]> git.ipfire.org Git - thirdparty/man-pages.git/blame - CONTRIBUTING.d/patches
CONTRIBUTING.d/patches: Add git-send-email(1) configuration for To and Cc
[thirdparty/man-pages.git] / CONTRIBUTING.d / patches
CommitLineData
beb01a3c
AC
1Name
2 Patches - instructions for contributing patches
3
4Description
5 If you know how to fix a problem in a manual page (if not, see
6 <CONTRIBUTING.d/bugs>), then send a patch in an email.
7
8 - Follow the instructions for sending mail to the mailing list
44ca9163
AC
9 from <CONTRIBUTING.d/mail>. See also "Send the patches"
10 below.
beb01a3c
AC
11
12 - The subject of the email should contain "[patch]" in the
13 subject line.
14
15 The above is the minimum needed so that someone might respond to
16 your patch. If you did that and someone does not respond within
17 a few days, then ping the email thread, "replying to all". Make
18 sure to send it to the maintainers in addition to the mailing
19 list.
20
21 To make your patch even more useful, please note the following
22 points:
23
24 - Write a suitable subject line. Make sure to mention the
25 name(s) of the page(s) being patched. Example:
26
27 [patch] shmop.2: Add "(void *)" cast to RETURN VALUE
28
29 - Sign your patch with "Signed-off-by:". Read about the
30 "Developer's Certificate of Origin" at
31 <https://www.kernel.org/doc/Documentation/process/submitting-patches.rst>.
32 When appropriate, other tags documented in that file, such as
33 "Reported-by:", "Reviewed-by:", "Acked-by:", and
34 "Suggested-by:" can be added to the patch. The man-pages
35 project also uses a "Cowritten-by:" tag with the obvious
36 meaning. Example:
37
38 Signed-off-by: Alejandro Colomar <alx@kernel.org>
39
40 - Describe how you obtained the information in your patch. For
41 example, was it:
42
43 - by reading (or writing) the relevant kernel or (g)libc
44 source code? Please provide a pointer to the following
45 code.
46
47 - from a commit message in the kernel or (g)libc source code
48 repository? Please provide a commit ID.
49
50 - by writing a test program? Send it with the patch, but
51 please make sure it's as simple as possible, and provide
52 instructions on how to use it and/or a demo run.
53
54 - from a standards document? Please name the standard, and
55 quote the relevant text.
56
57 - from other documentation? Please provide a pointer to that
58 documentation.
59
60 - from a mailing list or online forum? Please provide a URL
61 if possible.
62
63 - Send patches in diff -u format in an email patch. You may
64 find it useful to employ git-send-email(1) and
65 git-format-patch(1).
66
67 - Where relevant, include source code comments that cite commit
68 hashes for relevant kernel or glibc changes:
69
70 .\" commit <40-character-git-hash>
71
72 - For trivial patches, you can use subject tags:
73
74 - ffix: Formatting fix.
75 - tfix: Typo fix.
76 - wfix: Minor wording fix.
77 - srcfix: Change to manual page source that doesn't affect
78 the output.
79
80 Example:
81
82 [patch] tcp.7: tfix
83
84 - Send logically separate patches. For unrelated pages, or for
85 logically-separate issues in the same page, send separate
86 emails.
87
88 - Make patches against the latest version of the manual page.
89 Use git(1) for getting the latest version.
90
44ca9163
AC
91
92 Send the patches
93 We recommend using git-send-email(1) to send the patches to the
94 mailing list. For instructions on how to configure and use it,
95 see <https://git-send-email.io/>. It can also be configured to
96 use mutt(1) as a driver, which only requires the following
97 section in <~/.gitconfig> (assuming mutt(1) is already configured
98 for sending mail):
99
100 [sendemail]
101 sendmailcmd = mutt -H - && true
102
37908fd2
AC
103 In <man-pages/.git/config>, the following configuration will
104 simplify sending to the right addresses:
105
106 [sendemail]
107 to = Alejandro Colomar <alx@kernel.org>
108 cc = linux-man@vger.kernel.org
109
44ca9163
AC
110 Sign the patches with PGP
111 See <CONTRIBUTING.d/mail> for more details on signing your mail
112 to the list. git-send-email(1) can be configured to use a recent
113 version of neomutt(1) (>= 20240201), to sign patches with PGP
114 (assuming neomutt(1) is already configured for sending signed
115 mail). neomutt(1)'s -C flag enables crypto:
116
117 [sendemail]
118 sendmailcmd = neomutt -C -H - && true
119
beb01a3c
AC
120See also
121 CONTRIBUTING
122 CONTRIBUTING.d/*
123
124 <https://www.kernel.org/doc/Documentation/process/submitting-patches.rst>
44ca9163
AC
125 <https://git-send-email.io/>
126 <https://neomutt.org/feature/cli-crypto>