]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Simplify tui_source_window_base::show_source_content
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
2ad52f6f
TT
12019-09-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-winsource.h (struct tui_source_window_base)
4 <show_source_content>: Now private.
5 * tui/tui-winsource.c
6 (tui_source_window_base::show_source_content): Don't handle empty
7 content case.
8
b3b1bde6
TT
92019-09-20 Tom Tromey <tom@tromey.com>
10
11 * tui/tui-layout.c (show_source_disasm_command)
12 (show_source_or_disasm_and_command): Don't call
13 show_source_content.
14
71a25ed2
TT
152019-09-20 Tom Tromey <tom@tromey.com>
16
17 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
18 Declare.
19 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
20 from tui_make_status_line.
21 (tui_locator_window::rerender): Update.
22
f8532154
TT
232019-09-20 Tom Tromey <tom@tromey.com>
24
25 * tui/tui-stack.c (tui_make_status_line): Return std::string.
26 (tui_locator_window::rerender): Update.
27
2d81b349
TT
282019-09-20 Tom Tromey <tom@tromey.com>
29
30 * tui/tui-winsource.h (struct tui_source_window_base)
31 <~tui_source_window_base>: Don't declare.
32 <fullname>: Remove.
33 * tui/tui-winsource.c (~tui_source_window_base): Remove.
34 * tui/tui-source.h (struct tui_source_window) <fullname>: New
35 member.
36 * tui/tui-source.c (tui_source_window::set_contents): Update.
37 (tui_source_window::location_matches_p)
38 (tui_source_window::maybe_update): Update.
39
f14bec58
TT
402019-09-20 Tom Tromey <tom@tromey.com>
41
42 * tui/tui-winsource.h (~tui_source_element): Remove.
43 (tui_source_element): Update.
44 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
45 * tui/tui-winsource.c (tui_show_source_line): Update.
46 * tui/tui-source.c (tui_source_window::set_contents): Update.
47 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
48
78d5933a
TT
492019-09-20 Tom Tromey <tom@tromey.com>
50
51 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
52 declare.
53 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
54 tui_clear_source_windows_detail.
55 * tui/tui-winsource.h (struct tui_source_window_base)
56 <clear_detail>: Don't declare.
57 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
58 Remove.
59 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
60
d4207696
TT
612019-09-20 Tom Tromey <tromey@adacore.com>
62
63 PR ada/24919:
64 * block.c (contained_in): Fix final return value.
65
00f93c44
AM
662019-09-20 Alan Modra <amodra@gmail.com>
67
68 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
69 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
70 (read_indirect_string_from_dwz): Use bfd accessor.
71 * dwarf2read.h (struct dwz_file <filename>): Likewise.
72 * machoread.c (macho_symfile_read_all_oso): Likewise.
73 * solib.c (solib_bfd_open): Likewise.
74
e4153ae6
CB
752019-09-19 Christian Biesinger <cbiesinger@google.com>
76
77 * eval.c: Move declaration of overload_resolution to...
78 * value.h: ...here.
79
c7ae7675
CB
802019-09-19 Christian Biesinger <cbiesinger@google.com>
81
82 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
83 * arm-linux-tdep.c: Likewise.
84 * arm-nbsd-nat.c: Likewise.
85 * arm-tdep.h: Declare arm_apcs_32.
86 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
87
e86f08d2
CB
882019-09-19 Christian Biesinger <cbiesinger@google.com>
89
90 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
91 * dwarf2read.h: Declare dwarf_always_disassemble.
92
f64e2f40
TV
932019-09-19 Tom de Vries <tdevries@suse.de>
94
95 PR gdb/25009
96 * source-cache.c (source_cache::ensure): Catch exception thrown during
97 construction of the highlighter.
98
fd361982
AM
992019-09-18 Alan Modra <amodra@gmail.com>
100
101 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
102 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
103 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
104 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
105 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
106 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
107 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
108 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
109 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
110 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
111 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
112 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
113 * solib-spu.c, * solib-svr4.c, * solib-target.c,
114 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
115 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
116 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
117 * mi/mi-interp.c: Update throughout for bfd section macro and
118 function changes.
119 * gcore (gcore_create_callback): Use bfd_set_section_lma.
120 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
121
11061048
TT
1222019-09-18 Tom Tromey <tom@tromey.com>
123
124 * NEWS: Add entry.
125 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
126 call rl_initialize.
127 (tui_enable): Do not call rl_initialize.
128
7a27b85f
CG
1292019-09-18 Christian Groessler <chris@groessler.org>
130
131 * alpha-linux-nat.c: Include gdbarch.h.
132
f64eea3a
SM
1332019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
134
135 * ui-file.c: Include cli/cli-style.h.
136 (term_cli_styling): Remove cli_styling declaration.
137
e6f7f6d1
AM
1382019-09-18 Alan Modra <amodra@gmail.com>
139
140 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
141 to bfd_asymbol_section.
142
1d38e9d1
AM
1432019-09-18 Alan Modra <amodra@gmail.com>
144
145 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
146 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
147 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
148
90d92a63
AM
1492019-09-18 Alan Modra <amodra@gmail.com>
150
151 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
152 * spu-linux-nat.c (spu_bfd_open): Likewise.
153
a3d181d2
CB
1542019-09-18 Christian Biesinger <cbiesinger@google.com>
155
156 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
157 to bool to match definition in dwarf2read.c.
158
491144b5
CB
1592019-09-17 Christian Biesinger <cbiesinger@google.com>
160
161 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
162 (print_signatures): Likewise.
163 (trust_pad_over_xvs): Likewise.
164 * arch/aarch64-insn.c (aarch64_debug): Likewise.
165 * arch/aarch64-insn.h (aarch64_debug): Likewise.
166 * arm-linux-nat.c (arm_apcs_32): Likewise.
167 * arm-linux-tdep.c (arm_apcs_32): Likewise.
168 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
169 * arm-tdep.c (arm_debug): Likewise.
170 (arm_apcs_32): Likewise.
171 * auto-load.c (debug_auto_load): Likewise.
172 (auto_load_gdb_scripts): Likewise.
173 (global_auto_load): Likewise.
174 (auto_load_local_gdbinit): Likewise.
175 (auto_load_local_gdbinit_loaded): Likewise.
176 * auto-load.h (global_auto_load): Likewise.
177 (auto_load_local_gdbinit): Likewise.
178 (auto_load_local_gdbinit_loaded): Likewise.
179 * breakpoint.c (disconnected_dprintf): Likewise.
180 (breakpoint_proceeded): Likewise.
181 (automatic_hardware_breakpoints): Likewise.
182 (always_inserted_mode): Likewise.
183 (target_exact_watchpoints): Likewise.
184 (_initialize_breakpoint): Update.
185 * breakpoint.h (target_exact_watchpoints): Change to bool.
186 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
187 * cli/cli-cmds.c (trace_commands): Likewise.
188 * cli/cli-cmds.h (trace_commands): Likewise.
189 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
190 to bool*.
191 * cli/cli-logging.c (logging_overwrite): Change to bool.
192 (logging_redirect): Likewise.
193 (debug_redirect): Likewise.
194 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
195 (struct boolean_option_def) <get_var_address_cb_>: Change return type
196 to bool.
197 <boolean_option_def>: Update.
198 (struct flag_option_def): Change default type of Context to bool
199 from int.
200 <flag_option_def>: Change return type of var_address_cb_ to bool*.
201 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
202 (get_setshow_command_value_string): Likewise.
203 * cli/cli-style.c (cli_styling): Change to bool.
204 (source_styling): Likewise.
205 * cli/cli-style.h (source_styling): Likewise.
206 (cli_styling): Likewise.
207 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
208 to bool.
209 * command.h (var_types): Update comment.
210 (add_setshow_boolean_cmd): Change int* var argument to bool*.
211 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
212 bool.
213 (debug_compile_cplus_scopes): Likewise.
214 * compile/compile-internal.h (compile_debug): Likewise.
215 * compile/compile.c (compile_debug): Likewise.
216 (struct compile_options) <raw>: Likewise.
217 * cp-support.c (catch_demangler_crashes): Likewise.
218 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
219 (usr_cmd_cris_dwarf2_cfi): Likewise.
220 * csky-tdep.c (csky_debug): Likewise.
221 * darwin-nat.c (enable_mach_exceptions): Likewise.
222 * dcache.c (dcache_enabled_p): Likewise.
223 * defs.h (info_verbose): Likewise.
224 * demangle.c (demangle): Likewise.
225 (asm_demangle): Likewise.
226 * dwarf-index-cache.c (debug_index_cache): Likewise.
227 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
228 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
229 * dwarf2read.c (check_physname): Likewise.
230 (use_deprecated_index_sections): Likewise.
231 (dwarf_always_disassemble): Likewise.
232 * eval.c (overload_resolution): Likewise.
233 * event-top.c (set_editing_cmd_var): Likewise.
234 (exec_done_display_p): Likewise.
235 * event-top.h (set_editing_cmd_var): Likewise.
236 (exec_done_display_p): Likewise.
237 * exec.c (write_files): Likewise.
238 * fbsd-nat.c (debug_fbsd_lwp): Likewise
239 (debug_fbsd_nat): Likewise.
240 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
241 Likewise.
242 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
243 <backtrace_past_entry> Likewise.
244 * gdb-demangle.h (demangle): Likewise.
245 (asm_demangle): Likewise.
246 * gdb_bfd.c (bfd_sharing): Likewise.
247 * gdbcore.h (write_files): Likewise.
248 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
249 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
250 * gdbthread.h (print_thread_events): Likewise.
251 * gdbtypes.c (opaque_type_resolution): Likewise.
252 (strict_type_checking): Likewise.
253 * gnu-nat.c (gnu_debug_flag): Likewise.
254 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
255 * guile/scm-param.c (pascm_variable): Add boolval.
256 (add_setshow_generic): Update.
257 (pascm_param_value): Update.
258 (pascm_set_param_value_x): Update.
259 * hppa-tdep.c (hppa_debug): Change to bool..
260 * infcall.c (may_call_functions_p): Likewise.
261 (coerce_float_to_double_p): Likewise.
262 (unwind_on_signal_p): Likewise.
263 (unwind_on_terminating_exception_p): Likewise.
264 * infcmd.c (startup_with_shell): Likewise.
265 * inferior.c (print_inferior_events): Likewise.
266 * inferior.h (startup_with_shell): Likewise.
267 (print_inferior_events): Likewise.
268 * infrun.c (step_stop_if_no_debug): Likewise.
269 (detach_fork): Likewise.
270 (debug_displaced): Likewise.
271 (disable_randomization): Likewise.
272 (non_stop): Likewise.
273 (non_stop_1): Likewise.
274 (observer_mode): Likewise.
275 (observer_mode_1): Likewise.
276 (set_observer_mode): Update.
277 (sched_multi): Change to bool.
278 * infrun.h (debug_displaced): Likewise.
279 (sched_multi): Likewise.
280 (step_stop_if_no_debug): Likewise.
281 (non_stop): Likewise.
282 (disable_randomization): Likewise.
283 * linux-tdep.c (use_coredump_filter): Likewise.
284 (dump_excluded_mappings): Likewise.
285 * linux-thread-db.c (auto_load_thread_db): Likewise.
286 (check_thread_db_on_load): Likewise.
287 * main.c (captured_main_1): Update.
288 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
289 xx2_opt, boolean_opt>: Change to bool.
290 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
291 * maint.c (maintenance_profile_p): Likewise.
292 (per_command_time): Likewise.
293 (per_command_space): Likewise.
294 (per_command_symtab): Likewise.
295 * memattr.c (inaccessible_by_default): Likewise.
296 * mi/mi-main.c (mi_async): Likewise.
297 (mi_async_1): Likewise.
298 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
299 * nat/fork-inferior.h (startup_with_shell): Likewise.
300 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
301 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
302 * nios2-tdep.c (nios2_debug): Likewise.
303 * or1k-tdep.c (or1k_debug): Likewise.
304 * parse.c (parser_debug): Likewise.
305 * parser-defs.h (parser_debug): Likewise.
306 * printcmd.c (print_symbol_filename): Likewise.
307 * proc-api.c (procfs_trace): Likewise.
308 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
309 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
310 (set_parameter_value): Update.
311 (add_setshow_generic): Update.
312 * python/py-value.c (copy_py_bool_obj): Change argument from int*
313 to bool*.
314 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
315 int*.
316 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
317 * record-btrace.c (record_btrace_target::store_registers): Update.
318 * record-full.c (record_full_memory_query): Change to bool.
319 (record_full_stop_at_limit): Likewise.
320 * record-full.h (record_full_memory_query): Likewise.
321 * remote-notif.c (notif_debug): Likewise.
322 * remote-notif.h (notif_debug): Likewise.
323 * remote.c (use_range_stepping): Likewise.
324 (interrupt_on_connect): Likewise.
325 (remote_break): Likewise.
326 * ser-tcp.c (tcp_auto_retry): Likewise.
327 * ser-unix.c (serial_hwflow): Likewise.
328 * skip.c (debug_skip): Likewise.
329 * solib-aix.c (solib_aix_debug): Likewise.
330 * spu-tdep.c (spu_stop_on_load_p): Likewise.
331 (spu_auto_flush_cache_p): Likewise.
332 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
333 Likewise.
334 (struct info_print_options) <quiet>: Likewise.
335 * symfile-debug.c (debug_symfile): Likewise.
336 * symfile.c (auto_solib_add): Likewise.
337 (separate_debug_file_debug): Likewise.
338 * symfile.h (auto_solib_add): Likewise.
339 (separate_debug_file_debug): Likewise.
340 * symtab.c (basenames_may_differ): Likewise.
341 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
342 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
343 (struct info_types_options) <quiet>: Likewise.
344 * symtab.h (demangle): Likewise.
345 (basenames_may_differ): Likewise.
346 * target-dcache.c (stack_cache_enabled_1): Likewise.
347 (code_cache_enabled_1): Likewise.
348 * target.c (trust_readonly): Likewise.
349 (may_write_registers): Likewise.
350 (may_write_memory): Likewise.
351 (may_insert_breakpoints): Likewise.
352 (may_insert_tracepoints): Likewise.
353 (may_insert_fast_tracepoints): Likewise.
354 (may_stop): Likewise.
355 (auto_connect_native_target): Likewise.
356 (target_stop_and_wait): Update.
357 (target_async_permitted): Change to bool.
358 (target_async_permitted_1): Likewise.
359 (may_write_registers_1): Likewise.
360 (may_write_memory_1): Likewise.
361 (may_insert_breakpoints_1): Likewise.
362 (may_insert_tracepoints_1): Likewise.
363 (may_insert_fast_tracepoints_1): Likewise.
364 (may_stop_1): Likewise.
365 * target.h (target_async_permitted): Likewise.
366 (may_write_registers): Likewise.
367 (may_write_memory): Likewise.
368 (may_insert_breakpoints): Likewise.
369 (may_insert_tracepoints): Likewise.
370 (may_insert_fast_tracepoints): Likewise.
371 (may_stop): Likewise.
372 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
373 (make_thread_apply_all_options_def_group): Change argument from int*
374 to bool*.
375 (thread_apply_all_command): Update.
376 (print_thread_events): Change to bool.
377 * top.c (confirm): Likewise.
378 (command_editing_p): Likewise.
379 (history_expansion_p): Likewise.
380 (write_history_p): Likewise.
381 (info_verbose): Likewise.
382 * top.h (confirm): Likewise.
383 (history_expansion_p): Likewise.
384 * tracepoint.c (disconnected_tracing): Likewise.
385 (circular_trace_buffer): Likewise.
386 * typeprint.c (print_methods): Likewise.
387 (print_typedefs): Likewise.
388 * utils.c (debug_timestamp): Likewise.
389 (sevenbit_strings): Likewise.
390 (pagination_enabled): Likewise.
391 * utils.h (sevenbit_strings): Likewise.
392 (pagination_enabled): Likewise.
393 * valops.c (overload_resolution): Likewise.
394 * valprint.h (struct value_print_options) <prettyformat_arrays,
395 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
396 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
397 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
398 Likewise.
399 * windows-nat.c (new_console): Likewise.
400 (cygwin_exceptions): Likewise.
401 (new_group): Likewise.
402 (debug_exec): Likewise.
403 (debug_events): Likewise.
404 (debug_memory): Likewise.
405 (debug_exceptions): Likewise.
406 (useshell): Likewise.
407 * windows-tdep.c (maint_display_all_tib): Likewise.
408 * xml-support.c (debug_xml): Likewise.
409
f1b620e9
MG
4102019-09-17 Mike Gulick <mgulick@mathworks.com>
411
412 * source.c (prepare_path_for_appending): New function.
413 (openp): Make use of new function.
414 (find_and_open_source): Search for the compilation directory and
415 source file as a relative path beneath the directory search path.
416
67f3ed6a
AB
4172019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
418
419 * source-cache.c (source_cache::get_line_charpos): Catch
420 exceptions and return false, this matches the behaviour documented
421 in the header file.
422
74332189
JB
4232019-09-17 Joel Brobecker <brobecker@adacore.com>
424
425 * ada-tasks.c (info_task): Remove quoting of the task's name.
426
f2f24aa9
CB
4272019-09-16 Christian Biesinger <cbiesinger@google.com>
428
429 * symfile.c (auto_solib_add): Replace comment with a reference
430 to the header file.
431
6a062a93
CB
4322019-09-14 Christian Biesinger <cbiesinger@google.com>
433
434 * NEWS: Mention that gdb can now be compiled with Python 3
435 on Windows.
436
ec6c8338
AB
4372019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
438
439 * maint.c (maint_print_section_data::maint_print_section_data):
440 Force use of 'float log10 (float)' by casting the argument to
441 float.
442
aa17805f
AB
4432019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
444
445 * maint.c: Add 'cmath' include.
446 (struct maint_print_section_data): New structure.
447 (print_section_index): New function.
448 (print_bfd_section_info): Add header comment, small whitespace
449 cleanup, and update to call new print_section_index function.
450 (print_objfile_section_info): Likewise.
451 (maint_obj_section_from_bfd_section): New function.
452 (print_bfd_section_info_maybe_relocated): New function.
453 (maintenance_info_sections): Add header comment, always use
454 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
455
3dd9bb46
AB
4562019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
457
458 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
459 inner scope, add check that the objfile has psymtabs before
460 checking psymtabs_addrmap.
461 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
462
4993045d
PW
4632019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
464
465 * NEWS: Announce that Ada task names are now shown at more places,
466 and between quotes (except in info task output).
467 * gdb/ada-tasks.c (task_to_str): New function.
468 (display_current_task_id): Call task_to_str.
469 (task_command_1): Likewise.
470 (print_ada_task_info): In non-mi mode, Properly align headers and data
471 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
472
7a289707
RO
4732019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
474
475 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
476 prstatus.pr_lwp.pr_info instead of making it up.
477
f2aec7f6
CB
4782019-09-11 Christian Biesinger <cbiesinger@google.com>
479
480 * auto-load.c (auto_load_expand_dir_vars): Update.
481 * defs.h (gdb_datadir): Change to std::string.
482 (python_libdir): Likewise.
483 (relocate_gdb_directory): Change return type to std::string.
484 * guile/guile.c (gdbscm_data_directory): Update.
485 (initialize_scheme_side): Update.
486 * jit.c (jit_reader_dir): Change to std::string.
487 (jit_reader_load_command): Update.
488 * main.c (gdb_datadir): Change to std::string.
489 (python_libdir): Likewise.
490 (set_gdb_data_directory): Update.
491 (relocate_path): Change to return std::string.
492 (relocate_gdb_directory): Change to return std::string.
493 (relocate_gdbinit_path_maybe_in_datadir): Update.
494 (captured_main_1): Update.
495 * python/python.c (do_start_initialization): Update.
496 * top.c (show_gdb_datadir): Update.
497 * xml-syscall.c (xml_init_syscalls_info): Update.
498 (init_syscalls_info): Update.
499
9224a013
CB
5002019-09-11 Christian Biesinger <cbiesinger@google.com>
501
502 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
503 out of get_init_files.
504 (get_init_files): Update.
505
f48cd836
CB
5062019-09-11 Christian Biesinger <cbiesinger@google.com>
507
508 * main.c (get_init_files): Change to use std::string.
509 (captured_main_1): Update.
510 (print_gdb_help): Update.
511
9cab7ecd
AT
5122019-09-11 Ali Tamur <tamur@google.com>
513
514 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
515 implementation.
516
67547d89
CB
5172019-09-11 Christian Biesinger <cbiesinger@google.com>
518
519 * dbxread.c (read_dbx_symtab): Update.
520 * dwarf2read.c (load_partial_dies): Update.
521 * mdebugread.c (parse_partial_symbols): Update.
522 (handle_psymbol_enumerators): Update.
523 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
524 * psymtab.c (add_psymbol_to_bcache): Likewise.
525 (add_psymbol_to_list): Likewise.
526 * symtab.c (symbol_set_names): Likewise.
527 * symtab.h (symbol_set_names): Likewise.
528 * xcoffread.c (scan_xcoff_symtab): Update.
529
64b2d4a0
TT
5302019-09-11 Tom Tromey <tom@tromey.com>
531
532 * symfile-mem.c (symbol_file_add_from_memory): Use
533 bfd_set_filename.
534 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
535 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
536
3b00ef10
TT
5372019-09-10 Tom Tromey <tromey@adacore.com>
538
539 * dwarf-index-write.c (write_psymbols): Extend error message.
540 (debug_names::insert): Add Ada code.
541 (debug_names::write_psymbols): Remove Ada check.
542 (debug_names) <m_string_obstack>: New member.
543 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
544 (gdb_index_symbol_name_matcher::matches): Remove.
545 (mapped_index_base::find_name_components_bounds): Add "lang"
546 parameter.
547 (mapped_index_base::build_name_components): Also split names
548 according to Ada syntax.
549 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
550 type of "match_callback".
551 (check_match, check_find_bounds_finds)
552 (dw2_expand_symtabs_matching): Update.
553 (dw2_debug_names_iterator): Add new constructor.
554 (dw2_debug_names_map_matching_symbols): New function.
555 (dw2_debug_names_expand_symtabs_matching): Update.
556 (dwarf2_debug_names_functions): Use
557 dw2_debug_names_map_matching_symbols.
558
aa391654
TT
5592019-09-10 Tom Tromey <tromey@adacore.com>
560
561 * dwarf2read.c (dw2_get_file_names_reader): Add the
562 CU's file name to the results.
563
b054970d
TT
5642019-09-10 Tom Tromey <tromey@adacore.com>
565
566 * ada-lang.c (add_nonlocal_symbols): Combine calls to
567 map_matching_symbols. Update.
568 * dwarf2read.c (dw2_map_matching_symbols): Update.
569 * psymtab.c (match_partial_symbol): Change type; update.
570 (psym_map_matching_symbols): Likewise.
571 * symfile-debug.c (debug_qf_map_matching_symbols): Change
572 type; update.
573 * symfile.h (struct quick_symbol_functions)
574 <map_matching_symbols>: Change "name" to be a lookup_name_info.
575 Remove "match".
576
6a3dbf1b
TT
5772019-09-10 Tom Tromey <tromey@adacore.com>
578
579 * psymtab.c (map_block): Remove.
580 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
581 * symtab.c (iterate_over_symbols_terminated): New function.
582 * symtab.c (iterate_over_symbols_terminated): Declare.
583
6969f124
TT
5842019-09-10 Tom Tromey <tromey@adacore.com>
585
586 * ada-lang.c (ada_iterate_over_symbols): Return bool.
587 * language.h (struct language_defn) <la_iterate_over_symbols>:
588 Return bool.
589 * symtab.c (iterate_over_symbols): Return bool.
590 * symtab.h (iterate_over_symbols): Return bool.
591
199b4314
TT
5922019-09-10 Tom Tromey <tromey@adacore.com>
593
594 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
595 (add_nonlocal_symbols): Update.
596 * dwarf2read.c (dw2_map_matching_symbols): Change type.
597 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
598 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
599 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
600 Change type of "callback". Remove "data".
601
a084a2a6
AT
602
6032019-09-09 Ali Tamur <tamur@google.com>
604
605 * dwarf2read.c (comp_unit_head): Update comment.
606 (dwarf2_dwo_name): New function declaration.
607 (dwarf_unit_type_name): New function declaration.
608 (read_comp_unit_head): Add support for new compilation units,
609 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
610 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
611 (currently named as "signature") in their header. Also clarify error
612 messages.
613 (lookup_dwo_id): New function. Returns the dwo id of the given
614 compile unit.
615 (lookup_dwo_unit): Use the new lookup_dwo_id function.
616 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
617 functions.
618 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
619 (dwarf2_dwo_name): Get the dwo name if present.
620 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
621 purposes.
622
25a2915e
TT
6232019-09-09 Tom Tromey <tom@tromey.com>
624
625 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
626
e4df0874
PW
6272019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
628
629 * python/python.c (do_start_initialization): Make progname_copy static,
630 to avoid a leak report.
631
8634b462
TT
6322019-09-08 Tom Tromey <tom@tromey.com>
633
634 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
635
c7f839cb
SM
6362019-09-07 Simon Marchi <simon.marchi@efficios.com>
637
638 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
639 Change type to gdb::optional<block_enum>.
640 (dw2_symtab_iter_init): Change block_index parameter type
641 to gdb::optional<block_enum>.
642 (dw2_lookup_symbol): Change block_index parameter
643 type to block_enum.c
644 (dw2_debug_names_lookup_symbol): Likewise.
645 * psymtab.c (psym_lookup_symbol): Likewise.
646 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
647 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
648 Likewise.
649
ead0e69a
CB
6502019-09-06 Christian Biesinger <cbiesinger@google.com>
651
652 * defs.h (relocate_gdb_directory): Change int to bool in
653 signature and rename flag to relocatable.
654 * main.c (relocate_path): Likewise.
655 (relocate_gdb_directory): Likewise.
656
b16c44de
AM
6572019-09-06 Alan Modra <amodra@gmail.com>
658
659 * coffread.c (coff_symfile_read): Constify filename variable.
660 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
661 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
662 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
663 * solib.c (reload_shared_libraries_1): Likewise.
664 * symfile.c (reread_symbols): Likewise.
665 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
666 * solib-darwin.c (darwin_bfd_open): Likewise.
667 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
668
06ff036e
AB
6692019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
670
671 * psymtab.c (print_partial_symbols): Handle missing domain_enum
672 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
673
4e962e74
TT
6742019-09-03 Tom Tromey <tromey@adacore.com>
675
676 * ada-valprint.c (ada_val_print_num): Don't recurse for range
677 types.
678 (has_negatives): Unbias a range type bound.
679 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
680 * gdbtypes.c (operator==): Handle new field.
681 (create_range_type): Add "bias" parameter.
682 (create_static_range_type, resolve_dynamic_range): Update.
683 * gdbtypes.h (struct range_bounds) <bias>: New member.
684 (create_range_type): Add bias parameter.
685 * printcmd.c (print_scalar_formatted): Unbias range types.
686 * value.c (unpack_long): Unbias range types.
687 (pack_long): Bias range types.
688
d90b8f26
AH
6892019-09-02 Alan Hayward <alan.hayward@arm.com>
690
691 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
692 probe arguments.
693
fe01123e
AH
6942019-09-02 Alan Hayward <alan.hayward@arm.com>
695
696 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
697 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
698 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
699 (compile_probe_arg): Likewise.
700 * probe.h (get_argument_count): Likewise.
701 * solib-svr4.c (solib_event_probe_action): Likewise.
702 * stap-probe.c (stap_probe::get_argument_count): Likewise.
703
e661ef01
AH
7042019-09-02 Alan Hayward <alan.hayward@arm.com>
705
706 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
707 code to here...
708 (svr4_create_solib_event_breakpoints): ...from here.
709
47a536d9
SDJ
7102019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
711
712 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
713 suffix from warning message.
714
d6a00eba
TT
7152019-08-30 Tom Tromey <tom@tromey.com>
716
717 * tui/tui-winsource.h (struct tui_source_window_base)
718 <refresh_all>: Don't declare.
719 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
720 Remove.
721 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
722 tui_show_locator_content.
723 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
724 declare.
725 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
726 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
727 declare.
728
55b2657b
TT
7292019-08-30 Tom Tromey <tom@tromey.com>
730
731 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
732
12a8555a
TT
7332019-08-30 Tom Tromey <tom@tromey.com>
734
735 * tui/tui-stack.c (_initialize_tui_stack): Move later.
736 Remove unnecessary forward declarations.
737
900ac242
TT
7382019-08-30 Tom Tromey <tom@tromey.com>
739
740 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
741 rerender.
742 (tui_update_locator_fullname, tui_show_frame_info): Don't call
743 tui_show_locator_content.
744
99ab33fb
TT
7452019-08-30 Tom Tromey <tom@tromey.com>
746
747 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
748 (tui_locator_window::rerender): Rewrite using body of previous
749 tui_show_locator_content.
750
e594a5d1
TT
7512019-08-30 Tom Tromey <tom@tromey.com>
752
753 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
754 set_locator_fullname>: New methods.
755 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
756 Rename from tui_set_locator_fullname.
757 (tui_locator_window::set_locator_info): Rename from
758 tui_set_locator_info. Return bool.
759 (tui_update_locator_fullname, tui_show_frame_info): Update.
760
715bb467
TT
7612019-08-30 Tom Tromey <tom@tromey.com>
762
763 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
764
772f3f03
TT
7652019-08-30 Tom Tromey <tom@tromey.com>
766
767 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
768 call touchwin.
769
108e13ab
TT
7702019-08-30 Tom Tromey <tom@tromey.com>
771
772 * tui/tui-wingeneral.c (box_win): Assume win_info and
773 win_info->handle cannot be NULL.
774
cdaa6eb4
TT
7752019-08-30 Tom Tromey <tom@tromey.com>
776
777 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
778 refresh_window>: Declare.
779 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
780 resize.
781 (tui_data_item_window::rerender): Rename from
782 tui_display_register.
783 (tui_data_item_window::refresh_window): New method.
784 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
785 no-op.
786
89df7f90
TT
7872019-08-30 Tom Tromey <tom@tromey.com>
788
789 * tui/tui-regs.h (struct tui_data_window) <regs_content,
790 regs_column_count, current_group>: Move later. Now private.
791 <get_current_group>: New method.
792 * tui/tui-regs.c (tui_reg_command): Update.
793 * tui/tui-layout.c (tui_set_layout): Update.
794
1bf2866a
TT
7952019-08-30 Tom Tromey <tom@tromey.com>
796
797 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
798 (tui_data_window::rerender): Don't call
799 check_and_display_highlight_if_needed.
800 (tui_data_window::refresh_all): Remove call to
801 erase_data_content.
802
0670413d
TT
8032019-08-30 Tom Tromey <tom@tromey.com>
804
805 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
806 (tui_data_window::display_registers_from)
807 (tui_data_window::display_reg_element_at_line)
808 (tui_data_window::display_registers_from_line): Remove checks of
809 "empty".
810
18bb55c7
TT
8112019-08-30 Tom Tromey <tom@tromey.com>
812
813 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
814 Don't declare.
815 * tui/tui-regs.c (tui_data_window::show_registers): Call
816 rerender.
817 (tui_data_window::rerender): Rename from display_all_data.
818 (tui_data_window::rerender): Remove old implementation.
819
1f6d2f10
TT
8202019-08-30 Tom Tromey <tom@tromey.com>
821
822 * tui/tui-regs.c (tui_data_window::display_all_data): Change
823 text.
824 * tui/tui-data.h (NO_DATA_STRING): Remove define.
825
16d01f9c
BW
8262019-08-29 Bernhard Wodok <barto@gmx.net>
827 Sergio Durigan Junior <sergiodj@redhat.com>
828
829 PR win32/24284
830 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
831
d8f27c60
AB
8322019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
833
834 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
835 when searching for types.
836
1f20c35e
AB
8372019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
838
839 * f-lang.c (f_language_defn): Use f_print_typedef.
840 * f-lang.h (f_print_typedef): Declare.
841 * f-typeprint.c (f_print_typedef): Define.
842
550105b7
CB
8432019-08-27 Christian Biesinger <cbiesinger@google.com>
844
845 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
846
4acfdd20
AB
8472019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
848
849 * cli/cli-utils.c (info_print_options_defs): Delete.
850 (make_info_print_options_def_group): Delete.
851 (extract_info_print_options): Delete.
852 (info_print_command_completer): Delete.
853 (info_print_args_help): Add extra parameter, and optionally
854 include text about -n flag.
855 * cli/cli-utils.h (struct info_print_options): Delete.
856 (extract_info_print_options): Delete declaration.
857 (info_print_command_completer): Delete declaration.
858 (info_print_args_help): Add extra parameter, extend header
859 comment.
860 * python/python.c (gdbpy_rbreak): Pass additional parameter to
861 search_symbols.
862 * stack.c (struct info_print_options): New type.
863 (info_print_options_defs): New file scoped variable.
864 (make_info_print_options_def_group): New static function.
865 (info_print_command_completer): New static function.
866 (info_locals_command): Update to use new local functions.
867 (info_args_command): Likewise.
868 (_initialize_stack): Add extra parameter to calls to
869 info_print_args_help.
870 * symtab.c (search_symbols): Add extra parameter, use this to
871 possibly excluse non-debug symbols.
872 (symtab_symbol_info): Add extra parameter, which is passed on to
873 search_symbols.
874 (struct info_print_options): New type.
875 (info_print_options_defs): New file scoped variable.
876 (make_info_print_options_def_group): New static function.
877 (info_print_command_completer): New static function.
878 (info_variables_command): Update to use local functions, and pass
879 extra parameter through to symtab_symbol_info.
880 (info_functions_command): Likewise.
881 (info_types_command): Pass additional argument through to
882 symtab_symbol_info.
883 (rbreak_command): Pass extra argument to search_symbols.
884 (_initialize_symtab): Add extra arguments for calls to
885 info_print_args_help, and update help text for 'info variables',
886 'whereis', and 'info functions' commands.
887 * symtab.h (search_symbols): Add extra argument to declaration.
888 * NEWS: Mention new flags.
889
9aa55206
CB
8902019-08-26 Christian Biesinger <cbiesinger@google.com>
891
892 * symtab.c (lookup_static_symbol): Call the new function (and move
893 it down to be next to lookup_global_symbol).
894 (struct global_sym_lookup_data): Add block_enum member and rename to...
895 (struct global_or_static_sym_lookup_data): ...this.
896 (lookup_symbol_global_iterator_cb): Pass block_index instead of
897 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
898 (lookup_symbol_global_or_static_iterator_cb): ...this.
899 (lookup_global_or_static_symbol): New function.
900 (lookup_global_symbol): Call new function.
901
5c31b358
TV
9022019-08-26 Tom de Vries <tdevries@suse.de>
903
904 PR c++/24852
905 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
906 when pc_probe.prob == NULL.
907
23c13d42
SM
9082019-08-25 Simon Marchi <simon.marchi@efficios.com>
909
910 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
911 variable symbol_linkage to symbol_linkage_.
912
beadd3e8
SM
9132019-08-25 Simon Marchi <simon.marchi@efficios.com>
914
915 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
916 represent whether the symbol is static, dynamic, or we don't
917 know.
918
e3ec872f
YS
9192019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
920
921 * gdb/rx-tdep.c (rx_register_names): New.
922 (rx_register_name): Delete.
923 (rx_psw_type): Delete.
924 (rx_fpsw_type): Delete.
925 (rx_register_type): Delete.
926 (rx_gdbarch_init): Convert target-descriptions.
927 (_initialize_rx_tdep): Add initialize_tdesc_rx.
928 * gdb/features/Makefile: Add rx.xml.
929 * gdb/features/rx.xml: New.
930 * gdb/features/rx.c: Generated.
931 * gdb/NEWS: Mention target description support.
932
d0509ba4
CB
9332019-08-22 Christian Biesinger <cbiesinger@google.com>
934
935 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
936 *slot_ptr.
937
2d41fa11
SDJ
9382019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
939
940 * configure.ac: Don't check for 'dlfcn.h' (moved to
941 gdbsupport/common.m4).
942 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
943 'gdbsupport/'.
944 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
945 * compile/compile-c-support.c: Include
946 'gdbsupport/gdb-dlfcn.h'.
947 * gdbsupport/common.m4: Check for 'dlfcn.h'.
948 * gdb-dlfcn.c: Move to...
949 * gdbsupport/gdb-dlfcn.c: ... here.
950 * gdb-dlfcn.h: Move to...
951 * gdbsupport/gdb-dlfcn.h: ... here.
952
de8af808
SL
9532019-08-23 Sandra Loosemore <sandra@codesourcery.com>
954
955 * nios2-tdep.c (struct reg_value): Improve comments. Make
956 the offset field signed.
957
27204489
CB
9582019-08-22 Christian Biesinger <cbiesinger@google.com>
959
960 * python/lib/gdb/__init__.py (_execute_file): New function.
961 * python/python.c (python_run_simple_file): Call gdb._execute_file
962 on Windows.
963
43771869
AB
9642019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
965
966 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
967 all uses as this was never set to anything but a zero value.
968
26c957f1
PA
9692019-08-21 Bogdan Harjoc <harjoc@gmail.com>
970
971 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
972
c07aae6e
CB
9732019-08-21 Christian Biesinger <cbiesinger@google.com>
974
975 * tui/tui-data.h (tui_gen_win_info): Add an =default
976 move constructor, required by some GCC versions.
977
3960cb7a
JF
9782019-08-21 Jinke Fan <fanjinke51@yeah.net>
979
980 * go32-nat.c (go32_sysinfo): Add hygon_p.
981
04c72a68
TT
9822019-08-20 Tom Tromey <tom@tromey.com>
983
984 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
985 line_from_reg_element_no, first_reg_element_no_inline,
986 display_all_data, delete_data_content_windows,
987 erase_data_content>: Now private.
988
072272ce
TT
9892019-08-20 Tom Tromey <tom@tromey.com>
990
991 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
992 (tui_unhighlight_win, tui_highlight_win)
993 (tui_win_info::make_window): Update.
994 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
995
973961bd
TT
9962019-08-20 Tom Tromey <tom@tromey.com>
997
998 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
999 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1000 (MAX_PID_WIDTH): Move to tui-stack.c.
1001 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1002 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1003 (MAX_PID_WIDTH): Move from tui-data.h.
1004
ab0e1f1a
TT
10052019-08-20 Tom Tromey <tom@tromey.com>
1006
1007 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1008 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1009 (box_win): Update.
1010 (tui_gen_win_info::make_window): Rename from tui_make_window.
1011 (tui_win_info::make_window): New method.
1012 (tui_gen_win_info::make_visible): Update.
1013 * tui/tui-source.c (tui_source_window::set_contents): Update.
1014 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1015 (tui_data_window::display_registers_from): Update.
1016 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1017 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1018 Declare.
1019 <can_box>: Remove.
1020 <title>: Remove.
1021 (struct tui_win_info) <make_window>: Declare.
1022 <can_box>: Now virtual.
1023 <title>: New member.
1024 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1025 * tui/tui-command.c (tui_cmd_window::resize): Update.
1026
100c2bf3
TT
10272019-08-20 Tom Tromey <tom@tromey.com>
1028
1029 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1030 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1031 (tui_data_window::check_register_values): Update.
1032
fa4dc567
TT
10332019-08-20 Tom Tromey <tom@tromey.com>
1034
1035 * tui/tui-regs.h (struct tui_data_window): Use
1036 DISABLE_COPY_AND_ASSIGN.
1037 <regs_content>: Change type, removing unique_ptr.
1038 <tui_data_window>: Add move constructor.
1039 * tui/tui-regs.c (tui_data_window::show_registers)
1040 (tui_data_window::show_register_group)
1041 (tui_data_window::display_registers_from)
1042 (tui_data_window::display_registers_from)
1043 (tui_data_window::first_data_item_displayed)
1044 (tui_data_window::delete_data_content_windows)
1045 (tui_data_window::rerender, tui_data_window::refresh_window)
1046 (tui_data_window::check_register_values): Update.
1047
ca02d7c8
TT
10482019-08-20 Tom Tromey <tom@tromey.com>
1049
1050 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1051 show_register_group>: Declare.
1052 (tui_show_register_group): Don't declare.
1053 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1054 tui_show_registers.
1055 (tui_data_window::show_register_group): Rename from
1056 tui_show_register_group.
1057 (tui_data_window::check_register_values, tui_reg_command):
1058 Update.
1059 * tui/tui-layout.c (tui_set_layout): Update.
1060
63356bfd
TT
10612019-08-20 Tom Tromey <tom@tromey.com>
1062
1063 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1064 Declare.
1065 (tui_check_register_values): Don't declare.
1066 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1067 from tui_check_register_values.
1068 * tui/tui-hooks.c (tui_register_changed): Update.
1069
42cc14a7
TT
10702019-08-20 Tom Tromey <tom@tromey.com>
1071
1072 * tui/tui-regs.c (tui_reg_layout): Move later.
1073 (tui_show_registers): Don't enable TUI mode or change layout.
1074
b9ad3686
TT
10752019-08-20 Tom Tromey <tom@tromey.com>
1076
1077 * tui/tui-regs.h (struct tui_data_item_window)
1078 <~tui_data_item_window>: Remove.
1079 <content>: Now a unique_xmalloc_ptr.
1080 * tui/tui-regs.c (tui_register_format): Return a
1081 unique_xmalloc_ptr.
1082 (tui_get_register): Update.
1083 (~tui_data_item_window): Remove.
1084 (tui_data_window::display_registers_from, tui_display_register):
1085 Update.
1086 * tui/tui-io.h (tui_expand_tabs): Update.
1087 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1088 Remove "col" parameter.
1089
8e114aab
TT
10902019-08-20 Tom Tromey <tom@tromey.com>
1091
1092 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1093 field.
1094 * tui/tui-regs.c (~tui_data_item_window): Update.
1095
1a4f81dd
TT
10962019-08-20 Tom Tromey <tom@tromey.com>
1097
1098 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1099 earlier.
1100
0f8d8876
TT
11012019-08-20 Tom Tromey <tom@tromey.com>
1102
1103 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1104
605dc2c2
TT
11052019-08-20 Tom Tromey <tom@tromey.com>
1106
1107 * tui/tui-source.h (struct tui_source_window): Update.
1108 * tui/tui-regs.c (tui_show_registers): Update.
1109 * tui/tui-disasm.h (struct tui_disasm_window): Update.
1110 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1111 (NO_REGS_STRING): Remove defines.
1112
aedbe3bb
CM
11132019-08-20 Conrad Meyer <cem@FreeBSD.org>
1114
1115 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1116 unnecessary thread walk if remote doesn't support the packet.
1117
7ce8f214
TT
11182019-08-19 Tom Tromey <tromey@adacore.com>
1119
1120 * python/py-value.c (value_has_field): Fix indentation.
1121
f21c2bd7
TT
11222019-08-19 Tom Tromey <tromey@adacore.com>
1123
1124 * printcmd.c (do_one_display, info_display_command): Update.
1125 * block.h (contained_in): Return bool. Add allow_nested
1126 parameter.
1127 * block.c (contained_in): Return bool. Add allow_nested
1128 parameter.
1129
d806ea2d
TT
11302019-08-19 Tom Tromey <tom@tromey.com>
1131
1132 * configure: Rebuild.
1133 * configure.ac: Disallow the combination of -static-libstdc++ and
1134 source highlight.
1135 * source-cache.c (get_language_name): Handle rust.
1136 (source_cache::get_source_lines): Ignore highlighting exceptions.
1137
398fdd60
TT
11382019-08-16 Tom Tromey <tom@tromey.com>
1139
1140 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1141 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1142 (struct tui_source_window_base) <make_visible, refresh_window,
1143 resize>: Remove methods.
1144 <execution_info>: Remove field.
1145 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1146 (tui_show_source_line, tui_source_window_base)
1147 (~tui_source_window_base): Update.
1148 (tui_source_window_base::resize)
1149 (tui_source_window_base::make_visible)
1150 (tui_source_window_base::refresh_window): Remove.
1151 (tui_source_window_base::update_exec_info): Update.
1152 * tui/tui-source.c (tui_source_window::set_contents): Update.
1153 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1154
e699d331
TT
11552019-08-16 Tom Tromey <tom@tromey.com>
1156
1157 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1158 deprecated_query_hook.
1159
bb01dbfc
TT
11602019-08-16 Tom Tromey <tom@tromey.com>
1161
1162 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1163 (tui_update_source_windows_with_line): Update.
1164 * tui/tui-source.h (struct tui_source_window)
1165 <show_symtab_source>: Declare.
1166 (tui_show_symtab_source): Don't declare.
1167 * tui/tui-source.c (tui_show_symtab_source): Rename from
1168 tui_show_symtab_source.
1169
81c82c4b
TT
11702019-08-16 Tom Tromey <tom@tromey.com>
1171
1172 * tui/tui-winsource.h (struct tui_source_window_base)
1173 <set_contents>: Declare.
1174 * tui/tui-winsource.c
1175 (tui_source_window_base::update_source_window_as_is): Update.
1176 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1177 Declare.
1178 (tui_set_source_content): Don't declare.
1179 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1180 tui_set_source_content.
1181 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1182 Declare.
1183 (tui_set_disassem_content): Don't declare.
1184 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1185 tui_set_disassem_content.
1186
2ddaf614
TT
11872019-08-16 Tom Tromey <tom@tromey.com>
1188
1189 * tui/tui-winsource.h (struct tui_source_window_base)
1190 <update_breakpoint_info>: Declare.
1191 (tui_update_breakpoint_info): Don't declare.
1192 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1193 (tui_update_all_breakpoint_info): Update.
1194 (tui_source_window_base::update_breakpoint_info): Rename from
1195 tui_update_breakpoint_info.
1196 (tui_source_window_base::update_exec_info): Update.
1197
017f9828
TT
11982019-08-16 Tom Tromey <tom@tromey.com>
1199
1200 * tui/tui-winsource.h (struct tui_source_window_base)
1201 <update_source_window>: Declare.
1202 (tui_update_source_window): Don't declare.
1203 * tui/tui-winsource.c
1204 (tui_source_window_base::update_source_window): Rename from
1205 tui_update_source_window.
1206 (tui_source_window_base::rerender): Update.
1207 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1208 * tui/tui-disasm.c (tui_show_disassem)
1209 (tui_show_disassem_and_update_source)
1210 (tui_disasm_window::maybe_update): Update.
1211
ed8358e9
TT
12122019-08-16 Tom Tromey <tom@tromey.com>
1213
1214 * tui/tui-winsource.h (struct tui_source_window_base)
1215 <update_source_window_as_is>: Declare.
1216 (tui_update_source_window_as_is): Don't declare.
1217 * tui/tui-winsource.c (tui_update_source_window): Update
1218 (tui_source_window_base::update_source_window_as_is): Rename from
1219 tui_update_source_window_as_is.
1220 (tui_source_window_base::refill): Update.
1221 * tui/tui-source.c (tui_show_symtab_source): Update.
1222 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1223 Update.
1224
20149b6b
TT
12252019-08-16 Tom Tromey <tom@tromey.com>
1226
1227 * tui/tui-winsource.h (tui_update_source_window)
1228 (tui_update_source_window_as_is): Remove "noerror" parameter.
1229 * tui/tui-winsource.c (tui_update_source_window)
1230 (tui_update_source_window_as_is): Remove "noerror" parameter.
1231 (tui_update_source_windows_with_addr)
1232 (tui_update_source_windows_with_line)
1233 (tui_source_window_base::rerender)
1234 (tui_source_window_base::refill): Update.
1235 * tui/tui-source.h (tui_set_source_content)
1236 (tui_show_symtab_source): Remove "noerror" parameter.
1237 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1238 parameter.
1239 (tui_show_symtab_source): Likewise.
1240 (tui_source_window::maybe_update): Update.
1241 * tui/tui-disasm.c (tui_show_disassem)
1242 (tui_show_disassem_and_update_source)
1243 (tui_disasm_window::do_scroll_vertical)
1244 (tui_disasm_window::maybe_update): Update.
1245
2d83e710
TT
12462019-08-16 Tom Tromey <tom@tromey.com>
1247
1248 * tui/tui.c (tui_is_window_visible): Update.
1249 * tui/tui-wingeneral.c (tui_make_window)
1250 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1251 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1252 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1253 (tui_set_win_height_command, parse_scrolling_args): Update.
1254 * tui/tui-source.c (tui_source_window::style_changed): Update.
1255 * tui/tui-regs.c (tui_show_registers)
1256 (tui_data_window::first_data_item_displayed)
1257 (tui_data_window::delete_data_content_windows)
1258 (tui_check_register_values, tui_reg_command): Update.
1259 * tui/tui-disasm.c (tui_show_disassem): Update.
1260 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1261 method.
1262 <is_visible>: Remove field.
1263 * tui/tui-data.c (tui_next_win, tui_prev_win)
1264 (tui_delete_invisible_windows): Update.
1265
d4ab829a
TT
12662019-08-16 Tom Tromey <tom@tromey.com>
1267
1268 * tui/tui-winsource.h (struct tui_source_window_base)
1269 <m_has_locator>: Remove.
1270 * tui/tui-layout.c (show_source_disasm_command, show_data)
1271 (show_source_or_disasm_and_command): Update.
1272
aa7ca1bb
AH
12732019-08-16 Alan Hayward <alan.hayward@arm.com>
1274
1275 * NEWS (Other MI changes): New subsection.
1276 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1277 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1278 * arch-utils.c (default_get_pc_address_flags): New function.
1279 * arch-utils.h (default_get_pc_address_flags): New declaration.
1280 * gdbarch.sh: Add get_pc_address_flags.
1281 * gdbarch.c: Regenerate.
1282 * gdbarch.h: Likewise.
1283 * stack.c (print_pc): New function.
1284 (print_frame_info) (print_frame): Call print_pc.
1285
6eac171f
TV
12862019-08-16 Tom de Vries <tdevries@suse.de>
1287
1288 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1289 print_objfile_section_info.
1290
3df505f6
TT
12912019-08-15 Tom Tromey <tom@tromey.com>
1292
1293 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1294 calling update_cmdwin_start_line.
1295 * tui/tui-winsource.h (struct tui_source_window_base)
1296 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1297 <rerender>: Declare.
1298 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1299 Call rerender.
1300 (tui_source_window_base::set_new_height): Remove.
1301 (tui_source_window_base::rerender): Rename from
1302 do_make_visible_with_new_height.
1303 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1304 resize method.
1305 (tui_win_info::make_invisible_and_set_new_height)
1306 (tui_win_info::make_visible_with_new_height): Remove.
1307 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1308 Declare.
1309 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1310 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1311 do_make_visible_with_new_height>: Don't declare.
1312 <rerender>: Declare.
1313 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1314 set_new_height.
1315 (tui_data_window::do_make_visible_with_new_height): Remove.
1316 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1317 call tui_show_locator_content.
1318 (tui_gen_win_info::resize): Call rerender.
1319 (show_source_or_disasm_and_command): Don't call
1320 tui_show_locator_content.
1321 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1322 method.
1323 (struct tui_win_info) <rerender>: Declare.
1324 <set_new_height, make_invisible_and_set_new_height,
1325 make_visible_with_new_height>: Don't declare.
1326 * tui/tui-data.c (tui_win_list::rerender): New method.
1327 * tui/tui-command.h (struct tui_cmd_window)
1328 <do_make_visible_with_new_height>: Don't declare.
1329 * tui/tui-command.c
1330 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1331
272560b5
TT
13322019-08-15 Tom Tromey <tromey@adacore.com>
1333
1334 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1335 * ada-lang.c (ada_enum_name): Likewise.
1336
08235187
CB
13372019-08-15 Christian Biesinger <cbiesinger@google.com>
1338
1339 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1340 leading underscore.
1341 (GdbOutputErrorFile): Likewise.
1342 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1343 accordingly.
1344 (execute_unwinders): Rename to have a leading underscore.
1345 (auto_load_packages): Likewise.
1346 (global scope): Adjust call to auto_load_packages accordingly.
1347 (GdbSetPythonDirectory): Likewise.
1348 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1349 instead of execute_unwinders.
1350
db502012
TT
13512019-08-15 Tom Tromey <tom@tromey.com>
1352
1353 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1354 (show_data): Don't change window visibility.
1355 (tui_gen_win_info::resize): Remove special case for command
1356 window. Use wresize, when available.
1357 (show_source_or_disasm_and_command): Don't change window
1358 visibility.
1359 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1360 <make_visible>: New method.
1361 * tui/tui-command.c (tui_cmd_window::resize): New method.
1362
3891b65e
TT
13632019-08-15 Tom Tromey <tom@tromey.com>
1364
1365 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1366 (struct tui_source_windows): New.
1367 * tui/tui-winsource.c (tui_display_main): Update.
1368 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1369 (new_height_ok, parse_scrolling_args): Update.
1370 * tui/tui-layout.c (show_layout, show_data): Update.
1371 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1372 (tui_add_to_source_windows): Don't declare.
1373 * tui/tui-data.c (source_windows, tui_source_windows)
1374 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1375
ee556432
TT
13762019-08-15 Tom Tromey <tom@tromey.com>
1377
1378 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1379 Rename from reset.
1380 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1381 * tui/tui-layout.c (show_source_disasm_command, show_data):
1382 Update.
1383 (tui_gen_win_info::resize): Rename.
1384 (show_source_or_disasm_and_command): Update.
1385 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1386 reset.
1387
46f438e3
TT
13882019-08-15 Tom Tromey <tom@tromey.com>
1389
1390 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1391 * tui/tui-interp.c (tui_interp::init): Don't call
1392 tui_initialize_static_data.
1393 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1394
f4ce562c
TT
13952019-08-15 Tom Tromey <tom@tromey.com>
1396
1397 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1398 examine tui_win_list.
1399
c398c3d0
TT
14002019-08-15 Tom Tromey <tom@tromey.com>
1401
1402 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1403 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1404 tui_clear_source_content.
1405 (tui_clear_source_content): Remove.
1406 (tui_source_window_base::do_erase_source_content): Hoist call to
1407 content.clear().
1408 * tui/tui-stack.c (tui_show_frame_info): Don't call
1409 tui_clear_source_content.
1410
e25d2004
TT
14112019-08-15 Tom Tromey <tom@tromey.com>
1412
1413 * tui/tui-winsource.h (struct tui_source_window_base)
1414 <do_erase_source_content>: New method.
1415 <erase_source_content>: New method.
1416 (tui_erase_source_content): Don't declare.
1417 * tui/tui-winsource.c (tui_clear_source_content): Update.
1418 (tui_source_window_base::do_erase_source_content): Rename from
1419 tui_erase_source_content.
1420 (tui_source_window_base::show_source_content): Update.
1421 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1422 * tui/tui-source.h (struct tui_source_window)
1423 <erase_source_content>: New method.
1424 * tui/tui-disasm.h (struct tui_disasm_window)
1425 <erase_source_content>: New method.
1426
002f15c2
TT
14272019-08-15 Tom Tromey <tom@tromey.com>
1428
1429 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1430 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1431 constructor.
1432 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1433 * tui/tui-source.c (tui_set_source_content): Update.
1434 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1435
c9033fe8
TT
14362019-08-15 Tom Tromey <tom@tromey.com>
1437
1438 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1439 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1440 tui-source.c.
1441 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1442 Declare.
1443 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1444 method.
1445 (tui_source_window::maybe_update): Update.
1446
088f37dd
TT
14472019-08-15 Tom Tromey <tom@tromey.com>
1448
1449 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1450 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1451 tui-disasm.c.
1452 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1453 Declare.
1454 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1455 method.
1456 (tui_disasm_window::maybe_update): Update.
1457
a54700c6
TT
14582019-08-15 Tom Tromey <tom@tromey.com>
1459
1460 * tui/tui-winsource.h (struct tui_source_window_base)
1461 <maybe_update>: Declare.
1462 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1463 method.
1464 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1465 Declare.
1466 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1467 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1468 Declare.
1469 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1470
e2a678a5
TT
14712019-08-15 Tom Tromey <tom@tromey.com>
1472
1473 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1474
f2dda477
TT
14752019-08-15 Tom Tromey <tom@tromey.com>
1476
1477 * tui/tui-wingeneral.c: Include tui-stack.h.
1478 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1479 (struct tui_locator_window): Move from tui-data.h.
1480 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1481 (tui_initialize_static_data): Move from tui-data.c.
1482 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1483 (struct tui_locator_window): Move to tui-stack.c.
1484 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1485 (tui_initialize_static_data): Move to tui-stack.c.
1486
ed4a1084
TT
14872019-08-15 Tom Tromey <tom@tromey.com>
1488
1489 * tui/tui-layout.c (show_source_disasm_command)
1490 (show_source_or_disasm_and_command): Use make_visible method, not
1491 tui_make_window.
1492 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1493 Remove.
1494
65962b20
TT
14952019-08-15 Tom Tromey <tom@tromey.com>
1496
1497 * tui/tui-wingeneral.h (tui_make_window): Update.
1498 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1499 parameter.
1500 (tui_gen_win_info::make_visible): Update.
1501 * tui/tui-regs.c (tui_data_window::display_registers_from):
1502 Update.
1503 * tui/tui-layout.c (show_source_disasm_command)
1504 (show_source_or_disasm_and_command): Update.
1505 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1506 (enum tui_box): Remove.
1507 (struct tui_win_info) <can_box>: New method.
1508 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1509 method.
1510
2208ee91
TV
15112019-08-15 Tom de Vries <tdevries@suse.de>
1512
1513 * linux-nat-trad.c: Include gdbarch.h.
1514
75faf5c4
AH
15152019-08-14 Alan Hayward <alan.hayward@arm.com>
1516
1517 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1518 register sizes.
1519
b1c896b3
TT
15202019-08-14 Tom Tromey <tromey@adacore.com>
1521
1522 * darwin-nat.c: Include gdbarch.h.
1523 * darwin-nat-info.c: Include gdbarch.h.
1524
6405cd73
TT
15252019-08-13 Tom Tromey <tom@tromey.com>
1526
1527 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1528 Remove.
1529 * tui/tui-data.c (tui_initialize_static_data): Update.
1530
5216580d
TT
15312019-08-13 Tom Tromey <tom@tromey.com>
1532
1533 * tui/tui-winsource.h (struct tui_exec_info_window)
1534 <~tui_exec_info_window, maybe_allocate_content, get_content,
1535 m_content>: Remove.
1536 (struct tui_source_window_base) <set_exec_info_content,
1537 show_exec_info_content>: Don't declare.
1538 * tui/tui-winsource.c
1539 (tui_exec_info_window::maybe_allocate_content): Remove.
1540 (tui_source_window_base::update_exec_info): Rename from
1541 set_exec_info_content.
1542 (tui_source_window_base::show_exec_info_content)
1543 (tui_source_window_base::update_exec_info): Remove.
1544
93858ad3
TT
15452019-08-13 Tom Tromey <tom@tromey.com>
1546
1547 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1548 declare.
1549 * tui/tui-winsource.c (tui_update_source_window_as_is)
1550 (tui_update_source_windows_with_addr, tui_erase_source_content):
1551 Update.
1552 (tui_clear_exec_info_content): Remove.
1553
e321e7ce
TT
15542019-08-13 Tom Tromey <tom@tromey.com>
1555
1556 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1557 declare.
1558 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1559 call tui_erase_exec_info_content.
1560 (tui_clear_exec_info_content): Rename from
1561 tui_erase_exec_info_content.
1562 (tui_clear_exec_info_content): Delete.
1563
8270ac62
TT
15642019-08-13 Tom Tromey <tom@tromey.com>
1565
1566 * tui/tui-winsource.h (struct tui_source_window_base)
1567 <show_exec_info_content>: Declare.
1568 (tui_show_exec_info_content): Don't declare.
1569 * tui/tui-winsource.c
1570 (tui_source_window_base::show_exec_info_content): Rename from
1571 tui_show_exec_info_content.
1572 (tui_source_window_base::update_exec_info): Update.
1573
7b56485d
TT
15742019-08-13 Tom Tromey <tom@tromey.com>
1575
1576 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1577 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1578 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1579 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1580 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1581 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1582 ... here.
1583
7ba913dc
TT
15842019-08-13 Tom Tromey <tom@tromey.com>
1585
1586 * tui/tui-winsource.h (struct tui_source_window_base)
1587 <update_exec_info>: Declare.
1588 (tui_update_exec_info): Don't declare.
1589 * tui/tui-winsource.c (tui_update_source_window_as_is)
1590 (tui_source_window_base::refresh_all)
1591 (tui_update_all_breakpoint_info): Update.
1592 (tui_source_window_base::update_exec_info): Rename from
1593 tui_update_exec_info.
1594 * tui/tui-stack.c (tui_show_frame_info): Update.
1595
37a4a131
TT
15962019-08-13 Tom Tromey <tom@tromey.com>
1597
1598 * tui/tui-winsource.h (struct tui_source_window_base)
1599 <set_exec_info_content>: Declare.
1600 (tui_set_exec_info_content): Don't declare.
1601 * tui/tui-winsource.c
1602 (tui_source_window_base::set_exec_info_content): Rename from
1603 tui_set_exec_info_content.
1604 (tui_update_exec_info): Update.
1605
0bd27e07
TT
16062019-08-13 Tom Tromey <tom@tromey.com>
1607
1608 * tui/tui-winsource.h (struct tui_source_window_base)
1609 <show_source_content>: Declare.
1610 (tui_show_source_content): Don't declare.
1611 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1612 (tui_source_window_base::show_source_content): Rename from
1613 tui_show_source_content.
1614 (tui_source_window_base::refresh_all): Update.
1615 * tui/tui-layout.c (show_source_disasm_command)
1616 (show_source_or_disasm_and_command): Update.
1617
b4ef5aeb
TT
16182019-08-13 Tom Tromey <tom@tromey.com>
1619
1620 * tui/tui-winsource.c (tui_erase_source_content)
1621 (tui_show_source_content, tui_source_window_base::refresh_all):
1622 Update.
1623 * tui/tui-wingeneral.h
1624 (tui_check_and_display_highlight_if_needed): Don't declare.
1625 * tui/tui-wingeneral.c
1626 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1627 check_and_display_highlight_if_needed.
1628 * tui/tui-win.c (tui_rehighlight_all)
1629 (tui_win_info::make_visible_with_new_height): Update.
1630 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1631 (tui_data_window::erase_data_content)
1632 (tui_data_window::display_all_data): Update.
1633 * tui/tui-data.h (struct tui_win_info)
1634 <check_and_display_highlight_if_needed>: Declare.
1635
fede5273
TT
16362019-08-13 Tom Tromey <tom@tromey.com>
1637
1638 * tui/tui-win.c (tui_resize_all): Call
1639 tui_delete_invisible_windows.
1640 * tui/tui-layout.c (show_layout): Call
1641 tui_delete_invisible_windows.
1642 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1643 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1644
22c3f490
TT
16452019-08-13 Tom Tromey <tom@tromey.com>
1646
1647 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1648 tui_add_win_to_layout.
1649
16cb7910
TT
16502019-08-13 Tom Tromey <tom@tromey.com>
1651
1652 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1653 * tui/tui-layout.c (tui_default_win_height): Now static.
1654
cc0c3ffb
TT
16552019-08-13 Tom Tromey <tom@tromey.com>
1656
1657 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1658 single switch.
1659 (show_source_disasm_command, show_source_or_disasm_and_command):
1660 Don't check current layout.
1661
3f3ffe54
TT
16622019-08-13 Tom Tromey <tom@tromey.com>
1663
1664 * tui/tui-wingeneral.c (make_all_visible): Remove.
1665 (tui_make_all_invisible): Simplify.
1666 * tui/tui-layout.c (tui_make_all_invisible): Move from
1667 tui-wingeneral.c; simplify.
1668 (show_layout): Hoist call to tui_make_all_invisible.
1669 (show_data): Don't call tui_make_all_invisible.
1670
69258091
TT
16712019-08-13 Tom Tromey <tom@tromey.com>
1672
1673 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1674 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1675
62cf57fe
TT
16762019-08-13 Tom Tromey <tom@tromey.com>
1677
1678 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1679 tui-data.c.
1680 (show_source_disasm_command, show_data)
1681 (show_source_or_disasm_and_command): Don't use
1682 tui_set_current_layout_to.
1683 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1684 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1685 tui-layout.c.
1686 (tui_set_current_layout_to): Remove.
1687
2afade5d
TT
16882019-08-13 Tom Tromey <tom@tromey.com>
1689
1690 * tui/tui-layout.c (tui_set_layout): Update.
1691 * tui/tui-data.h (struct tui_layout_def): Remove.
1692 (tui_layout_def): Don't declare.
1693 * tui/tui-data.c (layout_def): Remove.
1694 (tui_layout_def): Remove.
1695
a3504e96
TT
16962019-08-13 Tom Tromey <tom@tromey.com>
1697
1698 * tui/tui-winsource.h (struct tui_source_window_base)
1699 <clear_detail>: No longer "override".
1700 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1701 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1702 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1703 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1704 Remove.
1705 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1706
29c92911
TT
17072019-08-13 Tom Tromey <tromey@adacore.com>
1708
1709 * tracepoint.c: Don't include readline.h or history.h.
1710
86c6b807
TT
17112019-08-12 Tom Tromey <tom@tromey.com>
1712
1713 * configure: Rebuild.
1714 * configure.ac: Check for readline 7.
1715 * NEWS: Mention readline 7 requirement.
1716 * README: Update.
1717
5db2718c
TT
17182019-08-12 Tom Tromey <tom@tromey.com>
1719
1720 * mingw-hdep.c (gdb_select): Remove readline hack.
1721
dac36daf
PFC
17222019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1723
1724 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1725 when the function fails.
1726
1022c627
AA
17272019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1728
1729 * s390-tdep.c (s390_type_align): New function.
1730 (s390_gdbarch_init): Set it as type_align gdbarch method.
1731
eba4caf2
TV
17322019-08-09 Tom de Vries <tdevries@suse.de>
1733
1734 PR gdb/24591
1735 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1736 pc_low with relocation offset.
1737
123cd851
TT
17382019-08-07 Tom Tromey <tromey@adacore.com>
1739
1740 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1741 (print_frame_args): Update.
1742 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1743 Update.
1744 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1745 * frame.h (struct frame_arg): Add initializers.
1746 <error>: Now a unique_xmalloc_ptr.
1747
3d31bc39
AH
17482019-08-07 Alan Hayward <alan.hayward@arm.com>
1749
1750 * NEWS: Expand the Pointer Authentication entry.
1751 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1752 (aarch64_frame_unmask_lr): ... to this.
1753 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1754 Call aarch64_frame_unmask_lr.
1755 * frame.c (struct frame_info): Add "masked" variable.
1756 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1757 (fprint_frame): Check for masked pc.
1758 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1759 declarations.
1760 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1761 * stack.c (print_frame): Check for masked pc.
1762
0cf9feb9
TT
17632019-08-06 Tom Tromey <tom@tromey.com>
1764
1765 * stabsread.c (patch_block_stabs, read_one_struct_field)
1766 (read_enum_type): Use obstack_strndup.
1767 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1768 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1769 * dwarf2read.c (guess_full_die_structure_name)
1770 (anonymous_struct_prefix): Use obstack_strndup.
1771 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1772 * c-exp.y (yylex): Use obstack_strndup.
1773 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1774 (write_var_or_type): Use obstack_strndup.
1775
efba19b0
TT
17762019-08-06 Tom Tromey <tom@tromey.com>
1777
1778 * symfile.c (reread_symbols): Use obstack_strdup.
1779 * stabsread.c (read_type): Use obstack_strdup.
1780 * gdb_obstack.h (obstack_strdup): New overload.
1781 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1782 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1783 (dwarf2_canonicalize_name): Use obstack_strdup.
1784 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1785 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1786 Use obstack_strdup.
1787
f25102f7
TT
17882019-08-06 Tom Tromey <tom@tromey.com>
1789
1790 * gdb_obstack.h (obstack_strdup): Define.
1791 * gdb_obstack.c (obstack_strdup): Don't define.
1792
021887d8
TT
17932019-08-06 Tom Tromey <tom@tromey.com>
1794
1795 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1796 obstack_strdup.
1797 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1798 obstack_strdup.
1799 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1800 * stabsread.c (common_block_start): Use obstack_strdup.
1801 * objfiles.c (set_objfile_main_name, objfile): Use
1802 obstack_strdup.
1803 * namespace.c (add_using_directive): Use obstack_strdup.
1804 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1805 * jit.c (finalize_symtab): Use obstack_strdup.
1806 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1807 (guess_partial_die_structure_name, partial_die_info::fixup)
1808 (dwarf2_name): Use obstack_strdup.
1809 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1810 obstack_strdup.
1811 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1812 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1813 obstack_strdup.
1814 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1815
d2834edc
PW
18162019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1817
1818 * unittests/help-doc-selftests.c: New file.
1819 * Makefile.in: Add the new file.
1820
590042fc
PW
18212019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1822
1823 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1824 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1825 the full first line, except when FOR_VALUE_PREFIX. In this case,
1826 the trailing '.' is not output, and the first character is uppercased.
1827 (print_help_for_command): Update call to print_doc_line.
1828 (print_doc_of_command): Likewise.
1829 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1830 * cli/cli-option.c (append_indented_doc): Do not append newline.
1831 (build_help_option): Append newline after first appended_indented_doc
1832 only if a second call is done.
1833 (build_help): Append 2 new lines before each option, except the first
1834 one.
1835 * compile/compile.c (_initialize_compile): Add new lines after
1836 %OPTIONS%, when not at the end of the help.
1837 Change help doc or code
1838 producing the help doc to respect the invariants.
1839 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1840 Also removed the new line after 'Options:', as all other commands
1841 do not put an empty line between 'Options:' and the first option.
1842 * printcmd.c (_initialize_printcmd): Likewise.
1843 * stack.c (_initialize_stack): Likewise.
1844 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1845 incorrectly telling COMMAND is optional.
1846 * ada-lang.c (_initialize_ada_language): Change help doc or code
1847 producing the help doc to respect the invariants.
1848 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1849 * breakpoint.c (_initialize_breakpoint): Likewise.
1850 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1851 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1852 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1853 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1854 _initialize_cli_style): Likewise.
1855 * corelow.c (core_target_info): Likewise.
1856 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1857 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1858 * filesystem.c (_initialize_filesystem): Likewise.
1859 * frame.c (_initialize_frame): Likewise.
1860 * gnu-nat.c (add_task_commands): Likewise.
1861 * infcall.c (_initialize_infcall): Likewise.
1862 * infcmd.c (_initialize_infcmd): Likewise.
1863 * interps.c (_initialize_interpreter): Likewise.
1864 * language.c (_initialize_language): Likewise.
1865 * linux-fork.c (_initialize_linux_fork): Likewise.
1866 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1867 * maint.c (_initialize_maint_cmds): Likewise.
1868 * memattr.c (_initialize_mem): Likewise.
1869 * printcmd.c (_initialize_printcmd): Likewise.
1870 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1871 _RegEx): Likewise.
1872 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1873 * record-btrace.c (_initialize_record_btrace): Likewise.
1874 * record-full.c (_initialize_record_full): Likewise.
1875 * record.c (_initialize_record): Likewise.
1876 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1877 * regcache.c (_initialize_regcache): Likewise.
1878 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1879 _initialize_remote): Likewise.
1880 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1881 * serial.c (_initialize_serial): Likewise.
1882 * skip.c (_initialize_step_skip): Likewise.
1883 * source.c (_initialize_source): Likewise.
1884 * stack.c (_initialize_stack): Likewise.
1885 * symfile.c (_initialize_symfile): Likewise.
1886 * symtab.c (_initialize_symtab): Likewise.
1887 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1888 * top.c (init_main): Likewise.
1889 * tracefile-tfile.c (tfile_target_info): Likewise.
1890 * tracepoint.c (_initialize_tracepoint): Likewise.
1891 * tui/tui-win.c (_initialize_tui_win): Likewise.
1892 * utils.c (add_internal_problem_command): Likewise.
1893 * valprint.c (value_print_option_defs): Likewise.
1894
404f2902
FCE
18952019-08-06 Frank Ch. Eigler <fche@redhat.com>
1896
1897 PR build/24886
1898 * configure.ac: Drop enable-libmcheck support.
1899 * configure, config.in: Rebuild.
1900 * libmcheck.m4: Remove.
1901 * acinclude.m4: Don't include it.
1902 * Makefile.in: Don't distribute it.
1903 * top.c (print_gdb_configuration): Don't mention it.
1904
046bebe1
TT
19052019-08-06 Tom Tromey <tom@tromey.com>
1906
1907 * utils.c (set_output_style): Sometimes pass stream to
1908 emit_style_escape.
1909 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1910 * record-btrace.c (btrace_insn_history): Update.
1911 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1912 method.
1913 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1914 Update initializers.
1915 <m_uiout>: New field.
1916 <m_di>: Move lower.
1917 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1918 Remove "uiout" parameter.
1919 (dump_insns): Update.
1920 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1921 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1922
ddbcedf5
CB
19232019-08-06 Christian Biesinger <cbiesinger@google.com>
1924
1925 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1926 (error_in_psymtab_expansion): Likewise.
1927 (lookup_symbol_via_quick_fns): Likewise.
1928 (basic_lookup_transparent_type_quick): Likewise.
1929 (basic_lookup_transparent_type_1): Likewise.
1930
b08b16c8
TT
19312019-08-06 Tom Tromey <tromey@adacore.com>
1932
1933 * source.c (last_source_error): Now bool.
1934 (print_source_lines_base): Make "noprint" bool. Only open
1935 source file when last_source_visited changes.
1936
cb44333d
TT
19372019-08-06 Tom Tromey <tromey@adacore.com>
1938
1939 * annotate.c (annotate_source_line): Use g_source_cache.
1940 * source-cache.c (source_cache::get_plain_source_lines): Change
1941 parameters. Populate m_offset_cache.
1942 (source_cache::ensure): New method.
1943 (source_cache::get_line_charpos): New method.
1944 (extract_lines): Move lower. Change parameters.
1945 (source_cache::get_source_lines): Move lower.
1946 * source-cache.h (class source_cache): Update comment.
1947 <get_line_charpos>: New method.
1948 <get_source_lines>: Update comment.
1949 <clear>: Clear m_offset_cache.
1950 <get_plain_source_lines>: Change parameters.
1951 <ensure>: New method
1952 <m_offset_cache>: New member.
1953 * source.c (forget_cached_source_info_for_objfile): Update.
1954 (info_source_command): Use g_source_cache.
1955 (find_source_lines, open_source_file_with_line_charpos): Remove.
1956 (print_source_lines_base, search_command_helper): Use g_source_cache.
1957 * source.h (open_source_file_with_line_charpos): Don't declare.
1958 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1959 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1960 Use g_source_cache.
1961
872dceaa
TT
19622019-08-06 Tom Tromey <tromey@adacore.com>
1963
1964 * source-cache.c (source_cache::get_plain_source_lines):
1965 Remove "first_line" and "last_line" parameters.
1966 (source_cache::get_source_lines): Cache plain text.
1967 * source-cache.h (class source_cache)
1968 <get_plain_source_lines>: Update.
1969
269249d9
TT
19702019-08-06 Tom Tromey <tromey@adacore.com>
1971
1972 * source-cache.c (extract_lines): No longer a method.
1973 Changed type of parameter. Include final newline.
1974 (selftests::extract_lines_test): New function.
1975 (_initialize_source_cache): Likewise.
1976 * source-cache.h (class source_cache)
1977 <extract_lines>: Don't declare.
1978
c0e8dcd8
TT
19792019-08-06 Tom Tromey <tromey@adacore.com>
1980
1981 * breakpoint.c (init_breakpoint_sal): Update.
1982 (breakpoint): Update.
1983 * breakpoint.h (struct breakpoint) <filter>: Now a
1984 unique_xmalloc_ptr.
1985
0b27c27d
CB
19862019-08-05 Christian Biesinger <cbiesinger@google.com>
1987
1988 * NEWS: Mention dictionary access on blocks.
1989 * python/py-block.c (blpy_getitem): New function.
1990 (block_object_as_mapping): New struct.
1991 (block_object_type): Use new struct for tp_as_mapping field.
1992
4ee94178
CB
19932019-08-05 Christian Biesinger <cbiesinger@google.com>
1994
1995 * objfiles.h (objfile): Add a comment describing partial symbols.
1996
8abfcabc
TT
19972019-08-05 Tom Tromey <tromey@adacore.com>
1998
1999 * compile/compile.c (_initialize_compile): Use _(), not N_().
2000 * thread.c (_initialize_thread): Use _(), not N_().
2001 * stack.c (_initialize_stack): Use _(), not N_().
2002 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2003
2b79f376
SM
20042019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2005
2006 * dwarf2read.c (struct dw2_symtab_iterator):
2007 <want_specific_block>: Remove.
2008 <block_index>: Change type to gdb::optional.
2009 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2010 change type of BLOCK_INDEX parameter to gdb::optional.
2011 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2012 (dw2_lookup_symbol): Don't pass argument for
2013 WANT_SPECIFIC_BLOCK.
2014 (dw2_expand_symtabs_for_function): Don't pass argument for
2015 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2016 (class dw2_debug_names_iterator)
2017 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2018 parameter, change BLOCK_INDEX type to gdb::optional.
2019 <m_want_specific_block>: Remove.
2020 <m_block_index>: Change type to gdb::optional.
2021 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2022 gdb::optional. Re-write in function of gdb::optional.
2023 (dw2_debug_names_lookup_symbol): Don't pass argument for
2024 WANT_SPECIFIC_BLOCK.
2025 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2026 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2027 BLOCK_INDEX.
2028
ae60f04e
PW
20292019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2030
2031 * NEWS: Mention changes to "info sources" command.
2032
28cd9371
PW
20332019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2034
2035 * symtab.c (filename_partial_match_opts): New struct type.
2036 (struct output_source_filename_data): New members
2037 regexp, c_regexp, partial_match.
2038 (output_source_filename): Use new members to decide to print file.
2039 (info_sources_option_defs): New variable.
2040 (make_info_sources_options_def_group, print_info_sources_header,
2041 info_sources_command_completer):
2042 New functions.
2043 (info_sources_command): Read new optional arguments.
2044 (_initialize_symtab): Update info sources help.
2045
ca683e3a
AO
20462019-08-02 Alexandre Oliva <oliva@adacore.com>
2047
2048 * ada-lang.c (exception_support_info_v0): Renamed from...
2049 (default_exception_support_info): ... this. Create new
2050 definition for v1.
2051 (ada_has_this_exception_support): Look up catch_handlers_sym.
2052 (ada_exception_support_info_sniffer): Try v0 after default.
2053
f1264162
TT
20542019-08-01 Tom Tromey <tromey@adacore.com>
2055
2056 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2057 gdbarch.h.
2058
0a7b2485
CB
20592019-08-01 Christian Biesinger <cbiesinger@google.com>
2060
2061 * s12z-tdep.c: Fix include path for s12z-opc.h.
2062
c6bdbeb7
AH
20632019-08-01 Alan Hayward <alan.hayward@arm.com>
2064
2065 * NEWS: Require GNU make 3.82.
2066
a2bd7b82
TT
20672019-07-16 Tom Tromey <tom@tromey.com>
2068
2069 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2070 declare.
2071
aa3b6533
TT
20722019-07-30 Tom Tromey <tromey@adacore.com>
2073
2074 * block.c (contained_in): Remove BLOCK_FUNCTION check.
2075
a1530dc7
KB
20762019-07-30 Kevin Buettner <kevinb@redhat.com>
2077
2078 * printcmd.c (print_address_symbolic): Print negative offsets.
2079 (build_address_symbolic): Force signed arithmetic when computing
2080 offset.
2081
2906593f
CB
20822019-07-30 Christian Biesinger <cbiesinger@google.com>
2083
2084 PR/24474: Add a function to lookup static variables.
2085 * NEWS: Mention this new function.
2086 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2087 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2088 * python/python.c (python_GdbMethods): Add new function.
2089
c620ed88
CB
20902019-07-29 Christian Biesinger <cbiesinger@google.com>
2091
2092 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2093 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2094 (objfpy_lookup_static_symbol): New function.
2095 (objfile_object_methods): Add new functions.
2096
bc4268a5
PW
20972019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2098
2099 * NEWS: Mention 'set|show print frame-info'. Mention new
2100 'presence' value for 'frame-arguments'. Mention new '-frame-info'
2101 backtrace argument. Mention that python frame filtering code
2102 is now consistent with what 'backtrace' command prints.
2103
4b5e8d19
PW
21042019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2105
2106 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2107 comments.
2108 (print_frame_info_auto, print_frame_info_source_line,
2109 print_frame_info_location, print_frame_info_source_and_location,
2110 print_frame_info_location_and_address, print_frame_info_short_location):
2111 New declarations.
2112 (struct frame_print_options): New member print_frame_info.
2113 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2114 * stack.h (get_user_print_what_frame_info): New declaration.
2115 (frame_show_address): New declaration.
2116 * stack.c (print_frame_arguments_choices): New value 'presence'.
2117 (print_frame_info_auto, print_frame_info_source_line,
2118 print_frame_info_location, print_frame_info_source_and_location,
2119 print_frame_info_location_and_address, print_frame_info_short_location,
2120 print_frame_info_choices, print_frame_info_print_what): New definitions.
2121 (print_frame_args): Only print dots for args if print frame-arguments
2122 is 'presence'.
2123 (frame_print_option_defs): New element for "frame-info".
2124 (get_user_print_what_frame_info): New function.
2125 (frame_show_address): Make non static. Move comment to stack.h.
2126 (print_frame_info_to_print_what): New function.
2127 (print_frame_info): Update comment. Use fp_opts.print_frame_info
2128 to decide what to print.
2129 (backtrace_command_1): Handle the new print_frame_arguments_presence
2130 value.
2131 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2132 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2133 (py_print_frame): In non-mi mode, use LOCATION as default for
2134 print_what, similarly to frame information printed directly by
2135 backtrace command. Handle frame-info user option in non MI mode.
2136
6bdfee81
KB
21372019-07-27 Kevin Buettner <kevinb@redhat.com>
2138
2139 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2140 Add case for debugging 32-bit target on 64-bit host. Revise
2141 comment.
2142
98a617f8
KB
21432019-07-27 Kevin Buettner <kevinb@redhat.com>
2144
2145 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2146 instead of find_function_entry_range_from_pc.
2147
567238c9
KB
21482019-07-27 Kevin Buettner <kevinb@redhat.com>
2149
2150 * stack.c (find_frame_funname): Remove code which preferred
2151 minsym over symtab sym in "certain pathological cases".
2152
2dc80cf8
KB
2153 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2154 parameter. Change type of "do_demangle" to bool.
2155 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2156 Pass suitable "prefer_sym_over_minsym" flag to
2157 build_address_symbolic(). Don't output "+" for negative offsets.
2158 * printcmd.c (print_address_symbolic): Update invocation of
2159 build_address_symbolic to include a "prefer_sym_over_minsym"
2160 flag.
2161 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2162 Restrict cases in which use of minimal symbol is preferred to that
2163 of a found symbol. Update comments.
2164
1aff7173
KB
2165 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2166 for entry pc when entry pc is out of range for that FDE.
2167
89b085ac
BC
21682019-07-26 Brian Callahan <bcallah@openbsd.org>
2169
2170 PR gdb/24839:
2171 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2172 type.
2173
f32feb4a
CB
21742019-07-25 Christian Biesinger <cbiesinger@google.com>
2175
2176 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2177 this function's Python signature.
2178
2179
21802019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
2181
2182 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2183 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2184 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2185 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2186 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2187
2188
c54e4253
YS
21892019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2190
2191 * h8300-tdep.c (h8300_register_name_common): New.
2192 h8300_register_name): Use h8300_register_name_common.
2193 (h8300s_register_name): Likewise.
2194 (h8300sx_register_name): Likewise.
2195 (h8300h_register_nam): New.
2196 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2197
2198
40eadf04
SP
21992019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2200
2201 * arm-tdep.c (arm_skip_cmse_entry): New function.
2202 (arm_is_sgstubs_section): New function.
2203 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2204
bfa2a36d
TT
22052019-07-22 Tom Tromey <tom@tromey.com>
2206
2207 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2208 Don't self-assign.
2209
a8e9d247
AB
22102019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2211
2212 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2213 type_print.
2214
eb86c5e2
AB
22152019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2216
2217 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2218 so that GDB doesn't match any msymbols when searching in the
2219 TYPES_DOMAIN.
2220 (print_symbol_info): Print using typedef_print or type_print based
2221 on the type of the symbol. Add updated FIXME comment moved from...
2222 (_initialize_symtab): ... move and update FIXME comment to above.
2223
a8eab7c6
AB
22242019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2225
2226 * NEWS: Mention adding -q option to "info types".
2227 * symtab.c (struct info_types_options): New struct.
2228 (info_types_options_defs): New variable.
2229 (make_info_types_options_def_group): New function.
2230 (info_types_command): Use gdb::option framework to parse options.
2231 (info_types_command_completer): New function.
2232 (_initialize_symtab): Extend the help text on "info types" and
2233 register command completer.
2234
b4603c34
CB
22352019-07-21 Christian Biesinger <cbiesinger@google.com>
2236
2237 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2238 (lookup_symbol_in_objfile): Change int to block_enum and add a
2239 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2240
c8cdc1e0
CB
22412019-07-20 Christian Biesinger <cbiesinger@google.com>
2242
2243 * MAINTAINERS (Write After Approval): Add self.
2244
01e175fe
AB
22452019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2246
2247 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2248 instruction to the dummy code region.
2249
56f79b63
TT
22502019-07-19 Tom Tromey <tromey@adacore.com>
2251
2252 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2253 (ARGSUSED, PARAMS, __func__): Remove rules.
2254
4c5aa8e0
AH
22552019-07-19 Alan Hayward <alan.hayward@arm.com>
2256
2257 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2258 * features/arm/arm-with-iwmmxt.c: Remove.
2259 * features/arm/arm-with-iwmmxt.xml: Remove.
2260 * features/arm/arm-with-m-fpa-layout.c: Remove.
2261 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2262 * features/arm/arm-with-m-vfp-d16.c: Remove.
2263 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2264 * features/arm/arm-with-m.c: Remove.
2265 * features/arm/arm-with-m.xml: Remove.
2266 * features/arm/arm-with-neon.c: Remove.
2267 * features/arm/arm-with-neon.xml: Remove.
2268 * features/arm/arm-with-vfpv2.c: Remove.
2269 * features/arm/arm-with-vfpv2.xml: Remove.
2270 * features/arm/arm-with-vfpv3.c: Remove.
2271 * features/arm/arm-with-vfpv3.xml: Remove.
2272
f42b2617
AH
22732019-07-19 Alan Hayward <alan.hayward@arm.com>
2274
2275 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2276
f29ec966
AH
22772019-07-19 Alan Hayward <alan.hayward@arm.com>
2278
2279 * arch/aarch32.c (aarch32_create_target_description): Create
2280 target descriptions using features.
2281 * arch/arm.c (arm_create_target_description)
2282 (arm_create_mprofile_target_description): Likewise.
2283 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2284
d105cce5
AH
22852019-07-19 Alan Hayward <alan.hayward@arm.com>
2286
2287 * Makefile.in: Add new files.
2288 * aarch32-tdep.c: New file.
2289 * aarch32-tdep.h: New file.
2290 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2291 Call aarch32_read_description.
2292 * arch/aarch32.c: New file.
2293 * arch/aarch32.h: New file.
2294 * arch/arm.c (arm_create_target_description)
2295 (arm_create_mprofile_target_description): New function.
2296 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2297 (arm_create_target_description)
2298 (arm_create_mprofile_target_description): New declaration.
2299 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2300 read_description functions.
2301 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2302 Likewise.
2303 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2304 * arm-tdep.c (tdesc_arm_list): New variable.
2305 (arm_register_g_packet_guesses): Call create description functions.
2306 (arm_read_description) (arm_read_mprofile_description): New
2307 function.
2308 * arm-tdep.h (arm_read_description)
2309 (arm_read_mprofile_description): Add declaration.
2310 * configure.tgt: Add new files.
2311
afe09f0b
GL
23122019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2313
2314 * top.c (new_ui_command): Open specified terminal just once.
2315
cd215b2e
TT
23162019-07-18 Tom Tromey <tromey@adacore.com>
2317
2318 * symtab.c (main_name): Constify return type.
2319 * symfile.c (set_initial_language): Update.
2320 * symtab.h (main_name): Constify return type.
2321
d8f68fcb
TT
23222019-07-17 Tom Tromey <tom@tromey.com>
2323
2324 * tui/tui-winsource.c (tui_update_source_window)
2325 (tui_update_source_window_as_is)
2326 (tui_update_source_windows_with_line): Remove return.
2327 * tui/tui-disasm.c (tui_show_disassem)
2328 (tui_show_disassem_and_update_source): Remove return.
2329 * tui/tui.c (tui_reset): Remove return.
2330 * tui/tui-wingeneral.c
2331 (tui_check_and_display_highlight_if_needed): Remove return.
2332
ca5af91e
TT
23332019-07-17 Tom Tromey <tom@tromey.com>
2334
2335 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2336
5104fe36
TT
23372019-07-17 Tom Tromey <tom@tromey.com>
2338
2339 * tui/tui-winsource.h (struct tui_exec_info_window)
2340 (struct tui_source_window_base): Move from tui-data.h.
2341 * tui/tui-winsource.c: Move many method definitions from
2342 elsewhere. Remove "structuring" comments.
2343 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2344 (tui_source_window_base::refresh_window): Move to
2345 tui-winsource.c.
2346 * tui/tui-win.c (tui_source_window_base::refresh_all)
2347 (tui_source_window_base::update_tab_width)
2348 (tui_source_window_base::set_new_height)
2349 (tui_source_window_base::do_make_visible_with_new_height): Move to
2350 tui-winsource.c.
2351 * tui/tui-source.h: Update.
2352 * tui/tui-source.c (tui_source_window_base::reset): Move to
2353 tui-winsource.c.
2354 * tui/tui-disasm.h: Update.
2355 * tui/tui-data.h (struct tui_exec_info_window): Move to
2356 tui-winsource.h.
2357 (struct tui_source_window_base): Likewise.
2358 * tui/tui-data.c (tui_source_window_base::clear_detail)
2359 (tui_source_window_base, ~tui_source_window_base): Move to
2360 tui-winsource.c.
2361
daa15dde
TT
23622019-07-17 Tom Tromey <tom@tromey.com>
2363
2364 * tui/tui-win.c (tui_resize_all)
2365 (tui_source_window_base::update_tab_width)
2366 (tui_adjust_win_heights): Update.
2367 (tui_win_info::make_invisible_and_set_new_height): Rename from
2368 make_invisible_and_set_new_height.
2369 * tui/tui-data.h (struct tui_win_info)
2370 <make_invisible_and_set_new_height>: New method.
2371
bfad4537
TT
23722019-07-17 Tom Tromey <tom@tromey.com>
2373
2374 * tui/tui.c: Update.
2375 * tui/tui-source.h (struct tui_source_window): Move from
2376 tui-data.h.
2377 * tui/tui-layout.c: Update.
2378 * tui/tui-disasm.c: Update.
2379 * tui/tui-data.h (struct tui_source_window): Move to
2380 tui-source.h.
2381
88f7e873
TT
23822019-07-17 Tom Tromey <tom@tromey.com>
2383
2384 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2385 tui-data.h.
2386 * tui/tui-data.h (struct tui_disasm_window): Move to
2387 tui-disasm.h.
2388
96bd6233
TT
23892019-07-17 Tom Tromey <tom@tromey.com>
2390
2391 * tui/tui-regs.h (struct tui_data_item_window): Move from
2392 tui-data.h.
2393 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2394 * tui/tui-data.h (struct tui_data_item_window): Move to
2395 tui-regs.h.
2396 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2397
ce38393b
TT
23982019-07-17 Tom Tromey <tom@tromey.com>
2399
2400 * tui/tui.c: Update.
2401 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2402 (tui_cmd_window::max_height): Move to tui-command.c.
2403 * tui/tui-layout.c: Update.
2404 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2405 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2406 tui-command.c.
2407 * tui/tui-command.h (struct tui_cmd_window): Move from
2408 tui-data.h.
2409 * tui/tui-command.c: Remove "structuring" comments.
2410 (tui_cmd_window::clear_detail)
2411 (tui_cmd_window::do_make_visible_with_new_height)
2412 (tui_cmd_window::max_height): Move from elsewhere.
2413
2d8b51cb
TT
24142019-07-17 Tom Tromey <tom@tromey.com>
2415
2416 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2417 Now static.
2418 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2419 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2420
18ab23af
TT
24212019-07-17 Tom Tromey <tom@tromey.com>
2422
2423 * tui/tui.c: Update.
2424 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2425 tui-regs.c.
2426 * tui/tui-windata.h: Remove file.
2427 * tui/tui-windata.c: Remove file.
2428 * tui/tui-win.c (tui_data_window::set_new_height)
2429 (tui_data_window::do_make_visible_with_new_height): Move to
2430 tui-regs.c.
2431 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2432 * tui/tui-regs.c: Remove "structuring" comments.
2433 (tui_data_window::first_data_item_displayed)
2434 (tui_data_window::delete_data_content_windows)
2435 (tui_data_window::erase_data_content)
2436 (tui_data_window::display_all_data)
2437 (tui_data_window::refresh_all)
2438 (tui_data_window::do_scroll_vertical)
2439 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2440 (tui_data_window::do_make_visible_with_new_height)
2441 (tui_data_window::refresh_window): Move from elsewhere.
2442 (_initialize_tui_regs): Move to end of file.
2443 * tui/tui-layout.c: Update.
2444 * tui/tui-hooks.c: Update.
2445 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2446 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2447 tui-regs.c.
2448 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2449
88b7e7cc
TT
24502019-07-17 Tom Tromey <tom@tromey.com>
2451
2452 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2453 seen.
2454
0fcd3711
TT
24552019-07-17 Tom Tromey <tom@tromey.com>
2456
2457 * tui/tui-win.c (tui_source_window_base::set_new_height)
2458 (tui_source_window_base::do_make_visible_with_new_height): Use
2459 m_has_locator field directly.
2460 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2461 method.
2462 (struct tui_source_window_base) <has_locator>: Likewise.
2463
4a38112d
TT
24642019-07-17 Tom Tromey <tom@tromey.com>
2465
2466 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2467 Don't declare.
2468 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2469 Remove.
2470 * tui/tui-win.c (tui_source_window_base::set_new_height)
2471 (tui_source_window_base::set_new_height)
2472 (make_invisible_and_set_new_height)
2473 (tui_source_window_base::do_make_visible_with_new_height)
2474 (tui_source_window_base::do_make_visible_with_new_height):
2475 Update.
2476 * tui/tui-layout.c (show_source_disasm_command, show_data)
2477 (show_source_or_disasm_and_command): Update.
2478 * tui/tui-layout.c (show_layout): Update.
2479
09129226
TT
24802019-07-17 Tom Tromey <tom@tromey.com>
2481
2482 * tui/tui-layout.c (make_data_window): Remove.
2483 (show_data): Unify creation and re-initialization cases.
2484
4a8a5e84
TT
24852019-07-17 Tom Tromey <tom@tromey.com>
2486
2487 * tui/tui-layout.c (make_source_window, make_disasm_window):
2488 Remove.
2489 (show_data): Unify creation and re-initialization cases.
2490
76d2be8e
TT
24912019-07-17 Tom Tromey <tom@tromey.com>
2492
2493 * tui/tui-layout.c (make_command_window): Remove.
2494 (show_source_disasm_command, show_source_or_disasm_and_command):
2495 Unify creation and re-initialization cases.
2496
890b8bde
TT
24972019-07-17 Tom Tromey <tom@tromey.com>
2498
2499 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2500 creation and re-initialization cases.
2501
2cdfa113
TT
25022019-07-17 Tom Tromey <tom@tromey.com>
2503
2504 * tui/tui-regs.c (tui_get_register): Return void.
2505
8e3cfd09
TT
25062019-07-17 Tom Tromey <tom@tromey.com>
2507
2508 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2509 Simplify.
2510
f4e04977
TT
25112019-07-17 Tom Tromey <tom@tromey.com>
2512
2513 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2514 resetting.
2515
0379b883
TT
25162019-07-17 Tom Tromey <tom@tromey.com>
2517
2518 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2519 * tui/tui-regs.c (tui_reg_layout): New function.
2520 (tui_show_registers, tui_reg_command): Use it.
2521 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2522 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2523 parameters.
2524 (tui_layout_command): Remove.
2525
b7fbad91
TT
25262019-07-17 Tom Tromey <tom@tromey.com>
2527
2528 * tui/tui-layout.h (tui/tui-layout): Return void.
2529 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2530
4e1e56b9
TT
25312019-07-17 Tom Tromey <tom@tromey.com>
2532
2533 * tui/tui-layout.c (show_source_disasm_command, show_data):
2534 Update.
2535 (reset_locator): Remove.
2536 (show_source_or_disasm_and_command): Update.
2537
1e0c09ba
TT
25382019-07-17 Tom Tromey <tom@tromey.com>
2539
2540 * tui/tui-source.c (tui_source_window_base::reset): Remove
2541 win_type parameter.
2542 * tui/tui-layout.c (make_command_window, make_source_window)
2543 (make_disasm_window, make_data_window)
2544 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2545 (reset_locator, show_source_or_disasm_and_command): Update.
2546 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2547 win_type parameter.
2548 (struct tui_source_window_base) <reset>: Likewise.
2549
1bf605de
TT
25502019-07-17 Tom Tromey <tom@tromey.com>
2551
2552 * tui/tui-layout.c (show_source_disasm_command): Use
2553 reset_locator.
2554 (reset_locator): New function.
2555 (init_and_make_win): Remove.
2556 (show_source_or_disasm_and_command): Use reset_locator.
2557
098f9ed4
TT
25582019-07-17 Tom Tromey <tom@tromey.com>
2559
2560 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2561 condition.
2562 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2563 Remove condition.
2564 * tui/tui-source.c (tui_source_window_base::reset): New method.
2565 * tui/tui-layout.c (make_command_window): Don't call
2566 init_and_make_win.
2567 (make_source_window, make_disasm_window): Don't call
2568 make_source_or_disasm_window.
2569 (make_data_window): Don't call init_and_make_win. Change calling
2570 convention.
2571 (show_source_disasm_command, show_data): Simplify.
2572 (make_source_or_disasm_window): Remove.
2573 (show_source_or_disasm_and_command): Simplify.
2574 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2575 (struct tui_source_window_base) <reset>: Likewise.
2576 <execution_info>: Remove initializer.
2577 * tui/tui-data.c (tui_source_window_base): Initialize
2578 execution_info.
2579
80110957
TT
25802019-07-17 Tom Tromey <tom@tromey.com>
2581
2582 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2583 variable.
2584
cf82af05
TT
25852019-07-17 Tom Tromey <tom@tromey.com>
2586
2587 * tui/tui.c (tui_rl_other_window): Update.
2588 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2589 superclass method first. Always iterate over regs_content.
2590 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2591 method.
2592 * tui/tui-win.c (tui_set_focus_command): Update.
2593
01aeb396
TT
25942019-07-17 Tom Tromey <tom@tromey.com>
2595
2596 * tui/tui-win.c (tui_set_focus_command): Rename from
2597 tui_set_focus. Call tui_enable.
2598 (tui_set_focus_command): Remove.
2599
fd6c75ee
TT
26002019-07-17 Tom Tromey <tom@tromey.com>
2601
2602 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2603 refresh_window.
2604 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2605 touchwin.
2606 (tui_data_window::refresh_window): Call refresh_window on data
2607 items. Always call superclass refresh_window.
2608 (tui_win_info::refresh): Remove.
2609 (tui_source_window_base::refresh_window): Update.
2610 (tui_refresh_all): Update.
2611 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2612 refresh_window.
2613 (show_source_or_disasm_and_command): Likewise.
2614 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2615 (struct tui_source_window_base) <refresh>: Likewise.
2616
f6cc34a9
TT
26172019-07-17 Tom Tromey <tom@tromey.com>
2618
2619 * tui/tui-winsource.c (tui_clear_source_content)
2620 (tui_show_source_content): Update.
2621 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2622 whether content is empty.
2623 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2624 Remove.
2625
f31ec9af
TT
26262019-07-17 Tom Tromey <tom@tromey.com>
2627
2628 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2629 window's contents.
2630 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2631 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2632
d1b6f1e5
TT
26332019-07-17 Tom Tromey <tom@tromey.com>
2634
2635 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2636 (struct tui_data_item_window): Update.
2637
d9743a13
TT
26382019-07-17 Tom Tromey <tom@tromey.com>
2639
2640 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2641 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2642 defines.
2643
caf0bc4e
TT
26442019-07-17 Tom Tromey <tom@tromey.com>
2645
2646 * tui/tui-winsource.h (tui_erase_source_content)
2647 (tui_clear_source_content): Remove "display_prompt" parameter.
2648 * tui/tui-winsource.c (tui_update_source_window_as_is)
2649 (tui_update_source_windows_with_addr): Update.
2650 (tui_clear_source_content): Remove "display_prompt" parameter.
2651 (tui_erase_source_content): Likewise. Simplify.
2652 (tui_show_source_content): Update.
2653 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2654 * tui/tui-stack.c (tui_show_frame_info): Update.
2655 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2656 Remove defines.
2657
9d391078
TT
26582019-07-17 Tom Tromey <tom@tromey.com>
2659
2660 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2661 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2662 parameter.
2663 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2664 parameter.
2665
a38da35d
TT
26662019-07-17 Tom Tromey <tom@tromey.com>
2667
2668 * tui/tui-winsource.c (tui_clear_source_content)
2669 (tui_show_source_content, tui_show_exec_info_content)
2670 (tui_clear_exec_info_content): Update.
2671 * tui/tui-stack.c (tui_show_locator_content): Update.
2672 (tui_show_frame_info): Update.
2673 * tui/tui-source.h (tui_source_window): Don't declare.
2674 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2675 from tui_source_is_displayed.
2676 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2677 Remove field.
2678 (struct tui_source_window_base) <content_in_use>: New field. Now
2679 bool.
2680 (struct tui_source_window) <showing_source_p>: New method.
2681 (TUI_SRC_WIN): Change cast.
2682 * tui/tui-data.c (tui_initialize_static_data): Update.
2683
c2cd8994
TT
26842019-07-17 Tom Tromey <tom@tromey.com>
2685
2686 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2687 location_matches_p.
2688 * tui/tui-source.c (tui_source_window::location_matches_p): New
2689 method.
2690 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2691 method.
2692 * tui/tui-data.h (struct tui_source_window_base)
2693 <location_matches_p>: New method.
2694 (struct tui_source_window, struct tui_disasm_window)
2695 <location_matches_p>: Likewise.
2696
4dde7b34
TT
26972019-07-17 Tom Tromey <tom@tromey.com>
2698
2699 * tui/tui-win.c (tui_set_win_height_command): Rename from
2700 tui_set_win_height.
2701 (tui_set_win_height_command): Remove.
2702
b73dd877
TT
27032019-07-17 Tom Tromey <tom@tromey.com>
2704
2705 * tui/tui-source.c (tui_source_window): New constructor. Add
2706 observer.
2707 (~tui_source_window): New destructor.
2708 (tui_source_window::style_changed): New method.
2709 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2710 (tui_attach_detach_observers): Update.
2711 * tui/tui-data.h (struct tui_source_window): Make constructor not
2712 inline. Add destructor.
2713 (struct tui_source_window) <style_changed>: New method.
2714 <m_observable>: New member.
2715
ae2b5380
TT
27162019-07-17 Tom Tromey <tom@tromey.com>
2717
2718 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2719 * tui/tui-win.c (tui_resize_all): Fix typo.
2720
1ce3e844
TT
27212019-07-17 Tom Tromey <tom@tromey.com>
2722
2723 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2724 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2725 (tui_refresh_all): Remove "list" parameter. Use foreach.
2726 * tui/tui-win.c (window_name_completer): Use foreach.
2727 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2728 (update_tab_width): Likewise.
2729 * tui/tui-layout.c (show_layout): Update.
2730 * tui/tui-data.h (class tui_window_iterator): New.
2731 (struct all_tui_windows): New.
2732 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2733
fe3eaf1c
TT
27342019-07-17 Tom Tromey <tom@tromey.com>
2735
2736 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2737 parameter. Don't reference globals.
2738 (tui_reg_command): Update.
2739
368c1354
TT
27402019-07-17 Tom Tromey <tom@tromey.com>
2741
2742 * tui/tui-regs.c (tui_show_registers): Simplify.
2743
e80cd204
TT
27442019-07-17 Tom Tromey <tom@tromey.com>
2745
2746 * tui/tui-regs.c (tui_show_registers): Update.
2747 (tui_show_register_group): Add win_info parameter.
2748
aca2dd16
TT
27492019-07-17 Tom Tromey <tom@tromey.com>
2750
2751 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2752 Rename from tui_display_reg_element_at_line.
2753 (tui_data_window::display_registers_from_line): Update.
2754 * tui/tui-data.h (struct tui_data_window)
2755 <display_reg_element_at_line>: New method.
2756
517e9505
TT
27572019-07-17 Tom Tromey <tom@tromey.com>
2758
2759 * tui/tui-regs.h (tui_display_registers_from)
2760 (tui_display_registers_from_line): Don't declare.
2761 * tui/tui-windata.c (tui_data_window::display_all_data)
2762 (tui_data_window::refresh_all)
2763 (tui_data_window::do_scroll_vertical): Update.
2764 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2765 from tui_display_registers_from.
2766 (tui_display_reg_element_at_line): Update.
2767 (tui_data_window::display_registers_from_line): Rename from
2768 tui_display_registers_from_line.
2769 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2770 display_registers_from_line>: New methods.
2771
f76d8b19
TT
27722019-07-17 Tom Tromey <tom@tromey.com>
2773
2774 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2775 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2776 from tui_erase_data_content.
2777 (tui_data_window::display_all_data)
2778 (tui_data_window::refresh_all)
2779 (tui_data_window::do_scroll_vertical): Update.
2780 * tui/tui-regs.c (tui_show_registers): Update.
2781 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2782 New method.
2783
b4094625
TT
27842019-07-17 Tom Tromey <tom@tromey.com>
2785
2786 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2787 declare.
2788 * tui/tui-windata.c
2789 (tui_data_window::delete_data_content_windows): Rename from
2790 tui_delete_data_content_windows.
2791 (tui_data_window::display_all_data)
2792 (tui_data_window::do_scroll_vertical): Update.
2793 * tui/tui-data.h (struct tui_data_window)
2794 <delete_data_content_windows>: New method.
2795
c223a729
TT
27962019-07-17 Tom Tromey <tom@tromey.com>
2797
2798 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2799 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2800
50daf268
TT
28012019-07-17 Tom Tromey <tom@tromey.com>
2802
2803 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2804 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2805 from tui_display_all_data.
2806 * tui/tui-win.c
2807 (tui_data_window::do_make_visible_with_new_height): Update.
2808 * tui/tui-regs.c (tui_show_registers): Update.
2809 * tui/tui-layout.c (tui_set_layout): Update.
2810 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2811 method.
2812
df5f8cab
TT
28132019-07-17 Tom Tromey <tom@tromey.com>
2814
2815 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2816 * tui/tui-windata.c (tui_display_data_from): Remove.
2817 (tui_data_window::refresh_all): Update.
2818
80cb6c27
TT
28192019-07-17 Tom Tromey <tom@tromey.com>
2820
2821 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2822 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2823 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2824 tui_display_registers_from_line.
2825 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2826 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2827 "force_display" parameter.
2828
baff0c28
TT
28292019-07-17 Tom Tromey <tom@tromey.com>
2830
2831 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2832 declare.
2833 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2834 Rename from tui_first_reg_element_no_inline.
2835 (tui_display_reg_element_at_line)
2836 (tui_display_registers_from_line): Update.
2837 * tui/tui-data.h (struct tui_data_window)
2838 <first_reg_element_no_inline>: New method.
2839
3b23c5f2
TT
28402019-07-17 Tom Tromey <tom@tromey.com>
2841
2842 * tui/tui-windata.c (tui_display_data_from)
2843 (tui_data_window::do_scroll_vertical): Update.
2844 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2845 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2846 Rename from tui_line_from_reg_element_no.
2847 (tui_display_registers_from_line): Update.
2848 * tui/tui-data.h (struct tui_data_window)
2849 <line_from_reg_element_no>: New method.
2850
0b5ec218
TT
28512019-07-17 Tom Tromey <tom@tromey.com>
2852
2853 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2854 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2855 tui_last_regs_line_no.
2856 (tui_display_reg_element_at_line)
2857 (tui_display_registers_from_line): Update.
2858 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2859 method.
2860
0807ab7b
TT
28612019-07-17 Tom Tromey <tom@tromey.com>
2862
2863 PR tui/24722:
2864 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2865 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2866 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2867 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2868 (tui_update_breakpoint_info): Likewise.
2869 * tui/tui-hooks.c (tui_event_create_breakpoint)
2870 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2871 Update.
2872
9ad7fdef
TT
28732019-07-17 Tom Tromey <tom@tromey.com>
2874
2875 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2876
5813316f
TT
28772019-07-17 Tom Tromey <tom@tromey.com>
2878
2879 * tui/tui-winsource.c (tui_update_source_window_as_is)
2880 (tui_update_source_windows_with_addr): Update.
2881 * tui/tui-source.h (tui_set_source_content)
2882 (tui_show_symtab_source): Add "win_info" parameter.
2883 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2884 parameter.
2885 (tui_show_symtab_source): Likewise.
2886
00e264e7
TT
28872019-07-17 Tom Tromey <tom@tromey.com>
2888
2889 * tui/tui-wingeneral.c
2890 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2891
06210ce4
TT
28922019-07-17 Tom Tromey <tom@tromey.com>
2893
2894 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2895 (struct tui_cmd_window) <can_scroll>: New method.
2896 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2897 method.
2898
381befee
TT
28992019-07-17 Tom Tromey <tromey@adacore.com>
2900
2901 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2902 do_field_signed>: Rename. Change type of "value".
2903 * ui-out.c (ui_out::field_signed): Rename from field_int.
2904 Change type of "value".
2905 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2906 type of "value".
2907 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2908 do_field_int. Change type of "value".
2909 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2910 do_field_int. Change type of "value".
2911 * tracepoint.c (trace_status_mi, tfind_1)
2912 (print_one_static_tracepoint_marker): Update.
2913 * thread.c (print_thread_info_1, print_selected_thread_frame):
2914 Update.
2915 * stack.c (print_frame, print_frame_info): Update.
2916 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2917 Update.
2918 * source.c (print_source_lines_base): Update.
2919 * skip.c (info_skip_command): Update.
2920 * record-btrace.c (btrace_ui_out_decode_error)
2921 (btrace_call_history_src_line): Update.
2922 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2923 Update.
2924 * progspace.c (print_program_space): Update.
2925 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2926 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2927 do_field_int. Change type of "value".
2928 * mi/mi-out.c (mi_ui_out::do_table_begin)
2929 (mi_ui_out::do_table_header): Update.
2930 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2931 type of "value".
2932 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2933 (mi_cmd_data_list_changed_registers, output_register)
2934 (mi_cmd_data_read_memory, mi_load_progress)
2935 (mi_cmd_trace_frame_collected): Update.
2936 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2937 Update.
2938 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2939 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2940 (mi_cmd_var_list_children, varobj_update_one): Update.
2941 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2942 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2943 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2944 * inferior.c (print_inferior): Update.
2945 * gdb_bfd.c (print_one_bfd): Update.
2946 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2947 Update.
2948 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2949 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2950 do_field_int. Change type of "value".
2951 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2952 do_field_int. Change type of "value".
2953 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2954 (print_one_breakpoint_location, print_it_catch_fork)
2955 (print_one_catch_fork, print_it_catch_vfork)
2956 (print_one_catch_vfork, print_it_catch_solib)
2957 (print_it_catch_exec, print_it_ranged_breakpoint)
2958 (print_mention_watchpoint, print_mention_masked_watchpoint)
2959 (bkpt_print_it, update_static_tracepoint): Update.
2960 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2961 * break-catch-syscall.c (print_it_catch_syscall): Update.
2962 * ada-tasks.c (print_ada_task_info): Update.
2963 * ada-lang.c (print_it_exception, print_mention_exception):
2964 Update.
2965
6b78c3f8
AB
29662019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2967
2968 PR breakpoints/24541
2969 * gdbarch.c: Regenerate.
2970 * gdbarch.h: Regenerate.
2971 * gdbarch.sh: Adjust return type and parameter types for
2972 'stap_adjust_register'.
2973 (i386_stap_adjust_register): Adjust signature and return new
2974 register name.
2975 * stap-probe.c (stap_parse_register_operand): Adjust use of
2976 'gdbarch_stap_adjust_register'.
2977
d72a9b85
TT
29782019-07-17 Tom Tromey <tromey@adacore.com>
2979
2980 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2981 declare VEC.
2982 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2983 std::vector.
2984 (struct s390_process_info): Add initializers.
2985 (s390_add_process): Use new.
2986 (s390_linux_nat_target::low_forget_process): Use delete.
2987 (s390_linux_nat_target::low_new_fork)
2988 (s390_linux_nat_target::stopped_by_watchpoint)
2989 (s390_linux_nat_target::low_prepare_to_resume)
2990 (s390_linux_nat_target::insert_watchpoint)
2991 (s390_linux_nat_target::insert_hw_breakpoint)
2992 (s390_linux_nat_target::remove_watchpoint)
2993 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2994
206e6c58
JB
29952019-07-16 John Baldwin <jhb@FreeBSD.org>
2996
2997 * aarch64-fbsd-nat.c: Include regcache.h.
2998 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2999 argument.
3000 (aarch64_fbsd_nat_target::fetch_registers)
3001 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3002 variable.
3003 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3004
cbde90f2
JB
30052019-07-16 John Baldwin <jhb@FreeBSD.org>
3006
3007 * fbsd-nat.c: Include gdbarch.h.
3008
07128006
TT
30092019-07-15 Tom Tromey <tromey@adacore.com>
3010
3011 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3012
1f77b012
TT
30132019-07-15 Tom Tromey <tromey@adacore.com>
3014
3015 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3016 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3017 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3018 * cli-out.c (cli_ui_out::do_field_int): New method.
3019 * ui-out.c (ui_out::field_unsigned): New method.
3020 * symfile.c (generic_load): Use field_unsigned.
3021 (print_transfer_performance): Likewise.
3022 * record-btrace.c (ui_out_field_uint): Remove.
3023 (btrace_call_history_insn_range, btrace_call_history): Use
3024 field_unsigned.
3025 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3026 field_unsigned.
3027 * ui-out.h (class ui_out) <field_unsigned>: New method.
3028 <do_field_unsigned>: Likewise.
3029
33eca680
TT
30302019-07-15 Tom Tromey <tromey@adacore.com>
3031
3032 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3033 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3034 * target.c (flash_erase_command): Use field_string.
3035 * infrun.c (print_signal_received_reason): Use field_string.
3036 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3037 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3038 field_string.
3039 * ada-tasks.c (print_ada_task_info): Use field_string.
3040
ca8d69be
TT
30412019-07-15 Tom Tromey <tromey@adacore.com>
3042
3043 * target.c (flash_erase_command): Use field_core_addr.
3044 * symfile.c (generic_load): Use field_core_addr.
3045 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3046 Use field_core_addr.
3047 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3048 field_core_addr.
3049
0d4e84ed
AB
30502019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3051
3052 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3053 value if its desired type is smaller than a CORE_ADDR and signed.
3054
9a49df9d
AB
30552019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3056
3057 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3058 of changes to field names, and use new is_reference field to
3059 decide if a property is a reference or not.
3060 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3061 field.
3062 (struct dwarf2_property_baton): Update header comment, rename
3063 'referenced_type' to 'property_type' and update comments.
3064 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3065 default property type, store in property baton, update to take
3066 accound of renamed field.
3067 (read_func_scope): Update call to attr_to_dynamic_prop.
3068 (read_array_type): Likewise.
3069 (dwarf2_per_cu_addr_sized_int_type): New function.
3070 (read_subrange_index_type): Move type finding code to
3071 dwarf2_per_cu_addr_sized_int_type.
3072 (read_subrange_type): Update calls to attr_to_dynamic_prop.
3073 (dwarf2_per_cu_addr_type): New function.
3074 (set_die_type): Update calls to attr_to_dynamic_prop.
3075
b86352cf
AB
30762019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3077
3078 * dwarf2read.c (read_subrange_index_type): New function.
3079 (read_subrange_type): Move code into new function and call it.
3080 * gdbtypes.c (create_range_type): Add some asserts.
3081
603490bf
AB
30822019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3083
3084 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3085 update return statements.
3086 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3087 declaration, and update comment to match.
3088 * gdbtypes.c (resolve_dynamic_array): Update call to
3089 dwarf2_evaluate_property to match new return type.
3090
592f9d27
AB
30912019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3092
3093 * valarith.c (value_subscripted_rvalue): Change lowerbound
3094 parameter type from int to LONGEST.
3095 * value.h (value_subscripted_rvalue): Likewise in declaration.
3096
60cfcb20
AB
30972019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3098
3099 * cli/cli-utils.c (info_print_command_completer): New function.
3100 * cli/cli-utils.h: Add 'completer.h' include, and forward
3101 declaration for 'struct cmd_list_element'.
3102 (info_print_command_completer): Declare.
3103 * stack.c (_initialize_stack): Add completer for 'info locals' and
3104 'info args'.
3105 * symtab.c (_initialize_symtab): Add completer for 'info
3106 variables' and 'info functions'.
3107 * NEWS: Mention completion for additional info commands.
3108
b16507e0
AB
31092019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3110
3111 * cli/cli-utils.c (extract_info_print_args): Delete.
3112 (extract_arg_maybe_quoted): Delete.
3113 (info_print_options_defs): New variable.
3114 (make_info_print_options_def_group): New function.
3115 (extract_info_print_options): Define new function.
3116 * cli/cli-utils.h (extract_info_print_args): Delete.
3117 (struct info_print_options): New structure.
3118 (extract_info_print_options): Declare new function.
3119 * stack.c (info_locals_command): Update to use new
3120 extract_info_print_options, also add a header comment.
3121 (info_args_command): Likewise.
3122 * symtab.c (info_variables_command): Likewise.
3123 (info_functions_command): Likewise.
3124
021d8588
AB
31252019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3126
3127 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3128 to extract string arguments.
3129 * common/common-utils.c (extract_string_maybe_quoted): New function.
3130 * common/common-utils.h (extract_string_maybe_quoted): Declare.
3131
b777eb6d
TT
31322019-07-11 Tom Tromey <tromey@adacore.com>
3133
3134 * main.c (get_init_files): Use GDBINIT, not gdbinit.
3135 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3136 * top.h (gdbinit): Don't declare.
3137 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3138 into...
3139 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
3140 * top.c (gdb_init): Don't call init_cli_cmds.
3141 (gdbinit): Remove.
3142 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3143
72ee03ff
TT
31442019-07-11 Tom Tromey <tromey@adacore.com>
3145
3146 * python/py-inferior.c (add_thread_object): Don't use thread_obj
3147 after it has been moved.
3148
00db9531
SM
31492019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3150
3151 * valops.c (value_must_coerce_to_target): Change return type to
3152 bool.
3153 * value.h (value_must_coerce_to_target): Likewise.
3154
f2478a7e
SM
31552019-07-10 Simon Marchi <simon.marchi@efficios.com>
3156
3157 * breakpoint.c (is_hardware_watchpoint): Remove
3158 forward-declaration.
3159 (is_masked_watchpoint): Change return type to bool.
3160 (is_tracepoint): Likewise.
3161 (is_breakpoint): Likewise.
3162 (is_hardware_watchpoint): Likewise.
3163 (is_watchpoint): Likewise.
3164 (is_no_memory_software_watchpoint): Likewise.
3165 (is_catchpoint): Likewise.
3166 (breakpoint_1): Make FILTER parameter's return type bool.
3167 is_masked_watchpoint): Change return type to bool.
3168 (save_breakpoints): Make FILTER parameter's return type bool.
3169 * breakpoint.h (is_breakpoint): Change return type to bool.
3170 (is_watchpoint): Likewise.
3171 (is_catchpoint): Likewise.
3172 (is_tracepoint): Likewise.
3173
0d12e84c
TT
31742019-07-10 Tom Tromey <tom@tromey.com>
3175
3176 * defs.h: Don't include gdbarch.h.
3177 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3178 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3179 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3180 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3181 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3182 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3183 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3184 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3185 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3186 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3187 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3188 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3189 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3190 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3191 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3192 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3193 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3194 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3195 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3196 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3197 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3198 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3199 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3200 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3201 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3202 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3203 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3204
f06f1252
TT
32052019-07-10 Tom Tromey <tromey@adacore.com>
3206
3207 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3208 * breakpoint.c (init_ada_exception_breakpoint): Register as
3209 bp_catchpoint.
3210 (print_one_breakpoint_location, print_one_breakpoint): Use
3211 is_ada_exception_catchpoint.
3212 * ada-lang.c (class ada_catchpoint_location): Pass
3213 bp_loc_software_breakpoint to bp_location constructor.
3214 (is_ada_exception_catchpoint): New function.
3215
7a5d944b
TT
32162019-07-10 Tom Tromey <tromey@adacore.com>
3217
3218 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3219 VEC.
3220 (struct arm_exidx_entry): New method operator<.
3221 (struct arm_exidx_data) <section_maps>: Change type.
3222 (arm_exidx_data_free): Remove.
3223 (arm_exidx_data_key): Change type. Move lower.
3224 (arm_exidx_new_objfile): Update.
3225 (arm_compare_exidx_entries): Remove.
3226 (arm_find_exidx_entry, _initialize_arm_tdep)
3227
48c66e1d
TT
32282019-07-10 Tom Tromey <tromey@adacore.com>
3229
3230 * solib-spu.c (ocl_program_data_key): Change type.
3231 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3232 Update.
3233
a269fbf1
TT
32342019-07-10 Tom Tromey <tromey@adacore.com>
3235
3236 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3237 (struct solib_aix_inferior_data) <library_list>: Change type.
3238 (solib_aix_inferior_data_handle): Change type.
3239 (get_solib_aix_inferior_data): Update.
3240 (solib_aix_free_library_list): Remove.
3241 (library_list_start_library): Update.
3242 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3243 return type.
3244 (solib_aix_get_library_list)
3245 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3246 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3247
c294730c
TT
32482019-07-10 Tom Tromey <tromey@adacore.com>
3249
3250 * solib-dsbt.c (struct dsbt_info): Add initializers.
3251 (solib_dsbt_pspace_data): Change type.
3252 (dsbt_pspace_data_cleanup): Remove.
3253 (get_dsbt_info, _initialize_dsbt_solib): Update.
3254
9d52077d
TT
32552019-07-10 Tom Tromey <tromey@adacore.com>
3256
3257 * spu-tdep.c (spu_overlay_data): Change type.
3258 (spu_get_overlay_table, spu_overlay_new_objfile)
3259 (_initialize_spu_tdep): Update.
3260
22a20dca
TT
32612019-07-10 Tom Tromey <tromey@adacore.com>
3262
3263 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3264 destructor.
3265 (dbx_objfile_data_key): Change type and declare later.
3266 (DBX_SYMFILE_INFO): Rewrite.
3267 * dbxread.c (dbx_objfile_data_key): Change type.
3268 (dbx_symfile_init): Update.
3269 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3270 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3271 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3272
cb60f420
TT
32732019-07-10 Tom Tromey <tromey@adacore.com>
3274
3275 * jit.c (jit_program_space_key): Change type. Move lower.
3276 (get_jit_program_space_data): Update.
3277 (jit_program_space_data_cleanup): Remove.
3278 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3279 Update.
3280 (struct jit_program_space_data): Add initializers.
3281
51df2ae3
TT
32822019-07-10 Tom Tromey <tromey@adacore.com>
3283
3284 * solib-darwin.c (struct darwin_info): Add initializers.
3285 (solib_darwin_pspace_data): Change type.
3286 (darwin_pspace_data_cleanup): Remove.
3287 (get_darwin_info, _initialize_darwin_solib): Update.
3288
18101a35
TT
32892019-07-10 Tom Tromey <tromey@adacore.com>
3290
3291 * remote-sim.c (struct sim_inferior_data): Add initializers,
3292 constructor, and destructor.
3293 (sim_inferior_data_key): Change type. Move lower.
3294 (check_for_duplicate_sim_descriptor): Update.
3295 (get_sim_inferior_data): Use new. Update.
3296 (~sim_inferior_data_cleanup): Rename from
3297 sim_inferior_data_cleanup. Simplify.
3298 (gdbsim_close_inferior, simulator_command)
3299 (sim_command_completer, _initialize_remote_sim): Update.
3300 (next_pid, INITIAL_PID): Move earlier.
3301
05b08ac1
TT
33022019-07-10 Tom Tromey <tromey@adacore.com>
3303
3304 * python/python-internal.h (create_thread_object): Return
3305 gdbpy_ref.
3306 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3307 * python/py-inferior.c (struct threadlist_entry): Add
3308 constructor.
3309 <thread_obj>: Now a gdbpy_ref.
3310 (thread_to_thread_object): Update.
3311 (add_thread_object): Use new.
3312 (delete_thread_object): Use delete.
3313 (infpy_threads): Update.
3314 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3315 GIL.
3316
32372d80
TT
33172019-07-10 Tom Tromey <tromey@adacore.com>
3318
3319 * valops.c (value_cast): Specialize error message for Ada.
3320
5c458ae8
SM
33212019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3322
3323 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3324
4c462cb0
SM
33252019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3326
3327 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3328 bpstat_should_step): Return bool, adjust comments.
3329 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3330 bpstat_should_step): Likewise.
3331
89abbcc2
AH
33322019-07-10 Alan Hayward <alan.hayward@arm.com>
3333
3334 * features/Makefile: Use feature target descriptions for Arm.
3335 * features/arm/arm-core.c: Generate new file.
3336 * features/arm/arm-fpa.c: Likewise.
3337 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3338 * features/arm/arm-m-profile.c: Likewise.
3339 * features/arm/arm-vfpv2.c: Likewise.
3340 * features/arm/arm-vfpv3.c: Likewise.
3341 * features/arm/xscale-iwmmxt.c: Likewise.
3342 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3343
166a82be
AH
33442019-07-10 Alan Hayward <alan.hayward@arm.com>
3345
3346 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3347 ptrace earlier.
3348
9fb4c7e9
AH
33492019-07-10 Alan Hayward <alan.hayward@arm.com>
3350
3351 * features/aarch64-pauth.c: Regenerate.
3352
e2d0f980
SM
33532019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3354
3355 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3356 bool.
3357 (bpstat_what): Use false instead of 0.
3358
a38118e5
PA
33592019-07-09 Pedro Alves <palves@redhat.com>
3360
3361 * break-catch-throw.c (is_exception_catchpoint): New.
3362 * breakpoint.c (print_one_breakpoint_location): New parameter
3363 'raw_loc'. Handle it. Use
3364 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3365 looking at the breakpoint's type.
3366 (print_one_breakpoint): If handling "maint info breakpoints", also
3367 print locations of exception catchpoints.
3368 * breakpoint.h (is_exception_catchpoint): Declare.
3369
cb1e4e32
PA
33702019-07-09 Pedro Alves <palves@redhat.com>
3371
3372 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3373 "addr" field.
3374 (allocate_location_exception_catchpoint): New.
3375 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3376 (initialize_throw_catchpoint_ops): Install
3377 allocate_location_exception_catchpoint as allocate_location
3378 method.
3379 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3380 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3381 bp_loc_other.
3382 (breakpoint_address_is_meaningful): Delete.
3383 (bl_address_is_meaningful): New.
3384 (breakpoint_locations_match): Adjust comment.
3385 (bp_location_from_bp_type): New, factored out of...
3386 (bp_location::bp_location(breakpoint *)): ... this.
3387 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3388 factored out of...
3389 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3390 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3391 breakpoint_address_is_meaningful.
3392 (bp_locations_compare): Adjust comment.
3393 (update_global_location_list): Use bl_address_is_meaningful
3394 instead of breakpoint_address_is_meaningful.
3395 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3396 explicit.
3397 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3398 * python/py-breakpoint.c (bppy_get_location): No longer check
3399 whether location is null.
3400
b58a68fe
PA
34012019-07-09 Pedro Alves <palves@redhat.com>
3402
3403 PR c++/15468
3404 * breakpoint.c (print_one_breakpoint_location): Remove
3405 single-location assert.
3406
268a13a5
TT
34072019-07-09 Tom Tromey <tom@tromey.com>
3408
3409 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3410 * configure: Rebuild.
3411 * configure.ac: Change common to gdbsupport.
3412 * gdbsupport: Rename from common.
3413 * acinclude.m4: Change common to gdbsupport.
3414 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3415 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3416 gdbsupport.
3417 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3418 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3419 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3420 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3421 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3422 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3423 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3424 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3425 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3426 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3427 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3428 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3429 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3430 coff-pe-read.c, command.h, compile/compile-c-support.c,
3431 compile/compile-c.h, compile/compile-cplus-symbols.c,
3432 compile/compile-cplus-types.c, compile/compile-cplus.h,
3433 compile/compile-loc2c.c, compile/compile.c, completer.c,
3434 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3435 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3436 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3437 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3438 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3439 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3440 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3441 features/aarch64-core.c, features/aarch64-fpu.c,
3442 features/aarch64-pauth.c, features/aarch64-sve.c,
3443 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3444 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3445 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3446 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3447 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3448 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3449 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3450 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3451 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3452 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3453 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3454 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3455 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3456 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3457 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3458 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3459 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3460 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3461 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3462 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3463 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3464 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3465 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3466 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3467 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3468 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3469 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3470 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3471 minsyms.c, mips-linux-tdep.c, namespace.h,
3472 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3473 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3474 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3475 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3476 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3477 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3478 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3479 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3480 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3481 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3482 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3483 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3484 procfs.c, producer.c, progspace.h, psymtab.h,
3485 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3486 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3487 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3488 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3489 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3490 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3491 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3492 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3493 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3494 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3495 target-memory.c, target.c, target.h, target/waitstatus.c,
3496 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3497 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3498 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3499 unittests/array-view-selftests.c,
3500 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3501 unittests/common-utils-selftests.c,
3502 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3503 unittests/format_pieces-selftests.c,
3504 unittests/function-view-selftests.c,
3505 unittests/lookup_name_info-selftests.c,
3506 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3507 unittests/mkdir-recursive-selftests.c,
3508 unittests/observable-selftests.c,
3509 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3510 unittests/parse-connection-spec-selftests.c,
3511 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3512 unittests/scoped_fd-selftests.c,
3513 unittests/scoped_mmap-selftests.c,
3514 unittests/scoped_restore-selftests.c,
3515 unittests/string_view-selftests.c, unittests/style-selftests.c,
3516 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3517 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3518 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3519 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3520 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3521 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3522
5b0e2db4
AB
35232019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3524
3525 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3526 bool value.
3527 (decode_digits_ordinary): Set explicit_line field in sal.
3528 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3529 symtab_and_line that was set on an explicit line number in
3530 assembler code. Do always update the recorded symtab and line if
3531 we do skip the prologue.
3532
0ba852ab
AB
35332019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3534
3535 * breakpoint.c (set_breakpoint_location_function): Remove
3536 explicit_loc parameter.
3537 (momentary_breakpoint_from_master): Update call to
3538 set_breakpoint_location_function.
3539 (add_location_to_breakpoint): Likewise.
3540
b3a7d171
AB
35412019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3542
3543 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3544 required features based on default bfd type when no specific bfd
3545 is present.
3546
1f6f6e21
PW
35472019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3548
3549 * NEWS: Mention that GDB printf and eval commands can now print
3550 C-style and Ada-style convenience var strings without
3551 calling the inferior.
3552 * printcmd.c (printf_c_string): Locally print GDB internal var
3553 instead of transiting via the inferior.
3554 (printf_wide_c_string): Likewise.
3555
35562019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
3557
3558 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3559
0598af48
TT
35602019-07-04 Tom Tromey <tom@tromey.com>
3561
3562 PR tui/24724:
3563 * tui/tui-winsource.c (tui_clear_source_content): Update.
3564 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3565 (tui_update_breakpoint_info): Update.
3566 (tui_set_exec_info_content): Update.
3567 * tui/tui-source.c (tui_set_source_content_nil): Update.
3568 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3569 has_break.
3570 * tui/tui-data.h (enum tui_bp_flag): New.
3571 (tui_bp_flags): New enum flags type.
3572 (struct tui_source_element) <break_mode>: Change type. Rename
3573 from has_break.
3574 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3575 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3576 constants.
3577 * tui/tui-winsource.h: Fix comment.
3578
350fab54
AH
35792019-07-04 Alan Hayward <alan.hayward@arm.com>
3580
3581 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3582 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3583 (store_fpregs_to_thread)
3584 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3585 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3586 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3587 (IWMMXT_REGS_SIZE): Add define.
3588 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3589 (fetch_vfp_regs, store_vfp_regs)
3590 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3591 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3592
f0452268
AH
35932019-07-04 Alan Hayward <alan.hayward@arm.com>
3594
3595 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3596 defines.
3597 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3598 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3599 (ARM_INT_REGISTER_SIZE): ...to this.
3600 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3601 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3602 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3603 (arm_linux_collect_gregset, supply_nwfpe_register)
3604 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3605 defines.
3606 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3607 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3608 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3609 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3610 (arm_return_in_memory, arm_store_return_value)
3611 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3612 (arm_record_ld_st_multiple): Likewise.
3613 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3614 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3615
e935475c
AH
36162019-07-04 Alan Hayward <alan.hayward@arm.com>
3617
3618 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3619 AARCH64_DISPLACED_MODIFIED_INSNS.
3620 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3621 (aarch64_displaced_step_copy_insn): Likewise.
3622 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3623 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3624 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3625 ARM_DISPLACED_MODIFIED_INSNS.
3626 * arm-tdep.c (arm_gdbarch_init): Likewise.
3627 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3628 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3629 (struct arm_displaced_step_closure): Use
3630 ARM_DISPLACED_MODIFIED_INSNS.
3631
df0bb381
AH
36322019-07-04 Alan Hayward <alan.hayward@arm.com>
3633
3634 * features/Makefile: Remove unused xml files.
3635 * features/aarch64.xml: Remove.
3636 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3637 * features/i386/amd64-avx-avx512.xml: Remove.
3638 * features/i386/amd64-avx-linux.xml: Remove.
3639 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3640 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3641 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3642 * features/i386/amd64-avx-mpx.xml: Remove.
3643 * features/i386/amd64-avx.xml: Remove.
3644 * features/i386/amd64-linux.xml: Remove.
3645 * features/i386/amd64-mpx-linux.xml: Remove.
3646 * features/i386/amd64-mpx.xml: Remove.
3647 * features/i386/amd64.xml: Remove.
3648 * features/i386/i386-avx-avx512-linux.xml: Remove.
3649 * features/i386/i386-avx-avx512.xml: Remove.
3650 * features/i386/i386-avx-linux.xml: Remove.
3651 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3652 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3653 * features/i386/i386-avx-mpx-linux.xml: Remove.
3654 * features/i386/i386-avx-mpx.xml: Remove.
3655 * features/i386/i386-avx.xml: Remove.
3656 * features/i386/i386-linux.xml: Remove.
3657 * features/i386/i386-mmx-linux.xml: Remove.
3658 * features/i386/i386-mmx.xml: Remove.
3659 * features/i386/i386-mpx-linux.xml: Remove.
3660 * features/i386/i386-mpx.xml: Remove.
3661 * features/i386/i386.xml: Remove.
3662 * features/i386/x32-avx-avx512-linux.xml: Remove.
3663 * features/i386/x32-avx-linux.xml: Remove.
3664 * features/i386/x32-linux.xml: Remove.
3665
edd6266a
AH
36662019-07-04 Alan Hayward <alan.hayward@arm.com>
3667
3668 * regformats/aarch64.dat: Remove.
3669 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3670 * regformats/i386/amd64-avx-linux.dat: Remove.
3671 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3672 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3673 * regformats/i386/amd64-linux.dat: Remove.
3674 * regformats/i386/amd64-mpx-linux.dat: Remove.
3675 * regformats/i386/amd64.dat: Remove.
3676 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3677 * regformats/i386/i386-avx-linux.dat: Remove.
3678 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3679 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3680 * regformats/i386/i386-linux.dat: Remove.
3681 * regformats/i386/i386-mmx-linux.dat: Remove.
3682 * regformats/i386/i386-mpx-linux.dat: Remove.
3683 * regformats/i386/i386.dat: Remove.
3684 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3685 * regformats/i386/x32-avx-linux.dat: Remove.
3686 * regformats/i386/x32-linux.dat: Remove.
3687
2b40fda7
AH
36882019-07-04 Alan Hayward <alan.hayward@arm.com>
3689
3690 * aarch64-tdep.c: Remove xml self tests.
3691 * amd64-linux-tdep.c: Likewise.
3692 * amd64-tdep.c: Likewise.
3693 * i386-linux-tdep.c: Likewise.
3694 * i386-tdep.c: Likewise.
3695
5f4ba3e7
PA
36962019-07-03 Pedro Alves <palves@redhat.com>
3697
3698 PR cli/24732
3699 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3700 (pipe_cmd_option_defs): New.
3701 (make_pipe_cmd_options_def_group): New.
3702 (pipe_command): Use gdb::option::process_options.
3703 (pipe_command_completer): New function.
3704 (_initialize_cli_cmds): Install completer for "pipe" command.
3705
3d9be6f5
PA
37062019-07-03 Pedro Alves <palves@redhat.com>
3707
3708 * cli/cli-option.c (union option_value) <string>: New field.
3709 (struct option_def_and_value): Add ctor, move ctor, dtor and
3710 use DISABLE_COPY_AND_ASSIGN.
3711 (option_def_and_value::clear_value): New.
3712 (parse_option, save_option_value_in_ctx, get_val_type_str)
3713 (add_setshow_cmds_for_options): Handle var_string.
3714 * cli-option.h (union option_def::var_address) <string>: New
3715 field.
3716 (struct string_option_def): New.
3717 * maint-test-options.c (struct test_options_opts): Add default
3718 ctor and use DISABLE_COPY_AND_ASSIGN.
3719 <string_opt>: New field.
3720 (test_options_opts::~test_options_opts): New.
3721 (test_options_opts::dump): Also dump "-string".
3722 (test_options_option_defs): Install "string.
3723
41fc454c
PA
37242019-07-03 Pedro Alves <palves@redhat.com>
3725
3726 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3727 option_value with a null enumeration.
3728 (complete_options): Save the option values in the context.
3729 (save_option_value_in_ctx): New, factored out from ...
3730 (process_options): ... here.
3731 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3732 of the function.
3733 * maint-test-options.c (test_options_opts::dump): New, factored
3734 out from ...
3735 (maintenance_test_options_command_mode): ... here.
3736 (maintenance_test_options_command_completion_result): Delete.
3737 (maintenance_test_options_command_completion_text): Update
3738 comment.
3739 (maintenance_show_test_options_completion_result): Change
3740 prototype. Just print
3741 maintenance_test_options_command_completion_text.
3742 (save_completion_result): New.
3743 (maintenance_test_options_completer_mode): Pass options context to
3744 complete_options, and then save a dump.
3745 (_initialize_maint_test_options): Use add_cmd to install "maint
3746 show test-options-completion-result".
3747
fdbc9870
PA
37482019-07-03 Pedro Alves <palves@redhat.com>
3749
3750 * NEWS (New commands): Mention "with" and "maint with".
3751 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3752 (with_command, with_command_completer): New.
3753 (pipe_command): Adjust to new repeat_previous
3754 interface.
3755 (_initialize_cli_cmds): Install the "with" command and its "w"
3756 alias.
3757 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3758 declarations.
3759 * cli/cli-setshow.c (parse_cli_var_uinteger)
3760 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3761 argument strings for all var_types.
3762 (get_setshow_command_value_string): New, factored out from ...
3763 (do_show_command): ... this.
3764 * cli/cli-setshow.h: Include <string>.
3765 (get_setshow_command_value_string): Declare.
3766 * command.h (repeat_previous): Now returns const char *. Adjust
3767 comment.
3768 * maint.c: Include "cli/cli-cmds.h".
3769 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3770 (_initialize_maint_cmds): Register the "maintenance with" command.
3771 * top.c (repeat_previous): Move bits from pipe_command here:
3772 Return the saved command line, if any; error out if there's no
3773 command to relaunch.
3774
c6ac8931
PA
37752019-07-03 Pedro Alves <palves@redhat.com>
3776
3777 * NEWS (New commands): Mention "maint set/show test-settings"
3778 instead of "maint test-settings".
3779 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3780 (maintenance_test_settings_set_list): Rename to ...
3781 (maintenance_set_test_settings_list): ... this.
3782 (maintenance_test_settings_show_list): Rename to ...
3783 (maintenance_show_test_settings_list): ... this.
3784 (maintenance_test_settings_cmd): Delete.
3785 (maintenance_test_settings_set_cmd): ...
3786 (maintenance_set_test_settings_cmd): ... this.
3787 (maintenance_test_settings_show_cmd): ...
3788 (maintenance_show_test_settings_cmd): ... this.
3789 (maintenance_test_settings_show_value_cmd):
3790 (maintenance_show_test_settings_value_cmd): ... this.
3791 (_initialize_maint_test_settings): No longer install the "maint
3792 test-settings" prefix command. Rename "maint test-settings set"
3793 to "maint set test-settings", and "maint test-settings show" to
3794 "maint show test-settings". Adjust all subcommands.
3795
d1fcf2fd
PA
37962019-07-03 Pedro Alves <palves@redhat.com>
3797
3798 * maint-test-settings.c: Fix file's intro comment. Replace all
3799 references to "test-options" with references to "test-settings",
3800 in comments.
3801
970f9d09
PA
38022019-07-03 Pedro Alves <palves@redhat.com>
3803
3804 * maint-test-settings.c (maintenance_test_settings_xxx)
3805 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3806 New.
3807 (maintenance_test_settings_enums): Use them.
3808 (maintenance_test_settings_enum): Default to
3809 maintenance_test_settings_xxx.
3810 (_initialize_maint_test_settings): Initialize
3811 MAINTENANCE_TEST_SETTINGS_FILENAME.
3812
f3869b1a
SM
38132019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3814
3815 * breakpoint.h (remove_breakpoints_inf): Change return type to
3816 void, move function documentation here.
3817 * breakpoint.c (remove_breakpoints_inf): Change return type to
3818 void, move function documentation to header.
3819
54d66006
PA
38202019-07-02 Pedro Alves <palves@redhat.com>
3821
3822 * NEWS (Completion improvements): Mention "info threads".
3823 * thread.c (struct info_threads_opts, info_threads_option_defs)
3824 (make_info_threads_options_def_group): New.
3825 (info_threads_command): Use gdb::option::process_options.
3826 (info_threads_command_completer): New.
3827 (_initialize_thread): Use gdb::option::build_help to build the
3828 help text for "info threads".
3829
854f6088
SM
38302019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3831
3832 * defs.h (generic_load): Move from here...
3833 * symfile.h (generic_load): ... to here. Rename name parameter
3834 to args.
3835 * symfile.c (generic_load): Add comment.
3836
54ee4252
TT
38372019-07-01 Tom Tromey <tromey@adacore.com>
3838
3839 * dwarf2read.c
3840 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3841 declaration of without_params. Fix formatting.
3842
65392b3e
TT
38432019-07-01 Tom Tromey <tromey@adacore.com>
3844
3845 * ada-exp.y (find_primitive_type): Update.
3846 * ada-lang.h (ada_lookup_symbol): Update.
3847 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3848 parameter.
3849 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3850
7d7571f0
SDJ
38512019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3852
3853 PR breakpoints/24541
3854 * gdbarch.c: Regenerate.
3855 * gdbarch.h: Regenerate.
3856 * gdbarch.sh: Add 'stap_adjust_register'.
3857 * i386-tdep.c: Include '<unordered_set>'.
3858 (i386_stap_adjust_register): New function.
3859 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3860 * stap-probe.c (stap_parse_register_operand): Call
3861 'gdbarch_stap_adjust_register'.
3862
5af5392a
SDJ
38632019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3864
3865 PR python/24742
3866 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3867 * python/python.c (do_start_initialization): Use 'xmalloc'
3868 instead of 'PyMem_Malloc'.
3869
10d06d82
TT
38702019-06-28 Tom Tromey <tromey@adacore.com>
3871
3872 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3873 for Ada.
3874
1b7f24cd
TT
38752019-06-27 Tom Tromey <tromey@adacore.com>
3876
3877 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3878 objfile_key.
3879 (arm_find_mapping_symbol, arm_record_special_symbol)
3880 (_initialize_arm_tdep): Update.
3881 (arm_objfile_data_free): Remove.
3882
3d507ff2
TT
38832019-06-27 Tom Tromey <tromey@adacore.com>
3884
3885 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3886 to cp_print_static_field.
3887
762c164d
TT
38882019-06-26 Tom Tromey <tromey@adacore.com>
3889
3890 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3891 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3892 declare.
3893
aa2f9bcf
AH
38942019-06-26 Alan Hayward <alan.hayward@arm.com>
3895
3896 * features/aarch64-core.c (create_feature_aarch64_core):
3897 Regenerate.
3898 * features/aarch64-core.xml: Add cpsr flags.
3899
3426ae57
AH
39002019-06-26 Alan Hayward <alan.hayward@arm.com>
3901
3902 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3903 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3904
4838e44c
SM
39052019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3906
3907 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3908 field.
3909 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3910 use.
3911 (arm_record_special_symbol): Don't insert new symbol in sorted
3912 position, push it at the end.
3913
54cc7474
SM
39142019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3915
3916 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3917 (arm_mapping_symbol_s): Remove.
3918 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3919 (arm_mapping_symbol_vec): New typedef.
3920 (struct arm_per_objfile): Add constructor.
3921 <section_maps>: Change type to
3922 std::unique_ptr<arm_mapping_symbol_vec[]>.
3923 (arm_compare_mapping_symbols): Remove.
3924 (arm_find_mapping_symbol): Adjust to section_maps type change.
3925 (arm_objfile_data_free): Call delete on arm_per_objfile.
3926 (arm_record_special_symbol): Adjust to section_maps type change.
3927 Allocate arm_per_objfile with new.
3928
b65b566c
PW
39292019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3930
3931 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3932 with the command prefix.
3933
c2fc64f5
TT
39342019-06-25 Tom Tromey <tom@tromey.com>
3935
3936 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3937 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3938
fb54fa76
TT
39392019-06-25 Tom Tromey <tom@tromey.com>
3940
3941 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3942 type.
3943 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3944 protected.
3945
f7952c57
TT
39462019-06-25 Tom Tromey <tom@tromey.com>
3947
3948 * tui/tui-winsource.c
3949 (tui_source_window_base::set_is_exec_point_at): Add check against
3950 LOA_ADDRESS.
3951
17568d78
TT
39522019-06-25 Tom Tromey <tom@tromey.com>
3953
3954 * tui/tui-source.c (tui_set_source_content): Don't check before
3955 xfree.
3956 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3957
53e7cdba
TT
39582019-06-25 Tom Tromey <tom@tromey.com>
3959
3960 * tui/tui-winsource.h (tui_update_source_window_as_is)
3961 (tui_alloc_source_buffer, tui_line_is_displayed)
3962 (tui_addr_is_displayed): Change type of win_info.
3963 * tui/tui-winsource.c (tui_update_source_window_as_is)
3964 (tui_clear_source_content, tui_show_source_line)
3965 (tui_show_source_content, tui_source_window_base::refill)
3966 (tui_source_window_base::set_is_exec_point_at)
3967 (tui_source_window_base::set_is_exec_point_at)
3968 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3969 (tui_alloc_source_buffer, tui_line_is_displayed)
3970 (tui_addr_is_displayed): Change type of win_info. Update.
3971 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3972 (tui_source_window_base::do_make_visible_with_new_height):
3973 Update.
3974 * tui/tui-source.c (tui_set_source_content)
3975 (tui_set_source_content_nil)
3976 (tui_source_window::do_scroll_vertical): Update.
3977 * tui/tui-layout.c (show_layout): Update.
3978 * tui/tui-disasm.c (tui_set_disassem_content)
3979 (tui_disasm_window::do_scroll_vertical): Update.
3980 * tui/tui-data.h (tui_win_content): Remove.
3981 (struct tui_gen_win_info) <content, content_size>: Remove.
3982 (struct tui_source_element): Add initializers and destructor.
3983 (union tui_which_element, struct tui_win_element): Remove.
3984 (struct tui_source_window_base) <content>: New field.
3985 (struct tui_data_window): Remove destructor.
3986 (tui_alloc_content, tui_free_win_content)
3987 (tui_free_all_source_wins_content): Don't declare.
3988 * tui/tui-data.c (tui_initialize_static_data): Update.
3989 (init_content_element, tui_alloc_content): Remove.
3990 (~tui_gen_win_info): Update.
3991 (~tui_data_window, tui_free_all_source_wins_content)
3992 (tui_free_win_content, free_content, free_content_elements):
3993 Remove.
3994
7908abbf
TT
39952019-06-25 Tom Tromey <tom@tromey.com>
3996
3997 * tui/tui-winsource.h (tui_clear_source_content)
3998 (tui_erase_source_content, tui_show_source_content): Change type
3999 of win_info.
4000 * tui/tui-winsource.c (tui_clear_source_content)
4001 (tui_erase_source_content, tui_show_source_content): Change type
4002 of win_info.
4003 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4004 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4005 win_info.
4006 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4007 win_info.
4008 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4009
02c28df0
TT
40102019-06-25 Tom Tromey <tom@tromey.com>
4011
4012 * tui/tui-winsource.c (tui_clear_source_content)
4013 (tui_source_window_base::set_is_exec_point_at): Update.
4014 * tui/tui-source.c (tui_set_source_content_nil): Update.
4015 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4016 a bool.
4017 * tui/tui-data.c (init_content_element): Update.
4018
6658b1bf
TT
40192019-06-25 Tom Tromey <tom@tromey.com>
4020
4021 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4022 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4023 * tui/tui-layout.c (init_and_make_win): Update.
4024 * tui/tui.h (enum tui_win_type): Update.
4025 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4026 tui_win_is_auxillary.
4027 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4028 tui_win_is_auxillary.
4029
21e1c91e
TT
40302019-06-25 Tom Tromey <tom@tromey.com>
4031
4032 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4033 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4034 (tui_delete_data_content_windows, tui_display_all_data)
4035 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4036 Update.
4037 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4038 * tui/tui-regs.c (tui_last_regs_line_no)
4039 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4040 (tui_show_registers): Update.
4041 (tui_show_register_group): Return void. Update.
4042 (tui_display_registers_from, tui_display_reg_element_at_line)
4043 (tui_display_registers_from_line, tui_check_register_values):
4044 Update.
4045 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4046 member.
4047 (struct tui_data_window) <regs_content>: Now a std::vector.
4048 <regs_content_count>: Remove.
4049 (tui_add_content_elements, tui_free_data_content): Don't declare.
4050 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4051 (init_content_element): Remove DATA_WIN case. Add assert.
4052 (tui_add_content_elements): Remove.
4053 (tui_data_window): Update.
4054 (tui_free_data_content): Remove.
4055 (free_content_elements): Remove DATA_WIN case.
4056
115ac53b
TT
40572019-06-25 Tom Tromey <tom@tromey.com>
4058
4059 * tui/tui-data.c (tui_data_item_window): Update.
4060 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4061 * tui/tui-windata.c (tui_display_all_data)
4062 (tui_display_data_from_line): Update.
4063 (tui_check_data_values): Remove.
4064 * tui/tui-regs.c (tui_show_register_group)
4065 (tui_display_reg_element_at_line): Update.
4066 * tui/tui-hooks.c (tui_register_changed)
4067 (tui_refresh_frame_and_register_information): Call
4068 tui_check_register_values.
4069 * tui/tui-data.h (struct tui_data_window) <data_content,
4070 data_content_count, data_type>: Remove.
4071 (enum tui_data_type): Remove.
4072
4073 * tui/tui-data.c (tui_data_window::clear_detail)
4074 (~tui_data_window): Update.
4075
eaf9738b
TT
40762019-06-25 Tom Tromey <tom@tromey.com>
4077
4078 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4079 declare.
4080 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4081 Rename from tui_first_data_item_displayed. Update.
4082 (tui_data_window::refresh_all)
4083 (tui_data_window::do_scroll_vertical): Update.
4084 * tui/tui-data.h (struct tui_data_window)
4085 <first_data_item_displayed>: Declare new method.
4086
31ca4723
TT
40872019-06-25 Tom Tromey <tom@tromey.com>
4088
4089 * tui/tui-data.h (tui_init_generic_part): Don't declare.
4090 * tui/tui-data.c (tui_init_generic_part): Remove, moving
4091 contents...
4092 (tui_initialize_static_data): ...here.
4093
41bcff7f
TT
40942019-06-25 Tom Tromey <tom@tromey.com>
4095
4096 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4097 (tui_display_registers_from, tui_check_register_values): Update.
4098 (tui_display_register): Remove win_info parameter; update.
4099 (tui_get_register): Change type of parameters.
4100 * tui/tui-data.h (struct tui_data_element): Remove.
4101 (union tui_which_element) <data>: Remove.
4102 <data_window>: Change type.
4103 (struct tui_data_item_window): New.
4104 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4105 case. Add assert.
4106 (~tui_data_item_window): New destructor.
4107 (free_content_elements): Remove DATA_ITEM_WIN case.
4108
d2802c33
TT
41092019-06-25 Tom Tromey <tom@tromey.com>
4110
4111 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4112 Remove.
4113
dd835f8b
TT
41142019-06-25 Tom Tromey <tom@tromey.com>
4115
4116 * tui/tui-data.h (struct tui_command_element): Remove.
4117 (union tui_which_element) <command>: Remove.
4118 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
4119 assert.
4120 (free_content_elements): Remove CMD_WIN case.
4121
bd7db367
TT
41222019-06-25 Tom Tromey <tom@tromey.com>
4123
4124 * tui/tui-layout.c (tui_set_layout): Update.
4125 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4126 * tui/tui-data.c (layout_def): Update.
4127
3add462f
TT
41282019-06-25 Tom Tromey <tom@tromey.com>
4129
4130 * tui/tui-wingeneral.c (tui_refresh_all): Update.
4131 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4132 (tui_source_window_base::set_new_height): Update.
4133 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4134 Update.
4135 (tui_set_locator_fullname, tui_set_locator_info)
4136 (tui_show_frame_info): Update.
4137 * tui/tui-source.c (tui_set_source_content)
4138 (tui_source_is_displayed): Update.
4139 * tui/tui-layout.c (show_source_disasm_command, show_data)
4140 (show_source_or_disasm_and_command): Update.
4141 * tui/tui-disasm.c (tui_set_disassem_content)
4142 (tui_get_begin_asm_address): Update.
4143 * tui/tui-data.h (struct tui_locator_element): Remove.
4144 (union tui_which_element) <locator>: Remove.
4145 (struct tui_locator_window): New.
4146 (tui_locator_win_info_ptr): Change return type.
4147 * tui/tui-data.c (_locator): Change type.
4148 (tui_locator_win_info_ptr): Change return type.
4149 (init_content_element): Remove LOCATOR_WIN case. Add assert.
4150 (tui_alloc_content): Add assert.
4151
489e9d8b
TT
41522019-06-25 Tom Tromey <tom@tromey.com>
4153
4154 * tui/tui-winsource.c
4155 (tui_exec_info_window::maybe_allocate_content): New method.
4156 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4157 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4158 (make_source_or_disasm_window): Add cast.
4159 * tui/tui-data.h (union tui_which_element) <simple_string>:
4160 Remove.
4161 (struct tui_source_info): New.
4162 (struct tui_source_window_base) <execution_info>: Change type.
4163 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4164 case, and add assert.
4165 (tui_alloc_content): Add assert.
4166
c3fabb7d
TT
41672019-06-25 Tom Tromey <tom@tromey.com>
4168
4169 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4170 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4171 * tui/tui-data.c (tui_alloc_win_info): Remove.
4172
bbc228ee
TT
41732019-06-25 Tom Tromey <tom@tromey.com>
4174
4175 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4176 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4177 can_highlight.
4178
5fcee43a
TT
41792019-06-25 Tom Tromey <tom@tromey.com>
4180
4181 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4182 make_visible_with_new_height method.
4183 (tui_win_info::make_visible_with_new_height): New method.
4184 (tui_source_window_base::do_make_visible_with_new_height)
4185 (tui_data_window::do_make_visible_with_new_height)
4186 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4187 (make_visible_with_new_height): Remove.
4188 (tui_resize_all, tui_adjust_win_heights): Use
4189 make_visible_with_new_height method.
4190 * tui/tui-data.h (struct tui_win_info)
4191 <do_make_visible_with_new_height, make_visible_with_new_height>:
4192 New methods.
4193 (struct tui_source_window_base, struct tui_data_window)
4194 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4195 methods.
4196
d83f1fe6
TT
41972019-06-25 Tom Tromey <tom@tromey.com>
4198
4199 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4200 method.
4201 (update_tab_width): Call update_tab_width method.
4202 * tui/tui-data.h (struct tui_win_info)
4203 (struct tui_source_window_base) <update_tab_width>: New methods.
4204
17374de4
TT
42052019-06-25 Tom Tromey <tom@tromey.com>
4206
4207 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4208 parameter.
4209 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4210 parameter.
4211 (tui_gen_win_info::make_visible): Update.
4212 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4213 parameter.
4214 * tui/tui-data.h (enum tui_box): New enum.
4215 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4216
f936bca2
TT
42172019-06-25 Tom Tromey <tom@tromey.com>
4218
4219 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4220 init_and_make_win for EXEC_INFO_WIN.
4221 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4222 longer inline.
4223 (struct tui_win_info) <~tui_win_info>: Inline.
4224 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4225 Don't declare.
4226 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4227 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4228 Remove.
4229 (tui_initialize_static_data): Update.
4230 (~tui_gen_win_info): Handle more cleanup here.
4231 (~tui_source_window_base): Delete "execution_info".
4232 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4233
d6ba6a11
TT
42342019-06-25 Tom Tromey <tom@tromey.com>
4235
4236 * tui/tui-layout.c (make_command_window): Don't set
4237 can_highlight.
4238 (show_source_disasm_command): Call the reset method.
4239 (show_data): Don't set can_highlight. Call the reset method.
4240 (tui_gen_win_info::reset): Rename from init_gen_win_info
4241 (init_and_make_win): Simplify. Return tui_gen_win_info.
4242 (show_source_or_disasm_and_command): Call the reset method.
4243 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4244 (struct tui_cmd_window): Set can_highlight.
4245
48a3bd16
TT
42462019-06-25 Tom Tromey <tom@tromey.com>
4247
4248 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4249 from make_visible.
4250 (tui_make_visible, tui_make_invisible): Rewrite.
4251 (tui_win_info::make_visible): Remove.
4252 (tui_source_window_base::make_visible): Update.
4253 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4254 method. Moved from...
4255 (struct tui_win_info) <make_visible>: ...here.
4256
c3bd716f
TT
42572019-06-25 Tom Tromey <tom@tromey.com>
4258
4259 * tui/tui-winsource.c
4260 (tui_source_window_base::do_scroll_horizontal): Remove direction
4261 parameter.
4262 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4263 direction parameter.
4264 * tui/tui-win.c (tui_win_info::forward_scroll)
4265 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4266 (tui_win_info::right_scroll): Update.
4267 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4268 direction parameter.
4269 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4270 direction parameter.
4271 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4272 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4273 Remove direction parameter.
4274 (struct tui_source_window_base, struct tui_source_window)
4275 (struct tui_disasm_window, struct tui_data_window)
4276 (struct tui_cmd_window): Update.
4277
21c32dca
TT
42782019-06-25 Tom Tromey <tom@tromey.com>
4279
4280 * tui/tui-winsource.h (tui_set_exec_info_content)
4281 (tui_show_exec_info_content, tui_erase_exec_info_content)
4282 (tui_clear_exec_info_content, tui_update_exec_info): Change
4283 argument to tui_source_window_base.
4284 * tui/tui-winsource.c (tui_set_exec_info_content)
4285 (tui_show_exec_info_content, tui_erase_exec_info_content)
4286 (tui_clear_exec_info_content, tui_update_exec_info): Change
4287 argument to tui_source_window_base.
4288
73fbdc65
TT
42892019-06-25 Tom Tromey <tom@tromey.com>
4290
4291 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4292 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4293
33325343
TT
42942019-06-25 Tom Tromey <tom@tromey.com>
4295
4296 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4297 check.
4298
29d2c474
TT
42992019-06-25 Tom Tromey <tom@tromey.com>
4300
4301 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4302 type to void.
4303 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4304 type to void.
4305 * tui/tui-source.c (tui_set_source_content): Update.
4306 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4307
152f3f4b
TT
43082019-06-25 Tom Tromey <tom@tromey.com>
4309
4310 * tui/tui-win.c (window_name_completer, tui_set_focus)
4311 (tui_all_windows_info): Use name method.
4312 * tui/tui-data.h (struct tui_gen_win_info)
4313 (struct tui_source_window, struct tui_disasm_window)
4314 (struct tui_data_window, struct tui_cmd_window) <name>: New
4315 method.
4316 (tui_win_name): Don't declare.
4317 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4318 (tui_win_name): Remove.
4319
be4da588
TT
43202019-06-25 Tom Tromey <tom@tromey.com>
4321
4322 * tui/tui-winsource.h (tui_update_source_window)
4323 (tui_update_source_window_as_is): Change parameter type.
4324 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4325 to be a tui_source_window_base.
4326 (tui_update_source_window_as_is): Likewise.
4327 * tui/tui-win.c (make_visible_with_new_height): Update.
4328
5b81daba
TT
43292019-06-25 Tom Tromey <tom@tromey.com>
4330
4331 * tui/tui-winsource.c (tui_erase_source_content)
4332 (tui_show_source_content, tui_show_exec_info_content)
4333 (tui_erase_exec_info_content): Use refresh_window method.
4334 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4335 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4336 from tui_refresh_win.
4337 (tui_data_window::refresh_window): New method.
4338 (tui_win_info::refresh, tui_source_window_base::refresh)
4339 (tui_refresh_all): Use refresh_window method.
4340 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4341 method.
4342 * tui/tui-regs.c (tui_display_register): Call refresh_window
4343 method.
4344 * tui/tui-layout.c (show_source_disasm_command)
4345 (show_source_or_disasm_and_command): Call refresh_window method.
4346 * tui/tui-data.h (struct tui_gen_win_info)
4347 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4348 New method.
4349
cb2ce893
TT
43502019-06-25 Tom Tromey <tom@tromey.com>
4351
4352 * tui/tui.c (tui_rl_other_window, tui_enable)
4353 (tui_is_window_visible, tui_get_command_dimension): Update.
4354 * tui/tui-winsource.c (tui_update_source_window_as_is)
4355 (tui_clear_source_content, tui_erase_source_content)
4356 (tui_show_source_line, tui_source_window_base::refill)
4357 (tui_source_window_base::do_scroll_horizontal)
4358 (tui_source_window_base::set_is_exec_point_at)
4359 (tui_update_breakpoint_info, tui_set_exec_info_content)
4360 (tui_alloc_source_buffer, tui_line_is_displayed)
4361 (tui_addr_is_displayed): Update.
4362 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4363 (tui_check_and_display_highlight_if_needed)
4364 (tui_win_info::make_visible, tui_win_info::refresh)
4365 (tui_refresh_all): Update.
4366 * tui/tui-windata.c (tui_first_data_item_displayed)
4367 (tui_delete_data_content_windows, tui_erase_data_content)
4368 (tui_display_all_data, tui_data_window::refresh_all)
4369 (tui_check_data_values): Update.
4370 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4371 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4372 (tui_win_info::backward_scroll, tui_refresh_all_win)
4373 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4374 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4375 (tui_source_window_base::set_new_height)
4376 (tui_data_window::set_new_height)
4377 (make_invisible_and_set_new_height)
4378 (make_visible_with_new_height, new_height_ok)
4379 (parse_scrolling_args): Update.
4380 * tui/tui-stack.c (tui_show_frame_info): Update.
4381 * tui/tui-source.c (tui_set_source_content)
4382 (tui_set_source_content_nil, tui_source_is_displayed)
4383 (tui_source_window::do_scroll_vertical): Update.
4384 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4385 (tui_display_registers_from, tui_display_reg_element_at_line)
4386 (tui_check_register_values, tui_reg_command): Update.
4387 * tui/tui-layout.c (tui_default_win_height)
4388 (show_source_disasm_command, show_data, init_and_make_win)
4389 (show_source_or_disasm_and_command): Update.
4390 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4391 (tui_redisplay_readline, tui_mld_flush)
4392 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4393 (tui_getc): Update.
4394 * tui/tui-disasm.c (tui_set_disassem_content)
4395 (tui_disasm_window::do_scroll_vertical): Update.
4396 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4397 Now virtual.
4398 (struct tui_win_info): Derive from tui_gen_win_info.
4399 <~tui_win_info>: Mark as override.
4400 <generic>: Remove member.
4401 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4402 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4403 (~tui_data_window, ~tui_win_info)
4404 (tui_free_all_source_wins_content): Update.
4405 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4406
ab313b35
TT
44072019-06-25 Tom Tromey <tom@tromey.com>
4408
4409 * tui/tui-layout.c (init_and_make_win): Use new.
4410 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4411 destructor, initializers.
4412 (tui_alloc_generic_win_info): Don't declare.
4413 * tui/tui-data.c (_locator): Add argument to constructor.
4414 (source_win, disasm_win): New globals.
4415 (exec_info): Remove.
4416 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4417 Update.
4418 (tui_alloc_generic_win_info): Remove.
4419 (init_content_element): Use new.
4420 (tui_win_info::tui_win_info): Update.
4421 (free_content_elements) <case DATA_WIN>: Use delete.
4422
dc2c33e4
TT
44232019-06-25 Tom Tromey <tom@tromey.com>
4424
4425 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4426 * tui/tui-windata.c (tui_first_data_item_displayed)
4427 (tui_delete_data_content_windows): Update.
4428 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4429 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4430 (tui_display_registers_from, tui_check_register_values): Update.
4431 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4432 pointer.
4433 * tui/tui-data.c (init_content_element): Update. Allocate the new
4434 window.
4435 (tui_free_data_content): Update.
4436 (free_content_elements) <case DATA_WIN>: Free the window.
4437
214a5cbe
TT
44382019-06-25 Tom Tromey <tom@tromey.com>
4439
4440 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4441 Update.
4442 * tui/tui-layout.c (make_command_window)
4443 (show_source_disasm_command, show_data, init_and_make_win)
4444 (show_source_or_disasm_and_command): Update.
4445 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4446 method.
4447 <can_highight, is_highlighted>: Now bool.
4448 (tui_set_win_highlight): Don't declare.
4449 * tui/tui-data.c (tui_set_win_highlight): Remove.
4450
8e2daf15
TT
44512019-06-25 Tom Tromey <tom@tromey.com>
4452
4453 * tui/tui-wingeneral.c (make_visible): Remove check of window
4454 type.
4455
8903bd8a
TT
44562019-06-25 Tom Tromey <tom@tromey.com>
4457
4458 * tui/tui-win.c (tui_win_info::max_height)
4459 (tui_cmd_window::max_height): New methods.
4460 (new_height_ok): Call max_height.
4461 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4462 <max_height>: New method.
4463
3f02ce1e
TT
44642019-06-25 Tom Tromey <tom@tromey.com>
4465
4466 * tui/tui-win.c (tui_source_window_base::set_new_height)
4467 (tui_data_window::set_new_height): New methods.
4468 (make_invisible_and_set_new_height): Call set_new_height method.
4469 * tui/tui-data.h (struct tui_win_info)
4470 (struct tui_source_window_base, struct tui_data_window)
4471 <set_new_height>: New method.
4472
1825f487
TT
44732019-06-25 Tom Tromey <tom@tromey.com>
4474
4475 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4476 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4477 tui_refresh_data_win.
4478 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4479 method.
4480 (tui_refresh_all_win): Call the refresh_all method.
4481 (tui_set_focus): Likewise.
4482 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4483 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4484 Likewise.
4485
ad54d15b
TT
44862019-06-25 Tom Tromey <tom@tromey.com>
4487
4488 * tui/tui-winsource.h (tui_refill_source_window)
4489 (tui_set_is_exec_point_at): Don't declare.
4490 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4491 (tui_source_window_base::refill): Rename from
4492 tui_refill_source_window.
4493 (tui_source_window_base::do_scroll_horizontal): Update.
4494 (tui_source_window_base::set_is_exec_point_at): Rename from
4495 tui_set_is_exec_point_at.
4496 (tui_update_all_breakpoint_info): Update.
4497 * tui/tui-stack.c (tui_show_frame_info): Update.
4498 * tui/tui-layout.c (show_data): Add cast.
4499 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4500 * tui/tui-data.h (struct tui_source_window_base) <refill,
4501 set_is_exec_point_at>: New methods.
4502 (tui_source_windows, tui_add_to_source_windows): Update types.
4503 (tui_add_to_source_windows): Remove redundant declaration.
4504 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4505 (tui_source_windows): Change return type.
4506 (tui_clear_source_windows_detail): Update.
4507 (tui_add_to_source_windows): Change type of parameter.
4508 (tui_free_all_source_wins_content): Update.
4509
2042b506
TT
45102019-06-25 Tom Tromey <tom@tromey.com>
4511
4512 * tui/tui-wingeneral.c (tui_win_info::refresh)
4513 (tui_source_window_base::refresh): New methods.
4514 (tui_refresh_all): Call the refresh method.
4515 * tui/tui-data.h (struct tui_win_info)
4516 (struct tui_source_window_base) <refresh>: New method.
4517
56122977
TT
45182019-06-25 Tom Tromey <tom@tromey.com>
4519
4520 * tui/tui.h (tui_is_window_visible): Return bool.
4521 * tui/tui.c (tui_is_window_visible): Return bool.
4522 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4523 (tui_make_visible, tui_make_invisible)
4524 (tui_win_info::make_visible)
4525 (tui_source_window_base::make_visible, make_all_visible)
4526 (tui_make_all_visible, tui_make_all_invisible): Update.
4527 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4528 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4529 bool.
4530 (struct tui_win_info, struct tui_source_window_base)
4531 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4532 * tui/tui-data.c (tui_init_generic_part): Update.
4533
cda37efb
TT
45342019-06-25 Tom Tromey <tom@tromey.com>
4535
4536 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4537 (tui_source_window_base::make_visible): New methods.
4538 (make_all_visible): Make method call.
4539 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4540 (struct tui_source_window_base, struct tui_cmd_window): Override
4541 make_visible.
4542 (tui_win_is_source_type): Don't declare.
4543 * tui/tui-data.c (tui_win_is_source_type): Remove.
4544
6a0ee02c
TT
45452019-06-25 Tom Tromey <tom@tromey.com>
4546
4547 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4548 NULL check.
4549
63901aec
TT
45502019-06-25 Tom Tromey <tom@tromey.com>
4551
4552 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4553 Inline constructor. Add initializers for members.
4554 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4555 constructors; now inline in class.
4556
ceb13a13
TT
45572019-06-25 Tom Tromey <tom@tromey.com>
4558
4559 * tui/tui-regs.c (tui_show_registers): Update.
4560 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4561 bool.
4562 * tui/tui-data.c (tui_data_window::clear_detail)
4563 (tui_data_window): Update.
4564
238eb706
TT
45652019-06-25 Tom Tromey <tom@tromey.com>
4566
4567 * tui/tui-windata.c (tui_display_all_data)
4568 (tui_display_data_from_line, tui_display_data_from)
4569 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4570 Update.
4571 * tui/tui-regs.c (tui_last_regs_line_no)
4572 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4573 (tui_show_registers, tui_show_register_group)
4574 (tui_display_registers_from, tui_display_reg_element_at_line)
4575 (tui_display_registers_from_line, tui_check_register_values)
4576 (tui_reg_next, tui_reg_prev): Update.
4577 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4578 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4579 tui_data_window.
4580 (struct tui_win_info) <detail>: Remove. Add new fields from
4581 tui_data_info.
4582 (TUI_DATA_WIN): Add cast.
4583 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4584 (~tui_data_window): Simplify.
4585
81491aa0
TT
45862019-06-25 Tom Tromey <tom@tromey.com>
4587
4588 * tui/tui-layout.c (show_source_disasm_command)
4589 (show_source_or_disasm_and_command): Update.
4590 * tui/tui-io.c (update_cmdwin_start_line)
4591 (tui_redisplay_readline): Update.
4592 * tui/tui-data.h (struct tui_command_info): Remove.
4593 (struct tui_win_info) <detail>: Remove command_info member.
4594 (struct tui_data_window) <start_line>: New member, from
4595 tui_command_info.
4596 (TUI_CMD_WIN): Add casts.
4597
e6e41501
TT
45982019-06-25 Tom Tromey <tom@tromey.com>
4599
4600 * tui/tui-winsource.c (tui_update_source_window)
4601 (tui_refill_source_window)
4602 (tui_source_window_base::do_scroll_horizontal)
4603 (tui_update_breakpoint_info, tui_set_exec_info_content)
4604 (tui_show_exec_info_content, tui_erase_exec_info_content)
4605 (tui_clear_exec_info_content): Update.
4606 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4607 Update.
4608 * tui/tui-win.c (make_invisible_and_set_new_height)
4609 (make_visible_with_new_height): Update.
4610 * tui/tui-source.c (tui_set_source_content)
4611 (tui_show_symtab_source): Update.
4612 * tui/tui-layout.c (extract_display_start_addr)
4613 (show_source_disasm_command, show_data)
4614 (make_source_or_disasm_window)
4615 (show_source_or_disasm_and_command): Update.
4616 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4617 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4618 "gdbarch".
4619 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4620 to tui_source_window_base.
4621 (struct tui_win_info) <detail>: Remove source_info member.
4622 (struct tui_source_window_base) <has_locator>: Inline.
4623 Move contents from tui_source_info; rename has_locator member to
4624 m_has_locator.
4625 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4626 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4627 header file.
4628 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4629 Simplify.
4630 (tui_free_all_source_wins_content): Cast to
4631 tui_source_window_base.
4632
44f0e208
TT
46332019-06-25 Tom Tromey <tom@tromey.com>
4634
4635 * tui/tui-win.c (make_invisible_and_set_new_height)
4636 (make_visible_with_new_height): Call has_locator method.
4637 * tui/tui-layout.c (show_source_disasm_command, show_data)
4638 (show_source_or_disasm_and_command): Update for bool change.
4639 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4640 (tui_win_info) <has_locator>: New method.
4641 (struct tui_source_window_base) <has_locator>: New method.
4642 (tui_win_has_locator): Don't declare.
4643 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4644 from tui_win_has_locator.
4645 (tui_source_window_base): Use false, not FALSE.
4646
7778b912
TT
46472019-06-25 Tom Tromey <tom@tromey.com>
4648
4649 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4650 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4651 clear_detail method directly.
4652 (tui_clear_win_detail): Remove.
4653
f83d391c
TT
46542019-06-25 Tom Tromey <tom@tromey.com>
4655
4656 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4657 "this", not TUI_DISASM_WIN.
4658
13446e05
TT
46592019-06-25 Tom Tromey <tom@tromey.com>
4660
4661 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4662 declare.
4663 * tui/tui-winsource.c
4664 (tui_source_window_base::do_scroll_horizontal): Rename from
4665 tui_horizontal_source_scroll.
4666 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4667 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4668 from tui_vertical_data_scroll.
4669 * tui/tui-win.h (tui_scroll): Don't declare.
4670 * tui/tui-win.c (tui_win_info::forward_scroll)
4671 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4672 (tui_win_info::right_scroll): Rename and update.
4673 (tui_scroll_forward_command, tui_scroll_backward_command)
4674 (tui_scroll_left_command, tui_scroll_right_command): Update.
4675 (tui_scroll): Remove.
4676 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4677 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4678 from tui_vertical_source_scroll.
4679 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4680 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4681 from tui_vertical_disassem_scroll.
4682 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4683 do_scroll_horizontal>: New methods.
4684 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4685 Likewise.
4686 (struct tui_source_window_base): Add do_scroll_horizontal.
4687 (struct tui_source_window, struct tui_disasm_window): Add
4688 do_scroll_vertical.
4689 (struct tui_data_window, struct tui_cmd_window): Add
4690 do_scroll_horizontal and do_scroll_vertical.
4691 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4692
5cf82909
TT
46932019-06-25 Tom Tromey <tom@tromey.com>
4694
4695 * tui/tui-data.h (struct tui_source_window_base): New struct.
4696 (struct tui_source_window): Derive from tui_source_window_base.
4697 (struct tui_disasm_window): New struct.
4698 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4699 from tui_source_window::clear_detail.
4700 (tui_source_window_base): Rename from tui_source_window.
4701 (~tui_source_window_base): Rename from ~tui_source_window.
4702 (tui_alloc_win_info): Create a tui_disasm_window.
4703
ee1d42d6
TT
47042019-06-25 Tom Tromey <tom@tromey.com>
4705
4706 * tui/tui-data.h (struct tui_source_window)
4707 (struct tui_data_window): Declare destructors.
4708 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4709 destructors.
4710 (tui_win_info): Simplify.
4711
b4eb2452
TT
47122019-06-25 Tom Tromey <tom@tromey.com>
4713
4714 * tui/tui-winsource.c (tui_display_main)
4715 (tui_update_source_windows_with_addr)
4716 (tui_update_all_breakpoint_info): Update.
4717 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4718 (new_height_ok, parse_scrolling_args): Update.
4719 * tui/tui-stack.c (tui_show_frame_info): Update.
4720 * tui/tui-data.h (struct tui_list): Remove.
4721 (tui_source_windows): Return a reference to a std::vector.
4722 * tui/tui-data.c (source_windows): Now a std::vector.
4723 (tui_source_windows): Change return type.
4724 (tui_clear_source_windows): Rewrite.
4725 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4726 (tui_free_all_source_wins_content): Rewrite.
4727
8761a91b
TT
47282019-06-25 Tom Tromey <tom@tromey.com>
4729
4730 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4731 (struct tui_data_window, struct tui_cmd_window): Declare
4732 clear_detail method.
4733 * tui/tui-data.c (tui_source_window::clear_detail)
4734 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4735 methods.
4736 (tui_clear_win_detail): Simplify.
4737
0ed69eda
TT
47382019-06-25 Tom Tromey <tom@tromey.com>
4739
4740 * tui/tui-layout.c (make_source_window, make_disasm_window)
4741 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4742 Return the new window.
4743 (show_source_disasm_command, show_data)
4744 (show_source_or_disasm_and_command): Update.
4745
82432e10
TT
47462019-06-25 Tom Tromey <tom@tromey.com>
4747
4748 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4749 parameter. Return the new window.
4750 (show_source_disasm_command): Update and remove NULL check.
4751 (show_source_or_disasm_and_command): Update.
4752
ec328aa5
TT
47532019-06-25 Tom Tromey <tom@tromey.com>
4754
4755 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4756
33b906ab
TT
47572019-06-25 Tom Tromey <tom@tromey.com>
4758
4759 * tui/tui-data.h (struct tui_win_info): Make constructor
4760 protected. Make destructor virtual. Add initializers.
4761 (tui_source_window, tui_data_window, tui_cmd_window): New
4762 classes.
4763 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4764 constructor. Add "type" parameter.
4765 (tui_source_window, tui_data_window, tui_cmd_window): New
4766 constructors.
4767 (tui_alloc_win_info): Instantiate the appropriate subclass.
4768
e7e11af4
TT
47692019-06-25 Tom Tromey <tom@tromey.com>
4770
4771 * tui/tui-win.c (tui_resize_all): Use delete.
4772 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4773 destructor.
4774 (tui_free_window): Don't declare.
4775 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4776 Update.
4777
6792b55e
TT
47782019-06-25 Tom Tromey <tom@tromey.com>
4779
4780 * tui/tui-data.h (struct tui_win_info): Add constructor.
4781 * tui/tui-data.c (tui_alloc_win_info): Use new.
4782 (tui_free_window): Use delete.
4783
f95675e1
TT
47842019-06-22 Tom Tromey <tom@tromey.com>
4785
4786 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4787 declare.
4788 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4789
5bff081c
TT
47902019-06-22 Tom Tromey <tom@tromey.com>
4791
4792 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4793 declare.
4794 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4795
47e3f474
TV
47962019-06-22 Tom de Vries <tdevries@suse.de>
4797
4798 * dwarf2read.c (create_addrmap_from_aranges)
4799 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4800 instead of '%zu'.
4801
fd5866f6
SM
48022019-06-21 Simon Marchi <simon.marchi@efficios.com>
4803
4804 * dwarf2read.h (dwarf2_section_info_def): Remove.
4805 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4806 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4807 std::vector<dwarf2_section_info>.
4808 (struct dwo_file) <~dwo_file>: Remove.
4809 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4810 types field.
4811 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4812 (dwarf2_read_debug_names): Likewise.
4813 (create_debug_types_hash_table): Change parameter type to
4814 array_view, adjust code accordingly.
4815 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4816 (partial_die_info::fixup): Likewise.
4817 (determine_prefix): Likewise.
4818 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4819
fb1eb2f9
SM
48202019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4821
4822 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4823 gdb_bfd_ref_ptr.
4824 <~dwo_file>: Remove call to gdb_bfd_unref.
4825 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4826 gdb_bfd_ref_ptr::get.
4827
51ac9db5
SM
48282019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4829
4830 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4831 type to htab_up.
4832 * dwarf2read.c (struct dwo_file): Initialize fields.
4833 <~dwo_file>: New.
4834 (free_dwo_file): Remove, move content to ~dwo_file.
4835 (struct dwo_file_deleter): Remove.
4836 (dwo_file_up>: Remove custom deleter.
4837 (free_dwo_files): Remove.
4838 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4839 dwo_files.
4840 (process_skeletonless_type_units): Call unique_ptr::get.
4841 (allocate_dwo_file_hash_table): Add deleter to created hash
4842 table. Change return type to htab_up.
4843 (lookup_dwo_file_slot): Don't memset dwo_file, call
4844 unique_ptr::get.
4845 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4846 (create_dwo_unit_in_dwp_v2): Likewise.
4847 (open_and_init_dwo_file): Likewise.
4848 (free_dwo_file_from_slot): Remove.
4849
dc4ccb6f
SM
48502019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4851
4852 * dwarf2read.h (struct dwarf2_section_info) <readin,
4853 is_virtual>: Change type to bool.
4854 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4855 true instead of 1.
4856
e6a1c5cb
TT
48572019-06-19 Tom Tromey <tom@tromey.com>
4858
4859 * tui/tui-data.h (tui_init_content_element): Don't declare.
4860
6f6ffbeb
TT
48612019-06-19 Tom Tromey <tom@tromey.com>
4862
4863 * tui/tui-data.h (tui_init_win_info): Don't declare.
4864
f23f598e
TV
48652019-06-19 Tom de Vries <tdevries@suse.de>
4866
4867 * dwarf2read.h (abstract_to_concrete): Change type to
4868 std::unordered_map<sect_offset, std::vector<sect_offset>,
4869 gdb::hash_enum<sect_offset>>.
4870
680e1bee
TT
48712019-06-19 Tom Tromey <tromey@adacore.com>
4872
4873 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4874 EVAL_AVOID_SIDE_EFFECTS specially.
4875
dcf37923
TT
48762019-06-19 Tom Tromey <tromey@adacore.com>
4877
4878 * source-cache.c (highlighter): New global.
4879 (source_cache::get_source_lines): Create a highlighter on demand.
4880
494986d5
AB
48812019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4882
4883 * defs.h (deprecated_interactive_hook): Delete declaration.
4884 * interps.c (clear_interpreter_hooks): Remove use of
4885 deprecated_interactive_hook.
4886 * top.c (deprecated_interactive_hook): Delete definition.
4887 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4888
3360b6e7
TV
48892019-06-18 Tom de Vries <tdevries@suse.de>
4890
4891 PR gdb/24515
4892 * dwarf2read.h (abstract_to_concrete): Change type from
4893 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4894 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4895 * dwarf2read.c (read_variable): Update.
4896 (dwarf2_fetch_die_loc_sect_off): Update.
4897
310b3441
TV
48982019-06-17 Tom de Vries <tdevries@suse.de>
4899
4900 PR gdb/24617
4901 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4902 accessing parent[parent_len - 1].
4903
ba9777be
PP
49042019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4905
4906 PR gdb/24364
4907 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4908 call dtrace_process_dof with NULL dof.
4909
2b9f6e89
TV
49102019-06-16 Tom de Vries <tdevries@suse.de>
4911
4912 PR gdb/24445
4913 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4914
431b3ead
TT
49152019-06-16 Tom Tromey <tom@tromey.com>
4916
4917 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4918 (make_all_visible): Use address of member.
4919
d04b44a1
TT
49202019-06-16 Tom Tromey <tom@tromey.com>
4921
4922 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4923 (tui_free_window, free_content, free_content_elements): Remove
4924 unnecessary cast.
4925 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4926 cast.
4927 * tui/tui-regs.c (tui_show_register_group)
4928 (tui_display_registers_from, tui_display_reg_element_at_line):
4929 Remove unnecessary cast.
4930
bf5142e7
AB
49312019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4932
4933 * linux-nat.c (normal_mask): Delete.
4934 (_initialize_linux_nat): Don't initialise normal_mask.
4935
c4973306
SM
49362019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4937
4938 PR gdb/24445
4939 * dwarf-index-write.h (write_psymtabs_to_index): Add
4940 dwz_basename parameter.
4941 * dwarf-index-write.c (write_gdbindex): Move file writing to
4942 write_gdbindex_1. Change return type void.
4943 (assert_file_size): Move up, remove filename parameter.
4944 (write_gdbindex_1): New function.
4945 (write_debug_names): Change return type to void, call
4946 assert_file_size.
4947 (struct index_wip_file): New struct.
4948 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4949 file logic to index_wip_file. Write index for dwz file if
4950 needed.
4951 (save_gdb_index_command): Pass basename of dwz file, if present.
4952 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4953 build-id of dwz file, if present.
4954 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4955 (dwarf2_get_dwz_file): Likewise.
4956 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4957 (dwarf2_get_dwz_file): Likewise.
4958
395f9c91
TT
49592019-06-16 Tom Tromey <tom@tromey.com>
4960
4961 * coffread.c (process_coff_symbol): Use xstrdup.
4962 * value.c (create_internalvar): Use xstrdup.
4963
cafb3438
TT
49642019-06-16 Tom Tromey <tom@tromey.com>
4965
4966 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4967 * breakpoint.c (stopin_command, stopat_command)
4968 (until_break_command, decode_location_default): Remove unnecessary
4969 cast.
4970 * utils.c (subset_compare): Remove unnecessary cast.
4971 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4972 cast.
4973 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4974 cast.
4975 * infcmd.c (path_command): Remove unnecessary cast.
4976 * coffread.c (decode_type): Remove unnecessary cast.
4977 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4978 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4979 * tui/tui-stack.c (tui_show_locator_content)
4980 (tui_show_frame_info): Remove unnecessary cast.
4981 * tui/tui-win.c (tui_scroll_forward_command)
4982 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4983 (parse_scrolling_args): Remove unnecessary cast.
4984 * tui/tui-data.c (init_win_info, tui_del_window)
4985 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4986 (free_content_elements): Remove unnecessary cast.
4987 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4988 unnecessary cast.
4989 * tui/tui-source.c (tui_set_source_content)
4990 (tui_vertical_source_scroll): Remove unnecessary cast.
4991 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4992 cast.
4993 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4994 * tui/tui-regs.c (tui_display_registers_from)
4995 (tui_display_register): Remove unnecessary cast.
4996 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4997 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4998 (make_visible): Remove unnecessary cast.
4999 * tui/tui-winsource.c (tui_erase_source_content)
5000 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5001 unnecessary cast.
5002 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5003 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5004 * stabsread.c (read_type, read_array_type, read_range_type):
5005 Remove unnecessary cast.
5006 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5007 (parse_symbol, parse_type, upgrade_type, parse_external)
5008 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5009 unnecessary cast.
5010 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5011
730ead81
TT
50122019-06-16 Tom Tromey <tom@tromey.com>
5013
5014 * tui/tui-data.c (tui_alloc_generic_win_info)
5015 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5016 checks.
5017
584a927c
AB
50182019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5019 Andrew Burgess <andrew.burgess@embecosm.com>
5020
5021 * f-typeprint.c (f_print_type): Don't return early for not
5022 associated or not allocated types.
5023 (f_type_print_varspec_suffix): Add print_rank parameter and print
5024 ranks of array types in case they dangling.
5025 (f_type_print_base): Add print_rank parameter.
5026
30056ea0
AB
50272019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5028
5029 * NEWS: Mention new MI commands.
5030 * break-catch-throw.c (enum exception_event_kind): Move to
5031 breakpoint.h.
5032 (print_mention_exception_catchpoint): Output text as a single
5033 message.
5034 (catch_exception_command_1): Rename to...
5035 (catch_exception_event): ...this, make non-static, update header
5036 command, and change some parameter types.
5037 (catch_catch_command): Update for changes to
5038 catch_exception_command_1.
5039 (catch_throw_command): Likewise.
5040 (catch_rethrow_command): Likewise.
5041 * breakpoint.c (enum exception_event_kind): Delete.
5042 * breakpoint.h (enum exception_event_kind): Moved here from
5043 break-catch-throw.c.
5044 (catch_exception_event): Declare.
5045 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5046 (mi_cmd_catch_throw): New function.
5047 (mi_cmd_catch_rethrow): New function.
5048 (mi_cmd_catch_catch): New function.
5049 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5050 'catch-catch' entries.
5051 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5052 (mi_cmd_catch_rethrow): Declare.
5053 (mi_cmd_catch_catch): Declare.
5054
ec8e2b6d
AB
50552019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5056
5057 * annotate.c (annotate_source_line): Change return type to void,
5058 update implementation to match.
5059 * annotate.h (annotate_source_line): Change return type to void,
5060 update header comment.
5061 * stack.c (print_frame_info): Don't change what frame information
5062 is printed based on whether annotations are on or not.
5063
0d3abd8c
AB
50642019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5065
5066 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5067 (annotate_source): Make static.
5068 (annotate_source_line): Moved from source.c and renamed from
5069 identify_source_line. Update the return type.
5070 * annotate.h (annotate_source): Delete declaration.
5071 (annotate_source_line): Declaration moved from source.h, and
5072 renamed from identify_source_line. Return type updated.
5073 * source.c (identify_source_line): Moved to annotate.c and renamed
5074 to annotate_source_line.
5075 (info_line_command): Remove check of annotation_level.
5076 * source.h (identify_source_line): Move declaration to annotate.h
5077 and rename to annotate_source_line.
5078 * stack.c: Add 'annotate.h' include.
5079 (print_frame_info): Remove check of annotation_level before
5080 calling annotate_source_line.
5081
00df30ae
AB
50822019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5083
5084 * source-cache.c (source_cache::get_plain_source_lines): Use
5085 open_source_file_with_line_charpos instead of just
5086 open_source_file, remove call to find_source_lines.
5087 (source_cache::get_source_lines): Likewise.
5088 * source.c (find_source_lines): Make static.
5089 (get_filename_and_charpos): Renamed into...
5090 (open_source_file_with_line_charpos): ..this along with changes to
5091 return a scoped_fd, and some other minor clean ups.
5092 (identify_source_line): Use open_source_file_with_line_charpos.
5093 (search_command_helper): Use open_source_file_with_line_charpos
5094 instead of just open_source_file, remove call to
5095 find_source_lines.
5096 * source.h (open_source_file_with_line_charpos): Declare new
5097 function.
5098 (find_source_lines): Delete declaration.
5099
afda45a2
AB
51002019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5101
5102 * source.c (get_filename_and_charpos): Remove fullname
5103 parameter.
5104 (identify_source_line): Update call to get_filename_and_charpos.
5105
0735b091
TT
51062019-06-14 Tom Tromey <tromey@adacore.com>
5107
5108 PR gdb/24502:
5109 * ui-style.h (skip_ansi_escape): Update comment.
5110 * ui-file.h (class no_terminal_escape_file): New class.
5111 * ui-file.c (no_terminal_escape_file::write)
5112 (no_terminal_escape_file::puts): New methods.
5113 * cli/cli-logging.c (handle_redirections): Use
5114 no_terminal_escape_file.
5115
52ce35e2
TT
51162019-06-14 Tom Tromey <tromey@adacore.com>
5117
5118 * NEWS: Move convenience variable news above Python news.
5119
73cc7272
TT
51202019-06-14 Tom Tromey <tom@tromey.com>
5121
5122 * gnulib: Move directory to top-level.
5123 * configure.ac: Don't configure gnulib.
5124 * configure: Rebuild.
5125 * common/common-defs.h: Use new path to gnulib.
5126 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5127 (GNULIB_H): Remove.
5128 (INCGNU): Look in new gnulib location.
5129 (HFILES_NO_SRCDIR): Remove gnulib files.
5130 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5131 (generated_files): Remove GNULIB_H.
5132 ($(LIBGNU), all-lib): Remove targets.
5133 (distclean): Don't mention GNULIB_BUILDDIR.
5134 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5135
f5686554
TT
51362019-06-14 Tom Tromey <tromey@adacore.com>
5137
5138 * symfile.c (add_symbol_file_command): Remove obsolete comment.
5139 Warn if symbol file does not provide any symbols.
5140
a0c1ffed
TT
51412019-06-14 Tom Tromey <tromey@adacore.com>
5142
5143 * source.c (find_and_open_source): Respect basenames_may_differ.
5144
7c39e397
AB
51452019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
5146
5147 * annotate.c (annotate_breakpoints_invalid): Make use of
5148 scoped_restore_terminal_state.
5149 (annotate_frames_invalid): Likewise.
5150
f411722c
TT
51512019-06-14 Tom Tromey <tromey@adacore.com>
5152
5153 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5154 allow assignment to an internalvar.
5155
4268ec18
TT
51562019-06-14 Tom Tromey <tromey@adacore.com>
5157
5158 * ada-lex.l: Allow "_" in attribute names.
5159
abdb711e
TT
51602019-06-14 Tom Tromey <tromey@adacore.com>
5161
5162 PR gdb/24653:
5163 * regcache.c (registers_changed): Don't call alloca.
5164 * top.c (execute_command): Don't call alloca.
5165
4c048731
PA
51662019-06-13 Pedro Alves <palves@redhat.com>
5167
5168 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5169 'expression'. When parsing an expression, error out if there's
5170 junk after "unlimited".
5171 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5172 (do_set_command): Adjust calls to is_unlimited_literal.
5173
66eb1ed3
PA
51742019-06-13 Pedro Alves <palves@redhat.com>
5175
5176 * compile/compile.c (make_compile_options_def_group): Add braces
5177 around array_view initializer.
5178 * thread.c (make_thread_apply_all_options_def_group)
5179 (make_thread_apply_all_options_def_group): Likewise.
5180
3345721a
PA
51812019-06-13 Pedro Alves <palves@redhat.com>
5182
5183 * NEWS (New commands): Mention "maint test-options
5184 require-delimiter", "maint test-options unknown-is-error", "maint
5185 test-options unknown-is-operand" and "maint show
5186 test-options-completion-result".
5187 (New command options, command completion): New section.
5188 (Completion improvements): New section.
5189 Mention that you can abbreviate "unlimited".
5190
6206060d
PA
51912019-06-13 Pedro Alves <palves@redhat.com>
5192
5193 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5194 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5195 * unittests/cli-utils-selftests.c (test_parse_flags)
5196 (test_parse_flags_qcs): Delete.
5197 (test_cli_utils): Don't call deleted functions.
5198
6665660a
PA
51992019-06-13 Pedro Alves <palves@redhat.com>
5200
5201 * thread.c: Include "cli/cli-option.h".
5202 (tp_array_compar_ascending): Global.
5203 (tp_array_compar): Delete function.
5204 (tp_array_compar_ascending, tp_array_compar_descending): New
5205 functions.
5206 (ascending_option_def, qcs_flag_option_def)
5207 (thr_qcs_flags_option_defs)
5208 (make_thread_apply_all_options_def_group)
5209 (make_thread_apply_options_def_group): New.
5210 (thread_apply_all_command): Use gdb::option::process_options.
5211 (thread_apply_command_completer)
5212 (thread_apply_all_command_completer): New.
5213 (thread_apply_command): Use gdb::option::process_options.
5214 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5215 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5216 to generate help text of "thread apply". Adjust "taas"'s help.
5217 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5218 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5219
f7e13587
PA
52202019-06-13 Pedro Alves <palves@redhat.com>
5221
5222 * thread.c (thread_apply_command): Check for invalid TID with
5223 isdigit instead of !isalpha.
5224
5d707134
PA
52252019-06-13 Pedro Alves <palves@redhat.com>
5226
5227 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5228 (validate_flags_qcs): New.
5229 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5230 (validate_flags_qcs): Declare.
5231 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5232 (make_frame_apply_options_def_group): New.
5233 (frame_apply_command_count): Process options with
5234 gdb::option::process_options.
5235 (frame_apply_completer): New.
5236 (frame_apply_level_completer, frame_apply_all_completer)
5237 (frame_apply_completer): New.
5238 (_initialize_stack): Update help of "frame apply", "frame apply
5239 level", "frame apply all" and "faas" to mention supported options
5240 and install command completers.
5241 * stack.h (frame_apply_all_completer): Declare.
5242 * thread.c: Include "stack.h".
5243 (tfaas_command): Add "--".
5244 (_initialize_thread): Update help "tfaas" to mention supported
5245 options and install command completer.
5246
272d4594
PA
52472019-06-13 Pedro Alves <palves@redhat.com>
5248
5249 * completer.c (complete_nested_command_line): New.
5250 (gdb_completion_word_break_characters_throw): Add assertion.
5251 * completer.h (complete_nested_command_line): Declare.
5252
90a1ef87
PA
52532019-06-13 Pedro Alves <palves@redhat.com>
5254
5255 * stack.c (parse_backtrace_qualifiers): New.
5256 (backtrace_command): Use it.
5257 (backtrace_command_completer): Complete on qualifiers.
5258
d4c16835
PA
52592019-06-13 Pedro Alves <palves@redhat.com>
5260
5261 * frame.c: Include "cli/cli-option.h.
5262 (user_set_backtrace_options): New.
5263 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5264 Delete.
5265 (get_prev_frame): Adjust.
5266 (boolean_option_def, uinteger_option_def)
5267 (set_backtrace_option_defs): New.
5268 (_initialize_frame): Adjust and use
5269 gdb::option::add_setshow_cmds_for_options to install "set
5270 backtrace past-main" and "set backtrace past-entry".
5271 * frame.h: Include "cli/cli-option.h".
5272 (struct frame_print_options): Forward declare.
5273 (print_frame_arguments_all, print_frame_arguments_scalars)
5274 (print_frame_arguments_none): Declare.
5275 (print_entry_values): Delete declaration.
5276 (struct frame_print_options, user_frame_print_options): New.
5277 (struct set_backtrace_options): New.
5278 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5279 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5280 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5281 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5282 (list_args_or_locals): Add frame_print_options parameter.
5283 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5284 * python/py-framefilter.c (enumerate_args): Pass down
5285 USER_FRAME_PRINT_OPTIONS.
5286 * stack.c: Include "cli/cli-option.h".
5287 (print_frame_arguments_all, print_frame_arguments_scalars)
5288 (print_frame_arguments_none): Declare.
5289 (print_raw_frame_arguments, print_entry_values): Delete.
5290 (user_frame_print_options): New.
5291 (boolean_option_def, enum_option_def, frame_print_option_defs):
5292 New.
5293 (struct backtrace_cmd_options): New.
5294 (bt_flag_option_def): New.
5295 (backtrace_command_option_defs): New.
5296 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5297 (print_frame_arg, read_frame_arg, print_frame_args)
5298 (print_frame_info, print_frame): Add frame_print_options parameter
5299 and use it.
5300 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5301 (backtrace_command_1): Add frame_print_options and
5302 backtrace_cmd_options parameters and use them.
5303 (make_backtrace_options_def_group): New.
5304 (backtrace_command): Process command options with
5305 gdb::option::process_options.
5306 (backtrace_command_completer): New.
5307 (_initialize_stack): Extend "backtrace"'s help to mention
5308 supported options. Install completer for "backtrace".
5309 Install some settings commands with add_setshow_cmds_for_options.
5310
2daf894e
PA
53112019-06-13 Pedro Alves <palves@redhat.com>
5312
5313 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5314 and that "set/show print raw frame-arguments" are now deprecated.
5315
5316 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5317 command.
5318 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5319 * stack.c (_initialize_stack): Install "set/show print
5320 raw-frame-arguments", and deprecate "set/show print raw
5321 frame-arguments".
5322 * valprint.c (_initialize_valprint): Deprecate "set/show print
5323 raw".
5324
e6ed716c
PA
53252019-06-13 Pedro Alves <palves@redhat.com>
5326
5327 * compile/compile.c (struct compile_options): New.
5328 (compile_flag_option_def, compile_command_option_defs)
5329 (make_compile_options_def_group): New.
5330 (compile_file_command): Handle options with
5331 gdb::option::process_options.
5332 (compile_file_command_completer): New function.
5333 (compile_code_command): Handle options with
5334 gdb::option::process_options.
5335 (compile_code_command_completer): New function.
5336 (_initialize_compiler): Install completers for "compile code" and
5337 "compile file". Mention available options in "compile code" and
5338 "compile code"'s help.
5339 * completer.c (advance_to_completion_word): New, factored out from
5340 ...
5341 (advance_to_expression_complete_word_point): ... this.
5342 (advance_to_filename_complete_word_point): New.
5343 * completer.h (advance_to_filename_complete_word_point): New
5344 declaration.
5345
7d8062de
PA
53462019-06-13 Pedro Alves <palves@redhat.com>
5347
5348 * compile/compile.c: Include "cli/cli-option.h".
5349 (compile_print_value): Scope data pointer is now a
5350 value_print_options pointer; adjust.
5351 (compile_print_command): Process options. Scope data pointer is
5352 now a value_print_options pointer; adjust.
5353 (_initialize_compile): Update "compile print"'s help to include
5354 supported options. Install a completer for "compile print".
5355 * cp-valprint.c (show_vtblprint, show_objectprint)
5356 (show_static_field_print): Delete.
5357 (_initialize_cp_valprint): Don't install "set print
5358 static-members", "set print vtbl", "set print object" here.
5359 * printcmd.c: Include "cli/cli-option.h" and
5360 "common/gdb_optional.h".
5361 (print_command_parse_format): Rework to fill in a
5362 value_print_options instead of a format_data.
5363 (print_value): Change parameter type from format_data pointer to
5364 value_print_options reference. Adjust.
5365 (print_command_1): Process options. Adjust to pass down a
5366 value_print_options.
5367 (print_command_completer): New.
5368 (_initialize_printcmd): Install print_command_completer as
5369 handle_brkchars completer for the "print" command. Update
5370 "print"'s help to include supported options.
5371 * valprint.c: Include "cli/cli-option.h".
5372 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5373 here from cp-valprint.c.
5374 (boolean_option_def, uinteger_option_def)
5375 (value_print_option_defs, make_value_print_options_def_group):
5376 New. Use gdb::option::add_setshow_cmds_for_options to install
5377 "set print elements", "set print null-stop", "set print repeats",
5378 "set print pretty", "set print union", "set print array", "set
5379 print address", "set print symbol", "set print array-indexes".
5380 * valprint.h: Include <string> and "cli/cli-option.h".
5381 (make_value_print_options_def_group): Declare.
5382 (print_value): Change parameter type from format_data pointer to
5383 value_print_options reference.
5384 (print_command_completer): Declare.
5385
9d0faba9
PA
53862019-06-13 Pedro Alves <palves@redhat.com>
5387
5388 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5389 (COMMON_SFILES): Add maint-test-settings.c.
5390 * cli/cli-decode.c (boolean_enums): New global, factored out from
5391 ...
5392 (add_setshow_boolean_cmd): ... here.
5393 * cli/cli-decode.h (boolean_enums): Declare.
5394 * cli/cli-option.c: New file.
5395 * cli/cli-option.h: New file.
5396 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5397 factored out from ...
5398 (parse_cli_boolean_value(const char *)): ... this.
5399 (is_unlimited_literal): Change parameter type to pointer to
5400 pointer. Adjust and advance ARG pointer.
5401 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5402 (parse_cli_var_enum): New, factored out from ...
5403 (do_set_command): ... this. Adjust.
5404 * cli/cli-setshow.h (parse_cli_boolean_value)
5405 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5406 (parse_cli_var_enum): Declare.
5407 * cli/cli-utils.c: Include "cli/cli-option.h".
5408 (get_ulongest): New.
5409 * cli/cli-utils.h (get_ulongest): Declare.
5410 (check_for_argument): New overloads.
5411 * maint-test-options.c: New file.
5412
2c722807
PA
54132019-06-13 Pedro Alves <palves@redhat.com>
5414
5415 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5416 parse a range if "-" is at the end of the string.
5417
dee7b4c8
PA
54182019-06-13 Pedro Alves <palves@redhat.com>
5419
5420 * cli/cli-setshow.c (parse_auto_binary_operation)
5421 (parse_cli_boolean_value): Don't allow "o".
5422
dca0f6c0
PA
54232019-06-13 Pedro Alves <palves@redhat.com>
5424
5425 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5426 * NEWS: Mention maint test-settings KIND.
5427 * maint-test-settings.c: New file.
5428
597bf39d
PA
54292019-06-13 Pedro Alves <palves@redhat.com>
5430
5431 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5432 completer.
5433 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5434 "set" completers.
5435
48c410fb
PA
54362019-06-13 Pedro Alves <palves@redhat.com>
5437
5438 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5439 after item.
5440
93bcb043
PA
54412019-06-13 Pedro Alves <palves@redhat.com>
5442
5443 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5444
cbba3ecd
PA
54452019-06-13 Pedro Alves <palves@redhat.com>
5446
5447 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5448 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5449 call.
5450 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5451 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5452 calls.
5453 (check_for_argument): Skip spaces after argument.
5454
b9a3f842
PA
54552019-06-13 Pedro Alves <palves@redhat.com>
5456
5457 * thread.c (thread_apply_command): Adjust TID parsing.
5458 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5459 detected before end of string.
5460 (tid_is_in_list): Error out if LIST is invalid.
5461
3844e605
PA
54622019-06-13 Pedro Alves <palves@redhat.com>
5463
5464 * completer.c (complete_line_internal_1): Rewind completion word
5465 point.
5466 (completion_tracker::advance_custom_word_point_by): Change
5467 parameter type to int.
5468 * completer.h (completion_tracker::advance_custom_word_point_by):
5469 Likewise.
5470
00b56dbe
PA
54712019-06-13 Pedro Alves <palves@redhat.com>
5472
5473 * completer.c (advance_to_completion_word): Handle delimiters.
5474
d106773e
PA
54752019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5476
5477 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5478
08f10e02
TT
54792019-06-11 Tom Tromey <tom@tromey.com>
5480
5481 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5482 (xmalloc_failed): Move to alloc.c.
5483 * alloc.c: New file.
5484 * Makefile.in (COMMON_SFILES): Add alloc.c.
5485
1c7fe951
TT
54862019-06-11 Tom Tromey <tom@tromey.com>
5487
5488 * nat/linux-waitpid.c: Don't include server.h.
5489 (linux_debug): Remove.
5490 (my_waitpid): Update.
5491
89549d7f
TT
54922019-06-11 Tom Tromey <tromey@adacore.com>
5493
5494 * infcall.c (_initialize_infcall): Remove trailing newline from
5495 help.
5496 * user-regs.c (_initialize_user_regs): Remove trailing newline
5497 from help.
5498 * typeprint.c (_initialize_typeprint): Remove trailing newline
5499 from help.
5500 * reverse.c (_initialize_reverse): Remove trailing newlines from
5501 help.
5502 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5503 from help.
5504 * language.c (add_set_language_command): Remove trailing newline
5505 from help.
5506 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5507 help.
5508 * disasm.c (_initialize_disasm): Remove trailing newline from
5509 help.
5510 * top.c (init_main): Remove trailing newline from help.
5511 * interps.c (_initialize_interpreter): Remove trailing newline
5512 from help.
5513 * btrace.c (_initialize_btrace): Remove trailing newlines from
5514 help.
5515 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5516 from help.
5517 * python/python.c (_initialize_python): Remove trailing newline
5518 from help.
5519 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5520 help.
5521 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5522 from help. Reformat some text.
5523 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5524 from help.
5525 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5526 newline from help.
5527
86108c13
TT
55282019-06-11 Tom Tromey <tromey@adacore.com>
5529
5530 * darwin-nat.c (darwin_decode_exception_message)
5531 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5532
a7067863
AB
55332019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5534
5535 * valops.c (value_slice): Check for not allocated or not
5536 associated values.
5537
9ab08412
TV
55382019-06-10 Tom de Vries <tdevries@suse.de>
5539
5540 PR gdb/24618
5541 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5542 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5543 invalid.
5544
f19e22e9
TV
55452019-06-10 Tom de Vries <tdevries@suse.de>
5546
5547 PR gdb/24611
5548 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5549 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5550
e99f9db0
TV
55512019-06-10 Tom de Vries <tdevries@suse.de>
5552
5553 PR symtab/24545
5554 * symtab.c (struct demangled_name_entry): Add language field.
5555 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5556 static minimal symbol". Set and use language field.
5557
9bf7038b
TT
55582019-06-10 Tom Tromey <tromey@adacore.com>
5559
5560 * ada-lang.c (_initialize_ada_language): Update help text.
5561
422186a9
TT
55622019-06-10 Tom Tromey <tromey@adacore.com>
5563
5564 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5565 with a newline.
5566 * guile/guile.c (handle_boot_error): Don't end warning with a
5567 newline.
5568 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5569 warning with a newline.
5570 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5571 newline.
5572 (s12z_frame_cache): Likewise.
5573 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5574 a newline.
5575 * solib-svr4.c (disable_probes_interface): Don't end warning with
5576 a newline.
5577 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5578 newline.
5579 * python/python.c (do_finish_initialization): Don't end warning
5580 with a newline.
5581
25ce02ee
TT
55822019-06-10 Tom Tromey <tom@tromey.com>
5583
5584 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5585 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5586 gdbpy_enter.
5587
caa429d8
TT
55882019-06-10 Tom Tromey <tromey@adacore.com>
5589
5590 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5591 data.
5592 (elf_new_init): Don't call stabsread_new_init.
5593 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5594 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5595 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5596
81873cc8
TV
55972019-06-10 Tom de Vries <tdevries@suse.de>
5598
5599 PR symtab/16264
5600 PR symtab/24517
5601 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5602
4fa0265e
РИ
56032019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5604
5605 * source.c (find_and_open_source): Also rewrite relative file
5606 names.
5607
1a3da2cd
AB
56082019-04-26 Amos Bird <amosbird@gmail.com>
5609
5610 * annotate.c (annotate_thread_exited): Add "thread-exited"
5611 annotation.
5612
3847a7bf
TT
56132019-06-06 Tom Tromey <tromey@adacore.com>
5614
5615 * maint.h (class scoped_command_stats): Use
5616 DISABLE_COPY_AND_ASSIGN.
5617 <print_time>: New method.
5618 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5619 print_time.
5620 (scoped_command_stats::print_time): New method.
5621
312617a3
AB
56222019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5623
5624 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5625 instructions of lengths 6 or 8 bytes.
5626
b02f78f9
PA
56272019-06-04 Pedro Alves <palves@redhat.com>
5628
5629 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5630
5631 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5632 * breakpoint.c (condition_completer): Likewise.
5633 * cli/cli-dump.c (scan_expression): Likewise.
5634 * common/filestuff.c (mkdir_recursive): Likewise.
5635 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5636 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5637 (gdb_abspath): Likewise.
5638 * compile/compile-cplus-types.c
5639 (compile_cplus_instance::decl_name): Likewise.
5640 * completer.c (complete_explicit_location):
5641 (signal_completer, reg_or_group_completer_1): Likewise.
5642 * cp-support.c (cp_remove_params_if_any): Likewise.
5643 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5644 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5645 * infcmd.c (strip_bg_char): Likewise.
5646 * linespec.c (copy_token_string): Likewise.
5647 * mi/mi-main.c (output_cores): Likewise.
5648 * psymtab.c (psymtab_search_name):
5649 * symfile.c (test_set_ext_lang_command): Likewise.
5650 * target.c (target_fileio_read_stralloc): Likewise.
5651 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5652 * value.c (complete_internalvar): Likewise.
5653
e1f2e1a2
CB
56542019-06-04 Christian Biesinger <cbiesinger@google.com>
5655
5656 Add objfile property to gdb.Type.
d3238f7d
PA
5657 * NEWS: Mention Python API addition.
5658 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 5659
e664d728
PW
56602019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5661
5662 * NEWS: Mention the new set|show style [title|highlight].
5663 Mention changes to "show style", "help" and "apropos".
5664
66d8c862
PW
56652019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5666
5667 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5668 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5669 instead of print_help_for_command.
5670 (print_doc_of_command): New function.
5671 (help_list): Add 'apropos -v word' suggestion.
5672 (print_help_for_command): Style the command name using title style.
5673 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5674 (_initialize_cli_cmds): Describe -v in apropos_command help.
5675
9303eb2f
PW
56762019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5677
5678 * cli/cli-style.h (cli_style_option): Add name in constructor,
5679 add m_name class member, add constructor with intensity,
5680 add name class function.
5681 (cli_style_option::add_setshow_commands): Remove name argument.
5682 (highlight_style, title_style): New styles.
5683 * cli/cli-style.c (do_show): New function that shows a style
5684 characteristic styling the style name with itself.
5685 (set_style_name): New function.
5686 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5687 Update all callers according to the changes in cli/cli-style.h.
5688 * utils.h (fputs_highlighted): New function.
5689 * utils.c (fputs_highlighted): Likewise.
5690
e2c52041
PW
56912019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5692
5693 * NEWS: Mention new pipe command and new convenience variables.
5694
947d3946
PW
56952019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5696
5697 * cli/cli-cmds.c (pipe_command): New function.
5698 (_initialize_cli_cmds): Call add_com for pipe_command.
5699 Define | as an alias for pipe.
5700 (exit_status_set_internal_vars): New function.
5701 (shell_escape): Call exit_status_set_internal_vars.
5702 cli/cli-decode.c (find_command_name_length): Recognize | as
5703 a single character command.
5704
b8fd0918
PW
57052019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5706
5707 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5708 top.c (execute_command_to_ui_file): New function, mostly a copy
5709 of execute_command_to_string.
5710 (execute_command_to_string): Implement by calling
5711 execute_command_to_ui_file.
5712
68bb5386
PW
57132019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5714
5715 * top.h (saved_command_line): Remove declaration.
5716 * top.c (previous_saved_command_line, previous_repeat_arguments):
5717 New variables.
5718 (saved_command_line): Make static, define together with other
5719 'repeat variables'.
5720 (dont_repeat): Clear repeat_arguments.
5721 (repeat_previous, get_saved_command_line, save_command_line):
5722 New functions.
5723 (gdb_init): Initialize saved_command_line
5724 and previous_saved_command_line.
5725 * main.c (captured_main_1): Remove saved_command_line initialization.
5726 * event-top.c (handle_line_of_input): Update to use
5727 the new 'repeat' related functions instead of direct access to
5728 saved_command_line.
5729 * command.h (repeat_previous, get_saved_command_line,
5730 save_command_line): New declarations.
5731 (dont_repeat): Add comment.
5732
bfcdb852
TT
57332019-05-30 Tom Tromey <tromey@adacore.com>
5734
5735 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5736 Fix comment.
5737 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5738
0ef209f2
JV
57392019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5740
5741 PR cli/24587
5742 * completer.c (complete): Initialize variable word.
5743
955b06fa
SDJ
57442019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5745
5746 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5747 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5748 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5749 'body' is NULL to the outter 'if', protecting the '!is_define'
5750 situation as well.
5751
fa9c3fa0
TT
57522019-05-29 Tom Tromey <tromey@adacore.com>
5753
5754 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5755 (dwarf_unknown): New function.
5756 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5757 (dwarf_type_encoding_name): Use dwarf_unknown.
5758
4330d61d
TT
57592019-05-29 Tom Tromey <tromey@adacore.com>
5760
5761 PR c++/20020:
5762 * cp-valprint.c (cp_print_value_fields): Call
5763 cp_print_static_field inside "try".
5764
33a6bc35
TT
57652019-05-29 Tom Tromey <tromey@adacore.com>
5766
5767 * inflow.c (struct terminal_info): Add default operator=.
5768 * configure: Rebuild.
5769 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5770 -Wdeprecated-copy-dtor, -Wredundant-move.
5771
000439d5
TT
57722019-05-29 Tom Tromey <tromey@adacore.com>
5773
5774 * NEWS: Add entry.
5775 * infcmd.c (print_return_value_1): Handle finish_print
5776 option.
5777 (show_print_finish): New function.
5778 (_initialize_infcmd): Add "set/show print finish" commands.
5779 * valprint.c (user_print_options): Initialize new member.
5780 * valprint.h (struct value_print_options) <finish_print>: New
5781 member.
5782
c0e70c62
TT
57832019-05-28 Tom Tromey <tromey@adacore.com>
5784
5785 * ada-lang.c (ada_remove_Xbn_suffix)
5786 (find_old_style_renaming_symbol)
5787 (parse_old_style_renaming): Remove.
5788 (ada_find_renaming_symbol): Don't call
5789 find_old_style_renaming_symbol.
5790 (ada_is_renaming_symbol): Rename from
5791 ada_find_renaming_symbol. Remove "block" parameter. Return
5792 bool. Now static.
5793 (ada_read_var_value): Update and simplify.
5794 * ada-exp.y (write_var_or_type): Remove old code.
5795
766f8836
AH
57962019-05-28 Alan Hayward <alan.hayward@arm.com>
5797
5798 * event-top.c: Remove include comment.
5799 * inflow.c (class scoped_ignore_sigttou): Move from here...
5800 * inflow.h (class scoped_ignore_sigttou): ...to here.
5801 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5802 * top.c: Remove include comment.
5803
eb41253a
TT
58042019-05-27 Tom Tromey <tom@tromey.com>
5805
5806 * NEWS: Fix typo.
5807
4ca51187
TT
58082019-05-22 Tom Tromey <tromey@adacore.com>
5809
5810 * target.c (target_follow_exec): Constify parameter.
5811 * target-delegates.c: Rebuild.
5812 * remote.c (remote_target::follow_exec): Constify parameter.
5813 * infrun.c (follow_exec): Constify parameter.
5814 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5815 (target_follow_exec): Likewise.
5816
8fca4da0
AH
58172019-05-22 Alan Hayward <alan.hayward@arm.com>
5818
5819 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5820 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5821
b7060614
AH
58222019-05-22 Alan Hayward <alan.hayward@arm.com>
5823
5824 * NEWS: Add debugredirect and testsuite sections.
5825
0a5954bd
SC
58262019-05-22 Simon Cook <simon.cook@embecosm.com>
5827
5828 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5829 target descriptions using exclusively floating point register name
5830 aliases.
5831
dc42e902
AB
58322019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5833
5834 PR gdb/18644:
5835 * f-lang.c (build_fortran_types): Handle the case where
5836 gdbarch_floatformat_for_type returns a nullptr.
5837
fb7806c7
TV
58382019-05-21 Tom de Vries <tdevries@suse.de>
5839
5840 PR cli/24587
5841 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5842
34d11c68
AB
58432019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5844
5845 PR gdb/18644:
5846 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5847 16-byte floats.
5848 * i386-tdep.c (i386_floatformat_for_type): Use
5849 floatformats_ia64_quad for the 16-byte floating point component
5850 within a fortran 32-byte complex number.
5851
122cf0f2
AB
58522019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5853
5854 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5855 delete default constructor.
5856 (find_partial_die): Update to return const struct.
5857 (partial_die_parent_scope): Move variable declaration into scope
5858 of its use and change its type to auto.
5859 (guess_partial_die_structure_name): Likewise.
5860 (partial_die_info::fixup): Likewise.
5861
33d0e35a
TT
58622019-05-17 Tom Tromey <tromey@adacore.com>
5863
5864 * source.c (find_and_open_source): Remove cast.
5865
a45575b0
TT
58662019-05-17 Tom Tromey <tromey@adacore.com>
5867
5868 * annotate.c (annotate_source): Make "filename" const.
5869 * annotate.h (annotate_source): Use const.
5870
81f47ac2
AH
58712019-05-17 Alan Hayward <alan.hayward@arm.com>
5872
5873 * disasm.c (set_disassembler_options): Send errors to stderr.
5874
ca1285d1
AH
58752019-05-17 Alan Hayward <alan.hayward@arm.com>
5876
5877 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5878 (cli_interp_base::set_logging): Check debug_redirect.
5879 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5880 * cli/cli-logging.c (debug_redirect): Add static variable.
5881 (pop_output_files): Add default param.
5882 (handle_redirections): Print debug setting.
5883 (show_logging_command): Likewise.
5884 (_initialize_cli_logging): Add debugredirect command.
5885 * interps.c (current_interp_set_logging): Add debug_redirect
5886 parameter.
5887 * interps.h (set_logging): Add debug_redirect parameter.
5888 (current_interp_set_logging): Likewise.
5889 * mi/mi-common.h: Likewise.
5890 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5891
58922019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
5893 Tom Tromey <tromey@adacore.com>
5894
5895 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5896 directly.
5897 * cli/cli-interp.h (make_logging_output): Remove declaration.
5898 * cli/cli-logging.c (make_logging_output): Remove function.
5899 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5900 directly.
5901 * ui-file.c (tee_file::tee_file): Remove bools.
5902 (tee_file::~tee_file): Remove deletes.
5903 * ui-file.h (tee_file): Remove bools.
5904
26648588
JV
59052019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5906
5907 * mi/mi-cmds.h (mi_cmd_complete): New function.
5908 * mi/mi-main.c (mi_cmd_complete): Likewise.
5909 * mi/mi-cmds.c: Define new MI command -complete.
5910 * NEWS: Mention new -complete command.
5911
6e035501
JV
59122019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5913
5914 * completer.h (complete): New function.
5915 * completer.c (complete): Likewise.
5916 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5917 function defined in completer.h.
5918
7d0e2ece
JV
59192019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5920
e79be6e5 5921 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5922
fb816e8b
TV
59232019-05-17 Tom de Vries <tdevries@suse.de>
5924
5925 PR gdb/24094
5926 * dwarf2read.c (struct cu_partial_die_info): New struct.
5927 (find_partial_die): Return cu_partial_die_info.
5928 (partial_die_parent_scope, guess_partial_die_structure_name)
5929 (partial_die_info::fixup): Handle new return type of find_partial_die.
5930
677052f2
SDJ
59312019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5932
a1726c38 5933 PR breakpoints/24541
677052f2
SDJ
5934 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5935 "std::string", simplifying the algorithm.
5936
f3da9116
SDJ
59372019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5938
5939 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5940 (stap_static_probe_ops::get_probes): Likewise.
5941
f1bb75ab
SDJ
59422019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5943
5944 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5945 '-')" and "else if".
5946 (stap_parse_single_operand): Join checks for
5947 "gdbarch_stap_parse_special_token_p" and
5948 "gdbarch_stap_parse_special_token" in the same "if" statement.
5949 Invert check when verifying for operation on register
5950 displacement.
5951
3ca58cde
SDJ
59522019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5953
5954 * stap-probe.c (stap_get_opcode): Update comment.
5955 (stap_get_expected_argument_type): Likewise.
5956 (handle_stap_probe): Likewise.
5957
af2d9bee
SDJ
59582019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5959
5960 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5961 return type to 'bool'. Adjust comment. Use 'bool' when
5962 appropriate.
5963 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5964 * stap-probe.c (stap_parse_argument_1): Likewise.
5965 (stap_is_operator): Likewise.
5966 (stap_is_generic_prefix): Likewise.
5967 (stap_is_register_prefix): Likewise.
5968 (stap_is_register_indirection_prefix): Likewise.
5969 (stap_is_integer_prefix): Likewise.
5970 (stap_generic_check_suffix): Likewise.
5971 (stap_check_integer_suffix): Likewise.
5972 (stap_check_register_suffix): Likewise.
5973 (stap_check_register_indirection_suffix): Likewise.
5974 (stap_parse_register_operand): Likewise.
5975 (stap_parse_single_operand): Likewise.
5976 (stap_parse_argument_1): Likewise.
5977 (stap_probe::get_argument_count): Likewise.
5978 (stap_is_operator): Likewise.
5979
61c9c421
TT
59802019-05-16 Tom Tromey <tromey@adacore.com>
5981
5982 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5983 keyword to foreach.
5984
9ddc1af1
SM
59852019-05-15 Simon Marchi <simon.marchi@efficios.com>
5986
5987 * linux-thread-db.c (try_thread_db_load_1): Change return type
5988 to bool.
5989 (try_thread_db_load): Likewise.
5990 (try_thread_db_load_from_pdir_1): Likewise.
5991 (try_thread_db_load_from_pdir): Likewise.
5992 (try_thread_db_load_from_sdir): Likewise.
5993 (try_thread_db_load_from_dir): Likewise.
5994 (thread_db_load_search): Likewise.
5995 (has_libpthread): Likewise.
5996 (thread_db_load): Likewise.
5997
7bede828
SDJ
59982019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5999
6000 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6001 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6002 NULL, and complain/return if that's the case.
6003
c5358db4
JD
60042019-05-15 John Darrington <john@darrington.wattle.id.au>
6005
6006 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6007 (advance, posn, abstract_read_memory): New functions.
6008 [struct mem_read_abstraction]: New struct.
6009 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6010
c408a94f
TT
60112019-05-14 Tom Tromey <tromey@adacore.com>
6012
6013 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6014 value is not lval_memory.
6015
e7bd7fba
TT
60162019-05-14 Tom Tromey <tromey@adacore.com>
6017
6018 * solib.c (info_sharedlibrary_command): Style the file name.
6019
a6d0f249
AH
60202019-05-14 Alan Hayward <alan.hayward@arm.com>
6021
6022 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6023 (aarch64_vnv_type): Likewise.
6024 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6025 * common/tdesc.c: Likewise.
6026 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6027 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6028 * features/aarch64-fpu.xml: Add ieee half view.
6029 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6030 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6031 * gdbtypes.h (struct builtin_type): Likewise.
6032 (struct objfile_type): Likewise.
6033
66b8bb74
SM
60342019-05-12 Paul Naert <paul.naert@polymtl.ca>
6035
6036 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6037 typo.
6038 * location.h (string_to_event_location): Likewise.
6039
21c219fd
JB
60402019-05-11 Joel Brobecker <brobecker@adacore.com>
6041
6042 GDB 8.3 released.
6043
13674803
SM
60442019-05-10 Simon Marchi <simon.marchi@efficios.com>
6045
6046 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6047 New variable declaration.
6048 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6049 New variable.
6050 (print_one_breakpoint): Use ui_out::test_flags and new global
6051 variable to compute use_fixed_output.
6052 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6053 Remove.
6054 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6055 (mi_multi_location_breakpoint_output_fixed): Remove.
6056 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6057 new variable.
6058 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6059 fix_multi_location_breakpoint_output flag if version >= 3.
6060 * ui-out.h (enum ui_out_flag)
6061 <fix_multi_location_breakpoint_output>: New enumerator.
6062
a9eac7f9
SM
60632019-05-10 Simon Marchi <simon.marchi@efficios.com>
6064
6065 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6066
71bed2db
TT
60672019-05-10 Tom Tromey <tromey@adacore.com>
6068
6069 * ada-lang.c (catch_ada_completer): New function.
6070 (_initialize_ada_language): Use it.
6071
24c54127
TT
60722019-05-10 Tom Tromey <tromey@adacore.com>
6073
6074 * thread.c (print_thread_info): Make "requested_threads" const.
6075 * gdbthread.h (print_thread_info): Make "requested_threads"
6076 const.
6077 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6078 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6079
7a102139
TT
60802019-05-08 Tom Tromey <tom@tromey.com>
6081
6082 * gdbtypes.c (objfile_type_data): Change type.
6083 (objfile_type, _initialize_gdbtypes): Update.
6084
924d79e2
TT
60852019-05-08 Tom Tromey <tom@tromey.com>
6086
6087 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6088 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6089 (_initialize_dwarf2_frame): Update.
6090
4c58e337
TT
60912019-05-08 Tom Tromey <tom@tromey.com>
6092
6093 * objc-lang.c (objc_objfile_data): Change type.
6094 (find_methods): Update.
6095 (_initialize_objc_lang): Remove.
6096
d772d2ab
TT
60972019-05-08 Tom Tromey <tom@tromey.com>
6098
6099 * stabsread.c (rs6000_builtin_type_data): Change type.
6100 (rs6000_builtin_type, _initialize_stabsread): Update.
6101
d11d83f4
TT
61022019-05-08 Tom Tromey <tom@tromey.com>
6103
6104 * mips-tdep.c (mips_pdr_data): Remove.
6105 (_initialize_mips_tdep): Update.
6106
9a73f0ad
TT
61072019-05-08 Tom Tromey <tom@tromey.com>
6108
6109 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6110 (hppa_init_objfile_priv_data, read_unwind_info)
6111 (find_unwind_entry, _initialize_hppa_tdep): Update.
6112
8127a2fa
TT
61132019-05-08 Tom Tromey <tom@tromey.com>
6114
6115 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6116 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
6117 on obstack.
6118 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6119
91d3055d
TT
61202019-05-08 Tom Tromey <tom@tromey.com>
6121
6122 * mdebugread.c (basic_type_data): Change type.
6123 (basic_type, _initialize_mdebugread): Update.
6124
31930bd3
TT
61252019-05-08 Tom Tromey <tom@tromey.com>
6126
6127 * common/gdb_unique_ptr.h (struct noop_deleter): New.
6128
bdb3ed9e
TT
61292019-05-08 Tom Tromey <tom@tromey.com>
6130
6131 * nto-tdep.c (nto_inferior_data_reg): Change type.
6132 (nto_inferior_data): Update.
6133 (nto_inferior_data_cleanup, nto_new_inferior_data)
6134 (_initialize_nto_tdep): Remove.
6135 * nto-tdep.h (struct nto_inferior_data): Add initializers.
6136
f37b313d
TT
61372019-05-08 Tom Tromey <tom@tromey.com>
6138
6139 * ada-lang.c (struct ada_inferior_data): Add initializers.
6140 (ada_inferior_data): Change type.
6141 (ada_inferior_data_cleanup): Remove.
6142 (get_ada_inferior_data, ada_inferior_exit)
6143 (struct ada_pspace_data): Add initializers, destructor.
6144 (ada_pspace_data_handle): Change type.
6145 (get_ada_pspace_data): Update.
6146 (ada_pspace_data_cleanup): Remove.
6147
24699405
TT
61482019-05-08 Tom Tromey <tom@tromey.com>
6149
6150 * coffread.c (struct coff_symfile_info): Add initializers.
6151 (coff_objfile_data_key): Move lower. Change type.
6152 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6153 Update.
6154 (coff_free_info): Remove.
6155
d4e05d2f
TT
61562019-05-08 Tom Tromey <tom@tromey.com>
6157
6158 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6159 (fbsd_pspace_data_handle): Move lower. Change type.
6160 (get_fbsd_pspace_data): Update.
6161 (fbsd_pspace_data_cleanup): Remove.
6162 (_initialize_fbsd_tdep): Update.
6163
14ef6690
TT
61642019-05-08 Tom Tromey <tom@tromey.com>
6165
6166 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6167 (get_ada_tasks_pspace_data): Update.
6168 (ada_tasks_pspace_data_cleanup): Remove.
6169 (_initialize_tasks): Update.
6170 (ada_tasks_inferior_data_handle): Change type.
6171 (get_ada_tasks_inferior_data): Update.
6172 (ada_tasks_inferior_data_cleanup): Remove.
6173 (struct ada_tasks_pspace_data): Add initializers.
6174
814cf43a
TT
61752019-05-08 Tom Tromey <tom@tromey.com>
6176
6177 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6178 * symfile-debug.c (debug_sym_get_probes): Change type.
6179 * stap-probe.c (handle_stap_probe):
6180 (stap_static_probe_ops::get_probes): Change type.
6181 * probe.h (class static_probe_ops) <get_probes>: Change type.
6182 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6183 (parse_probes_in_pspace): Update.
6184 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6185 Update.
6186 (any_static_probe_ops::get_probes): Change type.
6187 * elfread.c (elfread_data): New typedef.
6188 (probe_key): Change type.
6189 (elf_get_probes): Likewise. Update.
6190 (probe_key_free): Remove.
6191 (_initialize_elfread): Update.
6192 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6193 Change type.
6194 (dtrace_process_dof_probe, dtrace_process_dof)
6195 (dtrace_static_probe_ops::get_probe): Change type.
6196
02dc647e
TT
61972019-05-08 Tom Tromey <tom@tromey.com>
6198
6199 * xcoffread.c (struct xcoff_symfile_info): Rename from
6200 coff_symfile_info. Add initializers.
6201 (xcoff_objfile_data_key): Move lower. Change type.
6202 (XCOFF_DATA): Rewrite.
6203 (xcoff_free_info): Remove.
6204 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6205 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6206 (xcoff_initial_scan): Update.
6207
09232438
TT
62082019-05-08 Tom Tromey <tom@tromey.com>
6209
6210 * solib-svr4.c (struct svr4_info): Add initializers and
6211 destructor.
6212 <probes_table>: Now an htab_up.
6213 (solib_svr4_pspace_data): Change type.
6214 (free_probes_table): Simplify.
6215 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6216 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6217 (probes_table_remove_objfile_probes, register_solib_event_probe)
6218 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6219 (_initialize_svr4_solib): Update.
6220
7b4a314f
TT
62212019-05-08 Tom Tromey <tom@tromey.com>
6222
6223 * remote.c (remote_pspace_data): Change type.
6224 (remote_pspace_data_cleanup): Remove.
6225 (get_remote_exec_file, set_pspace_remote_exec_file)
6226 (_initialize_remote): Update.
6227
51d3063a
TT
62282019-05-08 Tom Tromey <tom@tromey.com>
6229
6230 * breakpoint.c (breakpoint_objfile_key): Change type.
6231 (get_breakpoint_objfile_data): Update.
6232 (free_breakpoint_objfile_data): Remove.
6233 (_initialize_breakpoint): Update.
6234
89fb8848
TT
62352019-05-08 Tom Tromey <tom@tromey.com>
6236
6237 * linux-tdep.c (struct linux_info): Add initializers.
6238 (linux_inferior_data): Move. Change type.
6239 (invalidate_linux_cache_inf): Update.
6240 (linux_inferior_data_cleanup): Remove.
6241 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6242
e9b89e2d
TT
62432019-05-08 Tom Tromey <tom@tromey.com>
6244
6245 * auxv.c (auxv_inferior_data): Move. Change type.
6246 (auxv_inferior_data_cleanup): Remove.
6247 (invalidate_auxv_cache_inf): Rewrite.
6248 (get_auxv_inferior_data, _initialize_auxv): Update.
6249
8c42777c
TT
62502019-05-08 Tom Tromey <tom@tromey.com>
6251
6252 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6253 (symfile_debug_objfile_data_key): Change type.
6254 (symfile_debug_installed, debug_qf_has_symbols)
6255 (debug_qf_find_last_source_symtab)
6256 (debug_qf_forget_cached_source_info)
6257 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6258 (debug_qf_print_stats, debug_qf_dump)
6259 (debug_qf_expand_symtabs_for_function)
6260 (debug_qf_expand_all_symtabs)
6261 (debug_qf_expand_symtabs_with_fullname)
6262 (debug_qf_map_matching_symbols)
6263 (debug_qf_expand_symtabs_matching)
6264 (debug_qf_find_pc_sect_compunit_symtab)
6265 (debug_qf_map_symbol_filenames)
6266 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6267 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6268 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6269 (debug_sym_read_linetable, debug_sym_relocate): Update.
6270 (symfile_debug_free_objfile): Remove.
6271 (install_symfile_debug_logging, _initialize_symfile_debug):
6272 Update.
6273
5bfd760d
TT
62742019-05-08 Tom Tromey <tom@tromey.com>
6275
6276 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6277 allocate_on_obstack.
6278 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6279 (get_dwarf2_per_objfile): Update.
6280 (set_dwarf2_per_objfile): Remove.
6281 (dwarf2_has_info, dwarf2_get_section_info): Update.
6282 (dwarf2_free_objfile): Remove.
6283 (_initialize_dwarf2_read): Update.
6284
e85e19b4
TT
62852019-05-08 Tom Tromey <tom@tromey.com>
6286
6287 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6288 initializers.
6289 <unsupported_script_warning_printed,
6290 script_not_found_warning_printed>: Now bool.
6291 (auto_load_pspace_data): Change type.
6292 (~auto_load_pspace_info): Rename from
6293 auto_load_pspace_data_cleanup.
6294 (get_auto_load_pspace_data, init_loaded_scripts_info)
6295 (clear_section_scripts, maybe_print_unsupported_script_warning)
6296 (maybe_print_script_not_found_warning, _initialize_auto_load):
6297 Update.
6298
f6aa7436
TT
62992019-05-08 Tom Tromey <tom@tromey.com>
6300
6301 * objfiles.c (objfile_pspace_info): Add destructor and
6302 initializers.
6303 (objfiles_pspace_data): Change type.
6304 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6305 (get_objfile_pspace_data): Update.
6306 (objfiles_bfd_data): Change type.
6307 (get_objfile_bfd_data): Update.
6308 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6309
6ae614f6
TT
63102019-05-08 Tom Tromey <tom@tromey.com>
6311
6312 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6313 Change type.
6314 (get_catch_syscall_inferior_data): Update.
6315 (catch_syscall_inferior_data_cleanup): Remove.
6316 (_initialize_break_catch_syscall): Update.
6317
6509b8eb
TT
63182019-05-08 Tom Tromey <tom@tromey.com>
6319
6320 * inflow.c (struct terminal_info): Add destructor and
6321 initializers.
6322 (inflow_inferior_data): Change type.
6323 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6324 (get_inflow_inferior_data, inflow_inferior_exit)
6325 (swap_terminal_info, _initialize_inflow): Update.
6326
35632941
TT
63272019-05-08 Tom Tromey <tom@tromey.com>
6328
6329 * target-dcache.c (target_dcache_cleanup): Remove.
6330 (target_dcache_aspace_key): Change type.
6331 (target_dcache_init_p, target_dcache_invalidate)
6332 (target_dcache_get, target_dcache_get_or_init)
6333 (_initialize_target_dcache): Update.
6334 * dcache.h (struct dcache_deleter): New.
6335
3017b94d
TT
63362019-05-08 Tom Tromey <tom@tromey.com>
6337
6338 * symtab.c (struct symbol_cache): Add destructor and
6339 initializers.
6340 (symbol_cache_key): Move. Change type.
6341 (make_symbol_cache, free_symbol_cache): Remove.
6342 (get_symbol_cache): Update.
6343 (symbol_cache_cleanup): Remove.
6344 (ALL_PSPACES, symbol_cache_flush)
6345 (maintenance_print_symbol_cache)
6346 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6347 Update.
6348
a32ad8c5
TT
63492019-05-08 Tom Tromey <tom@tromey.com>
6350
6351 * symtab.c (struct main_info): Add destructor and initializers.
6352 (main_progspace_key): Move. Change type.
6353 (get_main_info): Update.
6354 (main_info_cleanup): Remove.
6355 (_initialize_symtab): Update.
6356
5f6e90a0
TT
63572019-05-08 Tom Tromey <tom@tromey.com>
6358
6359 * registry.h (DECLARE_REGISTRY): Define the _key class.
6360
1bd0c6e4
AB
63612019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6362
6363 * NEWS: Merge two 'New commands' sections.
6364
2228ef77
XR
63652019-05-08 Joel Brobecker <brobecker@adacore.com>
6366
6367 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6368 parameter and use Ada language definition instead.
6369 (ada_val_print_ptr): Remove unused language parameter.
6370 (ada_val_print_num): Remove language parameter and use Ada language
6371 definition instead.
6372 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6373 parameter.
6374 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6375 parameter and use Ada language definition instead.
6376 (ada_val_print_1): Update all ada_val_print_xxx calls.
6377 Remove language parameter.
6378 (ada_val_print): Update ada_val_print_1 call.
6379
60fcc1c3
TT
63802019-05-08 Tom Tromey <tromey@adacore.com>
6381
6382 * remote.c (remote_hw_watchpoint_limit)
6383 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6384 Now static.
6385
ed2b7c17
TT
63862019-05-08 Tom Tromey <tromey@adacore.com>
6387
6388 * maint.c (_initialize_maint_cmds): Move initialization code to
6389 remote.c.
6390 (watchdog, show_watchdog): Move to remote.c.
6391 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6392 "watchdog" static.
6393 (_initialize_remote): Move initialization code from maint.c.
6394 * defs.h (watchdog): Don't declare.
6395
b0be6c91
TT
63962019-05-08 Tom Tromey <tromey@adacore.com>
6397
6398 * tui/tui-interp.c: Include main.h.
6399 * interps.c: Include main.h.
6400 * main.h (interpreter_p): Declare.
6401 * defs.h (interpreter_p): Don't declare.
6402
587ee17b
TT
64032019-05-08 Tom Tromey <tromey@adacore.com>
6404
6405 * dwarf2loc.c: Include dwarf2read.h.
6406 * defs.h (read_unsigned_leb128): Don't declare.
6407 * dwarf2read.h (read_unsigned_leb128): Declare.
6408
ca1df239
TT
64092019-05-08 Tom Tromey <tromey@adacore.com>
6410
6411 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6412 method.
6413
99f20f08
TT
64142019-05-08 Tom Tromey <tromey@adacore.com>
6415
6416 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6417 when no wrap column is set.
6418
80e55b13
TT
64192019-05-08 Tom Tromey <tromey@adacore.com>
6420
6421 * c-lang.c (c_get_string): Handle non-C-style arrays.
6422
9d3421af
TT
64232019-05-08 Tom Tromey <tromey@adacore.com>
6424
6425 * typeprint.c (print_offset_data::update): Print the bit offset,
6426 not the number of bits remaining.
6427
844333e2
TT
64282019-05-08 Tom Tromey <tromey@adacore.com>
6429
6430 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6431 padding at end of comment.
6432
988915ee
TT
64332019-05-08 Tom Tromey <tromey@adacore.com>
6434
6435 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6436 Compare main types.
6437
26bfd823
TT
64382019-05-06 Tom Tromey <tom@tromey.com>
6439
6440 * common/scoped_mmap.c: Include common-defs.h.
6441 * common/scoped_mmap.h: Don't include config.h.
6442
89055eaa
TT
64432019-05-04 Tom Tromey <tom@tromey.com>
6444
6445 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6446 (struct aarch64_call_info): Add initializers.
6447 <si>: Now a std::vector.
6448 (pass_on_stack, aarch64_push_dummy_call): Update.
6449
5da01df5
TT
64502019-05-04 Simon Marchi <simon.marchi@efficios.com>
6451 Tom Tromey <tom@tromey.com>
6452
6453 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6454 (ppc_threads): Now a std::vector. Now static.
6455 (hwdebug_find_thread_points_by_tid)
6456 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6457 Update.
6458
fbdf05a1
TT
64592019-05-04 Tom Tromey <tom@tromey.com>
6460
6461 * arc-tdep.c (arc_tdesc_init): Return bool.
6462
06d16ec9
TT
64632019-05-04 Tom Tromey <tom@tromey.com>
6464
6465 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6466 Use gdb_assert_not_reached.
6467
9c056022
TT
64682019-05-04 Tom Tromey <tom@tromey.com>
6469
6470 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6471 "false".
6472
fa9c2a59
TT
64732019-05-04 Tom Tromey <tom@tromey.com>
6474
6475 * arc-tdep.c (arc_tdesc_init): Use bool.
6476
e2eb806a
TT
64772019-05-04 Tom Tromey <tom@tromey.com>
6478
6479 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6480
6fe87677
TT
64812019-05-04 Tom Tromey <tom@tromey.com>
6482
6483 * cli/cli-cmds.c (valid_command_p): Return bool.
6484
7f008c9e
TT
64852019-05-04 Tom Tromey <tom@tromey.com>
6486
6487 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6488 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6489
b6484282
RT
64902019-05-04 Raul Tambre <raul@tambre.ee>
6491
6492 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6493 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6494 operator for comparison.
6495
af97b416
TT
64962019-05-04 Tom Tromey <tom@tromey.com>
6497
6498 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6499 (lookup_partial_symbol, print_partial_symbols)
6500 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6501 (psymbol_compare): Update.
6502 (add_psymbol_to_bcache): Clear the entire psymbol.
6503 (maintenance_check_psymtabs): Update.
6504 * psympriv.h (struct partial_symbol): Don't derive from
6505 general_symbol_info.
6506 <obj_section, unrelocated_address, address,
6507 set_unrelocated_address>: Update.
6508 <ginfo>: New member.
6509 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6510 (debug_names::write_psymbols): Update.
6511
9d6d4be8
TV
65122019-05-04 Tom de Vries <tdevries@suse.de>
6513
6514 * contrib/cc-with-tweaks.sh: Support -n arg.
6515
66452beb
PW
65162019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6517
6518 * corelow.c (core_target::detach): Ensure frame cache and
6519 register caches are cleared.
6520 inferior.c (exit_inferior_1): Likewise.
6521
bde09ab7
TT
65222019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6523 Tom Tromey <tom@tromey.com>
6524
6525 * dictionary.c (collate_pending_symbols_by_language): Remove
6526 "struct" from foreach.
6527 * symtab.c (lookup_global_symbol_from_objfile)
6528 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6529 foreach.
6530 * ser-tcp.c (net_open): Remove "struct" from foreach.
6531 * objfiles.c (objfile_relocate, objfile_rebase)
6532 (objfile_has_symbols): Remove "struct" from foreach.
6533 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6534 from foreach.
6535 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6536 foreach.
6537 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6538 "struct" from foreach.
6539 * ada-lang.c (create_excep_cond_exprs)
6540 (ada_exception_catchpoint_cond_string): Remove "struct" from
6541 foreach.
6542
222a8d25
TT
65432019-05-03 Tom Tromey <tromey@adacore.com>
6544
6545 * ada-exp.y (convert_char_literal): Check suffix of each
6546 enumerator.
6547
fcd60b84
DP
65482019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6549
6550 PR ada/21406:
6551 * ada-exp.y (yywrap): Don't define.
6552 * ada-lex.l (%option): Add noyywrap
6553 (yywrap): Remove.
6554
5f2459c2
EZ
65552019-05-03 Eli Zaretskii <eliz@gnu.org>
6556
353ea2d1
EZ
6557 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6558 _WIN32_WINNT to the XP level, unless already defined to a higher
6559 level.
6560
6561 * unittests/parse-connection-spec-selftests.c:
6562 * ser-tcp.c:
6563 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6564 override.
6565
5f2459c2
EZ
6566 * symfile.c (find_separate_debug_file): Remove colon from the
6567 drive spec of DOS/Windows file names of the target, so that the
6568 file name produced from DEBUGDIR and the target's directory will
6569 be valid on DOS/Windows systems.
6570
80062eb9
AB
65712019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6572
6573 * rust-lang.c (val_print_struct): Handle printing structures
6574 containing strings.
6575
b8c05e85
TT
65762019-05-02 Tom Tromey <tromey@adacore.com>
6577
6578 * valarith.c (_initialize_valarith): Remove.
6579
4504bbde
TT
65802019-05-01 Tom Tromey <tromey@adacore.com>
6581
6582 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6583 bitfields.
6584
d48e62f4
TT
65852019-05-01 Tom Tromey <tromey@adacore.com>
6586
6587 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6588 for big-endian copies.
6589
15f18d14
AT
65902019-04-30 Ali Tamur <tamur@google.com>
6591 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6592 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6593 (read_3_bytes): New function.
6594
ab4ee614
JB
65952019-04-30 Joel Brobecker <brobecker@adacore.com>
6596
6597 * windows-nat.c (main_thread_id): Delete.
6598 (handle_output_debug_string): Replace main_thread_id by
6599 current_event.dwThreadId.
6600 (fake_create_process): Likewise.
6601 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6602 Do not set main_thread_id.
6603 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6604 current_event.dwThreadId.
6605 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6606
8ed5b76e
JB
66072019-04-30 Joel Brobecker <brobecker@adacore.com>
6608
6609 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6610 Use current_event.dwThreadId instead of main_thread_id.
6611
2ff0a947
TT
66122019-04-30 Tom Tromey <tromey@adacore.com>
6613
6614 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6615 (create_excep_cond_exprs): Iterate over program spaces.
6616 (ada_exception_catchpoint_cond_string): Examine all minimal
6617 symbols for exception types.
6618
a776957c
TT
66192019-04-30 Tom Tromey <tromey@adacore.com>
6620
6621 PR c++/24470:
6622 * dwarf2read.c (process_structure_scope): Handle case where type
6623 has template parameters but no symbol was created.
6624
bc68014d
AB
66252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6626 Chris January <chris.january@arm.com>
6627
6628 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6629 qualifier.
6630 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6631
f1fdc960
AB
66322019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6633
6634 * f-typeprint.c (f_print_type): Update rules for printing
6635 whitespace.
6636 (f_type_print_varspec_suffix): Likewise.
6637
bf7a4de1
AB
66382019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6639 Chris January <chris.january@arm.com>
6640
6641 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6642 function arguments.
6643
bbe75b9d
AB
66442019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6645
6646 * f-lang.c (build_fortran_types): Change name of void type to
6647 lower case.
6648 * f-typeprint.c (f_type_print_base): Print the name of the void
6649 type, rather than a fixed string.
6650 * f-valprint.c (f_decorations): Use lower case void string.
6651
1db455a7
AB
66522019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6653 Chris January <chris.january@arm.com>
6654
6655 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6656 types for Fortran.
6657
b6d03bb2
AB
66582019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6659 Chris January <chris.january@arm.com>
6660 David Lecomber <david.lecomber@arm.com>
6661
6662 * f-exp.y (BINOP_INTRINSIC): New token.
6663 (exp): New parser rule handling BINOP_INTRINSIC.
6664 (f77_keywords): Add new builtin procedures.
6665 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6666 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6667 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6668 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6669 (print_unop_subexp_f): New function.
6670 (print_binop_subexp_f): New function.
6671 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6672 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6673 (dump_subexp_body_f): Likewise.
6674 (operator_check_f): Likewise.
6675 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6676 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6677
83228e93
AB
66782019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6679
6680 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6681 UNOP_KIND.
6682 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6683 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6684 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6685 (operator_length_f): New fuction.
6686 (print_subexp_f): New function.
6687 (op_name_f): New function.
6688 (dump_subexp_body_f): New function.
6689 (operator_check_f): New function.
6690 (exp_descriptor_f): Replace standard expression handling functions
6691 with new functions.
6692 * gdb/fortran-operator.def: New file.
6693 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6694 * gdb/std-operator.def: Remove UNOP_KIND.
6695
6fdcd7cc
AB
66962019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6697
6698 * std-operator.def: Remove unbalanced, stray double quote
6699 character.
6700
2e62ab40
AB
67012019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6702 Chris January <chris.january@arm.com>
6703 Daniel Everett <daniel.everett@arm.com>
6704 Nick Forrington <nick.forrington@arm.com>
6705 Richard Bunt <richard.bunt@arm.com>
6706
6707 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6708 of depth when printing anonymous structs or unions.
6709 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6710 Don't print either the top-level value, or the children if the
6711 max-depth is exceeded.
6712 (ppscm_print_children): When printing the key of a map, allow one
6713 extra level of depth.
6714 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6715 print either the top-level value, or the children if the max-depth
6716 is exceeded.
6717 (print_children): When printing the key of a map, allow one extra
6718 level of depth.
6719 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6720 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6721 (user_print_options): Initialise max_depth field.
6722 (val_print_scalar_or_string_type_p): New function.
6723 (val_print): Check to see if the max depth has been reached.
6724 (val_print_check_max_depth): Define new function.
6725 (show_print_max_depth): New function.
6726 (_initialize_valprint): Add 'print max-depth' option.
6727 * valprint.h (struct value_print_options) <max_depth>: New field.
6728 (val_print_check_max_depth): Declare new function.
6729 * NEWS: Document new feature.
6730
4be290b2
AB
67312019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6732
6733 * ada-lang.c (ada_language_defn): Initialise new field.
6734 * c-lang.c (c_is_string_type_p): New function.
6735 (c_language_defn): Initialise new field.
6736 (cplus_language_defn): Initialise new field.
6737 (asm_language_defn): Initialise new field.
6738 (minimal_language_defn): Initialise new field.
6739 * c-lang.h (c_is_string_type_p): Declare new function.
6740 * d-lang.c (d_language_defn): Initialise new field.
6741 * f-lang.c (f_is_string_type_p): New function.
6742 (f_language_defn): Initialise new field.
6743 * go-lang.c (go_is_string_type_p): New function.
6744 (go_language_defn): Initialise new field.
6745 * language.c (default_is_string_type_p): New function.
6746 (unknown_language_defn): Initialise new field.
6747 (auto_language_defn): Initialise new field.
6748 * language.h (struct language_defn) <la_is_string_type_p>: New
6749 member variable.
6750 (default_is_string_type_p): Declare new function.
6751 * m2-lang.c (m2_language_defn): Initialise new field.
6752 * objc-lang.c (objc_language_defn): Initialise new field.
6753 * opencl-lang.c (opencl_language_defn): Initialise new field.
6754 * p-lang.c (pascal_is_string_type_p): New function.
6755 (pascal_language_defn): Initialise new field.
6756 * rust-lang.c (rust_is_string_type_p): New function.
6757 (rust_language_defn): Initialise new field.
6758
721b08c6
AB
67592019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6760
6761 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6762 New field.
6763 * ada-lang.c (ada_language_defn): Initialise new field.
6764 * c-lang.c (c_language_defn): Likewise.
6765 (cplus_language_defn): Likewise.
6766 (asm_language_defn): Likewise.
6767 (minimal_language_defn): Likewise.
6768 * d-lang.c (d_language_defn): Likewise.
6769 * f-lang.c (f_language_defn): Likewise.
6770 * go-lang.c (go_language_defn): Likewise.
6771 * language.c (unknown_language_defn): Likewise.
6772 (auto_language_defn): Likewise.
6773 * m2-lang.c (m2_language_defn): Likewise.
6774 * objc-lang.c (objc_language_defn): Likewise.
6775 * opencl-lang.c (opencl_language_defn): Likewise.
6776 * p-lang.c (pascal_language_defn): Likewise.
6777 * rust-lang.c (rust_language_defn): Likewise.
6778
fc913e53
AB
67792019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6780
6781 * ada-lang.c (ada_is_character_type): Change return type to bool.
6782 (ada_is_string_type): Likewise.
6783 * ada-lang.h (ada_is_character_type): Update declaration
6784 (ada_is_string_type): Likewise.
6785
fa731fa0
PW
67862019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6787
6788 Support style in 'frame|thread apply'
6789
6790 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6791 * record.c (record_start, record_stop): Update callers of
6792 execute_command_to_string with false.
6793 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6794 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6795 methods.
6796 (class string_file): New constructor with term_out parameter.
6797 Override methods term_out and can_emit_style_escape. New member
6798 term_out.
6799 (class stdio_file): Override can_emit_style_escape.
6800 (class tee_file): Override term_out and can_emit_style_escape.
6801 * utils.h (can_emit_style_escape): Remove.
6802 * utils.c (can_emit_style_escape): Likewise.
6803 Update all callers of can_emit_style_escape (SOMESTREAM) to
6804 SOMESTREAM->can_emit_style_escape.
6805 * source-cache.c (source_cache::get_source_lines): Likewise.
6806 * stack.c (frame_apply_command_count): Call execute_command_to_string
6807 passing the term_out characteristic of the current gdb_stdout.
6808 * thread.c (thr_try_catch_cmd): Likewise.
6809 * top.c (execute_command_to_string): pass term_out parameter
6810 to construct the string_file for the command output.
6811 * ui-file.c (term_cli_styling): New function (most code moved
6812 from utils.c can_emit_style_escape).
6813 (string_file::string_file, string_file::can_emit_style_escape,
6814 stdio_file::can_emit_style_escape, tee_file::term_out,
6815 tee_file::can_emit_style_escape): New functions.
6816
136afab8
PW
68172019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6818
6819 * NEWS: Mention the new set|show may-call-functions.
6820 * infcall.c (may_call_functions_p): New variable.
6821 (show_may_call_functions_p): New function.
6822 (call_function_by_hand_dummy): Throws an error if not
6823 may-call-functions.
6824 (_initialize_infcall): Call add_setshow_boolean_cmd for
6825 may-call-functions.
6826
725cbb63
KS
68272019-04-25 Keith Seitz <keiths@redhat.com>
6828
6829 PR c++/24367
6830 * cp-support.c (inspect_type): Don't attempt substitutions
6831 of symbol with the same name.
6832
3d1cbb78
TT
68332019-04-25 Tom Tromey <tromey@adacore.com>
6834
6835 PR gdb/24475:
6836 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6837 static.
6838
94aeb44b
TT
68392019-04-25 Tom Tromey <tromey@adacore.com>
6840
6841 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6842 rvalue reference.
6843 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6844 (gdb_xml_parser::parse): Use std::move.
6845 * python/python-internal.h (gdbpy_convert_exception): Take a const
6846 reference.
6847 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6848 std::move.
6849 * python/py-utils.c (gdbpy_convert_exception): Take a const
6850 reference.
6851 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6852 Use std::move.
6853 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6854 Use std::move.
6855 * mi/mi-main.c (mi_print_exception): Take a const reference.
6856 * main.c (handle_command_errors): Take a const reference.
6857 * linespec.c (parse_linespec): Use std::move.
6858 * infcall.c (run_inferior_call): Use std::move.
6859 (call_function_by_hand_dummy): Use std::move.
6860 * exec.c (try_open_exec_file): Use std::move.
6861 * exceptions.h (exception_print, exception_fprintf)
6862 (exception_print_same): Update.
6863 * exceptions.c (print_exception, exception_print)
6864 (exception_fprintf, exception_print_same): Change parameters to
6865 const reference.
6866 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6867 * common/new-op.c: Use std::move.
6868 * common/common-exceptions.h (struct gdb_exception): Add move
6869 constructor.
6870 (struct gdb_exception_error, struct gdb_exception_quit, struct
6871 gdb_quit_bad_alloc): Change constructor to move constructor.
6872 (throw_exception): Change parameter to rvalue reference.
6873 * common/common-exceptions.c (throw_exception): Take rvalue
6874 reference.
6875 * cli/cli-interp.c (safe_execute_command): Use std::move.
6876 * breakpoint.c (insert_bp_location, location_to_sals): Use
6877 std::move.
6878
680d7fd5
TT
68792019-04-25 Tom Tromey <tromey@adacore.com>
6880
6881 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6882 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6883 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6884 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6885 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6886 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6887 guile/scm-value.c: Use unpack.
6888 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6889 gdbscm_gdb_exception.
6890 (gdbscm_throw_gdb_exception): Likewise.
6891 (struct gdbscm_gdb_exception): New.
6892 (unpack): New function.
6893 (gdbscm_wrap): Use unpack.
6894
c6fdd8b2
TT
68952019-04-25 Tom Tromey <tromey@adacore.com>
6896
6897 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6898 (gdb_rl_callback_handler): Use std::move.
6899 * common/common-exceptions.h (struct gdb_exception): Add move
6900 assignment operator.
6901 (throw_exception_sjlj): Change "exception" to const reference.
6902 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6903 (throw_exception_sjlj): Change "exception" to const reference.
6904
cc06b668
TT
69052019-04-25 Tom Tromey <tromey@adacore.com>
6906
6907 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6908 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6909 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6910 Update.
6911 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6912 Update.
6913 * mi/mi-interp.c (mi_interp::exec): Update.
6914 * linespec.c (parse_linespec): Update.
6915 * infcall.c (run_inferior_call): Update.
6916 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6917 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6918 (gdbscm_lookup_global_symbol): Update.
6919 * guile/scm-param.c (gdbscm_parameter_value): Update.
6920 * guile/scm-frame.c (gdbscm_frame_read_register)
6921 (gdbscm_frame_read_var): Update.
6922 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6923 * exec.c (try_open_exec_file): Update.
6924 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6925 (gdb_rl_callback_handler): Update.
6926 * common/common-exceptions.h (exception_none): Don't declare.
6927 * common/common-exceptions.c (exception_none): Don't define.
6928 (struct catcher) <exception>: Update.
6929 * cli/cli-interp.c (safe_execute_command): Update.
6930 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6931
cf532bd1
AT
69322019-04-25 Ali Tamur <tamur@google.com>
6933
6934 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6935 (read_attribute_value): Likewise.
6936 (dwarf2_read_addr_index): Update comment.
6937 (read_str_index): Add DW_FORM_strx.
6938 (dwarf2_string_attr): Likewise.
6939 (dwarf2_const_value_attr): Likewise.
6940 (dump_die_shallow): Likewise.
6941 (dwarf2_fetch_constant_bytes): Likewise.
6942 (skip_form_bytes): Likewise.
6943 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6944
82433e3e
SDJ
69452019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6946
6947 PR corefiles/11608
6948 PR corefiles/18187
6949 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6950 OFFSET. Verify if current mapping contains an ELF header.
6951 (linux_find_memory_regions_full): Adjust call to
6952 dump_mapping_p.
6953
723adb65
SL
69542019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6955 Kang Li <kanglictf@gmail.com>
6956
6957 PR gdb/21600
6958
6959 * dwarf2-frame.c (read_initial_length): Be consistent about using
6960 unsigned representation of length.
6961 (decode_frame_entry_1): Likewise. Check for wraparound of
6962 end pointer as well as buffer overflow.
6963
596179f7
SDJ
69642019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6965
6966 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6967 "vq".
6968
a59240a4
TT
69692019-04-24 Tom Tromey <tromey@adacore.com>
6970
6971 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6972
f872fdbb
AB
69732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6974
6975 * s12z-tdep.c (s12z_unwind_pc): Delete.
6976 (s12z_unwind_sp): Delete.
6977 (s12z_gdbarch_init): Don't register deleted functions with
6978 gdbarch.
6979
b614e6f3
AB
69802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6981
6982 * rl78-tdep.c (rl78_unwind_sp): Delete.
6983 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6984
14faed38
AB
69852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6986
6987 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6988 (xstormy16_unwind_pc): Delete.
6989 (xstormy16_dummy_id): Delete.
6990 (xstormy16_gdbarch_init): Don't register deleted functions with
6991 gdbarch.
6992
541aad8a
AB
69932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6994
6995 * vax-tdep.c (vax_unwind_pc): Delete.
6996 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6997
29222070
AB
69982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6999
7000 * v850-tdep.c (v850_unwind_sp): Delete.
7001 (v850_unwind_pc): Delete.
7002 (v850_dummy_id): Delete.
7003 (v850_gdbarch_init): Don't register deleted functions with
7004 gdbarch.
7005
0f534d76
AB
70062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7007
7008 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7009 (tilegx_unwind_pc): Delete.
7010 (tilegx_unwind_dummy_id): Delete.
7011 (tilegx_gdbarch_init): Don't register deleted functions with
7012 gdbarch.
7013
1ba7b7f9
AB
70142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7015
7016 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7017 (tic6x_dummy_id): Delete.
7018 (tic6x_gdbarch_init): Don't register deleted functions with
7019 gdbarch.
7020
d31f262c
AB
70212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7022
7023 * sparc-tdep.c (sparc_unwind_pc): Delete.
7024 (sparc32_gdbarch_init): Don't register deleted function with
7025 gdbarch.
7026
6d14d64d
AB
70272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7028
7029 * sh-tdep.c (sh_unwind_sp): Delete.
7030 (sh_unwind_pc): Delete.
7031 (sh_dummy_id): Delete.
7032 (sh_gdbarch_init): Don't register deleted functions with
7033 gdbarch.
7034
a40dde9d
AB
70352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7036
7037 * score-tdep.c (score_unwind_sp): Delete.
7038 (score_unwind_pc): Delete.
7039 (score_dummy_id): Delete.
7040 (score_gdbarch_init): Don't register deleted functions with
7041 gdbarch.
7042
47c47d69
AB
70432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7044
7045 * rx-tdep.c (rx_unwind_pc): Delete.
7046 (rx_unwind_sp): Delete.
7047 (rx_dummy_id): Delete.
7048 (rx_gdbarch_init): Don't register deleted functions with
7049 gdbarch. Update comment.
7050
833a4480
AB
70512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7052
7053 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7054 (rs6000_dummy_id): Delete.
7055 (rs6000_gdbarch_init): Don't register deleted functions with
7056 gdbarch.
7057
3f2cef49
AB
70582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7059
7060 * or1k-tdep.c (or1k_dummy_id): Delete.
7061 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7062
96acf884
AB
70632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7064
7065 * nios2-tdep.c (nios2_dummy_id): Delete.
7066 (nios2_unwind_sp): Delete.
7067 (nios2_gdbarch_init): Don't register deleted functions with
7068 gdbarch.
7069
ca0ab0aa
AB
70702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7071
7072 * nds32-tdep.c (nds32_dummy_id): Delete.
7073 (nds32_unwind_pc): Delete.
7074 (nds32_unwind_sp): Delete.
7075 (nds32_gdbarch_init): Don't register deleted functions with
7076 gdbarch.
7077
c8259044
AB
70782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7079
7080 * msp430-tdep.c (msp430_unwind_pc): Delete.
7081 (msp430_unwind_sp): Delete.
7082 (msp430_dummy_id): Delete.
7083 (msp430_gdbarch_init): Don't register deleted functions with
7084 gdbarch.
7085
27f113c8
AB
70862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7087
7088 * moxie-tdep.c (moxie_unwind_sp): Delete.
7089 (moxie_unwind_pc): Delete.
7090 (moxie_dummy_id): Delete.
7091 (moxie_gdbarch_init): Don't register deleted functions with
7092 gdbarch.
7093
aee6c3cd
AB
70942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7095
7096 * mn10300-tdep.c (mn10300_dummy_id): Delete.
7097 (mn10300_unwind_pc): Delete.
7098 (mn10300_unwind_sp): Delete.
7099 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7100 mn10300_unwind_sp.
7101 (mn10300_frame_unwind_init): Don't register deleted functions with
7102 gdbarch.
7103
8e2b5aea
AB
71042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7105
7106 * mep-tdep.c (mep_unwind_pc): Delete.
7107 (mep_unwind_sp): Delete.
7108 (mep_dummy_id): Delete.
7109 (mep_gdbarch_init): Don't register deleted functions with
7110 gdbarch.
7111
43cf3ede
AB
71122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7113
7114 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7115 (m68hc11_unwind_sp): Delete.
7116 (m68hc11_gdbarch_init): Don't register deleted functions with
7117 gdbarch.
7118
5e79b7bb
AB
71192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7120
7121 * m32r-tdep.c (m32r_unwind_sp): Delete.
7122 (m32r_unwind_pc): Delete.
7123 (m32r_dummy_id): Delete.
7124 (m32r_gdbarch_init): Don't register deleted functions with
7125 gdbarch.
7126
89b268d8
AB
71272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7128
7129 * m32c-tdep.c (m32c_unwind_pc): Delete.
7130 (m32c_unwind_sp): Delete.
7131 (m32c_dummy_id): Delete.
7132 (m32c_gdbarch_init): Don't register deleted functions with
7133 gdbarch.
7134
946c28d2
AB
71352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7136
7137 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7138 (lm32_unwind_pc): Delete.
7139 (lm32_dummy_id): Delete.
7140 (lm32_gdbarch_init): Don't register deleted functions with
7141 gdbarch.
7142
bf12844a
AB
71432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7144
7145 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7146 (iq2000_unwind_pc): Delete.
7147 (iq2000_dummy_id): Delete.
7148 (iq2000_gdbarch_init): Don't register deleted functions with
7149 gdbarch.
7150
ecbc06d2
AB
71512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7152
7153 * nds32-tdep.c (nds32_type_align): Delete.
7154 (nds32_push_dummy_call): Use type_align instead.
7155
030197b4
AB
71562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7157
7158 * arm-tdep.c (arm_type_align): Only handle vector override case.
7159 (arm_push_dummy_call): Use type_align.
7160 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7161
b907456c
AB
71622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7163
7164 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7165 case.
7166 (pass_on_stack): Use type_align.
7167 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7168 function.
7169
9e97ba43
TT
71702019-04-23 Tom Tromey <tromey@adacore.com>
7171
7172 * dwarf2read.c (line_header::file_name_at): Remove unused
7173 overload.
7174
6892f601
TV
71752019-04-23 Tom de Vries <tdevries@suse.de>
7176
7177 PR gdb/24438
7178 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7179 invocation.
7180
336d760d
AT
7181
71822019-03-27 Ali Tamur <tamur@google.com>
7183
7184 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7185 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7186 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7187 (dwarf_expr_context::get_addr_index): Likewise
7188 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7189 (symbol_needs_eval_context::get_addr_index): Likewise
7190 (disassemble_dwarf_expression): Add DW_OP_addrx
7191 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7192 (read_cutu_die_from_dwo): Update comment
7193 (skip_one_die): Add DW_FORM_addrx
7194 (read_attribute_value): Likewise
7195 (var_decode_location): Add DW_OP_addrx
7196 (dwarf2_const_value_attr): Add DW_FORM_addrx
7197 (dump_die_shallow): Likewise
7198 (dwarf2_fetch_constant_bytes): Likewise
7199 (decode_locdesc): Add DW_OP_addrx
7200 (skip_form_bytes): Add DW_FORM_addrx
7201
ad9d13f8
AT
72022019-04-22 Ali Tamur <tamur@google.com>
7203
7204 * MAINTAINERS (Write After Approval): Add self.
7205
d70cc3ba
SM
72062019-04-22 Simon Marchi <simon.marchi@efficios.com>
7207
7208 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7209 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7210 (open_symbol_file_object): Likewise.
7211 (svr4_default_sos): Add info parameter.
7212 (svr4_read_so_list): Likewise.
7213 (svr4_current_sos_direct): Adjust functions calls to pass down
7214 info.
7215 (svr4_current_sos_1): Add info parameter.
7216 (svr4_current_sos): Call get_svr4_info, pass info down to
7217 svr4_current_sos_1.
7218 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7219 get_svr4_info.
7220 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7221 get_svr4_info.
7222 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7223 to get_svr4_info.
7224 (probes_table_remove_objfile_probes): Likewise.
7225 (register_solib_event_probe): Add info parameter.
7226 (solist_update_incremental): Pass info parameter down to
7227 svr4_read_so_list.
7228 (disable_probes_interface): Add info parameter.
7229 (svr4_handle_solib_event): Pass current_program_space to
7230 get_svr4_info. Adjust disable_probes_interface cleanup.
7231 (svr4_create_probe_breakpoints): Add info parameter, pass it
7232 down to register_solib_event_probe.
7233 (svr4_create_solib_event_breakpoints): Add info parameter,
7234 pass it down to svr4_create_probe_breakpoints.
7235 (enable_break): Pass info down to
7236 svr4_create_solib_event_breakpoints.
7237 (svr4_solib_create_inferior_hook): Pass current_program_space to
7238 get_svr4_info.
7239 (svr4_clear_solib): Likewise.
7240
7905fc35
PA
72412019-04-22 Pedro Alves <palves@redhat.com>
7242
7243 * solib-svr4.c (svr4_free_objfile_observer): New.
7244 (probe_and_action::objfile): New field.
7245 (probes_table_htab_remove_objfile_probes)
7246 (probes_table_remove_objfile_probes): New functions.
7247 (register_solib_event_probe): Add 'objfile' parameter. Store it
7248 in the new probe_and_action. Don't store the probe in 'lookup'.
7249 (svr4_create_probe_breakpoints): Pass objfile to
7250 register_solib_event_probe.
7251 (_initialize_svr4_solib): Register a free_objfile observer.
7252
fb881986
TT
72532019-04-19 Tom Tromey <tom@tromey.com>
7254
7255 * common/queue.h: Remove.
7256
8732db6c
TT
72572019-04-19 Tom Tromey <tom@tromey.com>
7258
7259 * event-loop.c: Don't include "common/queue.h".
7260
97dfbadd
TT
72612019-04-19 Tom Tromey <tom@tromey.com>
7262
7263 * remote.c (remote_target): Use delete.
7264 * remote-notif.h: Include <list>, not "common/queue.h".
7265 (notif_client_p): Remove typedef.
7266 (remote_notif_state): Add constructor, destructor, initializer.
7267 <notif_queue>: Now a std::list.
7268 (remote_notif_state_xfree): Don't declare.
7269 * remote-notif.c (remote_notif_process, handle_notification)
7270 (remote_notif_state_allocate): Update.
7271 (~remote_notif_state): Rename from remote_notif_state_xfree.
7272
cf250e36
TT
72732019-04-19 Tom Tromey <tom@tromey.com>
7274
7275 * symfile.c (reread_symbols): Update.
7276 * objfiles.c (objfile_register_static_link)
7277 (objfile_lookup_static_link): Update
7278 (~objfile) Don't delete static_links.
7279 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7280
61f4b350
TT
72812019-04-19 Tom Tromey <tom@tromey.com>
7282
7283 * type-stack.h (struct type_stack) <insert>: Constify string.
7284 * type-stack.c (type_stack::insert): Constify string.
7285 * gdbtypes.h (lookup_template_type): Update.
7286 (address_space_name_to_int): Update.
7287 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7288 const.
7289 (lookup_template_type): Make name const.
7290 * c-exp.y: Update rules.
7291 (lex_one_token, classify_name, classify_inner_name)
7292 (c_print_token): Update.
7293 * p-exp.y: Update rules.
7294 (yylex): Update.
7295 * f-exp.y: Update rules.
7296 (yylex): Update.
7297 * d-exp.y: Update rules.
7298 (lex_one_token, classify_name, classify_inner_name): Update.
7299 * parse.c (write_dollar_variable, copy_name): Return std::string.
7300 * parser-defs.h (copy_name): Change return type.
7301 * m2-exp.y: Update rules.
7302 (yylex): Update.
7303 * go-exp.y (lex_one_token): Update.
7304 Update rules.
7305 (classify_unsafe_function, classify_packaged_name)
7306 (classify_name, yylex): Update.
7307
189b8c2e
ST
73082019-04-19 Sergei Trofimovich <siarheit@google.com>
7309
7310 * configure.ac: add --enable-source-highlight switch.
7311 * configure: Regenerate.
7312 * top.c (print_gdb_version): plumb --enable-source-highlight
7313 status to "show configuration".
7314
8ecb59f8
TT
73152019-04-19 Tom Tromey <tromey@adacore.com>
7316
7317 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7318 Check ADA_TYPE_P.
7319 (empty_record, ada_template_to_fixed_record_type_1)
7320 (template_to_static_fixed_type)
7321 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7322 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7323 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7324 macros.
7325
62160ec9
TT
73262019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7327
7328 PR symtab/24423:
7329 * source.c (print_source_lines_base): Advance "iter" when a
7330 control character is seen.
7331
f2ae8bc8
PW
73322019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7333
7334 * inferior.h (struct infcall_suspend_state_deleter):
7335 Catch exception in destructor to avoid crash.
7336
d563b953
PW
73372019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7338
7339 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7340 close to the add_com "shell".
7341
dc34c897
TT
73422019-04-18 Tom Tromey <tromey@adacore.com>
7343
7344 * process-stratum-target.h (class process_stratum_target)
7345 <stratum>: Add "final".
7346
a12e5744
TT
73472019-04-17 Tom Tromey <tromey@adacore.com>
7348
7349 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7350 against nullptr before use.
7351
a7e559cc
AH
73522019-04-17 Alan Hayward <alan.hayward@arm.com>
7353
7354 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7355
c01660c6
AB
73562019-04-17 Jim Wilson <jimw@sifive.com>
7357 Andrew Burgess <andrew.burgess@embecosm.com>
7358
7359 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7360 code read might fail, assume 4-byte breakpoint in that case.
7361
4aa866af
LS
73622019-04-15 Leszek Swirski <leszeks@google.com>
7363
7364 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7365 rather than a hand-rolled POD check when checking for forced MEMORY
7366 classification.
7367
48574d91
AH
73682019-04-15 Alan Hayward <alan.hayward@arm.com>
7369
7370 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7371 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7372 function.
7373 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7374 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7375 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7376 declaration.
7377
4da037ef
AH
73782019-04-15 Alan Hayward <alan.hayward@arm.com>
7379
7380 * aarch64-linux-nat.c
7381 (aarch64_linux_nat_target::thread_architecture): Add override.
7382 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7383 each VQ.
7384
ccb8d7e8
AH
73852019-04-15 Alan Hayward <alan.hayward@arm.com>
7386
7387 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7388
35add35e
AB
73892019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7390
7391 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7392 target types of size 96-bits, add some additional comments, and
7393 check that the builtin type we found was the correct size.
7394
51196bbc
EZ
73952019-04-12 Eli Zaretskii <eliz@gnu.org>
7396
7397 * utils.c (prompt_for_continue): Don't restore the styling at the
7398 end, as applied_style has the wrong value. This fixes styling in
7399 long lists of file names that are interrupted by the "Continue?"
7400 prompt.
7401
62253a61
AB
74022019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7403
7404 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7405 * c-lang.c (c_language_defn): Likewise.
7406 (cplus_language_defn): Likewise.
7407 (asm_language_defn): Likewise.
7408 (minimal_language_defn): Likewise.
7409 * d-lang.c (d_language_defn): Likewise.
7410 * f-lang.c (f_language_defn): Likewise.
7411 * go-lang.c (go_language_defn): Likewise.
7412 * language.c (unknown_language_defn): Likewise.
7413 (auto_language_defn): Likewise.
7414 * language.h (struct language_defn): Remove la_magic field.
7415 (LANG_MAGIC): Delete.
7416 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7417 * objc-lang.c (objc_language_defn): Likewise.
7418 * opencl-lang.c (opencl_language_defn): Likewise.
7419 * p-lang.c (pascal_language_defn): Likewise.
7420 * rust-lang.c (rust_language_defn): Likewise.
7421
a9158a86
AB
74222019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7423
7424 * riscv-tdep.c (riscv_type_align): New function.
7425 (riscv_type_alignment): Delete.
7426 (riscv_arg_location): Use 'type_align'.
7427 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7428
41077b66
AB
74292019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7430
7431 * gdbtypes.c (type_align): A struct with no non-static fields also
7432 has alignment of 1.
7433
9f0272f8
AB
74342019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7435
7436 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7437 component to 0.
7438 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7439 member.
7440 (riscv_struct_info::analyse): New implementation using new
7441 analyse_inner member function.
7442 (riscv_struct_info::field_offset): New member function.
7443 (riscv_struct_info::m_offsets): New member variable.
7444 (riscv_struct_info::analyse_inner): New private member function,
7445 takes the old implementation of riscv_struct_info::analyse but
7446 extended to track field offsets.
7447 (riscv_call_arg_struct): Update the struct folding special cases
7448 to handle cases where empty C++ structs, which are non-zero
7449 length, are found.
7450 (riscv_arg_location): Initialise the length of each location, a
7451 non-zero length now indicates the location is in use.
7452 (riscv_push_dummy_call): Allow for the first location having a
7453 non-zero offset when setting up arguments.
7454 (riscv_return_value): Likewise, but for return values.
7455
02cf60c7
TT
74562019-04-11 Tom Tromey <tromey@adacore.com>
7457
7458 * utils.c (internal_vproblem): Make "msg" const.
7459
68811f8f
AH
74602019-04-11 Alan Hayward <alan.hayward@arm.com>
7461
7462 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7463 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7464 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7465 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7466
3f52fdbc
KB
74672019-04-10 Kevin Buettner <kevinb@redhat.com>
7468
7469 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7470 function.
7471 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7472 of amd64_collect_native_gregset.
7473 (amd64_linux_nat_target::store_registers): Likewise.
7474
e9ad22ee
TT
74752019-04-10 Tom Tromey <tom@tromey.com>
7476
7477 * symtab.c (lookup_global_symbol_from_objfile)
7478 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7479 * objfiles.h (class separate_debug_iterator): New.
7480 (class separate_debug_range): New.
7481 (struct objfile) <separate_debug_objfiles>: New method.
7482 (objfile_separate_debug_iterate): Don't declare.
7483 * objfiles.c (separate_debug_iterator::operator++): Rename from
7484 objfile_separate_debug_iterate.
7485 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7486 iterator.
7487 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7488 iterator.
7489
ee371134
TT
74902019-04-10 Tom Tromey <tom@tromey.com>
7491
7492 * symfile.c (reread_symbols): Remove old comment.
7493 * objfiles.c (free_all_objfiles): Fix a typo.
7494
bf227d61
TT
74952019-04-10 Tom Tromey <tom@tromey.com>
7496
7497 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7498 * minsyms.c (lookup_minimal_symbol): Use foreach.
7499 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7500 (lookup_minimal_symbol_solib_trampoline): Likewise.
7501 * symfile.c (reread_symbols): Use foreach.
7502
8dc433a0
TT
75032019-04-09 Ivan Begert <ivanbegert@gmail.com>
7504 Tom Tromey <tromey@adacore.com>
7505
7506 PR rust/24414:
7507 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7508 (rust_lex_int_test): Change "value" to be LONGEST.
7509 (rust_lex_tests): Add test for long integer literal.
7510
9ab8741a
TT
75112019-04-09 Tom Tromey <tromey@adacore.com>
7512
7513 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7514 to bool.
7515 (extended_remote_target::attach): Update.
7516 (remote_target::remote_notice_new_inferior): Update.
7517 (remote_target::add_current_inferior_and_thread): Update.
7518 * inferior.c (exit_inferior_1): Use "false".
7519 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7520
e242fd12
SM
75212019-04-09 Simon Marchi <simon.marchi@efficios.com>
7522
9ca1957f 7523 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
7524 the "start" command.
7525
2b0c8b01
KB
75262019-04-08 Kevin Buettner <kevinb@redhat.com>
7527
7528 * python/py-inferior.c (infpy_thread_from_thread_handle):
7529 Adjust comments to reflect renaming of thread_from_thread_handle
7530 to thread_from_handle. Adjust keywords. Fix type error message.
7531 (inferior_object_methods): Add thread_from_handle. Retain
7532 thread_from_thread_handle, but mark it as deprecated.
7533
50a82723
KB
75342019-04-08 Kevin Buettner <kevinb@redhat.com>
7535
7536 * gdbthread.h (find_thread_by_handle): Revise declaration.
7537 * thread.c (find_thread_by_handle): Likewise. Adjust
7538 implementation too.
7539 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7540 support for buffer objects as handles.
7541
cf63b016
KB
75422019-04-08 Kevin Buettner <kevinb@redhat.com>
7543
7544 * python/py-infthread.c (thpy_thread_handle): New function.
7545 (thread_object_methods): Register thpy_thread_handle.
7546
3d6c6204
KB
75472019-04-08 Kevin Buettner <kevinb@redhat.com>
7548
7549 * gdbthread.h (thread_to_thread_handle): Declare.
7550 * thread.c (gdbtypes.h): Include.
7551 (thread_to_thread_handle): New function.
7552
7553 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7554 (target_thread_info_to_thread_handle): Declare.
7555 * target.c (target_thread_info_to_thread_handle): New function.
7556 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7557 * target-delegates.c: Regenerate.
7558
7559 * linux-thread-db.c (class thread_db_target): Add method
7560 thread_info_to_thread_handle.
7561 (thread_db_target::thread_info_to_thread_handle): Define.
7562 * remote.c (class remote_target): Add new method
7563 thread_info_to_thread_handle.
7564 (remote_target::thread_info_to_thread_handle): Define.
7565
56be6ea8
PA
75662019-04-08 Pedro Alves <palves@redhat.com>
7567
7568 * common/common-exceptions.c (throw_exception): Don't create
7569 named object to throw; throw directly.
7570 (throw_it): Likewise. Don't initialize gdb_exception::message
7571 here, with new; pass FMT and AP to the ctor instead.
7572 * common/common-exceptions.h: Include <string>.
7573 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7574 const char *, va_list)): New ctor. Use std::make_shared.
7575 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7576 errors)): Delete.
7577 (gdb_exception_error::gdb_exception_error(enum errors, const char
7578 *, va_list)): New.
7579 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7580 Add assertion.
7581 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7582 errors)): Delete.
7583 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7584 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7585 Add assertion.
7586
eedc3f4f
TT
75872019-04-08 Tom Tromey <tom@tromey.com>
7588
7589 * valops.c (value_rtti_indirect_type): Replace throw_exception
7590 with throw.
7591 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7592 with throw.
7593 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7594 throw.
7595 * target.c (target_translate_tls_address): Replace throw_exception
7596 with throw.
7597 * stack.c (frame_apply_command_count): Replace throw_exception
7598 with throw.
7599 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7600 throw.
7601 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7602 with throw.
7603 * rs6000-tdep.c (rs6000_frame_cache)
7604 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7605 * remote.c: Replace throw_exception with throw.
7606 * record-full.c (record_full_message, record_full_wait_1)
7607 (record_full_restore): Replace throw_exception with throw.
7608 * record-btrace.c:
7609 (get_thread_current_frame_id, record_btrace_start_replaying)
7610 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7611 (cmd_record_btrace_start): Replace throw_exception with throw.
7612 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7613 throw.
7614 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7615 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7616 * linespec.c:
7617 (find_linespec_symbols): Replace throw_exception with throw.
7618 * infrun.c (displaced_step_prepare, resume): Replace
7619 throw_exception with throw.
7620 * infcmd.c (post_create_inferior): Replace throw_exception with
7621 throw.
7622 * inf-loop.c (inferior_event_handler): Replace throw_exception
7623 with throw.
7624 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7625 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7626 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7627 (get_prev_frame_always, get_frame_pc_if_available)
7628 (get_frame_address_in_block_if_available, get_frame_language):
7629 Replace throw_exception with throw.
7630 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7631 throw_exception with throw.
7632 * eval.c (fetch_subexp_value, evaluate_var_value)
7633 (evaluate_funcall, evaluate_subexp_standard): Replace
7634 throw_exception with throw.
7635 * dwarf2loc.c (call_site_find_chain)
7636 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7637 Replace throw_exception with throw.
7638 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7639 with throw.
7640 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7641 throw.
7642 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7643 * completer.c (complete_line_internal): Replace throw_exception
7644 with throw.
7645 * compile/compile-object-run.c (compile_object_run): Replace
7646 throw_exception with throw.
7647 * cli/cli-script.c (process_next_line): Replace throw_exception
7648 with throw.
7649 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7650 (btrace_enable, btrace_maint_update_pt_packets): Replace
7651 throw_exception with throw.
7652 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7653 throw_exception with throw.
7654 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7655 throw_exception with throw.
7656 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7657 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7658 * aarch64-tdep.c (aarch64_make_prologue_cache)
7659 (aarch64_make_stub_cache): Replace throw_exception with throw.
7660
26003a20
TT
76612019-04-08 Tom Tromey <tom@tromey.com>
7662
7663 * common/common-exceptions.c (throw_exception): Rename from
7664 throw_exception_cxx. Remove old copy. Make argument const.
7665 (throw_it): Create and throw exception objects directly.
7666 * common/common-exceptions.h (throw_exception): Make argument
7667 const.
7668 (struct gdb_exception_error): Add constructor.
7669 (struct gdb_exception_quit): Add constructor.
7670
d272eb37
TT
76712019-04-08 Tom Tromey <tom@tromey.com>
7672
7673 * common/common-exceptions.h (exception_rethrow): Don't declare.
7674 (TRY_SJLJ): Update comment.
7675 (TRY, CATCH, END_CATCH): Remove.
7676 * common/common-exceptions.c (exception_rethrow): Remove.
7677
230d2906
TT
76782019-04-08 Tom Tromey <tom@tromey.com>
7679
7680 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7681 Remove.
7682 (gdb_exception_error): Rename from
7683 gdb_exception_RETURN_MASK_ERROR.
7684 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7685 (gdb_quit_bad_alloc): Update.
7686 * aarch64-tdep.c: Update.
7687 * ada-lang.c: Update.
7688 * ada-typeprint.c: Update.
7689 * ada-valprint.c: Update.
7690 * amd64-tdep.c: Update.
7691 * arch-utils.c: Update.
7692 * break-catch-throw.c: Update.
7693 * breakpoint.c: Update.
7694 * btrace.c: Update.
7695 * c-varobj.c: Update.
7696 * cli/cli-cmds.c: Update.
7697 * cli/cli-interp.c: Update.
7698 * cli/cli-script.c: Update.
7699 * common/common-exceptions.c: Update.
7700 * common/new-op.c: Update.
7701 * common/selftest.c: Update.
7702 * compile/compile-c-symbols.c: Update.
7703 * compile/compile-cplus-symbols.c: Update.
7704 * compile/compile-object-load.c: Update.
7705 * compile/compile-object-run.c: Update.
7706 * completer.c: Update.
7707 * corelow.c: Update.
7708 * cp-abi.c: Update.
7709 * cp-support.c: Update.
7710 * cp-valprint.c: Update.
7711 * darwin-nat.c: Update.
7712 * disasm-selftests.c: Update.
7713 * dtrace-probe.c: Update.
7714 * dwarf-index-cache.c: Update.
7715 * dwarf-index-write.c: Update.
7716 * dwarf2-frame-tailcall.c: Update.
7717 * dwarf2-frame.c: Update.
7718 * dwarf2loc.c: Update.
7719 * dwarf2read.c: Update.
7720 * eval.c: Update.
7721 * event-loop.c: Update.
7722 * event-top.c: Update.
7723 * exec.c: Update.
7724 * f-valprint.c: Update.
7725 * fbsd-tdep.c: Update.
7726 * frame-unwind.c: Update.
7727 * frame.c: Update.
7728 * gdbtypes.c: Update.
7729 * gnu-v3-abi.c: Update.
7730 * guile/guile-internal.h: Update.
7731 * guile/scm-block.c: Update.
7732 * guile/scm-breakpoint.c: Update.
7733 * guile/scm-cmd.c: Update.
7734 * guile/scm-disasm.c: Update.
7735 * guile/scm-frame.c: Update.
7736 * guile/scm-lazy-string.c: Update.
7737 * guile/scm-math.c: Update.
7738 * guile/scm-param.c: Update.
7739 * guile/scm-ports.c: Update.
7740 * guile/scm-pretty-print.c: Update.
7741 * guile/scm-symbol.c: Update.
7742 * guile/scm-symtab.c: Update.
7743 * guile/scm-type.c: Update.
7744 * guile/scm-value.c: Update.
7745 * i386-linux-tdep.c: Update.
7746 * i386-tdep.c: Update.
7747 * inf-loop.c: Update.
7748 * infcall.c: Update.
7749 * infcmd.c: Update.
7750 * infrun.c: Update.
7751 * jit.c: Update.
7752 * language.c: Update.
7753 * linespec.c: Update.
7754 * linux-fork.c: Update.
7755 * linux-nat.c: Update.
7756 * linux-tdep.c: Update.
7757 * linux-thread-db.c: Update.
7758 * main.c: Update.
7759 * mi/mi-cmd-break.c: Update.
7760 * mi/mi-cmd-stack.c: Update.
7761 * mi/mi-interp.c: Update.
7762 * mi/mi-main.c: Update.
7763 * objc-lang.c: Update.
7764 * p-valprint.c: Update.
7765 * parse.c: Update.
7766 * ppc-linux-tdep.c: Update.
7767 * printcmd.c: Update.
7768 * python/py-arch.c: Update.
7769 * python/py-breakpoint.c: Update.
7770 * python/py-cmd.c: Update.
7771 * python/py-finishbreakpoint.c: Update.
7772 * python/py-frame.c: Update.
7773 * python/py-framefilter.c: Update.
7774 * python/py-gdb-readline.c: Update.
7775 * python/py-inferior.c: Update.
7776 * python/py-infthread.c: Update.
7777 * python/py-lazy-string.c: Update.
7778 * python/py-linetable.c: Update.
7779 * python/py-objfile.c: Update.
7780 * python/py-param.c: Update.
7781 * python/py-prettyprint.c: Update.
7782 * python/py-progspace.c: Update.
7783 * python/py-record-btrace.c: Update.
7784 * python/py-record.c: Update.
7785 * python/py-symbol.c: Update.
7786 * python/py-type.c: Update.
7787 * python/py-unwind.c: Update.
7788 * python/py-utils.c: Update.
7789 * python/py-value.c: Update.
7790 * python/python.c: Update.
7791 * record-btrace.c: Update.
7792 * record-full.c: Update.
7793 * remote-fileio.c: Update.
7794 * remote.c: Update.
7795 * riscv-tdep.c: Update.
7796 * rs6000-aix-tdep.c: Update.
7797 * rs6000-tdep.c: Update.
7798 * rust-exp.y: Update.
7799 * rust-lang.c: Update.
7800 * s390-tdep.c: Update.
7801 * selftest-arch.c: Update.
7802 * solib-dsbt.c: Update.
7803 * solib-frv.c: Update.
7804 * solib-spu.c: Update.
7805 * solib-svr4.c: Update.
7806 * solib.c: Update.
7807 * sparc64-linux-tdep.c: Update.
7808 * stack.c: Update.
7809 * symfile-mem.c: Update.
7810 * symmisc.c: Update.
7811 * target.c: Update.
7812 * thread.c: Update.
7813 * top.c: Update.
7814 * tracefile-tfile.c: Update.
7815 * tui/tui.c: Update.
7816 * typeprint.c: Update.
7817 * unittests/cli-utils-selftests.c: Update.
7818 * unittests/parse-connection-spec-selftests.c: Update.
7819 * valops.c: Update.
7820 * valprint.c: Update.
7821 * value.c: Update.
7822 * varobj.c: Update.
7823 * windows-nat.c: Update.
7824 * x86-linux-nat.c: Update.
7825 * xml-support.c: Update.
7826
a70b8144
TT
78272019-04-08 Tom Tromey <tom@tromey.com>
7828
7829 * xml-support.c: Use C++ exception handling.
7830 * x86-linux-nat.c: Use C++ exception handling.
7831 * windows-nat.c: Use C++ exception handling.
7832 * varobj.c: Use C++ exception handling.
7833 * value.c: Use C++ exception handling.
7834 * valprint.c: Use C++ exception handling.
7835 * valops.c: Use C++ exception handling.
7836 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7837 handling.
7838 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7839 * typeprint.c: Use C++ exception handling.
7840 * tui/tui.c: Use C++ exception handling.
7841 * tracefile-tfile.c: Use C++ exception handling.
7842 * top.c: Use C++ exception handling.
7843 * thread.c: Use C++ exception handling.
7844 * target.c: Use C++ exception handling.
7845 * symmisc.c: Use C++ exception handling.
7846 * symfile-mem.c: Use C++ exception handling.
7847 * stack.c: Use C++ exception handling.
7848 * sparc64-linux-tdep.c: Use C++ exception handling.
7849 * solib.c: Use C++ exception handling.
7850 * solib-svr4.c: Use C++ exception handling.
7851 * solib-spu.c: Use C++ exception handling.
7852 * solib-frv.c: Use C++ exception handling.
7853 * solib-dsbt.c: Use C++ exception handling.
7854 * selftest-arch.c: Use C++ exception handling.
7855 * s390-tdep.c: Use C++ exception handling.
7856 * rust-lang.c: Use C++ exception handling.
7857 * rust-exp.y: Use C++ exception handling.
7858 * rs6000-tdep.c: Use C++ exception handling.
7859 * rs6000-aix-tdep.c: Use C++ exception handling.
7860 * riscv-tdep.c: Use C++ exception handling.
7861 * remote.c: Use C++ exception handling.
7862 * remote-fileio.c: Use C++ exception handling.
7863 * record-full.c: Use C++ exception handling.
7864 * record-btrace.c: Use C++ exception handling.
7865 * python/python.c: Use C++ exception handling.
7866 * python/py-value.c: Use C++ exception handling.
7867 * python/py-utils.c: Use C++ exception handling.
7868 * python/py-unwind.c: Use C++ exception handling.
7869 * python/py-type.c: Use C++ exception handling.
7870 * python/py-symbol.c: Use C++ exception handling.
7871 * python/py-record.c: Use C++ exception handling.
7872 * python/py-record-btrace.c: Use C++ exception handling.
7873 * python/py-progspace.c: Use C++ exception handling.
7874 * python/py-prettyprint.c: Use C++ exception handling.
7875 * python/py-param.c: Use C++ exception handling.
7876 * python/py-objfile.c: Use C++ exception handling.
7877 * python/py-linetable.c: Use C++ exception handling.
7878 * python/py-lazy-string.c: Use C++ exception handling.
7879 * python/py-infthread.c: Use C++ exception handling.
7880 * python/py-inferior.c: Use C++ exception handling.
7881 * python/py-gdb-readline.c: Use C++ exception handling.
7882 * python/py-framefilter.c: Use C++ exception handling.
7883 * python/py-frame.c: Use C++ exception handling.
7884 * python/py-finishbreakpoint.c: Use C++ exception handling.
7885 * python/py-cmd.c: Use C++ exception handling.
7886 * python/py-breakpoint.c: Use C++ exception handling.
7887 * python/py-arch.c: Use C++ exception handling.
7888 * printcmd.c: Use C++ exception handling.
7889 * ppc-linux-tdep.c: Use C++ exception handling.
7890 * parse.c: Use C++ exception handling.
7891 * p-valprint.c: Use C++ exception handling.
7892 * objc-lang.c: Use C++ exception handling.
7893 * mi/mi-main.c: Use C++ exception handling.
7894 * mi/mi-interp.c: Use C++ exception handling.
7895 * mi/mi-cmd-stack.c: Use C++ exception handling.
7896 * mi/mi-cmd-break.c: Use C++ exception handling.
7897 * main.c: Use C++ exception handling.
7898 * linux-thread-db.c: Use C++ exception handling.
7899 * linux-tdep.c: Use C++ exception handling.
7900 * linux-nat.c: Use C++ exception handling.
7901 * linux-fork.c: Use C++ exception handling.
7902 * linespec.c: Use C++ exception handling.
7903 * language.c: Use C++ exception handling.
7904 * jit.c: Use C++ exception handling.
7905 * infrun.c: Use C++ exception handling.
7906 * infcmd.c: Use C++ exception handling.
7907 * infcall.c: Use C++ exception handling.
7908 * inf-loop.c: Use C++ exception handling.
7909 * i386-tdep.c: Use C++ exception handling.
7910 * i386-linux-tdep.c: Use C++ exception handling.
7911 * guile/scm-value.c: Use C++ exception handling.
7912 * guile/scm-type.c: Use C++ exception handling.
7913 * guile/scm-symtab.c: Use C++ exception handling.
7914 * guile/scm-symbol.c: Use C++ exception handling.
7915 * guile/scm-pretty-print.c: Use C++ exception handling.
7916 * guile/scm-ports.c: Use C++ exception handling.
7917 * guile/scm-param.c: Use C++ exception handling.
7918 * guile/scm-math.c: Use C++ exception handling.
7919 * guile/scm-lazy-string.c: Use C++ exception handling.
7920 * guile/scm-frame.c: Use C++ exception handling.
7921 * guile/scm-disasm.c: Use C++ exception handling.
7922 * guile/scm-cmd.c: Use C++ exception handling.
7923 * guile/scm-breakpoint.c: Use C++ exception handling.
7924 * guile/scm-block.c: Use C++ exception handling.
7925 * guile/guile-internal.h: Use C++ exception handling.
7926 * gnu-v3-abi.c: Use C++ exception handling.
7927 * gdbtypes.c: Use C++ exception handling.
7928 * frame.c: Use C++ exception handling.
7929 * frame-unwind.c: Use C++ exception handling.
7930 * fbsd-tdep.c: Use C++ exception handling.
7931 * f-valprint.c: Use C++ exception handling.
7932 * exec.c: Use C++ exception handling.
7933 * event-top.c: Use C++ exception handling.
7934 * event-loop.c: Use C++ exception handling.
7935 * eval.c: Use C++ exception handling.
7936 * dwarf2read.c: Use C++ exception handling.
7937 * dwarf2loc.c: Use C++ exception handling.
7938 * dwarf2-frame.c: Use C++ exception handling.
7939 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7940 * dwarf-index-write.c: Use C++ exception handling.
7941 * dwarf-index-cache.c: Use C++ exception handling.
7942 * dtrace-probe.c: Use C++ exception handling.
7943 * disasm-selftests.c: Use C++ exception handling.
7944 * darwin-nat.c: Use C++ exception handling.
7945 * cp-valprint.c: Use C++ exception handling.
7946 * cp-support.c: Use C++ exception handling.
7947 * cp-abi.c: Use C++ exception handling.
7948 * corelow.c: Use C++ exception handling.
7949 * completer.c: Use C++ exception handling.
7950 * compile/compile-object-run.c: Use C++ exception handling.
7951 * compile/compile-object-load.c: Use C++ exception handling.
7952 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7953 * compile/compile-c-symbols.c: Use C++ exception handling.
7954 * common/selftest.c: Use C++ exception handling.
7955 * common/new-op.c: Use C++ exception handling.
7956 * cli/cli-script.c: Use C++ exception handling.
7957 * cli/cli-interp.c: Use C++ exception handling.
7958 * cli/cli-cmds.c: Use C++ exception handling.
7959 * c-varobj.c: Use C++ exception handling.
7960 * btrace.c: Use C++ exception handling.
7961 * breakpoint.c: Use C++ exception handling.
7962 * break-catch-throw.c: Use C++ exception handling.
7963 * arch-utils.c: Use C++ exception handling.
7964 * amd64-tdep.c: Use C++ exception handling.
7965 * ada-valprint.c: Use C++ exception handling.
7966 * ada-typeprint.c: Use C++ exception handling.
7967 * ada-lang.c: Use C++ exception handling.
7968 * aarch64-tdep.c: Use C++ exception handling.
7969
3d6e9d23
TT
79702019-04-08 Tom Tromey <tom@tromey.com>
7971
7972 * xml-support.c (gdb_xml_parser::parse): Update.
7973 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7974 * value.c (show_convenience): Update.
7975 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7976 (test_parse_flags_qcs): Update.
7977 * thread.c (thr_try_catch_cmd): Update.
7978 * target.c (target_translate_tls_address): Update.
7979 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7980 (info_frame_command_core, frame_apply_command_count): Update.
7981 * rust-exp.y (rust_lex_exception_test): Update.
7982 * riscv-tdep.c (riscv_print_one_register_info): Update.
7983 * remote.c (remote_target::enable_btrace): Update.
7984 * record-btrace.c (record_btrace_enable_warn): Update.
7985 * python/py-utils.c (gdbpy_convert_exception): Update.
7986 * printcmd.c (do_one_display, print_variable_and_value): Update.
7987 * mi/mi-main.c (mi_print_exception): Update.
7988 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7989 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7990 * linux-nat.c (linux_nat_target::attach): Update.
7991 * linux-fork.c (class scoped_switch_fork_info): Update.
7992 * infrun.c (displaced_step_prepare): Update.
7993 * infcall.c (call_function_by_hand_dummy): Update.
7994 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7995 * gnu-v3-abi.c (print_one_vtable): Update.
7996 * frame.c (get_prev_frame_always): Update.
7997 * f-valprint.c (info_common_command_for_block): Update.
7998 * exec.c (try_open_exec_file): Update.
7999 * exceptions.c (print_exception, exception_print)
8000 (exception_fprintf, exception_print_same): Update.
8001 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8002 * dwarf-index-cache.c (index_cache::store)
8003 (index_cache::lookup_gdb_index): Update.
8004 * darwin-nat.c (maybe_cache_shell): Update.
8005 * cp-valprint.c (cp_print_value_fields): Update.
8006 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8007 (gcc_cplus_symbol_address): Update.
8008 * compile/compile-c-symbols.c (gcc_convert_symbol)
8009 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8010 * common/selftest.c: Update.
8011 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8012 a std::string.
8013 (exception_try_scope_entry, exception_try_scope_exit): Don't
8014 declare.
8015 (struct exception_try_scope): Remove.
8016 (TRY): Don't use exception_try_scope.
8017 (struct gdb_exception): Add constructor, operator=.
8018 <what>: New method.
8019 (struct gdb_exception_RETURN_MASK_ALL)
8020 (struct gdb_exception_RETURN_MASK_ERROR)
8021 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8022 (struct gdb_quit_bad_alloc): Update.
8023 * common/common-exceptions.c (exception_none): Change
8024 initializer.
8025 (struct catcher) <state, exception>: Initialize inline.
8026 <prev>: Remove member.
8027 (current_catcher): Remove.
8028 (catchers): New global.
8029 (exceptions_state_mc_init): Simplify.
8030 (catcher_pop): Remove.
8031 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8032 (try_scope_depth, exception_try_scope_entry)
8033 (exception_try_scope_exit): Remove.
8034 (throw_exception_sjlj): Update.
8035 (exception_messages, exception_messages_size): Remove.
8036 (throw_it): Simplify.
8037 (gdb_exception_sliced_copy): Remove.
8038 (throw_exception_cxx): Update.
8039 * cli/cli-script.c (script_from_file): Update.
8040 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8041 Update.
8042 * ada-valprint.c (ada_val_print): Update.
8043 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8044 (create_excep_cond_exprs): Update.
8045
c5c10118
TT
80462019-04-08 Tom Tromey <tom@tromey.com>
8047
8048 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8049 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8050 (TRY, CATCH, END_CATCH): Remove some definitions.
8051 * common/common-exceptions.c: Don't use GDB_XCPT.
8052 (catcher_list_size): Remove.
8053 (throw_exception, throw_it): Simplify.
8054
4de283e4
TT
80552019-04-05 Tom Tromey <tom@tromey.com>
8056
8057 Revert the header-sorting patch.
8058 * ft32-tdep.c: Revert.
8059 * frv-tdep.c: Revert.
8060 * frv-linux-tdep.c: Revert.
8061 * frame.c: Revert.
8062 * frame-unwind.c: Revert.
8063 * frame-base.c: Revert.
8064 * fork-child.c: Revert.
8065 * findvar.c: Revert.
8066 * findcmd.c: Revert.
8067 * filesystem.c: Revert.
8068 * filename-seen-cache.h: Revert.
8069 * filename-seen-cache.c: Revert.
8070 * fbsd-tdep.c: Revert.
8071 * fbsd-nat.h: Revert.
8072 * fbsd-nat.c: Revert.
8073 * f-valprint.c: Revert.
8074 * f-typeprint.c: Revert.
8075 * f-lang.c: Revert.
8076 * extension.h: Revert.
8077 * extension.c: Revert.
8078 * extension-priv.h: Revert.
8079 * expprint.c: Revert.
8080 * exec.h: Revert.
8081 * exec.c: Revert.
8082 * exceptions.c: Revert.
8083 * event-top.c: Revert.
8084 * event-loop.c: Revert.
8085 * eval.c: Revert.
8086 * elfread.c: Revert.
8087 * dwarf2read.h: Revert.
8088 * dwarf2read.c: Revert.
8089 * dwarf2loc.c: Revert.
8090 * dwarf2expr.h: Revert.
8091 * dwarf2expr.c: Revert.
8092 * dwarf2-frame.c: Revert.
8093 * dwarf2-frame-tailcall.c: Revert.
8094 * dwarf-index-write.h: Revert.
8095 * dwarf-index-write.c: Revert.
8096 * dwarf-index-common.c: Revert.
8097 * dwarf-index-cache.h: Revert.
8098 * dwarf-index-cache.c: Revert.
8099 * dummy-frame.c: Revert.
8100 * dtrace-probe.c: Revert.
8101 * disasm.h: Revert.
8102 * disasm.c: Revert.
8103 * disasm-selftests.c: Revert.
8104 * dictionary.c: Revert.
8105 * dicos-tdep.c: Revert.
8106 * demangle.c: Revert.
8107 * dcache.h: Revert.
8108 * dcache.c: Revert.
8109 * darwin-nat.h: Revert.
8110 * darwin-nat.c: Revert.
8111 * darwin-nat-info.c: Revert.
8112 * d-valprint.c: Revert.
8113 * d-namespace.c: Revert.
8114 * d-lang.c: Revert.
8115 * ctf.c: Revert.
8116 * csky-tdep.c: Revert.
8117 * csky-linux-tdep.c: Revert.
8118 * cris-tdep.c: Revert.
8119 * cris-linux-tdep.c: Revert.
8120 * cp-valprint.c: Revert.
8121 * cp-support.c: Revert.
8122 * cp-namespace.c: Revert.
8123 * cp-abi.c: Revert.
8124 * corelow.c: Revert.
8125 * corefile.c: Revert.
8126 * continuations.c: Revert.
8127 * completer.h: Revert.
8128 * completer.c: Revert.
8129 * complaints.c: Revert.
8130 * coffread.c: Revert.
8131 * coff-pe-read.c: Revert.
8132 * cli-out.h: Revert.
8133 * cli-out.c: Revert.
8134 * charset.c: Revert.
8135 * c-varobj.c: Revert.
8136 * c-valprint.c: Revert.
8137 * c-typeprint.c: Revert.
8138 * c-lang.c: Revert.
8139 * buildsym.c: Revert.
8140 * buildsym-legacy.c: Revert.
8141 * build-id.h: Revert.
8142 * build-id.c: Revert.
8143 * btrace.c: Revert.
8144 * bsd-uthread.c: Revert.
8145 * breakpoint.h: Revert.
8146 * breakpoint.c: Revert.
8147 * break-catch-throw.c: Revert.
8148 * break-catch-syscall.c: Revert.
8149 * break-catch-sig.c: Revert.
8150 * blockframe.c: Revert.
8151 * block.c: Revert.
8152 * bfin-tdep.c: Revert.
8153 * bfin-linux-tdep.c: Revert.
8154 * bfd-target.c: Revert.
8155 * bcache.c: Revert.
8156 * ax-general.c: Revert.
8157 * ax-gdb.h: Revert.
8158 * ax-gdb.c: Revert.
8159 * avr-tdep.c: Revert.
8160 * auxv.c: Revert.
8161 * auto-load.c: Revert.
8162 * arm-wince-tdep.c: Revert.
8163 * arm-tdep.c: Revert.
8164 * arm-symbian-tdep.c: Revert.
8165 * arm-pikeos-tdep.c: Revert.
8166 * arm-obsd-tdep.c: Revert.
8167 * arm-nbsd-tdep.c: Revert.
8168 * arm-nbsd-nat.c: Revert.
8169 * arm-linux-tdep.c: Revert.
8170 * arm-linux-nat.c: Revert.
8171 * arm-fbsd-tdep.c: Revert.
8172 * arm-fbsd-nat.c: Revert.
8173 * arm-bsd-tdep.c: Revert.
8174 * arch-utils.c: Revert.
8175 * arc-tdep.c: Revert.
8176 * arc-newlib-tdep.c: Revert.
8177 * annotate.h: Revert.
8178 * annotate.c: Revert.
8179 * amd64-windows-tdep.c: Revert.
8180 * amd64-windows-nat.c: Revert.
8181 * amd64-tdep.c: Revert.
8182 * amd64-sol2-tdep.c: Revert.
8183 * amd64-obsd-tdep.c: Revert.
8184 * amd64-obsd-nat.c: Revert.
8185 * amd64-nbsd-tdep.c: Revert.
8186 * amd64-nbsd-nat.c: Revert.
8187 * amd64-nat.c: Revert.
8188 * amd64-linux-tdep.c: Revert.
8189 * amd64-linux-nat.c: Revert.
8190 * amd64-fbsd-tdep.c: Revert.
8191 * amd64-fbsd-nat.c: Revert.
8192 * amd64-dicos-tdep.c: Revert.
8193 * amd64-darwin-tdep.c: Revert.
8194 * amd64-bsd-nat.c: Revert.
8195 * alpha-tdep.c: Revert.
8196 * alpha-obsd-tdep.c: Revert.
8197 * alpha-nbsd-tdep.c: Revert.
8198 * alpha-mdebug-tdep.c: Revert.
8199 * alpha-linux-tdep.c: Revert.
8200 * alpha-linux-nat.c: Revert.
8201 * alpha-bsd-tdep.c: Revert.
8202 * alpha-bsd-nat.c: Revert.
8203 * aix-thread.c: Revert.
8204 * agent.c: Revert.
8205 * addrmap.c: Revert.
8206 * ada-varobj.c: Revert.
8207 * ada-valprint.c: Revert.
8208 * ada-typeprint.c: Revert.
8209 * ada-tasks.c: Revert.
8210 * ada-lang.c: Revert.
8211 * aarch64-tdep.c: Revert.
8212 * aarch64-ravenscar-thread.c: Revert.
8213 * aarch64-newlib-tdep.c: Revert.
8214 * aarch64-linux-tdep.c: Revert.
8215 * aarch64-linux-nat.c: Revert.
8216 * aarch64-fbsd-tdep.c: Revert.
8217 * aarch64-fbsd-nat.c: Revert.
8218 * aarch32-linux-nat.c: Revert.
8219
d55e5aa6
TT
82202019-04-05 Tom Tromey <tom@tromey.com>
8221
8222 * ft32-tdep.c: Sort headers.
8223 * frv-tdep.c: Sort headers.
8224 * frv-linux-tdep.c: Sort headers.
8225 * frame.c: Sort headers.
8226 * frame-unwind.c: Sort headers.
8227 * frame-base.c: Sort headers.
8228 * fork-child.c: Sort headers.
8229 * findvar.c: Sort headers.
8230 * findcmd.c: Sort headers.
8231 * filesystem.c: Sort headers.
8232 * filename-seen-cache.h: Sort headers.
8233 * filename-seen-cache.c: Sort headers.
8234 * fbsd-tdep.c: Sort headers.
8235 * fbsd-nat.h: Sort headers.
8236 * fbsd-nat.c: Sort headers.
8237 * f-valprint.c: Sort headers.
8238 * f-typeprint.c: Sort headers.
8239 * f-lang.c: Sort headers.
8240 * extension.h: Sort headers.
8241 * extension.c: Sort headers.
8242 * extension-priv.h: Sort headers.
8243 * expprint.c: Sort headers.
8244 * exec.h: Sort headers.
8245 * exec.c: Sort headers.
8246 * exceptions.c: Sort headers.
8247 * event-top.c: Sort headers.
8248 * event-loop.c: Sort headers.
8249 * eval.c: Sort headers.
8250 * elfread.c: Sort headers.
8251 * dwarf2read.h: Sort headers.
8252 * dwarf2read.c: Sort headers.
8253 * dwarf2loc.c: Sort headers.
8254 * dwarf2expr.h: Sort headers.
8255 * dwarf2expr.c: Sort headers.
8256 * dwarf2-frame.c: Sort headers.
8257 * dwarf2-frame-tailcall.c: Sort headers.
8258 * dwarf-index-write.h: Sort headers.
8259 * dwarf-index-write.c: Sort headers.
8260 * dwarf-index-common.c: Sort headers.
8261 * dwarf-index-cache.h: Sort headers.
8262 * dwarf-index-cache.c: Sort headers.
8263 * dummy-frame.c: Sort headers.
8264 * dtrace-probe.c: Sort headers.
8265 * disasm.h: Sort headers.
8266 * disasm.c: Sort headers.
8267 * disasm-selftests.c: Sort headers.
8268 * dictionary.c: Sort headers.
8269 * dicos-tdep.c: Sort headers.
8270 * demangle.c: Sort headers.
8271 * dcache.h: Sort headers.
8272 * dcache.c: Sort headers.
8273 * darwin-nat.h: Sort headers.
8274 * darwin-nat.c: Sort headers.
8275 * darwin-nat-info.c: Sort headers.
8276 * d-valprint.c: Sort headers.
8277 * d-namespace.c: Sort headers.
8278 * d-lang.c: Sort headers.
8279 * ctf.c: Sort headers.
8280 * csky-tdep.c: Sort headers.
8281 * csky-linux-tdep.c: Sort headers.
8282 * cris-tdep.c: Sort headers.
8283 * cris-linux-tdep.c: Sort headers.
8284 * cp-valprint.c: Sort headers.
8285 * cp-support.c: Sort headers.
8286 * cp-namespace.c: Sort headers.
8287 * cp-abi.c: Sort headers.
8288 * corelow.c: Sort headers.
8289 * corefile.c: Sort headers.
8290 * continuations.c: Sort headers.
8291 * completer.h: Sort headers.
8292 * completer.c: Sort headers.
8293 * complaints.c: Sort headers.
8294 * coffread.c: Sort headers.
8295 * coff-pe-read.c: Sort headers.
8296 * cli-out.h: Sort headers.
8297 * cli-out.c: Sort headers.
8298 * charset.c: Sort headers.
8299 * c-varobj.c: Sort headers.
8300 * c-valprint.c: Sort headers.
8301 * c-typeprint.c: Sort headers.
8302 * c-lang.c: Sort headers.
8303 * buildsym.c: Sort headers.
8304 * buildsym-legacy.c: Sort headers.
8305 * build-id.h: Sort headers.
8306 * build-id.c: Sort headers.
8307 * btrace.c: Sort headers.
8308 * bsd-uthread.c: Sort headers.
8309 * breakpoint.h: Sort headers.
8310 * breakpoint.c: Sort headers.
8311 * break-catch-throw.c: Sort headers.
8312 * break-catch-syscall.c: Sort headers.
8313 * break-catch-sig.c: Sort headers.
8314 * blockframe.c: Sort headers.
8315 * block.c: Sort headers.
8316 * bfin-tdep.c: Sort headers.
8317 * bfin-linux-tdep.c: Sort headers.
8318 * bfd-target.c: Sort headers.
8319 * bcache.c: Sort headers.
8320 * ax-general.c: Sort headers.
8321 * ax-gdb.h: Sort headers.
8322 * ax-gdb.c: Sort headers.
8323 * avr-tdep.c: Sort headers.
8324 * auxv.c: Sort headers.
8325 * auto-load.c: Sort headers.
8326 * arm-wince-tdep.c: Sort headers.
8327 * arm-tdep.c: Sort headers.
8328 * arm-symbian-tdep.c: Sort headers.
8329 * arm-pikeos-tdep.c: Sort headers.
8330 * arm-obsd-tdep.c: Sort headers.
8331 * arm-nbsd-tdep.c: Sort headers.
8332 * arm-nbsd-nat.c: Sort headers.
8333 * arm-linux-tdep.c: Sort headers.
8334 * arm-linux-nat.c: Sort headers.
8335 * arm-fbsd-tdep.c: Sort headers.
8336 * arm-fbsd-nat.c: Sort headers.
8337 * arm-bsd-tdep.c: Sort headers.
8338 * arch-utils.c: Sort headers.
8339 * arc-tdep.c: Sort headers.
8340 * arc-newlib-tdep.c: Sort headers.
8341 * annotate.h: Sort headers.
8342 * annotate.c: Sort headers.
8343 * amd64-windows-tdep.c: Sort headers.
8344 * amd64-windows-nat.c: Sort headers.
8345 * amd64-tdep.c: Sort headers.
8346 * amd64-sol2-tdep.c: Sort headers.
8347 * amd64-obsd-tdep.c: Sort headers.
8348 * amd64-obsd-nat.c: Sort headers.
8349 * amd64-nbsd-tdep.c: Sort headers.
8350 * amd64-nbsd-nat.c: Sort headers.
8351 * amd64-nat.c: Sort headers.
8352 * amd64-linux-tdep.c: Sort headers.
8353 * amd64-linux-nat.c: Sort headers.
8354 * amd64-fbsd-tdep.c: Sort headers.
8355 * amd64-fbsd-nat.c: Sort headers.
8356 * amd64-dicos-tdep.c: Sort headers.
8357 * amd64-darwin-tdep.c: Sort headers.
8358 * amd64-bsd-nat.c: Sort headers.
8359 * alpha-tdep.c: Sort headers.
8360 * alpha-obsd-tdep.c: Sort headers.
8361 * alpha-nbsd-tdep.c: Sort headers.
8362 * alpha-mdebug-tdep.c: Sort headers.
8363 * alpha-linux-tdep.c: Sort headers.
8364 * alpha-linux-nat.c: Sort headers.
8365 * alpha-bsd-tdep.c: Sort headers.
8366 * alpha-bsd-nat.c: Sort headers.
8367 * aix-thread.c: Sort headers.
8368 * agent.c: Sort headers.
8369 * addrmap.c: Sort headers.
8370 * ada-varobj.c: Sort headers.
8371 * ada-valprint.c: Sort headers.
8372 * ada-typeprint.c: Sort headers.
8373 * ada-tasks.c: Sort headers.
8374 * ada-lang.c: Sort headers.
8375 * aarch64-tdep.c: Sort headers.
8376 * aarch64-ravenscar-thread.c: Sort headers.
8377 * aarch64-newlib-tdep.c: Sort headers.
8378 * aarch64-linux-tdep.c: Sort headers.
8379 * aarch64-linux-nat.c: Sort headers.
8380 * aarch64-fbsd-tdep.c: Sort headers.
8381 * aarch64-fbsd-nat.c: Sort headers.
8382 * aarch32-linux-nat.c: Sort headers.
8383
699bd4cf
TT
83842019-04-04 Tom Tromey <tom@tromey.com>
8385
8386 * varobj.c (varobj_create): Update.
8387 * rust-exp.y (struct rust_parser) <update_innermost_block,
8388 lookup_symbol>: New methods.
8389 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8390 Rename.
8391 (rust_parser::rust_lookup_type)
8392 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8393 * printcmd.c (display_command, do_one_display): Update.
8394 * parser-defs.h (struct parser_state) <parser_state>: Add
8395 "tracker" parameter.
8396 (block_tracker): New member.
8397 (class innermost_block_tracker) <innermost_block_tracker>: Add
8398 "types" parameter.
8399 <reset>: Remove method.
8400 (innermost_block): Don't declare.
8401 (null_post_parser): Update.
8402 * parse.c (innermost_block): Remove global.
8403 (write_dollar_variable): Update.
8404 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8405 Remove "tracker_types" parameter.
8406 (parse_expression): Add "tracker" parameter.
8407 (parse_expression_for_completion): Update.
8408 (null_post_parser): Add "tracker" parameter.
8409 * p-exp.y: Update rules.
8410 * m2-exp.y: Update rules.
8411 * language.h (struct language_defn) <la_post_parser>: Add
8412 "tracker" parameter.
8413 * go-exp.y: Update rules.
8414 * f-exp.y: Update rules.
8415 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8416 parameter.
8417 * d-exp.y: Update rules.
8418 * c-exp.y: Update rules.
8419 * breakpoint.c (set_breakpoint_condition): Create an
8420 innermost_block_tracker.
8421 (watch_command_1): Likewise.
8422 * ada-lang.c (resolve): Add "tracker" parameter.
8423 (resolve_subexp): Likewise.
8424 * ada-exp.y (write_var_from_sym): Update.
8425
dac43e32
TT
84262019-04-04 Tom Tromey <tom@tromey.com>
8427
8428 * type-stack.h: New file.
8429 * type-stack.c: New file.
8430 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8431 type-stack.h.
8432 (insert_into_type_stack, insert_type, push_type, push_type_int)
8433 (insert_type_address_space, pop_type, pop_type_int)
8434 (pop_typelist, pop_type_stack, append_type_stack)
8435 (push_type_stack, get_type_stack, push_typelist)
8436 (follow_type_instance_flags, follow_types): Don't declare.
8437 * parse.c (type_stack): Remove global.
8438 (parse_exp_in_context): Update.
8439 (insert_into_type_stack, insert_type, push_type, push_type_int)
8440 (insert_type_address_space, pop_type, pop_type_int)
8441 (pop_typelist, pop_type_stack, append_type_stack)
8442 (push_type_stack, get_type_stack, push_typelist)
8443 (follow_type_instance_flags, follow_types): Remove (moved to
8444 type-stack.c).
8445 * f-exp.y (type_stack): New global.
8446 Update rules.
8447 (push_kind_type, f_parse): Update.
8448 * d-exp.y (type_stack): New global.
8449 Update rules.
8450 (d_parse): Update.
8451 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8452 Update rules.
8453 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8454 (HFILES_NO_SRCDIR): Add type-stack.h.
8455
2a612529
TT
84562019-04-04 Tom Tromey <tom@tromey.com>
8457
8458 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8459 (rust_parser::convert_ast_to_expression, rust_parse)
8460 (rust_lex_test_completion, rust_lex_tests): Update.
8461 * parser-defs.h (struct expr_completion_state): New.
8462 (struct parser_state) <parser_state>: Add completion parameter.
8463 <mark_struct_expression, mark_completion_tag>: New methods.
8464 <parse_completion, m_completion_state>: New members.
8465 (prefixify_expression, null_post_parser): Update.
8466 (mark_struct_expression, mark_completion_tag): Don't declare.
8467 * parse.c (parse_completion, expout_last_struct)
8468 (expout_tag_completion_type, expout_completion_name): Remove
8469 globals.
8470 (parser_state::mark_struct_expression)
8471 (parser_state::mark_completion_tag): Now methods.
8472 (prefixify_expression): Add last_struct parameter.
8473 (prefixify_subexp): Likewise.
8474 (parse_exp_1): Update.
8475 (parse_exp_in_context): Add cstate parameter. Update.
8476 (parse_expression_for_completion): Create an
8477 expr_completion_state.
8478 (null_post_parser): Add "completion" parameter.
8479 * p-exp.y: Update rules.
8480 (yylex): Update.
8481 * language.h (struct language_defn) <la_post_parser>: Add
8482 "completing" parameter.
8483 * go-exp.y: Update rules.
8484 (lex_one_token): Update.
8485 * expression.h (parse_completion): Don't declare.
8486 * d-exp.y: Update rules.
8487 (lex_one_token): Update rules.
8488 * c-exp.y: Update rules.
8489 (lex_one_token): Update.
8490 * ada-lang.c (resolve): Add "parse_completion" parameter.
8491 (resolve_subexp): Likewise.
8492 (ada_resolve_function): Likewise.
8493
43476f0b
TT
84942019-04-04 Tom Tromey <tom@tromey.com>
8495
8496 * parser-defs.h (struct parser_state) <start_arglist,
8497 end_arglist>: New methods.
8498 <arglist_len, m_funcall_chain>: New members.
8499 (arglist_len, start_arglist, end_arglist): Don't declare.
8500 * parse.c (arglist_len, funcall_chain): Remove global.
8501 (start_arglist, end_arglist): Remove functions.
8502 (parse_exp_in_context): Update.
8503 * p-exp.y: Update rules.
8504 * m2-exp.y: Update rules.
8505 * go-exp.y: Update rules.
8506 * f-exp.y: Update rules.
8507 * d-exp.y: Update rules.
8508 * c-exp.y: Update rules.
8509
5776fca3
TT
85102019-04-04 Tom Tromey <tom@tromey.com>
8511
8512 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8513 lex_operator, push_back>: New methods.
8514 Update all rules.
8515 (rust_parser::lex_hex, lex_escape): Rename and update.
8516 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8517 (rust_parser::lex_operator): Rename and update.
8518 (rust_parser::lex_number, rustyylex, rustyyerror)
8519 (rust_lex_test_init, rust_lex_test_sequence)
8520 (rust_lex_test_push_back, rust_lex_tests): Update.
8521 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8522 parameter.
8523 <lexptr, prev_lexptr>: New members.
8524 (lexptr, prev_lexptr): Don't declare.
8525 * parse.c (lexptr, prev_lexptr): Remove globals.
8526 (parse_exp_in_context): Update.
8527 * p-exp.y (yylex, yyerror): Update.
8528 * m2-exp.y (parse_number, yylex, yyerror): Update.
8529 * go-exp.y (lex_one_token, yyerror): Update.
8530 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8531 * d-exp.y (lex_one_token, yyerror): Update.
8532 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8533 (lex_one_token, yyerror): Update.
8534 * ada-lex.l (YY_INPUT): Update.
8535 (rewind_to_char): Update.
8536 * ada-exp.y (yyerror): Update.
8537
8621b685
TT
85382019-04-04 Tom Tromey <tom@tromey.com>
8539
8540 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8541 * parser-defs.h (struct parser_state) <parser_state>: Add new
8542 parameter.
8543 <comma_terminates>: New member.
8544 (comma_terminates): Don't declare global.
8545 * parse.c (comma_terminates): Remove global.
8546 (parse_exp_in_context): Update.
8547 * p-exp.y (yylex): Update.
8548 * m2-exp.y (yylex): Update.
8549 * go-exp.y (lex_one_token): Update.
8550 * f-exp.y (yylex): Update.
8551 * d-exp.y (lex_one_token): Update.
8552 * c-exp.y (lex_one_token): Update.
8553 * ada-lex.l: Update.
8554
28aaf3fd
TT
85552019-04-04 Tom Tromey <tom@tromey.com>
8556
8557 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8558 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8559 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8560 * parser-defs.h (paren_depth): Don't declare.
8561 * parse.c (paren_depth): Remove global.
8562 (parse_exp_in_context): Update.
8563 * p-exp.y (paren_depth): New global.
8564 (pascal_parse): Initialize it.
8565 * m2-exp.y (paren_depth): New global.
8566 (m2_parse): Initialize it.
8567 * go-exp.y (paren_depth): New global.
8568 (go_parse): Initialize it.
8569 * f-exp.y (paren_depth): New global.
8570 (f_parse): Initialize it.
8571 * d-exp.y (paren_depth): New global.
8572 (d_parse): Initialize it.
8573 * c-exp.y (paren_depth): New global.
8574 (c_parse): Initialize it.
8575 * ada-lex.l (paren_depth): New global.
8576 (lexer_init): Initialize it.
8577
1e58a4a4
TT
85782019-04-04 Tom Tromey <tom@tromey.com>
8579
8580 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8581 (rust_parser::convert_ast_to_type)
8582 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8583 * parser-defs.h (struct parser_state) <parser_state>: Add
8584 parameters. Initialize new members.
8585 <expression_context_block, expression_context_pc>: New members.
8586 * parse.c (expression_context_block, expression_context_pc):
8587 Remove globals.
8588 (parse_exp_in_context): Update.
8589 * p-exp.y: Update all rules.
8590 (yylex): Update.
8591 * m2-exp.y: Update all rules.
8592 (yylex): Update.
8593 * go-exp.y (yylex): Update.
8594 * f-exp.y (yylex): Update.
8595 * d-exp.y: Update all rules.
8596 (yylex): Update.
8597 * c-exp.y: Update all rules.
8598 (lex_one_token, classify_name, yylex, c_parse): Update.
8599 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8600
37eedb39
TT
86012019-04-04 Tom Tromey <tom@tromey.com>
8602
8603 * gdbarch.h, gdbarch.c: Rebuild.
8604 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8605 * stap-probe.h:
8606 (struct stap_parse_info): Replace "parser_state" with
8607 "expr_builder".
8608 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8609 (parser_state): New class.
8610 * parse.c (expr_builder): Rename.
8611 (expr_builder::release): Rename.
8612 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8613 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8614 (write_exp_elt_longcst, write_exp_elt_floatcst)
8615 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8616 (write_exp_string_vector, write_exp_bitstring)
8617 (write_exp_msymbol, mark_struct_expression)
8618 (write_dollar_variable)
8619 (insert_type_address_space, increase_expout_size): Replace
8620 "parser_state" with "expr_builder".
8621 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8622 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8623 "parser_state" with "expr_builder".
8624
73923d7e
TT
86252019-04-04 Tom Tromey <tom@tromey.com>
8626
8627 * rust-exp.y: Replace "parse_language" with method call.
8628 * p-exp.y:
8629 (yylex): Replace "parse_language" with method call.
8630 * m2-exp.y:
8631 (yylex): Replace "parse_language" with method call.
8632 * go-exp.y (classify_name): Replace "parse_language" with method
8633 call.
8634 * f-exp.y (yylex): Replace "parse_language" with method call.
8635 * d-exp.y (lex_one_token): Replace "parse_language" with method
8636 call.
8637 * c-exp.y:
8638 (lex_one_token, classify_name, yylex): Replace "parse_language"
8639 with method call.
8640 * ada-exp.y (find_primitive_type, type_char)
8641 (type_system_address): Replace "parse_language" with method call.
8642
fa9f5be6
TT
86432019-04-04 Tom Tromey <tom@tromey.com>
8644
8645 * rust-exp.y: Replace "parse_gdbarch" with method call.
8646 * parse.c (write_dollar_variable, insert_type_address_space):
8647 Replace "parse_gdbarch" with method call.
8648 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8649 call.
8650 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8651 call.
8652 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8653 "parse_gdbarch" with method call.
8654 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8655 with method call.
8656 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8657 "parse_gdbarch" with method call.
8658 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8659 "parse_gdbarch" with method call.
8660 * c-exp.y (parse_type, parse_number, classify_name): Replace
8661 "parse_gdbarch" with method call.
8662 * ada-lex.l: Replace "parse_gdbarch" with method call.
8663 * ada-exp.y (parse_type, find_primitive_type, type_char)
8664 (type_system_address): Replace "parse_gdbarch" with method call.
8665
1201a264
TT
86662019-04-04 Tom Tromey <tom@tromey.com>
8667
8668 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8669 * stap-probe.c (stap_parse_argument): Update.
8670 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8671 initial_size parameter.
8672 * rust-exp.y (rust_lex_tests): Update.
8673 * parse.c (parser_state): Update.
8674 (parse_exp_in_context): Update.
8675 * parser-defs.h (struct parser_state) <parser_state>: Remove
8676 "initial_size" parameter.
8677
e3980ce2
TT
86782019-04-04 Tom Tromey <tom@tromey.com>
8679
8680 * parser-defs.h (increase_expout_size): Don't declare.
8681 * parse.c (increase_expout_size): Now static.
8682
e9f8e3f1
TS
86832019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8684
8685 * gnu-nat.c (gnu_nat_target::wait): Fix
8686 target_waitstatus_to_string call.
8687
d7df6549
AB
86882019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8689
8690 * eval.c (evaluate_subexp_standard): Handle internal functions
8691 during Fortran function call handling.
8692
8bdc1658
AB
86932019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8694
8695 * NEWS: Mention new internal functions.
8696 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8697 (read_base_type): Use dwarf2_init_complex_target_type.
8698 * value.c (creal_internal_fn): New function.
8699 (cimag_internal_fn): New function.
8700 (_initialize_values): Register new internal functions.
8701
c29705b7
PW
87022019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8703
8704 * infrun.c (stop_all_threads): If debug_infrun, always
8705 trace the wait status after wait_one, using
8706 target_waitstatus_to_string and target_pid_to_str.
8707 (handle_inferior_event): Replace various trace of
8708 wait status kind by a single trace.
8709 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8710 wait status kind image by target_waitstatus_to_string.
8711 * target/waitstatus.c (target_waitstatus_to_string): Fix
8712 obsolete comment.
8713
05caa1d2
TT
87142019-04-01 Tom Tromey <tromey@adacore.com>
8715
8716 PR symtab/23331:
8717 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8718
9d1447e0
SDJ
87192019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8720 Pedro Alves <palves@redhat.com>
8721
8722 * top.c (quit_force): Call 'finalize_values'.
8723 * value.c (finalize_values): New function.
8724 * value.h (finalize_values): Declare.
8725
7734102d
EZ
87262019-03-30 Eli Zaretskii <eliz@gnu.org>
8727
8728 * NEWS: Announce $_gdb_major and $_gdb_minor.
8729
8730 * top.c (init_gdb_version_vars): New function.
8731 (gdb_init): Call init_gdb_version_vars.
8732
188e1fa9
TT
87332019-03-29 Tom Tromey <tromey@adacore.com>
8734
8735 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8736 help text. Remove dead code.
8737
2880242d
KS
87382019-03-29 Keith Seitz <keiths@redhat.com>
8739
8740 From Siddhesh Poyarekar:
8741 * f-lang.h (f77_get_upperbound): Return LONGEST.
8742 (f77_get_lowerbound): Likewise.
8743 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8744 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8745 print them.
8746 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8747 plongest to format print it.
8748 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8749 (f77_get_upperbound): Likewise.
8750 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8751 LOWER_BOUND to LONGEST.
8752 (f77_create_arrayprint_offset_tbl): Likewise.
8753
cc1defb1
KS
87542019-03-29 Keith Seitz <keiths@redhat.com>
8755
8756 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8757 %s/pulongest for TYPE_LENGTH instead of %d in format
8758 strings.
8759 * ada-typerint.c (ada_print_type): Likewise.
8760 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8761 * compile/compile-c-support.c (generate_register_struct): Likewise.
8762 * gdbtypes.c (recursive_dump_type): Likewise.
8763 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8764 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8765 instead of %d in format strings.
8766 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8767 to std::min to ULONGEST.
8768 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8769 instead of %d in format strings.
8770 * tracepoint.c (info_scope_command): Likewise.
8771 * typeprint.c (print_offset_data::update)
8772 (print_offset_data::finish): Likewise.
8773 * xtensa-tdep.c (xtensa_store_return_value)
8774 (xtensa_push_dummy_call): Likewise.
8775
e432ccf1
JT
87762019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8777
8778 * windows-nat.c (display_selector): Fixed format specifications
8779 for 64-bit Cygwin.
8780
65d2b333
PW
87812019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8782
8783 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8784
f489207e
SL
87852019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8786
8787 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8788 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8789 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8790 (nios2_linux_init_abi): Install it.
8791
bffa1015
AH
87922019-03-28 Alan Hayward <alan.hayward@arm.com>
8793
8794 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8795
fc96163a
AH
87962019-03-28 Alan Hayward <alan.hayward@arm.com>
8797
8798 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8799
20dc7e9b
PW
88002019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8801 Tom Tromey <tromey@adacore.com>
8802
8803 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8804
7f5331a8
JB
88052019-03-26 Joel Brobecker <brobecker@adacore.com>
8806
8807 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8808 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8809 method to compute the bounds of range types. Also print "[evaluated]"
8810 if the bounds' values come from a dynamic evaluation.
8811
18c77628
AB
88122019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8813
8814 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8815 whitespace when pretty printing is on.
8816
53c973f2
AH
88172019-03-26 Alan Hayward <alan.hayward@arm.com>
8818
e79be6e5 8819 * ppc-linux-nat.c: Add include.
53c973f2 8820
d851aa71
AH
88212019-03-26 Alan Hayward <alan.hayward@arm.com>
8822
e79be6e5 8823 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 8824
2fe7bab7
AH
88252019-03-26 Alan Hayward <alan.hayward@arm.com>
8826
e79be6e5 8827 * arm-linux-nat.c: Add include.
2fe7bab7 8828
068ef30e
SM
88292019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8830
8831 * source-cache.c (source_cache::get_source_lines): Re-read
8832 fullname after calling open_source_file.
8833
81a24d04
JB
88342019-03-25 John Baldwin <jhb@FreeBSD.org>
8835
8836 * NEWS: Mention TLS support for FreeBSD.
8837
79e7ae11
TT
88382019-03-25 Tom Tromey <tromey@adacore.com>
8839
8840 * minsyms.c (BUNCH_SIZE): Update comment.
8841 (~minimal_symbol_reader): Remove old comment.
8842 (compact_minimal_symbols): Update comment.
8843 (minimal_symbol_reader::install): Remove old comment. Update
8844 other comments.
8845
d45963c2
AH
88462019-03-25 Alan Hayward <alan.hayward@arm.com>
8847
8848 * s390-linux-nat.c: Add include.
8849
0f83012e
AH
88502019-03-25 Alan Hayward <alan.hayward@arm.com>
8851
8852 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8853 Call linux_get_hwcap.
8854 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8855 Likewise.
8856 (aarch64_linux_get_hwcap): Remove function.
8857 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8858 declaration.
8859 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8860 linux_get_hwcap.
8861 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8862 * linux-tdep.c (linux_get_hwcap): Add function.
8863 (linux_get_hwcap2): Likewise.
8864 * linux-tdep.h (linux_get_hwcap): Add declaration.
8865 (linux_get_hwcap2): Likewise.
8866 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8867 (ppc_linux_get_hwcap2): Likewise.
8868 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8869 linux_get_hwcap.
8870 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8871 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8872 (ppc_linux_nat_target::read_description): Likewise.
8873 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8874 * s390-linux-nat.c: Likewise.
8875 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8876
6640a367
TT
88772019-03-24 Tom Tromey <tom@tromey.com>
8878
8879 * ada-lang.c (standard_lookup): Simplify initialization.
8880 (ada_lookup_symbol_nonlocal): Simplify return.
8881 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8882 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8883 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8884 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8885 initialization.
8886 * solib.c (solib_global_lookup): Simplify.
8887 * symtab.c (null_block_symbol): Remove.
8888 (symbol_cache_lookup): Simplify returns.
8889 (lookup_language_this): Simplify returns.
8890 (lookup_symbol_aux): Simplify return.
8891 (lookup_local_symbol): Simplify returns.
8892 (lookup_global_symbol_from_objfile): Simplify return.
8893 (lookup_symbol_in_objfile_symtabs)
8894 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8895 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8896 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8897 * cp-namespace.c (cp_lookup_bare_symbol)
8898 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8899 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8900 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8901 (cp_lookup_symbol_via_imports): Simplify initialization.
8902 (find_symbol_in_baseclass): Likewise.
8903 * symtab.h (null_block_symbol): Remove.
8904 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8905 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8906 (d_lookup_symbol_module): Likewise.
8907 (find_symbol_in_baseclass): Simplify initialization.
8908
a930ebcd
TT
89092019-03-24 Tom Tromey <tom@tromey.com>
8910
8911 * expression.h: Don't include symtab.h.
8912 (struct block): Forward declare.
8913
582942f4
TT
89142019-03-24 Tom Tromey <tom@tromey.com>
8915
8916 * c-exp.y (typebase): Remove casts.
8917 * gdbtypes.c (lookup_unsigned_typename, )
8918 (lookup_signed_typename): Remove cast.
8919 * eval.c (parse_to_comma_and_eval): Remove cast.
8920 * parse.c (write_dollar_variable): Remove cast.
8921 * block.h (struct block) <superblock>: Now const.
8922 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8923 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8924 (map_block): Make "block" const.
8925 * symfile.h (struct quick_symbol_functions)
8926 <map_matching_symbols>: Constify block argument to "callback".
8927 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8928 const.
8929 (find_pc_sect_compunit_symtab): Make "b" const.
8930 (find_symbol_at_address): Likewise.
8931 (search_symbols): Likewise.
8932 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8933 (dw2_debug_names_lookup_symbol): Likewise.
8934 (dw2_map_matching_symbols): Update.
8935 * p-valprint.c (pascal_val_print): Remove "block".
8936 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8937 (aux_add_nonlocal_symbols): Make "block" const.
8938 (resolve_subexp): Remove cast.
8939 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8940 const.
8941 (iterate_over_file_blocks): Likewise.
8942 * f-exp.y (%union) <bval>: Remove.
8943 * coffread.c (patch_opaque_types): Make "b" const.
8944 * spu-tdep.c (spu_catch_start): Make "block" const.
8945 * c-valprint.c (print_unpacked_pointer): Remove "block".
8946 * symmisc.c (dump_symtab_1): Make "b" const.
8947 (block_depth): Make "block" const.
8948 * d-exp.y (%union) <bval>: Remove.
8949 * cp-support.h (cp_lookup_rtti_type): Update.
8950 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8951 * psymtab.c (psym_lookup_symbol): Make "block" const.
8952 (maintenance_check_psymtabs): Make "b" const.
8953 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8954 (enumerate_locals, enumerate_args): Update.
8955 * python/py-symtab.c (stpy_global_block): Make "block" const.
8956 (stpy_static_block): Likewise.
8957 * inline-frame.c (block_starting_point_at): Make "new_block"
8958 const.
8959 * block.c (find_block_in_blockvector): Make return type const.
8960 (blockvector_for_pc_sect): Make "b" const.
8961 (find_block_in_blockvector): Make "b" const.
8962
7ad417dd
TT
89632019-03-23 Tom Tromey <tom@tromey.com>
8964
8965 * varobj.c (varobj_create): Update.
8966 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8967 * printcmd.c (display_command, do_one_display): Don't reset
8968 innermost_block.
8969 * parser-defs.h (enum innermost_block_tracker_type): Move to
8970 expression.h.
8971 (innermost_block): Update comment.
8972 * parse.c (parse_exp_1): Add tracker_types parameter.
8973 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8974 tracker_types parameter. Reset innermost_block.
8975 (parse_exp_in_context): Remove.
8976 (parse_expression_for_completion): Update.
8977 * objfiles.c (~objfile): Don't reset expression_context_block or
8978 innermost_block.
8979 * expression.h (enum innermost_block_tracker_type): Move from
8980 parser-defs.h.
8981 (parse_exp_1): Add tracker_types parameter.
8982 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8983 reset innermost_block.
8984
b366c208
TT
89852019-03-23 Tom Tromey <tom@tromey.com>
8986
8987 * objfiles.h: Include bcache.h.
8988
9bb9b2f9
TT
89892019-03-23 Tom Tromey <tom@tromey.com>
8990
8991 * linespec.c (get_current_search_block): Use
8992 scoped_restore_current_language.
8993 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8994
59c28372
AH
89952019-03-22 Alan Hayward <alan.hayward@arm.com>
8996 Jiong Wang <jiong.wang@arm.com>
8997
8998 * aarch64-linux-tdep.c
8999 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9000 section.
9001 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9002
17e116a7
AH
90032019-03-22 Alan Hayward <alan.hayward@arm.com>
9004 Jiong Wang <jiong.wang@arm.com>
9005
9006 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9007 instructions.
9008 (aarch64_analyze_prologue_test): Add PACIASP test.
9009 (aarch64_prologue_prev_register): Unmask PC value.
9010
11e1b75f
AH
90112019-03-22 Alan Hayward <alan.hayward@arm.com>
9012 Jiong Wang <jiong.wang@arm.com>
9013
9014 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9015 (aarch64_dwarf2_prev_register): Unmask PC value.
9016 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9017 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9018 DW_CFA_AARCH64_negate_ra_state.
9019 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9020
34dcc7cf
AH
90212019-03-22 Alan Hayward <alan.hayward@arm.com>
9022 Jiong Wang <jiong.wang@arm.com>
9023
9024 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9025 registers.
9026 (aarch64_pseudo_register_name): Likewise.
9027 (aarch64_pseudo_register_type): Likewise.
9028 (aarch64_pseudo_register_reggroup_p): Likewise.
9029 (aarch64_gdbarch_init): Add pauth registers.
9030 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9031 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9032 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9033 (struct gdbarch_tdep): Add regnum for ra_state.
9034
1ef53e6b
AH
90352019-03-22 Alan Hayward <alan.hayward@arm.com>
9036 Jiong Wang <jiong.wang@arm.com>
9037
9038 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9039
76bed0fd
AH
90402019-03-22 Alan Hayward <alan.hayward@arm.com>
9041 Jiong Wang <jiong.wang@arm.com>
9042
9043 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9044 function.
9045 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9046 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9047 (aarch64_gdbarch_init): Add puth registers.
9048 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9049 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9050 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9051
ee4fbcfa
AH
90522019-03-22 Alan Hayward <alan.hayward@arm.com>
9053 Jiong Wang <jiong.wang@arm.com>
9054
9055 * aarch64-linux-nat.c
9056 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9057 * aarch64-linux-tdep.c
9058 (aarch64_linux_core_read_description): Likewise.
9059 (aarch64_linux_get_hwcap): New function.
9060 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9061 (aarch64_linux_get_hwcap): New declaration.
9062
6dc0ebde
AH
90632019-03-22 Alan Hayward <alan.hayward@arm.com>
9064 Jiong Wang <jiong.wang@arm.com>
9065
9066 * aarch64-linux-nat.c
9067 (aarch64_linux_nat_target::read_description): Add pauth param.
9068 * aarch64-linux-tdep.c
9069 (aarch64_linux_core_read_description): Likewise.
9070 * aarch64-tdep.c (struct target_desc): Add in pauth.
9071 (aarch64_read_description): Add pauth param.
9072 (aarch64_gdbarch_init): Likewise.
9073 * aarch64-tdep.h (aarch64_read_description): Likewise.
9074 * arch/aarch64.c (aarch64_create_target_description): Likewise.
9075 * arch/aarch64.h (aarch64_create_target_description): Likewise.
9076 * features/Makefile: Add new files.
9077 * features/aarch64-pauth.c: New file.
9078 * features/aarch64-pauth.xml: New file.
9079
595915c1
TT
90802019-03-20 Tom Tromey <tromey@adacore.com>
9081
9082 * infrun.c (handle_inferior_event): Rename from
9083 handle_inferior_event_1. Create a scoped_value_mark.
9084 (handle_inferior_event): Remove.
9085
4c7d57e7
TT
90862019-03-19 Tom Tromey <tromey@adacore.com>
9087
9088 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9089 * infrun.h (print_stop_event): Add "displays" parameter.
9090 * infrun.c (print_stop_event): Add "displays" parameter.
9091
cb246234
PA
90922019-03-19 Pedro Alves <palves@redhat.com>
9093
9094 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9095 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
9096 to -1. Fix TABs vs spaces.
9097 (tui_ui_out::tui_ui_out): Don't initialize fields here.
9098 * tui/tui-out.h (tui_ui_out) Add intro comments.
9099 <m_line, m_start_of_line>: In-class initialize, and add describing
9100 comment.
9101
3a0e45b2
AH
91022019-03-18 Alan Hayward <alan.hayward@arm.com>
9103
9104 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9105 variable names.
9106 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9107
5371b850
PA
91082019-03-18 Pedro Alves <palves@redhat.com>
9109 Eli Zaretskii <eliz@gnu.org>
9110
9111 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9112 m_line and m_start_of_line.
9113
b17c4cd0
EZ
91142019-03-18 Eli Zaretskii <eliz@gnu.org>
9115
9116 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9117 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9118 it returns a newline. This fixes a regression in TU mode, whereby
9119 the next line is output on the same screen line as the user input.
9120
4bd56d18
TT
91212019-03-18 Tom Tromey <tromey@adacore.com>
9122
9123 * minsyms.c (minimal_symbol_reader::install): Remove call to
9124 obstack_blank.
9125
55c10aca
PA
91262019-03-18 Pedro Alves <palves@redhat.com>
9127
9128 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9129 New globals.
9130 (apply_style): New, factored out from ...
9131 (apply_ansi_escape): ... this. Handle reverse video mode.
9132 (tui_set_reverse_mode): New function.
9133 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9134 * tui/tui-winsource.c (tui_show_source_line): Use
9135 tui_set_reverse_mode instead of setting A_STANDOUT.
9136 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9137 New setter methods.
9138
647bb750
HD
91392019-03-18 Hannes Domani <ssbssa@yahoo.de>
9140
9141 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9142 Handle tabs.
9143
bff8c71f
TT
91442019-03-18 Tom Tromey <tromey@adacore.com>
9145
9146 * ada-lang.c (empty_array): Add "high" parameter.
9147 (ada_evaluate_subexp): Update.
9148
58785d98
ST
91492019-03-17 Sergei Trofimovich <siarheit@google.com>
9150
9151 * unittests/string_view-selftests.c: Define
9152 _initialize_string_view_selftests unconditionally.
9153
d4cbef22
ВМ
91542019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9155
9156 PR gdb/24350
9157 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9158
fce4c071
ВМ
91592019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9160
9161 PR gdb/24351
9162 * windows-nat.c (display_selector): Fix format specifiers.
9163
f7f0a123
EZ
91642019-03-17 Eli Zaretskii <eliz@gnu.org>
9165
9166 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9167 tui_refill_source_window instead of tui_refresh_win, to update the
9168 current execution line. This fixes redisplay of the current line
9169 when stepping through the code with "next" or "step".
9170
ab42892f
EZ
91712019-03-16 Eli Zaretskii <eliz@gnu.org>
9172
9173 * source-cache.c (source_cache::get_source_lines): Call
9174 find_source_lines to initialize s->nlines. This fixes vertical
9175 scrolling of TUI source window when the DOWN arrow is pressed.
9176
8d8c087f
PW
91772019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9178
9179 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9180 linux-thread-db.c (_initialize_thread_db): Likewise.
9181
798e1c30
EZ
91822019-03-16 Eli Zaretskii <eliz@gnu.org>
9183
9184 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9185 wclrtoeol in tui_show_source_line". This reverts changes made in
9186 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9187
eefba3da
TT
91882019-03-15 Tom Tromey <tom@tromey.com>
9189
9190 * symtab.h (struct minimal_symbol): Derive from
9191 general_symbol_info.
9192 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9193 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9194 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9195 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9196 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9197 (MSYMBOL_SEARCH_NAME): Update.
9198 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9199 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9200 * minsyms.c (minimal_symbol_reader::record_full): Update.
9201
0de2420c
TT
92022019-03-15 Tom Tromey <tom@tromey.com>
9203
9204 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9205
042d75e4
TT
92062019-03-15 Tom Tromey <tom@tromey.com>
9207
9208 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9209 unique_xmalloc_ptr.
9210 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9211 Update.
9212 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9213 (build_minimal_symbol_hash_tables)
9214 (minimal_symbol_reader::install): Update.
9215
db92718b
TT
92162019-03-15 Tom Tromey <tom@tromey.com>
9217
9218 * symtab.c (create_demangled_names_hash): Update.
9219 (symbol_set_names): Update.
9220 * objfiles.h (struct objfile_per_bfd_storage)
9221 <demangled_names_hash>: Now an htab_up.
9222 * objfiles.c (objfile_per_bfd_storage): Simplify.
9223
d6797f46
TT
92242019-03-15 Tom Tromey <tom@tromey.com>
9225
9226 * objfiles.h (struct objfile_per_bfd_storage): Declare
9227 destructor.
9228 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9229 New.
9230 (get_objfile_bfd_data): Use new. Don't initialize
9231 language_of_main.
9232 (free_objfile_per_bfd_storage): Remove.
9233 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9234
741d7538
TT
92352019-03-15 Tom Tromey <tom@tromey.com>
9236
9237 * symfile.c (reread_symbols): Update.
9238 * objfiles.c (objfile::objfile): Update.
9239 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9240 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9241 comment.
9242 (minimal_symbol_reader::install): Update.
9243 (terminate_minimal_symbol_table): Remove.
9244 * jit.c (jit_object_close_impl): Update.
9245
788c80d1
TT
92462019-03-15 Tom Tromey <tom@tromey.com>
9247
9248 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9249 initializations.
9250
1b7a07cb
TT
92512019-03-15 Tom Tromey <tom@tromey.com>
9252
9253 * objfiles.h (struct objfile_per_bfd_storage)
9254 <demangled_hash_languages>: Now a bitset.
9255 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9256 (lookup_minimal_symbol): Update.
9257
3db066bc
TT
92582019-03-15 Tom Tromey <tom@tromey.com>
9259
9260 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9261 Don't return the symbol.
9262 * coffread.c (record_minimal_symbol): Use record_full.
9263
3fff2c37
EZ
92642019-03-14 Eli Zaretskii <eliz@gnu.org>
9265
9266 The MS-Windows port of ncurses fails to switch to a color pair if
9267 one or both of the colors are the implicit default colors. This
9268 change records the default colors when TUI is initialized, and
9269 then specifies them explicitly when a color pair uses the default
9270 colors. This allows color styling in TUI mode on MS-Windows.
9271
9272 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9273 ncurses_norm_attr.
9274 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9275 colors in ncurses_norm_attr.
9276 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9277 "none", replace it with the default color recorded in
9278 ncurses_norm_attr.
9279
3b336828
TT
92802019-03-14 Tom Tromey <tromey@adacore.com>
9281
9282 * source-cache.h (class source_cache) <get_source_lines>: Return
9283 std::string.
9284 * source-cache.c (source_cache::extract_lines): Handle case where
9285 first_pos==npos. Return std::string.
9286 (source_cache::get_source_lines): Update.
9287
d085f989
TT
92882019-03-14 Tom Tromey <tromey@adacore.com>
9289
9290 * NEWS: Add item for "style sources" commands.
9291 * source-cache.c (source_cache::get_source_lines): Check
9292 source_styling.
9293 * cli/cli-style.c (source_styling): New global.
9294 (_initialize_cli_style): Add "style sources" commands.
9295 (show_style_sources): New function.
9296 * cli/cli-style.h (source_styling): Declare.
9297
6f11e682
TT
92982019-03-14 Pedro Alves <palves@redhat.com>
9299 Tom Tromey <tromey@adacore.com>
9300
9301 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9302 * tui/tui-winsource.c (tui_refill_source_window): New function,
9303 from...
9304 (tui_horizontal_source_scroll): ... here. Move some logic.
9305 * cli/cli-style.c (set_style_enabled): Notify new observable.
9306 * tui/tui-hooks.c (tui_redisplay_source): New function.
9307 (tui_attach_detach_observers): Attach or detach
9308 tui_redisplay_source.
9309 * observable.h (source_styling_changed): New observable.
9310 * observable.c: Define source_styling_changed observable.
9311
a068643d
TT
93122019-03-13 Tom Tromey <tromey@adacore.com>
9313
9314 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9315 (i386_gnu_nat_target::store_registers): Update.
9316 * target-debug.h (target_debug_print_std_string): New macro.
9317 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9318 * windows-tdep.c (display_one_tib): Update.
9319 * tui/tui-stack.c (tui_make_status_line): Update.
9320 * top.c (print_inferior_quit_action): Update.
9321 * thread.c (thr_try_catch_cmd): Update.
9322 (add_thread_with_info): Update.
9323 (thread_target_id_str): Update.
9324 (thr_try_catch_cmd): Update.
9325 (thread_command): Update.
9326 (thread_find_command): Update.
9327 * record-btrace.c (record_btrace_target::info_record)
9328 (record_btrace_resume_thread, record_btrace_target::resume)
9329 (record_btrace_cancel_resume, record_btrace_step_thread)
9330 (record_btrace_target::wait, record_btrace_target::wait)
9331 (record_btrace_target::wait, record_btrace_target::stop): Update.
9332 * progspace.c (print_program_space): Update.
9333 * process-stratum-target.c
9334 (process_stratum_target::thread_address_space): Update.
9335 * linux-fork.c (linux_fork_mourn_inferior)
9336 (detach_checkpoint_command, info_checkpoints_command)
9337 (linux_fork_context): Update.
9338 (linux_fork_detach): Update.
9339 (class scoped_switch_fork_info): Update.
9340 (delete_checkpoint_command): Update.
9341 * infrun.c (follow_fork_inferior): Update.
9342 (follow_fork_inferior): Update.
9343 (proceed_after_vfork_done): Update.
9344 (handle_vfork_child_exec_or_exit): Update.
9345 (follow_exec): Update.
9346 (displaced_step_prepare_throw): Update.
9347 (displaced_step_restore): Update.
9348 (start_step_over): Update.
9349 (resume_1): Update.
9350 (clear_proceed_status_thread): Update.
9351 (proceed): Update.
9352 (print_target_wait_results): Update.
9353 (do_target_wait): Update.
9354 (context_switch): Update.
9355 (stop_all_threads): Update.
9356 (restart_threads): Update.
9357 (finish_step_over): Update.
9358 (handle_signal_stop): Update.
9359 (switch_back_to_stepped_thread): Update.
9360 (keep_going_pass_signal): Update.
9361 (print_exited_reason): Update.
9362 (normal_stop): Update.
9363 * inferior.c (inferior_pid_to_str): Change return type.
9364 (print_selected_inferior): Update.
9365 (add_inferior): Update.
9366 (detach_inferior): Update.
9367 * dummy-frame.c (fprint_dummy_frames): Update.
9368 * dcache.c (dcache_info_1): Update.
9369 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9370 (btrace_fetch, btrace_clear): Update.
9371 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9372 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9373 type.
9374 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9375 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9376 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9377 * gdbarch.c, gdbarch.h: Rebuild.
9378 * gdbarch.sh (core_pid_to_str): Change return type.
9379 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9380 return type.
9381 (windows_nat_target::pid_to_str): Change return type.
9382 (windows_delete_thread): Update.
9383 (windows_nat_target::attach): Update.
9384 (windows_nat_target::files_info): Update.
9385 * target-delegates.c: Rebuild.
9386 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9387 return type.
9388 (sol_thread_target::pid_to_str): Change return type.
9389 * remote.c (class remote_target) <pid_to_str>: Change return
9390 type.
9391 (remote_target::pid_to_str): Change return type.
9392 (extended_remote_target::attach, remote_target::remote_stop_ns)
9393 (remote_target::remote_notif_remove_queued_reply)
9394 (remote_target::push_stop_reply, remote_target::disable_btrace):
9395 Update.
9396 (extended_remote_target::attach): Update.
9397 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9398 type.
9399 (gdbsim_target::pid_to_str): Change return type.
9400 * ravenscar-thread.c (struct ravenscar_thread_target)
9401 <pid_to_str>: Change return type.
9402 (ravenscar_thread_target::pid_to_str): Change return type.
9403 * procfs.c (class procfs_target) <pid_to_str>: Change return
9404 type.
9405 (procfs_target::pid_to_str): Change return type.
9406 (procfs_target::attach): Update.
9407 (procfs_target::detach): Update.
9408 (procfs_target::fetch_registers): Update.
9409 (procfs_target::store_registers): Update.
9410 (procfs_target::wait): Update.
9411 (procfs_target::files_info): Update.
9412 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9413 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9414 return type.
9415 (nto_procfs_target::pid_to_str): Change return type.
9416 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9417 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9418 return type.
9419 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9420 (exit_lwp): Update.
9421 (attach_proc_task_lwp_callback, get_detach_signal)
9422 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9423 (linux_nat_target::resume, wait_lwp, stop_callback)
9424 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9425 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9426 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9427 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9428 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9429 type.
9430 (inf_ptrace_target::attach): Update.
9431 (inf_ptrace_target::files_info): Update.
9432 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9433 type.
9434 (go32_nat_target::pid_to_str): Change return type.
9435 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9436 (gnu_nat_target::wait): Update.
9437 (gnu_nat_target::wait): Update.
9438 (gnu_nat_target::resume): Update.
9439 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9440 (fbsd_nat_target::wait): Update.
9441 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9442 type.
9443 (darwin_nat_target::attach): Update.
9444 * corelow.c (class core_target) <pid_to_str>: Change return type.
9445 (core_target::pid_to_str): Change return type.
9446 * target.c (normal_pid_to_str): Change return type.
9447 (default_pid_to_str): Likewise.
9448 (target_pid_to_str): Change return type.
9449 (target_translate_tls_address): Update.
9450 (target_announce_detach): Update.
9451 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9452 return type.
9453 (bsd_uthread_target::pid_to_str): Change return type.
9454 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9455 type.
9456 (bsd_kvm_target::pid_to_str): Change return type.
9457 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9458 return type.
9459 (aix_thread_target::pid_to_str): Change return type.
9460 * target.h (struct target_ops) <pid_to_str>: Change return type.
9461 (target_pid_to_str, normal_pid_to_str): Likewise.
9462 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9463 type.
9464 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9465 type.
9466 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9467 return type.
9468 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9469 type.
9470 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9471 type.
9472 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9473 return type.
9474
b4be1b06
SM
94752019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9476
9477 * NEWS: Mention that the new default MI version is 3. Mention
9478 changes to the output of commands and events that deal with
9479 multi-location breakpoints.
9480 * breakpoint.c: Include "mi/mi-out.h".
9481 (print_one_breakpoint): Change output syntax if using MI version
9482 >= 3.
9483 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9484 New.
9485 (mi_multi_location_breakpoint_output_fixed): New.
9486 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9487 (mi_cmd_fix_multi_location_breakpoint_output): New.
9488 (mi_multi_location_breakpoint_output_fixed): New.
9489 * mi/mi-cmds.c (mi_cmds): Register command
9490 -fix-multi-location-breakpoint-output.
9491 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9492 interpreter "mi".
9493
8e5e5494
SM
94942019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9495
9496 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9497 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9498 instantiate mi_ui_out based on interpreter name.
9499 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9500 * mi/mi-main.c (mi_load_progress): Likewise.
9501
197df35e
JB
95022019-03-12 John Baldwin <jhb@FreeBSD.org>
9503
9504 * NEWS: Combine separate "New targets" sections for 8.3.
9505
8399425f
JB
95062019-03-12 John Baldwin <jhb@FreeBSD.org>
9507
9508 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9509 (ppcfbsd_init_abi): Install gdbarch
9510 "fetch_tls_load_module_address" and "get_thread_local_address"
9511 methods.
9512
b0f87ed0
JB
95132019-03-12 John Baldwin <jhb@FreeBSD.org>
9514
9515 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9516 (riscv_fbsd_init_abi): Install gdbarch
9517 "fetch_tls_load_module_address" and "get_thread_local_address"
9518 methods.
9519
ce25aa57
JB
95202019-03-12 John Baldwin <jhb@FreeBSD.org>
9521
9522 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9523 (i386fbsd_init_abi): Install gdbarch
9524 "fetch_tls_load_module_address" and "get_thread_local_address"
9525 methods.
9526
f5424cfa
JB
95272019-03-12 John Baldwin <jhb@FreeBSD.org>
9528
9529 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9530 (amd64fbsd_init_abi): Install gdbarch
9531 "fetch_tls_load_module_address" and "get_thread_local_address"
9532 methods.
9533
945f3901
JB
95342019-03-12 John Baldwin <jhb@FreeBSD.org>
9535
9536 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9537 (struct fbsd_pspace_data): New type.
9538 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9539 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9540 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9541 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9542 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9543
ef0bd204
JB
95442019-03-12 John Baldwin <jhb@FreeBSD.org>
9545
9546 * gdbtypes.c (lookup_struct_elt): New function.
9547 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9548 * gdbtypes.h (struct struct_elt): New type.
9549 (lookup_struct_elt): New prototype.
9550
36c53a02
JB
95512019-03-12 John Baldwin <jhb@FreeBSD.org>
9552
9553 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9554 remove disabled code block.
9555
6e056c81
JB
95562019-03-12 John Baldwin <jhb@FreeBSD.org>
9557
9558 * gdbarch.sh (get_thread_local_address): New method.
9559 * gdbarch.h, gdbarch.c: Regenerate.
9560 * target.c (target_translate_tls_address): Use
9561 gdbarch_get_thread_local_address if present instead of
9562 target::get_thread_local_address.
9563
cd250a18
JB
95642019-03-12 John Baldwin <jhb@FreeBSD.org>
9565
9566 * target.h (target::get_thread_local_address): Update comment.
9567
df22c1e5
JB
95682019-03-12 John Baldwin <jhb@FreeBSD.org>
9569
9570 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9571 objfile->separate_debug_objfile_backlink if not NULL.
9572
dd6876c9
JB
95732019-03-12 John Baldwin <jhb@FreeBSD.org>
9574
9575 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9576 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9577 (amd64bsd_store_inferior_registers): Likewise.
9578 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9579 Enable segment base registers.
9580 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9581 PT_GETFSBASE and PT_GETGSBASE.
9582 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9583 PT_SETGSBASE.
9584 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9585 segment base registers.
9586 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9587
1163a4b7
JB
95882019-03-12 John Baldwin <jhb@FreeBSD.org>
9589
9590 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9591 Update calls to i386_target_description to add 'segments'
9592 parameter.
9593 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9594 add segment base registers.
9595 * arch/i386.c (i386_create_target_description): Add 'segments'
9596 parameter to enable segment base registers.
9597 * arch/i386.h (i386_create_target_description): Likewise.
9598 * features/i386/32bit-segments.xml: New file.
9599 * features/i386/32bit-segments.c: Generate.
9600 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9601 call to i386_target_description to add 'segments' parameter.
9602 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9603 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9604 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9605 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9606 if feature is present.
9607 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9608 Add 'segments' parameter to call to i386_target_description.
9609 (i386_target_description): Add 'segments' parameter to enable
9610 segment base registers.
9611 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9612 to call to i386_target_description.
9613 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9614 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9615 Define I386_NUM_REGS.
9616 (i386_target_description): Add 'segments' parameter to enable
9617 segment base registers.
9618
3a350822
EZ
96192019-03-12 Eli Zaretskii <eliz@gnu.org>
9620
9621 PR/24325
9622 * source-cache.c: #undef open and close, to avoid unresolved
9623 externals during linking.
9624
ffdd69cf
TT
96252019-03-12 Tom Tromey <tromey@adacore.com>
9626
9627 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9628 const. Add initializers.
9629 (_initialize_remote): Don't initialize ptid globals.
9630
ec148c57
PA
96312019-03-12 Pedro Alves <palves@redhat.com>
9632
9633 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9634
32764270
PA
96352019-03-12 Pedro Alves <palves@redhat.com>
9636
9637 * cp-name-parser.y (main): Remove unused 'len' variable.
9638
17547186
TT
96392019-03-12 Tom Tromey <tromey@adacore.com>
9640
9641 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9642 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9643
d3a70e03
TT
96442019-03-12 Tom Tromey <tromey@adacore.com>
9645
9646 * linux-nat.c (iterate_over_lwps): Update.
9647 (stop_callback): Remove parameter.
9648 (stop_wait_callback, detach_callback, resume_set_callback)
9649 (select_singlestep_lwp_callback, set_ignore_sigint)
9650 (status_callback, resumed_callback, resume_clear_callback)
9651 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9652 data parameter.
9653 (linux_nat_target::detach, linux_nat_target::resume)
9654 (linux_stop_and_wait_all_lwps, select_event_lwp)
9655 (linux_nat_filter_event, linux_nat_wait_1)
9656 (linux_nat_target::kill, linux_nat_target::stop)
9657 (linux_nat_target::stop): Update.
9658 (linux_nat_resume_callback): Change type.
9659 (resume_stopped_resumed_lwps, count_events_callback)
9660 (select_event_lwp_callback): Likewise.
9661 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9662 * arm-linux-nat.c (struct update_registers_data): Remove.
9663 (update_registers_callback): Change type.
9664 (arm_linux_insert_hw_breakpoint1): Update.
9665 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9666 parameter.
9667 (x86_linux_dr_set_addr): Update.
9668 (x86_linux_dr_set_control): Update.
9669 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9670 (iterate_over_lwps): Use gdb::function_view.
9671 * nat/aarch64-linux-hw-point.c (struct
9672 aarch64_dr_update_callback_param): Remove.
9673 (debug_reg_change_callback): Change type.
9674 (aarch64_notify_debug_reg_change): Update.
9675 * s390-linux-nat.c (s390_refresh_per_info): Update.
9676
82cb27ff
TT
96772019-03-11 Tom Tromey <tromey@adacore.com>
9678
9679 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9680 redundant assignment to "this_cu".
9681
568c0683
SM
96822019-03-08 Simon Marchi <simon.marchi@efficios.com>
9683
9684 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9685
f09ce22d
SM
96862019-03-08 Simon Marchi <simon.marchi@efficios.com>
9687
9688 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9689 from...
9690 (rank_one_type): ... this.
9691
595f96a9
SM
96922019-03-08 Simon Marchi <simon.marchi@efficios.com>
9693
9694 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9695 from...
9696 (rank_one_type): ... this.
9697
2598a94b
SM
96982019-03-08 Simon Marchi <simon.marchi@efficios.com>
9699
9700 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9701 from...
9702 (rank_one_type): ... this.
9703
7f17b20d
SM
97042019-03-08 Simon Marchi <simon.marchi@efficios.com>
9705
9706 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9707 from...
9708 (rank_one_type): ... this.
9709
2c509035
SM
97102019-03-08 Simon Marchi <simon.marchi@efficios.com>
9711
9712 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9713 from...
9714 (rank_one_type): ... this.
9715
0dd322dc
SM
97162019-03-08 Simon Marchi <simon.marchi@efficios.com>
9717
9718 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9719 from...
9720 (rank_one_type): ... this.
9721
41ea4728
SM
97222019-03-08 Simon Marchi <simon.marchi@efficios.com>
9723
9724 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9725 from...
9726 (rank_one_type): ... this.
9727
793cd1d2
SM
97282019-03-08 Simon Marchi <simon.marchi@efficios.com>
9729
9730 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9731 from...
9732 (rank_one_type): ... this.
9733
34910087
SM
97342019-03-08 Simon Marchi <simon.marchi@efficios.com>
9735
9736 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9737 from...
9738 (rank_one_type): ... this.
9739
f1f832d6
SM
97402019-03-08 Simon Marchi <simon.marchi@efficios.com>
9741
9742 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9743 from...
9744 (rank_one_type): ... this.
9745
b9f4512f
SM
97462019-03-08 Simon Marchi <simon.marchi@efficios.com>
9747
9748 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9749 from...
9750 (rank_one_type): ... this.
9751
9293fc63
SM
97522019-03-08 Simon Marchi <simon.marchi@efficios.com>
9753
9754 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9755 from...
9756 (rank_one_type): ... this.
9757
e3abbe7e
PW
97582019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9759
9760 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9761 inferior-events' shows the example events.
9762
e4adb939
EZ
97632019-03-08 Eli Zaretskii <eliz@gnu.org>
9764
9765 Support styling on native MS-Windows console
9766
9767 PR/24315
9768 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9769 on MS-Windows if $TERM is not defined.
9770
9771 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9772
9773 * posix-hdep.c (gdb_console_fputs):
9774 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9775 functions.
9776 * ui-file.h (gdb_console_fputs): Add prototype.
9777
9778 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9779 back to fputs only if the former returns zero.
9780
25629dfd
TT
97812019-03-07 Tom Tromey <tom@tromey.com>
9782
9783 * symmisc.c (print_symbol_bcache_statistics): Update.
9784 (print_objfile_statistics): Update.
9785 * symfile.c (allocate_symtab): Update.
9786 * stabsread.c: Don't include bcache.h.
9787 * psymtab.h (struct psymbol_bcache): Don't declare.
9788 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9789 (psymbol_bcache_init, psymbol_bcache_free)
9790 (psymbol_bcache_get_bcache): Don't declare.
9791 * psymtab.c (struct psymbol_bcache): Remove.
9792 (psymtab_storage::psymtab_storage): Update.
9793 (psymtab_storage::~psymtab_storage): Update.
9794 (psymbol_bcache_init, psymbol_bcache_free)
9795 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9796 (add_psymbol_to_bcache): Update.
9797 (allocate_psymtab): Update.
9798 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9799 macro_cache>: No longer pointers.
9800 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9801 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9802 * macrotab.c (macro_bcache): Update.
9803 * macroexp.c: Don't include bcache.h.
9804 * gdbtypes.c (check_types_worklist): Update.
9805 (types_deeply_equal): Remove TRY/CATCH. Update.
9806 * elfread.c (elf_symtab_read): Update.
9807 * dwarf2read.c: Don't include bcache.h.
9808 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9809 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9810 (print_bcache_statistics, bcache_memory_used): Don't declare.
9811 (struct bcache): Move from bcache.c. Add constructor, destructor,
9812 methods. Rename all data members.
9813 * bcache.c (struct bcache): Move to bcache.h.
9814 (bcache::expand_hash_table): Rename from expand_hash_table.
9815 (bcache): Remove.
9816 (bcache::insert): Rename from bcache_full.
9817 (bcache::compare): Rename from bcache_compare.
9818 (bcache_xmalloc): Remove.
9819 (bcache::~bcache): Rename from bcache_xfree.
9820 (bcache::print_statistics): Rename from print_bcache_statistics.
9821 (bcache::memory_used): Rename from bcache_memory_used.
9822
fe726667
PA
98232019-03-07 Pedro Alves <palves@redhat.com>
9824
9825 * infrun.c (normal_stop): Also check for
9826 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9827
7584bb30
AB
98282019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9829
9830 * f-lang.c (value_from_host_double): Moved to...
9831 * value.c (value_from_host_double): ...here.
9832 * value.h (value_from_host_double): Declare.
9833 * guile/scm-math.c (vlscm_convert_typed_number): Use
9834 value_from_host_double.
9835 (vlscm_convert_number): Likewise.
9836 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9837 * python/py-value.c (convert_value_from_python): Likewise.
9838
a7b1986e
TT
98392019-03-06 Tom Tromey <tom@tromey.com>
9840
9841 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9842
0ccf4211
TT
98432019-03-06 Tom Tromey <tom@tromey.com>
9844
9845 * utils.h (free_current_contents): Don't declare.
9846 * utils.c (free_current_contents): Remove.
9847
fe7b42e5
TT
98482019-03-06 Tom Tromey <tom@tromey.com>
9849
9850 * top.c (quit_force): Update.
9851 * main.c (captured_command_loop): Update.
9852 * common/new-op.c (operator new): Update.
9853 * common/common-exceptions.c (struct catcher)
9854 <save_cleanup_chain>: Remove member.
9855 (exceptions_state_mc_init): Update.
9856 (exception_try_scope_entry): Return nullptr.
9857 (exception_try_scope_exit, exception_rethrow)
9858 (throw_exception_sjlj, throw_exception_cxx): Update.
9859 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9860 (all_cleanups, do_cleanups, discard_cleanups)
9861 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9862 (restore_cleanups, restore_final_cleanups): Don't declare.
9863 (do_final_cleanups): Remove parameter.
9864 * common/cleanups.c (cleanup_chain, make_cleanup)
9865 (make_cleanup_dtor, all_cleanups, do_cleanups)
9866 (discard_my_cleanups, discard_cleanups)
9867 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9868 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9869 (null_cleanup): Remove.
9870 (do_final_cleanups): Remove parameter.
9871
c6321f19
TT
98722019-03-06 Tom Tromey <tom@tromey.com>
9873
9874 * remote.c (remote_target::remote_parse_stop_reply): Use
9875 unique_xmalloc_ptr.
9876
61b30099
TT
98772019-03-06 Tom Tromey <tom@tromey.com>
9878
9879 * stabsread.c (struct stabs_field_info): Rename from field_info.
9880 <list, fnlist>: Add initializers.
9881 <obstack>: New member.
9882 (read_member_functions, read_struct_fields, read_baseclasses):
9883 Allocate on obstack. Don't use cleanups.
9884 (read_one_struct_field, read_member_functions, read_struct_fields)
9885 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9886 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9887 (read_struct_type): Update.
9888
6cceac94
TT
98892019-03-06 Tom Tromey <tom@tromey.com>
9890
9891 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9892 * common/filestuff.h (make_cleanup_close): Don't declare.
9893 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9894 Remove.
9895
72412762
TT
98962019-03-06 Tom Tromey <tom@tromey.com>
9897
9898 * solib-aix.c: Use make_scope_exit.
9899
2b6ff1c0
TT
99002019-03-06 Tom Tromey <tom@tromey.com>
9901
9902 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9903 Use make_scope_exit.
9904
d01c5877
TT
99052019-03-06 Tom Tromey <tom@tromey.com>
9906
9907 * solib-svr4.c (disable_probes_interface): Remove parameter.
9908 (svr4_handle_solib_event): Use make_scope_exit.
9909
32603266
TT
99102019-03-06 Tom Tromey <tom@tromey.com>
9911
9912 * remote.c (struct stop_reply_deleter): Remove.
9913 (stop_reply_up): Update.
9914 (struct stop_reply): Derive from notif_event. Don't typedef.
9915 <regcache>: Now a std::vector.
9916 (stop_reply_xfree): Remove.
9917 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9918 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9919 (remote_target::discard_pending_stop_replies): Use delete.
9920 (remote_target::remote_parse_stop_reply): Update.
9921 (remote_target::process_stop_reply): Update.
9922 * remote-notif.h (struct notif_event): Add virtual destructor.
9923 Remove "dtr" member.
9924 (struct notif_client) <alloc_event>: Return a unique_ptr.
9925 (notif_event_xfree): Don't declare.
9926 (notif_event_up): New typedef.
9927 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9928 (notif_event_xfree, do_notif_event_xfree): Remove.
9929 (remote_notif_state_xfree): Update.
9930
9799571e
TT
99312019-03-06 Tom Tromey <tom@tromey.com>
9932
9933 * infrun.c (displaced_step_clear_cleanup): Now a
9934 forward_scope_exit type.
9935 (displaced_step_prepare_throw): Update.
9936 (displaced_step_fixup): Update.
9937
09e3c4ca
TT
99382019-03-06 Tom Tromey <tom@tromey.com>
9939
9940 * inferior.h (class inferior): Update comment.
9941 * gdbthread.h (class thread_info): Update comment.
9942
e2a03548
TT
99432019-03-06 Joel Brobecker <brobecker@adacore.com>
9944 Tom Tromey <tom@tromey.com>
9945
9946 * stabsread.h (struct stab_section_list): Remove.
9947 (coffstab_build_psymtabs): Update.
9948 * dbxread.c (symbuf_sections): Now a std::vector.
9949 (sect_idx): New global.
9950 (fill_symbuf): Update.
9951 (coffstab_build_psymtabs): Change type of stabsects parameter.
9952 Update.
9953 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9954 std::vector.
9955 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9956 (coff_locate_sections): Update.
9957 (coff_symfile_read): Remove cleanups. Update.
9958 (init_stringtab): Add storage parameter.
9959 (free_stringtab, free_stringtab_cleanup): Remove.
9960 (init_lineno): Add storage parameter.
9961 (free_linetab, free_linetab_cleanup): Remove.
9962
b7e60d85
PA
99632019-03-06 Pedro Alves <palves@redhat.com>
9964
9965 * linux-fork.c (fork_info::clobber_regs): Delete.
9966 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9967 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9968 comment. Adjust.
9969 (scoped_switch_fork_info::scoped_switch_fork_info)
9970 (checkpoint_command, linux_fork_context): Adjust
9971 fork_save_infrun_state calls.
9972
e52c971f
PA
99732019-03-06 Pedro Alves <palves@redhat.com>
9974
9975 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9976 (inf_has_multiple_threads): Return 'bool' and rewrite using
9977 inferior_info::threads().
9978
06974e6c
PA
99792019-03-06 Pedro Alves <palves@redhat.com>
9980
9981 * linux-fork.c: Include <list>.
9982 (fork_list): Now a std::list instance.
9983 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9984 (forks_exist_p, find_last_fork): Adjust.
9985 (new_fork): Delete.
9986 (one_fork_p): New.
9987 (add_fork): Adjust.
9988 (free_fork): Delete, folded into fork_info::~fork_info().
9989 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9990 Adjust.
9991 (init_fork_list): Delete.
9992 (linux_fork_killall, linux_fork_mourn_inferior)
9993 (linux_fork_detach, info_checkpoints_command): Adjust.
9994 (_initialize_linux_fork): No longer call init_fork_list.
9995
72f31aea
PA
99962019-03-06 Pedro Alves <palves@redhat.com>
9997
9998 * linux-fork.c (new_fork): New, split out of ...
9999 (add_fork): ... this. Return void. Move "first fork" special
10000 case from here, to ...
10001 (checkpoint_command): ... here.
10002 * linux-linux.h (add_fork): Return void.
10003
efbecbc1
AB
100042019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10005
10006 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10007
0841c79a
AB
100082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10009 Chris January <chris.january@arm.com>
10010 David Lecomber <david.lecomber@arm.com>
10011
10012 * f-exp.y: New token, UNOP_INTRINSIC.
10013 (exp): New pattern using UNOP_INTRINSIC token.
10014 (f77_keywords): Add 'abs' keyword.
10015 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10016 (value_from_host_double): New function.
10017 (evaluate_subexp_f): Support UNOP_ABS.
10018
4a270568
AB
100192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10020
10021 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10022 types.
10023
067630bd
AB
100242019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10025
10026 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10027 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10028 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10029
3be47f7a
AB
100302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10031
10032 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10033
4d00f5d8
AB
100342019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10035 Chris January <chris.january@arm.com>
10036
10037 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10038 * f-exp.y: Define 'KIND' token.
10039 (exp): New pattern for KIND expressions.
10040 (ptype): Handle types with a kind extension.
10041 (direct_abs_decl): Extend to spot kind extensions.
10042 (f77_keywords): Add 'kind' to the list.
10043 (push_kind_type): New function.
10044 (convert_to_kind_type): New function.
10045 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10046 * parse.c (operator_length_standard): Likewise.
10047 * parser-defs.h (enum type_pieces): Add tp_kind.
10048 * std-operator.def: Add UNOP_KIND.
10049
e454224f
AB
100502019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10051
10052 * f-exp.y (f_parse): Set yydebug.
10053
9dad4a58
AB
100542019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10055
10056 * f-lang.c (evaluate_subexp_f): New function.
10057 (exp_descriptor_f): New global.
10058 (f_language_defn): Use exp_descriptor_f instead of
10059 exp_descriptor_standard.
10060
c8f91604
AB
100612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10062
10063 * f-exp.y (struct token): Add comments.
10064 (dot_ops): Remove uppercase versions and the end marker.
10065 (f77_keywords): Likewise.
10066 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10067 entries in the dot_ops array are case insensitive, and use
10068 strncasecmp to compare strings. Also some whitespace cleanup in
10069 this area. Similar for the f77_keywords array, except entries in
10070 this list might be case sensitive.
10071
dd9f2c76
AB
100722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10073
10074 * f-exp.y (struct f77_boolean_val): Add comments.
10075 (boolean_values): Remove uppercase versions, and end marker.
10076 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10077 and use strncasecmp to achieve case insensitivity. Additionally,
10078 perform whitespace cleanup around this code.
10079
67a3048c
TT
100802019-03-06 Tom Tromey <tromey@adacore.com>
10081
10082 * remote-sim.c (gdbsim_target_open): Use result of
10083 gdb_argv::release.
10084
aa3cfbda
RB
100852019-03-06 Richard Bunt <richard.bunt@arm.com>
10086 Dirk Schubert <dirk.schubert@arm.com>
10087 Chris January <chris.january@arm.com>
10088
10089 * eval.c (evaluate_subexp_standard): Call Fortran argument
10090 wrapping logic.
10091 * f-lang.c (struct value): A value which can be passed into a
10092 Fortran function call.
10093 (fortran_argument_convert): Wrap Fortran arguments in a pointer
10094 where appropriate.
10095 (struct type): Value ready for a Fortran function call.
10096 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10097 is needed.
10098 * f-lang.h (fortran_argument_convert): Declaration.
10099 (fortran_preserve_arg_pointer): Declaration.
10100 * infcall.c (value_arg_coerce): Call Fortran argument logic.
10101
ea38e5df
TT
101022019-03-05 Tom Tromey <tromey@adacore.com>
10103
10104 * python/py-prettyprint.c (print_string_repr): Remove #if.
10105 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10106
06b5b831
TT
101072019-03-05 Tom Tromey <tromey@adacore.com>
10108
10109 * target.c (the_dummy_target): Move later. Change type to
10110 "dummy_target".
10111 (initialize_targets): Don't initialize the_dummy_target.
10112
edbd9e45
TT
101132019-03-05 Tom Tromey <tromey@adacore.com>
10114
10115 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10116 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10117
c119e040
TT
101182019-03-05 Tom Tromey <tromey@adacore.com>
10119
10120 * windows-nat.c (windows_nat_target::attach)
10121 (windows_nat_target::detach): Don't call gdb_flush.
10122 * valprint.c (generic_val_print, val_print, val_print_string):
10123 Don't call gdb_flush.
10124 * utils.c (defaulted_query): Don't call gdb_flush.
10125 * typeprint.c (print_type_scalar): Don't call gdb_flush.
10126 * target.c (target_announce_detach): Don't call gdb_flush.
10127 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10128 * remote.c (extended_remote_target::attach): Don't call
10129 gdb_flush.
10130 * procfs.c (procfs_target::detach): Don't call gdb_flush.
10131 * printcmd.c (do_examine): Don't call gdb_flush.
10132 (info_display_command): Don't call gdb_flush.
10133 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10134 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10135 * memattr.c (info_mem_command): Don't call gdb_flush.
10136 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10137 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10138 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10139 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10140 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10141 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10142 (gnu_nat_target::detach): Don't call gdb_flush.
10143 * f-valprint.c (f_val_print): Don't call gdb_flush.
10144 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10145 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10146 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10147 gdb_flush.
10148 * c-valprint.c (c_val_print): Don't call gdb_flush.
10149 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10150
895dafa6
TT
101512019-03-05 Tom Tromey <tromey@adacore.com>
10152
10153 * varobj.c (update_dynamic_varobj_children): Update.
10154 (install_default_visualizer): Use reset, not release.
10155 * value.c (set_internalvar): Update.
10156 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10157 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10158 ATTRIBUTE_UNUSED_RESULT.
10159
88a774b9
TT
101602019-03-05 Tom Tromey <tromey@adacore.com>
10161
10162 * remote.c (class scoped_remote_fd) <release>: Add
10163 ATTRIBUTE_UNUSED_RESULT.
10164
4e4a8b93
TT
101652019-03-05 Tom Tromey <tromey@adacore.com>
10166
10167 * macroexp.c (struct macro_buffer) <release>: Add
10168 ATTRIBUTE_UNUSED_RESULT.
10169
083eef1f
TT
101702019-03-05 Tom Tromey <tromey@adacore.com>
10171
10172 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10173 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10174 ATTRIBUTE_UNUSED_RESULT.
10175
3cabd438
TT
101762019-03-05 Tom Tromey <tromey@adacore.com>
10177
10178 * common/scoped_fd.h (class scoped_fd) <release>: Add
10179 ATTRIBUTE_UNUSED_RESULT.
10180
41e3300a
TT
101812019-03-05 Tom Tromey <tromey@adacore.com>
10182
10183 * parser-defs.h (struct parser_state) <release>: Add
10184 ATTRIBUTE_UNUSED_RESULT.
10185
18cb7c9f
TT
101862019-03-05 Tom Tromey <tromey@adacore.com>
10187
10188 * utils.h (class gdb_argv) <release>: Add
10189 ATTRIBUTE_UNUSED_RESULT.
10190 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10191
41fa577f
EZ
101922019-03-02 Eli Zaretskii <eliz@gnu.org>
10193
a6a4b2c6
EZ
10194 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10195 for-loop range, to avoid compiler warnings.
10196
10197 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10198 avoid compiler warnings about unused variables.
10199
742a7df5
EZ
10200 * NEWS: Mention end of support for native debugging on MS-Windows
10201 before XP.
10202
41fa577f
EZ
10203 PR gdb/24292
10204 * common/netstuff.c:
10205 * gdbserver/gdbreplay.c
10206 * gdbserver/remote-utils.c:
10207 * ser-tcp.c:
10208 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10209 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10210 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10211 'getaddrinfo' and 'freeaddrinfo' were not available before
10212 Windows XP, and mingw.org's MinGW headers by default define
10213 _WIN32_WINNT to 0x500.
10214
827f438f
GB
102152019-03-01 Gary Benson <gbenson@redhat.com>
10216
10217 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10218
92137da0
RO
102192019-02-28 Brian Vandenberg <phantall@gmail.com>
10220 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10221
10222 PR gdb/8527
10223 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10224 set_sigint_trap, clear_sigint_trap.
10225
799efbe8
PW
102262019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10227
10228 * target.c (target_detach): Clear the regcache and the
10229 frame cache.
10230
8ed25214
PA
102312019-02-27 Pedro Alves <palves@redhat.com>
10232
10233 * utils.c (set_screen_size): When we cap the height/width sizes,
10234 tweak the corresponding command variable to show "unlimited":
10235
23031e31
SJ
102362019-02-27 Saagar Jha <saagar@saagarjha.com>
10237 Pedro Alves <palves@redhat.com>
10238
10239 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10240 before calling rl_set_screen_size.
10241
6c28e44a
TT
102422019-02-27 Tom Tromey <tromey@adacore.com>
10243
10244 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10245 define.
10246 * python/py-value.c: Remove Python 2.4 workaround.
10247 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10248 workaround.
10249 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10250 Python 2.4 workaround.
10251 * python/python-internal.h: Remove Python 2.4 comment.
10252 (Py_ssize_t): Don't define.
10253 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10254 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10255 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10256 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10257 * python/python.c (do_start_initialization): Remove Python 2.4
10258 workaround.
10259 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10260 (print_children): Remove Python 2.4 workaround.
10261 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10262 workaround.
10263 (CHARBUFFERPROC_NAME): Remove.
10264 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10265 Python 2.4 workaround.
10266
2c3fc25d 102672019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 10268
2c3fc25d
KB
10269 * NEWS: Note minimum Python version.
10270
6ca62222
KB
102712019-02-27 Kevin Buettner <kevinb@redhat.com>
10272
10273 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10274 code from these functions. Remove corresponding ifdefs. Use
10275 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10276 Remove gotos and target of gotos.
10277 (infpy_search_memory): Likewise.
10278
f4bc7d2c
AB
102792019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10280
10281 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10282 (hppa_gdbarch_init): Don't register deleted functions with
10283 gdbarch.
10284
9734a586
AB
102852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10286
10287 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10288 (h8300_unwind_sp): Delete.
10289 (h8300_dummy_id): Delete.
10290 (h8300_gdbarch_init): Don't register deleted functions with
10291 gdbarch.
10292
68b867f3
AB
102932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10294
10295 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10296 (ft32_unwind_pc): Delete.
10297 (ft32_unwind_sp): Delete.
10298 (ft32_gdbarch_init): Don't register deleted functions with
10299 gdbarch.
10300
2fbe7ad0
AB
103012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10302
10303 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10304 (frv_unwind_pc): Delete.
10305 (frv_unwind_sp): Delete.
10306 (frv_gdbarch_init): Don't register deleted functions with
10307 gdbarch.
10308
76055cbe
AB
103092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10310
10311 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10312 (riscv_unwind_pc): Delete.
10313 (riscv_unwind_sp): Delete.
10314 (riscv_gdbarch_init): Don't register deleted functions with
10315 gdbarch.
10316
4133e5a1
AB
103172019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10318
10319 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10320 (csky_unwind_pc): Delete.
10321 (csky_unwind_sp): Delete.
10322 (csky_gdbarch_init): Don't register deleted functions with
10323 gdbarch.
10324
8010f576
AB
103252019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10326
10327 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10328 (cris_unwind_pc): Delete.
10329 (cris_unwind_sp): Delete.
10330 (cris_gdbarch_init): Don't register deleted functions with
10331 gdbarch.
10332
b56bf084
AB
103332019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10334
10335 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10336 (bfin_unwind_pc): Delete.
10337 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10338
a19a650f
AB
103392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10340
10341 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10342 (arm_unwind_pc): Delete.
10343 (arm_unwind_sp): Delete.
10344 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10345
f8278c3c
AB
103462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10347
10348 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10349 (arc_unwind_pc): Delete.
10350 (arc_unwind_sp): Delete.
10351 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10352
480e46cf
AB
103532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10354
10355 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10356 (alpha_unwind_pc): Delete.
10357 (alpha_gdbarch_init): Don't register deleted functions with
10358 gdbarch.
10359
7a995095
AB
103602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10361
10362 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10363 (aarch64_unwind_pc): Delete.
10364 (aarch64_unwind_sp): Delete.
10365 (aarch64_gdbarch_init): Don't register deleted functions with
10366 gdbarch.
10367
bf9a735e
AB
103682019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10369
10370 * gdbtypes.c (type_align): Don't consider static members when
10371 computing structure alignment.
10372
5561fc30
AB
103732019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10374
10375 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10376 return 0 for other types.
10377 * arch-utils.c (default_type_align): Always return 0.
10378 * gdbarch.h: Regenerate.
10379 * gdbarch.sh (type_align): Extend comment.
10380 * gdbtypes.c (type_align): Add additional comments, always call
10381 gdbarch_type_align before applying the default rules.
10382 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10383 generic code will then apply a suitable default.
10384 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10385 types, return 0 for other types.
10386
9335e75a
JB
103872019-02-27 Joel Brobecker <brobecker@adacore.com>
10388
10389 * NEWS: Create a new section for the next release branch.
10390 Rename the section of the current branch, now that it has
10391 been cut.
10392
3d34d8de
JB
103932019-02-27 Joel Brobecker <brobecker@adacore.com>
10394
10395 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10396 * version.in: Bump version to 8.3.50.DATE-git.
10397
143420fb
SM
103982019-02-26 Simon Marchi <simon.marchi@efficios.com>
10399
10400 * aix-thread.c (ptid_cmp): Remove unused variable.
10401 (get_signaled_thread): Likewise.
10402 (store_regs_user_thread): Likewise.
10403 (store_regs_kernel_thread): Likewise.
10404 (fetch_regs_kernel_thread): Remove shadowed variable.
10405
172fb711
AB
104062019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10407
10408 * features/riscv/32bit-cpu.xml: Add register numbers.
10409 * features/riscv/32bit-fpu.c: Regenerate.
10410 * features/riscv/32bit-fpu.xml: Add register numbers.
10411 * features/riscv/64bit-cpu.xml: Add register numbers.
10412 * features/riscv/64bit-fpu.c: Regenerate.
10413 * features/riscv/64bit-fpu.xml: Add register numbers.
10414
26c89782
KB
104152019-02-26 Kevin Buettner <kevinb@redhat.com>
10416
af54ade9 10417 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
10418 * python/py-value.c (convert_buffer_and_type_to_value): New
10419 function.
10420 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10421 Add support for handling an optional second argument. Call
10422 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
10423 * python/python-internal.h (Py_buffer_deleter): New struct.
10424 (Py_buffer_up): New typedef.
10425
0f58c9e8
JB
104262019-02-25 John Baldwin <jhb@FreeBSD.org>
10427
10428 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10429 instead of releasing ownership.
10430
0a0f4c01
JR
104312019-02-25 Jordan Rupprecht <rupprecht@google.com>
10432
10433 * dwarf2read.c (open_and_init_dwp_file): Call
10434 elf_numsections instead of bfd_count_sections to initialize
10435 dwp_file->num_sections.
10436
cd5a152c
TT
104372019-02-25 Tom Tromey <tromey@adacore.com>
10438
10439 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10440
8a6a8513
SDJ
104412019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10442
10443 * gcore.in: Add '--readnever' option when invoking GDB.
10444
04dcda9c
SM
104452019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10446
10447 * MAINTAINERS: Update my email address.
10448
07bc701d
SM
104492019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10450
10451 * build-id.c (build_id_to_debug_bfd_1): New function.
10452 (build_id_to_debug_bfd): Look for separate debug file in
10453 sysroot.
10454
c6f4a5d0
AB
104552019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10456
10457 * gdbarch.sh: Update the copyright year range that is placed into
10458 generated files.
10459
9600246d
KS
104602019-02-22 Keith Seitz <keiths@redhat.com>
10461
10462 PR symtab/23853
10463 * linespec.c (create_sals_line_offset): Search for the default
10464 symtab's filename instead of its fullname.
10465
7557a514
AH
104662019-02-21 Alan Hayward <alan.hayward@arm.com>
10467
10468 * NEWS: Update style defaults.
10469
ee2bcb0c
AH
104702019-02-21 Alan Hayward <alan.hayward@arm.com>
10471
10472 * main.c (captured_main_1): Disable styling in batch mode.
10473
0c95f9ed
TT
104742019-02-20 Tom Tromey <tom@tromey.com>
10475
10476 * symtab.c (symtab_symbol_info): Fix typos.
10477
c763b894
TT
104782019-02-20 Tom Tromey <tromey@adacore.com>
10479
10480 * findcmd.c (_initialize_mem_search): Use upper case for
10481 metasyntactic variables.
10482
0ef8a082
AH
104832019-02-20 Alan Hayward <alan.hayward@arm.com>
10484
10485 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10486 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10487
6caa91b6
SM
104882019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10489
10490 * top.h (source_file_name): Change to std::string.
10491 * top.c (source_file_name): Likewise.
10492 (command_line_input): Adjust.
10493 * cli/cli-script.c (script_from_file): Adjust.
10494
98814c6c
TT
104952019-02-19 Tom Tromey <tromey@adacore.com>
10496
10497 * ravenscar-thread.c
10498 (ravenscar_thread_target::update_thread_list): Don't call
10499 ada_build_task_list.
10500 * ada-lang.h (ada_build_task_list): Don't declare.
10501 * ada-tasks.c (struct ada_tasks_inferior_data)
10502 <task_list_valid_p>: Now bool.
10503 (read_known_tasks, ada_task_list_changed)
10504 (ada_tasks_invalidate_inferior_data): Update.
10505 (read_known_tasks_array): Return bool.
10506 (read_known_tasks_list): Likewise.
10507 (read_known_tasks): Return void.
10508 (ada_build_task_list): Now static.
10509
70cd633e
AB
105102019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10511
10512 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10513 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10514
040b3e95
PW
105152019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10516
10517 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10518 variant for ada_tasks_pspace_data_handle and
10519 ada_tasks_inferior_data_handle.
10520 (ada_tasks_pspace_data_cleanup): New function.
10521 (ada_tasks_inferior_data_cleanup): New function.
10522
9409233b
TT
105232019-02-17 Tom Tromey <tom@tromey.com>
10524
10525 * macrotab.h (macro_source_fullname): Return a std::string.
10526 * macrotab.c (macro_include, check_for_redefinition)
10527 (macro_undef, macro_lookup_definition, foreach_macro)
10528 (foreach_macro_in_scope): Update.
10529 (macro_source_fullname): Return a std::string.
10530 * macrocmd.c (show_pp_source_pos): Update.
10531
6506371f
TT
105322019-02-17 Tom Tromey <tom@tromey.com>
10533
10534 * macrocmd.c (show_pp_source_pos): Style the file names.
10535
0c820d67
TT
105362019-02-17 Tom Tromey <tom@tromey.com>
10537
10538 PR tui/24197:
10539 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10540
a0087920
TT
105412019-02-17 Tom Tromey <tom@tromey.com>
10542
10543 * ada-lang.c (user_select_syms): Use filtered printing.
10544 * utils.c (wrap_style): New global.
10545 (desired_style): Remove.
10546 (emit_style_escape): Add stream parameter.
10547 (set_output_style, reset_terminal_style, prompt_for_continue):
10548 Update.
10549 (flush_wrap_buffer): Only flush gdb_stdout.
10550 (wrap_here): Set wrap_style.
10551 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10552 treat escape sequences as a character. Change when wrap buffer is
10553 flushed.
10554 (fputs_styled): Do not set the output style when the default is
10555 requested.
10556 * ui-style.h (struct ui_file_style) <is_default>: New method.
10557 * source.c (print_source_lines_base): Emit escape sequences in one
10558 piece.
10559
75ba10dc
JB
105602019-02-17 Joel Brobecker <brobecker@adacore.com>
10561
10562 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10563 integers and enumeration types.
10564
a2cd4f14
JB
105652019-02-17 Joel Brobecker <brobecker@adacore.com>
10566
10567 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10568 instead of lookup_symbol_in_language
10569 (do_exact_match): New function.
10570 (ada_get_symbol_name_matcher): Return do_exact_match when
10571 doing a verbatim match.
10572
485b851b
TT
105732019-02-15 Tom Tromey <tromey@adacore.com>
10574
10575 * ravenscar-thread.c (ravenscar_thread_target::resume)
10576 (ravenscar_thread_target::wait): Special case wildcard requests.
10577
0b790b1e
TT
105782019-02-15 Tom Tromey <tromey@adacore.com>
10579
10580 * ravenscar-thread.c (base_ptid): Remove.
10581 (struct ravenscar_thread_target) <close>: New method.
10582 <m_base_ptid>: New member.
10583 <update_inferior_ptid, active_task, task_is_currently_active,
10584 runtime_initialized>: Declare methods.
10585 <ravenscar_thread_target>: Add constructor.
10586 (ravenscar_thread_target::task_is_currently_active)
10587 (ravenscar_thread_target::update_inferior_ptid)
10588 (ravenscar_runtime_initialized): Rename. Now methods.
10589 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10590 (ravenscar_thread_target::update_thread_list): Update.
10591 (ravenscar_thread_target::active_task): Now method.
10592 (ravenscar_thread_target::store_registers)
10593 (ravenscar_thread_target::prepare_to_store)
10594 (ravenscar_thread_target::prepare_to_store)
10595 (ravenscar_thread_target::mourn_inferior): Update.
10596 (ravenscar_inferior_created): Use "new" to create target.
10597 (ravenscar_thread_target::get_ada_task_ptid): Update.
10598 (_initialize_ravenscar): Don't initialize base_ptid.
10599 (ravenscar_ops): Remove global.
10600
dea57a62
TT
106012019-02-15 Tom Tromey <tromey@adacore.com>
10602
10603 * target.h (push_target): Declare new overload.
10604 * target.c (push_target): New overload, taking an rvalue reference.
10605 * remote.c (remote_target::open_1): Use push_target overload.
10606 * corelow.c (core_target_open): Use push_target overload.
10607
989f3c58
TT
106082019-02-15 Tom Tromey <tromey@adacore.com>
10609
10610 * ravenscar-thread.c (is_ravenscar_task)
10611 (ravenscar_task_is_currently_active): Return bool.
10612 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10613 (_initialize_ravenscar): Remove "(void)".
10614 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10615 Return bool.
10616
6cbcc006
TT
106172019-02-15 Tom Tromey <tromey@adacore.com>
10618
10619 * ravenscar-thread.c (ravenscar_runtime_initializer)
10620 (has_ravenscar_runtime, get_running_thread_id)
10621 (ravenscar_thread_target::resume): Fix indentation.
10622
7657f14d
TT
106232019-02-15 Tom Tromey <tromey@adacore.com>
10624
10625 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10626 from ravenscar_arch_ops.
10627 (sparc_ravenscar_ops::fetch_registers)
10628 (sparc_ravenscar_ops::store_registers): Now methods.
10629 (sparc_ravenscar_prepare_to_store): Remove.
10630 (sparc_ravenscar_ops): Redefine.
10631 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10632 methods and destructor. Remove members.
10633 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10634 (ravenscar_thread_target::store_registers)
10635 (ravenscar_thread_target::prepare_to_store): Update.
10636 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10637 Remove.
10638 (struct ppc_ravenscar_powerpc_ops): Derive from
10639 ravenscar_arch_ops.
10640 (ppc_ravenscar_powerpc_ops::fetch_registers)
10641 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10642 (ppc_ravenscar_powerpc_ops): Redefine.
10643 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10644 (ppc_ravenscar_e500_ops::fetch_registers)
10645 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10646 (ppc_ravenscar_e500_ops): Redefine.
10647 * aarch64-ravenscar-thread.c
10648 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10649 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10650 (aarch64_ravenscar_fetch_registers)
10651 (aarch64_ravenscar_store_registers): Now methods.
10652 (aarch64_ravenscar_ops): Redefine.
10653
5b6ea500
TT
106542019-02-15 Tom Tromey <tromey@adacore.com>
10655
10656 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10657 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10658 (ravenscar_thread_target::stopped_by_watchpoint)
10659 (ravenscar_thread_target::stopped_data_address)
10660 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10661
e397fd39
TT
106622019-02-15 Tom Tromey <tromey@adacore.com>
10663
10664 * ravenscar-thread.c: Fix some typos.
10665
cc12f4a8
TT
106662019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10667 Tom Tromey <tromey@adacore.com>
10668
10669 * ada-lang.c (ada_exception_sal): Change addr_string to a
10670 std::string.
10671 (create_ada_exception_catchpoint): Update.
10672
5f486660
TT
106732019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10674 Tom Tromey <tromey@adacore.com>
10675
10676 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10677 (bp_location_ops): Remove.
10678 (base_breakpoint_allocate_location): Update.
10679 (free_bp_location): Update.
10680 * ada-lang.c (class ada_catchpoint_location)
10681 <ada_catchpoint_location>: Remove ops parameter.
10682 (ada_catchpoint_location_dtor): Remove.
10683 (ada_catchpoint_location_ops): Remove.
10684 (allocate_location_exception): Update.
10685 * breakpoint.h (struct bp_location_ops): Remove.
10686 (class bp_location) <bp_location>: Remove bp_location_ops
10687 parameter.
10688 <~bp_location>: Add destructor.
10689 <ops>: Remove.
10690
b671c7fb
TS
106912019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10692 Pedro Alves <palves@redhat.com>
10693
10694 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10695 'PATH_MAX'.
10696
8071c5ce
DM
106972019-02-14 David Michael <fedora.dm0@gmail.com>
10698 Samuel Thibault <samuel.thibault@gnu.org>
10699 Thomas Schwinge <thomas@codesourcery.com>
10700
10701 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10702 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10703
b1041ae0
TS
107042019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10705
924514e1
TS
10706 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10707 (check_empty): Use "const char *".
10708
c29ee8d4
TS
10709 * gnu-nat.c (gnu_nat_target::detach): Instead of
10710 'detach_inferior (pid)' call
10711 'detach_inferior (find_inferior_pid (pid))'.
10712
6c6ef69f
TS
10713 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10714 'nat/fork-inferior.o'.
10715 * gnu-nat.c: #include "nat/fork-inferior.h".
10716
2d0a338c
TS
10717 * gnu-nat.c (gnu_nat_target::detach): Instead of
10718 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10719 * gnu-nat.h: #include "inf-child.h".
10720 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10721 'i386_gnu_nat_target::fetch_registers'.
10722 (gnu_store_registers): Rename/move to
10723 'i386_gnu_nat_target::store_registers'.
10724
cabb5f06
TS
10725 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10726 * gnu-nat.h (mach_thread_info): New function.
10727 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10728
b1041ae0
TS
10729 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10730
2988d01e
KF
107312019-02-14 Frederic Konrad <konrad@adacore.com>
10732
10733 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10734
c559d709
JB
107352019-02-14 Joel Brobecker <brobecker@adacore.com>
10736
10737 * windows-nat.c (windows_add_thread): Add new parameter
10738 "main_thread_p" with default value set to false. Update
10739 function documentation as well as all callers.
10740 (windows_delete_thread): Likewise.
10741 (fake_create_process): Update call to windows_add_thread.
10742 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10743 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10744 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10745 call to windows_delete_thread.
10746
007024cc
SM
107472019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10748
10749 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10750
f62318e9
JB
107512019-02-12 John Baldwin <jhb@FreeBSD.org>
10752
10753 * symfile.c (find_separate_debug_file): Use canonical path of
10754 sysroot with child_path instead of gdb_sysroot if it is valid.
10755
cd4b7848
JB
107562019-02-12 John Baldwin <jhb@FreeBSD.org>
10757
10758 * symfile.c (find_separate_debug_file): Use child_path to
10759 determine if an object file is under a sysroot.
10760
efac4bfe
JB
107612019-02-12 John Baldwin <jhb@FreeBSD.org>
10762
10763 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10764 unittests/child-path-selftests.c.
10765 * common/pathstuff.c (child_path): New function.
10766 * common/pathstuff.h (child_path): New prototype.
10767 * unittests/child-path-selftests.c: New file.
10768
402d2bfe
JB
107692019-02-12 John Baldwin <jhb@FreeBSD.org>
10770
10771 * symfile.c (find_separate_debug_file): Look for separate debug
10772 files in debug directories under the sysroot.
10773
1ed9f74e
PW
107742019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10775
10776 * symtab.h (struct minimal_symbol data_p): New const method.
10777 (struct minimal_symbol text_p): Likewise.
10778 * symtab.c (output_source_filename): Use file name style
10779 to print file name.
10780 (print_symbol_info): Likewise.
10781 (print_msymbol_info): Use address style to print addresses.
10782 Use function name style to print executable text symbols.
10783 (expand_symtab_containing_pc): Use data_p.
10784 (find_pc_sect_compunit_symtab): Likewise.
10785
2636d81d
PW
107862019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10787
10788 * breakpoint.c (describe_other_breakpoints): Use address style
10789 to print addresses.
10790 (say_where): Likewise.
10791
ac8c53cc
PW
107922019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10793
10794 * ada-typeprint.c (print_func_type): Print function name
10795 style to print function name.
10796 * c-typeprint.c (c_print_type_1): Likewise.
10797
ea638c43
AH
107982019-02-11 Alan Hayward <alan.hayward@arm.com>
10799
10800 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10801 for execve.
10802
ab759ca8
PW
108032019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10804
10805 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10806 type_stack.
10807
aff29d1c
JB
108082019-02-10 Joel Brobecker <brobecker@adacore.com>
10809
10810 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10811 TYPE_CODE_REF types.
10812
617126bc
JW
108132019-02-08 Jim Wilson <jimw@sifive.com>
10814
10815 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10816 (riscv_linux_fregset): New.
10817 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10818
46e3ed7f
TT
108192019-02-07 Tom Tromey <tom@tromey.com>
10820
10821 * thread.c (thread_cancel_execution_command): Update.
10822 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10823 methods.
10824 (struct thread_fsm_ops): Remove.
10825 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10826 (thread_fsm_should_stop, thread_fsm_return_value)
10827 (thread_fsm_set_finished, thread_fsm_finished_p)
10828 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10829 Don't declare.
10830 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10831 * infrun.c (clear_proceed_status_thread)
10832 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10833 (print_stop_event): Update.
10834 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10835 Add constructor.
10836 (step_command_fsm_ops): Remove.
10837 (new_step_command_fsm): Remove.
10838 (step_1): Update.
10839 (step_command_fsm::should_stop): Rename from
10840 step_command_fsm_should_stop.
10841 (step_command_fsm::clean_up): Rename from
10842 step_command_fsm_clean_up.
10843 (step_command_fsm::do_async_reply_reason): Rename from
10844 step_command_fsm_async_reply_reason.
10845 (struct until_next_fsm): Inherit from thread_fsm. Add
10846 constructor.
10847 (until_next_fsm_ops): Remove.
10848 (new_until_next_fsm): Remove.
10849 (until_next_fsm::should_stop): Rename from
10850 until_next_fsm_should_stop.
10851 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10852 (until_next_fsm::do_async_reply_reason): Rename from
10853 until_next_fsm_async_reply_reason.
10854 (struct finish_command_fsm): Inherit from thread_fsm. Add
10855 constructor. Change type of breakpoint.
10856 (finish_command_fsm_ops): Remove.
10857 (new_finish_command_fsm): Remove.
10858 (finish_command_fsm::should_stop): Rename from
10859 finish_command_fsm_should_stop.
10860 (finish_command_fsm::clean_up): Rename from
10861 finish_command_fsm_clean_up.
10862 (finish_command_fsm::return_value): Rename from
10863 finish_command_fsm_return_value.
10864 (finish_command_fsm::do_async_reply_reason): Rename from
10865 finish_command_fsm_async_reply_reason.
10866 (finish_command): Update.
10867 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10868 Add constructor.
10869 (call_thread_fsm_ops): Remove.
10870 (call_thread_fsm::call_thread_fsm): Rename from
10871 new_call_thread_fsm.
10872 (call_thread_fsm::should_stop): Rename from
10873 call_thread_fsm_should_stop.
10874 (call_thread_fsm::should_notify_stop): Rename from
10875 call_thread_fsm_should_notify_stop.
10876 (run_inferior_call, call_function_by_hand_dummy): Update.
10877 * cli/cli-interp.c (should_print_stop_to_console): Update.
10878 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10879 Add constructor. Change type of location_breakpoint,
10880 caller_breakpoint.
10881 (until_break_fsm_ops): Remove.
10882 (new_until_break_fsm): Remove.
10883 (until_break_fsm::should_stop): Rename from
10884 until_break_fsm_should_stop.
10885 (until_break_fsm::clean_up): Rename from
10886 until_break_fsm_clean_up.
10887 (until_break_fsm::do_async_reply_reason): Rename from
10888 until_break_fsm_async_reply_reason.
10889 (until_break_command): Update.
10890 * thread-fsm.c: Remove.
10891 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10892
1a5c2598
TT
108932019-02-07 Tom Tromey <tom@tromey.com>
10894
10895 * yy-remap.h: Add include guard.
10896 * xtensa-tdep.h: Add include guard.
10897 * xcoffread.h: Rename include guard.
10898 * varobj-iter.h: Add include guard.
10899 * tui/tui.h: Rename include guard.
10900 * tui/tui-winsource.h: Rename include guard.
10901 * tui/tui-wingeneral.h: Rename include guard.
10902 * tui/tui-windata.h: Rename include guard.
10903 * tui/tui-win.h: Rename include guard.
10904 * tui/tui-stack.h: Rename include guard.
10905 * tui/tui-source.h: Rename include guard.
10906 * tui/tui-regs.h: Rename include guard.
10907 * tui/tui-out.h: Rename include guard.
10908 * tui/tui-layout.h: Rename include guard.
10909 * tui/tui-io.h: Rename include guard.
10910 * tui/tui-hooks.h: Rename include guard.
10911 * tui/tui-file.h: Rename include guard.
10912 * tui/tui-disasm.h: Rename include guard.
10913 * tui/tui-data.h: Rename include guard.
10914 * tui/tui-command.h: Rename include guard.
10915 * tic6x-tdep.h: Add include guard.
10916 * target/waitstatus.h: Rename include guard.
10917 * target/wait.h: Rename include guard.
10918 * target/target.h: Rename include guard.
10919 * target/resume.h: Rename include guard.
10920 * target-float.h: Rename include guard.
10921 * stabsread.h: Add include guard.
10922 * rs6000-tdep.h: Add include guard.
10923 * riscv-fbsd-tdep.h: Add include guard.
10924 * regformats/regdef.h: Rename include guard.
10925 * record.h: Rename include guard.
10926 * python/python.h: Rename include guard.
10927 * python/python-internal.h: Rename include guard.
10928 * python/py-stopevent.h: Rename include guard.
10929 * python/py-ref.h: Rename include guard.
10930 * python/py-record.h: Rename include guard.
10931 * python/py-record-full.h: Rename include guard.
10932 * python/py-record-btrace.h: Rename include guard.
10933 * python/py-instruction.h: Rename include guard.
10934 * python/py-events.h: Rename include guard.
10935 * python/py-event.h: Rename include guard.
10936 * procfs.h: Add include guard.
10937 * proc-utils.h: Add include guard.
10938 * p-lang.h: Add include guard.
10939 * or1k-tdep.h: Rename include guard.
10940 * observable.h: Rename include guard.
10941 * nto-tdep.h: Rename include guard.
10942 * nat/x86-linux.h: Rename include guard.
10943 * nat/x86-linux-dregs.h: Rename include guard.
10944 * nat/x86-gcc-cpuid.h: Add include guard.
10945 * nat/x86-dregs.h: Rename include guard.
10946 * nat/x86-cpuid.h: Rename include guard.
10947 * nat/ppc-linux.h: Rename include guard.
10948 * nat/mips-linux-watch.h: Rename include guard.
10949 * nat/linux-waitpid.h: Rename include guard.
10950 * nat/linux-ptrace.h: Rename include guard.
10951 * nat/linux-procfs.h: Rename include guard.
10952 * nat/linux-osdata.h: Rename include guard.
10953 * nat/linux-nat.h: Rename include guard.
10954 * nat/linux-namespaces.h: Rename include guard.
10955 * nat/linux-btrace.h: Rename include guard.
10956 * nat/glibc_thread_db.h: Rename include guard.
10957 * nat/gdb_thread_db.h: Rename include guard.
10958 * nat/gdb_ptrace.h: Rename include guard.
10959 * nat/fork-inferior.h: Rename include guard.
10960 * nat/amd64-linux-siginfo.h: Rename include guard.
10961 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10962 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10963 * nat/aarch64-linux.h: Rename include guard.
10964 * nat/aarch64-linux-hw-point.h: Rename include guard.
10965 * mn10300-tdep.h: Add include guard.
10966 * mips-linux-tdep.h: Add include guard.
10967 * mi/mi-parse.h: Rename include guard.
10968 * mi/mi-out.h: Rename include guard.
10969 * mi/mi-main.h: Rename include guard.
10970 * mi/mi-interp.h: Rename include guard.
10971 * mi/mi-getopt.h: Rename include guard.
10972 * mi/mi-console.h: Rename include guard.
10973 * mi/mi-common.h: Rename include guard.
10974 * mi/mi-cmds.h: Rename include guard.
10975 * mi/mi-cmd-break.h: Rename include guard.
10976 * m2-lang.h: Add include guard.
10977 * location.h: Rename include guard.
10978 * linux-record.h: Rename include guard.
10979 * linux-nat.h: Add include guard.
10980 * linux-fork.h: Add include guard.
10981 * i386-darwin-tdep.h: Rename include guard.
10982 * hppa-linux-offsets.h: Add include guard.
10983 * guile/guile.h: Rename include guard.
10984 * guile/guile-internal.h: Rename include guard.
10985 * gnu-nat.h: Rename include guard.
10986 * gdb-stabs.h: Rename include guard.
10987 * frv-tdep.h: Add include guard.
10988 * f-lang.h: Add include guard.
10989 * event-loop.h: Add include guard.
10990 * darwin-nat.h: Rename include guard.
10991 * cp-abi.h: Rename include guard.
10992 * config/sparc/nm-sol2.h: Rename include guard.
10993 * config/nm-nto.h: Rename include guard.
10994 * config/nm-linux.h: Add include guard.
10995 * config/i386/nm-i386gnu.h: Rename include guard.
10996 * config/djgpp/nl_types.h: Rename include guard.
10997 * config/djgpp/langinfo.h: Rename include guard.
10998 * compile/gcc-cp-plugin.h: Add include guard.
10999 * compile/gcc-c-plugin.h: Add include guard.
11000 * compile/compile.h: Rename include guard.
11001 * compile/compile-object-run.h: Rename include guard.
11002 * compile/compile-object-load.h: Rename include guard.
11003 * compile/compile-internal.h: Rename include guard.
11004 * compile/compile-cplus.h: Rename include guard.
11005 * compile/compile-c.h: Rename include guard.
11006 * common/xml-utils.h: Rename include guard.
11007 * common/x86-xstate.h: Rename include guard.
11008 * common/version.h: Rename include guard.
11009 * common/vec.h: Rename include guard.
11010 * common/tdesc.h: Rename include guard.
11011 * common/selftest.h: Rename include guard.
11012 * common/scoped_restore.h: Rename include guard.
11013 * common/scoped_mmap.h: Rename include guard.
11014 * common/scoped_fd.h: Rename include guard.
11015 * common/safe-iterator.h: Rename include guard.
11016 * common/run-time-clock.h: Rename include guard.
11017 * common/refcounted-object.h: Rename include guard.
11018 * common/queue.h: Rename include guard.
11019 * common/ptid.h: Rename include guard.
11020 * common/print-utils.h: Rename include guard.
11021 * common/preprocessor.h: Rename include guard.
11022 * common/pathstuff.h: Rename include guard.
11023 * common/observable.h: Rename include guard.
11024 * common/netstuff.h: Rename include guard.
11025 * common/job-control.h: Rename include guard.
11026 * common/host-defs.h: Rename include guard.
11027 * common/gdb_wait.h: Rename include guard.
11028 * common/gdb_vecs.h: Rename include guard.
11029 * common/gdb_unlinker.h: Rename include guard.
11030 * common/gdb_unique_ptr.h: Rename include guard.
11031 * common/gdb_tilde_expand.h: Rename include guard.
11032 * common/gdb_sys_time.h: Rename include guard.
11033 * common/gdb_string_view.h: Rename include guard.
11034 * common/gdb_splay_tree.h: Rename include guard.
11035 * common/gdb_setjmp.h: Rename include guard.
11036 * common/gdb_ref_ptr.h: Rename include guard.
11037 * common/gdb_optional.h: Rename include guard.
11038 * common/gdb_locale.h: Rename include guard.
11039 * common/gdb_assert.h: Rename include guard.
11040 * common/filtered-iterator.h: Rename include guard.
11041 * common/filestuff.h: Rename include guard.
11042 * common/fileio.h: Rename include guard.
11043 * common/environ.h: Rename include guard.
11044 * common/common-utils.h: Rename include guard.
11045 * common/common-types.h: Rename include guard.
11046 * common/common-regcache.h: Rename include guard.
11047 * common/common-inferior.h: Rename include guard.
11048 * common/common-gdbthread.h: Rename include guard.
11049 * common/common-exceptions.h: Rename include guard.
11050 * common/common-defs.h: Rename include guard.
11051 * common/common-debug.h: Rename include guard.
11052 * common/cleanups.h: Rename include guard.
11053 * common/buffer.h: Rename include guard.
11054 * common/btrace-common.h: Rename include guard.
11055 * common/break-common.h: Rename include guard.
11056 * cli/cli-utils.h: Rename include guard.
11057 * cli/cli-style.h: Rename include guard.
11058 * cli/cli-setshow.h: Rename include guard.
11059 * cli/cli-script.h: Rename include guard.
11060 * cli/cli-interp.h: Rename include guard.
11061 * cli/cli-decode.h: Rename include guard.
11062 * cli/cli-cmds.h: Rename include guard.
11063 * charset-list.h: Add include guard.
11064 * buildsym-legacy.h: Rename include guard.
11065 * bfin-tdep.h: Add include guard.
11066 * ax.h: Rename include guard.
11067 * arm-linux-tdep.h: Add include guard.
11068 * arm-fbsd-tdep.h: Add include guard.
11069 * arch/xtensa.h: Rename include guard.
11070 * arch/tic6x.h: Add include guard.
11071 * arch/i386.h: Add include guard.
11072 * arch/arm.h: Rename include guard.
11073 * arch/arm-linux.h: Rename include guard.
11074 * arch/arm-get-next-pcs.h: Rename include guard.
11075 * arch/amd64.h: Add include guard.
11076 * arch/aarch64-insn.h: Rename include guard.
11077 * arch-utils.h: Rename include guard.
11078 * annotate.h: Add include guard.
11079 * amd64-darwin-tdep.h: Rename include guard.
11080 * aarch64-linux-tdep.h: Add include guard.
11081 * aarch64-fbsd-tdep.h: Add include guard.
11082 * aarch32-linux-nat.h: Add include guard.
11083
ab9268d2
PW
110842019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11085
11086 * macrotab.c (macro_define_internal): New function that
11087 factorizes macro_define_object_internal and macro_define_function
11088 code.
11089 (macro_define_object_internal): Use macro_define_internal.
11090 (macro_define_function): Likewise.
11091
bb0da2b4
PW
110922019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11093
11094 * macrocmd.c (extract_identifier): Return
11095 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11096 callers.
11097
424eb552
JB
110982019-02-06 John Baldwin <jhb@FreeBSD.org>
11099
11100 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11101
1688cb29
TT
111022019-02-05 Tom Tromey <tom@tromey.com>
11103
11104 * target.c (target_stack::unpush): Move assertion earlier.
11105
b5eba2d8
TT
111062019-01-30 Tom Tromey <tom@tromey.com>
11107
11108 PR python/23615:
11109 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11110 (gdbpy_parse_and_eval): Likewise.
11111 * python/python-internal.h (gdbpy_allow_threads): New class.
11112
7054e2ff
JB
111132019-01-28 John Baldwin <jhb@FreeBSD.org>
11114
11115 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11116 (aarch64_fbsd_fpregmap): Move earlier.
11117 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11118 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11119 instead of individual calls to trad_frame_set_reg_addr.
11120 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11121 earlier.
11122 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11123 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11124 instead of individual calls to trad_frame_set_reg_addr.
11125
36c25ffa
AH
111262019-01-28 Alan Hayward <alan.hayward@arm.com>
11127
11128 * CONTRIBUTE: Replace contribution list with wiki link.
11129
a0707f3c
TT
111302019-01-25 Tom Tromey <tom@tromey.com>
11131
11132 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11133
0747795c
TT
111342019-01-25 Tom Tromey <tom@tromey.com>
11135
11136 * xtensa-linux-nat.c: Fix common/ includes.
11137 * xml-support.h: Fix common/ includes.
11138 * xml-support.c: Fix common/ includes.
11139 * x86-linux-nat.c: Fix common/ includes.
11140 * windows-nat.c: Fix common/ includes.
11141 * varobj.h: Fix common/ includes.
11142 * varobj.c: Fix common/ includes.
11143 * value.c: Fix common/ includes.
11144 * valops.c: Fix common/ includes.
11145 * utils.c: Fix common/ includes.
11146 * unittests/xml-utils-selftests.c: Fix common/ includes.
11147 * unittests/utils-selftests.c: Fix common/ includes.
11148 * unittests/unpack-selftests.c: Fix common/ includes.
11149 * unittests/tracepoint-selftests.c: Fix common/ includes.
11150 * unittests/style-selftests.c: Fix common/ includes.
11151 * unittests/string_view-selftests.c: Fix common/ includes.
11152 * unittests/scoped_restore-selftests.c: Fix common/ includes.
11153 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11154 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11155 * unittests/rsp-low-selftests.c: Fix common/ includes.
11156 * unittests/parse-connection-spec-selftests.c: Fix common/
11157 includes.
11158 * unittests/optional-selftests.c: Fix common/ includes.
11159 * unittests/offset-type-selftests.c: Fix common/ includes.
11160 * unittests/observable-selftests.c: Fix common/ includes.
11161 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11162 * unittests/memrange-selftests.c: Fix common/ includes.
11163 * unittests/memory-map-selftests.c: Fix common/ includes.
11164 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11165 * unittests/function-view-selftests.c: Fix common/ includes.
11166 * unittests/environ-selftests.c: Fix common/ includes.
11167 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11168 * unittests/common-utils-selftests.c: Fix common/ includes.
11169 * unittests/cli-utils-selftests.c: Fix common/ includes.
11170 * unittests/array-view-selftests.c: Fix common/ includes.
11171 * ui-file.c: Fix common/ includes.
11172 * tui/tui-io.c: Fix common/ includes.
11173 * tracepoint.h: Fix common/ includes.
11174 * tracepoint.c: Fix common/ includes.
11175 * tracefile-tfile.c: Fix common/ includes.
11176 * top.h: Fix common/ includes.
11177 * top.c: Fix common/ includes.
11178 * thread.c: Fix common/ includes.
11179 * target/waitstatus.h: Fix common/ includes.
11180 * target/waitstatus.c: Fix common/ includes.
11181 * target.h: Fix common/ includes.
11182 * target.c: Fix common/ includes.
11183 * target-memory.c: Fix common/ includes.
11184 * target-descriptions.c: Fix common/ includes.
11185 * symtab.h: Fix common/ includes.
11186 * symfile.c: Fix common/ includes.
11187 * stap-probe.c: Fix common/ includes.
11188 * spu-linux-nat.c: Fix common/ includes.
11189 * sparc-nat.c: Fix common/ includes.
11190 * source.c: Fix common/ includes.
11191 * solib.c: Fix common/ includes.
11192 * solib-target.c: Fix common/ includes.
11193 * ser-unix.c: Fix common/ includes.
11194 * ser-tcp.c: Fix common/ includes.
11195 * ser-pipe.c: Fix common/ includes.
11196 * ser-base.c: Fix common/ includes.
11197 * selftest-arch.c: Fix common/ includes.
11198 * s12z-tdep.c: Fix common/ includes.
11199 * rust-exp.y: Fix common/ includes.
11200 * rs6000-aix-tdep.c: Fix common/ includes.
11201 * riscv-tdep.c: Fix common/ includes.
11202 * remote.c: Fix common/ includes.
11203 * remote-notif.h: Fix common/ includes.
11204 * remote-fileio.h: Fix common/ includes.
11205 * remote-fileio.c: Fix common/ includes.
11206 * regcache.h: Fix common/ includes.
11207 * regcache.c: Fix common/ includes.
11208 * record-btrace.c: Fix common/ includes.
11209 * python/python.c: Fix common/ includes.
11210 * python/py-type.c: Fix common/ includes.
11211 * python/py-inferior.c: Fix common/ includes.
11212 * progspace.h: Fix common/ includes.
11213 * producer.c: Fix common/ includes.
11214 * procfs.c: Fix common/ includes.
11215 * proc-api.c: Fix common/ includes.
11216 * printcmd.c: Fix common/ includes.
11217 * ppc-linux-nat.c: Fix common/ includes.
11218 * parser-defs.h: Fix common/ includes.
11219 * osdata.c: Fix common/ includes.
11220 * obsd-nat.c: Fix common/ includes.
11221 * nat/x86-linux.c: Fix common/ includes.
11222 * nat/x86-linux-dregs.c: Fix common/ includes.
11223 * nat/x86-dregs.h: Fix common/ includes.
11224 * nat/x86-dregs.c: Fix common/ includes.
11225 * nat/ppc-linux.c: Fix common/ includes.
11226 * nat/mips-linux-watch.h: Fix common/ includes.
11227 * nat/mips-linux-watch.c: Fix common/ includes.
11228 * nat/linux-waitpid.c: Fix common/ includes.
11229 * nat/linux-ptrace.h: Fix common/ includes.
11230 * nat/linux-ptrace.c: Fix common/ includes.
11231 * nat/linux-procfs.c: Fix common/ includes.
11232 * nat/linux-personality.c: Fix common/ includes.
11233 * nat/linux-osdata.c: Fix common/ includes.
11234 * nat/linux-namespaces.c: Fix common/ includes.
11235 * nat/linux-btrace.h: Fix common/ includes.
11236 * nat/linux-btrace.c: Fix common/ includes.
11237 * nat/fork-inferior.c: Fix common/ includes.
11238 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11239 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11240 * nat/aarch64-linux.c: Fix common/ includes.
11241 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11242 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11243 * namespace.h: Fix common/ includes.
11244 * mips-linux-tdep.c: Fix common/ includes.
11245 * minsyms.c: Fix common/ includes.
11246 * mi/mi-parse.h: Fix common/ includes.
11247 * mi/mi-main.c: Fix common/ includes.
11248 * mi/mi-cmd-env.c: Fix common/ includes.
11249 * memrange.h: Fix common/ includes.
11250 * memattr.c: Fix common/ includes.
11251 * maint.h: Fix common/ includes.
11252 * maint.c: Fix common/ includes.
11253 * main.c: Fix common/ includes.
11254 * machoread.c: Fix common/ includes.
11255 * location.c: Fix common/ includes.
11256 * linux-thread-db.c: Fix common/ includes.
11257 * linux-nat.c: Fix common/ includes.
11258 * linux-fork.c: Fix common/ includes.
11259 * inline-frame.c: Fix common/ includes.
11260 * infrun.c: Fix common/ includes.
11261 * inflow.c: Fix common/ includes.
11262 * inferior.h: Fix common/ includes.
11263 * inferior.c: Fix common/ includes.
11264 * infcmd.c: Fix common/ includes.
11265 * inf-ptrace.c: Fix common/ includes.
11266 * inf-child.c: Fix common/ includes.
11267 * ia64-linux-nat.c: Fix common/ includes.
11268 * i387-tdep.c: Fix common/ includes.
11269 * i386-tdep.c: Fix common/ includes.
11270 * i386-linux-tdep.c: Fix common/ includes.
11271 * i386-linux-nat.c: Fix common/ includes.
11272 * i386-go32-tdep.c: Fix common/ includes.
11273 * i386-fbsd-tdep.c: Fix common/ includes.
11274 * i386-fbsd-nat.c: Fix common/ includes.
11275 * guile/scm-type.c: Fix common/ includes.
11276 * guile/guile.c: Fix common/ includes.
11277 * go32-nat.c: Fix common/ includes.
11278 * gnu-nat.c: Fix common/ includes.
11279 * gdbthread.h: Fix common/ includes.
11280 * gdbarch-selftests.c: Fix common/ includes.
11281 * gdb_usleep.c: Fix common/ includes.
11282 * gdb_select.h: Fix common/ includes.
11283 * gdb_bfd.c: Fix common/ includes.
11284 * gcore.c: Fix common/ includes.
11285 * fork-child.c: Fix common/ includes.
11286 * findvar.c: Fix common/ includes.
11287 * fbsd-nat.c: Fix common/ includes.
11288 * event-top.c: Fix common/ includes.
11289 * event-loop.c: Fix common/ includes.
11290 * dwarf2read.c: Fix common/ includes.
11291 * dwarf2loc.c: Fix common/ includes.
11292 * dwarf2-frame.c: Fix common/ includes.
11293 * dwarf-index-cache.c: Fix common/ includes.
11294 * dtrace-probe.c: Fix common/ includes.
11295 * disasm-selftests.c: Fix common/ includes.
11296 * defs.h: Fix common/ includes.
11297 * csky-tdep.c: Fix common/ includes.
11298 * cp-valprint.c: Fix common/ includes.
11299 * cp-support.h: Fix common/ includes.
11300 * cp-support.c: Fix common/ includes.
11301 * corelow.c: Fix common/ includes.
11302 * completer.h: Fix common/ includes.
11303 * completer.c: Fix common/ includes.
11304 * compile/compile.c: Fix common/ includes.
11305 * compile/compile-loc2c.c: Fix common/ includes.
11306 * compile/compile-cplus-types.c: Fix common/ includes.
11307 * compile/compile-cplus-symbols.c: Fix common/ includes.
11308 * command.h: Fix common/ includes.
11309 * cli/cli-dump.c: Fix common/ includes.
11310 * cli/cli-cmds.c: Fix common/ includes.
11311 * charset.c: Fix common/ includes.
11312 * build-id.c: Fix common/ includes.
11313 * btrace.h: Fix common/ includes.
11314 * btrace.c: Fix common/ includes.
11315 * breakpoint.h: Fix common/ includes.
11316 * breakpoint.c: Fix common/ includes.
11317 * ax.h:
11318 (enum agent_op): Fix common/ includes.
11319 * ax-general.c (struct aop_map): Fix common/ includes.
11320 * ax-gdb.c: Fix common/ includes.
11321 * auxv.c: Fix common/ includes.
11322 * auto-load.c: Fix common/ includes.
11323 * arm-tdep.c: Fix common/ includes.
11324 * arch/riscv.c: Fix common/ includes.
11325 * arch/ppc-linux-common.c: Fix common/ includes.
11326 * arch/i386.c: Fix common/ includes.
11327 * arch/arm.c: Fix common/ includes.
11328 * arch/arm-linux.c: Fix common/ includes.
11329 * arch/arm-get-next-pcs.c: Fix common/ includes.
11330 * arch/amd64.c: Fix common/ includes.
11331 * arch/aarch64.c: Fix common/ includes.
11332 * arch/aarch64-insn.c: Fix common/ includes.
11333 * arch-utils.c: Fix common/ includes.
11334 * amd64-windows-tdep.c: Fix common/ includes.
11335 * amd64-tdep.c: Fix common/ includes.
11336 * amd64-sol2-tdep.c: Fix common/ includes.
11337 * amd64-obsd-tdep.c: Fix common/ includes.
11338 * amd64-nbsd-tdep.c: Fix common/ includes.
11339 * amd64-linux-tdep.c: Fix common/ includes.
11340 * amd64-linux-nat.c: Fix common/ includes.
11341 * amd64-fbsd-tdep.c: Fix common/ includes.
11342 * amd64-fbsd-nat.c: Fix common/ includes.
11343 * amd64-dicos-tdep.c: Fix common/ includes.
11344 * amd64-darwin-tdep.c: Fix common/ includes.
11345 * agent.c: Fix common/ includes.
11346 * ada-lang.h: Fix common/ includes.
11347 * ada-lang.c: Fix common/ includes.
11348 * aarch64-tdep.c: Fix common/ includes.
11349
2f5c153e
TT
113502019-01-25 Tom Tromey <tom@tromey.com>
11351
11352 * common/create-version.sh: Use common/version.h.
11353
adc6a863
PA
113542019-01-24 Pedro Alves <palves@redhat.com>
11355
11356 * infrun.c (signal_stop, signal_print, signal_program)
11357 (signal_catch, signal_pass): Now arrays instead of pointers.
11358 (update_signals_program_target, do_target_resume)
11359 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11360 * linux-nat.c (linux_nat_target::pass_signals)
11361 (linux_nat_target::create_inferior, linux_nat_target::attach):
11362 Adjust.
11363 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11364 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11365 * procfs.c (procfs_target::pass_signals): Adjust.
11366 * record-full.c (record_full_target::resume): Adjust.
11367 * remote.c (remote_target::pass_signals)
11368 (remote_target::program_signals): Adjust.
11369 * target-debug.h (target_debug_print_signals): Now takes a
11370 gdb::array_view as parameter. Adjust.
11371 * target.h (target_ops) <pass_signals, program_signals>: Replace
11372 pointer and length parameters with gdb::array_view.
11373 (target_pass_signals, target_program_signals): Likewise.
11374 * target-delegates.c: Regenerate.
11375
3046d67a
PA
113762019-01-24 Pedro Alves <palves@redhat.com>
11377
11378 * common/forward-scope-exit.h
11379 (forward_scope_exit::forward_scope_exit): Pass arguments to
11380 m_bind_function directly, instead of creating a std::bind and
11381 copying that.
11382
353229bf
AH
113832019-01-24 Alan Hayward <alan.hayward@arm.com>
11384
11385 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11386 for static members.
11387 (pass_in_v_vfp_candidate): Likewise.
11388
311dc83a
TT
113892019-01-23 Tom Tromey <tom@tromey.com>
11390 Pedro Alves <palves@redhat.com>
11391
11392 * regcache.c (class regcache_invalidator): Remove.
11393 (regcache::raw_write): Use make_scope_exit.
11394
296bd123
TT
113952019-01-23 Tom Tromey <tom@tromey.com>
11396
11397 * ui-out.h (class ui_out_emit_type): Update comment.
11398
979a0d13
TT
113992019-01-23 Tom Tromey <tom@tromey.com>
11400
11401 * infrun.c (fetch_inferior_event): Update comment.
11402
d238133d
TT
114032019-01-23 Tom Tromey <tom@tromey.com>
11404 Pedro Alves <palves@redhat.com>
11405
11406 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11407 parameter.
11408 (fetch_inferior_event): Use SCOPE_EXIT.
11409
11410
9885e6bb
TT
114112019-01-23 Tom Tromey <tom@tromey.com>
11412 Pedro Alves <palves@redhat.com>
11413
11414 * infrun.c (disable_thread_events): Delete.
11415 (stop_all_threads): Use SCOPE_EXIT.
11416
286526c1
TT
114172019-01-23 Tom Tromey <tom@tromey.com>
11418 Pedro Alves <palves@redhat.com>
11419
11420 * symfile.c: Include forward-scope-exit.h.
11421 (clear_symtab_users_cleanup): Replace forward declaration with
11422 a FORWARD_SCOPE_EXIT.
11423 (syms_from_objfile_1): Use the forward_scope_exit and
11424 gdb::optional instead of cleanup_function.
11425 (reread_symbols): Use the forward_scope_exit instead of
11426 cleanup_function.
11427 (clear_symtab_users_cleanup): Remove function.
11428
1db93f14
TT
114292019-01-23 Tom Tromey <tom@tromey.com>
11430 Pedro Alves <palves@redhat.com>
11431
11432 * linux-nat.c: Include scope-exit.h.
11433 (cleanup_target_stop): Remove.
11434 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11435 SCOPE_EXIT.
11436
2cc83d1e
TT
114372019-01-23 Tom Tromey <tom@tromey.com>
11438 Pedro Alves <palves@redhat.com>
11439
11440 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11441 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11442
694c6bf5
TT
114432019-01-23 Tom Tromey <tom@tromey.com>
11444 Andrew Burgess <andrew.burgess@embecosm.com>
11445 Pedro Alves <palves@redhat.com>
11446
11447 * infrun.c (fetch_inferior_event): Use scope_exit.
11448 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11449 * top.c (execute_command): Use scope_exit.
11450 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11451 * utils.c (do_bpstat_clear_actions_cleanup)
11452 (make_bpstat_clear_actions_cleanup): Remove.
11453
4c41382a
TT
114542019-01-23 Tom Tromey <tom@tromey.com>
11455 Pedro Alves <palves@redhat.com>
11456
11457 * infrun.c: Include "common/scope-exit.h"
11458 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11459 (wait_for_inferior): Use SCOPE_EXIT.
11460 (fetch_inferior_event): Use scope_exit.
11461
89f8fb50
TT
114622019-01-23 Tom Tromey <tom@tromey.com>
11463 Pedro Alves <palves@redhat.com>
11464
11465 * breakpoint.c (create_breakpoint): Remove cleanup.
11466
5419bdae
TT
114672019-01-23 Tom Tromey <tom@tromey.com>
11468 Andrew Burgess <andrew.burgess@embecosm.com>
11469 Pedro Alves <palves@redhat.com>
11470
e587ef42
PA
114712019-01-23 Pedro Alves <palves@redhat.com>
11472
11473 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11474
77f0e74c
PA
114752019-01-23 Pedro Alves <palves@redhat.com>
11476 Andrew Burgess <andrew.burgess@embecosm.com>
11477
11478 * gdbthread.h: Include "common/forward-scope-exit.h".
11479 (scoped_finish_thread_state): Redefine custom class in terms of
11480 forward_scope_exit.
11481
5b9b3e53
PA
114822019-01-23 Pedro Alves <palves@redhat.com>
11483 Andrew Burgess <andrew.burgess@embecosm.com>
11484
11485 * common/forward-scope-exit.h: New file.
11486
54b65c9b
PA
114872019-01-23 Pedro Alves <palves@redhat.com>
11488 Andrew Burgess <andrew.burgess@embecosm.com>
11489 Tom Tromey <tom@tromey.com>
11490
11491 * common/scope-exit.h: New file.
11492
cf08fb29
PA
114932019-01-23 Pedro Alves <palves@redhat.com>
11494
11495 * common/preprocessor.h (ESC): Rename to ...
11496 (ESC_PARENS): ... this.
11497 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11498 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11499
ae73e2e2
TT
115002019-01-23 Tom Tromey <tom@tromey.com>
11501
11502 * language.h (class scoped_switch_to_sym_language_if_auto):
11503 Initialize m_lang in both cases.
11504
6594e122
AH
115052019-01-23 Alan Hayward <alan.hayward@arm.com>
11506
11507 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11508 with XCNEW.
11509
a7c9855d
TT
115102019-01-22 Tom Tromey <tom@tromey.com>
11511
11512 * corelow.c: Do not include sys/file.h.
11513
93cc1d53
TT
115142019-01-22 Tom Tromey <tom@tromey.com>
11515
11516 * tui/tui-wingeneral.h: Include gdb_curses.h.
11517
38561778
TT
115182019-01-22 Tom Tromey <tom@tromey.com>
11519
11520 * source-cache.h (class source_cache) <get_source_lines,
11521 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11522
37b3ab5b
TT
115232019-01-22 Tom Tromey <tom@tromey.com>
11524
11525 * remote-fileio.h (struct remote_target): Declare.
11526
3fabc016
TT
115272019-01-22 Tom Tromey <tom@tromey.com>
11528
11529 * python/py-arch.c: Do not include py-ref.h.
11530 * python/py-bpevent.c: Do not include py-ref.h.
11531 * python/py-cmd.c: Do not include py-ref.h.
11532 * python/py-continueevent.c: Do not include py-ref.h.
11533 * python/py-event.h: Do not include py-ref.h.
11534 * python/py-evtregistry.c: Do not include py-ref.h.
11535 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11536 * python/py-frame.c: Do not include py-ref.h.
11537 * python/py-framefilter.c: Do not include py-ref.h.
11538 * python/py-function.c: Do not include py-ref.h.
11539 * python/py-infevents.c: Do not include py-ref.h.
11540 * python/py-linetable.c: Do not include py-ref.h.
11541 * python/py-objfile.c: Do not include py-ref.h.
11542 * python/py-param.c: Do not include py-ref.h.
11543 * python/py-prettyprint.c: Do not include py-ref.h.
11544 * python/py-progspace.c: Do not include py-ref.h.
11545 * python/py-symbol.c: Do not include py-ref.h.
11546 * python/py-symtab.c: Do not include py-ref.h.
11547 * python/py-type.c: Do not include py-ref.h.
11548 * python/py-unwind.c: Do not include py-ref.h.
11549 * python/py-utils.c: Do not include py-ref.h.
11550 * python/py-value.c: Do not include py-ref.h.
11551 * python/py-varobj.c: Do not include py-ref.h.
11552 * python/py-xmethods.c: Do not include py-ref.h.
11553 * python/python.c: Do not include py-ref.h.
11554 * varobj.c: Do not include py-ref.h.
11555
6b4d7774
TT
115562019-01-22 Tom Tromey <tom@tromey.com>
11557
11558 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11559 keyword for bcache.
11560
7af7e9b5
TT
115612019-01-22 Tom Tromey <tom@tromey.com>
11562
11563 * compile/compile-cplus-types.c: Remove a comment by #include.
11564
951d1049
TT
115652019-01-22 Tom Tromey <tom@tromey.com>
11566
11567 * compile/gcc-c-plugin.h: Include compile-internal.h.
11568
d65d5705
TT
115692019-01-22 Tom Tromey <tom@tromey.com>
11570
11571 * stabsread.c (EXTERN): Do not define.
11572 (symnum, next_symbol_text_func, processing_gcc_compilation)
11573 (within_function, global_sym_chain, global_stabs)
11574 (previous_stab_code, this_object_header_files)
11575 (n_this_object_header_files)
11576 (n_allocated_this_object_header_files): Define.
11577 * stabsread.h (EXTERN): Never define. Use "extern".
11578
b6fb1ee5
PW
115792019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11580
11581 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11582 history_value.
11583
be6d4f74
TT
115842019-01-21 Tom Tromey <tom@tromey.com>
11585
11586 * ui-out.c: Fix includes.
11587 * tui/tui-source.c: Fix includes.
11588 * target.c: Fix includes.
11589 * remote.c: Fix includes.
11590 * regcache.c: Fix includes.
11591 * python/py-block.c: Fix includes.
11592 * printcmd.c: Fix includes.
11593 * or1k-tdep.c: Fix includes.
11594 * mi/mi-main.c: Fix includes.
11595 * m32r-tdep.c: Fix includes.
11596 * csky-tdep.c: Fix includes.
11597 * compile/compile-cplus-types.c: Fix includes.
11598 * cli/cli-interp.c: Fix includes.
11599
73021deb
AH
116002019-01-21 Alan Hayward <alan.hayward@arm.com>
11601
11602 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11603 for padding.
11604
7932255d
TT
116052019-01-16 Tom Tromey <tom@tromey.com>
11606
11607 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11608 earlier.
11609 (struct objfile) <msymbols_range>: Move from top level.
11610 <msymbols>: New method.
11611 (class objfile_msymbols): Remove.
11612 * symtab.c (default_collect_symbol_completion_matches_break_on):
11613 Update.
11614 * symmisc.c (dump_msymbols): Update.
11615 * stabsread.c (scan_file_globals): Update.
11616 * objc-lang.c (info_selectors_command, info_classes_command)
11617 (find_methods): Update.
11618 * minsyms.c (find_solib_trampoline_target): Update.
11619 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11620 * coffread.c (coff_symfile_read): Update.
11621 * ada-lang.c (ada_lookup_simple_minsym)
11622 (ada_collect_symbol_completion_matches): Update.
11623
604b1bfb
TT
116242019-01-16 Tom Tromey <tom@tromey.com>
11625
11626 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11627 type. Remove no-argument constructor.
11628 <iterator::operator++>: Simplify.
11629 <begin>: Update.
11630 <end>: Use minimal_symbol_count.
11631
f252c6d5
TT
116322019-01-16 Tom Tromey <tom@tromey.com>
11633
11634 * objfiles.h (struct objfile) <psymtabs>: New method.
11635 (class objfile_psymtabs): Remove.
11636 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11637 typedef.
11638 <range>: New method.
11639 (require_partial_symbols): Change return type.
11640 * psymtab.c (require_partial_symbols)
11641 (psym_expand_symtabs_matching): Update.
11642 * mdebugread.c (parse_partial_symbols): Update.
11643 * dbxread.c (dbx_end_psymtab): Update.
11644
b669c953
TT
116452019-01-15 Tom Tromey <tom@tromey.com>
11646
11647 * symtab.c (lookup_objfile_from_block)
11648 (lookup_symbol_in_objfile_symtabs)
11649 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11650 (find_line_symtab, info_sources_command)
11651 (default_collect_symbol_completion_matches_break_on)
11652 (make_source_files_completion_list): Update.
11653 * symmisc.c (print_objfile_statistics, dump_objfile)
11654 (maintenance_print_symbols, maintenance_info_symtabs)
11655 (maintenance_check_symtabs, maintenance_info_line_tables):
11656 Update.
11657 * source.c (select_source_symtab)
11658 (forget_cached_source_info_for_objfile): Update.
11659 * objfiles.h (class objfile_compunits): Remove.
11660 (struct objfile) <compunits_range>: New typedef.
11661 (compunits): New method.
11662 * objfiles.c (objfile_relocate1): Update.
11663 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11664 * maint.c (count_symtabs_and_blocks): Update.
11665 * linespec.c (iterate_over_all_matching_symtabs): Update.
11666 * cp-support.c (add_symbol_overload_list_qualified): Update.
11667 * coffread.c (coff_symtab_read): Update.
11668 * ada-lang.c (add_nonlocal_symbols)
11669 (ada_collect_symbol_completion_matches)
11670 (ada_add_global_exceptions): Update.
11671
7e955d83
TT
116722019-01-15 Tom Tromey <tom@tromey.com>
11673
11674 * progspace.h (program_space) <objfiles_safe_range>: New
11675 typedef.
11676 <objfiles_safe>: New method.
11677 * objfiles.h (class all_objfiles_safe): Remove.
11678 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11679 * jit.c (jit_inferior_exit_hook): Update.
11680
2030c079
TT
116812019-01-17 Tom Tromey <tom@tromey.com>
11682
11683 * progspace.h (program_space) <objfiles_range>: New typedef.
11684 <objfiles>: New method.
11685 <objfiles_head>: Rename from objfiles.
11686 (object_files): Update.
11687 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11688 * guile/scm-pretty-print.c
11689 (ppscm_find_pretty_printer_from_objfiles): Update.
11690 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11691 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11692 Update.
11693 * python/py-progspace.c (pspy_get_objfiles): Update.
11694 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11695 Update.
11696 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11697 (objfpy_lookup_objfile_by_build_id): Update.
11698 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11699 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11700 Update.
11701 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11702 (expand_symtab_containing_pc, lookup_objfile_from_block)
11703 (lookup_static_symbol, basic_lookup_transparent_type)
11704 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11705 (find_line_symtab, info_sources_command)
11706 (default_collect_symbol_completion_matches_break_on)
11707 (make_source_files_completion_list, find_main_name): Update.
11708 * symmisc.c (print_symbol_bcache_statistics)
11709 (print_objfile_statistics, maintenance_print_symbols)
11710 (maintenance_print_msymbols, maintenance_print_objfiles)
11711 (maintenance_info_symtabs, maintenance_check_symtabs)
11712 (maintenance_expand_symtabs, maintenance_info_line_tables):
11713 Update.
11714 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11715 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11716 (map_overlay_command, unmap_overlay_command)
11717 (simple_overlay_update, expand_symtabs_matching)
11718 (map_symbol_filenames): Update.
11719 * symfile-debug.c (set_debug_symfile): Update.
11720 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11721 Update.
11722 * source.c (select_source_symtab, forget_cached_source_info):
11723 Update.
11724 * solib.c (solib_read_symbols): Update.
11725 * solib-spu.c (append_ocl_sos): Update.
11726 * psymtab.c (maintenance_print_psymbols)
11727 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11728 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11729 * printcmd.c (info_symbol_command): Update.
11730 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11731 Update.
11732 * objfiles.h (class all_objfiles): Remove.
11733 * objfiles.c (have_partial_symbols, have_full_symbols)
11734 (have_minimal_symbols, qsort_cmp, update_section_map)
11735 (shared_objfile_contains_address_p)
11736 (default_iterate_over_objfiles_in_search_order): Update.
11737 * objc-lang.c (info_selectors_command, info_classes_command)
11738 (find_methods): Update.
11739 * minsyms.c (find_solib_trampoline_target): Update.
11740 * maint.c (maintenance_info_sections)
11741 (maintenance_translate_address, count_symtabs_and_blocks):
11742 Update.
11743 * main.c (captured_main_1): Update.
11744 * linux-thread-db.c (try_thread_db_load_from_pdir)
11745 (has_libpthread): Update.
11746 * linespec.c (iterate_over_all_matching_symtabs)
11747 (search_minsyms_for_name): Update.
11748 * jit.c (jit_find_objf_with_entry_addr): Update.
11749 * hppa-tdep.c (find_unwind_entry)
11750 (hppa_lookup_stub_minimal_symbol): Update.
11751 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11752 Update.
11753 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11754 (elf_gnu_ifunc_resolve_by_got): Update.
11755 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11756 * dwarf-index-write.c (save_gdb_index_command): Update.
11757 * cp-support.c (add_symbol_overload_list_qualified): Update.
11758 * breakpoint.c (create_overlay_event_breakpoint)
11759 (create_longjmp_master_breakpoint)
11760 (create_std_terminate_master_breakpoint)
11761 (create_exception_master_breakpoint): Update.
11762 * blockframe.c (find_pc_partial_function): Update.
11763 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11764 (ada_collect_symbol_completion_matches)
11765 (ada_add_global_exceptions): Update.
11766
776489e0
TT
117672019-01-17 Tom Tromey <tom@tromey.com>
11768
11769 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11770 declare VEC.
11771 (solib_target_parse_libraries): Change return type.
11772 (library_list_start_segment, library_list_start_section)
11773 (library_list_end_library, library_list_start_library); Update.
11774 (solib_target_free_library_list): Remove.
11775 (solib_target_parse_libraries): Remove cleanup. Change return
11776 type.
11777 (solib_target_current_sos): Update.
11778
6471e7d2
TT
117792019-01-17 Tom Tromey <tromey@bapiya>
11780
11781 * valprint.c: Replace "the the" with "the".
11782 * symtab.c: Replace "the the" with "the".
11783 * solib.c: Replace "the the" with "the".
11784 * solib-dsbt.c: Replace "the the" with "the".
11785 * linespec.c: Replace "the the" with "the".
11786 * dwarf2loc.h: Replace "the the" with "the".
11787 * amd64-windows-tdep.c: Replace "the the" with "the".
11788 * aarch64-tdep.c: Replace "the the" with "the".
11789
c24bdb02
KS
117902019-01-16 Keith Seitz <keiths@redhat.com>
11791
11792 PR gdb/23773
11793 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11794 <builder>: Rename to ..
11795 <m_builder>: ... this and make private.
11796 (dwarf2_cu::get_builder): New method. Change all users of
11797 `builder' to use this method.
11798 (dwarf2_start_symtab): Move to ...
11799 (dwarf2_cu::start_symtab): ... here. Update all callers
11800 (setup_type_unit_groups): Move to ...
11801 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11802 callers.
11803 (dwarf2_cu::reset_builder): New method.
11804 (process_full_compunit, process_full_type_unit): Use
11805 dwarf2_cu::reset_builder.
11806 (follow_die_offset): Record the ancestor CU if it is different
11807 from the followed DIE's CU.
11808 (follow_die_sig_1): Likewise.
11809
8d64371b
TT
118102019-01-15 Tom Tromey <tom@tromey.com>
11811
11812 * remote.c (class remote_state) <buf>: Now a char_vector.
11813 <buf_size>: Remove.
11814 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11815 parameter.
11816 (remote_target::getpkt_or_notif_sane_1)
11817 (remote_target::getpkt_sane)
11818 (remote_target::getpkt_or_notif_sane): Likewise.
11819 (class remote_target) <putpkt>: New overload.
11820 (remote_target::read_frame): Change type of "buf_p". Remove
11821 sizeof_p parameter.
11822 (packet_ok): New overload.
11823 (packet_check_result): New overload.
11824 Update all uses.
11825
bb277751
TT
118262019-01-14 Tom Tromey <tom@tromey.com>
11827
11828 * remote-notif.c (handle_notification, remote_notif_ack)
11829 (remote_notif_parse): Make "buf" const.
11830 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11831 const.
11832 (remote_notif_parse, remote_notif_ack, handle_notification):
11833 Likewise.
11834 * remote.c (remote_notif_stop_parse): Make "buf" const.
11835 (remote_target::remote_parse_stop_reply): Make "buf" const.
11836 (remote_notif_stop_ack): Make "buf" const.
11837
05be00a8
TT
118382019-01-14 Tom Tromey <tom@tromey.com>
11839
11840 * remote.c (remote_console_output): Make parameter const.
11841
491adeca
TT
118422019-01-14 Tom Tromey <tom@tromey.com>
11843
11844 * target-debug.h (target_debug_print_signals): Constify.
11845 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11846 * procfs.c (procfs_target::pass_signals): Update.
11847 * linux-nat.c (linux_nat_target::pass_signals): Update.
11848 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11849 * target-delegates.c: Rebuild.
11850 * remote.c (remote_target::program_signals): Update.
11851 (remote_target::pass_signals): Update.
11852 * target.c (target_pass_signals): Constify argument.
11853 (target_program_signals): Likewise.
11854 * target.h (struct target_ops) <pass_signals, program_signals>:
11855 Constify argument.
11856 (target_pass_signals, target_program_signals): Constify argument.
11857
bbd94648
TT
118582019-01-14 Tom Tromey <tom@tromey.com>
11859
11860 PR tui/28819:
11861 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11862
6f072a10
PFC
118632019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11864
11865 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11866 field.
11867 * rs6000-tdep.c: Include reggroups.h.
11868 (IS_V_ALIAS_PSEUDOREG): Define.
11869 (rs6000_register_name): Return names for the "vX" aliases.
11870 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11871 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11872 aliases. Call default_register_reggroup_p for all other
11873 pseudo-registers.
11874 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11875 New functions.
11876 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11877 Handle "vX" aliases.
11878 (v_alias_pseudo_register_collect): New function.
11879 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11880 (rs6000_gdbarch_init): Initialize "vX" aliases as
11881 pseudo-registers. Restore registration of
11882 rs6000_pseudo_register_reggroup_p with
11883 set_tdesc_pseudo_register_reggroup_p.
11884
1a782351
MF
118852019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11886
11887 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11888 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11889 set_gdbarch_num_pseudo_regs.
11890
d73cff18
PW
118912019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11892
11893 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11894 Remove arg prefixname, add do_set and do_show.
11895 Add member functions set_list and show_list.
11896 * cli/cli-style.c (class cli_style_option): Update accordingly.
11897 (style_set_list): Move to file scope.
11898 (style_show_list): Likewise.
11899 (set_style): Call help_list.
11900 (show_style): Call cmd_show_list.
11901 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11902 Update to use the new macro.
11903
60a90376
JB
119042019-10-12 Joel Brobecker <brobecker@adacore.com>
11905
11906 * ada-lang.c (_initialize_ada_language): Expand the help text
11907 for the "catch exception" command.
11908
9d7c67bf
PW
119092019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11910
11911 * symtab.c (matching_obj_sections): Initialize obj,
11912 declare it closer to its usage.
11913
7cf47dc4
TT
119142019-01-10 Tom Tromey <tom@tromey.com>
11915
11916 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11917 (basic_inf_threads_range): Remove.
11918 (inf_threads_range, inf_non_exited_threads_range)
11919 (safe_inf_threads_range): Use next_adapter.
11920
d3cb6808
KS
119212019-01-10 Keith Seitz <keiths@redhat.com>
11922
11923 PR gdb/23712
11924 PR symtab/23010
11925 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11926 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11927
63a20375
KS
119282019-01-10 Keith Seitz <keiths@redhat.com>
11929
11930 PR gdb/23712
11931 PR symtab/23010
11932 * dictionary.c (pending_to_vector): Remove.
11933 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11934 Remove _1 suffix, replacing functions of the same name. Update
11935 all callers.
11936 (dict_create_hashed, dict_create_hashed_expandable)
11937 (dict_create_linear, dict_create_linear_expandable, dict_free)
11938 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11939 Make functions static.
11940
b026f593
KS
119412019-01-10 Keith Seitz <keiths@redhat.com>
11942
11943 PR gdb/23712
11944 PR symtab/23010
11945 * dictionary.h (struct dictionary): Replace declaration with
11946 multidictionary.
11947 (dict_create_hashed, dict_create_hashed_expandable)
11948 (dict_create_linear, dict_create_linear_expandable)
11949 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11950 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11951 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11952 taking multidictionary argument.
11953 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11954 * block.h (struct block) <dict>: Change to multidictionary
11955 and rename `multidict'.
11956 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11957 symmisc.c: Update all dictionary references to multidictionary.
11958
c7748ee9
KS
119592019-01-10 Keith Seitz <keiths@redhat.com>
11960
11961 PR gdb/23712
11962 PR symtab/23010
11963 * dictionary.c: Include unordered_map.
11964 (pending_to_vector): New function.
11965 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11966 Rewrite the non-"_1" functions to take vector instead
11967 of linked list.
11968 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11969 "new" _1 versions of the same name.
11970 (multidictionary): Define.
11971 (std::hash<enum language): New definition.
11972 (collate_pending_symbols_by_language, mdict_create_hashed)
11973 (mdict_create_hashed_expandable, mdict_create_linear)
11974 (mdict_create_linear_expandable, mdict_free)
11975 (find_language_dictionary, create_new_language_dictionary)
11976 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11977 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11978 (mdict_size, mdict_empty): New functions.
11979 * dictionary.h (mdict_iterator): Define.
11980
67aa1f3c
PA
119812019-01-10 Pedro Alves <palves@redhat.com>
11982
11983 * breakpoint.c (read_uploaded_action)
11984 (create_tracepoint_from_upload): Adjust to use
11985 gdb::unique_xmalloc_ptr.
11986 * ctf.c (ctf_write_uploaded_tp):
11987 (SET_ARRAY_FIELD): Use emplace_back.
11988 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11989 * tracefile-tfile.c (tfile_write_uploaded_tp):
11990 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11991 gdb::unique_xmalloc_ptr.
11992 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11993 at_string, cond_string, cmd_strings>: Replace char pointers
11994 with gdb::unique_xmalloc_ptr.
11995
2f667667
PA
119962019-01-10 Pedro Alves <palves@redhat.com>
11997
11998 * solib-target.c (library_list_start_library): Don't xstrdup name.
11999
36cb7237
PA
120002019-01-10 Pedro Alves <palves@redhat.com>
12001
12002 * mdebugread.c (parse_partial_symbols): Use
12003 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12004
da584958
AB
120052019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12006
12007 * linux-fork.c (scoped_switch_fork_info)
12008 <~scoped_switch_fork_info>: Fix incorrect variable name.
12009
1ef8573c
AB
120102019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12011
12012 * linux-fork.c (scoped_switch_fork_info)
12013 <scoped_switch_fork_info>: Make explicit.
12014 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12015
8d7bcccb
TT
120162019-01-10 Tom Tromey <tom@tromey.com>
12017
12018 * objfiles.h (objfile::reset_psymtabs): Update.
12019 * objfiles.c (objfile::objfile): Update.
12020 * psymtab.h (psymtab_storage::obstack): Update.
12021 (psymtab_storage::m_obstack): Use gdb::optional.
12022 (class psymtab_storage): Update comment. Remove objfile
12023 parameter.
12024 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12025
b596a3c7
TT
120262019-01-10 Tom Tromey <tom@tromey.com>
12027
12028 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12029 <free_psymtabs>: Now private.
12030 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12031 (allocate_psymtab): Use new method.
12032
a9342b62
TT
120332019-01-10 Tom Tromey <tom@tromey.com>
12034
12035 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12036 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12037 * mdebugread.c (parse_partial_symbols): Use
12038 allocate_dependencies.
12039 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12040 allocate_dependencies.
12041 (process_psymtab_comp_unit_reader)
12042 (build_type_psymtab_dependencies): Likewise.
12043 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12044
5af70966
TT
120452019-01-10 Tom Tromey <tom@tromey.com>
12046
12047 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12048 PSYMBOL_SET_LANGUAGE.
12049 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12050
5923a04c
TT
120512019-01-10 Tom Tromey <tom@tromey.com>
12052
12053 * psymtab.h (psymtab_storage::obstack): New method.
12054 <m_obstack>: Rename from obstack; now private.
12055 * psymtab.c (psymtab_storage): Update.
12056 * dwarf2read.c (create_addrmap_from_index)
12057 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12058 Update.
12059
6d6a12bf
TT
120602019-01-10 Tom Tromey <tom@tromey.com>
12061
12062 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12063 * objfiles.h (objfile::reset_psymtabs): New method.
12064
d320c2b5
TT
120652019-01-10 Tom Tromey <tom@tromey.com>
12066
12067 * symmisc.c (print_symbol_bcache_statistics): Update.
12068 (print_objfile_statistics): Update.
12069 * symfile.c (reread_symbols): Update.
12070 * psymtab.h (class psymtab_storage): New.
12071 * psymtab.c (psymtab_storage): New constructor.
12072 (~psymtab_storage): New destructor.
12073 (require_partial_symbols): Update.
12074 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12075 (find_pc_sect_psymtab, find_pc_sect_psymbol)
12076 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12077 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12078 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12079 (start_psymtab_common, end_psymtab_common)
12080 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12081 (allocate_psymtab): Update.
12082 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12083 Update.
12084 (dump_psymtab_addrmap, maintenance_print_psymbols)
12085 (maintenance_check_psymtabs): Update.
12086 (class objfile_psymtabs): Move to objfiles.h.
12087 * psympriv.h (discard_psymtab): Now inline.
12088 (psymtab_discarder::psymtab_discarder): Update.
12089 (psymtab_discarder::~psymtab_discarder): Update.
12090 (ALL_OBJFILE_PSYMTABS): Rewrite.
12091 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12092 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12093 Remove fields.
12094 <partial_symtabs>: New field.
12095 (class objfile_psymtabs): Move from psymtab.h. Update.
12096 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12097 psymbol_cache.
12098 (objfile::~objfile): Don't destroy psymbol_cache.
12099 * mdebugread.c (parse_partial_symbols): Update.
12100 * dwarf2read.c (create_addrmap_from_index)
12101 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12102 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12103 (add_partial_subprogram, dwarf2_ranges_read): Update.
12104 * dwarf-index-write.c (write_address_map)
12105 (write_one_signatured_type, recursively_write_psymbols)
12106 (class debug_names, class debug_names, write_psymtabs_to_index):
12107 Update.
12108
1d94a5a3
TT
121092019-01-10 Tom Tromey <tom@tromey.com>
12110
12111 * symtab.h (SYMBOL_SET_NAMES): Update.
12112 (symbol_set_names): Update.
12113 (MSYMBOL_SET_NAMES): Update.
12114 * symtab.c (symbol_set_names): Change argument to be an
12115 objfile_per_bfd_storage.
12116 * psymtab.c (add_psymbol_to_bcache): Update.
12117 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12118
0f14768a
TT
121192019-01-10 Tom Tromey <tom@tromey.com>
12120
12121 * symtab.c (create_demangled_names_hash): Change argument to be an
12122 objfile_per_bfd_storage.
12123 (symbol_set_names): Update.
12124
6eee24ce
TT
121252019-01-10 Tom Tromey <tom@tromey.com>
12126
12127 * xcoffread.c (xcoff_initial_scan): Unconditionally call
12128 init_psymbol_list.
12129 * psymtab.c (init_psymbol_list): Do nothing if already called.
12130 * psympriv.h (init_psymbol_list): Add comment.
12131 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12132 init_psymbol_list.
12133 * dbxread.c (dbx_symfile_read): Unconditionally call
12134 init_psymbol_list.
12135
75aedd27
TT
121362019-01-10 Tom Tromey <tom@tromey.com>
12137
12138 * xcoffread.c (scan_xcoff_symtab): Update.
12139 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12140 "where".
12141 * mdebugread.c (parse_partial_symbols)
12142 (handle_psymbol_enumerators): Update.
12143 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12144 * dbxread.c (read_dbx_symtab): Update.
12145 * psympriv.h (psymbol_placement): New enum.
12146 (add_psymbol_to_list): Update.
12147
939652a5
TT
121482019-01-10 Tom Tromey <tom@tromey.com>
12149
12150 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12151 static_psymbols parameters.
12152 (scan_xcoff_symtab): Update.
12153 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12154 static_psymbols parameters.
12155 * psympriv.h (start_psymtab_common): Update.
12156 * mdebugread.c (parse_partial_symbols): Update.
12157 * dwarf2read.c (create_partial_symtab): Update.
12158 * dbxread.c (read_dbx_symtab): Update.
12159 (start_psymtab): Remove global_psymbols and static_psymbols
12160 parameters.
12161
baa62830
TT
121622019-01-10 Tom Tromey <tom@tromey.com>
12163
12164 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12165 * psymtab.c (allocate_psymtab): Add comment.
12166 * psympriv.h (allocate_psymtab): Add comment.
12167 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12168 initializations.
12169 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12170
0e8f53ba
TT
121712019-01-10 Tom Tromey <tom@tromey.com>
12172
12173 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12174 Don't declare.
12175 * mipsread.c: Include mdebugread.h.
12176 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12177 Declare.
12178 * elfread.c: Include mdebugread.h.
12179
b22a7c6a
TT
121802019-01-09 Tom Tromey <tom@tromey.com>
12181
12182 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12183 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12184 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12185 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12186 (psym_lookup_symbol, psym_find_last_source_symtab)
12187 (psym_forget_cached_source_info, psym_print_stats)
12188 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12189 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12190 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12191 (psym_find_compunit_symtab_by_address)
12192 (maintenance_print_psymbols, maintenance_info_psymtabs)
12193 (maintenance_check_psymtabs): Use ranged for.
12194 * psymtab.h (class objfile_psymtabs): New.
12195 (require_partial_symbols): Return objfile_psymtabs.
12196 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12197
3b9d3ac2
TT
121982019-01-09 Tom Tromey <tom@tromey.com>
12199
12200 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12201 (find_pc_mapped_section, list_overlays_command)
12202 (map_overlay_command, unmap_overlay_command)
12203 (simple_overlay_update): Use all_objfiles.
12204 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12205 * printcmd.c (info_symbol_command): Use all_objfiles.
12206 * objfiles.h (ALL_OBJSECTIONS): Remove.
12207 * maint.c (maintenance_translate_address): Use all_objfiles.
12208 * gcore.c (gcore_create_callback): Use all_objfiles.
12209 (objfile_find_memory_regions): Likewise.
12210
8b31193a
TT
122112019-01-09 Tom Tromey <tom@tromey.com>
12212
12213 * symtab.c (find_line_symtab, info_sources_command)
12214 (make_source_files_completion_list): Use objfile_compunits.
12215 * source.c (select_source_symtab): Use objfile_compunits.
12216 * objfiles.h (struct objfile): Update comment.
12217 (ALL_OBJFILES): Remove.
12218 (ALL_FILETABS): Remove.
12219 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12220 objfile_compunits.
12221
d5da8b3c
TT
122222019-01-09 Tom Tromey <tom@tromey.com>
12223
12224 * symmisc.c (print_objfile_statistics, dump_objfile)
12225 (maintenance_print_symbols): Use compunit_filetabs.
12226 * source.c (forget_cached_source_info_for_objfile): Use
12227 compunit_filetabs.
12228 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12229 (ALL_FILETABS): Use compunit_filetabs.
12230 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12231 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12232
5accd1a0
TT
122332019-01-09 Tom Tromey <tom@tromey.com>
12234
12235 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12236 (compunit_filetabs): New.
12237 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12238 compunit_filetabs.
12239 (info_sources_command, make_source_files_completion_list): Remove
12240 declaration.
12241 * symmisc.c (print_objfile_statistics, dump_objfile)
12242 (maintenance_print_symbols): Remove declaration.
12243 (maintenance_info_symtabs): Use compunit_filetabs.
12244 (maintenance_info_line_tables): Likewise.
12245 * source.c (select_source_symtab): Change local variable name.
12246 (forget_cached_source_info_for_objfile): Remove declaration.
12247 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12248 * objfiles.c (objfile_relocate1): Remove declaration.
12249 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12250 declaration.
12251 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12252 * coffread.c (coff_symtab_read): Remove declaration.
12253 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12254 compunit_filetabs.
12255
d8aeb77f
TT
122562019-01-09 Tom Tromey <tom@tromey.com>
12257
12258 * symtab.c (lookup_objfile_from_block)
12259 (find_pc_sect_compunit_symtab, search_symbols)
12260 (default_collect_symbol_completion_matches_break_on): Use
12261 objfile_compunits.
12262 * objfiles.h (ALL_COMPUNITS): Remove.
12263 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12264 * cp-support.c (add_symbol_overload_list_qualified): Use
12265 objfile_compunits.
12266 * ada-lang.c (ada_collect_symbol_completion_matches)
12267 (ada_add_global_exceptions): Use objfile_compunits.
12268
592553c4
TT
122692019-01-09 Tom Tromey <tom@tromey.com>
12270
12271 * source.c (select_source_symtab)
12272 (forget_cached_source_info_for_objfile): Remove declaration.
12273 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12274 declaration.
12275 * maint.c (count_symtabs_and_blocks): Remove declaration.
12276 * cp-support.c (add_symbol_overload_list_qualified): Remove
12277 declaration.
12278 * coffread.c (coff_symtab_read): Remove declaration.
12279 * symtab.c (lookup_symbol_in_objfile_symtabs)
12280 (basic_lookup_transparent_type_1): Use objfile_compunits.
12281 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12282 (info_sources_command, search_symbols)
12283 (default_collect_symbol_completion_matches_break_on)
12284 (make_source_files_completion_list): Remove declaration.
12285 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12286 (ada_collect_symbol_completion_matches)
12287 (ada_add_global_exceptions): Remove declaration.
12288 * linespec.c (iterate_over_all_matching_symtabs): Use
12289 objfile_compunits.
12290 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12291 (class objfile_compunits): New.
12292 (ALL_COMPUNITS): Use objfile_compunits.
12293 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12294 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12295 objfile_compunits.
12296 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12297
5325b9bf
TT
122982019-01-09 Tom Tromey <tom@tromey.com>
12299
12300 * symtab.c (search_symbols)
12301 (default_collect_symbol_completion_matches_break_on): Use
12302 objfile_msymbols.
12303 * ada-lang.c (ada_lookup_simple_minsym)
12304 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12305 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12306 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12307 objfile_msymbols.
12308 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12309 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12310 * objc-lang.c (find_methods): Use objfile_msymbols.
12311 (info_selectors_command, info_classes_command): Likewise.
12312 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12313 * objfiles.h (class objfile_msymbols): New.
12314 (ALL_OBJFILE_MSYMBOLS): Remove.
12315 (ALL_MSYMBOLS): Remove.
12316
cac85af2
TT
123172019-01-09 Tom Tromey <tom@tromey.com>
12318
12319 * common/next-iterator.h (next_adapter): Add Iterator template
12320 parameter.
12321 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12322 (class all_objfiles_safe): New.
12323 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12324 * objfiles.c (put_objfile_before): Update comment.
12325 (add_separate_debug_objfile): Likewise.
12326 (free_all_objfiles): Use all_objfiles_safe.
12327 (objfile_purge_solibs): Likewise.
12328
aed57c53
TT
123292019-01-09 Tom Tromey <tom@tromey.com>
12330
12331 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12332 (expand_symtab_containing_pc, lookup_static_symbol)
12333 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12334 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12335 all_objfiles.
12336 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12337 * breakpoint.c (create_overlay_event_breakpoint)
12338 (create_longjmp_master_breakpoint)
12339 (create_std_terminate_master_breakpoint)
12340 (create_exception_master_breakpoint): Use all_objfiles.
12341 * linux-thread-db.c (try_thread_db_load_from_pdir)
12342 (has_libpthread): Use all_objfiles.
12343 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12344 * linespec.c (iterate_over_all_matching_symtabs)
12345 (search_minsyms_for_name): Use all_objfiles.
12346 * maint.c (maintenance_info_sections): Use all_objfiles.
12347 * main.c (captured_main_1): Use all_objfiles.
12348 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12349 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12350 * guile/scm-pretty-print.c
12351 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12352 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12353 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12354 (maintenance_print_msymbols): Use all_objfiles.
12355 * source.c (select_source_symtab): Use all_objfiles.
12356 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12357 * symfile.c (remove_symbol_file_command)
12358 (expand_symtabs_matching, map_symbol_filenames): Use
12359 all_objfiles.
12360 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12361 all_objfiles.
12362 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12363 * objc-lang.c (find_methods): Use all_objfiles.
12364 * objfiles.c (have_partial_symbols, have_full_symbols)
12365 (have_minimal_symbols, qsort_cmp)
12366 (default_iterate_over_objfiles_in_search_order): Use
12367 all_objfiles.
12368 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12369 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12370 (maintenance_check_psymtabs): Use all_objfiles.
12371 (ALL_PSYMTABS): Remove.
12372 * compile/compile-object-run.c (do_module_cleanup): Use
12373 all_objfiles.
12374 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12375 * cp-support.c (add_symbol_overload_list_qualified): Use
12376 all_objfiles.
12377 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12378 Use all_objfiles.
12379 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12380 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12381 all_objfiles.
12382 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12383 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12384 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12385 Uses all_objfiles.
12386 * solib.c (solib_read_symbols): Use all_objfiles
12387
99d89cde
TT
123882019-01-09 Tom Tromey <tom@tromey.com>
12389
12390 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12391 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12392 all_objfiles.
12393 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12394 * symmisc.c (print_symbol_bcache_statistics)
12395 (print_objfile_statistics, maintenance_print_objfiles)
12396 (maintenance_info_symtabs, maintenance_check_symtabs)
12397 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12398 all_objfiles.
12399 * source.c (forget_cached_source_info): Use all_objfiles.
12400 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12401 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12402 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12403 * objfiles.c (update_section_map): Use all_objfiles.
12404 (shared_objfile_contains_address_p): Likewise.
12405 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12406 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12407
21708325
TT
124082019-01-09 Tom Tromey <tom@tromey.com>
12409
12410 * common/next-iterator.h: New file.
12411 * objfiles.h (class all_objfiles): New.
12412 (struct objfile_iterator): New.
12413
669e09f6
PW
124142019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12415
12416 * NEWS: Move the description of the changed "frame", "select-frame",
12417 and "info frame" commands to the Changed commands section.
12418
041be526
SM
124192019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12420
12421 * gdbtypes.c (check_stub_method_group): Remove handling of old
12422 mangling schemes.
12423 * linespec.c (find_methods): Likewise.
12424 * stabsread.c (read_member_functions): Likewise.
12425 * valops.c (search_struct_method): Likewise.
12426 (value_struct_elt_for_reference): Likewise.
12427 * NEWS: Mention this change.
12428
0e2a2133
AB
124292019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12430
12431 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12432 print_source_lines.
12433 * source.c (print_source_lines_base): Update line number check.
12434 (print_source_lines): New function.
12435 (source_lines_range::source_lines_range): New function.
12436 * source.h (class source_lines_range): New class.
12437 (print_source_lines): New declaration.
12438
1055a3b4
PW
124392019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12440
12441 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12442
cfeadda5
TT
124432019-01-08 Tom Tromey <tom@tromey.com>
12444 Simon Marchi <simon.marchi@ericsson.com>
12445
12446 PR gdb/24060
12447 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12448 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12449 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12450 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12451 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12452 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12453
583068ca
AB
124542019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12455
12456 * source.c (select_source_symtab): Move header comment to
12457 declaration in source.h.
12458 (forget_cached_source_info_for_objfile): Likewise.
12459 (forget_cached_source_info): Likewise.
12460 (identify_source_line): Likewise.
12461 * source.h (identify_source_line): Move declaration from symtab.h
12462 and add comment from source.c
12463 (print_source_lines): Likewise.
12464 (forget_cached_source_info_for_objfile): Likewise.
12465 (forget_cached_source_info): Likewise.
12466 (select_source_symtab): Likewise.
12467 (enum print_source_lines_flag): Move definition from symtab.h.
12468 * symtab.h (identify_source_line): Move declaration to source.h.
12469 (print_source_lines): Likewise.
12470 (forget_cached_source_info_for_objfile): Likewise.
12471 (forget_cached_source_info): Likewise.
12472 (select_source_symtab): Likewise.
12473 (enum print_source_lines_flag): Move definition to source.h.
12474 * tui/tui-hooks.c: Add 'source.h' include.
12475
ec98a4ad
AB
124762019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12477
12478 * source.c (print_source_lines_base): Handle requests to print
12479 reverse line number sequences, and guard against empty lines
12480 string.
12481
62ea19c1
AB
124822019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12483
12484 * source.c (print_source_lines_base): Fix skip of '\r' if next
12485 character is '\n'.
12486
9d30e1fd
TT
124872019-01-06 Tom Tromey <tom@tromey.com>
12488
12489 * c-exp.y (struct c_parse_state) <macro_original_text,
12490 expansion_obstack>: New member.
12491 (macro_original_text, expansion_obstack): Remove globals.
12492 (scan_macro_expansion, scanning_macro_expansion)
12493 (finished_macro_expansion): Update.
12494 (scan_macro_cleanup): Remove.
12495 (yylex, c_parse): Update.
12496
c65bac38
TT
124972019-01-06 Tom Tromey <tom@tromey.com>
12498
12499 * c-exp.y (struct c_parse_state) <strings>: New member.
12500 (operator_stoken): Update.
12501
02e12e38
TT
125022019-01-06 Tom Tromey <tom@tromey.com>
12503
12504 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12505 (union type_stack_elt) <typelist_val>: Now a pointer to
12506 std::vector.
12507 (type_stack_cleanup): Don't declare.
12508 (push_typelist): Update.
12509 * parse.c (pop_typelist): Return a std::vector.
12510 (push_typelist): Take a std::vector.
12511 (follow_types): Update. Do not free args.
12512 (type_stack_cleanup): Remove.
12513 * c-exp.y (struct c_parse_state): New.
12514 (cpstate): New global.
12515 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12516 (nonempty_typelist): Update.
12517 (func_mod): Create a new vector.
12518 (c_parse): Create a c_parse_state.
12519 (check_parameter_typelist): Do not delete params.
12520 (function_method): Update. Do not delete type_list.
12521
f097f5ad
TT
125222019-01-06 Tom Tromey <tom@tromey.com>
12523
12524 PR gdb/28155:
12525 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12526 check_typedef.
12527 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12528 (print_return_value): Likewise.
12529
d2adf9f1
TT
125302019-01-05 Tom Tromey <tom@tromey.com>
12531
12532 * contrib/cleanup_check.py: Remove.
12533 * contrib/gcc-with-excheck: Remove.
12534 * contrib/exsummary.py: Remove.
12535 * contrib/excheck.py: Remove.
12536
2eab46b1
JB
125372019-01-05 Joel Brobecker <brobecker@adacore.com>
12538
12539 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12540 NULL. Initialize tpprev to NULL instead of assigning it
12541 to NULL on the next statement.
12542 * windows-nat.c (windows_delete_thread): Remove check for
12543 main_thread_id before printing thread exit notifications.
12544 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12545 Remove thread ID check against main_thread_id.
12546 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12547 windows_delete_thread.
12548 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12549
48c5e7e2
TT
125502019-01-04 Tom Tromey <tom@tromey.com>
12551
12552 * compile/compile.c (_initialize_compile): Use upper case for
12553 metasyntactic variables.
12554 * symmisc.c (_initialize_symmisc): Use upper case for
12555 metasyntactic variables.
12556 * psymtab.c (_initialize_psymtab): Use upper case for
12557 metasyntactic variables.
12558 * demangle.c (demangle_command): Use upper case for metasyntactic
12559 variables.
12560 (_initialize_demangler): Likewise.
12561 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12562 variables.
12563
986041cd
TT
125642019-01-03 Tom Tromey <tom@tromey.com>
12565
12566 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12567
7c711119
TT
125682019-01-03 Tom Tromey <tom@tromey.com>
12569
12570 * python/py-symtab.c (salpy_str): Update.
12571 (struct salpy_sal_object) <symtab>: Now a PyObject.
12572 (salpy_dealloc): Update.
12573 (del_objfile_sal): Use gdbpy_ref.
12574
1b20edf0
TT
125752019-01-03 Tom Tromey <tom@tromey.com>
12576
12577 * python/py-type.c (convert_field): Use new_reference. Return
12578 gdbpy_ref.
12579 (make_fielditem): Return gdbpy_ref.
12580 (typy_fields): Update.
12581 (typy_getitem): Update.
12582 (field_name): Return gdbpy_ref. Use new_reference.
12583 (typy_iterator_iternext): Update.
12584
ea41325b
TT
125852019-01-03 Tom Tromey <tom@tromey.com>
12586
12587 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12588
2a3c71d6
TT
125892019-01-03 Tom Tromey <tom@tromey.com>
12590
12591 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12592 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12593 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12594 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12595 (pspy_set_type_printers): Likewise.
12596 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12597 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12598 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12599 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12600 (objfpy_set_type_printers): Likewise.
12601
5c329e6a
TT
126022019-01-03 Tom Tromey <tom@tromey.com>
12603
12604 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12605 (gdbpy_print_stack): Use gdbpy_err_fetch.
12606 * python/python-internal.h (class gdbpy_err_fetch): New class.
12607 (class gdbpy_enter) <m_error_type, m_error_value,
12608 m_error_traceback>: Remove.
12609 <m_error>: New member.
12610 (gdbpy_exception_to_string): Don't declare.
12611 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12612 * python/py-value.c (convert_value_from_python): Use
12613 gdbpy_err_fetch.
12614 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12615 gdbpy_exception_to_string.
12616 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12617 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12618 gdbpy_err_fetch.
12619
169bb27b
AB
126202019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12621
12622 * linux-nat.c (delete_lwp_cleanup): Delete.
12623 (struct lwp_deleter): New struct.
12624 (lwp_info_up): New typedef.
12625 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12626 lwp_info_up.
12627
a07c8880
AB
126282019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12629
12630 * linux-fork.c (class scoped_switch_fork_info): New class.
12631 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12632
26089c49
AB
126332019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12634
12635 * valops.c (find_overload_match): Remove use of null_cleanup, and
12636 calls to do_cleanups.
12637
06d3e5b0
AB
126382019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12639
12640 * compile/compile-cplus-types.c
12641 (compile_cplus_instance::decl_name): Handle changes to
12642 cp_func_name.
12643 * cp-support.c (cp_func_name): Update header comment, update
12644 return type.
12645 * cp-support.h (cp_func_name): Update return type in declaration.
12646 * valops.c (find_overload_match): Move temp_func local to top
12647 level of function and change its type. Use temp_func to hold and
12648 delete temporary string obtained from cp_func_name.
12649
66644cd3
AB
126502019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12651
12652 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12653 gdb::char_vector, remove cleanup, and update uses of `msg`.
12654
592d8c0a
JW
126552019-01-03 Jim Wilson <jimw@sifive.com>
12656
12657 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12658
c55d06ec
TT
126592019-01-02 Tom Tromey <tom@tromey.com>
12660
12661 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12662 (tdesc_parse_xml): Remove cleanups.
12663 * target-descriptions.h (make_cleanup_free_target_description):
12664 Don't declare.
12665 (target_desc_deleter): New struct.
12666 (target_desc_up): New typedef.
12667 * target-descriptions.c (target_desc_deleter::operator()): Rename
12668 from free_target_description.
12669 (make_cleanup_free_target_description): Remove.
12670
3a6ae42d
TT
126712019-01-02 Tom Tromey <tom@tromey.com>
12672
12673 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12674 constructor, destructor.
12675 (linespec_parser): Remove typedef.
12676 (~linespec_parser): Rename from linespec_parser_delete.
12677 (linespec_lex_to_end, linespec_complete_label)
12678 (linespec_complete): Update.
12679 (decode_line_full): Remove cleanups.
12680 (decode_line_1): Update.
12681
61fd3e73
TT
126822019-01-02 Tom Tromey <tom@tromey.com>
12683
12684 * python/python-internal.h (inferior_to_inferior_object): Change
12685 return type.
12686 * python/py-exitedevent.c (create_exited_event_object): Update.
12687 * python/py-inferior.c (inferior_to_inferior_object): Return
12688 gdbpy_ref.
12689 (python_new_inferior, python_inferior_deleted)
12690 (thread_to_thread_object, delete_thread_object)
12691 (build_inferior_list, gdbpy_selected_inferior): Update.
12692 * python/py-infthread.c (create_thread_object): Update. Also fail
12693 if inferior_to_inferior_object fails.
12694
d20172fc
SM
126952019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12696
12697 * inferior.h (class inferior) <displaced_step_state>: New field.
12698 * infrun.h (struct displaced_step_state): Move here from
12699 infrun.c. Initialize fields, add constructor.
12700 <inf>: Remove field.
12701 <reset>: New method.
12702 * infrun.c (struct displaced_step_inferior_state): Move to
12703 infrun.h.
12704 (displaced_step_inferior_states): Remove.
12705 (get_displaced_stepping_state): Adust.
12706 (displaced_step_in_progress_any_inferior): Adjust.
12707 (displaced_step_in_progress_thread): Adjust.
12708 (displaced_step_in_progress): Adjust.
12709 (add_displaced_stepping_state): Remove.
12710 (get_displaced_step_closure_by_addr): Adjust.
12711 (remove_displaced_stepping_state): Remove.
12712 (infrun_inferior_exit): Call displaced_step_state.reset.
12713 (use_displaced_stepping): Don't check for NULL.
12714 (displaced_step_prepare_throw): Call
12715 get_displaced_stepping_state.
12716 (displaced_step_fixup): Don't check for NULL.
12717 (prepare_for_detach): Don't check for NULL.
12718
e3319240
PW
127192019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12720
12721 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12722 in case of call that did not complete.
12723
5d36dfb9
AU
127242019-01-02 Andrey Utkin <autkin@undo.io>
12725
12726 * symfile.c (find_separate_debug_file): Fix search of debug files for
12727 remote debuggee.
12728
8833fbf0
TT
127292019-01-02 Tom Tromey <tom@tromey.com>
12730
12731 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12732 indentation.
12733 * python/py-frame.c (frapy_older): Remove cast.
12734 (frapy_newer): Likewise.
12735 * python/py-breakpoint.c (local_setattro): Remove cast.
12736 * python/py-arch.c (archpy_name): Remove local variable.
12737 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12738
4ada3dfd
JB
127392019-01-02 Joel Brobecker <brobecker@adacore.com>
12740
12741 * unittests/basic_string_view/element_access/char/empty.cc:
12742 Fix year range in copyright header.
12743
113b7b81
AB
127442019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12745
12746 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12747 Delete.
12748 <operator==>: Update with for removed field.
12749 <hash>: Likewise.
12750 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12751 <isa_features>: ...this.
12752 <abi_features>: New field.
12753 (riscv_isa_flen): Update comment.
12754 (riscv_abi_xlen): New declaration.
12755 (riscv_abi_flen): New declaration.
12756 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12757 isa_features.
12758 (riscv_abi_xlen): New function.
12759 (riscv_isa_flen): Update to get answer from isa_features.
12760 (riscv_abi_flen): New function.
12761 (riscv_has_fp_abi): Update to get answer from abi_features.
12762 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12763 xlen and flen.
12764 (riscv_call_info) <xlen, flen>: Update comment.
12765 (riscv_call_arg_struct): Remove invalid assertions
12766 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12767 is removed.
12768 (riscv_gdbarch_init): Gather isa features and abi features
12769 separately, ensure both match on the gdbarch when reusing an old
12770 gdbarch. Relax an error check to allow 32-bit abi float to run on
12771 a target with 64-bit float hardware.
12772
b18ca514
PW
127732019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12774
12775 * source.c (search_command_helper): Stop reverse search
12776 when line 1 has been searched.
12777
ec70d8db
PW
127782019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12779
12780 * record-full.c (record_full_base_target::close): Rewrite
12781 record_full_core_buf_list free logic.
12782
5b38f9c1
PW
127832019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12784
12785 * break-catch-syscall.c (print_one_catch_syscall): xfree
12786 the last text.
12787
66d91b39
JB
127882019-01-01 Joel Brobecker <brobecker@adacore.com>
12789
12790 * top.c (print_gdb_version): Update Copyright year in version
12791 message.
12792
42a4f53d
JB
127932019-01-01 Joel Brobecker <brobecker@adacore.com>
12794
12795 Update copyright year range in all GDB files.
12796
7e955d83 127972019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 12798
5bbd631d 12799 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 12800
5bbd631d 12801For older changes see ChangeLog-2018.
c906108c
SS
12802\f
12803Local Variables:
12804mode: change-log
12805left-margin: 8
12806fill-column: 74
12807version-control: never
57da7796 12808coding: utf-8
c906108c 12809End:
5bbd631d 12810