]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Make gdb::option::complete_options save processed arguments too
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
41fc454c
PA
12019-07-03 Pedro Alves <palves@redhat.com>
2
3 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4 option_value with a null enumeration.
5 (complete_options): Save the option values in the context.
6 (save_option_value_in_ctx): New, factored out from ...
7 (process_options): ... here.
8 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
9 of the function.
10 * maint-test-options.c (test_options_opts::dump): New, factored
11 out from ...
12 (maintenance_test_options_command_mode): ... here.
13 (maintenance_test_options_command_completion_result): Delete.
14 (maintenance_test_options_command_completion_text): Update
15 comment.
16 (maintenance_show_test_options_completion_result): Change
17 prototype. Just print
18 maintenance_test_options_command_completion_text.
19 (save_completion_result): New.
20 (maintenance_test_options_completer_mode): Pass options context to
21 complete_options, and then save a dump.
22 (_initialize_maint_test_options): Use add_cmd to install "maint
23 show test-options-completion-result".
24
fdbc9870
PA
252019-07-03 Pedro Alves <palves@redhat.com>
26
27 * NEWS (New commands): Mention "with" and "maint with".
28 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
29 (with_command, with_command_completer): New.
30 (pipe_command): Adjust to new repeat_previous
31 interface.
32 (_initialize_cli_cmds): Install the "with" command and its "w"
33 alias.
34 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
35 declarations.
36 * cli/cli-setshow.c (parse_cli_var_uinteger)
37 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
38 argument strings for all var_types.
39 (get_setshow_command_value_string): New, factored out from ...
40 (do_show_command): ... this.
41 * cli/cli-setshow.h: Include <string>.
42 (get_setshow_command_value_string): Declare.
43 * command.h (repeat_previous): Now returns const char *. Adjust
44 comment.
45 * maint.c: Include "cli/cli-cmds.h".
46 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
47 (_initialize_maint_cmds): Register the "maintenance with" command.
48 * top.c (repeat_previous): Move bits from pipe_command here:
49 Return the saved command line, if any; error out if there's no
50 command to relaunch.
51
c6ac8931
PA
522019-07-03 Pedro Alves <palves@redhat.com>
53
54 * NEWS (New commands): Mention "maint set/show test-settings"
55 instead of "maint test-settings".
56 * maint-test-settings.c (maintenance_test_settings_list): Delete.
57 (maintenance_test_settings_set_list): Rename to ...
58 (maintenance_set_test_settings_list): ... this.
59 (maintenance_test_settings_show_list): Rename to ...
60 (maintenance_show_test_settings_list): ... this.
61 (maintenance_test_settings_cmd): Delete.
62 (maintenance_test_settings_set_cmd): ...
63 (maintenance_set_test_settings_cmd): ... this.
64 (maintenance_test_settings_show_cmd): ...
65 (maintenance_show_test_settings_cmd): ... this.
66 (maintenance_test_settings_show_value_cmd):
67 (maintenance_show_test_settings_value_cmd): ... this.
68 (_initialize_maint_test_settings): No longer install the "maint
69 test-settings" prefix command. Rename "maint test-settings set"
70 to "maint set test-settings", and "maint test-settings show" to
71 "maint show test-settings". Adjust all subcommands.
72
d1fcf2fd
PA
732019-07-03 Pedro Alves <palves@redhat.com>
74
75 * maint-test-settings.c: Fix file's intro comment. Replace all
76 references to "test-options" with references to "test-settings",
77 in comments.
78
970f9d09
PA
792019-07-03 Pedro Alves <palves@redhat.com>
80
81 * maint-test-settings.c (maintenance_test_settings_xxx)
82 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
83 New.
84 (maintenance_test_settings_enums): Use them.
85 (maintenance_test_settings_enum): Default to
86 maintenance_test_settings_xxx.
87 (_initialize_maint_test_settings): Initialize
88 MAINTENANCE_TEST_SETTINGS_FILENAME.
89
f3869b1a
SM
902019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
91
92 * breakpoint.h (remove_breakpoints_inf): Change return type to
93 void, move function documentation here.
94 * breakpoint.c (remove_breakpoints_inf): Change return type to
95 void, move function documentation to header.
96
54d66006
PA
972019-07-02 Pedro Alves <palves@redhat.com>
98
99 * NEWS (Completion improvements): Mention "info threads".
100 * thread.c (struct info_threads_opts, info_threads_option_defs)
101 (make_info_threads_options_def_group): New.
102 (info_threads_command): Use gdb::option::process_options.
103 (info_threads_command_completer): New.
104 (_initialize_thread): Use gdb::option::build_help to build the
105 help text for "info threads".
106
854f6088
SM
1072019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
108
109 * defs.h (generic_load): Move from here...
110 * symfile.h (generic_load): ... to here. Rename name parameter
111 to args.
112 * symfile.c (generic_load): Add comment.
113
54ee4252
TT
1142019-07-01 Tom Tromey <tromey@adacore.com>
115
116 * dwarf2read.c
117 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
118 declaration of without_params. Fix formatting.
119
65392b3e
TT
1202019-07-01 Tom Tromey <tromey@adacore.com>
121
122 * ada-exp.y (find_primitive_type): Update.
123 * ada-lang.h (ada_lookup_symbol): Update.
124 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
125 parameter.
126 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
127
7d7571f0
SDJ
1282019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
129
130 PR breakpoints/24541
131 * gdbarch.c: Regenerate.
132 * gdbarch.h: Regenerate.
133 * gdbarch.sh: Add 'stap_adjust_register'.
134 * i386-tdep.c: Include '<unordered_set>'.
135 (i386_stap_adjust_register): New function.
136 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
137 * stap-probe.c (stap_parse_register_operand): Call
138 'gdbarch_stap_adjust_register'.
139
5af5392a
SDJ
1402019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
141
142 PR python/24742
143 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
144 * python/python.c (do_start_initialization): Use 'xmalloc'
145 instead of 'PyMem_Malloc'.
146
10d06d82
TT
1472019-06-28 Tom Tromey <tromey@adacore.com>
148
149 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
150 for Ada.
151
1b7f24cd
TT
1522019-06-27 Tom Tromey <tromey@adacore.com>
153
154 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
155 objfile_key.
156 (arm_find_mapping_symbol, arm_record_special_symbol)
157 (_initialize_arm_tdep): Update.
158 (arm_objfile_data_free): Remove.
159
3d507ff2
TT
1602019-06-27 Tom Tromey <tromey@adacore.com>
161
162 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
163 to cp_print_static_field.
164
762c164d
TT
1652019-06-26 Tom Tromey <tromey@adacore.com>
166
167 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
168 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
169 declare.
170
aa2f9bcf
AH
1712019-06-26 Alan Hayward <alan.hayward@arm.com>
172
173 * features/aarch64-core.c (create_feature_aarch64_core):
174 Regenerate.
175 * features/aarch64-core.xml: Add cpsr flags.
176
3426ae57
AH
1772019-06-26 Alan Hayward <alan.hayward@arm.com>
178
179 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
180 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
181
4838e44c
SM
1822019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
183
184 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
185 field.
186 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
187 use.
188 (arm_record_special_symbol): Don't insert new symbol in sorted
189 position, push it at the end.
190
54cc7474
SM
1912019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
192
193 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
194 (arm_mapping_symbol_s): Remove.
195 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
196 (arm_mapping_symbol_vec): New typedef.
197 (struct arm_per_objfile): Add constructor.
198 <section_maps>: Change type to
199 std::unique_ptr<arm_mapping_symbol_vec[]>.
200 (arm_compare_mapping_symbols): Remove.
201 (arm_find_mapping_symbol): Adjust to section_maps type change.
202 (arm_objfile_data_free): Call delete on arm_per_objfile.
203 (arm_record_special_symbol): Adjust to section_maps type change.
204 Allocate arm_per_objfile with new.
205
b65b566c
PW
2062019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
207
208 * cli/cli-cmds.c (alias_command): Compare the alias prefix
209 with the command prefix.
210
c2fc64f5
TT
2112019-06-25 Tom Tromey <tom@tromey.com>
212
213 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
214 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
215
fb54fa76
TT
2162019-06-25 Tom Tromey <tom@tromey.com>
217
218 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
219 type.
220 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
221 protected.
222
f7952c57
TT
2232019-06-25 Tom Tromey <tom@tromey.com>
224
225 * tui/tui-winsource.c
226 (tui_source_window_base::set_is_exec_point_at): Add check against
227 LOA_ADDRESS.
228
17568d78
TT
2292019-06-25 Tom Tromey <tom@tromey.com>
230
231 * tui/tui-source.c (tui_set_source_content): Don't check before
232 xfree.
233 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
234
53e7cdba
TT
2352019-06-25 Tom Tromey <tom@tromey.com>
236
237 * tui/tui-winsource.h (tui_update_source_window_as_is)
238 (tui_alloc_source_buffer, tui_line_is_displayed)
239 (tui_addr_is_displayed): Change type of win_info.
240 * tui/tui-winsource.c (tui_update_source_window_as_is)
241 (tui_clear_source_content, tui_show_source_line)
242 (tui_show_source_content, tui_source_window_base::refill)
243 (tui_source_window_base::set_is_exec_point_at)
244 (tui_source_window_base::set_is_exec_point_at)
245 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
246 (tui_alloc_source_buffer, tui_line_is_displayed)
247 (tui_addr_is_displayed): Change type of win_info. Update.
248 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
249 (tui_source_window_base::do_make_visible_with_new_height):
250 Update.
251 * tui/tui-source.c (tui_set_source_content)
252 (tui_set_source_content_nil)
253 (tui_source_window::do_scroll_vertical): Update.
254 * tui/tui-layout.c (show_layout): Update.
255 * tui/tui-disasm.c (tui_set_disassem_content)
256 (tui_disasm_window::do_scroll_vertical): Update.
257 * tui/tui-data.h (tui_win_content): Remove.
258 (struct tui_gen_win_info) <content, content_size>: Remove.
259 (struct tui_source_element): Add initializers and destructor.
260 (union tui_which_element, struct tui_win_element): Remove.
261 (struct tui_source_window_base) <content>: New field.
262 (struct tui_data_window): Remove destructor.
263 (tui_alloc_content, tui_free_win_content)
264 (tui_free_all_source_wins_content): Don't declare.
265 * tui/tui-data.c (tui_initialize_static_data): Update.
266 (init_content_element, tui_alloc_content): Remove.
267 (~tui_gen_win_info): Update.
268 (~tui_data_window, tui_free_all_source_wins_content)
269 (tui_free_win_content, free_content, free_content_elements):
270 Remove.
271
7908abbf
TT
2722019-06-25 Tom Tromey <tom@tromey.com>
273
274 * tui/tui-winsource.h (tui_clear_source_content)
275 (tui_erase_source_content, tui_show_source_content): Change type
276 of win_info.
277 * tui/tui-winsource.c (tui_clear_source_content)
278 (tui_erase_source_content, tui_show_source_content): Change type
279 of win_info.
280 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
281 * tui/tui-source.h (tui_set_source_content_nil): Change type of
282 win_info.
283 * tui/tui-source.c (tui_set_source_content_nil): Change type of
284 win_info.
285 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
286
02c28df0
TT
2872019-06-25 Tom Tromey <tom@tromey.com>
288
289 * tui/tui-winsource.c (tui_clear_source_content)
290 (tui_source_window_base::set_is_exec_point_at): Update.
291 * tui/tui-source.c (tui_set_source_content_nil): Update.
292 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
293 a bool.
294 * tui/tui-data.c (init_content_element): Update.
295
6658b1bf
TT
2962019-06-25 Tom Tromey <tom@tromey.com>
297
298 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
299 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
300 * tui/tui-layout.c (init_and_make_win): Update.
301 * tui/tui.h (enum tui_win_type): Update.
302 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
303 tui_win_is_auxillary.
304 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
305 tui_win_is_auxillary.
306
21e1c91e
TT
3072019-06-25 Tom Tromey <tom@tromey.com>
308
309 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
310 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
311 (tui_delete_data_content_windows, tui_display_all_data)
312 (tui_data_window::do_scroll_vertical, tui_display_data_from):
313 Update.
314 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
315 * tui/tui-regs.c (tui_last_regs_line_no)
316 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
317 (tui_show_registers): Update.
318 (tui_show_register_group): Return void. Update.
319 (tui_display_registers_from, tui_display_reg_element_at_line)
320 (tui_display_registers_from_line, tui_check_register_values):
321 Update.
322 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
323 member.
324 (struct tui_data_window) <regs_content>: Now a std::vector.
325 <regs_content_count>: Remove.
326 (tui_add_content_elements, tui_free_data_content): Don't declare.
327 * tui/tui-data.c (tui_data_window::clear_detail): Update.
328 (init_content_element): Remove DATA_WIN case. Add assert.
329 (tui_add_content_elements): Remove.
330 (tui_data_window): Update.
331 (tui_free_data_content): Remove.
332 (free_content_elements): Remove DATA_WIN case.
333
115ac53b
TT
3342019-06-25 Tom Tromey <tom@tromey.com>
335
336 * tui/tui-data.c (tui_data_item_window): Update.
337 * tui/tui-windata.h (tui_check_data_values): Don't declare.
338 * tui/tui-windata.c (tui_display_all_data)
339 (tui_display_data_from_line): Update.
340 (tui_check_data_values): Remove.
341 * tui/tui-regs.c (tui_show_register_group)
342 (tui_display_reg_element_at_line): Update.
343 * tui/tui-hooks.c (tui_register_changed)
344 (tui_refresh_frame_and_register_information): Call
345 tui_check_register_values.
346 * tui/tui-data.h (struct tui_data_window) <data_content,
347 data_content_count, data_type>: Remove.
348 (enum tui_data_type): Remove.
349
350 * tui/tui-data.c (tui_data_window::clear_detail)
351 (~tui_data_window): Update.
352
eaf9738b
TT
3532019-06-25 Tom Tromey <tom@tromey.com>
354
355 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
356 declare.
357 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
358 Rename from tui_first_data_item_displayed. Update.
359 (tui_data_window::refresh_all)
360 (tui_data_window::do_scroll_vertical): Update.
361 * tui/tui-data.h (struct tui_data_window)
362 <first_data_item_displayed>: Declare new method.
363
31ca4723
TT
3642019-06-25 Tom Tromey <tom@tromey.com>
365
366 * tui/tui-data.h (tui_init_generic_part): Don't declare.
367 * tui/tui-data.c (tui_init_generic_part): Remove, moving
368 contents...
369 (tui_initialize_static_data): ...here.
370
41bcff7f
TT
3712019-06-25 Tom Tromey <tom@tromey.com>
372
373 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
374 (tui_display_registers_from, tui_check_register_values): Update.
375 (tui_display_register): Remove win_info parameter; update.
376 (tui_get_register): Change type of parameters.
377 * tui/tui-data.h (struct tui_data_element): Remove.
378 (union tui_which_element) <data>: Remove.
379 <data_window>: Change type.
380 (struct tui_data_item_window): New.
381 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
382 case. Add assert.
383 (~tui_data_item_window): New destructor.
384 (free_content_elements): Remove DATA_ITEM_WIN case.
385
d2802c33
TT
3862019-06-25 Tom Tromey <tom@tromey.com>
387
388 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
389 Remove.
390
dd835f8b
TT
3912019-06-25 Tom Tromey <tom@tromey.com>
392
393 * tui/tui-data.h (struct tui_command_element): Remove.
394 (union tui_which_element) <command>: Remove.
395 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
396 assert.
397 (free_content_elements): Remove CMD_WIN case.
398
bd7db367
TT
3992019-06-25 Tom Tromey <tom@tromey.com>
400
401 * tui/tui-layout.c (tui_set_layout): Update.
402 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
403 * tui/tui-data.c (layout_def): Update.
404
3add462f
TT
4052019-06-25 Tom Tromey <tom@tromey.com>
406
407 * tui/tui-wingeneral.c (tui_refresh_all): Update.
408 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
409 (tui_source_window_base::set_new_height): Update.
410 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
411 Update.
412 (tui_set_locator_fullname, tui_set_locator_info)
413 (tui_show_frame_info): Update.
414 * tui/tui-source.c (tui_set_source_content)
415 (tui_source_is_displayed): Update.
416 * tui/tui-layout.c (show_source_disasm_command, show_data)
417 (show_source_or_disasm_and_command): Update.
418 * tui/tui-disasm.c (tui_set_disassem_content)
419 (tui_get_begin_asm_address): Update.
420 * tui/tui-data.h (struct tui_locator_element): Remove.
421 (union tui_which_element) <locator>: Remove.
422 (struct tui_locator_window): New.
423 (tui_locator_win_info_ptr): Change return type.
424 * tui/tui-data.c (_locator): Change type.
425 (tui_locator_win_info_ptr): Change return type.
426 (init_content_element): Remove LOCATOR_WIN case. Add assert.
427 (tui_alloc_content): Add assert.
428
489e9d8b
TT
4292019-06-25 Tom Tromey <tom@tromey.com>
430
431 * tui/tui-winsource.c
432 (tui_exec_info_window::maybe_allocate_content): New method.
433 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
434 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
435 (make_source_or_disasm_window): Add cast.
436 * tui/tui-data.h (union tui_which_element) <simple_string>:
437 Remove.
438 (struct tui_source_info): New.
439 (struct tui_source_window_base) <execution_info>: Change type.
440 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
441 case, and add assert.
442 (tui_alloc_content): Add assert.
443
c3fabb7d
TT
4442019-06-25 Tom Tromey <tom@tromey.com>
445
446 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
447 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
448 * tui/tui-data.c (tui_alloc_win_info): Remove.
449
bbc228ee
TT
4502019-06-25 Tom Tromey <tom@tromey.com>
451
452 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
453 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
454 can_highlight.
455
5fcee43a
TT
4562019-06-25 Tom Tromey <tom@tromey.com>
457
458 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
459 make_visible_with_new_height method.
460 (tui_win_info::make_visible_with_new_height): New method.
461 (tui_source_window_base::do_make_visible_with_new_height)
462 (tui_data_window::do_make_visible_with_new_height)
463 (tui_cmd_window::do_make_visible_with_new_height): New methods.
464 (make_visible_with_new_height): Remove.
465 (tui_resize_all, tui_adjust_win_heights): Use
466 make_visible_with_new_height method.
467 * tui/tui-data.h (struct tui_win_info)
468 <do_make_visible_with_new_height, make_visible_with_new_height>:
469 New methods.
470 (struct tui_source_window_base, struct tui_data_window)
471 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
472 methods.
473
d83f1fe6
TT
4742019-06-25 Tom Tromey <tom@tromey.com>
475
476 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
477 method.
478 (update_tab_width): Call update_tab_width method.
479 * tui/tui-data.h (struct tui_win_info)
480 (struct tui_source_window_base) <update_tab_width>: New methods.
481
17374de4
TT
4822019-06-25 Tom Tromey <tom@tromey.com>
483
484 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
485 parameter.
486 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
487 parameter.
488 (tui_gen_win_info::make_visible): Update.
489 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
490 parameter.
491 * tui/tui-data.h (enum tui_box): New enum.
492 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
493
f936bca2
TT
4942019-06-25 Tom Tromey <tom@tromey.com>
495
496 * tui/tui-layout.c (make_source_or_disasm_window): Always use
497 init_and_make_win for EXEC_INFO_WIN.
498 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
499 longer inline.
500 (struct tui_win_info) <~tui_win_info>: Inline.
501 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
502 Don't declare.
503 * tui/tui-data.c (source_win, disasm_win): Remove globals.
504 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
505 Remove.
506 (tui_initialize_static_data): Update.
507 (~tui_gen_win_info): Handle more cleanup here.
508 (~tui_source_window_base): Delete "execution_info".
509 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
510
d6ba6a11
TT
5112019-06-25 Tom Tromey <tom@tromey.com>
512
513 * tui/tui-layout.c (make_command_window): Don't set
514 can_highlight.
515 (show_source_disasm_command): Call the reset method.
516 (show_data): Don't set can_highlight. Call the reset method.
517 (tui_gen_win_info::reset): Rename from init_gen_win_info
518 (init_and_make_win): Simplify. Return tui_gen_win_info.
519 (show_source_or_disasm_and_command): Call the reset method.
520 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
521 (struct tui_cmd_window): Set can_highlight.
522
48a3bd16
TT
5232019-06-25 Tom Tromey <tom@tromey.com>
524
525 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
526 from make_visible.
527 (tui_make_visible, tui_make_invisible): Rewrite.
528 (tui_win_info::make_visible): Remove.
529 (tui_source_window_base::make_visible): Update.
530 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
531 method. Moved from...
532 (struct tui_win_info) <make_visible>: ...here.
533
c3bd716f
TT
5342019-06-25 Tom Tromey <tom@tromey.com>
535
536 * tui/tui-winsource.c
537 (tui_source_window_base::do_scroll_horizontal): Remove direction
538 parameter.
539 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
540 direction parameter.
541 * tui/tui-win.c (tui_win_info::forward_scroll)
542 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
543 (tui_win_info::right_scroll): Update.
544 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
545 direction parameter.
546 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
547 direction parameter.
548 * tui/tui-data.h (enum tui_scroll_direction): Remove.
549 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
550 Remove direction parameter.
551 (struct tui_source_window_base, struct tui_source_window)
552 (struct tui_disasm_window, struct tui_data_window)
553 (struct tui_cmd_window): Update.
554
21c32dca
TT
5552019-06-25 Tom Tromey <tom@tromey.com>
556
557 * tui/tui-winsource.h (tui_set_exec_info_content)
558 (tui_show_exec_info_content, tui_erase_exec_info_content)
559 (tui_clear_exec_info_content, tui_update_exec_info): Change
560 argument to tui_source_window_base.
561 * tui/tui-winsource.c (tui_set_exec_info_content)
562 (tui_show_exec_info_content, tui_erase_exec_info_content)
563 (tui_clear_exec_info_content, tui_update_exec_info): Change
564 argument to tui_source_window_base.
565
73fbdc65
TT
5662019-06-25 Tom Tromey <tom@tromey.com>
567
568 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
569 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
570
33325343
TT
5712019-06-25 Tom Tromey <tom@tromey.com>
572
573 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
574 check.
575
29d2c474
TT
5762019-06-25 Tom Tromey <tom@tromey.com>
577
578 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
579 type to void.
580 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
581 type to void.
582 * tui/tui-source.c (tui_set_source_content): Update.
583 * tui/tui-disasm.c (tui_set_disassem_content): Update.
584
152f3f4b
TT
5852019-06-25 Tom Tromey <tom@tromey.com>
586
587 * tui/tui-win.c (window_name_completer, tui_set_focus)
588 (tui_all_windows_info): Use name method.
589 * tui/tui-data.h (struct tui_gen_win_info)
590 (struct tui_source_window, struct tui_disasm_window)
591 (struct tui_data_window, struct tui_cmd_window) <name>: New
592 method.
593 (tui_win_name): Don't declare.
594 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
595 (tui_win_name): Remove.
596
be4da588
TT
5972019-06-25 Tom Tromey <tom@tromey.com>
598
599 * tui/tui-winsource.h (tui_update_source_window)
600 (tui_update_source_window_as_is): Change parameter type.
601 * tui/tui-winsource.c (tui_update_source_window): Change win_info
602 to be a tui_source_window_base.
603 (tui_update_source_window_as_is): Likewise.
604 * tui/tui-win.c (make_visible_with_new_height): Update.
605
5b81daba
TT
6062019-06-25 Tom Tromey <tom@tromey.com>
607
608 * tui/tui-winsource.c (tui_erase_source_content)
609 (tui_show_source_content, tui_show_exec_info_content)
610 (tui_erase_exec_info_content): Use refresh_window method.
611 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
612 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
613 from tui_refresh_win.
614 (tui_data_window::refresh_window): New method.
615 (tui_win_info::refresh, tui_source_window_base::refresh)
616 (tui_refresh_all): Use refresh_window method.
617 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
618 method.
619 * tui/tui-regs.c (tui_display_register): Call refresh_window
620 method.
621 * tui/tui-layout.c (show_source_disasm_command)
622 (show_source_or_disasm_and_command): Call refresh_window method.
623 * tui/tui-data.h (struct tui_gen_win_info)
624 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
625 New method.
626
cb2ce893
TT
6272019-06-25 Tom Tromey <tom@tromey.com>
628
629 * tui/tui.c (tui_rl_other_window, tui_enable)
630 (tui_is_window_visible, tui_get_command_dimension): Update.
631 * tui/tui-winsource.c (tui_update_source_window_as_is)
632 (tui_clear_source_content, tui_erase_source_content)
633 (tui_show_source_line, tui_source_window_base::refill)
634 (tui_source_window_base::do_scroll_horizontal)
635 (tui_source_window_base::set_is_exec_point_at)
636 (tui_update_breakpoint_info, tui_set_exec_info_content)
637 (tui_alloc_source_buffer, tui_line_is_displayed)
638 (tui_addr_is_displayed): Update.
639 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
640 (tui_check_and_display_highlight_if_needed)
641 (tui_win_info::make_visible, tui_win_info::refresh)
642 (tui_refresh_all): Update.
643 * tui/tui-windata.c (tui_first_data_item_displayed)
644 (tui_delete_data_content_windows, tui_erase_data_content)
645 (tui_display_all_data, tui_data_window::refresh_all)
646 (tui_check_data_values): Update.
647 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
648 (tui_set_win_focus_to, tui_win_info::forward_scroll)
649 (tui_win_info::backward_scroll, tui_refresh_all_win)
650 (tui_resize_all, tui_set_focus, tui_all_windows_info)
651 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
652 (tui_source_window_base::set_new_height)
653 (tui_data_window::set_new_height)
654 (make_invisible_and_set_new_height)
655 (make_visible_with_new_height, new_height_ok)
656 (parse_scrolling_args): Update.
657 * tui/tui-stack.c (tui_show_frame_info): Update.
658 * tui/tui-source.c (tui_set_source_content)
659 (tui_set_source_content_nil, tui_source_is_displayed)
660 (tui_source_window::do_scroll_vertical): Update.
661 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
662 (tui_display_registers_from, tui_display_reg_element_at_line)
663 (tui_check_register_values, tui_reg_command): Update.
664 * tui/tui-layout.c (tui_default_win_height)
665 (show_source_disasm_command, show_data, init_and_make_win)
666 (show_source_or_disasm_and_command): Update.
667 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
668 (tui_redisplay_readline, tui_mld_flush)
669 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
670 (tui_getc): Update.
671 * tui/tui-disasm.c (tui_set_disassem_content)
672 (tui_disasm_window::do_scroll_vertical): Update.
673 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
674 Now virtual.
675 (struct tui_win_info): Derive from tui_gen_win_info.
676 <~tui_win_info>: Mark as override.
677 <generic>: Remove member.
678 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
679 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
680 (~tui_data_window, ~tui_win_info)
681 (tui_free_all_source_wins_content): Update.
682 * tui/tui-command.c (tui_refresh_cmd_win): Update.
683
ab313b35
TT
6842019-06-25 Tom Tromey <tom@tromey.com>
685
686 * tui/tui-layout.c (init_and_make_win): Use new.
687 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
688 destructor, initializers.
689 (tui_alloc_generic_win_info): Don't declare.
690 * tui/tui-data.c (_locator): Add argument to constructor.
691 (source_win, disasm_win): New globals.
692 (exec_info): Remove.
693 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
694 Update.
695 (tui_alloc_generic_win_info): Remove.
696 (init_content_element): Use new.
697 (tui_win_info::tui_win_info): Update.
698 (free_content_elements) <case DATA_WIN>: Use delete.
699
dc2c33e4
TT
7002019-06-25 Tom Tromey <tom@tromey.com>
701
702 * tui/tui-wingeneral.c (tui_refresh_win): Update.
703 * tui/tui-windata.c (tui_first_data_item_displayed)
704 (tui_delete_data_content_windows): Update.
705 * tui/tui-win.c (tui_data_window::set_new_height): Update.
706 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
707 (tui_display_registers_from, tui_check_register_values): Update.
708 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
709 pointer.
710 * tui/tui-data.c (init_content_element): Update. Allocate the new
711 window.
712 (tui_free_data_content): Update.
713 (free_content_elements) <case DATA_WIN>: Free the window.
714
214a5cbe
TT
7152019-06-25 Tom Tromey <tom@tromey.com>
716
717 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
718 Update.
719 * tui/tui-layout.c (make_command_window)
720 (show_source_disasm_command, show_data, init_and_make_win)
721 (show_source_or_disasm_and_command): Update.
722 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
723 method.
724 <can_highight, is_highlighted>: Now bool.
725 (tui_set_win_highlight): Don't declare.
726 * tui/tui-data.c (tui_set_win_highlight): Remove.
727
8e2daf15
TT
7282019-06-25 Tom Tromey <tom@tromey.com>
729
730 * tui/tui-wingeneral.c (make_visible): Remove check of window
731 type.
732
8903bd8a
TT
7332019-06-25 Tom Tromey <tom@tromey.com>
734
735 * tui/tui-win.c (tui_win_info::max_height)
736 (tui_cmd_window::max_height): New methods.
737 (new_height_ok): Call max_height.
738 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
739 <max_height>: New method.
740
3f02ce1e
TT
7412019-06-25 Tom Tromey <tom@tromey.com>
742
743 * tui/tui-win.c (tui_source_window_base::set_new_height)
744 (tui_data_window::set_new_height): New methods.
745 (make_invisible_and_set_new_height): Call set_new_height method.
746 * tui/tui-data.h (struct tui_win_info)
747 (struct tui_source_window_base, struct tui_data_window)
748 <set_new_height>: New method.
749
1825f487
TT
7502019-06-25 Tom Tromey <tom@tromey.com>
751
752 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
753 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
754 tui_refresh_data_win.
755 * tui/tui-win.c (tui_source_window_base::refresh_all): New
756 method.
757 (tui_refresh_all_win): Call the refresh_all method.
758 (tui_set_focus): Likewise.
759 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
760 (struct tui_source_window_base, struct tui_data_window) <refresh>:
761 Likewise.
762
ad54d15b
TT
7632019-06-25 Tom Tromey <tom@tromey.com>
764
765 * tui/tui-winsource.h (tui_refill_source_window)
766 (tui_set_is_exec_point_at): Don't declare.
767 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
768 (tui_source_window_base::refill): Rename from
769 tui_refill_source_window.
770 (tui_source_window_base::do_scroll_horizontal): Update.
771 (tui_source_window_base::set_is_exec_point_at): Rename from
772 tui_set_is_exec_point_at.
773 (tui_update_all_breakpoint_info): Update.
774 * tui/tui-stack.c (tui_show_frame_info): Update.
775 * tui/tui-layout.c (show_data): Add cast.
776 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
777 * tui/tui-data.h (struct tui_source_window_base) <refill,
778 set_is_exec_point_at>: New methods.
779 (tui_source_windows, tui_add_to_source_windows): Update types.
780 (tui_add_to_source_windows): Remove redundant declaration.
781 * tui/tui-data.c (source_windows): Store tui_source_window_base.
782 (tui_source_windows): Change return type.
783 (tui_clear_source_windows_detail): Update.
784 (tui_add_to_source_windows): Change type of parameter.
785 (tui_free_all_source_wins_content): Update.
786
2042b506
TT
7872019-06-25 Tom Tromey <tom@tromey.com>
788
789 * tui/tui-wingeneral.c (tui_win_info::refresh)
790 (tui_source_window_base::refresh): New methods.
791 (tui_refresh_all): Call the refresh method.
792 * tui/tui-data.h (struct tui_win_info)
793 (struct tui_source_window_base) <refresh>: New method.
794
56122977
TT
7952019-06-25 Tom Tromey <tom@tromey.com>
796
797 * tui/tui.h (tui_is_window_visible): Return bool.
798 * tui/tui.c (tui_is_window_visible): Return bool.
799 * tui/tui-wingeneral.c (tui_make_window, make_visible)
800 (tui_make_visible, tui_make_invisible)
801 (tui_win_info::make_visible)
802 (tui_source_window_base::make_visible, make_all_visible)
803 (tui_make_all_visible, tui_make_all_invisible): Update.
804 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
805 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
806 bool.
807 (struct tui_win_info, struct tui_source_window_base)
808 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
809 * tui/tui-data.c (tui_init_generic_part): Update.
810
cda37efb
TT
8112019-06-25 Tom Tromey <tom@tromey.com>
812
813 * tui/tui-wingeneral.c (tui_win_info::make_visible)
814 (tui_source_window_base::make_visible): New methods.
815 (make_all_visible): Make method call.
816 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
817 (struct tui_source_window_base, struct tui_cmd_window): Override
818 make_visible.
819 (tui_win_is_source_type): Don't declare.
820 * tui/tui-data.c (tui_win_is_source_type): Remove.
821
6a0ee02c
TT
8222019-06-25 Tom Tromey <tom@tromey.com>
823
824 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
825 NULL check.
826
63901aec
TT
8272019-06-25 Tom Tromey <tom@tromey.com>
828
829 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
830 Inline constructor. Add initializers for members.
831 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
832 constructors; now inline in class.
833
ceb13a13
TT
8342019-06-25 Tom Tromey <tom@tromey.com>
835
836 * tui/tui-regs.c (tui_show_registers): Update.
837 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
838 bool.
839 * tui/tui-data.c (tui_data_window::clear_detail)
840 (tui_data_window): Update.
841
238eb706
TT
8422019-06-25 Tom Tromey <tom@tromey.com>
843
844 * tui/tui-windata.c (tui_display_all_data)
845 (tui_display_data_from_line, tui_display_data_from)
846 (tui_check_data_values, tui_data_window::do_scroll_vertical):
847 Update.
848 * tui/tui-regs.c (tui_last_regs_line_no)
849 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
850 (tui_show_registers, tui_show_register_group)
851 (tui_display_registers_from, tui_display_reg_element_at_line)
852 (tui_display_registers_from_line, tui_check_register_values)
853 (tui_reg_next, tui_reg_prev): Update.
854 * tui/tui-layout.c (tui_set_layout, show_data): Update.
855 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
856 tui_data_window.
857 (struct tui_win_info) <detail>: Remove. Add new fields from
858 tui_data_info.
859 (TUI_DATA_WIN): Add cast.
860 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
861 (~tui_data_window): Simplify.
862
81491aa0
TT
8632019-06-25 Tom Tromey <tom@tromey.com>
864
865 * tui/tui-layout.c (show_source_disasm_command)
866 (show_source_or_disasm_and_command): Update.
867 * tui/tui-io.c (update_cmdwin_start_line)
868 (tui_redisplay_readline): Update.
869 * tui/tui-data.h (struct tui_command_info): Remove.
870 (struct tui_win_info) <detail>: Remove command_info member.
871 (struct tui_data_window) <start_line>: New member, from
872 tui_command_info.
873 (TUI_CMD_WIN): Add casts.
874
e6e41501
TT
8752019-06-25 Tom Tromey <tom@tromey.com>
876
877 * tui/tui-winsource.c (tui_update_source_window)
878 (tui_refill_source_window)
879 (tui_source_window_base::do_scroll_horizontal)
880 (tui_update_breakpoint_info, tui_set_exec_info_content)
881 (tui_show_exec_info_content, tui_erase_exec_info_content)
882 (tui_clear_exec_info_content): Update.
883 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
884 Update.
885 * tui/tui-win.c (make_invisible_and_set_new_height)
886 (make_visible_with_new_height): Update.
887 * tui/tui-source.c (tui_set_source_content)
888 (tui_show_symtab_source): Update.
889 * tui/tui-layout.c (extract_display_start_addr)
890 (show_source_disasm_command, show_data)
891 (make_source_or_disasm_window)
892 (show_source_or_disasm_and_command): Update.
893 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
894 (tui_disasm_window::do_scroll_vertical): Remove shadowing
895 "gdbarch".
896 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
897 to tui_source_window_base.
898 (struct tui_win_info) <detail>: Remove source_info member.
899 (struct tui_source_window_base) <has_locator>: Inline.
900 Move contents from tui_source_info; rename has_locator member to
901 m_has_locator.
902 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
903 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
904 header file.
905 (tui_source_window_base::clear_detail, ~tui_source_window_base):
906 Simplify.
907 (tui_free_all_source_wins_content): Cast to
908 tui_source_window_base.
909
44f0e208
TT
9102019-06-25 Tom Tromey <tom@tromey.com>
911
912 * tui/tui-win.c (make_invisible_and_set_new_height)
913 (make_visible_with_new_height): Call has_locator method.
914 * tui/tui-layout.c (show_source_disasm_command, show_data)
915 (show_source_or_disasm_and_command): Update for bool change.
916 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
917 (tui_win_info) <has_locator>: New method.
918 (struct tui_source_window_base) <has_locator>: New method.
919 (tui_win_has_locator): Don't declare.
920 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
921 from tui_win_has_locator.
922 (tui_source_window_base): Use false, not FALSE.
923
7778b912
TT
9242019-06-25 Tom Tromey <tom@tromey.com>
925
926 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
927 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
928 clear_detail method directly.
929 (tui_clear_win_detail): Remove.
930
f83d391c
TT
9312019-06-25 Tom Tromey <tom@tromey.com>
932
933 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
934 "this", not TUI_DISASM_WIN.
935
13446e05
TT
9362019-06-25 Tom Tromey <tom@tromey.com>
937
938 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
939 declare.
940 * tui/tui-winsource.c
941 (tui_source_window_base::do_scroll_horizontal): Rename from
942 tui_horizontal_source_scroll.
943 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
944 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
945 from tui_vertical_data_scroll.
946 * tui/tui-win.h (tui_scroll): Don't declare.
947 * tui/tui-win.c (tui_win_info::forward_scroll)
948 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
949 (tui_win_info::right_scroll): Rename and update.
950 (tui_scroll_forward_command, tui_scroll_backward_command)
951 (tui_scroll_left_command, tui_scroll_right_command): Update.
952 (tui_scroll): Remove.
953 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
954 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
955 from tui_vertical_source_scroll.
956 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
957 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
958 from tui_vertical_disassem_scroll.
959 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
960 do_scroll_horizontal>: New methods.
961 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
962 Likewise.
963 (struct tui_source_window_base): Add do_scroll_horizontal.
964 (struct tui_source_window, struct tui_disasm_window): Add
965 do_scroll_vertical.
966 (struct tui_data_window, struct tui_cmd_window): Add
967 do_scroll_horizontal and do_scroll_vertical.
968 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
969
5cf82909
TT
9702019-06-25 Tom Tromey <tom@tromey.com>
971
972 * tui/tui-data.h (struct tui_source_window_base): New struct.
973 (struct tui_source_window): Derive from tui_source_window_base.
974 (struct tui_disasm_window): New struct.
975 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
976 from tui_source_window::clear_detail.
977 (tui_source_window_base): Rename from tui_source_window.
978 (~tui_source_window_base): Rename from ~tui_source_window.
979 (tui_alloc_win_info): Create a tui_disasm_window.
980
ee1d42d6
TT
9812019-06-25 Tom Tromey <tom@tromey.com>
982
983 * tui/tui-data.h (struct tui_source_window)
984 (struct tui_data_window): Declare destructors.
985 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
986 destructors.
987 (tui_win_info): Simplify.
988
b4eb2452
TT
9892019-06-25 Tom Tromey <tom@tromey.com>
990
991 * tui/tui-winsource.c (tui_display_main)
992 (tui_update_source_windows_with_addr)
993 (tui_update_all_breakpoint_info): Update.
994 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
995 (new_height_ok, parse_scrolling_args): Update.
996 * tui/tui-stack.c (tui_show_frame_info): Update.
997 * tui/tui-data.h (struct tui_list): Remove.
998 (tui_source_windows): Return a reference to a std::vector.
999 * tui/tui-data.c (source_windows): Now a std::vector.
1000 (tui_source_windows): Change return type.
1001 (tui_clear_source_windows): Rewrite.
1002 (tui_clear_source_windows_detail, tui_add_to_source_windows)
1003 (tui_free_all_source_wins_content): Rewrite.
1004
8761a91b
TT
10052019-06-25 Tom Tromey <tom@tromey.com>
1006
1007 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1008 (struct tui_data_window, struct tui_cmd_window): Declare
1009 clear_detail method.
1010 * tui/tui-data.c (tui_source_window::clear_detail)
1011 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1012 methods.
1013 (tui_clear_win_detail): Simplify.
1014
0ed69eda
TT
10152019-06-25 Tom Tromey <tom@tromey.com>
1016
1017 * tui/tui-layout.c (make_source_window, make_disasm_window)
1018 (make_source_or_disasm_window): Remove win_info_ptr parameter.
1019 Return the new window.
1020 (show_source_disasm_command, show_data)
1021 (show_source_or_disasm_and_command): Update.
1022
82432e10
TT
10232019-06-25 Tom Tromey <tom@tromey.com>
1024
1025 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1026 parameter. Return the new window.
1027 (show_source_disasm_command): Update and remove NULL check.
1028 (show_source_or_disasm_and_command): Update.
1029
ec328aa5
TT
10302019-06-25 Tom Tromey <tom@tromey.com>
1031
1032 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1033
33b906ab
TT
10342019-06-25 Tom Tromey <tom@tromey.com>
1035
1036 * tui/tui-data.h (struct tui_win_info): Make constructor
1037 protected. Make destructor virtual. Add initializers.
1038 (tui_source_window, tui_data_window, tui_cmd_window): New
1039 classes.
1040 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
1041 constructor. Add "type" parameter.
1042 (tui_source_window, tui_data_window, tui_cmd_window): New
1043 constructors.
1044 (tui_alloc_win_info): Instantiate the appropriate subclass.
1045
e7e11af4
TT
10462019-06-25 Tom Tromey <tom@tromey.com>
1047
1048 * tui/tui-win.c (tui_resize_all): Use delete.
1049 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1050 destructor.
1051 (tui_free_window): Don't declare.
1052 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1053 Update.
1054
6792b55e
TT
10552019-06-25 Tom Tromey <tom@tromey.com>
1056
1057 * tui/tui-data.h (struct tui_win_info): Add constructor.
1058 * tui/tui-data.c (tui_alloc_win_info): Use new.
1059 (tui_free_window): Use delete.
1060
f95675e1
TT
10612019-06-22 Tom Tromey <tom@tromey.com>
1062
1063 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1064 declare.
1065 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1066
5bff081c
TT
10672019-06-22 Tom Tromey <tom@tromey.com>
1068
1069 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1070 declare.
1071 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1072
47e3f474
TV
10732019-06-22 Tom de Vries <tdevries@suse.de>
1074
1075 * dwarf2read.c (create_addrmap_from_aranges)
1076 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1077 instead of '%zu'.
1078
fd5866f6
SM
10792019-06-21 Simon Marchi <simon.marchi@efficios.com>
1080
1081 * dwarf2read.h (dwarf2_section_info_def): Remove.
1082 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1083 * dwarf2read.c (struct dwo_sections) <types>: Change type to
1084 std::vector<dwarf2_section_info>.
1085 (struct dwo_file) <~dwo_file>: Remove.
1086 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1087 types field.
1088 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1089 (dwarf2_read_debug_names): Likewise.
1090 (create_debug_types_hash_table): Change parameter type to
1091 array_view, adjust code accordingly.
1092 (dwarf2_locate_dwo_sections): Adjust to std::vector.
1093 (partial_die_info::fixup): Likewise.
1094 (determine_prefix): Likewise.
1095 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1096
fb1eb2f9
SM
10972019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
1098
1099 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1100 gdb_bfd_ref_ptr.
1101 <~dwo_file>: Remove call to gdb_bfd_unref.
1102 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1103 gdb_bfd_ref_ptr::get.
1104
51ac9db5
SM
11052019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
1106
1107 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1108 type to htab_up.
1109 * dwarf2read.c (struct dwo_file): Initialize fields.
1110 <~dwo_file>: New.
1111 (free_dwo_file): Remove, move content to ~dwo_file.
1112 (struct dwo_file_deleter): Remove.
1113 (dwo_file_up>: Remove custom deleter.
1114 (free_dwo_files): Remove.
1115 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1116 dwo_files.
1117 (process_skeletonless_type_units): Call unique_ptr::get.
1118 (allocate_dwo_file_hash_table): Add deleter to created hash
1119 table. Change return type to htab_up.
1120 (lookup_dwo_file_slot): Don't memset dwo_file, call
1121 unique_ptr::get.
1122 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1123 (create_dwo_unit_in_dwp_v2): Likewise.
1124 (open_and_init_dwo_file): Likewise.
1125 (free_dwo_file_from_slot): Remove.
1126
dc4ccb6f
SM
11272019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
1128
1129 * dwarf2read.h (struct dwarf2_section_info) <readin,
1130 is_virtual>: Change type to bool.
1131 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1132 true instead of 1.
1133
e6a1c5cb
TT
11342019-06-19 Tom Tromey <tom@tromey.com>
1135
1136 * tui/tui-data.h (tui_init_content_element): Don't declare.
1137
6f6ffbeb
TT
11382019-06-19 Tom Tromey <tom@tromey.com>
1139
1140 * tui/tui-data.h (tui_init_win_info): Don't declare.
1141
f23f598e
TV
11422019-06-19 Tom de Vries <tdevries@suse.de>
1143
1144 * dwarf2read.h (abstract_to_concrete): Change type to
1145 std::unordered_map<sect_offset, std::vector<sect_offset>,
1146 gdb::hash_enum<sect_offset>>.
1147
680e1bee
TT
11482019-06-19 Tom Tromey <tromey@adacore.com>
1149
1150 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1151 EVAL_AVOID_SIDE_EFFECTS specially.
1152
dcf37923
TT
11532019-06-19 Tom Tromey <tromey@adacore.com>
1154
1155 * source-cache.c (highlighter): New global.
1156 (source_cache::get_source_lines): Create a highlighter on demand.
1157
494986d5
AB
11582019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
1159
1160 * defs.h (deprecated_interactive_hook): Delete declaration.
1161 * interps.c (clear_interpreter_hooks): Remove use of
1162 deprecated_interactive_hook.
1163 * top.c (deprecated_interactive_hook): Delete definition.
1164 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1165
3360b6e7
TV
11662019-06-18 Tom de Vries <tdevries@suse.de>
1167
1168 PR gdb/24515
1169 * dwarf2read.h (abstract_to_concrete): Change type from
1170 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1171 std::unordered_map<sect_offset, std::vector<sect_offset>>.
1172 * dwarf2read.c (read_variable): Update.
1173 (dwarf2_fetch_die_loc_sect_off): Update.
1174
310b3441
TV
11752019-06-17 Tom de Vries <tdevries@suse.de>
1176
1177 PR gdb/24617
1178 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1179 accessing parent[parent_len - 1].
1180
ba9777be
PP
11812019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
1182
1183 PR gdb/24364
1184 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1185 call dtrace_process_dof with NULL dof.
1186
2b9f6e89
TV
11872019-06-16 Tom de Vries <tdevries@suse.de>
1188
1189 PR gdb/24445
1190 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1191
431b3ead
TT
11922019-06-16 Tom Tromey <tom@tromey.com>
1193
1194 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1195 (make_all_visible): Use address of member.
1196
d04b44a1
TT
11972019-06-16 Tom Tromey <tom@tromey.com>
1198
1199 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1200 (tui_free_window, free_content, free_content_elements): Remove
1201 unnecessary cast.
1202 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1203 cast.
1204 * tui/tui-regs.c (tui_show_register_group)
1205 (tui_display_registers_from, tui_display_reg_element_at_line):
1206 Remove unnecessary cast.
1207
bf5142e7
AB
12082019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
1209
1210 * linux-nat.c (normal_mask): Delete.
1211 (_initialize_linux_nat): Don't initialise normal_mask.
1212
c4973306
SM
12132019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
1214
1215 PR gdb/24445
1216 * dwarf-index-write.h (write_psymtabs_to_index): Add
1217 dwz_basename parameter.
1218 * dwarf-index-write.c (write_gdbindex): Move file writing to
1219 write_gdbindex_1. Change return type void.
1220 (assert_file_size): Move up, remove filename parameter.
1221 (write_gdbindex_1): New function.
1222 (write_debug_names): Change return type to void, call
1223 assert_file_size.
1224 (struct index_wip_file): New struct.
1225 (write_psymtabs_to_index): Add dwz_basename parameter. Move
1226 file logic to index_wip_file. Write index for dwz file if
1227 needed.
1228 (save_gdb_index_command): Pass basename of dwz file, if present.
1229 * dwarf-index-cache.c (index_cache::store): Obtain and pass
1230 build-id of dwz file, if present.
1231 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1232 (dwarf2_get_dwz_file): Likewise.
1233 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1234 (dwarf2_get_dwz_file): Likewise.
1235
395f9c91
TT
12362019-06-16 Tom Tromey <tom@tromey.com>
1237
1238 * coffread.c (process_coff_symbol): Use xstrdup.
1239 * value.c (create_internalvar): Use xstrdup.
1240
cafb3438
TT
12412019-06-16 Tom Tromey <tom@tromey.com>
1242
1243 * valops.c (value_cast, value_slice): Remove unnecessary cast.
1244 * breakpoint.c (stopin_command, stopat_command)
1245 (until_break_command, decode_location_default): Remove unnecessary
1246 cast.
1247 * utils.c (subset_compare): Remove unnecessary cast.
1248 * ada-lang.c (ada_update_initial_language): Remove unnecessary
1249 cast.
1250 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1251 cast.
1252 * infcmd.c (path_command): Remove unnecessary cast.
1253 * coffread.c (decode_type): Remove unnecessary cast.
1254 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1255 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1256 * tui/tui-stack.c (tui_show_locator_content)
1257 (tui_show_frame_info): Remove unnecessary cast.
1258 * tui/tui-win.c (tui_scroll_forward_command)
1259 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1260 (parse_scrolling_args): Remove unnecessary cast.
1261 * tui/tui-data.c (init_win_info, tui_del_window)
1262 (tui_free_window, tui_del_data_windows, tui_free_data_content)
1263 (free_content_elements): Remove unnecessary cast.
1264 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1265 unnecessary cast.
1266 * tui/tui-source.c (tui_set_source_content)
1267 (tui_vertical_source_scroll): Remove unnecessary cast.
1268 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1269 cast.
1270 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1271 * tui/tui-regs.c (tui_display_registers_from)
1272 (tui_display_register): Remove unnecessary cast.
1273 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1274 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1275 (make_visible): Remove unnecessary cast.
1276 * tui/tui-winsource.c (tui_erase_source_content)
1277 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1278 unnecessary cast.
1279 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1280 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1281 * stabsread.c (read_type, read_array_type, read_range_type):
1282 Remove unnecessary cast.
1283 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1284 (parse_symbol, parse_type, upgrade_type, parse_external)
1285 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1286 unnecessary cast.
1287 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1288
730ead81
TT
12892019-06-16 Tom Tromey <tom@tromey.com>
1290
1291 * tui/tui-data.c (tui_alloc_generic_win_info)
1292 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1293 checks.
1294
584a927c
AB
12952019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
1296 Andrew Burgess <andrew.burgess@embecosm.com>
1297
1298 * f-typeprint.c (f_print_type): Don't return early for not
1299 associated or not allocated types.
1300 (f_type_print_varspec_suffix): Add print_rank parameter and print
1301 ranks of array types in case they dangling.
1302 (f_type_print_base): Add print_rank parameter.
1303
30056ea0
AB
13042019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1305
1306 * NEWS: Mention new MI commands.
1307 * break-catch-throw.c (enum exception_event_kind): Move to
1308 breakpoint.h.
1309 (print_mention_exception_catchpoint): Output text as a single
1310 message.
1311 (catch_exception_command_1): Rename to...
1312 (catch_exception_event): ...this, make non-static, update header
1313 command, and change some parameter types.
1314 (catch_catch_command): Update for changes to
1315 catch_exception_command_1.
1316 (catch_throw_command): Likewise.
1317 (catch_rethrow_command): Likewise.
1318 * breakpoint.c (enum exception_event_kind): Delete.
1319 * breakpoint.h (enum exception_event_kind): Moved here from
1320 break-catch-throw.c.
1321 (catch_exception_event): Declare.
1322 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1323 (mi_cmd_catch_throw): New function.
1324 (mi_cmd_catch_rethrow): New function.
1325 (mi_cmd_catch_catch): New function.
1326 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1327 'catch-catch' entries.
1328 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1329 (mi_cmd_catch_rethrow): Declare.
1330 (mi_cmd_catch_catch): Declare.
1331
ec8e2b6d
AB
13322019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1333
1334 * annotate.c (annotate_source_line): Change return type to void,
1335 update implementation to match.
1336 * annotate.h (annotate_source_line): Change return type to void,
1337 update header comment.
1338 * stack.c (print_frame_info): Don't change what frame information
1339 is printed based on whether annotations are on or not.
1340
0d3abd8c
AB
13412019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1342
1343 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1344 (annotate_source): Make static.
1345 (annotate_source_line): Moved from source.c and renamed from
1346 identify_source_line. Update the return type.
1347 * annotate.h (annotate_source): Delete declaration.
1348 (annotate_source_line): Declaration moved from source.h, and
1349 renamed from identify_source_line. Return type updated.
1350 * source.c (identify_source_line): Moved to annotate.c and renamed
1351 to annotate_source_line.
1352 (info_line_command): Remove check of annotation_level.
1353 * source.h (identify_source_line): Move declaration to annotate.h
1354 and rename to annotate_source_line.
1355 * stack.c: Add 'annotate.h' include.
1356 (print_frame_info): Remove check of annotation_level before
1357 calling annotate_source_line.
1358
00df30ae
AB
13592019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1360
1361 * source-cache.c (source_cache::get_plain_source_lines): Use
1362 open_source_file_with_line_charpos instead of just
1363 open_source_file, remove call to find_source_lines.
1364 (source_cache::get_source_lines): Likewise.
1365 * source.c (find_source_lines): Make static.
1366 (get_filename_and_charpos): Renamed into...
1367 (open_source_file_with_line_charpos): ..this along with changes to
1368 return a scoped_fd, and some other minor clean ups.
1369 (identify_source_line): Use open_source_file_with_line_charpos.
1370 (search_command_helper): Use open_source_file_with_line_charpos
1371 instead of just open_source_file, remove call to
1372 find_source_lines.
1373 * source.h (open_source_file_with_line_charpos): Declare new
1374 function.
1375 (find_source_lines): Delete declaration.
1376
afda45a2
AB
13772019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1378
1379 * source.c (get_filename_and_charpos): Remove fullname
1380 parameter.
1381 (identify_source_line): Update call to get_filename_and_charpos.
1382
0735b091
TT
13832019-06-14 Tom Tromey <tromey@adacore.com>
1384
1385 PR gdb/24502:
1386 * ui-style.h (skip_ansi_escape): Update comment.
1387 * ui-file.h (class no_terminal_escape_file): New class.
1388 * ui-file.c (no_terminal_escape_file::write)
1389 (no_terminal_escape_file::puts): New methods.
1390 * cli/cli-logging.c (handle_redirections): Use
1391 no_terminal_escape_file.
1392
52ce35e2
TT
13932019-06-14 Tom Tromey <tromey@adacore.com>
1394
1395 * NEWS: Move convenience variable news above Python news.
1396
73cc7272
TT
13972019-06-14 Tom Tromey <tom@tromey.com>
1398
1399 * gnulib: Move directory to top-level.
1400 * configure.ac: Don't configure gnulib.
1401 * configure: Rebuild.
1402 * common/common-defs.h: Use new path to gnulib.
1403 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1404 (GNULIB_H): Remove.
1405 (INCGNU): Look in new gnulib location.
1406 (HFILES_NO_SRCDIR): Remove gnulib files.
1407 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1408 (generated_files): Remove GNULIB_H.
1409 ($(LIBGNU), all-lib): Remove targets.
1410 (distclean): Don't mention GNULIB_BUILDDIR.
1411 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1412
f5686554
TT
14132019-06-14 Tom Tromey <tromey@adacore.com>
1414
1415 * symfile.c (add_symbol_file_command): Remove obsolete comment.
1416 Warn if symbol file does not provide any symbols.
1417
a0c1ffed
TT
14182019-06-14 Tom Tromey <tromey@adacore.com>
1419
1420 * source.c (find_and_open_source): Respect basenames_may_differ.
1421
7c39e397
AB
14222019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
1423
1424 * annotate.c (annotate_breakpoints_invalid): Make use of
1425 scoped_restore_terminal_state.
1426 (annotate_frames_invalid): Likewise.
1427
f411722c
TT
14282019-06-14 Tom Tromey <tromey@adacore.com>
1429
1430 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1431 allow assignment to an internalvar.
1432
4268ec18
TT
14332019-06-14 Tom Tromey <tromey@adacore.com>
1434
1435 * ada-lex.l: Allow "_" in attribute names.
1436
abdb711e
TT
14372019-06-14 Tom Tromey <tromey@adacore.com>
1438
1439 PR gdb/24653:
1440 * regcache.c (registers_changed): Don't call alloca.
1441 * top.c (execute_command): Don't call alloca.
1442
4c048731
PA
14432019-06-13 Pedro Alves <palves@redhat.com>
1444
1445 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1446 'expression'. When parsing an expression, error out if there's
1447 junk after "unlimited".
1448 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1449 (do_set_command): Adjust calls to is_unlimited_literal.
1450
66eb1ed3
PA
14512019-06-13 Pedro Alves <palves@redhat.com>
1452
1453 * compile/compile.c (make_compile_options_def_group): Add braces
1454 around array_view initializer.
1455 * thread.c (make_thread_apply_all_options_def_group)
1456 (make_thread_apply_all_options_def_group): Likewise.
1457
3345721a
PA
14582019-06-13 Pedro Alves <palves@redhat.com>
1459
1460 * NEWS (New commands): Mention "maint test-options
1461 require-delimiter", "maint test-options unknown-is-error", "maint
1462 test-options unknown-is-operand" and "maint show
1463 test-options-completion-result".
1464 (New command options, command completion): New section.
1465 (Completion improvements): New section.
1466 Mention that you can abbreviate "unlimited".
1467
6206060d
PA
14682019-06-13 Pedro Alves <palves@redhat.com>
1469
1470 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1471 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1472 * unittests/cli-utils-selftests.c (test_parse_flags)
1473 (test_parse_flags_qcs): Delete.
1474 (test_cli_utils): Don't call deleted functions.
1475
6665660a
PA
14762019-06-13 Pedro Alves <palves@redhat.com>
1477
1478 * thread.c: Include "cli/cli-option.h".
1479 (tp_array_compar_ascending): Global.
1480 (tp_array_compar): Delete function.
1481 (tp_array_compar_ascending, tp_array_compar_descending): New
1482 functions.
1483 (ascending_option_def, qcs_flag_option_def)
1484 (thr_qcs_flags_option_defs)
1485 (make_thread_apply_all_options_def_group)
1486 (make_thread_apply_options_def_group): New.
1487 (thread_apply_all_command): Use gdb::option::process_options.
1488 (thread_apply_command_completer)
1489 (thread_apply_all_command_completer): New.
1490 (thread_apply_command): Use gdb::option::process_options.
1491 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1492 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
1493 to generate help text of "thread apply". Adjust "taas"'s help.
1494 * tid-parse.c (tid_range_parser::in_thread_range): New method.
1495 * tid-parse.h (tid_range_parser::in_thread_range): New method.
1496
f7e13587
PA
14972019-06-13 Pedro Alves <palves@redhat.com>
1498
1499 * thread.c (thread_apply_command): Check for invalid TID with
1500 isdigit instead of !isalpha.
1501
5d707134
PA
15022019-06-13 Pedro Alves <palves@redhat.com>
1503
1504 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1505 (validate_flags_qcs): New.
1506 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1507 (validate_flags_qcs): Declare.
1508 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1509 (make_frame_apply_options_def_group): New.
1510 (frame_apply_command_count): Process options with
1511 gdb::option::process_options.
1512 (frame_apply_completer): New.
1513 (frame_apply_level_completer, frame_apply_all_completer)
1514 (frame_apply_completer): New.
1515 (_initialize_stack): Update help of "frame apply", "frame apply
1516 level", "frame apply all" and "faas" to mention supported options
1517 and install command completers.
1518 * stack.h (frame_apply_all_completer): Declare.
1519 * thread.c: Include "stack.h".
1520 (tfaas_command): Add "--".
1521 (_initialize_thread): Update help "tfaas" to mention supported
1522 options and install command completer.
1523
272d4594
PA
15242019-06-13 Pedro Alves <palves@redhat.com>
1525
1526 * completer.c (complete_nested_command_line): New.
1527 (gdb_completion_word_break_characters_throw): Add assertion.
1528 * completer.h (complete_nested_command_line): Declare.
1529
90a1ef87
PA
15302019-06-13 Pedro Alves <palves@redhat.com>
1531
1532 * stack.c (parse_backtrace_qualifiers): New.
1533 (backtrace_command): Use it.
1534 (backtrace_command_completer): Complete on qualifiers.
1535
d4c16835
PA
15362019-06-13 Pedro Alves <palves@redhat.com>
1537
1538 * frame.c: Include "cli/cli-option.h.
1539 (user_set_backtrace_options): New.
1540 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1541 Delete.
1542 (get_prev_frame): Adjust.
1543 (boolean_option_def, uinteger_option_def)
1544 (set_backtrace_option_defs): New.
1545 (_initialize_frame): Adjust and use
1546 gdb::option::add_setshow_cmds_for_options to install "set
1547 backtrace past-main" and "set backtrace past-entry".
1548 * frame.h: Include "cli/cli-option.h".
1549 (struct frame_print_options): Forward declare.
1550 (print_frame_arguments_all, print_frame_arguments_scalars)
1551 (print_frame_arguments_none): Declare.
1552 (print_entry_values): Delete declaration.
1553 (struct frame_print_options, user_frame_print_options): New.
1554 (struct set_backtrace_options): New.
1555 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1556 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1557 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1558 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1559 (list_args_or_locals): Add frame_print_options parameter.
1560 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1561 * python/py-framefilter.c (enumerate_args): Pass down
1562 USER_FRAME_PRINT_OPTIONS.
1563 * stack.c: Include "cli/cli-option.h".
1564 (print_frame_arguments_all, print_frame_arguments_scalars)
1565 (print_frame_arguments_none): Declare.
1566 (print_raw_frame_arguments, print_entry_values): Delete.
1567 (user_frame_print_options): New.
1568 (boolean_option_def, enum_option_def, frame_print_option_defs):
1569 New.
1570 (struct backtrace_cmd_options): New.
1571 (bt_flag_option_def): New.
1572 (backtrace_command_option_defs): New.
1573 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1574 (print_frame_arg, read_frame_arg, print_frame_args)
1575 (print_frame_info, print_frame): Add frame_print_options parameter
1576 and use it.
1577 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1578 (backtrace_command_1): Add frame_print_options and
1579 backtrace_cmd_options parameters and use them.
1580 (make_backtrace_options_def_group): New.
1581 (backtrace_command): Process command options with
1582 gdb::option::process_options.
1583 (backtrace_command_completer): New.
1584 (_initialize_stack): Extend "backtrace"'s help to mention
1585 supported options. Install completer for "backtrace".
1586 Install some settings commands with add_setshow_cmds_for_options.
1587
2daf894e
PA
15882019-06-13 Pedro Alves <palves@redhat.com>
1589
1590 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1591 and that "set/show print raw frame-arguments" are now deprecated.
1592
1593 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1594 command.
1595 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1596 * stack.c (_initialize_stack): Install "set/show print
1597 raw-frame-arguments", and deprecate "set/show print raw
1598 frame-arguments".
1599 * valprint.c (_initialize_valprint): Deprecate "set/show print
1600 raw".
1601
e6ed716c
PA
16022019-06-13 Pedro Alves <palves@redhat.com>
1603
1604 * compile/compile.c (struct compile_options): New.
1605 (compile_flag_option_def, compile_command_option_defs)
1606 (make_compile_options_def_group): New.
1607 (compile_file_command): Handle options with
1608 gdb::option::process_options.
1609 (compile_file_command_completer): New function.
1610 (compile_code_command): Handle options with
1611 gdb::option::process_options.
1612 (compile_code_command_completer): New function.
1613 (_initialize_compiler): Install completers for "compile code" and
1614 "compile file". Mention available options in "compile code" and
1615 "compile code"'s help.
1616 * completer.c (advance_to_completion_word): New, factored out from
1617 ...
1618 (advance_to_expression_complete_word_point): ... this.
1619 (advance_to_filename_complete_word_point): New.
1620 * completer.h (advance_to_filename_complete_word_point): New
1621 declaration.
1622
7d8062de
PA
16232019-06-13 Pedro Alves <palves@redhat.com>
1624
1625 * compile/compile.c: Include "cli/cli-option.h".
1626 (compile_print_value): Scope data pointer is now a
1627 value_print_options pointer; adjust.
1628 (compile_print_command): Process options. Scope data pointer is
1629 now a value_print_options pointer; adjust.
1630 (_initialize_compile): Update "compile print"'s help to include
1631 supported options. Install a completer for "compile print".
1632 * cp-valprint.c (show_vtblprint, show_objectprint)
1633 (show_static_field_print): Delete.
1634 (_initialize_cp_valprint): Don't install "set print
1635 static-members", "set print vtbl", "set print object" here.
1636 * printcmd.c: Include "cli/cli-option.h" and
1637 "common/gdb_optional.h".
1638 (print_command_parse_format): Rework to fill in a
1639 value_print_options instead of a format_data.
1640 (print_value): Change parameter type from format_data pointer to
1641 value_print_options reference. Adjust.
1642 (print_command_1): Process options. Adjust to pass down a
1643 value_print_options.
1644 (print_command_completer): New.
1645 (_initialize_printcmd): Install print_command_completer as
1646 handle_brkchars completer for the "print" command. Update
1647 "print"'s help to include supported options.
1648 * valprint.c: Include "cli/cli-option.h".
1649 (show_vtblprint, show_objectprint, show_static_field_print): Moved
1650 here from cp-valprint.c.
1651 (boolean_option_def, uinteger_option_def)
1652 (value_print_option_defs, make_value_print_options_def_group):
1653 New. Use gdb::option::add_setshow_cmds_for_options to install
1654 "set print elements", "set print null-stop", "set print repeats",
1655 "set print pretty", "set print union", "set print array", "set
1656 print address", "set print symbol", "set print array-indexes".
1657 * valprint.h: Include <string> and "cli/cli-option.h".
1658 (make_value_print_options_def_group): Declare.
1659 (print_value): Change parameter type from format_data pointer to
1660 value_print_options reference.
1661 (print_command_completer): Declare.
1662
9d0faba9
PA
16632019-06-13 Pedro Alves <palves@redhat.com>
1664
1665 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1666 (COMMON_SFILES): Add maint-test-settings.c.
1667 * cli/cli-decode.c (boolean_enums): New global, factored out from
1668 ...
1669 (add_setshow_boolean_cmd): ... here.
1670 * cli/cli-decode.h (boolean_enums): Declare.
1671 * cli/cli-option.c: New file.
1672 * cli/cli-option.h: New file.
1673 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1674 factored out from ...
1675 (parse_cli_boolean_value(const char *)): ... this.
1676 (is_unlimited_literal): Change parameter type to pointer to
1677 pointer. Adjust and advance ARG pointer.
1678 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1679 (parse_cli_var_enum): New, factored out from ...
1680 (do_set_command): ... this. Adjust.
1681 * cli/cli-setshow.h (parse_cli_boolean_value)
1682 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1683 (parse_cli_var_enum): Declare.
1684 * cli/cli-utils.c: Include "cli/cli-option.h".
1685 (get_ulongest): New.
1686 * cli/cli-utils.h (get_ulongest): Declare.
1687 (check_for_argument): New overloads.
1688 * maint-test-options.c: New file.
1689
2c722807
PA
16902019-06-13 Pedro Alves <palves@redhat.com>
1691
1692 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1693 parse a range if "-" is at the end of the string.
1694
dee7b4c8
PA
16952019-06-13 Pedro Alves <palves@redhat.com>
1696
1697 * cli/cli-setshow.c (parse_auto_binary_operation)
1698 (parse_cli_boolean_value): Don't allow "o".
1699
dca0f6c0
PA
17002019-06-13 Pedro Alves <palves@redhat.com>
1701
1702 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1703 * NEWS: Mention maint test-settings KIND.
1704 * maint-test-settings.c: New file.
1705
597bf39d
PA
17062019-06-13 Pedro Alves <palves@redhat.com>
1707
1708 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1709 completer.
1710 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1711 "set" completers.
1712
48c410fb
PA
17132019-06-13 Pedro Alves <palves@redhat.com>
1714
1715 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1716 after item.
1717
93bcb043
PA
17182019-06-13 Pedro Alves <palves@redhat.com>
1719
1720 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1721
cbba3ecd
PA
17222019-06-13 Pedro Alves <palves@redhat.com>
1723
1724 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1725 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1726 call.
1727 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1728 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1729 calls.
1730 (check_for_argument): Skip spaces after argument.
1731
b9a3f842
PA
17322019-06-13 Pedro Alves <palves@redhat.com>
1733
1734 * thread.c (thread_apply_command): Adjust TID parsing.
1735 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1736 detected before end of string.
1737 (tid_is_in_list): Error out if LIST is invalid.
1738
3844e605
PA
17392019-06-13 Pedro Alves <palves@redhat.com>
1740
1741 * completer.c (complete_line_internal_1): Rewind completion word
1742 point.
1743 (completion_tracker::advance_custom_word_point_by): Change
1744 parameter type to int.
1745 * completer.h (completion_tracker::advance_custom_word_point_by):
1746 Likewise.
1747
00b56dbe
PA
17482019-06-13 Pedro Alves <palves@redhat.com>
1749
1750 * completer.c (advance_to_completion_word): Handle delimiters.
1751
d106773e
PA
17522019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
1753
1754 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1755
08f10e02
TT
17562019-06-11 Tom Tromey <tom@tromey.com>
1757
1758 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1759 (xmalloc_failed): Move to alloc.c.
1760 * alloc.c: New file.
1761 * Makefile.in (COMMON_SFILES): Add alloc.c.
1762
1c7fe951
TT
17632019-06-11 Tom Tromey <tom@tromey.com>
1764
1765 * nat/linux-waitpid.c: Don't include server.h.
1766 (linux_debug): Remove.
1767 (my_waitpid): Update.
1768
89549d7f
TT
17692019-06-11 Tom Tromey <tromey@adacore.com>
1770
1771 * infcall.c (_initialize_infcall): Remove trailing newline from
1772 help.
1773 * user-regs.c (_initialize_user_regs): Remove trailing newline
1774 from help.
1775 * typeprint.c (_initialize_typeprint): Remove trailing newline
1776 from help.
1777 * reverse.c (_initialize_reverse): Remove trailing newlines from
1778 help.
1779 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1780 from help.
1781 * language.c (add_set_language_command): Remove trailing newline
1782 from help.
1783 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1784 help.
1785 * disasm.c (_initialize_disasm): Remove trailing newline from
1786 help.
1787 * top.c (init_main): Remove trailing newline from help.
1788 * interps.c (_initialize_interpreter): Remove trailing newline
1789 from help.
1790 * btrace.c (_initialize_btrace): Remove trailing newlines from
1791 help.
1792 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1793 from help.
1794 * python/python.c (_initialize_python): Remove trailing newline
1795 from help.
1796 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1797 help.
1798 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1799 from help. Reformat some text.
1800 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1801 from help.
1802 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1803 newline from help.
1804
86108c13
TT
18052019-06-11 Tom Tromey <tromey@adacore.com>
1806
1807 * darwin-nat.c (darwin_decode_exception_message)
1808 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1809
a7067863
AB
18102019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
1811
1812 * valops.c (value_slice): Check for not allocated or not
1813 associated values.
1814
9ab08412
TV
18152019-06-10 Tom de Vries <tdevries@suse.de>
1816
1817 PR gdb/24618
1818 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1819 sure an empty slot (defined by a 32-bit zero pair) is recognized as
1820 invalid.
1821
f19e22e9
TV
18222019-06-10 Tom de Vries <tdevries@suse.de>
1823
1824 PR gdb/24611
1825 * linespec.c (linespec_lexer_lex_string): Remove incorrect
1826 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
1827
e99f9db0
TV
18282019-06-10 Tom de Vries <tdevries@suse.de>
1829
1830 PR symtab/24545
1831 * symtab.c (struct demangled_name_entry): Add language field.
1832 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
1833 static minimal symbol". Set and use language field.
1834
9bf7038b
TT
18352019-06-10 Tom Tromey <tromey@adacore.com>
1836
1837 * ada-lang.c (_initialize_ada_language): Update help text.
1838
422186a9
TT
18392019-06-10 Tom Tromey <tromey@adacore.com>
1840
1841 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1842 with a newline.
1843 * guile/guile.c (handle_boot_error): Don't end warning with a
1844 newline.
1845 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1846 warning with a newline.
1847 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1848 newline.
1849 (s12z_frame_cache): Likewise.
1850 * dwarf-index-cache.c (index_cache::store): Don't end warning with
1851 a newline.
1852 * solib-svr4.c (disable_probes_interface): Don't end warning with
1853 a newline.
1854 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1855 newline.
1856 * python/python.c (do_finish_initialization): Don't end warning
1857 with a newline.
1858
25ce02ee
TT
18592019-06-10 Tom Tromey <tom@tromey.com>
1860
1861 * python/py-breakpoint.c (gdbpy_breakpoint_created)
1862 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1863 gdbpy_enter.
1864
caa429d8
TT
18652019-06-10 Tom Tromey <tromey@adacore.com>
1866
1867 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1868 data.
1869 (elf_new_init): Don't call stabsread_new_init.
1870 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1871 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
1872 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1873
81873cc8
TV
18742019-06-10 Tom de Vries <tdevries@suse.de>
1875
1876 PR symtab/16264
1877 PR symtab/24517
1878 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1879
4fa0265e
РИ
18802019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
1881
1882 * source.c (find_and_open_source): Also rewrite relative file
1883 names.
1884
1a3da2cd
AB
18852019-04-26 Amos Bird <amosbird@gmail.com>
1886
1887 * annotate.c (annotate_thread_exited): Add "thread-exited"
1888 annotation.
1889
3847a7bf
TT
18902019-06-06 Tom Tromey <tromey@adacore.com>
1891
1892 * maint.h (class scoped_command_stats): Use
1893 DISABLE_COPY_AND_ASSIGN.
1894 <print_time>: New method.
1895 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1896 print_time.
1897 (scoped_command_stats::print_time): New method.
1898
312617a3
AB
18992019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
1900
1901 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1902 instructions of lengths 6 or 8 bytes.
1903
b02f78f9
PA
19042019-06-04 Pedro Alves <palves@redhat.com>
1905
1906 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1907
1908 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1909 * breakpoint.c (condition_completer): Likewise.
1910 * cli/cli-dump.c (scan_expression): Likewise.
1911 * common/filestuff.c (mkdir_recursive): Likewise.
1912 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1913 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1914 (gdb_abspath): Likewise.
1915 * compile/compile-cplus-types.c
1916 (compile_cplus_instance::decl_name): Likewise.
1917 * completer.c (complete_explicit_location):
1918 (signal_completer, reg_or_group_completer_1): Likewise.
1919 * cp-support.c (cp_remove_params_if_any): Likewise.
1920 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1921 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1922 * infcmd.c (strip_bg_char): Likewise.
1923 * linespec.c (copy_token_string): Likewise.
1924 * mi/mi-main.c (output_cores): Likewise.
1925 * psymtab.c (psymtab_search_name):
1926 * symfile.c (test_set_ext_lang_command): Likewise.
1927 * target.c (target_fileio_read_stralloc): Likewise.
1928 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1929 * value.c (complete_internalvar): Likewise.
1930
e1f2e1a2
CB
19312019-06-04 Christian Biesinger <cbiesinger@google.com>
1932
1933 Add objfile property to gdb.Type.
d3238f7d
PA
1934 * NEWS: Mention Python API addition.
1935 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 1936
e664d728
PW
19372019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1938
1939 * NEWS: Mention the new set|show style [title|highlight].
1940 Mention changes to "show style", "help" and "apropos".
1941
66d8c862
PW
19422019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1943
1944 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1945 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
1946 instead of print_help_for_command.
1947 (print_doc_of_command): New function.
1948 (help_list): Add 'apropos -v word' suggestion.
1949 (print_help_for_command): Style the command name using title style.
1950 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1951 (_initialize_cli_cmds): Describe -v in apropos_command help.
1952
9303eb2f
PW
19532019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1954
1955 * cli/cli-style.h (cli_style_option): Add name in constructor,
1956 add m_name class member, add constructor with intensity,
1957 add name class function.
1958 (cli_style_option::add_setshow_commands): Remove name argument.
1959 (highlight_style, title_style): New styles.
1960 * cli/cli-style.c (do_show): New function that shows a style
1961 characteristic styling the style name with itself.
1962 (set_style_name): New function.
1963 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1964 Update all callers according to the changes in cli/cli-style.h.
1965 * utils.h (fputs_highlighted): New function.
1966 * utils.c (fputs_highlighted): Likewise.
1967
e2c52041
PW
19682019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1969
1970 * NEWS: Mention new pipe command and new convenience variables.
1971
947d3946
PW
19722019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1973
1974 * cli/cli-cmds.c (pipe_command): New function.
1975 (_initialize_cli_cmds): Call add_com for pipe_command.
1976 Define | as an alias for pipe.
1977 (exit_status_set_internal_vars): New function.
1978 (shell_escape): Call exit_status_set_internal_vars.
1979 cli/cli-decode.c (find_command_name_length): Recognize | as
1980 a single character command.
1981
b8fd0918
PW
19822019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1983
1984 * gdbcmd.h (execute_command_to_ui_file): New declaration.
1985 top.c (execute_command_to_ui_file): New function, mostly a copy
1986 of execute_command_to_string.
1987 (execute_command_to_string): Implement by calling
1988 execute_command_to_ui_file.
1989
68bb5386
PW
19902019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1991
1992 * top.h (saved_command_line): Remove declaration.
1993 * top.c (previous_saved_command_line, previous_repeat_arguments):
1994 New variables.
1995 (saved_command_line): Make static, define together with other
1996 'repeat variables'.
1997 (dont_repeat): Clear repeat_arguments.
1998 (repeat_previous, get_saved_command_line, save_command_line):
1999 New functions.
2000 (gdb_init): Initialize saved_command_line
2001 and previous_saved_command_line.
2002 * main.c (captured_main_1): Remove saved_command_line initialization.
2003 * event-top.c (handle_line_of_input): Update to use
2004 the new 'repeat' related functions instead of direct access to
2005 saved_command_line.
2006 * command.h (repeat_previous, get_saved_command_line,
2007 save_command_line): New declarations.
2008 (dont_repeat): Add comment.
2009
bfcdb852
TT
20102019-05-30 Tom Tromey <tromey@adacore.com>
2011
2012 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2013 Fix comment.
2014 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2015
0ef209f2
JV
20162019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
2017
2018 PR cli/24587
2019 * completer.c (complete): Initialize variable word.
2020
955b06fa
SDJ
20212019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
2022
2023 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2024 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2025 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2026 'body' is NULL to the outter 'if', protecting the '!is_define'
2027 situation as well.
2028
fa9c3fa0
TT
20292019-05-29 Tom Tromey <tromey@adacore.com>
2030
2031 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2032 (dwarf_unknown): New function.
2033 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2034 (dwarf_type_encoding_name): Use dwarf_unknown.
2035
4330d61d
TT
20362019-05-29 Tom Tromey <tromey@adacore.com>
2037
2038 PR c++/20020:
2039 * cp-valprint.c (cp_print_value_fields): Call
2040 cp_print_static_field inside "try".
2041
33a6bc35
TT
20422019-05-29 Tom Tromey <tromey@adacore.com>
2043
2044 * inflow.c (struct terminal_info): Add default operator=.
2045 * configure: Rebuild.
2046 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2047 -Wdeprecated-copy-dtor, -Wredundant-move.
2048
000439d5
TT
20492019-05-29 Tom Tromey <tromey@adacore.com>
2050
2051 * NEWS: Add entry.
2052 * infcmd.c (print_return_value_1): Handle finish_print
2053 option.
2054 (show_print_finish): New function.
2055 (_initialize_infcmd): Add "set/show print finish" commands.
2056 * valprint.c (user_print_options): Initialize new member.
2057 * valprint.h (struct value_print_options) <finish_print>: New
2058 member.
2059
c0e70c62
TT
20602019-05-28 Tom Tromey <tromey@adacore.com>
2061
2062 * ada-lang.c (ada_remove_Xbn_suffix)
2063 (find_old_style_renaming_symbol)
2064 (parse_old_style_renaming): Remove.
2065 (ada_find_renaming_symbol): Don't call
2066 find_old_style_renaming_symbol.
2067 (ada_is_renaming_symbol): Rename from
2068 ada_find_renaming_symbol. Remove "block" parameter. Return
2069 bool. Now static.
2070 (ada_read_var_value): Update and simplify.
2071 * ada-exp.y (write_var_or_type): Remove old code.
2072
766f8836
AH
20732019-05-28 Alan Hayward <alan.hayward@arm.com>
2074
2075 * event-top.c: Remove include comment.
2076 * inflow.c (class scoped_ignore_sigttou): Move from here...
2077 * inflow.h (class scoped_ignore_sigttou): ...to here.
2078 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2079 * top.c: Remove include comment.
2080
eb41253a
TT
20812019-05-27 Tom Tromey <tom@tromey.com>
2082
2083 * NEWS: Fix typo.
2084
4ca51187
TT
20852019-05-22 Tom Tromey <tromey@adacore.com>
2086
2087 * target.c (target_follow_exec): Constify parameter.
2088 * target-delegates.c: Rebuild.
2089 * remote.c (remote_target::follow_exec): Constify parameter.
2090 * infrun.c (follow_exec): Constify parameter.
2091 * target.h (struct target_ops) <follow_exec>: Constify parameter.
2092 (target_follow_exec): Likewise.
2093
8fca4da0
AH
20942019-05-22 Alan Hayward <alan.hayward@arm.com>
2095
2096 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2097 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2098
b7060614
AH
20992019-05-22 Alan Hayward <alan.hayward@arm.com>
2100
2101 * NEWS: Add debugredirect and testsuite sections.
2102
0a5954bd
SC
21032019-05-22 Simon Cook <simon.cook@embecosm.com>
2104
2105 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2106 target descriptions using exclusively floating point register name
2107 aliases.
2108
dc42e902
AB
21092019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
2110
2111 PR gdb/18644:
2112 * f-lang.c (build_fortran_types): Handle the case where
2113 gdbarch_floatformat_for_type returns a nullptr.
2114
fb7806c7
TV
21152019-05-21 Tom de Vries <tdevries@suse.de>
2116
2117 PR cli/24587
2118 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2119
34d11c68
AB
21202019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
2121
2122 PR gdb/18644:
2123 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2124 16-byte floats.
2125 * i386-tdep.c (i386_floatformat_for_type): Use
2126 floatformats_ia64_quad for the 16-byte floating point component
2127 within a fortran 32-byte complex number.
2128
122cf0f2
AB
21292019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
2130
2131 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2132 delete default constructor.
2133 (find_partial_die): Update to return const struct.
2134 (partial_die_parent_scope): Move variable declaration into scope
2135 of its use and change its type to auto.
2136 (guess_partial_die_structure_name): Likewise.
2137 (partial_die_info::fixup): Likewise.
2138
33d0e35a
TT
21392019-05-17 Tom Tromey <tromey@adacore.com>
2140
2141 * source.c (find_and_open_source): Remove cast.
2142
a45575b0
TT
21432019-05-17 Tom Tromey <tromey@adacore.com>
2144
2145 * annotate.c (annotate_source): Make "filename" const.
2146 * annotate.h (annotate_source): Use const.
2147
81f47ac2
AH
21482019-05-17 Alan Hayward <alan.hayward@arm.com>
2149
2150 * disasm.c (set_disassembler_options): Send errors to stderr.
2151
ca1285d1
AH
21522019-05-17 Alan Hayward <alan.hayward@arm.com>
2153
2154 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2155 (cli_interp_base::set_logging): Check debug_redirect.
2156 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2157 * cli/cli-logging.c (debug_redirect): Add static variable.
2158 (pop_output_files): Add default param.
2159 (handle_redirections): Print debug setting.
2160 (show_logging_command): Likewise.
2161 (_initialize_cli_logging): Add debugredirect command.
2162 * interps.c (current_interp_set_logging): Add debug_redirect
2163 parameter.
2164 * interps.h (set_logging): Add debug_redirect parameter.
2165 (current_interp_set_logging): Likewise.
2166 * mi/mi-common.h: Likewise.
2167 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2168
21692019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
2170 Tom Tromey <tromey@adacore.com>
2171
2172 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2173 directly.
2174 * cli/cli-interp.h (make_logging_output): Remove declaration.
2175 * cli/cli-logging.c (make_logging_output): Remove function.
2176 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2177 directly.
2178 * ui-file.c (tee_file::tee_file): Remove bools.
2179 (tee_file::~tee_file): Remove deletes.
2180 * ui-file.h (tee_file): Remove bools.
2181
26648588
JV
21822019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
2183
2184 * mi/mi-cmds.h (mi_cmd_complete): New function.
2185 * mi/mi-main.c (mi_cmd_complete): Likewise.
2186 * mi/mi-cmds.c: Define new MI command -complete.
2187 * NEWS: Mention new -complete command.
2188
6e035501
JV
21892019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
2190
2191 * completer.h (complete): New function.
2192 * completer.c (complete): Likewise.
2193 * cli/cli-cmds.c: (complete_command): Update to use new complete()
2194 function defined in completer.h.
2195
7d0e2ece
JV
21962019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
2197
e79be6e5 2198 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 2199
fb816e8b
TV
22002019-05-17 Tom de Vries <tdevries@suse.de>
2201
2202 PR gdb/24094
2203 * dwarf2read.c (struct cu_partial_die_info): New struct.
2204 (find_partial_die): Return cu_partial_die_info.
2205 (partial_die_parent_scope, guess_partial_die_structure_name)
2206 (partial_die_info::fixup): Handle new return type of find_partial_die.
2207
677052f2
SDJ
22082019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2209
2210 * stap-probe.c (stap_parse_register_operand): Make "regname" an
2211 "std::string", simplifying the algorithm.
2212
f3da9116
SDJ
22132019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2214
2215 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2216 (stap_static_probe_ops::get_probes): Likewise.
2217
f1bb75ab
SDJ
22182019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2219
2220 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2221 '-')" and "else if".
2222 (stap_parse_single_operand): Join checks for
2223 "gdbarch_stap_parse_special_token_p" and
2224 "gdbarch_stap_parse_special_token" in the same "if" statement.
2225 Invert check when verifying for operation on register
2226 displacement.
2227
3ca58cde
SDJ
22282019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2229
2230 * stap-probe.c (stap_get_opcode): Update comment.
2231 (stap_get_expected_argument_type): Likewise.
2232 (handle_stap_probe): Likewise.
2233
af2d9bee
SDJ
22342019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2235
2236 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2237 return type to 'bool'. Adjust comment. Use 'bool' when
2238 appropriate.
2239 (i386_stap_parse_special_token_three_arg_disp): Likewise.
2240 * stap-probe.c (stap_parse_argument_1): Likewise.
2241 (stap_is_operator): Likewise.
2242 (stap_is_generic_prefix): Likewise.
2243 (stap_is_register_prefix): Likewise.
2244 (stap_is_register_indirection_prefix): Likewise.
2245 (stap_is_integer_prefix): Likewise.
2246 (stap_generic_check_suffix): Likewise.
2247 (stap_check_integer_suffix): Likewise.
2248 (stap_check_register_suffix): Likewise.
2249 (stap_check_register_indirection_suffix): Likewise.
2250 (stap_parse_register_operand): Likewise.
2251 (stap_parse_single_operand): Likewise.
2252 (stap_parse_argument_1): Likewise.
2253 (stap_probe::get_argument_count): Likewise.
2254 (stap_is_operator): Likewise.
2255
61c9c421
TT
22562019-05-16 Tom Tromey <tromey@adacore.com>
2257
2258 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2259 keyword to foreach.
2260
9ddc1af1
SM
22612019-05-15 Simon Marchi <simon.marchi@efficios.com>
2262
2263 * linux-thread-db.c (try_thread_db_load_1): Change return type
2264 to bool.
2265 (try_thread_db_load): Likewise.
2266 (try_thread_db_load_from_pdir_1): Likewise.
2267 (try_thread_db_load_from_pdir): Likewise.
2268 (try_thread_db_load_from_sdir): Likewise.
2269 (try_thread_db_load_from_dir): Likewise.
2270 (thread_db_load_search): Likewise.
2271 (has_libpthread): Likewise.
2272 (thread_db_load): Likewise.
2273
7bede828
SDJ
22742019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
2275
2276 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2277 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2278 NULL, and complain/return if that's the case.
2279
c5358db4
JD
22802019-05-15 John Darrington <john@darrington.wattle.id.au>
2281
2282 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2283 (advance, posn, abstract_read_memory): New functions.
2284 [struct mem_read_abstraction]: New struct.
2285 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2286
c408a94f
TT
22872019-05-14 Tom Tromey <tromey@adacore.com>
2288
2289 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2290 value is not lval_memory.
2291
e7bd7fba
TT
22922019-05-14 Tom Tromey <tromey@adacore.com>
2293
2294 * solib.c (info_sharedlibrary_command): Style the file name.
2295
a6d0f249
AH
22962019-05-14 Alan Hayward <alan.hayward@arm.com>
2297
2298 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2299 (aarch64_vnv_type): Likewise.
2300 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2301 * common/tdesc.c: Likewise.
2302 * common/tdesc.h (enum tdesc_type_kind): Likewise.
2303 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2304 * features/aarch64-fpu.xml: Add ieee half view.
2305 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2306 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2307 * gdbtypes.h (struct builtin_type): Likewise.
2308 (struct objfile_type): Likewise.
2309
66b8bb74
SM
23102019-05-12 Paul Naert <paul.naert@polymtl.ca>
2311
2312 * language.c (language_sniff_from_mangled_name): Fix "langauge"
2313 typo.
2314 * location.h (string_to_event_location): Likewise.
2315
21c219fd
JB
23162019-05-11 Joel Brobecker <brobecker@adacore.com>
2317
2318 GDB 8.3 released.
2319
13674803
SM
23202019-05-10 Simon Marchi <simon.marchi@efficios.com>
2321
2322 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2323 New variable declaration.
2324 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2325 New variable.
2326 (print_one_breakpoint): Use ui_out::test_flags and new global
2327 variable to compute use_fixed_output.
2328 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2329 Remove.
2330 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2331 (mi_multi_location_breakpoint_output_fixed): Remove.
2332 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2333 new variable.
2334 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2335 fix_multi_location_breakpoint_output flag if version >= 3.
2336 * ui-out.h (enum ui_out_flag)
2337 <fix_multi_location_breakpoint_output>: New enumerator.
2338
a9eac7f9
SM
23392019-05-10 Simon Marchi <simon.marchi@efficios.com>
2340
2341 * contrib/cc-with-tweaks.sh: Validate dwz's work.
2342
71bed2db
TT
23432019-05-10 Tom Tromey <tromey@adacore.com>
2344
2345 * ada-lang.c (catch_ada_completer): New function.
2346 (_initialize_ada_language): Use it.
2347
24c54127
TT
23482019-05-10 Tom Tromey <tromey@adacore.com>
2349
2350 * thread.c (print_thread_info): Make "requested_threads" const.
2351 * gdbthread.h (print_thread_info): Make "requested_threads"
2352 const.
2353 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2354 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2355
7a102139
TT
23562019-05-08 Tom Tromey <tom@tromey.com>
2357
2358 * gdbtypes.c (objfile_type_data): Change type.
2359 (objfile_type, _initialize_gdbtypes): Update.
2360
924d79e2
TT
23612019-05-08 Tom Tromey <tom@tromey.com>
2362
2363 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2364 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2365 (_initialize_dwarf2_frame): Update.
2366
4c58e337
TT
23672019-05-08 Tom Tromey <tom@tromey.com>
2368
2369 * objc-lang.c (objc_objfile_data): Change type.
2370 (find_methods): Update.
2371 (_initialize_objc_lang): Remove.
2372
d772d2ab
TT
23732019-05-08 Tom Tromey <tom@tromey.com>
2374
2375 * stabsread.c (rs6000_builtin_type_data): Change type.
2376 (rs6000_builtin_type, _initialize_stabsread): Update.
2377
d11d83f4
TT
23782019-05-08 Tom Tromey <tom@tromey.com>
2379
2380 * mips-tdep.c (mips_pdr_data): Remove.
2381 (_initialize_mips_tdep): Update.
2382
9a73f0ad
TT
23832019-05-08 Tom Tromey <tom@tromey.com>
2384
2385 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2386 (hppa_init_objfile_priv_data, read_unwind_info)
2387 (find_unwind_entry, _initialize_hppa_tdep): Update.
2388
8127a2fa
TT
23892019-05-08 Tom Tromey <tom@tromey.com>
2390
2391 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2392 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
2393 on obstack.
2394 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2395
91d3055d
TT
23962019-05-08 Tom Tromey <tom@tromey.com>
2397
2398 * mdebugread.c (basic_type_data): Change type.
2399 (basic_type, _initialize_mdebugread): Update.
2400
31930bd3
TT
24012019-05-08 Tom Tromey <tom@tromey.com>
2402
2403 * common/gdb_unique_ptr.h (struct noop_deleter): New.
2404
bdb3ed9e
TT
24052019-05-08 Tom Tromey <tom@tromey.com>
2406
2407 * nto-tdep.c (nto_inferior_data_reg): Change type.
2408 (nto_inferior_data): Update.
2409 (nto_inferior_data_cleanup, nto_new_inferior_data)
2410 (_initialize_nto_tdep): Remove.
2411 * nto-tdep.h (struct nto_inferior_data): Add initializers.
2412
f37b313d
TT
24132019-05-08 Tom Tromey <tom@tromey.com>
2414
2415 * ada-lang.c (struct ada_inferior_data): Add initializers.
2416 (ada_inferior_data): Change type.
2417 (ada_inferior_data_cleanup): Remove.
2418 (get_ada_inferior_data, ada_inferior_exit)
2419 (struct ada_pspace_data): Add initializers, destructor.
2420 (ada_pspace_data_handle): Change type.
2421 (get_ada_pspace_data): Update.
2422 (ada_pspace_data_cleanup): Remove.
2423
24699405
TT
24242019-05-08 Tom Tromey <tom@tromey.com>
2425
2426 * coffread.c (struct coff_symfile_info): Add initializers.
2427 (coff_objfile_data_key): Move lower. Change type.
2428 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2429 Update.
2430 (coff_free_info): Remove.
2431
d4e05d2f
TT
24322019-05-08 Tom Tromey <tom@tromey.com>
2433
2434 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2435 (fbsd_pspace_data_handle): Move lower. Change type.
2436 (get_fbsd_pspace_data): Update.
2437 (fbsd_pspace_data_cleanup): Remove.
2438 (_initialize_fbsd_tdep): Update.
2439
14ef6690
TT
24402019-05-08 Tom Tromey <tom@tromey.com>
2441
2442 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2443 (get_ada_tasks_pspace_data): Update.
2444 (ada_tasks_pspace_data_cleanup): Remove.
2445 (_initialize_tasks): Update.
2446 (ada_tasks_inferior_data_handle): Change type.
2447 (get_ada_tasks_inferior_data): Update.
2448 (ada_tasks_inferior_data_cleanup): Remove.
2449 (struct ada_tasks_pspace_data): Add initializers.
2450
814cf43a
TT
24512019-05-08 Tom Tromey <tom@tromey.com>
2452
2453 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2454 * symfile-debug.c (debug_sym_get_probes): Change type.
2455 * stap-probe.c (handle_stap_probe):
2456 (stap_static_probe_ops::get_probes): Change type.
2457 * probe.h (class static_probe_ops) <get_probes>: Change type.
2458 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2459 (parse_probes_in_pspace): Update.
2460 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2461 Update.
2462 (any_static_probe_ops::get_probes): Change type.
2463 * elfread.c (elfread_data): New typedef.
2464 (probe_key): Change type.
2465 (elf_get_probes): Likewise. Update.
2466 (probe_key_free): Remove.
2467 (_initialize_elfread): Update.
2468 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2469 Change type.
2470 (dtrace_process_dof_probe, dtrace_process_dof)
2471 (dtrace_static_probe_ops::get_probe): Change type.
2472
02dc647e
TT
24732019-05-08 Tom Tromey <tom@tromey.com>
2474
2475 * xcoffread.c (struct xcoff_symfile_info): Rename from
2476 coff_symfile_info. Add initializers.
2477 (xcoff_objfile_data_key): Move lower. Change type.
2478 (XCOFF_DATA): Rewrite.
2479 (xcoff_free_info): Remove.
2480 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2481 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2482 (xcoff_initial_scan): Update.
2483
09232438
TT
24842019-05-08 Tom Tromey <tom@tromey.com>
2485
2486 * solib-svr4.c (struct svr4_info): Add initializers and
2487 destructor.
2488 <probes_table>: Now an htab_up.
2489 (solib_svr4_pspace_data): Change type.
2490 (free_probes_table): Simplify.
2491 (~svr4_info): Rename from svr4_pspace_data_cleanup.
2492 (get_svr4_info, probes_table_htab_remove_objfile_probes)
2493 (probes_table_remove_objfile_probes, register_solib_event_probe)
2494 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2495 (_initialize_svr4_solib): Update.
2496
7b4a314f
TT
24972019-05-08 Tom Tromey <tom@tromey.com>
2498
2499 * remote.c (remote_pspace_data): Change type.
2500 (remote_pspace_data_cleanup): Remove.
2501 (get_remote_exec_file, set_pspace_remote_exec_file)
2502 (_initialize_remote): Update.
2503
51d3063a
TT
25042019-05-08 Tom Tromey <tom@tromey.com>
2505
2506 * breakpoint.c (breakpoint_objfile_key): Change type.
2507 (get_breakpoint_objfile_data): Update.
2508 (free_breakpoint_objfile_data): Remove.
2509 (_initialize_breakpoint): Update.
2510
89fb8848
TT
25112019-05-08 Tom Tromey <tom@tromey.com>
2512
2513 * linux-tdep.c (struct linux_info): Add initializers.
2514 (linux_inferior_data): Move. Change type.
2515 (invalidate_linux_cache_inf): Update.
2516 (linux_inferior_data_cleanup): Remove.
2517 (get_linux_inferior_data, _initialize_linux_tdep): Update.
2518
e9b89e2d
TT
25192019-05-08 Tom Tromey <tom@tromey.com>
2520
2521 * auxv.c (auxv_inferior_data): Move. Change type.
2522 (auxv_inferior_data_cleanup): Remove.
2523 (invalidate_auxv_cache_inf): Rewrite.
2524 (get_auxv_inferior_data, _initialize_auxv): Update.
2525
8c42777c
TT
25262019-05-08 Tom Tromey <tom@tromey.com>
2527
2528 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2529 (symfile_debug_objfile_data_key): Change type.
2530 (symfile_debug_installed, debug_qf_has_symbols)
2531 (debug_qf_find_last_source_symtab)
2532 (debug_qf_forget_cached_source_info)
2533 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2534 (debug_qf_print_stats, debug_qf_dump)
2535 (debug_qf_expand_symtabs_for_function)
2536 (debug_qf_expand_all_symtabs)
2537 (debug_qf_expand_symtabs_with_fullname)
2538 (debug_qf_map_matching_symbols)
2539 (debug_qf_expand_symtabs_matching)
2540 (debug_qf_find_pc_sect_compunit_symtab)
2541 (debug_qf_map_symbol_filenames)
2542 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2543 (debug_sym_new_init, debug_sym_init, debug_sym_read)
2544 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2545 (debug_sym_read_linetable, debug_sym_relocate): Update.
2546 (symfile_debug_free_objfile): Remove.
2547 (install_symfile_debug_logging, _initialize_symfile_debug):
2548 Update.
2549
5bfd760d
TT
25502019-05-08 Tom Tromey <tom@tromey.com>
2551
2552 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2553 allocate_on_obstack.
2554 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2555 (get_dwarf2_per_objfile): Update.
2556 (set_dwarf2_per_objfile): Remove.
2557 (dwarf2_has_info, dwarf2_get_section_info): Update.
2558 (dwarf2_free_objfile): Remove.
2559 (_initialize_dwarf2_read): Update.
2560
e85e19b4
TT
25612019-05-08 Tom Tromey <tom@tromey.com>
2562
2563 * auto-load.c (struct auto_load_pspace_info): Add destructor and
2564 initializers.
2565 <unsupported_script_warning_printed,
2566 script_not_found_warning_printed>: Now bool.
2567 (auto_load_pspace_data): Change type.
2568 (~auto_load_pspace_info): Rename from
2569 auto_load_pspace_data_cleanup.
2570 (get_auto_load_pspace_data, init_loaded_scripts_info)
2571 (clear_section_scripts, maybe_print_unsupported_script_warning)
2572 (maybe_print_script_not_found_warning, _initialize_auto_load):
2573 Update.
2574
f6aa7436
TT
25752019-05-08 Tom Tromey <tom@tromey.com>
2576
2577 * objfiles.c (objfile_pspace_info): Add destructor and
2578 initializers.
2579 (objfiles_pspace_data): Change type.
2580 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2581 (get_objfile_pspace_data): Update.
2582 (objfiles_bfd_data): Change type.
2583 (get_objfile_bfd_data): Update.
2584 (objfile_bfd_data_free, _initialize_objfiles): Remove.
2585
6ae614f6
TT
25862019-05-08 Tom Tromey <tom@tromey.com>
2587
2588 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2589 Change type.
2590 (get_catch_syscall_inferior_data): Update.
2591 (catch_syscall_inferior_data_cleanup): Remove.
2592 (_initialize_break_catch_syscall): Update.
2593
6509b8eb
TT
25942019-05-08 Tom Tromey <tom@tromey.com>
2595
2596 * inflow.c (struct terminal_info): Add destructor and
2597 initializers.
2598 (inflow_inferior_data): Change type.
2599 (~terminal_info): Rename from inflow_inferior_data_cleanup.
2600 (get_inflow_inferior_data, inflow_inferior_exit)
2601 (swap_terminal_info, _initialize_inflow): Update.
2602
35632941
TT
26032019-05-08 Tom Tromey <tom@tromey.com>
2604
2605 * target-dcache.c (target_dcache_cleanup): Remove.
2606 (target_dcache_aspace_key): Change type.
2607 (target_dcache_init_p, target_dcache_invalidate)
2608 (target_dcache_get, target_dcache_get_or_init)
2609 (_initialize_target_dcache): Update.
2610 * dcache.h (struct dcache_deleter): New.
2611
3017b94d
TT
26122019-05-08 Tom Tromey <tom@tromey.com>
2613
2614 * symtab.c (struct symbol_cache): Add destructor and
2615 initializers.
2616 (symbol_cache_key): Move. Change type.
2617 (make_symbol_cache, free_symbol_cache): Remove.
2618 (get_symbol_cache): Update.
2619 (symbol_cache_cleanup): Remove.
2620 (ALL_PSPACES, symbol_cache_flush)
2621 (maintenance_print_symbol_cache)
2622 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2623 Update.
2624
a32ad8c5
TT
26252019-05-08 Tom Tromey <tom@tromey.com>
2626
2627 * symtab.c (struct main_info): Add destructor and initializers.
2628 (main_progspace_key): Move. Change type.
2629 (get_main_info): Update.
2630 (main_info_cleanup): Remove.
2631 (_initialize_symtab): Update.
2632
5f6e90a0
TT
26332019-05-08 Tom Tromey <tom@tromey.com>
2634
2635 * registry.h (DECLARE_REGISTRY): Define the _key class.
2636
1bd0c6e4
AB
26372019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
2638
2639 * NEWS: Merge two 'New commands' sections.
2640
2228ef77
XR
26412019-05-08 Joel Brobecker <brobecker@adacore.com>
2642
2643 * ada-valprint.c (ada_val_print_gnat_array): Remove language
2644 parameter and use Ada language definition instead.
2645 (ada_val_print_ptr): Remove unused language parameter.
2646 (ada_val_print_num): Remove language parameter and use Ada language
2647 definition instead.
2648 (ada_val_print_enum, ada_val_print_flt): Remove unused language
2649 parameter.
2650 (ada_val_print_struct_union, ada_val_print_ref): Remove language
2651 parameter and use Ada language definition instead.
2652 (ada_val_print_1): Update all ada_val_print_xxx calls.
2653 Remove language parameter.
2654 (ada_val_print): Update ada_val_print_1 call.
2655
60fcc1c3
TT
26562019-05-08 Tom Tromey <tromey@adacore.com>
2657
2658 * remote.c (remote_hw_watchpoint_limit)
2659 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2660 Now static.
2661
ed2b7c17
TT
26622019-05-08 Tom Tromey <tromey@adacore.com>
2663
2664 * maint.c (_initialize_maint_cmds): Move initialization code to
2665 remote.c.
2666 (watchdog, show_watchdog): Move to remote.c.
2667 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
2668 "watchdog" static.
2669 (_initialize_remote): Move initialization code from maint.c.
2670 * defs.h (watchdog): Don't declare.
2671
b0be6c91
TT
26722019-05-08 Tom Tromey <tromey@adacore.com>
2673
2674 * tui/tui-interp.c: Include main.h.
2675 * interps.c: Include main.h.
2676 * main.h (interpreter_p): Declare.
2677 * defs.h (interpreter_p): Don't declare.
2678
587ee17b
TT
26792019-05-08 Tom Tromey <tromey@adacore.com>
2680
2681 * dwarf2loc.c: Include dwarf2read.h.
2682 * defs.h (read_unsigned_leb128): Don't declare.
2683 * dwarf2read.h (read_unsigned_leb128): Declare.
2684
ca1df239
TT
26852019-05-08 Tom Tromey <tromey@adacore.com>
2686
2687 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2688 method.
2689
99f20f08
TT
26902019-05-08 Tom Tromey <tromey@adacore.com>
2691
2692 * utils.c (fputs_maybe_filtered): Reset style after paging, even
2693 when no wrap column is set.
2694
80e55b13
TT
26952019-05-08 Tom Tromey <tromey@adacore.com>
2696
2697 * c-lang.c (c_get_string): Handle non-C-style arrays.
2698
9d3421af
TT
26992019-05-08 Tom Tromey <tromey@adacore.com>
2700
2701 * typeprint.c (print_offset_data::update): Print the bit offset,
2702 not the number of bits remaining.
2703
844333e2
TT
27042019-05-08 Tom Tromey <tromey@adacore.com>
2705
2706 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2707 padding at end of comment.
2708
988915ee
TT
27092019-05-08 Tom Tromey <tromey@adacore.com>
2710
2711 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2712 Compare main types.
2713
26bfd823
TT
27142019-05-06 Tom Tromey <tom@tromey.com>
2715
2716 * common/scoped_mmap.c: Include common-defs.h.
2717 * common/scoped_mmap.h: Don't include config.h.
2718
89055eaa
TT
27192019-05-04 Tom Tromey <tom@tromey.com>
2720
2721 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2722 (struct aarch64_call_info): Add initializers.
2723 <si>: Now a std::vector.
2724 (pass_on_stack, aarch64_push_dummy_call): Update.
2725
5da01df5
TT
27262019-05-04 Simon Marchi <simon.marchi@efficios.com>
2727 Tom Tromey <tom@tromey.com>
2728
2729 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2730 (ppc_threads): Now a std::vector. Now static.
2731 (hwdebug_find_thread_points_by_tid)
2732 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2733 Update.
2734
fbdf05a1
TT
27352019-05-04 Tom Tromey <tom@tromey.com>
2736
2737 * arc-tdep.c (arc_tdesc_init): Return bool.
2738
06d16ec9
TT
27392019-05-04 Tom Tromey <tom@tromey.com>
2740
2741 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2742 Use gdb_assert_not_reached.
2743
9c056022
TT
27442019-05-04 Tom Tromey <tom@tromey.com>
2745
2746 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2747 "false".
2748
fa9c2a59
TT
27492019-05-04 Tom Tromey <tom@tromey.com>
2750
2751 * arc-tdep.c (arc_tdesc_init): Use bool.
2752
e2eb806a
TT
27532019-05-04 Tom Tromey <tom@tromey.com>
2754
2755 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2756
6fe87677
TT
27572019-05-04 Tom Tromey <tom@tromey.com>
2758
2759 * cli/cli-cmds.c (valid_command_p): Return bool.
2760
7f008c9e
TT
27612019-05-04 Tom Tromey <tom@tromey.com>
2762
2763 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2764 * command.h (valid_user_defined_cmd_name_p): Channge return type.
2765
b6484282
RT
27662019-05-04 Raul Tambre <raul@tambre.ee>
2767
2768 * python/lib/gdb/prompt.py (_ExtendedPrompt)
2769 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2770 operator for comparison.
2771
af97b416
TT
27722019-05-04 Tom Tromey <tom@tromey.com>
2773
2774 * psymtab.c (psymbol_name_matches, match_partial_symbol)
2775 (lookup_partial_symbol, print_partial_symbols)
2776 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2777 (psymbol_compare): Update.
2778 (add_psymbol_to_bcache): Clear the entire psymbol.
2779 (maintenance_check_psymtabs): Update.
2780 * psympriv.h (struct partial_symbol): Don't derive from
2781 general_symbol_info.
2782 <obj_section, unrelocated_address, address,
2783 set_unrelocated_address>: Update.
2784 <ginfo>: New member.
2785 * dwarf-index-write.c (write_psymbols, debug_names::insert)
2786 (debug_names::write_psymbols): Update.
2787
9d6d4be8
TV
27882019-05-04 Tom de Vries <tdevries@suse.de>
2789
2790 * contrib/cc-with-tweaks.sh: Support -n arg.
2791
66452beb
PW
27922019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2793
2794 * corelow.c (core_target::detach): Ensure frame cache and
2795 register caches are cleared.
2796 inferior.c (exit_inferior_1): Likewise.
2797
bde09ab7
TT
27982019-05-03 Sandra Loosemore <sandra@codesourcery.com>
2799 Tom Tromey <tom@tromey.com>
2800
2801 * dictionary.c (collate_pending_symbols_by_language): Remove
2802 "struct" from foreach.
2803 * symtab.c (lookup_global_symbol_from_objfile)
2804 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2805 foreach.
2806 * ser-tcp.c (net_open): Remove "struct" from foreach.
2807 * objfiles.c (objfile_relocate, objfile_rebase)
2808 (objfile_has_symbols): Remove "struct" from foreach.
2809 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2810 from foreach.
2811 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2812 foreach.
2813 * darwin-nat.c (thread_info_from_private_thread_info): Remove
2814 "struct" from foreach.
2815 * ada-lang.c (create_excep_cond_exprs)
2816 (ada_exception_catchpoint_cond_string): Remove "struct" from
2817 foreach.
2818
222a8d25
TT
28192019-05-03 Tom Tromey <tromey@adacore.com>
2820
2821 * ada-exp.y (convert_char_literal): Check suffix of each
2822 enumerator.
2823
fcd60b84
DP
28242019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
2825
2826 PR ada/21406:
2827 * ada-exp.y (yywrap): Don't define.
2828 * ada-lex.l (%option): Add noyywrap
2829 (yywrap): Remove.
2830
5f2459c2
EZ
28312019-05-03 Eli Zaretskii <eliz@gnu.org>
2832
353ea2d1
EZ
2833 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2834 _WIN32_WINNT to the XP level, unless already defined to a higher
2835 level.
2836
2837 * unittests/parse-connection-spec-selftests.c:
2838 * ser-tcp.c:
2839 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
2840 override.
2841
5f2459c2
EZ
2842 * symfile.c (find_separate_debug_file): Remove colon from the
2843 drive spec of DOS/Windows file names of the target, so that the
2844 file name produced from DEBUGDIR and the target's directory will
2845 be valid on DOS/Windows systems.
2846
80062eb9
AB
28472019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
2848
2849 * rust-lang.c (val_print_struct): Handle printing structures
2850 containing strings.
2851
b8c05e85
TT
28522019-05-02 Tom Tromey <tromey@adacore.com>
2853
2854 * valarith.c (_initialize_valarith): Remove.
2855
4504bbde
TT
28562019-05-01 Tom Tromey <tromey@adacore.com>
2857
2858 * ada-lang.c (ada_value_primitive_field): Treat more fields as
2859 bitfields.
2860
d48e62f4
TT
28612019-05-01 Tom Tromey <tromey@adacore.com>
2862
2863 * ada-lang.c (ada_value_assign): Correctly compute starting offset
2864 for big-endian copies.
2865
15f18d14
AT
28662019-04-30 Ali Tamur <tamur@google.com>
2867 * gdb/dwarf2read.c (read_3_bytes): New declaration.
2868 (read_attribute_value): Added DW_FORM_strx1-4 cases.
2869 (read_3_bytes): New function.
2870
ab4ee614
JB
28712019-04-30 Joel Brobecker <brobecker@adacore.com>
2872
2873 * windows-nat.c (main_thread_id): Delete.
2874 (handle_output_debug_string): Replace main_thread_id by
2875 current_event.dwThreadId.
2876 (fake_create_process): Likewise.
2877 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2878 Do not set main_thread_id.
2879 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2880 current_event.dwThreadId.
2881 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2882
8ed5b76e
JB
28832019-04-30 Joel Brobecker <brobecker@adacore.com>
2884
2885 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2886 Use current_event.dwThreadId instead of main_thread_id.
2887
2ff0a947
TT
28882019-04-30 Tom Tromey <tromey@adacore.com>
2889
2890 * ada-lang.c (ada_lookup_simple_minsyms): New function.
2891 (create_excep_cond_exprs): Iterate over program spaces.
2892 (ada_exception_catchpoint_cond_string): Examine all minimal
2893 symbols for exception types.
2894
a776957c
TT
28952019-04-30 Tom Tromey <tromey@adacore.com>
2896
2897 PR c++/24470:
2898 * dwarf2read.c (process_structure_scope): Handle case where type
2899 has template parameters but no symbol was created.
2900
bc68014d
AB
29012019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2902 Chris January <chris.january@arm.com>
2903
2904 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2905 qualifier.
2906 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2907
f1fdc960
AB
29082019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2909
2910 * f-typeprint.c (f_print_type): Update rules for printing
2911 whitespace.
2912 (f_type_print_varspec_suffix): Likewise.
2913
bf7a4de1
AB
29142019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2915 Chris January <chris.january@arm.com>
2916
2917 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2918 function arguments.
2919
bbe75b9d
AB
29202019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2921
2922 * f-lang.c (build_fortran_types): Change name of void type to
2923 lower case.
2924 * f-typeprint.c (f_type_print_base): Print the name of the void
2925 type, rather than a fixed string.
2926 * f-valprint.c (f_decorations): Use lower case void string.
2927
1db455a7
AB
29282019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2929 Chris January <chris.january@arm.com>
2930
2931 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2932 types for Fortran.
2933
b6d03bb2
AB
29342019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2935 Chris January <chris.january@arm.com>
2936 David Lecomber <david.lecomber@arm.com>
2937
2938 * f-exp.y (BINOP_INTRINSIC): New token.
2939 (exp): New parser rule handling BINOP_INTRINSIC.
2940 (f77_keywords): Add new builtin procedures.
2941 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2942 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2943 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2944 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2945 (print_unop_subexp_f): New function.
2946 (print_binop_subexp_f): New function.
2947 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2948 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2949 (dump_subexp_body_f): Likewise.
2950 (operator_check_f): Likewise.
2951 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2952 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2953
83228e93
AB
29542019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2955
2956 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2957 UNOP_KIND.
2958 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2959 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2960 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2961 (operator_length_f): New fuction.
2962 (print_subexp_f): New function.
2963 (op_name_f): New function.
2964 (dump_subexp_body_f): New function.
2965 (operator_check_f): New function.
2966 (exp_descriptor_f): Replace standard expression handling functions
2967 with new functions.
2968 * gdb/fortran-operator.def: New file.
2969 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2970 * gdb/std-operator.def: Remove UNOP_KIND.
2971
6fdcd7cc
AB
29722019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
2973
2974 * std-operator.def: Remove unbalanced, stray double quote
2975 character.
2976
2e62ab40
AB
29772019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
2978 Chris January <chris.january@arm.com>
2979 Daniel Everett <daniel.everett@arm.com>
2980 Nick Forrington <nick.forrington@arm.com>
2981 Richard Bunt <richard.bunt@arm.com>
2982
2983 * cp-valprint.c (cp_print_value_fields): Allow an additional level
2984 of depth when printing anonymous structs or unions.
2985 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2986 Don't print either the top-level value, or the children if the
2987 max-depth is exceeded.
2988 (ppscm_print_children): When printing the key of a map, allow one
2989 extra level of depth.
2990 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2991 print either the top-level value, or the children if the max-depth
2992 is exceeded.
2993 (print_children): When printing the key of a map, allow one extra
2994 level of depth.
2995 * python/py-value.c (valpy_format_string): Add max_depth keyword.
2996 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2997 (user_print_options): Initialise max_depth field.
2998 (val_print_scalar_or_string_type_p): New function.
2999 (val_print): Check to see if the max depth has been reached.
3000 (val_print_check_max_depth): Define new function.
3001 (show_print_max_depth): New function.
3002 (_initialize_valprint): Add 'print max-depth' option.
3003 * valprint.h (struct value_print_options) <max_depth>: New field.
3004 (val_print_check_max_depth): Declare new function.
3005 * NEWS: Document new feature.
3006
4be290b2
AB
30072019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
3008
3009 * ada-lang.c (ada_language_defn): Initialise new field.
3010 * c-lang.c (c_is_string_type_p): New function.
3011 (c_language_defn): Initialise new field.
3012 (cplus_language_defn): Initialise new field.
3013 (asm_language_defn): Initialise new field.
3014 (minimal_language_defn): Initialise new field.
3015 * c-lang.h (c_is_string_type_p): Declare new function.
3016 * d-lang.c (d_language_defn): Initialise new field.
3017 * f-lang.c (f_is_string_type_p): New function.
3018 (f_language_defn): Initialise new field.
3019 * go-lang.c (go_is_string_type_p): New function.
3020 (go_language_defn): Initialise new field.
3021 * language.c (default_is_string_type_p): New function.
3022 (unknown_language_defn): Initialise new field.
3023 (auto_language_defn): Initialise new field.
3024 * language.h (struct language_defn) <la_is_string_type_p>: New
3025 member variable.
3026 (default_is_string_type_p): Declare new function.
3027 * m2-lang.c (m2_language_defn): Initialise new field.
3028 * objc-lang.c (objc_language_defn): Initialise new field.
3029 * opencl-lang.c (opencl_language_defn): Initialise new field.
3030 * p-lang.c (pascal_is_string_type_p): New function.
3031 (pascal_language_defn): Initialise new field.
3032 * rust-lang.c (rust_is_string_type_p): New function.
3033 (rust_language_defn): Initialise new field.
3034
721b08c6
AB
30352019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
3036
3037 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3038 New field.
3039 * ada-lang.c (ada_language_defn): Initialise new field.
3040 * c-lang.c (c_language_defn): Likewise.
3041 (cplus_language_defn): Likewise.
3042 (asm_language_defn): Likewise.
3043 (minimal_language_defn): Likewise.
3044 * d-lang.c (d_language_defn): Likewise.
3045 * f-lang.c (f_language_defn): Likewise.
3046 * go-lang.c (go_language_defn): Likewise.
3047 * language.c (unknown_language_defn): Likewise.
3048 (auto_language_defn): Likewise.
3049 * m2-lang.c (m2_language_defn): Likewise.
3050 * objc-lang.c (objc_language_defn): Likewise.
3051 * opencl-lang.c (opencl_language_defn): Likewise.
3052 * p-lang.c (pascal_language_defn): Likewise.
3053 * rust-lang.c (rust_language_defn): Likewise.
3054
fc913e53
AB
30552019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
3056
3057 * ada-lang.c (ada_is_character_type): Change return type to bool.
3058 (ada_is_string_type): Likewise.
3059 * ada-lang.h (ada_is_character_type): Update declaration
3060 (ada_is_string_type): Likewise.
3061
fa731fa0
PW
30622019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3063
3064 Support style in 'frame|thread apply'
3065
3066 * gdbcmd.h (execute_command_to_string): New term_out parameter.
3067 * record.c (record_start, record_stop): Update callers of
3068 execute_command_to_string with false.
3069 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3070 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3071 methods.
3072 (class string_file): New constructor with term_out parameter.
3073 Override methods term_out and can_emit_style_escape. New member
3074 term_out.
3075 (class stdio_file): Override can_emit_style_escape.
3076 (class tee_file): Override term_out and can_emit_style_escape.
3077 * utils.h (can_emit_style_escape): Remove.
3078 * utils.c (can_emit_style_escape): Likewise.
3079 Update all callers of can_emit_style_escape (SOMESTREAM) to
3080 SOMESTREAM->can_emit_style_escape.
3081 * source-cache.c (source_cache::get_source_lines): Likewise.
3082 * stack.c (frame_apply_command_count): Call execute_command_to_string
3083 passing the term_out characteristic of the current gdb_stdout.
3084 * thread.c (thr_try_catch_cmd): Likewise.
3085 * top.c (execute_command_to_string): pass term_out parameter
3086 to construct the string_file for the command output.
3087 * ui-file.c (term_cli_styling): New function (most code moved
3088 from utils.c can_emit_style_escape).
3089 (string_file::string_file, string_file::can_emit_style_escape,
3090 stdio_file::can_emit_style_escape, tee_file::term_out,
3091 tee_file::can_emit_style_escape): New functions.
3092
136afab8
PW
30932019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3094
3095 * NEWS: Mention the new set|show may-call-functions.
3096 * infcall.c (may_call_functions_p): New variable.
3097 (show_may_call_functions_p): New function.
3098 (call_function_by_hand_dummy): Throws an error if not
3099 may-call-functions.
3100 (_initialize_infcall): Call add_setshow_boolean_cmd for
3101 may-call-functions.
3102
725cbb63
KS
31032019-04-25 Keith Seitz <keiths@redhat.com>
3104
3105 PR c++/24367
3106 * cp-support.c (inspect_type): Don't attempt substitutions
3107 of symbol with the same name.
3108
3d1cbb78
TT
31092019-04-25 Tom Tromey <tromey@adacore.com>
3110
3111 PR gdb/24475:
3112 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3113 static.
3114
94aeb44b
TT
31152019-04-25 Tom Tromey <tromey@adacore.com>
3116
3117 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3118 rvalue reference.
3119 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3120 (gdb_xml_parser::parse): Use std::move.
3121 * python/python-internal.h (gdbpy_convert_exception): Take a const
3122 reference.
3123 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3124 std::move.
3125 * python/py-utils.c (gdbpy_convert_exception): Take a const
3126 reference.
3127 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3128 Use std::move.
3129 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3130 Use std::move.
3131 * mi/mi-main.c (mi_print_exception): Take a const reference.
3132 * main.c (handle_command_errors): Take a const reference.
3133 * linespec.c (parse_linespec): Use std::move.
3134 * infcall.c (run_inferior_call): Use std::move.
3135 (call_function_by_hand_dummy): Use std::move.
3136 * exec.c (try_open_exec_file): Use std::move.
3137 * exceptions.h (exception_print, exception_fprintf)
3138 (exception_print_same): Update.
3139 * exceptions.c (print_exception, exception_print)
3140 (exception_fprintf, exception_print_same): Change parameters to
3141 const reference.
3142 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3143 * common/new-op.c: Use std::move.
3144 * common/common-exceptions.h (struct gdb_exception): Add move
3145 constructor.
3146 (struct gdb_exception_error, struct gdb_exception_quit, struct
3147 gdb_quit_bad_alloc): Change constructor to move constructor.
3148 (throw_exception): Change parameter to rvalue reference.
3149 * common/common-exceptions.c (throw_exception): Take rvalue
3150 reference.
3151 * cli/cli-interp.c (safe_execute_command): Use std::move.
3152 * breakpoint.c (insert_bp_location, location_to_sals): Use
3153 std::move.
3154
680d7fd5
TT
31552019-04-25 Tom Tromey <tromey@adacore.com>
3156
3157 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3158 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3159 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3160 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3161 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3162 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3163 guile/scm-value.c: Use unpack.
3164 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3165 gdbscm_gdb_exception.
3166 (gdbscm_throw_gdb_exception): Likewise.
3167 (struct gdbscm_gdb_exception): New.
3168 (unpack): New function.
3169 (gdbscm_wrap): Use unpack.
3170
c6fdd8b2
TT
31712019-04-25 Tom Tromey <tromey@adacore.com>
3172
3173 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3174 (gdb_rl_callback_handler): Use std::move.
3175 * common/common-exceptions.h (struct gdb_exception): Add move
3176 assignment operator.
3177 (throw_exception_sjlj): Change "exception" to const reference.
3178 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3179 (throw_exception_sjlj): Change "exception" to const reference.
3180
cc06b668
TT
31812019-04-25 Tom Tromey <tromey@adacore.com>
3182
3183 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3184 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3185 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3186 Update.
3187 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3188 Update.
3189 * mi/mi-interp.c (mi_interp::exec): Update.
3190 * linespec.c (parse_linespec): Update.
3191 * infcall.c (run_inferior_call): Update.
3192 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3193 * guile/scm-symbol.c (gdbscm_lookup_symbol)
3194 (gdbscm_lookup_global_symbol): Update.
3195 * guile/scm-param.c (gdbscm_parameter_value): Update.
3196 * guile/scm-frame.c (gdbscm_frame_read_register)
3197 (gdbscm_frame_read_var): Update.
3198 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3199 * exec.c (try_open_exec_file): Update.
3200 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3201 (gdb_rl_callback_handler): Update.
3202 * common/common-exceptions.h (exception_none): Don't declare.
3203 * common/common-exceptions.c (exception_none): Don't define.
3204 (struct catcher) <exception>: Update.
3205 * cli/cli-interp.c (safe_execute_command): Update.
3206 * breakpoint.c (insert_bp_location, location_to_sals): Update.
3207
cf532bd1
AT
32082019-04-25 Ali Tamur <tamur@google.com>
3209
3210 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3211 (read_attribute_value): Likewise.
3212 (dwarf2_read_addr_index): Update comment.
3213 (read_str_index): Add DW_FORM_strx.
3214 (dwarf2_string_attr): Likewise.
3215 (dwarf2_const_value_attr): Likewise.
3216 (dump_die_shallow): Likewise.
3217 (dwarf2_fetch_constant_bytes): Likewise.
3218 (skip_form_bytes): Likewise.
3219 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3220
82433e3e
SDJ
32212019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
3222
3223 PR corefiles/11608
3224 PR corefiles/18187
3225 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3226 OFFSET. Verify if current mapping contains an ELF header.
3227 (linux_find_memory_regions_full): Adjust call to
3228 dump_mapping_p.
3229
723adb65
SL
32302019-04-25 Sandra Loosemore <sandra@codesourcery.com>
3231 Kang Li <kanglictf@gmail.com>
3232
3233 PR gdb/21600
3234
3235 * dwarf2-frame.c (read_initial_length): Be consistent about using
3236 unsigned representation of length.
3237 (decode_frame_entry_1): Likewise. Check for wraparound of
3238 end pointer as well as buffer overflow.
3239
596179f7
SDJ
32402019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
3241
3242 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3243 "vq".
3244
a59240a4
TT
32452019-04-24 Tom Tromey <tromey@adacore.com>
3246
3247 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3248
f872fdbb
AB
32492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3250
3251 * s12z-tdep.c (s12z_unwind_pc): Delete.
3252 (s12z_unwind_sp): Delete.
3253 (s12z_gdbarch_init): Don't register deleted functions with
3254 gdbarch.
3255
b614e6f3
AB
32562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3257
3258 * rl78-tdep.c (rl78_unwind_sp): Delete.
3259 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3260
14faed38
AB
32612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3262
3263 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3264 (xstormy16_unwind_pc): Delete.
3265 (xstormy16_dummy_id): Delete.
3266 (xstormy16_gdbarch_init): Don't register deleted functions with
3267 gdbarch.
3268
541aad8a
AB
32692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3270
3271 * vax-tdep.c (vax_unwind_pc): Delete.
3272 (vax_gdbarch_init): Don't register deleted function with gdbarch.
3273
29222070
AB
32742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3275
3276 * v850-tdep.c (v850_unwind_sp): Delete.
3277 (v850_unwind_pc): Delete.
3278 (v850_dummy_id): Delete.
3279 (v850_gdbarch_init): Don't register deleted functions with
3280 gdbarch.
3281
0f534d76
AB
32822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3283
3284 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3285 (tilegx_unwind_pc): Delete.
3286 (tilegx_unwind_dummy_id): Delete.
3287 (tilegx_gdbarch_init): Don't register deleted functions with
3288 gdbarch.
3289
1ba7b7f9
AB
32902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3291
3292 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3293 (tic6x_dummy_id): Delete.
3294 (tic6x_gdbarch_init): Don't register deleted functions with
3295 gdbarch.
3296
d31f262c
AB
32972019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3298
3299 * sparc-tdep.c (sparc_unwind_pc): Delete.
3300 (sparc32_gdbarch_init): Don't register deleted function with
3301 gdbarch.
3302
6d14d64d
AB
33032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3304
3305 * sh-tdep.c (sh_unwind_sp): Delete.
3306 (sh_unwind_pc): Delete.
3307 (sh_dummy_id): Delete.
3308 (sh_gdbarch_init): Don't register deleted functions with
3309 gdbarch.
3310
a40dde9d
AB
33112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3312
3313 * score-tdep.c (score_unwind_sp): Delete.
3314 (score_unwind_pc): Delete.
3315 (score_dummy_id): Delete.
3316 (score_gdbarch_init): Don't register deleted functions with
3317 gdbarch.
3318
47c47d69
AB
33192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3320
3321 * rx-tdep.c (rx_unwind_pc): Delete.
3322 (rx_unwind_sp): Delete.
3323 (rx_dummy_id): Delete.
3324 (rx_gdbarch_init): Don't register deleted functions with
3325 gdbarch. Update comment.
3326
833a4480
AB
33272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3328
3329 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3330 (rs6000_dummy_id): Delete.
3331 (rs6000_gdbarch_init): Don't register deleted functions with
3332 gdbarch.
3333
3f2cef49
AB
33342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3335
3336 * or1k-tdep.c (or1k_dummy_id): Delete.
3337 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3338
96acf884
AB
33392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3340
3341 * nios2-tdep.c (nios2_dummy_id): Delete.
3342 (nios2_unwind_sp): Delete.
3343 (nios2_gdbarch_init): Don't register deleted functions with
3344 gdbarch.
3345
ca0ab0aa
AB
33462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3347
3348 * nds32-tdep.c (nds32_dummy_id): Delete.
3349 (nds32_unwind_pc): Delete.
3350 (nds32_unwind_sp): Delete.
3351 (nds32_gdbarch_init): Don't register deleted functions with
3352 gdbarch.
3353
c8259044
AB
33542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3355
3356 * msp430-tdep.c (msp430_unwind_pc): Delete.
3357 (msp430_unwind_sp): Delete.
3358 (msp430_dummy_id): Delete.
3359 (msp430_gdbarch_init): Don't register deleted functions with
3360 gdbarch.
3361
27f113c8
AB
33622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3363
3364 * moxie-tdep.c (moxie_unwind_sp): Delete.
3365 (moxie_unwind_pc): Delete.
3366 (moxie_dummy_id): Delete.
3367 (moxie_gdbarch_init): Don't register deleted functions with
3368 gdbarch.
3369
aee6c3cd
AB
33702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3371
3372 * mn10300-tdep.c (mn10300_dummy_id): Delete.
3373 (mn10300_unwind_pc): Delete.
3374 (mn10300_unwind_sp): Delete.
3375 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3376 mn10300_unwind_sp.
3377 (mn10300_frame_unwind_init): Don't register deleted functions with
3378 gdbarch.
3379
8e2b5aea
AB
33802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3381
3382 * mep-tdep.c (mep_unwind_pc): Delete.
3383 (mep_unwind_sp): Delete.
3384 (mep_dummy_id): Delete.
3385 (mep_gdbarch_init): Don't register deleted functions with
3386 gdbarch.
3387
43cf3ede
AB
33882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3389
3390 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3391 (m68hc11_unwind_sp): Delete.
3392 (m68hc11_gdbarch_init): Don't register deleted functions with
3393 gdbarch.
3394
5e79b7bb
AB
33952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3396
3397 * m32r-tdep.c (m32r_unwind_sp): Delete.
3398 (m32r_unwind_pc): Delete.
3399 (m32r_dummy_id): Delete.
3400 (m32r_gdbarch_init): Don't register deleted functions with
3401 gdbarch.
3402
89b268d8
AB
34032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3404
3405 * m32c-tdep.c (m32c_unwind_pc): Delete.
3406 (m32c_unwind_sp): Delete.
3407 (m32c_dummy_id): Delete.
3408 (m32c_gdbarch_init): Don't register deleted functions with
3409 gdbarch.
3410
946c28d2
AB
34112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3412
3413 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3414 (lm32_unwind_pc): Delete.
3415 (lm32_dummy_id): Delete.
3416 (lm32_gdbarch_init): Don't register deleted functions with
3417 gdbarch.
3418
bf12844a
AB
34192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3420
3421 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3422 (iq2000_unwind_pc): Delete.
3423 (iq2000_dummy_id): Delete.
3424 (iq2000_gdbarch_init): Don't register deleted functions with
3425 gdbarch.
3426
ecbc06d2
AB
34272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3428
3429 * nds32-tdep.c (nds32_type_align): Delete.
3430 (nds32_push_dummy_call): Use type_align instead.
3431
030197b4
AB
34322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3433
3434 * arm-tdep.c (arm_type_align): Only handle vector override case.
3435 (arm_push_dummy_call): Use type_align.
3436 (arm_gdbarch_init): Register arm_type_align gdbarch function.
3437
b907456c
AB
34382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3439
3440 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3441 case.
3442 (pass_on_stack): Use type_align.
3443 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3444 function.
3445
9e97ba43
TT
34462019-04-23 Tom Tromey <tromey@adacore.com>
3447
3448 * dwarf2read.c (line_header::file_name_at): Remove unused
3449 overload.
3450
6892f601
TV
34512019-04-23 Tom de Vries <tdevries@suse.de>
3452
3453 PR gdb/24438
3454 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3455 invocation.
3456
336d760d
AT
3457
34582019-03-27 Ali Tamur <tamur@google.com>
3459
3460 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3461 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3462 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3463 (dwarf_expr_context::get_addr_index): Likewise
3464 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3465 (symbol_needs_eval_context::get_addr_index): Likewise
3466 (disassemble_dwarf_expression): Add DW_OP_addrx
3467 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3468 (read_cutu_die_from_dwo): Update comment
3469 (skip_one_die): Add DW_FORM_addrx
3470 (read_attribute_value): Likewise
3471 (var_decode_location): Add DW_OP_addrx
3472 (dwarf2_const_value_attr): Add DW_FORM_addrx
3473 (dump_die_shallow): Likewise
3474 (dwarf2_fetch_constant_bytes): Likewise
3475 (decode_locdesc): Add DW_OP_addrx
3476 (skip_form_bytes): Add DW_FORM_addrx
3477
ad9d13f8
AT
34782019-04-22 Ali Tamur <tamur@google.com>
3479
3480 * MAINTAINERS (Write After Approval): Add self.
3481
d70cc3ba
SM
34822019-04-22 Simon Marchi <simon.marchi@efficios.com>
3483
3484 * solib-svr4.c (get_svr4_info): Add pspace parameter.
3485 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3486 (open_symbol_file_object): Likewise.
3487 (svr4_default_sos): Add info parameter.
3488 (svr4_read_so_list): Likewise.
3489 (svr4_current_sos_direct): Adjust functions calls to pass down
3490 info.
3491 (svr4_current_sos_1): Add info parameter.
3492 (svr4_current_sos): Call get_svr4_info, pass info down to
3493 svr4_current_sos_1.
3494 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3495 get_svr4_info.
3496 (svr4_in_dynsym_resolve_code): Pass current_program_space to
3497 get_svr4_info.
3498 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3499 to get_svr4_info.
3500 (probes_table_remove_objfile_probes): Likewise.
3501 (register_solib_event_probe): Add info parameter.
3502 (solist_update_incremental): Pass info parameter down to
3503 svr4_read_so_list.
3504 (disable_probes_interface): Add info parameter.
3505 (svr4_handle_solib_event): Pass current_program_space to
3506 get_svr4_info. Adjust disable_probes_interface cleanup.
3507 (svr4_create_probe_breakpoints): Add info parameter, pass it
3508 down to register_solib_event_probe.
3509 (svr4_create_solib_event_breakpoints): Add info parameter,
3510 pass it down to svr4_create_probe_breakpoints.
3511 (enable_break): Pass info down to
3512 svr4_create_solib_event_breakpoints.
3513 (svr4_solib_create_inferior_hook): Pass current_program_space to
3514 get_svr4_info.
3515 (svr4_clear_solib): Likewise.
3516
7905fc35
PA
35172019-04-22 Pedro Alves <palves@redhat.com>
3518
3519 * solib-svr4.c (svr4_free_objfile_observer): New.
3520 (probe_and_action::objfile): New field.
3521 (probes_table_htab_remove_objfile_probes)
3522 (probes_table_remove_objfile_probes): New functions.
3523 (register_solib_event_probe): Add 'objfile' parameter. Store it
3524 in the new probe_and_action. Don't store the probe in 'lookup'.
3525 (svr4_create_probe_breakpoints): Pass objfile to
3526 register_solib_event_probe.
3527 (_initialize_svr4_solib): Register a free_objfile observer.
3528
fb881986
TT
35292019-04-19 Tom Tromey <tom@tromey.com>
3530
3531 * common/queue.h: Remove.
3532
8732db6c
TT
35332019-04-19 Tom Tromey <tom@tromey.com>
3534
3535 * event-loop.c: Don't include "common/queue.h".
3536
97dfbadd
TT
35372019-04-19 Tom Tromey <tom@tromey.com>
3538
3539 * remote.c (remote_target): Use delete.
3540 * remote-notif.h: Include <list>, not "common/queue.h".
3541 (notif_client_p): Remove typedef.
3542 (remote_notif_state): Add constructor, destructor, initializer.
3543 <notif_queue>: Now a std::list.
3544 (remote_notif_state_xfree): Don't declare.
3545 * remote-notif.c (remote_notif_process, handle_notification)
3546 (remote_notif_state_allocate): Update.
3547 (~remote_notif_state): Rename from remote_notif_state_xfree.
3548
cf250e36
TT
35492019-04-19 Tom Tromey <tom@tromey.com>
3550
3551 * symfile.c (reread_symbols): Update.
3552 * objfiles.c (objfile_register_static_link)
3553 (objfile_lookup_static_link): Update
3554 (~objfile) Don't delete static_links.
3555 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3556
61f4b350
TT
35572019-04-19 Tom Tromey <tom@tromey.com>
3558
3559 * type-stack.h (struct type_stack) <insert>: Constify string.
3560 * type-stack.c (type_stack::insert): Constify string.
3561 * gdbtypes.h (lookup_template_type): Update.
3562 (address_space_name_to_int): Update.
3563 * gdbtypes.c (address_space_name_to_int): Make space_identifier
3564 const.
3565 (lookup_template_type): Make name const.
3566 * c-exp.y: Update rules.
3567 (lex_one_token, classify_name, classify_inner_name)
3568 (c_print_token): Update.
3569 * p-exp.y: Update rules.
3570 (yylex): Update.
3571 * f-exp.y: Update rules.
3572 (yylex): Update.
3573 * d-exp.y: Update rules.
3574 (lex_one_token, classify_name, classify_inner_name): Update.
3575 * parse.c (write_dollar_variable, copy_name): Return std::string.
3576 * parser-defs.h (copy_name): Change return type.
3577 * m2-exp.y: Update rules.
3578 (yylex): Update.
3579 * go-exp.y (lex_one_token): Update.
3580 Update rules.
3581 (classify_unsafe_function, classify_packaged_name)
3582 (classify_name, yylex): Update.
3583
189b8c2e
ST
35842019-04-19 Sergei Trofimovich <siarheit@google.com>
3585
3586 * configure.ac: add --enable-source-highlight switch.
3587 * configure: Regenerate.
3588 * top.c (print_gdb_version): plumb --enable-source-highlight
3589 status to "show configuration".
3590
8ecb59f8
TT
35912019-04-19 Tom Tromey <tromey@adacore.com>
3592
3593 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3594 Check ADA_TYPE_P.
3595 (empty_record, ada_template_to_fixed_record_type_1)
3596 (template_to_static_fixed_type)
3597 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3598 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3599 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3600 macros.
3601
62160ec9
TT
36022019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
3603
3604 PR symtab/24423:
3605 * source.c (print_source_lines_base): Advance "iter" when a
3606 control character is seen.
3607
f2ae8bc8
PW
36082019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3609
3610 * inferior.h (struct infcall_suspend_state_deleter):
3611 Catch exception in destructor to avoid crash.
3612
d563b953
PW
36132019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3614
3615 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3616 close to the add_com "shell".
3617
dc34c897
TT
36182019-04-18 Tom Tromey <tromey@adacore.com>
3619
3620 * process-stratum-target.h (class process_stratum_target)
3621 <stratum>: Add "final".
3622
a12e5744
TT
36232019-04-17 Tom Tromey <tromey@adacore.com>
3624
3625 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3626 against nullptr before use.
3627
a7e559cc
AH
36282019-04-17 Alan Hayward <alan.hayward@arm.com>
3629
3630 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3631
c01660c6
AB
36322019-04-17 Jim Wilson <jimw@sifive.com>
3633 Andrew Burgess <andrew.burgess@embecosm.com>
3634
3635 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3636 code read might fail, assume 4-byte breakpoint in that case.
3637
4aa866af
LS
36382019-04-15 Leszek Swirski <leszeks@google.com>
3639
3640 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3641 rather than a hand-rolled POD check when checking for forced MEMORY
3642 classification.
3643
48574d91
AH
36442019-04-15 Alan Hayward <alan.hayward@arm.com>
3645
3646 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3647 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3648 function.
3649 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3650 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3651 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3652 declaration.
3653
4da037ef
AH
36542019-04-15 Alan Hayward <alan.hayward@arm.com>
3655
3656 * aarch64-linux-nat.c
3657 (aarch64_linux_nat_target::thread_architecture): Add override.
3658 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3659 each VQ.
3660
ccb8d7e8
AH
36612019-04-15 Alan Hayward <alan.hayward@arm.com>
3662
3663 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3664
35add35e
AB
36652019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
3666
3667 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3668 target types of size 96-bits, add some additional comments, and
3669 check that the builtin type we found was the correct size.
3670
51196bbc
EZ
36712019-04-12 Eli Zaretskii <eliz@gnu.org>
3672
3673 * utils.c (prompt_for_continue): Don't restore the styling at the
3674 end, as applied_style has the wrong value. This fixes styling in
3675 long lists of file names that are interrupted by the "Continue?"
3676 prompt.
3677
62253a61
AB
36782019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
3679
3680 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3681 * c-lang.c (c_language_defn): Likewise.
3682 (cplus_language_defn): Likewise.
3683 (asm_language_defn): Likewise.
3684 (minimal_language_defn): Likewise.
3685 * d-lang.c (d_language_defn): Likewise.
3686 * f-lang.c (f_language_defn): Likewise.
3687 * go-lang.c (go_language_defn): Likewise.
3688 * language.c (unknown_language_defn): Likewise.
3689 (auto_language_defn): Likewise.
3690 * language.h (struct language_defn): Remove la_magic field.
3691 (LANG_MAGIC): Delete.
3692 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3693 * objc-lang.c (objc_language_defn): Likewise.
3694 * opencl-lang.c (opencl_language_defn): Likewise.
3695 * p-lang.c (pascal_language_defn): Likewise.
3696 * rust-lang.c (rust_language_defn): Likewise.
3697
a9158a86
AB
36982019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
3699
3700 * riscv-tdep.c (riscv_type_align): New function.
3701 (riscv_type_alignment): Delete.
3702 (riscv_arg_location): Use 'type_align'.
3703 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3704
41077b66
AB
37052019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
3706
3707 * gdbtypes.c (type_align): A struct with no non-static fields also
3708 has alignment of 1.
3709
9f0272f8
AB
37102019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
3711
3712 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3713 component to 0.
3714 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3715 member.
3716 (riscv_struct_info::analyse): New implementation using new
3717 analyse_inner member function.
3718 (riscv_struct_info::field_offset): New member function.
3719 (riscv_struct_info::m_offsets): New member variable.
3720 (riscv_struct_info::analyse_inner): New private member function,
3721 takes the old implementation of riscv_struct_info::analyse but
3722 extended to track field offsets.
3723 (riscv_call_arg_struct): Update the struct folding special cases
3724 to handle cases where empty C++ structs, which are non-zero
3725 length, are found.
3726 (riscv_arg_location): Initialise the length of each location, a
3727 non-zero length now indicates the location is in use.
3728 (riscv_push_dummy_call): Allow for the first location having a
3729 non-zero offset when setting up arguments.
3730 (riscv_return_value): Likewise, but for return values.
3731
02cf60c7
TT
37322019-04-11 Tom Tromey <tromey@adacore.com>
3733
3734 * utils.c (internal_vproblem): Make "msg" const.
3735
68811f8f
AH
37362019-04-11 Alan Hayward <alan.hayward@arm.com>
3737
3738 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3739 * trad-frame.c (trad_frame_reset_saved_regs): New function.
3740 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3741 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3742
3f52fdbc
KB
37432019-04-10 Kevin Buettner <kevinb@redhat.com>
3744
3745 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3746 function.
3747 (fill_gregset): Call amd64_linux_collect_native_gregset instead
3748 of amd64_collect_native_gregset.
3749 (amd64_linux_nat_target::store_registers): Likewise.
3750
e9ad22ee
TT
37512019-04-10 Tom Tromey <tom@tromey.com>
3752
3753 * symtab.c (lookup_global_symbol_from_objfile)
3754 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3755 * objfiles.h (class separate_debug_iterator): New.
3756 (class separate_debug_range): New.
3757 (struct objfile) <separate_debug_objfiles>: New method.
3758 (objfile_separate_debug_iterate): Don't declare.
3759 * objfiles.c (separate_debug_iterator::operator++): Rename from
3760 objfile_separate_debug_iterate.
3761 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3762 iterator.
3763 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3764 iterator.
3765
ee371134
TT
37662019-04-10 Tom Tromey <tom@tromey.com>
3767
3768 * symfile.c (reread_symbols): Remove old comment.
3769 * objfiles.c (free_all_objfiles): Fix a typo.
3770
bf227d61
TT
37712019-04-10 Tom Tromey <tom@tromey.com>
3772
3773 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3774 * minsyms.c (lookup_minimal_symbol): Use foreach.
3775 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3776 (lookup_minimal_symbol_solib_trampoline): Likewise.
3777 * symfile.c (reread_symbols): Use foreach.
3778
8dc433a0
TT
37792019-04-09 Ivan Begert <ivanbegert@gmail.com>
3780 Tom Tromey <tromey@adacore.com>
3781
3782 PR rust/24414:
3783 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3784 (rust_lex_int_test): Change "value" to be LONGEST.
3785 (rust_lex_tests): Add test for long integer literal.
3786
9ab8741a
TT
37872019-04-09 Tom Tromey <tromey@adacore.com>
3788
3789 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3790 to bool.
3791 (extended_remote_target::attach): Update.
3792 (remote_target::remote_notice_new_inferior): Update.
3793 (remote_target::add_current_inferior_and_thread): Update.
3794 * inferior.c (exit_inferior_1): Use "false".
3795 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3796
e242fd12
SM
37972019-04-09 Simon Marchi <simon.marchi@efficios.com>
3798
9ca1957f 3799 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
3800 the "start" command.
3801
2b0c8b01
KB
38022019-04-08 Kevin Buettner <kevinb@redhat.com>
3803
3804 * python/py-inferior.c (infpy_thread_from_thread_handle):
3805 Adjust comments to reflect renaming of thread_from_thread_handle
3806 to thread_from_handle. Adjust keywords. Fix type error message.
3807 (inferior_object_methods): Add thread_from_handle. Retain
3808 thread_from_thread_handle, but mark it as deprecated.
3809
50a82723
KB
38102019-04-08 Kevin Buettner <kevinb@redhat.com>
3811
3812 * gdbthread.h (find_thread_by_handle): Revise declaration.
3813 * thread.c (find_thread_by_handle): Likewise. Adjust
3814 implementation too.
3815 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3816 support for buffer objects as handles.
3817
cf63b016
KB
38182019-04-08 Kevin Buettner <kevinb@redhat.com>
3819
3820 * python/py-infthread.c (thpy_thread_handle): New function.
3821 (thread_object_methods): Register thpy_thread_handle.
3822
3d6c6204
KB
38232019-04-08 Kevin Buettner <kevinb@redhat.com>
3824
3825 * gdbthread.h (thread_to_thread_handle): Declare.
3826 * thread.c (gdbtypes.h): Include.
3827 (thread_to_thread_handle): New function.
3828
3829 * target.h (struct target_ops): Add thread_info_to_thread_handle.
3830 (target_thread_info_to_thread_handle): Declare.
3831 * target.c (target_thread_info_to_thread_handle): New function.
3832 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3833 * target-delegates.c: Regenerate.
3834
3835 * linux-thread-db.c (class thread_db_target): Add method
3836 thread_info_to_thread_handle.
3837 (thread_db_target::thread_info_to_thread_handle): Define.
3838 * remote.c (class remote_target): Add new method
3839 thread_info_to_thread_handle.
3840 (remote_target::thread_info_to_thread_handle): Define.
3841
56be6ea8
PA
38422019-04-08 Pedro Alves <palves@redhat.com>
3843
3844 * common/common-exceptions.c (throw_exception): Don't create
3845 named object to throw; throw directly.
3846 (throw_it): Likewise. Don't initialize gdb_exception::message
3847 here, with new; pass FMT and AP to the ctor instead.
3848 * common/common-exceptions.h: Include <string>.
3849 (gdb_exception::gdb_exception(enum return_reason, enum errors,
3850 const char *, va_list)): New ctor. Use std::make_shared.
3851 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3852 errors)): Delete.
3853 (gdb_exception_error::gdb_exception_error(enum errors, const char
3854 *, va_list)): New.
3855 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3856 Add assertion.
3857 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3858 errors)): Delete.
3859 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3860 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3861 Add assertion.
3862
eedc3f4f
TT
38632019-04-08 Tom Tromey <tom@tromey.com>
3864
3865 * valops.c (value_rtti_indirect_type): Replace throw_exception
3866 with throw.
3867 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3868 with throw.
3869 * thread.c (thr_try_catch_cmd): Replace throw_exception with
3870 throw.
3871 * target.c (target_translate_tls_address): Replace throw_exception
3872 with throw.
3873 * stack.c (frame_apply_command_count): Replace throw_exception
3874 with throw.
3875 * solib-spu.c (append_ocl_sos): Replace throw_exception with
3876 throw.
3877 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3878 with throw.
3879 * rs6000-tdep.c (rs6000_frame_cache)
3880 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3881 * remote.c: Replace throw_exception with throw.
3882 * record-full.c (record_full_message, record_full_wait_1)
3883 (record_full_restore): Replace throw_exception with throw.
3884 * record-btrace.c:
3885 (get_thread_current_frame_id, record_btrace_start_replaying)
3886 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3887 (cmd_record_btrace_start): Replace throw_exception with throw.
3888 * parse.c (parse_exp_in_context_1): Replace throw_exception with
3889 throw.
3890 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3891 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3892 * linespec.c:
3893 (find_linespec_symbols): Replace throw_exception with throw.
3894 * infrun.c (displaced_step_prepare, resume): Replace
3895 throw_exception with throw.
3896 * infcmd.c (post_create_inferior): Replace throw_exception with
3897 throw.
3898 * inf-loop.c (inferior_event_handler): Replace throw_exception
3899 with throw.
3900 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3901 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3902 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3903 (get_prev_frame_always, get_frame_pc_if_available)
3904 (get_frame_address_in_block_if_available, get_frame_language):
3905 Replace throw_exception with throw.
3906 * frame-unwind.c (frame_unwind_try_unwinder): Replace
3907 throw_exception with throw.
3908 * eval.c (fetch_subexp_value, evaluate_var_value)
3909 (evaluate_funcall, evaluate_subexp_standard): Replace
3910 throw_exception with throw.
3911 * dwarf2loc.c (call_site_find_chain)
3912 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3913 Replace throw_exception with throw.
3914 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3915 with throw.
3916 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3917 throw.
3918 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3919 * completer.c (complete_line_internal): Replace throw_exception
3920 with throw.
3921 * compile/compile-object-run.c (compile_object_run): Replace
3922 throw_exception with throw.
3923 * cli/cli-script.c (process_next_line): Replace throw_exception
3924 with throw.
3925 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3926 (btrace_enable, btrace_maint_update_pt_packets): Replace
3927 throw_exception with throw.
3928 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3929 throw_exception with throw.
3930 * break-catch-throw.c (re_set_exception_catchpoint): Replace
3931 throw_exception with throw.
3932 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3933 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3934 * aarch64-tdep.c (aarch64_make_prologue_cache)
3935 (aarch64_make_stub_cache): Replace throw_exception with throw.
3936
26003a20
TT
39372019-04-08 Tom Tromey <tom@tromey.com>
3938
3939 * common/common-exceptions.c (throw_exception): Rename from
3940 throw_exception_cxx. Remove old copy. Make argument const.
3941 (throw_it): Create and throw exception objects directly.
3942 * common/common-exceptions.h (throw_exception): Make argument
3943 const.
3944 (struct gdb_exception_error): Add constructor.
3945 (struct gdb_exception_quit): Add constructor.
3946
d272eb37
TT
39472019-04-08 Tom Tromey <tom@tromey.com>
3948
3949 * common/common-exceptions.h (exception_rethrow): Don't declare.
3950 (TRY_SJLJ): Update comment.
3951 (TRY, CATCH, END_CATCH): Remove.
3952 * common/common-exceptions.c (exception_rethrow): Remove.
3953
230d2906
TT
39542019-04-08 Tom Tromey <tom@tromey.com>
3955
3956 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3957 Remove.
3958 (gdb_exception_error): Rename from
3959 gdb_exception_RETURN_MASK_ERROR.
3960 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3961 (gdb_quit_bad_alloc): Update.
3962 * aarch64-tdep.c: Update.
3963 * ada-lang.c: Update.
3964 * ada-typeprint.c: Update.
3965 * ada-valprint.c: Update.
3966 * amd64-tdep.c: Update.
3967 * arch-utils.c: Update.
3968 * break-catch-throw.c: Update.
3969 * breakpoint.c: Update.
3970 * btrace.c: Update.
3971 * c-varobj.c: Update.
3972 * cli/cli-cmds.c: Update.
3973 * cli/cli-interp.c: Update.
3974 * cli/cli-script.c: Update.
3975 * common/common-exceptions.c: Update.
3976 * common/new-op.c: Update.
3977 * common/selftest.c: Update.
3978 * compile/compile-c-symbols.c: Update.
3979 * compile/compile-cplus-symbols.c: Update.
3980 * compile/compile-object-load.c: Update.
3981 * compile/compile-object-run.c: Update.
3982 * completer.c: Update.
3983 * corelow.c: Update.
3984 * cp-abi.c: Update.
3985 * cp-support.c: Update.
3986 * cp-valprint.c: Update.
3987 * darwin-nat.c: Update.
3988 * disasm-selftests.c: Update.
3989 * dtrace-probe.c: Update.
3990 * dwarf-index-cache.c: Update.
3991 * dwarf-index-write.c: Update.
3992 * dwarf2-frame-tailcall.c: Update.
3993 * dwarf2-frame.c: Update.
3994 * dwarf2loc.c: Update.
3995 * dwarf2read.c: Update.
3996 * eval.c: Update.
3997 * event-loop.c: Update.
3998 * event-top.c: Update.
3999 * exec.c: Update.
4000 * f-valprint.c: Update.
4001 * fbsd-tdep.c: Update.
4002 * frame-unwind.c: Update.
4003 * frame.c: Update.
4004 * gdbtypes.c: Update.
4005 * gnu-v3-abi.c: Update.
4006 * guile/guile-internal.h: Update.
4007 * guile/scm-block.c: Update.
4008 * guile/scm-breakpoint.c: Update.
4009 * guile/scm-cmd.c: Update.
4010 * guile/scm-disasm.c: Update.
4011 * guile/scm-frame.c: Update.
4012 * guile/scm-lazy-string.c: Update.
4013 * guile/scm-math.c: Update.
4014 * guile/scm-param.c: Update.
4015 * guile/scm-ports.c: Update.
4016 * guile/scm-pretty-print.c: Update.
4017 * guile/scm-symbol.c: Update.
4018 * guile/scm-symtab.c: Update.
4019 * guile/scm-type.c: Update.
4020 * guile/scm-value.c: Update.
4021 * i386-linux-tdep.c: Update.
4022 * i386-tdep.c: Update.
4023 * inf-loop.c: Update.
4024 * infcall.c: Update.
4025 * infcmd.c: Update.
4026 * infrun.c: Update.
4027 * jit.c: Update.
4028 * language.c: Update.
4029 * linespec.c: Update.
4030 * linux-fork.c: Update.
4031 * linux-nat.c: Update.
4032 * linux-tdep.c: Update.
4033 * linux-thread-db.c: Update.
4034 * main.c: Update.
4035 * mi/mi-cmd-break.c: Update.
4036 * mi/mi-cmd-stack.c: Update.
4037 * mi/mi-interp.c: Update.
4038 * mi/mi-main.c: Update.
4039 * objc-lang.c: Update.
4040 * p-valprint.c: Update.
4041 * parse.c: Update.
4042 * ppc-linux-tdep.c: Update.
4043 * printcmd.c: Update.
4044 * python/py-arch.c: Update.
4045 * python/py-breakpoint.c: Update.
4046 * python/py-cmd.c: Update.
4047 * python/py-finishbreakpoint.c: Update.
4048 * python/py-frame.c: Update.
4049 * python/py-framefilter.c: Update.
4050 * python/py-gdb-readline.c: Update.
4051 * python/py-inferior.c: Update.
4052 * python/py-infthread.c: Update.
4053 * python/py-lazy-string.c: Update.
4054 * python/py-linetable.c: Update.
4055 * python/py-objfile.c: Update.
4056 * python/py-param.c: Update.
4057 * python/py-prettyprint.c: Update.
4058 * python/py-progspace.c: Update.
4059 * python/py-record-btrace.c: Update.
4060 * python/py-record.c: Update.
4061 * python/py-symbol.c: Update.
4062 * python/py-type.c: Update.
4063 * python/py-unwind.c: Update.
4064 * python/py-utils.c: Update.
4065 * python/py-value.c: Update.
4066 * python/python.c: Update.
4067 * record-btrace.c: Update.
4068 * record-full.c: Update.
4069 * remote-fileio.c: Update.
4070 * remote.c: Update.
4071 * riscv-tdep.c: Update.
4072 * rs6000-aix-tdep.c: Update.
4073 * rs6000-tdep.c: Update.
4074 * rust-exp.y: Update.
4075 * rust-lang.c: Update.
4076 * s390-tdep.c: Update.
4077 * selftest-arch.c: Update.
4078 * solib-dsbt.c: Update.
4079 * solib-frv.c: Update.
4080 * solib-spu.c: Update.
4081 * solib-svr4.c: Update.
4082 * solib.c: Update.
4083 * sparc64-linux-tdep.c: Update.
4084 * stack.c: Update.
4085 * symfile-mem.c: Update.
4086 * symmisc.c: Update.
4087 * target.c: Update.
4088 * thread.c: Update.
4089 * top.c: Update.
4090 * tracefile-tfile.c: Update.
4091 * tui/tui.c: Update.
4092 * typeprint.c: Update.
4093 * unittests/cli-utils-selftests.c: Update.
4094 * unittests/parse-connection-spec-selftests.c: Update.
4095 * valops.c: Update.
4096 * valprint.c: Update.
4097 * value.c: Update.
4098 * varobj.c: Update.
4099 * windows-nat.c: Update.
4100 * x86-linux-nat.c: Update.
4101 * xml-support.c: Update.
4102
a70b8144
TT
41032019-04-08 Tom Tromey <tom@tromey.com>
4104
4105 * xml-support.c: Use C++ exception handling.
4106 * x86-linux-nat.c: Use C++ exception handling.
4107 * windows-nat.c: Use C++ exception handling.
4108 * varobj.c: Use C++ exception handling.
4109 * value.c: Use C++ exception handling.
4110 * valprint.c: Use C++ exception handling.
4111 * valops.c: Use C++ exception handling.
4112 * unittests/parse-connection-spec-selftests.c: Use C++ exception
4113 handling.
4114 * unittests/cli-utils-selftests.c: Use C++ exception handling.
4115 * typeprint.c: Use C++ exception handling.
4116 * tui/tui.c: Use C++ exception handling.
4117 * tracefile-tfile.c: Use C++ exception handling.
4118 * top.c: Use C++ exception handling.
4119 * thread.c: Use C++ exception handling.
4120 * target.c: Use C++ exception handling.
4121 * symmisc.c: Use C++ exception handling.
4122 * symfile-mem.c: Use C++ exception handling.
4123 * stack.c: Use C++ exception handling.
4124 * sparc64-linux-tdep.c: Use C++ exception handling.
4125 * solib.c: Use C++ exception handling.
4126 * solib-svr4.c: Use C++ exception handling.
4127 * solib-spu.c: Use C++ exception handling.
4128 * solib-frv.c: Use C++ exception handling.
4129 * solib-dsbt.c: Use C++ exception handling.
4130 * selftest-arch.c: Use C++ exception handling.
4131 * s390-tdep.c: Use C++ exception handling.
4132 * rust-lang.c: Use C++ exception handling.
4133 * rust-exp.y: Use C++ exception handling.
4134 * rs6000-tdep.c: Use C++ exception handling.
4135 * rs6000-aix-tdep.c: Use C++ exception handling.
4136 * riscv-tdep.c: Use C++ exception handling.
4137 * remote.c: Use C++ exception handling.
4138 * remote-fileio.c: Use C++ exception handling.
4139 * record-full.c: Use C++ exception handling.
4140 * record-btrace.c: Use C++ exception handling.
4141 * python/python.c: Use C++ exception handling.
4142 * python/py-value.c: Use C++ exception handling.
4143 * python/py-utils.c: Use C++ exception handling.
4144 * python/py-unwind.c: Use C++ exception handling.
4145 * python/py-type.c: Use C++ exception handling.
4146 * python/py-symbol.c: Use C++ exception handling.
4147 * python/py-record.c: Use C++ exception handling.
4148 * python/py-record-btrace.c: Use C++ exception handling.
4149 * python/py-progspace.c: Use C++ exception handling.
4150 * python/py-prettyprint.c: Use C++ exception handling.
4151 * python/py-param.c: Use C++ exception handling.
4152 * python/py-objfile.c: Use C++ exception handling.
4153 * python/py-linetable.c: Use C++ exception handling.
4154 * python/py-lazy-string.c: Use C++ exception handling.
4155 * python/py-infthread.c: Use C++ exception handling.
4156 * python/py-inferior.c: Use C++ exception handling.
4157 * python/py-gdb-readline.c: Use C++ exception handling.
4158 * python/py-framefilter.c: Use C++ exception handling.
4159 * python/py-frame.c: Use C++ exception handling.
4160 * python/py-finishbreakpoint.c: Use C++ exception handling.
4161 * python/py-cmd.c: Use C++ exception handling.
4162 * python/py-breakpoint.c: Use C++ exception handling.
4163 * python/py-arch.c: Use C++ exception handling.
4164 * printcmd.c: Use C++ exception handling.
4165 * ppc-linux-tdep.c: Use C++ exception handling.
4166 * parse.c: Use C++ exception handling.
4167 * p-valprint.c: Use C++ exception handling.
4168 * objc-lang.c: Use C++ exception handling.
4169 * mi/mi-main.c: Use C++ exception handling.
4170 * mi/mi-interp.c: Use C++ exception handling.
4171 * mi/mi-cmd-stack.c: Use C++ exception handling.
4172 * mi/mi-cmd-break.c: Use C++ exception handling.
4173 * main.c: Use C++ exception handling.
4174 * linux-thread-db.c: Use C++ exception handling.
4175 * linux-tdep.c: Use C++ exception handling.
4176 * linux-nat.c: Use C++ exception handling.
4177 * linux-fork.c: Use C++ exception handling.
4178 * linespec.c: Use C++ exception handling.
4179 * language.c: Use C++ exception handling.
4180 * jit.c: Use C++ exception handling.
4181 * infrun.c: Use C++ exception handling.
4182 * infcmd.c: Use C++ exception handling.
4183 * infcall.c: Use C++ exception handling.
4184 * inf-loop.c: Use C++ exception handling.
4185 * i386-tdep.c: Use C++ exception handling.
4186 * i386-linux-tdep.c: Use C++ exception handling.
4187 * guile/scm-value.c: Use C++ exception handling.
4188 * guile/scm-type.c: Use C++ exception handling.
4189 * guile/scm-symtab.c: Use C++ exception handling.
4190 * guile/scm-symbol.c: Use C++ exception handling.
4191 * guile/scm-pretty-print.c: Use C++ exception handling.
4192 * guile/scm-ports.c: Use C++ exception handling.
4193 * guile/scm-param.c: Use C++ exception handling.
4194 * guile/scm-math.c: Use C++ exception handling.
4195 * guile/scm-lazy-string.c: Use C++ exception handling.
4196 * guile/scm-frame.c: Use C++ exception handling.
4197 * guile/scm-disasm.c: Use C++ exception handling.
4198 * guile/scm-cmd.c: Use C++ exception handling.
4199 * guile/scm-breakpoint.c: Use C++ exception handling.
4200 * guile/scm-block.c: Use C++ exception handling.
4201 * guile/guile-internal.h: Use C++ exception handling.
4202 * gnu-v3-abi.c: Use C++ exception handling.
4203 * gdbtypes.c: Use C++ exception handling.
4204 * frame.c: Use C++ exception handling.
4205 * frame-unwind.c: Use C++ exception handling.
4206 * fbsd-tdep.c: Use C++ exception handling.
4207 * f-valprint.c: Use C++ exception handling.
4208 * exec.c: Use C++ exception handling.
4209 * event-top.c: Use C++ exception handling.
4210 * event-loop.c: Use C++ exception handling.
4211 * eval.c: Use C++ exception handling.
4212 * dwarf2read.c: Use C++ exception handling.
4213 * dwarf2loc.c: Use C++ exception handling.
4214 * dwarf2-frame.c: Use C++ exception handling.
4215 * dwarf2-frame-tailcall.c: Use C++ exception handling.
4216 * dwarf-index-write.c: Use C++ exception handling.
4217 * dwarf-index-cache.c: Use C++ exception handling.
4218 * dtrace-probe.c: Use C++ exception handling.
4219 * disasm-selftests.c: Use C++ exception handling.
4220 * darwin-nat.c: Use C++ exception handling.
4221 * cp-valprint.c: Use C++ exception handling.
4222 * cp-support.c: Use C++ exception handling.
4223 * cp-abi.c: Use C++ exception handling.
4224 * corelow.c: Use C++ exception handling.
4225 * completer.c: Use C++ exception handling.
4226 * compile/compile-object-run.c: Use C++ exception handling.
4227 * compile/compile-object-load.c: Use C++ exception handling.
4228 * compile/compile-cplus-symbols.c: Use C++ exception handling.
4229 * compile/compile-c-symbols.c: Use C++ exception handling.
4230 * common/selftest.c: Use C++ exception handling.
4231 * common/new-op.c: Use C++ exception handling.
4232 * cli/cli-script.c: Use C++ exception handling.
4233 * cli/cli-interp.c: Use C++ exception handling.
4234 * cli/cli-cmds.c: Use C++ exception handling.
4235 * c-varobj.c: Use C++ exception handling.
4236 * btrace.c: Use C++ exception handling.
4237 * breakpoint.c: Use C++ exception handling.
4238 * break-catch-throw.c: Use C++ exception handling.
4239 * arch-utils.c: Use C++ exception handling.
4240 * amd64-tdep.c: Use C++ exception handling.
4241 * ada-valprint.c: Use C++ exception handling.
4242 * ada-typeprint.c: Use C++ exception handling.
4243 * ada-lang.c: Use C++ exception handling.
4244 * aarch64-tdep.c: Use C++ exception handling.
4245
3d6e9d23
TT
42462019-04-08 Tom Tromey <tom@tromey.com>
4247
4248 * xml-support.c (gdb_xml_parser::parse): Update.
4249 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4250 * value.c (show_convenience): Update.
4251 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4252 (test_parse_flags_qcs): Update.
4253 * thread.c (thr_try_catch_cmd): Update.
4254 * target.c (target_translate_tls_address): Update.
4255 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4256 (info_frame_command_core, frame_apply_command_count): Update.
4257 * rust-exp.y (rust_lex_exception_test): Update.
4258 * riscv-tdep.c (riscv_print_one_register_info): Update.
4259 * remote.c (remote_target::enable_btrace): Update.
4260 * record-btrace.c (record_btrace_enable_warn): Update.
4261 * python/py-utils.c (gdbpy_convert_exception): Update.
4262 * printcmd.c (do_one_display, print_variable_and_value): Update.
4263 * mi/mi-main.c (mi_print_exception): Update.
4264 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4265 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4266 * linux-nat.c (linux_nat_target::attach): Update.
4267 * linux-fork.c (class scoped_switch_fork_info): Update.
4268 * infrun.c (displaced_step_prepare): Update.
4269 * infcall.c (call_function_by_hand_dummy): Update.
4270 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4271 * gnu-v3-abi.c (print_one_vtable): Update.
4272 * frame.c (get_prev_frame_always): Update.
4273 * f-valprint.c (info_common_command_for_block): Update.
4274 * exec.c (try_open_exec_file): Update.
4275 * exceptions.c (print_exception, exception_print)
4276 (exception_fprintf, exception_print_same): Update.
4277 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4278 * dwarf-index-cache.c (index_cache::store)
4279 (index_cache::lookup_gdb_index): Update.
4280 * darwin-nat.c (maybe_cache_shell): Update.
4281 * cp-valprint.c (cp_print_value_fields): Update.
4282 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4283 (gcc_cplus_symbol_address): Update.
4284 * compile/compile-c-symbols.c (gcc_convert_symbol)
4285 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4286 * common/selftest.c: Update.
4287 * common/common-exceptions.h (struct gdb_exception) <message>: Now
4288 a std::string.
4289 (exception_try_scope_entry, exception_try_scope_exit): Don't
4290 declare.
4291 (struct exception_try_scope): Remove.
4292 (TRY): Don't use exception_try_scope.
4293 (struct gdb_exception): Add constructor, operator=.
4294 <what>: New method.
4295 (struct gdb_exception_RETURN_MASK_ALL)
4296 (struct gdb_exception_RETURN_MASK_ERROR)
4297 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4298 (struct gdb_quit_bad_alloc): Update.
4299 * common/common-exceptions.c (exception_none): Change
4300 initializer.
4301 (struct catcher) <state, exception>: Initialize inline.
4302 <prev>: Remove member.
4303 (current_catcher): Remove.
4304 (catchers): New global.
4305 (exceptions_state_mc_init): Simplify.
4306 (catcher_pop): Remove.
4307 (exceptions_state_mc, exceptions_state_mc_catch): Update.
4308 (try_scope_depth, exception_try_scope_entry)
4309 (exception_try_scope_exit): Remove.
4310 (throw_exception_sjlj): Update.
4311 (exception_messages, exception_messages_size): Remove.
4312 (throw_it): Simplify.
4313 (gdb_exception_sliced_copy): Remove.
4314 (throw_exception_cxx): Update.
4315 * cli/cli-script.c (script_from_file): Update.
4316 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4317 Update.
4318 * ada-valprint.c (ada_val_print): Update.
4319 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4320 (create_excep_cond_exprs): Update.
4321
c5c10118
TT
43222019-04-08 Tom Tromey <tom@tromey.com>
4323
4324 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4325 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4326 (TRY, CATCH, END_CATCH): Remove some definitions.
4327 * common/common-exceptions.c: Don't use GDB_XCPT.
4328 (catcher_list_size): Remove.
4329 (throw_exception, throw_it): Simplify.
4330
4de283e4
TT
43312019-04-05 Tom Tromey <tom@tromey.com>
4332
4333 Revert the header-sorting patch.
4334 * ft32-tdep.c: Revert.
4335 * frv-tdep.c: Revert.
4336 * frv-linux-tdep.c: Revert.
4337 * frame.c: Revert.
4338 * frame-unwind.c: Revert.
4339 * frame-base.c: Revert.
4340 * fork-child.c: Revert.
4341 * findvar.c: Revert.
4342 * findcmd.c: Revert.
4343 * filesystem.c: Revert.
4344 * filename-seen-cache.h: Revert.
4345 * filename-seen-cache.c: Revert.
4346 * fbsd-tdep.c: Revert.
4347 * fbsd-nat.h: Revert.
4348 * fbsd-nat.c: Revert.
4349 * f-valprint.c: Revert.
4350 * f-typeprint.c: Revert.
4351 * f-lang.c: Revert.
4352 * extension.h: Revert.
4353 * extension.c: Revert.
4354 * extension-priv.h: Revert.
4355 * expprint.c: Revert.
4356 * exec.h: Revert.
4357 * exec.c: Revert.
4358 * exceptions.c: Revert.
4359 * event-top.c: Revert.
4360 * event-loop.c: Revert.
4361 * eval.c: Revert.
4362 * elfread.c: Revert.
4363 * dwarf2read.h: Revert.
4364 * dwarf2read.c: Revert.
4365 * dwarf2loc.c: Revert.
4366 * dwarf2expr.h: Revert.
4367 * dwarf2expr.c: Revert.
4368 * dwarf2-frame.c: Revert.
4369 * dwarf2-frame-tailcall.c: Revert.
4370 * dwarf-index-write.h: Revert.
4371 * dwarf-index-write.c: Revert.
4372 * dwarf-index-common.c: Revert.
4373 * dwarf-index-cache.h: Revert.
4374 * dwarf-index-cache.c: Revert.
4375 * dummy-frame.c: Revert.
4376 * dtrace-probe.c: Revert.
4377 * disasm.h: Revert.
4378 * disasm.c: Revert.
4379 * disasm-selftests.c: Revert.
4380 * dictionary.c: Revert.
4381 * dicos-tdep.c: Revert.
4382 * demangle.c: Revert.
4383 * dcache.h: Revert.
4384 * dcache.c: Revert.
4385 * darwin-nat.h: Revert.
4386 * darwin-nat.c: Revert.
4387 * darwin-nat-info.c: Revert.
4388 * d-valprint.c: Revert.
4389 * d-namespace.c: Revert.
4390 * d-lang.c: Revert.
4391 * ctf.c: Revert.
4392 * csky-tdep.c: Revert.
4393 * csky-linux-tdep.c: Revert.
4394 * cris-tdep.c: Revert.
4395 * cris-linux-tdep.c: Revert.
4396 * cp-valprint.c: Revert.
4397 * cp-support.c: Revert.
4398 * cp-namespace.c: Revert.
4399 * cp-abi.c: Revert.
4400 * corelow.c: Revert.
4401 * corefile.c: Revert.
4402 * continuations.c: Revert.
4403 * completer.h: Revert.
4404 * completer.c: Revert.
4405 * complaints.c: Revert.
4406 * coffread.c: Revert.
4407 * coff-pe-read.c: Revert.
4408 * cli-out.h: Revert.
4409 * cli-out.c: Revert.
4410 * charset.c: Revert.
4411 * c-varobj.c: Revert.
4412 * c-valprint.c: Revert.
4413 * c-typeprint.c: Revert.
4414 * c-lang.c: Revert.
4415 * buildsym.c: Revert.
4416 * buildsym-legacy.c: Revert.
4417 * build-id.h: Revert.
4418 * build-id.c: Revert.
4419 * btrace.c: Revert.
4420 * bsd-uthread.c: Revert.
4421 * breakpoint.h: Revert.
4422 * breakpoint.c: Revert.
4423 * break-catch-throw.c: Revert.
4424 * break-catch-syscall.c: Revert.
4425 * break-catch-sig.c: Revert.
4426 * blockframe.c: Revert.
4427 * block.c: Revert.
4428 * bfin-tdep.c: Revert.
4429 * bfin-linux-tdep.c: Revert.
4430 * bfd-target.c: Revert.
4431 * bcache.c: Revert.
4432 * ax-general.c: Revert.
4433 * ax-gdb.h: Revert.
4434 * ax-gdb.c: Revert.
4435 * avr-tdep.c: Revert.
4436 * auxv.c: Revert.
4437 * auto-load.c: Revert.
4438 * arm-wince-tdep.c: Revert.
4439 * arm-tdep.c: Revert.
4440 * arm-symbian-tdep.c: Revert.
4441 * arm-pikeos-tdep.c: Revert.
4442 * arm-obsd-tdep.c: Revert.
4443 * arm-nbsd-tdep.c: Revert.
4444 * arm-nbsd-nat.c: Revert.
4445 * arm-linux-tdep.c: Revert.
4446 * arm-linux-nat.c: Revert.
4447 * arm-fbsd-tdep.c: Revert.
4448 * arm-fbsd-nat.c: Revert.
4449 * arm-bsd-tdep.c: Revert.
4450 * arch-utils.c: Revert.
4451 * arc-tdep.c: Revert.
4452 * arc-newlib-tdep.c: Revert.
4453 * annotate.h: Revert.
4454 * annotate.c: Revert.
4455 * amd64-windows-tdep.c: Revert.
4456 * amd64-windows-nat.c: Revert.
4457 * amd64-tdep.c: Revert.
4458 * amd64-sol2-tdep.c: Revert.
4459 * amd64-obsd-tdep.c: Revert.
4460 * amd64-obsd-nat.c: Revert.
4461 * amd64-nbsd-tdep.c: Revert.
4462 * amd64-nbsd-nat.c: Revert.
4463 * amd64-nat.c: Revert.
4464 * amd64-linux-tdep.c: Revert.
4465 * amd64-linux-nat.c: Revert.
4466 * amd64-fbsd-tdep.c: Revert.
4467 * amd64-fbsd-nat.c: Revert.
4468 * amd64-dicos-tdep.c: Revert.
4469 * amd64-darwin-tdep.c: Revert.
4470 * amd64-bsd-nat.c: Revert.
4471 * alpha-tdep.c: Revert.
4472 * alpha-obsd-tdep.c: Revert.
4473 * alpha-nbsd-tdep.c: Revert.
4474 * alpha-mdebug-tdep.c: Revert.
4475 * alpha-linux-tdep.c: Revert.
4476 * alpha-linux-nat.c: Revert.
4477 * alpha-bsd-tdep.c: Revert.
4478 * alpha-bsd-nat.c: Revert.
4479 * aix-thread.c: Revert.
4480 * agent.c: Revert.
4481 * addrmap.c: Revert.
4482 * ada-varobj.c: Revert.
4483 * ada-valprint.c: Revert.
4484 * ada-typeprint.c: Revert.
4485 * ada-tasks.c: Revert.
4486 * ada-lang.c: Revert.
4487 * aarch64-tdep.c: Revert.
4488 * aarch64-ravenscar-thread.c: Revert.
4489 * aarch64-newlib-tdep.c: Revert.
4490 * aarch64-linux-tdep.c: Revert.
4491 * aarch64-linux-nat.c: Revert.
4492 * aarch64-fbsd-tdep.c: Revert.
4493 * aarch64-fbsd-nat.c: Revert.
4494 * aarch32-linux-nat.c: Revert.
4495
d55e5aa6
TT
44962019-04-05 Tom Tromey <tom@tromey.com>
4497
4498 * ft32-tdep.c: Sort headers.
4499 * frv-tdep.c: Sort headers.
4500 * frv-linux-tdep.c: Sort headers.
4501 * frame.c: Sort headers.
4502 * frame-unwind.c: Sort headers.
4503 * frame-base.c: Sort headers.
4504 * fork-child.c: Sort headers.
4505 * findvar.c: Sort headers.
4506 * findcmd.c: Sort headers.
4507 * filesystem.c: Sort headers.
4508 * filename-seen-cache.h: Sort headers.
4509 * filename-seen-cache.c: Sort headers.
4510 * fbsd-tdep.c: Sort headers.
4511 * fbsd-nat.h: Sort headers.
4512 * fbsd-nat.c: Sort headers.
4513 * f-valprint.c: Sort headers.
4514 * f-typeprint.c: Sort headers.
4515 * f-lang.c: Sort headers.
4516 * extension.h: Sort headers.
4517 * extension.c: Sort headers.
4518 * extension-priv.h: Sort headers.
4519 * expprint.c: Sort headers.
4520 * exec.h: Sort headers.
4521 * exec.c: Sort headers.
4522 * exceptions.c: Sort headers.
4523 * event-top.c: Sort headers.
4524 * event-loop.c: Sort headers.
4525 * eval.c: Sort headers.
4526 * elfread.c: Sort headers.
4527 * dwarf2read.h: Sort headers.
4528 * dwarf2read.c: Sort headers.
4529 * dwarf2loc.c: Sort headers.
4530 * dwarf2expr.h: Sort headers.
4531 * dwarf2expr.c: Sort headers.
4532 * dwarf2-frame.c: Sort headers.
4533 * dwarf2-frame-tailcall.c: Sort headers.
4534 * dwarf-index-write.h: Sort headers.
4535 * dwarf-index-write.c: Sort headers.
4536 * dwarf-index-common.c: Sort headers.
4537 * dwarf-index-cache.h: Sort headers.
4538 * dwarf-index-cache.c: Sort headers.
4539 * dummy-frame.c: Sort headers.
4540 * dtrace-probe.c: Sort headers.
4541 * disasm.h: Sort headers.
4542 * disasm.c: Sort headers.
4543 * disasm-selftests.c: Sort headers.
4544 * dictionary.c: Sort headers.
4545 * dicos-tdep.c: Sort headers.
4546 * demangle.c: Sort headers.
4547 * dcache.h: Sort headers.
4548 * dcache.c: Sort headers.
4549 * darwin-nat.h: Sort headers.
4550 * darwin-nat.c: Sort headers.
4551 * darwin-nat-info.c: Sort headers.
4552 * d-valprint.c: Sort headers.
4553 * d-namespace.c: Sort headers.
4554 * d-lang.c: Sort headers.
4555 * ctf.c: Sort headers.
4556 * csky-tdep.c: Sort headers.
4557 * csky-linux-tdep.c: Sort headers.
4558 * cris-tdep.c: Sort headers.
4559 * cris-linux-tdep.c: Sort headers.
4560 * cp-valprint.c: Sort headers.
4561 * cp-support.c: Sort headers.
4562 * cp-namespace.c: Sort headers.
4563 * cp-abi.c: Sort headers.
4564 * corelow.c: Sort headers.
4565 * corefile.c: Sort headers.
4566 * continuations.c: Sort headers.
4567 * completer.h: Sort headers.
4568 * completer.c: Sort headers.
4569 * complaints.c: Sort headers.
4570 * coffread.c: Sort headers.
4571 * coff-pe-read.c: Sort headers.
4572 * cli-out.h: Sort headers.
4573 * cli-out.c: Sort headers.
4574 * charset.c: Sort headers.
4575 * c-varobj.c: Sort headers.
4576 * c-valprint.c: Sort headers.
4577 * c-typeprint.c: Sort headers.
4578 * c-lang.c: Sort headers.
4579 * buildsym.c: Sort headers.
4580 * buildsym-legacy.c: Sort headers.
4581 * build-id.h: Sort headers.
4582 * build-id.c: Sort headers.
4583 * btrace.c: Sort headers.
4584 * bsd-uthread.c: Sort headers.
4585 * breakpoint.h: Sort headers.
4586 * breakpoint.c: Sort headers.
4587 * break-catch-throw.c: Sort headers.
4588 * break-catch-syscall.c: Sort headers.
4589 * break-catch-sig.c: Sort headers.
4590 * blockframe.c: Sort headers.
4591 * block.c: Sort headers.
4592 * bfin-tdep.c: Sort headers.
4593 * bfin-linux-tdep.c: Sort headers.
4594 * bfd-target.c: Sort headers.
4595 * bcache.c: Sort headers.
4596 * ax-general.c: Sort headers.
4597 * ax-gdb.h: Sort headers.
4598 * ax-gdb.c: Sort headers.
4599 * avr-tdep.c: Sort headers.
4600 * auxv.c: Sort headers.
4601 * auto-load.c: Sort headers.
4602 * arm-wince-tdep.c: Sort headers.
4603 * arm-tdep.c: Sort headers.
4604 * arm-symbian-tdep.c: Sort headers.
4605 * arm-pikeos-tdep.c: Sort headers.
4606 * arm-obsd-tdep.c: Sort headers.
4607 * arm-nbsd-tdep.c: Sort headers.
4608 * arm-nbsd-nat.c: Sort headers.
4609 * arm-linux-tdep.c: Sort headers.
4610 * arm-linux-nat.c: Sort headers.
4611 * arm-fbsd-tdep.c: Sort headers.
4612 * arm-fbsd-nat.c: Sort headers.
4613 * arm-bsd-tdep.c: Sort headers.
4614 * arch-utils.c: Sort headers.
4615 * arc-tdep.c: Sort headers.
4616 * arc-newlib-tdep.c: Sort headers.
4617 * annotate.h: Sort headers.
4618 * annotate.c: Sort headers.
4619 * amd64-windows-tdep.c: Sort headers.
4620 * amd64-windows-nat.c: Sort headers.
4621 * amd64-tdep.c: Sort headers.
4622 * amd64-sol2-tdep.c: Sort headers.
4623 * amd64-obsd-tdep.c: Sort headers.
4624 * amd64-obsd-nat.c: Sort headers.
4625 * amd64-nbsd-tdep.c: Sort headers.
4626 * amd64-nbsd-nat.c: Sort headers.
4627 * amd64-nat.c: Sort headers.
4628 * amd64-linux-tdep.c: Sort headers.
4629 * amd64-linux-nat.c: Sort headers.
4630 * amd64-fbsd-tdep.c: Sort headers.
4631 * amd64-fbsd-nat.c: Sort headers.
4632 * amd64-dicos-tdep.c: Sort headers.
4633 * amd64-darwin-tdep.c: Sort headers.
4634 * amd64-bsd-nat.c: Sort headers.
4635 * alpha-tdep.c: Sort headers.
4636 * alpha-obsd-tdep.c: Sort headers.
4637 * alpha-nbsd-tdep.c: Sort headers.
4638 * alpha-mdebug-tdep.c: Sort headers.
4639 * alpha-linux-tdep.c: Sort headers.
4640 * alpha-linux-nat.c: Sort headers.
4641 * alpha-bsd-tdep.c: Sort headers.
4642 * alpha-bsd-nat.c: Sort headers.
4643 * aix-thread.c: Sort headers.
4644 * agent.c: Sort headers.
4645 * addrmap.c: Sort headers.
4646 * ada-varobj.c: Sort headers.
4647 * ada-valprint.c: Sort headers.
4648 * ada-typeprint.c: Sort headers.
4649 * ada-tasks.c: Sort headers.
4650 * ada-lang.c: Sort headers.
4651 * aarch64-tdep.c: Sort headers.
4652 * aarch64-ravenscar-thread.c: Sort headers.
4653 * aarch64-newlib-tdep.c: Sort headers.
4654 * aarch64-linux-tdep.c: Sort headers.
4655 * aarch64-linux-nat.c: Sort headers.
4656 * aarch64-fbsd-tdep.c: Sort headers.
4657 * aarch64-fbsd-nat.c: Sort headers.
4658 * aarch32-linux-nat.c: Sort headers.
4659
699bd4cf
TT
46602019-04-04 Tom Tromey <tom@tromey.com>
4661
4662 * varobj.c (varobj_create): Update.
4663 * rust-exp.y (struct rust_parser) <update_innermost_block,
4664 lookup_symbol>: New methods.
4665 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4666 Rename.
4667 (rust_parser::rust_lookup_type)
4668 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4669 * printcmd.c (display_command, do_one_display): Update.
4670 * parser-defs.h (struct parser_state) <parser_state>: Add
4671 "tracker" parameter.
4672 (block_tracker): New member.
4673 (class innermost_block_tracker) <innermost_block_tracker>: Add
4674 "types" parameter.
4675 <reset>: Remove method.
4676 (innermost_block): Don't declare.
4677 (null_post_parser): Update.
4678 * parse.c (innermost_block): Remove global.
4679 (write_dollar_variable): Update.
4680 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4681 Remove "tracker_types" parameter.
4682 (parse_expression): Add "tracker" parameter.
4683 (parse_expression_for_completion): Update.
4684 (null_post_parser): Add "tracker" parameter.
4685 * p-exp.y: Update rules.
4686 * m2-exp.y: Update rules.
4687 * language.h (struct language_defn) <la_post_parser>: Add
4688 "tracker" parameter.
4689 * go-exp.y: Update rules.
4690 * f-exp.y: Update rules.
4691 * expression.h (parse_expression, parse_exp_1): Add "tracker"
4692 parameter.
4693 * d-exp.y: Update rules.
4694 * c-exp.y: Update rules.
4695 * breakpoint.c (set_breakpoint_condition): Create an
4696 innermost_block_tracker.
4697 (watch_command_1): Likewise.
4698 * ada-lang.c (resolve): Add "tracker" parameter.
4699 (resolve_subexp): Likewise.
4700 * ada-exp.y (write_var_from_sym): Update.
4701
dac43e32
TT
47022019-04-04 Tom Tromey <tom@tromey.com>
4703
4704 * type-stack.h: New file.
4705 * type-stack.c: New file.
4706 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4707 type-stack.h.
4708 (insert_into_type_stack, insert_type, push_type, push_type_int)
4709 (insert_type_address_space, pop_type, pop_type_int)
4710 (pop_typelist, pop_type_stack, append_type_stack)
4711 (push_type_stack, get_type_stack, push_typelist)
4712 (follow_type_instance_flags, follow_types): Don't declare.
4713 * parse.c (type_stack): Remove global.
4714 (parse_exp_in_context): Update.
4715 (insert_into_type_stack, insert_type, push_type, push_type_int)
4716 (insert_type_address_space, pop_type, pop_type_int)
4717 (pop_typelist, pop_type_stack, append_type_stack)
4718 (push_type_stack, get_type_stack, push_typelist)
4719 (follow_type_instance_flags, follow_types): Remove (moved to
4720 type-stack.c).
4721 * f-exp.y (type_stack): New global.
4722 Update rules.
4723 (push_kind_type, f_parse): Update.
4724 * d-exp.y (type_stack): New global.
4725 Update rules.
4726 (d_parse): Update.
4727 * c-exp.y (struct c_parse_state) <type_stack>: New member.
4728 Update rules.
4729 * Makefile.in (COMMON_SFILES): Add type-stack.c.
4730 (HFILES_NO_SRCDIR): Add type-stack.h.
4731
2a612529
TT
47322019-04-04 Tom Tromey <tom@tromey.com>
4733
4734 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4735 (rust_parser::convert_ast_to_expression, rust_parse)
4736 (rust_lex_test_completion, rust_lex_tests): Update.
4737 * parser-defs.h (struct expr_completion_state): New.
4738 (struct parser_state) <parser_state>: Add completion parameter.
4739 <mark_struct_expression, mark_completion_tag>: New methods.
4740 <parse_completion, m_completion_state>: New members.
4741 (prefixify_expression, null_post_parser): Update.
4742 (mark_struct_expression, mark_completion_tag): Don't declare.
4743 * parse.c (parse_completion, expout_last_struct)
4744 (expout_tag_completion_type, expout_completion_name): Remove
4745 globals.
4746 (parser_state::mark_struct_expression)
4747 (parser_state::mark_completion_tag): Now methods.
4748 (prefixify_expression): Add last_struct parameter.
4749 (prefixify_subexp): Likewise.
4750 (parse_exp_1): Update.
4751 (parse_exp_in_context): Add cstate parameter. Update.
4752 (parse_expression_for_completion): Create an
4753 expr_completion_state.
4754 (null_post_parser): Add "completion" parameter.
4755 * p-exp.y: Update rules.
4756 (yylex): Update.
4757 * language.h (struct language_defn) <la_post_parser>: Add
4758 "completing" parameter.
4759 * go-exp.y: Update rules.
4760 (lex_one_token): Update.
4761 * expression.h (parse_completion): Don't declare.
4762 * d-exp.y: Update rules.
4763 (lex_one_token): Update rules.
4764 * c-exp.y: Update rules.
4765 (lex_one_token): Update.
4766 * ada-lang.c (resolve): Add "parse_completion" parameter.
4767 (resolve_subexp): Likewise.
4768 (ada_resolve_function): Likewise.
4769
43476f0b
TT
47702019-04-04 Tom Tromey <tom@tromey.com>
4771
4772 * parser-defs.h (struct parser_state) <start_arglist,
4773 end_arglist>: New methods.
4774 <arglist_len, m_funcall_chain>: New members.
4775 (arglist_len, start_arglist, end_arglist): Don't declare.
4776 * parse.c (arglist_len, funcall_chain): Remove global.
4777 (start_arglist, end_arglist): Remove functions.
4778 (parse_exp_in_context): Update.
4779 * p-exp.y: Update rules.
4780 * m2-exp.y: Update rules.
4781 * go-exp.y: Update rules.
4782 * f-exp.y: Update rules.
4783 * d-exp.y: Update rules.
4784 * c-exp.y: Update rules.
4785
5776fca3
TT
47862019-04-04 Tom Tromey <tom@tromey.com>
4787
4788 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4789 lex_operator, push_back>: New methods.
4790 Update all rules.
4791 (rust_parser::lex_hex, lex_escape): Rename and update.
4792 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4793 (rust_parser::lex_operator): Rename and update.
4794 (rust_parser::lex_number, rustyylex, rustyyerror)
4795 (rust_lex_test_init, rust_lex_test_sequence)
4796 (rust_lex_test_push_back, rust_lex_tests): Update.
4797 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4798 parameter.
4799 <lexptr, prev_lexptr>: New members.
4800 (lexptr, prev_lexptr): Don't declare.
4801 * parse.c (lexptr, prev_lexptr): Remove globals.
4802 (parse_exp_in_context): Update.
4803 * p-exp.y (yylex, yyerror): Update.
4804 * m2-exp.y (parse_number, yylex, yyerror): Update.
4805 * go-exp.y (lex_one_token, yyerror): Update.
4806 * f-exp.y (match_string_literal, yylex, yyerror): Update.
4807 * d-exp.y (lex_one_token, yyerror): Update.
4808 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4809 (lex_one_token, yyerror): Update.
4810 * ada-lex.l (YY_INPUT): Update.
4811 (rewind_to_char): Update.
4812 * ada-exp.y (yyerror): Update.
4813
8621b685
TT
48142019-04-04 Tom Tromey <tom@tromey.com>
4815
4816 * rust-exp.y (rustyylex, rust_lex_tests): Update.
4817 * parser-defs.h (struct parser_state) <parser_state>: Add new
4818 parameter.
4819 <comma_terminates>: New member.
4820 (comma_terminates): Don't declare global.
4821 * parse.c (comma_terminates): Remove global.
4822 (parse_exp_in_context): Update.
4823 * p-exp.y (yylex): Update.
4824 * m2-exp.y (yylex): Update.
4825 * go-exp.y (lex_one_token): Update.
4826 * f-exp.y (yylex): Update.
4827 * d-exp.y (lex_one_token): Update.
4828 * c-exp.y (lex_one_token): Update.
4829 * ada-lex.l: Update.
4830
28aaf3fd
TT
48312019-04-04 Tom Tromey <tom@tromey.com>
4832
4833 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4834 (rustyylex, rust_lex_test_init, rust_lex_test_one)
4835 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4836 * parser-defs.h (paren_depth): Don't declare.
4837 * parse.c (paren_depth): Remove global.
4838 (parse_exp_in_context): Update.
4839 * p-exp.y (paren_depth): New global.
4840 (pascal_parse): Initialize it.
4841 * m2-exp.y (paren_depth): New global.
4842 (m2_parse): Initialize it.
4843 * go-exp.y (paren_depth): New global.
4844 (go_parse): Initialize it.
4845 * f-exp.y (paren_depth): New global.
4846 (f_parse): Initialize it.
4847 * d-exp.y (paren_depth): New global.
4848 (d_parse): Initialize it.
4849 * c-exp.y (paren_depth): New global.
4850 (c_parse): Initialize it.
4851 * ada-lex.l (paren_depth): New global.
4852 (lexer_init): Initialize it.
4853
1e58a4a4
TT
48542019-04-04 Tom Tromey <tom@tromey.com>
4855
4856 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4857 (rust_parser::convert_ast_to_type)
4858 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4859 * parser-defs.h (struct parser_state) <parser_state>: Add
4860 parameters. Initialize new members.
4861 <expression_context_block, expression_context_pc>: New members.
4862 * parse.c (expression_context_block, expression_context_pc):
4863 Remove globals.
4864 (parse_exp_in_context): Update.
4865 * p-exp.y: Update all rules.
4866 (yylex): Update.
4867 * m2-exp.y: Update all rules.
4868 (yylex): Update.
4869 * go-exp.y (yylex): Update.
4870 * f-exp.y (yylex): Update.
4871 * d-exp.y: Update all rules.
4872 (yylex): Update.
4873 * c-exp.y: Update all rules.
4874 (lex_one_token, classify_name, yylex, c_parse): Update.
4875 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4876
37eedb39
TT
48772019-04-04 Tom Tromey <tom@tromey.com>
4878
4879 * gdbarch.h, gdbarch.c: Rebuild.
4880 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4881 * stap-probe.h:
4882 (struct stap_parse_info): Replace "parser_state" with
4883 "expr_builder".
4884 * parser-defs.h (struct expr_builder): Rename from "parser_state".
4885 (parser_state): New class.
4886 * parse.c (expr_builder): Rename.
4887 (expr_builder::release): Rename.
4888 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4889 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4890 (write_exp_elt_longcst, write_exp_elt_floatcst)
4891 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4892 (write_exp_string_vector, write_exp_bitstring)
4893 (write_exp_msymbol, mark_struct_expression)
4894 (write_dollar_variable)
4895 (insert_type_address_space, increase_expout_size): Replace
4896 "parser_state" with "expr_builder".
4897 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4898 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4899 "parser_state" with "expr_builder".
4900
73923d7e
TT
49012019-04-04 Tom Tromey <tom@tromey.com>
4902
4903 * rust-exp.y: Replace "parse_language" with method call.
4904 * p-exp.y:
4905 (yylex): Replace "parse_language" with method call.
4906 * m2-exp.y:
4907 (yylex): Replace "parse_language" with method call.
4908 * go-exp.y (classify_name): Replace "parse_language" with method
4909 call.
4910 * f-exp.y (yylex): Replace "parse_language" with method call.
4911 * d-exp.y (lex_one_token): Replace "parse_language" with method
4912 call.
4913 * c-exp.y:
4914 (lex_one_token, classify_name, yylex): Replace "parse_language"
4915 with method call.
4916 * ada-exp.y (find_primitive_type, type_char)
4917 (type_system_address): Replace "parse_language" with method call.
4918
fa9f5be6
TT
49192019-04-04 Tom Tromey <tom@tromey.com>
4920
4921 * rust-exp.y: Replace "parse_gdbarch" with method call.
4922 * parse.c (write_dollar_variable, insert_type_address_space):
4923 Replace "parse_gdbarch" with method call.
4924 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4925 call.
4926 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4927 call.
4928 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4929 "parse_gdbarch" with method call.
4930 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4931 with method call.
4932 * f-exp.y (parse_type, parse_f_type, yylex): Replace
4933 "parse_gdbarch" with method call.
4934 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4935 "parse_gdbarch" with method call.
4936 * c-exp.y (parse_type, parse_number, classify_name): Replace
4937 "parse_gdbarch" with method call.
4938 * ada-lex.l: Replace "parse_gdbarch" with method call.
4939 * ada-exp.y (parse_type, find_primitive_type, type_char)
4940 (type_system_address): Replace "parse_gdbarch" with method call.
4941
1201a264
TT
49422019-04-04 Tom Tromey <tom@tromey.com>
4943
4944 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4945 * stap-probe.c (stap_parse_argument): Update.
4946 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4947 initial_size parameter.
4948 * rust-exp.y (rust_lex_tests): Update.
4949 * parse.c (parser_state): Update.
4950 (parse_exp_in_context): Update.
4951 * parser-defs.h (struct parser_state) <parser_state>: Remove
4952 "initial_size" parameter.
4953
e3980ce2
TT
49542019-04-04 Tom Tromey <tom@tromey.com>
4955
4956 * parser-defs.h (increase_expout_size): Don't declare.
4957 * parse.c (increase_expout_size): Now static.
4958
e9f8e3f1
TS
49592019-04-04 Thomas Schwinge <thomas@codesourcery.com>
4960
4961 * gnu-nat.c (gnu_nat_target::wait): Fix
4962 target_waitstatus_to_string call.
4963
d7df6549
AB
49642019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
4965
4966 * eval.c (evaluate_subexp_standard): Handle internal functions
4967 during Fortran function call handling.
4968
8bdc1658
AB
49692019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
4970
4971 * NEWS: Mention new internal functions.
4972 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4973 (read_base_type): Use dwarf2_init_complex_target_type.
4974 * value.c (creal_internal_fn): New function.
4975 (cimag_internal_fn): New function.
4976 (_initialize_values): Register new internal functions.
4977
c29705b7
PW
49782019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4979
4980 * infrun.c (stop_all_threads): If debug_infrun, always
4981 trace the wait status after wait_one, using
4982 target_waitstatus_to_string and target_pid_to_str.
4983 (handle_inferior_event): Replace various trace of
4984 wait status kind by a single trace.
4985 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4986 wait status kind image by target_waitstatus_to_string.
4987 * target/waitstatus.c (target_waitstatus_to_string): Fix
4988 obsolete comment.
4989
05caa1d2
TT
49902019-04-01 Tom Tromey <tromey@adacore.com>
4991
4992 PR symtab/23331:
4993 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4994
9d1447e0
SDJ
49952019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
4996 Pedro Alves <palves@redhat.com>
4997
4998 * top.c (quit_force): Call 'finalize_values'.
4999 * value.c (finalize_values): New function.
5000 * value.h (finalize_values): Declare.
5001
7734102d
EZ
50022019-03-30 Eli Zaretskii <eliz@gnu.org>
5003
5004 * NEWS: Announce $_gdb_major and $_gdb_minor.
5005
5006 * top.c (init_gdb_version_vars): New function.
5007 (gdb_init): Call init_gdb_version_vars.
5008
188e1fa9
TT
50092019-03-29 Tom Tromey <tromey@adacore.com>
5010
5011 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
5012 help text. Remove dead code.
5013
2880242d
KS
50142019-03-29 Keith Seitz <keiths@redhat.com>
5015
5016 From Siddhesh Poyarekar:
5017 * f-lang.h (f77_get_upperbound): Return LONGEST.
5018 (f77_get_lowerbound): Likewise.
5019 * f-typeprint.c (f_type_print_varspec_suffix): Expand
5020 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
5021 print them.
5022 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
5023 plongest to format print it.
5024 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5025 (f77_get_upperbound): Likewise.
5026 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5027 LOWER_BOUND to LONGEST.
5028 (f77_create_arrayprint_offset_tbl): Likewise.
5029
cc1defb1
KS
50302019-03-29 Keith Seitz <keiths@redhat.com>
5031
5032 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5033 %s/pulongest for TYPE_LENGTH instead of %d in format
5034 strings.
5035 * ada-typerint.c (ada_print_type): Likewise.
5036 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5037 * compile/compile-c-support.c (generate_register_struct): Likewise.
5038 * gdbtypes.c (recursive_dump_type): Likewise.
5039 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5040 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
5041 instead of %d in format strings.
5042 * riscv-tdep.c (riscv_type_alignment): Cast second argument
5043 to std::min to ULONGEST.
5044 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5045 instead of %d in format strings.
5046 * tracepoint.c (info_scope_command): Likewise.
5047 * typeprint.c (print_offset_data::update)
5048 (print_offset_data::finish): Likewise.
5049 * xtensa-tdep.c (xtensa_store_return_value)
5050 (xtensa_push_dummy_call): Likewise.
5051
e432ccf1
JT
50522019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
5053
5054 * windows-nat.c (display_selector): Fixed format specifications
5055 for 64-bit Cygwin.
5056
65d2b333
PW
50572019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5058
5059 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5060
f489207e
SL
50612019-03-28 Sandra Loosemore <sandra@codesourcery.com>
5062
5063 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5064 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5065 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5066 (nios2_linux_init_abi): Install it.
5067
bffa1015
AH
50682019-03-28 Alan Hayward <alan.hayward@arm.com>
5069
5070 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5071
fc96163a
AH
50722019-03-28 Alan Hayward <alan.hayward@arm.com>
5073
5074 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5075
20dc7e9b
PW
50762019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5077 Tom Tromey <tromey@adacore.com>
5078
5079 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5080
7f5331a8
JB
50812019-03-26 Joel Brobecker <brobecker@adacore.com>
5082
5083 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5084 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5085 method to compute the bounds of range types. Also print "[evaluated]"
5086 if the bounds' values come from a dynamic evaluation.
5087
18c77628
AB
50882019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
5089
5090 * cp-valprint.c (cp_print_value_fields): Don't print trailing
5091 whitespace when pretty printing is on.
5092
53c973f2
AH
50932019-03-26 Alan Hayward <alan.hayward@arm.com>
5094
e79be6e5 5095 * ppc-linux-nat.c: Add include.
53c973f2 5096
d851aa71
AH
50972019-03-26 Alan Hayward <alan.hayward@arm.com>
5098
e79be6e5 5099 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 5100
2fe7bab7
AH
51012019-03-26 Alan Hayward <alan.hayward@arm.com>
5102
e79be6e5 5103 * arm-linux-nat.c: Add include.
2fe7bab7 5104
068ef30e
SM
51052019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
5106
5107 * source-cache.c (source_cache::get_source_lines): Re-read
5108 fullname after calling open_source_file.
5109
81a24d04
JB
51102019-03-25 John Baldwin <jhb@FreeBSD.org>
5111
5112 * NEWS: Mention TLS support for FreeBSD.
5113
79e7ae11
TT
51142019-03-25 Tom Tromey <tromey@adacore.com>
5115
5116 * minsyms.c (BUNCH_SIZE): Update comment.
5117 (~minimal_symbol_reader): Remove old comment.
5118 (compact_minimal_symbols): Update comment.
5119 (minimal_symbol_reader::install): Remove old comment. Update
5120 other comments.
5121
d45963c2
AH
51222019-03-25 Alan Hayward <alan.hayward@arm.com>
5123
5124 * s390-linux-nat.c: Add include.
5125
0f83012e
AH
51262019-03-25 Alan Hayward <alan.hayward@arm.com>
5127
5128 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5129 Call linux_get_hwcap.
5130 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5131 Likewise.
5132 (aarch64_linux_get_hwcap): Remove function.
5133 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5134 declaration.
5135 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5136 linux_get_hwcap.
5137 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5138 * linux-tdep.c (linux_get_hwcap): Add function.
5139 (linux_get_hwcap2): Likewise.
5140 * linux-tdep.h (linux_get_hwcap): Add declaration.
5141 (linux_get_hwcap2): Likewise.
5142 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5143 (ppc_linux_get_hwcap2): Likewise.
5144 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5145 linux_get_hwcap.
5146 (ppc_linux_nat_target::insert_watchpoint): Likewise.
5147 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5148 (ppc_linux_nat_target::read_description): Likewise.
5149 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5150 * s390-linux-nat.c: Likewise.
5151 * s390-linux-tdep.c (s390_core_read_description): Likewise.
5152
6640a367
TT
51532019-03-24 Tom Tromey <tom@tromey.com>
5154
5155 * ada-lang.c (standard_lookup): Simplify initialization.
5156 (ada_lookup_symbol_nonlocal): Simplify return.
5157 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5158 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5159 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5160 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5161 initialization.
5162 * solib.c (solib_global_lookup): Simplify.
5163 * symtab.c (null_block_symbol): Remove.
5164 (symbol_cache_lookup): Simplify returns.
5165 (lookup_language_this): Simplify returns.
5166 (lookup_symbol_aux): Simplify return.
5167 (lookup_local_symbol): Simplify returns.
5168 (lookup_global_symbol_from_objfile): Simplify return.
5169 (lookup_symbol_in_objfile_symtabs)
5170 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5171 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5172 (lookup_static_symbol, lookup_global_symbol): Simplify return.
5173 * cp-namespace.c (cp_lookup_bare_symbol)
5174 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5175 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5176 (cp_lookup_nested_symbol): Don't use null_block_symbol.
5177 (cp_lookup_symbol_via_imports): Simplify initialization.
5178 (find_symbol_in_baseclass): Likewise.
5179 * symtab.h (null_block_symbol): Remove.
5180 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5181 (d_lookup_nested_symbol, d_lookup_symbol_imports)
5182 (d_lookup_symbol_module): Likewise.
5183 (find_symbol_in_baseclass): Simplify initialization.
5184
a930ebcd
TT
51852019-03-24 Tom Tromey <tom@tromey.com>
5186
5187 * expression.h: Don't include symtab.h.
5188 (struct block): Forward declare.
5189
582942f4
TT
51902019-03-24 Tom Tromey <tom@tromey.com>
5191
5192 * c-exp.y (typebase): Remove casts.
5193 * gdbtypes.c (lookup_unsigned_typename, )
5194 (lookup_signed_typename): Remove cast.
5195 * eval.c (parse_to_comma_and_eval): Remove cast.
5196 * parse.c (write_dollar_variable): Remove cast.
5197 * block.h (struct block) <superblock>: Now const.
5198 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5199 * psymtab.c (psym_map_matching_symbols): Make "block" const.
5200 (map_block): Make "block" const.
5201 * symfile.h (struct quick_symbol_functions)
5202 <map_matching_symbols>: Constify block argument to "callback".
5203 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5204 const.
5205 (find_pc_sect_compunit_symtab): Make "b" const.
5206 (find_symbol_at_address): Likewise.
5207 (search_symbols): Likewise.
5208 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5209 (dw2_debug_names_lookup_symbol): Likewise.
5210 (dw2_map_matching_symbols): Update.
5211 * p-valprint.c (pascal_val_print): Remove "block".
5212 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5213 (aux_add_nonlocal_symbols): Make "block" const.
5214 (resolve_subexp): Remove cast.
5215 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5216 const.
5217 (iterate_over_file_blocks): Likewise.
5218 * f-exp.y (%union) <bval>: Remove.
5219 * coffread.c (patch_opaque_types): Make "b" const.
5220 * spu-tdep.c (spu_catch_start): Make "block" const.
5221 * c-valprint.c (print_unpacked_pointer): Remove "block".
5222 * symmisc.c (dump_symtab_1): Make "b" const.
5223 (block_depth): Make "block" const.
5224 * d-exp.y (%union) <bval>: Remove.
5225 * cp-support.h (cp_lookup_rtti_type): Update.
5226 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5227 * psymtab.c (psym_lookup_symbol): Make "block" const.
5228 (maintenance_check_psymtabs): Make "b" const.
5229 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5230 (enumerate_locals, enumerate_args): Update.
5231 * python/py-symtab.c (stpy_global_block): Make "block" const.
5232 (stpy_static_block): Likewise.
5233 * inline-frame.c (block_starting_point_at): Make "new_block"
5234 const.
5235 * block.c (find_block_in_blockvector): Make return type const.
5236 (blockvector_for_pc_sect): Make "b" const.
5237 (find_block_in_blockvector): Make "b" const.
5238
7ad417dd
TT
52392019-03-23 Tom Tromey <tom@tromey.com>
5240
5241 * varobj.c (varobj_create): Update.
5242 * symfile.c (clear_symtab_users): Don't reset innermost_block.
5243 * printcmd.c (display_command, do_one_display): Don't reset
5244 innermost_block.
5245 * parser-defs.h (enum innermost_block_tracker_type): Move to
5246 expression.h.
5247 (innermost_block): Update comment.
5248 * parse.c (parse_exp_1): Add tracker_types parameter.
5249 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
5250 tracker_types parameter. Reset innermost_block.
5251 (parse_exp_in_context): Remove.
5252 (parse_expression_for_completion): Update.
5253 * objfiles.c (~objfile): Don't reset expression_context_block or
5254 innermost_block.
5255 * expression.h (enum innermost_block_tracker_type): Move from
5256 parser-defs.h.
5257 (parse_exp_1): Add tracker_types parameter.
5258 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5259 reset innermost_block.
5260
b366c208
TT
52612019-03-23 Tom Tromey <tom@tromey.com>
5262
5263 * objfiles.h: Include bcache.h.
5264
9bb9b2f9
TT
52652019-03-23 Tom Tromey <tom@tromey.com>
5266
5267 * linespec.c (get_current_search_block): Use
5268 scoped_restore_current_language.
5269 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5270
59c28372
AH
52712019-03-22 Alan Hayward <alan.hayward@arm.com>
5272 Jiong Wang <jiong.wang@arm.com>
5273
5274 * aarch64-linux-tdep.c
5275 (aarch64_linux_iterate_over_regset_sections): Check for pauth
5276 section.
5277 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5278
17e116a7
AH
52792019-03-22 Alan Hayward <alan.hayward@arm.com>
5280 Jiong Wang <jiong.wang@arm.com>
5281
5282 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5283 instructions.
5284 (aarch64_analyze_prologue_test): Add PACIASP test.
5285 (aarch64_prologue_prev_register): Unmask PC value.
5286
11e1b75f
AH
52872019-03-22 Alan Hayward <alan.hayward@arm.com>
5288 Jiong Wang <jiong.wang@arm.com>
5289
5290 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5291 (aarch64_dwarf2_prev_register): Unmask PC value.
5292 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5293 (aarch64_execute_dwarf_cfa_vendor_op): Check for
5294 DW_CFA_AARCH64_negate_ra_state.
5295 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5296
34dcc7cf
AH
52972019-03-22 Alan Hayward <alan.hayward@arm.com>
5298 Jiong Wang <jiong.wang@arm.com>
5299
5300 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5301 registers.
5302 (aarch64_pseudo_register_name): Likewise.
5303 (aarch64_pseudo_register_type): Likewise.
5304 (aarch64_pseudo_register_reggroup_p): Likewise.
5305 (aarch64_gdbarch_init): Add pauth registers.
5306 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5307 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5308 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5309 (struct gdbarch_tdep): Add regnum for ra_state.
5310
1ef53e6b
AH
53112019-03-22 Alan Hayward <alan.hayward@arm.com>
5312 Jiong Wang <jiong.wang@arm.com>
5313
5314 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5315
76bed0fd
AH
53162019-03-22 Alan Hayward <alan.hayward@arm.com>
5317 Jiong Wang <jiong.wang@arm.com>
5318
5319 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5320 function.
5321 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5322 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5323 (aarch64_gdbarch_init): Add puth registers.
5324 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5325 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5326 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5327
ee4fbcfa
AH
53282019-03-22 Alan Hayward <alan.hayward@arm.com>
5329 Jiong Wang <jiong.wang@arm.com>
5330
5331 * aarch64-linux-nat.c
5332 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5333 * aarch64-linux-tdep.c
5334 (aarch64_linux_core_read_description): Likewise.
5335 (aarch64_linux_get_hwcap): New function.
5336 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5337 (aarch64_linux_get_hwcap): New declaration.
5338
6dc0ebde
AH
53392019-03-22 Alan Hayward <alan.hayward@arm.com>
5340 Jiong Wang <jiong.wang@arm.com>
5341
5342 * aarch64-linux-nat.c
5343 (aarch64_linux_nat_target::read_description): Add pauth param.
5344 * aarch64-linux-tdep.c
5345 (aarch64_linux_core_read_description): Likewise.
5346 * aarch64-tdep.c (struct target_desc): Add in pauth.
5347 (aarch64_read_description): Add pauth param.
5348 (aarch64_gdbarch_init): Likewise.
5349 * aarch64-tdep.h (aarch64_read_description): Likewise.
5350 * arch/aarch64.c (aarch64_create_target_description): Likewise.
5351 * arch/aarch64.h (aarch64_create_target_description): Likewise.
5352 * features/Makefile: Add new files.
5353 * features/aarch64-pauth.c: New file.
5354 * features/aarch64-pauth.xml: New file.
5355
595915c1
TT
53562019-03-20 Tom Tromey <tromey@adacore.com>
5357
5358 * infrun.c (handle_inferior_event): Rename from
5359 handle_inferior_event_1. Create a scoped_value_mark.
5360 (handle_inferior_event): Remove.
5361
4c7d57e7
TT
53622019-03-19 Tom Tromey <tromey@adacore.com>
5363
5364 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5365 * infrun.h (print_stop_event): Add "displays" parameter.
5366 * infrun.c (print_stop_event): Add "displays" parameter.
5367
cb246234
PA
53682019-03-19 Pedro Alves <palves@redhat.com>
5369
5370 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5371 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
5372 to -1. Fix TABs vs spaces.
5373 (tui_ui_out::tui_ui_out): Don't initialize fields here.
5374 * tui/tui-out.h (tui_ui_out) Add intro comments.
5375 <m_line, m_start_of_line>: In-class initialize, and add describing
5376 comment.
5377
3a0e45b2
AH
53782019-03-18 Alan Hayward <alan.hayward@arm.com>
5379
5380 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5381 variable names.
5382 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5383
5371b850
PA
53842019-03-18 Pedro Alves <palves@redhat.com>
5385 Eli Zaretskii <eliz@gnu.org>
5386
5387 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5388 m_line and m_start_of_line.
5389
b17c4cd0
EZ
53902019-03-18 Eli Zaretskii <eliz@gnu.org>
5391
5392 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5393 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5394 it returns a newline. This fixes a regression in TU mode, whereby
5395 the next line is output on the same screen line as the user input.
5396
4bd56d18
TT
53972019-03-18 Tom Tromey <tromey@adacore.com>
5398
5399 * minsyms.c (minimal_symbol_reader::install): Remove call to
5400 obstack_blank.
5401
55c10aca
PA
54022019-03-18 Pedro Alves <palves@redhat.com>
5403
5404 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5405 New globals.
5406 (apply_style): New, factored out from ...
5407 (apply_ansi_escape): ... this. Handle reverse video mode.
5408 (tui_set_reverse_mode): New function.
5409 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5410 * tui/tui-winsource.c (tui_show_source_line): Use
5411 tui_set_reverse_mode instead of setting A_STANDOUT.
5412 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5413 New setter methods.
5414
647bb750
HD
54152019-03-18 Hannes Domani <ssbssa@yahoo.de>
5416
5417 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5418 Handle tabs.
5419
bff8c71f
TT
54202019-03-18 Tom Tromey <tromey@adacore.com>
5421
5422 * ada-lang.c (empty_array): Add "high" parameter.
5423 (ada_evaluate_subexp): Update.
5424
58785d98
ST
54252019-03-17 Sergei Trofimovich <siarheit@google.com>
5426
5427 * unittests/string_view-selftests.c: Define
5428 _initialize_string_view_selftests unconditionally.
5429
d4cbef22
ВМ
54302019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
5431
5432 PR gdb/24350
5433 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5434
fce4c071
ВМ
54352019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
5436
5437 PR gdb/24351
5438 * windows-nat.c (display_selector): Fix format specifiers.
5439
f7f0a123
EZ
54402019-03-17 Eli Zaretskii <eliz@gnu.org>
5441
5442 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5443 tui_refill_source_window instead of tui_refresh_win, to update the
5444 current execution line. This fixes redisplay of the current line
5445 when stepping through the code with "next" or "step".
5446
ab42892f
EZ
54472019-03-16 Eli Zaretskii <eliz@gnu.org>
5448
5449 * source-cache.c (source_cache::get_source_lines): Call
5450 find_source_lines to initialize s->nlines. This fixes vertical
5451 scrolling of TUI source window when the DOWN arrow is pressed.
5452
8d8c087f
PW
54532019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5454
5455 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5456 linux-thread-db.c (_initialize_thread_db): Likewise.
5457
798e1c30
EZ
54582019-03-16 Eli Zaretskii <eliz@gnu.org>
5459
5460 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5461 wclrtoeol in tui_show_source_line". This reverts changes made in
5462 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5463
eefba3da
TT
54642019-03-15 Tom Tromey <tom@tromey.com>
5465
5466 * symtab.h (struct minimal_symbol): Derive from
5467 general_symbol_info.
5468 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5469 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5470 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5471 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5472 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5473 (MSYMBOL_SEARCH_NAME): Update.
5474 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5475 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5476 * minsyms.c (minimal_symbol_reader::record_full): Update.
5477
0de2420c
TT
54782019-03-15 Tom Tromey <tom@tromey.com>
5479
5480 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5481
042d75e4
TT
54822019-03-15 Tom Tromey <tom@tromey.com>
5483
5484 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5485 unique_xmalloc_ptr.
5486 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5487 Update.
5488 * minsyms.c (lookup_minimal_symbol_by_pc_section)
5489 (build_minimal_symbol_hash_tables)
5490 (minimal_symbol_reader::install): Update.
5491
db92718b
TT
54922019-03-15 Tom Tromey <tom@tromey.com>
5493
5494 * symtab.c (create_demangled_names_hash): Update.
5495 (symbol_set_names): Update.
5496 * objfiles.h (struct objfile_per_bfd_storage)
5497 <demangled_names_hash>: Now an htab_up.
5498 * objfiles.c (objfile_per_bfd_storage): Simplify.
5499
d6797f46
TT
55002019-03-15 Tom Tromey <tom@tromey.com>
5501
5502 * objfiles.h (struct objfile_per_bfd_storage): Declare
5503 destructor.
5504 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5505 New.
5506 (get_objfile_bfd_data): Use new. Don't initialize
5507 language_of_main.
5508 (free_objfile_per_bfd_storage): Remove.
5509 (objfile_bfd_data_free, objfile::~objfile): Use delete.
5510
741d7538
TT
55112019-03-15 Tom Tromey <tom@tromey.com>
5512
5513 * symfile.c (reread_symbols): Update.
5514 * objfiles.c (objfile::objfile): Update.
5515 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5516 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5517 comment.
5518 (minimal_symbol_reader::install): Update.
5519 (terminate_minimal_symbol_table): Remove.
5520 * jit.c (jit_object_close_impl): Update.
5521
788c80d1
TT
55222019-03-15 Tom Tromey <tom@tromey.com>
5523
5524 * minsyms.c (minimal_symbol_reader::record_full): Remove some
5525 initializations.
5526
1b7a07cb
TT
55272019-03-15 Tom Tromey <tom@tromey.com>
5528
5529 * objfiles.h (struct objfile_per_bfd_storage)
5530 <demangled_hash_languages>: Now a bitset.
5531 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5532 (lookup_minimal_symbol): Update.
5533
3db066bc
TT
55342019-03-15 Tom Tromey <tom@tromey.com>
5535
5536 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5537 Don't return the symbol.
5538 * coffread.c (record_minimal_symbol): Use record_full.
5539
3fff2c37
EZ
55402019-03-14 Eli Zaretskii <eliz@gnu.org>
5541
5542 The MS-Windows port of ncurses fails to switch to a color pair if
5543 one or both of the colors are the implicit default colors. This
5544 change records the default colors when TUI is initialized, and
5545 then specifies them explicitly when a color pair uses the default
5546 colors. This allows color styling in TUI mode on MS-Windows.
5547
5548 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
5549 ncurses_norm_attr.
5550 (tui_initialize_io) [__MINGW32__]: Record the default terminal
5551 colors in ncurses_norm_attr.
5552 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5553 "none", replace it with the default color recorded in
5554 ncurses_norm_attr.
5555
3b336828
TT
55562019-03-14 Tom Tromey <tromey@adacore.com>
5557
5558 * source-cache.h (class source_cache) <get_source_lines>: Return
5559 std::string.
5560 * source-cache.c (source_cache::extract_lines): Handle case where
5561 first_pos==npos. Return std::string.
5562 (source_cache::get_source_lines): Update.
5563
d085f989
TT
55642019-03-14 Tom Tromey <tromey@adacore.com>
5565
5566 * NEWS: Add item for "style sources" commands.
5567 * source-cache.c (source_cache::get_source_lines): Check
5568 source_styling.
5569 * cli/cli-style.c (source_styling): New global.
5570 (_initialize_cli_style): Add "style sources" commands.
5571 (show_style_sources): New function.
5572 * cli/cli-style.h (source_styling): Declare.
5573
6f11e682
TT
55742019-03-14 Pedro Alves <palves@redhat.com>
5575 Tom Tromey <tromey@adacore.com>
5576
5577 * tui/tui-winsource.h (tui_refill_source_window): Declare.
5578 * tui/tui-winsource.c (tui_refill_source_window): New function,
5579 from...
5580 (tui_horizontal_source_scroll): ... here. Move some logic.
5581 * cli/cli-style.c (set_style_enabled): Notify new observable.
5582 * tui/tui-hooks.c (tui_redisplay_source): New function.
5583 (tui_attach_detach_observers): Attach or detach
5584 tui_redisplay_source.
5585 * observable.h (source_styling_changed): New observable.
5586 * observable.c: Define source_styling_changed observable.
5587
a068643d
TT
55882019-03-13 Tom Tromey <tromey@adacore.com>
5589
5590 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5591 (i386_gnu_nat_target::store_registers): Update.
5592 * target-debug.h (target_debug_print_std_string): New macro.
5593 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5594 * windows-tdep.c (display_one_tib): Update.
5595 * tui/tui-stack.c (tui_make_status_line): Update.
5596 * top.c (print_inferior_quit_action): Update.
5597 * thread.c (thr_try_catch_cmd): Update.
5598 (add_thread_with_info): Update.
5599 (thread_target_id_str): Update.
5600 (thr_try_catch_cmd): Update.
5601 (thread_command): Update.
5602 (thread_find_command): Update.
5603 * record-btrace.c (record_btrace_target::info_record)
5604 (record_btrace_resume_thread, record_btrace_target::resume)
5605 (record_btrace_cancel_resume, record_btrace_step_thread)
5606 (record_btrace_target::wait, record_btrace_target::wait)
5607 (record_btrace_target::wait, record_btrace_target::stop): Update.
5608 * progspace.c (print_program_space): Update.
5609 * process-stratum-target.c
5610 (process_stratum_target::thread_address_space): Update.
5611 * linux-fork.c (linux_fork_mourn_inferior)
5612 (detach_checkpoint_command, info_checkpoints_command)
5613 (linux_fork_context): Update.
5614 (linux_fork_detach): Update.
5615 (class scoped_switch_fork_info): Update.
5616 (delete_checkpoint_command): Update.
5617 * infrun.c (follow_fork_inferior): Update.
5618 (follow_fork_inferior): Update.
5619 (proceed_after_vfork_done): Update.
5620 (handle_vfork_child_exec_or_exit): Update.
5621 (follow_exec): Update.
5622 (displaced_step_prepare_throw): Update.
5623 (displaced_step_restore): Update.
5624 (start_step_over): Update.
5625 (resume_1): Update.
5626 (clear_proceed_status_thread): Update.
5627 (proceed): Update.
5628 (print_target_wait_results): Update.
5629 (do_target_wait): Update.
5630 (context_switch): Update.
5631 (stop_all_threads): Update.
5632 (restart_threads): Update.
5633 (finish_step_over): Update.
5634 (handle_signal_stop): Update.
5635 (switch_back_to_stepped_thread): Update.
5636 (keep_going_pass_signal): Update.
5637 (print_exited_reason): Update.
5638 (normal_stop): Update.
5639 * inferior.c (inferior_pid_to_str): Change return type.
5640 (print_selected_inferior): Update.
5641 (add_inferior): Update.
5642 (detach_inferior): Update.
5643 * dummy-frame.c (fprint_dummy_frames): Update.
5644 * dcache.c (dcache_info_1): Update.
5645 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5646 (btrace_fetch, btrace_clear): Update.
5647 * linux-tdep.c (linux_core_pid_to_str): Change return type.
5648 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5649 type.
5650 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5651 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5652 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5653 * gdbarch.c, gdbarch.h: Rebuild.
5654 * gdbarch.sh (core_pid_to_str): Change return type.
5655 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5656 return type.
5657 (windows_nat_target::pid_to_str): Change return type.
5658 (windows_delete_thread): Update.
5659 (windows_nat_target::attach): Update.
5660 (windows_nat_target::files_info): Update.
5661 * target-delegates.c: Rebuild.
5662 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5663 return type.
5664 (sol_thread_target::pid_to_str): Change return type.
5665 * remote.c (class remote_target) <pid_to_str>: Change return
5666 type.
5667 (remote_target::pid_to_str): Change return type.
5668 (extended_remote_target::attach, remote_target::remote_stop_ns)
5669 (remote_target::remote_notif_remove_queued_reply)
5670 (remote_target::push_stop_reply, remote_target::disable_btrace):
5671 Update.
5672 (extended_remote_target::attach): Update.
5673 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5674 type.
5675 (gdbsim_target::pid_to_str): Change return type.
5676 * ravenscar-thread.c (struct ravenscar_thread_target)
5677 <pid_to_str>: Change return type.
5678 (ravenscar_thread_target::pid_to_str): Change return type.
5679 * procfs.c (class procfs_target) <pid_to_str>: Change return
5680 type.
5681 (procfs_target::pid_to_str): Change return type.
5682 (procfs_target::attach): Update.
5683 (procfs_target::detach): Update.
5684 (procfs_target::fetch_registers): Update.
5685 (procfs_target::store_registers): Update.
5686 (procfs_target::wait): Update.
5687 (procfs_target::files_info): Update.
5688 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5689 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5690 return type.
5691 (nto_procfs_target::pid_to_str): Change return type.
5692 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5693 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5694 return type.
5695 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5696 (exit_lwp): Update.
5697 (attach_proc_task_lwp_callback, get_detach_signal)
5698 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5699 (linux_nat_target::resume, wait_lwp, stop_callback)
5700 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5701 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5702 (linux_nat_wait_1, resume_stopped_resumed_lwps)
5703 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5704 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5705 type.
5706 (inf_ptrace_target::attach): Update.
5707 (inf_ptrace_target::files_info): Update.
5708 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5709 type.
5710 (go32_nat_target::pid_to_str): Change return type.
5711 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5712 (gnu_nat_target::wait): Update.
5713 (gnu_nat_target::wait): Update.
5714 (gnu_nat_target::resume): Update.
5715 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5716 (fbsd_nat_target::wait): Update.
5717 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5718 type.
5719 (darwin_nat_target::attach): Update.
5720 * corelow.c (class core_target) <pid_to_str>: Change return type.
5721 (core_target::pid_to_str): Change return type.
5722 * target.c (normal_pid_to_str): Change return type.
5723 (default_pid_to_str): Likewise.
5724 (target_pid_to_str): Change return type.
5725 (target_translate_tls_address): Update.
5726 (target_announce_detach): Update.
5727 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5728 return type.
5729 (bsd_uthread_target::pid_to_str): Change return type.
5730 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5731 type.
5732 (bsd_kvm_target::pid_to_str): Change return type.
5733 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5734 return type.
5735 (aix_thread_target::pid_to_str): Change return type.
5736 * target.h (struct target_ops) <pid_to_str>: Change return type.
5737 (target_pid_to_str, normal_pid_to_str): Likewise.
5738 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5739 type.
5740 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5741 type.
5742 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5743 return type.
5744 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5745 type.
5746 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5747 type.
5748 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5749 return type.
5750
b4be1b06
SM
57512019-03-13 Simon Marchi <simon.marchi@ericsson.com>
5752
5753 * NEWS: Mention that the new default MI version is 3. Mention
5754 changes to the output of commands and events that deal with
5755 multi-location breakpoints.
5756 * breakpoint.c: Include "mi/mi-out.h".
5757 (print_one_breakpoint): Change output syntax if using MI version
5758 >= 3.
5759 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5760 New.
5761 (mi_multi_location_breakpoint_output_fixed): New.
5762 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5763 (mi_cmd_fix_multi_location_breakpoint_output): New.
5764 (mi_multi_location_breakpoint_output_fixed): New.
5765 * mi/mi-cmds.c (mi_cmds): Register command
5766 -fix-multi-location-breakpoint-output.
5767 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5768 interpreter "mi".
5769
8e5e5494
SM
57702019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
5771
5772 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5773 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5774 instantiate mi_ui_out based on interpreter name.
5775 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5776 * mi/mi-main.c (mi_load_progress): Likewise.
5777
197df35e
JB
57782019-03-12 John Baldwin <jhb@FreeBSD.org>
5779
5780 * NEWS: Combine separate "New targets" sections for 8.3.
5781
8399425f
JB
57822019-03-12 John Baldwin <jhb@FreeBSD.org>
5783
5784 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5785 (ppcfbsd_init_abi): Install gdbarch
5786 "fetch_tls_load_module_address" and "get_thread_local_address"
5787 methods.
5788
b0f87ed0
JB
57892019-03-12 John Baldwin <jhb@FreeBSD.org>
5790
5791 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5792 (riscv_fbsd_init_abi): Install gdbarch
5793 "fetch_tls_load_module_address" and "get_thread_local_address"
5794 methods.
5795
ce25aa57
JB
57962019-03-12 John Baldwin <jhb@FreeBSD.org>
5797
5798 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5799 (i386fbsd_init_abi): Install gdbarch
5800 "fetch_tls_load_module_address" and "get_thread_local_address"
5801 methods.
5802
f5424cfa
JB
58032019-03-12 John Baldwin <jhb@FreeBSD.org>
5804
5805 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5806 (amd64fbsd_init_abi): Install gdbarch
5807 "fetch_tls_load_module_address" and "get_thread_local_address"
5808 methods.
5809
945f3901
JB
58102019-03-12 John Baldwin <jhb@FreeBSD.org>
5811
5812 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5813 (struct fbsd_pspace_data): New type.
5814 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5815 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5816 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5817 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5818 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5819
ef0bd204
JB
58202019-03-12 John Baldwin <jhb@FreeBSD.org>
5821
5822 * gdbtypes.c (lookup_struct_elt): New function.
5823 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5824 * gdbtypes.h (struct struct_elt): New type.
5825 (lookup_struct_elt): New prototype.
5826
36c53a02
JB
58272019-03-12 John Baldwin <jhb@FreeBSD.org>
5828
5829 * gdbtypes.c (lookup_struct_elt_type): Update comment and
5830 remove disabled code block.
5831
6e056c81
JB
58322019-03-12 John Baldwin <jhb@FreeBSD.org>
5833
5834 * gdbarch.sh (get_thread_local_address): New method.
5835 * gdbarch.h, gdbarch.c: Regenerate.
5836 * target.c (target_translate_tls_address): Use
5837 gdbarch_get_thread_local_address if present instead of
5838 target::get_thread_local_address.
5839
cd250a18
JB
58402019-03-12 John Baldwin <jhb@FreeBSD.org>
5841
5842 * target.h (target::get_thread_local_address): Update comment.
5843
df22c1e5
JB
58442019-03-12 John Baldwin <jhb@FreeBSD.org>
5845
5846 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5847 objfile->separate_debug_objfile_backlink if not NULL.
5848
dd6876c9
JB
58492019-03-12 John Baldwin <jhb@FreeBSD.org>
5850
5851 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5852 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5853 (amd64bsd_store_inferior_registers): Likewise.
5854 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5855 Enable segment base registers.
5856 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5857 PT_GETFSBASE and PT_GETGSBASE.
5858 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5859 PT_SETGSBASE.
5860 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5861 segment base registers.
5862 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5863
1163a4b7
JB
58642019-03-12 John Baldwin <jhb@FreeBSD.org>
5865
5866 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5867 Update calls to i386_target_description to add 'segments'
5868 parameter.
5869 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
5870 add segment base registers.
5871 * arch/i386.c (i386_create_target_description): Add 'segments'
5872 parameter to enable segment base registers.
5873 * arch/i386.h (i386_create_target_description): Likewise.
5874 * features/i386/32bit-segments.xml: New file.
5875 * features/i386/32bit-segments.c: Generate.
5876 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5877 call to i386_target_description to add 'segments' parameter.
5878 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5879 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5880 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5881 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5882 if feature is present.
5883 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5884 Add 'segments' parameter to call to i386_target_description.
5885 (i386_target_description): Add 'segments' parameter to enable
5886 segment base registers.
5887 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5888 to call to i386_target_description.
5889 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5890 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5891 Define I386_NUM_REGS.
5892 (i386_target_description): Add 'segments' parameter to enable
5893 segment base registers.
5894
3a350822
EZ
58952019-03-12 Eli Zaretskii <eliz@gnu.org>
5896
5897 PR/24325
5898 * source-cache.c: #undef open and close, to avoid unresolved
5899 externals during linking.
5900
ffdd69cf
TT
59012019-03-12 Tom Tromey <tromey@adacore.com>
5902
5903 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5904 const. Add initializers.
5905 (_initialize_remote): Don't initialize ptid globals.
5906
ec148c57
PA
59072019-03-12 Pedro Alves <palves@redhat.com>
5908
5909 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5910
32764270
PA
59112019-03-12 Pedro Alves <palves@redhat.com>
5912
5913 * cp-name-parser.y (main): Remove unused 'len' variable.
5914
17547186
TT
59152019-03-12 Tom Tromey <tromey@adacore.com>
5916
5917 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5918 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5919
d3a70e03
TT
59202019-03-12 Tom Tromey <tromey@adacore.com>
5921
5922 * linux-nat.c (iterate_over_lwps): Update.
5923 (stop_callback): Remove parameter.
5924 (stop_wait_callback, detach_callback, resume_set_callback)
5925 (select_singlestep_lwp_callback, set_ignore_sigint)
5926 (status_callback, resumed_callback, resume_clear_callback)
5927 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5928 data parameter.
5929 (linux_nat_target::detach, linux_nat_target::resume)
5930 (linux_stop_and_wait_all_lwps, select_event_lwp)
5931 (linux_nat_filter_event, linux_nat_wait_1)
5932 (linux_nat_target::kill, linux_nat_target::stop)
5933 (linux_nat_target::stop): Update.
5934 (linux_nat_resume_callback): Change type.
5935 (resume_stopped_resumed_lwps, count_events_callback)
5936 (select_event_lwp_callback): Likewise.
5937 (linux_stop_lwp, linux_nat_stop_lwp): Update.
5938 * arm-linux-nat.c (struct update_registers_data): Remove.
5939 (update_registers_callback): Change type.
5940 (arm_linux_insert_hw_breakpoint1): Update.
5941 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5942 parameter.
5943 (x86_linux_dr_set_addr): Update.
5944 (x86_linux_dr_set_control): Update.
5945 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5946 (iterate_over_lwps): Use gdb::function_view.
5947 * nat/aarch64-linux-hw-point.c (struct
5948 aarch64_dr_update_callback_param): Remove.
5949 (debug_reg_change_callback): Change type.
5950 (aarch64_notify_debug_reg_change): Update.
5951 * s390-linux-nat.c (s390_refresh_per_info): Update.
5952
82cb27ff
TT
59532019-03-11 Tom Tromey <tromey@adacore.com>
5954
5955 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5956 redundant assignment to "this_cu".
5957
568c0683
SM
59582019-03-08 Simon Marchi <simon.marchi@efficios.com>
5959
5960 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5961
f09ce22d
SM
59622019-03-08 Simon Marchi <simon.marchi@efficios.com>
5963
5964 * gdbtypes.c (rank_one_type_parm_set): New function extracted
5965 from...
5966 (rank_one_type): ... this.
5967
595f96a9
SM
59682019-03-08 Simon Marchi <simon.marchi@efficios.com>
5969
5970 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5971 from...
5972 (rank_one_type): ... this.
5973
2598a94b
SM
59742019-03-08 Simon Marchi <simon.marchi@efficios.com>
5975
5976 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5977 from...
5978 (rank_one_type): ... this.
5979
7f17b20d
SM
59802019-03-08 Simon Marchi <simon.marchi@efficios.com>
5981
5982 * gdbtypes.c (rank_one_type_parm_float): New function extracted
5983 from...
5984 (rank_one_type): ... this.
5985
2c509035
SM
59862019-03-08 Simon Marchi <simon.marchi@efficios.com>
5987
5988 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5989 from...
5990 (rank_one_type): ... this.
5991
0dd322dc
SM
59922019-03-08 Simon Marchi <simon.marchi@efficios.com>
5993
5994 * gdbtypes.c (rank_one_type_parm_range): New function extracted
5995 from...
5996 (rank_one_type): ... this.
5997
41ea4728
SM
59982019-03-08 Simon Marchi <simon.marchi@efficios.com>
5999
6000 * gdbtypes.c (rank_one_type_parm_char): New function extracted
6001 from...
6002 (rank_one_type): ... this.
6003
793cd1d2
SM
60042019-03-08 Simon Marchi <simon.marchi@efficios.com>
6005
6006 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6007 from...
6008 (rank_one_type): ... this.
6009
34910087
SM
60102019-03-08 Simon Marchi <simon.marchi@efficios.com>
6011
6012 * gdbtypes.c (rank_one_type_parm_int): New function extracted
6013 from...
6014 (rank_one_type): ... this.
6015
f1f832d6
SM
60162019-03-08 Simon Marchi <simon.marchi@efficios.com>
6017
6018 * gdbtypes.c (rank_one_type_parm_func): New function extracted
6019 from...
6020 (rank_one_type): ... this.
6021
b9f4512f
SM
60222019-03-08 Simon Marchi <simon.marchi@efficios.com>
6023
6024 * gdbtypes.c (rank_one_type_parm_array): New function extracted
6025 from...
6026 (rank_one_type): ... this.
6027
9293fc63
SM
60282019-03-08 Simon Marchi <simon.marchi@efficios.com>
6029
6030 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6031 from...
6032 (rank_one_type): ... this.
6033
e3abbe7e
PW
60342019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6035
6036 * inferior.c (initialize_inferiors): Ensure 'help set/show print
6037 inferior-events' shows the example events.
6038
e4adb939
EZ
60392019-03-08 Eli Zaretskii <eliz@gnu.org>
6040
6041 Support styling on native MS-Windows console
6042
6043 PR/24315
6044 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6045 on MS-Windows if $TERM is not defined.
6046
6047 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6048
6049 * posix-hdep.c (gdb_console_fputs):
6050 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6051 functions.
6052 * ui-file.h (gdb_console_fputs): Add prototype.
6053
6054 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6055 back to fputs only if the former returns zero.
6056
25629dfd
TT
60572019-03-07 Tom Tromey <tom@tromey.com>
6058
6059 * symmisc.c (print_symbol_bcache_statistics): Update.
6060 (print_objfile_statistics): Update.
6061 * symfile.c (allocate_symtab): Update.
6062 * stabsread.c: Don't include bcache.h.
6063 * psymtab.h (struct psymbol_bcache): Don't declare.
6064 (class psymtab_storage) <psymbol_cache>: Now a bcache.
6065 (psymbol_bcache_init, psymbol_bcache_free)
6066 (psymbol_bcache_get_bcache): Don't declare.
6067 * psymtab.c (struct psymbol_bcache): Remove.
6068 (psymtab_storage::psymtab_storage): Update.
6069 (psymtab_storage::~psymtab_storage): Update.
6070 (psymbol_bcache_init, psymbol_bcache_free)
6071 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6072 (add_psymbol_to_bcache): Update.
6073 (allocate_psymtab): Update.
6074 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6075 macro_cache>: No longer pointers.
6076 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6077 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6078 * macrotab.c (macro_bcache): Update.
6079 * macroexp.c: Don't include bcache.h.
6080 * gdbtypes.c (check_types_worklist): Update.
6081 (types_deeply_equal): Remove TRY/CATCH. Update.
6082 * elfread.c (elf_symtab_read): Update.
6083 * dwarf2read.c: Don't include bcache.h.
6084 * buildsym.c (buildsym_compunit::get_macro_table): Update.
6085 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6086 (print_bcache_statistics, bcache_memory_used): Don't declare.
6087 (struct bcache): Move from bcache.c. Add constructor, destructor,
6088 methods. Rename all data members.
6089 * bcache.c (struct bcache): Move to bcache.h.
6090 (bcache::expand_hash_table): Rename from expand_hash_table.
6091 (bcache): Remove.
6092 (bcache::insert): Rename from bcache_full.
6093 (bcache::compare): Rename from bcache_compare.
6094 (bcache_xmalloc): Remove.
6095 (bcache::~bcache): Rename from bcache_xfree.
6096 (bcache::print_statistics): Rename from print_bcache_statistics.
6097 (bcache::memory_used): Rename from bcache_memory_used.
6098
fe726667
PA
60992019-03-07 Pedro Alves <palves@redhat.com>
6100
6101 * infrun.c (normal_stop): Also check for
6102 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6103
7584bb30
AB
61042019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
6105
6106 * f-lang.c (value_from_host_double): Moved to...
6107 * value.c (value_from_host_double): ...here.
6108 * value.h (value_from_host_double): Declare.
6109 * guile/scm-math.c (vlscm_convert_typed_number): Use
6110 value_from_host_double.
6111 (vlscm_convert_number): Likewise.
6112 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6113 * python/py-value.c (convert_value_from_python): Likewise.
6114
a7b1986e
TT
61152019-03-06 Tom Tromey <tom@tromey.com>
6116
6117 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6118
0ccf4211
TT
61192019-03-06 Tom Tromey <tom@tromey.com>
6120
6121 * utils.h (free_current_contents): Don't declare.
6122 * utils.c (free_current_contents): Remove.
6123
fe7b42e5
TT
61242019-03-06 Tom Tromey <tom@tromey.com>
6125
6126 * top.c (quit_force): Update.
6127 * main.c (captured_command_loop): Update.
6128 * common/new-op.c (operator new): Update.
6129 * common/common-exceptions.c (struct catcher)
6130 <save_cleanup_chain>: Remove member.
6131 (exceptions_state_mc_init): Update.
6132 (exception_try_scope_entry): Return nullptr.
6133 (exception_try_scope_exit, exception_rethrow)
6134 (throw_exception_sjlj, throw_exception_cxx): Update.
6135 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6136 (all_cleanups, do_cleanups, discard_cleanups)
6137 (discard_final_cleanups, save_cleanups, save_final_cleanups)
6138 (restore_cleanups, restore_final_cleanups): Don't declare.
6139 (do_final_cleanups): Remove parameter.
6140 * common/cleanups.c (cleanup_chain, make_cleanup)
6141 (make_cleanup_dtor, all_cleanups, do_cleanups)
6142 (discard_my_cleanups, discard_cleanups)
6143 (discard_final_cleanups, save_my_cleanups, save_cleanups)
6144 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6145 (null_cleanup): Remove.
6146 (do_final_cleanups): Remove parameter.
6147
c6321f19
TT
61482019-03-06 Tom Tromey <tom@tromey.com>
6149
6150 * remote.c (remote_target::remote_parse_stop_reply): Use
6151 unique_xmalloc_ptr.
6152
61b30099
TT
61532019-03-06 Tom Tromey <tom@tromey.com>
6154
6155 * stabsread.c (struct stabs_field_info): Rename from field_info.
6156 <list, fnlist>: Add initializers.
6157 <obstack>: New member.
6158 (read_member_functions, read_struct_fields, read_baseclasses):
6159 Allocate on obstack. Don't use cleanups.
6160 (read_one_struct_field, read_member_functions, read_struct_fields)
6161 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6162 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6163 (read_struct_type): Update.
6164
6cceac94
TT
61652019-03-06 Tom Tromey <tom@tromey.com>
6166
6167 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6168 * common/filestuff.h (make_cleanup_close): Don't declare.
6169 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6170 Remove.
6171
72412762
TT
61722019-03-06 Tom Tromey <tom@tromey.com>
6173
6174 * solib-aix.c: Use make_scope_exit.
6175
2b6ff1c0
TT
61762019-03-06 Tom Tromey <tom@tromey.com>
6177
6178 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6179 Use make_scope_exit.
6180
d01c5877
TT
61812019-03-06 Tom Tromey <tom@tromey.com>
6182
6183 * solib-svr4.c (disable_probes_interface): Remove parameter.
6184 (svr4_handle_solib_event): Use make_scope_exit.
6185
32603266
TT
61862019-03-06 Tom Tromey <tom@tromey.com>
6187
6188 * remote.c (struct stop_reply_deleter): Remove.
6189 (stop_reply_up): Update.
6190 (struct stop_reply): Derive from notif_event. Don't typedef.
6191 <regcache>: Now a std::vector.
6192 (stop_reply_xfree): Remove.
6193 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6194 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
6195 (remote_target::discard_pending_stop_replies): Use delete.
6196 (remote_target::remote_parse_stop_reply): Update.
6197 (remote_target::process_stop_reply): Update.
6198 * remote-notif.h (struct notif_event): Add virtual destructor.
6199 Remove "dtr" member.
6200 (struct notif_client) <alloc_event>: Return a unique_ptr.
6201 (notif_event_xfree): Don't declare.
6202 (notif_event_up): New typedef.
6203 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6204 (notif_event_xfree, do_notif_event_xfree): Remove.
6205 (remote_notif_state_xfree): Update.
6206
9799571e
TT
62072019-03-06 Tom Tromey <tom@tromey.com>
6208
6209 * infrun.c (displaced_step_clear_cleanup): Now a
6210 forward_scope_exit type.
6211 (displaced_step_prepare_throw): Update.
6212 (displaced_step_fixup): Update.
6213
09e3c4ca
TT
62142019-03-06 Tom Tromey <tom@tromey.com>
6215
6216 * inferior.h (class inferior): Update comment.
6217 * gdbthread.h (class thread_info): Update comment.
6218
e2a03548
TT
62192019-03-06 Joel Brobecker <brobecker@adacore.com>
6220 Tom Tromey <tom@tromey.com>
6221
6222 * stabsread.h (struct stab_section_list): Remove.
6223 (coffstab_build_psymtabs): Update.
6224 * dbxread.c (symbuf_sections): Now a std::vector.
6225 (sect_idx): New global.
6226 (fill_symbuf): Update.
6227 (coffstab_build_psymtabs): Change type of stabsects parameter.
6228 Update.
6229 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6230 std::vector.
6231 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6232 (coff_locate_sections): Update.
6233 (coff_symfile_read): Remove cleanups. Update.
6234 (init_stringtab): Add storage parameter.
6235 (free_stringtab, free_stringtab_cleanup): Remove.
6236 (init_lineno): Add storage parameter.
6237 (free_linetab, free_linetab_cleanup): Remove.
6238
b7e60d85
PA
62392019-03-06 Pedro Alves <palves@redhat.com>
6240
6241 * linux-fork.c (fork_info::clobber_regs): Delete.
6242 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6243 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
6244 comment. Adjust.
6245 (scoped_switch_fork_info::scoped_switch_fork_info)
6246 (checkpoint_command, linux_fork_context): Adjust
6247 fork_save_infrun_state calls.
6248
e52c971f
PA
62492019-03-06 Pedro Alves <palves@redhat.com>
6250
6251 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6252 (inf_has_multiple_threads): Return 'bool' and rewrite using
6253 inferior_info::threads().
6254
06974e6c
PA
62552019-03-06 Pedro Alves <palves@redhat.com>
6256
6257 * linux-fork.c: Include <list>.
6258 (fork_list): Now a std::list instance.
6259 (fork_info): Add ctor, dtor, and in-class initialize all fields.
6260 (forks_exist_p, find_last_fork): Adjust.
6261 (new_fork): Delete.
6262 (one_fork_p): New.
6263 (add_fork): Adjust.
6264 (free_fork): Delete, folded into fork_info::~fork_info().
6265 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6266 Adjust.
6267 (init_fork_list): Delete.
6268 (linux_fork_killall, linux_fork_mourn_inferior)
6269 (linux_fork_detach, info_checkpoints_command): Adjust.
6270 (_initialize_linux_fork): No longer call init_fork_list.
6271
72f31aea
PA
62722019-03-06 Pedro Alves <palves@redhat.com>
6273
6274 * linux-fork.c (new_fork): New, split out of ...
6275 (add_fork): ... this. Return void. Move "first fork" special
6276 case from here, to ...
6277 (checkpoint_command): ... here.
6278 * linux-linux.h (add_fork): Return void.
6279
efbecbc1
AB
62802019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6281
6282 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6283
0841c79a
AB
62842019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6285 Chris January <chris.january@arm.com>
6286 David Lecomber <david.lecomber@arm.com>
6287
6288 * f-exp.y: New token, UNOP_INTRINSIC.
6289 (exp): New pattern using UNOP_INTRINSIC token.
6290 (f77_keywords): Add 'abs' keyword.
6291 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6292 (value_from_host_double): New function.
6293 (evaluate_subexp_f): Support UNOP_ABS.
6294
4a270568
AB
62952019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6296
6297 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6298 types.
6299
067630bd
AB
63002019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6301
6302 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6303 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6304 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6305
3be47f7a
AB
63062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6307
6308 * f-exp.y (convert_to_kind_type): Handle more type kinds.
6309
4d00f5d8
AB
63102019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6311 Chris January <chris.january@arm.com>
6312
6313 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6314 * f-exp.y: Define 'KIND' token.
6315 (exp): New pattern for KIND expressions.
6316 (ptype): Handle types with a kind extension.
6317 (direct_abs_decl): Extend to spot kind extensions.
6318 (f77_keywords): Add 'kind' to the list.
6319 (push_kind_type): New function.
6320 (convert_to_kind_type): New function.
6321 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6322 * parse.c (operator_length_standard): Likewise.
6323 * parser-defs.h (enum type_pieces): Add tp_kind.
6324 * std-operator.def: Add UNOP_KIND.
6325
e454224f
AB
63262019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6327
6328 * f-exp.y (f_parse): Set yydebug.
6329
9dad4a58
AB
63302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6331
6332 * f-lang.c (evaluate_subexp_f): New function.
6333 (exp_descriptor_f): New global.
6334 (f_language_defn): Use exp_descriptor_f instead of
6335 exp_descriptor_standard.
6336
c8f91604
AB
63372019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6338
6339 * f-exp.y (struct token): Add comments.
6340 (dot_ops): Remove uppercase versions and the end marker.
6341 (f77_keywords): Likewise.
6342 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6343 entries in the dot_ops array are case insensitive, and use
6344 strncasecmp to compare strings. Also some whitespace cleanup in
6345 this area. Similar for the f77_keywords array, except entries in
6346 this list might be case sensitive.
6347
dd9f2c76
AB
63482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6349
6350 * f-exp.y (struct f77_boolean_val): Add comments.
6351 (boolean_values): Remove uppercase versions, and end marker.
6352 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6353 and use strncasecmp to achieve case insensitivity. Additionally,
6354 perform whitespace cleanup around this code.
6355
67a3048c
TT
63562019-03-06 Tom Tromey <tromey@adacore.com>
6357
6358 * remote-sim.c (gdbsim_target_open): Use result of
6359 gdb_argv::release.
6360
aa3cfbda
RB
63612019-03-06 Richard Bunt <richard.bunt@arm.com>
6362 Dirk Schubert <dirk.schubert@arm.com>
6363 Chris January <chris.january@arm.com>
6364
6365 * eval.c (evaluate_subexp_standard): Call Fortran argument
6366 wrapping logic.
6367 * f-lang.c (struct value): A value which can be passed into a
6368 Fortran function call.
6369 (fortran_argument_convert): Wrap Fortran arguments in a pointer
6370 where appropriate.
6371 (struct type): Value ready for a Fortran function call.
6372 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6373 is needed.
6374 * f-lang.h (fortran_argument_convert): Declaration.
6375 (fortran_preserve_arg_pointer): Declaration.
6376 * infcall.c (value_arg_coerce): Call Fortran argument logic.
6377
ea38e5df
TT
63782019-03-05 Tom Tromey <tromey@adacore.com>
6379
6380 * python/py-prettyprint.c (print_string_repr): Remove #if.
6381 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6382
06b5b831
TT
63832019-03-05 Tom Tromey <tromey@adacore.com>
6384
6385 * target.c (the_dummy_target): Move later. Change type to
6386 "dummy_target".
6387 (initialize_targets): Don't initialize the_dummy_target.
6388
edbd9e45
TT
63892019-03-05 Tom Tromey <tromey@adacore.com>
6390
6391 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6392 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6393
c119e040
TT
63942019-03-05 Tom Tromey <tromey@adacore.com>
6395
6396 * windows-nat.c (windows_nat_target::attach)
6397 (windows_nat_target::detach): Don't call gdb_flush.
6398 * valprint.c (generic_val_print, val_print, val_print_string):
6399 Don't call gdb_flush.
6400 * utils.c (defaulted_query): Don't call gdb_flush.
6401 * typeprint.c (print_type_scalar): Don't call gdb_flush.
6402 * target.c (target_announce_detach): Don't call gdb_flush.
6403 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6404 * remote.c (extended_remote_target::attach): Don't call
6405 gdb_flush.
6406 * procfs.c (procfs_target::detach): Don't call gdb_flush.
6407 * printcmd.c (do_examine): Don't call gdb_flush.
6408 (info_display_command): Don't call gdb_flush.
6409 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6410 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6411 * memattr.c (info_mem_command): Don't call gdb_flush.
6412 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6413 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6414 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6415 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6416 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6417 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6418 (gnu_nat_target::detach): Don't call gdb_flush.
6419 * f-valprint.c (f_val_print): Don't call gdb_flush.
6420 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6421 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6422 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6423 gdb_flush.
6424 * c-valprint.c (c_val_print): Don't call gdb_flush.
6425 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6426
895dafa6
TT
64272019-03-05 Tom Tromey <tromey@adacore.com>
6428
6429 * varobj.c (update_dynamic_varobj_children): Update.
6430 (install_default_visualizer): Use reset, not release.
6431 * value.c (set_internalvar): Update.
6432 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6433 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6434 ATTRIBUTE_UNUSED_RESULT.
6435
88a774b9
TT
64362019-03-05 Tom Tromey <tromey@adacore.com>
6437
6438 * remote.c (class scoped_remote_fd) <release>: Add
6439 ATTRIBUTE_UNUSED_RESULT.
6440
4e4a8b93
TT
64412019-03-05 Tom Tromey <tromey@adacore.com>
6442
6443 * macroexp.c (struct macro_buffer) <release>: Add
6444 ATTRIBUTE_UNUSED_RESULT.
6445
083eef1f
TT
64462019-03-05 Tom Tromey <tromey@adacore.com>
6447
6448 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6449 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6450 ATTRIBUTE_UNUSED_RESULT.
6451
3cabd438
TT
64522019-03-05 Tom Tromey <tromey@adacore.com>
6453
6454 * common/scoped_fd.h (class scoped_fd) <release>: Add
6455 ATTRIBUTE_UNUSED_RESULT.
6456
41e3300a
TT
64572019-03-05 Tom Tromey <tromey@adacore.com>
6458
6459 * parser-defs.h (struct parser_state) <release>: Add
6460 ATTRIBUTE_UNUSED_RESULT.
6461
18cb7c9f
TT
64622019-03-05 Tom Tromey <tromey@adacore.com>
6463
6464 * utils.h (class gdb_argv) <release>: Add
6465 ATTRIBUTE_UNUSED_RESULT.
6466 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6467
41fa577f
EZ
64682019-03-02 Eli Zaretskii <eliz@gnu.org>
6469
a6a4b2c6
EZ
6470 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6471 for-loop range, to avoid compiler warnings.
6472
6473 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6474 avoid compiler warnings about unused variables.
6475
742a7df5
EZ
6476 * NEWS: Mention end of support for native debugging on MS-Windows
6477 before XP.
6478
41fa577f
EZ
6479 PR gdb/24292
6480 * common/netstuff.c:
6481 * gdbserver/gdbreplay.c
6482 * gdbserver/remote-utils.c:
6483 * ser-tcp.c:
6484 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6485 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
6486 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6487 'getaddrinfo' and 'freeaddrinfo' were not available before
6488 Windows XP, and mingw.org's MinGW headers by default define
6489 _WIN32_WINNT to 0x500.
6490
827f438f
GB
64912019-03-01 Gary Benson <gbenson@redhat.com>
6492
6493 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6494
92137da0
RO
64952019-02-28 Brian Vandenberg <phantall@gmail.com>
6496 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
6497
6498 PR gdb/8527
6499 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6500 set_sigint_trap, clear_sigint_trap.
6501
799efbe8
PW
65022019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6503
6504 * target.c (target_detach): Clear the regcache and the
6505 frame cache.
6506
8ed25214
PA
65072019-02-27 Pedro Alves <palves@redhat.com>
6508
6509 * utils.c (set_screen_size): When we cap the height/width sizes,
6510 tweak the corresponding command variable to show "unlimited":
6511
23031e31
SJ
65122019-02-27 Saagar Jha <saagar@saagarjha.com>
6513 Pedro Alves <palves@redhat.com>
6514
6515 * utils.c (set_screen_size): Reduce "infinite" rows and columns
6516 before calling rl_set_screen_size.
6517
6c28e44a
TT
65182019-02-27 Tom Tromey <tromey@adacore.com>
6519
6520 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6521 define.
6522 * python/py-value.c: Remove Python 2.4 workaround.
6523 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6524 workaround.
6525 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6526 Python 2.4 workaround.
6527 * python/python-internal.h: Remove Python 2.4 comment.
6528 (Py_ssize_t): Don't define.
6529 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6530 (gdb_Py_DECREF): Remove Python 2.4 workaround.
6531 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6532 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6533 * python/python.c (do_start_initialization): Remove Python 2.4
6534 workaround.
6535 * python/py-prettyprint.c (class dummy_python_frame): Remove.
6536 (print_children): Remove Python 2.4 workaround.
6537 * python/py-inferior.c (buffer_procs): Remove Python 2.4
6538 workaround.
6539 (CHARBUFFERPROC_NAME): Remove.
6540 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6541 Python 2.4 workaround.
6542
2c3fc25d 65432019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 6544
2c3fc25d
KB
6545 * NEWS: Note minimum Python version.
6546
6ca62222
KB
65472019-02-27 Kevin Buettner <kevinb@redhat.com>
6548
6549 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6550 code from these functions. Remove corresponding ifdefs. Use
6551 Py_buffer_up instead of explicit calls to PyBuffer_Release.
6552 Remove gotos and target of gotos.
6553 (infpy_search_memory): Likewise.
6554
f4bc7d2c
AB
65552019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6556
6557 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6558 (hppa_gdbarch_init): Don't register deleted functions with
6559 gdbarch.
6560
9734a586
AB
65612019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6562
6563 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6564 (h8300_unwind_sp): Delete.
6565 (h8300_dummy_id): Delete.
6566 (h8300_gdbarch_init): Don't register deleted functions with
6567 gdbarch.
6568
68b867f3
AB
65692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6570
6571 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6572 (ft32_unwind_pc): Delete.
6573 (ft32_unwind_sp): Delete.
6574 (ft32_gdbarch_init): Don't register deleted functions with
6575 gdbarch.
6576
2fbe7ad0
AB
65772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6578
6579 * gdb/frv-tdep.c (frv_dummy_id): Delete.
6580 (frv_unwind_pc): Delete.
6581 (frv_unwind_sp): Delete.
6582 (frv_gdbarch_init): Don't register deleted functions with
6583 gdbarch.
6584
76055cbe
AB
65852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6586
6587 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6588 (riscv_unwind_pc): Delete.
6589 (riscv_unwind_sp): Delete.
6590 (riscv_gdbarch_init): Don't register deleted functions with
6591 gdbarch.
6592
4133e5a1
AB
65932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6594
6595 * gdb/csky-tdep.c (csky_dummy_id): Delete.
6596 (csky_unwind_pc): Delete.
6597 (csky_unwind_sp): Delete.
6598 (csky_gdbarch_init): Don't register deleted functions with
6599 gdbarch.
6600
8010f576
AB
66012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6602
6603 * gdb/cris-tdep.c (cris_dummy_id): Delete.
6604 (cris_unwind_pc): Delete.
6605 (cris_unwind_sp): Delete.
6606 (cris_gdbarch_init): Don't register deleted functions with
6607 gdbarch.
6608
b56bf084
AB
66092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6610
6611 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6612 (bfin_unwind_pc): Delete.
6613 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6614
a19a650f
AB
66152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6616
6617 * gdb/arm-tdep.c (arm_dummy_id): Delete.
6618 (arm_unwind_pc): Delete.
6619 (arm_unwind_sp): Delete.
6620 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6621
f8278c3c
AB
66222019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6623
6624 * gdb/arc-tdep.c (arc_dummy_id): Delete.
6625 (arc_unwind_pc): Delete.
6626 (arc_unwind_sp): Delete.
6627 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6628
480e46cf
AB
66292019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6630
6631 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6632 (alpha_unwind_pc): Delete.
6633 (alpha_gdbarch_init): Don't register deleted functions with
6634 gdbarch.
6635
7a995095
AB
66362019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6637
6638 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6639 (aarch64_unwind_pc): Delete.
6640 (aarch64_unwind_sp): Delete.
6641 (aarch64_gdbarch_init): Don't register deleted functions with
6642 gdbarch.
6643
bf9a735e
AB
66442019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6645
6646 * gdbtypes.c (type_align): Don't consider static members when
6647 computing structure alignment.
6648
5561fc30
AB
66492019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6650
6651 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6652 return 0 for other types.
6653 * arch-utils.c (default_type_align): Always return 0.
6654 * gdbarch.h: Regenerate.
6655 * gdbarch.sh (type_align): Extend comment.
6656 * gdbtypes.c (type_align): Add additional comments, always call
6657 gdbarch_type_align before applying the default rules.
6658 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6659 generic code will then apply a suitable default.
6660 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6661 types, return 0 for other types.
6662
9335e75a
JB
66632019-02-27 Joel Brobecker <brobecker@adacore.com>
6664
6665 * NEWS: Create a new section for the next release branch.
6666 Rename the section of the current branch, now that it has
6667 been cut.
6668
3d34d8de
JB
66692019-02-27 Joel Brobecker <brobecker@adacore.com>
6670
6671 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6672 * version.in: Bump version to 8.3.50.DATE-git.
6673
143420fb
SM
66742019-02-26 Simon Marchi <simon.marchi@efficios.com>
6675
6676 * aix-thread.c (ptid_cmp): Remove unused variable.
6677 (get_signaled_thread): Likewise.
6678 (store_regs_user_thread): Likewise.
6679 (store_regs_kernel_thread): Likewise.
6680 (fetch_regs_kernel_thread): Remove shadowed variable.
6681
172fb711
AB
66822019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
6683
6684 * features/riscv/32bit-cpu.xml: Add register numbers.
6685 * features/riscv/32bit-fpu.c: Regenerate.
6686 * features/riscv/32bit-fpu.xml: Add register numbers.
6687 * features/riscv/64bit-cpu.xml: Add register numbers.
6688 * features/riscv/64bit-fpu.c: Regenerate.
6689 * features/riscv/64bit-fpu.xml: Add register numbers.
6690
26c89782
KB
66912019-02-26 Kevin Buettner <kevinb@redhat.com>
6692
af54ade9 6693 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
6694 * python/py-value.c (convert_buffer_and_type_to_value): New
6695 function.
6696 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6697 Add support for handling an optional second argument. Call
6698 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
6699 * python/python-internal.h (Py_buffer_deleter): New struct.
6700 (Py_buffer_up): New typedef.
6701
0f58c9e8
JB
67022019-02-25 John Baldwin <jhb@FreeBSD.org>
6703
6704 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6705 instead of releasing ownership.
6706
0a0f4c01
JR
67072019-02-25 Jordan Rupprecht <rupprecht@google.com>
6708
6709 * dwarf2read.c (open_and_init_dwp_file): Call
6710 elf_numsections instead of bfd_count_sections to initialize
6711 dwp_file->num_sections.
6712
cd5a152c
TT
67132019-02-25 Tom Tromey <tromey@adacore.com>
6714
6715 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6716
8a6a8513
SDJ
67172019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
6718
6719 * gcore.in: Add '--readnever' option when invoking GDB.
6720
04dcda9c
SM
67212019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
6722
6723 * MAINTAINERS: Update my email address.
6724
07bc701d
SM
67252019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
6726
6727 * build-id.c (build_id_to_debug_bfd_1): New function.
6728 (build_id_to_debug_bfd): Look for separate debug file in
6729 sysroot.
6730
c6f4a5d0
AB
67312019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
6732
6733 * gdbarch.sh: Update the copyright year range that is placed into
6734 generated files.
6735
9600246d
KS
67362019-02-22 Keith Seitz <keiths@redhat.com>
6737
6738 PR symtab/23853
6739 * linespec.c (create_sals_line_offset): Search for the default
6740 symtab's filename instead of its fullname.
6741
7557a514
AH
67422019-02-21 Alan Hayward <alan.hayward@arm.com>
6743
6744 * NEWS: Update style defaults.
6745
ee2bcb0c
AH
67462019-02-21 Alan Hayward <alan.hayward@arm.com>
6747
6748 * main.c (captured_main_1): Disable styling in batch mode.
6749
0c95f9ed
TT
67502019-02-20 Tom Tromey <tom@tromey.com>
6751
6752 * symtab.c (symtab_symbol_info): Fix typos.
6753
c763b894
TT
67542019-02-20 Tom Tromey <tromey@adacore.com>
6755
6756 * findcmd.c (_initialize_mem_search): Use upper case for
6757 metasyntactic variables.
6758
0ef8a082
AH
67592019-02-20 Alan Hayward <alan.hayward@arm.com>
6760
6761 * aarch64-tdep.c (aarch64_add_reggroups): New function.
6762 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6763
6caa91b6
SM
67642019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
6765
6766 * top.h (source_file_name): Change to std::string.
6767 * top.c (source_file_name): Likewise.
6768 (command_line_input): Adjust.
6769 * cli/cli-script.c (script_from_file): Adjust.
6770
98814c6c
TT
67712019-02-19 Tom Tromey <tromey@adacore.com>
6772
6773 * ravenscar-thread.c
6774 (ravenscar_thread_target::update_thread_list): Don't call
6775 ada_build_task_list.
6776 * ada-lang.h (ada_build_task_list): Don't declare.
6777 * ada-tasks.c (struct ada_tasks_inferior_data)
6778 <task_list_valid_p>: Now bool.
6779 (read_known_tasks, ada_task_list_changed)
6780 (ada_tasks_invalidate_inferior_data): Update.
6781 (read_known_tasks_array): Return bool.
6782 (read_known_tasks_list): Likewise.
6783 (read_known_tasks): Return void.
6784 (ada_build_task_list): Now static.
6785
70cd633e
AB
67862019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
6787
6788 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6789 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6790
040b3e95
PW
67912019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6792
6793 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6794 variant for ada_tasks_pspace_data_handle and
6795 ada_tasks_inferior_data_handle.
6796 (ada_tasks_pspace_data_cleanup): New function.
6797 (ada_tasks_inferior_data_cleanup): New function.
6798
9409233b
TT
67992019-02-17 Tom Tromey <tom@tromey.com>
6800
6801 * macrotab.h (macro_source_fullname): Return a std::string.
6802 * macrotab.c (macro_include, check_for_redefinition)
6803 (macro_undef, macro_lookup_definition, foreach_macro)
6804 (foreach_macro_in_scope): Update.
6805 (macro_source_fullname): Return a std::string.
6806 * macrocmd.c (show_pp_source_pos): Update.
6807
6506371f
TT
68082019-02-17 Tom Tromey <tom@tromey.com>
6809
6810 * macrocmd.c (show_pp_source_pos): Style the file names.
6811
0c820d67
TT
68122019-02-17 Tom Tromey <tom@tromey.com>
6813
6814 PR tui/24197:
6815 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6816
a0087920
TT
68172019-02-17 Tom Tromey <tom@tromey.com>
6818
6819 * ada-lang.c (user_select_syms): Use filtered printing.
6820 * utils.c (wrap_style): New global.
6821 (desired_style): Remove.
6822 (emit_style_escape): Add stream parameter.
6823 (set_output_style, reset_terminal_style, prompt_for_continue):
6824 Update.
6825 (flush_wrap_buffer): Only flush gdb_stdout.
6826 (wrap_here): Set wrap_style.
6827 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
6828 treat escape sequences as a character. Change when wrap buffer is
6829 flushed.
6830 (fputs_styled): Do not set the output style when the default is
6831 requested.
6832 * ui-style.h (struct ui_file_style) <is_default>: New method.
6833 * source.c (print_source_lines_base): Emit escape sequences in one
6834 piece.
6835
75ba10dc
JB
68362019-02-17 Joel Brobecker <brobecker@adacore.com>
6837
6838 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6839 integers and enumeration types.
6840
a2cd4f14
JB
68412019-02-17 Joel Brobecker <brobecker@adacore.com>
6842
6843 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6844 instead of lookup_symbol_in_language
6845 (do_exact_match): New function.
6846 (ada_get_symbol_name_matcher): Return do_exact_match when
6847 doing a verbatim match.
6848
485b851b
TT
68492019-02-15 Tom Tromey <tromey@adacore.com>
6850
6851 * ravenscar-thread.c (ravenscar_thread_target::resume)
6852 (ravenscar_thread_target::wait): Special case wildcard requests.
6853
0b790b1e
TT
68542019-02-15 Tom Tromey <tromey@adacore.com>
6855
6856 * ravenscar-thread.c (base_ptid): Remove.
6857 (struct ravenscar_thread_target) <close>: New method.
6858 <m_base_ptid>: New member.
6859 <update_inferior_ptid, active_task, task_is_currently_active,
6860 runtime_initialized>: Declare methods.
6861 <ravenscar_thread_target>: Add constructor.
6862 (ravenscar_thread_target::task_is_currently_active)
6863 (ravenscar_thread_target::update_inferior_ptid)
6864 (ravenscar_runtime_initialized): Rename. Now methods.
6865 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6866 (ravenscar_thread_target::update_thread_list): Update.
6867 (ravenscar_thread_target::active_task): Now method.
6868 (ravenscar_thread_target::store_registers)
6869 (ravenscar_thread_target::prepare_to_store)
6870 (ravenscar_thread_target::prepare_to_store)
6871 (ravenscar_thread_target::mourn_inferior): Update.
6872 (ravenscar_inferior_created): Use "new" to create target.
6873 (ravenscar_thread_target::get_ada_task_ptid): Update.
6874 (_initialize_ravenscar): Don't initialize base_ptid.
6875 (ravenscar_ops): Remove global.
6876
dea57a62
TT
68772019-02-15 Tom Tromey <tromey@adacore.com>
6878
6879 * target.h (push_target): Declare new overload.
6880 * target.c (push_target): New overload, taking an rvalue reference.
6881 * remote.c (remote_target::open_1): Use push_target overload.
6882 * corelow.c (core_target_open): Use push_target overload.
6883
989f3c58
TT
68842019-02-15 Tom Tromey <tromey@adacore.com>
6885
6886 * ravenscar-thread.c (is_ravenscar_task)
6887 (ravenscar_task_is_currently_active): Return bool.
6888 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6889 (_initialize_ravenscar): Remove "(void)".
6890 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6891 Return bool.
6892
6cbcc006
TT
68932019-02-15 Tom Tromey <tromey@adacore.com>
6894
6895 * ravenscar-thread.c (ravenscar_runtime_initializer)
6896 (has_ravenscar_runtime, get_running_thread_id)
6897 (ravenscar_thread_target::resume): Fix indentation.
6898
7657f14d
TT
68992019-02-15 Tom Tromey <tromey@adacore.com>
6900
6901 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6902 from ravenscar_arch_ops.
6903 (sparc_ravenscar_ops::fetch_registers)
6904 (sparc_ravenscar_ops::store_registers): Now methods.
6905 (sparc_ravenscar_prepare_to_store): Remove.
6906 (sparc_ravenscar_ops): Redefine.
6907 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6908 methods and destructor. Remove members.
6909 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6910 (ravenscar_thread_target::store_registers)
6911 (ravenscar_thread_target::prepare_to_store): Update.
6912 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6913 Remove.
6914 (struct ppc_ravenscar_powerpc_ops): Derive from
6915 ravenscar_arch_ops.
6916 (ppc_ravenscar_powerpc_ops::fetch_registers)
6917 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6918 (ppc_ravenscar_powerpc_ops): Redefine.
6919 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6920 (ppc_ravenscar_e500_ops::fetch_registers)
6921 (ppc_ravenscar_e500_ops::store_registers): Now methods.
6922 (ppc_ravenscar_e500_ops): Redefine.
6923 * aarch64-ravenscar-thread.c
6924 (aarch64_ravenscar_generic_prepare_to_store): Remove.
6925 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6926 (aarch64_ravenscar_fetch_registers)
6927 (aarch64_ravenscar_store_registers): Now methods.
6928 (aarch64_ravenscar_ops): Redefine.
6929
5b6ea500
TT
69302019-02-15 Tom Tromey <tromey@adacore.com>
6931
6932 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6933 (ravenscar_thread_target::stopped_by_hw_breakpoint)
6934 (ravenscar_thread_target::stopped_by_watchpoint)
6935 (ravenscar_thread_target::stopped_data_address)
6936 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6937
e397fd39
TT
69382019-02-15 Tom Tromey <tromey@adacore.com>
6939
6940 * ravenscar-thread.c: Fix some typos.
6941
cc12f4a8
TT
69422019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6943 Tom Tromey <tromey@adacore.com>
6944
6945 * ada-lang.c (ada_exception_sal): Change addr_string to a
6946 std::string.
6947 (create_ada_exception_catchpoint): Update.
6948
5f486660
TT
69492019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6950 Tom Tromey <tromey@adacore.com>
6951
6952 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6953 (bp_location_ops): Remove.
6954 (base_breakpoint_allocate_location): Update.
6955 (free_bp_location): Update.
6956 * ada-lang.c (class ada_catchpoint_location)
6957 <ada_catchpoint_location>: Remove ops parameter.
6958 (ada_catchpoint_location_dtor): Remove.
6959 (ada_catchpoint_location_ops): Remove.
6960 (allocate_location_exception): Update.
6961 * breakpoint.h (struct bp_location_ops): Remove.
6962 (class bp_location) <bp_location>: Remove bp_location_ops
6963 parameter.
6964 <~bp_location>: Add destructor.
6965 <ops>: Remove.
6966
b671c7fb
TS
69672019-02-14 Thomas Schwinge <thomas@codesourcery.com>
6968 Pedro Alves <palves@redhat.com>
6969
6970 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6971 'PATH_MAX'.
6972
8071c5ce
DM
69732019-02-14 David Michael <fedora.dm0@gmail.com>
6974 Samuel Thibault <samuel.thibault@gnu.org>
6975 Thomas Schwinge <thomas@codesourcery.com>
6976
6977 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6978 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6979
b1041ae0
TS
69802019-02-14 Thomas Schwinge <thomas@codesourcery.com>
6981
924514e1
TS
6982 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6983 (check_empty): Use "const char *".
6984
c29ee8d4
TS
6985 * gnu-nat.c (gnu_nat_target::detach): Instead of
6986 'detach_inferior (pid)' call
6987 'detach_inferior (find_inferior_pid (pid))'.
6988
6c6ef69f
TS
6989 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6990 'nat/fork-inferior.o'.
6991 * gnu-nat.c: #include "nat/fork-inferior.h".
6992
2d0a338c
TS
6993 * gnu-nat.c (gnu_nat_target::detach): Instead of
6994 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6995 * gnu-nat.h: #include "inf-child.h".
6996 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6997 'i386_gnu_nat_target::fetch_registers'.
6998 (gnu_store_registers): Rename/move to
6999 'i386_gnu_nat_target::store_registers'.
7000
cabb5f06
TS
7001 * config/i386/nm-i386gnu.h: Don't "#include" any files.
7002 * gnu-nat.h (mach_thread_info): New function.
7003 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7004
b1041ae0
TS
7005 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7006
2988d01e
KF
70072019-02-14 Frederic Konrad <konrad@adacore.com>
7008
7009 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7010
c559d709
JB
70112019-02-14 Joel Brobecker <brobecker@adacore.com>
7012
7013 * windows-nat.c (windows_add_thread): Add new parameter
7014 "main_thread_p" with default value set to false. Update
7015 function documentation as well as all callers.
7016 (windows_delete_thread): Likewise.
7017 (fake_create_process): Update call to windows_add_thread.
7018 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7019 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7020 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7021 call to windows_delete_thread.
7022
007024cc
SM
70232019-02-13 Simon Marchi <simon.marchi@ericsson.com>
7024
7025 * MAINTAINERS: Add Andrew Burgess as global maintainer.
7026
f62318e9
JB
70272019-02-12 John Baldwin <jhb@FreeBSD.org>
7028
7029 * symfile.c (find_separate_debug_file): Use canonical path of
7030 sysroot with child_path instead of gdb_sysroot if it is valid.
7031
cd4b7848
JB
70322019-02-12 John Baldwin <jhb@FreeBSD.org>
7033
7034 * symfile.c (find_separate_debug_file): Use child_path to
7035 determine if an object file is under a sysroot.
7036
efac4bfe
JB
70372019-02-12 John Baldwin <jhb@FreeBSD.org>
7038
7039 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7040 unittests/child-path-selftests.c.
7041 * common/pathstuff.c (child_path): New function.
7042 * common/pathstuff.h (child_path): New prototype.
7043 * unittests/child-path-selftests.c: New file.
7044
402d2bfe
JB
70452019-02-12 John Baldwin <jhb@FreeBSD.org>
7046
7047 * symfile.c (find_separate_debug_file): Look for separate debug
7048 files in debug directories under the sysroot.
7049
1ed9f74e
PW
70502019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7051
7052 * symtab.h (struct minimal_symbol data_p): New const method.
7053 (struct minimal_symbol text_p): Likewise.
7054 * symtab.c (output_source_filename): Use file name style
7055 to print file name.
7056 (print_symbol_info): Likewise.
7057 (print_msymbol_info): Use address style to print addresses.
7058 Use function name style to print executable text symbols.
7059 (expand_symtab_containing_pc): Use data_p.
7060 (find_pc_sect_compunit_symtab): Likewise.
7061
2636d81d
PW
70622019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7063
7064 * breakpoint.c (describe_other_breakpoints): Use address style
7065 to print addresses.
7066 (say_where): Likewise.
7067
ac8c53cc
PW
70682019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7069
7070 * ada-typeprint.c (print_func_type): Print function name
7071 style to print function name.
7072 * c-typeprint.c (c_print_type_1): Likewise.
7073
ea638c43
AH
70742019-02-11 Alan Hayward <alan.hayward@arm.com>
7075
7076 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7077 for execve.
7078
ab759ca8
PW
70792019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7080
7081 * c-exp.y (direct_abs_decl): Use emplace_back to record the
7082 type_stack.
7083
aff29d1c
JB
70842019-02-10 Joel Brobecker <brobecker@adacore.com>
7085
7086 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7087 TYPE_CODE_REF types.
7088
617126bc
JW
70892019-02-08 Jim Wilson <jimw@sifive.com>
7090
7091 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7092 (riscv_linux_fregset): New.
7093 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7094
46e3ed7f
TT
70952019-02-07 Tom Tromey <tom@tromey.com>
7096
7097 * thread.c (thread_cancel_execution_command): Update.
7098 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7099 methods.
7100 (struct thread_fsm_ops): Remove.
7101 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7102 (thread_fsm_should_stop, thread_fsm_return_value)
7103 (thread_fsm_set_finished, thread_fsm_finished_p)
7104 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7105 Don't declare.
7106 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7107 * infrun.c (clear_proceed_status_thread)
7108 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7109 (print_stop_event): Update.
7110 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7111 Add constructor.
7112 (step_command_fsm_ops): Remove.
7113 (new_step_command_fsm): Remove.
7114 (step_1): Update.
7115 (step_command_fsm::should_stop): Rename from
7116 step_command_fsm_should_stop.
7117 (step_command_fsm::clean_up): Rename from
7118 step_command_fsm_clean_up.
7119 (step_command_fsm::do_async_reply_reason): Rename from
7120 step_command_fsm_async_reply_reason.
7121 (struct until_next_fsm): Inherit from thread_fsm. Add
7122 constructor.
7123 (until_next_fsm_ops): Remove.
7124 (new_until_next_fsm): Remove.
7125 (until_next_fsm::should_stop): Rename from
7126 until_next_fsm_should_stop.
7127 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7128 (until_next_fsm::do_async_reply_reason): Rename from
7129 until_next_fsm_async_reply_reason.
7130 (struct finish_command_fsm): Inherit from thread_fsm. Add
7131 constructor. Change type of breakpoint.
7132 (finish_command_fsm_ops): Remove.
7133 (new_finish_command_fsm): Remove.
7134 (finish_command_fsm::should_stop): Rename from
7135 finish_command_fsm_should_stop.
7136 (finish_command_fsm::clean_up): Rename from
7137 finish_command_fsm_clean_up.
7138 (finish_command_fsm::return_value): Rename from
7139 finish_command_fsm_return_value.
7140 (finish_command_fsm::do_async_reply_reason): Rename from
7141 finish_command_fsm_async_reply_reason.
7142 (finish_command): Update.
7143 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7144 Add constructor.
7145 (call_thread_fsm_ops): Remove.
7146 (call_thread_fsm::call_thread_fsm): Rename from
7147 new_call_thread_fsm.
7148 (call_thread_fsm::should_stop): Rename from
7149 call_thread_fsm_should_stop.
7150 (call_thread_fsm::should_notify_stop): Rename from
7151 call_thread_fsm_should_notify_stop.
7152 (run_inferior_call, call_function_by_hand_dummy): Update.
7153 * cli/cli-interp.c (should_print_stop_to_console): Update.
7154 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7155 Add constructor. Change type of location_breakpoint,
7156 caller_breakpoint.
7157 (until_break_fsm_ops): Remove.
7158 (new_until_break_fsm): Remove.
7159 (until_break_fsm::should_stop): Rename from
7160 until_break_fsm_should_stop.
7161 (until_break_fsm::clean_up): Rename from
7162 until_break_fsm_clean_up.
7163 (until_break_fsm::do_async_reply_reason): Rename from
7164 until_break_fsm_async_reply_reason.
7165 (until_break_command): Update.
7166 * thread-fsm.c: Remove.
7167 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7168
1a5c2598
TT
71692019-02-07 Tom Tromey <tom@tromey.com>
7170
7171 * yy-remap.h: Add include guard.
7172 * xtensa-tdep.h: Add include guard.
7173 * xcoffread.h: Rename include guard.
7174 * varobj-iter.h: Add include guard.
7175 * tui/tui.h: Rename include guard.
7176 * tui/tui-winsource.h: Rename include guard.
7177 * tui/tui-wingeneral.h: Rename include guard.
7178 * tui/tui-windata.h: Rename include guard.
7179 * tui/tui-win.h: Rename include guard.
7180 * tui/tui-stack.h: Rename include guard.
7181 * tui/tui-source.h: Rename include guard.
7182 * tui/tui-regs.h: Rename include guard.
7183 * tui/tui-out.h: Rename include guard.
7184 * tui/tui-layout.h: Rename include guard.
7185 * tui/tui-io.h: Rename include guard.
7186 * tui/tui-hooks.h: Rename include guard.
7187 * tui/tui-file.h: Rename include guard.
7188 * tui/tui-disasm.h: Rename include guard.
7189 * tui/tui-data.h: Rename include guard.
7190 * tui/tui-command.h: Rename include guard.
7191 * tic6x-tdep.h: Add include guard.
7192 * target/waitstatus.h: Rename include guard.
7193 * target/wait.h: Rename include guard.
7194 * target/target.h: Rename include guard.
7195 * target/resume.h: Rename include guard.
7196 * target-float.h: Rename include guard.
7197 * stabsread.h: Add include guard.
7198 * rs6000-tdep.h: Add include guard.
7199 * riscv-fbsd-tdep.h: Add include guard.
7200 * regformats/regdef.h: Rename include guard.
7201 * record.h: Rename include guard.
7202 * python/python.h: Rename include guard.
7203 * python/python-internal.h: Rename include guard.
7204 * python/py-stopevent.h: Rename include guard.
7205 * python/py-ref.h: Rename include guard.
7206 * python/py-record.h: Rename include guard.
7207 * python/py-record-full.h: Rename include guard.
7208 * python/py-record-btrace.h: Rename include guard.
7209 * python/py-instruction.h: Rename include guard.
7210 * python/py-events.h: Rename include guard.
7211 * python/py-event.h: Rename include guard.
7212 * procfs.h: Add include guard.
7213 * proc-utils.h: Add include guard.
7214 * p-lang.h: Add include guard.
7215 * or1k-tdep.h: Rename include guard.
7216 * observable.h: Rename include guard.
7217 * nto-tdep.h: Rename include guard.
7218 * nat/x86-linux.h: Rename include guard.
7219 * nat/x86-linux-dregs.h: Rename include guard.
7220 * nat/x86-gcc-cpuid.h: Add include guard.
7221 * nat/x86-dregs.h: Rename include guard.
7222 * nat/x86-cpuid.h: Rename include guard.
7223 * nat/ppc-linux.h: Rename include guard.
7224 * nat/mips-linux-watch.h: Rename include guard.
7225 * nat/linux-waitpid.h: Rename include guard.
7226 * nat/linux-ptrace.h: Rename include guard.
7227 * nat/linux-procfs.h: Rename include guard.
7228 * nat/linux-osdata.h: Rename include guard.
7229 * nat/linux-nat.h: Rename include guard.
7230 * nat/linux-namespaces.h: Rename include guard.
7231 * nat/linux-btrace.h: Rename include guard.
7232 * nat/glibc_thread_db.h: Rename include guard.
7233 * nat/gdb_thread_db.h: Rename include guard.
7234 * nat/gdb_ptrace.h: Rename include guard.
7235 * nat/fork-inferior.h: Rename include guard.
7236 * nat/amd64-linux-siginfo.h: Rename include guard.
7237 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7238 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7239 * nat/aarch64-linux.h: Rename include guard.
7240 * nat/aarch64-linux-hw-point.h: Rename include guard.
7241 * mn10300-tdep.h: Add include guard.
7242 * mips-linux-tdep.h: Add include guard.
7243 * mi/mi-parse.h: Rename include guard.
7244 * mi/mi-out.h: Rename include guard.
7245 * mi/mi-main.h: Rename include guard.
7246 * mi/mi-interp.h: Rename include guard.
7247 * mi/mi-getopt.h: Rename include guard.
7248 * mi/mi-console.h: Rename include guard.
7249 * mi/mi-common.h: Rename include guard.
7250 * mi/mi-cmds.h: Rename include guard.
7251 * mi/mi-cmd-break.h: Rename include guard.
7252 * m2-lang.h: Add include guard.
7253 * location.h: Rename include guard.
7254 * linux-record.h: Rename include guard.
7255 * linux-nat.h: Add include guard.
7256 * linux-fork.h: Add include guard.
7257 * i386-darwin-tdep.h: Rename include guard.
7258 * hppa-linux-offsets.h: Add include guard.
7259 * guile/guile.h: Rename include guard.
7260 * guile/guile-internal.h: Rename include guard.
7261 * gnu-nat.h: Rename include guard.
7262 * gdb-stabs.h: Rename include guard.
7263 * frv-tdep.h: Add include guard.
7264 * f-lang.h: Add include guard.
7265 * event-loop.h: Add include guard.
7266 * darwin-nat.h: Rename include guard.
7267 * cp-abi.h: Rename include guard.
7268 * config/sparc/nm-sol2.h: Rename include guard.
7269 * config/nm-nto.h: Rename include guard.
7270 * config/nm-linux.h: Add include guard.
7271 * config/i386/nm-i386gnu.h: Rename include guard.
7272 * config/djgpp/nl_types.h: Rename include guard.
7273 * config/djgpp/langinfo.h: Rename include guard.
7274 * compile/gcc-cp-plugin.h: Add include guard.
7275 * compile/gcc-c-plugin.h: Add include guard.
7276 * compile/compile.h: Rename include guard.
7277 * compile/compile-object-run.h: Rename include guard.
7278 * compile/compile-object-load.h: Rename include guard.
7279 * compile/compile-internal.h: Rename include guard.
7280 * compile/compile-cplus.h: Rename include guard.
7281 * compile/compile-c.h: Rename include guard.
7282 * common/xml-utils.h: Rename include guard.
7283 * common/x86-xstate.h: Rename include guard.
7284 * common/version.h: Rename include guard.
7285 * common/vec.h: Rename include guard.
7286 * common/tdesc.h: Rename include guard.
7287 * common/selftest.h: Rename include guard.
7288 * common/scoped_restore.h: Rename include guard.
7289 * common/scoped_mmap.h: Rename include guard.
7290 * common/scoped_fd.h: Rename include guard.
7291 * common/safe-iterator.h: Rename include guard.
7292 * common/run-time-clock.h: Rename include guard.
7293 * common/refcounted-object.h: Rename include guard.
7294 * common/queue.h: Rename include guard.
7295 * common/ptid.h: Rename include guard.
7296 * common/print-utils.h: Rename include guard.
7297 * common/preprocessor.h: Rename include guard.
7298 * common/pathstuff.h: Rename include guard.
7299 * common/observable.h: Rename include guard.
7300 * common/netstuff.h: Rename include guard.
7301 * common/job-control.h: Rename include guard.
7302 * common/host-defs.h: Rename include guard.
7303 * common/gdb_wait.h: Rename include guard.
7304 * common/gdb_vecs.h: Rename include guard.
7305 * common/gdb_unlinker.h: Rename include guard.
7306 * common/gdb_unique_ptr.h: Rename include guard.
7307 * common/gdb_tilde_expand.h: Rename include guard.
7308 * common/gdb_sys_time.h: Rename include guard.
7309 * common/gdb_string_view.h: Rename include guard.
7310 * common/gdb_splay_tree.h: Rename include guard.
7311 * common/gdb_setjmp.h: Rename include guard.
7312 * common/gdb_ref_ptr.h: Rename include guard.
7313 * common/gdb_optional.h: Rename include guard.
7314 * common/gdb_locale.h: Rename include guard.
7315 * common/gdb_assert.h: Rename include guard.
7316 * common/filtered-iterator.h: Rename include guard.
7317 * common/filestuff.h: Rename include guard.
7318 * common/fileio.h: Rename include guard.
7319 * common/environ.h: Rename include guard.
7320 * common/common-utils.h: Rename include guard.
7321 * common/common-types.h: Rename include guard.
7322 * common/common-regcache.h: Rename include guard.
7323 * common/common-inferior.h: Rename include guard.
7324 * common/common-gdbthread.h: Rename include guard.
7325 * common/common-exceptions.h: Rename include guard.
7326 * common/common-defs.h: Rename include guard.
7327 * common/common-debug.h: Rename include guard.
7328 * common/cleanups.h: Rename include guard.
7329 * common/buffer.h: Rename include guard.
7330 * common/btrace-common.h: Rename include guard.
7331 * common/break-common.h: Rename include guard.
7332 * cli/cli-utils.h: Rename include guard.
7333 * cli/cli-style.h: Rename include guard.
7334 * cli/cli-setshow.h: Rename include guard.
7335 * cli/cli-script.h: Rename include guard.
7336 * cli/cli-interp.h: Rename include guard.
7337 * cli/cli-decode.h: Rename include guard.
7338 * cli/cli-cmds.h: Rename include guard.
7339 * charset-list.h: Add include guard.
7340 * buildsym-legacy.h: Rename include guard.
7341 * bfin-tdep.h: Add include guard.
7342 * ax.h: Rename include guard.
7343 * arm-linux-tdep.h: Add include guard.
7344 * arm-fbsd-tdep.h: Add include guard.
7345 * arch/xtensa.h: Rename include guard.
7346 * arch/tic6x.h: Add include guard.
7347 * arch/i386.h: Add include guard.
7348 * arch/arm.h: Rename include guard.
7349 * arch/arm-linux.h: Rename include guard.
7350 * arch/arm-get-next-pcs.h: Rename include guard.
7351 * arch/amd64.h: Add include guard.
7352 * arch/aarch64-insn.h: Rename include guard.
7353 * arch-utils.h: Rename include guard.
7354 * annotate.h: Add include guard.
7355 * amd64-darwin-tdep.h: Rename include guard.
7356 * aarch64-linux-tdep.h: Add include guard.
7357 * aarch64-fbsd-tdep.h: Add include guard.
7358 * aarch32-linux-nat.h: Add include guard.
7359
ab9268d2
PW
73602019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7361
7362 * macrotab.c (macro_define_internal): New function that
7363 factorizes macro_define_object_internal and macro_define_function
7364 code.
7365 (macro_define_object_internal): Use macro_define_internal.
7366 (macro_define_function): Likewise.
7367
bb0da2b4
PW
73682019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7369
7370 * macrocmd.c (extract_identifier): Return
7371 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7372 callers.
7373
424eb552
JB
73742019-02-06 John Baldwin <jhb@FreeBSD.org>
7375
7376 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7377
1688cb29
TT
73782019-02-05 Tom Tromey <tom@tromey.com>
7379
7380 * target.c (target_stack::unpush): Move assertion earlier.
7381
b5eba2d8
TT
73822019-01-30 Tom Tromey <tom@tromey.com>
7383
7384 PR python/23615:
7385 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7386 (gdbpy_parse_and_eval): Likewise.
7387 * python/python-internal.h (gdbpy_allow_threads): New class.
7388
7054e2ff
JB
73892019-01-28 John Baldwin <jhb@FreeBSD.org>
7390
7391 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7392 (aarch64_fbsd_fpregmap): Move earlier.
7393 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7394 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7395 instead of individual calls to trad_frame_set_reg_addr.
7396 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7397 earlier.
7398 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7399 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7400 instead of individual calls to trad_frame_set_reg_addr.
7401
36c25ffa
AH
74022019-01-28 Alan Hayward <alan.hayward@arm.com>
7403
7404 * CONTRIBUTE: Replace contribution list with wiki link.
7405
a0707f3c
TT
74062019-01-25 Tom Tromey <tom@tromey.com>
7407
7408 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7409
0747795c
TT
74102019-01-25 Tom Tromey <tom@tromey.com>
7411
7412 * xtensa-linux-nat.c: Fix common/ includes.
7413 * xml-support.h: Fix common/ includes.
7414 * xml-support.c: Fix common/ includes.
7415 * x86-linux-nat.c: Fix common/ includes.
7416 * windows-nat.c: Fix common/ includes.
7417 * varobj.h: Fix common/ includes.
7418 * varobj.c: Fix common/ includes.
7419 * value.c: Fix common/ includes.
7420 * valops.c: Fix common/ includes.
7421 * utils.c: Fix common/ includes.
7422 * unittests/xml-utils-selftests.c: Fix common/ includes.
7423 * unittests/utils-selftests.c: Fix common/ includes.
7424 * unittests/unpack-selftests.c: Fix common/ includes.
7425 * unittests/tracepoint-selftests.c: Fix common/ includes.
7426 * unittests/style-selftests.c: Fix common/ includes.
7427 * unittests/string_view-selftests.c: Fix common/ includes.
7428 * unittests/scoped_restore-selftests.c: Fix common/ includes.
7429 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7430 * unittests/scoped_fd-selftests.c: Fix common/ includes.
7431 * unittests/rsp-low-selftests.c: Fix common/ includes.
7432 * unittests/parse-connection-spec-selftests.c: Fix common/
7433 includes.
7434 * unittests/optional-selftests.c: Fix common/ includes.
7435 * unittests/offset-type-selftests.c: Fix common/ includes.
7436 * unittests/observable-selftests.c: Fix common/ includes.
7437 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7438 * unittests/memrange-selftests.c: Fix common/ includes.
7439 * unittests/memory-map-selftests.c: Fix common/ includes.
7440 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7441 * unittests/function-view-selftests.c: Fix common/ includes.
7442 * unittests/environ-selftests.c: Fix common/ includes.
7443 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7444 * unittests/common-utils-selftests.c: Fix common/ includes.
7445 * unittests/cli-utils-selftests.c: Fix common/ includes.
7446 * unittests/array-view-selftests.c: Fix common/ includes.
7447 * ui-file.c: Fix common/ includes.
7448 * tui/tui-io.c: Fix common/ includes.
7449 * tracepoint.h: Fix common/ includes.
7450 * tracepoint.c: Fix common/ includes.
7451 * tracefile-tfile.c: Fix common/ includes.
7452 * top.h: Fix common/ includes.
7453 * top.c: Fix common/ includes.
7454 * thread.c: Fix common/ includes.
7455 * target/waitstatus.h: Fix common/ includes.
7456 * target/waitstatus.c: Fix common/ includes.
7457 * target.h: Fix common/ includes.
7458 * target.c: Fix common/ includes.
7459 * target-memory.c: Fix common/ includes.
7460 * target-descriptions.c: Fix common/ includes.
7461 * symtab.h: Fix common/ includes.
7462 * symfile.c: Fix common/ includes.
7463 * stap-probe.c: Fix common/ includes.
7464 * spu-linux-nat.c: Fix common/ includes.
7465 * sparc-nat.c: Fix common/ includes.
7466 * source.c: Fix common/ includes.
7467 * solib.c: Fix common/ includes.
7468 * solib-target.c: Fix common/ includes.
7469 * ser-unix.c: Fix common/ includes.
7470 * ser-tcp.c: Fix common/ includes.
7471 * ser-pipe.c: Fix common/ includes.
7472 * ser-base.c: Fix common/ includes.
7473 * selftest-arch.c: Fix common/ includes.
7474 * s12z-tdep.c: Fix common/ includes.
7475 * rust-exp.y: Fix common/ includes.
7476 * rs6000-aix-tdep.c: Fix common/ includes.
7477 * riscv-tdep.c: Fix common/ includes.
7478 * remote.c: Fix common/ includes.
7479 * remote-notif.h: Fix common/ includes.
7480 * remote-fileio.h: Fix common/ includes.
7481 * remote-fileio.c: Fix common/ includes.
7482 * regcache.h: Fix common/ includes.
7483 * regcache.c: Fix common/ includes.
7484 * record-btrace.c: Fix common/ includes.
7485 * python/python.c: Fix common/ includes.
7486 * python/py-type.c: Fix common/ includes.
7487 * python/py-inferior.c: Fix common/ includes.
7488 * progspace.h: Fix common/ includes.
7489 * producer.c: Fix common/ includes.
7490 * procfs.c: Fix common/ includes.
7491 * proc-api.c: Fix common/ includes.
7492 * printcmd.c: Fix common/ includes.
7493 * ppc-linux-nat.c: Fix common/ includes.
7494 * parser-defs.h: Fix common/ includes.
7495 * osdata.c: Fix common/ includes.
7496 * obsd-nat.c: Fix common/ includes.
7497 * nat/x86-linux.c: Fix common/ includes.
7498 * nat/x86-linux-dregs.c: Fix common/ includes.
7499 * nat/x86-dregs.h: Fix common/ includes.
7500 * nat/x86-dregs.c: Fix common/ includes.
7501 * nat/ppc-linux.c: Fix common/ includes.
7502 * nat/mips-linux-watch.h: Fix common/ includes.
7503 * nat/mips-linux-watch.c: Fix common/ includes.
7504 * nat/linux-waitpid.c: Fix common/ includes.
7505 * nat/linux-ptrace.h: Fix common/ includes.
7506 * nat/linux-ptrace.c: Fix common/ includes.
7507 * nat/linux-procfs.c: Fix common/ includes.
7508 * nat/linux-personality.c: Fix common/ includes.
7509 * nat/linux-osdata.c: Fix common/ includes.
7510 * nat/linux-namespaces.c: Fix common/ includes.
7511 * nat/linux-btrace.h: Fix common/ includes.
7512 * nat/linux-btrace.c: Fix common/ includes.
7513 * nat/fork-inferior.c: Fix common/ includes.
7514 * nat/amd64-linux-siginfo.c: Fix common/ includes.
7515 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7516 * nat/aarch64-linux.c: Fix common/ includes.
7517 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7518 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7519 * namespace.h: Fix common/ includes.
7520 * mips-linux-tdep.c: Fix common/ includes.
7521 * minsyms.c: Fix common/ includes.
7522 * mi/mi-parse.h: Fix common/ includes.
7523 * mi/mi-main.c: Fix common/ includes.
7524 * mi/mi-cmd-env.c: Fix common/ includes.
7525 * memrange.h: Fix common/ includes.
7526 * memattr.c: Fix common/ includes.
7527 * maint.h: Fix common/ includes.
7528 * maint.c: Fix common/ includes.
7529 * main.c: Fix common/ includes.
7530 * machoread.c: Fix common/ includes.
7531 * location.c: Fix common/ includes.
7532 * linux-thread-db.c: Fix common/ includes.
7533 * linux-nat.c: Fix common/ includes.
7534 * linux-fork.c: Fix common/ includes.
7535 * inline-frame.c: Fix common/ includes.
7536 * infrun.c: Fix common/ includes.
7537 * inflow.c: Fix common/ includes.
7538 * inferior.h: Fix common/ includes.
7539 * inferior.c: Fix common/ includes.
7540 * infcmd.c: Fix common/ includes.
7541 * inf-ptrace.c: Fix common/ includes.
7542 * inf-child.c: Fix common/ includes.
7543 * ia64-linux-nat.c: Fix common/ includes.
7544 * i387-tdep.c: Fix common/ includes.
7545 * i386-tdep.c: Fix common/ includes.
7546 * i386-linux-tdep.c: Fix common/ includes.
7547 * i386-linux-nat.c: Fix common/ includes.
7548 * i386-go32-tdep.c: Fix common/ includes.
7549 * i386-fbsd-tdep.c: Fix common/ includes.
7550 * i386-fbsd-nat.c: Fix common/ includes.
7551 * guile/scm-type.c: Fix common/ includes.
7552 * guile/guile.c: Fix common/ includes.
7553 * go32-nat.c: Fix common/ includes.
7554 * gnu-nat.c: Fix common/ includes.
7555 * gdbthread.h: Fix common/ includes.
7556 * gdbarch-selftests.c: Fix common/ includes.
7557 * gdb_usleep.c: Fix common/ includes.
7558 * gdb_select.h: Fix common/ includes.
7559 * gdb_bfd.c: Fix common/ includes.
7560 * gcore.c: Fix common/ includes.
7561 * fork-child.c: Fix common/ includes.
7562 * findvar.c: Fix common/ includes.
7563 * fbsd-nat.c: Fix common/ includes.
7564 * event-top.c: Fix common/ includes.
7565 * event-loop.c: Fix common/ includes.
7566 * dwarf2read.c: Fix common/ includes.
7567 * dwarf2loc.c: Fix common/ includes.
7568 * dwarf2-frame.c: Fix common/ includes.
7569 * dwarf-index-cache.c: Fix common/ includes.
7570 * dtrace-probe.c: Fix common/ includes.
7571 * disasm-selftests.c: Fix common/ includes.
7572 * defs.h: Fix common/ includes.
7573 * csky-tdep.c: Fix common/ includes.
7574 * cp-valprint.c: Fix common/ includes.
7575 * cp-support.h: Fix common/ includes.
7576 * cp-support.c: Fix common/ includes.
7577 * corelow.c: Fix common/ includes.
7578 * completer.h: Fix common/ includes.
7579 * completer.c: Fix common/ includes.
7580 * compile/compile.c: Fix common/ includes.
7581 * compile/compile-loc2c.c: Fix common/ includes.
7582 * compile/compile-cplus-types.c: Fix common/ includes.
7583 * compile/compile-cplus-symbols.c: Fix common/ includes.
7584 * command.h: Fix common/ includes.
7585 * cli/cli-dump.c: Fix common/ includes.
7586 * cli/cli-cmds.c: Fix common/ includes.
7587 * charset.c: Fix common/ includes.
7588 * build-id.c: Fix common/ includes.
7589 * btrace.h: Fix common/ includes.
7590 * btrace.c: Fix common/ includes.
7591 * breakpoint.h: Fix common/ includes.
7592 * breakpoint.c: Fix common/ includes.
7593 * ax.h:
7594 (enum agent_op): Fix common/ includes.
7595 * ax-general.c (struct aop_map): Fix common/ includes.
7596 * ax-gdb.c: Fix common/ includes.
7597 * auxv.c: Fix common/ includes.
7598 * auto-load.c: Fix common/ includes.
7599 * arm-tdep.c: Fix common/ includes.
7600 * arch/riscv.c: Fix common/ includes.
7601 * arch/ppc-linux-common.c: Fix common/ includes.
7602 * arch/i386.c: Fix common/ includes.
7603 * arch/arm.c: Fix common/ includes.
7604 * arch/arm-linux.c: Fix common/ includes.
7605 * arch/arm-get-next-pcs.c: Fix common/ includes.
7606 * arch/amd64.c: Fix common/ includes.
7607 * arch/aarch64.c: Fix common/ includes.
7608 * arch/aarch64-insn.c: Fix common/ includes.
7609 * arch-utils.c: Fix common/ includes.
7610 * amd64-windows-tdep.c: Fix common/ includes.
7611 * amd64-tdep.c: Fix common/ includes.
7612 * amd64-sol2-tdep.c: Fix common/ includes.
7613 * amd64-obsd-tdep.c: Fix common/ includes.
7614 * amd64-nbsd-tdep.c: Fix common/ includes.
7615 * amd64-linux-tdep.c: Fix common/ includes.
7616 * amd64-linux-nat.c: Fix common/ includes.
7617 * amd64-fbsd-tdep.c: Fix common/ includes.
7618 * amd64-fbsd-nat.c: Fix common/ includes.
7619 * amd64-dicos-tdep.c: Fix common/ includes.
7620 * amd64-darwin-tdep.c: Fix common/ includes.
7621 * agent.c: Fix common/ includes.
7622 * ada-lang.h: Fix common/ includes.
7623 * ada-lang.c: Fix common/ includes.
7624 * aarch64-tdep.c: Fix common/ includes.
7625
2f5c153e
TT
76262019-01-25 Tom Tromey <tom@tromey.com>
7627
7628 * common/create-version.sh: Use common/version.h.
7629
adc6a863
PA
76302019-01-24 Pedro Alves <palves@redhat.com>
7631
7632 * infrun.c (signal_stop, signal_print, signal_program)
7633 (signal_catch, signal_pass): Now arrays instead of pointers.
7634 (update_signals_program_target, do_target_resume)
7635 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7636 * linux-nat.c (linux_nat_target::pass_signals)
7637 (linux_nat_target::create_inferior, linux_nat_target::attach):
7638 Adjust.
7639 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7640 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7641 * procfs.c (procfs_target::pass_signals): Adjust.
7642 * record-full.c (record_full_target::resume): Adjust.
7643 * remote.c (remote_target::pass_signals)
7644 (remote_target::program_signals): Adjust.
7645 * target-debug.h (target_debug_print_signals): Now takes a
7646 gdb::array_view as parameter. Adjust.
7647 * target.h (target_ops) <pass_signals, program_signals>: Replace
7648 pointer and length parameters with gdb::array_view.
7649 (target_pass_signals, target_program_signals): Likewise.
7650 * target-delegates.c: Regenerate.
7651
3046d67a
PA
76522019-01-24 Pedro Alves <palves@redhat.com>
7653
7654 * common/forward-scope-exit.h
7655 (forward_scope_exit::forward_scope_exit): Pass arguments to
7656 m_bind_function directly, instead of creating a std::bind and
7657 copying that.
7658
353229bf
AH
76592019-01-24 Alan Hayward <alan.hayward@arm.com>
7660
7661 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7662 for static members.
7663 (pass_in_v_vfp_candidate): Likewise.
7664
311dc83a
TT
76652019-01-23 Tom Tromey <tom@tromey.com>
7666 Pedro Alves <palves@redhat.com>
7667
7668 * regcache.c (class regcache_invalidator): Remove.
7669 (regcache::raw_write): Use make_scope_exit.
7670
296bd123
TT
76712019-01-23 Tom Tromey <tom@tromey.com>
7672
7673 * ui-out.h (class ui_out_emit_type): Update comment.
7674
979a0d13
TT
76752019-01-23 Tom Tromey <tom@tromey.com>
7676
7677 * infrun.c (fetch_inferior_event): Update comment.
7678
d238133d
TT
76792019-01-23 Tom Tromey <tom@tromey.com>
7680 Pedro Alves <palves@redhat.com>
7681
7682 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7683 parameter.
7684 (fetch_inferior_event): Use SCOPE_EXIT.
7685
7686
9885e6bb
TT
76872019-01-23 Tom Tromey <tom@tromey.com>
7688 Pedro Alves <palves@redhat.com>
7689
7690 * infrun.c (disable_thread_events): Delete.
7691 (stop_all_threads): Use SCOPE_EXIT.
7692
286526c1
TT
76932019-01-23 Tom Tromey <tom@tromey.com>
7694 Pedro Alves <palves@redhat.com>
7695
7696 * symfile.c: Include forward-scope-exit.h.
7697 (clear_symtab_users_cleanup): Replace forward declaration with
7698 a FORWARD_SCOPE_EXIT.
7699 (syms_from_objfile_1): Use the forward_scope_exit and
7700 gdb::optional instead of cleanup_function.
7701 (reread_symbols): Use the forward_scope_exit instead of
7702 cleanup_function.
7703 (clear_symtab_users_cleanup): Remove function.
7704
1db93f14
TT
77052019-01-23 Tom Tromey <tom@tromey.com>
7706 Pedro Alves <palves@redhat.com>
7707
7708 * linux-nat.c: Include scope-exit.h.
7709 (cleanup_target_stop): Remove.
7710 (linux_nat_target::static_tracepoint_markers_by_strid): Use
7711 SCOPE_EXIT.
7712
2cc83d1e
TT
77132019-01-23 Tom Tromey <tom@tromey.com>
7714 Pedro Alves <palves@redhat.com>
7715
7716 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7717 (call_function_by_hand_dummy): Use SCOPE_EXIT.
7718
694c6bf5
TT
77192019-01-23 Tom Tromey <tom@tromey.com>
7720 Andrew Burgess <andrew.burgess@embecosm.com>
7721 Pedro Alves <palves@redhat.com>
7722
7723 * infrun.c (fetch_inferior_event): Use scope_exit.
7724 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7725 * top.c (execute_command): Use scope_exit.
7726 * breakpoint.c (bpstat_do_actions): Use scope_exit.
7727 * utils.c (do_bpstat_clear_actions_cleanup)
7728 (make_bpstat_clear_actions_cleanup): Remove.
7729
4c41382a
TT
77302019-01-23 Tom Tromey <tom@tromey.com>
7731 Pedro Alves <palves@redhat.com>
7732
7733 * infrun.c: Include "common/scope-exit.h"
7734 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7735 (wait_for_inferior): Use SCOPE_EXIT.
7736 (fetch_inferior_event): Use scope_exit.
7737
89f8fb50
TT
77382019-01-23 Tom Tromey <tom@tromey.com>
7739 Pedro Alves <palves@redhat.com>
7740
7741 * breakpoint.c (create_breakpoint): Remove cleanup.
7742
5419bdae
TT
77432019-01-23 Tom Tromey <tom@tromey.com>
7744 Andrew Burgess <andrew.burgess@embecosm.com>
7745 Pedro Alves <palves@redhat.com>
7746
e587ef42
PA
77472019-01-23 Pedro Alves <palves@redhat.com>
7748
7749 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7750
77f0e74c
PA
77512019-01-23 Pedro Alves <palves@redhat.com>
7752 Andrew Burgess <andrew.burgess@embecosm.com>
7753
7754 * gdbthread.h: Include "common/forward-scope-exit.h".
7755 (scoped_finish_thread_state): Redefine custom class in terms of
7756 forward_scope_exit.
7757
5b9b3e53
PA
77582019-01-23 Pedro Alves <palves@redhat.com>
7759 Andrew Burgess <andrew.burgess@embecosm.com>
7760
7761 * common/forward-scope-exit.h: New file.
7762
54b65c9b
PA
77632019-01-23 Pedro Alves <palves@redhat.com>
7764 Andrew Burgess <andrew.burgess@embecosm.com>
7765 Tom Tromey <tom@tromey.com>
7766
7767 * common/scope-exit.h: New file.
7768
cf08fb29
PA
77692019-01-23 Pedro Alves <palves@redhat.com>
7770
7771 * common/preprocessor.h (ESC): Rename to ...
7772 (ESC_PARENS): ... this.
7773 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7774 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7775
ae73e2e2
TT
77762019-01-23 Tom Tromey <tom@tromey.com>
7777
7778 * language.h (class scoped_switch_to_sym_language_if_auto):
7779 Initialize m_lang in both cases.
7780
6594e122
AH
77812019-01-23 Alan Hayward <alan.hayward@arm.com>
7782
7783 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7784 with XCNEW.
7785
a7c9855d
TT
77862019-01-22 Tom Tromey <tom@tromey.com>
7787
7788 * corelow.c: Do not include sys/file.h.
7789
93cc1d53
TT
77902019-01-22 Tom Tromey <tom@tromey.com>
7791
7792 * tui/tui-wingeneral.h: Include gdb_curses.h.
7793
38561778
TT
77942019-01-22 Tom Tromey <tom@tromey.com>
7795
7796 * source-cache.h (class source_cache) <get_source_lines,
7797 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7798
37b3ab5b
TT
77992019-01-22 Tom Tromey <tom@tromey.com>
7800
7801 * remote-fileio.h (struct remote_target): Declare.
7802
3fabc016
TT
78032019-01-22 Tom Tromey <tom@tromey.com>
7804
7805 * python/py-arch.c: Do not include py-ref.h.
7806 * python/py-bpevent.c: Do not include py-ref.h.
7807 * python/py-cmd.c: Do not include py-ref.h.
7808 * python/py-continueevent.c: Do not include py-ref.h.
7809 * python/py-event.h: Do not include py-ref.h.
7810 * python/py-evtregistry.c: Do not include py-ref.h.
7811 * python/py-finishbreakpoint.c: Do not include py-ref.h.
7812 * python/py-frame.c: Do not include py-ref.h.
7813 * python/py-framefilter.c: Do not include py-ref.h.
7814 * python/py-function.c: Do not include py-ref.h.
7815 * python/py-infevents.c: Do not include py-ref.h.
7816 * python/py-linetable.c: Do not include py-ref.h.
7817 * python/py-objfile.c: Do not include py-ref.h.
7818 * python/py-param.c: Do not include py-ref.h.
7819 * python/py-prettyprint.c: Do not include py-ref.h.
7820 * python/py-progspace.c: Do not include py-ref.h.
7821 * python/py-symbol.c: Do not include py-ref.h.
7822 * python/py-symtab.c: Do not include py-ref.h.
7823 * python/py-type.c: Do not include py-ref.h.
7824 * python/py-unwind.c: Do not include py-ref.h.
7825 * python/py-utils.c: Do not include py-ref.h.
7826 * python/py-value.c: Do not include py-ref.h.
7827 * python/py-varobj.c: Do not include py-ref.h.
7828 * python/py-xmethods.c: Do not include py-ref.h.
7829 * python/python.c: Do not include py-ref.h.
7830 * varobj.c: Do not include py-ref.h.
7831
6b4d7774
TT
78322019-01-22 Tom Tromey <tom@tromey.com>
7833
7834 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7835 keyword for bcache.
7836
7af7e9b5
TT
78372019-01-22 Tom Tromey <tom@tromey.com>
7838
7839 * compile/compile-cplus-types.c: Remove a comment by #include.
7840
951d1049
TT
78412019-01-22 Tom Tromey <tom@tromey.com>
7842
7843 * compile/gcc-c-plugin.h: Include compile-internal.h.
7844
d65d5705
TT
78452019-01-22 Tom Tromey <tom@tromey.com>
7846
7847 * stabsread.c (EXTERN): Do not define.
7848 (symnum, next_symbol_text_func, processing_gcc_compilation)
7849 (within_function, global_sym_chain, global_stabs)
7850 (previous_stab_code, this_object_header_files)
7851 (n_this_object_header_files)
7852 (n_allocated_this_object_header_files): Define.
7853 * stabsread.h (EXTERN): Never define. Use "extern".
7854
b6fb1ee5
PW
78552019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7856
7857 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7858 history_value.
7859
be6d4f74
TT
78602019-01-21 Tom Tromey <tom@tromey.com>
7861
7862 * ui-out.c: Fix includes.
7863 * tui/tui-source.c: Fix includes.
7864 * target.c: Fix includes.
7865 * remote.c: Fix includes.
7866 * regcache.c: Fix includes.
7867 * python/py-block.c: Fix includes.
7868 * printcmd.c: Fix includes.
7869 * or1k-tdep.c: Fix includes.
7870 * mi/mi-main.c: Fix includes.
7871 * m32r-tdep.c: Fix includes.
7872 * csky-tdep.c: Fix includes.
7873 * compile/compile-cplus-types.c: Fix includes.
7874 * cli/cli-interp.c: Fix includes.
7875
73021deb
AH
78762019-01-21 Alan Hayward <alan.hayward@arm.com>
7877
7878 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7879 for padding.
7880
7932255d
TT
78812019-01-16 Tom Tromey <tom@tromey.com>
7882
7883 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
7884 earlier.
7885 (struct objfile) <msymbols_range>: Move from top level.
7886 <msymbols>: New method.
7887 (class objfile_msymbols): Remove.
7888 * symtab.c (default_collect_symbol_completion_matches_break_on):
7889 Update.
7890 * symmisc.c (dump_msymbols): Update.
7891 * stabsread.c (scan_file_globals): Update.
7892 * objc-lang.c (info_selectors_command, info_classes_command)
7893 (find_methods): Update.
7894 * minsyms.c (find_solib_trampoline_target): Update.
7895 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7896 * coffread.c (coff_symfile_read): Update.
7897 * ada-lang.c (ada_lookup_simple_minsym)
7898 (ada_collect_symbol_completion_matches): Update.
7899
604b1bfb
TT
79002019-01-16 Tom Tromey <tom@tromey.com>
7901
7902 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7903 type. Remove no-argument constructor.
7904 <iterator::operator++>: Simplify.
7905 <begin>: Update.
7906 <end>: Use minimal_symbol_count.
7907
f252c6d5
TT
79082019-01-16 Tom Tromey <tom@tromey.com>
7909
7910 * objfiles.h (struct objfile) <psymtabs>: New method.
7911 (class objfile_psymtabs): Remove.
7912 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7913 typedef.
7914 <range>: New method.
7915 (require_partial_symbols): Change return type.
7916 * psymtab.c (require_partial_symbols)
7917 (psym_expand_symtabs_matching): Update.
7918 * mdebugread.c (parse_partial_symbols): Update.
7919 * dbxread.c (dbx_end_psymtab): Update.
7920
b669c953
TT
79212019-01-15 Tom Tromey <tom@tromey.com>
7922
7923 * symtab.c (lookup_objfile_from_block)
7924 (lookup_symbol_in_objfile_symtabs)
7925 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7926 (find_line_symtab, info_sources_command)
7927 (default_collect_symbol_completion_matches_break_on)
7928 (make_source_files_completion_list): Update.
7929 * symmisc.c (print_objfile_statistics, dump_objfile)
7930 (maintenance_print_symbols, maintenance_info_symtabs)
7931 (maintenance_check_symtabs, maintenance_info_line_tables):
7932 Update.
7933 * source.c (select_source_symtab)
7934 (forget_cached_source_info_for_objfile): Update.
7935 * objfiles.h (class objfile_compunits): Remove.
7936 (struct objfile) <compunits_range>: New typedef.
7937 (compunits): New method.
7938 * objfiles.c (objfile_relocate1): Update.
7939 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7940 * maint.c (count_symtabs_and_blocks): Update.
7941 * linespec.c (iterate_over_all_matching_symtabs): Update.
7942 * cp-support.c (add_symbol_overload_list_qualified): Update.
7943 * coffread.c (coff_symtab_read): Update.
7944 * ada-lang.c (add_nonlocal_symbols)
7945 (ada_collect_symbol_completion_matches)
7946 (ada_add_global_exceptions): Update.
7947
7e955d83
TT
79482019-01-15 Tom Tromey <tom@tromey.com>
7949
7950 * progspace.h (program_space) <objfiles_safe_range>: New
7951 typedef.
7952 <objfiles_safe>: New method.
7953 * objfiles.h (class all_objfiles_safe): Remove.
7954 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7955 * jit.c (jit_inferior_exit_hook): Update.
7956
2030c079
TT
79572019-01-17 Tom Tromey <tom@tromey.com>
7958
7959 * progspace.h (program_space) <objfiles_range>: New typedef.
7960 <objfiles>: New method.
7961 <objfiles_head>: Rename from objfiles.
7962 (object_files): Update.
7963 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7964 * guile/scm-pretty-print.c
7965 (ppscm_find_pretty_printer_from_objfiles): Update.
7966 * guile/scm-objfile.c (gdbscm_objfiles): Update.
7967 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7968 Update.
7969 * python/py-progspace.c (pspy_get_objfiles): Update.
7970 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7971 Update.
7972 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7973 (objfpy_lookup_objfile_by_build_id): Update.
7974 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7975 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7976 Update.
7977 * symtab.c (iterate_over_symtabs, matching_obj_sections)
7978 (expand_symtab_containing_pc, lookup_objfile_from_block)
7979 (lookup_static_symbol, basic_lookup_transparent_type)
7980 (find_pc_sect_compunit_symtab, find_symbol_at_address)
7981 (find_line_symtab, info_sources_command)
7982 (default_collect_symbol_completion_matches_break_on)
7983 (make_source_files_completion_list, find_main_name): Update.
7984 * symmisc.c (print_symbol_bcache_statistics)
7985 (print_objfile_statistics, maintenance_print_symbols)
7986 (maintenance_print_msymbols, maintenance_print_objfiles)
7987 (maintenance_info_symtabs, maintenance_check_symtabs)
7988 (maintenance_expand_symtabs, maintenance_info_line_tables):
7989 Update.
7990 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7991 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7992 (map_overlay_command, unmap_overlay_command)
7993 (simple_overlay_update, expand_symtabs_matching)
7994 (map_symbol_filenames): Update.
7995 * symfile-debug.c (set_debug_symfile): Update.
7996 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7997 Update.
7998 * source.c (select_source_symtab, forget_cached_source_info):
7999 Update.
8000 * solib.c (solib_read_symbols): Update.
8001 * solib-spu.c (append_ocl_sos): Update.
8002 * psymtab.c (maintenance_print_psymbols)
8003 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8004 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8005 * printcmd.c (info_symbol_command): Update.
8006 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8007 Update.
8008 * objfiles.h (class all_objfiles): Remove.
8009 * objfiles.c (have_partial_symbols, have_full_symbols)
8010 (have_minimal_symbols, qsort_cmp, update_section_map)
8011 (shared_objfile_contains_address_p)
8012 (default_iterate_over_objfiles_in_search_order): Update.
8013 * objc-lang.c (info_selectors_command, info_classes_command)
8014 (find_methods): Update.
8015 * minsyms.c (find_solib_trampoline_target): Update.
8016 * maint.c (maintenance_info_sections)
8017 (maintenance_translate_address, count_symtabs_and_blocks):
8018 Update.
8019 * main.c (captured_main_1): Update.
8020 * linux-thread-db.c (try_thread_db_load_from_pdir)
8021 (has_libpthread): Update.
8022 * linespec.c (iterate_over_all_matching_symtabs)
8023 (search_minsyms_for_name): Update.
8024 * jit.c (jit_find_objf_with_entry_addr): Update.
8025 * hppa-tdep.c (find_unwind_entry)
8026 (hppa_lookup_stub_minimal_symbol): Update.
8027 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8028 Update.
8029 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8030 (elf_gnu_ifunc_resolve_by_got): Update.
8031 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8032 * dwarf-index-write.c (save_gdb_index_command): Update.
8033 * cp-support.c (add_symbol_overload_list_qualified): Update.
8034 * breakpoint.c (create_overlay_event_breakpoint)
8035 (create_longjmp_master_breakpoint)
8036 (create_std_terminate_master_breakpoint)
8037 (create_exception_master_breakpoint): Update.
8038 * blockframe.c (find_pc_partial_function): Update.
8039 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8040 (ada_collect_symbol_completion_matches)
8041 (ada_add_global_exceptions): Update.
8042
776489e0
TT
80432019-01-17 Tom Tromey <tom@tromey.com>
8044
8045 * solib-target.c (lm_info_target_p): Remove typedef. Don't
8046 declare VEC.
8047 (solib_target_parse_libraries): Change return type.
8048 (library_list_start_segment, library_list_start_section)
8049 (library_list_end_library, library_list_start_library); Update.
8050 (solib_target_free_library_list): Remove.
8051 (solib_target_parse_libraries): Remove cleanup. Change return
8052 type.
8053 (solib_target_current_sos): Update.
8054
6471e7d2
TT
80552019-01-17 Tom Tromey <tromey@bapiya>
8056
8057 * valprint.c: Replace "the the" with "the".
8058 * symtab.c: Replace "the the" with "the".
8059 * solib.c: Replace "the the" with "the".
8060 * solib-dsbt.c: Replace "the the" with "the".
8061 * linespec.c: Replace "the the" with "the".
8062 * dwarf2loc.h: Replace "the the" with "the".
8063 * amd64-windows-tdep.c: Replace "the the" with "the".
8064 * aarch64-tdep.c: Replace "the the" with "the".
8065
c24bdb02
KS
80662019-01-16 Keith Seitz <keiths@redhat.com>
8067
8068 PR gdb/23773
8069 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8070 <builder>: Rename to ..
8071 <m_builder>: ... this and make private.
8072 (dwarf2_cu::get_builder): New method. Change all users of
8073 `builder' to use this method.
8074 (dwarf2_start_symtab): Move to ...
8075 (dwarf2_cu::start_symtab): ... here. Update all callers
8076 (setup_type_unit_groups): Move to ...
8077 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
8078 callers.
8079 (dwarf2_cu::reset_builder): New method.
8080 (process_full_compunit, process_full_type_unit): Use
8081 dwarf2_cu::reset_builder.
8082 (follow_die_offset): Record the ancestor CU if it is different
8083 from the followed DIE's CU.
8084 (follow_die_sig_1): Likewise.
8085
8d64371b
TT
80862019-01-15 Tom Tromey <tom@tromey.com>
8087
8088 * remote.c (class remote_state) <buf>: Now a char_vector.
8089 <buf_size>: Remove.
8090 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
8091 parameter.
8092 (remote_target::getpkt_or_notif_sane_1)
8093 (remote_target::getpkt_sane)
8094 (remote_target::getpkt_or_notif_sane): Likewise.
8095 (class remote_target) <putpkt>: New overload.
8096 (remote_target::read_frame): Change type of "buf_p". Remove
8097 sizeof_p parameter.
8098 (packet_ok): New overload.
8099 (packet_check_result): New overload.
8100 Update all uses.
8101
bb277751
TT
81022019-01-14 Tom Tromey <tom@tromey.com>
8103
8104 * remote-notif.c (handle_notification, remote_notif_ack)
8105 (remote_notif_parse): Make "buf" const.
8106 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8107 const.
8108 (remote_notif_parse, remote_notif_ack, handle_notification):
8109 Likewise.
8110 * remote.c (remote_notif_stop_parse): Make "buf" const.
8111 (remote_target::remote_parse_stop_reply): Make "buf" const.
8112 (remote_notif_stop_ack): Make "buf" const.
8113
05be00a8
TT
81142019-01-14 Tom Tromey <tom@tromey.com>
8115
8116 * remote.c (remote_console_output): Make parameter const.
8117
491adeca
TT
81182019-01-14 Tom Tromey <tom@tromey.com>
8119
8120 * target-debug.h (target_debug_print_signals): Constify.
8121 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8122 * procfs.c (procfs_target::pass_signals): Update.
8123 * linux-nat.c (linux_nat_target::pass_signals): Update.
8124 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8125 * target-delegates.c: Rebuild.
8126 * remote.c (remote_target::program_signals): Update.
8127 (remote_target::pass_signals): Update.
8128 * target.c (target_pass_signals): Constify argument.
8129 (target_program_signals): Likewise.
8130 * target.h (struct target_ops) <pass_signals, program_signals>:
8131 Constify argument.
8132 (target_pass_signals, target_program_signals): Constify argument.
8133
bbd94648
TT
81342019-01-14 Tom Tromey <tom@tromey.com>
8135
8136 PR tui/28819:
8137 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8138
6f072a10
PFC
81392019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
8140
8141 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8142 field.
8143 * rs6000-tdep.c: Include reggroups.h.
8144 (IS_V_ALIAS_PSEUDOREG): Define.
8145 (rs6000_register_name): Return names for the "vX" aliases.
8146 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8147 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
8148 aliases. Call default_register_reggroup_p for all other
8149 pseudo-registers.
8150 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8151 New functions.
8152 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8153 Handle "vX" aliases.
8154 (v_alias_pseudo_register_collect): New function.
8155 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8156 (rs6000_gdbarch_init): Initialize "vX" aliases as
8157 pseudo-registers. Restore registration of
8158 rs6000_pseudo_register_reggroup_p with
8159 set_tdesc_pseudo_register_reggroup_p.
8160
1a782351
MF
81612019-01-13 Max Filippov <jcmvbkbc@gmail.com>
8162
8163 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8164 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8165 set_gdbarch_num_pseudo_regs.
8166
d73cff18
PW
81672019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8168
8169 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8170 Remove arg prefixname, add do_set and do_show.
8171 Add member functions set_list and show_list.
8172 * cli/cli-style.c (class cli_style_option): Update accordingly.
8173 (style_set_list): Move to file scope.
8174 (style_show_list): Likewise.
8175 (set_style): Call help_list.
8176 (show_style): Call cmd_show_list.
8177 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8178 Update to use the new macro.
8179
60a90376
JB
81802019-10-12 Joel Brobecker <brobecker@adacore.com>
8181
8182 * ada-lang.c (_initialize_ada_language): Expand the help text
8183 for the "catch exception" command.
8184
9d7c67bf
PW
81852019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8186
8187 * symtab.c (matching_obj_sections): Initialize obj,
8188 declare it closer to its usage.
8189
7cf47dc4
TT
81902019-01-10 Tom Tromey <tom@tromey.com>
8191
8192 * thread-iter.h (inf_threads_iterator): Use next_iterator.
8193 (basic_inf_threads_range): Remove.
8194 (inf_threads_range, inf_non_exited_threads_range)
8195 (safe_inf_threads_range): Use next_adapter.
8196
d3cb6808
KS
81972019-01-10 Keith Seitz <keiths@redhat.com>
8198
8199 PR gdb/23712
8200 PR symtab/23010
8201 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8202 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8203
63a20375
KS
82042019-01-10 Keith Seitz <keiths@redhat.com>
8205
8206 PR gdb/23712
8207 PR symtab/23010
8208 * dictionary.c (pending_to_vector): Remove.
8209 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8210 Remove _1 suffix, replacing functions of the same name. Update
8211 all callers.
8212 (dict_create_hashed, dict_create_hashed_expandable)
8213 (dict_create_linear, dict_create_linear_expandable, dict_free)
8214 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8215 Make functions static.
8216
b026f593
KS
82172019-01-10 Keith Seitz <keiths@redhat.com>
8218
8219 PR gdb/23712
8220 PR symtab/23010
8221 * dictionary.h (struct dictionary): Replace declaration with
8222 multidictionary.
8223 (dict_create_hashed, dict_create_hashed_expandable)
8224 (dict_create_linear, dict_create_linear_expandable)
8225 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8226 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8227 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8228 taking multidictionary argument.
8229 [ALL_DICT_SYMBOLS]: Update for multidictionary.
8230 * block.h (struct block) <dict>: Change to multidictionary
8231 and rename `multidict'.
8232 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8233 symmisc.c: Update all dictionary references to multidictionary.
8234
c7748ee9
KS
82352019-01-10 Keith Seitz <keiths@redhat.com>
8236
8237 PR gdb/23712
8238 PR symtab/23010
8239 * dictionary.c: Include unordered_map.
8240 (pending_to_vector): New function.
8241 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8242 Rewrite the non-"_1" functions to take vector instead
8243 of linked list.
8244 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8245 "new" _1 versions of the same name.
8246 (multidictionary): Define.
8247 (std::hash<enum language): New definition.
8248 (collate_pending_symbols_by_language, mdict_create_hashed)
8249 (mdict_create_hashed_expandable, mdict_create_linear)
8250 (mdict_create_linear_expandable, mdict_free)
8251 (find_language_dictionary, create_new_language_dictionary)
8252 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8253 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8254 (mdict_size, mdict_empty): New functions.
8255 * dictionary.h (mdict_iterator): Define.
8256
67aa1f3c
PA
82572019-01-10 Pedro Alves <palves@redhat.com>
8258
8259 * breakpoint.c (read_uploaded_action)
8260 (create_tracepoint_from_upload): Adjust to use
8261 gdb::unique_xmalloc_ptr.
8262 * ctf.c (ctf_write_uploaded_tp):
8263 (SET_ARRAY_FIELD): Use emplace_back.
8264 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8265 * tracefile-tfile.c (tfile_write_uploaded_tp):
8266 * tracepoint.c (parse_tracepoint_definition): Adjust to use
8267 gdb::unique_xmalloc_ptr.
8268 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8269 at_string, cond_string, cmd_strings>: Replace char pointers
8270 with gdb::unique_xmalloc_ptr.
8271
2f667667
PA
82722019-01-10 Pedro Alves <palves@redhat.com>
8273
8274 * solib-target.c (library_list_start_library): Don't xstrdup name.
8275
36cb7237
PA
82762019-01-10 Pedro Alves <palves@redhat.com>
8277
8278 * mdebugread.c (parse_partial_symbols): Use
8279 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8280
da584958
AB
82812019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
8282
8283 * linux-fork.c (scoped_switch_fork_info)
8284 <~scoped_switch_fork_info>: Fix incorrect variable name.
8285
1ef8573c
AB
82862019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
8287
8288 * linux-fork.c (scoped_switch_fork_info)
8289 <scoped_switch_fork_info>: Make explicit.
8290 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8291
8d7bcccb
TT
82922019-01-10 Tom Tromey <tom@tromey.com>
8293
8294 * objfiles.h (objfile::reset_psymtabs): Update.
8295 * objfiles.c (objfile::objfile): Update.
8296 * psymtab.h (psymtab_storage::obstack): Update.
8297 (psymtab_storage::m_obstack): Use gdb::optional.
8298 (class psymtab_storage): Update comment. Remove objfile
8299 parameter.
8300 * psymtab.c (psymtab_storage::psymtab_storage): Update.
8301
b596a3c7
TT
83022019-01-10 Tom Tromey <tom@tromey.com>
8303
8304 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8305 <free_psymtabs>: Now private.
8306 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8307 (allocate_psymtab): Use new method.
8308
a9342b62
TT
83092019-01-10 Tom Tromey <tom@tromey.com>
8310
8311 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8312 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8313 * mdebugread.c (parse_partial_symbols): Use
8314 allocate_dependencies.
8315 * dwarf2read.c (dwarf2_create_include_psymtab): Use
8316 allocate_dependencies.
8317 (process_psymtab_comp_unit_reader)
8318 (build_type_psymtab_dependencies): Likewise.
8319 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8320
5af70966
TT
83212019-01-10 Tom Tromey <tom@tromey.com>
8322
8323 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8324 PSYMBOL_SET_LANGUAGE.
8325 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8326
5923a04c
TT
83272019-01-10 Tom Tromey <tom@tromey.com>
8328
8329 * psymtab.h (psymtab_storage::obstack): New method.
8330 <m_obstack>: Rename from obstack; now private.
8331 * psymtab.c (psymtab_storage): Update.
8332 * dwarf2read.c (create_addrmap_from_index)
8333 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8334 Update.
8335
6d6a12bf
TT
83362019-01-10 Tom Tromey <tom@tromey.com>
8337
8338 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8339 * objfiles.h (objfile::reset_psymtabs): New method.
8340
d320c2b5
TT
83412019-01-10 Tom Tromey <tom@tromey.com>
8342
8343 * symmisc.c (print_symbol_bcache_statistics): Update.
8344 (print_objfile_statistics): Update.
8345 * symfile.c (reread_symbols): Update.
8346 * psymtab.h (class psymtab_storage): New.
8347 * psymtab.c (psymtab_storage): New constructor.
8348 (~psymtab_storage): New destructor.
8349 (require_partial_symbols): Update.
8350 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8351 (find_pc_sect_psymtab, find_pc_sect_psymbol)
8352 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8353 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8354 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8355 (start_psymtab_common, end_psymtab_common)
8356 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8357 (allocate_psymtab): Update.
8358 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8359 Update.
8360 (dump_psymtab_addrmap, maintenance_print_psymbols)
8361 (maintenance_check_psymtabs): Update.
8362 (class objfile_psymtabs): Move to objfiles.h.
8363 * psympriv.h (discard_psymtab): Now inline.
8364 (psymtab_discarder::psymtab_discarder): Update.
8365 (psymtab_discarder::~psymtab_discarder): Update.
8366 (ALL_OBJFILE_PSYMTABS): Rewrite.
8367 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8368 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8369 Remove fields.
8370 <partial_symtabs>: New field.
8371 (class objfile_psymtabs): Move from psymtab.h. Update.
8372 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8373 psymbol_cache.
8374 (objfile::~objfile): Don't destroy psymbol_cache.
8375 * mdebugread.c (parse_partial_symbols): Update.
8376 * dwarf2read.c (create_addrmap_from_index)
8377 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8378 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8379 (add_partial_subprogram, dwarf2_ranges_read): Update.
8380 * dwarf-index-write.c (write_address_map)
8381 (write_one_signatured_type, recursively_write_psymbols)
8382 (class debug_names, class debug_names, write_psymtabs_to_index):
8383 Update.
8384
1d94a5a3
TT
83852019-01-10 Tom Tromey <tom@tromey.com>
8386
8387 * symtab.h (SYMBOL_SET_NAMES): Update.
8388 (symbol_set_names): Update.
8389 (MSYMBOL_SET_NAMES): Update.
8390 * symtab.c (symbol_set_names): Change argument to be an
8391 objfile_per_bfd_storage.
8392 * psymtab.c (add_psymbol_to_bcache): Update.
8393 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8394
0f14768a
TT
83952019-01-10 Tom Tromey <tom@tromey.com>
8396
8397 * symtab.c (create_demangled_names_hash): Change argument to be an
8398 objfile_per_bfd_storage.
8399 (symbol_set_names): Update.
8400
6eee24ce
TT
84012019-01-10 Tom Tromey <tom@tromey.com>
8402
8403 * xcoffread.c (xcoff_initial_scan): Unconditionally call
8404 init_psymbol_list.
8405 * psymtab.c (init_psymbol_list): Do nothing if already called.
8406 * psympriv.h (init_psymbol_list): Add comment.
8407 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8408 init_psymbol_list.
8409 * dbxread.c (dbx_symfile_read): Unconditionally call
8410 init_psymbol_list.
8411
75aedd27
TT
84122019-01-10 Tom Tromey <tom@tromey.com>
8413
8414 * xcoffread.c (scan_xcoff_symtab): Update.
8415 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8416 "where".
8417 * mdebugread.c (parse_partial_symbols)
8418 (handle_psymbol_enumerators): Update.
8419 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8420 * dbxread.c (read_dbx_symtab): Update.
8421 * psympriv.h (psymbol_placement): New enum.
8422 (add_psymbol_to_list): Update.
8423
939652a5
TT
84242019-01-10 Tom Tromey <tom@tromey.com>
8425
8426 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8427 static_psymbols parameters.
8428 (scan_xcoff_symtab): Update.
8429 * psymtab.c (start_psymtab_common): Remove global_psymbols and
8430 static_psymbols parameters.
8431 * psympriv.h (start_psymtab_common): Update.
8432 * mdebugread.c (parse_partial_symbols): Update.
8433 * dwarf2read.c (create_partial_symtab): Update.
8434 * dbxread.c (read_dbx_symtab): Update.
8435 (start_psymtab): Remove global_psymbols and static_psymbols
8436 parameters.
8437
baa62830
TT
84382019-01-10 Tom Tromey <tom@tromey.com>
8439
8440 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8441 * psymtab.c (allocate_psymtab): Add comment.
8442 * psympriv.h (allocate_psymtab): Add comment.
8443 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8444 initializations.
8445 * dbxread.c (dbx_end_psymtab): Remove some initializations.
8446
0e8f53ba
TT
84472019-01-10 Tom Tromey <tom@tromey.com>
8448
8449 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8450 Don't declare.
8451 * mipsread.c: Include mdebugread.h.
8452 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8453 Declare.
8454 * elfread.c: Include mdebugread.h.
8455
b22a7c6a
TT
84562019-01-09 Tom Tromey <tom@tromey.com>
8457
8458 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8459 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8460 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8461 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8462 (psym_lookup_symbol, psym_find_last_source_symtab)
8463 (psym_forget_cached_source_info, psym_print_stats)
8464 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8465 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8466 (psym_map_matching_symbols, psym_expand_symtabs_matching)
8467 (psym_find_compunit_symtab_by_address)
8468 (maintenance_print_psymbols, maintenance_info_psymtabs)
8469 (maintenance_check_psymtabs): Use ranged for.
8470 * psymtab.h (class objfile_psymtabs): New.
8471 (require_partial_symbols): Return objfile_psymtabs.
8472 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8473
3b9d3ac2
TT
84742019-01-09 Tom Tromey <tom@tromey.com>
8475
8476 * symfile.c (overlay_invalidate_all, find_pc_overlay)
8477 (find_pc_mapped_section, list_overlays_command)
8478 (map_overlay_command, unmap_overlay_command)
8479 (simple_overlay_update): Use all_objfiles.
8480 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8481 * printcmd.c (info_symbol_command): Use all_objfiles.
8482 * objfiles.h (ALL_OBJSECTIONS): Remove.
8483 * maint.c (maintenance_translate_address): Use all_objfiles.
8484 * gcore.c (gcore_create_callback): Use all_objfiles.
8485 (objfile_find_memory_regions): Likewise.
8486
8b31193a
TT
84872019-01-09 Tom Tromey <tom@tromey.com>
8488
8489 * symtab.c (find_line_symtab, info_sources_command)
8490 (make_source_files_completion_list): Use objfile_compunits.
8491 * source.c (select_source_symtab): Use objfile_compunits.
8492 * objfiles.h (struct objfile): Update comment.
8493 (ALL_OBJFILES): Remove.
8494 (ALL_FILETABS): Remove.
8495 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8496 objfile_compunits.
8497
d5da8b3c
TT
84982019-01-09 Tom Tromey <tom@tromey.com>
8499
8500 * symmisc.c (print_objfile_statistics, dump_objfile)
8501 (maintenance_print_symbols): Use compunit_filetabs.
8502 * source.c (forget_cached_source_info_for_objfile): Use
8503 compunit_filetabs.
8504 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8505 (ALL_FILETABS): Use compunit_filetabs.
8506 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8507 * coffread.c (coff_symtab_read): Use compunit_filetabs.
8508
5accd1a0
TT
85092019-01-09 Tom Tromey <tom@tromey.com>
8510
8511 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8512 (compunit_filetabs): New.
8513 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8514 compunit_filetabs.
8515 (info_sources_command, make_source_files_completion_list): Remove
8516 declaration.
8517 * symmisc.c (print_objfile_statistics, dump_objfile)
8518 (maintenance_print_symbols): Remove declaration.
8519 (maintenance_info_symtabs): Use compunit_filetabs.
8520 (maintenance_info_line_tables): Likewise.
8521 * source.c (select_source_symtab): Change local variable name.
8522 (forget_cached_source_info_for_objfile): Remove declaration.
8523 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8524 * objfiles.c (objfile_relocate1): Remove declaration.
8525 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8526 declaration.
8527 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8528 * coffread.c (coff_symtab_read): Remove declaration.
8529 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8530 compunit_filetabs.
8531
d8aeb77f
TT
85322019-01-09 Tom Tromey <tom@tromey.com>
8533
8534 * symtab.c (lookup_objfile_from_block)
8535 (find_pc_sect_compunit_symtab, search_symbols)
8536 (default_collect_symbol_completion_matches_break_on): Use
8537 objfile_compunits.
8538 * objfiles.h (ALL_COMPUNITS): Remove.
8539 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8540 * cp-support.c (add_symbol_overload_list_qualified): Use
8541 objfile_compunits.
8542 * ada-lang.c (ada_collect_symbol_completion_matches)
8543 (ada_add_global_exceptions): Use objfile_compunits.
8544
592553c4
TT
85452019-01-09 Tom Tromey <tom@tromey.com>
8546
8547 * source.c (select_source_symtab)
8548 (forget_cached_source_info_for_objfile): Remove declaration.
8549 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8550 declaration.
8551 * maint.c (count_symtabs_and_blocks): Remove declaration.
8552 * cp-support.c (add_symbol_overload_list_qualified): Remove
8553 declaration.
8554 * coffread.c (coff_symtab_read): Remove declaration.
8555 * symtab.c (lookup_symbol_in_objfile_symtabs)
8556 (basic_lookup_transparent_type_1): Use objfile_compunits.
8557 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8558 (info_sources_command, search_symbols)
8559 (default_collect_symbol_completion_matches_break_on)
8560 (make_source_files_completion_list): Remove declaration.
8561 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8562 (ada_collect_symbol_completion_matches)
8563 (ada_add_global_exceptions): Remove declaration.
8564 * linespec.c (iterate_over_all_matching_symtabs): Use
8565 objfile_compunits.
8566 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8567 (class objfile_compunits): New.
8568 (ALL_COMPUNITS): Use objfile_compunits.
8569 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8570 (maintenance_check_symtabs, maintenance_info_line_tables): Use
8571 objfile_compunits.
8572 * objfiles.c (objfile_relocate1): Use objfile_compunits.
8573
5325b9bf
TT
85742019-01-09 Tom Tromey <tom@tromey.com>
8575
8576 * symtab.c (search_symbols)
8577 (default_collect_symbol_completion_matches_break_on): Use
8578 objfile_msymbols.
8579 * ada-lang.c (ada_lookup_simple_minsym)
8580 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8581 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8582 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8583 objfile_msymbols.
8584 * coffread.c (coff_symfile_read): Use objfile_msymbols.
8585 * symmisc.c (dump_msymbols): Use objfile_msymbols.
8586 * objc-lang.c (find_methods): Use objfile_msymbols.
8587 (info_selectors_command, info_classes_command): Likewise.
8588 * stabsread.c (scan_file_globals): Use objfile_msymbols.
8589 * objfiles.h (class objfile_msymbols): New.
8590 (ALL_OBJFILE_MSYMBOLS): Remove.
8591 (ALL_MSYMBOLS): Remove.
8592
cac85af2
TT
85932019-01-09 Tom Tromey <tom@tromey.com>
8594
8595 * common/next-iterator.h (next_adapter): Add Iterator template
8596 parameter.
8597 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8598 (class all_objfiles_safe): New.
8599 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8600 * objfiles.c (put_objfile_before): Update comment.
8601 (add_separate_debug_objfile): Likewise.
8602 (free_all_objfiles): Use all_objfiles_safe.
8603 (objfile_purge_solibs): Likewise.
8604
aed57c53
TT
86052019-01-09 Tom Tromey <tom@tromey.com>
8606
8607 * symtab.c (iterate_over_symtabs, matching_obj_sections)
8608 (expand_symtab_containing_pc, lookup_static_symbol)
8609 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8610 (find_symbol_at_address, find_line_symtab, find_main_name): Use
8611 all_objfiles.
8612 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8613 * breakpoint.c (create_overlay_event_breakpoint)
8614 (create_longjmp_master_breakpoint)
8615 (create_std_terminate_master_breakpoint)
8616 (create_exception_master_breakpoint): Use all_objfiles.
8617 * linux-thread-db.c (try_thread_db_load_from_pdir)
8618 (has_libpthread): Use all_objfiles.
8619 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8620 * linespec.c (iterate_over_all_matching_symtabs)
8621 (search_minsyms_for_name): Use all_objfiles.
8622 * maint.c (maintenance_info_sections): Use all_objfiles.
8623 * main.c (captured_main_1): Use all_objfiles.
8624 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8625 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8626 * guile/scm-pretty-print.c
8627 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8628 * solib-spu.c (append_ocl_sos): Use all_objfiles.
8629 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8630 (maintenance_print_msymbols): Use all_objfiles.
8631 * source.c (select_source_symtab): Use all_objfiles.
8632 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8633 * symfile.c (remove_symbol_file_command)
8634 (expand_symtabs_matching, map_symbol_filenames): Use
8635 all_objfiles.
8636 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8637 all_objfiles.
8638 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8639 * objc-lang.c (find_methods): Use all_objfiles.
8640 * objfiles.c (have_partial_symbols, have_full_symbols)
8641 (have_minimal_symbols, qsort_cmp)
8642 (default_iterate_over_objfiles_in_search_order): Use
8643 all_objfiles.
8644 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8645 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8646 (maintenance_check_psymtabs): Use all_objfiles.
8647 (ALL_PSYMTABS): Remove.
8648 * compile/compile-object-run.c (do_module_cleanup): Use
8649 all_objfiles.
8650 * blockframe.c (find_pc_partial_function): Use all_objfiles.
8651 * cp-support.c (add_symbol_overload_list_qualified): Use
8652 all_objfiles.
8653 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8654 Use all_objfiles.
8655 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8656 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8657 all_objfiles.
8658 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8659 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8660 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8661 Uses all_objfiles.
8662 * solib.c (solib_read_symbols): Use all_objfiles
8663
99d89cde
TT
86642019-01-09 Tom Tromey <tom@tromey.com>
8665
8666 * probe.c (parse_probes_in_pspace): Use all_objfiles.
8667 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8668 all_objfiles.
8669 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8670 * symmisc.c (print_symbol_bcache_statistics)
8671 (print_objfile_statistics, maintenance_print_objfiles)
8672 (maintenance_info_symtabs, maintenance_check_symtabs)
8673 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8674 all_objfiles.
8675 * source.c (forget_cached_source_info): Use all_objfiles.
8676 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8677 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8678 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8679 * objfiles.c (update_section_map): Use all_objfiles.
8680 (shared_objfile_contains_address_p): Likewise.
8681 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8682 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8683
21708325
TT
86842019-01-09 Tom Tromey <tom@tromey.com>
8685
8686 * common/next-iterator.h: New file.
8687 * objfiles.h (class all_objfiles): New.
8688 (struct objfile_iterator): New.
8689
669e09f6
PW
86902019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8691
8692 * NEWS: Move the description of the changed "frame", "select-frame",
8693 and "info frame" commands to the Changed commands section.
8694
041be526
SM
86952019-01-09 Simon Marchi <simon.marchi@ericsson.com>
8696
8697 * gdbtypes.c (check_stub_method_group): Remove handling of old
8698 mangling schemes.
8699 * linespec.c (find_methods): Likewise.
8700 * stabsread.c (read_member_functions): Likewise.
8701 * valops.c (search_struct_method): Likewise.
8702 (value_struct_elt_for_reference): Likewise.
8703 * NEWS: Mention this change.
8704
0e2a2133
AB
87052019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
8706
8707 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8708 print_source_lines.
8709 * source.c (print_source_lines_base): Update line number check.
8710 (print_source_lines): New function.
8711 (source_lines_range::source_lines_range): New function.
8712 * source.h (class source_lines_range): New class.
8713 (print_source_lines): New declaration.
8714
1055a3b4
PW
87152019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8716
8717 * linespec.c (linespec_state_destructor): Free self->canonical_names.
8718
cfeadda5
TT
87192019-01-08 Tom Tromey <tom@tromey.com>
8720 Simon Marchi <simon.marchi@ericsson.com>
8721
8722 PR gdb/24060
8723 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8724 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8725 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8726 * f-exp.y (DOLLAR_VARIABLE): Likewise.
8727 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8728 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8729
583068ca
AB
87302019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
8731
8732 * source.c (select_source_symtab): Move header comment to
8733 declaration in source.h.
8734 (forget_cached_source_info_for_objfile): Likewise.
8735 (forget_cached_source_info): Likewise.
8736 (identify_source_line): Likewise.
8737 * source.h (identify_source_line): Move declaration from symtab.h
8738 and add comment from source.c
8739 (print_source_lines): Likewise.
8740 (forget_cached_source_info_for_objfile): Likewise.
8741 (forget_cached_source_info): Likewise.
8742 (select_source_symtab): Likewise.
8743 (enum print_source_lines_flag): Move definition from symtab.h.
8744 * symtab.h (identify_source_line): Move declaration to source.h.
8745 (print_source_lines): Likewise.
8746 (forget_cached_source_info_for_objfile): Likewise.
8747 (forget_cached_source_info): Likewise.
8748 (select_source_symtab): Likewise.
8749 (enum print_source_lines_flag): Move definition to source.h.
8750 * tui/tui-hooks.c: Add 'source.h' include.
8751
ec98a4ad
AB
87522019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
8753
8754 * source.c (print_source_lines_base): Handle requests to print
8755 reverse line number sequences, and guard against empty lines
8756 string.
8757
62ea19c1
AB
87582019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
8759
8760 * source.c (print_source_lines_base): Fix skip of '\r' if next
8761 character is '\n'.
8762
9d30e1fd
TT
87632019-01-06 Tom Tromey <tom@tromey.com>
8764
8765 * c-exp.y (struct c_parse_state) <macro_original_text,
8766 expansion_obstack>: New member.
8767 (macro_original_text, expansion_obstack): Remove globals.
8768 (scan_macro_expansion, scanning_macro_expansion)
8769 (finished_macro_expansion): Update.
8770 (scan_macro_cleanup): Remove.
8771 (yylex, c_parse): Update.
8772
c65bac38
TT
87732019-01-06 Tom Tromey <tom@tromey.com>
8774
8775 * c-exp.y (struct c_parse_state) <strings>: New member.
8776 (operator_stoken): Update.
8777
02e12e38
TT
87782019-01-06 Tom Tromey <tom@tromey.com>
8779
8780 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
8781 (union type_stack_elt) <typelist_val>: Now a pointer to
8782 std::vector.
8783 (type_stack_cleanup): Don't declare.
8784 (push_typelist): Update.
8785 * parse.c (pop_typelist): Return a std::vector.
8786 (push_typelist): Take a std::vector.
8787 (follow_types): Update. Do not free args.
8788 (type_stack_cleanup): Remove.
8789 * c-exp.y (struct c_parse_state): New.
8790 (cpstate): New global.
8791 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8792 (nonempty_typelist): Update.
8793 (func_mod): Create a new vector.
8794 (c_parse): Create a c_parse_state.
8795 (check_parameter_typelist): Do not delete params.
8796 (function_method): Update. Do not delete type_list.
8797
f097f5ad
TT
87982019-01-06 Tom Tromey <tom@tromey.com>
8799
8800 PR gdb/28155:
8801 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8802 check_typedef.
8803 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8804 (print_return_value): Likewise.
8805
d2adf9f1
TT
88062019-01-05 Tom Tromey <tom@tromey.com>
8807
8808 * contrib/cleanup_check.py: Remove.
8809 * contrib/gcc-with-excheck: Remove.
8810 * contrib/exsummary.py: Remove.
8811 * contrib/excheck.py: Remove.
8812
2eab46b1
JB
88132019-01-05 Joel Brobecker <brobecker@adacore.com>
8814
8815 * thread.c (delete_thread_1): Add gdb_assert that THR is not
8816 NULL. Initialize tpprev to NULL instead of assigning it
8817 to NULL on the next statement.
8818 * windows-nat.c (windows_delete_thread): Remove check for
8819 main_thread_id before printing thread exit notifications.
8820 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8821 Remove thread ID check against main_thread_id.
8822 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8823 windows_delete_thread.
8824 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8825
48c5e7e2
TT
88262019-01-04 Tom Tromey <tom@tromey.com>
8827
8828 * compile/compile.c (_initialize_compile): Use upper case for
8829 metasyntactic variables.
8830 * symmisc.c (_initialize_symmisc): Use upper case for
8831 metasyntactic variables.
8832 * psymtab.c (_initialize_psymtab): Use upper case for
8833 metasyntactic variables.
8834 * demangle.c (demangle_command): Use upper case for metasyntactic
8835 variables.
8836 (_initialize_demangler): Likewise.
8837 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8838 variables.
8839
986041cd
TT
88402019-01-03 Tom Tromey <tom@tromey.com>
8841
8842 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8843
7c711119
TT
88442019-01-03 Tom Tromey <tom@tromey.com>
8845
8846 * python/py-symtab.c (salpy_str): Update.
8847 (struct salpy_sal_object) <symtab>: Now a PyObject.
8848 (salpy_dealloc): Update.
8849 (del_objfile_sal): Use gdbpy_ref.
8850
1b20edf0
TT
88512019-01-03 Tom Tromey <tom@tromey.com>
8852
8853 * python/py-type.c (convert_field): Use new_reference. Return
8854 gdbpy_ref.
8855 (make_fielditem): Return gdbpy_ref.
8856 (typy_fields): Update.
8857 (typy_getitem): Update.
8858 (field_name): Return gdbpy_ref. Use new_reference.
8859 (typy_iterator_iternext): Update.
8860
ea41325b
TT
88612019-01-03 Tom Tromey <tom@tromey.com>
8862
8863 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8864
2a3c71d6
TT
88652019-01-03 Tom Tromey <tom@tromey.com>
8866
8867 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8868 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8869 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8870 (pspy_set_frame_filters, pspy_set_frame_unwinders)
8871 (pspy_set_type_printers): Likewise.
8872 * python/py-function.c (fnpy_init): Use gdbpy_ref.
8873 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8874 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8875 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8876 (objfpy_set_type_printers): Likewise.
8877
5c329e6a
TT
88782019-01-03 Tom Tromey <tom@tromey.com>
8879
8880 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8881 (gdbpy_print_stack): Use gdbpy_err_fetch.
8882 * python/python-internal.h (class gdbpy_err_fetch): New class.
8883 (class gdbpy_enter) <m_error_type, m_error_value,
8884 m_error_traceback>: Remove.
8885 <m_error>: New member.
8886 (gdbpy_exception_to_string): Don't declare.
8887 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8888 * python/py-value.c (convert_value_from_python): Use
8889 gdbpy_err_fetch.
8890 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8891 gdbpy_exception_to_string.
8892 (gdbpy_handle_exception): Use gdbpy_err_fetch.
8893 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8894 gdbpy_err_fetch.
8895
169bb27b
AB
88962019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
8897
8898 * linux-nat.c (delete_lwp_cleanup): Delete.
8899 (struct lwp_deleter): New struct.
8900 (lwp_info_up): New typedef.
8901 (linux_nat_target::follow_fork): Delete cleanup, and make use of
8902 lwp_info_up.
8903
a07c8880
AB
89042019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
8905
8906 * linux-fork.c (class scoped_switch_fork_info): New class.
8907 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8908
26089c49
AB
89092019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
8910
8911 * valops.c (find_overload_match): Remove use of null_cleanup, and
8912 calls to do_cleanups.
8913
06d3e5b0
AB
89142019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
8915
8916 * compile/compile-cplus-types.c
8917 (compile_cplus_instance::decl_name): Handle changes to
8918 cp_func_name.
8919 * cp-support.c (cp_func_name): Update header comment, update
8920 return type.
8921 * cp-support.h (cp_func_name): Update return type in declaration.
8922 * valops.c (find_overload_match): Move temp_func local to top
8923 level of function and change its type. Use temp_func to hold and
8924 delete temporary string obtained from cp_func_name.
8925
66644cd3
AB
89262019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
8927
8928 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8929 gdb::char_vector, remove cleanup, and update uses of `msg`.
8930
592d8c0a
JW
89312019-01-03 Jim Wilson <jimw@sifive.com>
8932
8933 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8934
c55d06ec
TT
89352019-01-02 Tom Tromey <tom@tromey.com>
8936
8937 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8938 (tdesc_parse_xml): Remove cleanups.
8939 * target-descriptions.h (make_cleanup_free_target_description):
8940 Don't declare.
8941 (target_desc_deleter): New struct.
8942 (target_desc_up): New typedef.
8943 * target-descriptions.c (target_desc_deleter::operator()): Rename
8944 from free_target_description.
8945 (make_cleanup_free_target_description): Remove.
8946
3a6ae42d
TT
89472019-01-02 Tom Tromey <tom@tromey.com>
8948
8949 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
8950 constructor, destructor.
8951 (linespec_parser): Remove typedef.
8952 (~linespec_parser): Rename from linespec_parser_delete.
8953 (linespec_lex_to_end, linespec_complete_label)
8954 (linespec_complete): Update.
8955 (decode_line_full): Remove cleanups.
8956 (decode_line_1): Update.
8957
61fd3e73
TT
89582019-01-02 Tom Tromey <tom@tromey.com>
8959
8960 * python/python-internal.h (inferior_to_inferior_object): Change
8961 return type.
8962 * python/py-exitedevent.c (create_exited_event_object): Update.
8963 * python/py-inferior.c (inferior_to_inferior_object): Return
8964 gdbpy_ref.
8965 (python_new_inferior, python_inferior_deleted)
8966 (thread_to_thread_object, delete_thread_object)
8967 (build_inferior_list, gdbpy_selected_inferior): Update.
8968 * python/py-infthread.c (create_thread_object): Update. Also fail
8969 if inferior_to_inferior_object fails.
8970
d20172fc
SM
89712019-01-02 Simon Marchi <simon.marchi@ericsson.com>
8972
8973 * inferior.h (class inferior) <displaced_step_state>: New field.
8974 * infrun.h (struct displaced_step_state): Move here from
8975 infrun.c. Initialize fields, add constructor.
8976 <inf>: Remove field.
8977 <reset>: New method.
8978 * infrun.c (struct displaced_step_inferior_state): Move to
8979 infrun.h.
8980 (displaced_step_inferior_states): Remove.
8981 (get_displaced_stepping_state): Adust.
8982 (displaced_step_in_progress_any_inferior): Adjust.
8983 (displaced_step_in_progress_thread): Adjust.
8984 (displaced_step_in_progress): Adjust.
8985 (add_displaced_stepping_state): Remove.
8986 (get_displaced_step_closure_by_addr): Adjust.
8987 (remove_displaced_stepping_state): Remove.
8988 (infrun_inferior_exit): Call displaced_step_state.reset.
8989 (use_displaced_stepping): Don't check for NULL.
8990 (displaced_step_prepare_throw): Call
8991 get_displaced_stepping_state.
8992 (displaced_step_fixup): Don't check for NULL.
8993 (prepare_for_detach): Don't check for NULL.
8994
e3319240
PW
89952019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8996
8997 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8998 in case of call that did not complete.
8999
5d36dfb9
AU
90002019-01-02 Andrey Utkin <autkin@undo.io>
9001
9002 * symfile.c (find_separate_debug_file): Fix search of debug files for
9003 remote debuggee.
9004
8833fbf0
TT
90052019-01-02 Tom Tromey <tom@tromey.com>
9006
9007 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9008 indentation.
9009 * python/py-frame.c (frapy_older): Remove cast.
9010 (frapy_newer): Likewise.
9011 * python/py-breakpoint.c (local_setattro): Remove cast.
9012 * python/py-arch.c (archpy_name): Remove local variable.
9013 * python/py-type.c (gdbpy_lookup_type): Remove cast.
9014
4ada3dfd
JB
90152019-01-02 Joel Brobecker <brobecker@adacore.com>
9016
9017 * unittests/basic_string_view/element_access/char/empty.cc:
9018 Fix year range in copyright header.
9019
113b7b81
AB
90202019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
9021
9022 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9023 Delete.
9024 <operator==>: Update with for removed field.
9025 <hash>: Likewise.
9026 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9027 <isa_features>: ...this.
9028 <abi_features>: New field.
9029 (riscv_isa_flen): Update comment.
9030 (riscv_abi_xlen): New declaration.
9031 (riscv_abi_flen): New declaration.
9032 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9033 isa_features.
9034 (riscv_abi_xlen): New function.
9035 (riscv_isa_flen): Update to get answer from isa_features.
9036 (riscv_abi_flen): New function.
9037 (riscv_has_fp_abi): Update to get answer from abi_features.
9038 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9039 xlen and flen.
9040 (riscv_call_info) <xlen, flen>: Update comment.
9041 (riscv_call_arg_struct): Remove invalid assertions
9042 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9043 is removed.
9044 (riscv_gdbarch_init): Gather isa features and abi features
9045 separately, ensure both match on the gdbarch when reusing an old
9046 gdbarch. Relax an error check to allow 32-bit abi float to run on
9047 a target with 64-bit float hardware.
9048
b18ca514
PW
90492019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9050
9051 * source.c (search_command_helper): Stop reverse search
9052 when line 1 has been searched.
9053
ec70d8db
PW
90542019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9055
9056 * record-full.c (record_full_base_target::close): Rewrite
9057 record_full_core_buf_list free logic.
9058
5b38f9c1
PW
90592019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9060
9061 * break-catch-syscall.c (print_one_catch_syscall): xfree
9062 the last text.
9063
66d91b39
JB
90642019-01-01 Joel Brobecker <brobecker@adacore.com>
9065
9066 * top.c (print_gdb_version): Update Copyright year in version
9067 message.
9068
42a4f53d
JB
90692019-01-01 Joel Brobecker <brobecker@adacore.com>
9070
9071 Update copyright year range in all GDB files.
9072
7e955d83 90732019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 9074
5bbd631d 9075 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 9076
5bbd631d 9077For older changes see ChangeLog-2018.
c906108c
SS
9078\f
9079Local Variables:
9080mode: change-log
9081left-margin: 8
9082fill-column: 74
9083version-control: never
57da7796 9084coding: utf-8
c906108c 9085End:
5bbd631d 9086