]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
[gdb/testsuite] Add KFAIL for missing support of reverse-debugging xsave
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
7b9a15e1
CB
12019-10-12 Christian Biesinger <cbiesinger@google.com>
2
3 * remote.c (remote_target::get_trace_status): Remove declaration of
4 trace_regblock_size.
5
cc8dee1f
CB
62019-10-12 Christian Biesinger <cbiesinger@google.com>
7
8 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
9 (show_user): Remove declaration of cmdlist.
10 * cli/cli-cmds.h (max_user_call_depth): Declare.
11 * cli/cli-script.c (execute_user_command): Remove declaration
12 of max_user_call_depth.
13
a83d4ef6
JW
142019-10-11 Jim Wilson <jimw@sifive.com>
15
5f93c5a6
JW
16 * gdbsupport/print-utils.h (pulongest): Fix comment.
17 (plongest): Likewise.
18 (phex): Add missing comment, mention leading zeros.
19 (phex_nz): Add mention of no leading zeros to comment.
20
a83d4ef6
JW
21 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
22 plongest instead of unsigned long long cast.
23
26344e0c
CB
242019-10-10 Christian Biesinger <cbiesinger@google.com>
25
26 * main.c (captured_main_1): Include gdbtk.h and remove declarations
27 for external_editor_command and gdbtk_test.
28
c2c440a9
CB
292019-10-10 Christian Biesinger <cbiesinger@google.com>
30
31 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
32 * varobj.c (varobjdebug): Move comment to...
33 * varobj.h (varobjdebug): ...here, and declare.
34
a31bff9d
TT
352019-10-09 Tom Tromey <tom@tromey.com>
36
37 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
38 erase_data_content.
39
7523da63
TT
402019-10-09 Tom Tromey <tom@tromey.com>
41
42 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
43 * tui/tui-stack.c (tui_locator_window::rerender): Update.
44 * tui/tui-command.c (tui_cmd_window::resize)
45 (tui_refresh_cmd_win): Update.
46 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
47 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
48 * tui/tui-data.c (~tui_gen_win_info): Remove.
49 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
50 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
51 (tui_redisplay_readline, tui_mld_flush)
52 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
53 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
54 (tui_data_window::erase_data_content)
55 (tui_data_item_window::rerender)
56 (tui_data_item_window::refresh_window): Update.
57 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
58 (box_win, tui_gen_win_info::make_window)
59 (tui_gen_win_info::make_visible): Update.
60 (tui_delete_win): Remove.
61 * tui/tui-winsource.c
62 (tui_source_window_base::do_erase_source_content): Update.
63 (tui_show_source_line, tui_source_window_base::update_tab_width)
64 (tui_source_window_base::update_exec_info): Update.
65 * tui/tui-data.h (struct curses_deleter): New.
66 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
67 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
68
a7798e7f
TT
692019-10-09 Tom Tromey <tom@tromey.com>
70
71 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
72
5c45899e
TT
732019-10-09 Tom Tromey <tom@tromey.com>
74
75 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
76 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
77
6d7fd9aa
TT
782019-10-09 Tom Tromey <tom@tromey.com>
79
80 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
81 window height directly.
82 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
83 declare.
84 * tui/tui-layout.c (tui_default_win_height): Remove.
85 (tui_default_win_viewport_height): Remove.
86
d2dd1084
TT
872019-10-09 Tom Tromey <tom@tromey.com>
88
89 * tui/tui.h: Remove comments.
90
cff32449
TV
912019-10-09 Tom de Vries <tdevries@suse.de>
92
93 * python/lib/gdb/printer/bound_registers.py: Use
94 '^builtin_type_bound128' as regexp argument for
95 add_builtin_pretty_printer.
96
6a25e8a2
CB
972019-10-09 Christian Biesinger <cbiesinger@google.com>
98
99 * guile/guile.c (guile_extension_script_ops): Remove forward
100 declaration and mark as static.
101 (guile_script_ops): Likewise.
102 (extension_language_guile): Move further down in the file so
103 it can reference the definitions for guile_{extension_,}script_ops.
104
6d9d6da4
AA
1052019-10-09 Andreas Arnez <arnez@linux.ibm.com>
106
107 * s390-tdep.c (390_process_record): Handle new arch13 instructions
108 except SORTL, DFLTCC, and KDSA.
109
3abea05d
TT
1102019-10-08 Tom Tromey <tromey@adacore.com>
111
112 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
113 (struct safe_symbol_file_add_args): Remove.
114
dde996e2
TT
1152019-10-08 Tom Tromey <tromey@adacore.com>
116
117 * windows-nat.c: Don't include buildsym-legacy.h.
118
cd6fdaa1
TT
1192019-10-08 Tom Tromey <tromey@adacore.com>
120
121 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
122
79bb1944
CB
1232019-10-08 Christian Biesinger <cbiesinger@google.com>
124
125 * gdbtypes.c (overload_debug): Move comment to header.
126 * gdbtypes.h (overload_debug): Declare.
127 * valops.c: Remove declaration of overload_debug, instead
128 include gdbtypes.h.
129
34916edc
CB
1302019-10-08 Christian Biesinger <cbiesinger@google.com>
131
132 * language.c (show_language_command): Pass lang_frame_mismatch_warn
133 through _().
134 (lang_frame_mismatch_warn): Make const, mark with N_(), and
135 move comment...
136 * language.h (lang_frame_mismatch_warn): ... here. Also add
137 declaration.
138 * top.c (lang_frame_mismatch_warn): Remove declaration.
139 (check_frame_language_change): Pass lang_frame_mismatch_warn
140 through _().
141
bad5c026
CB
1422019-10-07 Christian Biesinger <cbiesinger@google.com>
143
144 * c-lang.h (vtbl_ptr_name): Declare.
145 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
146 it from the header.
147 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
148
51f1fdc3
CB
1492019-10-07 Christian Biesinger <cbiesinger@google.com>
150
151 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
152 gdb_static_assert.
153
30d1f018
WP
1542019-10-07 Weimin Pan <weimin.pan@oracle.com>
155
606813d5
WP
156 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
157 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
158 * ctfread.c: New file.
159 * ctfread.h: New file.
160 * elfread.c: Include ctfread.h.
161 (struct elfinfo text_p): New member ctfsect.
162 (elf_locate_sections): Mark CTF section.
163 (elf_symfile_read): Call elfctf_build_psymtabs.
164 * Makefile.in (LIBCTF): Add.
165 (CLIBS): Use it.
166 (CDEPS): Likewise.
167 (DIST): Add ctfread.c.
606813d5
WP
168
1692019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
170
171 * ctfread.c (struct nextfield): Renamed to ...
172 (struct ctf_nextfield): ... this.
173 (struct field_info): Renamed to ...
174 (strut ctf_field_info): ... this.
175 (attach_fields_to_type): Update for renamed structures.
176 (ctf_add_member_cb): Likewise.
177 (ctf_add_enum_member_cb): Likewise.
178 (process_struct_members): Likewise.
179 (process_enum_type): Likewise.
30d1f018 180
518fe38c
WP
1812019-10-07 Weimin Pan <weimin.pan@oracle.com>
182
183 * tracectf.h: Rename, was ctf.h.
184 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
185 * tracefile.c: Likewise.
186 * tracepoint.c: Remove unused include ctf.h.
187 * mi/mi-main.c: Likewise.
188 * Makefile.in Replace ctf.c with tracectf.c.
189
225f296a
JB
1902019-10-06 Joel Brobecker <brobecker@adacore.com>
191
192 * version.in: Change version number to "9.0.50.DATE-git".
193
77c2dba3
TT
1942019-10-03 Tom Tromey <tom@tromey.com>
195
196 PR rust/24976:
197 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
198
179aed7f
AB
1992019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
200
201 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
202 cp_search_name_hash.
203 * NEWS: Add entry about nested function support.
204
0a4b0913
AB
2052019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
206 Andrew Burgess <andrew.burgess@embecosm.com>
207
208 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
209 for nested static variables when searchin VAR_DOMAIN.
210 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
211 global scope, update comment.
212 (add_partial_subprogram): Call add_partial_subprogram recursively
213 for nested subroutines when processinng Fortran.
214 (load_partial_dies): Process the child entities of a subprogram
215 when processing Fortran.
216 (partial_die_parent_scope): Handle building scope
217 for Fortran nested functions.
218 (process_die): Record that nested functions have a scope.
219 (new_symbol): Always record Fortran subprograms on the global
220 symbol list.
221 (determine_prefix): How to build the prefix for Fortran
222 subprograms.
223
d8c06f22
AB
2242019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
225
226 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
227 have just sent the thread a SIGSTOP and are waiting for it to
228 arrive.
229
a8b3b8e9
AB
2302019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
231
232 * btrace.c (btrace_add_pc): Remove whitespace before the template
233 parameter in 'std::vector <...>'.
234 (parse_xml_btrace_block): Likewise.
235 (btrace_maint_decode_pt): Likewise.
236 (btrace_maint_update_packets): Likewise.
237 (btrace_maint_print_packets): Likewise.
238 * btrace.h (struct btrace_maint_info): Likewise.
239 * dwarf2read.c (struct type_unit_group): Likewise.
240 (build_type_psymtabs_reader): Likewise.
241 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
242 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
243 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
244
4d825eab
TV
2452019-10-03 Tom de Vries <tdevries@suse.de>
246
247 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
248 the first line of the help text for set/show style metadata.
249
80fd2826
TT
2502019-10-02 Tom Tromey <tromey@adacore.com>
251
252 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
253 * gdbsupport/common-inferior.c: New file.
254 * infcmd.c (startup_with_shell): Don't define.
255 * nat/fork-inferior.h (startup_with_shell): Don't declare.
256 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
257 * inferior.h (startup_with_shell): Don't declare.
258
70054538
CB
2592019-10-02 Christian Biesinger <cbiesinger@google.com>
260
261 * gdbsupport/gdb_assert.h: Include errors.h.
262 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
263
37f6a7f4
TT
2642019-10-02 Tom Tromey <tromey@adacore.com>
265
266 * NEWS: Add $_ada_exception entry.
267 * ada-lang.c (struct ada_catchpoint): Add constructor.
268 <m_kind>: New member.
269 (allocate_location_exception, re_set_exception): Remove
270 "ex" parameter.
271 (should_stop_exception): Compute $_ada_exception.
272 (check_status_exception, print_it_exception)
273 (print_one_exception, print_mention_exception): Remove
274 "ex" parameter.
275 (allocate_location_catch_exception, re_set_catch_exception)
276 (check_status_exception, print_it_catch_exception)
277 (print_one_catch_exception, print_mention_catch_exception)
278 (print_recreate_catch_exception)
279 (allocate_location_catch_exception_unhandled)
280 (re_set_catch_exception_unhandled)
281 (check_status_exception, print_it_catch_exception_unhandled)
282 (print_one_catch_exception_unhandled)
283 (print_mention_catch_exception_unhandled)
284 (print_recreate_catch_exception_unhandled)
285 (allocate_location_catch_assert, re_set_catch_assert)
286 (check_status_assert, print_it_catch_assert)
287 (print_one_catch_assert, print_mention_catch_assert)
288 (print_recreate_catch_assert)
289 (allocate_location_catch_handlers, re_set_catch_handlers)
290 (check_status_handlers, print_it_catch_handlers)
291 (print_one_catch_handlers, print_mention_catch_handlers)
292 (print_recreate_catch_handlers): Remove.
293 (create_ada_exception_catchpoint): Update.
294 (initialize_ada_catchpoint_ops): Update.
295
fccf9de1
TT
2962019-10-02 Tom Tromey <tromey@adacore.com>
297
298 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
299 (create_excep_cond_exprs): Simplify exception string computation.
300 (ada_exception_catchpoint_cond_string): Likewise.
301
4b610737
TT
3022019-10-02 Tom Tromey <tromey@adacore.com>
303
304 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
305 * ada-lang.c (lesseq_defined_than): Handle
306 LOC_STATIC.
307 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
308 parameter.
309 (dwarf2_has_info): Likewise.
310 (new_symbol): Set maybe_copied on symbol when
311 appropriate.
312 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
313 parameter.
314 <can_copy>: New member.
315 * elfread.c (record_minimal_symbol): Set maybe_copied
316 on symbol when appropriate.
317 (elf_symfile_read): Update call to dwarf2_has_info.
318 * minsyms.c (lookup_minimal_symbol_linkage): New
319 function.
320 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
321 * symtab.c (get_symbol_address, get_msymbol_address):
322 New functions.
323 * symtab.h (get_symbol_address, get_msymbol_address):
324 Declare.
325 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
326 maybe_copied.
327 (struct symbol, struct minimal_symbol) <maybe_copied>:
328 New member.
329
1dd58850
TT
3302019-10-02 Tom Tromey <tromey@adacore.com>
331
332 * source.c (struct current_source_location): New.
333 (current_source_key): New global.
334 (current_source_symtab, current_source_line)
335 (current_source_pspace): Remove.
336 (get_source_location): New function.
337 (get_current_source_symtab_and_line)
338 (set_default_source_symtab_and_line)
339 (set_current_source_symtab_and_line)
340 (clear_current_source_symtab_and_line, select_source_symtab)
341 (info_source_command, print_source_lines_base)
342 (info_line_command, search_command_helper, _initialize_source):
343 Update.
344
5c281dbb
TT
3452019-10-02 Tom Tromey <tromey@adacore.com>
346
347 * source.c (select_source_symtab): Don't call
348 decode_line_with_current_source.
349
d3d32391
AB
3502019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
351
352 * symtab.c (lookup_global_symbol): Search global block.
353
38583298
TT
3542019-10-02 Tom Tromey <tromey@adacore.com>
355
356 * coffread.c (process_coff_symbol): Update.
357 * dwarf2read.c (var_decode_location, new_symbol): Update.
358 * mdebugread.c (parse_symbol): Update.
359 * objfiles.c (relocate_one_symbol): Update.
360 * stabsread.c (define_symbol, fix_common_block)
361 (scan_file_globals): Update.
362 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
363 (SET_SYMBOL_VALUE_ADDRESS): New macro.
364 * xcoffread.c (process_xcoff_symbol): Update.
365
9344c18f
AA
3662019-10-02 Andreas Arnez <arnez@linux.ibm.com>
367
368 * MAINTAINERS: Update my email address.
369
df07e2c7
AB
3702019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
371
372 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
373 std::vector.
374 (build_type_psymtabs_reader): Update for std::vector.
375 (build_type_psymtab_dependencies): Likewise.
376 * dwarf2read.h: Remove use of DEF_VEC_P.
377 (typedef sig_type_ptr): Delete.
378
554ac434
AB
3792019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
380
381 * btrace.c (btrace_maint_clear): Update to handle change from VEC
382 to std::vector.
383 (btrace_maint_decode_pt): Likewise, and move allocation of the
384 vector outside of the loop.
385 (btrace_maint_update_packets): Update to handle change from VEC to
386 std::vector.
387 (btrace_maint_print_packets): Likewise.
388 (maint_info_btrace_cmd): Likewise.
389 * btrace.h: Remove use of DEF_VEC_O.
390 (typedef btrace_pt_packet_s): Delete.
391 (struct btrace_maint_info) <packets>: Change fromm VEC to
392 std::vector.
393 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
394
46f29a9a
AB
3952019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
396
397 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
398 make accesses into the vector constant references.
399 (btrace_add_pc): Update for std::vector.
400 (btrace_stitch_bts): Likewise.
401 (parse_xml_btrace_block): Likewise.
402 (btrace_maint_update_packets): Likewise.
403 (btrace_maint_print_packets): Likewise.
404 (maint_info_btrace_cmd): Likewise.
405 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
406 std::vector.
407 (btrace_data::empty): Likewise.
408 (btrace_data_append): Likewise.
409 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
410 (typedef btrace_block_s): Delete.
411 (struct btrace_block): Add constructor.
412 (struct btrace_data_bts) <blocks>: Change to std::vector.
413 * nat/linux-btrace.c (perf_event_read_bts): Update for
414 std::vector.
415 (linux_read_bts): Likewise.
416
d770d56f
TT
4172019-10-01 Tom Tromey <tom@tromey.com>
418
419 * cli/cli-logging.c (show_logging_filename): Use styled_string.
420
9d636d67
TT
4212019-10-01 Tom Tromey <tom@tromey.com>
422
423 * stack.c (print_frame, info_frame_command_core): Use
424 styled_string.
425 * linux-thread-db.c (try_thread_db_load_1)
426 (try_thread_db_load_from_pdir_1): Use styled_string.
427 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
428 (auto_load_section_scripts, info_auto_load_local_gdbinit)
429 (maybe_print_unsupported_script_warning)
430 (maybe_print_script_not_found_warning): Use styled_string.
431 * ada-lang.c (user_select_syms): Use styled_string.
432
7f6aba03
TT
4332019-10-01 Tom Tromey <tom@tromey.com>
434
435 * p-lang.c (pascal_printstr): Use metadata style.
436 * value.c (show_convenience): Use metadata style.
437 * valprint.c (valprint_check_validity, val_print_optimized_out)
438 (val_print_not_saved, val_print_unavailable)
439 (val_print_invalid_address, generic_val_print, val_print)
440 (value_check_printable, val_print_array_elements): Use metadata
441 style.
442 * ui-out.h (class ui_out) <field_fmt>: New overload.
443 <do_field_fmt>: Add style parameter.
444 * ui-out.c (ui_out::field_fmt): New overload.
445 * typeprint.c (type_print_unknown_return_type)
446 (val_print_not_allocated, val_print_not_associated): Use metadata
447 style.
448 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
449 parameter.
450 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
451 * tracepoint.c (tvariables_info_1): Use metadata style.
452 * stack.c (print_frame_arg, print_frame_info, print_frame)
453 (info_frame_command_core): Use metadata style.
454 * skip.c (info_skip_command): Use metadata style.
455 * rust-lang.c (rust_print_enum): Use metadata style.
456 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
457 metadata style.
458 * python/py-framefilter.c (py_print_single_arg): Use metadata
459 style.
460 * printcmd.c (do_one_display, print_variable_and_value): Use
461 metadata style.
462 * p-valprint.c (pascal_val_print)
463 (pascal_object_print_value_fields): Use metadata style.
464 * p-typeprint.c (pascal_type_print_base): Use metadata style.
465 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
466 parameter.
467 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
468 * m2-valprint.c (m2_print_long_set): Use metadata style.
469 * m2-typeprint.c (m2_print_type): Use metadata style.
470 * infcmd.c (print_return_value_1): Use metadata style.
471 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
472 * f-valprint.c (info_common_command_for_block): Use metadata
473 style.
474 * f-typeprint.c (f_type_print_base): Use metadata style.
475 * expprint.c (print_subexp_standard): Use metadata style.
476 * cp-valprint.c (cp_print_value_fields): Use metadata style.
477 * cli/cli-style.h (class cli_style_option): Add constructor.
478 (metadata_style): Declare.
479 * cli/cli-style.c (metadata_style): New global.
480 (_initialize_cli_style): Register metadata style.
481 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
482 parameter.
483 * cli-out.c (cli_ui_out::do_field_fmt): Update.
484 * c-typeprint.c (c_type_print_base_struct_union)
485 (c_type_print_base_1): Use metadata style.
486 * breakpoint.c (watchpoint_value_print)
487 (print_one_breakpoint_location): Use metadata style.
488 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
489 style.
490 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
491 style.
492 * ada-valprint.c (val_print_packed_array_elements, printstr)
493 (print_field_values, ada_val_print_ref, ada_val_print): Use
494 metadata style.
495 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
496 style.
497 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
498 style.
499 * ada-lang.c (user_select_syms): Use metadata style.
500
14309bb6
TT
5012019-10-01 Tom Tromey <tom@tromey.com>
502
503 * cli/cli-cmds.c (pwd_command): Style output.
504
6a831f06
PA
5052019-10-01 Pedro Alves <palves@redhat.com>
506 Tom Tromey <tom@tromey.com>
507
508 * symtab.c (print_symbol_info): Use %ps.
509 (print_msymbol_info): Use %ps.
510 * symfile.c (symbol_file_add_with_addrs): Use %ps.
511 * printcmd.c (print_variable_and_value): Use %ps.
512 * macrocmd.c (show_pp_source_pos): Use %ps.
513 * infrun.c (print_exited_reason): Use ui_out::message.
514 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
515 (describe_other_breakpoints): Use ui_out::message and new
516 formats.
517 (say_where): Use new formats.
518 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
519 and new formats.
520
2a3c1174
PA
5212019-10-01 Pedro Alves <palves@redhat.com>
522 Tom Tromey <tom@tromey.com>
523
524 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
525 (test_gdb_formats): New function.
526 (run_tests): Call it.
527 (test_format_specifier): Update.
528 * utils.h (fputs_filtered): Update comment.
529 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
530 (fputs_styled_unfiltered): Declare.
531 * utils.c (fputs_styled_unfiltered): New function.
532 (vfprintf_maybe_filtered): Add gdbfmt parameter.
533 (vfprintf_filtered): Update.
534 (vfprintf_unfiltered, vprintf_filtered): Update.
535 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
536 * ui-out.h (enum ui_out_flag) <unfiltered_output,
537 disallow_ui_out_field>: New constants.
538 (enum class field_kind): New.
539 (struct base_field_s, struct signed_field_s): New.
540 (signed_field): New function.
541 (struct string_field_s): New.
542 (string_field): New function.
543 (struct styled_string_s): New.
544 (styled_string): New function.
545 (class ui_out) <message>: Add comment.
546 <vmessage, call_do_message>: New methods.
547 <do_message>: Add style parameter.
548 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
549 methods.
550 (ui_out::message): Rewrite.
551 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
552 parameter.
553 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
554 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
555 gdb_extensions parameter.
556 (class format_piece): Add parameter to constructor.
557 (n_int_args): New field.
558 * gdbsupport/format.c (format_pieces::format_pieces): Add
559 gdb_extensions parameter. Handle '*'.
560 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
561 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
562 vfprintf_styled_no_gdbfmt.
563 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
564 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
565 unfiltered output.
566 * ui-style.h (struct ui_file_style) <ptr>: New method.
567
0dfe5bfb
TT
5682019-10-01 Tom Tromey <tom@tromey.com>
569
570 * unittests/format_pieces-selftests.c: Update. Add final format.
571 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
572 empty literal pieces.
573
e43b10e1
TT
5742019-10-01 Tom Tromey <tom@tromey.com>
575
576 * ui-out.h (enum class ui_out_style_kind): Remove.
577 (class ui_out) <field_string, field_stsream, do_field_string>:
578 Change type of "style".
579 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
580 (ui_out::field_string): Update.
581 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
582 of "style".
583 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
584 * tracepoint.c (print_one_static_tracepoint_marker): Update.
585 * stack.c (print_frame_arg, print_frame_info, print_frame):
586 Update.
587 * source.c (print_source_lines_base): Update.
588 * solib.c (info_sharedlibrary_command): Update.
589 * skip.c (info_skip_command): Update.
590 * record-btrace.c (btrace_call_history_src_line)
591 (btrace_call_history): Update.
592 * python/py-framefilter.c (py_print_frame): Update.
593 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
594 "style".
595 * mi/mi-out.c (mi_ui_out::do_table_header)
596 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
597 (mi_ui_out::do_field_string): Update.
598 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
599 Update.
600 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
601 "style".
602 * cli-out.c (cli_ui_out::do_table_header)
603 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
604 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
605 (cli_ui_out::do_field_fmt): Update.
606 * breakpoint.c (print_breakpoint_location): Update.
607 (update_static_tracepoint): Update.
608
cd7c32c3
PW
6092019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
610
611 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
612 conversion of gdb_datadir.
613 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
614 remove not needed c_str ().
615
8fe0f950
AT
6162019-09-30 Ali Tamur <tamur@google.com>
617
618 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
619 (dwarf2_string_attr): Likewise.
620
5f48f8f3
AT
6212019-09-30 Ali Tamur <tamur@google.com>
622
623 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
624 (process_full_type_unit): Likewise.
625 (dump_die_shallow): Likewise.
626 (cu_debug_loc_section): Likewise.
627
6fb08628
CB
6282019-09-28 Christian Biesinger <cbiesinger@google.com>
629
630 * minsyms.c (compare_minimal_symbols): Rename to...
631 (minimal_symbol_is_less_than): ...this, and adjust to STL
632 conventions (return bool, take arguments as references)
633 (minimal_symbol_reader::install): Call std::sort instead
634 of qsort.
635
c7ee338a
CB
6362019-09-29 Christian Biesinger <cbiesinger@google.com>
637
638 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
639 hash and why.
640 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
641 msymbol_hash, msymbol_demangled_hash>: Improve comments.
642
703a86c2
SM
6432019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
644
645 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
646 * psympriv.h (add_psymbol_to_list): Move comment here and update
647 it.
648
0df0352a
TV
6492019-09-29 Tom de Vries <tdevries@suse.de>
650
651 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
652 Use $tmpdir/$(basename "$output_file").dwz instead of
653 "${output_file}.dwz".
654
ad75efa6
SM
6552019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
656
657 PR gdb/25045
658 * hppa-linux-nat.c: Include gdbarch.h.
659
ececd218
CB
6602019-09-26 Christian Biesinger <cbiesinger@google.com>
661
662 * blockframe.c (find_pc_partial_function): Change return type to bool.
663 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
664 * minsyms.c (in_gnu_ifunc_stub): Likewise.
665 (stub_gnu_ifunc_resolve_name): Likewise.
666 * symtab.c (compare_filenames_for_search): Likewise.
667 (compare_glob_filenames_for_search): Likewise.
668 (matching_obj_sections): Likewise.
669 (symbol_matches_domain): Likewise.
670 (find_line_symtab): Change out param EXACT_MATCH to bool *.
671 (find_line_pc): Change return type to bool.
672 (find_line_pc_range): Likewise.
673 (producer_is_realview): Likewise.
674 * symtab.h (symbol_matches_domain): Likewise.
675 (find_pc_partial_function): Likewise.
676 (find_pc_line_pc_range): Likewise.
677 (in_gnu_ifunc_stub): Likewise.
678 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
679 (find_line_pc): Likewise.
680 (find_line_pc_range): Likewise.
681 (matching_obj_sections): Likewise.
682 (find_line_symtab): Change out parameter to bool.
683 (producer_is_realview): Change return type to bool.
684 (compare_filenames_for_search): Likewise.
685 (compare_glob_filenames_for_search): Likewise.
686
27a900b8
TT
6872019-09-26 Tom Tromey <tom@tromey.com>
688
689 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
690 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
691 * gdb_usleep.h: Remove.
692 * gdb_usleep.c: Remove.
693 * utils.c: Don't include gdb_usleep.h.
694
5d63b30a
TT
6952019-09-26 Tom Tromey <tromey@adacore.com>
696
697 * python/py-type.c (type_to_type_object): Call check_typedef
698 for stub types.
699
12904d37
TT
7002019-09-26 Tom Tromey <tom@tromey.com>
701
702 * utils.h (initialize_utils): Don't declare.
703 * top.c (gdb_init): Don't call initialize_utils.
704 * utils.c (initialize_utils): Remove. Move contents...
705 (_initialize_utils): ... here.
706
858f25f0
TT
7072019-09-25 Tom Tromey <tom@tromey.com>
708
709 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
710 * utils.h (make_hex_string): Don't declare.
711 * utils.c (make_hex_string): Remove.
712
3d435220
TV
7132019-09-24 Tom de Vries <tdevries@suse.de>
714
715 PR gdb/23815
716 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
717 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
718
ddd44b70
DD
7192019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
720
721 * NEWS: Mention new simulator port for PRU.
722
f945dedf
CB
7232019-09-23 Christian Biesinger <cbiesinger@google.com>
724
725 * ada-exp.y (write_object_remaining): Update.
726 * ada-lang.c (ada_decode): Return a std::string instead of a char*
727 and eliminate the static buffer.
728 (ada_decode_symbol): Update.
729 (ada_la_decode): Update.
730 (ada_sniff_from_mangled_name): Update.
731 (is_valid_name_for_wild_match): Update.
732 (ada_lookup_name_info::matches): Update and simplify.
733 (name_matches_regex): Update.
734 (ada_add_global_exceptions): Update.
735 * ada-lang.h (ada_decode): Update signature.
736 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
737 * dwarf-index-write.c (debug_names::insert): Update.
738
7ab78ccb
SM
7392019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
740
741 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
742 formatting.
743
9252448b
SM
7442019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
745
746 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
747 Change "nonzero" to "true" in documentation.
748
626ca2c0
CB
7492019-09-20 Christian Biesinger <cbiesinger@google.com>
750
751 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
752 (_initialize_darwin_solib): Don't set
753 darwin_so_ops.lookup_lib_global_symbol.
754 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
755 set_gdbarch_iterate_over_objfiles_in_search_order.
756 (elf_lookup_lib_symbol): Rename to...
757 (svr4_iterate_over_objfiles_in_search_order): this, and update
758 to iterate semantics.
759 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
760 * solib.c (solib_global_lookup): Remove.
761 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
762 (solib_global_lookup): Remove.
763 * symtab.c (lookup_global_or_static_symbol): Remove call to
764 solib_global_lookup.
765
5a3a0d63
JB
7662019-09-20 Joel Brobecker <brobecker@adacore.com>
767
768 * NEWS: Move entries about default MI version now being
769 version 3, and about the GDB/MI fix for multi-location
770 breakpoints to the "since GDB 8.3" section.
771
ffea1427
JB
7722019-09-20 Joel Brobecker <brobecker@adacore.com>
773
774 GDB 8.3.1 released.
775
abf516c6
UW
7762019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
777
778 * NEWS: Mention that Cell/B.E. debugging support was removed.
779 * MAINTAINERS: Remove spu target.
780
781 * config/djgpp/fnchange.lst: Remove entries for removed files.
782
783 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
784 spu-multiarch.o, and spu-tdep.o.
785 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
786 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
787 spu-multiarch.c, and spu-tdep.c.
788 * spu-linux-nat.c: Remove file.
789 * spu-multiarch.c: Remove file.
790 * spu-tdep.c: Remove file.
791 * spu-tdep.h: Remove file.
792 * solib-spu.c: Remove file.
793 * solib-spu.h: Remove file.
794
795 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
796 * configure.nat (spu-linux): Remove.
797 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
798 solib-multiarch.o from gdb_target_obs.
799 (spu*-*-*): Remove.
800
801 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
802 feature flag.
803 (ppc_linux_no_features): Update.
804 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
805 Cell/B.E. support.
806 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
807 (tdesc_powerpc_cell64l): Likewise.
808 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
809 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
810 Cell/B.E. support.
811 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
812 Do not include "features/rs6000/powerpc-cell32l.c" or
813 "features/rs6000/powerpc-cell64l.c".
814 (ppc_linux_spu_section): Remove.
815 (ppc_linux_core_read_description): Remove Cell/B.E. support.
816 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
817 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
818 (ppc_linux_spe_context_lookup): Remove.
819 (ppc_linux_spe_context_inferior_created): Remove.
820 (ppc_linux_spe_context_solib_loaded): Remove.
821 (ppc_linux_spe_context_solib_unloaded): Remove.
822 (ppc_linux_spe_context): Remove.
823 (struct ppu2spu_cache): Remove.
824 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
825 (struct ppu2spu_data): Remove.
826 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
827 ppu2spu_unwind): Remove.
828 (ppc_linux_init_abi): Remove Cell/B.E. support.
829 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
830
831 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
832 (rs6000/powerpc-cell64l-expedite): Likewise
833 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
834 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
835 rs6000/powerpc-cell64l.xml.
836 * features/rs6000/powerpc-cell32l.xml: Remove.
837 * features/rs6000/powerpc-cell64l.xml: Likewise.
838 * features/rs6000/powerpc-cell32l.c: Remove generated file.
839 * features/rs6000/powerpc-cell64l.c: Likewise.
840 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
841 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
842 * regformats/reg-spu.dat: Remove.
843
844 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
845 * corelow.c (struct spuid_list): Remove.
846 (add_to_spuid_list): Remove.
847 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
848 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
849 (remote_protocol_features): Remove associated entries.
850 (_initialize_remote): No longer initialize them.
851 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
852 * linux-nat.c (SPUFS_MAGIC): Remove.
853 (linux_proc_xfer_spu): Remove.
854 (spu_enumerate_spu_ids): Remove.
855 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
856 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
857 (linux_make_corefile_notes): No longer call it.
858
859 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
860 (cooked_write_test): Likewise.
861
78e8cb91
TT
8622019-09-20 Tom Tromey <tom@tromey.com>
863
864 * NEWS: Mention case-sensitivity of TUI commands.
865 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
866 (tui_set_win_height_command, parse_scrolling_args): Likewise.
867 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
868
f074b67e
TT
8692019-09-20 Tom Tromey <tom@tromey.com>
870
871 * tui/tui-source.c (tui_source_window::set_contents): Use
872 make_unique_xstrdup.
873 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
874 make_unique_xstrdup.
875
63c4bf19
TT
8762019-09-20 Tom Tromey <tom@tromey.com>
877
878 * tui/tui-data.c: Remove separator comments.
879 * tui/tui-layout.c: Remove separator comments.
880 * tui/tui-win.c: Remove separator comments.
881 * tui/tui-wingeneral.c: Remove separator comments.
882
43df9b2f
TT
8832019-09-20 Tom Tromey <tom@tromey.com>
884
885 * tui/tui.h (strcat_to_buf): Don't declare.
886 * tui/tui.c (strcat_to_buf): Remove.
887
7226433c
TT
8882019-09-20 Tom Tromey <tom@tromey.com>
889
890 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
891 from "fullname".
892 * tui/tui-source.c (tui_source_window::set_contents)
893 (tui_source_window::location_matches_p)
894 (tui_source_window::maybe_update): Update.
895
80df3337
TT
8962019-09-20 Tom Tromey <tom@tromey.com>
897
898 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
899 Update.
900 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
901 prefix.
902 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
903 (tui_data_window::line_from_reg_element_no)
904 (tui_data_window::first_reg_element_no_inline)
905 (tui_data_window::show_registers)
906 (tui_data_window::show_register_group)
907 (tui_data_window::display_registers_from)
908 (tui_data_window::display_registers_from_line)
909 (tui_data_window::first_data_item_displayed)
910 (tui_data_window::delete_data_content_windows)
911 (tui_data_window::erase_data_content)
912 (tui_data_window::do_scroll_vertical)
913 (tui_data_window::refresh_window)
914 (tui_data_window::check_register_values): Update.
915
9923f347
TT
9162019-09-20 Tom Tromey <tom@tromey.com>
917
918 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
919 (struct tui_locator_window) <full_name, proc_name>: Now
920 std::string.
921 * tui/tui-stack.c (tui_locator_window::make_status_line)
922 (tui_locator_window::set_locator_fullname)
923 (tui_locator_window::set_locator_info): Update.
924 * tui/tui-source.c (tui_source_window::set_contents)
925 (tui_source_window::showing_source_p): Update.
926
b76251ab
TT
9272019-09-20 Tom Tromey <tom@tromey.com>
928
929 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
930 Don't call tui_locator_win_info_ptr.
931
0891be08
TT
9322019-09-20 Tom Tromey <tom@tromey.com>
933
934 * tui/tui-win.c (tui_resize_all): Don't call refresh.
935
1b935acf
TT
9362019-09-20 Tom Tromey <tom@tromey.com>
937
938 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
939 height for locator.
940 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
941 * tui/tui-layout.c (show_source_disasm_command, show_data)
942 (show_source_or_disasm_and_command): Use 1 as height for locator.
943
9abd8a65
TT
9442019-09-20 Tom Tromey <tom@tromey.com>
945
946 * tui/tui.c (tui_enable): Update.
947 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
948 Update.
949 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
950 Update.
951 * tui/tui-data.c (win_resized): Now bool.
952 (tui_win_resized): Return bool.
953 (tui_set_win_resized_to): Accept a bool.
954
b5457826
TT
9552019-09-20 Tom Tromey <tom@tromey.com>
956
957 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
958 Change type of "refresh_values_only".
959 * tui/tui-regs.c (tui_data_window::show_register_group): Change
960 type of "refresh_values_only".
961
6b915f7d
TT
9622019-09-20 Tom Tromey <tom@tromey.com>
963
964 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
965 std::string.
966 (tui_disassemble): Add "pos" parameter.
967 (tui_disasm_window::set_contents): Simplify.
968
2ad52f6f
TT
9692019-09-20 Tom Tromey <tom@tromey.com>
970
971 * tui/tui-winsource.h (struct tui_source_window_base)
972 <show_source_content>: Now private.
973 * tui/tui-winsource.c
974 (tui_source_window_base::show_source_content): Don't handle empty
975 content case.
976
b3b1bde6
TT
9772019-09-20 Tom Tromey <tom@tromey.com>
978
979 * tui/tui-layout.c (show_source_disasm_command)
980 (show_source_or_disasm_and_command): Don't call
981 show_source_content.
982
71a25ed2
TT
9832019-09-20 Tom Tromey <tom@tromey.com>
984
985 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
986 Declare.
987 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
988 from tui_make_status_line.
989 (tui_locator_window::rerender): Update.
990
f8532154
TT
9912019-09-20 Tom Tromey <tom@tromey.com>
992
993 * tui/tui-stack.c (tui_make_status_line): Return std::string.
994 (tui_locator_window::rerender): Update.
995
2d81b349
TT
9962019-09-20 Tom Tromey <tom@tromey.com>
997
998 * tui/tui-winsource.h (struct tui_source_window_base)
999 <~tui_source_window_base>: Don't declare.
1000 <fullname>: Remove.
1001 * tui/tui-winsource.c (~tui_source_window_base): Remove.
1002 * tui/tui-source.h (struct tui_source_window) <fullname>: New
1003 member.
1004 * tui/tui-source.c (tui_source_window::set_contents): Update.
1005 (tui_source_window::location_matches_p)
1006 (tui_source_window::maybe_update): Update.
1007
f14bec58
TT
10082019-09-20 Tom Tromey <tom@tromey.com>
1009
1010 * tui/tui-winsource.h (~tui_source_element): Remove.
1011 (tui_source_element): Update.
1012 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1013 * tui/tui-winsource.c (tui_show_source_line): Update.
1014 * tui/tui-source.c (tui_source_window::set_contents): Update.
1015 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1016
78d5933a
TT
10172019-09-20 Tom Tromey <tom@tromey.com>
1018
1019 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1020 declare.
1021 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1022 tui_clear_source_windows_detail.
1023 * tui/tui-winsource.h (struct tui_source_window_base)
1024 <clear_detail>: Don't declare.
1025 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1026 Remove.
1027 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1028
d4207696
TT
10292019-09-20 Tom Tromey <tromey@adacore.com>
1030
1031 PR ada/24919:
1032 * block.c (contained_in): Fix final return value.
1033
00f93c44
AM
10342019-09-20 Alan Modra <amodra@gmail.com>
1035
1036 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1037 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1038 (read_indirect_string_from_dwz): Use bfd accessor.
1039 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1040 * machoread.c (macho_symfile_read_all_oso): Likewise.
1041 * solib.c (solib_bfd_open): Likewise.
1042
e4153ae6
CB
10432019-09-19 Christian Biesinger <cbiesinger@google.com>
1044
1045 * eval.c: Move declaration of overload_resolution to...
1046 * value.h: ...here.
1047
c7ae7675
CB
10482019-09-19 Christian Biesinger <cbiesinger@google.com>
1049
1050 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1051 * arm-linux-tdep.c: Likewise.
1052 * arm-nbsd-nat.c: Likewise.
1053 * arm-tdep.h: Declare arm_apcs_32.
1054 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1055
e86f08d2
CB
10562019-09-19 Christian Biesinger <cbiesinger@google.com>
1057
1058 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1059 * dwarf2read.h: Declare dwarf_always_disassemble.
1060
f64e2f40
TV
10612019-09-19 Tom de Vries <tdevries@suse.de>
1062
1063 PR gdb/25009
1064 * source-cache.c (source_cache::ensure): Catch exception thrown during
1065 construction of the highlighter.
1066
fd361982
AM
10672019-09-18 Alan Modra <amodra@gmail.com>
1068
1069 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1070 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1071 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1072 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1073 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1074 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1075 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1076 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1077 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1078 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1079 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1080 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1081 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1082 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1083 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1084 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1085 * mi/mi-interp.c: Update throughout for bfd section macro and
1086 function changes.
1087 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1088 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1089
11061048
TT
10902019-09-18 Tom Tromey <tom@tromey.com>
1091
1092 * NEWS: Add entry.
1093 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1094 call rl_initialize.
1095 (tui_enable): Do not call rl_initialize.
1096
7a27b85f
CG
10972019-09-18 Christian Groessler <chris@groessler.org>
1098
1099 * alpha-linux-nat.c: Include gdbarch.h.
1100
f64eea3a
SM
11012019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1102
1103 * ui-file.c: Include cli/cli-style.h.
1104 (term_cli_styling): Remove cli_styling declaration.
1105
e6f7f6d1
AM
11062019-09-18 Alan Modra <amodra@gmail.com>
1107
1108 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1109 to bfd_asymbol_section.
1110
1d38e9d1
AM
11112019-09-18 Alan Modra <amodra@gmail.com>
1112
1113 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1114 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1115 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1116
90d92a63
AM
11172019-09-18 Alan Modra <amodra@gmail.com>
1118
1119 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1120 * spu-linux-nat.c (spu_bfd_open): Likewise.
1121
a3d181d2
CB
11222019-09-18 Christian Biesinger <cbiesinger@google.com>
1123
1124 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1125 to bool to match definition in dwarf2read.c.
1126
491144b5
CB
11272019-09-17 Christian Biesinger <cbiesinger@google.com>
1128
1129 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1130 (print_signatures): Likewise.
1131 (trust_pad_over_xvs): Likewise.
1132 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1133 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1134 * arm-linux-nat.c (arm_apcs_32): Likewise.
1135 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1136 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1137 * arm-tdep.c (arm_debug): Likewise.
1138 (arm_apcs_32): Likewise.
1139 * auto-load.c (debug_auto_load): Likewise.
1140 (auto_load_gdb_scripts): Likewise.
1141 (global_auto_load): Likewise.
1142 (auto_load_local_gdbinit): Likewise.
1143 (auto_load_local_gdbinit_loaded): Likewise.
1144 * auto-load.h (global_auto_load): Likewise.
1145 (auto_load_local_gdbinit): Likewise.
1146 (auto_load_local_gdbinit_loaded): Likewise.
1147 * breakpoint.c (disconnected_dprintf): Likewise.
1148 (breakpoint_proceeded): Likewise.
1149 (automatic_hardware_breakpoints): Likewise.
1150 (always_inserted_mode): Likewise.
1151 (target_exact_watchpoints): Likewise.
1152 (_initialize_breakpoint): Update.
1153 * breakpoint.h (target_exact_watchpoints): Change to bool.
1154 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1155 * cli/cli-cmds.c (trace_commands): Likewise.
1156 * cli/cli-cmds.h (trace_commands): Likewise.
1157 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1158 to bool*.
1159 * cli/cli-logging.c (logging_overwrite): Change to bool.
1160 (logging_redirect): Likewise.
1161 (debug_redirect): Likewise.
1162 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1163 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1164 to bool.
1165 <boolean_option_def>: Update.
1166 (struct flag_option_def): Change default type of Context to bool
1167 from int.
1168 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1169 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1170 (get_setshow_command_value_string): Likewise.
1171 * cli/cli-style.c (cli_styling): Change to bool.
1172 (source_styling): Likewise.
1173 * cli/cli-style.h (source_styling): Likewise.
1174 (cli_styling): Likewise.
1175 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1176 to bool.
1177 * command.h (var_types): Update comment.
1178 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1179 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1180 bool.
1181 (debug_compile_cplus_scopes): Likewise.
1182 * compile/compile-internal.h (compile_debug): Likewise.
1183 * compile/compile.c (compile_debug): Likewise.
1184 (struct compile_options) <raw>: Likewise.
1185 * cp-support.c (catch_demangler_crashes): Likewise.
1186 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1187 (usr_cmd_cris_dwarf2_cfi): Likewise.
1188 * csky-tdep.c (csky_debug): Likewise.
1189 * darwin-nat.c (enable_mach_exceptions): Likewise.
1190 * dcache.c (dcache_enabled_p): Likewise.
1191 * defs.h (info_verbose): Likewise.
1192 * demangle.c (demangle): Likewise.
1193 (asm_demangle): Likewise.
1194 * dwarf-index-cache.c (debug_index_cache): Likewise.
1195 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1196 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1197 * dwarf2read.c (check_physname): Likewise.
1198 (use_deprecated_index_sections): Likewise.
1199 (dwarf_always_disassemble): Likewise.
1200 * eval.c (overload_resolution): Likewise.
1201 * event-top.c (set_editing_cmd_var): Likewise.
1202 (exec_done_display_p): Likewise.
1203 * event-top.h (set_editing_cmd_var): Likewise.
1204 (exec_done_display_p): Likewise.
1205 * exec.c (write_files): Likewise.
1206 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1207 (debug_fbsd_nat): Likewise.
1208 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1209 Likewise.
1210 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1211 <backtrace_past_entry> Likewise.
1212 * gdb-demangle.h (demangle): Likewise.
1213 (asm_demangle): Likewise.
1214 * gdb_bfd.c (bfd_sharing): Likewise.
1215 * gdbcore.h (write_files): Likewise.
1216 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1217 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1218 * gdbthread.h (print_thread_events): Likewise.
1219 * gdbtypes.c (opaque_type_resolution): Likewise.
1220 (strict_type_checking): Likewise.
1221 * gnu-nat.c (gnu_debug_flag): Likewise.
1222 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1223 * guile/scm-param.c (pascm_variable): Add boolval.
1224 (add_setshow_generic): Update.
1225 (pascm_param_value): Update.
1226 (pascm_set_param_value_x): Update.
1227 * hppa-tdep.c (hppa_debug): Change to bool..
1228 * infcall.c (may_call_functions_p): Likewise.
1229 (coerce_float_to_double_p): Likewise.
1230 (unwind_on_signal_p): Likewise.
1231 (unwind_on_terminating_exception_p): Likewise.
1232 * infcmd.c (startup_with_shell): Likewise.
1233 * inferior.c (print_inferior_events): Likewise.
1234 * inferior.h (startup_with_shell): Likewise.
1235 (print_inferior_events): Likewise.
1236 * infrun.c (step_stop_if_no_debug): Likewise.
1237 (detach_fork): Likewise.
1238 (debug_displaced): Likewise.
1239 (disable_randomization): Likewise.
1240 (non_stop): Likewise.
1241 (non_stop_1): Likewise.
1242 (observer_mode): Likewise.
1243 (observer_mode_1): Likewise.
1244 (set_observer_mode): Update.
1245 (sched_multi): Change to bool.
1246 * infrun.h (debug_displaced): Likewise.
1247 (sched_multi): Likewise.
1248 (step_stop_if_no_debug): Likewise.
1249 (non_stop): Likewise.
1250 (disable_randomization): Likewise.
1251 * linux-tdep.c (use_coredump_filter): Likewise.
1252 (dump_excluded_mappings): Likewise.
1253 * linux-thread-db.c (auto_load_thread_db): Likewise.
1254 (check_thread_db_on_load): Likewise.
1255 * main.c (captured_main_1): Update.
1256 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1257 xx2_opt, boolean_opt>: Change to bool.
1258 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1259 * maint.c (maintenance_profile_p): Likewise.
1260 (per_command_time): Likewise.
1261 (per_command_space): Likewise.
1262 (per_command_symtab): Likewise.
1263 * memattr.c (inaccessible_by_default): Likewise.
1264 * mi/mi-main.c (mi_async): Likewise.
1265 (mi_async_1): Likewise.
1266 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1267 * nat/fork-inferior.h (startup_with_shell): Likewise.
1268 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1269 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1270 * nios2-tdep.c (nios2_debug): Likewise.
1271 * or1k-tdep.c (or1k_debug): Likewise.
1272 * parse.c (parser_debug): Likewise.
1273 * parser-defs.h (parser_debug): Likewise.
1274 * printcmd.c (print_symbol_filename): Likewise.
1275 * proc-api.c (procfs_trace): Likewise.
1276 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1277 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1278 (set_parameter_value): Update.
1279 (add_setshow_generic): Update.
1280 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1281 to bool*.
1282 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1283 int*.
1284 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1285 * record-btrace.c (record_btrace_target::store_registers): Update.
1286 * record-full.c (record_full_memory_query): Change to bool.
1287 (record_full_stop_at_limit): Likewise.
1288 * record-full.h (record_full_memory_query): Likewise.
1289 * remote-notif.c (notif_debug): Likewise.
1290 * remote-notif.h (notif_debug): Likewise.
1291 * remote.c (use_range_stepping): Likewise.
1292 (interrupt_on_connect): Likewise.
1293 (remote_break): Likewise.
1294 * ser-tcp.c (tcp_auto_retry): Likewise.
1295 * ser-unix.c (serial_hwflow): Likewise.
1296 * skip.c (debug_skip): Likewise.
1297 * solib-aix.c (solib_aix_debug): Likewise.
1298 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1299 (spu_auto_flush_cache_p): Likewise.
1300 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1301 Likewise.
1302 (struct info_print_options) <quiet>: Likewise.
1303 * symfile-debug.c (debug_symfile): Likewise.
1304 * symfile.c (auto_solib_add): Likewise.
1305 (separate_debug_file_debug): Likewise.
1306 * symfile.h (auto_solib_add): Likewise.
1307 (separate_debug_file_debug): Likewise.
1308 * symtab.c (basenames_may_differ): Likewise.
1309 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1310 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1311 (struct info_types_options) <quiet>: Likewise.
1312 * symtab.h (demangle): Likewise.
1313 (basenames_may_differ): Likewise.
1314 * target-dcache.c (stack_cache_enabled_1): Likewise.
1315 (code_cache_enabled_1): Likewise.
1316 * target.c (trust_readonly): Likewise.
1317 (may_write_registers): Likewise.
1318 (may_write_memory): Likewise.
1319 (may_insert_breakpoints): Likewise.
1320 (may_insert_tracepoints): Likewise.
1321 (may_insert_fast_tracepoints): Likewise.
1322 (may_stop): Likewise.
1323 (auto_connect_native_target): Likewise.
1324 (target_stop_and_wait): Update.
1325 (target_async_permitted): Change to bool.
1326 (target_async_permitted_1): Likewise.
1327 (may_write_registers_1): Likewise.
1328 (may_write_memory_1): Likewise.
1329 (may_insert_breakpoints_1): Likewise.
1330 (may_insert_tracepoints_1): Likewise.
1331 (may_insert_fast_tracepoints_1): Likewise.
1332 (may_stop_1): Likewise.
1333 * target.h (target_async_permitted): Likewise.
1334 (may_write_registers): Likewise.
1335 (may_write_memory): Likewise.
1336 (may_insert_breakpoints): Likewise.
1337 (may_insert_tracepoints): Likewise.
1338 (may_insert_fast_tracepoints): Likewise.
1339 (may_stop): Likewise.
1340 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1341 (make_thread_apply_all_options_def_group): Change argument from int*
1342 to bool*.
1343 (thread_apply_all_command): Update.
1344 (print_thread_events): Change to bool.
1345 * top.c (confirm): Likewise.
1346 (command_editing_p): Likewise.
1347 (history_expansion_p): Likewise.
1348 (write_history_p): Likewise.
1349 (info_verbose): Likewise.
1350 * top.h (confirm): Likewise.
1351 (history_expansion_p): Likewise.
1352 * tracepoint.c (disconnected_tracing): Likewise.
1353 (circular_trace_buffer): Likewise.
1354 * typeprint.c (print_methods): Likewise.
1355 (print_typedefs): Likewise.
1356 * utils.c (debug_timestamp): Likewise.
1357 (sevenbit_strings): Likewise.
1358 (pagination_enabled): Likewise.
1359 * utils.h (sevenbit_strings): Likewise.
1360 (pagination_enabled): Likewise.
1361 * valops.c (overload_resolution): Likewise.
1362 * valprint.h (struct value_print_options) <prettyformat_arrays,
1363 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1364 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1365 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1366 Likewise.
1367 * windows-nat.c (new_console): Likewise.
1368 (cygwin_exceptions): Likewise.
1369 (new_group): Likewise.
1370 (debug_exec): Likewise.
1371 (debug_events): Likewise.
1372 (debug_memory): Likewise.
1373 (debug_exceptions): Likewise.
1374 (useshell): Likewise.
1375 * windows-tdep.c (maint_display_all_tib): Likewise.
1376 * xml-support.c (debug_xml): Likewise.
1377
f1b620e9
MG
13782019-09-17 Mike Gulick <mgulick@mathworks.com>
1379
1380 * source.c (prepare_path_for_appending): New function.
1381 (openp): Make use of new function.
1382 (find_and_open_source): Search for the compilation directory and
1383 source file as a relative path beneath the directory search path.
1384
67f3ed6a
AB
13852019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1386
1387 * source-cache.c (source_cache::get_line_charpos): Catch
1388 exceptions and return false, this matches the behaviour documented
1389 in the header file.
1390
74332189
JB
13912019-09-17 Joel Brobecker <brobecker@adacore.com>
1392
1393 * ada-tasks.c (info_task): Remove quoting of the task's name.
1394
f2f24aa9
CB
13952019-09-16 Christian Biesinger <cbiesinger@google.com>
1396
1397 * symfile.c (auto_solib_add): Replace comment with a reference
1398 to the header file.
1399
6a062a93
CB
14002019-09-14 Christian Biesinger <cbiesinger@google.com>
1401
1402 * NEWS: Mention that gdb can now be compiled with Python 3
1403 on Windows.
1404
ec6c8338
AB
14052019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1406
1407 * maint.c (maint_print_section_data::maint_print_section_data):
1408 Force use of 'float log10 (float)' by casting the argument to
1409 float.
1410
aa17805f
AB
14112019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1412
1413 * maint.c: Add 'cmath' include.
1414 (struct maint_print_section_data): New structure.
1415 (print_section_index): New function.
1416 (print_bfd_section_info): Add header comment, small whitespace
1417 cleanup, and update to call new print_section_index function.
1418 (print_objfile_section_info): Likewise.
1419 (maint_obj_section_from_bfd_section): New function.
1420 (print_bfd_section_info_maybe_relocated): New function.
1421 (maintenance_info_sections): Add header comment, always use
1422 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1423
3dd9bb46
AB
14242019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1425
1426 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1427 inner scope, add check that the objfile has psymtabs before
1428 checking psymtabs_addrmap.
1429 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1430
4993045d
PW
14312019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1432
1433 * NEWS: Announce that Ada task names are now shown at more places,
1434 and between quotes (except in info task output).
1435 * gdb/ada-tasks.c (task_to_str): New function.
1436 (display_current_task_id): Call task_to_str.
1437 (task_command_1): Likewise.
1438 (print_ada_task_info): In non-mi mode, Properly align headers and data
1439 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1440
7a289707
RO
14412019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1442
1443 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1444 prstatus.pr_lwp.pr_info instead of making it up.
1445
f2aec7f6
CB
14462019-09-11 Christian Biesinger <cbiesinger@google.com>
1447
1448 * auto-load.c (auto_load_expand_dir_vars): Update.
1449 * defs.h (gdb_datadir): Change to std::string.
1450 (python_libdir): Likewise.
1451 (relocate_gdb_directory): Change return type to std::string.
1452 * guile/guile.c (gdbscm_data_directory): Update.
1453 (initialize_scheme_side): Update.
1454 * jit.c (jit_reader_dir): Change to std::string.
1455 (jit_reader_load_command): Update.
1456 * main.c (gdb_datadir): Change to std::string.
1457 (python_libdir): Likewise.
1458 (set_gdb_data_directory): Update.
1459 (relocate_path): Change to return std::string.
1460 (relocate_gdb_directory): Change to return std::string.
1461 (relocate_gdbinit_path_maybe_in_datadir): Update.
1462 (captured_main_1): Update.
1463 * python/python.c (do_start_initialization): Update.
1464 * top.c (show_gdb_datadir): Update.
1465 * xml-syscall.c (xml_init_syscalls_info): Update.
1466 (init_syscalls_info): Update.
1467
9224a013
CB
14682019-09-11 Christian Biesinger <cbiesinger@google.com>
1469
1470 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1471 out of get_init_files.
1472 (get_init_files): Update.
1473
f48cd836
CB
14742019-09-11 Christian Biesinger <cbiesinger@google.com>
1475
1476 * main.c (get_init_files): Change to use std::string.
1477 (captured_main_1): Update.
1478 (print_gdb_help): Update.
1479
9cab7ecd
AT
14802019-09-11 Ali Tamur <tamur@google.com>
1481
1482 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1483 implementation.
1484
67547d89
CB
14852019-09-11 Christian Biesinger <cbiesinger@google.com>
1486
1487 * dbxread.c (read_dbx_symtab): Update.
1488 * dwarf2read.c (load_partial_dies): Update.
1489 * mdebugread.c (parse_partial_symbols): Update.
1490 (handle_psymbol_enumerators): Update.
1491 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1492 * psymtab.c (add_psymbol_to_bcache): Likewise.
1493 (add_psymbol_to_list): Likewise.
1494 * symtab.c (symbol_set_names): Likewise.
1495 * symtab.h (symbol_set_names): Likewise.
1496 * xcoffread.c (scan_xcoff_symtab): Update.
1497
64b2d4a0
TT
14982019-09-11 Tom Tromey <tom@tromey.com>
1499
1500 * symfile-mem.c (symbol_file_add_from_memory): Use
1501 bfd_set_filename.
1502 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1503 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1504
3b00ef10
TT
15052019-09-10 Tom Tromey <tromey@adacore.com>
1506
1507 * dwarf-index-write.c (write_psymbols): Extend error message.
1508 (debug_names::insert): Add Ada code.
1509 (debug_names::write_psymbols): Remove Ada check.
1510 (debug_names) <m_string_obstack>: New member.
1511 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1512 (gdb_index_symbol_name_matcher::matches): Remove.
1513 (mapped_index_base::find_name_components_bounds): Add "lang"
1514 parameter.
1515 (mapped_index_base::build_name_components): Also split names
1516 according to Ada syntax.
1517 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
1518 type of "match_callback".
1519 (check_match, check_find_bounds_finds)
1520 (dw2_expand_symtabs_matching): Update.
1521 (dw2_debug_names_iterator): Add new constructor.
1522 (dw2_debug_names_map_matching_symbols): New function.
1523 (dw2_debug_names_expand_symtabs_matching): Update.
1524 (dwarf2_debug_names_functions): Use
1525 dw2_debug_names_map_matching_symbols.
1526
aa391654
TT
15272019-09-10 Tom Tromey <tromey@adacore.com>
1528
1529 * dwarf2read.c (dw2_get_file_names_reader): Add the
1530 CU's file name to the results.
1531
b054970d
TT
15322019-09-10 Tom Tromey <tromey@adacore.com>
1533
1534 * ada-lang.c (add_nonlocal_symbols): Combine calls to
1535 map_matching_symbols. Update.
1536 * dwarf2read.c (dw2_map_matching_symbols): Update.
1537 * psymtab.c (match_partial_symbol): Change type; update.
1538 (psym_map_matching_symbols): Likewise.
1539 * symfile-debug.c (debug_qf_map_matching_symbols): Change
1540 type; update.
1541 * symfile.h (struct quick_symbol_functions)
1542 <map_matching_symbols>: Change "name" to be a lookup_name_info.
1543 Remove "match".
1544
6a3dbf1b
TT
15452019-09-10 Tom Tromey <tromey@adacore.com>
1546
1547 * psymtab.c (map_block): Remove.
1548 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1549 * symtab.c (iterate_over_symbols_terminated): New function.
1550 * symtab.c (iterate_over_symbols_terminated): Declare.
1551
6969f124
TT
15522019-09-10 Tom Tromey <tromey@adacore.com>
1553
1554 * ada-lang.c (ada_iterate_over_symbols): Return bool.
1555 * language.h (struct language_defn) <la_iterate_over_symbols>:
1556 Return bool.
1557 * symtab.c (iterate_over_symbols): Return bool.
1558 * symtab.h (iterate_over_symbols): Return bool.
1559
199b4314
TT
15602019-09-10 Tom Tromey <tromey@adacore.com>
1561
1562 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1563 (add_nonlocal_symbols): Update.
1564 * dwarf2read.c (dw2_map_matching_symbols): Change type.
1565 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1566 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1567 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1568 Change type of "callback". Remove "data".
1569
a084a2a6
AT
1570
15712019-09-09 Ali Tamur <tamur@google.com>
1572
1573 * dwarf2read.c (comp_unit_head): Update comment.
1574 (dwarf2_dwo_name): New function declaration.
1575 (dwarf_unit_type_name): New function declaration.
1576 (read_comp_unit_head): Add support for new compilation units,
1577 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1578 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1579 (currently named as "signature") in their header. Also clarify error
1580 messages.
1581 (lookup_dwo_id): New function. Returns the dwo id of the given
1582 compile unit.
1583 (lookup_dwo_unit): Use the new lookup_dwo_id function.
1584 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1585 functions.
1586 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1587 (dwarf2_dwo_name): Get the dwo name if present.
1588 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1589 purposes.
1590
25a2915e
TT
15912019-09-09 Tom Tromey <tom@tromey.com>
1592
1593 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1594
e4df0874
PW
15952019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1596
1597 * python/python.c (do_start_initialization): Make progname_copy static,
1598 to avoid a leak report.
1599
8634b462
TT
16002019-09-08 Tom Tromey <tom@tromey.com>
1601
1602 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1603
c7f839cb
SM
16042019-09-07 Simon Marchi <simon.marchi@efficios.com>
1605
1606 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1607 Change type to gdb::optional<block_enum>.
1608 (dw2_symtab_iter_init): Change block_index parameter type
1609 to gdb::optional<block_enum>.
1610 (dw2_lookup_symbol): Change block_index parameter
1611 type to block_enum.c
1612 (dw2_debug_names_lookup_symbol): Likewise.
1613 * psymtab.c (psym_lookup_symbol): Likewise.
1614 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1615 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1616 Likewise.
1617
ead0e69a
CB
16182019-09-06 Christian Biesinger <cbiesinger@google.com>
1619
1620 * defs.h (relocate_gdb_directory): Change int to bool in
1621 signature and rename flag to relocatable.
1622 * main.c (relocate_path): Likewise.
1623 (relocate_gdb_directory): Likewise.
1624
b16c44de
AM
16252019-09-06 Alan Modra <amodra@gmail.com>
1626
1627 * coffread.c (coff_symfile_read): Constify filename variable.
1628 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1629 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1630 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1631 * solib.c (reload_shared_libraries_1): Likewise.
1632 * symfile.c (reread_symbols): Likewise.
1633 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1634 * solib-darwin.c (darwin_bfd_open): Likewise.
1635 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1636
06ff036e
AB
16372019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
1638
1639 * psymtab.c (print_partial_symbols): Handle missing domain_enum
1640 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1641
4e962e74
TT
16422019-09-03 Tom Tromey <tromey@adacore.com>
1643
1644 * ada-valprint.c (ada_val_print_num): Don't recurse for range
1645 types.
1646 (has_negatives): Unbias a range type bound.
1647 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1648 * gdbtypes.c (operator==): Handle new field.
1649 (create_range_type): Add "bias" parameter.
1650 (create_static_range_type, resolve_dynamic_range): Update.
1651 * gdbtypes.h (struct range_bounds) <bias>: New member.
1652 (create_range_type): Add bias parameter.
1653 * printcmd.c (print_scalar_formatted): Unbias range types.
1654 * value.c (unpack_long): Unbias range types.
1655 (pack_long): Bias range types.
1656
d90b8f26
AH
16572019-09-02 Alan Hayward <alan.hayward@arm.com>
1658
1659 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1660 probe arguments.
1661
fe01123e
AH
16622019-09-02 Alan Hayward <alan.hayward@arm.com>
1663
1664 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1665 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1666 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1667 (compile_probe_arg): Likewise.
1668 * probe.h (get_argument_count): Likewise.
1669 * solib-svr4.c (solib_event_probe_action): Likewise.
1670 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1671
e661ef01
AH
16722019-09-02 Alan Hayward <alan.hayward@arm.com>
1673
1674 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1675 code to here...
1676 (svr4_create_solib_event_breakpoints): ...from here.
1677
47a536d9
SDJ
16782019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1679
1680 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1681 suffix from warning message.
1682
d6a00eba
TT
16832019-08-30 Tom Tromey <tom@tromey.com>
1684
1685 * tui/tui-winsource.h (struct tui_source_window_base)
1686 <refresh_all>: Don't declare.
1687 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1688 Remove.
1689 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1690 tui_show_locator_content.
1691 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1692 declare.
1693 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1694 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1695 declare.
1696
55b2657b
TT
16972019-08-30 Tom Tromey <tom@tromey.com>
1698
1699 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1700
12a8555a
TT
17012019-08-30 Tom Tromey <tom@tromey.com>
1702
1703 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1704 Remove unnecessary forward declarations.
1705
900ac242
TT
17062019-08-30 Tom Tromey <tom@tromey.com>
1707
1708 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1709 rerender.
1710 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1711 tui_show_locator_content.
1712
99ab33fb
TT
17132019-08-30 Tom Tromey <tom@tromey.com>
1714
1715 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1716 (tui_locator_window::rerender): Rewrite using body of previous
1717 tui_show_locator_content.
1718
e594a5d1
TT
17192019-08-30 Tom Tromey <tom@tromey.com>
1720
1721 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1722 set_locator_fullname>: New methods.
1723 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1724 Rename from tui_set_locator_fullname.
1725 (tui_locator_window::set_locator_info): Rename from
1726 tui_set_locator_info. Return bool.
1727 (tui_update_locator_fullname, tui_show_frame_info): Update.
1728
715bb467
TT
17292019-08-30 Tom Tromey <tom@tromey.com>
1730
1731 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1732
772f3f03
TT
17332019-08-30 Tom Tromey <tom@tromey.com>
1734
1735 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1736 call touchwin.
1737
108e13ab
TT
17382019-08-30 Tom Tromey <tom@tromey.com>
1739
1740 * tui/tui-wingeneral.c (box_win): Assume win_info and
1741 win_info->handle cannot be NULL.
1742
cdaa6eb4
TT
17432019-08-30 Tom Tromey <tom@tromey.com>
1744
1745 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1746 refresh_window>: Declare.
1747 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1748 resize.
1749 (tui_data_item_window::rerender): Rename from
1750 tui_display_register.
1751 (tui_data_item_window::refresh_window): New method.
1752 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1753 no-op.
1754
89df7f90
TT
17552019-08-30 Tom Tromey <tom@tromey.com>
1756
1757 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1758 regs_column_count, current_group>: Move later. Now private.
1759 <get_current_group>: New method.
1760 * tui/tui-regs.c (tui_reg_command): Update.
1761 * tui/tui-layout.c (tui_set_layout): Update.
1762
1bf2866a
TT
17632019-08-30 Tom Tromey <tom@tromey.com>
1764
1765 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1766 (tui_data_window::rerender): Don't call
1767 check_and_display_highlight_if_needed.
1768 (tui_data_window::refresh_all): Remove call to
1769 erase_data_content.
1770
0670413d
TT
17712019-08-30 Tom Tromey <tom@tromey.com>
1772
1773 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1774 (tui_data_window::display_registers_from)
1775 (tui_data_window::display_reg_element_at_line)
1776 (tui_data_window::display_registers_from_line): Remove checks of
1777 "empty".
1778
18bb55c7
TT
17792019-08-30 Tom Tromey <tom@tromey.com>
1780
1781 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1782 Don't declare.
1783 * tui/tui-regs.c (tui_data_window::show_registers): Call
1784 rerender.
1785 (tui_data_window::rerender): Rename from display_all_data.
1786 (tui_data_window::rerender): Remove old implementation.
1787
1f6d2f10
TT
17882019-08-30 Tom Tromey <tom@tromey.com>
1789
1790 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1791 text.
1792 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1793
16d01f9c
BW
17942019-08-29 Bernhard Wodok <barto@gmx.net>
1795 Sergio Durigan Junior <sergiodj@redhat.com>
1796
1797 PR win32/24284
1798 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1799
d8f27c60
AB
18002019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1801
1802 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1803 when searching for types.
1804
1f20c35e
AB
18052019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1806
1807 * f-lang.c (f_language_defn): Use f_print_typedef.
1808 * f-lang.h (f_print_typedef): Declare.
1809 * f-typeprint.c (f_print_typedef): Define.
1810
550105b7
CB
18112019-08-27 Christian Biesinger <cbiesinger@google.com>
1812
1813 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1814
4acfdd20
AB
18152019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1816
1817 * cli/cli-utils.c (info_print_options_defs): Delete.
1818 (make_info_print_options_def_group): Delete.
1819 (extract_info_print_options): Delete.
1820 (info_print_command_completer): Delete.
1821 (info_print_args_help): Add extra parameter, and optionally
1822 include text about -n flag.
1823 * cli/cli-utils.h (struct info_print_options): Delete.
1824 (extract_info_print_options): Delete declaration.
1825 (info_print_command_completer): Delete declaration.
1826 (info_print_args_help): Add extra parameter, extend header
1827 comment.
1828 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1829 search_symbols.
1830 * stack.c (struct info_print_options): New type.
1831 (info_print_options_defs): New file scoped variable.
1832 (make_info_print_options_def_group): New static function.
1833 (info_print_command_completer): New static function.
1834 (info_locals_command): Update to use new local functions.
1835 (info_args_command): Likewise.
1836 (_initialize_stack): Add extra parameter to calls to
1837 info_print_args_help.
1838 * symtab.c (search_symbols): Add extra parameter, use this to
1839 possibly excluse non-debug symbols.
1840 (symtab_symbol_info): Add extra parameter, which is passed on to
1841 search_symbols.
1842 (struct info_print_options): New type.
1843 (info_print_options_defs): New file scoped variable.
1844 (make_info_print_options_def_group): New static function.
1845 (info_print_command_completer): New static function.
1846 (info_variables_command): Update to use local functions, and pass
1847 extra parameter through to symtab_symbol_info.
1848 (info_functions_command): Likewise.
1849 (info_types_command): Pass additional argument through to
1850 symtab_symbol_info.
1851 (rbreak_command): Pass extra argument to search_symbols.
1852 (_initialize_symtab): Add extra arguments for calls to
1853 info_print_args_help, and update help text for 'info variables',
1854 'whereis', and 'info functions' commands.
1855 * symtab.h (search_symbols): Add extra argument to declaration.
1856 * NEWS: Mention new flags.
1857
9aa55206
CB
18582019-08-26 Christian Biesinger <cbiesinger@google.com>
1859
1860 * symtab.c (lookup_static_symbol): Call the new function (and move
1861 it down to be next to lookup_global_symbol).
1862 (struct global_sym_lookup_data): Add block_enum member and rename to...
1863 (struct global_or_static_sym_lookup_data): ...this.
1864 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1865 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1866 (lookup_symbol_global_or_static_iterator_cb): ...this.
1867 (lookup_global_or_static_symbol): New function.
1868 (lookup_global_symbol): Call new function.
1869
5c31b358
TV
18702019-08-26 Tom de Vries <tdevries@suse.de>
1871
1872 PR c++/24852
1873 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1874 when pc_probe.prob == NULL.
1875
23c13d42
SM
18762019-08-25 Simon Marchi <simon.marchi@efficios.com>
1877
1878 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1879 variable symbol_linkage to symbol_linkage_.
1880
beadd3e8
SM
18812019-08-25 Simon Marchi <simon.marchi@efficios.com>
1882
1883 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1884 represent whether the symbol is static, dynamic, or we don't
1885 know.
1886
e3ec872f
YS
18872019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1888
1889 * gdb/rx-tdep.c (rx_register_names): New.
1890 (rx_register_name): Delete.
1891 (rx_psw_type): Delete.
1892 (rx_fpsw_type): Delete.
1893 (rx_register_type): Delete.
1894 (rx_gdbarch_init): Convert target-descriptions.
1895 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1896 * gdb/features/Makefile: Add rx.xml.
1897 * gdb/features/rx.xml: New.
1898 * gdb/features/rx.c: Generated.
1899 * gdb/NEWS: Mention target description support.
1900
d0509ba4
CB
19012019-08-22 Christian Biesinger <cbiesinger@google.com>
1902
1903 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1904 *slot_ptr.
1905
2d41fa11
SDJ
19062019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1907
1908 * configure.ac: Don't check for 'dlfcn.h' (moved to
1909 gdbsupport/common.m4).
1910 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1911 'gdbsupport/'.
1912 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1913 * compile/compile-c-support.c: Include
1914 'gdbsupport/gdb-dlfcn.h'.
1915 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1916 * gdb-dlfcn.c: Move to...
1917 * gdbsupport/gdb-dlfcn.c: ... here.
1918 * gdb-dlfcn.h: Move to...
1919 * gdbsupport/gdb-dlfcn.h: ... here.
1920
de8af808
SL
19212019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1922
1923 * nios2-tdep.c (struct reg_value): Improve comments. Make
1924 the offset field signed.
1925
27204489
CB
19262019-08-22 Christian Biesinger <cbiesinger@google.com>
1927
1928 * python/lib/gdb/__init__.py (_execute_file): New function.
1929 * python/python.c (python_run_simple_file): Call gdb._execute_file
1930 on Windows.
1931
43771869
AB
19322019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1933
1934 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1935 all uses as this was never set to anything but a zero value.
1936
26c957f1
PA
19372019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1938
1939 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1940
c07aae6e
CB
19412019-08-21 Christian Biesinger <cbiesinger@google.com>
1942
1943 * tui/tui-data.h (tui_gen_win_info): Add an =default
1944 move constructor, required by some GCC versions.
1945
3960cb7a
JF
19462019-08-21 Jinke Fan <fanjinke51@yeah.net>
1947
1948 * go32-nat.c (go32_sysinfo): Add hygon_p.
1949
04c72a68
TT
19502019-08-20 Tom Tromey <tom@tromey.com>
1951
1952 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1953 line_from_reg_element_no, first_reg_element_no_inline,
1954 display_all_data, delete_data_content_windows,
1955 erase_data_content>: Now private.
1956
072272ce
TT
19572019-08-20 Tom Tromey <tom@tromey.com>
1958
1959 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1960 (tui_unhighlight_win, tui_highlight_win)
1961 (tui_win_info::make_window): Update.
1962 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1963
973961bd
TT
19642019-08-20 Tom Tromey <tom@tromey.com>
1965
1966 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1967 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1968 (MAX_PID_WIDTH): Move to tui-stack.c.
1969 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1970 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1971 (MAX_PID_WIDTH): Move from tui-data.h.
1972
ab0e1f1a
TT
19732019-08-20 Tom Tromey <tom@tromey.com>
1974
1975 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1976 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1977 (box_win): Update.
1978 (tui_gen_win_info::make_window): Rename from tui_make_window.
1979 (tui_win_info::make_window): New method.
1980 (tui_gen_win_info::make_visible): Update.
1981 * tui/tui-source.c (tui_source_window::set_contents): Update.
1982 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1983 (tui_data_window::display_registers_from): Update.
1984 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1985 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1986 Declare.
1987 <can_box>: Remove.
1988 <title>: Remove.
1989 (struct tui_win_info) <make_window>: Declare.
1990 <can_box>: Now virtual.
1991 <title>: New member.
1992 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1993 * tui/tui-command.c (tui_cmd_window::resize): Update.
1994
100c2bf3
TT
19952019-08-20 Tom Tromey <tom@tromey.com>
1996
1997 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1998 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1999 (tui_data_window::check_register_values): Update.
2000
fa4dc567
TT
20012019-08-20 Tom Tromey <tom@tromey.com>
2002
2003 * tui/tui-regs.h (struct tui_data_window): Use
2004 DISABLE_COPY_AND_ASSIGN.
2005 <regs_content>: Change type, removing unique_ptr.
2006 <tui_data_window>: Add move constructor.
2007 * tui/tui-regs.c (tui_data_window::show_registers)
2008 (tui_data_window::show_register_group)
2009 (tui_data_window::display_registers_from)
2010 (tui_data_window::display_registers_from)
2011 (tui_data_window::first_data_item_displayed)
2012 (tui_data_window::delete_data_content_windows)
2013 (tui_data_window::rerender, tui_data_window::refresh_window)
2014 (tui_data_window::check_register_values): Update.
2015
ca02d7c8
TT
20162019-08-20 Tom Tromey <tom@tromey.com>
2017
2018 * tui/tui-regs.h (struct tui_data_window) <show_registers,
2019 show_register_group>: Declare.
2020 (tui_show_register_group): Don't declare.
2021 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2022 tui_show_registers.
2023 (tui_data_window::show_register_group): Rename from
2024 tui_show_register_group.
2025 (tui_data_window::check_register_values, tui_reg_command):
2026 Update.
2027 * tui/tui-layout.c (tui_set_layout): Update.
2028
63356bfd
TT
20292019-08-20 Tom Tromey <tom@tromey.com>
2030
2031 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2032 Declare.
2033 (tui_check_register_values): Don't declare.
2034 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2035 from tui_check_register_values.
2036 * tui/tui-hooks.c (tui_register_changed): Update.
2037
42cc14a7
TT
20382019-08-20 Tom Tromey <tom@tromey.com>
2039
2040 * tui/tui-regs.c (tui_reg_layout): Move later.
2041 (tui_show_registers): Don't enable TUI mode or change layout.
2042
b9ad3686
TT
20432019-08-20 Tom Tromey <tom@tromey.com>
2044
2045 * tui/tui-regs.h (struct tui_data_item_window)
2046 <~tui_data_item_window>: Remove.
2047 <content>: Now a unique_xmalloc_ptr.
2048 * tui/tui-regs.c (tui_register_format): Return a
2049 unique_xmalloc_ptr.
2050 (tui_get_register): Update.
2051 (~tui_data_item_window): Remove.
2052 (tui_data_window::display_registers_from, tui_display_register):
2053 Update.
2054 * tui/tui-io.h (tui_expand_tabs): Update.
2055 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2056 Remove "col" parameter.
2057
8e114aab
TT
20582019-08-20 Tom Tromey <tom@tromey.com>
2059
2060 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2061 field.
2062 * tui/tui-regs.c (~tui_data_item_window): Update.
2063
1a4f81dd
TT
20642019-08-20 Tom Tromey <tom@tromey.com>
2065
2066 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2067 earlier.
2068
0f8d8876
TT
20692019-08-20 Tom Tromey <tom@tromey.com>
2070
2071 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2072
605dc2c2
TT
20732019-08-20 Tom Tromey <tom@tromey.com>
2074
2075 * tui/tui-source.h (struct tui_source_window): Update.
2076 * tui/tui-regs.c (tui_show_registers): Update.
2077 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2078 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2079 (NO_REGS_STRING): Remove defines.
2080
aedbe3bb
CM
20812019-08-20 Conrad Meyer <cem@FreeBSD.org>
2082
2083 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2084 unnecessary thread walk if remote doesn't support the packet.
2085
7ce8f214
TT
20862019-08-19 Tom Tromey <tromey@adacore.com>
2087
2088 * python/py-value.c (value_has_field): Fix indentation.
2089
f21c2bd7
TT
20902019-08-19 Tom Tromey <tromey@adacore.com>
2091
2092 * printcmd.c (do_one_display, info_display_command): Update.
2093 * block.h (contained_in): Return bool. Add allow_nested
2094 parameter.
2095 * block.c (contained_in): Return bool. Add allow_nested
2096 parameter.
2097
d806ea2d
TT
20982019-08-19 Tom Tromey <tom@tromey.com>
2099
2100 * configure: Rebuild.
2101 * configure.ac: Disallow the combination of -static-libstdc++ and
2102 source highlight.
2103 * source-cache.c (get_language_name): Handle rust.
2104 (source_cache::get_source_lines): Ignore highlighting exceptions.
2105
398fdd60
TT
21062019-08-16 Tom Tromey <tom@tromey.com>
2107
2108 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2109 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2110 (struct tui_source_window_base) <make_visible, refresh_window,
2111 resize>: Remove methods.
2112 <execution_info>: Remove field.
2113 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2114 (tui_show_source_line, tui_source_window_base)
2115 (~tui_source_window_base): Update.
2116 (tui_source_window_base::resize)
2117 (tui_source_window_base::make_visible)
2118 (tui_source_window_base::refresh_window): Remove.
2119 (tui_source_window_base::update_exec_info): Update.
2120 * tui/tui-source.c (tui_source_window::set_contents): Update.
2121 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2122
e699d331
TT
21232019-08-16 Tom Tromey <tom@tromey.com>
2124
2125 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2126 deprecated_query_hook.
2127
bb01dbfc
TT
21282019-08-16 Tom Tromey <tom@tromey.com>
2129
2130 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2131 (tui_update_source_windows_with_line): Update.
2132 * tui/tui-source.h (struct tui_source_window)
2133 <show_symtab_source>: Declare.
2134 (tui_show_symtab_source): Don't declare.
2135 * tui/tui-source.c (tui_show_symtab_source): Rename from
2136 tui_show_symtab_source.
2137
81c82c4b
TT
21382019-08-16 Tom Tromey <tom@tromey.com>
2139
2140 * tui/tui-winsource.h (struct tui_source_window_base)
2141 <set_contents>: Declare.
2142 * tui/tui-winsource.c
2143 (tui_source_window_base::update_source_window_as_is): Update.
2144 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2145 Declare.
2146 (tui_set_source_content): Don't declare.
2147 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2148 tui_set_source_content.
2149 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2150 Declare.
2151 (tui_set_disassem_content): Don't declare.
2152 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2153 tui_set_disassem_content.
2154
2ddaf614
TT
21552019-08-16 Tom Tromey <tom@tromey.com>
2156
2157 * tui/tui-winsource.h (struct tui_source_window_base)
2158 <update_breakpoint_info>: Declare.
2159 (tui_update_breakpoint_info): Don't declare.
2160 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2161 (tui_update_all_breakpoint_info): Update.
2162 (tui_source_window_base::update_breakpoint_info): Rename from
2163 tui_update_breakpoint_info.
2164 (tui_source_window_base::update_exec_info): Update.
2165
017f9828
TT
21662019-08-16 Tom Tromey <tom@tromey.com>
2167
2168 * tui/tui-winsource.h (struct tui_source_window_base)
2169 <update_source_window>: Declare.
2170 (tui_update_source_window): Don't declare.
2171 * tui/tui-winsource.c
2172 (tui_source_window_base::update_source_window): Rename from
2173 tui_update_source_window.
2174 (tui_source_window_base::rerender): Update.
2175 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2176 * tui/tui-disasm.c (tui_show_disassem)
2177 (tui_show_disassem_and_update_source)
2178 (tui_disasm_window::maybe_update): Update.
2179
ed8358e9
TT
21802019-08-16 Tom Tromey <tom@tromey.com>
2181
2182 * tui/tui-winsource.h (struct tui_source_window_base)
2183 <update_source_window_as_is>: Declare.
2184 (tui_update_source_window_as_is): Don't declare.
2185 * tui/tui-winsource.c (tui_update_source_window): Update
2186 (tui_source_window_base::update_source_window_as_is): Rename from
2187 tui_update_source_window_as_is.
2188 (tui_source_window_base::refill): Update.
2189 * tui/tui-source.c (tui_show_symtab_source): Update.
2190 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2191 Update.
2192
20149b6b
TT
21932019-08-16 Tom Tromey <tom@tromey.com>
2194
2195 * tui/tui-winsource.h (tui_update_source_window)
2196 (tui_update_source_window_as_is): Remove "noerror" parameter.
2197 * tui/tui-winsource.c (tui_update_source_window)
2198 (tui_update_source_window_as_is): Remove "noerror" parameter.
2199 (tui_update_source_windows_with_addr)
2200 (tui_update_source_windows_with_line)
2201 (tui_source_window_base::rerender)
2202 (tui_source_window_base::refill): Update.
2203 * tui/tui-source.h (tui_set_source_content)
2204 (tui_show_symtab_source): Remove "noerror" parameter.
2205 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2206 parameter.
2207 (tui_show_symtab_source): Likewise.
2208 (tui_source_window::maybe_update): Update.
2209 * tui/tui-disasm.c (tui_show_disassem)
2210 (tui_show_disassem_and_update_source)
2211 (tui_disasm_window::do_scroll_vertical)
2212 (tui_disasm_window::maybe_update): Update.
2213
2d83e710
TT
22142019-08-16 Tom Tromey <tom@tromey.com>
2215
2216 * tui/tui.c (tui_is_window_visible): Update.
2217 * tui/tui-wingeneral.c (tui_make_window)
2218 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2219 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2220 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2221 (tui_set_win_height_command, parse_scrolling_args): Update.
2222 * tui/tui-source.c (tui_source_window::style_changed): Update.
2223 * tui/tui-regs.c (tui_show_registers)
2224 (tui_data_window::first_data_item_displayed)
2225 (tui_data_window::delete_data_content_windows)
2226 (tui_check_register_values, tui_reg_command): Update.
2227 * tui/tui-disasm.c (tui_show_disassem): Update.
2228 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2229 method.
2230 <is_visible>: Remove field.
2231 * tui/tui-data.c (tui_next_win, tui_prev_win)
2232 (tui_delete_invisible_windows): Update.
2233
d4ab829a
TT
22342019-08-16 Tom Tromey <tom@tromey.com>
2235
2236 * tui/tui-winsource.h (struct tui_source_window_base)
2237 <m_has_locator>: Remove.
2238 * tui/tui-layout.c (show_source_disasm_command, show_data)
2239 (show_source_or_disasm_and_command): Update.
2240
aa7ca1bb
AH
22412019-08-16 Alan Hayward <alan.hayward@arm.com>
2242
2243 * NEWS (Other MI changes): New subsection.
2244 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2245 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2246 * arch-utils.c (default_get_pc_address_flags): New function.
2247 * arch-utils.h (default_get_pc_address_flags): New declaration.
2248 * gdbarch.sh: Add get_pc_address_flags.
2249 * gdbarch.c: Regenerate.
2250 * gdbarch.h: Likewise.
2251 * stack.c (print_pc): New function.
2252 (print_frame_info) (print_frame): Call print_pc.
2253
6eac171f
TV
22542019-08-16 Tom de Vries <tdevries@suse.de>
2255
2256 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2257 print_objfile_section_info.
2258
3df505f6
TT
22592019-08-15 Tom Tromey <tom@tromey.com>
2260
2261 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2262 calling update_cmdwin_start_line.
2263 * tui/tui-winsource.h (struct tui_source_window_base)
2264 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2265 <rerender>: Declare.
2266 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2267 Call rerender.
2268 (tui_source_window_base::set_new_height): Remove.
2269 (tui_source_window_base::rerender): Rename from
2270 do_make_visible_with_new_height.
2271 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2272 resize method.
2273 (tui_win_info::make_invisible_and_set_new_height)
2274 (tui_win_info::make_visible_with_new_height): Remove.
2275 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2276 Declare.
2277 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2278 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2279 do_make_visible_with_new_height>: Don't declare.
2280 <rerender>: Declare.
2281 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2282 set_new_height.
2283 (tui_data_window::do_make_visible_with_new_height): Remove.
2284 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2285 call tui_show_locator_content.
2286 (tui_gen_win_info::resize): Call rerender.
2287 (show_source_or_disasm_and_command): Don't call
2288 tui_show_locator_content.
2289 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2290 method.
2291 (struct tui_win_info) <rerender>: Declare.
2292 <set_new_height, make_invisible_and_set_new_height,
2293 make_visible_with_new_height>: Don't declare.
2294 * tui/tui-data.c (tui_win_list::rerender): New method.
2295 * tui/tui-command.h (struct tui_cmd_window)
2296 <do_make_visible_with_new_height>: Don't declare.
2297 * tui/tui-command.c
2298 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2299
272560b5
TT
23002019-08-15 Tom Tromey <tromey@adacore.com>
2301
2302 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2303 * ada-lang.c (ada_enum_name): Likewise.
2304
08235187
CB
23052019-08-15 Christian Biesinger <cbiesinger@google.com>
2306
2307 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2308 leading underscore.
2309 (GdbOutputErrorFile): Likewise.
2310 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2311 accordingly.
2312 (execute_unwinders): Rename to have a leading underscore.
2313 (auto_load_packages): Likewise.
2314 (global scope): Adjust call to auto_load_packages accordingly.
2315 (GdbSetPythonDirectory): Likewise.
2316 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2317 instead of execute_unwinders.
2318
db502012
TT
23192019-08-15 Tom Tromey <tom@tromey.com>
2320
2321 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2322 (show_data): Don't change window visibility.
2323 (tui_gen_win_info::resize): Remove special case for command
2324 window. Use wresize, when available.
2325 (show_source_or_disasm_and_command): Don't change window
2326 visibility.
2327 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2328 <make_visible>: New method.
2329 * tui/tui-command.c (tui_cmd_window::resize): New method.
2330
3891b65e
TT
23312019-08-15 Tom Tromey <tom@tromey.com>
2332
2333 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2334 (struct tui_source_windows): New.
2335 * tui/tui-winsource.c (tui_display_main): Update.
2336 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2337 (new_height_ok, parse_scrolling_args): Update.
2338 * tui/tui-layout.c (show_layout, show_data): Update.
2339 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2340 (tui_add_to_source_windows): Don't declare.
2341 * tui/tui-data.c (source_windows, tui_source_windows)
2342 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2343
ee556432
TT
23442019-08-15 Tom Tromey <tom@tromey.com>
2345
2346 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2347 Rename from reset.
2348 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2349 * tui/tui-layout.c (show_source_disasm_command, show_data):
2350 Update.
2351 (tui_gen_win_info::resize): Rename.
2352 (show_source_or_disasm_and_command): Update.
2353 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2354 reset.
2355
46f438e3
TT
23562019-08-15 Tom Tromey <tom@tromey.com>
2357
2358 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2359 * tui/tui-interp.c (tui_interp::init): Don't call
2360 tui_initialize_static_data.
2361 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2362
f4ce562c
TT
23632019-08-15 Tom Tromey <tom@tromey.com>
2364
2365 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2366 examine tui_win_list.
2367
c398c3d0
TT
23682019-08-15 Tom Tromey <tom@tromey.com>
2369
2370 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2371 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2372 tui_clear_source_content.
2373 (tui_clear_source_content): Remove.
2374 (tui_source_window_base::do_erase_source_content): Hoist call to
2375 content.clear().
2376 * tui/tui-stack.c (tui_show_frame_info): Don't call
2377 tui_clear_source_content.
2378
e25d2004
TT
23792019-08-15 Tom Tromey <tom@tromey.com>
2380
2381 * tui/tui-winsource.h (struct tui_source_window_base)
2382 <do_erase_source_content>: New method.
2383 <erase_source_content>: New method.
2384 (tui_erase_source_content): Don't declare.
2385 * tui/tui-winsource.c (tui_clear_source_content): Update.
2386 (tui_source_window_base::do_erase_source_content): Rename from
2387 tui_erase_source_content.
2388 (tui_source_window_base::show_source_content): Update.
2389 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2390 * tui/tui-source.h (struct tui_source_window)
2391 <erase_source_content>: New method.
2392 * tui/tui-disasm.h (struct tui_disasm_window)
2393 <erase_source_content>: New method.
2394
002f15c2
TT
23952019-08-15 Tom Tromey <tom@tromey.com>
2396
2397 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2398 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2399 constructor.
2400 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2401 * tui/tui-source.c (tui_set_source_content): Update.
2402 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2403
c9033fe8
TT
24042019-08-15 Tom Tromey <tom@tromey.com>
2405
2406 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2407 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2408 tui-source.c.
2409 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2410 Declare.
2411 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2412 method.
2413 (tui_source_window::maybe_update): Update.
2414
088f37dd
TT
24152019-08-15 Tom Tromey <tom@tromey.com>
2416
2417 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2418 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2419 tui-disasm.c.
2420 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2421 Declare.
2422 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2423 method.
2424 (tui_disasm_window::maybe_update): Update.
2425
a54700c6
TT
24262019-08-15 Tom Tromey <tom@tromey.com>
2427
2428 * tui/tui-winsource.h (struct tui_source_window_base)
2429 <maybe_update>: Declare.
2430 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2431 method.
2432 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2433 Declare.
2434 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2435 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2436 Declare.
2437 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2438
e2a678a5
TT
24392019-08-15 Tom Tromey <tom@tromey.com>
2440
2441 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2442
f2dda477
TT
24432019-08-15 Tom Tromey <tom@tromey.com>
2444
2445 * tui/tui-wingeneral.c: Include tui-stack.h.
2446 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2447 (struct tui_locator_window): Move from tui-data.h.
2448 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2449 (tui_initialize_static_data): Move from tui-data.c.
2450 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2451 (struct tui_locator_window): Move to tui-stack.c.
2452 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2453 (tui_initialize_static_data): Move to tui-stack.c.
2454
ed4a1084
TT
24552019-08-15 Tom Tromey <tom@tromey.com>
2456
2457 * tui/tui-layout.c (show_source_disasm_command)
2458 (show_source_or_disasm_and_command): Use make_visible method, not
2459 tui_make_window.
2460 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2461 Remove.
2462
65962b20
TT
24632019-08-15 Tom Tromey <tom@tromey.com>
2464
2465 * tui/tui-wingeneral.h (tui_make_window): Update.
2466 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2467 parameter.
2468 (tui_gen_win_info::make_visible): Update.
2469 * tui/tui-regs.c (tui_data_window::display_registers_from):
2470 Update.
2471 * tui/tui-layout.c (show_source_disasm_command)
2472 (show_source_or_disasm_and_command): Update.
2473 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2474 (enum tui_box): Remove.
2475 (struct tui_win_info) <can_box>: New method.
2476 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2477 method.
2478
2208ee91
TV
24792019-08-15 Tom de Vries <tdevries@suse.de>
2480
2481 * linux-nat-trad.c: Include gdbarch.h.
2482
75faf5c4
AH
24832019-08-14 Alan Hayward <alan.hayward@arm.com>
2484
2485 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2486 register sizes.
2487
b1c896b3
TT
24882019-08-14 Tom Tromey <tromey@adacore.com>
2489
2490 * darwin-nat.c: Include gdbarch.h.
2491 * darwin-nat-info.c: Include gdbarch.h.
2492
6405cd73
TT
24932019-08-13 Tom Tromey <tom@tromey.com>
2494
2495 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2496 Remove.
2497 * tui/tui-data.c (tui_initialize_static_data): Update.
2498
5216580d
TT
24992019-08-13 Tom Tromey <tom@tromey.com>
2500
2501 * tui/tui-winsource.h (struct tui_exec_info_window)
2502 <~tui_exec_info_window, maybe_allocate_content, get_content,
2503 m_content>: Remove.
2504 (struct tui_source_window_base) <set_exec_info_content,
2505 show_exec_info_content>: Don't declare.
2506 * tui/tui-winsource.c
2507 (tui_exec_info_window::maybe_allocate_content): Remove.
2508 (tui_source_window_base::update_exec_info): Rename from
2509 set_exec_info_content.
2510 (tui_source_window_base::show_exec_info_content)
2511 (tui_source_window_base::update_exec_info): Remove.
2512
93858ad3
TT
25132019-08-13 Tom Tromey <tom@tromey.com>
2514
2515 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2516 declare.
2517 * tui/tui-winsource.c (tui_update_source_window_as_is)
2518 (tui_update_source_windows_with_addr, tui_erase_source_content):
2519 Update.
2520 (tui_clear_exec_info_content): Remove.
2521
e321e7ce
TT
25222019-08-13 Tom Tromey <tom@tromey.com>
2523
2524 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2525 declare.
2526 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2527 call tui_erase_exec_info_content.
2528 (tui_clear_exec_info_content): Rename from
2529 tui_erase_exec_info_content.
2530 (tui_clear_exec_info_content): Delete.
2531
8270ac62
TT
25322019-08-13 Tom Tromey <tom@tromey.com>
2533
2534 * tui/tui-winsource.h (struct tui_source_window_base)
2535 <show_exec_info_content>: Declare.
2536 (tui_show_exec_info_content): Don't declare.
2537 * tui/tui-winsource.c
2538 (tui_source_window_base::show_exec_info_content): Rename from
2539 tui_show_exec_info_content.
2540 (tui_source_window_base::update_exec_info): Update.
2541
7b56485d
TT
25422019-08-13 Tom Tromey <tom@tromey.com>
2543
2544 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2545 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2546 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2547 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2548 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2549 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2550 ... here.
2551
7ba913dc
TT
25522019-08-13 Tom Tromey <tom@tromey.com>
2553
2554 * tui/tui-winsource.h (struct tui_source_window_base)
2555 <update_exec_info>: Declare.
2556 (tui_update_exec_info): Don't declare.
2557 * tui/tui-winsource.c (tui_update_source_window_as_is)
2558 (tui_source_window_base::refresh_all)
2559 (tui_update_all_breakpoint_info): Update.
2560 (tui_source_window_base::update_exec_info): Rename from
2561 tui_update_exec_info.
2562 * tui/tui-stack.c (tui_show_frame_info): Update.
2563
37a4a131
TT
25642019-08-13 Tom Tromey <tom@tromey.com>
2565
2566 * tui/tui-winsource.h (struct tui_source_window_base)
2567 <set_exec_info_content>: Declare.
2568 (tui_set_exec_info_content): Don't declare.
2569 * tui/tui-winsource.c
2570 (tui_source_window_base::set_exec_info_content): Rename from
2571 tui_set_exec_info_content.
2572 (tui_update_exec_info): Update.
2573
0bd27e07
TT
25742019-08-13 Tom Tromey <tom@tromey.com>
2575
2576 * tui/tui-winsource.h (struct tui_source_window_base)
2577 <show_source_content>: Declare.
2578 (tui_show_source_content): Don't declare.
2579 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2580 (tui_source_window_base::show_source_content): Rename from
2581 tui_show_source_content.
2582 (tui_source_window_base::refresh_all): Update.
2583 * tui/tui-layout.c (show_source_disasm_command)
2584 (show_source_or_disasm_and_command): Update.
2585
b4ef5aeb
TT
25862019-08-13 Tom Tromey <tom@tromey.com>
2587
2588 * tui/tui-winsource.c (tui_erase_source_content)
2589 (tui_show_source_content, tui_source_window_base::refresh_all):
2590 Update.
2591 * tui/tui-wingeneral.h
2592 (tui_check_and_display_highlight_if_needed): Don't declare.
2593 * tui/tui-wingeneral.c
2594 (tui_win_info::check_and_display_highlight_if_needed): Rename from
2595 check_and_display_highlight_if_needed.
2596 * tui/tui-win.c (tui_rehighlight_all)
2597 (tui_win_info::make_visible_with_new_height): Update.
2598 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2599 (tui_data_window::erase_data_content)
2600 (tui_data_window::display_all_data): Update.
2601 * tui/tui-data.h (struct tui_win_info)
2602 <check_and_display_highlight_if_needed>: Declare.
2603
fede5273
TT
26042019-08-13 Tom Tromey <tom@tromey.com>
2605
2606 * tui/tui-win.c (tui_resize_all): Call
2607 tui_delete_invisible_windows.
2608 * tui/tui-layout.c (show_layout): Call
2609 tui_delete_invisible_windows.
2610 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2611 * tui/tui-data.c (tui_delete_invisible_windows): New function.
2612
22c3f490
TT
26132019-08-13 Tom Tromey <tom@tromey.com>
2614
2615 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
2616 tui_add_win_to_layout.
2617
16cb7910
TT
26182019-08-13 Tom Tromey <tom@tromey.com>
2619
2620 * tui/tui-layout.h (tui_default_win_height): Don't declare.
2621 * tui/tui-layout.c (tui_default_win_height): Now static.
2622
cc0c3ffb
TT
26232019-08-13 Tom Tromey <tom@tromey.com>
2624
2625 * tui/tui-layout.c (show_layout): Unify all layout cases into a
2626 single switch.
2627 (show_source_disasm_command, show_source_or_disasm_and_command):
2628 Don't check current layout.
2629
3f3ffe54
TT
26302019-08-13 Tom Tromey <tom@tromey.com>
2631
2632 * tui/tui-wingeneral.c (make_all_visible): Remove.
2633 (tui_make_all_invisible): Simplify.
2634 * tui/tui-layout.c (tui_make_all_invisible): Move from
2635 tui-wingeneral.c; simplify.
2636 (show_layout): Hoist call to tui_make_all_invisible.
2637 (show_data): Don't call tui_make_all_invisible.
2638
69258091
TT
26392019-08-13 Tom Tromey <tom@tromey.com>
2640
2641 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2642 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2643
62cf57fe
TT
26442019-08-13 Tom Tromey <tom@tromey.com>
2645
2646 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2647 tui-data.c.
2648 (show_source_disasm_command, show_data)
2649 (show_source_or_disasm_and_command): Don't use
2650 tui_set_current_layout_to.
2651 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2652 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2653 tui-layout.c.
2654 (tui_set_current_layout_to): Remove.
2655
2afade5d
TT
26562019-08-13 Tom Tromey <tom@tromey.com>
2657
2658 * tui/tui-layout.c (tui_set_layout): Update.
2659 * tui/tui-data.h (struct tui_layout_def): Remove.
2660 (tui_layout_def): Don't declare.
2661 * tui/tui-data.c (layout_def): Remove.
2662 (tui_layout_def): Remove.
2663
a3504e96
TT
26642019-08-13 Tom Tromey <tom@tromey.com>
2665
2666 * tui/tui-winsource.h (struct tui_source_window_base)
2667 <clear_detail>: No longer "override".
2668 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2669 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2670 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2671 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2672 Remove.
2673 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2674
29c92911
TT
26752019-08-13 Tom Tromey <tromey@adacore.com>
2676
2677 * tracepoint.c: Don't include readline.h or history.h.
2678
86c6b807
TT
26792019-08-12 Tom Tromey <tom@tromey.com>
2680
2681 * configure: Rebuild.
2682 * configure.ac: Check for readline 7.
2683 * NEWS: Mention readline 7 requirement.
2684 * README: Update.
2685
5db2718c
TT
26862019-08-12 Tom Tromey <tom@tromey.com>
2687
2688 * mingw-hdep.c (gdb_select): Remove readline hack.
2689
dac36daf
PFC
26902019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2691
2692 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2693 when the function fails.
2694
1022c627
AA
26952019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2696
2697 * s390-tdep.c (s390_type_align): New function.
2698 (s390_gdbarch_init): Set it as type_align gdbarch method.
2699
eba4caf2
TV
27002019-08-09 Tom de Vries <tdevries@suse.de>
2701
2702 PR gdb/24591
2703 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2704 pc_low with relocation offset.
2705
123cd851
TT
27062019-08-07 Tom Tromey <tromey@adacore.com>
2707
2708 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2709 (print_frame_args): Update.
2710 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2711 Update.
2712 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2713 * frame.h (struct frame_arg): Add initializers.
2714 <error>: Now a unique_xmalloc_ptr.
2715
3d31bc39
AH
27162019-08-07 Alan Hayward <alan.hayward@arm.com>
2717
2718 * NEWS: Expand the Pointer Authentication entry.
2719 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2720 (aarch64_frame_unmask_lr): ... to this.
2721 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2722 Call aarch64_frame_unmask_lr.
2723 * frame.c (struct frame_info): Add "masked" variable.
2724 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2725 (fprint_frame): Check for masked pc.
2726 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2727 declarations.
2728 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2729 * stack.c (print_frame): Check for masked pc.
2730
0cf9feb9
TT
27312019-08-06 Tom Tromey <tom@tromey.com>
2732
2733 * stabsread.c (patch_block_stabs, read_one_struct_field)
2734 (read_enum_type): Use obstack_strndup.
2735 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2736 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2737 * dwarf2read.c (guess_full_die_structure_name)
2738 (anonymous_struct_prefix): Use obstack_strndup.
2739 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2740 * c-exp.y (yylex): Use obstack_strndup.
2741 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2742 (write_var_or_type): Use obstack_strndup.
2743
efba19b0
TT
27442019-08-06 Tom Tromey <tom@tromey.com>
2745
2746 * symfile.c (reread_symbols): Use obstack_strdup.
2747 * stabsread.c (read_type): Use obstack_strdup.
2748 * gdb_obstack.h (obstack_strdup): New overload.
2749 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2750 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2751 (dwarf2_canonicalize_name): Use obstack_strdup.
2752 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2753 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2754 Use obstack_strdup.
2755
f25102f7
TT
27562019-08-06 Tom Tromey <tom@tromey.com>
2757
2758 * gdb_obstack.h (obstack_strdup): Define.
2759 * gdb_obstack.c (obstack_strdup): Don't define.
2760
021887d8
TT
27612019-08-06 Tom Tromey <tom@tromey.com>
2762
2763 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2764 obstack_strdup.
2765 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2766 obstack_strdup.
2767 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2768 * stabsread.c (common_block_start): Use obstack_strdup.
2769 * objfiles.c (set_objfile_main_name, objfile): Use
2770 obstack_strdup.
2771 * namespace.c (add_using_directive): Use obstack_strdup.
2772 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2773 * jit.c (finalize_symtab): Use obstack_strdup.
2774 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2775 (guess_partial_die_structure_name, partial_die_info::fixup)
2776 (dwarf2_name): Use obstack_strdup.
2777 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2778 obstack_strdup.
2779 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2780 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2781 obstack_strdup.
2782 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2783
d2834edc
PW
27842019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2785
2786 * unittests/help-doc-selftests.c: New file.
2787 * Makefile.in: Add the new file.
2788
590042fc
PW
27892019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2790
2791 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2792 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2793 the full first line, except when FOR_VALUE_PREFIX. In this case,
2794 the trailing '.' is not output, and the first character is uppercased.
2795 (print_help_for_command): Update call to print_doc_line.
2796 (print_doc_of_command): Likewise.
2797 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2798 * cli/cli-option.c (append_indented_doc): Do not append newline.
2799 (build_help_option): Append newline after first appended_indented_doc
2800 only if a second call is done.
2801 (build_help): Append 2 new lines before each option, except the first
2802 one.
2803 * compile/compile.c (_initialize_compile): Add new lines after
2804 %OPTIONS%, when not at the end of the help.
2805 Change help doc or code
2806 producing the help doc to respect the invariants.
2807 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2808 Also removed the new line after 'Options:', as all other commands
2809 do not put an empty line between 'Options:' and the first option.
2810 * printcmd.c (_initialize_printcmd): Likewise.
2811 * stack.c (_initialize_stack): Likewise.
2812 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2813 incorrectly telling COMMAND is optional.
2814 * ada-lang.c (_initialize_ada_language): Change help doc or code
2815 producing the help doc to respect the invariants.
2816 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2817 * breakpoint.c (_initialize_breakpoint): Likewise.
2818 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2819 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2820 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2821 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2822 _initialize_cli_style): Likewise.
2823 * corelow.c (core_target_info): Likewise.
2824 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2825 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2826 * filesystem.c (_initialize_filesystem): Likewise.
2827 * frame.c (_initialize_frame): Likewise.
2828 * gnu-nat.c (add_task_commands): Likewise.
2829 * infcall.c (_initialize_infcall): Likewise.
2830 * infcmd.c (_initialize_infcmd): Likewise.
2831 * interps.c (_initialize_interpreter): Likewise.
2832 * language.c (_initialize_language): Likewise.
2833 * linux-fork.c (_initialize_linux_fork): Likewise.
2834 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2835 * maint.c (_initialize_maint_cmds): Likewise.
2836 * memattr.c (_initialize_mem): Likewise.
2837 * printcmd.c (_initialize_printcmd): Likewise.
2838 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2839 _RegEx): Likewise.
2840 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2841 * record-btrace.c (_initialize_record_btrace): Likewise.
2842 * record-full.c (_initialize_record_full): Likewise.
2843 * record.c (_initialize_record): Likewise.
2844 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2845 * regcache.c (_initialize_regcache): Likewise.
2846 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2847 _initialize_remote): Likewise.
2848 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2849 * serial.c (_initialize_serial): Likewise.
2850 * skip.c (_initialize_step_skip): Likewise.
2851 * source.c (_initialize_source): Likewise.
2852 * stack.c (_initialize_stack): Likewise.
2853 * symfile.c (_initialize_symfile): Likewise.
2854 * symtab.c (_initialize_symtab): Likewise.
2855 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2856 * top.c (init_main): Likewise.
2857 * tracefile-tfile.c (tfile_target_info): Likewise.
2858 * tracepoint.c (_initialize_tracepoint): Likewise.
2859 * tui/tui-win.c (_initialize_tui_win): Likewise.
2860 * utils.c (add_internal_problem_command): Likewise.
2861 * valprint.c (value_print_option_defs): Likewise.
2862
404f2902
FCE
28632019-08-06 Frank Ch. Eigler <fche@redhat.com>
2864
2865 PR build/24886
2866 * configure.ac: Drop enable-libmcheck support.
2867 * configure, config.in: Rebuild.
2868 * libmcheck.m4: Remove.
2869 * acinclude.m4: Don't include it.
2870 * Makefile.in: Don't distribute it.
2871 * top.c (print_gdb_configuration): Don't mention it.
2872
046bebe1
TT
28732019-08-06 Tom Tromey <tom@tromey.com>
2874
2875 * utils.c (set_output_style): Sometimes pass stream to
2876 emit_style_escape.
2877 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2878 * record-btrace.c (btrace_insn_history): Update.
2879 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2880 method.
2881 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2882 Update initializers.
2883 <m_uiout>: New field.
2884 <m_di>: Move lower.
2885 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2886 Remove "uiout" parameter.
2887 (dump_insns): Update.
2888 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2889 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2890
ddbcedf5
CB
28912019-08-06 Christian Biesinger <cbiesinger@google.com>
2892
2893 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2894 (error_in_psymtab_expansion): Likewise.
2895 (lookup_symbol_via_quick_fns): Likewise.
2896 (basic_lookup_transparent_type_quick): Likewise.
2897 (basic_lookup_transparent_type_1): Likewise.
2898
b08b16c8
TT
28992019-08-06 Tom Tromey <tromey@adacore.com>
2900
2901 * source.c (last_source_error): Now bool.
2902 (print_source_lines_base): Make "noprint" bool. Only open
2903 source file when last_source_visited changes.
2904
cb44333d
TT
29052019-08-06 Tom Tromey <tromey@adacore.com>
2906
2907 * annotate.c (annotate_source_line): Use g_source_cache.
2908 * source-cache.c (source_cache::get_plain_source_lines): Change
2909 parameters. Populate m_offset_cache.
2910 (source_cache::ensure): New method.
2911 (source_cache::get_line_charpos): New method.
2912 (extract_lines): Move lower. Change parameters.
2913 (source_cache::get_source_lines): Move lower.
2914 * source-cache.h (class source_cache): Update comment.
2915 <get_line_charpos>: New method.
2916 <get_source_lines>: Update comment.
2917 <clear>: Clear m_offset_cache.
2918 <get_plain_source_lines>: Change parameters.
2919 <ensure>: New method
2920 <m_offset_cache>: New member.
2921 * source.c (forget_cached_source_info_for_objfile): Update.
2922 (info_source_command): Use g_source_cache.
2923 (find_source_lines, open_source_file_with_line_charpos): Remove.
2924 (print_source_lines_base, search_command_helper): Use g_source_cache.
2925 * source.h (open_source_file_with_line_charpos): Don't declare.
2926 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2927 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2928 Use g_source_cache.
2929
872dceaa
TT
29302019-08-06 Tom Tromey <tromey@adacore.com>
2931
2932 * source-cache.c (source_cache::get_plain_source_lines):
2933 Remove "first_line" and "last_line" parameters.
2934 (source_cache::get_source_lines): Cache plain text.
2935 * source-cache.h (class source_cache)
2936 <get_plain_source_lines>: Update.
2937
269249d9
TT
29382019-08-06 Tom Tromey <tromey@adacore.com>
2939
2940 * source-cache.c (extract_lines): No longer a method.
2941 Changed type of parameter. Include final newline.
2942 (selftests::extract_lines_test): New function.
2943 (_initialize_source_cache): Likewise.
2944 * source-cache.h (class source_cache)
2945 <extract_lines>: Don't declare.
2946
c0e8dcd8
TT
29472019-08-06 Tom Tromey <tromey@adacore.com>
2948
2949 * breakpoint.c (init_breakpoint_sal): Update.
2950 (breakpoint): Update.
2951 * breakpoint.h (struct breakpoint) <filter>: Now a
2952 unique_xmalloc_ptr.
2953
0b27c27d
CB
29542019-08-05 Christian Biesinger <cbiesinger@google.com>
2955
2956 * NEWS: Mention dictionary access on blocks.
2957 * python/py-block.c (blpy_getitem): New function.
2958 (block_object_as_mapping): New struct.
2959 (block_object_type): Use new struct for tp_as_mapping field.
2960
4ee94178
CB
29612019-08-05 Christian Biesinger <cbiesinger@google.com>
2962
2963 * objfiles.h (objfile): Add a comment describing partial symbols.
2964
8abfcabc
TT
29652019-08-05 Tom Tromey <tromey@adacore.com>
2966
2967 * compile/compile.c (_initialize_compile): Use _(), not N_().
2968 * thread.c (_initialize_thread): Use _(), not N_().
2969 * stack.c (_initialize_stack): Use _(), not N_().
2970 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2971
2b79f376
SM
29722019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2973
2974 * dwarf2read.c (struct dw2_symtab_iterator):
2975 <want_specific_block>: Remove.
2976 <block_index>: Change type to gdb::optional.
2977 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2978 change type of BLOCK_INDEX parameter to gdb::optional.
2979 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2980 (dw2_lookup_symbol): Don't pass argument for
2981 WANT_SPECIFIC_BLOCK.
2982 (dw2_expand_symtabs_for_function): Don't pass argument for
2983 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2984 (class dw2_debug_names_iterator)
2985 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2986 parameter, change BLOCK_INDEX type to gdb::optional.
2987 <m_want_specific_block>: Remove.
2988 <m_block_index>: Change type to gdb::optional.
2989 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2990 gdb::optional. Re-write in function of gdb::optional.
2991 (dw2_debug_names_lookup_symbol): Don't pass argument for
2992 WANT_SPECIFIC_BLOCK.
2993 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2994 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2995 BLOCK_INDEX.
2996
ae60f04e
PW
29972019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2998
2999 * NEWS: Mention changes to "info sources" command.
3000
28cd9371
PW
30012019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3002
3003 * symtab.c (filename_partial_match_opts): New struct type.
3004 (struct output_source_filename_data): New members
3005 regexp, c_regexp, partial_match.
3006 (output_source_filename): Use new members to decide to print file.
3007 (info_sources_option_defs): New variable.
3008 (make_info_sources_options_def_group, print_info_sources_header,
3009 info_sources_command_completer):
3010 New functions.
3011 (info_sources_command): Read new optional arguments.
3012 (_initialize_symtab): Update info sources help.
3013
ca683e3a
AO
30142019-08-02 Alexandre Oliva <oliva@adacore.com>
3015
3016 * ada-lang.c (exception_support_info_v0): Renamed from...
3017 (default_exception_support_info): ... this. Create new
3018 definition for v1.
3019 (ada_has_this_exception_support): Look up catch_handlers_sym.
3020 (ada_exception_support_info_sniffer): Try v0 after default.
3021
f1264162
TT
30222019-08-01 Tom Tromey <tromey@adacore.com>
3023
3024 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3025 gdbarch.h.
3026
0a7b2485
CB
30272019-08-01 Christian Biesinger <cbiesinger@google.com>
3028
3029 * s12z-tdep.c: Fix include path for s12z-opc.h.
3030
c6bdbeb7
AH
30312019-08-01 Alan Hayward <alan.hayward@arm.com>
3032
3033 * NEWS: Require GNU make 3.82.
3034
a2bd7b82
TT
30352019-07-16 Tom Tromey <tom@tromey.com>
3036
3037 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3038 declare.
3039
aa3b6533
TT
30402019-07-30 Tom Tromey <tromey@adacore.com>
3041
3042 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3043
a1530dc7
KB
30442019-07-30 Kevin Buettner <kevinb@redhat.com>
3045
3046 * printcmd.c (print_address_symbolic): Print negative offsets.
3047 (build_address_symbolic): Force signed arithmetic when computing
3048 offset.
3049
2906593f
CB
30502019-07-30 Christian Biesinger <cbiesinger@google.com>
3051
3052 PR/24474: Add a function to lookup static variables.
3053 * NEWS: Mention this new function.
3054 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3055 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3056 * python/python.c (python_GdbMethods): Add new function.
3057
c620ed88
CB
30582019-07-29 Christian Biesinger <cbiesinger@google.com>
3059
3060 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3061 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3062 (objfpy_lookup_static_symbol): New function.
3063 (objfile_object_methods): Add new functions.
3064
bc4268a5
PW
30652019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3066
3067 * NEWS: Mention 'set|show print frame-info'. Mention new
3068 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3069 backtrace argument. Mention that python frame filtering code
3070 is now consistent with what 'backtrace' command prints.
3071
4b5e8d19
PW
30722019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3073
3074 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3075 comments.
3076 (print_frame_info_auto, print_frame_info_source_line,
3077 print_frame_info_location, print_frame_info_source_and_location,
3078 print_frame_info_location_and_address, print_frame_info_short_location):
3079 New declarations.
3080 (struct frame_print_options): New member print_frame_info.
3081 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3082 * stack.h (get_user_print_what_frame_info): New declaration.
3083 (frame_show_address): New declaration.
3084 * stack.c (print_frame_arguments_choices): New value 'presence'.
3085 (print_frame_info_auto, print_frame_info_source_line,
3086 print_frame_info_location, print_frame_info_source_and_location,
3087 print_frame_info_location_and_address, print_frame_info_short_location,
3088 print_frame_info_choices, print_frame_info_print_what): New definitions.
3089 (print_frame_args): Only print dots for args if print frame-arguments
3090 is 'presence'.
3091 (frame_print_option_defs): New element for "frame-info".
3092 (get_user_print_what_frame_info): New function.
3093 (frame_show_address): Make non static. Move comment to stack.h.
3094 (print_frame_info_to_print_what): New function.
3095 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3096 to decide what to print.
3097 (backtrace_command_1): Handle the new print_frame_arguments_presence
3098 value.
3099 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3100 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3101 (py_print_frame): In non-mi mode, use LOCATION as default for
3102 print_what, similarly to frame information printed directly by
3103 backtrace command. Handle frame-info user option in non MI mode.
3104
6bdfee81
KB
31052019-07-27 Kevin Buettner <kevinb@redhat.com>
3106
3107 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3108 Add case for debugging 32-bit target on 64-bit host. Revise
3109 comment.
3110
98a617f8
KB
31112019-07-27 Kevin Buettner <kevinb@redhat.com>
3112
3113 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3114 instead of find_function_entry_range_from_pc.
3115
567238c9
KB
31162019-07-27 Kevin Buettner <kevinb@redhat.com>
3117
3118 * stack.c (find_frame_funname): Remove code which preferred
3119 minsym over symtab sym in "certain pathological cases".
3120
2dc80cf8
KB
3121 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3122 parameter. Change type of "do_demangle" to bool.
3123 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3124 Pass suitable "prefer_sym_over_minsym" flag to
3125 build_address_symbolic(). Don't output "+" for negative offsets.
3126 * printcmd.c (print_address_symbolic): Update invocation of
3127 build_address_symbolic to include a "prefer_sym_over_minsym"
3128 flag.
3129 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3130 Restrict cases in which use of minimal symbol is preferred to that
3131 of a found symbol. Update comments.
3132
1aff7173
KB
3133 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3134 for entry pc when entry pc is out of range for that FDE.
3135
89b085ac
BC
31362019-07-26 Brian Callahan <bcallah@openbsd.org>
3137
3138 PR gdb/24839:
3139 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3140 type.
3141
f32feb4a
CB
31422019-07-25 Christian Biesinger <cbiesinger@google.com>
3143
3144 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3145 this function's Python signature.
3146
3147
31482019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
3149
3150 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3151 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3152 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3153 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3154 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3155
3156
c54e4253
YS
31572019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3158
3159 * h8300-tdep.c (h8300_register_name_common): New.
3160 h8300_register_name): Use h8300_register_name_common.
3161 (h8300s_register_name): Likewise.
3162 (h8300sx_register_name): Likewise.
3163 (h8300h_register_nam): New.
3164 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3165
3166
40eadf04
SP
31672019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3168
3169 * arm-tdep.c (arm_skip_cmse_entry): New function.
3170 (arm_is_sgstubs_section): New function.
3171 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3172
bfa2a36d
TT
31732019-07-22 Tom Tromey <tom@tromey.com>
3174
3175 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3176 Don't self-assign.
3177
a8e9d247
AB
31782019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3179
3180 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3181 type_print.
3182
eb86c5e2
AB
31832019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3184
3185 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3186 so that GDB doesn't match any msymbols when searching in the
3187 TYPES_DOMAIN.
3188 (print_symbol_info): Print using typedef_print or type_print based
3189 on the type of the symbol. Add updated FIXME comment moved from...
3190 (_initialize_symtab): ... move and update FIXME comment to above.
3191
a8eab7c6
AB
31922019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3193
3194 * NEWS: Mention adding -q option to "info types".
3195 * symtab.c (struct info_types_options): New struct.
3196 (info_types_options_defs): New variable.
3197 (make_info_types_options_def_group): New function.
3198 (info_types_command): Use gdb::option framework to parse options.
3199 (info_types_command_completer): New function.
3200 (_initialize_symtab): Extend the help text on "info types" and
3201 register command completer.
3202
b4603c34
CB
32032019-07-21 Christian Biesinger <cbiesinger@google.com>
3204
3205 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3206 (lookup_symbol_in_objfile): Change int to block_enum and add a
3207 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3208
c8cdc1e0
CB
32092019-07-20 Christian Biesinger <cbiesinger@google.com>
3210
3211 * MAINTAINERS (Write After Approval): Add self.
3212
01e175fe
AB
32132019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3214
3215 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3216 instruction to the dummy code region.
3217
56f79b63
TT
32182019-07-19 Tom Tromey <tromey@adacore.com>
3219
3220 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3221 (ARGSUSED, PARAMS, __func__): Remove rules.
3222
4c5aa8e0
AH
32232019-07-19 Alan Hayward <alan.hayward@arm.com>
3224
3225 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3226 * features/arm/arm-with-iwmmxt.c: Remove.
3227 * features/arm/arm-with-iwmmxt.xml: Remove.
3228 * features/arm/arm-with-m-fpa-layout.c: Remove.
3229 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3230 * features/arm/arm-with-m-vfp-d16.c: Remove.
3231 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3232 * features/arm/arm-with-m.c: Remove.
3233 * features/arm/arm-with-m.xml: Remove.
3234 * features/arm/arm-with-neon.c: Remove.
3235 * features/arm/arm-with-neon.xml: Remove.
3236 * features/arm/arm-with-vfpv2.c: Remove.
3237 * features/arm/arm-with-vfpv2.xml: Remove.
3238 * features/arm/arm-with-vfpv3.c: Remove.
3239 * features/arm/arm-with-vfpv3.xml: Remove.
3240
f42b2617
AH
32412019-07-19 Alan Hayward <alan.hayward@arm.com>
3242
3243 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3244
f29ec966
AH
32452019-07-19 Alan Hayward <alan.hayward@arm.com>
3246
3247 * arch/aarch32.c (aarch32_create_target_description): Create
3248 target descriptions using features.
3249 * arch/arm.c (arm_create_target_description)
3250 (arm_create_mprofile_target_description): Likewise.
3251 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3252
d105cce5
AH
32532019-07-19 Alan Hayward <alan.hayward@arm.com>
3254
3255 * Makefile.in: Add new files.
3256 * aarch32-tdep.c: New file.
3257 * aarch32-tdep.h: New file.
3258 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3259 Call aarch32_read_description.
3260 * arch/aarch32.c: New file.
3261 * arch/aarch32.h: New file.
3262 * arch/arm.c (arm_create_target_description)
3263 (arm_create_mprofile_target_description): New function.
3264 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3265 (arm_create_target_description)
3266 (arm_create_mprofile_target_description): New declaration.
3267 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3268 read_description functions.
3269 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3270 Likewise.
3271 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3272 * arm-tdep.c (tdesc_arm_list): New variable.
3273 (arm_register_g_packet_guesses): Call create description functions.
3274 (arm_read_description) (arm_read_mprofile_description): New
3275 function.
3276 * arm-tdep.h (arm_read_description)
3277 (arm_read_mprofile_description): Add declaration.
3278 * configure.tgt: Add new files.
3279
afe09f0b
GL
32802019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3281
3282 * top.c (new_ui_command): Open specified terminal just once.
3283
cd215b2e
TT
32842019-07-18 Tom Tromey <tromey@adacore.com>
3285
3286 * symtab.c (main_name): Constify return type.
3287 * symfile.c (set_initial_language): Update.
3288 * symtab.h (main_name): Constify return type.
3289
d8f68fcb
TT
32902019-07-17 Tom Tromey <tom@tromey.com>
3291
3292 * tui/tui-winsource.c (tui_update_source_window)
3293 (tui_update_source_window_as_is)
3294 (tui_update_source_windows_with_line): Remove return.
3295 * tui/tui-disasm.c (tui_show_disassem)
3296 (tui_show_disassem_and_update_source): Remove return.
3297 * tui/tui.c (tui_reset): Remove return.
3298 * tui/tui-wingeneral.c
3299 (tui_check_and_display_highlight_if_needed): Remove return.
3300
ca5af91e
TT
33012019-07-17 Tom Tromey <tom@tromey.com>
3302
3303 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3304
5104fe36
TT
33052019-07-17 Tom Tromey <tom@tromey.com>
3306
3307 * tui/tui-winsource.h (struct tui_exec_info_window)
3308 (struct tui_source_window_base): Move from tui-data.h.
3309 * tui/tui-winsource.c: Move many method definitions from
3310 elsewhere. Remove "structuring" comments.
3311 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3312 (tui_source_window_base::refresh_window): Move to
3313 tui-winsource.c.
3314 * tui/tui-win.c (tui_source_window_base::refresh_all)
3315 (tui_source_window_base::update_tab_width)
3316 (tui_source_window_base::set_new_height)
3317 (tui_source_window_base::do_make_visible_with_new_height): Move to
3318 tui-winsource.c.
3319 * tui/tui-source.h: Update.
3320 * tui/tui-source.c (tui_source_window_base::reset): Move to
3321 tui-winsource.c.
3322 * tui/tui-disasm.h: Update.
3323 * tui/tui-data.h (struct tui_exec_info_window): Move to
3324 tui-winsource.h.
3325 (struct tui_source_window_base): Likewise.
3326 * tui/tui-data.c (tui_source_window_base::clear_detail)
3327 (tui_source_window_base, ~tui_source_window_base): Move to
3328 tui-winsource.c.
3329
daa15dde
TT
33302019-07-17 Tom Tromey <tom@tromey.com>
3331
3332 * tui/tui-win.c (tui_resize_all)
3333 (tui_source_window_base::update_tab_width)
3334 (tui_adjust_win_heights): Update.
3335 (tui_win_info::make_invisible_and_set_new_height): Rename from
3336 make_invisible_and_set_new_height.
3337 * tui/tui-data.h (struct tui_win_info)
3338 <make_invisible_and_set_new_height>: New method.
3339
bfad4537
TT
33402019-07-17 Tom Tromey <tom@tromey.com>
3341
3342 * tui/tui.c: Update.
3343 * tui/tui-source.h (struct tui_source_window): Move from
3344 tui-data.h.
3345 * tui/tui-layout.c: Update.
3346 * tui/tui-disasm.c: Update.
3347 * tui/tui-data.h (struct tui_source_window): Move to
3348 tui-source.h.
3349
88f7e873
TT
33502019-07-17 Tom Tromey <tom@tromey.com>
3351
3352 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3353 tui-data.h.
3354 * tui/tui-data.h (struct tui_disasm_window): Move to
3355 tui-disasm.h.
3356
96bd6233
TT
33572019-07-17 Tom Tromey <tom@tromey.com>
3358
3359 * tui/tui-regs.h (struct tui_data_item_window): Move from
3360 tui-data.h.
3361 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3362 * tui/tui-data.h (struct tui_data_item_window): Move to
3363 tui-regs.h.
3364 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3365
ce38393b
TT
33662019-07-17 Tom Tromey <tom@tromey.com>
3367
3368 * tui/tui.c: Update.
3369 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3370 (tui_cmd_window::max_height): Move to tui-command.c.
3371 * tui/tui-layout.c: Update.
3372 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3373 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3374 tui-command.c.
3375 * tui/tui-command.h (struct tui_cmd_window): Move from
3376 tui-data.h.
3377 * tui/tui-command.c: Remove "structuring" comments.
3378 (tui_cmd_window::clear_detail)
3379 (tui_cmd_window::do_make_visible_with_new_height)
3380 (tui_cmd_window::max_height): Move from elsewhere.
3381
2d8b51cb
TT
33822019-07-17 Tom Tromey <tom@tromey.com>
3383
3384 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3385 Now static.
3386 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3387 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3388
18ab23af
TT
33892019-07-17 Tom Tromey <tom@tromey.com>
3390
3391 * tui/tui.c: Update.
3392 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3393 tui-regs.c.
3394 * tui/tui-windata.h: Remove file.
3395 * tui/tui-windata.c: Remove file.
3396 * tui/tui-win.c (tui_data_window::set_new_height)
3397 (tui_data_window::do_make_visible_with_new_height): Move to
3398 tui-regs.c.
3399 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3400 * tui/tui-regs.c: Remove "structuring" comments.
3401 (tui_data_window::first_data_item_displayed)
3402 (tui_data_window::delete_data_content_windows)
3403 (tui_data_window::erase_data_content)
3404 (tui_data_window::display_all_data)
3405 (tui_data_window::refresh_all)
3406 (tui_data_window::do_scroll_vertical)
3407 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3408 (tui_data_window::do_make_visible_with_new_height)
3409 (tui_data_window::refresh_window): Move from elsewhere.
3410 (_initialize_tui_regs): Move to end of file.
3411 * tui/tui-layout.c: Update.
3412 * tui/tui-hooks.c: Update.
3413 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3414 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3415 tui-regs.c.
3416 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3417
88b7e7cc
TT
34182019-07-17 Tom Tromey <tom@tromey.com>
3419
3420 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3421 seen.
3422
0fcd3711
TT
34232019-07-17 Tom Tromey <tom@tromey.com>
3424
3425 * tui/tui-win.c (tui_source_window_base::set_new_height)
3426 (tui_source_window_base::do_make_visible_with_new_height): Use
3427 m_has_locator field directly.
3428 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3429 method.
3430 (struct tui_source_window_base) <has_locator>: Likewise.
3431
4a38112d
TT
34322019-07-17 Tom Tromey <tom@tromey.com>
3433
3434 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3435 Don't declare.
3436 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3437 Remove.
3438 * tui/tui-win.c (tui_source_window_base::set_new_height)
3439 (tui_source_window_base::set_new_height)
3440 (make_invisible_and_set_new_height)
3441 (tui_source_window_base::do_make_visible_with_new_height)
3442 (tui_source_window_base::do_make_visible_with_new_height):
3443 Update.
3444 * tui/tui-layout.c (show_source_disasm_command, show_data)
3445 (show_source_or_disasm_and_command): Update.
3446 * tui/tui-layout.c (show_layout): Update.
3447
09129226
TT
34482019-07-17 Tom Tromey <tom@tromey.com>
3449
3450 * tui/tui-layout.c (make_data_window): Remove.
3451 (show_data): Unify creation and re-initialization cases.
3452
4a8a5e84
TT
34532019-07-17 Tom Tromey <tom@tromey.com>
3454
3455 * tui/tui-layout.c (make_source_window, make_disasm_window):
3456 Remove.
3457 (show_data): Unify creation and re-initialization cases.
3458
76d2be8e
TT
34592019-07-17 Tom Tromey <tom@tromey.com>
3460
3461 * tui/tui-layout.c (make_command_window): Remove.
3462 (show_source_disasm_command, show_source_or_disasm_and_command):
3463 Unify creation and re-initialization cases.
3464
890b8bde
TT
34652019-07-17 Tom Tromey <tom@tromey.com>
3466
3467 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3468 creation and re-initialization cases.
3469
2cdfa113
TT
34702019-07-17 Tom Tromey <tom@tromey.com>
3471
3472 * tui/tui-regs.c (tui_get_register): Return void.
3473
8e3cfd09
TT
34742019-07-17 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3477 Simplify.
3478
f4e04977
TT
34792019-07-17 Tom Tromey <tom@tromey.com>
3480
3481 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3482 resetting.
3483
0379b883
TT
34842019-07-17 Tom Tromey <tom@tromey.com>
3485
3486 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3487 * tui/tui-regs.c (tui_reg_layout): New function.
3488 (tui_show_registers, tui_reg_command): Use it.
3489 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3490 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3491 parameters.
3492 (tui_layout_command): Remove.
3493
b7fbad91
TT
34942019-07-17 Tom Tromey <tom@tromey.com>
3495
3496 * tui/tui-layout.h (tui/tui-layout): Return void.
3497 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3498
4e1e56b9
TT
34992019-07-17 Tom Tromey <tom@tromey.com>
3500
3501 * tui/tui-layout.c (show_source_disasm_command, show_data):
3502 Update.
3503 (reset_locator): Remove.
3504 (show_source_or_disasm_and_command): Update.
3505
1e0c09ba
TT
35062019-07-17 Tom Tromey <tom@tromey.com>
3507
3508 * tui/tui-source.c (tui_source_window_base::reset): Remove
3509 win_type parameter.
3510 * tui/tui-layout.c (make_command_window, make_source_window)
3511 (make_disasm_window, make_data_window)
3512 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3513 (reset_locator, show_source_or_disasm_and_command): Update.
3514 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3515 win_type parameter.
3516 (struct tui_source_window_base) <reset>: Likewise.
3517
1bf605de
TT
35182019-07-17 Tom Tromey <tom@tromey.com>
3519
3520 * tui/tui-layout.c (show_source_disasm_command): Use
3521 reset_locator.
3522 (reset_locator): New function.
3523 (init_and_make_win): Remove.
3524 (show_source_or_disasm_and_command): Use reset_locator.
3525
098f9ed4
TT
35262019-07-17 Tom Tromey <tom@tromey.com>
3527
3528 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3529 condition.
3530 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3531 Remove condition.
3532 * tui/tui-source.c (tui_source_window_base::reset): New method.
3533 * tui/tui-layout.c (make_command_window): Don't call
3534 init_and_make_win.
3535 (make_source_window, make_disasm_window): Don't call
3536 make_source_or_disasm_window.
3537 (make_data_window): Don't call init_and_make_win. Change calling
3538 convention.
3539 (show_source_disasm_command, show_data): Simplify.
3540 (make_source_or_disasm_window): Remove.
3541 (show_source_or_disasm_and_command): Simplify.
3542 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3543 (struct tui_source_window_base) <reset>: Likewise.
3544 <execution_info>: Remove initializer.
3545 * tui/tui-data.c (tui_source_window_base): Initialize
3546 execution_info.
3547
80110957
TT
35482019-07-17 Tom Tromey <tom@tromey.com>
3549
3550 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3551 variable.
3552
cf82af05
TT
35532019-07-17 Tom Tromey <tom@tromey.com>
3554
3555 * tui/tui.c (tui_rl_other_window): Update.
3556 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3557 superclass method first. Always iterate over regs_content.
3558 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3559 method.
3560 * tui/tui-win.c (tui_set_focus_command): Update.
3561
01aeb396
TT
35622019-07-17 Tom Tromey <tom@tromey.com>
3563
3564 * tui/tui-win.c (tui_set_focus_command): Rename from
3565 tui_set_focus. Call tui_enable.
3566 (tui_set_focus_command): Remove.
3567
fd6c75ee
TT
35682019-07-17 Tom Tromey <tom@tromey.com>
3569
3570 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3571 refresh_window.
3572 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3573 touchwin.
3574 (tui_data_window::refresh_window): Call refresh_window on data
3575 items. Always call superclass refresh_window.
3576 (tui_win_info::refresh): Remove.
3577 (tui_source_window_base::refresh_window): Update.
3578 (tui_refresh_all): Update.
3579 * tui/tui-layout.c (show_source_disasm_command): Remove call to
3580 refresh_window.
3581 (show_source_or_disasm_and_command): Likewise.
3582 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3583 (struct tui_source_window_base) <refresh>: Likewise.
3584
f6cc34a9
TT
35852019-07-17 Tom Tromey <tom@tromey.com>
3586
3587 * tui/tui-winsource.c (tui_clear_source_content)
3588 (tui_show_source_content): Update.
3589 * tui/tui-source.c (tui_source_window::showing_source_p): Check
3590 whether content is empty.
3591 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3592 Remove.
3593
f31ec9af
TT
35942019-07-17 Tom Tromey <tom@tromey.com>
3595
3596 * tui/tui-winsource.c (tui_erase_source_content): Clear the
3597 window's contents.
3598 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3599 * tui/tui-source.c (tui_set_source_content_nil): Remove.
3600
d1b6f1e5
TT
36012019-07-17 Tom Tromey <tom@tromey.com>
3602
3603 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3604 (struct tui_data_item_window): Update.
3605
d9743a13
TT
36062019-07-17 Tom Tromey <tom@tromey.com>
3607
3608 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3609 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3610 defines.
3611
caf0bc4e
TT
36122019-07-17 Tom Tromey <tom@tromey.com>
3613
3614 * tui/tui-winsource.h (tui_erase_source_content)
3615 (tui_clear_source_content): Remove "display_prompt" parameter.
3616 * tui/tui-winsource.c (tui_update_source_window_as_is)
3617 (tui_update_source_windows_with_addr): Update.
3618 (tui_clear_source_content): Remove "display_prompt" parameter.
3619 (tui_erase_source_content): Likewise. Simplify.
3620 (tui_show_source_content): Update.
3621 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3622 * tui/tui-stack.c (tui_show_frame_info): Update.
3623 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3624 Remove defines.
3625
9d391078
TT
36262019-07-17 Tom Tromey <tom@tromey.com>
3627
3628 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3629 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3630 parameter.
3631 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3632 parameter.
3633
a38da35d
TT
36342019-07-17 Tom Tromey <tom@tromey.com>
3635
3636 * tui/tui-winsource.c (tui_clear_source_content)
3637 (tui_show_source_content, tui_show_exec_info_content)
3638 (tui_clear_exec_info_content): Update.
3639 * tui/tui-stack.c (tui_show_locator_content): Update.
3640 (tui_show_frame_info): Update.
3641 * tui/tui-source.h (tui_source_window): Don't declare.
3642 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3643 from tui_source_is_displayed.
3644 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3645 Remove field.
3646 (struct tui_source_window_base) <content_in_use>: New field. Now
3647 bool.
3648 (struct tui_source_window) <showing_source_p>: New method.
3649 (TUI_SRC_WIN): Change cast.
3650 * tui/tui-data.c (tui_initialize_static_data): Update.
3651
c2cd8994
TT
36522019-07-17 Tom Tromey <tom@tromey.com>
3653
3654 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3655 location_matches_p.
3656 * tui/tui-source.c (tui_source_window::location_matches_p): New
3657 method.
3658 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3659 method.
3660 * tui/tui-data.h (struct tui_source_window_base)
3661 <location_matches_p>: New method.
3662 (struct tui_source_window, struct tui_disasm_window)
3663 <location_matches_p>: Likewise.
3664
4dde7b34
TT
36652019-07-17 Tom Tromey <tom@tromey.com>
3666
3667 * tui/tui-win.c (tui_set_win_height_command): Rename from
3668 tui_set_win_height.
3669 (tui_set_win_height_command): Remove.
3670
b73dd877
TT
36712019-07-17 Tom Tromey <tom@tromey.com>
3672
3673 * tui/tui-source.c (tui_source_window): New constructor. Add
3674 observer.
3675 (~tui_source_window): New destructor.
3676 (tui_source_window::style_changed): New method.
3677 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3678 (tui_attach_detach_observers): Update.
3679 * tui/tui-data.h (struct tui_source_window): Make constructor not
3680 inline. Add destructor.
3681 (struct tui_source_window) <style_changed>: New method.
3682 <m_observable>: New member.
3683
ae2b5380
TT
36842019-07-17 Tom Tromey <tom@tromey.com>
3685
3686 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3687 * tui/tui-win.c (tui_resize_all): Fix typo.
3688
1ce3e844
TT
36892019-07-17 Tom Tromey <tom@tromey.com>
3690
3691 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3692 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3693 (tui_refresh_all): Remove "list" parameter. Use foreach.
3694 * tui/tui-win.c (window_name_completer): Use foreach.
3695 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3696 (update_tab_width): Likewise.
3697 * tui/tui-layout.c (show_layout): Update.
3698 * tui/tui-data.h (class tui_window_iterator): New.
3699 (struct all_tui_windows): New.
3700 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3701
fe3eaf1c
TT
37022019-07-17 Tom Tromey <tom@tromey.com>
3703
3704 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3705 parameter. Don't reference globals.
3706 (tui_reg_command): Update.
3707
368c1354
TT
37082019-07-17 Tom Tromey <tom@tromey.com>
3709
3710 * tui/tui-regs.c (tui_show_registers): Simplify.
3711
e80cd204
TT
37122019-07-17 Tom Tromey <tom@tromey.com>
3713
3714 * tui/tui-regs.c (tui_show_registers): Update.
3715 (tui_show_register_group): Add win_info parameter.
3716
aca2dd16
TT
37172019-07-17 Tom Tromey <tom@tromey.com>
3718
3719 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3720 Rename from tui_display_reg_element_at_line.
3721 (tui_data_window::display_registers_from_line): Update.
3722 * tui/tui-data.h (struct tui_data_window)
3723 <display_reg_element_at_line>: New method.
3724
517e9505
TT
37252019-07-17 Tom Tromey <tom@tromey.com>
3726
3727 * tui/tui-regs.h (tui_display_registers_from)
3728 (tui_display_registers_from_line): Don't declare.
3729 * tui/tui-windata.c (tui_data_window::display_all_data)
3730 (tui_data_window::refresh_all)
3731 (tui_data_window::do_scroll_vertical): Update.
3732 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3733 from tui_display_registers_from.
3734 (tui_display_reg_element_at_line): Update.
3735 (tui_data_window::display_registers_from_line): Rename from
3736 tui_display_registers_from_line.
3737 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3738 display_registers_from_line>: New methods.
3739
f76d8b19
TT
37402019-07-17 Tom Tromey <tom@tromey.com>
3741
3742 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3743 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3744 from tui_erase_data_content.
3745 (tui_data_window::display_all_data)
3746 (tui_data_window::refresh_all)
3747 (tui_data_window::do_scroll_vertical): Update.
3748 * tui/tui-regs.c (tui_show_registers): Update.
3749 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3750 New method.
3751
b4094625
TT
37522019-07-17 Tom Tromey <tom@tromey.com>
3753
3754 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3755 declare.
3756 * tui/tui-windata.c
3757 (tui_data_window::delete_data_content_windows): Rename from
3758 tui_delete_data_content_windows.
3759 (tui_data_window::display_all_data)
3760 (tui_data_window::do_scroll_vertical): Update.
3761 * tui/tui-data.h (struct tui_data_window)
3762 <delete_data_content_windows>: New method.
3763
c223a729
TT
37642019-07-17 Tom Tromey <tom@tromey.com>
3765
3766 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3767 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3768
50daf268
TT
37692019-07-17 Tom Tromey <tom@tromey.com>
3770
3771 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3772 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3773 from tui_display_all_data.
3774 * tui/tui-win.c
3775 (tui_data_window::do_make_visible_with_new_height): Update.
3776 * tui/tui-regs.c (tui_show_registers): Update.
3777 * tui/tui-layout.c (tui_set_layout): Update.
3778 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3779 method.
3780
df5f8cab
TT
37812019-07-17 Tom Tromey <tom@tromey.com>
3782
3783 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3784 * tui/tui-windata.c (tui_display_data_from): Remove.
3785 (tui_data_window::refresh_all): Update.
3786
80cb6c27
TT
37872019-07-17 Tom Tromey <tom@tromey.com>
3788
3789 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3790 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3791 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3792 tui_display_registers_from_line.
3793 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3794 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3795 "force_display" parameter.
3796
baff0c28
TT
37972019-07-17 Tom Tromey <tom@tromey.com>
3798
3799 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3800 declare.
3801 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3802 Rename from tui_first_reg_element_no_inline.
3803 (tui_display_reg_element_at_line)
3804 (tui_display_registers_from_line): Update.
3805 * tui/tui-data.h (struct tui_data_window)
3806 <first_reg_element_no_inline>: New method.
3807
3b23c5f2
TT
38082019-07-17 Tom Tromey <tom@tromey.com>
3809
3810 * tui/tui-windata.c (tui_display_data_from)
3811 (tui_data_window::do_scroll_vertical): Update.
3812 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3813 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3814 Rename from tui_line_from_reg_element_no.
3815 (tui_display_registers_from_line): Update.
3816 * tui/tui-data.h (struct tui_data_window)
3817 <line_from_reg_element_no>: New method.
3818
0b5ec218
TT
38192019-07-17 Tom Tromey <tom@tromey.com>
3820
3821 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3822 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3823 tui_last_regs_line_no.
3824 (tui_display_reg_element_at_line)
3825 (tui_display_registers_from_line): Update.
3826 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3827 method.
3828
0807ab7b
TT
38292019-07-17 Tom Tromey <tom@tromey.com>
3830
3831 PR tui/24722:
3832 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3833 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3834 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3835 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3836 (tui_update_breakpoint_info): Likewise.
3837 * tui/tui-hooks.c (tui_event_create_breakpoint)
3838 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3839 Update.
3840
9ad7fdef
TT
38412019-07-17 Tom Tromey <tom@tromey.com>
3842
3843 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3844
5813316f
TT
38452019-07-17 Tom Tromey <tom@tromey.com>
3846
3847 * tui/tui-winsource.c (tui_update_source_window_as_is)
3848 (tui_update_source_windows_with_addr): Update.
3849 * tui/tui-source.h (tui_set_source_content)
3850 (tui_show_symtab_source): Add "win_info" parameter.
3851 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3852 parameter.
3853 (tui_show_symtab_source): Likewise.
3854
00e264e7
TT
38552019-07-17 Tom Tromey <tom@tromey.com>
3856
3857 * tui/tui-wingeneral.c
3858 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3859
06210ce4
TT
38602019-07-17 Tom Tromey <tom@tromey.com>
3861
3862 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3863 (struct tui_cmd_window) <can_scroll>: New method.
3864 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3865 method.
3866
381befee
TT
38672019-07-17 Tom Tromey <tromey@adacore.com>
3868
3869 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3870 do_field_signed>: Rename. Change type of "value".
3871 * ui-out.c (ui_out::field_signed): Rename from field_int.
3872 Change type of "value".
3873 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3874 type of "value".
3875 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3876 do_field_int. Change type of "value".
3877 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3878 do_field_int. Change type of "value".
3879 * tracepoint.c (trace_status_mi, tfind_1)
3880 (print_one_static_tracepoint_marker): Update.
3881 * thread.c (print_thread_info_1, print_selected_thread_frame):
3882 Update.
3883 * stack.c (print_frame, print_frame_info): Update.
3884 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3885 Update.
3886 * source.c (print_source_lines_base): Update.
3887 * skip.c (info_skip_command): Update.
3888 * record-btrace.c (btrace_ui_out_decode_error)
3889 (btrace_call_history_src_line): Update.
3890 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3891 Update.
3892 * progspace.c (print_program_space): Update.
3893 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3894 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3895 do_field_int. Change type of "value".
3896 * mi/mi-out.c (mi_ui_out::do_table_begin)
3897 (mi_ui_out::do_table_header): Update.
3898 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3899 type of "value".
3900 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3901 (mi_cmd_data_list_changed_registers, output_register)
3902 (mi_cmd_data_read_memory, mi_load_progress)
3903 (mi_cmd_trace_frame_collected): Update.
3904 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3905 Update.
3906 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3907 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3908 (mi_cmd_var_list_children, varobj_update_one): Update.
3909 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3910 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3911 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3912 * inferior.c (print_inferior): Update.
3913 * gdb_bfd.c (print_one_bfd): Update.
3914 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3915 Update.
3916 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3917 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3918 do_field_int. Change type of "value".
3919 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3920 do_field_int. Change type of "value".
3921 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3922 (print_one_breakpoint_location, print_it_catch_fork)
3923 (print_one_catch_fork, print_it_catch_vfork)
3924 (print_one_catch_vfork, print_it_catch_solib)
3925 (print_it_catch_exec, print_it_ranged_breakpoint)
3926 (print_mention_watchpoint, print_mention_masked_watchpoint)
3927 (bkpt_print_it, update_static_tracepoint): Update.
3928 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3929 * break-catch-syscall.c (print_it_catch_syscall): Update.
3930 * ada-tasks.c (print_ada_task_info): Update.
3931 * ada-lang.c (print_it_exception, print_mention_exception):
3932 Update.
3933
6b78c3f8
AB
39342019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3935
3936 PR breakpoints/24541
3937 * gdbarch.c: Regenerate.
3938 * gdbarch.h: Regenerate.
3939 * gdbarch.sh: Adjust return type and parameter types for
3940 'stap_adjust_register'.
3941 (i386_stap_adjust_register): Adjust signature and return new
3942 register name.
3943 * stap-probe.c (stap_parse_register_operand): Adjust use of
3944 'gdbarch_stap_adjust_register'.
3945
d72a9b85
TT
39462019-07-17 Tom Tromey <tromey@adacore.com>
3947
3948 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3949 declare VEC.
3950 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3951 std::vector.
3952 (struct s390_process_info): Add initializers.
3953 (s390_add_process): Use new.
3954 (s390_linux_nat_target::low_forget_process): Use delete.
3955 (s390_linux_nat_target::low_new_fork)
3956 (s390_linux_nat_target::stopped_by_watchpoint)
3957 (s390_linux_nat_target::low_prepare_to_resume)
3958 (s390_linux_nat_target::insert_watchpoint)
3959 (s390_linux_nat_target::insert_hw_breakpoint)
3960 (s390_linux_nat_target::remove_watchpoint)
3961 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3962
206e6c58
JB
39632019-07-16 John Baldwin <jhb@FreeBSD.org>
3964
3965 * aarch64-fbsd-nat.c: Include regcache.h.
3966 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3967 argument.
3968 (aarch64_fbsd_nat_target::fetch_registers)
3969 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3970 variable.
3971 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3972
cbde90f2
JB
39732019-07-16 John Baldwin <jhb@FreeBSD.org>
3974
3975 * fbsd-nat.c: Include gdbarch.h.
3976
07128006
TT
39772019-07-15 Tom Tromey <tromey@adacore.com>
3978
3979 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3980
1f77b012
TT
39812019-07-15 Tom Tromey <tromey@adacore.com>
3982
3983 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3984 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3985 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3986 * cli-out.c (cli_ui_out::do_field_int): New method.
3987 * ui-out.c (ui_out::field_unsigned): New method.
3988 * symfile.c (generic_load): Use field_unsigned.
3989 (print_transfer_performance): Likewise.
3990 * record-btrace.c (ui_out_field_uint): Remove.
3991 (btrace_call_history_insn_range, btrace_call_history): Use
3992 field_unsigned.
3993 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3994 field_unsigned.
3995 * ui-out.h (class ui_out) <field_unsigned>: New method.
3996 <do_field_unsigned>: Likewise.
3997
33eca680
TT
39982019-07-15 Tom Tromey <tromey@adacore.com>
3999
4000 * mi/mi-main.c (list_available_thread_groups): Use field_string.
4001 * mi/mi-interp.c (mi_memory_changed): Use field_string.
4002 * target.c (flash_erase_command): Use field_string.
4003 * infrun.c (print_signal_received_reason): Use field_string.
4004 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4005 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4006 field_string.
4007 * ada-tasks.c (print_ada_task_info): Use field_string.
4008
ca8d69be
TT
40092019-07-15 Tom Tromey <tromey@adacore.com>
4010
4011 * target.c (flash_erase_command): Use field_core_addr.
4012 * symfile.c (generic_load): Use field_core_addr.
4013 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4014 Use field_core_addr.
4015 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4016 field_core_addr.
4017
0d4e84ed
AB
40182019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4019
4020 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4021 value if its desired type is smaller than a CORE_ADDR and signed.
4022
9a49df9d
AB
40232019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4024
4025 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4026 of changes to field names, and use new is_reference field to
4027 decide if a property is a reference or not.
4028 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4029 field.
4030 (struct dwarf2_property_baton): Update header comment, rename
4031 'referenced_type' to 'property_type' and update comments.
4032 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4033 default property type, store in property baton, update to take
4034 accound of renamed field.
4035 (read_func_scope): Update call to attr_to_dynamic_prop.
4036 (read_array_type): Likewise.
4037 (dwarf2_per_cu_addr_sized_int_type): New function.
4038 (read_subrange_index_type): Move type finding code to
4039 dwarf2_per_cu_addr_sized_int_type.
4040 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4041 (dwarf2_per_cu_addr_type): New function.
4042 (set_die_type): Update calls to attr_to_dynamic_prop.
4043
b86352cf
AB
40442019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4045
4046 * dwarf2read.c (read_subrange_index_type): New function.
4047 (read_subrange_type): Move code into new function and call it.
4048 * gdbtypes.c (create_range_type): Add some asserts.
4049
603490bf
AB
40502019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4051
4052 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4053 update return statements.
4054 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4055 declaration, and update comment to match.
4056 * gdbtypes.c (resolve_dynamic_array): Update call to
4057 dwarf2_evaluate_property to match new return type.
4058
592f9d27
AB
40592019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4060
4061 * valarith.c (value_subscripted_rvalue): Change lowerbound
4062 parameter type from int to LONGEST.
4063 * value.h (value_subscripted_rvalue): Likewise in declaration.
4064
60cfcb20
AB
40652019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4066
4067 * cli/cli-utils.c (info_print_command_completer): New function.
4068 * cli/cli-utils.h: Add 'completer.h' include, and forward
4069 declaration for 'struct cmd_list_element'.
4070 (info_print_command_completer): Declare.
4071 * stack.c (_initialize_stack): Add completer for 'info locals' and
4072 'info args'.
4073 * symtab.c (_initialize_symtab): Add completer for 'info
4074 variables' and 'info functions'.
4075 * NEWS: Mention completion for additional info commands.
4076
b16507e0
AB
40772019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4078
4079 * cli/cli-utils.c (extract_info_print_args): Delete.
4080 (extract_arg_maybe_quoted): Delete.
4081 (info_print_options_defs): New variable.
4082 (make_info_print_options_def_group): New function.
4083 (extract_info_print_options): Define new function.
4084 * cli/cli-utils.h (extract_info_print_args): Delete.
4085 (struct info_print_options): New structure.
4086 (extract_info_print_options): Declare new function.
4087 * stack.c (info_locals_command): Update to use new
4088 extract_info_print_options, also add a header comment.
4089 (info_args_command): Likewise.
4090 * symtab.c (info_variables_command): Likewise.
4091 (info_functions_command): Likewise.
4092
021d8588
AB
40932019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4094
4095 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4096 to extract string arguments.
4097 * common/common-utils.c (extract_string_maybe_quoted): New function.
4098 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4099
b777eb6d
TT
41002019-07-11 Tom Tromey <tromey@adacore.com>
4101
4102 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4103 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4104 * top.h (gdbinit): Don't declare.
4105 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4106 into...
4107 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4108 * top.c (gdb_init): Don't call init_cli_cmds.
4109 (gdbinit): Remove.
4110 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4111
72ee03ff
TT
41122019-07-11 Tom Tromey <tromey@adacore.com>
4113
4114 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4115 after it has been moved.
4116
00db9531
SM
41172019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4118
4119 * valops.c (value_must_coerce_to_target): Change return type to
4120 bool.
4121 * value.h (value_must_coerce_to_target): Likewise.
4122
f2478a7e
SM
41232019-07-10 Simon Marchi <simon.marchi@efficios.com>
4124
4125 * breakpoint.c (is_hardware_watchpoint): Remove
4126 forward-declaration.
4127 (is_masked_watchpoint): Change return type to bool.
4128 (is_tracepoint): Likewise.
4129 (is_breakpoint): Likewise.
4130 (is_hardware_watchpoint): Likewise.
4131 (is_watchpoint): Likewise.
4132 (is_no_memory_software_watchpoint): Likewise.
4133 (is_catchpoint): Likewise.
4134 (breakpoint_1): Make FILTER parameter's return type bool.
4135 is_masked_watchpoint): Change return type to bool.
4136 (save_breakpoints): Make FILTER parameter's return type bool.
4137 * breakpoint.h (is_breakpoint): Change return type to bool.
4138 (is_watchpoint): Likewise.
4139 (is_catchpoint): Likewise.
4140 (is_tracepoint): Likewise.
4141
0d12e84c
TT
41422019-07-10 Tom Tromey <tom@tromey.com>
4143
4144 * defs.h: Don't include gdbarch.h.
4145 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4146 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4147 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4148 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4149 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4150 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4151 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4152 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4153 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4154 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4155 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4156 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4157 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4158 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4159 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4160 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4161 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4162 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4163 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4164 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4165 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4166 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4167 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4168 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4169 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4170 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4171 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4172
f06f1252
TT
41732019-07-10 Tom Tromey <tromey@adacore.com>
4174
4175 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4176 * breakpoint.c (init_ada_exception_breakpoint): Register as
4177 bp_catchpoint.
4178 (print_one_breakpoint_location, print_one_breakpoint): Use
4179 is_ada_exception_catchpoint.
4180 * ada-lang.c (class ada_catchpoint_location): Pass
4181 bp_loc_software_breakpoint to bp_location constructor.
4182 (is_ada_exception_catchpoint): New function.
4183
7a5d944b
TT
41842019-07-10 Tom Tromey <tromey@adacore.com>
4185
4186 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4187 VEC.
4188 (struct arm_exidx_entry): New method operator<.
4189 (struct arm_exidx_data) <section_maps>: Change type.
4190 (arm_exidx_data_free): Remove.
4191 (arm_exidx_data_key): Change type. Move lower.
4192 (arm_exidx_new_objfile): Update.
4193 (arm_compare_exidx_entries): Remove.
4194 (arm_find_exidx_entry, _initialize_arm_tdep)
4195
48c66e1d
TT
41962019-07-10 Tom Tromey <tromey@adacore.com>
4197
4198 * solib-spu.c (ocl_program_data_key): Change type.
4199 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4200 Update.
4201
a269fbf1
TT
42022019-07-10 Tom Tromey <tromey@adacore.com>
4203
4204 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4205 (struct solib_aix_inferior_data) <library_list>: Change type.
4206 (solib_aix_inferior_data_handle): Change type.
4207 (get_solib_aix_inferior_data): Update.
4208 (solib_aix_free_library_list): Remove.
4209 (library_list_start_library): Update.
4210 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4211 return type.
4212 (solib_aix_get_library_list)
4213 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4214 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4215
c294730c
TT
42162019-07-10 Tom Tromey <tromey@adacore.com>
4217
4218 * solib-dsbt.c (struct dsbt_info): Add initializers.
4219 (solib_dsbt_pspace_data): Change type.
4220 (dsbt_pspace_data_cleanup): Remove.
4221 (get_dsbt_info, _initialize_dsbt_solib): Update.
4222
9d52077d
TT
42232019-07-10 Tom Tromey <tromey@adacore.com>
4224
4225 * spu-tdep.c (spu_overlay_data): Change type.
4226 (spu_get_overlay_table, spu_overlay_new_objfile)
4227 (_initialize_spu_tdep): Update.
4228
22a20dca
TT
42292019-07-10 Tom Tromey <tromey@adacore.com>
4230
4231 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4232 destructor.
4233 (dbx_objfile_data_key): Change type and declare later.
4234 (DBX_SYMFILE_INFO): Rewrite.
4235 * dbxread.c (dbx_objfile_data_key): Change type.
4236 (dbx_symfile_init): Update.
4237 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4238 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4239 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4240
cb60f420
TT
42412019-07-10 Tom Tromey <tromey@adacore.com>
4242
4243 * jit.c (jit_program_space_key): Change type. Move lower.
4244 (get_jit_program_space_data): Update.
4245 (jit_program_space_data_cleanup): Remove.
4246 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4247 Update.
4248 (struct jit_program_space_data): Add initializers.
4249
51df2ae3
TT
42502019-07-10 Tom Tromey <tromey@adacore.com>
4251
4252 * solib-darwin.c (struct darwin_info): Add initializers.
4253 (solib_darwin_pspace_data): Change type.
4254 (darwin_pspace_data_cleanup): Remove.
4255 (get_darwin_info, _initialize_darwin_solib): Update.
4256
18101a35
TT
42572019-07-10 Tom Tromey <tromey@adacore.com>
4258
4259 * remote-sim.c (struct sim_inferior_data): Add initializers,
4260 constructor, and destructor.
4261 (sim_inferior_data_key): Change type. Move lower.
4262 (check_for_duplicate_sim_descriptor): Update.
4263 (get_sim_inferior_data): Use new. Update.
4264 (~sim_inferior_data_cleanup): Rename from
4265 sim_inferior_data_cleanup. Simplify.
4266 (gdbsim_close_inferior, simulator_command)
4267 (sim_command_completer, _initialize_remote_sim): Update.
4268 (next_pid, INITIAL_PID): Move earlier.
4269
05b08ac1
TT
42702019-07-10 Tom Tromey <tromey@adacore.com>
4271
4272 * python/python-internal.h (create_thread_object): Return
4273 gdbpy_ref.
4274 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4275 * python/py-inferior.c (struct threadlist_entry): Add
4276 constructor.
4277 <thread_obj>: Now a gdbpy_ref.
4278 (thread_to_thread_object): Update.
4279 (add_thread_object): Use new.
4280 (delete_thread_object): Use delete.
4281 (infpy_threads): Update.
4282 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4283 GIL.
4284
32372d80
TT
42852019-07-10 Tom Tromey <tromey@adacore.com>
4286
4287 * valops.c (value_cast): Specialize error message for Ada.
4288
5c458ae8
SM
42892019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4290
4291 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4292
4c462cb0
SM
42932019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4294
4295 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4296 bpstat_should_step): Return bool, adjust comments.
4297 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4298 bpstat_should_step): Likewise.
4299
89abbcc2
AH
43002019-07-10 Alan Hayward <alan.hayward@arm.com>
4301
4302 * features/Makefile: Use feature target descriptions for Arm.
4303 * features/arm/arm-core.c: Generate new file.
4304 * features/arm/arm-fpa.c: Likewise.
4305 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4306 * features/arm/arm-m-profile.c: Likewise.
4307 * features/arm/arm-vfpv2.c: Likewise.
4308 * features/arm/arm-vfpv3.c: Likewise.
4309 * features/arm/xscale-iwmmxt.c: Likewise.
4310 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4311
166a82be
AH
43122019-07-10 Alan Hayward <alan.hayward@arm.com>
4313
4314 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4315 ptrace earlier.
4316
9fb4c7e9
AH
43172019-07-10 Alan Hayward <alan.hayward@arm.com>
4318
4319 * features/aarch64-pauth.c: Regenerate.
4320
e2d0f980
SM
43212019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4322
4323 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4324 bool.
4325 (bpstat_what): Use false instead of 0.
4326
a38118e5
PA
43272019-07-09 Pedro Alves <palves@redhat.com>
4328
4329 * break-catch-throw.c (is_exception_catchpoint): New.
4330 * breakpoint.c (print_one_breakpoint_location): New parameter
4331 'raw_loc'. Handle it. Use
4332 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4333 looking at the breakpoint's type.
4334 (print_one_breakpoint): If handling "maint info breakpoints", also
4335 print locations of exception catchpoints.
4336 * breakpoint.h (is_exception_catchpoint): Declare.
4337
cb1e4e32
PA
43382019-07-09 Pedro Alves <palves@redhat.com>
4339
4340 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4341 "addr" field.
4342 (allocate_location_exception_catchpoint): New.
4343 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4344 (initialize_throw_catchpoint_ops): Install
4345 allocate_location_exception_catchpoint as allocate_location
4346 method.
4347 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4348 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4349 bp_loc_other.
4350 (breakpoint_address_is_meaningful): Delete.
4351 (bl_address_is_meaningful): New.
4352 (breakpoint_locations_match): Adjust comment.
4353 (bp_location_from_bp_type): New, factored out of...
4354 (bp_location::bp_location(breakpoint *)): ... this.
4355 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4356 factored out of...
4357 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4358 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4359 breakpoint_address_is_meaningful.
4360 (bp_locations_compare): Adjust comment.
4361 (update_global_location_list): Use bl_address_is_meaningful
4362 instead of breakpoint_address_is_meaningful.
4363 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4364 explicit.
4365 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4366 * python/py-breakpoint.c (bppy_get_location): No longer check
4367 whether location is null.
4368
b58a68fe
PA
43692019-07-09 Pedro Alves <palves@redhat.com>
4370
4371 PR c++/15468
4372 * breakpoint.c (print_one_breakpoint_location): Remove
4373 single-location assert.
4374
268a13a5
TT
43752019-07-09 Tom Tromey <tom@tromey.com>
4376
4377 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4378 * configure: Rebuild.
4379 * configure.ac: Change common to gdbsupport.
4380 * gdbsupport: Rename from common.
4381 * acinclude.m4: Change common to gdbsupport.
4382 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4383 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4384 gdbsupport.
4385 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4386 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4387 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4388 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4389 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4390 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4391 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4392 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4393 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4394 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4395 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4396 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4397 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4398 coff-pe-read.c, command.h, compile/compile-c-support.c,
4399 compile/compile-c.h, compile/compile-cplus-symbols.c,
4400 compile/compile-cplus-types.c, compile/compile-cplus.h,
4401 compile/compile-loc2c.c, compile/compile.c, completer.c,
4402 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4403 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4404 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4405 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4406 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4407 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4408 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4409 features/aarch64-core.c, features/aarch64-fpu.c,
4410 features/aarch64-pauth.c, features/aarch64-sve.c,
4411 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4412 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4413 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4414 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4415 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4416 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4417 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4418 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4419 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4420 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4421 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4422 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4423 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4424 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4425 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4426 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4427 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4428 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4429 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4430 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4431 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4432 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4433 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4434 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4435 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4436 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4437 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4438 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4439 minsyms.c, mips-linux-tdep.c, namespace.h,
4440 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4441 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4442 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4443 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4444 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4445 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4446 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4447 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4448 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4449 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4450 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4451 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4452 procfs.c, producer.c, progspace.h, psymtab.h,
4453 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4454 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4455 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4456 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4457 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4458 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4459 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4460 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4461 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4462 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4463 target-memory.c, target.c, target.h, target/waitstatus.c,
4464 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4465 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4466 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4467 unittests/array-view-selftests.c,
4468 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4469 unittests/common-utils-selftests.c,
4470 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4471 unittests/format_pieces-selftests.c,
4472 unittests/function-view-selftests.c,
4473 unittests/lookup_name_info-selftests.c,
4474 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4475 unittests/mkdir-recursive-selftests.c,
4476 unittests/observable-selftests.c,
4477 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4478 unittests/parse-connection-spec-selftests.c,
4479 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4480 unittests/scoped_fd-selftests.c,
4481 unittests/scoped_mmap-selftests.c,
4482 unittests/scoped_restore-selftests.c,
4483 unittests/string_view-selftests.c, unittests/style-selftests.c,
4484 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4485 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4486 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4487 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4488 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4489 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4490
5b0e2db4
AB
44912019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4492
4493 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4494 bool value.
4495 (decode_digits_ordinary): Set explicit_line field in sal.
4496 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4497 symtab_and_line that was set on an explicit line number in
4498 assembler code. Do always update the recorded symtab and line if
4499 we do skip the prologue.
4500
0ba852ab
AB
45012019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4502
4503 * breakpoint.c (set_breakpoint_location_function): Remove
4504 explicit_loc parameter.
4505 (momentary_breakpoint_from_master): Update call to
4506 set_breakpoint_location_function.
4507 (add_location_to_breakpoint): Likewise.
4508
b3a7d171
AB
45092019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4510
4511 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4512 required features based on default bfd type when no specific bfd
4513 is present.
4514
1f6f6e21
PW
45152019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4516
4517 * NEWS: Mention that GDB printf and eval commands can now print
4518 C-style and Ada-style convenience var strings without
4519 calling the inferior.
4520 * printcmd.c (printf_c_string): Locally print GDB internal var
4521 instead of transiting via the inferior.
4522 (printf_wide_c_string): Likewise.
4523
45242019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
4525
4526 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4527
0598af48
TT
45282019-07-04 Tom Tromey <tom@tromey.com>
4529
4530 PR tui/24724:
4531 * tui/tui-winsource.c (tui_clear_source_content): Update.
4532 (tui_source_window_base::set_is_exec_point_at): Fix comment.
4533 (tui_update_breakpoint_info): Update.
4534 (tui_set_exec_info_content): Update.
4535 * tui/tui-source.c (tui_set_source_content_nil): Update.
4536 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4537 has_break.
4538 * tui/tui-data.h (enum tui_bp_flag): New.
4539 (tui_bp_flags): New enum flags type.
4540 (struct tui_source_element) <break_mode>: Change type. Rename
4541 from has_break.
4542 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4543 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
4544 constants.
4545 * tui/tui-winsource.h: Fix comment.
4546
350fab54
AH
45472019-07-04 Alan Hayward <alan.hayward@arm.com>
4548
4549 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4550 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4551 (store_fpregs_to_thread)
4552 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4553 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4554 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4555 (IWMMXT_REGS_SIZE): Add define.
4556 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4557 (fetch_vfp_regs, store_vfp_regs)
4558 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4559 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4560
f0452268
AH
45612019-07-04 Alan Hayward <alan.hayward@arm.com>
4562
4563 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4564 defines.
4565 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4566 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4567 (ARM_INT_REGISTER_SIZE): ...to this.
4568 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4569 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4570 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4571 (arm_linux_collect_gregset, supply_nwfpe_register)
4572 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4573 defines.
4574 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4575 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4576 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4577 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4578 (arm_return_in_memory, arm_store_return_value)
4579 (arm_get_longjmp_target, arm_register_g_packet_guesses)
4580 (arm_record_ld_st_multiple): Likewise.
4581 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4582 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4583
e935475c
AH
45842019-07-04 Alan Hayward <alan.hayward@arm.com>
4585
4586 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4587 AARCH64_DISPLACED_MODIFIED_INSNS.
4588 * aarch64-tdep.c (struct aarch64_displaced_step_data)
4589 (aarch64_displaced_step_copy_insn): Likewise.
4590 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4591 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4592 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4593 ARM_DISPLACED_MODIFIED_INSNS.
4594 * arm-tdep.c (arm_gdbarch_init): Likewise.
4595 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4596 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4597 (struct arm_displaced_step_closure): Use
4598 ARM_DISPLACED_MODIFIED_INSNS.
4599
df0bb381
AH
46002019-07-04 Alan Hayward <alan.hayward@arm.com>
4601
4602 * features/Makefile: Remove unused xml files.
4603 * features/aarch64.xml: Remove.
4604 * features/i386/amd64-avx-avx512-linux.xml: Remove.
4605 * features/i386/amd64-avx-avx512.xml: Remove.
4606 * features/i386/amd64-avx-linux.xml: Remove.
4607 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4608 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4609 * features/i386/amd64-avx-mpx-linux.xml: Remove.
4610 * features/i386/amd64-avx-mpx.xml: Remove.
4611 * features/i386/amd64-avx.xml: Remove.
4612 * features/i386/amd64-linux.xml: Remove.
4613 * features/i386/amd64-mpx-linux.xml: Remove.
4614 * features/i386/amd64-mpx.xml: Remove.
4615 * features/i386/amd64.xml: Remove.
4616 * features/i386/i386-avx-avx512-linux.xml: Remove.
4617 * features/i386/i386-avx-avx512.xml: Remove.
4618 * features/i386/i386-avx-linux.xml: Remove.
4619 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4620 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4621 * features/i386/i386-avx-mpx-linux.xml: Remove.
4622 * features/i386/i386-avx-mpx.xml: Remove.
4623 * features/i386/i386-avx.xml: Remove.
4624 * features/i386/i386-linux.xml: Remove.
4625 * features/i386/i386-mmx-linux.xml: Remove.
4626 * features/i386/i386-mmx.xml: Remove.
4627 * features/i386/i386-mpx-linux.xml: Remove.
4628 * features/i386/i386-mpx.xml: Remove.
4629 * features/i386/i386.xml: Remove.
4630 * features/i386/x32-avx-avx512-linux.xml: Remove.
4631 * features/i386/x32-avx-linux.xml: Remove.
4632 * features/i386/x32-linux.xml: Remove.
4633
edd6266a
AH
46342019-07-04 Alan Hayward <alan.hayward@arm.com>
4635
4636 * regformats/aarch64.dat: Remove.
4637 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4638 * regformats/i386/amd64-avx-linux.dat: Remove.
4639 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4640 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4641 * regformats/i386/amd64-linux.dat: Remove.
4642 * regformats/i386/amd64-mpx-linux.dat: Remove.
4643 * regformats/i386/amd64.dat: Remove.
4644 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4645 * regformats/i386/i386-avx-linux.dat: Remove.
4646 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4647 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4648 * regformats/i386/i386-linux.dat: Remove.
4649 * regformats/i386/i386-mmx-linux.dat: Remove.
4650 * regformats/i386/i386-mpx-linux.dat: Remove.
4651 * regformats/i386/i386.dat: Remove.
4652 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4653 * regformats/i386/x32-avx-linux.dat: Remove.
4654 * regformats/i386/x32-linux.dat: Remove.
4655
2b40fda7
AH
46562019-07-04 Alan Hayward <alan.hayward@arm.com>
4657
4658 * aarch64-tdep.c: Remove xml self tests.
4659 * amd64-linux-tdep.c: Likewise.
4660 * amd64-tdep.c: Likewise.
4661 * i386-linux-tdep.c: Likewise.
4662 * i386-tdep.c: Likewise.
4663
5f4ba3e7
PA
46642019-07-03 Pedro Alves <palves@redhat.com>
4665
4666 PR cli/24732
4667 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4668 (pipe_cmd_option_defs): New.
4669 (make_pipe_cmd_options_def_group): New.
4670 (pipe_command): Use gdb::option::process_options.
4671 (pipe_command_completer): New function.
4672 (_initialize_cli_cmds): Install completer for "pipe" command.
4673
3d9be6f5
PA
46742019-07-03 Pedro Alves <palves@redhat.com>
4675
4676 * cli/cli-option.c (union option_value) <string>: New field.
4677 (struct option_def_and_value): Add ctor, move ctor, dtor and
4678 use DISABLE_COPY_AND_ASSIGN.
4679 (option_def_and_value::clear_value): New.
4680 (parse_option, save_option_value_in_ctx, get_val_type_str)
4681 (add_setshow_cmds_for_options): Handle var_string.
4682 * cli-option.h (union option_def::var_address) <string>: New
4683 field.
4684 (struct string_option_def): New.
4685 * maint-test-options.c (struct test_options_opts): Add default
4686 ctor and use DISABLE_COPY_AND_ASSIGN.
4687 <string_opt>: New field.
4688 (test_options_opts::~test_options_opts): New.
4689 (test_options_opts::dump): Also dump "-string".
4690 (test_options_option_defs): Install "string.
4691
41fc454c
PA
46922019-07-03 Pedro Alves <palves@redhat.com>
4693
4694 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4695 option_value with a null enumeration.
4696 (complete_options): Save the option values in the context.
4697 (save_option_value_in_ctx): New, factored out from ...
4698 (process_options): ... here.
4699 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4700 of the function.
4701 * maint-test-options.c (test_options_opts::dump): New, factored
4702 out from ...
4703 (maintenance_test_options_command_mode): ... here.
4704 (maintenance_test_options_command_completion_result): Delete.
4705 (maintenance_test_options_command_completion_text): Update
4706 comment.
4707 (maintenance_show_test_options_completion_result): Change
4708 prototype. Just print
4709 maintenance_test_options_command_completion_text.
4710 (save_completion_result): New.
4711 (maintenance_test_options_completer_mode): Pass options context to
4712 complete_options, and then save a dump.
4713 (_initialize_maint_test_options): Use add_cmd to install "maint
4714 show test-options-completion-result".
4715
fdbc9870
PA
47162019-07-03 Pedro Alves <palves@redhat.com>
4717
4718 * NEWS (New commands): Mention "with" and "maint with".
4719 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4720 (with_command, with_command_completer): New.
4721 (pipe_command): Adjust to new repeat_previous
4722 interface.
4723 (_initialize_cli_cmds): Install the "with" command and its "w"
4724 alias.
4725 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4726 declarations.
4727 * cli/cli-setshow.c (parse_cli_var_uinteger)
4728 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4729 argument strings for all var_types.
4730 (get_setshow_command_value_string): New, factored out from ...
4731 (do_show_command): ... this.
4732 * cli/cli-setshow.h: Include <string>.
4733 (get_setshow_command_value_string): Declare.
4734 * command.h (repeat_previous): Now returns const char *. Adjust
4735 comment.
4736 * maint.c: Include "cli/cli-cmds.h".
4737 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4738 (_initialize_maint_cmds): Register the "maintenance with" command.
4739 * top.c (repeat_previous): Move bits from pipe_command here:
4740 Return the saved command line, if any; error out if there's no
4741 command to relaunch.
4742
c6ac8931
PA
47432019-07-03 Pedro Alves <palves@redhat.com>
4744
4745 * NEWS (New commands): Mention "maint set/show test-settings"
4746 instead of "maint test-settings".
4747 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4748 (maintenance_test_settings_set_list): Rename to ...
4749 (maintenance_set_test_settings_list): ... this.
4750 (maintenance_test_settings_show_list): Rename to ...
4751 (maintenance_show_test_settings_list): ... this.
4752 (maintenance_test_settings_cmd): Delete.
4753 (maintenance_test_settings_set_cmd): ...
4754 (maintenance_set_test_settings_cmd): ... this.
4755 (maintenance_test_settings_show_cmd): ...
4756 (maintenance_show_test_settings_cmd): ... this.
4757 (maintenance_test_settings_show_value_cmd):
4758 (maintenance_show_test_settings_value_cmd): ... this.
4759 (_initialize_maint_test_settings): No longer install the "maint
4760 test-settings" prefix command. Rename "maint test-settings set"
4761 to "maint set test-settings", and "maint test-settings show" to
4762 "maint show test-settings". Adjust all subcommands.
4763
d1fcf2fd
PA
47642019-07-03 Pedro Alves <palves@redhat.com>
4765
4766 * maint-test-settings.c: Fix file's intro comment. Replace all
4767 references to "test-options" with references to "test-settings",
4768 in comments.
4769
970f9d09
PA
47702019-07-03 Pedro Alves <palves@redhat.com>
4771
4772 * maint-test-settings.c (maintenance_test_settings_xxx)
4773 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4774 New.
4775 (maintenance_test_settings_enums): Use them.
4776 (maintenance_test_settings_enum): Default to
4777 maintenance_test_settings_xxx.
4778 (_initialize_maint_test_settings): Initialize
4779 MAINTENANCE_TEST_SETTINGS_FILENAME.
4780
f3869b1a
SM
47812019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4782
4783 * breakpoint.h (remove_breakpoints_inf): Change return type to
4784 void, move function documentation here.
4785 * breakpoint.c (remove_breakpoints_inf): Change return type to
4786 void, move function documentation to header.
4787
54d66006
PA
47882019-07-02 Pedro Alves <palves@redhat.com>
4789
4790 * NEWS (Completion improvements): Mention "info threads".
4791 * thread.c (struct info_threads_opts, info_threads_option_defs)
4792 (make_info_threads_options_def_group): New.
4793 (info_threads_command): Use gdb::option::process_options.
4794 (info_threads_command_completer): New.
4795 (_initialize_thread): Use gdb::option::build_help to build the
4796 help text for "info threads".
4797
854f6088
SM
47982019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4799
4800 * defs.h (generic_load): Move from here...
4801 * symfile.h (generic_load): ... to here. Rename name parameter
4802 to args.
4803 * symfile.c (generic_load): Add comment.
4804
54ee4252
TT
48052019-07-01 Tom Tromey <tromey@adacore.com>
4806
4807 * dwarf2read.c
4808 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4809 declaration of without_params. Fix formatting.
4810
65392b3e
TT
48112019-07-01 Tom Tromey <tromey@adacore.com>
4812
4813 * ada-exp.y (find_primitive_type): Update.
4814 * ada-lang.h (ada_lookup_symbol): Update.
4815 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4816 parameter.
4817 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4818
7d7571f0
SDJ
48192019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4820
4821 PR breakpoints/24541
4822 * gdbarch.c: Regenerate.
4823 * gdbarch.h: Regenerate.
4824 * gdbarch.sh: Add 'stap_adjust_register'.
4825 * i386-tdep.c: Include '<unordered_set>'.
4826 (i386_stap_adjust_register): New function.
4827 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4828 * stap-probe.c (stap_parse_register_operand): Call
4829 'gdbarch_stap_adjust_register'.
4830
5af5392a
SDJ
48312019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4832
4833 PR python/24742
4834 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4835 * python/python.c (do_start_initialization): Use 'xmalloc'
4836 instead of 'PyMem_Malloc'.
4837
10d06d82
TT
48382019-06-28 Tom Tromey <tromey@adacore.com>
4839
4840 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4841 for Ada.
4842
1b7f24cd
TT
48432019-06-27 Tom Tromey <tromey@adacore.com>
4844
4845 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4846 objfile_key.
4847 (arm_find_mapping_symbol, arm_record_special_symbol)
4848 (_initialize_arm_tdep): Update.
4849 (arm_objfile_data_free): Remove.
4850
3d507ff2
TT
48512019-06-27 Tom Tromey <tromey@adacore.com>
4852
4853 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4854 to cp_print_static_field.
4855
762c164d
TT
48562019-06-26 Tom Tromey <tromey@adacore.com>
4857
4858 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4859 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4860 declare.
4861
aa2f9bcf
AH
48622019-06-26 Alan Hayward <alan.hayward@arm.com>
4863
4864 * features/aarch64-core.c (create_feature_aarch64_core):
4865 Regenerate.
4866 * features/aarch64-core.xml: Add cpsr flags.
4867
3426ae57
AH
48682019-06-26 Alan Hayward <alan.hayward@arm.com>
4869
4870 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4871 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4872
4838e44c
SM
48732019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4874
4875 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4876 field.
4877 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4878 use.
4879 (arm_record_special_symbol): Don't insert new symbol in sorted
4880 position, push it at the end.
4881
54cc7474
SM
48822019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4883
4884 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4885 (arm_mapping_symbol_s): Remove.
4886 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4887 (arm_mapping_symbol_vec): New typedef.
4888 (struct arm_per_objfile): Add constructor.
4889 <section_maps>: Change type to
4890 std::unique_ptr<arm_mapping_symbol_vec[]>.
4891 (arm_compare_mapping_symbols): Remove.
4892 (arm_find_mapping_symbol): Adjust to section_maps type change.
4893 (arm_objfile_data_free): Call delete on arm_per_objfile.
4894 (arm_record_special_symbol): Adjust to section_maps type change.
4895 Allocate arm_per_objfile with new.
4896
b65b566c
PW
48972019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4898
4899 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4900 with the command prefix.
4901
c2fc64f5
TT
49022019-06-25 Tom Tromey <tom@tromey.com>
4903
4904 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4905 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4906
fb54fa76
TT
49072019-06-25 Tom Tromey <tom@tromey.com>
4908
4909 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4910 type.
4911 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4912 protected.
4913
f7952c57
TT
49142019-06-25 Tom Tromey <tom@tromey.com>
4915
4916 * tui/tui-winsource.c
4917 (tui_source_window_base::set_is_exec_point_at): Add check against
4918 LOA_ADDRESS.
4919
17568d78
TT
49202019-06-25 Tom Tromey <tom@tromey.com>
4921
4922 * tui/tui-source.c (tui_set_source_content): Don't check before
4923 xfree.
4924 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4925
53e7cdba
TT
49262019-06-25 Tom Tromey <tom@tromey.com>
4927
4928 * tui/tui-winsource.h (tui_update_source_window_as_is)
4929 (tui_alloc_source_buffer, tui_line_is_displayed)
4930 (tui_addr_is_displayed): Change type of win_info.
4931 * tui/tui-winsource.c (tui_update_source_window_as_is)
4932 (tui_clear_source_content, tui_show_source_line)
4933 (tui_show_source_content, tui_source_window_base::refill)
4934 (tui_source_window_base::set_is_exec_point_at)
4935 (tui_source_window_base::set_is_exec_point_at)
4936 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4937 (tui_alloc_source_buffer, tui_line_is_displayed)
4938 (tui_addr_is_displayed): Change type of win_info. Update.
4939 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4940 (tui_source_window_base::do_make_visible_with_new_height):
4941 Update.
4942 * tui/tui-source.c (tui_set_source_content)
4943 (tui_set_source_content_nil)
4944 (tui_source_window::do_scroll_vertical): Update.
4945 * tui/tui-layout.c (show_layout): Update.
4946 * tui/tui-disasm.c (tui_set_disassem_content)
4947 (tui_disasm_window::do_scroll_vertical): Update.
4948 * tui/tui-data.h (tui_win_content): Remove.
4949 (struct tui_gen_win_info) <content, content_size>: Remove.
4950 (struct tui_source_element): Add initializers and destructor.
4951 (union tui_which_element, struct tui_win_element): Remove.
4952 (struct tui_source_window_base) <content>: New field.
4953 (struct tui_data_window): Remove destructor.
4954 (tui_alloc_content, tui_free_win_content)
4955 (tui_free_all_source_wins_content): Don't declare.
4956 * tui/tui-data.c (tui_initialize_static_data): Update.
4957 (init_content_element, tui_alloc_content): Remove.
4958 (~tui_gen_win_info): Update.
4959 (~tui_data_window, tui_free_all_source_wins_content)
4960 (tui_free_win_content, free_content, free_content_elements):
4961 Remove.
4962
7908abbf
TT
49632019-06-25 Tom Tromey <tom@tromey.com>
4964
4965 * tui/tui-winsource.h (tui_clear_source_content)
4966 (tui_erase_source_content, tui_show_source_content): Change type
4967 of win_info.
4968 * tui/tui-winsource.c (tui_clear_source_content)
4969 (tui_erase_source_content, tui_show_source_content): Change type
4970 of win_info.
4971 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4972 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4973 win_info.
4974 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4975 win_info.
4976 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4977
02c28df0
TT
49782019-06-25 Tom Tromey <tom@tromey.com>
4979
4980 * tui/tui-winsource.c (tui_clear_source_content)
4981 (tui_source_window_base::set_is_exec_point_at): Update.
4982 * tui/tui-source.c (tui_set_source_content_nil): Update.
4983 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4984 a bool.
4985 * tui/tui-data.c (init_content_element): Update.
4986
6658b1bf
TT
49872019-06-25 Tom Tromey <tom@tromey.com>
4988
4989 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4990 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4991 * tui/tui-layout.c (init_and_make_win): Update.
4992 * tui/tui.h (enum tui_win_type): Update.
4993 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4994 tui_win_is_auxillary.
4995 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4996 tui_win_is_auxillary.
4997
21e1c91e
TT
49982019-06-25 Tom Tromey <tom@tromey.com>
4999
5000 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5001 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5002 (tui_delete_data_content_windows, tui_display_all_data)
5003 (tui_data_window::do_scroll_vertical, tui_display_data_from):
5004 Update.
5005 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5006 * tui/tui-regs.c (tui_last_regs_line_no)
5007 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5008 (tui_show_registers): Update.
5009 (tui_show_register_group): Return void. Update.
5010 (tui_display_registers_from, tui_display_reg_element_at_line)
5011 (tui_display_registers_from_line, tui_check_register_values):
5012 Update.
5013 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5014 member.
5015 (struct tui_data_window) <regs_content>: Now a std::vector.
5016 <regs_content_count>: Remove.
5017 (tui_add_content_elements, tui_free_data_content): Don't declare.
5018 * tui/tui-data.c (tui_data_window::clear_detail): Update.
5019 (init_content_element): Remove DATA_WIN case. Add assert.
5020 (tui_add_content_elements): Remove.
5021 (tui_data_window): Update.
5022 (tui_free_data_content): Remove.
5023 (free_content_elements): Remove DATA_WIN case.
5024
115ac53b
TT
50252019-06-25 Tom Tromey <tom@tromey.com>
5026
5027 * tui/tui-data.c (tui_data_item_window): Update.
5028 * tui/tui-windata.h (tui_check_data_values): Don't declare.
5029 * tui/tui-windata.c (tui_display_all_data)
5030 (tui_display_data_from_line): Update.
5031 (tui_check_data_values): Remove.
5032 * tui/tui-regs.c (tui_show_register_group)
5033 (tui_display_reg_element_at_line): Update.
5034 * tui/tui-hooks.c (tui_register_changed)
5035 (tui_refresh_frame_and_register_information): Call
5036 tui_check_register_values.
5037 * tui/tui-data.h (struct tui_data_window) <data_content,
5038 data_content_count, data_type>: Remove.
5039 (enum tui_data_type): Remove.
5040
5041 * tui/tui-data.c (tui_data_window::clear_detail)
5042 (~tui_data_window): Update.
5043
eaf9738b
TT
50442019-06-25 Tom Tromey <tom@tromey.com>
5045
5046 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5047 declare.
5048 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5049 Rename from tui_first_data_item_displayed. Update.
5050 (tui_data_window::refresh_all)
5051 (tui_data_window::do_scroll_vertical): Update.
5052 * tui/tui-data.h (struct tui_data_window)
5053 <first_data_item_displayed>: Declare new method.
5054
31ca4723
TT
50552019-06-25 Tom Tromey <tom@tromey.com>
5056
5057 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5058 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5059 contents...
5060 (tui_initialize_static_data): ...here.
5061
41bcff7f
TT
50622019-06-25 Tom Tromey <tom@tromey.com>
5063
5064 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5065 (tui_display_registers_from, tui_check_register_values): Update.
5066 (tui_display_register): Remove win_info parameter; update.
5067 (tui_get_register): Change type of parameters.
5068 * tui/tui-data.h (struct tui_data_element): Remove.
5069 (union tui_which_element) <data>: Remove.
5070 <data_window>: Change type.
5071 (struct tui_data_item_window): New.
5072 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5073 case. Add assert.
5074 (~tui_data_item_window): New destructor.
5075 (free_content_elements): Remove DATA_ITEM_WIN case.
5076
d2802c33
TT
50772019-06-25 Tom Tromey <tom@tromey.com>
5078
5079 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5080 Remove.
5081
dd835f8b
TT
50822019-06-25 Tom Tromey <tom@tromey.com>
5083
5084 * tui/tui-data.h (struct tui_command_element): Remove.
5085 (union tui_which_element) <command>: Remove.
5086 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5087 assert.
5088 (free_content_elements): Remove CMD_WIN case.
5089
bd7db367
TT
50902019-06-25 Tom Tromey <tom@tromey.com>
5091
5092 * tui/tui-layout.c (tui_set_layout): Update.
5093 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5094 * tui/tui-data.c (layout_def): Update.
5095
3add462f
TT
50962019-06-25 Tom Tromey <tom@tromey.com>
5097
5098 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5099 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5100 (tui_source_window_base::set_new_height): Update.
5101 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5102 Update.
5103 (tui_set_locator_fullname, tui_set_locator_info)
5104 (tui_show_frame_info): Update.
5105 * tui/tui-source.c (tui_set_source_content)
5106 (tui_source_is_displayed): Update.
5107 * tui/tui-layout.c (show_source_disasm_command, show_data)
5108 (show_source_or_disasm_and_command): Update.
5109 * tui/tui-disasm.c (tui_set_disassem_content)
5110 (tui_get_begin_asm_address): Update.
5111 * tui/tui-data.h (struct tui_locator_element): Remove.
5112 (union tui_which_element) <locator>: Remove.
5113 (struct tui_locator_window): New.
5114 (tui_locator_win_info_ptr): Change return type.
5115 * tui/tui-data.c (_locator): Change type.
5116 (tui_locator_win_info_ptr): Change return type.
5117 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5118 (tui_alloc_content): Add assert.
5119
489e9d8b
TT
51202019-06-25 Tom Tromey <tom@tromey.com>
5121
5122 * tui/tui-winsource.c
5123 (tui_exec_info_window::maybe_allocate_content): New method.
5124 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5125 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5126 (make_source_or_disasm_window): Add cast.
5127 * tui/tui-data.h (union tui_which_element) <simple_string>:
5128 Remove.
5129 (struct tui_source_info): New.
5130 (struct tui_source_window_base) <execution_info>: Change type.
5131 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5132 case, and add assert.
5133 (tui_alloc_content): Add assert.
5134
c3fabb7d
TT
51352019-06-25 Tom Tromey <tom@tromey.com>
5136
5137 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5138 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5139 * tui/tui-data.c (tui_alloc_win_info): Remove.
5140
bbc228ee
TT
51412019-06-25 Tom Tromey <tom@tromey.com>
5142
5143 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5144 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5145 can_highlight.
5146
5fcee43a
TT
51472019-06-25 Tom Tromey <tom@tromey.com>
5148
5149 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5150 make_visible_with_new_height method.
5151 (tui_win_info::make_visible_with_new_height): New method.
5152 (tui_source_window_base::do_make_visible_with_new_height)
5153 (tui_data_window::do_make_visible_with_new_height)
5154 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5155 (make_visible_with_new_height): Remove.
5156 (tui_resize_all, tui_adjust_win_heights): Use
5157 make_visible_with_new_height method.
5158 * tui/tui-data.h (struct tui_win_info)
5159 <do_make_visible_with_new_height, make_visible_with_new_height>:
5160 New methods.
5161 (struct tui_source_window_base, struct tui_data_window)
5162 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5163 methods.
5164
d83f1fe6
TT
51652019-06-25 Tom Tromey <tom@tromey.com>
5166
5167 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5168 method.
5169 (update_tab_width): Call update_tab_width method.
5170 * tui/tui-data.h (struct tui_win_info)
5171 (struct tui_source_window_base) <update_tab_width>: New methods.
5172
17374de4
TT
51732019-06-25 Tom Tromey <tom@tromey.com>
5174
5175 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5176 parameter.
5177 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5178 parameter.
5179 (tui_gen_win_info::make_visible): Update.
5180 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5181 parameter.
5182 * tui/tui-data.h (enum tui_box): New enum.
5183 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5184
f936bca2
TT
51852019-06-25 Tom Tromey <tom@tromey.com>
5186
5187 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5188 init_and_make_win for EXEC_INFO_WIN.
5189 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5190 longer inline.
5191 (struct tui_win_info) <~tui_win_info>: Inline.
5192 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5193 Don't declare.
5194 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5195 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5196 Remove.
5197 (tui_initialize_static_data): Update.
5198 (~tui_gen_win_info): Handle more cleanup here.
5199 (~tui_source_window_base): Delete "execution_info".
5200 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5201
d6ba6a11
TT
52022019-06-25 Tom Tromey <tom@tromey.com>
5203
5204 * tui/tui-layout.c (make_command_window): Don't set
5205 can_highlight.
5206 (show_source_disasm_command): Call the reset method.
5207 (show_data): Don't set can_highlight. Call the reset method.
5208 (tui_gen_win_info::reset): Rename from init_gen_win_info
5209 (init_and_make_win): Simplify. Return tui_gen_win_info.
5210 (show_source_or_disasm_and_command): Call the reset method.
5211 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5212 (struct tui_cmd_window): Set can_highlight.
5213
48a3bd16
TT
52142019-06-25 Tom Tromey <tom@tromey.com>
5215
5216 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5217 from make_visible.
5218 (tui_make_visible, tui_make_invisible): Rewrite.
5219 (tui_win_info::make_visible): Remove.
5220 (tui_source_window_base::make_visible): Update.
5221 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5222 method. Moved from...
5223 (struct tui_win_info) <make_visible>: ...here.
5224
c3bd716f
TT
52252019-06-25 Tom Tromey <tom@tromey.com>
5226
5227 * tui/tui-winsource.c
5228 (tui_source_window_base::do_scroll_horizontal): Remove direction
5229 parameter.
5230 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5231 direction parameter.
5232 * tui/tui-win.c (tui_win_info::forward_scroll)
5233 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5234 (tui_win_info::right_scroll): Update.
5235 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5236 direction parameter.
5237 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5238 direction parameter.
5239 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5240 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5241 Remove direction parameter.
5242 (struct tui_source_window_base, struct tui_source_window)
5243 (struct tui_disasm_window, struct tui_data_window)
5244 (struct tui_cmd_window): Update.
5245
21c32dca
TT
52462019-06-25 Tom Tromey <tom@tromey.com>
5247
5248 * tui/tui-winsource.h (tui_set_exec_info_content)
5249 (tui_show_exec_info_content, tui_erase_exec_info_content)
5250 (tui_clear_exec_info_content, tui_update_exec_info): Change
5251 argument to tui_source_window_base.
5252 * tui/tui-winsource.c (tui_set_exec_info_content)
5253 (tui_show_exec_info_content, tui_erase_exec_info_content)
5254 (tui_clear_exec_info_content, tui_update_exec_info): Change
5255 argument to tui_source_window_base.
5256
73fbdc65
TT
52572019-06-25 Tom Tromey <tom@tromey.com>
5258
5259 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5260 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5261
33325343
TT
52622019-06-25 Tom Tromey <tom@tromey.com>
5263
5264 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5265 check.
5266
29d2c474
TT
52672019-06-25 Tom Tromey <tom@tromey.com>
5268
5269 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5270 type to void.
5271 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5272 type to void.
5273 * tui/tui-source.c (tui_set_source_content): Update.
5274 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5275
152f3f4b
TT
52762019-06-25 Tom Tromey <tom@tromey.com>
5277
5278 * tui/tui-win.c (window_name_completer, tui_set_focus)
5279 (tui_all_windows_info): Use name method.
5280 * tui/tui-data.h (struct tui_gen_win_info)
5281 (struct tui_source_window, struct tui_disasm_window)
5282 (struct tui_data_window, struct tui_cmd_window) <name>: New
5283 method.
5284 (tui_win_name): Don't declare.
5285 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5286 (tui_win_name): Remove.
5287
be4da588
TT
52882019-06-25 Tom Tromey <tom@tromey.com>
5289
5290 * tui/tui-winsource.h (tui_update_source_window)
5291 (tui_update_source_window_as_is): Change parameter type.
5292 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5293 to be a tui_source_window_base.
5294 (tui_update_source_window_as_is): Likewise.
5295 * tui/tui-win.c (make_visible_with_new_height): Update.
5296
5b81daba
TT
52972019-06-25 Tom Tromey <tom@tromey.com>
5298
5299 * tui/tui-winsource.c (tui_erase_source_content)
5300 (tui_show_source_content, tui_show_exec_info_content)
5301 (tui_erase_exec_info_content): Use refresh_window method.
5302 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5303 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5304 from tui_refresh_win.
5305 (tui_data_window::refresh_window): New method.
5306 (tui_win_info::refresh, tui_source_window_base::refresh)
5307 (tui_refresh_all): Use refresh_window method.
5308 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5309 method.
5310 * tui/tui-regs.c (tui_display_register): Call refresh_window
5311 method.
5312 * tui/tui-layout.c (show_source_disasm_command)
5313 (show_source_or_disasm_and_command): Call refresh_window method.
5314 * tui/tui-data.h (struct tui_gen_win_info)
5315 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5316 New method.
5317
cb2ce893
TT
53182019-06-25 Tom Tromey <tom@tromey.com>
5319
5320 * tui/tui.c (tui_rl_other_window, tui_enable)
5321 (tui_is_window_visible, tui_get_command_dimension): Update.
5322 * tui/tui-winsource.c (tui_update_source_window_as_is)
5323 (tui_clear_source_content, tui_erase_source_content)
5324 (tui_show_source_line, tui_source_window_base::refill)
5325 (tui_source_window_base::do_scroll_horizontal)
5326 (tui_source_window_base::set_is_exec_point_at)
5327 (tui_update_breakpoint_info, tui_set_exec_info_content)
5328 (tui_alloc_source_buffer, tui_line_is_displayed)
5329 (tui_addr_is_displayed): Update.
5330 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5331 (tui_check_and_display_highlight_if_needed)
5332 (tui_win_info::make_visible, tui_win_info::refresh)
5333 (tui_refresh_all): Update.
5334 * tui/tui-windata.c (tui_first_data_item_displayed)
5335 (tui_delete_data_content_windows, tui_erase_data_content)
5336 (tui_display_all_data, tui_data_window::refresh_all)
5337 (tui_check_data_values): Update.
5338 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5339 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5340 (tui_win_info::backward_scroll, tui_refresh_all_win)
5341 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5342 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5343 (tui_source_window_base::set_new_height)
5344 (tui_data_window::set_new_height)
5345 (make_invisible_and_set_new_height)
5346 (make_visible_with_new_height, new_height_ok)
5347 (parse_scrolling_args): Update.
5348 * tui/tui-stack.c (tui_show_frame_info): Update.
5349 * tui/tui-source.c (tui_set_source_content)
5350 (tui_set_source_content_nil, tui_source_is_displayed)
5351 (tui_source_window::do_scroll_vertical): Update.
5352 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5353 (tui_display_registers_from, tui_display_reg_element_at_line)
5354 (tui_check_register_values, tui_reg_command): Update.
5355 * tui/tui-layout.c (tui_default_win_height)
5356 (show_source_disasm_command, show_data, init_and_make_win)
5357 (show_source_or_disasm_and_command): Update.
5358 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5359 (tui_redisplay_readline, tui_mld_flush)
5360 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5361 (tui_getc): Update.
5362 * tui/tui-disasm.c (tui_set_disassem_content)
5363 (tui_disasm_window::do_scroll_vertical): Update.
5364 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5365 Now virtual.
5366 (struct tui_win_info): Derive from tui_gen_win_info.
5367 <~tui_win_info>: Mark as override.
5368 <generic>: Remove member.
5369 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5370 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5371 (~tui_data_window, ~tui_win_info)
5372 (tui_free_all_source_wins_content): Update.
5373 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5374
ab313b35
TT
53752019-06-25 Tom Tromey <tom@tromey.com>
5376
5377 * tui/tui-layout.c (init_and_make_win): Use new.
5378 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5379 destructor, initializers.
5380 (tui_alloc_generic_win_info): Don't declare.
5381 * tui/tui-data.c (_locator): Add argument to constructor.
5382 (source_win, disasm_win): New globals.
5383 (exec_info): Remove.
5384 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5385 Update.
5386 (tui_alloc_generic_win_info): Remove.
5387 (init_content_element): Use new.
5388 (tui_win_info::tui_win_info): Update.
5389 (free_content_elements) <case DATA_WIN>: Use delete.
5390
dc2c33e4
TT
53912019-06-25 Tom Tromey <tom@tromey.com>
5392
5393 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5394 * tui/tui-windata.c (tui_first_data_item_displayed)
5395 (tui_delete_data_content_windows): Update.
5396 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5397 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5398 (tui_display_registers_from, tui_check_register_values): Update.
5399 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5400 pointer.
5401 * tui/tui-data.c (init_content_element): Update. Allocate the new
5402 window.
5403 (tui_free_data_content): Update.
5404 (free_content_elements) <case DATA_WIN>: Free the window.
5405
214a5cbe
TT
54062019-06-25 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5409 Update.
5410 * tui/tui-layout.c (make_command_window)
5411 (show_source_disasm_command, show_data, init_and_make_win)
5412 (show_source_or_disasm_and_command): Update.
5413 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5414 method.
5415 <can_highight, is_highlighted>: Now bool.
5416 (tui_set_win_highlight): Don't declare.
5417 * tui/tui-data.c (tui_set_win_highlight): Remove.
5418
8e2daf15
TT
54192019-06-25 Tom Tromey <tom@tromey.com>
5420
5421 * tui/tui-wingeneral.c (make_visible): Remove check of window
5422 type.
5423
8903bd8a
TT
54242019-06-25 Tom Tromey <tom@tromey.com>
5425
5426 * tui/tui-win.c (tui_win_info::max_height)
5427 (tui_cmd_window::max_height): New methods.
5428 (new_height_ok): Call max_height.
5429 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5430 <max_height>: New method.
5431
3f02ce1e
TT
54322019-06-25 Tom Tromey <tom@tromey.com>
5433
5434 * tui/tui-win.c (tui_source_window_base::set_new_height)
5435 (tui_data_window::set_new_height): New methods.
5436 (make_invisible_and_set_new_height): Call set_new_height method.
5437 * tui/tui-data.h (struct tui_win_info)
5438 (struct tui_source_window_base, struct tui_data_window)
5439 <set_new_height>: New method.
5440
1825f487
TT
54412019-06-25 Tom Tromey <tom@tromey.com>
5442
5443 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5444 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5445 tui_refresh_data_win.
5446 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5447 method.
5448 (tui_refresh_all_win): Call the refresh_all method.
5449 (tui_set_focus): Likewise.
5450 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5451 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5452 Likewise.
5453
ad54d15b
TT
54542019-06-25 Tom Tromey <tom@tromey.com>
5455
5456 * tui/tui-winsource.h (tui_refill_source_window)
5457 (tui_set_is_exec_point_at): Don't declare.
5458 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5459 (tui_source_window_base::refill): Rename from
5460 tui_refill_source_window.
5461 (tui_source_window_base::do_scroll_horizontal): Update.
5462 (tui_source_window_base::set_is_exec_point_at): Rename from
5463 tui_set_is_exec_point_at.
5464 (tui_update_all_breakpoint_info): Update.
5465 * tui/tui-stack.c (tui_show_frame_info): Update.
5466 * tui/tui-layout.c (show_data): Add cast.
5467 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5468 * tui/tui-data.h (struct tui_source_window_base) <refill,
5469 set_is_exec_point_at>: New methods.
5470 (tui_source_windows, tui_add_to_source_windows): Update types.
5471 (tui_add_to_source_windows): Remove redundant declaration.
5472 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5473 (tui_source_windows): Change return type.
5474 (tui_clear_source_windows_detail): Update.
5475 (tui_add_to_source_windows): Change type of parameter.
5476 (tui_free_all_source_wins_content): Update.
5477
2042b506
TT
54782019-06-25 Tom Tromey <tom@tromey.com>
5479
5480 * tui/tui-wingeneral.c (tui_win_info::refresh)
5481 (tui_source_window_base::refresh): New methods.
5482 (tui_refresh_all): Call the refresh method.
5483 * tui/tui-data.h (struct tui_win_info)
5484 (struct tui_source_window_base) <refresh>: New method.
5485
56122977
TT
54862019-06-25 Tom Tromey <tom@tromey.com>
5487
5488 * tui/tui.h (tui_is_window_visible): Return bool.
5489 * tui/tui.c (tui_is_window_visible): Return bool.
5490 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5491 (tui_make_visible, tui_make_invisible)
5492 (tui_win_info::make_visible)
5493 (tui_source_window_base::make_visible, make_all_visible)
5494 (tui_make_all_visible, tui_make_all_invisible): Update.
5495 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5496 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5497 bool.
5498 (struct tui_win_info, struct tui_source_window_base)
5499 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5500 * tui/tui-data.c (tui_init_generic_part): Update.
5501
cda37efb
TT
55022019-06-25 Tom Tromey <tom@tromey.com>
5503
5504 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5505 (tui_source_window_base::make_visible): New methods.
5506 (make_all_visible): Make method call.
5507 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5508 (struct tui_source_window_base, struct tui_cmd_window): Override
5509 make_visible.
5510 (tui_win_is_source_type): Don't declare.
5511 * tui/tui-data.c (tui_win_is_source_type): Remove.
5512
6a0ee02c
TT
55132019-06-25 Tom Tromey <tom@tromey.com>
5514
5515 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5516 NULL check.
5517
63901aec
TT
55182019-06-25 Tom Tromey <tom@tromey.com>
5519
5520 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5521 Inline constructor. Add initializers for members.
5522 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5523 constructors; now inline in class.
5524
ceb13a13
TT
55252019-06-25 Tom Tromey <tom@tromey.com>
5526
5527 * tui/tui-regs.c (tui_show_registers): Update.
5528 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5529 bool.
5530 * tui/tui-data.c (tui_data_window::clear_detail)
5531 (tui_data_window): Update.
5532
238eb706
TT
55332019-06-25 Tom Tromey <tom@tromey.com>
5534
5535 * tui/tui-windata.c (tui_display_all_data)
5536 (tui_display_data_from_line, tui_display_data_from)
5537 (tui_check_data_values, tui_data_window::do_scroll_vertical):
5538 Update.
5539 * tui/tui-regs.c (tui_last_regs_line_no)
5540 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5541 (tui_show_registers, tui_show_register_group)
5542 (tui_display_registers_from, tui_display_reg_element_at_line)
5543 (tui_display_registers_from_line, tui_check_register_values)
5544 (tui_reg_next, tui_reg_prev): Update.
5545 * tui/tui-layout.c (tui_set_layout, show_data): Update.
5546 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
5547 tui_data_window.
5548 (struct tui_win_info) <detail>: Remove. Add new fields from
5549 tui_data_info.
5550 (TUI_DATA_WIN): Add cast.
5551 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5552 (~tui_data_window): Simplify.
5553
81491aa0
TT
55542019-06-25 Tom Tromey <tom@tromey.com>
5555
5556 * tui/tui-layout.c (show_source_disasm_command)
5557 (show_source_or_disasm_and_command): Update.
5558 * tui/tui-io.c (update_cmdwin_start_line)
5559 (tui_redisplay_readline): Update.
5560 * tui/tui-data.h (struct tui_command_info): Remove.
5561 (struct tui_win_info) <detail>: Remove command_info member.
5562 (struct tui_data_window) <start_line>: New member, from
5563 tui_command_info.
5564 (TUI_CMD_WIN): Add casts.
5565
e6e41501
TT
55662019-06-25 Tom Tromey <tom@tromey.com>
5567
5568 * tui/tui-winsource.c (tui_update_source_window)
5569 (tui_refill_source_window)
5570 (tui_source_window_base::do_scroll_horizontal)
5571 (tui_update_breakpoint_info, tui_set_exec_info_content)
5572 (tui_show_exec_info_content, tui_erase_exec_info_content)
5573 (tui_clear_exec_info_content): Update.
5574 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5575 Update.
5576 * tui/tui-win.c (make_invisible_and_set_new_height)
5577 (make_visible_with_new_height): Update.
5578 * tui/tui-source.c (tui_set_source_content)
5579 (tui_show_symtab_source): Update.
5580 * tui/tui-layout.c (extract_display_start_addr)
5581 (show_source_disasm_command, show_data)
5582 (make_source_or_disasm_window)
5583 (show_source_or_disasm_and_command): Update.
5584 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5585 (tui_disasm_window::do_scroll_vertical): Remove shadowing
5586 "gdbarch".
5587 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
5588 to tui_source_window_base.
5589 (struct tui_win_info) <detail>: Remove source_info member.
5590 (struct tui_source_window_base) <has_locator>: Inline.
5591 Move contents from tui_source_info; rename has_locator member to
5592 m_has_locator.
5593 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5594 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5595 header file.
5596 (tui_source_window_base::clear_detail, ~tui_source_window_base):
5597 Simplify.
5598 (tui_free_all_source_wins_content): Cast to
5599 tui_source_window_base.
5600
44f0e208
TT
56012019-06-25 Tom Tromey <tom@tromey.com>
5602
5603 * tui/tui-win.c (make_invisible_and_set_new_height)
5604 (make_visible_with_new_height): Call has_locator method.
5605 * tui/tui-layout.c (show_source_disasm_command, show_data)
5606 (show_source_or_disasm_and_command): Update for bool change.
5607 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5608 (tui_win_info) <has_locator>: New method.
5609 (struct tui_source_window_base) <has_locator>: New method.
5610 (tui_win_has_locator): Don't declare.
5611 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5612 from tui_win_has_locator.
5613 (tui_source_window_base): Use false, not FALSE.
5614
7778b912
TT
56152019-06-25 Tom Tromey <tom@tromey.com>
5616
5617 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5618 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5619 clear_detail method directly.
5620 (tui_clear_win_detail): Remove.
5621
f83d391c
TT
56222019-06-25 Tom Tromey <tom@tromey.com>
5623
5624 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5625 "this", not TUI_DISASM_WIN.
5626
13446e05
TT
56272019-06-25 Tom Tromey <tom@tromey.com>
5628
5629 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
5630 declare.
5631 * tui/tui-winsource.c
5632 (tui_source_window_base::do_scroll_horizontal): Rename from
5633 tui_horizontal_source_scroll.
5634 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5635 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5636 from tui_vertical_data_scroll.
5637 * tui/tui-win.h (tui_scroll): Don't declare.
5638 * tui/tui-win.c (tui_win_info::forward_scroll)
5639 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5640 (tui_win_info::right_scroll): Rename and update.
5641 (tui_scroll_forward_command, tui_scroll_backward_command)
5642 (tui_scroll_left_command, tui_scroll_right_command): Update.
5643 (tui_scroll): Remove.
5644 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5645 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5646 from tui_vertical_source_scroll.
5647 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5648 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5649 from tui_vertical_disassem_scroll.
5650 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5651 do_scroll_horizontal>: New methods.
5652 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5653 Likewise.
5654 (struct tui_source_window_base): Add do_scroll_horizontal.
5655 (struct tui_source_window, struct tui_disasm_window): Add
5656 do_scroll_vertical.
5657 (struct tui_data_window, struct tui_cmd_window): Add
5658 do_scroll_horizontal and do_scroll_vertical.
5659 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5660
5cf82909
TT
56612019-06-25 Tom Tromey <tom@tromey.com>
5662
5663 * tui/tui-data.h (struct tui_source_window_base): New struct.
5664 (struct tui_source_window): Derive from tui_source_window_base.
5665 (struct tui_disasm_window): New struct.
5666 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5667 from tui_source_window::clear_detail.
5668 (tui_source_window_base): Rename from tui_source_window.
5669 (~tui_source_window_base): Rename from ~tui_source_window.
5670 (tui_alloc_win_info): Create a tui_disasm_window.
5671
ee1d42d6
TT
56722019-06-25 Tom Tromey <tom@tromey.com>
5673
5674 * tui/tui-data.h (struct tui_source_window)
5675 (struct tui_data_window): Declare destructors.
5676 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5677 destructors.
5678 (tui_win_info): Simplify.
5679
b4eb2452
TT
56802019-06-25 Tom Tromey <tom@tromey.com>
5681
5682 * tui/tui-winsource.c (tui_display_main)
5683 (tui_update_source_windows_with_addr)
5684 (tui_update_all_breakpoint_info): Update.
5685 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5686 (new_height_ok, parse_scrolling_args): Update.
5687 * tui/tui-stack.c (tui_show_frame_info): Update.
5688 * tui/tui-data.h (struct tui_list): Remove.
5689 (tui_source_windows): Return a reference to a std::vector.
5690 * tui/tui-data.c (source_windows): Now a std::vector.
5691 (tui_source_windows): Change return type.
5692 (tui_clear_source_windows): Rewrite.
5693 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5694 (tui_free_all_source_wins_content): Rewrite.
5695
8761a91b
TT
56962019-06-25 Tom Tromey <tom@tromey.com>
5697
5698 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5699 (struct tui_data_window, struct tui_cmd_window): Declare
5700 clear_detail method.
5701 * tui/tui-data.c (tui_source_window::clear_detail)
5702 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5703 methods.
5704 (tui_clear_win_detail): Simplify.
5705
0ed69eda
TT
57062019-06-25 Tom Tromey <tom@tromey.com>
5707
5708 * tui/tui-layout.c (make_source_window, make_disasm_window)
5709 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5710 Return the new window.
5711 (show_source_disasm_command, show_data)
5712 (show_source_or_disasm_and_command): Update.
5713
82432e10
TT
57142019-06-25 Tom Tromey <tom@tromey.com>
5715
5716 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5717 parameter. Return the new window.
5718 (show_source_disasm_command): Update and remove NULL check.
5719 (show_source_or_disasm_and_command): Update.
5720
ec328aa5
TT
57212019-06-25 Tom Tromey <tom@tromey.com>
5722
5723 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5724
33b906ab
TT
57252019-06-25 Tom Tromey <tom@tromey.com>
5726
5727 * tui/tui-data.h (struct tui_win_info): Make constructor
5728 protected. Make destructor virtual. Add initializers.
5729 (tui_source_window, tui_data_window, tui_cmd_window): New
5730 classes.
5731 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5732 constructor. Add "type" parameter.
5733 (tui_source_window, tui_data_window, tui_cmd_window): New
5734 constructors.
5735 (tui_alloc_win_info): Instantiate the appropriate subclass.
5736
e7e11af4
TT
57372019-06-25 Tom Tromey <tom@tromey.com>
5738
5739 * tui/tui-win.c (tui_resize_all): Use delete.
5740 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5741 destructor.
5742 (tui_free_window): Don't declare.
5743 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5744 Update.
5745
6792b55e
TT
57462019-06-25 Tom Tromey <tom@tromey.com>
5747
5748 * tui/tui-data.h (struct tui_win_info): Add constructor.
5749 * tui/tui-data.c (tui_alloc_win_info): Use new.
5750 (tui_free_window): Use delete.
5751
f95675e1
TT
57522019-06-22 Tom Tromey <tom@tromey.com>
5753
5754 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5755 declare.
5756 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5757
5bff081c
TT
57582019-06-22 Tom Tromey <tom@tromey.com>
5759
5760 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5761 declare.
5762 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5763
47e3f474
TV
57642019-06-22 Tom de Vries <tdevries@suse.de>
5765
5766 * dwarf2read.c (create_addrmap_from_aranges)
5767 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5768 instead of '%zu'.
5769
fd5866f6
SM
57702019-06-21 Simon Marchi <simon.marchi@efficios.com>
5771
5772 * dwarf2read.h (dwarf2_section_info_def): Remove.
5773 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5774 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5775 std::vector<dwarf2_section_info>.
5776 (struct dwo_file) <~dwo_file>: Remove.
5777 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5778 types field.
5779 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5780 (dwarf2_read_debug_names): Likewise.
5781 (create_debug_types_hash_table): Change parameter type to
5782 array_view, adjust code accordingly.
5783 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5784 (partial_die_info::fixup): Likewise.
5785 (determine_prefix): Likewise.
5786 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5787
fb1eb2f9
SM
57882019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5789
5790 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5791 gdb_bfd_ref_ptr.
5792 <~dwo_file>: Remove call to gdb_bfd_unref.
5793 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5794 gdb_bfd_ref_ptr::get.
5795
51ac9db5
SM
57962019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5797
5798 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5799 type to htab_up.
5800 * dwarf2read.c (struct dwo_file): Initialize fields.
5801 <~dwo_file>: New.
5802 (free_dwo_file): Remove, move content to ~dwo_file.
5803 (struct dwo_file_deleter): Remove.
5804 (dwo_file_up>: Remove custom deleter.
5805 (free_dwo_files): Remove.
5806 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5807 dwo_files.
5808 (process_skeletonless_type_units): Call unique_ptr::get.
5809 (allocate_dwo_file_hash_table): Add deleter to created hash
5810 table. Change return type to htab_up.
5811 (lookup_dwo_file_slot): Don't memset dwo_file, call
5812 unique_ptr::get.
5813 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5814 (create_dwo_unit_in_dwp_v2): Likewise.
5815 (open_and_init_dwo_file): Likewise.
5816 (free_dwo_file_from_slot): Remove.
5817
dc4ccb6f
SM
58182019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5819
5820 * dwarf2read.h (struct dwarf2_section_info) <readin,
5821 is_virtual>: Change type to bool.
5822 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5823 true instead of 1.
5824
e6a1c5cb
TT
58252019-06-19 Tom Tromey <tom@tromey.com>
5826
5827 * tui/tui-data.h (tui_init_content_element): Don't declare.
5828
6f6ffbeb
TT
58292019-06-19 Tom Tromey <tom@tromey.com>
5830
5831 * tui/tui-data.h (tui_init_win_info): Don't declare.
5832
f23f598e
TV
58332019-06-19 Tom de Vries <tdevries@suse.de>
5834
5835 * dwarf2read.h (abstract_to_concrete): Change type to
5836 std::unordered_map<sect_offset, std::vector<sect_offset>,
5837 gdb::hash_enum<sect_offset>>.
5838
680e1bee
TT
58392019-06-19 Tom Tromey <tromey@adacore.com>
5840
5841 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5842 EVAL_AVOID_SIDE_EFFECTS specially.
5843
dcf37923
TT
58442019-06-19 Tom Tromey <tromey@adacore.com>
5845
5846 * source-cache.c (highlighter): New global.
5847 (source_cache::get_source_lines): Create a highlighter on demand.
5848
494986d5
AB
58492019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5850
5851 * defs.h (deprecated_interactive_hook): Delete declaration.
5852 * interps.c (clear_interpreter_hooks): Remove use of
5853 deprecated_interactive_hook.
5854 * top.c (deprecated_interactive_hook): Delete definition.
5855 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5856
3360b6e7
TV
58572019-06-18 Tom de Vries <tdevries@suse.de>
5858
5859 PR gdb/24515
5860 * dwarf2read.h (abstract_to_concrete): Change type from
5861 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5862 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5863 * dwarf2read.c (read_variable): Update.
5864 (dwarf2_fetch_die_loc_sect_off): Update.
5865
310b3441
TV
58662019-06-17 Tom de Vries <tdevries@suse.de>
5867
5868 PR gdb/24617
5869 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5870 accessing parent[parent_len - 1].
5871
ba9777be
PP
58722019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5873
5874 PR gdb/24364
5875 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5876 call dtrace_process_dof with NULL dof.
5877
2b9f6e89
TV
58782019-06-16 Tom de Vries <tdevries@suse.de>
5879
5880 PR gdb/24445
5881 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5882
431b3ead
TT
58832019-06-16 Tom Tromey <tom@tromey.com>
5884
5885 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5886 (make_all_visible): Use address of member.
5887
d04b44a1
TT
58882019-06-16 Tom Tromey <tom@tromey.com>
5889
5890 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5891 (tui_free_window, free_content, free_content_elements): Remove
5892 unnecessary cast.
5893 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5894 cast.
5895 * tui/tui-regs.c (tui_show_register_group)
5896 (tui_display_registers_from, tui_display_reg_element_at_line):
5897 Remove unnecessary cast.
5898
bf5142e7
AB
58992019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5900
5901 * linux-nat.c (normal_mask): Delete.
5902 (_initialize_linux_nat): Don't initialise normal_mask.
5903
c4973306
SM
59042019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5905
5906 PR gdb/24445
5907 * dwarf-index-write.h (write_psymtabs_to_index): Add
5908 dwz_basename parameter.
5909 * dwarf-index-write.c (write_gdbindex): Move file writing to
5910 write_gdbindex_1. Change return type void.
5911 (assert_file_size): Move up, remove filename parameter.
5912 (write_gdbindex_1): New function.
5913 (write_debug_names): Change return type to void, call
5914 assert_file_size.
5915 (struct index_wip_file): New struct.
5916 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5917 file logic to index_wip_file. Write index for dwz file if
5918 needed.
5919 (save_gdb_index_command): Pass basename of dwz file, if present.
5920 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5921 build-id of dwz file, if present.
5922 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5923 (dwarf2_get_dwz_file): Likewise.
5924 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5925 (dwarf2_get_dwz_file): Likewise.
5926
395f9c91
TT
59272019-06-16 Tom Tromey <tom@tromey.com>
5928
5929 * coffread.c (process_coff_symbol): Use xstrdup.
5930 * value.c (create_internalvar): Use xstrdup.
5931
cafb3438
TT
59322019-06-16 Tom Tromey <tom@tromey.com>
5933
5934 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5935 * breakpoint.c (stopin_command, stopat_command)
5936 (until_break_command, decode_location_default): Remove unnecessary
5937 cast.
5938 * utils.c (subset_compare): Remove unnecessary cast.
5939 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5940 cast.
5941 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5942 cast.
5943 * infcmd.c (path_command): Remove unnecessary cast.
5944 * coffread.c (decode_type): Remove unnecessary cast.
5945 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5946 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5947 * tui/tui-stack.c (tui_show_locator_content)
5948 (tui_show_frame_info): Remove unnecessary cast.
5949 * tui/tui-win.c (tui_scroll_forward_command)
5950 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5951 (parse_scrolling_args): Remove unnecessary cast.
5952 * tui/tui-data.c (init_win_info, tui_del_window)
5953 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5954 (free_content_elements): Remove unnecessary cast.
5955 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5956 unnecessary cast.
5957 * tui/tui-source.c (tui_set_source_content)
5958 (tui_vertical_source_scroll): Remove unnecessary cast.
5959 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5960 cast.
5961 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5962 * tui/tui-regs.c (tui_display_registers_from)
5963 (tui_display_register): Remove unnecessary cast.
5964 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5965 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5966 (make_visible): Remove unnecessary cast.
5967 * tui/tui-winsource.c (tui_erase_source_content)
5968 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5969 unnecessary cast.
5970 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5971 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5972 * stabsread.c (read_type, read_array_type, read_range_type):
5973 Remove unnecessary cast.
5974 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5975 (parse_symbol, parse_type, upgrade_type, parse_external)
5976 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5977 unnecessary cast.
5978 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5979
730ead81
TT
59802019-06-16 Tom Tromey <tom@tromey.com>
5981
5982 * tui/tui-data.c (tui_alloc_generic_win_info)
5983 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5984 checks.
5985
584a927c
AB
59862019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5987 Andrew Burgess <andrew.burgess@embecosm.com>
5988
5989 * f-typeprint.c (f_print_type): Don't return early for not
5990 associated or not allocated types.
5991 (f_type_print_varspec_suffix): Add print_rank parameter and print
5992 ranks of array types in case they dangling.
5993 (f_type_print_base): Add print_rank parameter.
5994
30056ea0
AB
59952019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5996
5997 * NEWS: Mention new MI commands.
5998 * break-catch-throw.c (enum exception_event_kind): Move to
5999 breakpoint.h.
6000 (print_mention_exception_catchpoint): Output text as a single
6001 message.
6002 (catch_exception_command_1): Rename to...
6003 (catch_exception_event): ...this, make non-static, update header
6004 command, and change some parameter types.
6005 (catch_catch_command): Update for changes to
6006 catch_exception_command_1.
6007 (catch_throw_command): Likewise.
6008 (catch_rethrow_command): Likewise.
6009 * breakpoint.c (enum exception_event_kind): Delete.
6010 * breakpoint.h (enum exception_event_kind): Moved here from
6011 break-catch-throw.c.
6012 (catch_exception_event): Declare.
6013 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6014 (mi_cmd_catch_throw): New function.
6015 (mi_cmd_catch_rethrow): New function.
6016 (mi_cmd_catch_catch): New function.
6017 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6018 'catch-catch' entries.
6019 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6020 (mi_cmd_catch_rethrow): Declare.
6021 (mi_cmd_catch_catch): Declare.
6022
ec8e2b6d
AB
60232019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6024
6025 * annotate.c (annotate_source_line): Change return type to void,
6026 update implementation to match.
6027 * annotate.h (annotate_source_line): Change return type to void,
6028 update header comment.
6029 * stack.c (print_frame_info): Don't change what frame information
6030 is printed based on whether annotations are on or not.
6031
0d3abd8c
AB
60322019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6033
6034 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6035 (annotate_source): Make static.
6036 (annotate_source_line): Moved from source.c and renamed from
6037 identify_source_line. Update the return type.
6038 * annotate.h (annotate_source): Delete declaration.
6039 (annotate_source_line): Declaration moved from source.h, and
6040 renamed from identify_source_line. Return type updated.
6041 * source.c (identify_source_line): Moved to annotate.c and renamed
6042 to annotate_source_line.
6043 (info_line_command): Remove check of annotation_level.
6044 * source.h (identify_source_line): Move declaration to annotate.h
6045 and rename to annotate_source_line.
6046 * stack.c: Add 'annotate.h' include.
6047 (print_frame_info): Remove check of annotation_level before
6048 calling annotate_source_line.
6049
00df30ae
AB
60502019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6051
6052 * source-cache.c (source_cache::get_plain_source_lines): Use
6053 open_source_file_with_line_charpos instead of just
6054 open_source_file, remove call to find_source_lines.
6055 (source_cache::get_source_lines): Likewise.
6056 * source.c (find_source_lines): Make static.
6057 (get_filename_and_charpos): Renamed into...
6058 (open_source_file_with_line_charpos): ..this along with changes to
6059 return a scoped_fd, and some other minor clean ups.
6060 (identify_source_line): Use open_source_file_with_line_charpos.
6061 (search_command_helper): Use open_source_file_with_line_charpos
6062 instead of just open_source_file, remove call to
6063 find_source_lines.
6064 * source.h (open_source_file_with_line_charpos): Declare new
6065 function.
6066 (find_source_lines): Delete declaration.
6067
afda45a2
AB
60682019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6069
6070 * source.c (get_filename_and_charpos): Remove fullname
6071 parameter.
6072 (identify_source_line): Update call to get_filename_and_charpos.
6073
0735b091
TT
60742019-06-14 Tom Tromey <tromey@adacore.com>
6075
6076 PR gdb/24502:
6077 * ui-style.h (skip_ansi_escape): Update comment.
6078 * ui-file.h (class no_terminal_escape_file): New class.
6079 * ui-file.c (no_terminal_escape_file::write)
6080 (no_terminal_escape_file::puts): New methods.
6081 * cli/cli-logging.c (handle_redirections): Use
6082 no_terminal_escape_file.
6083
52ce35e2
TT
60842019-06-14 Tom Tromey <tromey@adacore.com>
6085
6086 * NEWS: Move convenience variable news above Python news.
6087
73cc7272
TT
60882019-06-14 Tom Tromey <tom@tromey.com>
6089
6090 * gnulib: Move directory to top-level.
6091 * configure.ac: Don't configure gnulib.
6092 * configure: Rebuild.
6093 * common/common-defs.h: Use new path to gnulib.
6094 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6095 (GNULIB_H): Remove.
6096 (INCGNU): Look in new gnulib location.
6097 (HFILES_NO_SRCDIR): Remove gnulib files.
6098 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6099 (generated_files): Remove GNULIB_H.
6100 ($(LIBGNU), all-lib): Remove targets.
6101 (distclean): Don't mention GNULIB_BUILDDIR.
6102 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6103
f5686554
TT
61042019-06-14 Tom Tromey <tromey@adacore.com>
6105
6106 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6107 Warn if symbol file does not provide any symbols.
6108
a0c1ffed
TT
61092019-06-14 Tom Tromey <tromey@adacore.com>
6110
6111 * source.c (find_and_open_source): Respect basenames_may_differ.
6112
7c39e397
AB
61132019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6114
6115 * annotate.c (annotate_breakpoints_invalid): Make use of
6116 scoped_restore_terminal_state.
6117 (annotate_frames_invalid): Likewise.
6118
f411722c
TT
61192019-06-14 Tom Tromey <tromey@adacore.com>
6120
6121 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6122 allow assignment to an internalvar.
6123
4268ec18
TT
61242019-06-14 Tom Tromey <tromey@adacore.com>
6125
6126 * ada-lex.l: Allow "_" in attribute names.
6127
abdb711e
TT
61282019-06-14 Tom Tromey <tromey@adacore.com>
6129
6130 PR gdb/24653:
6131 * regcache.c (registers_changed): Don't call alloca.
6132 * top.c (execute_command): Don't call alloca.
6133
4c048731
PA
61342019-06-13 Pedro Alves <palves@redhat.com>
6135
6136 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6137 'expression'. When parsing an expression, error out if there's
6138 junk after "unlimited".
6139 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6140 (do_set_command): Adjust calls to is_unlimited_literal.
6141
66eb1ed3
PA
61422019-06-13 Pedro Alves <palves@redhat.com>
6143
6144 * compile/compile.c (make_compile_options_def_group): Add braces
6145 around array_view initializer.
6146 * thread.c (make_thread_apply_all_options_def_group)
6147 (make_thread_apply_all_options_def_group): Likewise.
6148
3345721a
PA
61492019-06-13 Pedro Alves <palves@redhat.com>
6150
6151 * NEWS (New commands): Mention "maint test-options
6152 require-delimiter", "maint test-options unknown-is-error", "maint
6153 test-options unknown-is-operand" and "maint show
6154 test-options-completion-result".
6155 (New command options, command completion): New section.
6156 (Completion improvements): New section.
6157 Mention that you can abbreviate "unlimited".
6158
6206060d
PA
61592019-06-13 Pedro Alves <palves@redhat.com>
6160
6161 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6162 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6163 * unittests/cli-utils-selftests.c (test_parse_flags)
6164 (test_parse_flags_qcs): Delete.
6165 (test_cli_utils): Don't call deleted functions.
6166
6665660a
PA
61672019-06-13 Pedro Alves <palves@redhat.com>
6168
6169 * thread.c: Include "cli/cli-option.h".
6170 (tp_array_compar_ascending): Global.
6171 (tp_array_compar): Delete function.
6172 (tp_array_compar_ascending, tp_array_compar_descending): New
6173 functions.
6174 (ascending_option_def, qcs_flag_option_def)
6175 (thr_qcs_flags_option_defs)
6176 (make_thread_apply_all_options_def_group)
6177 (make_thread_apply_options_def_group): New.
6178 (thread_apply_all_command): Use gdb::option::process_options.
6179 (thread_apply_command_completer)
6180 (thread_apply_all_command_completer): New.
6181 (thread_apply_command): Use gdb::option::process_options.
6182 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6183 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6184 to generate help text of "thread apply". Adjust "taas"'s help.
6185 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6186 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6187
f7e13587
PA
61882019-06-13 Pedro Alves <palves@redhat.com>
6189
6190 * thread.c (thread_apply_command): Check for invalid TID with
6191 isdigit instead of !isalpha.
6192
5d707134
PA
61932019-06-13 Pedro Alves <palves@redhat.com>
6194
6195 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6196 (validate_flags_qcs): New.
6197 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6198 (validate_flags_qcs): Declare.
6199 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6200 (make_frame_apply_options_def_group): New.
6201 (frame_apply_command_count): Process options with
6202 gdb::option::process_options.
6203 (frame_apply_completer): New.
6204 (frame_apply_level_completer, frame_apply_all_completer)
6205 (frame_apply_completer): New.
6206 (_initialize_stack): Update help of "frame apply", "frame apply
6207 level", "frame apply all" and "faas" to mention supported options
6208 and install command completers.
6209 * stack.h (frame_apply_all_completer): Declare.
6210 * thread.c: Include "stack.h".
6211 (tfaas_command): Add "--".
6212 (_initialize_thread): Update help "tfaas" to mention supported
6213 options and install command completer.
6214
272d4594
PA
62152019-06-13 Pedro Alves <palves@redhat.com>
6216
6217 * completer.c (complete_nested_command_line): New.
6218 (gdb_completion_word_break_characters_throw): Add assertion.
6219 * completer.h (complete_nested_command_line): Declare.
6220
90a1ef87
PA
62212019-06-13 Pedro Alves <palves@redhat.com>
6222
6223 * stack.c (parse_backtrace_qualifiers): New.
6224 (backtrace_command): Use it.
6225 (backtrace_command_completer): Complete on qualifiers.
6226
d4c16835
PA
62272019-06-13 Pedro Alves <palves@redhat.com>
6228
6229 * frame.c: Include "cli/cli-option.h.
6230 (user_set_backtrace_options): New.
6231 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6232 Delete.
6233 (get_prev_frame): Adjust.
6234 (boolean_option_def, uinteger_option_def)
6235 (set_backtrace_option_defs): New.
6236 (_initialize_frame): Adjust and use
6237 gdb::option::add_setshow_cmds_for_options to install "set
6238 backtrace past-main" and "set backtrace past-entry".
6239 * frame.h: Include "cli/cli-option.h".
6240 (struct frame_print_options): Forward declare.
6241 (print_frame_arguments_all, print_frame_arguments_scalars)
6242 (print_frame_arguments_none): Declare.
6243 (print_entry_values): Delete declaration.
6244 (struct frame_print_options, user_frame_print_options): New.
6245 (struct set_backtrace_options): New.
6246 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6247 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6248 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6249 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6250 (list_args_or_locals): Add frame_print_options parameter.
6251 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6252 * python/py-framefilter.c (enumerate_args): Pass down
6253 USER_FRAME_PRINT_OPTIONS.
6254 * stack.c: Include "cli/cli-option.h".
6255 (print_frame_arguments_all, print_frame_arguments_scalars)
6256 (print_frame_arguments_none): Declare.
6257 (print_raw_frame_arguments, print_entry_values): Delete.
6258 (user_frame_print_options): New.
6259 (boolean_option_def, enum_option_def, frame_print_option_defs):
6260 New.
6261 (struct backtrace_cmd_options): New.
6262 (bt_flag_option_def): New.
6263 (backtrace_command_option_defs): New.
6264 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6265 (print_frame_arg, read_frame_arg, print_frame_args)
6266 (print_frame_info, print_frame): Add frame_print_options parameter
6267 and use it.
6268 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6269 (backtrace_command_1): Add frame_print_options and
6270 backtrace_cmd_options parameters and use them.
6271 (make_backtrace_options_def_group): New.
6272 (backtrace_command): Process command options with
6273 gdb::option::process_options.
6274 (backtrace_command_completer): New.
6275 (_initialize_stack): Extend "backtrace"'s help to mention
6276 supported options. Install completer for "backtrace".
6277 Install some settings commands with add_setshow_cmds_for_options.
6278
2daf894e
PA
62792019-06-13 Pedro Alves <palves@redhat.com>
6280
6281 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6282 and that "set/show print raw frame-arguments" are now deprecated.
6283
6284 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6285 command.
6286 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6287 * stack.c (_initialize_stack): Install "set/show print
6288 raw-frame-arguments", and deprecate "set/show print raw
6289 frame-arguments".
6290 * valprint.c (_initialize_valprint): Deprecate "set/show print
6291 raw".
6292
e6ed716c
PA
62932019-06-13 Pedro Alves <palves@redhat.com>
6294
6295 * compile/compile.c (struct compile_options): New.
6296 (compile_flag_option_def, compile_command_option_defs)
6297 (make_compile_options_def_group): New.
6298 (compile_file_command): Handle options with
6299 gdb::option::process_options.
6300 (compile_file_command_completer): New function.
6301 (compile_code_command): Handle options with
6302 gdb::option::process_options.
6303 (compile_code_command_completer): New function.
6304 (_initialize_compiler): Install completers for "compile code" and
6305 "compile file". Mention available options in "compile code" and
6306 "compile code"'s help.
6307 * completer.c (advance_to_completion_word): New, factored out from
6308 ...
6309 (advance_to_expression_complete_word_point): ... this.
6310 (advance_to_filename_complete_word_point): New.
6311 * completer.h (advance_to_filename_complete_word_point): New
6312 declaration.
6313
7d8062de
PA
63142019-06-13 Pedro Alves <palves@redhat.com>
6315
6316 * compile/compile.c: Include "cli/cli-option.h".
6317 (compile_print_value): Scope data pointer is now a
6318 value_print_options pointer; adjust.
6319 (compile_print_command): Process options. Scope data pointer is
6320 now a value_print_options pointer; adjust.
6321 (_initialize_compile): Update "compile print"'s help to include
6322 supported options. Install a completer for "compile print".
6323 * cp-valprint.c (show_vtblprint, show_objectprint)
6324 (show_static_field_print): Delete.
6325 (_initialize_cp_valprint): Don't install "set print
6326 static-members", "set print vtbl", "set print object" here.
6327 * printcmd.c: Include "cli/cli-option.h" and
6328 "common/gdb_optional.h".
6329 (print_command_parse_format): Rework to fill in a
6330 value_print_options instead of a format_data.
6331 (print_value): Change parameter type from format_data pointer to
6332 value_print_options reference. Adjust.
6333 (print_command_1): Process options. Adjust to pass down a
6334 value_print_options.
6335 (print_command_completer): New.
6336 (_initialize_printcmd): Install print_command_completer as
6337 handle_brkchars completer for the "print" command. Update
6338 "print"'s help to include supported options.
6339 * valprint.c: Include "cli/cli-option.h".
6340 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6341 here from cp-valprint.c.
6342 (boolean_option_def, uinteger_option_def)
6343 (value_print_option_defs, make_value_print_options_def_group):
6344 New. Use gdb::option::add_setshow_cmds_for_options to install
6345 "set print elements", "set print null-stop", "set print repeats",
6346 "set print pretty", "set print union", "set print array", "set
6347 print address", "set print symbol", "set print array-indexes".
6348 * valprint.h: Include <string> and "cli/cli-option.h".
6349 (make_value_print_options_def_group): Declare.
6350 (print_value): Change parameter type from format_data pointer to
6351 value_print_options reference.
6352 (print_command_completer): Declare.
6353
9d0faba9
PA
63542019-06-13 Pedro Alves <palves@redhat.com>
6355
6356 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6357 (COMMON_SFILES): Add maint-test-settings.c.
6358 * cli/cli-decode.c (boolean_enums): New global, factored out from
6359 ...
6360 (add_setshow_boolean_cmd): ... here.
6361 * cli/cli-decode.h (boolean_enums): Declare.
6362 * cli/cli-option.c: New file.
6363 * cli/cli-option.h: New file.
6364 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6365 factored out from ...
6366 (parse_cli_boolean_value(const char *)): ... this.
6367 (is_unlimited_literal): Change parameter type to pointer to
6368 pointer. Adjust and advance ARG pointer.
6369 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6370 (parse_cli_var_enum): New, factored out from ...
6371 (do_set_command): ... this. Adjust.
6372 * cli/cli-setshow.h (parse_cli_boolean_value)
6373 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6374 (parse_cli_var_enum): Declare.
6375 * cli/cli-utils.c: Include "cli/cli-option.h".
6376 (get_ulongest): New.
6377 * cli/cli-utils.h (get_ulongest): Declare.
6378 (check_for_argument): New overloads.
6379 * maint-test-options.c: New file.
6380
2c722807
PA
63812019-06-13 Pedro Alves <palves@redhat.com>
6382
6383 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6384 parse a range if "-" is at the end of the string.
6385
dee7b4c8
PA
63862019-06-13 Pedro Alves <palves@redhat.com>
6387
6388 * cli/cli-setshow.c (parse_auto_binary_operation)
6389 (parse_cli_boolean_value): Don't allow "o".
6390
dca0f6c0
PA
63912019-06-13 Pedro Alves <palves@redhat.com>
6392
6393 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6394 * NEWS: Mention maint test-settings KIND.
6395 * maint-test-settings.c: New file.
6396
597bf39d
PA
63972019-06-13 Pedro Alves <palves@redhat.com>
6398
6399 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6400 completer.
6401 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6402 "set" completers.
6403
48c410fb
PA
64042019-06-13 Pedro Alves <palves@redhat.com>
6405
6406 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6407 after item.
6408
93bcb043
PA
64092019-06-13 Pedro Alves <palves@redhat.com>
6410
6411 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6412
cbba3ecd
PA
64132019-06-13 Pedro Alves <palves@redhat.com>
6414
6415 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6416 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6417 call.
6418 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6419 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6420 calls.
6421 (check_for_argument): Skip spaces after argument.
6422
b9a3f842
PA
64232019-06-13 Pedro Alves <palves@redhat.com>
6424
6425 * thread.c (thread_apply_command): Adjust TID parsing.
6426 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6427 detected before end of string.
6428 (tid_is_in_list): Error out if LIST is invalid.
6429
3844e605
PA
64302019-06-13 Pedro Alves <palves@redhat.com>
6431
6432 * completer.c (complete_line_internal_1): Rewind completion word
6433 point.
6434 (completion_tracker::advance_custom_word_point_by): Change
6435 parameter type to int.
6436 * completer.h (completion_tracker::advance_custom_word_point_by):
6437 Likewise.
6438
00b56dbe
PA
64392019-06-13 Pedro Alves <palves@redhat.com>
6440
6441 * completer.c (advance_to_completion_word): Handle delimiters.
6442
d106773e
PA
64432019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6444
6445 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6446
08f10e02
TT
64472019-06-11 Tom Tromey <tom@tromey.com>
6448
6449 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6450 (xmalloc_failed): Move to alloc.c.
6451 * alloc.c: New file.
6452 * Makefile.in (COMMON_SFILES): Add alloc.c.
6453
1c7fe951
TT
64542019-06-11 Tom Tromey <tom@tromey.com>
6455
6456 * nat/linux-waitpid.c: Don't include server.h.
6457 (linux_debug): Remove.
6458 (my_waitpid): Update.
6459
89549d7f
TT
64602019-06-11 Tom Tromey <tromey@adacore.com>
6461
6462 * infcall.c (_initialize_infcall): Remove trailing newline from
6463 help.
6464 * user-regs.c (_initialize_user_regs): Remove trailing newline
6465 from help.
6466 * typeprint.c (_initialize_typeprint): Remove trailing newline
6467 from help.
6468 * reverse.c (_initialize_reverse): Remove trailing newlines from
6469 help.
6470 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6471 from help.
6472 * language.c (add_set_language_command): Remove trailing newline
6473 from help.
6474 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6475 help.
6476 * disasm.c (_initialize_disasm): Remove trailing newline from
6477 help.
6478 * top.c (init_main): Remove trailing newline from help.
6479 * interps.c (_initialize_interpreter): Remove trailing newline
6480 from help.
6481 * btrace.c (_initialize_btrace): Remove trailing newlines from
6482 help.
6483 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6484 from help.
6485 * python/python.c (_initialize_python): Remove trailing newline
6486 from help.
6487 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6488 help.
6489 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6490 from help. Reformat some text.
6491 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6492 from help.
6493 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6494 newline from help.
6495
86108c13
TT
64962019-06-11 Tom Tromey <tromey@adacore.com>
6497
6498 * darwin-nat.c (darwin_decode_exception_message)
6499 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6500
a7067863
AB
65012019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6502
6503 * valops.c (value_slice): Check for not allocated or not
6504 associated values.
6505
9ab08412
TV
65062019-06-10 Tom de Vries <tdevries@suse.de>
6507
6508 PR gdb/24618
6509 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6510 sure an empty slot (defined by a 32-bit zero pair) is recognized as
6511 invalid.
6512
f19e22e9
TV
65132019-06-10 Tom de Vries <tdevries@suse.de>
6514
6515 PR gdb/24611
6516 * linespec.c (linespec_lexer_lex_string): Remove incorrect
6517 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
6518
e99f9db0
TV
65192019-06-10 Tom de Vries <tdevries@suse.de>
6520
6521 PR symtab/24545
6522 * symtab.c (struct demangled_name_entry): Add language field.
6523 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
6524 static minimal symbol". Set and use language field.
6525
9bf7038b
TT
65262019-06-10 Tom Tromey <tromey@adacore.com>
6527
6528 * ada-lang.c (_initialize_ada_language): Update help text.
6529
422186a9
TT
65302019-06-10 Tom Tromey <tromey@adacore.com>
6531
6532 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6533 with a newline.
6534 * guile/guile.c (handle_boot_error): Don't end warning with a
6535 newline.
6536 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6537 warning with a newline.
6538 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6539 newline.
6540 (s12z_frame_cache): Likewise.
6541 * dwarf-index-cache.c (index_cache::store): Don't end warning with
6542 a newline.
6543 * solib-svr4.c (disable_probes_interface): Don't end warning with
6544 a newline.
6545 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6546 newline.
6547 * python/python.c (do_finish_initialization): Don't end warning
6548 with a newline.
6549
25ce02ee
TT
65502019-06-10 Tom Tromey <tom@tromey.com>
6551
6552 * python/py-breakpoint.c (gdbpy_breakpoint_created)
6553 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6554 gdbpy_enter.
6555
caa429d8
TT
65562019-06-10 Tom Tromey <tromey@adacore.com>
6557
6558 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6559 data.
6560 (elf_new_init): Don't call stabsread_new_init.
6561 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6562 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
6563 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6564
81873cc8
TV
65652019-06-10 Tom de Vries <tdevries@suse.de>
6566
6567 PR symtab/16264
6568 PR symtab/24517
6569 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6570
4fa0265e
РИ
65712019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
6572
6573 * source.c (find_and_open_source): Also rewrite relative file
6574 names.
6575
1a3da2cd
AB
65762019-04-26 Amos Bird <amosbird@gmail.com>
6577
6578 * annotate.c (annotate_thread_exited): Add "thread-exited"
6579 annotation.
6580
3847a7bf
TT
65812019-06-06 Tom Tromey <tromey@adacore.com>
6582
6583 * maint.h (class scoped_command_stats): Use
6584 DISABLE_COPY_AND_ASSIGN.
6585 <print_time>: New method.
6586 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6587 print_time.
6588 (scoped_command_stats::print_time): New method.
6589
312617a3
AB
65902019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
6591
6592 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6593 instructions of lengths 6 or 8 bytes.
6594
b02f78f9
PA
65952019-06-04 Pedro Alves <palves@redhat.com>
6596
6597 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6598
6599 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6600 * breakpoint.c (condition_completer): Likewise.
6601 * cli/cli-dump.c (scan_expression): Likewise.
6602 * common/filestuff.c (mkdir_recursive): Likewise.
6603 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6604 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6605 (gdb_abspath): Likewise.
6606 * compile/compile-cplus-types.c
6607 (compile_cplus_instance::decl_name): Likewise.
6608 * completer.c (complete_explicit_location):
6609 (signal_completer, reg_or_group_completer_1): Likewise.
6610 * cp-support.c (cp_remove_params_if_any): Likewise.
6611 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6612 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6613 * infcmd.c (strip_bg_char): Likewise.
6614 * linespec.c (copy_token_string): Likewise.
6615 * mi/mi-main.c (output_cores): Likewise.
6616 * psymtab.c (psymtab_search_name):
6617 * symfile.c (test_set_ext_lang_command): Likewise.
6618 * target.c (target_fileio_read_stralloc): Likewise.
6619 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6620 * value.c (complete_internalvar): Likewise.
6621
e1f2e1a2
CB
66222019-06-04 Christian Biesinger <cbiesinger@google.com>
6623
6624 Add objfile property to gdb.Type.
d3238f7d
PA
6625 * NEWS: Mention Python API addition.
6626 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 6627
e664d728
PW
66282019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6629
6630 * NEWS: Mention the new set|show style [title|highlight].
6631 Mention changes to "show style", "help" and "apropos".
6632
66d8c862
PW
66332019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6634
6635 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6636 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
6637 instead of print_help_for_command.
6638 (print_doc_of_command): New function.
6639 (help_list): Add 'apropos -v word' suggestion.
6640 (print_help_for_command): Style the command name using title style.
6641 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6642 (_initialize_cli_cmds): Describe -v in apropos_command help.
6643
9303eb2f
PW
66442019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6645
6646 * cli/cli-style.h (cli_style_option): Add name in constructor,
6647 add m_name class member, add constructor with intensity,
6648 add name class function.
6649 (cli_style_option::add_setshow_commands): Remove name argument.
6650 (highlight_style, title_style): New styles.
6651 * cli/cli-style.c (do_show): New function that shows a style
6652 characteristic styling the style name with itself.
6653 (set_style_name): New function.
6654 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6655 Update all callers according to the changes in cli/cli-style.h.
6656 * utils.h (fputs_highlighted): New function.
6657 * utils.c (fputs_highlighted): Likewise.
6658
e2c52041
PW
66592019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6660
6661 * NEWS: Mention new pipe command and new convenience variables.
6662
947d3946
PW
66632019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6664
6665 * cli/cli-cmds.c (pipe_command): New function.
6666 (_initialize_cli_cmds): Call add_com for pipe_command.
6667 Define | as an alias for pipe.
6668 (exit_status_set_internal_vars): New function.
6669 (shell_escape): Call exit_status_set_internal_vars.
6670 cli/cli-decode.c (find_command_name_length): Recognize | as
6671 a single character command.
6672
b8fd0918
PW
66732019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6674
6675 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6676 top.c (execute_command_to_ui_file): New function, mostly a copy
6677 of execute_command_to_string.
6678 (execute_command_to_string): Implement by calling
6679 execute_command_to_ui_file.
6680
68bb5386
PW
66812019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6682
6683 * top.h (saved_command_line): Remove declaration.
6684 * top.c (previous_saved_command_line, previous_repeat_arguments):
6685 New variables.
6686 (saved_command_line): Make static, define together with other
6687 'repeat variables'.
6688 (dont_repeat): Clear repeat_arguments.
6689 (repeat_previous, get_saved_command_line, save_command_line):
6690 New functions.
6691 (gdb_init): Initialize saved_command_line
6692 and previous_saved_command_line.
6693 * main.c (captured_main_1): Remove saved_command_line initialization.
6694 * event-top.c (handle_line_of_input): Update to use
6695 the new 'repeat' related functions instead of direct access to
6696 saved_command_line.
6697 * command.h (repeat_previous, get_saved_command_line,
6698 save_command_line): New declarations.
6699 (dont_repeat): Add comment.
6700
bfcdb852
TT
67012019-05-30 Tom Tromey <tromey@adacore.com>
6702
6703 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6704 Fix comment.
6705 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6706
0ef209f2
JV
67072019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6708
6709 PR cli/24587
6710 * completer.c (complete): Initialize variable word.
6711
955b06fa
SDJ
67122019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6713
6714 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6715 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6716 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6717 'body' is NULL to the outter 'if', protecting the '!is_define'
6718 situation as well.
6719
fa9c3fa0
TT
67202019-05-29 Tom Tromey <tromey@adacore.com>
6721
6722 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6723 (dwarf_unknown): New function.
6724 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6725 (dwarf_type_encoding_name): Use dwarf_unknown.
6726
4330d61d
TT
67272019-05-29 Tom Tromey <tromey@adacore.com>
6728
6729 PR c++/20020:
6730 * cp-valprint.c (cp_print_value_fields): Call
6731 cp_print_static_field inside "try".
6732
33a6bc35
TT
67332019-05-29 Tom Tromey <tromey@adacore.com>
6734
6735 * inflow.c (struct terminal_info): Add default operator=.
6736 * configure: Rebuild.
6737 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6738 -Wdeprecated-copy-dtor, -Wredundant-move.
6739
000439d5
TT
67402019-05-29 Tom Tromey <tromey@adacore.com>
6741
6742 * NEWS: Add entry.
6743 * infcmd.c (print_return_value_1): Handle finish_print
6744 option.
6745 (show_print_finish): New function.
6746 (_initialize_infcmd): Add "set/show print finish" commands.
6747 * valprint.c (user_print_options): Initialize new member.
6748 * valprint.h (struct value_print_options) <finish_print>: New
6749 member.
6750
c0e70c62
TT
67512019-05-28 Tom Tromey <tromey@adacore.com>
6752
6753 * ada-lang.c (ada_remove_Xbn_suffix)
6754 (find_old_style_renaming_symbol)
6755 (parse_old_style_renaming): Remove.
6756 (ada_find_renaming_symbol): Don't call
6757 find_old_style_renaming_symbol.
6758 (ada_is_renaming_symbol): Rename from
6759 ada_find_renaming_symbol. Remove "block" parameter. Return
6760 bool. Now static.
6761 (ada_read_var_value): Update and simplify.
6762 * ada-exp.y (write_var_or_type): Remove old code.
6763
766f8836
AH
67642019-05-28 Alan Hayward <alan.hayward@arm.com>
6765
6766 * event-top.c: Remove include comment.
6767 * inflow.c (class scoped_ignore_sigttou): Move from here...
6768 * inflow.h (class scoped_ignore_sigttou): ...to here.
6769 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6770 * top.c: Remove include comment.
6771
eb41253a
TT
67722019-05-27 Tom Tromey <tom@tromey.com>
6773
6774 * NEWS: Fix typo.
6775
4ca51187
TT
67762019-05-22 Tom Tromey <tromey@adacore.com>
6777
6778 * target.c (target_follow_exec): Constify parameter.
6779 * target-delegates.c: Rebuild.
6780 * remote.c (remote_target::follow_exec): Constify parameter.
6781 * infrun.c (follow_exec): Constify parameter.
6782 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6783 (target_follow_exec): Likewise.
6784
8fca4da0
AH
67852019-05-22 Alan Hayward <alan.hayward@arm.com>
6786
6787 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6788 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6789
b7060614
AH
67902019-05-22 Alan Hayward <alan.hayward@arm.com>
6791
6792 * NEWS: Add debugredirect and testsuite sections.
6793
0a5954bd
SC
67942019-05-22 Simon Cook <simon.cook@embecosm.com>
6795
6796 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6797 target descriptions using exclusively floating point register name
6798 aliases.
6799
dc42e902
AB
68002019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6801
6802 PR gdb/18644:
6803 * f-lang.c (build_fortran_types): Handle the case where
6804 gdbarch_floatformat_for_type returns a nullptr.
6805
fb7806c7
TV
68062019-05-21 Tom de Vries <tdevries@suse.de>
6807
6808 PR cli/24587
6809 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6810
34d11c68
AB
68112019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6812
6813 PR gdb/18644:
6814 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6815 16-byte floats.
6816 * i386-tdep.c (i386_floatformat_for_type): Use
6817 floatformats_ia64_quad for the 16-byte floating point component
6818 within a fortran 32-byte complex number.
6819
122cf0f2
AB
68202019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6821
6822 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6823 delete default constructor.
6824 (find_partial_die): Update to return const struct.
6825 (partial_die_parent_scope): Move variable declaration into scope
6826 of its use and change its type to auto.
6827 (guess_partial_die_structure_name): Likewise.
6828 (partial_die_info::fixup): Likewise.
6829
33d0e35a
TT
68302019-05-17 Tom Tromey <tromey@adacore.com>
6831
6832 * source.c (find_and_open_source): Remove cast.
6833
a45575b0
TT
68342019-05-17 Tom Tromey <tromey@adacore.com>
6835
6836 * annotate.c (annotate_source): Make "filename" const.
6837 * annotate.h (annotate_source): Use const.
6838
81f47ac2
AH
68392019-05-17 Alan Hayward <alan.hayward@arm.com>
6840
6841 * disasm.c (set_disassembler_options): Send errors to stderr.
6842
ca1285d1
AH
68432019-05-17 Alan Hayward <alan.hayward@arm.com>
6844
6845 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6846 (cli_interp_base::set_logging): Check debug_redirect.
6847 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6848 * cli/cli-logging.c (debug_redirect): Add static variable.
6849 (pop_output_files): Add default param.
6850 (handle_redirections): Print debug setting.
6851 (show_logging_command): Likewise.
6852 (_initialize_cli_logging): Add debugredirect command.
6853 * interps.c (current_interp_set_logging): Add debug_redirect
6854 parameter.
6855 * interps.h (set_logging): Add debug_redirect parameter.
6856 (current_interp_set_logging): Likewise.
6857 * mi/mi-common.h: Likewise.
6858 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6859
68602019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
6861 Tom Tromey <tromey@adacore.com>
6862
6863 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6864 directly.
6865 * cli/cli-interp.h (make_logging_output): Remove declaration.
6866 * cli/cli-logging.c (make_logging_output): Remove function.
6867 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6868 directly.
6869 * ui-file.c (tee_file::tee_file): Remove bools.
6870 (tee_file::~tee_file): Remove deletes.
6871 * ui-file.h (tee_file): Remove bools.
6872
26648588
JV
68732019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6874
6875 * mi/mi-cmds.h (mi_cmd_complete): New function.
6876 * mi/mi-main.c (mi_cmd_complete): Likewise.
6877 * mi/mi-cmds.c: Define new MI command -complete.
6878 * NEWS: Mention new -complete command.
6879
6e035501
JV
68802019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6881
6882 * completer.h (complete): New function.
6883 * completer.c (complete): Likewise.
6884 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6885 function defined in completer.h.
6886
7d0e2ece
JV
68872019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6888
e79be6e5 6889 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 6890
fb816e8b
TV
68912019-05-17 Tom de Vries <tdevries@suse.de>
6892
6893 PR gdb/24094
6894 * dwarf2read.c (struct cu_partial_die_info): New struct.
6895 (find_partial_die): Return cu_partial_die_info.
6896 (partial_die_parent_scope, guess_partial_die_structure_name)
6897 (partial_die_info::fixup): Handle new return type of find_partial_die.
6898
677052f2
SDJ
68992019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6900
a1726c38 6901 PR breakpoints/24541
677052f2
SDJ
6902 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6903 "std::string", simplifying the algorithm.
6904
f3da9116
SDJ
69052019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6906
6907 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6908 (stap_static_probe_ops::get_probes): Likewise.
6909
f1bb75ab
SDJ
69102019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6911
6912 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6913 '-')" and "else if".
6914 (stap_parse_single_operand): Join checks for
6915 "gdbarch_stap_parse_special_token_p" and
6916 "gdbarch_stap_parse_special_token" in the same "if" statement.
6917 Invert check when verifying for operation on register
6918 displacement.
6919
3ca58cde
SDJ
69202019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6921
6922 * stap-probe.c (stap_get_opcode): Update comment.
6923 (stap_get_expected_argument_type): Likewise.
6924 (handle_stap_probe): Likewise.
6925
af2d9bee
SDJ
69262019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6927
6928 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6929 return type to 'bool'. Adjust comment. Use 'bool' when
6930 appropriate.
6931 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6932 * stap-probe.c (stap_parse_argument_1): Likewise.
6933 (stap_is_operator): Likewise.
6934 (stap_is_generic_prefix): Likewise.
6935 (stap_is_register_prefix): Likewise.
6936 (stap_is_register_indirection_prefix): Likewise.
6937 (stap_is_integer_prefix): Likewise.
6938 (stap_generic_check_suffix): Likewise.
6939 (stap_check_integer_suffix): Likewise.
6940 (stap_check_register_suffix): Likewise.
6941 (stap_check_register_indirection_suffix): Likewise.
6942 (stap_parse_register_operand): Likewise.
6943 (stap_parse_single_operand): Likewise.
6944 (stap_parse_argument_1): Likewise.
6945 (stap_probe::get_argument_count): Likewise.
6946 (stap_is_operator): Likewise.
6947
61c9c421
TT
69482019-05-16 Tom Tromey <tromey@adacore.com>
6949
6950 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6951 keyword to foreach.
6952
9ddc1af1
SM
69532019-05-15 Simon Marchi <simon.marchi@efficios.com>
6954
6955 * linux-thread-db.c (try_thread_db_load_1): Change return type
6956 to bool.
6957 (try_thread_db_load): Likewise.
6958 (try_thread_db_load_from_pdir_1): Likewise.
6959 (try_thread_db_load_from_pdir): Likewise.
6960 (try_thread_db_load_from_sdir): Likewise.
6961 (try_thread_db_load_from_dir): Likewise.
6962 (thread_db_load_search): Likewise.
6963 (has_libpthread): Likewise.
6964 (thread_db_load): Likewise.
6965
7bede828
SDJ
69662019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6967
6968 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6969 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6970 NULL, and complain/return if that's the case.
6971
c5358db4
JD
69722019-05-15 John Darrington <john@darrington.wattle.id.au>
6973
6974 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6975 (advance, posn, abstract_read_memory): New functions.
6976 [struct mem_read_abstraction]: New struct.
6977 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6978
c408a94f
TT
69792019-05-14 Tom Tromey <tromey@adacore.com>
6980
6981 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6982 value is not lval_memory.
6983
e7bd7fba
TT
69842019-05-14 Tom Tromey <tromey@adacore.com>
6985
6986 * solib.c (info_sharedlibrary_command): Style the file name.
6987
a6d0f249
AH
69882019-05-14 Alan Hayward <alan.hayward@arm.com>
6989
6990 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6991 (aarch64_vnv_type): Likewise.
6992 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6993 * common/tdesc.c: Likewise.
6994 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6995 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6996 * features/aarch64-fpu.xml: Add ieee half view.
6997 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6998 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6999 * gdbtypes.h (struct builtin_type): Likewise.
7000 (struct objfile_type): Likewise.
7001
66b8bb74
SM
70022019-05-12 Paul Naert <paul.naert@polymtl.ca>
7003
7004 * language.c (language_sniff_from_mangled_name): Fix "langauge"
7005 typo.
7006 * location.h (string_to_event_location): Likewise.
7007
21c219fd
JB
70082019-05-11 Joel Brobecker <brobecker@adacore.com>
7009
7010 GDB 8.3 released.
7011
13674803
SM
70122019-05-10 Simon Marchi <simon.marchi@efficios.com>
7013
7014 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7015 New variable declaration.
7016 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7017 New variable.
7018 (print_one_breakpoint): Use ui_out::test_flags and new global
7019 variable to compute use_fixed_output.
7020 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7021 Remove.
7022 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7023 (mi_multi_location_breakpoint_output_fixed): Remove.
7024 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7025 new variable.
7026 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7027 fix_multi_location_breakpoint_output flag if version >= 3.
7028 * ui-out.h (enum ui_out_flag)
7029 <fix_multi_location_breakpoint_output>: New enumerator.
7030
a9eac7f9
SM
70312019-05-10 Simon Marchi <simon.marchi@efficios.com>
7032
7033 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7034
71bed2db
TT
70352019-05-10 Tom Tromey <tromey@adacore.com>
7036
7037 * ada-lang.c (catch_ada_completer): New function.
7038 (_initialize_ada_language): Use it.
7039
24c54127
TT
70402019-05-10 Tom Tromey <tromey@adacore.com>
7041
7042 * thread.c (print_thread_info): Make "requested_threads" const.
7043 * gdbthread.h (print_thread_info): Make "requested_threads"
7044 const.
7045 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7046 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7047
7a102139
TT
70482019-05-08 Tom Tromey <tom@tromey.com>
7049
7050 * gdbtypes.c (objfile_type_data): Change type.
7051 (objfile_type, _initialize_gdbtypes): Update.
7052
924d79e2
TT
70532019-05-08 Tom Tromey <tom@tromey.com>
7054
7055 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7056 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7057 (_initialize_dwarf2_frame): Update.
7058
4c58e337
TT
70592019-05-08 Tom Tromey <tom@tromey.com>
7060
7061 * objc-lang.c (objc_objfile_data): Change type.
7062 (find_methods): Update.
7063 (_initialize_objc_lang): Remove.
7064
d772d2ab
TT
70652019-05-08 Tom Tromey <tom@tromey.com>
7066
7067 * stabsread.c (rs6000_builtin_type_data): Change type.
7068 (rs6000_builtin_type, _initialize_stabsread): Update.
7069
d11d83f4
TT
70702019-05-08 Tom Tromey <tom@tromey.com>
7071
7072 * mips-tdep.c (mips_pdr_data): Remove.
7073 (_initialize_mips_tdep): Update.
7074
9a73f0ad
TT
70752019-05-08 Tom Tromey <tom@tromey.com>
7076
7077 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7078 (hppa_init_objfile_priv_data, read_unwind_info)
7079 (find_unwind_entry, _initialize_hppa_tdep): Update.
7080
8127a2fa
TT
70812019-05-08 Tom Tromey <tom@tromey.com>
7082
7083 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7084 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7085 on obstack.
7086 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7087
91d3055d
TT
70882019-05-08 Tom Tromey <tom@tromey.com>
7089
7090 * mdebugread.c (basic_type_data): Change type.
7091 (basic_type, _initialize_mdebugread): Update.
7092
31930bd3
TT
70932019-05-08 Tom Tromey <tom@tromey.com>
7094
7095 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7096
bdb3ed9e
TT
70972019-05-08 Tom Tromey <tom@tromey.com>
7098
7099 * nto-tdep.c (nto_inferior_data_reg): Change type.
7100 (nto_inferior_data): Update.
7101 (nto_inferior_data_cleanup, nto_new_inferior_data)
7102 (_initialize_nto_tdep): Remove.
7103 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7104
f37b313d
TT
71052019-05-08 Tom Tromey <tom@tromey.com>
7106
7107 * ada-lang.c (struct ada_inferior_data): Add initializers.
7108 (ada_inferior_data): Change type.
7109 (ada_inferior_data_cleanup): Remove.
7110 (get_ada_inferior_data, ada_inferior_exit)
7111 (struct ada_pspace_data): Add initializers, destructor.
7112 (ada_pspace_data_handle): Change type.
7113 (get_ada_pspace_data): Update.
7114 (ada_pspace_data_cleanup): Remove.
7115
24699405
TT
71162019-05-08 Tom Tromey <tom@tromey.com>
7117
7118 * coffread.c (struct coff_symfile_info): Add initializers.
7119 (coff_objfile_data_key): Move lower. Change type.
7120 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7121 Update.
7122 (coff_free_info): Remove.
7123
d4e05d2f
TT
71242019-05-08 Tom Tromey <tom@tromey.com>
7125
7126 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7127 (fbsd_pspace_data_handle): Move lower. Change type.
7128 (get_fbsd_pspace_data): Update.
7129 (fbsd_pspace_data_cleanup): Remove.
7130 (_initialize_fbsd_tdep): Update.
7131
14ef6690
TT
71322019-05-08 Tom Tromey <tom@tromey.com>
7133
7134 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7135 (get_ada_tasks_pspace_data): Update.
7136 (ada_tasks_pspace_data_cleanup): Remove.
7137 (_initialize_tasks): Update.
7138 (ada_tasks_inferior_data_handle): Change type.
7139 (get_ada_tasks_inferior_data): Update.
7140 (ada_tasks_inferior_data_cleanup): Remove.
7141 (struct ada_tasks_pspace_data): Add initializers.
7142
814cf43a
TT
71432019-05-08 Tom Tromey <tom@tromey.com>
7144
7145 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7146 * symfile-debug.c (debug_sym_get_probes): Change type.
7147 * stap-probe.c (handle_stap_probe):
7148 (stap_static_probe_ops::get_probes): Change type.
7149 * probe.h (class static_probe_ops) <get_probes>: Change type.
7150 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7151 (parse_probes_in_pspace): Update.
7152 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7153 Update.
7154 (any_static_probe_ops::get_probes): Change type.
7155 * elfread.c (elfread_data): New typedef.
7156 (probe_key): Change type.
7157 (elf_get_probes): Likewise. Update.
7158 (probe_key_free): Remove.
7159 (_initialize_elfread): Update.
7160 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7161 Change type.
7162 (dtrace_process_dof_probe, dtrace_process_dof)
7163 (dtrace_static_probe_ops::get_probe): Change type.
7164
02dc647e
TT
71652019-05-08 Tom Tromey <tom@tromey.com>
7166
7167 * xcoffread.c (struct xcoff_symfile_info): Rename from
7168 coff_symfile_info. Add initializers.
7169 (xcoff_objfile_data_key): Move lower. Change type.
7170 (XCOFF_DATA): Rewrite.
7171 (xcoff_free_info): Remove.
7172 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7173 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7174 (xcoff_initial_scan): Update.
7175
09232438
TT
71762019-05-08 Tom Tromey <tom@tromey.com>
7177
7178 * solib-svr4.c (struct svr4_info): Add initializers and
7179 destructor.
7180 <probes_table>: Now an htab_up.
7181 (solib_svr4_pspace_data): Change type.
7182 (free_probes_table): Simplify.
7183 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7184 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7185 (probes_table_remove_objfile_probes, register_solib_event_probe)
7186 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7187 (_initialize_svr4_solib): Update.
7188
7b4a314f
TT
71892019-05-08 Tom Tromey <tom@tromey.com>
7190
7191 * remote.c (remote_pspace_data): Change type.
7192 (remote_pspace_data_cleanup): Remove.
7193 (get_remote_exec_file, set_pspace_remote_exec_file)
7194 (_initialize_remote): Update.
7195
51d3063a
TT
71962019-05-08 Tom Tromey <tom@tromey.com>
7197
7198 * breakpoint.c (breakpoint_objfile_key): Change type.
7199 (get_breakpoint_objfile_data): Update.
7200 (free_breakpoint_objfile_data): Remove.
7201 (_initialize_breakpoint): Update.
7202
89fb8848
TT
72032019-05-08 Tom Tromey <tom@tromey.com>
7204
7205 * linux-tdep.c (struct linux_info): Add initializers.
7206 (linux_inferior_data): Move. Change type.
7207 (invalidate_linux_cache_inf): Update.
7208 (linux_inferior_data_cleanup): Remove.
7209 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7210
e9b89e2d
TT
72112019-05-08 Tom Tromey <tom@tromey.com>
7212
7213 * auxv.c (auxv_inferior_data): Move. Change type.
7214 (auxv_inferior_data_cleanup): Remove.
7215 (invalidate_auxv_cache_inf): Rewrite.
7216 (get_auxv_inferior_data, _initialize_auxv): Update.
7217
8c42777c
TT
72182019-05-08 Tom Tromey <tom@tromey.com>
7219
7220 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7221 (symfile_debug_objfile_data_key): Change type.
7222 (symfile_debug_installed, debug_qf_has_symbols)
7223 (debug_qf_find_last_source_symtab)
7224 (debug_qf_forget_cached_source_info)
7225 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7226 (debug_qf_print_stats, debug_qf_dump)
7227 (debug_qf_expand_symtabs_for_function)
7228 (debug_qf_expand_all_symtabs)
7229 (debug_qf_expand_symtabs_with_fullname)
7230 (debug_qf_map_matching_symbols)
7231 (debug_qf_expand_symtabs_matching)
7232 (debug_qf_find_pc_sect_compunit_symtab)
7233 (debug_qf_map_symbol_filenames)
7234 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7235 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7236 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7237 (debug_sym_read_linetable, debug_sym_relocate): Update.
7238 (symfile_debug_free_objfile): Remove.
7239 (install_symfile_debug_logging, _initialize_symfile_debug):
7240 Update.
7241
5bfd760d
TT
72422019-05-08 Tom Tromey <tom@tromey.com>
7243
7244 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7245 allocate_on_obstack.
7246 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7247 (get_dwarf2_per_objfile): Update.
7248 (set_dwarf2_per_objfile): Remove.
7249 (dwarf2_has_info, dwarf2_get_section_info): Update.
7250 (dwarf2_free_objfile): Remove.
7251 (_initialize_dwarf2_read): Update.
7252
e85e19b4
TT
72532019-05-08 Tom Tromey <tom@tromey.com>
7254
7255 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7256 initializers.
7257 <unsupported_script_warning_printed,
7258 script_not_found_warning_printed>: Now bool.
7259 (auto_load_pspace_data): Change type.
7260 (~auto_load_pspace_info): Rename from
7261 auto_load_pspace_data_cleanup.
7262 (get_auto_load_pspace_data, init_loaded_scripts_info)
7263 (clear_section_scripts, maybe_print_unsupported_script_warning)
7264 (maybe_print_script_not_found_warning, _initialize_auto_load):
7265 Update.
7266
f6aa7436
TT
72672019-05-08 Tom Tromey <tom@tromey.com>
7268
7269 * objfiles.c (objfile_pspace_info): Add destructor and
7270 initializers.
7271 (objfiles_pspace_data): Change type.
7272 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7273 (get_objfile_pspace_data): Update.
7274 (objfiles_bfd_data): Change type.
7275 (get_objfile_bfd_data): Update.
7276 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7277
6ae614f6
TT
72782019-05-08 Tom Tromey <tom@tromey.com>
7279
7280 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7281 Change type.
7282 (get_catch_syscall_inferior_data): Update.
7283 (catch_syscall_inferior_data_cleanup): Remove.
7284 (_initialize_break_catch_syscall): Update.
7285
6509b8eb
TT
72862019-05-08 Tom Tromey <tom@tromey.com>
7287
7288 * inflow.c (struct terminal_info): Add destructor and
7289 initializers.
7290 (inflow_inferior_data): Change type.
7291 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7292 (get_inflow_inferior_data, inflow_inferior_exit)
7293 (swap_terminal_info, _initialize_inflow): Update.
7294
35632941
TT
72952019-05-08 Tom Tromey <tom@tromey.com>
7296
7297 * target-dcache.c (target_dcache_cleanup): Remove.
7298 (target_dcache_aspace_key): Change type.
7299 (target_dcache_init_p, target_dcache_invalidate)
7300 (target_dcache_get, target_dcache_get_or_init)
7301 (_initialize_target_dcache): Update.
7302 * dcache.h (struct dcache_deleter): New.
7303
3017b94d
TT
73042019-05-08 Tom Tromey <tom@tromey.com>
7305
7306 * symtab.c (struct symbol_cache): Add destructor and
7307 initializers.
7308 (symbol_cache_key): Move. Change type.
7309 (make_symbol_cache, free_symbol_cache): Remove.
7310 (get_symbol_cache): Update.
7311 (symbol_cache_cleanup): Remove.
7312 (ALL_PSPACES, symbol_cache_flush)
7313 (maintenance_print_symbol_cache)
7314 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7315 Update.
7316
a32ad8c5
TT
73172019-05-08 Tom Tromey <tom@tromey.com>
7318
7319 * symtab.c (struct main_info): Add destructor and initializers.
7320 (main_progspace_key): Move. Change type.
7321 (get_main_info): Update.
7322 (main_info_cleanup): Remove.
7323 (_initialize_symtab): Update.
7324
5f6e90a0
TT
73252019-05-08 Tom Tromey <tom@tromey.com>
7326
7327 * registry.h (DECLARE_REGISTRY): Define the _key class.
7328
1bd0c6e4
AB
73292019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7330
7331 * NEWS: Merge two 'New commands' sections.
7332
2228ef77
XR
73332019-05-08 Joel Brobecker <brobecker@adacore.com>
7334
7335 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7336 parameter and use Ada language definition instead.
7337 (ada_val_print_ptr): Remove unused language parameter.
7338 (ada_val_print_num): Remove language parameter and use Ada language
7339 definition instead.
7340 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7341 parameter.
7342 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7343 parameter and use Ada language definition instead.
7344 (ada_val_print_1): Update all ada_val_print_xxx calls.
7345 Remove language parameter.
7346 (ada_val_print): Update ada_val_print_1 call.
7347
60fcc1c3
TT
73482019-05-08 Tom Tromey <tromey@adacore.com>
7349
7350 * remote.c (remote_hw_watchpoint_limit)
7351 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7352 Now static.
7353
ed2b7c17
TT
73542019-05-08 Tom Tromey <tromey@adacore.com>
7355
7356 * maint.c (_initialize_maint_cmds): Move initialization code to
7357 remote.c.
7358 (watchdog, show_watchdog): Move to remote.c.
7359 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7360 "watchdog" static.
7361 (_initialize_remote): Move initialization code from maint.c.
7362 * defs.h (watchdog): Don't declare.
7363
b0be6c91
TT
73642019-05-08 Tom Tromey <tromey@adacore.com>
7365
7366 * tui/tui-interp.c: Include main.h.
7367 * interps.c: Include main.h.
7368 * main.h (interpreter_p): Declare.
7369 * defs.h (interpreter_p): Don't declare.
7370
587ee17b
TT
73712019-05-08 Tom Tromey <tromey@adacore.com>
7372
7373 * dwarf2loc.c: Include dwarf2read.h.
7374 * defs.h (read_unsigned_leb128): Don't declare.
7375 * dwarf2read.h (read_unsigned_leb128): Declare.
7376
ca1df239
TT
73772019-05-08 Tom Tromey <tromey@adacore.com>
7378
7379 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7380 method.
7381
99f20f08
TT
73822019-05-08 Tom Tromey <tromey@adacore.com>
7383
7384 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7385 when no wrap column is set.
7386
80e55b13
TT
73872019-05-08 Tom Tromey <tromey@adacore.com>
7388
7389 * c-lang.c (c_get_string): Handle non-C-style arrays.
7390
9d3421af
TT
73912019-05-08 Tom Tromey <tromey@adacore.com>
7392
7393 * typeprint.c (print_offset_data::update): Print the bit offset,
7394 not the number of bits remaining.
7395
844333e2
TT
73962019-05-08 Tom Tromey <tromey@adacore.com>
7397
7398 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7399 padding at end of comment.
7400
988915ee
TT
74012019-05-08 Tom Tromey <tromey@adacore.com>
7402
7403 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7404 Compare main types.
7405
26bfd823
TT
74062019-05-06 Tom Tromey <tom@tromey.com>
7407
7408 * common/scoped_mmap.c: Include common-defs.h.
7409 * common/scoped_mmap.h: Don't include config.h.
7410
89055eaa
TT
74112019-05-04 Tom Tromey <tom@tromey.com>
7412
7413 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7414 (struct aarch64_call_info): Add initializers.
7415 <si>: Now a std::vector.
7416 (pass_on_stack, aarch64_push_dummy_call): Update.
7417
5da01df5
TT
74182019-05-04 Simon Marchi <simon.marchi@efficios.com>
7419 Tom Tromey <tom@tromey.com>
7420
7421 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7422 (ppc_threads): Now a std::vector. Now static.
7423 (hwdebug_find_thread_points_by_tid)
7424 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7425 Update.
7426
fbdf05a1
TT
74272019-05-04 Tom Tromey <tom@tromey.com>
7428
7429 * arc-tdep.c (arc_tdesc_init): Return bool.
7430
06d16ec9
TT
74312019-05-04 Tom Tromey <tom@tromey.com>
7432
7433 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7434 Use gdb_assert_not_reached.
7435
9c056022
TT
74362019-05-04 Tom Tromey <tom@tromey.com>
7437
7438 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7439 "false".
7440
fa9c2a59
TT
74412019-05-04 Tom Tromey <tom@tromey.com>
7442
7443 * arc-tdep.c (arc_tdesc_init): Use bool.
7444
e2eb806a
TT
74452019-05-04 Tom Tromey <tom@tromey.com>
7446
7447 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7448
6fe87677
TT
74492019-05-04 Tom Tromey <tom@tromey.com>
7450
7451 * cli/cli-cmds.c (valid_command_p): Return bool.
7452
7f008c9e
TT
74532019-05-04 Tom Tromey <tom@tromey.com>
7454
7455 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7456 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7457
b6484282
RT
74582019-05-04 Raul Tambre <raul@tambre.ee>
7459
7460 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7461 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7462 operator for comparison.
7463
af97b416
TT
74642019-05-04 Tom Tromey <tom@tromey.com>
7465
7466 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7467 (lookup_partial_symbol, print_partial_symbols)
7468 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7469 (psymbol_compare): Update.
7470 (add_psymbol_to_bcache): Clear the entire psymbol.
7471 (maintenance_check_psymtabs): Update.
7472 * psympriv.h (struct partial_symbol): Don't derive from
7473 general_symbol_info.
7474 <obj_section, unrelocated_address, address,
7475 set_unrelocated_address>: Update.
7476 <ginfo>: New member.
7477 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7478 (debug_names::write_psymbols): Update.
7479
9d6d4be8
TV
74802019-05-04 Tom de Vries <tdevries@suse.de>
7481
7482 * contrib/cc-with-tweaks.sh: Support -n arg.
7483
66452beb
PW
74842019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7485
7486 * corelow.c (core_target::detach): Ensure frame cache and
7487 register caches are cleared.
7488 inferior.c (exit_inferior_1): Likewise.
7489
bde09ab7
TT
74902019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7491 Tom Tromey <tom@tromey.com>
7492
7493 * dictionary.c (collate_pending_symbols_by_language): Remove
7494 "struct" from foreach.
7495 * symtab.c (lookup_global_symbol_from_objfile)
7496 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7497 foreach.
7498 * ser-tcp.c (net_open): Remove "struct" from foreach.
7499 * objfiles.c (objfile_relocate, objfile_rebase)
7500 (objfile_has_symbols): Remove "struct" from foreach.
7501 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7502 from foreach.
7503 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7504 foreach.
7505 * darwin-nat.c (thread_info_from_private_thread_info): Remove
7506 "struct" from foreach.
7507 * ada-lang.c (create_excep_cond_exprs)
7508 (ada_exception_catchpoint_cond_string): Remove "struct" from
7509 foreach.
7510
222a8d25
TT
75112019-05-03 Tom Tromey <tromey@adacore.com>
7512
7513 * ada-exp.y (convert_char_literal): Check suffix of each
7514 enumerator.
7515
fcd60b84
DP
75162019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
7517
7518 PR ada/21406:
7519 * ada-exp.y (yywrap): Don't define.
7520 * ada-lex.l (%option): Add noyywrap
7521 (yywrap): Remove.
7522
5f2459c2
EZ
75232019-05-03 Eli Zaretskii <eliz@gnu.org>
7524
353ea2d1
EZ
7525 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7526 _WIN32_WINNT to the XP level, unless already defined to a higher
7527 level.
7528
7529 * unittests/parse-connection-spec-selftests.c:
7530 * ser-tcp.c:
7531 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
7532 override.
7533
5f2459c2
EZ
7534 * symfile.c (find_separate_debug_file): Remove colon from the
7535 drive spec of DOS/Windows file names of the target, so that the
7536 file name produced from DEBUGDIR and the target's directory will
7537 be valid on DOS/Windows systems.
7538
80062eb9
AB
75392019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
7540
7541 * rust-lang.c (val_print_struct): Handle printing structures
7542 containing strings.
7543
b8c05e85
TT
75442019-05-02 Tom Tromey <tromey@adacore.com>
7545
7546 * valarith.c (_initialize_valarith): Remove.
7547
4504bbde
TT
75482019-05-01 Tom Tromey <tromey@adacore.com>
7549
7550 * ada-lang.c (ada_value_primitive_field): Treat more fields as
7551 bitfields.
7552
d48e62f4
TT
75532019-05-01 Tom Tromey <tromey@adacore.com>
7554
7555 * ada-lang.c (ada_value_assign): Correctly compute starting offset
7556 for big-endian copies.
7557
15f18d14
AT
75582019-04-30 Ali Tamur <tamur@google.com>
7559 * gdb/dwarf2read.c (read_3_bytes): New declaration.
7560 (read_attribute_value): Added DW_FORM_strx1-4 cases.
7561 (read_3_bytes): New function.
7562
ab4ee614
JB
75632019-04-30 Joel Brobecker <brobecker@adacore.com>
7564
7565 * windows-nat.c (main_thread_id): Delete.
7566 (handle_output_debug_string): Replace main_thread_id by
7567 current_event.dwThreadId.
7568 (fake_create_process): Likewise.
7569 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7570 Do not set main_thread_id.
7571 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7572 current_event.dwThreadId.
7573 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7574
8ed5b76e
JB
75752019-04-30 Joel Brobecker <brobecker@adacore.com>
7576
7577 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7578 Use current_event.dwThreadId instead of main_thread_id.
7579
2ff0a947
TT
75802019-04-30 Tom Tromey <tromey@adacore.com>
7581
7582 * ada-lang.c (ada_lookup_simple_minsyms): New function.
7583 (create_excep_cond_exprs): Iterate over program spaces.
7584 (ada_exception_catchpoint_cond_string): Examine all minimal
7585 symbols for exception types.
7586
a776957c
TT
75872019-04-30 Tom Tromey <tromey@adacore.com>
7588
7589 PR c++/24470:
7590 * dwarf2read.c (process_structure_scope): Handle case where type
7591 has template parameters but no symbol was created.
7592
bc68014d
AB
75932019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7594 Chris January <chris.january@arm.com>
7595
7596 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7597 qualifier.
7598 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7599
f1fdc960
AB
76002019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7601
7602 * f-typeprint.c (f_print_type): Update rules for printing
7603 whitespace.
7604 (f_type_print_varspec_suffix): Likewise.
7605
bf7a4de1
AB
76062019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7607 Chris January <chris.january@arm.com>
7608
7609 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7610 function arguments.
7611
bbe75b9d
AB
76122019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7613
7614 * f-lang.c (build_fortran_types): Change name of void type to
7615 lower case.
7616 * f-typeprint.c (f_type_print_base): Print the name of the void
7617 type, rather than a fixed string.
7618 * f-valprint.c (f_decorations): Use lower case void string.
7619
1db455a7
AB
76202019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7621 Chris January <chris.january@arm.com>
7622
7623 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7624 types for Fortran.
7625
b6d03bb2
AB
76262019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7627 Chris January <chris.january@arm.com>
7628 David Lecomber <david.lecomber@arm.com>
7629
7630 * f-exp.y (BINOP_INTRINSIC): New token.
7631 (exp): New parser rule handling BINOP_INTRINSIC.
7632 (f77_keywords): Add new builtin procedures.
7633 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7634 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7635 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7636 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7637 (print_unop_subexp_f): New function.
7638 (print_binop_subexp_f): New function.
7639 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7640 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7641 (dump_subexp_body_f): Likewise.
7642 (operator_check_f): Likewise.
7643 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7644 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7645
83228e93
AB
76462019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7647
7648 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7649 UNOP_KIND.
7650 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7651 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7652 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7653 (operator_length_f): New fuction.
7654 (print_subexp_f): New function.
7655 (op_name_f): New function.
7656 (dump_subexp_body_f): New function.
7657 (operator_check_f): New function.
7658 (exp_descriptor_f): Replace standard expression handling functions
7659 with new functions.
7660 * gdb/fortran-operator.def: New file.
7661 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7662 * gdb/std-operator.def: Remove UNOP_KIND.
7663
6fdcd7cc
AB
76642019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7665
7666 * std-operator.def: Remove unbalanced, stray double quote
7667 character.
7668
2e62ab40
AB
76692019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7670 Chris January <chris.january@arm.com>
7671 Daniel Everett <daniel.everett@arm.com>
7672 Nick Forrington <nick.forrington@arm.com>
7673 Richard Bunt <richard.bunt@arm.com>
7674
7675 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7676 of depth when printing anonymous structs or unions.
7677 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7678 Don't print either the top-level value, or the children if the
7679 max-depth is exceeded.
7680 (ppscm_print_children): When printing the key of a map, allow one
7681 extra level of depth.
7682 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7683 print either the top-level value, or the children if the max-depth
7684 is exceeded.
7685 (print_children): When printing the key of a map, allow one extra
7686 level of depth.
7687 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7688 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7689 (user_print_options): Initialise max_depth field.
7690 (val_print_scalar_or_string_type_p): New function.
7691 (val_print): Check to see if the max depth has been reached.
7692 (val_print_check_max_depth): Define new function.
7693 (show_print_max_depth): New function.
7694 (_initialize_valprint): Add 'print max-depth' option.
7695 * valprint.h (struct value_print_options) <max_depth>: New field.
7696 (val_print_check_max_depth): Declare new function.
7697 * NEWS: Document new feature.
7698
4be290b2
AB
76992019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7700
7701 * ada-lang.c (ada_language_defn): Initialise new field.
7702 * c-lang.c (c_is_string_type_p): New function.
7703 (c_language_defn): Initialise new field.
7704 (cplus_language_defn): Initialise new field.
7705 (asm_language_defn): Initialise new field.
7706 (minimal_language_defn): Initialise new field.
7707 * c-lang.h (c_is_string_type_p): Declare new function.
7708 * d-lang.c (d_language_defn): Initialise new field.
7709 * f-lang.c (f_is_string_type_p): New function.
7710 (f_language_defn): Initialise new field.
7711 * go-lang.c (go_is_string_type_p): New function.
7712 (go_language_defn): Initialise new field.
7713 * language.c (default_is_string_type_p): New function.
7714 (unknown_language_defn): Initialise new field.
7715 (auto_language_defn): Initialise new field.
7716 * language.h (struct language_defn) <la_is_string_type_p>: New
7717 member variable.
7718 (default_is_string_type_p): Declare new function.
7719 * m2-lang.c (m2_language_defn): Initialise new field.
7720 * objc-lang.c (objc_language_defn): Initialise new field.
7721 * opencl-lang.c (opencl_language_defn): Initialise new field.
7722 * p-lang.c (pascal_is_string_type_p): New function.
7723 (pascal_language_defn): Initialise new field.
7724 * rust-lang.c (rust_is_string_type_p): New function.
7725 (rust_language_defn): Initialise new field.
7726
721b08c6
AB
77272019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7728
7729 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7730 New field.
7731 * ada-lang.c (ada_language_defn): Initialise new field.
7732 * c-lang.c (c_language_defn): Likewise.
7733 (cplus_language_defn): Likewise.
7734 (asm_language_defn): Likewise.
7735 (minimal_language_defn): Likewise.
7736 * d-lang.c (d_language_defn): Likewise.
7737 * f-lang.c (f_language_defn): Likewise.
7738 * go-lang.c (go_language_defn): Likewise.
7739 * language.c (unknown_language_defn): Likewise.
7740 (auto_language_defn): Likewise.
7741 * m2-lang.c (m2_language_defn): Likewise.
7742 * objc-lang.c (objc_language_defn): Likewise.
7743 * opencl-lang.c (opencl_language_defn): Likewise.
7744 * p-lang.c (pascal_language_defn): Likewise.
7745 * rust-lang.c (rust_language_defn): Likewise.
7746
fc913e53
AB
77472019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7748
7749 * ada-lang.c (ada_is_character_type): Change return type to bool.
7750 (ada_is_string_type): Likewise.
7751 * ada-lang.h (ada_is_character_type): Update declaration
7752 (ada_is_string_type): Likewise.
7753
fa731fa0
PW
77542019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7755
7756 Support style in 'frame|thread apply'
7757
7758 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7759 * record.c (record_start, record_stop): Update callers of
7760 execute_command_to_string with false.
7761 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7762 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7763 methods.
7764 (class string_file): New constructor with term_out parameter.
7765 Override methods term_out and can_emit_style_escape. New member
7766 term_out.
7767 (class stdio_file): Override can_emit_style_escape.
7768 (class tee_file): Override term_out and can_emit_style_escape.
7769 * utils.h (can_emit_style_escape): Remove.
7770 * utils.c (can_emit_style_escape): Likewise.
7771 Update all callers of can_emit_style_escape (SOMESTREAM) to
7772 SOMESTREAM->can_emit_style_escape.
7773 * source-cache.c (source_cache::get_source_lines): Likewise.
7774 * stack.c (frame_apply_command_count): Call execute_command_to_string
7775 passing the term_out characteristic of the current gdb_stdout.
7776 * thread.c (thr_try_catch_cmd): Likewise.
7777 * top.c (execute_command_to_string): pass term_out parameter
7778 to construct the string_file for the command output.
7779 * ui-file.c (term_cli_styling): New function (most code moved
7780 from utils.c can_emit_style_escape).
7781 (string_file::string_file, string_file::can_emit_style_escape,
7782 stdio_file::can_emit_style_escape, tee_file::term_out,
7783 tee_file::can_emit_style_escape): New functions.
7784
136afab8
PW
77852019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7786
7787 * NEWS: Mention the new set|show may-call-functions.
7788 * infcall.c (may_call_functions_p): New variable.
7789 (show_may_call_functions_p): New function.
7790 (call_function_by_hand_dummy): Throws an error if not
7791 may-call-functions.
7792 (_initialize_infcall): Call add_setshow_boolean_cmd for
7793 may-call-functions.
7794
725cbb63
KS
77952019-04-25 Keith Seitz <keiths@redhat.com>
7796
7797 PR c++/24367
7798 * cp-support.c (inspect_type): Don't attempt substitutions
7799 of symbol with the same name.
7800
3d1cbb78
TT
78012019-04-25 Tom Tromey <tromey@adacore.com>
7802
7803 PR gdb/24475:
7804 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7805 static.
7806
94aeb44b
TT
78072019-04-25 Tom Tromey <tromey@adacore.com>
7808
7809 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7810 rvalue reference.
7811 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7812 (gdb_xml_parser::parse): Use std::move.
7813 * python/python-internal.h (gdbpy_convert_exception): Take a const
7814 reference.
7815 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7816 std::move.
7817 * python/py-utils.c (gdbpy_convert_exception): Take a const
7818 reference.
7819 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7820 Use std::move.
7821 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7822 Use std::move.
7823 * mi/mi-main.c (mi_print_exception): Take a const reference.
7824 * main.c (handle_command_errors): Take a const reference.
7825 * linespec.c (parse_linespec): Use std::move.
7826 * infcall.c (run_inferior_call): Use std::move.
7827 (call_function_by_hand_dummy): Use std::move.
7828 * exec.c (try_open_exec_file): Use std::move.
7829 * exceptions.h (exception_print, exception_fprintf)
7830 (exception_print_same): Update.
7831 * exceptions.c (print_exception, exception_print)
7832 (exception_fprintf, exception_print_same): Change parameters to
7833 const reference.
7834 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7835 * common/new-op.c: Use std::move.
7836 * common/common-exceptions.h (struct gdb_exception): Add move
7837 constructor.
7838 (struct gdb_exception_error, struct gdb_exception_quit, struct
7839 gdb_quit_bad_alloc): Change constructor to move constructor.
7840 (throw_exception): Change parameter to rvalue reference.
7841 * common/common-exceptions.c (throw_exception): Take rvalue
7842 reference.
7843 * cli/cli-interp.c (safe_execute_command): Use std::move.
7844 * breakpoint.c (insert_bp_location, location_to_sals): Use
7845 std::move.
7846
680d7fd5
TT
78472019-04-25 Tom Tromey <tromey@adacore.com>
7848
7849 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7850 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7851 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7852 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7853 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7854 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7855 guile/scm-value.c: Use unpack.
7856 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7857 gdbscm_gdb_exception.
7858 (gdbscm_throw_gdb_exception): Likewise.
7859 (struct gdbscm_gdb_exception): New.
7860 (unpack): New function.
7861 (gdbscm_wrap): Use unpack.
7862
c6fdd8b2
TT
78632019-04-25 Tom Tromey <tromey@adacore.com>
7864
7865 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7866 (gdb_rl_callback_handler): Use std::move.
7867 * common/common-exceptions.h (struct gdb_exception): Add move
7868 assignment operator.
7869 (throw_exception_sjlj): Change "exception" to const reference.
7870 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7871 (throw_exception_sjlj): Change "exception" to const reference.
7872
cc06b668
TT
78732019-04-25 Tom Tromey <tromey@adacore.com>
7874
7875 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7876 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7877 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7878 Update.
7879 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7880 Update.
7881 * mi/mi-interp.c (mi_interp::exec): Update.
7882 * linespec.c (parse_linespec): Update.
7883 * infcall.c (run_inferior_call): Update.
7884 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7885 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7886 (gdbscm_lookup_global_symbol): Update.
7887 * guile/scm-param.c (gdbscm_parameter_value): Update.
7888 * guile/scm-frame.c (gdbscm_frame_read_register)
7889 (gdbscm_frame_read_var): Update.
7890 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7891 * exec.c (try_open_exec_file): Update.
7892 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7893 (gdb_rl_callback_handler): Update.
7894 * common/common-exceptions.h (exception_none): Don't declare.
7895 * common/common-exceptions.c (exception_none): Don't define.
7896 (struct catcher) <exception>: Update.
7897 * cli/cli-interp.c (safe_execute_command): Update.
7898 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7899
cf532bd1
AT
79002019-04-25 Ali Tamur <tamur@google.com>
7901
7902 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7903 (read_attribute_value): Likewise.
7904 (dwarf2_read_addr_index): Update comment.
7905 (read_str_index): Add DW_FORM_strx.
7906 (dwarf2_string_attr): Likewise.
7907 (dwarf2_const_value_attr): Likewise.
7908 (dump_die_shallow): Likewise.
7909 (dwarf2_fetch_constant_bytes): Likewise.
7910 (skip_form_bytes): Likewise.
7911 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7912
82433e3e
SDJ
79132019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7914
7915 PR corefiles/11608
7916 PR corefiles/18187
7917 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7918 OFFSET. Verify if current mapping contains an ELF header.
7919 (linux_find_memory_regions_full): Adjust call to
7920 dump_mapping_p.
7921
723adb65
SL
79222019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7923 Kang Li <kanglictf@gmail.com>
7924
7925 PR gdb/21600
7926
7927 * dwarf2-frame.c (read_initial_length): Be consistent about using
7928 unsigned representation of length.
7929 (decode_frame_entry_1): Likewise. Check for wraparound of
7930 end pointer as well as buffer overflow.
7931
596179f7
SDJ
79322019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7933
7934 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7935 "vq".
7936
a59240a4
TT
79372019-04-24 Tom Tromey <tromey@adacore.com>
7938
7939 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7940
f872fdbb
AB
79412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7942
7943 * s12z-tdep.c (s12z_unwind_pc): Delete.
7944 (s12z_unwind_sp): Delete.
7945 (s12z_gdbarch_init): Don't register deleted functions with
7946 gdbarch.
7947
b614e6f3
AB
79482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7949
7950 * rl78-tdep.c (rl78_unwind_sp): Delete.
7951 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7952
14faed38
AB
79532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7954
7955 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7956 (xstormy16_unwind_pc): Delete.
7957 (xstormy16_dummy_id): Delete.
7958 (xstormy16_gdbarch_init): Don't register deleted functions with
7959 gdbarch.
7960
541aad8a
AB
79612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7962
7963 * vax-tdep.c (vax_unwind_pc): Delete.
7964 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7965
29222070
AB
79662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7967
7968 * v850-tdep.c (v850_unwind_sp): Delete.
7969 (v850_unwind_pc): Delete.
7970 (v850_dummy_id): Delete.
7971 (v850_gdbarch_init): Don't register deleted functions with
7972 gdbarch.
7973
0f534d76
AB
79742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7975
7976 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7977 (tilegx_unwind_pc): Delete.
7978 (tilegx_unwind_dummy_id): Delete.
7979 (tilegx_gdbarch_init): Don't register deleted functions with
7980 gdbarch.
7981
1ba7b7f9
AB
79822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7983
7984 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7985 (tic6x_dummy_id): Delete.
7986 (tic6x_gdbarch_init): Don't register deleted functions with
7987 gdbarch.
7988
d31f262c
AB
79892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7990
7991 * sparc-tdep.c (sparc_unwind_pc): Delete.
7992 (sparc32_gdbarch_init): Don't register deleted function with
7993 gdbarch.
7994
6d14d64d
AB
79952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7996
7997 * sh-tdep.c (sh_unwind_sp): Delete.
7998 (sh_unwind_pc): Delete.
7999 (sh_dummy_id): Delete.
8000 (sh_gdbarch_init): Don't register deleted functions with
8001 gdbarch.
8002
a40dde9d
AB
80032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8004
8005 * score-tdep.c (score_unwind_sp): Delete.
8006 (score_unwind_pc): Delete.
8007 (score_dummy_id): Delete.
8008 (score_gdbarch_init): Don't register deleted functions with
8009 gdbarch.
8010
47c47d69
AB
80112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8012
8013 * rx-tdep.c (rx_unwind_pc): Delete.
8014 (rx_unwind_sp): Delete.
8015 (rx_dummy_id): Delete.
8016 (rx_gdbarch_init): Don't register deleted functions with
8017 gdbarch. Update comment.
8018
833a4480
AB
80192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8020
8021 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8022 (rs6000_dummy_id): Delete.
8023 (rs6000_gdbarch_init): Don't register deleted functions with
8024 gdbarch.
8025
3f2cef49
AB
80262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8027
8028 * or1k-tdep.c (or1k_dummy_id): Delete.
8029 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8030
96acf884
AB
80312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8032
8033 * nios2-tdep.c (nios2_dummy_id): Delete.
8034 (nios2_unwind_sp): Delete.
8035 (nios2_gdbarch_init): Don't register deleted functions with
8036 gdbarch.
8037
ca0ab0aa
AB
80382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8039
8040 * nds32-tdep.c (nds32_dummy_id): Delete.
8041 (nds32_unwind_pc): Delete.
8042 (nds32_unwind_sp): Delete.
8043 (nds32_gdbarch_init): Don't register deleted functions with
8044 gdbarch.
8045
c8259044
AB
80462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8047
8048 * msp430-tdep.c (msp430_unwind_pc): Delete.
8049 (msp430_unwind_sp): Delete.
8050 (msp430_dummy_id): Delete.
8051 (msp430_gdbarch_init): Don't register deleted functions with
8052 gdbarch.
8053
27f113c8
AB
80542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8055
8056 * moxie-tdep.c (moxie_unwind_sp): Delete.
8057 (moxie_unwind_pc): Delete.
8058 (moxie_dummy_id): Delete.
8059 (moxie_gdbarch_init): Don't register deleted functions with
8060 gdbarch.
8061
aee6c3cd
AB
80622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8063
8064 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8065 (mn10300_unwind_pc): Delete.
8066 (mn10300_unwind_sp): Delete.
8067 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8068 mn10300_unwind_sp.
8069 (mn10300_frame_unwind_init): Don't register deleted functions with
8070 gdbarch.
8071
8e2b5aea
AB
80722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8073
8074 * mep-tdep.c (mep_unwind_pc): Delete.
8075 (mep_unwind_sp): Delete.
8076 (mep_dummy_id): Delete.
8077 (mep_gdbarch_init): Don't register deleted functions with
8078 gdbarch.
8079
43cf3ede
AB
80802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8081
8082 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8083 (m68hc11_unwind_sp): Delete.
8084 (m68hc11_gdbarch_init): Don't register deleted functions with
8085 gdbarch.
8086
5e79b7bb
AB
80872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8088
8089 * m32r-tdep.c (m32r_unwind_sp): Delete.
8090 (m32r_unwind_pc): Delete.
8091 (m32r_dummy_id): Delete.
8092 (m32r_gdbarch_init): Don't register deleted functions with
8093 gdbarch.
8094
89b268d8
AB
80952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8096
8097 * m32c-tdep.c (m32c_unwind_pc): Delete.
8098 (m32c_unwind_sp): Delete.
8099 (m32c_dummy_id): Delete.
8100 (m32c_gdbarch_init): Don't register deleted functions with
8101 gdbarch.
8102
946c28d2
AB
81032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8104
8105 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8106 (lm32_unwind_pc): Delete.
8107 (lm32_dummy_id): Delete.
8108 (lm32_gdbarch_init): Don't register deleted functions with
8109 gdbarch.
8110
bf12844a
AB
81112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8112
8113 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8114 (iq2000_unwind_pc): Delete.
8115 (iq2000_dummy_id): Delete.
8116 (iq2000_gdbarch_init): Don't register deleted functions with
8117 gdbarch.
8118
ecbc06d2
AB
81192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8120
8121 * nds32-tdep.c (nds32_type_align): Delete.
8122 (nds32_push_dummy_call): Use type_align instead.
8123
030197b4
AB
81242019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8125
8126 * arm-tdep.c (arm_type_align): Only handle vector override case.
8127 (arm_push_dummy_call): Use type_align.
8128 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8129
b907456c
AB
81302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8131
8132 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8133 case.
8134 (pass_on_stack): Use type_align.
8135 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8136 function.
8137
9e97ba43
TT
81382019-04-23 Tom Tromey <tromey@adacore.com>
8139
8140 * dwarf2read.c (line_header::file_name_at): Remove unused
8141 overload.
8142
6892f601
TV
81432019-04-23 Tom de Vries <tdevries@suse.de>
8144
8145 PR gdb/24438
8146 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8147 invocation.
8148
336d760d
AT
8149
81502019-03-27 Ali Tamur <tamur@google.com>
8151
8152 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8153 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8154 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8155 (dwarf_expr_context::get_addr_index): Likewise
8156 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8157 (symbol_needs_eval_context::get_addr_index): Likewise
8158 (disassemble_dwarf_expression): Add DW_OP_addrx
8159 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8160 (read_cutu_die_from_dwo): Update comment
8161 (skip_one_die): Add DW_FORM_addrx
8162 (read_attribute_value): Likewise
8163 (var_decode_location): Add DW_OP_addrx
8164 (dwarf2_const_value_attr): Add DW_FORM_addrx
8165 (dump_die_shallow): Likewise
8166 (dwarf2_fetch_constant_bytes): Likewise
8167 (decode_locdesc): Add DW_OP_addrx
8168 (skip_form_bytes): Add DW_FORM_addrx
8169
ad9d13f8
AT
81702019-04-22 Ali Tamur <tamur@google.com>
8171
8172 * MAINTAINERS (Write After Approval): Add self.
8173
d70cc3ba
SM
81742019-04-22 Simon Marchi <simon.marchi@efficios.com>
8175
8176 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8177 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8178 (open_symbol_file_object): Likewise.
8179 (svr4_default_sos): Add info parameter.
8180 (svr4_read_so_list): Likewise.
8181 (svr4_current_sos_direct): Adjust functions calls to pass down
8182 info.
8183 (svr4_current_sos_1): Add info parameter.
8184 (svr4_current_sos): Call get_svr4_info, pass info down to
8185 svr4_current_sos_1.
8186 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8187 get_svr4_info.
8188 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8189 get_svr4_info.
8190 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8191 to get_svr4_info.
8192 (probes_table_remove_objfile_probes): Likewise.
8193 (register_solib_event_probe): Add info parameter.
8194 (solist_update_incremental): Pass info parameter down to
8195 svr4_read_so_list.
8196 (disable_probes_interface): Add info parameter.
8197 (svr4_handle_solib_event): Pass current_program_space to
8198 get_svr4_info. Adjust disable_probes_interface cleanup.
8199 (svr4_create_probe_breakpoints): Add info parameter, pass it
8200 down to register_solib_event_probe.
8201 (svr4_create_solib_event_breakpoints): Add info parameter,
8202 pass it down to svr4_create_probe_breakpoints.
8203 (enable_break): Pass info down to
8204 svr4_create_solib_event_breakpoints.
8205 (svr4_solib_create_inferior_hook): Pass current_program_space to
8206 get_svr4_info.
8207 (svr4_clear_solib): Likewise.
8208
7905fc35
PA
82092019-04-22 Pedro Alves <palves@redhat.com>
8210
8211 * solib-svr4.c (svr4_free_objfile_observer): New.
8212 (probe_and_action::objfile): New field.
8213 (probes_table_htab_remove_objfile_probes)
8214 (probes_table_remove_objfile_probes): New functions.
8215 (register_solib_event_probe): Add 'objfile' parameter. Store it
8216 in the new probe_and_action. Don't store the probe in 'lookup'.
8217 (svr4_create_probe_breakpoints): Pass objfile to
8218 register_solib_event_probe.
8219 (_initialize_svr4_solib): Register a free_objfile observer.
8220
fb881986
TT
82212019-04-19 Tom Tromey <tom@tromey.com>
8222
8223 * common/queue.h: Remove.
8224
8732db6c
TT
82252019-04-19 Tom Tromey <tom@tromey.com>
8226
8227 * event-loop.c: Don't include "common/queue.h".
8228
97dfbadd
TT
82292019-04-19 Tom Tromey <tom@tromey.com>
8230
8231 * remote.c (remote_target): Use delete.
8232 * remote-notif.h: Include <list>, not "common/queue.h".
8233 (notif_client_p): Remove typedef.
8234 (remote_notif_state): Add constructor, destructor, initializer.
8235 <notif_queue>: Now a std::list.
8236 (remote_notif_state_xfree): Don't declare.
8237 * remote-notif.c (remote_notif_process, handle_notification)
8238 (remote_notif_state_allocate): Update.
8239 (~remote_notif_state): Rename from remote_notif_state_xfree.
8240
cf250e36
TT
82412019-04-19 Tom Tromey <tom@tromey.com>
8242
8243 * symfile.c (reread_symbols): Update.
8244 * objfiles.c (objfile_register_static_link)
8245 (objfile_lookup_static_link): Update
8246 (~objfile) Don't delete static_links.
8247 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8248
61f4b350
TT
82492019-04-19 Tom Tromey <tom@tromey.com>
8250
8251 * type-stack.h (struct type_stack) <insert>: Constify string.
8252 * type-stack.c (type_stack::insert): Constify string.
8253 * gdbtypes.h (lookup_template_type): Update.
8254 (address_space_name_to_int): Update.
8255 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8256 const.
8257 (lookup_template_type): Make name const.
8258 * c-exp.y: Update rules.
8259 (lex_one_token, classify_name, classify_inner_name)
8260 (c_print_token): Update.
8261 * p-exp.y: Update rules.
8262 (yylex): Update.
8263 * f-exp.y: Update rules.
8264 (yylex): Update.
8265 * d-exp.y: Update rules.
8266 (lex_one_token, classify_name, classify_inner_name): Update.
8267 * parse.c (write_dollar_variable, copy_name): Return std::string.
8268 * parser-defs.h (copy_name): Change return type.
8269 * m2-exp.y: Update rules.
8270 (yylex): Update.
8271 * go-exp.y (lex_one_token): Update.
8272 Update rules.
8273 (classify_unsafe_function, classify_packaged_name)
8274 (classify_name, yylex): Update.
8275
189b8c2e
ST
82762019-04-19 Sergei Trofimovich <siarheit@google.com>
8277
8278 * configure.ac: add --enable-source-highlight switch.
8279 * configure: Regenerate.
8280 * top.c (print_gdb_version): plumb --enable-source-highlight
8281 status to "show configuration".
8282
8ecb59f8
TT
82832019-04-19 Tom Tromey <tromey@adacore.com>
8284
8285 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8286 Check ADA_TYPE_P.
8287 (empty_record, ada_template_to_fixed_record_type_1)
8288 (template_to_static_fixed_type)
8289 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8290 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8291 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8292 macros.
8293
62160ec9
TT
82942019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8295
8296 PR symtab/24423:
8297 * source.c (print_source_lines_base): Advance "iter" when a
8298 control character is seen.
8299
f2ae8bc8
PW
83002019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8301
8302 * inferior.h (struct infcall_suspend_state_deleter):
8303 Catch exception in destructor to avoid crash.
8304
d563b953
PW
83052019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8306
8307 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8308 close to the add_com "shell".
8309
dc34c897
TT
83102019-04-18 Tom Tromey <tromey@adacore.com>
8311
8312 * process-stratum-target.h (class process_stratum_target)
8313 <stratum>: Add "final".
8314
a12e5744
TT
83152019-04-17 Tom Tromey <tromey@adacore.com>
8316
8317 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8318 against nullptr before use.
8319
a7e559cc
AH
83202019-04-17 Alan Hayward <alan.hayward@arm.com>
8321
8322 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8323
c01660c6
AB
83242019-04-17 Jim Wilson <jimw@sifive.com>
8325 Andrew Burgess <andrew.burgess@embecosm.com>
8326
8327 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8328 code read might fail, assume 4-byte breakpoint in that case.
8329
4aa866af
LS
83302019-04-15 Leszek Swirski <leszeks@google.com>
8331
8332 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8333 rather than a hand-rolled POD check when checking for forced MEMORY
8334 classification.
8335
48574d91
AH
83362019-04-15 Alan Hayward <alan.hayward@arm.com>
8337
8338 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8339 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8340 function.
8341 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8342 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8343 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8344 declaration.
8345
4da037ef
AH
83462019-04-15 Alan Hayward <alan.hayward@arm.com>
8347
8348 * aarch64-linux-nat.c
8349 (aarch64_linux_nat_target::thread_architecture): Add override.
8350 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8351 each VQ.
8352
ccb8d7e8
AH
83532019-04-15 Alan Hayward <alan.hayward@arm.com>
8354
8355 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8356
35add35e
AB
83572019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8358
8359 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8360 target types of size 96-bits, add some additional comments, and
8361 check that the builtin type we found was the correct size.
8362
51196bbc
EZ
83632019-04-12 Eli Zaretskii <eliz@gnu.org>
8364
8365 * utils.c (prompt_for_continue): Don't restore the styling at the
8366 end, as applied_style has the wrong value. This fixes styling in
8367 long lists of file names that are interrupted by the "Continue?"
8368 prompt.
8369
62253a61
AB
83702019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8371
8372 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8373 * c-lang.c (c_language_defn): Likewise.
8374 (cplus_language_defn): Likewise.
8375 (asm_language_defn): Likewise.
8376 (minimal_language_defn): Likewise.
8377 * d-lang.c (d_language_defn): Likewise.
8378 * f-lang.c (f_language_defn): Likewise.
8379 * go-lang.c (go_language_defn): Likewise.
8380 * language.c (unknown_language_defn): Likewise.
8381 (auto_language_defn): Likewise.
8382 * language.h (struct language_defn): Remove la_magic field.
8383 (LANG_MAGIC): Delete.
8384 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8385 * objc-lang.c (objc_language_defn): Likewise.
8386 * opencl-lang.c (opencl_language_defn): Likewise.
8387 * p-lang.c (pascal_language_defn): Likewise.
8388 * rust-lang.c (rust_language_defn): Likewise.
8389
a9158a86
AB
83902019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8391
8392 * riscv-tdep.c (riscv_type_align): New function.
8393 (riscv_type_alignment): Delete.
8394 (riscv_arg_location): Use 'type_align'.
8395 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8396
41077b66
AB
83972019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8398
8399 * gdbtypes.c (type_align): A struct with no non-static fields also
8400 has alignment of 1.
8401
9f0272f8
AB
84022019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8403
8404 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8405 component to 0.
8406 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8407 member.
8408 (riscv_struct_info::analyse): New implementation using new
8409 analyse_inner member function.
8410 (riscv_struct_info::field_offset): New member function.
8411 (riscv_struct_info::m_offsets): New member variable.
8412 (riscv_struct_info::analyse_inner): New private member function,
8413 takes the old implementation of riscv_struct_info::analyse but
8414 extended to track field offsets.
8415 (riscv_call_arg_struct): Update the struct folding special cases
8416 to handle cases where empty C++ structs, which are non-zero
8417 length, are found.
8418 (riscv_arg_location): Initialise the length of each location, a
8419 non-zero length now indicates the location is in use.
8420 (riscv_push_dummy_call): Allow for the first location having a
8421 non-zero offset when setting up arguments.
8422 (riscv_return_value): Likewise, but for return values.
8423
02cf60c7
TT
84242019-04-11 Tom Tromey <tromey@adacore.com>
8425
8426 * utils.c (internal_vproblem): Make "msg" const.
8427
68811f8f
AH
84282019-04-11 Alan Hayward <alan.hayward@arm.com>
8429
8430 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8431 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8432 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8433 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8434
3f52fdbc
KB
84352019-04-10 Kevin Buettner <kevinb@redhat.com>
8436
8437 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8438 function.
8439 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8440 of amd64_collect_native_gregset.
8441 (amd64_linux_nat_target::store_registers): Likewise.
8442
e9ad22ee
TT
84432019-04-10 Tom Tromey <tom@tromey.com>
8444
8445 * symtab.c (lookup_global_symbol_from_objfile)
8446 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8447 * objfiles.h (class separate_debug_iterator): New.
8448 (class separate_debug_range): New.
8449 (struct objfile) <separate_debug_objfiles>: New method.
8450 (objfile_separate_debug_iterate): Don't declare.
8451 * objfiles.c (separate_debug_iterator::operator++): Rename from
8452 objfile_separate_debug_iterate.
8453 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8454 iterator.
8455 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8456 iterator.
8457
ee371134
TT
84582019-04-10 Tom Tromey <tom@tromey.com>
8459
8460 * symfile.c (reread_symbols): Remove old comment.
8461 * objfiles.c (free_all_objfiles): Fix a typo.
8462
bf227d61
TT
84632019-04-10 Tom Tromey <tom@tromey.com>
8464
8465 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8466 * minsyms.c (lookup_minimal_symbol): Use foreach.
8467 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8468 (lookup_minimal_symbol_solib_trampoline): Likewise.
8469 * symfile.c (reread_symbols): Use foreach.
8470
8dc433a0
TT
84712019-04-09 Ivan Begert <ivanbegert@gmail.com>
8472 Tom Tromey <tromey@adacore.com>
8473
8474 PR rust/24414:
8475 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8476 (rust_lex_int_test): Change "value" to be LONGEST.
8477 (rust_lex_tests): Add test for long integer literal.
8478
9ab8741a
TT
84792019-04-09 Tom Tromey <tromey@adacore.com>
8480
8481 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8482 to bool.
8483 (extended_remote_target::attach): Update.
8484 (remote_target::remote_notice_new_inferior): Update.
8485 (remote_target::add_current_inferior_and_thread): Update.
8486 * inferior.c (exit_inferior_1): Use "false".
8487 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8488
e242fd12
SM
84892019-04-09 Simon Marchi <simon.marchi@efficios.com>
8490
9ca1957f 8491 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
8492 the "start" command.
8493
2b0c8b01
KB
84942019-04-08 Kevin Buettner <kevinb@redhat.com>
8495
8496 * python/py-inferior.c (infpy_thread_from_thread_handle):
8497 Adjust comments to reflect renaming of thread_from_thread_handle
8498 to thread_from_handle. Adjust keywords. Fix type error message.
8499 (inferior_object_methods): Add thread_from_handle. Retain
8500 thread_from_thread_handle, but mark it as deprecated.
8501
50a82723
KB
85022019-04-08 Kevin Buettner <kevinb@redhat.com>
8503
8504 * gdbthread.h (find_thread_by_handle): Revise declaration.
8505 * thread.c (find_thread_by_handle): Likewise. Adjust
8506 implementation too.
8507 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8508 support for buffer objects as handles.
8509
cf63b016
KB
85102019-04-08 Kevin Buettner <kevinb@redhat.com>
8511
8512 * python/py-infthread.c (thpy_thread_handle): New function.
8513 (thread_object_methods): Register thpy_thread_handle.
8514
3d6c6204
KB
85152019-04-08 Kevin Buettner <kevinb@redhat.com>
8516
8517 * gdbthread.h (thread_to_thread_handle): Declare.
8518 * thread.c (gdbtypes.h): Include.
8519 (thread_to_thread_handle): New function.
8520
8521 * target.h (struct target_ops): Add thread_info_to_thread_handle.
8522 (target_thread_info_to_thread_handle): Declare.
8523 * target.c (target_thread_info_to_thread_handle): New function.
8524 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8525 * target-delegates.c: Regenerate.
8526
8527 * linux-thread-db.c (class thread_db_target): Add method
8528 thread_info_to_thread_handle.
8529 (thread_db_target::thread_info_to_thread_handle): Define.
8530 * remote.c (class remote_target): Add new method
8531 thread_info_to_thread_handle.
8532 (remote_target::thread_info_to_thread_handle): Define.
8533
56be6ea8
PA
85342019-04-08 Pedro Alves <palves@redhat.com>
8535
8536 * common/common-exceptions.c (throw_exception): Don't create
8537 named object to throw; throw directly.
8538 (throw_it): Likewise. Don't initialize gdb_exception::message
8539 here, with new; pass FMT and AP to the ctor instead.
8540 * common/common-exceptions.h: Include <string>.
8541 (gdb_exception::gdb_exception(enum return_reason, enum errors,
8542 const char *, va_list)): New ctor. Use std::make_shared.
8543 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8544 errors)): Delete.
8545 (gdb_exception_error::gdb_exception_error(enum errors, const char
8546 *, va_list)): New.
8547 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8548 Add assertion.
8549 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8550 errors)): Delete.
8551 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8552 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8553 Add assertion.
8554
eedc3f4f
TT
85552019-04-08 Tom Tromey <tom@tromey.com>
8556
8557 * valops.c (value_rtti_indirect_type): Replace throw_exception
8558 with throw.
8559 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8560 with throw.
8561 * thread.c (thr_try_catch_cmd): Replace throw_exception with
8562 throw.
8563 * target.c (target_translate_tls_address): Replace throw_exception
8564 with throw.
8565 * stack.c (frame_apply_command_count): Replace throw_exception
8566 with throw.
8567 * solib-spu.c (append_ocl_sos): Replace throw_exception with
8568 throw.
8569 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8570 with throw.
8571 * rs6000-tdep.c (rs6000_frame_cache)
8572 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8573 * remote.c: Replace throw_exception with throw.
8574 * record-full.c (record_full_message, record_full_wait_1)
8575 (record_full_restore): Replace throw_exception with throw.
8576 * record-btrace.c:
8577 (get_thread_current_frame_id, record_btrace_start_replaying)
8578 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8579 (cmd_record_btrace_start): Replace throw_exception with throw.
8580 * parse.c (parse_exp_in_context_1): Replace throw_exception with
8581 throw.
8582 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8583 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8584 * linespec.c:
8585 (find_linespec_symbols): Replace throw_exception with throw.
8586 * infrun.c (displaced_step_prepare, resume): Replace
8587 throw_exception with throw.
8588 * infcmd.c (post_create_inferior): Replace throw_exception with
8589 throw.
8590 * inf-loop.c (inferior_event_handler): Replace throw_exception
8591 with throw.
8592 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8593 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8594 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8595 (get_prev_frame_always, get_frame_pc_if_available)
8596 (get_frame_address_in_block_if_available, get_frame_language):
8597 Replace throw_exception with throw.
8598 * frame-unwind.c (frame_unwind_try_unwinder): Replace
8599 throw_exception with throw.
8600 * eval.c (fetch_subexp_value, evaluate_var_value)
8601 (evaluate_funcall, evaluate_subexp_standard): Replace
8602 throw_exception with throw.
8603 * dwarf2loc.c (call_site_find_chain)
8604 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8605 Replace throw_exception with throw.
8606 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8607 with throw.
8608 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8609 throw.
8610 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8611 * completer.c (complete_line_internal): Replace throw_exception
8612 with throw.
8613 * compile/compile-object-run.c (compile_object_run): Replace
8614 throw_exception with throw.
8615 * cli/cli-script.c (process_next_line): Replace throw_exception
8616 with throw.
8617 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8618 (btrace_enable, btrace_maint_update_pt_packets): Replace
8619 throw_exception with throw.
8620 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8621 throw_exception with throw.
8622 * break-catch-throw.c (re_set_exception_catchpoint): Replace
8623 throw_exception with throw.
8624 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8625 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8626 * aarch64-tdep.c (aarch64_make_prologue_cache)
8627 (aarch64_make_stub_cache): Replace throw_exception with throw.
8628
26003a20
TT
86292019-04-08 Tom Tromey <tom@tromey.com>
8630
8631 * common/common-exceptions.c (throw_exception): Rename from
8632 throw_exception_cxx. Remove old copy. Make argument const.
8633 (throw_it): Create and throw exception objects directly.
8634 * common/common-exceptions.h (throw_exception): Make argument
8635 const.
8636 (struct gdb_exception_error): Add constructor.
8637 (struct gdb_exception_quit): Add constructor.
8638
d272eb37
TT
86392019-04-08 Tom Tromey <tom@tromey.com>
8640
8641 * common/common-exceptions.h (exception_rethrow): Don't declare.
8642 (TRY_SJLJ): Update comment.
8643 (TRY, CATCH, END_CATCH): Remove.
8644 * common/common-exceptions.c (exception_rethrow): Remove.
8645
230d2906
TT
86462019-04-08 Tom Tromey <tom@tromey.com>
8647
8648 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8649 Remove.
8650 (gdb_exception_error): Rename from
8651 gdb_exception_RETURN_MASK_ERROR.
8652 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8653 (gdb_quit_bad_alloc): Update.
8654 * aarch64-tdep.c: Update.
8655 * ada-lang.c: Update.
8656 * ada-typeprint.c: Update.
8657 * ada-valprint.c: Update.
8658 * amd64-tdep.c: Update.
8659 * arch-utils.c: Update.
8660 * break-catch-throw.c: Update.
8661 * breakpoint.c: Update.
8662 * btrace.c: Update.
8663 * c-varobj.c: Update.
8664 * cli/cli-cmds.c: Update.
8665 * cli/cli-interp.c: Update.
8666 * cli/cli-script.c: Update.
8667 * common/common-exceptions.c: Update.
8668 * common/new-op.c: Update.
8669 * common/selftest.c: Update.
8670 * compile/compile-c-symbols.c: Update.
8671 * compile/compile-cplus-symbols.c: Update.
8672 * compile/compile-object-load.c: Update.
8673 * compile/compile-object-run.c: Update.
8674 * completer.c: Update.
8675 * corelow.c: Update.
8676 * cp-abi.c: Update.
8677 * cp-support.c: Update.
8678 * cp-valprint.c: Update.
8679 * darwin-nat.c: Update.
8680 * disasm-selftests.c: Update.
8681 * dtrace-probe.c: Update.
8682 * dwarf-index-cache.c: Update.
8683 * dwarf-index-write.c: Update.
8684 * dwarf2-frame-tailcall.c: Update.
8685 * dwarf2-frame.c: Update.
8686 * dwarf2loc.c: Update.
8687 * dwarf2read.c: Update.
8688 * eval.c: Update.
8689 * event-loop.c: Update.
8690 * event-top.c: Update.
8691 * exec.c: Update.
8692 * f-valprint.c: Update.
8693 * fbsd-tdep.c: Update.
8694 * frame-unwind.c: Update.
8695 * frame.c: Update.
8696 * gdbtypes.c: Update.
8697 * gnu-v3-abi.c: Update.
8698 * guile/guile-internal.h: Update.
8699 * guile/scm-block.c: Update.
8700 * guile/scm-breakpoint.c: Update.
8701 * guile/scm-cmd.c: Update.
8702 * guile/scm-disasm.c: Update.
8703 * guile/scm-frame.c: Update.
8704 * guile/scm-lazy-string.c: Update.
8705 * guile/scm-math.c: Update.
8706 * guile/scm-param.c: Update.
8707 * guile/scm-ports.c: Update.
8708 * guile/scm-pretty-print.c: Update.
8709 * guile/scm-symbol.c: Update.
8710 * guile/scm-symtab.c: Update.
8711 * guile/scm-type.c: Update.
8712 * guile/scm-value.c: Update.
8713 * i386-linux-tdep.c: Update.
8714 * i386-tdep.c: Update.
8715 * inf-loop.c: Update.
8716 * infcall.c: Update.
8717 * infcmd.c: Update.
8718 * infrun.c: Update.
8719 * jit.c: Update.
8720 * language.c: Update.
8721 * linespec.c: Update.
8722 * linux-fork.c: Update.
8723 * linux-nat.c: Update.
8724 * linux-tdep.c: Update.
8725 * linux-thread-db.c: Update.
8726 * main.c: Update.
8727 * mi/mi-cmd-break.c: Update.
8728 * mi/mi-cmd-stack.c: Update.
8729 * mi/mi-interp.c: Update.
8730 * mi/mi-main.c: Update.
8731 * objc-lang.c: Update.
8732 * p-valprint.c: Update.
8733 * parse.c: Update.
8734 * ppc-linux-tdep.c: Update.
8735 * printcmd.c: Update.
8736 * python/py-arch.c: Update.
8737 * python/py-breakpoint.c: Update.
8738 * python/py-cmd.c: Update.
8739 * python/py-finishbreakpoint.c: Update.
8740 * python/py-frame.c: Update.
8741 * python/py-framefilter.c: Update.
8742 * python/py-gdb-readline.c: Update.
8743 * python/py-inferior.c: Update.
8744 * python/py-infthread.c: Update.
8745 * python/py-lazy-string.c: Update.
8746 * python/py-linetable.c: Update.
8747 * python/py-objfile.c: Update.
8748 * python/py-param.c: Update.
8749 * python/py-prettyprint.c: Update.
8750 * python/py-progspace.c: Update.
8751 * python/py-record-btrace.c: Update.
8752 * python/py-record.c: Update.
8753 * python/py-symbol.c: Update.
8754 * python/py-type.c: Update.
8755 * python/py-unwind.c: Update.
8756 * python/py-utils.c: Update.
8757 * python/py-value.c: Update.
8758 * python/python.c: Update.
8759 * record-btrace.c: Update.
8760 * record-full.c: Update.
8761 * remote-fileio.c: Update.
8762 * remote.c: Update.
8763 * riscv-tdep.c: Update.
8764 * rs6000-aix-tdep.c: Update.
8765 * rs6000-tdep.c: Update.
8766 * rust-exp.y: Update.
8767 * rust-lang.c: Update.
8768 * s390-tdep.c: Update.
8769 * selftest-arch.c: Update.
8770 * solib-dsbt.c: Update.
8771 * solib-frv.c: Update.
8772 * solib-spu.c: Update.
8773 * solib-svr4.c: Update.
8774 * solib.c: Update.
8775 * sparc64-linux-tdep.c: Update.
8776 * stack.c: Update.
8777 * symfile-mem.c: Update.
8778 * symmisc.c: Update.
8779 * target.c: Update.
8780 * thread.c: Update.
8781 * top.c: Update.
8782 * tracefile-tfile.c: Update.
8783 * tui/tui.c: Update.
8784 * typeprint.c: Update.
8785 * unittests/cli-utils-selftests.c: Update.
8786 * unittests/parse-connection-spec-selftests.c: Update.
8787 * valops.c: Update.
8788 * valprint.c: Update.
8789 * value.c: Update.
8790 * varobj.c: Update.
8791 * windows-nat.c: Update.
8792 * x86-linux-nat.c: Update.
8793 * xml-support.c: Update.
8794
a70b8144
TT
87952019-04-08 Tom Tromey <tom@tromey.com>
8796
8797 * xml-support.c: Use C++ exception handling.
8798 * x86-linux-nat.c: Use C++ exception handling.
8799 * windows-nat.c: Use C++ exception handling.
8800 * varobj.c: Use C++ exception handling.
8801 * value.c: Use C++ exception handling.
8802 * valprint.c: Use C++ exception handling.
8803 * valops.c: Use C++ exception handling.
8804 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8805 handling.
8806 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8807 * typeprint.c: Use C++ exception handling.
8808 * tui/tui.c: Use C++ exception handling.
8809 * tracefile-tfile.c: Use C++ exception handling.
8810 * top.c: Use C++ exception handling.
8811 * thread.c: Use C++ exception handling.
8812 * target.c: Use C++ exception handling.
8813 * symmisc.c: Use C++ exception handling.
8814 * symfile-mem.c: Use C++ exception handling.
8815 * stack.c: Use C++ exception handling.
8816 * sparc64-linux-tdep.c: Use C++ exception handling.
8817 * solib.c: Use C++ exception handling.
8818 * solib-svr4.c: Use C++ exception handling.
8819 * solib-spu.c: Use C++ exception handling.
8820 * solib-frv.c: Use C++ exception handling.
8821 * solib-dsbt.c: Use C++ exception handling.
8822 * selftest-arch.c: Use C++ exception handling.
8823 * s390-tdep.c: Use C++ exception handling.
8824 * rust-lang.c: Use C++ exception handling.
8825 * rust-exp.y: Use C++ exception handling.
8826 * rs6000-tdep.c: Use C++ exception handling.
8827 * rs6000-aix-tdep.c: Use C++ exception handling.
8828 * riscv-tdep.c: Use C++ exception handling.
8829 * remote.c: Use C++ exception handling.
8830 * remote-fileio.c: Use C++ exception handling.
8831 * record-full.c: Use C++ exception handling.
8832 * record-btrace.c: Use C++ exception handling.
8833 * python/python.c: Use C++ exception handling.
8834 * python/py-value.c: Use C++ exception handling.
8835 * python/py-utils.c: Use C++ exception handling.
8836 * python/py-unwind.c: Use C++ exception handling.
8837 * python/py-type.c: Use C++ exception handling.
8838 * python/py-symbol.c: Use C++ exception handling.
8839 * python/py-record.c: Use C++ exception handling.
8840 * python/py-record-btrace.c: Use C++ exception handling.
8841 * python/py-progspace.c: Use C++ exception handling.
8842 * python/py-prettyprint.c: Use C++ exception handling.
8843 * python/py-param.c: Use C++ exception handling.
8844 * python/py-objfile.c: Use C++ exception handling.
8845 * python/py-linetable.c: Use C++ exception handling.
8846 * python/py-lazy-string.c: Use C++ exception handling.
8847 * python/py-infthread.c: Use C++ exception handling.
8848 * python/py-inferior.c: Use C++ exception handling.
8849 * python/py-gdb-readline.c: Use C++ exception handling.
8850 * python/py-framefilter.c: Use C++ exception handling.
8851 * python/py-frame.c: Use C++ exception handling.
8852 * python/py-finishbreakpoint.c: Use C++ exception handling.
8853 * python/py-cmd.c: Use C++ exception handling.
8854 * python/py-breakpoint.c: Use C++ exception handling.
8855 * python/py-arch.c: Use C++ exception handling.
8856 * printcmd.c: Use C++ exception handling.
8857 * ppc-linux-tdep.c: Use C++ exception handling.
8858 * parse.c: Use C++ exception handling.
8859 * p-valprint.c: Use C++ exception handling.
8860 * objc-lang.c: Use C++ exception handling.
8861 * mi/mi-main.c: Use C++ exception handling.
8862 * mi/mi-interp.c: Use C++ exception handling.
8863 * mi/mi-cmd-stack.c: Use C++ exception handling.
8864 * mi/mi-cmd-break.c: Use C++ exception handling.
8865 * main.c: Use C++ exception handling.
8866 * linux-thread-db.c: Use C++ exception handling.
8867 * linux-tdep.c: Use C++ exception handling.
8868 * linux-nat.c: Use C++ exception handling.
8869 * linux-fork.c: Use C++ exception handling.
8870 * linespec.c: Use C++ exception handling.
8871 * language.c: Use C++ exception handling.
8872 * jit.c: Use C++ exception handling.
8873 * infrun.c: Use C++ exception handling.
8874 * infcmd.c: Use C++ exception handling.
8875 * infcall.c: Use C++ exception handling.
8876 * inf-loop.c: Use C++ exception handling.
8877 * i386-tdep.c: Use C++ exception handling.
8878 * i386-linux-tdep.c: Use C++ exception handling.
8879 * guile/scm-value.c: Use C++ exception handling.
8880 * guile/scm-type.c: Use C++ exception handling.
8881 * guile/scm-symtab.c: Use C++ exception handling.
8882 * guile/scm-symbol.c: Use C++ exception handling.
8883 * guile/scm-pretty-print.c: Use C++ exception handling.
8884 * guile/scm-ports.c: Use C++ exception handling.
8885 * guile/scm-param.c: Use C++ exception handling.
8886 * guile/scm-math.c: Use C++ exception handling.
8887 * guile/scm-lazy-string.c: Use C++ exception handling.
8888 * guile/scm-frame.c: Use C++ exception handling.
8889 * guile/scm-disasm.c: Use C++ exception handling.
8890 * guile/scm-cmd.c: Use C++ exception handling.
8891 * guile/scm-breakpoint.c: Use C++ exception handling.
8892 * guile/scm-block.c: Use C++ exception handling.
8893 * guile/guile-internal.h: Use C++ exception handling.
8894 * gnu-v3-abi.c: Use C++ exception handling.
8895 * gdbtypes.c: Use C++ exception handling.
8896 * frame.c: Use C++ exception handling.
8897 * frame-unwind.c: Use C++ exception handling.
8898 * fbsd-tdep.c: Use C++ exception handling.
8899 * f-valprint.c: Use C++ exception handling.
8900 * exec.c: Use C++ exception handling.
8901 * event-top.c: Use C++ exception handling.
8902 * event-loop.c: Use C++ exception handling.
8903 * eval.c: Use C++ exception handling.
8904 * dwarf2read.c: Use C++ exception handling.
8905 * dwarf2loc.c: Use C++ exception handling.
8906 * dwarf2-frame.c: Use C++ exception handling.
8907 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8908 * dwarf-index-write.c: Use C++ exception handling.
8909 * dwarf-index-cache.c: Use C++ exception handling.
8910 * dtrace-probe.c: Use C++ exception handling.
8911 * disasm-selftests.c: Use C++ exception handling.
8912 * darwin-nat.c: Use C++ exception handling.
8913 * cp-valprint.c: Use C++ exception handling.
8914 * cp-support.c: Use C++ exception handling.
8915 * cp-abi.c: Use C++ exception handling.
8916 * corelow.c: Use C++ exception handling.
8917 * completer.c: Use C++ exception handling.
8918 * compile/compile-object-run.c: Use C++ exception handling.
8919 * compile/compile-object-load.c: Use C++ exception handling.
8920 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8921 * compile/compile-c-symbols.c: Use C++ exception handling.
8922 * common/selftest.c: Use C++ exception handling.
8923 * common/new-op.c: Use C++ exception handling.
8924 * cli/cli-script.c: Use C++ exception handling.
8925 * cli/cli-interp.c: Use C++ exception handling.
8926 * cli/cli-cmds.c: Use C++ exception handling.
8927 * c-varobj.c: Use C++ exception handling.
8928 * btrace.c: Use C++ exception handling.
8929 * breakpoint.c: Use C++ exception handling.
8930 * break-catch-throw.c: Use C++ exception handling.
8931 * arch-utils.c: Use C++ exception handling.
8932 * amd64-tdep.c: Use C++ exception handling.
8933 * ada-valprint.c: Use C++ exception handling.
8934 * ada-typeprint.c: Use C++ exception handling.
8935 * ada-lang.c: Use C++ exception handling.
8936 * aarch64-tdep.c: Use C++ exception handling.
8937
3d6e9d23
TT
89382019-04-08 Tom Tromey <tom@tromey.com>
8939
8940 * xml-support.c (gdb_xml_parser::parse): Update.
8941 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8942 * value.c (show_convenience): Update.
8943 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8944 (test_parse_flags_qcs): Update.
8945 * thread.c (thr_try_catch_cmd): Update.
8946 * target.c (target_translate_tls_address): Update.
8947 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8948 (info_frame_command_core, frame_apply_command_count): Update.
8949 * rust-exp.y (rust_lex_exception_test): Update.
8950 * riscv-tdep.c (riscv_print_one_register_info): Update.
8951 * remote.c (remote_target::enable_btrace): Update.
8952 * record-btrace.c (record_btrace_enable_warn): Update.
8953 * python/py-utils.c (gdbpy_convert_exception): Update.
8954 * printcmd.c (do_one_display, print_variable_and_value): Update.
8955 * mi/mi-main.c (mi_print_exception): Update.
8956 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8957 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8958 * linux-nat.c (linux_nat_target::attach): Update.
8959 * linux-fork.c (class scoped_switch_fork_info): Update.
8960 * infrun.c (displaced_step_prepare): Update.
8961 * infcall.c (call_function_by_hand_dummy): Update.
8962 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8963 * gnu-v3-abi.c (print_one_vtable): Update.
8964 * frame.c (get_prev_frame_always): Update.
8965 * f-valprint.c (info_common_command_for_block): Update.
8966 * exec.c (try_open_exec_file): Update.
8967 * exceptions.c (print_exception, exception_print)
8968 (exception_fprintf, exception_print_same): Update.
8969 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8970 * dwarf-index-cache.c (index_cache::store)
8971 (index_cache::lookup_gdb_index): Update.
8972 * darwin-nat.c (maybe_cache_shell): Update.
8973 * cp-valprint.c (cp_print_value_fields): Update.
8974 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8975 (gcc_cplus_symbol_address): Update.
8976 * compile/compile-c-symbols.c (gcc_convert_symbol)
8977 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8978 * common/selftest.c: Update.
8979 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8980 a std::string.
8981 (exception_try_scope_entry, exception_try_scope_exit): Don't
8982 declare.
8983 (struct exception_try_scope): Remove.
8984 (TRY): Don't use exception_try_scope.
8985 (struct gdb_exception): Add constructor, operator=.
8986 <what>: New method.
8987 (struct gdb_exception_RETURN_MASK_ALL)
8988 (struct gdb_exception_RETURN_MASK_ERROR)
8989 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8990 (struct gdb_quit_bad_alloc): Update.
8991 * common/common-exceptions.c (exception_none): Change
8992 initializer.
8993 (struct catcher) <state, exception>: Initialize inline.
8994 <prev>: Remove member.
8995 (current_catcher): Remove.
8996 (catchers): New global.
8997 (exceptions_state_mc_init): Simplify.
8998 (catcher_pop): Remove.
8999 (exceptions_state_mc, exceptions_state_mc_catch): Update.
9000 (try_scope_depth, exception_try_scope_entry)
9001 (exception_try_scope_exit): Remove.
9002 (throw_exception_sjlj): Update.
9003 (exception_messages, exception_messages_size): Remove.
9004 (throw_it): Simplify.
9005 (gdb_exception_sliced_copy): Remove.
9006 (throw_exception_cxx): Update.
9007 * cli/cli-script.c (script_from_file): Update.
9008 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9009 Update.
9010 * ada-valprint.c (ada_val_print): Update.
9011 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9012 (create_excep_cond_exprs): Update.
9013
c5c10118
TT
90142019-04-08 Tom Tromey <tom@tromey.com>
9015
9016 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9017 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9018 (TRY, CATCH, END_CATCH): Remove some definitions.
9019 * common/common-exceptions.c: Don't use GDB_XCPT.
9020 (catcher_list_size): Remove.
9021 (throw_exception, throw_it): Simplify.
9022
4de283e4
TT
90232019-04-05 Tom Tromey <tom@tromey.com>
9024
9025 Revert the header-sorting patch.
9026 * ft32-tdep.c: Revert.
9027 * frv-tdep.c: Revert.
9028 * frv-linux-tdep.c: Revert.
9029 * frame.c: Revert.
9030 * frame-unwind.c: Revert.
9031 * frame-base.c: Revert.
9032 * fork-child.c: Revert.
9033 * findvar.c: Revert.
9034 * findcmd.c: Revert.
9035 * filesystem.c: Revert.
9036 * filename-seen-cache.h: Revert.
9037 * filename-seen-cache.c: Revert.
9038 * fbsd-tdep.c: Revert.
9039 * fbsd-nat.h: Revert.
9040 * fbsd-nat.c: Revert.
9041 * f-valprint.c: Revert.
9042 * f-typeprint.c: Revert.
9043 * f-lang.c: Revert.
9044 * extension.h: Revert.
9045 * extension.c: Revert.
9046 * extension-priv.h: Revert.
9047 * expprint.c: Revert.
9048 * exec.h: Revert.
9049 * exec.c: Revert.
9050 * exceptions.c: Revert.
9051 * event-top.c: Revert.
9052 * event-loop.c: Revert.
9053 * eval.c: Revert.
9054 * elfread.c: Revert.
9055 * dwarf2read.h: Revert.
9056 * dwarf2read.c: Revert.
9057 * dwarf2loc.c: Revert.
9058 * dwarf2expr.h: Revert.
9059 * dwarf2expr.c: Revert.
9060 * dwarf2-frame.c: Revert.
9061 * dwarf2-frame-tailcall.c: Revert.
9062 * dwarf-index-write.h: Revert.
9063 * dwarf-index-write.c: Revert.
9064 * dwarf-index-common.c: Revert.
9065 * dwarf-index-cache.h: Revert.
9066 * dwarf-index-cache.c: Revert.
9067 * dummy-frame.c: Revert.
9068 * dtrace-probe.c: Revert.
9069 * disasm.h: Revert.
9070 * disasm.c: Revert.
9071 * disasm-selftests.c: Revert.
9072 * dictionary.c: Revert.
9073 * dicos-tdep.c: Revert.
9074 * demangle.c: Revert.
9075 * dcache.h: Revert.
9076 * dcache.c: Revert.
9077 * darwin-nat.h: Revert.
9078 * darwin-nat.c: Revert.
9079 * darwin-nat-info.c: Revert.
9080 * d-valprint.c: Revert.
9081 * d-namespace.c: Revert.
9082 * d-lang.c: Revert.
9083 * ctf.c: Revert.
9084 * csky-tdep.c: Revert.
9085 * csky-linux-tdep.c: Revert.
9086 * cris-tdep.c: Revert.
9087 * cris-linux-tdep.c: Revert.
9088 * cp-valprint.c: Revert.
9089 * cp-support.c: Revert.
9090 * cp-namespace.c: Revert.
9091 * cp-abi.c: Revert.
9092 * corelow.c: Revert.
9093 * corefile.c: Revert.
9094 * continuations.c: Revert.
9095 * completer.h: Revert.
9096 * completer.c: Revert.
9097 * complaints.c: Revert.
9098 * coffread.c: Revert.
9099 * coff-pe-read.c: Revert.
9100 * cli-out.h: Revert.
9101 * cli-out.c: Revert.
9102 * charset.c: Revert.
9103 * c-varobj.c: Revert.
9104 * c-valprint.c: Revert.
9105 * c-typeprint.c: Revert.
9106 * c-lang.c: Revert.
9107 * buildsym.c: Revert.
9108 * buildsym-legacy.c: Revert.
9109 * build-id.h: Revert.
9110 * build-id.c: Revert.
9111 * btrace.c: Revert.
9112 * bsd-uthread.c: Revert.
9113 * breakpoint.h: Revert.
9114 * breakpoint.c: Revert.
9115 * break-catch-throw.c: Revert.
9116 * break-catch-syscall.c: Revert.
9117 * break-catch-sig.c: Revert.
9118 * blockframe.c: Revert.
9119 * block.c: Revert.
9120 * bfin-tdep.c: Revert.
9121 * bfin-linux-tdep.c: Revert.
9122 * bfd-target.c: Revert.
9123 * bcache.c: Revert.
9124 * ax-general.c: Revert.
9125 * ax-gdb.h: Revert.
9126 * ax-gdb.c: Revert.
9127 * avr-tdep.c: Revert.
9128 * auxv.c: Revert.
9129 * auto-load.c: Revert.
9130 * arm-wince-tdep.c: Revert.
9131 * arm-tdep.c: Revert.
9132 * arm-symbian-tdep.c: Revert.
9133 * arm-pikeos-tdep.c: Revert.
9134 * arm-obsd-tdep.c: Revert.
9135 * arm-nbsd-tdep.c: Revert.
9136 * arm-nbsd-nat.c: Revert.
9137 * arm-linux-tdep.c: Revert.
9138 * arm-linux-nat.c: Revert.
9139 * arm-fbsd-tdep.c: Revert.
9140 * arm-fbsd-nat.c: Revert.
9141 * arm-bsd-tdep.c: Revert.
9142 * arch-utils.c: Revert.
9143 * arc-tdep.c: Revert.
9144 * arc-newlib-tdep.c: Revert.
9145 * annotate.h: Revert.
9146 * annotate.c: Revert.
9147 * amd64-windows-tdep.c: Revert.
9148 * amd64-windows-nat.c: Revert.
9149 * amd64-tdep.c: Revert.
9150 * amd64-sol2-tdep.c: Revert.
9151 * amd64-obsd-tdep.c: Revert.
9152 * amd64-obsd-nat.c: Revert.
9153 * amd64-nbsd-tdep.c: Revert.
9154 * amd64-nbsd-nat.c: Revert.
9155 * amd64-nat.c: Revert.
9156 * amd64-linux-tdep.c: Revert.
9157 * amd64-linux-nat.c: Revert.
9158 * amd64-fbsd-tdep.c: Revert.
9159 * amd64-fbsd-nat.c: Revert.
9160 * amd64-dicos-tdep.c: Revert.
9161 * amd64-darwin-tdep.c: Revert.
9162 * amd64-bsd-nat.c: Revert.
9163 * alpha-tdep.c: Revert.
9164 * alpha-obsd-tdep.c: Revert.
9165 * alpha-nbsd-tdep.c: Revert.
9166 * alpha-mdebug-tdep.c: Revert.
9167 * alpha-linux-tdep.c: Revert.
9168 * alpha-linux-nat.c: Revert.
9169 * alpha-bsd-tdep.c: Revert.
9170 * alpha-bsd-nat.c: Revert.
9171 * aix-thread.c: Revert.
9172 * agent.c: Revert.
9173 * addrmap.c: Revert.
9174 * ada-varobj.c: Revert.
9175 * ada-valprint.c: Revert.
9176 * ada-typeprint.c: Revert.
9177 * ada-tasks.c: Revert.
9178 * ada-lang.c: Revert.
9179 * aarch64-tdep.c: Revert.
9180 * aarch64-ravenscar-thread.c: Revert.
9181 * aarch64-newlib-tdep.c: Revert.
9182 * aarch64-linux-tdep.c: Revert.
9183 * aarch64-linux-nat.c: Revert.
9184 * aarch64-fbsd-tdep.c: Revert.
9185 * aarch64-fbsd-nat.c: Revert.
9186 * aarch32-linux-nat.c: Revert.
9187
d55e5aa6
TT
91882019-04-05 Tom Tromey <tom@tromey.com>
9189
9190 * ft32-tdep.c: Sort headers.
9191 * frv-tdep.c: Sort headers.
9192 * frv-linux-tdep.c: Sort headers.
9193 * frame.c: Sort headers.
9194 * frame-unwind.c: Sort headers.
9195 * frame-base.c: Sort headers.
9196 * fork-child.c: Sort headers.
9197 * findvar.c: Sort headers.
9198 * findcmd.c: Sort headers.
9199 * filesystem.c: Sort headers.
9200 * filename-seen-cache.h: Sort headers.
9201 * filename-seen-cache.c: Sort headers.
9202 * fbsd-tdep.c: Sort headers.
9203 * fbsd-nat.h: Sort headers.
9204 * fbsd-nat.c: Sort headers.
9205 * f-valprint.c: Sort headers.
9206 * f-typeprint.c: Sort headers.
9207 * f-lang.c: Sort headers.
9208 * extension.h: Sort headers.
9209 * extension.c: Sort headers.
9210 * extension-priv.h: Sort headers.
9211 * expprint.c: Sort headers.
9212 * exec.h: Sort headers.
9213 * exec.c: Sort headers.
9214 * exceptions.c: Sort headers.
9215 * event-top.c: Sort headers.
9216 * event-loop.c: Sort headers.
9217 * eval.c: Sort headers.
9218 * elfread.c: Sort headers.
9219 * dwarf2read.h: Sort headers.
9220 * dwarf2read.c: Sort headers.
9221 * dwarf2loc.c: Sort headers.
9222 * dwarf2expr.h: Sort headers.
9223 * dwarf2expr.c: Sort headers.
9224 * dwarf2-frame.c: Sort headers.
9225 * dwarf2-frame-tailcall.c: Sort headers.
9226 * dwarf-index-write.h: Sort headers.
9227 * dwarf-index-write.c: Sort headers.
9228 * dwarf-index-common.c: Sort headers.
9229 * dwarf-index-cache.h: Sort headers.
9230 * dwarf-index-cache.c: Sort headers.
9231 * dummy-frame.c: Sort headers.
9232 * dtrace-probe.c: Sort headers.
9233 * disasm.h: Sort headers.
9234 * disasm.c: Sort headers.
9235 * disasm-selftests.c: Sort headers.
9236 * dictionary.c: Sort headers.
9237 * dicos-tdep.c: Sort headers.
9238 * demangle.c: Sort headers.
9239 * dcache.h: Sort headers.
9240 * dcache.c: Sort headers.
9241 * darwin-nat.h: Sort headers.
9242 * darwin-nat.c: Sort headers.
9243 * darwin-nat-info.c: Sort headers.
9244 * d-valprint.c: Sort headers.
9245 * d-namespace.c: Sort headers.
9246 * d-lang.c: Sort headers.
9247 * ctf.c: Sort headers.
9248 * csky-tdep.c: Sort headers.
9249 * csky-linux-tdep.c: Sort headers.
9250 * cris-tdep.c: Sort headers.
9251 * cris-linux-tdep.c: Sort headers.
9252 * cp-valprint.c: Sort headers.
9253 * cp-support.c: Sort headers.
9254 * cp-namespace.c: Sort headers.
9255 * cp-abi.c: Sort headers.
9256 * corelow.c: Sort headers.
9257 * corefile.c: Sort headers.
9258 * continuations.c: Sort headers.
9259 * completer.h: Sort headers.
9260 * completer.c: Sort headers.
9261 * complaints.c: Sort headers.
9262 * coffread.c: Sort headers.
9263 * coff-pe-read.c: Sort headers.
9264 * cli-out.h: Sort headers.
9265 * cli-out.c: Sort headers.
9266 * charset.c: Sort headers.
9267 * c-varobj.c: Sort headers.
9268 * c-valprint.c: Sort headers.
9269 * c-typeprint.c: Sort headers.
9270 * c-lang.c: Sort headers.
9271 * buildsym.c: Sort headers.
9272 * buildsym-legacy.c: Sort headers.
9273 * build-id.h: Sort headers.
9274 * build-id.c: Sort headers.
9275 * btrace.c: Sort headers.
9276 * bsd-uthread.c: Sort headers.
9277 * breakpoint.h: Sort headers.
9278 * breakpoint.c: Sort headers.
9279 * break-catch-throw.c: Sort headers.
9280 * break-catch-syscall.c: Sort headers.
9281 * break-catch-sig.c: Sort headers.
9282 * blockframe.c: Sort headers.
9283 * block.c: Sort headers.
9284 * bfin-tdep.c: Sort headers.
9285 * bfin-linux-tdep.c: Sort headers.
9286 * bfd-target.c: Sort headers.
9287 * bcache.c: Sort headers.
9288 * ax-general.c: Sort headers.
9289 * ax-gdb.h: Sort headers.
9290 * ax-gdb.c: Sort headers.
9291 * avr-tdep.c: Sort headers.
9292 * auxv.c: Sort headers.
9293 * auto-load.c: Sort headers.
9294 * arm-wince-tdep.c: Sort headers.
9295 * arm-tdep.c: Sort headers.
9296 * arm-symbian-tdep.c: Sort headers.
9297 * arm-pikeos-tdep.c: Sort headers.
9298 * arm-obsd-tdep.c: Sort headers.
9299 * arm-nbsd-tdep.c: Sort headers.
9300 * arm-nbsd-nat.c: Sort headers.
9301 * arm-linux-tdep.c: Sort headers.
9302 * arm-linux-nat.c: Sort headers.
9303 * arm-fbsd-tdep.c: Sort headers.
9304 * arm-fbsd-nat.c: Sort headers.
9305 * arm-bsd-tdep.c: Sort headers.
9306 * arch-utils.c: Sort headers.
9307 * arc-tdep.c: Sort headers.
9308 * arc-newlib-tdep.c: Sort headers.
9309 * annotate.h: Sort headers.
9310 * annotate.c: Sort headers.
9311 * amd64-windows-tdep.c: Sort headers.
9312 * amd64-windows-nat.c: Sort headers.
9313 * amd64-tdep.c: Sort headers.
9314 * amd64-sol2-tdep.c: Sort headers.
9315 * amd64-obsd-tdep.c: Sort headers.
9316 * amd64-obsd-nat.c: Sort headers.
9317 * amd64-nbsd-tdep.c: Sort headers.
9318 * amd64-nbsd-nat.c: Sort headers.
9319 * amd64-nat.c: Sort headers.
9320 * amd64-linux-tdep.c: Sort headers.
9321 * amd64-linux-nat.c: Sort headers.
9322 * amd64-fbsd-tdep.c: Sort headers.
9323 * amd64-fbsd-nat.c: Sort headers.
9324 * amd64-dicos-tdep.c: Sort headers.
9325 * amd64-darwin-tdep.c: Sort headers.
9326 * amd64-bsd-nat.c: Sort headers.
9327 * alpha-tdep.c: Sort headers.
9328 * alpha-obsd-tdep.c: Sort headers.
9329 * alpha-nbsd-tdep.c: Sort headers.
9330 * alpha-mdebug-tdep.c: Sort headers.
9331 * alpha-linux-tdep.c: Sort headers.
9332 * alpha-linux-nat.c: Sort headers.
9333 * alpha-bsd-tdep.c: Sort headers.
9334 * alpha-bsd-nat.c: Sort headers.
9335 * aix-thread.c: Sort headers.
9336 * agent.c: Sort headers.
9337 * addrmap.c: Sort headers.
9338 * ada-varobj.c: Sort headers.
9339 * ada-valprint.c: Sort headers.
9340 * ada-typeprint.c: Sort headers.
9341 * ada-tasks.c: Sort headers.
9342 * ada-lang.c: Sort headers.
9343 * aarch64-tdep.c: Sort headers.
9344 * aarch64-ravenscar-thread.c: Sort headers.
9345 * aarch64-newlib-tdep.c: Sort headers.
9346 * aarch64-linux-tdep.c: Sort headers.
9347 * aarch64-linux-nat.c: Sort headers.
9348 * aarch64-fbsd-tdep.c: Sort headers.
9349 * aarch64-fbsd-nat.c: Sort headers.
9350 * aarch32-linux-nat.c: Sort headers.
9351
699bd4cf
TT
93522019-04-04 Tom Tromey <tom@tromey.com>
9353
9354 * varobj.c (varobj_create): Update.
9355 * rust-exp.y (struct rust_parser) <update_innermost_block,
9356 lookup_symbol>: New methods.
9357 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9358 Rename.
9359 (rust_parser::rust_lookup_type)
9360 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9361 * printcmd.c (display_command, do_one_display): Update.
9362 * parser-defs.h (struct parser_state) <parser_state>: Add
9363 "tracker" parameter.
9364 (block_tracker): New member.
9365 (class innermost_block_tracker) <innermost_block_tracker>: Add
9366 "types" parameter.
9367 <reset>: Remove method.
9368 (innermost_block): Don't declare.
9369 (null_post_parser): Update.
9370 * parse.c (innermost_block): Remove global.
9371 (write_dollar_variable): Update.
9372 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9373 Remove "tracker_types" parameter.
9374 (parse_expression): Add "tracker" parameter.
9375 (parse_expression_for_completion): Update.
9376 (null_post_parser): Add "tracker" parameter.
9377 * p-exp.y: Update rules.
9378 * m2-exp.y: Update rules.
9379 * language.h (struct language_defn) <la_post_parser>: Add
9380 "tracker" parameter.
9381 * go-exp.y: Update rules.
9382 * f-exp.y: Update rules.
9383 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9384 parameter.
9385 * d-exp.y: Update rules.
9386 * c-exp.y: Update rules.
9387 * breakpoint.c (set_breakpoint_condition): Create an
9388 innermost_block_tracker.
9389 (watch_command_1): Likewise.
9390 * ada-lang.c (resolve): Add "tracker" parameter.
9391 (resolve_subexp): Likewise.
9392 * ada-exp.y (write_var_from_sym): Update.
9393
dac43e32
TT
93942019-04-04 Tom Tromey <tom@tromey.com>
9395
9396 * type-stack.h: New file.
9397 * type-stack.c: New file.
9398 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9399 type-stack.h.
9400 (insert_into_type_stack, insert_type, push_type, push_type_int)
9401 (insert_type_address_space, pop_type, pop_type_int)
9402 (pop_typelist, pop_type_stack, append_type_stack)
9403 (push_type_stack, get_type_stack, push_typelist)
9404 (follow_type_instance_flags, follow_types): Don't declare.
9405 * parse.c (type_stack): Remove global.
9406 (parse_exp_in_context): Update.
9407 (insert_into_type_stack, insert_type, push_type, push_type_int)
9408 (insert_type_address_space, pop_type, pop_type_int)
9409 (pop_typelist, pop_type_stack, append_type_stack)
9410 (push_type_stack, get_type_stack, push_typelist)
9411 (follow_type_instance_flags, follow_types): Remove (moved to
9412 type-stack.c).
9413 * f-exp.y (type_stack): New global.
9414 Update rules.
9415 (push_kind_type, f_parse): Update.
9416 * d-exp.y (type_stack): New global.
9417 Update rules.
9418 (d_parse): Update.
9419 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9420 Update rules.
9421 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9422 (HFILES_NO_SRCDIR): Add type-stack.h.
9423
2a612529
TT
94242019-04-04 Tom Tromey <tom@tromey.com>
9425
9426 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9427 (rust_parser::convert_ast_to_expression, rust_parse)
9428 (rust_lex_test_completion, rust_lex_tests): Update.
9429 * parser-defs.h (struct expr_completion_state): New.
9430 (struct parser_state) <parser_state>: Add completion parameter.
9431 <mark_struct_expression, mark_completion_tag>: New methods.
9432 <parse_completion, m_completion_state>: New members.
9433 (prefixify_expression, null_post_parser): Update.
9434 (mark_struct_expression, mark_completion_tag): Don't declare.
9435 * parse.c (parse_completion, expout_last_struct)
9436 (expout_tag_completion_type, expout_completion_name): Remove
9437 globals.
9438 (parser_state::mark_struct_expression)
9439 (parser_state::mark_completion_tag): Now methods.
9440 (prefixify_expression): Add last_struct parameter.
9441 (prefixify_subexp): Likewise.
9442 (parse_exp_1): Update.
9443 (parse_exp_in_context): Add cstate parameter. Update.
9444 (parse_expression_for_completion): Create an
9445 expr_completion_state.
9446 (null_post_parser): Add "completion" parameter.
9447 * p-exp.y: Update rules.
9448 (yylex): Update.
9449 * language.h (struct language_defn) <la_post_parser>: Add
9450 "completing" parameter.
9451 * go-exp.y: Update rules.
9452 (lex_one_token): Update.
9453 * expression.h (parse_completion): Don't declare.
9454 * d-exp.y: Update rules.
9455 (lex_one_token): Update rules.
9456 * c-exp.y: Update rules.
9457 (lex_one_token): Update.
9458 * ada-lang.c (resolve): Add "parse_completion" parameter.
9459 (resolve_subexp): Likewise.
9460 (ada_resolve_function): Likewise.
9461
43476f0b
TT
94622019-04-04 Tom Tromey <tom@tromey.com>
9463
9464 * parser-defs.h (struct parser_state) <start_arglist,
9465 end_arglist>: New methods.
9466 <arglist_len, m_funcall_chain>: New members.
9467 (arglist_len, start_arglist, end_arglist): Don't declare.
9468 * parse.c (arglist_len, funcall_chain): Remove global.
9469 (start_arglist, end_arglist): Remove functions.
9470 (parse_exp_in_context): Update.
9471 * p-exp.y: Update rules.
9472 * m2-exp.y: Update rules.
9473 * go-exp.y: Update rules.
9474 * f-exp.y: Update rules.
9475 * d-exp.y: Update rules.
9476 * c-exp.y: Update rules.
9477
5776fca3
TT
94782019-04-04 Tom Tromey <tom@tromey.com>
9479
9480 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9481 lex_operator, push_back>: New methods.
9482 Update all rules.
9483 (rust_parser::lex_hex, lex_escape): Rename and update.
9484 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9485 (rust_parser::lex_operator): Rename and update.
9486 (rust_parser::lex_number, rustyylex, rustyyerror)
9487 (rust_lex_test_init, rust_lex_test_sequence)
9488 (rust_lex_test_push_back, rust_lex_tests): Update.
9489 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9490 parameter.
9491 <lexptr, prev_lexptr>: New members.
9492 (lexptr, prev_lexptr): Don't declare.
9493 * parse.c (lexptr, prev_lexptr): Remove globals.
9494 (parse_exp_in_context): Update.
9495 * p-exp.y (yylex, yyerror): Update.
9496 * m2-exp.y (parse_number, yylex, yyerror): Update.
9497 * go-exp.y (lex_one_token, yyerror): Update.
9498 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9499 * d-exp.y (lex_one_token, yyerror): Update.
9500 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9501 (lex_one_token, yyerror): Update.
9502 * ada-lex.l (YY_INPUT): Update.
9503 (rewind_to_char): Update.
9504 * ada-exp.y (yyerror): Update.
9505
8621b685
TT
95062019-04-04 Tom Tromey <tom@tromey.com>
9507
9508 * rust-exp.y (rustyylex, rust_lex_tests): Update.
9509 * parser-defs.h (struct parser_state) <parser_state>: Add new
9510 parameter.
9511 <comma_terminates>: New member.
9512 (comma_terminates): Don't declare global.
9513 * parse.c (comma_terminates): Remove global.
9514 (parse_exp_in_context): Update.
9515 * p-exp.y (yylex): Update.
9516 * m2-exp.y (yylex): Update.
9517 * go-exp.y (lex_one_token): Update.
9518 * f-exp.y (yylex): Update.
9519 * d-exp.y (lex_one_token): Update.
9520 * c-exp.y (lex_one_token): Update.
9521 * ada-lex.l: Update.
9522
28aaf3fd
TT
95232019-04-04 Tom Tromey <tom@tromey.com>
9524
9525 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9526 (rustyylex, rust_lex_test_init, rust_lex_test_one)
9527 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9528 * parser-defs.h (paren_depth): Don't declare.
9529 * parse.c (paren_depth): Remove global.
9530 (parse_exp_in_context): Update.
9531 * p-exp.y (paren_depth): New global.
9532 (pascal_parse): Initialize it.
9533 * m2-exp.y (paren_depth): New global.
9534 (m2_parse): Initialize it.
9535 * go-exp.y (paren_depth): New global.
9536 (go_parse): Initialize it.
9537 * f-exp.y (paren_depth): New global.
9538 (f_parse): Initialize it.
9539 * d-exp.y (paren_depth): New global.
9540 (d_parse): Initialize it.
9541 * c-exp.y (paren_depth): New global.
9542 (c_parse): Initialize it.
9543 * ada-lex.l (paren_depth): New global.
9544 (lexer_init): Initialize it.
9545
1e58a4a4
TT
95462019-04-04 Tom Tromey <tom@tromey.com>
9547
9548 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9549 (rust_parser::convert_ast_to_type)
9550 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9551 * parser-defs.h (struct parser_state) <parser_state>: Add
9552 parameters. Initialize new members.
9553 <expression_context_block, expression_context_pc>: New members.
9554 * parse.c (expression_context_block, expression_context_pc):
9555 Remove globals.
9556 (parse_exp_in_context): Update.
9557 * p-exp.y: Update all rules.
9558 (yylex): Update.
9559 * m2-exp.y: Update all rules.
9560 (yylex): Update.
9561 * go-exp.y (yylex): Update.
9562 * f-exp.y (yylex): Update.
9563 * d-exp.y: Update all rules.
9564 (yylex): Update.
9565 * c-exp.y: Update all rules.
9566 (lex_one_token, classify_name, yylex, c_parse): Update.
9567 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9568
37eedb39
TT
95692019-04-04 Tom Tromey <tom@tromey.com>
9570
9571 * gdbarch.h, gdbarch.c: Rebuild.
9572 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9573 * stap-probe.h:
9574 (struct stap_parse_info): Replace "parser_state" with
9575 "expr_builder".
9576 * parser-defs.h (struct expr_builder): Rename from "parser_state".
9577 (parser_state): New class.
9578 * parse.c (expr_builder): Rename.
9579 (expr_builder::release): Rename.
9580 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9581 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9582 (write_exp_elt_longcst, write_exp_elt_floatcst)
9583 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9584 (write_exp_string_vector, write_exp_bitstring)
9585 (write_exp_msymbol, mark_struct_expression)
9586 (write_dollar_variable)
9587 (insert_type_address_space, increase_expout_size): Replace
9588 "parser_state" with "expr_builder".
9589 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9590 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9591 "parser_state" with "expr_builder".
9592
73923d7e
TT
95932019-04-04 Tom Tromey <tom@tromey.com>
9594
9595 * rust-exp.y: Replace "parse_language" with method call.
9596 * p-exp.y:
9597 (yylex): Replace "parse_language" with method call.
9598 * m2-exp.y:
9599 (yylex): Replace "parse_language" with method call.
9600 * go-exp.y (classify_name): Replace "parse_language" with method
9601 call.
9602 * f-exp.y (yylex): Replace "parse_language" with method call.
9603 * d-exp.y (lex_one_token): Replace "parse_language" with method
9604 call.
9605 * c-exp.y:
9606 (lex_one_token, classify_name, yylex): Replace "parse_language"
9607 with method call.
9608 * ada-exp.y (find_primitive_type, type_char)
9609 (type_system_address): Replace "parse_language" with method call.
9610
fa9f5be6
TT
96112019-04-04 Tom Tromey <tom@tromey.com>
9612
9613 * rust-exp.y: Replace "parse_gdbarch" with method call.
9614 * parse.c (write_dollar_variable, insert_type_address_space):
9615 Replace "parse_gdbarch" with method call.
9616 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9617 call.
9618 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9619 call.
9620 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9621 "parse_gdbarch" with method call.
9622 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9623 with method call.
9624 * f-exp.y (parse_type, parse_f_type, yylex): Replace
9625 "parse_gdbarch" with method call.
9626 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9627 "parse_gdbarch" with method call.
9628 * c-exp.y (parse_type, parse_number, classify_name): Replace
9629 "parse_gdbarch" with method call.
9630 * ada-lex.l: Replace "parse_gdbarch" with method call.
9631 * ada-exp.y (parse_type, find_primitive_type, type_char)
9632 (type_system_address): Replace "parse_gdbarch" with method call.
9633
1201a264
TT
96342019-04-04 Tom Tromey <tom@tromey.com>
9635
9636 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9637 * stap-probe.c (stap_parse_argument): Update.
9638 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9639 initial_size parameter.
9640 * rust-exp.y (rust_lex_tests): Update.
9641 * parse.c (parser_state): Update.
9642 (parse_exp_in_context): Update.
9643 * parser-defs.h (struct parser_state) <parser_state>: Remove
9644 "initial_size" parameter.
9645
e3980ce2
TT
96462019-04-04 Tom Tromey <tom@tromey.com>
9647
9648 * parser-defs.h (increase_expout_size): Don't declare.
9649 * parse.c (increase_expout_size): Now static.
9650
e9f8e3f1
TS
96512019-04-04 Thomas Schwinge <thomas@codesourcery.com>
9652
9653 * gnu-nat.c (gnu_nat_target::wait): Fix
9654 target_waitstatus_to_string call.
9655
d7df6549
AB
96562019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9657
9658 * eval.c (evaluate_subexp_standard): Handle internal functions
9659 during Fortran function call handling.
9660
8bdc1658
AB
96612019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9662
9663 * NEWS: Mention new internal functions.
9664 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9665 (read_base_type): Use dwarf2_init_complex_target_type.
9666 * value.c (creal_internal_fn): New function.
9667 (cimag_internal_fn): New function.
9668 (_initialize_values): Register new internal functions.
9669
c29705b7
PW
96702019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9671
9672 * infrun.c (stop_all_threads): If debug_infrun, always
9673 trace the wait status after wait_one, using
9674 target_waitstatus_to_string and target_pid_to_str.
9675 (handle_inferior_event): Replace various trace of
9676 wait status kind by a single trace.
9677 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9678 wait status kind image by target_waitstatus_to_string.
9679 * target/waitstatus.c (target_waitstatus_to_string): Fix
9680 obsolete comment.
9681
05caa1d2
TT
96822019-04-01 Tom Tromey <tromey@adacore.com>
9683
9684 PR symtab/23331:
9685 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9686
9d1447e0
SDJ
96872019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9688 Pedro Alves <palves@redhat.com>
9689
9690 * top.c (quit_force): Call 'finalize_values'.
9691 * value.c (finalize_values): New function.
9692 * value.h (finalize_values): Declare.
9693
7734102d
EZ
96942019-03-30 Eli Zaretskii <eliz@gnu.org>
9695
9696 * NEWS: Announce $_gdb_major and $_gdb_minor.
9697
9698 * top.c (init_gdb_version_vars): New function.
9699 (gdb_init): Call init_gdb_version_vars.
9700
188e1fa9
TT
97012019-03-29 Tom Tromey <tromey@adacore.com>
9702
9703 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9704 help text. Remove dead code.
9705
2880242d
KS
97062019-03-29 Keith Seitz <keiths@redhat.com>
9707
9708 From Siddhesh Poyarekar:
9709 * f-lang.h (f77_get_upperbound): Return LONGEST.
9710 (f77_get_lowerbound): Likewise.
9711 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9712 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9713 print them.
9714 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9715 plongest to format print it.
9716 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9717 (f77_get_upperbound): Likewise.
9718 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9719 LOWER_BOUND to LONGEST.
9720 (f77_create_arrayprint_offset_tbl): Likewise.
9721
cc1defb1
KS
97222019-03-29 Keith Seitz <keiths@redhat.com>
9723
9724 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9725 %s/pulongest for TYPE_LENGTH instead of %d in format
9726 strings.
9727 * ada-typerint.c (ada_print_type): Likewise.
9728 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9729 * compile/compile-c-support.c (generate_register_struct): Likewise.
9730 * gdbtypes.c (recursive_dump_type): Likewise.
9731 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9732 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9733 instead of %d in format strings.
9734 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9735 to std::min to ULONGEST.
9736 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9737 instead of %d in format strings.
9738 * tracepoint.c (info_scope_command): Likewise.
9739 * typeprint.c (print_offset_data::update)
9740 (print_offset_data::finish): Likewise.
9741 * xtensa-tdep.c (xtensa_store_return_value)
9742 (xtensa_push_dummy_call): Likewise.
9743
e432ccf1
JT
97442019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9745
9746 * windows-nat.c (display_selector): Fixed format specifications
9747 for 64-bit Cygwin.
9748
65d2b333
PW
97492019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9750
9751 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9752
f489207e
SL
97532019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9754
9755 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9756 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9757 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9758 (nios2_linux_init_abi): Install it.
9759
bffa1015
AH
97602019-03-28 Alan Hayward <alan.hayward@arm.com>
9761
9762 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9763
fc96163a
AH
97642019-03-28 Alan Hayward <alan.hayward@arm.com>
9765
9766 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9767
20dc7e9b
PW
97682019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9769 Tom Tromey <tromey@adacore.com>
9770
9771 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9772
7f5331a8
JB
97732019-03-26 Joel Brobecker <brobecker@adacore.com>
9774
9775 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9776 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9777 method to compute the bounds of range types. Also print "[evaluated]"
9778 if the bounds' values come from a dynamic evaluation.
9779
18c77628
AB
97802019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9781
9782 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9783 whitespace when pretty printing is on.
9784
53c973f2
AH
97852019-03-26 Alan Hayward <alan.hayward@arm.com>
9786
e79be6e5 9787 * ppc-linux-nat.c: Add include.
53c973f2 9788
d851aa71
AH
97892019-03-26 Alan Hayward <alan.hayward@arm.com>
9790
e79be6e5 9791 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 9792
2fe7bab7
AH
97932019-03-26 Alan Hayward <alan.hayward@arm.com>
9794
e79be6e5 9795 * arm-linux-nat.c: Add include.
2fe7bab7 9796
068ef30e
SM
97972019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9798
9799 * source-cache.c (source_cache::get_source_lines): Re-read
9800 fullname after calling open_source_file.
9801
81a24d04
JB
98022019-03-25 John Baldwin <jhb@FreeBSD.org>
9803
9804 * NEWS: Mention TLS support for FreeBSD.
9805
79e7ae11
TT
98062019-03-25 Tom Tromey <tromey@adacore.com>
9807
9808 * minsyms.c (BUNCH_SIZE): Update comment.
9809 (~minimal_symbol_reader): Remove old comment.
9810 (compact_minimal_symbols): Update comment.
9811 (minimal_symbol_reader::install): Remove old comment. Update
9812 other comments.
9813
d45963c2
AH
98142019-03-25 Alan Hayward <alan.hayward@arm.com>
9815
9816 * s390-linux-nat.c: Add include.
9817
0f83012e
AH
98182019-03-25 Alan Hayward <alan.hayward@arm.com>
9819
9820 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9821 Call linux_get_hwcap.
9822 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9823 Likewise.
9824 (aarch64_linux_get_hwcap): Remove function.
9825 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9826 declaration.
9827 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9828 linux_get_hwcap.
9829 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9830 * linux-tdep.c (linux_get_hwcap): Add function.
9831 (linux_get_hwcap2): Likewise.
9832 * linux-tdep.h (linux_get_hwcap): Add declaration.
9833 (linux_get_hwcap2): Likewise.
9834 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9835 (ppc_linux_get_hwcap2): Likewise.
9836 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9837 linux_get_hwcap.
9838 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9839 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9840 (ppc_linux_nat_target::read_description): Likewise.
9841 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9842 * s390-linux-nat.c: Likewise.
9843 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9844
6640a367
TT
98452019-03-24 Tom Tromey <tom@tromey.com>
9846
9847 * ada-lang.c (standard_lookup): Simplify initialization.
9848 (ada_lookup_symbol_nonlocal): Simplify return.
9849 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9850 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9851 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9852 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9853 initialization.
9854 * solib.c (solib_global_lookup): Simplify.
9855 * symtab.c (null_block_symbol): Remove.
9856 (symbol_cache_lookup): Simplify returns.
9857 (lookup_language_this): Simplify returns.
9858 (lookup_symbol_aux): Simplify return.
9859 (lookup_local_symbol): Simplify returns.
9860 (lookup_global_symbol_from_objfile): Simplify return.
9861 (lookup_symbol_in_objfile_symtabs)
9862 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9863 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9864 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9865 * cp-namespace.c (cp_lookup_bare_symbol)
9866 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9867 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9868 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9869 (cp_lookup_symbol_via_imports): Simplify initialization.
9870 (find_symbol_in_baseclass): Likewise.
9871 * symtab.h (null_block_symbol): Remove.
9872 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9873 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9874 (d_lookup_symbol_module): Likewise.
9875 (find_symbol_in_baseclass): Simplify initialization.
9876
a930ebcd
TT
98772019-03-24 Tom Tromey <tom@tromey.com>
9878
9879 * expression.h: Don't include symtab.h.
9880 (struct block): Forward declare.
9881
582942f4
TT
98822019-03-24 Tom Tromey <tom@tromey.com>
9883
9884 * c-exp.y (typebase): Remove casts.
9885 * gdbtypes.c (lookup_unsigned_typename, )
9886 (lookup_signed_typename): Remove cast.
9887 * eval.c (parse_to_comma_and_eval): Remove cast.
9888 * parse.c (write_dollar_variable): Remove cast.
9889 * block.h (struct block) <superblock>: Now const.
9890 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9891 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9892 (map_block): Make "block" const.
9893 * symfile.h (struct quick_symbol_functions)
9894 <map_matching_symbols>: Constify block argument to "callback".
9895 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9896 const.
9897 (find_pc_sect_compunit_symtab): Make "b" const.
9898 (find_symbol_at_address): Likewise.
9899 (search_symbols): Likewise.
9900 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9901 (dw2_debug_names_lookup_symbol): Likewise.
9902 (dw2_map_matching_symbols): Update.
9903 * p-valprint.c (pascal_val_print): Remove "block".
9904 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9905 (aux_add_nonlocal_symbols): Make "block" const.
9906 (resolve_subexp): Remove cast.
9907 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9908 const.
9909 (iterate_over_file_blocks): Likewise.
9910 * f-exp.y (%union) <bval>: Remove.
9911 * coffread.c (patch_opaque_types): Make "b" const.
9912 * spu-tdep.c (spu_catch_start): Make "block" const.
9913 * c-valprint.c (print_unpacked_pointer): Remove "block".
9914 * symmisc.c (dump_symtab_1): Make "b" const.
9915 (block_depth): Make "block" const.
9916 * d-exp.y (%union) <bval>: Remove.
9917 * cp-support.h (cp_lookup_rtti_type): Update.
9918 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9919 * psymtab.c (psym_lookup_symbol): Make "block" const.
9920 (maintenance_check_psymtabs): Make "b" const.
9921 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9922 (enumerate_locals, enumerate_args): Update.
9923 * python/py-symtab.c (stpy_global_block): Make "block" const.
9924 (stpy_static_block): Likewise.
9925 * inline-frame.c (block_starting_point_at): Make "new_block"
9926 const.
9927 * block.c (find_block_in_blockvector): Make return type const.
9928 (blockvector_for_pc_sect): Make "b" const.
9929 (find_block_in_blockvector): Make "b" const.
9930
7ad417dd
TT
99312019-03-23 Tom Tromey <tom@tromey.com>
9932
9933 * varobj.c (varobj_create): Update.
9934 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9935 * printcmd.c (display_command, do_one_display): Don't reset
9936 innermost_block.
9937 * parser-defs.h (enum innermost_block_tracker_type): Move to
9938 expression.h.
9939 (innermost_block): Update comment.
9940 * parse.c (parse_exp_1): Add tracker_types parameter.
9941 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9942 tracker_types parameter. Reset innermost_block.
9943 (parse_exp_in_context): Remove.
9944 (parse_expression_for_completion): Update.
9945 * objfiles.c (~objfile): Don't reset expression_context_block or
9946 innermost_block.
9947 * expression.h (enum innermost_block_tracker_type): Move from
9948 parser-defs.h.
9949 (parse_exp_1): Add tracker_types parameter.
9950 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9951 reset innermost_block.
9952
b366c208
TT
99532019-03-23 Tom Tromey <tom@tromey.com>
9954
9955 * objfiles.h: Include bcache.h.
9956
9bb9b2f9
TT
99572019-03-23 Tom Tromey <tom@tromey.com>
9958
9959 * linespec.c (get_current_search_block): Use
9960 scoped_restore_current_language.
9961 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9962
59c28372
AH
99632019-03-22 Alan Hayward <alan.hayward@arm.com>
9964 Jiong Wang <jiong.wang@arm.com>
9965
9966 * aarch64-linux-tdep.c
9967 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9968 section.
9969 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9970
17e116a7
AH
99712019-03-22 Alan Hayward <alan.hayward@arm.com>
9972 Jiong Wang <jiong.wang@arm.com>
9973
9974 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9975 instructions.
9976 (aarch64_analyze_prologue_test): Add PACIASP test.
9977 (aarch64_prologue_prev_register): Unmask PC value.
9978
11e1b75f
AH
99792019-03-22 Alan Hayward <alan.hayward@arm.com>
9980 Jiong Wang <jiong.wang@arm.com>
9981
9982 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9983 (aarch64_dwarf2_prev_register): Unmask PC value.
9984 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9985 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9986 DW_CFA_AARCH64_negate_ra_state.
9987 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9988
34dcc7cf
AH
99892019-03-22 Alan Hayward <alan.hayward@arm.com>
9990 Jiong Wang <jiong.wang@arm.com>
9991
9992 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9993 registers.
9994 (aarch64_pseudo_register_name): Likewise.
9995 (aarch64_pseudo_register_type): Likewise.
9996 (aarch64_pseudo_register_reggroup_p): Likewise.
9997 (aarch64_gdbarch_init): Add pauth registers.
9998 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9999 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10000 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10001 (struct gdbarch_tdep): Add regnum for ra_state.
10002
1ef53e6b
AH
100032019-03-22 Alan Hayward <alan.hayward@arm.com>
10004 Jiong Wang <jiong.wang@arm.com>
10005
10006 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10007
76bed0fd
AH
100082019-03-22 Alan Hayward <alan.hayward@arm.com>
10009 Jiong Wang <jiong.wang@arm.com>
10010
10011 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10012 function.
10013 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10014 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10015 (aarch64_gdbarch_init): Add puth registers.
10016 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10017 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10018 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10019
ee4fbcfa
AH
100202019-03-22 Alan Hayward <alan.hayward@arm.com>
10021 Jiong Wang <jiong.wang@arm.com>
10022
10023 * aarch64-linux-nat.c
10024 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10025 * aarch64-linux-tdep.c
10026 (aarch64_linux_core_read_description): Likewise.
10027 (aarch64_linux_get_hwcap): New function.
10028 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10029 (aarch64_linux_get_hwcap): New declaration.
10030
6dc0ebde
AH
100312019-03-22 Alan Hayward <alan.hayward@arm.com>
10032 Jiong Wang <jiong.wang@arm.com>
10033
10034 * aarch64-linux-nat.c
10035 (aarch64_linux_nat_target::read_description): Add pauth param.
10036 * aarch64-linux-tdep.c
10037 (aarch64_linux_core_read_description): Likewise.
10038 * aarch64-tdep.c (struct target_desc): Add in pauth.
10039 (aarch64_read_description): Add pauth param.
10040 (aarch64_gdbarch_init): Likewise.
10041 * aarch64-tdep.h (aarch64_read_description): Likewise.
10042 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10043 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10044 * features/Makefile: Add new files.
10045 * features/aarch64-pauth.c: New file.
10046 * features/aarch64-pauth.xml: New file.
10047
595915c1
TT
100482019-03-20 Tom Tromey <tromey@adacore.com>
10049
10050 * infrun.c (handle_inferior_event): Rename from
10051 handle_inferior_event_1. Create a scoped_value_mark.
10052 (handle_inferior_event): Remove.
10053
4c7d57e7
TT
100542019-03-19 Tom Tromey <tromey@adacore.com>
10055
10056 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10057 * infrun.h (print_stop_event): Add "displays" parameter.
10058 * infrun.c (print_stop_event): Add "displays" parameter.
10059
cb246234
PA
100602019-03-19 Pedro Alves <palves@redhat.com>
10061
10062 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10063 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10064 to -1. Fix TABs vs spaces.
10065 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10066 * tui/tui-out.h (tui_ui_out) Add intro comments.
10067 <m_line, m_start_of_line>: In-class initialize, and add describing
10068 comment.
10069
3a0e45b2
AH
100702019-03-18 Alan Hayward <alan.hayward@arm.com>
10071
10072 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10073 variable names.
10074 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10075
5371b850
PA
100762019-03-18 Pedro Alves <palves@redhat.com>
10077 Eli Zaretskii <eliz@gnu.org>
10078
10079 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10080 m_line and m_start_of_line.
10081
b17c4cd0
EZ
100822019-03-18 Eli Zaretskii <eliz@gnu.org>
10083
10084 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10085 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10086 it returns a newline. This fixes a regression in TU mode, whereby
10087 the next line is output on the same screen line as the user input.
10088
4bd56d18
TT
100892019-03-18 Tom Tromey <tromey@adacore.com>
10090
10091 * minsyms.c (minimal_symbol_reader::install): Remove call to
10092 obstack_blank.
10093
55c10aca
PA
100942019-03-18 Pedro Alves <palves@redhat.com>
10095
10096 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10097 New globals.
10098 (apply_style): New, factored out from ...
10099 (apply_ansi_escape): ... this. Handle reverse video mode.
10100 (tui_set_reverse_mode): New function.
10101 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10102 * tui/tui-winsource.c (tui_show_source_line): Use
10103 tui_set_reverse_mode instead of setting A_STANDOUT.
10104 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10105 New setter methods.
10106
647bb750
HD
101072019-03-18 Hannes Domani <ssbssa@yahoo.de>
10108
10109 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10110 Handle tabs.
10111
bff8c71f
TT
101122019-03-18 Tom Tromey <tromey@adacore.com>
10113
10114 * ada-lang.c (empty_array): Add "high" parameter.
10115 (ada_evaluate_subexp): Update.
10116
58785d98
ST
101172019-03-17 Sergei Trofimovich <siarheit@google.com>
10118
10119 * unittests/string_view-selftests.c: Define
10120 _initialize_string_view_selftests unconditionally.
10121
d4cbef22
ВМ
101222019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10123
10124 PR gdb/24350
10125 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10126
fce4c071
ВМ
101272019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10128
10129 PR gdb/24351
10130 * windows-nat.c (display_selector): Fix format specifiers.
10131
f7f0a123
EZ
101322019-03-17 Eli Zaretskii <eliz@gnu.org>
10133
10134 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10135 tui_refill_source_window instead of tui_refresh_win, to update the
10136 current execution line. This fixes redisplay of the current line
10137 when stepping through the code with "next" or "step".
10138
ab42892f
EZ
101392019-03-16 Eli Zaretskii <eliz@gnu.org>
10140
10141 * source-cache.c (source_cache::get_source_lines): Call
10142 find_source_lines to initialize s->nlines. This fixes vertical
10143 scrolling of TUI source window when the DOWN arrow is pressed.
10144
8d8c087f
PW
101452019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10146
10147 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10148 linux-thread-db.c (_initialize_thread_db): Likewise.
10149
798e1c30
EZ
101502019-03-16 Eli Zaretskii <eliz@gnu.org>
10151
10152 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10153 wclrtoeol in tui_show_source_line". This reverts changes made in
10154 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10155
eefba3da
TT
101562019-03-15 Tom Tromey <tom@tromey.com>
10157
10158 * symtab.h (struct minimal_symbol): Derive from
10159 general_symbol_info.
10160 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10161 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10162 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10163 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10164 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10165 (MSYMBOL_SEARCH_NAME): Update.
10166 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10167 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10168 * minsyms.c (minimal_symbol_reader::record_full): Update.
10169
0de2420c
TT
101702019-03-15 Tom Tromey <tom@tromey.com>
10171
10172 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10173
042d75e4
TT
101742019-03-15 Tom Tromey <tom@tromey.com>
10175
10176 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10177 unique_xmalloc_ptr.
10178 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10179 Update.
10180 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10181 (build_minimal_symbol_hash_tables)
10182 (minimal_symbol_reader::install): Update.
10183
db92718b
TT
101842019-03-15 Tom Tromey <tom@tromey.com>
10185
10186 * symtab.c (create_demangled_names_hash): Update.
10187 (symbol_set_names): Update.
10188 * objfiles.h (struct objfile_per_bfd_storage)
10189 <demangled_names_hash>: Now an htab_up.
10190 * objfiles.c (objfile_per_bfd_storage): Simplify.
10191
d6797f46
TT
101922019-03-15 Tom Tromey <tom@tromey.com>
10193
10194 * objfiles.h (struct objfile_per_bfd_storage): Declare
10195 destructor.
10196 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10197 New.
10198 (get_objfile_bfd_data): Use new. Don't initialize
10199 language_of_main.
10200 (free_objfile_per_bfd_storage): Remove.
10201 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10202
741d7538
TT
102032019-03-15 Tom Tromey <tom@tromey.com>
10204
10205 * symfile.c (reread_symbols): Update.
10206 * objfiles.c (objfile::objfile): Update.
10207 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10208 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10209 comment.
10210 (minimal_symbol_reader::install): Update.
10211 (terminate_minimal_symbol_table): Remove.
10212 * jit.c (jit_object_close_impl): Update.
10213
788c80d1
TT
102142019-03-15 Tom Tromey <tom@tromey.com>
10215
10216 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10217 initializations.
10218
1b7a07cb
TT
102192019-03-15 Tom Tromey <tom@tromey.com>
10220
10221 * objfiles.h (struct objfile_per_bfd_storage)
10222 <demangled_hash_languages>: Now a bitset.
10223 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10224 (lookup_minimal_symbol): Update.
10225
3db066bc
TT
102262019-03-15 Tom Tromey <tom@tromey.com>
10227
10228 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10229 Don't return the symbol.
10230 * coffread.c (record_minimal_symbol): Use record_full.
10231
3fff2c37
EZ
102322019-03-14 Eli Zaretskii <eliz@gnu.org>
10233
10234 The MS-Windows port of ncurses fails to switch to a color pair if
10235 one or both of the colors are the implicit default colors. This
10236 change records the default colors when TUI is initialized, and
10237 then specifies them explicitly when a color pair uses the default
10238 colors. This allows color styling in TUI mode on MS-Windows.
10239
10240 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10241 ncurses_norm_attr.
10242 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10243 colors in ncurses_norm_attr.
10244 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10245 "none", replace it with the default color recorded in
10246 ncurses_norm_attr.
10247
3b336828
TT
102482019-03-14 Tom Tromey <tromey@adacore.com>
10249
10250 * source-cache.h (class source_cache) <get_source_lines>: Return
10251 std::string.
10252 * source-cache.c (source_cache::extract_lines): Handle case where
10253 first_pos==npos. Return std::string.
10254 (source_cache::get_source_lines): Update.
10255
d085f989
TT
102562019-03-14 Tom Tromey <tromey@adacore.com>
10257
10258 * NEWS: Add item for "style sources" commands.
10259 * source-cache.c (source_cache::get_source_lines): Check
10260 source_styling.
10261 * cli/cli-style.c (source_styling): New global.
10262 (_initialize_cli_style): Add "style sources" commands.
10263 (show_style_sources): New function.
10264 * cli/cli-style.h (source_styling): Declare.
10265
6f11e682
TT
102662019-03-14 Pedro Alves <palves@redhat.com>
10267 Tom Tromey <tromey@adacore.com>
10268
10269 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10270 * tui/tui-winsource.c (tui_refill_source_window): New function,
10271 from...
10272 (tui_horizontal_source_scroll): ... here. Move some logic.
10273 * cli/cli-style.c (set_style_enabled): Notify new observable.
10274 * tui/tui-hooks.c (tui_redisplay_source): New function.
10275 (tui_attach_detach_observers): Attach or detach
10276 tui_redisplay_source.
10277 * observable.h (source_styling_changed): New observable.
10278 * observable.c: Define source_styling_changed observable.
10279
a068643d
TT
102802019-03-13 Tom Tromey <tromey@adacore.com>
10281
10282 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10283 (i386_gnu_nat_target::store_registers): Update.
10284 * target-debug.h (target_debug_print_std_string): New macro.
10285 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10286 * windows-tdep.c (display_one_tib): Update.
10287 * tui/tui-stack.c (tui_make_status_line): Update.
10288 * top.c (print_inferior_quit_action): Update.
10289 * thread.c (thr_try_catch_cmd): Update.
10290 (add_thread_with_info): Update.
10291 (thread_target_id_str): Update.
10292 (thr_try_catch_cmd): Update.
10293 (thread_command): Update.
10294 (thread_find_command): Update.
10295 * record-btrace.c (record_btrace_target::info_record)
10296 (record_btrace_resume_thread, record_btrace_target::resume)
10297 (record_btrace_cancel_resume, record_btrace_step_thread)
10298 (record_btrace_target::wait, record_btrace_target::wait)
10299 (record_btrace_target::wait, record_btrace_target::stop): Update.
10300 * progspace.c (print_program_space): Update.
10301 * process-stratum-target.c
10302 (process_stratum_target::thread_address_space): Update.
10303 * linux-fork.c (linux_fork_mourn_inferior)
10304 (detach_checkpoint_command, info_checkpoints_command)
10305 (linux_fork_context): Update.
10306 (linux_fork_detach): Update.
10307 (class scoped_switch_fork_info): Update.
10308 (delete_checkpoint_command): Update.
10309 * infrun.c (follow_fork_inferior): Update.
10310 (follow_fork_inferior): Update.
10311 (proceed_after_vfork_done): Update.
10312 (handle_vfork_child_exec_or_exit): Update.
10313 (follow_exec): Update.
10314 (displaced_step_prepare_throw): Update.
10315 (displaced_step_restore): Update.
10316 (start_step_over): Update.
10317 (resume_1): Update.
10318 (clear_proceed_status_thread): Update.
10319 (proceed): Update.
10320 (print_target_wait_results): Update.
10321 (do_target_wait): Update.
10322 (context_switch): Update.
10323 (stop_all_threads): Update.
10324 (restart_threads): Update.
10325 (finish_step_over): Update.
10326 (handle_signal_stop): Update.
10327 (switch_back_to_stepped_thread): Update.
10328 (keep_going_pass_signal): Update.
10329 (print_exited_reason): Update.
10330 (normal_stop): Update.
10331 * inferior.c (inferior_pid_to_str): Change return type.
10332 (print_selected_inferior): Update.
10333 (add_inferior): Update.
10334 (detach_inferior): Update.
10335 * dummy-frame.c (fprint_dummy_frames): Update.
10336 * dcache.c (dcache_info_1): Update.
10337 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10338 (btrace_fetch, btrace_clear): Update.
10339 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10340 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10341 type.
10342 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10343 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10344 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10345 * gdbarch.c, gdbarch.h: Rebuild.
10346 * gdbarch.sh (core_pid_to_str): Change return type.
10347 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10348 return type.
10349 (windows_nat_target::pid_to_str): Change return type.
10350 (windows_delete_thread): Update.
10351 (windows_nat_target::attach): Update.
10352 (windows_nat_target::files_info): Update.
10353 * target-delegates.c: Rebuild.
10354 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10355 return type.
10356 (sol_thread_target::pid_to_str): Change return type.
10357 * remote.c (class remote_target) <pid_to_str>: Change return
10358 type.
10359 (remote_target::pid_to_str): Change return type.
10360 (extended_remote_target::attach, remote_target::remote_stop_ns)
10361 (remote_target::remote_notif_remove_queued_reply)
10362 (remote_target::push_stop_reply, remote_target::disable_btrace):
10363 Update.
10364 (extended_remote_target::attach): Update.
10365 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10366 type.
10367 (gdbsim_target::pid_to_str): Change return type.
10368 * ravenscar-thread.c (struct ravenscar_thread_target)
10369 <pid_to_str>: Change return type.
10370 (ravenscar_thread_target::pid_to_str): Change return type.
10371 * procfs.c (class procfs_target) <pid_to_str>: Change return
10372 type.
10373 (procfs_target::pid_to_str): Change return type.
10374 (procfs_target::attach): Update.
10375 (procfs_target::detach): Update.
10376 (procfs_target::fetch_registers): Update.
10377 (procfs_target::store_registers): Update.
10378 (procfs_target::wait): Update.
10379 (procfs_target::files_info): Update.
10380 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10381 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10382 return type.
10383 (nto_procfs_target::pid_to_str): Change return type.
10384 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10385 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10386 return type.
10387 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10388 (exit_lwp): Update.
10389 (attach_proc_task_lwp_callback, get_detach_signal)
10390 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10391 (linux_nat_target::resume, wait_lwp, stop_callback)
10392 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10393 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10394 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10395 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10396 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10397 type.
10398 (inf_ptrace_target::attach): Update.
10399 (inf_ptrace_target::files_info): Update.
10400 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10401 type.
10402 (go32_nat_target::pid_to_str): Change return type.
10403 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10404 (gnu_nat_target::wait): Update.
10405 (gnu_nat_target::wait): Update.
10406 (gnu_nat_target::resume): Update.
10407 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10408 (fbsd_nat_target::wait): Update.
10409 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10410 type.
10411 (darwin_nat_target::attach): Update.
10412 * corelow.c (class core_target) <pid_to_str>: Change return type.
10413 (core_target::pid_to_str): Change return type.
10414 * target.c (normal_pid_to_str): Change return type.
10415 (default_pid_to_str): Likewise.
10416 (target_pid_to_str): Change return type.
10417 (target_translate_tls_address): Update.
10418 (target_announce_detach): Update.
10419 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10420 return type.
10421 (bsd_uthread_target::pid_to_str): Change return type.
10422 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10423 type.
10424 (bsd_kvm_target::pid_to_str): Change return type.
10425 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10426 return type.
10427 (aix_thread_target::pid_to_str): Change return type.
10428 * target.h (struct target_ops) <pid_to_str>: Change return type.
10429 (target_pid_to_str, normal_pid_to_str): Likewise.
10430 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10431 type.
10432 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10433 type.
10434 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10435 return type.
10436 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10437 type.
10438 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10439 type.
10440 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10441 return type.
10442
b4be1b06
SM
104432019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10444
10445 * NEWS: Mention that the new default MI version is 3. Mention
10446 changes to the output of commands and events that deal with
10447 multi-location breakpoints.
10448 * breakpoint.c: Include "mi/mi-out.h".
10449 (print_one_breakpoint): Change output syntax if using MI version
10450 >= 3.
10451 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10452 New.
10453 (mi_multi_location_breakpoint_output_fixed): New.
10454 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10455 (mi_cmd_fix_multi_location_breakpoint_output): New.
10456 (mi_multi_location_breakpoint_output_fixed): New.
10457 * mi/mi-cmds.c (mi_cmds): Register command
10458 -fix-multi-location-breakpoint-output.
10459 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10460 interpreter "mi".
10461
8e5e5494
SM
104622019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10463
10464 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10465 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10466 instantiate mi_ui_out based on interpreter name.
10467 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10468 * mi/mi-main.c (mi_load_progress): Likewise.
10469
197df35e
JB
104702019-03-12 John Baldwin <jhb@FreeBSD.org>
10471
10472 * NEWS: Combine separate "New targets" sections for 8.3.
10473
8399425f
JB
104742019-03-12 John Baldwin <jhb@FreeBSD.org>
10475
10476 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10477 (ppcfbsd_init_abi): Install gdbarch
10478 "fetch_tls_load_module_address" and "get_thread_local_address"
10479 methods.
10480
b0f87ed0
JB
104812019-03-12 John Baldwin <jhb@FreeBSD.org>
10482
10483 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10484 (riscv_fbsd_init_abi): Install gdbarch
10485 "fetch_tls_load_module_address" and "get_thread_local_address"
10486 methods.
10487
ce25aa57
JB
104882019-03-12 John Baldwin <jhb@FreeBSD.org>
10489
10490 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10491 (i386fbsd_init_abi): Install gdbarch
10492 "fetch_tls_load_module_address" and "get_thread_local_address"
10493 methods.
10494
f5424cfa
JB
104952019-03-12 John Baldwin <jhb@FreeBSD.org>
10496
10497 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10498 (amd64fbsd_init_abi): Install gdbarch
10499 "fetch_tls_load_module_address" and "get_thread_local_address"
10500 methods.
10501
945f3901
JB
105022019-03-12 John Baldwin <jhb@FreeBSD.org>
10503
10504 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10505 (struct fbsd_pspace_data): New type.
10506 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10507 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10508 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10509 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10510 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10511
ef0bd204
JB
105122019-03-12 John Baldwin <jhb@FreeBSD.org>
10513
10514 * gdbtypes.c (lookup_struct_elt): New function.
10515 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10516 * gdbtypes.h (struct struct_elt): New type.
10517 (lookup_struct_elt): New prototype.
10518
36c53a02
JB
105192019-03-12 John Baldwin <jhb@FreeBSD.org>
10520
10521 * gdbtypes.c (lookup_struct_elt_type): Update comment and
10522 remove disabled code block.
10523
6e056c81
JB
105242019-03-12 John Baldwin <jhb@FreeBSD.org>
10525
10526 * gdbarch.sh (get_thread_local_address): New method.
10527 * gdbarch.h, gdbarch.c: Regenerate.
10528 * target.c (target_translate_tls_address): Use
10529 gdbarch_get_thread_local_address if present instead of
10530 target::get_thread_local_address.
10531
cd250a18
JB
105322019-03-12 John Baldwin <jhb@FreeBSD.org>
10533
10534 * target.h (target::get_thread_local_address): Update comment.
10535
df22c1e5
JB
105362019-03-12 John Baldwin <jhb@FreeBSD.org>
10537
10538 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10539 objfile->separate_debug_objfile_backlink if not NULL.
10540
dd6876c9
JB
105412019-03-12 John Baldwin <jhb@FreeBSD.org>
10542
10543 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10544 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10545 (amd64bsd_store_inferior_registers): Likewise.
10546 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10547 Enable segment base registers.
10548 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10549 PT_GETFSBASE and PT_GETGSBASE.
10550 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10551 PT_SETGSBASE.
10552 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10553 segment base registers.
10554 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10555
1163a4b7
JB
105562019-03-12 John Baldwin <jhb@FreeBSD.org>
10557
10558 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10559 Update calls to i386_target_description to add 'segments'
10560 parameter.
10561 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
10562 add segment base registers.
10563 * arch/i386.c (i386_create_target_description): Add 'segments'
10564 parameter to enable segment base registers.
10565 * arch/i386.h (i386_create_target_description): Likewise.
10566 * features/i386/32bit-segments.xml: New file.
10567 * features/i386/32bit-segments.c: Generate.
10568 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10569 call to i386_target_description to add 'segments' parameter.
10570 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10571 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10572 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10573 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10574 if feature is present.
10575 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10576 Add 'segments' parameter to call to i386_target_description.
10577 (i386_target_description): Add 'segments' parameter to enable
10578 segment base registers.
10579 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10580 to call to i386_target_description.
10581 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10582 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10583 Define I386_NUM_REGS.
10584 (i386_target_description): Add 'segments' parameter to enable
10585 segment base registers.
10586
3a350822
EZ
105872019-03-12 Eli Zaretskii <eliz@gnu.org>
10588
10589 PR/24325
10590 * source-cache.c: #undef open and close, to avoid unresolved
10591 externals during linking.
10592
ffdd69cf
TT
105932019-03-12 Tom Tromey <tromey@adacore.com>
10594
10595 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10596 const. Add initializers.
10597 (_initialize_remote): Don't initialize ptid globals.
10598
ec148c57
PA
105992019-03-12 Pedro Alves <palves@redhat.com>
10600
10601 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10602
32764270
PA
106032019-03-12 Pedro Alves <palves@redhat.com>
10604
10605 * cp-name-parser.y (main): Remove unused 'len' variable.
10606
17547186
TT
106072019-03-12 Tom Tromey <tromey@adacore.com>
10608
10609 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10610 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10611
d3a70e03
TT
106122019-03-12 Tom Tromey <tromey@adacore.com>
10613
10614 * linux-nat.c (iterate_over_lwps): Update.
10615 (stop_callback): Remove parameter.
10616 (stop_wait_callback, detach_callback, resume_set_callback)
10617 (select_singlestep_lwp_callback, set_ignore_sigint)
10618 (status_callback, resumed_callback, resume_clear_callback)
10619 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10620 data parameter.
10621 (linux_nat_target::detach, linux_nat_target::resume)
10622 (linux_stop_and_wait_all_lwps, select_event_lwp)
10623 (linux_nat_filter_event, linux_nat_wait_1)
10624 (linux_nat_target::kill, linux_nat_target::stop)
10625 (linux_nat_target::stop): Update.
10626 (linux_nat_resume_callback): Change type.
10627 (resume_stopped_resumed_lwps, count_events_callback)
10628 (select_event_lwp_callback): Likewise.
10629 (linux_stop_lwp, linux_nat_stop_lwp): Update.
10630 * arm-linux-nat.c (struct update_registers_data): Remove.
10631 (update_registers_callback): Change type.
10632 (arm_linux_insert_hw_breakpoint1): Update.
10633 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10634 parameter.
10635 (x86_linux_dr_set_addr): Update.
10636 (x86_linux_dr_set_control): Update.
10637 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10638 (iterate_over_lwps): Use gdb::function_view.
10639 * nat/aarch64-linux-hw-point.c (struct
10640 aarch64_dr_update_callback_param): Remove.
10641 (debug_reg_change_callback): Change type.
10642 (aarch64_notify_debug_reg_change): Update.
10643 * s390-linux-nat.c (s390_refresh_per_info): Update.
10644
82cb27ff
TT
106452019-03-11 Tom Tromey <tromey@adacore.com>
10646
10647 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10648 redundant assignment to "this_cu".
10649
568c0683
SM
106502019-03-08 Simon Marchi <simon.marchi@efficios.com>
10651
10652 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10653
f09ce22d
SM
106542019-03-08 Simon Marchi <simon.marchi@efficios.com>
10655
10656 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10657 from...
10658 (rank_one_type): ... this.
10659
595f96a9
SM
106602019-03-08 Simon Marchi <simon.marchi@efficios.com>
10661
10662 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10663 from...
10664 (rank_one_type): ... this.
10665
2598a94b
SM
106662019-03-08 Simon Marchi <simon.marchi@efficios.com>
10667
10668 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10669 from...
10670 (rank_one_type): ... this.
10671
7f17b20d
SM
106722019-03-08 Simon Marchi <simon.marchi@efficios.com>
10673
10674 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10675 from...
10676 (rank_one_type): ... this.
10677
2c509035
SM
106782019-03-08 Simon Marchi <simon.marchi@efficios.com>
10679
10680 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10681 from...
10682 (rank_one_type): ... this.
10683
0dd322dc
SM
106842019-03-08 Simon Marchi <simon.marchi@efficios.com>
10685
10686 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10687 from...
10688 (rank_one_type): ... this.
10689
41ea4728
SM
106902019-03-08 Simon Marchi <simon.marchi@efficios.com>
10691
10692 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10693 from...
10694 (rank_one_type): ... this.
10695
793cd1d2
SM
106962019-03-08 Simon Marchi <simon.marchi@efficios.com>
10697
10698 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10699 from...
10700 (rank_one_type): ... this.
10701
34910087
SM
107022019-03-08 Simon Marchi <simon.marchi@efficios.com>
10703
10704 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10705 from...
10706 (rank_one_type): ... this.
10707
f1f832d6
SM
107082019-03-08 Simon Marchi <simon.marchi@efficios.com>
10709
10710 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10711 from...
10712 (rank_one_type): ... this.
10713
b9f4512f
SM
107142019-03-08 Simon Marchi <simon.marchi@efficios.com>
10715
10716 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10717 from...
10718 (rank_one_type): ... this.
10719
9293fc63
SM
107202019-03-08 Simon Marchi <simon.marchi@efficios.com>
10721
10722 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10723 from...
10724 (rank_one_type): ... this.
10725
e3abbe7e
PW
107262019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10727
10728 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10729 inferior-events' shows the example events.
10730
e4adb939
EZ
107312019-03-08 Eli Zaretskii <eliz@gnu.org>
10732
10733 Support styling on native MS-Windows console
10734
10735 PR/24315
10736 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10737 on MS-Windows if $TERM is not defined.
10738
10739 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10740
10741 * posix-hdep.c (gdb_console_fputs):
10742 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10743 functions.
10744 * ui-file.h (gdb_console_fputs): Add prototype.
10745
10746 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10747 back to fputs only if the former returns zero.
10748
25629dfd
TT
107492019-03-07 Tom Tromey <tom@tromey.com>
10750
10751 * symmisc.c (print_symbol_bcache_statistics): Update.
10752 (print_objfile_statistics): Update.
10753 * symfile.c (allocate_symtab): Update.
10754 * stabsread.c: Don't include bcache.h.
10755 * psymtab.h (struct psymbol_bcache): Don't declare.
10756 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10757 (psymbol_bcache_init, psymbol_bcache_free)
10758 (psymbol_bcache_get_bcache): Don't declare.
10759 * psymtab.c (struct psymbol_bcache): Remove.
10760 (psymtab_storage::psymtab_storage): Update.
10761 (psymtab_storage::~psymtab_storage): Update.
10762 (psymbol_bcache_init, psymbol_bcache_free)
10763 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10764 (add_psymbol_to_bcache): Update.
10765 (allocate_psymtab): Update.
10766 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10767 macro_cache>: No longer pointers.
10768 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10769 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10770 * macrotab.c (macro_bcache): Update.
10771 * macroexp.c: Don't include bcache.h.
10772 * gdbtypes.c (check_types_worklist): Update.
10773 (types_deeply_equal): Remove TRY/CATCH. Update.
10774 * elfread.c (elf_symtab_read): Update.
10775 * dwarf2read.c: Don't include bcache.h.
10776 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10777 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10778 (print_bcache_statistics, bcache_memory_used): Don't declare.
10779 (struct bcache): Move from bcache.c. Add constructor, destructor,
10780 methods. Rename all data members.
10781 * bcache.c (struct bcache): Move to bcache.h.
10782 (bcache::expand_hash_table): Rename from expand_hash_table.
10783 (bcache): Remove.
10784 (bcache::insert): Rename from bcache_full.
10785 (bcache::compare): Rename from bcache_compare.
10786 (bcache_xmalloc): Remove.
10787 (bcache::~bcache): Rename from bcache_xfree.
10788 (bcache::print_statistics): Rename from print_bcache_statistics.
10789 (bcache::memory_used): Rename from bcache_memory_used.
10790
fe726667
PA
107912019-03-07 Pedro Alves <palves@redhat.com>
10792
10793 * infrun.c (normal_stop): Also check for
10794 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10795
7584bb30
AB
107962019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10797
10798 * f-lang.c (value_from_host_double): Moved to...
10799 * value.c (value_from_host_double): ...here.
10800 * value.h (value_from_host_double): Declare.
10801 * guile/scm-math.c (vlscm_convert_typed_number): Use
10802 value_from_host_double.
10803 (vlscm_convert_number): Likewise.
10804 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10805 * python/py-value.c (convert_value_from_python): Likewise.
10806
a7b1986e
TT
108072019-03-06 Tom Tromey <tom@tromey.com>
10808
10809 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10810
0ccf4211
TT
108112019-03-06 Tom Tromey <tom@tromey.com>
10812
10813 * utils.h (free_current_contents): Don't declare.
10814 * utils.c (free_current_contents): Remove.
10815
fe7b42e5
TT
108162019-03-06 Tom Tromey <tom@tromey.com>
10817
10818 * top.c (quit_force): Update.
10819 * main.c (captured_command_loop): Update.
10820 * common/new-op.c (operator new): Update.
10821 * common/common-exceptions.c (struct catcher)
10822 <save_cleanup_chain>: Remove member.
10823 (exceptions_state_mc_init): Update.
10824 (exception_try_scope_entry): Return nullptr.
10825 (exception_try_scope_exit, exception_rethrow)
10826 (throw_exception_sjlj, throw_exception_cxx): Update.
10827 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10828 (all_cleanups, do_cleanups, discard_cleanups)
10829 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10830 (restore_cleanups, restore_final_cleanups): Don't declare.
10831 (do_final_cleanups): Remove parameter.
10832 * common/cleanups.c (cleanup_chain, make_cleanup)
10833 (make_cleanup_dtor, all_cleanups, do_cleanups)
10834 (discard_my_cleanups, discard_cleanups)
10835 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10836 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10837 (null_cleanup): Remove.
10838 (do_final_cleanups): Remove parameter.
10839
c6321f19
TT
108402019-03-06 Tom Tromey <tom@tromey.com>
10841
10842 * remote.c (remote_target::remote_parse_stop_reply): Use
10843 unique_xmalloc_ptr.
10844
61b30099
TT
108452019-03-06 Tom Tromey <tom@tromey.com>
10846
10847 * stabsread.c (struct stabs_field_info): Rename from field_info.
10848 <list, fnlist>: Add initializers.
10849 <obstack>: New member.
10850 (read_member_functions, read_struct_fields, read_baseclasses):
10851 Allocate on obstack. Don't use cleanups.
10852 (read_one_struct_field, read_member_functions, read_struct_fields)
10853 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10854 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10855 (read_struct_type): Update.
10856
6cceac94
TT
108572019-03-06 Tom Tromey <tom@tromey.com>
10858
10859 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10860 * common/filestuff.h (make_cleanup_close): Don't declare.
10861 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10862 Remove.
10863
72412762
TT
108642019-03-06 Tom Tromey <tom@tromey.com>
10865
10866 * solib-aix.c: Use make_scope_exit.
10867
2b6ff1c0
TT
108682019-03-06 Tom Tromey <tom@tromey.com>
10869
10870 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10871 Use make_scope_exit.
10872
d01c5877
TT
108732019-03-06 Tom Tromey <tom@tromey.com>
10874
10875 * solib-svr4.c (disable_probes_interface): Remove parameter.
10876 (svr4_handle_solib_event): Use make_scope_exit.
10877
32603266
TT
108782019-03-06 Tom Tromey <tom@tromey.com>
10879
10880 * remote.c (struct stop_reply_deleter): Remove.
10881 (stop_reply_up): Update.
10882 (struct stop_reply): Derive from notif_event. Don't typedef.
10883 <regcache>: Now a std::vector.
10884 (stop_reply_xfree): Remove.
10885 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10886 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10887 (remote_target::discard_pending_stop_replies): Use delete.
10888 (remote_target::remote_parse_stop_reply): Update.
10889 (remote_target::process_stop_reply): Update.
10890 * remote-notif.h (struct notif_event): Add virtual destructor.
10891 Remove "dtr" member.
10892 (struct notif_client) <alloc_event>: Return a unique_ptr.
10893 (notif_event_xfree): Don't declare.
10894 (notif_event_up): New typedef.
10895 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10896 (notif_event_xfree, do_notif_event_xfree): Remove.
10897 (remote_notif_state_xfree): Update.
10898
9799571e
TT
108992019-03-06 Tom Tromey <tom@tromey.com>
10900
10901 * infrun.c (displaced_step_clear_cleanup): Now a
10902 forward_scope_exit type.
10903 (displaced_step_prepare_throw): Update.
10904 (displaced_step_fixup): Update.
10905
09e3c4ca
TT
109062019-03-06 Tom Tromey <tom@tromey.com>
10907
10908 * inferior.h (class inferior): Update comment.
10909 * gdbthread.h (class thread_info): Update comment.
10910
e2a03548
TT
109112019-03-06 Joel Brobecker <brobecker@adacore.com>
10912 Tom Tromey <tom@tromey.com>
10913
10914 * stabsread.h (struct stab_section_list): Remove.
10915 (coffstab_build_psymtabs): Update.
10916 * dbxread.c (symbuf_sections): Now a std::vector.
10917 (sect_idx): New global.
10918 (fill_symbuf): Update.
10919 (coffstab_build_psymtabs): Change type of stabsects parameter.
10920 Update.
10921 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10922 std::vector.
10923 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10924 (coff_locate_sections): Update.
10925 (coff_symfile_read): Remove cleanups. Update.
10926 (init_stringtab): Add storage parameter.
10927 (free_stringtab, free_stringtab_cleanup): Remove.
10928 (init_lineno): Add storage parameter.
10929 (free_linetab, free_linetab_cleanup): Remove.
10930
b7e60d85
PA
109312019-03-06 Pedro Alves <palves@redhat.com>
10932
10933 * linux-fork.c (fork_info::clobber_regs): Delete.
10934 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10935 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10936 comment. Adjust.
10937 (scoped_switch_fork_info::scoped_switch_fork_info)
10938 (checkpoint_command, linux_fork_context): Adjust
10939 fork_save_infrun_state calls.
10940
e52c971f
PA
109412019-03-06 Pedro Alves <palves@redhat.com>
10942
10943 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10944 (inf_has_multiple_threads): Return 'bool' and rewrite using
10945 inferior_info::threads().
10946
06974e6c
PA
109472019-03-06 Pedro Alves <palves@redhat.com>
10948
10949 * linux-fork.c: Include <list>.
10950 (fork_list): Now a std::list instance.
10951 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10952 (forks_exist_p, find_last_fork): Adjust.
10953 (new_fork): Delete.
10954 (one_fork_p): New.
10955 (add_fork): Adjust.
10956 (free_fork): Delete, folded into fork_info::~fork_info().
10957 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10958 Adjust.
10959 (init_fork_list): Delete.
10960 (linux_fork_killall, linux_fork_mourn_inferior)
10961 (linux_fork_detach, info_checkpoints_command): Adjust.
10962 (_initialize_linux_fork): No longer call init_fork_list.
10963
72f31aea
PA
109642019-03-06 Pedro Alves <palves@redhat.com>
10965
10966 * linux-fork.c (new_fork): New, split out of ...
10967 (add_fork): ... this. Return void. Move "first fork" special
10968 case from here, to ...
10969 (checkpoint_command): ... here.
10970 * linux-linux.h (add_fork): Return void.
10971
efbecbc1
AB
109722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10973
10974 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10975
0841c79a
AB
109762019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10977 Chris January <chris.january@arm.com>
10978 David Lecomber <david.lecomber@arm.com>
10979
10980 * f-exp.y: New token, UNOP_INTRINSIC.
10981 (exp): New pattern using UNOP_INTRINSIC token.
10982 (f77_keywords): Add 'abs' keyword.
10983 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10984 (value_from_host_double): New function.
10985 (evaluate_subexp_f): Support UNOP_ABS.
10986
4a270568
AB
109872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10988
10989 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10990 types.
10991
067630bd
AB
109922019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10993
10994 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10995 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10996 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10997
3be47f7a
AB
109982019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10999
11000 * f-exp.y (convert_to_kind_type): Handle more type kinds.
11001
4d00f5d8
AB
110022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11003 Chris January <chris.january@arm.com>
11004
11005 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11006 * f-exp.y: Define 'KIND' token.
11007 (exp): New pattern for KIND expressions.
11008 (ptype): Handle types with a kind extension.
11009 (direct_abs_decl): Extend to spot kind extensions.
11010 (f77_keywords): Add 'kind' to the list.
11011 (push_kind_type): New function.
11012 (convert_to_kind_type): New function.
11013 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11014 * parse.c (operator_length_standard): Likewise.
11015 * parser-defs.h (enum type_pieces): Add tp_kind.
11016 * std-operator.def: Add UNOP_KIND.
11017
e454224f
AB
110182019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11019
11020 * f-exp.y (f_parse): Set yydebug.
11021
9dad4a58
AB
110222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11023
11024 * f-lang.c (evaluate_subexp_f): New function.
11025 (exp_descriptor_f): New global.
11026 (f_language_defn): Use exp_descriptor_f instead of
11027 exp_descriptor_standard.
11028
c8f91604
AB
110292019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11030
11031 * f-exp.y (struct token): Add comments.
11032 (dot_ops): Remove uppercase versions and the end marker.
11033 (f77_keywords): Likewise.
11034 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11035 entries in the dot_ops array are case insensitive, and use
11036 strncasecmp to compare strings. Also some whitespace cleanup in
11037 this area. Similar for the f77_keywords array, except entries in
11038 this list might be case sensitive.
11039
dd9f2c76
AB
110402019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11041
11042 * f-exp.y (struct f77_boolean_val): Add comments.
11043 (boolean_values): Remove uppercase versions, and end marker.
11044 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11045 and use strncasecmp to achieve case insensitivity. Additionally,
11046 perform whitespace cleanup around this code.
11047
67a3048c
TT
110482019-03-06 Tom Tromey <tromey@adacore.com>
11049
11050 * remote-sim.c (gdbsim_target_open): Use result of
11051 gdb_argv::release.
11052
aa3cfbda
RB
110532019-03-06 Richard Bunt <richard.bunt@arm.com>
11054 Dirk Schubert <dirk.schubert@arm.com>
11055 Chris January <chris.january@arm.com>
11056
11057 * eval.c (evaluate_subexp_standard): Call Fortran argument
11058 wrapping logic.
11059 * f-lang.c (struct value): A value which can be passed into a
11060 Fortran function call.
11061 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11062 where appropriate.
11063 (struct type): Value ready for a Fortran function call.
11064 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11065 is needed.
11066 * f-lang.h (fortran_argument_convert): Declaration.
11067 (fortran_preserve_arg_pointer): Declaration.
11068 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11069
ea38e5df
TT
110702019-03-05 Tom Tromey <tromey@adacore.com>
11071
11072 * python/py-prettyprint.c (print_string_repr): Remove #if.
11073 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11074
06b5b831
TT
110752019-03-05 Tom Tromey <tromey@adacore.com>
11076
11077 * target.c (the_dummy_target): Move later. Change type to
11078 "dummy_target".
11079 (initialize_targets): Don't initialize the_dummy_target.
11080
edbd9e45
TT
110812019-03-05 Tom Tromey <tromey@adacore.com>
11082
11083 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11084 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11085
c119e040
TT
110862019-03-05 Tom Tromey <tromey@adacore.com>
11087
11088 * windows-nat.c (windows_nat_target::attach)
11089 (windows_nat_target::detach): Don't call gdb_flush.
11090 * valprint.c (generic_val_print, val_print, val_print_string):
11091 Don't call gdb_flush.
11092 * utils.c (defaulted_query): Don't call gdb_flush.
11093 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11094 * target.c (target_announce_detach): Don't call gdb_flush.
11095 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11096 * remote.c (extended_remote_target::attach): Don't call
11097 gdb_flush.
11098 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11099 * printcmd.c (do_examine): Don't call gdb_flush.
11100 (info_display_command): Don't call gdb_flush.
11101 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11102 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11103 * memattr.c (info_mem_command): Don't call gdb_flush.
11104 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11105 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11106 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11107 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11108 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11109 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11110 (gnu_nat_target::detach): Don't call gdb_flush.
11111 * f-valprint.c (f_val_print): Don't call gdb_flush.
11112 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11113 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11114 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11115 gdb_flush.
11116 * c-valprint.c (c_val_print): Don't call gdb_flush.
11117 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11118
895dafa6
TT
111192019-03-05 Tom Tromey <tromey@adacore.com>
11120
11121 * varobj.c (update_dynamic_varobj_children): Update.
11122 (install_default_visualizer): Use reset, not release.
11123 * value.c (set_internalvar): Update.
11124 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11125 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11126 ATTRIBUTE_UNUSED_RESULT.
11127
88a774b9
TT
111282019-03-05 Tom Tromey <tromey@adacore.com>
11129
11130 * remote.c (class scoped_remote_fd) <release>: Add
11131 ATTRIBUTE_UNUSED_RESULT.
11132
4e4a8b93
TT
111332019-03-05 Tom Tromey <tromey@adacore.com>
11134
11135 * macroexp.c (struct macro_buffer) <release>: Add
11136 ATTRIBUTE_UNUSED_RESULT.
11137
083eef1f
TT
111382019-03-05 Tom Tromey <tromey@adacore.com>
11139
11140 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11141 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11142 ATTRIBUTE_UNUSED_RESULT.
11143
3cabd438
TT
111442019-03-05 Tom Tromey <tromey@adacore.com>
11145
11146 * common/scoped_fd.h (class scoped_fd) <release>: Add
11147 ATTRIBUTE_UNUSED_RESULT.
11148
41e3300a
TT
111492019-03-05 Tom Tromey <tromey@adacore.com>
11150
11151 * parser-defs.h (struct parser_state) <release>: Add
11152 ATTRIBUTE_UNUSED_RESULT.
11153
18cb7c9f
TT
111542019-03-05 Tom Tromey <tromey@adacore.com>
11155
11156 * utils.h (class gdb_argv) <release>: Add
11157 ATTRIBUTE_UNUSED_RESULT.
11158 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11159
41fa577f
EZ
111602019-03-02 Eli Zaretskii <eliz@gnu.org>
11161
a6a4b2c6
EZ
11162 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11163 for-loop range, to avoid compiler warnings.
11164
11165 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11166 avoid compiler warnings about unused variables.
11167
742a7df5
EZ
11168 * NEWS: Mention end of support for native debugging on MS-Windows
11169 before XP.
11170
41fa577f
EZ
11171 PR gdb/24292
11172 * common/netstuff.c:
11173 * gdbserver/gdbreplay.c
11174 * gdbserver/remote-utils.c:
11175 * ser-tcp.c:
11176 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11177 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11178 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11179 'getaddrinfo' and 'freeaddrinfo' were not available before
11180 Windows XP, and mingw.org's MinGW headers by default define
11181 _WIN32_WINNT to 0x500.
11182
827f438f
GB
111832019-03-01 Gary Benson <gbenson@redhat.com>
11184
11185 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11186
92137da0
RO
111872019-02-28 Brian Vandenberg <phantall@gmail.com>
11188 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11189
11190 PR gdb/8527
11191 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11192 set_sigint_trap, clear_sigint_trap.
11193
799efbe8
PW
111942019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11195
11196 * target.c (target_detach): Clear the regcache and the
11197 frame cache.
11198
8ed25214
PA
111992019-02-27 Pedro Alves <palves@redhat.com>
11200
11201 * utils.c (set_screen_size): When we cap the height/width sizes,
11202 tweak the corresponding command variable to show "unlimited":
11203
23031e31
SJ
112042019-02-27 Saagar Jha <saagar@saagarjha.com>
11205 Pedro Alves <palves@redhat.com>
11206
11207 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11208 before calling rl_set_screen_size.
11209
6c28e44a
TT
112102019-02-27 Tom Tromey <tromey@adacore.com>
11211
11212 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11213 define.
11214 * python/py-value.c: Remove Python 2.4 workaround.
11215 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11216 workaround.
11217 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11218 Python 2.4 workaround.
11219 * python/python-internal.h: Remove Python 2.4 comment.
11220 (Py_ssize_t): Don't define.
11221 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11222 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11223 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11224 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11225 * python/python.c (do_start_initialization): Remove Python 2.4
11226 workaround.
11227 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11228 (print_children): Remove Python 2.4 workaround.
11229 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11230 workaround.
11231 (CHARBUFFERPROC_NAME): Remove.
11232 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11233 Python 2.4 workaround.
11234
2c3fc25d 112352019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 11236
2c3fc25d
KB
11237 * NEWS: Note minimum Python version.
11238
6ca62222
KB
112392019-02-27 Kevin Buettner <kevinb@redhat.com>
11240
11241 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11242 code from these functions. Remove corresponding ifdefs. Use
11243 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11244 Remove gotos and target of gotos.
11245 (infpy_search_memory): Likewise.
11246
f4bc7d2c
AB
112472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11248
11249 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11250 (hppa_gdbarch_init): Don't register deleted functions with
11251 gdbarch.
11252
9734a586
AB
112532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11254
11255 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11256 (h8300_unwind_sp): Delete.
11257 (h8300_dummy_id): Delete.
11258 (h8300_gdbarch_init): Don't register deleted functions with
11259 gdbarch.
11260
68b867f3
AB
112612019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11262
11263 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11264 (ft32_unwind_pc): Delete.
11265 (ft32_unwind_sp): Delete.
11266 (ft32_gdbarch_init): Don't register deleted functions with
11267 gdbarch.
11268
2fbe7ad0
AB
112692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11270
11271 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11272 (frv_unwind_pc): Delete.
11273 (frv_unwind_sp): Delete.
11274 (frv_gdbarch_init): Don't register deleted functions with
11275 gdbarch.
11276
76055cbe
AB
112772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11278
11279 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11280 (riscv_unwind_pc): Delete.
11281 (riscv_unwind_sp): Delete.
11282 (riscv_gdbarch_init): Don't register deleted functions with
11283 gdbarch.
11284
4133e5a1
AB
112852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11286
11287 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11288 (csky_unwind_pc): Delete.
11289 (csky_unwind_sp): Delete.
11290 (csky_gdbarch_init): Don't register deleted functions with
11291 gdbarch.
11292
8010f576
AB
112932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11294
11295 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11296 (cris_unwind_pc): Delete.
11297 (cris_unwind_sp): Delete.
11298 (cris_gdbarch_init): Don't register deleted functions with
11299 gdbarch.
11300
b56bf084
AB
113012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11302
11303 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11304 (bfin_unwind_pc): Delete.
11305 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11306
a19a650f
AB
113072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11308
11309 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11310 (arm_unwind_pc): Delete.
11311 (arm_unwind_sp): Delete.
11312 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11313
f8278c3c
AB
113142019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11315
11316 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11317 (arc_unwind_pc): Delete.
11318 (arc_unwind_sp): Delete.
11319 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11320
480e46cf
AB
113212019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11322
11323 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11324 (alpha_unwind_pc): Delete.
11325 (alpha_gdbarch_init): Don't register deleted functions with
11326 gdbarch.
11327
7a995095
AB
113282019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11329
11330 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11331 (aarch64_unwind_pc): Delete.
11332 (aarch64_unwind_sp): Delete.
11333 (aarch64_gdbarch_init): Don't register deleted functions with
11334 gdbarch.
11335
bf9a735e
AB
113362019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11337
11338 * gdbtypes.c (type_align): Don't consider static members when
11339 computing structure alignment.
11340
5561fc30
AB
113412019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11342
11343 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11344 return 0 for other types.
11345 * arch-utils.c (default_type_align): Always return 0.
11346 * gdbarch.h: Regenerate.
11347 * gdbarch.sh (type_align): Extend comment.
11348 * gdbtypes.c (type_align): Add additional comments, always call
11349 gdbarch_type_align before applying the default rules.
11350 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11351 generic code will then apply a suitable default.
11352 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11353 types, return 0 for other types.
11354
9335e75a
JB
113552019-02-27 Joel Brobecker <brobecker@adacore.com>
11356
11357 * NEWS: Create a new section for the next release branch.
11358 Rename the section of the current branch, now that it has
11359 been cut.
11360
3d34d8de
JB
113612019-02-27 Joel Brobecker <brobecker@adacore.com>
11362
11363 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11364 * version.in: Bump version to 8.3.50.DATE-git.
11365
143420fb
SM
113662019-02-26 Simon Marchi <simon.marchi@efficios.com>
11367
11368 * aix-thread.c (ptid_cmp): Remove unused variable.
11369 (get_signaled_thread): Likewise.
11370 (store_regs_user_thread): Likewise.
11371 (store_regs_kernel_thread): Likewise.
11372 (fetch_regs_kernel_thread): Remove shadowed variable.
11373
172fb711
AB
113742019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11375
11376 * features/riscv/32bit-cpu.xml: Add register numbers.
11377 * features/riscv/32bit-fpu.c: Regenerate.
11378 * features/riscv/32bit-fpu.xml: Add register numbers.
11379 * features/riscv/64bit-cpu.xml: Add register numbers.
11380 * features/riscv/64bit-fpu.c: Regenerate.
11381 * features/riscv/64bit-fpu.xml: Add register numbers.
11382
26c89782
KB
113832019-02-26 Kevin Buettner <kevinb@redhat.com>
11384
af54ade9 11385 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
11386 * python/py-value.c (convert_buffer_and_type_to_value): New
11387 function.
11388 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11389 Add support for handling an optional second argument. Call
11390 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
11391 * python/python-internal.h (Py_buffer_deleter): New struct.
11392 (Py_buffer_up): New typedef.
11393
0f58c9e8
JB
113942019-02-25 John Baldwin <jhb@FreeBSD.org>
11395
11396 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11397 instead of releasing ownership.
11398
0a0f4c01
JR
113992019-02-25 Jordan Rupprecht <rupprecht@google.com>
11400
11401 * dwarf2read.c (open_and_init_dwp_file): Call
11402 elf_numsections instead of bfd_count_sections to initialize
11403 dwp_file->num_sections.
11404
cd5a152c
TT
114052019-02-25 Tom Tromey <tromey@adacore.com>
11406
11407 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11408
8a6a8513
SDJ
114092019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11410
11411 * gcore.in: Add '--readnever' option when invoking GDB.
11412
04dcda9c
SM
114132019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11414
11415 * MAINTAINERS: Update my email address.
11416
07bc701d
SM
114172019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11418
11419 * build-id.c (build_id_to_debug_bfd_1): New function.
11420 (build_id_to_debug_bfd): Look for separate debug file in
11421 sysroot.
11422
c6f4a5d0
AB
114232019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11424
11425 * gdbarch.sh: Update the copyright year range that is placed into
11426 generated files.
11427
9600246d
KS
114282019-02-22 Keith Seitz <keiths@redhat.com>
11429
11430 PR symtab/23853
11431 * linespec.c (create_sals_line_offset): Search for the default
11432 symtab's filename instead of its fullname.
11433
7557a514
AH
114342019-02-21 Alan Hayward <alan.hayward@arm.com>
11435
11436 * NEWS: Update style defaults.
11437
ee2bcb0c
AH
114382019-02-21 Alan Hayward <alan.hayward@arm.com>
11439
11440 * main.c (captured_main_1): Disable styling in batch mode.
11441
0c95f9ed
TT
114422019-02-20 Tom Tromey <tom@tromey.com>
11443
11444 * symtab.c (symtab_symbol_info): Fix typos.
11445
c763b894
TT
114462019-02-20 Tom Tromey <tromey@adacore.com>
11447
11448 * findcmd.c (_initialize_mem_search): Use upper case for
11449 metasyntactic variables.
11450
0ef8a082
AH
114512019-02-20 Alan Hayward <alan.hayward@arm.com>
11452
11453 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11454 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11455
6caa91b6
SM
114562019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11457
11458 * top.h (source_file_name): Change to std::string.
11459 * top.c (source_file_name): Likewise.
11460 (command_line_input): Adjust.
11461 * cli/cli-script.c (script_from_file): Adjust.
11462
98814c6c
TT
114632019-02-19 Tom Tromey <tromey@adacore.com>
11464
11465 * ravenscar-thread.c
11466 (ravenscar_thread_target::update_thread_list): Don't call
11467 ada_build_task_list.
11468 * ada-lang.h (ada_build_task_list): Don't declare.
11469 * ada-tasks.c (struct ada_tasks_inferior_data)
11470 <task_list_valid_p>: Now bool.
11471 (read_known_tasks, ada_task_list_changed)
11472 (ada_tasks_invalidate_inferior_data): Update.
11473 (read_known_tasks_array): Return bool.
11474 (read_known_tasks_list): Likewise.
11475 (read_known_tasks): Return void.
11476 (ada_build_task_list): Now static.
11477
70cd633e
AB
114782019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11479
11480 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11481 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11482
040b3e95
PW
114832019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11484
11485 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11486 variant for ada_tasks_pspace_data_handle and
11487 ada_tasks_inferior_data_handle.
11488 (ada_tasks_pspace_data_cleanup): New function.
11489 (ada_tasks_inferior_data_cleanup): New function.
11490
9409233b
TT
114912019-02-17 Tom Tromey <tom@tromey.com>
11492
11493 * macrotab.h (macro_source_fullname): Return a std::string.
11494 * macrotab.c (macro_include, check_for_redefinition)
11495 (macro_undef, macro_lookup_definition, foreach_macro)
11496 (foreach_macro_in_scope): Update.
11497 (macro_source_fullname): Return a std::string.
11498 * macrocmd.c (show_pp_source_pos): Update.
11499
6506371f
TT
115002019-02-17 Tom Tromey <tom@tromey.com>
11501
11502 * macrocmd.c (show_pp_source_pos): Style the file names.
11503
0c820d67
TT
115042019-02-17 Tom Tromey <tom@tromey.com>
11505
11506 PR tui/24197:
11507 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11508
a0087920
TT
115092019-02-17 Tom Tromey <tom@tromey.com>
11510
11511 * ada-lang.c (user_select_syms): Use filtered printing.
11512 * utils.c (wrap_style): New global.
11513 (desired_style): Remove.
11514 (emit_style_escape): Add stream parameter.
11515 (set_output_style, reset_terminal_style, prompt_for_continue):
11516 Update.
11517 (flush_wrap_buffer): Only flush gdb_stdout.
11518 (wrap_here): Set wrap_style.
11519 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
11520 treat escape sequences as a character. Change when wrap buffer is
11521 flushed.
11522 (fputs_styled): Do not set the output style when the default is
11523 requested.
11524 * ui-style.h (struct ui_file_style) <is_default>: New method.
11525 * source.c (print_source_lines_base): Emit escape sequences in one
11526 piece.
11527
75ba10dc
JB
115282019-02-17 Joel Brobecker <brobecker@adacore.com>
11529
11530 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11531 integers and enumeration types.
11532
a2cd4f14
JB
115332019-02-17 Joel Brobecker <brobecker@adacore.com>
11534
11535 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11536 instead of lookup_symbol_in_language
11537 (do_exact_match): New function.
11538 (ada_get_symbol_name_matcher): Return do_exact_match when
11539 doing a verbatim match.
11540
485b851b
TT
115412019-02-15 Tom Tromey <tromey@adacore.com>
11542
11543 * ravenscar-thread.c (ravenscar_thread_target::resume)
11544 (ravenscar_thread_target::wait): Special case wildcard requests.
11545
0b790b1e
TT
115462019-02-15 Tom Tromey <tromey@adacore.com>
11547
11548 * ravenscar-thread.c (base_ptid): Remove.
11549 (struct ravenscar_thread_target) <close>: New method.
11550 <m_base_ptid>: New member.
11551 <update_inferior_ptid, active_task, task_is_currently_active,
11552 runtime_initialized>: Declare methods.
11553 <ravenscar_thread_target>: Add constructor.
11554 (ravenscar_thread_target::task_is_currently_active)
11555 (ravenscar_thread_target::update_inferior_ptid)
11556 (ravenscar_runtime_initialized): Rename. Now methods.
11557 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11558 (ravenscar_thread_target::update_thread_list): Update.
11559 (ravenscar_thread_target::active_task): Now method.
11560 (ravenscar_thread_target::store_registers)
11561 (ravenscar_thread_target::prepare_to_store)
11562 (ravenscar_thread_target::prepare_to_store)
11563 (ravenscar_thread_target::mourn_inferior): Update.
11564 (ravenscar_inferior_created): Use "new" to create target.
11565 (ravenscar_thread_target::get_ada_task_ptid): Update.
11566 (_initialize_ravenscar): Don't initialize base_ptid.
11567 (ravenscar_ops): Remove global.
11568
dea57a62
TT
115692019-02-15 Tom Tromey <tromey@adacore.com>
11570
11571 * target.h (push_target): Declare new overload.
11572 * target.c (push_target): New overload, taking an rvalue reference.
11573 * remote.c (remote_target::open_1): Use push_target overload.
11574 * corelow.c (core_target_open): Use push_target overload.
11575
989f3c58
TT
115762019-02-15 Tom Tromey <tromey@adacore.com>
11577
11578 * ravenscar-thread.c (is_ravenscar_task)
11579 (ravenscar_task_is_currently_active): Return bool.
11580 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11581 (_initialize_ravenscar): Remove "(void)".
11582 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11583 Return bool.
11584
6cbcc006
TT
115852019-02-15 Tom Tromey <tromey@adacore.com>
11586
11587 * ravenscar-thread.c (ravenscar_runtime_initializer)
11588 (has_ravenscar_runtime, get_running_thread_id)
11589 (ravenscar_thread_target::resume): Fix indentation.
11590
7657f14d
TT
115912019-02-15 Tom Tromey <tromey@adacore.com>
11592
11593 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11594 from ravenscar_arch_ops.
11595 (sparc_ravenscar_ops::fetch_registers)
11596 (sparc_ravenscar_ops::store_registers): Now methods.
11597 (sparc_ravenscar_prepare_to_store): Remove.
11598 (sparc_ravenscar_ops): Redefine.
11599 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11600 methods and destructor. Remove members.
11601 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11602 (ravenscar_thread_target::store_registers)
11603 (ravenscar_thread_target::prepare_to_store): Update.
11604 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11605 Remove.
11606 (struct ppc_ravenscar_powerpc_ops): Derive from
11607 ravenscar_arch_ops.
11608 (ppc_ravenscar_powerpc_ops::fetch_registers)
11609 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11610 (ppc_ravenscar_powerpc_ops): Redefine.
11611 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11612 (ppc_ravenscar_e500_ops::fetch_registers)
11613 (ppc_ravenscar_e500_ops::store_registers): Now methods.
11614 (ppc_ravenscar_e500_ops): Redefine.
11615 * aarch64-ravenscar-thread.c
11616 (aarch64_ravenscar_generic_prepare_to_store): Remove.
11617 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11618 (aarch64_ravenscar_fetch_registers)
11619 (aarch64_ravenscar_store_registers): Now methods.
11620 (aarch64_ravenscar_ops): Redefine.
11621
5b6ea500
TT
116222019-02-15 Tom Tromey <tromey@adacore.com>
11623
11624 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11625 (ravenscar_thread_target::stopped_by_hw_breakpoint)
11626 (ravenscar_thread_target::stopped_by_watchpoint)
11627 (ravenscar_thread_target::stopped_data_address)
11628 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11629
e397fd39
TT
116302019-02-15 Tom Tromey <tromey@adacore.com>
11631
11632 * ravenscar-thread.c: Fix some typos.
11633
cc12f4a8
TT
116342019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11635 Tom Tromey <tromey@adacore.com>
11636
11637 * ada-lang.c (ada_exception_sal): Change addr_string to a
11638 std::string.
11639 (create_ada_exception_catchpoint): Update.
11640
5f486660
TT
116412019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11642 Tom Tromey <tromey@adacore.com>
11643
11644 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11645 (bp_location_ops): Remove.
11646 (base_breakpoint_allocate_location): Update.
11647 (free_bp_location): Update.
11648 * ada-lang.c (class ada_catchpoint_location)
11649 <ada_catchpoint_location>: Remove ops parameter.
11650 (ada_catchpoint_location_dtor): Remove.
11651 (ada_catchpoint_location_ops): Remove.
11652 (allocate_location_exception): Update.
11653 * breakpoint.h (struct bp_location_ops): Remove.
11654 (class bp_location) <bp_location>: Remove bp_location_ops
11655 parameter.
11656 <~bp_location>: Add destructor.
11657 <ops>: Remove.
11658
b671c7fb
TS
116592019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11660 Pedro Alves <palves@redhat.com>
11661
11662 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11663 'PATH_MAX'.
11664
8071c5ce
DM
116652019-02-14 David Michael <fedora.dm0@gmail.com>
11666 Samuel Thibault <samuel.thibault@gnu.org>
11667 Thomas Schwinge <thomas@codesourcery.com>
11668
11669 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11670 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11671
b1041ae0
TS
116722019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11673
924514e1
TS
11674 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11675 (check_empty): Use "const char *".
11676
c29ee8d4
TS
11677 * gnu-nat.c (gnu_nat_target::detach): Instead of
11678 'detach_inferior (pid)' call
11679 'detach_inferior (find_inferior_pid (pid))'.
11680
6c6ef69f
TS
11681 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11682 'nat/fork-inferior.o'.
11683 * gnu-nat.c: #include "nat/fork-inferior.h".
11684
2d0a338c
TS
11685 * gnu-nat.c (gnu_nat_target::detach): Instead of
11686 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11687 * gnu-nat.h: #include "inf-child.h".
11688 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11689 'i386_gnu_nat_target::fetch_registers'.
11690 (gnu_store_registers): Rename/move to
11691 'i386_gnu_nat_target::store_registers'.
11692
cabb5f06
TS
11693 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11694 * gnu-nat.h (mach_thread_info): New function.
11695 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11696
b1041ae0
TS
11697 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11698
2988d01e
KF
116992019-02-14 Frederic Konrad <konrad@adacore.com>
11700
11701 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11702
c559d709
JB
117032019-02-14 Joel Brobecker <brobecker@adacore.com>
11704
11705 * windows-nat.c (windows_add_thread): Add new parameter
11706 "main_thread_p" with default value set to false. Update
11707 function documentation as well as all callers.
11708 (windows_delete_thread): Likewise.
11709 (fake_create_process): Update call to windows_add_thread.
11710 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11711 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11712 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11713 call to windows_delete_thread.
11714
007024cc
SM
117152019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11716
11717 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11718
f62318e9
JB
117192019-02-12 John Baldwin <jhb@FreeBSD.org>
11720
11721 * symfile.c (find_separate_debug_file): Use canonical path of
11722 sysroot with child_path instead of gdb_sysroot if it is valid.
11723
cd4b7848
JB
117242019-02-12 John Baldwin <jhb@FreeBSD.org>
11725
11726 * symfile.c (find_separate_debug_file): Use child_path to
11727 determine if an object file is under a sysroot.
11728
efac4bfe
JB
117292019-02-12 John Baldwin <jhb@FreeBSD.org>
11730
11731 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11732 unittests/child-path-selftests.c.
11733 * common/pathstuff.c (child_path): New function.
11734 * common/pathstuff.h (child_path): New prototype.
11735 * unittests/child-path-selftests.c: New file.
11736
402d2bfe
JB
117372019-02-12 John Baldwin <jhb@FreeBSD.org>
11738
11739 * symfile.c (find_separate_debug_file): Look for separate debug
11740 files in debug directories under the sysroot.
11741
1ed9f74e
PW
117422019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11743
11744 * symtab.h (struct minimal_symbol data_p): New const method.
11745 (struct minimal_symbol text_p): Likewise.
11746 * symtab.c (output_source_filename): Use file name style
11747 to print file name.
11748 (print_symbol_info): Likewise.
11749 (print_msymbol_info): Use address style to print addresses.
11750 Use function name style to print executable text symbols.
11751 (expand_symtab_containing_pc): Use data_p.
11752 (find_pc_sect_compunit_symtab): Likewise.
11753
2636d81d
PW
117542019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11755
11756 * breakpoint.c (describe_other_breakpoints): Use address style
11757 to print addresses.
11758 (say_where): Likewise.
11759
ac8c53cc
PW
117602019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11761
11762 * ada-typeprint.c (print_func_type): Print function name
11763 style to print function name.
11764 * c-typeprint.c (c_print_type_1): Likewise.
11765
ea638c43
AH
117662019-02-11 Alan Hayward <alan.hayward@arm.com>
11767
11768 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11769 for execve.
11770
ab759ca8
PW
117712019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11772
11773 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11774 type_stack.
11775
aff29d1c
JB
117762019-02-10 Joel Brobecker <brobecker@adacore.com>
11777
11778 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11779 TYPE_CODE_REF types.
11780
617126bc
JW
117812019-02-08 Jim Wilson <jimw@sifive.com>
11782
11783 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11784 (riscv_linux_fregset): New.
11785 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11786
46e3ed7f
TT
117872019-02-07 Tom Tromey <tom@tromey.com>
11788
11789 * thread.c (thread_cancel_execution_command): Update.
11790 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11791 methods.
11792 (struct thread_fsm_ops): Remove.
11793 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11794 (thread_fsm_should_stop, thread_fsm_return_value)
11795 (thread_fsm_set_finished, thread_fsm_finished_p)
11796 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11797 Don't declare.
11798 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11799 * infrun.c (clear_proceed_status_thread)
11800 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11801 (print_stop_event): Update.
11802 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11803 Add constructor.
11804 (step_command_fsm_ops): Remove.
11805 (new_step_command_fsm): Remove.
11806 (step_1): Update.
11807 (step_command_fsm::should_stop): Rename from
11808 step_command_fsm_should_stop.
11809 (step_command_fsm::clean_up): Rename from
11810 step_command_fsm_clean_up.
11811 (step_command_fsm::do_async_reply_reason): Rename from
11812 step_command_fsm_async_reply_reason.
11813 (struct until_next_fsm): Inherit from thread_fsm. Add
11814 constructor.
11815 (until_next_fsm_ops): Remove.
11816 (new_until_next_fsm): Remove.
11817 (until_next_fsm::should_stop): Rename from
11818 until_next_fsm_should_stop.
11819 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11820 (until_next_fsm::do_async_reply_reason): Rename from
11821 until_next_fsm_async_reply_reason.
11822 (struct finish_command_fsm): Inherit from thread_fsm. Add
11823 constructor. Change type of breakpoint.
11824 (finish_command_fsm_ops): Remove.
11825 (new_finish_command_fsm): Remove.
11826 (finish_command_fsm::should_stop): Rename from
11827 finish_command_fsm_should_stop.
11828 (finish_command_fsm::clean_up): Rename from
11829 finish_command_fsm_clean_up.
11830 (finish_command_fsm::return_value): Rename from
11831 finish_command_fsm_return_value.
11832 (finish_command_fsm::do_async_reply_reason): Rename from
11833 finish_command_fsm_async_reply_reason.
11834 (finish_command): Update.
11835 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11836 Add constructor.
11837 (call_thread_fsm_ops): Remove.
11838 (call_thread_fsm::call_thread_fsm): Rename from
11839 new_call_thread_fsm.
11840 (call_thread_fsm::should_stop): Rename from
11841 call_thread_fsm_should_stop.
11842 (call_thread_fsm::should_notify_stop): Rename from
11843 call_thread_fsm_should_notify_stop.
11844 (run_inferior_call, call_function_by_hand_dummy): Update.
11845 * cli/cli-interp.c (should_print_stop_to_console): Update.
11846 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11847 Add constructor. Change type of location_breakpoint,
11848 caller_breakpoint.
11849 (until_break_fsm_ops): Remove.
11850 (new_until_break_fsm): Remove.
11851 (until_break_fsm::should_stop): Rename from
11852 until_break_fsm_should_stop.
11853 (until_break_fsm::clean_up): Rename from
11854 until_break_fsm_clean_up.
11855 (until_break_fsm::do_async_reply_reason): Rename from
11856 until_break_fsm_async_reply_reason.
11857 (until_break_command): Update.
11858 * thread-fsm.c: Remove.
11859 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11860
1a5c2598
TT
118612019-02-07 Tom Tromey <tom@tromey.com>
11862
11863 * yy-remap.h: Add include guard.
11864 * xtensa-tdep.h: Add include guard.
11865 * xcoffread.h: Rename include guard.
11866 * varobj-iter.h: Add include guard.
11867 * tui/tui.h: Rename include guard.
11868 * tui/tui-winsource.h: Rename include guard.
11869 * tui/tui-wingeneral.h: Rename include guard.
11870 * tui/tui-windata.h: Rename include guard.
11871 * tui/tui-win.h: Rename include guard.
11872 * tui/tui-stack.h: Rename include guard.
11873 * tui/tui-source.h: Rename include guard.
11874 * tui/tui-regs.h: Rename include guard.
11875 * tui/tui-out.h: Rename include guard.
11876 * tui/tui-layout.h: Rename include guard.
11877 * tui/tui-io.h: Rename include guard.
11878 * tui/tui-hooks.h: Rename include guard.
11879 * tui/tui-file.h: Rename include guard.
11880 * tui/tui-disasm.h: Rename include guard.
11881 * tui/tui-data.h: Rename include guard.
11882 * tui/tui-command.h: Rename include guard.
11883 * tic6x-tdep.h: Add include guard.
11884 * target/waitstatus.h: Rename include guard.
11885 * target/wait.h: Rename include guard.
11886 * target/target.h: Rename include guard.
11887 * target/resume.h: Rename include guard.
11888 * target-float.h: Rename include guard.
11889 * stabsread.h: Add include guard.
11890 * rs6000-tdep.h: Add include guard.
11891 * riscv-fbsd-tdep.h: Add include guard.
11892 * regformats/regdef.h: Rename include guard.
11893 * record.h: Rename include guard.
11894 * python/python.h: Rename include guard.
11895 * python/python-internal.h: Rename include guard.
11896 * python/py-stopevent.h: Rename include guard.
11897 * python/py-ref.h: Rename include guard.
11898 * python/py-record.h: Rename include guard.
11899 * python/py-record-full.h: Rename include guard.
11900 * python/py-record-btrace.h: Rename include guard.
11901 * python/py-instruction.h: Rename include guard.
11902 * python/py-events.h: Rename include guard.
11903 * python/py-event.h: Rename include guard.
11904 * procfs.h: Add include guard.
11905 * proc-utils.h: Add include guard.
11906 * p-lang.h: Add include guard.
11907 * or1k-tdep.h: Rename include guard.
11908 * observable.h: Rename include guard.
11909 * nto-tdep.h: Rename include guard.
11910 * nat/x86-linux.h: Rename include guard.
11911 * nat/x86-linux-dregs.h: Rename include guard.
11912 * nat/x86-gcc-cpuid.h: Add include guard.
11913 * nat/x86-dregs.h: Rename include guard.
11914 * nat/x86-cpuid.h: Rename include guard.
11915 * nat/ppc-linux.h: Rename include guard.
11916 * nat/mips-linux-watch.h: Rename include guard.
11917 * nat/linux-waitpid.h: Rename include guard.
11918 * nat/linux-ptrace.h: Rename include guard.
11919 * nat/linux-procfs.h: Rename include guard.
11920 * nat/linux-osdata.h: Rename include guard.
11921 * nat/linux-nat.h: Rename include guard.
11922 * nat/linux-namespaces.h: Rename include guard.
11923 * nat/linux-btrace.h: Rename include guard.
11924 * nat/glibc_thread_db.h: Rename include guard.
11925 * nat/gdb_thread_db.h: Rename include guard.
11926 * nat/gdb_ptrace.h: Rename include guard.
11927 * nat/fork-inferior.h: Rename include guard.
11928 * nat/amd64-linux-siginfo.h: Rename include guard.
11929 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11930 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11931 * nat/aarch64-linux.h: Rename include guard.
11932 * nat/aarch64-linux-hw-point.h: Rename include guard.
11933 * mn10300-tdep.h: Add include guard.
11934 * mips-linux-tdep.h: Add include guard.
11935 * mi/mi-parse.h: Rename include guard.
11936 * mi/mi-out.h: Rename include guard.
11937 * mi/mi-main.h: Rename include guard.
11938 * mi/mi-interp.h: Rename include guard.
11939 * mi/mi-getopt.h: Rename include guard.
11940 * mi/mi-console.h: Rename include guard.
11941 * mi/mi-common.h: Rename include guard.
11942 * mi/mi-cmds.h: Rename include guard.
11943 * mi/mi-cmd-break.h: Rename include guard.
11944 * m2-lang.h: Add include guard.
11945 * location.h: Rename include guard.
11946 * linux-record.h: Rename include guard.
11947 * linux-nat.h: Add include guard.
11948 * linux-fork.h: Add include guard.
11949 * i386-darwin-tdep.h: Rename include guard.
11950 * hppa-linux-offsets.h: Add include guard.
11951 * guile/guile.h: Rename include guard.
11952 * guile/guile-internal.h: Rename include guard.
11953 * gnu-nat.h: Rename include guard.
11954 * gdb-stabs.h: Rename include guard.
11955 * frv-tdep.h: Add include guard.
11956 * f-lang.h: Add include guard.
11957 * event-loop.h: Add include guard.
11958 * darwin-nat.h: Rename include guard.
11959 * cp-abi.h: Rename include guard.
11960 * config/sparc/nm-sol2.h: Rename include guard.
11961 * config/nm-nto.h: Rename include guard.
11962 * config/nm-linux.h: Add include guard.
11963 * config/i386/nm-i386gnu.h: Rename include guard.
11964 * config/djgpp/nl_types.h: Rename include guard.
11965 * config/djgpp/langinfo.h: Rename include guard.
11966 * compile/gcc-cp-plugin.h: Add include guard.
11967 * compile/gcc-c-plugin.h: Add include guard.
11968 * compile/compile.h: Rename include guard.
11969 * compile/compile-object-run.h: Rename include guard.
11970 * compile/compile-object-load.h: Rename include guard.
11971 * compile/compile-internal.h: Rename include guard.
11972 * compile/compile-cplus.h: Rename include guard.
11973 * compile/compile-c.h: Rename include guard.
11974 * common/xml-utils.h: Rename include guard.
11975 * common/x86-xstate.h: Rename include guard.
11976 * common/version.h: Rename include guard.
11977 * common/vec.h: Rename include guard.
11978 * common/tdesc.h: Rename include guard.
11979 * common/selftest.h: Rename include guard.
11980 * common/scoped_restore.h: Rename include guard.
11981 * common/scoped_mmap.h: Rename include guard.
11982 * common/scoped_fd.h: Rename include guard.
11983 * common/safe-iterator.h: Rename include guard.
11984 * common/run-time-clock.h: Rename include guard.
11985 * common/refcounted-object.h: Rename include guard.
11986 * common/queue.h: Rename include guard.
11987 * common/ptid.h: Rename include guard.
11988 * common/print-utils.h: Rename include guard.
11989 * common/preprocessor.h: Rename include guard.
11990 * common/pathstuff.h: Rename include guard.
11991 * common/observable.h: Rename include guard.
11992 * common/netstuff.h: Rename include guard.
11993 * common/job-control.h: Rename include guard.
11994 * common/host-defs.h: Rename include guard.
11995 * common/gdb_wait.h: Rename include guard.
11996 * common/gdb_vecs.h: Rename include guard.
11997 * common/gdb_unlinker.h: Rename include guard.
11998 * common/gdb_unique_ptr.h: Rename include guard.
11999 * common/gdb_tilde_expand.h: Rename include guard.
12000 * common/gdb_sys_time.h: Rename include guard.
12001 * common/gdb_string_view.h: Rename include guard.
12002 * common/gdb_splay_tree.h: Rename include guard.
12003 * common/gdb_setjmp.h: Rename include guard.
12004 * common/gdb_ref_ptr.h: Rename include guard.
12005 * common/gdb_optional.h: Rename include guard.
12006 * common/gdb_locale.h: Rename include guard.
12007 * common/gdb_assert.h: Rename include guard.
12008 * common/filtered-iterator.h: Rename include guard.
12009 * common/filestuff.h: Rename include guard.
12010 * common/fileio.h: Rename include guard.
12011 * common/environ.h: Rename include guard.
12012 * common/common-utils.h: Rename include guard.
12013 * common/common-types.h: Rename include guard.
12014 * common/common-regcache.h: Rename include guard.
12015 * common/common-inferior.h: Rename include guard.
12016 * common/common-gdbthread.h: Rename include guard.
12017 * common/common-exceptions.h: Rename include guard.
12018 * common/common-defs.h: Rename include guard.
12019 * common/common-debug.h: Rename include guard.
12020 * common/cleanups.h: Rename include guard.
12021 * common/buffer.h: Rename include guard.
12022 * common/btrace-common.h: Rename include guard.
12023 * common/break-common.h: Rename include guard.
12024 * cli/cli-utils.h: Rename include guard.
12025 * cli/cli-style.h: Rename include guard.
12026 * cli/cli-setshow.h: Rename include guard.
12027 * cli/cli-script.h: Rename include guard.
12028 * cli/cli-interp.h: Rename include guard.
12029 * cli/cli-decode.h: Rename include guard.
12030 * cli/cli-cmds.h: Rename include guard.
12031 * charset-list.h: Add include guard.
12032 * buildsym-legacy.h: Rename include guard.
12033 * bfin-tdep.h: Add include guard.
12034 * ax.h: Rename include guard.
12035 * arm-linux-tdep.h: Add include guard.
12036 * arm-fbsd-tdep.h: Add include guard.
12037 * arch/xtensa.h: Rename include guard.
12038 * arch/tic6x.h: Add include guard.
12039 * arch/i386.h: Add include guard.
12040 * arch/arm.h: Rename include guard.
12041 * arch/arm-linux.h: Rename include guard.
12042 * arch/arm-get-next-pcs.h: Rename include guard.
12043 * arch/amd64.h: Add include guard.
12044 * arch/aarch64-insn.h: Rename include guard.
12045 * arch-utils.h: Rename include guard.
12046 * annotate.h: Add include guard.
12047 * amd64-darwin-tdep.h: Rename include guard.
12048 * aarch64-linux-tdep.h: Add include guard.
12049 * aarch64-fbsd-tdep.h: Add include guard.
12050 * aarch32-linux-nat.h: Add include guard.
12051
ab9268d2
PW
120522019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12053
12054 * macrotab.c (macro_define_internal): New function that
12055 factorizes macro_define_object_internal and macro_define_function
12056 code.
12057 (macro_define_object_internal): Use macro_define_internal.
12058 (macro_define_function): Likewise.
12059
bb0da2b4
PW
120602019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12061
12062 * macrocmd.c (extract_identifier): Return
12063 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12064 callers.
12065
424eb552
JB
120662019-02-06 John Baldwin <jhb@FreeBSD.org>
12067
12068 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12069
1688cb29
TT
120702019-02-05 Tom Tromey <tom@tromey.com>
12071
12072 * target.c (target_stack::unpush): Move assertion earlier.
12073
b5eba2d8
TT
120742019-01-30 Tom Tromey <tom@tromey.com>
12075
12076 PR python/23615:
12077 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12078 (gdbpy_parse_and_eval): Likewise.
12079 * python/python-internal.h (gdbpy_allow_threads): New class.
12080
7054e2ff
JB
120812019-01-28 John Baldwin <jhb@FreeBSD.org>
12082
12083 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12084 (aarch64_fbsd_fpregmap): Move earlier.
12085 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12086 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12087 instead of individual calls to trad_frame_set_reg_addr.
12088 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12089 earlier.
12090 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12091 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12092 instead of individual calls to trad_frame_set_reg_addr.
12093
36c25ffa
AH
120942019-01-28 Alan Hayward <alan.hayward@arm.com>
12095
12096 * CONTRIBUTE: Replace contribution list with wiki link.
12097
a0707f3c
TT
120982019-01-25 Tom Tromey <tom@tromey.com>
12099
12100 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12101
0747795c
TT
121022019-01-25 Tom Tromey <tom@tromey.com>
12103
12104 * xtensa-linux-nat.c: Fix common/ includes.
12105 * xml-support.h: Fix common/ includes.
12106 * xml-support.c: Fix common/ includes.
12107 * x86-linux-nat.c: Fix common/ includes.
12108 * windows-nat.c: Fix common/ includes.
12109 * varobj.h: Fix common/ includes.
12110 * varobj.c: Fix common/ includes.
12111 * value.c: Fix common/ includes.
12112 * valops.c: Fix common/ includes.
12113 * utils.c: Fix common/ includes.
12114 * unittests/xml-utils-selftests.c: Fix common/ includes.
12115 * unittests/utils-selftests.c: Fix common/ includes.
12116 * unittests/unpack-selftests.c: Fix common/ includes.
12117 * unittests/tracepoint-selftests.c: Fix common/ includes.
12118 * unittests/style-selftests.c: Fix common/ includes.
12119 * unittests/string_view-selftests.c: Fix common/ includes.
12120 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12121 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12122 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12123 * unittests/rsp-low-selftests.c: Fix common/ includes.
12124 * unittests/parse-connection-spec-selftests.c: Fix common/
12125 includes.
12126 * unittests/optional-selftests.c: Fix common/ includes.
12127 * unittests/offset-type-selftests.c: Fix common/ includes.
12128 * unittests/observable-selftests.c: Fix common/ includes.
12129 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12130 * unittests/memrange-selftests.c: Fix common/ includes.
12131 * unittests/memory-map-selftests.c: Fix common/ includes.
12132 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12133 * unittests/function-view-selftests.c: Fix common/ includes.
12134 * unittests/environ-selftests.c: Fix common/ includes.
12135 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12136 * unittests/common-utils-selftests.c: Fix common/ includes.
12137 * unittests/cli-utils-selftests.c: Fix common/ includes.
12138 * unittests/array-view-selftests.c: Fix common/ includes.
12139 * ui-file.c: Fix common/ includes.
12140 * tui/tui-io.c: Fix common/ includes.
12141 * tracepoint.h: Fix common/ includes.
12142 * tracepoint.c: Fix common/ includes.
12143 * tracefile-tfile.c: Fix common/ includes.
12144 * top.h: Fix common/ includes.
12145 * top.c: Fix common/ includes.
12146 * thread.c: Fix common/ includes.
12147 * target/waitstatus.h: Fix common/ includes.
12148 * target/waitstatus.c: Fix common/ includes.
12149 * target.h: Fix common/ includes.
12150 * target.c: Fix common/ includes.
12151 * target-memory.c: Fix common/ includes.
12152 * target-descriptions.c: Fix common/ includes.
12153 * symtab.h: Fix common/ includes.
12154 * symfile.c: Fix common/ includes.
12155 * stap-probe.c: Fix common/ includes.
12156 * spu-linux-nat.c: Fix common/ includes.
12157 * sparc-nat.c: Fix common/ includes.
12158 * source.c: Fix common/ includes.
12159 * solib.c: Fix common/ includes.
12160 * solib-target.c: Fix common/ includes.
12161 * ser-unix.c: Fix common/ includes.
12162 * ser-tcp.c: Fix common/ includes.
12163 * ser-pipe.c: Fix common/ includes.
12164 * ser-base.c: Fix common/ includes.
12165 * selftest-arch.c: Fix common/ includes.
12166 * s12z-tdep.c: Fix common/ includes.
12167 * rust-exp.y: Fix common/ includes.
12168 * rs6000-aix-tdep.c: Fix common/ includes.
12169 * riscv-tdep.c: Fix common/ includes.
12170 * remote.c: Fix common/ includes.
12171 * remote-notif.h: Fix common/ includes.
12172 * remote-fileio.h: Fix common/ includes.
12173 * remote-fileio.c: Fix common/ includes.
12174 * regcache.h: Fix common/ includes.
12175 * regcache.c: Fix common/ includes.
12176 * record-btrace.c: Fix common/ includes.
12177 * python/python.c: Fix common/ includes.
12178 * python/py-type.c: Fix common/ includes.
12179 * python/py-inferior.c: Fix common/ includes.
12180 * progspace.h: Fix common/ includes.
12181 * producer.c: Fix common/ includes.
12182 * procfs.c: Fix common/ includes.
12183 * proc-api.c: Fix common/ includes.
12184 * printcmd.c: Fix common/ includes.
12185 * ppc-linux-nat.c: Fix common/ includes.
12186 * parser-defs.h: Fix common/ includes.
12187 * osdata.c: Fix common/ includes.
12188 * obsd-nat.c: Fix common/ includes.
12189 * nat/x86-linux.c: Fix common/ includes.
12190 * nat/x86-linux-dregs.c: Fix common/ includes.
12191 * nat/x86-dregs.h: Fix common/ includes.
12192 * nat/x86-dregs.c: Fix common/ includes.
12193 * nat/ppc-linux.c: Fix common/ includes.
12194 * nat/mips-linux-watch.h: Fix common/ includes.
12195 * nat/mips-linux-watch.c: Fix common/ includes.
12196 * nat/linux-waitpid.c: Fix common/ includes.
12197 * nat/linux-ptrace.h: Fix common/ includes.
12198 * nat/linux-ptrace.c: Fix common/ includes.
12199 * nat/linux-procfs.c: Fix common/ includes.
12200 * nat/linux-personality.c: Fix common/ includes.
12201 * nat/linux-osdata.c: Fix common/ includes.
12202 * nat/linux-namespaces.c: Fix common/ includes.
12203 * nat/linux-btrace.h: Fix common/ includes.
12204 * nat/linux-btrace.c: Fix common/ includes.
12205 * nat/fork-inferior.c: Fix common/ includes.
12206 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12207 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12208 * nat/aarch64-linux.c: Fix common/ includes.
12209 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12210 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12211 * namespace.h: Fix common/ includes.
12212 * mips-linux-tdep.c: Fix common/ includes.
12213 * minsyms.c: Fix common/ includes.
12214 * mi/mi-parse.h: Fix common/ includes.
12215 * mi/mi-main.c: Fix common/ includes.
12216 * mi/mi-cmd-env.c: Fix common/ includes.
12217 * memrange.h: Fix common/ includes.
12218 * memattr.c: Fix common/ includes.
12219 * maint.h: Fix common/ includes.
12220 * maint.c: Fix common/ includes.
12221 * main.c: Fix common/ includes.
12222 * machoread.c: Fix common/ includes.
12223 * location.c: Fix common/ includes.
12224 * linux-thread-db.c: Fix common/ includes.
12225 * linux-nat.c: Fix common/ includes.
12226 * linux-fork.c: Fix common/ includes.
12227 * inline-frame.c: Fix common/ includes.
12228 * infrun.c: Fix common/ includes.
12229 * inflow.c: Fix common/ includes.
12230 * inferior.h: Fix common/ includes.
12231 * inferior.c: Fix common/ includes.
12232 * infcmd.c: Fix common/ includes.
12233 * inf-ptrace.c: Fix common/ includes.
12234 * inf-child.c: Fix common/ includes.
12235 * ia64-linux-nat.c: Fix common/ includes.
12236 * i387-tdep.c: Fix common/ includes.
12237 * i386-tdep.c: Fix common/ includes.
12238 * i386-linux-tdep.c: Fix common/ includes.
12239 * i386-linux-nat.c: Fix common/ includes.
12240 * i386-go32-tdep.c: Fix common/ includes.
12241 * i386-fbsd-tdep.c: Fix common/ includes.
12242 * i386-fbsd-nat.c: Fix common/ includes.
12243 * guile/scm-type.c: Fix common/ includes.
12244 * guile/guile.c: Fix common/ includes.
12245 * go32-nat.c: Fix common/ includes.
12246 * gnu-nat.c: Fix common/ includes.
12247 * gdbthread.h: Fix common/ includes.
12248 * gdbarch-selftests.c: Fix common/ includes.
12249 * gdb_usleep.c: Fix common/ includes.
12250 * gdb_select.h: Fix common/ includes.
12251 * gdb_bfd.c: Fix common/ includes.
12252 * gcore.c: Fix common/ includes.
12253 * fork-child.c: Fix common/ includes.
12254 * findvar.c: Fix common/ includes.
12255 * fbsd-nat.c: Fix common/ includes.
12256 * event-top.c: Fix common/ includes.
12257 * event-loop.c: Fix common/ includes.
12258 * dwarf2read.c: Fix common/ includes.
12259 * dwarf2loc.c: Fix common/ includes.
12260 * dwarf2-frame.c: Fix common/ includes.
12261 * dwarf-index-cache.c: Fix common/ includes.
12262 * dtrace-probe.c: Fix common/ includes.
12263 * disasm-selftests.c: Fix common/ includes.
12264 * defs.h: Fix common/ includes.
12265 * csky-tdep.c: Fix common/ includes.
12266 * cp-valprint.c: Fix common/ includes.
12267 * cp-support.h: Fix common/ includes.
12268 * cp-support.c: Fix common/ includes.
12269 * corelow.c: Fix common/ includes.
12270 * completer.h: Fix common/ includes.
12271 * completer.c: Fix common/ includes.
12272 * compile/compile.c: Fix common/ includes.
12273 * compile/compile-loc2c.c: Fix common/ includes.
12274 * compile/compile-cplus-types.c: Fix common/ includes.
12275 * compile/compile-cplus-symbols.c: Fix common/ includes.
12276 * command.h: Fix common/ includes.
12277 * cli/cli-dump.c: Fix common/ includes.
12278 * cli/cli-cmds.c: Fix common/ includes.
12279 * charset.c: Fix common/ includes.
12280 * build-id.c: Fix common/ includes.
12281 * btrace.h: Fix common/ includes.
12282 * btrace.c: Fix common/ includes.
12283 * breakpoint.h: Fix common/ includes.
12284 * breakpoint.c: Fix common/ includes.
12285 * ax.h:
12286 (enum agent_op): Fix common/ includes.
12287 * ax-general.c (struct aop_map): Fix common/ includes.
12288 * ax-gdb.c: Fix common/ includes.
12289 * auxv.c: Fix common/ includes.
12290 * auto-load.c: Fix common/ includes.
12291 * arm-tdep.c: Fix common/ includes.
12292 * arch/riscv.c: Fix common/ includes.
12293 * arch/ppc-linux-common.c: Fix common/ includes.
12294 * arch/i386.c: Fix common/ includes.
12295 * arch/arm.c: Fix common/ includes.
12296 * arch/arm-linux.c: Fix common/ includes.
12297 * arch/arm-get-next-pcs.c: Fix common/ includes.
12298 * arch/amd64.c: Fix common/ includes.
12299 * arch/aarch64.c: Fix common/ includes.
12300 * arch/aarch64-insn.c: Fix common/ includes.
12301 * arch-utils.c: Fix common/ includes.
12302 * amd64-windows-tdep.c: Fix common/ includes.
12303 * amd64-tdep.c: Fix common/ includes.
12304 * amd64-sol2-tdep.c: Fix common/ includes.
12305 * amd64-obsd-tdep.c: Fix common/ includes.
12306 * amd64-nbsd-tdep.c: Fix common/ includes.
12307 * amd64-linux-tdep.c: Fix common/ includes.
12308 * amd64-linux-nat.c: Fix common/ includes.
12309 * amd64-fbsd-tdep.c: Fix common/ includes.
12310 * amd64-fbsd-nat.c: Fix common/ includes.
12311 * amd64-dicos-tdep.c: Fix common/ includes.
12312 * amd64-darwin-tdep.c: Fix common/ includes.
12313 * agent.c: Fix common/ includes.
12314 * ada-lang.h: Fix common/ includes.
12315 * ada-lang.c: Fix common/ includes.
12316 * aarch64-tdep.c: Fix common/ includes.
12317
2f5c153e
TT
123182019-01-25 Tom Tromey <tom@tromey.com>
12319
12320 * common/create-version.sh: Use common/version.h.
12321
adc6a863
PA
123222019-01-24 Pedro Alves <palves@redhat.com>
12323
12324 * infrun.c (signal_stop, signal_print, signal_program)
12325 (signal_catch, signal_pass): Now arrays instead of pointers.
12326 (update_signals_program_target, do_target_resume)
12327 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12328 * linux-nat.c (linux_nat_target::pass_signals)
12329 (linux_nat_target::create_inferior, linux_nat_target::attach):
12330 Adjust.
12331 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12332 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12333 * procfs.c (procfs_target::pass_signals): Adjust.
12334 * record-full.c (record_full_target::resume): Adjust.
12335 * remote.c (remote_target::pass_signals)
12336 (remote_target::program_signals): Adjust.
12337 * target-debug.h (target_debug_print_signals): Now takes a
12338 gdb::array_view as parameter. Adjust.
12339 * target.h (target_ops) <pass_signals, program_signals>: Replace
12340 pointer and length parameters with gdb::array_view.
12341 (target_pass_signals, target_program_signals): Likewise.
12342 * target-delegates.c: Regenerate.
12343
3046d67a
PA
123442019-01-24 Pedro Alves <palves@redhat.com>
12345
12346 * common/forward-scope-exit.h
12347 (forward_scope_exit::forward_scope_exit): Pass arguments to
12348 m_bind_function directly, instead of creating a std::bind and
12349 copying that.
12350
353229bf
AH
123512019-01-24 Alan Hayward <alan.hayward@arm.com>
12352
12353 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12354 for static members.
12355 (pass_in_v_vfp_candidate): Likewise.
12356
311dc83a
TT
123572019-01-23 Tom Tromey <tom@tromey.com>
12358 Pedro Alves <palves@redhat.com>
12359
12360 * regcache.c (class regcache_invalidator): Remove.
12361 (regcache::raw_write): Use make_scope_exit.
12362
296bd123
TT
123632019-01-23 Tom Tromey <tom@tromey.com>
12364
12365 * ui-out.h (class ui_out_emit_type): Update comment.
12366
979a0d13
TT
123672019-01-23 Tom Tromey <tom@tromey.com>
12368
12369 * infrun.c (fetch_inferior_event): Update comment.
12370
d238133d
TT
123712019-01-23 Tom Tromey <tom@tromey.com>
12372 Pedro Alves <palves@redhat.com>
12373
12374 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12375 parameter.
12376 (fetch_inferior_event): Use SCOPE_EXIT.
12377
12378
9885e6bb
TT
123792019-01-23 Tom Tromey <tom@tromey.com>
12380 Pedro Alves <palves@redhat.com>
12381
12382 * infrun.c (disable_thread_events): Delete.
12383 (stop_all_threads): Use SCOPE_EXIT.
12384
286526c1
TT
123852019-01-23 Tom Tromey <tom@tromey.com>
12386 Pedro Alves <palves@redhat.com>
12387
12388 * symfile.c: Include forward-scope-exit.h.
12389 (clear_symtab_users_cleanup): Replace forward declaration with
12390 a FORWARD_SCOPE_EXIT.
12391 (syms_from_objfile_1): Use the forward_scope_exit and
12392 gdb::optional instead of cleanup_function.
12393 (reread_symbols): Use the forward_scope_exit instead of
12394 cleanup_function.
12395 (clear_symtab_users_cleanup): Remove function.
12396
1db93f14
TT
123972019-01-23 Tom Tromey <tom@tromey.com>
12398 Pedro Alves <palves@redhat.com>
12399
12400 * linux-nat.c: Include scope-exit.h.
12401 (cleanup_target_stop): Remove.
12402 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12403 SCOPE_EXIT.
12404
2cc83d1e
TT
124052019-01-23 Tom Tromey <tom@tromey.com>
12406 Pedro Alves <palves@redhat.com>
12407
12408 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12409 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12410
694c6bf5
TT
124112019-01-23 Tom Tromey <tom@tromey.com>
12412 Andrew Burgess <andrew.burgess@embecosm.com>
12413 Pedro Alves <palves@redhat.com>
12414
12415 * infrun.c (fetch_inferior_event): Use scope_exit.
12416 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12417 * top.c (execute_command): Use scope_exit.
12418 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12419 * utils.c (do_bpstat_clear_actions_cleanup)
12420 (make_bpstat_clear_actions_cleanup): Remove.
12421
4c41382a
TT
124222019-01-23 Tom Tromey <tom@tromey.com>
12423 Pedro Alves <palves@redhat.com>
12424
12425 * infrun.c: Include "common/scope-exit.h"
12426 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12427 (wait_for_inferior): Use SCOPE_EXIT.
12428 (fetch_inferior_event): Use scope_exit.
12429
89f8fb50
TT
124302019-01-23 Tom Tromey <tom@tromey.com>
12431 Pedro Alves <palves@redhat.com>
12432
12433 * breakpoint.c (create_breakpoint): Remove cleanup.
12434
5419bdae
TT
124352019-01-23 Tom Tromey <tom@tromey.com>
12436 Andrew Burgess <andrew.burgess@embecosm.com>
12437 Pedro Alves <palves@redhat.com>
12438
e587ef42
PA
124392019-01-23 Pedro Alves <palves@redhat.com>
12440
12441 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12442
77f0e74c
PA
124432019-01-23 Pedro Alves <palves@redhat.com>
12444 Andrew Burgess <andrew.burgess@embecosm.com>
12445
12446 * gdbthread.h: Include "common/forward-scope-exit.h".
12447 (scoped_finish_thread_state): Redefine custom class in terms of
12448 forward_scope_exit.
12449
5b9b3e53
PA
124502019-01-23 Pedro Alves <palves@redhat.com>
12451 Andrew Burgess <andrew.burgess@embecosm.com>
12452
12453 * common/forward-scope-exit.h: New file.
12454
54b65c9b
PA
124552019-01-23 Pedro Alves <palves@redhat.com>
12456 Andrew Burgess <andrew.burgess@embecosm.com>
12457 Tom Tromey <tom@tromey.com>
12458
12459 * common/scope-exit.h: New file.
12460
cf08fb29
PA
124612019-01-23 Pedro Alves <palves@redhat.com>
12462
12463 * common/preprocessor.h (ESC): Rename to ...
12464 (ESC_PARENS): ... this.
12465 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12466 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12467
ae73e2e2
TT
124682019-01-23 Tom Tromey <tom@tromey.com>
12469
12470 * language.h (class scoped_switch_to_sym_language_if_auto):
12471 Initialize m_lang in both cases.
12472
6594e122
AH
124732019-01-23 Alan Hayward <alan.hayward@arm.com>
12474
12475 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12476 with XCNEW.
12477
a7c9855d
TT
124782019-01-22 Tom Tromey <tom@tromey.com>
12479
12480 * corelow.c: Do not include sys/file.h.
12481
93cc1d53
TT
124822019-01-22 Tom Tromey <tom@tromey.com>
12483
12484 * tui/tui-wingeneral.h: Include gdb_curses.h.
12485
38561778
TT
124862019-01-22 Tom Tromey <tom@tromey.com>
12487
12488 * source-cache.h (class source_cache) <get_source_lines,
12489 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12490
37b3ab5b
TT
124912019-01-22 Tom Tromey <tom@tromey.com>
12492
12493 * remote-fileio.h (struct remote_target): Declare.
12494
3fabc016
TT
124952019-01-22 Tom Tromey <tom@tromey.com>
12496
12497 * python/py-arch.c: Do not include py-ref.h.
12498 * python/py-bpevent.c: Do not include py-ref.h.
12499 * python/py-cmd.c: Do not include py-ref.h.
12500 * python/py-continueevent.c: Do not include py-ref.h.
12501 * python/py-event.h: Do not include py-ref.h.
12502 * python/py-evtregistry.c: Do not include py-ref.h.
12503 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12504 * python/py-frame.c: Do not include py-ref.h.
12505 * python/py-framefilter.c: Do not include py-ref.h.
12506 * python/py-function.c: Do not include py-ref.h.
12507 * python/py-infevents.c: Do not include py-ref.h.
12508 * python/py-linetable.c: Do not include py-ref.h.
12509 * python/py-objfile.c: Do not include py-ref.h.
12510 * python/py-param.c: Do not include py-ref.h.
12511 * python/py-prettyprint.c: Do not include py-ref.h.
12512 * python/py-progspace.c: Do not include py-ref.h.
12513 * python/py-symbol.c: Do not include py-ref.h.
12514 * python/py-symtab.c: Do not include py-ref.h.
12515 * python/py-type.c: Do not include py-ref.h.
12516 * python/py-unwind.c: Do not include py-ref.h.
12517 * python/py-utils.c: Do not include py-ref.h.
12518 * python/py-value.c: Do not include py-ref.h.
12519 * python/py-varobj.c: Do not include py-ref.h.
12520 * python/py-xmethods.c: Do not include py-ref.h.
12521 * python/python.c: Do not include py-ref.h.
12522 * varobj.c: Do not include py-ref.h.
12523
6b4d7774
TT
125242019-01-22 Tom Tromey <tom@tromey.com>
12525
12526 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12527 keyword for bcache.
12528
7af7e9b5
TT
125292019-01-22 Tom Tromey <tom@tromey.com>
12530
12531 * compile/compile-cplus-types.c: Remove a comment by #include.
12532
951d1049
TT
125332019-01-22 Tom Tromey <tom@tromey.com>
12534
12535 * compile/gcc-c-plugin.h: Include compile-internal.h.
12536
d65d5705
TT
125372019-01-22 Tom Tromey <tom@tromey.com>
12538
12539 * stabsread.c (EXTERN): Do not define.
12540 (symnum, next_symbol_text_func, processing_gcc_compilation)
12541 (within_function, global_sym_chain, global_stabs)
12542 (previous_stab_code, this_object_header_files)
12543 (n_this_object_header_files)
12544 (n_allocated_this_object_header_files): Define.
12545 * stabsread.h (EXTERN): Never define. Use "extern".
12546
b6fb1ee5
PW
125472019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12548
12549 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12550 history_value.
12551
be6d4f74
TT
125522019-01-21 Tom Tromey <tom@tromey.com>
12553
12554 * ui-out.c: Fix includes.
12555 * tui/tui-source.c: Fix includes.
12556 * target.c: Fix includes.
12557 * remote.c: Fix includes.
12558 * regcache.c: Fix includes.
12559 * python/py-block.c: Fix includes.
12560 * printcmd.c: Fix includes.
12561 * or1k-tdep.c: Fix includes.
12562 * mi/mi-main.c: Fix includes.
12563 * m32r-tdep.c: Fix includes.
12564 * csky-tdep.c: Fix includes.
12565 * compile/compile-cplus-types.c: Fix includes.
12566 * cli/cli-interp.c: Fix includes.
12567
73021deb
AH
125682019-01-21 Alan Hayward <alan.hayward@arm.com>
12569
12570 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12571 for padding.
12572
7932255d
TT
125732019-01-16 Tom Tromey <tom@tromey.com>
12574
12575 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
12576 earlier.
12577 (struct objfile) <msymbols_range>: Move from top level.
12578 <msymbols>: New method.
12579 (class objfile_msymbols): Remove.
12580 * symtab.c (default_collect_symbol_completion_matches_break_on):
12581 Update.
12582 * symmisc.c (dump_msymbols): Update.
12583 * stabsread.c (scan_file_globals): Update.
12584 * objc-lang.c (info_selectors_command, info_classes_command)
12585 (find_methods): Update.
12586 * minsyms.c (find_solib_trampoline_target): Update.
12587 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12588 * coffread.c (coff_symfile_read): Update.
12589 * ada-lang.c (ada_lookup_simple_minsym)
12590 (ada_collect_symbol_completion_matches): Update.
12591
604b1bfb
TT
125922019-01-16 Tom Tromey <tom@tromey.com>
12593
12594 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12595 type. Remove no-argument constructor.
12596 <iterator::operator++>: Simplify.
12597 <begin>: Update.
12598 <end>: Use minimal_symbol_count.
12599
f252c6d5
TT
126002019-01-16 Tom Tromey <tom@tromey.com>
12601
12602 * objfiles.h (struct objfile) <psymtabs>: New method.
12603 (class objfile_psymtabs): Remove.
12604 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12605 typedef.
12606 <range>: New method.
12607 (require_partial_symbols): Change return type.
12608 * psymtab.c (require_partial_symbols)
12609 (psym_expand_symtabs_matching): Update.
12610 * mdebugread.c (parse_partial_symbols): Update.
12611 * dbxread.c (dbx_end_psymtab): Update.
12612
b669c953
TT
126132019-01-15 Tom Tromey <tom@tromey.com>
12614
12615 * symtab.c (lookup_objfile_from_block)
12616 (lookup_symbol_in_objfile_symtabs)
12617 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12618 (find_line_symtab, info_sources_command)
12619 (default_collect_symbol_completion_matches_break_on)
12620 (make_source_files_completion_list): Update.
12621 * symmisc.c (print_objfile_statistics, dump_objfile)
12622 (maintenance_print_symbols, maintenance_info_symtabs)
12623 (maintenance_check_symtabs, maintenance_info_line_tables):
12624 Update.
12625 * source.c (select_source_symtab)
12626 (forget_cached_source_info_for_objfile): Update.
12627 * objfiles.h (class objfile_compunits): Remove.
12628 (struct objfile) <compunits_range>: New typedef.
12629 (compunits): New method.
12630 * objfiles.c (objfile_relocate1): Update.
12631 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12632 * maint.c (count_symtabs_and_blocks): Update.
12633 * linespec.c (iterate_over_all_matching_symtabs): Update.
12634 * cp-support.c (add_symbol_overload_list_qualified): Update.
12635 * coffread.c (coff_symtab_read): Update.
12636 * ada-lang.c (add_nonlocal_symbols)
12637 (ada_collect_symbol_completion_matches)
12638 (ada_add_global_exceptions): Update.
12639
7e955d83
TT
126402019-01-15 Tom Tromey <tom@tromey.com>
12641
12642 * progspace.h (program_space) <objfiles_safe_range>: New
12643 typedef.
12644 <objfiles_safe>: New method.
12645 * objfiles.h (class all_objfiles_safe): Remove.
12646 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12647 * jit.c (jit_inferior_exit_hook): Update.
12648
2030c079
TT
126492019-01-17 Tom Tromey <tom@tromey.com>
12650
12651 * progspace.h (program_space) <objfiles_range>: New typedef.
12652 <objfiles>: New method.
12653 <objfiles_head>: Rename from objfiles.
12654 (object_files): Update.
12655 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12656 * guile/scm-pretty-print.c
12657 (ppscm_find_pretty_printer_from_objfiles): Update.
12658 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12659 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12660 Update.
12661 * python/py-progspace.c (pspy_get_objfiles): Update.
12662 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12663 Update.
12664 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12665 (objfpy_lookup_objfile_by_build_id): Update.
12666 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12667 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12668 Update.
12669 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12670 (expand_symtab_containing_pc, lookup_objfile_from_block)
12671 (lookup_static_symbol, basic_lookup_transparent_type)
12672 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12673 (find_line_symtab, info_sources_command)
12674 (default_collect_symbol_completion_matches_break_on)
12675 (make_source_files_completion_list, find_main_name): Update.
12676 * symmisc.c (print_symbol_bcache_statistics)
12677 (print_objfile_statistics, maintenance_print_symbols)
12678 (maintenance_print_msymbols, maintenance_print_objfiles)
12679 (maintenance_info_symtabs, maintenance_check_symtabs)
12680 (maintenance_expand_symtabs, maintenance_info_line_tables):
12681 Update.
12682 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12683 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12684 (map_overlay_command, unmap_overlay_command)
12685 (simple_overlay_update, expand_symtabs_matching)
12686 (map_symbol_filenames): Update.
12687 * symfile-debug.c (set_debug_symfile): Update.
12688 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12689 Update.
12690 * source.c (select_source_symtab, forget_cached_source_info):
12691 Update.
12692 * solib.c (solib_read_symbols): Update.
12693 * solib-spu.c (append_ocl_sos): Update.
12694 * psymtab.c (maintenance_print_psymbols)
12695 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12696 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12697 * printcmd.c (info_symbol_command): Update.
12698 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12699 Update.
12700 * objfiles.h (class all_objfiles): Remove.
12701 * objfiles.c (have_partial_symbols, have_full_symbols)
12702 (have_minimal_symbols, qsort_cmp, update_section_map)
12703 (shared_objfile_contains_address_p)
12704 (default_iterate_over_objfiles_in_search_order): Update.
12705 * objc-lang.c (info_selectors_command, info_classes_command)
12706 (find_methods): Update.
12707 * minsyms.c (find_solib_trampoline_target): Update.
12708 * maint.c (maintenance_info_sections)
12709 (maintenance_translate_address, count_symtabs_and_blocks):
12710 Update.
12711 * main.c (captured_main_1): Update.
12712 * linux-thread-db.c (try_thread_db_load_from_pdir)
12713 (has_libpthread): Update.
12714 * linespec.c (iterate_over_all_matching_symtabs)
12715 (search_minsyms_for_name): Update.
12716 * jit.c (jit_find_objf_with_entry_addr): Update.
12717 * hppa-tdep.c (find_unwind_entry)
12718 (hppa_lookup_stub_minimal_symbol): Update.
12719 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12720 Update.
12721 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12722 (elf_gnu_ifunc_resolve_by_got): Update.
12723 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12724 * dwarf-index-write.c (save_gdb_index_command): Update.
12725 * cp-support.c (add_symbol_overload_list_qualified): Update.
12726 * breakpoint.c (create_overlay_event_breakpoint)
12727 (create_longjmp_master_breakpoint)
12728 (create_std_terminate_master_breakpoint)
12729 (create_exception_master_breakpoint): Update.
12730 * blockframe.c (find_pc_partial_function): Update.
12731 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12732 (ada_collect_symbol_completion_matches)
12733 (ada_add_global_exceptions): Update.
12734
776489e0
TT
127352019-01-17 Tom Tromey <tom@tromey.com>
12736
12737 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12738 declare VEC.
12739 (solib_target_parse_libraries): Change return type.
12740 (library_list_start_segment, library_list_start_section)
12741 (library_list_end_library, library_list_start_library); Update.
12742 (solib_target_free_library_list): Remove.
12743 (solib_target_parse_libraries): Remove cleanup. Change return
12744 type.
12745 (solib_target_current_sos): Update.
12746
6471e7d2
TT
127472019-01-17 Tom Tromey <tromey@bapiya>
12748
12749 * valprint.c: Replace "the the" with "the".
12750 * symtab.c: Replace "the the" with "the".
12751 * solib.c: Replace "the the" with "the".
12752 * solib-dsbt.c: Replace "the the" with "the".
12753 * linespec.c: Replace "the the" with "the".
12754 * dwarf2loc.h: Replace "the the" with "the".
12755 * amd64-windows-tdep.c: Replace "the the" with "the".
12756 * aarch64-tdep.c: Replace "the the" with "the".
12757
c24bdb02
KS
127582019-01-16 Keith Seitz <keiths@redhat.com>
12759
12760 PR gdb/23773
12761 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12762 <builder>: Rename to ..
12763 <m_builder>: ... this and make private.
12764 (dwarf2_cu::get_builder): New method. Change all users of
12765 `builder' to use this method.
12766 (dwarf2_start_symtab): Move to ...
12767 (dwarf2_cu::start_symtab): ... here. Update all callers
12768 (setup_type_unit_groups): Move to ...
12769 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12770 callers.
12771 (dwarf2_cu::reset_builder): New method.
12772 (process_full_compunit, process_full_type_unit): Use
12773 dwarf2_cu::reset_builder.
12774 (follow_die_offset): Record the ancestor CU if it is different
12775 from the followed DIE's CU.
12776 (follow_die_sig_1): Likewise.
12777
8d64371b
TT
127782019-01-15 Tom Tromey <tom@tromey.com>
12779
12780 * remote.c (class remote_state) <buf>: Now a char_vector.
12781 <buf_size>: Remove.
12782 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12783 parameter.
12784 (remote_target::getpkt_or_notif_sane_1)
12785 (remote_target::getpkt_sane)
12786 (remote_target::getpkt_or_notif_sane): Likewise.
12787 (class remote_target) <putpkt>: New overload.
12788 (remote_target::read_frame): Change type of "buf_p". Remove
12789 sizeof_p parameter.
12790 (packet_ok): New overload.
12791 (packet_check_result): New overload.
12792 Update all uses.
12793
bb277751
TT
127942019-01-14 Tom Tromey <tom@tromey.com>
12795
12796 * remote-notif.c (handle_notification, remote_notif_ack)
12797 (remote_notif_parse): Make "buf" const.
12798 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12799 const.
12800 (remote_notif_parse, remote_notif_ack, handle_notification):
12801 Likewise.
12802 * remote.c (remote_notif_stop_parse): Make "buf" const.
12803 (remote_target::remote_parse_stop_reply): Make "buf" const.
12804 (remote_notif_stop_ack): Make "buf" const.
12805
05be00a8
TT
128062019-01-14 Tom Tromey <tom@tromey.com>
12807
12808 * remote.c (remote_console_output): Make parameter const.
12809
491adeca
TT
128102019-01-14 Tom Tromey <tom@tromey.com>
12811
12812 * target-debug.h (target_debug_print_signals): Constify.
12813 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12814 * procfs.c (procfs_target::pass_signals): Update.
12815 * linux-nat.c (linux_nat_target::pass_signals): Update.
12816 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12817 * target-delegates.c: Rebuild.
12818 * remote.c (remote_target::program_signals): Update.
12819 (remote_target::pass_signals): Update.
12820 * target.c (target_pass_signals): Constify argument.
12821 (target_program_signals): Likewise.
12822 * target.h (struct target_ops) <pass_signals, program_signals>:
12823 Constify argument.
12824 (target_pass_signals, target_program_signals): Constify argument.
12825
bbd94648
TT
128262019-01-14 Tom Tromey <tom@tromey.com>
12827
12828 PR tui/28819:
12829 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12830
6f072a10
PFC
128312019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12832
12833 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12834 field.
12835 * rs6000-tdep.c: Include reggroups.h.
12836 (IS_V_ALIAS_PSEUDOREG): Define.
12837 (rs6000_register_name): Return names for the "vX" aliases.
12838 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12839 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12840 aliases. Call default_register_reggroup_p for all other
12841 pseudo-registers.
12842 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12843 New functions.
12844 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12845 Handle "vX" aliases.
12846 (v_alias_pseudo_register_collect): New function.
12847 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12848 (rs6000_gdbarch_init): Initialize "vX" aliases as
12849 pseudo-registers. Restore registration of
12850 rs6000_pseudo_register_reggroup_p with
12851 set_tdesc_pseudo_register_reggroup_p.
12852
1a782351
MF
128532019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12854
12855 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12856 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12857 set_gdbarch_num_pseudo_regs.
12858
d73cff18
PW
128592019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12860
12861 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12862 Remove arg prefixname, add do_set and do_show.
12863 Add member functions set_list and show_list.
12864 * cli/cli-style.c (class cli_style_option): Update accordingly.
12865 (style_set_list): Move to file scope.
12866 (style_show_list): Likewise.
12867 (set_style): Call help_list.
12868 (show_style): Call cmd_show_list.
12869 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12870 Update to use the new macro.
12871
60a90376
JB
128722019-10-12 Joel Brobecker <brobecker@adacore.com>
12873
12874 * ada-lang.c (_initialize_ada_language): Expand the help text
12875 for the "catch exception" command.
12876
9d7c67bf
PW
128772019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12878
12879 * symtab.c (matching_obj_sections): Initialize obj,
12880 declare it closer to its usage.
12881
7cf47dc4
TT
128822019-01-10 Tom Tromey <tom@tromey.com>
12883
12884 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12885 (basic_inf_threads_range): Remove.
12886 (inf_threads_range, inf_non_exited_threads_range)
12887 (safe_inf_threads_range): Use next_adapter.
12888
d3cb6808
KS
128892019-01-10 Keith Seitz <keiths@redhat.com>
12890
12891 PR gdb/23712
12892 PR symtab/23010
12893 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12894 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12895
63a20375
KS
128962019-01-10 Keith Seitz <keiths@redhat.com>
12897
12898 PR gdb/23712
12899 PR symtab/23010
12900 * dictionary.c (pending_to_vector): Remove.
12901 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12902 Remove _1 suffix, replacing functions of the same name. Update
12903 all callers.
12904 (dict_create_hashed, dict_create_hashed_expandable)
12905 (dict_create_linear, dict_create_linear_expandable, dict_free)
12906 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12907 Make functions static.
12908
b026f593
KS
129092019-01-10 Keith Seitz <keiths@redhat.com>
12910
12911 PR gdb/23712
12912 PR symtab/23010
12913 * dictionary.h (struct dictionary): Replace declaration with
12914 multidictionary.
12915 (dict_create_hashed, dict_create_hashed_expandable)
12916 (dict_create_linear, dict_create_linear_expandable)
12917 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12918 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12919 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12920 taking multidictionary argument.
12921 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12922 * block.h (struct block) <dict>: Change to multidictionary
12923 and rename `multidict'.
12924 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12925 symmisc.c: Update all dictionary references to multidictionary.
12926
c7748ee9
KS
129272019-01-10 Keith Seitz <keiths@redhat.com>
12928
12929 PR gdb/23712
12930 PR symtab/23010
12931 * dictionary.c: Include unordered_map.
12932 (pending_to_vector): New function.
12933 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12934 Rewrite the non-"_1" functions to take vector instead
12935 of linked list.
12936 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12937 "new" _1 versions of the same name.
12938 (multidictionary): Define.
12939 (std::hash<enum language): New definition.
12940 (collate_pending_symbols_by_language, mdict_create_hashed)
12941 (mdict_create_hashed_expandable, mdict_create_linear)
12942 (mdict_create_linear_expandable, mdict_free)
12943 (find_language_dictionary, create_new_language_dictionary)
12944 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12945 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12946 (mdict_size, mdict_empty): New functions.
12947 * dictionary.h (mdict_iterator): Define.
12948
67aa1f3c
PA
129492019-01-10 Pedro Alves <palves@redhat.com>
12950
12951 * breakpoint.c (read_uploaded_action)
12952 (create_tracepoint_from_upload): Adjust to use
12953 gdb::unique_xmalloc_ptr.
12954 * ctf.c (ctf_write_uploaded_tp):
12955 (SET_ARRAY_FIELD): Use emplace_back.
12956 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12957 * tracefile-tfile.c (tfile_write_uploaded_tp):
12958 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12959 gdb::unique_xmalloc_ptr.
12960 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12961 at_string, cond_string, cmd_strings>: Replace char pointers
12962 with gdb::unique_xmalloc_ptr.
12963
2f667667
PA
129642019-01-10 Pedro Alves <palves@redhat.com>
12965
12966 * solib-target.c (library_list_start_library): Don't xstrdup name.
12967
36cb7237
PA
129682019-01-10 Pedro Alves <palves@redhat.com>
12969
12970 * mdebugread.c (parse_partial_symbols): Use
12971 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12972
da584958
AB
129732019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12974
12975 * linux-fork.c (scoped_switch_fork_info)
12976 <~scoped_switch_fork_info>: Fix incorrect variable name.
12977
1ef8573c
AB
129782019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12979
12980 * linux-fork.c (scoped_switch_fork_info)
12981 <scoped_switch_fork_info>: Make explicit.
12982 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12983
8d7bcccb
TT
129842019-01-10 Tom Tromey <tom@tromey.com>
12985
12986 * objfiles.h (objfile::reset_psymtabs): Update.
12987 * objfiles.c (objfile::objfile): Update.
12988 * psymtab.h (psymtab_storage::obstack): Update.
12989 (psymtab_storage::m_obstack): Use gdb::optional.
12990 (class psymtab_storage): Update comment. Remove objfile
12991 parameter.
12992 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12993
b596a3c7
TT
129942019-01-10 Tom Tromey <tom@tromey.com>
12995
12996 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12997 <free_psymtabs>: Now private.
12998 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12999 (allocate_psymtab): Use new method.
13000
a9342b62
TT
130012019-01-10 Tom Tromey <tom@tromey.com>
13002
13003 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13004 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13005 * mdebugread.c (parse_partial_symbols): Use
13006 allocate_dependencies.
13007 * dwarf2read.c (dwarf2_create_include_psymtab): Use
13008 allocate_dependencies.
13009 (process_psymtab_comp_unit_reader)
13010 (build_type_psymtab_dependencies): Likewise.
13011 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13012
5af70966
TT
130132019-01-10 Tom Tromey <tom@tromey.com>
13014
13015 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13016 PSYMBOL_SET_LANGUAGE.
13017 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13018
5923a04c
TT
130192019-01-10 Tom Tromey <tom@tromey.com>
13020
13021 * psymtab.h (psymtab_storage::obstack): New method.
13022 <m_obstack>: Rename from obstack; now private.
13023 * psymtab.c (psymtab_storage): Update.
13024 * dwarf2read.c (create_addrmap_from_index)
13025 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13026 Update.
13027
6d6a12bf
TT
130282019-01-10 Tom Tromey <tom@tromey.com>
13029
13030 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13031 * objfiles.h (objfile::reset_psymtabs): New method.
13032
d320c2b5
TT
130332019-01-10 Tom Tromey <tom@tromey.com>
13034
13035 * symmisc.c (print_symbol_bcache_statistics): Update.
13036 (print_objfile_statistics): Update.
13037 * symfile.c (reread_symbols): Update.
13038 * psymtab.h (class psymtab_storage): New.
13039 * psymtab.c (psymtab_storage): New constructor.
13040 (~psymtab_storage): New destructor.
13041 (require_partial_symbols): Update.
13042 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13043 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13044 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13045 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13046 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13047 (start_psymtab_common, end_psymtab_common)
13048 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13049 (allocate_psymtab): Update.
13050 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13051 Update.
13052 (dump_psymtab_addrmap, maintenance_print_psymbols)
13053 (maintenance_check_psymtabs): Update.
13054 (class objfile_psymtabs): Move to objfiles.h.
13055 * psympriv.h (discard_psymtab): Now inline.
13056 (psymtab_discarder::psymtab_discarder): Update.
13057 (psymtab_discarder::~psymtab_discarder): Update.
13058 (ALL_OBJFILE_PSYMTABS): Rewrite.
13059 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13060 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13061 Remove fields.
13062 <partial_symtabs>: New field.
13063 (class objfile_psymtabs): Move from psymtab.h. Update.
13064 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13065 psymbol_cache.
13066 (objfile::~objfile): Don't destroy psymbol_cache.
13067 * mdebugread.c (parse_partial_symbols): Update.
13068 * dwarf2read.c (create_addrmap_from_index)
13069 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13070 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13071 (add_partial_subprogram, dwarf2_ranges_read): Update.
13072 * dwarf-index-write.c (write_address_map)
13073 (write_one_signatured_type, recursively_write_psymbols)
13074 (class debug_names, class debug_names, write_psymtabs_to_index):
13075 Update.
13076
1d94a5a3
TT
130772019-01-10 Tom Tromey <tom@tromey.com>
13078
13079 * symtab.h (SYMBOL_SET_NAMES): Update.
13080 (symbol_set_names): Update.
13081 (MSYMBOL_SET_NAMES): Update.
13082 * symtab.c (symbol_set_names): Change argument to be an
13083 objfile_per_bfd_storage.
13084 * psymtab.c (add_psymbol_to_bcache): Update.
13085 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13086
0f14768a
TT
130872019-01-10 Tom Tromey <tom@tromey.com>
13088
13089 * symtab.c (create_demangled_names_hash): Change argument to be an
13090 objfile_per_bfd_storage.
13091 (symbol_set_names): Update.
13092
6eee24ce
TT
130932019-01-10 Tom Tromey <tom@tromey.com>
13094
13095 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13096 init_psymbol_list.
13097 * psymtab.c (init_psymbol_list): Do nothing if already called.
13098 * psympriv.h (init_psymbol_list): Add comment.
13099 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13100 init_psymbol_list.
13101 * dbxread.c (dbx_symfile_read): Unconditionally call
13102 init_psymbol_list.
13103
75aedd27
TT
131042019-01-10 Tom Tromey <tom@tromey.com>
13105
13106 * xcoffread.c (scan_xcoff_symtab): Update.
13107 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13108 "where".
13109 * mdebugread.c (parse_partial_symbols)
13110 (handle_psymbol_enumerators): Update.
13111 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13112 * dbxread.c (read_dbx_symtab): Update.
13113 * psympriv.h (psymbol_placement): New enum.
13114 (add_psymbol_to_list): Update.
13115
939652a5
TT
131162019-01-10 Tom Tromey <tom@tromey.com>
13117
13118 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13119 static_psymbols parameters.
13120 (scan_xcoff_symtab): Update.
13121 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13122 static_psymbols parameters.
13123 * psympriv.h (start_psymtab_common): Update.
13124 * mdebugread.c (parse_partial_symbols): Update.
13125 * dwarf2read.c (create_partial_symtab): Update.
13126 * dbxread.c (read_dbx_symtab): Update.
13127 (start_psymtab): Remove global_psymbols and static_psymbols
13128 parameters.
13129
baa62830
TT
131302019-01-10 Tom Tromey <tom@tromey.com>
13131
13132 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13133 * psymtab.c (allocate_psymtab): Add comment.
13134 * psympriv.h (allocate_psymtab): Add comment.
13135 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13136 initializations.
13137 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13138
0e8f53ba
TT
131392019-01-10 Tom Tromey <tom@tromey.com>
13140
13141 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13142 Don't declare.
13143 * mipsread.c: Include mdebugread.h.
13144 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13145 Declare.
13146 * elfread.c: Include mdebugread.h.
13147
b22a7c6a
TT
131482019-01-09 Tom Tromey <tom@tromey.com>
13149
13150 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13151 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13152 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13153 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13154 (psym_lookup_symbol, psym_find_last_source_symtab)
13155 (psym_forget_cached_source_info, psym_print_stats)
13156 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13157 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13158 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13159 (psym_find_compunit_symtab_by_address)
13160 (maintenance_print_psymbols, maintenance_info_psymtabs)
13161 (maintenance_check_psymtabs): Use ranged for.
13162 * psymtab.h (class objfile_psymtabs): New.
13163 (require_partial_symbols): Return objfile_psymtabs.
13164 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13165
3b9d3ac2
TT
131662019-01-09 Tom Tromey <tom@tromey.com>
13167
13168 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13169 (find_pc_mapped_section, list_overlays_command)
13170 (map_overlay_command, unmap_overlay_command)
13171 (simple_overlay_update): Use all_objfiles.
13172 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13173 * printcmd.c (info_symbol_command): Use all_objfiles.
13174 * objfiles.h (ALL_OBJSECTIONS): Remove.
13175 * maint.c (maintenance_translate_address): Use all_objfiles.
13176 * gcore.c (gcore_create_callback): Use all_objfiles.
13177 (objfile_find_memory_regions): Likewise.
13178
8b31193a
TT
131792019-01-09 Tom Tromey <tom@tromey.com>
13180
13181 * symtab.c (find_line_symtab, info_sources_command)
13182 (make_source_files_completion_list): Use objfile_compunits.
13183 * source.c (select_source_symtab): Use objfile_compunits.
13184 * objfiles.h (struct objfile): Update comment.
13185 (ALL_OBJFILES): Remove.
13186 (ALL_FILETABS): Remove.
13187 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13188 objfile_compunits.
13189
d5da8b3c
TT
131902019-01-09 Tom Tromey <tom@tromey.com>
13191
13192 * symmisc.c (print_objfile_statistics, dump_objfile)
13193 (maintenance_print_symbols): Use compunit_filetabs.
13194 * source.c (forget_cached_source_info_for_objfile): Use
13195 compunit_filetabs.
13196 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13197 (ALL_FILETABS): Use compunit_filetabs.
13198 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13199 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13200
5accd1a0
TT
132012019-01-09 Tom Tromey <tom@tromey.com>
13202
13203 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13204 (compunit_filetabs): New.
13205 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13206 compunit_filetabs.
13207 (info_sources_command, make_source_files_completion_list): Remove
13208 declaration.
13209 * symmisc.c (print_objfile_statistics, dump_objfile)
13210 (maintenance_print_symbols): Remove declaration.
13211 (maintenance_info_symtabs): Use compunit_filetabs.
13212 (maintenance_info_line_tables): Likewise.
13213 * source.c (select_source_symtab): Change local variable name.
13214 (forget_cached_source_info_for_objfile): Remove declaration.
13215 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13216 * objfiles.c (objfile_relocate1): Remove declaration.
13217 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13218 declaration.
13219 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13220 * coffread.c (coff_symtab_read): Remove declaration.
13221 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13222 compunit_filetabs.
13223
d8aeb77f
TT
132242019-01-09 Tom Tromey <tom@tromey.com>
13225
13226 * symtab.c (lookup_objfile_from_block)
13227 (find_pc_sect_compunit_symtab, search_symbols)
13228 (default_collect_symbol_completion_matches_break_on): Use
13229 objfile_compunits.
13230 * objfiles.h (ALL_COMPUNITS): Remove.
13231 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13232 * cp-support.c (add_symbol_overload_list_qualified): Use
13233 objfile_compunits.
13234 * ada-lang.c (ada_collect_symbol_completion_matches)
13235 (ada_add_global_exceptions): Use objfile_compunits.
13236
592553c4
TT
132372019-01-09 Tom Tromey <tom@tromey.com>
13238
13239 * source.c (select_source_symtab)
13240 (forget_cached_source_info_for_objfile): Remove declaration.
13241 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13242 declaration.
13243 * maint.c (count_symtabs_and_blocks): Remove declaration.
13244 * cp-support.c (add_symbol_overload_list_qualified): Remove
13245 declaration.
13246 * coffread.c (coff_symtab_read): Remove declaration.
13247 * symtab.c (lookup_symbol_in_objfile_symtabs)
13248 (basic_lookup_transparent_type_1): Use objfile_compunits.
13249 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13250 (info_sources_command, search_symbols)
13251 (default_collect_symbol_completion_matches_break_on)
13252 (make_source_files_completion_list): Remove declaration.
13253 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13254 (ada_collect_symbol_completion_matches)
13255 (ada_add_global_exceptions): Remove declaration.
13256 * linespec.c (iterate_over_all_matching_symtabs): Use
13257 objfile_compunits.
13258 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13259 (class objfile_compunits): New.
13260 (ALL_COMPUNITS): Use objfile_compunits.
13261 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13262 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13263 objfile_compunits.
13264 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13265
5325b9bf
TT
132662019-01-09 Tom Tromey <tom@tromey.com>
13267
13268 * symtab.c (search_symbols)
13269 (default_collect_symbol_completion_matches_break_on): Use
13270 objfile_msymbols.
13271 * ada-lang.c (ada_lookup_simple_minsym)
13272 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13273 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13274 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13275 objfile_msymbols.
13276 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13277 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13278 * objc-lang.c (find_methods): Use objfile_msymbols.
13279 (info_selectors_command, info_classes_command): Likewise.
13280 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13281 * objfiles.h (class objfile_msymbols): New.
13282 (ALL_OBJFILE_MSYMBOLS): Remove.
13283 (ALL_MSYMBOLS): Remove.
13284
cac85af2
TT
132852019-01-09 Tom Tromey <tom@tromey.com>
13286
13287 * common/next-iterator.h (next_adapter): Add Iterator template
13288 parameter.
13289 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13290 (class all_objfiles_safe): New.
13291 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13292 * objfiles.c (put_objfile_before): Update comment.
13293 (add_separate_debug_objfile): Likewise.
13294 (free_all_objfiles): Use all_objfiles_safe.
13295 (objfile_purge_solibs): Likewise.
13296
aed57c53
TT
132972019-01-09 Tom Tromey <tom@tromey.com>
13298
13299 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13300 (expand_symtab_containing_pc, lookup_static_symbol)
13301 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13302 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13303 all_objfiles.
13304 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13305 * breakpoint.c (create_overlay_event_breakpoint)
13306 (create_longjmp_master_breakpoint)
13307 (create_std_terminate_master_breakpoint)
13308 (create_exception_master_breakpoint): Use all_objfiles.
13309 * linux-thread-db.c (try_thread_db_load_from_pdir)
13310 (has_libpthread): Use all_objfiles.
13311 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13312 * linespec.c (iterate_over_all_matching_symtabs)
13313 (search_minsyms_for_name): Use all_objfiles.
13314 * maint.c (maintenance_info_sections): Use all_objfiles.
13315 * main.c (captured_main_1): Use all_objfiles.
13316 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13317 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13318 * guile/scm-pretty-print.c
13319 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13320 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13321 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13322 (maintenance_print_msymbols): Use all_objfiles.
13323 * source.c (select_source_symtab): Use all_objfiles.
13324 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13325 * symfile.c (remove_symbol_file_command)
13326 (expand_symtabs_matching, map_symbol_filenames): Use
13327 all_objfiles.
13328 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13329 all_objfiles.
13330 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13331 * objc-lang.c (find_methods): Use all_objfiles.
13332 * objfiles.c (have_partial_symbols, have_full_symbols)
13333 (have_minimal_symbols, qsort_cmp)
13334 (default_iterate_over_objfiles_in_search_order): Use
13335 all_objfiles.
13336 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13337 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13338 (maintenance_check_psymtabs): Use all_objfiles.
13339 (ALL_PSYMTABS): Remove.
13340 * compile/compile-object-run.c (do_module_cleanup): Use
13341 all_objfiles.
13342 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13343 * cp-support.c (add_symbol_overload_list_qualified): Use
13344 all_objfiles.
13345 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13346 Use all_objfiles.
13347 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13348 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13349 all_objfiles.
13350 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13351 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13352 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13353 Uses all_objfiles.
13354 * solib.c (solib_read_symbols): Use all_objfiles
13355
99d89cde
TT
133562019-01-09 Tom Tromey <tom@tromey.com>
13357
13358 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13359 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13360 all_objfiles.
13361 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13362 * symmisc.c (print_symbol_bcache_statistics)
13363 (print_objfile_statistics, maintenance_print_objfiles)
13364 (maintenance_info_symtabs, maintenance_check_symtabs)
13365 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13366 all_objfiles.
13367 * source.c (forget_cached_source_info): Use all_objfiles.
13368 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13369 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13370 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13371 * objfiles.c (update_section_map): Use all_objfiles.
13372 (shared_objfile_contains_address_p): Likewise.
13373 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13374 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13375
21708325
TT
133762019-01-09 Tom Tromey <tom@tromey.com>
13377
13378 * common/next-iterator.h: New file.
13379 * objfiles.h (class all_objfiles): New.
13380 (struct objfile_iterator): New.
13381
669e09f6
PW
133822019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13383
13384 * NEWS: Move the description of the changed "frame", "select-frame",
13385 and "info frame" commands to the Changed commands section.
13386
041be526
SM
133872019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13388
13389 * gdbtypes.c (check_stub_method_group): Remove handling of old
13390 mangling schemes.
13391 * linespec.c (find_methods): Likewise.
13392 * stabsread.c (read_member_functions): Likewise.
13393 * valops.c (search_struct_method): Likewise.
13394 (value_struct_elt_for_reference): Likewise.
13395 * NEWS: Mention this change.
13396
0e2a2133
AB
133972019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13398
13399 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13400 print_source_lines.
13401 * source.c (print_source_lines_base): Update line number check.
13402 (print_source_lines): New function.
13403 (source_lines_range::source_lines_range): New function.
13404 * source.h (class source_lines_range): New class.
13405 (print_source_lines): New declaration.
13406
1055a3b4
PW
134072019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13408
13409 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13410
cfeadda5
TT
134112019-01-08 Tom Tromey <tom@tromey.com>
13412 Simon Marchi <simon.marchi@ericsson.com>
13413
13414 PR gdb/24060
13415 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13416 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13417 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13418 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13419 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13420 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13421
583068ca
AB
134222019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13423
13424 * source.c (select_source_symtab): Move header comment to
13425 declaration in source.h.
13426 (forget_cached_source_info_for_objfile): Likewise.
13427 (forget_cached_source_info): Likewise.
13428 (identify_source_line): Likewise.
13429 * source.h (identify_source_line): Move declaration from symtab.h
13430 and add comment from source.c
13431 (print_source_lines): Likewise.
13432 (forget_cached_source_info_for_objfile): Likewise.
13433 (forget_cached_source_info): Likewise.
13434 (select_source_symtab): Likewise.
13435 (enum print_source_lines_flag): Move definition from symtab.h.
13436 * symtab.h (identify_source_line): Move declaration to source.h.
13437 (print_source_lines): Likewise.
13438 (forget_cached_source_info_for_objfile): Likewise.
13439 (forget_cached_source_info): Likewise.
13440 (select_source_symtab): Likewise.
13441 (enum print_source_lines_flag): Move definition to source.h.
13442 * tui/tui-hooks.c: Add 'source.h' include.
13443
ec98a4ad
AB
134442019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13445
13446 * source.c (print_source_lines_base): Handle requests to print
13447 reverse line number sequences, and guard against empty lines
13448 string.
13449
62ea19c1
AB
134502019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13451
13452 * source.c (print_source_lines_base): Fix skip of '\r' if next
13453 character is '\n'.
13454
9d30e1fd
TT
134552019-01-06 Tom Tromey <tom@tromey.com>
13456
13457 * c-exp.y (struct c_parse_state) <macro_original_text,
13458 expansion_obstack>: New member.
13459 (macro_original_text, expansion_obstack): Remove globals.
13460 (scan_macro_expansion, scanning_macro_expansion)
13461 (finished_macro_expansion): Update.
13462 (scan_macro_cleanup): Remove.
13463 (yylex, c_parse): Update.
13464
c65bac38
TT
134652019-01-06 Tom Tromey <tom@tromey.com>
13466
13467 * c-exp.y (struct c_parse_state) <strings>: New member.
13468 (operator_stoken): Update.
13469
02e12e38
TT
134702019-01-06 Tom Tromey <tom@tromey.com>
13471
13472 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13473 (union type_stack_elt) <typelist_val>: Now a pointer to
13474 std::vector.
13475 (type_stack_cleanup): Don't declare.
13476 (push_typelist): Update.
13477 * parse.c (pop_typelist): Return a std::vector.
13478 (push_typelist): Take a std::vector.
13479 (follow_types): Update. Do not free args.
13480 (type_stack_cleanup): Remove.
13481 * c-exp.y (struct c_parse_state): New.
13482 (cpstate): New global.
13483 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13484 (nonempty_typelist): Update.
13485 (func_mod): Create a new vector.
13486 (c_parse): Create a c_parse_state.
13487 (check_parameter_typelist): Do not delete params.
13488 (function_method): Update. Do not delete type_list.
13489
f097f5ad
TT
134902019-01-06 Tom Tromey <tom@tromey.com>
13491
13492 PR gdb/28155:
13493 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13494 check_typedef.
13495 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13496 (print_return_value): Likewise.
13497
d2adf9f1
TT
134982019-01-05 Tom Tromey <tom@tromey.com>
13499
13500 * contrib/cleanup_check.py: Remove.
13501 * contrib/gcc-with-excheck: Remove.
13502 * contrib/exsummary.py: Remove.
13503 * contrib/excheck.py: Remove.
13504
2eab46b1
JB
135052019-01-05 Joel Brobecker <brobecker@adacore.com>
13506
13507 * thread.c (delete_thread_1): Add gdb_assert that THR is not
13508 NULL. Initialize tpprev to NULL instead of assigning it
13509 to NULL on the next statement.
13510 * windows-nat.c (windows_delete_thread): Remove check for
13511 main_thread_id before printing thread exit notifications.
13512 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13513 Remove thread ID check against main_thread_id.
13514 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13515 windows_delete_thread.
13516 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13517
48c5e7e2
TT
135182019-01-04 Tom Tromey <tom@tromey.com>
13519
13520 * compile/compile.c (_initialize_compile): Use upper case for
13521 metasyntactic variables.
13522 * symmisc.c (_initialize_symmisc): Use upper case for
13523 metasyntactic variables.
13524 * psymtab.c (_initialize_psymtab): Use upper case for
13525 metasyntactic variables.
13526 * demangle.c (demangle_command): Use upper case for metasyntactic
13527 variables.
13528 (_initialize_demangler): Likewise.
13529 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13530 variables.
13531
986041cd
TT
135322019-01-03 Tom Tromey <tom@tromey.com>
13533
13534 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13535
7c711119
TT
135362019-01-03 Tom Tromey <tom@tromey.com>
13537
13538 * python/py-symtab.c (salpy_str): Update.
13539 (struct salpy_sal_object) <symtab>: Now a PyObject.
13540 (salpy_dealloc): Update.
13541 (del_objfile_sal): Use gdbpy_ref.
13542
1b20edf0
TT
135432019-01-03 Tom Tromey <tom@tromey.com>
13544
13545 * python/py-type.c (convert_field): Use new_reference. Return
13546 gdbpy_ref.
13547 (make_fielditem): Return gdbpy_ref.
13548 (typy_fields): Update.
13549 (typy_getitem): Update.
13550 (field_name): Return gdbpy_ref. Use new_reference.
13551 (typy_iterator_iternext): Update.
13552
ea41325b
TT
135532019-01-03 Tom Tromey <tom@tromey.com>
13554
13555 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13556
2a3c71d6
TT
135572019-01-03 Tom Tromey <tom@tromey.com>
13558
13559 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13560 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13561 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13562 (pspy_set_frame_filters, pspy_set_frame_unwinders)
13563 (pspy_set_type_printers): Likewise.
13564 * python/py-function.c (fnpy_init): Use gdbpy_ref.
13565 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13566 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13567 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13568 (objfpy_set_type_printers): Likewise.
13569
5c329e6a
TT
135702019-01-03 Tom Tromey <tom@tromey.com>
13571
13572 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13573 (gdbpy_print_stack): Use gdbpy_err_fetch.
13574 * python/python-internal.h (class gdbpy_err_fetch): New class.
13575 (class gdbpy_enter) <m_error_type, m_error_value,
13576 m_error_traceback>: Remove.
13577 <m_error>: New member.
13578 (gdbpy_exception_to_string): Don't declare.
13579 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13580 * python/py-value.c (convert_value_from_python): Use
13581 gdbpy_err_fetch.
13582 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13583 gdbpy_exception_to_string.
13584 (gdbpy_handle_exception): Use gdbpy_err_fetch.
13585 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13586 gdbpy_err_fetch.
13587
169bb27b
AB
135882019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13589
13590 * linux-nat.c (delete_lwp_cleanup): Delete.
13591 (struct lwp_deleter): New struct.
13592 (lwp_info_up): New typedef.
13593 (linux_nat_target::follow_fork): Delete cleanup, and make use of
13594 lwp_info_up.
13595
a07c8880
AB
135962019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13597
13598 * linux-fork.c (class scoped_switch_fork_info): New class.
13599 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13600
26089c49
AB
136012019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13602
13603 * valops.c (find_overload_match): Remove use of null_cleanup, and
13604 calls to do_cleanups.
13605
06d3e5b0
AB
136062019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13607
13608 * compile/compile-cplus-types.c
13609 (compile_cplus_instance::decl_name): Handle changes to
13610 cp_func_name.
13611 * cp-support.c (cp_func_name): Update header comment, update
13612 return type.
13613 * cp-support.h (cp_func_name): Update return type in declaration.
13614 * valops.c (find_overload_match): Move temp_func local to top
13615 level of function and change its type. Use temp_func to hold and
13616 delete temporary string obtained from cp_func_name.
13617
66644cd3
AB
136182019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13619
13620 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13621 gdb::char_vector, remove cleanup, and update uses of `msg`.
13622
592d8c0a
JW
136232019-01-03 Jim Wilson <jimw@sifive.com>
13624
13625 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13626
c55d06ec
TT
136272019-01-02 Tom Tromey <tom@tromey.com>
13628
13629 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13630 (tdesc_parse_xml): Remove cleanups.
13631 * target-descriptions.h (make_cleanup_free_target_description):
13632 Don't declare.
13633 (target_desc_deleter): New struct.
13634 (target_desc_up): New typedef.
13635 * target-descriptions.c (target_desc_deleter::operator()): Rename
13636 from free_target_description.
13637 (make_cleanup_free_target_description): Remove.
13638
3a6ae42d
TT
136392019-01-02 Tom Tromey <tom@tromey.com>
13640
13641 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
13642 constructor, destructor.
13643 (linespec_parser): Remove typedef.
13644 (~linespec_parser): Rename from linespec_parser_delete.
13645 (linespec_lex_to_end, linespec_complete_label)
13646 (linespec_complete): Update.
13647 (decode_line_full): Remove cleanups.
13648 (decode_line_1): Update.
13649
61fd3e73
TT
136502019-01-02 Tom Tromey <tom@tromey.com>
13651
13652 * python/python-internal.h (inferior_to_inferior_object): Change
13653 return type.
13654 * python/py-exitedevent.c (create_exited_event_object): Update.
13655 * python/py-inferior.c (inferior_to_inferior_object): Return
13656 gdbpy_ref.
13657 (python_new_inferior, python_inferior_deleted)
13658 (thread_to_thread_object, delete_thread_object)
13659 (build_inferior_list, gdbpy_selected_inferior): Update.
13660 * python/py-infthread.c (create_thread_object): Update. Also fail
13661 if inferior_to_inferior_object fails.
13662
d20172fc
SM
136632019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13664
13665 * inferior.h (class inferior) <displaced_step_state>: New field.
13666 * infrun.h (struct displaced_step_state): Move here from
13667 infrun.c. Initialize fields, add constructor.
13668 <inf>: Remove field.
13669 <reset>: New method.
13670 * infrun.c (struct displaced_step_inferior_state): Move to
13671 infrun.h.
13672 (displaced_step_inferior_states): Remove.
13673 (get_displaced_stepping_state): Adust.
13674 (displaced_step_in_progress_any_inferior): Adjust.
13675 (displaced_step_in_progress_thread): Adjust.
13676 (displaced_step_in_progress): Adjust.
13677 (add_displaced_stepping_state): Remove.
13678 (get_displaced_step_closure_by_addr): Adjust.
13679 (remove_displaced_stepping_state): Remove.
13680 (infrun_inferior_exit): Call displaced_step_state.reset.
13681 (use_displaced_stepping): Don't check for NULL.
13682 (displaced_step_prepare_throw): Call
13683 get_displaced_stepping_state.
13684 (displaced_step_fixup): Don't check for NULL.
13685 (prepare_for_detach): Don't check for NULL.
13686
e3319240
PW
136872019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13688
13689 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13690 in case of call that did not complete.
13691
5d36dfb9
AU
136922019-01-02 Andrey Utkin <autkin@undo.io>
13693
13694 * symfile.c (find_separate_debug_file): Fix search of debug files for
13695 remote debuggee.
13696
8833fbf0
TT
136972019-01-02 Tom Tromey <tom@tromey.com>
13698
13699 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13700 indentation.
13701 * python/py-frame.c (frapy_older): Remove cast.
13702 (frapy_newer): Likewise.
13703 * python/py-breakpoint.c (local_setattro): Remove cast.
13704 * python/py-arch.c (archpy_name): Remove local variable.
13705 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13706
4ada3dfd
JB
137072019-01-02 Joel Brobecker <brobecker@adacore.com>
13708
13709 * unittests/basic_string_view/element_access/char/empty.cc:
13710 Fix year range in copyright header.
13711
113b7b81
AB
137122019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13713
13714 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13715 Delete.
13716 <operator==>: Update with for removed field.
13717 <hash>: Likewise.
13718 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13719 <isa_features>: ...this.
13720 <abi_features>: New field.
13721 (riscv_isa_flen): Update comment.
13722 (riscv_abi_xlen): New declaration.
13723 (riscv_abi_flen): New declaration.
13724 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13725 isa_features.
13726 (riscv_abi_xlen): New function.
13727 (riscv_isa_flen): Update to get answer from isa_features.
13728 (riscv_abi_flen): New function.
13729 (riscv_has_fp_abi): Update to get answer from abi_features.
13730 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13731 xlen and flen.
13732 (riscv_call_info) <xlen, flen>: Update comment.
13733 (riscv_call_arg_struct): Remove invalid assertions
13734 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13735 is removed.
13736 (riscv_gdbarch_init): Gather isa features and abi features
13737 separately, ensure both match on the gdbarch when reusing an old
13738 gdbarch. Relax an error check to allow 32-bit abi float to run on
13739 a target with 64-bit float hardware.
13740
b18ca514
PW
137412019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13742
13743 * source.c (search_command_helper): Stop reverse search
13744 when line 1 has been searched.
13745
ec70d8db
PW
137462019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13747
13748 * record-full.c (record_full_base_target::close): Rewrite
13749 record_full_core_buf_list free logic.
13750
5b38f9c1
PW
137512019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13752
13753 * break-catch-syscall.c (print_one_catch_syscall): xfree
13754 the last text.
13755
66d91b39
JB
137562019-01-01 Joel Brobecker <brobecker@adacore.com>
13757
13758 * top.c (print_gdb_version): Update Copyright year in version
13759 message.
13760
42a4f53d
JB
137612019-01-01 Joel Brobecker <brobecker@adacore.com>
13762
13763 Update copyright year range in all GDB files.
13764
7e955d83 137652019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 13766
5bbd631d 13767 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 13768
5bbd631d 13769For older changes see ChangeLog-2018.
c906108c
SS
13770\f
13771Local Variables:
13772mode: change-log
13773left-margin: 8
13774fill-column: 74
13775version-control: never
57da7796 13776coding: utf-8
c906108c 13777End:
5bbd631d 13778