]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - libctf/ChangeLog
libctf, dump: migrate towards dumping errors rather than truncation
[thirdparty/binutils-gdb.git] / libctf / ChangeLog
CommitLineData
8e795b46
NA
12020-07-22 Nick Alcock <nick.alcock@oracle.com>
2
3 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
4 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
5 (ctf_dump_objts): Likewise.
6 (ctf_dump_var): Likewise.
7 (ctf_dump_type): Do not emit a duplicate message. Move to
8 ctf_err_warning, and swallow all errors.
9
b255b35f
NA
102020-07-22 Nick Alcock <nick.alcock@oracle.com>
11
12 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
13 (ctf_decl_buf): Once it escapes, don't try to free it later.
14
c6e9a1e5
NA
152020-07-22 Nick Alcock <nick.alcock@oracle.com>
16
17 * ctf-types.c (ctf_type_aname): Print arg types here...
18 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
19 in the type name here.
20
8b37e7b6
NA
212020-07-22 Nick Alcock <nick.alcock@oracle.com>
22
23 * ctf-impl.h (ctf_assert): New.
24 (ctf_err_warning_t): Likewise.
25 (ctf_file_t) <ctf_errs_warnings>: Likewise.
26 (ctf_err_warn): New prototype.
27 (ctf_assert_fail_internal): Likewise.
28 * ctf-inlines.h (ctf_assert_internal): Likewise.
29 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
30 * ctf-create.c (ctf_serialize): Copy it on serialization.
31 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
32 (ctf_errwarning_next): New iterator, free and pass back
33 errors/warnings in succession.
34 * libctf.ver (ctf_errwarning_next): Add.
35
b7190c82
EB
362020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
37
38 * ctf-types.c (ctf_variable_iter): Fix error return.
39
ec388c16
NA
402020-07-22 Nick Alcock <nick.alcock@oracle.com>
41
42 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
43
67d4cc67
NA
442020-07-22 Nick Alcock <nick.alcock@oracle.com>
45
46 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
47
e28591b3
NA
482020-07-22 Nick Alcock <nick.alcock@oracle.com>
49
50 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
51 sorting functions.
52 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
53 ctf_dynhash_next_sorted.
54 <cu.ctn_h>: New, pointer to the dynhash under iteration.
55 <cu.ctn_s>: New, pointer to the dynset under iteration.
56 (ctf_hash_sort_f): Sorting function passed to...
57 (ctf_dynhash_next_sorted): ... this new function.
58 (ctf_dynhash_next): New.
59 (ctf_dynset_next): New.
60 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
61 (ctf_dynhash_cnext): New.
62 (ctf_dynset_cnext): New.
63 * ctf-hash.c (ctf_dynhash_next_sorted): New.
64 (ctf_dynhash_next): New.
65 (ctf_dynset_next): New.
66 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
67 needed.
68 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
69
688d28f6
NA
702020-07-22 Nick Alcock <nick.alcock@oracle.com>
71
72 * ctf-impl.h (ctf_next): New.
73 (ctf_get_dict): New prototype.
74 * ctf-lookup.c (ctf_get_dict): New, split out of...
75 (ctf_lookup_by_id): ... here.
76 * ctf-util.c (ctf_next_create): New.
77 (ctf_next_destroy): New.
78 (ctf_next_copy): New.
79 * ctf-types.c (includes): Add <assert.h>.
80 (ctf_member_next): New.
81 (ctf_enum_next): New.
82 (ctf_type_iter): Document the lack of iteration over parent
83 types.
84 (ctf_type_next): New.
85 (ctf_variable_next): New.
86 * ctf-archive.c (ctf_archive_next): New.
87 * libctf.ver: Add new public functions.
88
2399827b
NA
892020-07-22 Nick Alcock <nick.alcock@oracle.com>
90
91 * libctf.ver (ctf_ref): New.
92 * ctf-open.c (ctf_ref): Implement it.
93
9850ce4d
NA
942020-07-22 Nick Alcock <nick.alcock@oracle.com>
95
96 * ctf-inlines.h (ctf_forwardable_kind): New.
97 * ctf-create.c (ctf_add_forward): Use it.
98
2c9ca36b
NA
992020-07-22 Nick Alcock <nick.alcock@oracle.com>
100
101 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
102 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
103
77648241
NA
1042020-07-22 Nick Alcock <nick.alcock@oracle.com>
105
106 * ctf-hash.c (ctf_dynset_eq_string): New.
107 (ctf_dynset_create): New.
108 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
109 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
110 (key_to_internal): New.
111 (internal_to_key): New.
112 (ctf_dynset_insert): New.
113 (ctf_dynset_remove): New.
114 (ctf_dynset_destroy): New.
115 (ctf_dynset_lookup): New.
116 (ctf_dynset_exists): New.
117 (ctf_dynset_lookup_any): New.
118 (ctf_hash_insert_type): Coding style.
119 (ctf_hash_define_type): Likewise.
120 * ctf-impl.h (ctf_dynset_t): New.
121 (ctf_dynset_eq_string): New.
122 (ctf_dynset_create): New.
123 (ctf_dynset_insert): New.
124 (ctf_dynset_remove): New.
125 (ctf_dynset_destroy): New.
126 (ctf_dynset_lookup): New.
127 (ctf_dynset_exists): New.
128 (ctf_dynset_lookup_any): New.
129 * ctf-inlines.h (ctf_dynset_cinsert): New.
130
a49c6c6a
NA
1312020-07-22 Nick Alcock <nick.alcock@oracle.com>
132
133 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
134 <value_free>: Likewise.
135 <owner>: New.
136 (ctf_dynhash_item_free): Indirect through the owner.
137 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
138 allocate space for the key_free and value_free fields fields
139 if necessary.
140 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
141 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
142 value_free if they will exist. Set the slot's owner, but only
143 if it exists.
144 (ctf_dynhash_remove): Adjust.
145
5ceee3db
NA
1462020-07-22 Nick Alcock <nick.alcock@oracle.com>
147
148 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
149 there is a key-freeing function and the key already exists.
150
809f6eb3
NA
1512020-07-22 Nick Alcock <nick.alcock@oracle.com>
152
153 * ctf-inlines.h: New file.
154 * ctf-impl.h: Include it.
155 (ctf_hash_iter_find_f): New typedef.
156 (ctf_dynhash_elements): New.
157 (ctf_dynhash_lookup_kv): New.
158 (ctf_dynhash_iter_find): New.
159 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
160 (ctf_traverse_find_cb_arg_t): New.
161 (ctf_hashtab_traverse_find): New.
162 (ctf_dynhash_iter_find): New.
163 (ctf_dynhash_elements): New.
164
469e75b6
NA
1652020-07-22 Nick Alcock <nick.alcock@oracle.com>
166
167 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
168
9c23dfa5
NA
1692020-07-22 Nick Alcock <nick.alcock@oracle.com>
170
171 * ctf-archive.c (ctf_archive_count): New.
172 * libctf.ver: New public function.
173
e0325e2c
NA
1742020-07-22 Nick Alcock <nick.alcock@oracle.com>
175
176 * ctf-types.c (ctf_member_count): New.
177 * libctf.ver: New public function.
178
9b15cbb7
NA
1792020-07-22 Nick Alcock <nick.alcock@oracle.com>
180
181 * ctf-types.c (ctf_type_kind_forwarded): New.
182
01d93174
NA
1832020-07-22 Nick Alcock <nick.alcock@oracle.com>
184
185 * ctf-types.c (ctf_type_name_raw): New.
186 (ctf_type_aname_raw): Reimplement accordingly.
187
5ec7465f
NA
1882020-07-22 Nick Alcock <nick.alcock@oracle.com>
189
190 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
191
601e455b
NA
1922020-07-22 Nick Alcock <nick.alcock@oracle.com>
193
194 * ctf-impl.h (struct ctf_archive_internal)
195 <ctfi_unmap_on_close>: New.
196 (ctf_new_archive_internal): Adjust.
197 * ctf-archive.c (ctf_new_archive_internal): Likewise.
198 Initialize ctfi_unmap_on_close. Adjust error path.
199 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
200 (unmap_on_close is 0).
201 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
202 * ctf-open-bfd.c (ctf_fdopen): Adjust.
203
96e3ec29
NA
2042020-07-22 Nick Alcock <nick.alcock@oracle.com>
205
206 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
207 ints, floats or typedefs have no name. Fix comment typo.
208
502e838e
NA
2092020-07-22 Nick Alcock <nick.alcock@oracle.com>
210
211 * ctf-create.c (ctf_add_slice): Support slices of any kind that
212 resolves to an integral type.
213 * ctf-types.c (ctf_type_encoding): Resolve the type before
214 fishing its encoding out.
215
dd987f00
NA
2162020-07-22 Nick Alcock <nick.alcock@oracle.com>
217
218 * ctf-create.c (ctf_create): Mark dirty.
219
f47ca311
NA
2202020-07-22 Nick Alcock <nick.alcock@oracle.com>
221
222 * ctf-create.c (membcmp) Skip nameless members.
223
ab769488
NA
2242020-07-22 Nick Alcock <nick.alcock@oracle.com>
225
226 * ctf-create.c (ctf_add_member_offset): Support names of ""
227 as if they were the null pointer.
228
2484ca43
NA
2292020-07-22 Nick Alcock <nick.alcock@oracle.com>
230
231 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
232 special-casing.
233
43706199
NA
2342020-07-22 Nick Alcock <nick.alcock@oracle.com>
235
236 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
237
9943fa3a
NA
2382020-07-22 Nick Alcock <nick.alcock@oracle.com>
239
240 * ctf-create.c (ctf_serialize): Add cast.
241 (ctf_add_slice): Likewise.
242
afd78bd6
NA
2432020-07-22 Nick Alcock <nick.alcock@oracle.com>
244
245 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
246 * ctf-create.c (ctf_add_function): Check for unimplemented type
247 and populate at the same time. Populate one-by-one, not via
248 memcpy.
249 (ctf_serialize): Remove unnecessary cast.
250 * ctf-types.c (ctf_func_type_info): Likewise.
251 (ctf_func_type_args): Likewise. Fix comment typo.
252
2361f1c8
NA
2532020-07-22 Nick Alcock <nick.alcock@oracle.com>
254
255 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
256 (ctf_add_array): Support array contents of type zero.
257 (ctf_add_function): Support arguments and return types of
258 type zero.
259 (ctf_add_typedef): Support typedefs to type zero.
260 (ctf_add_member_offset): Support members of type zero,
261 unless added at unspecified (naturally-aligned) offset.
262
7eea9d3b
NA
2632020-07-22 Nick Alcock <nick.alcock@oracle.com>
264
265 * ctf-error.c: Include <stddef.h>, for offsetof.
266 (_ctf_errlist): Migrate to...
267 (_ctf_errlist_t): ... this.
268 (_ctf_erridx): New, indexes into _ctf_errlist_t.
269 (_ctf_nerr): Remove.
270 (ctf_errmsg): Adjust accordingly.
271 * Makefile.am (BUILT_SOURCES): Note...
272 (ctf-error.h): ... this new rule.
273 * Makefile.in: Regenerate.
274 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
275 * .gitignore: New, ignore ctf-error.h.
276
b64751cf
NA
2772020-07-22 Nick Alcock <nick.alcock@oracle.com>
278
279 * ctf-impl.h: Fix typos in comments.
280
df16e041
NC
2812020-07-22 Nick Clifton <nickc@redhat.com>
282
283 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
284 same file descriptor.
285
b115b9fd
NC
2862020-07-04 Nick Clifton <nickc@redhat.com>
287
288 Binutils 2.35 branch created.
289
8e6635bd
NA
2902020-06-26 Nick Alcock <nick.alcock@oracle.com>
291
292 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
293 alphabetical order.
294 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
295 * config.h.in: Regenerated.
296 * Makefile.in: Likewise.
297 * configure: Likewise.
298
c1401ecc
NA
2992020-06-26 Nick Alcock <nick.alcock@oracle.com>
300
301 * ctf-create.c: Include <unistd.h>.
302 * ctf-open-bfd.c: Likewise.
303
e755667f
NA
3042020-06-26 Nick Alcock <nick.alcock@oracle.com>
305
306 PR libctf/25120
307 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
308 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
309 means this is declared.
310 (bswap_32): Likewise.
311 (bswap_64): Likewise.
312 (bswap_identity_64): Remove, unused.
313 * configure: Regenerated.
314 * config.h.in: Likewise.
315
86670658
NA
3162020-06-26 Nick Alcock <nick.alcock@oracle.com>
317
318 PR libctf/25120
319 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
320 (_libctf_unlikely_): Likewise.
321 (_libctf_unused): Likewise.
322 (_libctf_malloc_): Likewise.
323
2e428e74
NA
3242020-06-26 Nick Alcock <nick.alcock@oracle.com>
325
326 PR libctf/25120
327 * ctf-archive.c (search_nametbl): No longer global: declare...
328 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
329 (search_modent_by_name): Take and use ARG for the nametbl.
330
2f6ecaed
NA
3312020-06-26 Nick Alcock <nick.alcock@oracle.com>
332
333 * ctf-impl.h (ctf_new_archive_internal): Declare.
334 (ctf_arc_bufopen): Remove.
335 (ctf_archive_internal) <ctfi_free_symsect>: New.
336 * ctf-archive.c (ctf_arc_close): Use it.
337 (ctf_arc_bufopen): Fuse into...
338 (ctf_new_archive_internal): ... this, moved across from...
339 * ctf-open-bfd.c: ... here.
340 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
341 * libctf.ver: Add it.
342
8ffcdf18
NA
3432020-06-26 Nick Alcock <nick.alcock@oracle.com>
344
345 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
346 (ctf_dtd_delete): Remove correspondingly.
347 (ctf_rollback): Likewise.
348
d04a47ac
NA
3492020-06-26 Nick Alcock <nick.alcock@oracle.com>
350
351 * ctf-create.c (ctf_add_type_internal): Hand back existing types
352 unchanged.
353
6bbf9da8
NA
3542020-06-26 Nick Alcock <nick.alcock@oracle.com>
355
356 * ctf-create.c (ctf_add_forward): Don't add forwards to
357 types that already exist.
358
fe4c2d55
NA
3592020-06-26 Nick Alcock <nick.alcock@oracle.com>
360
361 * ctf-open.c (init_types): Only intern root-visible types.
362 * ctf-create.c (ctf_dtd_insert): Likewise.
363 (ctf_dtd_delete): Only remove root-visible types.
364 (ctf_rollback): Likewise.
365 (ctf_add_generic): Adjust.
366 (ctf_add_struct_sized): Adjust comment.
367 (ctf_add_union_sized): Likewise.
368 (ctf_add_enum): Likewise.
369 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
370
11978942
JB
3712020-03-11 John Baldwin <jhb@FreeBSD.org>
372
373 * swap.h (bswap_identity_64): Make static.
374
ae774686
NC
3752020-01-18 Nick Clifton <nickc@redhat.com>
376
377 Binutils 2.34 branch created.
378
eb9a7e35 3792020-01-05 Joel Brobecker <brobecker@adacore.com>
3a657c60
EZ
380
381 PR binutils/25155:
382 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
383 * configure, config.h.in: Regenerate.
384
b14ce8bf
AM
3852020-01-01 Alan Modra <amodra@gmail.com>
386
387 Update year range in copyright notice of all files.
388
cbbbc402
SM
3892019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
390
391 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
392
fa56cdcd
NA
3932019-09-30 Nick Alcock <nick.alcock@oracle.com>
394
395 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
396 * ctf-types.c (ctf_type_lname): Likewise.
397
ad613f1d
NA
3982019-09-23 Nick Alcock <nick.alcock@oracle.com>
399
400 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
401 ctf_import after the first for a given file.
402
9323dd86
NA
4032019-09-23 Nick Alcock <nick.alcock@oracle.com>
404
405 * ctf-impl.h (ctf_str_append_noerr): Declare.
406 * ctf-util.c (ctf_str_append_noerr): Define in terms of
407 ctf_str_append.
408 * ctf-dump.c (str_append): New, call it.
409 (ctf_dump_format_type): Use str_append, not ctf_str_append.
410 (ctf_dump_label): Likewise.
411 (ctf_dump_objts): Likewise.
412 (ctf_dump_funcs): Likewise.
413 (ctf_dump_var): Likewise.
414 (ctf_dump_member): Likewise.
415 (ctf_dump_type): Likewise.
416 (ctf_dump): Likewise.
417
de07e349
NA
4182019-09-23 Nick Alcock <nick.alcock@oracle.com>
419
420 * ctf-impl.h (ctf_alloc): Remove.
421 (ctf_free): Likewise.
422 (ctf_strdup): Likewise.
423 * ctf-subr.c (ctf_alloc): Remove.
424 (ctf_free): Likewise.
425 * ctf-util.c (ctf_strdup): Remove.
426
427 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
428 ctf_free; strdup, not ctf_strdup.
429 (ctf_dtd_delete): Likewise.
430 (ctf_dvd_delete): Likewise.
431 (ctf_add_generic): Likewise.
432 (ctf_add_function): Likewise.
433 (ctf_add_enumerator): Likewise.
434 (ctf_add_member_offset): Likewise.
435 (ctf_add_variable): Likewise.
436 (membadd): Likewise.
437 (ctf_compress_write): Likewise.
438 (ctf_write_mem): Likewise.
439 * ctf-decl.c (ctf_decl_push): Likewise.
440 (ctf_decl_fini): Likewise.
441 (ctf_decl_sprintf): Likewise. Check for OOM.
442 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
443 ctf_free; strdup, not ctf_strdup.
444 (ctf_dump_free): Likewise.
445 (ctf_dump): Likewise.
446 * ctf-open.c (upgrade_types_v1): Likewise.
447 (init_types): Likewise.
448 (ctf_file_close): Likewise.
449 (ctf_bufopen_internal): Likewise. Check for OOM.
450 (ctf_parent_name_set): Likewise: report the OOM to the caller.
451 (ctf_cuname_set): Likewise.
452 (ctf_import): Likewise.
453 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
454 free, not ctf_free; strdup, not ctf_strdup.
455 (ctf_str_free_atom): Likewise.
456 (ctf_str_create_atoms): Likewise.
457 (ctf_str_add_ref_internal): Likewise.
458 (ctf_str_remove_ref): Likewise.
459 (ctf_str_write_strtab): Likewise.
460
9c1a2295
NA
4612019-08-09 Nick Alcock <nick.alcock@oracle.com>
462
463 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
464 work right for non-int/fps.
465
1a6ab13e
NA
4662019-08-08 Nick Alcock <nick.alcock@oracle.com>
467
468 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
469 null pointer.
470
99dc3ebd
NA
4712019-08-07 Nick Alcock <nick.alcock@oracle.com>
472
473 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
474 * ctf-open.c (ctf_file_close): Free it.
475 * ctf-create.c (ctf_serialize): Adjust.
476 (membcmp): When reporting a conflict due to an error, report the
477 error.
478 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
479 (ctf_add_type_internal): ... this. Hand back types we are already
480 in the middle of adding immediately. Hand back structs/unions with
481 the same number of members immediately. Do not walk the dynamic
482 list. Call ctf_add_type_internal, not ctf_add_type. Handle
483 forwards promoted to other types and the inverse case identically.
484 Add structs to the mapping as soon as we intern them, before they
485 gain any members.
486
676c3ecb
NA
4872019-08-09 Nick Alcock <nick.alcock@oracle.com>
488
489 * ctf-impl.h (ctf_names_t): New.
490 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
491 (ctf_file_t) <ctf_structs>: Likewise.
492 <ctf_unions>: Likewise.
493 <ctf_enums>: Likewise.
494 <ctf_names>: Likewise.
495 <ctf_lookups>: Improve comment.
496 <ctf_ptrtab_len>: New.
497 <ctf_prov_strtab>: New.
498 <ctf_str_prov_offset>: New.
499 <ctf_dtbyname>: Remove, redundant to the names hashes.
500 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
501 (ctf_dtdef_t) <dtd_name>: Remove.
502 <dtd_data>: Note that the ctt_name is now populated.
503 (ctf_str_atom_t) <csa_offset>: This is now the strtab
504 offset for internal strings too.
505 <csa_external_offset>: New, the external strtab offset.
506 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
507 (ctf_name_table): New declaration.
508 (ctf_lookup_by_rawname): Likewise.
509 (ctf_lookup_by_rawhash): Likewise.
510 (ctf_set_ctl_hashes): Likewise.
511 (ctf_serialize): Likewise.
512 (ctf_dtd_insert): Adjust.
513 (ctf_simple_open_internal): Likewise.
514 (ctf_bufopen_internal): Likewise.
515 (ctf_list_empty_p): Likewise.
516 (ctf_str_remove_ref): Likewise.
517 (ctf_str_add): Returns uint32_t now.
518 (ctf_str_add_ref): Likewise.
519 (ctf_str_add_external): Now returns a boolean (int).
520 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
521 for strings in the appropriate range.
522 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
523 when adding the null string to the new strtab.
524 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
525 (ctf_str_add_ref_internal): Add make_provisional argument. If
526 make_provisional, populate the offset and fill in the
527 ctf_prov_strtab accordingly.
528 (ctf_str_add): Return the offset, not the string.
529 (ctf_str_add_ref): Likewise.
530 (ctf_str_add_external): Return a success integer.
531 (ctf_str_remove_ref): New, remove a single ref.
532 (ctf_str_count_strtab): Do not count the initial null string's
533 length or the existence or length of any unreferenced internal
534 atoms.
535 (ctf_str_populate_sorttab): Skip atoms with no refs.
536 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
537 to the cts_len for the null string, since it is no longer done
538 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
539 Populate the csa_offset for both internal and external cases.
540 Flush the ctf_prov_strtab afterwards, and reset the
541 ctf_str_prov_offset.
542 * ctf-create.c (ctf_grow_ptrtab): New.
543 (ctf_create): Call it. Initialize new fields rather than old
544 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
545 Set the ctl hashes and data model.
546 (ctf_update): Rename to...
547 (ctf_serialize): ... this. Leave a compatibility function behind.
548 Tell ctf_simple_open_internal that this is a writable dictionary.
549 Pass the new fields along from the old dictionary. Drop
550 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
551 Do not zero out the DTD's ctt_name.
552 (ctf_prefixed_name): Rename to...
553 (ctf_name_table): ... this. No longer return a prefixed name: return
554 the applicable name table instead.
555 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
556 kind we're adding. Migrate away from dtd_name.
557 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
558 deleted ctt_name.
559 (ctf_dtd_lookup_type_by_name): Remove.
560 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
561 No longer check ctf_dtnextid: check ctf_typemax instead.
562 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
563 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
564 ctf_name_table and the right name table, and migrate away from
565 dtd_name as in ctf_dtd_delete.
566 (ctf_add_generic): Pass in the kind explicitly and pass it to
567 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
568 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
569 Grow the ptrtab if needed.
570 (ctf_add_encoded): Pass in the kind.
571 (ctf_add_slice): Likewise.
572 (ctf_add_array): Likewise.
573 (ctf_add_function): Likewise.
574 (ctf_add_typedef): Likewise.
575 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
576 ctt_name rather than dtd_name.
577 (ctf_add_struct_sized): Pass in the kind. Use
578 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
579 ctf_dtd_lookup_type_by_name.
580 (ctf_add_union_sized): Likewise.
581 (ctf_add_enum): Likewise.
582 (ctf_add_enum_encoded): Likewise.
583 (ctf_add_forward): Likewise.
584 (ctf_add_type): Likewise.
585 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
586 being initialized until after the call.
587 (ctf_write_mem): Likewise.
588 (ctf_write): Likewise.
589 * ctf-archive.c (arc_write_one_ctf): Likewise.
590 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
591 ctf_hash_lookup_type.
592 (ctf_lookup_by_id): No longer check the readonly types if the
593 dictionary is writable.
594 * ctf-open.c (init_types): Assert that this dictionary is not
595 writable. Adjust to use the new name hashes, ctf_name_table,
596 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
597 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
598 if set. Drop out early when dictionary is writable. Split the
599 ctf_lookups initialization into...
600 (ctf_set_cth_hashes): ... this new function.
601 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
602 (ctf_simple_open): Adjust accordingly.
603 (ctf_bufopen): Likewise.
604 (ctf_file_close): Destroy the appropriate name hashes. No longer
605 destroy ctf_dtbyname, which is gone.
606 (ctf_getdatasect): Remove spurious "extern".
607 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
608 specified name table, given a kind.
609 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
610 (ctf_member_iter): Add support for iterating over the
611 dynamic type list.
612 (ctf_enum_iter): Likewise.
613 (ctf_variable_iter): Likewise.
614 (ctf_type_rvisit): Likewise.
615 (ctf_member_info): Add support for types in the dynamic type list.
616 (ctf_enum_name): Likewise.
617 (ctf_enum_value): Likewise.
618 (ctf_func_type_info): Likewise.
619 (ctf_func_type_args): Likewise.
620 * ctf-link.c (ctf_accumulate_archive_names): No longer call
621 ctf_update.
622 (ctf_link_write): Likewise.
623 (ctf_link_intern_extern_string): Adjust for new
624 ctf_str_add_external return value.
625 (ctf_link_add_strtab): Likewise.
626 * ctf-util.c (ctf_list_empty_p): New.
627
791915db
NA
6282019-08-05 Nick Alcock <nick.alcock@oracle.com>
629
630 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
631 type zero.
632 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
633 members and types.
634 (ctf_add_variable): Likewise for variables pointing to them.
635 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
636 type link failure, but do warn for others.
637 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
638 errors to be ENOMEM.
639 (ctf_dump_member): Likewise.
640 (ctf_dump_type): Likewise.
641 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
642 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
643 (ctf_dump_header): Likewise.
644 (ctf_dump_label): likewise.
645 (ctf_dump_objts): likewise.
646 (ctf_dump_funcs): likewise.
647 (ctf_dump_var): likewise.
648 (ctf_dump_str): Likewise.
649
87279e3c
NA
6502019-09-30 Nick Alcock <nick.alcock@oracle.com>
651
652 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
653 (LT_INIT): Likewise.
654 (AM_INSTALL_LIBBFD): Likewise.
655 (dlopen): Note why this is necessary in a comment.
656 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
657 opcodes/.
658 (SHARED_LDFLAGS): Likewise.
659 (BFD_LIBADD): Likewise, for libbfd.
660 (BFD_DEPENDENCIES): Likewise.
661 (VERSION_FLAGS): Initialize, using a version script if ld supports
662 one, or libtool -export-symbols-regex otherwise.
663 (AC_CONFIG_MACRO_DIR): Add ../BFD.
664 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
665 (INCDIR): New.
666 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
667 (noinst_LIBRARIES): Replace with...
668 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
669 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
670 libctf-nobfd.la as well.
671 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
672 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
673 (libctf_a_SOURCES): Rename to...
674 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
675 ctf-open-bfd.c.
676 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
677 with ctf-open-bfd.c added.
678 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
679 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
680 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
681 * Makefile.am [INSTALL_LIBCTF]: Use it.
682 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
683 libtool macros.
684 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
685 the unstable components).
686 * Makefile.in: Regenerated.
687 * config.h.in: Likewise.
688 * configure: Likewise.
689
6902019-07-30 Nick Alcock <nick.alcock@oracle.com>
691
692 * configure.ac (INSTALL_LIBCTF): New, controlled by
693 --enable-install-libctf.
694 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
695 * Makefile.in: Regenerated.
696 * configure: Regenerated.
697
f046147d
NA
6982019-07-30 Nick Alcock <nick.alcock@oracle.com>
699
700 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
701 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
702
edc8bbe9
NA
7032019-07-30 Nick Alcock <nick.alcock@oracle.com>
704
705 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
706
7e97445a
NA
7072019-07-13 Nick Alcock <nick.alcock@oracle.com>
708
709 * ctf-impl.h (includes): Include <sys/param.h> here.
710
5ae6af75
NA
7112019-07-30 Nick Alcock <nick.alcock@oracle.com>
712
713 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
714 (flip_objts): Likewise.
715 (flip_vars): Likewise.
716 (flip_types): Likewise.
717
1820745a
NA
7182019-07-30 Nick Alcock <nick.alcock@oracle.com>
719
720 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
721 freeing functions: if set, free the key and value if the slot
722 already exists. Always reassign the key.
723 (ctf_dynhash_insert): Adjust call appropriately.
724 (ctf_hash_insert_type): Likewise.
725
5de9eada
NA
7262019-08-03 Nick Alcock <nick.alcock@oracle.com>
727
728 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
729 type kind. Allow forwards to unify with pre-existing structs/
730 unions/enums.
731
49ea9b45
NA
7322019-07-30 Nick Alcock <nick.alcock@oracle.com>
733
734 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
735 <ctf_link_memb_name_changer>: Likewise.
736 <ctf_link_memb_name_changer_arg>: Likewise.
737 * ctf-create.c (ctf_update): Update accordingly.
738 * ctf-open.c (ctf_file_close): Likewise.
739 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
740 (ctf_link_add_cu_mapping): New.
741 (ctf_link_set_memb_name_changer): Likewise.
742 (ctf_change_parent_name): New.
743 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
744 allocated by the caller's ctf_link_memb_name_changer.
745 <ndynames>: Likewise.
746 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
747 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
748 ctf_change_parent_name. Free any resulting names.
749
eabb7154
NA
7502019-07-13 Nick Alcock <nick.alcock@oracle.com>
751
752 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
753 (ctf_link_one_type): ... here, with parent-name setting added.
754 (check_variable): New.
755 (ctf_link_one_variable): Likewise.
756 (ctf_link_one_input_archive_member): Call it.
757 * ctf-error.c (_ctf_errlist): Updated with new errors.
758
886453cb
NA
7592019-07-13 Nick Alcock <nick.alcock@oracle.com>
760
761 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
762 (struct ctf_link_type_mapping_key): New.
763 (ctf_hash_type_mapping_key): Likewise.
764 (ctf_hash_eq_type_mapping_key): Likewise.
765 (ctf_add_type_mapping): Likewise.
766 (ctf_type_mapping): Likewise.
767 (ctf_dynhash_empty): Likewise.
768 * ctf-open.c (ctf_file_close): Update accordingly.
769 * ctf-create.c (ctf_update): Likewise.
770 (ctf_add_type): Populate the mapping.
771 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
772 (ctf_hash_eq_type_mapping_key): Check the key for equality.
773 (ctf_dynhash_insert): Fix comment typo.
774 (ctf_dynhash_empty): New.
775 * ctf-link.c (ctf_add_type_mapping): New.
776 (ctf_type_mapping): Likewise.
777 (empty_link_type_mapping): New.
778 (ctf_link_one_input_archive): Call it.
779
72c83edd
NA
7802019-07-13 Nick Alcock <nick.alcock@oracle.com>
781
782 * ctf-link.c: New file, linking of the string and type sections.
783 * Makefile.am (libctf_a_SOURCES): Add it.
784 * Makefile.in: Regenerate.
785
786 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
787 ctf_link_outputs.
788 * ctf-create.c (ctf_update): Update accordingly.
789 * ctf-open.c (ctf_file_close): Likewise.
790 * ctf-error.c (_ctf_errlist): Updated with new errors.
791
d18f9f16
NA
7922019-07-13 Nick Alcock <nick.alcock@oracle.com>
793
794 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
795
b4f0e09c
NA
7962019-07-13 Nick Alcock <nick.alcock@oracle.com>
797
798 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
799 ctf_type_iter.
800 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
801 (ctf_dump_format_type): Add non-root-type { } notation.
802 Add root flag to prototype.
803 (ctf_dump_label): Adjust accordingly.
804 (ctf_dump_objts): Likewise.
805 (ctf_dump_var): Likewise.
806
3dde2c91
NA
8072019-07-13 Nick Alcock <nick.alcock@oracle.com>
808
809 * ctf-create.c (ctf_compress_write): Fix double-free.
810
5537f9b9
NA
8112019-07-13 Nick Alcock <nick.alcock@oracle.com>
812
813 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
814 of...
815 (ctf_arc_write_fd): ... this new function.
816 * ctf-create.c (ctf_write_mem): New.
817
d851ecd3
NA
8182019-07-13 Nick Alcock <nick.alcock@oracle.com>
819
820 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
821 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
822 (ctf_str_add_ref): Name the last arg.
823 (ctf_str_add_external) New.
824 (ctf_str_add_strraw_explicit): Likewise.
825 (ctf_simple_open_internal): Likewise.
826 (ctf_bufopen_internal): Likewise.
827
828 * ctf-string.c (ctf_strraw_explicit): Split from...
829 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
830 (ctf_str_add_ref_internal): Return the atom, not the
831 string.
832 (ctf_str_add): Adjust accordingly.
833 (ctf_str_add_ref): Likewise. Move up in the file.
834 (ctf_str_add_external): New: update the csa_offset.
835 (ctf_str_count_strtab): Only account for strings with no csa_offset
836 in the internal strtab length.
837 (ctf_str_write_strtab): If the csa_offset is set, update the
838 string's refs without writing the string out, and update the
839 ctf_syn_ext_strtab. Make OOM handling less ugly.
840 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
841 (ctf_update): Handle failure to populate the strtab. Pass in the
842 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
843 Call ctf_simple_open_internal, not ctf_simple_open.
844 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
845 strings by hand.
846 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
847 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
848 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
849 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
850 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
851 (ctf_simple_open_internal): ... this new function, which calls
852 ctf_bufopen_internal.
853 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
854 (ctf_bufopen_internal): ... this new function, which sets
855 ctf_syn_ext_strtab.
856
0ac62312
NA
8572019-07-13 Nick Alcock <nick.alcock@oracle.com>
858
859 * ctf_types.c (ctf_type_iter_all): New.
860
2db912ba
NA
8612019-07-13 Nick Alcock <nick.alcock@oracle.com>
862
863 * ctf-open.c (init_symtab): Check for overflow against the right
864 section.
865 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
866 (upgrade_types_v1): Note that these sections are not checked.
867 (flip_header): Endian-swap the header fields.
868 (flip_ctf): Endian-swap the sections.
869 (flip_objts): Update comment.
870 (ctf_bufopen): Check header offsets and alignment for validity.
871
6d5944fc
NA
8722019-07-13 Nick Alcock <nick.alcock@oracle.com>
873
874 * ctf-open-bfd.c: Add <assert.h>.
875 (ctf_bfdopen_ctfsect): Open string and symbol tables using
876 techniques borrowed from bfd_elf_sym_name.
877 (ctf_new_archive_internal): Improve comment.
878 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
879 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
880 no symbol section, but not vice versa.
881
9b32cba4
NA
8822019-07-08 Nick Alcock <nick.alcock@oracle.com>
883
884 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
885 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
886 * ctf-dump.c (dump_header): New function, dump the CTF header.
887 (ctf_dump): Call it.
888 (ctf_dump_header_strfield): New function.
889 (ctf_dump_header_sectfield): Likewise.
890
fd55eae8
NA
8912019-07-06 Nick Alcock <nick.alcock@oracle.com>
892
893 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
894 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
895 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
896 ctf_base: do not assume that it is always sizeof (ctf_header_t).
897 Print out ctf_cuname: only print out ctf_parname if set.
898 (ctf_free_base): Removed, ctf_base is no longer freed: free
899 ctf_dynbase instead.
900 (ctf_set_version): Fix spacing.
901 (upgrade_header): New, in-place header upgrading.
902 (upgrade_types): Rename to...
903 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
904 longer track old and new headers separately. No longer allow for
905 header sizes explicitly: squeeze the headers out on upgrade (they
906 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
907 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
908 (upgrade_types): New, also handle ctf_parmax updating.
909 (flip_header): Flip ctf_cuname.
910 (flip_types): Flip BUF explicitly rather than deriving BUF from
911 BASE.
912 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
913 required alignment of objtoff and funcoff. No longer store it in
914 the ctf_buf unless that buf is derived unmodified from the input.
915 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
916 that duplicate fields in ctf_file: move allocation of ctf_file
917 further up instead. Call upgrade_header as needed. Move
918 version-specific ctf_parmax initialization into upgrade_types. More
919 concise error handling.
920 (ctf_file_close): No longer test for null pointers before freeing.
921 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
922 ctf_free_base.
923 (ctf_cuname): New.
924 (ctf_cuname_set): New.
925 * ctf-create.c (ctf_update): Populate ctf_cuname.
926 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
927 comment.
928 (ctf_write): Likewise.
929 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
930 Fix the compression length: fp->ctf_size never counted the CTF
931 header. Simplify the compress call accordingly.
932
a2230b5e
HPN
9332019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
934
935 * ctf-endian.h: Don't assume htole64 and le64toh are always
936 present if HAVE_ENDIAN_H; also check if htole64 is defined.
937 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
938 not bswap_identity_64.
939
fd361982
AM
9402019-09-18 Alan Modra <amodra@gmail.com>
941
942 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
943
60391a25
PB
9442019-09-09 Phil Blundell <pb@pbcl.net>
945
946 binutils 2.33 branch created.
947
12a0b67d
NA
9482019-07-18 Nick Alcock <nick.alcock@oracle.com>
949
950 * ctf-types.c (ctf_type_aname_raw): New.
951 (ctf_func_type_info): Likewise.
952 (ctf_func_type_args): Likewise.
953 * ctf-error.c (_ctf_errlist): Fix description.
954 * ctf-lookup.c: Fix file description.
955
083114f8 9562019-06-28 Nick Alcock <nick.alcock@oracle.com>
f57cf0e3
NA
957
958 * ctf-create.c (ctf_create): Fix off-by-one error.
959
083114f8 9602019-06-28 Nick Alcock <nick.alcock@oracle.com>
f5e9c9bd
NA
961
962 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
963 struct ctf_strs.
964 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
965 (struct ctf_str_atom): New, disambiguated single string.
966 (struct ctf_str_atom_ref): New, points to some other location that
967 references this string's offset.
968 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
969 Remove member ctf_dtvstrlen: we no longer track the total strlen
970 as we add strings.
971 (ctf_str_create_atoms): Declare new function in ctf-string.c.
972 (ctf_str_free_atoms): Likewise.
973 (ctf_str_add): Likewise.
974 (ctf_str_add_ref): Likewise.
975 (ctf_str_rollback): Likewise.
976 (ctf_str_purge_refs): Likewise.
977 (ctf_str_write_strtab): Likewise.
978 (ctf_realloc): Declare new function in ctf-util.c.
979
980 * ctf-open.c (ctf_bufopen): Create the atoms table.
981 (ctf_file_close): Destroy it.
982 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
983 special-case the position of the parname string. Construct the
984 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
985 rest of each buffer element is constructed, not via open-coding:
986 realloc the CTF buffer and append the strtab to it. No longer
987 maintain ctf_dtvstrlen. Sort the variable entry table later, after
988 strtab construction.
989 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
990 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
991 after buffer element construction instead.
992 (ctf_copy_lmembers): Likewise.
993 (ctf_copy_emembers): Likewise.
994 (ctf_create): No longer maintain the ctf_dtvstrlen.
995 (ctf_dtd_delete): Likewise.
996 (ctf_dvd_delete): Likewise.
997 (ctf_add_generic): Likewise.
998 (ctf_add_enumerator): Likewise.
999 (ctf_add_member_offset): Likewise.
1000 (ctf_add_variable): Likewise.
1001 (membadd): Likewise.
1002 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1003 if there are active ctf_str_num_refs.
1004 (ctf_strraw): Move to ctf-string.c.
1005 (ctf_strptr): Likewise.
1006 * ctf-string.c: New file, strtab manipulation.
1007
1008 * Makefile.am (libctf_a_SOURCES): Add it.
1009 * Makefile.in: Regenerate.
1010
083114f8 10112019-06-28 Nick Alcock <nick.alcock@oracle.com>
9658dc39
NA
1012
1013 * ctf-impl.h (ctf_hash_iter_f): New.
1014 (ctf_dynhash_iter): New declaration.
1015 (ctf_dynhash_iter_remove): New declaration.
1016 * ctf-hash.c (ctf_dynhash_iter): Define.
1017 (ctf_dynhash_iter_remove): Likewise.
1018 (ctf_hashtab_traverse): New.
1019 (ctf_hashtab_traverse_remove): Likewise.
1020 (struct ctf_traverse_cb_arg): Likewise.
1021 (struct ctf_traverse_remove_cb_arg): Likewise.
1022
083114f8 10232019-06-28 Nick Alcock <nick.alcock@oracle.com>
3e10cffc
NA
1024
1025 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1026
083114f8 10272019-06-28 Nick Alcock <nick.alcock@oracle.com>
c550e7ba
NA
1028
1029 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1030 (ctf_dump_funcs): Likewise.
1031
083114f8 10322019-06-19 Nick Alcock <nick.alcock@oracle.com>
cf02c44d
NA
1033
1034 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1035 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1036 little-endian CTF archive magic. Do not check the CTF version:
1037 ctf_simple_open does that in endian-safe ways. Do not dereference
1038 null pointers on open failure.
1039
083114f8 10402019-06-19 Nick Alcock <nick.alcock@oracle.com>
7cee1826
NA
1041
1042 * ctf-open.c (get_vbytes_common): Return the new slice size.
1043 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1044 Remember to copy in the CTF data when opening an uncompressed
1045 foreign-endian CTF file. Prune useless variable manipulation.
1046
083114f8 10472019-06-19 Nick Alcock <nick.alcock@oracle.com>
0b4fa56e
NA
1048
1049 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1050 seen.
1051
083114f8 10522019-06-19 Nick Alcock <nick.alcock@oracle.com>
364620bf
NA
1053
1054 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1055 output.
1056
083114f8 10572019-06-19 Nick Alcock <nick.alcock@oracle.com>
65365aa8
NA
1058
1059 * ctf-subr.c (_PAGESIZE): Remove.
1060 (ctf_data_alloc): Likewise.
1061 (ctf_data_free): Likewise.
1062 (ctf_data_protect): Likewise.
1063 * ctf-impl.h: Remove declarations.
1064 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1065 ctf_free, not ctf_data_free.
1066 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1067 the buffer again on compression error.
1068 * ctf-open.c (ctf_set_base): No longer track the size: call
1069 ctf_free, not ctf_data_free.
1070 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1071 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1072
083114f8 10732019-06-19 Nick Alcock <nick.alcock@oracle.com>
24865428
NA
1074
1075 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1076 ctf_dynhash_insert.
1077 (ctf_dvd_insert): Likewise.
1078 (ctf_add_generic): Likewise.
1079 (ctf_add_variable): Likewise.
1080 * ctf-impl.h: Adjust declarations.
1081
3a3a077c
AM
10822019-06-14 Alan Modra <amodra@gmail.com>
1083
1084 * configure: Regenerate.
1085
942d35f7
NA
10862019-06-06 Nick Alcock <nick.alcock@oracle.com>
1087
1088 * ctf-decls.h: Include <libiberty.h>.
1089 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1090
595a4d43
NA
10912019-06-06 Nick Alcock <nick.alcock@oracle.com>
1092
1093 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1094 (ctf_dump_objts): Likewise.
1095 (ctf_dump_funcs): Likewise.
1096 (ctf_dump_member): Likewise.
1097 (ctf_dump_str): Likewise.
1098
f5e73be1
NA
10992019-06-06 Nick Alcock <nick.alcock@oracle.com>
1100
1101 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1102 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1103
62d8e3b7
NA
11042019-06-05 Nick Alcock <nick.alcock@oracle.com>
1105
1106 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1107 (ctf_arc_open_by_offset): Likewise.
1108 * ctf-create.c (ctf_add_type): Likewise.
1109
76fad999
TT
11102019-06-04 Tom Tromey <tromey@adacore.com>
1111
1112 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1113 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1114
ad118caa
NA
11152019-06-04 Nick Alcock <nick.alcock@oracle.com>
1116
1117 * configure.ac: Check for O_CLOEXEC.
1118 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1119 * config.h.in: Regenerate.
1120 * configure: Likewise.
1121
6b22174f
NA
11222019-06-04 Nick Alcock <nick.alcock@oracle.com>
1123
1124 * qsort_r.c: Rename to...
1125 * ctf-qsort_r.c: ... this.
1126 (_quicksort): Define to ctf_qsort_r.
1127 * ctf-decls.h (qsort_r): Remove.
1128 (ctf_qsort_r): Add.
1129 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1130 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1131 * Makefile.am (libctf_a_LIBADD): Remove.
1132 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1133 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1134 * ctf-create.c (ctf_update): Likewise.
1135 * configure.ac: Check for BSD versus GNU qsort_r signature.
1136 * Makefile.in: Regenerate.
1137 * config.h.in: Likewise.
1138 * configure: Likewise.
1139
941accce
NA
11402019-06-03 Nick Alcock <nick.alcock@oracle.com>
1141
1142 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1143
a0486bac
JM
11442019-05-29 Nick Alcock <nick.alcock@oracle.com>
1145
1146 * Makefile.am (ZLIB): New.
1147 (ZLIBINC): Likewise.
1148 (AM_CFLAGS): Use them.
1149 (libctf_a_LIBADD): New, for LIBOBJS.
1150 * configure.ac: Check for zlib, endian.h, and qsort_r.
1151 * ctf-endian.h: New, providing htole64 and le64toh.
1152 * swap.h: Code style fixes.
1153 (bswap_identity_64): New.
1154 * qsort_r.c: New, from gnulib (with one added #include).
1155 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1156 and unconditional definitions of MIN and MAX.
1157 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1158 (ctf_set_errno): Now returns unsigned long.
1159 * ctf-util.c (ctf_set_errno): Adjust here too.
1160 * ctf-archive.c: Use ctf-endian.h.
1161 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1162 cts_flags and cts_offset.
1163 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1164 * ctf-create.c: Provide a definition of roundup if not defined.
1165 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1166 (ctf_add_reftype): Do not check if type IDs are below zero.
1167 (ctf_add_slice): Likewise.
1168 (ctf_add_typedef): Likewise.
1169 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1170 when known error-free. Drop CTF_ERR usage for functions returning
1171 int.
1172 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1173 int.
1174 (ctf_add_variable): Likewise.
1175 (enumcmp): Likewise.
1176 (enumadd): Likewise.
1177 (membcmp): Likewise.
1178 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1179 when known error-free.
1180 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1181 returning int: use CTF_ERR for functions returning ctf_type_id.
1182 (ctf_dump_label): Likewise.
1183 (ctf_dump_objts): Likewise.
1184 * ctf-labels.c (ctf_label_topmost): Likewise.
1185 (ctf_label_iter): Likewise.
1186 (ctf_label_info): Likewise.
1187 * ctf-lookup.c (ctf_func_args): Likewise.
1188 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1189 (ctf_bufopen): Likewise. Use zlib types as needed.
1190 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1191 returning int.
1192 (ctf_enum_iter): Likewise.
1193 (ctf_type_size): Likewise.
1194 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1195 (ctf_type_kind_unsliced): Likewise.
1196 (ctf_type_kind): Likewise.
1197 (ctf_type_encoding): Likewise.
1198 (ctf_member_info): Likewise.
1199 (ctf_array_info): Likewise.
1200 (ctf_enum_value): Likewise.
1201 (ctf_type_rvisit): Likewise.
1202 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1203 cts_offset.
1204 (ctf_simple_open): Likewise.
1205 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1206 * Makefile.in: Regenerate.
1207 * aclocal.m4: Likewise.
1208 * config.h: Likewise.
1209 * configure: Likewise.
1210
9698cf9b
NA
12112019-05-28 Nick Alcock <nick.alcock@oracle.com>
1212
1213 * configure.in: Check for bfd_section_from_elf_index.
1214 * configure: Regenerate.
1215 * config.h.in [HAVE_BFD_ELF]: Likewise.
1216 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1217 abfd is potentially unused now.
1218
0e65dfba
NA
12192019-05-28 Nick Alcock <nick.alcock@oracle.com>
1220
1221 * Makefile.am: New.
1222 * Makefile.in: Regenerated.
1223 * config.h.in: Likewise.
1224 * aclocal.m4: Likewise.
1225 * configure: Likewise.
1226
a30b3e18
NA
12272019-05-28 Nick Alcock <nick.alcock@oracle.com>
1228
1229 * ctf-dump.c: New.
1230
6dbf2b73
NA
12312019-05-28 Nick Alcock <nick.alcock@oracle.com>
1232
1233 * ctf-labels.c: New.
1234
6c33b742
NA
12352019-05-28 Nick Alcock <nick.alcock@oracle.com>
1236
1237 * ctf-impl.h (_libctf_version): New declaration.
1238 * ctf-subr.c (_libctf_version): Define it.
1239 (ctf_version): New.
1240
c499eb68
NA
12412019-05-28 Nick Alcock <nick.alcock@oracle.com>
1242
1243 * ctf-create.c (enumcmp): New.
1244 (enumadd): Likewise.
1245 (membcmp): Likewise.
1246 (membadd): Likewise.
1247 (ctf_add_type): Likewise.
1248
b437bfe0
NA
12492019-05-28 Nick Alcock <nick.alcock@oracle.com>
1250
1251 * ctf-lookup.c (isqualifier): New.
1252 (ctf_lookup_by_name): Likewise.
1253 (struct ctf_lookup_var_key): Likewise.
1254 (ctf_lookup_var): Likewise.
1255 (ctf_lookup_variable): Likewise.
1256 (ctf_lookup_symbol_name): Likewise.
1257 (ctf_lookup_by_symbol): Likewise.
1258 (ctf_func_info): Likewise.
1259 (ctf_func_args): Likewise.
1260
316afdb1
NA
12612019-05-28 Nick Alcock <nick.alcock@oracle.com>
1262
1263 * ctf-decl.c: New file.
1264 * ctf-types.c: Likewise.
1265 * ctf-impl.h: New declarations.
1266
143dce84
NA
12672019-05-28 Nick Alcock <nick.alcock@oracle.com>
1268
1269 * ctf-open-bfd.c: New file.
1270 * ctf-open.c (ctf_close): New.
1271 * ctf-impl.h: Include bfd.h.
1272 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1273 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1274 ctfi_bfd_close.
1275 (ctf_bfdopen_ctfsect): New declaration.
1276 (_CTF_SECTION): likewise.
1277
9402cc59
NA
12782019-05-28 Nick Alcock <nick.alcock@oracle.com>
1279
1280 * ctf-archive.c: New.
1281 * ctf-impl.h (ctf_archive_internal): New type.
1282 (ctf_arc_open_internal): New declaration.
1283 (ctf_arc_bufopen): Likewise.
1284 (ctf_arc_close_internal): Likewise.
1285
72f33921
NA
12862019-05-28 Nick Alcock <nick.alcock@oracle.com>
1287
1288 * ctf-open.c: New file.
1289 * swap.h: Likewise.
1290
47d546f4
NA
12912019-05-28 Nick Alcock <nick.alcock@oracle.com>
1292
1293 * ctf-create.c: New file.
1294 * ctf-lookup.c: New file.
1295
a5be9bbe
NA
12962019-05-28 Nick Alcock <nick.alcock@oracle.com>
1297
1298 * ctf-impl.h: New definitions and declarations for type creation
1299 and lookup.
1300
c0754cdd
NA
13012019-05-28 Nick Alcock <nick.alcock@oracle.com>
1302
1303 * ctf-hash.c: New file.
1304 * ctf-impl.h: New declarations.
1305
479604f4
NA
13062019-05-28 Nick Alcock <nick.alcock@oracle.com>
1307
1308 * ctf-error.c: New file.
1309
94585e7f
NA
13102019-05-28 Nick Alcock <nick.alcock@oracle.com>
1311
1312 * ctf-util.c: New file.
1313 * elf.h: Likewise.
1314 * ctf-impl.h: Include it, and add declarations.
1315
60da9d95
NA
13162019-05-28 Nick Alcock <nick.alcock@oracle.com>
1317
1318 * ctf-impl.h: New file.
1319 * ctf-subr.c: New file.
1320
1321\f
1322Local Variables:
1323mode: change-log
1324left-margin: 8
1325fill-column: 76
1326version-control: never
1327End: