]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - libctf/ChangeLog
libctf: make ctf_dump not crash on OOM
[thirdparty/binutils-gdb.git] / libctf / ChangeLog
CommitLineData
9323dd86
NA
12019-09-23 Nick Alcock <nick.alcock@oracle.com>
2
3 * ctf-impl.h (ctf_str_append_noerr): Declare.
4 * ctf-util.c (ctf_str_append_noerr): Define in terms of
5 ctf_str_append.
6 * ctf-dump.c (str_append): New, call it.
7 (ctf_dump_format_type): Use str_append, not ctf_str_append.
8 (ctf_dump_label): Likewise.
9 (ctf_dump_objts): Likewise.
10 (ctf_dump_funcs): Likewise.
11 (ctf_dump_var): Likewise.
12 (ctf_dump_member): Likewise.
13 (ctf_dump_type): Likewise.
14 (ctf_dump): Likewise.
15
de07e349
NA
162019-09-23 Nick Alcock <nick.alcock@oracle.com>
17
18 * ctf-impl.h (ctf_alloc): Remove.
19 (ctf_free): Likewise.
20 (ctf_strdup): Likewise.
21 * ctf-subr.c (ctf_alloc): Remove.
22 (ctf_free): Likewise.
23 * ctf-util.c (ctf_strdup): Remove.
24
25 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
26 ctf_free; strdup, not ctf_strdup.
27 (ctf_dtd_delete): Likewise.
28 (ctf_dvd_delete): Likewise.
29 (ctf_add_generic): Likewise.
30 (ctf_add_function): Likewise.
31 (ctf_add_enumerator): Likewise.
32 (ctf_add_member_offset): Likewise.
33 (ctf_add_variable): Likewise.
34 (membadd): Likewise.
35 (ctf_compress_write): Likewise.
36 (ctf_write_mem): Likewise.
37 * ctf-decl.c (ctf_decl_push): Likewise.
38 (ctf_decl_fini): Likewise.
39 (ctf_decl_sprintf): Likewise. Check for OOM.
40 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
41 ctf_free; strdup, not ctf_strdup.
42 (ctf_dump_free): Likewise.
43 (ctf_dump): Likewise.
44 * ctf-open.c (upgrade_types_v1): Likewise.
45 (init_types): Likewise.
46 (ctf_file_close): Likewise.
47 (ctf_bufopen_internal): Likewise. Check for OOM.
48 (ctf_parent_name_set): Likewise: report the OOM to the caller.
49 (ctf_cuname_set): Likewise.
50 (ctf_import): Likewise.
51 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
52 free, not ctf_free; strdup, not ctf_strdup.
53 (ctf_str_free_atom): Likewise.
54 (ctf_str_create_atoms): Likewise.
55 (ctf_str_add_ref_internal): Likewise.
56 (ctf_str_remove_ref): Likewise.
57 (ctf_str_write_strtab): Likewise.
58
9c1a2295
NA
592019-08-09 Nick Alcock <nick.alcock@oracle.com>
60
61 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
62 work right for non-int/fps.
63
1a6ab13e
NA
642019-08-08 Nick Alcock <nick.alcock@oracle.com>
65
66 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
67 null pointer.
68
99dc3ebd
NA
692019-08-07 Nick Alcock <nick.alcock@oracle.com>
70
71 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
72 * ctf-open.c (ctf_file_close): Free it.
73 * ctf-create.c (ctf_serialize): Adjust.
74 (membcmp): When reporting a conflict due to an error, report the
75 error.
76 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
77 (ctf_add_type_internal): ... this. Hand back types we are already
78 in the middle of adding immediately. Hand back structs/unions with
79 the same number of members immediately. Do not walk the dynamic
80 list. Call ctf_add_type_internal, not ctf_add_type. Handle
81 forwards promoted to other types and the inverse case identically.
82 Add structs to the mapping as soon as we intern them, before they
83 gain any members.
84
676c3ecb
NA
852019-08-09 Nick Alcock <nick.alcock@oracle.com>
86
87 * ctf-impl.h (ctf_names_t): New.
88 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
89 (ctf_file_t) <ctf_structs>: Likewise.
90 <ctf_unions>: Likewise.
91 <ctf_enums>: Likewise.
92 <ctf_names>: Likewise.
93 <ctf_lookups>: Improve comment.
94 <ctf_ptrtab_len>: New.
95 <ctf_prov_strtab>: New.
96 <ctf_str_prov_offset>: New.
97 <ctf_dtbyname>: Remove, redundant to the names hashes.
98 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
99 (ctf_dtdef_t) <dtd_name>: Remove.
100 <dtd_data>: Note that the ctt_name is now populated.
101 (ctf_str_atom_t) <csa_offset>: This is now the strtab
102 offset for internal strings too.
103 <csa_external_offset>: New, the external strtab offset.
104 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
105 (ctf_name_table): New declaration.
106 (ctf_lookup_by_rawname): Likewise.
107 (ctf_lookup_by_rawhash): Likewise.
108 (ctf_set_ctl_hashes): Likewise.
109 (ctf_serialize): Likewise.
110 (ctf_dtd_insert): Adjust.
111 (ctf_simple_open_internal): Likewise.
112 (ctf_bufopen_internal): Likewise.
113 (ctf_list_empty_p): Likewise.
114 (ctf_str_remove_ref): Likewise.
115 (ctf_str_add): Returns uint32_t now.
116 (ctf_str_add_ref): Likewise.
117 (ctf_str_add_external): Now returns a boolean (int).
118 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
119 for strings in the appropriate range.
120 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
121 when adding the null string to the new strtab.
122 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
123 (ctf_str_add_ref_internal): Add make_provisional argument. If
124 make_provisional, populate the offset and fill in the
125 ctf_prov_strtab accordingly.
126 (ctf_str_add): Return the offset, not the string.
127 (ctf_str_add_ref): Likewise.
128 (ctf_str_add_external): Return a success integer.
129 (ctf_str_remove_ref): New, remove a single ref.
130 (ctf_str_count_strtab): Do not count the initial null string's
131 length or the existence or length of any unreferenced internal
132 atoms.
133 (ctf_str_populate_sorttab): Skip atoms with no refs.
134 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
135 to the cts_len for the null string, since it is no longer done
136 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
137 Populate the csa_offset for both internal and external cases.
138 Flush the ctf_prov_strtab afterwards, and reset the
139 ctf_str_prov_offset.
140 * ctf-create.c (ctf_grow_ptrtab): New.
141 (ctf_create): Call it. Initialize new fields rather than old
142 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
143 Set the ctl hashes and data model.
144 (ctf_update): Rename to...
145 (ctf_serialize): ... this. Leave a compatibility function behind.
146 Tell ctf_simple_open_internal that this is a writable dictionary.
147 Pass the new fields along from the old dictionary. Drop
148 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
149 Do not zero out the DTD's ctt_name.
150 (ctf_prefixed_name): Rename to...
151 (ctf_name_table): ... this. No longer return a prefixed name: return
152 the applicable name table instead.
153 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
154 kind we're adding. Migrate away from dtd_name.
155 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
156 deleted ctt_name.
157 (ctf_dtd_lookup_type_by_name): Remove.
158 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
159 No longer check ctf_dtnextid: check ctf_typemax instead.
160 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
161 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
162 ctf_name_table and the right name table, and migrate away from
163 dtd_name as in ctf_dtd_delete.
164 (ctf_add_generic): Pass in the kind explicitly and pass it to
165 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
166 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
167 Grow the ptrtab if needed.
168 (ctf_add_encoded): Pass in the kind.
169 (ctf_add_slice): Likewise.
170 (ctf_add_array): Likewise.
171 (ctf_add_function): Likewise.
172 (ctf_add_typedef): Likewise.
173 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
174 ctt_name rather than dtd_name.
175 (ctf_add_struct_sized): Pass in the kind. Use
176 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
177 ctf_dtd_lookup_type_by_name.
178 (ctf_add_union_sized): Likewise.
179 (ctf_add_enum): Likewise.
180 (ctf_add_enum_encoded): Likewise.
181 (ctf_add_forward): Likewise.
182 (ctf_add_type): Likewise.
183 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
184 being initialized until after the call.
185 (ctf_write_mem): Likewise.
186 (ctf_write): Likewise.
187 * ctf-archive.c (arc_write_one_ctf): Likewise.
188 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
189 ctf_hash_lookup_type.
190 (ctf_lookup_by_id): No longer check the readonly types if the
191 dictionary is writable.
192 * ctf-open.c (init_types): Assert that this dictionary is not
193 writable. Adjust to use the new name hashes, ctf_name_table,
194 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
195 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
196 if set. Drop out early when dictionary is writable. Split the
197 ctf_lookups initialization into...
198 (ctf_set_cth_hashes): ... this new function.
199 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
200 (ctf_simple_open): Adjust accordingly.
201 (ctf_bufopen): Likewise.
202 (ctf_file_close): Destroy the appropriate name hashes. No longer
203 destroy ctf_dtbyname, which is gone.
204 (ctf_getdatasect): Remove spurious "extern".
205 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
206 specified name table, given a kind.
207 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
208 (ctf_member_iter): Add support for iterating over the
209 dynamic type list.
210 (ctf_enum_iter): Likewise.
211 (ctf_variable_iter): Likewise.
212 (ctf_type_rvisit): Likewise.
213 (ctf_member_info): Add support for types in the dynamic type list.
214 (ctf_enum_name): Likewise.
215 (ctf_enum_value): Likewise.
216 (ctf_func_type_info): Likewise.
217 (ctf_func_type_args): Likewise.
218 * ctf-link.c (ctf_accumulate_archive_names): No longer call
219 ctf_update.
220 (ctf_link_write): Likewise.
221 (ctf_link_intern_extern_string): Adjust for new
222 ctf_str_add_external return value.
223 (ctf_link_add_strtab): Likewise.
224 * ctf-util.c (ctf_list_empty_p): New.
225
791915db
NA
2262019-08-05 Nick Alcock <nick.alcock@oracle.com>
227
228 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
229 type zero.
230 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
231 members and types.
232 (ctf_add_variable): Likewise for variables pointing to them.
233 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
234 type link failure, but do warn for others.
235 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
236 errors to be ENOMEM.
237 (ctf_dump_member): Likewise.
238 (ctf_dump_type): Likewise.
239 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
240 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
241 (ctf_dump_header): Likewise.
242 (ctf_dump_label): likewise.
243 (ctf_dump_objts): likewise.
244 (ctf_dump_funcs): likewise.
245 (ctf_dump_var): likewise.
246 (ctf_dump_str): Likewise.
247
87279e3c
NA
2482019-09-30 Nick Alcock <nick.alcock@oracle.com>
249
250 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
251 (LT_INIT): Likewise.
252 (AM_INSTALL_LIBBFD): Likewise.
253 (dlopen): Note why this is necessary in a comment.
254 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
255 opcodes/.
256 (SHARED_LDFLAGS): Likewise.
257 (BFD_LIBADD): Likewise, for libbfd.
258 (BFD_DEPENDENCIES): Likewise.
259 (VERSION_FLAGS): Initialize, using a version script if ld supports
260 one, or libtool -export-symbols-regex otherwise.
261 (AC_CONFIG_MACRO_DIR): Add ../BFD.
262 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
263 (INCDIR): New.
264 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
265 (noinst_LIBRARIES): Replace with...
266 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
267 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
268 libctf-nobfd.la as well.
269 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
270 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
271 (libctf_a_SOURCES): Rename to...
272 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
273 ctf-open-bfd.c.
274 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
275 with ctf-open-bfd.c added.
276 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
277 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
278 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
279 * Makefile.am [INSTALL_LIBCTF]: Use it.
280 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
281 libtool macros.
282 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
283 the unstable components).
284 * Makefile.in: Regenerated.
285 * config.h.in: Likewise.
286 * configure: Likewise.
287
2882019-07-30 Nick Alcock <nick.alcock@oracle.com>
289
290 * configure.ac (INSTALL_LIBCTF): New, controlled by
291 --enable-install-libctf.
292 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
293 * Makefile.in: Regenerated.
294 * configure: Regenerated.
295
f046147d
NA
2962019-07-30 Nick Alcock <nick.alcock@oracle.com>
297
298 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
299 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
300
edc8bbe9
NA
3012019-07-30 Nick Alcock <nick.alcock@oracle.com>
302
303 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
304
7e97445a
NA
3052019-07-13 Nick Alcock <nick.alcock@oracle.com>
306
307 * ctf-impl.h (includes): Include <sys/param.h> here.
308
5ae6af75
NA
3092019-07-30 Nick Alcock <nick.alcock@oracle.com>
310
311 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
312 (flip_objts): Likewise.
313 (flip_vars): Likewise.
314 (flip_types): Likewise.
315
1820745a
NA
3162019-07-30 Nick Alcock <nick.alcock@oracle.com>
317
318 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
319 freeing functions: if set, free the key and value if the slot
320 already exists. Always reassign the key.
321 (ctf_dynhash_insert): Adjust call appropriately.
322 (ctf_hash_insert_type): Likewise.
323
5de9eada
NA
3242019-08-03 Nick Alcock <nick.alcock@oracle.com>
325
326 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
327 type kind. Allow forwards to unify with pre-existing structs/
328 unions/enums.
329
49ea9b45
NA
3302019-07-30 Nick Alcock <nick.alcock@oracle.com>
331
332 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
333 <ctf_link_memb_name_changer>: Likewise.
334 <ctf_link_memb_name_changer_arg>: Likewise.
335 * ctf-create.c (ctf_update): Update accordingly.
336 * ctf-open.c (ctf_file_close): Likewise.
337 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
338 (ctf_link_add_cu_mapping): New.
339 (ctf_link_set_memb_name_changer): Likewise.
340 (ctf_change_parent_name): New.
341 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
342 allocated by the caller's ctf_link_memb_name_changer.
343 <ndynames>: Likewise.
344 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
345 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
346 ctf_change_parent_name. Free any resulting names.
347
eabb7154
NA
3482019-07-13 Nick Alcock <nick.alcock@oracle.com>
349
350 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
351 (ctf_link_one_type): ... here, with parent-name setting added.
352 (check_variable): New.
353 (ctf_link_one_variable): Likewise.
354 (ctf_link_one_input_archive_member): Call it.
355 * ctf-error.c (_ctf_errlist): Updated with new errors.
356
886453cb
NA
3572019-07-13 Nick Alcock <nick.alcock@oracle.com>
358
359 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
360 (struct ctf_link_type_mapping_key): New.
361 (ctf_hash_type_mapping_key): Likewise.
362 (ctf_hash_eq_type_mapping_key): Likewise.
363 (ctf_add_type_mapping): Likewise.
364 (ctf_type_mapping): Likewise.
365 (ctf_dynhash_empty): Likewise.
366 * ctf-open.c (ctf_file_close): Update accordingly.
367 * ctf-create.c (ctf_update): Likewise.
368 (ctf_add_type): Populate the mapping.
369 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
370 (ctf_hash_eq_type_mapping_key): Check the key for equality.
371 (ctf_dynhash_insert): Fix comment typo.
372 (ctf_dynhash_empty): New.
373 * ctf-link.c (ctf_add_type_mapping): New.
374 (ctf_type_mapping): Likewise.
375 (empty_link_type_mapping): New.
376 (ctf_link_one_input_archive): Call it.
377
72c83edd
NA
3782019-07-13 Nick Alcock <nick.alcock@oracle.com>
379
380 * ctf-link.c: New file, linking of the string and type sections.
381 * Makefile.am (libctf_a_SOURCES): Add it.
382 * Makefile.in: Regenerate.
383
384 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
385 ctf_link_outputs.
386 * ctf-create.c (ctf_update): Update accordingly.
387 * ctf-open.c (ctf_file_close): Likewise.
388 * ctf-error.c (_ctf_errlist): Updated with new errors.
389
d18f9f16
NA
3902019-07-13 Nick Alcock <nick.alcock@oracle.com>
391
392 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
393
b4f0e09c
NA
3942019-07-13 Nick Alcock <nick.alcock@oracle.com>
395
396 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
397 ctf_type_iter.
398 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
399 (ctf_dump_format_type): Add non-root-type { } notation.
400 Add root flag to prototype.
401 (ctf_dump_label): Adjust accordingly.
402 (ctf_dump_objts): Likewise.
403 (ctf_dump_var): Likewise.
404
3dde2c91
NA
4052019-07-13 Nick Alcock <nick.alcock@oracle.com>
406
407 * ctf-create.c (ctf_compress_write): Fix double-free.
408
5537f9b9
NA
4092019-07-13 Nick Alcock <nick.alcock@oracle.com>
410
411 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
412 of...
413 (ctf_arc_write_fd): ... this new function.
414 * ctf-create.c (ctf_write_mem): New.
415
d851ecd3
NA
4162019-07-13 Nick Alcock <nick.alcock@oracle.com>
417
418 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
419 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
420 (ctf_str_add_ref): Name the last arg.
421 (ctf_str_add_external) New.
422 (ctf_str_add_strraw_explicit): Likewise.
423 (ctf_simple_open_internal): Likewise.
424 (ctf_bufopen_internal): Likewise.
425
426 * ctf-string.c (ctf_strraw_explicit): Split from...
427 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
428 (ctf_str_add_ref_internal): Return the atom, not the
429 string.
430 (ctf_str_add): Adjust accordingly.
431 (ctf_str_add_ref): Likewise. Move up in the file.
432 (ctf_str_add_external): New: update the csa_offset.
433 (ctf_str_count_strtab): Only account for strings with no csa_offset
434 in the internal strtab length.
435 (ctf_str_write_strtab): If the csa_offset is set, update the
436 string's refs without writing the string out, and update the
437 ctf_syn_ext_strtab. Make OOM handling less ugly.
438 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
439 (ctf_update): Handle failure to populate the strtab. Pass in the
440 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
441 Call ctf_simple_open_internal, not ctf_simple_open.
442 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
443 strings by hand.
444 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
445 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
446 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
447 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
448 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
449 (ctf_simple_open_internal): ... this new function, which calls
450 ctf_bufopen_internal.
451 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
452 (ctf_bufopen_internal): ... this new function, which sets
453 ctf_syn_ext_strtab.
454
0ac62312
NA
4552019-07-13 Nick Alcock <nick.alcock@oracle.com>
456
457 * ctf_types.c (ctf_type_iter_all): New.
458
2db912ba
NA
4592019-07-13 Nick Alcock <nick.alcock@oracle.com>
460
461 * ctf-open.c (init_symtab): Check for overflow against the right
462 section.
463 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
464 (upgrade_types_v1): Note that these sections are not checked.
465 (flip_header): Endian-swap the header fields.
466 (flip_ctf): Endian-swap the sections.
467 (flip_objts): Update comment.
468 (ctf_bufopen): Check header offsets and alignment for validity.
469
6d5944fc
NA
4702019-07-13 Nick Alcock <nick.alcock@oracle.com>
471
472 * ctf-open-bfd.c: Add <assert.h>.
473 (ctf_bfdopen_ctfsect): Open string and symbol tables using
474 techniques borrowed from bfd_elf_sym_name.
475 (ctf_new_archive_internal): Improve comment.
476 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
477 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
478 no symbol section, but not vice versa.
479
9b32cba4
NA
4802019-07-08 Nick Alcock <nick.alcock@oracle.com>
481
482 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
483 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
484 * ctf-dump.c (dump_header): New function, dump the CTF header.
485 (ctf_dump): Call it.
486 (ctf_dump_header_strfield): New function.
487 (ctf_dump_header_sectfield): Likewise.
488
fd55eae8
NA
4892019-07-06 Nick Alcock <nick.alcock@oracle.com>
490
491 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
492 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
493 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
494 ctf_base: do not assume that it is always sizeof (ctf_header_t).
495 Print out ctf_cuname: only print out ctf_parname if set.
496 (ctf_free_base): Removed, ctf_base is no longer freed: free
497 ctf_dynbase instead.
498 (ctf_set_version): Fix spacing.
499 (upgrade_header): New, in-place header upgrading.
500 (upgrade_types): Rename to...
501 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
502 longer track old and new headers separately. No longer allow for
503 header sizes explicitly: squeeze the headers out on upgrade (they
504 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
505 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
506 (upgrade_types): New, also handle ctf_parmax updating.
507 (flip_header): Flip ctf_cuname.
508 (flip_types): Flip BUF explicitly rather than deriving BUF from
509 BASE.
510 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
511 required alignment of objtoff and funcoff. No longer store it in
512 the ctf_buf unless that buf is derived unmodified from the input.
513 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
514 that duplicate fields in ctf_file: move allocation of ctf_file
515 further up instead. Call upgrade_header as needed. Move
516 version-specific ctf_parmax initialization into upgrade_types. More
517 concise error handling.
518 (ctf_file_close): No longer test for null pointers before freeing.
519 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
520 ctf_free_base.
521 (ctf_cuname): New.
522 (ctf_cuname_set): New.
523 * ctf-create.c (ctf_update): Populate ctf_cuname.
524 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
525 comment.
526 (ctf_write): Likewise.
527 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
528 Fix the compression length: fp->ctf_size never counted the CTF
529 header. Simplify the compress call accordingly.
530
a2230b5e
HPN
5312019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
532
533 * ctf-endian.h: Don't assume htole64 and le64toh are always
534 present if HAVE_ENDIAN_H; also check if htole64 is defined.
535 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
536 not bswap_identity_64.
537
fd361982
AM
5382019-09-18 Alan Modra <amodra@gmail.com>
539
540 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
541
60391a25
PB
5422019-09-09 Phil Blundell <pb@pbcl.net>
543
544 binutils 2.33 branch created.
545
12a0b67d
NA
5462019-07-18 Nick Alcock <nick.alcock@oracle.com>
547
548 * ctf-types.c (ctf_type_aname_raw): New.
549 (ctf_func_type_info): Likewise.
550 (ctf_func_type_args): Likewise.
551 * ctf-error.c (_ctf_errlist): Fix description.
552 * ctf-lookup.c: Fix file description.
553
083114f8 5542019-06-28 Nick Alcock <nick.alcock@oracle.com>
f57cf0e3
NA
555
556 * ctf-create.c (ctf_create): Fix off-by-one error.
557
083114f8 5582019-06-28 Nick Alcock <nick.alcock@oracle.com>
f5e9c9bd
NA
559
560 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
561 struct ctf_strs.
562 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
563 (struct ctf_str_atom): New, disambiguated single string.
564 (struct ctf_str_atom_ref): New, points to some other location that
565 references this string's offset.
566 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
567 Remove member ctf_dtvstrlen: we no longer track the total strlen
568 as we add strings.
569 (ctf_str_create_atoms): Declare new function in ctf-string.c.
570 (ctf_str_free_atoms): Likewise.
571 (ctf_str_add): Likewise.
572 (ctf_str_add_ref): Likewise.
573 (ctf_str_rollback): Likewise.
574 (ctf_str_purge_refs): Likewise.
575 (ctf_str_write_strtab): Likewise.
576 (ctf_realloc): Declare new function in ctf-util.c.
577
578 * ctf-open.c (ctf_bufopen): Create the atoms table.
579 (ctf_file_close): Destroy it.
580 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
581 special-case the position of the parname string. Construct the
582 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
583 rest of each buffer element is constructed, not via open-coding:
584 realloc the CTF buffer and append the strtab to it. No longer
585 maintain ctf_dtvstrlen. Sort the variable entry table later, after
586 strtab construction.
587 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
588 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
589 after buffer element construction instead.
590 (ctf_copy_lmembers): Likewise.
591 (ctf_copy_emembers): Likewise.
592 (ctf_create): No longer maintain the ctf_dtvstrlen.
593 (ctf_dtd_delete): Likewise.
594 (ctf_dvd_delete): Likewise.
595 (ctf_add_generic): Likewise.
596 (ctf_add_enumerator): Likewise.
597 (ctf_add_member_offset): Likewise.
598 (ctf_add_variable): Likewise.
599 (membadd): Likewise.
600 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
601 if there are active ctf_str_num_refs.
602 (ctf_strraw): Move to ctf-string.c.
603 (ctf_strptr): Likewise.
604 * ctf-string.c: New file, strtab manipulation.
605
606 * Makefile.am (libctf_a_SOURCES): Add it.
607 * Makefile.in: Regenerate.
608
083114f8 6092019-06-28 Nick Alcock <nick.alcock@oracle.com>
9658dc39
NA
610
611 * ctf-impl.h (ctf_hash_iter_f): New.
612 (ctf_dynhash_iter): New declaration.
613 (ctf_dynhash_iter_remove): New declaration.
614 * ctf-hash.c (ctf_dynhash_iter): Define.
615 (ctf_dynhash_iter_remove): Likewise.
616 (ctf_hashtab_traverse): New.
617 (ctf_hashtab_traverse_remove): Likewise.
618 (struct ctf_traverse_cb_arg): Likewise.
619 (struct ctf_traverse_remove_cb_arg): Likewise.
620
083114f8 6212019-06-28 Nick Alcock <nick.alcock@oracle.com>
3e10cffc
NA
622
623 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
624
083114f8 6252019-06-28 Nick Alcock <nick.alcock@oracle.com>
c550e7ba
NA
626
627 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
628 (ctf_dump_funcs): Likewise.
629
083114f8 6302019-06-19 Nick Alcock <nick.alcock@oracle.com>
cf02c44d
NA
631
632 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
633 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
634 little-endian CTF archive magic. Do not check the CTF version:
635 ctf_simple_open does that in endian-safe ways. Do not dereference
636 null pointers on open failure.
637
083114f8 6382019-06-19 Nick Alcock <nick.alcock@oracle.com>
7cee1826
NA
639
640 * ctf-open.c (get_vbytes_common): Return the new slice size.
641 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
642 Remember to copy in the CTF data when opening an uncompressed
643 foreign-endian CTF file. Prune useless variable manipulation.
644
083114f8 6452019-06-19 Nick Alcock <nick.alcock@oracle.com>
0b4fa56e
NA
646
647 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
648 seen.
649
083114f8 6502019-06-19 Nick Alcock <nick.alcock@oracle.com>
364620bf
NA
651
652 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
653 output.
654
083114f8 6552019-06-19 Nick Alcock <nick.alcock@oracle.com>
65365aa8
NA
656
657 * ctf-subr.c (_PAGESIZE): Remove.
658 (ctf_data_alloc): Likewise.
659 (ctf_data_free): Likewise.
660 (ctf_data_protect): Likewise.
661 * ctf-impl.h: Remove declarations.
662 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
663 ctf_free, not ctf_data_free.
664 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
665 the buffer again on compression error.
666 * ctf-open.c (ctf_set_base): No longer track the size: call
667 ctf_free, not ctf_data_free.
668 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
669 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
670
083114f8 6712019-06-19 Nick Alcock <nick.alcock@oracle.com>
24865428
NA
672
673 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
674 ctf_dynhash_insert.
675 (ctf_dvd_insert): Likewise.
676 (ctf_add_generic): Likewise.
677 (ctf_add_variable): Likewise.
678 * ctf-impl.h: Adjust declarations.
679
3a3a077c
AM
6802019-06-14 Alan Modra <amodra@gmail.com>
681
682 * configure: Regenerate.
683
942d35f7
NA
6842019-06-06 Nick Alcock <nick.alcock@oracle.com>
685
686 * ctf-decls.h: Include <libiberty.h>.
687 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
688
595a4d43
NA
6892019-06-06 Nick Alcock <nick.alcock@oracle.com>
690
691 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
692 (ctf_dump_objts): Likewise.
693 (ctf_dump_funcs): Likewise.
694 (ctf_dump_member): Likewise.
695 (ctf_dump_str): Likewise.
696
f5e73be1
NA
6972019-06-06 Nick Alcock <nick.alcock@oracle.com>
698
699 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
700 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
701
62d8e3b7
NA
7022019-06-05 Nick Alcock <nick.alcock@oracle.com>
703
704 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
705 (ctf_arc_open_by_offset): Likewise.
706 * ctf-create.c (ctf_add_type): Likewise.
707
76fad999
TT
7082019-06-04 Tom Tromey <tromey@adacore.com>
709
710 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
711 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
712
ad118caa
NA
7132019-06-04 Nick Alcock <nick.alcock@oracle.com>
714
715 * configure.ac: Check for O_CLOEXEC.
716 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
717 * config.h.in: Regenerate.
718 * configure: Likewise.
719
6b22174f
NA
7202019-06-04 Nick Alcock <nick.alcock@oracle.com>
721
722 * qsort_r.c: Rename to...
723 * ctf-qsort_r.c: ... this.
724 (_quicksort): Define to ctf_qsort_r.
725 * ctf-decls.h (qsort_r): Remove.
726 (ctf_qsort_r): Add.
727 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
728 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
729 * Makefile.am (libctf_a_LIBADD): Remove.
730 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
731 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
732 * ctf-create.c (ctf_update): Likewise.
733 * configure.ac: Check for BSD versus GNU qsort_r signature.
734 * Makefile.in: Regenerate.
735 * config.h.in: Likewise.
736 * configure: Likewise.
737
941accce
NA
7382019-06-03 Nick Alcock <nick.alcock@oracle.com>
739
740 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
741
a0486bac
JM
7422019-05-29 Nick Alcock <nick.alcock@oracle.com>
743
744 * Makefile.am (ZLIB): New.
745 (ZLIBINC): Likewise.
746 (AM_CFLAGS): Use them.
747 (libctf_a_LIBADD): New, for LIBOBJS.
748 * configure.ac: Check for zlib, endian.h, and qsort_r.
749 * ctf-endian.h: New, providing htole64 and le64toh.
750 * swap.h: Code style fixes.
751 (bswap_identity_64): New.
752 * qsort_r.c: New, from gnulib (with one added #include).
753 * ctf-decls.h: New, providing a conditional qsort_r declaration,
754 and unconditional definitions of MIN and MAX.
755 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
756 (ctf_set_errno): Now returns unsigned long.
757 * ctf-util.c (ctf_set_errno): Adjust here too.
758 * ctf-archive.c: Use ctf-endian.h.
759 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
760 cts_flags and cts_offset.
761 (ctf_arc_write): Drop debugging dependent on the size of off_t.
762 * ctf-create.c: Provide a definition of roundup if not defined.
763 (ctf_create): Drop cts_type, cts_flags and cts_offset.
764 (ctf_add_reftype): Do not check if type IDs are below zero.
765 (ctf_add_slice): Likewise.
766 (ctf_add_typedef): Likewise.
767 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
768 when known error-free. Drop CTF_ERR usage for functions returning
769 int.
770 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
771 int.
772 (ctf_add_variable): Likewise.
773 (enumcmp): Likewise.
774 (enumadd): Likewise.
775 (membcmp): Likewise.
776 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
777 when known error-free.
778 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
779 returning int: use CTF_ERR for functions returning ctf_type_id.
780 (ctf_dump_label): Likewise.
781 (ctf_dump_objts): Likewise.
782 * ctf-labels.c (ctf_label_topmost): Likewise.
783 (ctf_label_iter): Likewise.
784 (ctf_label_info): Likewise.
785 * ctf-lookup.c (ctf_func_args): Likewise.
786 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
787 (ctf_bufopen): Likewise. Use zlib types as needed.
788 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
789 returning int.
790 (ctf_enum_iter): Likewise.
791 (ctf_type_size): Likewise.
792 (ctf_type_align): Likewise. Cast to size_t where appropriate.
793 (ctf_type_kind_unsliced): Likewise.
794 (ctf_type_kind): Likewise.
795 (ctf_type_encoding): Likewise.
796 (ctf_member_info): Likewise.
797 (ctf_array_info): Likewise.
798 (ctf_enum_value): Likewise.
799 (ctf_type_rvisit): Likewise.
800 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
801 cts_offset.
802 (ctf_simple_open): Likewise.
803 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
804 * Makefile.in: Regenerate.
805 * aclocal.m4: Likewise.
806 * config.h: Likewise.
807 * configure: Likewise.
808
9698cf9b
NA
8092019-05-28 Nick Alcock <nick.alcock@oracle.com>
810
811 * configure.in: Check for bfd_section_from_elf_index.
812 * configure: Regenerate.
813 * config.h.in [HAVE_BFD_ELF]: Likewise.
814 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
815 abfd is potentially unused now.
816
0e65dfba
NA
8172019-05-28 Nick Alcock <nick.alcock@oracle.com>
818
819 * Makefile.am: New.
820 * Makefile.in: Regenerated.
821 * config.h.in: Likewise.
822 * aclocal.m4: Likewise.
823 * configure: Likewise.
824
a30b3e18
NA
8252019-05-28 Nick Alcock <nick.alcock@oracle.com>
826
827 * ctf-dump.c: New.
828
6dbf2b73
NA
8292019-05-28 Nick Alcock <nick.alcock@oracle.com>
830
831 * ctf-labels.c: New.
832
6c33b742
NA
8332019-05-28 Nick Alcock <nick.alcock@oracle.com>
834
835 * ctf-impl.h (_libctf_version): New declaration.
836 * ctf-subr.c (_libctf_version): Define it.
837 (ctf_version): New.
838
c499eb68
NA
8392019-05-28 Nick Alcock <nick.alcock@oracle.com>
840
841 * ctf-create.c (enumcmp): New.
842 (enumadd): Likewise.
843 (membcmp): Likewise.
844 (membadd): Likewise.
845 (ctf_add_type): Likewise.
846
b437bfe0
NA
8472019-05-28 Nick Alcock <nick.alcock@oracle.com>
848
849 * ctf-lookup.c (isqualifier): New.
850 (ctf_lookup_by_name): Likewise.
851 (struct ctf_lookup_var_key): Likewise.
852 (ctf_lookup_var): Likewise.
853 (ctf_lookup_variable): Likewise.
854 (ctf_lookup_symbol_name): Likewise.
855 (ctf_lookup_by_symbol): Likewise.
856 (ctf_func_info): Likewise.
857 (ctf_func_args): Likewise.
858
316afdb1
NA
8592019-05-28 Nick Alcock <nick.alcock@oracle.com>
860
861 * ctf-decl.c: New file.
862 * ctf-types.c: Likewise.
863 * ctf-impl.h: New declarations.
864
143dce84
NA
8652019-05-28 Nick Alcock <nick.alcock@oracle.com>
866
867 * ctf-open-bfd.c: New file.
868 * ctf-open.c (ctf_close): New.
869 * ctf-impl.h: Include bfd.h.
870 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
871 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
872 ctfi_bfd_close.
873 (ctf_bfdopen_ctfsect): New declaration.
874 (_CTF_SECTION): likewise.
875
9402cc59
NA
8762019-05-28 Nick Alcock <nick.alcock@oracle.com>
877
878 * ctf-archive.c: New.
879 * ctf-impl.h (ctf_archive_internal): New type.
880 (ctf_arc_open_internal): New declaration.
881 (ctf_arc_bufopen): Likewise.
882 (ctf_arc_close_internal): Likewise.
883
72f33921
NA
8842019-05-28 Nick Alcock <nick.alcock@oracle.com>
885
886 * ctf-open.c: New file.
887 * swap.h: Likewise.
888
47d546f4
NA
8892019-05-28 Nick Alcock <nick.alcock@oracle.com>
890
891 * ctf-create.c: New file.
892 * ctf-lookup.c: New file.
893
a5be9bbe
NA
8942019-05-28 Nick Alcock <nick.alcock@oracle.com>
895
896 * ctf-impl.h: New definitions and declarations for type creation
897 and lookup.
898
c0754cdd
NA
8992019-05-28 Nick Alcock <nick.alcock@oracle.com>
900
901 * ctf-hash.c: New file.
902 * ctf-impl.h: New declarations.
903
479604f4
NA
9042019-05-28 Nick Alcock <nick.alcock@oracle.com>
905
906 * ctf-error.c: New file.
907
94585e7f
NA
9082019-05-28 Nick Alcock <nick.alcock@oracle.com>
909
910 * ctf-util.c: New file.
911 * elf.h: Likewise.
912 * ctf-impl.h: Include it, and add declarations.
913
60da9d95
NA
9142019-05-28 Nick Alcock <nick.alcock@oracle.com>
915
916 * ctf-impl.h: New file.
917 * ctf-subr.c: New file.
918
919\f
920Local Variables:
921mode: change-log
922left-margin: 8
923fill-column: 76
924version-control: never
925End: