]>
Commit | Line | Data |
---|---|---|
00e5a55c BS |
1 | From: Xiuling Ma <xma@us.ibm.com> |
2 | Subject: [PATCH] disable catas_reset by default to avoid problems with EEH | |
3 | References: bnc#456389 | |
4 | ||
5 | PPC machines with EEH and Mellanox ib/net cards with catastrophic error | |
6 | recovery that encounter a PCI bus error can crash and become | |
7 | unresponsive. | |
8 | ||
9 | Disable the card reset to avoid this. | |
10 | ||
11 | NOTE: an upstream fix will come later once IBM can review a couple of | |
12 | approaches I suggested since this fix is brute force. This driver didn't have | |
13 | this reset on error feature in SLES10 so it isn't a feature removal. | |
14 | ||
15 | Signed-off-by: Xiuling Ma <xma@us.ibm.com> | |
16 | Acked-by: Brandon Philips <bphilips@suse.de> | |
17 | ||
18 | --- | |
19 | drivers/infiniband/hw/mthca/mthca_catas.c | 2 +- | |
20 | drivers/net/mlx4/catas.c | 2 +- | |
21 | 2 files changed, 2 insertions(+), 2 deletions(-) | |
22 | ||
23 | Index: linux-2.6/drivers/infiniband/hw/mthca/mthca_catas.c | |
24 | =================================================================== | |
25 | --- linux-2.6.orig/drivers/infiniband/hw/mthca/mthca_catas.c | |
26 | +++ linux-2.6/drivers/infiniband/hw/mthca/mthca_catas.c | |
27 | @@ -51,7 +51,7 @@ static LIST_HEAD(catas_list); | |
28 | static struct workqueue_struct *catas_wq; | |
29 | static struct work_struct catas_work; | |
30 | ||
31 | -static int catas_reset_disable; | |
32 | +static int catas_reset_disable = 1; | |
33 | module_param_named(catas_reset_disable, catas_reset_disable, int, 0644); | |
34 | MODULE_PARM_DESC(catas_reset_disable, "disable reset on catastrophic event if nonzero"); | |
35 | ||
36 | Index: linux-2.6/drivers/net/mlx4/catas.c | |
37 | =================================================================== | |
38 | --- linux-2.6.orig/drivers/net/mlx4/catas.c | |
39 | +++ linux-2.6/drivers/net/mlx4/catas.c | |
40 | @@ -45,7 +45,7 @@ static LIST_HEAD(catas_list); | |
41 | static struct workqueue_struct *catas_wq; | |
42 | static struct work_struct catas_work; | |
43 | ||
44 | -static int internal_err_reset = 1; | |
45 | +static int internal_err_reset = 0; | |
46 | module_param(internal_err_reset, int, 0644); | |
47 | MODULE_PARM_DESC(internal_err_reset, | |
48 | "Reset device on internal errors if non-zero (default 1)"); |