[thirdparty/git.git] / t / t3800-mktag.sh

#!/bin/sh
#
#

test_description='git mktag: tag object verify test'

. ./test-lib.sh

###########################################################
# check the tag.sig file, expecting verify_tag() to fail,
# and checking that the error message matches the pattern
# given in the expect.pat file.

check_verify_failure () {
	subject=$1 &&
	message=$2 &&
	shift 2 &&

	no_strict= &&
	fsck_obj_ok= &&
	no_strict= &&
	while test $# != 0
	do
		case "$1" in
		--no-strict)
			no_strict=yes
			;;
		--fsck-obj-ok)
			fsck_obj_ok=yes
			;;
		esac &&
		shift
	done &&

	test_expect_success "fail with [--[no-]strict]: $subject" '
		test_must_fail git mktag <tag.sig 2>err &&
		if test -z "$no_strict"
		then
			test_must_fail git mktag <tag.sig 2>err2 &&
			test_cmp err err2
		else
			git mktag --no-strict <tag.sig
		fi
	'

	test_expect_success "setup: $subject" '
		# Reset any leftover state from the last $subject
		rm -rf bad-tag &&

		git init --bare bad-tag &&
		git -C bad-tag hash-object -t tag -w --stdin --literally <tag.sig
	'

	test_expect_success "hash-object & fsck unreachable: $subject" '
		if test -n "$fsck_obj_ok"
		then
			git -C bad-tag fsck
		else
			test_must_fail git -C bad-tag fsck
		fi
	'
}

test_expect_mktag_success() {
	test_expect_success "$1" '
		git hash-object -t tag -w --stdin <tag.sig >expected &&
		git fsck --strict &&

		git mktag <tag.sig >hash &&
		test_cmp expected hash &&
		test_when_finished "git update-ref -d refs/tags/mytag $(cat hash)" &&
		git update-ref refs/tags/mytag $(cat hash) $(test_oid zero) &&
		git fsck --strict
	'
}

###########################################################
# first create a commit, so we have a valid object/type
# for the tag.
test_expect_success 'setup' '
	test_commit A &&
	test_commit B &&
	head=$(git rev-parse --verify HEAD) &&
	head_parent=$(git rev-parse --verify HEAD~) &&
	tree=$(git rev-parse HEAD^{tree}) &&
	blob=$(git rev-parse --verify HEAD:B.t)
'

test_expect_success 'basic usage' '
	cat >tag.sig <<-EOF &&
	object $head
	type commit
	tag mytag
	tagger T A Gger <tagger@example.com> 1206478233 -0500
	EOF
	git mktag <tag.sig &&
	git mktag --end-of-options <tag.sig &&
	test_expect_code 129 git mktag --unknown-option
'

############################################################
#  1. length check

cat >tag.sig <<EOF
too short for a tag
EOF

check_verify_failure 'Tag object length check' \
	'^error:.* missingObject:' 'strict'

############################################################
#  2. object line label check

cat >tag.sig <<EOF
xxxxxx $head
type tag
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure '"object" line label check' '^error:.* missingObject:'

############################################################
#  3. object line hash check

cat >tag.sig <<EOF
object $(echo $head | tr 0-9a-f z)
type tag
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure '"object" line check' '^error:.* badObjectSha1:'

############################################################
#  4. type line label check

cat >tag.sig <<EOF
object $head
xxxx tag
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure '"type" line label check' '^error:.* missingTypeEntry:'

############################################################
#  5. type line eol check

echo "object $head" >tag.sig
printf "type tagsssssssssssssssssssssssssssssss" >>tag.sig

check_verify_failure '"type" line eol check' '^error:.* unterminatedHeader:'

############################################################
#  6. tag line label check #1

cat >tag.sig <<EOF
object $head
type tag
xxx mytag
tagger . <> 0 +0000

EOF

check_verify_failure '"tag" line label check #1' \
	'^error:.* missingTagEntry:'

############################################################
#  7. tag line label check #2

cat >tag.sig <<EOF
object $head
type taggggggggggggggggggggggggggggggg
tag
EOF

check_verify_failure '"tag" line label check #2' \
	'^error:.* badType:'

############################################################
#  8. type line type-name length check

cat >tag.sig <<EOF
object $head
type taggggggggggggggggggggggggggggggg
tag mytag
EOF

check_verify_failure '"type" line type-name length check' \
	'^error:.* badType:'

############################################################
#  9. verify object (hash/type) check

cat >tag.sig <<EOF
object $(test_oid deadbeef)
type tag
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure 'verify object (hash/type) check -- correct type, nonexisting object' \
	'^fatal: could not read tagged object' \
	--fsck-obj-ok

cat >tag.sig <<EOF
object $head
type tagggg
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure 'verify object (hash/type) check -- made-up type, valid object' \
	'^error:.* badType:'

cat >tag.sig <<EOF
object $(test_oid deadbeef)
type tagggg
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure 'verify object (hash/type) check -- made-up type, nonexisting object' \
	'^error:.* badType:'

cat >tag.sig <<EOF
object $head
type tree
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure 'verify object (hash/type) check -- mismatched type, valid object' \
	'^fatal: object.*tagged as.*tree.*but is.*commit' \
	--fsck-obj-ok

############################################################
#  9.5. verify object (hash/type) check -- replacement

test_expect_success 'setup replacement of commit -> commit and tree -> blob' '
	git replace $head_parent $head &&
	git replace -f $tree $blob
'

cat >tag.sig <<EOF
object $head_parent
type commit
tag mytag
tagger . <> 0 +0000

EOF

test_expect_mktag_success 'tag to a commit replaced by another commit'

cat >tag.sig <<EOF
object $tree
type tree
tag mytag
tagger . <> 0 +0000

EOF

check_verify_failure 'verify object (hash/type) check -- mismatched type, valid object' \
	'^fatal: object.*tagged as.*tree.*but is.*blob' \
	--fsck-obj-ok

############################################################
# 10. verify tag-name check

cat >tag.sig <<EOF
object $head
type commit
tag my	tag
tagger . <> 0 +0000

EOF

check_verify_failure 'verify tag-name check' \
	'^error:.* badTagName:' \
	--no-strict \
	--fsck-obj-ok

############################################################
# 11. tagger line label check #1

cat >tag.sig <<EOF
object $head
type commit
tag mytag

This is filler
EOF

check_verify_failure '"tagger" line label check #1' \
	'^error:.* missingTaggerEntry:' \
	--no-strict \
	--fsck-obj-ok

############################################################
# 12. tagger line label check #2

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger

This is filler
EOF

check_verify_failure '"tagger" line label check #2' \
	'^error:.* missingTaggerEntry:' \
	--no-strict \
	--fsck-obj-ok

############################################################
# 13. allow missing tag author name like fsck

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger  <> 0 +0000

This is filler
EOF

test_expect_mktag_success 'allow missing tag author name'

############################################################
# 14. disallow missing tag author name

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <
 > 0 +0000

EOF

check_verify_failure 'disallow malformed tagger' \
	'^error:.* badEmail:' \
	--no-strict \
	--fsck-obj-ok

############################################################
# 15. allow empty tag email

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <> 0 +0000

EOF

test_expect_mktag_success 'allow empty tag email'

############################################################
# 16. allow spaces in tag email like fsck

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tag ger@example.com> 0 +0000

EOF

test_expect_mktag_success 'allow spaces in tag email like fsck'

############################################################
# 17. disallow missing tag timestamp

tr '_' ' ' >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com>__

EOF

check_verify_failure 'disallow missing tag timestamp' \
	'^error:.* badDate:'

############################################################
# 18. detect invalid tag timestamp1

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> Tue Mar 25 15:47:44 2008

EOF

check_verify_failure 'detect invalid tag timestamp1' \
	'^error:.* badDate:'

############################################################
# 19. detect invalid tag timestamp2

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 2008-03-31T12:20:15-0500

EOF

check_verify_failure 'detect invalid tag timestamp2' \
	'^error:.* badDate:'

############################################################
# 20. detect invalid tag timezone1

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 GMT

EOF

check_verify_failure 'detect invalid tag timezone1' \
	'^error:.* badTimezone:'

############################################################
# 21. detect invalid tag timezone2

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 +  30

EOF

check_verify_failure 'detect invalid tag timezone2' \
	'^error:.* badTimezone:'

############################################################
# 22. allow invalid tag timezone3 (the maximum is -1200/+1400)

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 -1430

EOF

test_expect_mktag_success 'allow invalid tag timezone'

############################################################
# 23. detect invalid header entry

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 -0500
this line should not be here

EOF

check_verify_failure 'detect invalid header entry' \
	'^error:.* extraHeaderEntry:' \
	--no-strict \
	--fsck-obj-ok

test_expect_success 'invalid header entry config & fsck' '
	test_must_fail git mktag <tag.sig &&
	git mktag --no-strict <tag.sig &&

	test_must_fail git -c fsck.extraHeaderEntry=error mktag <tag.sig &&
	test_must_fail git -c fsck.extraHeaderEntry=error mktag --no-strict <tag.sig &&

	test_must_fail git -c fsck.extraHeaderEntry=warn mktag <tag.sig &&
	git -c fsck.extraHeaderEntry=warn mktag --no-strict <tag.sig &&

	git -c fsck.extraHeaderEntry=ignore mktag <tag.sig &&
	git -c fsck.extraHeaderEntry=ignore mktag --no-strict <tag.sig &&

	git fsck &&
	git -c fsck.extraHeaderEntry=warn fsck 2>err &&
	grep "warning .*extraHeaderEntry:" err &&
	test_must_fail git -c fsck.extraHeaderEntry=error 2>err fsck &&
	grep "error .* extraHeaderEntry:" err
'

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 -0500


this line comes after an extra newline
EOF

test_expect_mktag_success 'allow extra newlines at start of body'

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 -0500

EOF

test_expect_mktag_success 'allow a blank line before an empty body (1)'

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 -0500
EOF

test_expect_mktag_success 'allow no blank line before an empty body (2)'

############################################################
# 24. create valid tag

cat >tag.sig <<EOF
object $head
type commit
tag mytag
tagger T A Gger <tagger@example.com> 1206478233 -0500
EOF

test_expect_mktag_success 'create valid tag object'

test_done
Commit	Line	Data
446c6fae RJ	1	#!/bin/sh
	2	#
	3	#
	4
0cb0e143	5	test_description='git mktag: tag object verify test'
446c6fae RJ	6
	7	. ./test-lib.sh
	8
	9	###########################################################
	10	# check the tag.sig file, expecting verify_tag() to fail,
	11	# and checking that the error message matches the pattern
	12	# given in the expect.pat file.
	13
	14	check_verify_failure () {
fce3b089 ÆAB	15	subject=$1 &&
	16	message=$2 &&
	17	shift 2 &&
	18
47c0cb1a ÆAB	19	no_strict= &&
47c0cb1a ÆAB	20	fsck_obj_ok= &&
fce3b089 ÆAB	21	no_strict= &&
	22	while test $# != 0
	23	do
	24	case "$1" in
	25	--no-strict)
	26	no_strict=yes
	27	;;
47c0cb1a ÆAB	28	--fsck-obj-ok)
	29	fsck_obj_ok=yes
	30	;;
fce3b089 ÆAB	31	esac &&
	32	shift
	33	done &&
	34
	35	test_expect_success "fail with [--[no-]strict]: $subject" '
	36	test_must_fail git mktag <tag.sig 2>err &&
	37	if test -z "$no_strict"
06ce7915	38	then
fce3b089 ÆAB	39	test_must_fail git mktag <tag.sig 2>err2 &&
fce3b089 ÆAB	40	test_cmp err err2
6a748c2c ÆAB	41	else
6a748c2c ÆAB	42	git mktag --no-strict <tag.sig
06ce7915	43	fi
fce3b089	44	'
47c0cb1a ÆAB	45
	46	test_expect_success "setup: $subject" '
	47	# Reset any leftover state from the last $subject
	48	rm -rf bad-tag &&
	49
	50	git init --bare bad-tag &&
	51	git -C bad-tag hash-object -t tag -w --stdin --literally <tag.sig
	52	'
	53
	54	test_expect_success "hash-object & fsck unreachable: $subject" '
	55	if test -n "$fsck_obj_ok"
	56	then
	57	git -C bad-tag fsck
	58	else
	59	test_must_fail git -C bad-tag fsck
	60	fi
	61	'
446c6fae RJ	62	}
446c6fae RJ	63
ca9a1ed9 ÆAB	64	test_expect_mktag_success() {
	65	test_expect_success "$1" '
	66	git hash-object -t tag -w --stdin <tag.sig >expected &&
	67	git fsck --strict &&
	68
	69	git mktag <tag.sig >hash &&
	70	test_cmp expected hash &&
	71	test_when_finished "git update-ref -d refs/tags/mytag $(cat hash)" &&
	72	git update-ref refs/tags/mytag $(cat hash) $(test_oid zero) &&
	73	git fsck --strict
	74	'
	75	}
	76
446c6fae RJ	77	###########################################################
	78	# first create a commit, so we have a valid object/type
	79	# for the tag.
4a45f7dd	80	test_expect_success 'setup' '
b5ca549c	81	test_commit A &&
692654dc ÆAB	82	test_commit B &&
	83	head=$(git rev-parse --verify HEAD) &&
	84	head_parent=$(git rev-parse --verify HEAD~) &&
	85	tree=$(git rev-parse HEAD^{tree}) &&
	86	blob=$(git rev-parse --verify HEAD:B.t)
4a45f7dd	87	'
446c6fae	88
3f390a36 ÆAB	89	test_expect_success 'basic usage' '
	90	cat >tag.sig <<-EOF &&
	91	object $head
	92	type commit
	93	tag mytag
	94	tagger T A Gger <tagger@example.com> 1206478233 -0500
	95	EOF
	96	git mktag <tag.sig &&
	97	git mktag --end-of-options <tag.sig &&
	98	test_expect_code 129 git mktag --unknown-option
	99	'
	100
446c6fae RJ	101	############################################################
	102	# 1. length check
	103
	104	cat >tag.sig <<EOF
	105	too short for a tag
	106	EOF
	107
e9b20943	108	check_verify_failure 'Tag object length check' \
06ce7915	109	'^error:.* missingObject:' 'strict'
446c6fae RJ	110
	111	############################################################
	112	# 2. object line label check
	113
	114	cat >tag.sig <<EOF
0d35ccb5	115	xxxxxx $head
446c6fae RJ	116	type tag
446c6fae RJ	117	tag mytag
e0aaf781 BC	118	tagger . <> 0 +0000
e0aaf781 BC	119
446c6fae RJ	120	EOF
446c6fae RJ	121
acf9de4c	122	check_verify_failure '"object" line label check' '^error:.* missingObject:'
446c6fae RJ	123
446c6fae RJ	124	############################################################
0d35ccb5	125	# 3. object line hash check
446c6fae RJ	126
446c6fae RJ	127	cat >tag.sig <<EOF
0d35ccb5	128	object $(echo $head \| tr 0-9a-f z)
446c6fae RJ	129	type tag
446c6fae RJ	130	tag mytag
e0aaf781 BC	131	tagger . <> 0 +0000
e0aaf781 BC	132
446c6fae RJ	133	EOF
446c6fae RJ	134
acf9de4c	135	check_verify_failure '"object" line check' '^error:.* badObjectSha1:'
446c6fae RJ	136
	137	############################################################
	138	# 4. type line label check
	139
	140	cat >tag.sig <<EOF
acb49d1c	141	object $head
446c6fae RJ	142	xxxx tag
446c6fae RJ	143	tag mytag
e0aaf781 BC	144	tagger . <> 0 +0000
e0aaf781 BC	145
446c6fae RJ	146	EOF
446c6fae RJ	147
acf9de4c	148	check_verify_failure '"type" line label check' '^error:.* missingTypeEntry:'
446c6fae RJ	149
	150	############################################################
	151	# 5. type line eol check
	152
acb49d1c	153	echo "object $head" >tag.sig
2aad957a	154	printf "type tagsssssssssssssssssssssssssssssss" >>tag.sig
446c6fae	155
acf9de4c	156	check_verify_failure '"type" line eol check' '^error:.* unterminatedHeader:'
446c6fae RJ	157
	158	############################################################
	159	# 6. tag line label check #1
	160
	161	cat >tag.sig <<EOF
acb49d1c	162	object $head
446c6fae RJ	163	type tag
446c6fae RJ	164	xxx mytag
e0aaf781 BC	165	tagger . <> 0 +0000
e0aaf781 BC	166
446c6fae RJ	167	EOF
446c6fae RJ	168
e9b20943	169	check_verify_failure '"tag" line label check #1' \
acf9de4c	170	'^error:.* missingTagEntry:'
446c6fae RJ	171
	172	############################################################
	173	# 7. tag line label check #2
	174
	175	cat >tag.sig <<EOF
acb49d1c	176	object $head
446c6fae RJ	177	type taggggggggggggggggggggggggggggggg
	178	tag
	179	EOF
	180
e9b20943	181	check_verify_failure '"tag" line label check #2' \
acf9de4c	182	'^error:.* badType:'
446c6fae RJ	183
	184	############################################################
	185	# 8. type line type-name length check
	186
	187	cat >tag.sig <<EOF
acb49d1c	188	object $head
446c6fae RJ	189	type taggggggggggggggggggggggggggggggg
	190	tag mytag
	191	EOF
	192
e9b20943	193	check_verify_failure '"type" line type-name length check' \
acf9de4c	194	'^error:.* badType:'
446c6fae RJ	195
446c6fae RJ	196	############################################################
30f882c1	197	# 9. verify object (hash/type) check
446c6fae RJ	198
446c6fae RJ	199	cat >tag.sig <<EOF
acb49d1c	200	object $(test_oid deadbeef)
30f882c1 ÆAB	201	type tag
	202	tag mytag
	203	tagger . <> 0 +0000
	204
	205	EOF
	206
	207	check_verify_failure 'verify object (hash/type) check -- correct type, nonexisting object' \
47c0cb1a ÆAB	208	'^fatal: could not read tagged object' \
47c0cb1a ÆAB	209	--fsck-obj-ok
30f882c1 ÆAB	210
	211	cat >tag.sig <<EOF
	212	object $head
446c6fae RJ	213	type tagggg
446c6fae RJ	214	tag mytag
e0aaf781 BC	215	tagger . <> 0 +0000
e0aaf781 BC	216
446c6fae RJ	217	EOF
446c6fae RJ	218
30f882c1	219	check_verify_failure 'verify object (hash/type) check -- made-up type, valid object' \
acf9de4c	220	'^error:.* badType:'
30f882c1 ÆAB	221
	222	cat >tag.sig <<EOF
	223	object $(test_oid deadbeef)
	224	type tagggg
	225	tag mytag
	226	tagger . <> 0 +0000
	227
	228	EOF
	229
	230	check_verify_failure 'verify object (hash/type) check -- made-up type, nonexisting object' \
acf9de4c	231	'^error:.* badType:'
446c6fae	232
30f882c1 ÆAB	233	cat >tag.sig <<EOF
	234	object $head
	235	type tree
	236	tag mytag
	237	tagger . <> 0 +0000
	238
	239	EOF
	240
692654dc	241	check_verify_failure 'verify object (hash/type) check -- mismatched type, valid object' \
47c0cb1a ÆAB	242	'^fatal: object.tagged as.tree.but is.commit' \
47c0cb1a ÆAB	243	--fsck-obj-ok
692654dc ÆAB	244
	245	############################################################
	246	# 9.5. verify object (hash/type) check -- replacement
	247
	248	test_expect_success 'setup replacement of commit -> commit and tree -> blob' '
	249	git replace $head_parent $head &&
	250	git replace -f $tree $blob
	251	'
	252
	253	cat >tag.sig <<EOF
	254	object $head_parent
	255	type commit
	256	tag mytag
	257	tagger . <> 0 +0000
	258
	259	EOF
	260
	261	test_expect_mktag_success 'tag to a commit replaced by another commit'
	262
	263	cat >tag.sig <<EOF
	264	object $tree
	265	type tree
	266	tag mytag
	267	tagger . <> 0 +0000
	268
	269	EOF
	270
30f882c1	271	check_verify_failure 'verify object (hash/type) check -- mismatched type, valid object' \
47c0cb1a ÆAB	272	'^fatal: object.tagged as.tree.but is.blob' \
47c0cb1a ÆAB	273	--fsck-obj-ok
30f882c1	274
446c6fae RJ	275	############################################################
	276	# 10. verify tag-name check
	277
	278	cat >tag.sig <<EOF
	279	object $head
	280	type commit
	281	tag my tag
e0aaf781 BC	282	tagger . <> 0 +0000
e0aaf781 BC	283
446c6fae RJ	284	EOF
446c6fae RJ	285
e9b20943	286	check_verify_failure 'verify tag-name check' \
fce3b089	287	'^error:.* badTagName:' \
47c0cb1a ÆAB	288	--no-strict \
47c0cb1a ÆAB	289	--fsck-obj-ok
446c6fae RJ	290
446c6fae RJ	291	############################################################
3dff5379	292	# 11. tagger line label check #1
446c6fae RJ	293
	294	cat >tag.sig <<EOF
	295	object $head
	296	type commit
	297	tag mytag
e0aaf781 BC	298
e0aaf781 BC	299	This is filler
446c6fae RJ	300	EOF
446c6fae RJ	301
e9b20943	302	check_verify_failure '"tagger" line label check #1' \
fce3b089	303	'^error:.* missingTaggerEntry:' \
47c0cb1a ÆAB	304	--no-strict \
47c0cb1a ÆAB	305	--fsck-obj-ok
446c6fae RJ	306
446c6fae RJ	307	############################################################
3dff5379	308	# 12. tagger line label check #2
446c6fae RJ	309
	310	cat >tag.sig <<EOF
	311	object $head
	312	type commit
	313	tag mytag
	314	tagger
e0aaf781 BC	315
e0aaf781 BC	316	This is filler
446c6fae RJ	317	EOF
446c6fae RJ	318
e9b20943	319	check_verify_failure '"tagger" line label check #2' \
fce3b089	320	'^error:.* missingTaggerEntry:' \
47c0cb1a ÆAB	321	--no-strict \
47c0cb1a ÆAB	322	--fsck-obj-ok
446c6fae RJ	323
446c6fae RJ	324	############################################################
acf9de4c	325	# 13. allow missing tag author name like fsck
446c6fae RJ	326
	327	cat >tag.sig <<EOF
	328	object $head
	329	type commit
	330	tag mytag
e0aaf781 BC	331	tagger <> 0 +0000
	332
	333	This is filler
	334	EOF
	335
acf9de4c	336	test_expect_mktag_success 'allow missing tag author name'
e0aaf781 BC	337
e0aaf781 BC	338	############################################################
ba26ab99	339	# 14. disallow missing tag author name
e0aaf781 BC	340
	341	cat >tag.sig <<EOF
	342	object $head
	343	type commit
	344	tag mytag
	345	tagger T A Gger <
	346	> 0 +0000
	347
	348	EOF
	349
ba26ab99	350	check_verify_failure 'disallow malformed tagger' \
fce3b089	351	'^error:.* badEmail:' \
47c0cb1a ÆAB	352	--no-strict \
47c0cb1a ÆAB	353	--fsck-obj-ok
e0aaf781 BC	354
	355	############################################################
	356	# 15. allow empty tag email
	357
	358	cat >tag.sig <<EOF
	359	object $head
	360	type commit
	361	tag mytag
	362	tagger T A Gger <> 0 +0000
	363
	364	EOF
	365
ca9a1ed9	366	test_expect_mktag_success 'allow empty tag email'
e0aaf781 BC	367
e0aaf781 BC	368	############################################################
acf9de4c	369	# 16. allow spaces in tag email like fsck
ba26ab99 BC	370
	371	cat >tag.sig <<EOF
	372	object $head
	373	type commit
	374	tag mytag
	375	tagger T A Gger <tag ger@example.com> 0 +0000
	376
	377	EOF
	378
acf9de4c	379	test_expect_mktag_success 'allow spaces in tag email like fsck'
ba26ab99 BC	380
	381	############################################################
	382	# 17. disallow missing tag timestamp
e0aaf781	383
74f16b0c	384	tr '_' ' ' >tag.sig <<EOF
e0aaf781 BC	385	object $head
	386	type commit
	387	tag mytag
74f16b0c	388	tagger T A Gger <tagger@example.com>__
e0aaf781 BC	389
	390	EOF
	391
ba26ab99	392	check_verify_failure 'disallow missing tag timestamp' \
acf9de4c	393	'^error:.* badDate:'
e0aaf781 BC	394
e0aaf781 BC	395	############################################################
ba26ab99	396	# 18. detect invalid tag timestamp1
e0aaf781 BC	397
	398	cat >tag.sig <<EOF
	399	object $head
	400	type commit
	401	tag mytag
	402	tagger T A Gger <tagger@example.com> Tue Mar 25 15:47:44 2008
	403
	404	EOF
	405
ba26ab99	406	check_verify_failure 'detect invalid tag timestamp1' \
acf9de4c	407	'^error:.* badDate:'
e0aaf781 BC	408
e0aaf781 BC	409	############################################################
ba26ab99 BC	410	# 19. detect invalid tag timestamp2
	411
	412	cat >tag.sig <<EOF
	413	object $head
	414	type commit
	415	tag mytag
	416	tagger T A Gger <tagger@example.com> 2008-03-31T12:20:15-0500
	417
	418	EOF
	419
	420	check_verify_failure 'detect invalid tag timestamp2' \
acf9de4c	421	'^error:.* badDate:'
ba26ab99 BC	422
	423	############################################################
	424	# 20. detect invalid tag timezone1
e0aaf781 BC	425
	426	cat >tag.sig <<EOF
	427	object $head
	428	type commit
	429	tag mytag
	430	tagger T A Gger <tagger@example.com> 1206478233 GMT
	431
	432	EOF
	433
ba26ab99	434	check_verify_failure 'detect invalid tag timezone1' \
acf9de4c	435	'^error:.* badTimezone:'
ba26ab99 BC	436
	437	############################################################
	438	# 21. detect invalid tag timezone2
	439
	440	cat >tag.sig <<EOF
	441	object $head
	442	type commit
	443	tag mytag
	444	tagger T A Gger <tagger@example.com> 1206478233 + 30
	445
	446	EOF
	447
	448	check_verify_failure 'detect invalid tag timezone2' \
acf9de4c	449	'^error:.* badTimezone:'
ba26ab99 BC	450
ba26ab99 BC	451	############################################################
acf9de4c	452	# 22. allow invalid tag timezone3 (the maximum is -1200/+1400)
ba26ab99 BC	453
	454	cat >tag.sig <<EOF
	455	object $head
	456	type commit
	457	tag mytag
	458	tagger T A Gger <tagger@example.com> 1206478233 -1430
	459
	460	EOF
	461
acf9de4c	462	test_expect_mktag_success 'allow invalid tag timezone'
e0aaf781 BC	463
e0aaf781 BC	464	############################################################
ba26ab99	465	# 23. detect invalid header entry
e0aaf781 BC	466
	467	cat >tag.sig <<EOF
	468	object $head
	469	type commit
	470	tag mytag
	471	tagger T A Gger <tagger@example.com> 1206478233 -0500
	472	this line should not be here
	473
	474	EOF
	475
	476	check_verify_failure 'detect invalid header entry' \
fce3b089	477	'^error:.* extraHeaderEntry:' \
47c0cb1a ÆAB	478	--no-strict \
47c0cb1a ÆAB	479	--fsck-obj-ok
e0aaf781	480
acfc0133 ÆAB	481	test_expect_success 'invalid header entry config & fsck' '
acfc0133 ÆAB	482	test_must_fail git mktag <tag.sig &&
06ce7915 ÆAB	483	git mktag --no-strict <tag.sig &&
06ce7915 ÆAB	484
acfc0133	485	test_must_fail git -c fsck.extraHeaderEntry=error mktag <tag.sig &&
06ce7915 ÆAB	486	test_must_fail git -c fsck.extraHeaderEntry=error mktag --no-strict <tag.sig &&
06ce7915 ÆAB	487
acfc0133	488	test_must_fail git -c fsck.extraHeaderEntry=warn mktag <tag.sig &&
06ce7915 ÆAB	489	git -c fsck.extraHeaderEntry=warn mktag --no-strict <tag.sig &&
06ce7915 ÆAB	490
acfc0133	491	git -c fsck.extraHeaderEntry=ignore mktag <tag.sig &&
06ce7915 ÆAB	492	git -c fsck.extraHeaderEntry=ignore mktag --no-strict <tag.sig &&
06ce7915 ÆAB	493
acfc0133	494	git fsck &&
780aa0a2	495	git -c fsck.extraHeaderEntry=warn fsck 2>err &&
acfc0133	496	grep "warning .*extraHeaderEntry:" err &&
780aa0a2	497	test_must_fail git -c fsck.extraHeaderEntry=error 2>err fsck &&
acfc0133 ÆAB	498	grep "error .* extraHeaderEntry:" err
	499	'
	500
47c95e77 ÆAB	501	cat >tag.sig <<EOF
	502	object $head
	503	type commit
	504	tag mytag
	505	tagger T A Gger <tagger@example.com> 1206478233 -0500
	506
	507
	508	this line comes after an extra newline
	509	EOF
	510
ca9a1ed9	511	test_expect_mktag_success 'allow extra newlines at start of body'
47c95e77 ÆAB	512
	513	cat >tag.sig <<EOF
	514	object $head
	515	type commit
	516	tag mytag
	517	tagger T A Gger <tagger@example.com> 1206478233 -0500
	518
	519	EOF
	520
9a1a3a4d	521	test_expect_mktag_success 'allow a blank line before an empty body (1)'
47c95e77 ÆAB	522
	523	cat >tag.sig <<EOF
	524	object $head
	525	type commit
	526	tag mytag
	527	tagger T A Gger <tagger@example.com> 1206478233 -0500
	528	EOF
	529
9a1a3a4d	530	test_expect_mktag_success 'allow no blank line before an empty body (2)'
47c95e77	531
e0aaf781	532	############################################################
ba26ab99	533	# 24. create valid tag
e0aaf781 BC	534
	535	cat >tag.sig <<EOF
	536	object $head
	537	type commit
	538	tag mytag
	539	tagger T A Gger <tagger@example.com> 1206478233 -0500
446c6fae RJ	540	EOF
446c6fae RJ	541
ca9a1ed9	542	test_expect_mktag_success 'create valid tag object'
446c6fae RJ	543
446c6fae RJ	544	test_done