]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blob - bfd/ChangeLog
2004-02-14 Andrew Cagney <cagney@redhat.com>
[thirdparty/binutils-gdb.git] / bfd / ChangeLog
1 2004-02-14 Andrew Cagney <cagney@redhat.com>
2
3 * configure.host (HDEFINES): When hppa*-*-hpux*, define
4 _LARGEFILE64_SOURCE.
5
6 2004-02-13 Andrew Cagney <cagney@redhat.com>
7
8 * elf.c (vma_page_aligned_bias): New function.
9 (assign_file_positions_except_relocs)
10 (assign_file_positions_for_segments): Replace broken modulo
11 arithmetic with call to vma_page_aligned_bias.
12
13 2004-02-11 Andrew Cagney <cagney@redhat.com>
14
15 * bfd-in.h: Update copyright.
16 (bfd_tell): Change return type to file_ptr.
17 * bfd-in2.h: Re-generate.
18 * cache.c: Update copyright.
19 (bfd_cache_lookup_worker): Use real_fseek, do not cast offset
20 parameter.
21 (close_one): Use real_ftell.
22 * bfdio.c: Update copyright.
23 (real_ftell, real_fseek): New functions.
24 (bfd_tell): Use real_fseek and real_ftell, change return type to
25 file_ptr.
26 (bfd_seek): Use real_ftell and real_fseek, change type of
27 file_position to a file_ptr.
28 * libbfd-in.h: Update copyright.
29 (real_ftell, real_fseek): Declare.
30 * libbfd.h: Re-generate.
31
32 * configure.in (AC_CHECK_FUNCS): Check for ftello, ftello64,
33 fseeko and fseeko64. Determine bfd_file_ptr.
34 * configure: Re-generate.
35 * config.in: Re-generate.
36
37 2004-02-09 Anil Paranjpe <anilp1@KPITCummins.com>
38
39 * coff-h8300.c: Added comments about relaxation for ldc.w and stc.w.
40 * elf32-h8300.c: Likewise.
41
42 2004-02-09 Christian Vogel <vogelchr@vogel.cx>
43 Nick Clifton <nickc@redhat.com>
44
45 * elf64-alpha.c (elf64_alpha_calc_got_offsets_for_symbol): Catch
46 GOT entries with no associated GOT subsection.
47
48 2004-02-09 Richard Sandiford <rsandifo@redhat.com>
49
50 * bfd-elf.h (elf_backend_name_local_section_symbols): New hook.
51 * elf.c (swap_out_syms): Use it to decide whether local section
52 symbols should be named.
53 * elfxx-target.h (elf_backend_name_local_section_symbols): New macro.
54 * elfxx-mips.h (_bfd_mips_elf_name_local_section_symbols): Declare.
55 (elf_backend_name_local_section_symbols): Define.
56 * elfxx-mips.c (_bfd_mips_elf_name_local_section_symbols): New.
57
58 2004-01-30 H.J. Lu <hongjiu.lu@intel.com>
59
60 * elfxx-ia64.c (elfNN_ia64_relax_brl): New function.
61 (elfNN_ia64_relax_section): Optimize brl to br during the relax
62 finalize pass.
63
64 2004-01-30 Alexandre Oliva <aoliva@redhat.com>
65
66 * elf32-frv.c (elf32_frv_always_size_sections): Initialize pointer
67 to bfd_link_hash_entry passed by reference to
68 _bfd_generic_link_add_one_symbol.
69
70 2004-01-25 H.J. Lu <hongjiu.lu@intel.com>
71
72 * elfxx-ia64.c (elfNN_ia64_relocate_section): Disallow imm
73 relocations against dynamic symbols.
74
75 2004-01-23 Daniel Jacobowitz <drow@mvista.com>
76
77 * elf32-arm.h (elf32_arm_check_relocs): Revert part of 2004-01-13
78 change.
79
80 2004-01-21 Tom Rix <tcrix@worldnet.att.net>
81
82 * reloc.c: New 5 bit reloc, BFD_RELOC_M68HC12_5B, for m68hc12 movb/movw.
83 * bfd-in2.h, libbfd.h: Rebuilt.
84
85 2004-01-20 Danny Smith <dannysmith@users.sourceforge.net>
86
87 * peXXigen.c (_bfd_XXi_swap_scnhdr_out): Don't remove
88 IMAGE_SCN_MEM_WRITE flag from .text section if WP_TEXT
89 flag has been cleared.
90
91 2004-01-19 Kazu Hirata <kazu@cs.umass.edu>
92
93 * coff-h8300.c: Add and adjust comments about relaxation.
94 * elf32-h8300.c: Likewise.
95
96 2004-01-16 Kazu Hirata <kazu@cs.umass.edu>
97
98 * coff-h8300.c: Fix comment typos.
99 * elf32-h8300.c: Likewise.
100
101 2004-01-16 Kazu Hirata <kazu@cs.umass.edu>
102
103 * coff-h8300.c: Add comments about relaxation.
104 * elf32-h8300.c: Likewise.
105
106 2004-01-14 Maciej W. Rozycki <macro@ds2.pg.gda.pl>
107
108 * acinclude.m4: Quote names of macros to be defined by AC_DEFUN
109 throughout.
110 * aclocal.m4: Regenerate.
111 * configure: Regenerate.
112
113 2004-01-13 Ian Lance Taylor <ian@wasabisystems.com>
114
115 * elf64-mips.c (mips_elf64_slurp_one_reloc_table): Call
116 mips_elf64_rtype_to_howto instead of using howto_table.
117
118 2004-01-13 Daniel Jacobowitz <drow@mvista.com>
119
120 * elf32-arm.h (elf32_arm_final_link_relocate): Check that we created
121 the .plt section.
122 (elf32_arm_check_relocs): Don't increment the PLT refcount for
123 relocs which would not use the PLT.
124
125 2004-01-13 Alan Modra <amodra@bigpond.net.au>
126
127 * elf64-ppc.c (ppc64_elf_check_relocs): Ignore !SEC_ALLOC relocs.
128 (ppc64_elf_gc_sweep_hook): Likewise.
129 (ppc64_elf_size_dynamic_sections): Test for .plt directly.
130
131 2004-01-12 Anil Paranjpe <anilp1@KPITCummins.com>
132
133 Adds linker relaxation support for bit manipulation insns like
134 band, bclr, biand, bild, bior, bist, bixor, bld, bnot, bor, bset,
135 bst, btst, bxor.
136 * elf32-h8300.c: Opcode for bit manipulation insn is checked in
137 elf32_h8_relax_section function while relxation for aa:16 and aa:32.
138 * coff-h8300.c: Opcode for bit manipulation insn is checked in
139 h8300_reloc16_extra_cases function while relxation for aa:16 and aa:32.
140
141 2004-01-12 Alan Modra <amodra@bigpond.net.au>
142
143 * dwarf2.c: Convert to C90, remove unneeded casts and prototypes.
144
145 2004-01-11 Kazu Hirata <kazu@cs.umass.edu>
146
147 * elf32-h8300.c: Fix formatting.
148
149 2004-01-11 Kazu Hirata <kazu@cs.umass.edu>
150
151 * elf32-cris.c (cris_elf_gc_sweep_hook): Return early if no
152 dynamic object is present. Declare r_symndx and h in an inner
153 scope.
154 * elf32-vax.c (elf_vax_gc_sweep_hook): Likewise.
155
156 2004-01-09 Daniel Jacobowitz <drow@mvista.com>
157
158 * elf32-arm.h (struct elf32_arm_relocs_copied): Remove pc_count.
159 (elf32_arm_copy_indirect_symbol): Don't copy pc_count.
160 (elf32_arm_final_link_relocate): Handle PLT32 and PC24 relocs
161 identically. Do not emit PC24 relocations for shared libraries.
162 (elf32_arm_gc_sweep_hook): Handle PLT32 and PC24 relocs
163 identically. Don't adjust pc_count.
164 (elf32_arm_check_relocs): Handle PLT32 and PC24 relocs identically.
165 Set ELF_LINK_HASH_NEEDS_PLT for both. Don't adjust pc_count; don't
166 adjust count for branch relocations.
167 (allocate_dynrelocs): Correct typo in call to
168 WILL_CALL_FINISH_DYNAMIC_SYMBOL. Never allocate space for
169 PC24 or PLT32 relocs when linking.
170
171 2004-01-09 Dmitry Semyonov <Dmitry.Semyonov@oktet.ru>
172
173 * coff-arm.c (aoutarm_std_reloc_howto): [ARM_WINCE] Synchronize ARM_26D
174 relocation howto with ARM_26 one for consistency.
175 (coff_arm_relocate_section): Set partial_inplace for ARM_26 relocations
176 that will be converted to ARM_26D ones, since we always want 'done'
177 relocations to be reflected in section's data.
178 (coff_arm_relocate_section): [ARM_WINCE] Quick fix for BL instruction
179 offset.
180 (_bfd_final_link_relocate): Do not modify "inplace" data, if not
181 requested.
182
183 2004-01-08 Dmitry Semyonov <Dmitry.Semyonov@oktet.ru>
184
185 * coff-arm.c (coff_arm_relocate_section): Do not alter relocs that
186 are not partial_inplace during a relocatable link.
187
188 2004-01-08 Kazu Hirata <kazu@cs.umass.edu>
189
190 * elf32-m68k.c (elf_m68k_gc_sweep_hook): Return early
191 if no dynamic object is present. Declare r_symndx and h in an
192 inner scope.
193
194 2004-01-07 H.J. Lu <hongjiu.lu@intel.com>
195
196 * elfxx-ia64.c (elfNN_ia64_relax_section): Don't install
197 trampoline if it is known out of range.
198
199 2004-01-06 Alexandre Oliva <aoliva@redhat.com>
200
201 2003-12-17 Alexandre Oliva <aoliva@redhat.com>
202 * elf32-frv.c (_frv_osec_readonly_p): New.
203 (_frv_emit_got_relocs_plt_entries): Don't emit rofixup for
204 undefweak symbol.
205 (_frv_count_got_plt_entries): Adjust expected count accordingly.
206 (elf32_frv_relocate_section): Likewise. Error out if attempting
207 to emit rofixups or dynamic relocs in read-only segments. Use
208 _bfd_elf_section_offset to adjust r_offsets in rofixups and
209 dynamic relocations.
210 2003-12-12 Alexandre Oliva <aoliva@redhat.com>
211 * elf32-frv.c (elf32_frv_relocate_section): Compute dynamic
212 relocations or fixups involving merged sections correctly. Avoid
213 crash when undefined symbol is referenced by R_FRV_32 or
214 R_FRV_FUNCDESC_VALUE.
215 2003-12-02 Alexandre Oliva <aoliva@redhat.com>
216 * elf32-frv.c (elf32_frv_relocate_section): Add output_offset of
217 input section holding local symbol to addend of R_FRV_32 or
218 R_FRV_FUNCDESC_VALUE dynamic relocation.
219 2003-11-27 Alexandre Oliva <aoliva@redhat.com>
220 * elf32-frv.c (elf32_frv_modify_segment_map): Add link info arg.
221 (elf32_frv_always_size_sections): Don't store pointer to
222 __stacksize symbol in sec_info.
223 (elf32_frv_modify_segment_map): Look it up here.
224 2003-11-26 Alexandre Oliva <aoliva@redhat.com>
225 * elf32-frv.c (_frv_emit_got_relocs_plt_entries): Emit the address
226 of the lazy PLT entry, not only its offset, as the low word of a
227 function descriptor.
228 2003-11-10 Alexandre Oliva <aoliva@redhat.com>
229 * elf32-frv.c (elf32_frv_always_size_sections): Define __stacksize
230 if a hash table entry already exists but is not a definition.
231 2003-11-05 Alexandre Oliva <aoliva@redhat.com>
232 * elf32-frv.c (frv_elf_link_hash_table_create): Use bfd_zalloc.
233 (_frv_add_rofixup): Don't inline.
234 (_frv_emit_got_relocs_plt_entries): Use NULL as funcdesc address
235 for undefweak symbols.
236 (elf32_frv_relocate_section): Avoid crash while computing
237 relocation when linking with shared library. Only emit rofixups
238 and dynamic relocations for alloc&load sections. Mark binaries
239 with inter-segment relocations for relocation as a unit.
240 (_frv_create_got_section): Rename .rofixup.got to .rofixup.
241 (DEFAULT_STACK_SIZE): New.
242 (_frv_count_got_plt_entries): Fix thinko in deciding whether to
243 emit rofixups or dynamic relocs when linking dynamic non-PIE
244 executables.
245 (elf32_frv_size_dynamic_sections): Generate rofixup on PIEs and
246 shared libs too. Reserve the last entry for the GOT pointer.
247 (elf32_frv_finish_dynamic_sections): Emit it.
248 (elf32_frv_always_size_sections): New.
249 (elf32_frv_modify_segment_map): New.
250 (elf32_frv_check_relocs): Reserve relocs32 space only in ALLOC
251 sections.
252 (frv_elf_merge_private_bfd_data): Clear PIC bit if FDPIC is set.
253 (frv_elf_print_private_bfd_data): Handle FDPIC and LIBPIC.
254 (elf_backend_always_size_sections): New.
255 (elf_backend_modify_segment_map): New.
256 2003-10-31 Alexandre Oliva <aoliva@redhat.com>
257 * config.bfd: Added frv-*-*linux*.
258 * elf32-frv.c (_frv_emit_got_relocs_plt_entries): Use idx 0 for
259 ABS section, instead of crashing.
260 (elf32_frv_relocate_section): Don't crash before warning about
261 different segments in non-PIC relocation.
262 2003-10-17 Alexandre Oliva <aoliva@redhat.com>
263 * elf32-frv.c (elf32_frv_relocate_section): Don't warn on LABEL24
264 relocs to undefweak symbols.
265 (elf32_frv_relocate_section): Ditto for undefined symbols.
266 2003-10-06 Alexandre Oliva <aoliva@redhat.com>
267 * elf32-frv.c (elf32_frv_create_dynamic_sections): Make sure
268 gotfixup section was created.
269 2003-09-30 Alexandre Oliva <aoliva@redhat.com>
270 * elf32-frv.c (elf32_frv_howto_table): Change GOT12,
271 FUNCDESC_GOT12, GOTOFF12 and FUNCDESC_GOTOFF12 to
272 complain_overflow_signed.
273 * elf32-frv.c (_frv_add_rofixup): Do not error out if contents
274 have not been allocated.
275 (_frv_emit_got_relocs_plt_entries): Return non-void. Assert
276 privfd only if dynamic sections were created.
277 (elf32_frv_relocate_section): Compute gprel_segment, and use it
278 for GPREL relocs. When linking relocatable FDPIC executables,
279 emit warnings for relocations that would be illegal on PIE or
280 shared libraries. Emit rofixup for R_FRV_32 only if input object
281 is not FDPIC.
282 (_frv_create_got_section): Define _gp symbol in the rofixup
283 section.
284 (elf32_frv_finish_dynamic_sections): If rofixups needed but
285 dynamic sections missing, error out requesting -melf32frvfd.
286 2003-09-19 Alexandre Oliva <aoliva@redhat.com>
287 * elf32-frv.c (_frv_emit_got_relocs_plt_entries): Rearrange
288 computation of addends from section and global or local symbol
289 value. Change return type to bfd_boolean, and return a failure if
290 a dynamic FUNCDESC or FUNCDESC_VALUE relocation that requires a
291 nonzero addend is required.
292 (elf32_frv_relocate_section): Likewise. Print error for
293 unsupported nonzero addends.
294 2003-09-18 Alexandre Oliva <aoliva@redhat.com>
295 * elf32-frv.c (FRV_SYM_LOCAL): In the absence of dynamic sections,
296 force everything local.
297 (_frv_emit_got_relocs_plt_entries): Cope with NULL sec.
298 * elf32-frv.c (struct frv_elf_link_hash_table): Added sgotfixup.
299 (frv_gotfixup_section): New.
300 (FRV_SYM_LOCAL): Accept undefweak and local common symbols.
301 (struct frv_pic_relocs_info): Split relocs into relocs32, relocsfd
302 and relocsfdv.
303 (_frv_add_rofixup): New.
304 (_frv_emit_got_relocs_plt_entries): Generate fixups for non-PIE
305 fdpic executables. Use FRV_SYM_LOCAL more widely to simplify and
306 improve some ugly conditions.
307 (elf32_frv_relocate_section): Likewise. Reject inter-segment
308 relocations in fdpic.
309 (_frv_create_got_section): Create .rofixup.got section.
310 (struct _frv_dynamic_got_info): Added fixups.
311 (_frv_count_got_plt_entries): Account in-GOT relocations into
312 relocs32, relocsfd and relocsfdv. Account them into relocs or
313 fixups, as appropriate.
314 (elf32_frv_size_dynamic_sections): Size rofixup section. Simplify
315 sizing of gotrel.
316 (elf32_frv_finish_dynamic_sections): Verify that the right number
317 of relocations and fixups was generated.
318 (elf32_frv_check_relocs): Compute relocs32, relocsfd and
319 relocsfdv.
320 * elf32-frv.c (FRV_SYM_LOCAL): New macro, used instead of
321 SYMBOL_CALLS_LOCAL and SYMBOL_REFERENCES_LOCAL.
322 (FRV_FUNCDESC_LOCAL): New macro, used to decide whether a function
323 descriptor of a (formerly-)global symbol is local.
324 (struct frv_pic_relocs_info): Adjust comments.
325 (_frv_emit_got_relocs_plt_entries): Adjust.
326 (elf32_frv_relocate_section): Likewise.
327 (_frv_count_got_plt_entries): Likewise.
328 * elf32-frv.c (_frv_emit_got_relocs_plt_entries): Don't add global
329 symbol's value to addend in the common preamble. Decay dynamic
330 symbols to section+offset if they bind or call locally, for GOT
331 and FUNCDESC_VALUE, respectively.
332 (elf32_frv_relocate_section): Likewise.
333 (elf32_frv_check_relocs): Don't register as dynamic symbols of
334 internal or hidden visibility.
335 2003-09-17 Alexandre Oliva <aoliva@redhat.com>
336 * elf32-frv.c (_frv_emit_got_relocs_plt_entries): Get addend as
337 argument, so as to not call _bfd_elf_rel_local_sym to compute it.
338 (elf32_frv_relocate_section): Pass relocation addend in. Use
339 original relocation addend to look up the got relocs/plt entries
340 table. Do not call _bfd_elf_rel_local_sym. Don't error out when
341 processing relocations that reference .scommon symbols.
342 2003-09-15 Alexandre Oliva <aoliva@redhat.com>
343 Introduce support for dynamic linking.
344 * elf32-frv.c (R_FRV_FUNCDESC_VALUE): Mark it as 64 bits.
345 (elf32_frv_rel_32_howto, elf32_frv_rel_funcdesc_howto,
346 elf32_frv_rel_funcdesc_value_howto): New REL descriptors.
347 (frv_reloc_type_lookup): Return REL howtos for executables and
348 dynamic libraries.
349 (frv_info_to_howto_rel): New.
350 (struct frv_elf_link_hash_table): New.
351 (frv_hash_table, frv_got_section, frv_gotrel_section,
352 frv_plt_section, frv_pltrel_section, frv_relocs_info,
353 frv_got_initial_offset, frv_plt_initial_offset): New macros.
354 (frv_elf_link_hash_table_create): New.
355 (struct frv_pic_relocs_info): New.
356 (frv_pic_relocs_info_hash, frv_pic_relocs_info_eq): New.
357 (frv_pic_relocs_info_find): New.
358 (frv_pic_relocs_info_for_global, frv_pic_relocs_info_for_local):
359 New.
360 (FRV_LZPLT_BLOCK_SIZE, FRV_LZPLT_RESOLVE_LOC): New.
361 (_frv_add_dyn_reloc, _frv_osec_to_segment): New.
362 (_frv_emit_got_relocs_plt_entries): New.
363 (elf32_frv_relocate_section): Add support for dynamic linking.
364 Handle new relocations.
365 (_frv_create_got_section): New.
366 (elf32_frv_create_dynamic_sections): New.
367 (ELF_DYNAMIC_INTERPRETER): New.
368 (struct _frv_dynamic_got_info): New.
369 (_frv_count_got_plt_entries): New.
370 (struct _frv_dynamic_got_plt_info): New.
371 (_frv_compute_got_alloc_data): New.
372 (_frv_get_got_entry, _frv_get_fd_entry): New.
373 (_frv_assign_got_entries, _frv_assign_plt_entries): New.
374 (_frv_resolve_final_relocs_info): New.
375 (elf32_frv_size_dynamic_sections): New.
376 (elf32_frv_finish_dynamic_sections): New.
377 (elf32_frv_adjust_dynamic_symbol): New.
378 (elf32_frv_finish_dynamic_symbol): New.
379 (elf32_frv_check_relocs): Handle new relocs. Explain how the
380 whole thing works.
381 (elf_info_to_howto_rel): Define.
382 (bfd_elf32_bfd_link_hash_table_create): Define.
383 (elf_backend_create_dynamic_sections): Define.
384 (elf_backend_adjust_dynamic_symbol): Define.
385 (elf_backend_size_dynamic_sections): Define.
386 (elf_backend_finish_dynamic_symbol): Define.
387 (elf_backend_finish_dynamic_sections): Define.
388 (elf_backend_want_got_sym): Define.
389 (elf_backend_got_header_size): Define.
390 (elf_backend_want_got_plt): Define.
391 (elf_backend_plt_readonly): Define.
392 (elf_backend_want_plt_sym): Define.
393 (elf_backend_plt_header_size): Define.
394 (elf_backend_may_use_rel_p): Define.
395 (elf_backend_may_use_rela_p): Define.
396 (elf_backend_default_use_rela_p): Define.
397 2003-08-08 Alexandre Oliva <aoliva@redhat.com>
398 * elf32-frv.c (R_FRV_FUNCDESC_VALUE, R_FRV_FUNCDESC_GOTOFF12,
399 R_FRV_FUNCDESC_GOTOFFHI, R_FRV_FUNCDESC_GOTOFFLO, R_FRV_GOTOFF12,
400 R_FRV_GOTOFFHI, R_FRV_GOTOFFLO): New.
401 (frv_reloc_map): Map the corresponding BFD relocs to them.
402 (frv_reloc_type_lookup): ... and back to BFD relocs.
403 * reloc.c: New relocs.
404 * bfd-in2.h, libbfd.h: Rebuilt.
405 2003-08-04 Alexandre Oliva <aoliva@redhat.com>
406 * elf32-frv.c (R_FRV_GOT12, R_FRV_GOTHI, R_FRV_GOTLO,
407 R_FRV_FUNCDESC, R_FRV_FUNCDESC_GOT12, R_FRV_FUNCDESC_GOTHI,
408 R_FRV_FUNCDESC_GOTLO): New.
409 (frv_reloc_map): Map the corresponding BFD relocs to them.
410 (frv_reloc_type_lookup): ... and back to BFD relocs.
411 * reloc.c: New relocs.
412 * bfd-in2.h, libbfd.h: Rebuilt.
413
414 2004-01-05 Maciej W. Rozycki <macro@ds2.pg.gda.pl>
415
416 * elf32-mips.c (ELF_MAXPAGESIZE): Redefine for traditional
417 targets to support pages of up to 64kB.
418 (elf32_bed): Redefine to get a separate backend data structure for
419 traditional targets.
420 * elf64-mips.c (ELF_MAXPAGESIZE): Redefine for traditional
421 targets to support pages of up to 64kB.
422 (elf64_bed): Redefine to get a separate backend data structure for
423 traditional targets.
424 * elfn32-mips.c (ELF_MAXPAGESIZE): Redefine for traditional
425 targets to support pages of up to 64kB.
426 (elf32_bed): Redefine to get a separate backend data structure for
427 traditional targets.
428
429 2004-01-04 Mark Kettenis <kettenis@gnu.org>
430
431 * elf32-sparc.c (elf32_sparc_grok_psinfo): New function.
432
433 2004-01-02 Mark Kettenis <kettenis@gnu.org>
434
435 * elf32-i386.c (elf_i386_grok_prstatus): Add support for FreeBSD.
436 (elf_i386_grok_psinfo): Likewise.
437
438 2004-01-02 Bernardo Innocenti <bernie@develer.com>
439
440 * config.bfd: Add m68k-uClinux target.
441
442 2004-01-01 Grant Edwards <grante@visi.com>
443
444 * elflink.h (elf_gc_sections): Warn when gc-sections option is ignored.
445 * elf32-h8300.c (elf32_h8_gc_mark_hook): New function.
446 (elf32_h8_gc_sweep_hook): New function.
447 (elf_backend_gc_mark_hook): Define.
448 (elf_backend_gc_sweep_hook): Define.
449 (elf_backend_can_gc_sections): Define.
450
451 For older changes see ChangeLog-0203
452 \f
453 Local Variables:
454 mode: change-log
455 left-margin: 8
456 fill-column: 74
457 version-control: never
458 End: