]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blob - binutils/ChangeLog
Tweak the 'how to make a release' document
[thirdparty/binutils-gdb.git] / binutils / ChangeLog
1 2019-10-12 Nick Clifton <nickc@redhat.com>
2
3 * README-how-to-make-a-release: Tweak a few sections based on the
4 results of the 2.33.1 release.
5
6 2019-10-11 Nick Clifton <nickc@redhat.com>
7
8 * po/zh_TW.po: Updated Chinese (traditional) translation.
9
10 2019-10-09 Alan Modra <amodra@gmail.com>
11
12 PR 25079
13 * ar.c (decode_options): Don't try for command options if
14 write_armap or mri_mode is selected.
15
16 2019-10-07 Jozef Lawrynowicz <jozef.l@mittosystems.com>
17
18 * readelf.c (display_msp430_gnu_attribute): New.
19 (process_arch_specific): Use msp430 specific handler for GNU
20 attributes.
21
22 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
23
24 * objdump.c (main): Fix tabdamage.
25 * readelf.c (CTF_DUMP): Likewise.
26 (options): Likewise.
27 (dump_section_as_ctf): Likewise.
28
29 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
30
31 * objdump.c (dump_ctf): Use the default CTF archive member as the
32 parent even when no parent section is specified.
33 (dump_ctf_archive_member): Only import from the parent
34 if this is not the default ".ctf" member.
35
36 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
37
38 * Makefile.am (LIBCTF): Mention the .la file.
39 (LIBCTF_NOBFD): New.
40 (readelf_DEPENDENCIES): Use it.
41 (readelf_LDADD): Likewise.
42 * Makefile.in: Regenerated.
43
44 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
45
46 * readelf.c (dump_ctf_symtab_name): Give default value.
47 (dump_ctf_strtab_name): Likewise.
48 (dump_section_as_ctf): Allow for the null string.
49
50 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
51
52 * objdump.c (dump_ctf_archive_member): Dump the CTF header.
53 * readelf.c (dump_section_as_ctf): Likewise.
54
55 2019-10-02 Niklas Gürtler <profclonk@gmail.com>
56
57 PR 24942
58 * objcopy.c (copy_usage): Update description of
59 --set-section-alignment.
60 (copy_main): Interpret numeric argument of --set-section-alignment
61 as a byte alignment, not a power of two alignment.
62 * doc/binutils.texi: Update description of
63 --set-section-alignment.
64 * testsuite/binutils-all/set-section-alignment.d: New test.
65 * testsuite/binutils-all/objcopy.exp: Run the new test.
66
67 2019-09-30 Alan Modra <amodra@gmail.com>
68
69 PR 25046
70 * readelf.c (process_program_headers): Clear dynamic_addr and
71 dynamic_size earlier.
72
73 2019-09-24 Alan Modra <amodra@gmail.com>
74
75 PR 25031
76 * nm.c (print_format_string): New.
77 (get_print_format): Delete saved_format. Move earlier.
78 (set_print_width): Call get_print_format.
79 (print_value): Use print_format_string.
80
81 2019-09-23 Alan Modra <amodra@gmail.com>
82
83 * dlltool.c: Include coff-bfd.h.
84
85 2019-09-23 Alan Modra <amodra@gmail.com>
86
87 PR 25018
88 * dwarf.c (get_type_signedness): Delete ineffective pointer
89 comparison check. Properly range check uvalue offset on
90 recursive call.
91 (read_and_display_attr_value): Range check uvalue offset before
92 calling get_type_signedness.
93
94 2019-09-20 Alan Modra <amodra@gmail.com>
95
96 * ar.c (write_archive): Use bfd_set_thin_archive.
97
98 2019-09-18 Tamar Christina <tamar.christina@arm.com>
99
100 * testsuite/binutils-all/objdump.exp (objump -S): Update testcases.
101
102 2019-09-18 Alan Modra <amodra@gmail.com>
103
104 * addr2line.c, * bucomm.c, * coffgrok.c, * dlltool.c, * nm.c,
105 * objcopy.c, * objdump.c, * od-elf32_avr.c, * od-macho.c,
106 * od-xcoff.c, * prdbg.c, * rdcoff.c, * rddbg.c, * rescoff.c,
107 * resres.c, * size.c, * srconv.c, * strings.c, * windmc.c: Update
108 throughout for bfd section macro and function changes.
109
110 2019-09-18 Alan Modra <amodra@gmail.com>
111
112 * nm.c: Update bfd_get_section to bfd_asymbol_section throughout.
113 * objcopy.c: Likewise.
114 * objdump.c: Likewise.
115 * rdcoff.c: Likewise.
116 * objcopy.c (create_new_symbol): Use bfd_set_asymbol_name.
117 (filter_symbols): Likewise.
118
119 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
120
121 * doc/Makefile.am (MOSTLYCLEANFILES): Clean all man pages,
122 cxxfilt.man and binutils.info.
123 (MAINTAINERCLEANFILES): Remove.
124 * doc/Makefile.in: Re-generate.
125
126 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
127
128 * doc/Makefile.am: Remove references to binutils_TEXINFOS.
129 * doc/Makefile.in: Re-generate.
130
131 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
132
133 * doc/Makefile.am (install-data-loca): Remove target.
134 (DISTCLEANFILES): Remove variable.
135 * doc/Makefile.in: Re-generate.
136
137 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
138
139 * Makefile.in: Re-generate.
140 * configure: Re-generate.
141 * doc/Makefile.in: Re-generate.
142
143 2019-09-16 Phil Blundell <pb@pbcl.net>
144
145 * Makefile.in, configure. doc/Makefile.in: Regenerated.
146
147 2019-09-11 Tom Tromey <tom@tromey.com>
148
149 * objcopy.c (copy_archive): Update.
150 * bucomm.h (make_tempname, make_tempdir): Make argument const.
151 * bucomm.c (make_tempname, make_tempdir): Make argument const.
152
153 2019-09-11 Alan Modra <amodra@gmail.com>
154
155 PR 24907
156 * objdump.c (disassemble_bytes): Adjust code to avoid overlong
157 lines. Correct max_reloc_offset_into_insn test.
158
159 2019-09-10 Nick Clifton <nickc@redhat.com>
160
161 PR 24907
162 * objdump.c (null_print): New function.
163 (disassemble_bytes): Delete previous_octets local and replace with
164 a test of the max_reloc_offset_into_insn field of the
165 bfd_arch_info structure. If a reloc is a potential match for the
166 next insn, then perform a dummy disassembly in order to calculate
167 its real length.
168
169 2019-09-09 Phil Blundell <pb@pbcl.net>
170
171 binutils 2.33 branch created.
172
173 2019-09-06 Alan Modra <amodra@gmail.com>
174
175 * nm.c (print_object_filename_bsd, print_object_filename_sysv),
176 (print_object_filename_posix, print_archive_filename_bsd),
177 (print_archive_filename_sysv, print_archive_filename_posix),
178 (print_archive_member_bsd, print_archive_member_sysv),
179 (print_archive_member_posix): Constify parameter.
180 (struct output_fns <print_object_filename, print_archive_filename>),
181 (<print_archive_member>): Likewise.
182 * objcopy.c (copy_archive): Add cast for make_tempdir.
183
184 2019-08-29 Alan Modra <amodra@gmail.com>
185
186 * dwarf.c (check_uvalue): Remove unnecessary pointer checks.
187
188 2019-08-28 Niklas Gürtler <profclonk@gmail.com>
189
190 PR 24942
191 * objcopy.c (SECTION_CONTEXT_SET_ALIGNMENT): New constant.
192 (struct section_list): Add alignment field.
193 (command_line_switch): Add OPTION_SET_SECTION_ALIGNMENT.
194 (copy_options): Add --set-section-alignment.
195 (copy_usage): Describe --set-section-alignment.
196 (find_section_list): Initialise the alignment field.
197 (setup_section): Handle the alignment field.
198 (copy_main): Handle OPTION_SET_SECTION_ALIGNMENT.
199 * doc/binutils.texi: Document the new feature.
200 * NEWS: Mention the new feature.
201
202 2019-08-28 Nick Clifton <nickc@redhat.com>
203
204 PR 24931
205 * objdump.c (source_comment): New static variable.
206 (option_values): Add OPTION_SOURCE_COMMENT.
207 (long_opions): Add --source-comment.
208 (print_line): If source comment is set, use it as a prefix to the
209 source code line.
210 (main): Handle OPTION_SOURCE_COMMENT.
211 * doc/binutils.texi: Document the new option.
212 * NEWS: Mention the new feature.
213 * testsuite/binutils-all/objdump.exp (test_objdump_S): Add tests
214 of the -S and --source-comment options.
215
216 2019-08-27 Nick Clifton <nickc@redhat.com>
217
218 PR 24510
219 * dwarf.c (MAX_CU_NESTING): New constant.
220 (level_type_signed): New static array.
221 (skip_attr_bytes): New function.
222 (get_type_signedness): New function.
223 (read_and_print_leb128): New function.
224 (display_discr_list): New function.
225 (read_and_display_attr_value): Add start parameter.
226 Use new functions when handling DW_AT_type and DW_AT_discr_list.
227 (read_and_display_attr): Add start parameter. Pass to
228 read_and_display_attr_value.
229 (process_debug_info): Update call to read_and_display_attr.
230 (display_formatted_table): Likewise.
231 (display_debug_lines_decoded): Likewise. Also add start
232 parameter.
233 (display_debug_lines): Likewise.
234 * testsuite/binutils-all/dwarf-attributes.S: Update discrimination
235 lists.
236 * testsuite/binutils-all/dwarf-attributes.W: Update expected
237 output.
238
239 2019-08-26 Alan Modra <amodra@gmail.com>
240
241 PR 24938
242 * debug.c (debug_write_type): Call empty_type for NULL type here..
243 (debug_write_type): ..rather than in just one case here.
244
245 2019-08-23 Nick Clifton <nickc@redhat.com>
246
247 PR 24829
248 * dwarf.c (check_uvalue): New function. Ensures that a block's
249 size is valid.
250 (read_and_display_attr_value): Use check_value when processsing
251 DW_FORM_block<n> attributes.
252
253 2019-08-22 Nick Clifton <nickc@redhat.com>
254
255 PR 24921
256 * dwarf.c (process_cu_tu_index): Handle the case where a table
257 does not have any columns.
258
259 2019-08-19 Alan Modra <amodra@gmail.com>
260
261 PR 24898
262 * dwarf.c (display_debug_frames): Use the read_cie check and error
263 for augmentation data length.
264
265 2019-08-17 Alan Modra <amodra@gmail.com>
266
267 PR 24911
268 * dwarf.c (comp_addr_base): Dereference args.
269
270 2019-08-16 Alan Modra <amodra@gmail.com>
271
272 PR 24909
273 PR 23499
274 * readelf.c (get_symbol_version_string): Set sym_info earlier.
275
276 2019-08-15 Nick Clifton <nickc@redhat.com>
277
278 PR 24767
279 * doc/binutils.texi (nm): Document the 'n' symbol type.
280
281 2019-08-15 Christophe Vidal <support@krizalys.com>
282
283 * docs/binutils.texi: Fixed notice message disassembler options
284 section of the man page.
285
286 2019-08-09 Mihailo Stojanovic <mihailo.stojanovic@rt-rk.com>
287
288 * readelf.c (get_mips_dynamic_type): Return MIPS_XHASH dynamic type.
289 (get_mips_section_type_name): Return MI{S_XHASH name string.
290 (dynamic_section_mips_val): Initialize the .MIPS.xhash dynamic
291 info.
292 (process_symbol_table): Initialize the .MIPS.xhash section
293 pointer. Adjust the readelf output to support the new section.
294 (process_object): Set the .MIPS.xhash dynamic info to zero.
295
296 2019-08-09 Tamar Christina <tamar.christina@arm.com>
297
298 * testsuite/binutils-all/arm/in-order-all.d: Skip on pe, wince, coff.
299 * testsuite/binutils-all/arm/in-order.d: Likewise.
300 * testsuite/binutils-all/arm/out-of-order-all.d: Likewise.
301 * testsuite/binutils-all/arm/out-of-order.d: Likewise.
302
303 2019-08-08 Nick Clifton <nickc@redhat.com>
304
305 PR 24887
306 * readelf.c (process_notes_at): Left justify the "Data size"
307 column heading.
308 * testsuite/binutils-all/i386/empty.d: Adjust for new output format.
309 * testsuite/binutils-all/i386/ibt.d: Likewise.
310 * testsuite/binutils-all/i386/pr21231a.d: Likewise.
311 * testsuite/binutils-all/i386/pr21231b.d: Likewise.
312 * testsuite/binutils-all/i386/shstk.d: Likewise.
313 * testsuite/binutils-all/note-2-32.d: Likewise.
314 * testsuite/binutils-all/note-2-64.d: Likewise.
315 * testsuite/binutils-all/x86-64/empty-x32.d: Likewise.
316 * testsuite/binutils-all/x86-64/empty.d: Likewise.
317 * testsuite/binutils-all/x86-64/ibt-x32.d: Likewise.
318 * testsuite/binutils-all/x86-64/ibt.d: Likewise.
319 * testsuite/binutils-all/x86-64/pr21231a.d: Likewise.
320 * testsuite/binutils-all/x86-64/pr21231b.d: Likewise.
321 * testsuite/binutils-all/x86-64/pr23494a-x32.d: Likewise.
322 * testsuite/binutils-all/x86-64/pr23494a.d: Likewise.
323 * testsuite/binutils-all/x86-64/pr23494c-x32.d: Likewise.
324 * testsuite/binutils-all/x86-64/pr23494c.d: Likewise.
325 * testsuite/binutils-all/x86-64/pr23494d-x32.d: Likewise.
326 * testsuite/binutils-all/x86-64/pr23494d.d: Likewise.
327 * testsuite/binutils-all/x86-64/pr23494e-x32.d: Likewise.
328 * testsuite/binutils-all/x86-64/pr23494e.d: Likewise.
329 * testsuite/binutils-all/x86-64/shstk-x32.d: Likewise.
330 * testsuite/binutils-all/x86-64/shstk.d: Likewise.
331
332 2019-08-08 Nick Clifton <nickc@redhat.com>
333
334 * testsuite/gentestdlls.c (main): Move declaration of loop
335 variable outside of the for() statement.
336
337 2019-08-08 Jordan Rupprecht <rupprecht@google.com>
338
339 * readelf.c (process_note): Mask unknown description data bytes.
340
341 2019-08-08 Alan Modra <amodra@gmail.com>
342
343 * readelf.c (get_data): Improve overflow checks.
344
345 2019-08-07 Nick Clifton <nickc@redhat.com>
346
347 PR 24777
348 * doc/binutils.texi: Ensure consistent formating of title strings
349 for man pages. Extend the title of the size man page to be more
350 informative.
351
352 2019-08-07 Omair Majid <omajid@redhat.com>
353
354 * testsuite/binutils-all/objdump.exp
355 (test_objdump_dotnet_assemblies): Fix test to distinguish errors
356 in parsing simple pei-i386 and pei-x86-64 vs parsing the newly
357 introduced machine types.
358 * testsuite/gentestdlls.c (write_simple_dll): New function.
359 (main): Generate simple and Linux-specific variants of pei-i386
360 and pei-x86-64 files so both can be used by tests.
361
362 2019-08-07 Alan Modra <amodra@gmail.com>
363
364 PR 24876
365 * readelf.c (dump_ia64_unwind): Check that buffer is large
366 enough for "stamp" before reading.
367
368 2019-08-05 Nick Clifton <nickc@redhat.com>
369
370 PR 24874
371 * objcopy.c (merge_gnu_build_notes): Do not insist on the first
372 note being a version note.
373 Remove spurious debugging fprintf.
374
375 2019-08-05 Nick Clifton <nickc@redhat.com>
376
377 PR 24829
378 * readelf.c (apply_relocations): Catch potential integer overflow
379 whilst checking reloc location against section size.
380
381 2019-08-02 Alan Modra <amodra@gmail.com>
382
383 PR 24871
384 * readelf.c (ABSADDR): Delete.
385 (dump_ia64_unwind): Expand ABSADDR. Check validity of info.section.
386
387 2019-07-29 Martin Liska <mliska@suse.cz>
388
389 PR 24768
390 * nm.c (filter_symbols): Set report_plugin_err if
391 error is reported.
392 (display_rel_file): Report error for a missing LTO plugin.
393
394 2019-07-26 Alan Modra <amodra@gmail.com>
395
396 PR 24798
397 * dwarf.c (process_cu_tu_index): Avoid integer overflow on 64-bit
398 systems by casting ncols and nslots expressions to size_t. Display
399 number of columns and slots before giving up due to buffer overflow.
400 Use %u to display unsigned ints. Perform more pointer wrap tests.
401
402 2019-07-25 Tom Tromey <tromey@adacore.com>
403
404 PR 24809
405 * dwarf.c (display_debug_names): Display the contents of the
406 augmentation string, if it is printable.
407
408 2019-07-25 Nick Clifton <nickc@redhat.com>
409
410 PR 24837
411 * readelf.c (process_mips_specific): Check for buffer overflow
412 before reading reginfo information.
413
414 2019-07-24 Nick Clifton <nickc@redhat.com>
415
416 PR 13256
417 * ar.c (decode_options): Restart option scanning if no operation
418 is detected and argument remain to be scanned.
419
420 2019-07-23 Nick Clifton <nickc@redhat.com>
421
422 PR 24818
423 * objdump.c (is_relocateable): Delete.
424 (load_specific_debug_section): Test the abfd for relocations
425 directly, rather than relying upon is_relocateable.
426 (dump_dwarf): Delete initlialization of is_relocateable.
427
428 2019-07-23 Alan Modra <amodra@gmail.com>
429
430 * readelf.c (get_parisc_segment_type): Split off hpux entries..
431 (get_ia64_segment_type): ..and these..
432 (get_hpux_segment_type): ..to here.
433 (get_segment_type): Condition GNU_MBIND on osabi. Use
434 get_hpux_segment_type.
435 (get_symbol_binding): Do not print UNIQUE for ELFOSABI_NONE.
436 (get_symbol_type): Do not print IFUNC for ELFOSABI_NONE.
437
438 2019-07-23 Alan Modra <amodra@gmail.com>
439
440 * testsuite/binutils-all/objcopy.exp (elf64): Correct object
441 file used to set this variable.
442
443 2019-07-23 Omar Majid <omajid@redhat.com>
444
445 * Makefile.am (AUTOMAKE_OPTIONS): Add subdir-objects
446 (GENTESTDLLSPROG): Define.
447 (TEST_PROGS): Add GENTESTDLLSPROG.
448 * Makefile.in: Regenerate.
449 * testsuite/binutils-all/objdump.exp
450 (test_objdump_dotnet_assemblies): New proc.
451 Run the new proc.
452 * testsuite/gentestdlls.c: New source file.
453
454 2019-06-28 Nick Clifton <nickc@redhat.com>
455
456 PR 24707
457 * objdump.c (slurp_symtab): Fail with a helpful error message if
458 the symbol table is too large. Skip this check for MMO format
459 files.
460
461 2019-06-26 Nick Clifton <nickc@redhat.com>
462
463 PR 24703
464 * bucomm.c (bfd_nonfatal): If no bfd error code has been set then
465 indicate this in the output.
466 (bfd_nonfatal_message): Likewise.
467
468 2019-06-25 Jan Beulich <jbeulich@suse.com>
469
470 * readelf.c (dump_ctf_indent_lines): Rename local variable
471 "spaces" to "blanks".
472
473 2019-06-25 Jan Beulich <jbeulich@suse.com>
474
475 * objdump.c (dump_ctf_indent_lines): Rename local variable
476 "spaces" to "blanks".
477
478 2019-06-14 Alan Modra <amodra@gmail.com>
479
480 * Makefile.in: Regenerate.
481 * aclocal.m4: Regenerate.
482 * doc/Makefile.in: Regenerate.
483
484 2019-06-12 Christos Zoulas <christos@zoulas.com>
485
486 PR 24663
487 * readelf.c (process_netbsd_elf_note): Add support for
488 NT_NETBSD_PAX.
489 (process_note): Add support for PaX notes.
490
491 2019-06-12 Christos Zoulas <christos@zoulas.com>
492
493 PR 24665
494 * readelf.c (get_netbsd_elfcore_note_type): Add support for SH
495 core notes.
496
497 2019-06-12 Christos Zoulas <christos@zoulas.com>
498
499 PR 24664
500 * readelf.c (get_netbsd_elfcore_note_type): Add support for NetBSD
501 auxv notes.
502
503 2019-06-11 Christos Zoulas <christos@zoulas.com>
504
505 PR 24662
506 * readelf.c (get_alpha_symbol_other): New function.
507 (get_symbol_other): Use for Alpha symbols.
508 (is_32bit_pcrel_reloc): Add R_VAX_PCREL32.
509
510 2019-06-11 Christos Zoulas <christos@zoulas.com>
511
512 PR 24661
513 * readelf.c (decode_arm_unwind): Ensure that the local variable
514 'addr' is always initialised.
515
516 2019-06-10 Christos Zoulas <christos@zoulas.com>
517
518 PR 24651
519 * strings.c (print_strings): Use %u to print unsigned values in
520 decimal.
521
522 2019-06-10 Christos Zoulas <christos@zoulas.com>
523
524 PR 24649
525 * arsup.c (ar_open): Use asprintf in place of xmalloc and
526 sprintf.
527
528 2019-06-03 Nick Clifton <nickc@redhat.com>
529
530 Revert:
531 2019-05-29 Nick Clifton <nickc@redhat.com>
532
533 * configure.ac (LIBCTF): Export. Set to empty for non-ELF based
534 targets.
535 (HAVE_LIBCTF): Define if libctf support is available.
536 * Makefile.am (LIBCTF): Set value to @LIBCTF@.
537 * objdump.c: Make CTF code conditional upon HAVE_LIBCTF being
538 defined.
539 * readelf.c: Likewise.
540 * configure: Regenerate.
541 * Makefile.in: Regenerate.
542 * config.in: Regenerate.
543
544 2019-05-30 Nick Alcock <nick.alcock@oracle.com>
545
546 * objdump.c (make_ctfsect): Drop cts_type, cts_flags, and
547 cts_offset.
548 * readelf.c (shdr_to_ctf_sect): Likewise.
549
550 2019-05-30 Nick Clifton <nickc@redhat.com>
551
552 PR 24627
553 * readelf.c (process_version_sections): Add 0x prefix to address
554 display. Correct indentation.
555
556 2019-05-30 Alan Modra <amodra@gmail.com>
557
558 * testsuite/lib/binutils-common.exp (supports_gnu_unique): Add
559 s12z to targets not supporting this feature.
560
561 2019-05-30 Alan Modra <amodra@gmail.com>
562
563 * testsuite/lib/binutils-common.exp (run_dump_test): Support
564 tcl procedures for xfail args.
565
566 2019-05-29 Nick Clifton <nickc@redhat.com>
567
568 * README-how-to-make-a-release: Add libctf to list of directories
569 that need updates in their ChangeLogs.
570
571 2019-05-29 Nick Clifton <nickc@redhat.com>
572
573 * configure.ac (LIBCTF): Export. Set to empty for non-ELF based
574 targets.
575 (HAVE_LIBCTF): Define if libctf support is available.
576 * Makefile.am (LIBCTF): Set value to @LIBCTF@.
577 * objdump.c: Make CTF code conditional upon HAVE_LIBCTF being
578 defined.
579 * readelf.c: Likewise.
580 * configure: Regenerate.
581 * Makefile.in: Regenerate.
582 * config.in: Regenerate.
583
584 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
585
586 * MAINTAINERS: Add myself as CTF maintainer.
587
588 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
589
590 * objdump.c (ctf-api.h): New include.
591 (dump_ctf_section_info): New variable.
592 (dump_ctf_section_name): Likewise.
593 (usage): Describe new options.
594 (enum option_values): Add OPTION_CTF and OPTION_CTF_PARENT.
595 (main): Use them to add --ctf and --ctf-parent.
596 (read_section_stabs): Add new parameter, entsize_ptr.
597 (find_stabs_section): Adjust accordingly.
598 (make_ctfsect): New.
599 (dump_ctf_indent_lines): New.
600 (dump_ctf_archive_member): New.
601 (dump_ctf): New.
602 (dump_bfd): Call it. Free resources afterwards.
603 * readelf.c (ctf-api.h): New include.
604 (CTF_DUMP): New.
605 (static bfd_boolean do_ctf): Likewise.
606 (dump_ctf_parent_name): Likewise.
607 (dump_ctf_symtab_name): Likewise.
608 (dump_ctf_strtab_name): Likewise.
609 (OPTION_CTF_DUMP): Likewise.
610 (OPTION_CTF_PARENT): Likewise.
611 (OPTION_CTF_SYMBOLS): Likewise.
612 (OPTION_CTF_STRINGS): Likewise.
613 (options): Add them.
614 (usage): Likewise.
615 (parse_args): Handle the new options, requesting CTF_DUMP.
616 (process_section_contents): Handle CTF_DUMP.
617 (shdr_to_ctf_sect): New.
618 (dump_ctf_indent_lines): New.
619 (dump_section_as_ctf): New.
620 (main): Free resources.
621 * Makefile.am (LIBCTF): New variable.
622 (objdump_DEPENDENCIES): Use it.
623 (readelf_DEPENDENCIES): Likewise.
624 (objdump_LDADD): Likewise.
625 (readelf_LDADD): Likewise.
626 * aclocal.m4: Regenerated.
627 * Makefile.in: Likewise.
628
629 * doc/binutils.texi (objdump): Document the new options.
630 (readelf): Likewise.
631 * doc/ctf.options.texi: New.
632 * doc/Makefile.in: Regenerated.
633 * NEWS: Mention the new feature.
634
635 2019-05-27 Alan Modra <amodra@gmail.com>
636
637 * readelf.c (process_section_groups): Continue processing groups
638 when sh_entsize exceeds group size.
639
640 2019-05-24 Szabolcs Nagy <szabolcs.nagy@arm.com>
641
642 * readelf.c (get_aarch64_dynamic_type): Handle DT_AARCH64_VARIANT_PCS.
643 (get_aarch64_symbol_other): New, handles STO_AARCH64_VARIANT_PCS.
644 (get_symbol_other): Call get_aarch64_symbol_other.
645
646 2019-05-24 Alan Modra <amodra@gmail.com>
647
648 * objdump.c (disassemble_bytes): Set WIDE_OUTPUT in flags.
649
650 2019-05-23 Jose E. Marchesi <jose.marchesi@oracle.com>
651
652 * MAINTAINERS: Add myself as the maintainer for BPF.
653
654 2019-05-23 Jose E. Marchesi <jose.marchesi@oracle.com>
655
656 * readelf.c: Include elf/bpf.h.
657 (guess_is_rela): Hanle EM_BPF.
658 (dump_relocations): Likewise.
659 (is_32bit_abs_reloc): Likewise.
660 * testsuite/binutils-all/nm.exp: Add bpf-*-* to the list of
661 ELF targets.
662
663 2019-05-21 Tamar Christina <tamar.christina@arm.com>
664
665 * dwarf.c (dwarf_regnames_aarch64): Add SVE registers.
666 * testsuite/binutils-all/aarch64/sve-dwarf-registers.d: New test.
667 * testsuite/binutils-all/aarch64/sve-dwarf-registers.s: New test.
668
669 2019-05-20 Faraz Shahbazker <fshahbazker@wavecomp.com>
670
671 PR 14798
672 * testsuite/binutils-all/readelf.ss-mips: Update reference output.
673 * testsuite/binutils-all/readelf.ss-tmips: Likewise.
674
675 2019-05-20 Nick Clifton <nickc@redhat.com>
676
677 * po/ca.po: Updated Catalan translation.
678
679 2019-05-16 Andre Vieira <andre.simoesdiasvieira@arm.com>
680
681 * NEWS: Mention Armv8.1-M Mainline and MVE.
682
683 2019-05-16 Andre Vieira <andre.simoesdiasvieira@arm.com>
684
685 * readelf.c (arm_attr_tag_MVE_arch): New array for Tag_MVE_arch values.
686 (arm_attr_public_tag arm_attr_public_tags): Add case for Tag_MVE_arch.
687
688 2019-05-14 Jamey Hicks <jamey.hicks@gmail.com>
689
690 PR 19921
691 * objcopy.c: Add new option --verilog-data-width. Use it to set
692 the value of VerilogDataWidth.
693 * doc/binutils.texi: Document the new option.
694 * testsuite/binutils-all/objcopy.exp: Run tests of new option.
695 * testsuite/binutils-all/verilog-1.hex: New file.
696 * testsuite/binutils-all/verilog-2.hex: New file.
697 * testsuite/binutils-all/verilog-4.hex: New file.
698 * testsuite/binutils-all/verilog-8.hex: New file.
699 * NEWS: Mention the new feature.
700
701 2019-05-10 Alan Modra <amodra@gmail.com>
702
703 * testsuite/binutils-all/objdump.exp (test_objdump_disas_limited),
704 (test_objdump_content_limited): Add text arg, use in place of .text.
705 (bintest_signed.o): Call get_standard_section_names for name of
706 text section.
707
708 2019-05-08 Faraz Shahbazker <fshahbazker@wavecomp.com>
709
710 * objdump.c (sign_extend_address): New function.
711 (dump_bfd): Sign-extend user-specified start/stop addresses
712 for targets that need it.
713 * testsuite/binutils-all/objdump.exp: Add tests for objdump
714 with start and stop addresses in higher address ranges.
715
716 2019-05-01 Matthew Malcomson <matthew.malcomson@arm.com>
717
718 * testsuite/binutils-all/objdump.exp: Correct executable
719 spelling.
720 * testsuite/binutils-all/compress.exp: Likewise.
721
722 2019-05-01 Nick Clifton <nickc@redhat.com>
723
724 PR 24507
725 * nm.c: (print_format): New variable.
726 (value_format_32bit, value_format_64bit): Delete.
727 (set_print_radix): Remove code to alter value_format strings.
728 (set_output_format): Record chosen format in print_format.
729 (get_print_format): New function - constructs a printf formatting
730 string according to the requirements of size, radix, and output
731 format.
732 (print_value): Use get_print_format.
733 * testsuite/binutils-all/nm.exp: Add tests of "nm --format=posix"
734 and "nm -t d".
735
736 2019-04-30 Alan Modra <amodra@gmail.com>
737
738 * wrstabs.c (stab_start_class_type): Add assert to work around
739 gcc9 warning. Tidy.
740
741 2019-04-24 Nick Clifton <nickc@redhat.com>
742
743 * objcopy.c (strip_main): Do not enable note merging by default if
744 just stripping debug or dwo information.
745 * doc/binutils.texi (strip): Update documentation.
746
747 2019-04-23 Nick Clifton <nickc@redhat.com>
748
749 * README-how-to-make-a-release: Add note to update the symbolic
750 link from "docs" to "docs-2.x" on the sourceware website.
751
752 2019-04-16 Alan Modra <amodra@gmail.com>
753
754 * testsuite/binutils-all/copy-2.d: Don't run for ns32k-*-*.
755 * testsuite/binutils-all/copy-3.d: Likewise.
756
757 2019-04-15 Thomas Preud'homme <thomas.preudhomme@arm.com>
758
759 * readelf.c (arm_attr_tag_CPU_arch): Add entry for Armv8.1-M Mainline.
760
761 2019-04-08 H.J. Lu <hongjiu.lu@intel.com>
762
763 * readelf.c (decode_x86_isa): Handle
764 GNU_PROPERTY_X86_ISA_1_AVX512_BF16.
765 * testsuite/binutils-all/i386/pr21231b.d: Updated.
766 * testsuite/binutils-all/x86-64/pr21231b.d: Likewise.
767
768 2019-04-08 H.J. Lu <hongjiu.lu@intel.com>
769
770 * testsuite/binutils-all/nm.exp: Count i386-moss as ELF.
771
772 2019-03-26 Tamar Christina <tamar.christina@arm.com>
773
774 * testsuite/binutils-all/aarch64/in-order-all.d: Update.
775 * testsuite/binutils-all/aarch64/in-order.d: Likewise.
776 * testsuite/binutils-all/aarch64/out-of-order-all.d: Likewise.
777 * testsuite/binutils-all/aarch64/out-of-order.d: Likewise.
778 * testsuite/binutils-all/aarch64/out-of-order.s: Likewise.
779 * testsuite/binutils-all/arm/in-order-all.d: Likewise.
780 * testsuite/binutils-all/arm/in-order.d: Likewise.
781 * testsuite/binutils-all/arm/out-of-order-all.d: Likewise.
782 * testsuite/binutils-all/arm/out-of-order.d: Likewise.
783 * testsuite/binutils-all/arm/out-of-order.s: Likewise.
784
785 2019-03-26 Nick Clifton <nickc@redhat.com>
786
787 * MAINTAINERS: Take over Dave Brolley's maintainerships for FR30,
788 FRV and MEP.
789
790 2019-03-26 Alan Modra <amodra@gmail.com>
791
792 * objdump.c (dump_relocs_in_section): Warning fix.
793
794 2019-03-25 Tamar Christina <tamar.christina@arm.com>
795
796 * testsuite/binutils-all/arm/in-order-all.d: New test.
797 * testsuite/binutils-all/arm/in-order.d: New test.
798 * testsuite/binutils-all/arm/objdump.exp: Support .d tests.
799 * testsuite/binutils-all/arm/out-of-order-all.d: New test.
800 * testsuite/binutils-all/arm/out-of-order.T: New test.
801 * testsuite/binutils-all/arm/out-of-order.d: New test.
802 * testsuite/binutils-all/arm/out-of-order.s: New test.
803
804
805 2019-03-25 Tamar Christina <tamar.christina@arm.com>
806
807 * testsuite/binutils-all/aarch64/in-order-all.d: New test.
808 * testsuite/binutils-all/aarch64/out-of-order-all.d: New test.
809 * testsuite/binutils-all/aarch64/out-of-order.d:
810
811 2019-03-25 Tamar Christina <tamar.christina@arm.com>
812
813 * testsuite/binutils-all/aarch64/in-order.d: New test.
814 * testsuite/binutils-all/aarch64/out-of-order.d: Disassemble data as
815 well.
816
817 2019-03-25 Tamar Christina <tamar.christina@arm.com>
818
819 * objdump.c (disassemble_bytes): Pass stop_offset.
820 * testsuite/binutils-all/aarch64/out-of-order.T: New test.
821 * testsuite/binutils-all/aarch64/out-of-order.d: New test.
822 * testsuite/binutils-all/aarch64/out-of-order.s: New test.
823
824 2019-03-19 Nick Clifton <nickc@redhat.com>
825
826 PR 24360
827 * objdump.c (load_specific_debug_section): Check that the amount
828 of memory to be allocated matches the size of the section.
829
830 2019-03-13 Sudakshina Das <sudi.das@arm.com>
831
832 * readelf.c (get_aarch64_dynamic_type): Add case for
833 DT_AARCH64_PAC_PLT.
834 (dynamic_section_aarch64_val): Likewise.
835
836 2019-03-13 Sudakshina Das <sudi.das@arm.com>
837 Szabolcs Nagy <szabolcs.nagy@arm.com>
838
839 * readelf.c (get_aarch64_dynamic_type): New.
840 (get_dynamic_type): Use above for EM_AARCH64.
841 (dynamic_section_aarch64_val): New.
842 (process_dynamic_section): Use above for EM_AARCH64.
843
844 2019-03-13 Sudakshina Das <sudi.das@arm.com>
845
846 * readelf.c (decode_aarch64_feature_1_and): New.
847 (print_gnu_property_note): Add case for AArch64 gnu notes.
848
849 2019-03-12 Alan Modra <amodra@gmail.com>
850
851 * objdump.c (load_specific_debug_section): Don't compare section
852 size against file size.
853 (dump_relocs_in_section): Don't compare reloc size against file size.
854 Print "failed to read relocs" on bfd_get_reloc_upper_bound error.
855
856 2019-03-05 Nick Clifton <nickc@redhat.com>
857
858 PR 24295
859 * doc/binutils.texi (ar cmdline): Fix spelling mistake.
860
861 2019-03-05 Nick Clifton <nickc@redhat.com>
862
863 * po/sv.po: Updated Swedish translation.
864
865 2019-03-05 Matthew Malcomson <matthew.malcomson@arm.com>
866
867 PR 24287
868 * testsuite/lib/binutils-common.exp (run_dump_test): Replace a use
869 of "lmap" with a "foreach" loop.
870
871 2019-03-04 Nick Clifton <nickc@redhat.com>
872
873 PR 24281
874 * objcopy.c (copy_archive): Do not copy thin archives.
875
876 2019-02-27 Matthew Malcomson <matthew.malcomson@arm.com>
877
878 * testsuite/lib/binutils-common.exp: Allow multiple "as" lines.
879
880 2019-02-25 Nick Clifton <nickc@redhat.com>
881
882 * objdump.c (sym_ok): New function.
883 (find_symbol_for_address): Use new function.
884 (disassemble_section): Compare sections by name, not pointer.
885 (dump_dwarf): Move code to initialise byte_get pointer and iterate
886 over separate debug files from here to ...
887 (dump_bfd): ... here. Add parameter indicating that a separate
888 debug info file is being dumped. For main file, pull in the
889 symbol tables from all separate debug info files.
890 (display_object): Update call to dump_bfd.
891 * doc/binutils.texi: Document extened behaviour of the
892 --dwarf=follow-links option.
893 * NEWS: Mention this new feature.
894 * testsuite/binutils-all/objdump.WK2: Update expected output.
895 * testsuite/binutils-all/objdump.exp (test_follow_debuglink): Add
896 options and dump file parameters.
897 Add extra test.
898 * testsuite/binutils-all/objdump.WK3: New file.
899 * testsuite/binutils-all/readelf.exp: Change expected output for
900 readelf -wKis test.
901 * testsuite/binutils-all/readelf.wKis: New file.
902
903 2019-02-22 Nick Clifton <nickc@redhat.com>
904
905 PR 23843
906 * dwarf.h (struct separate_info): New structure for containing
907 information on separate debug info files.
908 * dwarf.c (struct dwo_info): New structure for containing dwo
909 links.
910 (first_dwo_info): Chain of dwo_info structures.
911 (first_separate_file): Chain of separate_info structures.
912 (separate_debug_file, separate_debug_filename): Delete.
913 (fetch_alt_indirect_string): Scan all separate debug info files
914 for the requested string.
915 (add_dwo_info): New function.
916 (add_dwo_name): New function.
917 (add_dwo_dir): New function.
918 (add_dwo_id: New function.
919 (free_dwo_info): New function.
920 (read_and_display_attr_value): Store DWO data using the new
921 functions.
922 (load_debug_section_with_follow): If necessary, scan the list of
923 separate debug info files for the requested section.
924 (add_separate_debug_file): New function.
925 (load_separate_debug_info): Call add_separate_debug_file to store
926 the information on the newly loaded file.
927 (load_dwo_file): Likewise.
928 (load_separate_debif_file): Rename to load_separate_debug_files.
929 Change return type to boolean. If following links then attempt to
930 load all separate debug info files, not just the first one.
931 (free_debug_memory): Release memory in dwo_info and separate_info
932 chains.
933 * objdump.c (dump_dwarf): Iterate over all loaded debg info files.
934 * readelf.c (process_object): Likewise.
935 * doc/debug.options.texi: Update descriptions of links and
936 follow-links options.
937 * testsuite/binutils-all/objdump.WK2: Update expected output.
938 * testsuite/binutils-all/readelf.k2: Likewise.
939 * NEWS: Announce the new feature.
940
941 2019-02-21 Nick Clifton <nickc@redhat.com>
942
943 PR 24247
944 * unwind-ia64.c: Include sysdep.h.
945 (unw_decode_x1): Check current pointer against end pointer before
946 accessing memory.
947 (unw_decode_x2): Likewise.
948 (unw_decode_x3): Likewise.
949 (unw_decode_x4): Likewise.
950 (unw_decode_r2): Likewise.
951 (unw_decode_p2_p5): Likewise.
952 (unw_decode_p7_p10): Likewise.
953 (unw_decode): Likewise.
954
955 2019-02-20 Nick Clifton <nickc@redhat.com>
956
957 PR 24246
958 * readelf.c (print_stapsdt_note): Harden against corrupt notes.
959
960 PR 24244
961 * unwind-ia64.c (unw_decode_uleb128): Add end parameter, use it to
962 prevent walking off the end of the buffer.
963 (unw_decode_x1): Add end paramter, pass it to unw_decode_uleb128.
964 (unw_decode_x2): Likewise.
965 (unw_decode_x3): Likewise.
966 (unw_decode_x4): Likewise.
967 (unw_decode_r2): Pass the end parameter to unw_decode_uleb128.
968 (unw_decode_r3): Likewise.
969 (unw_decode_p7_p10): Likewise.
970 (unw_decode_b2): Likewise.
971 (unw_decode_b3_x4): Likewise.
972
973 PR 24243
974 * readelf.c (process_mips_specific): Check for an options section
975 that is too small to even contain a single option.
976
977 PR 24242
978 * readelf.c (print_ia64_vms_note): Harden against corrupt notes.
979
980 2019-02-20 Alan Modra <amodra@gmail.com>
981
982 PR 24132
983 PR 24138
984 * readelf.c (get_data): Avoid possibility of overflow when
985 checking for a read that may extend past end of file.
986 (process_program_headers): Likewise.
987
988 2019-02-20 Alan Modra <amodra@gmail.com>
989
990 PR 24233
991 * objdump.c (dump_bfd_private_header): Print warning if
992 bfd_print_private_bfd_data returns false.
993
994 2019-02-12 Nick Clifton <nickc@redhat.com>
995
996 PR 23440
997 * README-how-to-make-a-release: Use git clean to delete spurious
998 files from the local source repository.
999
1000 2019-02-08 Andrew Burgess <andrew.burgess@embecosm.com>
1001
1002 * size.c (berkeley_format): Delete.
1003 (enum output_format): New enum.
1004 (selected_output_format): New variable.
1005 (usage): Update to mention GNU format.
1006 (main): Update to extract options, and select format as needed.
1007 Handle GNU format where needed.
1008 (berkeley_sum): Renamed to...
1009 (berkeley_or_gnu_sum): ...this, and updated to handle both formats.
1010 (berkeley_format): Renamed to...
1011 (berkeley_or_gnu_format): ...this, and updated to handle both
1012 formats.
1013 (print_sizes): Handle GNU format.
1014 * doc/binutils.texi (size): Document new GNU format.
1015 * testsuite/binutils-all/size.exp: Add test of extended
1016 functionality.
1017 * NEWS: Mention new functionality.
1018
1019 2019-02-08 Andrew Burgess <andrew.burgess@embecosm.com>
1020
1021 * doc/binutils.texi (size): Update example output for Berkeley
1022 format output.
1023
1024 2019-02-07 Nick Clifton <nickc@redhat.com>
1025
1026 * README-how-to-make-a-release: Add a note about updating the
1027 obsolete targets in the bfd/config.bfd file.
1028
1029 2019-02-04 Nick Clifton <nickc@redhat.com>
1030
1031 * README-how-to-make-a-release: Add more notes on making a release.
1032
1033 2019-01-25 Nick Clifton <nickc@redhat.com>
1034
1035 PR 24131
1036 * readelf.c (process_notes_at): Prevent an illegal memory access
1037 when the note's namesize is zero.
1038 (decode_tic6x_unwind_bytecode): Add code to handle the case where
1039 no registers are specified in a frame pop instruction.
1040
1041 2019-01-25 Nick Clifton <nickc@redhat.com>
1042
1043 * po/bg.po: Updated Bulgarian translation.
1044
1045 2019-01-23 Nick Clifton <nickc@redhat.com>
1046
1047 * po/fr.po: Updated French translation.
1048 * po/pt.po: Updated Portuguese translation.
1049
1050 2019-01-21 Nick Clifton <nickc@redhat.com>
1051
1052 * po/uk.po: Updated Ukranian translation.
1053
1054 2019-01-19 Nick Clifton <nickc@redhat.com>
1055
1056 * configure: Regenerate.
1057 * binutils/po/binutils.pot.
1058
1059 * README-how-to-make-a-release: Update description on how to make
1060 a branch.
1061
1062 2018-06-24 Nick Clifton <nickc@redhat.com>
1063
1064 2.32 branch created.
1065
1066 2019-01-17 Nick Clifton <nickc@redhat.com>
1067
1068 * objdump.c (disassemble_section): When disassembling from a
1069 symbol only stop at the next symbol if the original symbol was not
1070 a function symbol. Otherwise continue disassembling until a new
1071 function is reached.
1072 * testsuite/binutils-all/objdump.exp: Add tests of extended
1073 functionality.
1074 * testsuite/binutils-all/disasm.s: New test source file.
1075
1076 2019-01-16 Kito Cheng <kito@andestech.com>
1077 Nelson Chu <nelson@andestech.com>
1078
1079 * readelf.c (get_riscv_section_type_name): New function.
1080 (get_section_type_name): Add handler for RISC-V.
1081 (riscv_attr_tag_t): Declare.
1082 (riscv_attr_tag): New.
1083 (display_riscv_attribute): New function.
1084 (process_attributes): Add handler for RISC-V.
1085 * testsuite/binutils-all/strip-3.d: Remove .riscv.attribute
1086 section.
1087
1088 2019-01-10 Nick Clifton <nickc@redhat.com>
1089
1090 PR 23963
1091 * objdump.c (sanitize_string): New function. Removes control
1092 characters from symbol names.
1093 (dump_section_header): Use new function.
1094 (objdump_print_symname): Likewise.
1095 (objdump_print_addr_with_sym): Likewise.
1096 (show_line): Likewise.
1097 (disassemble_bytes): Likewise.
1098 (disassemble_section): Likewise.
1099 (load_specific_debug_section): Likewise.
1100 (read_section_stabs): Likewise.
1101 (print_section_stabs): Likewise.
1102 (dump_section): Likewise.
1103 (dump_reloc_set): Likewise.
1104 (dump_relocs_in_section): Likewise.
1105 (dump_bfd): Likewise.
1106 (display_any_bfd): Likewise.
1107
1108 2019-01-09 Nick Clifton <nickc@redhat.com>
1109
1110 PR 24049
1111 * readelf.c (process_archive): Use arch.file_name in error
1112 messages until the qualified name is available.
1113
1114 2019-01-09 Andrew Paprocki <andrew@ishiboo.com>
1115
1116 * configure: Regenerate.
1117
1118 2019-01-09 Alan Modra <amodra@gmail.com>
1119
1120 * testsuite/binutils-all/cxxfilt.exp: Pass --no-strip-underscores
1121 unconditionally to tests needing the option rather than via a
1122 list of targets.
1123
1124 2019-01-08 Nick Clifton <nickc@redhat.com>
1125
1126 PR 24044
1127 * cxxfilt.c (hp_symbol_characters): Delete.
1128 (main): Remove depcreated demangling styles.
1129 * stabs.c (parse_stab_argtypes): Remove support for old gnu v2
1130 demangling opnames.
1131 * testsuite/binutils-all/cxxfilt.exp: Use the
1132 --no-strip-underscore option for targets that do prefix their
1133 symbols with underscores.
1134 Update tests to eliminate those that use gnu v2 encoding.
1135
1136 2019-01-08 Tamar Christina <tamar.christina@arm.com>
1137
1138 PR 24065
1139 * testsuite/binutils-all/copy-6.d: New test.
1140 * testsuite/binutils-all/objcopy.exp: Use it.
1141
1142 2019-01-08 Alan Modra <amodra@gmail.com>
1143
1144 * testsuite/lib/binutils-common.exp (run_dump_test): Don't prepend
1145 $srcdir/$subdir to source file name if it starts with "./".
1146
1147 2019-01-05 Yoshinori Sato <ysato@users.sourceforge.jp>
1148
1149 * readelf.c (get_machine_flags): Add RXv3 output.
1150
1151 2019-01-04 Nick Clifton <nickc@redhat.com>
1152
1153 PR 24005
1154 * objdump.c (load_specific_debug_section): Check for integer
1155 overflow before attempting to allocate contents.
1156
1157 2019-01-04 Nick Clifton <nickc@redhat.com>
1158
1159 PR 24001
1160 * objcopy.c (copy_object): Free dhandle after writing out the
1161 debug information.
1162 * objdump.c (dump_bfd): Free dhandle after printing out the debug
1163 information.
1164
1165
1166 2019-01-01 Alan Modra <amodra@gmail.com>
1167
1168 Update year range in copyright notice of all files.
1169
1170 For older changes see ChangeLog-2018
1171 \f
1172 Copyright (C) 2019 Free Software Foundation, Inc.
1173
1174 Copying and distribution of this file, with or without modification,
1175 are permitted in any medium without royalty provided the copyright
1176 notice and this notice are preserved.
1177
1178 Local Variables:
1179 mode: change-log
1180 left-margin: 8
1181 fill-column: 74
1182 version-control: never
1183 End: