]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blob - binutils/ChangeLog
Add support to readelf and objdump for following links to separate debug information...
[thirdparty/binutils-gdb.git] / binutils / ChangeLog
1 2017-11-15 Nick Clifton <nickc@redhat.com>
2
3 PR 15152
4 * dwarf.h (enum dwarf_section_display_enum): Add gnu_debuglink,
5 gnu_debugaltlink and separate_debug_str.
6 (struct dwarf_section): Add filename field.
7 Add prototypes for load_separate_debug_file, close_debug_file and
8 open_debug_file.
9 * dwarf.c (do_debug_links): New.
10 (do_follow_links): New.
11 (separate_debug_file, separate_debug_filename): New.
12 (fetch_alt_indirect_string): New function. Retrieves a string
13 from the debug string table in the separate debug info file.
14 (read_and_display_attr_value): Use it with DW_FORM_GNU_strp_alt.
15 (load_debug_section_with_follow): New function. Like
16 load_debug_section, but if the first attempt fails, then tries
17 again in the separate debug info file.
18 (introduce): New function.
19 (process_debug_info): Use load_debug_section_with_follow and
20 introduce.
21 (load_debug_info): Likewise.
22 (display_debug_lines_raw): Likewise.
23 (display_debug_lines_decoded): Likewise.
24 (display_debug_macinfo): Likewise.
25 (display_debug_macro): Likewise.
26 (display_debug_abbrev): Likewise.
27 (display_debug_loc): Likewise.
28 (display_debug_str): Likewise.
29 (display_debug_aranges): Likewise.
30 (display_debug_addr); Likewise.
31 (display_debug_frames): Likewise.
32 (display_gdb_index): Likewise.
33 (process_cu_tu_index): Likewise.
34 (load_cu_tu_indexes): Likewise.
35 (display_debug_links): New function. Displays the contents of a
36 .gnu_debuglink or .gnu_debugaltlink section.
37 (calc_gnu_debuglink_ctc32):New function. Calculates a CRC32
38 value.
39 (check_gnu_debuglink): New function. Checks the CRC of a
40 potential separate debug info file.
41 (parse_gnu_debuglink): New function. Reads a CRC value out of a
42 .gnu_debuglink section.
43 (check_gnu_debugaltlink): New function.
44 (parse_gnu_debugaltlink): New function. Reads the build-id value
45 out of a .gnu_debugaltlink section.
46 (load_separate_debug_info): New function. Finds and loads a
47 separate debug info file.
48 (load_separate_debug_file): New function. Attempts to find and
49 follow a link to a separate debug info file.
50 (free_debug_memory): Free the separate debug info file
51 information.
52 (opts_table): Add "follow-links" and "links".
53 (dwarf_select_sections_by_letters): Add "k" and "K".
54 (debug_displays): Reformat. Add .gnu-debuglink and
55 .gnu_debugaltlink.
56 Add an extra entry for .debug_str in a separate debug info file.
57 * doc/binutils.texi: Move description of debug dump features
58 common to both readelf and objdump into...
59 * objdump.c (usage): Add -Wk and -WK.
60 (load_specific_debug_section): Initialise the filename field in
61 the dwarf_section structure.
62 (close_debug_file): New function.
63 (open_debug_file): New function.
64 (dump_dwarf): Load and dump the separate debug info sections.
65 * readelf.c (struct filedata): New structure. Contains various
66 variables that used to be global:
67 (current_file_size, string_table, string_table_length, elf_header)
68 (section_headers, program_headers, dump_sects, num_dump_sects):
69 Move into filedata structure.
70 (cmdline): New global variable. Contains list of sections to dump
71 by number, as specified on the command line.
72 Add filedata parameter to most functions.
73 (load_debug_section): Load the string table if it has not already
74 been retrieved.
75 (close_file): New function.
76 (close_debug_file): New function.
77 (open_file): New function.
78 (open_debug_file): New function.
79 (process_object): Process sections in any separate debug info files.
80 * doc/debug.options.texi: New file. Add description of =links and
81 =follow-links options.
82 * NEWS: Mention the new feature.
83 * elfcomm.c: Have the byte get functions take a const pointer.
84 * elfcomm.h: Update prototypes.
85 * testsuite/binutils-all/dw5.W: Update expected output.
86 * testsuite/binutils-all/objdump.WL: Update expected output.
87 * testsuite/binutils-all/objdump.exp: Add test of -WK and -Wk.
88 * testsuite/binutils-all/readelf.exp: Add test of -wK and -wk.
89 * testsuite/binutils-all/readelf.k: New file.
90 * testsuite/binutils-all/objdump.Wk: New file.
91 * testsuite/binutils-all/objdump.WK2: New file.
92 * testsuite/binutils-all/linkdebug.s: New file.
93 * testsuite/binutils-all/debuglink.s: New file.
94
95 2017-11-10 Jim Wilson <jimw@sifive.com>
96
97 * testsuite/binutils-all/objdump.exp: Expect the debug_ranges test to
98 pass.
99
100 2017-11-07 Jim Wilson <jimw@sifive.com>
101
102 * MAINTAINERS (RISC-V): Fix typo in my email address.
103
104 2017-11-07 Palmer Dabbelt <palmer@sifive.com>
105
106 * MAINTAINERS (RISC-V): Add Jim Wilson as a maintainer.
107 Clean up Andrew's entry (remove trailing space, add tabs).
108 Change Palmer's email address, and clean up entry (add tabs).
109
110 2017-11-07 Alan Modra <amodra@gmail.com>
111
112 * dwarf.c (read_uleb128): Properly pluralize messages.
113 (display_debug_lines_raw, display_debug_loc): Likewise.
114 (display_debug_names, process_cu_tu_index): Likewise.
115 * od-macho.c (dump_code_signature_superblob): Likewise.
116 * readelf.c (process_program_headers): Likewise.
117 (process_section_header, process_relocs): Likewise.
118 (hppa_process_unwind, arm_process_unwind): Likewise.
119 (process_dynamic_section, process_version_sections): Likewise.
120 (process_symbol_table, process_syminfo): Likewise.
121 (apply_relocations, process_mips_specific): Likewise.
122 (process_gnu_liblist, process_notes_at): Likewise.
123 (process_archive): Likewise.
124 * testsuite/binutils-all/dw2-1.W,
125 * testsuite/binutils-all/dw2-3.W,
126 * testsuite/binutils-all/dw2-3gabi.W,
127 * testsuite/binutils-all/dw5.S,
128 * testsuite/binutils-all/dw5.W,
129 * testsuite/binutils-all/i386/compressed-1a.d,
130 * testsuite/binutils-all/libdw2-compressedgabi.out,
131 * testsuite/binutils-all/objdump.W,
132 * testsuite/binutils-all/readelf.r,
133 * testsuite/binutils-all/readelf.r-64,
134 * testsuite/binutils-all/x86-64/compressed-1a.d: Update
135 for pluralization fixes.
136
137 2017-11-07 Alan Modra <amodra@gmail.com>
138
139 * sysdep.h (textdomain, bindtextdomain): Use safer "do nothing".
140 (ngettext, dngettext, dcngettext): Define when !ENABLE_NLS.
141
142 2017-11-03 Claudiu Zissulescu <claziss@synopsys.com>
143
144 * doc/binutils.texi (ARC): Update disassembler options.
145 * testsuite/binutils-all/arc/hexprint.s: New file.
146 * testsuite/binutils-all/arc/objdump.exp: Test hex printing
147 feature.
148
149 2017-11-03 Mingi Cho <mgcho.minic@gmail.com>
150 Nick Clifton <nickc@redhat.com>
151
152 PR 22386
153 * dwarf.c (read_cie): Use bfd_size_type for
154 augmentation_data_len.
155 (display_augmentation_data): New function.
156 (display_debug_frames): Use it.
157 Check for integer overflow when testing augmentation_data_len.
158
159 2017-11-02 Mingi Cho <mgcho.minic@gmail.com>
160
161 PR 22384
162 * readelf.c (print_gnu_property_note): Improve overflow checks so
163 that they will work on a 32-bit host.
164
165 2017-11-01 James Bowman <james.bowman@ftdichip.com>
166
167 * readelf.c (is_16bit_abs_reloc): Add entry for FT32.
168
169 2017-10-31 Nick Clifton <nickc@redhat.com>
170
171 * readelf.c (process_relocs): Tell users if no static relocs were
172 found, but if they had added --use-dynamic to the command line
173 then relocs would have been displayed.
174
175 2017-10-28 Alan Modra <amodra@gmail.com>
176
177 PR 22361
178 * readelf.c (process_archive_index_and_symbols): Ensure ar_size
179 field is zero terminated for strtoul.
180 (setup_archive, get_archive_member_name): Likewise.
181
182 2017-10-27 Simon Marchi <simon.marchi@ericsson.com>
183
184 * dwarf.c (struct Frame_Chunk) <cfa_reg>: Change type to
185 unsigned int.
186 (display_debug_frames): Read CFA reg as an unsigned number.
187
188 2017-10-25 Alan Modra <amodra@gmail.com>
189
190 * nm.c (filter_symbols): Match "__gnu_lto_slim" optionally prefixed
191 with "_".
192
193 2017-10-18 Eric Botcazou <ebotcazou@adacore.com>
194
195 * MAINTAINERS: Add myself as Visium maintainer.
196
197 2017-10-18 Nick Clifton <nickc@redhat.com>
198
199 * README-how-to-make-a-release: A note about checking file and
200 directory permissions.
201
202 * MAINTAINERS: Move Svein Seldal to Past Maintainers section.
203
204 2017-10-18 Alan Modra <amodra@gmail.com>
205
206 PR 22303
207 * readelf.c (print_core_note): Ensure "count" sanity check
208 calculation doesn't overflow.
209 (process_notes_at): Perform note namesz and descsz checks
210 using unsigned comparisons against data remaining. Catch
211 alignment overflow of namesz and descsz too. Don't allocate a
212 temp for terminating "name" when there is space available
213 before descdata.
214
215 2017-10-17 Tom Tromey <tom@tromey.com>
216
217 * MAINTAINERS: Add myself as dwarf-mode.el maintainer.
218
219 2017-10-11 Peeter Joot <peeter.joot@lzlabs.com>
220 Nick Clifton <nickc@redhat.com>
221
222 * dwarf.c (read_and_display_attr_value): Handle DW_AT_endianity,
223 DW_END_default, DW_END_big, DW_END_little, DW_ATE_UCS,
224 DW_ATE_ASCII, DW_CC_pass_by_reference, DW_CC_pass_by_value,
225 DW_CC_GNU_renesas_sh, DW_CC_GNU_borland_fastcall_i386,
226 DW_AT_decimal_sign, DW_AT_defaulted, DW_AT_discr_list.
227 (get_TAG_name): Report user generated tag values.
228 * testsuite/binutils-all/dwarf-attributes.S: New test.
229 * testsuite/binutils-all/dwarf-attributes.W. Expected output from
230 readelf.
231 * testsuite/binutils-all/readelf.exp: Run the new test.
232
233 2017-10-10 Tom Tromey <tom@tromey.com>
234
235 * dwarf-mode.el: Bump to version 1.4.
236
237 2017-10-10 Tom Tromey <tom@tromey.com>
238
239 * dwarf-mode.el (dwarf--process, dwarf--deletion-region): New
240 defvar.
241 (dwarf--check-running, dwarf--sentinel, dwarf--invoke)
242 (dwarf--filter): New functions.
243 (dwarf-do-insert-substructure, dwarf-do-refresh): Call
244 dwarf--check-running, dwarf--invoke.
245 (dwarf-browse): Initialize new variables.
246
247 2017-10-10 Tom Tromey <tom@tromey.com>
248
249 * dwarf-mode.el: Set lexical-binding.
250
251 2017-10-10 Tom Tromey <tom@tromey.com>
252
253 * dwarf-mode.el (dwarf-mode-map): New defvar.
254
255 2017-10-10 Tom Tromey <tromey@sourceware.org>
256
257 PR 22249
258 * dwarf.c (process_debug_info): Skip any comp unit that ends
259 before dwarf_start_die.
260
261 2017-10-06 Alan Modra <amodra@gmail.com>
262
263 * dwarf.c (process_debug_info): Consolidate header length checks.
264 (display_debug_pubnames_worker): Use "start" to read header.
265 Properly check header length and report errors earlier.
266 Simplify loop printing pubnames.
267 (get_line_filename_and_dirname): Catch small negative "length"
268 values.
269 (display_debug_aranges): Likewise. Report header errors
270 earlier using standardized message.
271 (display_debug_names): Likewise.
272
273 2017-10-05 Joseph Myers <joseph@codesourcery.com>
274
275 * readelf.c (decode_arm_unwind): Initialize res to TRUE.
276
277 2017-10-05 Nick Clifton <nickc@redhat.com>
278
279 PR 22260
280 * objcopy.c (strip_main): Add 'M' character to short options list
281 when calling getopt_long.
282
283 2017-10-05 Nick Clifton <nickc@redhat.com>
284
285 PR 22262
286 * readelf.c (dump_relocations): Do not truncate reloc names when
287 displaying output in wide mode.
288
289 2017-10-05 Nick Clifton <nickc@redhat.com>
290
291 * README-how-to-make-a-release: Merge steps 3, 4 and 5, and insert
292 the git tag operation at the correct location.
293
294 2017-10-05 Alan Modra <amodra@gmail.com>
295
296 PR 22239
297 * dwarf.c (read_cie): Don't compare "start" and "end" pointers
298 after adding a possibly wild length to "start", compare the length
299 to the difference of the pointers instead. Remove now redundant
300 "negative" length test.
301
302 2017-10-05 Tristan Gingold <tgingold@free.fr>
303
304 * MAINTAINERS: Update email address. Redirect release maintainer
305 to global maitainers.
306
307 2017-10-01 Alan Modra <amodra@gmail.com>
308
309 PR 22232
310 PR 22230
311 * objdump.c (load_specific_debug_section): Introduce a temp to
312 stop bfd_get_full_section_contents NULLing out section->start.
313
314 2017-10-01 Alan Modra <amodra@gmail.com>
315
316 PR 22230
317 * objdump.c (load_specific_debug_section): Allocate an extra byte
318 for a terminating NUL.
319
320 2017-09-30 Alan Modra <amodra@gmail.com>
321
322 PR 21978
323 * objdump.c: Formatting.
324 (show_line): Reset prev_line when function name changes.
325
326 2017-09-27 Nick Clifton <nickc@redhat.com>
327
328 PR 22219
329 * dwarf.c (process_debug_info): Add a check for a negative
330 cu_length field.
331
332 2017-09-27 Alan Modra <amodra@gmail.com>
333
334 PR 22216
335 * readelf.c (process_symbol_table): Check that DT_HASH symbol
336 chains are only visited once, and report an error if not. Display
337 invalid symbol index if chain is out of range. Use the same logic
338 when calculating histograms rather than the PR 17531 fix. Delete
339 bogus check that chained index is less than number of buckets.
340
341 2017-09-26 Nick Clifton <nickc@redhat.com>
342
343 PR 22154
344 * dwarf.c (get_line_filename_and_dirname): Add extra checks for
345 buffer overruns.
346
347 2017-09-26 Nick Clifton <nickc@redhat.com>
348
349 * README-how-to-make-a-release: New file.
350
351 2017-09-26 Alan Modra <amodra@gmail.com>
352
353 PR 21732
354 * dwarf.c (READ_ULEB): Don't use DWARF_VMA_FMT in translated string.
355 (READ_SLEB): Likewise.
356 * readelf.c (bfd_vmatoa): New function.
357 (get_data, get_dynamic_data): Use it for printing error messages.
358
359 2017-09-25 H.J. Lu <hongjiu.lu@intel.com>
360
361 PR binutils/22203
362 * nm.c (display_rel_file): Free memory returned from
363 bfd_get_synthetic_symtab.
364
365 2017-09-22 Alexandre Oliva <aoliva@redhat.com>
366
367 * dwarf.h (debug_info): Add loc_views and num_loc_views.
368 * dwarf.c (vm1): New constant.
369 (print_dwarf_view): New function.
370 (read_and_display_attr_value): Support DW_AT_GNU_locviews.
371 (process_debug_info): Keep num_loc_offsets and num_loc_views
372 in sync.
373 (display_view_pair_list): New function.
374 (display_loc_list_dwo): Take vstart_ptr; update it. Dump
375 location view pairs before the range they apply to, when a
376 viewlist augments the loc list.
377 (display_loc_list): Likewise. Check view numbers in range
378 tests.
379 (display_loclists_list): Likewise. Handle view pair entries,
380 and warn on trailing ones.
381 (loc_views): New variable.
382 (loc_offsets_compar): Compare loc_views if loc_offsets are the
383 same.
384 (display_debug_loc): Check and sort loc_views too. Accept
385 loc_view as expected_start. Skip if lists and views are the
386 same. Dump locview list separately in order, and pass the
387 locview list base to each list dump function. Warn and skip
388 overlap and hole checking if we find loclists and locviews to
389 not be adjacent.
390 * testsuite/binutils-all/locview-1.s: New.
391 * testsuite/binutils-all/readelf.locview-1: New.
392 * testsuite/binutils-all/locview-2.s: New.
393 * testsuite/binutils-all/readelf.locview-2: New.
394 * testsuite/binutils-all/readelf.exp: Run new tests. Fix
395 option spelling in pr18374 fail message. XFAIL dw5 test on
396 nds32*-elf.
397
398 2017-09-22 Alan Modra <amodra@gmail.com>
399
400 * testsuite/binutils-all/readelf.exp: Don't perror and exit on
401 bintest.s assembly failure. Report tests unresolved instead.
402 Likewise for version note test, pr18374, decompress, and dw5
403 tests.
404 (readelf_test): Set testname to include both option and binary
405 file name. Use for pass/fail.
406
407 2017-09-21 Maciej W. Rozycki <macro@imgtec.com>
408
409 * readelf.c (get_machine_flags) <E_MIPS_MACH_5900>: New case.
410
411 2017-09-05 Nick Clifton <nickc@redhat.com>
412
413 PR 21995
414 * readelf.c (process_mips_specific): Add checks for a NULL data
415 pointer.
416
417 2017-09-05 Alexander Fedotov <alexander.fedotov@nxp.com>
418 Edmar Wienskoski <edmar.wienskoski@nxp.com
419
420 * readelf.c (get_elf_section_flags): Add VLE.
421 (process_section_headers): Add VLE key to details.
422
423 2017-08-25 Alan Modra <amodra@gmail.com>
424
425 PR 21994
426 * readelf.c (process_version_sections <SHT_GNU_verdef>): Check
427 vd_aux and vda_next for sanity. Delete "end". Correct overflow
428 checks.
429 (process_version_sections <SHT_GNU_verneed>): Correct overflow
430 check. Don't report invalid vna_next on overflow. Do report
431 invalid vna_next on size less than aux info.
432
433 2017-08-23 Alan Modra <amodra@gmail.com>
434
435 PR 21990
436 * readelf.c (process_version_sections <SHT_GNU_verneed>): Check
437 for invalid vn_next field before adding to idx. Use unsigned
438 long for index vars. Move index checks.
439 <SHT_GNU_verdef>: Likewise for vd_next.
440
441 2017-08-17 Nick Clifton <nickc@redhat.com>
442
443 * testsuite/binutils-all/note-3-64.s: New test. Checks assembly
444 and decoding of version2 GNU build attribute notes.
445 * testsuite/binutils-all/note-3-32.s: New test. 32-bit version of
446 the above test.
447 * testsuite/binutils-all/note-3-64.d: New test driver.
448 * testsuite/binutils-all/note-3-32.d: New test driver.
449 * testsuite/binutils-all/objcopy.exp: Run the new test.
450 * readelf.c (is_64bit_abs_reloc): Add R_SPARC_64.
451
452 2017-08-14 Gustavo Romero <gromero@linux.vnet.ibm.com>
453
454 * readelf.c (get_note_type): Handle PPC note types available
455 since Linux 4.8.
456
457 2017-08-12 Alan Modra <amodra@gmail.com>
458
459 * readelf.c (process_note): Qualify NT_GNU_BUILD_ATTRIBUTE notes
460 by name data.
461
462 2017-08-08 Nick Clifton <nickc@redhat.com>
463
464 PR 21909
465 * prdbg.c (pr_int_type): Increase size of local string buffer.
466 (pr_float_type): Likewise.
467 (pr_bool_type): Likewise.
468
469 2017-08-02 Nick Clifton <nickc@redhat.com>
470
471 PR 21702
472 * arsup.c (ar_addmod): Add plugin support for the MRI ADDMOD
473 command.
474
475 2017-08-02 Nick Clifton <nickc@redhat.com>
476
477 * testsuite/binutils-all/objdump.exp (cpus_expected): Add am33-2.
478
479 2017-08-02 Alan Modra <amodra@gmail.com>
480
481 * readelf.c (is_32bit_abs_reloc): Add R_IA64_SECREL32MSB and
482 R_IA64_DIR32MSB.
483 (is_64bit_abs_reloc): Add R_IA64_DIR64MSB.
484 (is_64bit_pcrel_reloc): Add R_IA64_PCREL64MSB.
485
486 2017-08-01 Nick Clifton <nickc@redhat.com>
487
488 * po/sv.po: Updated Swedish translation.
489
490 2017-07-31 Marty Plummer <ntzrmtthihu777@gmail.com>
491
492 PR 21861
493 * winduni.c (codepages): Use cp1252 for codepage 0.
494
495 2017-07-25 Nick Clifton <nickc@redhat.com>
496
497 PR 21820
498 * readelf.c (dump_section_as_strings): Do not fail if the section
499 was empty.
500 (dump_section_as_bytes): Likewise.
501
502 2017-07-24 Nick Clifton <nickc@redhat.com>
503
504 PR 21813
505 * rddbg.c (read_symbol_stabs_debugging_info): Check for an empty
506 string whilst concatenating symbol names.
507
508 2017-07-21 Nick Clifton <nickc@redhat.com>
509
510 * po/fr.po: Updated French translation.
511
512 2017-07-21 Simon Marchi <simon.marchi@ericsson.com>
513
514 * dwarf.c (last_pointer_size, warned_about_missing_comp_units):
515 Remove.
516 (load_debug_info): Remove assignments to those two variables.
517
518 2017-07-21 Alexandre Oliva <aoliva@redhat.com>
519
520 * dwarf.c (struct State_Machine_Registers): Add view field.
521 (reset_state_machine): Reset view.
522 (process_extended_line_op): Reset view when appropriate.
523 (display_debug_lines_raw): Increment or reset view when appropriate.
524 Print nonzero views. Support print view resets, disabled by default.
525 (display_debug_lines_decoded): Likewise. Disambiguate op_code tests,
526 enabling printing of end_sequence.
527 * testsuite/binutils-all/dw2-1.W: Add nonzero views.
528 * testsuite/binutils-all/dw2-3.W: Likewise.
529 * testsuite/binutils-all/dw2-3gabi.W: Likewise.
530 * testsuite/binutils-all/dw5.W: Add end sequence lines.
531 * testsuite/binutils-all/i386/compressed-1a.d: Add nonzero views.
532 * testsuite/binutils-all/libdw2-compressedgabi.out: Likewise.
533 * testsuite/binutils-all/objdump.W: Likewise.
534 * testsuite/binutils-all/objdump.WL: Add end sequence lines.
535 * testsuite/binutils-all/x86-64/compressed-1a.d: Add nonzero views.
536
537 2017-07-19 Tristan Gingold <gingold@adacore.com>
538
539 * nm.c (show_stats): Remove variable.
540 (long_options): Remove --stats option.
541 (main): Remove handling of --stats.
542
543 2017-07-18 Nick Clifton <nickc@redhat.com>
544
545 PR 21775
546 * coffgrok.c: Fix spelling typos.
547 * readelf.c: Likewise.
548 * stabs.c: Likewise.
549 * testsuite/binutils-all/objcopy.exp: Likewise.
550
551 2017-07-18 Nick Clifton <nickc@redhat.com>
552
553 * po/sv.po: Updated Swedish translation.
554
555 2017-07-18 Hans-Peter Nilsson <hp@bitrange.com>
556
557 * dwarf.c (display_debug_names): Initialize hash_prev.
558
559 2017-07-17 Nick Clifton <nickc@redhat.com>
560
561 PR 21433
562 * ar.c (main): Skip check for no files on the command line when
563 running in MRI mode.
564
565 2017-07-13 H.J. Lu <hongjiu.lu@intel.com>
566
567 * testsuite/binutils-all/objdump.exp: Always delete $testarchive
568 first.
569
570 2017-07-12 Alan Modra <amodra@gmail.com>
571
572 * po/bg.po: Update from translationproject.org/latest/binutils/.
573 * po/ca.po: Likewise.
574 * po/da.po: Likewise.
575 * po/es.po: Likewise.
576 * po/fi.po: Likewise.
577 * po/fr.po: Likewise.
578 * po/hr.po: Likewise.
579 * po/id.po: Likewise.
580 * po/it.po: Likewise.
581 * po/ja.po: Likewise.
582 * po/ro.po: Likewise.
583 * po/ru.po: Likewise.
584 * po/sk.po: Likewise.
585 * po/sr.po: Likewise.
586 * po/sv.po: Likewise.
587 * po/tr.po: Likewise.
588 * po/uk.po: Likewise.
589 * po/vi.po: Likewise.
590 * po/zh_CN.po: Likewise.
591 * po/zh_TW.po: Likewise.
592
593 2017-07-12 Nick Clifton <nickc@redhat.com>
594
595 Fix compile time warnings using gcc 7.1.1.
596 * dwarf.c (dwarf_vmatoa_1): Do not pass a NULL string pointer to
597 sprintf.
598 * srconv.c (walk_tree_type): Initialise the spare field of the
599 IT_dty structure.
600
601 2017-07-11 Andreas Schwab <schwab@suse.de>
602
603 * readelf.c (process_note): Print newline after description data
604 in narrow mode.
605 (print_core_note): Print newline if nothing was printed in wide
606 mode.
607
608 2017-07-09 Rafael Fontenelle <rafaelff@gnome.org>
609
610 * dwarf.c (display_formatted_table): Fix error message typo.
611
612 2017-07-07 John Baldwin <jhb@FreeBSD.org>
613
614 * readelf.c (get_freebsd_elfcore_note_type): Handle
615 NT_FREEBSD_PTLWPINFO.
616
617 2017-07-05 H.J. Lu <hongjiu.lu@intel.com>
618
619 * dwarf.c (display_debug_names): Replace index with xindex.
620
621 2017-07-04 Tristan Gingold <gingold@adacore.com>
622
623 * configure: Regenerate.
624
625 2017-07-04 Tristan Gingold <gingold@adacore.com>
626
627 * NEWS: Add marker for 2.29.
628
629 2017-07-03 Tristan Gingold <gingold@adacore.com>
630
631 * po/binutils.pot: Regenerate.
632
633 2017-07-03 Alan Modra <amodra@gmail.com>
634
635 * strings.c (filename_and_size_t): Delete.
636 (strings_a_section): Don't check section size against file size.
637 Use bdf_malloc_and_get_section. Report an error on failures.
638 Replace arg param with filename and got_a_section param.
639 (got_a_section): Move to..
640 (strings_object_file): ..an auto var here. Iterate over sections
641 rather than calling bfd_map_over_sections. Adjust strings_a_section
642 call.
643
644 2017-07-02 Jan Kratochvil <jan.kratochvil@redhat.com>
645
646 * dwarf.c: Include assert.h.
647 (MAX, MIN, get_IDX_name, display_debug_names): New.
648 (debug_displays): Add .debug_names.
649 * dwarf.h: (enum dwarf_section_display_enum): Add debug_names.
650 * readelf.c (process_section_headers): Add ".debug_names".
651
652 2017-07-01 Alan Modra <amodra@gmail.com>
653
654 PR binutils/21665
655 * objdump.c (strtab): Make var a bfd_byte*.
656 (disassemble_section): Don't limit malloc size. Instead, use
657 bfd_malloc_and_get_section.
658 (read_section_stabs): Use bfd_malloc_and_get_section. Return
659 bfd_byte*.
660 (find_stabs_section): Remove now unnecessary cast.
661 * objcopy.c (copy_object): Use bfd_malloc_and_get_section. Free
662 contents on error return.
663 * nlmconv.c (copy_sections): Use bfd_malloc_and_get_section.
664
665 2017-06-30 Nick Clifton <nickc@redhat.com>
666
667 PR binutils/21665
668 * objdump.c (disassemble_section): Move check for an overlarge
669 section to just before the allocation of memory. Do not check
670 section size against file size, but instead use an arbitrary 2Gb
671 limit. Issue a warning message if the section is too big.
672
673 2017-06-30 Maciej W. Rozycki <macro@imgtec.com>
674
675 * NEWS: Mention microMIPS XPA support.
676
677 2017-06-30 Maciej W. Rozycki <macro@imgtec.com>
678
679 * NEWS: Mention microMIPS Release 5 ISA support.
680
681 2017-06-30 Maciej W. Rozycki <macro@imgtec.com>
682
683 * testsuite/binutils-all/mips/mips-xpa-virt-1.d: New test.
684 * testsuite/binutils-all/mips/mips-xpa-virt-2.d: New test.
685 * testsuite/binutils-all/mips/mips-xpa-virt-3.d: New test.
686 * testsuite/binutils-all/mips/mips-xpa-virt-4.d: New test.
687 * testsuite/binutils-all/mips/mips-xpa-virt.s: New test source.
688 * testsuite/binutils-all/mips/mips.exp: Run the new tests.
689
690 2017-06-29 Anton Kolesov <Anton.Kolesov@synopsys.com>
691
692 * testsuite/binutils-all/arc/double_store.s: New file.
693 * testsuite/binutils-all/arc/objdump.exp: Tests for disassembler
694 options.
695 (do_objfile): New function.
696 (check_assembly): Likewise.
697
698 2017-06-29 Andreas Arnez <arnez@linux.vnet.ibm.com>
699
700 * readelf.c (get_note_type): Add NT_S390_GS_CB and NT_S390_GS_BC.
701
702 2017-06-28 H.J. Lu <hongjiu.lu@intel.com>
703
704 * objdump.c (dump_relocs_in_section): Cast to ufile_ptr when
705 comparing against bfd_get_file_size return.
706
707 2017-06-28 Nick Clifton <nickc@redhat.com>
708
709 * objcopy.c (merge_gnu_build_notes): Add support for version 2 notes.
710 * readelf.c (print_gnu_build_attribute_name): Likewise.
711
712 2017-06-28 Maciej W. Rozycki <macro@imgtec.com>
713 Matthew Fortune <matthew.fortune@imgtec.com>
714
715 * readelf.c (get_machine_flags) <E_MIPS_MACH_IAMR2>: New case.
716 (print_mips_isa_ext) <AFL_EXT_INTERAPTIV_MR2>: Likewise.
717 * NEWS: Mention Imagination interAptiv MR2 processor support.
718
719 2017-06-26 Nick Clifton <nickc@redhat.com>
720
721 PR binutils/21665
722 * objdump.c (disassemble_section): Skip any section that is bigger
723 than the entire file.
724
725 2017-06-26 Nick Clifton <nickc@redhat.com>
726
727 PR binutils/21659
728 * bucomm.c (get_file_size): Explicitly warn if the file is a
729 directory.
730
731 2017-06-24 Thomas Preud'homme <thomas.preudhomme@arm.com>
732
733 * readelf.c (arm_attr_tag_CPU_arch): Fill value for ARMv8-R.
734
735 2017-06-23 Nick Clifton <nickc@redhat.com>
736
737 PR binutils/21659
738 * strings.c (strings_file): Warn about attempts to run strings on
739 a directory.
740
741 2017-06-22 H.J. Lu <hongjiu.lu@intel.com>
742
743 * readelf.c (decode_x86_feature): Decode
744 GNU_PROPERTY_X86_FEATURE_1_SHSTK.
745 * testsuite/binutils-all/i386/shstk.d: New file.
746 * testsuite/binutils-all/i386/shstk.s: Likewise.
747 * testsuite/binutils-all/x86-64/shstk-x32.d: Likewise.
748 * testsuite/binutils-all/x86-64/shstk.d: Likewise.
749 * testsuite/binutils-all/x86-64/shstk.s: Likewise.
750
751 2017-06-22 H.J. Lu <hongjiu.lu@intel.com>
752
753 * readelf.c (decode_x86_feature): New.
754 (print_gnu_property_note): Call decode_x86_feature on
755 GNU_PROPERTY_X86_FEATURE_1_AND.
756 * testsuite/binutils-all/i386/empty.d: New file.
757 * testsuite/binutils-all/i386/empty.s: Likewise.
758 * testsuite/binutils-all/i386/ibt.d: Likewise.
759 * testsuite/binutils-all/i386/ibt.s: Likewise.
760 * testsuite/binutils-all/x86-64/empty-x32.d: Likewise.
761 * testsuite/binutils-all/x86-64/empty.d: Likewise.
762 * testsuite/binutils-all/x86-64/empty.s: Likewise.
763 * testsuite/binutils-all/x86-64/ibt-x32.d: Likewise.
764 * testsuite/binutils-all/x86-64/ibt.d: Likewise.
765 * testsuite/binutils-all/x86-64/ibt.s: Likewise.
766
767 2017-06-21 H.J. Lu <hongjiu.lu@intel.com>
768
769 * dwarf.c (READ_ULEB): Use DWARF_VMA_FMT to report error.
770 (READ_SLEB): Likewise.
771
772 2017-06-21 Nick Clifton <nickc@redhat.com>
773
774 PR binutils/21648
775 * dwarf.c (LEB): Rename to SKIP_ULEB and READ_ULEB. Add check for
776 reading a value that is too big for the containing variable.
777 (SLEB): Rename to SKIP_SLEB and READ_SLEB. Add similar check.
778 Replace uses of LEB and SLEB with appropriate new macro.
779 (display_debug_frames): Use an unsigned int for the 'reg'
780 variable. Use a signed long for the 'l' variable.
781
782 2017-06-20 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
783
784 * readelf.c (get_s390_segment_type): Add support for the new
785 segment type PT_S390_PGSTE.
786 (get_segment_type): Call get_s390_segment_type.
787
788 2017-06-19 Nick Clifton <nickc@redhat.com>
789
790 PR binutils/21619
791 * objdump.c (disassemble_bytes): Check that there is sufficient
792 data available before attempting to display it.
793
794 2017-06-06 Simon Marchi <simon.marchi@ericsson.com>
795
796 * sysinfo.y: Free memory allocated by token NAME.
797
798 2017-05-30 Anton Kolesov <anton.kolesov@synopsys.com>
799
800 * doc/binutils.texi: Document new cpu=... disassembler options for ARC.
801
802 2017-05-30 H.J. Lu <hongjiu.lu@intel.com>
803
804 PR binutils/21519
805 * objdump.c (dump_relocs_in_section): Replace get_file_size
806 with bfd_get_file_size to get archive element size.
807 * testsuite/binutils-all/objdump.exp (test_objdump_f): New
808 proc.
809 (test_objdump_h): Likewise.
810 (test_objdump_t): Likewise.
811 (test_objdump_r): Likewise.
812 (test_objdump_s): Likewise.
813 Add objdump tests on archive.
814
815 2017-05-24 Yao Qi <yao.qi@linaro.org>
816
817 * objdump.c (disassemble_data): Caller update.
818
819 2017-05-19 Jose E. Marchesi <jose.marchesi@oracle.com>
820
821 * objcopy.c (merge_gnu_build_notes): Remove workaround that
822 prevented deleting relocations in duplicated notes in mips64 and
823 sparc.
824
825 2017-05-19 Maciej W. Rozycki <macro@imgtec.com>
826
827 * testsuite/binutils-all/mips/mips-note-2.d: New test.
828 * testsuite/binutils-all/mips/mips-note-2r.d: New test.
829 * testsuite/binutils-all/mips/mips-note-2-n32.d: New test.
830 * testsuite/binutils-all/mips/mips-note-2-n64.d: New test.
831 * testsuite/binutils-all/mips/mips-note-2r-n32.d: New test.
832 * testsuite/binutils-all/mips/mips-note-2r-n64.d: New test.
833 * testsuite/binutils-all/mips/mips.exp: Define `has_newabi'.
834 Run the new tests.
835
836 2017-05-19 Maciej W. Rozycki <macro@imgtec.com>
837
838 * testsuite/lib/utils-lib.exp (run_dump_test): Handle the `dump'
839 option.
840
841 2017-05-19 Jose E. Marchesi <jose.marchesi@oracle.com>
842
843 * NEWS: Mention the SPARC M8 support.
844
845 2017-05-19 Maciej W. Rozycki <macro@imgtec.com>
846
847 * testsuite/binutils-all/mips/mips.exp: Bail out right away if
848 non-ELF.
849
850 2017-05-18 Alan Modra <amodra@gmail.com>
851
852 * strings.c: Don't compare boolean values against TRUE or FALSE.
853
854 2017-05-15 Jeff Law <law@redhat.com>
855
856 * readelf.c (display_arc_attribute): Avoid implicit fallthru.
857
858 2017-05-15 Maciej W. Rozycki <macro@imgtec.com>
859
860 * testsuite/binutils-all/mips/mips16-undecoded.d: Add `-mips3'
861 to `as' flags.
862 * testsuite/binutils-all/mips/mips16e2-undecoded.d: New test.
863 * testsuite/binutils-all/mips/mips16e2-extend-insn.d: New test.
864 * testsuite/binutils-all/mips/mips16-undecoded.s: Remove
865 `.module mips3'.
866 * testsuite/binutils-all/mips/mips.exp: Run the new tests.
867
868 2017-05-15 Maciej W. Rozycki <macro@imgtec.com>
869
870 * readelf.c (print_mips_ases): Handle MIPS16e2 ASE.
871 * NEWS: Mention MIPS16e2 ASE support.
872
873 2017-05-12 Maciej W. Rozycki <macro@imgtec.com>
874
875 * testsuite/binutils-all/mips/mips16-extend-insn.d: Adjust BREAK
876 and SDBBP disassembly.
877
878 2017-05-10 Maciej W. Rozycki <macro@imgtec.com>
879
880 * testsuite/binutils-all/mips/mips.exp: Define `tempfile' and
881 `copyfile' variables.
882
883 2017-05-10 Claudiu Zissulescu <claziss@synopsys.com>
884
885 * readelf.c (decode_ARC_machine_flags): Recognize OSABI v4.
886 (get_arc_section_type_name): New function.
887 (get_section_type_name): Use the above function.
888 (display_arc_attribute): New function.
889 (process_arc_specific): Likewise.
890 (process_arch_specific): Handle ARC specific information.
891
892 2017-05-09 Kaz Kojima <kkojima@rr.iij4u.or.jp>
893
894 * MAINTAINERS (SH): Remove myself as SH maintainer.
895
896 2017-05-02 H.J. Lu <hongjiu.lu@intel.com>
897
898 * objcopy.c (merge_gnu_build_notes): Cast relcount to unsigned
899 long when comparing with sec->reloc_count.
900
901 2017-05-02 Nick Clifton <nickc@redhat.com>
902
903 * objcopy.c (merge_gnu_build_notes): Disable merge if there are
904 more internal relocs than external relocs.
905
906 2017-05-02 Maciej W. Rozycki <macro@imgtec.com>
907
908 * testsuite/binutils-all/mips/mips16-undecoded.d: Adjust the
909 disassembly of PC-relative LA and LW synthetic instructions.
910
911 2017-05-02 Nick Clifton <nickc@redhat.com>
912
913 PR 21440
914 * objdump.c (dump_relocs_in_section): Check for an excessive
915 number of relocs before attempting to dump them.
916
917 2017-05-01 Alan Modra <amodra@gmail.com>
918
919 * objcopy.c (merge_gnu_build_notes): Correct code deleting
920 relocs.
921
922 2017-04-28 Nick Clifton <nickc@redhat.com>
923
924 PR binutils/21439
925 * readelf.c (print_gnu_build_attribute_name): Allow for an empty
926 name field.
927
928 2017-04-28 Nick Clifton <nickc@redhat.com>
929
930 PR binutils/21437
931 * readelf.c (process_version_sections): Check for underflow when
932 computing the start address of the auxillary version data.
933
934 2017-04-28 Nick Clifton <nickc@redhat.com>
935
936 PR binutils/21438
937 * dwarf.c (process_extended_line_op): Do not assume that the
938 string extracted from the section is NUL terminated.
939 (fetch_indirect_string): If the string retrieved from the section
940 is not NUL terminated, return an error message.
941 (fetch_indirect_line_string): Likewise.
942 (fetch_indexed_string): Likewise.
943
944 2017-04-26 Nick Clifton <nickc@redhat.com>
945
946 PR binutils/21433
947 * bucomm.c (get_file_size): Return -1 if file_name is NULL.
948 * ar.c (main): Fail with usage() invocation if no file names are
949 provided.
950
951 2017-04-26 Nick Clifton <nickc@redhat.com>
952
953 * readelf.c (process_section_headers): Warn about overlarge
954 sections.
955 (print_gnu_build_attribute_name): Print the number of unrecognised
956 note types. Fix formatting in the presence of errors.
957 (testsuite/binutils-all/note-2-32.s): Fix encoding of numeric notes.
958 (testsuite/binutils-all/note-2-64.s): Likewise.
959
960 2017-04-26 Maciej W. Rozycki <macro@imgtec.com>
961
962 * readelf.c (process_mips_specific): Add static GOT support.
963
964 2017-04-25 Maciej W. Rozycki <macro@imgtec.com>
965
966 * readelf.c (process_mips_specific): Remove error reporting from
967 GOT[1] processing.
968
969 2017-04-25 Maciej W. Rozycki <macro@imgtec.com>
970
971 * readelf.c (process_mips_specific): Remove null GOT data check.
972
973 2017-04-25 Maciej W. Rozycki <macro@imgtec.com>
974
975 * testsuite/binutils-all/mips/mips16-alias.d: New test.
976 * testsuite/binutils-all/mips/mips16-noalias.d: New test.
977 * testsuite/binutils-all/mips/mips16-alias.s: New test source.
978 * testsuite/binutils-all/mips/mips.exp: Run the new tests.
979
980 2017-04-23 Alan Modra <amodra@gmail.com>
981
982 PR 21418
983 * ar.c (main): Check -a, -b, -i and -N args are given.
984
985 2017-04-23 Alan Modra <amodra@gmail.com>
986
987 PR 21417
988 * ar.c (main): Check that an archive file is given after options.
989
990 2017-04-23 Alan Modra <amodra@gmail.com>
991
992 PR 21415
993 * objdump.c (disassemble_section): Check bfd_get_section_contents
994 status.
995
996 2017-04-23 Alan Modra <amodra@gmail.com>
997
998 PR 21408
999 * dwarf.c (display_debug_lines_decoded): Don't segfault on NULL
1000 file_table.
1001
1002 2017-04-21 Nick Clifton <nickc@redhat.com>
1003
1004 PR binutils/21378
1005 * readelf.c (print_gnu_build_attribute_name): Check for an
1006 overlarge name field.
1007
1008 2017-04-13 Nick Clifton <nickc@redhat.com>
1009
1010 PR binutils/21379
1011 * readelf.c (process_dynamic_section): Detect over large section
1012 offsets in the DT_SYMTAB entry.
1013
1014 2017-04-13 Nick Clifton <nickc@redhat.com>
1015
1016 PR binutils/21345
1017 * readelf.c (process_mips_specific): Catch an unfeasible memory
1018 allocation before it happens and print a suitable error message.
1019
1020 2017-04-13 Nick Clifton <nickc@redhat.com>
1021
1022 * objcopy.c: Add --no-merge-notes option to disable note merging.
1023 Add --[no-]merge-notes option to strip, and enable it by default.
1024 (num_bytes): New function.
1025 (merge_gnu_build_notes): Add code to merge stack size notes.
1026 * binutils.texi: Update strip and objcopy documentation.
1027 * readelf.c (print_gnu_build_attribute_name): Use defined
1028 constants for note types.
1029
1030 2017-04-10 John Delsignor <john.delsignore@roguewave.com>
1031
1032 PR binutils/21319
1033 * dwarf.c (display_gdb_index): Correct test for a corrupt address
1034 table size.
1035
1036 2017-04-05 Jiong Wang <jiong.wang@arm.com>
1037
1038 * objcopy.c (struct redefine_node): Delete the field "next".
1039 (redefine_sym_list): Deleted.
1040 (redefine_specific_htab): New hash table.
1041 (redefine_specific_reverse_htab): Likewise.
1042 (eq_string_redefnode): New function.
1043 (htab_hash_redefnode): Likewise.
1044 (create_symbol2redef_htab): Likewise.
1045 (add_specific_symbol_node): Likewise.
1046 (create_symbol_htabs): Create redefine_specific_htab and
1047 redefine_specific_reverse_htab.
1048 (lookup_sym_redefinition): Use hash table instead of list.
1049 (redefine_list_append): Likewise, and rename to add_redefine_and_check.
1050 (copy_main): Use redefine_specific_htab instead of redefine_sym_list.
1051 Update comments.
1052
1053 2017-04-04 H.J. Lu <hongjiu.lu@intel.com>
1054
1055 * NEWS: Mention support for ELF SHF_GNU_MBIND and
1056 PT_GNU_MBIND_XXX.
1057 * readelf.c (get_segment_type): Handle PT_GNU_MBIND_XXX.
1058 (get_elf_section_flags): Handle SHF_GNU_MBIND.
1059 (process_section_headers): Likewise.
1060 * testsuite/binutils-all/mbind1.s: New file.
1061 * testsuite/binutils-all/objcopy.exp: Run readelf test on
1062 mbind1.s.
1063
1064 2017-04-03 Nick Clifton <nickc@redhat.com>
1065
1066 PR binutils/21345
1067 * readelf.c (get_program_headers): Check for there being too many
1068 program headers before attempting to allocate space for them.
1069
1070 2017-04-03 Nick Clifton <nickc@redhat.com>
1071
1072 PR binutils/21344
1073 * readelf.c (process_mips_specific): Check for an out of range GOT
1074 entry before reading the module pointer.
1075
1076 2017-04-03 Nick Clifton <nickc@redhat.com>
1077
1078 PR binutils/21343
1079 * readelf.c (get_unwind_section_word): Fix snafu checking for
1080 invalid word offsets in ARM unwind information.
1081
1082 2017-03-31 Pip Cet <pipcet@gmail.com>
1083
1084 * NEWS: Use "WebAssembly" consistently.
1085 * testsuite/binutils-all/wasm32/wasm32.exp: Fix copyright notice.
1086
1087 2017-03-30 Pip Cet <pipcet@gmail.com>
1088
1089 * readelf.c: Add support for wasm32 ELF format WebAssembly files.
1090 (guess_is_rela): Likewise.
1091 (dump_relocations): Likewise.
1092 (is_32bit_abs_reloc): Likewise.
1093 (is_none_reloc_): Likewise.
1094 * NEWS: Mention the new support.
1095 * testsuite/lib/binutils-common.exp (is_elf_format): Mark wasm32
1096 as ELF target.
1097 (supports_gnu_unique): Mark wasm32 as supporting STB_GNU_UNIQUE.
1098 * testsuite/binutils-all/nm.exp: Mark wasm32 as requiring .size annotations.
1099 * testsuite/binutils-all/wasm32: New directory.
1100 * testsuite/binutils-all/wasm32/create-wasm.d: New file.
1101 * testsuite/binutils-all/wasm32/create-wasm.s: Likewise.
1102 * testsuite/binutils-all/wasm32/custom-section.d: Likewise.
1103 * testsuite/binutils-all/wasm32/custom-section.s: Likewise.
1104 * testsuite/binutils-all/wasm32/invalid-wasm-1.d: Likewise.
1105 * testsuite/binutils-all/wasm32/invalid-wasm-1.s: Likewise.
1106 * testsuite/binutils-all/wasm32/long-sections.d: Likewise.
1107 * testsuite/binutils-all/wasm32/long-sections.s: Likewise.
1108 * testsuite/binutils-all/wasm32/parse-wasm.d: Likewise.
1109 * testsuite/binutils-all/wasm32/parse-wasm.s: Likewise.
1110 * testsuite/binutils-all/wasm32/parse-wasm-2.d: Likewise.
1111 * testsuite/binutils-all/wasm32/parse-wasm-2.s: Likewise.
1112 * testsuite/binutils-all/wasm32/prepared-section.d: Likewise.
1113 * testsuite/binutils-all/wasm32/prepared-section.s: Likewise.
1114 * testsuite/binutils-all/wasm32/wasm32.exp: New file, run tests.
1115
1116 2017-03-29 Alan Modra <amodra@gmail.com>
1117
1118 * doc/binutils.texi (objdump): Document PowerPC -M options.
1119
1120 2017-03-21 Andi Kleen <ak@linux.intel.com>
1121
1122 * objdump.c (unwind_inlines): Add.
1123 (option_values): Add OPTION_INLINES.
1124 (show_line): Unwind inlines if requested.
1125 (main): Parse OPTION_INLINES.
1126 (usage): Document --inlines.
1127 * doc/binutils.texi: Document --inlines.
1128 * NEWS: Likewise.
1129
1130 2017-03-21 Nick Clifton <nickc@redhat.com>
1131
1132 * readelf.c (print_gnu_build_attribute_name): Allow stack
1133 protection notes to contain numeric values. Use a colon rather
1134 than a space to separate a string name from its values. Decode
1135 the numeric value of a stack protection note.
1136 * objcopy.c (merge_gnu_build_notes): Allow version notes to
1137 contain extra text after the protocol version number.
1138
1139 2017-03-20 Mark Wielaard <mark@klomp.org>
1140
1141 * readelf.c (process_program_headers): Move dynamic_addr check
1142 after .dynamic section cross check.
1143
1144 2017-03-17 Nick Clifton <nickc@redhat.com>
1145
1146 * readelf.c (print_gnu_build_attribute_name): Fix off by one error
1147 printing the value for a build note with an ascii name.
1148
1149 2017-03-16 Nick Clifton <nickc@redhat.com>
1150
1151 * readelf.c (print_gnu_build_attribute_name): Add support for
1152 GNU_BUILD_ATTRIBUTE_SHORT_ENUM.
1153
1154 2017-03-14 Nick Clifton <nickc@redhat.com>
1155
1156 * readelf.c (print_gnu_build_attribute_description): Move symbol
1157 printing code to...
1158 (print_symbol_for_build_attribute): New function. ...here.
1159 Add to find the best symbol to associate with an OPEN note.
1160 Add code to cache the symbol table and string table, so that they
1161 are not loaded every time a note is displayed.
1162 * testsuite/binutils-all/note-2-32.s: Add a function symbol.
1163 * testsuite/binutils-all/note-2-64.s: Likewise.
1164 * testsuite/binutils-all/note-2-32.d: Update expected note output.
1165 * testsuite/binutils-all/note-2-64.d: Likewise.
1166
1167 2017-03-13 Alan Modra <amodra@gmail.com>
1168 Taeung Song <treeze.taeung@gmail.com>
1169
1170 * objdump.c (update_source_path): Add abfd param. Add struct
1171 stat var. Pass to try_print_file_open. Warn if source is more
1172 recent than object.
1173 (try_print_file_open, slurp_file): Add struct stat param to
1174 return fstat.
1175 (show_line): Call update_source_path with bfd.
1176
1177 2017-03-10 Chia-Hao Lo <fcamel@gmail.com>
1178
1179 PR binutils/21235
1180 * objdump.c (main): Set do_wide with --wide.
1181
1182 2017-03-10 Nick Clifton <nickc@redhat.com>
1183
1184 * readelf.c (get_machine_name): Rearrange switch table in order of
1185 increasing machine number. Add missing entries.
1186
1187 2017-03-08 H.J. Lu <hongjiu.lu@intel.com>
1188
1189 PR binutils/21231
1190 * readelf.c (decode_x86_isa): Change argument to unsigned int.
1191 (print_gnu_property_note): Retrieve property type and datasz as
1192 4-byte integer. Consolidate property datasz check. Check
1193 GNU_PROPERTY_LOPROC and GNU_PROPERTY_LOUSER.
1194 * testsuite/binutils-all/i386/pr21231a.d: New file.
1195 * testsuite/binutils-all/i386/pr21231a.s: Likewise.
1196 * testsuite/binutils-all/i386/pr21231b.d: Likewise.
1197 * testsuite/binutils-all/i386/pr21231b.s: Likewise.
1198 * testsuite/binutils-all/x86-64/pr21231a.d: Likewise.
1199 * testsuite/binutils-all/x86-64/pr21231a.s: Likewise.
1200 * testsuite/binutils-all/x86-64/pr21231b.d: Likewise.
1201 * testsuite/binutils-all/x86-64/pr21231b.s: Likewise.
1202
1203 2017-03-06 Nick Clifton <nickc@redhat.com>
1204
1205 * readelf.c (print_gnu_build_attribute_name): Read byte values
1206 from the name string as unsigned bytes.
1207 (process_notes_at): Use memcpy to copy an unterminated name
1208 string.
1209
1210 2017-03-06 Sam Thursfield <sam.thursfield@codethink.co.uk>
1211
1212 * configure.ac (AC_CHECK_DECLS): Add asprintf.
1213 * config.in: Regenerate.
1214 * configure: Regenerate.
1215
1216 2017-03-02 Nick Clifton <nickc@redhat.com>
1217
1218 * readelf.c (print_gnu_build_attribute_description): Use global
1219 symbols for OPEN attributes if at all possible.
1220 * objcopy.c (is_merged_note_section): Support build note sections
1221 without the SHF_GNU_BUILD_NOTE section flag set.
1222
1223 2017-03-02 Jan Kratochvil <jan.kratochvil@redhat.com>
1224
1225 * dwarf.c (debug_displays_assert): New static assertion.
1226
1227 2017-03-02 Jan Kratochvil <jan.kratochvil@redhat.com>
1228
1229 * dwarf.h (enum dwarf_section_display_enum): Add loclists and rnglists.
1230
1231 2017-03-01 Nick Clifton <nickc@redhat.com>
1232
1233 * readelf.c (get_note_type): Add support for GNU_BUILD_NOTEs.
1234 (get_gnu_elf_note_type): Add support for GNU_PROPERTY_NOTEs.
1235 (decode_x86_isa): New function.
1236 (print_gnu_property_note): New function.
1237 (print_gnu_note): Handle GNU_PROPERTY_NOTEs.
1238 (print_gnu_build_attribute_description): New function.
1239 (print_gnu_build_attribute_name): New function.
1240 (process_note): Add support for GNU_BUILD_NOTEs.
1241 * objcopy.c (--merge-notes): New command line option.
1242 (copy_options): Add merge-notes.
1243 (copy_usage): Likewise.
1244 (is_merge_note_section): New function.
1245 (merge_gnu_build_notes): New function.
1246 (copy_object): Merge note sections if asked to do so.
1247 (skip_section): Add skip_copy parameter. Add support for skipping
1248 merged note sections.
1249 (copy_relocations_in_section): Update call to skip_section.
1250 (copy_section): Likewise.
1251 (copy_main): Add support for merge-notes option.
1252 * doc/binutils.texi: Document the new option to objcopy.
1253 * NEWS: Mention the new feature.
1254 * testsuite/binutils-all/note-2-32.d: New test. Checks note
1255 merging on 32-bit targets.
1256 * testsuite/binutils-all/note-2-32.s: New test source file.
1257 * testsuite/binutils-all/note-2-64.d: New test. Like note-2-32.d
1258 but for 64-bit targets.
1259 * testsuite/binutils-all/note-2-64.s: New test source file.
1260 * testsuite/binutils-all/objcopy.exp: Run the new test.
1261
1262 2017-02-28 Peter Bergner <bergner@vnet.ibm.com>
1263
1264 * objdump.c (main): Use remove_whitespace_and_extra_commas.
1265
1266 2017-02-27 Jan Kratochvil <jan.kratochvil@redhat.com>
1267
1268 Fix compilation with GCC 4.4.7.
1269 * dwarf.c (display_loclists_list, display_debug_rnglists_list):
1270 Initialize begin and end.
1271
1272 2017-02-25 Alan Modra <amodra@gmail.com>
1273
1274 * testsuite/binutils-all/dw5.S: Replace .string with .asciz.
1275 Support hpux .comm variant.
1276 * testsuite/binutils-all/readelf.exp: Define HPUX when assembling
1277 dw5 test for hppa64-hpux.
1278
1279 2017-02-24 Nick Clifton <nickc@redhat.com>
1280
1281 * readelf.c (show_name, do_dynamic, do_syms, do_dyn_syms,
1282 (do_reloc, do_sections, do_section_groups, do_section_details,
1283 (do_segments, do_unwind, do_using_dynamic, do_header, do_dump,
1284 (do_version, do_histogram, do_debugging, do_arch, do_notes,
1285 (do_archive_index, is_32bit_elf, decompress_dumps): Use
1286 bfd_boolean type.
1287 (parse_args): Treat the do_* variables as booleans.
1288 (print_vma): Return an unsigned int.
1289 (print_symbol): Change width parameter to signed int.
1290 (is_ia64_vms): Change return type to bfd_boolean.
1291 (guess_is_rela): Likewise.
1292 (slurp_rela_relocs): Likewise.
1293 (slurp_rel_relocs): Likewise.
1294 (dump_relocations): Likewise.
1295 (process_file_header): Likewise.
1296 (get_program_headers): Likewise.
1297 (process_program_headers): Likewise.
1298 (process_section_headers): Likewise.
1299 (process_section_groups): Likewise.
1300 (dump_ia64_vms_dynamic_fixups): Likewise.
1301 (dump_ia64_vms_dynamic_relocs): Likewise.
1302 (process_ia64_vms_dynamic_relocs): Likewise.
1303 (process_relocs): Likewise.
1304 (dump_ia64_unwind): Likewise.
1305 (ia64_process_unwind): Likewise.
1306 (dump_hppa_unwind): Likewise.
1307 (slurp_hppa_unwind_table): Likewise.
1308 (hppa_process_unwind): Likewise.
1309 (decode_arm_unwind_bytecode): Likewise.
1310 (decode_tic6x_unwind_bytecode): Likewise.
1311 (decode_arm_unwind): Likewise.
1312 (dump_arm_unwind): Likewise.
1313 (arm_process_unwind): Likewise.
1314 (process_unwind): Likewise.
1315 (get_32bit_dynamic_section): Likewise.
1316 (get_64bit_dynamic_section): Likewise.
1317 (process_dynamic_section): Likewise.
1318 (process_version_sections): Likewise.
1319 (process_symbol_table): Likewise.
1320 (process_syminfo): Likewise.
1321 (apply_relocations): Likewise.
1322 (disassemble_section): Likewise.
1323 (dump_section_as_strings): Likewise.
1324 (dump_section_as_bytes): Likewise.
1325 (load_specific_debug_section): Likewise.
1326 (load_debug_section): Likewise.
1327 (display_debug_section): Likewise.
1328 (process_section_contents): Likewise.
1329 (process_attributes): Likewise.
1330 (process_nds32_specific): Likewise.
1331 (process_gnu_liblist): Likewise.
1332 (print_core_note): Likewise.
1333 (print_gnu_note): Likewise.
1334 (print_v850_note): Likewise.
1335 (process_netbsd_elf_note): Likewise.
1336 (print_stapsdt_note): Likewise.
1337 (print_ia64_vms_note): Likewise.
1338 (process_note): Likewise.
1339 (process_notes_at): Likewise.
1340 (process_corefile_note_segments): Likewise.
1341 (process_v850_notes): Likewise.
1342 (process_note_sections): Likewise.
1343 (process_notes): Likewise.
1344 (process_arch_specific): Likewise.
1345 (get_file_header): Likewise.
1346 (process_object): Likewise.
1347 (process_archive): Likewise.
1348 (process_file): Likewise.
1349 (section_subset): Make static.
1350 (get_mips_reg_size): Return a signed integer.
1351 (process_object): Reverse the logic of the return value.
1352 (process_archive): Likewise.
1353 (process_file): Likewise.
1354 (process_program_headers): Fix snafu - if the program headers are
1355 not available then this is not a cause to fail.
1356 (process_corefile_note_segments): Likewise.
1357
1358 2017-02-24 Maciej W. Rozycki <macro@imgtec.com>
1359
1360 * readelf.c (get_ver_flags): Tidy the formatting of the string
1361 returned
1362
1363 2017-02-24 Maciej W. Rozycki <macro@imgtec.com>
1364
1365 * readelf.c (process_version_sections) <SHT_GNU_verdef>: Make
1366 `isum' unsigned.
1367 <SHT_GNU_verneed>: Likewise.
1368
1369 2017-02-24 Maciej W. Rozycki <macro@imgtec.com>
1370
1371 * readelf.c (process_version_sections) <SHT_GNU_verdef>: Limit
1372 the number of entries processed by the section size. Don't
1373 break out of the loop if `ent.vd_next' is 0.
1374
1375 2017-02-23 Jan Kratochvil <jan.kratochvil@redhat.com>
1376
1377 * testsuite/binutils-all/dw5.S: New file.
1378 * testsuite/binutils-all/dw5.W: New file.
1379 * testsuite/binutils-all/readelf.exp (readelf -wiaoRlL): New test.
1380
1381 2017-02-23 Jan Kratochvil <jan.kratochvil@redhat.com>
1382
1383 * dwarf.c (read_and_display_attr_value): Support DW_FORM_data16.
1384
1385 2017-02-23 Jan Kratochvil <jan.kratochvil@redhat.com>
1386
1387 * dwarf.c (display_debug_macro): Support DWARF-5. Rename
1388 DW_MACRO_GNU_*.
1389
1390 2017-02-23 Jan Kratochvil <jan.kratochvil@redhat.com>
1391
1392 * dwarf.c (decode_location_expression): Support DW_OP_implicit_pointer,
1393 DW_OP_const_type, DW_OP_regval_type, DW_OP_deref_type, DW_OP_convert
1394 and DW_OP_reinterpret.
1395 (read_and_display_attr_value): Support DW_AT_call_value,
1396 DW_AT_call_data_value, DW_AT_call_target and
1397 DW_AT_call_target_clobbered.
1398
1399 2017-02-23 Jan Kratochvil <jan.kratochvil@redhat.com>
1400
1401 * dwarf.c (fetch_indirect_line_string): New function.
1402 (abbrev_attr): New field implicit_const.
1403 (add_abbrev_attr): New parameter implicit_const.
1404 (process_abbrev_section): Support DW_FORM_implicit_const.
1405 (decode_location_expression): Support DW_OP_entry_value.
1406 (read_and_display_attr_value): Add parameter implicit_const. Support
1407 DW_FORM_line_strp and DW_FORM_implicit_const.
1408 (read_and_display_attr): Add parameter implicit_const.
1409 (process_debug_info): Support line_str and DWARF-5.
1410 (read_debug_line_header): Support DWARF-5.
1411 (display_formatted_table): New function.
1412 (display_debug_lines_raw): New parameter file. Support DWARF-5.
1413 (display_debug_lines_decoded): New parameter fileptr. Support DWARF-5.
1414 (display_debug_lines): Pass file parameter.
1415 (display_debug_macro): Update read_and_display_attr_value caller.
1416 (display_debug_abbrev): Support DW_FORM_implicit_const.
1417 (display_loclists_list): New function.
1418 (display_loc_list): Support .debug_loclists.
1419 (display_debug_ranges_list): New function from display_debug_ranges.
1420 (display_debug_rnglists_list): New function.
1421 (display_debug_ranges): Support .debug_rnglists.
1422 (debug_displays): Add .debug_line_str, .debug_loclists and
1423 .debug_rnglists.
1424 * dwarf.h: Include dwarf2.h
1425 (DWARF2_Internal_LineInfo): Add li_offset_size.
1426 (DWARF2_Internal_CompUnit): Add cu_unit_type.
1427 (enum dwarf_section_display_enum): Add line_str.
1428 * readelf.c (process_section_headers): Add rnglists and loclists.
1429
1430 2017-02-23 Jan Kratochvil <jan.kratochvil@redhat.com>
1431
1432 * dwarf.c (display_block): Add parameter delimiter.
1433 (decode_location_expression): Update display_block callers.
1434 (read_and_display_attr_value): Add parameter delimiter.
1435 (read_and_display_attr, display_debug_macro): Update
1436 read_and_display_attr_value caller.
1437
1438 2017-02-23 Jan Kratochvil <jan.kratochvil@redhat.com>
1439
1440 * dwarf.c (display_loc_list): Use dwarf_vma for offset, base_address
1441 and off.
1442 (display_loc_list_dwo): Use dwarf_vma for offset.
1443 (display_debug_loc): Use dwarf_vma for offset, base_address.
1444 (struct range_entry, range_entry_compar): Use dwarf_vma for
1445 ranges_offset.
1446 (display_debug_ranges): Use dwarf_vma for ranges_offset, offset and
1447 base_address.
1448
1449 2017-02-23 Nick Clifton <nickc@redhat.com>
1450
1451 * readelf.c (display_tag_value): Use an explicit signed type for
1452 the tag parameter.
1453 (display_gnu_attributes): Use an unsigned integer type for
1454 attribute tags.
1455 (display_power_gnu_attribute): Likewise.
1456 (display_s390_gnu_attribute): Likewise.
1457 (display_sparc_hwcaps): Likewise.
1458 (display_sparc_hwcaps2): Likewise.
1459 (display_sparc_gnu_attribute): Likewise.
1460 (display_mips_gnu_attribute): Likewise.
1461 (display_tic6x_attribute): Likewise.
1462 (display_raw_attribute): Likewise.
1463 (process_attributes): Likewise.
1464 (process_arm_specific): Delete redundant function.
1465 (process_power_specific): Likewise.
1466 (process_s390_specific): Likewise.
1467 (process_sparc_specific): Likewise.
1468 (process_tic6x_specific): Likewise.
1469 (process_msp430x_specific): Likewise.
1470 (display_public_gnu_attributes): New function. Displays known
1471 information about an unknown gnu attribute.
1472 (display_generic_attribute): New function. Calls
1473 display_tag_value for non-nul tags.
1474 (process_arch_specific): Call process_attributes even for
1475 architectures not known to specifically support gnu attributes.
1476
1477 2017-02-22 Jan Kratochvil <jan.kratochvil@redhat.com>
1478
1479 * dwarf.c (decode_location_expression): Display also OP.
1480
1481 2017-02-22 Maciej W. Rozycki <macro@imgtec.com>
1482
1483 * readelf.c (process_version_sections) <SHT_GNU_verdef>: Print a
1484 new line between the heading and the first version definition
1485 entry.
1486
1487 2017-02-20 Nick Clifton <nickc@redhat.com>
1488
1489 PR binutils/21156
1490 * dwarf.c (cu_tu_indexes_read): Move into...
1491 (load_cu_tu_indexes): ... here. Change the variable into
1492 tri-state. Change the function into boolean, returning
1493 false if the indicies could not be loaded.
1494 (find_cu_tu_set): Return NULL if the indicies could not be
1495 loaded.
1496
1497 2017-02-17 Nick Clifton <nickc@redhat.com>
1498
1499 PR binutils/21156
1500 * readelf.c (find_section_in_set): Test for invalid section
1501 indicies.
1502
1503 2017-02-17 Nick Clifton <nickc@redhat.com>
1504
1505 * readelf.c (get_section_type_name): Add decoding of GNU section
1506 types.
1507
1508 2017-02-15 Nick Clifton <nickc@redhat.com>
1509
1510 * MAINTAINERS: (MIPS, MN10300): Move Eric Christopher to Past
1511 Maintainers section.
1512
1513 2017-02-14 Nick Clifton <nickc@redhat.com>
1514
1515 PR binutils/21159
1516 * readelf.c (dump_section_as_strings): Reset the start address if
1517 no decompression is perfromed.
1518 (dump_section_as_bytes): Likewise.
1519
1520 2017-02-14 Nick Clifton <nickc@redhat.com>
1521
1522 PR binutils/21158
1523 * rddbg.c (read_symbol_stabs_debugging_info): Check for a null or
1524 empty symbol name.
1525
1526 2017-02-14 Nick Clifton <nickc@redhat.com>
1527
1528 PR binutils/21157
1529 * stabs.c (parse_stab_enum_type): Check for corrupt NAME:VALUE
1530 pairs.
1531 (parse_number): Exit early if passed an empty string.
1532
1533 2017-02-14 Nick Clifton <nickc@redhat.com>
1534
1535 PR binutils/21155
1536 * readelf.c (IN_RANGE): New macro. Tests for an address + offset
1537 being within a given range.
1538 (target_specific_reloc_handling): Use macro to test for underflow
1539 as well as overflow of reloc offset.
1540
1541 2017-02-13 Nick Clifton <nickc@redhat.com>
1542
1543 PR binutils/21150
1544 * nm.c (file_symbol): Add test of string length before testing
1545 string characters.
1546
1547 2017-02-13 Nick Clifton <nickc@redhat.com>
1548
1549 PR binutils/21135
1550 * readelf.c (dump_section_as_bytes): Handle the case where
1551 uncompress_section_contents returns false.
1552 (dump_section_as_bytes, load_specific_debug_section): Likewise.
1553
1554 2017-02-13 Nick Clifton <nickc@redhat.com>
1555
1556 PR binutils/21149
1557 * readelf.c (get_compression_header): Add size parameter. Check
1558 size against sizeof compression header before attempting to
1559 extract the header.
1560 (process_section_headers): Pass size to get_compression_header.
1561 (dump_section_as_strings): Likewise.
1562 (dump_section_as_bytes): Likewise.
1563 (load_specific_debug_section): Likewise.
1564
1565 2017-02-13 Nick Clifton <nickc@redhat.com>
1566
1567 PR binutils/21148
1568 * readelf.c (process_version_sections): Include size of auxillary
1569 version information when checking for buffer overflow.
1570
1571 2017-02-13 Nick Clifton <nickc@redhat.com>
1572
1573 PR binutils/21147
1574 * readelf.c (process_section_contents): Fix off by one error
1575 reporting un-dumped sections.
1576
1577 2017-02-13 Nick Clifton <nickc@redhat.com>
1578
1579 PR binutils/21139
1580 * readelf.c (target_specific_reloc_handling): Add num_syms
1581 parameter. Check for symbol table overflow before accessing
1582 symbol value. If reloc pointer is NULL, discard all saved state.
1583 (apply_relocations): Pass num_syms to target_specific_reloc_handling.
1584 Call target_specific_reloc_handling with a NULL reloc pointer
1585 after processing all of the relocs.
1586
1587 2017-02-13 Nick Clifton <nickc@redhat.com>
1588
1589 PR binutils/21137
1590 * readelf.c (target_specific_reloc_handling): Add end parameter.
1591 Check for buffer overflow before writing relocated values.
1592 (apply_relocations): Pass end to target_specific_reloc_handling.
1593
1594 2017-01-27 Dilyan Palauzov <dilyan.palauzov@aegee.org>
1595 Nick Clifton <nickc@redhat.com>
1596
1597 PR 20343
1598 * doc/binutils.texi (ar): Extend documentation of the --plugin
1599 option. Include a description of where the plugins should be
1600 located.
1601 (nm): Likewise.
1602
1603 2017-01-23 Nick Clifton <nickc@redhat.com>
1604
1605 * MAINTAINERS: Add Bernd to Past Maintainers section.
1606 (SCORE): Remove Mei Ligang as maintainer. Add to Past Maintainers
1607 section.
1608
1609 2017-01-23 Bernd Schmidt <bschmidt@redhat.com>
1610
1611 * MAINTAINERS (BFIN): Remove myself as Blackfin maintainer.
1612
1613 2017-01-20 Andrew Burgess <andrew.burgess@embecosm.com>
1614
1615 * objdump.c (dump_section_header): Extract max section name length
1616 from data parameter, use this when formatting output.
1617 (find_longest_section_name): New function.
1618 (dump_headers): Calculate longest section name when in wide mode,
1619 reformat to unify printing of header line.
1620
1621 2017-01-18 Bernhard Rosenkranzer <bero@lindev.ch>
1622
1623 PR 21059
1624 * arlex.l: Support processing with flex 2.6.3.
1625 * deflex.l: Likewise.
1626
1627 2017-01-17 Dmitry Timoshkov <dmitry@baikal.ru>
1628
1629 * resbin.c: Optional dialog control data immediately follows
1630 the control description without alignment.
1631 * testsuite/binutils-all/windres/controldata.rc: New test.
1632 source.
1633 * testsuite/binutils-all/windres/controldata.rsd: New test.
1634
1635 2017-01-12 Nick Clifton <nickc@redhat.com>
1636
1637 PR binutils/20876
1638 * NEWS: Mention the new feature.
1639 * testsuite/binutils-all/objdump.exp (test_build_id_debuglink):
1640 New proc to test the location of separate debug info files using
1641 the build-id method.
1642
1643 2017-01-10 Nick Clifton <nickc@redhat.com>
1644
1645 PR 21034
1646 * stabs.c (parse_stab_members): Fix thinko checking for g++
1647 version 1 stabs information.
1648
1649 2017-01-09 Nick Clifton <nickc@redhat.com>
1650
1651 * objdump.c (display_file): Add new parameter 'last_file'. If
1652 last_file is true, do not call bfd_close at the end of the
1653 function.
1654 (main): Set the value of the last_file parameter when calling
1655 display_file.
1656
1657 2017-01-09 Alan Modra <amodra@gmail.com>
1658
1659 * readelf.c (process_section_headers): Correct .rel.dyn/.rela.dyn
1660 comment.
1661
1662 2017-01-06 Nick Clifton <nickc@redhat.com>
1663
1664 * MAINTAINERS: Move Paul Brook to the Past Maintainers section.
1665
1666 2017-01-04 Dilan Palauzov <dilyan.palauzov@aegee.org>
1667
1668 PR 20958
1669 * syslex.l (option): Add noyywrap
1670 (yywrap): Delete.
1671
1672 2017-01-02 Alan Modra <amodra@gmail.com>
1673
1674 Update year range in copyright notice of all files.
1675
1676 For older changes see ChangeLog-2016
1677 \f
1678 Copyright (C) 2017 Free Software Foundation, Inc.
1679
1680 Copying and distribution of this file, with or without modification,
1681 are permitted in any medium without royalty provided the copyright
1682 notice and this notice are preserved.
1683
1684 Local Variables:
1685 mode: change-log
1686 left-margin: 8
1687 fill-column: 74
1688 version-control: never
1689 End: