gdb/ChangeLog

   1 2019-07-22  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
   4         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
   5         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
   6         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
   7         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
   8
   9
  10 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  11
  12         * h8300-tdep.c (h8300_register_name_common): New.
  13         h8300_register_name): Use h8300_register_name_common.
  14         (h8300s_register_name): Likewise.
  15         (h8300sx_register_name): Likewise.
  16         (h8300h_register_nam): New.
  17         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  18
  19
  20 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  21
  22         * arm-tdep.c (arm_skip_cmse_entry): New function.
  23         (arm_is_sgstubs_section): New function.
  24         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  25
  26 2019-07-22  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  29         Don't self-assign.
  30
  31 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  32
  33         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  34         type_print.
  35
  36 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  37
  38         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  39         so that GDB doesn't match any msymbols when searching in the
  40         TYPES_DOMAIN.
  41         (print_symbol_info): Print using typedef_print or type_print based
  42         on the type of the symbol.  Add updated FIXME comment moved from...
  43         (_initialize_symtab): ... move and update FIXME comment to above.
  44
  45 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  46
  47         * NEWS: Mention adding -q option to "info types".
  48         * symtab.c (struct info_types_options): New struct.
  49         (info_types_options_defs): New variable.
  50         (make_info_types_options_def_group): New function.
  51         (info_types_command): Use gdb::option framework to parse options.
  52         (info_types_command_completer): New function.
  53         (_initialize_symtab): Extend the help text on "info types" and
  54         register command completer.
  55
  56 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  57
  58         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  59         (lookup_symbol_in_objfile): Change int to block_enum and add a
  60         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  61
  62 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  63
  64         * MAINTAINERS (Write After Approval): Add self.
  65
  66 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  67
  68         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  69         instruction to the dummy code region.
  70
  71 2019-07-19  Tom Tromey  <tromey@adacore.com>
  72
  73         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  74         (ARGSUSED, PARAMS, __func__): Remove rules.
  75
  76 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  77
  78         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  79         * features/arm/arm-with-iwmmxt.c: Remove.
  80         * features/arm/arm-with-iwmmxt.xml: Remove.
  81         * features/arm/arm-with-m-fpa-layout.c: Remove.
  82         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  83         * features/arm/arm-with-m-vfp-d16.c: Remove.
  84         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  85         * features/arm/arm-with-m.c: Remove.
  86         * features/arm/arm-with-m.xml: Remove.
  87         * features/arm/arm-with-neon.c: Remove.
  88         * features/arm/arm-with-neon.xml: Remove.
  89         * features/arm/arm-with-vfpv2.c: Remove.
  90         * features/arm/arm-with-vfpv2.xml: Remove.
  91         * features/arm/arm-with-vfpv3.c: Remove.
  92         * features/arm/arm-with-vfpv3.xml: Remove.
  93
  94 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  95
  96         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  97
  98 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  99
 100         * arch/aarch32.c (aarch32_create_target_description): Create
 101         target descriptions using features.
 102         * arch/arm.c (arm_create_target_description)
 103         (arm_create_mprofile_target_description): Likewise.
 104         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 105
 106 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 107
 108         * Makefile.in: Add new files.
 109         * aarch32-tdep.c: New file.
 110         * aarch32-tdep.h: New file.
 111         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 112         Call aarch32_read_description.
 113         * arch/aarch32.c: New file.
 114         * arch/aarch32.h: New file.
 115         * arch/arm.c (arm_create_target_description)
 116         (arm_create_mprofile_target_description): New function.
 117         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 118         (arm_create_target_description)
 119         (arm_create_mprofile_target_description): New declaration.
 120         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 121         read_description functions.
 122         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 123         Likewise.
 124         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 125         * arm-tdep.c (tdesc_arm_list): New variable.
 126         (arm_register_g_packet_guesses): Call create description functions.
 127         (arm_read_description) (arm_read_mprofile_description): New
 128         function.
 129         * arm-tdep.h (arm_read_description)
 130         (arm_read_mprofile_description): Add declaration.
 131         * configure.tgt: Add new files.
 132
 133 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 134
 135         * top.c (new_ui_command): Open specified terminal just once.
 136
 137 2019-07-18  Tom Tromey  <tromey@adacore.com>
 138
 139         * symtab.c (main_name): Constify return type.
 140         * symfile.c (set_initial_language): Update.
 141         * symtab.h (main_name): Constify return type.
 142
 143 2019-07-17  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-winsource.c (tui_update_source_window)
 146         (tui_update_source_window_as_is)
 147         (tui_update_source_windows_with_line): Remove return.
 148         * tui/tui-disasm.c (tui_show_disassem)
 149         (tui_show_disassem_and_update_source): Remove return.
 150         * tui/tui.c (tui_reset): Remove return.
 151         * tui/tui-wingeneral.c
 152         (tui_check_and_display_highlight_if_needed): Remove return.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 157
 158 2019-07-17  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-winsource.h (struct tui_exec_info_window)
 161         (struct tui_source_window_base): Move from tui-data.h.
 162         * tui/tui-winsource.c: Move many method definitions from
 163         elsewhere.  Remove "structuring" comments.
 164         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 165         (tui_source_window_base::refresh_window): Move to
 166         tui-winsource.c.
 167         * tui/tui-win.c (tui_source_window_base::refresh_all)
 168         (tui_source_window_base::update_tab_width)
 169         (tui_source_window_base::set_new_height)
 170         (tui_source_window_base::do_make_visible_with_new_height): Move to
 171         tui-winsource.c.
 172         * tui/tui-source.h: Update.
 173         * tui/tui-source.c (tui_source_window_base::reset): Move to
 174         tui-winsource.c.
 175         * tui/tui-disasm.h: Update.
 176         * tui/tui-data.h (struct tui_exec_info_window): Move to
 177         tui-winsource.h.
 178         (struct tui_source_window_base): Likewise.
 179         * tui/tui-data.c (tui_source_window_base::clear_detail)
 180         (tui_source_window_base, ~tui_source_window_base): Move to
 181         tui-winsource.c.
 182
 183 2019-07-17  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-win.c (tui_resize_all)
 186         (tui_source_window_base::update_tab_width)
 187         (tui_adjust_win_heights): Update.
 188         (tui_win_info::make_invisible_and_set_new_height): Rename from
 189         make_invisible_and_set_new_height.
 190         * tui/tui-data.h (struct tui_win_info)
 191         <make_invisible_and_set_new_height>: New method.
 192
 193 2019-07-17  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui.c: Update.
 196         * tui/tui-source.h (struct tui_source_window): Move from
 197         tui-data.h.
 198         * tui/tui-layout.c: Update.
 199         * tui/tui-disasm.c: Update.
 200         * tui/tui-data.h (struct tui_source_window): Move to
 201         tui-source.h.
 202
 203 2019-07-17  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 206         tui-data.h.
 207         * tui/tui-data.h (struct tui_disasm_window): Move to
 208         tui-disasm.h.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-regs.h (struct tui_data_item_window): Move from
 213         tui-data.h.
 214         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 215         * tui/tui-data.h (struct tui_data_item_window): Move to
 216         tui-regs.h.
 217         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui.c: Update.
 222         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 223         (tui_cmd_window::max_height): Move to tui-command.c.
 224         * tui/tui-layout.c: Update.
 225         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 226         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 227         tui-command.c.
 228         * tui/tui-command.h (struct tui_cmd_window): Move from
 229         tui-data.h.
 230         * tui/tui-command.c: Remove "structuring" comments.
 231         (tui_cmd_window::clear_detail)
 232         (tui_cmd_window::do_make_visible_with_new_height)
 233         (tui_cmd_window::max_height): Move from elsewhere.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 238         Now static.
 239         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 240         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 241
 242 2019-07-17  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui.c: Update.
 245         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 246         tui-regs.c.
 247         * tui/tui-windata.h: Remove file.
 248         * tui/tui-windata.c: Remove file.
 249         * tui/tui-win.c (tui_data_window::set_new_height)
 250         (tui_data_window::do_make_visible_with_new_height): Move to
 251         tui-regs.c.
 252         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 253         * tui/tui-regs.c: Remove "structuring" comments.
 254         (tui_data_window::first_data_item_displayed)
 255         (tui_data_window::delete_data_content_windows)
 256         (tui_data_window::erase_data_content)
 257         (tui_data_window::display_all_data)
 258         (tui_data_window::refresh_all)
 259         (tui_data_window::do_scroll_vertical)
 260         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 261         (tui_data_window::do_make_visible_with_new_height)
 262         (tui_data_window::refresh_window): Move from elsewhere.
 263         (_initialize_tui_regs): Move to end of file.
 264         * tui/tui-layout.c: Update.
 265         * tui/tui-hooks.c: Update.
 266         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 267         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 268         tui-regs.c.
 269         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 274         seen.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-win.c (tui_source_window_base::set_new_height)
 279         (tui_source_window_base::do_make_visible_with_new_height): Use
 280         m_has_locator field directly.
 281         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 282         method.
 283         (struct tui_source_window_base) <has_locator>: Likewise.
 284
 285 2019-07-17  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 288         Don't declare.
 289         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 290         Remove.
 291         * tui/tui-win.c (tui_source_window_base::set_new_height)
 292         (tui_source_window_base::set_new_height)
 293         (make_invisible_and_set_new_height)
 294         (tui_source_window_base::do_make_visible_with_new_height)
 295         (tui_source_window_base::do_make_visible_with_new_height):
 296         Update.
 297         * tui/tui-layout.c (show_source_disasm_command, show_data)
 298         (show_source_or_disasm_and_command): Update.
 299         * tui/tui-layout.c (show_layout): Update.
 300
 301 2019-07-17  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-layout.c (make_data_window): Remove.
 304         (show_data): Unify creation and re-initialization cases.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-layout.c (make_source_window, make_disasm_window):
 309         Remove.
 310         (show_data): Unify creation and re-initialization cases.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-layout.c (make_command_window): Remove.
 315         (show_source_disasm_command, show_source_or_disasm_and_command):
 316         Unify creation and re-initialization cases.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 321         creation and re-initialization cases.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-regs.c (tui_get_register): Return void.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 330         Simplify.
 331
 332 2019-07-17  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 335         resetting.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 340         * tui/tui-regs.c (tui_reg_layout): New function.
 341         (tui_show_registers, tui_reg_command): Use it.
 342         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 343         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 344         parameters.
 345         (tui_layout_command): Remove.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-layout.h (tui/tui-layout): Return void.
 350         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-layout.c (show_source_disasm_command, show_data):
 355         Update.
 356         (reset_locator): Remove.
 357         (show_source_or_disasm_and_command): Update.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-source.c (tui_source_window_base::reset): Remove
 362         win_type parameter.
 363         * tui/tui-layout.c (make_command_window, make_source_window)
 364         (make_disasm_window, make_data_window)
 365         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 366         (reset_locator, show_source_or_disasm_and_command): Update.
 367         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 368         win_type parameter.
 369         (struct tui_source_window_base) <reset>: Likewise.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-layout.c (show_source_disasm_command): Use
 374         reset_locator.
 375         (reset_locator): New function.
 376         (init_and_make_win): Remove.
 377         (show_source_or_disasm_and_command): Use reset_locator.
 378
 379 2019-07-17  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 382         condition.
 383         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 384         Remove condition.
 385         * tui/tui-source.c (tui_source_window_base::reset): New method.
 386         * tui/tui-layout.c (make_command_window): Don't call
 387         init_and_make_win.
 388         (make_source_window, make_disasm_window): Don't call
 389         make_source_or_disasm_window.
 390         (make_data_window): Don't call init_and_make_win.  Change calling
 391         convention.
 392         (show_source_disasm_command, show_data): Simplify.
 393         (make_source_or_disasm_window): Remove.
 394         (show_source_or_disasm_and_command): Simplify.
 395         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 396         (struct tui_source_window_base) <reset>: Likewise.
 397         <execution_info>: Remove initializer.
 398         * tui/tui-data.c (tui_source_window_base): Initialize
 399         execution_info.
 400
 401 2019-07-17  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 404         variable.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui.c (tui_rl_other_window): Update.
 409         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 410         superclass method first.  Always iterate over regs_content.
 411         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 412         method.
 413         * tui/tui-win.c (tui_set_focus_command): Update.
 414
 415 2019-07-17  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-win.c (tui_set_focus_command): Rename from
 418         tui_set_focus.  Call tui_enable.
 419         (tui_set_focus_command): Remove.
 420
 421 2019-07-17  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 424         refresh_window.
 425         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 426         touchwin.
 427         (tui_data_window::refresh_window): Call refresh_window on data
 428         items.  Always call superclass refresh_window.
 429         (tui_win_info::refresh): Remove.
 430         (tui_source_window_base::refresh_window): Update.
 431         (tui_refresh_all): Update.
 432         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 433         refresh_window.
 434         (show_source_or_disasm_and_command): Likewise.
 435         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 436         (struct tui_source_window_base) <refresh>: Likewise.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.c (tui_clear_source_content)
 441         (tui_show_source_content): Update.
 442         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 443         whether content is empty.
 444         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 445         Remove.
 446
 447 2019-07-17  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 450         window's contents.
 451         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 452         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 453
 454 2019-07-17  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 457         (struct tui_data_item_window): Update.
 458
 459 2019-07-17  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 462         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 463         defines.
 464
 465 2019-07-17  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-winsource.h (tui_erase_source_content)
 468         (tui_clear_source_content): Remove "display_prompt" parameter.
 469         * tui/tui-winsource.c (tui_update_source_window_as_is)
 470         (tui_update_source_windows_with_addr): Update.
 471         (tui_clear_source_content): Remove "display_prompt" parameter.
 472         (tui_erase_source_content): Likewise.  Simplify.
 473         (tui_show_source_content): Update.
 474         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 475         * tui/tui-stack.c (tui_show_frame_info): Update.
 476         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 477         Remove defines.
 478
 479 2019-07-17  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 482         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 483         parameter.
 484         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 485         parameter.
 486
 487 2019-07-17  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-winsource.c (tui_clear_source_content)
 490         (tui_show_source_content, tui_show_exec_info_content)
 491         (tui_clear_exec_info_content): Update.
 492         * tui/tui-stack.c (tui_show_locator_content): Update.
 493         (tui_show_frame_info): Update.
 494         * tui/tui-source.h (tui_source_window): Don't declare.
 495         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 496         from tui_source_is_displayed.
 497         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 498         Remove field.
 499         (struct tui_source_window_base) <content_in_use>: New field.  Now
 500         bool.
 501         (struct tui_source_window) <showing_source_p>: New method.
 502         (TUI_SRC_WIN): Change cast.
 503         * tui/tui-data.c (tui_initialize_static_data): Update.
 504
 505 2019-07-17  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 508         location_matches_p.
 509         * tui/tui-source.c (tui_source_window::location_matches_p): New
 510         method.
 511         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 512         method.
 513         * tui/tui-data.h (struct tui_source_window_base)
 514         <location_matches_p>: New method.
 515         (struct tui_source_window, struct tui_disasm_window)
 516         <location_matches_p>: Likewise.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-win.c (tui_set_win_height_command): Rename from
 521         tui_set_win_height.
 522         (tui_set_win_height_command): Remove.
 523
 524 2019-07-17  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-source.c (tui_source_window): New constructor.  Add
 527         observer.
 528         (~tui_source_window): New destructor.
 529         (tui_source_window::style_changed): New method.
 530         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 531         (tui_attach_detach_observers): Update.
 532         * tui/tui-data.h (struct tui_source_window): Make constructor not
 533         inline.  Add destructor.
 534         (struct tui_source_window) <style_changed>: New method.
 535         <m_observable>: New member.
 536
 537 2019-07-17  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 540         * tui/tui-win.c (tui_resize_all): Fix typo.
 541
 542 2019-07-17  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 545         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 546         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 547         * tui/tui-win.c (window_name_completer): Use foreach.
 548         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 549         (update_tab_width): Likewise.
 550         * tui/tui-layout.c (show_layout): Update.
 551         * tui/tui-data.h (class tui_window_iterator): New.
 552         (struct all_tui_windows): New.
 553         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 558         parameter.  Don't reference globals.
 559         (tui_reg_command): Update.
 560
 561 2019-07-17  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-regs.c (tui_show_registers): Simplify.
 564
 565 2019-07-17  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-regs.c (tui_show_registers): Update.
 568         (tui_show_register_group): Add win_info parameter.
 569
 570 2019-07-17  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 573         Rename from tui_display_reg_element_at_line.
 574         (tui_data_window::display_registers_from_line): Update.
 575         * tui/tui-data.h (struct tui_data_window)
 576         <display_reg_element_at_line>: New method.
 577
 578 2019-07-17  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-regs.h (tui_display_registers_from)
 581         (tui_display_registers_from_line): Don't declare.
 582         * tui/tui-windata.c (tui_data_window::display_all_data)
 583         (tui_data_window::refresh_all)
 584         (tui_data_window::do_scroll_vertical): Update.
 585         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 586         from tui_display_registers_from.
 587         (tui_display_reg_element_at_line): Update.
 588         (tui_data_window::display_registers_from_line): Rename from
 589         tui_display_registers_from_line.
 590         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 591         display_registers_from_line>: New methods.
 592
 593 2019-07-17  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 596         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 597         from tui_erase_data_content.
 598         (tui_data_window::display_all_data)
 599         (tui_data_window::refresh_all)
 600         (tui_data_window::do_scroll_vertical): Update.
 601         * tui/tui-regs.c (tui_show_registers): Update.
 602         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 603         New method.
 604
 605 2019-07-17  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 608         declare.
 609         * tui/tui-windata.c
 610         (tui_data_window::delete_data_content_windows): Rename from
 611         tui_delete_data_content_windows.
 612         (tui_data_window::display_all_data)
 613         (tui_data_window::do_scroll_vertical): Update.
 614         * tui/tui-data.h (struct tui_data_window)
 615         <delete_data_content_windows>: New method.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 620         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 625         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 626         from tui_display_all_data.
 627         * tui/tui-win.c
 628         (tui_data_window::do_make_visible_with_new_height): Update.
 629         * tui/tui-regs.c (tui_show_registers): Update.
 630         * tui/tui-layout.c (tui_set_layout): Update.
 631         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 632         method.
 633
 634 2019-07-17  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 637         * tui/tui-windata.c (tui_display_data_from): Remove.
 638         (tui_data_window::refresh_all): Update.
 639
 640 2019-07-17  Tom Tromey  <tom@tromey.com>
 641
 642         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 643         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 644         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 645         tui_display_registers_from_line.
 646         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 647         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 648         "force_display" parameter.
 649
 650 2019-07-17  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 653         declare.
 654         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 655         Rename from tui_first_reg_element_no_inline.
 656         (tui_display_reg_element_at_line)
 657         (tui_display_registers_from_line): Update.
 658         * tui/tui-data.h (struct tui_data_window)
 659         <first_reg_element_no_inline>: New method.
 660
 661 2019-07-17  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-windata.c (tui_display_data_from)
 664         (tui_data_window::do_scroll_vertical): Update.
 665         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 666         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 667         Rename from tui_line_from_reg_element_no.
 668         (tui_display_registers_from_line): Update.
 669         * tui/tui-data.h (struct tui_data_window)
 670         <line_from_reg_element_no>: New method.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 675         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 676         tui_last_regs_line_no.
 677         (tui_display_reg_element_at_line)
 678         (tui_display_registers_from_line): Update.
 679         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 680         method.
 681
 682 2019-07-17  Tom Tromey  <tom@tromey.com>
 683
 684         PR tui/24722:
 685         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 686         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 687         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 688         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 689         (tui_update_breakpoint_info): Likewise.
 690         * tui/tui-hooks.c (tui_event_create_breakpoint)
 691         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 692         Update.
 693
 694 2019-07-17  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 697
 698 2019-07-17  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-winsource.c (tui_update_source_window_as_is)
 701         (tui_update_source_windows_with_addr): Update.
 702         * tui/tui-source.h (tui_set_source_content)
 703         (tui_show_symtab_source): Add "win_info" parameter.
 704         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 705         parameter.
 706         (tui_show_symtab_source): Likewise.
 707
 708 2019-07-17  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-wingeneral.c
 711         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 712
 713 2019-07-17  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 716         (struct tui_cmd_window) <can_scroll>: New method.
 717         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 718         method.
 719
 720 2019-07-17  Tom Tromey  <tromey@adacore.com>
 721
 722         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 723         do_field_signed>: Rename.  Change type of "value".
 724         * ui-out.c (ui_out::field_signed): Rename from field_int.
 725         Change type of "value".
 726         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 727         type of "value".
 728         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 729         do_field_int.  Change type of "value".
 730         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 731         do_field_int.  Change type of "value".
 732         * tracepoint.c (trace_status_mi, tfind_1)
 733         (print_one_static_tracepoint_marker): Update.
 734         * thread.c (print_thread_info_1, print_selected_thread_frame):
 735         Update.
 736         * stack.c (print_frame, print_frame_info): Update.
 737         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 738         Update.
 739         * source.c (print_source_lines_base): Update.
 740         * skip.c (info_skip_command): Update.
 741         * record-btrace.c (btrace_ui_out_decode_error)
 742         (btrace_call_history_src_line): Update.
 743         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 744         Update.
 745         * progspace.c (print_program_space): Update.
 746         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 747         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 748         do_field_int.  Change type of "value".
 749         * mi/mi-out.c (mi_ui_out::do_table_begin)
 750         (mi_ui_out::do_table_header): Update.
 751         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 752         type of "value".
 753         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 754         (mi_cmd_data_list_changed_registers, output_register)
 755         (mi_cmd_data_read_memory, mi_load_progress)
 756         (mi_cmd_trace_frame_collected): Update.
 757         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 758         Update.
 759         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 760         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 761         (mi_cmd_var_list_children, varobj_update_one): Update.
 762         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 763         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 765         * inferior.c (print_inferior): Update.
 766         * gdb_bfd.c (print_one_bfd): Update.
 767         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 768         Update.
 769         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 770         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 771         do_field_int.  Change type of "value".
 772         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 773         do_field_int.  Change type of "value".
 774         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 775         (print_one_breakpoint_location, print_it_catch_fork)
 776         (print_one_catch_fork, print_it_catch_vfork)
 777         (print_one_catch_vfork, print_it_catch_solib)
 778         (print_it_catch_exec, print_it_ranged_breakpoint)
 779         (print_mention_watchpoint, print_mention_masked_watchpoint)
 780         (bkpt_print_it, update_static_tracepoint): Update.
 781         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 782         * break-catch-syscall.c (print_it_catch_syscall): Update.
 783         * ada-tasks.c (print_ada_task_info): Update.
 784         * ada-lang.c (print_it_exception, print_mention_exception):
 785         Update.
 786
 787 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         PR breakpoints/24541
 790         * gdbarch.c: Regenerate.
 791         * gdbarch.h: Regenerate.
 792         * gdbarch.sh: Adjust return type and parameter types for
 793         'stap_adjust_register'.
 794         (i386_stap_adjust_register): Adjust signature and return new
 795         register name.
 796         * stap-probe.c (stap_parse_register_operand): Adjust use of
 797         'gdbarch_stap_adjust_register'.
 798
 799 2019-07-17  Tom Tromey  <tromey@adacore.com>
 800
 801         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 802         declare VEC.
 803         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 804         std::vector.
 805         (struct s390_process_info): Add initializers.
 806         (s390_add_process): Use new.
 807         (s390_linux_nat_target::low_forget_process): Use delete.
 808         (s390_linux_nat_target::low_new_fork)
 809         (s390_linux_nat_target::stopped_by_watchpoint)
 810         (s390_linux_nat_target::low_prepare_to_resume)
 811         (s390_linux_nat_target::insert_watchpoint)
 812         (s390_linux_nat_target::insert_hw_breakpoint)
 813         (s390_linux_nat_target::remove_watchpoint)
 814         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 815
 816 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 817
 818         * aarch64-fbsd-nat.c: Include regcache.h.
 819         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 820         argument.
 821         (aarch64_fbsd_nat_target::fetch_registers)
 822         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 823         variable.
 824         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 825
 826 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 827
 828         * fbsd-nat.c: Include gdbarch.h.
 829
 830 2019-07-15  Tom Tromey  <tromey@adacore.com>
 831
 832         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 833
 834 2019-07-15  Tom Tromey  <tromey@adacore.com>
 835
 836         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 837         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 838         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 839         * cli-out.c (cli_ui_out::do_field_int): New method.
 840         * ui-out.c (ui_out::field_unsigned): New method.
 841         * symfile.c (generic_load): Use field_unsigned.
 842         (print_transfer_performance): Likewise.
 843         * record-btrace.c (ui_out_field_uint): Remove.
 844         (btrace_call_history_insn_range, btrace_call_history): Use
 845         field_unsigned.
 846         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 847         field_unsigned.
 848         * ui-out.h (class ui_out) <field_unsigned>: New method.
 849         <do_field_unsigned>: Likewise.
 850
 851 2019-07-15  Tom Tromey  <tromey@adacore.com>
 852
 853         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 854         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 855         * target.c (flash_erase_command): Use field_string.
 856         * infrun.c (print_signal_received_reason): Use field_string.
 857         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 858         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 859         field_string.
 860         * ada-tasks.c (print_ada_task_info): Use field_string.
 861
 862 2019-07-15  Tom Tromey  <tromey@adacore.com>
 863
 864         * target.c (flash_erase_command): Use field_core_addr.
 865         * symfile.c (generic_load): Use field_core_addr.
 866         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 867         Use field_core_addr.
 868         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 869         field_core_addr.
 870
 871 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 872
 873         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 874         value if its desired type is smaller than a CORE_ADDR and signed.
 875
 876 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 879         of changes to field names, and use new is_reference field to
 880         decide if a property is a reference or not.
 881         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 882         field.
 883         (struct dwarf2_property_baton): Update header comment, rename
 884         'referenced_type' to 'property_type' and update comments.
 885         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 886         default property type, store in property baton, update to take
 887         accound of renamed field.
 888         (read_func_scope): Update call to attr_to_dynamic_prop.
 889         (read_array_type): Likewise.
 890         (dwarf2_per_cu_addr_sized_int_type): New function.
 891         (read_subrange_index_type): Move type finding code to
 892         dwarf2_per_cu_addr_sized_int_type.
 893         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 894         (dwarf2_per_cu_addr_type): New function.
 895         (set_die_type): Update calls to attr_to_dynamic_prop.
 896
 897 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 898
 899         * dwarf2read.c (read_subrange_index_type): New function.
 900         (read_subrange_type): Move code into new function and call it.
 901         * gdbtypes.c (create_range_type): Add some asserts.
 902
 903 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 904
 905         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 906         update return statements.
 907         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 908         declaration, and update comment to match.
 909         * gdbtypes.c (resolve_dynamic_array): Update call to
 910         dwarf2_evaluate_property to match new return type.
 911
 912 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * valarith.c (value_subscripted_rvalue): Change lowerbound
 915         parameter type from int to LONGEST.
 916         * value.h (value_subscripted_rvalue): Likewise in declaration.
 917
 918 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 919
 920         * cli/cli-utils.c (info_print_command_completer): New function.
 921         * cli/cli-utils.h: Add 'completer.h' include, and forward
 922         declaration for 'struct cmd_list_element'.
 923         (info_print_command_completer): Declare.
 924         * stack.c (_initialize_stack): Add completer for 'info locals' and
 925         'info args'.
 926         * symtab.c (_initialize_symtab): Add completer for 'info
 927         variables' and 'info functions'.
 928         * NEWS: Mention completion for additional info commands.
 929
 930 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * cli/cli-utils.c (extract_info_print_args): Delete.
 933         (extract_arg_maybe_quoted): Delete.
 934         (info_print_options_defs): New variable.
 935         (make_info_print_options_def_group): New function.
 936         (extract_info_print_options): Define new function.
 937         * cli/cli-utils.h (extract_info_print_args): Delete.
 938         (struct info_print_options): New structure.
 939         (extract_info_print_options): Declare new function.
 940         * stack.c (info_locals_command): Update to use new
 941         extract_info_print_options, also add a header comment.
 942         (info_args_command): Likewise.
 943         * symtab.c (info_variables_command): Likewise.
 944         (info_functions_command): Likewise.
 945
 946 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 949         to extract string arguments.
 950         * common/common-utils.c (extract_string_maybe_quoted): New function.
 951         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 952
 953 2019-07-11  Tom Tromey  <tromey@adacore.com>
 954
 955         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 956         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 957         * top.h (gdbinit): Don't declare.
 958         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 959         into...
 960         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 961         * top.c (gdb_init): Don't call init_cli_cmds.
 962         (gdbinit): Remove.
 963         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 964
 965 2019-07-11  Tom Tromey  <tromey@adacore.com>
 966
 967         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 968         after it has been moved.
 969
 970 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 971
 972         * valops.c (value_must_coerce_to_target): Change return type to
 973         bool.
 974         * value.h (value_must_coerce_to_target): Likewise.
 975
 976 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 977
 978         * breakpoint.c (is_hardware_watchpoint): Remove
 979         forward-declaration.
 980         (is_masked_watchpoint): Change return type to bool.
 981         (is_tracepoint): Likewise.
 982         (is_breakpoint): Likewise.
 983         (is_hardware_watchpoint): Likewise.
 984         (is_watchpoint): Likewise.
 985         (is_no_memory_software_watchpoint): Likewise.
 986         (is_catchpoint): Likewise.
 987         (breakpoint_1): Make FILTER parameter's return type bool.
 988         is_masked_watchpoint): Change return type to bool.
 989         (save_breakpoints): Make FILTER parameter's return type bool.
 990         * breakpoint.h (is_breakpoint): Change return type to bool.
 991         (is_watchpoint): Likewise.
 992         (is_catchpoint): Likewise.
 993         (is_tracepoint): Likewise.
 994
 995 2019-07-10  Tom Tromey  <tom@tromey.com>
 996
 997         * defs.h: Don't include gdbarch.h.
 998         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 999         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1000         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1001         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1002         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1003         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1004         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1005         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1006         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1007         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1008         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1009         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1010         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1011         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1012         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1013         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1014         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1015         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1016         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1017         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1018         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1019         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1020         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1021         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1022         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1023         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1024         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1025
1026 2019-07-10  Tom Tromey  <tromey@adacore.com>
1027
1028         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1029         * breakpoint.c (init_ada_exception_breakpoint): Register as
1030         bp_catchpoint.
1031         (print_one_breakpoint_location, print_one_breakpoint): Use
1032         is_ada_exception_catchpoint.
1033         * ada-lang.c (class ada_catchpoint_location): Pass
1034         bp_loc_software_breakpoint to bp_location constructor.
1035         (is_ada_exception_catchpoint): New function.
1036
1037 2019-07-10  Tom Tromey  <tromey@adacore.com>
1038
1039         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1040         VEC.
1041         (struct arm_exidx_entry): New method operator<.
1042         (struct arm_exidx_data) <section_maps>: Change type.
1043         (arm_exidx_data_free): Remove.
1044         (arm_exidx_data_key): Change type.  Move lower.
1045         (arm_exidx_new_objfile): Update.
1046         (arm_compare_exidx_entries): Remove.
1047         (arm_find_exidx_entry, _initialize_arm_tdep)
1048
1049 2019-07-10  Tom Tromey  <tromey@adacore.com>
1050
1051         * solib-spu.c (ocl_program_data_key): Change type.
1052         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1053         Update.
1054
1055 2019-07-10  Tom Tromey  <tromey@adacore.com>
1056
1057         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1058         (struct solib_aix_inferior_data) <library_list>: Change type.
1059         (solib_aix_inferior_data_handle): Change type.
1060         (get_solib_aix_inferior_data): Update.
1061         (solib_aix_free_library_list): Remove.
1062         (library_list_start_library): Update.
1063         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1064         return type.
1065         (solib_aix_get_library_list)
1066         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1067         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1068
1069 2019-07-10  Tom Tromey  <tromey@adacore.com>
1070
1071         * solib-dsbt.c (struct dsbt_info): Add initializers.
1072         (solib_dsbt_pspace_data): Change type.
1073         (dsbt_pspace_data_cleanup): Remove.
1074         (get_dsbt_info, _initialize_dsbt_solib): Update.
1075
1076 2019-07-10  Tom Tromey  <tromey@adacore.com>
1077
1078         * spu-tdep.c (spu_overlay_data): Change type.
1079         (spu_get_overlay_table, spu_overlay_new_objfile)
1080         (_initialize_spu_tdep): Update.
1081
1082 2019-07-10  Tom Tromey  <tromey@adacore.com>
1083
1084         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1085         destructor.
1086         (dbx_objfile_data_key): Change type and declare later.
1087         (DBX_SYMFILE_INFO): Rewrite.
1088         * dbxread.c (dbx_objfile_data_key): Change type.
1089         (dbx_symfile_init): Update.
1090         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1091         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1092         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1093
1094 2019-07-10  Tom Tromey  <tromey@adacore.com>
1095
1096         * jit.c (jit_program_space_key): Change type.  Move lower.
1097         (get_jit_program_space_data): Update.
1098         (jit_program_space_data_cleanup): Remove.
1099         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1100         Update.
1101         (struct jit_program_space_data): Add initializers.
1102
1103 2019-07-10  Tom Tromey  <tromey@adacore.com>
1104
1105         * solib-darwin.c (struct darwin_info): Add initializers.
1106         (solib_darwin_pspace_data): Change type.
1107         (darwin_pspace_data_cleanup): Remove.
1108         (get_darwin_info, _initialize_darwin_solib): Update.
1109
1110 2019-07-10  Tom Tromey  <tromey@adacore.com>
1111
1112         * remote-sim.c (struct sim_inferior_data): Add initializers,
1113         constructor, and destructor.
1114         (sim_inferior_data_key): Change type.  Move lower.
1115         (check_for_duplicate_sim_descriptor): Update.
1116         (get_sim_inferior_data): Use new.  Update.
1117         (~sim_inferior_data_cleanup): Rename from
1118         sim_inferior_data_cleanup.  Simplify.
1119         (gdbsim_close_inferior, simulator_command)
1120         (sim_command_completer, _initialize_remote_sim): Update.
1121         (next_pid, INITIAL_PID): Move earlier.
1122
1123 2019-07-10  Tom Tromey  <tromey@adacore.com>
1124
1125         * python/python-internal.h (create_thread_object): Return
1126         gdbpy_ref.
1127         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1128         * python/py-inferior.c (struct threadlist_entry): Add
1129         constructor.
1130         <thread_obj>: Now a gdbpy_ref.
1131         (thread_to_thread_object): Update.
1132         (add_thread_object): Use new.
1133         (delete_thread_object): Use delete.
1134         (infpy_threads): Update.
1135         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1136         GIL.
1137
1138 2019-07-10  Tom Tromey  <tromey@adacore.com>
1139
1140         * valops.c (value_cast): Specialize error message for Ada.
1141
1142 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1143
1144         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1145
1146 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1147
1148         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1149         bpstat_should_step): Return bool, adjust comments.
1150         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1151         bpstat_should_step): Likewise.
1152
1153 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1154
1155         * features/Makefile: Use feature target descriptions for Arm.
1156         * features/arm/arm-core.c: Generate new file.
1157         * features/arm/arm-fpa.c: Likewise.
1158         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1159         * features/arm/arm-m-profile.c: Likewise.
1160         * features/arm/arm-vfpv2.c: Likewise.
1161         * features/arm/arm-vfpv3.c: Likewise.
1162         * features/arm/xscale-iwmmxt.c: Likewise.
1163         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1164
1165 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1168         ptrace earlier.
1169
1170 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1171
1172         * features/aarch64-pauth.c: Regenerate.
1173
1174 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1175
1176         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1177         bool.
1178         (bpstat_what): Use false instead of 0.
1179
1180 2019-07-09  Pedro Alves  <palves@redhat.com>
1181
1182         * break-catch-throw.c (is_exception_catchpoint): New.
1183         * breakpoint.c (print_one_breakpoint_location): New parameter
1184         'raw_loc'.  Handle it.  Use
1185         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1186         looking at the breakpoint's type.
1187         (print_one_breakpoint): If handling "maint info breakpoints", also
1188         print locations of exception catchpoints.
1189         * breakpoint.h (is_exception_catchpoint): Declare.
1190
1191 2019-07-09  Pedro Alves  <palves@redhat.com>
1192
1193         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1194         "addr" field.
1195         (allocate_location_exception_catchpoint): New.
1196         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1197         (initialize_throw_catchpoint_ops): Install
1198         allocate_location_exception_catchpoint as allocate_location
1199         method.
1200         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1201         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1202         bp_loc_other.
1203         (breakpoint_address_is_meaningful): Delete.
1204         (bl_address_is_meaningful): New.
1205         (breakpoint_locations_match): Adjust comment.
1206         (bp_location_from_bp_type): New, factored out of...
1207         (bp_location::bp_location(breakpoint *)): ... this.
1208         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1209         factored out of...
1210         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1211         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1212         breakpoint_address_is_meaningful.
1213         (bp_locations_compare): Adjust comment.
1214         (update_global_location_list): Use bl_address_is_meaningful
1215         instead of breakpoint_address_is_meaningful.
1216         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1217         explicit.
1218         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1219         * python/py-breakpoint.c (bppy_get_location): No longer check
1220         whether location is null.
1221
1222 2019-07-09  Pedro Alves  <palves@redhat.com>
1223
1224         PR c++/15468
1225         * breakpoint.c (print_one_breakpoint_location): Remove
1226         single-location assert.
1227
1228 2019-07-09  Tom Tromey  <tom@tromey.com>
1229
1230         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1231         * configure: Rebuild.
1232         * configure.ac: Change common to gdbsupport.
1233         * gdbsupport: Rename from common.
1234         * acinclude.m4: Change common to gdbsupport.
1235         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1236         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1237         gdbsupport.
1238         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1239         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1240         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1241         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1242         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1243         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1244         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1245         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1246         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1247         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1248         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1249         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1250         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1251         coff-pe-read.c, command.h, compile/compile-c-support.c,
1252         compile/compile-c.h, compile/compile-cplus-symbols.c,
1253         compile/compile-cplus-types.c, compile/compile-cplus.h,
1254         compile/compile-loc2c.c, compile/compile.c, completer.c,
1255         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1256         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1257         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1258         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1259         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1260         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1261         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1262         features/aarch64-core.c, features/aarch64-fpu.c,
1263         features/aarch64-pauth.c, features/aarch64-sve.c,
1264         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1265         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1266         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1267         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1268         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1269         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1270         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1271         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1272         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1273         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1274         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1275         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1276         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1277         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1278         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1279         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1280         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1281         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1282         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1283         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1284         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1285         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1286         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1287         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1288         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1289         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1290         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1291         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1292         minsyms.c, mips-linux-tdep.c, namespace.h,
1293         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1294         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1295         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1296         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1297         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1298         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1299         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1300         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1301         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1302         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1303         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1304         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1305         procfs.c, producer.c, progspace.h, psymtab.h,
1306         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1307         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1308         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1309         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1310         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1311         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1312         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1313         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1314         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1315         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1316         target-memory.c, target.c, target.h, target/waitstatus.c,
1317         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1318         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1319         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1320         unittests/array-view-selftests.c,
1321         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1322         unittests/common-utils-selftests.c,
1323         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1324         unittests/format_pieces-selftests.c,
1325         unittests/function-view-selftests.c,
1326         unittests/lookup_name_info-selftests.c,
1327         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1328         unittests/mkdir-recursive-selftests.c,
1329         unittests/observable-selftests.c,
1330         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1331         unittests/parse-connection-spec-selftests.c,
1332         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1333         unittests/scoped_fd-selftests.c,
1334         unittests/scoped_mmap-selftests.c,
1335         unittests/scoped_restore-selftests.c,
1336         unittests/string_view-selftests.c, unittests/style-selftests.c,
1337         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1338         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1339         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1340         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1341         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1342         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1343
1344 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1347         bool value.
1348         (decode_digits_ordinary): Set explicit_line field in sal.
1349         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1350         symtab_and_line that was set on an explicit line number in
1351         assembler code.  Do always update the recorded symtab and line if
1352         we do skip the prologue.
1353
1354 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * breakpoint.c (set_breakpoint_location_function): Remove
1357         explicit_loc parameter.
1358         (momentary_breakpoint_from_master): Update call to
1359         set_breakpoint_location_function.
1360         (add_location_to_breakpoint): Likewise.
1361
1362 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1365         required features based on default bfd type when no specific bfd
1366         is present.
1367
1368 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1369
1370         * NEWS: Mention that GDB printf and eval commands can now print
1371         C-style and Ada-style convenience var strings without
1372         calling the inferior.
1373         * printcmd.c (printf_c_string): Locally print GDB internal var
1374         instead of transiting via the inferior.
1375         (printf_wide_c_string): Likewise.
1376
1377 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1378
1379         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1380
1381 2019-07-04  Tom Tromey  <tom@tromey.com>
1382
1383         PR tui/24724:
1384         * tui/tui-winsource.c (tui_clear_source_content): Update.
1385         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1386         (tui_update_breakpoint_info): Update.
1387         (tui_set_exec_info_content): Update.
1388         * tui/tui-source.c (tui_set_source_content_nil): Update.
1389         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1390         has_break.
1391         * tui/tui-data.h (enum tui_bp_flag): New.
1392         (tui_bp_flags): New enum flags type.
1393         (struct tui_source_element) <break_mode>: Change type.  Rename
1394         from has_break.
1395         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1396         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1397         constants.
1398         * tui/tui-winsource.h: Fix comment.
1399
1400 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1401
1402         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1403         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1404         (store_fpregs_to_thread)
1405         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1406         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1407         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1408         (IWMMXT_REGS_SIZE): Add define.
1409         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1410         (fetch_vfp_regs, store_vfp_regs)
1411         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1412         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1413
1414 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1415
1416         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1417         defines.
1418         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1419         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1420         (ARM_INT_REGISTER_SIZE): ...to this.
1421         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1422         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1423         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1424         (arm_linux_collect_gregset, supply_nwfpe_register)
1425         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1426         defines.
1427         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1428         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1429         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1430         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1431         (arm_return_in_memory, arm_store_return_value)
1432         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1433         (arm_record_ld_st_multiple): Likewise.
1434         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1435         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1436
1437 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1440         AARCH64_DISPLACED_MODIFIED_INSNS.
1441         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1442         (aarch64_displaced_step_copy_insn): Likewise.
1443         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1444         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1445         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1446         ARM_DISPLACED_MODIFIED_INSNS.
1447         * arm-tdep.c (arm_gdbarch_init): Likewise.
1448         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1449         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1450         (struct arm_displaced_step_closure): Use
1451         ARM_DISPLACED_MODIFIED_INSNS.
1452
1453 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1454
1455         * features/Makefile: Remove unused xml files.
1456         * features/aarch64.xml: Remove.
1457         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1458         * features/i386/amd64-avx-avx512.xml: Remove.
1459         * features/i386/amd64-avx-linux.xml: Remove.
1460         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1461         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1462         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1463         * features/i386/amd64-avx-mpx.xml: Remove.
1464         * features/i386/amd64-avx.xml: Remove.
1465         * features/i386/amd64-linux.xml: Remove.
1466         * features/i386/amd64-mpx-linux.xml: Remove.
1467         * features/i386/amd64-mpx.xml: Remove.
1468         * features/i386/amd64.xml: Remove.
1469         * features/i386/i386-avx-avx512-linux.xml: Remove.
1470         * features/i386/i386-avx-avx512.xml: Remove.
1471         * features/i386/i386-avx-linux.xml: Remove.
1472         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1473         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1474         * features/i386/i386-avx-mpx-linux.xml: Remove.
1475         * features/i386/i386-avx-mpx.xml: Remove.
1476         * features/i386/i386-avx.xml: Remove.
1477         * features/i386/i386-linux.xml: Remove.
1478         * features/i386/i386-mmx-linux.xml: Remove.
1479         * features/i386/i386-mmx.xml: Remove.
1480         * features/i386/i386-mpx-linux.xml: Remove.
1481         * features/i386/i386-mpx.xml: Remove.
1482         * features/i386/i386.xml: Remove.
1483         * features/i386/x32-avx-avx512-linux.xml: Remove.
1484         * features/i386/x32-avx-linux.xml: Remove.
1485         * features/i386/x32-linux.xml: Remove.
1486
1487 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1488
1489         * regformats/aarch64.dat: Remove.
1490         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1491         * regformats/i386/amd64-avx-linux.dat: Remove.
1492         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1493         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1494         * regformats/i386/amd64-linux.dat: Remove.
1495         * regformats/i386/amd64-mpx-linux.dat: Remove.
1496         * regformats/i386/amd64.dat: Remove.
1497         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1498         * regformats/i386/i386-avx-linux.dat: Remove.
1499         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1500         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1501         * regformats/i386/i386-linux.dat: Remove.
1502         * regformats/i386/i386-mmx-linux.dat: Remove.
1503         * regformats/i386/i386-mpx-linux.dat: Remove.
1504         * regformats/i386/i386.dat: Remove.
1505         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1506         * regformats/i386/x32-avx-linux.dat: Remove.
1507         * regformats/i386/x32-linux.dat: Remove.
1508
1509 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1510
1511         * aarch64-tdep.c: Remove xml self tests.
1512         * amd64-linux-tdep.c: Likewise.
1513         * amd64-tdep.c: Likewise.
1514         * i386-linux-tdep.c: Likewise.
1515         * i386-tdep.c: Likewise.
1516
1517 2019-07-03  Pedro Alves  <palves@redhat.com>
1518
1519         PR cli/24732
1520         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1521         (pipe_cmd_option_defs): New.
1522         (make_pipe_cmd_options_def_group): New.
1523         (pipe_command): Use gdb::option::process_options.
1524         (pipe_command_completer): New function.
1525         (_initialize_cli_cmds): Install completer for "pipe" command.
1526
1527 2019-07-03  Pedro Alves  <palves@redhat.com>
1528
1529         * cli/cli-option.c (union option_value) <string>: New field.
1530         (struct option_def_and_value): Add ctor, move ctor, dtor and
1531         use DISABLE_COPY_AND_ASSIGN.
1532         (option_def_and_value::clear_value): New.
1533         (parse_option, save_option_value_in_ctx, get_val_type_str)
1534         (add_setshow_cmds_for_options): Handle var_string.
1535         * cli-option.h (union option_def::var_address) <string>: New
1536         field.
1537         (struct string_option_def): New.
1538         * maint-test-options.c (struct test_options_opts): Add default
1539         ctor and use DISABLE_COPY_AND_ASSIGN.
1540         <string_opt>: New field.
1541         (test_options_opts::~test_options_opts): New.
1542         (test_options_opts::dump): Also dump "-string".
1543         (test_options_option_defs): Install "string.
1544
1545 2019-07-03  Pedro Alves  <palves@redhat.com>
1546
1547         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1548         option_value with a null enumeration.
1549         (complete_options): Save the option values in the context.
1550         (save_option_value_in_ctx): New, factored out from ...
1551         (process_options): ... here.
1552         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1553         of the function.
1554         * maint-test-options.c (test_options_opts::dump): New, factored
1555         out from ...
1556         (maintenance_test_options_command_mode): ... here.
1557         (maintenance_test_options_command_completion_result): Delete.
1558         (maintenance_test_options_command_completion_text): Update
1559         comment.
1560         (maintenance_show_test_options_completion_result): Change
1561         prototype.  Just print
1562         maintenance_test_options_command_completion_text.
1563         (save_completion_result): New.
1564         (maintenance_test_options_completer_mode): Pass options context to
1565         complete_options, and then save a dump.
1566         (_initialize_maint_test_options): Use add_cmd to install "maint
1567         show test-options-completion-result".
1568
1569 2019-07-03  Pedro Alves  <palves@redhat.com>
1570
1571         * NEWS (New commands): Mention "with" and "maint with".
1572         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1573         (with_command, with_command_completer): New.
1574         (pipe_command): Adjust to new repeat_previous
1575         interface.
1576         (_initialize_cli_cmds): Install the "with" command and its "w"
1577         alias.
1578         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1579         declarations.
1580         * cli/cli-setshow.c (parse_cli_var_uinteger)
1581         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1582         argument strings for all var_types.
1583         (get_setshow_command_value_string): New, factored out from ...
1584         (do_show_command): ... this.
1585         * cli/cli-setshow.h: Include <string>.
1586         (get_setshow_command_value_string): Declare.
1587         * command.h (repeat_previous): Now returns const char *.  Adjust
1588         comment.
1589         * maint.c: Include "cli/cli-cmds.h".
1590         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1591         (_initialize_maint_cmds): Register the "maintenance with" command.
1592         * top.c (repeat_previous): Move bits from pipe_command here:
1593         Return the saved command line, if any; error out if there's no
1594         command to relaunch.
1595
1596 2019-07-03  Pedro Alves  <palves@redhat.com>
1597
1598         * NEWS (New commands): Mention "maint set/show test-settings"
1599         instead of "maint test-settings".
1600         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1601         (maintenance_test_settings_set_list): Rename to ...
1602         (maintenance_set_test_settings_list): ... this.
1603         (maintenance_test_settings_show_list): Rename to  ...
1604         (maintenance_show_test_settings_list): ... this.
1605         (maintenance_test_settings_cmd): Delete.
1606         (maintenance_test_settings_set_cmd): ...
1607         (maintenance_set_test_settings_cmd): ... this.
1608         (maintenance_test_settings_show_cmd): ...
1609         (maintenance_show_test_settings_cmd): ... this.
1610         (maintenance_test_settings_show_value_cmd):
1611         (maintenance_show_test_settings_value_cmd): ... this.
1612         (_initialize_maint_test_settings): No longer install the "maint
1613         test-settings" prefix command.  Rename "maint test-settings set"
1614         to "maint set test-settings", and "maint test-settings show" to
1615         "maint show test-settings".  Adjust all subcommands.
1616
1617 2019-07-03  Pedro Alves  <palves@redhat.com>
1618
1619         * maint-test-settings.c: Fix file's intro comment.  Replace all
1620         references to "test-options" with references to "test-settings",
1621         in comments.
1622
1623 2019-07-03  Pedro Alves  <palves@redhat.com>
1624
1625         * maint-test-settings.c (maintenance_test_settings_xxx)
1626         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1627         New.
1628         (maintenance_test_settings_enums): Use them.
1629         (maintenance_test_settings_enum): Default to
1630         maintenance_test_settings_xxx.
1631         (_initialize_maint_test_settings): Initialize
1632         MAINTENANCE_TEST_SETTINGS_FILENAME.
1633
1634 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1635
1636         * breakpoint.h (remove_breakpoints_inf): Change return type to
1637         void, move function documentation here.
1638         * breakpoint.c (remove_breakpoints_inf): Change return type to
1639         void, move function documentation to header.
1640
1641 2019-07-02  Pedro Alves  <palves@redhat.com>
1642
1643         * NEWS (Completion improvements): Mention "info threads".
1644         * thread.c (struct info_threads_opts, info_threads_option_defs)
1645         (make_info_threads_options_def_group): New.
1646         (info_threads_command): Use gdb::option::process_options.
1647         (info_threads_command_completer): New.
1648         (_initialize_thread): Use gdb::option::build_help to build the
1649         help text for "info threads".
1650
1651 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1652
1653         * defs.h (generic_load): Move from here...
1654         * symfile.h (generic_load): ... to here.  Rename name parameter
1655         to args.
1656         * symfile.c (generic_load): Add comment.
1657
1658 2019-07-01  Tom Tromey  <tromey@adacore.com>
1659
1660         * dwarf2read.c
1661         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1662         declaration of without_params.  Fix formatting.
1663
1664 2019-07-01  Tom Tromey  <tromey@adacore.com>
1665
1666         * ada-exp.y (find_primitive_type): Update.
1667         * ada-lang.h (ada_lookup_symbol): Update.
1668         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1669         parameter.
1670         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1671
1672 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1673
1674         PR breakpoints/24541
1675         * gdbarch.c: Regenerate.
1676         * gdbarch.h: Regenerate.
1677         * gdbarch.sh: Add 'stap_adjust_register'.
1678         * i386-tdep.c: Include '<unordered_set>'.
1679         (i386_stap_adjust_register): New function.
1680         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1681         * stap-probe.c (stap_parse_register_operand): Call
1682         'gdbarch_stap_adjust_register'.
1683
1684 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1685
1686         PR python/24742
1687         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1688         * python/python.c (do_start_initialization): Use 'xmalloc'
1689         instead of 'PyMem_Malloc'.
1690
1691 2019-06-28  Tom Tromey  <tromey@adacore.com>
1692
1693         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1694         for Ada.
1695
1696 2019-06-27  Tom Tromey  <tromey@adacore.com>
1697
1698         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1699         objfile_key.
1700         (arm_find_mapping_symbol, arm_record_special_symbol)
1701         (_initialize_arm_tdep): Update.
1702         (arm_objfile_data_free): Remove.
1703
1704 2019-06-27  Tom Tromey  <tromey@adacore.com>
1705
1706         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1707         to cp_print_static_field.
1708
1709 2019-06-26  Tom Tromey  <tromey@adacore.com>
1710
1711         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1712         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1713         declare.
1714
1715 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1716
1717         * features/aarch64-core.c (create_feature_aarch64_core):
1718         Regenerate.
1719         * features/aarch64-core.xml: Add cpsr flags.
1720
1721 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1722
1723         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1724         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1725
1726 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1727
1728         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1729         field.
1730         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1731         use.
1732         (arm_record_special_symbol): Don't insert new symbol in sorted
1733         position, push it at the end.
1734
1735 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1736
1737         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1738         (arm_mapping_symbol_s): Remove.
1739         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1740         (arm_mapping_symbol_vec): New typedef.
1741         (struct arm_per_objfile): Add constructor.
1742         <section_maps>: Change type to
1743         std::unique_ptr<arm_mapping_symbol_vec[]>.
1744         (arm_compare_mapping_symbols): Remove.
1745         (arm_find_mapping_symbol): Adjust to section_maps type change.
1746         (arm_objfile_data_free): Call delete on arm_per_objfile.
1747         (arm_record_special_symbol): Adjust to section_maps type change.
1748         Allocate arm_per_objfile with new.
1749
1750 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1751
1752         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1753         with the command prefix.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1758         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1759
1760 2019-06-25  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1763         type.
1764         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1765         protected.
1766
1767 2019-06-25  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-winsource.c
1770         (tui_source_window_base::set_is_exec_point_at): Add check against
1771         LOA_ADDRESS.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-source.c (tui_set_source_content): Don't check before
1776         xfree.
1777         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-winsource.h (tui_update_source_window_as_is)
1782         (tui_alloc_source_buffer, tui_line_is_displayed)
1783         (tui_addr_is_displayed): Change type of win_info.
1784         * tui/tui-winsource.c (tui_update_source_window_as_is)
1785         (tui_clear_source_content, tui_show_source_line)
1786         (tui_show_source_content, tui_source_window_base::refill)
1787         (tui_source_window_base::set_is_exec_point_at)
1788         (tui_source_window_base::set_is_exec_point_at)
1789         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1790         (tui_alloc_source_buffer, tui_line_is_displayed)
1791         (tui_addr_is_displayed): Change type of win_info.  Update.
1792         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1793         (tui_source_window_base::do_make_visible_with_new_height):
1794         Update.
1795         * tui/tui-source.c (tui_set_source_content)
1796         (tui_set_source_content_nil)
1797         (tui_source_window::do_scroll_vertical): Update.
1798         * tui/tui-layout.c (show_layout): Update.
1799         * tui/tui-disasm.c (tui_set_disassem_content)
1800         (tui_disasm_window::do_scroll_vertical): Update.
1801         * tui/tui-data.h (tui_win_content): Remove.
1802         (struct tui_gen_win_info) <content, content_size>: Remove.
1803         (struct tui_source_element): Add initializers and destructor.
1804         (union tui_which_element, struct tui_win_element): Remove.
1805         (struct tui_source_window_base) <content>: New field.
1806         (struct tui_data_window): Remove destructor.
1807         (tui_alloc_content, tui_free_win_content)
1808         (tui_free_all_source_wins_content): Don't declare.
1809         * tui/tui-data.c (tui_initialize_static_data): Update.
1810         (init_content_element, tui_alloc_content): Remove.
1811         (~tui_gen_win_info): Update.
1812         (~tui_data_window, tui_free_all_source_wins_content)
1813         (tui_free_win_content, free_content, free_content_elements):
1814         Remove.
1815
1816 2019-06-25  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-winsource.h (tui_clear_source_content)
1819         (tui_erase_source_content, tui_show_source_content): Change type
1820         of win_info.
1821         * tui/tui-winsource.c (tui_clear_source_content)
1822         (tui_erase_source_content, tui_show_source_content): Change type
1823         of win_info.
1824         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1825         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1826         win_info.
1827         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1828         win_info.
1829         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1830
1831 2019-06-25  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.c (tui_clear_source_content)
1834         (tui_source_window_base::set_is_exec_point_at): Update.
1835         * tui/tui-source.c (tui_set_source_content_nil): Update.
1836         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1837         a bool.
1838         * tui/tui-data.c (init_content_element): Update.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1843         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1844         * tui/tui-layout.c (init_and_make_win): Update.
1845         * tui/tui.h (enum tui_win_type): Update.
1846         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1847         tui_win_is_auxillary.
1848         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1849         tui_win_is_auxillary.
1850
1851 2019-06-25  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1854         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1855         (tui_delete_data_content_windows, tui_display_all_data)
1856         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1857         Update.
1858         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1859         * tui/tui-regs.c (tui_last_regs_line_no)
1860         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1861         (tui_show_registers): Update.
1862         (tui_show_register_group): Return void.  Update.
1863         (tui_display_registers_from, tui_display_reg_element_at_line)
1864         (tui_display_registers_from_line, tui_check_register_values):
1865         Update.
1866         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1867         member.
1868         (struct tui_data_window) <regs_content>: Now a std::vector.
1869         <regs_content_count>: Remove.
1870         (tui_add_content_elements, tui_free_data_content): Don't declare.
1871         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1872         (init_content_element): Remove DATA_WIN case.  Add assert.
1873         (tui_add_content_elements): Remove.
1874         (tui_data_window): Update.
1875         (tui_free_data_content): Remove.
1876         (free_content_elements): Remove DATA_WIN case.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-data.c (tui_data_item_window): Update.
1881         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1882         * tui/tui-windata.c (tui_display_all_data)
1883         (tui_display_data_from_line): Update.
1884         (tui_check_data_values): Remove.
1885         * tui/tui-regs.c (tui_show_register_group)
1886         (tui_display_reg_element_at_line): Update.
1887         * tui/tui-hooks.c (tui_register_changed)
1888         (tui_refresh_frame_and_register_information): Call
1889         tui_check_register_values.
1890         * tui/tui-data.h (struct tui_data_window) <data_content,
1891         data_content_count, data_type>: Remove.
1892         (enum tui_data_type): Remove.
1893
1894         * tui/tui-data.c (tui_data_window::clear_detail)
1895         (~tui_data_window): Update.
1896
1897 2019-06-25  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1900         declare.
1901         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1902         Rename from tui_first_data_item_displayed.  Update.
1903         (tui_data_window::refresh_all)
1904         (tui_data_window::do_scroll_vertical): Update.
1905         * tui/tui-data.h (struct tui_data_window)
1906         <first_data_item_displayed>: Declare new method.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1911         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1912         contents...
1913         (tui_initialize_static_data): ...here.
1914
1915 2019-06-25  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1918         (tui_display_registers_from, tui_check_register_values): Update.
1919         (tui_display_register): Remove win_info parameter; update.
1920         (tui_get_register): Change type of parameters.
1921         * tui/tui-data.h (struct tui_data_element): Remove.
1922         (union tui_which_element) <data>: Remove.
1923         <data_window>: Change type.
1924         (struct tui_data_item_window): New.
1925         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1926         case.  Add assert.
1927         (~tui_data_item_window): New destructor.
1928         (free_content_elements): Remove DATA_ITEM_WIN case.
1929
1930 2019-06-25  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1933         Remove.
1934
1935 2019-06-25  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-data.h (struct tui_command_element): Remove.
1938         (union tui_which_element) <command>: Remove.
1939         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1940         assert.
1941         (free_content_elements): Remove CMD_WIN case.
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-layout.c (tui_set_layout): Update.
1946         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1947         * tui/tui-data.c (layout_def): Update.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1952         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1953         (tui_source_window_base::set_new_height): Update.
1954         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1955         Update.
1956         (tui_set_locator_fullname, tui_set_locator_info)
1957         (tui_show_frame_info): Update.
1958         * tui/tui-source.c (tui_set_source_content)
1959         (tui_source_is_displayed): Update.
1960         * tui/tui-layout.c (show_source_disasm_command, show_data)
1961         (show_source_or_disasm_and_command): Update.
1962         * tui/tui-disasm.c (tui_set_disassem_content)
1963         (tui_get_begin_asm_address): Update.
1964         * tui/tui-data.h (struct tui_locator_element): Remove.
1965         (union tui_which_element) <locator>: Remove.
1966         (struct tui_locator_window): New.
1967         (tui_locator_win_info_ptr): Change return type.
1968         * tui/tui-data.c (_locator): Change type.
1969         (tui_locator_win_info_ptr): Change return type.
1970         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1971         (tui_alloc_content): Add assert.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-winsource.c
1976         (tui_exec_info_window::maybe_allocate_content): New method.
1977         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1978         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1979         (make_source_or_disasm_window): Add cast.
1980         * tui/tui-data.h (union tui_which_element) <simple_string>:
1981         Remove.
1982         (struct tui_source_info): New.
1983         (struct tui_source_window_base) <execution_info>: Change type.
1984         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1985         case, and add assert.
1986         (tui_alloc_content): Add assert.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1991         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1992         * tui/tui-data.c (tui_alloc_win_info): Remove.
1993
1994 2019-06-25  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1997         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1998         can_highlight.
1999
2000 2019-06-25  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2003         make_visible_with_new_height method.
2004         (tui_win_info::make_visible_with_new_height): New method.
2005         (tui_source_window_base::do_make_visible_with_new_height)
2006         (tui_data_window::do_make_visible_with_new_height)
2007         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2008         (make_visible_with_new_height): Remove.
2009         (tui_resize_all, tui_adjust_win_heights): Use
2010         make_visible_with_new_height method.
2011         * tui/tui-data.h (struct tui_win_info)
2012         <do_make_visible_with_new_height, make_visible_with_new_height>:
2013         New methods.
2014         (struct tui_source_window_base, struct tui_data_window)
2015         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2016         methods.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2021         method.
2022         (update_tab_width): Call update_tab_width method.
2023         * tui/tui-data.h (struct tui_win_info)
2024         (struct tui_source_window_base) <update_tab_width>: New methods.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2029         parameter.
2030         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2031         parameter.
2032         (tui_gen_win_info::make_visible): Update.
2033         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2034         parameter.
2035         * tui/tui-data.h (enum tui_box): New enum.
2036         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2041         init_and_make_win for EXEC_INFO_WIN.
2042         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2043         longer inline.
2044         (struct tui_win_info) <~tui_win_info>: Inline.
2045         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2046         Don't declare.
2047         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2048         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2049         Remove.
2050         (tui_initialize_static_data): Update.
2051         (~tui_gen_win_info): Handle more cleanup here.
2052         (~tui_source_window_base): Delete "execution_info".
2053         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-layout.c (make_command_window): Don't set
2058         can_highlight.
2059         (show_source_disasm_command): Call the reset method.
2060         (show_data): Don't set can_highlight.  Call the reset method.
2061         (tui_gen_win_info::reset): Rename from init_gen_win_info
2062         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2063         (show_source_or_disasm_and_command): Call the reset method.
2064         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2065         (struct tui_cmd_window): Set can_highlight.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2070         from make_visible.
2071         (tui_make_visible, tui_make_invisible): Rewrite.
2072         (tui_win_info::make_visible): Remove.
2073         (tui_source_window_base::make_visible): Update.
2074         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2075         method.  Moved from...
2076         (struct tui_win_info) <make_visible>: ...here.
2077
2078 2019-06-25  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui-winsource.c
2081         (tui_source_window_base::do_scroll_horizontal): Remove direction
2082         parameter.
2083         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2084         direction parameter.
2085         * tui/tui-win.c (tui_win_info::forward_scroll)
2086         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2087         (tui_win_info::right_scroll): Update.
2088         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2089         direction parameter.
2090         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2091         direction parameter.
2092         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2093         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2094         Remove direction parameter.
2095         (struct tui_source_window_base, struct tui_source_window)
2096         (struct tui_disasm_window, struct tui_data_window)
2097         (struct tui_cmd_window): Update.
2098
2099 2019-06-25  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-winsource.h (tui_set_exec_info_content)
2102         (tui_show_exec_info_content, tui_erase_exec_info_content)
2103         (tui_clear_exec_info_content, tui_update_exec_info): Change
2104         argument to tui_source_window_base.
2105         * tui/tui-winsource.c (tui_set_exec_info_content)
2106         (tui_show_exec_info_content, tui_erase_exec_info_content)
2107         (tui_clear_exec_info_content, tui_update_exec_info): Change
2108         argument to tui_source_window_base.
2109
2110 2019-06-25  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2113         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2114
2115 2019-06-25  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2118         check.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2123         type to void.
2124         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2125         type to void.
2126         * tui/tui-source.c (tui_set_source_content): Update.
2127         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2128
2129 2019-06-25  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-win.c (window_name_completer, tui_set_focus)
2132         (tui_all_windows_info): Use name method.
2133         * tui/tui-data.h (struct tui_gen_win_info)
2134         (struct tui_source_window, struct tui_disasm_window)
2135         (struct tui_data_window, struct tui_cmd_window) <name>: New
2136         method.
2137         (tui_win_name): Don't declare.
2138         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2139         (tui_win_name): Remove.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-winsource.h (tui_update_source_window)
2144         (tui_update_source_window_as_is): Change parameter type.
2145         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2146         to be a tui_source_window_base.
2147         (tui_update_source_window_as_is): Likewise.
2148         * tui/tui-win.c (make_visible_with_new_height): Update.
2149
2150 2019-06-25  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-winsource.c (tui_erase_source_content)
2153         (tui_show_source_content, tui_show_exec_info_content)
2154         (tui_erase_exec_info_content): Use refresh_window method.
2155         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2156         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2157         from tui_refresh_win.
2158         (tui_data_window::refresh_window): New method.
2159         (tui_win_info::refresh, tui_source_window_base::refresh)
2160         (tui_refresh_all): Use refresh_window method.
2161         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2162         method.
2163         * tui/tui-regs.c (tui_display_register): Call refresh_window
2164         method.
2165         * tui/tui-layout.c (show_source_disasm_command)
2166         (show_source_or_disasm_and_command): Call refresh_window method.
2167         * tui/tui-data.h (struct tui_gen_win_info)
2168         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2169         New method.
2170
2171 2019-06-25  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui.c (tui_rl_other_window, tui_enable)
2174         (tui_is_window_visible, tui_get_command_dimension): Update.
2175         * tui/tui-winsource.c (tui_update_source_window_as_is)
2176         (tui_clear_source_content, tui_erase_source_content)
2177         (tui_show_source_line, tui_source_window_base::refill)
2178         (tui_source_window_base::do_scroll_horizontal)
2179         (tui_source_window_base::set_is_exec_point_at)
2180         (tui_update_breakpoint_info, tui_set_exec_info_content)
2181         (tui_alloc_source_buffer, tui_line_is_displayed)
2182         (tui_addr_is_displayed): Update.
2183         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2184         (tui_check_and_display_highlight_if_needed)
2185         (tui_win_info::make_visible, tui_win_info::refresh)
2186         (tui_refresh_all): Update.
2187         * tui/tui-windata.c (tui_first_data_item_displayed)
2188         (tui_delete_data_content_windows, tui_erase_data_content)
2189         (tui_display_all_data, tui_data_window::refresh_all)
2190         (tui_check_data_values): Update.
2191         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2192         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2193         (tui_win_info::backward_scroll, tui_refresh_all_win)
2194         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2195         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2196         (tui_source_window_base::set_new_height)
2197         (tui_data_window::set_new_height)
2198         (make_invisible_and_set_new_height)
2199         (make_visible_with_new_height, new_height_ok)
2200         (parse_scrolling_args): Update.
2201         * tui/tui-stack.c (tui_show_frame_info): Update.
2202         * tui/tui-source.c (tui_set_source_content)
2203         (tui_set_source_content_nil, tui_source_is_displayed)
2204         (tui_source_window::do_scroll_vertical): Update.
2205         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2206         (tui_display_registers_from, tui_display_reg_element_at_line)
2207         (tui_check_register_values, tui_reg_command): Update.
2208         * tui/tui-layout.c (tui_default_win_height)
2209         (show_source_disasm_command, show_data, init_and_make_win)
2210         (show_source_or_disasm_and_command): Update.
2211         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2212         (tui_redisplay_readline, tui_mld_flush)
2213         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2214         (tui_getc): Update.
2215         * tui/tui-disasm.c (tui_set_disassem_content)
2216         (tui_disasm_window::do_scroll_vertical): Update.
2217         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2218         Now virtual.
2219         (struct tui_win_info): Derive from tui_gen_win_info.
2220         <~tui_win_info>: Mark as override.
2221         <generic>: Remove member.
2222         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2223         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2224         (~tui_data_window, ~tui_win_info)
2225         (tui_free_all_source_wins_content): Update.
2226         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-layout.c (init_and_make_win): Use new.
2231         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2232         destructor, initializers.
2233         (tui_alloc_generic_win_info): Don't declare.
2234         * tui/tui-data.c (_locator): Add argument to constructor.
2235         (source_win, disasm_win): New globals.
2236         (exec_info): Remove.
2237         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2238         Update.
2239         (tui_alloc_generic_win_info): Remove.
2240         (init_content_element): Use new.
2241         (tui_win_info::tui_win_info): Update.
2242         (free_content_elements) <case DATA_WIN>: Use delete.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2247         * tui/tui-windata.c (tui_first_data_item_displayed)
2248         (tui_delete_data_content_windows): Update.
2249         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2250         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2251         (tui_display_registers_from, tui_check_register_values): Update.
2252         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2253         pointer.
2254         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2255         window.
2256         (tui_free_data_content): Update.
2257         (free_content_elements) <case DATA_WIN>: Free the window.
2258
2259 2019-06-25  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2262         Update.
2263         * tui/tui-layout.c (make_command_window)
2264         (show_source_disasm_command, show_data, init_and_make_win)
2265         (show_source_or_disasm_and_command): Update.
2266         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2267         method.
2268         <can_highight, is_highlighted>: Now bool.
2269         (tui_set_win_highlight): Don't declare.
2270         * tui/tui-data.c (tui_set_win_highlight): Remove.
2271
2272 2019-06-25  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-wingeneral.c (make_visible): Remove check of window
2275         type.
2276
2277 2019-06-25  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-win.c (tui_win_info::max_height)
2280         (tui_cmd_window::max_height): New methods.
2281         (new_height_ok): Call max_height.
2282         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2283         <max_height>: New method.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-win.c (tui_source_window_base::set_new_height)
2288         (tui_data_window::set_new_height): New methods.
2289         (make_invisible_and_set_new_height): Call set_new_height method.
2290         * tui/tui-data.h (struct tui_win_info)
2291         (struct tui_source_window_base, struct tui_data_window)
2292         <set_new_height>: New method.
2293
2294 2019-06-25  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2297         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2298         tui_refresh_data_win.
2299         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2300         method.
2301         (tui_refresh_all_win): Call the refresh_all method.
2302         (tui_set_focus): Likewise.
2303         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2304         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2305         Likewise.
2306
2307 2019-06-25  Tom Tromey  <tom@tromey.com>
2308
2309         * tui/tui-winsource.h (tui_refill_source_window)
2310         (tui_set_is_exec_point_at): Don't declare.
2311         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2312         (tui_source_window_base::refill): Rename from
2313         tui_refill_source_window.
2314         (tui_source_window_base::do_scroll_horizontal): Update.
2315         (tui_source_window_base::set_is_exec_point_at): Rename from
2316         tui_set_is_exec_point_at.
2317         (tui_update_all_breakpoint_info): Update.
2318         * tui/tui-stack.c (tui_show_frame_info): Update.
2319         * tui/tui-layout.c (show_data): Add cast.
2320         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2321         * tui/tui-data.h (struct tui_source_window_base) <refill,
2322         set_is_exec_point_at>: New methods.
2323         (tui_source_windows, tui_add_to_source_windows): Update types.
2324         (tui_add_to_source_windows): Remove redundant declaration.
2325         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2326         (tui_source_windows): Change return type.
2327         (tui_clear_source_windows_detail): Update.
2328         (tui_add_to_source_windows): Change type of parameter.
2329         (tui_free_all_source_wins_content): Update.
2330
2331 2019-06-25  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-wingeneral.c (tui_win_info::refresh)
2334         (tui_source_window_base::refresh): New methods.
2335         (tui_refresh_all): Call the refresh method.
2336         * tui/tui-data.h (struct tui_win_info)
2337         (struct tui_source_window_base) <refresh>: New method.
2338
2339 2019-06-25  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui.h (tui_is_window_visible): Return bool.
2342         * tui/tui.c (tui_is_window_visible): Return bool.
2343         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2344         (tui_make_visible, tui_make_invisible)
2345         (tui_win_info::make_visible)
2346         (tui_source_window_base::make_visible, make_all_visible)
2347         (tui_make_all_visible, tui_make_all_invisible): Update.
2348         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2349         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2350         bool.
2351         (struct tui_win_info, struct tui_source_window_base)
2352         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2353         * tui/tui-data.c (tui_init_generic_part): Update.
2354
2355 2019-06-25  Tom Tromey  <tom@tromey.com>
2356
2357         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2358         (tui_source_window_base::make_visible): New methods.
2359         (make_all_visible): Make method call.
2360         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2361         (struct tui_source_window_base, struct tui_cmd_window): Override
2362         make_visible.
2363         (tui_win_is_source_type): Don't declare.
2364         * tui/tui-data.c (tui_win_is_source_type): Remove.
2365
2366 2019-06-25  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2369         NULL check.
2370
2371 2019-06-25  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2374         Inline constructor.  Add initializers for members.
2375         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2376         constructors; now inline in class.
2377
2378 2019-06-25  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-regs.c (tui_show_registers): Update.
2381         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2382         bool.
2383         * tui/tui-data.c (tui_data_window::clear_detail)
2384         (tui_data_window): Update.
2385
2386 2019-06-25  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-windata.c (tui_display_all_data)
2389         (tui_display_data_from_line, tui_display_data_from)
2390         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2391         Update.
2392         * tui/tui-regs.c (tui_last_regs_line_no)
2393         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2394         (tui_show_registers, tui_show_register_group)
2395         (tui_display_registers_from, tui_display_reg_element_at_line)
2396         (tui_display_registers_from_line, tui_check_register_values)
2397         (tui_reg_next, tui_reg_prev): Update.
2398         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2399         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2400         tui_data_window.
2401         (struct tui_win_info) <detail>: Remove.  Add new fields from
2402         tui_data_info.
2403         (TUI_DATA_WIN): Add cast.
2404         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2405         (~tui_data_window): Simplify.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-layout.c (show_source_disasm_command)
2410         (show_source_or_disasm_and_command): Update.
2411         * tui/tui-io.c (update_cmdwin_start_line)
2412         (tui_redisplay_readline): Update.
2413         * tui/tui-data.h (struct tui_command_info): Remove.
2414         (struct tui_win_info) <detail>: Remove command_info member.
2415         (struct tui_data_window) <start_line>: New member, from
2416         tui_command_info.
2417         (TUI_CMD_WIN): Add casts.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-winsource.c (tui_update_source_window)
2422         (tui_refill_source_window)
2423         (tui_source_window_base::do_scroll_horizontal)
2424         (tui_update_breakpoint_info, tui_set_exec_info_content)
2425         (tui_show_exec_info_content, tui_erase_exec_info_content)
2426         (tui_clear_exec_info_content): Update.
2427         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2428         Update.
2429         * tui/tui-win.c (make_invisible_and_set_new_height)
2430         (make_visible_with_new_height): Update.
2431         * tui/tui-source.c (tui_set_source_content)
2432         (tui_show_symtab_source): Update.
2433         * tui/tui-layout.c (extract_display_start_addr)
2434         (show_source_disasm_command, show_data)
2435         (make_source_or_disasm_window)
2436         (show_source_or_disasm_and_command): Update.
2437         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2438         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2439         "gdbarch".
2440         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2441         to tui_source_window_base.
2442         (struct tui_win_info) <detail>: Remove source_info member.
2443         (struct tui_source_window_base) <has_locator>: Inline.
2444         Move contents from tui_source_info; rename has_locator member to
2445         m_has_locator.
2446         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2447         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2448         header file.
2449         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2450         Simplify.
2451         (tui_free_all_source_wins_content): Cast to
2452         tui_source_window_base.
2453
2454 2019-06-25  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-win.c (make_invisible_and_set_new_height)
2457         (make_visible_with_new_height): Call has_locator method.
2458         * tui/tui-layout.c (show_source_disasm_command, show_data)
2459         (show_source_or_disasm_and_command): Update for bool change.
2460         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2461         (tui_win_info) <has_locator>: New method.
2462         (struct tui_source_window_base) <has_locator>: New method.
2463         (tui_win_has_locator): Don't declare.
2464         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2465         from tui_win_has_locator.
2466         (tui_source_window_base): Use false, not FALSE.
2467
2468 2019-06-25  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2471         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2472         clear_detail method directly.
2473         (tui_clear_win_detail): Remove.
2474
2475 2019-06-25  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2478         "this", not TUI_DISASM_WIN.
2479
2480 2019-06-25  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2483         declare.
2484         * tui/tui-winsource.c
2485         (tui_source_window_base::do_scroll_horizontal): Rename from
2486         tui_horizontal_source_scroll.
2487         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2488         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2489         from tui_vertical_data_scroll.
2490         * tui/tui-win.h (tui_scroll): Don't declare.
2491         * tui/tui-win.c (tui_win_info::forward_scroll)
2492         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2493         (tui_win_info::right_scroll): Rename and update.
2494         (tui_scroll_forward_command, tui_scroll_backward_command)
2495         (tui_scroll_left_command, tui_scroll_right_command): Update.
2496         (tui_scroll): Remove.
2497         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2498         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2499         from tui_vertical_source_scroll.
2500         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2501         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2502         from tui_vertical_disassem_scroll.
2503         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2504         do_scroll_horizontal>: New methods.
2505         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2506         Likewise.
2507         (struct tui_source_window_base): Add do_scroll_horizontal.
2508         (struct tui_source_window, struct tui_disasm_window): Add
2509         do_scroll_vertical.
2510         (struct tui_data_window, struct tui_cmd_window): Add
2511         do_scroll_horizontal and do_scroll_vertical.
2512         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-data.h (struct tui_source_window_base): New struct.
2517         (struct tui_source_window): Derive from tui_source_window_base.
2518         (struct tui_disasm_window): New struct.
2519         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2520         from tui_source_window::clear_detail.
2521         (tui_source_window_base): Rename from tui_source_window.
2522         (~tui_source_window_base): Rename from ~tui_source_window.
2523         (tui_alloc_win_info): Create a tui_disasm_window.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-data.h (struct tui_source_window)
2528         (struct tui_data_window): Declare destructors.
2529         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2530         destructors.
2531         (tui_win_info): Simplify.
2532
2533 2019-06-25  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-winsource.c (tui_display_main)
2536         (tui_update_source_windows_with_addr)
2537         (tui_update_all_breakpoint_info): Update.
2538         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2539         (new_height_ok, parse_scrolling_args): Update.
2540         * tui/tui-stack.c (tui_show_frame_info): Update.
2541         * tui/tui-data.h (struct tui_list): Remove.
2542         (tui_source_windows): Return a reference to a std::vector.
2543         * tui/tui-data.c (source_windows): Now a std::vector.
2544         (tui_source_windows): Change return type.
2545         (tui_clear_source_windows): Rewrite.
2546         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2547         (tui_free_all_source_wins_content): Rewrite.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2552         (struct tui_data_window, struct tui_cmd_window): Declare
2553         clear_detail method.
2554         * tui/tui-data.c (tui_source_window::clear_detail)
2555         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2556         methods.
2557         (tui_clear_win_detail): Simplify.
2558
2559 2019-06-25  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-layout.c (make_source_window, make_disasm_window)
2562         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2563         Return the new window.
2564         (show_source_disasm_command, show_data)
2565         (show_source_or_disasm_and_command): Update.
2566
2567 2019-06-25  Tom Tromey  <tom@tromey.com>
2568
2569         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2570         parameter.  Return the new window.
2571         (show_source_disasm_command): Update and remove NULL check.
2572         (show_source_or_disasm_and_command): Update.
2573
2574 2019-06-25  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2577
2578 2019-06-25  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-data.h (struct tui_win_info): Make constructor
2581         protected.  Make destructor virtual.  Add initializers.
2582         (tui_source_window, tui_data_window, tui_cmd_window): New
2583         classes.
2584         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2585         constructor.  Add "type" parameter.
2586         (tui_source_window, tui_data_window, tui_cmd_window): New
2587         constructors.
2588         (tui_alloc_win_info): Instantiate the appropriate subclass.
2589
2590 2019-06-25  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-win.c (tui_resize_all): Use delete.
2593         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2594         destructor.
2595         (tui_free_window): Don't declare.
2596         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2597         Update.
2598
2599 2019-06-25  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-data.h (struct tui_win_info): Add constructor.
2602         * tui/tui-data.c (tui_alloc_win_info): Use new.
2603         (tui_free_window): Use delete.
2604
2605 2019-06-22  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2608         declare.
2609         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2610
2611 2019-06-22  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2614         declare.
2615         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2616
2617 2019-06-22  Tom de Vries  <tdevries@suse.de>
2618
2619         * dwarf2read.c (create_addrmap_from_aranges)
2620         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2621         instead of '%zu'.
2622
2623 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2624
2625         * dwarf2read.h (dwarf2_section_info_def): Remove.
2626         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2627         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2628         std::vector<dwarf2_section_info>.
2629         (struct dwo_file) <~dwo_file>: Remove.
2630         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2631         types field.
2632         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2633         (dwarf2_read_debug_names): Likewise.
2634         (create_debug_types_hash_table): Change parameter type to
2635         array_view, adjust code accordingly.
2636         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2637         (partial_die_info::fixup): Likewise.
2638         (determine_prefix): Likewise.
2639         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2640
2641 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2642
2643         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2644         gdb_bfd_ref_ptr.
2645         <~dwo_file>: Remove call to gdb_bfd_unref.
2646         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2647         gdb_bfd_ref_ptr::get.
2648
2649 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2650
2651         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2652         type to htab_up.
2653         * dwarf2read.c (struct dwo_file): Initialize fields.
2654         <~dwo_file>: New.
2655         (free_dwo_file): Remove, move content to ~dwo_file.
2656         (struct dwo_file_deleter): Remove.
2657         (dwo_file_up>: Remove custom deleter.
2658         (free_dwo_files): Remove.
2659         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2660         dwo_files.
2661         (process_skeletonless_type_units): Call unique_ptr::get.
2662         (allocate_dwo_file_hash_table): Add deleter to created hash
2663         table.  Change return type to htab_up.
2664         (lookup_dwo_file_slot): Don't memset dwo_file, call
2665         unique_ptr::get.
2666         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2667         (create_dwo_unit_in_dwp_v2): Likewise.
2668         (open_and_init_dwo_file): Likewise.
2669         (free_dwo_file_from_slot): Remove.
2670
2671 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2672
2673         * dwarf2read.h (struct dwarf2_section_info) <readin,
2674         is_virtual>: Change type to bool.
2675         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2676         true instead of 1.
2677
2678 2019-06-19  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-data.h (tui_init_content_element): Don't declare.
2681
2682 2019-06-19  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-data.h (tui_init_win_info): Don't declare.
2685
2686 2019-06-19  Tom de Vries  <tdevries@suse.de>
2687
2688         * dwarf2read.h (abstract_to_concrete): Change type to
2689         std::unordered_map<sect_offset, std::vector<sect_offset>,
2690         gdb::hash_enum<sect_offset>>.
2691
2692 2019-06-19  Tom Tromey  <tromey@adacore.com>
2693
2694         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2695         EVAL_AVOID_SIDE_EFFECTS specially.
2696
2697 2019-06-19  Tom Tromey  <tromey@adacore.com>
2698
2699         * source-cache.c (highlighter): New global.
2700         (source_cache::get_source_lines): Create a highlighter on demand.
2701
2702 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2703
2704         * defs.h (deprecated_interactive_hook): Delete declaration.
2705         * interps.c (clear_interpreter_hooks): Remove use of
2706         deprecated_interactive_hook.
2707         * top.c (deprecated_interactive_hook): Delete definition.
2708         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2709
2710 2019-06-18  Tom de Vries  <tdevries@suse.de>
2711
2712         PR gdb/24515
2713         * dwarf2read.h (abstract_to_concrete): Change type from
2714         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2715         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2716         * dwarf2read.c (read_variable): Update.
2717         (dwarf2_fetch_die_loc_sect_off): Update.
2718
2719 2019-06-17  Tom de Vries  <tdevries@suse.de>
2720
2721         PR gdb/24617
2722         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2723         accessing parent[parent_len - 1].
2724
2725 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2726
2727         PR gdb/24364
2728         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2729         call dtrace_process_dof with NULL dof.
2730
2731 2019-06-16  Tom de Vries  <tdevries@suse.de>
2732
2733         PR gdb/24445
2734         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2735
2736 2019-06-16  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2739         (make_all_visible): Use address of member.
2740
2741 2019-06-16  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2744         (tui_free_window, free_content, free_content_elements): Remove
2745         unnecessary cast.
2746         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2747         cast.
2748         * tui/tui-regs.c (tui_show_register_group)
2749         (tui_display_registers_from, tui_display_reg_element_at_line):
2750         Remove unnecessary cast.
2751
2752 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2753
2754         * linux-nat.c (normal_mask): Delete.
2755         (_initialize_linux_nat): Don't initialise normal_mask.
2756
2757 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2758
2759         PR gdb/24445
2760         * dwarf-index-write.h (write_psymtabs_to_index): Add
2761         dwz_basename parameter.
2762         * dwarf-index-write.c (write_gdbindex): Move file writing to
2763         write_gdbindex_1.  Change return type void.
2764         (assert_file_size): Move up, remove filename parameter.
2765         (write_gdbindex_1): New function.
2766         (write_debug_names): Change return type to void, call
2767         assert_file_size.
2768         (struct index_wip_file): New struct.
2769         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2770         file logic to index_wip_file.  Write index for dwz file if
2771         needed.
2772         (save_gdb_index_command): Pass basename of dwz file, if present.
2773         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2774         build-id of dwz file, if present.
2775         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2776         (dwarf2_get_dwz_file): Likewise.
2777         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2778         (dwarf2_get_dwz_file): Likewise.
2779
2780 2019-06-16  Tom Tromey  <tom@tromey.com>
2781
2782         * coffread.c (process_coff_symbol): Use xstrdup.
2783         * value.c (create_internalvar): Use xstrdup.
2784
2785 2019-06-16  Tom Tromey  <tom@tromey.com>
2786
2787         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2788         * breakpoint.c (stopin_command, stopat_command)
2789         (until_break_command, decode_location_default): Remove unnecessary
2790         cast.
2791         * utils.c (subset_compare): Remove unnecessary cast.
2792         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2793         cast.
2794         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2795         cast.
2796         * infcmd.c (path_command): Remove unnecessary cast.
2797         * coffread.c (decode_type): Remove unnecessary cast.
2798         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2799         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2800         * tui/tui-stack.c (tui_show_locator_content)
2801         (tui_show_frame_info): Remove unnecessary cast.
2802         * tui/tui-win.c (tui_scroll_forward_command)
2803         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2804         (parse_scrolling_args): Remove unnecessary cast.
2805         * tui/tui-data.c (init_win_info, tui_del_window)
2806         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2807         (free_content_elements): Remove unnecessary cast.
2808         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2809         unnecessary cast.
2810         * tui/tui-source.c (tui_set_source_content)
2811         (tui_vertical_source_scroll): Remove unnecessary cast.
2812         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2813         cast.
2814         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2815         * tui/tui-regs.c (tui_display_registers_from)
2816         (tui_display_register): Remove unnecessary cast.
2817         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2818         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2819         (make_visible): Remove unnecessary cast.
2820         * tui/tui-winsource.c (tui_erase_source_content)
2821         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2822         unnecessary cast.
2823         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2824         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2825         * stabsread.c (read_type, read_array_type, read_range_type):
2826         Remove unnecessary cast.
2827         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2828         (parse_symbol, parse_type, upgrade_type, parse_external)
2829         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2830         unnecessary cast.
2831         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2832
2833 2019-06-16  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-data.c (tui_alloc_generic_win_info)
2836         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2837         checks.
2838
2839 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2840             Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * f-typeprint.c (f_print_type): Don't return early for not
2843         associated or not allocated types.
2844         (f_type_print_varspec_suffix): Add print_rank parameter and print
2845         ranks of array types in case they dangling.
2846         (f_type_print_base): Add print_rank parameter.
2847
2848 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * NEWS: Mention new MI commands.
2851         * break-catch-throw.c (enum exception_event_kind): Move to
2852         breakpoint.h.
2853         (print_mention_exception_catchpoint): Output text as a single
2854         message.
2855         (catch_exception_command_1): Rename to...
2856         (catch_exception_event): ...this, make non-static, update header
2857         command, and change some parameter types.
2858         (catch_catch_command): Update for changes to
2859         catch_exception_command_1.
2860         (catch_throw_command): Likewise.
2861         (catch_rethrow_command): Likewise.
2862         * breakpoint.c (enum exception_event_kind): Delete.
2863         * breakpoint.h (enum exception_event_kind): Moved here from
2864         break-catch-throw.c.
2865         (catch_exception_event): Declare.
2866         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2867         (mi_cmd_catch_throw): New function.
2868         (mi_cmd_catch_rethrow): New function.
2869         (mi_cmd_catch_catch): New function.
2870         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2871         'catch-catch' entries.
2872         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2873         (mi_cmd_catch_rethrow): Declare.
2874         (mi_cmd_catch_catch): Declare.
2875
2876 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * annotate.c (annotate_source_line): Change return type to void,
2879         update implementation to match.
2880         * annotate.h (annotate_source_line): Change return type to void,
2881         update header comment.
2882         * stack.c (print_frame_info): Don't change what frame information
2883         is printed based on whether annotations are on or not.
2884
2885 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2888         (annotate_source): Make static.
2889         (annotate_source_line): Moved from source.c and renamed from
2890         identify_source_line.  Update the return type.
2891         * annotate.h (annotate_source): Delete declaration.
2892         (annotate_source_line): Declaration moved from source.h, and
2893         renamed from identify_source_line.  Return type updated.
2894         * source.c (identify_source_line): Moved to annotate.c and renamed
2895         to annotate_source_line.
2896         (info_line_command): Remove check of annotation_level.
2897         * source.h (identify_source_line): Move declaration to annotate.h
2898         and rename to annotate_source_line.
2899         * stack.c: Add 'annotate.h' include.
2900         (print_frame_info): Remove check of annotation_level before
2901         calling annotate_source_line.
2902
2903 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2904
2905         * source-cache.c (source_cache::get_plain_source_lines): Use
2906         open_source_file_with_line_charpos instead of just
2907         open_source_file, remove call to find_source_lines.
2908         (source_cache::get_source_lines): Likewise.
2909         * source.c (find_source_lines): Make static.
2910         (get_filename_and_charpos): Renamed into...
2911         (open_source_file_with_line_charpos): ..this along with changes to
2912         return a scoped_fd, and some other minor clean ups.
2913         (identify_source_line): Use open_source_file_with_line_charpos.
2914         (search_command_helper): Use open_source_file_with_line_charpos
2915         instead of just open_source_file, remove call to
2916         find_source_lines.
2917         * source.h (open_source_file_with_line_charpos): Declare new
2918         function.
2919         (find_source_lines): Delete declaration.
2920
2921 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * source.c (get_filename_and_charpos): Remove fullname
2924         parameter.
2925         (identify_source_line): Update call to get_filename_and_charpos.
2926
2927 2019-06-14  Tom Tromey  <tromey@adacore.com>
2928
2929         PR gdb/24502:
2930         * ui-style.h (skip_ansi_escape): Update comment.
2931         * ui-file.h (class no_terminal_escape_file): New class.
2932         * ui-file.c (no_terminal_escape_file::write)
2933         (no_terminal_escape_file::puts): New methods.
2934         * cli/cli-logging.c (handle_redirections): Use
2935         no_terminal_escape_file.
2936
2937 2019-06-14  Tom Tromey  <tromey@adacore.com>
2938
2939         * NEWS: Move convenience variable news above Python news.
2940
2941 2019-06-14  Tom Tromey  <tom@tromey.com>
2942
2943         * gnulib: Move directory to top-level.
2944         * configure.ac: Don't configure gnulib.
2945         * configure: Rebuild.
2946         * common/common-defs.h: Use new path to gnulib.
2947         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2948         (GNULIB_H): Remove.
2949         (INCGNU): Look in new gnulib location.
2950         (HFILES_NO_SRCDIR): Remove gnulib files.
2951         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2952         (generated_files): Remove GNULIB_H.
2953         ($(LIBGNU), all-lib): Remove targets.
2954         (distclean): Don't mention GNULIB_BUILDDIR.
2955         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2956
2957 2019-06-14  Tom Tromey  <tromey@adacore.com>
2958
2959         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2960         Warn if symbol file does not provide any symbols.
2961
2962 2019-06-14  Tom Tromey  <tromey@adacore.com>
2963
2964         * source.c (find_and_open_source): Respect basenames_may_differ.
2965
2966 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * annotate.c (annotate_breakpoints_invalid): Make use of
2969         scoped_restore_terminal_state.
2970         (annotate_frames_invalid): Likewise.
2971
2972 2019-06-14  Tom Tromey  <tromey@adacore.com>
2973
2974         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2975         allow assignment to an internalvar.
2976
2977 2019-06-14  Tom Tromey  <tromey@adacore.com>
2978
2979         * ada-lex.l: Allow "_" in attribute names.
2980
2981 2019-06-14  Tom Tromey  <tromey@adacore.com>
2982
2983         PR gdb/24653:
2984         * regcache.c (registers_changed): Don't call alloca.
2985         * top.c (execute_command): Don't call alloca.
2986
2987 2019-06-13  Pedro Alves  <palves@redhat.com>
2988
2989         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2990         'expression'.  When parsing an expression, error out if there's
2991         junk after "unlimited".
2992         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2993         (do_set_command): Adjust calls to is_unlimited_literal.
2994
2995 2019-06-13  Pedro Alves  <palves@redhat.com>
2996
2997         * compile/compile.c (make_compile_options_def_group): Add braces
2998         around array_view initializer.
2999         * thread.c (make_thread_apply_all_options_def_group)
3000         (make_thread_apply_all_options_def_group): Likewise.
3001
3002 2019-06-13  Pedro Alves  <palves@redhat.com>
3003
3004         * NEWS (New commands): Mention "maint test-options
3005         require-delimiter", "maint test-options unknown-is-error", "maint
3006         test-options unknown-is-operand" and "maint show
3007         test-options-completion-result".
3008         (New command options, command completion): New section.
3009         (Completion improvements): New section.
3010         Mention that you can abbreviate "unlimited".
3011
3012 2019-06-13  Pedro Alves  <palves@redhat.com>
3013
3014         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3015         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3016         * unittests/cli-utils-selftests.c (test_parse_flags)
3017         (test_parse_flags_qcs): Delete.
3018         (test_cli_utils): Don't call deleted functions.
3019
3020 2019-06-13  Pedro Alves  <palves@redhat.com>
3021
3022         * thread.c: Include "cli/cli-option.h".
3023         (tp_array_compar_ascending): Global.
3024         (tp_array_compar): Delete function.
3025         (tp_array_compar_ascending, tp_array_compar_descending): New
3026         functions.
3027         (ascending_option_def, qcs_flag_option_def)
3028         (thr_qcs_flags_option_defs)
3029         (make_thread_apply_all_options_def_group)
3030         (make_thread_apply_options_def_group): New.
3031         (thread_apply_all_command): Use gdb::option::process_options.
3032         (thread_apply_command_completer)
3033         (thread_apply_all_command_completer): New.
3034         (thread_apply_command): Use gdb::option::process_options.
3035         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3036         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3037         to generate help text of "thread apply".  Adjust "taas"'s help.
3038         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3039         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3040
3041 2019-06-13  Pedro Alves  <palves@redhat.com>
3042
3043         * thread.c (thread_apply_command): Check for invalid TID with
3044         isdigit instead of !isalpha.
3045
3046 2019-06-13  Pedro Alves  <palves@redhat.com>
3047
3048         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3049         (validate_flags_qcs): New.
3050         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3051         (validate_flags_qcs): Declare.
3052         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3053         (make_frame_apply_options_def_group): New.
3054         (frame_apply_command_count): Process options with
3055         gdb::option::process_options.
3056         (frame_apply_completer): New.
3057         (frame_apply_level_completer, frame_apply_all_completer)
3058         (frame_apply_completer): New.
3059         (_initialize_stack): Update help of "frame apply", "frame apply
3060         level", "frame apply all" and "faas" to mention supported options
3061         and install command completers.
3062         * stack.h (frame_apply_all_completer): Declare.
3063         * thread.c: Include "stack.h".
3064         (tfaas_command): Add "--".
3065         (_initialize_thread): Update help "tfaas" to mention supported
3066         options and install command completer.
3067
3068 2019-06-13  Pedro Alves  <palves@redhat.com>
3069
3070         * completer.c (complete_nested_command_line): New.
3071         (gdb_completion_word_break_characters_throw): Add assertion.
3072         * completer.h (complete_nested_command_line): Declare.
3073
3074 2019-06-13  Pedro Alves  <palves@redhat.com>
3075
3076         * stack.c (parse_backtrace_qualifiers): New.
3077         (backtrace_command): Use it.
3078         (backtrace_command_completer): Complete on qualifiers.
3079
3080 2019-06-13  Pedro Alves  <palves@redhat.com>
3081
3082         * frame.c: Include "cli/cli-option.h.
3083         (user_set_backtrace_options): New.
3084         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3085         Delete.
3086         (get_prev_frame): Adjust.
3087         (boolean_option_def, uinteger_option_def)
3088         (set_backtrace_option_defs): New.
3089         (_initialize_frame): Adjust and use
3090         gdb::option::add_setshow_cmds_for_options to install "set
3091         backtrace past-main" and "set backtrace past-entry".
3092         * frame.h: Include "cli/cli-option.h".
3093         (struct frame_print_options): Forward declare.
3094         (print_frame_arguments_all, print_frame_arguments_scalars)
3095         (print_frame_arguments_none): Declare.
3096         (print_entry_values): Delete declaration.
3097         (struct frame_print_options, user_frame_print_options): New.
3098         (struct set_backtrace_options): New.
3099         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3100         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3101         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3102         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3103         (list_args_or_locals): Add frame_print_options parameter.
3104         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3105         * python/py-framefilter.c (enumerate_args): Pass down
3106         USER_FRAME_PRINT_OPTIONS.
3107         * stack.c: Include "cli/cli-option.h".
3108         (print_frame_arguments_all, print_frame_arguments_scalars)
3109         (print_frame_arguments_none): Declare.
3110         (print_raw_frame_arguments, print_entry_values): Delete.
3111         (user_frame_print_options): New.
3112         (boolean_option_def, enum_option_def, frame_print_option_defs):
3113         New.
3114         (struct backtrace_cmd_options): New.
3115         (bt_flag_option_def): New.
3116         (backtrace_command_option_defs): New.
3117         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3118         (print_frame_arg, read_frame_arg, print_frame_args)
3119         (print_frame_info, print_frame): Add frame_print_options parameter
3120         and use it.
3121         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3122         (backtrace_command_1): Add frame_print_options and
3123         backtrace_cmd_options parameters and use them.
3124         (make_backtrace_options_def_group): New.
3125         (backtrace_command): Process command options with
3126         gdb::option::process_options.
3127         (backtrace_command_completer): New.
3128         (_initialize_stack): Extend "backtrace"'s help to mention
3129         supported options.  Install completer for "backtrace".
3130         Install some settings commands with add_setshow_cmds_for_options.
3131
3132 2019-06-13  Pedro Alves  <palves@redhat.com>
3133
3134         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3135         and that "set/show print raw frame-arguments" are now deprecated.
3136
3137         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3138         command.
3139         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3140         * stack.c (_initialize_stack): Install "set/show print
3141         raw-frame-arguments", and deprecate "set/show print raw
3142         frame-arguments".
3143         * valprint.c (_initialize_valprint): Deprecate "set/show print
3144         raw".
3145
3146 2019-06-13  Pedro Alves  <palves@redhat.com>
3147
3148         * compile/compile.c (struct compile_options): New.
3149         (compile_flag_option_def, compile_command_option_defs)
3150         (make_compile_options_def_group): New.
3151         (compile_file_command): Handle options with
3152         gdb::option::process_options.
3153         (compile_file_command_completer): New function.
3154         (compile_code_command): Handle options with
3155         gdb::option::process_options.
3156         (compile_code_command_completer): New function.
3157         (_initialize_compiler): Install completers for "compile code" and
3158         "compile file".  Mention available options in "compile code" and
3159         "compile code"'s help.
3160         * completer.c (advance_to_completion_word): New, factored out from
3161         ...
3162         (advance_to_expression_complete_word_point): ... this.
3163         (advance_to_filename_complete_word_point): New.
3164         * completer.h (advance_to_filename_complete_word_point): New
3165         declaration.
3166
3167 2019-06-13  Pedro Alves  <palves@redhat.com>
3168
3169         * compile/compile.c: Include "cli/cli-option.h".
3170         (compile_print_value): Scope data pointer is now a
3171         value_print_options pointer; adjust.
3172         (compile_print_command): Process options.  Scope data pointer is
3173         now a value_print_options pointer; adjust.
3174         (_initialize_compile): Update "compile print"'s help to include
3175         supported options.  Install a completer for "compile print".
3176         * cp-valprint.c (show_vtblprint, show_objectprint)
3177         (show_static_field_print): Delete.
3178         (_initialize_cp_valprint): Don't install "set print
3179         static-members", "set print vtbl", "set print object" here.
3180         * printcmd.c: Include "cli/cli-option.h" and
3181         "common/gdb_optional.h".
3182         (print_command_parse_format): Rework to fill in a
3183         value_print_options instead of a format_data.
3184         (print_value): Change parameter type from format_data pointer to
3185         value_print_options reference.  Adjust.
3186         (print_command_1): Process options.  Adjust to pass down a
3187         value_print_options.
3188         (print_command_completer): New.
3189         (_initialize_printcmd): Install print_command_completer as
3190         handle_brkchars completer for the "print" command.  Update
3191         "print"'s help to include supported options.
3192         * valprint.c: Include "cli/cli-option.h".
3193         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3194         here from cp-valprint.c.
3195         (boolean_option_def, uinteger_option_def)
3196         (value_print_option_defs, make_value_print_options_def_group):
3197         New.  Use gdb::option::add_setshow_cmds_for_options to install
3198         "set print elements", "set print null-stop", "set print repeats",
3199         "set print pretty", "set print union", "set print array", "set
3200         print address", "set print symbol", "set print array-indexes".
3201         * valprint.h: Include <string> and "cli/cli-option.h".
3202         (make_value_print_options_def_group): Declare.
3203         (print_value): Change parameter type from format_data pointer to
3204         value_print_options reference.
3205         (print_command_completer): Declare.
3206
3207 2019-06-13  Pedro Alves  <palves@redhat.com>
3208
3209         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3210         (COMMON_SFILES): Add maint-test-settings.c.
3211         * cli/cli-decode.c (boolean_enums): New global, factored out from
3212         ...
3213         (add_setshow_boolean_cmd): ... here.
3214         * cli/cli-decode.h (boolean_enums): Declare.
3215         * cli/cli-option.c: New file.
3216         * cli/cli-option.h: New file.
3217         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3218         factored out from ...
3219         (parse_cli_boolean_value(const char *)): ... this.
3220         (is_unlimited_literal): Change parameter type to pointer to
3221         pointer.  Adjust and advance ARG pointer.
3222         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3223         (parse_cli_var_enum): New, factored out from ...
3224         (do_set_command): ... this.  Adjust.
3225         * cli/cli-setshow.h (parse_cli_boolean_value)
3226         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3227         (parse_cli_var_enum): Declare.
3228         * cli/cli-utils.c: Include "cli/cli-option.h".
3229         (get_ulongest): New.
3230         * cli/cli-utils.h (get_ulongest): Declare.
3231         (check_for_argument): New overloads.
3232         * maint-test-options.c: New file.
3233
3234 2019-06-13  Pedro Alves  <palves@redhat.com>
3235
3236         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3237         parse a range if "-" is at the end of the string.
3238
3239 2019-06-13  Pedro Alves  <palves@redhat.com>
3240
3241         * cli/cli-setshow.c (parse_auto_binary_operation)
3242         (parse_cli_boolean_value): Don't allow "o".
3243
3244 2019-06-13  Pedro Alves  <palves@redhat.com>
3245
3246         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3247         * NEWS: Mention maint test-settings KIND.
3248         * maint-test-settings.c: New file.
3249
3250 2019-06-13  Pedro Alves  <palves@redhat.com>
3251
3252         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3253         completer.
3254         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3255         "set" completers.
3256
3257 2019-06-13  Pedro Alves  <palves@redhat.com>
3258
3259         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3260         after item.
3261
3262 2019-06-13  Pedro Alves  <palves@redhat.com>
3263
3264         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3265
3266 2019-06-13  Pedro Alves <palves@redhat.com>
3267
3268         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3269         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3270         call.
3271         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3272         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3273         calls.
3274         (check_for_argument): Skip spaces after argument.
3275
3276 2019-06-13  Pedro Alves  <palves@redhat.com>
3277
3278         * thread.c (thread_apply_command): Adjust TID parsing.
3279         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3280         detected before end of string.
3281         (tid_is_in_list): Error out if LIST is invalid.
3282
3283 2019-06-13  Pedro Alves  <palves@redhat.com>
3284
3285         * completer.c (complete_line_internal_1): Rewind completion word
3286         point.
3287         (completion_tracker::advance_custom_word_point_by): Change
3288         parameter type to int.
3289         * completer.h (completion_tracker::advance_custom_word_point_by):
3290         Likewise.
3291
3292 2019-06-13  Pedro Alves  <palves@redhat.com>
3293
3294         * completer.c (advance_to_completion_word): Handle delimiters.
3295
3296 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3297
3298         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3299
3300 2019-06-11  Tom Tromey  <tom@tromey.com>
3301
3302         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3303         (xmalloc_failed): Move to alloc.c.
3304         * alloc.c: New file.
3305         * Makefile.in (COMMON_SFILES): Add alloc.c.
3306
3307 2019-06-11  Tom Tromey  <tom@tromey.com>
3308
3309         * nat/linux-waitpid.c: Don't include server.h.
3310         (linux_debug): Remove.
3311         (my_waitpid): Update.
3312
3313 2019-06-11  Tom Tromey  <tromey@adacore.com>
3314
3315         * infcall.c (_initialize_infcall): Remove trailing newline from
3316         help.
3317         * user-regs.c (_initialize_user_regs): Remove trailing newline
3318         from help.
3319         * typeprint.c (_initialize_typeprint): Remove trailing newline
3320         from help.
3321         * reverse.c (_initialize_reverse): Remove trailing newlines from
3322         help.
3323         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3324         from help.
3325         * language.c (add_set_language_command): Remove trailing newline
3326         from help.
3327         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3328         help.
3329         * disasm.c (_initialize_disasm): Remove trailing newline from
3330         help.
3331         * top.c (init_main): Remove trailing newline from help.
3332         * interps.c (_initialize_interpreter): Remove trailing newline
3333         from help.
3334         * btrace.c (_initialize_btrace): Remove trailing newlines from
3335         help.
3336         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3337         from help.
3338         * python/python.c (_initialize_python): Remove trailing newline
3339         from help.
3340         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3341         help.
3342         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3343         from help.  Reformat some text.
3344         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3345         from help.
3346         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3347         newline from help.
3348
3349 2019-06-11  Tom Tromey  <tromey@adacore.com>
3350
3351         * darwin-nat.c (darwin_decode_exception_message)
3352         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3353
3354 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3355
3356         * valops.c (value_slice): Check for not allocated or not
3357         associated values.
3358
3359 2019-06-10  Tom de Vries  <tdevries@suse.de>
3360
3361         PR gdb/24618
3362         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3363         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3364         invalid.
3365
3366 2019-06-10  Tom de Vries  <tdevries@suse.de>
3367
3368         PR gdb/24611
3369         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3370         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3371
3372 2019-06-10  Tom de Vries  <tdevries@suse.de>
3373
3374         PR symtab/24545
3375         * symtab.c (struct demangled_name_entry): Add language field.
3376         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3377         static minimal symbol".  Set and use language field.
3378
3379 2019-06-10  Tom Tromey  <tromey@adacore.com>
3380
3381         * ada-lang.c (_initialize_ada_language): Update help text.
3382
3383 2019-06-10  Tom Tromey  <tromey@adacore.com>
3384
3385         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3386         with a newline.
3387         * guile/guile.c (handle_boot_error): Don't end warning with a
3388         newline.
3389         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3390         warning with a newline.
3391         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3392         newline.
3393         (s12z_frame_cache): Likewise.
3394         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3395         a newline.
3396         * solib-svr4.c (disable_probes_interface): Don't end warning with
3397         a newline.
3398         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3399         newline.
3400         * python/python.c (do_finish_initialization): Don't end warning
3401         with a newline.
3402
3403 2019-06-10  Tom Tromey  <tom@tromey.com>
3404
3405         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3406         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3407         gdbpy_enter.
3408
3409 2019-06-10  Tom Tromey  <tromey@adacore.com>
3410
3411         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3412         data.
3413         (elf_new_init): Don't call stabsread_new_init.
3414         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3415         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3416         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3417
3418 2019-06-10  Tom de Vries  <tdevries@suse.de>
3419
3420         PR symtab/16264
3421         PR symtab/24517
3422         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3423
3424 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3425
3426         * source.c (find_and_open_source): Also rewrite relative file
3427         names.
3428
3429 2019-04-26  Amos Bird  <amosbird@gmail.com>
3430
3431         * annotate.c (annotate_thread_exited): Add "thread-exited"
3432         annotation.
3433
3434 2019-06-06  Tom Tromey  <tromey@adacore.com>
3435
3436         * maint.h (class scoped_command_stats): Use
3437         DISABLE_COPY_AND_ASSIGN.
3438         <print_time>: New method.
3439         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3440         print_time.
3441         (scoped_command_stats::print_time): New method.
3442
3443 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3444
3445         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3446         instructions of lengths 6 or 8 bytes.
3447
3448 2019-06-04  Pedro Alves  <palves@redhat.com>
3449
3450         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3451
3452         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3453         * breakpoint.c (condition_completer): Likewise.
3454         * cli/cli-dump.c (scan_expression): Likewise.
3455         * common/filestuff.c (mkdir_recursive): Likewise.
3456         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3457         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3458         (gdb_abspath): Likewise.
3459         * compile/compile-cplus-types.c
3460         (compile_cplus_instance::decl_name): Likewise.
3461         * completer.c (complete_explicit_location):
3462         (signal_completer, reg_or_group_completer_1): Likewise.
3463         * cp-support.c (cp_remove_params_if_any): Likewise.
3464         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3465         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3466         * infcmd.c (strip_bg_char): Likewise.
3467         * linespec.c (copy_token_string): Likewise.
3468         * mi/mi-main.c (output_cores): Likewise.
3469         * psymtab.c (psymtab_search_name):
3470         * symfile.c (test_set_ext_lang_command): Likewise.
3471         * target.c (target_fileio_read_stralloc): Likewise.
3472         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3473         * value.c (complete_internalvar): Likewise.
3474
3475 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3476
3477         Add objfile property to gdb.Type.
3478         * NEWS: Mention Python API addition.
3479         * python/py-type.c (typy_get_objfile): New method.
3480
3481 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3482
3483         * NEWS: Mention the new set|show style [title|highlight].
3484         Mention changes to "show style", "help" and "apropos".
3485
3486 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3487
3488         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3489         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3490         instead of print_help_for_command.
3491         (print_doc_of_command): New function.
3492         (help_list): Add 'apropos -v word' suggestion.
3493         (print_help_for_command): Style the command name using title style.
3494         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3495         (_initialize_cli_cmds): Describe -v in apropos_command help.
3496
3497 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3498
3499         * cli/cli-style.h (cli_style_option): Add name in constructor,
3500         add m_name class member, add constructor with intensity,
3501         add name class function.
3502         (cli_style_option::add_setshow_commands): Remove name argument.
3503         (highlight_style, title_style): New styles.
3504         * cli/cli-style.c (do_show): New function that shows a style
3505         characteristic styling the style name with itself.
3506         (set_style_name): New function.
3507         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3508         Update all callers according to the changes in cli/cli-style.h.
3509         * utils.h (fputs_highlighted): New function.
3510         * utils.c (fputs_highlighted): Likewise.
3511
3512 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3513
3514         * NEWS: Mention new pipe command and new convenience variables.
3515
3516 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3517
3518         * cli/cli-cmds.c (pipe_command): New function.
3519         (_initialize_cli_cmds): Call add_com for pipe_command.
3520         Define | as an alias for pipe.
3521         (exit_status_set_internal_vars): New function.
3522         (shell_escape): Call exit_status_set_internal_vars.
3523         cli/cli-decode.c (find_command_name_length): Recognize | as
3524         a single character command.
3525
3526 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3527
3528         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3529         top.c (execute_command_to_ui_file): New function, mostly a copy
3530         of execute_command_to_string.
3531         (execute_command_to_string): Implement by calling
3532         execute_command_to_ui_file.
3533
3534 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3535
3536         * top.h (saved_command_line): Remove declaration.
3537         * top.c (previous_saved_command_line, previous_repeat_arguments):
3538         New variables.
3539         (saved_command_line): Make static, define together with other
3540         'repeat variables'.
3541         (dont_repeat): Clear repeat_arguments.
3542         (repeat_previous, get_saved_command_line, save_command_line):
3543         New functions.
3544         (gdb_init): Initialize saved_command_line
3545         and previous_saved_command_line.
3546         * main.c (captured_main_1): Remove saved_command_line initialization.
3547         * event-top.c (handle_line_of_input): Update to use
3548         the new 'repeat' related functions instead of direct access to
3549         saved_command_line.
3550         * command.h (repeat_previous, get_saved_command_line,
3551         save_command_line): New declarations.
3552         (dont_repeat): Add comment.
3553
3554 2019-05-30  Tom Tromey  <tromey@adacore.com>
3555
3556         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3557         Fix comment.
3558         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3559
3560 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3561
3562         PR cli/24587
3563         * completer.c (complete): Initialize variable word.
3564
3565 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3566
3567         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3568         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3569         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3570         'body' is NULL to the outter 'if', protecting the '!is_define'
3571         situation as well.
3572
3573 2019-05-29  Tom Tromey  <tromey@adacore.com>
3574
3575         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3576         (dwarf_unknown): New function.
3577         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3578         (dwarf_type_encoding_name): Use dwarf_unknown.
3579
3580 2019-05-29  Tom Tromey  <tromey@adacore.com>
3581
3582         PR c++/20020:
3583         * cp-valprint.c (cp_print_value_fields): Call
3584         cp_print_static_field inside "try".
3585
3586 2019-05-29  Tom Tromey  <tromey@adacore.com>
3587
3588         * inflow.c (struct terminal_info): Add default operator=.
3589         * configure: Rebuild.
3590         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3591         -Wdeprecated-copy-dtor, -Wredundant-move.
3592
3593 2019-05-29  Tom Tromey  <tromey@adacore.com>
3594
3595         * NEWS: Add entry.
3596         * infcmd.c (print_return_value_1): Handle finish_print
3597         option.
3598         (show_print_finish): New function.
3599         (_initialize_infcmd): Add "set/show print finish" commands.
3600         * valprint.c (user_print_options): Initialize new member.
3601         * valprint.h (struct value_print_options) <finish_print>: New
3602         member.
3603
3604 2019-05-28  Tom Tromey  <tromey@adacore.com>
3605
3606         * ada-lang.c (ada_remove_Xbn_suffix)
3607         (find_old_style_renaming_symbol)
3608         (parse_old_style_renaming): Remove.
3609         (ada_find_renaming_symbol): Don't call
3610         find_old_style_renaming_symbol.
3611         (ada_is_renaming_symbol): Rename from
3612         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3613         bool.  Now static.
3614         (ada_read_var_value): Update and simplify.
3615         * ada-exp.y (write_var_or_type): Remove old code.
3616
3617 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3618
3619         * event-top.c: Remove include comment.
3620         * inflow.c (class scoped_ignore_sigttou): Move from here...
3621         * inflow.h (class scoped_ignore_sigttou): ...to here.
3622         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3623         * top.c:  Remove include comment.
3624
3625 2019-05-27  Tom Tromey  <tom@tromey.com>
3626
3627         * NEWS: Fix typo.
3628
3629 2019-05-22  Tom Tromey  <tromey@adacore.com>
3630
3631         * target.c (target_follow_exec): Constify parameter.
3632         * target-delegates.c: Rebuild.
3633         * remote.c (remote_target::follow_exec): Constify parameter.
3634         * infrun.c (follow_exec): Constify parameter.
3635         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3636         (target_follow_exec): Likewise.
3637
3638 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3639
3640         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3641         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3642
3643 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3644
3645         * NEWS: Add debugredirect and testsuite sections.
3646
3647 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3648
3649         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3650         target descriptions using exclusively floating point register name
3651         aliases.
3652
3653 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3654
3655         PR gdb/18644:
3656         * f-lang.c (build_fortran_types): Handle the case where
3657         gdbarch_floatformat_for_type returns a nullptr.
3658
3659 2019-05-21  Tom de Vries  <tdevries@suse.de>
3660
3661         PR cli/24587
3662         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3663
3664 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3665
3666         PR gdb/18644:
3667         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3668         16-byte floats.
3669         * i386-tdep.c (i386_floatformat_for_type): Use
3670         floatformats_ia64_quad for the 16-byte floating point component
3671         within a fortran 32-byte complex number.
3672
3673 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3676         delete default constructor.
3677         (find_partial_die): Update to return const struct.
3678         (partial_die_parent_scope): Move variable declaration into scope
3679         of its use and change its type to auto.
3680         (guess_partial_die_structure_name): Likewise.
3681         (partial_die_info::fixup): Likewise.
3682
3683 2019-05-17  Tom Tromey  <tromey@adacore.com>
3684
3685         * source.c (find_and_open_source): Remove cast.
3686
3687 2019-05-17  Tom Tromey  <tromey@adacore.com>
3688
3689         * annotate.c (annotate_source): Make "filename" const.
3690         * annotate.h (annotate_source): Use const.
3691
3692 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3693
3694         * disasm.c (set_disassembler_options): Send errors to stderr.
3695
3696 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3697
3698         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3699         (cli_interp_base::set_logging): Check debug_redirect.
3700         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3701         * cli/cli-logging.c (debug_redirect): Add static variable.
3702         (pop_output_files): Add default param.
3703         (handle_redirections): Print debug setting.
3704         (show_logging_command): Likewise.
3705         (_initialize_cli_logging): Add debugredirect command.
3706         * interps.c (current_interp_set_logging): Add debug_redirect
3707         parameter.
3708         * interps.h (set_logging): Add debug_redirect parameter.
3709         (current_interp_set_logging): Likewise.
3710         * mi/mi-common.h: Likewise.
3711         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3712
3713 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3714             Tom Tromey  <tromey@adacore.com>
3715
3716         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3717         directly.
3718         * cli/cli-interp.h (make_logging_output): Remove declaration.
3719         * cli/cli-logging.c (make_logging_output): Remove function.
3720         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3721         directly.
3722         * ui-file.c (tee_file::tee_file): Remove bools.
3723         (tee_file::~tee_file): Remove deletes.
3724         * ui-file.h (tee_file): Remove bools.
3725
3726 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3727
3728         * mi/mi-cmds.h (mi_cmd_complete): New function.
3729         * mi/mi-main.c (mi_cmd_complete): Likewise.
3730         * mi/mi-cmds.c: Define new MI command -complete.
3731         * NEWS: Mention new -complete command.
3732
3733 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3734
3735         * completer.h (complete): New function.
3736         * completer.c (complete): Likewise.
3737         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3738         function defined in completer.h.
3739
3740 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3741
3742         * MAINTAINERS (Write After Approval): Add myself.
3743
3744 2019-05-17  Tom de Vries  <tdevries@suse.de>
3745
3746         PR gdb/24094
3747         * dwarf2read.c (struct cu_partial_die_info): New struct.
3748         (find_partial_die): Return cu_partial_die_info.
3749         (partial_die_parent_scope, guess_partial_die_structure_name)
3750         (partial_die_info::fixup): Handle new return type of find_partial_die.
3751
3752 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3753
3754         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3755         "std::string", simplifying the algorithm.
3756
3757 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3758
3759         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3760         (stap_static_probe_ops::get_probes): Likewise.
3761
3762 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3763
3764         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3765         '-')" and "else if".
3766         (stap_parse_single_operand): Join checks for
3767         "gdbarch_stap_parse_special_token_p" and
3768         "gdbarch_stap_parse_special_token" in the same "if" statement.
3769         Invert check when verifying for operation on register
3770         displacement.
3771
3772 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3773
3774         * stap-probe.c (stap_get_opcode): Update comment.
3775         (stap_get_expected_argument_type): Likewise.
3776         (handle_stap_probe): Likewise.
3777
3778 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3779
3780         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3781         return type to 'bool'.  Adjust comment.  Use 'bool' when
3782         appropriate.
3783         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3784         * stap-probe.c (stap_parse_argument_1): Likewise.
3785         (stap_is_operator): Likewise.
3786         (stap_is_generic_prefix): Likewise.
3787         (stap_is_register_prefix): Likewise.
3788         (stap_is_register_indirection_prefix): Likewise.
3789         (stap_is_integer_prefix): Likewise.
3790         (stap_generic_check_suffix): Likewise.
3791         (stap_check_integer_suffix): Likewise.
3792         (stap_check_register_suffix): Likewise.
3793         (stap_check_register_indirection_suffix): Likewise.
3794         (stap_parse_register_operand): Likewise.
3795         (stap_parse_single_operand): Likewise.
3796         (stap_parse_argument_1): Likewise.
3797         (stap_probe::get_argument_count): Likewise.
3798         (stap_is_operator): Likewise.
3799
3800 2019-05-16  Tom Tromey  <tromey@adacore.com>
3801
3802         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3803         keyword to foreach.
3804
3805 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3806
3807         * linux-thread-db.c (try_thread_db_load_1): Change return type
3808         to bool.
3809         (try_thread_db_load): Likewise.
3810         (try_thread_db_load_from_pdir_1): Likewise.
3811         (try_thread_db_load_from_pdir): Likewise.
3812         (try_thread_db_load_from_sdir): Likewise.
3813         (try_thread_db_load_from_dir): Likewise.
3814         (thread_db_load_search): Likewise.
3815         (has_libpthread): Likewise.
3816         (thread_db_load): Likewise.
3817
3818 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3819
3820         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3821         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3822         NULL, and complain/return if that's the case.
3823
3824 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3825
3826         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3827         (advance, posn, abstract_read_memory): New functions.
3828         [struct mem_read_abstraction]: New struct.
3829         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3830
3831 2019-05-14  Tom Tromey  <tromey@adacore.com>
3832
3833         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3834         value is not lval_memory.
3835
3836 2019-05-14  Tom Tromey  <tromey@adacore.com>
3837
3838         * solib.c (info_sharedlibrary_command): Style the file name.
3839
3840 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3841
3842         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3843         (aarch64_vnv_type): Likewise.
3844         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3845         * common/tdesc.c: Likewise.
3846         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3847         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3848         * features/aarch64-fpu.xml: Add ieee half view.
3849         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3850         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3851         * gdbtypes.h (struct builtin_type): Likewise.
3852         (struct objfile_type): Likewise.
3853
3854 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3855
3856         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3857         typo.
3858         * location.h (string_to_event_location): Likewise.
3859
3860 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3861
3862         GDB 8.3 released.
3863
3864 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3865
3866         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3867         New variable declaration.
3868         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3869         New variable.
3870         (print_one_breakpoint): Use ui_out::test_flags and new global
3871         variable to compute use_fixed_output.
3872         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3873         Remove.
3874         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3875         (mi_multi_location_breakpoint_output_fixed): Remove.
3876         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3877         new variable.
3878         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3879         fix_multi_location_breakpoint_output flag if version >= 3.
3880         * ui-out.h (enum ui_out_flag)
3881         <fix_multi_location_breakpoint_output>: New enumerator.
3882
3883 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3884
3885         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3886
3887 2019-05-10  Tom Tromey  <tromey@adacore.com>
3888
3889         * ada-lang.c (catch_ada_completer): New function.
3890         (_initialize_ada_language): Use it.
3891
3892 2019-05-10  Tom Tromey  <tromey@adacore.com>
3893
3894         * thread.c (print_thread_info): Make "requested_threads" const.
3895         * gdbthread.h (print_thread_info): Make "requested_threads"
3896         const.
3897         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3898         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3899
3900 2019-05-08  Tom Tromey  <tom@tromey.com>
3901
3902         * gdbtypes.c (objfile_type_data): Change type.
3903         (objfile_type, _initialize_gdbtypes): Update.
3904
3905 2019-05-08  Tom Tromey  <tom@tromey.com>
3906
3907         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3908         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3909         (_initialize_dwarf2_frame): Update.
3910
3911 2019-05-08  Tom Tromey  <tom@tromey.com>
3912
3913         * objc-lang.c (objc_objfile_data): Change type.
3914         (find_methods): Update.
3915         (_initialize_objc_lang): Remove.
3916
3917 2019-05-08  Tom Tromey  <tom@tromey.com>
3918
3919         * stabsread.c (rs6000_builtin_type_data): Change type.
3920         (rs6000_builtin_type, _initialize_stabsread): Update.
3921
3922 2019-05-08  Tom Tromey  <tom@tromey.com>
3923
3924         * mips-tdep.c (mips_pdr_data): Remove.
3925         (_initialize_mips_tdep): Update.
3926
3927 2019-05-08  Tom Tromey  <tom@tromey.com>
3928
3929         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3930         (hppa_init_objfile_priv_data, read_unwind_info)
3931         (find_unwind_entry, _initialize_hppa_tdep): Update.
3932
3933 2019-05-08  Tom Tromey  <tom@tromey.com>
3934
3935         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3936         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3937         on obstack.
3938         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3939
3940 2019-05-08  Tom Tromey  <tom@tromey.com>
3941
3942         * mdebugread.c (basic_type_data): Change type.
3943         (basic_type, _initialize_mdebugread): Update.
3944
3945 2019-05-08  Tom Tromey  <tom@tromey.com>
3946
3947         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3948
3949 2019-05-08  Tom Tromey  <tom@tromey.com>
3950
3951         * nto-tdep.c (nto_inferior_data_reg): Change type.
3952         (nto_inferior_data): Update.
3953         (nto_inferior_data_cleanup, nto_new_inferior_data)
3954         (_initialize_nto_tdep): Remove.
3955         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3956
3957 2019-05-08  Tom Tromey  <tom@tromey.com>
3958
3959         * ada-lang.c (struct ada_inferior_data): Add initializers.
3960         (ada_inferior_data): Change type.
3961         (ada_inferior_data_cleanup): Remove.
3962         (get_ada_inferior_data, ada_inferior_exit)
3963         (struct ada_pspace_data): Add initializers, destructor.
3964         (ada_pspace_data_handle): Change type.
3965         (get_ada_pspace_data): Update.
3966         (ada_pspace_data_cleanup): Remove.
3967
3968 2019-05-08  Tom Tromey  <tom@tromey.com>
3969
3970         * coffread.c (struct coff_symfile_info): Add initializers.
3971         (coff_objfile_data_key): Move lower.  Change type.
3972         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3973         Update.
3974         (coff_free_info): Remove.
3975
3976 2019-05-08  Tom Tromey  <tom@tromey.com>
3977
3978         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3979         (fbsd_pspace_data_handle): Move lower.  Change type.
3980         (get_fbsd_pspace_data): Update.
3981         (fbsd_pspace_data_cleanup): Remove.
3982         (_initialize_fbsd_tdep): Update.
3983
3984 2019-05-08  Tom Tromey  <tom@tromey.com>
3985
3986         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3987         (get_ada_tasks_pspace_data): Update.
3988         (ada_tasks_pspace_data_cleanup): Remove.
3989         (_initialize_tasks): Update.
3990         (ada_tasks_inferior_data_handle): Change type.
3991         (get_ada_tasks_inferior_data): Update.
3992         (ada_tasks_inferior_data_cleanup): Remove.
3993         (struct ada_tasks_pspace_data): Add initializers.
3994
3995 2019-05-08  Tom Tromey  <tom@tromey.com>
3996
3997         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3998         * symfile-debug.c (debug_sym_get_probes): Change type.
3999         * stap-probe.c (handle_stap_probe):
4000         (stap_static_probe_ops::get_probes): Change type.
4001         * probe.h (class static_probe_ops) <get_probes>: Change type.
4002         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4003         (parse_probes_in_pspace): Update.
4004         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4005         Update.
4006         (any_static_probe_ops::get_probes): Change type.
4007         * elfread.c (elfread_data): New typedef.
4008         (probe_key): Change type.
4009         (elf_get_probes): Likewise.  Update.
4010         (probe_key_free): Remove.
4011         (_initialize_elfread): Update.
4012         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4013         Change type.
4014         (dtrace_process_dof_probe, dtrace_process_dof)
4015         (dtrace_static_probe_ops::get_probe): Change type.
4016
4017 2019-05-08  Tom Tromey  <tom@tromey.com>
4018
4019         * xcoffread.c (struct xcoff_symfile_info): Rename from
4020         coff_symfile_info.  Add initializers.
4021         (xcoff_objfile_data_key): Move lower.  Change type.
4022         (XCOFF_DATA): Rewrite.
4023         (xcoff_free_info): Remove.
4024         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4025         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4026         (xcoff_initial_scan): Update.
4027
4028 2019-05-08  Tom Tromey  <tom@tromey.com>
4029
4030         * solib-svr4.c (struct svr4_info): Add initializers and
4031         destructor.
4032         <probes_table>: Now an htab_up.
4033         (solib_svr4_pspace_data): Change type.
4034         (free_probes_table): Simplify.
4035         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4036         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4037         (probes_table_remove_objfile_probes, register_solib_event_probe)
4038         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4039         (_initialize_svr4_solib): Update.
4040
4041 2019-05-08  Tom Tromey  <tom@tromey.com>
4042
4043         * remote.c (remote_pspace_data): Change type.
4044         (remote_pspace_data_cleanup): Remove.
4045         (get_remote_exec_file, set_pspace_remote_exec_file)
4046         (_initialize_remote): Update.
4047
4048 2019-05-08  Tom Tromey  <tom@tromey.com>
4049
4050         * breakpoint.c (breakpoint_objfile_key): Change type.
4051         (get_breakpoint_objfile_data): Update.
4052         (free_breakpoint_objfile_data): Remove.
4053         (_initialize_breakpoint): Update.
4054
4055 2019-05-08  Tom Tromey  <tom@tromey.com>
4056
4057         * linux-tdep.c (struct linux_info): Add initializers.
4058         (linux_inferior_data): Move.  Change type.
4059         (invalidate_linux_cache_inf): Update.
4060         (linux_inferior_data_cleanup): Remove.
4061         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4062
4063 2019-05-08  Tom Tromey  <tom@tromey.com>
4064
4065         * auxv.c (auxv_inferior_data): Move.  Change type.
4066         (auxv_inferior_data_cleanup): Remove.
4067         (invalidate_auxv_cache_inf): Rewrite.
4068         (get_auxv_inferior_data, _initialize_auxv): Update.
4069
4070 2019-05-08  Tom Tromey  <tom@tromey.com>
4071
4072         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4073         (symfile_debug_objfile_data_key): Change type.
4074         (symfile_debug_installed, debug_qf_has_symbols)
4075         (debug_qf_find_last_source_symtab)
4076         (debug_qf_forget_cached_source_info)
4077         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4078         (debug_qf_print_stats, debug_qf_dump)
4079         (debug_qf_expand_symtabs_for_function)
4080         (debug_qf_expand_all_symtabs)
4081         (debug_qf_expand_symtabs_with_fullname)
4082         (debug_qf_map_matching_symbols)
4083         (debug_qf_expand_symtabs_matching)
4084         (debug_qf_find_pc_sect_compunit_symtab)
4085         (debug_qf_map_symbol_filenames)
4086         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4087         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4088         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4089         (debug_sym_read_linetable, debug_sym_relocate): Update.
4090         (symfile_debug_free_objfile): Remove.
4091         (install_symfile_debug_logging, _initialize_symfile_debug):
4092         Update.
4093
4094 2019-05-08  Tom Tromey  <tom@tromey.com>
4095
4096         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4097         allocate_on_obstack.
4098         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4099         (get_dwarf2_per_objfile): Update.
4100         (set_dwarf2_per_objfile): Remove.
4101         (dwarf2_has_info, dwarf2_get_section_info): Update.
4102         (dwarf2_free_objfile): Remove.
4103         (_initialize_dwarf2_read): Update.
4104
4105 2019-05-08  Tom Tromey  <tom@tromey.com>
4106
4107         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4108         initializers.
4109         <unsupported_script_warning_printed,
4110         script_not_found_warning_printed>: Now bool.
4111         (auto_load_pspace_data): Change type.
4112         (~auto_load_pspace_info): Rename from
4113         auto_load_pspace_data_cleanup.
4114         (get_auto_load_pspace_data, init_loaded_scripts_info)
4115         (clear_section_scripts, maybe_print_unsupported_script_warning)
4116         (maybe_print_script_not_found_warning, _initialize_auto_load):
4117         Update.
4118
4119 2019-05-08  Tom Tromey  <tom@tromey.com>
4120
4121         * objfiles.c (objfile_pspace_info): Add destructor and
4122         initializers.
4123         (objfiles_pspace_data): Change type.
4124         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4125         (get_objfile_pspace_data): Update.
4126         (objfiles_bfd_data): Change type.
4127         (get_objfile_bfd_data): Update.
4128         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4129
4130 2019-05-08  Tom Tromey  <tom@tromey.com>
4131
4132         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4133         Change type.
4134         (get_catch_syscall_inferior_data): Update.
4135         (catch_syscall_inferior_data_cleanup): Remove.
4136         (_initialize_break_catch_syscall): Update.
4137
4138 2019-05-08  Tom Tromey  <tom@tromey.com>
4139
4140         * inflow.c (struct terminal_info): Add destructor and
4141         initializers.
4142         (inflow_inferior_data): Change type.
4143         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4144         (get_inflow_inferior_data, inflow_inferior_exit)
4145         (swap_terminal_info, _initialize_inflow): Update.
4146
4147 2019-05-08  Tom Tromey  <tom@tromey.com>
4148
4149         * target-dcache.c (target_dcache_cleanup): Remove.
4150         (target_dcache_aspace_key): Change type.
4151         (target_dcache_init_p, target_dcache_invalidate)
4152         (target_dcache_get, target_dcache_get_or_init)
4153         (_initialize_target_dcache): Update.
4154         * dcache.h (struct dcache_deleter): New.
4155
4156 2019-05-08  Tom Tromey  <tom@tromey.com>
4157
4158         * symtab.c (struct symbol_cache): Add destructor and
4159         initializers.
4160         (symbol_cache_key): Move.  Change type.
4161         (make_symbol_cache, free_symbol_cache): Remove.
4162         (get_symbol_cache): Update.
4163         (symbol_cache_cleanup): Remove.
4164         (ALL_PSPACES, symbol_cache_flush)
4165         (maintenance_print_symbol_cache)
4166         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4167         Update.
4168
4169 2019-05-08  Tom Tromey  <tom@tromey.com>
4170
4171         * symtab.c (struct main_info): Add destructor and initializers.
4172         (main_progspace_key): Move.  Change type.
4173         (get_main_info): Update.
4174         (main_info_cleanup): Remove.
4175         (_initialize_symtab): Update.
4176
4177 2019-05-08  Tom Tromey  <tom@tromey.com>
4178
4179         * registry.h (DECLARE_REGISTRY): Define the _key class.
4180
4181 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * NEWS: Merge two 'New commands' sections.
4184
4185 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4186
4187         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4188         parameter and use Ada language definition instead.
4189         (ada_val_print_ptr): Remove unused language parameter.
4190         (ada_val_print_num): Remove language parameter and use Ada language
4191         definition instead.
4192         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4193         parameter.
4194         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4195         parameter and use Ada language definition instead.
4196         (ada_val_print_1): Update all ada_val_print_xxx calls.
4197         Remove language parameter.
4198         (ada_val_print): Update ada_val_print_1 call.
4199
4200 2019-05-08  Tom Tromey  <tromey@adacore.com>
4201
4202         * remote.c (remote_hw_watchpoint_limit)
4203         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4204         Now static.
4205
4206 2019-05-08  Tom Tromey  <tromey@adacore.com>
4207
4208         * maint.c (_initialize_maint_cmds): Move initialization code to
4209         remote.c.
4210         (watchdog, show_watchdog): Move to remote.c.
4211         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4212         "watchdog" static.
4213         (_initialize_remote): Move initialization code from maint.c.
4214         * defs.h (watchdog): Don't declare.
4215
4216 2019-05-08  Tom Tromey  <tromey@adacore.com>
4217
4218         * tui/tui-interp.c: Include main.h.
4219         * interps.c: Include main.h.
4220         * main.h (interpreter_p): Declare.
4221         * defs.h (interpreter_p): Don't declare.
4222
4223 2019-05-08  Tom Tromey  <tromey@adacore.com>
4224
4225         * dwarf2loc.c: Include dwarf2read.h.
4226         * defs.h (read_unsigned_leb128): Don't declare.
4227         * dwarf2read.h (read_unsigned_leb128): Declare.
4228
4229 2019-05-08  Tom Tromey  <tromey@adacore.com>
4230
4231         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4232         method.
4233
4234 2019-05-08  Tom Tromey  <tromey@adacore.com>
4235
4236         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4237         when no wrap column is set.
4238
4239 2019-05-08  Tom Tromey  <tromey@adacore.com>
4240
4241         * c-lang.c (c_get_string): Handle non-C-style arrays.
4242
4243 2019-05-08  Tom Tromey  <tromey@adacore.com>
4244
4245         * typeprint.c (print_offset_data::update): Print the bit offset,
4246         not the number of bits remaining.
4247
4248 2019-05-08  Tom Tromey  <tromey@adacore.com>
4249
4250         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4251         padding at end of comment.
4252
4253 2019-05-08  Tom Tromey  <tromey@adacore.com>
4254
4255         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4256         Compare main types.
4257
4258 2019-05-06  Tom Tromey  <tom@tromey.com>
4259
4260         * common/scoped_mmap.c: Include common-defs.h.
4261         * common/scoped_mmap.h: Don't include config.h.
4262
4263 2019-05-04  Tom Tromey  <tom@tromey.com>
4264
4265         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4266         (struct aarch64_call_info): Add initializers.
4267         <si>: Now a std::vector.
4268         (pass_on_stack, aarch64_push_dummy_call): Update.
4269
4270 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4271             Tom Tromey  <tom@tromey.com>
4272
4273         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4274         (ppc_threads): Now a std::vector.  Now static.
4275         (hwdebug_find_thread_points_by_tid)
4276         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4277         Update.
4278
4279 2019-05-04  Tom Tromey  <tom@tromey.com>
4280
4281         * arc-tdep.c (arc_tdesc_init): Return bool.
4282
4283 2019-05-04  Tom Tromey  <tom@tromey.com>
4284
4285         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4286         Use gdb_assert_not_reached.
4287
4288 2019-05-04  Tom Tromey  <tom@tromey.com>
4289
4290         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4291         "false".
4292
4293 2019-05-04  Tom Tromey  <tom@tromey.com>
4294
4295         * arc-tdep.c (arc_tdesc_init): Use bool.
4296
4297 2019-05-04  Tom Tromey  <tom@tromey.com>
4298
4299         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4300
4301 2019-05-04  Tom Tromey  <tom@tromey.com>
4302
4303         * cli/cli-cmds.c (valid_command_p): Return bool.
4304
4305 2019-05-04  Tom Tromey  <tom@tromey.com>
4306
4307         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4308         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4309
4310 2019-05-04  Raul Tambre  <raul@tambre.ee>
4311
4312         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4313         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4314         operator for comparison.
4315
4316 2019-05-04  Tom Tromey  <tom@tromey.com>
4317
4318         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4319         (lookup_partial_symbol, print_partial_symbols)
4320         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4321         (psymbol_compare): Update.
4322         (add_psymbol_to_bcache): Clear the entire psymbol.
4323         (maintenance_check_psymtabs): Update.
4324         * psympriv.h (struct partial_symbol): Don't derive from
4325         general_symbol_info.
4326         <obj_section, unrelocated_address, address,
4327         set_unrelocated_address>: Update.
4328         <ginfo>: New member.
4329         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4330         (debug_names::write_psymbols): Update.
4331
4332 2019-05-04  Tom de Vries  <tdevries@suse.de>
4333
4334         * contrib/cc-with-tweaks.sh: Support -n arg.
4335
4336 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4337
4338         * corelow.c (core_target::detach): Ensure frame cache and
4339         register caches are cleared.
4340         inferior.c (exit_inferior_1): Likewise.
4341
4342 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4343             Tom Tromey  <tom@tromey.com>
4344
4345         * dictionary.c (collate_pending_symbols_by_language): Remove
4346         "struct" from foreach.
4347         * symtab.c (lookup_global_symbol_from_objfile)
4348         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4349         foreach.
4350         * ser-tcp.c (net_open): Remove "struct" from foreach.
4351         * objfiles.c (objfile_relocate, objfile_rebase)
4352         (objfile_has_symbols): Remove "struct" from foreach.
4353         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4354         from foreach.
4355         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4356         foreach.
4357         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4358         "struct" from foreach.
4359         * ada-lang.c (create_excep_cond_exprs)
4360         (ada_exception_catchpoint_cond_string): Remove "struct" from
4361         foreach.
4362
4363 2019-05-03  Tom Tromey  <tromey@adacore.com>
4364
4365         * ada-exp.y (convert_char_literal): Check suffix of each
4366         enumerator.
4367
4368 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4369
4370         PR ada/21406:
4371         * ada-exp.y (yywrap): Don't define.
4372         * ada-lex.l (%option): Add noyywrap
4373         (yywrap): Remove.
4374
4375 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4376
4377         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4378         _WIN32_WINNT to the XP level, unless already defined to a higher
4379         level.
4380
4381         * unittests/parse-connection-spec-selftests.c:
4382         * ser-tcp.c:
4383         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4384         override.
4385
4386         * symfile.c (find_separate_debug_file): Remove colon from the
4387         drive spec of DOS/Windows file names of the target, so that the
4388         file name produced from DEBUGDIR and the target's directory will
4389         be valid on DOS/Windows systems.
4390
4391 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * rust-lang.c (val_print_struct): Handle printing structures
4394         containing strings.
4395
4396 2019-05-02  Tom Tromey  <tromey@adacore.com>
4397
4398         * valarith.c (_initialize_valarith): Remove.
4399
4400 2019-05-01  Tom Tromey  <tromey@adacore.com>
4401
4402         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4403         bitfields.
4404
4405 2019-05-01  Tom Tromey  <tromey@adacore.com>
4406
4407         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4408         for big-endian copies.
4409
4410 2019-04-30  Ali Tamur  <tamur@google.com>
4411         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4412         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4413         (read_3_bytes): New function.
4414
4415 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4416
4417         * windows-nat.c (main_thread_id): Delete.
4418         (handle_output_debug_string): Replace main_thread_id by
4419         current_event.dwThreadId.
4420         (fake_create_process): Likewise.
4421         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4422         Do not set main_thread_id.
4423         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4424         current_event.dwThreadId.
4425         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4426
4427 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4428
4429         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4430         Use current_event.dwThreadId instead of main_thread_id.
4431
4432 2019-04-30  Tom Tromey  <tromey@adacore.com>
4433
4434         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4435         (create_excep_cond_exprs): Iterate over program spaces.
4436         (ada_exception_catchpoint_cond_string): Examine all minimal
4437         symbols for exception types.
4438
4439 2019-04-30  Tom Tromey  <tromey@adacore.com>
4440
4441         PR c++/24470:
4442         * dwarf2read.c (process_structure_scope): Handle case where type
4443         has template parameters but no symbol was created.
4444
4445 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4446             Chris January  <chris.january@arm.com>
4447
4448         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4449         qualifier.
4450         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4451
4452 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4453
4454         * f-typeprint.c (f_print_type): Update rules for printing
4455         whitespace.
4456         (f_type_print_varspec_suffix): Likewise.
4457
4458 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4459             Chris January  <chris.january@arm.com>
4460
4461         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4462         function arguments.
4463
4464 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * f-lang.c (build_fortran_types): Change name of void type to
4467         lower case.
4468         * f-typeprint.c (f_type_print_base): Print the name of the void
4469         type, rather than a fixed string.
4470         * f-valprint.c (f_decorations): Use lower case void string.
4471
4472 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4473             Chris January  <chris.january@arm.com>
4474
4475         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4476         types for Fortran.
4477
4478 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4479             Chris January  <chris.january@arm.com>
4480             David Lecomber  <david.lecomber@arm.com>
4481
4482         * f-exp.y (BINOP_INTRINSIC): New token.
4483         (exp): New parser rule handling BINOP_INTRINSIC.
4484         (f77_keywords): Add new builtin procedures.
4485         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4486         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4487         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4488         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4489         (print_unop_subexp_f): New function.
4490         (print_binop_subexp_f): New function.
4491         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4492         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4493         (dump_subexp_body_f): Likewise.
4494         (operator_check_f): Likewise.
4495         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4496         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4497
4498 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4499
4500         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4501         UNOP_KIND.
4502         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4503         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4504         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4505         (operator_length_f): New fuction.
4506         (print_subexp_f): New function.
4507         (op_name_f): New function.
4508         (dump_subexp_body_f): New function.
4509         (operator_check_f): New function.
4510         (exp_descriptor_f): Replace standard expression handling functions
4511         with new functions.
4512         * gdb/fortran-operator.def: New file.
4513         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4514         * gdb/std-operator.def: Remove UNOP_KIND.
4515
4516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * std-operator.def: Remove unbalanced, stray double quote
4519         character.
4520
4521 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4522             Chris January  <chris.january@arm.com>
4523             Daniel Everett  <daniel.everett@arm.com>
4524             Nick Forrington  <nick.forrington@arm.com>
4525             Richard Bunt  <richard.bunt@arm.com>
4526
4527         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4528         of depth when printing anonymous structs or unions.
4529         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4530         Don't print either the top-level value, or the children if the
4531         max-depth is exceeded.
4532         (ppscm_print_children): When printing the key of a map, allow one
4533         extra level of depth.
4534         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4535         print either the top-level value, or the children if the max-depth
4536         is exceeded.
4537         (print_children): When printing the key of a map, allow one extra
4538         level of depth.
4539         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4540         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4541         (user_print_options): Initialise max_depth field.
4542         (val_print_scalar_or_string_type_p): New function.
4543         (val_print): Check to see if the max depth has been reached.
4544         (val_print_check_max_depth): Define new function.
4545         (show_print_max_depth): New function.
4546         (_initialize_valprint): Add 'print max-depth' option.
4547         * valprint.h (struct value_print_options) <max_depth>: New field.
4548         (val_print_check_max_depth): Declare new function.
4549         * NEWS: Document new feature.
4550
4551 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * ada-lang.c (ada_language_defn): Initialise new field.
4554         * c-lang.c (c_is_string_type_p): New function.
4555         (c_language_defn): Initialise new field.
4556         (cplus_language_defn): Initialise new field.
4557         (asm_language_defn): Initialise new field.
4558         (minimal_language_defn): Initialise new field.
4559         * c-lang.h (c_is_string_type_p): Declare new function.
4560         * d-lang.c (d_language_defn): Initialise new field.
4561         * f-lang.c (f_is_string_type_p): New function.
4562         (f_language_defn): Initialise new field.
4563         * go-lang.c (go_is_string_type_p): New function.
4564         (go_language_defn): Initialise new field.
4565         * language.c (default_is_string_type_p): New function.
4566         (unknown_language_defn): Initialise new field.
4567         (auto_language_defn): Initialise new field.
4568         * language.h (struct language_defn) <la_is_string_type_p>: New
4569         member variable.
4570         (default_is_string_type_p): Declare new function.
4571         * m2-lang.c (m2_language_defn): Initialise new field.
4572         * objc-lang.c (objc_language_defn): Initialise new field.
4573         * opencl-lang.c (opencl_language_defn): Initialise new field.
4574         * p-lang.c (pascal_is_string_type_p): New function.
4575         (pascal_language_defn): Initialise new field.
4576         * rust-lang.c (rust_is_string_type_p): New function.
4577         (rust_language_defn): Initialise new field.
4578
4579 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4582         New field.
4583         * ada-lang.c (ada_language_defn): Initialise new field.
4584         * c-lang.c (c_language_defn): Likewise.
4585         (cplus_language_defn): Likewise.
4586         (asm_language_defn): Likewise.
4587         (minimal_language_defn): Likewise.
4588         * d-lang.c (d_language_defn): Likewise.
4589         * f-lang.c (f_language_defn): Likewise.
4590         * go-lang.c (go_language_defn): Likewise.
4591         * language.c (unknown_language_defn): Likewise.
4592         (auto_language_defn): Likewise.
4593         * m2-lang.c (m2_language_defn): Likewise.
4594         * objc-lang.c (objc_language_defn): Likewise.
4595         * opencl-lang.c (opencl_language_defn): Likewise.
4596         * p-lang.c (pascal_language_defn): Likewise.
4597         * rust-lang.c (rust_language_defn): Likewise.
4598
4599 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * ada-lang.c (ada_is_character_type): Change return type to bool.
4602         (ada_is_string_type): Likewise.
4603         * ada-lang.h (ada_is_character_type): Update declaration
4604         (ada_is_string_type): Likewise.
4605
4606 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4607
4608         Support style in 'frame|thread apply'
4609
4610         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4611         * record.c (record_start, record_stop): Update callers of
4612         execute_command_to_string with false.
4613         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4614         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4615         methods.
4616         (class string_file): New constructor with term_out parameter.
4617         Override methods term_out and can_emit_style_escape.  New member
4618         term_out.
4619         (class stdio_file): Override can_emit_style_escape.
4620         (class tee_file): Override term_out and can_emit_style_escape.
4621         * utils.h (can_emit_style_escape): Remove.
4622         * utils.c (can_emit_style_escape): Likewise.
4623         Update all callers of can_emit_style_escape (SOMESTREAM) to
4624         SOMESTREAM->can_emit_style_escape.
4625         * source-cache.c (source_cache::get_source_lines): Likewise.
4626         * stack.c (frame_apply_command_count): Call execute_command_to_string
4627         passing the term_out characteristic of the current gdb_stdout.
4628         * thread.c (thr_try_catch_cmd): Likewise.
4629         * top.c (execute_command_to_string): pass term_out parameter
4630         to construct the string_file for the command output.
4631         * ui-file.c (term_cli_styling): New function (most code moved
4632         from utils.c can_emit_style_escape).
4633         (string_file::string_file, string_file::can_emit_style_escape,
4634         stdio_file::can_emit_style_escape, tee_file::term_out,
4635         tee_file::can_emit_style_escape): New functions.
4636
4637 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4638
4639         * NEWS: Mention the new set|show may-call-functions.
4640         * infcall.c (may_call_functions_p): New variable.
4641         (show_may_call_functions_p): New function.
4642         (call_function_by_hand_dummy): Throws an error if not
4643         may-call-functions.
4644         (_initialize_infcall): Call add_setshow_boolean_cmd for
4645         may-call-functions.
4646
4647 2019-04-25  Keith Seitz  <keiths@redhat.com>
4648
4649         PR c++/24367
4650         * cp-support.c (inspect_type): Don't attempt substitutions
4651         of symbol with the same name.
4652
4653 2019-04-25  Tom Tromey  <tromey@adacore.com>
4654
4655         PR gdb/24475:
4656         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4657         static.
4658
4659 2019-04-25  Tom Tromey  <tromey@adacore.com>
4660
4661         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4662         rvalue reference.
4663         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4664         (gdb_xml_parser::parse): Use std::move.
4665         * python/python-internal.h (gdbpy_convert_exception): Take a const
4666         reference.
4667         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4668         std::move.
4669         * python/py-utils.c (gdbpy_convert_exception): Take a const
4670         reference.
4671         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4672         Use std::move.
4673         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4674         Use std::move.
4675         * mi/mi-main.c (mi_print_exception): Take a const reference.
4676         * main.c (handle_command_errors): Take a const reference.
4677         * linespec.c (parse_linespec): Use std::move.
4678         * infcall.c (run_inferior_call): Use std::move.
4679         (call_function_by_hand_dummy): Use std::move.
4680         * exec.c (try_open_exec_file): Use std::move.
4681         * exceptions.h (exception_print, exception_fprintf)
4682         (exception_print_same): Update.
4683         * exceptions.c (print_exception, exception_print)
4684         (exception_fprintf, exception_print_same): Change parameters to
4685         const reference.
4686         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4687         * common/new-op.c: Use std::move.
4688         * common/common-exceptions.h (struct gdb_exception): Add move
4689         constructor.
4690         (struct gdb_exception_error, struct gdb_exception_quit, struct
4691         gdb_quit_bad_alloc): Change constructor to move constructor.
4692         (throw_exception): Change parameter to rvalue reference.
4693         * common/common-exceptions.c (throw_exception): Take rvalue
4694         reference.
4695         * cli/cli-interp.c (safe_execute_command): Use std::move.
4696         * breakpoint.c (insert_bp_location, location_to_sals): Use
4697         std::move.
4698
4699 2019-04-25  Tom Tromey  <tromey@adacore.com>
4700
4701         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4702         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4703         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4704         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4705         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4706         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4707         guile/scm-value.c: Use unpack.
4708         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4709         gdbscm_gdb_exception.
4710         (gdbscm_throw_gdb_exception): Likewise.
4711         (struct gdbscm_gdb_exception): New.
4712         (unpack): New function.
4713         (gdbscm_wrap): Use unpack.
4714
4715 2019-04-25  Tom Tromey  <tromey@adacore.com>
4716
4717         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4718         (gdb_rl_callback_handler): Use std::move.
4719         * common/common-exceptions.h (struct gdb_exception): Add move
4720         assignment operator.
4721         (throw_exception_sjlj): Change "exception" to const reference.
4722         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4723         (throw_exception_sjlj): Change "exception" to const reference.
4724
4725 2019-04-25  Tom Tromey  <tromey@adacore.com>
4726
4727         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4728         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4729         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4730         Update.
4731         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4732         Update.
4733         * mi/mi-interp.c (mi_interp::exec): Update.
4734         * linespec.c (parse_linespec): Update.
4735         * infcall.c (run_inferior_call): Update.
4736         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4737         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4738         (gdbscm_lookup_global_symbol): Update.
4739         * guile/scm-param.c (gdbscm_parameter_value): Update.
4740         * guile/scm-frame.c (gdbscm_frame_read_register)
4741         (gdbscm_frame_read_var): Update.
4742         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4743         * exec.c (try_open_exec_file): Update.
4744         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4745         (gdb_rl_callback_handler): Update.
4746         * common/common-exceptions.h (exception_none): Don't declare.
4747         * common/common-exceptions.c (exception_none): Don't define.
4748         (struct catcher) <exception>: Update.
4749         * cli/cli-interp.c (safe_execute_command): Update.
4750         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4751
4752 2019-04-25  Ali Tamur  <tamur@google.com>
4753
4754         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4755         (read_attribute_value): Likewise.
4756         (dwarf2_read_addr_index): Update comment.
4757         (read_str_index): Add DW_FORM_strx.
4758         (dwarf2_string_attr): Likewise.
4759         (dwarf2_const_value_attr): Likewise.
4760         (dump_die_shallow): Likewise.
4761         (dwarf2_fetch_constant_bytes): Likewise.
4762         (skip_form_bytes): Likewise.
4763         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4764
4765 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4766
4767         PR corefiles/11608
4768         PR corefiles/18187
4769         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4770         OFFSET.  Verify if current mapping contains an ELF header.
4771         (linux_find_memory_regions_full): Adjust call to
4772         dump_mapping_p.
4773
4774 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4775             Kang Li <kanglictf@gmail.com>
4776
4777         PR gdb/21600
4778
4779         * dwarf2-frame.c (read_initial_length): Be consistent about using
4780         unsigned representation of length.
4781         (decode_frame_entry_1): Likewise.  Check for wraparound of
4782         end pointer as well as buffer overflow.
4783
4784 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4785
4786         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4787         "vq".
4788
4789 2019-04-24  Tom Tromey  <tromey@adacore.com>
4790
4791         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4792
4793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * s12z-tdep.c (s12z_unwind_pc): Delete.
4796         (s12z_unwind_sp): Delete.
4797         (s12z_gdbarch_init): Don't register deleted functions with
4798         gdbarch.
4799
4800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         * rl78-tdep.c (rl78_unwind_sp): Delete.
4803         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4804
4805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4808         (xstormy16_unwind_pc): Delete.
4809         (xstormy16_dummy_id): Delete.
4810         (xstormy16_gdbarch_init): Don't register deleted functions with
4811         gdbarch.
4812
4813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * vax-tdep.c (vax_unwind_pc): Delete.
4816         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4817
4818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * v850-tdep.c (v850_unwind_sp): Delete.
4821         (v850_unwind_pc): Delete.
4822         (v850_dummy_id): Delete.
4823         (v850_gdbarch_init): Don't register deleted functions with
4824         gdbarch.
4825
4826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4827
4828         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4829         (tilegx_unwind_pc): Delete.
4830         (tilegx_unwind_dummy_id): Delete.
4831         (tilegx_gdbarch_init): Don't register deleted functions with
4832         gdbarch.
4833
4834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4837         (tic6x_dummy_id): Delete.
4838         (tic6x_gdbarch_init): Don't register deleted functions with
4839         gdbarch.
4840
4841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4842
4843         * sparc-tdep.c (sparc_unwind_pc): Delete.
4844         (sparc32_gdbarch_init): Don't register deleted function with
4845         gdbarch.
4846
4847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4848
4849         * sh-tdep.c (sh_unwind_sp): Delete.
4850         (sh_unwind_pc): Delete.
4851         (sh_dummy_id): Delete.
4852         (sh_gdbarch_init): Don't register deleted functions with
4853         gdbarch.
4854
4855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4856
4857         * score-tdep.c (score_unwind_sp): Delete.
4858         (score_unwind_pc): Delete.
4859         (score_dummy_id): Delete.
4860         (score_gdbarch_init): Don't register deleted functions with
4861         gdbarch.
4862
4863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * rx-tdep.c (rx_unwind_pc): Delete.
4866         (rx_unwind_sp): Delete.
4867         (rx_dummy_id): Delete.
4868         (rx_gdbarch_init): Don't register deleted functions with
4869         gdbarch.  Update comment.
4870
4871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4874         (rs6000_dummy_id): Delete.
4875         (rs6000_gdbarch_init): Don't register deleted functions with
4876         gdbarch.
4877
4878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * or1k-tdep.c (or1k_dummy_id): Delete.
4881         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4882
4883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * nios2-tdep.c (nios2_dummy_id): Delete.
4886         (nios2_unwind_sp): Delete.
4887         (nios2_gdbarch_init): Don't register deleted functions with
4888         gdbarch.
4889
4890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * nds32-tdep.c (nds32_dummy_id): Delete.
4893         (nds32_unwind_pc): Delete.
4894         (nds32_unwind_sp): Delete.
4895         (nds32_gdbarch_init): Don't register deleted functions with
4896         gdbarch.
4897
4898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * msp430-tdep.c (msp430_unwind_pc): Delete.
4901         (msp430_unwind_sp): Delete.
4902         (msp430_dummy_id): Delete.
4903         (msp430_gdbarch_init): Don't register deleted functions with
4904         gdbarch.
4905
4906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * moxie-tdep.c (moxie_unwind_sp): Delete.
4909         (moxie_unwind_pc): Delete.
4910         (moxie_dummy_id): Delete.
4911         (moxie_gdbarch_init): Don't register deleted functions with
4912         gdbarch.
4913
4914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4917         (mn10300_unwind_pc): Delete.
4918         (mn10300_unwind_sp): Delete.
4919         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4920         mn10300_unwind_sp.
4921         (mn10300_frame_unwind_init): Don't register deleted functions with
4922         gdbarch.
4923
4924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * mep-tdep.c (mep_unwind_pc): Delete.
4927         (mep_unwind_sp): Delete.
4928         (mep_dummy_id): Delete.
4929         (mep_gdbarch_init): Don't register deleted functions with
4930         gdbarch.
4931
4932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4933
4934         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4935         (m68hc11_unwind_sp): Delete.
4936         (m68hc11_gdbarch_init): Don't register deleted functions with
4937         gdbarch.
4938
4939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * m32r-tdep.c (m32r_unwind_sp): Delete.
4942         (m32r_unwind_pc): Delete.
4943         (m32r_dummy_id): Delete.
4944         (m32r_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * m32c-tdep.c (m32c_unwind_pc): Delete.
4950         (m32c_unwind_sp): Delete.
4951         (m32c_dummy_id): Delete.
4952         (m32c_gdbarch_init): Don't register deleted functions with
4953         gdbarch.
4954
4955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4958         (lm32_unwind_pc): Delete.
4959         (lm32_dummy_id): Delete.
4960         (lm32_gdbarch_init): Don't register deleted functions with
4961         gdbarch.
4962
4963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4966         (iq2000_unwind_pc): Delete.
4967         (iq2000_dummy_id): Delete.
4968         (iq2000_gdbarch_init): Don't register deleted functions with
4969         gdbarch.
4970
4971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * nds32-tdep.c (nds32_type_align): Delete.
4974         (nds32_push_dummy_call): Use type_align instead.
4975
4976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * arm-tdep.c (arm_type_align): Only handle vector override case.
4979         (arm_push_dummy_call): Use type_align.
4980         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4981
4982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4985         case.
4986         (pass_on_stack): Use type_align.
4987         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4988         function.
4989
4990 2019-04-23  Tom Tromey  <tromey@adacore.com>
4991
4992         * dwarf2read.c (line_header::file_name_at): Remove unused
4993         overload.
4994
4995 2019-04-23  Tom de Vries  <tdevries@suse.de>
4996
4997         PR gdb/24438
4998         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4999         invocation.
5000
5001
5002 2019-03-27  Ali Tamur  <tamur@google.com>
5003
5004         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5005         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5006         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5007         (dwarf_expr_context::get_addr_index): Likewise
5008         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5009         (symbol_needs_eval_context::get_addr_index): Likewise
5010         (disassemble_dwarf_expression): Add DW_OP_addrx
5011         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5012         (read_cutu_die_from_dwo): Update comment
5013         (skip_one_die): Add DW_FORM_addrx
5014         (read_attribute_value): Likewise
5015         (var_decode_location): Add DW_OP_addrx
5016         (dwarf2_const_value_attr): Add DW_FORM_addrx
5017         (dump_die_shallow): Likewise
5018         (dwarf2_fetch_constant_bytes): Likewise
5019         (decode_locdesc): Add DW_OP_addrx
5020         (skip_form_bytes): Add DW_FORM_addrx
5021
5022 2019-04-22  Ali Tamur  <tamur@google.com>
5023
5024         * MAINTAINERS (Write After Approval): Add self.
5025
5026 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5027
5028         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5029         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5030         (open_symbol_file_object): Likewise.
5031         (svr4_default_sos): Add info parameter.
5032         (svr4_read_so_list): Likewise.
5033         (svr4_current_sos_direct): Adjust functions calls to pass down
5034         info.
5035         (svr4_current_sos_1): Add info parameter.
5036         (svr4_current_sos): Call get_svr4_info, pass info down to
5037         svr4_current_sos_1.
5038         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5039         get_svr4_info.
5040         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5041         get_svr4_info.
5042         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5043         to get_svr4_info.
5044         (probes_table_remove_objfile_probes): Likewise.
5045         (register_solib_event_probe): Add info parameter.
5046         (solist_update_incremental): Pass info parameter down to
5047         svr4_read_so_list.
5048         (disable_probes_interface): Add info parameter.
5049         (svr4_handle_solib_event): Pass current_program_space to
5050         get_svr4_info.  Adjust disable_probes_interface cleanup.
5051         (svr4_create_probe_breakpoints): Add info parameter, pass it
5052         down to register_solib_event_probe.
5053         (svr4_create_solib_event_breakpoints): Add info parameter,
5054         pass it down to svr4_create_probe_breakpoints.
5055         (enable_break): Pass info down to
5056         svr4_create_solib_event_breakpoints.
5057         (svr4_solib_create_inferior_hook): Pass current_program_space to
5058         get_svr4_info.
5059         (svr4_clear_solib): Likewise.
5060
5061 2019-04-22  Pedro Alves  <palves@redhat.com>
5062
5063         * solib-svr4.c (svr4_free_objfile_observer): New.
5064         (probe_and_action::objfile): New field.
5065         (probes_table_htab_remove_objfile_probes)
5066         (probes_table_remove_objfile_probes): New functions.
5067         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5068         in the new probe_and_action.  Don't store the probe in 'lookup'.
5069         (svr4_create_probe_breakpoints): Pass objfile to
5070         register_solib_event_probe.
5071         (_initialize_svr4_solib): Register a free_objfile observer.
5072
5073 2019-04-19  Tom Tromey  <tom@tromey.com>
5074
5075         * common/queue.h: Remove.
5076
5077 2019-04-19  Tom Tromey  <tom@tromey.com>
5078
5079         * event-loop.c: Don't include "common/queue.h".
5080
5081 2019-04-19  Tom Tromey  <tom@tromey.com>
5082
5083         * remote.c (remote_target): Use delete.
5084         * remote-notif.h: Include <list>, not "common/queue.h".
5085         (notif_client_p): Remove typedef.
5086         (remote_notif_state): Add constructor, destructor, initializer.
5087         <notif_queue>: Now a std::list.
5088         (remote_notif_state_xfree): Don't declare.
5089         * remote-notif.c (remote_notif_process, handle_notification)
5090         (remote_notif_state_allocate): Update.
5091         (~remote_notif_state): Rename from remote_notif_state_xfree.
5092
5093 2019-04-19  Tom Tromey  <tom@tromey.com>
5094
5095         * symfile.c (reread_symbols): Update.
5096         * objfiles.c (objfile_register_static_link)
5097         (objfile_lookup_static_link): Update
5098         (~objfile) Don't delete static_links.
5099         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5100
5101 2019-04-19  Tom Tromey  <tom@tromey.com>
5102
5103         * type-stack.h (struct type_stack) <insert>: Constify string.
5104         * type-stack.c (type_stack::insert): Constify string.
5105         * gdbtypes.h (lookup_template_type): Update.
5106         (address_space_name_to_int): Update.
5107         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5108         const.
5109         (lookup_template_type): Make name const.
5110         * c-exp.y: Update rules.
5111         (lex_one_token, classify_name, classify_inner_name)
5112         (c_print_token): Update.
5113         * p-exp.y: Update rules.
5114         (yylex): Update.
5115         * f-exp.y: Update rules.
5116         (yylex): Update.
5117         * d-exp.y: Update rules.
5118         (lex_one_token, classify_name, classify_inner_name): Update.
5119         * parse.c (write_dollar_variable, copy_name): Return std::string.
5120         * parser-defs.h (copy_name): Change return type.
5121         * m2-exp.y: Update rules.
5122         (yylex): Update.
5123         * go-exp.y (lex_one_token): Update.
5124         Update rules.
5125         (classify_unsafe_function, classify_packaged_name)
5126         (classify_name, yylex): Update.
5127
5128 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5129
5130         * configure.ac: add --enable-source-highlight switch.
5131         * configure: Regenerate.
5132         * top.c (print_gdb_version): plumb --enable-source-highlight
5133         status to "show configuration".
5134
5135 2019-04-19  Tom Tromey  <tromey@adacore.com>
5136
5137         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5138         Check ADA_TYPE_P.
5139         (empty_record, ada_template_to_fixed_record_type_1)
5140         (template_to_static_fixed_type)
5141         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5142         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5143         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5144         macros.
5145
5146 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5147
5148         PR symtab/24423:
5149         * source.c (print_source_lines_base): Advance "iter" when a
5150         control character is seen.
5151
5152 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5153
5154         * inferior.h (struct infcall_suspend_state_deleter):
5155         Catch exception in destructor to avoid crash.
5156
5157 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5158
5159         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5160         close to the add_com "shell".
5161
5162 2019-04-18  Tom Tromey  <tromey@adacore.com>
5163
5164         * process-stratum-target.h (class process_stratum_target)
5165         <stratum>: Add "final".
5166
5167 2019-04-17  Tom Tromey  <tromey@adacore.com>
5168
5169         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5170         against nullptr before use.
5171
5172 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5173
5174         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5175
5176 2019-04-17  Jim Wilson  <jimw@sifive.com>
5177             Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5180         code read might fail, assume 4-byte breakpoint in that case.
5181
5182 2019-04-15  Leszek Swirski  <leszeks@google.com>
5183
5184         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5185         rather than a hand-rolled POD check when checking for forced MEMORY
5186         classification.
5187
5188 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5189
5190         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5191         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5192         function.
5193         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5194         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5195         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5196         declaration.
5197
5198 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5199
5200         * aarch64-linux-nat.c
5201         (aarch64_linux_nat_target::thread_architecture): Add override.
5202         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5203         each VQ.
5204
5205 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5206
5207         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5208
5209 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5210
5211         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5212         target types of size 96-bits, add some additional comments, and
5213         check that the builtin type we found was the correct size.
5214
5215 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5216
5217         * utils.c (prompt_for_continue): Don't restore the styling at the
5218         end, as applied_style has the wrong value.  This fixes styling in
5219         long lists of file names that are interrupted by the "Continue?"
5220         prompt.
5221
5222 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5225         * c-lang.c (c_language_defn): Likewise.
5226         (cplus_language_defn): Likewise.
5227         (asm_language_defn): Likewise.
5228         (minimal_language_defn): Likewise.
5229         * d-lang.c (d_language_defn): Likewise.
5230         * f-lang.c (f_language_defn): Likewise.
5231         * go-lang.c (go_language_defn): Likewise.
5232         * language.c (unknown_language_defn): Likewise.
5233         (auto_language_defn): Likewise.
5234         * language.h (struct language_defn): Remove la_magic field.
5235         (LANG_MAGIC): Delete.
5236         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5237         * objc-lang.c (objc_language_defn): Likewise.
5238         * opencl-lang.c (opencl_language_defn): Likewise.
5239         * p-lang.c (pascal_language_defn): Likewise.
5240         * rust-lang.c (rust_language_defn): Likewise.
5241
5242 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * riscv-tdep.c (riscv_type_align): New function.
5245         (riscv_type_alignment): Delete.
5246         (riscv_arg_location): Use 'type_align'.
5247         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5248
5249 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5250
5251         * gdbtypes.c (type_align): A struct with no non-static fields also
5252         has alignment of 1.
5253
5254 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5257         component to 0.
5258         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5259         member.
5260         (riscv_struct_info::analyse): New implementation using new
5261         analyse_inner member function.
5262         (riscv_struct_info::field_offset): New member function.
5263         (riscv_struct_info::m_offsets): New member variable.
5264         (riscv_struct_info::analyse_inner): New private member function,
5265         takes the old implementation of riscv_struct_info::analyse but
5266         extended to track field offsets.
5267         (riscv_call_arg_struct): Update the struct folding special cases
5268         to handle cases where empty C++ structs, which are non-zero
5269         length, are found.
5270         (riscv_arg_location): Initialise the length of each location, a
5271         non-zero length now indicates the location is in use.
5272         (riscv_push_dummy_call): Allow for the first location having a
5273         non-zero offset when setting up arguments.
5274         (riscv_return_value): Likewise, but for return values.
5275
5276 2019-04-11  Tom Tromey  <tromey@adacore.com>
5277
5278         * utils.c (internal_vproblem): Make "msg" const.
5279
5280 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5281
5282         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5283         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5284         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5285         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5286
5287 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5288
5289         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5290         function.
5291         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5292         of amd64_collect_native_gregset.
5293         (amd64_linux_nat_target::store_registers): Likewise.
5294
5295 2019-04-10  Tom Tromey  <tom@tromey.com>
5296
5297         * symtab.c (lookup_global_symbol_from_objfile)
5298         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5299         * objfiles.h (class separate_debug_iterator): New.
5300         (class separate_debug_range): New.
5301         (struct objfile) <separate_debug_objfiles>: New method.
5302         (objfile_separate_debug_iterate): Don't declare.
5303         * objfiles.c (separate_debug_iterator::operator++): Rename from
5304         objfile_separate_debug_iterate.
5305         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5306         iterator.
5307         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5308         iterator.
5309
5310 2019-04-10  Tom Tromey  <tom@tromey.com>
5311
5312         * symfile.c (reread_symbols): Remove old comment.
5313         * objfiles.c (free_all_objfiles): Fix a typo.
5314
5315 2019-04-10  Tom Tromey  <tom@tromey.com>
5316
5317         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5318         * minsyms.c (lookup_minimal_symbol): Use foreach.
5319         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5320         (lookup_minimal_symbol_solib_trampoline): Likewise.
5321         * symfile.c (reread_symbols): Use foreach.
5322
5323 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5324             Tom Tromey  <tromey@adacore.com>
5325
5326         PR rust/24414:
5327         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5328         (rust_lex_int_test): Change "value" to be LONGEST.
5329         (rust_lex_tests): Add test for long integer literal.
5330
5331 2019-04-09  Tom Tromey  <tromey@adacore.com>
5332
5333         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5334         to bool.
5335         (extended_remote_target::attach): Update.
5336         (remote_target::remote_notice_new_inferior): Update.
5337         (remote_target::add_current_inferior_and_thread): Update.
5338         * inferior.c (exit_inferior_1): Use "false".
5339         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5340
5341 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5342
5343         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5344         the "start" command.
5345
5346 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5347
5348         * python/py-inferior.c (infpy_thread_from_thread_handle):
5349         Adjust comments to reflect renaming of thread_from_thread_handle
5350         to thread_from_handle.  Adjust keywords.  Fix type error message.
5351         (inferior_object_methods): Add thread_from_handle.  Retain
5352         thread_from_thread_handle, but mark it as deprecated.
5353
5354 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5355
5356         * gdbthread.h (find_thread_by_handle): Revise declaration.
5357         * thread.c (find_thread_by_handle): Likewise.  Adjust
5358         implementation too.
5359         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5360         support for buffer objects as handles.
5361
5362 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5363
5364         * python/py-infthread.c (thpy_thread_handle): New function.
5365         (thread_object_methods): Register thpy_thread_handle.
5366
5367 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5368
5369         * gdbthread.h (thread_to_thread_handle): Declare.
5370         * thread.c (gdbtypes.h): Include.
5371         (thread_to_thread_handle): New function.
5372
5373         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5374         (target_thread_info_to_thread_handle): Declare.
5375         * target.c (target_thread_info_to_thread_handle): New function.
5376         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5377         * target-delegates.c: Regenerate.
5378
5379         * linux-thread-db.c (class thread_db_target): Add method
5380         thread_info_to_thread_handle.
5381         (thread_db_target::thread_info_to_thread_handle): Define.
5382         * remote.c (class remote_target): Add new method
5383         thread_info_to_thread_handle.
5384         (remote_target::thread_info_to_thread_handle): Define.
5385
5386 2019-04-08  Pedro Alves  <palves@redhat.com>
5387
5388         * common/common-exceptions.c (throw_exception): Don't create
5389         named object to throw; throw directly.
5390         (throw_it): Likewise.  Don't initialize gdb_exception::message
5391         here, with new; pass FMT and AP to the ctor instead.
5392         * common/common-exceptions.h: Include <string>.
5393         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5394         const char *, va_list)): New ctor.  Use std::make_shared.
5395         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5396         errors)): Delete.
5397         (gdb_exception_error::gdb_exception_error(enum errors, const char
5398         *, va_list)): New.
5399         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5400         Add assertion.
5401         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5402         errors)): Delete.
5403         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5404         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5405         Add assertion.
5406
5407 2019-04-08  Tom Tromey  <tom@tromey.com>
5408
5409         * valops.c (value_rtti_indirect_type): Replace throw_exception
5410         with throw.
5411         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5412         with throw.
5413         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5414         throw.
5415         * target.c (target_translate_tls_address): Replace throw_exception
5416         with throw.
5417         * stack.c (frame_apply_command_count): Replace throw_exception
5418         with throw.
5419         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5420         throw.
5421         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5422         with throw.
5423         * rs6000-tdep.c (rs6000_frame_cache)
5424         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5425         * remote.c: Replace throw_exception with throw.
5426         * record-full.c (record_full_message, record_full_wait_1)
5427         (record_full_restore): Replace throw_exception with throw.
5428         * record-btrace.c:
5429         (get_thread_current_frame_id, record_btrace_start_replaying)
5430         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5431         (cmd_record_btrace_start): Replace throw_exception with throw.
5432         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5433         throw.
5434         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5435         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5436         * linespec.c:
5437         (find_linespec_symbols): Replace throw_exception with throw.
5438         * infrun.c (displaced_step_prepare, resume): Replace
5439         throw_exception with throw.
5440         * infcmd.c (post_create_inferior): Replace throw_exception with
5441         throw.
5442         * inf-loop.c (inferior_event_handler): Replace throw_exception
5443         with throw.
5444         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5445         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5446         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5447         (get_prev_frame_always, get_frame_pc_if_available)
5448         (get_frame_address_in_block_if_available, get_frame_language):
5449         Replace throw_exception with throw.
5450         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5451         throw_exception with throw.
5452         * eval.c (fetch_subexp_value, evaluate_var_value)
5453         (evaluate_funcall, evaluate_subexp_standard): Replace
5454         throw_exception with throw.
5455         * dwarf2loc.c (call_site_find_chain)
5456         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5457         Replace throw_exception with throw.
5458         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5459         with throw.
5460         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5461         throw.
5462         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5463         * completer.c (complete_line_internal): Replace throw_exception
5464         with throw.
5465         * compile/compile-object-run.c (compile_object_run): Replace
5466         throw_exception with throw.
5467         * cli/cli-script.c (process_next_line): Replace throw_exception
5468         with throw.
5469         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5470         (btrace_enable, btrace_maint_update_pt_packets): Replace
5471         throw_exception with throw.
5472         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5473         throw_exception with throw.
5474         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5475         throw_exception with throw.
5476         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5477         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5478         * aarch64-tdep.c (aarch64_make_prologue_cache)
5479         (aarch64_make_stub_cache): Replace throw_exception with throw.
5480
5481 2019-04-08  Tom Tromey  <tom@tromey.com>
5482
5483         * common/common-exceptions.c (throw_exception): Rename from
5484         throw_exception_cxx.  Remove old copy.  Make argument const.
5485         (throw_it): Create and throw exception objects directly.
5486         * common/common-exceptions.h (throw_exception): Make argument
5487         const.
5488         (struct gdb_exception_error): Add constructor.
5489         (struct gdb_exception_quit): Add constructor.
5490
5491 2019-04-08  Tom Tromey  <tom@tromey.com>
5492
5493         * common/common-exceptions.h (exception_rethrow): Don't declare.
5494         (TRY_SJLJ): Update comment.
5495         (TRY, CATCH, END_CATCH): Remove.
5496         * common/common-exceptions.c (exception_rethrow): Remove.
5497
5498 2019-04-08  Tom Tromey  <tom@tromey.com>
5499
5500         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5501         Remove.
5502         (gdb_exception_error): Rename from
5503         gdb_exception_RETURN_MASK_ERROR.
5504         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5505         (gdb_quit_bad_alloc): Update.
5506         * aarch64-tdep.c: Update.
5507         * ada-lang.c: Update.
5508         * ada-typeprint.c: Update.
5509         * ada-valprint.c: Update.
5510         * amd64-tdep.c: Update.
5511         * arch-utils.c: Update.
5512         * break-catch-throw.c: Update.
5513         * breakpoint.c: Update.
5514         * btrace.c: Update.
5515         * c-varobj.c: Update.
5516         * cli/cli-cmds.c: Update.
5517         * cli/cli-interp.c: Update.
5518         * cli/cli-script.c: Update.
5519         * common/common-exceptions.c: Update.
5520         * common/new-op.c: Update.
5521         * common/selftest.c: Update.
5522         * compile/compile-c-symbols.c: Update.
5523         * compile/compile-cplus-symbols.c: Update.
5524         * compile/compile-object-load.c: Update.
5525         * compile/compile-object-run.c: Update.
5526         * completer.c: Update.
5527         * corelow.c: Update.
5528         * cp-abi.c: Update.
5529         * cp-support.c: Update.
5530         * cp-valprint.c: Update.
5531         * darwin-nat.c: Update.
5532         * disasm-selftests.c: Update.
5533         * dtrace-probe.c: Update.
5534         * dwarf-index-cache.c: Update.
5535         * dwarf-index-write.c: Update.
5536         * dwarf2-frame-tailcall.c: Update.
5537         * dwarf2-frame.c: Update.
5538         * dwarf2loc.c: Update.
5539         * dwarf2read.c: Update.
5540         * eval.c: Update.
5541         * event-loop.c: Update.
5542         * event-top.c: Update.
5543         * exec.c: Update.
5544         * f-valprint.c: Update.
5545         * fbsd-tdep.c: Update.
5546         * frame-unwind.c: Update.
5547         * frame.c: Update.
5548         * gdbtypes.c: Update.
5549         * gnu-v3-abi.c: Update.
5550         * guile/guile-internal.h: Update.
5551         * guile/scm-block.c: Update.
5552         * guile/scm-breakpoint.c: Update.
5553         * guile/scm-cmd.c: Update.
5554         * guile/scm-disasm.c: Update.
5555         * guile/scm-frame.c: Update.
5556         * guile/scm-lazy-string.c: Update.
5557         * guile/scm-math.c: Update.
5558         * guile/scm-param.c: Update.
5559         * guile/scm-ports.c: Update.
5560         * guile/scm-pretty-print.c: Update.
5561         * guile/scm-symbol.c: Update.
5562         * guile/scm-symtab.c: Update.
5563         * guile/scm-type.c: Update.
5564         * guile/scm-value.c: Update.
5565         * i386-linux-tdep.c: Update.
5566         * i386-tdep.c: Update.
5567         * inf-loop.c: Update.
5568         * infcall.c: Update.
5569         * infcmd.c: Update.
5570         * infrun.c: Update.
5571         * jit.c: Update.
5572         * language.c: Update.
5573         * linespec.c: Update.
5574         * linux-fork.c: Update.
5575         * linux-nat.c: Update.
5576         * linux-tdep.c: Update.
5577         * linux-thread-db.c: Update.
5578         * main.c: Update.
5579         * mi/mi-cmd-break.c: Update.
5580         * mi/mi-cmd-stack.c: Update.
5581         * mi/mi-interp.c: Update.
5582         * mi/mi-main.c: Update.
5583         * objc-lang.c: Update.
5584         * p-valprint.c: Update.
5585         * parse.c: Update.
5586         * ppc-linux-tdep.c: Update.
5587         * printcmd.c: Update.
5588         * python/py-arch.c: Update.
5589         * python/py-breakpoint.c: Update.
5590         * python/py-cmd.c: Update.
5591         * python/py-finishbreakpoint.c: Update.
5592         * python/py-frame.c: Update.
5593         * python/py-framefilter.c: Update.
5594         * python/py-gdb-readline.c: Update.
5595         * python/py-inferior.c: Update.
5596         * python/py-infthread.c: Update.
5597         * python/py-lazy-string.c: Update.
5598         * python/py-linetable.c: Update.
5599         * python/py-objfile.c: Update.
5600         * python/py-param.c: Update.
5601         * python/py-prettyprint.c: Update.
5602         * python/py-progspace.c: Update.
5603         * python/py-record-btrace.c: Update.
5604         * python/py-record.c: Update.
5605         * python/py-symbol.c: Update.
5606         * python/py-type.c: Update.
5607         * python/py-unwind.c: Update.
5608         * python/py-utils.c: Update.
5609         * python/py-value.c: Update.
5610         * python/python.c: Update.
5611         * record-btrace.c: Update.
5612         * record-full.c: Update.
5613         * remote-fileio.c: Update.
5614         * remote.c: Update.
5615         * riscv-tdep.c: Update.
5616         * rs6000-aix-tdep.c: Update.
5617         * rs6000-tdep.c: Update.
5618         * rust-exp.y: Update.
5619         * rust-lang.c: Update.
5620         * s390-tdep.c: Update.
5621         * selftest-arch.c: Update.
5622         * solib-dsbt.c: Update.
5623         * solib-frv.c: Update.
5624         * solib-spu.c: Update.
5625         * solib-svr4.c: Update.
5626         * solib.c: Update.
5627         * sparc64-linux-tdep.c: Update.
5628         * stack.c: Update.
5629         * symfile-mem.c: Update.
5630         * symmisc.c: Update.
5631         * target.c: Update.
5632         * thread.c: Update.
5633         * top.c: Update.
5634         * tracefile-tfile.c: Update.
5635         * tui/tui.c: Update.
5636         * typeprint.c: Update.
5637         * unittests/cli-utils-selftests.c: Update.
5638         * unittests/parse-connection-spec-selftests.c: Update.
5639         * valops.c: Update.
5640         * valprint.c: Update.
5641         * value.c: Update.
5642         * varobj.c: Update.
5643         * windows-nat.c: Update.
5644         * x86-linux-nat.c: Update.
5645         * xml-support.c: Update.
5646
5647 2019-04-08  Tom Tromey  <tom@tromey.com>
5648
5649         * xml-support.c: Use C++ exception handling.
5650         * x86-linux-nat.c: Use C++ exception handling.
5651         * windows-nat.c: Use C++ exception handling.
5652         * varobj.c: Use C++ exception handling.
5653         * value.c: Use C++ exception handling.
5654         * valprint.c: Use C++ exception handling.
5655         * valops.c: Use C++ exception handling.
5656         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5657         handling.
5658         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5659         * typeprint.c: Use C++ exception handling.
5660         * tui/tui.c: Use C++ exception handling.
5661         * tracefile-tfile.c: Use C++ exception handling.
5662         * top.c: Use C++ exception handling.
5663         * thread.c: Use C++ exception handling.
5664         * target.c: Use C++ exception handling.
5665         * symmisc.c: Use C++ exception handling.
5666         * symfile-mem.c: Use C++ exception handling.
5667         * stack.c: Use C++ exception handling.
5668         * sparc64-linux-tdep.c: Use C++ exception handling.
5669         * solib.c: Use C++ exception handling.
5670         * solib-svr4.c: Use C++ exception handling.
5671         * solib-spu.c: Use C++ exception handling.
5672         * solib-frv.c: Use C++ exception handling.
5673         * solib-dsbt.c: Use C++ exception handling.
5674         * selftest-arch.c: Use C++ exception handling.
5675         * s390-tdep.c: Use C++ exception handling.
5676         * rust-lang.c: Use C++ exception handling.
5677         * rust-exp.y: Use C++ exception handling.
5678         * rs6000-tdep.c: Use C++ exception handling.
5679         * rs6000-aix-tdep.c: Use C++ exception handling.
5680         * riscv-tdep.c: Use C++ exception handling.
5681         * remote.c: Use C++ exception handling.
5682         * remote-fileio.c: Use C++ exception handling.
5683         * record-full.c: Use C++ exception handling.
5684         * record-btrace.c: Use C++ exception handling.
5685         * python/python.c: Use C++ exception handling.
5686         * python/py-value.c: Use C++ exception handling.
5687         * python/py-utils.c: Use C++ exception handling.
5688         * python/py-unwind.c: Use C++ exception handling.
5689         * python/py-type.c: Use C++ exception handling.
5690         * python/py-symbol.c: Use C++ exception handling.
5691         * python/py-record.c: Use C++ exception handling.
5692         * python/py-record-btrace.c: Use C++ exception handling.
5693         * python/py-progspace.c: Use C++ exception handling.
5694         * python/py-prettyprint.c: Use C++ exception handling.
5695         * python/py-param.c: Use C++ exception handling.
5696         * python/py-objfile.c: Use C++ exception handling.
5697         * python/py-linetable.c: Use C++ exception handling.
5698         * python/py-lazy-string.c: Use C++ exception handling.
5699         * python/py-infthread.c: Use C++ exception handling.
5700         * python/py-inferior.c: Use C++ exception handling.
5701         * python/py-gdb-readline.c: Use C++ exception handling.
5702         * python/py-framefilter.c: Use C++ exception handling.
5703         * python/py-frame.c: Use C++ exception handling.
5704         * python/py-finishbreakpoint.c: Use C++ exception handling.
5705         * python/py-cmd.c: Use C++ exception handling.
5706         * python/py-breakpoint.c: Use C++ exception handling.
5707         * python/py-arch.c: Use C++ exception handling.
5708         * printcmd.c: Use C++ exception handling.
5709         * ppc-linux-tdep.c: Use C++ exception handling.
5710         * parse.c: Use C++ exception handling.
5711         * p-valprint.c: Use C++ exception handling.
5712         * objc-lang.c: Use C++ exception handling.
5713         * mi/mi-main.c: Use C++ exception handling.
5714         * mi/mi-interp.c: Use C++ exception handling.
5715         * mi/mi-cmd-stack.c: Use C++ exception handling.
5716         * mi/mi-cmd-break.c: Use C++ exception handling.
5717         * main.c: Use C++ exception handling.
5718         * linux-thread-db.c: Use C++ exception handling.
5719         * linux-tdep.c: Use C++ exception handling.
5720         * linux-nat.c: Use C++ exception handling.
5721         * linux-fork.c: Use C++ exception handling.
5722         * linespec.c: Use C++ exception handling.
5723         * language.c: Use C++ exception handling.
5724         * jit.c: Use C++ exception handling.
5725         * infrun.c: Use C++ exception handling.
5726         * infcmd.c: Use C++ exception handling.
5727         * infcall.c: Use C++ exception handling.
5728         * inf-loop.c: Use C++ exception handling.
5729         * i386-tdep.c: Use C++ exception handling.
5730         * i386-linux-tdep.c: Use C++ exception handling.
5731         * guile/scm-value.c: Use C++ exception handling.
5732         * guile/scm-type.c: Use C++ exception handling.
5733         * guile/scm-symtab.c: Use C++ exception handling.
5734         * guile/scm-symbol.c: Use C++ exception handling.
5735         * guile/scm-pretty-print.c: Use C++ exception handling.
5736         * guile/scm-ports.c: Use C++ exception handling.
5737         * guile/scm-param.c: Use C++ exception handling.
5738         * guile/scm-math.c: Use C++ exception handling.
5739         * guile/scm-lazy-string.c: Use C++ exception handling.
5740         * guile/scm-frame.c: Use C++ exception handling.
5741         * guile/scm-disasm.c: Use C++ exception handling.
5742         * guile/scm-cmd.c: Use C++ exception handling.
5743         * guile/scm-breakpoint.c: Use C++ exception handling.
5744         * guile/scm-block.c: Use C++ exception handling.
5745         * guile/guile-internal.h: Use C++ exception handling.
5746         * gnu-v3-abi.c: Use C++ exception handling.
5747         * gdbtypes.c: Use C++ exception handling.
5748         * frame.c: Use C++ exception handling.
5749         * frame-unwind.c: Use C++ exception handling.
5750         * fbsd-tdep.c: Use C++ exception handling.
5751         * f-valprint.c: Use C++ exception handling.
5752         * exec.c: Use C++ exception handling.
5753         * event-top.c: Use C++ exception handling.
5754         * event-loop.c: Use C++ exception handling.
5755         * eval.c: Use C++ exception handling.
5756         * dwarf2read.c: Use C++ exception handling.
5757         * dwarf2loc.c: Use C++ exception handling.
5758         * dwarf2-frame.c: Use C++ exception handling.
5759         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5760         * dwarf-index-write.c: Use C++ exception handling.
5761         * dwarf-index-cache.c: Use C++ exception handling.
5762         * dtrace-probe.c: Use C++ exception handling.
5763         * disasm-selftests.c: Use C++ exception handling.
5764         * darwin-nat.c: Use C++ exception handling.
5765         * cp-valprint.c: Use C++ exception handling.
5766         * cp-support.c: Use C++ exception handling.
5767         * cp-abi.c: Use C++ exception handling.
5768         * corelow.c: Use C++ exception handling.
5769         * completer.c: Use C++ exception handling.
5770         * compile/compile-object-run.c: Use C++ exception handling.
5771         * compile/compile-object-load.c: Use C++ exception handling.
5772         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5773         * compile/compile-c-symbols.c: Use C++ exception handling.
5774         * common/selftest.c: Use C++ exception handling.
5775         * common/new-op.c: Use C++ exception handling.
5776         * cli/cli-script.c: Use C++ exception handling.
5777         * cli/cli-interp.c: Use C++ exception handling.
5778         * cli/cli-cmds.c: Use C++ exception handling.
5779         * c-varobj.c: Use C++ exception handling.
5780         * btrace.c: Use C++ exception handling.
5781         * breakpoint.c: Use C++ exception handling.
5782         * break-catch-throw.c: Use C++ exception handling.
5783         * arch-utils.c: Use C++ exception handling.
5784         * amd64-tdep.c: Use C++ exception handling.
5785         * ada-valprint.c: Use C++ exception handling.
5786         * ada-typeprint.c: Use C++ exception handling.
5787         * ada-lang.c: Use C++ exception handling.
5788         * aarch64-tdep.c: Use C++ exception handling.
5789
5790 2019-04-08  Tom Tromey  <tom@tromey.com>
5791
5792         * xml-support.c (gdb_xml_parser::parse): Update.
5793         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5794         * value.c (show_convenience): Update.
5795         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5796         (test_parse_flags_qcs): Update.
5797         * thread.c (thr_try_catch_cmd): Update.
5798         * target.c (target_translate_tls_address): Update.
5799         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5800         (info_frame_command_core, frame_apply_command_count): Update.
5801         * rust-exp.y (rust_lex_exception_test): Update.
5802         * riscv-tdep.c (riscv_print_one_register_info): Update.
5803         * remote.c (remote_target::enable_btrace): Update.
5804         * record-btrace.c (record_btrace_enable_warn): Update.
5805         * python/py-utils.c (gdbpy_convert_exception): Update.
5806         * printcmd.c (do_one_display, print_variable_and_value): Update.
5807         * mi/mi-main.c (mi_print_exception): Update.
5808         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5809         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5810         * linux-nat.c (linux_nat_target::attach): Update.
5811         * linux-fork.c (class scoped_switch_fork_info): Update.
5812         * infrun.c (displaced_step_prepare): Update.
5813         * infcall.c (call_function_by_hand_dummy): Update.
5814         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5815         * gnu-v3-abi.c (print_one_vtable): Update.
5816         * frame.c (get_prev_frame_always): Update.
5817         * f-valprint.c (info_common_command_for_block): Update.
5818         * exec.c (try_open_exec_file): Update.
5819         * exceptions.c (print_exception, exception_print)
5820         (exception_fprintf, exception_print_same): Update.
5821         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5822         * dwarf-index-cache.c (index_cache::store)
5823         (index_cache::lookup_gdb_index): Update.
5824         * darwin-nat.c (maybe_cache_shell): Update.
5825         * cp-valprint.c (cp_print_value_fields): Update.
5826         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5827         (gcc_cplus_symbol_address): Update.
5828         * compile/compile-c-symbols.c (gcc_convert_symbol)
5829         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5830         * common/selftest.c: Update.
5831         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5832         a std::string.
5833         (exception_try_scope_entry, exception_try_scope_exit): Don't
5834         declare.
5835         (struct exception_try_scope): Remove.
5836         (TRY): Don't use exception_try_scope.
5837         (struct gdb_exception): Add constructor, operator=.
5838         <what>: New method.
5839         (struct gdb_exception_RETURN_MASK_ALL)
5840         (struct gdb_exception_RETURN_MASK_ERROR)
5841         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5842         (struct gdb_quit_bad_alloc): Update.
5843         * common/common-exceptions.c (exception_none): Change
5844         initializer.
5845         (struct catcher) <state, exception>: Initialize inline.
5846         <prev>: Remove member.
5847         (current_catcher): Remove.
5848         (catchers): New global.
5849         (exceptions_state_mc_init): Simplify.
5850         (catcher_pop): Remove.
5851         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5852         (try_scope_depth, exception_try_scope_entry)
5853         (exception_try_scope_exit): Remove.
5854         (throw_exception_sjlj): Update.
5855         (exception_messages, exception_messages_size): Remove.
5856         (throw_it): Simplify.
5857         (gdb_exception_sliced_copy): Remove.
5858         (throw_exception_cxx): Update.
5859         * cli/cli-script.c (script_from_file): Update.
5860         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5861         Update.
5862         * ada-valprint.c (ada_val_print): Update.
5863         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5864         (create_excep_cond_exprs): Update.
5865
5866 2019-04-08  Tom Tromey  <tom@tromey.com>
5867
5868         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5869         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5870         (TRY, CATCH, END_CATCH): Remove some definitions.
5871         * common/common-exceptions.c: Don't use GDB_XCPT.
5872         (catcher_list_size): Remove.
5873         (throw_exception, throw_it): Simplify.
5874
5875 2019-04-05  Tom Tromey  <tom@tromey.com>
5876
5877         Revert the header-sorting patch.
5878         * ft32-tdep.c: Revert.
5879         * frv-tdep.c: Revert.
5880         * frv-linux-tdep.c: Revert.
5881         * frame.c: Revert.
5882         * frame-unwind.c: Revert.
5883         * frame-base.c: Revert.
5884         * fork-child.c: Revert.
5885         * findvar.c: Revert.
5886         * findcmd.c: Revert.
5887         * filesystem.c: Revert.
5888         * filename-seen-cache.h: Revert.
5889         * filename-seen-cache.c: Revert.
5890         * fbsd-tdep.c: Revert.
5891         * fbsd-nat.h: Revert.
5892         * fbsd-nat.c: Revert.
5893         * f-valprint.c: Revert.
5894         * f-typeprint.c: Revert.
5895         * f-lang.c: Revert.
5896         * extension.h: Revert.
5897         * extension.c: Revert.
5898         * extension-priv.h: Revert.
5899         * expprint.c: Revert.
5900         * exec.h: Revert.
5901         * exec.c: Revert.
5902         * exceptions.c: Revert.
5903         * event-top.c: Revert.
5904         * event-loop.c: Revert.
5905         * eval.c: Revert.
5906         * elfread.c: Revert.
5907         * dwarf2read.h: Revert.
5908         * dwarf2read.c: Revert.
5909         * dwarf2loc.c: Revert.
5910         * dwarf2expr.h: Revert.
5911         * dwarf2expr.c: Revert.
5912         * dwarf2-frame.c: Revert.
5913         * dwarf2-frame-tailcall.c: Revert.
5914         * dwarf-index-write.h: Revert.
5915         * dwarf-index-write.c: Revert.
5916         * dwarf-index-common.c: Revert.
5917         * dwarf-index-cache.h: Revert.
5918         * dwarf-index-cache.c: Revert.
5919         * dummy-frame.c: Revert.
5920         * dtrace-probe.c: Revert.
5921         * disasm.h: Revert.
5922         * disasm.c: Revert.
5923         * disasm-selftests.c: Revert.
5924         * dictionary.c: Revert.
5925         * dicos-tdep.c: Revert.
5926         * demangle.c: Revert.
5927         * dcache.h: Revert.
5928         * dcache.c: Revert.
5929         * darwin-nat.h: Revert.
5930         * darwin-nat.c: Revert.
5931         * darwin-nat-info.c: Revert.
5932         * d-valprint.c: Revert.
5933         * d-namespace.c: Revert.
5934         * d-lang.c: Revert.
5935         * ctf.c: Revert.
5936         * csky-tdep.c: Revert.
5937         * csky-linux-tdep.c: Revert.
5938         * cris-tdep.c: Revert.
5939         * cris-linux-tdep.c: Revert.
5940         * cp-valprint.c: Revert.
5941         * cp-support.c: Revert.
5942         * cp-namespace.c: Revert.
5943         * cp-abi.c: Revert.
5944         * corelow.c: Revert.
5945         * corefile.c: Revert.
5946         * continuations.c: Revert.
5947         * completer.h: Revert.
5948         * completer.c: Revert.
5949         * complaints.c: Revert.
5950         * coffread.c: Revert.
5951         * coff-pe-read.c: Revert.
5952         * cli-out.h: Revert.
5953         * cli-out.c: Revert.
5954         * charset.c: Revert.
5955         * c-varobj.c: Revert.
5956         * c-valprint.c: Revert.
5957         * c-typeprint.c: Revert.
5958         * c-lang.c: Revert.
5959         * buildsym.c: Revert.
5960         * buildsym-legacy.c: Revert.
5961         * build-id.h: Revert.
5962         * build-id.c: Revert.
5963         * btrace.c: Revert.
5964         * bsd-uthread.c: Revert.
5965         * breakpoint.h: Revert.
5966         * breakpoint.c: Revert.
5967         * break-catch-throw.c: Revert.
5968         * break-catch-syscall.c: Revert.
5969         * break-catch-sig.c: Revert.
5970         * blockframe.c: Revert.
5971         * block.c: Revert.
5972         * bfin-tdep.c: Revert.
5973         * bfin-linux-tdep.c: Revert.
5974         * bfd-target.c: Revert.
5975         * bcache.c: Revert.
5976         * ax-general.c: Revert.
5977         * ax-gdb.h: Revert.
5978         * ax-gdb.c: Revert.
5979         * avr-tdep.c: Revert.
5980         * auxv.c: Revert.
5981         * auto-load.c: Revert.
5982         * arm-wince-tdep.c: Revert.
5983         * arm-tdep.c: Revert.
5984         * arm-symbian-tdep.c: Revert.
5985         * arm-pikeos-tdep.c: Revert.
5986         * arm-obsd-tdep.c: Revert.
5987         * arm-nbsd-tdep.c: Revert.
5988         * arm-nbsd-nat.c: Revert.
5989         * arm-linux-tdep.c: Revert.
5990         * arm-linux-nat.c: Revert.
5991         * arm-fbsd-tdep.c: Revert.
5992         * arm-fbsd-nat.c: Revert.
5993         * arm-bsd-tdep.c: Revert.
5994         * arch-utils.c: Revert.
5995         * arc-tdep.c: Revert.
5996         * arc-newlib-tdep.c: Revert.
5997         * annotate.h: Revert.
5998         * annotate.c: Revert.
5999         * amd64-windows-tdep.c: Revert.
6000         * amd64-windows-nat.c: Revert.
6001         * amd64-tdep.c: Revert.
6002         * amd64-sol2-tdep.c: Revert.
6003         * amd64-obsd-tdep.c: Revert.
6004         * amd64-obsd-nat.c: Revert.
6005         * amd64-nbsd-tdep.c: Revert.
6006         * amd64-nbsd-nat.c: Revert.
6007         * amd64-nat.c: Revert.
6008         * amd64-linux-tdep.c: Revert.
6009         * amd64-linux-nat.c: Revert.
6010         * amd64-fbsd-tdep.c: Revert.
6011         * amd64-fbsd-nat.c: Revert.
6012         * amd64-dicos-tdep.c: Revert.
6013         * amd64-darwin-tdep.c: Revert.
6014         * amd64-bsd-nat.c: Revert.
6015         * alpha-tdep.c: Revert.
6016         * alpha-obsd-tdep.c: Revert.
6017         * alpha-nbsd-tdep.c: Revert.
6018         * alpha-mdebug-tdep.c: Revert.
6019         * alpha-linux-tdep.c: Revert.
6020         * alpha-linux-nat.c: Revert.
6021         * alpha-bsd-tdep.c: Revert.
6022         * alpha-bsd-nat.c: Revert.
6023         * aix-thread.c: Revert.
6024         * agent.c: Revert.
6025         * addrmap.c: Revert.
6026         * ada-varobj.c: Revert.
6027         * ada-valprint.c: Revert.
6028         * ada-typeprint.c: Revert.
6029         * ada-tasks.c: Revert.
6030         * ada-lang.c: Revert.
6031         * aarch64-tdep.c: Revert.
6032         * aarch64-ravenscar-thread.c: Revert.
6033         * aarch64-newlib-tdep.c: Revert.
6034         * aarch64-linux-tdep.c: Revert.
6035         * aarch64-linux-nat.c: Revert.
6036         * aarch64-fbsd-tdep.c: Revert.
6037         * aarch64-fbsd-nat.c: Revert.
6038         * aarch32-linux-nat.c: Revert.
6039
6040 2019-04-05  Tom Tromey  <tom@tromey.com>
6041
6042         * ft32-tdep.c: Sort headers.
6043         * frv-tdep.c: Sort headers.
6044         * frv-linux-tdep.c: Sort headers.
6045         * frame.c: Sort headers.
6046         * frame-unwind.c: Sort headers.
6047         * frame-base.c: Sort headers.
6048         * fork-child.c: Sort headers.
6049         * findvar.c: Sort headers.
6050         * findcmd.c: Sort headers.
6051         * filesystem.c: Sort headers.
6052         * filename-seen-cache.h: Sort headers.
6053         * filename-seen-cache.c: Sort headers.
6054         * fbsd-tdep.c: Sort headers.
6055         * fbsd-nat.h: Sort headers.
6056         * fbsd-nat.c: Sort headers.
6057         * f-valprint.c: Sort headers.
6058         * f-typeprint.c: Sort headers.
6059         * f-lang.c: Sort headers.
6060         * extension.h: Sort headers.
6061         * extension.c: Sort headers.
6062         * extension-priv.h: Sort headers.
6063         * expprint.c: Sort headers.
6064         * exec.h: Sort headers.
6065         * exec.c: Sort headers.
6066         * exceptions.c: Sort headers.
6067         * event-top.c: Sort headers.
6068         * event-loop.c: Sort headers.
6069         * eval.c: Sort headers.
6070         * elfread.c: Sort headers.
6071         * dwarf2read.h: Sort headers.
6072         * dwarf2read.c: Sort headers.
6073         * dwarf2loc.c: Sort headers.
6074         * dwarf2expr.h: Sort headers.
6075         * dwarf2expr.c: Sort headers.
6076         * dwarf2-frame.c: Sort headers.
6077         * dwarf2-frame-tailcall.c: Sort headers.
6078         * dwarf-index-write.h: Sort headers.
6079         * dwarf-index-write.c: Sort headers.
6080         * dwarf-index-common.c: Sort headers.
6081         * dwarf-index-cache.h: Sort headers.
6082         * dwarf-index-cache.c: Sort headers.
6083         * dummy-frame.c: Sort headers.
6084         * dtrace-probe.c: Sort headers.
6085         * disasm.h: Sort headers.
6086         * disasm.c: Sort headers.
6087         * disasm-selftests.c: Sort headers.
6088         * dictionary.c: Sort headers.
6089         * dicos-tdep.c: Sort headers.
6090         * demangle.c: Sort headers.
6091         * dcache.h: Sort headers.
6092         * dcache.c: Sort headers.
6093         * darwin-nat.h: Sort headers.
6094         * darwin-nat.c: Sort headers.
6095         * darwin-nat-info.c: Sort headers.
6096         * d-valprint.c: Sort headers.
6097         * d-namespace.c: Sort headers.
6098         * d-lang.c: Sort headers.
6099         * ctf.c: Sort headers.
6100         * csky-tdep.c: Sort headers.
6101         * csky-linux-tdep.c: Sort headers.
6102         * cris-tdep.c: Sort headers.
6103         * cris-linux-tdep.c: Sort headers.
6104         * cp-valprint.c: Sort headers.
6105         * cp-support.c: Sort headers.
6106         * cp-namespace.c: Sort headers.
6107         * cp-abi.c: Sort headers.
6108         * corelow.c: Sort headers.
6109         * corefile.c: Sort headers.
6110         * continuations.c: Sort headers.
6111         * completer.h: Sort headers.
6112         * completer.c: Sort headers.
6113         * complaints.c: Sort headers.
6114         * coffread.c: Sort headers.
6115         * coff-pe-read.c: Sort headers.
6116         * cli-out.h: Sort headers.
6117         * cli-out.c: Sort headers.
6118         * charset.c: Sort headers.
6119         * c-varobj.c: Sort headers.
6120         * c-valprint.c: Sort headers.
6121         * c-typeprint.c: Sort headers.
6122         * c-lang.c: Sort headers.
6123         * buildsym.c: Sort headers.
6124         * buildsym-legacy.c: Sort headers.
6125         * build-id.h: Sort headers.
6126         * build-id.c: Sort headers.
6127         * btrace.c: Sort headers.
6128         * bsd-uthread.c: Sort headers.
6129         * breakpoint.h: Sort headers.
6130         * breakpoint.c: Sort headers.
6131         * break-catch-throw.c: Sort headers.
6132         * break-catch-syscall.c: Sort headers.
6133         * break-catch-sig.c: Sort headers.
6134         * blockframe.c: Sort headers.
6135         * block.c: Sort headers.
6136         * bfin-tdep.c: Sort headers.
6137         * bfin-linux-tdep.c: Sort headers.
6138         * bfd-target.c: Sort headers.
6139         * bcache.c: Sort headers.
6140         * ax-general.c: Sort headers.
6141         * ax-gdb.h: Sort headers.
6142         * ax-gdb.c: Sort headers.
6143         * avr-tdep.c: Sort headers.
6144         * auxv.c: Sort headers.
6145         * auto-load.c: Sort headers.
6146         * arm-wince-tdep.c: Sort headers.
6147         * arm-tdep.c: Sort headers.
6148         * arm-symbian-tdep.c: Sort headers.
6149         * arm-pikeos-tdep.c: Sort headers.
6150         * arm-obsd-tdep.c: Sort headers.
6151         * arm-nbsd-tdep.c: Sort headers.
6152         * arm-nbsd-nat.c: Sort headers.
6153         * arm-linux-tdep.c: Sort headers.
6154         * arm-linux-nat.c: Sort headers.
6155         * arm-fbsd-tdep.c: Sort headers.
6156         * arm-fbsd-nat.c: Sort headers.
6157         * arm-bsd-tdep.c: Sort headers.
6158         * arch-utils.c: Sort headers.
6159         * arc-tdep.c: Sort headers.
6160         * arc-newlib-tdep.c: Sort headers.
6161         * annotate.h: Sort headers.
6162         * annotate.c: Sort headers.
6163         * amd64-windows-tdep.c: Sort headers.
6164         * amd64-windows-nat.c: Sort headers.
6165         * amd64-tdep.c: Sort headers.
6166         * amd64-sol2-tdep.c: Sort headers.
6167         * amd64-obsd-tdep.c: Sort headers.
6168         * amd64-obsd-nat.c: Sort headers.
6169         * amd64-nbsd-tdep.c: Sort headers.
6170         * amd64-nbsd-nat.c: Sort headers.
6171         * amd64-nat.c: Sort headers.
6172         * amd64-linux-tdep.c: Sort headers.
6173         * amd64-linux-nat.c: Sort headers.
6174         * amd64-fbsd-tdep.c: Sort headers.
6175         * amd64-fbsd-nat.c: Sort headers.
6176         * amd64-dicos-tdep.c: Sort headers.
6177         * amd64-darwin-tdep.c: Sort headers.
6178         * amd64-bsd-nat.c: Sort headers.
6179         * alpha-tdep.c: Sort headers.
6180         * alpha-obsd-tdep.c: Sort headers.
6181         * alpha-nbsd-tdep.c: Sort headers.
6182         * alpha-mdebug-tdep.c: Sort headers.
6183         * alpha-linux-tdep.c: Sort headers.
6184         * alpha-linux-nat.c: Sort headers.
6185         * alpha-bsd-tdep.c: Sort headers.
6186         * alpha-bsd-nat.c: Sort headers.
6187         * aix-thread.c: Sort headers.
6188         * agent.c: Sort headers.
6189         * addrmap.c: Sort headers.
6190         * ada-varobj.c: Sort headers.
6191         * ada-valprint.c: Sort headers.
6192         * ada-typeprint.c: Sort headers.
6193         * ada-tasks.c: Sort headers.
6194         * ada-lang.c: Sort headers.
6195         * aarch64-tdep.c: Sort headers.
6196         * aarch64-ravenscar-thread.c: Sort headers.
6197         * aarch64-newlib-tdep.c: Sort headers.
6198         * aarch64-linux-tdep.c: Sort headers.
6199         * aarch64-linux-nat.c: Sort headers.
6200         * aarch64-fbsd-tdep.c: Sort headers.
6201         * aarch64-fbsd-nat.c: Sort headers.
6202         * aarch32-linux-nat.c: Sort headers.
6203
6204 2019-04-04  Tom Tromey  <tom@tromey.com>
6205
6206         * varobj.c (varobj_create): Update.
6207         * rust-exp.y (struct rust_parser) <update_innermost_block,
6208         lookup_symbol>: New methods.
6209         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6210         Rename.
6211         (rust_parser::rust_lookup_type)
6212         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6213         * printcmd.c (display_command, do_one_display): Update.
6214         * parser-defs.h (struct parser_state) <parser_state>: Add
6215         "tracker" parameter.
6216         (block_tracker): New member.
6217         (class innermost_block_tracker) <innermost_block_tracker>: Add
6218         "types" parameter.
6219         <reset>: Remove method.
6220         (innermost_block): Don't declare.
6221         (null_post_parser): Update.
6222         * parse.c (innermost_block): Remove global.
6223         (write_dollar_variable): Update.
6224         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6225         Remove "tracker_types" parameter.
6226         (parse_expression): Add "tracker" parameter.
6227         (parse_expression_for_completion): Update.
6228         (null_post_parser): Add "tracker" parameter.
6229         * p-exp.y: Update rules.
6230         * m2-exp.y: Update rules.
6231         * language.h (struct language_defn) <la_post_parser>: Add
6232         "tracker" parameter.
6233         * go-exp.y: Update rules.
6234         * f-exp.y: Update rules.
6235         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6236         parameter.
6237         * d-exp.y: Update rules.
6238         * c-exp.y: Update rules.
6239         * breakpoint.c (set_breakpoint_condition): Create an
6240         innermost_block_tracker.
6241         (watch_command_1): Likewise.
6242         * ada-lang.c (resolve): Add "tracker" parameter.
6243         (resolve_subexp): Likewise.
6244         * ada-exp.y (write_var_from_sym): Update.
6245
6246 2019-04-04  Tom Tromey  <tom@tromey.com>
6247
6248         * type-stack.h: New file.
6249         * type-stack.c: New file.
6250         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6251         type-stack.h.
6252         (insert_into_type_stack, insert_type, push_type, push_type_int)
6253         (insert_type_address_space, pop_type, pop_type_int)
6254         (pop_typelist, pop_type_stack, append_type_stack)
6255         (push_type_stack, get_type_stack, push_typelist)
6256         (follow_type_instance_flags, follow_types): Don't declare.
6257         * parse.c (type_stack): Remove global.
6258         (parse_exp_in_context): Update.
6259         (insert_into_type_stack, insert_type, push_type, push_type_int)
6260         (insert_type_address_space, pop_type, pop_type_int)
6261         (pop_typelist, pop_type_stack, append_type_stack)
6262         (push_type_stack, get_type_stack, push_typelist)
6263         (follow_type_instance_flags, follow_types): Remove (moved to
6264         type-stack.c).
6265         * f-exp.y (type_stack): New global.
6266         Update rules.
6267         (push_kind_type, f_parse): Update.
6268         * d-exp.y (type_stack): New global.
6269         Update rules.
6270         (d_parse): Update.
6271         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6272         Update rules.
6273         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6274         (HFILES_NO_SRCDIR): Add type-stack.h.
6275
6276 2019-04-04  Tom Tromey  <tom@tromey.com>
6277
6278         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6279         (rust_parser::convert_ast_to_expression, rust_parse)
6280         (rust_lex_test_completion, rust_lex_tests): Update.
6281         * parser-defs.h (struct expr_completion_state): New.
6282         (struct parser_state) <parser_state>: Add completion parameter.
6283         <mark_struct_expression, mark_completion_tag>: New methods.
6284         <parse_completion, m_completion_state>: New members.
6285         (prefixify_expression, null_post_parser): Update.
6286         (mark_struct_expression, mark_completion_tag): Don't declare.
6287         * parse.c (parse_completion, expout_last_struct)
6288         (expout_tag_completion_type, expout_completion_name): Remove
6289         globals.
6290         (parser_state::mark_struct_expression)
6291         (parser_state::mark_completion_tag): Now methods.
6292         (prefixify_expression): Add last_struct parameter.
6293         (prefixify_subexp): Likewise.
6294         (parse_exp_1): Update.
6295         (parse_exp_in_context): Add cstate parameter.  Update.
6296         (parse_expression_for_completion): Create an
6297         expr_completion_state.
6298         (null_post_parser): Add "completion" parameter.
6299         * p-exp.y: Update rules.
6300         (yylex): Update.
6301         * language.h (struct language_defn) <la_post_parser>: Add
6302         "completing" parameter.
6303         * go-exp.y: Update rules.
6304         (lex_one_token): Update.
6305         * expression.h (parse_completion): Don't declare.
6306         * d-exp.y: Update rules.
6307         (lex_one_token): Update rules.
6308         * c-exp.y: Update rules.
6309         (lex_one_token): Update.
6310         * ada-lang.c (resolve): Add "parse_completion" parameter.
6311         (resolve_subexp): Likewise.
6312         (ada_resolve_function): Likewise.
6313
6314 2019-04-04  Tom Tromey  <tom@tromey.com>
6315
6316         * parser-defs.h (struct parser_state) <start_arglist,
6317         end_arglist>: New methods.
6318         <arglist_len, m_funcall_chain>: New members.
6319         (arglist_len, start_arglist, end_arglist): Don't declare.
6320         * parse.c (arglist_len, funcall_chain): Remove global.
6321         (start_arglist, end_arglist): Remove functions.
6322         (parse_exp_in_context): Update.
6323         * p-exp.y: Update rules.
6324         * m2-exp.y: Update rules.
6325         * go-exp.y: Update rules.
6326         * f-exp.y: Update rules.
6327         * d-exp.y: Update rules.
6328         * c-exp.y: Update rules.
6329
6330 2019-04-04  Tom Tromey  <tom@tromey.com>
6331
6332         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6333         lex_operator, push_back>: New methods.
6334         Update all rules.
6335         (rust_parser::lex_hex, lex_escape): Rename and update.
6336         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6337         (rust_parser::lex_operator): Rename and update.
6338         (rust_parser::lex_number, rustyylex, rustyyerror)
6339         (rust_lex_test_init, rust_lex_test_sequence)
6340         (rust_lex_test_push_back, rust_lex_tests): Update.
6341         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6342         parameter.
6343         <lexptr, prev_lexptr>: New members.
6344         (lexptr, prev_lexptr): Don't declare.
6345         * parse.c (lexptr, prev_lexptr): Remove globals.
6346         (parse_exp_in_context): Update.
6347         * p-exp.y (yylex, yyerror): Update.
6348         * m2-exp.y (parse_number, yylex, yyerror): Update.
6349         * go-exp.y (lex_one_token, yyerror): Update.
6350         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6351         * d-exp.y (lex_one_token, yyerror): Update.
6352         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6353         (lex_one_token, yyerror): Update.
6354         * ada-lex.l (YY_INPUT): Update.
6355         (rewind_to_char): Update.
6356         * ada-exp.y (yyerror): Update.
6357
6358 2019-04-04  Tom Tromey  <tom@tromey.com>
6359
6360         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6361         * parser-defs.h (struct parser_state) <parser_state>: Add new
6362         parameter.
6363         <comma_terminates>: New member.
6364         (comma_terminates): Don't declare global.
6365         * parse.c (comma_terminates): Remove global.
6366         (parse_exp_in_context): Update.
6367         * p-exp.y (yylex): Update.
6368         * m2-exp.y (yylex): Update.
6369         * go-exp.y (lex_one_token): Update.
6370         * f-exp.y (yylex): Update.
6371         * d-exp.y (lex_one_token): Update.
6372         * c-exp.y (lex_one_token): Update.
6373         * ada-lex.l: Update.
6374
6375 2019-04-04  Tom Tromey  <tom@tromey.com>
6376
6377         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6378         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6379         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6380         * parser-defs.h (paren_depth): Don't declare.
6381         * parse.c (paren_depth): Remove global.
6382         (parse_exp_in_context): Update.
6383         * p-exp.y (paren_depth): New global.
6384         (pascal_parse): Initialize it.
6385         * m2-exp.y (paren_depth): New global.
6386         (m2_parse): Initialize it.
6387         * go-exp.y (paren_depth): New global.
6388         (go_parse): Initialize it.
6389         * f-exp.y (paren_depth): New global.
6390         (f_parse): Initialize it.
6391         * d-exp.y (paren_depth): New global.
6392         (d_parse): Initialize it.
6393         * c-exp.y (paren_depth): New global.
6394         (c_parse): Initialize it.
6395         * ada-lex.l (paren_depth): New global.
6396         (lexer_init): Initialize it.
6397
6398 2019-04-04  Tom Tromey  <tom@tromey.com>
6399
6400         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6401         (rust_parser::convert_ast_to_type)
6402         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6403         * parser-defs.h (struct parser_state) <parser_state>: Add
6404         parameters.  Initialize new members.
6405         <expression_context_block, expression_context_pc>: New members.
6406         * parse.c (expression_context_block, expression_context_pc):
6407         Remove globals.
6408         (parse_exp_in_context): Update.
6409         * p-exp.y: Update all rules.
6410         (yylex): Update.
6411         * m2-exp.y: Update all rules.
6412         (yylex): Update.
6413         * go-exp.y (yylex): Update.
6414         * f-exp.y (yylex): Update.
6415         * d-exp.y: Update all rules.
6416         (yylex): Update.
6417         * c-exp.y: Update all rules.
6418         (lex_one_token, classify_name, yylex, c_parse): Update.
6419         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6420
6421 2019-04-04  Tom Tromey  <tom@tromey.com>
6422
6423         * gdbarch.h, gdbarch.c: Rebuild.
6424         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6425         * stap-probe.h:
6426         (struct stap_parse_info): Replace "parser_state" with
6427         "expr_builder".
6428         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6429         (parser_state): New class.
6430         * parse.c (expr_builder): Rename.
6431         (expr_builder::release): Rename.
6432         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6433         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6434         (write_exp_elt_longcst, write_exp_elt_floatcst)
6435         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6436         (write_exp_string_vector, write_exp_bitstring)
6437         (write_exp_msymbol, mark_struct_expression)
6438         (write_dollar_variable)
6439         (insert_type_address_space, increase_expout_size): Replace
6440         "parser_state" with "expr_builder".
6441         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6442         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6443         "parser_state" with "expr_builder".
6444
6445 2019-04-04  Tom Tromey  <tom@tromey.com>
6446
6447         * rust-exp.y: Replace "parse_language" with method call.
6448         * p-exp.y:
6449         (yylex): Replace "parse_language" with method call.
6450         * m2-exp.y:
6451         (yylex): Replace "parse_language" with method call.
6452         * go-exp.y (classify_name): Replace "parse_language" with method
6453         call.
6454         * f-exp.y (yylex): Replace "parse_language" with method call.
6455         * d-exp.y (lex_one_token): Replace "parse_language" with method
6456         call.
6457         * c-exp.y:
6458         (lex_one_token, classify_name, yylex): Replace "parse_language"
6459         with method call.
6460         * ada-exp.y (find_primitive_type, type_char)
6461         (type_system_address): Replace "parse_language" with method call.
6462
6463 2019-04-04  Tom Tromey  <tom@tromey.com>
6464
6465         * rust-exp.y: Replace "parse_gdbarch" with method call.
6466         * parse.c (write_dollar_variable, insert_type_address_space):
6467         Replace "parse_gdbarch" with method call.
6468         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6469         call.
6470         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6471         call.
6472         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6473         "parse_gdbarch" with method call.
6474         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6475         with method call.
6476         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6477         "parse_gdbarch" with method call.
6478         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6479         "parse_gdbarch" with method call.
6480         * c-exp.y (parse_type, parse_number, classify_name): Replace
6481         "parse_gdbarch" with method call.
6482         * ada-lex.l: Replace "parse_gdbarch" with method call.
6483         * ada-exp.y (parse_type, find_primitive_type, type_char)
6484         (type_system_address): Replace "parse_gdbarch" with method call.
6485
6486 2019-04-04  Tom Tromey  <tom@tromey.com>
6487
6488         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6489         * stap-probe.c (stap_parse_argument): Update.
6490         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6491         initial_size parameter.
6492         * rust-exp.y (rust_lex_tests): Update.
6493         * parse.c (parser_state): Update.
6494         (parse_exp_in_context): Update.
6495         * parser-defs.h (struct parser_state) <parser_state>: Remove
6496         "initial_size" parameter.
6497
6498 2019-04-04  Tom Tromey  <tom@tromey.com>
6499
6500         * parser-defs.h (increase_expout_size): Don't declare.
6501         * parse.c (increase_expout_size): Now static.
6502
6503 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6504
6505         * gnu-nat.c (gnu_nat_target::wait): Fix
6506         target_waitstatus_to_string call.
6507
6508 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6509
6510         * eval.c (evaluate_subexp_standard): Handle internal functions
6511         during Fortran function call handling.
6512
6513 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6514
6515         * NEWS: Mention new internal functions.
6516         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6517         (read_base_type): Use dwarf2_init_complex_target_type.
6518         * value.c (creal_internal_fn): New function.
6519         (cimag_internal_fn): New function.
6520         (_initialize_values): Register new internal functions.
6521
6522 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6523
6524         * infrun.c (stop_all_threads): If debug_infrun, always
6525         trace the wait status after wait_one, using
6526         target_waitstatus_to_string and target_pid_to_str.
6527         (handle_inferior_event): Replace various trace of
6528         wait status kind by a single trace.
6529         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6530         wait status kind image by target_waitstatus_to_string.
6531         * target/waitstatus.c (target_waitstatus_to_string): Fix
6532         obsolete comment.
6533
6534 2019-04-01  Tom Tromey  <tromey@adacore.com>
6535
6536         PR symtab/23331:
6537         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6538
6539 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6540             Pedro Alves  <palves@redhat.com>
6541
6542         * top.c (quit_force): Call 'finalize_values'.
6543         * value.c (finalize_values): New function.
6544         * value.h (finalize_values): Declare.
6545
6546 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6547
6548         * NEWS: Announce $_gdb_major and $_gdb_minor.
6549
6550         * top.c (init_gdb_version_vars): New function.
6551         (gdb_init): Call init_gdb_version_vars.
6552
6553 2019-03-29  Tom Tromey  <tromey@adacore.com>
6554
6555         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6556         help text.  Remove dead code.
6557
6558 2019-03-29  Keith Seitz  <keiths@redhat.com>
6559
6560         From Siddhesh Poyarekar:
6561         * f-lang.h (f77_get_upperbound): Return LONGEST.
6562         (f77_get_lowerbound): Likewise.
6563         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6564         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6565         print them.
6566         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6567         plongest to format print it.
6568         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6569         (f77_get_upperbound): Likewise.
6570         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6571         LOWER_BOUND to LONGEST.
6572         (f77_create_arrayprint_offset_tbl): Likewise.
6573
6574 2019-03-29  Keith Seitz  <keiths@redhat.com>
6575
6576         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6577         %s/pulongest for TYPE_LENGTH instead of %d in format
6578         strings.
6579         * ada-typerint.c (ada_print_type): Likewise.
6580         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6581         * compile/compile-c-support.c (generate_register_struct): Likewise.
6582         * gdbtypes.c (recursive_dump_type): Likewise.
6583         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6584         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6585         instead of %d in format strings.
6586         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6587         to std::min to ULONGEST.
6588         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6589         instead of %d in format strings.
6590         * tracepoint.c (info_scope_command): Likewise.
6591         * typeprint.c (print_offset_data::update)
6592         (print_offset_data::finish): Likewise.
6593         * xtensa-tdep.c (xtensa_store_return_value)
6594         (xtensa_push_dummy_call): Likewise.
6595
6596 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6597
6598         * windows-nat.c (display_selector): Fixed format specifications
6599         for 64-bit Cygwin.
6600
6601 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6602
6603         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6604
6605 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6606
6607         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6608         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6609         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6610         (nios2_linux_init_abi): Install it.
6611
6612 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6613
6614         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6615
6616 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6617
6618         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6619
6620 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6621             Tom Tromey  <tromey@adacore.com>
6622
6623         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6624
6625 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6626
6627         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6628         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6629         method to compute the bounds of range types. Also print "[evaluated]"
6630         if the bounds' values come from a dynamic evaluation.
6631
6632 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6633
6634         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6635         whitespace when pretty printing is on.
6636
6637 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6638
6639         * ppc-linux-nat.c: Add include.
6640
6641 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6642
6643         * NEWS: Mention AArch64 Pointer Authentication.
6644
6645 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6646
6647         * arm-linux-nat.c: Add include.
6648
6649 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6650
6651         * source-cache.c (source_cache::get_source_lines): Re-read
6652         fullname after calling open_source_file.
6653
6654 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6655
6656         * NEWS: Mention TLS support for FreeBSD.
6657
6658 2019-03-25  Tom Tromey  <tromey@adacore.com>
6659
6660         * minsyms.c (BUNCH_SIZE): Update comment.
6661         (~minimal_symbol_reader): Remove old comment.
6662         (compact_minimal_symbols): Update comment.
6663         (minimal_symbol_reader::install): Remove old comment.  Update
6664         other comments.
6665
6666 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6667
6668         * s390-linux-nat.c: Add include.
6669
6670 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6671
6672         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6673         Call linux_get_hwcap.
6674         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6675         Likewise.
6676         (aarch64_linux_get_hwcap): Remove function.
6677         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6678         declaration.
6679         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6680         linux_get_hwcap.
6681         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6682         * linux-tdep.c (linux_get_hwcap): Add function.
6683         (linux_get_hwcap2): Likewise.
6684         * linux-tdep.h (linux_get_hwcap): Add declaration.
6685         (linux_get_hwcap2): Likewise.
6686         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6687         (ppc_linux_get_hwcap2): Likewise.
6688         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6689         linux_get_hwcap.
6690         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6691         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6692         (ppc_linux_nat_target::read_description): Likewise.
6693         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6694         * s390-linux-nat.c: Likewise.
6695         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6696
6697 2019-03-24  Tom Tromey  <tom@tromey.com>
6698
6699         * ada-lang.c (standard_lookup): Simplify initialization.
6700         (ada_lookup_symbol_nonlocal): Simplify return.
6701         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6702         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6703         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6704         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6705         initialization.
6706         * solib.c (solib_global_lookup): Simplify.
6707         * symtab.c (null_block_symbol): Remove.
6708         (symbol_cache_lookup): Simplify returns.
6709         (lookup_language_this): Simplify returns.
6710         (lookup_symbol_aux): Simplify return.
6711         (lookup_local_symbol): Simplify returns.
6712         (lookup_global_symbol_from_objfile): Simplify return.
6713         (lookup_symbol_in_objfile_symtabs)
6714         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6715         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6716         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6717         * cp-namespace.c (cp_lookup_bare_symbol)
6718         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6719         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6720         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6721         (cp_lookup_symbol_via_imports): Simplify initialization.
6722         (find_symbol_in_baseclass): Likewise.
6723         * symtab.h (null_block_symbol): Remove.
6724         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6725         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6726         (d_lookup_symbol_module): Likewise.
6727         (find_symbol_in_baseclass): Simplify initialization.
6728
6729 2019-03-24  Tom Tromey  <tom@tromey.com>
6730
6731         * expression.h: Don't include symtab.h.
6732         (struct block): Forward declare.
6733
6734 2019-03-24  Tom Tromey  <tom@tromey.com>
6735
6736         * c-exp.y (typebase): Remove casts.
6737         * gdbtypes.c (lookup_unsigned_typename, )
6738         (lookup_signed_typename): Remove cast.
6739         * eval.c (parse_to_comma_and_eval): Remove cast.
6740         * parse.c (write_dollar_variable): Remove cast.
6741         * block.h (struct block) <superblock>: Now const.
6742         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6743         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6744         (map_block): Make "block" const.
6745         * symfile.h (struct quick_symbol_functions)
6746         <map_matching_symbols>: Constify block argument to "callback".
6747         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6748         const.
6749         (find_pc_sect_compunit_symtab): Make "b" const.
6750         (find_symbol_at_address): Likewise.
6751         (search_symbols): Likewise.
6752         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6753         (dw2_debug_names_lookup_symbol): Likewise.
6754         (dw2_map_matching_symbols): Update.
6755         * p-valprint.c (pascal_val_print): Remove "block".
6756         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6757         (aux_add_nonlocal_symbols): Make "block" const.
6758         (resolve_subexp): Remove cast.
6759         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6760         const.
6761         (iterate_over_file_blocks): Likewise.
6762         * f-exp.y (%union) <bval>: Remove.
6763         * coffread.c (patch_opaque_types): Make "b" const.
6764         * spu-tdep.c (spu_catch_start): Make "block" const.
6765         * c-valprint.c (print_unpacked_pointer): Remove "block".
6766         * symmisc.c (dump_symtab_1): Make "b" const.
6767         (block_depth): Make "block" const.
6768         * d-exp.y (%union) <bval>: Remove.
6769         * cp-support.h (cp_lookup_rtti_type): Update.
6770         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6771         * psymtab.c (psym_lookup_symbol): Make "block" const.
6772         (maintenance_check_psymtabs): Make "b" const.
6773         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6774         (enumerate_locals, enumerate_args): Update.
6775         * python/py-symtab.c (stpy_global_block): Make "block" const.
6776         (stpy_static_block): Likewise.
6777         * inline-frame.c (block_starting_point_at): Make "new_block"
6778         const.
6779         * block.c (find_block_in_blockvector): Make return type const.
6780         (blockvector_for_pc_sect): Make "b" const.
6781         (find_block_in_blockvector): Make "b" const.
6782
6783 2019-03-23  Tom Tromey  <tom@tromey.com>
6784
6785         * varobj.c (varobj_create): Update.
6786         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6787         * printcmd.c (display_command, do_one_display): Don't reset
6788         innermost_block.
6789         * parser-defs.h (enum innermost_block_tracker_type): Move to
6790         expression.h.
6791         (innermost_block): Update comment.
6792         * parse.c (parse_exp_1): Add tracker_types parameter.
6793         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6794         tracker_types parameter.  Reset innermost_block.
6795         (parse_exp_in_context): Remove.
6796         (parse_expression_for_completion): Update.
6797         * objfiles.c (~objfile): Don't reset expression_context_block or
6798         innermost_block.
6799         * expression.h (enum innermost_block_tracker_type): Move from
6800         parser-defs.h.
6801         (parse_exp_1): Add tracker_types parameter.
6802         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6803         reset innermost_block.
6804
6805 2019-03-23  Tom Tromey  <tom@tromey.com>
6806
6807         * objfiles.h: Include bcache.h.
6808
6809 2019-03-23  Tom Tromey  <tom@tromey.com>
6810
6811         * linespec.c (get_current_search_block): Use
6812         scoped_restore_current_language.
6813         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6814
6815 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6816             Jiong Wang  <jiong.wang@arm.com>
6817
6818         * aarch64-linux-tdep.c
6819         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6820         section.
6821         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6822
6823 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6824             Jiong Wang  <jiong.wang@arm.com>
6825
6826         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6827         instructions.
6828         (aarch64_analyze_prologue_test): Add PACIASP test.
6829         (aarch64_prologue_prev_register): Unmask PC value.
6830
6831 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6832             Jiong Wang  <jiong.wang@arm.com>
6833
6834         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6835         (aarch64_dwarf2_prev_register): Unmask PC value.
6836         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6837         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6838         DW_CFA_AARCH64_negate_ra_state.
6839         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6840
6841 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6842             Jiong Wang  <jiong.wang@arm.com>
6843
6844         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6845         registers.
6846         (aarch64_pseudo_register_name): Likewise.
6847         (aarch64_pseudo_register_type): Likewise.
6848         (aarch64_pseudo_register_reggroup_p): Likewise.
6849         (aarch64_gdbarch_init): Add pauth registers.
6850         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6851         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6852         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6853         (struct gdbarch_tdep): Add regnum for ra_state.
6854
6855 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6856             Jiong Wang  <jiong.wang@arm.com>
6857
6858         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6859
6860 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6861             Jiong Wang  <jiong.wang@arm.com>
6862
6863         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6864         function.
6865         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6866         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6867         (aarch64_gdbarch_init): Add puth registers.
6868         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6869         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6870         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6871
6872 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6873             Jiong Wang  <jiong.wang@arm.com>
6874
6875         * aarch64-linux-nat.c
6876         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6877         * aarch64-linux-tdep.c
6878         (aarch64_linux_core_read_description): Likewise.
6879         (aarch64_linux_get_hwcap): New function.
6880         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6881         (aarch64_linux_get_hwcap): New declaration.
6882
6883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6884             Jiong Wang  <jiong.wang@arm.com>
6885
6886         * aarch64-linux-nat.c
6887         (aarch64_linux_nat_target::read_description): Add pauth param.
6888         * aarch64-linux-tdep.c
6889         (aarch64_linux_core_read_description): Likewise.
6890         * aarch64-tdep.c (struct target_desc): Add in pauth.
6891         (aarch64_read_description): Add pauth param.
6892         (aarch64_gdbarch_init): Likewise.
6893         * aarch64-tdep.h (aarch64_read_description): Likewise.
6894         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6895         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6896         * features/Makefile: Add new files.
6897         * features/aarch64-pauth.c: New file.
6898         * features/aarch64-pauth.xml: New file.
6899
6900 2019-03-20  Tom Tromey  <tromey@adacore.com>
6901
6902         * infrun.c (handle_inferior_event): Rename from
6903         handle_inferior_event_1.  Create a scoped_value_mark.
6904         (handle_inferior_event): Remove.
6905
6906 2019-03-19  Tom Tromey  <tromey@adacore.com>
6907
6908         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6909         * infrun.h (print_stop_event): Add "displays" parameter.
6910         * infrun.c (print_stop_event): Add "displays" parameter.
6911
6912 2019-03-19  Pedro Alves  <palves@redhat.com>
6913
6914         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6915         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6916         to -1.  Fix TABs vs spaces.
6917         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6918         * tui/tui-out.h (tui_ui_out) Add intro comments.
6919         <m_line, m_start_of_line>: In-class initialize, and add describing
6920         comment.
6921
6922 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6923
6924         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6925         variable names.
6926         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6927
6928 2019-03-18  Pedro Alves  <palves@redhat.com>
6929             Eli Zaretskii <eliz@gnu.org>
6930
6931         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6932         m_line and m_start_of_line.
6933
6934 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6935
6936         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6937         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6938         it returns a newline.  This fixes a regression in TU mode, whereby
6939         the next line is output on the same screen line as the user input.
6940
6941 2019-03-18  Tom Tromey  <tromey@adacore.com>
6942
6943         * minsyms.c (minimal_symbol_reader::install): Remove call to
6944         obstack_blank.
6945
6946 2019-03-18  Pedro Alves  <palves@redhat.com>
6947
6948         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6949         New globals.
6950         (apply_style): New, factored out from ...
6951         (apply_ansi_escape): ... this.  Handle reverse video mode.
6952         (tui_set_reverse_mode): New function.
6953         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6954         * tui/tui-winsource.c (tui_show_source_line): Use
6955         tui_set_reverse_mode instead of setting A_STANDOUT.
6956         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6957         New setter methods.
6958
6959 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6960
6961         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6962         Handle tabs.
6963
6964 2019-03-18  Tom Tromey  <tromey@adacore.com>
6965
6966         * ada-lang.c (empty_array): Add "high" parameter.
6967         (ada_evaluate_subexp): Update.
6968
6969 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6970
6971         * unittests/string_view-selftests.c: Define
6972         _initialize_string_view_selftests unconditionally.
6973
6974 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6975
6976         PR gdb/24350
6977         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6978
6979 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6980
6981         PR gdb/24351
6982         * windows-nat.c (display_selector): Fix format specifiers.
6983
6984 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6985
6986         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6987         tui_refill_source_window instead of tui_refresh_win, to update the
6988         current execution line.  This fixes redisplay of the current line
6989         when stepping through the code with "next" or "step".
6990
6991 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6992
6993         * source-cache.c (source_cache::get_source_lines): Call
6994         find_source_lines to initialize s->nlines.  This fixes vertical
6995         scrolling of TUI source window when the DOWN arrow is pressed.
6996
6997 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6998
6999         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7000         linux-thread-db.c (_initialize_thread_db): Likewise.
7001
7002 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7003
7004         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7005         wclrtoeol in tui_show_source_line".  This reverts changes made in
7006         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7007
7008 2019-03-15  Tom Tromey  <tom@tromey.com>
7009
7010         * symtab.h (struct minimal_symbol): Derive from
7011         general_symbol_info.
7012         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7013         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7014         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7015         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7016         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7017         (MSYMBOL_SEARCH_NAME): Update.
7018         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7019         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7020         * minsyms.c (minimal_symbol_reader::record_full): Update.
7021
7022 2019-03-15  Tom Tromey  <tom@tromey.com>
7023
7024         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7025
7026 2019-03-15  Tom Tromey  <tom@tromey.com>
7027
7028         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7029         unique_xmalloc_ptr.
7030         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7031         Update.
7032         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7033         (build_minimal_symbol_hash_tables)
7034         (minimal_symbol_reader::install): Update.
7035
7036 2019-03-15  Tom Tromey  <tom@tromey.com>
7037
7038         * symtab.c (create_demangled_names_hash): Update.
7039         (symbol_set_names): Update.
7040         * objfiles.h (struct objfile_per_bfd_storage)
7041         <demangled_names_hash>: Now an htab_up.
7042         * objfiles.c (objfile_per_bfd_storage): Simplify.
7043
7044 2019-03-15  Tom Tromey  <tom@tromey.com>
7045
7046         * objfiles.h (struct objfile_per_bfd_storage): Declare
7047         destructor.
7048         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7049         New.
7050         (get_objfile_bfd_data): Use new.  Don't initialize
7051         language_of_main.
7052         (free_objfile_per_bfd_storage): Remove.
7053         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7054
7055 2019-03-15  Tom Tromey  <tom@tromey.com>
7056
7057         * symfile.c (reread_symbols): Update.
7058         * objfiles.c (objfile::objfile): Update.
7059         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7060         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7061         comment.
7062         (minimal_symbol_reader::install): Update.
7063         (terminate_minimal_symbol_table): Remove.
7064         * jit.c (jit_object_close_impl): Update.
7065
7066 2019-03-15  Tom Tromey  <tom@tromey.com>
7067
7068         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7069         initializations.
7070
7071 2019-03-15  Tom Tromey  <tom@tromey.com>
7072
7073         * objfiles.h (struct objfile_per_bfd_storage)
7074         <demangled_hash_languages>: Now a bitset.
7075         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7076         (lookup_minimal_symbol): Update.
7077
7078 2019-03-15  Tom Tromey  <tom@tromey.com>
7079
7080         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7081         Don't return the symbol.
7082         * coffread.c (record_minimal_symbol): Use record_full.
7083
7084 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7085
7086         The MS-Windows port of ncurses fails to switch to a color pair if
7087         one or both of the colors are the implicit default colors.  This
7088         change records the default colors when TUI is initialized, and
7089         then specifies them explicitly when a color pair uses the default
7090         colors.  This allows color styling in TUI mode on MS-Windows.
7091
7092         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7093         ncurses_norm_attr.
7094         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7095         colors in ncurses_norm_attr.
7096         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7097         "none", replace it with the default color recorded in
7098         ncurses_norm_attr.
7099
7100 2019-03-14  Tom Tromey  <tromey@adacore.com>
7101
7102         * source-cache.h (class source_cache) <get_source_lines>: Return
7103         std::string.
7104         * source-cache.c (source_cache::extract_lines): Handle case where
7105         first_pos==npos.  Return std::string.
7106         (source_cache::get_source_lines): Update.
7107
7108 2019-03-14  Tom Tromey  <tromey@adacore.com>
7109
7110         * NEWS: Add item for "style sources" commands.
7111         * source-cache.c (source_cache::get_source_lines): Check
7112         source_styling.
7113         * cli/cli-style.c (source_styling): New global.
7114         (_initialize_cli_style): Add "style sources" commands.
7115         (show_style_sources): New function.
7116         * cli/cli-style.h (source_styling): Declare.
7117
7118 2019-03-14  Pedro Alves  <palves@redhat.com>
7119             Tom Tromey  <tromey@adacore.com>
7120
7121         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7122         * tui/tui-winsource.c (tui_refill_source_window): New function,
7123         from...
7124         (tui_horizontal_source_scroll): ... here.  Move some logic.
7125         * cli/cli-style.c (set_style_enabled): Notify new observable.
7126         * tui/tui-hooks.c (tui_redisplay_source): New function.
7127         (tui_attach_detach_observers): Attach or detach
7128         tui_redisplay_source.
7129         * observable.h (source_styling_changed): New observable.
7130         * observable.c: Define source_styling_changed observable.
7131
7132 2019-03-13  Tom Tromey  <tromey@adacore.com>
7133
7134         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7135         (i386_gnu_nat_target::store_registers): Update.
7136         * target-debug.h (target_debug_print_std_string): New macro.
7137         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7138         * windows-tdep.c (display_one_tib): Update.
7139         * tui/tui-stack.c (tui_make_status_line): Update.
7140         * top.c (print_inferior_quit_action): Update.
7141         * thread.c (thr_try_catch_cmd): Update.
7142         (add_thread_with_info): Update.
7143         (thread_target_id_str): Update.
7144         (thr_try_catch_cmd): Update.
7145         (thread_command): Update.
7146         (thread_find_command): Update.
7147         * record-btrace.c (record_btrace_target::info_record)
7148         (record_btrace_resume_thread, record_btrace_target::resume)
7149         (record_btrace_cancel_resume, record_btrace_step_thread)
7150         (record_btrace_target::wait, record_btrace_target::wait)
7151         (record_btrace_target::wait, record_btrace_target::stop): Update.
7152         * progspace.c (print_program_space): Update.
7153         * process-stratum-target.c
7154         (process_stratum_target::thread_address_space): Update.
7155         * linux-fork.c (linux_fork_mourn_inferior)
7156         (detach_checkpoint_command, info_checkpoints_command)
7157         (linux_fork_context): Update.
7158         (linux_fork_detach): Update.
7159         (class scoped_switch_fork_info): Update.
7160         (delete_checkpoint_command): Update.
7161         * infrun.c (follow_fork_inferior): Update.
7162         (follow_fork_inferior): Update.
7163         (proceed_after_vfork_done): Update.
7164         (handle_vfork_child_exec_or_exit): Update.
7165         (follow_exec): Update.
7166         (displaced_step_prepare_throw): Update.
7167         (displaced_step_restore): Update.
7168         (start_step_over): Update.
7169         (resume_1): Update.
7170         (clear_proceed_status_thread): Update.
7171         (proceed): Update.
7172         (print_target_wait_results): Update.
7173         (do_target_wait): Update.
7174         (context_switch): Update.
7175         (stop_all_threads): Update.
7176         (restart_threads): Update.
7177         (finish_step_over): Update.
7178         (handle_signal_stop): Update.
7179         (switch_back_to_stepped_thread): Update.
7180         (keep_going_pass_signal): Update.
7181         (print_exited_reason): Update.
7182         (normal_stop): Update.
7183         * inferior.c (inferior_pid_to_str): Change return type.
7184         (print_selected_inferior): Update.
7185         (add_inferior): Update.
7186         (detach_inferior): Update.
7187         * dummy-frame.c (fprint_dummy_frames): Update.
7188         * dcache.c (dcache_info_1): Update.
7189         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7190         (btrace_fetch, btrace_clear): Update.
7191         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7192         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7193         type.
7194         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7195         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7196         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7197         * gdbarch.c, gdbarch.h: Rebuild.
7198         * gdbarch.sh (core_pid_to_str): Change return type.
7199         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7200         return type.
7201         (windows_nat_target::pid_to_str): Change return type.
7202         (windows_delete_thread): Update.
7203         (windows_nat_target::attach): Update.
7204         (windows_nat_target::files_info): Update.
7205         * target-delegates.c: Rebuild.
7206         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7207         return type.
7208         (sol_thread_target::pid_to_str): Change return type.
7209         * remote.c (class remote_target) <pid_to_str>: Change return
7210         type.
7211         (remote_target::pid_to_str): Change return type.
7212         (extended_remote_target::attach, remote_target::remote_stop_ns)
7213         (remote_target::remote_notif_remove_queued_reply)
7214         (remote_target::push_stop_reply, remote_target::disable_btrace):
7215         Update.
7216         (extended_remote_target::attach): Update.
7217         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7218         type.
7219         (gdbsim_target::pid_to_str): Change return type.
7220         * ravenscar-thread.c (struct ravenscar_thread_target)
7221         <pid_to_str>: Change return type.
7222         (ravenscar_thread_target::pid_to_str): Change return type.
7223         * procfs.c (class procfs_target) <pid_to_str>: Change return
7224         type.
7225         (procfs_target::pid_to_str): Change return type.
7226         (procfs_target::attach): Update.
7227         (procfs_target::detach): Update.
7228         (procfs_target::fetch_registers): Update.
7229         (procfs_target::store_registers): Update.
7230         (procfs_target::wait): Update.
7231         (procfs_target::files_info): Update.
7232         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7233         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7234         return type.
7235         (nto_procfs_target::pid_to_str): Change return type.
7236         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7237         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7238         return type.
7239         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7240         (exit_lwp): Update.
7241         (attach_proc_task_lwp_callback, get_detach_signal)
7242         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7243         (linux_nat_target::resume, wait_lwp, stop_callback)
7244         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7245         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7246         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7247         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7248         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7249         type.
7250         (inf_ptrace_target::attach): Update.
7251         (inf_ptrace_target::files_info): Update.
7252         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7253         type.
7254         (go32_nat_target::pid_to_str): Change return type.
7255         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7256         (gnu_nat_target::wait): Update.
7257         (gnu_nat_target::wait): Update.
7258         (gnu_nat_target::resume): Update.
7259         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7260         (fbsd_nat_target::wait): Update.
7261         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7262         type.
7263         (darwin_nat_target::attach): Update.
7264         * corelow.c (class core_target) <pid_to_str>: Change return type.
7265         (core_target::pid_to_str): Change return type.
7266         * target.c (normal_pid_to_str): Change return type.
7267         (default_pid_to_str): Likewise.
7268         (target_pid_to_str): Change return type.
7269         (target_translate_tls_address): Update.
7270         (target_announce_detach): Update.
7271         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7272         return type.
7273         (bsd_uthread_target::pid_to_str): Change return type.
7274         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7275         type.
7276         (bsd_kvm_target::pid_to_str): Change return type.
7277         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7278         return type.
7279         (aix_thread_target::pid_to_str): Change return type.
7280         * target.h (struct target_ops) <pid_to_str>: Change return type.
7281         (target_pid_to_str, normal_pid_to_str): Likewise.
7282         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7283         type.
7284         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7285         type.
7286         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7287         return type.
7288         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7289         type.
7290         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7291         type.
7292         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7293         return type.
7294
7295 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7296
7297         * NEWS: Mention that the new default MI version is 3.  Mention
7298         changes to the output of commands and events that deal with
7299         multi-location breakpoints.
7300         * breakpoint.c: Include "mi/mi-out.h".
7301         (print_one_breakpoint): Change output syntax if using MI version
7302         >= 3.
7303         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7304         New.
7305         (mi_multi_location_breakpoint_output_fixed): New.
7306         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7307         (mi_cmd_fix_multi_location_breakpoint_output): New.
7308         (mi_multi_location_breakpoint_output_fixed): New.
7309         * mi/mi-cmds.c (mi_cmds): Register command
7310         -fix-multi-location-breakpoint-output.
7311         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7312         interpreter "mi".
7313
7314 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7315
7316         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7317         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7318         instantiate mi_ui_out based on interpreter name.
7319         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7320         * mi/mi-main.c (mi_load_progress): Likewise.
7321
7322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7323
7324         * NEWS: Combine separate "New targets" sections for 8.3.
7325
7326 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7327
7328         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7329         (ppcfbsd_init_abi): Install gdbarch
7330         "fetch_tls_load_module_address" and "get_thread_local_address"
7331         methods.
7332
7333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7334
7335         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7336         (riscv_fbsd_init_abi): Install gdbarch
7337         "fetch_tls_load_module_address" and "get_thread_local_address"
7338         methods.
7339
7340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7341
7342         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7343         (i386fbsd_init_abi): Install gdbarch
7344         "fetch_tls_load_module_address" and "get_thread_local_address"
7345         methods.
7346
7347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7348
7349         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7350         (amd64fbsd_init_abi): Install gdbarch
7351         "fetch_tls_load_module_address" and "get_thread_local_address"
7352         methods.
7353
7354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7355
7356         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7357         (struct fbsd_pspace_data): New type.
7358         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7359         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7360         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7361         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7362         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7363
7364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7365
7366         * gdbtypes.c (lookup_struct_elt): New function.
7367         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7368         * gdbtypes.h (struct struct_elt): New type.
7369         (lookup_struct_elt): New prototype.
7370
7371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7372
7373         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7374         remove disabled code block.
7375
7376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7377
7378         * gdbarch.sh (get_thread_local_address): New method.
7379         * gdbarch.h, gdbarch.c: Regenerate.
7380         * target.c (target_translate_tls_address): Use
7381         gdbarch_get_thread_local_address if present instead of
7382         target::get_thread_local_address.
7383
7384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7385
7386         * target.h (target::get_thread_local_address): Update comment.
7387
7388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7389
7390         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7391         objfile->separate_debug_objfile_backlink if not NULL.
7392
7393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7394
7395         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7396         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7397         (amd64bsd_store_inferior_registers): Likewise.
7398         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7399         Enable segment base registers.
7400         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7401         PT_GETFSBASE and PT_GETGSBASE.
7402         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7403         PT_SETGSBASE.
7404         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7405         segment base registers.
7406         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7407
7408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7409
7410         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7411         Update calls to i386_target_description to add 'segments'
7412         parameter.
7413         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7414         add segment base registers.
7415         * arch/i386.c (i386_create_target_description): Add 'segments'
7416         parameter to enable segment base registers.
7417         * arch/i386.h (i386_create_target_description): Likewise.
7418         * features/i386/32bit-segments.xml: New file.
7419         * features/i386/32bit-segments.c: Generate.
7420         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7421         call to i386_target_description to add 'segments' parameter.
7422         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7423         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7424         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7425         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7426         if feature is present.
7427         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7428         Add 'segments' parameter to call to i386_target_description.
7429         (i386_target_description): Add 'segments' parameter to enable
7430         segment base registers.
7431         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7432         to call to i386_target_description.
7433         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7434         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7435         Define I386_NUM_REGS.
7436         (i386_target_description): Add 'segments' parameter to enable
7437         segment base registers.
7438
7439 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7440
7441         PR/24325
7442         * source-cache.c: #undef open and close, to avoid unresolved
7443         externals during linking.
7444
7445 2019-03-12  Tom Tromey  <tromey@adacore.com>
7446
7447         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7448         const.  Add initializers.
7449         (_initialize_remote): Don't initialize ptid globals.
7450
7451 2019-03-12  Pedro Alves  <palves@redhat.com>
7452
7453         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7454
7455 2019-03-12  Pedro Alves  <palves@redhat.com>
7456
7457         * cp-name-parser.y (main): Remove unused 'len' variable.
7458
7459 2019-03-12  Tom Tromey  <tromey@adacore.com>
7460
7461         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7462         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7463
7464 2019-03-12  Tom Tromey  <tromey@adacore.com>
7465
7466         * linux-nat.c (iterate_over_lwps): Update.
7467         (stop_callback): Remove parameter.
7468         (stop_wait_callback, detach_callback, resume_set_callback)
7469         (select_singlestep_lwp_callback, set_ignore_sigint)
7470         (status_callback, resumed_callback, resume_clear_callback)
7471         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7472         data parameter.
7473         (linux_nat_target::detach, linux_nat_target::resume)
7474         (linux_stop_and_wait_all_lwps, select_event_lwp)
7475         (linux_nat_filter_event, linux_nat_wait_1)
7476         (linux_nat_target::kill, linux_nat_target::stop)
7477         (linux_nat_target::stop): Update.
7478         (linux_nat_resume_callback): Change type.
7479         (resume_stopped_resumed_lwps, count_events_callback)
7480         (select_event_lwp_callback): Likewise.
7481         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7482         * arm-linux-nat.c (struct update_registers_data): Remove.
7483         (update_registers_callback): Change type.
7484         (arm_linux_insert_hw_breakpoint1): Update.
7485         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7486         parameter.
7487         (x86_linux_dr_set_addr): Update.
7488         (x86_linux_dr_set_control): Update.
7489         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7490         (iterate_over_lwps): Use gdb::function_view.
7491         * nat/aarch64-linux-hw-point.c (struct
7492         aarch64_dr_update_callback_param): Remove.
7493         (debug_reg_change_callback): Change type.
7494         (aarch64_notify_debug_reg_change): Update.
7495         * s390-linux-nat.c (s390_refresh_per_info): Update.
7496
7497 2019-03-11  Tom Tromey  <tromey@adacore.com>
7498
7499         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7500         redundant assignment to "this_cu".
7501
7502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7503
7504         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7505
7506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7507
7508         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7509         from...
7510         (rank_one_type): ... this.
7511
7512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7513
7514         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7515         from...
7516         (rank_one_type): ... this.
7517
7518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7519
7520         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7521         from...
7522         (rank_one_type): ... this.
7523
7524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7525
7526         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7527         from...
7528         (rank_one_type): ... this.
7529
7530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7531
7532         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7533         from...
7534         (rank_one_type): ... this.
7535
7536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7537
7538         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7539         from...
7540         (rank_one_type): ... this.
7541
7542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7543
7544         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7545         from...
7546         (rank_one_type): ... this.
7547
7548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7549
7550         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7551         from...
7552         (rank_one_type): ... this.
7553
7554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7555
7556         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7557         from...
7558         (rank_one_type): ... this.
7559
7560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7561
7562         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7563         from...
7564         (rank_one_type): ... this.
7565
7566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7567
7568         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7569         from...
7570         (rank_one_type): ... this.
7571
7572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7573
7574         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7575         from...
7576         (rank_one_type): ... this.
7577
7578 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7579
7580         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7581         inferior-events' shows the example events.
7582
7583 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7584
7585         Support styling on native MS-Windows console
7586
7587         PR/24315
7588         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7589         on MS-Windows if $TERM is not defined.
7590
7591         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7592
7593         * posix-hdep.c (gdb_console_fputs):
7594         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7595         functions.
7596         * ui-file.h (gdb_console_fputs): Add prototype.
7597
7598         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7599         back to fputs only if the former returns zero.
7600
7601 2019-03-07  Tom Tromey  <tom@tromey.com>
7602
7603         * symmisc.c (print_symbol_bcache_statistics): Update.
7604         (print_objfile_statistics): Update.
7605         * symfile.c (allocate_symtab): Update.
7606         * stabsread.c: Don't include bcache.h.
7607         * psymtab.h (struct psymbol_bcache): Don't declare.
7608         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7609         (psymbol_bcache_init, psymbol_bcache_free)
7610         (psymbol_bcache_get_bcache): Don't declare.
7611         * psymtab.c (struct psymbol_bcache): Remove.
7612         (psymtab_storage::psymtab_storage): Update.
7613         (psymtab_storage::~psymtab_storage): Update.
7614         (psymbol_bcache_init, psymbol_bcache_free)
7615         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7616         (add_psymbol_to_bcache): Update.
7617         (allocate_psymtab): Update.
7618         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7619         macro_cache>: No longer pointers.
7620         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7621         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7622         * macrotab.c (macro_bcache): Update.
7623         * macroexp.c: Don't include bcache.h.
7624         * gdbtypes.c (check_types_worklist): Update.
7625         (types_deeply_equal): Remove TRY/CATCH.  Update.
7626         * elfread.c (elf_symtab_read): Update.
7627         * dwarf2read.c: Don't include bcache.h.
7628         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7629         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7630         (print_bcache_statistics, bcache_memory_used): Don't declare.
7631         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7632         methods.  Rename all data members.
7633         * bcache.c (struct bcache): Move to bcache.h.
7634         (bcache::expand_hash_table): Rename from expand_hash_table.
7635         (bcache): Remove.
7636         (bcache::insert): Rename from bcache_full.
7637         (bcache::compare): Rename from bcache_compare.
7638         (bcache_xmalloc): Remove.
7639         (bcache::~bcache): Rename from bcache_xfree.
7640         (bcache::print_statistics): Rename from print_bcache_statistics.
7641         (bcache::memory_used): Rename from bcache_memory_used.
7642
7643 2019-03-07  Pedro Alves  <palves@redhat.com>
7644
7645         * infrun.c (normal_stop): Also check for
7646         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7647
7648 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7649
7650         * f-lang.c (value_from_host_double): Moved to...
7651         * value.c (value_from_host_double): ...here.
7652         * value.h (value_from_host_double): Declare.
7653         * guile/scm-math.c (vlscm_convert_typed_number): Use
7654         value_from_host_double.
7655         (vlscm_convert_number): Likewise.
7656         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7657         * python/py-value.c (convert_value_from_python): Likewise.
7658
7659 2019-03-06  Tom Tromey  <tom@tromey.com>
7660
7661         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7662
7663 2019-03-06  Tom Tromey  <tom@tromey.com>
7664
7665         * utils.h (free_current_contents): Don't declare.
7666         * utils.c (free_current_contents): Remove.
7667
7668 2019-03-06  Tom Tromey  <tom@tromey.com>
7669
7670         * top.c (quit_force): Update.
7671         * main.c (captured_command_loop): Update.
7672         * common/new-op.c (operator new): Update.
7673         * common/common-exceptions.c (struct catcher)
7674         <save_cleanup_chain>: Remove member.
7675         (exceptions_state_mc_init): Update.
7676         (exception_try_scope_entry): Return nullptr.
7677         (exception_try_scope_exit, exception_rethrow)
7678         (throw_exception_sjlj, throw_exception_cxx): Update.
7679         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7680         (all_cleanups, do_cleanups, discard_cleanups)
7681         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7682         (restore_cleanups, restore_final_cleanups): Don't declare.
7683         (do_final_cleanups): Remove parameter.
7684         * common/cleanups.c (cleanup_chain, make_cleanup)
7685         (make_cleanup_dtor, all_cleanups, do_cleanups)
7686         (discard_my_cleanups, discard_cleanups)
7687         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7688         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7689         (null_cleanup): Remove.
7690         (do_final_cleanups): Remove parameter.
7691
7692 2019-03-06  Tom Tromey  <tom@tromey.com>
7693
7694         * remote.c (remote_target::remote_parse_stop_reply): Use
7695         unique_xmalloc_ptr.
7696
7697 2019-03-06  Tom Tromey  <tom@tromey.com>
7698
7699         * stabsread.c (struct stabs_field_info): Rename from field_info.
7700         <list, fnlist>: Add initializers.
7701         <obstack>: New member.
7702         (read_member_functions, read_struct_fields, read_baseclasses):
7703         Allocate on obstack.  Don't use cleanups.
7704         (read_one_struct_field, read_member_functions, read_struct_fields)
7705         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7706         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7707         (read_struct_type): Update.
7708
7709 2019-03-06  Tom Tromey  <tom@tromey.com>
7710
7711         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7712         * common/filestuff.h (make_cleanup_close): Don't declare.
7713         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7714         Remove.
7715
7716 2019-03-06  Tom Tromey  <tom@tromey.com>
7717
7718         * solib-aix.c: Use make_scope_exit.
7719
7720 2019-03-06  Tom Tromey  <tom@tromey.com>
7721
7722         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7723         Use make_scope_exit.
7724
7725 2019-03-06  Tom Tromey  <tom@tromey.com>
7726
7727         * solib-svr4.c (disable_probes_interface): Remove parameter.
7728         (svr4_handle_solib_event): Use make_scope_exit.
7729
7730 2019-03-06  Tom Tromey  <tom@tromey.com>
7731
7732         * remote.c (struct stop_reply_deleter): Remove.
7733         (stop_reply_up): Update.
7734         (struct stop_reply): Derive from notif_event.  Don't typedef.
7735         <regcache>: Now a std::vector.
7736         (stop_reply_xfree): Remove.
7737         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7738         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7739         (remote_target::discard_pending_stop_replies): Use delete.
7740         (remote_target::remote_parse_stop_reply): Update.
7741         (remote_target::process_stop_reply): Update.
7742         * remote-notif.h (struct notif_event): Add virtual destructor.
7743         Remove "dtr" member.
7744         (struct notif_client) <alloc_event>: Return a unique_ptr.
7745         (notif_event_xfree): Don't declare.
7746         (notif_event_up): New typedef.
7747         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7748         (notif_event_xfree, do_notif_event_xfree): Remove.
7749         (remote_notif_state_xfree): Update.
7750
7751 2019-03-06  Tom Tromey  <tom@tromey.com>
7752
7753         * infrun.c (displaced_step_clear_cleanup): Now a
7754         forward_scope_exit type.
7755         (displaced_step_prepare_throw): Update.
7756         (displaced_step_fixup): Update.
7757
7758 2019-03-06  Tom Tromey  <tom@tromey.com>
7759
7760         * inferior.h (class inferior): Update comment.
7761         * gdbthread.h (class thread_info): Update comment.
7762
7763 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7764             Tom Tromey  <tom@tromey.com>
7765
7766         * stabsread.h (struct stab_section_list): Remove.
7767         (coffstab_build_psymtabs): Update.
7768         * dbxread.c (symbuf_sections): Now a std::vector.
7769         (sect_idx): New global.
7770         (fill_symbuf): Update.
7771         (coffstab_build_psymtabs): Change type of stabsects parameter.
7772         Update.
7773         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7774         std::vector.
7775         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7776         (coff_locate_sections): Update.
7777         (coff_symfile_read): Remove cleanups.  Update.
7778         (init_stringtab): Add storage parameter.
7779         (free_stringtab, free_stringtab_cleanup): Remove.
7780         (init_lineno): Add storage parameter.
7781         (free_linetab, free_linetab_cleanup): Remove.
7782
7783 2019-03-06  Pedro Alves  <palves@redhat.com>
7784
7785         * linux-fork.c (fork_info::clobber_regs): Delete.
7786         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7787         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7788         comment.  Adjust.
7789         (scoped_switch_fork_info::scoped_switch_fork_info)
7790         (checkpoint_command, linux_fork_context): Adjust
7791         fork_save_infrun_state calls.
7792
7793 2019-03-06  Pedro Alves  <palves@redhat.com>
7794
7795         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7796         (inf_has_multiple_threads): Return 'bool' and rewrite using
7797         inferior_info::threads().
7798
7799 2019-03-06  Pedro Alves  <palves@redhat.com>
7800
7801         * linux-fork.c: Include <list>.
7802         (fork_list): Now a std::list instance.
7803         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7804         (forks_exist_p, find_last_fork): Adjust.
7805         (new_fork): Delete.
7806         (one_fork_p): New.
7807         (add_fork): Adjust.
7808         (free_fork): Delete, folded into fork_info::~fork_info().
7809         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7810         Adjust.
7811         (init_fork_list): Delete.
7812         (linux_fork_killall, linux_fork_mourn_inferior)
7813         (linux_fork_detach, info_checkpoints_command): Adjust.
7814         (_initialize_linux_fork): No longer call init_fork_list.
7815
7816 2019-03-06  Pedro Alves  <palves@redhat.com>
7817
7818         * linux-fork.c (new_fork): New, split out of ...
7819         (add_fork): ... this.  Return void.  Move "first fork" special
7820         case from here, to ...
7821         (checkpoint_command): ... here.
7822         * linux-linux.h (add_fork): Return void.
7823
7824 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7827
7828 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7829             Chris January  <chris.january@arm.com>
7830             David Lecomber  <david.lecomber@arm.com>
7831
7832         * f-exp.y: New token, UNOP_INTRINSIC.
7833         (exp): New pattern using UNOP_INTRINSIC token.
7834         (f77_keywords): Add 'abs' keyword.
7835         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7836         (value_from_host_double): New function.
7837         (evaluate_subexp_f): Support UNOP_ABS.
7838
7839 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7840
7841         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7842         types.
7843
7844 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7845
7846         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7847         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7848         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7849
7850 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7851
7852         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7853
7854 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7855             Chris January  <chris.january@arm.com>
7856
7857         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7858         * f-exp.y: Define 'KIND' token.
7859         (exp): New pattern for KIND expressions.
7860         (ptype): Handle types with a kind extension.
7861         (direct_abs_decl): Extend to spot kind extensions.
7862         (f77_keywords): Add 'kind' to the list.
7863         (push_kind_type): New function.
7864         (convert_to_kind_type): New function.
7865         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7866         * parse.c (operator_length_standard): Likewise.
7867         * parser-defs.h (enum type_pieces): Add tp_kind.
7868         * std-operator.def: Add UNOP_KIND.
7869
7870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7871
7872         * f-exp.y (f_parse): Set yydebug.
7873
7874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7875
7876         * f-lang.c (evaluate_subexp_f): New function.
7877         (exp_descriptor_f): New global.
7878         (f_language_defn): Use exp_descriptor_f instead of
7879         exp_descriptor_standard.
7880
7881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7882
7883         * f-exp.y (struct token): Add comments.
7884         (dot_ops): Remove uppercase versions and the end marker.
7885         (f77_keywords): Likewise.
7886         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7887         entries in the dot_ops array are case insensitive, and use
7888         strncasecmp to compare strings.  Also some whitespace cleanup in
7889         this area.  Similar for the f77_keywords array, except entries in
7890         this list might be case sensitive.
7891
7892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7893
7894         * f-exp.y (struct f77_boolean_val): Add comments.
7895         (boolean_values): Remove uppercase versions, and end marker.
7896         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7897         and use strncasecmp to achieve case insensitivity.  Additionally,
7898         perform whitespace cleanup around this code.
7899
7900 2019-03-06  Tom Tromey  <tromey@adacore.com>
7901
7902         * remote-sim.c (gdbsim_target_open): Use result of
7903         gdb_argv::release.
7904
7905 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7906         Dirk Schubert  <dirk.schubert@arm.com>
7907         Chris January  <chris.january@arm.com>
7908
7909         * eval.c (evaluate_subexp_standard): Call Fortran argument
7910         wrapping logic.
7911         * f-lang.c (struct value): A value which can be passed into a
7912         Fortran function call.
7913         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7914         where appropriate.
7915         (struct type): Value ready for a Fortran function call.
7916         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7917         is needed.
7918         * f-lang.h (fortran_argument_convert): Declaration.
7919         (fortran_preserve_arg_pointer): Declaration.
7920         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7921
7922 2019-03-05  Tom Tromey  <tromey@adacore.com>
7923
7924         * python/py-prettyprint.c (print_string_repr): Remove #if.
7925         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7926
7927 2019-03-05  Tom Tromey  <tromey@adacore.com>
7928
7929         * target.c (the_dummy_target): Move later.  Change type to
7930         "dummy_target".
7931         (initialize_targets): Don't initialize the_dummy_target.
7932
7933 2019-03-05  Tom Tromey  <tromey@adacore.com>
7934
7935         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7936         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7937
7938 2019-03-05  Tom Tromey  <tromey@adacore.com>
7939
7940         * windows-nat.c (windows_nat_target::attach)
7941         (windows_nat_target::detach): Don't call gdb_flush.
7942         * valprint.c (generic_val_print, val_print, val_print_string):
7943         Don't call gdb_flush.
7944         * utils.c (defaulted_query): Don't call gdb_flush.
7945         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7946         * target.c (target_announce_detach): Don't call gdb_flush.
7947         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7948         * remote.c (extended_remote_target::attach): Don't call
7949         gdb_flush.
7950         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7951         * printcmd.c (do_examine): Don't call gdb_flush.
7952         (info_display_command): Don't call gdb_flush.
7953         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7954         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7955         * memattr.c (info_mem_command): Don't call gdb_flush.
7956         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7957         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7958         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7959         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7960         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7961         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7962         (gnu_nat_target::detach): Don't call gdb_flush.
7963         * f-valprint.c (f_val_print): Don't call gdb_flush.
7964         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7965         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7966         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7967         gdb_flush.
7968         * c-valprint.c (c_val_print): Don't call gdb_flush.
7969         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7970
7971 2019-03-05  Tom Tromey  <tromey@adacore.com>
7972
7973         * varobj.c (update_dynamic_varobj_children): Update.
7974         (install_default_visualizer): Use reset, not release.
7975         * value.c (set_internalvar): Update.
7976         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7977         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7978         ATTRIBUTE_UNUSED_RESULT.
7979
7980 2019-03-05  Tom Tromey  <tromey@adacore.com>
7981
7982         * remote.c (class scoped_remote_fd) <release>: Add
7983         ATTRIBUTE_UNUSED_RESULT.
7984
7985 2019-03-05  Tom Tromey  <tromey@adacore.com>
7986
7987         * macroexp.c (struct macro_buffer) <release>: Add
7988         ATTRIBUTE_UNUSED_RESULT.
7989
7990 2019-03-05  Tom Tromey  <tromey@adacore.com>
7991
7992         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7993         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7994         ATTRIBUTE_UNUSED_RESULT.
7995
7996 2019-03-05  Tom Tromey  <tromey@adacore.com>
7997
7998         * common/scoped_fd.h (class scoped_fd) <release>: Add
7999         ATTRIBUTE_UNUSED_RESULT.
8000
8001 2019-03-05  Tom Tromey  <tromey@adacore.com>
8002
8003         * parser-defs.h (struct parser_state) <release>: Add
8004         ATTRIBUTE_UNUSED_RESULT.
8005
8006 2019-03-05  Tom Tromey  <tromey@adacore.com>
8007
8008         * utils.h (class gdb_argv) <release>: Add
8009         ATTRIBUTE_UNUSED_RESULT.
8010         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8011
8012 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8013
8014         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8015         for-loop range, to avoid compiler warnings.
8016
8017         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8018         avoid compiler warnings about unused variables.
8019
8020         * NEWS: Mention end of support for native debugging on MS-Windows
8021         before XP.
8022
8023         PR gdb/24292
8024         * common/netstuff.c:
8025         * gdbserver/gdbreplay.c
8026         * gdbserver/remote-utils.c:
8027         * ser-tcp.c:
8028         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8029         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8030         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8031         'getaddrinfo' and 'freeaddrinfo' were not available before
8032         Windows XP, and mingw.org's MinGW headers by default define
8033         _WIN32_WINNT to 0x500.
8034
8035 2019-03-01  Gary Benson <gbenson@redhat.com>
8036
8037         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8038
8039 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8040             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8041
8042         PR gdb/8527
8043         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8044         set_sigint_trap, clear_sigint_trap.
8045
8046 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8047
8048         * target.c (target_detach): Clear the regcache and the
8049         frame cache.
8050
8051 2019-02-27  Pedro Alves  <palves@redhat.com>
8052
8053         * utils.c (set_screen_size): When we cap the height/width sizes,
8054         tweak the corresponding command variable to show "unlimited":
8055
8056 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8057             Pedro Alves  <palves@redhat.com>
8058
8059         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8060         before calling rl_set_screen_size.
8061
8062 2019-02-27  Tom Tromey  <tromey@adacore.com>
8063
8064         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8065         define.
8066         * python/py-value.c: Remove Python 2.4 workaround.
8067         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8068         workaround.
8069         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8070         Python 2.4 workaround.
8071         * python/python-internal.h: Remove Python 2.4 comment.
8072         (Py_ssize_t): Don't define.
8073         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8074         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8075         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8076         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8077         * python/python.c (do_start_initialization): Remove Python 2.4
8078         workaround.
8079         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8080         (print_children): Remove Python 2.4 workaround.
8081         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8082         workaround.
8083         (CHARBUFFERPROC_NAME): Remove.
8084         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8085         Python 2.4 workaround.
8086
8087 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8088
8089         * NEWS: Note minimum Python version.
8090
8091 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8092
8093         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8094         code from these functions.  Remove corresponding ifdefs.  Use
8095         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8096         Remove gotos and target of gotos.
8097         (infpy_search_memory): Likewise.
8098
8099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8100
8101         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8102         (hppa_gdbarch_init): Don't register deleted functions with
8103         gdbarch.
8104
8105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8108         (h8300_unwind_sp): Delete.
8109         (h8300_dummy_id): Delete.
8110         (h8300_gdbarch_init): Don't register deleted functions with
8111         gdbarch.
8112
8113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8114
8115         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8116         (ft32_unwind_pc): Delete.
8117         (ft32_unwind_sp): Delete.
8118         (ft32_gdbarch_init): Don't register deleted functions with
8119         gdbarch.
8120
8121 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8122
8123         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8124         (frv_unwind_pc): Delete.
8125         (frv_unwind_sp): Delete.
8126         (frv_gdbarch_init): Don't register deleted functions with
8127         gdbarch.
8128
8129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8132         (riscv_unwind_pc): Delete.
8133         (riscv_unwind_sp): Delete.
8134         (riscv_gdbarch_init): Don't register deleted functions with
8135         gdbarch.
8136
8137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8138
8139         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8140         (csky_unwind_pc): Delete.
8141         (csky_unwind_sp): Delete.
8142         (csky_gdbarch_init): Don't register deleted functions with
8143         gdbarch.
8144
8145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8146
8147         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8148         (cris_unwind_pc): Delete.
8149         (cris_unwind_sp): Delete.
8150         (cris_gdbarch_init): Don't register deleted functions with
8151         gdbarch.
8152
8153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8154
8155         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8156         (bfin_unwind_pc): Delete.
8157         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8158
8159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8160
8161         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8162         (arm_unwind_pc): Delete.
8163         (arm_unwind_sp): Delete.
8164         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8165
8166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8167
8168         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8169         (arc_unwind_pc): Delete.
8170         (arc_unwind_sp): Delete.
8171         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8172
8173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8174
8175         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8176         (alpha_unwind_pc): Delete.
8177         (alpha_gdbarch_init): Don't register deleted functions with
8178         gdbarch.
8179
8180 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8181
8182         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8183         (aarch64_unwind_pc): Delete.
8184         (aarch64_unwind_sp): Delete.
8185         (aarch64_gdbarch_init): Don't register deleted functions with
8186         gdbarch.
8187
8188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8189
8190         * gdbtypes.c (type_align): Don't consider static members when
8191         computing structure alignment.
8192
8193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8196         return 0 for other types.
8197         * arch-utils.c (default_type_align): Always return 0.
8198         * gdbarch.h: Regenerate.
8199         * gdbarch.sh (type_align): Extend comment.
8200         * gdbtypes.c (type_align): Add additional comments, always call
8201         gdbarch_type_align before applying the default rules.
8202         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8203         generic code will then apply a suitable default.
8204         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8205         types, return 0 for other types.
8206
8207 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8208
8209         * NEWS: Create a new section for the next release branch.
8210         Rename the section of the current branch, now that it has
8211         been cut.
8212
8213 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8214
8215         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8216         * version.in: Bump version to 8.3.50.DATE-git.
8217
8218 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8219
8220         * aix-thread.c (ptid_cmp): Remove unused variable.
8221         (get_signaled_thread): Likewise.
8222         (store_regs_user_thread): Likewise.
8223         (store_regs_kernel_thread): Likewise.
8224         (fetch_regs_kernel_thread): Remove shadowed variable.
8225
8226 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8227
8228         * features/riscv/32bit-cpu.xml: Add register numbers.
8229         * features/riscv/32bit-fpu.c: Regenerate.
8230         * features/riscv/32bit-fpu.xml: Add register numbers.
8231         * features/riscv/64bit-cpu.xml: Add register numbers.
8232         * features/riscv/64bit-fpu.c: Regenerate.
8233         * features/riscv/64bit-fpu.xml: Add register numbers.
8234
8235 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8236
8237         * NEWS: Mention two argument form of gdb.Value constructor.
8238         * python/py-value.c (convert_buffer_and_type_to_value): New
8239         function.
8240         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8241         Add support for handling an optional second argument.  Call
8242         convert_buffer_and_type_to_value as appropriate.
8243         * python/python-internal.h (Py_buffer_deleter): New struct.
8244         (Py_buffer_up): New typedef.
8245
8246 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8247
8248         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8249         instead of releasing ownership.
8250
8251 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8252
8253         * dwarf2read.c (open_and_init_dwp_file): Call
8254         elf_numsections instead of bfd_count_sections to initialize
8255         dwp_file->num_sections.
8256
8257 2019-02-25  Tom Tromey  <tromey@adacore.com>
8258
8259         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8260
8261 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8262
8263         * gcore.in: Add '--readnever' option when invoking GDB.
8264
8265 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8266
8267         * MAINTAINERS: Update my email address.
8268
8269 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8270
8271         * build-id.c (build_id_to_debug_bfd_1): New function.
8272         (build_id_to_debug_bfd): Look for separate debug file in
8273         sysroot.
8274
8275 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8276
8277         * gdbarch.sh: Update the copyright year range that is placed into
8278         generated files.
8279
8280 2019-02-22  Keith Seitz  <keiths@redhat.com>
8281
8282         PR symtab/23853
8283         * linespec.c (create_sals_line_offset): Search for the default
8284         symtab's filename instead of its fullname.
8285
8286 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8287
8288         * NEWS: Update style defaults.
8289
8290 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8291
8292         * main.c (captured_main_1): Disable styling in batch mode.
8293
8294 2019-02-20  Tom Tromey  <tom@tromey.com>
8295
8296         * symtab.c (symtab_symbol_info): Fix typos.
8297
8298 2019-02-20  Tom Tromey  <tromey@adacore.com>
8299
8300         * findcmd.c (_initialize_mem_search): Use upper case for
8301         metasyntactic variables.
8302
8303 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8304
8305         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8306         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8307
8308 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8309
8310         * top.h (source_file_name): Change to std::string.
8311         * top.c (source_file_name): Likewise.
8312         (command_line_input): Adjust.
8313         * cli/cli-script.c (script_from_file): Adjust.
8314
8315 2019-02-19  Tom Tromey  <tromey@adacore.com>
8316
8317         * ravenscar-thread.c
8318         (ravenscar_thread_target::update_thread_list): Don't call
8319         ada_build_task_list.
8320         * ada-lang.h (ada_build_task_list): Don't declare.
8321         * ada-tasks.c (struct ada_tasks_inferior_data)
8322         <task_list_valid_p>: Now bool.
8323         (read_known_tasks, ada_task_list_changed)
8324         (ada_tasks_invalidate_inferior_data): Update.
8325         (read_known_tasks_array): Return bool.
8326         (read_known_tasks_list): Likewise.
8327         (read_known_tasks): Return void.
8328         (ada_build_task_list): Now static.
8329
8330 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8331
8332         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8333         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8334
8335 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8336
8337         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8338         variant for ada_tasks_pspace_data_handle and
8339         ada_tasks_inferior_data_handle.
8340         (ada_tasks_pspace_data_cleanup): New function.
8341         (ada_tasks_inferior_data_cleanup): New function.
8342
8343 2019-02-17  Tom Tromey  <tom@tromey.com>
8344
8345         * macrotab.h (macro_source_fullname): Return a std::string.
8346         * macrotab.c (macro_include, check_for_redefinition)
8347         (macro_undef, macro_lookup_definition, foreach_macro)
8348         (foreach_macro_in_scope): Update.
8349         (macro_source_fullname): Return a std::string.
8350         * macrocmd.c (show_pp_source_pos): Update.
8351
8352 2019-02-17  Tom Tromey  <tom@tromey.com>
8353
8354         * macrocmd.c (show_pp_source_pos): Style the file names.
8355
8356 2019-02-17  Tom Tromey  <tom@tromey.com>
8357
8358         PR tui/24197:
8359         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8360
8361 2019-02-17  Tom Tromey  <tom@tromey.com>
8362
8363         * ada-lang.c (user_select_syms): Use filtered printing.
8364         * utils.c (wrap_style): New global.
8365         (desired_style): Remove.
8366         (emit_style_escape): Add stream parameter.
8367         (set_output_style, reset_terminal_style, prompt_for_continue):
8368         Update.
8369         (flush_wrap_buffer): Only flush gdb_stdout.
8370         (wrap_here): Set wrap_style.
8371         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8372         treat escape sequences as a character.  Change when wrap buffer is
8373         flushed.
8374         (fputs_styled): Do not set the output style when the default is
8375         requested.
8376         * ui-style.h (struct ui_file_style) <is_default>: New method.
8377         * source.c (print_source_lines_base): Emit escape sequences in one
8378         piece.
8379
8380 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8381
8382         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8383         integers and enumeration types.
8384
8385 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8386
8387         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8388         instead of lookup_symbol_in_language
8389         (do_exact_match): New function.
8390         (ada_get_symbol_name_matcher): Return do_exact_match when
8391         doing a verbatim match.
8392
8393 2019-02-15  Tom Tromey  <tromey@adacore.com>
8394
8395         * ravenscar-thread.c (ravenscar_thread_target::resume)
8396         (ravenscar_thread_target::wait): Special case wildcard requests.
8397
8398 2019-02-15  Tom Tromey  <tromey@adacore.com>
8399
8400         * ravenscar-thread.c (base_ptid): Remove.
8401         (struct ravenscar_thread_target) <close>: New method.
8402         <m_base_ptid>: New member.
8403         <update_inferior_ptid, active_task, task_is_currently_active,
8404         runtime_initialized>: Declare methods.
8405         <ravenscar_thread_target>: Add constructor.
8406         (ravenscar_thread_target::task_is_currently_active)
8407         (ravenscar_thread_target::update_inferior_ptid)
8408         (ravenscar_runtime_initialized): Rename.  Now methods.
8409         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8410         (ravenscar_thread_target::update_thread_list): Update.
8411         (ravenscar_thread_target::active_task): Now method.
8412         (ravenscar_thread_target::store_registers)
8413         (ravenscar_thread_target::prepare_to_store)
8414         (ravenscar_thread_target::prepare_to_store)
8415         (ravenscar_thread_target::mourn_inferior): Update.
8416         (ravenscar_inferior_created): Use "new" to create target.
8417         (ravenscar_thread_target::get_ada_task_ptid): Update.
8418         (_initialize_ravenscar): Don't initialize base_ptid.
8419         (ravenscar_ops): Remove global.
8420
8421 2019-02-15  Tom Tromey  <tromey@adacore.com>
8422
8423         * target.h (push_target): Declare new overload.
8424         * target.c (push_target): New overload, taking an rvalue reference.
8425         * remote.c (remote_target::open_1): Use push_target overload.
8426         * corelow.c (core_target_open): Use push_target overload.
8427
8428 2019-02-15  Tom Tromey  <tromey@adacore.com>
8429
8430         * ravenscar-thread.c (is_ravenscar_task)
8431         (ravenscar_task_is_currently_active): Return bool.
8432         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8433         (_initialize_ravenscar): Remove "(void)".
8434         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8435         Return bool.
8436
8437 2019-02-15  Tom Tromey  <tromey@adacore.com>
8438
8439         * ravenscar-thread.c (ravenscar_runtime_initializer)
8440         (has_ravenscar_runtime, get_running_thread_id)
8441         (ravenscar_thread_target::resume): Fix indentation.
8442
8443 2019-02-15  Tom Tromey  <tromey@adacore.com>
8444
8445         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8446         from ravenscar_arch_ops.
8447         (sparc_ravenscar_ops::fetch_registers)
8448         (sparc_ravenscar_ops::store_registers): Now methods.
8449         (sparc_ravenscar_prepare_to_store): Remove.
8450         (sparc_ravenscar_ops): Redefine.
8451         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8452         methods and destructor.  Remove members.
8453         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8454         (ravenscar_thread_target::store_registers)
8455         (ravenscar_thread_target::prepare_to_store): Update.
8456         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8457         Remove.
8458         (struct ppc_ravenscar_powerpc_ops): Derive from
8459         ravenscar_arch_ops.
8460         (ppc_ravenscar_powerpc_ops::fetch_registers)
8461         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8462         (ppc_ravenscar_powerpc_ops): Redefine.
8463         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8464         (ppc_ravenscar_e500_ops::fetch_registers)
8465         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8466         (ppc_ravenscar_e500_ops): Redefine.
8467         * aarch64-ravenscar-thread.c
8468         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8469         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8470         (aarch64_ravenscar_fetch_registers)
8471         (aarch64_ravenscar_store_registers): Now methods.
8472         (aarch64_ravenscar_ops): Redefine.
8473
8474 2019-02-15  Tom Tromey  <tromey@adacore.com>
8475
8476         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8477         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8478         (ravenscar_thread_target::stopped_by_watchpoint)
8479         (ravenscar_thread_target::stopped_data_address)
8480         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8481
8482 2019-02-15  Tom Tromey  <tromey@adacore.com>
8483
8484         * ravenscar-thread.c: Fix some typos.
8485
8486 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8487             Tom Tromey  <tromey@adacore.com>
8488
8489         * ada-lang.c (ada_exception_sal): Change addr_string to a
8490         std::string.
8491         (create_ada_exception_catchpoint): Update.
8492
8493 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8494             Tom Tromey  <tromey@adacore.com>
8495
8496         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8497         (bp_location_ops): Remove.
8498         (base_breakpoint_allocate_location): Update.
8499         (free_bp_location): Update.
8500         * ada-lang.c (class ada_catchpoint_location)
8501         <ada_catchpoint_location>: Remove ops parameter.
8502         (ada_catchpoint_location_dtor): Remove.
8503         (ada_catchpoint_location_ops): Remove.
8504         (allocate_location_exception): Update.
8505         * breakpoint.h (struct bp_location_ops): Remove.
8506         (class bp_location) <bp_location>: Remove bp_location_ops
8507         parameter.
8508         <~bp_location>: Add destructor.
8509         <ops>: Remove.
8510
8511 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8512             Pedro Alves  <palves@redhat.com>
8513
8514         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8515         'PATH_MAX'.
8516
8517 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8518             Samuel Thibault  <samuel.thibault@gnu.org>
8519             Thomas Schwinge  <thomas@codesourcery.com>
8520
8521         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8522         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8523
8524 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8525
8526         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8527         (check_empty): Use "const char *".
8528
8529         * gnu-nat.c (gnu_nat_target::detach): Instead of
8530         'detach_inferior (pid)' call
8531         'detach_inferior (find_inferior_pid (pid))'.
8532
8533         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8534         'nat/fork-inferior.o'.
8535         * gnu-nat.c: #include "nat/fork-inferior.h".
8536
8537         * gnu-nat.c (gnu_nat_target::detach): Instead of
8538         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8539         * gnu-nat.h: #include "inf-child.h".
8540         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8541         'i386_gnu_nat_target::fetch_registers'.
8542         (gnu_store_registers): Rename/move to
8543         'i386_gnu_nat_target::store_registers'.
8544
8545         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8546         * gnu-nat.h (mach_thread_info): New function.
8547         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8548
8549         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8550
8551 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8552
8553         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8554
8555 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8556
8557         * windows-nat.c (windows_add_thread): Add new parameter
8558         "main_thread_p" with default value set to false.  Update
8559         function documentation as well as all callers.
8560         (windows_delete_thread): Likewise.
8561         (fake_create_process): Update call to windows_add_thread.
8562         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8563         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8564         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8565         call to windows_delete_thread.
8566
8567 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8568
8569         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8570
8571 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8572
8573         * symfile.c (find_separate_debug_file): Use canonical path of
8574         sysroot with child_path instead of gdb_sysroot if it is valid.
8575
8576 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8577
8578         * symfile.c (find_separate_debug_file): Use child_path to
8579         determine if an object file is under a sysroot.
8580
8581 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8582
8583         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8584         unittests/child-path-selftests.c.
8585         * common/pathstuff.c (child_path): New function.
8586         * common/pathstuff.h (child_path): New prototype.
8587         * unittests/child-path-selftests.c: New file.
8588
8589 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8590
8591         * symfile.c (find_separate_debug_file): Look for separate debug
8592         files in debug directories under the sysroot.
8593
8594 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8595
8596         * symtab.h (struct minimal_symbol data_p): New const method.
8597         (struct minimal_symbol text_p): Likewise.
8598         * symtab.c (output_source_filename): Use file name style
8599         to print file name.
8600         (print_symbol_info): Likewise.
8601         (print_msymbol_info): Use address style to print addresses.
8602         Use function name style to print executable text symbols.
8603         (expand_symtab_containing_pc): Use data_p.
8604         (find_pc_sect_compunit_symtab): Likewise.
8605
8606 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8607
8608         * breakpoint.c (describe_other_breakpoints): Use address style
8609         to print addresses.
8610         (say_where): Likewise.
8611
8612 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8613
8614         * ada-typeprint.c (print_func_type): Print function name
8615         style to print function name.
8616         * c-typeprint.c (c_print_type_1): Likewise.
8617
8618 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8619
8620         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8621         for execve.
8622
8623 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8624
8625         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8626         type_stack.
8627
8628 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8629
8630         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8631         TYPE_CODE_REF types.
8632
8633 2019-02-08  Jim Wilson  <jimw@sifive.com>
8634
8635         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8636         (riscv_linux_fregset): New.
8637         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8638
8639 2019-02-07  Tom Tromey  <tom@tromey.com>
8640
8641         * thread.c (thread_cancel_execution_command): Update.
8642         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8643         methods.
8644         (struct thread_fsm_ops): Remove.
8645         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8646         (thread_fsm_should_stop, thread_fsm_return_value)
8647         (thread_fsm_set_finished, thread_fsm_finished_p)
8648         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8649         Don't declare.
8650         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8651         * infrun.c (clear_proceed_status_thread)
8652         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8653         (print_stop_event): Update.
8654         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8655         Add constructor.
8656         (step_command_fsm_ops): Remove.
8657         (new_step_command_fsm): Remove.
8658         (step_1): Update.
8659         (step_command_fsm::should_stop): Rename from
8660         step_command_fsm_should_stop.
8661         (step_command_fsm::clean_up): Rename from
8662         step_command_fsm_clean_up.
8663         (step_command_fsm::do_async_reply_reason): Rename from
8664         step_command_fsm_async_reply_reason.
8665         (struct until_next_fsm): Inherit from thread_fsm.  Add
8666         constructor.
8667         (until_next_fsm_ops): Remove.
8668         (new_until_next_fsm): Remove.
8669         (until_next_fsm::should_stop): Rename from
8670         until_next_fsm_should_stop.
8671         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8672         (until_next_fsm::do_async_reply_reason): Rename from
8673         until_next_fsm_async_reply_reason.
8674         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8675         constructor.  Change type of breakpoint.
8676         (finish_command_fsm_ops): Remove.
8677         (new_finish_command_fsm): Remove.
8678         (finish_command_fsm::should_stop): Rename from
8679         finish_command_fsm_should_stop.
8680         (finish_command_fsm::clean_up): Rename from
8681         finish_command_fsm_clean_up.
8682         (finish_command_fsm::return_value): Rename from
8683         finish_command_fsm_return_value.
8684         (finish_command_fsm::do_async_reply_reason): Rename from
8685         finish_command_fsm_async_reply_reason.
8686         (finish_command): Update.
8687         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8688         Add constructor.
8689         (call_thread_fsm_ops): Remove.
8690         (call_thread_fsm::call_thread_fsm): Rename from
8691         new_call_thread_fsm.
8692         (call_thread_fsm::should_stop): Rename from
8693         call_thread_fsm_should_stop.
8694         (call_thread_fsm::should_notify_stop): Rename from
8695         call_thread_fsm_should_notify_stop.
8696         (run_inferior_call, call_function_by_hand_dummy): Update.
8697         * cli/cli-interp.c (should_print_stop_to_console): Update.
8698         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8699         Add constructor.  Change type of location_breakpoint,
8700         caller_breakpoint.
8701         (until_break_fsm_ops): Remove.
8702         (new_until_break_fsm): Remove.
8703         (until_break_fsm::should_stop): Rename from
8704         until_break_fsm_should_stop.
8705         (until_break_fsm::clean_up): Rename from
8706         until_break_fsm_clean_up.
8707         (until_break_fsm::do_async_reply_reason): Rename from
8708         until_break_fsm_async_reply_reason.
8709         (until_break_command): Update.
8710         * thread-fsm.c: Remove.
8711         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8712
8713 2019-02-07  Tom Tromey  <tom@tromey.com>
8714
8715         * yy-remap.h: Add include guard.
8716         * xtensa-tdep.h: Add include guard.
8717         * xcoffread.h: Rename include guard.
8718         * varobj-iter.h: Add include guard.
8719         * tui/tui.h: Rename include guard.
8720         * tui/tui-winsource.h: Rename include guard.
8721         * tui/tui-wingeneral.h: Rename include guard.
8722         * tui/tui-windata.h: Rename include guard.
8723         * tui/tui-win.h: Rename include guard.
8724         * tui/tui-stack.h: Rename include guard.
8725         * tui/tui-source.h: Rename include guard.
8726         * tui/tui-regs.h: Rename include guard.
8727         * tui/tui-out.h: Rename include guard.
8728         * tui/tui-layout.h: Rename include guard.
8729         * tui/tui-io.h: Rename include guard.
8730         * tui/tui-hooks.h: Rename include guard.
8731         * tui/tui-file.h: Rename include guard.
8732         * tui/tui-disasm.h: Rename include guard.
8733         * tui/tui-data.h: Rename include guard.
8734         * tui/tui-command.h: Rename include guard.
8735         * tic6x-tdep.h: Add include guard.
8736         * target/waitstatus.h: Rename include guard.
8737         * target/wait.h: Rename include guard.
8738         * target/target.h: Rename include guard.
8739         * target/resume.h: Rename include guard.
8740         * target-float.h: Rename include guard.
8741         * stabsread.h: Add include guard.
8742         * rs6000-tdep.h: Add include guard.
8743         * riscv-fbsd-tdep.h: Add include guard.
8744         * regformats/regdef.h: Rename include guard.
8745         * record.h: Rename include guard.
8746         * python/python.h: Rename include guard.
8747         * python/python-internal.h: Rename include guard.
8748         * python/py-stopevent.h: Rename include guard.
8749         * python/py-ref.h: Rename include guard.
8750         * python/py-record.h: Rename include guard.
8751         * python/py-record-full.h: Rename include guard.
8752         * python/py-record-btrace.h: Rename include guard.
8753         * python/py-instruction.h: Rename include guard.
8754         * python/py-events.h: Rename include guard.
8755         * python/py-event.h: Rename include guard.
8756         * procfs.h: Add include guard.
8757         * proc-utils.h: Add include guard.
8758         * p-lang.h: Add include guard.
8759         * or1k-tdep.h: Rename include guard.
8760         * observable.h: Rename include guard.
8761         * nto-tdep.h: Rename include guard.
8762         * nat/x86-linux.h: Rename include guard.
8763         * nat/x86-linux-dregs.h: Rename include guard.
8764         * nat/x86-gcc-cpuid.h: Add include guard.
8765         * nat/x86-dregs.h: Rename include guard.
8766         * nat/x86-cpuid.h: Rename include guard.
8767         * nat/ppc-linux.h: Rename include guard.
8768         * nat/mips-linux-watch.h: Rename include guard.
8769         * nat/linux-waitpid.h: Rename include guard.
8770         * nat/linux-ptrace.h: Rename include guard.
8771         * nat/linux-procfs.h: Rename include guard.
8772         * nat/linux-osdata.h: Rename include guard.
8773         * nat/linux-nat.h: Rename include guard.
8774         * nat/linux-namespaces.h: Rename include guard.
8775         * nat/linux-btrace.h: Rename include guard.
8776         * nat/glibc_thread_db.h: Rename include guard.
8777         * nat/gdb_thread_db.h: Rename include guard.
8778         * nat/gdb_ptrace.h: Rename include guard.
8779         * nat/fork-inferior.h: Rename include guard.
8780         * nat/amd64-linux-siginfo.h: Rename include guard.
8781         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8782         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8783         * nat/aarch64-linux.h: Rename include guard.
8784         * nat/aarch64-linux-hw-point.h: Rename include guard.
8785         * mn10300-tdep.h: Add include guard.
8786         * mips-linux-tdep.h: Add include guard.
8787         * mi/mi-parse.h: Rename include guard.
8788         * mi/mi-out.h: Rename include guard.
8789         * mi/mi-main.h: Rename include guard.
8790         * mi/mi-interp.h: Rename include guard.
8791         * mi/mi-getopt.h: Rename include guard.
8792         * mi/mi-console.h: Rename include guard.
8793         * mi/mi-common.h: Rename include guard.
8794         * mi/mi-cmds.h: Rename include guard.
8795         * mi/mi-cmd-break.h: Rename include guard.
8796         * m2-lang.h: Add include guard.
8797         * location.h: Rename include guard.
8798         * linux-record.h: Rename include guard.
8799         * linux-nat.h: Add include guard.
8800         * linux-fork.h: Add include guard.
8801         * i386-darwin-tdep.h: Rename include guard.
8802         * hppa-linux-offsets.h: Add include guard.
8803         * guile/guile.h: Rename include guard.
8804         * guile/guile-internal.h: Rename include guard.
8805         * gnu-nat.h: Rename include guard.
8806         * gdb-stabs.h: Rename include guard.
8807         * frv-tdep.h: Add include guard.
8808         * f-lang.h: Add include guard.
8809         * event-loop.h: Add include guard.
8810         * darwin-nat.h: Rename include guard.
8811         * cp-abi.h: Rename include guard.
8812         * config/sparc/nm-sol2.h: Rename include guard.
8813         * config/nm-nto.h: Rename include guard.
8814         * config/nm-linux.h: Add include guard.
8815         * config/i386/nm-i386gnu.h: Rename include guard.
8816         * config/djgpp/nl_types.h: Rename include guard.
8817         * config/djgpp/langinfo.h: Rename include guard.
8818         * compile/gcc-cp-plugin.h: Add include guard.
8819         * compile/gcc-c-plugin.h: Add include guard.
8820         * compile/compile.h: Rename include guard.
8821         * compile/compile-object-run.h: Rename include guard.
8822         * compile/compile-object-load.h: Rename include guard.
8823         * compile/compile-internal.h: Rename include guard.
8824         * compile/compile-cplus.h: Rename include guard.
8825         * compile/compile-c.h: Rename include guard.
8826         * common/xml-utils.h: Rename include guard.
8827         * common/x86-xstate.h: Rename include guard.
8828         * common/version.h: Rename include guard.
8829         * common/vec.h: Rename include guard.
8830         * common/tdesc.h: Rename include guard.
8831         * common/selftest.h: Rename include guard.
8832         * common/scoped_restore.h: Rename include guard.
8833         * common/scoped_mmap.h: Rename include guard.
8834         * common/scoped_fd.h: Rename include guard.
8835         * common/safe-iterator.h: Rename include guard.
8836         * common/run-time-clock.h: Rename include guard.
8837         * common/refcounted-object.h: Rename include guard.
8838         * common/queue.h: Rename include guard.
8839         * common/ptid.h: Rename include guard.
8840         * common/print-utils.h: Rename include guard.
8841         * common/preprocessor.h: Rename include guard.
8842         * common/pathstuff.h: Rename include guard.
8843         * common/observable.h: Rename include guard.
8844         * common/netstuff.h: Rename include guard.
8845         * common/job-control.h: Rename include guard.
8846         * common/host-defs.h: Rename include guard.
8847         * common/gdb_wait.h: Rename include guard.
8848         * common/gdb_vecs.h: Rename include guard.
8849         * common/gdb_unlinker.h: Rename include guard.
8850         * common/gdb_unique_ptr.h: Rename include guard.
8851         * common/gdb_tilde_expand.h: Rename include guard.
8852         * common/gdb_sys_time.h: Rename include guard.
8853         * common/gdb_string_view.h: Rename include guard.
8854         * common/gdb_splay_tree.h: Rename include guard.
8855         * common/gdb_setjmp.h: Rename include guard.
8856         * common/gdb_ref_ptr.h: Rename include guard.
8857         * common/gdb_optional.h: Rename include guard.
8858         * common/gdb_locale.h: Rename include guard.
8859         * common/gdb_assert.h: Rename include guard.
8860         * common/filtered-iterator.h: Rename include guard.
8861         * common/filestuff.h: Rename include guard.
8862         * common/fileio.h: Rename include guard.
8863         * common/environ.h: Rename include guard.
8864         * common/common-utils.h: Rename include guard.
8865         * common/common-types.h: Rename include guard.
8866         * common/common-regcache.h: Rename include guard.
8867         * common/common-inferior.h: Rename include guard.
8868         * common/common-gdbthread.h: Rename include guard.
8869         * common/common-exceptions.h: Rename include guard.
8870         * common/common-defs.h: Rename include guard.
8871         * common/common-debug.h: Rename include guard.
8872         * common/cleanups.h: Rename include guard.
8873         * common/buffer.h: Rename include guard.
8874         * common/btrace-common.h: Rename include guard.
8875         * common/break-common.h: Rename include guard.
8876         * cli/cli-utils.h: Rename include guard.
8877         * cli/cli-style.h: Rename include guard.
8878         * cli/cli-setshow.h: Rename include guard.
8879         * cli/cli-script.h: Rename include guard.
8880         * cli/cli-interp.h: Rename include guard.
8881         * cli/cli-decode.h: Rename include guard.
8882         * cli/cli-cmds.h: Rename include guard.
8883         * charset-list.h: Add include guard.
8884         * buildsym-legacy.h: Rename include guard.
8885         * bfin-tdep.h: Add include guard.
8886         * ax.h: Rename include guard.
8887         * arm-linux-tdep.h: Add include guard.
8888         * arm-fbsd-tdep.h: Add include guard.
8889         * arch/xtensa.h: Rename include guard.
8890         * arch/tic6x.h: Add include guard.
8891         * arch/i386.h: Add include guard.
8892         * arch/arm.h: Rename include guard.
8893         * arch/arm-linux.h: Rename include guard.
8894         * arch/arm-get-next-pcs.h: Rename include guard.
8895         * arch/amd64.h: Add include guard.
8896         * arch/aarch64-insn.h: Rename include guard.
8897         * arch-utils.h: Rename include guard.
8898         * annotate.h: Add include guard.
8899         * amd64-darwin-tdep.h: Rename include guard.
8900         * aarch64-linux-tdep.h: Add include guard.
8901         * aarch64-fbsd-tdep.h: Add include guard.
8902         * aarch32-linux-nat.h: Add include guard.
8903
8904 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8905
8906         * macrotab.c (macro_define_internal): New function that
8907         factorizes macro_define_object_internal and macro_define_function
8908         code.
8909         (macro_define_object_internal): Use macro_define_internal.
8910         (macro_define_function): Likewise.
8911
8912 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8913
8914         * macrocmd.c (extract_identifier): Return
8915         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8916         callers.
8917
8918 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8919
8920         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8921
8922 2019-02-05  Tom Tromey  <tom@tromey.com>
8923
8924         * target.c (target_stack::unpush): Move assertion earlier.
8925
8926 2019-01-30  Tom Tromey  <tom@tromey.com>
8927
8928         PR python/23615:
8929         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8930         (gdbpy_parse_and_eval): Likewise.
8931         * python/python-internal.h (gdbpy_allow_threads): New class.
8932
8933 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8934
8935         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8936         (aarch64_fbsd_fpregmap): Move earlier.
8937         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8938         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8939         instead of individual calls to trad_frame_set_reg_addr.
8940         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8941         earlier.
8942         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8943         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8944         instead of individual calls to trad_frame_set_reg_addr.
8945
8946 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8947
8948         * CONTRIBUTE: Replace contribution list with wiki link.
8949
8950 2019-01-25  Tom Tromey  <tom@tromey.com>
8951
8952         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8953
8954 2019-01-25  Tom Tromey  <tom@tromey.com>
8955
8956         * xtensa-linux-nat.c: Fix common/ includes.
8957         * xml-support.h: Fix common/ includes.
8958         * xml-support.c: Fix common/ includes.
8959         * x86-linux-nat.c: Fix common/ includes.
8960         * windows-nat.c: Fix common/ includes.
8961         * varobj.h: Fix common/ includes.
8962         * varobj.c: Fix common/ includes.
8963         * value.c: Fix common/ includes.
8964         * valops.c: Fix common/ includes.
8965         * utils.c: Fix common/ includes.
8966         * unittests/xml-utils-selftests.c: Fix common/ includes.
8967         * unittests/utils-selftests.c: Fix common/ includes.
8968         * unittests/unpack-selftests.c: Fix common/ includes.
8969         * unittests/tracepoint-selftests.c: Fix common/ includes.
8970         * unittests/style-selftests.c: Fix common/ includes.
8971         * unittests/string_view-selftests.c: Fix common/ includes.
8972         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8973         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8974         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8975         * unittests/rsp-low-selftests.c: Fix common/ includes.
8976         * unittests/parse-connection-spec-selftests.c: Fix common/
8977         includes.
8978         * unittests/optional-selftests.c: Fix common/ includes.
8979         * unittests/offset-type-selftests.c: Fix common/ includes.
8980         * unittests/observable-selftests.c: Fix common/ includes.
8981         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8982         * unittests/memrange-selftests.c: Fix common/ includes.
8983         * unittests/memory-map-selftests.c: Fix common/ includes.
8984         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8985         * unittests/function-view-selftests.c: Fix common/ includes.
8986         * unittests/environ-selftests.c: Fix common/ includes.
8987         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8988         * unittests/common-utils-selftests.c: Fix common/ includes.
8989         * unittests/cli-utils-selftests.c: Fix common/ includes.
8990         * unittests/array-view-selftests.c: Fix common/ includes.
8991         * ui-file.c: Fix common/ includes.
8992         * tui/tui-io.c: Fix common/ includes.
8993         * tracepoint.h: Fix common/ includes.
8994         * tracepoint.c: Fix common/ includes.
8995         * tracefile-tfile.c: Fix common/ includes.
8996         * top.h: Fix common/ includes.
8997         * top.c: Fix common/ includes.
8998         * thread.c: Fix common/ includes.
8999         * target/waitstatus.h: Fix common/ includes.
9000         * target/waitstatus.c: Fix common/ includes.
9001         * target.h: Fix common/ includes.
9002         * target.c: Fix common/ includes.
9003         * target-memory.c: Fix common/ includes.
9004         * target-descriptions.c: Fix common/ includes.
9005         * symtab.h: Fix common/ includes.
9006         * symfile.c: Fix common/ includes.
9007         * stap-probe.c: Fix common/ includes.
9008         * spu-linux-nat.c: Fix common/ includes.
9009         * sparc-nat.c: Fix common/ includes.
9010         * source.c: Fix common/ includes.
9011         * solib.c: Fix common/ includes.
9012         * solib-target.c: Fix common/ includes.
9013         * ser-unix.c: Fix common/ includes.
9014         * ser-tcp.c: Fix common/ includes.
9015         * ser-pipe.c: Fix common/ includes.
9016         * ser-base.c: Fix common/ includes.
9017         * selftest-arch.c: Fix common/ includes.
9018         * s12z-tdep.c: Fix common/ includes.
9019         * rust-exp.y: Fix common/ includes.
9020         * rs6000-aix-tdep.c: Fix common/ includes.
9021         * riscv-tdep.c: Fix common/ includes.
9022         * remote.c: Fix common/ includes.
9023         * remote-notif.h: Fix common/ includes.
9024         * remote-fileio.h: Fix common/ includes.
9025         * remote-fileio.c: Fix common/ includes.
9026         * regcache.h: Fix common/ includes.
9027         * regcache.c: Fix common/ includes.
9028         * record-btrace.c: Fix common/ includes.
9029         * python/python.c: Fix common/ includes.
9030         * python/py-type.c: Fix common/ includes.
9031         * python/py-inferior.c: Fix common/ includes.
9032         * progspace.h: Fix common/ includes.
9033         * producer.c: Fix common/ includes.
9034         * procfs.c: Fix common/ includes.
9035         * proc-api.c: Fix common/ includes.
9036         * printcmd.c: Fix common/ includes.
9037         * ppc-linux-nat.c: Fix common/ includes.
9038         * parser-defs.h: Fix common/ includes.
9039         * osdata.c: Fix common/ includes.
9040         * obsd-nat.c: Fix common/ includes.
9041         * nat/x86-linux.c: Fix common/ includes.
9042         * nat/x86-linux-dregs.c: Fix common/ includes.
9043         * nat/x86-dregs.h: Fix common/ includes.
9044         * nat/x86-dregs.c: Fix common/ includes.
9045         * nat/ppc-linux.c: Fix common/ includes.
9046         * nat/mips-linux-watch.h: Fix common/ includes.
9047         * nat/mips-linux-watch.c: Fix common/ includes.
9048         * nat/linux-waitpid.c: Fix common/ includes.
9049         * nat/linux-ptrace.h: Fix common/ includes.
9050         * nat/linux-ptrace.c: Fix common/ includes.
9051         * nat/linux-procfs.c: Fix common/ includes.
9052         * nat/linux-personality.c: Fix common/ includes.
9053         * nat/linux-osdata.c: Fix common/ includes.
9054         * nat/linux-namespaces.c: Fix common/ includes.
9055         * nat/linux-btrace.h: Fix common/ includes.
9056         * nat/linux-btrace.c: Fix common/ includes.
9057         * nat/fork-inferior.c: Fix common/ includes.
9058         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9059         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9060         * nat/aarch64-linux.c: Fix common/ includes.
9061         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9062         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9063         * namespace.h: Fix common/ includes.
9064         * mips-linux-tdep.c: Fix common/ includes.
9065         * minsyms.c: Fix common/ includes.
9066         * mi/mi-parse.h: Fix common/ includes.
9067         * mi/mi-main.c: Fix common/ includes.
9068         * mi/mi-cmd-env.c: Fix common/ includes.
9069         * memrange.h: Fix common/ includes.
9070         * memattr.c: Fix common/ includes.
9071         * maint.h: Fix common/ includes.
9072         * maint.c: Fix common/ includes.
9073         * main.c: Fix common/ includes.
9074         * machoread.c: Fix common/ includes.
9075         * location.c: Fix common/ includes.
9076         * linux-thread-db.c: Fix common/ includes.
9077         * linux-nat.c: Fix common/ includes.
9078         * linux-fork.c: Fix common/ includes.
9079         * inline-frame.c: Fix common/ includes.
9080         * infrun.c: Fix common/ includes.
9081         * inflow.c: Fix common/ includes.
9082         * inferior.h: Fix common/ includes.
9083         * inferior.c: Fix common/ includes.
9084         * infcmd.c: Fix common/ includes.
9085         * inf-ptrace.c: Fix common/ includes.
9086         * inf-child.c: Fix common/ includes.
9087         * ia64-linux-nat.c: Fix common/ includes.
9088         * i387-tdep.c: Fix common/ includes.
9089         * i386-tdep.c: Fix common/ includes.
9090         * i386-linux-tdep.c: Fix common/ includes.
9091         * i386-linux-nat.c: Fix common/ includes.
9092         * i386-go32-tdep.c: Fix common/ includes.
9093         * i386-fbsd-tdep.c: Fix common/ includes.
9094         * i386-fbsd-nat.c: Fix common/ includes.
9095         * guile/scm-type.c: Fix common/ includes.
9096         * guile/guile.c: Fix common/ includes.
9097         * go32-nat.c: Fix common/ includes.
9098         * gnu-nat.c: Fix common/ includes.
9099         * gdbthread.h: Fix common/ includes.
9100         * gdbarch-selftests.c: Fix common/ includes.
9101         * gdb_usleep.c: Fix common/ includes.
9102         * gdb_select.h: Fix common/ includes.
9103         * gdb_bfd.c: Fix common/ includes.
9104         * gcore.c: Fix common/ includes.
9105         * fork-child.c: Fix common/ includes.
9106         * findvar.c: Fix common/ includes.
9107         * fbsd-nat.c: Fix common/ includes.
9108         * event-top.c: Fix common/ includes.
9109         * event-loop.c: Fix common/ includes.
9110         * dwarf2read.c: Fix common/ includes.
9111         * dwarf2loc.c: Fix common/ includes.
9112         * dwarf2-frame.c: Fix common/ includes.
9113         * dwarf-index-cache.c: Fix common/ includes.
9114         * dtrace-probe.c: Fix common/ includes.
9115         * disasm-selftests.c: Fix common/ includes.
9116         * defs.h: Fix common/ includes.
9117         * csky-tdep.c: Fix common/ includes.
9118         * cp-valprint.c: Fix common/ includes.
9119         * cp-support.h: Fix common/ includes.
9120         * cp-support.c: Fix common/ includes.
9121         * corelow.c: Fix common/ includes.
9122         * completer.h: Fix common/ includes.
9123         * completer.c: Fix common/ includes.
9124         * compile/compile.c: Fix common/ includes.
9125         * compile/compile-loc2c.c: Fix common/ includes.
9126         * compile/compile-cplus-types.c: Fix common/ includes.
9127         * compile/compile-cplus-symbols.c: Fix common/ includes.
9128         * command.h: Fix common/ includes.
9129         * cli/cli-dump.c: Fix common/ includes.
9130         * cli/cli-cmds.c: Fix common/ includes.
9131         * charset.c: Fix common/ includes.
9132         * build-id.c: Fix common/ includes.
9133         * btrace.h: Fix common/ includes.
9134         * btrace.c: Fix common/ includes.
9135         * breakpoint.h: Fix common/ includes.
9136         * breakpoint.c: Fix common/ includes.
9137         * ax.h:
9138         (enum agent_op): Fix common/ includes.
9139         * ax-general.c (struct aop_map): Fix common/ includes.
9140         * ax-gdb.c: Fix common/ includes.
9141         * auxv.c: Fix common/ includes.
9142         * auto-load.c: Fix common/ includes.
9143         * arm-tdep.c: Fix common/ includes.
9144         * arch/riscv.c: Fix common/ includes.
9145         * arch/ppc-linux-common.c: Fix common/ includes.
9146         * arch/i386.c: Fix common/ includes.
9147         * arch/arm.c: Fix common/ includes.
9148         * arch/arm-linux.c: Fix common/ includes.
9149         * arch/arm-get-next-pcs.c: Fix common/ includes.
9150         * arch/amd64.c: Fix common/ includes.
9151         * arch/aarch64.c: Fix common/ includes.
9152         * arch/aarch64-insn.c: Fix common/ includes.
9153         * arch-utils.c: Fix common/ includes.
9154         * amd64-windows-tdep.c: Fix common/ includes.
9155         * amd64-tdep.c: Fix common/ includes.
9156         * amd64-sol2-tdep.c: Fix common/ includes.
9157         * amd64-obsd-tdep.c: Fix common/ includes.
9158         * amd64-nbsd-tdep.c: Fix common/ includes.
9159         * amd64-linux-tdep.c: Fix common/ includes.
9160         * amd64-linux-nat.c: Fix common/ includes.
9161         * amd64-fbsd-tdep.c: Fix common/ includes.
9162         * amd64-fbsd-nat.c: Fix common/ includes.
9163         * amd64-dicos-tdep.c: Fix common/ includes.
9164         * amd64-darwin-tdep.c: Fix common/ includes.
9165         * agent.c: Fix common/ includes.
9166         * ada-lang.h: Fix common/ includes.
9167         * ada-lang.c: Fix common/ includes.
9168         * aarch64-tdep.c: Fix common/ includes.
9169
9170 2019-01-25  Tom Tromey  <tom@tromey.com>
9171
9172         * common/create-version.sh: Use common/version.h.
9173
9174 2019-01-24  Pedro Alves  <palves@redhat.com>
9175
9176         * infrun.c (signal_stop, signal_print, signal_program)
9177         (signal_catch, signal_pass): Now arrays instead of pointers.
9178         (update_signals_program_target, do_target_resume)
9179         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9180         * linux-nat.c (linux_nat_target::pass_signals)
9181         (linux_nat_target::create_inferior, linux_nat_target::attach):
9182         Adjust.
9183         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9184         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9185         * procfs.c (procfs_target::pass_signals): Adjust.
9186         * record-full.c (record_full_target::resume): Adjust.
9187         * remote.c (remote_target::pass_signals)
9188         (remote_target::program_signals): Adjust.
9189         * target-debug.h (target_debug_print_signals): Now takes a
9190         gdb::array_view as parameter.  Adjust.
9191         * target.h (target_ops) <pass_signals, program_signals>: Replace
9192         pointer and length parameters with gdb::array_view.
9193         (target_pass_signals, target_program_signals): Likewise.
9194         * target-delegates.c: Regenerate.
9195
9196 2019-01-24  Pedro Alves  <palves@redhat.com>
9197
9198         * common/forward-scope-exit.h
9199         (forward_scope_exit::forward_scope_exit): Pass arguments to
9200         m_bind_function directly, instead of creating a std::bind and
9201         copying that.
9202
9203 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9204
9205         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9206         for static members.
9207         (pass_in_v_vfp_candidate): Likewise.
9208
9209 2019-01-23  Tom Tromey  <tom@tromey.com>
9210             Pedro Alves  <palves@redhat.com>
9211
9212         * regcache.c (class regcache_invalidator): Remove.
9213         (regcache::raw_write): Use make_scope_exit.
9214
9215 2019-01-23  Tom Tromey  <tom@tromey.com>
9216
9217         * ui-out.h (class ui_out_emit_type): Update comment.
9218
9219 2019-01-23  Tom Tromey  <tom@tromey.com>
9220
9221         * infrun.c (fetch_inferior_event): Update comment.
9222
9223 2019-01-23  Tom Tromey  <tom@tromey.com>
9224             Pedro Alves  <palves@redhat.com>
9225
9226         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9227         parameter.
9228         (fetch_inferior_event): Use SCOPE_EXIT.
9229
9230
9231 2019-01-23  Tom Tromey  <tom@tromey.com>
9232             Pedro Alves  <palves@redhat.com>
9233
9234         * infrun.c (disable_thread_events): Delete.
9235         (stop_all_threads): Use SCOPE_EXIT.
9236
9237 2019-01-23  Tom Tromey  <tom@tromey.com>
9238             Pedro Alves  <palves@redhat.com>
9239
9240         * symfile.c: Include forward-scope-exit.h.
9241         (clear_symtab_users_cleanup): Replace forward declaration with
9242         a FORWARD_SCOPE_EXIT.
9243         (syms_from_objfile_1): Use the forward_scope_exit and
9244         gdb::optional instead of cleanup_function.
9245         (reread_symbols): Use the forward_scope_exit instead of
9246         cleanup_function.
9247         (clear_symtab_users_cleanup): Remove function.
9248
9249 2019-01-23  Tom Tromey  <tom@tromey.com>
9250             Pedro Alves  <palves@redhat.com>
9251
9252         * linux-nat.c: Include scope-exit.h.
9253         (cleanup_target_stop): Remove.
9254         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9255         SCOPE_EXIT.
9256
9257 2019-01-23  Tom Tromey  <tom@tromey.com>
9258             Pedro Alves  <palves@redhat.com>
9259
9260         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9261         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9262
9263 2019-01-23  Tom Tromey  <tom@tromey.com>
9264             Andrew Burgess  <andrew.burgess@embecosm.com>
9265             Pedro Alves  <palves@redhat.com>
9266
9267         * infrun.c (fetch_inferior_event): Use scope_exit.
9268         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9269         * top.c (execute_command): Use scope_exit.
9270         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9271         * utils.c (do_bpstat_clear_actions_cleanup)
9272         (make_bpstat_clear_actions_cleanup): Remove.
9273
9274 2019-01-23  Tom Tromey  <tom@tromey.com>
9275             Pedro Alves  <palves@redhat.com>
9276
9277         * infrun.c: Include "common/scope-exit.h"
9278         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9279         (wait_for_inferior): Use SCOPE_EXIT.
9280         (fetch_inferior_event): Use scope_exit.
9281
9282 2019-01-23  Tom Tromey  <tom@tromey.com>
9283             Pedro Alves  <palves@redhat.com>
9284
9285         * breakpoint.c (create_breakpoint): Remove cleanup.
9286
9287 2019-01-23  Tom Tromey  <tom@tromey.com>
9288             Andrew Burgess  <andrew.burgess@embecosm.com>
9289             Pedro Alves  <palves@redhat.com>
9290
9291 2019-01-23  Pedro Alves  <palves@redhat.com>
9292
9293         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9294
9295 2019-01-23  Pedro Alves  <palves@redhat.com>
9296             Andrew Burgess  <andrew.burgess@embecosm.com>
9297
9298         * gdbthread.h: Include "common/forward-scope-exit.h".
9299         (scoped_finish_thread_state): Redefine custom class in terms of
9300         forward_scope_exit.
9301
9302 2019-01-23  Pedro Alves  <palves@redhat.com>
9303             Andrew Burgess  <andrew.burgess@embecosm.com>
9304
9305         * common/forward-scope-exit.h: New file.
9306
9307 2019-01-23  Pedro Alves  <palves@redhat.com>
9308             Andrew Burgess  <andrew.burgess@embecosm.com>
9309             Tom Tromey  <tom@tromey.com>
9310
9311         * common/scope-exit.h: New file.
9312
9313 2019-01-23  Pedro Alves  <palves@redhat.com>
9314
9315         * common/preprocessor.h (ESC): Rename to ...
9316         (ESC_PARENS): ... this.
9317         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9318         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9319
9320 2019-01-23  Tom Tromey  <tom@tromey.com>
9321
9322         * language.h (class scoped_switch_to_sym_language_if_auto):
9323         Initialize m_lang in both cases.
9324
9325 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9326
9327         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9328         with XCNEW.
9329
9330 2019-01-22  Tom Tromey  <tom@tromey.com>
9331
9332         * corelow.c: Do not include sys/file.h.
9333
9334 2019-01-22  Tom Tromey  <tom@tromey.com>
9335
9336         * tui/tui-wingeneral.h: Include gdb_curses.h.
9337
9338 2019-01-22  Tom Tromey  <tom@tromey.com>
9339
9340         * source-cache.h (class source_cache) <get_source_lines,
9341         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9342
9343 2019-01-22  Tom Tromey  <tom@tromey.com>
9344
9345         * remote-fileio.h (struct remote_target): Declare.
9346
9347 2019-01-22  Tom Tromey  <tom@tromey.com>
9348
9349         * python/py-arch.c: Do not include py-ref.h.
9350         * python/py-bpevent.c: Do not include py-ref.h.
9351         * python/py-cmd.c: Do not include py-ref.h.
9352         * python/py-continueevent.c: Do not include py-ref.h.
9353         * python/py-event.h: Do not include py-ref.h.
9354         * python/py-evtregistry.c: Do not include py-ref.h.
9355         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9356         * python/py-frame.c: Do not include py-ref.h.
9357         * python/py-framefilter.c: Do not include py-ref.h.
9358         * python/py-function.c: Do not include py-ref.h.
9359         * python/py-infevents.c: Do not include py-ref.h.
9360         * python/py-linetable.c: Do not include py-ref.h.
9361         * python/py-objfile.c: Do not include py-ref.h.
9362         * python/py-param.c: Do not include py-ref.h.
9363         * python/py-prettyprint.c: Do not include py-ref.h.
9364         * python/py-progspace.c: Do not include py-ref.h.
9365         * python/py-symbol.c: Do not include py-ref.h.
9366         * python/py-symtab.c: Do not include py-ref.h.
9367         * python/py-type.c: Do not include py-ref.h.
9368         * python/py-unwind.c: Do not include py-ref.h.
9369         * python/py-utils.c: Do not include py-ref.h.
9370         * python/py-value.c: Do not include py-ref.h.
9371         * python/py-varobj.c: Do not include py-ref.h.
9372         * python/py-xmethods.c: Do not include py-ref.h.
9373         * python/python.c: Do not include py-ref.h.
9374         * varobj.c: Do not include py-ref.h.
9375
9376 2019-01-22  Tom Tromey  <tom@tromey.com>
9377
9378         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9379         keyword for bcache.
9380
9381 2019-01-22  Tom Tromey  <tom@tromey.com>
9382
9383         * compile/compile-cplus-types.c: Remove a comment by #include.
9384
9385 2019-01-22  Tom Tromey  <tom@tromey.com>
9386
9387         * compile/gcc-c-plugin.h: Include compile-internal.h.
9388
9389 2019-01-22  Tom Tromey  <tom@tromey.com>
9390
9391         * stabsread.c (EXTERN): Do not define.
9392         (symnum, next_symbol_text_func, processing_gcc_compilation)
9393         (within_function, global_sym_chain, global_stabs)
9394         (previous_stab_code, this_object_header_files)
9395         (n_this_object_header_files)
9396         (n_allocated_this_object_header_files): Define.
9397         * stabsread.h (EXTERN): Never define.  Use "extern".
9398
9399 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9400
9401         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9402         history_value.
9403
9404 2019-01-21  Tom Tromey  <tom@tromey.com>
9405
9406         * ui-out.c: Fix includes.
9407         * tui/tui-source.c: Fix includes.
9408         * target.c: Fix includes.
9409         * remote.c: Fix includes.
9410         * regcache.c: Fix includes.
9411         * python/py-block.c: Fix includes.
9412         * printcmd.c: Fix includes.
9413         * or1k-tdep.c: Fix includes.
9414         * mi/mi-main.c: Fix includes.
9415         * m32r-tdep.c: Fix includes.
9416         * csky-tdep.c: Fix includes.
9417         * compile/compile-cplus-types.c: Fix includes.
9418         * cli/cli-interp.c: Fix includes.
9419
9420 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9421
9422         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9423         for padding.
9424
9425 2019-01-16  Tom Tromey  <tom@tromey.com>
9426
9427         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9428         earlier.
9429         (struct objfile) <msymbols_range>: Move from top level.
9430         <msymbols>: New method.
9431         (class objfile_msymbols): Remove.
9432         * symtab.c (default_collect_symbol_completion_matches_break_on):
9433         Update.
9434         * symmisc.c (dump_msymbols): Update.
9435         * stabsread.c (scan_file_globals): Update.
9436         * objc-lang.c (info_selectors_command, info_classes_command)
9437         (find_methods): Update.
9438         * minsyms.c (find_solib_trampoline_target): Update.
9439         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9440         * coffread.c (coff_symfile_read): Update.
9441         * ada-lang.c (ada_lookup_simple_minsym)
9442         (ada_collect_symbol_completion_matches): Update.
9443
9444 2019-01-16  Tom Tromey  <tom@tromey.com>
9445
9446         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9447         type.  Remove no-argument constructor.
9448         <iterator::operator++>: Simplify.
9449         <begin>: Update.
9450         <end>: Use minimal_symbol_count.
9451
9452 2019-01-16  Tom Tromey  <tom@tromey.com>
9453
9454         * objfiles.h (struct objfile) <psymtabs>: New method.
9455         (class objfile_psymtabs): Remove.
9456         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9457         typedef.
9458         <range>: New method.
9459         (require_partial_symbols): Change return type.
9460         * psymtab.c (require_partial_symbols)
9461         (psym_expand_symtabs_matching): Update.
9462         * mdebugread.c (parse_partial_symbols): Update.
9463         * dbxread.c (dbx_end_psymtab): Update.
9464
9465 2019-01-15  Tom Tromey  <tom@tromey.com>
9466
9467         * symtab.c (lookup_objfile_from_block)
9468         (lookup_symbol_in_objfile_symtabs)
9469         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9470         (find_line_symtab, info_sources_command)
9471         (default_collect_symbol_completion_matches_break_on)
9472         (make_source_files_completion_list): Update.
9473         * symmisc.c (print_objfile_statistics, dump_objfile)
9474         (maintenance_print_symbols, maintenance_info_symtabs)
9475         (maintenance_check_symtabs, maintenance_info_line_tables):
9476         Update.
9477         * source.c (select_source_symtab)
9478         (forget_cached_source_info_for_objfile): Update.
9479         * objfiles.h (class objfile_compunits): Remove.
9480         (struct objfile) <compunits_range>: New typedef.
9481         (compunits): New method.
9482         * objfiles.c (objfile_relocate1): Update.
9483         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9484         * maint.c (count_symtabs_and_blocks): Update.
9485         * linespec.c (iterate_over_all_matching_symtabs): Update.
9486         * cp-support.c (add_symbol_overload_list_qualified): Update.
9487         * coffread.c (coff_symtab_read): Update.
9488         * ada-lang.c (add_nonlocal_symbols)
9489         (ada_collect_symbol_completion_matches)
9490         (ada_add_global_exceptions): Update.
9491
9492 2019-01-15  Tom Tromey  <tom@tromey.com>
9493
9494         * progspace.h (program_space) <objfiles_safe_range>: New
9495         typedef.
9496         <objfiles_safe>: New method.
9497         * objfiles.h (class all_objfiles_safe): Remove.
9498         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9499         * jit.c (jit_inferior_exit_hook): Update.
9500
9501 2019-01-17  Tom Tromey  <tom@tromey.com>
9502
9503         * progspace.h (program_space) <objfiles_range>: New typedef.
9504         <objfiles>: New method.
9505         <objfiles_head>: Rename from objfiles.
9506         (object_files): Update.
9507         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9508         * guile/scm-pretty-print.c
9509         (ppscm_find_pretty_printer_from_objfiles): Update.
9510         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9511         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9512         Update.
9513         * python/py-progspace.c (pspy_get_objfiles): Update.
9514         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9515         Update.
9516         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9517         (objfpy_lookup_objfile_by_build_id): Update.
9518         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9519         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9520         Update.
9521         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9522         (expand_symtab_containing_pc, lookup_objfile_from_block)
9523         (lookup_static_symbol, basic_lookup_transparent_type)
9524         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9525         (find_line_symtab, info_sources_command)
9526         (default_collect_symbol_completion_matches_break_on)
9527         (make_source_files_completion_list, find_main_name): Update.
9528         * symmisc.c (print_symbol_bcache_statistics)
9529         (print_objfile_statistics, maintenance_print_symbols)
9530         (maintenance_print_msymbols, maintenance_print_objfiles)
9531         (maintenance_info_symtabs, maintenance_check_symtabs)
9532         (maintenance_expand_symtabs, maintenance_info_line_tables):
9533         Update.
9534         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9535         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9536         (map_overlay_command, unmap_overlay_command)
9537         (simple_overlay_update, expand_symtabs_matching)
9538         (map_symbol_filenames): Update.
9539         * symfile-debug.c (set_debug_symfile): Update.
9540         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9541         Update.
9542         * source.c (select_source_symtab, forget_cached_source_info):
9543         Update.
9544         * solib.c (solib_read_symbols): Update.
9545         * solib-spu.c (append_ocl_sos): Update.
9546         * psymtab.c (maintenance_print_psymbols)
9547         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9548         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9549         * printcmd.c (info_symbol_command): Update.
9550         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9551         Update.
9552         * objfiles.h (class all_objfiles): Remove.
9553         * objfiles.c (have_partial_symbols, have_full_symbols)
9554         (have_minimal_symbols, qsort_cmp, update_section_map)
9555         (shared_objfile_contains_address_p)
9556         (default_iterate_over_objfiles_in_search_order): Update.
9557         * objc-lang.c (info_selectors_command, info_classes_command)
9558         (find_methods): Update.
9559         * minsyms.c (find_solib_trampoline_target): Update.
9560         * maint.c (maintenance_info_sections)
9561         (maintenance_translate_address, count_symtabs_and_blocks):
9562         Update.
9563         * main.c (captured_main_1): Update.
9564         * linux-thread-db.c (try_thread_db_load_from_pdir)
9565         (has_libpthread): Update.
9566         * linespec.c (iterate_over_all_matching_symtabs)
9567         (search_minsyms_for_name): Update.
9568         * jit.c (jit_find_objf_with_entry_addr): Update.
9569         * hppa-tdep.c (find_unwind_entry)
9570         (hppa_lookup_stub_minimal_symbol): Update.
9571         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9572         Update.
9573         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9574         (elf_gnu_ifunc_resolve_by_got): Update.
9575         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9576         * dwarf-index-write.c (save_gdb_index_command): Update.
9577         * cp-support.c (add_symbol_overload_list_qualified): Update.
9578         * breakpoint.c (create_overlay_event_breakpoint)
9579         (create_longjmp_master_breakpoint)
9580         (create_std_terminate_master_breakpoint)
9581         (create_exception_master_breakpoint): Update.
9582         * blockframe.c (find_pc_partial_function): Update.
9583         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9584         (ada_collect_symbol_completion_matches)
9585         (ada_add_global_exceptions): Update.
9586
9587 2019-01-17  Tom Tromey  <tom@tromey.com>
9588
9589         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9590         declare VEC.
9591         (solib_target_parse_libraries): Change return type.
9592         (library_list_start_segment, library_list_start_section)
9593         (library_list_end_library, library_list_start_library); Update.
9594         (solib_target_free_library_list): Remove.
9595         (solib_target_parse_libraries): Remove cleanup.  Change return
9596         type.
9597         (solib_target_current_sos): Update.
9598
9599 2019-01-17  Tom Tromey  <tromey@bapiya>
9600
9601         * valprint.c: Replace "the the" with "the".
9602         * symtab.c: Replace "the the" with "the".
9603         * solib.c: Replace "the the" with "the".
9604         * solib-dsbt.c: Replace "the the" with "the".
9605         * linespec.c: Replace "the the" with "the".
9606         * dwarf2loc.h: Replace "the the" with "the".
9607         * amd64-windows-tdep.c: Replace "the the" with "the".
9608         * aarch64-tdep.c: Replace "the the" with "the".
9609
9610 2019-01-16  Keith Seitz  <keiths@redhat.com>
9611
9612         PR gdb/23773
9613         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9614         <builder>: Rename to ..
9615         <m_builder>: ... this and make private.
9616         (dwarf2_cu::get_builder): New method.  Change all users of
9617         `builder' to use this method.
9618         (dwarf2_start_symtab): Move to ...
9619         (dwarf2_cu::start_symtab): ... here.  Update all callers
9620         (setup_type_unit_groups): Move to ...
9621         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9622         callers.
9623         (dwarf2_cu::reset_builder): New method.
9624         (process_full_compunit, process_full_type_unit): Use
9625         dwarf2_cu::reset_builder.
9626         (follow_die_offset): Record the ancestor CU if it is different
9627         from the followed DIE's CU.
9628         (follow_die_sig_1): Likewise.
9629
9630 2019-01-15  Tom Tromey  <tom@tromey.com>
9631
9632         * remote.c (class remote_state) <buf>: Now a char_vector.
9633         <buf_size>: Remove.
9634         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9635         parameter.
9636         (remote_target::getpkt_or_notif_sane_1)
9637         (remote_target::getpkt_sane)
9638         (remote_target::getpkt_or_notif_sane): Likewise.
9639         (class remote_target) <putpkt>: New overload.
9640         (remote_target::read_frame): Change type of "buf_p".  Remove
9641         sizeof_p parameter.
9642         (packet_ok): New overload.
9643         (packet_check_result): New overload.
9644         Update all uses.
9645
9646 2019-01-14  Tom Tromey  <tom@tromey.com>
9647
9648         * remote-notif.c (handle_notification, remote_notif_ack)
9649         (remote_notif_parse): Make "buf" const.
9650         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9651         const.
9652         (remote_notif_parse, remote_notif_ack, handle_notification):
9653         Likewise.
9654         * remote.c (remote_notif_stop_parse): Make "buf" const.
9655         (remote_target::remote_parse_stop_reply): Make "buf" const.
9656         (remote_notif_stop_ack): Make "buf" const.
9657
9658 2019-01-14  Tom Tromey  <tom@tromey.com>
9659
9660         * remote.c (remote_console_output): Make parameter const.
9661
9662 2019-01-14  Tom Tromey  <tom@tromey.com>
9663
9664         * target-debug.h (target_debug_print_signals): Constify.
9665         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9666         * procfs.c (procfs_target::pass_signals): Update.
9667         * linux-nat.c (linux_nat_target::pass_signals): Update.
9668         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9669         * target-delegates.c: Rebuild.
9670         * remote.c (remote_target::program_signals): Update.
9671         (remote_target::pass_signals): Update.
9672         * target.c (target_pass_signals): Constify argument.
9673         (target_program_signals): Likewise.
9674         * target.h (struct target_ops) <pass_signals, program_signals>:
9675         Constify argument.
9676         (target_pass_signals, target_program_signals): Constify argument.
9677
9678 2019-01-14  Tom Tromey  <tom@tromey.com>
9679
9680         PR tui/28819:
9681         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9682
9683 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9684
9685         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9686         field.
9687         * rs6000-tdep.c: Include reggroups.h.
9688         (IS_V_ALIAS_PSEUDOREG): Define.
9689         (rs6000_register_name): Return names for the "vX" aliases.
9690         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9691         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9692         aliases.  Call default_register_reggroup_p for all other
9693         pseudo-registers.
9694         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9695         New functions.
9696         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9697         Handle "vX" aliases.
9698         (v_alias_pseudo_register_collect): New function.
9699         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9700         (rs6000_gdbarch_init): Initialize "vX" aliases as
9701         pseudo-registers.  Restore registration of
9702         rs6000_pseudo_register_reggroup_p with
9703         set_tdesc_pseudo_register_reggroup_p.
9704
9705 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9706
9707         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9708         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9709         set_gdbarch_num_pseudo_regs.
9710
9711 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9712
9713         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9714         Remove arg prefixname, add do_set and do_show.
9715         Add member functions set_list and show_list.
9716         * cli/cli-style.c (class cli_style_option): Update accordingly.
9717         (style_set_list): Move to file scope.
9718         (style_show_list): Likewise.
9719         (set_style): Call help_list.
9720         (show_style): Call cmd_show_list.
9721         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9722         Update to use the new macro.
9723
9724 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9725
9726         * ada-lang.c (_initialize_ada_language): Expand the help text
9727         for the "catch exception" command.
9728
9729 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9730
9731         * symtab.c (matching_obj_sections): Initialize obj,
9732         declare it closer to its usage.
9733
9734 2019-01-10  Tom Tromey  <tom@tromey.com>
9735
9736         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9737         (basic_inf_threads_range): Remove.
9738         (inf_threads_range, inf_non_exited_threads_range)
9739         (safe_inf_threads_range): Use next_adapter.
9740
9741 2019-01-10  Keith Seitz  <keiths@redhat.com>
9742
9743         PR gdb/23712
9744         PR symtab/23010
9745         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9746         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9747
9748 2019-01-10  Keith Seitz  <keiths@redhat.com>
9749
9750         PR gdb/23712
9751         PR symtab/23010
9752         * dictionary.c (pending_to_vector): Remove.
9753         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9754         Remove _1 suffix, replacing functions of the same name.  Update
9755         all callers.
9756         (dict_create_hashed, dict_create_hashed_expandable)
9757         (dict_create_linear, dict_create_linear_expandable, dict_free)
9758         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9759         Make functions static.
9760
9761 2019-01-10  Keith Seitz  <keiths@redhat.com>
9762
9763         PR gdb/23712
9764         PR symtab/23010
9765         * dictionary.h (struct dictionary): Replace declaration with
9766         multidictionary.
9767         (dict_create_hashed, dict_create_hashed_expandable)
9768         (dict_create_linear, dict_create_linear_expandable)
9769         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9770         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9771         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9772         taking multidictionary argument.
9773         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9774         * block.h (struct block) <dict>: Change to multidictionary
9775         and rename `multidict'.
9776         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9777         symmisc.c: Update all dictionary references to multidictionary.
9778
9779 2019-01-10  Keith Seitz  <keiths@redhat.com>
9780
9781         PR gdb/23712
9782         PR symtab/23010
9783         * dictionary.c: Include unordered_map.
9784         (pending_to_vector): New function.
9785         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9786         Rewrite the non-"_1" functions to take vector instead
9787         of linked list.
9788         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9789         "new" _1 versions of the same name.
9790         (multidictionary): Define.
9791         (std::hash<enum language): New definition.
9792         (collate_pending_symbols_by_language, mdict_create_hashed)
9793         (mdict_create_hashed_expandable, mdict_create_linear)
9794         (mdict_create_linear_expandable, mdict_free)
9795         (find_language_dictionary, create_new_language_dictionary)
9796         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9797         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9798         (mdict_size, mdict_empty): New functions.
9799         * dictionary.h (mdict_iterator): Define.
9800
9801 2019-01-10  Pedro Alves  <palves@redhat.com>
9802
9803         * breakpoint.c (read_uploaded_action)
9804         (create_tracepoint_from_upload): Adjust to use
9805         gdb::unique_xmalloc_ptr.
9806         * ctf.c (ctf_write_uploaded_tp):
9807         (SET_ARRAY_FIELD): Use emplace_back.
9808         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9809         * tracefile-tfile.c (tfile_write_uploaded_tp):
9810         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9811         gdb::unique_xmalloc_ptr.
9812         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9813         at_string, cond_string, cmd_strings>: Replace char pointers
9814         with gdb::unique_xmalloc_ptr.
9815
9816 2019-01-10  Pedro Alves  <palves@redhat.com>
9817
9818         * solib-target.c (library_list_start_library): Don't xstrdup name.
9819
9820 2019-01-10  Pedro Alves  <palves@redhat.com>
9821
9822         * mdebugread.c (parse_partial_symbols): Use
9823         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9824
9825 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9826
9827         * linux-fork.c (scoped_switch_fork_info)
9828         <~scoped_switch_fork_info>: Fix incorrect variable name.
9829
9830 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9831
9832         * linux-fork.c (scoped_switch_fork_info)
9833         <scoped_switch_fork_info>: Make explicit.
9834         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9835
9836 2019-01-10  Tom Tromey  <tom@tromey.com>
9837
9838         * objfiles.h (objfile::reset_psymtabs): Update.
9839         * objfiles.c (objfile::objfile): Update.
9840         * psymtab.h (psymtab_storage::obstack): Update.
9841         (psymtab_storage::m_obstack): Use gdb::optional.
9842         (class psymtab_storage): Update comment.  Remove objfile
9843         parameter.
9844         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9845
9846 2019-01-10  Tom Tromey  <tom@tromey.com>
9847
9848         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9849         <free_psymtabs>: Now private.
9850         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9851         (allocate_psymtab): Use new method.
9852
9853 2019-01-10  Tom Tromey  <tom@tromey.com>
9854
9855         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9856         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9857         * mdebugread.c (parse_partial_symbols): Use
9858         allocate_dependencies.
9859         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9860         allocate_dependencies.
9861         (process_psymtab_comp_unit_reader)
9862         (build_type_psymtab_dependencies): Likewise.
9863         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9864
9865 2019-01-10  Tom Tromey  <tom@tromey.com>
9866
9867         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9868         PSYMBOL_SET_LANGUAGE.
9869         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9870
9871 2019-01-10  Tom Tromey  <tom@tromey.com>
9872
9873         * psymtab.h (psymtab_storage::obstack): New method.
9874         <m_obstack>: Rename from obstack; now private.
9875         * psymtab.c (psymtab_storage): Update.
9876         * dwarf2read.c (create_addrmap_from_index)
9877         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9878         Update.
9879
9880 2019-01-10  Tom Tromey  <tom@tromey.com>
9881
9882         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9883         * objfiles.h (objfile::reset_psymtabs): New method.
9884
9885 2019-01-10  Tom Tromey  <tom@tromey.com>
9886
9887         * symmisc.c (print_symbol_bcache_statistics): Update.
9888         (print_objfile_statistics): Update.
9889         * symfile.c (reread_symbols): Update.
9890         * psymtab.h (class psymtab_storage): New.
9891         * psymtab.c (psymtab_storage): New constructor.
9892         (~psymtab_storage): New destructor.
9893         (require_partial_symbols): Update.
9894         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9895         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9896         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9897         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9898         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9899         (start_psymtab_common, end_psymtab_common)
9900         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9901         (allocate_psymtab): Update.
9902         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9903         Update.
9904         (dump_psymtab_addrmap, maintenance_print_psymbols)
9905         (maintenance_check_psymtabs): Update.
9906         (class objfile_psymtabs): Move to objfiles.h.
9907         * psympriv.h (discard_psymtab): Now inline.
9908         (psymtab_discarder::psymtab_discarder): Update.
9909         (psymtab_discarder::~psymtab_discarder): Update.
9910         (ALL_OBJFILE_PSYMTABS): Rewrite.
9911         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9912         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9913         Remove fields.
9914         <partial_symtabs>: New field.
9915         (class objfile_psymtabs): Move from psymtab.h.  Update.
9916         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9917         psymbol_cache.
9918         (objfile::~objfile): Don't destroy psymbol_cache.
9919         * mdebugread.c (parse_partial_symbols): Update.
9920         * dwarf2read.c (create_addrmap_from_index)
9921         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9922         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9923         (add_partial_subprogram, dwarf2_ranges_read): Update.
9924         * dwarf-index-write.c (write_address_map)
9925         (write_one_signatured_type, recursively_write_psymbols)
9926         (class debug_names, class debug_names, write_psymtabs_to_index):
9927         Update.
9928
9929 2019-01-10  Tom Tromey  <tom@tromey.com>
9930
9931         * symtab.h (SYMBOL_SET_NAMES): Update.
9932         (symbol_set_names): Update.
9933         (MSYMBOL_SET_NAMES): Update.
9934         * symtab.c (symbol_set_names): Change argument to be an
9935         objfile_per_bfd_storage.
9936         * psymtab.c (add_psymbol_to_bcache): Update.
9937         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9938
9939 2019-01-10  Tom Tromey  <tom@tromey.com>
9940
9941         * symtab.c (create_demangled_names_hash): Change argument to be an
9942         objfile_per_bfd_storage.
9943         (symbol_set_names): Update.
9944
9945 2019-01-10  Tom Tromey  <tom@tromey.com>
9946
9947         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9948         init_psymbol_list.
9949         * psymtab.c (init_psymbol_list): Do nothing if already called.
9950         * psympriv.h (init_psymbol_list): Add comment.
9951         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9952         init_psymbol_list.
9953         * dbxread.c (dbx_symfile_read): Unconditionally call
9954         init_psymbol_list.
9955
9956 2019-01-10  Tom Tromey  <tom@tromey.com>
9957
9958         * xcoffread.c (scan_xcoff_symtab): Update.
9959         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9960         "where".
9961         * mdebugread.c (parse_partial_symbols)
9962         (handle_psymbol_enumerators): Update.
9963         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9964         * dbxread.c (read_dbx_symtab): Update.
9965         * psympriv.h (psymbol_placement): New enum.
9966         (add_psymbol_to_list): Update.
9967
9968 2019-01-10  Tom Tromey  <tom@tromey.com>
9969
9970         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9971         static_psymbols parameters.
9972         (scan_xcoff_symtab): Update.
9973         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9974         static_psymbols parameters.
9975         * psympriv.h (start_psymtab_common): Update.
9976         * mdebugread.c (parse_partial_symbols): Update.
9977         * dwarf2read.c (create_partial_symtab): Update.
9978         * dbxread.c (read_dbx_symtab): Update.
9979         (start_psymtab): Remove global_psymbols and static_psymbols
9980         parameters.
9981
9982 2019-01-10  Tom Tromey  <tom@tromey.com>
9983
9984         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9985         * psymtab.c (allocate_psymtab): Add comment.
9986         * psympriv.h (allocate_psymtab): Add comment.
9987         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9988         initializations.
9989         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9990
9991 2019-01-10  Tom Tromey  <tom@tromey.com>
9992
9993         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9994         Don't declare.
9995         * mipsread.c: Include mdebugread.h.
9996         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9997         Declare.
9998         * elfread.c: Include mdebugread.h.
9999
10000 2019-01-09  Tom Tromey  <tom@tromey.com>
10001
10002         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10003         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10004         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10005         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10006         (psym_lookup_symbol, psym_find_last_source_symtab)
10007         (psym_forget_cached_source_info, psym_print_stats)
10008         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10009         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10010         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10011         (psym_find_compunit_symtab_by_address)
10012         (maintenance_print_psymbols, maintenance_info_psymtabs)
10013         (maintenance_check_psymtabs): Use ranged for.
10014         * psymtab.h (class objfile_psymtabs): New.
10015         (require_partial_symbols): Return objfile_psymtabs.
10016         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10017
10018 2019-01-09  Tom Tromey  <tom@tromey.com>
10019
10020         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10021         (find_pc_mapped_section, list_overlays_command)
10022         (map_overlay_command, unmap_overlay_command)
10023         (simple_overlay_update): Use all_objfiles.
10024         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10025         * printcmd.c (info_symbol_command): Use all_objfiles.
10026         * objfiles.h (ALL_OBJSECTIONS): Remove.
10027         * maint.c (maintenance_translate_address): Use all_objfiles.
10028         * gcore.c (gcore_create_callback): Use all_objfiles.
10029         (objfile_find_memory_regions): Likewise.
10030
10031 2019-01-09  Tom Tromey  <tom@tromey.com>
10032
10033         * symtab.c (find_line_symtab, info_sources_command)
10034         (make_source_files_completion_list): Use objfile_compunits.
10035         * source.c (select_source_symtab): Use objfile_compunits.
10036         * objfiles.h (struct objfile): Update comment.
10037         (ALL_OBJFILES): Remove.
10038         (ALL_FILETABS): Remove.
10039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10040         objfile_compunits.
10041
10042 2019-01-09  Tom Tromey  <tom@tromey.com>
10043
10044         * symmisc.c (print_objfile_statistics, dump_objfile)
10045         (maintenance_print_symbols): Use compunit_filetabs.
10046         * source.c (forget_cached_source_info_for_objfile): Use
10047         compunit_filetabs.
10048         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10049         (ALL_FILETABS): Use compunit_filetabs.
10050         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10051         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10052
10053 2019-01-09  Tom Tromey  <tom@tromey.com>
10054
10055         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10056         (compunit_filetabs): New.
10057         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10058         compunit_filetabs.
10059         (info_sources_command, make_source_files_completion_list): Remove
10060         declaration.
10061         * symmisc.c (print_objfile_statistics, dump_objfile)
10062         (maintenance_print_symbols): Remove declaration.
10063         (maintenance_info_symtabs): Use compunit_filetabs.
10064         (maintenance_info_line_tables): Likewise.
10065         * source.c (select_source_symtab): Change local variable name.
10066         (forget_cached_source_info_for_objfile): Remove declaration.
10067         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10068         * objfiles.c (objfile_relocate1): Remove declaration.
10069         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10070         declaration.
10071         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10072         * coffread.c (coff_symtab_read): Remove declaration.
10073         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10074         compunit_filetabs.
10075
10076 2019-01-09  Tom Tromey  <tom@tromey.com>
10077
10078         * symtab.c (lookup_objfile_from_block)
10079         (find_pc_sect_compunit_symtab, search_symbols)
10080         (default_collect_symbol_completion_matches_break_on): Use
10081         objfile_compunits.
10082         * objfiles.h (ALL_COMPUNITS): Remove.
10083         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10084         * cp-support.c (add_symbol_overload_list_qualified): Use
10085         objfile_compunits.
10086         * ada-lang.c (ada_collect_symbol_completion_matches)
10087         (ada_add_global_exceptions): Use objfile_compunits.
10088
10089 2019-01-09  Tom Tromey  <tom@tromey.com>
10090
10091         * source.c (select_source_symtab)
10092         (forget_cached_source_info_for_objfile): Remove declaration.
10093         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10094         declaration.
10095         * maint.c (count_symtabs_and_blocks): Remove declaration.
10096         * cp-support.c (add_symbol_overload_list_qualified): Remove
10097         declaration.
10098         * coffread.c (coff_symtab_read): Remove declaration.
10099         * symtab.c (lookup_symbol_in_objfile_symtabs)
10100         (basic_lookup_transparent_type_1): Use objfile_compunits.
10101         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10102         (info_sources_command, search_symbols)
10103         (default_collect_symbol_completion_matches_break_on)
10104         (make_source_files_completion_list): Remove declaration.
10105         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10106         (ada_collect_symbol_completion_matches)
10107         (ada_add_global_exceptions): Remove declaration.
10108         * linespec.c (iterate_over_all_matching_symtabs): Use
10109         objfile_compunits.
10110         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10111         (class objfile_compunits): New.
10112         (ALL_COMPUNITS): Use objfile_compunits.
10113         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10114         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10115         objfile_compunits.
10116         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10117
10118 2019-01-09  Tom Tromey  <tom@tromey.com>
10119
10120         * symtab.c (search_symbols)
10121         (default_collect_symbol_completion_matches_break_on): Use
10122         objfile_msymbols.
10123         * ada-lang.c (ada_lookup_simple_minsym)
10124         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10125         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10126         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10127         objfile_msymbols.
10128         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10129         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10130         * objc-lang.c (find_methods): Use objfile_msymbols.
10131         (info_selectors_command, info_classes_command): Likewise.
10132         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10133         * objfiles.h (class objfile_msymbols): New.
10134         (ALL_OBJFILE_MSYMBOLS): Remove.
10135         (ALL_MSYMBOLS): Remove.
10136
10137 2019-01-09  Tom Tromey  <tom@tromey.com>
10138
10139         * common/next-iterator.h (next_adapter): Add Iterator template
10140         parameter.
10141         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10142         (class all_objfiles_safe): New.
10143         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10144         * objfiles.c (put_objfile_before): Update comment.
10145         (add_separate_debug_objfile): Likewise.
10146         (free_all_objfiles): Use all_objfiles_safe.
10147         (objfile_purge_solibs): Likewise.
10148
10149 2019-01-09  Tom Tromey  <tom@tromey.com>
10150
10151         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10152         (expand_symtab_containing_pc, lookup_static_symbol)
10153         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10154         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10155         all_objfiles.
10156         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10157         * breakpoint.c (create_overlay_event_breakpoint)
10158         (create_longjmp_master_breakpoint)
10159         (create_std_terminate_master_breakpoint)
10160         (create_exception_master_breakpoint): Use all_objfiles.
10161         * linux-thread-db.c (try_thread_db_load_from_pdir)
10162         (has_libpthread): Use all_objfiles.
10163         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10164         * linespec.c (iterate_over_all_matching_symtabs)
10165         (search_minsyms_for_name): Use all_objfiles.
10166         * maint.c (maintenance_info_sections): Use all_objfiles.
10167         * main.c (captured_main_1): Use all_objfiles.
10168         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10169         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10170         * guile/scm-pretty-print.c
10171         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10172         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10173         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10174         (maintenance_print_msymbols): Use all_objfiles.
10175         * source.c (select_source_symtab): Use all_objfiles.
10176         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10177         * symfile.c (remove_symbol_file_command)
10178         (expand_symtabs_matching, map_symbol_filenames): Use
10179         all_objfiles.
10180         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10181         all_objfiles.
10182         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10183         * objc-lang.c (find_methods): Use all_objfiles.
10184         * objfiles.c (have_partial_symbols, have_full_symbols)
10185         (have_minimal_symbols, qsort_cmp)
10186         (default_iterate_over_objfiles_in_search_order): Use
10187         all_objfiles.
10188         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10189         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10190         (maintenance_check_psymtabs): Use all_objfiles.
10191         (ALL_PSYMTABS): Remove.
10192         * compile/compile-object-run.c (do_module_cleanup): Use
10193         all_objfiles.
10194         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10195         * cp-support.c (add_symbol_overload_list_qualified): Use
10196         all_objfiles.
10197         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10198         Use all_objfiles.
10199         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10200         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10201         all_objfiles.
10202         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10203         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10204         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10205         Uses all_objfiles.
10206         * solib.c (solib_read_symbols): Use all_objfiles
10207
10208 2019-01-09  Tom Tromey  <tom@tromey.com>
10209
10210         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10211         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10212         all_objfiles.
10213         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10214         * symmisc.c (print_symbol_bcache_statistics)
10215         (print_objfile_statistics, maintenance_print_objfiles)
10216         (maintenance_info_symtabs, maintenance_check_symtabs)
10217         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10218         all_objfiles.
10219         * source.c (forget_cached_source_info): Use all_objfiles.
10220         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10221         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10222         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10223         * objfiles.c (update_section_map): Use all_objfiles.
10224         (shared_objfile_contains_address_p): Likewise.
10225         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10226         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10227
10228 2019-01-09  Tom Tromey  <tom@tromey.com>
10229
10230         * common/next-iterator.h: New file.
10231         * objfiles.h (class all_objfiles): New.
10232         (struct objfile_iterator): New.
10233
10234 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10235
10236         * NEWS: Move the description of the changed "frame", "select-frame",
10237          and "info frame" commands to the Changed commands section.
10238
10239 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10240
10241         * gdbtypes.c (check_stub_method_group): Remove handling of old
10242         mangling schemes.
10243         * linespec.c (find_methods): Likewise.
10244         * stabsread.c (read_member_functions): Likewise.
10245         * valops.c (search_struct_method): Likewise.
10246         (value_struct_elt_for_reference): Likewise.
10247         * NEWS: Mention this change.
10248
10249 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10250
10251         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10252         print_source_lines.
10253         * source.c (print_source_lines_base): Update line number check.
10254         (print_source_lines): New function.
10255         (source_lines_range::source_lines_range): New function.
10256         * source.h (class source_lines_range): New class.
10257         (print_source_lines): New declaration.
10258
10259 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10260
10261         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10262
10263 2019-01-08  Tom Tromey  <tom@tromey.com>
10264             Simon Marchi  <simon.marchi@ericsson.com>
10265
10266         PR gdb/24060
10267         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10268         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10269         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10270         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10271         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10272         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10273
10274 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10275
10276         * source.c (select_source_symtab): Move header comment to
10277         declaration in source.h.
10278         (forget_cached_source_info_for_objfile): Likewise.
10279         (forget_cached_source_info): Likewise.
10280         (identify_source_line): Likewise.
10281         * source.h (identify_source_line): Move declaration from symtab.h
10282         and add comment from source.c
10283         (print_source_lines): Likewise.
10284         (forget_cached_source_info_for_objfile): Likewise.
10285         (forget_cached_source_info): Likewise.
10286         (select_source_symtab): Likewise.
10287         (enum print_source_lines_flag): Move definition from symtab.h.
10288         * symtab.h (identify_source_line): Move declaration to source.h.
10289         (print_source_lines): Likewise.
10290         (forget_cached_source_info_for_objfile): Likewise.
10291         (forget_cached_source_info): Likewise.
10292         (select_source_symtab): Likewise.
10293         (enum print_source_lines_flag): Move definition to source.h.
10294         * tui/tui-hooks.c: Add 'source.h' include.
10295
10296 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * source.c (print_source_lines_base): Handle requests to print
10299         reverse line number sequences, and guard against empty lines
10300         string.
10301
10302 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10303
10304         * source.c (print_source_lines_base): Fix skip of '\r' if next
10305         character is '\n'.
10306
10307 2019-01-06  Tom Tromey  <tom@tromey.com>
10308
10309         * c-exp.y (struct c_parse_state) <macro_original_text,
10310         expansion_obstack>: New member.
10311         (macro_original_text, expansion_obstack): Remove globals.
10312         (scan_macro_expansion, scanning_macro_expansion)
10313         (finished_macro_expansion): Update.
10314         (scan_macro_cleanup): Remove.
10315         (yylex, c_parse): Update.
10316
10317 2019-01-06  Tom Tromey  <tom@tromey.com>
10318
10319         * c-exp.y (struct c_parse_state) <strings>: New member.
10320         (operator_stoken): Update.
10321
10322 2019-01-06  Tom Tromey  <tom@tromey.com>
10323
10324         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10325         (union type_stack_elt) <typelist_val>: Now a pointer to
10326         std::vector.
10327         (type_stack_cleanup): Don't declare.
10328         (push_typelist): Update.
10329         * parse.c (pop_typelist): Return a std::vector.
10330         (push_typelist): Take a std::vector.
10331         (follow_types): Update.  Do not free args.
10332         (type_stack_cleanup): Remove.
10333         * c-exp.y (struct c_parse_state): New.
10334         (cpstate): New global.
10335         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10336         (nonempty_typelist): Update.
10337         (func_mod): Create a new vector.
10338         (c_parse): Create a c_parse_state.
10339         (check_parameter_typelist): Do not delete params.
10340         (function_method): Update.  Do not delete type_list.
10341
10342 2019-01-06  Tom Tromey  <tom@tromey.com>
10343
10344         PR gdb/28155:
10345         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10346         check_typedef.
10347         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10348         (print_return_value): Likewise.
10349
10350 2019-01-05  Tom Tromey  <tom@tromey.com>
10351
10352         * contrib/cleanup_check.py: Remove.
10353         * contrib/gcc-with-excheck: Remove.
10354         * contrib/exsummary.py: Remove.
10355         * contrib/excheck.py: Remove.
10356
10357 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10358
10359         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10360         NULL. Initialize tpprev to NULL instead of assigning it
10361         to NULL on the next statement.
10362         * windows-nat.c (windows_delete_thread): Remove check for
10363         main_thread_id before printing thread exit notifications.
10364         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10365         Remove thread ID check against main_thread_id.
10366         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10367         windows_delete_thread.
10368         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10369
10370 2019-01-04  Tom Tromey  <tom@tromey.com>
10371
10372         * compile/compile.c (_initialize_compile): Use upper case for
10373         metasyntactic variables.
10374         * symmisc.c (_initialize_symmisc): Use upper case for
10375         metasyntactic variables.
10376         * psymtab.c (_initialize_psymtab): Use upper case for
10377         metasyntactic variables.
10378         * demangle.c (demangle_command): Use upper case for metasyntactic
10379         variables.
10380         (_initialize_demangler): Likewise.
10381         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10382         variables.
10383
10384 2019-01-03  Tom Tromey  <tom@tromey.com>
10385
10386         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10387
10388 2019-01-03  Tom Tromey  <tom@tromey.com>
10389
10390         * python/py-symtab.c (salpy_str): Update.
10391         (struct salpy_sal_object) <symtab>: Now a PyObject.
10392         (salpy_dealloc): Update.
10393         (del_objfile_sal): Use gdbpy_ref.
10394
10395 2019-01-03  Tom Tromey  <tom@tromey.com>
10396
10397         * python/py-type.c (convert_field): Use new_reference.  Return
10398         gdbpy_ref.
10399         (make_fielditem): Return gdbpy_ref.
10400         (typy_fields): Update.
10401         (typy_getitem): Update.
10402         (field_name): Return gdbpy_ref.  Use new_reference.
10403         (typy_iterator_iternext): Update.
10404
10405 2019-01-03  Tom Tromey  <tom@tromey.com>
10406
10407         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10408
10409 2019-01-03  Tom Tromey  <tom@tromey.com>
10410
10411         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10412         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10413         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10414         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10415         (pspy_set_type_printers): Likewise.
10416         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10417         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10418         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10419         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10420         (objfpy_set_type_printers): Likewise.
10421
10422 2019-01-03  Tom Tromey  <tom@tromey.com>
10423
10424         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10425         (gdbpy_print_stack): Use gdbpy_err_fetch.
10426         * python/python-internal.h (class gdbpy_err_fetch): New class.
10427         (class gdbpy_enter) <m_error_type, m_error_value,
10428         m_error_traceback>: Remove.
10429         <m_error>: New member.
10430         (gdbpy_exception_to_string): Don't declare.
10431         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10432         * python/py-value.c (convert_value_from_python): Use
10433         gdbpy_err_fetch.
10434         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10435         gdbpy_exception_to_string.
10436         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10437         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10438         gdbpy_err_fetch.
10439
10440 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10441
10442         * linux-nat.c (delete_lwp_cleanup): Delete.
10443         (struct lwp_deleter): New struct.
10444         (lwp_info_up): New typedef.
10445         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10446         lwp_info_up.
10447
10448 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10449
10450         * linux-fork.c (class scoped_switch_fork_info): New class.
10451         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10452
10453 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10454
10455         * valops.c (find_overload_match): Remove use of null_cleanup, and
10456         calls to do_cleanups.
10457
10458 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10459
10460         * compile/compile-cplus-types.c
10461         (compile_cplus_instance::decl_name): Handle changes to
10462         cp_func_name.
10463         * cp-support.c (cp_func_name): Update header comment, update
10464         return type.
10465         * cp-support.h (cp_func_name): Update return type in declaration.
10466         * valops.c (find_overload_match): Move temp_func local to top
10467         level of function and change its type.  Use temp_func to hold and
10468         delete temporary string obtained from cp_func_name.
10469
10470 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10471
10472         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10473         gdb::char_vector, remove cleanup, and update uses of `msg`.
10474
10475 2019-01-03  Jim Wilson  <jimw@sifive.com>
10476
10477         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10478
10479 2019-01-02  Tom Tromey  <tom@tromey.com>
10480
10481         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10482         (tdesc_parse_xml): Remove cleanups.
10483         * target-descriptions.h (make_cleanup_free_target_description):
10484         Don't declare.
10485         (target_desc_deleter): New struct.
10486         (target_desc_up): New typedef.
10487         * target-descriptions.c (target_desc_deleter::operator()): Rename
10488         from free_target_description.
10489         (make_cleanup_free_target_description): Remove.
10490
10491 2019-01-02  Tom Tromey  <tom@tromey.com>
10492
10493         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10494         constructor, destructor.
10495         (linespec_parser): Remove typedef.
10496         (~linespec_parser): Rename from linespec_parser_delete.
10497         (linespec_lex_to_end, linespec_complete_label)
10498         (linespec_complete): Update.
10499         (decode_line_full): Remove cleanups.
10500         (decode_line_1): Update.
10501
10502 2019-01-02  Tom Tromey  <tom@tromey.com>
10503
10504         * python/python-internal.h (inferior_to_inferior_object): Change
10505         return type.
10506         * python/py-exitedevent.c (create_exited_event_object): Update.
10507         * python/py-inferior.c (inferior_to_inferior_object): Return
10508         gdbpy_ref.
10509         (python_new_inferior, python_inferior_deleted)
10510         (thread_to_thread_object, delete_thread_object)
10511         (build_inferior_list, gdbpy_selected_inferior): Update.
10512         * python/py-infthread.c (create_thread_object): Update.  Also fail
10513         if inferior_to_inferior_object fails.
10514
10515 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10516
10517         * inferior.h (class inferior) <displaced_step_state>: New field.
10518         * infrun.h (struct displaced_step_state): Move here from
10519         infrun.c.  Initialize fields, add constructor.
10520         <inf>: Remove field.
10521         <reset>: New method.
10522         * infrun.c (struct displaced_step_inferior_state): Move to
10523         infrun.h.
10524         (displaced_step_inferior_states): Remove.
10525         (get_displaced_stepping_state): Adust.
10526         (displaced_step_in_progress_any_inferior): Adjust.
10527         (displaced_step_in_progress_thread): Adjust.
10528         (displaced_step_in_progress): Adjust.
10529         (add_displaced_stepping_state): Remove.
10530         (get_displaced_step_closure_by_addr): Adjust.
10531         (remove_displaced_stepping_state): Remove.
10532         (infrun_inferior_exit): Call displaced_step_state.reset.
10533         (use_displaced_stepping): Don't check for NULL.
10534         (displaced_step_prepare_throw): Call
10535         get_displaced_stepping_state.
10536         (displaced_step_fixup): Don't check for NULL.
10537         (prepare_for_detach): Don't check for NULL.
10538
10539 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10540
10541         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10542          in case of call that did not complete.
10543
10544 2019-01-02  Andrey Utkin  <autkin@undo.io>
10545
10546         * symfile.c (find_separate_debug_file): Fix search of debug files for
10547         remote debuggee.
10548
10549 2019-01-02  Tom Tromey  <tom@tromey.com>
10550
10551         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10552         indentation.
10553         * python/py-frame.c (frapy_older): Remove cast.
10554         (frapy_newer): Likewise.
10555         * python/py-breakpoint.c (local_setattro): Remove cast.
10556         * python/py-arch.c (archpy_name): Remove local variable.
10557         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10558
10559 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10560
10561         * unittests/basic_string_view/element_access/char/empty.cc:
10562         Fix year range in copyright header.
10563
10564 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10565
10566         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10567         Delete.
10568         <operator==>: Update with for removed field.
10569         <hash>: Likewise.
10570         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10571         <isa_features>: ...this.
10572         <abi_features>: New field.
10573         (riscv_isa_flen): Update comment.
10574         (riscv_abi_xlen): New declaration.
10575         (riscv_abi_flen): New declaration.
10576         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10577         isa_features.
10578         (riscv_abi_xlen): New function.
10579         (riscv_isa_flen): Update to get answer from isa_features.
10580         (riscv_abi_flen): New function.
10581         (riscv_has_fp_abi): Update to get answer from abi_features.
10582         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10583         xlen and flen.
10584         (riscv_call_info) <xlen, flen>: Update comment.
10585         (riscv_call_arg_struct): Remove invalid assertions
10586         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10587         is removed.
10588         (riscv_gdbarch_init): Gather isa features and abi features
10589         separately, ensure both match on the gdbarch when reusing an old
10590         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10591         a target with 64-bit float hardware.
10592
10593 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10594
10595         * source.c (search_command_helper): Stop reverse search
10596         when line 1 has been searched.
10597
10598 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10599
10600         * record-full.c (record_full_base_target::close): Rewrite
10601         record_full_core_buf_list free logic.
10602
10603 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10604
10605         * break-catch-syscall.c (print_one_catch_syscall): xfree
10606         the last text.
10607
10608 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10609
10610         * top.c (print_gdb_version): Update Copyright year in version
10611         message.
10612
10613 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10614
10615         Update copyright year range in all GDB files.
10616
10617 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10618
10619         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10620
10621 For older changes see ChangeLog-2018.
10622 \f
10623 Local Variables:
10624 mode: change-log
10625 left-margin: 8
10626 fill-column: 74
10627 version-control: never
10628 coding: utf-8
10629 End:
10630