gdb/ChangeLog

   1 2019-05-01  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-lang.c (ada_value_primitive_field): Treat more fields as
   4         bitfields.
   5
   6 2019-05-01  Tom Tromey  <tromey@adacore.com>
   7
   8         * ada-lang.c (ada_value_assign): Correctly compute starting offset
   9         for big-endian copies.
  10
  11 2019-04-30  Ali Tamur  <tamur@google.com>
  12         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  13         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  14         (read_3_bytes): New function.
  15
  16 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  17
  18         * windows-nat.c (main_thread_id): Delete.
  19         (handle_output_debug_string): Replace main_thread_id by
  20         current_event.dwThreadId.
  21         (fake_create_process): Likewise.
  22         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  23         Do not set main_thread_id.
  24         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  25         current_event.dwThreadId.
  26         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  27
  28 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  29
  30         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  31         Use current_event.dwThreadId instead of main_thread_id.
  32
  33 2019-04-30  Tom Tromey  <tromey@adacore.com>
  34
  35         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  36         (create_excep_cond_exprs): Iterate over program spaces.
  37         (ada_exception_catchpoint_cond_string): Examine all minimal
  38         symbols for exception types.
  39
  40 2019-04-30  Tom Tromey  <tromey@adacore.com>
  41
  42         PR c++/24470:
  43         * dwarf2read.c (process_structure_scope): Handle case where type
  44         has template parameters but no symbol was created.
  45
  46 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  47             Chris January  <chris.january@arm.com>
  48
  49         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  50         qualifier.
  51         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  52
  53 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * f-typeprint.c (f_print_type): Update rules for printing
  56         whitespace.
  57         (f_type_print_varspec_suffix): Likewise.
  58
  59 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  60             Chris January  <chris.january@arm.com>
  61
  62         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  63         function arguments.
  64
  65 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  66
  67         * f-lang.c (build_fortran_types): Change name of void type to
  68         lower case.
  69         * f-typeprint.c (f_type_print_base): Print the name of the void
  70         type, rather than a fixed string.
  71         * f-valprint.c (f_decorations): Use lower case void string.
  72
  73 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  74             Chris January  <chris.january@arm.com>
  75
  76         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  77         types for Fortran.
  78
  79 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  80             Chris January  <chris.january@arm.com>
  81             David Lecomber  <david.lecomber@arm.com>
  82
  83         * f-exp.y (BINOP_INTRINSIC): New token.
  84         (exp): New parser rule handling BINOP_INTRINSIC.
  85         (f77_keywords): Add new builtin procedures.
  86         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  87         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  88         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  89         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  90         (print_unop_subexp_f): New function.
  91         (print_binop_subexp_f): New function.
  92         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  93         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  94         (dump_subexp_body_f): Likewise.
  95         (operator_check_f): Likewise.
  96         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  97         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  98
  99 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 100
 101         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 102         UNOP_KIND.
 103         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 104         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 105         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 106         (operator_length_f): New fuction.
 107         (print_subexp_f): New function.
 108         (op_name_f): New function.
 109         (dump_subexp_body_f): New function.
 110         (operator_check_f): New function.
 111         (exp_descriptor_f): Replace standard expression handling functions
 112         with new functions.
 113         * gdb/fortran-operator.def: New file.
 114         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 115         * gdb/std-operator.def: Remove UNOP_KIND.
 116
 117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 118
 119         * std-operator.def: Remove unbalanced, stray double quote
 120         character.
 121
 122 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 123             Chris January  <chris.january@arm.com>
 124             Daniel Everett  <daniel.everett@arm.com>
 125             Nick Forrington  <nick.forrington@arm.com>
 126             Richard Bunt  <richard.bunt@arm.com>
 127
 128         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 129         of depth when printing anonymous structs or unions.
 130         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 131         Don't print either the top-level value, or the children if the
 132         max-depth is exceeded.
 133         (ppscm_print_children): When printing the key of a map, allow one
 134         extra level of depth.
 135         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 136         print either the top-level value, or the children if the max-depth
 137         is exceeded.
 138         (print_children): When printing the key of a map, allow one extra
 139         level of depth.
 140         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 141         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 142         (user_print_options): Initialise max_depth field.
 143         (val_print_scalar_or_string_type_p): New function.
 144         (val_print): Check to see if the max depth has been reached.
 145         (val_print_check_max_depth): Define new function.
 146         (show_print_max_depth): New function.
 147         (_initialize_valprint): Add 'print max-depth' option.
 148         * valprint.h (struct value_print_options) <max_depth>: New field.
 149         (val_print_check_max_depth): Declare new function.
 150         * NEWS: Document new feature.
 151
 152 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 153
 154         * ada-lang.c (ada_language_defn): Initialise new field.
 155         * c-lang.c (c_is_string_type_p): New function.
 156         (c_language_defn): Initialise new field.
 157         (cplus_language_defn): Initialise new field.
 158         (asm_language_defn): Initialise new field.
 159         (minimal_language_defn): Initialise new field.
 160         * c-lang.h (c_is_string_type_p): Declare new function.
 161         * d-lang.c (d_language_defn): Initialise new field.
 162         * f-lang.c (f_is_string_type_p): New function.
 163         (f_language_defn): Initialise new field.
 164         * go-lang.c (go_is_string_type_p): New function.
 165         (go_language_defn): Initialise new field.
 166         * language.c (default_is_string_type_p): New function.
 167         (unknown_language_defn): Initialise new field.
 168         (auto_language_defn): Initialise new field.
 169         * language.h (struct language_defn) <la_is_string_type_p>: New
 170         member variable.
 171         (default_is_string_type_p): Declare new function.
 172         * m2-lang.c (m2_language_defn): Initialise new field.
 173         * objc-lang.c (objc_language_defn): Initialise new field.
 174         * opencl-lang.c (opencl_language_defn): Initialise new field.
 175         * p-lang.c (pascal_is_string_type_p): New function.
 176         (pascal_language_defn): Initialise new field.
 177         * rust-lang.c (rust_is_string_type_p): New function.
 178         (rust_language_defn): Initialise new field.
 179
 180 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 181
 182         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 183         New field.
 184         * ada-lang.c (ada_language_defn): Initialise new field.
 185         * c-lang.c (c_language_defn): Likewise.
 186         (cplus_language_defn): Likewise.
 187         (asm_language_defn): Likewise.
 188         (minimal_language_defn): Likewise.
 189         * d-lang.c (d_language_defn): Likewise.
 190         * f-lang.c (f_language_defn): Likewise.
 191         * go-lang.c (go_language_defn): Likewise.
 192         * language.c (unknown_language_defn): Likewise.
 193         (auto_language_defn): Likewise.
 194         * m2-lang.c (m2_language_defn): Likewise.
 195         * objc-lang.c (objc_language_defn): Likewise.
 196         * opencl-lang.c (opencl_language_defn): Likewise.
 197         * p-lang.c (pascal_language_defn): Likewise.
 198         * rust-lang.c (rust_language_defn): Likewise.
 199
 200 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * ada-lang.c (ada_is_character_type): Change return type to bool.
 203         (ada_is_string_type): Likewise.
 204         * ada-lang.h (ada_is_character_type): Update declaration
 205         (ada_is_string_type): Likewise.
 206
 207 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 208
 209         Support style in 'frame|thread apply'
 210
 211         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 212         * record.c (record_start, record_stop): Update callers of
 213         execute_command_to_string with false.
 214         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 215         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 216         methods.
 217         (class string_file): New constructor with term_out parameter.
 218         Override methods term_out and can_emit_style_escape.  New member
 219         term_out.
 220         (class stdio_file): Override can_emit_style_escape.
 221         (class tee_file): Override term_out and can_emit_style_escape.
 222         * utils.h (can_emit_style_escape): Remove.
 223         * utils.c (can_emit_style_escape): Likewise.
 224         Update all callers of can_emit_style_escape (SOMESTREAM) to
 225         SOMESTREAM->can_emit_style_escape.
 226         * source-cache.c (source_cache::get_source_lines): Likewise.
 227         * stack.c (frame_apply_command_count): Call execute_command_to_string
 228         passing the term_out characteristic of the current gdb_stdout.
 229         * thread.c (thr_try_catch_cmd): Likewise.
 230         * top.c (execute_command_to_string): pass term_out parameter
 231         to construct the string_file for the command output.
 232         * ui-file.c (term_cli_styling): New function (most code moved
 233         from utils.c can_emit_style_escape).
 234         (string_file::string_file, string_file::can_emit_style_escape,
 235         stdio_file::can_emit_style_escape, tee_file::term_out,
 236         tee_file::can_emit_style_escape): New functions.
 237
 238 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 239
 240         * NEWS: Mention the new set|show may-call-functions.
 241         * infcall.c (may_call_functions_p): New variable.
 242         (show_may_call_functions_p): New function.
 243         (call_function_by_hand_dummy): Throws an error if not
 244         may-call-functions.
 245         (_initialize_infcall): Call add_setshow_boolean_cmd for
 246         may-call-functions.
 247
 248 2019-04-25  Keith Seitz  <keiths@redhat.com>
 249
 250         PR c++/24367
 251         * cp-support.c (inspect_type): Don't attempt substitutions
 252         of symbol with the same name.
 253
 254 2019-04-25  Tom Tromey  <tromey@adacore.com>
 255
 256         PR gdb/24475:
 257         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 258         static.
 259
 260 2019-04-25  Tom Tromey  <tromey@adacore.com>
 261
 262         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 263         rvalue reference.
 264         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 265         (gdb_xml_parser::parse): Use std::move.
 266         * python/python-internal.h (gdbpy_convert_exception): Take a const
 267         reference.
 268         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 269         std::move.
 270         * python/py-utils.c (gdbpy_convert_exception): Take a const
 271         reference.
 272         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 273         Use std::move.
 274         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 275         Use std::move.
 276         * mi/mi-main.c (mi_print_exception): Take a const reference.
 277         * main.c (handle_command_errors): Take a const reference.
 278         * linespec.c (parse_linespec): Use std::move.
 279         * infcall.c (run_inferior_call): Use std::move.
 280         (call_function_by_hand_dummy): Use std::move.
 281         * exec.c (try_open_exec_file): Use std::move.
 282         * exceptions.h (exception_print, exception_fprintf)
 283         (exception_print_same): Update.
 284         * exceptions.c (print_exception, exception_print)
 285         (exception_fprintf, exception_print_same): Change parameters to
 286         const reference.
 287         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 288         * common/new-op.c: Use std::move.
 289         * common/common-exceptions.h (struct gdb_exception): Add move
 290         constructor.
 291         (struct gdb_exception_error, struct gdb_exception_quit, struct
 292         gdb_quit_bad_alloc): Change constructor to move constructor.
 293         (throw_exception): Change parameter to rvalue reference.
 294         * common/common-exceptions.c (throw_exception): Take rvalue
 295         reference.
 296         * cli/cli-interp.c (safe_execute_command): Use std::move.
 297         * breakpoint.c (insert_bp_location, location_to_sals): Use
 298         std::move.
 299
 300 2019-04-25  Tom Tromey  <tromey@adacore.com>
 301
 302         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 303         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 304         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 305         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 306         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 307         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 308         guile/scm-value.c: Use unpack.
 309         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 310         gdbscm_gdb_exception.
 311         (gdbscm_throw_gdb_exception): Likewise.
 312         (struct gdbscm_gdb_exception): New.
 313         (unpack): New function.
 314         (gdbscm_wrap): Use unpack.
 315
 316 2019-04-25  Tom Tromey  <tromey@adacore.com>
 317
 318         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 319         (gdb_rl_callback_handler): Use std::move.
 320         * common/common-exceptions.h (struct gdb_exception): Add move
 321         assignment operator.
 322         (throw_exception_sjlj): Change "exception" to const reference.
 323         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 324         (throw_exception_sjlj): Change "exception" to const reference.
 325
 326 2019-04-25  Tom Tromey  <tromey@adacore.com>
 327
 328         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 329         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 330         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 331         Update.
 332         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 333         Update.
 334         * mi/mi-interp.c (mi_interp::exec): Update.
 335         * linespec.c (parse_linespec): Update.
 336         * infcall.c (run_inferior_call): Update.
 337         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 338         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 339         (gdbscm_lookup_global_symbol): Update.
 340         * guile/scm-param.c (gdbscm_parameter_value): Update.
 341         * guile/scm-frame.c (gdbscm_frame_read_register)
 342         (gdbscm_frame_read_var): Update.
 343         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 344         * exec.c (try_open_exec_file): Update.
 345         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 346         (gdb_rl_callback_handler): Update.
 347         * common/common-exceptions.h (exception_none): Don't declare.
 348         * common/common-exceptions.c (exception_none): Don't define.
 349         (struct catcher) <exception>: Update.
 350         * cli/cli-interp.c (safe_execute_command): Update.
 351         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 352
 353 2019-04-25  Ali Tamur  <tamur@google.com>
 354
 355         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 356         (read_attribute_value): Likewise.
 357         (dwarf2_read_addr_index): Update comment.
 358         (read_str_index): Add DW_FORM_strx.
 359         (dwarf2_string_attr): Likewise.
 360         (dwarf2_const_value_attr): Likewise.
 361         (dump_die_shallow): Likewise.
 362         (dwarf2_fetch_constant_bytes): Likewise.
 363         (skip_form_bytes): Likewise.
 364         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 365
 366 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 367
 368         PR corefiles/11608
 369         PR corefiles/18187
 370         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 371         OFFSET.  Verify if current mapping contains an ELF header.
 372         (linux_find_memory_regions_full): Adjust call to
 373         dump_mapping_p.
 374
 375 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 376             Kang Li <kanglictf@gmail.com>
 377
 378         PR gdb/21600
 379
 380         * dwarf2-frame.c (read_initial_length): Be consistent about using
 381         unsigned representation of length.
 382         (decode_frame_entry_1): Likewise.  Check for wraparound of
 383         end pointer as well as buffer overflow.
 384
 385 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 386
 387         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 388         "vq".
 389
 390 2019-04-24  Tom Tromey  <tromey@adacore.com>
 391
 392         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 393
 394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 395
 396         * s12z-tdep.c (s12z_unwind_pc): Delete.
 397         (s12z_unwind_sp): Delete.
 398         (s12z_gdbarch_init): Don't register deleted functions with
 399         gdbarch.
 400
 401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 402
 403         * rl78-tdep.c (rl78_unwind_sp): Delete.
 404         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 405
 406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 407
 408         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 409         (xstormy16_unwind_pc): Delete.
 410         (xstormy16_dummy_id): Delete.
 411         (xstormy16_gdbarch_init): Don't register deleted functions with
 412         gdbarch.
 413
 414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 415
 416         * vax-tdep.c (vax_unwind_pc): Delete.
 417         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 418
 419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * v850-tdep.c (v850_unwind_sp): Delete.
 422         (v850_unwind_pc): Delete.
 423         (v850_dummy_id): Delete.
 424         (v850_gdbarch_init): Don't register deleted functions with
 425         gdbarch.
 426
 427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 430         (tilegx_unwind_pc): Delete.
 431         (tilegx_unwind_dummy_id): Delete.
 432         (tilegx_gdbarch_init): Don't register deleted functions with
 433         gdbarch.
 434
 435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 438         (tic6x_dummy_id): Delete.
 439         (tic6x_gdbarch_init): Don't register deleted functions with
 440         gdbarch.
 441
 442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * sparc-tdep.c (sparc_unwind_pc): Delete.
 445         (sparc32_gdbarch_init): Don't register deleted function with
 446         gdbarch.
 447
 448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 449
 450         * sh-tdep.c (sh_unwind_sp): Delete.
 451         (sh_unwind_pc): Delete.
 452         (sh_dummy_id): Delete.
 453         (sh_gdbarch_init): Don't register deleted functions with
 454         gdbarch.
 455
 456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 457
 458         * score-tdep.c (score_unwind_sp): Delete.
 459         (score_unwind_pc): Delete.
 460         (score_dummy_id): Delete.
 461         (score_gdbarch_init): Don't register deleted functions with
 462         gdbarch.
 463
 464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * rx-tdep.c (rx_unwind_pc): Delete.
 467         (rx_unwind_sp): Delete.
 468         (rx_dummy_id): Delete.
 469         (rx_gdbarch_init): Don't register deleted functions with
 470         gdbarch.  Update comment.
 471
 472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 475         (rs6000_dummy_id): Delete.
 476         (rs6000_gdbarch_init): Don't register deleted functions with
 477         gdbarch.
 478
 479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 480
 481         * or1k-tdep.c (or1k_dummy_id): Delete.
 482         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 483
 484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 485
 486         * nios2-tdep.c (nios2_dummy_id): Delete.
 487         (nios2_unwind_sp): Delete.
 488         (nios2_gdbarch_init): Don't register deleted functions with
 489         gdbarch.
 490
 491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 492
 493         * nds32-tdep.c (nds32_dummy_id): Delete.
 494         (nds32_unwind_pc): Delete.
 495         (nds32_unwind_sp): Delete.
 496         (nds32_gdbarch_init): Don't register deleted functions with
 497         gdbarch.
 498
 499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 500
 501         * msp430-tdep.c (msp430_unwind_pc): Delete.
 502         (msp430_unwind_sp): Delete.
 503         (msp430_dummy_id): Delete.
 504         (msp430_gdbarch_init): Don't register deleted functions with
 505         gdbarch.
 506
 507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * moxie-tdep.c (moxie_unwind_sp): Delete.
 510         (moxie_unwind_pc): Delete.
 511         (moxie_dummy_id): Delete.
 512         (moxie_gdbarch_init): Don't register deleted functions with
 513         gdbarch.
 514
 515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 516
 517         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 518         (mn10300_unwind_pc): Delete.
 519         (mn10300_unwind_sp): Delete.
 520         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 521         mn10300_unwind_sp.
 522         (mn10300_frame_unwind_init): Don't register deleted functions with
 523         gdbarch.
 524
 525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * mep-tdep.c (mep_unwind_pc): Delete.
 528         (mep_unwind_sp): Delete.
 529         (mep_dummy_id): Delete.
 530         (mep_gdbarch_init): Don't register deleted functions with
 531         gdbarch.
 532
 533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 536         (m68hc11_unwind_sp): Delete.
 537         (m68hc11_gdbarch_init): Don't register deleted functions with
 538         gdbarch.
 539
 540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * m32r-tdep.c (m32r_unwind_sp): Delete.
 543         (m32r_unwind_pc): Delete.
 544         (m32r_dummy_id): Delete.
 545         (m32r_gdbarch_init): Don't register deleted functions with
 546         gdbarch.
 547
 548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * m32c-tdep.c (m32c_unwind_pc): Delete.
 551         (m32c_unwind_sp): Delete.
 552         (m32c_dummy_id): Delete.
 553         (m32c_gdbarch_init): Don't register deleted functions with
 554         gdbarch.
 555
 556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 559         (lm32_unwind_pc): Delete.
 560         (lm32_dummy_id): Delete.
 561         (lm32_gdbarch_init): Don't register deleted functions with
 562         gdbarch.
 563
 564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 565
 566         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 567         (iq2000_unwind_pc): Delete.
 568         (iq2000_dummy_id): Delete.
 569         (iq2000_gdbarch_init): Don't register deleted functions with
 570         gdbarch.
 571
 572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * nds32-tdep.c (nds32_type_align): Delete.
 575         (nds32_push_dummy_call): Use type_align instead.
 576
 577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * arm-tdep.c (arm_type_align): Only handle vector override case.
 580         (arm_push_dummy_call): Use type_align.
 581         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 582
 583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 586         case.
 587         (pass_on_stack): Use type_align.
 588         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 589         function.
 590
 591 2019-04-23  Tom Tromey  <tromey@adacore.com>
 592
 593         * dwarf2read.c (line_header::file_name_at): Remove unused
 594         overload.
 595
 596 2019-04-23  Tom de Vries  <tdevries@suse.de>
 597
 598         PR gdb/24438
 599         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 600         invocation.
 601
 602
 603 2019-03-27  Ali Tamur  <tamur@google.com>
 604
 605         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 606         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 607         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 608         (dwarf_expr_context::get_addr_index): Likewise
 609         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 610         (symbol_needs_eval_context::get_addr_index): Likewise
 611         (disassemble_dwarf_expression): Add DW_OP_addrx
 612         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 613         (read_cutu_die_from_dwo): Update comment
 614         (skip_one_die): Add DW_FORM_addrx
 615         (read_attribute_value): Likewise
 616         (var_decode_location): Add DW_OP_addrx
 617         (dwarf2_const_value_attr): Add DW_FORM_addrx
 618         (dump_die_shallow): Likewise
 619         (dwarf2_fetch_constant_bytes): Likewise
 620         (decode_locdesc): Add DW_OP_addrx
 621         (skip_form_bytes): Add DW_FORM_addrx
 622
 623 2019-04-22  Ali Tamur  <tamur@google.com>
 624
 625         * MAINTAINERS (Write After Approval): Add self.
 626
 627 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 628
 629         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 630         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 631         (open_symbol_file_object): Likewise.
 632         (svr4_default_sos): Add info parameter.
 633         (svr4_read_so_list): Likewise.
 634         (svr4_current_sos_direct): Adjust functions calls to pass down
 635         info.
 636         (svr4_current_sos_1): Add info parameter.
 637         (svr4_current_sos): Call get_svr4_info, pass info down to
 638         svr4_current_sos_1.
 639         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 640         get_svr4_info.
 641         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 642         get_svr4_info.
 643         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 644         to get_svr4_info.
 645         (probes_table_remove_objfile_probes): Likewise.
 646         (register_solib_event_probe): Add info parameter.
 647         (solist_update_incremental): Pass info parameter down to
 648         svr4_read_so_list.
 649         (disable_probes_interface): Add info parameter.
 650         (svr4_handle_solib_event): Pass current_program_space to
 651         get_svr4_info.  Adjust disable_probes_interface cleanup.
 652         (svr4_create_probe_breakpoints): Add info parameter, pass it
 653         down to register_solib_event_probe.
 654         (svr4_create_solib_event_breakpoints): Add info parameter,
 655         pass it down to svr4_create_probe_breakpoints.
 656         (enable_break): Pass info down to
 657         svr4_create_solib_event_breakpoints.
 658         (svr4_solib_create_inferior_hook): Pass current_program_space to
 659         get_svr4_info.
 660         (svr4_clear_solib): Likewise.
 661
 662 2019-04-22  Pedro Alves  <palves@redhat.com>
 663
 664         * solib-svr4.c (svr4_free_objfile_observer): New.
 665         (probe_and_action::objfile): New field.
 666         (probes_table_htab_remove_objfile_probes)
 667         (probes_table_remove_objfile_probes): New functions.
 668         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 669         in the new probe_and_action.  Don't store the probe in 'lookup'.
 670         (svr4_create_probe_breakpoints): Pass objfile to
 671         register_solib_event_probe.
 672         (_initialize_svr4_solib): Register a free_objfile observer.
 673
 674 2019-04-19  Tom Tromey  <tom@tromey.com>
 675
 676         * common/queue.h: Remove.
 677
 678 2019-04-19  Tom Tromey  <tom@tromey.com>
 679
 680         * event-loop.c: Don't include "common/queue.h".
 681
 682 2019-04-19  Tom Tromey  <tom@tromey.com>
 683
 684         * remote.c (remote_target): Use delete.
 685         * remote-notif.h: Include <list>, not "common/queue.h".
 686         (notif_client_p): Remove typedef.
 687         (remote_notif_state): Add constructor, destructor, initializer.
 688         <notif_queue>: Now a std::list.
 689         (remote_notif_state_xfree): Don't declare.
 690         * remote-notif.c (remote_notif_process, handle_notification)
 691         (remote_notif_state_allocate): Update.
 692         (~remote_notif_state): Rename from remote_notif_state_xfree.
 693
 694 2019-04-19  Tom Tromey  <tom@tromey.com>
 695
 696         * symfile.c (reread_symbols): Update.
 697         * objfiles.c (objfile_register_static_link)
 698         (objfile_lookup_static_link): Update
 699         (~objfile) Don't delete static_links.
 700         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 701
 702 2019-04-19  Tom Tromey  <tom@tromey.com>
 703
 704         * type-stack.h (struct type_stack) <insert>: Constify string.
 705         * type-stack.c (type_stack::insert): Constify string.
 706         * gdbtypes.h (lookup_template_type): Update.
 707         (address_space_name_to_int): Update.
 708         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 709         const.
 710         (lookup_template_type): Make name const.
 711         * c-exp.y: Update rules.
 712         (lex_one_token, classify_name, classify_inner_name)
 713         (c_print_token): Update.
 714         * p-exp.y: Update rules.
 715         (yylex): Update.
 716         * f-exp.y: Update rules.
 717         (yylex): Update.
 718         * d-exp.y: Update rules.
 719         (lex_one_token, classify_name, classify_inner_name): Update.
 720         * parse.c (write_dollar_variable, copy_name): Return std::string.
 721         * parser-defs.h (copy_name): Change return type.
 722         * m2-exp.y: Update rules.
 723         (yylex): Update.
 724         * go-exp.y (lex_one_token): Update.
 725         Update rules.
 726         (classify_unsafe_function, classify_packaged_name)
 727         (classify_name, yylex): Update.
 728
 729 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 730
 731         * configure.ac: add --enable-source-highlight switch.
 732         * configure: Regenerate.
 733         * top.c (print_gdb_version): plumb --enable-source-highlight
 734         status to "show configuration".
 735
 736 2019-04-19  Tom Tromey  <tromey@adacore.com>
 737
 738         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 739         Check ADA_TYPE_P.
 740         (empty_record, ada_template_to_fixed_record_type_1)
 741         (template_to_static_fixed_type)
 742         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 743         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 744         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 745         macros.
 746
 747 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 748
 749         PR symtab/24423:
 750         * source.c (print_source_lines_base): Advance "iter" when a
 751         control character is seen.
 752
 753 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 754
 755         * inferior.h (struct infcall_suspend_state_deleter):
 756         Catch exception in destructor to avoid crash.
 757
 758 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 759
 760         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 761         close to the add_com "shell".
 762
 763 2019-04-18  Tom Tromey  <tromey@adacore.com>
 764
 765         * process-stratum-target.h (class process_stratum_target)
 766         <stratum>: Add "final".
 767
 768 2019-04-17  Tom Tromey  <tromey@adacore.com>
 769
 770         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 771         against nullptr before use.
 772
 773 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 774
 775         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 776
 777 2019-04-17  Jim Wilson  <jimw@sifive.com>
 778             Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 781         code read might fail, assume 4-byte breakpoint in that case.
 782
 783 2019-04-15  Leszek Swirski  <leszeks@google.com>
 784
 785         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 786         rather than a hand-rolled POD check when checking for forced MEMORY
 787         classification.
 788
 789 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 790
 791         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 792         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 793         function.
 794         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 795         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 796         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 797         declaration.
 798
 799 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 800
 801         * aarch64-linux-nat.c
 802         (aarch64_linux_nat_target::thread_architecture): Add override.
 803         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 804         each VQ.
 805
 806 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 807
 808         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 809
 810 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 813         target types of size 96-bits, add some additional comments, and
 814         check that the builtin type we found was the correct size.
 815
 816 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 817
 818         * utils.c (prompt_for_continue): Don't restore the styling at the
 819         end, as applied_style has the wrong value.  This fixes styling in
 820         long lists of file names that are interrupted by the "Continue?"
 821         prompt.
 822
 823 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 826         * c-lang.c (c_language_defn): Likewise.
 827         (cplus_language_defn): Likewise.
 828         (asm_language_defn): Likewise.
 829         (minimal_language_defn): Likewise.
 830         * d-lang.c (d_language_defn): Likewise.
 831         * f-lang.c (f_language_defn): Likewise.
 832         * go-lang.c (go_language_defn): Likewise.
 833         * language.c (unknown_language_defn): Likewise.
 834         (auto_language_defn): Likewise.
 835         * language.h (struct language_defn): Remove la_magic field.
 836         (LANG_MAGIC): Delete.
 837         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 838         * objc-lang.c (objc_language_defn): Likewise.
 839         * opencl-lang.c (opencl_language_defn): Likewise.
 840         * p-lang.c (pascal_language_defn): Likewise.
 841         * rust-lang.c (rust_language_defn): Likewise.
 842
 843 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * riscv-tdep.c (riscv_type_align): New function.
 846         (riscv_type_alignment): Delete.
 847         (riscv_arg_location): Use 'type_align'.
 848         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 849
 850 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 851
 852         * gdbtypes.c (type_align): A struct with no non-static fields also
 853         has alignment of 1.
 854
 855 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 858         component to 0.
 859         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 860         member.
 861         (riscv_struct_info::analyse): New implementation using new
 862         analyse_inner member function.
 863         (riscv_struct_info::field_offset): New member function.
 864         (riscv_struct_info::m_offsets): New member variable.
 865         (riscv_struct_info::analyse_inner): New private member function,
 866         takes the old implementation of riscv_struct_info::analyse but
 867         extended to track field offsets.
 868         (riscv_call_arg_struct): Update the struct folding special cases
 869         to handle cases where empty C++ structs, which are non-zero
 870         length, are found.
 871         (riscv_arg_location): Initialise the length of each location, a
 872         non-zero length now indicates the location is in use.
 873         (riscv_push_dummy_call): Allow for the first location having a
 874         non-zero offset when setting up arguments.
 875         (riscv_return_value): Likewise, but for return values.
 876
 877 2019-04-11  Tom Tromey  <tromey@adacore.com>
 878
 879         * utils.c (internal_vproblem): Make "msg" const.
 880
 881 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 882
 883         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 884         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 885         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 886         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 887
 888 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 889
 890         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 891         function.
 892         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 893         of amd64_collect_native_gregset.
 894         (amd64_linux_nat_target::store_registers): Likewise.
 895
 896 2019-04-10  Tom Tromey  <tom@tromey.com>
 897
 898         * symtab.c (lookup_global_symbol_from_objfile)
 899         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 900         * objfiles.h (class separate_debug_iterator): New.
 901         (class separate_debug_range): New.
 902         (struct objfile) <separate_debug_objfiles>: New method.
 903         (objfile_separate_debug_iterate): Don't declare.
 904         * objfiles.c (separate_debug_iterator::operator++): Rename from
 905         objfile_separate_debug_iterate.
 906         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 907         iterator.
 908         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 909         iterator.
 910
 911 2019-04-10  Tom Tromey  <tom@tromey.com>
 912
 913         * symfile.c (reread_symbols): Remove old comment.
 914         * objfiles.c (free_all_objfiles): Fix a typo.
 915
 916 2019-04-10  Tom Tromey  <tom@tromey.com>
 917
 918         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 919         * minsyms.c (lookup_minimal_symbol): Use foreach.
 920         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 921         (lookup_minimal_symbol_solib_trampoline): Likewise.
 922         * symfile.c (reread_symbols): Use foreach.
 923
 924 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 925             Tom Tromey  <tromey@adacore.com>
 926
 927         PR rust/24414:
 928         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 929         (rust_lex_int_test): Change "value" to be LONGEST.
 930         (rust_lex_tests): Add test for long integer literal.
 931
 932 2019-04-09  Tom Tromey  <tromey@adacore.com>
 933
 934         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 935         to bool.
 936         (extended_remote_target::attach): Update.
 937         (remote_target::remote_notice_new_inferior): Update.
 938         (remote_target::add_current_inferior_and_thread): Update.
 939         * inferior.c (exit_inferior_1): Use "false".
 940         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 941
 942 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 943
 944         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 945         the "start" command.
 946
 947 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 948
 949         * python/py-inferior.c (infpy_thread_from_thread_handle):
 950         Adjust comments to reflect renaming of thread_from_thread_handle
 951         to thread_from_handle.  Adjust keywords.  Fix type error message.
 952         (inferior_object_methods): Add thread_from_handle.  Retain
 953         thread_from_thread_handle, but mark it as deprecated.
 954
 955 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 956
 957         * gdbthread.h (find_thread_by_handle): Revise declaration.
 958         * thread.c (find_thread_by_handle): Likewise.  Adjust
 959         implementation too.
 960         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 961         support for buffer objects as handles.
 962
 963 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 964
 965         * python/py-infthread.c (thpy_thread_handle): New function.
 966         (thread_object_methods): Register thpy_thread_handle.
 967
 968 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 969
 970         * gdbthread.h (thread_to_thread_handle): Declare.
 971         * thread.c (gdbtypes.h): Include.
 972         (thread_to_thread_handle): New function.
 973
 974         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 975         (target_thread_info_to_thread_handle): Declare.
 976         * target.c (target_thread_info_to_thread_handle): New function.
 977         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 978         * target-delegates.c: Regenerate.
 979
 980         * linux-thread-db.c (class thread_db_target): Add method
 981         thread_info_to_thread_handle.
 982         (thread_db_target::thread_info_to_thread_handle): Define.
 983         * remote.c (class remote_target): Add new method
 984         thread_info_to_thread_handle.
 985         (remote_target::thread_info_to_thread_handle): Define.
 986
 987 2019-04-08  Pedro Alves  <palves@redhat.com>
 988
 989         * common/common-exceptions.c (throw_exception): Don't create
 990         named object to throw; throw directly.
 991         (throw_it): Likewise.  Don't initialize gdb_exception::message
 992         here, with new; pass FMT and AP to the ctor instead.
 993         * common/common-exceptions.h: Include <string>.
 994         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 995         const char *, va_list)): New ctor.  Use std::make_shared.
 996         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 997         errors)): Delete.
 998         (gdb_exception_error::gdb_exception_error(enum errors, const char
 999         *, va_list)): New.
1000         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1001         Add assertion.
1002         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1003         errors)): Delete.
1004         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1005         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1006         Add assertion.
1007
1008 2019-04-08  Tom Tromey  <tom@tromey.com>
1009
1010         * valops.c (value_rtti_indirect_type): Replace throw_exception
1011         with throw.
1012         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1013         with throw.
1014         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1015         throw.
1016         * target.c (target_translate_tls_address): Replace throw_exception
1017         with throw.
1018         * stack.c (frame_apply_command_count): Replace throw_exception
1019         with throw.
1020         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1021         throw.
1022         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1023         with throw.
1024         * rs6000-tdep.c (rs6000_frame_cache)
1025         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1026         * remote.c: Replace throw_exception with throw.
1027         * record-full.c (record_full_message, record_full_wait_1)
1028         (record_full_restore): Replace throw_exception with throw.
1029         * record-btrace.c:
1030         (get_thread_current_frame_id, record_btrace_start_replaying)
1031         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1032         (cmd_record_btrace_start): Replace throw_exception with throw.
1033         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1034         throw.
1035         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1036         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1037         * linespec.c:
1038         (find_linespec_symbols): Replace throw_exception with throw.
1039         * infrun.c (displaced_step_prepare, resume): Replace
1040         throw_exception with throw.
1041         * infcmd.c (post_create_inferior): Replace throw_exception with
1042         throw.
1043         * inf-loop.c (inferior_event_handler): Replace throw_exception
1044         with throw.
1045         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1046         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1047         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1048         (get_prev_frame_always, get_frame_pc_if_available)
1049         (get_frame_address_in_block_if_available, get_frame_language):
1050         Replace throw_exception with throw.
1051         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1052         throw_exception with throw.
1053         * eval.c (fetch_subexp_value, evaluate_var_value)
1054         (evaluate_funcall, evaluate_subexp_standard): Replace
1055         throw_exception with throw.
1056         * dwarf2loc.c (call_site_find_chain)
1057         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1058         Replace throw_exception with throw.
1059         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1060         with throw.
1061         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1062         throw.
1063         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1064         * completer.c (complete_line_internal): Replace throw_exception
1065         with throw.
1066         * compile/compile-object-run.c (compile_object_run): Replace
1067         throw_exception with throw.
1068         * cli/cli-script.c (process_next_line): Replace throw_exception
1069         with throw.
1070         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1071         (btrace_enable, btrace_maint_update_pt_packets): Replace
1072         throw_exception with throw.
1073         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1074         throw_exception with throw.
1075         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1076         throw_exception with throw.
1077         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1078         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1079         * aarch64-tdep.c (aarch64_make_prologue_cache)
1080         (aarch64_make_stub_cache): Replace throw_exception with throw.
1081
1082 2019-04-08  Tom Tromey  <tom@tromey.com>
1083
1084         * common/common-exceptions.c (throw_exception): Rename from
1085         throw_exception_cxx.  Remove old copy.  Make argument const.
1086         (throw_it): Create and throw exception objects directly.
1087         * common/common-exceptions.h (throw_exception): Make argument
1088         const.
1089         (struct gdb_exception_error): Add constructor.
1090         (struct gdb_exception_quit): Add constructor.
1091
1092 2019-04-08  Tom Tromey  <tom@tromey.com>
1093
1094         * common/common-exceptions.h (exception_rethrow): Don't declare.
1095         (TRY_SJLJ): Update comment.
1096         (TRY, CATCH, END_CATCH): Remove.
1097         * common/common-exceptions.c (exception_rethrow): Remove.
1098
1099 2019-04-08  Tom Tromey  <tom@tromey.com>
1100
1101         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1102         Remove.
1103         (gdb_exception_error): Rename from
1104         gdb_exception_RETURN_MASK_ERROR.
1105         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1106         (gdb_quit_bad_alloc): Update.
1107         * aarch64-tdep.c: Update.
1108         * ada-lang.c: Update.
1109         * ada-typeprint.c: Update.
1110         * ada-valprint.c: Update.
1111         * amd64-tdep.c: Update.
1112         * arch-utils.c: Update.
1113         * break-catch-throw.c: Update.
1114         * breakpoint.c: Update.
1115         * btrace.c: Update.
1116         * c-varobj.c: Update.
1117         * cli/cli-cmds.c: Update.
1118         * cli/cli-interp.c: Update.
1119         * cli/cli-script.c: Update.
1120         * common/common-exceptions.c: Update.
1121         * common/new-op.c: Update.
1122         * common/selftest.c: Update.
1123         * compile/compile-c-symbols.c: Update.
1124         * compile/compile-cplus-symbols.c: Update.
1125         * compile/compile-object-load.c: Update.
1126         * compile/compile-object-run.c: Update.
1127         * completer.c: Update.
1128         * corelow.c: Update.
1129         * cp-abi.c: Update.
1130         * cp-support.c: Update.
1131         * cp-valprint.c: Update.
1132         * darwin-nat.c: Update.
1133         * disasm-selftests.c: Update.
1134         * dtrace-probe.c: Update.
1135         * dwarf-index-cache.c: Update.
1136         * dwarf-index-write.c: Update.
1137         * dwarf2-frame-tailcall.c: Update.
1138         * dwarf2-frame.c: Update.
1139         * dwarf2loc.c: Update.
1140         * dwarf2read.c: Update.
1141         * eval.c: Update.
1142         * event-loop.c: Update.
1143         * event-top.c: Update.
1144         * exec.c: Update.
1145         * f-valprint.c: Update.
1146         * fbsd-tdep.c: Update.
1147         * frame-unwind.c: Update.
1148         * frame.c: Update.
1149         * gdbtypes.c: Update.
1150         * gnu-v3-abi.c: Update.
1151         * guile/guile-internal.h: Update.
1152         * guile/scm-block.c: Update.
1153         * guile/scm-breakpoint.c: Update.
1154         * guile/scm-cmd.c: Update.
1155         * guile/scm-disasm.c: Update.
1156         * guile/scm-frame.c: Update.
1157         * guile/scm-lazy-string.c: Update.
1158         * guile/scm-math.c: Update.
1159         * guile/scm-param.c: Update.
1160         * guile/scm-ports.c: Update.
1161         * guile/scm-pretty-print.c: Update.
1162         * guile/scm-symbol.c: Update.
1163         * guile/scm-symtab.c: Update.
1164         * guile/scm-type.c: Update.
1165         * guile/scm-value.c: Update.
1166         * i386-linux-tdep.c: Update.
1167         * i386-tdep.c: Update.
1168         * inf-loop.c: Update.
1169         * infcall.c: Update.
1170         * infcmd.c: Update.
1171         * infrun.c: Update.
1172         * jit.c: Update.
1173         * language.c: Update.
1174         * linespec.c: Update.
1175         * linux-fork.c: Update.
1176         * linux-nat.c: Update.
1177         * linux-tdep.c: Update.
1178         * linux-thread-db.c: Update.
1179         * main.c: Update.
1180         * mi/mi-cmd-break.c: Update.
1181         * mi/mi-cmd-stack.c: Update.
1182         * mi/mi-interp.c: Update.
1183         * mi/mi-main.c: Update.
1184         * objc-lang.c: Update.
1185         * p-valprint.c: Update.
1186         * parse.c: Update.
1187         * ppc-linux-tdep.c: Update.
1188         * printcmd.c: Update.
1189         * python/py-arch.c: Update.
1190         * python/py-breakpoint.c: Update.
1191         * python/py-cmd.c: Update.
1192         * python/py-finishbreakpoint.c: Update.
1193         * python/py-frame.c: Update.
1194         * python/py-framefilter.c: Update.
1195         * python/py-gdb-readline.c: Update.
1196         * python/py-inferior.c: Update.
1197         * python/py-infthread.c: Update.
1198         * python/py-lazy-string.c: Update.
1199         * python/py-linetable.c: Update.
1200         * python/py-objfile.c: Update.
1201         * python/py-param.c: Update.
1202         * python/py-prettyprint.c: Update.
1203         * python/py-progspace.c: Update.
1204         * python/py-record-btrace.c: Update.
1205         * python/py-record.c: Update.
1206         * python/py-symbol.c: Update.
1207         * python/py-type.c: Update.
1208         * python/py-unwind.c: Update.
1209         * python/py-utils.c: Update.
1210         * python/py-value.c: Update.
1211         * python/python.c: Update.
1212         * record-btrace.c: Update.
1213         * record-full.c: Update.
1214         * remote-fileio.c: Update.
1215         * remote.c: Update.
1216         * riscv-tdep.c: Update.
1217         * rs6000-aix-tdep.c: Update.
1218         * rs6000-tdep.c: Update.
1219         * rust-exp.y: Update.
1220         * rust-lang.c: Update.
1221         * s390-tdep.c: Update.
1222         * selftest-arch.c: Update.
1223         * solib-dsbt.c: Update.
1224         * solib-frv.c: Update.
1225         * solib-spu.c: Update.
1226         * solib-svr4.c: Update.
1227         * solib.c: Update.
1228         * sparc64-linux-tdep.c: Update.
1229         * stack.c: Update.
1230         * symfile-mem.c: Update.
1231         * symmisc.c: Update.
1232         * target.c: Update.
1233         * thread.c: Update.
1234         * top.c: Update.
1235         * tracefile-tfile.c: Update.
1236         * tui/tui.c: Update.
1237         * typeprint.c: Update.
1238         * unittests/cli-utils-selftests.c: Update.
1239         * unittests/parse-connection-spec-selftests.c: Update.
1240         * valops.c: Update.
1241         * valprint.c: Update.
1242         * value.c: Update.
1243         * varobj.c: Update.
1244         * windows-nat.c: Update.
1245         * x86-linux-nat.c: Update.
1246         * xml-support.c: Update.
1247
1248 2019-04-08  Tom Tromey  <tom@tromey.com>
1249
1250         * xml-support.c: Use C++ exception handling.
1251         * x86-linux-nat.c: Use C++ exception handling.
1252         * windows-nat.c: Use C++ exception handling.
1253         * varobj.c: Use C++ exception handling.
1254         * value.c: Use C++ exception handling.
1255         * valprint.c: Use C++ exception handling.
1256         * valops.c: Use C++ exception handling.
1257         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1258         handling.
1259         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1260         * typeprint.c: Use C++ exception handling.
1261         * tui/tui.c: Use C++ exception handling.
1262         * tracefile-tfile.c: Use C++ exception handling.
1263         * top.c: Use C++ exception handling.
1264         * thread.c: Use C++ exception handling.
1265         * target.c: Use C++ exception handling.
1266         * symmisc.c: Use C++ exception handling.
1267         * symfile-mem.c: Use C++ exception handling.
1268         * stack.c: Use C++ exception handling.
1269         * sparc64-linux-tdep.c: Use C++ exception handling.
1270         * solib.c: Use C++ exception handling.
1271         * solib-svr4.c: Use C++ exception handling.
1272         * solib-spu.c: Use C++ exception handling.
1273         * solib-frv.c: Use C++ exception handling.
1274         * solib-dsbt.c: Use C++ exception handling.
1275         * selftest-arch.c: Use C++ exception handling.
1276         * s390-tdep.c: Use C++ exception handling.
1277         * rust-lang.c: Use C++ exception handling.
1278         * rust-exp.y: Use C++ exception handling.
1279         * rs6000-tdep.c: Use C++ exception handling.
1280         * rs6000-aix-tdep.c: Use C++ exception handling.
1281         * riscv-tdep.c: Use C++ exception handling.
1282         * remote.c: Use C++ exception handling.
1283         * remote-fileio.c: Use C++ exception handling.
1284         * record-full.c: Use C++ exception handling.
1285         * record-btrace.c: Use C++ exception handling.
1286         * python/python.c: Use C++ exception handling.
1287         * python/py-value.c: Use C++ exception handling.
1288         * python/py-utils.c: Use C++ exception handling.
1289         * python/py-unwind.c: Use C++ exception handling.
1290         * python/py-type.c: Use C++ exception handling.
1291         * python/py-symbol.c: Use C++ exception handling.
1292         * python/py-record.c: Use C++ exception handling.
1293         * python/py-record-btrace.c: Use C++ exception handling.
1294         * python/py-progspace.c: Use C++ exception handling.
1295         * python/py-prettyprint.c: Use C++ exception handling.
1296         * python/py-param.c: Use C++ exception handling.
1297         * python/py-objfile.c: Use C++ exception handling.
1298         * python/py-linetable.c: Use C++ exception handling.
1299         * python/py-lazy-string.c: Use C++ exception handling.
1300         * python/py-infthread.c: Use C++ exception handling.
1301         * python/py-inferior.c: Use C++ exception handling.
1302         * python/py-gdb-readline.c: Use C++ exception handling.
1303         * python/py-framefilter.c: Use C++ exception handling.
1304         * python/py-frame.c: Use C++ exception handling.
1305         * python/py-finishbreakpoint.c: Use C++ exception handling.
1306         * python/py-cmd.c: Use C++ exception handling.
1307         * python/py-breakpoint.c: Use C++ exception handling.
1308         * python/py-arch.c: Use C++ exception handling.
1309         * printcmd.c: Use C++ exception handling.
1310         * ppc-linux-tdep.c: Use C++ exception handling.
1311         * parse.c: Use C++ exception handling.
1312         * p-valprint.c: Use C++ exception handling.
1313         * objc-lang.c: Use C++ exception handling.
1314         * mi/mi-main.c: Use C++ exception handling.
1315         * mi/mi-interp.c: Use C++ exception handling.
1316         * mi/mi-cmd-stack.c: Use C++ exception handling.
1317         * mi/mi-cmd-break.c: Use C++ exception handling.
1318         * main.c: Use C++ exception handling.
1319         * linux-thread-db.c: Use C++ exception handling.
1320         * linux-tdep.c: Use C++ exception handling.
1321         * linux-nat.c: Use C++ exception handling.
1322         * linux-fork.c: Use C++ exception handling.
1323         * linespec.c: Use C++ exception handling.
1324         * language.c: Use C++ exception handling.
1325         * jit.c: Use C++ exception handling.
1326         * infrun.c: Use C++ exception handling.
1327         * infcmd.c: Use C++ exception handling.
1328         * infcall.c: Use C++ exception handling.
1329         * inf-loop.c: Use C++ exception handling.
1330         * i386-tdep.c: Use C++ exception handling.
1331         * i386-linux-tdep.c: Use C++ exception handling.
1332         * guile/scm-value.c: Use C++ exception handling.
1333         * guile/scm-type.c: Use C++ exception handling.
1334         * guile/scm-symtab.c: Use C++ exception handling.
1335         * guile/scm-symbol.c: Use C++ exception handling.
1336         * guile/scm-pretty-print.c: Use C++ exception handling.
1337         * guile/scm-ports.c: Use C++ exception handling.
1338         * guile/scm-param.c: Use C++ exception handling.
1339         * guile/scm-math.c: Use C++ exception handling.
1340         * guile/scm-lazy-string.c: Use C++ exception handling.
1341         * guile/scm-frame.c: Use C++ exception handling.
1342         * guile/scm-disasm.c: Use C++ exception handling.
1343         * guile/scm-cmd.c: Use C++ exception handling.
1344         * guile/scm-breakpoint.c: Use C++ exception handling.
1345         * guile/scm-block.c: Use C++ exception handling.
1346         * guile/guile-internal.h: Use C++ exception handling.
1347         * gnu-v3-abi.c: Use C++ exception handling.
1348         * gdbtypes.c: Use C++ exception handling.
1349         * frame.c: Use C++ exception handling.
1350         * frame-unwind.c: Use C++ exception handling.
1351         * fbsd-tdep.c: Use C++ exception handling.
1352         * f-valprint.c: Use C++ exception handling.
1353         * exec.c: Use C++ exception handling.
1354         * event-top.c: Use C++ exception handling.
1355         * event-loop.c: Use C++ exception handling.
1356         * eval.c: Use C++ exception handling.
1357         * dwarf2read.c: Use C++ exception handling.
1358         * dwarf2loc.c: Use C++ exception handling.
1359         * dwarf2-frame.c: Use C++ exception handling.
1360         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1361         * dwarf-index-write.c: Use C++ exception handling.
1362         * dwarf-index-cache.c: Use C++ exception handling.
1363         * dtrace-probe.c: Use C++ exception handling.
1364         * disasm-selftests.c: Use C++ exception handling.
1365         * darwin-nat.c: Use C++ exception handling.
1366         * cp-valprint.c: Use C++ exception handling.
1367         * cp-support.c: Use C++ exception handling.
1368         * cp-abi.c: Use C++ exception handling.
1369         * corelow.c: Use C++ exception handling.
1370         * completer.c: Use C++ exception handling.
1371         * compile/compile-object-run.c: Use C++ exception handling.
1372         * compile/compile-object-load.c: Use C++ exception handling.
1373         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1374         * compile/compile-c-symbols.c: Use C++ exception handling.
1375         * common/selftest.c: Use C++ exception handling.
1376         * common/new-op.c: Use C++ exception handling.
1377         * cli/cli-script.c: Use C++ exception handling.
1378         * cli/cli-interp.c: Use C++ exception handling.
1379         * cli/cli-cmds.c: Use C++ exception handling.
1380         * c-varobj.c: Use C++ exception handling.
1381         * btrace.c: Use C++ exception handling.
1382         * breakpoint.c: Use C++ exception handling.
1383         * break-catch-throw.c: Use C++ exception handling.
1384         * arch-utils.c: Use C++ exception handling.
1385         * amd64-tdep.c: Use C++ exception handling.
1386         * ada-valprint.c: Use C++ exception handling.
1387         * ada-typeprint.c: Use C++ exception handling.
1388         * ada-lang.c: Use C++ exception handling.
1389         * aarch64-tdep.c: Use C++ exception handling.
1390
1391 2019-04-08  Tom Tromey  <tom@tromey.com>
1392
1393         * xml-support.c (gdb_xml_parser::parse): Update.
1394         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1395         * value.c (show_convenience): Update.
1396         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1397         (test_parse_flags_qcs): Update.
1398         * thread.c (thr_try_catch_cmd): Update.
1399         * target.c (target_translate_tls_address): Update.
1400         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1401         (info_frame_command_core, frame_apply_command_count): Update.
1402         * rust-exp.y (rust_lex_exception_test): Update.
1403         * riscv-tdep.c (riscv_print_one_register_info): Update.
1404         * remote.c (remote_target::enable_btrace): Update.
1405         * record-btrace.c (record_btrace_enable_warn): Update.
1406         * python/py-utils.c (gdbpy_convert_exception): Update.
1407         * printcmd.c (do_one_display, print_variable_and_value): Update.
1408         * mi/mi-main.c (mi_print_exception): Update.
1409         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1410         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1411         * linux-nat.c (linux_nat_target::attach): Update.
1412         * linux-fork.c (class scoped_switch_fork_info): Update.
1413         * infrun.c (displaced_step_prepare): Update.
1414         * infcall.c (call_function_by_hand_dummy): Update.
1415         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1416         * gnu-v3-abi.c (print_one_vtable): Update.
1417         * frame.c (get_prev_frame_always): Update.
1418         * f-valprint.c (info_common_command_for_block): Update.
1419         * exec.c (try_open_exec_file): Update.
1420         * exceptions.c (print_exception, exception_print)
1421         (exception_fprintf, exception_print_same): Update.
1422         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1423         * dwarf-index-cache.c (index_cache::store)
1424         (index_cache::lookup_gdb_index): Update.
1425         * darwin-nat.c (maybe_cache_shell): Update.
1426         * cp-valprint.c (cp_print_value_fields): Update.
1427         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1428         (gcc_cplus_symbol_address): Update.
1429         * compile/compile-c-symbols.c (gcc_convert_symbol)
1430         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1431         * common/selftest.c: Update.
1432         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1433         a std::string.
1434         (exception_try_scope_entry, exception_try_scope_exit): Don't
1435         declare.
1436         (struct exception_try_scope): Remove.
1437         (TRY): Don't use exception_try_scope.
1438         (struct gdb_exception): Add constructor, operator=.
1439         <what>: New method.
1440         (struct gdb_exception_RETURN_MASK_ALL)
1441         (struct gdb_exception_RETURN_MASK_ERROR)
1442         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1443         (struct gdb_quit_bad_alloc): Update.
1444         * common/common-exceptions.c (exception_none): Change
1445         initializer.
1446         (struct catcher) <state, exception>: Initialize inline.
1447         <prev>: Remove member.
1448         (current_catcher): Remove.
1449         (catchers): New global.
1450         (exceptions_state_mc_init): Simplify.
1451         (catcher_pop): Remove.
1452         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1453         (try_scope_depth, exception_try_scope_entry)
1454         (exception_try_scope_exit): Remove.
1455         (throw_exception_sjlj): Update.
1456         (exception_messages, exception_messages_size): Remove.
1457         (throw_it): Simplify.
1458         (gdb_exception_sliced_copy): Remove.
1459         (throw_exception_cxx): Update.
1460         * cli/cli-script.c (script_from_file): Update.
1461         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1462         Update.
1463         * ada-valprint.c (ada_val_print): Update.
1464         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1465         (create_excep_cond_exprs): Update.
1466
1467 2019-04-08  Tom Tromey  <tom@tromey.com>
1468
1469         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1470         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1471         (TRY, CATCH, END_CATCH): Remove some definitions.
1472         * common/common-exceptions.c: Don't use GDB_XCPT.
1473         (catcher_list_size): Remove.
1474         (throw_exception, throw_it): Simplify.
1475
1476 2019-04-05  Tom Tromey  <tom@tromey.com>
1477
1478         Revert the header-sorting patch.
1479         * ft32-tdep.c: Revert.
1480         * frv-tdep.c: Revert.
1481         * frv-linux-tdep.c: Revert.
1482         * frame.c: Revert.
1483         * frame-unwind.c: Revert.
1484         * frame-base.c: Revert.
1485         * fork-child.c: Revert.
1486         * findvar.c: Revert.
1487         * findcmd.c: Revert.
1488         * filesystem.c: Revert.
1489         * filename-seen-cache.h: Revert.
1490         * filename-seen-cache.c: Revert.
1491         * fbsd-tdep.c: Revert.
1492         * fbsd-nat.h: Revert.
1493         * fbsd-nat.c: Revert.
1494         * f-valprint.c: Revert.
1495         * f-typeprint.c: Revert.
1496         * f-lang.c: Revert.
1497         * extension.h: Revert.
1498         * extension.c: Revert.
1499         * extension-priv.h: Revert.
1500         * expprint.c: Revert.
1501         * exec.h: Revert.
1502         * exec.c: Revert.
1503         * exceptions.c: Revert.
1504         * event-top.c: Revert.
1505         * event-loop.c: Revert.
1506         * eval.c: Revert.
1507         * elfread.c: Revert.
1508         * dwarf2read.h: Revert.
1509         * dwarf2read.c: Revert.
1510         * dwarf2loc.c: Revert.
1511         * dwarf2expr.h: Revert.
1512         * dwarf2expr.c: Revert.
1513         * dwarf2-frame.c: Revert.
1514         * dwarf2-frame-tailcall.c: Revert.
1515         * dwarf-index-write.h: Revert.
1516         * dwarf-index-write.c: Revert.
1517         * dwarf-index-common.c: Revert.
1518         * dwarf-index-cache.h: Revert.
1519         * dwarf-index-cache.c: Revert.
1520         * dummy-frame.c: Revert.
1521         * dtrace-probe.c: Revert.
1522         * disasm.h: Revert.
1523         * disasm.c: Revert.
1524         * disasm-selftests.c: Revert.
1525         * dictionary.c: Revert.
1526         * dicos-tdep.c: Revert.
1527         * demangle.c: Revert.
1528         * dcache.h: Revert.
1529         * dcache.c: Revert.
1530         * darwin-nat.h: Revert.
1531         * darwin-nat.c: Revert.
1532         * darwin-nat-info.c: Revert.
1533         * d-valprint.c: Revert.
1534         * d-namespace.c: Revert.
1535         * d-lang.c: Revert.
1536         * ctf.c: Revert.
1537         * csky-tdep.c: Revert.
1538         * csky-linux-tdep.c: Revert.
1539         * cris-tdep.c: Revert.
1540         * cris-linux-tdep.c: Revert.
1541         * cp-valprint.c: Revert.
1542         * cp-support.c: Revert.
1543         * cp-namespace.c: Revert.
1544         * cp-abi.c: Revert.
1545         * corelow.c: Revert.
1546         * corefile.c: Revert.
1547         * continuations.c: Revert.
1548         * completer.h: Revert.
1549         * completer.c: Revert.
1550         * complaints.c: Revert.
1551         * coffread.c: Revert.
1552         * coff-pe-read.c: Revert.
1553         * cli-out.h: Revert.
1554         * cli-out.c: Revert.
1555         * charset.c: Revert.
1556         * c-varobj.c: Revert.
1557         * c-valprint.c: Revert.
1558         * c-typeprint.c: Revert.
1559         * c-lang.c: Revert.
1560         * buildsym.c: Revert.
1561         * buildsym-legacy.c: Revert.
1562         * build-id.h: Revert.
1563         * build-id.c: Revert.
1564         * btrace.c: Revert.
1565         * bsd-uthread.c: Revert.
1566         * breakpoint.h: Revert.
1567         * breakpoint.c: Revert.
1568         * break-catch-throw.c: Revert.
1569         * break-catch-syscall.c: Revert.
1570         * break-catch-sig.c: Revert.
1571         * blockframe.c: Revert.
1572         * block.c: Revert.
1573         * bfin-tdep.c: Revert.
1574         * bfin-linux-tdep.c: Revert.
1575         * bfd-target.c: Revert.
1576         * bcache.c: Revert.
1577         * ax-general.c: Revert.
1578         * ax-gdb.h: Revert.
1579         * ax-gdb.c: Revert.
1580         * avr-tdep.c: Revert.
1581         * auxv.c: Revert.
1582         * auto-load.c: Revert.
1583         * arm-wince-tdep.c: Revert.
1584         * arm-tdep.c: Revert.
1585         * arm-symbian-tdep.c: Revert.
1586         * arm-pikeos-tdep.c: Revert.
1587         * arm-obsd-tdep.c: Revert.
1588         * arm-nbsd-tdep.c: Revert.
1589         * arm-nbsd-nat.c: Revert.
1590         * arm-linux-tdep.c: Revert.
1591         * arm-linux-nat.c: Revert.
1592         * arm-fbsd-tdep.c: Revert.
1593         * arm-fbsd-nat.c: Revert.
1594         * arm-bsd-tdep.c: Revert.
1595         * arch-utils.c: Revert.
1596         * arc-tdep.c: Revert.
1597         * arc-newlib-tdep.c: Revert.
1598         * annotate.h: Revert.
1599         * annotate.c: Revert.
1600         * amd64-windows-tdep.c: Revert.
1601         * amd64-windows-nat.c: Revert.
1602         * amd64-tdep.c: Revert.
1603         * amd64-sol2-tdep.c: Revert.
1604         * amd64-obsd-tdep.c: Revert.
1605         * amd64-obsd-nat.c: Revert.
1606         * amd64-nbsd-tdep.c: Revert.
1607         * amd64-nbsd-nat.c: Revert.
1608         * amd64-nat.c: Revert.
1609         * amd64-linux-tdep.c: Revert.
1610         * amd64-linux-nat.c: Revert.
1611         * amd64-fbsd-tdep.c: Revert.
1612         * amd64-fbsd-nat.c: Revert.
1613         * amd64-dicos-tdep.c: Revert.
1614         * amd64-darwin-tdep.c: Revert.
1615         * amd64-bsd-nat.c: Revert.
1616         * alpha-tdep.c: Revert.
1617         * alpha-obsd-tdep.c: Revert.
1618         * alpha-nbsd-tdep.c: Revert.
1619         * alpha-mdebug-tdep.c: Revert.
1620         * alpha-linux-tdep.c: Revert.
1621         * alpha-linux-nat.c: Revert.
1622         * alpha-bsd-tdep.c: Revert.
1623         * alpha-bsd-nat.c: Revert.
1624         * aix-thread.c: Revert.
1625         * agent.c: Revert.
1626         * addrmap.c: Revert.
1627         * ada-varobj.c: Revert.
1628         * ada-valprint.c: Revert.
1629         * ada-typeprint.c: Revert.
1630         * ada-tasks.c: Revert.
1631         * ada-lang.c: Revert.
1632         * aarch64-tdep.c: Revert.
1633         * aarch64-ravenscar-thread.c: Revert.
1634         * aarch64-newlib-tdep.c: Revert.
1635         * aarch64-linux-tdep.c: Revert.
1636         * aarch64-linux-nat.c: Revert.
1637         * aarch64-fbsd-tdep.c: Revert.
1638         * aarch64-fbsd-nat.c: Revert.
1639         * aarch32-linux-nat.c: Revert.
1640
1641 2019-04-05  Tom Tromey  <tom@tromey.com>
1642
1643         * ft32-tdep.c: Sort headers.
1644         * frv-tdep.c: Sort headers.
1645         * frv-linux-tdep.c: Sort headers.
1646         * frame.c: Sort headers.
1647         * frame-unwind.c: Sort headers.
1648         * frame-base.c: Sort headers.
1649         * fork-child.c: Sort headers.
1650         * findvar.c: Sort headers.
1651         * findcmd.c: Sort headers.
1652         * filesystem.c: Sort headers.
1653         * filename-seen-cache.h: Sort headers.
1654         * filename-seen-cache.c: Sort headers.
1655         * fbsd-tdep.c: Sort headers.
1656         * fbsd-nat.h: Sort headers.
1657         * fbsd-nat.c: Sort headers.
1658         * f-valprint.c: Sort headers.
1659         * f-typeprint.c: Sort headers.
1660         * f-lang.c: Sort headers.
1661         * extension.h: Sort headers.
1662         * extension.c: Sort headers.
1663         * extension-priv.h: Sort headers.
1664         * expprint.c: Sort headers.
1665         * exec.h: Sort headers.
1666         * exec.c: Sort headers.
1667         * exceptions.c: Sort headers.
1668         * event-top.c: Sort headers.
1669         * event-loop.c: Sort headers.
1670         * eval.c: Sort headers.
1671         * elfread.c: Sort headers.
1672         * dwarf2read.h: Sort headers.
1673         * dwarf2read.c: Sort headers.
1674         * dwarf2loc.c: Sort headers.
1675         * dwarf2expr.h: Sort headers.
1676         * dwarf2expr.c: Sort headers.
1677         * dwarf2-frame.c: Sort headers.
1678         * dwarf2-frame-tailcall.c: Sort headers.
1679         * dwarf-index-write.h: Sort headers.
1680         * dwarf-index-write.c: Sort headers.
1681         * dwarf-index-common.c: Sort headers.
1682         * dwarf-index-cache.h: Sort headers.
1683         * dwarf-index-cache.c: Sort headers.
1684         * dummy-frame.c: Sort headers.
1685         * dtrace-probe.c: Sort headers.
1686         * disasm.h: Sort headers.
1687         * disasm.c: Sort headers.
1688         * disasm-selftests.c: Sort headers.
1689         * dictionary.c: Sort headers.
1690         * dicos-tdep.c: Sort headers.
1691         * demangle.c: Sort headers.
1692         * dcache.h: Sort headers.
1693         * dcache.c: Sort headers.
1694         * darwin-nat.h: Sort headers.
1695         * darwin-nat.c: Sort headers.
1696         * darwin-nat-info.c: Sort headers.
1697         * d-valprint.c: Sort headers.
1698         * d-namespace.c: Sort headers.
1699         * d-lang.c: Sort headers.
1700         * ctf.c: Sort headers.
1701         * csky-tdep.c: Sort headers.
1702         * csky-linux-tdep.c: Sort headers.
1703         * cris-tdep.c: Sort headers.
1704         * cris-linux-tdep.c: Sort headers.
1705         * cp-valprint.c: Sort headers.
1706         * cp-support.c: Sort headers.
1707         * cp-namespace.c: Sort headers.
1708         * cp-abi.c: Sort headers.
1709         * corelow.c: Sort headers.
1710         * corefile.c: Sort headers.
1711         * continuations.c: Sort headers.
1712         * completer.h: Sort headers.
1713         * completer.c: Sort headers.
1714         * complaints.c: Sort headers.
1715         * coffread.c: Sort headers.
1716         * coff-pe-read.c: Sort headers.
1717         * cli-out.h: Sort headers.
1718         * cli-out.c: Sort headers.
1719         * charset.c: Sort headers.
1720         * c-varobj.c: Sort headers.
1721         * c-valprint.c: Sort headers.
1722         * c-typeprint.c: Sort headers.
1723         * c-lang.c: Sort headers.
1724         * buildsym.c: Sort headers.
1725         * buildsym-legacy.c: Sort headers.
1726         * build-id.h: Sort headers.
1727         * build-id.c: Sort headers.
1728         * btrace.c: Sort headers.
1729         * bsd-uthread.c: Sort headers.
1730         * breakpoint.h: Sort headers.
1731         * breakpoint.c: Sort headers.
1732         * break-catch-throw.c: Sort headers.
1733         * break-catch-syscall.c: Sort headers.
1734         * break-catch-sig.c: Sort headers.
1735         * blockframe.c: Sort headers.
1736         * block.c: Sort headers.
1737         * bfin-tdep.c: Sort headers.
1738         * bfin-linux-tdep.c: Sort headers.
1739         * bfd-target.c: Sort headers.
1740         * bcache.c: Sort headers.
1741         * ax-general.c: Sort headers.
1742         * ax-gdb.h: Sort headers.
1743         * ax-gdb.c: Sort headers.
1744         * avr-tdep.c: Sort headers.
1745         * auxv.c: Sort headers.
1746         * auto-load.c: Sort headers.
1747         * arm-wince-tdep.c: Sort headers.
1748         * arm-tdep.c: Sort headers.
1749         * arm-symbian-tdep.c: Sort headers.
1750         * arm-pikeos-tdep.c: Sort headers.
1751         * arm-obsd-tdep.c: Sort headers.
1752         * arm-nbsd-tdep.c: Sort headers.
1753         * arm-nbsd-nat.c: Sort headers.
1754         * arm-linux-tdep.c: Sort headers.
1755         * arm-linux-nat.c: Sort headers.
1756         * arm-fbsd-tdep.c: Sort headers.
1757         * arm-fbsd-nat.c: Sort headers.
1758         * arm-bsd-tdep.c: Sort headers.
1759         * arch-utils.c: Sort headers.
1760         * arc-tdep.c: Sort headers.
1761         * arc-newlib-tdep.c: Sort headers.
1762         * annotate.h: Sort headers.
1763         * annotate.c: Sort headers.
1764         * amd64-windows-tdep.c: Sort headers.
1765         * amd64-windows-nat.c: Sort headers.
1766         * amd64-tdep.c: Sort headers.
1767         * amd64-sol2-tdep.c: Sort headers.
1768         * amd64-obsd-tdep.c: Sort headers.
1769         * amd64-obsd-nat.c: Sort headers.
1770         * amd64-nbsd-tdep.c: Sort headers.
1771         * amd64-nbsd-nat.c: Sort headers.
1772         * amd64-nat.c: Sort headers.
1773         * amd64-linux-tdep.c: Sort headers.
1774         * amd64-linux-nat.c: Sort headers.
1775         * amd64-fbsd-tdep.c: Sort headers.
1776         * amd64-fbsd-nat.c: Sort headers.
1777         * amd64-dicos-tdep.c: Sort headers.
1778         * amd64-darwin-tdep.c: Sort headers.
1779         * amd64-bsd-nat.c: Sort headers.
1780         * alpha-tdep.c: Sort headers.
1781         * alpha-obsd-tdep.c: Sort headers.
1782         * alpha-nbsd-tdep.c: Sort headers.
1783         * alpha-mdebug-tdep.c: Sort headers.
1784         * alpha-linux-tdep.c: Sort headers.
1785         * alpha-linux-nat.c: Sort headers.
1786         * alpha-bsd-tdep.c: Sort headers.
1787         * alpha-bsd-nat.c: Sort headers.
1788         * aix-thread.c: Sort headers.
1789         * agent.c: Sort headers.
1790         * addrmap.c: Sort headers.
1791         * ada-varobj.c: Sort headers.
1792         * ada-valprint.c: Sort headers.
1793         * ada-typeprint.c: Sort headers.
1794         * ada-tasks.c: Sort headers.
1795         * ada-lang.c: Sort headers.
1796         * aarch64-tdep.c: Sort headers.
1797         * aarch64-ravenscar-thread.c: Sort headers.
1798         * aarch64-newlib-tdep.c: Sort headers.
1799         * aarch64-linux-tdep.c: Sort headers.
1800         * aarch64-linux-nat.c: Sort headers.
1801         * aarch64-fbsd-tdep.c: Sort headers.
1802         * aarch64-fbsd-nat.c: Sort headers.
1803         * aarch32-linux-nat.c: Sort headers.
1804
1805 2019-04-04  Tom Tromey  <tom@tromey.com>
1806
1807         * varobj.c (varobj_create): Update.
1808         * rust-exp.y (struct rust_parser) <update_innermost_block,
1809         lookup_symbol>: New methods.
1810         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1811         Rename.
1812         (rust_parser::rust_lookup_type)
1813         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1814         * printcmd.c (display_command, do_one_display): Update.
1815         * parser-defs.h (struct parser_state) <parser_state>: Add
1816         "tracker" parameter.
1817         (block_tracker): New member.
1818         (class innermost_block_tracker) <innermost_block_tracker>: Add
1819         "types" parameter.
1820         <reset>: Remove method.
1821         (innermost_block): Don't declare.
1822         (null_post_parser): Update.
1823         * parse.c (innermost_block): Remove global.
1824         (write_dollar_variable): Update.
1825         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1826         Remove "tracker_types" parameter.
1827         (parse_expression): Add "tracker" parameter.
1828         (parse_expression_for_completion): Update.
1829         (null_post_parser): Add "tracker" parameter.
1830         * p-exp.y: Update rules.
1831         * m2-exp.y: Update rules.
1832         * language.h (struct language_defn) <la_post_parser>: Add
1833         "tracker" parameter.
1834         * go-exp.y: Update rules.
1835         * f-exp.y: Update rules.
1836         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1837         parameter.
1838         * d-exp.y: Update rules.
1839         * c-exp.y: Update rules.
1840         * breakpoint.c (set_breakpoint_condition): Create an
1841         innermost_block_tracker.
1842         (watch_command_1): Likewise.
1843         * ada-lang.c (resolve): Add "tracker" parameter.
1844         (resolve_subexp): Likewise.
1845         * ada-exp.y (write_var_from_sym): Update.
1846
1847 2019-04-04  Tom Tromey  <tom@tromey.com>
1848
1849         * type-stack.h: New file.
1850         * type-stack.c: New file.
1851         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1852         type-stack.h.
1853         (insert_into_type_stack, insert_type, push_type, push_type_int)
1854         (insert_type_address_space, pop_type, pop_type_int)
1855         (pop_typelist, pop_type_stack, append_type_stack)
1856         (push_type_stack, get_type_stack, push_typelist)
1857         (follow_type_instance_flags, follow_types): Don't declare.
1858         * parse.c (type_stack): Remove global.
1859         (parse_exp_in_context): Update.
1860         (insert_into_type_stack, insert_type, push_type, push_type_int)
1861         (insert_type_address_space, pop_type, pop_type_int)
1862         (pop_typelist, pop_type_stack, append_type_stack)
1863         (push_type_stack, get_type_stack, push_typelist)
1864         (follow_type_instance_flags, follow_types): Remove (moved to
1865         type-stack.c).
1866         * f-exp.y (type_stack): New global.
1867         Update rules.
1868         (push_kind_type, f_parse): Update.
1869         * d-exp.y (type_stack): New global.
1870         Update rules.
1871         (d_parse): Update.
1872         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1873         Update rules.
1874         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1875         (HFILES_NO_SRCDIR): Add type-stack.h.
1876
1877 2019-04-04  Tom Tromey  <tom@tromey.com>
1878
1879         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1880         (rust_parser::convert_ast_to_expression, rust_parse)
1881         (rust_lex_test_completion, rust_lex_tests): Update.
1882         * parser-defs.h (struct expr_completion_state): New.
1883         (struct parser_state) <parser_state>: Add completion parameter.
1884         <mark_struct_expression, mark_completion_tag>: New methods.
1885         <parse_completion, m_completion_state>: New members.
1886         (prefixify_expression, null_post_parser): Update.
1887         (mark_struct_expression, mark_completion_tag): Don't declare.
1888         * parse.c (parse_completion, expout_last_struct)
1889         (expout_tag_completion_type, expout_completion_name): Remove
1890         globals.
1891         (parser_state::mark_struct_expression)
1892         (parser_state::mark_completion_tag): Now methods.
1893         (prefixify_expression): Add last_struct parameter.
1894         (prefixify_subexp): Likewise.
1895         (parse_exp_1): Update.
1896         (parse_exp_in_context): Add cstate parameter.  Update.
1897         (parse_expression_for_completion): Create an
1898         expr_completion_state.
1899         (null_post_parser): Add "completion" parameter.
1900         * p-exp.y: Update rules.
1901         (yylex): Update.
1902         * language.h (struct language_defn) <la_post_parser>: Add
1903         "completing" parameter.
1904         * go-exp.y: Update rules.
1905         (lex_one_token): Update.
1906         * expression.h (parse_completion): Don't declare.
1907         * d-exp.y: Update rules.
1908         (lex_one_token): Update rules.
1909         * c-exp.y: Update rules.
1910         (lex_one_token): Update.
1911         * ada-lang.c (resolve): Add "parse_completion" parameter.
1912         (resolve_subexp): Likewise.
1913         (ada_resolve_function): Likewise.
1914
1915 2019-04-04  Tom Tromey  <tom@tromey.com>
1916
1917         * parser-defs.h (struct parser_state) <start_arglist,
1918         end_arglist>: New methods.
1919         <arglist_len, m_funcall_chain>: New members.
1920         (arglist_len, start_arglist, end_arglist): Don't declare.
1921         * parse.c (arglist_len, funcall_chain): Remove global.
1922         (start_arglist, end_arglist): Remove functions.
1923         (parse_exp_in_context): Update.
1924         * p-exp.y: Update rules.
1925         * m2-exp.y: Update rules.
1926         * go-exp.y: Update rules.
1927         * f-exp.y: Update rules.
1928         * d-exp.y: Update rules.
1929         * c-exp.y: Update rules.
1930
1931 2019-04-04  Tom Tromey  <tom@tromey.com>
1932
1933         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1934         lex_operator, push_back>: New methods.
1935         Update all rules.
1936         (rust_parser::lex_hex, lex_escape): Rename and update.
1937         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1938         (rust_parser::lex_operator): Rename and update.
1939         (rust_parser::lex_number, rustyylex, rustyyerror)
1940         (rust_lex_test_init, rust_lex_test_sequence)
1941         (rust_lex_test_push_back, rust_lex_tests): Update.
1942         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1943         parameter.
1944         <lexptr, prev_lexptr>: New members.
1945         (lexptr, prev_lexptr): Don't declare.
1946         * parse.c (lexptr, prev_lexptr): Remove globals.
1947         (parse_exp_in_context): Update.
1948         * p-exp.y (yylex, yyerror): Update.
1949         * m2-exp.y (parse_number, yylex, yyerror): Update.
1950         * go-exp.y (lex_one_token, yyerror): Update.
1951         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1952         * d-exp.y (lex_one_token, yyerror): Update.
1953         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1954         (lex_one_token, yyerror): Update.
1955         * ada-lex.l (YY_INPUT): Update.
1956         (rewind_to_char): Update.
1957         * ada-exp.y (yyerror): Update.
1958
1959 2019-04-04  Tom Tromey  <tom@tromey.com>
1960
1961         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1962         * parser-defs.h (struct parser_state) <parser_state>: Add new
1963         parameter.
1964         <comma_terminates>: New member.
1965         (comma_terminates): Don't declare global.
1966         * parse.c (comma_terminates): Remove global.
1967         (parse_exp_in_context): Update.
1968         * p-exp.y (yylex): Update.
1969         * m2-exp.y (yylex): Update.
1970         * go-exp.y (lex_one_token): Update.
1971         * f-exp.y (yylex): Update.
1972         * d-exp.y (lex_one_token): Update.
1973         * c-exp.y (lex_one_token): Update.
1974         * ada-lex.l: Update.
1975
1976 2019-04-04  Tom Tromey  <tom@tromey.com>
1977
1978         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1979         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1980         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1981         * parser-defs.h (paren_depth): Don't declare.
1982         * parse.c (paren_depth): Remove global.
1983         (parse_exp_in_context): Update.
1984         * p-exp.y (paren_depth): New global.
1985         (pascal_parse): Initialize it.
1986         * m2-exp.y (paren_depth): New global.
1987         (m2_parse): Initialize it.
1988         * go-exp.y (paren_depth): New global.
1989         (go_parse): Initialize it.
1990         * f-exp.y (paren_depth): New global.
1991         (f_parse): Initialize it.
1992         * d-exp.y (paren_depth): New global.
1993         (d_parse): Initialize it.
1994         * c-exp.y (paren_depth): New global.
1995         (c_parse): Initialize it.
1996         * ada-lex.l (paren_depth): New global.
1997         (lexer_init): Initialize it.
1998
1999 2019-04-04  Tom Tromey  <tom@tromey.com>
2000
2001         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2002         (rust_parser::convert_ast_to_type)
2003         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2004         * parser-defs.h (struct parser_state) <parser_state>: Add
2005         parameters.  Initialize new members.
2006         <expression_context_block, expression_context_pc>: New members.
2007         * parse.c (expression_context_block, expression_context_pc):
2008         Remove globals.
2009         (parse_exp_in_context): Update.
2010         * p-exp.y: Update all rules.
2011         (yylex): Update.
2012         * m2-exp.y: Update all rules.
2013         (yylex): Update.
2014         * go-exp.y (yylex): Update.
2015         * f-exp.y (yylex): Update.
2016         * d-exp.y: Update all rules.
2017         (yylex): Update.
2018         * c-exp.y: Update all rules.
2019         (lex_one_token, classify_name, yylex, c_parse): Update.
2020         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2021
2022 2019-04-04  Tom Tromey  <tom@tromey.com>
2023
2024         * gdbarch.h, gdbarch.c: Rebuild.
2025         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2026         * stap-probe.h:
2027         (struct stap_parse_info): Replace "parser_state" with
2028         "expr_builder".
2029         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2030         (parser_state): New class.
2031         * parse.c (expr_builder): Rename.
2032         (expr_builder::release): Rename.
2033         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2034         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2035         (write_exp_elt_longcst, write_exp_elt_floatcst)
2036         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2037         (write_exp_string_vector, write_exp_bitstring)
2038         (write_exp_msymbol, mark_struct_expression)
2039         (write_dollar_variable)
2040         (insert_type_address_space, increase_expout_size): Replace
2041         "parser_state" with "expr_builder".
2042         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2043         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2044         "parser_state" with "expr_builder".
2045
2046 2019-04-04  Tom Tromey  <tom@tromey.com>
2047
2048         * rust-exp.y: Replace "parse_language" with method call.
2049         * p-exp.y:
2050         (yylex): Replace "parse_language" with method call.
2051         * m2-exp.y:
2052         (yylex): Replace "parse_language" with method call.
2053         * go-exp.y (classify_name): Replace "parse_language" with method
2054         call.
2055         * f-exp.y (yylex): Replace "parse_language" with method call.
2056         * d-exp.y (lex_one_token): Replace "parse_language" with method
2057         call.
2058         * c-exp.y:
2059         (lex_one_token, classify_name, yylex): Replace "parse_language"
2060         with method call.
2061         * ada-exp.y (find_primitive_type, type_char)
2062         (type_system_address): Replace "parse_language" with method call.
2063
2064 2019-04-04  Tom Tromey  <tom@tromey.com>
2065
2066         * rust-exp.y: Replace "parse_gdbarch" with method call.
2067         * parse.c (write_dollar_variable, insert_type_address_space):
2068         Replace "parse_gdbarch" with method call.
2069         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2070         call.
2071         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2072         call.
2073         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2074         "parse_gdbarch" with method call.
2075         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2076         with method call.
2077         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2078         "parse_gdbarch" with method call.
2079         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2080         "parse_gdbarch" with method call.
2081         * c-exp.y (parse_type, parse_number, classify_name): Replace
2082         "parse_gdbarch" with method call.
2083         * ada-lex.l: Replace "parse_gdbarch" with method call.
2084         * ada-exp.y (parse_type, find_primitive_type, type_char)
2085         (type_system_address): Replace "parse_gdbarch" with method call.
2086
2087 2019-04-04  Tom Tromey  <tom@tromey.com>
2088
2089         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2090         * stap-probe.c (stap_parse_argument): Update.
2091         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2092         initial_size parameter.
2093         * rust-exp.y (rust_lex_tests): Update.
2094         * parse.c (parser_state): Update.
2095         (parse_exp_in_context): Update.
2096         * parser-defs.h (struct parser_state) <parser_state>: Remove
2097         "initial_size" parameter.
2098
2099 2019-04-04  Tom Tromey  <tom@tromey.com>
2100
2101         * parser-defs.h (increase_expout_size): Don't declare.
2102         * parse.c (increase_expout_size): Now static.
2103
2104 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2105
2106         * gnu-nat.c (gnu_nat_target::wait): Fix
2107         target_waitstatus_to_string call.
2108
2109 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * eval.c (evaluate_subexp_standard): Handle internal functions
2112         during Fortran function call handling.
2113
2114 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2115
2116         * NEWS: Mention new internal functions.
2117         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2118         (read_base_type): Use dwarf2_init_complex_target_type.
2119         * value.c (creal_internal_fn): New function.
2120         (cimag_internal_fn): New function.
2121         (_initialize_values): Register new internal functions.
2122
2123 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2124
2125         * infrun.c (stop_all_threads): If debug_infrun, always
2126         trace the wait status after wait_one, using
2127         target_waitstatus_to_string and target_pid_to_str.
2128         (handle_inferior_event): Replace various trace of
2129         wait status kind by a single trace.
2130         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2131         wait status kind image by target_waitstatus_to_string.
2132         * target/waitstatus.c (target_waitstatus_to_string): Fix
2133         obsolete comment.
2134
2135 2019-04-01  Tom Tromey  <tromey@adacore.com>
2136
2137         PR symtab/23331:
2138         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2139
2140 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2141             Pedro Alves  <palves@redhat.com>
2142
2143         * top.c (quit_force): Call 'finalize_values'.
2144         * value.c (finalize_values): New function.
2145         * value.h (finalize_values): Declare.
2146
2147 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2148
2149         * NEWS: Announce $_gdb_major and $_gdb_minor.
2150
2151         * top.c (init_gdb_version_vars): New function.
2152         (gdb_init): Call init_gdb_version_vars.
2153
2154 2019-03-29  Tom Tromey  <tromey@adacore.com>
2155
2156         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2157         help text.  Remove dead code.
2158
2159 2019-03-29  Keith Seitz  <keiths@redhat.com>
2160
2161         From Siddhesh Poyarekar:
2162         * f-lang.h (f77_get_upperbound): Return LONGEST.
2163         (f77_get_lowerbound): Likewise.
2164         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2165         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2166         print them.
2167         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2168         plongest to format print it.
2169         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2170         (f77_get_upperbound): Likewise.
2171         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2172         LOWER_BOUND to LONGEST.
2173         (f77_create_arrayprint_offset_tbl): Likewise.
2174
2175 2019-03-29  Keith Seitz  <keiths@redhat.com>
2176
2177         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2178         %s/pulongest for TYPE_LENGTH instead of %d in format
2179         strings.
2180         * ada-typerint.c (ada_print_type): Likewise.
2181         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2182         * compile/compile-c-support.c (generate_register_struct): Likewise.
2183         * gdbtypes.c (recursive_dump_type): Likewise.
2184         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2185         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2186         instead of %d in format strings.
2187         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2188         to std::min to ULONGEST.
2189         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2190         instead of %d in format strings.
2191         * tracepoint.c (info_scope_command): Likewise.
2192         * typeprint.c (print_offset_data::update)
2193         (print_offset_data::finish): Likewise.
2194         * xtensa-tdep.c (xtensa_store_return_value)
2195         (xtensa_push_dummy_call): Likewise.
2196
2197 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2198
2199         * windows-nat.c (display_selector): Fixed format specifications
2200         for 64-bit Cygwin.
2201
2202 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2203
2204         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2205
2206 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2207
2208         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2209         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2210         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2211         (nios2_linux_init_abi): Install it.
2212
2213 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2214
2215         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2216
2217 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2218
2219         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2220
2221 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2222             Tom Tromey  <tromey@adacore.com>
2223
2224         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2225
2226 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2227
2228         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2229         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2230         method to compute the bounds of range types. Also print "[evaluated]"
2231         if the bounds' values come from a dynamic evaluation.
2232
2233 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2236         whitespace when pretty printing is on.
2237
2238 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2239
2240         * ppc-linux-nat.c: Add include.
2241
2242 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2243
2244         * NEWS: Mention AArch64 Pointer Authentication.
2245
2246 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2247
2248         * arm-linux-nat.c: Add include.
2249
2250 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2251
2252         * source-cache.c (source_cache::get_source_lines): Re-read
2253         fullname after calling open_source_file.
2254
2255 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2256
2257         * NEWS: Mention TLS support for FreeBSD.
2258
2259 2019-03-25  Tom Tromey  <tromey@adacore.com>
2260
2261         * minsyms.c (BUNCH_SIZE): Update comment.
2262         (~minimal_symbol_reader): Remove old comment.
2263         (compact_minimal_symbols): Update comment.
2264         (minimal_symbol_reader::install): Remove old comment.  Update
2265         other comments.
2266
2267 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2268
2269         * s390-linux-nat.c: Add include.
2270
2271 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2274         Call linux_get_hwcap.
2275         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2276         Likewise.
2277         (aarch64_linux_get_hwcap): Remove function.
2278         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2279         declaration.
2280         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2281         linux_get_hwcap.
2282         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2283         * linux-tdep.c (linux_get_hwcap): Add function.
2284         (linux_get_hwcap2): Likewise.
2285         * linux-tdep.h (linux_get_hwcap): Add declaration.
2286         (linux_get_hwcap2): Likewise.
2287         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2288         (ppc_linux_get_hwcap2): Likewise.
2289         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2290         linux_get_hwcap.
2291         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2292         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2293         (ppc_linux_nat_target::read_description): Likewise.
2294         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2295         * s390-linux-nat.c: Likewise.
2296         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2297
2298 2019-03-24  Tom Tromey  <tom@tromey.com>
2299
2300         * ada-lang.c (standard_lookup): Simplify initialization.
2301         (ada_lookup_symbol_nonlocal): Simplify return.
2302         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2303         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2304         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2305         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2306         initialization.
2307         * solib.c (solib_global_lookup): Simplify.
2308         * symtab.c (null_block_symbol): Remove.
2309         (symbol_cache_lookup): Simplify returns.
2310         (lookup_language_this): Simplify returns.
2311         (lookup_symbol_aux): Simplify return.
2312         (lookup_local_symbol): Simplify returns.
2313         (lookup_global_symbol_from_objfile): Simplify return.
2314         (lookup_symbol_in_objfile_symtabs)
2315         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2316         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2317         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2318         * cp-namespace.c (cp_lookup_bare_symbol)
2319         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2320         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2321         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2322         (cp_lookup_symbol_via_imports): Simplify initialization.
2323         (find_symbol_in_baseclass): Likewise.
2324         * symtab.h (null_block_symbol): Remove.
2325         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2326         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2327         (d_lookup_symbol_module): Likewise.
2328         (find_symbol_in_baseclass): Simplify initialization.
2329
2330 2019-03-24  Tom Tromey  <tom@tromey.com>
2331
2332         * expression.h: Don't include symtab.h.
2333         (struct block): Forward declare.
2334
2335 2019-03-24  Tom Tromey  <tom@tromey.com>
2336
2337         * c-exp.y (typebase): Remove casts.
2338         * gdbtypes.c (lookup_unsigned_typename, )
2339         (lookup_signed_typename): Remove cast.
2340         * eval.c (parse_to_comma_and_eval): Remove cast.
2341         * parse.c (write_dollar_variable): Remove cast.
2342         * block.h (struct block) <superblock>: Now const.
2343         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2344         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2345         (map_block): Make "block" const.
2346         * symfile.h (struct quick_symbol_functions)
2347         <map_matching_symbols>: Constify block argument to "callback".
2348         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2349         const.
2350         (find_pc_sect_compunit_symtab): Make "b" const.
2351         (find_symbol_at_address): Likewise.
2352         (search_symbols): Likewise.
2353         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2354         (dw2_debug_names_lookup_symbol): Likewise.
2355         (dw2_map_matching_symbols): Update.
2356         * p-valprint.c (pascal_val_print): Remove "block".
2357         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2358         (aux_add_nonlocal_symbols): Make "block" const.
2359         (resolve_subexp): Remove cast.
2360         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2361         const.
2362         (iterate_over_file_blocks): Likewise.
2363         * f-exp.y (%union) <bval>: Remove.
2364         * coffread.c (patch_opaque_types): Make "b" const.
2365         * spu-tdep.c (spu_catch_start): Make "block" const.
2366         * c-valprint.c (print_unpacked_pointer): Remove "block".
2367         * symmisc.c (dump_symtab_1): Make "b" const.
2368         (block_depth): Make "block" const.
2369         * d-exp.y (%union) <bval>: Remove.
2370         * cp-support.h (cp_lookup_rtti_type): Update.
2371         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2372         * psymtab.c (psym_lookup_symbol): Make "block" const.
2373         (maintenance_check_psymtabs): Make "b" const.
2374         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2375         (enumerate_locals, enumerate_args): Update.
2376         * python/py-symtab.c (stpy_global_block): Make "block" const.
2377         (stpy_static_block): Likewise.
2378         * inline-frame.c (block_starting_point_at): Make "new_block"
2379         const.
2380         * block.c (find_block_in_blockvector): Make return type const.
2381         (blockvector_for_pc_sect): Make "b" const.
2382         (find_block_in_blockvector): Make "b" const.
2383
2384 2019-03-23  Tom Tromey  <tom@tromey.com>
2385
2386         * varobj.c (varobj_create): Update.
2387         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2388         * printcmd.c (display_command, do_one_display): Don't reset
2389         innermost_block.
2390         * parser-defs.h (enum innermost_block_tracker_type): Move to
2391         expression.h.
2392         (innermost_block): Update comment.
2393         * parse.c (parse_exp_1): Add tracker_types parameter.
2394         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2395         tracker_types parameter.  Reset innermost_block.
2396         (parse_exp_in_context): Remove.
2397         (parse_expression_for_completion): Update.
2398         * objfiles.c (~objfile): Don't reset expression_context_block or
2399         innermost_block.
2400         * expression.h (enum innermost_block_tracker_type): Move from
2401         parser-defs.h.
2402         (parse_exp_1): Add tracker_types parameter.
2403         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2404         reset innermost_block.
2405
2406 2019-03-23  Tom Tromey  <tom@tromey.com>
2407
2408         * objfiles.h: Include bcache.h.
2409
2410 2019-03-23  Tom Tromey  <tom@tromey.com>
2411
2412         * linespec.c (get_current_search_block): Use
2413         scoped_restore_current_language.
2414         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2415
2416 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2417             Jiong Wang  <jiong.wang@arm.com>
2418
2419         * aarch64-linux-tdep.c
2420         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2421         section.
2422         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2423
2424 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2425             Jiong Wang  <jiong.wang@arm.com>
2426
2427         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2428         instructions.
2429         (aarch64_analyze_prologue_test): Add PACIASP test.
2430         (aarch64_prologue_prev_register): Unmask PC value.
2431
2432 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2433             Jiong Wang  <jiong.wang@arm.com>
2434
2435         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2436         (aarch64_dwarf2_prev_register): Unmask PC value.
2437         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2438         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2439         DW_CFA_AARCH64_negate_ra_state.
2440         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2441
2442 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2443             Jiong Wang  <jiong.wang@arm.com>
2444
2445         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2446         registers.
2447         (aarch64_pseudo_register_name): Likewise.
2448         (aarch64_pseudo_register_type): Likewise.
2449         (aarch64_pseudo_register_reggroup_p): Likewise.
2450         (aarch64_gdbarch_init): Add pauth registers.
2451         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2452         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2453         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2454         (struct gdbarch_tdep): Add regnum for ra_state.
2455
2456 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2457             Jiong Wang  <jiong.wang@arm.com>
2458
2459         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2460
2461 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2462             Jiong Wang  <jiong.wang@arm.com>
2463
2464         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2465         function.
2466         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2467         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2468         (aarch64_gdbarch_init): Add puth registers.
2469         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2470         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2471         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2472
2473 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2474             Jiong Wang  <jiong.wang@arm.com>
2475
2476         * aarch64-linux-nat.c
2477         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2478         * aarch64-linux-tdep.c
2479         (aarch64_linux_core_read_description): Likewise.
2480         (aarch64_linux_get_hwcap): New function.
2481         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2482         (aarch64_linux_get_hwcap): New declaration.
2483
2484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2485             Jiong Wang  <jiong.wang@arm.com>
2486
2487         * aarch64-linux-nat.c
2488         (aarch64_linux_nat_target::read_description): Add pauth param.
2489         * aarch64-linux-tdep.c
2490         (aarch64_linux_core_read_description): Likewise.
2491         * aarch64-tdep.c (struct target_desc): Add in pauth.
2492         (aarch64_read_description): Add pauth param.
2493         (aarch64_gdbarch_init): Likewise.
2494         * aarch64-tdep.h (aarch64_read_description): Likewise.
2495         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2496         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2497         * features/Makefile: Add new files.
2498         * features/aarch64-pauth.c: New file.
2499         * features/aarch64-pauth.xml: New file.
2500
2501 2019-03-20  Tom Tromey  <tromey@adacore.com>
2502
2503         * infrun.c (handle_inferior_event): Rename from
2504         handle_inferior_event_1.  Create a scoped_value_mark.
2505         (handle_inferior_event): Remove.
2506
2507 2019-03-19  Tom Tromey  <tromey@adacore.com>
2508
2509         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2510         * infrun.h (print_stop_event): Add "displays" parameter.
2511         * infrun.c (print_stop_event): Add "displays" parameter.
2512
2513 2019-03-19  Pedro Alves  <palves@redhat.com>
2514
2515         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2516         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2517         to -1.  Fix TABs vs spaces.
2518         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2519         * tui/tui-out.h (tui_ui_out) Add intro comments.
2520         <m_line, m_start_of_line>: In-class initialize, and add describing
2521         comment.
2522
2523 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2524
2525         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2526         variable names.
2527         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2528
2529 2019-03-18  Pedro Alves  <palves@redhat.com>
2530             Eli Zaretskii <eliz@gnu.org>
2531
2532         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2533         m_line and m_start_of_line.
2534
2535 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2536
2537         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2538         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2539         it returns a newline.  This fixes a regression in TU mode, whereby
2540         the next line is output on the same screen line as the user input.
2541
2542 2019-03-18  Tom Tromey  <tromey@adacore.com>
2543
2544         * minsyms.c (minimal_symbol_reader::install): Remove call to
2545         obstack_blank.
2546
2547 2019-03-18  Pedro Alves  <palves@redhat.com>
2548
2549         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2550         New globals.
2551         (apply_style): New, factored out from ...
2552         (apply_ansi_escape): ... this.  Handle reverse video mode.
2553         (tui_set_reverse_mode): New function.
2554         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2555         * tui/tui-winsource.c (tui_show_source_line): Use
2556         tui_set_reverse_mode instead of setting A_STANDOUT.
2557         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2558         New setter methods.
2559
2560 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2561
2562         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2563         Handle tabs.
2564
2565 2019-03-18  Tom Tromey  <tromey@adacore.com>
2566
2567         * ada-lang.c (empty_array): Add "high" parameter.
2568         (ada_evaluate_subexp): Update.
2569
2570 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2571
2572         * unittests/string_view-selftests.c: Define
2573         _initialize_string_view_selftests unconditionally.
2574
2575 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2576
2577         PR gdb/24350
2578         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2579
2580 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2581
2582         PR gdb/24351
2583         * windows-nat.c (display_selector): Fix format specifiers.
2584
2585 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2586
2587         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2588         tui_refill_source_window instead of tui_refresh_win, to update the
2589         current execution line.  This fixes redisplay of the current line
2590         when stepping through the code with "next" or "step".
2591
2592 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2593
2594         * source-cache.c (source_cache::get_source_lines): Call
2595         find_source_lines to initialize s->nlines.  This fixes vertical
2596         scrolling of TUI source window when the DOWN arrow is pressed.
2597
2598 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2599
2600         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2601         linux-thread-db.c (_initialize_thread_db): Likewise.
2602
2603 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2604
2605         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2606         wclrtoeol in tui_show_source_line".  This reverts changes made in
2607         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2608
2609 2019-03-15  Tom Tromey  <tom@tromey.com>
2610
2611         * symtab.h (struct minimal_symbol): Derive from
2612         general_symbol_info.
2613         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2614         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2615         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2616         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2617         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2618         (MSYMBOL_SEARCH_NAME): Update.
2619         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2620         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2621         * minsyms.c (minimal_symbol_reader::record_full): Update.
2622
2623 2019-03-15  Tom Tromey  <tom@tromey.com>
2624
2625         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2626
2627 2019-03-15  Tom Tromey  <tom@tromey.com>
2628
2629         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2630         unique_xmalloc_ptr.
2631         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2632         Update.
2633         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2634         (build_minimal_symbol_hash_tables)
2635         (minimal_symbol_reader::install): Update.
2636
2637 2019-03-15  Tom Tromey  <tom@tromey.com>
2638
2639         * symtab.c (create_demangled_names_hash): Update.
2640         (symbol_set_names): Update.
2641         * objfiles.h (struct objfile_per_bfd_storage)
2642         <demangled_names_hash>: Now an htab_up.
2643         * objfiles.c (objfile_per_bfd_storage): Simplify.
2644
2645 2019-03-15  Tom Tromey  <tom@tromey.com>
2646
2647         * objfiles.h (struct objfile_per_bfd_storage): Declare
2648         destructor.
2649         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2650         New.
2651         (get_objfile_bfd_data): Use new.  Don't initialize
2652         language_of_main.
2653         (free_objfile_per_bfd_storage): Remove.
2654         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2655
2656 2019-03-15  Tom Tromey  <tom@tromey.com>
2657
2658         * symfile.c (reread_symbols): Update.
2659         * objfiles.c (objfile::objfile): Update.
2660         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2661         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2662         comment.
2663         (minimal_symbol_reader::install): Update.
2664         (terminate_minimal_symbol_table): Remove.
2665         * jit.c (jit_object_close_impl): Update.
2666
2667 2019-03-15  Tom Tromey  <tom@tromey.com>
2668
2669         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2670         initializations.
2671
2672 2019-03-15  Tom Tromey  <tom@tromey.com>
2673
2674         * objfiles.h (struct objfile_per_bfd_storage)
2675         <demangled_hash_languages>: Now a bitset.
2676         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2677         (lookup_minimal_symbol): Update.
2678
2679 2019-03-15  Tom Tromey  <tom@tromey.com>
2680
2681         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2682         Don't return the symbol.
2683         * coffread.c (record_minimal_symbol): Use record_full.
2684
2685 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2686
2687         The MS-Windows port of ncurses fails to switch to a color pair if
2688         one or both of the colors are the implicit default colors.  This
2689         change records the default colors when TUI is initialized, and
2690         then specifies them explicitly when a color pair uses the default
2691         colors.  This allows color styling in TUI mode on MS-Windows.
2692
2693         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2694         ncurses_norm_attr.
2695         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2696         colors in ncurses_norm_attr.
2697         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2698         "none", replace it with the default color recorded in
2699         ncurses_norm_attr.
2700
2701 2019-03-14  Tom Tromey  <tromey@adacore.com>
2702
2703         * source-cache.h (class source_cache) <get_source_lines>: Return
2704         std::string.
2705         * source-cache.c (source_cache::extract_lines): Handle case where
2706         first_pos==npos.  Return std::string.
2707         (source_cache::get_source_lines): Update.
2708
2709 2019-03-14  Tom Tromey  <tromey@adacore.com>
2710
2711         * NEWS: Add item for "style sources" commands.
2712         * source-cache.c (source_cache::get_source_lines): Check
2713         source_styling.
2714         * cli/cli-style.c (source_styling): New global.
2715         (_initialize_cli_style): Add "style sources" commands.
2716         (show_style_sources): New function.
2717         * cli/cli-style.h (source_styling): Declare.
2718
2719 2019-03-14  Pedro Alves  <palves@redhat.com>
2720             Tom Tromey  <tromey@adacore.com>
2721
2722         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2723         * tui/tui-winsource.c (tui_refill_source_window): New function,
2724         from...
2725         (tui_horizontal_source_scroll): ... here.  Move some logic.
2726         * cli/cli-style.c (set_style_enabled): Notify new observable.
2727         * tui/tui-hooks.c (tui_redisplay_source): New function.
2728         (tui_attach_detach_observers): Attach or detach
2729         tui_redisplay_source.
2730         * observable.h (source_styling_changed): New observable.
2731         * observable.c: Define source_styling_changed observable.
2732
2733 2019-03-13  Tom Tromey  <tromey@adacore.com>
2734
2735         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2736         (i386_gnu_nat_target::store_registers): Update.
2737         * target-debug.h (target_debug_print_std_string): New macro.
2738         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2739         * windows-tdep.c (display_one_tib): Update.
2740         * tui/tui-stack.c (tui_make_status_line): Update.
2741         * top.c (print_inferior_quit_action): Update.
2742         * thread.c (thr_try_catch_cmd): Update.
2743         (add_thread_with_info): Update.
2744         (thread_target_id_str): Update.
2745         (thr_try_catch_cmd): Update.
2746         (thread_command): Update.
2747         (thread_find_command): Update.
2748         * record-btrace.c (record_btrace_target::info_record)
2749         (record_btrace_resume_thread, record_btrace_target::resume)
2750         (record_btrace_cancel_resume, record_btrace_step_thread)
2751         (record_btrace_target::wait, record_btrace_target::wait)
2752         (record_btrace_target::wait, record_btrace_target::stop): Update.
2753         * progspace.c (print_program_space): Update.
2754         * process-stratum-target.c
2755         (process_stratum_target::thread_address_space): Update.
2756         * linux-fork.c (linux_fork_mourn_inferior)
2757         (detach_checkpoint_command, info_checkpoints_command)
2758         (linux_fork_context): Update.
2759         (linux_fork_detach): Update.
2760         (class scoped_switch_fork_info): Update.
2761         (delete_checkpoint_command): Update.
2762         * infrun.c (follow_fork_inferior): Update.
2763         (follow_fork_inferior): Update.
2764         (proceed_after_vfork_done): Update.
2765         (handle_vfork_child_exec_or_exit): Update.
2766         (follow_exec): Update.
2767         (displaced_step_prepare_throw): Update.
2768         (displaced_step_restore): Update.
2769         (start_step_over): Update.
2770         (resume_1): Update.
2771         (clear_proceed_status_thread): Update.
2772         (proceed): Update.
2773         (print_target_wait_results): Update.
2774         (do_target_wait): Update.
2775         (context_switch): Update.
2776         (stop_all_threads): Update.
2777         (restart_threads): Update.
2778         (finish_step_over): Update.
2779         (handle_signal_stop): Update.
2780         (switch_back_to_stepped_thread): Update.
2781         (keep_going_pass_signal): Update.
2782         (print_exited_reason): Update.
2783         (normal_stop): Update.
2784         * inferior.c (inferior_pid_to_str): Change return type.
2785         (print_selected_inferior): Update.
2786         (add_inferior): Update.
2787         (detach_inferior): Update.
2788         * dummy-frame.c (fprint_dummy_frames): Update.
2789         * dcache.c (dcache_info_1): Update.
2790         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2791         (btrace_fetch, btrace_clear): Update.
2792         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2793         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2794         type.
2795         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2796         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2797         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2798         * gdbarch.c, gdbarch.h: Rebuild.
2799         * gdbarch.sh (core_pid_to_str): Change return type.
2800         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2801         return type.
2802         (windows_nat_target::pid_to_str): Change return type.
2803         (windows_delete_thread): Update.
2804         (windows_nat_target::attach): Update.
2805         (windows_nat_target::files_info): Update.
2806         * target-delegates.c: Rebuild.
2807         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2808         return type.
2809         (sol_thread_target::pid_to_str): Change return type.
2810         * remote.c (class remote_target) <pid_to_str>: Change return
2811         type.
2812         (remote_target::pid_to_str): Change return type.
2813         (extended_remote_target::attach, remote_target::remote_stop_ns)
2814         (remote_target::remote_notif_remove_queued_reply)
2815         (remote_target::push_stop_reply, remote_target::disable_btrace):
2816         Update.
2817         (extended_remote_target::attach): Update.
2818         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2819         type.
2820         (gdbsim_target::pid_to_str): Change return type.
2821         * ravenscar-thread.c (struct ravenscar_thread_target)
2822         <pid_to_str>: Change return type.
2823         (ravenscar_thread_target::pid_to_str): Change return type.
2824         * procfs.c (class procfs_target) <pid_to_str>: Change return
2825         type.
2826         (procfs_target::pid_to_str): Change return type.
2827         (procfs_target::attach): Update.
2828         (procfs_target::detach): Update.
2829         (procfs_target::fetch_registers): Update.
2830         (procfs_target::store_registers): Update.
2831         (procfs_target::wait): Update.
2832         (procfs_target::files_info): Update.
2833         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2834         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2835         return type.
2836         (nto_procfs_target::pid_to_str): Change return type.
2837         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2838         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2839         return type.
2840         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2841         (exit_lwp): Update.
2842         (attach_proc_task_lwp_callback, get_detach_signal)
2843         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2844         (linux_nat_target::resume, wait_lwp, stop_callback)
2845         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2846         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2847         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2848         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2849         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2850         type.
2851         (inf_ptrace_target::attach): Update.
2852         (inf_ptrace_target::files_info): Update.
2853         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2854         type.
2855         (go32_nat_target::pid_to_str): Change return type.
2856         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2857         (gnu_nat_target::wait): Update.
2858         (gnu_nat_target::wait): Update.
2859         (gnu_nat_target::resume): Update.
2860         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2861         (fbsd_nat_target::wait): Update.
2862         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2863         type.
2864         (darwin_nat_target::attach): Update.
2865         * corelow.c (class core_target) <pid_to_str>: Change return type.
2866         (core_target::pid_to_str): Change return type.
2867         * target.c (normal_pid_to_str): Change return type.
2868         (default_pid_to_str): Likewise.
2869         (target_pid_to_str): Change return type.
2870         (target_translate_tls_address): Update.
2871         (target_announce_detach): Update.
2872         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2873         return type.
2874         (bsd_uthread_target::pid_to_str): Change return type.
2875         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2876         type.
2877         (bsd_kvm_target::pid_to_str): Change return type.
2878         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2879         return type.
2880         (aix_thread_target::pid_to_str): Change return type.
2881         * target.h (struct target_ops) <pid_to_str>: Change return type.
2882         (target_pid_to_str, normal_pid_to_str): Likewise.
2883         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2884         type.
2885         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2886         type.
2887         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2888         return type.
2889         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2890         type.
2891         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2892         type.
2893         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2894         return type.
2895
2896 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2897
2898         * NEWS: Mention that the new default MI version is 3.  Mention
2899         changes to the output of commands and events that deal with
2900         multi-location breakpoints.
2901         * breakpoint.c: Include "mi/mi-out.h".
2902         (print_one_breakpoint): Change output syntax if using MI version
2903         >= 3.
2904         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2905         New.
2906         (mi_multi_location_breakpoint_output_fixed): New.
2907         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2908         (mi_cmd_fix_multi_location_breakpoint_output): New.
2909         (mi_multi_location_breakpoint_output_fixed): New.
2910         * mi/mi-cmds.c (mi_cmds): Register command
2911         -fix-multi-location-breakpoint-output.
2912         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2913         interpreter "mi".
2914
2915 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2916
2917         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2918         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2919         instantiate mi_ui_out based on interpreter name.
2920         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2921         * mi/mi-main.c (mi_load_progress): Likewise.
2922
2923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2924
2925         * NEWS: Combine separate "New targets" sections for 8.3.
2926
2927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2928
2929         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2930         (ppcfbsd_init_abi): Install gdbarch
2931         "fetch_tls_load_module_address" and "get_thread_local_address"
2932         methods.
2933
2934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2935
2936         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2937         (riscv_fbsd_init_abi): Install gdbarch
2938         "fetch_tls_load_module_address" and "get_thread_local_address"
2939         methods.
2940
2941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2942
2943         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2944         (i386fbsd_init_abi): Install gdbarch
2945         "fetch_tls_load_module_address" and "get_thread_local_address"
2946         methods.
2947
2948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2949
2950         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2951         (amd64fbsd_init_abi): Install gdbarch
2952         "fetch_tls_load_module_address" and "get_thread_local_address"
2953         methods.
2954
2955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2956
2957         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2958         (struct fbsd_pspace_data): New type.
2959         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2960         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2961         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2962         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2963         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2964
2965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2966
2967         * gdbtypes.c (lookup_struct_elt): New function.
2968         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2969         * gdbtypes.h (struct struct_elt): New type.
2970         (lookup_struct_elt): New prototype.
2971
2972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2973
2974         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2975         remove disabled code block.
2976
2977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2978
2979         * gdbarch.sh (get_thread_local_address): New method.
2980         * gdbarch.h, gdbarch.c: Regenerate.
2981         * target.c (target_translate_tls_address): Use
2982         gdbarch_get_thread_local_address if present instead of
2983         target::get_thread_local_address.
2984
2985 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2986
2987         * target.h (target::get_thread_local_address): Update comment.
2988
2989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2990
2991         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2992         objfile->separate_debug_objfile_backlink if not NULL.
2993
2994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2995
2996         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2997         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2998         (amd64bsd_store_inferior_registers): Likewise.
2999         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3000         Enable segment base registers.
3001         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3002         PT_GETFSBASE and PT_GETGSBASE.
3003         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3004         PT_SETGSBASE.
3005         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3006         segment base registers.
3007         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3008
3009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3010
3011         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3012         Update calls to i386_target_description to add 'segments'
3013         parameter.
3014         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3015         add segment base registers.
3016         * arch/i386.c (i386_create_target_description): Add 'segments'
3017         parameter to enable segment base registers.
3018         * arch/i386.h (i386_create_target_description): Likewise.
3019         * features/i386/32bit-segments.xml: New file.
3020         * features/i386/32bit-segments.c: Generate.
3021         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3022         call to i386_target_description to add 'segments' parameter.
3023         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3024         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3025         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3026         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3027         if feature is present.
3028         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3029         Add 'segments' parameter to call to i386_target_description.
3030         (i386_target_description): Add 'segments' parameter to enable
3031         segment base registers.
3032         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3033         to call to i386_target_description.
3034         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3035         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3036         Define I386_NUM_REGS.
3037         (i386_target_description): Add 'segments' parameter to enable
3038         segment base registers.
3039
3040 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3041
3042         PR/24325
3043         * source-cache.c: #undef open and close, to avoid unresolved
3044         externals during linking.
3045
3046 2019-03-12  Tom Tromey  <tromey@adacore.com>
3047
3048         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3049         const.  Add initializers.
3050         (_initialize_remote): Don't initialize ptid globals.
3051
3052 2019-03-12  Pedro Alves  <palves@redhat.com>
3053
3054         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3055
3056 2019-03-12  Pedro Alves  <palves@redhat.com>
3057
3058         * cp-name-parser.y (main): Remove unused 'len' variable.
3059
3060 2019-03-12  Tom Tromey  <tromey@adacore.com>
3061
3062         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3063         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3064
3065 2019-03-12  Tom Tromey  <tromey@adacore.com>
3066
3067         * linux-nat.c (iterate_over_lwps): Update.
3068         (stop_callback): Remove parameter.
3069         (stop_wait_callback, detach_callback, resume_set_callback)
3070         (select_singlestep_lwp_callback, set_ignore_sigint)
3071         (status_callback, resumed_callback, resume_clear_callback)
3072         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3073         data parameter.
3074         (linux_nat_target::detach, linux_nat_target::resume)
3075         (linux_stop_and_wait_all_lwps, select_event_lwp)
3076         (linux_nat_filter_event, linux_nat_wait_1)
3077         (linux_nat_target::kill, linux_nat_target::stop)
3078         (linux_nat_target::stop): Update.
3079         (linux_nat_resume_callback): Change type.
3080         (resume_stopped_resumed_lwps, count_events_callback)
3081         (select_event_lwp_callback): Likewise.
3082         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3083         * arm-linux-nat.c (struct update_registers_data): Remove.
3084         (update_registers_callback): Change type.
3085         (arm_linux_insert_hw_breakpoint1): Update.
3086         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3087         parameter.
3088         (x86_linux_dr_set_addr): Update.
3089         (x86_linux_dr_set_control): Update.
3090         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3091         (iterate_over_lwps): Use gdb::function_view.
3092         * nat/aarch64-linux-hw-point.c (struct
3093         aarch64_dr_update_callback_param): Remove.
3094         (debug_reg_change_callback): Change type.
3095         (aarch64_notify_debug_reg_change): Update.
3096         * s390-linux-nat.c (s390_refresh_per_info): Update.
3097
3098 2019-03-11  Tom Tromey  <tromey@adacore.com>
3099
3100         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3101         redundant assignment to "this_cu".
3102
3103 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3104
3105         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3106
3107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3108
3109         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3110         from...
3111         (rank_one_type): ... this.
3112
3113 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3114
3115         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3116         from...
3117         (rank_one_type): ... this.
3118
3119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3120
3121         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3122         from...
3123         (rank_one_type): ... this.
3124
3125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3126
3127         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3128         from...
3129         (rank_one_type): ... this.
3130
3131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3132
3133         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3134         from...
3135         (rank_one_type): ... this.
3136
3137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3138
3139         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3140         from...
3141         (rank_one_type): ... this.
3142
3143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3144
3145         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3146         from...
3147         (rank_one_type): ... this.
3148
3149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3150
3151         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3152         from...
3153         (rank_one_type): ... this.
3154
3155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3156
3157         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3158         from...
3159         (rank_one_type): ... this.
3160
3161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3162
3163         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3164         from...
3165         (rank_one_type): ... this.
3166
3167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3168
3169         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3170         from...
3171         (rank_one_type): ... this.
3172
3173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3174
3175         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3176         from...
3177         (rank_one_type): ... this.
3178
3179 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3180
3181         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3182         inferior-events' shows the example events.
3183
3184 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3185
3186         Support styling on native MS-Windows console
3187
3188         PR/24315
3189         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3190         on MS-Windows if $TERM is not defined.
3191
3192         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3193
3194         * posix-hdep.c (gdb_console_fputs):
3195         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3196         functions.
3197         * ui-file.h (gdb_console_fputs): Add prototype.
3198
3199         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3200         back to fputs only if the former returns zero.
3201
3202 2019-03-07  Tom Tromey  <tom@tromey.com>
3203
3204         * symmisc.c (print_symbol_bcache_statistics): Update.
3205         (print_objfile_statistics): Update.
3206         * symfile.c (allocate_symtab): Update.
3207         * stabsread.c: Don't include bcache.h.
3208         * psymtab.h (struct psymbol_bcache): Don't declare.
3209         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3210         (psymbol_bcache_init, psymbol_bcache_free)
3211         (psymbol_bcache_get_bcache): Don't declare.
3212         * psymtab.c (struct psymbol_bcache): Remove.
3213         (psymtab_storage::psymtab_storage): Update.
3214         (psymtab_storage::~psymtab_storage): Update.
3215         (psymbol_bcache_init, psymbol_bcache_free)
3216         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3217         (add_psymbol_to_bcache): Update.
3218         (allocate_psymtab): Update.
3219         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3220         macro_cache>: No longer pointers.
3221         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3222         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3223         * macrotab.c (macro_bcache): Update.
3224         * macroexp.c: Don't include bcache.h.
3225         * gdbtypes.c (check_types_worklist): Update.
3226         (types_deeply_equal): Remove TRY/CATCH.  Update.
3227         * elfread.c (elf_symtab_read): Update.
3228         * dwarf2read.c: Don't include bcache.h.
3229         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3230         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3231         (print_bcache_statistics, bcache_memory_used): Don't declare.
3232         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3233         methods.  Rename all data members.
3234         * bcache.c (struct bcache): Move to bcache.h.
3235         (bcache::expand_hash_table): Rename from expand_hash_table.
3236         (bcache): Remove.
3237         (bcache::insert): Rename from bcache_full.
3238         (bcache::compare): Rename from bcache_compare.
3239         (bcache_xmalloc): Remove.
3240         (bcache::~bcache): Rename from bcache_xfree.
3241         (bcache::print_statistics): Rename from print_bcache_statistics.
3242         (bcache::memory_used): Rename from bcache_memory_used.
3243
3244 2019-03-07  Pedro Alves  <palves@redhat.com>
3245
3246         * infrun.c (normal_stop): Also check for
3247         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3248
3249 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3250
3251         * f-lang.c (value_from_host_double): Moved to...
3252         * value.c (value_from_host_double): ...here.
3253         * value.h (value_from_host_double): Declare.
3254         * guile/scm-math.c (vlscm_convert_typed_number): Use
3255         value_from_host_double.
3256         (vlscm_convert_number): Likewise.
3257         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3258         * python/py-value.c (convert_value_from_python): Likewise.
3259
3260 2019-03-06  Tom Tromey  <tom@tromey.com>
3261
3262         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3263
3264 2019-03-06  Tom Tromey  <tom@tromey.com>
3265
3266         * utils.h (free_current_contents): Don't declare.
3267         * utils.c (free_current_contents): Remove.
3268
3269 2019-03-06  Tom Tromey  <tom@tromey.com>
3270
3271         * top.c (quit_force): Update.
3272         * main.c (captured_command_loop): Update.
3273         * common/new-op.c (operator new): Update.
3274         * common/common-exceptions.c (struct catcher)
3275         <save_cleanup_chain>: Remove member.
3276         (exceptions_state_mc_init): Update.
3277         (exception_try_scope_entry): Return nullptr.
3278         (exception_try_scope_exit, exception_rethrow)
3279         (throw_exception_sjlj, throw_exception_cxx): Update.
3280         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3281         (all_cleanups, do_cleanups, discard_cleanups)
3282         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3283         (restore_cleanups, restore_final_cleanups): Don't declare.
3284         (do_final_cleanups): Remove parameter.
3285         * common/cleanups.c (cleanup_chain, make_cleanup)
3286         (make_cleanup_dtor, all_cleanups, do_cleanups)
3287         (discard_my_cleanups, discard_cleanups)
3288         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3289         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3290         (null_cleanup): Remove.
3291         (do_final_cleanups): Remove parameter.
3292
3293 2019-03-06  Tom Tromey  <tom@tromey.com>
3294
3295         * remote.c (remote_target::remote_parse_stop_reply): Use
3296         unique_xmalloc_ptr.
3297
3298 2019-03-06  Tom Tromey  <tom@tromey.com>
3299
3300         * stabsread.c (struct stabs_field_info): Rename from field_info.
3301         <list, fnlist>: Add initializers.
3302         <obstack>: New member.
3303         (read_member_functions, read_struct_fields, read_baseclasses):
3304         Allocate on obstack.  Don't use cleanups.
3305         (read_one_struct_field, read_member_functions, read_struct_fields)
3306         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3307         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3308         (read_struct_type): Update.
3309
3310 2019-03-06  Tom Tromey  <tom@tromey.com>
3311
3312         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3313         * common/filestuff.h (make_cleanup_close): Don't declare.
3314         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3315         Remove.
3316
3317 2019-03-06  Tom Tromey  <tom@tromey.com>
3318
3319         * solib-aix.c: Use make_scope_exit.
3320
3321 2019-03-06  Tom Tromey  <tom@tromey.com>
3322
3323         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3324         Use make_scope_exit.
3325
3326 2019-03-06  Tom Tromey  <tom@tromey.com>
3327
3328         * solib-svr4.c (disable_probes_interface): Remove parameter.
3329         (svr4_handle_solib_event): Use make_scope_exit.
3330
3331 2019-03-06  Tom Tromey  <tom@tromey.com>
3332
3333         * remote.c (struct stop_reply_deleter): Remove.
3334         (stop_reply_up): Update.
3335         (struct stop_reply): Derive from notif_event.  Don't typedef.
3336         <regcache>: Now a std::vector.
3337         (stop_reply_xfree): Remove.
3338         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3339         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3340         (remote_target::discard_pending_stop_replies): Use delete.
3341         (remote_target::remote_parse_stop_reply): Update.
3342         (remote_target::process_stop_reply): Update.
3343         * remote-notif.h (struct notif_event): Add virtual destructor.
3344         Remove "dtr" member.
3345         (struct notif_client) <alloc_event>: Return a unique_ptr.
3346         (notif_event_xfree): Don't declare.
3347         (notif_event_up): New typedef.
3348         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3349         (notif_event_xfree, do_notif_event_xfree): Remove.
3350         (remote_notif_state_xfree): Update.
3351
3352 2019-03-06  Tom Tromey  <tom@tromey.com>
3353
3354         * infrun.c (displaced_step_clear_cleanup): Now a
3355         forward_scope_exit type.
3356         (displaced_step_prepare_throw): Update.
3357         (displaced_step_fixup): Update.
3358
3359 2019-03-06  Tom Tromey  <tom@tromey.com>
3360
3361         * inferior.h (class inferior): Update comment.
3362         * gdbthread.h (class thread_info): Update comment.
3363
3364 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3365             Tom Tromey  <tom@tromey.com>
3366
3367         * stabsread.h (struct stab_section_list): Remove.
3368         (coffstab_build_psymtabs): Update.
3369         * dbxread.c (symbuf_sections): Now a std::vector.
3370         (sect_idx): New global.
3371         (fill_symbuf): Update.
3372         (coffstab_build_psymtabs): Change type of stabsects parameter.
3373         Update.
3374         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3375         std::vector.
3376         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3377         (coff_locate_sections): Update.
3378         (coff_symfile_read): Remove cleanups.  Update.
3379         (init_stringtab): Add storage parameter.
3380         (free_stringtab, free_stringtab_cleanup): Remove.
3381         (init_lineno): Add storage parameter.
3382         (free_linetab, free_linetab_cleanup): Remove.
3383
3384 2019-03-06  Pedro Alves  <palves@redhat.com>
3385
3386         * linux-fork.c (fork_info::clobber_regs): Delete.
3387         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3388         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3389         comment.  Adjust.
3390         (scoped_switch_fork_info::scoped_switch_fork_info)
3391         (checkpoint_command, linux_fork_context): Adjust
3392         fork_save_infrun_state calls.
3393
3394 2019-03-06  Pedro Alves  <palves@redhat.com>
3395
3396         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3397         (inf_has_multiple_threads): Return 'bool' and rewrite using
3398         inferior_info::threads().
3399
3400 2019-03-06  Pedro Alves  <palves@redhat.com>
3401
3402         * linux-fork.c: Include <list>.
3403         (fork_list): Now a std::list instance.
3404         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3405         (forks_exist_p, find_last_fork): Adjust.
3406         (new_fork): Delete.
3407         (one_fork_p): New.
3408         (add_fork): Adjust.
3409         (free_fork): Delete, folded into fork_info::~fork_info().
3410         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3411         Adjust.
3412         (init_fork_list): Delete.
3413         (linux_fork_killall, linux_fork_mourn_inferior)
3414         (linux_fork_detach, info_checkpoints_command): Adjust.
3415         (_initialize_linux_fork): No longer call init_fork_list.
3416
3417 2019-03-06  Pedro Alves  <palves@redhat.com>
3418
3419         * linux-fork.c (new_fork): New, split out of ...
3420         (add_fork): ... this.  Return void.  Move "first fork" special
3421         case from here, to ...
3422         (checkpoint_command): ... here.
3423         * linux-linux.h (add_fork): Return void.
3424
3425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3426
3427         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3428
3429 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3430             Chris January  <chris.january@arm.com>
3431             David Lecomber  <david.lecomber@arm.com>
3432
3433         * f-exp.y: New token, UNOP_INTRINSIC.
3434         (exp): New pattern using UNOP_INTRINSIC token.
3435         (f77_keywords): Add 'abs' keyword.
3436         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3437         (value_from_host_double): New function.
3438         (evaluate_subexp_f): Support UNOP_ABS.
3439
3440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3441
3442         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3443         types.
3444
3445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3446
3447         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3448         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3449         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3450
3451 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3454
3455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3456             Chris January  <chris.january@arm.com>
3457
3458         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3459         * f-exp.y: Define 'KIND' token.
3460         (exp): New pattern for KIND expressions.
3461         (ptype): Handle types with a kind extension.
3462         (direct_abs_decl): Extend to spot kind extensions.
3463         (f77_keywords): Add 'kind' to the list.
3464         (push_kind_type): New function.
3465         (convert_to_kind_type): New function.
3466         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3467         * parse.c (operator_length_standard): Likewise.
3468         * parser-defs.h (enum type_pieces): Add tp_kind.
3469         * std-operator.def: Add UNOP_KIND.
3470
3471 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3472
3473         * f-exp.y (f_parse): Set yydebug.
3474
3475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3476
3477         * f-lang.c (evaluate_subexp_f): New function.
3478         (exp_descriptor_f): New global.
3479         (f_language_defn): Use exp_descriptor_f instead of
3480         exp_descriptor_standard.
3481
3482 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3483
3484         * f-exp.y (struct token): Add comments.
3485         (dot_ops): Remove uppercase versions and the end marker.
3486         (f77_keywords): Likewise.
3487         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3488         entries in the dot_ops array are case insensitive, and use
3489         strncasecmp to compare strings.  Also some whitespace cleanup in
3490         this area.  Similar for the f77_keywords array, except entries in
3491         this list might be case sensitive.
3492
3493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3494
3495         * f-exp.y (struct f77_boolean_val): Add comments.
3496         (boolean_values): Remove uppercase versions, and end marker.
3497         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3498         and use strncasecmp to achieve case insensitivity.  Additionally,
3499         perform whitespace cleanup around this code.
3500
3501 2019-03-06  Tom Tromey  <tromey@adacore.com>
3502
3503         * remote-sim.c (gdbsim_target_open): Use result of
3504         gdb_argv::release.
3505
3506 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3507         Dirk Schubert  <dirk.schubert@arm.com>
3508         Chris January  <chris.january@arm.com>
3509
3510         * eval.c (evaluate_subexp_standard): Call Fortran argument
3511         wrapping logic.
3512         * f-lang.c (struct value): A value which can be passed into a
3513         Fortran function call.
3514         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3515         where appropriate.
3516         (struct type): Value ready for a Fortran function call.
3517         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3518         is needed.
3519         * f-lang.h (fortran_argument_convert): Declaration.
3520         (fortran_preserve_arg_pointer): Declaration.
3521         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3522
3523 2019-03-05  Tom Tromey  <tromey@adacore.com>
3524
3525         * python/py-prettyprint.c (print_string_repr): Remove #if.
3526         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3527
3528 2019-03-05  Tom Tromey  <tromey@adacore.com>
3529
3530         * target.c (the_dummy_target): Move later.  Change type to
3531         "dummy_target".
3532         (initialize_targets): Don't initialize the_dummy_target.
3533
3534 2019-03-05  Tom Tromey  <tromey@adacore.com>
3535
3536         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3537         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3538
3539 2019-03-05  Tom Tromey  <tromey@adacore.com>
3540
3541         * windows-nat.c (windows_nat_target::attach)
3542         (windows_nat_target::detach): Don't call gdb_flush.
3543         * valprint.c (generic_val_print, val_print, val_print_string):
3544         Don't call gdb_flush.
3545         * utils.c (defaulted_query): Don't call gdb_flush.
3546         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3547         * target.c (target_announce_detach): Don't call gdb_flush.
3548         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3549         * remote.c (extended_remote_target::attach): Don't call
3550         gdb_flush.
3551         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3552         * printcmd.c (do_examine): Don't call gdb_flush.
3553         (info_display_command): Don't call gdb_flush.
3554         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3555         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3556         * memattr.c (info_mem_command): Don't call gdb_flush.
3557         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3558         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3559         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3560         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3561         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3562         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3563         (gnu_nat_target::detach): Don't call gdb_flush.
3564         * f-valprint.c (f_val_print): Don't call gdb_flush.
3565         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3566         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3567         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3568         gdb_flush.
3569         * c-valprint.c (c_val_print): Don't call gdb_flush.
3570         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3571
3572 2019-03-05  Tom Tromey  <tromey@adacore.com>
3573
3574         * varobj.c (update_dynamic_varobj_children): Update.
3575         (install_default_visualizer): Use reset, not release.
3576         * value.c (set_internalvar): Update.
3577         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3578         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3579         ATTRIBUTE_UNUSED_RESULT.
3580
3581 2019-03-05  Tom Tromey  <tromey@adacore.com>
3582
3583         * remote.c (class scoped_remote_fd) <release>: Add
3584         ATTRIBUTE_UNUSED_RESULT.
3585
3586 2019-03-05  Tom Tromey  <tromey@adacore.com>
3587
3588         * macroexp.c (struct macro_buffer) <release>: Add
3589         ATTRIBUTE_UNUSED_RESULT.
3590
3591 2019-03-05  Tom Tromey  <tromey@adacore.com>
3592
3593         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3594         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3595         ATTRIBUTE_UNUSED_RESULT.
3596
3597 2019-03-05  Tom Tromey  <tromey@adacore.com>
3598
3599         * common/scoped_fd.h (class scoped_fd) <release>: Add
3600         ATTRIBUTE_UNUSED_RESULT.
3601
3602 2019-03-05  Tom Tromey  <tromey@adacore.com>
3603
3604         * parser-defs.h (struct parser_state) <release>: Add
3605         ATTRIBUTE_UNUSED_RESULT.
3606
3607 2019-03-05  Tom Tromey  <tromey@adacore.com>
3608
3609         * utils.h (class gdb_argv) <release>: Add
3610         ATTRIBUTE_UNUSED_RESULT.
3611         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3612
3613 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3614
3615         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3616         for-loop range, to avoid compiler warnings.
3617
3618         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3619         avoid compiler warnings about unused variables.
3620
3621         * NEWS: Mention end of support for native debugging on MS-Windows
3622         before XP.
3623
3624         PR gdb/24292
3625         * common/netstuff.c:
3626         * gdbserver/gdbreplay.c
3627         * gdbserver/remote-utils.c:
3628         * ser-tcp.c:
3629         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3630         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3631         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3632         'getaddrinfo' and 'freeaddrinfo' were not available before
3633         Windows XP, and mingw.org's MinGW headers by default define
3634         _WIN32_WINNT to 0x500.
3635
3636 2019-03-01  Gary Benson <gbenson@redhat.com>
3637
3638         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3639
3640 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3641             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3642
3643         PR gdb/8527
3644         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3645         set_sigint_trap, clear_sigint_trap.
3646
3647 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3648
3649         * target.c (target_detach): Clear the regcache and the
3650         frame cache.
3651
3652 2019-02-27  Pedro Alves  <palves@redhat.com>
3653
3654         * utils.c (set_screen_size): When we cap the height/width sizes,
3655         tweak the corresponding command variable to show "unlimited":
3656
3657 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3658             Pedro Alves  <palves@redhat.com>
3659
3660         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3661         before calling rl_set_screen_size.
3662
3663 2019-02-27  Tom Tromey  <tromey@adacore.com>
3664
3665         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3666         define.
3667         * python/py-value.c: Remove Python 2.4 workaround.
3668         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3669         workaround.
3670         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3671         Python 2.4 workaround.
3672         * python/python-internal.h: Remove Python 2.4 comment.
3673         (Py_ssize_t): Don't define.
3674         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3675         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3676         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3677         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3678         * python/python.c (do_start_initialization): Remove Python 2.4
3679         workaround.
3680         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3681         (print_children): Remove Python 2.4 workaround.
3682         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3683         workaround.
3684         (CHARBUFFERPROC_NAME): Remove.
3685         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3686         Python 2.4 workaround.
3687
3688 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3689
3690         * NEWS: Note minimum Python version.
3691
3692 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3693
3694         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3695         code from these functions.  Remove corresponding ifdefs.  Use
3696         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3697         Remove gotos and target of gotos.
3698         (infpy_search_memory): Likewise.
3699
3700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3703         (hppa_gdbarch_init): Don't register deleted functions with
3704         gdbarch.
3705
3706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3709         (h8300_unwind_sp): Delete.
3710         (h8300_dummy_id): Delete.
3711         (h8300_gdbarch_init): Don't register deleted functions with
3712         gdbarch.
3713
3714 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3715
3716         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3717         (ft32_unwind_pc): Delete.
3718         (ft32_unwind_sp): Delete.
3719         (ft32_gdbarch_init): Don't register deleted functions with
3720         gdbarch.
3721
3722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3725         (frv_unwind_pc): Delete.
3726         (frv_unwind_sp): Delete.
3727         (frv_gdbarch_init): Don't register deleted functions with
3728         gdbarch.
3729
3730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3733         (riscv_unwind_pc): Delete.
3734         (riscv_unwind_sp): Delete.
3735         (riscv_gdbarch_init): Don't register deleted functions with
3736         gdbarch.
3737
3738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3741         (csky_unwind_pc): Delete.
3742         (csky_unwind_sp): Delete.
3743         (csky_gdbarch_init): Don't register deleted functions with
3744         gdbarch.
3745
3746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3749         (cris_unwind_pc): Delete.
3750         (cris_unwind_sp): Delete.
3751         (cris_gdbarch_init): Don't register deleted functions with
3752         gdbarch.
3753
3754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3757         (bfin_unwind_pc): Delete.
3758         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3759
3760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3761
3762         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3763         (arm_unwind_pc): Delete.
3764         (arm_unwind_sp): Delete.
3765         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3766
3767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3770         (arc_unwind_pc): Delete.
3771         (arc_unwind_sp): Delete.
3772         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3773
3774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3777         (alpha_unwind_pc): Delete.
3778         (alpha_gdbarch_init): Don't register deleted functions with
3779         gdbarch.
3780
3781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3784         (aarch64_unwind_pc): Delete.
3785         (aarch64_unwind_sp): Delete.
3786         (aarch64_gdbarch_init): Don't register deleted functions with
3787         gdbarch.
3788
3789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * gdbtypes.c (type_align): Don't consider static members when
3792         computing structure alignment.
3793
3794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3797         return 0 for other types.
3798         * arch-utils.c (default_type_align): Always return 0.
3799         * gdbarch.h: Regenerate.
3800         * gdbarch.sh (type_align): Extend comment.
3801         * gdbtypes.c (type_align): Add additional comments, always call
3802         gdbarch_type_align before applying the default rules.
3803         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3804         generic code will then apply a suitable default.
3805         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3806         types, return 0 for other types.
3807
3808 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3809
3810         * NEWS: Create a new section for the next release branch.
3811         Rename the section of the current branch, now that it has
3812         been cut.
3813
3814 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3815
3816         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3817         * version.in: Bump version to 8.3.50.DATE-git.
3818
3819 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3820
3821         * aix-thread.c (ptid_cmp): Remove unused variable.
3822         (get_signaled_thread): Likewise.
3823         (store_regs_user_thread): Likewise.
3824         (store_regs_kernel_thread): Likewise.
3825         (fetch_regs_kernel_thread): Remove shadowed variable.
3826
3827 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3828
3829         * features/riscv/32bit-cpu.xml: Add register numbers.
3830         * features/riscv/32bit-fpu.c: Regenerate.
3831         * features/riscv/32bit-fpu.xml: Add register numbers.
3832         * features/riscv/64bit-cpu.xml: Add register numbers.
3833         * features/riscv/64bit-fpu.c: Regenerate.
3834         * features/riscv/64bit-fpu.xml: Add register numbers.
3835
3836 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3837
3838         * NEWS: Mention two argument form of gdb.Value constructor.
3839         * python/py-value.c (convert_buffer_and_type_to_value): New
3840         function.
3841         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3842         Add support for handling an optional second argument.  Call
3843         convert_buffer_and_type_to_value as appropriate.
3844         * python/python-internal.h (Py_buffer_deleter): New struct.
3845         (Py_buffer_up): New typedef.
3846
3847 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3848
3849         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3850         instead of releasing ownership.
3851
3852 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3853
3854         * dwarf2read.c (open_and_init_dwp_file): Call
3855         elf_numsections instead of bfd_count_sections to initialize
3856         dwp_file->num_sections.
3857
3858 2019-02-25  Tom Tromey  <tromey@adacore.com>
3859
3860         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3861
3862 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3863
3864         * gcore.in: Add '--readnever' option when invoking GDB.
3865
3866 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3867
3868         * MAINTAINERS: Update my email address.
3869
3870 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3871
3872         * build-id.c (build_id_to_debug_bfd_1): New function.
3873         (build_id_to_debug_bfd): Look for separate debug file in
3874         sysroot.
3875
3876 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * gdbarch.sh: Update the copyright year range that is placed into
3879         generated files.
3880
3881 2019-02-22  Keith Seitz  <keiths@redhat.com>
3882
3883         PR symtab/23853
3884         * linespec.c (create_sals_line_offset): Search for the default
3885         symtab's filename instead of its fullname.
3886
3887 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3888
3889         * NEWS: Update style defaults.
3890
3891 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3892
3893         * main.c (captured_main_1): Disable styling in batch mode.
3894
3895 2019-02-20  Tom Tromey  <tom@tromey.com>
3896
3897         * symtab.c (symtab_symbol_info): Fix typos.
3898
3899 2019-02-20  Tom Tromey  <tromey@adacore.com>
3900
3901         * findcmd.c (_initialize_mem_search): Use upper case for
3902         metasyntactic variables.
3903
3904 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3905
3906         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3907         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3908
3909 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3910
3911         * top.h (source_file_name): Change to std::string.
3912         * top.c (source_file_name): Likewise.
3913         (command_line_input): Adjust.
3914         * cli/cli-script.c (script_from_file): Adjust.
3915
3916 2019-02-19  Tom Tromey  <tromey@adacore.com>
3917
3918         * ravenscar-thread.c
3919         (ravenscar_thread_target::update_thread_list): Don't call
3920         ada_build_task_list.
3921         * ada-lang.h (ada_build_task_list): Don't declare.
3922         * ada-tasks.c (struct ada_tasks_inferior_data)
3923         <task_list_valid_p>: Now bool.
3924         (read_known_tasks, ada_task_list_changed)
3925         (ada_tasks_invalidate_inferior_data): Update.
3926         (read_known_tasks_array): Return bool.
3927         (read_known_tasks_list): Likewise.
3928         (read_known_tasks): Return void.
3929         (ada_build_task_list): Now static.
3930
3931 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3934         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3935
3936 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3937
3938         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3939         variant for ada_tasks_pspace_data_handle and
3940         ada_tasks_inferior_data_handle.
3941         (ada_tasks_pspace_data_cleanup): New function.
3942         (ada_tasks_inferior_data_cleanup): New function.
3943
3944 2019-02-17  Tom Tromey  <tom@tromey.com>
3945
3946         * macrotab.h (macro_source_fullname): Return a std::string.
3947         * macrotab.c (macro_include, check_for_redefinition)
3948         (macro_undef, macro_lookup_definition, foreach_macro)
3949         (foreach_macro_in_scope): Update.
3950         (macro_source_fullname): Return a std::string.
3951         * macrocmd.c (show_pp_source_pos): Update.
3952
3953 2019-02-17  Tom Tromey  <tom@tromey.com>
3954
3955         * macrocmd.c (show_pp_source_pos): Style the file names.
3956
3957 2019-02-17  Tom Tromey  <tom@tromey.com>
3958
3959         PR tui/24197:
3960         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3961
3962 2019-02-17  Tom Tromey  <tom@tromey.com>
3963
3964         * ada-lang.c (user_select_syms): Use filtered printing.
3965         * utils.c (wrap_style): New global.
3966         (desired_style): Remove.
3967         (emit_style_escape): Add stream parameter.
3968         (set_output_style, reset_terminal_style, prompt_for_continue):
3969         Update.
3970         (flush_wrap_buffer): Only flush gdb_stdout.
3971         (wrap_here): Set wrap_style.
3972         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3973         treat escape sequences as a character.  Change when wrap buffer is
3974         flushed.
3975         (fputs_styled): Do not set the output style when the default is
3976         requested.
3977         * ui-style.h (struct ui_file_style) <is_default>: New method.
3978         * source.c (print_source_lines_base): Emit escape sequences in one
3979         piece.
3980
3981 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3982
3983         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3984         integers and enumeration types.
3985
3986 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3987
3988         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3989         instead of lookup_symbol_in_language
3990         (do_exact_match): New function.
3991         (ada_get_symbol_name_matcher): Return do_exact_match when
3992         doing a verbatim match.
3993
3994 2019-02-15  Tom Tromey  <tromey@adacore.com>
3995
3996         * ravenscar-thread.c (ravenscar_thread_target::resume)
3997         (ravenscar_thread_target::wait): Special case wildcard requests.
3998
3999 2019-02-15  Tom Tromey  <tromey@adacore.com>
4000
4001         * ravenscar-thread.c (base_ptid): Remove.
4002         (struct ravenscar_thread_target) <close>: New method.
4003         <m_base_ptid>: New member.
4004         <update_inferior_ptid, active_task, task_is_currently_active,
4005         runtime_initialized>: Declare methods.
4006         <ravenscar_thread_target>: Add constructor.
4007         (ravenscar_thread_target::task_is_currently_active)
4008         (ravenscar_thread_target::update_inferior_ptid)
4009         (ravenscar_runtime_initialized): Rename.  Now methods.
4010         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4011         (ravenscar_thread_target::update_thread_list): Update.
4012         (ravenscar_thread_target::active_task): Now method.
4013         (ravenscar_thread_target::store_registers)
4014         (ravenscar_thread_target::prepare_to_store)
4015         (ravenscar_thread_target::prepare_to_store)
4016         (ravenscar_thread_target::mourn_inferior): Update.
4017         (ravenscar_inferior_created): Use "new" to create target.
4018         (ravenscar_thread_target::get_ada_task_ptid): Update.
4019         (_initialize_ravenscar): Don't initialize base_ptid.
4020         (ravenscar_ops): Remove global.
4021
4022 2019-02-15  Tom Tromey  <tromey@adacore.com>
4023
4024         * target.h (push_target): Declare new overload.
4025         * target.c (push_target): New overload, taking an rvalue reference.
4026         * remote.c (remote_target::open_1): Use push_target overload.
4027         * corelow.c (core_target_open): Use push_target overload.
4028
4029 2019-02-15  Tom Tromey  <tromey@adacore.com>
4030
4031         * ravenscar-thread.c (is_ravenscar_task)
4032         (ravenscar_task_is_currently_active): Return bool.
4033         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4034         (_initialize_ravenscar): Remove "(void)".
4035         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4036         Return bool.
4037
4038 2019-02-15  Tom Tromey  <tromey@adacore.com>
4039
4040         * ravenscar-thread.c (ravenscar_runtime_initializer)
4041         (has_ravenscar_runtime, get_running_thread_id)
4042         (ravenscar_thread_target::resume): Fix indentation.
4043
4044 2019-02-15  Tom Tromey  <tromey@adacore.com>
4045
4046         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4047         from ravenscar_arch_ops.
4048         (sparc_ravenscar_ops::fetch_registers)
4049         (sparc_ravenscar_ops::store_registers): Now methods.
4050         (sparc_ravenscar_prepare_to_store): Remove.
4051         (sparc_ravenscar_ops): Redefine.
4052         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4053         methods and destructor.  Remove members.
4054         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4055         (ravenscar_thread_target::store_registers)
4056         (ravenscar_thread_target::prepare_to_store): Update.
4057         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4058         Remove.
4059         (struct ppc_ravenscar_powerpc_ops): Derive from
4060         ravenscar_arch_ops.
4061         (ppc_ravenscar_powerpc_ops::fetch_registers)
4062         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4063         (ppc_ravenscar_powerpc_ops): Redefine.
4064         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4065         (ppc_ravenscar_e500_ops::fetch_registers)
4066         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4067         (ppc_ravenscar_e500_ops): Redefine.
4068         * aarch64-ravenscar-thread.c
4069         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4070         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4071         (aarch64_ravenscar_fetch_registers)
4072         (aarch64_ravenscar_store_registers): Now methods.
4073         (aarch64_ravenscar_ops): Redefine.
4074
4075 2019-02-15  Tom Tromey  <tromey@adacore.com>
4076
4077         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4078         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4079         (ravenscar_thread_target::stopped_by_watchpoint)
4080         (ravenscar_thread_target::stopped_data_address)
4081         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4082
4083 2019-02-15  Tom Tromey  <tromey@adacore.com>
4084
4085         * ravenscar-thread.c: Fix some typos.
4086
4087 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4088             Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-lang.c (ada_exception_sal): Change addr_string to a
4091         std::string.
4092         (create_ada_exception_catchpoint): Update.
4093
4094 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4095             Tom Tromey  <tromey@adacore.com>
4096
4097         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4098         (bp_location_ops): Remove.
4099         (base_breakpoint_allocate_location): Update.
4100         (free_bp_location): Update.
4101         * ada-lang.c (class ada_catchpoint_location)
4102         <ada_catchpoint_location>: Remove ops parameter.
4103         (ada_catchpoint_location_dtor): Remove.
4104         (ada_catchpoint_location_ops): Remove.
4105         (allocate_location_exception): Update.
4106         * breakpoint.h (struct bp_location_ops): Remove.
4107         (class bp_location) <bp_location>: Remove bp_location_ops
4108         parameter.
4109         <~bp_location>: Add destructor.
4110         <ops>: Remove.
4111
4112 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4113             Pedro Alves  <palves@redhat.com>
4114
4115         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4116         'PATH_MAX'.
4117
4118 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4119             Samuel Thibault  <samuel.thibault@gnu.org>
4120             Thomas Schwinge  <thomas@codesourcery.com>
4121
4122         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4123         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4124
4125 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4126
4127         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4128         (check_empty): Use "const char *".
4129
4130         * gnu-nat.c (gnu_nat_target::detach): Instead of
4131         'detach_inferior (pid)' call
4132         'detach_inferior (find_inferior_pid (pid))'.
4133
4134         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4135         'nat/fork-inferior.o'.
4136         * gnu-nat.c: #include "nat/fork-inferior.h".
4137
4138         * gnu-nat.c (gnu_nat_target::detach): Instead of
4139         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4140         * gnu-nat.h: #include "inf-child.h".
4141         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4142         'i386_gnu_nat_target::fetch_registers'.
4143         (gnu_store_registers): Rename/move to
4144         'i386_gnu_nat_target::store_registers'.
4145
4146         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4147         * gnu-nat.h (mach_thread_info): New function.
4148         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4149
4150         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4151
4152 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4153
4154         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4155
4156 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4157
4158         * windows-nat.c (windows_add_thread): Add new parameter
4159         "main_thread_p" with default value set to false.  Update
4160         function documentation as well as all callers.
4161         (windows_delete_thread): Likewise.
4162         (fake_create_process): Update call to windows_add_thread.
4163         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4164         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4165         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4166         call to windows_delete_thread.
4167
4168 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4169
4170         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4171
4172 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4173
4174         * symfile.c (find_separate_debug_file): Use canonical path of
4175         sysroot with child_path instead of gdb_sysroot if it is valid.
4176
4177 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4178
4179         * symfile.c (find_separate_debug_file): Use child_path to
4180         determine if an object file is under a sysroot.
4181
4182 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4183
4184         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4185         unittests/child-path-selftests.c.
4186         * common/pathstuff.c (child_path): New function.
4187         * common/pathstuff.h (child_path): New prototype.
4188         * unittests/child-path-selftests.c: New file.
4189
4190 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4191
4192         * symfile.c (find_separate_debug_file): Look for separate debug
4193         files in debug directories under the sysroot.
4194
4195 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4196
4197         * symtab.h (struct minimal_symbol data_p): New const method.
4198         (struct minimal_symbol text_p): Likewise.
4199         * symtab.c (output_source_filename): Use file name style
4200         to print file name.
4201         (print_symbol_info): Likewise.
4202         (print_msymbol_info): Use address style to print addresses.
4203         Use function name style to print executable text symbols.
4204         (expand_symtab_containing_pc): Use data_p.
4205         (find_pc_sect_compunit_symtab): Likewise.
4206
4207 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4208
4209         * breakpoint.c (describe_other_breakpoints): Use address style
4210         to print addresses.
4211         (say_where): Likewise.
4212
4213 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4214
4215         * ada-typeprint.c (print_func_type): Print function name
4216         style to print function name.
4217         * c-typeprint.c (c_print_type_1): Likewise.
4218
4219 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4220
4221         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4222         for execve.
4223
4224 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4225
4226         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4227         type_stack.
4228
4229 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4230
4231         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4232         TYPE_CODE_REF types.
4233
4234 2019-02-08  Jim Wilson  <jimw@sifive.com>
4235
4236         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4237         (riscv_linux_fregset): New.
4238         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4239
4240 2019-02-07  Tom Tromey  <tom@tromey.com>
4241
4242         * thread.c (thread_cancel_execution_command): Update.
4243         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4244         methods.
4245         (struct thread_fsm_ops): Remove.
4246         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4247         (thread_fsm_should_stop, thread_fsm_return_value)
4248         (thread_fsm_set_finished, thread_fsm_finished_p)
4249         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4250         Don't declare.
4251         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4252         * infrun.c (clear_proceed_status_thread)
4253         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4254         (print_stop_event): Update.
4255         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4256         Add constructor.
4257         (step_command_fsm_ops): Remove.
4258         (new_step_command_fsm): Remove.
4259         (step_1): Update.
4260         (step_command_fsm::should_stop): Rename from
4261         step_command_fsm_should_stop.
4262         (step_command_fsm::clean_up): Rename from
4263         step_command_fsm_clean_up.
4264         (step_command_fsm::do_async_reply_reason): Rename from
4265         step_command_fsm_async_reply_reason.
4266         (struct until_next_fsm): Inherit from thread_fsm.  Add
4267         constructor.
4268         (until_next_fsm_ops): Remove.
4269         (new_until_next_fsm): Remove.
4270         (until_next_fsm::should_stop): Rename from
4271         until_next_fsm_should_stop.
4272         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4273         (until_next_fsm::do_async_reply_reason): Rename from
4274         until_next_fsm_async_reply_reason.
4275         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4276         constructor.  Change type of breakpoint.
4277         (finish_command_fsm_ops): Remove.
4278         (new_finish_command_fsm): Remove.
4279         (finish_command_fsm::should_stop): Rename from
4280         finish_command_fsm_should_stop.
4281         (finish_command_fsm::clean_up): Rename from
4282         finish_command_fsm_clean_up.
4283         (finish_command_fsm::return_value): Rename from
4284         finish_command_fsm_return_value.
4285         (finish_command_fsm::do_async_reply_reason): Rename from
4286         finish_command_fsm_async_reply_reason.
4287         (finish_command): Update.
4288         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4289         Add constructor.
4290         (call_thread_fsm_ops): Remove.
4291         (call_thread_fsm::call_thread_fsm): Rename from
4292         new_call_thread_fsm.
4293         (call_thread_fsm::should_stop): Rename from
4294         call_thread_fsm_should_stop.
4295         (call_thread_fsm::should_notify_stop): Rename from
4296         call_thread_fsm_should_notify_stop.
4297         (run_inferior_call, call_function_by_hand_dummy): Update.
4298         * cli/cli-interp.c (should_print_stop_to_console): Update.
4299         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4300         Add constructor.  Change type of location_breakpoint,
4301         caller_breakpoint.
4302         (until_break_fsm_ops): Remove.
4303         (new_until_break_fsm): Remove.
4304         (until_break_fsm::should_stop): Rename from
4305         until_break_fsm_should_stop.
4306         (until_break_fsm::clean_up): Rename from
4307         until_break_fsm_clean_up.
4308         (until_break_fsm::do_async_reply_reason): Rename from
4309         until_break_fsm_async_reply_reason.
4310         (until_break_command): Update.
4311         * thread-fsm.c: Remove.
4312         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4313
4314 2019-02-07  Tom Tromey  <tom@tromey.com>
4315
4316         * yy-remap.h: Add include guard.
4317         * xtensa-tdep.h: Add include guard.
4318         * xcoffread.h: Rename include guard.
4319         * varobj-iter.h: Add include guard.
4320         * tui/tui.h: Rename include guard.
4321         * tui/tui-winsource.h: Rename include guard.
4322         * tui/tui-wingeneral.h: Rename include guard.
4323         * tui/tui-windata.h: Rename include guard.
4324         * tui/tui-win.h: Rename include guard.
4325         * tui/tui-stack.h: Rename include guard.
4326         * tui/tui-source.h: Rename include guard.
4327         * tui/tui-regs.h: Rename include guard.
4328         * tui/tui-out.h: Rename include guard.
4329         * tui/tui-layout.h: Rename include guard.
4330         * tui/tui-io.h: Rename include guard.
4331         * tui/tui-hooks.h: Rename include guard.
4332         * tui/tui-file.h: Rename include guard.
4333         * tui/tui-disasm.h: Rename include guard.
4334         * tui/tui-data.h: Rename include guard.
4335         * tui/tui-command.h: Rename include guard.
4336         * tic6x-tdep.h: Add include guard.
4337         * target/waitstatus.h: Rename include guard.
4338         * target/wait.h: Rename include guard.
4339         * target/target.h: Rename include guard.
4340         * target/resume.h: Rename include guard.
4341         * target-float.h: Rename include guard.
4342         * stabsread.h: Add include guard.
4343         * rs6000-tdep.h: Add include guard.
4344         * riscv-fbsd-tdep.h: Add include guard.
4345         * regformats/regdef.h: Rename include guard.
4346         * record.h: Rename include guard.
4347         * python/python.h: Rename include guard.
4348         * python/python-internal.h: Rename include guard.
4349         * python/py-stopevent.h: Rename include guard.
4350         * python/py-ref.h: Rename include guard.
4351         * python/py-record.h: Rename include guard.
4352         * python/py-record-full.h: Rename include guard.
4353         * python/py-record-btrace.h: Rename include guard.
4354         * python/py-instruction.h: Rename include guard.
4355         * python/py-events.h: Rename include guard.
4356         * python/py-event.h: Rename include guard.
4357         * procfs.h: Add include guard.
4358         * proc-utils.h: Add include guard.
4359         * p-lang.h: Add include guard.
4360         * or1k-tdep.h: Rename include guard.
4361         * observable.h: Rename include guard.
4362         * nto-tdep.h: Rename include guard.
4363         * nat/x86-linux.h: Rename include guard.
4364         * nat/x86-linux-dregs.h: Rename include guard.
4365         * nat/x86-gcc-cpuid.h: Add include guard.
4366         * nat/x86-dregs.h: Rename include guard.
4367         * nat/x86-cpuid.h: Rename include guard.
4368         * nat/ppc-linux.h: Rename include guard.
4369         * nat/mips-linux-watch.h: Rename include guard.
4370         * nat/linux-waitpid.h: Rename include guard.
4371         * nat/linux-ptrace.h: Rename include guard.
4372         * nat/linux-procfs.h: Rename include guard.
4373         * nat/linux-osdata.h: Rename include guard.
4374         * nat/linux-nat.h: Rename include guard.
4375         * nat/linux-namespaces.h: Rename include guard.
4376         * nat/linux-btrace.h: Rename include guard.
4377         * nat/glibc_thread_db.h: Rename include guard.
4378         * nat/gdb_thread_db.h: Rename include guard.
4379         * nat/gdb_ptrace.h: Rename include guard.
4380         * nat/fork-inferior.h: Rename include guard.
4381         * nat/amd64-linux-siginfo.h: Rename include guard.
4382         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4383         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4384         * nat/aarch64-linux.h: Rename include guard.
4385         * nat/aarch64-linux-hw-point.h: Rename include guard.
4386         * mn10300-tdep.h: Add include guard.
4387         * mips-linux-tdep.h: Add include guard.
4388         * mi/mi-parse.h: Rename include guard.
4389         * mi/mi-out.h: Rename include guard.
4390         * mi/mi-main.h: Rename include guard.
4391         * mi/mi-interp.h: Rename include guard.
4392         * mi/mi-getopt.h: Rename include guard.
4393         * mi/mi-console.h: Rename include guard.
4394         * mi/mi-common.h: Rename include guard.
4395         * mi/mi-cmds.h: Rename include guard.
4396         * mi/mi-cmd-break.h: Rename include guard.
4397         * m2-lang.h: Add include guard.
4398         * location.h: Rename include guard.
4399         * linux-record.h: Rename include guard.
4400         * linux-nat.h: Add include guard.
4401         * linux-fork.h: Add include guard.
4402         * i386-darwin-tdep.h: Rename include guard.
4403         * hppa-linux-offsets.h: Add include guard.
4404         * guile/guile.h: Rename include guard.
4405         * guile/guile-internal.h: Rename include guard.
4406         * gnu-nat.h: Rename include guard.
4407         * gdb-stabs.h: Rename include guard.
4408         * frv-tdep.h: Add include guard.
4409         * f-lang.h: Add include guard.
4410         * event-loop.h: Add include guard.
4411         * darwin-nat.h: Rename include guard.
4412         * cp-abi.h: Rename include guard.
4413         * config/sparc/nm-sol2.h: Rename include guard.
4414         * config/nm-nto.h: Rename include guard.
4415         * config/nm-linux.h: Add include guard.
4416         * config/i386/nm-i386gnu.h: Rename include guard.
4417         * config/djgpp/nl_types.h: Rename include guard.
4418         * config/djgpp/langinfo.h: Rename include guard.
4419         * compile/gcc-cp-plugin.h: Add include guard.
4420         * compile/gcc-c-plugin.h: Add include guard.
4421         * compile/compile.h: Rename include guard.
4422         * compile/compile-object-run.h: Rename include guard.
4423         * compile/compile-object-load.h: Rename include guard.
4424         * compile/compile-internal.h: Rename include guard.
4425         * compile/compile-cplus.h: Rename include guard.
4426         * compile/compile-c.h: Rename include guard.
4427         * common/xml-utils.h: Rename include guard.
4428         * common/x86-xstate.h: Rename include guard.
4429         * common/version.h: Rename include guard.
4430         * common/vec.h: Rename include guard.
4431         * common/tdesc.h: Rename include guard.
4432         * common/selftest.h: Rename include guard.
4433         * common/scoped_restore.h: Rename include guard.
4434         * common/scoped_mmap.h: Rename include guard.
4435         * common/scoped_fd.h: Rename include guard.
4436         * common/safe-iterator.h: Rename include guard.
4437         * common/run-time-clock.h: Rename include guard.
4438         * common/refcounted-object.h: Rename include guard.
4439         * common/queue.h: Rename include guard.
4440         * common/ptid.h: Rename include guard.
4441         * common/print-utils.h: Rename include guard.
4442         * common/preprocessor.h: Rename include guard.
4443         * common/pathstuff.h: Rename include guard.
4444         * common/observable.h: Rename include guard.
4445         * common/netstuff.h: Rename include guard.
4446         * common/job-control.h: Rename include guard.
4447         * common/host-defs.h: Rename include guard.
4448         * common/gdb_wait.h: Rename include guard.
4449         * common/gdb_vecs.h: Rename include guard.
4450         * common/gdb_unlinker.h: Rename include guard.
4451         * common/gdb_unique_ptr.h: Rename include guard.
4452         * common/gdb_tilde_expand.h: Rename include guard.
4453         * common/gdb_sys_time.h: Rename include guard.
4454         * common/gdb_string_view.h: Rename include guard.
4455         * common/gdb_splay_tree.h: Rename include guard.
4456         * common/gdb_setjmp.h: Rename include guard.
4457         * common/gdb_ref_ptr.h: Rename include guard.
4458         * common/gdb_optional.h: Rename include guard.
4459         * common/gdb_locale.h: Rename include guard.
4460         * common/gdb_assert.h: Rename include guard.
4461         * common/filtered-iterator.h: Rename include guard.
4462         * common/filestuff.h: Rename include guard.
4463         * common/fileio.h: Rename include guard.
4464         * common/environ.h: Rename include guard.
4465         * common/common-utils.h: Rename include guard.
4466         * common/common-types.h: Rename include guard.
4467         * common/common-regcache.h: Rename include guard.
4468         * common/common-inferior.h: Rename include guard.
4469         * common/common-gdbthread.h: Rename include guard.
4470         * common/common-exceptions.h: Rename include guard.
4471         * common/common-defs.h: Rename include guard.
4472         * common/common-debug.h: Rename include guard.
4473         * common/cleanups.h: Rename include guard.
4474         * common/buffer.h: Rename include guard.
4475         * common/btrace-common.h: Rename include guard.
4476         * common/break-common.h: Rename include guard.
4477         * cli/cli-utils.h: Rename include guard.
4478         * cli/cli-style.h: Rename include guard.
4479         * cli/cli-setshow.h: Rename include guard.
4480         * cli/cli-script.h: Rename include guard.
4481         * cli/cli-interp.h: Rename include guard.
4482         * cli/cli-decode.h: Rename include guard.
4483         * cli/cli-cmds.h: Rename include guard.
4484         * charset-list.h: Add include guard.
4485         * buildsym-legacy.h: Rename include guard.
4486         * bfin-tdep.h: Add include guard.
4487         * ax.h: Rename include guard.
4488         * arm-linux-tdep.h: Add include guard.
4489         * arm-fbsd-tdep.h: Add include guard.
4490         * arch/xtensa.h: Rename include guard.
4491         * arch/tic6x.h: Add include guard.
4492         * arch/i386.h: Add include guard.
4493         * arch/arm.h: Rename include guard.
4494         * arch/arm-linux.h: Rename include guard.
4495         * arch/arm-get-next-pcs.h: Rename include guard.
4496         * arch/amd64.h: Add include guard.
4497         * arch/aarch64-insn.h: Rename include guard.
4498         * arch-utils.h: Rename include guard.
4499         * annotate.h: Add include guard.
4500         * amd64-darwin-tdep.h: Rename include guard.
4501         * aarch64-linux-tdep.h: Add include guard.
4502         * aarch64-fbsd-tdep.h: Add include guard.
4503         * aarch32-linux-nat.h: Add include guard.
4504
4505 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4506
4507         * macrotab.c (macro_define_internal): New function that
4508         factorizes macro_define_object_internal and macro_define_function
4509         code.
4510         (macro_define_object_internal): Use macro_define_internal.
4511         (macro_define_function): Likewise.
4512
4513 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4514
4515         * macrocmd.c (extract_identifier): Return
4516         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4517         callers.
4518
4519 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4520
4521         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4522
4523 2019-02-05  Tom Tromey  <tom@tromey.com>
4524
4525         * target.c (target_stack::unpush): Move assertion earlier.
4526
4527 2019-01-30  Tom Tromey  <tom@tromey.com>
4528
4529         PR python/23615:
4530         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4531         (gdbpy_parse_and_eval): Likewise.
4532         * python/python-internal.h (gdbpy_allow_threads): New class.
4533
4534 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4535
4536         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4537         (aarch64_fbsd_fpregmap): Move earlier.
4538         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4539         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4540         instead of individual calls to trad_frame_set_reg_addr.
4541         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4542         earlier.
4543         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4544         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4545         instead of individual calls to trad_frame_set_reg_addr.
4546
4547 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4548
4549         * CONTRIBUTE: Replace contribution list with wiki link.
4550
4551 2019-01-25  Tom Tromey  <tom@tromey.com>
4552
4553         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4554
4555 2019-01-25  Tom Tromey  <tom@tromey.com>
4556
4557         * xtensa-linux-nat.c: Fix common/ includes.
4558         * xml-support.h: Fix common/ includes.
4559         * xml-support.c: Fix common/ includes.
4560         * x86-linux-nat.c: Fix common/ includes.
4561         * windows-nat.c: Fix common/ includes.
4562         * varobj.h: Fix common/ includes.
4563         * varobj.c: Fix common/ includes.
4564         * value.c: Fix common/ includes.
4565         * valops.c: Fix common/ includes.
4566         * utils.c: Fix common/ includes.
4567         * unittests/xml-utils-selftests.c: Fix common/ includes.
4568         * unittests/utils-selftests.c: Fix common/ includes.
4569         * unittests/unpack-selftests.c: Fix common/ includes.
4570         * unittests/tracepoint-selftests.c: Fix common/ includes.
4571         * unittests/style-selftests.c: Fix common/ includes.
4572         * unittests/string_view-selftests.c: Fix common/ includes.
4573         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4574         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4575         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4576         * unittests/rsp-low-selftests.c: Fix common/ includes.
4577         * unittests/parse-connection-spec-selftests.c: Fix common/
4578         includes.
4579         * unittests/optional-selftests.c: Fix common/ includes.
4580         * unittests/offset-type-selftests.c: Fix common/ includes.
4581         * unittests/observable-selftests.c: Fix common/ includes.
4582         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4583         * unittests/memrange-selftests.c: Fix common/ includes.
4584         * unittests/memory-map-selftests.c: Fix common/ includes.
4585         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4586         * unittests/function-view-selftests.c: Fix common/ includes.
4587         * unittests/environ-selftests.c: Fix common/ includes.
4588         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4589         * unittests/common-utils-selftests.c: Fix common/ includes.
4590         * unittests/cli-utils-selftests.c: Fix common/ includes.
4591         * unittests/array-view-selftests.c: Fix common/ includes.
4592         * ui-file.c: Fix common/ includes.
4593         * tui/tui-io.c: Fix common/ includes.
4594         * tracepoint.h: Fix common/ includes.
4595         * tracepoint.c: Fix common/ includes.
4596         * tracefile-tfile.c: Fix common/ includes.
4597         * top.h: Fix common/ includes.
4598         * top.c: Fix common/ includes.
4599         * thread.c: Fix common/ includes.
4600         * target/waitstatus.h: Fix common/ includes.
4601         * target/waitstatus.c: Fix common/ includes.
4602         * target.h: Fix common/ includes.
4603         * target.c: Fix common/ includes.
4604         * target-memory.c: Fix common/ includes.
4605         * target-descriptions.c: Fix common/ includes.
4606         * symtab.h: Fix common/ includes.
4607         * symfile.c: Fix common/ includes.
4608         * stap-probe.c: Fix common/ includes.
4609         * spu-linux-nat.c: Fix common/ includes.
4610         * sparc-nat.c: Fix common/ includes.
4611         * source.c: Fix common/ includes.
4612         * solib.c: Fix common/ includes.
4613         * solib-target.c: Fix common/ includes.
4614         * ser-unix.c: Fix common/ includes.
4615         * ser-tcp.c: Fix common/ includes.
4616         * ser-pipe.c: Fix common/ includes.
4617         * ser-base.c: Fix common/ includes.
4618         * selftest-arch.c: Fix common/ includes.
4619         * s12z-tdep.c: Fix common/ includes.
4620         * rust-exp.y: Fix common/ includes.
4621         * rs6000-aix-tdep.c: Fix common/ includes.
4622         * riscv-tdep.c: Fix common/ includes.
4623         * remote.c: Fix common/ includes.
4624         * remote-notif.h: Fix common/ includes.
4625         * remote-fileio.h: Fix common/ includes.
4626         * remote-fileio.c: Fix common/ includes.
4627         * regcache.h: Fix common/ includes.
4628         * regcache.c: Fix common/ includes.
4629         * record-btrace.c: Fix common/ includes.
4630         * python/python.c: Fix common/ includes.
4631         * python/py-type.c: Fix common/ includes.
4632         * python/py-inferior.c: Fix common/ includes.
4633         * progspace.h: Fix common/ includes.
4634         * producer.c: Fix common/ includes.
4635         * procfs.c: Fix common/ includes.
4636         * proc-api.c: Fix common/ includes.
4637         * printcmd.c: Fix common/ includes.
4638         * ppc-linux-nat.c: Fix common/ includes.
4639         * parser-defs.h: Fix common/ includes.
4640         * osdata.c: Fix common/ includes.
4641         * obsd-nat.c: Fix common/ includes.
4642         * nat/x86-linux.c: Fix common/ includes.
4643         * nat/x86-linux-dregs.c: Fix common/ includes.
4644         * nat/x86-dregs.h: Fix common/ includes.
4645         * nat/x86-dregs.c: Fix common/ includes.
4646         * nat/ppc-linux.c: Fix common/ includes.
4647         * nat/mips-linux-watch.h: Fix common/ includes.
4648         * nat/mips-linux-watch.c: Fix common/ includes.
4649         * nat/linux-waitpid.c: Fix common/ includes.
4650         * nat/linux-ptrace.h: Fix common/ includes.
4651         * nat/linux-ptrace.c: Fix common/ includes.
4652         * nat/linux-procfs.c: Fix common/ includes.
4653         * nat/linux-personality.c: Fix common/ includes.
4654         * nat/linux-osdata.c: Fix common/ includes.
4655         * nat/linux-namespaces.c: Fix common/ includes.
4656         * nat/linux-btrace.h: Fix common/ includes.
4657         * nat/linux-btrace.c: Fix common/ includes.
4658         * nat/fork-inferior.c: Fix common/ includes.
4659         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4660         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4661         * nat/aarch64-linux.c: Fix common/ includes.
4662         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4663         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4664         * namespace.h: Fix common/ includes.
4665         * mips-linux-tdep.c: Fix common/ includes.
4666         * minsyms.c: Fix common/ includes.
4667         * mi/mi-parse.h: Fix common/ includes.
4668         * mi/mi-main.c: Fix common/ includes.
4669         * mi/mi-cmd-env.c: Fix common/ includes.
4670         * memrange.h: Fix common/ includes.
4671         * memattr.c: Fix common/ includes.
4672         * maint.h: Fix common/ includes.
4673         * maint.c: Fix common/ includes.
4674         * main.c: Fix common/ includes.
4675         * machoread.c: Fix common/ includes.
4676         * location.c: Fix common/ includes.
4677         * linux-thread-db.c: Fix common/ includes.
4678         * linux-nat.c: Fix common/ includes.
4679         * linux-fork.c: Fix common/ includes.
4680         * inline-frame.c: Fix common/ includes.
4681         * infrun.c: Fix common/ includes.
4682         * inflow.c: Fix common/ includes.
4683         * inferior.h: Fix common/ includes.
4684         * inferior.c: Fix common/ includes.
4685         * infcmd.c: Fix common/ includes.
4686         * inf-ptrace.c: Fix common/ includes.
4687         * inf-child.c: Fix common/ includes.
4688         * ia64-linux-nat.c: Fix common/ includes.
4689         * i387-tdep.c: Fix common/ includes.
4690         * i386-tdep.c: Fix common/ includes.
4691         * i386-linux-tdep.c: Fix common/ includes.
4692         * i386-linux-nat.c: Fix common/ includes.
4693         * i386-go32-tdep.c: Fix common/ includes.
4694         * i386-fbsd-tdep.c: Fix common/ includes.
4695         * i386-fbsd-nat.c: Fix common/ includes.
4696         * guile/scm-type.c: Fix common/ includes.
4697         * guile/guile.c: Fix common/ includes.
4698         * go32-nat.c: Fix common/ includes.
4699         * gnu-nat.c: Fix common/ includes.
4700         * gdbthread.h: Fix common/ includes.
4701         * gdbarch-selftests.c: Fix common/ includes.
4702         * gdb_usleep.c: Fix common/ includes.
4703         * gdb_select.h: Fix common/ includes.
4704         * gdb_bfd.c: Fix common/ includes.
4705         * gcore.c: Fix common/ includes.
4706         * fork-child.c: Fix common/ includes.
4707         * findvar.c: Fix common/ includes.
4708         * fbsd-nat.c: Fix common/ includes.
4709         * event-top.c: Fix common/ includes.
4710         * event-loop.c: Fix common/ includes.
4711         * dwarf2read.c: Fix common/ includes.
4712         * dwarf2loc.c: Fix common/ includes.
4713         * dwarf2-frame.c: Fix common/ includes.
4714         * dwarf-index-cache.c: Fix common/ includes.
4715         * dtrace-probe.c: Fix common/ includes.
4716         * disasm-selftests.c: Fix common/ includes.
4717         * defs.h: Fix common/ includes.
4718         * csky-tdep.c: Fix common/ includes.
4719         * cp-valprint.c: Fix common/ includes.
4720         * cp-support.h: Fix common/ includes.
4721         * cp-support.c: Fix common/ includes.
4722         * corelow.c: Fix common/ includes.
4723         * completer.h: Fix common/ includes.
4724         * completer.c: Fix common/ includes.
4725         * compile/compile.c: Fix common/ includes.
4726         * compile/compile-loc2c.c: Fix common/ includes.
4727         * compile/compile-cplus-types.c: Fix common/ includes.
4728         * compile/compile-cplus-symbols.c: Fix common/ includes.
4729         * command.h: Fix common/ includes.
4730         * cli/cli-dump.c: Fix common/ includes.
4731         * cli/cli-cmds.c: Fix common/ includes.
4732         * charset.c: Fix common/ includes.
4733         * build-id.c: Fix common/ includes.
4734         * btrace.h: Fix common/ includes.
4735         * btrace.c: Fix common/ includes.
4736         * breakpoint.h: Fix common/ includes.
4737         * breakpoint.c: Fix common/ includes.
4738         * ax.h:
4739         (enum agent_op): Fix common/ includes.
4740         * ax-general.c (struct aop_map): Fix common/ includes.
4741         * ax-gdb.c: Fix common/ includes.
4742         * auxv.c: Fix common/ includes.
4743         * auto-load.c: Fix common/ includes.
4744         * arm-tdep.c: Fix common/ includes.
4745         * arch/riscv.c: Fix common/ includes.
4746         * arch/ppc-linux-common.c: Fix common/ includes.
4747         * arch/i386.c: Fix common/ includes.
4748         * arch/arm.c: Fix common/ includes.
4749         * arch/arm-linux.c: Fix common/ includes.
4750         * arch/arm-get-next-pcs.c: Fix common/ includes.
4751         * arch/amd64.c: Fix common/ includes.
4752         * arch/aarch64.c: Fix common/ includes.
4753         * arch/aarch64-insn.c: Fix common/ includes.
4754         * arch-utils.c: Fix common/ includes.
4755         * amd64-windows-tdep.c: Fix common/ includes.
4756         * amd64-tdep.c: Fix common/ includes.
4757         * amd64-sol2-tdep.c: Fix common/ includes.
4758         * amd64-obsd-tdep.c: Fix common/ includes.
4759         * amd64-nbsd-tdep.c: Fix common/ includes.
4760         * amd64-linux-tdep.c: Fix common/ includes.
4761         * amd64-linux-nat.c: Fix common/ includes.
4762         * amd64-fbsd-tdep.c: Fix common/ includes.
4763         * amd64-fbsd-nat.c: Fix common/ includes.
4764         * amd64-dicos-tdep.c: Fix common/ includes.
4765         * amd64-darwin-tdep.c: Fix common/ includes.
4766         * agent.c: Fix common/ includes.
4767         * ada-lang.h: Fix common/ includes.
4768         * ada-lang.c: Fix common/ includes.
4769         * aarch64-tdep.c: Fix common/ includes.
4770
4771 2019-01-25  Tom Tromey  <tom@tromey.com>
4772
4773         * common/create-version.sh: Use common/version.h.
4774
4775 2019-01-24  Pedro Alves  <palves@redhat.com>
4776
4777         * infrun.c (signal_stop, signal_print, signal_program)
4778         (signal_catch, signal_pass): Now arrays instead of pointers.
4779         (update_signals_program_target, do_target_resume)
4780         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4781         * linux-nat.c (linux_nat_target::pass_signals)
4782         (linux_nat_target::create_inferior, linux_nat_target::attach):
4783         Adjust.
4784         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4785         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4786         * procfs.c (procfs_target::pass_signals): Adjust.
4787         * record-full.c (record_full_target::resume): Adjust.
4788         * remote.c (remote_target::pass_signals)
4789         (remote_target::program_signals): Adjust.
4790         * target-debug.h (target_debug_print_signals): Now takes a
4791         gdb::array_view as parameter.  Adjust.
4792         * target.h (target_ops) <pass_signals, program_signals>: Replace
4793         pointer and length parameters with gdb::array_view.
4794         (target_pass_signals, target_program_signals): Likewise.
4795         * target-delegates.c: Regenerate.
4796
4797 2019-01-24  Pedro Alves  <palves@redhat.com>
4798
4799         * common/forward-scope-exit.h
4800         (forward_scope_exit::forward_scope_exit): Pass arguments to
4801         m_bind_function directly, instead of creating a std::bind and
4802         copying that.
4803
4804 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4805
4806         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4807         for static members.
4808         (pass_in_v_vfp_candidate): Likewise.
4809
4810 2019-01-23  Tom Tromey  <tom@tromey.com>
4811             Pedro Alves  <palves@redhat.com>
4812
4813         * regcache.c (class regcache_invalidator): Remove.
4814         (regcache::raw_write): Use make_scope_exit.
4815
4816 2019-01-23  Tom Tromey  <tom@tromey.com>
4817
4818         * ui-out.h (class ui_out_emit_type): Update comment.
4819
4820 2019-01-23  Tom Tromey  <tom@tromey.com>
4821
4822         * infrun.c (fetch_inferior_event): Update comment.
4823
4824 2019-01-23  Tom Tromey  <tom@tromey.com>
4825             Pedro Alves  <palves@redhat.com>
4826
4827         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4828         parameter.
4829         (fetch_inferior_event): Use SCOPE_EXIT.
4830
4831
4832 2019-01-23  Tom Tromey  <tom@tromey.com>
4833             Pedro Alves  <palves@redhat.com>
4834
4835         * infrun.c (disable_thread_events): Delete.
4836         (stop_all_threads): Use SCOPE_EXIT.
4837
4838 2019-01-23  Tom Tromey  <tom@tromey.com>
4839             Pedro Alves  <palves@redhat.com>
4840
4841         * symfile.c: Include forward-scope-exit.h.
4842         (clear_symtab_users_cleanup): Replace forward declaration with
4843         a FORWARD_SCOPE_EXIT.
4844         (syms_from_objfile_1): Use the forward_scope_exit and
4845         gdb::optional instead of cleanup_function.
4846         (reread_symbols): Use the forward_scope_exit instead of
4847         cleanup_function.
4848         (clear_symtab_users_cleanup): Remove function.
4849
4850 2019-01-23  Tom Tromey  <tom@tromey.com>
4851             Pedro Alves  <palves@redhat.com>
4852
4853         * linux-nat.c: Include scope-exit.h.
4854         (cleanup_target_stop): Remove.
4855         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4856         SCOPE_EXIT.
4857
4858 2019-01-23  Tom Tromey  <tom@tromey.com>
4859             Pedro Alves  <palves@redhat.com>
4860
4861         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4862         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4863
4864 2019-01-23  Tom Tromey  <tom@tromey.com>
4865             Andrew Burgess  <andrew.burgess@embecosm.com>
4866             Pedro Alves  <palves@redhat.com>
4867
4868         * infrun.c (fetch_inferior_event): Use scope_exit.
4869         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4870         * top.c (execute_command): Use scope_exit.
4871         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4872         * utils.c (do_bpstat_clear_actions_cleanup)
4873         (make_bpstat_clear_actions_cleanup): Remove.
4874
4875 2019-01-23  Tom Tromey  <tom@tromey.com>
4876             Pedro Alves  <palves@redhat.com>
4877
4878         * infrun.c: Include "common/scope-exit.h"
4879         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4880         (wait_for_inferior): Use SCOPE_EXIT.
4881         (fetch_inferior_event): Use scope_exit.
4882
4883 2019-01-23  Tom Tromey  <tom@tromey.com>
4884             Pedro Alves  <palves@redhat.com>
4885
4886         * breakpoint.c (create_breakpoint): Remove cleanup.
4887
4888 2019-01-23  Tom Tromey  <tom@tromey.com>
4889             Andrew Burgess  <andrew.burgess@embecosm.com>
4890             Pedro Alves  <palves@redhat.com>
4891
4892 2019-01-23  Pedro Alves  <palves@redhat.com>
4893
4894         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4895
4896 2019-01-23  Pedro Alves  <palves@redhat.com>
4897             Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * gdbthread.h: Include "common/forward-scope-exit.h".
4900         (scoped_finish_thread_state): Redefine custom class in terms of
4901         forward_scope_exit.
4902
4903 2019-01-23  Pedro Alves  <palves@redhat.com>
4904             Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * common/forward-scope-exit.h: New file.
4907
4908 2019-01-23  Pedro Alves  <palves@redhat.com>
4909             Andrew Burgess  <andrew.burgess@embecosm.com>
4910             Tom Tromey  <tom@tromey.com>
4911
4912         * common/scope-exit.h: New file.
4913
4914 2019-01-23  Pedro Alves  <palves@redhat.com>
4915
4916         * common/preprocessor.h (ESC): Rename to ...
4917         (ESC_PARENS): ... this.
4918         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4919         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4920
4921 2019-01-23  Tom Tromey  <tom@tromey.com>
4922
4923         * language.h (class scoped_switch_to_sym_language_if_auto):
4924         Initialize m_lang in both cases.
4925
4926 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4927
4928         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4929         with XCNEW.
4930
4931 2019-01-22  Tom Tromey  <tom@tromey.com>
4932
4933         * corelow.c: Do not include sys/file.h.
4934
4935 2019-01-22  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-wingeneral.h: Include gdb_curses.h.
4938
4939 2019-01-22  Tom Tromey  <tom@tromey.com>
4940
4941         * source-cache.h (class source_cache) <get_source_lines,
4942         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4943
4944 2019-01-22  Tom Tromey  <tom@tromey.com>
4945
4946         * remote-fileio.h (struct remote_target): Declare.
4947
4948 2019-01-22  Tom Tromey  <tom@tromey.com>
4949
4950         * python/py-arch.c: Do not include py-ref.h.
4951         * python/py-bpevent.c: Do not include py-ref.h.
4952         * python/py-cmd.c: Do not include py-ref.h.
4953         * python/py-continueevent.c: Do not include py-ref.h.
4954         * python/py-event.h: Do not include py-ref.h.
4955         * python/py-evtregistry.c: Do not include py-ref.h.
4956         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4957         * python/py-frame.c: Do not include py-ref.h.
4958         * python/py-framefilter.c: Do not include py-ref.h.
4959         * python/py-function.c: Do not include py-ref.h.
4960         * python/py-infevents.c: Do not include py-ref.h.
4961         * python/py-linetable.c: Do not include py-ref.h.
4962         * python/py-objfile.c: Do not include py-ref.h.
4963         * python/py-param.c: Do not include py-ref.h.
4964         * python/py-prettyprint.c: Do not include py-ref.h.
4965         * python/py-progspace.c: Do not include py-ref.h.
4966         * python/py-symbol.c: Do not include py-ref.h.
4967         * python/py-symtab.c: Do not include py-ref.h.
4968         * python/py-type.c: Do not include py-ref.h.
4969         * python/py-unwind.c: Do not include py-ref.h.
4970         * python/py-utils.c: Do not include py-ref.h.
4971         * python/py-value.c: Do not include py-ref.h.
4972         * python/py-varobj.c: Do not include py-ref.h.
4973         * python/py-xmethods.c: Do not include py-ref.h.
4974         * python/python.c: Do not include py-ref.h.
4975         * varobj.c: Do not include py-ref.h.
4976
4977 2019-01-22  Tom Tromey  <tom@tromey.com>
4978
4979         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4980         keyword for bcache.
4981
4982 2019-01-22  Tom Tromey  <tom@tromey.com>
4983
4984         * compile/compile-cplus-types.c: Remove a comment by #include.
4985
4986 2019-01-22  Tom Tromey  <tom@tromey.com>
4987
4988         * compile/gcc-c-plugin.h: Include compile-internal.h.
4989
4990 2019-01-22  Tom Tromey  <tom@tromey.com>
4991
4992         * stabsread.c (EXTERN): Do not define.
4993         (symnum, next_symbol_text_func, processing_gcc_compilation)
4994         (within_function, global_sym_chain, global_stabs)
4995         (previous_stab_code, this_object_header_files)
4996         (n_this_object_header_files)
4997         (n_allocated_this_object_header_files): Define.
4998         * stabsread.h (EXTERN): Never define.  Use "extern".
4999
5000 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5001
5002         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5003         history_value.
5004
5005 2019-01-21  Tom Tromey  <tom@tromey.com>
5006
5007         * ui-out.c: Fix includes.
5008         * tui/tui-source.c: Fix includes.
5009         * target.c: Fix includes.
5010         * remote.c: Fix includes.
5011         * regcache.c: Fix includes.
5012         * python/py-block.c: Fix includes.
5013         * printcmd.c: Fix includes.
5014         * or1k-tdep.c: Fix includes.
5015         * mi/mi-main.c: Fix includes.
5016         * m32r-tdep.c: Fix includes.
5017         * csky-tdep.c: Fix includes.
5018         * compile/compile-cplus-types.c: Fix includes.
5019         * cli/cli-interp.c: Fix includes.
5020
5021 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5022
5023         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5024         for padding.
5025
5026 2019-01-16  Tom Tromey  <tom@tromey.com>
5027
5028         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5029         earlier.
5030         (struct objfile) <msymbols_range>: Move from top level.
5031         <msymbols>: New method.
5032         (class objfile_msymbols): Remove.
5033         * symtab.c (default_collect_symbol_completion_matches_break_on):
5034         Update.
5035         * symmisc.c (dump_msymbols): Update.
5036         * stabsread.c (scan_file_globals): Update.
5037         * objc-lang.c (info_selectors_command, info_classes_command)
5038         (find_methods): Update.
5039         * minsyms.c (find_solib_trampoline_target): Update.
5040         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5041         * coffread.c (coff_symfile_read): Update.
5042         * ada-lang.c (ada_lookup_simple_minsym)
5043         (ada_collect_symbol_completion_matches): Update.
5044
5045 2019-01-16  Tom Tromey  <tom@tromey.com>
5046
5047         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5048         type.  Remove no-argument constructor.
5049         <iterator::operator++>: Simplify.
5050         <begin>: Update.
5051         <end>: Use minimal_symbol_count.
5052
5053 2019-01-16  Tom Tromey  <tom@tromey.com>
5054
5055         * objfiles.h (struct objfile) <psymtabs>: New method.
5056         (class objfile_psymtabs): Remove.
5057         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5058         typedef.
5059         <range>: New method.
5060         (require_partial_symbols): Change return type.
5061         * psymtab.c (require_partial_symbols)
5062         (psym_expand_symtabs_matching): Update.
5063         * mdebugread.c (parse_partial_symbols): Update.
5064         * dbxread.c (dbx_end_psymtab): Update.
5065
5066 2019-01-15  Tom Tromey  <tom@tromey.com>
5067
5068         * symtab.c (lookup_objfile_from_block)
5069         (lookup_symbol_in_objfile_symtabs)
5070         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5071         (find_line_symtab, info_sources_command)
5072         (default_collect_symbol_completion_matches_break_on)
5073         (make_source_files_completion_list): Update.
5074         * symmisc.c (print_objfile_statistics, dump_objfile)
5075         (maintenance_print_symbols, maintenance_info_symtabs)
5076         (maintenance_check_symtabs, maintenance_info_line_tables):
5077         Update.
5078         * source.c (select_source_symtab)
5079         (forget_cached_source_info_for_objfile): Update.
5080         * objfiles.h (class objfile_compunits): Remove.
5081         (struct objfile) <compunits_range>: New typedef.
5082         (compunits): New method.
5083         * objfiles.c (objfile_relocate1): Update.
5084         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5085         * maint.c (count_symtabs_and_blocks): Update.
5086         * linespec.c (iterate_over_all_matching_symtabs): Update.
5087         * cp-support.c (add_symbol_overload_list_qualified): Update.
5088         * coffread.c (coff_symtab_read): Update.
5089         * ada-lang.c (add_nonlocal_symbols)
5090         (ada_collect_symbol_completion_matches)
5091         (ada_add_global_exceptions): Update.
5092
5093 2019-01-15  Tom Tromey  <tom@tromey.com>
5094
5095         * progspace.h (program_space) <objfiles_safe_range>: New
5096         typedef.
5097         <objfiles_safe>: New method.
5098         * objfiles.h (class all_objfiles_safe): Remove.
5099         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5100         * jit.c (jit_inferior_exit_hook): Update.
5101
5102 2019-01-17  Tom Tromey  <tom@tromey.com>
5103
5104         * progspace.h (program_space) <objfiles_range>: New typedef.
5105         <objfiles>: New method.
5106         <objfiles_head>: Rename from objfiles.
5107         (object_files): Update.
5108         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5109         * guile/scm-pretty-print.c
5110         (ppscm_find_pretty_printer_from_objfiles): Update.
5111         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5112         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5113         Update.
5114         * python/py-progspace.c (pspy_get_objfiles): Update.
5115         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5116         Update.
5117         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5118         (objfpy_lookup_objfile_by_build_id): Update.
5119         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5120         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5121         Update.
5122         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5123         (expand_symtab_containing_pc, lookup_objfile_from_block)
5124         (lookup_static_symbol, basic_lookup_transparent_type)
5125         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5126         (find_line_symtab, info_sources_command)
5127         (default_collect_symbol_completion_matches_break_on)
5128         (make_source_files_completion_list, find_main_name): Update.
5129         * symmisc.c (print_symbol_bcache_statistics)
5130         (print_objfile_statistics, maintenance_print_symbols)
5131         (maintenance_print_msymbols, maintenance_print_objfiles)
5132         (maintenance_info_symtabs, maintenance_check_symtabs)
5133         (maintenance_expand_symtabs, maintenance_info_line_tables):
5134         Update.
5135         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5136         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5137         (map_overlay_command, unmap_overlay_command)
5138         (simple_overlay_update, expand_symtabs_matching)
5139         (map_symbol_filenames): Update.
5140         * symfile-debug.c (set_debug_symfile): Update.
5141         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5142         Update.
5143         * source.c (select_source_symtab, forget_cached_source_info):
5144         Update.
5145         * solib.c (solib_read_symbols): Update.
5146         * solib-spu.c (append_ocl_sos): Update.
5147         * psymtab.c (maintenance_print_psymbols)
5148         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5149         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5150         * printcmd.c (info_symbol_command): Update.
5151         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5152         Update.
5153         * objfiles.h (class all_objfiles): Remove.
5154         * objfiles.c (have_partial_symbols, have_full_symbols)
5155         (have_minimal_symbols, qsort_cmp, update_section_map)
5156         (shared_objfile_contains_address_p)
5157         (default_iterate_over_objfiles_in_search_order): Update.
5158         * objc-lang.c (info_selectors_command, info_classes_command)
5159         (find_methods): Update.
5160         * minsyms.c (find_solib_trampoline_target): Update.
5161         * maint.c (maintenance_info_sections)
5162         (maintenance_translate_address, count_symtabs_and_blocks):
5163         Update.
5164         * main.c (captured_main_1): Update.
5165         * linux-thread-db.c (try_thread_db_load_from_pdir)
5166         (has_libpthread): Update.
5167         * linespec.c (iterate_over_all_matching_symtabs)
5168         (search_minsyms_for_name): Update.
5169         * jit.c (jit_find_objf_with_entry_addr): Update.
5170         * hppa-tdep.c (find_unwind_entry)
5171         (hppa_lookup_stub_minimal_symbol): Update.
5172         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5173         Update.
5174         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5175         (elf_gnu_ifunc_resolve_by_got): Update.
5176         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5177         * dwarf-index-write.c (save_gdb_index_command): Update.
5178         * cp-support.c (add_symbol_overload_list_qualified): Update.
5179         * breakpoint.c (create_overlay_event_breakpoint)
5180         (create_longjmp_master_breakpoint)
5181         (create_std_terminate_master_breakpoint)
5182         (create_exception_master_breakpoint): Update.
5183         * blockframe.c (find_pc_partial_function): Update.
5184         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5185         (ada_collect_symbol_completion_matches)
5186         (ada_add_global_exceptions): Update.
5187
5188 2019-01-17  Tom Tromey  <tom@tromey.com>
5189
5190         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5191         declare VEC.
5192         (solib_target_parse_libraries): Change return type.
5193         (library_list_start_segment, library_list_start_section)
5194         (library_list_end_library, library_list_start_library); Update.
5195         (solib_target_free_library_list): Remove.
5196         (solib_target_parse_libraries): Remove cleanup.  Change return
5197         type.
5198         (solib_target_current_sos): Update.
5199
5200 2019-01-17  Tom Tromey  <tromey@bapiya>
5201
5202         * valprint.c: Replace "the the" with "the".
5203         * symtab.c: Replace "the the" with "the".
5204         * solib.c: Replace "the the" with "the".
5205         * solib-dsbt.c: Replace "the the" with "the".
5206         * linespec.c: Replace "the the" with "the".
5207         * dwarf2loc.h: Replace "the the" with "the".
5208         * amd64-windows-tdep.c: Replace "the the" with "the".
5209         * aarch64-tdep.c: Replace "the the" with "the".
5210
5211 2019-01-16  Keith Seitz  <keiths@redhat.com>
5212
5213         PR gdb/23773
5214         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5215         <builder>: Rename to ..
5216         <m_builder>: ... this and make private.
5217         (dwarf2_cu::get_builder): New method.  Change all users of
5218         `builder' to use this method.
5219         (dwarf2_start_symtab): Move to ...
5220         (dwarf2_cu::start_symtab): ... here.  Update all callers
5221         (setup_type_unit_groups): Move to ...
5222         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5223         callers.
5224         (dwarf2_cu::reset_builder): New method.
5225         (process_full_compunit, process_full_type_unit): Use
5226         dwarf2_cu::reset_builder.
5227         (follow_die_offset): Record the ancestor CU if it is different
5228         from the followed DIE's CU.
5229         (follow_die_sig_1): Likewise.
5230
5231 2019-01-15  Tom Tromey  <tom@tromey.com>
5232
5233         * remote.c (class remote_state) <buf>: Now a char_vector.
5234         <buf_size>: Remove.
5235         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5236         parameter.
5237         (remote_target::getpkt_or_notif_sane_1)
5238         (remote_target::getpkt_sane)
5239         (remote_target::getpkt_or_notif_sane): Likewise.
5240         (class remote_target) <putpkt>: New overload.
5241         (remote_target::read_frame): Change type of "buf_p".  Remove
5242         sizeof_p parameter.
5243         (packet_ok): New overload.
5244         (packet_check_result): New overload.
5245         Update all uses.
5246
5247 2019-01-14  Tom Tromey  <tom@tromey.com>
5248
5249         * remote-notif.c (handle_notification, remote_notif_ack)
5250         (remote_notif_parse): Make "buf" const.
5251         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5252         const.
5253         (remote_notif_parse, remote_notif_ack, handle_notification):
5254         Likewise.
5255         * remote.c (remote_notif_stop_parse): Make "buf" const.
5256         (remote_target::remote_parse_stop_reply): Make "buf" const.
5257         (remote_notif_stop_ack): Make "buf" const.
5258
5259 2019-01-14  Tom Tromey  <tom@tromey.com>
5260
5261         * remote.c (remote_console_output): Make parameter const.
5262
5263 2019-01-14  Tom Tromey  <tom@tromey.com>
5264
5265         * target-debug.h (target_debug_print_signals): Constify.
5266         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5267         * procfs.c (procfs_target::pass_signals): Update.
5268         * linux-nat.c (linux_nat_target::pass_signals): Update.
5269         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5270         * target-delegates.c: Rebuild.
5271         * remote.c (remote_target::program_signals): Update.
5272         (remote_target::pass_signals): Update.
5273         * target.c (target_pass_signals): Constify argument.
5274         (target_program_signals): Likewise.
5275         * target.h (struct target_ops) <pass_signals, program_signals>:
5276         Constify argument.
5277         (target_pass_signals, target_program_signals): Constify argument.
5278
5279 2019-01-14  Tom Tromey  <tom@tromey.com>
5280
5281         PR tui/28819:
5282         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5283
5284 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5285
5286         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5287         field.
5288         * rs6000-tdep.c: Include reggroups.h.
5289         (IS_V_ALIAS_PSEUDOREG): Define.
5290         (rs6000_register_name): Return names for the "vX" aliases.
5291         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5292         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5293         aliases.  Call default_register_reggroup_p for all other
5294         pseudo-registers.
5295         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5296         New functions.
5297         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5298         Handle "vX" aliases.
5299         (v_alias_pseudo_register_collect): New function.
5300         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5301         (rs6000_gdbarch_init): Initialize "vX" aliases as
5302         pseudo-registers.  Restore registration of
5303         rs6000_pseudo_register_reggroup_p with
5304         set_tdesc_pseudo_register_reggroup_p.
5305
5306 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5307
5308         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5309         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5310         set_gdbarch_num_pseudo_regs.
5311
5312 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5313
5314         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5315         Remove arg prefixname, add do_set and do_show.
5316         Add member functions set_list and show_list.
5317         * cli/cli-style.c (class cli_style_option): Update accordingly.
5318         (style_set_list): Move to file scope.
5319         (style_show_list): Likewise.
5320         (set_style): Call help_list.
5321         (show_style): Call cmd_show_list.
5322         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5323         Update to use the new macro.
5324
5325 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5326
5327         * ada-lang.c (_initialize_ada_language): Expand the help text
5328         for the "catch exception" command.
5329
5330 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5331
5332         * symtab.c (matching_obj_sections): Initialize obj,
5333         declare it closer to its usage.
5334
5335 2019-01-10  Tom Tromey  <tom@tromey.com>
5336
5337         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5338         (basic_inf_threads_range): Remove.
5339         (inf_threads_range, inf_non_exited_threads_range)
5340         (safe_inf_threads_range): Use next_adapter.
5341
5342 2019-01-10  Keith Seitz  <keiths@redhat.com>
5343
5344         PR gdb/23712
5345         PR symtab/23010
5346         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5347         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5348
5349 2019-01-10  Keith Seitz  <keiths@redhat.com>
5350
5351         PR gdb/23712
5352         PR symtab/23010
5353         * dictionary.c (pending_to_vector): Remove.
5354         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5355         Remove _1 suffix, replacing functions of the same name.  Update
5356         all callers.
5357         (dict_create_hashed, dict_create_hashed_expandable)
5358         (dict_create_linear, dict_create_linear_expandable, dict_free)
5359         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5360         Make functions static.
5361
5362 2019-01-10  Keith Seitz  <keiths@redhat.com>
5363
5364         PR gdb/23712
5365         PR symtab/23010
5366         * dictionary.h (struct dictionary): Replace declaration with
5367         multidictionary.
5368         (dict_create_hashed, dict_create_hashed_expandable)
5369         (dict_create_linear, dict_create_linear_expandable)
5370         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5371         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5372         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5373         taking multidictionary argument.
5374         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5375         * block.h (struct block) <dict>: Change to multidictionary
5376         and rename `multidict'.
5377         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5378         symmisc.c: Update all dictionary references to multidictionary.
5379
5380 2019-01-10  Keith Seitz  <keiths@redhat.com>
5381
5382         PR gdb/23712
5383         PR symtab/23010
5384         * dictionary.c: Include unordered_map.
5385         (pending_to_vector): New function.
5386         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5387         Rewrite the non-"_1" functions to take vector instead
5388         of linked list.
5389         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5390         "new" _1 versions of the same name.
5391         (multidictionary): Define.
5392         (std::hash<enum language): New definition.
5393         (collate_pending_symbols_by_language, mdict_create_hashed)
5394         (mdict_create_hashed_expandable, mdict_create_linear)
5395         (mdict_create_linear_expandable, mdict_free)
5396         (find_language_dictionary, create_new_language_dictionary)
5397         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5398         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5399         (mdict_size, mdict_empty): New functions.
5400         * dictionary.h (mdict_iterator): Define.
5401
5402 2019-01-10  Pedro Alves  <palves@redhat.com>
5403
5404         * breakpoint.c (read_uploaded_action)
5405         (create_tracepoint_from_upload): Adjust to use
5406         gdb::unique_xmalloc_ptr.
5407         * ctf.c (ctf_write_uploaded_tp):
5408         (SET_ARRAY_FIELD): Use emplace_back.
5409         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5410         * tracefile-tfile.c (tfile_write_uploaded_tp):
5411         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5412         gdb::unique_xmalloc_ptr.
5413         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5414         at_string, cond_string, cmd_strings>: Replace char pointers
5415         with gdb::unique_xmalloc_ptr.
5416
5417 2019-01-10  Pedro Alves  <palves@redhat.com>
5418
5419         * solib-target.c (library_list_start_library): Don't xstrdup name.
5420
5421 2019-01-10  Pedro Alves  <palves@redhat.com>
5422
5423         * mdebugread.c (parse_partial_symbols): Use
5424         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5425
5426 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5427
5428         * linux-fork.c (scoped_switch_fork_info)
5429         <~scoped_switch_fork_info>: Fix incorrect variable name.
5430
5431 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5432
5433         * linux-fork.c (scoped_switch_fork_info)
5434         <scoped_switch_fork_info>: Make explicit.
5435         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5436
5437 2019-01-10  Tom Tromey  <tom@tromey.com>
5438
5439         * objfiles.h (objfile::reset_psymtabs): Update.
5440         * objfiles.c (objfile::objfile): Update.
5441         * psymtab.h (psymtab_storage::obstack): Update.
5442         (psymtab_storage::m_obstack): Use gdb::optional.
5443         (class psymtab_storage): Update comment.  Remove objfile
5444         parameter.
5445         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5446
5447 2019-01-10  Tom Tromey  <tom@tromey.com>
5448
5449         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5450         <free_psymtabs>: Now private.
5451         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5452         (allocate_psymtab): Use new method.
5453
5454 2019-01-10  Tom Tromey  <tom@tromey.com>
5455
5456         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5457         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5458         * mdebugread.c (parse_partial_symbols): Use
5459         allocate_dependencies.
5460         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5461         allocate_dependencies.
5462         (process_psymtab_comp_unit_reader)
5463         (build_type_psymtab_dependencies): Likewise.
5464         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5465
5466 2019-01-10  Tom Tromey  <tom@tromey.com>
5467
5468         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5469         PSYMBOL_SET_LANGUAGE.
5470         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5471
5472 2019-01-10  Tom Tromey  <tom@tromey.com>
5473
5474         * psymtab.h (psymtab_storage::obstack): New method.
5475         <m_obstack>: Rename from obstack; now private.
5476         * psymtab.c (psymtab_storage): Update.
5477         * dwarf2read.c (create_addrmap_from_index)
5478         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5479         Update.
5480
5481 2019-01-10  Tom Tromey  <tom@tromey.com>
5482
5483         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5484         * objfiles.h (objfile::reset_psymtabs): New method.
5485
5486 2019-01-10  Tom Tromey  <tom@tromey.com>
5487
5488         * symmisc.c (print_symbol_bcache_statistics): Update.
5489         (print_objfile_statistics): Update.
5490         * symfile.c (reread_symbols): Update.
5491         * psymtab.h (class psymtab_storage): New.
5492         * psymtab.c (psymtab_storage): New constructor.
5493         (~psymtab_storage): New destructor.
5494         (require_partial_symbols): Update.
5495         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5496         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5497         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5498         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5499         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5500         (start_psymtab_common, end_psymtab_common)
5501         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5502         (allocate_psymtab): Update.
5503         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5504         Update.
5505         (dump_psymtab_addrmap, maintenance_print_psymbols)
5506         (maintenance_check_psymtabs): Update.
5507         (class objfile_psymtabs): Move to objfiles.h.
5508         * psympriv.h (discard_psymtab): Now inline.
5509         (psymtab_discarder::psymtab_discarder): Update.
5510         (psymtab_discarder::~psymtab_discarder): Update.
5511         (ALL_OBJFILE_PSYMTABS): Rewrite.
5512         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5513         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5514         Remove fields.
5515         <partial_symtabs>: New field.
5516         (class objfile_psymtabs): Move from psymtab.h.  Update.
5517         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5518         psymbol_cache.
5519         (objfile::~objfile): Don't destroy psymbol_cache.
5520         * mdebugread.c (parse_partial_symbols): Update.
5521         * dwarf2read.c (create_addrmap_from_index)
5522         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5523         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5524         (add_partial_subprogram, dwarf2_ranges_read): Update.
5525         * dwarf-index-write.c (write_address_map)
5526         (write_one_signatured_type, recursively_write_psymbols)
5527         (class debug_names, class debug_names, write_psymtabs_to_index):
5528         Update.
5529
5530 2019-01-10  Tom Tromey  <tom@tromey.com>
5531
5532         * symtab.h (SYMBOL_SET_NAMES): Update.
5533         (symbol_set_names): Update.
5534         (MSYMBOL_SET_NAMES): Update.
5535         * symtab.c (symbol_set_names): Change argument to be an
5536         objfile_per_bfd_storage.
5537         * psymtab.c (add_psymbol_to_bcache): Update.
5538         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5539
5540 2019-01-10  Tom Tromey  <tom@tromey.com>
5541
5542         * symtab.c (create_demangled_names_hash): Change argument to be an
5543         objfile_per_bfd_storage.
5544         (symbol_set_names): Update.
5545
5546 2019-01-10  Tom Tromey  <tom@tromey.com>
5547
5548         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5549         init_psymbol_list.
5550         * psymtab.c (init_psymbol_list): Do nothing if already called.
5551         * psympriv.h (init_psymbol_list): Add comment.
5552         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5553         init_psymbol_list.
5554         * dbxread.c (dbx_symfile_read): Unconditionally call
5555         init_psymbol_list.
5556
5557 2019-01-10  Tom Tromey  <tom@tromey.com>
5558
5559         * xcoffread.c (scan_xcoff_symtab): Update.
5560         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5561         "where".
5562         * mdebugread.c (parse_partial_symbols)
5563         (handle_psymbol_enumerators): Update.
5564         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5565         * dbxread.c (read_dbx_symtab): Update.
5566         * psympriv.h (psymbol_placement): New enum.
5567         (add_psymbol_to_list): Update.
5568
5569 2019-01-10  Tom Tromey  <tom@tromey.com>
5570
5571         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5572         static_psymbols parameters.
5573         (scan_xcoff_symtab): Update.
5574         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5575         static_psymbols parameters.
5576         * psympriv.h (start_psymtab_common): Update.
5577         * mdebugread.c (parse_partial_symbols): Update.
5578         * dwarf2read.c (create_partial_symtab): Update.
5579         * dbxread.c (read_dbx_symtab): Update.
5580         (start_psymtab): Remove global_psymbols and static_psymbols
5581         parameters.
5582
5583 2019-01-10  Tom Tromey  <tom@tromey.com>
5584
5585         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5586         * psymtab.c (allocate_psymtab): Add comment.
5587         * psympriv.h (allocate_psymtab): Add comment.
5588         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5589         initializations.
5590         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5591
5592 2019-01-10  Tom Tromey  <tom@tromey.com>
5593
5594         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5595         Don't declare.
5596         * mipsread.c: Include mdebugread.h.
5597         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5598         Declare.
5599         * elfread.c: Include mdebugread.h.
5600
5601 2019-01-09  Tom Tromey  <tom@tromey.com>
5602
5603         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5604         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5605         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5606         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5607         (psym_lookup_symbol, psym_find_last_source_symtab)
5608         (psym_forget_cached_source_info, psym_print_stats)
5609         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5610         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5611         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5612         (psym_find_compunit_symtab_by_address)
5613         (maintenance_print_psymbols, maintenance_info_psymtabs)
5614         (maintenance_check_psymtabs): Use ranged for.
5615         * psymtab.h (class objfile_psymtabs): New.
5616         (require_partial_symbols): Return objfile_psymtabs.
5617         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5618
5619 2019-01-09  Tom Tromey  <tom@tromey.com>
5620
5621         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5622         (find_pc_mapped_section, list_overlays_command)
5623         (map_overlay_command, unmap_overlay_command)
5624         (simple_overlay_update): Use all_objfiles.
5625         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5626         * printcmd.c (info_symbol_command): Use all_objfiles.
5627         * objfiles.h (ALL_OBJSECTIONS): Remove.
5628         * maint.c (maintenance_translate_address): Use all_objfiles.
5629         * gcore.c (gcore_create_callback): Use all_objfiles.
5630         (objfile_find_memory_regions): Likewise.
5631
5632 2019-01-09  Tom Tromey  <tom@tromey.com>
5633
5634         * symtab.c (find_line_symtab, info_sources_command)
5635         (make_source_files_completion_list): Use objfile_compunits.
5636         * source.c (select_source_symtab): Use objfile_compunits.
5637         * objfiles.h (struct objfile): Update comment.
5638         (ALL_OBJFILES): Remove.
5639         (ALL_FILETABS): Remove.
5640         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5641         objfile_compunits.
5642
5643 2019-01-09  Tom Tromey  <tom@tromey.com>
5644
5645         * symmisc.c (print_objfile_statistics, dump_objfile)
5646         (maintenance_print_symbols): Use compunit_filetabs.
5647         * source.c (forget_cached_source_info_for_objfile): Use
5648         compunit_filetabs.
5649         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5650         (ALL_FILETABS): Use compunit_filetabs.
5651         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5652         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5653
5654 2019-01-09  Tom Tromey  <tom@tromey.com>
5655
5656         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5657         (compunit_filetabs): New.
5658         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5659         compunit_filetabs.
5660         (info_sources_command, make_source_files_completion_list): Remove
5661         declaration.
5662         * symmisc.c (print_objfile_statistics, dump_objfile)
5663         (maintenance_print_symbols): Remove declaration.
5664         (maintenance_info_symtabs): Use compunit_filetabs.
5665         (maintenance_info_line_tables): Likewise.
5666         * source.c (select_source_symtab): Change local variable name.
5667         (forget_cached_source_info_for_objfile): Remove declaration.
5668         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5669         * objfiles.c (objfile_relocate1): Remove declaration.
5670         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5671         declaration.
5672         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5673         * coffread.c (coff_symtab_read): Remove declaration.
5674         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5675         compunit_filetabs.
5676
5677 2019-01-09  Tom Tromey  <tom@tromey.com>
5678
5679         * symtab.c (lookup_objfile_from_block)
5680         (find_pc_sect_compunit_symtab, search_symbols)
5681         (default_collect_symbol_completion_matches_break_on): Use
5682         objfile_compunits.
5683         * objfiles.h (ALL_COMPUNITS): Remove.
5684         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5685         * cp-support.c (add_symbol_overload_list_qualified): Use
5686         objfile_compunits.
5687         * ada-lang.c (ada_collect_symbol_completion_matches)
5688         (ada_add_global_exceptions): Use objfile_compunits.
5689
5690 2019-01-09  Tom Tromey  <tom@tromey.com>
5691
5692         * source.c (select_source_symtab)
5693         (forget_cached_source_info_for_objfile): Remove declaration.
5694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5695         declaration.
5696         * maint.c (count_symtabs_and_blocks): Remove declaration.
5697         * cp-support.c (add_symbol_overload_list_qualified): Remove
5698         declaration.
5699         * coffread.c (coff_symtab_read): Remove declaration.
5700         * symtab.c (lookup_symbol_in_objfile_symtabs)
5701         (basic_lookup_transparent_type_1): Use objfile_compunits.
5702         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5703         (info_sources_command, search_symbols)
5704         (default_collect_symbol_completion_matches_break_on)
5705         (make_source_files_completion_list): Remove declaration.
5706         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5707         (ada_collect_symbol_completion_matches)
5708         (ada_add_global_exceptions): Remove declaration.
5709         * linespec.c (iterate_over_all_matching_symtabs): Use
5710         objfile_compunits.
5711         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5712         (class objfile_compunits): New.
5713         (ALL_COMPUNITS): Use objfile_compunits.
5714         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5715         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5716         objfile_compunits.
5717         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5718
5719 2019-01-09  Tom Tromey  <tom@tromey.com>
5720
5721         * symtab.c (search_symbols)
5722         (default_collect_symbol_completion_matches_break_on): Use
5723         objfile_msymbols.
5724         * ada-lang.c (ada_lookup_simple_minsym)
5725         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5726         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5727         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5728         objfile_msymbols.
5729         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5730         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5731         * objc-lang.c (find_methods): Use objfile_msymbols.
5732         (info_selectors_command, info_classes_command): Likewise.
5733         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5734         * objfiles.h (class objfile_msymbols): New.
5735         (ALL_OBJFILE_MSYMBOLS): Remove.
5736         (ALL_MSYMBOLS): Remove.
5737
5738 2019-01-09  Tom Tromey  <tom@tromey.com>
5739
5740         * common/next-iterator.h (next_adapter): Add Iterator template
5741         parameter.
5742         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5743         (class all_objfiles_safe): New.
5744         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5745         * objfiles.c (put_objfile_before): Update comment.
5746         (add_separate_debug_objfile): Likewise.
5747         (free_all_objfiles): Use all_objfiles_safe.
5748         (objfile_purge_solibs): Likewise.
5749
5750 2019-01-09  Tom Tromey  <tom@tromey.com>
5751
5752         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5753         (expand_symtab_containing_pc, lookup_static_symbol)
5754         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5755         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5756         all_objfiles.
5757         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5758         * breakpoint.c (create_overlay_event_breakpoint)
5759         (create_longjmp_master_breakpoint)
5760         (create_std_terminate_master_breakpoint)
5761         (create_exception_master_breakpoint): Use all_objfiles.
5762         * linux-thread-db.c (try_thread_db_load_from_pdir)
5763         (has_libpthread): Use all_objfiles.
5764         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5765         * linespec.c (iterate_over_all_matching_symtabs)
5766         (search_minsyms_for_name): Use all_objfiles.
5767         * maint.c (maintenance_info_sections): Use all_objfiles.
5768         * main.c (captured_main_1): Use all_objfiles.
5769         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5770         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5771         * guile/scm-pretty-print.c
5772         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5773         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5774         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5775         (maintenance_print_msymbols): Use all_objfiles.
5776         * source.c (select_source_symtab): Use all_objfiles.
5777         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5778         * symfile.c (remove_symbol_file_command)
5779         (expand_symtabs_matching, map_symbol_filenames): Use
5780         all_objfiles.
5781         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5782         all_objfiles.
5783         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5784         * objc-lang.c (find_methods): Use all_objfiles.
5785         * objfiles.c (have_partial_symbols, have_full_symbols)
5786         (have_minimal_symbols, qsort_cmp)
5787         (default_iterate_over_objfiles_in_search_order): Use
5788         all_objfiles.
5789         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5790         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5791         (maintenance_check_psymtabs): Use all_objfiles.
5792         (ALL_PSYMTABS): Remove.
5793         * compile/compile-object-run.c (do_module_cleanup): Use
5794         all_objfiles.
5795         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5796         * cp-support.c (add_symbol_overload_list_qualified): Use
5797         all_objfiles.
5798         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5799         Use all_objfiles.
5800         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5801         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5802         all_objfiles.
5803         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5804         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5805         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5806         Uses all_objfiles.
5807         * solib.c (solib_read_symbols): Use all_objfiles
5808
5809 2019-01-09  Tom Tromey  <tom@tromey.com>
5810
5811         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5812         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5813         all_objfiles.
5814         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5815         * symmisc.c (print_symbol_bcache_statistics)
5816         (print_objfile_statistics, maintenance_print_objfiles)
5817         (maintenance_info_symtabs, maintenance_check_symtabs)
5818         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5819         all_objfiles.
5820         * source.c (forget_cached_source_info): Use all_objfiles.
5821         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5822         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5823         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5824         * objfiles.c (update_section_map): Use all_objfiles.
5825         (shared_objfile_contains_address_p): Likewise.
5826         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5827         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5828
5829 2019-01-09  Tom Tromey  <tom@tromey.com>
5830
5831         * common/next-iterator.h: New file.
5832         * objfiles.h (class all_objfiles): New.
5833         (struct objfile_iterator): New.
5834
5835 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5836
5837         * NEWS: Move the description of the changed "frame", "select-frame",
5838          and "info frame" commands to the Changed commands section.
5839
5840 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5841
5842         * gdbtypes.c (check_stub_method_group): Remove handling of old
5843         mangling schemes.
5844         * linespec.c (find_methods): Likewise.
5845         * stabsread.c (read_member_functions): Likewise.
5846         * valops.c (search_struct_method): Likewise.
5847         (value_struct_elt_for_reference): Likewise.
5848         * NEWS: Mention this change.
5849
5850 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5853         print_source_lines.
5854         * source.c (print_source_lines_base): Update line number check.
5855         (print_source_lines): New function.
5856         (source_lines_range::source_lines_range): New function.
5857         * source.h (class source_lines_range): New class.
5858         (print_source_lines): New declaration.
5859
5860 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5861
5862         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5863
5864 2019-01-08  Tom Tromey  <tom@tromey.com>
5865             Simon Marchi  <simon.marchi@ericsson.com>
5866
5867         PR gdb/24060
5868         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5869         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5870         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5871         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5872         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5873         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5874
5875 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * source.c (select_source_symtab): Move header comment to
5878         declaration in source.h.
5879         (forget_cached_source_info_for_objfile): Likewise.
5880         (forget_cached_source_info): Likewise.
5881         (identify_source_line): Likewise.
5882         * source.h (identify_source_line): Move declaration from symtab.h
5883         and add comment from source.c
5884         (print_source_lines): Likewise.
5885         (forget_cached_source_info_for_objfile): Likewise.
5886         (forget_cached_source_info): Likewise.
5887         (select_source_symtab): Likewise.
5888         (enum print_source_lines_flag): Move definition from symtab.h.
5889         * symtab.h (identify_source_line): Move declaration to source.h.
5890         (print_source_lines): Likewise.
5891         (forget_cached_source_info_for_objfile): Likewise.
5892         (forget_cached_source_info): Likewise.
5893         (select_source_symtab): Likewise.
5894         (enum print_source_lines_flag): Move definition to source.h.
5895         * tui/tui-hooks.c: Add 'source.h' include.
5896
5897 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * source.c (print_source_lines_base): Handle requests to print
5900         reverse line number sequences, and guard against empty lines
5901         string.
5902
5903 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * source.c (print_source_lines_base): Fix skip of '\r' if next
5906         character is '\n'.
5907
5908 2019-01-06  Tom Tromey  <tom@tromey.com>
5909
5910         * c-exp.y (struct c_parse_state) <macro_original_text,
5911         expansion_obstack>: New member.
5912         (macro_original_text, expansion_obstack): Remove globals.
5913         (scan_macro_expansion, scanning_macro_expansion)
5914         (finished_macro_expansion): Update.
5915         (scan_macro_cleanup): Remove.
5916         (yylex, c_parse): Update.
5917
5918 2019-01-06  Tom Tromey  <tom@tromey.com>
5919
5920         * c-exp.y (struct c_parse_state) <strings>: New member.
5921         (operator_stoken): Update.
5922
5923 2019-01-06  Tom Tromey  <tom@tromey.com>
5924
5925         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5926         (union type_stack_elt) <typelist_val>: Now a pointer to
5927         std::vector.
5928         (type_stack_cleanup): Don't declare.
5929         (push_typelist): Update.
5930         * parse.c (pop_typelist): Return a std::vector.
5931         (push_typelist): Take a std::vector.
5932         (follow_types): Update.  Do not free args.
5933         (type_stack_cleanup): Remove.
5934         * c-exp.y (struct c_parse_state): New.
5935         (cpstate): New global.
5936         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5937         (nonempty_typelist): Update.
5938         (func_mod): Create a new vector.
5939         (c_parse): Create a c_parse_state.
5940         (check_parameter_typelist): Do not delete params.
5941         (function_method): Update.  Do not delete type_list.
5942
5943 2019-01-06  Tom Tromey  <tom@tromey.com>
5944
5945         PR gdb/28155:
5946         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5947         check_typedef.
5948         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5949         (print_return_value): Likewise.
5950
5951 2019-01-05  Tom Tromey  <tom@tromey.com>
5952
5953         * contrib/cleanup_check.py: Remove.
5954         * contrib/gcc-with-excheck: Remove.
5955         * contrib/exsummary.py: Remove.
5956         * contrib/excheck.py: Remove.
5957
5958 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5959
5960         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5961         NULL. Initialize tpprev to NULL instead of assigning it
5962         to NULL on the next statement.
5963         * windows-nat.c (windows_delete_thread): Remove check for
5964         main_thread_id before printing thread exit notifications.
5965         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5966         Remove thread ID check against main_thread_id.
5967         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5968         windows_delete_thread.
5969         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5970
5971 2019-01-04  Tom Tromey  <tom@tromey.com>
5972
5973         * compile/compile.c (_initialize_compile): Use upper case for
5974         metasyntactic variables.
5975         * symmisc.c (_initialize_symmisc): Use upper case for
5976         metasyntactic variables.
5977         * psymtab.c (_initialize_psymtab): Use upper case for
5978         metasyntactic variables.
5979         * demangle.c (demangle_command): Use upper case for metasyntactic
5980         variables.
5981         (_initialize_demangler): Likewise.
5982         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5983         variables.
5984
5985 2019-01-03  Tom Tromey  <tom@tromey.com>
5986
5987         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5988
5989 2019-01-03  Tom Tromey  <tom@tromey.com>
5990
5991         * python/py-symtab.c (salpy_str): Update.
5992         (struct salpy_sal_object) <symtab>: Now a PyObject.
5993         (salpy_dealloc): Update.
5994         (del_objfile_sal): Use gdbpy_ref.
5995
5996 2019-01-03  Tom Tromey  <tom@tromey.com>
5997
5998         * python/py-type.c (convert_field): Use new_reference.  Return
5999         gdbpy_ref.
6000         (make_fielditem): Return gdbpy_ref.
6001         (typy_fields): Update.
6002         (typy_getitem): Update.
6003         (field_name): Return gdbpy_ref.  Use new_reference.
6004         (typy_iterator_iternext): Update.
6005
6006 2019-01-03  Tom Tromey  <tom@tromey.com>
6007
6008         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6009
6010 2019-01-03  Tom Tromey  <tom@tromey.com>
6011
6012         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6013         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6014         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6015         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6016         (pspy_set_type_printers): Likewise.
6017         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6018         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6019         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6020         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6021         (objfpy_set_type_printers): Likewise.
6022
6023 2019-01-03  Tom Tromey  <tom@tromey.com>
6024
6025         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6026         (gdbpy_print_stack): Use gdbpy_err_fetch.
6027         * python/python-internal.h (class gdbpy_err_fetch): New class.
6028         (class gdbpy_enter) <m_error_type, m_error_value,
6029         m_error_traceback>: Remove.
6030         <m_error>: New member.
6031         (gdbpy_exception_to_string): Don't declare.
6032         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6033         * python/py-value.c (convert_value_from_python): Use
6034         gdbpy_err_fetch.
6035         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6036         gdbpy_exception_to_string.
6037         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6038         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6039         gdbpy_err_fetch.
6040
6041 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6042
6043         * linux-nat.c (delete_lwp_cleanup): Delete.
6044         (struct lwp_deleter): New struct.
6045         (lwp_info_up): New typedef.
6046         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6047         lwp_info_up.
6048
6049 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6050
6051         * linux-fork.c (class scoped_switch_fork_info): New class.
6052         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6053
6054 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6055
6056         * valops.c (find_overload_match): Remove use of null_cleanup, and
6057         calls to do_cleanups.
6058
6059 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6060
6061         * compile/compile-cplus-types.c
6062         (compile_cplus_instance::decl_name): Handle changes to
6063         cp_func_name.
6064         * cp-support.c (cp_func_name): Update header comment, update
6065         return type.
6066         * cp-support.h (cp_func_name): Update return type in declaration.
6067         * valops.c (find_overload_match): Move temp_func local to top
6068         level of function and change its type.  Use temp_func to hold and
6069         delete temporary string obtained from cp_func_name.
6070
6071 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6074         gdb::char_vector, remove cleanup, and update uses of `msg`.
6075
6076 2019-01-03  Jim Wilson  <jimw@sifive.com>
6077
6078         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6079
6080 2019-01-02  Tom Tromey  <tom@tromey.com>
6081
6082         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6083         (tdesc_parse_xml): Remove cleanups.
6084         * target-descriptions.h (make_cleanup_free_target_description):
6085         Don't declare.
6086         (target_desc_deleter): New struct.
6087         (target_desc_up): New typedef.
6088         * target-descriptions.c (target_desc_deleter::operator()): Rename
6089         from free_target_description.
6090         (make_cleanup_free_target_description): Remove.
6091
6092 2019-01-02  Tom Tromey  <tom@tromey.com>
6093
6094         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6095         constructor, destructor.
6096         (linespec_parser): Remove typedef.
6097         (~linespec_parser): Rename from linespec_parser_delete.
6098         (linespec_lex_to_end, linespec_complete_label)
6099         (linespec_complete): Update.
6100         (decode_line_full): Remove cleanups.
6101         (decode_line_1): Update.
6102
6103 2019-01-02  Tom Tromey  <tom@tromey.com>
6104
6105         * python/python-internal.h (inferior_to_inferior_object): Change
6106         return type.
6107         * python/py-exitedevent.c (create_exited_event_object): Update.
6108         * python/py-inferior.c (inferior_to_inferior_object): Return
6109         gdbpy_ref.
6110         (python_new_inferior, python_inferior_deleted)
6111         (thread_to_thread_object, delete_thread_object)
6112         (build_inferior_list, gdbpy_selected_inferior): Update.
6113         * python/py-infthread.c (create_thread_object): Update.  Also fail
6114         if inferior_to_inferior_object fails.
6115
6116 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6117
6118         * inferior.h (class inferior) <displaced_step_state>: New field.
6119         * infrun.h (struct displaced_step_state): Move here from
6120         infrun.c.  Initialize fields, add constructor.
6121         <inf>: Remove field.
6122         <reset>: New method.
6123         * infrun.c (struct displaced_step_inferior_state): Move to
6124         infrun.h.
6125         (displaced_step_inferior_states): Remove.
6126         (get_displaced_stepping_state): Adust.
6127         (displaced_step_in_progress_any_inferior): Adjust.
6128         (displaced_step_in_progress_thread): Adjust.
6129         (displaced_step_in_progress): Adjust.
6130         (add_displaced_stepping_state): Remove.
6131         (get_displaced_step_closure_by_addr): Adjust.
6132         (remove_displaced_stepping_state): Remove.
6133         (infrun_inferior_exit): Call displaced_step_state.reset.
6134         (use_displaced_stepping): Don't check for NULL.
6135         (displaced_step_prepare_throw): Call
6136         get_displaced_stepping_state.
6137         (displaced_step_fixup): Don't check for NULL.
6138         (prepare_for_detach): Don't check for NULL.
6139
6140 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6141
6142         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6143          in case of call that did not complete.
6144
6145 2019-01-02  Andrey Utkin  <autkin@undo.io>
6146
6147         * symfile.c (find_separate_debug_file): Fix search of debug files for
6148         remote debuggee.
6149
6150 2019-01-02  Tom Tromey  <tom@tromey.com>
6151
6152         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6153         indentation.
6154         * python/py-frame.c (frapy_older): Remove cast.
6155         (frapy_newer): Likewise.
6156         * python/py-breakpoint.c (local_setattro): Remove cast.
6157         * python/py-arch.c (archpy_name): Remove local variable.
6158         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6159
6160 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6161
6162         * unittests/basic_string_view/element_access/char/empty.cc:
6163         Fix year range in copyright header.
6164
6165 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6166
6167         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6168         Delete.
6169         <operator==>: Update with for removed field.
6170         <hash>: Likewise.
6171         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6172         <isa_features>: ...this.
6173         <abi_features>: New field.
6174         (riscv_isa_flen): Update comment.
6175         (riscv_abi_xlen): New declaration.
6176         (riscv_abi_flen): New declaration.
6177         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6178         isa_features.
6179         (riscv_abi_xlen): New function.
6180         (riscv_isa_flen): Update to get answer from isa_features.
6181         (riscv_abi_flen): New function.
6182         (riscv_has_fp_abi): Update to get answer from abi_features.
6183         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6184         xlen and flen.
6185         (riscv_call_info) <xlen, flen>: Update comment.
6186         (riscv_call_arg_struct): Remove invalid assertions
6187         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6188         is removed.
6189         (riscv_gdbarch_init): Gather isa features and abi features
6190         separately, ensure both match on the gdbarch when reusing an old
6191         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6192         a target with 64-bit float hardware.
6193
6194 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6195
6196         * source.c (search_command_helper): Stop reverse search
6197         when line 1 has been searched.
6198
6199 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6200
6201         * record-full.c (record_full_base_target::close): Rewrite
6202         record_full_core_buf_list free logic.
6203
6204 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6205
6206         * break-catch-syscall.c (print_one_catch_syscall): xfree
6207         the last text.
6208
6209 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6210
6211         * top.c (print_gdb_version): Update Copyright year in version
6212         message.
6213
6214 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6215
6216         Update copyright year range in all GDB files.
6217
6218 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6219
6220         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6221
6222 For older changes see ChangeLog-2018.
6223 \f
6224 Local Variables:
6225 mode: change-log
6226 left-margin: 8
6227 fill-column: 74
6228 version-control: never
6229 coding: utf-8
6230 End:
6231