gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
   4         (tui_unhighlight_win, tui_highlight_win)
   5         (tui_win_info::make_window): Update.
   6         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
   7
   8 2019-08-20  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  11         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  12         (MAX_PID_WIDTH): Move to tui-stack.c.
  13         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  14         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  15         (MAX_PID_WIDTH): Move from tui-data.h.
  16
  17 2019-08-20  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  20         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  21         (box_win): Update.
  22         (tui_gen_win_info::make_window): Rename from tui_make_window.
  23         (tui_win_info::make_window): New method.
  24         (tui_gen_win_info::make_visible): Update.
  25         * tui/tui-source.c (tui_source_window::set_contents): Update.
  26         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  27         (tui_data_window::display_registers_from): Update.
  28         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  29         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  30         Declare.
  31         <can_box>: Remove.
  32         <title>: Remove.
  33         (struct tui_win_info) <make_window>: Declare.
  34         <can_box>: Now virtual.
  35         <title>: New member.
  36         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  37         * tui/tui-command.c (tui_cmd_window::resize): Update.
  38
  39 2019-08-20  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  42         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  43         (tui_data_window::check_register_values): Update.
  44
  45 2019-08-20  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-regs.h (struct tui_data_window): Use
  48         DISABLE_COPY_AND_ASSIGN.
  49         <regs_content>: Change type, removing unique_ptr.
  50         <tui_data_window>: Add move constructor.
  51         * tui/tui-regs.c (tui_data_window::show_registers)
  52         (tui_data_window::show_register_group)
  53         (tui_data_window::display_registers_from)
  54         (tui_data_window::display_registers_from)
  55         (tui_data_window::first_data_item_displayed)
  56         (tui_data_window::delete_data_content_windows)
  57         (tui_data_window::rerender, tui_data_window::refresh_window)
  58         (tui_data_window::check_register_values): Update.
  59
  60 2019-08-20  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  63         show_register_group>: Declare.
  64         (tui_show_register_group): Don't declare.
  65         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  66         tui_show_registers.
  67         (tui_data_window::show_register_group): Rename from
  68         tui_show_register_group.
  69         (tui_data_window::check_register_values, tui_reg_command):
  70         Update.
  71         * tui/tui-layout.c (tui_set_layout): Update.
  72
  73 2019-08-20  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  76         Declare.
  77         (tui_check_register_values): Don't declare.
  78         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  79         from tui_check_register_values.
  80         * tui/tui-hooks.c (tui_register_changed): Update.
  81
  82 2019-08-20  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-regs.c (tui_reg_layout): Move later.
  85         (tui_show_registers): Don't enable TUI mode or change layout.
  86
  87 2019-08-20  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-regs.h (struct tui_data_item_window)
  90         <~tui_data_item_window>: Remove.
  91         <content>: Now a unique_xmalloc_ptr.
  92         * tui/tui-regs.c (tui_register_format): Return a
  93         unique_xmalloc_ptr.
  94         (tui_get_register): Update.
  95         (~tui_data_item_window): Remove.
  96         (tui_data_window::display_registers_from, tui_display_register):
  97         Update.
  98         * tui/tui-io.h (tui_expand_tabs): Update.
  99         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 100         Remove "col" parameter.
 101
 102 2019-08-20  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 105         field.
 106         * tui/tui-regs.c (~tui_data_item_window): Update.
 107
 108 2019-08-20  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 111         earlier.
 112
 113 2019-08-20  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 116
 117 2019-08-20  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-source.h (struct tui_source_window): Update.
 120         * tui/tui-regs.c (tui_show_registers): Update.
 121         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 122         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 123         (NO_REGS_STRING): Remove defines.
 124
 125 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 126
 127         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 128         unnecessary thread walk if remote doesn't support the packet.
 129
 130 2019-08-19  Tom Tromey  <tromey@adacore.com>
 131
 132         * python/py-value.c (value_has_field): Fix indentation.
 133
 134 2019-08-19  Tom Tromey  <tromey@adacore.com>
 135
 136         * printcmd.c (do_one_display, info_display_command): Update.
 137         * block.h (contained_in): Return bool.  Add allow_nested
 138         parameter.
 139         * block.c (contained_in): Return bool.  Add allow_nested
 140         parameter.
 141
 142 2019-08-19  Tom Tromey  <tom@tromey.com>
 143
 144         * configure: Rebuild.
 145         * configure.ac: Disallow the combination of -static-libstdc++ and
 146         source highlight.
 147         * source-cache.c (get_language_name): Handle rust.
 148         (source_cache::get_source_lines): Ignore highlighting exceptions.
 149
 150 2019-08-16  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 153         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 154         (struct tui_source_window_base) <make_visible, refresh_window,
 155         resize>: Remove methods.
 156         <execution_info>: Remove field.
 157         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 158         (tui_show_source_line, tui_source_window_base)
 159         (~tui_source_window_base): Update.
 160         (tui_source_window_base::resize)
 161         (tui_source_window_base::make_visible)
 162         (tui_source_window_base::refresh_window): Remove.
 163         (tui_source_window_base::update_exec_info): Update.
 164         * tui/tui-source.c (tui_source_window::set_contents): Update.
 165         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 166
 167 2019-08-16  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 170         deprecated_query_hook.
 171
 172 2019-08-16  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 175         (tui_update_source_windows_with_line): Update.
 176         * tui/tui-source.h (struct tui_source_window)
 177         <show_symtab_source>: Declare.
 178         (tui_show_symtab_source): Don't declare.
 179         * tui/tui-source.c (tui_show_symtab_source): Rename from
 180         tui_show_symtab_source.
 181
 182 2019-08-16  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-winsource.h (struct tui_source_window_base)
 185         <set_contents>: Declare.
 186         * tui/tui-winsource.c
 187         (tui_source_window_base::update_source_window_as_is): Update.
 188         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 189         Declare.
 190         (tui_set_source_content): Don't declare.
 191         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 192         tui_set_source_content.
 193         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 194         Declare.
 195         (tui_set_disassem_content): Don't declare.
 196         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 197         tui_set_disassem_content.
 198
 199 2019-08-16  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-winsource.h (struct tui_source_window_base)
 202         <update_breakpoint_info>: Declare.
 203         (tui_update_breakpoint_info): Don't declare.
 204         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 205         (tui_update_all_breakpoint_info): Update.
 206         (tui_source_window_base::update_breakpoint_info): Rename from
 207         tui_update_breakpoint_info.
 208         (tui_source_window_base::update_exec_info): Update.
 209
 210 2019-08-16  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-winsource.h (struct tui_source_window_base)
 213         <update_source_window>: Declare.
 214         (tui_update_source_window): Don't declare.
 215         * tui/tui-winsource.c
 216         (tui_source_window_base::update_source_window): Rename from
 217         tui_update_source_window.
 218         (tui_source_window_base::rerender): Update.
 219         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 220         * tui/tui-disasm.c (tui_show_disassem)
 221         (tui_show_disassem_and_update_source)
 222         (tui_disasm_window::maybe_update): Update.
 223
 224 2019-08-16  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-winsource.h (struct tui_source_window_base)
 227         <update_source_window_as_is>: Declare.
 228         (tui_update_source_window_as_is): Don't declare.
 229         * tui/tui-winsource.c (tui_update_source_window): Update
 230         (tui_source_window_base::update_source_window_as_is): Rename from
 231         tui_update_source_window_as_is.
 232         (tui_source_window_base::refill): Update.
 233         * tui/tui-source.c (tui_show_symtab_source): Update.
 234         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 235         Update.
 236
 237 2019-08-16  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-winsource.h (tui_update_source_window)
 240         (tui_update_source_window_as_is): Remove "noerror" parameter.
 241         * tui/tui-winsource.c (tui_update_source_window)
 242         (tui_update_source_window_as_is): Remove "noerror" parameter.
 243         (tui_update_source_windows_with_addr)
 244         (tui_update_source_windows_with_line)
 245         (tui_source_window_base::rerender)
 246         (tui_source_window_base::refill): Update.
 247         * tui/tui-source.h (tui_set_source_content)
 248         (tui_show_symtab_source): Remove "noerror" parameter.
 249         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 250         parameter.
 251         (tui_show_symtab_source): Likewise.
 252         (tui_source_window::maybe_update): Update.
 253         * tui/tui-disasm.c (tui_show_disassem)
 254         (tui_show_disassem_and_update_source)
 255         (tui_disasm_window::do_scroll_vertical)
 256         (tui_disasm_window::maybe_update): Update.
 257
 258 2019-08-16  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui.c (tui_is_window_visible): Update.
 261         * tui/tui-wingeneral.c (tui_make_window)
 262         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 263         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 264         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 265         (tui_set_win_height_command, parse_scrolling_args): Update.
 266         * tui/tui-source.c (tui_source_window::style_changed): Update.
 267         * tui/tui-regs.c (tui_show_registers)
 268         (tui_data_window::first_data_item_displayed)
 269         (tui_data_window::delete_data_content_windows)
 270         (tui_check_register_values, tui_reg_command): Update.
 271         * tui/tui-disasm.c (tui_show_disassem): Update.
 272         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 273         method.
 274         <is_visible>: Remove field.
 275         * tui/tui-data.c (tui_next_win, tui_prev_win)
 276         (tui_delete_invisible_windows): Update.
 277
 278 2019-08-16  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-winsource.h (struct tui_source_window_base)
 281         <m_has_locator>: Remove.
 282         * tui/tui-layout.c (show_source_disasm_command, show_data)
 283         (show_source_or_disasm_and_command): Update.
 284
 285 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 286
 287         * NEWS (Other MI changes): New subsection.
 288         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 289         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 290         * arch-utils.c (default_get_pc_address_flags): New function.
 291         * arch-utils.h (default_get_pc_address_flags): New declaration.
 292         * gdbarch.sh: Add get_pc_address_flags.
 293         * gdbarch.c: Regenerate.
 294         * gdbarch.h: Likewise.
 295         * stack.c (print_pc): New function.
 296         (print_frame_info) (print_frame): Call print_pc.
 297
 298 2019-08-16  Tom de Vries  <tdevries@suse.de>
 299
 300         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 301         print_objfile_section_info.
 302
 303 2019-08-15  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 306         calling update_cmdwin_start_line.
 307         * tui/tui-winsource.h (struct tui_source_window_base)
 308         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 309         <rerender>: Declare.
 310         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 311         Call rerender.
 312         (tui_source_window_base::set_new_height): Remove.
 313         (tui_source_window_base::rerender): Rename from
 314         do_make_visible_with_new_height.
 315         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 316         resize method.
 317         (tui_win_info::make_invisible_and_set_new_height)
 318         (tui_win_info::make_visible_with_new_height): Remove.
 319         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 320         Declare.
 321         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 322         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 323         do_make_visible_with_new_height>: Don't declare.
 324         <rerender>: Declare.
 325         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 326         set_new_height.
 327         (tui_data_window::do_make_visible_with_new_height): Remove.
 328         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 329         call tui_show_locator_content.
 330         (tui_gen_win_info::resize): Call rerender.
 331         (show_source_or_disasm_and_command): Don't call
 332         tui_show_locator_content.
 333         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 334         method.
 335         (struct tui_win_info) <rerender>: Declare.
 336         <set_new_height, make_invisible_and_set_new_height,
 337         make_visible_with_new_height>: Don't declare.
 338         * tui/tui-data.c (tui_win_list::rerender): New method.
 339         * tui/tui-command.h (struct tui_cmd_window)
 340         <do_make_visible_with_new_height>: Don't declare.
 341         * tui/tui-command.c
 342         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 343
 344 2019-08-15  Tom Tromey  <tromey@adacore.com>
 345
 346         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 347         * ada-lang.c (ada_enum_name): Likewise.
 348
 349 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 350
 351         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 352         leading underscore.
 353         (GdbOutputErrorFile): Likewise.
 354         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 355         accordingly.
 356         (execute_unwinders): Rename to have a leading underscore.
 357         (auto_load_packages): Likewise.
 358         (global scope): Adjust call to auto_load_packages accordingly.
 359         (GdbSetPythonDirectory): Likewise.
 360         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 361         instead of execute_unwinders.
 362
 363 2019-08-15  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 366         (show_data): Don't change window visibility.
 367         (tui_gen_win_info::resize): Remove special case for command
 368         window.  Use wresize, when available.
 369         (show_source_or_disasm_and_command): Don't change window
 370         visibility.
 371         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 372         <make_visible>: New method.
 373         * tui/tui-command.c (tui_cmd_window::resize): New method.
 374
 375 2019-08-15  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 378         (struct tui_source_windows): New.
 379         * tui/tui-winsource.c (tui_display_main): Update.
 380         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 381         (new_height_ok, parse_scrolling_args): Update.
 382         * tui/tui-layout.c (show_layout, show_data): Update.
 383         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 384         (tui_add_to_source_windows): Don't declare.
 385         * tui/tui-data.c (source_windows, tui_source_windows)
 386         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 387
 388 2019-08-15  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 391         Rename from reset.
 392         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 393         * tui/tui-layout.c (show_source_disasm_command, show_data):
 394         Update.
 395         (tui_gen_win_info::resize): Rename.
 396         (show_source_or_disasm_and_command): Update.
 397         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 398         reset.
 399
 400 2019-08-15  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 403         * tui/tui-interp.c (tui_interp::init): Don't call
 404         tui_initialize_static_data.
 405         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 406
 407 2019-08-15  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 410         examine tui_win_list.
 411
 412 2019-08-15  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 415         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 416         tui_clear_source_content.
 417         (tui_clear_source_content): Remove.
 418         (tui_source_window_base::do_erase_source_content): Hoist call to
 419         content.clear().
 420         * tui/tui-stack.c (tui_show_frame_info): Don't call
 421         tui_clear_source_content.
 422
 423 2019-08-15  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-winsource.h (struct tui_source_window_base)
 426         <do_erase_source_content>: New method.
 427         <erase_source_content>: New method.
 428         (tui_erase_source_content): Don't declare.
 429         * tui/tui-winsource.c (tui_clear_source_content): Update.
 430         (tui_source_window_base::do_erase_source_content): Rename from
 431         tui_erase_source_content.
 432         (tui_source_window_base::show_source_content): Update.
 433         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 434         * tui/tui-source.h (struct tui_source_window)
 435         <erase_source_content>: New method.
 436         * tui/tui-disasm.h (struct tui_disasm_window)
 437         <erase_source_content>: New method.
 438
 439 2019-08-15  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 442         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 443         constructor.
 444         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 445         * tui/tui-source.c (tui_set_source_content): Update.
 446         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 447
 448 2019-08-15  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 451         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 452         tui-source.c.
 453         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 454         Declare.
 455         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 456         method.
 457         (tui_source_window::maybe_update): Update.
 458
 459 2019-08-15  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 462         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 463         tui-disasm.c.
 464         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 465         Declare.
 466         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 467         method.
 468         (tui_disasm_window::maybe_update): Update.
 469
 470 2019-08-15  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-winsource.h (struct tui_source_window_base)
 473         <maybe_update>: Declare.
 474         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 475         method.
 476         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 477         Declare.
 478         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 479         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 480         Declare.
 481         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 482
 483 2019-08-15  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 486
 487 2019-08-15  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-wingeneral.c: Include tui-stack.h.
 490         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 491         (struct tui_locator_window): Move from tui-data.h.
 492         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 493         (tui_initialize_static_data): Move from tui-data.c.
 494         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 495         (struct tui_locator_window): Move to tui-stack.c.
 496         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 497         (tui_initialize_static_data): Move to tui-stack.c.
 498
 499 2019-08-15  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-layout.c (show_source_disasm_command)
 502         (show_source_or_disasm_and_command): Use make_visible method, not
 503         tui_make_window.
 504         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 505         Remove.
 506
 507 2019-08-15  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-wingeneral.h (tui_make_window): Update.
 510         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 511         parameter.
 512         (tui_gen_win_info::make_visible): Update.
 513         * tui/tui-regs.c (tui_data_window::display_registers_from):
 514         Update.
 515         * tui/tui-layout.c (show_source_disasm_command)
 516         (show_source_or_disasm_and_command): Update.
 517         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 518         (enum tui_box): Remove.
 519         (struct tui_win_info) <can_box>: New method.
 520         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 521         method.
 522
 523 2019-08-15  Tom de Vries  <tdevries@suse.de>
 524
 525         * linux-nat-trad.c: Include gdbarch.h.
 526
 527 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 528
 529         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 530         register sizes.
 531
 532 2019-08-14  Tom Tromey  <tromey@adacore.com>
 533
 534         * darwin-nat.c: Include gdbarch.h.
 535         * darwin-nat-info.c: Include gdbarch.h.
 536
 537 2019-08-13  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 540         Remove.
 541         * tui/tui-data.c (tui_initialize_static_data): Update.
 542
 543 2019-08-13  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-winsource.h (struct tui_exec_info_window)
 546         <~tui_exec_info_window, maybe_allocate_content, get_content,
 547         m_content>: Remove.
 548         (struct tui_source_window_base) <set_exec_info_content,
 549         show_exec_info_content>: Don't declare.
 550         * tui/tui-winsource.c
 551         (tui_exec_info_window::maybe_allocate_content): Remove.
 552         (tui_source_window_base::update_exec_info): Rename from
 553         set_exec_info_content.
 554         (tui_source_window_base::show_exec_info_content)
 555         (tui_source_window_base::update_exec_info): Remove.
 556
 557 2019-08-13  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 560         declare.
 561         * tui/tui-winsource.c (tui_update_source_window_as_is)
 562         (tui_update_source_windows_with_addr, tui_erase_source_content):
 563         Update.
 564         (tui_clear_exec_info_content): Remove.
 565
 566 2019-08-13  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 569         declare.
 570         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 571         call tui_erase_exec_info_content.
 572         (tui_clear_exec_info_content): Rename from
 573         tui_erase_exec_info_content.
 574         (tui_clear_exec_info_content): Delete.
 575
 576 2019-08-13  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-winsource.h (struct tui_source_window_base)
 579         <show_exec_info_content>: Declare.
 580         (tui_show_exec_info_content): Don't declare.
 581         * tui/tui-winsource.c
 582         (tui_source_window_base::show_exec_info_content): Rename from
 583         tui_show_exec_info_content.
 584         (tui_source_window_base::update_exec_info): Update.
 585
 586 2019-08-13  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 589         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 590         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 591         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 592         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 593         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 594         ... here.
 595
 596 2019-08-13  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-winsource.h (struct tui_source_window_base)
 599         <update_exec_info>: Declare.
 600         (tui_update_exec_info): Don't declare.
 601         * tui/tui-winsource.c (tui_update_source_window_as_is)
 602         (tui_source_window_base::refresh_all)
 603         (tui_update_all_breakpoint_info): Update.
 604         (tui_source_window_base::update_exec_info): Rename from
 605         tui_update_exec_info.
 606         * tui/tui-stack.c (tui_show_frame_info): Update.
 607
 608 2019-08-13  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-winsource.h (struct tui_source_window_base)
 611         <set_exec_info_content>: Declare.
 612         (tui_set_exec_info_content): Don't declare.
 613         * tui/tui-winsource.c
 614         (tui_source_window_base::set_exec_info_content): Rename from
 615         tui_set_exec_info_content.
 616         (tui_update_exec_info): Update.
 617
 618 2019-08-13  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-winsource.h (struct tui_source_window_base)
 621         <show_source_content>: Declare.
 622         (tui_show_source_content): Don't declare.
 623         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 624         (tui_source_window_base::show_source_content): Rename from
 625         tui_show_source_content.
 626         (tui_source_window_base::refresh_all): Update.
 627         * tui/tui-layout.c (show_source_disasm_command)
 628         (show_source_or_disasm_and_command): Update.
 629
 630 2019-08-13  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-winsource.c (tui_erase_source_content)
 633         (tui_show_source_content, tui_source_window_base::refresh_all):
 634         Update.
 635         * tui/tui-wingeneral.h
 636         (tui_check_and_display_highlight_if_needed): Don't declare.
 637         * tui/tui-wingeneral.c
 638         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 639         check_and_display_highlight_if_needed.
 640         * tui/tui-win.c (tui_rehighlight_all)
 641         (tui_win_info::make_visible_with_new_height): Update.
 642         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 643         (tui_data_window::erase_data_content)
 644         (tui_data_window::display_all_data): Update.
 645         * tui/tui-data.h (struct tui_win_info)
 646         <check_and_display_highlight_if_needed>: Declare.
 647
 648 2019-08-13  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-win.c (tui_resize_all): Call
 651         tui_delete_invisible_windows.
 652         * tui/tui-layout.c (show_layout): Call
 653         tui_delete_invisible_windows.
 654         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 655         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 656
 657 2019-08-13  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 660         tui_add_win_to_layout.
 661
 662 2019-08-13  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 665         * tui/tui-layout.c (tui_default_win_height): Now static.
 666
 667 2019-08-13  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 670         single switch.
 671         (show_source_disasm_command, show_source_or_disasm_and_command):
 672         Don't check current layout.
 673
 674 2019-08-13  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-wingeneral.c (make_all_visible): Remove.
 677         (tui_make_all_invisible): Simplify.
 678         * tui/tui-layout.c (tui_make_all_invisible): Move from
 679         tui-wingeneral.c; simplify.
 680         (show_layout): Hoist call to tui_make_all_invisible.
 681         (show_data): Don't call tui_make_all_invisible.
 682
 683 2019-08-13  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 686         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 687
 688 2019-08-13  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 691         tui-data.c.
 692         (show_source_disasm_command, show_data)
 693         (show_source_or_disasm_and_command): Don't use
 694         tui_set_current_layout_to.
 695         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 696         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 697         tui-layout.c.
 698         (tui_set_current_layout_to): Remove.
 699
 700 2019-08-13  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-layout.c (tui_set_layout): Update.
 703         * tui/tui-data.h (struct tui_layout_def): Remove.
 704         (tui_layout_def): Don't declare.
 705         * tui/tui-data.c (layout_def): Remove.
 706         (tui_layout_def): Remove.
 707
 708 2019-08-13  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-winsource.h (struct tui_source_window_base)
 711         <clear_detail>: No longer "override".
 712         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 713         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 714         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 715         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 716         Remove.
 717         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 718
 719 2019-08-13  Tom Tromey  <tromey@adacore.com>
 720
 721         * tracepoint.c: Don't include readline.h or history.h.
 722
 723 2019-08-12  Tom Tromey  <tom@tromey.com>
 724
 725         * configure: Rebuild.
 726         * configure.ac: Check for readline 7.
 727         * NEWS: Mention readline 7 requirement.
 728         * README: Update.
 729
 730 2019-08-12  Tom Tromey  <tom@tromey.com>
 731
 732         * mingw-hdep.c (gdb_select): Remove readline hack.
 733
 734 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 735
 736         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 737         when the function fails.
 738
 739 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 740
 741         * s390-tdep.c (s390_type_align): New function.
 742         (s390_gdbarch_init): Set it as type_align gdbarch method.
 743
 744 2019-08-09  Tom de Vries  <tdevries@suse.de>
 745
 746         PR gdb/24591
 747         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 748         pc_low with relocation offset.
 749
 750 2019-08-07  Tom Tromey  <tromey@adacore.com>
 751
 752         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 753         (print_frame_args): Update.
 754         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 755         Update.
 756         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 757         * frame.h (struct frame_arg): Add initializers.
 758         <error>: Now a unique_xmalloc_ptr.
 759
 760 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 761
 762         * NEWS: Expand the Pointer Authentication entry.
 763         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 764         (aarch64_frame_unmask_lr): ... to this.
 765         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 766         Call aarch64_frame_unmask_lr.
 767         * frame.c (struct frame_info): Add "masked" variable.
 768         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 769         (fprint_frame): Check for masked pc.
 770         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 771         declarations.
 772         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 773         * stack.c (print_frame): Check for masked pc.
 774
 775 2019-08-06  Tom Tromey  <tom@tromey.com>
 776
 777         * stabsread.c (patch_block_stabs, read_one_struct_field)
 778         (read_enum_type): Use obstack_strndup.
 779         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 780         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 781         * dwarf2read.c (guess_full_die_structure_name)
 782         (anonymous_struct_prefix): Use obstack_strndup.
 783         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 784         * c-exp.y (yylex): Use obstack_strndup.
 785         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 786         (write_var_or_type): Use obstack_strndup.
 787
 788 2019-08-06  Tom Tromey  <tom@tromey.com>
 789
 790         * symfile.c (reread_symbols): Use obstack_strdup.
 791         * stabsread.c (read_type): Use obstack_strdup.
 792         * gdb_obstack.h (obstack_strdup): New overload.
 793         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 794         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 795         (dwarf2_canonicalize_name): Use obstack_strdup.
 796         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 797         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 798         Use obstack_strdup.
 799
 800 2019-08-06  Tom Tromey  <tom@tromey.com>
 801
 802         * gdb_obstack.h (obstack_strdup): Define.
 803         * gdb_obstack.c (obstack_strdup): Don't define.
 804
 805 2019-08-06  Tom Tromey  <tom@tromey.com>
 806
 807         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 808         obstack_strdup.
 809         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 810         obstack_strdup.
 811         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 812         * stabsread.c (common_block_start): Use obstack_strdup.
 813         * objfiles.c (set_objfile_main_name, objfile): Use
 814         obstack_strdup.
 815         * namespace.c (add_using_directive): Use obstack_strdup.
 816         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 817         * jit.c (finalize_symtab): Use obstack_strdup.
 818         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 819         (guess_partial_die_structure_name, partial_die_info::fixup)
 820         (dwarf2_name): Use obstack_strdup.
 821         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 822         obstack_strdup.
 823         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 824         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 825         obstack_strdup.
 826         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 827
 828 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 829
 830         * unittests/help-doc-selftests.c: New file.
 831         * Makefile.in: Add the new file.
 832
 833 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 834
 835         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 836         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 837         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 838         the trailing '.' is not output, and the first character is uppercased.
 839         (print_help_for_command): Update call to print_doc_line.
 840         (print_doc_of_command): Likewise.
 841         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 842         * cli/cli-option.c (append_indented_doc): Do not append newline.
 843         (build_help_option): Append newline after first appended_indented_doc
 844         only if a second call is done.
 845         (build_help): Append 2 new lines before each option, except the first
 846         one.
 847         * compile/compile.c (_initialize_compile): Add new lines after
 848         %OPTIONS%, when not at the end of the help.
 849         Change help doc or code
 850         producing the help doc to respect the invariants.
 851         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 852         Also removed the new line after 'Options:', as all other commands
 853         do not put an empty line between 'Options:' and the first option.
 854         * printcmd.c (_initialize_printcmd): Likewise.
 855         * stack.c (_initialize_stack): Likewise.
 856         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 857         incorrectly telling COMMAND is optional.
 858         * ada-lang.c (_initialize_ada_language): Change help doc or code
 859         producing the help doc to respect the invariants.
 860         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 861         * breakpoint.c (_initialize_breakpoint): Likewise.
 862         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 863         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 864         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 865         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 866         _initialize_cli_style): Likewise.
 867         * corelow.c (core_target_info): Likewise.
 868         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 869         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 870         * filesystem.c (_initialize_filesystem): Likewise.
 871         * frame.c (_initialize_frame): Likewise.
 872         * gnu-nat.c (add_task_commands): Likewise.
 873         * infcall.c (_initialize_infcall): Likewise.
 874         * infcmd.c (_initialize_infcmd): Likewise.
 875         * interps.c (_initialize_interpreter): Likewise.
 876         * language.c (_initialize_language): Likewise.
 877         * linux-fork.c (_initialize_linux_fork): Likewise.
 878         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 879         * maint.c (_initialize_maint_cmds): Likewise.
 880         * memattr.c (_initialize_mem): Likewise.
 881         * printcmd.c (_initialize_printcmd): Likewise.
 882         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 883         _RegEx): Likewise.
 884         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 885         * record-btrace.c (_initialize_record_btrace): Likewise.
 886         * record-full.c (_initialize_record_full): Likewise.
 887         * record.c (_initialize_record): Likewise.
 888         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 889         * regcache.c (_initialize_regcache): Likewise.
 890         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 891         _initialize_remote): Likewise.
 892         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 893         * serial.c (_initialize_serial): Likewise.
 894         * skip.c (_initialize_step_skip): Likewise.
 895         * source.c (_initialize_source): Likewise.
 896         * stack.c (_initialize_stack): Likewise.
 897         * symfile.c (_initialize_symfile): Likewise.
 898         * symtab.c (_initialize_symtab): Likewise.
 899         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 900         * top.c (init_main): Likewise.
 901         * tracefile-tfile.c (tfile_target_info): Likewise.
 902         * tracepoint.c (_initialize_tracepoint): Likewise.
 903         * tui/tui-win.c (_initialize_tui_win): Likewise.
 904         * utils.c (add_internal_problem_command): Likewise.
 905         * valprint.c (value_print_option_defs): Likewise.
 906
 907 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 908
 909         PR build/24886
 910         * configure.ac: Drop enable-libmcheck support.
 911         * configure, config.in: Rebuild.
 912         * libmcheck.m4: Remove.
 913         * acinclude.m4: Don't include it.
 914         * Makefile.in: Don't distribute it.
 915         * top.c (print_gdb_configuration): Don't mention it.
 916
 917 2019-08-06  Tom Tromey  <tom@tromey.com>
 918
 919         * utils.c (set_output_style): Sometimes pass stream to
 920         emit_style_escape.
 921         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 922         * record-btrace.c (btrace_insn_history): Update.
 923         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 924         method.
 925         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 926         Update initializers.
 927         <m_uiout>: New field.
 928         <m_di>: Move lower.
 929         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 930         Remove "uiout" parameter.
 931         (dump_insns): Update.
 932         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 933         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 934
 935 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 936
 937         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 938         (error_in_psymtab_expansion): Likewise.
 939         (lookup_symbol_via_quick_fns): Likewise.
 940         (basic_lookup_transparent_type_quick): Likewise.
 941         (basic_lookup_transparent_type_1): Likewise.
 942
 943 2019-08-06  Tom Tromey  <tromey@adacore.com>
 944
 945         * source.c (last_source_error): Now bool.
 946         (print_source_lines_base): Make "noprint" bool.  Only open
 947         source file when last_source_visited changes.
 948
 949 2019-08-06  Tom Tromey  <tromey@adacore.com>
 950
 951         * annotate.c (annotate_source_line): Use g_source_cache.
 952         * source-cache.c (source_cache::get_plain_source_lines): Change
 953         parameters.  Populate m_offset_cache.
 954         (source_cache::ensure): New method.
 955         (source_cache::get_line_charpos): New method.
 956         (extract_lines): Move lower.  Change parameters.
 957         (source_cache::get_source_lines): Move lower.
 958         * source-cache.h (class source_cache): Update comment.
 959         <get_line_charpos>: New method.
 960         <get_source_lines>: Update comment.
 961         <clear>: Clear m_offset_cache.
 962         <get_plain_source_lines>: Change parameters.
 963         <ensure>: New method
 964         <m_offset_cache>: New member.
 965         * source.c (forget_cached_source_info_for_objfile): Update.
 966         (info_source_command): Use g_source_cache.
 967         (find_source_lines, open_source_file_with_line_charpos): Remove.
 968         (print_source_lines_base, search_command_helper): Use g_source_cache.
 969         * source.h (open_source_file_with_line_charpos): Don't declare.
 970         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 971         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 972         Use g_source_cache.
 973
 974 2019-08-06  Tom Tromey  <tromey@adacore.com>
 975
 976         * source-cache.c (source_cache::get_plain_source_lines):
 977         Remove "first_line" and "last_line" parameters.
 978         (source_cache::get_source_lines): Cache plain text.
 979         * source-cache.h (class source_cache)
 980         <get_plain_source_lines>: Update.
 981
 982 2019-08-06  Tom Tromey  <tromey@adacore.com>
 983
 984         * source-cache.c (extract_lines): No longer a method.
 985         Changed type of parameter.  Include final newline.
 986         (selftests::extract_lines_test): New function.
 987         (_initialize_source_cache): Likewise.
 988         * source-cache.h (class source_cache)
 989         <extract_lines>: Don't declare.
 990
 991 2019-08-06  Tom Tromey  <tromey@adacore.com>
 992
 993         * breakpoint.c (init_breakpoint_sal): Update.
 994         (breakpoint): Update.
 995         * breakpoint.h (struct breakpoint) <filter>: Now a
 996         unique_xmalloc_ptr.
 997
 998 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 999
1000         * NEWS: Mention dictionary access on blocks.
1001         * python/py-block.c (blpy_getitem): New function.
1002         (block_object_as_mapping): New struct.
1003         (block_object_type): Use new struct for tp_as_mapping field.
1004
1005 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1006
1007         * objfiles.h (objfile): Add a comment describing partial symbols.
1008
1009 2019-08-05  Tom Tromey  <tromey@adacore.com>
1010
1011         * compile/compile.c (_initialize_compile): Use _(), not N_().
1012         * thread.c (_initialize_thread): Use _(), not N_().
1013         * stack.c (_initialize_stack): Use _(), not N_().
1014         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1015
1016 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1017
1018         * dwarf2read.c (struct dw2_symtab_iterator):
1019         <want_specific_block>: Remove.
1020         <block_index>: Change type to gdb::optional.
1021         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1022         change type of BLOCK_INDEX parameter to gdb::optional.
1023         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1024         (dw2_lookup_symbol): Don't pass argument for
1025         WANT_SPECIFIC_BLOCK.
1026         (dw2_expand_symtabs_for_function): Don't pass argument for
1027         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1028         (class dw2_debug_names_iterator)
1029         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1030         parameter, change BLOCK_INDEX type to gdb::optional.
1031         <m_want_specific_block>: Remove.
1032         <m_block_index>: Change type to gdb::optional.
1033         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1034         gdb::optional.  Re-write in function of gdb::optional.
1035         (dw2_debug_names_lookup_symbol): Don't pass argument for
1036         WANT_SPECIFIC_BLOCK.
1037         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1038         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1039         BLOCK_INDEX.
1040
1041 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1042
1043         * NEWS: Mention changes to "info sources" command.
1044
1045 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1046
1047         * symtab.c (filename_partial_match_opts): New struct type.
1048         (struct output_source_filename_data): New members
1049         regexp, c_regexp, partial_match.
1050         (output_source_filename): Use new members to decide to print file.
1051         (info_sources_option_defs): New variable.
1052         (make_info_sources_options_def_group, print_info_sources_header,
1053         info_sources_command_completer):
1054         New functions.
1055         (info_sources_command): Read new optional arguments.
1056         (_initialize_symtab): Update info sources help.
1057
1058 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1059
1060         * ada-lang.c (exception_support_info_v0): Renamed from...
1061         (default_exception_support_info): ... this.  Create new
1062         definition for v1.
1063         (ada_has_this_exception_support): Look up catch_handlers_sym.
1064         (ada_exception_support_info_sniffer): Try v0 after default.
1065
1066 2019-08-01  Tom Tromey  <tromey@adacore.com>
1067
1068         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1069         gdbarch.h.
1070
1071 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1072
1073         * s12z-tdep.c: Fix include path for s12z-opc.h.
1074
1075 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1076
1077         * NEWS: Require GNU make 3.82.
1078
1079 2019-07-16  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1082         declare.
1083
1084 2019-07-30  Tom Tromey  <tromey@adacore.com>
1085
1086         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1087
1088 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1089
1090         * printcmd.c (print_address_symbolic): Print negative offsets.
1091         (build_address_symbolic): Force signed arithmetic when computing
1092         offset.
1093
1094 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1095
1096         PR/24474: Add a function to lookup static variables.
1097         * NEWS: Mention this new function.
1098         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1099         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1100         * python/python.c (python_GdbMethods): Add new function.
1101
1102 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1103
1104         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1105         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1106         (objfpy_lookup_static_symbol): New function.
1107         (objfile_object_methods): Add new functions.
1108
1109 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1110
1111         * NEWS: Mention 'set|show print frame-info'.  Mention new
1112         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1113         backtrace argument.  Mention that python frame filtering code
1114         is now consistent with what 'backtrace' command prints.
1115
1116 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117
1118         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1119         comments.
1120         (print_frame_info_auto, print_frame_info_source_line,
1121         print_frame_info_location, print_frame_info_source_and_location,
1122         print_frame_info_location_and_address, print_frame_info_short_location):
1123         New declarations.
1124         (struct frame_print_options): New member print_frame_info.
1125         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1126         * stack.h (get_user_print_what_frame_info): New declaration.
1127         (frame_show_address): New declaration.
1128         * stack.c (print_frame_arguments_choices): New value 'presence'.
1129         (print_frame_info_auto, print_frame_info_source_line,
1130         print_frame_info_location, print_frame_info_source_and_location,
1131         print_frame_info_location_and_address, print_frame_info_short_location,
1132         print_frame_info_choices, print_frame_info_print_what): New definitions.
1133         (print_frame_args): Only print dots for args if print frame-arguments
1134         is 'presence'.
1135         (frame_print_option_defs): New element for "frame-info".
1136         (get_user_print_what_frame_info): New function.
1137         (frame_show_address): Make non static.  Move comment to stack.h.
1138         (print_frame_info_to_print_what): New function.
1139         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1140         to decide what to print.
1141         (backtrace_command_1): Handle the new print_frame_arguments_presence
1142         value.
1143         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1144         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1145         (py_print_frame): In non-mi mode, use LOCATION as default for
1146         print_what, similarly to frame information printed directly by
1147         backtrace command. Handle frame-info user option in non MI mode.
1148
1149 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1150
1151         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1152         Add case for debugging 32-bit target on 64-bit host.  Revise
1153         comment.
1154
1155 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1156
1157         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1158         instead of find_function_entry_range_from_pc.
1159
1160 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1161
1162         * stack.c (find_frame_funname): Remove code which preferred
1163         minsym over symtab sym in "certain pathological cases".
1164
1165         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1166         parameter.  Change type of "do_demangle" to bool.
1167         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1168         Pass suitable "prefer_sym_over_minsym" flag to
1169         build_address_symbolic().  Don't output "+" for negative offsets.
1170         * printcmd.c (print_address_symbolic): Update invocation of
1171         build_address_symbolic to include a "prefer_sym_over_minsym"
1172         flag.
1173         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1174         Restrict cases in which use of minimal symbol is preferred to that
1175         of a found symbol.  Update comments.
1176
1177         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1178         for entry pc when entry pc is out of range for that FDE.
1179
1180 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1181
1182         PR gdb/24839:
1183         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1184         type.
1185
1186 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1187
1188         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1189         this function's Python signature.
1190
1191
1192 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1193
1194         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1195         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1196         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1197         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1198         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1199
1200
1201 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1202
1203         * h8300-tdep.c (h8300_register_name_common): New.
1204         h8300_register_name): Use h8300_register_name_common.
1205         (h8300s_register_name): Likewise.
1206         (h8300sx_register_name): Likewise.
1207         (h8300h_register_nam): New.
1208         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1209
1210
1211 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1212
1213         * arm-tdep.c (arm_skip_cmse_entry): New function.
1214         (arm_is_sgstubs_section): New function.
1215         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1216
1217 2019-07-22  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1220         Don't self-assign.
1221
1222 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1225         type_print.
1226
1227 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1230         so that GDB doesn't match any msymbols when searching in the
1231         TYPES_DOMAIN.
1232         (print_symbol_info): Print using typedef_print or type_print based
1233         on the type of the symbol.  Add updated FIXME comment moved from...
1234         (_initialize_symtab): ... move and update FIXME comment to above.
1235
1236 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1237
1238         * NEWS: Mention adding -q option to "info types".
1239         * symtab.c (struct info_types_options): New struct.
1240         (info_types_options_defs): New variable.
1241         (make_info_types_options_def_group): New function.
1242         (info_types_command): Use gdb::option framework to parse options.
1243         (info_types_command_completer): New function.
1244         (_initialize_symtab): Extend the help text on "info types" and
1245         register command completer.
1246
1247 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1248
1249         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1250         (lookup_symbol_in_objfile): Change int to block_enum and add a
1251         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1252
1253 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1254
1255         * MAINTAINERS (Write After Approval): Add self.
1256
1257 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1260         instruction to the dummy code region.
1261
1262 2019-07-19  Tom Tromey  <tromey@adacore.com>
1263
1264         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1265         (ARGSUSED, PARAMS, __func__): Remove rules.
1266
1267 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1268
1269         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1270         * features/arm/arm-with-iwmmxt.c: Remove.
1271         * features/arm/arm-with-iwmmxt.xml: Remove.
1272         * features/arm/arm-with-m-fpa-layout.c: Remove.
1273         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1274         * features/arm/arm-with-m-vfp-d16.c: Remove.
1275         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1276         * features/arm/arm-with-m.c: Remove.
1277         * features/arm/arm-with-m.xml: Remove.
1278         * features/arm/arm-with-neon.c: Remove.
1279         * features/arm/arm-with-neon.xml: Remove.
1280         * features/arm/arm-with-vfpv2.c: Remove.
1281         * features/arm/arm-with-vfpv2.xml: Remove.
1282         * features/arm/arm-with-vfpv3.c: Remove.
1283         * features/arm/arm-with-vfpv3.xml: Remove.
1284
1285 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1286
1287         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1288
1289 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1290
1291         * arch/aarch32.c (aarch32_create_target_description): Create
1292         target descriptions using features.
1293         * arch/arm.c (arm_create_target_description)
1294         (arm_create_mprofile_target_description): Likewise.
1295         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1296
1297 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1298
1299         * Makefile.in: Add new files.
1300         * aarch32-tdep.c: New file.
1301         * aarch32-tdep.h: New file.
1302         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1303         Call aarch32_read_description.
1304         * arch/aarch32.c: New file.
1305         * arch/aarch32.h: New file.
1306         * arch/arm.c (arm_create_target_description)
1307         (arm_create_mprofile_target_description): New function.
1308         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1309         (arm_create_target_description)
1310         (arm_create_mprofile_target_description): New declaration.
1311         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1312         read_description functions.
1313         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1314         Likewise.
1315         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1316         * arm-tdep.c (tdesc_arm_list): New variable.
1317         (arm_register_g_packet_guesses): Call create description functions.
1318         (arm_read_description) (arm_read_mprofile_description): New
1319         function.
1320         * arm-tdep.h (arm_read_description)
1321         (arm_read_mprofile_description): Add declaration.
1322         * configure.tgt: Add new files.
1323
1324 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1325
1326         * top.c (new_ui_command): Open specified terminal just once.
1327
1328 2019-07-18  Tom Tromey  <tromey@adacore.com>
1329
1330         * symtab.c (main_name): Constify return type.
1331         * symfile.c (set_initial_language): Update.
1332         * symtab.h (main_name): Constify return type.
1333
1334 2019-07-17  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-winsource.c (tui_update_source_window)
1337         (tui_update_source_window_as_is)
1338         (tui_update_source_windows_with_line): Remove return.
1339         * tui/tui-disasm.c (tui_show_disassem)
1340         (tui_show_disassem_and_update_source): Remove return.
1341         * tui/tui.c (tui_reset): Remove return.
1342         * tui/tui-wingeneral.c
1343         (tui_check_and_display_highlight_if_needed): Remove return.
1344
1345 2019-07-17  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1348
1349 2019-07-17  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-winsource.h (struct tui_exec_info_window)
1352         (struct tui_source_window_base): Move from tui-data.h.
1353         * tui/tui-winsource.c: Move many method definitions from
1354         elsewhere.  Remove "structuring" comments.
1355         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1356         (tui_source_window_base::refresh_window): Move to
1357         tui-winsource.c.
1358         * tui/tui-win.c (tui_source_window_base::refresh_all)
1359         (tui_source_window_base::update_tab_width)
1360         (tui_source_window_base::set_new_height)
1361         (tui_source_window_base::do_make_visible_with_new_height): Move to
1362         tui-winsource.c.
1363         * tui/tui-source.h: Update.
1364         * tui/tui-source.c (tui_source_window_base::reset): Move to
1365         tui-winsource.c.
1366         * tui/tui-disasm.h: Update.
1367         * tui/tui-data.h (struct tui_exec_info_window): Move to
1368         tui-winsource.h.
1369         (struct tui_source_window_base): Likewise.
1370         * tui/tui-data.c (tui_source_window_base::clear_detail)
1371         (tui_source_window_base, ~tui_source_window_base): Move to
1372         tui-winsource.c.
1373
1374 2019-07-17  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-win.c (tui_resize_all)
1377         (tui_source_window_base::update_tab_width)
1378         (tui_adjust_win_heights): Update.
1379         (tui_win_info::make_invisible_and_set_new_height): Rename from
1380         make_invisible_and_set_new_height.
1381         * tui/tui-data.h (struct tui_win_info)
1382         <make_invisible_and_set_new_height>: New method.
1383
1384 2019-07-17  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui.c: Update.
1387         * tui/tui-source.h (struct tui_source_window): Move from
1388         tui-data.h.
1389         * tui/tui-layout.c: Update.
1390         * tui/tui-disasm.c: Update.
1391         * tui/tui-data.h (struct tui_source_window): Move to
1392         tui-source.h.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1397         tui-data.h.
1398         * tui/tui-data.h (struct tui_disasm_window): Move to
1399         tui-disasm.h.
1400
1401 2019-07-17  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-regs.h (struct tui_data_item_window): Move from
1404         tui-data.h.
1405         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1406         * tui/tui-data.h (struct tui_data_item_window): Move to
1407         tui-regs.h.
1408         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1409
1410 2019-07-17  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui.c: Update.
1413         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1414         (tui_cmd_window::max_height): Move to tui-command.c.
1415         * tui/tui-layout.c: Update.
1416         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1417         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1418         tui-command.c.
1419         * tui/tui-command.h (struct tui_cmd_window): Move from
1420         tui-data.h.
1421         * tui/tui-command.c: Remove "structuring" comments.
1422         (tui_cmd_window::clear_detail)
1423         (tui_cmd_window::do_make_visible_with_new_height)
1424         (tui_cmd_window::max_height): Move from elsewhere.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1429         Now static.
1430         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1431         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1432
1433 2019-07-17  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui.c: Update.
1436         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1437         tui-regs.c.
1438         * tui/tui-windata.h: Remove file.
1439         * tui/tui-windata.c: Remove file.
1440         * tui/tui-win.c (tui_data_window::set_new_height)
1441         (tui_data_window::do_make_visible_with_new_height): Move to
1442         tui-regs.c.
1443         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1444         * tui/tui-regs.c: Remove "structuring" comments.
1445         (tui_data_window::first_data_item_displayed)
1446         (tui_data_window::delete_data_content_windows)
1447         (tui_data_window::erase_data_content)
1448         (tui_data_window::display_all_data)
1449         (tui_data_window::refresh_all)
1450         (tui_data_window::do_scroll_vertical)
1451         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1452         (tui_data_window::do_make_visible_with_new_height)
1453         (tui_data_window::refresh_window): Move from elsewhere.
1454         (_initialize_tui_regs): Move to end of file.
1455         * tui/tui-layout.c: Update.
1456         * tui/tui-hooks.c: Update.
1457         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1458         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1459         tui-regs.c.
1460         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1461
1462 2019-07-17  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1465         seen.
1466
1467 2019-07-17  Tom Tromey  <tom@tromey.com>
1468
1469         * tui/tui-win.c (tui_source_window_base::set_new_height)
1470         (tui_source_window_base::do_make_visible_with_new_height): Use
1471         m_has_locator field directly.
1472         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1473         method.
1474         (struct tui_source_window_base) <has_locator>: Likewise.
1475
1476 2019-07-17  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1479         Don't declare.
1480         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1481         Remove.
1482         * tui/tui-win.c (tui_source_window_base::set_new_height)
1483         (tui_source_window_base::set_new_height)
1484         (make_invisible_and_set_new_height)
1485         (tui_source_window_base::do_make_visible_with_new_height)
1486         (tui_source_window_base::do_make_visible_with_new_height):
1487         Update.
1488         * tui/tui-layout.c (show_source_disasm_command, show_data)
1489         (show_source_or_disasm_and_command): Update.
1490         * tui/tui-layout.c (show_layout): Update.
1491
1492 2019-07-17  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-layout.c (make_data_window): Remove.
1495         (show_data): Unify creation and re-initialization cases.
1496
1497 2019-07-17  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-layout.c (make_source_window, make_disasm_window):
1500         Remove.
1501         (show_data): Unify creation and re-initialization cases.
1502
1503 2019-07-17  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-layout.c (make_command_window): Remove.
1506         (show_source_disasm_command, show_source_or_disasm_and_command):
1507         Unify creation and re-initialization cases.
1508
1509 2019-07-17  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1512         creation and re-initialization cases.
1513
1514 2019-07-17  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-regs.c (tui_get_register): Return void.
1517
1518 2019-07-17  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1521         Simplify.
1522
1523 2019-07-17  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1526         resetting.
1527
1528 2019-07-17  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1531         * tui/tui-regs.c (tui_reg_layout): New function.
1532         (tui_show_registers, tui_reg_command): Use it.
1533         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1534         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1535         parameters.
1536         (tui_layout_command): Remove.
1537
1538 2019-07-17  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-layout.h (tui/tui-layout): Return void.
1541         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-layout.c (show_source_disasm_command, show_data):
1546         Update.
1547         (reset_locator): Remove.
1548         (show_source_or_disasm_and_command): Update.
1549
1550 2019-07-17  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-source.c (tui_source_window_base::reset): Remove
1553         win_type parameter.
1554         * tui/tui-layout.c (make_command_window, make_source_window)
1555         (make_disasm_window, make_data_window)
1556         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1557         (reset_locator, show_source_or_disasm_and_command): Update.
1558         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1559         win_type parameter.
1560         (struct tui_source_window_base) <reset>: Likewise.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-layout.c (show_source_disasm_command): Use
1565         reset_locator.
1566         (reset_locator): New function.
1567         (init_and_make_win): Remove.
1568         (show_source_or_disasm_and_command): Use reset_locator.
1569
1570 2019-07-17  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1573         condition.
1574         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1575         Remove condition.
1576         * tui/tui-source.c (tui_source_window_base::reset): New method.
1577         * tui/tui-layout.c (make_command_window): Don't call
1578         init_and_make_win.
1579         (make_source_window, make_disasm_window): Don't call
1580         make_source_or_disasm_window.
1581         (make_data_window): Don't call init_and_make_win.  Change calling
1582         convention.
1583         (show_source_disasm_command, show_data): Simplify.
1584         (make_source_or_disasm_window): Remove.
1585         (show_source_or_disasm_and_command): Simplify.
1586         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1587         (struct tui_source_window_base) <reset>: Likewise.
1588         <execution_info>: Remove initializer.
1589         * tui/tui-data.c (tui_source_window_base): Initialize
1590         execution_info.
1591
1592 2019-07-17  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1595         variable.
1596
1597 2019-07-17  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui.c (tui_rl_other_window): Update.
1600         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1601         superclass method first.  Always iterate over regs_content.
1602         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1603         method.
1604         * tui/tui-win.c (tui_set_focus_command): Update.
1605
1606 2019-07-17  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-win.c (tui_set_focus_command): Rename from
1609         tui_set_focus.  Call tui_enable.
1610         (tui_set_focus_command): Remove.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1615         refresh_window.
1616         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1617         touchwin.
1618         (tui_data_window::refresh_window): Call refresh_window on data
1619         items.  Always call superclass refresh_window.
1620         (tui_win_info::refresh): Remove.
1621         (tui_source_window_base::refresh_window): Update.
1622         (tui_refresh_all): Update.
1623         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1624         refresh_window.
1625         (show_source_or_disasm_and_command): Likewise.
1626         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1627         (struct tui_source_window_base) <refresh>: Likewise.
1628
1629 2019-07-17  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-winsource.c (tui_clear_source_content)
1632         (tui_show_source_content): Update.
1633         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1634         whether content is empty.
1635         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1636         Remove.
1637
1638 2019-07-17  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1641         window's contents.
1642         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1643         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1648         (struct tui_data_item_window): Update.
1649
1650 2019-07-17  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1653         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1654         defines.
1655
1656 2019-07-17  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-winsource.h (tui_erase_source_content)
1659         (tui_clear_source_content): Remove "display_prompt" parameter.
1660         * tui/tui-winsource.c (tui_update_source_window_as_is)
1661         (tui_update_source_windows_with_addr): Update.
1662         (tui_clear_source_content): Remove "display_prompt" parameter.
1663         (tui_erase_source_content): Likewise.  Simplify.
1664         (tui_show_source_content): Update.
1665         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1666         * tui/tui-stack.c (tui_show_frame_info): Update.
1667         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1668         Remove defines.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1673         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1674         parameter.
1675         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1676         parameter.
1677
1678 2019-07-17  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-winsource.c (tui_clear_source_content)
1681         (tui_show_source_content, tui_show_exec_info_content)
1682         (tui_clear_exec_info_content): Update.
1683         * tui/tui-stack.c (tui_show_locator_content): Update.
1684         (tui_show_frame_info): Update.
1685         * tui/tui-source.h (tui_source_window): Don't declare.
1686         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1687         from tui_source_is_displayed.
1688         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1689         Remove field.
1690         (struct tui_source_window_base) <content_in_use>: New field.  Now
1691         bool.
1692         (struct tui_source_window) <showing_source_p>: New method.
1693         (TUI_SRC_WIN): Change cast.
1694         * tui/tui-data.c (tui_initialize_static_data): Update.
1695
1696 2019-07-17  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1699         location_matches_p.
1700         * tui/tui-source.c (tui_source_window::location_matches_p): New
1701         method.
1702         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1703         method.
1704         * tui/tui-data.h (struct tui_source_window_base)
1705         <location_matches_p>: New method.
1706         (struct tui_source_window, struct tui_disasm_window)
1707         <location_matches_p>: Likewise.
1708
1709 2019-07-17  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-win.c (tui_set_win_height_command): Rename from
1712         tui_set_win_height.
1713         (tui_set_win_height_command): Remove.
1714
1715 2019-07-17  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-source.c (tui_source_window): New constructor.  Add
1718         observer.
1719         (~tui_source_window): New destructor.
1720         (tui_source_window::style_changed): New method.
1721         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1722         (tui_attach_detach_observers): Update.
1723         * tui/tui-data.h (struct tui_source_window): Make constructor not
1724         inline.  Add destructor.
1725         (struct tui_source_window) <style_changed>: New method.
1726         <m_observable>: New member.
1727
1728 2019-07-17  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1731         * tui/tui-win.c (tui_resize_all): Fix typo.
1732
1733 2019-07-17  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1736         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1737         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1738         * tui/tui-win.c (window_name_completer): Use foreach.
1739         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1740         (update_tab_width): Likewise.
1741         * tui/tui-layout.c (show_layout): Update.
1742         * tui/tui-data.h (class tui_window_iterator): New.
1743         (struct all_tui_windows): New.
1744         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1749         parameter.  Don't reference globals.
1750         (tui_reg_command): Update.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-regs.c (tui_show_registers): Simplify.
1755
1756 2019-07-17  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-regs.c (tui_show_registers): Update.
1759         (tui_show_register_group): Add win_info parameter.
1760
1761 2019-07-17  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1764         Rename from tui_display_reg_element_at_line.
1765         (tui_data_window::display_registers_from_line): Update.
1766         * tui/tui-data.h (struct tui_data_window)
1767         <display_reg_element_at_line>: New method.
1768
1769 2019-07-17  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-regs.h (tui_display_registers_from)
1772         (tui_display_registers_from_line): Don't declare.
1773         * tui/tui-windata.c (tui_data_window::display_all_data)
1774         (tui_data_window::refresh_all)
1775         (tui_data_window::do_scroll_vertical): Update.
1776         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1777         from tui_display_registers_from.
1778         (tui_display_reg_element_at_line): Update.
1779         (tui_data_window::display_registers_from_line): Rename from
1780         tui_display_registers_from_line.
1781         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1782         display_registers_from_line>: New methods.
1783
1784 2019-07-17  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1787         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1788         from tui_erase_data_content.
1789         (tui_data_window::display_all_data)
1790         (tui_data_window::refresh_all)
1791         (tui_data_window::do_scroll_vertical): Update.
1792         * tui/tui-regs.c (tui_show_registers): Update.
1793         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1794         New method.
1795
1796 2019-07-17  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1799         declare.
1800         * tui/tui-windata.c
1801         (tui_data_window::delete_data_content_windows): Rename from
1802         tui_delete_data_content_windows.
1803         (tui_data_window::display_all_data)
1804         (tui_data_window::do_scroll_vertical): Update.
1805         * tui/tui-data.h (struct tui_data_window)
1806         <delete_data_content_windows>: New method.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1811         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1812
1813 2019-07-17  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1816         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1817         from tui_display_all_data.
1818         * tui/tui-win.c
1819         (tui_data_window::do_make_visible_with_new_height): Update.
1820         * tui/tui-regs.c (tui_show_registers): Update.
1821         * tui/tui-layout.c (tui_set_layout): Update.
1822         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1823         method.
1824
1825 2019-07-17  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1828         * tui/tui-windata.c (tui_display_data_from): Remove.
1829         (tui_data_window::refresh_all): Update.
1830
1831 2019-07-17  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1834         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1835         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1836         tui_display_registers_from_line.
1837         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1838         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1839         "force_display" parameter.
1840
1841 2019-07-17  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1844         declare.
1845         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1846         Rename from tui_first_reg_element_no_inline.
1847         (tui_display_reg_element_at_line)
1848         (tui_display_registers_from_line): Update.
1849         * tui/tui-data.h (struct tui_data_window)
1850         <first_reg_element_no_inline>: New method.
1851
1852 2019-07-17  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-windata.c (tui_display_data_from)
1855         (tui_data_window::do_scroll_vertical): Update.
1856         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1857         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1858         Rename from tui_line_from_reg_element_no.
1859         (tui_display_registers_from_line): Update.
1860         * tui/tui-data.h (struct tui_data_window)
1861         <line_from_reg_element_no>: New method.
1862
1863 2019-07-17  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1866         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1867         tui_last_regs_line_no.
1868         (tui_display_reg_element_at_line)
1869         (tui_display_registers_from_line): Update.
1870         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1871         method.
1872
1873 2019-07-17  Tom Tromey  <tom@tromey.com>
1874
1875         PR tui/24722:
1876         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1877         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1878         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1879         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1880         (tui_update_breakpoint_info): Likewise.
1881         * tui/tui-hooks.c (tui_event_create_breakpoint)
1882         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1883         Update.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-winsource.c (tui_update_source_window_as_is)
1892         (tui_update_source_windows_with_addr): Update.
1893         * tui/tui-source.h (tui_set_source_content)
1894         (tui_show_symtab_source): Add "win_info" parameter.
1895         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1896         parameter.
1897         (tui_show_symtab_source): Likewise.
1898
1899 2019-07-17  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-wingeneral.c
1902         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1903
1904 2019-07-17  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1907         (struct tui_cmd_window) <can_scroll>: New method.
1908         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1909         method.
1910
1911 2019-07-17  Tom Tromey  <tromey@adacore.com>
1912
1913         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1914         do_field_signed>: Rename.  Change type of "value".
1915         * ui-out.c (ui_out::field_signed): Rename from field_int.
1916         Change type of "value".
1917         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1918         type of "value".
1919         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1920         do_field_int.  Change type of "value".
1921         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1922         do_field_int.  Change type of "value".
1923         * tracepoint.c (trace_status_mi, tfind_1)
1924         (print_one_static_tracepoint_marker): Update.
1925         * thread.c (print_thread_info_1, print_selected_thread_frame):
1926         Update.
1927         * stack.c (print_frame, print_frame_info): Update.
1928         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1929         Update.
1930         * source.c (print_source_lines_base): Update.
1931         * skip.c (info_skip_command): Update.
1932         * record-btrace.c (btrace_ui_out_decode_error)
1933         (btrace_call_history_src_line): Update.
1934         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1935         Update.
1936         * progspace.c (print_program_space): Update.
1937         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1938         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1939         do_field_int.  Change type of "value".
1940         * mi/mi-out.c (mi_ui_out::do_table_begin)
1941         (mi_ui_out::do_table_header): Update.
1942         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1943         type of "value".
1944         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1945         (mi_cmd_data_list_changed_registers, output_register)
1946         (mi_cmd_data_read_memory, mi_load_progress)
1947         (mi_cmd_trace_frame_collected): Update.
1948         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1949         Update.
1950         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1951         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1952         (mi_cmd_var_list_children, varobj_update_one): Update.
1953         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1954         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1955         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1956         * inferior.c (print_inferior): Update.
1957         * gdb_bfd.c (print_one_bfd): Update.
1958         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1959         Update.
1960         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1961         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1962         do_field_int.  Change type of "value".
1963         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1964         do_field_int.  Change type of "value".
1965         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1966         (print_one_breakpoint_location, print_it_catch_fork)
1967         (print_one_catch_fork, print_it_catch_vfork)
1968         (print_one_catch_vfork, print_it_catch_solib)
1969         (print_it_catch_exec, print_it_ranged_breakpoint)
1970         (print_mention_watchpoint, print_mention_masked_watchpoint)
1971         (bkpt_print_it, update_static_tracepoint): Update.
1972         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1973         * break-catch-syscall.c (print_it_catch_syscall): Update.
1974         * ada-tasks.c (print_ada_task_info): Update.
1975         * ada-lang.c (print_it_exception, print_mention_exception):
1976         Update.
1977
1978 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         PR breakpoints/24541
1981         * gdbarch.c: Regenerate.
1982         * gdbarch.h: Regenerate.
1983         * gdbarch.sh: Adjust return type and parameter types for
1984         'stap_adjust_register'.
1985         (i386_stap_adjust_register): Adjust signature and return new
1986         register name.
1987         * stap-probe.c (stap_parse_register_operand): Adjust use of
1988         'gdbarch_stap_adjust_register'.
1989
1990 2019-07-17  Tom Tromey  <tromey@adacore.com>
1991
1992         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1993         declare VEC.
1994         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1995         std::vector.
1996         (struct s390_process_info): Add initializers.
1997         (s390_add_process): Use new.
1998         (s390_linux_nat_target::low_forget_process): Use delete.
1999         (s390_linux_nat_target::low_new_fork)
2000         (s390_linux_nat_target::stopped_by_watchpoint)
2001         (s390_linux_nat_target::low_prepare_to_resume)
2002         (s390_linux_nat_target::insert_watchpoint)
2003         (s390_linux_nat_target::insert_hw_breakpoint)
2004         (s390_linux_nat_target::remove_watchpoint)
2005         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2006
2007 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2008
2009         * aarch64-fbsd-nat.c: Include regcache.h.
2010         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2011         argument.
2012         (aarch64_fbsd_nat_target::fetch_registers)
2013         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2014         variable.
2015         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2016
2017 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2018
2019         * fbsd-nat.c: Include gdbarch.h.
2020
2021 2019-07-15  Tom Tromey  <tromey@adacore.com>
2022
2023         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2024
2025 2019-07-15  Tom Tromey  <tromey@adacore.com>
2026
2027         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2028         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2029         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2030         * cli-out.c (cli_ui_out::do_field_int): New method.
2031         * ui-out.c (ui_out::field_unsigned): New method.
2032         * symfile.c (generic_load): Use field_unsigned.
2033         (print_transfer_performance): Likewise.
2034         * record-btrace.c (ui_out_field_uint): Remove.
2035         (btrace_call_history_insn_range, btrace_call_history): Use
2036         field_unsigned.
2037         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2038         field_unsigned.
2039         * ui-out.h (class ui_out) <field_unsigned>: New method.
2040         <do_field_unsigned>: Likewise.
2041
2042 2019-07-15  Tom Tromey  <tromey@adacore.com>
2043
2044         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2045         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2046         * target.c (flash_erase_command): Use field_string.
2047         * infrun.c (print_signal_received_reason): Use field_string.
2048         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2049         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2050         field_string.
2051         * ada-tasks.c (print_ada_task_info): Use field_string.
2052
2053 2019-07-15  Tom Tromey  <tromey@adacore.com>
2054
2055         * target.c (flash_erase_command): Use field_core_addr.
2056         * symfile.c (generic_load): Use field_core_addr.
2057         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2058         Use field_core_addr.
2059         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2060         field_core_addr.
2061
2062 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2065         value if its desired type is smaller than a CORE_ADDR and signed.
2066
2067 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2068
2069         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2070         of changes to field names, and use new is_reference field to
2071         decide if a property is a reference or not.
2072         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2073         field.
2074         (struct dwarf2_property_baton): Update header comment, rename
2075         'referenced_type' to 'property_type' and update comments.
2076         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2077         default property type, store in property baton, update to take
2078         accound of renamed field.
2079         (read_func_scope): Update call to attr_to_dynamic_prop.
2080         (read_array_type): Likewise.
2081         (dwarf2_per_cu_addr_sized_int_type): New function.
2082         (read_subrange_index_type): Move type finding code to
2083         dwarf2_per_cu_addr_sized_int_type.
2084         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2085         (dwarf2_per_cu_addr_type): New function.
2086         (set_die_type): Update calls to attr_to_dynamic_prop.
2087
2088 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * dwarf2read.c (read_subrange_index_type): New function.
2091         (read_subrange_type): Move code into new function and call it.
2092         * gdbtypes.c (create_range_type): Add some asserts.
2093
2094 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2095
2096         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2097         update return statements.
2098         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2099         declaration, and update comment to match.
2100         * gdbtypes.c (resolve_dynamic_array): Update call to
2101         dwarf2_evaluate_property to match new return type.
2102
2103 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2104
2105         * valarith.c (value_subscripted_rvalue): Change lowerbound
2106         parameter type from int to LONGEST.
2107         * value.h (value_subscripted_rvalue): Likewise in declaration.
2108
2109 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * cli/cli-utils.c (info_print_command_completer): New function.
2112         * cli/cli-utils.h: Add 'completer.h' include, and forward
2113         declaration for 'struct cmd_list_element'.
2114         (info_print_command_completer): Declare.
2115         * stack.c (_initialize_stack): Add completer for 'info locals' and
2116         'info args'.
2117         * symtab.c (_initialize_symtab): Add completer for 'info
2118         variables' and 'info functions'.
2119         * NEWS: Mention completion for additional info commands.
2120
2121 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2122
2123         * cli/cli-utils.c (extract_info_print_args): Delete.
2124         (extract_arg_maybe_quoted): Delete.
2125         (info_print_options_defs): New variable.
2126         (make_info_print_options_def_group): New function.
2127         (extract_info_print_options): Define new function.
2128         * cli/cli-utils.h (extract_info_print_args): Delete.
2129         (struct info_print_options): New structure.
2130         (extract_info_print_options): Declare new function.
2131         * stack.c (info_locals_command): Update to use new
2132         extract_info_print_options, also add a header comment.
2133         (info_args_command): Likewise.
2134         * symtab.c (info_variables_command): Likewise.
2135         (info_functions_command): Likewise.
2136
2137 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2140         to extract string arguments.
2141         * common/common-utils.c (extract_string_maybe_quoted): New function.
2142         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2143
2144 2019-07-11  Tom Tromey  <tromey@adacore.com>
2145
2146         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2147         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2148         * top.h (gdbinit): Don't declare.
2149         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2150         into...
2151         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2152         * top.c (gdb_init): Don't call init_cli_cmds.
2153         (gdbinit): Remove.
2154         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2155
2156 2019-07-11  Tom Tromey  <tromey@adacore.com>
2157
2158         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2159         after it has been moved.
2160
2161 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2162
2163         * valops.c (value_must_coerce_to_target): Change return type to
2164         bool.
2165         * value.h (value_must_coerce_to_target): Likewise.
2166
2167 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2168
2169         * breakpoint.c (is_hardware_watchpoint): Remove
2170         forward-declaration.
2171         (is_masked_watchpoint): Change return type to bool.
2172         (is_tracepoint): Likewise.
2173         (is_breakpoint): Likewise.
2174         (is_hardware_watchpoint): Likewise.
2175         (is_watchpoint): Likewise.
2176         (is_no_memory_software_watchpoint): Likewise.
2177         (is_catchpoint): Likewise.
2178         (breakpoint_1): Make FILTER parameter's return type bool.
2179         is_masked_watchpoint): Change return type to bool.
2180         (save_breakpoints): Make FILTER parameter's return type bool.
2181         * breakpoint.h (is_breakpoint): Change return type to bool.
2182         (is_watchpoint): Likewise.
2183         (is_catchpoint): Likewise.
2184         (is_tracepoint): Likewise.
2185
2186 2019-07-10  Tom Tromey  <tom@tromey.com>
2187
2188         * defs.h: Don't include gdbarch.h.
2189         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2190         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2191         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2192         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2193         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2194         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2195         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2196         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2197         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2198         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2199         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2200         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2201         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2202         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2203         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2204         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2205         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2206         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2207         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2208         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2209         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2210         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2211         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2212         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2213         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2214         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2215         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2216
2217 2019-07-10  Tom Tromey  <tromey@adacore.com>
2218
2219         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2220         * breakpoint.c (init_ada_exception_breakpoint): Register as
2221         bp_catchpoint.
2222         (print_one_breakpoint_location, print_one_breakpoint): Use
2223         is_ada_exception_catchpoint.
2224         * ada-lang.c (class ada_catchpoint_location): Pass
2225         bp_loc_software_breakpoint to bp_location constructor.
2226         (is_ada_exception_catchpoint): New function.
2227
2228 2019-07-10  Tom Tromey  <tromey@adacore.com>
2229
2230         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2231         VEC.
2232         (struct arm_exidx_entry): New method operator<.
2233         (struct arm_exidx_data) <section_maps>: Change type.
2234         (arm_exidx_data_free): Remove.
2235         (arm_exidx_data_key): Change type.  Move lower.
2236         (arm_exidx_new_objfile): Update.
2237         (arm_compare_exidx_entries): Remove.
2238         (arm_find_exidx_entry, _initialize_arm_tdep)
2239
2240 2019-07-10  Tom Tromey  <tromey@adacore.com>
2241
2242         * solib-spu.c (ocl_program_data_key): Change type.
2243         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2244         Update.
2245
2246 2019-07-10  Tom Tromey  <tromey@adacore.com>
2247
2248         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2249         (struct solib_aix_inferior_data) <library_list>: Change type.
2250         (solib_aix_inferior_data_handle): Change type.
2251         (get_solib_aix_inferior_data): Update.
2252         (solib_aix_free_library_list): Remove.
2253         (library_list_start_library): Update.
2254         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2255         return type.
2256         (solib_aix_get_library_list)
2257         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2258         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2259
2260 2019-07-10  Tom Tromey  <tromey@adacore.com>
2261
2262         * solib-dsbt.c (struct dsbt_info): Add initializers.
2263         (solib_dsbt_pspace_data): Change type.
2264         (dsbt_pspace_data_cleanup): Remove.
2265         (get_dsbt_info, _initialize_dsbt_solib): Update.
2266
2267 2019-07-10  Tom Tromey  <tromey@adacore.com>
2268
2269         * spu-tdep.c (spu_overlay_data): Change type.
2270         (spu_get_overlay_table, spu_overlay_new_objfile)
2271         (_initialize_spu_tdep): Update.
2272
2273 2019-07-10  Tom Tromey  <tromey@adacore.com>
2274
2275         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2276         destructor.
2277         (dbx_objfile_data_key): Change type and declare later.
2278         (DBX_SYMFILE_INFO): Rewrite.
2279         * dbxread.c (dbx_objfile_data_key): Change type.
2280         (dbx_symfile_init): Update.
2281         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2282         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2283         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2284
2285 2019-07-10  Tom Tromey  <tromey@adacore.com>
2286
2287         * jit.c (jit_program_space_key): Change type.  Move lower.
2288         (get_jit_program_space_data): Update.
2289         (jit_program_space_data_cleanup): Remove.
2290         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2291         Update.
2292         (struct jit_program_space_data): Add initializers.
2293
2294 2019-07-10  Tom Tromey  <tromey@adacore.com>
2295
2296         * solib-darwin.c (struct darwin_info): Add initializers.
2297         (solib_darwin_pspace_data): Change type.
2298         (darwin_pspace_data_cleanup): Remove.
2299         (get_darwin_info, _initialize_darwin_solib): Update.
2300
2301 2019-07-10  Tom Tromey  <tromey@adacore.com>
2302
2303         * remote-sim.c (struct sim_inferior_data): Add initializers,
2304         constructor, and destructor.
2305         (sim_inferior_data_key): Change type.  Move lower.
2306         (check_for_duplicate_sim_descriptor): Update.
2307         (get_sim_inferior_data): Use new.  Update.
2308         (~sim_inferior_data_cleanup): Rename from
2309         sim_inferior_data_cleanup.  Simplify.
2310         (gdbsim_close_inferior, simulator_command)
2311         (sim_command_completer, _initialize_remote_sim): Update.
2312         (next_pid, INITIAL_PID): Move earlier.
2313
2314 2019-07-10  Tom Tromey  <tromey@adacore.com>
2315
2316         * python/python-internal.h (create_thread_object): Return
2317         gdbpy_ref.
2318         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2319         * python/py-inferior.c (struct threadlist_entry): Add
2320         constructor.
2321         <thread_obj>: Now a gdbpy_ref.
2322         (thread_to_thread_object): Update.
2323         (add_thread_object): Use new.
2324         (delete_thread_object): Use delete.
2325         (infpy_threads): Update.
2326         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2327         GIL.
2328
2329 2019-07-10  Tom Tromey  <tromey@adacore.com>
2330
2331         * valops.c (value_cast): Specialize error message for Ada.
2332
2333 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2334
2335         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2336
2337 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2338
2339         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2340         bpstat_should_step): Return bool, adjust comments.
2341         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2342         bpstat_should_step): Likewise.
2343
2344 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2345
2346         * features/Makefile: Use feature target descriptions for Arm.
2347         * features/arm/arm-core.c: Generate new file.
2348         * features/arm/arm-fpa.c: Likewise.
2349         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2350         * features/arm/arm-m-profile.c: Likewise.
2351         * features/arm/arm-vfpv2.c: Likewise.
2352         * features/arm/arm-vfpv3.c: Likewise.
2353         * features/arm/xscale-iwmmxt.c: Likewise.
2354         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2355
2356 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2357
2358         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2359         ptrace earlier.
2360
2361 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2362
2363         * features/aarch64-pauth.c: Regenerate.
2364
2365 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2366
2367         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2368         bool.
2369         (bpstat_what): Use false instead of 0.
2370
2371 2019-07-09  Pedro Alves  <palves@redhat.com>
2372
2373         * break-catch-throw.c (is_exception_catchpoint): New.
2374         * breakpoint.c (print_one_breakpoint_location): New parameter
2375         'raw_loc'.  Handle it.  Use
2376         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2377         looking at the breakpoint's type.
2378         (print_one_breakpoint): If handling "maint info breakpoints", also
2379         print locations of exception catchpoints.
2380         * breakpoint.h (is_exception_catchpoint): Declare.
2381
2382 2019-07-09  Pedro Alves  <palves@redhat.com>
2383
2384         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2385         "addr" field.
2386         (allocate_location_exception_catchpoint): New.
2387         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2388         (initialize_throw_catchpoint_ops): Install
2389         allocate_location_exception_catchpoint as allocate_location
2390         method.
2391         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2392         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2393         bp_loc_other.
2394         (breakpoint_address_is_meaningful): Delete.
2395         (bl_address_is_meaningful): New.
2396         (breakpoint_locations_match): Adjust comment.
2397         (bp_location_from_bp_type): New, factored out of...
2398         (bp_location::bp_location(breakpoint *)): ... this.
2399         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2400         factored out of...
2401         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2402         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2403         breakpoint_address_is_meaningful.
2404         (bp_locations_compare): Adjust comment.
2405         (update_global_location_list): Use bl_address_is_meaningful
2406         instead of breakpoint_address_is_meaningful.
2407         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2408         explicit.
2409         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2410         * python/py-breakpoint.c (bppy_get_location): No longer check
2411         whether location is null.
2412
2413 2019-07-09  Pedro Alves  <palves@redhat.com>
2414
2415         PR c++/15468
2416         * breakpoint.c (print_one_breakpoint_location): Remove
2417         single-location assert.
2418
2419 2019-07-09  Tom Tromey  <tom@tromey.com>
2420
2421         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2422         * configure: Rebuild.
2423         * configure.ac: Change common to gdbsupport.
2424         * gdbsupport: Rename from common.
2425         * acinclude.m4: Change common to gdbsupport.
2426         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2427         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2428         gdbsupport.
2429         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2430         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2431         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2432         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2433         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2434         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2435         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2436         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2437         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2438         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2439         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2440         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2441         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2442         coff-pe-read.c, command.h, compile/compile-c-support.c,
2443         compile/compile-c.h, compile/compile-cplus-symbols.c,
2444         compile/compile-cplus-types.c, compile/compile-cplus.h,
2445         compile/compile-loc2c.c, compile/compile.c, completer.c,
2446         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2447         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2448         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2449         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2450         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2451         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2452         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2453         features/aarch64-core.c, features/aarch64-fpu.c,
2454         features/aarch64-pauth.c, features/aarch64-sve.c,
2455         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2456         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2457         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2458         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2459         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2460         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2461         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2462         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2463         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2464         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2465         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2466         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2467         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2468         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2469         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2470         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2471         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2472         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2473         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2474         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2475         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2476         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2477         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2478         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2479         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2480         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2481         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2482         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2483         minsyms.c, mips-linux-tdep.c, namespace.h,
2484         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2485         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2486         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2487         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2488         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2489         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2490         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2491         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2492         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2493         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2494         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2495         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2496         procfs.c, producer.c, progspace.h, psymtab.h,
2497         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2498         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2499         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2500         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2501         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2502         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2503         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2504         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2505         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2506         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2507         target-memory.c, target.c, target.h, target/waitstatus.c,
2508         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2509         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2510         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2511         unittests/array-view-selftests.c,
2512         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2513         unittests/common-utils-selftests.c,
2514         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2515         unittests/format_pieces-selftests.c,
2516         unittests/function-view-selftests.c,
2517         unittests/lookup_name_info-selftests.c,
2518         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2519         unittests/mkdir-recursive-selftests.c,
2520         unittests/observable-selftests.c,
2521         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2522         unittests/parse-connection-spec-selftests.c,
2523         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2524         unittests/scoped_fd-selftests.c,
2525         unittests/scoped_mmap-selftests.c,
2526         unittests/scoped_restore-selftests.c,
2527         unittests/string_view-selftests.c, unittests/style-selftests.c,
2528         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2529         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2530         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2531         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2532         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2533         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2534
2535 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2536
2537         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2538         bool value.
2539         (decode_digits_ordinary): Set explicit_line field in sal.
2540         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2541         symtab_and_line that was set on an explicit line number in
2542         assembler code.  Do always update the recorded symtab and line if
2543         we do skip the prologue.
2544
2545 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * breakpoint.c (set_breakpoint_location_function): Remove
2548         explicit_loc parameter.
2549         (momentary_breakpoint_from_master): Update call to
2550         set_breakpoint_location_function.
2551         (add_location_to_breakpoint): Likewise.
2552
2553 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2554
2555         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2556         required features based on default bfd type when no specific bfd
2557         is present.
2558
2559 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2560
2561         * NEWS: Mention that GDB printf and eval commands can now print
2562         C-style and Ada-style convenience var strings without
2563         calling the inferior.
2564         * printcmd.c (printf_c_string): Locally print GDB internal var
2565         instead of transiting via the inferior.
2566         (printf_wide_c_string): Likewise.
2567
2568 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2569
2570         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2571
2572 2019-07-04  Tom Tromey  <tom@tromey.com>
2573
2574         PR tui/24724:
2575         * tui/tui-winsource.c (tui_clear_source_content): Update.
2576         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2577         (tui_update_breakpoint_info): Update.
2578         (tui_set_exec_info_content): Update.
2579         * tui/tui-source.c (tui_set_source_content_nil): Update.
2580         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2581         has_break.
2582         * tui/tui-data.h (enum tui_bp_flag): New.
2583         (tui_bp_flags): New enum flags type.
2584         (struct tui_source_element) <break_mode>: Change type.  Rename
2585         from has_break.
2586         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2587         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2588         constants.
2589         * tui/tui-winsource.h: Fix comment.
2590
2591 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2592
2593         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2594         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2595         (store_fpregs_to_thread)
2596         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2597         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2598         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2599         (IWMMXT_REGS_SIZE): Add define.
2600         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2601         (fetch_vfp_regs, store_vfp_regs)
2602         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2603         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2604
2605 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2606
2607         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2608         defines.
2609         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2610         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2611         (ARM_INT_REGISTER_SIZE): ...to this.
2612         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2613         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2614         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2615         (arm_linux_collect_gregset, supply_nwfpe_register)
2616         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2617         defines.
2618         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2619         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2620         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2621         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2622         (arm_return_in_memory, arm_store_return_value)
2623         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2624         (arm_record_ld_st_multiple): Likewise.
2625         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2626         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2627
2628 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2629
2630         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2631         AARCH64_DISPLACED_MODIFIED_INSNS.
2632         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2633         (aarch64_displaced_step_copy_insn): Likewise.
2634         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2635         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2636         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2637         ARM_DISPLACED_MODIFIED_INSNS.
2638         * arm-tdep.c (arm_gdbarch_init): Likewise.
2639         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2640         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2641         (struct arm_displaced_step_closure): Use
2642         ARM_DISPLACED_MODIFIED_INSNS.
2643
2644 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2645
2646         * features/Makefile: Remove unused xml files.
2647         * features/aarch64.xml: Remove.
2648         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2649         * features/i386/amd64-avx-avx512.xml: Remove.
2650         * features/i386/amd64-avx-linux.xml: Remove.
2651         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2652         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2653         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2654         * features/i386/amd64-avx-mpx.xml: Remove.
2655         * features/i386/amd64-avx.xml: Remove.
2656         * features/i386/amd64-linux.xml: Remove.
2657         * features/i386/amd64-mpx-linux.xml: Remove.
2658         * features/i386/amd64-mpx.xml: Remove.
2659         * features/i386/amd64.xml: Remove.
2660         * features/i386/i386-avx-avx512-linux.xml: Remove.
2661         * features/i386/i386-avx-avx512.xml: Remove.
2662         * features/i386/i386-avx-linux.xml: Remove.
2663         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2664         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2665         * features/i386/i386-avx-mpx-linux.xml: Remove.
2666         * features/i386/i386-avx-mpx.xml: Remove.
2667         * features/i386/i386-avx.xml: Remove.
2668         * features/i386/i386-linux.xml: Remove.
2669         * features/i386/i386-mmx-linux.xml: Remove.
2670         * features/i386/i386-mmx.xml: Remove.
2671         * features/i386/i386-mpx-linux.xml: Remove.
2672         * features/i386/i386-mpx.xml: Remove.
2673         * features/i386/i386.xml: Remove.
2674         * features/i386/x32-avx-avx512-linux.xml: Remove.
2675         * features/i386/x32-avx-linux.xml: Remove.
2676         * features/i386/x32-linux.xml: Remove.
2677
2678 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2679
2680         * regformats/aarch64.dat: Remove.
2681         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2682         * regformats/i386/amd64-avx-linux.dat: Remove.
2683         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2684         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2685         * regformats/i386/amd64-linux.dat: Remove.
2686         * regformats/i386/amd64-mpx-linux.dat: Remove.
2687         * regformats/i386/amd64.dat: Remove.
2688         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2689         * regformats/i386/i386-avx-linux.dat: Remove.
2690         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2691         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2692         * regformats/i386/i386-linux.dat: Remove.
2693         * regformats/i386/i386-mmx-linux.dat: Remove.
2694         * regformats/i386/i386-mpx-linux.dat: Remove.
2695         * regformats/i386/i386.dat: Remove.
2696         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2697         * regformats/i386/x32-avx-linux.dat: Remove.
2698         * regformats/i386/x32-linux.dat: Remove.
2699
2700 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2701
2702         * aarch64-tdep.c: Remove xml self tests.
2703         * amd64-linux-tdep.c: Likewise.
2704         * amd64-tdep.c: Likewise.
2705         * i386-linux-tdep.c: Likewise.
2706         * i386-tdep.c: Likewise.
2707
2708 2019-07-03  Pedro Alves  <palves@redhat.com>
2709
2710         PR cli/24732
2711         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2712         (pipe_cmd_option_defs): New.
2713         (make_pipe_cmd_options_def_group): New.
2714         (pipe_command): Use gdb::option::process_options.
2715         (pipe_command_completer): New function.
2716         (_initialize_cli_cmds): Install completer for "pipe" command.
2717
2718 2019-07-03  Pedro Alves  <palves@redhat.com>
2719
2720         * cli/cli-option.c (union option_value) <string>: New field.
2721         (struct option_def_and_value): Add ctor, move ctor, dtor and
2722         use DISABLE_COPY_AND_ASSIGN.
2723         (option_def_and_value::clear_value): New.
2724         (parse_option, save_option_value_in_ctx, get_val_type_str)
2725         (add_setshow_cmds_for_options): Handle var_string.
2726         * cli-option.h (union option_def::var_address) <string>: New
2727         field.
2728         (struct string_option_def): New.
2729         * maint-test-options.c (struct test_options_opts): Add default
2730         ctor and use DISABLE_COPY_AND_ASSIGN.
2731         <string_opt>: New field.
2732         (test_options_opts::~test_options_opts): New.
2733         (test_options_opts::dump): Also dump "-string".
2734         (test_options_option_defs): Install "string.
2735
2736 2019-07-03  Pedro Alves  <palves@redhat.com>
2737
2738         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2739         option_value with a null enumeration.
2740         (complete_options): Save the option values in the context.
2741         (save_option_value_in_ctx): New, factored out from ...
2742         (process_options): ... here.
2743         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2744         of the function.
2745         * maint-test-options.c (test_options_opts::dump): New, factored
2746         out from ...
2747         (maintenance_test_options_command_mode): ... here.
2748         (maintenance_test_options_command_completion_result): Delete.
2749         (maintenance_test_options_command_completion_text): Update
2750         comment.
2751         (maintenance_show_test_options_completion_result): Change
2752         prototype.  Just print
2753         maintenance_test_options_command_completion_text.
2754         (save_completion_result): New.
2755         (maintenance_test_options_completer_mode): Pass options context to
2756         complete_options, and then save a dump.
2757         (_initialize_maint_test_options): Use add_cmd to install "maint
2758         show test-options-completion-result".
2759
2760 2019-07-03  Pedro Alves  <palves@redhat.com>
2761
2762         * NEWS (New commands): Mention "with" and "maint with".
2763         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2764         (with_command, with_command_completer): New.
2765         (pipe_command): Adjust to new repeat_previous
2766         interface.
2767         (_initialize_cli_cmds): Install the "with" command and its "w"
2768         alias.
2769         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2770         declarations.
2771         * cli/cli-setshow.c (parse_cli_var_uinteger)
2772         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2773         argument strings for all var_types.
2774         (get_setshow_command_value_string): New, factored out from ...
2775         (do_show_command): ... this.
2776         * cli/cli-setshow.h: Include <string>.
2777         (get_setshow_command_value_string): Declare.
2778         * command.h (repeat_previous): Now returns const char *.  Adjust
2779         comment.
2780         * maint.c: Include "cli/cli-cmds.h".
2781         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2782         (_initialize_maint_cmds): Register the "maintenance with" command.
2783         * top.c (repeat_previous): Move bits from pipe_command here:
2784         Return the saved command line, if any; error out if there's no
2785         command to relaunch.
2786
2787 2019-07-03  Pedro Alves  <palves@redhat.com>
2788
2789         * NEWS (New commands): Mention "maint set/show test-settings"
2790         instead of "maint test-settings".
2791         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2792         (maintenance_test_settings_set_list): Rename to ...
2793         (maintenance_set_test_settings_list): ... this.
2794         (maintenance_test_settings_show_list): Rename to  ...
2795         (maintenance_show_test_settings_list): ... this.
2796         (maintenance_test_settings_cmd): Delete.
2797         (maintenance_test_settings_set_cmd): ...
2798         (maintenance_set_test_settings_cmd): ... this.
2799         (maintenance_test_settings_show_cmd): ...
2800         (maintenance_show_test_settings_cmd): ... this.
2801         (maintenance_test_settings_show_value_cmd):
2802         (maintenance_show_test_settings_value_cmd): ... this.
2803         (_initialize_maint_test_settings): No longer install the "maint
2804         test-settings" prefix command.  Rename "maint test-settings set"
2805         to "maint set test-settings", and "maint test-settings show" to
2806         "maint show test-settings".  Adjust all subcommands.
2807
2808 2019-07-03  Pedro Alves  <palves@redhat.com>
2809
2810         * maint-test-settings.c: Fix file's intro comment.  Replace all
2811         references to "test-options" with references to "test-settings",
2812         in comments.
2813
2814 2019-07-03  Pedro Alves  <palves@redhat.com>
2815
2816         * maint-test-settings.c (maintenance_test_settings_xxx)
2817         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2818         New.
2819         (maintenance_test_settings_enums): Use them.
2820         (maintenance_test_settings_enum): Default to
2821         maintenance_test_settings_xxx.
2822         (_initialize_maint_test_settings): Initialize
2823         MAINTENANCE_TEST_SETTINGS_FILENAME.
2824
2825 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2826
2827         * breakpoint.h (remove_breakpoints_inf): Change return type to
2828         void, move function documentation here.
2829         * breakpoint.c (remove_breakpoints_inf): Change return type to
2830         void, move function documentation to header.
2831
2832 2019-07-02  Pedro Alves  <palves@redhat.com>
2833
2834         * NEWS (Completion improvements): Mention "info threads".
2835         * thread.c (struct info_threads_opts, info_threads_option_defs)
2836         (make_info_threads_options_def_group): New.
2837         (info_threads_command): Use gdb::option::process_options.
2838         (info_threads_command_completer): New.
2839         (_initialize_thread): Use gdb::option::build_help to build the
2840         help text for "info threads".
2841
2842 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2843
2844         * defs.h (generic_load): Move from here...
2845         * symfile.h (generic_load): ... to here.  Rename name parameter
2846         to args.
2847         * symfile.c (generic_load): Add comment.
2848
2849 2019-07-01  Tom Tromey  <tromey@adacore.com>
2850
2851         * dwarf2read.c
2852         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2853         declaration of without_params.  Fix formatting.
2854
2855 2019-07-01  Tom Tromey  <tromey@adacore.com>
2856
2857         * ada-exp.y (find_primitive_type): Update.
2858         * ada-lang.h (ada_lookup_symbol): Update.
2859         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2860         parameter.
2861         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2862
2863 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2864
2865         PR breakpoints/24541
2866         * gdbarch.c: Regenerate.
2867         * gdbarch.h: Regenerate.
2868         * gdbarch.sh: Add 'stap_adjust_register'.
2869         * i386-tdep.c: Include '<unordered_set>'.
2870         (i386_stap_adjust_register): New function.
2871         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2872         * stap-probe.c (stap_parse_register_operand): Call
2873         'gdbarch_stap_adjust_register'.
2874
2875 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2876
2877         PR python/24742
2878         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2879         * python/python.c (do_start_initialization): Use 'xmalloc'
2880         instead of 'PyMem_Malloc'.
2881
2882 2019-06-28  Tom Tromey  <tromey@adacore.com>
2883
2884         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2885         for Ada.
2886
2887 2019-06-27  Tom Tromey  <tromey@adacore.com>
2888
2889         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2890         objfile_key.
2891         (arm_find_mapping_symbol, arm_record_special_symbol)
2892         (_initialize_arm_tdep): Update.
2893         (arm_objfile_data_free): Remove.
2894
2895 2019-06-27  Tom Tromey  <tromey@adacore.com>
2896
2897         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2898         to cp_print_static_field.
2899
2900 2019-06-26  Tom Tromey  <tromey@adacore.com>
2901
2902         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2903         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2904         declare.
2905
2906 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2907
2908         * features/aarch64-core.c (create_feature_aarch64_core):
2909         Regenerate.
2910         * features/aarch64-core.xml: Add cpsr flags.
2911
2912 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2913
2914         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2915         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2916
2917 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2918
2919         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2920         field.
2921         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2922         use.
2923         (arm_record_special_symbol): Don't insert new symbol in sorted
2924         position, push it at the end.
2925
2926 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2927
2928         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2929         (arm_mapping_symbol_s): Remove.
2930         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2931         (arm_mapping_symbol_vec): New typedef.
2932         (struct arm_per_objfile): Add constructor.
2933         <section_maps>: Change type to
2934         std::unique_ptr<arm_mapping_symbol_vec[]>.
2935         (arm_compare_mapping_symbols): Remove.
2936         (arm_find_mapping_symbol): Adjust to section_maps type change.
2937         (arm_objfile_data_free): Call delete on arm_per_objfile.
2938         (arm_record_special_symbol): Adjust to section_maps type change.
2939         Allocate arm_per_objfile with new.
2940
2941 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2942
2943         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2944         with the command prefix.
2945
2946 2019-06-25  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2949         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2950
2951 2019-06-25  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2954         type.
2955         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2956         protected.
2957
2958 2019-06-25  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.c
2961         (tui_source_window_base::set_is_exec_point_at): Add check against
2962         LOA_ADDRESS.
2963
2964 2019-06-25  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-source.c (tui_set_source_content): Don't check before
2967         xfree.
2968         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2969
2970 2019-06-25  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-winsource.h (tui_update_source_window_as_is)
2973         (tui_alloc_source_buffer, tui_line_is_displayed)
2974         (tui_addr_is_displayed): Change type of win_info.
2975         * tui/tui-winsource.c (tui_update_source_window_as_is)
2976         (tui_clear_source_content, tui_show_source_line)
2977         (tui_show_source_content, tui_source_window_base::refill)
2978         (tui_source_window_base::set_is_exec_point_at)
2979         (tui_source_window_base::set_is_exec_point_at)
2980         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2981         (tui_alloc_source_buffer, tui_line_is_displayed)
2982         (tui_addr_is_displayed): Change type of win_info.  Update.
2983         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2984         (tui_source_window_base::do_make_visible_with_new_height):
2985         Update.
2986         * tui/tui-source.c (tui_set_source_content)
2987         (tui_set_source_content_nil)
2988         (tui_source_window::do_scroll_vertical): Update.
2989         * tui/tui-layout.c (show_layout): Update.
2990         * tui/tui-disasm.c (tui_set_disassem_content)
2991         (tui_disasm_window::do_scroll_vertical): Update.
2992         * tui/tui-data.h (tui_win_content): Remove.
2993         (struct tui_gen_win_info) <content, content_size>: Remove.
2994         (struct tui_source_element): Add initializers and destructor.
2995         (union tui_which_element, struct tui_win_element): Remove.
2996         (struct tui_source_window_base) <content>: New field.
2997         (struct tui_data_window): Remove destructor.
2998         (tui_alloc_content, tui_free_win_content)
2999         (tui_free_all_source_wins_content): Don't declare.
3000         * tui/tui-data.c (tui_initialize_static_data): Update.
3001         (init_content_element, tui_alloc_content): Remove.
3002         (~tui_gen_win_info): Update.
3003         (~tui_data_window, tui_free_all_source_wins_content)
3004         (tui_free_win_content, free_content, free_content_elements):
3005         Remove.
3006
3007 2019-06-25  Tom Tromey  <tom@tromey.com>
3008
3009         * tui/tui-winsource.h (tui_clear_source_content)
3010         (tui_erase_source_content, tui_show_source_content): Change type
3011         of win_info.
3012         * tui/tui-winsource.c (tui_clear_source_content)
3013         (tui_erase_source_content, tui_show_source_content): Change type
3014         of win_info.
3015         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3016         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3017         win_info.
3018         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3019         win_info.
3020         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3021
3022 2019-06-25  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-winsource.c (tui_clear_source_content)
3025         (tui_source_window_base::set_is_exec_point_at): Update.
3026         * tui/tui-source.c (tui_set_source_content_nil): Update.
3027         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3028         a bool.
3029         * tui/tui-data.c (init_content_element): Update.
3030
3031 2019-06-25  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3034         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3035         * tui/tui-layout.c (init_and_make_win): Update.
3036         * tui/tui.h (enum tui_win_type): Update.
3037         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3038         tui_win_is_auxillary.
3039         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3040         tui_win_is_auxillary.
3041
3042 2019-06-25  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3045         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3046         (tui_delete_data_content_windows, tui_display_all_data)
3047         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3048         Update.
3049         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3050         * tui/tui-regs.c (tui_last_regs_line_no)
3051         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3052         (tui_show_registers): Update.
3053         (tui_show_register_group): Return void.  Update.
3054         (tui_display_registers_from, tui_display_reg_element_at_line)
3055         (tui_display_registers_from_line, tui_check_register_values):
3056         Update.
3057         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3058         member.
3059         (struct tui_data_window) <regs_content>: Now a std::vector.
3060         <regs_content_count>: Remove.
3061         (tui_add_content_elements, tui_free_data_content): Don't declare.
3062         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3063         (init_content_element): Remove DATA_WIN case.  Add assert.
3064         (tui_add_content_elements): Remove.
3065         (tui_data_window): Update.
3066         (tui_free_data_content): Remove.
3067         (free_content_elements): Remove DATA_WIN case.
3068
3069 2019-06-25  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-data.c (tui_data_item_window): Update.
3072         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3073         * tui/tui-windata.c (tui_display_all_data)
3074         (tui_display_data_from_line): Update.
3075         (tui_check_data_values): Remove.
3076         * tui/tui-regs.c (tui_show_register_group)
3077         (tui_display_reg_element_at_line): Update.
3078         * tui/tui-hooks.c (tui_register_changed)
3079         (tui_refresh_frame_and_register_information): Call
3080         tui_check_register_values.
3081         * tui/tui-data.h (struct tui_data_window) <data_content,
3082         data_content_count, data_type>: Remove.
3083         (enum tui_data_type): Remove.
3084
3085         * tui/tui-data.c (tui_data_window::clear_detail)
3086         (~tui_data_window): Update.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3091         declare.
3092         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3093         Rename from tui_first_data_item_displayed.  Update.
3094         (tui_data_window::refresh_all)
3095         (tui_data_window::do_scroll_vertical): Update.
3096         * tui/tui-data.h (struct tui_data_window)
3097         <first_data_item_displayed>: Declare new method.
3098
3099 2019-06-25  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3102         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3103         contents...
3104         (tui_initialize_static_data): ...here.
3105
3106 2019-06-25  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3109         (tui_display_registers_from, tui_check_register_values): Update.
3110         (tui_display_register): Remove win_info parameter; update.
3111         (tui_get_register): Change type of parameters.
3112         * tui/tui-data.h (struct tui_data_element): Remove.
3113         (union tui_which_element) <data>: Remove.
3114         <data_window>: Change type.
3115         (struct tui_data_item_window): New.
3116         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3117         case.  Add assert.
3118         (~tui_data_item_window): New destructor.
3119         (free_content_elements): Remove DATA_ITEM_WIN case.
3120
3121 2019-06-25  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3124         Remove.
3125
3126 2019-06-25  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-data.h (struct tui_command_element): Remove.
3129         (union tui_which_element) <command>: Remove.
3130         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3131         assert.
3132         (free_content_elements): Remove CMD_WIN case.
3133
3134 2019-06-25  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-layout.c (tui_set_layout): Update.
3137         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3138         * tui/tui-data.c (layout_def): Update.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3143         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3144         (tui_source_window_base::set_new_height): Update.
3145         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3146         Update.
3147         (tui_set_locator_fullname, tui_set_locator_info)
3148         (tui_show_frame_info): Update.
3149         * tui/tui-source.c (tui_set_source_content)
3150         (tui_source_is_displayed): Update.
3151         * tui/tui-layout.c (show_source_disasm_command, show_data)
3152         (show_source_or_disasm_and_command): Update.
3153         * tui/tui-disasm.c (tui_set_disassem_content)
3154         (tui_get_begin_asm_address): Update.
3155         * tui/tui-data.h (struct tui_locator_element): Remove.
3156         (union tui_which_element) <locator>: Remove.
3157         (struct tui_locator_window): New.
3158         (tui_locator_win_info_ptr): Change return type.
3159         * tui/tui-data.c (_locator): Change type.
3160         (tui_locator_win_info_ptr): Change return type.
3161         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3162         (tui_alloc_content): Add assert.
3163
3164 2019-06-25  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-winsource.c
3167         (tui_exec_info_window::maybe_allocate_content): New method.
3168         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3169         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3170         (make_source_or_disasm_window): Add cast.
3171         * tui/tui-data.h (union tui_which_element) <simple_string>:
3172         Remove.
3173         (struct tui_source_info): New.
3174         (struct tui_source_window_base) <execution_info>: Change type.
3175         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3176         case, and add assert.
3177         (tui_alloc_content): Add assert.
3178
3179 2019-06-25  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3182         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3183         * tui/tui-data.c (tui_alloc_win_info): Remove.
3184
3185 2019-06-25  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3188         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3189         can_highlight.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3194         make_visible_with_new_height method.
3195         (tui_win_info::make_visible_with_new_height): New method.
3196         (tui_source_window_base::do_make_visible_with_new_height)
3197         (tui_data_window::do_make_visible_with_new_height)
3198         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3199         (make_visible_with_new_height): Remove.
3200         (tui_resize_all, tui_adjust_win_heights): Use
3201         make_visible_with_new_height method.
3202         * tui/tui-data.h (struct tui_win_info)
3203         <do_make_visible_with_new_height, make_visible_with_new_height>:
3204         New methods.
3205         (struct tui_source_window_base, struct tui_data_window)
3206         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3207         methods.
3208
3209 2019-06-25  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3212         method.
3213         (update_tab_width): Call update_tab_width method.
3214         * tui/tui-data.h (struct tui_win_info)
3215         (struct tui_source_window_base) <update_tab_width>: New methods.
3216
3217 2019-06-25  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3220         parameter.
3221         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3222         parameter.
3223         (tui_gen_win_info::make_visible): Update.
3224         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3225         parameter.
3226         * tui/tui-data.h (enum tui_box): New enum.
3227         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3228
3229 2019-06-25  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3232         init_and_make_win for EXEC_INFO_WIN.
3233         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3234         longer inline.
3235         (struct tui_win_info) <~tui_win_info>: Inline.
3236         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3237         Don't declare.
3238         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3239         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3240         Remove.
3241         (tui_initialize_static_data): Update.
3242         (~tui_gen_win_info): Handle more cleanup here.
3243         (~tui_source_window_base): Delete "execution_info".
3244         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3245
3246 2019-06-25  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-layout.c (make_command_window): Don't set
3249         can_highlight.
3250         (show_source_disasm_command): Call the reset method.
3251         (show_data): Don't set can_highlight.  Call the reset method.
3252         (tui_gen_win_info::reset): Rename from init_gen_win_info
3253         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3254         (show_source_or_disasm_and_command): Call the reset method.
3255         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3256         (struct tui_cmd_window): Set can_highlight.
3257
3258 2019-06-25  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3261         from make_visible.
3262         (tui_make_visible, tui_make_invisible): Rewrite.
3263         (tui_win_info::make_visible): Remove.
3264         (tui_source_window_base::make_visible): Update.
3265         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3266         method.  Moved from...
3267         (struct tui_win_info) <make_visible>: ...here.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-winsource.c
3272         (tui_source_window_base::do_scroll_horizontal): Remove direction
3273         parameter.
3274         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3275         direction parameter.
3276         * tui/tui-win.c (tui_win_info::forward_scroll)
3277         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3278         (tui_win_info::right_scroll): Update.
3279         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3280         direction parameter.
3281         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3282         direction parameter.
3283         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3284         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3285         Remove direction parameter.
3286         (struct tui_source_window_base, struct tui_source_window)
3287         (struct tui_disasm_window, struct tui_data_window)
3288         (struct tui_cmd_window): Update.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-winsource.h (tui_set_exec_info_content)
3293         (tui_show_exec_info_content, tui_erase_exec_info_content)
3294         (tui_clear_exec_info_content, tui_update_exec_info): Change
3295         argument to tui_source_window_base.
3296         * tui/tui-winsource.c (tui_set_exec_info_content)
3297         (tui_show_exec_info_content, tui_erase_exec_info_content)
3298         (tui_clear_exec_info_content, tui_update_exec_info): Change
3299         argument to tui_source_window_base.
3300
3301 2019-06-25  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3304         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3305
3306 2019-06-25  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3309         check.
3310
3311 2019-06-25  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3314         type to void.
3315         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3316         type to void.
3317         * tui/tui-source.c (tui_set_source_content): Update.
3318         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3319
3320 2019-06-25  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-win.c (window_name_completer, tui_set_focus)
3323         (tui_all_windows_info): Use name method.
3324         * tui/tui-data.h (struct tui_gen_win_info)
3325         (struct tui_source_window, struct tui_disasm_window)
3326         (struct tui_data_window, struct tui_cmd_window) <name>: New
3327         method.
3328         (tui_win_name): Don't declare.
3329         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3330         (tui_win_name): Remove.
3331
3332 2019-06-25  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui-winsource.h (tui_update_source_window)
3335         (tui_update_source_window_as_is): Change parameter type.
3336         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3337         to be a tui_source_window_base.
3338         (tui_update_source_window_as_is): Likewise.
3339         * tui/tui-win.c (make_visible_with_new_height): Update.
3340
3341 2019-06-25  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-winsource.c (tui_erase_source_content)
3344         (tui_show_source_content, tui_show_exec_info_content)
3345         (tui_erase_exec_info_content): Use refresh_window method.
3346         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3347         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3348         from tui_refresh_win.
3349         (tui_data_window::refresh_window): New method.
3350         (tui_win_info::refresh, tui_source_window_base::refresh)
3351         (tui_refresh_all): Use refresh_window method.
3352         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3353         method.
3354         * tui/tui-regs.c (tui_display_register): Call refresh_window
3355         method.
3356         * tui/tui-layout.c (show_source_disasm_command)
3357         (show_source_or_disasm_and_command): Call refresh_window method.
3358         * tui/tui-data.h (struct tui_gen_win_info)
3359         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3360         New method.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui.c (tui_rl_other_window, tui_enable)
3365         (tui_is_window_visible, tui_get_command_dimension): Update.
3366         * tui/tui-winsource.c (tui_update_source_window_as_is)
3367         (tui_clear_source_content, tui_erase_source_content)
3368         (tui_show_source_line, tui_source_window_base::refill)
3369         (tui_source_window_base::do_scroll_horizontal)
3370         (tui_source_window_base::set_is_exec_point_at)
3371         (tui_update_breakpoint_info, tui_set_exec_info_content)
3372         (tui_alloc_source_buffer, tui_line_is_displayed)
3373         (tui_addr_is_displayed): Update.
3374         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3375         (tui_check_and_display_highlight_if_needed)
3376         (tui_win_info::make_visible, tui_win_info::refresh)
3377         (tui_refresh_all): Update.
3378         * tui/tui-windata.c (tui_first_data_item_displayed)
3379         (tui_delete_data_content_windows, tui_erase_data_content)
3380         (tui_display_all_data, tui_data_window::refresh_all)
3381         (tui_check_data_values): Update.
3382         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3383         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3384         (tui_win_info::backward_scroll, tui_refresh_all_win)
3385         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3386         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3387         (tui_source_window_base::set_new_height)
3388         (tui_data_window::set_new_height)
3389         (make_invisible_and_set_new_height)
3390         (make_visible_with_new_height, new_height_ok)
3391         (parse_scrolling_args): Update.
3392         * tui/tui-stack.c (tui_show_frame_info): Update.
3393         * tui/tui-source.c (tui_set_source_content)
3394         (tui_set_source_content_nil, tui_source_is_displayed)
3395         (tui_source_window::do_scroll_vertical): Update.
3396         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3397         (tui_display_registers_from, tui_display_reg_element_at_line)
3398         (tui_check_register_values, tui_reg_command): Update.
3399         * tui/tui-layout.c (tui_default_win_height)
3400         (show_source_disasm_command, show_data, init_and_make_win)
3401         (show_source_or_disasm_and_command): Update.
3402         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3403         (tui_redisplay_readline, tui_mld_flush)
3404         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3405         (tui_getc): Update.
3406         * tui/tui-disasm.c (tui_set_disassem_content)
3407         (tui_disasm_window::do_scroll_vertical): Update.
3408         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3409         Now virtual.
3410         (struct tui_win_info): Derive from tui_gen_win_info.
3411         <~tui_win_info>: Mark as override.
3412         <generic>: Remove member.
3413         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3414         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3415         (~tui_data_window, ~tui_win_info)
3416         (tui_free_all_source_wins_content): Update.
3417         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-layout.c (init_and_make_win): Use new.
3422         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3423         destructor, initializers.
3424         (tui_alloc_generic_win_info): Don't declare.
3425         * tui/tui-data.c (_locator): Add argument to constructor.
3426         (source_win, disasm_win): New globals.
3427         (exec_info): Remove.
3428         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3429         Update.
3430         (tui_alloc_generic_win_info): Remove.
3431         (init_content_element): Use new.
3432         (tui_win_info::tui_win_info): Update.
3433         (free_content_elements) <case DATA_WIN>: Use delete.
3434
3435 2019-06-25  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3438         * tui/tui-windata.c (tui_first_data_item_displayed)
3439         (tui_delete_data_content_windows): Update.
3440         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3441         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3442         (tui_display_registers_from, tui_check_register_values): Update.
3443         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3444         pointer.
3445         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3446         window.
3447         (tui_free_data_content): Update.
3448         (free_content_elements) <case DATA_WIN>: Free the window.
3449
3450 2019-06-25  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3453         Update.
3454         * tui/tui-layout.c (make_command_window)
3455         (show_source_disasm_command, show_data, init_and_make_win)
3456         (show_source_or_disasm_and_command): Update.
3457         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3458         method.
3459         <can_highight, is_highlighted>: Now bool.
3460         (tui_set_win_highlight): Don't declare.
3461         * tui/tui-data.c (tui_set_win_highlight): Remove.
3462
3463 2019-06-25  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-wingeneral.c (make_visible): Remove check of window
3466         type.
3467
3468 2019-06-25  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-win.c (tui_win_info::max_height)
3471         (tui_cmd_window::max_height): New methods.
3472         (new_height_ok): Call max_height.
3473         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3474         <max_height>: New method.
3475
3476 2019-06-25  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-win.c (tui_source_window_base::set_new_height)
3479         (tui_data_window::set_new_height): New methods.
3480         (make_invisible_and_set_new_height): Call set_new_height method.
3481         * tui/tui-data.h (struct tui_win_info)
3482         (struct tui_source_window_base, struct tui_data_window)
3483         <set_new_height>: New method.
3484
3485 2019-06-25  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3488         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3489         tui_refresh_data_win.
3490         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3491         method.
3492         (tui_refresh_all_win): Call the refresh_all method.
3493         (tui_set_focus): Likewise.
3494         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3495         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3496         Likewise.
3497
3498 2019-06-25  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-winsource.h (tui_refill_source_window)
3501         (tui_set_is_exec_point_at): Don't declare.
3502         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3503         (tui_source_window_base::refill): Rename from
3504         tui_refill_source_window.
3505         (tui_source_window_base::do_scroll_horizontal): Update.
3506         (tui_source_window_base::set_is_exec_point_at): Rename from
3507         tui_set_is_exec_point_at.
3508         (tui_update_all_breakpoint_info): Update.
3509         * tui/tui-stack.c (tui_show_frame_info): Update.
3510         * tui/tui-layout.c (show_data): Add cast.
3511         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3512         * tui/tui-data.h (struct tui_source_window_base) <refill,
3513         set_is_exec_point_at>: New methods.
3514         (tui_source_windows, tui_add_to_source_windows): Update types.
3515         (tui_add_to_source_windows): Remove redundant declaration.
3516         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3517         (tui_source_windows): Change return type.
3518         (tui_clear_source_windows_detail): Update.
3519         (tui_add_to_source_windows): Change type of parameter.
3520         (tui_free_all_source_wins_content): Update.
3521
3522 2019-06-25  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-wingeneral.c (tui_win_info::refresh)
3525         (tui_source_window_base::refresh): New methods.
3526         (tui_refresh_all): Call the refresh method.
3527         * tui/tui-data.h (struct tui_win_info)
3528         (struct tui_source_window_base) <refresh>: New method.
3529
3530 2019-06-25  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui.h (tui_is_window_visible): Return bool.
3533         * tui/tui.c (tui_is_window_visible): Return bool.
3534         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3535         (tui_make_visible, tui_make_invisible)
3536         (tui_win_info::make_visible)
3537         (tui_source_window_base::make_visible, make_all_visible)
3538         (tui_make_all_visible, tui_make_all_invisible): Update.
3539         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3540         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3541         bool.
3542         (struct tui_win_info, struct tui_source_window_base)
3543         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3544         * tui/tui-data.c (tui_init_generic_part): Update.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3549         (tui_source_window_base::make_visible): New methods.
3550         (make_all_visible): Make method call.
3551         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3552         (struct tui_source_window_base, struct tui_cmd_window): Override
3553         make_visible.
3554         (tui_win_is_source_type): Don't declare.
3555         * tui/tui-data.c (tui_win_is_source_type): Remove.
3556
3557 2019-06-25  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3560         NULL check.
3561
3562 2019-06-25  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3565         Inline constructor.  Add initializers for members.
3566         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3567         constructors; now inline in class.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-regs.c (tui_show_registers): Update.
3572         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3573         bool.
3574         * tui/tui-data.c (tui_data_window::clear_detail)
3575         (tui_data_window): Update.
3576
3577 2019-06-25  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-windata.c (tui_display_all_data)
3580         (tui_display_data_from_line, tui_display_data_from)
3581         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3582         Update.
3583         * tui/tui-regs.c (tui_last_regs_line_no)
3584         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3585         (tui_show_registers, tui_show_register_group)
3586         (tui_display_registers_from, tui_display_reg_element_at_line)
3587         (tui_display_registers_from_line, tui_check_register_values)
3588         (tui_reg_next, tui_reg_prev): Update.
3589         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3590         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3591         tui_data_window.
3592         (struct tui_win_info) <detail>: Remove.  Add new fields from
3593         tui_data_info.
3594         (TUI_DATA_WIN): Add cast.
3595         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3596         (~tui_data_window): Simplify.
3597
3598 2019-06-25  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-layout.c (show_source_disasm_command)
3601         (show_source_or_disasm_and_command): Update.
3602         * tui/tui-io.c (update_cmdwin_start_line)
3603         (tui_redisplay_readline): Update.
3604         * tui/tui-data.h (struct tui_command_info): Remove.
3605         (struct tui_win_info) <detail>: Remove command_info member.
3606         (struct tui_data_window) <start_line>: New member, from
3607         tui_command_info.
3608         (TUI_CMD_WIN): Add casts.
3609
3610 2019-06-25  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-winsource.c (tui_update_source_window)
3613         (tui_refill_source_window)
3614         (tui_source_window_base::do_scroll_horizontal)
3615         (tui_update_breakpoint_info, tui_set_exec_info_content)
3616         (tui_show_exec_info_content, tui_erase_exec_info_content)
3617         (tui_clear_exec_info_content): Update.
3618         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3619         Update.
3620         * tui/tui-win.c (make_invisible_and_set_new_height)
3621         (make_visible_with_new_height): Update.
3622         * tui/tui-source.c (tui_set_source_content)
3623         (tui_show_symtab_source): Update.
3624         * tui/tui-layout.c (extract_display_start_addr)
3625         (show_source_disasm_command, show_data)
3626         (make_source_or_disasm_window)
3627         (show_source_or_disasm_and_command): Update.
3628         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3629         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3630         "gdbarch".
3631         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3632         to tui_source_window_base.
3633         (struct tui_win_info) <detail>: Remove source_info member.
3634         (struct tui_source_window_base) <has_locator>: Inline.
3635         Move contents from tui_source_info; rename has_locator member to
3636         m_has_locator.
3637         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3638         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3639         header file.
3640         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3641         Simplify.
3642         (tui_free_all_source_wins_content): Cast to
3643         tui_source_window_base.
3644
3645 2019-06-25  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-win.c (make_invisible_and_set_new_height)
3648         (make_visible_with_new_height): Call has_locator method.
3649         * tui/tui-layout.c (show_source_disasm_command, show_data)
3650         (show_source_or_disasm_and_command): Update for bool change.
3651         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3652         (tui_win_info) <has_locator>: New method.
3653         (struct tui_source_window_base) <has_locator>: New method.
3654         (tui_win_has_locator): Don't declare.
3655         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3656         from tui_win_has_locator.
3657         (tui_source_window_base): Use false, not FALSE.
3658
3659 2019-06-25  Tom Tromey  <tom@tromey.com>
3660
3661         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3662         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3663         clear_detail method directly.
3664         (tui_clear_win_detail): Remove.
3665
3666 2019-06-25  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3669         "this", not TUI_DISASM_WIN.
3670
3671 2019-06-25  Tom Tromey  <tom@tromey.com>
3672
3673         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3674         declare.
3675         * tui/tui-winsource.c
3676         (tui_source_window_base::do_scroll_horizontal): Rename from
3677         tui_horizontal_source_scroll.
3678         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3679         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3680         from tui_vertical_data_scroll.
3681         * tui/tui-win.h (tui_scroll): Don't declare.
3682         * tui/tui-win.c (tui_win_info::forward_scroll)
3683         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3684         (tui_win_info::right_scroll): Rename and update.
3685         (tui_scroll_forward_command, tui_scroll_backward_command)
3686         (tui_scroll_left_command, tui_scroll_right_command): Update.
3687         (tui_scroll): Remove.
3688         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3689         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3690         from tui_vertical_source_scroll.
3691         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3692         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3693         from tui_vertical_disassem_scroll.
3694         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3695         do_scroll_horizontal>: New methods.
3696         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3697         Likewise.
3698         (struct tui_source_window_base): Add do_scroll_horizontal.
3699         (struct tui_source_window, struct tui_disasm_window): Add
3700         do_scroll_vertical.
3701         (struct tui_data_window, struct tui_cmd_window): Add
3702         do_scroll_horizontal and do_scroll_vertical.
3703         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3704
3705 2019-06-25  Tom Tromey  <tom@tromey.com>
3706
3707         * tui/tui-data.h (struct tui_source_window_base): New struct.
3708         (struct tui_source_window): Derive from tui_source_window_base.
3709         (struct tui_disasm_window): New struct.
3710         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3711         from tui_source_window::clear_detail.
3712         (tui_source_window_base): Rename from tui_source_window.
3713         (~tui_source_window_base): Rename from ~tui_source_window.
3714         (tui_alloc_win_info): Create a tui_disasm_window.
3715
3716 2019-06-25  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-data.h (struct tui_source_window)
3719         (struct tui_data_window): Declare destructors.
3720         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3721         destructors.
3722         (tui_win_info): Simplify.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-winsource.c (tui_display_main)
3727         (tui_update_source_windows_with_addr)
3728         (tui_update_all_breakpoint_info): Update.
3729         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3730         (new_height_ok, parse_scrolling_args): Update.
3731         * tui/tui-stack.c (tui_show_frame_info): Update.
3732         * tui/tui-data.h (struct tui_list): Remove.
3733         (tui_source_windows): Return a reference to a std::vector.
3734         * tui/tui-data.c (source_windows): Now a std::vector.
3735         (tui_source_windows): Change return type.
3736         (tui_clear_source_windows): Rewrite.
3737         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3738         (tui_free_all_source_wins_content): Rewrite.
3739
3740 2019-06-25  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3743         (struct tui_data_window, struct tui_cmd_window): Declare
3744         clear_detail method.
3745         * tui/tui-data.c (tui_source_window::clear_detail)
3746         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3747         methods.
3748         (tui_clear_win_detail): Simplify.
3749
3750 2019-06-25  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-layout.c (make_source_window, make_disasm_window)
3753         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3754         Return the new window.
3755         (show_source_disasm_command, show_data)
3756         (show_source_or_disasm_and_command): Update.
3757
3758 2019-06-25  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3761         parameter.  Return the new window.
3762         (show_source_disasm_command): Update and remove NULL check.
3763         (show_source_or_disasm_and_command): Update.
3764
3765 2019-06-25  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3768
3769 2019-06-25  Tom Tromey  <tom@tromey.com>
3770
3771         * tui/tui-data.h (struct tui_win_info): Make constructor
3772         protected.  Make destructor virtual.  Add initializers.
3773         (tui_source_window, tui_data_window, tui_cmd_window): New
3774         classes.
3775         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3776         constructor.  Add "type" parameter.
3777         (tui_source_window, tui_data_window, tui_cmd_window): New
3778         constructors.
3779         (tui_alloc_win_info): Instantiate the appropriate subclass.
3780
3781 2019-06-25  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-win.c (tui_resize_all): Use delete.
3784         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3785         destructor.
3786         (tui_free_window): Don't declare.
3787         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3788         Update.
3789
3790 2019-06-25  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-data.h (struct tui_win_info): Add constructor.
3793         * tui/tui-data.c (tui_alloc_win_info): Use new.
3794         (tui_free_window): Use delete.
3795
3796 2019-06-22  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3799         declare.
3800         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3801
3802 2019-06-22  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3805         declare.
3806         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3807
3808 2019-06-22  Tom de Vries  <tdevries@suse.de>
3809
3810         * dwarf2read.c (create_addrmap_from_aranges)
3811         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3812         instead of '%zu'.
3813
3814 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3815
3816         * dwarf2read.h (dwarf2_section_info_def): Remove.
3817         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3818         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3819         std::vector<dwarf2_section_info>.
3820         (struct dwo_file) <~dwo_file>: Remove.
3821         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3822         types field.
3823         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3824         (dwarf2_read_debug_names): Likewise.
3825         (create_debug_types_hash_table): Change parameter type to
3826         array_view, adjust code accordingly.
3827         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3828         (partial_die_info::fixup): Likewise.
3829         (determine_prefix): Likewise.
3830         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3831
3832 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3833
3834         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3835         gdb_bfd_ref_ptr.
3836         <~dwo_file>: Remove call to gdb_bfd_unref.
3837         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3838         gdb_bfd_ref_ptr::get.
3839
3840 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3841
3842         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3843         type to htab_up.
3844         * dwarf2read.c (struct dwo_file): Initialize fields.
3845         <~dwo_file>: New.
3846         (free_dwo_file): Remove, move content to ~dwo_file.
3847         (struct dwo_file_deleter): Remove.
3848         (dwo_file_up>: Remove custom deleter.
3849         (free_dwo_files): Remove.
3850         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3851         dwo_files.
3852         (process_skeletonless_type_units): Call unique_ptr::get.
3853         (allocate_dwo_file_hash_table): Add deleter to created hash
3854         table.  Change return type to htab_up.
3855         (lookup_dwo_file_slot): Don't memset dwo_file, call
3856         unique_ptr::get.
3857         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3858         (create_dwo_unit_in_dwp_v2): Likewise.
3859         (open_and_init_dwo_file): Likewise.
3860         (free_dwo_file_from_slot): Remove.
3861
3862 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3863
3864         * dwarf2read.h (struct dwarf2_section_info) <readin,
3865         is_virtual>: Change type to bool.
3866         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3867         true instead of 1.
3868
3869 2019-06-19  Tom Tromey  <tom@tromey.com>
3870
3871         * tui/tui-data.h (tui_init_content_element): Don't declare.
3872
3873 2019-06-19  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-data.h (tui_init_win_info): Don't declare.
3876
3877 2019-06-19  Tom de Vries  <tdevries@suse.de>
3878
3879         * dwarf2read.h (abstract_to_concrete): Change type to
3880         std::unordered_map<sect_offset, std::vector<sect_offset>,
3881         gdb::hash_enum<sect_offset>>.
3882
3883 2019-06-19  Tom Tromey  <tromey@adacore.com>
3884
3885         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3886         EVAL_AVOID_SIDE_EFFECTS specially.
3887
3888 2019-06-19  Tom Tromey  <tromey@adacore.com>
3889
3890         * source-cache.c (highlighter): New global.
3891         (source_cache::get_source_lines): Create a highlighter on demand.
3892
3893 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3894
3895         * defs.h (deprecated_interactive_hook): Delete declaration.
3896         * interps.c (clear_interpreter_hooks): Remove use of
3897         deprecated_interactive_hook.
3898         * top.c (deprecated_interactive_hook): Delete definition.
3899         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3900
3901 2019-06-18  Tom de Vries  <tdevries@suse.de>
3902
3903         PR gdb/24515
3904         * dwarf2read.h (abstract_to_concrete): Change type from
3905         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3906         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3907         * dwarf2read.c (read_variable): Update.
3908         (dwarf2_fetch_die_loc_sect_off): Update.
3909
3910 2019-06-17  Tom de Vries  <tdevries@suse.de>
3911
3912         PR gdb/24617
3913         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3914         accessing parent[parent_len - 1].
3915
3916 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3917
3918         PR gdb/24364
3919         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3920         call dtrace_process_dof with NULL dof.
3921
3922 2019-06-16  Tom de Vries  <tdevries@suse.de>
3923
3924         PR gdb/24445
3925         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3926
3927 2019-06-16  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3930         (make_all_visible): Use address of member.
3931
3932 2019-06-16  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3935         (tui_free_window, free_content, free_content_elements): Remove
3936         unnecessary cast.
3937         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3938         cast.
3939         * tui/tui-regs.c (tui_show_register_group)
3940         (tui_display_registers_from, tui_display_reg_element_at_line):
3941         Remove unnecessary cast.
3942
3943 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3944
3945         * linux-nat.c (normal_mask): Delete.
3946         (_initialize_linux_nat): Don't initialise normal_mask.
3947
3948 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3949
3950         PR gdb/24445
3951         * dwarf-index-write.h (write_psymtabs_to_index): Add
3952         dwz_basename parameter.
3953         * dwarf-index-write.c (write_gdbindex): Move file writing to
3954         write_gdbindex_1.  Change return type void.
3955         (assert_file_size): Move up, remove filename parameter.
3956         (write_gdbindex_1): New function.
3957         (write_debug_names): Change return type to void, call
3958         assert_file_size.
3959         (struct index_wip_file): New struct.
3960         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3961         file logic to index_wip_file.  Write index for dwz file if
3962         needed.
3963         (save_gdb_index_command): Pass basename of dwz file, if present.
3964         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3965         build-id of dwz file, if present.
3966         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3967         (dwarf2_get_dwz_file): Likewise.
3968         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3969         (dwarf2_get_dwz_file): Likewise.
3970
3971 2019-06-16  Tom Tromey  <tom@tromey.com>
3972
3973         * coffread.c (process_coff_symbol): Use xstrdup.
3974         * value.c (create_internalvar): Use xstrdup.
3975
3976 2019-06-16  Tom Tromey  <tom@tromey.com>
3977
3978         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3979         * breakpoint.c (stopin_command, stopat_command)
3980         (until_break_command, decode_location_default): Remove unnecessary
3981         cast.
3982         * utils.c (subset_compare): Remove unnecessary cast.
3983         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3984         cast.
3985         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3986         cast.
3987         * infcmd.c (path_command): Remove unnecessary cast.
3988         * coffread.c (decode_type): Remove unnecessary cast.
3989         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3990         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3991         * tui/tui-stack.c (tui_show_locator_content)
3992         (tui_show_frame_info): Remove unnecessary cast.
3993         * tui/tui-win.c (tui_scroll_forward_command)
3994         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3995         (parse_scrolling_args): Remove unnecessary cast.
3996         * tui/tui-data.c (init_win_info, tui_del_window)
3997         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3998         (free_content_elements): Remove unnecessary cast.
3999         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4000         unnecessary cast.
4001         * tui/tui-source.c (tui_set_source_content)
4002         (tui_vertical_source_scroll): Remove unnecessary cast.
4003         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4004         cast.
4005         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4006         * tui/tui-regs.c (tui_display_registers_from)
4007         (tui_display_register): Remove unnecessary cast.
4008         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4009         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4010         (make_visible): Remove unnecessary cast.
4011         * tui/tui-winsource.c (tui_erase_source_content)
4012         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4013         unnecessary cast.
4014         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4015         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4016         * stabsread.c (read_type, read_array_type, read_range_type):
4017         Remove unnecessary cast.
4018         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4019         (parse_symbol, parse_type, upgrade_type, parse_external)
4020         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4021         unnecessary cast.
4022         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4023
4024 2019-06-16  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-data.c (tui_alloc_generic_win_info)
4027         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4028         checks.
4029
4030 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4031             Andrew Burgess  <andrew.burgess@embecosm.com>
4032
4033         * f-typeprint.c (f_print_type): Don't return early for not
4034         associated or not allocated types.
4035         (f_type_print_varspec_suffix): Add print_rank parameter and print
4036         ranks of array types in case they dangling.
4037         (f_type_print_base): Add print_rank parameter.
4038
4039 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4040
4041         * NEWS: Mention new MI commands.
4042         * break-catch-throw.c (enum exception_event_kind): Move to
4043         breakpoint.h.
4044         (print_mention_exception_catchpoint): Output text as a single
4045         message.
4046         (catch_exception_command_1): Rename to...
4047         (catch_exception_event): ...this, make non-static, update header
4048         command, and change some parameter types.
4049         (catch_catch_command): Update for changes to
4050         catch_exception_command_1.
4051         (catch_throw_command): Likewise.
4052         (catch_rethrow_command): Likewise.
4053         * breakpoint.c (enum exception_event_kind): Delete.
4054         * breakpoint.h (enum exception_event_kind): Moved here from
4055         break-catch-throw.c.
4056         (catch_exception_event): Declare.
4057         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4058         (mi_cmd_catch_throw): New function.
4059         (mi_cmd_catch_rethrow): New function.
4060         (mi_cmd_catch_catch): New function.
4061         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4062         'catch-catch' entries.
4063         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4064         (mi_cmd_catch_rethrow): Declare.
4065         (mi_cmd_catch_catch): Declare.
4066
4067 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4068
4069         * annotate.c (annotate_source_line): Change return type to void,
4070         update implementation to match.
4071         * annotate.h (annotate_source_line): Change return type to void,
4072         update header comment.
4073         * stack.c (print_frame_info): Don't change what frame information
4074         is printed based on whether annotations are on or not.
4075
4076 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4077
4078         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4079         (annotate_source): Make static.
4080         (annotate_source_line): Moved from source.c and renamed from
4081         identify_source_line.  Update the return type.
4082         * annotate.h (annotate_source): Delete declaration.
4083         (annotate_source_line): Declaration moved from source.h, and
4084         renamed from identify_source_line.  Return type updated.
4085         * source.c (identify_source_line): Moved to annotate.c and renamed
4086         to annotate_source_line.
4087         (info_line_command): Remove check of annotation_level.
4088         * source.h (identify_source_line): Move declaration to annotate.h
4089         and rename to annotate_source_line.
4090         * stack.c: Add 'annotate.h' include.
4091         (print_frame_info): Remove check of annotation_level before
4092         calling annotate_source_line.
4093
4094 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4095
4096         * source-cache.c (source_cache::get_plain_source_lines): Use
4097         open_source_file_with_line_charpos instead of just
4098         open_source_file, remove call to find_source_lines.
4099         (source_cache::get_source_lines): Likewise.
4100         * source.c (find_source_lines): Make static.
4101         (get_filename_and_charpos): Renamed into...
4102         (open_source_file_with_line_charpos): ..this along with changes to
4103         return a scoped_fd, and some other minor clean ups.
4104         (identify_source_line): Use open_source_file_with_line_charpos.
4105         (search_command_helper): Use open_source_file_with_line_charpos
4106         instead of just open_source_file, remove call to
4107         find_source_lines.
4108         * source.h (open_source_file_with_line_charpos): Declare new
4109         function.
4110         (find_source_lines): Delete declaration.
4111
4112 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * source.c (get_filename_and_charpos): Remove fullname
4115         parameter.
4116         (identify_source_line): Update call to get_filename_and_charpos.
4117
4118 2019-06-14  Tom Tromey  <tromey@adacore.com>
4119
4120         PR gdb/24502:
4121         * ui-style.h (skip_ansi_escape): Update comment.
4122         * ui-file.h (class no_terminal_escape_file): New class.
4123         * ui-file.c (no_terminal_escape_file::write)
4124         (no_terminal_escape_file::puts): New methods.
4125         * cli/cli-logging.c (handle_redirections): Use
4126         no_terminal_escape_file.
4127
4128 2019-06-14  Tom Tromey  <tromey@adacore.com>
4129
4130         * NEWS: Move convenience variable news above Python news.
4131
4132 2019-06-14  Tom Tromey  <tom@tromey.com>
4133
4134         * gnulib: Move directory to top-level.
4135         * configure.ac: Don't configure gnulib.
4136         * configure: Rebuild.
4137         * common/common-defs.h: Use new path to gnulib.
4138         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4139         (GNULIB_H): Remove.
4140         (INCGNU): Look in new gnulib location.
4141         (HFILES_NO_SRCDIR): Remove gnulib files.
4142         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4143         (generated_files): Remove GNULIB_H.
4144         ($(LIBGNU), all-lib): Remove targets.
4145         (distclean): Don't mention GNULIB_BUILDDIR.
4146         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4147
4148 2019-06-14  Tom Tromey  <tromey@adacore.com>
4149
4150         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4151         Warn if symbol file does not provide any symbols.
4152
4153 2019-06-14  Tom Tromey  <tromey@adacore.com>
4154
4155         * source.c (find_and_open_source): Respect basenames_may_differ.
4156
4157 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * annotate.c (annotate_breakpoints_invalid): Make use of
4160         scoped_restore_terminal_state.
4161         (annotate_frames_invalid): Likewise.
4162
4163 2019-06-14  Tom Tromey  <tromey@adacore.com>
4164
4165         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4166         allow assignment to an internalvar.
4167
4168 2019-06-14  Tom Tromey  <tromey@adacore.com>
4169
4170         * ada-lex.l: Allow "_" in attribute names.
4171
4172 2019-06-14  Tom Tromey  <tromey@adacore.com>
4173
4174         PR gdb/24653:
4175         * regcache.c (registers_changed): Don't call alloca.
4176         * top.c (execute_command): Don't call alloca.
4177
4178 2019-06-13  Pedro Alves  <palves@redhat.com>
4179
4180         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4181         'expression'.  When parsing an expression, error out if there's
4182         junk after "unlimited".
4183         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4184         (do_set_command): Adjust calls to is_unlimited_literal.
4185
4186 2019-06-13  Pedro Alves  <palves@redhat.com>
4187
4188         * compile/compile.c (make_compile_options_def_group): Add braces
4189         around array_view initializer.
4190         * thread.c (make_thread_apply_all_options_def_group)
4191         (make_thread_apply_all_options_def_group): Likewise.
4192
4193 2019-06-13  Pedro Alves  <palves@redhat.com>
4194
4195         * NEWS (New commands): Mention "maint test-options
4196         require-delimiter", "maint test-options unknown-is-error", "maint
4197         test-options unknown-is-operand" and "maint show
4198         test-options-completion-result".
4199         (New command options, command completion): New section.
4200         (Completion improvements): New section.
4201         Mention that you can abbreviate "unlimited".
4202
4203 2019-06-13  Pedro Alves  <palves@redhat.com>
4204
4205         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4206         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4207         * unittests/cli-utils-selftests.c (test_parse_flags)
4208         (test_parse_flags_qcs): Delete.
4209         (test_cli_utils): Don't call deleted functions.
4210
4211 2019-06-13  Pedro Alves  <palves@redhat.com>
4212
4213         * thread.c: Include "cli/cli-option.h".
4214         (tp_array_compar_ascending): Global.
4215         (tp_array_compar): Delete function.
4216         (tp_array_compar_ascending, tp_array_compar_descending): New
4217         functions.
4218         (ascending_option_def, qcs_flag_option_def)
4219         (thr_qcs_flags_option_defs)
4220         (make_thread_apply_all_options_def_group)
4221         (make_thread_apply_options_def_group): New.
4222         (thread_apply_all_command): Use gdb::option::process_options.
4223         (thread_apply_command_completer)
4224         (thread_apply_all_command_completer): New.
4225         (thread_apply_command): Use gdb::option::process_options.
4226         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4227         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4228         to generate help text of "thread apply".  Adjust "taas"'s help.
4229         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4230         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4231
4232 2019-06-13  Pedro Alves  <palves@redhat.com>
4233
4234         * thread.c (thread_apply_command): Check for invalid TID with
4235         isdigit instead of !isalpha.
4236
4237 2019-06-13  Pedro Alves  <palves@redhat.com>
4238
4239         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4240         (validate_flags_qcs): New.
4241         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4242         (validate_flags_qcs): Declare.
4243         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4244         (make_frame_apply_options_def_group): New.
4245         (frame_apply_command_count): Process options with
4246         gdb::option::process_options.
4247         (frame_apply_completer): New.
4248         (frame_apply_level_completer, frame_apply_all_completer)
4249         (frame_apply_completer): New.
4250         (_initialize_stack): Update help of "frame apply", "frame apply
4251         level", "frame apply all" and "faas" to mention supported options
4252         and install command completers.
4253         * stack.h (frame_apply_all_completer): Declare.
4254         * thread.c: Include "stack.h".
4255         (tfaas_command): Add "--".
4256         (_initialize_thread): Update help "tfaas" to mention supported
4257         options and install command completer.
4258
4259 2019-06-13  Pedro Alves  <palves@redhat.com>
4260
4261         * completer.c (complete_nested_command_line): New.
4262         (gdb_completion_word_break_characters_throw): Add assertion.
4263         * completer.h (complete_nested_command_line): Declare.
4264
4265 2019-06-13  Pedro Alves  <palves@redhat.com>
4266
4267         * stack.c (parse_backtrace_qualifiers): New.
4268         (backtrace_command): Use it.
4269         (backtrace_command_completer): Complete on qualifiers.
4270
4271 2019-06-13  Pedro Alves  <palves@redhat.com>
4272
4273         * frame.c: Include "cli/cli-option.h.
4274         (user_set_backtrace_options): New.
4275         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4276         Delete.
4277         (get_prev_frame): Adjust.
4278         (boolean_option_def, uinteger_option_def)
4279         (set_backtrace_option_defs): New.
4280         (_initialize_frame): Adjust and use
4281         gdb::option::add_setshow_cmds_for_options to install "set
4282         backtrace past-main" and "set backtrace past-entry".
4283         * frame.h: Include "cli/cli-option.h".
4284         (struct frame_print_options): Forward declare.
4285         (print_frame_arguments_all, print_frame_arguments_scalars)
4286         (print_frame_arguments_none): Declare.
4287         (print_entry_values): Delete declaration.
4288         (struct frame_print_options, user_frame_print_options): New.
4289         (struct set_backtrace_options): New.
4290         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4291         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4292         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4293         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4294         (list_args_or_locals): Add frame_print_options parameter.
4295         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4296         * python/py-framefilter.c (enumerate_args): Pass down
4297         USER_FRAME_PRINT_OPTIONS.
4298         * stack.c: Include "cli/cli-option.h".
4299         (print_frame_arguments_all, print_frame_arguments_scalars)
4300         (print_frame_arguments_none): Declare.
4301         (print_raw_frame_arguments, print_entry_values): Delete.
4302         (user_frame_print_options): New.
4303         (boolean_option_def, enum_option_def, frame_print_option_defs):
4304         New.
4305         (struct backtrace_cmd_options): New.
4306         (bt_flag_option_def): New.
4307         (backtrace_command_option_defs): New.
4308         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4309         (print_frame_arg, read_frame_arg, print_frame_args)
4310         (print_frame_info, print_frame): Add frame_print_options parameter
4311         and use it.
4312         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4313         (backtrace_command_1): Add frame_print_options and
4314         backtrace_cmd_options parameters and use them.
4315         (make_backtrace_options_def_group): New.
4316         (backtrace_command): Process command options with
4317         gdb::option::process_options.
4318         (backtrace_command_completer): New.
4319         (_initialize_stack): Extend "backtrace"'s help to mention
4320         supported options.  Install completer for "backtrace".
4321         Install some settings commands with add_setshow_cmds_for_options.
4322
4323 2019-06-13  Pedro Alves  <palves@redhat.com>
4324
4325         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4326         and that "set/show print raw frame-arguments" are now deprecated.
4327
4328         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4329         command.
4330         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4331         * stack.c (_initialize_stack): Install "set/show print
4332         raw-frame-arguments", and deprecate "set/show print raw
4333         frame-arguments".
4334         * valprint.c (_initialize_valprint): Deprecate "set/show print
4335         raw".
4336
4337 2019-06-13  Pedro Alves  <palves@redhat.com>
4338
4339         * compile/compile.c (struct compile_options): New.
4340         (compile_flag_option_def, compile_command_option_defs)
4341         (make_compile_options_def_group): New.
4342         (compile_file_command): Handle options with
4343         gdb::option::process_options.
4344         (compile_file_command_completer): New function.
4345         (compile_code_command): Handle options with
4346         gdb::option::process_options.
4347         (compile_code_command_completer): New function.
4348         (_initialize_compiler): Install completers for "compile code" and
4349         "compile file".  Mention available options in "compile code" and
4350         "compile code"'s help.
4351         * completer.c (advance_to_completion_word): New, factored out from
4352         ...
4353         (advance_to_expression_complete_word_point): ... this.
4354         (advance_to_filename_complete_word_point): New.
4355         * completer.h (advance_to_filename_complete_word_point): New
4356         declaration.
4357
4358 2019-06-13  Pedro Alves  <palves@redhat.com>
4359
4360         * compile/compile.c: Include "cli/cli-option.h".
4361         (compile_print_value): Scope data pointer is now a
4362         value_print_options pointer; adjust.
4363         (compile_print_command): Process options.  Scope data pointer is
4364         now a value_print_options pointer; adjust.
4365         (_initialize_compile): Update "compile print"'s help to include
4366         supported options.  Install a completer for "compile print".
4367         * cp-valprint.c (show_vtblprint, show_objectprint)
4368         (show_static_field_print): Delete.
4369         (_initialize_cp_valprint): Don't install "set print
4370         static-members", "set print vtbl", "set print object" here.
4371         * printcmd.c: Include "cli/cli-option.h" and
4372         "common/gdb_optional.h".
4373         (print_command_parse_format): Rework to fill in a
4374         value_print_options instead of a format_data.
4375         (print_value): Change parameter type from format_data pointer to
4376         value_print_options reference.  Adjust.
4377         (print_command_1): Process options.  Adjust to pass down a
4378         value_print_options.
4379         (print_command_completer): New.
4380         (_initialize_printcmd): Install print_command_completer as
4381         handle_brkchars completer for the "print" command.  Update
4382         "print"'s help to include supported options.
4383         * valprint.c: Include "cli/cli-option.h".
4384         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4385         here from cp-valprint.c.
4386         (boolean_option_def, uinteger_option_def)
4387         (value_print_option_defs, make_value_print_options_def_group):
4388         New.  Use gdb::option::add_setshow_cmds_for_options to install
4389         "set print elements", "set print null-stop", "set print repeats",
4390         "set print pretty", "set print union", "set print array", "set
4391         print address", "set print symbol", "set print array-indexes".
4392         * valprint.h: Include <string> and "cli/cli-option.h".
4393         (make_value_print_options_def_group): Declare.
4394         (print_value): Change parameter type from format_data pointer to
4395         value_print_options reference.
4396         (print_command_completer): Declare.
4397
4398 2019-06-13  Pedro Alves  <palves@redhat.com>
4399
4400         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4401         (COMMON_SFILES): Add maint-test-settings.c.
4402         * cli/cli-decode.c (boolean_enums): New global, factored out from
4403         ...
4404         (add_setshow_boolean_cmd): ... here.
4405         * cli/cli-decode.h (boolean_enums): Declare.
4406         * cli/cli-option.c: New file.
4407         * cli/cli-option.h: New file.
4408         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4409         factored out from ...
4410         (parse_cli_boolean_value(const char *)): ... this.
4411         (is_unlimited_literal): Change parameter type to pointer to
4412         pointer.  Adjust and advance ARG pointer.
4413         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4414         (parse_cli_var_enum): New, factored out from ...
4415         (do_set_command): ... this.  Adjust.
4416         * cli/cli-setshow.h (parse_cli_boolean_value)
4417         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4418         (parse_cli_var_enum): Declare.
4419         * cli/cli-utils.c: Include "cli/cli-option.h".
4420         (get_ulongest): New.
4421         * cli/cli-utils.h (get_ulongest): Declare.
4422         (check_for_argument): New overloads.
4423         * maint-test-options.c: New file.
4424
4425 2019-06-13  Pedro Alves  <palves@redhat.com>
4426
4427         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4428         parse a range if "-" is at the end of the string.
4429
4430 2019-06-13  Pedro Alves  <palves@redhat.com>
4431
4432         * cli/cli-setshow.c (parse_auto_binary_operation)
4433         (parse_cli_boolean_value): Don't allow "o".
4434
4435 2019-06-13  Pedro Alves  <palves@redhat.com>
4436
4437         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4438         * NEWS: Mention maint test-settings KIND.
4439         * maint-test-settings.c: New file.
4440
4441 2019-06-13  Pedro Alves  <palves@redhat.com>
4442
4443         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4444         completer.
4445         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4446         "set" completers.
4447
4448 2019-06-13  Pedro Alves  <palves@redhat.com>
4449
4450         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4451         after item.
4452
4453 2019-06-13  Pedro Alves  <palves@redhat.com>
4454
4455         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4456
4457 2019-06-13  Pedro Alves <palves@redhat.com>
4458
4459         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4460         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4461         call.
4462         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4463         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4464         calls.
4465         (check_for_argument): Skip spaces after argument.
4466
4467 2019-06-13  Pedro Alves  <palves@redhat.com>
4468
4469         * thread.c (thread_apply_command): Adjust TID parsing.
4470         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4471         detected before end of string.
4472         (tid_is_in_list): Error out if LIST is invalid.
4473
4474 2019-06-13  Pedro Alves  <palves@redhat.com>
4475
4476         * completer.c (complete_line_internal_1): Rewind completion word
4477         point.
4478         (completion_tracker::advance_custom_word_point_by): Change
4479         parameter type to int.
4480         * completer.h (completion_tracker::advance_custom_word_point_by):
4481         Likewise.
4482
4483 2019-06-13  Pedro Alves  <palves@redhat.com>
4484
4485         * completer.c (advance_to_completion_word): Handle delimiters.
4486
4487 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4488
4489         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4490
4491 2019-06-11  Tom Tromey  <tom@tromey.com>
4492
4493         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4494         (xmalloc_failed): Move to alloc.c.
4495         * alloc.c: New file.
4496         * Makefile.in (COMMON_SFILES): Add alloc.c.
4497
4498 2019-06-11  Tom Tromey  <tom@tromey.com>
4499
4500         * nat/linux-waitpid.c: Don't include server.h.
4501         (linux_debug): Remove.
4502         (my_waitpid): Update.
4503
4504 2019-06-11  Tom Tromey  <tromey@adacore.com>
4505
4506         * infcall.c (_initialize_infcall): Remove trailing newline from
4507         help.
4508         * user-regs.c (_initialize_user_regs): Remove trailing newline
4509         from help.
4510         * typeprint.c (_initialize_typeprint): Remove trailing newline
4511         from help.
4512         * reverse.c (_initialize_reverse): Remove trailing newlines from
4513         help.
4514         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4515         from help.
4516         * language.c (add_set_language_command): Remove trailing newline
4517         from help.
4518         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4519         help.
4520         * disasm.c (_initialize_disasm): Remove trailing newline from
4521         help.
4522         * top.c (init_main): Remove trailing newline from help.
4523         * interps.c (_initialize_interpreter): Remove trailing newline
4524         from help.
4525         * btrace.c (_initialize_btrace): Remove trailing newlines from
4526         help.
4527         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4528         from help.
4529         * python/python.c (_initialize_python): Remove trailing newline
4530         from help.
4531         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4532         help.
4533         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4534         from help.  Reformat some text.
4535         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4536         from help.
4537         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4538         newline from help.
4539
4540 2019-06-11  Tom Tromey  <tromey@adacore.com>
4541
4542         * darwin-nat.c (darwin_decode_exception_message)
4543         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4544
4545 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * valops.c (value_slice): Check for not allocated or not
4548         associated values.
4549
4550 2019-06-10  Tom de Vries  <tdevries@suse.de>
4551
4552         PR gdb/24618
4553         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4554         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4555         invalid.
4556
4557 2019-06-10  Tom de Vries  <tdevries@suse.de>
4558
4559         PR gdb/24611
4560         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4561         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4562
4563 2019-06-10  Tom de Vries  <tdevries@suse.de>
4564
4565         PR symtab/24545
4566         * symtab.c (struct demangled_name_entry): Add language field.
4567         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4568         static minimal symbol".  Set and use language field.
4569
4570 2019-06-10  Tom Tromey  <tromey@adacore.com>
4571
4572         * ada-lang.c (_initialize_ada_language): Update help text.
4573
4574 2019-06-10  Tom Tromey  <tromey@adacore.com>
4575
4576         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4577         with a newline.
4578         * guile/guile.c (handle_boot_error): Don't end warning with a
4579         newline.
4580         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4581         warning with a newline.
4582         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4583         newline.
4584         (s12z_frame_cache): Likewise.
4585         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4586         a newline.
4587         * solib-svr4.c (disable_probes_interface): Don't end warning with
4588         a newline.
4589         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4590         newline.
4591         * python/python.c (do_finish_initialization): Don't end warning
4592         with a newline.
4593
4594 2019-06-10  Tom Tromey  <tom@tromey.com>
4595
4596         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4597         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4598         gdbpy_enter.
4599
4600 2019-06-10  Tom Tromey  <tromey@adacore.com>
4601
4602         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4603         data.
4604         (elf_new_init): Don't call stabsread_new_init.
4605         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4606         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4607         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4608
4609 2019-06-10  Tom de Vries  <tdevries@suse.de>
4610
4611         PR symtab/16264
4612         PR symtab/24517
4613         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4614
4615 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4616
4617         * source.c (find_and_open_source): Also rewrite relative file
4618         names.
4619
4620 2019-04-26  Amos Bird  <amosbird@gmail.com>
4621
4622         * annotate.c (annotate_thread_exited): Add "thread-exited"
4623         annotation.
4624
4625 2019-06-06  Tom Tromey  <tromey@adacore.com>
4626
4627         * maint.h (class scoped_command_stats): Use
4628         DISABLE_COPY_AND_ASSIGN.
4629         <print_time>: New method.
4630         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4631         print_time.
4632         (scoped_command_stats::print_time): New method.
4633
4634 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4637         instructions of lengths 6 or 8 bytes.
4638
4639 2019-06-04  Pedro Alves  <palves@redhat.com>
4640
4641         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4642
4643         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4644         * breakpoint.c (condition_completer): Likewise.
4645         * cli/cli-dump.c (scan_expression): Likewise.
4646         * common/filestuff.c (mkdir_recursive): Likewise.
4647         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4648         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4649         (gdb_abspath): Likewise.
4650         * compile/compile-cplus-types.c
4651         (compile_cplus_instance::decl_name): Likewise.
4652         * completer.c (complete_explicit_location):
4653         (signal_completer, reg_or_group_completer_1): Likewise.
4654         * cp-support.c (cp_remove_params_if_any): Likewise.
4655         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4656         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4657         * infcmd.c (strip_bg_char): Likewise.
4658         * linespec.c (copy_token_string): Likewise.
4659         * mi/mi-main.c (output_cores): Likewise.
4660         * psymtab.c (psymtab_search_name):
4661         * symfile.c (test_set_ext_lang_command): Likewise.
4662         * target.c (target_fileio_read_stralloc): Likewise.
4663         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4664         * value.c (complete_internalvar): Likewise.
4665
4666 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4667
4668         Add objfile property to gdb.Type.
4669         * NEWS: Mention Python API addition.
4670         * python/py-type.c (typy_get_objfile): New method.
4671
4672 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4673
4674         * NEWS: Mention the new set|show style [title|highlight].
4675         Mention changes to "show style", "help" and "apropos".
4676
4677 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4678
4679         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4680         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4681         instead of print_help_for_command.
4682         (print_doc_of_command): New function.
4683         (help_list): Add 'apropos -v word' suggestion.
4684         (print_help_for_command): Style the command name using title style.
4685         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4686         (_initialize_cli_cmds): Describe -v in apropos_command help.
4687
4688 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4689
4690         * cli/cli-style.h (cli_style_option): Add name in constructor,
4691         add m_name class member, add constructor with intensity,
4692         add name class function.
4693         (cli_style_option::add_setshow_commands): Remove name argument.
4694         (highlight_style, title_style): New styles.
4695         * cli/cli-style.c (do_show): New function that shows a style
4696         characteristic styling the style name with itself.
4697         (set_style_name): New function.
4698         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4699         Update all callers according to the changes in cli/cli-style.h.
4700         * utils.h (fputs_highlighted): New function.
4701         * utils.c (fputs_highlighted): Likewise.
4702
4703 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4704
4705         * NEWS: Mention new pipe command and new convenience variables.
4706
4707 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4708
4709         * cli/cli-cmds.c (pipe_command): New function.
4710         (_initialize_cli_cmds): Call add_com for pipe_command.
4711         Define | as an alias for pipe.
4712         (exit_status_set_internal_vars): New function.
4713         (shell_escape): Call exit_status_set_internal_vars.
4714         cli/cli-decode.c (find_command_name_length): Recognize | as
4715         a single character command.
4716
4717 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4718
4719         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4720         top.c (execute_command_to_ui_file): New function, mostly a copy
4721         of execute_command_to_string.
4722         (execute_command_to_string): Implement by calling
4723         execute_command_to_ui_file.
4724
4725 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4726
4727         * top.h (saved_command_line): Remove declaration.
4728         * top.c (previous_saved_command_line, previous_repeat_arguments):
4729         New variables.
4730         (saved_command_line): Make static, define together with other
4731         'repeat variables'.
4732         (dont_repeat): Clear repeat_arguments.
4733         (repeat_previous, get_saved_command_line, save_command_line):
4734         New functions.
4735         (gdb_init): Initialize saved_command_line
4736         and previous_saved_command_line.
4737         * main.c (captured_main_1): Remove saved_command_line initialization.
4738         * event-top.c (handle_line_of_input): Update to use
4739         the new 'repeat' related functions instead of direct access to
4740         saved_command_line.
4741         * command.h (repeat_previous, get_saved_command_line,
4742         save_command_line): New declarations.
4743         (dont_repeat): Add comment.
4744
4745 2019-05-30  Tom Tromey  <tromey@adacore.com>
4746
4747         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4748         Fix comment.
4749         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4750
4751 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4752
4753         PR cli/24587
4754         * completer.c (complete): Initialize variable word.
4755
4756 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4757
4758         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4759         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4760         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4761         'body' is NULL to the outter 'if', protecting the '!is_define'
4762         situation as well.
4763
4764 2019-05-29  Tom Tromey  <tromey@adacore.com>
4765
4766         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4767         (dwarf_unknown): New function.
4768         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4769         (dwarf_type_encoding_name): Use dwarf_unknown.
4770
4771 2019-05-29  Tom Tromey  <tromey@adacore.com>
4772
4773         PR c++/20020:
4774         * cp-valprint.c (cp_print_value_fields): Call
4775         cp_print_static_field inside "try".
4776
4777 2019-05-29  Tom Tromey  <tromey@adacore.com>
4778
4779         * inflow.c (struct terminal_info): Add default operator=.
4780         * configure: Rebuild.
4781         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4782         -Wdeprecated-copy-dtor, -Wredundant-move.
4783
4784 2019-05-29  Tom Tromey  <tromey@adacore.com>
4785
4786         * NEWS: Add entry.
4787         * infcmd.c (print_return_value_1): Handle finish_print
4788         option.
4789         (show_print_finish): New function.
4790         (_initialize_infcmd): Add "set/show print finish" commands.
4791         * valprint.c (user_print_options): Initialize new member.
4792         * valprint.h (struct value_print_options) <finish_print>: New
4793         member.
4794
4795 2019-05-28  Tom Tromey  <tromey@adacore.com>
4796
4797         * ada-lang.c (ada_remove_Xbn_suffix)
4798         (find_old_style_renaming_symbol)
4799         (parse_old_style_renaming): Remove.
4800         (ada_find_renaming_symbol): Don't call
4801         find_old_style_renaming_symbol.
4802         (ada_is_renaming_symbol): Rename from
4803         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4804         bool.  Now static.
4805         (ada_read_var_value): Update and simplify.
4806         * ada-exp.y (write_var_or_type): Remove old code.
4807
4808 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4809
4810         * event-top.c: Remove include comment.
4811         * inflow.c (class scoped_ignore_sigttou): Move from here...
4812         * inflow.h (class scoped_ignore_sigttou): ...to here.
4813         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4814         * top.c:  Remove include comment.
4815
4816 2019-05-27  Tom Tromey  <tom@tromey.com>
4817
4818         * NEWS: Fix typo.
4819
4820 2019-05-22  Tom Tromey  <tromey@adacore.com>
4821
4822         * target.c (target_follow_exec): Constify parameter.
4823         * target-delegates.c: Rebuild.
4824         * remote.c (remote_target::follow_exec): Constify parameter.
4825         * infrun.c (follow_exec): Constify parameter.
4826         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4827         (target_follow_exec): Likewise.
4828
4829 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4830
4831         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4832         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4833
4834 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4835
4836         * NEWS: Add debugredirect and testsuite sections.
4837
4838 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4839
4840         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4841         target descriptions using exclusively floating point register name
4842         aliases.
4843
4844 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         PR gdb/18644:
4847         * f-lang.c (build_fortran_types): Handle the case where
4848         gdbarch_floatformat_for_type returns a nullptr.
4849
4850 2019-05-21  Tom de Vries  <tdevries@suse.de>
4851
4852         PR cli/24587
4853         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4854
4855 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4856
4857         PR gdb/18644:
4858         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4859         16-byte floats.
4860         * i386-tdep.c (i386_floatformat_for_type): Use
4861         floatformats_ia64_quad for the 16-byte floating point component
4862         within a fortran 32-byte complex number.
4863
4864 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4867         delete default constructor.
4868         (find_partial_die): Update to return const struct.
4869         (partial_die_parent_scope): Move variable declaration into scope
4870         of its use and change its type to auto.
4871         (guess_partial_die_structure_name): Likewise.
4872         (partial_die_info::fixup): Likewise.
4873
4874 2019-05-17  Tom Tromey  <tromey@adacore.com>
4875
4876         * source.c (find_and_open_source): Remove cast.
4877
4878 2019-05-17  Tom Tromey  <tromey@adacore.com>
4879
4880         * annotate.c (annotate_source): Make "filename" const.
4881         * annotate.h (annotate_source): Use const.
4882
4883 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4884
4885         * disasm.c (set_disassembler_options): Send errors to stderr.
4886
4887 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4888
4889         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4890         (cli_interp_base::set_logging): Check debug_redirect.
4891         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4892         * cli/cli-logging.c (debug_redirect): Add static variable.
4893         (pop_output_files): Add default param.
4894         (handle_redirections): Print debug setting.
4895         (show_logging_command): Likewise.
4896         (_initialize_cli_logging): Add debugredirect command.
4897         * interps.c (current_interp_set_logging): Add debug_redirect
4898         parameter.
4899         * interps.h (set_logging): Add debug_redirect parameter.
4900         (current_interp_set_logging): Likewise.
4901         * mi/mi-common.h: Likewise.
4902         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4903
4904 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4905             Tom Tromey  <tromey@adacore.com>
4906
4907         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4908         directly.
4909         * cli/cli-interp.h (make_logging_output): Remove declaration.
4910         * cli/cli-logging.c (make_logging_output): Remove function.
4911         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4912         directly.
4913         * ui-file.c (tee_file::tee_file): Remove bools.
4914         (tee_file::~tee_file): Remove deletes.
4915         * ui-file.h (tee_file): Remove bools.
4916
4917 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4918
4919         * mi/mi-cmds.h (mi_cmd_complete): New function.
4920         * mi/mi-main.c (mi_cmd_complete): Likewise.
4921         * mi/mi-cmds.c: Define new MI command -complete.
4922         * NEWS: Mention new -complete command.
4923
4924 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4925
4926         * completer.h (complete): New function.
4927         * completer.c (complete): Likewise.
4928         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4929         function defined in completer.h.
4930
4931 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4932
4933         * MAINTAINERS (Write After Approval): Add myself.
4934
4935 2019-05-17  Tom de Vries  <tdevries@suse.de>
4936
4937         PR gdb/24094
4938         * dwarf2read.c (struct cu_partial_die_info): New struct.
4939         (find_partial_die): Return cu_partial_die_info.
4940         (partial_die_parent_scope, guess_partial_die_structure_name)
4941         (partial_die_info::fixup): Handle new return type of find_partial_die.
4942
4943 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4944
4945         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4946         "std::string", simplifying the algorithm.
4947
4948 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4949
4950         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4951         (stap_static_probe_ops::get_probes): Likewise.
4952
4953 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4954
4955         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4956         '-')" and "else if".
4957         (stap_parse_single_operand): Join checks for
4958         "gdbarch_stap_parse_special_token_p" and
4959         "gdbarch_stap_parse_special_token" in the same "if" statement.
4960         Invert check when verifying for operation on register
4961         displacement.
4962
4963 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4964
4965         * stap-probe.c (stap_get_opcode): Update comment.
4966         (stap_get_expected_argument_type): Likewise.
4967         (handle_stap_probe): Likewise.
4968
4969 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4970
4971         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4972         return type to 'bool'.  Adjust comment.  Use 'bool' when
4973         appropriate.
4974         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4975         * stap-probe.c (stap_parse_argument_1): Likewise.
4976         (stap_is_operator): Likewise.
4977         (stap_is_generic_prefix): Likewise.
4978         (stap_is_register_prefix): Likewise.
4979         (stap_is_register_indirection_prefix): Likewise.
4980         (stap_is_integer_prefix): Likewise.
4981         (stap_generic_check_suffix): Likewise.
4982         (stap_check_integer_suffix): Likewise.
4983         (stap_check_register_suffix): Likewise.
4984         (stap_check_register_indirection_suffix): Likewise.
4985         (stap_parse_register_operand): Likewise.
4986         (stap_parse_single_operand): Likewise.
4987         (stap_parse_argument_1): Likewise.
4988         (stap_probe::get_argument_count): Likewise.
4989         (stap_is_operator): Likewise.
4990
4991 2019-05-16  Tom Tromey  <tromey@adacore.com>
4992
4993         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4994         keyword to foreach.
4995
4996 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4997
4998         * linux-thread-db.c (try_thread_db_load_1): Change return type
4999         to bool.
5000         (try_thread_db_load): Likewise.
5001         (try_thread_db_load_from_pdir_1): Likewise.
5002         (try_thread_db_load_from_pdir): Likewise.
5003         (try_thread_db_load_from_sdir): Likewise.
5004         (try_thread_db_load_from_dir): Likewise.
5005         (thread_db_load_search): Likewise.
5006         (has_libpthread): Likewise.
5007         (thread_db_load): Likewise.
5008
5009 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5010
5011         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5012         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5013         NULL, and complain/return if that's the case.
5014
5015 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5016
5017         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5018         (advance, posn, abstract_read_memory): New functions.
5019         [struct mem_read_abstraction]: New struct.
5020         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5021
5022 2019-05-14  Tom Tromey  <tromey@adacore.com>
5023
5024         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5025         value is not lval_memory.
5026
5027 2019-05-14  Tom Tromey  <tromey@adacore.com>
5028
5029         * solib.c (info_sharedlibrary_command): Style the file name.
5030
5031 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5032
5033         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5034         (aarch64_vnv_type): Likewise.
5035         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5036         * common/tdesc.c: Likewise.
5037         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5038         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5039         * features/aarch64-fpu.xml: Add ieee half view.
5040         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5041         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5042         * gdbtypes.h (struct builtin_type): Likewise.
5043         (struct objfile_type): Likewise.
5044
5045 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5046
5047         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5048         typo.
5049         * location.h (string_to_event_location): Likewise.
5050
5051 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5052
5053         GDB 8.3 released.
5054
5055 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5056
5057         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5058         New variable declaration.
5059         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5060         New variable.
5061         (print_one_breakpoint): Use ui_out::test_flags and new global
5062         variable to compute use_fixed_output.
5063         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5064         Remove.
5065         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5066         (mi_multi_location_breakpoint_output_fixed): Remove.
5067         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5068         new variable.
5069         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5070         fix_multi_location_breakpoint_output flag if version >= 3.
5071         * ui-out.h (enum ui_out_flag)
5072         <fix_multi_location_breakpoint_output>: New enumerator.
5073
5074 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5075
5076         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5077
5078 2019-05-10  Tom Tromey  <tromey@adacore.com>
5079
5080         * ada-lang.c (catch_ada_completer): New function.
5081         (_initialize_ada_language): Use it.
5082
5083 2019-05-10  Tom Tromey  <tromey@adacore.com>
5084
5085         * thread.c (print_thread_info): Make "requested_threads" const.
5086         * gdbthread.h (print_thread_info): Make "requested_threads"
5087         const.
5088         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5089         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5090
5091 2019-05-08  Tom Tromey  <tom@tromey.com>
5092
5093         * gdbtypes.c (objfile_type_data): Change type.
5094         (objfile_type, _initialize_gdbtypes): Update.
5095
5096 2019-05-08  Tom Tromey  <tom@tromey.com>
5097
5098         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5099         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5100         (_initialize_dwarf2_frame): Update.
5101
5102 2019-05-08  Tom Tromey  <tom@tromey.com>
5103
5104         * objc-lang.c (objc_objfile_data): Change type.
5105         (find_methods): Update.
5106         (_initialize_objc_lang): Remove.
5107
5108 2019-05-08  Tom Tromey  <tom@tromey.com>
5109
5110         * stabsread.c (rs6000_builtin_type_data): Change type.
5111         (rs6000_builtin_type, _initialize_stabsread): Update.
5112
5113 2019-05-08  Tom Tromey  <tom@tromey.com>
5114
5115         * mips-tdep.c (mips_pdr_data): Remove.
5116         (_initialize_mips_tdep): Update.
5117
5118 2019-05-08  Tom Tromey  <tom@tromey.com>
5119
5120         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5121         (hppa_init_objfile_priv_data, read_unwind_info)
5122         (find_unwind_entry, _initialize_hppa_tdep): Update.
5123
5124 2019-05-08  Tom Tromey  <tom@tromey.com>
5125
5126         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5127         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5128         on obstack.
5129         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5130
5131 2019-05-08  Tom Tromey  <tom@tromey.com>
5132
5133         * mdebugread.c (basic_type_data): Change type.
5134         (basic_type, _initialize_mdebugread): Update.
5135
5136 2019-05-08  Tom Tromey  <tom@tromey.com>
5137
5138         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5139
5140 2019-05-08  Tom Tromey  <tom@tromey.com>
5141
5142         * nto-tdep.c (nto_inferior_data_reg): Change type.
5143         (nto_inferior_data): Update.
5144         (nto_inferior_data_cleanup, nto_new_inferior_data)
5145         (_initialize_nto_tdep): Remove.
5146         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5147
5148 2019-05-08  Tom Tromey  <tom@tromey.com>
5149
5150         * ada-lang.c (struct ada_inferior_data): Add initializers.
5151         (ada_inferior_data): Change type.
5152         (ada_inferior_data_cleanup): Remove.
5153         (get_ada_inferior_data, ada_inferior_exit)
5154         (struct ada_pspace_data): Add initializers, destructor.
5155         (ada_pspace_data_handle): Change type.
5156         (get_ada_pspace_data): Update.
5157         (ada_pspace_data_cleanup): Remove.
5158
5159 2019-05-08  Tom Tromey  <tom@tromey.com>
5160
5161         * coffread.c (struct coff_symfile_info): Add initializers.
5162         (coff_objfile_data_key): Move lower.  Change type.
5163         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5164         Update.
5165         (coff_free_info): Remove.
5166
5167 2019-05-08  Tom Tromey  <tom@tromey.com>
5168
5169         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5170         (fbsd_pspace_data_handle): Move lower.  Change type.
5171         (get_fbsd_pspace_data): Update.
5172         (fbsd_pspace_data_cleanup): Remove.
5173         (_initialize_fbsd_tdep): Update.
5174
5175 2019-05-08  Tom Tromey  <tom@tromey.com>
5176
5177         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5178         (get_ada_tasks_pspace_data): Update.
5179         (ada_tasks_pspace_data_cleanup): Remove.
5180         (_initialize_tasks): Update.
5181         (ada_tasks_inferior_data_handle): Change type.
5182         (get_ada_tasks_inferior_data): Update.
5183         (ada_tasks_inferior_data_cleanup): Remove.
5184         (struct ada_tasks_pspace_data): Add initializers.
5185
5186 2019-05-08  Tom Tromey  <tom@tromey.com>
5187
5188         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5189         * symfile-debug.c (debug_sym_get_probes): Change type.
5190         * stap-probe.c (handle_stap_probe):
5191         (stap_static_probe_ops::get_probes): Change type.
5192         * probe.h (class static_probe_ops) <get_probes>: Change type.
5193         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5194         (parse_probes_in_pspace): Update.
5195         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5196         Update.
5197         (any_static_probe_ops::get_probes): Change type.
5198         * elfread.c (elfread_data): New typedef.
5199         (probe_key): Change type.
5200         (elf_get_probes): Likewise.  Update.
5201         (probe_key_free): Remove.
5202         (_initialize_elfread): Update.
5203         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5204         Change type.
5205         (dtrace_process_dof_probe, dtrace_process_dof)
5206         (dtrace_static_probe_ops::get_probe): Change type.
5207
5208 2019-05-08  Tom Tromey  <tom@tromey.com>
5209
5210         * xcoffread.c (struct xcoff_symfile_info): Rename from
5211         coff_symfile_info.  Add initializers.
5212         (xcoff_objfile_data_key): Move lower.  Change type.
5213         (XCOFF_DATA): Rewrite.
5214         (xcoff_free_info): Remove.
5215         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5216         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5217         (xcoff_initial_scan): Update.
5218
5219 2019-05-08  Tom Tromey  <tom@tromey.com>
5220
5221         * solib-svr4.c (struct svr4_info): Add initializers and
5222         destructor.
5223         <probes_table>: Now an htab_up.
5224         (solib_svr4_pspace_data): Change type.
5225         (free_probes_table): Simplify.
5226         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5227         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5228         (probes_table_remove_objfile_probes, register_solib_event_probe)
5229         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5230         (_initialize_svr4_solib): Update.
5231
5232 2019-05-08  Tom Tromey  <tom@tromey.com>
5233
5234         * remote.c (remote_pspace_data): Change type.
5235         (remote_pspace_data_cleanup): Remove.
5236         (get_remote_exec_file, set_pspace_remote_exec_file)
5237         (_initialize_remote): Update.
5238
5239 2019-05-08  Tom Tromey  <tom@tromey.com>
5240
5241         * breakpoint.c (breakpoint_objfile_key): Change type.
5242         (get_breakpoint_objfile_data): Update.
5243         (free_breakpoint_objfile_data): Remove.
5244         (_initialize_breakpoint): Update.
5245
5246 2019-05-08  Tom Tromey  <tom@tromey.com>
5247
5248         * linux-tdep.c (struct linux_info): Add initializers.
5249         (linux_inferior_data): Move.  Change type.
5250         (invalidate_linux_cache_inf): Update.
5251         (linux_inferior_data_cleanup): Remove.
5252         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5253
5254 2019-05-08  Tom Tromey  <tom@tromey.com>
5255
5256         * auxv.c (auxv_inferior_data): Move.  Change type.
5257         (auxv_inferior_data_cleanup): Remove.
5258         (invalidate_auxv_cache_inf): Rewrite.
5259         (get_auxv_inferior_data, _initialize_auxv): Update.
5260
5261 2019-05-08  Tom Tromey  <tom@tromey.com>
5262
5263         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5264         (symfile_debug_objfile_data_key): Change type.
5265         (symfile_debug_installed, debug_qf_has_symbols)
5266         (debug_qf_find_last_source_symtab)
5267         (debug_qf_forget_cached_source_info)
5268         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5269         (debug_qf_print_stats, debug_qf_dump)
5270         (debug_qf_expand_symtabs_for_function)
5271         (debug_qf_expand_all_symtabs)
5272         (debug_qf_expand_symtabs_with_fullname)
5273         (debug_qf_map_matching_symbols)
5274         (debug_qf_expand_symtabs_matching)
5275         (debug_qf_find_pc_sect_compunit_symtab)
5276         (debug_qf_map_symbol_filenames)
5277         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5278         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5279         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5280         (debug_sym_read_linetable, debug_sym_relocate): Update.
5281         (symfile_debug_free_objfile): Remove.
5282         (install_symfile_debug_logging, _initialize_symfile_debug):
5283         Update.
5284
5285 2019-05-08  Tom Tromey  <tom@tromey.com>
5286
5287         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5288         allocate_on_obstack.
5289         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5290         (get_dwarf2_per_objfile): Update.
5291         (set_dwarf2_per_objfile): Remove.
5292         (dwarf2_has_info, dwarf2_get_section_info): Update.
5293         (dwarf2_free_objfile): Remove.
5294         (_initialize_dwarf2_read): Update.
5295
5296 2019-05-08  Tom Tromey  <tom@tromey.com>
5297
5298         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5299         initializers.
5300         <unsupported_script_warning_printed,
5301         script_not_found_warning_printed>: Now bool.
5302         (auto_load_pspace_data): Change type.
5303         (~auto_load_pspace_info): Rename from
5304         auto_load_pspace_data_cleanup.
5305         (get_auto_load_pspace_data, init_loaded_scripts_info)
5306         (clear_section_scripts, maybe_print_unsupported_script_warning)
5307         (maybe_print_script_not_found_warning, _initialize_auto_load):
5308         Update.
5309
5310 2019-05-08  Tom Tromey  <tom@tromey.com>
5311
5312         * objfiles.c (objfile_pspace_info): Add destructor and
5313         initializers.
5314         (objfiles_pspace_data): Change type.
5315         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5316         (get_objfile_pspace_data): Update.
5317         (objfiles_bfd_data): Change type.
5318         (get_objfile_bfd_data): Update.
5319         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5320
5321 2019-05-08  Tom Tromey  <tom@tromey.com>
5322
5323         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5324         Change type.
5325         (get_catch_syscall_inferior_data): Update.
5326         (catch_syscall_inferior_data_cleanup): Remove.
5327         (_initialize_break_catch_syscall): Update.
5328
5329 2019-05-08  Tom Tromey  <tom@tromey.com>
5330
5331         * inflow.c (struct terminal_info): Add destructor and
5332         initializers.
5333         (inflow_inferior_data): Change type.
5334         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5335         (get_inflow_inferior_data, inflow_inferior_exit)
5336         (swap_terminal_info, _initialize_inflow): Update.
5337
5338 2019-05-08  Tom Tromey  <tom@tromey.com>
5339
5340         * target-dcache.c (target_dcache_cleanup): Remove.
5341         (target_dcache_aspace_key): Change type.
5342         (target_dcache_init_p, target_dcache_invalidate)
5343         (target_dcache_get, target_dcache_get_or_init)
5344         (_initialize_target_dcache): Update.
5345         * dcache.h (struct dcache_deleter): New.
5346
5347 2019-05-08  Tom Tromey  <tom@tromey.com>
5348
5349         * symtab.c (struct symbol_cache): Add destructor and
5350         initializers.
5351         (symbol_cache_key): Move.  Change type.
5352         (make_symbol_cache, free_symbol_cache): Remove.
5353         (get_symbol_cache): Update.
5354         (symbol_cache_cleanup): Remove.
5355         (ALL_PSPACES, symbol_cache_flush)
5356         (maintenance_print_symbol_cache)
5357         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5358         Update.
5359
5360 2019-05-08  Tom Tromey  <tom@tromey.com>
5361
5362         * symtab.c (struct main_info): Add destructor and initializers.
5363         (main_progspace_key): Move.  Change type.
5364         (get_main_info): Update.
5365         (main_info_cleanup): Remove.
5366         (_initialize_symtab): Update.
5367
5368 2019-05-08  Tom Tromey  <tom@tromey.com>
5369
5370         * registry.h (DECLARE_REGISTRY): Define the _key class.
5371
5372 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * NEWS: Merge two 'New commands' sections.
5375
5376 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5377
5378         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5379         parameter and use Ada language definition instead.
5380         (ada_val_print_ptr): Remove unused language parameter.
5381         (ada_val_print_num): Remove language parameter and use Ada language
5382         definition instead.
5383         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5384         parameter.
5385         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5386         parameter and use Ada language definition instead.
5387         (ada_val_print_1): Update all ada_val_print_xxx calls.
5388         Remove language parameter.
5389         (ada_val_print): Update ada_val_print_1 call.
5390
5391 2019-05-08  Tom Tromey  <tromey@adacore.com>
5392
5393         * remote.c (remote_hw_watchpoint_limit)
5394         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5395         Now static.
5396
5397 2019-05-08  Tom Tromey  <tromey@adacore.com>
5398
5399         * maint.c (_initialize_maint_cmds): Move initialization code to
5400         remote.c.
5401         (watchdog, show_watchdog): Move to remote.c.
5402         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5403         "watchdog" static.
5404         (_initialize_remote): Move initialization code from maint.c.
5405         * defs.h (watchdog): Don't declare.
5406
5407 2019-05-08  Tom Tromey  <tromey@adacore.com>
5408
5409         * tui/tui-interp.c: Include main.h.
5410         * interps.c: Include main.h.
5411         * main.h (interpreter_p): Declare.
5412         * defs.h (interpreter_p): Don't declare.
5413
5414 2019-05-08  Tom Tromey  <tromey@adacore.com>
5415
5416         * dwarf2loc.c: Include dwarf2read.h.
5417         * defs.h (read_unsigned_leb128): Don't declare.
5418         * dwarf2read.h (read_unsigned_leb128): Declare.
5419
5420 2019-05-08  Tom Tromey  <tromey@adacore.com>
5421
5422         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5423         method.
5424
5425 2019-05-08  Tom Tromey  <tromey@adacore.com>
5426
5427         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5428         when no wrap column is set.
5429
5430 2019-05-08  Tom Tromey  <tromey@adacore.com>
5431
5432         * c-lang.c (c_get_string): Handle non-C-style arrays.
5433
5434 2019-05-08  Tom Tromey  <tromey@adacore.com>
5435
5436         * typeprint.c (print_offset_data::update): Print the bit offset,
5437         not the number of bits remaining.
5438
5439 2019-05-08  Tom Tromey  <tromey@adacore.com>
5440
5441         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5442         padding at end of comment.
5443
5444 2019-05-08  Tom Tromey  <tromey@adacore.com>
5445
5446         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5447         Compare main types.
5448
5449 2019-05-06  Tom Tromey  <tom@tromey.com>
5450
5451         * common/scoped_mmap.c: Include common-defs.h.
5452         * common/scoped_mmap.h: Don't include config.h.
5453
5454 2019-05-04  Tom Tromey  <tom@tromey.com>
5455
5456         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5457         (struct aarch64_call_info): Add initializers.
5458         <si>: Now a std::vector.
5459         (pass_on_stack, aarch64_push_dummy_call): Update.
5460
5461 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5462             Tom Tromey  <tom@tromey.com>
5463
5464         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5465         (ppc_threads): Now a std::vector.  Now static.
5466         (hwdebug_find_thread_points_by_tid)
5467         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5468         Update.
5469
5470 2019-05-04  Tom Tromey  <tom@tromey.com>
5471
5472         * arc-tdep.c (arc_tdesc_init): Return bool.
5473
5474 2019-05-04  Tom Tromey  <tom@tromey.com>
5475
5476         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5477         Use gdb_assert_not_reached.
5478
5479 2019-05-04  Tom Tromey  <tom@tromey.com>
5480
5481         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5482         "false".
5483
5484 2019-05-04  Tom Tromey  <tom@tromey.com>
5485
5486         * arc-tdep.c (arc_tdesc_init): Use bool.
5487
5488 2019-05-04  Tom Tromey  <tom@tromey.com>
5489
5490         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5491
5492 2019-05-04  Tom Tromey  <tom@tromey.com>
5493
5494         * cli/cli-cmds.c (valid_command_p): Return bool.
5495
5496 2019-05-04  Tom Tromey  <tom@tromey.com>
5497
5498         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5499         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5500
5501 2019-05-04  Raul Tambre  <raul@tambre.ee>
5502
5503         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5504         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5505         operator for comparison.
5506
5507 2019-05-04  Tom Tromey  <tom@tromey.com>
5508
5509         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5510         (lookup_partial_symbol, print_partial_symbols)
5511         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5512         (psymbol_compare): Update.
5513         (add_psymbol_to_bcache): Clear the entire psymbol.
5514         (maintenance_check_psymtabs): Update.
5515         * psympriv.h (struct partial_symbol): Don't derive from
5516         general_symbol_info.
5517         <obj_section, unrelocated_address, address,
5518         set_unrelocated_address>: Update.
5519         <ginfo>: New member.
5520         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5521         (debug_names::write_psymbols): Update.
5522
5523 2019-05-04  Tom de Vries  <tdevries@suse.de>
5524
5525         * contrib/cc-with-tweaks.sh: Support -n arg.
5526
5527 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5528
5529         * corelow.c (core_target::detach): Ensure frame cache and
5530         register caches are cleared.
5531         inferior.c (exit_inferior_1): Likewise.
5532
5533 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5534             Tom Tromey  <tom@tromey.com>
5535
5536         * dictionary.c (collate_pending_symbols_by_language): Remove
5537         "struct" from foreach.
5538         * symtab.c (lookup_global_symbol_from_objfile)
5539         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5540         foreach.
5541         * ser-tcp.c (net_open): Remove "struct" from foreach.
5542         * objfiles.c (objfile_relocate, objfile_rebase)
5543         (objfile_has_symbols): Remove "struct" from foreach.
5544         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5545         from foreach.
5546         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5547         foreach.
5548         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5549         "struct" from foreach.
5550         * ada-lang.c (create_excep_cond_exprs)
5551         (ada_exception_catchpoint_cond_string): Remove "struct" from
5552         foreach.
5553
5554 2019-05-03  Tom Tromey  <tromey@adacore.com>
5555
5556         * ada-exp.y (convert_char_literal): Check suffix of each
5557         enumerator.
5558
5559 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5560
5561         PR ada/21406:
5562         * ada-exp.y (yywrap): Don't define.
5563         * ada-lex.l (%option): Add noyywrap
5564         (yywrap): Remove.
5565
5566 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5567
5568         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5569         _WIN32_WINNT to the XP level, unless already defined to a higher
5570         level.
5571
5572         * unittests/parse-connection-spec-selftests.c:
5573         * ser-tcp.c:
5574         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5575         override.
5576
5577         * symfile.c (find_separate_debug_file): Remove colon from the
5578         drive spec of DOS/Windows file names of the target, so that the
5579         file name produced from DEBUGDIR and the target's directory will
5580         be valid on DOS/Windows systems.
5581
5582 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5583
5584         * rust-lang.c (val_print_struct): Handle printing structures
5585         containing strings.
5586
5587 2019-05-02  Tom Tromey  <tromey@adacore.com>
5588
5589         * valarith.c (_initialize_valarith): Remove.
5590
5591 2019-05-01  Tom Tromey  <tromey@adacore.com>
5592
5593         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5594         bitfields.
5595
5596 2019-05-01  Tom Tromey  <tromey@adacore.com>
5597
5598         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5599         for big-endian copies.
5600
5601 2019-04-30  Ali Tamur  <tamur@google.com>
5602         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5603         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5604         (read_3_bytes): New function.
5605
5606 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5607
5608         * windows-nat.c (main_thread_id): Delete.
5609         (handle_output_debug_string): Replace main_thread_id by
5610         current_event.dwThreadId.
5611         (fake_create_process): Likewise.
5612         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5613         Do not set main_thread_id.
5614         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5615         current_event.dwThreadId.
5616         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5617
5618 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5619
5620         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5621         Use current_event.dwThreadId instead of main_thread_id.
5622
5623 2019-04-30  Tom Tromey  <tromey@adacore.com>
5624
5625         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5626         (create_excep_cond_exprs): Iterate over program spaces.
5627         (ada_exception_catchpoint_cond_string): Examine all minimal
5628         symbols for exception types.
5629
5630 2019-04-30  Tom Tromey  <tromey@adacore.com>
5631
5632         PR c++/24470:
5633         * dwarf2read.c (process_structure_scope): Handle case where type
5634         has template parameters but no symbol was created.
5635
5636 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5637             Chris January  <chris.january@arm.com>
5638
5639         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5640         qualifier.
5641         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5642
5643 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5644
5645         * f-typeprint.c (f_print_type): Update rules for printing
5646         whitespace.
5647         (f_type_print_varspec_suffix): Likewise.
5648
5649 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5650             Chris January  <chris.january@arm.com>
5651
5652         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5653         function arguments.
5654
5655 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5656
5657         * f-lang.c (build_fortran_types): Change name of void type to
5658         lower case.
5659         * f-typeprint.c (f_type_print_base): Print the name of the void
5660         type, rather than a fixed string.
5661         * f-valprint.c (f_decorations): Use lower case void string.
5662
5663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5664             Chris January  <chris.january@arm.com>
5665
5666         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5667         types for Fortran.
5668
5669 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5670             Chris January  <chris.january@arm.com>
5671             David Lecomber  <david.lecomber@arm.com>
5672
5673         * f-exp.y (BINOP_INTRINSIC): New token.
5674         (exp): New parser rule handling BINOP_INTRINSIC.
5675         (f77_keywords): Add new builtin procedures.
5676         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5677         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5678         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5679         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5680         (print_unop_subexp_f): New function.
5681         (print_binop_subexp_f): New function.
5682         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5683         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5684         (dump_subexp_body_f): Likewise.
5685         (operator_check_f): Likewise.
5686         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5687         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5688
5689 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5690
5691         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5692         UNOP_KIND.
5693         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5694         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5695         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5696         (operator_length_f): New fuction.
5697         (print_subexp_f): New function.
5698         (op_name_f): New function.
5699         (dump_subexp_body_f): New function.
5700         (operator_check_f): New function.
5701         (exp_descriptor_f): Replace standard expression handling functions
5702         with new functions.
5703         * gdb/fortran-operator.def: New file.
5704         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5705         * gdb/std-operator.def: Remove UNOP_KIND.
5706
5707 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * std-operator.def: Remove unbalanced, stray double quote
5710         character.
5711
5712 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5713             Chris January  <chris.january@arm.com>
5714             Daniel Everett  <daniel.everett@arm.com>
5715             Nick Forrington  <nick.forrington@arm.com>
5716             Richard Bunt  <richard.bunt@arm.com>
5717
5718         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5719         of depth when printing anonymous structs or unions.
5720         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5721         Don't print either the top-level value, or the children if the
5722         max-depth is exceeded.
5723         (ppscm_print_children): When printing the key of a map, allow one
5724         extra level of depth.
5725         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5726         print either the top-level value, or the children if the max-depth
5727         is exceeded.
5728         (print_children): When printing the key of a map, allow one extra
5729         level of depth.
5730         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5731         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5732         (user_print_options): Initialise max_depth field.
5733         (val_print_scalar_or_string_type_p): New function.
5734         (val_print): Check to see if the max depth has been reached.
5735         (val_print_check_max_depth): Define new function.
5736         (show_print_max_depth): New function.
5737         (_initialize_valprint): Add 'print max-depth' option.
5738         * valprint.h (struct value_print_options) <max_depth>: New field.
5739         (val_print_check_max_depth): Declare new function.
5740         * NEWS: Document new feature.
5741
5742 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5743
5744         * ada-lang.c (ada_language_defn): Initialise new field.
5745         * c-lang.c (c_is_string_type_p): New function.
5746         (c_language_defn): Initialise new field.
5747         (cplus_language_defn): Initialise new field.
5748         (asm_language_defn): Initialise new field.
5749         (minimal_language_defn): Initialise new field.
5750         * c-lang.h (c_is_string_type_p): Declare new function.
5751         * d-lang.c (d_language_defn): Initialise new field.
5752         * f-lang.c (f_is_string_type_p): New function.
5753         (f_language_defn): Initialise new field.
5754         * go-lang.c (go_is_string_type_p): New function.
5755         (go_language_defn): Initialise new field.
5756         * language.c (default_is_string_type_p): New function.
5757         (unknown_language_defn): Initialise new field.
5758         (auto_language_defn): Initialise new field.
5759         * language.h (struct language_defn) <la_is_string_type_p>: New
5760         member variable.
5761         (default_is_string_type_p): Declare new function.
5762         * m2-lang.c (m2_language_defn): Initialise new field.
5763         * objc-lang.c (objc_language_defn): Initialise new field.
5764         * opencl-lang.c (opencl_language_defn): Initialise new field.
5765         * p-lang.c (pascal_is_string_type_p): New function.
5766         (pascal_language_defn): Initialise new field.
5767         * rust-lang.c (rust_is_string_type_p): New function.
5768         (rust_language_defn): Initialise new field.
5769
5770 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5771
5772         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5773         New field.
5774         * ada-lang.c (ada_language_defn): Initialise new field.
5775         * c-lang.c (c_language_defn): Likewise.
5776         (cplus_language_defn): Likewise.
5777         (asm_language_defn): Likewise.
5778         (minimal_language_defn): Likewise.
5779         * d-lang.c (d_language_defn): Likewise.
5780         * f-lang.c (f_language_defn): Likewise.
5781         * go-lang.c (go_language_defn): Likewise.
5782         * language.c (unknown_language_defn): Likewise.
5783         (auto_language_defn): Likewise.
5784         * m2-lang.c (m2_language_defn): Likewise.
5785         * objc-lang.c (objc_language_defn): Likewise.
5786         * opencl-lang.c (opencl_language_defn): Likewise.
5787         * p-lang.c (pascal_language_defn): Likewise.
5788         * rust-lang.c (rust_language_defn): Likewise.
5789
5790 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5791
5792         * ada-lang.c (ada_is_character_type): Change return type to bool.
5793         (ada_is_string_type): Likewise.
5794         * ada-lang.h (ada_is_character_type): Update declaration
5795         (ada_is_string_type): Likewise.
5796
5797 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5798
5799         Support style in 'frame|thread apply'
5800
5801         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5802         * record.c (record_start, record_stop): Update callers of
5803         execute_command_to_string with false.
5804         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5805         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5806         methods.
5807         (class string_file): New constructor with term_out parameter.
5808         Override methods term_out and can_emit_style_escape.  New member
5809         term_out.
5810         (class stdio_file): Override can_emit_style_escape.
5811         (class tee_file): Override term_out and can_emit_style_escape.
5812         * utils.h (can_emit_style_escape): Remove.
5813         * utils.c (can_emit_style_escape): Likewise.
5814         Update all callers of can_emit_style_escape (SOMESTREAM) to
5815         SOMESTREAM->can_emit_style_escape.
5816         * source-cache.c (source_cache::get_source_lines): Likewise.
5817         * stack.c (frame_apply_command_count): Call execute_command_to_string
5818         passing the term_out characteristic of the current gdb_stdout.
5819         * thread.c (thr_try_catch_cmd): Likewise.
5820         * top.c (execute_command_to_string): pass term_out parameter
5821         to construct the string_file for the command output.
5822         * ui-file.c (term_cli_styling): New function (most code moved
5823         from utils.c can_emit_style_escape).
5824         (string_file::string_file, string_file::can_emit_style_escape,
5825         stdio_file::can_emit_style_escape, tee_file::term_out,
5826         tee_file::can_emit_style_escape): New functions.
5827
5828 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5829
5830         * NEWS: Mention the new set|show may-call-functions.
5831         * infcall.c (may_call_functions_p): New variable.
5832         (show_may_call_functions_p): New function.
5833         (call_function_by_hand_dummy): Throws an error if not
5834         may-call-functions.
5835         (_initialize_infcall): Call add_setshow_boolean_cmd for
5836         may-call-functions.
5837
5838 2019-04-25  Keith Seitz  <keiths@redhat.com>
5839
5840         PR c++/24367
5841         * cp-support.c (inspect_type): Don't attempt substitutions
5842         of symbol with the same name.
5843
5844 2019-04-25  Tom Tromey  <tromey@adacore.com>
5845
5846         PR gdb/24475:
5847         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5848         static.
5849
5850 2019-04-25  Tom Tromey  <tromey@adacore.com>
5851
5852         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5853         rvalue reference.
5854         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5855         (gdb_xml_parser::parse): Use std::move.
5856         * python/python-internal.h (gdbpy_convert_exception): Take a const
5857         reference.
5858         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5859         std::move.
5860         * python/py-utils.c (gdbpy_convert_exception): Take a const
5861         reference.
5862         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5863         Use std::move.
5864         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5865         Use std::move.
5866         * mi/mi-main.c (mi_print_exception): Take a const reference.
5867         * main.c (handle_command_errors): Take a const reference.
5868         * linespec.c (parse_linespec): Use std::move.
5869         * infcall.c (run_inferior_call): Use std::move.
5870         (call_function_by_hand_dummy): Use std::move.
5871         * exec.c (try_open_exec_file): Use std::move.
5872         * exceptions.h (exception_print, exception_fprintf)
5873         (exception_print_same): Update.
5874         * exceptions.c (print_exception, exception_print)
5875         (exception_fprintf, exception_print_same): Change parameters to
5876         const reference.
5877         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5878         * common/new-op.c: Use std::move.
5879         * common/common-exceptions.h (struct gdb_exception): Add move
5880         constructor.
5881         (struct gdb_exception_error, struct gdb_exception_quit, struct
5882         gdb_quit_bad_alloc): Change constructor to move constructor.
5883         (throw_exception): Change parameter to rvalue reference.
5884         * common/common-exceptions.c (throw_exception): Take rvalue
5885         reference.
5886         * cli/cli-interp.c (safe_execute_command): Use std::move.
5887         * breakpoint.c (insert_bp_location, location_to_sals): Use
5888         std::move.
5889
5890 2019-04-25  Tom Tromey  <tromey@adacore.com>
5891
5892         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5893         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5894         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5895         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5896         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5897         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5898         guile/scm-value.c: Use unpack.
5899         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5900         gdbscm_gdb_exception.
5901         (gdbscm_throw_gdb_exception): Likewise.
5902         (struct gdbscm_gdb_exception): New.
5903         (unpack): New function.
5904         (gdbscm_wrap): Use unpack.
5905
5906 2019-04-25  Tom Tromey  <tromey@adacore.com>
5907
5908         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5909         (gdb_rl_callback_handler): Use std::move.
5910         * common/common-exceptions.h (struct gdb_exception): Add move
5911         assignment operator.
5912         (throw_exception_sjlj): Change "exception" to const reference.
5913         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5914         (throw_exception_sjlj): Change "exception" to const reference.
5915
5916 2019-04-25  Tom Tromey  <tromey@adacore.com>
5917
5918         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5919         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5920         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5921         Update.
5922         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5923         Update.
5924         * mi/mi-interp.c (mi_interp::exec): Update.
5925         * linespec.c (parse_linespec): Update.
5926         * infcall.c (run_inferior_call): Update.
5927         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5928         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5929         (gdbscm_lookup_global_symbol): Update.
5930         * guile/scm-param.c (gdbscm_parameter_value): Update.
5931         * guile/scm-frame.c (gdbscm_frame_read_register)
5932         (gdbscm_frame_read_var): Update.
5933         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5934         * exec.c (try_open_exec_file): Update.
5935         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5936         (gdb_rl_callback_handler): Update.
5937         * common/common-exceptions.h (exception_none): Don't declare.
5938         * common/common-exceptions.c (exception_none): Don't define.
5939         (struct catcher) <exception>: Update.
5940         * cli/cli-interp.c (safe_execute_command): Update.
5941         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5942
5943 2019-04-25  Ali Tamur  <tamur@google.com>
5944
5945         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5946         (read_attribute_value): Likewise.
5947         (dwarf2_read_addr_index): Update comment.
5948         (read_str_index): Add DW_FORM_strx.
5949         (dwarf2_string_attr): Likewise.
5950         (dwarf2_const_value_attr): Likewise.
5951         (dump_die_shallow): Likewise.
5952         (dwarf2_fetch_constant_bytes): Likewise.
5953         (skip_form_bytes): Likewise.
5954         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5955
5956 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5957
5958         PR corefiles/11608
5959         PR corefiles/18187
5960         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5961         OFFSET.  Verify if current mapping contains an ELF header.
5962         (linux_find_memory_regions_full): Adjust call to
5963         dump_mapping_p.
5964
5965 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5966             Kang Li <kanglictf@gmail.com>
5967
5968         PR gdb/21600
5969
5970         * dwarf2-frame.c (read_initial_length): Be consistent about using
5971         unsigned representation of length.
5972         (decode_frame_entry_1): Likewise.  Check for wraparound of
5973         end pointer as well as buffer overflow.
5974
5975 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5976
5977         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5978         "vq".
5979
5980 2019-04-24  Tom Tromey  <tromey@adacore.com>
5981
5982         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5983
5984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5985
5986         * s12z-tdep.c (s12z_unwind_pc): Delete.
5987         (s12z_unwind_sp): Delete.
5988         (s12z_gdbarch_init): Don't register deleted functions with
5989         gdbarch.
5990
5991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * rl78-tdep.c (rl78_unwind_sp): Delete.
5994         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5995
5996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5999         (xstormy16_unwind_pc): Delete.
6000         (xstormy16_dummy_id): Delete.
6001         (xstormy16_gdbarch_init): Don't register deleted functions with
6002         gdbarch.
6003
6004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * vax-tdep.c (vax_unwind_pc): Delete.
6007         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6008
6009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * v850-tdep.c (v850_unwind_sp): Delete.
6012         (v850_unwind_pc): Delete.
6013         (v850_dummy_id): Delete.
6014         (v850_gdbarch_init): Don't register deleted functions with
6015         gdbarch.
6016
6017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6020         (tilegx_unwind_pc): Delete.
6021         (tilegx_unwind_dummy_id): Delete.
6022         (tilegx_gdbarch_init): Don't register deleted functions with
6023         gdbarch.
6024
6025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6028         (tic6x_dummy_id): Delete.
6029         (tic6x_gdbarch_init): Don't register deleted functions with
6030         gdbarch.
6031
6032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6033
6034         * sparc-tdep.c (sparc_unwind_pc): Delete.
6035         (sparc32_gdbarch_init): Don't register deleted function with
6036         gdbarch.
6037
6038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6039
6040         * sh-tdep.c (sh_unwind_sp): Delete.
6041         (sh_unwind_pc): Delete.
6042         (sh_dummy_id): Delete.
6043         (sh_gdbarch_init): Don't register deleted functions with
6044         gdbarch.
6045
6046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * score-tdep.c (score_unwind_sp): Delete.
6049         (score_unwind_pc): Delete.
6050         (score_dummy_id): Delete.
6051         (score_gdbarch_init): Don't register deleted functions with
6052         gdbarch.
6053
6054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6055
6056         * rx-tdep.c (rx_unwind_pc): Delete.
6057         (rx_unwind_sp): Delete.
6058         (rx_dummy_id): Delete.
6059         (rx_gdbarch_init): Don't register deleted functions with
6060         gdbarch.  Update comment.
6061
6062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6063
6064         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6065         (rs6000_dummy_id): Delete.
6066         (rs6000_gdbarch_init): Don't register deleted functions with
6067         gdbarch.
6068
6069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6070
6071         * or1k-tdep.c (or1k_dummy_id): Delete.
6072         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6073
6074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * nios2-tdep.c (nios2_dummy_id): Delete.
6077         (nios2_unwind_sp): Delete.
6078         (nios2_gdbarch_init): Don't register deleted functions with
6079         gdbarch.
6080
6081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6082
6083         * nds32-tdep.c (nds32_dummy_id): Delete.
6084         (nds32_unwind_pc): Delete.
6085         (nds32_unwind_sp): Delete.
6086         (nds32_gdbarch_init): Don't register deleted functions with
6087         gdbarch.
6088
6089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6090
6091         * msp430-tdep.c (msp430_unwind_pc): Delete.
6092         (msp430_unwind_sp): Delete.
6093         (msp430_dummy_id): Delete.
6094         (msp430_gdbarch_init): Don't register deleted functions with
6095         gdbarch.
6096
6097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6098
6099         * moxie-tdep.c (moxie_unwind_sp): Delete.
6100         (moxie_unwind_pc): Delete.
6101         (moxie_dummy_id): Delete.
6102         (moxie_gdbarch_init): Don't register deleted functions with
6103         gdbarch.
6104
6105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6108         (mn10300_unwind_pc): Delete.
6109         (mn10300_unwind_sp): Delete.
6110         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6111         mn10300_unwind_sp.
6112         (mn10300_frame_unwind_init): Don't register deleted functions with
6113         gdbarch.
6114
6115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6116
6117         * mep-tdep.c (mep_unwind_pc): Delete.
6118         (mep_unwind_sp): Delete.
6119         (mep_dummy_id): Delete.
6120         (mep_gdbarch_init): Don't register deleted functions with
6121         gdbarch.
6122
6123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6126         (m68hc11_unwind_sp): Delete.
6127         (m68hc11_gdbarch_init): Don't register deleted functions with
6128         gdbarch.
6129
6130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6131
6132         * m32r-tdep.c (m32r_unwind_sp): Delete.
6133         (m32r_unwind_pc): Delete.
6134         (m32r_dummy_id): Delete.
6135         (m32r_gdbarch_init): Don't register deleted functions with
6136         gdbarch.
6137
6138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * m32c-tdep.c (m32c_unwind_pc): Delete.
6141         (m32c_unwind_sp): Delete.
6142         (m32c_dummy_id): Delete.
6143         (m32c_gdbarch_init): Don't register deleted functions with
6144         gdbarch.
6145
6146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6147
6148         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6149         (lm32_unwind_pc): Delete.
6150         (lm32_dummy_id): Delete.
6151         (lm32_gdbarch_init): Don't register deleted functions with
6152         gdbarch.
6153
6154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6155
6156         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6157         (iq2000_unwind_pc): Delete.
6158         (iq2000_dummy_id): Delete.
6159         (iq2000_gdbarch_init): Don't register deleted functions with
6160         gdbarch.
6161
6162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * nds32-tdep.c (nds32_type_align): Delete.
6165         (nds32_push_dummy_call): Use type_align instead.
6166
6167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * arm-tdep.c (arm_type_align): Only handle vector override case.
6170         (arm_push_dummy_call): Use type_align.
6171         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6172
6173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6174
6175         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6176         case.
6177         (pass_on_stack): Use type_align.
6178         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6179         function.
6180
6181 2019-04-23  Tom Tromey  <tromey@adacore.com>
6182
6183         * dwarf2read.c (line_header::file_name_at): Remove unused
6184         overload.
6185
6186 2019-04-23  Tom de Vries  <tdevries@suse.de>
6187
6188         PR gdb/24438
6189         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6190         invocation.
6191
6192
6193 2019-03-27  Ali Tamur  <tamur@google.com>
6194
6195         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6196         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6197         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6198         (dwarf_expr_context::get_addr_index): Likewise
6199         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6200         (symbol_needs_eval_context::get_addr_index): Likewise
6201         (disassemble_dwarf_expression): Add DW_OP_addrx
6202         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6203         (read_cutu_die_from_dwo): Update comment
6204         (skip_one_die): Add DW_FORM_addrx
6205         (read_attribute_value): Likewise
6206         (var_decode_location): Add DW_OP_addrx
6207         (dwarf2_const_value_attr): Add DW_FORM_addrx
6208         (dump_die_shallow): Likewise
6209         (dwarf2_fetch_constant_bytes): Likewise
6210         (decode_locdesc): Add DW_OP_addrx
6211         (skip_form_bytes): Add DW_FORM_addrx
6212
6213 2019-04-22  Ali Tamur  <tamur@google.com>
6214
6215         * MAINTAINERS (Write After Approval): Add self.
6216
6217 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6218
6219         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6220         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6221         (open_symbol_file_object): Likewise.
6222         (svr4_default_sos): Add info parameter.
6223         (svr4_read_so_list): Likewise.
6224         (svr4_current_sos_direct): Adjust functions calls to pass down
6225         info.
6226         (svr4_current_sos_1): Add info parameter.
6227         (svr4_current_sos): Call get_svr4_info, pass info down to
6228         svr4_current_sos_1.
6229         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6230         get_svr4_info.
6231         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6232         get_svr4_info.
6233         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6234         to get_svr4_info.
6235         (probes_table_remove_objfile_probes): Likewise.
6236         (register_solib_event_probe): Add info parameter.
6237         (solist_update_incremental): Pass info parameter down to
6238         svr4_read_so_list.
6239         (disable_probes_interface): Add info parameter.
6240         (svr4_handle_solib_event): Pass current_program_space to
6241         get_svr4_info.  Adjust disable_probes_interface cleanup.
6242         (svr4_create_probe_breakpoints): Add info parameter, pass it
6243         down to register_solib_event_probe.
6244         (svr4_create_solib_event_breakpoints): Add info parameter,
6245         pass it down to svr4_create_probe_breakpoints.
6246         (enable_break): Pass info down to
6247         svr4_create_solib_event_breakpoints.
6248         (svr4_solib_create_inferior_hook): Pass current_program_space to
6249         get_svr4_info.
6250         (svr4_clear_solib): Likewise.
6251
6252 2019-04-22  Pedro Alves  <palves@redhat.com>
6253
6254         * solib-svr4.c (svr4_free_objfile_observer): New.
6255         (probe_and_action::objfile): New field.
6256         (probes_table_htab_remove_objfile_probes)
6257         (probes_table_remove_objfile_probes): New functions.
6258         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6259         in the new probe_and_action.  Don't store the probe in 'lookup'.
6260         (svr4_create_probe_breakpoints): Pass objfile to
6261         register_solib_event_probe.
6262         (_initialize_svr4_solib): Register a free_objfile observer.
6263
6264 2019-04-19  Tom Tromey  <tom@tromey.com>
6265
6266         * common/queue.h: Remove.
6267
6268 2019-04-19  Tom Tromey  <tom@tromey.com>
6269
6270         * event-loop.c: Don't include "common/queue.h".
6271
6272 2019-04-19  Tom Tromey  <tom@tromey.com>
6273
6274         * remote.c (remote_target): Use delete.
6275         * remote-notif.h: Include <list>, not "common/queue.h".
6276         (notif_client_p): Remove typedef.
6277         (remote_notif_state): Add constructor, destructor, initializer.
6278         <notif_queue>: Now a std::list.
6279         (remote_notif_state_xfree): Don't declare.
6280         * remote-notif.c (remote_notif_process, handle_notification)
6281         (remote_notif_state_allocate): Update.
6282         (~remote_notif_state): Rename from remote_notif_state_xfree.
6283
6284 2019-04-19  Tom Tromey  <tom@tromey.com>
6285
6286         * symfile.c (reread_symbols): Update.
6287         * objfiles.c (objfile_register_static_link)
6288         (objfile_lookup_static_link): Update
6289         (~objfile) Don't delete static_links.
6290         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6291
6292 2019-04-19  Tom Tromey  <tom@tromey.com>
6293
6294         * type-stack.h (struct type_stack) <insert>: Constify string.
6295         * type-stack.c (type_stack::insert): Constify string.
6296         * gdbtypes.h (lookup_template_type): Update.
6297         (address_space_name_to_int): Update.
6298         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6299         const.
6300         (lookup_template_type): Make name const.
6301         * c-exp.y: Update rules.
6302         (lex_one_token, classify_name, classify_inner_name)
6303         (c_print_token): Update.
6304         * p-exp.y: Update rules.
6305         (yylex): Update.
6306         * f-exp.y: Update rules.
6307         (yylex): Update.
6308         * d-exp.y: Update rules.
6309         (lex_one_token, classify_name, classify_inner_name): Update.
6310         * parse.c (write_dollar_variable, copy_name): Return std::string.
6311         * parser-defs.h (copy_name): Change return type.
6312         * m2-exp.y: Update rules.
6313         (yylex): Update.
6314         * go-exp.y (lex_one_token): Update.
6315         Update rules.
6316         (classify_unsafe_function, classify_packaged_name)
6317         (classify_name, yylex): Update.
6318
6319 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6320
6321         * configure.ac: add --enable-source-highlight switch.
6322         * configure: Regenerate.
6323         * top.c (print_gdb_version): plumb --enable-source-highlight
6324         status to "show configuration".
6325
6326 2019-04-19  Tom Tromey  <tromey@adacore.com>
6327
6328         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6329         Check ADA_TYPE_P.
6330         (empty_record, ada_template_to_fixed_record_type_1)
6331         (template_to_static_fixed_type)
6332         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6333         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6334         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6335         macros.
6336
6337 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6338
6339         PR symtab/24423:
6340         * source.c (print_source_lines_base): Advance "iter" when a
6341         control character is seen.
6342
6343 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6344
6345         * inferior.h (struct infcall_suspend_state_deleter):
6346         Catch exception in destructor to avoid crash.
6347
6348 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6349
6350         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6351         close to the add_com "shell".
6352
6353 2019-04-18  Tom Tromey  <tromey@adacore.com>
6354
6355         * process-stratum-target.h (class process_stratum_target)
6356         <stratum>: Add "final".
6357
6358 2019-04-17  Tom Tromey  <tromey@adacore.com>
6359
6360         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6361         against nullptr before use.
6362
6363 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6364
6365         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6366
6367 2019-04-17  Jim Wilson  <jimw@sifive.com>
6368             Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6371         code read might fail, assume 4-byte breakpoint in that case.
6372
6373 2019-04-15  Leszek Swirski  <leszeks@google.com>
6374
6375         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6376         rather than a hand-rolled POD check when checking for forced MEMORY
6377         classification.
6378
6379 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6380
6381         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6382         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6383         function.
6384         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6385         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6386         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6387         declaration.
6388
6389 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6390
6391         * aarch64-linux-nat.c
6392         (aarch64_linux_nat_target::thread_architecture): Add override.
6393         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6394         each VQ.
6395
6396 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6397
6398         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6399
6400 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6403         target types of size 96-bits, add some additional comments, and
6404         check that the builtin type we found was the correct size.
6405
6406 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6407
6408         * utils.c (prompt_for_continue): Don't restore the styling at the
6409         end, as applied_style has the wrong value.  This fixes styling in
6410         long lists of file names that are interrupted by the "Continue?"
6411         prompt.
6412
6413 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6414
6415         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6416         * c-lang.c (c_language_defn): Likewise.
6417         (cplus_language_defn): Likewise.
6418         (asm_language_defn): Likewise.
6419         (minimal_language_defn): Likewise.
6420         * d-lang.c (d_language_defn): Likewise.
6421         * f-lang.c (f_language_defn): Likewise.
6422         * go-lang.c (go_language_defn): Likewise.
6423         * language.c (unknown_language_defn): Likewise.
6424         (auto_language_defn): Likewise.
6425         * language.h (struct language_defn): Remove la_magic field.
6426         (LANG_MAGIC): Delete.
6427         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6428         * objc-lang.c (objc_language_defn): Likewise.
6429         * opencl-lang.c (opencl_language_defn): Likewise.
6430         * p-lang.c (pascal_language_defn): Likewise.
6431         * rust-lang.c (rust_language_defn): Likewise.
6432
6433 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * riscv-tdep.c (riscv_type_align): New function.
6436         (riscv_type_alignment): Delete.
6437         (riscv_arg_location): Use 'type_align'.
6438         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6439
6440 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6441
6442         * gdbtypes.c (type_align): A struct with no non-static fields also
6443         has alignment of 1.
6444
6445 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6446
6447         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6448         component to 0.
6449         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6450         member.
6451         (riscv_struct_info::analyse): New implementation using new
6452         analyse_inner member function.
6453         (riscv_struct_info::field_offset): New member function.
6454         (riscv_struct_info::m_offsets): New member variable.
6455         (riscv_struct_info::analyse_inner): New private member function,
6456         takes the old implementation of riscv_struct_info::analyse but
6457         extended to track field offsets.
6458         (riscv_call_arg_struct): Update the struct folding special cases
6459         to handle cases where empty C++ structs, which are non-zero
6460         length, are found.
6461         (riscv_arg_location): Initialise the length of each location, a
6462         non-zero length now indicates the location is in use.
6463         (riscv_push_dummy_call): Allow for the first location having a
6464         non-zero offset when setting up arguments.
6465         (riscv_return_value): Likewise, but for return values.
6466
6467 2019-04-11  Tom Tromey  <tromey@adacore.com>
6468
6469         * utils.c (internal_vproblem): Make "msg" const.
6470
6471 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6472
6473         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6474         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6475         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6476         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6477
6478 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6479
6480         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6481         function.
6482         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6483         of amd64_collect_native_gregset.
6484         (amd64_linux_nat_target::store_registers): Likewise.
6485
6486 2019-04-10  Tom Tromey  <tom@tromey.com>
6487
6488         * symtab.c (lookup_global_symbol_from_objfile)
6489         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6490         * objfiles.h (class separate_debug_iterator): New.
6491         (class separate_debug_range): New.
6492         (struct objfile) <separate_debug_objfiles>: New method.
6493         (objfile_separate_debug_iterate): Don't declare.
6494         * objfiles.c (separate_debug_iterator::operator++): Rename from
6495         objfile_separate_debug_iterate.
6496         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6497         iterator.
6498         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6499         iterator.
6500
6501 2019-04-10  Tom Tromey  <tom@tromey.com>
6502
6503         * symfile.c (reread_symbols): Remove old comment.
6504         * objfiles.c (free_all_objfiles): Fix a typo.
6505
6506 2019-04-10  Tom Tromey  <tom@tromey.com>
6507
6508         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6509         * minsyms.c (lookup_minimal_symbol): Use foreach.
6510         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6511         (lookup_minimal_symbol_solib_trampoline): Likewise.
6512         * symfile.c (reread_symbols): Use foreach.
6513
6514 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6515             Tom Tromey  <tromey@adacore.com>
6516
6517         PR rust/24414:
6518         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6519         (rust_lex_int_test): Change "value" to be LONGEST.
6520         (rust_lex_tests): Add test for long integer literal.
6521
6522 2019-04-09  Tom Tromey  <tromey@adacore.com>
6523
6524         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6525         to bool.
6526         (extended_remote_target::attach): Update.
6527         (remote_target::remote_notice_new_inferior): Update.
6528         (remote_target::add_current_inferior_and_thread): Update.
6529         * inferior.c (exit_inferior_1): Use "false".
6530         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6531
6532 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6533
6534         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6535         the "start" command.
6536
6537 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6538
6539         * python/py-inferior.c (infpy_thread_from_thread_handle):
6540         Adjust comments to reflect renaming of thread_from_thread_handle
6541         to thread_from_handle.  Adjust keywords.  Fix type error message.
6542         (inferior_object_methods): Add thread_from_handle.  Retain
6543         thread_from_thread_handle, but mark it as deprecated.
6544
6545 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6546
6547         * gdbthread.h (find_thread_by_handle): Revise declaration.
6548         * thread.c (find_thread_by_handle): Likewise.  Adjust
6549         implementation too.
6550         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6551         support for buffer objects as handles.
6552
6553 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6554
6555         * python/py-infthread.c (thpy_thread_handle): New function.
6556         (thread_object_methods): Register thpy_thread_handle.
6557
6558 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6559
6560         * gdbthread.h (thread_to_thread_handle): Declare.
6561         * thread.c (gdbtypes.h): Include.
6562         (thread_to_thread_handle): New function.
6563
6564         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6565         (target_thread_info_to_thread_handle): Declare.
6566         * target.c (target_thread_info_to_thread_handle): New function.
6567         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6568         * target-delegates.c: Regenerate.
6569
6570         * linux-thread-db.c (class thread_db_target): Add method
6571         thread_info_to_thread_handle.
6572         (thread_db_target::thread_info_to_thread_handle): Define.
6573         * remote.c (class remote_target): Add new method
6574         thread_info_to_thread_handle.
6575         (remote_target::thread_info_to_thread_handle): Define.
6576
6577 2019-04-08  Pedro Alves  <palves@redhat.com>
6578
6579         * common/common-exceptions.c (throw_exception): Don't create
6580         named object to throw; throw directly.
6581         (throw_it): Likewise.  Don't initialize gdb_exception::message
6582         here, with new; pass FMT and AP to the ctor instead.
6583         * common/common-exceptions.h: Include <string>.
6584         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6585         const char *, va_list)): New ctor.  Use std::make_shared.
6586         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6587         errors)): Delete.
6588         (gdb_exception_error::gdb_exception_error(enum errors, const char
6589         *, va_list)): New.
6590         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6591         Add assertion.
6592         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6593         errors)): Delete.
6594         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6595         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6596         Add assertion.
6597
6598 2019-04-08  Tom Tromey  <tom@tromey.com>
6599
6600         * valops.c (value_rtti_indirect_type): Replace throw_exception
6601         with throw.
6602         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6603         with throw.
6604         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6605         throw.
6606         * target.c (target_translate_tls_address): Replace throw_exception
6607         with throw.
6608         * stack.c (frame_apply_command_count): Replace throw_exception
6609         with throw.
6610         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6611         throw.
6612         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6613         with throw.
6614         * rs6000-tdep.c (rs6000_frame_cache)
6615         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6616         * remote.c: Replace throw_exception with throw.
6617         * record-full.c (record_full_message, record_full_wait_1)
6618         (record_full_restore): Replace throw_exception with throw.
6619         * record-btrace.c:
6620         (get_thread_current_frame_id, record_btrace_start_replaying)
6621         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6622         (cmd_record_btrace_start): Replace throw_exception with throw.
6623         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6624         throw.
6625         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6626         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6627         * linespec.c:
6628         (find_linespec_symbols): Replace throw_exception with throw.
6629         * infrun.c (displaced_step_prepare, resume): Replace
6630         throw_exception with throw.
6631         * infcmd.c (post_create_inferior): Replace throw_exception with
6632         throw.
6633         * inf-loop.c (inferior_event_handler): Replace throw_exception
6634         with throw.
6635         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6636         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6637         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6638         (get_prev_frame_always, get_frame_pc_if_available)
6639         (get_frame_address_in_block_if_available, get_frame_language):
6640         Replace throw_exception with throw.
6641         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6642         throw_exception with throw.
6643         * eval.c (fetch_subexp_value, evaluate_var_value)
6644         (evaluate_funcall, evaluate_subexp_standard): Replace
6645         throw_exception with throw.
6646         * dwarf2loc.c (call_site_find_chain)
6647         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6648         Replace throw_exception with throw.
6649         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6650         with throw.
6651         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6652         throw.
6653         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6654         * completer.c (complete_line_internal): Replace throw_exception
6655         with throw.
6656         * compile/compile-object-run.c (compile_object_run): Replace
6657         throw_exception with throw.
6658         * cli/cli-script.c (process_next_line): Replace throw_exception
6659         with throw.
6660         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6661         (btrace_enable, btrace_maint_update_pt_packets): Replace
6662         throw_exception with throw.
6663         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6664         throw_exception with throw.
6665         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6666         throw_exception with throw.
6667         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6668         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6669         * aarch64-tdep.c (aarch64_make_prologue_cache)
6670         (aarch64_make_stub_cache): Replace throw_exception with throw.
6671
6672 2019-04-08  Tom Tromey  <tom@tromey.com>
6673
6674         * common/common-exceptions.c (throw_exception): Rename from
6675         throw_exception_cxx.  Remove old copy.  Make argument const.
6676         (throw_it): Create and throw exception objects directly.
6677         * common/common-exceptions.h (throw_exception): Make argument
6678         const.
6679         (struct gdb_exception_error): Add constructor.
6680         (struct gdb_exception_quit): Add constructor.
6681
6682 2019-04-08  Tom Tromey  <tom@tromey.com>
6683
6684         * common/common-exceptions.h (exception_rethrow): Don't declare.
6685         (TRY_SJLJ): Update comment.
6686         (TRY, CATCH, END_CATCH): Remove.
6687         * common/common-exceptions.c (exception_rethrow): Remove.
6688
6689 2019-04-08  Tom Tromey  <tom@tromey.com>
6690
6691         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6692         Remove.
6693         (gdb_exception_error): Rename from
6694         gdb_exception_RETURN_MASK_ERROR.
6695         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6696         (gdb_quit_bad_alloc): Update.
6697         * aarch64-tdep.c: Update.
6698         * ada-lang.c: Update.
6699         * ada-typeprint.c: Update.
6700         * ada-valprint.c: Update.
6701         * amd64-tdep.c: Update.
6702         * arch-utils.c: Update.
6703         * break-catch-throw.c: Update.
6704         * breakpoint.c: Update.
6705         * btrace.c: Update.
6706         * c-varobj.c: Update.
6707         * cli/cli-cmds.c: Update.
6708         * cli/cli-interp.c: Update.
6709         * cli/cli-script.c: Update.
6710         * common/common-exceptions.c: Update.
6711         * common/new-op.c: Update.
6712         * common/selftest.c: Update.
6713         * compile/compile-c-symbols.c: Update.
6714         * compile/compile-cplus-symbols.c: Update.
6715         * compile/compile-object-load.c: Update.
6716         * compile/compile-object-run.c: Update.
6717         * completer.c: Update.
6718         * corelow.c: Update.
6719         * cp-abi.c: Update.
6720         * cp-support.c: Update.
6721         * cp-valprint.c: Update.
6722         * darwin-nat.c: Update.
6723         * disasm-selftests.c: Update.
6724         * dtrace-probe.c: Update.
6725         * dwarf-index-cache.c: Update.
6726         * dwarf-index-write.c: Update.
6727         * dwarf2-frame-tailcall.c: Update.
6728         * dwarf2-frame.c: Update.
6729         * dwarf2loc.c: Update.
6730         * dwarf2read.c: Update.
6731         * eval.c: Update.
6732         * event-loop.c: Update.
6733         * event-top.c: Update.
6734         * exec.c: Update.
6735         * f-valprint.c: Update.
6736         * fbsd-tdep.c: Update.
6737         * frame-unwind.c: Update.
6738         * frame.c: Update.
6739         * gdbtypes.c: Update.
6740         * gnu-v3-abi.c: Update.
6741         * guile/guile-internal.h: Update.
6742         * guile/scm-block.c: Update.
6743         * guile/scm-breakpoint.c: Update.
6744         * guile/scm-cmd.c: Update.
6745         * guile/scm-disasm.c: Update.
6746         * guile/scm-frame.c: Update.
6747         * guile/scm-lazy-string.c: Update.
6748         * guile/scm-math.c: Update.
6749         * guile/scm-param.c: Update.
6750         * guile/scm-ports.c: Update.
6751         * guile/scm-pretty-print.c: Update.
6752         * guile/scm-symbol.c: Update.
6753         * guile/scm-symtab.c: Update.
6754         * guile/scm-type.c: Update.
6755         * guile/scm-value.c: Update.
6756         * i386-linux-tdep.c: Update.
6757         * i386-tdep.c: Update.
6758         * inf-loop.c: Update.
6759         * infcall.c: Update.
6760         * infcmd.c: Update.
6761         * infrun.c: Update.
6762         * jit.c: Update.
6763         * language.c: Update.
6764         * linespec.c: Update.
6765         * linux-fork.c: Update.
6766         * linux-nat.c: Update.
6767         * linux-tdep.c: Update.
6768         * linux-thread-db.c: Update.
6769         * main.c: Update.
6770         * mi/mi-cmd-break.c: Update.
6771         * mi/mi-cmd-stack.c: Update.
6772         * mi/mi-interp.c: Update.
6773         * mi/mi-main.c: Update.
6774         * objc-lang.c: Update.
6775         * p-valprint.c: Update.
6776         * parse.c: Update.
6777         * ppc-linux-tdep.c: Update.
6778         * printcmd.c: Update.
6779         * python/py-arch.c: Update.
6780         * python/py-breakpoint.c: Update.
6781         * python/py-cmd.c: Update.
6782         * python/py-finishbreakpoint.c: Update.
6783         * python/py-frame.c: Update.
6784         * python/py-framefilter.c: Update.
6785         * python/py-gdb-readline.c: Update.
6786         * python/py-inferior.c: Update.
6787         * python/py-infthread.c: Update.
6788         * python/py-lazy-string.c: Update.
6789         * python/py-linetable.c: Update.
6790         * python/py-objfile.c: Update.
6791         * python/py-param.c: Update.
6792         * python/py-prettyprint.c: Update.
6793         * python/py-progspace.c: Update.
6794         * python/py-record-btrace.c: Update.
6795         * python/py-record.c: Update.
6796         * python/py-symbol.c: Update.
6797         * python/py-type.c: Update.
6798         * python/py-unwind.c: Update.
6799         * python/py-utils.c: Update.
6800         * python/py-value.c: Update.
6801         * python/python.c: Update.
6802         * record-btrace.c: Update.
6803         * record-full.c: Update.
6804         * remote-fileio.c: Update.
6805         * remote.c: Update.
6806         * riscv-tdep.c: Update.
6807         * rs6000-aix-tdep.c: Update.
6808         * rs6000-tdep.c: Update.
6809         * rust-exp.y: Update.
6810         * rust-lang.c: Update.
6811         * s390-tdep.c: Update.
6812         * selftest-arch.c: Update.
6813         * solib-dsbt.c: Update.
6814         * solib-frv.c: Update.
6815         * solib-spu.c: Update.
6816         * solib-svr4.c: Update.
6817         * solib.c: Update.
6818         * sparc64-linux-tdep.c: Update.
6819         * stack.c: Update.
6820         * symfile-mem.c: Update.
6821         * symmisc.c: Update.
6822         * target.c: Update.
6823         * thread.c: Update.
6824         * top.c: Update.
6825         * tracefile-tfile.c: Update.
6826         * tui/tui.c: Update.
6827         * typeprint.c: Update.
6828         * unittests/cli-utils-selftests.c: Update.
6829         * unittests/parse-connection-spec-selftests.c: Update.
6830         * valops.c: Update.
6831         * valprint.c: Update.
6832         * value.c: Update.
6833         * varobj.c: Update.
6834         * windows-nat.c: Update.
6835         * x86-linux-nat.c: Update.
6836         * xml-support.c: Update.
6837
6838 2019-04-08  Tom Tromey  <tom@tromey.com>
6839
6840         * xml-support.c: Use C++ exception handling.
6841         * x86-linux-nat.c: Use C++ exception handling.
6842         * windows-nat.c: Use C++ exception handling.
6843         * varobj.c: Use C++ exception handling.
6844         * value.c: Use C++ exception handling.
6845         * valprint.c: Use C++ exception handling.
6846         * valops.c: Use C++ exception handling.
6847         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6848         handling.
6849         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6850         * typeprint.c: Use C++ exception handling.
6851         * tui/tui.c: Use C++ exception handling.
6852         * tracefile-tfile.c: Use C++ exception handling.
6853         * top.c: Use C++ exception handling.
6854         * thread.c: Use C++ exception handling.
6855         * target.c: Use C++ exception handling.
6856         * symmisc.c: Use C++ exception handling.
6857         * symfile-mem.c: Use C++ exception handling.
6858         * stack.c: Use C++ exception handling.
6859         * sparc64-linux-tdep.c: Use C++ exception handling.
6860         * solib.c: Use C++ exception handling.
6861         * solib-svr4.c: Use C++ exception handling.
6862         * solib-spu.c: Use C++ exception handling.
6863         * solib-frv.c: Use C++ exception handling.
6864         * solib-dsbt.c: Use C++ exception handling.
6865         * selftest-arch.c: Use C++ exception handling.
6866         * s390-tdep.c: Use C++ exception handling.
6867         * rust-lang.c: Use C++ exception handling.
6868         * rust-exp.y: Use C++ exception handling.
6869         * rs6000-tdep.c: Use C++ exception handling.
6870         * rs6000-aix-tdep.c: Use C++ exception handling.
6871         * riscv-tdep.c: Use C++ exception handling.
6872         * remote.c: Use C++ exception handling.
6873         * remote-fileio.c: Use C++ exception handling.
6874         * record-full.c: Use C++ exception handling.
6875         * record-btrace.c: Use C++ exception handling.
6876         * python/python.c: Use C++ exception handling.
6877         * python/py-value.c: Use C++ exception handling.
6878         * python/py-utils.c: Use C++ exception handling.
6879         * python/py-unwind.c: Use C++ exception handling.
6880         * python/py-type.c: Use C++ exception handling.
6881         * python/py-symbol.c: Use C++ exception handling.
6882         * python/py-record.c: Use C++ exception handling.
6883         * python/py-record-btrace.c: Use C++ exception handling.
6884         * python/py-progspace.c: Use C++ exception handling.
6885         * python/py-prettyprint.c: Use C++ exception handling.
6886         * python/py-param.c: Use C++ exception handling.
6887         * python/py-objfile.c: Use C++ exception handling.
6888         * python/py-linetable.c: Use C++ exception handling.
6889         * python/py-lazy-string.c: Use C++ exception handling.
6890         * python/py-infthread.c: Use C++ exception handling.
6891         * python/py-inferior.c: Use C++ exception handling.
6892         * python/py-gdb-readline.c: Use C++ exception handling.
6893         * python/py-framefilter.c: Use C++ exception handling.
6894         * python/py-frame.c: Use C++ exception handling.
6895         * python/py-finishbreakpoint.c: Use C++ exception handling.
6896         * python/py-cmd.c: Use C++ exception handling.
6897         * python/py-breakpoint.c: Use C++ exception handling.
6898         * python/py-arch.c: Use C++ exception handling.
6899         * printcmd.c: Use C++ exception handling.
6900         * ppc-linux-tdep.c: Use C++ exception handling.
6901         * parse.c: Use C++ exception handling.
6902         * p-valprint.c: Use C++ exception handling.
6903         * objc-lang.c: Use C++ exception handling.
6904         * mi/mi-main.c: Use C++ exception handling.
6905         * mi/mi-interp.c: Use C++ exception handling.
6906         * mi/mi-cmd-stack.c: Use C++ exception handling.
6907         * mi/mi-cmd-break.c: Use C++ exception handling.
6908         * main.c: Use C++ exception handling.
6909         * linux-thread-db.c: Use C++ exception handling.
6910         * linux-tdep.c: Use C++ exception handling.
6911         * linux-nat.c: Use C++ exception handling.
6912         * linux-fork.c: Use C++ exception handling.
6913         * linespec.c: Use C++ exception handling.
6914         * language.c: Use C++ exception handling.
6915         * jit.c: Use C++ exception handling.
6916         * infrun.c: Use C++ exception handling.
6917         * infcmd.c: Use C++ exception handling.
6918         * infcall.c: Use C++ exception handling.
6919         * inf-loop.c: Use C++ exception handling.
6920         * i386-tdep.c: Use C++ exception handling.
6921         * i386-linux-tdep.c: Use C++ exception handling.
6922         * guile/scm-value.c: Use C++ exception handling.
6923         * guile/scm-type.c: Use C++ exception handling.
6924         * guile/scm-symtab.c: Use C++ exception handling.
6925         * guile/scm-symbol.c: Use C++ exception handling.
6926         * guile/scm-pretty-print.c: Use C++ exception handling.
6927         * guile/scm-ports.c: Use C++ exception handling.
6928         * guile/scm-param.c: Use C++ exception handling.
6929         * guile/scm-math.c: Use C++ exception handling.
6930         * guile/scm-lazy-string.c: Use C++ exception handling.
6931         * guile/scm-frame.c: Use C++ exception handling.
6932         * guile/scm-disasm.c: Use C++ exception handling.
6933         * guile/scm-cmd.c: Use C++ exception handling.
6934         * guile/scm-breakpoint.c: Use C++ exception handling.
6935         * guile/scm-block.c: Use C++ exception handling.
6936         * guile/guile-internal.h: Use C++ exception handling.
6937         * gnu-v3-abi.c: Use C++ exception handling.
6938         * gdbtypes.c: Use C++ exception handling.
6939         * frame.c: Use C++ exception handling.
6940         * frame-unwind.c: Use C++ exception handling.
6941         * fbsd-tdep.c: Use C++ exception handling.
6942         * f-valprint.c: Use C++ exception handling.
6943         * exec.c: Use C++ exception handling.
6944         * event-top.c: Use C++ exception handling.
6945         * event-loop.c: Use C++ exception handling.
6946         * eval.c: Use C++ exception handling.
6947         * dwarf2read.c: Use C++ exception handling.
6948         * dwarf2loc.c: Use C++ exception handling.
6949         * dwarf2-frame.c: Use C++ exception handling.
6950         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6951         * dwarf-index-write.c: Use C++ exception handling.
6952         * dwarf-index-cache.c: Use C++ exception handling.
6953         * dtrace-probe.c: Use C++ exception handling.
6954         * disasm-selftests.c: Use C++ exception handling.
6955         * darwin-nat.c: Use C++ exception handling.
6956         * cp-valprint.c: Use C++ exception handling.
6957         * cp-support.c: Use C++ exception handling.
6958         * cp-abi.c: Use C++ exception handling.
6959         * corelow.c: Use C++ exception handling.
6960         * completer.c: Use C++ exception handling.
6961         * compile/compile-object-run.c: Use C++ exception handling.
6962         * compile/compile-object-load.c: Use C++ exception handling.
6963         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6964         * compile/compile-c-symbols.c: Use C++ exception handling.
6965         * common/selftest.c: Use C++ exception handling.
6966         * common/new-op.c: Use C++ exception handling.
6967         * cli/cli-script.c: Use C++ exception handling.
6968         * cli/cli-interp.c: Use C++ exception handling.
6969         * cli/cli-cmds.c: Use C++ exception handling.
6970         * c-varobj.c: Use C++ exception handling.
6971         * btrace.c: Use C++ exception handling.
6972         * breakpoint.c: Use C++ exception handling.
6973         * break-catch-throw.c: Use C++ exception handling.
6974         * arch-utils.c: Use C++ exception handling.
6975         * amd64-tdep.c: Use C++ exception handling.
6976         * ada-valprint.c: Use C++ exception handling.
6977         * ada-typeprint.c: Use C++ exception handling.
6978         * ada-lang.c: Use C++ exception handling.
6979         * aarch64-tdep.c: Use C++ exception handling.
6980
6981 2019-04-08  Tom Tromey  <tom@tromey.com>
6982
6983         * xml-support.c (gdb_xml_parser::parse): Update.
6984         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6985         * value.c (show_convenience): Update.
6986         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6987         (test_parse_flags_qcs): Update.
6988         * thread.c (thr_try_catch_cmd): Update.
6989         * target.c (target_translate_tls_address): Update.
6990         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6991         (info_frame_command_core, frame_apply_command_count): Update.
6992         * rust-exp.y (rust_lex_exception_test): Update.
6993         * riscv-tdep.c (riscv_print_one_register_info): Update.
6994         * remote.c (remote_target::enable_btrace): Update.
6995         * record-btrace.c (record_btrace_enable_warn): Update.
6996         * python/py-utils.c (gdbpy_convert_exception): Update.
6997         * printcmd.c (do_one_display, print_variable_and_value): Update.
6998         * mi/mi-main.c (mi_print_exception): Update.
6999         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7000         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7001         * linux-nat.c (linux_nat_target::attach): Update.
7002         * linux-fork.c (class scoped_switch_fork_info): Update.
7003         * infrun.c (displaced_step_prepare): Update.
7004         * infcall.c (call_function_by_hand_dummy): Update.
7005         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7006         * gnu-v3-abi.c (print_one_vtable): Update.
7007         * frame.c (get_prev_frame_always): Update.
7008         * f-valprint.c (info_common_command_for_block): Update.
7009         * exec.c (try_open_exec_file): Update.
7010         * exceptions.c (print_exception, exception_print)
7011         (exception_fprintf, exception_print_same): Update.
7012         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7013         * dwarf-index-cache.c (index_cache::store)
7014         (index_cache::lookup_gdb_index): Update.
7015         * darwin-nat.c (maybe_cache_shell): Update.
7016         * cp-valprint.c (cp_print_value_fields): Update.
7017         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7018         (gcc_cplus_symbol_address): Update.
7019         * compile/compile-c-symbols.c (gcc_convert_symbol)
7020         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7021         * common/selftest.c: Update.
7022         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7023         a std::string.
7024         (exception_try_scope_entry, exception_try_scope_exit): Don't
7025         declare.
7026         (struct exception_try_scope): Remove.
7027         (TRY): Don't use exception_try_scope.
7028         (struct gdb_exception): Add constructor, operator=.
7029         <what>: New method.
7030         (struct gdb_exception_RETURN_MASK_ALL)
7031         (struct gdb_exception_RETURN_MASK_ERROR)
7032         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7033         (struct gdb_quit_bad_alloc): Update.
7034         * common/common-exceptions.c (exception_none): Change
7035         initializer.
7036         (struct catcher) <state, exception>: Initialize inline.
7037         <prev>: Remove member.
7038         (current_catcher): Remove.
7039         (catchers): New global.
7040         (exceptions_state_mc_init): Simplify.
7041         (catcher_pop): Remove.
7042         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7043         (try_scope_depth, exception_try_scope_entry)
7044         (exception_try_scope_exit): Remove.
7045         (throw_exception_sjlj): Update.
7046         (exception_messages, exception_messages_size): Remove.
7047         (throw_it): Simplify.
7048         (gdb_exception_sliced_copy): Remove.
7049         (throw_exception_cxx): Update.
7050         * cli/cli-script.c (script_from_file): Update.
7051         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7052         Update.
7053         * ada-valprint.c (ada_val_print): Update.
7054         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7055         (create_excep_cond_exprs): Update.
7056
7057 2019-04-08  Tom Tromey  <tom@tromey.com>
7058
7059         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7060         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7061         (TRY, CATCH, END_CATCH): Remove some definitions.
7062         * common/common-exceptions.c: Don't use GDB_XCPT.
7063         (catcher_list_size): Remove.
7064         (throw_exception, throw_it): Simplify.
7065
7066 2019-04-05  Tom Tromey  <tom@tromey.com>
7067
7068         Revert the header-sorting patch.
7069         * ft32-tdep.c: Revert.
7070         * frv-tdep.c: Revert.
7071         * frv-linux-tdep.c: Revert.
7072         * frame.c: Revert.
7073         * frame-unwind.c: Revert.
7074         * frame-base.c: Revert.
7075         * fork-child.c: Revert.
7076         * findvar.c: Revert.
7077         * findcmd.c: Revert.
7078         * filesystem.c: Revert.
7079         * filename-seen-cache.h: Revert.
7080         * filename-seen-cache.c: Revert.
7081         * fbsd-tdep.c: Revert.
7082         * fbsd-nat.h: Revert.
7083         * fbsd-nat.c: Revert.
7084         * f-valprint.c: Revert.
7085         * f-typeprint.c: Revert.
7086         * f-lang.c: Revert.
7087         * extension.h: Revert.
7088         * extension.c: Revert.
7089         * extension-priv.h: Revert.
7090         * expprint.c: Revert.
7091         * exec.h: Revert.
7092         * exec.c: Revert.
7093         * exceptions.c: Revert.
7094         * event-top.c: Revert.
7095         * event-loop.c: Revert.
7096         * eval.c: Revert.
7097         * elfread.c: Revert.
7098         * dwarf2read.h: Revert.
7099         * dwarf2read.c: Revert.
7100         * dwarf2loc.c: Revert.
7101         * dwarf2expr.h: Revert.
7102         * dwarf2expr.c: Revert.
7103         * dwarf2-frame.c: Revert.
7104         * dwarf2-frame-tailcall.c: Revert.
7105         * dwarf-index-write.h: Revert.
7106         * dwarf-index-write.c: Revert.
7107         * dwarf-index-common.c: Revert.
7108         * dwarf-index-cache.h: Revert.
7109         * dwarf-index-cache.c: Revert.
7110         * dummy-frame.c: Revert.
7111         * dtrace-probe.c: Revert.
7112         * disasm.h: Revert.
7113         * disasm.c: Revert.
7114         * disasm-selftests.c: Revert.
7115         * dictionary.c: Revert.
7116         * dicos-tdep.c: Revert.
7117         * demangle.c: Revert.
7118         * dcache.h: Revert.
7119         * dcache.c: Revert.
7120         * darwin-nat.h: Revert.
7121         * darwin-nat.c: Revert.
7122         * darwin-nat-info.c: Revert.
7123         * d-valprint.c: Revert.
7124         * d-namespace.c: Revert.
7125         * d-lang.c: Revert.
7126         * ctf.c: Revert.
7127         * csky-tdep.c: Revert.
7128         * csky-linux-tdep.c: Revert.
7129         * cris-tdep.c: Revert.
7130         * cris-linux-tdep.c: Revert.
7131         * cp-valprint.c: Revert.
7132         * cp-support.c: Revert.
7133         * cp-namespace.c: Revert.
7134         * cp-abi.c: Revert.
7135         * corelow.c: Revert.
7136         * corefile.c: Revert.
7137         * continuations.c: Revert.
7138         * completer.h: Revert.
7139         * completer.c: Revert.
7140         * complaints.c: Revert.
7141         * coffread.c: Revert.
7142         * coff-pe-read.c: Revert.
7143         * cli-out.h: Revert.
7144         * cli-out.c: Revert.
7145         * charset.c: Revert.
7146         * c-varobj.c: Revert.
7147         * c-valprint.c: Revert.
7148         * c-typeprint.c: Revert.
7149         * c-lang.c: Revert.
7150         * buildsym.c: Revert.
7151         * buildsym-legacy.c: Revert.
7152         * build-id.h: Revert.
7153         * build-id.c: Revert.
7154         * btrace.c: Revert.
7155         * bsd-uthread.c: Revert.
7156         * breakpoint.h: Revert.
7157         * breakpoint.c: Revert.
7158         * break-catch-throw.c: Revert.
7159         * break-catch-syscall.c: Revert.
7160         * break-catch-sig.c: Revert.
7161         * blockframe.c: Revert.
7162         * block.c: Revert.
7163         * bfin-tdep.c: Revert.
7164         * bfin-linux-tdep.c: Revert.
7165         * bfd-target.c: Revert.
7166         * bcache.c: Revert.
7167         * ax-general.c: Revert.
7168         * ax-gdb.h: Revert.
7169         * ax-gdb.c: Revert.
7170         * avr-tdep.c: Revert.
7171         * auxv.c: Revert.
7172         * auto-load.c: Revert.
7173         * arm-wince-tdep.c: Revert.
7174         * arm-tdep.c: Revert.
7175         * arm-symbian-tdep.c: Revert.
7176         * arm-pikeos-tdep.c: Revert.
7177         * arm-obsd-tdep.c: Revert.
7178         * arm-nbsd-tdep.c: Revert.
7179         * arm-nbsd-nat.c: Revert.
7180         * arm-linux-tdep.c: Revert.
7181         * arm-linux-nat.c: Revert.
7182         * arm-fbsd-tdep.c: Revert.
7183         * arm-fbsd-nat.c: Revert.
7184         * arm-bsd-tdep.c: Revert.
7185         * arch-utils.c: Revert.
7186         * arc-tdep.c: Revert.
7187         * arc-newlib-tdep.c: Revert.
7188         * annotate.h: Revert.
7189         * annotate.c: Revert.
7190         * amd64-windows-tdep.c: Revert.
7191         * amd64-windows-nat.c: Revert.
7192         * amd64-tdep.c: Revert.
7193         * amd64-sol2-tdep.c: Revert.
7194         * amd64-obsd-tdep.c: Revert.
7195         * amd64-obsd-nat.c: Revert.
7196         * amd64-nbsd-tdep.c: Revert.
7197         * amd64-nbsd-nat.c: Revert.
7198         * amd64-nat.c: Revert.
7199         * amd64-linux-tdep.c: Revert.
7200         * amd64-linux-nat.c: Revert.
7201         * amd64-fbsd-tdep.c: Revert.
7202         * amd64-fbsd-nat.c: Revert.
7203         * amd64-dicos-tdep.c: Revert.
7204         * amd64-darwin-tdep.c: Revert.
7205         * amd64-bsd-nat.c: Revert.
7206         * alpha-tdep.c: Revert.
7207         * alpha-obsd-tdep.c: Revert.
7208         * alpha-nbsd-tdep.c: Revert.
7209         * alpha-mdebug-tdep.c: Revert.
7210         * alpha-linux-tdep.c: Revert.
7211         * alpha-linux-nat.c: Revert.
7212         * alpha-bsd-tdep.c: Revert.
7213         * alpha-bsd-nat.c: Revert.
7214         * aix-thread.c: Revert.
7215         * agent.c: Revert.
7216         * addrmap.c: Revert.
7217         * ada-varobj.c: Revert.
7218         * ada-valprint.c: Revert.
7219         * ada-typeprint.c: Revert.
7220         * ada-tasks.c: Revert.
7221         * ada-lang.c: Revert.
7222         * aarch64-tdep.c: Revert.
7223         * aarch64-ravenscar-thread.c: Revert.
7224         * aarch64-newlib-tdep.c: Revert.
7225         * aarch64-linux-tdep.c: Revert.
7226         * aarch64-linux-nat.c: Revert.
7227         * aarch64-fbsd-tdep.c: Revert.
7228         * aarch64-fbsd-nat.c: Revert.
7229         * aarch32-linux-nat.c: Revert.
7230
7231 2019-04-05  Tom Tromey  <tom@tromey.com>
7232
7233         * ft32-tdep.c: Sort headers.
7234         * frv-tdep.c: Sort headers.
7235         * frv-linux-tdep.c: Sort headers.
7236         * frame.c: Sort headers.
7237         * frame-unwind.c: Sort headers.
7238         * frame-base.c: Sort headers.
7239         * fork-child.c: Sort headers.
7240         * findvar.c: Sort headers.
7241         * findcmd.c: Sort headers.
7242         * filesystem.c: Sort headers.
7243         * filename-seen-cache.h: Sort headers.
7244         * filename-seen-cache.c: Sort headers.
7245         * fbsd-tdep.c: Sort headers.
7246         * fbsd-nat.h: Sort headers.
7247         * fbsd-nat.c: Sort headers.
7248         * f-valprint.c: Sort headers.
7249         * f-typeprint.c: Sort headers.
7250         * f-lang.c: Sort headers.
7251         * extension.h: Sort headers.
7252         * extension.c: Sort headers.
7253         * extension-priv.h: Sort headers.
7254         * expprint.c: Sort headers.
7255         * exec.h: Sort headers.
7256         * exec.c: Sort headers.
7257         * exceptions.c: Sort headers.
7258         * event-top.c: Sort headers.
7259         * event-loop.c: Sort headers.
7260         * eval.c: Sort headers.
7261         * elfread.c: Sort headers.
7262         * dwarf2read.h: Sort headers.
7263         * dwarf2read.c: Sort headers.
7264         * dwarf2loc.c: Sort headers.
7265         * dwarf2expr.h: Sort headers.
7266         * dwarf2expr.c: Sort headers.
7267         * dwarf2-frame.c: Sort headers.
7268         * dwarf2-frame-tailcall.c: Sort headers.
7269         * dwarf-index-write.h: Sort headers.
7270         * dwarf-index-write.c: Sort headers.
7271         * dwarf-index-common.c: Sort headers.
7272         * dwarf-index-cache.h: Sort headers.
7273         * dwarf-index-cache.c: Sort headers.
7274         * dummy-frame.c: Sort headers.
7275         * dtrace-probe.c: Sort headers.
7276         * disasm.h: Sort headers.
7277         * disasm.c: Sort headers.
7278         * disasm-selftests.c: Sort headers.
7279         * dictionary.c: Sort headers.
7280         * dicos-tdep.c: Sort headers.
7281         * demangle.c: Sort headers.
7282         * dcache.h: Sort headers.
7283         * dcache.c: Sort headers.
7284         * darwin-nat.h: Sort headers.
7285         * darwin-nat.c: Sort headers.
7286         * darwin-nat-info.c: Sort headers.
7287         * d-valprint.c: Sort headers.
7288         * d-namespace.c: Sort headers.
7289         * d-lang.c: Sort headers.
7290         * ctf.c: Sort headers.
7291         * csky-tdep.c: Sort headers.
7292         * csky-linux-tdep.c: Sort headers.
7293         * cris-tdep.c: Sort headers.
7294         * cris-linux-tdep.c: Sort headers.
7295         * cp-valprint.c: Sort headers.
7296         * cp-support.c: Sort headers.
7297         * cp-namespace.c: Sort headers.
7298         * cp-abi.c: Sort headers.
7299         * corelow.c: Sort headers.
7300         * corefile.c: Sort headers.
7301         * continuations.c: Sort headers.
7302         * completer.h: Sort headers.
7303         * completer.c: Sort headers.
7304         * complaints.c: Sort headers.
7305         * coffread.c: Sort headers.
7306         * coff-pe-read.c: Sort headers.
7307         * cli-out.h: Sort headers.
7308         * cli-out.c: Sort headers.
7309         * charset.c: Sort headers.
7310         * c-varobj.c: Sort headers.
7311         * c-valprint.c: Sort headers.
7312         * c-typeprint.c: Sort headers.
7313         * c-lang.c: Sort headers.
7314         * buildsym.c: Sort headers.
7315         * buildsym-legacy.c: Sort headers.
7316         * build-id.h: Sort headers.
7317         * build-id.c: Sort headers.
7318         * btrace.c: Sort headers.
7319         * bsd-uthread.c: Sort headers.
7320         * breakpoint.h: Sort headers.
7321         * breakpoint.c: Sort headers.
7322         * break-catch-throw.c: Sort headers.
7323         * break-catch-syscall.c: Sort headers.
7324         * break-catch-sig.c: Sort headers.
7325         * blockframe.c: Sort headers.
7326         * block.c: Sort headers.
7327         * bfin-tdep.c: Sort headers.
7328         * bfin-linux-tdep.c: Sort headers.
7329         * bfd-target.c: Sort headers.
7330         * bcache.c: Sort headers.
7331         * ax-general.c: Sort headers.
7332         * ax-gdb.h: Sort headers.
7333         * ax-gdb.c: Sort headers.
7334         * avr-tdep.c: Sort headers.
7335         * auxv.c: Sort headers.
7336         * auto-load.c: Sort headers.
7337         * arm-wince-tdep.c: Sort headers.
7338         * arm-tdep.c: Sort headers.
7339         * arm-symbian-tdep.c: Sort headers.
7340         * arm-pikeos-tdep.c: Sort headers.
7341         * arm-obsd-tdep.c: Sort headers.
7342         * arm-nbsd-tdep.c: Sort headers.
7343         * arm-nbsd-nat.c: Sort headers.
7344         * arm-linux-tdep.c: Sort headers.
7345         * arm-linux-nat.c: Sort headers.
7346         * arm-fbsd-tdep.c: Sort headers.
7347         * arm-fbsd-nat.c: Sort headers.
7348         * arm-bsd-tdep.c: Sort headers.
7349         * arch-utils.c: Sort headers.
7350         * arc-tdep.c: Sort headers.
7351         * arc-newlib-tdep.c: Sort headers.
7352         * annotate.h: Sort headers.
7353         * annotate.c: Sort headers.
7354         * amd64-windows-tdep.c: Sort headers.
7355         * amd64-windows-nat.c: Sort headers.
7356         * amd64-tdep.c: Sort headers.
7357         * amd64-sol2-tdep.c: Sort headers.
7358         * amd64-obsd-tdep.c: Sort headers.
7359         * amd64-obsd-nat.c: Sort headers.
7360         * amd64-nbsd-tdep.c: Sort headers.
7361         * amd64-nbsd-nat.c: Sort headers.
7362         * amd64-nat.c: Sort headers.
7363         * amd64-linux-tdep.c: Sort headers.
7364         * amd64-linux-nat.c: Sort headers.
7365         * amd64-fbsd-tdep.c: Sort headers.
7366         * amd64-fbsd-nat.c: Sort headers.
7367         * amd64-dicos-tdep.c: Sort headers.
7368         * amd64-darwin-tdep.c: Sort headers.
7369         * amd64-bsd-nat.c: Sort headers.
7370         * alpha-tdep.c: Sort headers.
7371         * alpha-obsd-tdep.c: Sort headers.
7372         * alpha-nbsd-tdep.c: Sort headers.
7373         * alpha-mdebug-tdep.c: Sort headers.
7374         * alpha-linux-tdep.c: Sort headers.
7375         * alpha-linux-nat.c: Sort headers.
7376         * alpha-bsd-tdep.c: Sort headers.
7377         * alpha-bsd-nat.c: Sort headers.
7378         * aix-thread.c: Sort headers.
7379         * agent.c: Sort headers.
7380         * addrmap.c: Sort headers.
7381         * ada-varobj.c: Sort headers.
7382         * ada-valprint.c: Sort headers.
7383         * ada-typeprint.c: Sort headers.
7384         * ada-tasks.c: Sort headers.
7385         * ada-lang.c: Sort headers.
7386         * aarch64-tdep.c: Sort headers.
7387         * aarch64-ravenscar-thread.c: Sort headers.
7388         * aarch64-newlib-tdep.c: Sort headers.
7389         * aarch64-linux-tdep.c: Sort headers.
7390         * aarch64-linux-nat.c: Sort headers.
7391         * aarch64-fbsd-tdep.c: Sort headers.
7392         * aarch64-fbsd-nat.c: Sort headers.
7393         * aarch32-linux-nat.c: Sort headers.
7394
7395 2019-04-04  Tom Tromey  <tom@tromey.com>
7396
7397         * varobj.c (varobj_create): Update.
7398         * rust-exp.y (struct rust_parser) <update_innermost_block,
7399         lookup_symbol>: New methods.
7400         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7401         Rename.
7402         (rust_parser::rust_lookup_type)
7403         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7404         * printcmd.c (display_command, do_one_display): Update.
7405         * parser-defs.h (struct parser_state) <parser_state>: Add
7406         "tracker" parameter.
7407         (block_tracker): New member.
7408         (class innermost_block_tracker) <innermost_block_tracker>: Add
7409         "types" parameter.
7410         <reset>: Remove method.
7411         (innermost_block): Don't declare.
7412         (null_post_parser): Update.
7413         * parse.c (innermost_block): Remove global.
7414         (write_dollar_variable): Update.
7415         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7416         Remove "tracker_types" parameter.
7417         (parse_expression): Add "tracker" parameter.
7418         (parse_expression_for_completion): Update.
7419         (null_post_parser): Add "tracker" parameter.
7420         * p-exp.y: Update rules.
7421         * m2-exp.y: Update rules.
7422         * language.h (struct language_defn) <la_post_parser>: Add
7423         "tracker" parameter.
7424         * go-exp.y: Update rules.
7425         * f-exp.y: Update rules.
7426         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7427         parameter.
7428         * d-exp.y: Update rules.
7429         * c-exp.y: Update rules.
7430         * breakpoint.c (set_breakpoint_condition): Create an
7431         innermost_block_tracker.
7432         (watch_command_1): Likewise.
7433         * ada-lang.c (resolve): Add "tracker" parameter.
7434         (resolve_subexp): Likewise.
7435         * ada-exp.y (write_var_from_sym): Update.
7436
7437 2019-04-04  Tom Tromey  <tom@tromey.com>
7438
7439         * type-stack.h: New file.
7440         * type-stack.c: New file.
7441         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7442         type-stack.h.
7443         (insert_into_type_stack, insert_type, push_type, push_type_int)
7444         (insert_type_address_space, pop_type, pop_type_int)
7445         (pop_typelist, pop_type_stack, append_type_stack)
7446         (push_type_stack, get_type_stack, push_typelist)
7447         (follow_type_instance_flags, follow_types): Don't declare.
7448         * parse.c (type_stack): Remove global.
7449         (parse_exp_in_context): Update.
7450         (insert_into_type_stack, insert_type, push_type, push_type_int)
7451         (insert_type_address_space, pop_type, pop_type_int)
7452         (pop_typelist, pop_type_stack, append_type_stack)
7453         (push_type_stack, get_type_stack, push_typelist)
7454         (follow_type_instance_flags, follow_types): Remove (moved to
7455         type-stack.c).
7456         * f-exp.y (type_stack): New global.
7457         Update rules.
7458         (push_kind_type, f_parse): Update.
7459         * d-exp.y (type_stack): New global.
7460         Update rules.
7461         (d_parse): Update.
7462         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7463         Update rules.
7464         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7465         (HFILES_NO_SRCDIR): Add type-stack.h.
7466
7467 2019-04-04  Tom Tromey  <tom@tromey.com>
7468
7469         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7470         (rust_parser::convert_ast_to_expression, rust_parse)
7471         (rust_lex_test_completion, rust_lex_tests): Update.
7472         * parser-defs.h (struct expr_completion_state): New.
7473         (struct parser_state) <parser_state>: Add completion parameter.
7474         <mark_struct_expression, mark_completion_tag>: New methods.
7475         <parse_completion, m_completion_state>: New members.
7476         (prefixify_expression, null_post_parser): Update.
7477         (mark_struct_expression, mark_completion_tag): Don't declare.
7478         * parse.c (parse_completion, expout_last_struct)
7479         (expout_tag_completion_type, expout_completion_name): Remove
7480         globals.
7481         (parser_state::mark_struct_expression)
7482         (parser_state::mark_completion_tag): Now methods.
7483         (prefixify_expression): Add last_struct parameter.
7484         (prefixify_subexp): Likewise.
7485         (parse_exp_1): Update.
7486         (parse_exp_in_context): Add cstate parameter.  Update.
7487         (parse_expression_for_completion): Create an
7488         expr_completion_state.
7489         (null_post_parser): Add "completion" parameter.
7490         * p-exp.y: Update rules.
7491         (yylex): Update.
7492         * language.h (struct language_defn) <la_post_parser>: Add
7493         "completing" parameter.
7494         * go-exp.y: Update rules.
7495         (lex_one_token): Update.
7496         * expression.h (parse_completion): Don't declare.
7497         * d-exp.y: Update rules.
7498         (lex_one_token): Update rules.
7499         * c-exp.y: Update rules.
7500         (lex_one_token): Update.
7501         * ada-lang.c (resolve): Add "parse_completion" parameter.
7502         (resolve_subexp): Likewise.
7503         (ada_resolve_function): Likewise.
7504
7505 2019-04-04  Tom Tromey  <tom@tromey.com>
7506
7507         * parser-defs.h (struct parser_state) <start_arglist,
7508         end_arglist>: New methods.
7509         <arglist_len, m_funcall_chain>: New members.
7510         (arglist_len, start_arglist, end_arglist): Don't declare.
7511         * parse.c (arglist_len, funcall_chain): Remove global.
7512         (start_arglist, end_arglist): Remove functions.
7513         (parse_exp_in_context): Update.
7514         * p-exp.y: Update rules.
7515         * m2-exp.y: Update rules.
7516         * go-exp.y: Update rules.
7517         * f-exp.y: Update rules.
7518         * d-exp.y: Update rules.
7519         * c-exp.y: Update rules.
7520
7521 2019-04-04  Tom Tromey  <tom@tromey.com>
7522
7523         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7524         lex_operator, push_back>: New methods.
7525         Update all rules.
7526         (rust_parser::lex_hex, lex_escape): Rename and update.
7527         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7528         (rust_parser::lex_operator): Rename and update.
7529         (rust_parser::lex_number, rustyylex, rustyyerror)
7530         (rust_lex_test_init, rust_lex_test_sequence)
7531         (rust_lex_test_push_back, rust_lex_tests): Update.
7532         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7533         parameter.
7534         <lexptr, prev_lexptr>: New members.
7535         (lexptr, prev_lexptr): Don't declare.
7536         * parse.c (lexptr, prev_lexptr): Remove globals.
7537         (parse_exp_in_context): Update.
7538         * p-exp.y (yylex, yyerror): Update.
7539         * m2-exp.y (parse_number, yylex, yyerror): Update.
7540         * go-exp.y (lex_one_token, yyerror): Update.
7541         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7542         * d-exp.y (lex_one_token, yyerror): Update.
7543         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7544         (lex_one_token, yyerror): Update.
7545         * ada-lex.l (YY_INPUT): Update.
7546         (rewind_to_char): Update.
7547         * ada-exp.y (yyerror): Update.
7548
7549 2019-04-04  Tom Tromey  <tom@tromey.com>
7550
7551         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7552         * parser-defs.h (struct parser_state) <parser_state>: Add new
7553         parameter.
7554         <comma_terminates>: New member.
7555         (comma_terminates): Don't declare global.
7556         * parse.c (comma_terminates): Remove global.
7557         (parse_exp_in_context): Update.
7558         * p-exp.y (yylex): Update.
7559         * m2-exp.y (yylex): Update.
7560         * go-exp.y (lex_one_token): Update.
7561         * f-exp.y (yylex): Update.
7562         * d-exp.y (lex_one_token): Update.
7563         * c-exp.y (lex_one_token): Update.
7564         * ada-lex.l: Update.
7565
7566 2019-04-04  Tom Tromey  <tom@tromey.com>
7567
7568         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7569         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7570         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7571         * parser-defs.h (paren_depth): Don't declare.
7572         * parse.c (paren_depth): Remove global.
7573         (parse_exp_in_context): Update.
7574         * p-exp.y (paren_depth): New global.
7575         (pascal_parse): Initialize it.
7576         * m2-exp.y (paren_depth): New global.
7577         (m2_parse): Initialize it.
7578         * go-exp.y (paren_depth): New global.
7579         (go_parse): Initialize it.
7580         * f-exp.y (paren_depth): New global.
7581         (f_parse): Initialize it.
7582         * d-exp.y (paren_depth): New global.
7583         (d_parse): Initialize it.
7584         * c-exp.y (paren_depth): New global.
7585         (c_parse): Initialize it.
7586         * ada-lex.l (paren_depth): New global.
7587         (lexer_init): Initialize it.
7588
7589 2019-04-04  Tom Tromey  <tom@tromey.com>
7590
7591         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7592         (rust_parser::convert_ast_to_type)
7593         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7594         * parser-defs.h (struct parser_state) <parser_state>: Add
7595         parameters.  Initialize new members.
7596         <expression_context_block, expression_context_pc>: New members.
7597         * parse.c (expression_context_block, expression_context_pc):
7598         Remove globals.
7599         (parse_exp_in_context): Update.
7600         * p-exp.y: Update all rules.
7601         (yylex): Update.
7602         * m2-exp.y: Update all rules.
7603         (yylex): Update.
7604         * go-exp.y (yylex): Update.
7605         * f-exp.y (yylex): Update.
7606         * d-exp.y: Update all rules.
7607         (yylex): Update.
7608         * c-exp.y: Update all rules.
7609         (lex_one_token, classify_name, yylex, c_parse): Update.
7610         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7611
7612 2019-04-04  Tom Tromey  <tom@tromey.com>
7613
7614         * gdbarch.h, gdbarch.c: Rebuild.
7615         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7616         * stap-probe.h:
7617         (struct stap_parse_info): Replace "parser_state" with
7618         "expr_builder".
7619         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7620         (parser_state): New class.
7621         * parse.c (expr_builder): Rename.
7622         (expr_builder::release): Rename.
7623         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7624         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7625         (write_exp_elt_longcst, write_exp_elt_floatcst)
7626         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7627         (write_exp_string_vector, write_exp_bitstring)
7628         (write_exp_msymbol, mark_struct_expression)
7629         (write_dollar_variable)
7630         (insert_type_address_space, increase_expout_size): Replace
7631         "parser_state" with "expr_builder".
7632         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7633         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7634         "parser_state" with "expr_builder".
7635
7636 2019-04-04  Tom Tromey  <tom@tromey.com>
7637
7638         * rust-exp.y: Replace "parse_language" with method call.
7639         * p-exp.y:
7640         (yylex): Replace "parse_language" with method call.
7641         * m2-exp.y:
7642         (yylex): Replace "parse_language" with method call.
7643         * go-exp.y (classify_name): Replace "parse_language" with method
7644         call.
7645         * f-exp.y (yylex): Replace "parse_language" with method call.
7646         * d-exp.y (lex_one_token): Replace "parse_language" with method
7647         call.
7648         * c-exp.y:
7649         (lex_one_token, classify_name, yylex): Replace "parse_language"
7650         with method call.
7651         * ada-exp.y (find_primitive_type, type_char)
7652         (type_system_address): Replace "parse_language" with method call.
7653
7654 2019-04-04  Tom Tromey  <tom@tromey.com>
7655
7656         * rust-exp.y: Replace "parse_gdbarch" with method call.
7657         * parse.c (write_dollar_variable, insert_type_address_space):
7658         Replace "parse_gdbarch" with method call.
7659         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7660         call.
7661         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7662         call.
7663         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7664         "parse_gdbarch" with method call.
7665         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7666         with method call.
7667         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7668         "parse_gdbarch" with method call.
7669         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7670         "parse_gdbarch" with method call.
7671         * c-exp.y (parse_type, parse_number, classify_name): Replace
7672         "parse_gdbarch" with method call.
7673         * ada-lex.l: Replace "parse_gdbarch" with method call.
7674         * ada-exp.y (parse_type, find_primitive_type, type_char)
7675         (type_system_address): Replace "parse_gdbarch" with method call.
7676
7677 2019-04-04  Tom Tromey  <tom@tromey.com>
7678
7679         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7680         * stap-probe.c (stap_parse_argument): Update.
7681         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7682         initial_size parameter.
7683         * rust-exp.y (rust_lex_tests): Update.
7684         * parse.c (parser_state): Update.
7685         (parse_exp_in_context): Update.
7686         * parser-defs.h (struct parser_state) <parser_state>: Remove
7687         "initial_size" parameter.
7688
7689 2019-04-04  Tom Tromey  <tom@tromey.com>
7690
7691         * parser-defs.h (increase_expout_size): Don't declare.
7692         * parse.c (increase_expout_size): Now static.
7693
7694 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7695
7696         * gnu-nat.c (gnu_nat_target::wait): Fix
7697         target_waitstatus_to_string call.
7698
7699 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7700
7701         * eval.c (evaluate_subexp_standard): Handle internal functions
7702         during Fortran function call handling.
7703
7704 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7705
7706         * NEWS: Mention new internal functions.
7707         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7708         (read_base_type): Use dwarf2_init_complex_target_type.
7709         * value.c (creal_internal_fn): New function.
7710         (cimag_internal_fn): New function.
7711         (_initialize_values): Register new internal functions.
7712
7713 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7714
7715         * infrun.c (stop_all_threads): If debug_infrun, always
7716         trace the wait status after wait_one, using
7717         target_waitstatus_to_string and target_pid_to_str.
7718         (handle_inferior_event): Replace various trace of
7719         wait status kind by a single trace.
7720         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7721         wait status kind image by target_waitstatus_to_string.
7722         * target/waitstatus.c (target_waitstatus_to_string): Fix
7723         obsolete comment.
7724
7725 2019-04-01  Tom Tromey  <tromey@adacore.com>
7726
7727         PR symtab/23331:
7728         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7729
7730 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7731             Pedro Alves  <palves@redhat.com>
7732
7733         * top.c (quit_force): Call 'finalize_values'.
7734         * value.c (finalize_values): New function.
7735         * value.h (finalize_values): Declare.
7736
7737 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7738
7739         * NEWS: Announce $_gdb_major and $_gdb_minor.
7740
7741         * top.c (init_gdb_version_vars): New function.
7742         (gdb_init): Call init_gdb_version_vars.
7743
7744 2019-03-29  Tom Tromey  <tromey@adacore.com>
7745
7746         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7747         help text.  Remove dead code.
7748
7749 2019-03-29  Keith Seitz  <keiths@redhat.com>
7750
7751         From Siddhesh Poyarekar:
7752         * f-lang.h (f77_get_upperbound): Return LONGEST.
7753         (f77_get_lowerbound): Likewise.
7754         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7755         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7756         print them.
7757         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7758         plongest to format print it.
7759         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7760         (f77_get_upperbound): Likewise.
7761         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7762         LOWER_BOUND to LONGEST.
7763         (f77_create_arrayprint_offset_tbl): Likewise.
7764
7765 2019-03-29  Keith Seitz  <keiths@redhat.com>
7766
7767         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7768         %s/pulongest for TYPE_LENGTH instead of %d in format
7769         strings.
7770         * ada-typerint.c (ada_print_type): Likewise.
7771         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7772         * compile/compile-c-support.c (generate_register_struct): Likewise.
7773         * gdbtypes.c (recursive_dump_type): Likewise.
7774         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7775         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7776         instead of %d in format strings.
7777         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7778         to std::min to ULONGEST.
7779         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7780         instead of %d in format strings.
7781         * tracepoint.c (info_scope_command): Likewise.
7782         * typeprint.c (print_offset_data::update)
7783         (print_offset_data::finish): Likewise.
7784         * xtensa-tdep.c (xtensa_store_return_value)
7785         (xtensa_push_dummy_call): Likewise.
7786
7787 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7788
7789         * windows-nat.c (display_selector): Fixed format specifications
7790         for 64-bit Cygwin.
7791
7792 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7793
7794         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7795
7796 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7797
7798         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7799         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7800         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7801         (nios2_linux_init_abi): Install it.
7802
7803 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7804
7805         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7806
7807 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7808
7809         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7810
7811 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7812             Tom Tromey  <tromey@adacore.com>
7813
7814         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7815
7816 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7817
7818         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7819         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7820         method to compute the bounds of range types. Also print "[evaluated]"
7821         if the bounds' values come from a dynamic evaluation.
7822
7823 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7826         whitespace when pretty printing is on.
7827
7828 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7829
7830         * ppc-linux-nat.c: Add include.
7831
7832 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7833
7834         * NEWS: Mention AArch64 Pointer Authentication.
7835
7836 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7837
7838         * arm-linux-nat.c: Add include.
7839
7840 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7841
7842         * source-cache.c (source_cache::get_source_lines): Re-read
7843         fullname after calling open_source_file.
7844
7845 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7846
7847         * NEWS: Mention TLS support for FreeBSD.
7848
7849 2019-03-25  Tom Tromey  <tromey@adacore.com>
7850
7851         * minsyms.c (BUNCH_SIZE): Update comment.
7852         (~minimal_symbol_reader): Remove old comment.
7853         (compact_minimal_symbols): Update comment.
7854         (minimal_symbol_reader::install): Remove old comment.  Update
7855         other comments.
7856
7857 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7858
7859         * s390-linux-nat.c: Add include.
7860
7861 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7862
7863         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7864         Call linux_get_hwcap.
7865         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7866         Likewise.
7867         (aarch64_linux_get_hwcap): Remove function.
7868         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7869         declaration.
7870         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7871         linux_get_hwcap.
7872         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7873         * linux-tdep.c (linux_get_hwcap): Add function.
7874         (linux_get_hwcap2): Likewise.
7875         * linux-tdep.h (linux_get_hwcap): Add declaration.
7876         (linux_get_hwcap2): Likewise.
7877         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7878         (ppc_linux_get_hwcap2): Likewise.
7879         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7880         linux_get_hwcap.
7881         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7882         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7883         (ppc_linux_nat_target::read_description): Likewise.
7884         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7885         * s390-linux-nat.c: Likewise.
7886         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7887
7888 2019-03-24  Tom Tromey  <tom@tromey.com>
7889
7890         * ada-lang.c (standard_lookup): Simplify initialization.
7891         (ada_lookup_symbol_nonlocal): Simplify return.
7892         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7893         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7894         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7895         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7896         initialization.
7897         * solib.c (solib_global_lookup): Simplify.
7898         * symtab.c (null_block_symbol): Remove.
7899         (symbol_cache_lookup): Simplify returns.
7900         (lookup_language_this): Simplify returns.
7901         (lookup_symbol_aux): Simplify return.
7902         (lookup_local_symbol): Simplify returns.
7903         (lookup_global_symbol_from_objfile): Simplify return.
7904         (lookup_symbol_in_objfile_symtabs)
7905         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7906         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7907         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7908         * cp-namespace.c (cp_lookup_bare_symbol)
7909         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7910         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7911         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7912         (cp_lookup_symbol_via_imports): Simplify initialization.
7913         (find_symbol_in_baseclass): Likewise.
7914         * symtab.h (null_block_symbol): Remove.
7915         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7916         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7917         (d_lookup_symbol_module): Likewise.
7918         (find_symbol_in_baseclass): Simplify initialization.
7919
7920 2019-03-24  Tom Tromey  <tom@tromey.com>
7921
7922         * expression.h: Don't include symtab.h.
7923         (struct block): Forward declare.
7924
7925 2019-03-24  Tom Tromey  <tom@tromey.com>
7926
7927         * c-exp.y (typebase): Remove casts.
7928         * gdbtypes.c (lookup_unsigned_typename, )
7929         (lookup_signed_typename): Remove cast.
7930         * eval.c (parse_to_comma_and_eval): Remove cast.
7931         * parse.c (write_dollar_variable): Remove cast.
7932         * block.h (struct block) <superblock>: Now const.
7933         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7934         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7935         (map_block): Make "block" const.
7936         * symfile.h (struct quick_symbol_functions)
7937         <map_matching_symbols>: Constify block argument to "callback".
7938         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7939         const.
7940         (find_pc_sect_compunit_symtab): Make "b" const.
7941         (find_symbol_at_address): Likewise.
7942         (search_symbols): Likewise.
7943         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7944         (dw2_debug_names_lookup_symbol): Likewise.
7945         (dw2_map_matching_symbols): Update.
7946         * p-valprint.c (pascal_val_print): Remove "block".
7947         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7948         (aux_add_nonlocal_symbols): Make "block" const.
7949         (resolve_subexp): Remove cast.
7950         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7951         const.
7952         (iterate_over_file_blocks): Likewise.
7953         * f-exp.y (%union) <bval>: Remove.
7954         * coffread.c (patch_opaque_types): Make "b" const.
7955         * spu-tdep.c (spu_catch_start): Make "block" const.
7956         * c-valprint.c (print_unpacked_pointer): Remove "block".
7957         * symmisc.c (dump_symtab_1): Make "b" const.
7958         (block_depth): Make "block" const.
7959         * d-exp.y (%union) <bval>: Remove.
7960         * cp-support.h (cp_lookup_rtti_type): Update.
7961         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7962         * psymtab.c (psym_lookup_symbol): Make "block" const.
7963         (maintenance_check_psymtabs): Make "b" const.
7964         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7965         (enumerate_locals, enumerate_args): Update.
7966         * python/py-symtab.c (stpy_global_block): Make "block" const.
7967         (stpy_static_block): Likewise.
7968         * inline-frame.c (block_starting_point_at): Make "new_block"
7969         const.
7970         * block.c (find_block_in_blockvector): Make return type const.
7971         (blockvector_for_pc_sect): Make "b" const.
7972         (find_block_in_blockvector): Make "b" const.
7973
7974 2019-03-23  Tom Tromey  <tom@tromey.com>
7975
7976         * varobj.c (varobj_create): Update.
7977         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7978         * printcmd.c (display_command, do_one_display): Don't reset
7979         innermost_block.
7980         * parser-defs.h (enum innermost_block_tracker_type): Move to
7981         expression.h.
7982         (innermost_block): Update comment.
7983         * parse.c (parse_exp_1): Add tracker_types parameter.
7984         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7985         tracker_types parameter.  Reset innermost_block.
7986         (parse_exp_in_context): Remove.
7987         (parse_expression_for_completion): Update.
7988         * objfiles.c (~objfile): Don't reset expression_context_block or
7989         innermost_block.
7990         * expression.h (enum innermost_block_tracker_type): Move from
7991         parser-defs.h.
7992         (parse_exp_1): Add tracker_types parameter.
7993         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7994         reset innermost_block.
7995
7996 2019-03-23  Tom Tromey  <tom@tromey.com>
7997
7998         * objfiles.h: Include bcache.h.
7999
8000 2019-03-23  Tom Tromey  <tom@tromey.com>
8001
8002         * linespec.c (get_current_search_block): Use
8003         scoped_restore_current_language.
8004         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8005
8006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8007             Jiong Wang  <jiong.wang@arm.com>
8008
8009         * aarch64-linux-tdep.c
8010         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8011         section.
8012         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8013
8014 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8015             Jiong Wang  <jiong.wang@arm.com>
8016
8017         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8018         instructions.
8019         (aarch64_analyze_prologue_test): Add PACIASP test.
8020         (aarch64_prologue_prev_register): Unmask PC value.
8021
8022 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8023             Jiong Wang  <jiong.wang@arm.com>
8024
8025         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8026         (aarch64_dwarf2_prev_register): Unmask PC value.
8027         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8028         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8029         DW_CFA_AARCH64_negate_ra_state.
8030         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8031
8032 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8033             Jiong Wang  <jiong.wang@arm.com>
8034
8035         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8036         registers.
8037         (aarch64_pseudo_register_name): Likewise.
8038         (aarch64_pseudo_register_type): Likewise.
8039         (aarch64_pseudo_register_reggroup_p): Likewise.
8040         (aarch64_gdbarch_init): Add pauth registers.
8041         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8042         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8043         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8044         (struct gdbarch_tdep): Add regnum for ra_state.
8045
8046 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8047             Jiong Wang  <jiong.wang@arm.com>
8048
8049         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8050
8051 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8052             Jiong Wang  <jiong.wang@arm.com>
8053
8054         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8055         function.
8056         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8057         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8058         (aarch64_gdbarch_init): Add puth registers.
8059         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8060         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8061         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8062
8063 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8064             Jiong Wang  <jiong.wang@arm.com>
8065
8066         * aarch64-linux-nat.c
8067         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8068         * aarch64-linux-tdep.c
8069         (aarch64_linux_core_read_description): Likewise.
8070         (aarch64_linux_get_hwcap): New function.
8071         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8072         (aarch64_linux_get_hwcap): New declaration.
8073
8074 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8075             Jiong Wang  <jiong.wang@arm.com>
8076
8077         * aarch64-linux-nat.c
8078         (aarch64_linux_nat_target::read_description): Add pauth param.
8079         * aarch64-linux-tdep.c
8080         (aarch64_linux_core_read_description): Likewise.
8081         * aarch64-tdep.c (struct target_desc): Add in pauth.
8082         (aarch64_read_description): Add pauth param.
8083         (aarch64_gdbarch_init): Likewise.
8084         * aarch64-tdep.h (aarch64_read_description): Likewise.
8085         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8086         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8087         * features/Makefile: Add new files.
8088         * features/aarch64-pauth.c: New file.
8089         * features/aarch64-pauth.xml: New file.
8090
8091 2019-03-20  Tom Tromey  <tromey@adacore.com>
8092
8093         * infrun.c (handle_inferior_event): Rename from
8094         handle_inferior_event_1.  Create a scoped_value_mark.
8095         (handle_inferior_event): Remove.
8096
8097 2019-03-19  Tom Tromey  <tromey@adacore.com>
8098
8099         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8100         * infrun.h (print_stop_event): Add "displays" parameter.
8101         * infrun.c (print_stop_event): Add "displays" parameter.
8102
8103 2019-03-19  Pedro Alves  <palves@redhat.com>
8104
8105         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8106         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8107         to -1.  Fix TABs vs spaces.
8108         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8109         * tui/tui-out.h (tui_ui_out) Add intro comments.
8110         <m_line, m_start_of_line>: In-class initialize, and add describing
8111         comment.
8112
8113 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8114
8115         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8116         variable names.
8117         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8118
8119 2019-03-18  Pedro Alves  <palves@redhat.com>
8120             Eli Zaretskii <eliz@gnu.org>
8121
8122         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8123         m_line and m_start_of_line.
8124
8125 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8126
8127         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8128         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8129         it returns a newline.  This fixes a regression in TU mode, whereby
8130         the next line is output on the same screen line as the user input.
8131
8132 2019-03-18  Tom Tromey  <tromey@adacore.com>
8133
8134         * minsyms.c (minimal_symbol_reader::install): Remove call to
8135         obstack_blank.
8136
8137 2019-03-18  Pedro Alves  <palves@redhat.com>
8138
8139         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8140         New globals.
8141         (apply_style): New, factored out from ...
8142         (apply_ansi_escape): ... this.  Handle reverse video mode.
8143         (tui_set_reverse_mode): New function.
8144         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8145         * tui/tui-winsource.c (tui_show_source_line): Use
8146         tui_set_reverse_mode instead of setting A_STANDOUT.
8147         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8148         New setter methods.
8149
8150 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8151
8152         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8153         Handle tabs.
8154
8155 2019-03-18  Tom Tromey  <tromey@adacore.com>
8156
8157         * ada-lang.c (empty_array): Add "high" parameter.
8158         (ada_evaluate_subexp): Update.
8159
8160 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8161
8162         * unittests/string_view-selftests.c: Define
8163         _initialize_string_view_selftests unconditionally.
8164
8165 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8166
8167         PR gdb/24350
8168         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8169
8170 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8171
8172         PR gdb/24351
8173         * windows-nat.c (display_selector): Fix format specifiers.
8174
8175 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8176
8177         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8178         tui_refill_source_window instead of tui_refresh_win, to update the
8179         current execution line.  This fixes redisplay of the current line
8180         when stepping through the code with "next" or "step".
8181
8182 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8183
8184         * source-cache.c (source_cache::get_source_lines): Call
8185         find_source_lines to initialize s->nlines.  This fixes vertical
8186         scrolling of TUI source window when the DOWN arrow is pressed.
8187
8188 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8189
8190         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8191         linux-thread-db.c (_initialize_thread_db): Likewise.
8192
8193 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8194
8195         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8196         wclrtoeol in tui_show_source_line".  This reverts changes made in
8197         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8198
8199 2019-03-15  Tom Tromey  <tom@tromey.com>
8200
8201         * symtab.h (struct minimal_symbol): Derive from
8202         general_symbol_info.
8203         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8204         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8205         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8206         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8207         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8208         (MSYMBOL_SEARCH_NAME): Update.
8209         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8210         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8211         * minsyms.c (minimal_symbol_reader::record_full): Update.
8212
8213 2019-03-15  Tom Tromey  <tom@tromey.com>
8214
8215         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8216
8217 2019-03-15  Tom Tromey  <tom@tromey.com>
8218
8219         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8220         unique_xmalloc_ptr.
8221         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8222         Update.
8223         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8224         (build_minimal_symbol_hash_tables)
8225         (minimal_symbol_reader::install): Update.
8226
8227 2019-03-15  Tom Tromey  <tom@tromey.com>
8228
8229         * symtab.c (create_demangled_names_hash): Update.
8230         (symbol_set_names): Update.
8231         * objfiles.h (struct objfile_per_bfd_storage)
8232         <demangled_names_hash>: Now an htab_up.
8233         * objfiles.c (objfile_per_bfd_storage): Simplify.
8234
8235 2019-03-15  Tom Tromey  <tom@tromey.com>
8236
8237         * objfiles.h (struct objfile_per_bfd_storage): Declare
8238         destructor.
8239         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8240         New.
8241         (get_objfile_bfd_data): Use new.  Don't initialize
8242         language_of_main.
8243         (free_objfile_per_bfd_storage): Remove.
8244         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8245
8246 2019-03-15  Tom Tromey  <tom@tromey.com>
8247
8248         * symfile.c (reread_symbols): Update.
8249         * objfiles.c (objfile::objfile): Update.
8250         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8251         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8252         comment.
8253         (minimal_symbol_reader::install): Update.
8254         (terminate_minimal_symbol_table): Remove.
8255         * jit.c (jit_object_close_impl): Update.
8256
8257 2019-03-15  Tom Tromey  <tom@tromey.com>
8258
8259         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8260         initializations.
8261
8262 2019-03-15  Tom Tromey  <tom@tromey.com>
8263
8264         * objfiles.h (struct objfile_per_bfd_storage)
8265         <demangled_hash_languages>: Now a bitset.
8266         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8267         (lookup_minimal_symbol): Update.
8268
8269 2019-03-15  Tom Tromey  <tom@tromey.com>
8270
8271         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8272         Don't return the symbol.
8273         * coffread.c (record_minimal_symbol): Use record_full.
8274
8275 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8276
8277         The MS-Windows port of ncurses fails to switch to a color pair if
8278         one or both of the colors are the implicit default colors.  This
8279         change records the default colors when TUI is initialized, and
8280         then specifies them explicitly when a color pair uses the default
8281         colors.  This allows color styling in TUI mode on MS-Windows.
8282
8283         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8284         ncurses_norm_attr.
8285         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8286         colors in ncurses_norm_attr.
8287         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8288         "none", replace it with the default color recorded in
8289         ncurses_norm_attr.
8290
8291 2019-03-14  Tom Tromey  <tromey@adacore.com>
8292
8293         * source-cache.h (class source_cache) <get_source_lines>: Return
8294         std::string.
8295         * source-cache.c (source_cache::extract_lines): Handle case where
8296         first_pos==npos.  Return std::string.
8297         (source_cache::get_source_lines): Update.
8298
8299 2019-03-14  Tom Tromey  <tromey@adacore.com>
8300
8301         * NEWS: Add item for "style sources" commands.
8302         * source-cache.c (source_cache::get_source_lines): Check
8303         source_styling.
8304         * cli/cli-style.c (source_styling): New global.
8305         (_initialize_cli_style): Add "style sources" commands.
8306         (show_style_sources): New function.
8307         * cli/cli-style.h (source_styling): Declare.
8308
8309 2019-03-14  Pedro Alves  <palves@redhat.com>
8310             Tom Tromey  <tromey@adacore.com>
8311
8312         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8313         * tui/tui-winsource.c (tui_refill_source_window): New function,
8314         from...
8315         (tui_horizontal_source_scroll): ... here.  Move some logic.
8316         * cli/cli-style.c (set_style_enabled): Notify new observable.
8317         * tui/tui-hooks.c (tui_redisplay_source): New function.
8318         (tui_attach_detach_observers): Attach or detach
8319         tui_redisplay_source.
8320         * observable.h (source_styling_changed): New observable.
8321         * observable.c: Define source_styling_changed observable.
8322
8323 2019-03-13  Tom Tromey  <tromey@adacore.com>
8324
8325         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8326         (i386_gnu_nat_target::store_registers): Update.
8327         * target-debug.h (target_debug_print_std_string): New macro.
8328         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8329         * windows-tdep.c (display_one_tib): Update.
8330         * tui/tui-stack.c (tui_make_status_line): Update.
8331         * top.c (print_inferior_quit_action): Update.
8332         * thread.c (thr_try_catch_cmd): Update.
8333         (add_thread_with_info): Update.
8334         (thread_target_id_str): Update.
8335         (thr_try_catch_cmd): Update.
8336         (thread_command): Update.
8337         (thread_find_command): Update.
8338         * record-btrace.c (record_btrace_target::info_record)
8339         (record_btrace_resume_thread, record_btrace_target::resume)
8340         (record_btrace_cancel_resume, record_btrace_step_thread)
8341         (record_btrace_target::wait, record_btrace_target::wait)
8342         (record_btrace_target::wait, record_btrace_target::stop): Update.
8343         * progspace.c (print_program_space): Update.
8344         * process-stratum-target.c
8345         (process_stratum_target::thread_address_space): Update.
8346         * linux-fork.c (linux_fork_mourn_inferior)
8347         (detach_checkpoint_command, info_checkpoints_command)
8348         (linux_fork_context): Update.
8349         (linux_fork_detach): Update.
8350         (class scoped_switch_fork_info): Update.
8351         (delete_checkpoint_command): Update.
8352         * infrun.c (follow_fork_inferior): Update.
8353         (follow_fork_inferior): Update.
8354         (proceed_after_vfork_done): Update.
8355         (handle_vfork_child_exec_or_exit): Update.
8356         (follow_exec): Update.
8357         (displaced_step_prepare_throw): Update.
8358         (displaced_step_restore): Update.
8359         (start_step_over): Update.
8360         (resume_1): Update.
8361         (clear_proceed_status_thread): Update.
8362         (proceed): Update.
8363         (print_target_wait_results): Update.
8364         (do_target_wait): Update.
8365         (context_switch): Update.
8366         (stop_all_threads): Update.
8367         (restart_threads): Update.
8368         (finish_step_over): Update.
8369         (handle_signal_stop): Update.
8370         (switch_back_to_stepped_thread): Update.
8371         (keep_going_pass_signal): Update.
8372         (print_exited_reason): Update.
8373         (normal_stop): Update.
8374         * inferior.c (inferior_pid_to_str): Change return type.
8375         (print_selected_inferior): Update.
8376         (add_inferior): Update.
8377         (detach_inferior): Update.
8378         * dummy-frame.c (fprint_dummy_frames): Update.
8379         * dcache.c (dcache_info_1): Update.
8380         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8381         (btrace_fetch, btrace_clear): Update.
8382         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8383         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8384         type.
8385         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8386         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8387         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8388         * gdbarch.c, gdbarch.h: Rebuild.
8389         * gdbarch.sh (core_pid_to_str): Change return type.
8390         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8391         return type.
8392         (windows_nat_target::pid_to_str): Change return type.
8393         (windows_delete_thread): Update.
8394         (windows_nat_target::attach): Update.
8395         (windows_nat_target::files_info): Update.
8396         * target-delegates.c: Rebuild.
8397         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8398         return type.
8399         (sol_thread_target::pid_to_str): Change return type.
8400         * remote.c (class remote_target) <pid_to_str>: Change return
8401         type.
8402         (remote_target::pid_to_str): Change return type.
8403         (extended_remote_target::attach, remote_target::remote_stop_ns)
8404         (remote_target::remote_notif_remove_queued_reply)
8405         (remote_target::push_stop_reply, remote_target::disable_btrace):
8406         Update.
8407         (extended_remote_target::attach): Update.
8408         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8409         type.
8410         (gdbsim_target::pid_to_str): Change return type.
8411         * ravenscar-thread.c (struct ravenscar_thread_target)
8412         <pid_to_str>: Change return type.
8413         (ravenscar_thread_target::pid_to_str): Change return type.
8414         * procfs.c (class procfs_target) <pid_to_str>: Change return
8415         type.
8416         (procfs_target::pid_to_str): Change return type.
8417         (procfs_target::attach): Update.
8418         (procfs_target::detach): Update.
8419         (procfs_target::fetch_registers): Update.
8420         (procfs_target::store_registers): Update.
8421         (procfs_target::wait): Update.
8422         (procfs_target::files_info): Update.
8423         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8424         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8425         return type.
8426         (nto_procfs_target::pid_to_str): Change return type.
8427         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8428         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8429         return type.
8430         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8431         (exit_lwp): Update.
8432         (attach_proc_task_lwp_callback, get_detach_signal)
8433         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8434         (linux_nat_target::resume, wait_lwp, stop_callback)
8435         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8436         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8437         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8438         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8439         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8440         type.
8441         (inf_ptrace_target::attach): Update.
8442         (inf_ptrace_target::files_info): Update.
8443         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8444         type.
8445         (go32_nat_target::pid_to_str): Change return type.
8446         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8447         (gnu_nat_target::wait): Update.
8448         (gnu_nat_target::wait): Update.
8449         (gnu_nat_target::resume): Update.
8450         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8451         (fbsd_nat_target::wait): Update.
8452         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8453         type.
8454         (darwin_nat_target::attach): Update.
8455         * corelow.c (class core_target) <pid_to_str>: Change return type.
8456         (core_target::pid_to_str): Change return type.
8457         * target.c (normal_pid_to_str): Change return type.
8458         (default_pid_to_str): Likewise.
8459         (target_pid_to_str): Change return type.
8460         (target_translate_tls_address): Update.
8461         (target_announce_detach): Update.
8462         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8463         return type.
8464         (bsd_uthread_target::pid_to_str): Change return type.
8465         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8466         type.
8467         (bsd_kvm_target::pid_to_str): Change return type.
8468         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8469         return type.
8470         (aix_thread_target::pid_to_str): Change return type.
8471         * target.h (struct target_ops) <pid_to_str>: Change return type.
8472         (target_pid_to_str, normal_pid_to_str): Likewise.
8473         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8474         type.
8475         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8476         type.
8477         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8478         return type.
8479         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8480         type.
8481         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8482         type.
8483         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8484         return type.
8485
8486 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8487
8488         * NEWS: Mention that the new default MI version is 3.  Mention
8489         changes to the output of commands and events that deal with
8490         multi-location breakpoints.
8491         * breakpoint.c: Include "mi/mi-out.h".
8492         (print_one_breakpoint): Change output syntax if using MI version
8493         >= 3.
8494         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8495         New.
8496         (mi_multi_location_breakpoint_output_fixed): New.
8497         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8498         (mi_cmd_fix_multi_location_breakpoint_output): New.
8499         (mi_multi_location_breakpoint_output_fixed): New.
8500         * mi/mi-cmds.c (mi_cmds): Register command
8501         -fix-multi-location-breakpoint-output.
8502         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8503         interpreter "mi".
8504
8505 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8506
8507         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8508         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8509         instantiate mi_ui_out based on interpreter name.
8510         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8511         * mi/mi-main.c (mi_load_progress): Likewise.
8512
8513 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8514
8515         * NEWS: Combine separate "New targets" sections for 8.3.
8516
8517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8518
8519         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8520         (ppcfbsd_init_abi): Install gdbarch
8521         "fetch_tls_load_module_address" and "get_thread_local_address"
8522         methods.
8523
8524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8525
8526         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8527         (riscv_fbsd_init_abi): Install gdbarch
8528         "fetch_tls_load_module_address" and "get_thread_local_address"
8529         methods.
8530
8531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8532
8533         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8534         (i386fbsd_init_abi): Install gdbarch
8535         "fetch_tls_load_module_address" and "get_thread_local_address"
8536         methods.
8537
8538 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8539
8540         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8541         (amd64fbsd_init_abi): Install gdbarch
8542         "fetch_tls_load_module_address" and "get_thread_local_address"
8543         methods.
8544
8545 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8546
8547         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8548         (struct fbsd_pspace_data): New type.
8549         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8550         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8551         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8552         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8553         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8554
8555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8556
8557         * gdbtypes.c (lookup_struct_elt): New function.
8558         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8559         * gdbtypes.h (struct struct_elt): New type.
8560         (lookup_struct_elt): New prototype.
8561
8562 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8563
8564         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8565         remove disabled code block.
8566
8567 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8568
8569         * gdbarch.sh (get_thread_local_address): New method.
8570         * gdbarch.h, gdbarch.c: Regenerate.
8571         * target.c (target_translate_tls_address): Use
8572         gdbarch_get_thread_local_address if present instead of
8573         target::get_thread_local_address.
8574
8575 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8576
8577         * target.h (target::get_thread_local_address): Update comment.
8578
8579 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8580
8581         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8582         objfile->separate_debug_objfile_backlink if not NULL.
8583
8584 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8585
8586         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8587         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8588         (amd64bsd_store_inferior_registers): Likewise.
8589         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8590         Enable segment base registers.
8591         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8592         PT_GETFSBASE and PT_GETGSBASE.
8593         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8594         PT_SETGSBASE.
8595         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8596         segment base registers.
8597         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8598
8599 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8600
8601         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8602         Update calls to i386_target_description to add 'segments'
8603         parameter.
8604         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8605         add segment base registers.
8606         * arch/i386.c (i386_create_target_description): Add 'segments'
8607         parameter to enable segment base registers.
8608         * arch/i386.h (i386_create_target_description): Likewise.
8609         * features/i386/32bit-segments.xml: New file.
8610         * features/i386/32bit-segments.c: Generate.
8611         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8612         call to i386_target_description to add 'segments' parameter.
8613         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8614         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8615         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8616         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8617         if feature is present.
8618         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8619         Add 'segments' parameter to call to i386_target_description.
8620         (i386_target_description): Add 'segments' parameter to enable
8621         segment base registers.
8622         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8623         to call to i386_target_description.
8624         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8625         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8626         Define I386_NUM_REGS.
8627         (i386_target_description): Add 'segments' parameter to enable
8628         segment base registers.
8629
8630 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8631
8632         PR/24325
8633         * source-cache.c: #undef open and close, to avoid unresolved
8634         externals during linking.
8635
8636 2019-03-12  Tom Tromey  <tromey@adacore.com>
8637
8638         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8639         const.  Add initializers.
8640         (_initialize_remote): Don't initialize ptid globals.
8641
8642 2019-03-12  Pedro Alves  <palves@redhat.com>
8643
8644         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8645
8646 2019-03-12  Pedro Alves  <palves@redhat.com>
8647
8648         * cp-name-parser.y (main): Remove unused 'len' variable.
8649
8650 2019-03-12  Tom Tromey  <tromey@adacore.com>
8651
8652         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8653         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8654
8655 2019-03-12  Tom Tromey  <tromey@adacore.com>
8656
8657         * linux-nat.c (iterate_over_lwps): Update.
8658         (stop_callback): Remove parameter.
8659         (stop_wait_callback, detach_callback, resume_set_callback)
8660         (select_singlestep_lwp_callback, set_ignore_sigint)
8661         (status_callback, resumed_callback, resume_clear_callback)
8662         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8663         data parameter.
8664         (linux_nat_target::detach, linux_nat_target::resume)
8665         (linux_stop_and_wait_all_lwps, select_event_lwp)
8666         (linux_nat_filter_event, linux_nat_wait_1)
8667         (linux_nat_target::kill, linux_nat_target::stop)
8668         (linux_nat_target::stop): Update.
8669         (linux_nat_resume_callback): Change type.
8670         (resume_stopped_resumed_lwps, count_events_callback)
8671         (select_event_lwp_callback): Likewise.
8672         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8673         * arm-linux-nat.c (struct update_registers_data): Remove.
8674         (update_registers_callback): Change type.
8675         (arm_linux_insert_hw_breakpoint1): Update.
8676         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8677         parameter.
8678         (x86_linux_dr_set_addr): Update.
8679         (x86_linux_dr_set_control): Update.
8680         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8681         (iterate_over_lwps): Use gdb::function_view.
8682         * nat/aarch64-linux-hw-point.c (struct
8683         aarch64_dr_update_callback_param): Remove.
8684         (debug_reg_change_callback): Change type.
8685         (aarch64_notify_debug_reg_change): Update.
8686         * s390-linux-nat.c (s390_refresh_per_info): Update.
8687
8688 2019-03-11  Tom Tromey  <tromey@adacore.com>
8689
8690         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8691         redundant assignment to "this_cu".
8692
8693 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8694
8695         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8696
8697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8698
8699         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8700         from...
8701         (rank_one_type): ... this.
8702
8703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8704
8705         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8706         from...
8707         (rank_one_type): ... this.
8708
8709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8710
8711         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8712         from...
8713         (rank_one_type): ... this.
8714
8715 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8716
8717         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8718         from...
8719         (rank_one_type): ... this.
8720
8721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8722
8723         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8724         from...
8725         (rank_one_type): ... this.
8726
8727 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8728
8729         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8730         from...
8731         (rank_one_type): ... this.
8732
8733 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8734
8735         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8736         from...
8737         (rank_one_type): ... this.
8738
8739 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8740
8741         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8742         from...
8743         (rank_one_type): ... this.
8744
8745 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8746
8747         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8748         from...
8749         (rank_one_type): ... this.
8750
8751 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8752
8753         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8754         from...
8755         (rank_one_type): ... this.
8756
8757 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8758
8759         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8760         from...
8761         (rank_one_type): ... this.
8762
8763 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8764
8765         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8766         from...
8767         (rank_one_type): ... this.
8768
8769 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8770
8771         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8772         inferior-events' shows the example events.
8773
8774 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8775
8776         Support styling on native MS-Windows console
8777
8778         PR/24315
8779         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8780         on MS-Windows if $TERM is not defined.
8781
8782         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8783
8784         * posix-hdep.c (gdb_console_fputs):
8785         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8786         functions.
8787         * ui-file.h (gdb_console_fputs): Add prototype.
8788
8789         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8790         back to fputs only if the former returns zero.
8791
8792 2019-03-07  Tom Tromey  <tom@tromey.com>
8793
8794         * symmisc.c (print_symbol_bcache_statistics): Update.
8795         (print_objfile_statistics): Update.
8796         * symfile.c (allocate_symtab): Update.
8797         * stabsread.c: Don't include bcache.h.
8798         * psymtab.h (struct psymbol_bcache): Don't declare.
8799         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8800         (psymbol_bcache_init, psymbol_bcache_free)
8801         (psymbol_bcache_get_bcache): Don't declare.
8802         * psymtab.c (struct psymbol_bcache): Remove.
8803         (psymtab_storage::psymtab_storage): Update.
8804         (psymtab_storage::~psymtab_storage): Update.
8805         (psymbol_bcache_init, psymbol_bcache_free)
8806         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8807         (add_psymbol_to_bcache): Update.
8808         (allocate_psymtab): Update.
8809         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8810         macro_cache>: No longer pointers.
8811         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8812         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8813         * macrotab.c (macro_bcache): Update.
8814         * macroexp.c: Don't include bcache.h.
8815         * gdbtypes.c (check_types_worklist): Update.
8816         (types_deeply_equal): Remove TRY/CATCH.  Update.
8817         * elfread.c (elf_symtab_read): Update.
8818         * dwarf2read.c: Don't include bcache.h.
8819         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8820         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8821         (print_bcache_statistics, bcache_memory_used): Don't declare.
8822         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8823         methods.  Rename all data members.
8824         * bcache.c (struct bcache): Move to bcache.h.
8825         (bcache::expand_hash_table): Rename from expand_hash_table.
8826         (bcache): Remove.
8827         (bcache::insert): Rename from bcache_full.
8828         (bcache::compare): Rename from bcache_compare.
8829         (bcache_xmalloc): Remove.
8830         (bcache::~bcache): Rename from bcache_xfree.
8831         (bcache::print_statistics): Rename from print_bcache_statistics.
8832         (bcache::memory_used): Rename from bcache_memory_used.
8833
8834 2019-03-07  Pedro Alves  <palves@redhat.com>
8835
8836         * infrun.c (normal_stop): Also check for
8837         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8838
8839 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8840
8841         * f-lang.c (value_from_host_double): Moved to...
8842         * value.c (value_from_host_double): ...here.
8843         * value.h (value_from_host_double): Declare.
8844         * guile/scm-math.c (vlscm_convert_typed_number): Use
8845         value_from_host_double.
8846         (vlscm_convert_number): Likewise.
8847         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8848         * python/py-value.c (convert_value_from_python): Likewise.
8849
8850 2019-03-06  Tom Tromey  <tom@tromey.com>
8851
8852         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8853
8854 2019-03-06  Tom Tromey  <tom@tromey.com>
8855
8856         * utils.h (free_current_contents): Don't declare.
8857         * utils.c (free_current_contents): Remove.
8858
8859 2019-03-06  Tom Tromey  <tom@tromey.com>
8860
8861         * top.c (quit_force): Update.
8862         * main.c (captured_command_loop): Update.
8863         * common/new-op.c (operator new): Update.
8864         * common/common-exceptions.c (struct catcher)
8865         <save_cleanup_chain>: Remove member.
8866         (exceptions_state_mc_init): Update.
8867         (exception_try_scope_entry): Return nullptr.
8868         (exception_try_scope_exit, exception_rethrow)
8869         (throw_exception_sjlj, throw_exception_cxx): Update.
8870         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8871         (all_cleanups, do_cleanups, discard_cleanups)
8872         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8873         (restore_cleanups, restore_final_cleanups): Don't declare.
8874         (do_final_cleanups): Remove parameter.
8875         * common/cleanups.c (cleanup_chain, make_cleanup)
8876         (make_cleanup_dtor, all_cleanups, do_cleanups)
8877         (discard_my_cleanups, discard_cleanups)
8878         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8879         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8880         (null_cleanup): Remove.
8881         (do_final_cleanups): Remove parameter.
8882
8883 2019-03-06  Tom Tromey  <tom@tromey.com>
8884
8885         * remote.c (remote_target::remote_parse_stop_reply): Use
8886         unique_xmalloc_ptr.
8887
8888 2019-03-06  Tom Tromey  <tom@tromey.com>
8889
8890         * stabsread.c (struct stabs_field_info): Rename from field_info.
8891         <list, fnlist>: Add initializers.
8892         <obstack>: New member.
8893         (read_member_functions, read_struct_fields, read_baseclasses):
8894         Allocate on obstack.  Don't use cleanups.
8895         (read_one_struct_field, read_member_functions, read_struct_fields)
8896         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8897         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8898         (read_struct_type): Update.
8899
8900 2019-03-06  Tom Tromey  <tom@tromey.com>
8901
8902         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8903         * common/filestuff.h (make_cleanup_close): Don't declare.
8904         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8905         Remove.
8906
8907 2019-03-06  Tom Tromey  <tom@tromey.com>
8908
8909         * solib-aix.c: Use make_scope_exit.
8910
8911 2019-03-06  Tom Tromey  <tom@tromey.com>
8912
8913         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8914         Use make_scope_exit.
8915
8916 2019-03-06  Tom Tromey  <tom@tromey.com>
8917
8918         * solib-svr4.c (disable_probes_interface): Remove parameter.
8919         (svr4_handle_solib_event): Use make_scope_exit.
8920
8921 2019-03-06  Tom Tromey  <tom@tromey.com>
8922
8923         * remote.c (struct stop_reply_deleter): Remove.
8924         (stop_reply_up): Update.
8925         (struct stop_reply): Derive from notif_event.  Don't typedef.
8926         <regcache>: Now a std::vector.
8927         (stop_reply_xfree): Remove.
8928         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8929         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8930         (remote_target::discard_pending_stop_replies): Use delete.
8931         (remote_target::remote_parse_stop_reply): Update.
8932         (remote_target::process_stop_reply): Update.
8933         * remote-notif.h (struct notif_event): Add virtual destructor.
8934         Remove "dtr" member.
8935         (struct notif_client) <alloc_event>: Return a unique_ptr.
8936         (notif_event_xfree): Don't declare.
8937         (notif_event_up): New typedef.
8938         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8939         (notif_event_xfree, do_notif_event_xfree): Remove.
8940         (remote_notif_state_xfree): Update.
8941
8942 2019-03-06  Tom Tromey  <tom@tromey.com>
8943
8944         * infrun.c (displaced_step_clear_cleanup): Now a
8945         forward_scope_exit type.
8946         (displaced_step_prepare_throw): Update.
8947         (displaced_step_fixup): Update.
8948
8949 2019-03-06  Tom Tromey  <tom@tromey.com>
8950
8951         * inferior.h (class inferior): Update comment.
8952         * gdbthread.h (class thread_info): Update comment.
8953
8954 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8955             Tom Tromey  <tom@tromey.com>
8956
8957         * stabsread.h (struct stab_section_list): Remove.
8958         (coffstab_build_psymtabs): Update.
8959         * dbxread.c (symbuf_sections): Now a std::vector.
8960         (sect_idx): New global.
8961         (fill_symbuf): Update.
8962         (coffstab_build_psymtabs): Change type of stabsects parameter.
8963         Update.
8964         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8965         std::vector.
8966         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8967         (coff_locate_sections): Update.
8968         (coff_symfile_read): Remove cleanups.  Update.
8969         (init_stringtab): Add storage parameter.
8970         (free_stringtab, free_stringtab_cleanup): Remove.
8971         (init_lineno): Add storage parameter.
8972         (free_linetab, free_linetab_cleanup): Remove.
8973
8974 2019-03-06  Pedro Alves  <palves@redhat.com>
8975
8976         * linux-fork.c (fork_info::clobber_regs): Delete.
8977         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8978         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8979         comment.  Adjust.
8980         (scoped_switch_fork_info::scoped_switch_fork_info)
8981         (checkpoint_command, linux_fork_context): Adjust
8982         fork_save_infrun_state calls.
8983
8984 2019-03-06  Pedro Alves  <palves@redhat.com>
8985
8986         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8987         (inf_has_multiple_threads): Return 'bool' and rewrite using
8988         inferior_info::threads().
8989
8990 2019-03-06  Pedro Alves  <palves@redhat.com>
8991
8992         * linux-fork.c: Include <list>.
8993         (fork_list): Now a std::list instance.
8994         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8995         (forks_exist_p, find_last_fork): Adjust.
8996         (new_fork): Delete.
8997         (one_fork_p): New.
8998         (add_fork): Adjust.
8999         (free_fork): Delete, folded into fork_info::~fork_info().
9000         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9001         Adjust.
9002         (init_fork_list): Delete.
9003         (linux_fork_killall, linux_fork_mourn_inferior)
9004         (linux_fork_detach, info_checkpoints_command): Adjust.
9005         (_initialize_linux_fork): No longer call init_fork_list.
9006
9007 2019-03-06  Pedro Alves  <palves@redhat.com>
9008
9009         * linux-fork.c (new_fork): New, split out of ...
9010         (add_fork): ... this.  Return void.  Move "first fork" special
9011         case from here, to ...
9012         (checkpoint_command): ... here.
9013         * linux-linux.h (add_fork): Return void.
9014
9015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9016
9017         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9018
9019 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9020             Chris January  <chris.january@arm.com>
9021             David Lecomber  <david.lecomber@arm.com>
9022
9023         * f-exp.y: New token, UNOP_INTRINSIC.
9024         (exp): New pattern using UNOP_INTRINSIC token.
9025         (f77_keywords): Add 'abs' keyword.
9026         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9027         (value_from_host_double): New function.
9028         (evaluate_subexp_f): Support UNOP_ABS.
9029
9030 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9031
9032         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9033         types.
9034
9035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9036
9037         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9038         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9039         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9040
9041 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9042
9043         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9044
9045 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9046             Chris January  <chris.january@arm.com>
9047
9048         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9049         * f-exp.y: Define 'KIND' token.
9050         (exp): New pattern for KIND expressions.
9051         (ptype): Handle types with a kind extension.
9052         (direct_abs_decl): Extend to spot kind extensions.
9053         (f77_keywords): Add 'kind' to the list.
9054         (push_kind_type): New function.
9055         (convert_to_kind_type): New function.
9056         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9057         * parse.c (operator_length_standard): Likewise.
9058         * parser-defs.h (enum type_pieces): Add tp_kind.
9059         * std-operator.def: Add UNOP_KIND.
9060
9061 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9062
9063         * f-exp.y (f_parse): Set yydebug.
9064
9065 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9066
9067         * f-lang.c (evaluate_subexp_f): New function.
9068         (exp_descriptor_f): New global.
9069         (f_language_defn): Use exp_descriptor_f instead of
9070         exp_descriptor_standard.
9071
9072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9073
9074         * f-exp.y (struct token): Add comments.
9075         (dot_ops): Remove uppercase versions and the end marker.
9076         (f77_keywords): Likewise.
9077         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9078         entries in the dot_ops array are case insensitive, and use
9079         strncasecmp to compare strings.  Also some whitespace cleanup in
9080         this area.  Similar for the f77_keywords array, except entries in
9081         this list might be case sensitive.
9082
9083 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9084
9085         * f-exp.y (struct f77_boolean_val): Add comments.
9086         (boolean_values): Remove uppercase versions, and end marker.
9087         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9088         and use strncasecmp to achieve case insensitivity.  Additionally,
9089         perform whitespace cleanup around this code.
9090
9091 2019-03-06  Tom Tromey  <tromey@adacore.com>
9092
9093         * remote-sim.c (gdbsim_target_open): Use result of
9094         gdb_argv::release.
9095
9096 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9097         Dirk Schubert  <dirk.schubert@arm.com>
9098         Chris January  <chris.january@arm.com>
9099
9100         * eval.c (evaluate_subexp_standard): Call Fortran argument
9101         wrapping logic.
9102         * f-lang.c (struct value): A value which can be passed into a
9103         Fortran function call.
9104         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9105         where appropriate.
9106         (struct type): Value ready for a Fortran function call.
9107         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9108         is needed.
9109         * f-lang.h (fortran_argument_convert): Declaration.
9110         (fortran_preserve_arg_pointer): Declaration.
9111         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9112
9113 2019-03-05  Tom Tromey  <tromey@adacore.com>
9114
9115         * python/py-prettyprint.c (print_string_repr): Remove #if.
9116         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9117
9118 2019-03-05  Tom Tromey  <tromey@adacore.com>
9119
9120         * target.c (the_dummy_target): Move later.  Change type to
9121         "dummy_target".
9122         (initialize_targets): Don't initialize the_dummy_target.
9123
9124 2019-03-05  Tom Tromey  <tromey@adacore.com>
9125
9126         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9127         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9128
9129 2019-03-05  Tom Tromey  <tromey@adacore.com>
9130
9131         * windows-nat.c (windows_nat_target::attach)
9132         (windows_nat_target::detach): Don't call gdb_flush.
9133         * valprint.c (generic_val_print, val_print, val_print_string):
9134         Don't call gdb_flush.
9135         * utils.c (defaulted_query): Don't call gdb_flush.
9136         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9137         * target.c (target_announce_detach): Don't call gdb_flush.
9138         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9139         * remote.c (extended_remote_target::attach): Don't call
9140         gdb_flush.
9141         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9142         * printcmd.c (do_examine): Don't call gdb_flush.
9143         (info_display_command): Don't call gdb_flush.
9144         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9145         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9146         * memattr.c (info_mem_command): Don't call gdb_flush.
9147         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9148         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9149         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9150         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9151         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9152         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9153         (gnu_nat_target::detach): Don't call gdb_flush.
9154         * f-valprint.c (f_val_print): Don't call gdb_flush.
9155         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9156         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9157         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9158         gdb_flush.
9159         * c-valprint.c (c_val_print): Don't call gdb_flush.
9160         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9161
9162 2019-03-05  Tom Tromey  <tromey@adacore.com>
9163
9164         * varobj.c (update_dynamic_varobj_children): Update.
9165         (install_default_visualizer): Use reset, not release.
9166         * value.c (set_internalvar): Update.
9167         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9168         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9169         ATTRIBUTE_UNUSED_RESULT.
9170
9171 2019-03-05  Tom Tromey  <tromey@adacore.com>
9172
9173         * remote.c (class scoped_remote_fd) <release>: Add
9174         ATTRIBUTE_UNUSED_RESULT.
9175
9176 2019-03-05  Tom Tromey  <tromey@adacore.com>
9177
9178         * macroexp.c (struct macro_buffer) <release>: Add
9179         ATTRIBUTE_UNUSED_RESULT.
9180
9181 2019-03-05  Tom Tromey  <tromey@adacore.com>
9182
9183         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9184         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9185         ATTRIBUTE_UNUSED_RESULT.
9186
9187 2019-03-05  Tom Tromey  <tromey@adacore.com>
9188
9189         * common/scoped_fd.h (class scoped_fd) <release>: Add
9190         ATTRIBUTE_UNUSED_RESULT.
9191
9192 2019-03-05  Tom Tromey  <tromey@adacore.com>
9193
9194         * parser-defs.h (struct parser_state) <release>: Add
9195         ATTRIBUTE_UNUSED_RESULT.
9196
9197 2019-03-05  Tom Tromey  <tromey@adacore.com>
9198
9199         * utils.h (class gdb_argv) <release>: Add
9200         ATTRIBUTE_UNUSED_RESULT.
9201         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9202
9203 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9204
9205         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9206         for-loop range, to avoid compiler warnings.
9207
9208         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9209         avoid compiler warnings about unused variables.
9210
9211         * NEWS: Mention end of support for native debugging on MS-Windows
9212         before XP.
9213
9214         PR gdb/24292
9215         * common/netstuff.c:
9216         * gdbserver/gdbreplay.c
9217         * gdbserver/remote-utils.c:
9218         * ser-tcp.c:
9219         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9220         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9221         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9222         'getaddrinfo' and 'freeaddrinfo' were not available before
9223         Windows XP, and mingw.org's MinGW headers by default define
9224         _WIN32_WINNT to 0x500.
9225
9226 2019-03-01  Gary Benson <gbenson@redhat.com>
9227
9228         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9229
9230 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9231             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9232
9233         PR gdb/8527
9234         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9235         set_sigint_trap, clear_sigint_trap.
9236
9237 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9238
9239         * target.c (target_detach): Clear the regcache and the
9240         frame cache.
9241
9242 2019-02-27  Pedro Alves  <palves@redhat.com>
9243
9244         * utils.c (set_screen_size): When we cap the height/width sizes,
9245         tweak the corresponding command variable to show "unlimited":
9246
9247 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9248             Pedro Alves  <palves@redhat.com>
9249
9250         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9251         before calling rl_set_screen_size.
9252
9253 2019-02-27  Tom Tromey  <tromey@adacore.com>
9254
9255         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9256         define.
9257         * python/py-value.c: Remove Python 2.4 workaround.
9258         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9259         workaround.
9260         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9261         Python 2.4 workaround.
9262         * python/python-internal.h: Remove Python 2.4 comment.
9263         (Py_ssize_t): Don't define.
9264         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9265         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9266         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9267         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9268         * python/python.c (do_start_initialization): Remove Python 2.4
9269         workaround.
9270         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9271         (print_children): Remove Python 2.4 workaround.
9272         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9273         workaround.
9274         (CHARBUFFERPROC_NAME): Remove.
9275         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9276         Python 2.4 workaround.
9277
9278 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9279
9280         * NEWS: Note minimum Python version.
9281
9282 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9283
9284         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9285         code from these functions.  Remove corresponding ifdefs.  Use
9286         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9287         Remove gotos and target of gotos.
9288         (infpy_search_memory): Likewise.
9289
9290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9291
9292         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9293         (hppa_gdbarch_init): Don't register deleted functions with
9294         gdbarch.
9295
9296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9297
9298         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9299         (h8300_unwind_sp): Delete.
9300         (h8300_dummy_id): Delete.
9301         (h8300_gdbarch_init): Don't register deleted functions with
9302         gdbarch.
9303
9304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9305
9306         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9307         (ft32_unwind_pc): Delete.
9308         (ft32_unwind_sp): Delete.
9309         (ft32_gdbarch_init): Don't register deleted functions with
9310         gdbarch.
9311
9312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9315         (frv_unwind_pc): Delete.
9316         (frv_unwind_sp): Delete.
9317         (frv_gdbarch_init): Don't register deleted functions with
9318         gdbarch.
9319
9320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9323         (riscv_unwind_pc): Delete.
9324         (riscv_unwind_sp): Delete.
9325         (riscv_gdbarch_init): Don't register deleted functions with
9326         gdbarch.
9327
9328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9329
9330         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9331         (csky_unwind_pc): Delete.
9332         (csky_unwind_sp): Delete.
9333         (csky_gdbarch_init): Don't register deleted functions with
9334         gdbarch.
9335
9336 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9337
9338         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9339         (cris_unwind_pc): Delete.
9340         (cris_unwind_sp): Delete.
9341         (cris_gdbarch_init): Don't register deleted functions with
9342         gdbarch.
9343
9344 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9347         (bfin_unwind_pc): Delete.
9348         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9349
9350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9353         (arm_unwind_pc): Delete.
9354         (arm_unwind_sp): Delete.
9355         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9356
9357 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9360         (arc_unwind_pc): Delete.
9361         (arc_unwind_sp): Delete.
9362         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9363
9364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9365
9366         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9367         (alpha_unwind_pc): Delete.
9368         (alpha_gdbarch_init): Don't register deleted functions with
9369         gdbarch.
9370
9371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9372
9373         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9374         (aarch64_unwind_pc): Delete.
9375         (aarch64_unwind_sp): Delete.
9376         (aarch64_gdbarch_init): Don't register deleted functions with
9377         gdbarch.
9378
9379 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9380
9381         * gdbtypes.c (type_align): Don't consider static members when
9382         computing structure alignment.
9383
9384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9385
9386         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9387         return 0 for other types.
9388         * arch-utils.c (default_type_align): Always return 0.
9389         * gdbarch.h: Regenerate.
9390         * gdbarch.sh (type_align): Extend comment.
9391         * gdbtypes.c (type_align): Add additional comments, always call
9392         gdbarch_type_align before applying the default rules.
9393         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9394         generic code will then apply a suitable default.
9395         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9396         types, return 0 for other types.
9397
9398 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9399
9400         * NEWS: Create a new section for the next release branch.
9401         Rename the section of the current branch, now that it has
9402         been cut.
9403
9404 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9405
9406         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9407         * version.in: Bump version to 8.3.50.DATE-git.
9408
9409 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9410
9411         * aix-thread.c (ptid_cmp): Remove unused variable.
9412         (get_signaled_thread): Likewise.
9413         (store_regs_user_thread): Likewise.
9414         (store_regs_kernel_thread): Likewise.
9415         (fetch_regs_kernel_thread): Remove shadowed variable.
9416
9417 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9418
9419         * features/riscv/32bit-cpu.xml: Add register numbers.
9420         * features/riscv/32bit-fpu.c: Regenerate.
9421         * features/riscv/32bit-fpu.xml: Add register numbers.
9422         * features/riscv/64bit-cpu.xml: Add register numbers.
9423         * features/riscv/64bit-fpu.c: Regenerate.
9424         * features/riscv/64bit-fpu.xml: Add register numbers.
9425
9426 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9427
9428         * NEWS: Mention two argument form of gdb.Value constructor.
9429         * python/py-value.c (convert_buffer_and_type_to_value): New
9430         function.
9431         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9432         Add support for handling an optional second argument.  Call
9433         convert_buffer_and_type_to_value as appropriate.
9434         * python/python-internal.h (Py_buffer_deleter): New struct.
9435         (Py_buffer_up): New typedef.
9436
9437 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9438
9439         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9440         instead of releasing ownership.
9441
9442 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9443
9444         * dwarf2read.c (open_and_init_dwp_file): Call
9445         elf_numsections instead of bfd_count_sections to initialize
9446         dwp_file->num_sections.
9447
9448 2019-02-25  Tom Tromey  <tromey@adacore.com>
9449
9450         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9451
9452 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9453
9454         * gcore.in: Add '--readnever' option when invoking GDB.
9455
9456 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9457
9458         * MAINTAINERS: Update my email address.
9459
9460 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9461
9462         * build-id.c (build_id_to_debug_bfd_1): New function.
9463         (build_id_to_debug_bfd): Look for separate debug file in
9464         sysroot.
9465
9466 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9467
9468         * gdbarch.sh: Update the copyright year range that is placed into
9469         generated files.
9470
9471 2019-02-22  Keith Seitz  <keiths@redhat.com>
9472
9473         PR symtab/23853
9474         * linespec.c (create_sals_line_offset): Search for the default
9475         symtab's filename instead of its fullname.
9476
9477 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9478
9479         * NEWS: Update style defaults.
9480
9481 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9482
9483         * main.c (captured_main_1): Disable styling in batch mode.
9484
9485 2019-02-20  Tom Tromey  <tom@tromey.com>
9486
9487         * symtab.c (symtab_symbol_info): Fix typos.
9488
9489 2019-02-20  Tom Tromey  <tromey@adacore.com>
9490
9491         * findcmd.c (_initialize_mem_search): Use upper case for
9492         metasyntactic variables.
9493
9494 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9495
9496         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9497         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9498
9499 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9500
9501         * top.h (source_file_name): Change to std::string.
9502         * top.c (source_file_name): Likewise.
9503         (command_line_input): Adjust.
9504         * cli/cli-script.c (script_from_file): Adjust.
9505
9506 2019-02-19  Tom Tromey  <tromey@adacore.com>
9507
9508         * ravenscar-thread.c
9509         (ravenscar_thread_target::update_thread_list): Don't call
9510         ada_build_task_list.
9511         * ada-lang.h (ada_build_task_list): Don't declare.
9512         * ada-tasks.c (struct ada_tasks_inferior_data)
9513         <task_list_valid_p>: Now bool.
9514         (read_known_tasks, ada_task_list_changed)
9515         (ada_tasks_invalidate_inferior_data): Update.
9516         (read_known_tasks_array): Return bool.
9517         (read_known_tasks_list): Likewise.
9518         (read_known_tasks): Return void.
9519         (ada_build_task_list): Now static.
9520
9521 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9522
9523         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9524         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9525
9526 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9527
9528         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9529         variant for ada_tasks_pspace_data_handle and
9530         ada_tasks_inferior_data_handle.
9531         (ada_tasks_pspace_data_cleanup): New function.
9532         (ada_tasks_inferior_data_cleanup): New function.
9533
9534 2019-02-17  Tom Tromey  <tom@tromey.com>
9535
9536         * macrotab.h (macro_source_fullname): Return a std::string.
9537         * macrotab.c (macro_include, check_for_redefinition)
9538         (macro_undef, macro_lookup_definition, foreach_macro)
9539         (foreach_macro_in_scope): Update.
9540         (macro_source_fullname): Return a std::string.
9541         * macrocmd.c (show_pp_source_pos): Update.
9542
9543 2019-02-17  Tom Tromey  <tom@tromey.com>
9544
9545         * macrocmd.c (show_pp_source_pos): Style the file names.
9546
9547 2019-02-17  Tom Tromey  <tom@tromey.com>
9548
9549         PR tui/24197:
9550         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9551
9552 2019-02-17  Tom Tromey  <tom@tromey.com>
9553
9554         * ada-lang.c (user_select_syms): Use filtered printing.
9555         * utils.c (wrap_style): New global.
9556         (desired_style): Remove.
9557         (emit_style_escape): Add stream parameter.
9558         (set_output_style, reset_terminal_style, prompt_for_continue):
9559         Update.
9560         (flush_wrap_buffer): Only flush gdb_stdout.
9561         (wrap_here): Set wrap_style.
9562         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9563         treat escape sequences as a character.  Change when wrap buffer is
9564         flushed.
9565         (fputs_styled): Do not set the output style when the default is
9566         requested.
9567         * ui-style.h (struct ui_file_style) <is_default>: New method.
9568         * source.c (print_source_lines_base): Emit escape sequences in one
9569         piece.
9570
9571 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9572
9573         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9574         integers and enumeration types.
9575
9576 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9577
9578         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9579         instead of lookup_symbol_in_language
9580         (do_exact_match): New function.
9581         (ada_get_symbol_name_matcher): Return do_exact_match when
9582         doing a verbatim match.
9583
9584 2019-02-15  Tom Tromey  <tromey@adacore.com>
9585
9586         * ravenscar-thread.c (ravenscar_thread_target::resume)
9587         (ravenscar_thread_target::wait): Special case wildcard requests.
9588
9589 2019-02-15  Tom Tromey  <tromey@adacore.com>
9590
9591         * ravenscar-thread.c (base_ptid): Remove.
9592         (struct ravenscar_thread_target) <close>: New method.
9593         <m_base_ptid>: New member.
9594         <update_inferior_ptid, active_task, task_is_currently_active,
9595         runtime_initialized>: Declare methods.
9596         <ravenscar_thread_target>: Add constructor.
9597         (ravenscar_thread_target::task_is_currently_active)
9598         (ravenscar_thread_target::update_inferior_ptid)
9599         (ravenscar_runtime_initialized): Rename.  Now methods.
9600         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9601         (ravenscar_thread_target::update_thread_list): Update.
9602         (ravenscar_thread_target::active_task): Now method.
9603         (ravenscar_thread_target::store_registers)
9604         (ravenscar_thread_target::prepare_to_store)
9605         (ravenscar_thread_target::prepare_to_store)
9606         (ravenscar_thread_target::mourn_inferior): Update.
9607         (ravenscar_inferior_created): Use "new" to create target.
9608         (ravenscar_thread_target::get_ada_task_ptid): Update.
9609         (_initialize_ravenscar): Don't initialize base_ptid.
9610         (ravenscar_ops): Remove global.
9611
9612 2019-02-15  Tom Tromey  <tromey@adacore.com>
9613
9614         * target.h (push_target): Declare new overload.
9615         * target.c (push_target): New overload, taking an rvalue reference.
9616         * remote.c (remote_target::open_1): Use push_target overload.
9617         * corelow.c (core_target_open): Use push_target overload.
9618
9619 2019-02-15  Tom Tromey  <tromey@adacore.com>
9620
9621         * ravenscar-thread.c (is_ravenscar_task)
9622         (ravenscar_task_is_currently_active): Return bool.
9623         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9624         (_initialize_ravenscar): Remove "(void)".
9625         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9626         Return bool.
9627
9628 2019-02-15  Tom Tromey  <tromey@adacore.com>
9629
9630         * ravenscar-thread.c (ravenscar_runtime_initializer)
9631         (has_ravenscar_runtime, get_running_thread_id)
9632         (ravenscar_thread_target::resume): Fix indentation.
9633
9634 2019-02-15  Tom Tromey  <tromey@adacore.com>
9635
9636         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9637         from ravenscar_arch_ops.
9638         (sparc_ravenscar_ops::fetch_registers)
9639         (sparc_ravenscar_ops::store_registers): Now methods.
9640         (sparc_ravenscar_prepare_to_store): Remove.
9641         (sparc_ravenscar_ops): Redefine.
9642         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9643         methods and destructor.  Remove members.
9644         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9645         (ravenscar_thread_target::store_registers)
9646         (ravenscar_thread_target::prepare_to_store): Update.
9647         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9648         Remove.
9649         (struct ppc_ravenscar_powerpc_ops): Derive from
9650         ravenscar_arch_ops.
9651         (ppc_ravenscar_powerpc_ops::fetch_registers)
9652         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9653         (ppc_ravenscar_powerpc_ops): Redefine.
9654         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9655         (ppc_ravenscar_e500_ops::fetch_registers)
9656         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9657         (ppc_ravenscar_e500_ops): Redefine.
9658         * aarch64-ravenscar-thread.c
9659         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9660         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9661         (aarch64_ravenscar_fetch_registers)
9662         (aarch64_ravenscar_store_registers): Now methods.
9663         (aarch64_ravenscar_ops): Redefine.
9664
9665 2019-02-15  Tom Tromey  <tromey@adacore.com>
9666
9667         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9668         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9669         (ravenscar_thread_target::stopped_by_watchpoint)
9670         (ravenscar_thread_target::stopped_data_address)
9671         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9672
9673 2019-02-15  Tom Tromey  <tromey@adacore.com>
9674
9675         * ravenscar-thread.c: Fix some typos.
9676
9677 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9678             Tom Tromey  <tromey@adacore.com>
9679
9680         * ada-lang.c (ada_exception_sal): Change addr_string to a
9681         std::string.
9682         (create_ada_exception_catchpoint): Update.
9683
9684 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9685             Tom Tromey  <tromey@adacore.com>
9686
9687         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9688         (bp_location_ops): Remove.
9689         (base_breakpoint_allocate_location): Update.
9690         (free_bp_location): Update.
9691         * ada-lang.c (class ada_catchpoint_location)
9692         <ada_catchpoint_location>: Remove ops parameter.
9693         (ada_catchpoint_location_dtor): Remove.
9694         (ada_catchpoint_location_ops): Remove.
9695         (allocate_location_exception): Update.
9696         * breakpoint.h (struct bp_location_ops): Remove.
9697         (class bp_location) <bp_location>: Remove bp_location_ops
9698         parameter.
9699         <~bp_location>: Add destructor.
9700         <ops>: Remove.
9701
9702 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9703             Pedro Alves  <palves@redhat.com>
9704
9705         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9706         'PATH_MAX'.
9707
9708 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9709             Samuel Thibault  <samuel.thibault@gnu.org>
9710             Thomas Schwinge  <thomas@codesourcery.com>
9711
9712         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9713         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9714
9715 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9716
9717         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9718         (check_empty): Use "const char *".
9719
9720         * gnu-nat.c (gnu_nat_target::detach): Instead of
9721         'detach_inferior (pid)' call
9722         'detach_inferior (find_inferior_pid (pid))'.
9723
9724         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9725         'nat/fork-inferior.o'.
9726         * gnu-nat.c: #include "nat/fork-inferior.h".
9727
9728         * gnu-nat.c (gnu_nat_target::detach): Instead of
9729         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9730         * gnu-nat.h: #include "inf-child.h".
9731         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9732         'i386_gnu_nat_target::fetch_registers'.
9733         (gnu_store_registers): Rename/move to
9734         'i386_gnu_nat_target::store_registers'.
9735
9736         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9737         * gnu-nat.h (mach_thread_info): New function.
9738         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9739
9740         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9741
9742 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9743
9744         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9745
9746 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9747
9748         * windows-nat.c (windows_add_thread): Add new parameter
9749         "main_thread_p" with default value set to false.  Update
9750         function documentation as well as all callers.
9751         (windows_delete_thread): Likewise.
9752         (fake_create_process): Update call to windows_add_thread.
9753         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9754         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9755         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9756         call to windows_delete_thread.
9757
9758 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9759
9760         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9761
9762 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9763
9764         * symfile.c (find_separate_debug_file): Use canonical path of
9765         sysroot with child_path instead of gdb_sysroot if it is valid.
9766
9767 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9768
9769         * symfile.c (find_separate_debug_file): Use child_path to
9770         determine if an object file is under a sysroot.
9771
9772 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9773
9774         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9775         unittests/child-path-selftests.c.
9776         * common/pathstuff.c (child_path): New function.
9777         * common/pathstuff.h (child_path): New prototype.
9778         * unittests/child-path-selftests.c: New file.
9779
9780 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9781
9782         * symfile.c (find_separate_debug_file): Look for separate debug
9783         files in debug directories under the sysroot.
9784
9785 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9786
9787         * symtab.h (struct minimal_symbol data_p): New const method.
9788         (struct minimal_symbol text_p): Likewise.
9789         * symtab.c (output_source_filename): Use file name style
9790         to print file name.
9791         (print_symbol_info): Likewise.
9792         (print_msymbol_info): Use address style to print addresses.
9793         Use function name style to print executable text symbols.
9794         (expand_symtab_containing_pc): Use data_p.
9795         (find_pc_sect_compunit_symtab): Likewise.
9796
9797 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9798
9799         * breakpoint.c (describe_other_breakpoints): Use address style
9800         to print addresses.
9801         (say_where): Likewise.
9802
9803 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9804
9805         * ada-typeprint.c (print_func_type): Print function name
9806         style to print function name.
9807         * c-typeprint.c (c_print_type_1): Likewise.
9808
9809 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9810
9811         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9812         for execve.
9813
9814 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9815
9816         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9817         type_stack.
9818
9819 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9820
9821         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9822         TYPE_CODE_REF types.
9823
9824 2019-02-08  Jim Wilson  <jimw@sifive.com>
9825
9826         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9827         (riscv_linux_fregset): New.
9828         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9829
9830 2019-02-07  Tom Tromey  <tom@tromey.com>
9831
9832         * thread.c (thread_cancel_execution_command): Update.
9833         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9834         methods.
9835         (struct thread_fsm_ops): Remove.
9836         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9837         (thread_fsm_should_stop, thread_fsm_return_value)
9838         (thread_fsm_set_finished, thread_fsm_finished_p)
9839         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9840         Don't declare.
9841         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9842         * infrun.c (clear_proceed_status_thread)
9843         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9844         (print_stop_event): Update.
9845         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9846         Add constructor.
9847         (step_command_fsm_ops): Remove.
9848         (new_step_command_fsm): Remove.
9849         (step_1): Update.
9850         (step_command_fsm::should_stop): Rename from
9851         step_command_fsm_should_stop.
9852         (step_command_fsm::clean_up): Rename from
9853         step_command_fsm_clean_up.
9854         (step_command_fsm::do_async_reply_reason): Rename from
9855         step_command_fsm_async_reply_reason.
9856         (struct until_next_fsm): Inherit from thread_fsm.  Add
9857         constructor.
9858         (until_next_fsm_ops): Remove.
9859         (new_until_next_fsm): Remove.
9860         (until_next_fsm::should_stop): Rename from
9861         until_next_fsm_should_stop.
9862         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9863         (until_next_fsm::do_async_reply_reason): Rename from
9864         until_next_fsm_async_reply_reason.
9865         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9866         constructor.  Change type of breakpoint.
9867         (finish_command_fsm_ops): Remove.
9868         (new_finish_command_fsm): Remove.
9869         (finish_command_fsm::should_stop): Rename from
9870         finish_command_fsm_should_stop.
9871         (finish_command_fsm::clean_up): Rename from
9872         finish_command_fsm_clean_up.
9873         (finish_command_fsm::return_value): Rename from
9874         finish_command_fsm_return_value.
9875         (finish_command_fsm::do_async_reply_reason): Rename from
9876         finish_command_fsm_async_reply_reason.
9877         (finish_command): Update.
9878         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9879         Add constructor.
9880         (call_thread_fsm_ops): Remove.
9881         (call_thread_fsm::call_thread_fsm): Rename from
9882         new_call_thread_fsm.
9883         (call_thread_fsm::should_stop): Rename from
9884         call_thread_fsm_should_stop.
9885         (call_thread_fsm::should_notify_stop): Rename from
9886         call_thread_fsm_should_notify_stop.
9887         (run_inferior_call, call_function_by_hand_dummy): Update.
9888         * cli/cli-interp.c (should_print_stop_to_console): Update.
9889         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9890         Add constructor.  Change type of location_breakpoint,
9891         caller_breakpoint.
9892         (until_break_fsm_ops): Remove.
9893         (new_until_break_fsm): Remove.
9894         (until_break_fsm::should_stop): Rename from
9895         until_break_fsm_should_stop.
9896         (until_break_fsm::clean_up): Rename from
9897         until_break_fsm_clean_up.
9898         (until_break_fsm::do_async_reply_reason): Rename from
9899         until_break_fsm_async_reply_reason.
9900         (until_break_command): Update.
9901         * thread-fsm.c: Remove.
9902         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9903
9904 2019-02-07  Tom Tromey  <tom@tromey.com>
9905
9906         * yy-remap.h: Add include guard.
9907         * xtensa-tdep.h: Add include guard.
9908         * xcoffread.h: Rename include guard.
9909         * varobj-iter.h: Add include guard.
9910         * tui/tui.h: Rename include guard.
9911         * tui/tui-winsource.h: Rename include guard.
9912         * tui/tui-wingeneral.h: Rename include guard.
9913         * tui/tui-windata.h: Rename include guard.
9914         * tui/tui-win.h: Rename include guard.
9915         * tui/tui-stack.h: Rename include guard.
9916         * tui/tui-source.h: Rename include guard.
9917         * tui/tui-regs.h: Rename include guard.
9918         * tui/tui-out.h: Rename include guard.
9919         * tui/tui-layout.h: Rename include guard.
9920         * tui/tui-io.h: Rename include guard.
9921         * tui/tui-hooks.h: Rename include guard.
9922         * tui/tui-file.h: Rename include guard.
9923         * tui/tui-disasm.h: Rename include guard.
9924         * tui/tui-data.h: Rename include guard.
9925         * tui/tui-command.h: Rename include guard.
9926         * tic6x-tdep.h: Add include guard.
9927         * target/waitstatus.h: Rename include guard.
9928         * target/wait.h: Rename include guard.
9929         * target/target.h: Rename include guard.
9930         * target/resume.h: Rename include guard.
9931         * target-float.h: Rename include guard.
9932         * stabsread.h: Add include guard.
9933         * rs6000-tdep.h: Add include guard.
9934         * riscv-fbsd-tdep.h: Add include guard.
9935         * regformats/regdef.h: Rename include guard.
9936         * record.h: Rename include guard.
9937         * python/python.h: Rename include guard.
9938         * python/python-internal.h: Rename include guard.
9939         * python/py-stopevent.h: Rename include guard.
9940         * python/py-ref.h: Rename include guard.
9941         * python/py-record.h: Rename include guard.
9942         * python/py-record-full.h: Rename include guard.
9943         * python/py-record-btrace.h: Rename include guard.
9944         * python/py-instruction.h: Rename include guard.
9945         * python/py-events.h: Rename include guard.
9946         * python/py-event.h: Rename include guard.
9947         * procfs.h: Add include guard.
9948         * proc-utils.h: Add include guard.
9949         * p-lang.h: Add include guard.
9950         * or1k-tdep.h: Rename include guard.
9951         * observable.h: Rename include guard.
9952         * nto-tdep.h: Rename include guard.
9953         * nat/x86-linux.h: Rename include guard.
9954         * nat/x86-linux-dregs.h: Rename include guard.
9955         * nat/x86-gcc-cpuid.h: Add include guard.
9956         * nat/x86-dregs.h: Rename include guard.
9957         * nat/x86-cpuid.h: Rename include guard.
9958         * nat/ppc-linux.h: Rename include guard.
9959         * nat/mips-linux-watch.h: Rename include guard.
9960         * nat/linux-waitpid.h: Rename include guard.
9961         * nat/linux-ptrace.h: Rename include guard.
9962         * nat/linux-procfs.h: Rename include guard.
9963         * nat/linux-osdata.h: Rename include guard.
9964         * nat/linux-nat.h: Rename include guard.
9965         * nat/linux-namespaces.h: Rename include guard.
9966         * nat/linux-btrace.h: Rename include guard.
9967         * nat/glibc_thread_db.h: Rename include guard.
9968         * nat/gdb_thread_db.h: Rename include guard.
9969         * nat/gdb_ptrace.h: Rename include guard.
9970         * nat/fork-inferior.h: Rename include guard.
9971         * nat/amd64-linux-siginfo.h: Rename include guard.
9972         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9973         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9974         * nat/aarch64-linux.h: Rename include guard.
9975         * nat/aarch64-linux-hw-point.h: Rename include guard.
9976         * mn10300-tdep.h: Add include guard.
9977         * mips-linux-tdep.h: Add include guard.
9978         * mi/mi-parse.h: Rename include guard.
9979         * mi/mi-out.h: Rename include guard.
9980         * mi/mi-main.h: Rename include guard.
9981         * mi/mi-interp.h: Rename include guard.
9982         * mi/mi-getopt.h: Rename include guard.
9983         * mi/mi-console.h: Rename include guard.
9984         * mi/mi-common.h: Rename include guard.
9985         * mi/mi-cmds.h: Rename include guard.
9986         * mi/mi-cmd-break.h: Rename include guard.
9987         * m2-lang.h: Add include guard.
9988         * location.h: Rename include guard.
9989         * linux-record.h: Rename include guard.
9990         * linux-nat.h: Add include guard.
9991         * linux-fork.h: Add include guard.
9992         * i386-darwin-tdep.h: Rename include guard.
9993         * hppa-linux-offsets.h: Add include guard.
9994         * guile/guile.h: Rename include guard.
9995         * guile/guile-internal.h: Rename include guard.
9996         * gnu-nat.h: Rename include guard.
9997         * gdb-stabs.h: Rename include guard.
9998         * frv-tdep.h: Add include guard.
9999         * f-lang.h: Add include guard.
10000         * event-loop.h: Add include guard.
10001         * darwin-nat.h: Rename include guard.
10002         * cp-abi.h: Rename include guard.
10003         * config/sparc/nm-sol2.h: Rename include guard.
10004         * config/nm-nto.h: Rename include guard.
10005         * config/nm-linux.h: Add include guard.
10006         * config/i386/nm-i386gnu.h: Rename include guard.
10007         * config/djgpp/nl_types.h: Rename include guard.
10008         * config/djgpp/langinfo.h: Rename include guard.
10009         * compile/gcc-cp-plugin.h: Add include guard.
10010         * compile/gcc-c-plugin.h: Add include guard.
10011         * compile/compile.h: Rename include guard.
10012         * compile/compile-object-run.h: Rename include guard.
10013         * compile/compile-object-load.h: Rename include guard.
10014         * compile/compile-internal.h: Rename include guard.
10015         * compile/compile-cplus.h: Rename include guard.
10016         * compile/compile-c.h: Rename include guard.
10017         * common/xml-utils.h: Rename include guard.
10018         * common/x86-xstate.h: Rename include guard.
10019         * common/version.h: Rename include guard.
10020         * common/vec.h: Rename include guard.
10021         * common/tdesc.h: Rename include guard.
10022         * common/selftest.h: Rename include guard.
10023         * common/scoped_restore.h: Rename include guard.
10024         * common/scoped_mmap.h: Rename include guard.
10025         * common/scoped_fd.h: Rename include guard.
10026         * common/safe-iterator.h: Rename include guard.
10027         * common/run-time-clock.h: Rename include guard.
10028         * common/refcounted-object.h: Rename include guard.
10029         * common/queue.h: Rename include guard.
10030         * common/ptid.h: Rename include guard.
10031         * common/print-utils.h: Rename include guard.
10032         * common/preprocessor.h: Rename include guard.
10033         * common/pathstuff.h: Rename include guard.
10034         * common/observable.h: Rename include guard.
10035         * common/netstuff.h: Rename include guard.
10036         * common/job-control.h: Rename include guard.
10037         * common/host-defs.h: Rename include guard.
10038         * common/gdb_wait.h: Rename include guard.
10039         * common/gdb_vecs.h: Rename include guard.
10040         * common/gdb_unlinker.h: Rename include guard.
10041         * common/gdb_unique_ptr.h: Rename include guard.
10042         * common/gdb_tilde_expand.h: Rename include guard.
10043         * common/gdb_sys_time.h: Rename include guard.
10044         * common/gdb_string_view.h: Rename include guard.
10045         * common/gdb_splay_tree.h: Rename include guard.
10046         * common/gdb_setjmp.h: Rename include guard.
10047         * common/gdb_ref_ptr.h: Rename include guard.
10048         * common/gdb_optional.h: Rename include guard.
10049         * common/gdb_locale.h: Rename include guard.
10050         * common/gdb_assert.h: Rename include guard.
10051         * common/filtered-iterator.h: Rename include guard.
10052         * common/filestuff.h: Rename include guard.
10053         * common/fileio.h: Rename include guard.
10054         * common/environ.h: Rename include guard.
10055         * common/common-utils.h: Rename include guard.
10056         * common/common-types.h: Rename include guard.
10057         * common/common-regcache.h: Rename include guard.
10058         * common/common-inferior.h: Rename include guard.
10059         * common/common-gdbthread.h: Rename include guard.
10060         * common/common-exceptions.h: Rename include guard.
10061         * common/common-defs.h: Rename include guard.
10062         * common/common-debug.h: Rename include guard.
10063         * common/cleanups.h: Rename include guard.
10064         * common/buffer.h: Rename include guard.
10065         * common/btrace-common.h: Rename include guard.
10066         * common/break-common.h: Rename include guard.
10067         * cli/cli-utils.h: Rename include guard.
10068         * cli/cli-style.h: Rename include guard.
10069         * cli/cli-setshow.h: Rename include guard.
10070         * cli/cli-script.h: Rename include guard.
10071         * cli/cli-interp.h: Rename include guard.
10072         * cli/cli-decode.h: Rename include guard.
10073         * cli/cli-cmds.h: Rename include guard.
10074         * charset-list.h: Add include guard.
10075         * buildsym-legacy.h: Rename include guard.
10076         * bfin-tdep.h: Add include guard.
10077         * ax.h: Rename include guard.
10078         * arm-linux-tdep.h: Add include guard.
10079         * arm-fbsd-tdep.h: Add include guard.
10080         * arch/xtensa.h: Rename include guard.
10081         * arch/tic6x.h: Add include guard.
10082         * arch/i386.h: Add include guard.
10083         * arch/arm.h: Rename include guard.
10084         * arch/arm-linux.h: Rename include guard.
10085         * arch/arm-get-next-pcs.h: Rename include guard.
10086         * arch/amd64.h: Add include guard.
10087         * arch/aarch64-insn.h: Rename include guard.
10088         * arch-utils.h: Rename include guard.
10089         * annotate.h: Add include guard.
10090         * amd64-darwin-tdep.h: Rename include guard.
10091         * aarch64-linux-tdep.h: Add include guard.
10092         * aarch64-fbsd-tdep.h: Add include guard.
10093         * aarch32-linux-nat.h: Add include guard.
10094
10095 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10096
10097         * macrotab.c (macro_define_internal): New function that
10098         factorizes macro_define_object_internal and macro_define_function
10099         code.
10100         (macro_define_object_internal): Use macro_define_internal.
10101         (macro_define_function): Likewise.
10102
10103 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10104
10105         * macrocmd.c (extract_identifier): Return
10106         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10107         callers.
10108
10109 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10110
10111         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10112
10113 2019-02-05  Tom Tromey  <tom@tromey.com>
10114
10115         * target.c (target_stack::unpush): Move assertion earlier.
10116
10117 2019-01-30  Tom Tromey  <tom@tromey.com>
10118
10119         PR python/23615:
10120         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10121         (gdbpy_parse_and_eval): Likewise.
10122         * python/python-internal.h (gdbpy_allow_threads): New class.
10123
10124 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10125
10126         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10127         (aarch64_fbsd_fpregmap): Move earlier.
10128         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10129         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10130         instead of individual calls to trad_frame_set_reg_addr.
10131         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10132         earlier.
10133         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10134         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10135         instead of individual calls to trad_frame_set_reg_addr.
10136
10137 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10138
10139         * CONTRIBUTE: Replace contribution list with wiki link.
10140
10141 2019-01-25  Tom Tromey  <tom@tromey.com>
10142
10143         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10144
10145 2019-01-25  Tom Tromey  <tom@tromey.com>
10146
10147         * xtensa-linux-nat.c: Fix common/ includes.
10148         * xml-support.h: Fix common/ includes.
10149         * xml-support.c: Fix common/ includes.
10150         * x86-linux-nat.c: Fix common/ includes.
10151         * windows-nat.c: Fix common/ includes.
10152         * varobj.h: Fix common/ includes.
10153         * varobj.c: Fix common/ includes.
10154         * value.c: Fix common/ includes.
10155         * valops.c: Fix common/ includes.
10156         * utils.c: Fix common/ includes.
10157         * unittests/xml-utils-selftests.c: Fix common/ includes.
10158         * unittests/utils-selftests.c: Fix common/ includes.
10159         * unittests/unpack-selftests.c: Fix common/ includes.
10160         * unittests/tracepoint-selftests.c: Fix common/ includes.
10161         * unittests/style-selftests.c: Fix common/ includes.
10162         * unittests/string_view-selftests.c: Fix common/ includes.
10163         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10164         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10165         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10166         * unittests/rsp-low-selftests.c: Fix common/ includes.
10167         * unittests/parse-connection-spec-selftests.c: Fix common/
10168         includes.
10169         * unittests/optional-selftests.c: Fix common/ includes.
10170         * unittests/offset-type-selftests.c: Fix common/ includes.
10171         * unittests/observable-selftests.c: Fix common/ includes.
10172         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10173         * unittests/memrange-selftests.c: Fix common/ includes.
10174         * unittests/memory-map-selftests.c: Fix common/ includes.
10175         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10176         * unittests/function-view-selftests.c: Fix common/ includes.
10177         * unittests/environ-selftests.c: Fix common/ includes.
10178         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10179         * unittests/common-utils-selftests.c: Fix common/ includes.
10180         * unittests/cli-utils-selftests.c: Fix common/ includes.
10181         * unittests/array-view-selftests.c: Fix common/ includes.
10182         * ui-file.c: Fix common/ includes.
10183         * tui/tui-io.c: Fix common/ includes.
10184         * tracepoint.h: Fix common/ includes.
10185         * tracepoint.c: Fix common/ includes.
10186         * tracefile-tfile.c: Fix common/ includes.
10187         * top.h: Fix common/ includes.
10188         * top.c: Fix common/ includes.
10189         * thread.c: Fix common/ includes.
10190         * target/waitstatus.h: Fix common/ includes.
10191         * target/waitstatus.c: Fix common/ includes.
10192         * target.h: Fix common/ includes.
10193         * target.c: Fix common/ includes.
10194         * target-memory.c: Fix common/ includes.
10195         * target-descriptions.c: Fix common/ includes.
10196         * symtab.h: Fix common/ includes.
10197         * symfile.c: Fix common/ includes.
10198         * stap-probe.c: Fix common/ includes.
10199         * spu-linux-nat.c: Fix common/ includes.
10200         * sparc-nat.c: Fix common/ includes.
10201         * source.c: Fix common/ includes.
10202         * solib.c: Fix common/ includes.
10203         * solib-target.c: Fix common/ includes.
10204         * ser-unix.c: Fix common/ includes.
10205         * ser-tcp.c: Fix common/ includes.
10206         * ser-pipe.c: Fix common/ includes.
10207         * ser-base.c: Fix common/ includes.
10208         * selftest-arch.c: Fix common/ includes.
10209         * s12z-tdep.c: Fix common/ includes.
10210         * rust-exp.y: Fix common/ includes.
10211         * rs6000-aix-tdep.c: Fix common/ includes.
10212         * riscv-tdep.c: Fix common/ includes.
10213         * remote.c: Fix common/ includes.
10214         * remote-notif.h: Fix common/ includes.
10215         * remote-fileio.h: Fix common/ includes.
10216         * remote-fileio.c: Fix common/ includes.
10217         * regcache.h: Fix common/ includes.
10218         * regcache.c: Fix common/ includes.
10219         * record-btrace.c: Fix common/ includes.
10220         * python/python.c: Fix common/ includes.
10221         * python/py-type.c: Fix common/ includes.
10222         * python/py-inferior.c: Fix common/ includes.
10223         * progspace.h: Fix common/ includes.
10224         * producer.c: Fix common/ includes.
10225         * procfs.c: Fix common/ includes.
10226         * proc-api.c: Fix common/ includes.
10227         * printcmd.c: Fix common/ includes.
10228         * ppc-linux-nat.c: Fix common/ includes.
10229         * parser-defs.h: Fix common/ includes.
10230         * osdata.c: Fix common/ includes.
10231         * obsd-nat.c: Fix common/ includes.
10232         * nat/x86-linux.c: Fix common/ includes.
10233         * nat/x86-linux-dregs.c: Fix common/ includes.
10234         * nat/x86-dregs.h: Fix common/ includes.
10235         * nat/x86-dregs.c: Fix common/ includes.
10236         * nat/ppc-linux.c: Fix common/ includes.
10237         * nat/mips-linux-watch.h: Fix common/ includes.
10238         * nat/mips-linux-watch.c: Fix common/ includes.
10239         * nat/linux-waitpid.c: Fix common/ includes.
10240         * nat/linux-ptrace.h: Fix common/ includes.
10241         * nat/linux-ptrace.c: Fix common/ includes.
10242         * nat/linux-procfs.c: Fix common/ includes.
10243         * nat/linux-personality.c: Fix common/ includes.
10244         * nat/linux-osdata.c: Fix common/ includes.
10245         * nat/linux-namespaces.c: Fix common/ includes.
10246         * nat/linux-btrace.h: Fix common/ includes.
10247         * nat/linux-btrace.c: Fix common/ includes.
10248         * nat/fork-inferior.c: Fix common/ includes.
10249         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10250         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10251         * nat/aarch64-linux.c: Fix common/ includes.
10252         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10253         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10254         * namespace.h: Fix common/ includes.
10255         * mips-linux-tdep.c: Fix common/ includes.
10256         * minsyms.c: Fix common/ includes.
10257         * mi/mi-parse.h: Fix common/ includes.
10258         * mi/mi-main.c: Fix common/ includes.
10259         * mi/mi-cmd-env.c: Fix common/ includes.
10260         * memrange.h: Fix common/ includes.
10261         * memattr.c: Fix common/ includes.
10262         * maint.h: Fix common/ includes.
10263         * maint.c: Fix common/ includes.
10264         * main.c: Fix common/ includes.
10265         * machoread.c: Fix common/ includes.
10266         * location.c: Fix common/ includes.
10267         * linux-thread-db.c: Fix common/ includes.
10268         * linux-nat.c: Fix common/ includes.
10269         * linux-fork.c: Fix common/ includes.
10270         * inline-frame.c: Fix common/ includes.
10271         * infrun.c: Fix common/ includes.
10272         * inflow.c: Fix common/ includes.
10273         * inferior.h: Fix common/ includes.
10274         * inferior.c: Fix common/ includes.
10275         * infcmd.c: Fix common/ includes.
10276         * inf-ptrace.c: Fix common/ includes.
10277         * inf-child.c: Fix common/ includes.
10278         * ia64-linux-nat.c: Fix common/ includes.
10279         * i387-tdep.c: Fix common/ includes.
10280         * i386-tdep.c: Fix common/ includes.
10281         * i386-linux-tdep.c: Fix common/ includes.
10282         * i386-linux-nat.c: Fix common/ includes.
10283         * i386-go32-tdep.c: Fix common/ includes.
10284         * i386-fbsd-tdep.c: Fix common/ includes.
10285         * i386-fbsd-nat.c: Fix common/ includes.
10286         * guile/scm-type.c: Fix common/ includes.
10287         * guile/guile.c: Fix common/ includes.
10288         * go32-nat.c: Fix common/ includes.
10289         * gnu-nat.c: Fix common/ includes.
10290         * gdbthread.h: Fix common/ includes.
10291         * gdbarch-selftests.c: Fix common/ includes.
10292         * gdb_usleep.c: Fix common/ includes.
10293         * gdb_select.h: Fix common/ includes.
10294         * gdb_bfd.c: Fix common/ includes.
10295         * gcore.c: Fix common/ includes.
10296         * fork-child.c: Fix common/ includes.
10297         * findvar.c: Fix common/ includes.
10298         * fbsd-nat.c: Fix common/ includes.
10299         * event-top.c: Fix common/ includes.
10300         * event-loop.c: Fix common/ includes.
10301         * dwarf2read.c: Fix common/ includes.
10302         * dwarf2loc.c: Fix common/ includes.
10303         * dwarf2-frame.c: Fix common/ includes.
10304         * dwarf-index-cache.c: Fix common/ includes.
10305         * dtrace-probe.c: Fix common/ includes.
10306         * disasm-selftests.c: Fix common/ includes.
10307         * defs.h: Fix common/ includes.
10308         * csky-tdep.c: Fix common/ includes.
10309         * cp-valprint.c: Fix common/ includes.
10310         * cp-support.h: Fix common/ includes.
10311         * cp-support.c: Fix common/ includes.
10312         * corelow.c: Fix common/ includes.
10313         * completer.h: Fix common/ includes.
10314         * completer.c: Fix common/ includes.
10315         * compile/compile.c: Fix common/ includes.
10316         * compile/compile-loc2c.c: Fix common/ includes.
10317         * compile/compile-cplus-types.c: Fix common/ includes.
10318         * compile/compile-cplus-symbols.c: Fix common/ includes.
10319         * command.h: Fix common/ includes.
10320         * cli/cli-dump.c: Fix common/ includes.
10321         * cli/cli-cmds.c: Fix common/ includes.
10322         * charset.c: Fix common/ includes.
10323         * build-id.c: Fix common/ includes.
10324         * btrace.h: Fix common/ includes.
10325         * btrace.c: Fix common/ includes.
10326         * breakpoint.h: Fix common/ includes.
10327         * breakpoint.c: Fix common/ includes.
10328         * ax.h:
10329         (enum agent_op): Fix common/ includes.
10330         * ax-general.c (struct aop_map): Fix common/ includes.
10331         * ax-gdb.c: Fix common/ includes.
10332         * auxv.c: Fix common/ includes.
10333         * auto-load.c: Fix common/ includes.
10334         * arm-tdep.c: Fix common/ includes.
10335         * arch/riscv.c: Fix common/ includes.
10336         * arch/ppc-linux-common.c: Fix common/ includes.
10337         * arch/i386.c: Fix common/ includes.
10338         * arch/arm.c: Fix common/ includes.
10339         * arch/arm-linux.c: Fix common/ includes.
10340         * arch/arm-get-next-pcs.c: Fix common/ includes.
10341         * arch/amd64.c: Fix common/ includes.
10342         * arch/aarch64.c: Fix common/ includes.
10343         * arch/aarch64-insn.c: Fix common/ includes.
10344         * arch-utils.c: Fix common/ includes.
10345         * amd64-windows-tdep.c: Fix common/ includes.
10346         * amd64-tdep.c: Fix common/ includes.
10347         * amd64-sol2-tdep.c: Fix common/ includes.
10348         * amd64-obsd-tdep.c: Fix common/ includes.
10349         * amd64-nbsd-tdep.c: Fix common/ includes.
10350         * amd64-linux-tdep.c: Fix common/ includes.
10351         * amd64-linux-nat.c: Fix common/ includes.
10352         * amd64-fbsd-tdep.c: Fix common/ includes.
10353         * amd64-fbsd-nat.c: Fix common/ includes.
10354         * amd64-dicos-tdep.c: Fix common/ includes.
10355         * amd64-darwin-tdep.c: Fix common/ includes.
10356         * agent.c: Fix common/ includes.
10357         * ada-lang.h: Fix common/ includes.
10358         * ada-lang.c: Fix common/ includes.
10359         * aarch64-tdep.c: Fix common/ includes.
10360
10361 2019-01-25  Tom Tromey  <tom@tromey.com>
10362
10363         * common/create-version.sh: Use common/version.h.
10364
10365 2019-01-24  Pedro Alves  <palves@redhat.com>
10366
10367         * infrun.c (signal_stop, signal_print, signal_program)
10368         (signal_catch, signal_pass): Now arrays instead of pointers.
10369         (update_signals_program_target, do_target_resume)
10370         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10371         * linux-nat.c (linux_nat_target::pass_signals)
10372         (linux_nat_target::create_inferior, linux_nat_target::attach):
10373         Adjust.
10374         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10375         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10376         * procfs.c (procfs_target::pass_signals): Adjust.
10377         * record-full.c (record_full_target::resume): Adjust.
10378         * remote.c (remote_target::pass_signals)
10379         (remote_target::program_signals): Adjust.
10380         * target-debug.h (target_debug_print_signals): Now takes a
10381         gdb::array_view as parameter.  Adjust.
10382         * target.h (target_ops) <pass_signals, program_signals>: Replace
10383         pointer and length parameters with gdb::array_view.
10384         (target_pass_signals, target_program_signals): Likewise.
10385         * target-delegates.c: Regenerate.
10386
10387 2019-01-24  Pedro Alves  <palves@redhat.com>
10388
10389         * common/forward-scope-exit.h
10390         (forward_scope_exit::forward_scope_exit): Pass arguments to
10391         m_bind_function directly, instead of creating a std::bind and
10392         copying that.
10393
10394 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10395
10396         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10397         for static members.
10398         (pass_in_v_vfp_candidate): Likewise.
10399
10400 2019-01-23  Tom Tromey  <tom@tromey.com>
10401             Pedro Alves  <palves@redhat.com>
10402
10403         * regcache.c (class regcache_invalidator): Remove.
10404         (regcache::raw_write): Use make_scope_exit.
10405
10406 2019-01-23  Tom Tromey  <tom@tromey.com>
10407
10408         * ui-out.h (class ui_out_emit_type): Update comment.
10409
10410 2019-01-23  Tom Tromey  <tom@tromey.com>
10411
10412         * infrun.c (fetch_inferior_event): Update comment.
10413
10414 2019-01-23  Tom Tromey  <tom@tromey.com>
10415             Pedro Alves  <palves@redhat.com>
10416
10417         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10418         parameter.
10419         (fetch_inferior_event): Use SCOPE_EXIT.
10420
10421
10422 2019-01-23  Tom Tromey  <tom@tromey.com>
10423             Pedro Alves  <palves@redhat.com>
10424
10425         * infrun.c (disable_thread_events): Delete.
10426         (stop_all_threads): Use SCOPE_EXIT.
10427
10428 2019-01-23  Tom Tromey  <tom@tromey.com>
10429             Pedro Alves  <palves@redhat.com>
10430
10431         * symfile.c: Include forward-scope-exit.h.
10432         (clear_symtab_users_cleanup): Replace forward declaration with
10433         a FORWARD_SCOPE_EXIT.
10434         (syms_from_objfile_1): Use the forward_scope_exit and
10435         gdb::optional instead of cleanup_function.
10436         (reread_symbols): Use the forward_scope_exit instead of
10437         cleanup_function.
10438         (clear_symtab_users_cleanup): Remove function.
10439
10440 2019-01-23  Tom Tromey  <tom@tromey.com>
10441             Pedro Alves  <palves@redhat.com>
10442
10443         * linux-nat.c: Include scope-exit.h.
10444         (cleanup_target_stop): Remove.
10445         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10446         SCOPE_EXIT.
10447
10448 2019-01-23  Tom Tromey  <tom@tromey.com>
10449             Pedro Alves  <palves@redhat.com>
10450
10451         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10452         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10453
10454 2019-01-23  Tom Tromey  <tom@tromey.com>
10455             Andrew Burgess  <andrew.burgess@embecosm.com>
10456             Pedro Alves  <palves@redhat.com>
10457
10458         * infrun.c (fetch_inferior_event): Use scope_exit.
10459         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10460         * top.c (execute_command): Use scope_exit.
10461         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10462         * utils.c (do_bpstat_clear_actions_cleanup)
10463         (make_bpstat_clear_actions_cleanup): Remove.
10464
10465 2019-01-23  Tom Tromey  <tom@tromey.com>
10466             Pedro Alves  <palves@redhat.com>
10467
10468         * infrun.c: Include "common/scope-exit.h"
10469         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10470         (wait_for_inferior): Use SCOPE_EXIT.
10471         (fetch_inferior_event): Use scope_exit.
10472
10473 2019-01-23  Tom Tromey  <tom@tromey.com>
10474             Pedro Alves  <palves@redhat.com>
10475
10476         * breakpoint.c (create_breakpoint): Remove cleanup.
10477
10478 2019-01-23  Tom Tromey  <tom@tromey.com>
10479             Andrew Burgess  <andrew.burgess@embecosm.com>
10480             Pedro Alves  <palves@redhat.com>
10481
10482 2019-01-23  Pedro Alves  <palves@redhat.com>
10483
10484         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10485
10486 2019-01-23  Pedro Alves  <palves@redhat.com>
10487             Andrew Burgess  <andrew.burgess@embecosm.com>
10488
10489         * gdbthread.h: Include "common/forward-scope-exit.h".
10490         (scoped_finish_thread_state): Redefine custom class in terms of
10491         forward_scope_exit.
10492
10493 2019-01-23  Pedro Alves  <palves@redhat.com>
10494             Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * common/forward-scope-exit.h: New file.
10497
10498 2019-01-23  Pedro Alves  <palves@redhat.com>
10499             Andrew Burgess  <andrew.burgess@embecosm.com>
10500             Tom Tromey  <tom@tromey.com>
10501
10502         * common/scope-exit.h: New file.
10503
10504 2019-01-23  Pedro Alves  <palves@redhat.com>
10505
10506         * common/preprocessor.h (ESC): Rename to ...
10507         (ESC_PARENS): ... this.
10508         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10509         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10510
10511 2019-01-23  Tom Tromey  <tom@tromey.com>
10512
10513         * language.h (class scoped_switch_to_sym_language_if_auto):
10514         Initialize m_lang in both cases.
10515
10516 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10517
10518         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10519         with XCNEW.
10520
10521 2019-01-22  Tom Tromey  <tom@tromey.com>
10522
10523         * corelow.c: Do not include sys/file.h.
10524
10525 2019-01-22  Tom Tromey  <tom@tromey.com>
10526
10527         * tui/tui-wingeneral.h: Include gdb_curses.h.
10528
10529 2019-01-22  Tom Tromey  <tom@tromey.com>
10530
10531         * source-cache.h (class source_cache) <get_source_lines,
10532         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10533
10534 2019-01-22  Tom Tromey  <tom@tromey.com>
10535
10536         * remote-fileio.h (struct remote_target): Declare.
10537
10538 2019-01-22  Tom Tromey  <tom@tromey.com>
10539
10540         * python/py-arch.c: Do not include py-ref.h.
10541         * python/py-bpevent.c: Do not include py-ref.h.
10542         * python/py-cmd.c: Do not include py-ref.h.
10543         * python/py-continueevent.c: Do not include py-ref.h.
10544         * python/py-event.h: Do not include py-ref.h.
10545         * python/py-evtregistry.c: Do not include py-ref.h.
10546         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10547         * python/py-frame.c: Do not include py-ref.h.
10548         * python/py-framefilter.c: Do not include py-ref.h.
10549         * python/py-function.c: Do not include py-ref.h.
10550         * python/py-infevents.c: Do not include py-ref.h.
10551         * python/py-linetable.c: Do not include py-ref.h.
10552         * python/py-objfile.c: Do not include py-ref.h.
10553         * python/py-param.c: Do not include py-ref.h.
10554         * python/py-prettyprint.c: Do not include py-ref.h.
10555         * python/py-progspace.c: Do not include py-ref.h.
10556         * python/py-symbol.c: Do not include py-ref.h.
10557         * python/py-symtab.c: Do not include py-ref.h.
10558         * python/py-type.c: Do not include py-ref.h.
10559         * python/py-unwind.c: Do not include py-ref.h.
10560         * python/py-utils.c: Do not include py-ref.h.
10561         * python/py-value.c: Do not include py-ref.h.
10562         * python/py-varobj.c: Do not include py-ref.h.
10563         * python/py-xmethods.c: Do not include py-ref.h.
10564         * python/python.c: Do not include py-ref.h.
10565         * varobj.c: Do not include py-ref.h.
10566
10567 2019-01-22  Tom Tromey  <tom@tromey.com>
10568
10569         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10570         keyword for bcache.
10571
10572 2019-01-22  Tom Tromey  <tom@tromey.com>
10573
10574         * compile/compile-cplus-types.c: Remove a comment by #include.
10575
10576 2019-01-22  Tom Tromey  <tom@tromey.com>
10577
10578         * compile/gcc-c-plugin.h: Include compile-internal.h.
10579
10580 2019-01-22  Tom Tromey  <tom@tromey.com>
10581
10582         * stabsread.c (EXTERN): Do not define.
10583         (symnum, next_symbol_text_func, processing_gcc_compilation)
10584         (within_function, global_sym_chain, global_stabs)
10585         (previous_stab_code, this_object_header_files)
10586         (n_this_object_header_files)
10587         (n_allocated_this_object_header_files): Define.
10588         * stabsread.h (EXTERN): Never define.  Use "extern".
10589
10590 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10591
10592         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10593         history_value.
10594
10595 2019-01-21  Tom Tromey  <tom@tromey.com>
10596
10597         * ui-out.c: Fix includes.
10598         * tui/tui-source.c: Fix includes.
10599         * target.c: Fix includes.
10600         * remote.c: Fix includes.
10601         * regcache.c: Fix includes.
10602         * python/py-block.c: Fix includes.
10603         * printcmd.c: Fix includes.
10604         * or1k-tdep.c: Fix includes.
10605         * mi/mi-main.c: Fix includes.
10606         * m32r-tdep.c: Fix includes.
10607         * csky-tdep.c: Fix includes.
10608         * compile/compile-cplus-types.c: Fix includes.
10609         * cli/cli-interp.c: Fix includes.
10610
10611 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10612
10613         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10614         for padding.
10615
10616 2019-01-16  Tom Tromey  <tom@tromey.com>
10617
10618         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10619         earlier.
10620         (struct objfile) <msymbols_range>: Move from top level.
10621         <msymbols>: New method.
10622         (class objfile_msymbols): Remove.
10623         * symtab.c (default_collect_symbol_completion_matches_break_on):
10624         Update.
10625         * symmisc.c (dump_msymbols): Update.
10626         * stabsread.c (scan_file_globals): Update.
10627         * objc-lang.c (info_selectors_command, info_classes_command)
10628         (find_methods): Update.
10629         * minsyms.c (find_solib_trampoline_target): Update.
10630         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10631         * coffread.c (coff_symfile_read): Update.
10632         * ada-lang.c (ada_lookup_simple_minsym)
10633         (ada_collect_symbol_completion_matches): Update.
10634
10635 2019-01-16  Tom Tromey  <tom@tromey.com>
10636
10637         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10638         type.  Remove no-argument constructor.
10639         <iterator::operator++>: Simplify.
10640         <begin>: Update.
10641         <end>: Use minimal_symbol_count.
10642
10643 2019-01-16  Tom Tromey  <tom@tromey.com>
10644
10645         * objfiles.h (struct objfile) <psymtabs>: New method.
10646         (class objfile_psymtabs): Remove.
10647         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10648         typedef.
10649         <range>: New method.
10650         (require_partial_symbols): Change return type.
10651         * psymtab.c (require_partial_symbols)
10652         (psym_expand_symtabs_matching): Update.
10653         * mdebugread.c (parse_partial_symbols): Update.
10654         * dbxread.c (dbx_end_psymtab): Update.
10655
10656 2019-01-15  Tom Tromey  <tom@tromey.com>
10657
10658         * symtab.c (lookup_objfile_from_block)
10659         (lookup_symbol_in_objfile_symtabs)
10660         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10661         (find_line_symtab, info_sources_command)
10662         (default_collect_symbol_completion_matches_break_on)
10663         (make_source_files_completion_list): Update.
10664         * symmisc.c (print_objfile_statistics, dump_objfile)
10665         (maintenance_print_symbols, maintenance_info_symtabs)
10666         (maintenance_check_symtabs, maintenance_info_line_tables):
10667         Update.
10668         * source.c (select_source_symtab)
10669         (forget_cached_source_info_for_objfile): Update.
10670         * objfiles.h (class objfile_compunits): Remove.
10671         (struct objfile) <compunits_range>: New typedef.
10672         (compunits): New method.
10673         * objfiles.c (objfile_relocate1): Update.
10674         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10675         * maint.c (count_symtabs_and_blocks): Update.
10676         * linespec.c (iterate_over_all_matching_symtabs): Update.
10677         * cp-support.c (add_symbol_overload_list_qualified): Update.
10678         * coffread.c (coff_symtab_read): Update.
10679         * ada-lang.c (add_nonlocal_symbols)
10680         (ada_collect_symbol_completion_matches)
10681         (ada_add_global_exceptions): Update.
10682
10683 2019-01-15  Tom Tromey  <tom@tromey.com>
10684
10685         * progspace.h (program_space) <objfiles_safe_range>: New
10686         typedef.
10687         <objfiles_safe>: New method.
10688         * objfiles.h (class all_objfiles_safe): Remove.
10689         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10690         * jit.c (jit_inferior_exit_hook): Update.
10691
10692 2019-01-17  Tom Tromey  <tom@tromey.com>
10693
10694         * progspace.h (program_space) <objfiles_range>: New typedef.
10695         <objfiles>: New method.
10696         <objfiles_head>: Rename from objfiles.
10697         (object_files): Update.
10698         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10699         * guile/scm-pretty-print.c
10700         (ppscm_find_pretty_printer_from_objfiles): Update.
10701         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10702         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10703         Update.
10704         * python/py-progspace.c (pspy_get_objfiles): Update.
10705         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10706         Update.
10707         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10708         (objfpy_lookup_objfile_by_build_id): Update.
10709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10710         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10711         Update.
10712         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10713         (expand_symtab_containing_pc, lookup_objfile_from_block)
10714         (lookup_static_symbol, basic_lookup_transparent_type)
10715         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10716         (find_line_symtab, info_sources_command)
10717         (default_collect_symbol_completion_matches_break_on)
10718         (make_source_files_completion_list, find_main_name): Update.
10719         * symmisc.c (print_symbol_bcache_statistics)
10720         (print_objfile_statistics, maintenance_print_symbols)
10721         (maintenance_print_msymbols, maintenance_print_objfiles)
10722         (maintenance_info_symtabs, maintenance_check_symtabs)
10723         (maintenance_expand_symtabs, maintenance_info_line_tables):
10724         Update.
10725         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10726         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10727         (map_overlay_command, unmap_overlay_command)
10728         (simple_overlay_update, expand_symtabs_matching)
10729         (map_symbol_filenames): Update.
10730         * symfile-debug.c (set_debug_symfile): Update.
10731         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10732         Update.
10733         * source.c (select_source_symtab, forget_cached_source_info):
10734         Update.
10735         * solib.c (solib_read_symbols): Update.
10736         * solib-spu.c (append_ocl_sos): Update.
10737         * psymtab.c (maintenance_print_psymbols)
10738         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10739         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10740         * printcmd.c (info_symbol_command): Update.
10741         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10742         Update.
10743         * objfiles.h (class all_objfiles): Remove.
10744         * objfiles.c (have_partial_symbols, have_full_symbols)
10745         (have_minimal_symbols, qsort_cmp, update_section_map)
10746         (shared_objfile_contains_address_p)
10747         (default_iterate_over_objfiles_in_search_order): Update.
10748         * objc-lang.c (info_selectors_command, info_classes_command)
10749         (find_methods): Update.
10750         * minsyms.c (find_solib_trampoline_target): Update.
10751         * maint.c (maintenance_info_sections)
10752         (maintenance_translate_address, count_symtabs_and_blocks):
10753         Update.
10754         * main.c (captured_main_1): Update.
10755         * linux-thread-db.c (try_thread_db_load_from_pdir)
10756         (has_libpthread): Update.
10757         * linespec.c (iterate_over_all_matching_symtabs)
10758         (search_minsyms_for_name): Update.
10759         * jit.c (jit_find_objf_with_entry_addr): Update.
10760         * hppa-tdep.c (find_unwind_entry)
10761         (hppa_lookup_stub_minimal_symbol): Update.
10762         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10763         Update.
10764         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10765         (elf_gnu_ifunc_resolve_by_got): Update.
10766         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10767         * dwarf-index-write.c (save_gdb_index_command): Update.
10768         * cp-support.c (add_symbol_overload_list_qualified): Update.
10769         * breakpoint.c (create_overlay_event_breakpoint)
10770         (create_longjmp_master_breakpoint)
10771         (create_std_terminate_master_breakpoint)
10772         (create_exception_master_breakpoint): Update.
10773         * blockframe.c (find_pc_partial_function): Update.
10774         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10775         (ada_collect_symbol_completion_matches)
10776         (ada_add_global_exceptions): Update.
10777
10778 2019-01-17  Tom Tromey  <tom@tromey.com>
10779
10780         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10781         declare VEC.
10782         (solib_target_parse_libraries): Change return type.
10783         (library_list_start_segment, library_list_start_section)
10784         (library_list_end_library, library_list_start_library); Update.
10785         (solib_target_free_library_list): Remove.
10786         (solib_target_parse_libraries): Remove cleanup.  Change return
10787         type.
10788         (solib_target_current_sos): Update.
10789
10790 2019-01-17  Tom Tromey  <tromey@bapiya>
10791
10792         * valprint.c: Replace "the the" with "the".
10793         * symtab.c: Replace "the the" with "the".
10794         * solib.c: Replace "the the" with "the".
10795         * solib-dsbt.c: Replace "the the" with "the".
10796         * linespec.c: Replace "the the" with "the".
10797         * dwarf2loc.h: Replace "the the" with "the".
10798         * amd64-windows-tdep.c: Replace "the the" with "the".
10799         * aarch64-tdep.c: Replace "the the" with "the".
10800
10801 2019-01-16  Keith Seitz  <keiths@redhat.com>
10802
10803         PR gdb/23773
10804         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10805         <builder>: Rename to ..
10806         <m_builder>: ... this and make private.
10807         (dwarf2_cu::get_builder): New method.  Change all users of
10808         `builder' to use this method.
10809         (dwarf2_start_symtab): Move to ...
10810         (dwarf2_cu::start_symtab): ... here.  Update all callers
10811         (setup_type_unit_groups): Move to ...
10812         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10813         callers.
10814         (dwarf2_cu::reset_builder): New method.
10815         (process_full_compunit, process_full_type_unit): Use
10816         dwarf2_cu::reset_builder.
10817         (follow_die_offset): Record the ancestor CU if it is different
10818         from the followed DIE's CU.
10819         (follow_die_sig_1): Likewise.
10820
10821 2019-01-15  Tom Tromey  <tom@tromey.com>
10822
10823         * remote.c (class remote_state) <buf>: Now a char_vector.
10824         <buf_size>: Remove.
10825         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10826         parameter.
10827         (remote_target::getpkt_or_notif_sane_1)
10828         (remote_target::getpkt_sane)
10829         (remote_target::getpkt_or_notif_sane): Likewise.
10830         (class remote_target) <putpkt>: New overload.
10831         (remote_target::read_frame): Change type of "buf_p".  Remove
10832         sizeof_p parameter.
10833         (packet_ok): New overload.
10834         (packet_check_result): New overload.
10835         Update all uses.
10836
10837 2019-01-14  Tom Tromey  <tom@tromey.com>
10838
10839         * remote-notif.c (handle_notification, remote_notif_ack)
10840         (remote_notif_parse): Make "buf" const.
10841         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10842         const.
10843         (remote_notif_parse, remote_notif_ack, handle_notification):
10844         Likewise.
10845         * remote.c (remote_notif_stop_parse): Make "buf" const.
10846         (remote_target::remote_parse_stop_reply): Make "buf" const.
10847         (remote_notif_stop_ack): Make "buf" const.
10848
10849 2019-01-14  Tom Tromey  <tom@tromey.com>
10850
10851         * remote.c (remote_console_output): Make parameter const.
10852
10853 2019-01-14  Tom Tromey  <tom@tromey.com>
10854
10855         * target-debug.h (target_debug_print_signals): Constify.
10856         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10857         * procfs.c (procfs_target::pass_signals): Update.
10858         * linux-nat.c (linux_nat_target::pass_signals): Update.
10859         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10860         * target-delegates.c: Rebuild.
10861         * remote.c (remote_target::program_signals): Update.
10862         (remote_target::pass_signals): Update.
10863         * target.c (target_pass_signals): Constify argument.
10864         (target_program_signals): Likewise.
10865         * target.h (struct target_ops) <pass_signals, program_signals>:
10866         Constify argument.
10867         (target_pass_signals, target_program_signals): Constify argument.
10868
10869 2019-01-14  Tom Tromey  <tom@tromey.com>
10870
10871         PR tui/28819:
10872         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10873
10874 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10875
10876         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10877         field.
10878         * rs6000-tdep.c: Include reggroups.h.
10879         (IS_V_ALIAS_PSEUDOREG): Define.
10880         (rs6000_register_name): Return names for the "vX" aliases.
10881         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10882         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10883         aliases.  Call default_register_reggroup_p for all other
10884         pseudo-registers.
10885         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10886         New functions.
10887         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10888         Handle "vX" aliases.
10889         (v_alias_pseudo_register_collect): New function.
10890         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10891         (rs6000_gdbarch_init): Initialize "vX" aliases as
10892         pseudo-registers.  Restore registration of
10893         rs6000_pseudo_register_reggroup_p with
10894         set_tdesc_pseudo_register_reggroup_p.
10895
10896 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10897
10898         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10899         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10900         set_gdbarch_num_pseudo_regs.
10901
10902 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10903
10904         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10905         Remove arg prefixname, add do_set and do_show.
10906         Add member functions set_list and show_list.
10907         * cli/cli-style.c (class cli_style_option): Update accordingly.
10908         (style_set_list): Move to file scope.
10909         (style_show_list): Likewise.
10910         (set_style): Call help_list.
10911         (show_style): Call cmd_show_list.
10912         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10913         Update to use the new macro.
10914
10915 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10916
10917         * ada-lang.c (_initialize_ada_language): Expand the help text
10918         for the "catch exception" command.
10919
10920 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10921
10922         * symtab.c (matching_obj_sections): Initialize obj,
10923         declare it closer to its usage.
10924
10925 2019-01-10  Tom Tromey  <tom@tromey.com>
10926
10927         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10928         (basic_inf_threads_range): Remove.
10929         (inf_threads_range, inf_non_exited_threads_range)
10930         (safe_inf_threads_range): Use next_adapter.
10931
10932 2019-01-10  Keith Seitz  <keiths@redhat.com>
10933
10934         PR gdb/23712
10935         PR symtab/23010
10936         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10937         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10938
10939 2019-01-10  Keith Seitz  <keiths@redhat.com>
10940
10941         PR gdb/23712
10942         PR symtab/23010
10943         * dictionary.c (pending_to_vector): Remove.
10944         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10945         Remove _1 suffix, replacing functions of the same name.  Update
10946         all callers.
10947         (dict_create_hashed, dict_create_hashed_expandable)
10948         (dict_create_linear, dict_create_linear_expandable, dict_free)
10949         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10950         Make functions static.
10951
10952 2019-01-10  Keith Seitz  <keiths@redhat.com>
10953
10954         PR gdb/23712
10955         PR symtab/23010
10956         * dictionary.h (struct dictionary): Replace declaration with
10957         multidictionary.
10958         (dict_create_hashed, dict_create_hashed_expandable)
10959         (dict_create_linear, dict_create_linear_expandable)
10960         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10961         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10962         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10963         taking multidictionary argument.
10964         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10965         * block.h (struct block) <dict>: Change to multidictionary
10966         and rename `multidict'.
10967         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10968         symmisc.c: Update all dictionary references to multidictionary.
10969
10970 2019-01-10  Keith Seitz  <keiths@redhat.com>
10971
10972         PR gdb/23712
10973         PR symtab/23010
10974         * dictionary.c: Include unordered_map.
10975         (pending_to_vector): New function.
10976         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10977         Rewrite the non-"_1" functions to take vector instead
10978         of linked list.
10979         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10980         "new" _1 versions of the same name.
10981         (multidictionary): Define.
10982         (std::hash<enum language): New definition.
10983         (collate_pending_symbols_by_language, mdict_create_hashed)
10984         (mdict_create_hashed_expandable, mdict_create_linear)
10985         (mdict_create_linear_expandable, mdict_free)
10986         (find_language_dictionary, create_new_language_dictionary)
10987         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10988         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10989         (mdict_size, mdict_empty): New functions.
10990         * dictionary.h (mdict_iterator): Define.
10991
10992 2019-01-10  Pedro Alves  <palves@redhat.com>
10993
10994         * breakpoint.c (read_uploaded_action)
10995         (create_tracepoint_from_upload): Adjust to use
10996         gdb::unique_xmalloc_ptr.
10997         * ctf.c (ctf_write_uploaded_tp):
10998         (SET_ARRAY_FIELD): Use emplace_back.
10999         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11000         * tracefile-tfile.c (tfile_write_uploaded_tp):
11001         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11002         gdb::unique_xmalloc_ptr.
11003         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11004         at_string, cond_string, cmd_strings>: Replace char pointers
11005         with gdb::unique_xmalloc_ptr.
11006
11007 2019-01-10  Pedro Alves  <palves@redhat.com>
11008
11009         * solib-target.c (library_list_start_library): Don't xstrdup name.
11010
11011 2019-01-10  Pedro Alves  <palves@redhat.com>
11012
11013         * mdebugread.c (parse_partial_symbols): Use
11014         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11015
11016 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11017
11018         * linux-fork.c (scoped_switch_fork_info)
11019         <~scoped_switch_fork_info>: Fix incorrect variable name.
11020
11021 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11022
11023         * linux-fork.c (scoped_switch_fork_info)
11024         <scoped_switch_fork_info>: Make explicit.
11025         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11026
11027 2019-01-10  Tom Tromey  <tom@tromey.com>
11028
11029         * objfiles.h (objfile::reset_psymtabs): Update.
11030         * objfiles.c (objfile::objfile): Update.
11031         * psymtab.h (psymtab_storage::obstack): Update.
11032         (psymtab_storage::m_obstack): Use gdb::optional.
11033         (class psymtab_storage): Update comment.  Remove objfile
11034         parameter.
11035         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11036
11037 2019-01-10  Tom Tromey  <tom@tromey.com>
11038
11039         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11040         <free_psymtabs>: Now private.
11041         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11042         (allocate_psymtab): Use new method.
11043
11044 2019-01-10  Tom Tromey  <tom@tromey.com>
11045
11046         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11047         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11048         * mdebugread.c (parse_partial_symbols): Use
11049         allocate_dependencies.
11050         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11051         allocate_dependencies.
11052         (process_psymtab_comp_unit_reader)
11053         (build_type_psymtab_dependencies): Likewise.
11054         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11055
11056 2019-01-10  Tom Tromey  <tom@tromey.com>
11057
11058         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11059         PSYMBOL_SET_LANGUAGE.
11060         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11061
11062 2019-01-10  Tom Tromey  <tom@tromey.com>
11063
11064         * psymtab.h (psymtab_storage::obstack): New method.
11065         <m_obstack>: Rename from obstack; now private.
11066         * psymtab.c (psymtab_storage): Update.
11067         * dwarf2read.c (create_addrmap_from_index)
11068         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11069         Update.
11070
11071 2019-01-10  Tom Tromey  <tom@tromey.com>
11072
11073         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11074         * objfiles.h (objfile::reset_psymtabs): New method.
11075
11076 2019-01-10  Tom Tromey  <tom@tromey.com>
11077
11078         * symmisc.c (print_symbol_bcache_statistics): Update.
11079         (print_objfile_statistics): Update.
11080         * symfile.c (reread_symbols): Update.
11081         * psymtab.h (class psymtab_storage): New.
11082         * psymtab.c (psymtab_storage): New constructor.
11083         (~psymtab_storage): New destructor.
11084         (require_partial_symbols): Update.
11085         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11086         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11087         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11088         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11089         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11090         (start_psymtab_common, end_psymtab_common)
11091         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11092         (allocate_psymtab): Update.
11093         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11094         Update.
11095         (dump_psymtab_addrmap, maintenance_print_psymbols)
11096         (maintenance_check_psymtabs): Update.
11097         (class objfile_psymtabs): Move to objfiles.h.
11098         * psympriv.h (discard_psymtab): Now inline.
11099         (psymtab_discarder::psymtab_discarder): Update.
11100         (psymtab_discarder::~psymtab_discarder): Update.
11101         (ALL_OBJFILE_PSYMTABS): Rewrite.
11102         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11103         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11104         Remove fields.
11105         <partial_symtabs>: New field.
11106         (class objfile_psymtabs): Move from psymtab.h.  Update.
11107         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11108         psymbol_cache.
11109         (objfile::~objfile): Don't destroy psymbol_cache.
11110         * mdebugread.c (parse_partial_symbols): Update.
11111         * dwarf2read.c (create_addrmap_from_index)
11112         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11113         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11114         (add_partial_subprogram, dwarf2_ranges_read): Update.
11115         * dwarf-index-write.c (write_address_map)
11116         (write_one_signatured_type, recursively_write_psymbols)
11117         (class debug_names, class debug_names, write_psymtabs_to_index):
11118         Update.
11119
11120 2019-01-10  Tom Tromey  <tom@tromey.com>
11121
11122         * symtab.h (SYMBOL_SET_NAMES): Update.
11123         (symbol_set_names): Update.
11124         (MSYMBOL_SET_NAMES): Update.
11125         * symtab.c (symbol_set_names): Change argument to be an
11126         objfile_per_bfd_storage.
11127         * psymtab.c (add_psymbol_to_bcache): Update.
11128         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11129
11130 2019-01-10  Tom Tromey  <tom@tromey.com>
11131
11132         * symtab.c (create_demangled_names_hash): Change argument to be an
11133         objfile_per_bfd_storage.
11134         (symbol_set_names): Update.
11135
11136 2019-01-10  Tom Tromey  <tom@tromey.com>
11137
11138         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11139         init_psymbol_list.
11140         * psymtab.c (init_psymbol_list): Do nothing if already called.
11141         * psympriv.h (init_psymbol_list): Add comment.
11142         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11143         init_psymbol_list.
11144         * dbxread.c (dbx_symfile_read): Unconditionally call
11145         init_psymbol_list.
11146
11147 2019-01-10  Tom Tromey  <tom@tromey.com>
11148
11149         * xcoffread.c (scan_xcoff_symtab): Update.
11150         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11151         "where".
11152         * mdebugread.c (parse_partial_symbols)
11153         (handle_psymbol_enumerators): Update.
11154         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11155         * dbxread.c (read_dbx_symtab): Update.
11156         * psympriv.h (psymbol_placement): New enum.
11157         (add_psymbol_to_list): Update.
11158
11159 2019-01-10  Tom Tromey  <tom@tromey.com>
11160
11161         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11162         static_psymbols parameters.
11163         (scan_xcoff_symtab): Update.
11164         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11165         static_psymbols parameters.
11166         * psympriv.h (start_psymtab_common): Update.
11167         * mdebugread.c (parse_partial_symbols): Update.
11168         * dwarf2read.c (create_partial_symtab): Update.
11169         * dbxread.c (read_dbx_symtab): Update.
11170         (start_psymtab): Remove global_psymbols and static_psymbols
11171         parameters.
11172
11173 2019-01-10  Tom Tromey  <tom@tromey.com>
11174
11175         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11176         * psymtab.c (allocate_psymtab): Add comment.
11177         * psympriv.h (allocate_psymtab): Add comment.
11178         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11179         initializations.
11180         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11181
11182 2019-01-10  Tom Tromey  <tom@tromey.com>
11183
11184         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11185         Don't declare.
11186         * mipsread.c: Include mdebugread.h.
11187         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11188         Declare.
11189         * elfread.c: Include mdebugread.h.
11190
11191 2019-01-09  Tom Tromey  <tom@tromey.com>
11192
11193         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11194         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11195         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11196         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11197         (psym_lookup_symbol, psym_find_last_source_symtab)
11198         (psym_forget_cached_source_info, psym_print_stats)
11199         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11200         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11201         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11202         (psym_find_compunit_symtab_by_address)
11203         (maintenance_print_psymbols, maintenance_info_psymtabs)
11204         (maintenance_check_psymtabs): Use ranged for.
11205         * psymtab.h (class objfile_psymtabs): New.
11206         (require_partial_symbols): Return objfile_psymtabs.
11207         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11208
11209 2019-01-09  Tom Tromey  <tom@tromey.com>
11210
11211         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11212         (find_pc_mapped_section, list_overlays_command)
11213         (map_overlay_command, unmap_overlay_command)
11214         (simple_overlay_update): Use all_objfiles.
11215         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11216         * printcmd.c (info_symbol_command): Use all_objfiles.
11217         * objfiles.h (ALL_OBJSECTIONS): Remove.
11218         * maint.c (maintenance_translate_address): Use all_objfiles.
11219         * gcore.c (gcore_create_callback): Use all_objfiles.
11220         (objfile_find_memory_regions): Likewise.
11221
11222 2019-01-09  Tom Tromey  <tom@tromey.com>
11223
11224         * symtab.c (find_line_symtab, info_sources_command)
11225         (make_source_files_completion_list): Use objfile_compunits.
11226         * source.c (select_source_symtab): Use objfile_compunits.
11227         * objfiles.h (struct objfile): Update comment.
11228         (ALL_OBJFILES): Remove.
11229         (ALL_FILETABS): Remove.
11230         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11231         objfile_compunits.
11232
11233 2019-01-09  Tom Tromey  <tom@tromey.com>
11234
11235         * symmisc.c (print_objfile_statistics, dump_objfile)
11236         (maintenance_print_symbols): Use compunit_filetabs.
11237         * source.c (forget_cached_source_info_for_objfile): Use
11238         compunit_filetabs.
11239         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11240         (ALL_FILETABS): Use compunit_filetabs.
11241         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11242         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11243
11244 2019-01-09  Tom Tromey  <tom@tromey.com>
11245
11246         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11247         (compunit_filetabs): New.
11248         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11249         compunit_filetabs.
11250         (info_sources_command, make_source_files_completion_list): Remove
11251         declaration.
11252         * symmisc.c (print_objfile_statistics, dump_objfile)
11253         (maintenance_print_symbols): Remove declaration.
11254         (maintenance_info_symtabs): Use compunit_filetabs.
11255         (maintenance_info_line_tables): Likewise.
11256         * source.c (select_source_symtab): Change local variable name.
11257         (forget_cached_source_info_for_objfile): Remove declaration.
11258         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11259         * objfiles.c (objfile_relocate1): Remove declaration.
11260         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11261         declaration.
11262         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11263         * coffread.c (coff_symtab_read): Remove declaration.
11264         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11265         compunit_filetabs.
11266
11267 2019-01-09  Tom Tromey  <tom@tromey.com>
11268
11269         * symtab.c (lookup_objfile_from_block)
11270         (find_pc_sect_compunit_symtab, search_symbols)
11271         (default_collect_symbol_completion_matches_break_on): Use
11272         objfile_compunits.
11273         * objfiles.h (ALL_COMPUNITS): Remove.
11274         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11275         * cp-support.c (add_symbol_overload_list_qualified): Use
11276         objfile_compunits.
11277         * ada-lang.c (ada_collect_symbol_completion_matches)
11278         (ada_add_global_exceptions): Use objfile_compunits.
11279
11280 2019-01-09  Tom Tromey  <tom@tromey.com>
11281
11282         * source.c (select_source_symtab)
11283         (forget_cached_source_info_for_objfile): Remove declaration.
11284         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11285         declaration.
11286         * maint.c (count_symtabs_and_blocks): Remove declaration.
11287         * cp-support.c (add_symbol_overload_list_qualified): Remove
11288         declaration.
11289         * coffread.c (coff_symtab_read): Remove declaration.
11290         * symtab.c (lookup_symbol_in_objfile_symtabs)
11291         (basic_lookup_transparent_type_1): Use objfile_compunits.
11292         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11293         (info_sources_command, search_symbols)
11294         (default_collect_symbol_completion_matches_break_on)
11295         (make_source_files_completion_list): Remove declaration.
11296         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11297         (ada_collect_symbol_completion_matches)
11298         (ada_add_global_exceptions): Remove declaration.
11299         * linespec.c (iterate_over_all_matching_symtabs): Use
11300         objfile_compunits.
11301         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11302         (class objfile_compunits): New.
11303         (ALL_COMPUNITS): Use objfile_compunits.
11304         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11305         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11306         objfile_compunits.
11307         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11308
11309 2019-01-09  Tom Tromey  <tom@tromey.com>
11310
11311         * symtab.c (search_symbols)
11312         (default_collect_symbol_completion_matches_break_on): Use
11313         objfile_msymbols.
11314         * ada-lang.c (ada_lookup_simple_minsym)
11315         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11316         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11317         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11318         objfile_msymbols.
11319         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11320         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11321         * objc-lang.c (find_methods): Use objfile_msymbols.
11322         (info_selectors_command, info_classes_command): Likewise.
11323         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11324         * objfiles.h (class objfile_msymbols): New.
11325         (ALL_OBJFILE_MSYMBOLS): Remove.
11326         (ALL_MSYMBOLS): Remove.
11327
11328 2019-01-09  Tom Tromey  <tom@tromey.com>
11329
11330         * common/next-iterator.h (next_adapter): Add Iterator template
11331         parameter.
11332         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11333         (class all_objfiles_safe): New.
11334         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11335         * objfiles.c (put_objfile_before): Update comment.
11336         (add_separate_debug_objfile): Likewise.
11337         (free_all_objfiles): Use all_objfiles_safe.
11338         (objfile_purge_solibs): Likewise.
11339
11340 2019-01-09  Tom Tromey  <tom@tromey.com>
11341
11342         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11343         (expand_symtab_containing_pc, lookup_static_symbol)
11344         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11345         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11346         all_objfiles.
11347         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11348         * breakpoint.c (create_overlay_event_breakpoint)
11349         (create_longjmp_master_breakpoint)
11350         (create_std_terminate_master_breakpoint)
11351         (create_exception_master_breakpoint): Use all_objfiles.
11352         * linux-thread-db.c (try_thread_db_load_from_pdir)
11353         (has_libpthread): Use all_objfiles.
11354         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11355         * linespec.c (iterate_over_all_matching_symtabs)
11356         (search_minsyms_for_name): Use all_objfiles.
11357         * maint.c (maintenance_info_sections): Use all_objfiles.
11358         * main.c (captured_main_1): Use all_objfiles.
11359         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11360         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11361         * guile/scm-pretty-print.c
11362         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11363         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11364         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11365         (maintenance_print_msymbols): Use all_objfiles.
11366         * source.c (select_source_symtab): Use all_objfiles.
11367         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11368         * symfile.c (remove_symbol_file_command)
11369         (expand_symtabs_matching, map_symbol_filenames): Use
11370         all_objfiles.
11371         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11372         all_objfiles.
11373         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11374         * objc-lang.c (find_methods): Use all_objfiles.
11375         * objfiles.c (have_partial_symbols, have_full_symbols)
11376         (have_minimal_symbols, qsort_cmp)
11377         (default_iterate_over_objfiles_in_search_order): Use
11378         all_objfiles.
11379         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11380         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11381         (maintenance_check_psymtabs): Use all_objfiles.
11382         (ALL_PSYMTABS): Remove.
11383         * compile/compile-object-run.c (do_module_cleanup): Use
11384         all_objfiles.
11385         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11386         * cp-support.c (add_symbol_overload_list_qualified): Use
11387         all_objfiles.
11388         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11389         Use all_objfiles.
11390         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11391         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11392         all_objfiles.
11393         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11394         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11395         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11396         Uses all_objfiles.
11397         * solib.c (solib_read_symbols): Use all_objfiles
11398
11399 2019-01-09  Tom Tromey  <tom@tromey.com>
11400
11401         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11402         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11403         all_objfiles.
11404         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11405         * symmisc.c (print_symbol_bcache_statistics)
11406         (print_objfile_statistics, maintenance_print_objfiles)
11407         (maintenance_info_symtabs, maintenance_check_symtabs)
11408         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11409         all_objfiles.
11410         * source.c (forget_cached_source_info): Use all_objfiles.
11411         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11412         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11413         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11414         * objfiles.c (update_section_map): Use all_objfiles.
11415         (shared_objfile_contains_address_p): Likewise.
11416         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11417         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11418
11419 2019-01-09  Tom Tromey  <tom@tromey.com>
11420
11421         * common/next-iterator.h: New file.
11422         * objfiles.h (class all_objfiles): New.
11423         (struct objfile_iterator): New.
11424
11425 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11426
11427         * NEWS: Move the description of the changed "frame", "select-frame",
11428          and "info frame" commands to the Changed commands section.
11429
11430 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11431
11432         * gdbtypes.c (check_stub_method_group): Remove handling of old
11433         mangling schemes.
11434         * linespec.c (find_methods): Likewise.
11435         * stabsread.c (read_member_functions): Likewise.
11436         * valops.c (search_struct_method): Likewise.
11437         (value_struct_elt_for_reference): Likewise.
11438         * NEWS: Mention this change.
11439
11440 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11441
11442         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11443         print_source_lines.
11444         * source.c (print_source_lines_base): Update line number check.
11445         (print_source_lines): New function.
11446         (source_lines_range::source_lines_range): New function.
11447         * source.h (class source_lines_range): New class.
11448         (print_source_lines): New declaration.
11449
11450 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11451
11452         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11453
11454 2019-01-08  Tom Tromey  <tom@tromey.com>
11455             Simon Marchi  <simon.marchi@ericsson.com>
11456
11457         PR gdb/24060
11458         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11459         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11460         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11461         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11462         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11463         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11464
11465 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11466
11467         * source.c (select_source_symtab): Move header comment to
11468         declaration in source.h.
11469         (forget_cached_source_info_for_objfile): Likewise.
11470         (forget_cached_source_info): Likewise.
11471         (identify_source_line): Likewise.
11472         * source.h (identify_source_line): Move declaration from symtab.h
11473         and add comment from source.c
11474         (print_source_lines): Likewise.
11475         (forget_cached_source_info_for_objfile): Likewise.
11476         (forget_cached_source_info): Likewise.
11477         (select_source_symtab): Likewise.
11478         (enum print_source_lines_flag): Move definition from symtab.h.
11479         * symtab.h (identify_source_line): Move declaration to source.h.
11480         (print_source_lines): Likewise.
11481         (forget_cached_source_info_for_objfile): Likewise.
11482         (forget_cached_source_info): Likewise.
11483         (select_source_symtab): Likewise.
11484         (enum print_source_lines_flag): Move definition to source.h.
11485         * tui/tui-hooks.c: Add 'source.h' include.
11486
11487 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11488
11489         * source.c (print_source_lines_base): Handle requests to print
11490         reverse line number sequences, and guard against empty lines
11491         string.
11492
11493 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11494
11495         * source.c (print_source_lines_base): Fix skip of '\r' if next
11496         character is '\n'.
11497
11498 2019-01-06  Tom Tromey  <tom@tromey.com>
11499
11500         * c-exp.y (struct c_parse_state) <macro_original_text,
11501         expansion_obstack>: New member.
11502         (macro_original_text, expansion_obstack): Remove globals.
11503         (scan_macro_expansion, scanning_macro_expansion)
11504         (finished_macro_expansion): Update.
11505         (scan_macro_cleanup): Remove.
11506         (yylex, c_parse): Update.
11507
11508 2019-01-06  Tom Tromey  <tom@tromey.com>
11509
11510         * c-exp.y (struct c_parse_state) <strings>: New member.
11511         (operator_stoken): Update.
11512
11513 2019-01-06  Tom Tromey  <tom@tromey.com>
11514
11515         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11516         (union type_stack_elt) <typelist_val>: Now a pointer to
11517         std::vector.
11518         (type_stack_cleanup): Don't declare.
11519         (push_typelist): Update.
11520         * parse.c (pop_typelist): Return a std::vector.
11521         (push_typelist): Take a std::vector.
11522         (follow_types): Update.  Do not free args.
11523         (type_stack_cleanup): Remove.
11524         * c-exp.y (struct c_parse_state): New.
11525         (cpstate): New global.
11526         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11527         (nonempty_typelist): Update.
11528         (func_mod): Create a new vector.
11529         (c_parse): Create a c_parse_state.
11530         (check_parameter_typelist): Do not delete params.
11531         (function_method): Update.  Do not delete type_list.
11532
11533 2019-01-06  Tom Tromey  <tom@tromey.com>
11534
11535         PR gdb/28155:
11536         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11537         check_typedef.
11538         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11539         (print_return_value): Likewise.
11540
11541 2019-01-05  Tom Tromey  <tom@tromey.com>
11542
11543         * contrib/cleanup_check.py: Remove.
11544         * contrib/gcc-with-excheck: Remove.
11545         * contrib/exsummary.py: Remove.
11546         * contrib/excheck.py: Remove.
11547
11548 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11549
11550         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11551         NULL. Initialize tpprev to NULL instead of assigning it
11552         to NULL on the next statement.
11553         * windows-nat.c (windows_delete_thread): Remove check for
11554         main_thread_id before printing thread exit notifications.
11555         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11556         Remove thread ID check against main_thread_id.
11557         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11558         windows_delete_thread.
11559         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11560
11561 2019-01-04  Tom Tromey  <tom@tromey.com>
11562
11563         * compile/compile.c (_initialize_compile): Use upper case for
11564         metasyntactic variables.
11565         * symmisc.c (_initialize_symmisc): Use upper case for
11566         metasyntactic variables.
11567         * psymtab.c (_initialize_psymtab): Use upper case for
11568         metasyntactic variables.
11569         * demangle.c (demangle_command): Use upper case for metasyntactic
11570         variables.
11571         (_initialize_demangler): Likewise.
11572         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11573         variables.
11574
11575 2019-01-03  Tom Tromey  <tom@tromey.com>
11576
11577         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11578
11579 2019-01-03  Tom Tromey  <tom@tromey.com>
11580
11581         * python/py-symtab.c (salpy_str): Update.
11582         (struct salpy_sal_object) <symtab>: Now a PyObject.
11583         (salpy_dealloc): Update.
11584         (del_objfile_sal): Use gdbpy_ref.
11585
11586 2019-01-03  Tom Tromey  <tom@tromey.com>
11587
11588         * python/py-type.c (convert_field): Use new_reference.  Return
11589         gdbpy_ref.
11590         (make_fielditem): Return gdbpy_ref.
11591         (typy_fields): Update.
11592         (typy_getitem): Update.
11593         (field_name): Return gdbpy_ref.  Use new_reference.
11594         (typy_iterator_iternext): Update.
11595
11596 2019-01-03  Tom Tromey  <tom@tromey.com>
11597
11598         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11599
11600 2019-01-03  Tom Tromey  <tom@tromey.com>
11601
11602         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11603         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11604         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11605         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11606         (pspy_set_type_printers): Likewise.
11607         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11608         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11609         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11610         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11611         (objfpy_set_type_printers): Likewise.
11612
11613 2019-01-03  Tom Tromey  <tom@tromey.com>
11614
11615         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11616         (gdbpy_print_stack): Use gdbpy_err_fetch.
11617         * python/python-internal.h (class gdbpy_err_fetch): New class.
11618         (class gdbpy_enter) <m_error_type, m_error_value,
11619         m_error_traceback>: Remove.
11620         <m_error>: New member.
11621         (gdbpy_exception_to_string): Don't declare.
11622         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11623         * python/py-value.c (convert_value_from_python): Use
11624         gdbpy_err_fetch.
11625         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11626         gdbpy_exception_to_string.
11627         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11628         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11629         gdbpy_err_fetch.
11630
11631 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11632
11633         * linux-nat.c (delete_lwp_cleanup): Delete.
11634         (struct lwp_deleter): New struct.
11635         (lwp_info_up): New typedef.
11636         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11637         lwp_info_up.
11638
11639 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11640
11641         * linux-fork.c (class scoped_switch_fork_info): New class.
11642         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11643
11644 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11645
11646         * valops.c (find_overload_match): Remove use of null_cleanup, and
11647         calls to do_cleanups.
11648
11649 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11650
11651         * compile/compile-cplus-types.c
11652         (compile_cplus_instance::decl_name): Handle changes to
11653         cp_func_name.
11654         * cp-support.c (cp_func_name): Update header comment, update
11655         return type.
11656         * cp-support.h (cp_func_name): Update return type in declaration.
11657         * valops.c (find_overload_match): Move temp_func local to top
11658         level of function and change its type.  Use temp_func to hold and
11659         delete temporary string obtained from cp_func_name.
11660
11661 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11662
11663         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11664         gdb::char_vector, remove cleanup, and update uses of `msg`.
11665
11666 2019-01-03  Jim Wilson  <jimw@sifive.com>
11667
11668         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11669
11670 2019-01-02  Tom Tromey  <tom@tromey.com>
11671
11672         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11673         (tdesc_parse_xml): Remove cleanups.
11674         * target-descriptions.h (make_cleanup_free_target_description):
11675         Don't declare.
11676         (target_desc_deleter): New struct.
11677         (target_desc_up): New typedef.
11678         * target-descriptions.c (target_desc_deleter::operator()): Rename
11679         from free_target_description.
11680         (make_cleanup_free_target_description): Remove.
11681
11682 2019-01-02  Tom Tromey  <tom@tromey.com>
11683
11684         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11685         constructor, destructor.
11686         (linespec_parser): Remove typedef.
11687         (~linespec_parser): Rename from linespec_parser_delete.
11688         (linespec_lex_to_end, linespec_complete_label)
11689         (linespec_complete): Update.
11690         (decode_line_full): Remove cleanups.
11691         (decode_line_1): Update.
11692
11693 2019-01-02  Tom Tromey  <tom@tromey.com>
11694
11695         * python/python-internal.h (inferior_to_inferior_object): Change
11696         return type.
11697         * python/py-exitedevent.c (create_exited_event_object): Update.
11698         * python/py-inferior.c (inferior_to_inferior_object): Return
11699         gdbpy_ref.
11700         (python_new_inferior, python_inferior_deleted)
11701         (thread_to_thread_object, delete_thread_object)
11702         (build_inferior_list, gdbpy_selected_inferior): Update.
11703         * python/py-infthread.c (create_thread_object): Update.  Also fail
11704         if inferior_to_inferior_object fails.
11705
11706 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11707
11708         * inferior.h (class inferior) <displaced_step_state>: New field.
11709         * infrun.h (struct displaced_step_state): Move here from
11710         infrun.c.  Initialize fields, add constructor.
11711         <inf>: Remove field.
11712         <reset>: New method.
11713         * infrun.c (struct displaced_step_inferior_state): Move to
11714         infrun.h.
11715         (displaced_step_inferior_states): Remove.
11716         (get_displaced_stepping_state): Adust.
11717         (displaced_step_in_progress_any_inferior): Adjust.
11718         (displaced_step_in_progress_thread): Adjust.
11719         (displaced_step_in_progress): Adjust.
11720         (add_displaced_stepping_state): Remove.
11721         (get_displaced_step_closure_by_addr): Adjust.
11722         (remove_displaced_stepping_state): Remove.
11723         (infrun_inferior_exit): Call displaced_step_state.reset.
11724         (use_displaced_stepping): Don't check for NULL.
11725         (displaced_step_prepare_throw): Call
11726         get_displaced_stepping_state.
11727         (displaced_step_fixup): Don't check for NULL.
11728         (prepare_for_detach): Don't check for NULL.
11729
11730 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11731
11732         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11733          in case of call that did not complete.
11734
11735 2019-01-02  Andrey Utkin  <autkin@undo.io>
11736
11737         * symfile.c (find_separate_debug_file): Fix search of debug files for
11738         remote debuggee.
11739
11740 2019-01-02  Tom Tromey  <tom@tromey.com>
11741
11742         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11743         indentation.
11744         * python/py-frame.c (frapy_older): Remove cast.
11745         (frapy_newer): Likewise.
11746         * python/py-breakpoint.c (local_setattro): Remove cast.
11747         * python/py-arch.c (archpy_name): Remove local variable.
11748         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11749
11750 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11751
11752         * unittests/basic_string_view/element_access/char/empty.cc:
11753         Fix year range in copyright header.
11754
11755 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11756
11757         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11758         Delete.
11759         <operator==>: Update with for removed field.
11760         <hash>: Likewise.
11761         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11762         <isa_features>: ...this.
11763         <abi_features>: New field.
11764         (riscv_isa_flen): Update comment.
11765         (riscv_abi_xlen): New declaration.
11766         (riscv_abi_flen): New declaration.
11767         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11768         isa_features.
11769         (riscv_abi_xlen): New function.
11770         (riscv_isa_flen): Update to get answer from isa_features.
11771         (riscv_abi_flen): New function.
11772         (riscv_has_fp_abi): Update to get answer from abi_features.
11773         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11774         xlen and flen.
11775         (riscv_call_info) <xlen, flen>: Update comment.
11776         (riscv_call_arg_struct): Remove invalid assertions
11777         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11778         is removed.
11779         (riscv_gdbarch_init): Gather isa features and abi features
11780         separately, ensure both match on the gdbarch when reusing an old
11781         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11782         a target with 64-bit float hardware.
11783
11784 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11785
11786         * source.c (search_command_helper): Stop reverse search
11787         when line 1 has been searched.
11788
11789 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11790
11791         * record-full.c (record_full_base_target::close): Rewrite
11792         record_full_core_buf_list free logic.
11793
11794 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11795
11796         * break-catch-syscall.c (print_one_catch_syscall): xfree
11797         the last text.
11798
11799 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11800
11801         * top.c (print_gdb_version): Update Copyright year in version
11802         message.
11803
11804 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11805
11806         Update copyright year range in all GDB files.
11807
11808 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11809
11810         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11811
11812 For older changes see ChangeLog-2018.
11813 \f
11814 Local Variables:
11815 mode: change-log
11816 left-margin: 8
11817 fill-column: 74
11818 version-control: never
11819 coding: utf-8
11820 End:
11821