gdb/ChangeLog

   1 2019-09-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
   4         (add_nonlocal_symbols): Update.
   5         * dwarf2read.c (dw2_map_matching_symbols): Change type.
   6         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
   7         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
   8         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
   9         Change type of "callback".  Remove "data".
  10
  11
  12 2019-09-09  Ali Tamur  <tamur@google.com>
  13
  14         * dwarf2read.c (comp_unit_head): Update comment.
  15         (dwarf2_dwo_name): New function declaration.
  16         (dwarf_unit_type_name): New function declaration.
  17         (read_comp_unit_head): Add support for new compilation units,
  18         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
  19         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
  20         (currently named as "signature") in their header. Also clarify error
  21         messages.
  22         (lookup_dwo_id): New function. Returns the dwo id of the given
  23         compile unit.
  24         (lookup_dwo_unit): Use the new lookup_dwo_id function.
  25         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
  26         functions.
  27         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
  28         (dwarf2_dwo_name): Get the dwo name if present.
  29         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
  30         purposes.
  31
  32 2019-09-09  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
  35
  36 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  37
  38         * python/python.c (do_start_initialization): Make progname_copy static,
  39         to avoid a leak report.
  40
  41 2019-09-08  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
  44
  45 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
  46
  47         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
  48         Change type to gdb::optional<block_enum>.
  49         (dw2_symtab_iter_init): Change block_index parameter type
  50         to gdb::optional<block_enum>.
  51         (dw2_lookup_symbol): Change block_index parameter
  52         type to block_enum.c
  53         (dw2_debug_names_lookup_symbol): Likewise.
  54         * psymtab.c (psym_lookup_symbol): Likewise.
  55         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  56         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  57         Likewise.
  58
  59 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  60
  61         * defs.h (relocate_gdb_directory): Change int to bool in
  62         signature and rename flag to relocatable.
  63         * main.c (relocate_path): Likewise.
  64         (relocate_gdb_directory): Likewise.
  65
  66 2019-09-06  Alan Modra  <amodra@gmail.com>
  67
  68         * coffread.c (coff_symfile_read): Constify filename variable.
  69         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  70         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  71         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
  72         * solib.c (reload_shared_libraries_1): Likewise.
  73         * symfile.c (reread_symbols): Likewise.
  74         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
  75         * solib-darwin.c (darwin_bfd_open): Likewise.
  76         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
  77
  78 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * psymtab.c (print_partial_symbols): Handle missing domain_enum
  81         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
  82
  83 2019-09-03  Tom Tromey  <tromey@adacore.com>
  84
  85         * ada-valprint.c (ada_val_print_num): Don't recurse for range
  86         types.
  87         (has_negatives): Unbias a range type bound.
  88         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
  89         * gdbtypes.c (operator==): Handle new field.
  90         (create_range_type): Add "bias" parameter.
  91         (create_static_range_type, resolve_dynamic_range): Update.
  92         * gdbtypes.h (struct range_bounds) <bias>: New member.
  93         (create_range_type): Add bias parameter.
  94         * printcmd.c (print_scalar_formatted): Unbias range types.
  95         * value.c (unpack_long): Unbias range types.
  96         (pack_long): Bias range types.
  97
  98 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  99
 100         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 101         probe arguments.
 102
 103 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 104
 105         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 106         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 107         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 108         (compile_probe_arg): Likewise.
 109         * probe.h (get_argument_count): Likewise.
 110         * solib-svr4.c (solib_event_probe_action): Likewise.
 111         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 112
 113 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 114
 115         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 116         code to here...
 117         (svr4_create_solib_event_breakpoints): ...from here.
 118
 119 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 120
 121         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 122         suffix from warning message.
 123
 124 2019-08-30  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-winsource.h (struct tui_source_window_base)
 127         <refresh_all>: Don't declare.
 128         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 129         Remove.
 130         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 131         tui_show_locator_content.
 132         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 133         declare.
 134         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 135         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 136         declare.
 137
 138 2019-08-30  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 141
 142 2019-08-30  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 145         Remove unnecessary forward declarations.
 146
 147 2019-08-30  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 150         rerender.
 151         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 152         tui_show_locator_content.
 153
 154 2019-08-30  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 157         (tui_locator_window::rerender): Rewrite using body of previous
 158         tui_show_locator_content.
 159
 160 2019-08-30  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 163         set_locator_fullname>: New methods.
 164         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 165         Rename from tui_set_locator_fullname.
 166         (tui_locator_window::set_locator_info): Rename from
 167         tui_set_locator_info.  Return bool.
 168         (tui_update_locator_fullname, tui_show_frame_info): Update.
 169
 170 2019-08-30  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 173
 174 2019-08-30  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 177         call touchwin.
 178
 179 2019-08-30  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-wingeneral.c (box_win): Assume win_info and
 182         win_info->handle cannot be NULL.
 183
 184 2019-08-30  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 187         refresh_window>: Declare.
 188         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 189         resize.
 190         (tui_data_item_window::rerender): Rename from
 191         tui_display_register.
 192         (tui_data_item_window::refresh_window): New method.
 193         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 194         no-op.
 195
 196 2019-08-30  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 199         regs_column_count, current_group>: Move later.  Now private.
 200         <get_current_group>: New method.
 201         * tui/tui-regs.c (tui_reg_command): Update.
 202         * tui/tui-layout.c (tui_set_layout): Update.
 203
 204 2019-08-30  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 207         (tui_data_window::rerender): Don't call
 208         check_and_display_highlight_if_needed.
 209         (tui_data_window::refresh_all): Remove call to
 210         erase_data_content.
 211
 212 2019-08-30  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 215         (tui_data_window::display_registers_from)
 216         (tui_data_window::display_reg_element_at_line)
 217         (tui_data_window::display_registers_from_line): Remove checks of
 218         "empty".
 219
 220 2019-08-30  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 223         Don't declare.
 224         * tui/tui-regs.c (tui_data_window::show_registers): Call
 225         rerender.
 226         (tui_data_window::rerender): Rename from display_all_data.
 227         (tui_data_window::rerender): Remove old implementation.
 228
 229 2019-08-30  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 232         text.
 233         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 234
 235 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 236             Sergio Durigan Junior  <sergiodj@redhat.com>
 237
 238         PR win32/24284
 239         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 240
 241 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 242
 243         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 244         when searching for types.
 245
 246 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         * f-lang.c (f_language_defn): Use f_print_typedef.
 249         * f-lang.h (f_print_typedef): Declare.
 250         * f-typeprint.c (f_print_typedef): Define.
 251
 252 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 253
 254         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 255
 256 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 257
 258         * cli/cli-utils.c (info_print_options_defs): Delete.
 259         (make_info_print_options_def_group): Delete.
 260         (extract_info_print_options): Delete.
 261         (info_print_command_completer): Delete.
 262         (info_print_args_help): Add extra parameter, and optionally
 263         include text about -n flag.
 264         * cli/cli-utils.h (struct info_print_options): Delete.
 265         (extract_info_print_options): Delete declaration.
 266         (info_print_command_completer): Delete declaration.
 267         (info_print_args_help): Add extra parameter, extend header
 268         comment.
 269         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 270         search_symbols.
 271         * stack.c (struct info_print_options): New type.
 272         (info_print_options_defs): New file scoped variable.
 273         (make_info_print_options_def_group): New static function.
 274         (info_print_command_completer): New static function.
 275         (info_locals_command): Update to use new local functions.
 276         (info_args_command): Likewise.
 277         (_initialize_stack): Add extra parameter to calls to
 278         info_print_args_help.
 279         * symtab.c (search_symbols): Add extra parameter, use this to
 280         possibly excluse non-debug symbols.
 281         (symtab_symbol_info): Add extra parameter, which is passed on to
 282         search_symbols.
 283         (struct info_print_options): New type.
 284         (info_print_options_defs): New file scoped variable.
 285         (make_info_print_options_def_group): New static function.
 286         (info_print_command_completer): New static function.
 287         (info_variables_command): Update to use local functions, and pass
 288         extra parameter through to symtab_symbol_info.
 289         (info_functions_command): Likewise.
 290         (info_types_command): Pass additional argument through to
 291         symtab_symbol_info.
 292         (rbreak_command): Pass extra argument to search_symbols.
 293         (_initialize_symtab): Add extra arguments for calls to
 294         info_print_args_help, and update help text for 'info variables',
 295         'whereis', and 'info functions' commands.
 296         * symtab.h (search_symbols): Add extra argument to declaration.
 297         * NEWS: Mention new flags.
 298
 299 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 300
 301         * symtab.c (lookup_static_symbol): Call the new function (and move
 302         it down to be next to lookup_global_symbol).
 303         (struct global_sym_lookup_data): Add block_enum member and rename to...
 304         (struct global_or_static_sym_lookup_data): ...this.
 305         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 306         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 307         (lookup_symbol_global_or_static_iterator_cb): ...this.
 308         (lookup_global_or_static_symbol): New function.
 309         (lookup_global_symbol): Call new function.
 310
 311 2019-08-26  Tom de Vries  <tdevries@suse.de>
 312
 313         PR c++/24852
 314         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 315         when pc_probe.prob == NULL.
 316
 317 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 318
 319         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 320         variable symbol_linkage to symbol_linkage_.
 321
 322 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 323
 324         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 325         represent whether the symbol is static, dynamic, or we don't
 326         know.
 327
 328 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 329
 330         * gdb/rx-tdep.c (rx_register_names): New.
 331         (rx_register_name): Delete.
 332         (rx_psw_type): Delete.
 333         (rx_fpsw_type): Delete.
 334         (rx_register_type): Delete.
 335         (rx_gdbarch_init): Convert target-descriptions.
 336         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 337         * gdb/features/Makefile: Add rx.xml.
 338         * gdb/features/rx.xml: New.
 339         * gdb/features/rx.c: Generated.
 340         * gdb/NEWS: Mention target description support.
 341
 342 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 345         *slot_ptr.
 346
 347 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 348
 349         * configure.ac: Don't check for 'dlfcn.h' (moved to
 350         gdbsupport/common.m4).
 351         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 352         'gdbsupport/'.
 353         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 354         * compile/compile-c-support.c: Include
 355         'gdbsupport/gdb-dlfcn.h'.
 356         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 357         * gdb-dlfcn.c: Move to...
 358         * gdbsupport/gdb-dlfcn.c: ... here.
 359         * gdb-dlfcn.h: Move to...
 360         * gdbsupport/gdb-dlfcn.h: ... here.
 361
 362 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 363
 364         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 365         the offset field signed.
 366
 367 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 368
 369         * python/lib/gdb/__init__.py (_execute_file): New function.
 370         * python/python.c (python_run_simple_file): Call gdb._execute_file
 371         on Windows.
 372
 373 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 376         all uses as this was never set to anything but a zero value.
 377
 378 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 379
 380         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 381
 382 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 383
 384         * tui/tui-data.h (tui_gen_win_info): Add an =default
 385         move constructor, required by some GCC versions.
 386
 387 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 388
 389         * go32-nat.c (go32_sysinfo): Add hygon_p.
 390
 391 2019-08-20  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 394         line_from_reg_element_no, first_reg_element_no_inline,
 395         display_all_data, delete_data_content_windows,
 396         erase_data_content>: Now private.
 397
 398 2019-08-20  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 401         (tui_unhighlight_win, tui_highlight_win)
 402         (tui_win_info::make_window): Update.
 403         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 404
 405 2019-08-20  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 408         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 409         (MAX_PID_WIDTH): Move to tui-stack.c.
 410         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 411         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 412         (MAX_PID_WIDTH): Move from tui-data.h.
 413
 414 2019-08-20  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 417         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 418         (box_win): Update.
 419         (tui_gen_win_info::make_window): Rename from tui_make_window.
 420         (tui_win_info::make_window): New method.
 421         (tui_gen_win_info::make_visible): Update.
 422         * tui/tui-source.c (tui_source_window::set_contents): Update.
 423         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 424         (tui_data_window::display_registers_from): Update.
 425         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 426         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 427         Declare.
 428         <can_box>: Remove.
 429         <title>: Remove.
 430         (struct tui_win_info) <make_window>: Declare.
 431         <can_box>: Now virtual.
 432         <title>: New member.
 433         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 434         * tui/tui-command.c (tui_cmd_window::resize): Update.
 435
 436 2019-08-20  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 439         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 440         (tui_data_window::check_register_values): Update.
 441
 442 2019-08-20  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-regs.h (struct tui_data_window): Use
 445         DISABLE_COPY_AND_ASSIGN.
 446         <regs_content>: Change type, removing unique_ptr.
 447         <tui_data_window>: Add move constructor.
 448         * tui/tui-regs.c (tui_data_window::show_registers)
 449         (tui_data_window::show_register_group)
 450         (tui_data_window::display_registers_from)
 451         (tui_data_window::display_registers_from)
 452         (tui_data_window::first_data_item_displayed)
 453         (tui_data_window::delete_data_content_windows)
 454         (tui_data_window::rerender, tui_data_window::refresh_window)
 455         (tui_data_window::check_register_values): Update.
 456
 457 2019-08-20  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 460         show_register_group>: Declare.
 461         (tui_show_register_group): Don't declare.
 462         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 463         tui_show_registers.
 464         (tui_data_window::show_register_group): Rename from
 465         tui_show_register_group.
 466         (tui_data_window::check_register_values, tui_reg_command):
 467         Update.
 468         * tui/tui-layout.c (tui_set_layout): Update.
 469
 470 2019-08-20  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 473         Declare.
 474         (tui_check_register_values): Don't declare.
 475         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 476         from tui_check_register_values.
 477         * tui/tui-hooks.c (tui_register_changed): Update.
 478
 479 2019-08-20  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-regs.c (tui_reg_layout): Move later.
 482         (tui_show_registers): Don't enable TUI mode or change layout.
 483
 484 2019-08-20  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-regs.h (struct tui_data_item_window)
 487         <~tui_data_item_window>: Remove.
 488         <content>: Now a unique_xmalloc_ptr.
 489         * tui/tui-regs.c (tui_register_format): Return a
 490         unique_xmalloc_ptr.
 491         (tui_get_register): Update.
 492         (~tui_data_item_window): Remove.
 493         (tui_data_window::display_registers_from, tui_display_register):
 494         Update.
 495         * tui/tui-io.h (tui_expand_tabs): Update.
 496         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 497         Remove "col" parameter.
 498
 499 2019-08-20  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 502         field.
 503         * tui/tui-regs.c (~tui_data_item_window): Update.
 504
 505 2019-08-20  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 508         earlier.
 509
 510 2019-08-20  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 513
 514 2019-08-20  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-source.h (struct tui_source_window): Update.
 517         * tui/tui-regs.c (tui_show_registers): Update.
 518         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 519         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 520         (NO_REGS_STRING): Remove defines.
 521
 522 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 523
 524         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 525         unnecessary thread walk if remote doesn't support the packet.
 526
 527 2019-08-19  Tom Tromey  <tromey@adacore.com>
 528
 529         * python/py-value.c (value_has_field): Fix indentation.
 530
 531 2019-08-19  Tom Tromey  <tromey@adacore.com>
 532
 533         * printcmd.c (do_one_display, info_display_command): Update.
 534         * block.h (contained_in): Return bool.  Add allow_nested
 535         parameter.
 536         * block.c (contained_in): Return bool.  Add allow_nested
 537         parameter.
 538
 539 2019-08-19  Tom Tromey  <tom@tromey.com>
 540
 541         * configure: Rebuild.
 542         * configure.ac: Disallow the combination of -static-libstdc++ and
 543         source highlight.
 544         * source-cache.c (get_language_name): Handle rust.
 545         (source_cache::get_source_lines): Ignore highlighting exceptions.
 546
 547 2019-08-16  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 550         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 551         (struct tui_source_window_base) <make_visible, refresh_window,
 552         resize>: Remove methods.
 553         <execution_info>: Remove field.
 554         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 555         (tui_show_source_line, tui_source_window_base)
 556         (~tui_source_window_base): Update.
 557         (tui_source_window_base::resize)
 558         (tui_source_window_base::make_visible)
 559         (tui_source_window_base::refresh_window): Remove.
 560         (tui_source_window_base::update_exec_info): Update.
 561         * tui/tui-source.c (tui_source_window::set_contents): Update.
 562         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 563
 564 2019-08-16  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 567         deprecated_query_hook.
 568
 569 2019-08-16  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 572         (tui_update_source_windows_with_line): Update.
 573         * tui/tui-source.h (struct tui_source_window)
 574         <show_symtab_source>: Declare.
 575         (tui_show_symtab_source): Don't declare.
 576         * tui/tui-source.c (tui_show_symtab_source): Rename from
 577         tui_show_symtab_source.
 578
 579 2019-08-16  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-winsource.h (struct tui_source_window_base)
 582         <set_contents>: Declare.
 583         * tui/tui-winsource.c
 584         (tui_source_window_base::update_source_window_as_is): Update.
 585         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 586         Declare.
 587         (tui_set_source_content): Don't declare.
 588         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 589         tui_set_source_content.
 590         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 591         Declare.
 592         (tui_set_disassem_content): Don't declare.
 593         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 594         tui_set_disassem_content.
 595
 596 2019-08-16  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-winsource.h (struct tui_source_window_base)
 599         <update_breakpoint_info>: Declare.
 600         (tui_update_breakpoint_info): Don't declare.
 601         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 602         (tui_update_all_breakpoint_info): Update.
 603         (tui_source_window_base::update_breakpoint_info): Rename from
 604         tui_update_breakpoint_info.
 605         (tui_source_window_base::update_exec_info): Update.
 606
 607 2019-08-16  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-winsource.h (struct tui_source_window_base)
 610         <update_source_window>: Declare.
 611         (tui_update_source_window): Don't declare.
 612         * tui/tui-winsource.c
 613         (tui_source_window_base::update_source_window): Rename from
 614         tui_update_source_window.
 615         (tui_source_window_base::rerender): Update.
 616         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 617         * tui/tui-disasm.c (tui_show_disassem)
 618         (tui_show_disassem_and_update_source)
 619         (tui_disasm_window::maybe_update): Update.
 620
 621 2019-08-16  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-winsource.h (struct tui_source_window_base)
 624         <update_source_window_as_is>: Declare.
 625         (tui_update_source_window_as_is): Don't declare.
 626         * tui/tui-winsource.c (tui_update_source_window): Update
 627         (tui_source_window_base::update_source_window_as_is): Rename from
 628         tui_update_source_window_as_is.
 629         (tui_source_window_base::refill): Update.
 630         * tui/tui-source.c (tui_show_symtab_source): Update.
 631         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 632         Update.
 633
 634 2019-08-16  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.h (tui_update_source_window)
 637         (tui_update_source_window_as_is): Remove "noerror" parameter.
 638         * tui/tui-winsource.c (tui_update_source_window)
 639         (tui_update_source_window_as_is): Remove "noerror" parameter.
 640         (tui_update_source_windows_with_addr)
 641         (tui_update_source_windows_with_line)
 642         (tui_source_window_base::rerender)
 643         (tui_source_window_base::refill): Update.
 644         * tui/tui-source.h (tui_set_source_content)
 645         (tui_show_symtab_source): Remove "noerror" parameter.
 646         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 647         parameter.
 648         (tui_show_symtab_source): Likewise.
 649         (tui_source_window::maybe_update): Update.
 650         * tui/tui-disasm.c (tui_show_disassem)
 651         (tui_show_disassem_and_update_source)
 652         (tui_disasm_window::do_scroll_vertical)
 653         (tui_disasm_window::maybe_update): Update.
 654
 655 2019-08-16  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui.c (tui_is_window_visible): Update.
 658         * tui/tui-wingeneral.c (tui_make_window)
 659         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 660         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 661         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 662         (tui_set_win_height_command, parse_scrolling_args): Update.
 663         * tui/tui-source.c (tui_source_window::style_changed): Update.
 664         * tui/tui-regs.c (tui_show_registers)
 665         (tui_data_window::first_data_item_displayed)
 666         (tui_data_window::delete_data_content_windows)
 667         (tui_check_register_values, tui_reg_command): Update.
 668         * tui/tui-disasm.c (tui_show_disassem): Update.
 669         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 670         method.
 671         <is_visible>: Remove field.
 672         * tui/tui-data.c (tui_next_win, tui_prev_win)
 673         (tui_delete_invisible_windows): Update.
 674
 675 2019-08-16  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-winsource.h (struct tui_source_window_base)
 678         <m_has_locator>: Remove.
 679         * tui/tui-layout.c (show_source_disasm_command, show_data)
 680         (show_source_or_disasm_and_command): Update.
 681
 682 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 683
 684         * NEWS (Other MI changes): New subsection.
 685         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 686         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 687         * arch-utils.c (default_get_pc_address_flags): New function.
 688         * arch-utils.h (default_get_pc_address_flags): New declaration.
 689         * gdbarch.sh: Add get_pc_address_flags.
 690         * gdbarch.c: Regenerate.
 691         * gdbarch.h: Likewise.
 692         * stack.c (print_pc): New function.
 693         (print_frame_info) (print_frame): Call print_pc.
 694
 695 2019-08-16  Tom de Vries  <tdevries@suse.de>
 696
 697         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 698         print_objfile_section_info.
 699
 700 2019-08-15  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 703         calling update_cmdwin_start_line.
 704         * tui/tui-winsource.h (struct tui_source_window_base)
 705         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 706         <rerender>: Declare.
 707         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 708         Call rerender.
 709         (tui_source_window_base::set_new_height): Remove.
 710         (tui_source_window_base::rerender): Rename from
 711         do_make_visible_with_new_height.
 712         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 713         resize method.
 714         (tui_win_info::make_invisible_and_set_new_height)
 715         (tui_win_info::make_visible_with_new_height): Remove.
 716         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 717         Declare.
 718         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 719         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 720         do_make_visible_with_new_height>: Don't declare.
 721         <rerender>: Declare.
 722         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 723         set_new_height.
 724         (tui_data_window::do_make_visible_with_new_height): Remove.
 725         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 726         call tui_show_locator_content.
 727         (tui_gen_win_info::resize): Call rerender.
 728         (show_source_or_disasm_and_command): Don't call
 729         tui_show_locator_content.
 730         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 731         method.
 732         (struct tui_win_info) <rerender>: Declare.
 733         <set_new_height, make_invisible_and_set_new_height,
 734         make_visible_with_new_height>: Don't declare.
 735         * tui/tui-data.c (tui_win_list::rerender): New method.
 736         * tui/tui-command.h (struct tui_cmd_window)
 737         <do_make_visible_with_new_height>: Don't declare.
 738         * tui/tui-command.c
 739         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 740
 741 2019-08-15  Tom Tromey  <tromey@adacore.com>
 742
 743         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 744         * ada-lang.c (ada_enum_name): Likewise.
 745
 746 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 747
 748         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 749         leading underscore.
 750         (GdbOutputErrorFile): Likewise.
 751         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 752         accordingly.
 753         (execute_unwinders): Rename to have a leading underscore.
 754         (auto_load_packages): Likewise.
 755         (global scope): Adjust call to auto_load_packages accordingly.
 756         (GdbSetPythonDirectory): Likewise.
 757         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 758         instead of execute_unwinders.
 759
 760 2019-08-15  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 763         (show_data): Don't change window visibility.
 764         (tui_gen_win_info::resize): Remove special case for command
 765         window.  Use wresize, when available.
 766         (show_source_or_disasm_and_command): Don't change window
 767         visibility.
 768         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 769         <make_visible>: New method.
 770         * tui/tui-command.c (tui_cmd_window::resize): New method.
 771
 772 2019-08-15  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 775         (struct tui_source_windows): New.
 776         * tui/tui-winsource.c (tui_display_main): Update.
 777         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 778         (new_height_ok, parse_scrolling_args): Update.
 779         * tui/tui-layout.c (show_layout, show_data): Update.
 780         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 781         (tui_add_to_source_windows): Don't declare.
 782         * tui/tui-data.c (source_windows, tui_source_windows)
 783         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 784
 785 2019-08-15  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 788         Rename from reset.
 789         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 790         * tui/tui-layout.c (show_source_disasm_command, show_data):
 791         Update.
 792         (tui_gen_win_info::resize): Rename.
 793         (show_source_or_disasm_and_command): Update.
 794         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 795         reset.
 796
 797 2019-08-15  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 800         * tui/tui-interp.c (tui_interp::init): Don't call
 801         tui_initialize_static_data.
 802         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 803
 804 2019-08-15  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 807         examine tui_win_list.
 808
 809 2019-08-15  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 812         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 813         tui_clear_source_content.
 814         (tui_clear_source_content): Remove.
 815         (tui_source_window_base::do_erase_source_content): Hoist call to
 816         content.clear().
 817         * tui/tui-stack.c (tui_show_frame_info): Don't call
 818         tui_clear_source_content.
 819
 820 2019-08-15  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-winsource.h (struct tui_source_window_base)
 823         <do_erase_source_content>: New method.
 824         <erase_source_content>: New method.
 825         (tui_erase_source_content): Don't declare.
 826         * tui/tui-winsource.c (tui_clear_source_content): Update.
 827         (tui_source_window_base::do_erase_source_content): Rename from
 828         tui_erase_source_content.
 829         (tui_source_window_base::show_source_content): Update.
 830         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 831         * tui/tui-source.h (struct tui_source_window)
 832         <erase_source_content>: New method.
 833         * tui/tui-disasm.h (struct tui_disasm_window)
 834         <erase_source_content>: New method.
 835
 836 2019-08-15  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 839         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 840         constructor.
 841         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 842         * tui/tui-source.c (tui_set_source_content): Update.
 843         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 844
 845 2019-08-15  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 848         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 849         tui-source.c.
 850         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 851         Declare.
 852         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 853         method.
 854         (tui_source_window::maybe_update): Update.
 855
 856 2019-08-15  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 859         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 860         tui-disasm.c.
 861         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 862         Declare.
 863         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 864         method.
 865         (tui_disasm_window::maybe_update): Update.
 866
 867 2019-08-15  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-winsource.h (struct tui_source_window_base)
 870         <maybe_update>: Declare.
 871         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 872         method.
 873         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 874         Declare.
 875         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 876         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 877         Declare.
 878         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 879
 880 2019-08-15  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 883
 884 2019-08-15  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-wingeneral.c: Include tui-stack.h.
 887         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 888         (struct tui_locator_window): Move from tui-data.h.
 889         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 890         (tui_initialize_static_data): Move from tui-data.c.
 891         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 892         (struct tui_locator_window): Move to tui-stack.c.
 893         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 894         (tui_initialize_static_data): Move to tui-stack.c.
 895
 896 2019-08-15  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-layout.c (show_source_disasm_command)
 899         (show_source_or_disasm_and_command): Use make_visible method, not
 900         tui_make_window.
 901         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 902         Remove.
 903
 904 2019-08-15  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-wingeneral.h (tui_make_window): Update.
 907         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 908         parameter.
 909         (tui_gen_win_info::make_visible): Update.
 910         * tui/tui-regs.c (tui_data_window::display_registers_from):
 911         Update.
 912         * tui/tui-layout.c (show_source_disasm_command)
 913         (show_source_or_disasm_and_command): Update.
 914         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 915         (enum tui_box): Remove.
 916         (struct tui_win_info) <can_box>: New method.
 917         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 918         method.
 919
 920 2019-08-15  Tom de Vries  <tdevries@suse.de>
 921
 922         * linux-nat-trad.c: Include gdbarch.h.
 923
 924 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 925
 926         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 927         register sizes.
 928
 929 2019-08-14  Tom Tromey  <tromey@adacore.com>
 930
 931         * darwin-nat.c: Include gdbarch.h.
 932         * darwin-nat-info.c: Include gdbarch.h.
 933
 934 2019-08-13  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 937         Remove.
 938         * tui/tui-data.c (tui_initialize_static_data): Update.
 939
 940 2019-08-13  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-winsource.h (struct tui_exec_info_window)
 943         <~tui_exec_info_window, maybe_allocate_content, get_content,
 944         m_content>: Remove.
 945         (struct tui_source_window_base) <set_exec_info_content,
 946         show_exec_info_content>: Don't declare.
 947         * tui/tui-winsource.c
 948         (tui_exec_info_window::maybe_allocate_content): Remove.
 949         (tui_source_window_base::update_exec_info): Rename from
 950         set_exec_info_content.
 951         (tui_source_window_base::show_exec_info_content)
 952         (tui_source_window_base::update_exec_info): Remove.
 953
 954 2019-08-13  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 957         declare.
 958         * tui/tui-winsource.c (tui_update_source_window_as_is)
 959         (tui_update_source_windows_with_addr, tui_erase_source_content):
 960         Update.
 961         (tui_clear_exec_info_content): Remove.
 962
 963 2019-08-13  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 966         declare.
 967         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 968         call tui_erase_exec_info_content.
 969         (tui_clear_exec_info_content): Rename from
 970         tui_erase_exec_info_content.
 971         (tui_clear_exec_info_content): Delete.
 972
 973 2019-08-13  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-winsource.h (struct tui_source_window_base)
 976         <show_exec_info_content>: Declare.
 977         (tui_show_exec_info_content): Don't declare.
 978         * tui/tui-winsource.c
 979         (tui_source_window_base::show_exec_info_content): Rename from
 980         tui_show_exec_info_content.
 981         (tui_source_window_base::update_exec_info): Update.
 982
 983 2019-08-13  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 986         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 987         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 988         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 989         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 990         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 991         ... here.
 992
 993 2019-08-13  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-winsource.h (struct tui_source_window_base)
 996         <update_exec_info>: Declare.
 997         (tui_update_exec_info): Don't declare.
 998         * tui/tui-winsource.c (tui_update_source_window_as_is)
 999         (tui_source_window_base::refresh_all)
1000         (tui_update_all_breakpoint_info): Update.
1001         (tui_source_window_base::update_exec_info): Rename from
1002         tui_update_exec_info.
1003         * tui/tui-stack.c (tui_show_frame_info): Update.
1004
1005 2019-08-13  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-winsource.h (struct tui_source_window_base)
1008         <set_exec_info_content>: Declare.
1009         (tui_set_exec_info_content): Don't declare.
1010         * tui/tui-winsource.c
1011         (tui_source_window_base::set_exec_info_content): Rename from
1012         tui_set_exec_info_content.
1013         (tui_update_exec_info): Update.
1014
1015 2019-08-13  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-winsource.h (struct tui_source_window_base)
1018         <show_source_content>: Declare.
1019         (tui_show_source_content): Don't declare.
1020         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1021         (tui_source_window_base::show_source_content): Rename from
1022         tui_show_source_content.
1023         (tui_source_window_base::refresh_all): Update.
1024         * tui/tui-layout.c (show_source_disasm_command)
1025         (show_source_or_disasm_and_command): Update.
1026
1027 2019-08-13  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-winsource.c (tui_erase_source_content)
1030         (tui_show_source_content, tui_source_window_base::refresh_all):
1031         Update.
1032         * tui/tui-wingeneral.h
1033         (tui_check_and_display_highlight_if_needed): Don't declare.
1034         * tui/tui-wingeneral.c
1035         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1036         check_and_display_highlight_if_needed.
1037         * tui/tui-win.c (tui_rehighlight_all)
1038         (tui_win_info::make_visible_with_new_height): Update.
1039         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1040         (tui_data_window::erase_data_content)
1041         (tui_data_window::display_all_data): Update.
1042         * tui/tui-data.h (struct tui_win_info)
1043         <check_and_display_highlight_if_needed>: Declare.
1044
1045 2019-08-13  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-win.c (tui_resize_all): Call
1048         tui_delete_invisible_windows.
1049         * tui/tui-layout.c (show_layout): Call
1050         tui_delete_invisible_windows.
1051         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1052         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1053
1054 2019-08-13  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1057         tui_add_win_to_layout.
1058
1059 2019-08-13  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1062         * tui/tui-layout.c (tui_default_win_height): Now static.
1063
1064 2019-08-13  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1067         single switch.
1068         (show_source_disasm_command, show_source_or_disasm_and_command):
1069         Don't check current layout.
1070
1071 2019-08-13  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-wingeneral.c (make_all_visible): Remove.
1074         (tui_make_all_invisible): Simplify.
1075         * tui/tui-layout.c (tui_make_all_invisible): Move from
1076         tui-wingeneral.c; simplify.
1077         (show_layout): Hoist call to tui_make_all_invisible.
1078         (show_data): Don't call tui_make_all_invisible.
1079
1080 2019-08-13  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1083         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1084
1085 2019-08-13  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1088         tui-data.c.
1089         (show_source_disasm_command, show_data)
1090         (show_source_or_disasm_and_command): Don't use
1091         tui_set_current_layout_to.
1092         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1093         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1094         tui-layout.c.
1095         (tui_set_current_layout_to): Remove.
1096
1097 2019-08-13  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-layout.c (tui_set_layout): Update.
1100         * tui/tui-data.h (struct tui_layout_def): Remove.
1101         (tui_layout_def): Don't declare.
1102         * tui/tui-data.c (layout_def): Remove.
1103         (tui_layout_def): Remove.
1104
1105 2019-08-13  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-winsource.h (struct tui_source_window_base)
1108         <clear_detail>: No longer "override".
1109         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1110         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1111         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1112         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1113         Remove.
1114         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1115
1116 2019-08-13  Tom Tromey  <tromey@adacore.com>
1117
1118         * tracepoint.c: Don't include readline.h or history.h.
1119
1120 2019-08-12  Tom Tromey  <tom@tromey.com>
1121
1122         * configure: Rebuild.
1123         * configure.ac: Check for readline 7.
1124         * NEWS: Mention readline 7 requirement.
1125         * README: Update.
1126
1127 2019-08-12  Tom Tromey  <tom@tromey.com>
1128
1129         * mingw-hdep.c (gdb_select): Remove readline hack.
1130
1131 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1132
1133         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1134         when the function fails.
1135
1136 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1137
1138         * s390-tdep.c (s390_type_align): New function.
1139         (s390_gdbarch_init): Set it as type_align gdbarch method.
1140
1141 2019-08-09  Tom de Vries  <tdevries@suse.de>
1142
1143         PR gdb/24591
1144         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1145         pc_low with relocation offset.
1146
1147 2019-08-07  Tom Tromey  <tromey@adacore.com>
1148
1149         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1150         (print_frame_args): Update.
1151         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1152         Update.
1153         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1154         * frame.h (struct frame_arg): Add initializers.
1155         <error>: Now a unique_xmalloc_ptr.
1156
1157 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1158
1159         * NEWS: Expand the Pointer Authentication entry.
1160         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1161         (aarch64_frame_unmask_lr): ... to this.
1162         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1163         Call aarch64_frame_unmask_lr.
1164         * frame.c (struct frame_info): Add "masked" variable.
1165         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1166         (fprint_frame): Check for masked pc.
1167         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1168         declarations.
1169         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1170         * stack.c (print_frame): Check for masked pc.
1171
1172 2019-08-06  Tom Tromey  <tom@tromey.com>
1173
1174         * stabsread.c (patch_block_stabs, read_one_struct_field)
1175         (read_enum_type): Use obstack_strndup.
1176         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1177         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1178         * dwarf2read.c (guess_full_die_structure_name)
1179         (anonymous_struct_prefix): Use obstack_strndup.
1180         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1181         * c-exp.y (yylex): Use obstack_strndup.
1182         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1183         (write_var_or_type): Use obstack_strndup.
1184
1185 2019-08-06  Tom Tromey  <tom@tromey.com>
1186
1187         * symfile.c (reread_symbols): Use obstack_strdup.
1188         * stabsread.c (read_type): Use obstack_strdup.
1189         * gdb_obstack.h (obstack_strdup): New overload.
1190         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1191         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1192         (dwarf2_canonicalize_name): Use obstack_strdup.
1193         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1194         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1195         Use obstack_strdup.
1196
1197 2019-08-06  Tom Tromey  <tom@tromey.com>
1198
1199         * gdb_obstack.h (obstack_strdup): Define.
1200         * gdb_obstack.c (obstack_strdup): Don't define.
1201
1202 2019-08-06  Tom Tromey  <tom@tromey.com>
1203
1204         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1205         obstack_strdup.
1206         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1207         obstack_strdup.
1208         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1209         * stabsread.c (common_block_start): Use obstack_strdup.
1210         * objfiles.c (set_objfile_main_name, objfile): Use
1211         obstack_strdup.
1212         * namespace.c (add_using_directive): Use obstack_strdup.
1213         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1214         * jit.c (finalize_symtab): Use obstack_strdup.
1215         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1216         (guess_partial_die_structure_name, partial_die_info::fixup)
1217         (dwarf2_name): Use obstack_strdup.
1218         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1219         obstack_strdup.
1220         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1221         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1222         obstack_strdup.
1223         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1224
1225 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1226
1227         * unittests/help-doc-selftests.c: New file.
1228         * Makefile.in: Add the new file.
1229
1230 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1231
1232         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1233         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1234         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1235         the trailing '.' is not output, and the first character is uppercased.
1236         (print_help_for_command): Update call to print_doc_line.
1237         (print_doc_of_command): Likewise.
1238         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1239         * cli/cli-option.c (append_indented_doc): Do not append newline.
1240         (build_help_option): Append newline after first appended_indented_doc
1241         only if a second call is done.
1242         (build_help): Append 2 new lines before each option, except the first
1243         one.
1244         * compile/compile.c (_initialize_compile): Add new lines after
1245         %OPTIONS%, when not at the end of the help.
1246         Change help doc or code
1247         producing the help doc to respect the invariants.
1248         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1249         Also removed the new line after 'Options:', as all other commands
1250         do not put an empty line between 'Options:' and the first option.
1251         * printcmd.c (_initialize_printcmd): Likewise.
1252         * stack.c (_initialize_stack): Likewise.
1253         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1254         incorrectly telling COMMAND is optional.
1255         * ada-lang.c (_initialize_ada_language): Change help doc or code
1256         producing the help doc to respect the invariants.
1257         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1258         * breakpoint.c (_initialize_breakpoint): Likewise.
1259         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1260         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1261         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1262         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1263         _initialize_cli_style): Likewise.
1264         * corelow.c (core_target_info): Likewise.
1265         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1266         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1267         * filesystem.c (_initialize_filesystem): Likewise.
1268         * frame.c (_initialize_frame): Likewise.
1269         * gnu-nat.c (add_task_commands): Likewise.
1270         * infcall.c (_initialize_infcall): Likewise.
1271         * infcmd.c (_initialize_infcmd): Likewise.
1272         * interps.c (_initialize_interpreter): Likewise.
1273         * language.c (_initialize_language): Likewise.
1274         * linux-fork.c (_initialize_linux_fork): Likewise.
1275         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1276         * maint.c (_initialize_maint_cmds): Likewise.
1277         * memattr.c (_initialize_mem): Likewise.
1278         * printcmd.c (_initialize_printcmd): Likewise.
1279         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1280         _RegEx): Likewise.
1281         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1282         * record-btrace.c (_initialize_record_btrace): Likewise.
1283         * record-full.c (_initialize_record_full): Likewise.
1284         * record.c (_initialize_record): Likewise.
1285         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1286         * regcache.c (_initialize_regcache): Likewise.
1287         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1288         _initialize_remote): Likewise.
1289         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1290         * serial.c (_initialize_serial): Likewise.
1291         * skip.c (_initialize_step_skip): Likewise.
1292         * source.c (_initialize_source): Likewise.
1293         * stack.c (_initialize_stack): Likewise.
1294         * symfile.c (_initialize_symfile): Likewise.
1295         * symtab.c (_initialize_symtab): Likewise.
1296         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1297         * top.c (init_main): Likewise.
1298         * tracefile-tfile.c (tfile_target_info): Likewise.
1299         * tracepoint.c (_initialize_tracepoint): Likewise.
1300         * tui/tui-win.c (_initialize_tui_win): Likewise.
1301         * utils.c (add_internal_problem_command): Likewise.
1302         * valprint.c (value_print_option_defs): Likewise.
1303
1304 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1305
1306         PR build/24886
1307         * configure.ac: Drop enable-libmcheck support.
1308         * configure, config.in: Rebuild.
1309         * libmcheck.m4: Remove.
1310         * acinclude.m4: Don't include it.
1311         * Makefile.in: Don't distribute it.
1312         * top.c (print_gdb_configuration): Don't mention it.
1313
1314 2019-08-06  Tom Tromey  <tom@tromey.com>
1315
1316         * utils.c (set_output_style): Sometimes pass stream to
1317         emit_style_escape.
1318         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1319         * record-btrace.c (btrace_insn_history): Update.
1320         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1321         method.
1322         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1323         Update initializers.
1324         <m_uiout>: New field.
1325         <m_di>: Move lower.
1326         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1327         Remove "uiout" parameter.
1328         (dump_insns): Update.
1329         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1330         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1331
1332 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1333
1334         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1335         (error_in_psymtab_expansion): Likewise.
1336         (lookup_symbol_via_quick_fns): Likewise.
1337         (basic_lookup_transparent_type_quick): Likewise.
1338         (basic_lookup_transparent_type_1): Likewise.
1339
1340 2019-08-06  Tom Tromey  <tromey@adacore.com>
1341
1342         * source.c (last_source_error): Now bool.
1343         (print_source_lines_base): Make "noprint" bool.  Only open
1344         source file when last_source_visited changes.
1345
1346 2019-08-06  Tom Tromey  <tromey@adacore.com>
1347
1348         * annotate.c (annotate_source_line): Use g_source_cache.
1349         * source-cache.c (source_cache::get_plain_source_lines): Change
1350         parameters.  Populate m_offset_cache.
1351         (source_cache::ensure): New method.
1352         (source_cache::get_line_charpos): New method.
1353         (extract_lines): Move lower.  Change parameters.
1354         (source_cache::get_source_lines): Move lower.
1355         * source-cache.h (class source_cache): Update comment.
1356         <get_line_charpos>: New method.
1357         <get_source_lines>: Update comment.
1358         <clear>: Clear m_offset_cache.
1359         <get_plain_source_lines>: Change parameters.
1360         <ensure>: New method
1361         <m_offset_cache>: New member.
1362         * source.c (forget_cached_source_info_for_objfile): Update.
1363         (info_source_command): Use g_source_cache.
1364         (find_source_lines, open_source_file_with_line_charpos): Remove.
1365         (print_source_lines_base, search_command_helper): Use g_source_cache.
1366         * source.h (open_source_file_with_line_charpos): Don't declare.
1367         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1368         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1369         Use g_source_cache.
1370
1371 2019-08-06  Tom Tromey  <tromey@adacore.com>
1372
1373         * source-cache.c (source_cache::get_plain_source_lines):
1374         Remove "first_line" and "last_line" parameters.
1375         (source_cache::get_source_lines): Cache plain text.
1376         * source-cache.h (class source_cache)
1377         <get_plain_source_lines>: Update.
1378
1379 2019-08-06  Tom Tromey  <tromey@adacore.com>
1380
1381         * source-cache.c (extract_lines): No longer a method.
1382         Changed type of parameter.  Include final newline.
1383         (selftests::extract_lines_test): New function.
1384         (_initialize_source_cache): Likewise.
1385         * source-cache.h (class source_cache)
1386         <extract_lines>: Don't declare.
1387
1388 2019-08-06  Tom Tromey  <tromey@adacore.com>
1389
1390         * breakpoint.c (init_breakpoint_sal): Update.
1391         (breakpoint): Update.
1392         * breakpoint.h (struct breakpoint) <filter>: Now a
1393         unique_xmalloc_ptr.
1394
1395 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1396
1397         * NEWS: Mention dictionary access on blocks.
1398         * python/py-block.c (blpy_getitem): New function.
1399         (block_object_as_mapping): New struct.
1400         (block_object_type): Use new struct for tp_as_mapping field.
1401
1402 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1403
1404         * objfiles.h (objfile): Add a comment describing partial symbols.
1405
1406 2019-08-05  Tom Tromey  <tromey@adacore.com>
1407
1408         * compile/compile.c (_initialize_compile): Use _(), not N_().
1409         * thread.c (_initialize_thread): Use _(), not N_().
1410         * stack.c (_initialize_stack): Use _(), not N_().
1411         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1412
1413 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1414
1415         * dwarf2read.c (struct dw2_symtab_iterator):
1416         <want_specific_block>: Remove.
1417         <block_index>: Change type to gdb::optional.
1418         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1419         change type of BLOCK_INDEX parameter to gdb::optional.
1420         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1421         (dw2_lookup_symbol): Don't pass argument for
1422         WANT_SPECIFIC_BLOCK.
1423         (dw2_expand_symtabs_for_function): Don't pass argument for
1424         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1425         (class dw2_debug_names_iterator)
1426         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1427         parameter, change BLOCK_INDEX type to gdb::optional.
1428         <m_want_specific_block>: Remove.
1429         <m_block_index>: Change type to gdb::optional.
1430         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1431         gdb::optional.  Re-write in function of gdb::optional.
1432         (dw2_debug_names_lookup_symbol): Don't pass argument for
1433         WANT_SPECIFIC_BLOCK.
1434         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1435         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1436         BLOCK_INDEX.
1437
1438 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1439
1440         * NEWS: Mention changes to "info sources" command.
1441
1442 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1443
1444         * symtab.c (filename_partial_match_opts): New struct type.
1445         (struct output_source_filename_data): New members
1446         regexp, c_regexp, partial_match.
1447         (output_source_filename): Use new members to decide to print file.
1448         (info_sources_option_defs): New variable.
1449         (make_info_sources_options_def_group, print_info_sources_header,
1450         info_sources_command_completer):
1451         New functions.
1452         (info_sources_command): Read new optional arguments.
1453         (_initialize_symtab): Update info sources help.
1454
1455 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1456
1457         * ada-lang.c (exception_support_info_v0): Renamed from...
1458         (default_exception_support_info): ... this.  Create new
1459         definition for v1.
1460         (ada_has_this_exception_support): Look up catch_handlers_sym.
1461         (ada_exception_support_info_sniffer): Try v0 after default.
1462
1463 2019-08-01  Tom Tromey  <tromey@adacore.com>
1464
1465         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1466         gdbarch.h.
1467
1468 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1469
1470         * s12z-tdep.c: Fix include path for s12z-opc.h.
1471
1472 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1473
1474         * NEWS: Require GNU make 3.82.
1475
1476 2019-07-16  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1479         declare.
1480
1481 2019-07-30  Tom Tromey  <tromey@adacore.com>
1482
1483         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1484
1485 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1486
1487         * printcmd.c (print_address_symbolic): Print negative offsets.
1488         (build_address_symbolic): Force signed arithmetic when computing
1489         offset.
1490
1491 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1492
1493         PR/24474: Add a function to lookup static variables.
1494         * NEWS: Mention this new function.
1495         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1496         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1497         * python/python.c (python_GdbMethods): Add new function.
1498
1499 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1500
1501         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1502         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1503         (objfpy_lookup_static_symbol): New function.
1504         (objfile_object_methods): Add new functions.
1505
1506 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1507
1508         * NEWS: Mention 'set|show print frame-info'.  Mention new
1509         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1510         backtrace argument.  Mention that python frame filtering code
1511         is now consistent with what 'backtrace' command prints.
1512
1513 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1514
1515         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1516         comments.
1517         (print_frame_info_auto, print_frame_info_source_line,
1518         print_frame_info_location, print_frame_info_source_and_location,
1519         print_frame_info_location_and_address, print_frame_info_short_location):
1520         New declarations.
1521         (struct frame_print_options): New member print_frame_info.
1522         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1523         * stack.h (get_user_print_what_frame_info): New declaration.
1524         (frame_show_address): New declaration.
1525         * stack.c (print_frame_arguments_choices): New value 'presence'.
1526         (print_frame_info_auto, print_frame_info_source_line,
1527         print_frame_info_location, print_frame_info_source_and_location,
1528         print_frame_info_location_and_address, print_frame_info_short_location,
1529         print_frame_info_choices, print_frame_info_print_what): New definitions.
1530         (print_frame_args): Only print dots for args if print frame-arguments
1531         is 'presence'.
1532         (frame_print_option_defs): New element for "frame-info".
1533         (get_user_print_what_frame_info): New function.
1534         (frame_show_address): Make non static.  Move comment to stack.h.
1535         (print_frame_info_to_print_what): New function.
1536         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1537         to decide what to print.
1538         (backtrace_command_1): Handle the new print_frame_arguments_presence
1539         value.
1540         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1541         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1542         (py_print_frame): In non-mi mode, use LOCATION as default for
1543         print_what, similarly to frame information printed directly by
1544         backtrace command. Handle frame-info user option in non MI mode.
1545
1546 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1547
1548         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1549         Add case for debugging 32-bit target on 64-bit host.  Revise
1550         comment.
1551
1552 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1553
1554         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1555         instead of find_function_entry_range_from_pc.
1556
1557 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1558
1559         * stack.c (find_frame_funname): Remove code which preferred
1560         minsym over symtab sym in "certain pathological cases".
1561
1562         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1563         parameter.  Change type of "do_demangle" to bool.
1564         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1565         Pass suitable "prefer_sym_over_minsym" flag to
1566         build_address_symbolic().  Don't output "+" for negative offsets.
1567         * printcmd.c (print_address_symbolic): Update invocation of
1568         build_address_symbolic to include a "prefer_sym_over_minsym"
1569         flag.
1570         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1571         Restrict cases in which use of minimal symbol is preferred to that
1572         of a found symbol.  Update comments.
1573
1574         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1575         for entry pc when entry pc is out of range for that FDE.
1576
1577 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1578
1579         PR gdb/24839:
1580         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1581         type.
1582
1583 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1584
1585         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1586         this function's Python signature.
1587
1588
1589 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1590
1591         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1592         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1593         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1594         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1595         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1596
1597
1598 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1599
1600         * h8300-tdep.c (h8300_register_name_common): New.
1601         h8300_register_name): Use h8300_register_name_common.
1602         (h8300s_register_name): Likewise.
1603         (h8300sx_register_name): Likewise.
1604         (h8300h_register_nam): New.
1605         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1606
1607
1608 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1609
1610         * arm-tdep.c (arm_skip_cmse_entry): New function.
1611         (arm_is_sgstubs_section): New function.
1612         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1613
1614 2019-07-22  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1617         Don't self-assign.
1618
1619 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1620
1621         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1622         type_print.
1623
1624 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1625
1626         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1627         so that GDB doesn't match any msymbols when searching in the
1628         TYPES_DOMAIN.
1629         (print_symbol_info): Print using typedef_print or type_print based
1630         on the type of the symbol.  Add updated FIXME comment moved from...
1631         (_initialize_symtab): ... move and update FIXME comment to above.
1632
1633 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * NEWS: Mention adding -q option to "info types".
1636         * symtab.c (struct info_types_options): New struct.
1637         (info_types_options_defs): New variable.
1638         (make_info_types_options_def_group): New function.
1639         (info_types_command): Use gdb::option framework to parse options.
1640         (info_types_command_completer): New function.
1641         (_initialize_symtab): Extend the help text on "info types" and
1642         register command completer.
1643
1644 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1645
1646         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1647         (lookup_symbol_in_objfile): Change int to block_enum and add a
1648         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1649
1650 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1651
1652         * MAINTAINERS (Write After Approval): Add self.
1653
1654 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1655
1656         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1657         instruction to the dummy code region.
1658
1659 2019-07-19  Tom Tromey  <tromey@adacore.com>
1660
1661         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1662         (ARGSUSED, PARAMS, __func__): Remove rules.
1663
1664 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1665
1666         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1667         * features/arm/arm-with-iwmmxt.c: Remove.
1668         * features/arm/arm-with-iwmmxt.xml: Remove.
1669         * features/arm/arm-with-m-fpa-layout.c: Remove.
1670         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1671         * features/arm/arm-with-m-vfp-d16.c: Remove.
1672         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1673         * features/arm/arm-with-m.c: Remove.
1674         * features/arm/arm-with-m.xml: Remove.
1675         * features/arm/arm-with-neon.c: Remove.
1676         * features/arm/arm-with-neon.xml: Remove.
1677         * features/arm/arm-with-vfpv2.c: Remove.
1678         * features/arm/arm-with-vfpv2.xml: Remove.
1679         * features/arm/arm-with-vfpv3.c: Remove.
1680         * features/arm/arm-with-vfpv3.xml: Remove.
1681
1682 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1683
1684         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1685
1686 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1687
1688         * arch/aarch32.c (aarch32_create_target_description): Create
1689         target descriptions using features.
1690         * arch/arm.c (arm_create_target_description)
1691         (arm_create_mprofile_target_description): Likewise.
1692         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1693
1694 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1695
1696         * Makefile.in: Add new files.
1697         * aarch32-tdep.c: New file.
1698         * aarch32-tdep.h: New file.
1699         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1700         Call aarch32_read_description.
1701         * arch/aarch32.c: New file.
1702         * arch/aarch32.h: New file.
1703         * arch/arm.c (arm_create_target_description)
1704         (arm_create_mprofile_target_description): New function.
1705         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1706         (arm_create_target_description)
1707         (arm_create_mprofile_target_description): New declaration.
1708         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1709         read_description functions.
1710         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1711         Likewise.
1712         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1713         * arm-tdep.c (tdesc_arm_list): New variable.
1714         (arm_register_g_packet_guesses): Call create description functions.
1715         (arm_read_description) (arm_read_mprofile_description): New
1716         function.
1717         * arm-tdep.h (arm_read_description)
1718         (arm_read_mprofile_description): Add declaration.
1719         * configure.tgt: Add new files.
1720
1721 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1722
1723         * top.c (new_ui_command): Open specified terminal just once.
1724
1725 2019-07-18  Tom Tromey  <tromey@adacore.com>
1726
1727         * symtab.c (main_name): Constify return type.
1728         * symfile.c (set_initial_language): Update.
1729         * symtab.h (main_name): Constify return type.
1730
1731 2019-07-17  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-winsource.c (tui_update_source_window)
1734         (tui_update_source_window_as_is)
1735         (tui_update_source_windows_with_line): Remove return.
1736         * tui/tui-disasm.c (tui_show_disassem)
1737         (tui_show_disassem_and_update_source): Remove return.
1738         * tui/tui.c (tui_reset): Remove return.
1739         * tui/tui-wingeneral.c
1740         (tui_check_and_display_highlight_if_needed): Remove return.
1741
1742 2019-07-17  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-winsource.h (struct tui_exec_info_window)
1749         (struct tui_source_window_base): Move from tui-data.h.
1750         * tui/tui-winsource.c: Move many method definitions from
1751         elsewhere.  Remove "structuring" comments.
1752         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1753         (tui_source_window_base::refresh_window): Move to
1754         tui-winsource.c.
1755         * tui/tui-win.c (tui_source_window_base::refresh_all)
1756         (tui_source_window_base::update_tab_width)
1757         (tui_source_window_base::set_new_height)
1758         (tui_source_window_base::do_make_visible_with_new_height): Move to
1759         tui-winsource.c.
1760         * tui/tui-source.h: Update.
1761         * tui/tui-source.c (tui_source_window_base::reset): Move to
1762         tui-winsource.c.
1763         * tui/tui-disasm.h: Update.
1764         * tui/tui-data.h (struct tui_exec_info_window): Move to
1765         tui-winsource.h.
1766         (struct tui_source_window_base): Likewise.
1767         * tui/tui-data.c (tui_source_window_base::clear_detail)
1768         (tui_source_window_base, ~tui_source_window_base): Move to
1769         tui-winsource.c.
1770
1771 2019-07-17  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-win.c (tui_resize_all)
1774         (tui_source_window_base::update_tab_width)
1775         (tui_adjust_win_heights): Update.
1776         (tui_win_info::make_invisible_and_set_new_height): Rename from
1777         make_invisible_and_set_new_height.
1778         * tui/tui-data.h (struct tui_win_info)
1779         <make_invisible_and_set_new_height>: New method.
1780
1781 2019-07-17  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui.c: Update.
1784         * tui/tui-source.h (struct tui_source_window): Move from
1785         tui-data.h.
1786         * tui/tui-layout.c: Update.
1787         * tui/tui-disasm.c: Update.
1788         * tui/tui-data.h (struct tui_source_window): Move to
1789         tui-source.h.
1790
1791 2019-07-17  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1794         tui-data.h.
1795         * tui/tui-data.h (struct tui_disasm_window): Move to
1796         tui-disasm.h.
1797
1798 2019-07-17  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-regs.h (struct tui_data_item_window): Move from
1801         tui-data.h.
1802         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1803         * tui/tui-data.h (struct tui_data_item_window): Move to
1804         tui-regs.h.
1805         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1806
1807 2019-07-17  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui.c: Update.
1810         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1811         (tui_cmd_window::max_height): Move to tui-command.c.
1812         * tui/tui-layout.c: Update.
1813         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1814         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1815         tui-command.c.
1816         * tui/tui-command.h (struct tui_cmd_window): Move from
1817         tui-data.h.
1818         * tui/tui-command.c: Remove "structuring" comments.
1819         (tui_cmd_window::clear_detail)
1820         (tui_cmd_window::do_make_visible_with_new_height)
1821         (tui_cmd_window::max_height): Move from elsewhere.
1822
1823 2019-07-17  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1826         Now static.
1827         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1828         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1829
1830 2019-07-17  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui.c: Update.
1833         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1834         tui-regs.c.
1835         * tui/tui-windata.h: Remove file.
1836         * tui/tui-windata.c: Remove file.
1837         * tui/tui-win.c (tui_data_window::set_new_height)
1838         (tui_data_window::do_make_visible_with_new_height): Move to
1839         tui-regs.c.
1840         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1841         * tui/tui-regs.c: Remove "structuring" comments.
1842         (tui_data_window::first_data_item_displayed)
1843         (tui_data_window::delete_data_content_windows)
1844         (tui_data_window::erase_data_content)
1845         (tui_data_window::display_all_data)
1846         (tui_data_window::refresh_all)
1847         (tui_data_window::do_scroll_vertical)
1848         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1849         (tui_data_window::do_make_visible_with_new_height)
1850         (tui_data_window::refresh_window): Move from elsewhere.
1851         (_initialize_tui_regs): Move to end of file.
1852         * tui/tui-layout.c: Update.
1853         * tui/tui-hooks.c: Update.
1854         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1855         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1856         tui-regs.c.
1857         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1858
1859 2019-07-17  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1862         seen.
1863
1864 2019-07-17  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-win.c (tui_source_window_base::set_new_height)
1867         (tui_source_window_base::do_make_visible_with_new_height): Use
1868         m_has_locator field directly.
1869         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1870         method.
1871         (struct tui_source_window_base) <has_locator>: Likewise.
1872
1873 2019-07-17  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1876         Don't declare.
1877         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1878         Remove.
1879         * tui/tui-win.c (tui_source_window_base::set_new_height)
1880         (tui_source_window_base::set_new_height)
1881         (make_invisible_and_set_new_height)
1882         (tui_source_window_base::do_make_visible_with_new_height)
1883         (tui_source_window_base::do_make_visible_with_new_height):
1884         Update.
1885         * tui/tui-layout.c (show_source_disasm_command, show_data)
1886         (show_source_or_disasm_and_command): Update.
1887         * tui/tui-layout.c (show_layout): Update.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-layout.c (make_data_window): Remove.
1892         (show_data): Unify creation and re-initialization cases.
1893
1894 2019-07-17  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-layout.c (make_source_window, make_disasm_window):
1897         Remove.
1898         (show_data): Unify creation and re-initialization cases.
1899
1900 2019-07-17  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-layout.c (make_command_window): Remove.
1903         (show_source_disasm_command, show_source_or_disasm_and_command):
1904         Unify creation and re-initialization cases.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1909         creation and re-initialization cases.
1910
1911 2019-07-17  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-regs.c (tui_get_register): Return void.
1914
1915 2019-07-17  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1918         Simplify.
1919
1920 2019-07-17  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1923         resetting.
1924
1925 2019-07-17  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1928         * tui/tui-regs.c (tui_reg_layout): New function.
1929         (tui_show_registers, tui_reg_command): Use it.
1930         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1931         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1932         parameters.
1933         (tui_layout_command): Remove.
1934
1935 2019-07-17  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-layout.h (tui/tui-layout): Return void.
1938         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1939
1940 2019-07-17  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-layout.c (show_source_disasm_command, show_data):
1943         Update.
1944         (reset_locator): Remove.
1945         (show_source_or_disasm_and_command): Update.
1946
1947 2019-07-17  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-source.c (tui_source_window_base::reset): Remove
1950         win_type parameter.
1951         * tui/tui-layout.c (make_command_window, make_source_window)
1952         (make_disasm_window, make_data_window)
1953         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1954         (reset_locator, show_source_or_disasm_and_command): Update.
1955         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1956         win_type parameter.
1957         (struct tui_source_window_base) <reset>: Likewise.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-layout.c (show_source_disasm_command): Use
1962         reset_locator.
1963         (reset_locator): New function.
1964         (init_and_make_win): Remove.
1965         (show_source_or_disasm_and_command): Use reset_locator.
1966
1967 2019-07-17  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1970         condition.
1971         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1972         Remove condition.
1973         * tui/tui-source.c (tui_source_window_base::reset): New method.
1974         * tui/tui-layout.c (make_command_window): Don't call
1975         init_and_make_win.
1976         (make_source_window, make_disasm_window): Don't call
1977         make_source_or_disasm_window.
1978         (make_data_window): Don't call init_and_make_win.  Change calling
1979         convention.
1980         (show_source_disasm_command, show_data): Simplify.
1981         (make_source_or_disasm_window): Remove.
1982         (show_source_or_disasm_and_command): Simplify.
1983         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1984         (struct tui_source_window_base) <reset>: Likewise.
1985         <execution_info>: Remove initializer.
1986         * tui/tui-data.c (tui_source_window_base): Initialize
1987         execution_info.
1988
1989 2019-07-17  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1992         variable.
1993
1994 2019-07-17  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui.c (tui_rl_other_window): Update.
1997         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1998         superclass method first.  Always iterate over regs_content.
1999         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2000         method.
2001         * tui/tui-win.c (tui_set_focus_command): Update.
2002
2003 2019-07-17  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-win.c (tui_set_focus_command): Rename from
2006         tui_set_focus.  Call tui_enable.
2007         (tui_set_focus_command): Remove.
2008
2009 2019-07-17  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2012         refresh_window.
2013         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2014         touchwin.
2015         (tui_data_window::refresh_window): Call refresh_window on data
2016         items.  Always call superclass refresh_window.
2017         (tui_win_info::refresh): Remove.
2018         (tui_source_window_base::refresh_window): Update.
2019         (tui_refresh_all): Update.
2020         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2021         refresh_window.
2022         (show_source_or_disasm_and_command): Likewise.
2023         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2024         (struct tui_source_window_base) <refresh>: Likewise.
2025
2026 2019-07-17  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-winsource.c (tui_clear_source_content)
2029         (tui_show_source_content): Update.
2030         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2031         whether content is empty.
2032         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2033         Remove.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2038         window's contents.
2039         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2040         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2041
2042 2019-07-17  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2045         (struct tui_data_item_window): Update.
2046
2047 2019-07-17  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2050         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2051         defines.
2052
2053 2019-07-17  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-winsource.h (tui_erase_source_content)
2056         (tui_clear_source_content): Remove "display_prompt" parameter.
2057         * tui/tui-winsource.c (tui_update_source_window_as_is)
2058         (tui_update_source_windows_with_addr): Update.
2059         (tui_clear_source_content): Remove "display_prompt" parameter.
2060         (tui_erase_source_content): Likewise.  Simplify.
2061         (tui_show_source_content): Update.
2062         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2063         * tui/tui-stack.c (tui_show_frame_info): Update.
2064         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2065         Remove defines.
2066
2067 2019-07-17  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2070         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2071         parameter.
2072         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2073         parameter.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.c (tui_clear_source_content)
2078         (tui_show_source_content, tui_show_exec_info_content)
2079         (tui_clear_exec_info_content): Update.
2080         * tui/tui-stack.c (tui_show_locator_content): Update.
2081         (tui_show_frame_info): Update.
2082         * tui/tui-source.h (tui_source_window): Don't declare.
2083         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2084         from tui_source_is_displayed.
2085         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2086         Remove field.
2087         (struct tui_source_window_base) <content_in_use>: New field.  Now
2088         bool.
2089         (struct tui_source_window) <showing_source_p>: New method.
2090         (TUI_SRC_WIN): Change cast.
2091         * tui/tui-data.c (tui_initialize_static_data): Update.
2092
2093 2019-07-17  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2096         location_matches_p.
2097         * tui/tui-source.c (tui_source_window::location_matches_p): New
2098         method.
2099         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2100         method.
2101         * tui/tui-data.h (struct tui_source_window_base)
2102         <location_matches_p>: New method.
2103         (struct tui_source_window, struct tui_disasm_window)
2104         <location_matches_p>: Likewise.
2105
2106 2019-07-17  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-win.c (tui_set_win_height_command): Rename from
2109         tui_set_win_height.
2110         (tui_set_win_height_command): Remove.
2111
2112 2019-07-17  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-source.c (tui_source_window): New constructor.  Add
2115         observer.
2116         (~tui_source_window): New destructor.
2117         (tui_source_window::style_changed): New method.
2118         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2119         (tui_attach_detach_observers): Update.
2120         * tui/tui-data.h (struct tui_source_window): Make constructor not
2121         inline.  Add destructor.
2122         (struct tui_source_window) <style_changed>: New method.
2123         <m_observable>: New member.
2124
2125 2019-07-17  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2128         * tui/tui-win.c (tui_resize_all): Fix typo.
2129
2130 2019-07-17  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2133         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2134         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2135         * tui/tui-win.c (window_name_completer): Use foreach.
2136         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2137         (update_tab_width): Likewise.
2138         * tui/tui-layout.c (show_layout): Update.
2139         * tui/tui-data.h (class tui_window_iterator): New.
2140         (struct all_tui_windows): New.
2141         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2142
2143 2019-07-17  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2146         parameter.  Don't reference globals.
2147         (tui_reg_command): Update.
2148
2149 2019-07-17  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-regs.c (tui_show_registers): Simplify.
2152
2153 2019-07-17  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-regs.c (tui_show_registers): Update.
2156         (tui_show_register_group): Add win_info parameter.
2157
2158 2019-07-17  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2161         Rename from tui_display_reg_element_at_line.
2162         (tui_data_window::display_registers_from_line): Update.
2163         * tui/tui-data.h (struct tui_data_window)
2164         <display_reg_element_at_line>: New method.
2165
2166 2019-07-17  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-regs.h (tui_display_registers_from)
2169         (tui_display_registers_from_line): Don't declare.
2170         * tui/tui-windata.c (tui_data_window::display_all_data)
2171         (tui_data_window::refresh_all)
2172         (tui_data_window::do_scroll_vertical): Update.
2173         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2174         from tui_display_registers_from.
2175         (tui_display_reg_element_at_line): Update.
2176         (tui_data_window::display_registers_from_line): Rename from
2177         tui_display_registers_from_line.
2178         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2179         display_registers_from_line>: New methods.
2180
2181 2019-07-17  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2184         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2185         from tui_erase_data_content.
2186         (tui_data_window::display_all_data)
2187         (tui_data_window::refresh_all)
2188         (tui_data_window::do_scroll_vertical): Update.
2189         * tui/tui-regs.c (tui_show_registers): Update.
2190         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2191         New method.
2192
2193 2019-07-17  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2196         declare.
2197         * tui/tui-windata.c
2198         (tui_data_window::delete_data_content_windows): Rename from
2199         tui_delete_data_content_windows.
2200         (tui_data_window::display_all_data)
2201         (tui_data_window::do_scroll_vertical): Update.
2202         * tui/tui-data.h (struct tui_data_window)
2203         <delete_data_content_windows>: New method.
2204
2205 2019-07-17  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2208         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2209
2210 2019-07-17  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2213         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2214         from tui_display_all_data.
2215         * tui/tui-win.c
2216         (tui_data_window::do_make_visible_with_new_height): Update.
2217         * tui/tui-regs.c (tui_show_registers): Update.
2218         * tui/tui-layout.c (tui_set_layout): Update.
2219         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2220         method.
2221
2222 2019-07-17  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2225         * tui/tui-windata.c (tui_display_data_from): Remove.
2226         (tui_data_window::refresh_all): Update.
2227
2228 2019-07-17  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2231         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2232         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2233         tui_display_registers_from_line.
2234         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2235         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2236         "force_display" parameter.
2237
2238 2019-07-17  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2241         declare.
2242         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2243         Rename from tui_first_reg_element_no_inline.
2244         (tui_display_reg_element_at_line)
2245         (tui_display_registers_from_line): Update.
2246         * tui/tui-data.h (struct tui_data_window)
2247         <first_reg_element_no_inline>: New method.
2248
2249 2019-07-17  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-windata.c (tui_display_data_from)
2252         (tui_data_window::do_scroll_vertical): Update.
2253         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2254         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2255         Rename from tui_line_from_reg_element_no.
2256         (tui_display_registers_from_line): Update.
2257         * tui/tui-data.h (struct tui_data_window)
2258         <line_from_reg_element_no>: New method.
2259
2260 2019-07-17  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2263         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2264         tui_last_regs_line_no.
2265         (tui_display_reg_element_at_line)
2266         (tui_display_registers_from_line): Update.
2267         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2268         method.
2269
2270 2019-07-17  Tom Tromey  <tom@tromey.com>
2271
2272         PR tui/24722:
2273         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2274         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2275         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2276         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2277         (tui_update_breakpoint_info): Likewise.
2278         * tui/tui-hooks.c (tui_event_create_breakpoint)
2279         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2280         Update.
2281
2282 2019-07-17  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2285
2286 2019-07-17  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.c (tui_update_source_window_as_is)
2289         (tui_update_source_windows_with_addr): Update.
2290         * tui/tui-source.h (tui_set_source_content)
2291         (tui_show_symtab_source): Add "win_info" parameter.
2292         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2293         parameter.
2294         (tui_show_symtab_source): Likewise.
2295
2296 2019-07-17  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-wingeneral.c
2299         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2300
2301 2019-07-17  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2304         (struct tui_cmd_window) <can_scroll>: New method.
2305         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2306         method.
2307
2308 2019-07-17  Tom Tromey  <tromey@adacore.com>
2309
2310         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2311         do_field_signed>: Rename.  Change type of "value".
2312         * ui-out.c (ui_out::field_signed): Rename from field_int.
2313         Change type of "value".
2314         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2315         type of "value".
2316         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2317         do_field_int.  Change type of "value".
2318         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2319         do_field_int.  Change type of "value".
2320         * tracepoint.c (trace_status_mi, tfind_1)
2321         (print_one_static_tracepoint_marker): Update.
2322         * thread.c (print_thread_info_1, print_selected_thread_frame):
2323         Update.
2324         * stack.c (print_frame, print_frame_info): Update.
2325         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2326         Update.
2327         * source.c (print_source_lines_base): Update.
2328         * skip.c (info_skip_command): Update.
2329         * record-btrace.c (btrace_ui_out_decode_error)
2330         (btrace_call_history_src_line): Update.
2331         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2332         Update.
2333         * progspace.c (print_program_space): Update.
2334         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2335         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2336         do_field_int.  Change type of "value".
2337         * mi/mi-out.c (mi_ui_out::do_table_begin)
2338         (mi_ui_out::do_table_header): Update.
2339         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2340         type of "value".
2341         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2342         (mi_cmd_data_list_changed_registers, output_register)
2343         (mi_cmd_data_read_memory, mi_load_progress)
2344         (mi_cmd_trace_frame_collected): Update.
2345         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2346         Update.
2347         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2348         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2349         (mi_cmd_var_list_children, varobj_update_one): Update.
2350         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2351         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2352         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2353         * inferior.c (print_inferior): Update.
2354         * gdb_bfd.c (print_one_bfd): Update.
2355         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2356         Update.
2357         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2358         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2359         do_field_int.  Change type of "value".
2360         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2361         do_field_int.  Change type of "value".
2362         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2363         (print_one_breakpoint_location, print_it_catch_fork)
2364         (print_one_catch_fork, print_it_catch_vfork)
2365         (print_one_catch_vfork, print_it_catch_solib)
2366         (print_it_catch_exec, print_it_ranged_breakpoint)
2367         (print_mention_watchpoint, print_mention_masked_watchpoint)
2368         (bkpt_print_it, update_static_tracepoint): Update.
2369         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2370         * break-catch-syscall.c (print_it_catch_syscall): Update.
2371         * ada-tasks.c (print_ada_task_info): Update.
2372         * ada-lang.c (print_it_exception, print_mention_exception):
2373         Update.
2374
2375 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2376
2377         PR breakpoints/24541
2378         * gdbarch.c: Regenerate.
2379         * gdbarch.h: Regenerate.
2380         * gdbarch.sh: Adjust return type and parameter types for
2381         'stap_adjust_register'.
2382         (i386_stap_adjust_register): Adjust signature and return new
2383         register name.
2384         * stap-probe.c (stap_parse_register_operand): Adjust use of
2385         'gdbarch_stap_adjust_register'.
2386
2387 2019-07-17  Tom Tromey  <tromey@adacore.com>
2388
2389         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2390         declare VEC.
2391         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2392         std::vector.
2393         (struct s390_process_info): Add initializers.
2394         (s390_add_process): Use new.
2395         (s390_linux_nat_target::low_forget_process): Use delete.
2396         (s390_linux_nat_target::low_new_fork)
2397         (s390_linux_nat_target::stopped_by_watchpoint)
2398         (s390_linux_nat_target::low_prepare_to_resume)
2399         (s390_linux_nat_target::insert_watchpoint)
2400         (s390_linux_nat_target::insert_hw_breakpoint)
2401         (s390_linux_nat_target::remove_watchpoint)
2402         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2403
2404 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2405
2406         * aarch64-fbsd-nat.c: Include regcache.h.
2407         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2408         argument.
2409         (aarch64_fbsd_nat_target::fetch_registers)
2410         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2411         variable.
2412         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2413
2414 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2415
2416         * fbsd-nat.c: Include gdbarch.h.
2417
2418 2019-07-15  Tom Tromey  <tromey@adacore.com>
2419
2420         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2421
2422 2019-07-15  Tom Tromey  <tromey@adacore.com>
2423
2424         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2425         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2426         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2427         * cli-out.c (cli_ui_out::do_field_int): New method.
2428         * ui-out.c (ui_out::field_unsigned): New method.
2429         * symfile.c (generic_load): Use field_unsigned.
2430         (print_transfer_performance): Likewise.
2431         * record-btrace.c (ui_out_field_uint): Remove.
2432         (btrace_call_history_insn_range, btrace_call_history): Use
2433         field_unsigned.
2434         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2435         field_unsigned.
2436         * ui-out.h (class ui_out) <field_unsigned>: New method.
2437         <do_field_unsigned>: Likewise.
2438
2439 2019-07-15  Tom Tromey  <tromey@adacore.com>
2440
2441         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2442         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2443         * target.c (flash_erase_command): Use field_string.
2444         * infrun.c (print_signal_received_reason): Use field_string.
2445         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2446         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2447         field_string.
2448         * ada-tasks.c (print_ada_task_info): Use field_string.
2449
2450 2019-07-15  Tom Tromey  <tromey@adacore.com>
2451
2452         * target.c (flash_erase_command): Use field_core_addr.
2453         * symfile.c (generic_load): Use field_core_addr.
2454         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2455         Use field_core_addr.
2456         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2457         field_core_addr.
2458
2459 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2462         value if its desired type is smaller than a CORE_ADDR and signed.
2463
2464 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2465
2466         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2467         of changes to field names, and use new is_reference field to
2468         decide if a property is a reference or not.
2469         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2470         field.
2471         (struct dwarf2_property_baton): Update header comment, rename
2472         'referenced_type' to 'property_type' and update comments.
2473         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2474         default property type, store in property baton, update to take
2475         accound of renamed field.
2476         (read_func_scope): Update call to attr_to_dynamic_prop.
2477         (read_array_type): Likewise.
2478         (dwarf2_per_cu_addr_sized_int_type): New function.
2479         (read_subrange_index_type): Move type finding code to
2480         dwarf2_per_cu_addr_sized_int_type.
2481         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2482         (dwarf2_per_cu_addr_type): New function.
2483         (set_die_type): Update calls to attr_to_dynamic_prop.
2484
2485 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2486
2487         * dwarf2read.c (read_subrange_index_type): New function.
2488         (read_subrange_type): Move code into new function and call it.
2489         * gdbtypes.c (create_range_type): Add some asserts.
2490
2491 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2492
2493         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2494         update return statements.
2495         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2496         declaration, and update comment to match.
2497         * gdbtypes.c (resolve_dynamic_array): Update call to
2498         dwarf2_evaluate_property to match new return type.
2499
2500 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * valarith.c (value_subscripted_rvalue): Change lowerbound
2503         parameter type from int to LONGEST.
2504         * value.h (value_subscripted_rvalue): Likewise in declaration.
2505
2506 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * cli/cli-utils.c (info_print_command_completer): New function.
2509         * cli/cli-utils.h: Add 'completer.h' include, and forward
2510         declaration for 'struct cmd_list_element'.
2511         (info_print_command_completer): Declare.
2512         * stack.c (_initialize_stack): Add completer for 'info locals' and
2513         'info args'.
2514         * symtab.c (_initialize_symtab): Add completer for 'info
2515         variables' and 'info functions'.
2516         * NEWS: Mention completion for additional info commands.
2517
2518 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * cli/cli-utils.c (extract_info_print_args): Delete.
2521         (extract_arg_maybe_quoted): Delete.
2522         (info_print_options_defs): New variable.
2523         (make_info_print_options_def_group): New function.
2524         (extract_info_print_options): Define new function.
2525         * cli/cli-utils.h (extract_info_print_args): Delete.
2526         (struct info_print_options): New structure.
2527         (extract_info_print_options): Declare new function.
2528         * stack.c (info_locals_command): Update to use new
2529         extract_info_print_options, also add a header comment.
2530         (info_args_command): Likewise.
2531         * symtab.c (info_variables_command): Likewise.
2532         (info_functions_command): Likewise.
2533
2534 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2537         to extract string arguments.
2538         * common/common-utils.c (extract_string_maybe_quoted): New function.
2539         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2540
2541 2019-07-11  Tom Tromey  <tromey@adacore.com>
2542
2543         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2544         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2545         * top.h (gdbinit): Don't declare.
2546         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2547         into...
2548         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2549         * top.c (gdb_init): Don't call init_cli_cmds.
2550         (gdbinit): Remove.
2551         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2552
2553 2019-07-11  Tom Tromey  <tromey@adacore.com>
2554
2555         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2556         after it has been moved.
2557
2558 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2559
2560         * valops.c (value_must_coerce_to_target): Change return type to
2561         bool.
2562         * value.h (value_must_coerce_to_target): Likewise.
2563
2564 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2565
2566         * breakpoint.c (is_hardware_watchpoint): Remove
2567         forward-declaration.
2568         (is_masked_watchpoint): Change return type to bool.
2569         (is_tracepoint): Likewise.
2570         (is_breakpoint): Likewise.
2571         (is_hardware_watchpoint): Likewise.
2572         (is_watchpoint): Likewise.
2573         (is_no_memory_software_watchpoint): Likewise.
2574         (is_catchpoint): Likewise.
2575         (breakpoint_1): Make FILTER parameter's return type bool.
2576         is_masked_watchpoint): Change return type to bool.
2577         (save_breakpoints): Make FILTER parameter's return type bool.
2578         * breakpoint.h (is_breakpoint): Change return type to bool.
2579         (is_watchpoint): Likewise.
2580         (is_catchpoint): Likewise.
2581         (is_tracepoint): Likewise.
2582
2583 2019-07-10  Tom Tromey  <tom@tromey.com>
2584
2585         * defs.h: Don't include gdbarch.h.
2586         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2587         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2588         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2589         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2590         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2591         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2592         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2593         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2594         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2595         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2596         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2597         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2598         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2599         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2600         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2601         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2602         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2603         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2604         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2605         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2606         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2607         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2608         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2609         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2610         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2611         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2612         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2613
2614 2019-07-10  Tom Tromey  <tromey@adacore.com>
2615
2616         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2617         * breakpoint.c (init_ada_exception_breakpoint): Register as
2618         bp_catchpoint.
2619         (print_one_breakpoint_location, print_one_breakpoint): Use
2620         is_ada_exception_catchpoint.
2621         * ada-lang.c (class ada_catchpoint_location): Pass
2622         bp_loc_software_breakpoint to bp_location constructor.
2623         (is_ada_exception_catchpoint): New function.
2624
2625 2019-07-10  Tom Tromey  <tromey@adacore.com>
2626
2627         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2628         VEC.
2629         (struct arm_exidx_entry): New method operator<.
2630         (struct arm_exidx_data) <section_maps>: Change type.
2631         (arm_exidx_data_free): Remove.
2632         (arm_exidx_data_key): Change type.  Move lower.
2633         (arm_exidx_new_objfile): Update.
2634         (arm_compare_exidx_entries): Remove.
2635         (arm_find_exidx_entry, _initialize_arm_tdep)
2636
2637 2019-07-10  Tom Tromey  <tromey@adacore.com>
2638
2639         * solib-spu.c (ocl_program_data_key): Change type.
2640         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2641         Update.
2642
2643 2019-07-10  Tom Tromey  <tromey@adacore.com>
2644
2645         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2646         (struct solib_aix_inferior_data) <library_list>: Change type.
2647         (solib_aix_inferior_data_handle): Change type.
2648         (get_solib_aix_inferior_data): Update.
2649         (solib_aix_free_library_list): Remove.
2650         (library_list_start_library): Update.
2651         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2652         return type.
2653         (solib_aix_get_library_list)
2654         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2655         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2656
2657 2019-07-10  Tom Tromey  <tromey@adacore.com>
2658
2659         * solib-dsbt.c (struct dsbt_info): Add initializers.
2660         (solib_dsbt_pspace_data): Change type.
2661         (dsbt_pspace_data_cleanup): Remove.
2662         (get_dsbt_info, _initialize_dsbt_solib): Update.
2663
2664 2019-07-10  Tom Tromey  <tromey@adacore.com>
2665
2666         * spu-tdep.c (spu_overlay_data): Change type.
2667         (spu_get_overlay_table, spu_overlay_new_objfile)
2668         (_initialize_spu_tdep): Update.
2669
2670 2019-07-10  Tom Tromey  <tromey@adacore.com>
2671
2672         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2673         destructor.
2674         (dbx_objfile_data_key): Change type and declare later.
2675         (DBX_SYMFILE_INFO): Rewrite.
2676         * dbxread.c (dbx_objfile_data_key): Change type.
2677         (dbx_symfile_init): Update.
2678         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2679         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2680         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2681
2682 2019-07-10  Tom Tromey  <tromey@adacore.com>
2683
2684         * jit.c (jit_program_space_key): Change type.  Move lower.
2685         (get_jit_program_space_data): Update.
2686         (jit_program_space_data_cleanup): Remove.
2687         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2688         Update.
2689         (struct jit_program_space_data): Add initializers.
2690
2691 2019-07-10  Tom Tromey  <tromey@adacore.com>
2692
2693         * solib-darwin.c (struct darwin_info): Add initializers.
2694         (solib_darwin_pspace_data): Change type.
2695         (darwin_pspace_data_cleanup): Remove.
2696         (get_darwin_info, _initialize_darwin_solib): Update.
2697
2698 2019-07-10  Tom Tromey  <tromey@adacore.com>
2699
2700         * remote-sim.c (struct sim_inferior_data): Add initializers,
2701         constructor, and destructor.
2702         (sim_inferior_data_key): Change type.  Move lower.
2703         (check_for_duplicate_sim_descriptor): Update.
2704         (get_sim_inferior_data): Use new.  Update.
2705         (~sim_inferior_data_cleanup): Rename from
2706         sim_inferior_data_cleanup.  Simplify.
2707         (gdbsim_close_inferior, simulator_command)
2708         (sim_command_completer, _initialize_remote_sim): Update.
2709         (next_pid, INITIAL_PID): Move earlier.
2710
2711 2019-07-10  Tom Tromey  <tromey@adacore.com>
2712
2713         * python/python-internal.h (create_thread_object): Return
2714         gdbpy_ref.
2715         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2716         * python/py-inferior.c (struct threadlist_entry): Add
2717         constructor.
2718         <thread_obj>: Now a gdbpy_ref.
2719         (thread_to_thread_object): Update.
2720         (add_thread_object): Use new.
2721         (delete_thread_object): Use delete.
2722         (infpy_threads): Update.
2723         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2724         GIL.
2725
2726 2019-07-10  Tom Tromey  <tromey@adacore.com>
2727
2728         * valops.c (value_cast): Specialize error message for Ada.
2729
2730 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2731
2732         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2733
2734 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2735
2736         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2737         bpstat_should_step): Return bool, adjust comments.
2738         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2739         bpstat_should_step): Likewise.
2740
2741 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2742
2743         * features/Makefile: Use feature target descriptions for Arm.
2744         * features/arm/arm-core.c: Generate new file.
2745         * features/arm/arm-fpa.c: Likewise.
2746         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2747         * features/arm/arm-m-profile.c: Likewise.
2748         * features/arm/arm-vfpv2.c: Likewise.
2749         * features/arm/arm-vfpv3.c: Likewise.
2750         * features/arm/xscale-iwmmxt.c: Likewise.
2751         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2752
2753 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2754
2755         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2756         ptrace earlier.
2757
2758 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2759
2760         * features/aarch64-pauth.c: Regenerate.
2761
2762 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2763
2764         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2765         bool.
2766         (bpstat_what): Use false instead of 0.
2767
2768 2019-07-09  Pedro Alves  <palves@redhat.com>
2769
2770         * break-catch-throw.c (is_exception_catchpoint): New.
2771         * breakpoint.c (print_one_breakpoint_location): New parameter
2772         'raw_loc'.  Handle it.  Use
2773         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2774         looking at the breakpoint's type.
2775         (print_one_breakpoint): If handling "maint info breakpoints", also
2776         print locations of exception catchpoints.
2777         * breakpoint.h (is_exception_catchpoint): Declare.
2778
2779 2019-07-09  Pedro Alves  <palves@redhat.com>
2780
2781         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2782         "addr" field.
2783         (allocate_location_exception_catchpoint): New.
2784         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2785         (initialize_throw_catchpoint_ops): Install
2786         allocate_location_exception_catchpoint as allocate_location
2787         method.
2788         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2789         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2790         bp_loc_other.
2791         (breakpoint_address_is_meaningful): Delete.
2792         (bl_address_is_meaningful): New.
2793         (breakpoint_locations_match): Adjust comment.
2794         (bp_location_from_bp_type): New, factored out of...
2795         (bp_location::bp_location(breakpoint *)): ... this.
2796         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2797         factored out of...
2798         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2799         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2800         breakpoint_address_is_meaningful.
2801         (bp_locations_compare): Adjust comment.
2802         (update_global_location_list): Use bl_address_is_meaningful
2803         instead of breakpoint_address_is_meaningful.
2804         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2805         explicit.
2806         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2807         * python/py-breakpoint.c (bppy_get_location): No longer check
2808         whether location is null.
2809
2810 2019-07-09  Pedro Alves  <palves@redhat.com>
2811
2812         PR c++/15468
2813         * breakpoint.c (print_one_breakpoint_location): Remove
2814         single-location assert.
2815
2816 2019-07-09  Tom Tromey  <tom@tromey.com>
2817
2818         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2819         * configure: Rebuild.
2820         * configure.ac: Change common to gdbsupport.
2821         * gdbsupport: Rename from common.
2822         * acinclude.m4: Change common to gdbsupport.
2823         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2824         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2825         gdbsupport.
2826         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2827         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2828         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2829         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2830         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2831         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2832         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2833         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2834         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2835         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2836         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2837         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2838         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2839         coff-pe-read.c, command.h, compile/compile-c-support.c,
2840         compile/compile-c.h, compile/compile-cplus-symbols.c,
2841         compile/compile-cplus-types.c, compile/compile-cplus.h,
2842         compile/compile-loc2c.c, compile/compile.c, completer.c,
2843         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2844         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2845         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2846         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2847         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2848         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2849         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2850         features/aarch64-core.c, features/aarch64-fpu.c,
2851         features/aarch64-pauth.c, features/aarch64-sve.c,
2852         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2853         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2854         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2855         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2856         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2857         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2858         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2859         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2860         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2861         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2862         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2863         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2864         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2865         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2866         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2867         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2868         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2869         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2870         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2871         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2872         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2873         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2874         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2875         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2876         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2877         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2878         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2879         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2880         minsyms.c, mips-linux-tdep.c, namespace.h,
2881         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2882         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2883         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2884         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2885         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2886         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2887         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2888         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2889         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2890         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2891         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2892         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2893         procfs.c, producer.c, progspace.h, psymtab.h,
2894         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2895         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2896         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2897         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2898         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2899         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2900         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2901         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2902         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2903         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2904         target-memory.c, target.c, target.h, target/waitstatus.c,
2905         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2906         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2907         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2908         unittests/array-view-selftests.c,
2909         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2910         unittests/common-utils-selftests.c,
2911         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2912         unittests/format_pieces-selftests.c,
2913         unittests/function-view-selftests.c,
2914         unittests/lookup_name_info-selftests.c,
2915         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2916         unittests/mkdir-recursive-selftests.c,
2917         unittests/observable-selftests.c,
2918         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2919         unittests/parse-connection-spec-selftests.c,
2920         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2921         unittests/scoped_fd-selftests.c,
2922         unittests/scoped_mmap-selftests.c,
2923         unittests/scoped_restore-selftests.c,
2924         unittests/string_view-selftests.c, unittests/style-selftests.c,
2925         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2926         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2927         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2928         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2929         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2930         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2931
2932 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2933
2934         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2935         bool value.
2936         (decode_digits_ordinary): Set explicit_line field in sal.
2937         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2938         symtab_and_line that was set on an explicit line number in
2939         assembler code.  Do always update the recorded symtab and line if
2940         we do skip the prologue.
2941
2942 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2943
2944         * breakpoint.c (set_breakpoint_location_function): Remove
2945         explicit_loc parameter.
2946         (momentary_breakpoint_from_master): Update call to
2947         set_breakpoint_location_function.
2948         (add_location_to_breakpoint): Likewise.
2949
2950 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2953         required features based on default bfd type when no specific bfd
2954         is present.
2955
2956 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2957
2958         * NEWS: Mention that GDB printf and eval commands can now print
2959         C-style and Ada-style convenience var strings without
2960         calling the inferior.
2961         * printcmd.c (printf_c_string): Locally print GDB internal var
2962         instead of transiting via the inferior.
2963         (printf_wide_c_string): Likewise.
2964
2965 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2966
2967         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2968
2969 2019-07-04  Tom Tromey  <tom@tromey.com>
2970
2971         PR tui/24724:
2972         * tui/tui-winsource.c (tui_clear_source_content): Update.
2973         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2974         (tui_update_breakpoint_info): Update.
2975         (tui_set_exec_info_content): Update.
2976         * tui/tui-source.c (tui_set_source_content_nil): Update.
2977         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2978         has_break.
2979         * tui/tui-data.h (enum tui_bp_flag): New.
2980         (tui_bp_flags): New enum flags type.
2981         (struct tui_source_element) <break_mode>: Change type.  Rename
2982         from has_break.
2983         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2984         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2985         constants.
2986         * tui/tui-winsource.h: Fix comment.
2987
2988 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2989
2990         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2991         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2992         (store_fpregs_to_thread)
2993         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2994         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2995         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2996         (IWMMXT_REGS_SIZE): Add define.
2997         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2998         (fetch_vfp_regs, store_vfp_regs)
2999         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3000         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3001
3002 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3003
3004         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3005         defines.
3006         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3007         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3008         (ARM_INT_REGISTER_SIZE): ...to this.
3009         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3010         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3011         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3012         (arm_linux_collect_gregset, supply_nwfpe_register)
3013         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3014         defines.
3015         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3016         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3017         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3018         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3019         (arm_return_in_memory, arm_store_return_value)
3020         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3021         (arm_record_ld_st_multiple): Likewise.
3022         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3023         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3024
3025 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3026
3027         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3028         AARCH64_DISPLACED_MODIFIED_INSNS.
3029         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3030         (aarch64_displaced_step_copy_insn): Likewise.
3031         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3032         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3033         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3034         ARM_DISPLACED_MODIFIED_INSNS.
3035         * arm-tdep.c (arm_gdbarch_init): Likewise.
3036         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3037         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3038         (struct arm_displaced_step_closure): Use
3039         ARM_DISPLACED_MODIFIED_INSNS.
3040
3041 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3042
3043         * features/Makefile: Remove unused xml files.
3044         * features/aarch64.xml: Remove.
3045         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3046         * features/i386/amd64-avx-avx512.xml: Remove.
3047         * features/i386/amd64-avx-linux.xml: Remove.
3048         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3049         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3050         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3051         * features/i386/amd64-avx-mpx.xml: Remove.
3052         * features/i386/amd64-avx.xml: Remove.
3053         * features/i386/amd64-linux.xml: Remove.
3054         * features/i386/amd64-mpx-linux.xml: Remove.
3055         * features/i386/amd64-mpx.xml: Remove.
3056         * features/i386/amd64.xml: Remove.
3057         * features/i386/i386-avx-avx512-linux.xml: Remove.
3058         * features/i386/i386-avx-avx512.xml: Remove.
3059         * features/i386/i386-avx-linux.xml: Remove.
3060         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3061         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3062         * features/i386/i386-avx-mpx-linux.xml: Remove.
3063         * features/i386/i386-avx-mpx.xml: Remove.
3064         * features/i386/i386-avx.xml: Remove.
3065         * features/i386/i386-linux.xml: Remove.
3066         * features/i386/i386-mmx-linux.xml: Remove.
3067         * features/i386/i386-mmx.xml: Remove.
3068         * features/i386/i386-mpx-linux.xml: Remove.
3069         * features/i386/i386-mpx.xml: Remove.
3070         * features/i386/i386.xml: Remove.
3071         * features/i386/x32-avx-avx512-linux.xml: Remove.
3072         * features/i386/x32-avx-linux.xml: Remove.
3073         * features/i386/x32-linux.xml: Remove.
3074
3075 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3076
3077         * regformats/aarch64.dat: Remove.
3078         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3079         * regformats/i386/amd64-avx-linux.dat: Remove.
3080         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3081         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3082         * regformats/i386/amd64-linux.dat: Remove.
3083         * regformats/i386/amd64-mpx-linux.dat: Remove.
3084         * regformats/i386/amd64.dat: Remove.
3085         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3086         * regformats/i386/i386-avx-linux.dat: Remove.
3087         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3088         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3089         * regformats/i386/i386-linux.dat: Remove.
3090         * regformats/i386/i386-mmx-linux.dat: Remove.
3091         * regformats/i386/i386-mpx-linux.dat: Remove.
3092         * regformats/i386/i386.dat: Remove.
3093         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3094         * regformats/i386/x32-avx-linux.dat: Remove.
3095         * regformats/i386/x32-linux.dat: Remove.
3096
3097 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3098
3099         * aarch64-tdep.c: Remove xml self tests.
3100         * amd64-linux-tdep.c: Likewise.
3101         * amd64-tdep.c: Likewise.
3102         * i386-linux-tdep.c: Likewise.
3103         * i386-tdep.c: Likewise.
3104
3105 2019-07-03  Pedro Alves  <palves@redhat.com>
3106
3107         PR cli/24732
3108         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3109         (pipe_cmd_option_defs): New.
3110         (make_pipe_cmd_options_def_group): New.
3111         (pipe_command): Use gdb::option::process_options.
3112         (pipe_command_completer): New function.
3113         (_initialize_cli_cmds): Install completer for "pipe" command.
3114
3115 2019-07-03  Pedro Alves  <palves@redhat.com>
3116
3117         * cli/cli-option.c (union option_value) <string>: New field.
3118         (struct option_def_and_value): Add ctor, move ctor, dtor and
3119         use DISABLE_COPY_AND_ASSIGN.
3120         (option_def_and_value::clear_value): New.
3121         (parse_option, save_option_value_in_ctx, get_val_type_str)
3122         (add_setshow_cmds_for_options): Handle var_string.
3123         * cli-option.h (union option_def::var_address) <string>: New
3124         field.
3125         (struct string_option_def): New.
3126         * maint-test-options.c (struct test_options_opts): Add default
3127         ctor and use DISABLE_COPY_AND_ASSIGN.
3128         <string_opt>: New field.
3129         (test_options_opts::~test_options_opts): New.
3130         (test_options_opts::dump): Also dump "-string".
3131         (test_options_option_defs): Install "string.
3132
3133 2019-07-03  Pedro Alves  <palves@redhat.com>
3134
3135         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3136         option_value with a null enumeration.
3137         (complete_options): Save the option values in the context.
3138         (save_option_value_in_ctx): New, factored out from ...
3139         (process_options): ... here.
3140         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3141         of the function.
3142         * maint-test-options.c (test_options_opts::dump): New, factored
3143         out from ...
3144         (maintenance_test_options_command_mode): ... here.
3145         (maintenance_test_options_command_completion_result): Delete.
3146         (maintenance_test_options_command_completion_text): Update
3147         comment.
3148         (maintenance_show_test_options_completion_result): Change
3149         prototype.  Just print
3150         maintenance_test_options_command_completion_text.
3151         (save_completion_result): New.
3152         (maintenance_test_options_completer_mode): Pass options context to
3153         complete_options, and then save a dump.
3154         (_initialize_maint_test_options): Use add_cmd to install "maint
3155         show test-options-completion-result".
3156
3157 2019-07-03  Pedro Alves  <palves@redhat.com>
3158
3159         * NEWS (New commands): Mention "with" and "maint with".
3160         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3161         (with_command, with_command_completer): New.
3162         (pipe_command): Adjust to new repeat_previous
3163         interface.
3164         (_initialize_cli_cmds): Install the "with" command and its "w"
3165         alias.
3166         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3167         declarations.
3168         * cli/cli-setshow.c (parse_cli_var_uinteger)
3169         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3170         argument strings for all var_types.
3171         (get_setshow_command_value_string): New, factored out from ...
3172         (do_show_command): ... this.
3173         * cli/cli-setshow.h: Include <string>.
3174         (get_setshow_command_value_string): Declare.
3175         * command.h (repeat_previous): Now returns const char *.  Adjust
3176         comment.
3177         * maint.c: Include "cli/cli-cmds.h".
3178         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3179         (_initialize_maint_cmds): Register the "maintenance with" command.
3180         * top.c (repeat_previous): Move bits from pipe_command here:
3181         Return the saved command line, if any; error out if there's no
3182         command to relaunch.
3183
3184 2019-07-03  Pedro Alves  <palves@redhat.com>
3185
3186         * NEWS (New commands): Mention "maint set/show test-settings"
3187         instead of "maint test-settings".
3188         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3189         (maintenance_test_settings_set_list): Rename to ...
3190         (maintenance_set_test_settings_list): ... this.
3191         (maintenance_test_settings_show_list): Rename to  ...
3192         (maintenance_show_test_settings_list): ... this.
3193         (maintenance_test_settings_cmd): Delete.
3194         (maintenance_test_settings_set_cmd): ...
3195         (maintenance_set_test_settings_cmd): ... this.
3196         (maintenance_test_settings_show_cmd): ...
3197         (maintenance_show_test_settings_cmd): ... this.
3198         (maintenance_test_settings_show_value_cmd):
3199         (maintenance_show_test_settings_value_cmd): ... this.
3200         (_initialize_maint_test_settings): No longer install the "maint
3201         test-settings" prefix command.  Rename "maint test-settings set"
3202         to "maint set test-settings", and "maint test-settings show" to
3203         "maint show test-settings".  Adjust all subcommands.
3204
3205 2019-07-03  Pedro Alves  <palves@redhat.com>
3206
3207         * maint-test-settings.c: Fix file's intro comment.  Replace all
3208         references to "test-options" with references to "test-settings",
3209         in comments.
3210
3211 2019-07-03  Pedro Alves  <palves@redhat.com>
3212
3213         * maint-test-settings.c (maintenance_test_settings_xxx)
3214         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3215         New.
3216         (maintenance_test_settings_enums): Use them.
3217         (maintenance_test_settings_enum): Default to
3218         maintenance_test_settings_xxx.
3219         (_initialize_maint_test_settings): Initialize
3220         MAINTENANCE_TEST_SETTINGS_FILENAME.
3221
3222 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3223
3224         * breakpoint.h (remove_breakpoints_inf): Change return type to
3225         void, move function documentation here.
3226         * breakpoint.c (remove_breakpoints_inf): Change return type to
3227         void, move function documentation to header.
3228
3229 2019-07-02  Pedro Alves  <palves@redhat.com>
3230
3231         * NEWS (Completion improvements): Mention "info threads".
3232         * thread.c (struct info_threads_opts, info_threads_option_defs)
3233         (make_info_threads_options_def_group): New.
3234         (info_threads_command): Use gdb::option::process_options.
3235         (info_threads_command_completer): New.
3236         (_initialize_thread): Use gdb::option::build_help to build the
3237         help text for "info threads".
3238
3239 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3240
3241         * defs.h (generic_load): Move from here...
3242         * symfile.h (generic_load): ... to here.  Rename name parameter
3243         to args.
3244         * symfile.c (generic_load): Add comment.
3245
3246 2019-07-01  Tom Tromey  <tromey@adacore.com>
3247
3248         * dwarf2read.c
3249         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3250         declaration of without_params.  Fix formatting.
3251
3252 2019-07-01  Tom Tromey  <tromey@adacore.com>
3253
3254         * ada-exp.y (find_primitive_type): Update.
3255         * ada-lang.h (ada_lookup_symbol): Update.
3256         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3257         parameter.
3258         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3259
3260 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3261
3262         PR breakpoints/24541
3263         * gdbarch.c: Regenerate.
3264         * gdbarch.h: Regenerate.
3265         * gdbarch.sh: Add 'stap_adjust_register'.
3266         * i386-tdep.c: Include '<unordered_set>'.
3267         (i386_stap_adjust_register): New function.
3268         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3269         * stap-probe.c (stap_parse_register_operand): Call
3270         'gdbarch_stap_adjust_register'.
3271
3272 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3273
3274         PR python/24742
3275         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3276         * python/python.c (do_start_initialization): Use 'xmalloc'
3277         instead of 'PyMem_Malloc'.
3278
3279 2019-06-28  Tom Tromey  <tromey@adacore.com>
3280
3281         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3282         for Ada.
3283
3284 2019-06-27  Tom Tromey  <tromey@adacore.com>
3285
3286         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3287         objfile_key.
3288         (arm_find_mapping_symbol, arm_record_special_symbol)
3289         (_initialize_arm_tdep): Update.
3290         (arm_objfile_data_free): Remove.
3291
3292 2019-06-27  Tom Tromey  <tromey@adacore.com>
3293
3294         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3295         to cp_print_static_field.
3296
3297 2019-06-26  Tom Tromey  <tromey@adacore.com>
3298
3299         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3300         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3301         declare.
3302
3303 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3304
3305         * features/aarch64-core.c (create_feature_aarch64_core):
3306         Regenerate.
3307         * features/aarch64-core.xml: Add cpsr flags.
3308
3309 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3310
3311         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3312         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3313
3314 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3315
3316         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3317         field.
3318         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3319         use.
3320         (arm_record_special_symbol): Don't insert new symbol in sorted
3321         position, push it at the end.
3322
3323 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3324
3325         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3326         (arm_mapping_symbol_s): Remove.
3327         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3328         (arm_mapping_symbol_vec): New typedef.
3329         (struct arm_per_objfile): Add constructor.
3330         <section_maps>: Change type to
3331         std::unique_ptr<arm_mapping_symbol_vec[]>.
3332         (arm_compare_mapping_symbols): Remove.
3333         (arm_find_mapping_symbol): Adjust to section_maps type change.
3334         (arm_objfile_data_free): Call delete on arm_per_objfile.
3335         (arm_record_special_symbol): Adjust to section_maps type change.
3336         Allocate arm_per_objfile with new.
3337
3338 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3339
3340         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3341         with the command prefix.
3342
3343 2019-06-25  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3346         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3351         type.
3352         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3353         protected.
3354
3355 2019-06-25  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-winsource.c
3358         (tui_source_window_base::set_is_exec_point_at): Add check against
3359         LOA_ADDRESS.
3360
3361 2019-06-25  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui-source.c (tui_set_source_content): Don't check before
3364         xfree.
3365         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3366
3367 2019-06-25  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-winsource.h (tui_update_source_window_as_is)
3370         (tui_alloc_source_buffer, tui_line_is_displayed)
3371         (tui_addr_is_displayed): Change type of win_info.
3372         * tui/tui-winsource.c (tui_update_source_window_as_is)
3373         (tui_clear_source_content, tui_show_source_line)
3374         (tui_show_source_content, tui_source_window_base::refill)
3375         (tui_source_window_base::set_is_exec_point_at)
3376         (tui_source_window_base::set_is_exec_point_at)
3377         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3378         (tui_alloc_source_buffer, tui_line_is_displayed)
3379         (tui_addr_is_displayed): Change type of win_info.  Update.
3380         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3381         (tui_source_window_base::do_make_visible_with_new_height):
3382         Update.
3383         * tui/tui-source.c (tui_set_source_content)
3384         (tui_set_source_content_nil)
3385         (tui_source_window::do_scroll_vertical): Update.
3386         * tui/tui-layout.c (show_layout): Update.
3387         * tui/tui-disasm.c (tui_set_disassem_content)
3388         (tui_disasm_window::do_scroll_vertical): Update.
3389         * tui/tui-data.h (tui_win_content): Remove.
3390         (struct tui_gen_win_info) <content, content_size>: Remove.
3391         (struct tui_source_element): Add initializers and destructor.
3392         (union tui_which_element, struct tui_win_element): Remove.
3393         (struct tui_source_window_base) <content>: New field.
3394         (struct tui_data_window): Remove destructor.
3395         (tui_alloc_content, tui_free_win_content)
3396         (tui_free_all_source_wins_content): Don't declare.
3397         * tui/tui-data.c (tui_initialize_static_data): Update.
3398         (init_content_element, tui_alloc_content): Remove.
3399         (~tui_gen_win_info): Update.
3400         (~tui_data_window, tui_free_all_source_wins_content)
3401         (tui_free_win_content, free_content, free_content_elements):
3402         Remove.
3403
3404 2019-06-25  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-winsource.h (tui_clear_source_content)
3407         (tui_erase_source_content, tui_show_source_content): Change type
3408         of win_info.
3409         * tui/tui-winsource.c (tui_clear_source_content)
3410         (tui_erase_source_content, tui_show_source_content): Change type
3411         of win_info.
3412         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3413         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3414         win_info.
3415         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3416         win_info.
3417         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-winsource.c (tui_clear_source_content)
3422         (tui_source_window_base::set_is_exec_point_at): Update.
3423         * tui/tui-source.c (tui_set_source_content_nil): Update.
3424         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3425         a bool.
3426         * tui/tui-data.c (init_content_element): Update.
3427
3428 2019-06-25  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3431         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3432         * tui/tui-layout.c (init_and_make_win): Update.
3433         * tui/tui.h (enum tui_win_type): Update.
3434         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3435         tui_win_is_auxillary.
3436         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3437         tui_win_is_auxillary.
3438
3439 2019-06-25  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3442         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3443         (tui_delete_data_content_windows, tui_display_all_data)
3444         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3445         Update.
3446         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3447         * tui/tui-regs.c (tui_last_regs_line_no)
3448         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3449         (tui_show_registers): Update.
3450         (tui_show_register_group): Return void.  Update.
3451         (tui_display_registers_from, tui_display_reg_element_at_line)
3452         (tui_display_registers_from_line, tui_check_register_values):
3453         Update.
3454         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3455         member.
3456         (struct tui_data_window) <regs_content>: Now a std::vector.
3457         <regs_content_count>: Remove.
3458         (tui_add_content_elements, tui_free_data_content): Don't declare.
3459         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3460         (init_content_element): Remove DATA_WIN case.  Add assert.
3461         (tui_add_content_elements): Remove.
3462         (tui_data_window): Update.
3463         (tui_free_data_content): Remove.
3464         (free_content_elements): Remove DATA_WIN case.
3465
3466 2019-06-25  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-data.c (tui_data_item_window): Update.
3469         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3470         * tui/tui-windata.c (tui_display_all_data)
3471         (tui_display_data_from_line): Update.
3472         (tui_check_data_values): Remove.
3473         * tui/tui-regs.c (tui_show_register_group)
3474         (tui_display_reg_element_at_line): Update.
3475         * tui/tui-hooks.c (tui_register_changed)
3476         (tui_refresh_frame_and_register_information): Call
3477         tui_check_register_values.
3478         * tui/tui-data.h (struct tui_data_window) <data_content,
3479         data_content_count, data_type>: Remove.
3480         (enum tui_data_type): Remove.
3481
3482         * tui/tui-data.c (tui_data_window::clear_detail)
3483         (~tui_data_window): Update.
3484
3485 2019-06-25  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3488         declare.
3489         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3490         Rename from tui_first_data_item_displayed.  Update.
3491         (tui_data_window::refresh_all)
3492         (tui_data_window::do_scroll_vertical): Update.
3493         * tui/tui-data.h (struct tui_data_window)
3494         <first_data_item_displayed>: Declare new method.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3499         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3500         contents...
3501         (tui_initialize_static_data): ...here.
3502
3503 2019-06-25  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3506         (tui_display_registers_from, tui_check_register_values): Update.
3507         (tui_display_register): Remove win_info parameter; update.
3508         (tui_get_register): Change type of parameters.
3509         * tui/tui-data.h (struct tui_data_element): Remove.
3510         (union tui_which_element) <data>: Remove.
3511         <data_window>: Change type.
3512         (struct tui_data_item_window): New.
3513         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3514         case.  Add assert.
3515         (~tui_data_item_window): New destructor.
3516         (free_content_elements): Remove DATA_ITEM_WIN case.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3521         Remove.
3522
3523 2019-06-25  Tom Tromey  <tom@tromey.com>
3524
3525         * tui/tui-data.h (struct tui_command_element): Remove.
3526         (union tui_which_element) <command>: Remove.
3527         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3528         assert.
3529         (free_content_elements): Remove CMD_WIN case.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-layout.c (tui_set_layout): Update.
3534         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3535         * tui/tui-data.c (layout_def): Update.
3536
3537 2019-06-25  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3540         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3541         (tui_source_window_base::set_new_height): Update.
3542         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3543         Update.
3544         (tui_set_locator_fullname, tui_set_locator_info)
3545         (tui_show_frame_info): Update.
3546         * tui/tui-source.c (tui_set_source_content)
3547         (tui_source_is_displayed): Update.
3548         * tui/tui-layout.c (show_source_disasm_command, show_data)
3549         (show_source_or_disasm_and_command): Update.
3550         * tui/tui-disasm.c (tui_set_disassem_content)
3551         (tui_get_begin_asm_address): Update.
3552         * tui/tui-data.h (struct tui_locator_element): Remove.
3553         (union tui_which_element) <locator>: Remove.
3554         (struct tui_locator_window): New.
3555         (tui_locator_win_info_ptr): Change return type.
3556         * tui/tui-data.c (_locator): Change type.
3557         (tui_locator_win_info_ptr): Change return type.
3558         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3559         (tui_alloc_content): Add assert.
3560
3561 2019-06-25  Tom Tromey  <tom@tromey.com>
3562
3563         * tui/tui-winsource.c
3564         (tui_exec_info_window::maybe_allocate_content): New method.
3565         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3566         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3567         (make_source_or_disasm_window): Add cast.
3568         * tui/tui-data.h (union tui_which_element) <simple_string>:
3569         Remove.
3570         (struct tui_source_info): New.
3571         (struct tui_source_window_base) <execution_info>: Change type.
3572         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3573         case, and add assert.
3574         (tui_alloc_content): Add assert.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3579         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3580         * tui/tui-data.c (tui_alloc_win_info): Remove.
3581
3582 2019-06-25  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3585         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3586         can_highlight.
3587
3588 2019-06-25  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3591         make_visible_with_new_height method.
3592         (tui_win_info::make_visible_with_new_height): New method.
3593         (tui_source_window_base::do_make_visible_with_new_height)
3594         (tui_data_window::do_make_visible_with_new_height)
3595         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3596         (make_visible_with_new_height): Remove.
3597         (tui_resize_all, tui_adjust_win_heights): Use
3598         make_visible_with_new_height method.
3599         * tui/tui-data.h (struct tui_win_info)
3600         <do_make_visible_with_new_height, make_visible_with_new_height>:
3601         New methods.
3602         (struct tui_source_window_base, struct tui_data_window)
3603         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3604         methods.
3605
3606 2019-06-25  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3609         method.
3610         (update_tab_width): Call update_tab_width method.
3611         * tui/tui-data.h (struct tui_win_info)
3612         (struct tui_source_window_base) <update_tab_width>: New methods.
3613
3614 2019-06-25  Tom Tromey  <tom@tromey.com>
3615
3616         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3617         parameter.
3618         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3619         parameter.
3620         (tui_gen_win_info::make_visible): Update.
3621         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3622         parameter.
3623         * tui/tui-data.h (enum tui_box): New enum.
3624         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3629         init_and_make_win for EXEC_INFO_WIN.
3630         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3631         longer inline.
3632         (struct tui_win_info) <~tui_win_info>: Inline.
3633         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3634         Don't declare.
3635         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3636         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3637         Remove.
3638         (tui_initialize_static_data): Update.
3639         (~tui_gen_win_info): Handle more cleanup here.
3640         (~tui_source_window_base): Delete "execution_info".
3641         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3642
3643 2019-06-25  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-layout.c (make_command_window): Don't set
3646         can_highlight.
3647         (show_source_disasm_command): Call the reset method.
3648         (show_data): Don't set can_highlight.  Call the reset method.
3649         (tui_gen_win_info::reset): Rename from init_gen_win_info
3650         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3651         (show_source_or_disasm_and_command): Call the reset method.
3652         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3653         (struct tui_cmd_window): Set can_highlight.
3654
3655 2019-06-25  Tom Tromey  <tom@tromey.com>
3656
3657         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3658         from make_visible.
3659         (tui_make_visible, tui_make_invisible): Rewrite.
3660         (tui_win_info::make_visible): Remove.
3661         (tui_source_window_base::make_visible): Update.
3662         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3663         method.  Moved from...
3664         (struct tui_win_info) <make_visible>: ...here.
3665
3666 2019-06-25  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-winsource.c
3669         (tui_source_window_base::do_scroll_horizontal): Remove direction
3670         parameter.
3671         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3672         direction parameter.
3673         * tui/tui-win.c (tui_win_info::forward_scroll)
3674         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3675         (tui_win_info::right_scroll): Update.
3676         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3677         direction parameter.
3678         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3679         direction parameter.
3680         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3681         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3682         Remove direction parameter.
3683         (struct tui_source_window_base, struct tui_source_window)
3684         (struct tui_disasm_window, struct tui_data_window)
3685         (struct tui_cmd_window): Update.
3686
3687 2019-06-25  Tom Tromey  <tom@tromey.com>
3688
3689         * tui/tui-winsource.h (tui_set_exec_info_content)
3690         (tui_show_exec_info_content, tui_erase_exec_info_content)
3691         (tui_clear_exec_info_content, tui_update_exec_info): Change
3692         argument to tui_source_window_base.
3693         * tui/tui-winsource.c (tui_set_exec_info_content)
3694         (tui_show_exec_info_content, tui_erase_exec_info_content)
3695         (tui_clear_exec_info_content, tui_update_exec_info): Change
3696         argument to tui_source_window_base.
3697
3698 2019-06-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3701         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3702
3703 2019-06-25  Tom Tromey  <tom@tromey.com>
3704
3705         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3706         check.
3707
3708 2019-06-25  Tom Tromey  <tom@tromey.com>
3709
3710         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3711         type to void.
3712         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3713         type to void.
3714         * tui/tui-source.c (tui_set_source_content): Update.
3715         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3716
3717 2019-06-25  Tom Tromey  <tom@tromey.com>
3718
3719         * tui/tui-win.c (window_name_completer, tui_set_focus)
3720         (tui_all_windows_info): Use name method.
3721         * tui/tui-data.h (struct tui_gen_win_info)
3722         (struct tui_source_window, struct tui_disasm_window)
3723         (struct tui_data_window, struct tui_cmd_window) <name>: New
3724         method.
3725         (tui_win_name): Don't declare.
3726         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3727         (tui_win_name): Remove.
3728
3729 2019-06-25  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-winsource.h (tui_update_source_window)
3732         (tui_update_source_window_as_is): Change parameter type.
3733         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3734         to be a tui_source_window_base.
3735         (tui_update_source_window_as_is): Likewise.
3736         * tui/tui-win.c (make_visible_with_new_height): Update.
3737
3738 2019-06-25  Tom Tromey  <tom@tromey.com>
3739
3740         * tui/tui-winsource.c (tui_erase_source_content)
3741         (tui_show_source_content, tui_show_exec_info_content)
3742         (tui_erase_exec_info_content): Use refresh_window method.
3743         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3744         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3745         from tui_refresh_win.
3746         (tui_data_window::refresh_window): New method.
3747         (tui_win_info::refresh, tui_source_window_base::refresh)
3748         (tui_refresh_all): Use refresh_window method.
3749         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3750         method.
3751         * tui/tui-regs.c (tui_display_register): Call refresh_window
3752         method.
3753         * tui/tui-layout.c (show_source_disasm_command)
3754         (show_source_or_disasm_and_command): Call refresh_window method.
3755         * tui/tui-data.h (struct tui_gen_win_info)
3756         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3757         New method.
3758
3759 2019-06-25  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui.c (tui_rl_other_window, tui_enable)
3762         (tui_is_window_visible, tui_get_command_dimension): Update.
3763         * tui/tui-winsource.c (tui_update_source_window_as_is)
3764         (tui_clear_source_content, tui_erase_source_content)
3765         (tui_show_source_line, tui_source_window_base::refill)
3766         (tui_source_window_base::do_scroll_horizontal)
3767         (tui_source_window_base::set_is_exec_point_at)
3768         (tui_update_breakpoint_info, tui_set_exec_info_content)
3769         (tui_alloc_source_buffer, tui_line_is_displayed)
3770         (tui_addr_is_displayed): Update.
3771         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3772         (tui_check_and_display_highlight_if_needed)
3773         (tui_win_info::make_visible, tui_win_info::refresh)
3774         (tui_refresh_all): Update.
3775         * tui/tui-windata.c (tui_first_data_item_displayed)
3776         (tui_delete_data_content_windows, tui_erase_data_content)
3777         (tui_display_all_data, tui_data_window::refresh_all)
3778         (tui_check_data_values): Update.
3779         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3780         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3781         (tui_win_info::backward_scroll, tui_refresh_all_win)
3782         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3783         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3784         (tui_source_window_base::set_new_height)
3785         (tui_data_window::set_new_height)
3786         (make_invisible_and_set_new_height)
3787         (make_visible_with_new_height, new_height_ok)
3788         (parse_scrolling_args): Update.
3789         * tui/tui-stack.c (tui_show_frame_info): Update.
3790         * tui/tui-source.c (tui_set_source_content)
3791         (tui_set_source_content_nil, tui_source_is_displayed)
3792         (tui_source_window::do_scroll_vertical): Update.
3793         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3794         (tui_display_registers_from, tui_display_reg_element_at_line)
3795         (tui_check_register_values, tui_reg_command): Update.
3796         * tui/tui-layout.c (tui_default_win_height)
3797         (show_source_disasm_command, show_data, init_and_make_win)
3798         (show_source_or_disasm_and_command): Update.
3799         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3800         (tui_redisplay_readline, tui_mld_flush)
3801         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3802         (tui_getc): Update.
3803         * tui/tui-disasm.c (tui_set_disassem_content)
3804         (tui_disasm_window::do_scroll_vertical): Update.
3805         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3806         Now virtual.
3807         (struct tui_win_info): Derive from tui_gen_win_info.
3808         <~tui_win_info>: Mark as override.
3809         <generic>: Remove member.
3810         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3811         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3812         (~tui_data_window, ~tui_win_info)
3813         (tui_free_all_source_wins_content): Update.
3814         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3815
3816 2019-06-25  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-layout.c (init_and_make_win): Use new.
3819         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3820         destructor, initializers.
3821         (tui_alloc_generic_win_info): Don't declare.
3822         * tui/tui-data.c (_locator): Add argument to constructor.
3823         (source_win, disasm_win): New globals.
3824         (exec_info): Remove.
3825         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3826         Update.
3827         (tui_alloc_generic_win_info): Remove.
3828         (init_content_element): Use new.
3829         (tui_win_info::tui_win_info): Update.
3830         (free_content_elements) <case DATA_WIN>: Use delete.
3831
3832 2019-06-25  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3835         * tui/tui-windata.c (tui_first_data_item_displayed)
3836         (tui_delete_data_content_windows): Update.
3837         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3838         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3839         (tui_display_registers_from, tui_check_register_values): Update.
3840         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3841         pointer.
3842         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3843         window.
3844         (tui_free_data_content): Update.
3845         (free_content_elements) <case DATA_WIN>: Free the window.
3846
3847 2019-06-25  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3850         Update.
3851         * tui/tui-layout.c (make_command_window)
3852         (show_source_disasm_command, show_data, init_and_make_win)
3853         (show_source_or_disasm_and_command): Update.
3854         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3855         method.
3856         <can_highight, is_highlighted>: Now bool.
3857         (tui_set_win_highlight): Don't declare.
3858         * tui/tui-data.c (tui_set_win_highlight): Remove.
3859
3860 2019-06-25  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-wingeneral.c (make_visible): Remove check of window
3863         type.
3864
3865 2019-06-25  Tom Tromey  <tom@tromey.com>
3866
3867         * tui/tui-win.c (tui_win_info::max_height)
3868         (tui_cmd_window::max_height): New methods.
3869         (new_height_ok): Call max_height.
3870         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3871         <max_height>: New method.
3872
3873 2019-06-25  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-win.c (tui_source_window_base::set_new_height)
3876         (tui_data_window::set_new_height): New methods.
3877         (make_invisible_and_set_new_height): Call set_new_height method.
3878         * tui/tui-data.h (struct tui_win_info)
3879         (struct tui_source_window_base, struct tui_data_window)
3880         <set_new_height>: New method.
3881
3882 2019-06-25  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3885         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3886         tui_refresh_data_win.
3887         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3888         method.
3889         (tui_refresh_all_win): Call the refresh_all method.
3890         (tui_set_focus): Likewise.
3891         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3892         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3893         Likewise.
3894
3895 2019-06-25  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-winsource.h (tui_refill_source_window)
3898         (tui_set_is_exec_point_at): Don't declare.
3899         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3900         (tui_source_window_base::refill): Rename from
3901         tui_refill_source_window.
3902         (tui_source_window_base::do_scroll_horizontal): Update.
3903         (tui_source_window_base::set_is_exec_point_at): Rename from
3904         tui_set_is_exec_point_at.
3905         (tui_update_all_breakpoint_info): Update.
3906         * tui/tui-stack.c (tui_show_frame_info): Update.
3907         * tui/tui-layout.c (show_data): Add cast.
3908         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3909         * tui/tui-data.h (struct tui_source_window_base) <refill,
3910         set_is_exec_point_at>: New methods.
3911         (tui_source_windows, tui_add_to_source_windows): Update types.
3912         (tui_add_to_source_windows): Remove redundant declaration.
3913         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3914         (tui_source_windows): Change return type.
3915         (tui_clear_source_windows_detail): Update.
3916         (tui_add_to_source_windows): Change type of parameter.
3917         (tui_free_all_source_wins_content): Update.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-wingeneral.c (tui_win_info::refresh)
3922         (tui_source_window_base::refresh): New methods.
3923         (tui_refresh_all): Call the refresh method.
3924         * tui/tui-data.h (struct tui_win_info)
3925         (struct tui_source_window_base) <refresh>: New method.
3926
3927 2019-06-25  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui.h (tui_is_window_visible): Return bool.
3930         * tui/tui.c (tui_is_window_visible): Return bool.
3931         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3932         (tui_make_visible, tui_make_invisible)
3933         (tui_win_info::make_visible)
3934         (tui_source_window_base::make_visible, make_all_visible)
3935         (tui_make_all_visible, tui_make_all_invisible): Update.
3936         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3937         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3938         bool.
3939         (struct tui_win_info, struct tui_source_window_base)
3940         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3941         * tui/tui-data.c (tui_init_generic_part): Update.
3942
3943 2019-06-25  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3946         (tui_source_window_base::make_visible): New methods.
3947         (make_all_visible): Make method call.
3948         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3949         (struct tui_source_window_base, struct tui_cmd_window): Override
3950         make_visible.
3951         (tui_win_is_source_type): Don't declare.
3952         * tui/tui-data.c (tui_win_is_source_type): Remove.
3953
3954 2019-06-25  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3957         NULL check.
3958
3959 2019-06-25  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3962         Inline constructor.  Add initializers for members.
3963         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3964         constructors; now inline in class.
3965
3966 2019-06-25  Tom Tromey  <tom@tromey.com>
3967
3968         * tui/tui-regs.c (tui_show_registers): Update.
3969         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3970         bool.
3971         * tui/tui-data.c (tui_data_window::clear_detail)
3972         (tui_data_window): Update.
3973
3974 2019-06-25  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-windata.c (tui_display_all_data)
3977         (tui_display_data_from_line, tui_display_data_from)
3978         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3979         Update.
3980         * tui/tui-regs.c (tui_last_regs_line_no)
3981         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3982         (tui_show_registers, tui_show_register_group)
3983         (tui_display_registers_from, tui_display_reg_element_at_line)
3984         (tui_display_registers_from_line, tui_check_register_values)
3985         (tui_reg_next, tui_reg_prev): Update.
3986         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3987         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3988         tui_data_window.
3989         (struct tui_win_info) <detail>: Remove.  Add new fields from
3990         tui_data_info.
3991         (TUI_DATA_WIN): Add cast.
3992         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3993         (~tui_data_window): Simplify.
3994
3995 2019-06-25  Tom Tromey  <tom@tromey.com>
3996
3997         * tui/tui-layout.c (show_source_disasm_command)
3998         (show_source_or_disasm_and_command): Update.
3999         * tui/tui-io.c (update_cmdwin_start_line)
4000         (tui_redisplay_readline): Update.
4001         * tui/tui-data.h (struct tui_command_info): Remove.
4002         (struct tui_win_info) <detail>: Remove command_info member.
4003         (struct tui_data_window) <start_line>: New member, from
4004         tui_command_info.
4005         (TUI_CMD_WIN): Add casts.
4006
4007 2019-06-25  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-winsource.c (tui_update_source_window)
4010         (tui_refill_source_window)
4011         (tui_source_window_base::do_scroll_horizontal)
4012         (tui_update_breakpoint_info, tui_set_exec_info_content)
4013         (tui_show_exec_info_content, tui_erase_exec_info_content)
4014         (tui_clear_exec_info_content): Update.
4015         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4016         Update.
4017         * tui/tui-win.c (make_invisible_and_set_new_height)
4018         (make_visible_with_new_height): Update.
4019         * tui/tui-source.c (tui_set_source_content)
4020         (tui_show_symtab_source): Update.
4021         * tui/tui-layout.c (extract_display_start_addr)
4022         (show_source_disasm_command, show_data)
4023         (make_source_or_disasm_window)
4024         (show_source_or_disasm_and_command): Update.
4025         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4026         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4027         "gdbarch".
4028         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4029         to tui_source_window_base.
4030         (struct tui_win_info) <detail>: Remove source_info member.
4031         (struct tui_source_window_base) <has_locator>: Inline.
4032         Move contents from tui_source_info; rename has_locator member to
4033         m_has_locator.
4034         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4035         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4036         header file.
4037         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4038         Simplify.
4039         (tui_free_all_source_wins_content): Cast to
4040         tui_source_window_base.
4041
4042 2019-06-25  Tom Tromey  <tom@tromey.com>
4043
4044         * tui/tui-win.c (make_invisible_and_set_new_height)
4045         (make_visible_with_new_height): Call has_locator method.
4046         * tui/tui-layout.c (show_source_disasm_command, show_data)
4047         (show_source_or_disasm_and_command): Update for bool change.
4048         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4049         (tui_win_info) <has_locator>: New method.
4050         (struct tui_source_window_base) <has_locator>: New method.
4051         (tui_win_has_locator): Don't declare.
4052         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4053         from tui_win_has_locator.
4054         (tui_source_window_base): Use false, not FALSE.
4055
4056 2019-06-25  Tom Tromey  <tom@tromey.com>
4057
4058         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4059         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4060         clear_detail method directly.
4061         (tui_clear_win_detail): Remove.
4062
4063 2019-06-25  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4066         "this", not TUI_DISASM_WIN.
4067
4068 2019-06-25  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4071         declare.
4072         * tui/tui-winsource.c
4073         (tui_source_window_base::do_scroll_horizontal): Rename from
4074         tui_horizontal_source_scroll.
4075         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4076         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4077         from tui_vertical_data_scroll.
4078         * tui/tui-win.h (tui_scroll): Don't declare.
4079         * tui/tui-win.c (tui_win_info::forward_scroll)
4080         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4081         (tui_win_info::right_scroll): Rename and update.
4082         (tui_scroll_forward_command, tui_scroll_backward_command)
4083         (tui_scroll_left_command, tui_scroll_right_command): Update.
4084         (tui_scroll): Remove.
4085         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4086         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4087         from tui_vertical_source_scroll.
4088         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4089         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4090         from tui_vertical_disassem_scroll.
4091         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4092         do_scroll_horizontal>: New methods.
4093         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4094         Likewise.
4095         (struct tui_source_window_base): Add do_scroll_horizontal.
4096         (struct tui_source_window, struct tui_disasm_window): Add
4097         do_scroll_vertical.
4098         (struct tui_data_window, struct tui_cmd_window): Add
4099         do_scroll_horizontal and do_scroll_vertical.
4100         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4101
4102 2019-06-25  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-data.h (struct tui_source_window_base): New struct.
4105         (struct tui_source_window): Derive from tui_source_window_base.
4106         (struct tui_disasm_window): New struct.
4107         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4108         from tui_source_window::clear_detail.
4109         (tui_source_window_base): Rename from tui_source_window.
4110         (~tui_source_window_base): Rename from ~tui_source_window.
4111         (tui_alloc_win_info): Create a tui_disasm_window.
4112
4113 2019-06-25  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui-data.h (struct tui_source_window)
4116         (struct tui_data_window): Declare destructors.
4117         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4118         destructors.
4119         (tui_win_info): Simplify.
4120
4121 2019-06-25  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-winsource.c (tui_display_main)
4124         (tui_update_source_windows_with_addr)
4125         (tui_update_all_breakpoint_info): Update.
4126         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4127         (new_height_ok, parse_scrolling_args): Update.
4128         * tui/tui-stack.c (tui_show_frame_info): Update.
4129         * tui/tui-data.h (struct tui_list): Remove.
4130         (tui_source_windows): Return a reference to a std::vector.
4131         * tui/tui-data.c (source_windows): Now a std::vector.
4132         (tui_source_windows): Change return type.
4133         (tui_clear_source_windows): Rewrite.
4134         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4135         (tui_free_all_source_wins_content): Rewrite.
4136
4137 2019-06-25  Tom Tromey  <tom@tromey.com>
4138
4139         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4140         (struct tui_data_window, struct tui_cmd_window): Declare
4141         clear_detail method.
4142         * tui/tui-data.c (tui_source_window::clear_detail)
4143         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4144         methods.
4145         (tui_clear_win_detail): Simplify.
4146
4147 2019-06-25  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-layout.c (make_source_window, make_disasm_window)
4150         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4151         Return the new window.
4152         (show_source_disasm_command, show_data)
4153         (show_source_or_disasm_and_command): Update.
4154
4155 2019-06-25  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4158         parameter.  Return the new window.
4159         (show_source_disasm_command): Update and remove NULL check.
4160         (show_source_or_disasm_and_command): Update.
4161
4162 2019-06-25  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4165
4166 2019-06-25  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-data.h (struct tui_win_info): Make constructor
4169         protected.  Make destructor virtual.  Add initializers.
4170         (tui_source_window, tui_data_window, tui_cmd_window): New
4171         classes.
4172         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4173         constructor.  Add "type" parameter.
4174         (tui_source_window, tui_data_window, tui_cmd_window): New
4175         constructors.
4176         (tui_alloc_win_info): Instantiate the appropriate subclass.
4177
4178 2019-06-25  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-win.c (tui_resize_all): Use delete.
4181         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4182         destructor.
4183         (tui_free_window): Don't declare.
4184         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4185         Update.
4186
4187 2019-06-25  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-data.h (struct tui_win_info): Add constructor.
4190         * tui/tui-data.c (tui_alloc_win_info): Use new.
4191         (tui_free_window): Use delete.
4192
4193 2019-06-22  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4196         declare.
4197         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4198
4199 2019-06-22  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4202         declare.
4203         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4204
4205 2019-06-22  Tom de Vries  <tdevries@suse.de>
4206
4207         * dwarf2read.c (create_addrmap_from_aranges)
4208         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4209         instead of '%zu'.
4210
4211 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4212
4213         * dwarf2read.h (dwarf2_section_info_def): Remove.
4214         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4215         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4216         std::vector<dwarf2_section_info>.
4217         (struct dwo_file) <~dwo_file>: Remove.
4218         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4219         types field.
4220         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4221         (dwarf2_read_debug_names): Likewise.
4222         (create_debug_types_hash_table): Change parameter type to
4223         array_view, adjust code accordingly.
4224         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4225         (partial_die_info::fixup): Likewise.
4226         (determine_prefix): Likewise.
4227         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4228
4229 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4230
4231         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4232         gdb_bfd_ref_ptr.
4233         <~dwo_file>: Remove call to gdb_bfd_unref.
4234         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4235         gdb_bfd_ref_ptr::get.
4236
4237 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4238
4239         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4240         type to htab_up.
4241         * dwarf2read.c (struct dwo_file): Initialize fields.
4242         <~dwo_file>: New.
4243         (free_dwo_file): Remove, move content to ~dwo_file.
4244         (struct dwo_file_deleter): Remove.
4245         (dwo_file_up>: Remove custom deleter.
4246         (free_dwo_files): Remove.
4247         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4248         dwo_files.
4249         (process_skeletonless_type_units): Call unique_ptr::get.
4250         (allocate_dwo_file_hash_table): Add deleter to created hash
4251         table.  Change return type to htab_up.
4252         (lookup_dwo_file_slot): Don't memset dwo_file, call
4253         unique_ptr::get.
4254         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4255         (create_dwo_unit_in_dwp_v2): Likewise.
4256         (open_and_init_dwo_file): Likewise.
4257         (free_dwo_file_from_slot): Remove.
4258
4259 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4260
4261         * dwarf2read.h (struct dwarf2_section_info) <readin,
4262         is_virtual>: Change type to bool.
4263         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4264         true instead of 1.
4265
4266 2019-06-19  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-data.h (tui_init_content_element): Don't declare.
4269
4270 2019-06-19  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-data.h (tui_init_win_info): Don't declare.
4273
4274 2019-06-19  Tom de Vries  <tdevries@suse.de>
4275
4276         * dwarf2read.h (abstract_to_concrete): Change type to
4277         std::unordered_map<sect_offset, std::vector<sect_offset>,
4278         gdb::hash_enum<sect_offset>>.
4279
4280 2019-06-19  Tom Tromey  <tromey@adacore.com>
4281
4282         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4283         EVAL_AVOID_SIDE_EFFECTS specially.
4284
4285 2019-06-19  Tom Tromey  <tromey@adacore.com>
4286
4287         * source-cache.c (highlighter): New global.
4288         (source_cache::get_source_lines): Create a highlighter on demand.
4289
4290 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * defs.h (deprecated_interactive_hook): Delete declaration.
4293         * interps.c (clear_interpreter_hooks): Remove use of
4294         deprecated_interactive_hook.
4295         * top.c (deprecated_interactive_hook): Delete definition.
4296         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4297
4298 2019-06-18  Tom de Vries  <tdevries@suse.de>
4299
4300         PR gdb/24515
4301         * dwarf2read.h (abstract_to_concrete): Change type from
4302         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4303         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4304         * dwarf2read.c (read_variable): Update.
4305         (dwarf2_fetch_die_loc_sect_off): Update.
4306
4307 2019-06-17  Tom de Vries  <tdevries@suse.de>
4308
4309         PR gdb/24617
4310         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4311         accessing parent[parent_len - 1].
4312
4313 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4314
4315         PR gdb/24364
4316         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4317         call dtrace_process_dof with NULL dof.
4318
4319 2019-06-16  Tom de Vries  <tdevries@suse.de>
4320
4321         PR gdb/24445
4322         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4323
4324 2019-06-16  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4327         (make_all_visible): Use address of member.
4328
4329 2019-06-16  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4332         (tui_free_window, free_content, free_content_elements): Remove
4333         unnecessary cast.
4334         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4335         cast.
4336         * tui/tui-regs.c (tui_show_register_group)
4337         (tui_display_registers_from, tui_display_reg_element_at_line):
4338         Remove unnecessary cast.
4339
4340 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * linux-nat.c (normal_mask): Delete.
4343         (_initialize_linux_nat): Don't initialise normal_mask.
4344
4345 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4346
4347         PR gdb/24445
4348         * dwarf-index-write.h (write_psymtabs_to_index): Add
4349         dwz_basename parameter.
4350         * dwarf-index-write.c (write_gdbindex): Move file writing to
4351         write_gdbindex_1.  Change return type void.
4352         (assert_file_size): Move up, remove filename parameter.
4353         (write_gdbindex_1): New function.
4354         (write_debug_names): Change return type to void, call
4355         assert_file_size.
4356         (struct index_wip_file): New struct.
4357         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4358         file logic to index_wip_file.  Write index for dwz file if
4359         needed.
4360         (save_gdb_index_command): Pass basename of dwz file, if present.
4361         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4362         build-id of dwz file, if present.
4363         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4364         (dwarf2_get_dwz_file): Likewise.
4365         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4366         (dwarf2_get_dwz_file): Likewise.
4367
4368 2019-06-16  Tom Tromey  <tom@tromey.com>
4369
4370         * coffread.c (process_coff_symbol): Use xstrdup.
4371         * value.c (create_internalvar): Use xstrdup.
4372
4373 2019-06-16  Tom Tromey  <tom@tromey.com>
4374
4375         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4376         * breakpoint.c (stopin_command, stopat_command)
4377         (until_break_command, decode_location_default): Remove unnecessary
4378         cast.
4379         * utils.c (subset_compare): Remove unnecessary cast.
4380         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4381         cast.
4382         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4383         cast.
4384         * infcmd.c (path_command): Remove unnecessary cast.
4385         * coffread.c (decode_type): Remove unnecessary cast.
4386         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4387         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4388         * tui/tui-stack.c (tui_show_locator_content)
4389         (tui_show_frame_info): Remove unnecessary cast.
4390         * tui/tui-win.c (tui_scroll_forward_command)
4391         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4392         (parse_scrolling_args): Remove unnecessary cast.
4393         * tui/tui-data.c (init_win_info, tui_del_window)
4394         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4395         (free_content_elements): Remove unnecessary cast.
4396         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4397         unnecessary cast.
4398         * tui/tui-source.c (tui_set_source_content)
4399         (tui_vertical_source_scroll): Remove unnecessary cast.
4400         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4401         cast.
4402         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4403         * tui/tui-regs.c (tui_display_registers_from)
4404         (tui_display_register): Remove unnecessary cast.
4405         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4406         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4407         (make_visible): Remove unnecessary cast.
4408         * tui/tui-winsource.c (tui_erase_source_content)
4409         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4410         unnecessary cast.
4411         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4412         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4413         * stabsread.c (read_type, read_array_type, read_range_type):
4414         Remove unnecessary cast.
4415         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4416         (parse_symbol, parse_type, upgrade_type, parse_external)
4417         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4418         unnecessary cast.
4419         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4420
4421 2019-06-16  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-data.c (tui_alloc_generic_win_info)
4424         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4425         checks.
4426
4427 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4428             Andrew Burgess  <andrew.burgess@embecosm.com>
4429
4430         * f-typeprint.c (f_print_type): Don't return early for not
4431         associated or not allocated types.
4432         (f_type_print_varspec_suffix): Add print_rank parameter and print
4433         ranks of array types in case they dangling.
4434         (f_type_print_base): Add print_rank parameter.
4435
4436 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * NEWS: Mention new MI commands.
4439         * break-catch-throw.c (enum exception_event_kind): Move to
4440         breakpoint.h.
4441         (print_mention_exception_catchpoint): Output text as a single
4442         message.
4443         (catch_exception_command_1): Rename to...
4444         (catch_exception_event): ...this, make non-static, update header
4445         command, and change some parameter types.
4446         (catch_catch_command): Update for changes to
4447         catch_exception_command_1.
4448         (catch_throw_command): Likewise.
4449         (catch_rethrow_command): Likewise.
4450         * breakpoint.c (enum exception_event_kind): Delete.
4451         * breakpoint.h (enum exception_event_kind): Moved here from
4452         break-catch-throw.c.
4453         (catch_exception_event): Declare.
4454         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4455         (mi_cmd_catch_throw): New function.
4456         (mi_cmd_catch_rethrow): New function.
4457         (mi_cmd_catch_catch): New function.
4458         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4459         'catch-catch' entries.
4460         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4461         (mi_cmd_catch_rethrow): Declare.
4462         (mi_cmd_catch_catch): Declare.
4463
4464 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * annotate.c (annotate_source_line): Change return type to void,
4467         update implementation to match.
4468         * annotate.h (annotate_source_line): Change return type to void,
4469         update header comment.
4470         * stack.c (print_frame_info): Don't change what frame information
4471         is printed based on whether annotations are on or not.
4472
4473 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4476         (annotate_source): Make static.
4477         (annotate_source_line): Moved from source.c and renamed from
4478         identify_source_line.  Update the return type.
4479         * annotate.h (annotate_source): Delete declaration.
4480         (annotate_source_line): Declaration moved from source.h, and
4481         renamed from identify_source_line.  Return type updated.
4482         * source.c (identify_source_line): Moved to annotate.c and renamed
4483         to annotate_source_line.
4484         (info_line_command): Remove check of annotation_level.
4485         * source.h (identify_source_line): Move declaration to annotate.h
4486         and rename to annotate_source_line.
4487         * stack.c: Add 'annotate.h' include.
4488         (print_frame_info): Remove check of annotation_level before
4489         calling annotate_source_line.
4490
4491 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * source-cache.c (source_cache::get_plain_source_lines): Use
4494         open_source_file_with_line_charpos instead of just
4495         open_source_file, remove call to find_source_lines.
4496         (source_cache::get_source_lines): Likewise.
4497         * source.c (find_source_lines): Make static.
4498         (get_filename_and_charpos): Renamed into...
4499         (open_source_file_with_line_charpos): ..this along with changes to
4500         return a scoped_fd, and some other minor clean ups.
4501         (identify_source_line): Use open_source_file_with_line_charpos.
4502         (search_command_helper): Use open_source_file_with_line_charpos
4503         instead of just open_source_file, remove call to
4504         find_source_lines.
4505         * source.h (open_source_file_with_line_charpos): Declare new
4506         function.
4507         (find_source_lines): Delete declaration.
4508
4509 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * source.c (get_filename_and_charpos): Remove fullname
4512         parameter.
4513         (identify_source_line): Update call to get_filename_and_charpos.
4514
4515 2019-06-14  Tom Tromey  <tromey@adacore.com>
4516
4517         PR gdb/24502:
4518         * ui-style.h (skip_ansi_escape): Update comment.
4519         * ui-file.h (class no_terminal_escape_file): New class.
4520         * ui-file.c (no_terminal_escape_file::write)
4521         (no_terminal_escape_file::puts): New methods.
4522         * cli/cli-logging.c (handle_redirections): Use
4523         no_terminal_escape_file.
4524
4525 2019-06-14  Tom Tromey  <tromey@adacore.com>
4526
4527         * NEWS: Move convenience variable news above Python news.
4528
4529 2019-06-14  Tom Tromey  <tom@tromey.com>
4530
4531         * gnulib: Move directory to top-level.
4532         * configure.ac: Don't configure gnulib.
4533         * configure: Rebuild.
4534         * common/common-defs.h: Use new path to gnulib.
4535         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4536         (GNULIB_H): Remove.
4537         (INCGNU): Look in new gnulib location.
4538         (HFILES_NO_SRCDIR): Remove gnulib files.
4539         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4540         (generated_files): Remove GNULIB_H.
4541         ($(LIBGNU), all-lib): Remove targets.
4542         (distclean): Don't mention GNULIB_BUILDDIR.
4543         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4544
4545 2019-06-14  Tom Tromey  <tromey@adacore.com>
4546
4547         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4548         Warn if symbol file does not provide any symbols.
4549
4550 2019-06-14  Tom Tromey  <tromey@adacore.com>
4551
4552         * source.c (find_and_open_source): Respect basenames_may_differ.
4553
4554 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * annotate.c (annotate_breakpoints_invalid): Make use of
4557         scoped_restore_terminal_state.
4558         (annotate_frames_invalid): Likewise.
4559
4560 2019-06-14  Tom Tromey  <tromey@adacore.com>
4561
4562         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4563         allow assignment to an internalvar.
4564
4565 2019-06-14  Tom Tromey  <tromey@adacore.com>
4566
4567         * ada-lex.l: Allow "_" in attribute names.
4568
4569 2019-06-14  Tom Tromey  <tromey@adacore.com>
4570
4571         PR gdb/24653:
4572         * regcache.c (registers_changed): Don't call alloca.
4573         * top.c (execute_command): Don't call alloca.
4574
4575 2019-06-13  Pedro Alves  <palves@redhat.com>
4576
4577         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4578         'expression'.  When parsing an expression, error out if there's
4579         junk after "unlimited".
4580         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4581         (do_set_command): Adjust calls to is_unlimited_literal.
4582
4583 2019-06-13  Pedro Alves  <palves@redhat.com>
4584
4585         * compile/compile.c (make_compile_options_def_group): Add braces
4586         around array_view initializer.
4587         * thread.c (make_thread_apply_all_options_def_group)
4588         (make_thread_apply_all_options_def_group): Likewise.
4589
4590 2019-06-13  Pedro Alves  <palves@redhat.com>
4591
4592         * NEWS (New commands): Mention "maint test-options
4593         require-delimiter", "maint test-options unknown-is-error", "maint
4594         test-options unknown-is-operand" and "maint show
4595         test-options-completion-result".
4596         (New command options, command completion): New section.
4597         (Completion improvements): New section.
4598         Mention that you can abbreviate "unlimited".
4599
4600 2019-06-13  Pedro Alves  <palves@redhat.com>
4601
4602         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4603         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4604         * unittests/cli-utils-selftests.c (test_parse_flags)
4605         (test_parse_flags_qcs): Delete.
4606         (test_cli_utils): Don't call deleted functions.
4607
4608 2019-06-13  Pedro Alves  <palves@redhat.com>
4609
4610         * thread.c: Include "cli/cli-option.h".
4611         (tp_array_compar_ascending): Global.
4612         (tp_array_compar): Delete function.
4613         (tp_array_compar_ascending, tp_array_compar_descending): New
4614         functions.
4615         (ascending_option_def, qcs_flag_option_def)
4616         (thr_qcs_flags_option_defs)
4617         (make_thread_apply_all_options_def_group)
4618         (make_thread_apply_options_def_group): New.
4619         (thread_apply_all_command): Use gdb::option::process_options.
4620         (thread_apply_command_completer)
4621         (thread_apply_all_command_completer): New.
4622         (thread_apply_command): Use gdb::option::process_options.
4623         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4624         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4625         to generate help text of "thread apply".  Adjust "taas"'s help.
4626         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4627         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4628
4629 2019-06-13  Pedro Alves  <palves@redhat.com>
4630
4631         * thread.c (thread_apply_command): Check for invalid TID with
4632         isdigit instead of !isalpha.
4633
4634 2019-06-13  Pedro Alves  <palves@redhat.com>
4635
4636         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4637         (validate_flags_qcs): New.
4638         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4639         (validate_flags_qcs): Declare.
4640         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4641         (make_frame_apply_options_def_group): New.
4642         (frame_apply_command_count): Process options with
4643         gdb::option::process_options.
4644         (frame_apply_completer): New.
4645         (frame_apply_level_completer, frame_apply_all_completer)
4646         (frame_apply_completer): New.
4647         (_initialize_stack): Update help of "frame apply", "frame apply
4648         level", "frame apply all" and "faas" to mention supported options
4649         and install command completers.
4650         * stack.h (frame_apply_all_completer): Declare.
4651         * thread.c: Include "stack.h".
4652         (tfaas_command): Add "--".
4653         (_initialize_thread): Update help "tfaas" to mention supported
4654         options and install command completer.
4655
4656 2019-06-13  Pedro Alves  <palves@redhat.com>
4657
4658         * completer.c (complete_nested_command_line): New.
4659         (gdb_completion_word_break_characters_throw): Add assertion.
4660         * completer.h (complete_nested_command_line): Declare.
4661
4662 2019-06-13  Pedro Alves  <palves@redhat.com>
4663
4664         * stack.c (parse_backtrace_qualifiers): New.
4665         (backtrace_command): Use it.
4666         (backtrace_command_completer): Complete on qualifiers.
4667
4668 2019-06-13  Pedro Alves  <palves@redhat.com>
4669
4670         * frame.c: Include "cli/cli-option.h.
4671         (user_set_backtrace_options): New.
4672         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4673         Delete.
4674         (get_prev_frame): Adjust.
4675         (boolean_option_def, uinteger_option_def)
4676         (set_backtrace_option_defs): New.
4677         (_initialize_frame): Adjust and use
4678         gdb::option::add_setshow_cmds_for_options to install "set
4679         backtrace past-main" and "set backtrace past-entry".
4680         * frame.h: Include "cli/cli-option.h".
4681         (struct frame_print_options): Forward declare.
4682         (print_frame_arguments_all, print_frame_arguments_scalars)
4683         (print_frame_arguments_none): Declare.
4684         (print_entry_values): Delete declaration.
4685         (struct frame_print_options, user_frame_print_options): New.
4686         (struct set_backtrace_options): New.
4687         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4688         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4689         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4690         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4691         (list_args_or_locals): Add frame_print_options parameter.
4692         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4693         * python/py-framefilter.c (enumerate_args): Pass down
4694         USER_FRAME_PRINT_OPTIONS.
4695         * stack.c: Include "cli/cli-option.h".
4696         (print_frame_arguments_all, print_frame_arguments_scalars)
4697         (print_frame_arguments_none): Declare.
4698         (print_raw_frame_arguments, print_entry_values): Delete.
4699         (user_frame_print_options): New.
4700         (boolean_option_def, enum_option_def, frame_print_option_defs):
4701         New.
4702         (struct backtrace_cmd_options): New.
4703         (bt_flag_option_def): New.
4704         (backtrace_command_option_defs): New.
4705         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4706         (print_frame_arg, read_frame_arg, print_frame_args)
4707         (print_frame_info, print_frame): Add frame_print_options parameter
4708         and use it.
4709         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4710         (backtrace_command_1): Add frame_print_options and
4711         backtrace_cmd_options parameters and use them.
4712         (make_backtrace_options_def_group): New.
4713         (backtrace_command): Process command options with
4714         gdb::option::process_options.
4715         (backtrace_command_completer): New.
4716         (_initialize_stack): Extend "backtrace"'s help to mention
4717         supported options.  Install completer for "backtrace".
4718         Install some settings commands with add_setshow_cmds_for_options.
4719
4720 2019-06-13  Pedro Alves  <palves@redhat.com>
4721
4722         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4723         and that "set/show print raw frame-arguments" are now deprecated.
4724
4725         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4726         command.
4727         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4728         * stack.c (_initialize_stack): Install "set/show print
4729         raw-frame-arguments", and deprecate "set/show print raw
4730         frame-arguments".
4731         * valprint.c (_initialize_valprint): Deprecate "set/show print
4732         raw".
4733
4734 2019-06-13  Pedro Alves  <palves@redhat.com>
4735
4736         * compile/compile.c (struct compile_options): New.
4737         (compile_flag_option_def, compile_command_option_defs)
4738         (make_compile_options_def_group): New.
4739         (compile_file_command): Handle options with
4740         gdb::option::process_options.
4741         (compile_file_command_completer): New function.
4742         (compile_code_command): Handle options with
4743         gdb::option::process_options.
4744         (compile_code_command_completer): New function.
4745         (_initialize_compiler): Install completers for "compile code" and
4746         "compile file".  Mention available options in "compile code" and
4747         "compile code"'s help.
4748         * completer.c (advance_to_completion_word): New, factored out from
4749         ...
4750         (advance_to_expression_complete_word_point): ... this.
4751         (advance_to_filename_complete_word_point): New.
4752         * completer.h (advance_to_filename_complete_word_point): New
4753         declaration.
4754
4755 2019-06-13  Pedro Alves  <palves@redhat.com>
4756
4757         * compile/compile.c: Include "cli/cli-option.h".
4758         (compile_print_value): Scope data pointer is now a
4759         value_print_options pointer; adjust.
4760         (compile_print_command): Process options.  Scope data pointer is
4761         now a value_print_options pointer; adjust.
4762         (_initialize_compile): Update "compile print"'s help to include
4763         supported options.  Install a completer for "compile print".
4764         * cp-valprint.c (show_vtblprint, show_objectprint)
4765         (show_static_field_print): Delete.
4766         (_initialize_cp_valprint): Don't install "set print
4767         static-members", "set print vtbl", "set print object" here.
4768         * printcmd.c: Include "cli/cli-option.h" and
4769         "common/gdb_optional.h".
4770         (print_command_parse_format): Rework to fill in a
4771         value_print_options instead of a format_data.
4772         (print_value): Change parameter type from format_data pointer to
4773         value_print_options reference.  Adjust.
4774         (print_command_1): Process options.  Adjust to pass down a
4775         value_print_options.
4776         (print_command_completer): New.
4777         (_initialize_printcmd): Install print_command_completer as
4778         handle_brkchars completer for the "print" command.  Update
4779         "print"'s help to include supported options.
4780         * valprint.c: Include "cli/cli-option.h".
4781         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4782         here from cp-valprint.c.
4783         (boolean_option_def, uinteger_option_def)
4784         (value_print_option_defs, make_value_print_options_def_group):
4785         New.  Use gdb::option::add_setshow_cmds_for_options to install
4786         "set print elements", "set print null-stop", "set print repeats",
4787         "set print pretty", "set print union", "set print array", "set
4788         print address", "set print symbol", "set print array-indexes".
4789         * valprint.h: Include <string> and "cli/cli-option.h".
4790         (make_value_print_options_def_group): Declare.
4791         (print_value): Change parameter type from format_data pointer to
4792         value_print_options reference.
4793         (print_command_completer): Declare.
4794
4795 2019-06-13  Pedro Alves  <palves@redhat.com>
4796
4797         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4798         (COMMON_SFILES): Add maint-test-settings.c.
4799         * cli/cli-decode.c (boolean_enums): New global, factored out from
4800         ...
4801         (add_setshow_boolean_cmd): ... here.
4802         * cli/cli-decode.h (boolean_enums): Declare.
4803         * cli/cli-option.c: New file.
4804         * cli/cli-option.h: New file.
4805         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4806         factored out from ...
4807         (parse_cli_boolean_value(const char *)): ... this.
4808         (is_unlimited_literal): Change parameter type to pointer to
4809         pointer.  Adjust and advance ARG pointer.
4810         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4811         (parse_cli_var_enum): New, factored out from ...
4812         (do_set_command): ... this.  Adjust.
4813         * cli/cli-setshow.h (parse_cli_boolean_value)
4814         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4815         (parse_cli_var_enum): Declare.
4816         * cli/cli-utils.c: Include "cli/cli-option.h".
4817         (get_ulongest): New.
4818         * cli/cli-utils.h (get_ulongest): Declare.
4819         (check_for_argument): New overloads.
4820         * maint-test-options.c: New file.
4821
4822 2019-06-13  Pedro Alves  <palves@redhat.com>
4823
4824         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4825         parse a range if "-" is at the end of the string.
4826
4827 2019-06-13  Pedro Alves  <palves@redhat.com>
4828
4829         * cli/cli-setshow.c (parse_auto_binary_operation)
4830         (parse_cli_boolean_value): Don't allow "o".
4831
4832 2019-06-13  Pedro Alves  <palves@redhat.com>
4833
4834         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4835         * NEWS: Mention maint test-settings KIND.
4836         * maint-test-settings.c: New file.
4837
4838 2019-06-13  Pedro Alves  <palves@redhat.com>
4839
4840         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4841         completer.
4842         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4843         "set" completers.
4844
4845 2019-06-13  Pedro Alves  <palves@redhat.com>
4846
4847         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4848         after item.
4849
4850 2019-06-13  Pedro Alves  <palves@redhat.com>
4851
4852         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4853
4854 2019-06-13  Pedro Alves <palves@redhat.com>
4855
4856         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4857         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4858         call.
4859         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4860         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4861         calls.
4862         (check_for_argument): Skip spaces after argument.
4863
4864 2019-06-13  Pedro Alves  <palves@redhat.com>
4865
4866         * thread.c (thread_apply_command): Adjust TID parsing.
4867         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4868         detected before end of string.
4869         (tid_is_in_list): Error out if LIST is invalid.
4870
4871 2019-06-13  Pedro Alves  <palves@redhat.com>
4872
4873         * completer.c (complete_line_internal_1): Rewind completion word
4874         point.
4875         (completion_tracker::advance_custom_word_point_by): Change
4876         parameter type to int.
4877         * completer.h (completion_tracker::advance_custom_word_point_by):
4878         Likewise.
4879
4880 2019-06-13  Pedro Alves  <palves@redhat.com>
4881
4882         * completer.c (advance_to_completion_word): Handle delimiters.
4883
4884 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4885
4886         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4887
4888 2019-06-11  Tom Tromey  <tom@tromey.com>
4889
4890         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4891         (xmalloc_failed): Move to alloc.c.
4892         * alloc.c: New file.
4893         * Makefile.in (COMMON_SFILES): Add alloc.c.
4894
4895 2019-06-11  Tom Tromey  <tom@tromey.com>
4896
4897         * nat/linux-waitpid.c: Don't include server.h.
4898         (linux_debug): Remove.
4899         (my_waitpid): Update.
4900
4901 2019-06-11  Tom Tromey  <tromey@adacore.com>
4902
4903         * infcall.c (_initialize_infcall): Remove trailing newline from
4904         help.
4905         * user-regs.c (_initialize_user_regs): Remove trailing newline
4906         from help.
4907         * typeprint.c (_initialize_typeprint): Remove trailing newline
4908         from help.
4909         * reverse.c (_initialize_reverse): Remove trailing newlines from
4910         help.
4911         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4912         from help.
4913         * language.c (add_set_language_command): Remove trailing newline
4914         from help.
4915         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4916         help.
4917         * disasm.c (_initialize_disasm): Remove trailing newline from
4918         help.
4919         * top.c (init_main): Remove trailing newline from help.
4920         * interps.c (_initialize_interpreter): Remove trailing newline
4921         from help.
4922         * btrace.c (_initialize_btrace): Remove trailing newlines from
4923         help.
4924         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4925         from help.
4926         * python/python.c (_initialize_python): Remove trailing newline
4927         from help.
4928         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4929         help.
4930         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4931         from help.  Reformat some text.
4932         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4933         from help.
4934         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4935         newline from help.
4936
4937 2019-06-11  Tom Tromey  <tromey@adacore.com>
4938
4939         * darwin-nat.c (darwin_decode_exception_message)
4940         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4941
4942 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * valops.c (value_slice): Check for not allocated or not
4945         associated values.
4946
4947 2019-06-10  Tom de Vries  <tdevries@suse.de>
4948
4949         PR gdb/24618
4950         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4951         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4952         invalid.
4953
4954 2019-06-10  Tom de Vries  <tdevries@suse.de>
4955
4956         PR gdb/24611
4957         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4958         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4959
4960 2019-06-10  Tom de Vries  <tdevries@suse.de>
4961
4962         PR symtab/24545
4963         * symtab.c (struct demangled_name_entry): Add language field.
4964         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4965         static minimal symbol".  Set and use language field.
4966
4967 2019-06-10  Tom Tromey  <tromey@adacore.com>
4968
4969         * ada-lang.c (_initialize_ada_language): Update help text.
4970
4971 2019-06-10  Tom Tromey  <tromey@adacore.com>
4972
4973         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4974         with a newline.
4975         * guile/guile.c (handle_boot_error): Don't end warning with a
4976         newline.
4977         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4978         warning with a newline.
4979         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4980         newline.
4981         (s12z_frame_cache): Likewise.
4982         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4983         a newline.
4984         * solib-svr4.c (disable_probes_interface): Don't end warning with
4985         a newline.
4986         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4987         newline.
4988         * python/python.c (do_finish_initialization): Don't end warning
4989         with a newline.
4990
4991 2019-06-10  Tom Tromey  <tom@tromey.com>
4992
4993         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4994         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4995         gdbpy_enter.
4996
4997 2019-06-10  Tom Tromey  <tromey@adacore.com>
4998
4999         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5000         data.
5001         (elf_new_init): Don't call stabsread_new_init.
5002         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5003         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5004         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5005
5006 2019-06-10  Tom de Vries  <tdevries@suse.de>
5007
5008         PR symtab/16264
5009         PR symtab/24517
5010         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5011
5012 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5013
5014         * source.c (find_and_open_source): Also rewrite relative file
5015         names.
5016
5017 2019-04-26  Amos Bird  <amosbird@gmail.com>
5018
5019         * annotate.c (annotate_thread_exited): Add "thread-exited"
5020         annotation.
5021
5022 2019-06-06  Tom Tromey  <tromey@adacore.com>
5023
5024         * maint.h (class scoped_command_stats): Use
5025         DISABLE_COPY_AND_ASSIGN.
5026         <print_time>: New method.
5027         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5028         print_time.
5029         (scoped_command_stats::print_time): New method.
5030
5031 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5034         instructions of lengths 6 or 8 bytes.
5035
5036 2019-06-04  Pedro Alves  <palves@redhat.com>
5037
5038         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5039
5040         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5041         * breakpoint.c (condition_completer): Likewise.
5042         * cli/cli-dump.c (scan_expression): Likewise.
5043         * common/filestuff.c (mkdir_recursive): Likewise.
5044         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5045         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5046         (gdb_abspath): Likewise.
5047         * compile/compile-cplus-types.c
5048         (compile_cplus_instance::decl_name): Likewise.
5049         * completer.c (complete_explicit_location):
5050         (signal_completer, reg_or_group_completer_1): Likewise.
5051         * cp-support.c (cp_remove_params_if_any): Likewise.
5052         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5053         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5054         * infcmd.c (strip_bg_char): Likewise.
5055         * linespec.c (copy_token_string): Likewise.
5056         * mi/mi-main.c (output_cores): Likewise.
5057         * psymtab.c (psymtab_search_name):
5058         * symfile.c (test_set_ext_lang_command): Likewise.
5059         * target.c (target_fileio_read_stralloc): Likewise.
5060         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5061         * value.c (complete_internalvar): Likewise.
5062
5063 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5064
5065         Add objfile property to gdb.Type.
5066         * NEWS: Mention Python API addition.
5067         * python/py-type.c (typy_get_objfile): New method.
5068
5069 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5070
5071         * NEWS: Mention the new set|show style [title|highlight].
5072         Mention changes to "show style", "help" and "apropos".
5073
5074 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5075
5076         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5077         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5078         instead of print_help_for_command.
5079         (print_doc_of_command): New function.
5080         (help_list): Add 'apropos -v word' suggestion.
5081         (print_help_for_command): Style the command name using title style.
5082         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5083         (_initialize_cli_cmds): Describe -v in apropos_command help.
5084
5085 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5086
5087         * cli/cli-style.h (cli_style_option): Add name in constructor,
5088         add m_name class member, add constructor with intensity,
5089         add name class function.
5090         (cli_style_option::add_setshow_commands): Remove name argument.
5091         (highlight_style, title_style): New styles.
5092         * cli/cli-style.c (do_show): New function that shows a style
5093         characteristic styling the style name with itself.
5094         (set_style_name): New function.
5095         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5096         Update all callers according to the changes in cli/cli-style.h.
5097         * utils.h (fputs_highlighted): New function.
5098         * utils.c (fputs_highlighted): Likewise.
5099
5100 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5101
5102         * NEWS: Mention new pipe command and new convenience variables.
5103
5104 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5105
5106         * cli/cli-cmds.c (pipe_command): New function.
5107         (_initialize_cli_cmds): Call add_com for pipe_command.
5108         Define | as an alias for pipe.
5109         (exit_status_set_internal_vars): New function.
5110         (shell_escape): Call exit_status_set_internal_vars.
5111         cli/cli-decode.c (find_command_name_length): Recognize | as
5112         a single character command.
5113
5114 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5115
5116         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5117         top.c (execute_command_to_ui_file): New function, mostly a copy
5118         of execute_command_to_string.
5119         (execute_command_to_string): Implement by calling
5120         execute_command_to_ui_file.
5121
5122 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5123
5124         * top.h (saved_command_line): Remove declaration.
5125         * top.c (previous_saved_command_line, previous_repeat_arguments):
5126         New variables.
5127         (saved_command_line): Make static, define together with other
5128         'repeat variables'.
5129         (dont_repeat): Clear repeat_arguments.
5130         (repeat_previous, get_saved_command_line, save_command_line):
5131         New functions.
5132         (gdb_init): Initialize saved_command_line
5133         and previous_saved_command_line.
5134         * main.c (captured_main_1): Remove saved_command_line initialization.
5135         * event-top.c (handle_line_of_input): Update to use
5136         the new 'repeat' related functions instead of direct access to
5137         saved_command_line.
5138         * command.h (repeat_previous, get_saved_command_line,
5139         save_command_line): New declarations.
5140         (dont_repeat): Add comment.
5141
5142 2019-05-30  Tom Tromey  <tromey@adacore.com>
5143
5144         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5145         Fix comment.
5146         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5147
5148 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5149
5150         PR cli/24587
5151         * completer.c (complete): Initialize variable word.
5152
5153 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5154
5155         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5156         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5157         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5158         'body' is NULL to the outter 'if', protecting the '!is_define'
5159         situation as well.
5160
5161 2019-05-29  Tom Tromey  <tromey@adacore.com>
5162
5163         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5164         (dwarf_unknown): New function.
5165         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5166         (dwarf_type_encoding_name): Use dwarf_unknown.
5167
5168 2019-05-29  Tom Tromey  <tromey@adacore.com>
5169
5170         PR c++/20020:
5171         * cp-valprint.c (cp_print_value_fields): Call
5172         cp_print_static_field inside "try".
5173
5174 2019-05-29  Tom Tromey  <tromey@adacore.com>
5175
5176         * inflow.c (struct terminal_info): Add default operator=.
5177         * configure: Rebuild.
5178         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5179         -Wdeprecated-copy-dtor, -Wredundant-move.
5180
5181 2019-05-29  Tom Tromey  <tromey@adacore.com>
5182
5183         * NEWS: Add entry.
5184         * infcmd.c (print_return_value_1): Handle finish_print
5185         option.
5186         (show_print_finish): New function.
5187         (_initialize_infcmd): Add "set/show print finish" commands.
5188         * valprint.c (user_print_options): Initialize new member.
5189         * valprint.h (struct value_print_options) <finish_print>: New
5190         member.
5191
5192 2019-05-28  Tom Tromey  <tromey@adacore.com>
5193
5194         * ada-lang.c (ada_remove_Xbn_suffix)
5195         (find_old_style_renaming_symbol)
5196         (parse_old_style_renaming): Remove.
5197         (ada_find_renaming_symbol): Don't call
5198         find_old_style_renaming_symbol.
5199         (ada_is_renaming_symbol): Rename from
5200         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5201         bool.  Now static.
5202         (ada_read_var_value): Update and simplify.
5203         * ada-exp.y (write_var_or_type): Remove old code.
5204
5205 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5206
5207         * event-top.c: Remove include comment.
5208         * inflow.c (class scoped_ignore_sigttou): Move from here...
5209         * inflow.h (class scoped_ignore_sigttou): ...to here.
5210         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5211         * top.c:  Remove include comment.
5212
5213 2019-05-27  Tom Tromey  <tom@tromey.com>
5214
5215         * NEWS: Fix typo.
5216
5217 2019-05-22  Tom Tromey  <tromey@adacore.com>
5218
5219         * target.c (target_follow_exec): Constify parameter.
5220         * target-delegates.c: Rebuild.
5221         * remote.c (remote_target::follow_exec): Constify parameter.
5222         * infrun.c (follow_exec): Constify parameter.
5223         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5224         (target_follow_exec): Likewise.
5225
5226 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5227
5228         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5229         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5230
5231 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5232
5233         * NEWS: Add debugredirect and testsuite sections.
5234
5235 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5236
5237         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5238         target descriptions using exclusively floating point register name
5239         aliases.
5240
5241 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5242
5243         PR gdb/18644:
5244         * f-lang.c (build_fortran_types): Handle the case where
5245         gdbarch_floatformat_for_type returns a nullptr.
5246
5247 2019-05-21  Tom de Vries  <tdevries@suse.de>
5248
5249         PR cli/24587
5250         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5251
5252 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         PR gdb/18644:
5255         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5256         16-byte floats.
5257         * i386-tdep.c (i386_floatformat_for_type): Use
5258         floatformats_ia64_quad for the 16-byte floating point component
5259         within a fortran 32-byte complex number.
5260
5261 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5262
5263         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5264         delete default constructor.
5265         (find_partial_die): Update to return const struct.
5266         (partial_die_parent_scope): Move variable declaration into scope
5267         of its use and change its type to auto.
5268         (guess_partial_die_structure_name): Likewise.
5269         (partial_die_info::fixup): Likewise.
5270
5271 2019-05-17  Tom Tromey  <tromey@adacore.com>
5272
5273         * source.c (find_and_open_source): Remove cast.
5274
5275 2019-05-17  Tom Tromey  <tromey@adacore.com>
5276
5277         * annotate.c (annotate_source): Make "filename" const.
5278         * annotate.h (annotate_source): Use const.
5279
5280 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5281
5282         * disasm.c (set_disassembler_options): Send errors to stderr.
5283
5284 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5285
5286         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5287         (cli_interp_base::set_logging): Check debug_redirect.
5288         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5289         * cli/cli-logging.c (debug_redirect): Add static variable.
5290         (pop_output_files): Add default param.
5291         (handle_redirections): Print debug setting.
5292         (show_logging_command): Likewise.
5293         (_initialize_cli_logging): Add debugredirect command.
5294         * interps.c (current_interp_set_logging): Add debug_redirect
5295         parameter.
5296         * interps.h (set_logging): Add debug_redirect parameter.
5297         (current_interp_set_logging): Likewise.
5298         * mi/mi-common.h: Likewise.
5299         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5300
5301 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5302             Tom Tromey  <tromey@adacore.com>
5303
5304         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5305         directly.
5306         * cli/cli-interp.h (make_logging_output): Remove declaration.
5307         * cli/cli-logging.c (make_logging_output): Remove function.
5308         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5309         directly.
5310         * ui-file.c (tee_file::tee_file): Remove bools.
5311         (tee_file::~tee_file): Remove deletes.
5312         * ui-file.h (tee_file): Remove bools.
5313
5314 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5315
5316         * mi/mi-cmds.h (mi_cmd_complete): New function.
5317         * mi/mi-main.c (mi_cmd_complete): Likewise.
5318         * mi/mi-cmds.c: Define new MI command -complete.
5319         * NEWS: Mention new -complete command.
5320
5321 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5322
5323         * completer.h (complete): New function.
5324         * completer.c (complete): Likewise.
5325         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5326         function defined in completer.h.
5327
5328 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5329
5330         * MAINTAINERS (Write After Approval): Add myself.
5331
5332 2019-05-17  Tom de Vries  <tdevries@suse.de>
5333
5334         PR gdb/24094
5335         * dwarf2read.c (struct cu_partial_die_info): New struct.
5336         (find_partial_die): Return cu_partial_die_info.
5337         (partial_die_parent_scope, guess_partial_die_structure_name)
5338         (partial_die_info::fixup): Handle new return type of find_partial_die.
5339
5340 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5341
5342         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5343         "std::string", simplifying the algorithm.
5344
5345 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5346
5347         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5348         (stap_static_probe_ops::get_probes): Likewise.
5349
5350 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5351
5352         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5353         '-')" and "else if".
5354         (stap_parse_single_operand): Join checks for
5355         "gdbarch_stap_parse_special_token_p" and
5356         "gdbarch_stap_parse_special_token" in the same "if" statement.
5357         Invert check when verifying for operation on register
5358         displacement.
5359
5360 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5361
5362         * stap-probe.c (stap_get_opcode): Update comment.
5363         (stap_get_expected_argument_type): Likewise.
5364         (handle_stap_probe): Likewise.
5365
5366 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5367
5368         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5369         return type to 'bool'.  Adjust comment.  Use 'bool' when
5370         appropriate.
5371         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5372         * stap-probe.c (stap_parse_argument_1): Likewise.
5373         (stap_is_operator): Likewise.
5374         (stap_is_generic_prefix): Likewise.
5375         (stap_is_register_prefix): Likewise.
5376         (stap_is_register_indirection_prefix): Likewise.
5377         (stap_is_integer_prefix): Likewise.
5378         (stap_generic_check_suffix): Likewise.
5379         (stap_check_integer_suffix): Likewise.
5380         (stap_check_register_suffix): Likewise.
5381         (stap_check_register_indirection_suffix): Likewise.
5382         (stap_parse_register_operand): Likewise.
5383         (stap_parse_single_operand): Likewise.
5384         (stap_parse_argument_1): Likewise.
5385         (stap_probe::get_argument_count): Likewise.
5386         (stap_is_operator): Likewise.
5387
5388 2019-05-16  Tom Tromey  <tromey@adacore.com>
5389
5390         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5391         keyword to foreach.
5392
5393 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5394
5395         * linux-thread-db.c (try_thread_db_load_1): Change return type
5396         to bool.
5397         (try_thread_db_load): Likewise.
5398         (try_thread_db_load_from_pdir_1): Likewise.
5399         (try_thread_db_load_from_pdir): Likewise.
5400         (try_thread_db_load_from_sdir): Likewise.
5401         (try_thread_db_load_from_dir): Likewise.
5402         (thread_db_load_search): Likewise.
5403         (has_libpthread): Likewise.
5404         (thread_db_load): Likewise.
5405
5406 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5407
5408         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5409         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5410         NULL, and complain/return if that's the case.
5411
5412 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5413
5414         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5415         (advance, posn, abstract_read_memory): New functions.
5416         [struct mem_read_abstraction]: New struct.
5417         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5418
5419 2019-05-14  Tom Tromey  <tromey@adacore.com>
5420
5421         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5422         value is not lval_memory.
5423
5424 2019-05-14  Tom Tromey  <tromey@adacore.com>
5425
5426         * solib.c (info_sharedlibrary_command): Style the file name.
5427
5428 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5429
5430         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5431         (aarch64_vnv_type): Likewise.
5432         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5433         * common/tdesc.c: Likewise.
5434         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5435         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5436         * features/aarch64-fpu.xml: Add ieee half view.
5437         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5438         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5439         * gdbtypes.h (struct builtin_type): Likewise.
5440         (struct objfile_type): Likewise.
5441
5442 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5443
5444         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5445         typo.
5446         * location.h (string_to_event_location): Likewise.
5447
5448 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5449
5450         GDB 8.3 released.
5451
5452 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5453
5454         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5455         New variable declaration.
5456         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5457         New variable.
5458         (print_one_breakpoint): Use ui_out::test_flags and new global
5459         variable to compute use_fixed_output.
5460         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5461         Remove.
5462         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5463         (mi_multi_location_breakpoint_output_fixed): Remove.
5464         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5465         new variable.
5466         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5467         fix_multi_location_breakpoint_output flag if version >= 3.
5468         * ui-out.h (enum ui_out_flag)
5469         <fix_multi_location_breakpoint_output>: New enumerator.
5470
5471 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5472
5473         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5474
5475 2019-05-10  Tom Tromey  <tromey@adacore.com>
5476
5477         * ada-lang.c (catch_ada_completer): New function.
5478         (_initialize_ada_language): Use it.
5479
5480 2019-05-10  Tom Tromey  <tromey@adacore.com>
5481
5482         * thread.c (print_thread_info): Make "requested_threads" const.
5483         * gdbthread.h (print_thread_info): Make "requested_threads"
5484         const.
5485         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5486         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5487
5488 2019-05-08  Tom Tromey  <tom@tromey.com>
5489
5490         * gdbtypes.c (objfile_type_data): Change type.
5491         (objfile_type, _initialize_gdbtypes): Update.
5492
5493 2019-05-08  Tom Tromey  <tom@tromey.com>
5494
5495         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5496         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5497         (_initialize_dwarf2_frame): Update.
5498
5499 2019-05-08  Tom Tromey  <tom@tromey.com>
5500
5501         * objc-lang.c (objc_objfile_data): Change type.
5502         (find_methods): Update.
5503         (_initialize_objc_lang): Remove.
5504
5505 2019-05-08  Tom Tromey  <tom@tromey.com>
5506
5507         * stabsread.c (rs6000_builtin_type_data): Change type.
5508         (rs6000_builtin_type, _initialize_stabsread): Update.
5509
5510 2019-05-08  Tom Tromey  <tom@tromey.com>
5511
5512         * mips-tdep.c (mips_pdr_data): Remove.
5513         (_initialize_mips_tdep): Update.
5514
5515 2019-05-08  Tom Tromey  <tom@tromey.com>
5516
5517         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5518         (hppa_init_objfile_priv_data, read_unwind_info)
5519         (find_unwind_entry, _initialize_hppa_tdep): Update.
5520
5521 2019-05-08  Tom Tromey  <tom@tromey.com>
5522
5523         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5524         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5525         on obstack.
5526         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5527
5528 2019-05-08  Tom Tromey  <tom@tromey.com>
5529
5530         * mdebugread.c (basic_type_data): Change type.
5531         (basic_type, _initialize_mdebugread): Update.
5532
5533 2019-05-08  Tom Tromey  <tom@tromey.com>
5534
5535         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5536
5537 2019-05-08  Tom Tromey  <tom@tromey.com>
5538
5539         * nto-tdep.c (nto_inferior_data_reg): Change type.
5540         (nto_inferior_data): Update.
5541         (nto_inferior_data_cleanup, nto_new_inferior_data)
5542         (_initialize_nto_tdep): Remove.
5543         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5544
5545 2019-05-08  Tom Tromey  <tom@tromey.com>
5546
5547         * ada-lang.c (struct ada_inferior_data): Add initializers.
5548         (ada_inferior_data): Change type.
5549         (ada_inferior_data_cleanup): Remove.
5550         (get_ada_inferior_data, ada_inferior_exit)
5551         (struct ada_pspace_data): Add initializers, destructor.
5552         (ada_pspace_data_handle): Change type.
5553         (get_ada_pspace_data): Update.
5554         (ada_pspace_data_cleanup): Remove.
5555
5556 2019-05-08  Tom Tromey  <tom@tromey.com>
5557
5558         * coffread.c (struct coff_symfile_info): Add initializers.
5559         (coff_objfile_data_key): Move lower.  Change type.
5560         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5561         Update.
5562         (coff_free_info): Remove.
5563
5564 2019-05-08  Tom Tromey  <tom@tromey.com>
5565
5566         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5567         (fbsd_pspace_data_handle): Move lower.  Change type.
5568         (get_fbsd_pspace_data): Update.
5569         (fbsd_pspace_data_cleanup): Remove.
5570         (_initialize_fbsd_tdep): Update.
5571
5572 2019-05-08  Tom Tromey  <tom@tromey.com>
5573
5574         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5575         (get_ada_tasks_pspace_data): Update.
5576         (ada_tasks_pspace_data_cleanup): Remove.
5577         (_initialize_tasks): Update.
5578         (ada_tasks_inferior_data_handle): Change type.
5579         (get_ada_tasks_inferior_data): Update.
5580         (ada_tasks_inferior_data_cleanup): Remove.
5581         (struct ada_tasks_pspace_data): Add initializers.
5582
5583 2019-05-08  Tom Tromey  <tom@tromey.com>
5584
5585         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5586         * symfile-debug.c (debug_sym_get_probes): Change type.
5587         * stap-probe.c (handle_stap_probe):
5588         (stap_static_probe_ops::get_probes): Change type.
5589         * probe.h (class static_probe_ops) <get_probes>: Change type.
5590         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5591         (parse_probes_in_pspace): Update.
5592         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5593         Update.
5594         (any_static_probe_ops::get_probes): Change type.
5595         * elfread.c (elfread_data): New typedef.
5596         (probe_key): Change type.
5597         (elf_get_probes): Likewise.  Update.
5598         (probe_key_free): Remove.
5599         (_initialize_elfread): Update.
5600         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5601         Change type.
5602         (dtrace_process_dof_probe, dtrace_process_dof)
5603         (dtrace_static_probe_ops::get_probe): Change type.
5604
5605 2019-05-08  Tom Tromey  <tom@tromey.com>
5606
5607         * xcoffread.c (struct xcoff_symfile_info): Rename from
5608         coff_symfile_info.  Add initializers.
5609         (xcoff_objfile_data_key): Move lower.  Change type.
5610         (XCOFF_DATA): Rewrite.
5611         (xcoff_free_info): Remove.
5612         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5613         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5614         (xcoff_initial_scan): Update.
5615
5616 2019-05-08  Tom Tromey  <tom@tromey.com>
5617
5618         * solib-svr4.c (struct svr4_info): Add initializers and
5619         destructor.
5620         <probes_table>: Now an htab_up.
5621         (solib_svr4_pspace_data): Change type.
5622         (free_probes_table): Simplify.
5623         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5624         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5625         (probes_table_remove_objfile_probes, register_solib_event_probe)
5626         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5627         (_initialize_svr4_solib): Update.
5628
5629 2019-05-08  Tom Tromey  <tom@tromey.com>
5630
5631         * remote.c (remote_pspace_data): Change type.
5632         (remote_pspace_data_cleanup): Remove.
5633         (get_remote_exec_file, set_pspace_remote_exec_file)
5634         (_initialize_remote): Update.
5635
5636 2019-05-08  Tom Tromey  <tom@tromey.com>
5637
5638         * breakpoint.c (breakpoint_objfile_key): Change type.
5639         (get_breakpoint_objfile_data): Update.
5640         (free_breakpoint_objfile_data): Remove.
5641         (_initialize_breakpoint): Update.
5642
5643 2019-05-08  Tom Tromey  <tom@tromey.com>
5644
5645         * linux-tdep.c (struct linux_info): Add initializers.
5646         (linux_inferior_data): Move.  Change type.
5647         (invalidate_linux_cache_inf): Update.
5648         (linux_inferior_data_cleanup): Remove.
5649         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5650
5651 2019-05-08  Tom Tromey  <tom@tromey.com>
5652
5653         * auxv.c (auxv_inferior_data): Move.  Change type.
5654         (auxv_inferior_data_cleanup): Remove.
5655         (invalidate_auxv_cache_inf): Rewrite.
5656         (get_auxv_inferior_data, _initialize_auxv): Update.
5657
5658 2019-05-08  Tom Tromey  <tom@tromey.com>
5659
5660         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5661         (symfile_debug_objfile_data_key): Change type.
5662         (symfile_debug_installed, debug_qf_has_symbols)
5663         (debug_qf_find_last_source_symtab)
5664         (debug_qf_forget_cached_source_info)
5665         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5666         (debug_qf_print_stats, debug_qf_dump)
5667         (debug_qf_expand_symtabs_for_function)
5668         (debug_qf_expand_all_symtabs)
5669         (debug_qf_expand_symtabs_with_fullname)
5670         (debug_qf_map_matching_symbols)
5671         (debug_qf_expand_symtabs_matching)
5672         (debug_qf_find_pc_sect_compunit_symtab)
5673         (debug_qf_map_symbol_filenames)
5674         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5675         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5676         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5677         (debug_sym_read_linetable, debug_sym_relocate): Update.
5678         (symfile_debug_free_objfile): Remove.
5679         (install_symfile_debug_logging, _initialize_symfile_debug):
5680         Update.
5681
5682 2019-05-08  Tom Tromey  <tom@tromey.com>
5683
5684         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5685         allocate_on_obstack.
5686         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5687         (get_dwarf2_per_objfile): Update.
5688         (set_dwarf2_per_objfile): Remove.
5689         (dwarf2_has_info, dwarf2_get_section_info): Update.
5690         (dwarf2_free_objfile): Remove.
5691         (_initialize_dwarf2_read): Update.
5692
5693 2019-05-08  Tom Tromey  <tom@tromey.com>
5694
5695         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5696         initializers.
5697         <unsupported_script_warning_printed,
5698         script_not_found_warning_printed>: Now bool.
5699         (auto_load_pspace_data): Change type.
5700         (~auto_load_pspace_info): Rename from
5701         auto_load_pspace_data_cleanup.
5702         (get_auto_load_pspace_data, init_loaded_scripts_info)
5703         (clear_section_scripts, maybe_print_unsupported_script_warning)
5704         (maybe_print_script_not_found_warning, _initialize_auto_load):
5705         Update.
5706
5707 2019-05-08  Tom Tromey  <tom@tromey.com>
5708
5709         * objfiles.c (objfile_pspace_info): Add destructor and
5710         initializers.
5711         (objfiles_pspace_data): Change type.
5712         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5713         (get_objfile_pspace_data): Update.
5714         (objfiles_bfd_data): Change type.
5715         (get_objfile_bfd_data): Update.
5716         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5717
5718 2019-05-08  Tom Tromey  <tom@tromey.com>
5719
5720         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5721         Change type.
5722         (get_catch_syscall_inferior_data): Update.
5723         (catch_syscall_inferior_data_cleanup): Remove.
5724         (_initialize_break_catch_syscall): Update.
5725
5726 2019-05-08  Tom Tromey  <tom@tromey.com>
5727
5728         * inflow.c (struct terminal_info): Add destructor and
5729         initializers.
5730         (inflow_inferior_data): Change type.
5731         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5732         (get_inflow_inferior_data, inflow_inferior_exit)
5733         (swap_terminal_info, _initialize_inflow): Update.
5734
5735 2019-05-08  Tom Tromey  <tom@tromey.com>
5736
5737         * target-dcache.c (target_dcache_cleanup): Remove.
5738         (target_dcache_aspace_key): Change type.
5739         (target_dcache_init_p, target_dcache_invalidate)
5740         (target_dcache_get, target_dcache_get_or_init)
5741         (_initialize_target_dcache): Update.
5742         * dcache.h (struct dcache_deleter): New.
5743
5744 2019-05-08  Tom Tromey  <tom@tromey.com>
5745
5746         * symtab.c (struct symbol_cache): Add destructor and
5747         initializers.
5748         (symbol_cache_key): Move.  Change type.
5749         (make_symbol_cache, free_symbol_cache): Remove.
5750         (get_symbol_cache): Update.
5751         (symbol_cache_cleanup): Remove.
5752         (ALL_PSPACES, symbol_cache_flush)
5753         (maintenance_print_symbol_cache)
5754         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5755         Update.
5756
5757 2019-05-08  Tom Tromey  <tom@tromey.com>
5758
5759         * symtab.c (struct main_info): Add destructor and initializers.
5760         (main_progspace_key): Move.  Change type.
5761         (get_main_info): Update.
5762         (main_info_cleanup): Remove.
5763         (_initialize_symtab): Update.
5764
5765 2019-05-08  Tom Tromey  <tom@tromey.com>
5766
5767         * registry.h (DECLARE_REGISTRY): Define the _key class.
5768
5769 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5770
5771         * NEWS: Merge two 'New commands' sections.
5772
5773 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5774
5775         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5776         parameter and use Ada language definition instead.
5777         (ada_val_print_ptr): Remove unused language parameter.
5778         (ada_val_print_num): Remove language parameter and use Ada language
5779         definition instead.
5780         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5781         parameter.
5782         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5783         parameter and use Ada language definition instead.
5784         (ada_val_print_1): Update all ada_val_print_xxx calls.
5785         Remove language parameter.
5786         (ada_val_print): Update ada_val_print_1 call.
5787
5788 2019-05-08  Tom Tromey  <tromey@adacore.com>
5789
5790         * remote.c (remote_hw_watchpoint_limit)
5791         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5792         Now static.
5793
5794 2019-05-08  Tom Tromey  <tromey@adacore.com>
5795
5796         * maint.c (_initialize_maint_cmds): Move initialization code to
5797         remote.c.
5798         (watchdog, show_watchdog): Move to remote.c.
5799         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5800         "watchdog" static.
5801         (_initialize_remote): Move initialization code from maint.c.
5802         * defs.h (watchdog): Don't declare.
5803
5804 2019-05-08  Tom Tromey  <tromey@adacore.com>
5805
5806         * tui/tui-interp.c: Include main.h.
5807         * interps.c: Include main.h.
5808         * main.h (interpreter_p): Declare.
5809         * defs.h (interpreter_p): Don't declare.
5810
5811 2019-05-08  Tom Tromey  <tromey@adacore.com>
5812
5813         * dwarf2loc.c: Include dwarf2read.h.
5814         * defs.h (read_unsigned_leb128): Don't declare.
5815         * dwarf2read.h (read_unsigned_leb128): Declare.
5816
5817 2019-05-08  Tom Tromey  <tromey@adacore.com>
5818
5819         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5820         method.
5821
5822 2019-05-08  Tom Tromey  <tromey@adacore.com>
5823
5824         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5825         when no wrap column is set.
5826
5827 2019-05-08  Tom Tromey  <tromey@adacore.com>
5828
5829         * c-lang.c (c_get_string): Handle non-C-style arrays.
5830
5831 2019-05-08  Tom Tromey  <tromey@adacore.com>
5832
5833         * typeprint.c (print_offset_data::update): Print the bit offset,
5834         not the number of bits remaining.
5835
5836 2019-05-08  Tom Tromey  <tromey@adacore.com>
5837
5838         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5839         padding at end of comment.
5840
5841 2019-05-08  Tom Tromey  <tromey@adacore.com>
5842
5843         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5844         Compare main types.
5845
5846 2019-05-06  Tom Tromey  <tom@tromey.com>
5847
5848         * common/scoped_mmap.c: Include common-defs.h.
5849         * common/scoped_mmap.h: Don't include config.h.
5850
5851 2019-05-04  Tom Tromey  <tom@tromey.com>
5852
5853         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5854         (struct aarch64_call_info): Add initializers.
5855         <si>: Now a std::vector.
5856         (pass_on_stack, aarch64_push_dummy_call): Update.
5857
5858 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5859             Tom Tromey  <tom@tromey.com>
5860
5861         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5862         (ppc_threads): Now a std::vector.  Now static.
5863         (hwdebug_find_thread_points_by_tid)
5864         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5865         Update.
5866
5867 2019-05-04  Tom Tromey  <tom@tromey.com>
5868
5869         * arc-tdep.c (arc_tdesc_init): Return bool.
5870
5871 2019-05-04  Tom Tromey  <tom@tromey.com>
5872
5873         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5874         Use gdb_assert_not_reached.
5875
5876 2019-05-04  Tom Tromey  <tom@tromey.com>
5877
5878         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5879         "false".
5880
5881 2019-05-04  Tom Tromey  <tom@tromey.com>
5882
5883         * arc-tdep.c (arc_tdesc_init): Use bool.
5884
5885 2019-05-04  Tom Tromey  <tom@tromey.com>
5886
5887         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5888
5889 2019-05-04  Tom Tromey  <tom@tromey.com>
5890
5891         * cli/cli-cmds.c (valid_command_p): Return bool.
5892
5893 2019-05-04  Tom Tromey  <tom@tromey.com>
5894
5895         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5896         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5897
5898 2019-05-04  Raul Tambre  <raul@tambre.ee>
5899
5900         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5901         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5902         operator for comparison.
5903
5904 2019-05-04  Tom Tromey  <tom@tromey.com>
5905
5906         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5907         (lookup_partial_symbol, print_partial_symbols)
5908         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5909         (psymbol_compare): Update.
5910         (add_psymbol_to_bcache): Clear the entire psymbol.
5911         (maintenance_check_psymtabs): Update.
5912         * psympriv.h (struct partial_symbol): Don't derive from
5913         general_symbol_info.
5914         <obj_section, unrelocated_address, address,
5915         set_unrelocated_address>: Update.
5916         <ginfo>: New member.
5917         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5918         (debug_names::write_psymbols): Update.
5919
5920 2019-05-04  Tom de Vries  <tdevries@suse.de>
5921
5922         * contrib/cc-with-tweaks.sh: Support -n arg.
5923
5924 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5925
5926         * corelow.c (core_target::detach): Ensure frame cache and
5927         register caches are cleared.
5928         inferior.c (exit_inferior_1): Likewise.
5929
5930 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5931             Tom Tromey  <tom@tromey.com>
5932
5933         * dictionary.c (collate_pending_symbols_by_language): Remove
5934         "struct" from foreach.
5935         * symtab.c (lookup_global_symbol_from_objfile)
5936         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5937         foreach.
5938         * ser-tcp.c (net_open): Remove "struct" from foreach.
5939         * objfiles.c (objfile_relocate, objfile_rebase)
5940         (objfile_has_symbols): Remove "struct" from foreach.
5941         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5942         from foreach.
5943         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5944         foreach.
5945         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5946         "struct" from foreach.
5947         * ada-lang.c (create_excep_cond_exprs)
5948         (ada_exception_catchpoint_cond_string): Remove "struct" from
5949         foreach.
5950
5951 2019-05-03  Tom Tromey  <tromey@adacore.com>
5952
5953         * ada-exp.y (convert_char_literal): Check suffix of each
5954         enumerator.
5955
5956 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5957
5958         PR ada/21406:
5959         * ada-exp.y (yywrap): Don't define.
5960         * ada-lex.l (%option): Add noyywrap
5961         (yywrap): Remove.
5962
5963 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5964
5965         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5966         _WIN32_WINNT to the XP level, unless already defined to a higher
5967         level.
5968
5969         * unittests/parse-connection-spec-selftests.c:
5970         * ser-tcp.c:
5971         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5972         override.
5973
5974         * symfile.c (find_separate_debug_file): Remove colon from the
5975         drive spec of DOS/Windows file names of the target, so that the
5976         file name produced from DEBUGDIR and the target's directory will
5977         be valid on DOS/Windows systems.
5978
5979 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5980
5981         * rust-lang.c (val_print_struct): Handle printing structures
5982         containing strings.
5983
5984 2019-05-02  Tom Tromey  <tromey@adacore.com>
5985
5986         * valarith.c (_initialize_valarith): Remove.
5987
5988 2019-05-01  Tom Tromey  <tromey@adacore.com>
5989
5990         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5991         bitfields.
5992
5993 2019-05-01  Tom Tromey  <tromey@adacore.com>
5994
5995         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5996         for big-endian copies.
5997
5998 2019-04-30  Ali Tamur  <tamur@google.com>
5999         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6000         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6001         (read_3_bytes): New function.
6002
6003 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6004
6005         * windows-nat.c (main_thread_id): Delete.
6006         (handle_output_debug_string): Replace main_thread_id by
6007         current_event.dwThreadId.
6008         (fake_create_process): Likewise.
6009         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6010         Do not set main_thread_id.
6011         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6012         current_event.dwThreadId.
6013         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6014
6015 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6016
6017         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6018         Use current_event.dwThreadId instead of main_thread_id.
6019
6020 2019-04-30  Tom Tromey  <tromey@adacore.com>
6021
6022         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6023         (create_excep_cond_exprs): Iterate over program spaces.
6024         (ada_exception_catchpoint_cond_string): Examine all minimal
6025         symbols for exception types.
6026
6027 2019-04-30  Tom Tromey  <tromey@adacore.com>
6028
6029         PR c++/24470:
6030         * dwarf2read.c (process_structure_scope): Handle case where type
6031         has template parameters but no symbol was created.
6032
6033 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6034             Chris January  <chris.january@arm.com>
6035
6036         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6037         qualifier.
6038         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6039
6040 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6041
6042         * f-typeprint.c (f_print_type): Update rules for printing
6043         whitespace.
6044         (f_type_print_varspec_suffix): Likewise.
6045
6046 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6047             Chris January  <chris.january@arm.com>
6048
6049         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6050         function arguments.
6051
6052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6053
6054         * f-lang.c (build_fortran_types): Change name of void type to
6055         lower case.
6056         * f-typeprint.c (f_type_print_base): Print the name of the void
6057         type, rather than a fixed string.
6058         * f-valprint.c (f_decorations): Use lower case void string.
6059
6060 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6061             Chris January  <chris.january@arm.com>
6062
6063         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6064         types for Fortran.
6065
6066 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6067             Chris January  <chris.january@arm.com>
6068             David Lecomber  <david.lecomber@arm.com>
6069
6070         * f-exp.y (BINOP_INTRINSIC): New token.
6071         (exp): New parser rule handling BINOP_INTRINSIC.
6072         (f77_keywords): Add new builtin procedures.
6073         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6074         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6075         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6076         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6077         (print_unop_subexp_f): New function.
6078         (print_binop_subexp_f): New function.
6079         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6080         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6081         (dump_subexp_body_f): Likewise.
6082         (operator_check_f): Likewise.
6083         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6084         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6085
6086 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6089         UNOP_KIND.
6090         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6091         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6092         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6093         (operator_length_f): New fuction.
6094         (print_subexp_f): New function.
6095         (op_name_f): New function.
6096         (dump_subexp_body_f): New function.
6097         (operator_check_f): New function.
6098         (exp_descriptor_f): Replace standard expression handling functions
6099         with new functions.
6100         * gdb/fortran-operator.def: New file.
6101         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6102         * gdb/std-operator.def: Remove UNOP_KIND.
6103
6104 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6105
6106         * std-operator.def: Remove unbalanced, stray double quote
6107         character.
6108
6109 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6110             Chris January  <chris.january@arm.com>
6111             Daniel Everett  <daniel.everett@arm.com>
6112             Nick Forrington  <nick.forrington@arm.com>
6113             Richard Bunt  <richard.bunt@arm.com>
6114
6115         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6116         of depth when printing anonymous structs or unions.
6117         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6118         Don't print either the top-level value, or the children if the
6119         max-depth is exceeded.
6120         (ppscm_print_children): When printing the key of a map, allow one
6121         extra level of depth.
6122         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6123         print either the top-level value, or the children if the max-depth
6124         is exceeded.
6125         (print_children): When printing the key of a map, allow one extra
6126         level of depth.
6127         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6128         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6129         (user_print_options): Initialise max_depth field.
6130         (val_print_scalar_or_string_type_p): New function.
6131         (val_print): Check to see if the max depth has been reached.
6132         (val_print_check_max_depth): Define new function.
6133         (show_print_max_depth): New function.
6134         (_initialize_valprint): Add 'print max-depth' option.
6135         * valprint.h (struct value_print_options) <max_depth>: New field.
6136         (val_print_check_max_depth): Declare new function.
6137         * NEWS: Document new feature.
6138
6139 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * ada-lang.c (ada_language_defn): Initialise new field.
6142         * c-lang.c (c_is_string_type_p): New function.
6143         (c_language_defn): Initialise new field.
6144         (cplus_language_defn): Initialise new field.
6145         (asm_language_defn): Initialise new field.
6146         (minimal_language_defn): Initialise new field.
6147         * c-lang.h (c_is_string_type_p): Declare new function.
6148         * d-lang.c (d_language_defn): Initialise new field.
6149         * f-lang.c (f_is_string_type_p): New function.
6150         (f_language_defn): Initialise new field.
6151         * go-lang.c (go_is_string_type_p): New function.
6152         (go_language_defn): Initialise new field.
6153         * language.c (default_is_string_type_p): New function.
6154         (unknown_language_defn): Initialise new field.
6155         (auto_language_defn): Initialise new field.
6156         * language.h (struct language_defn) <la_is_string_type_p>: New
6157         member variable.
6158         (default_is_string_type_p): Declare new function.
6159         * m2-lang.c (m2_language_defn): Initialise new field.
6160         * objc-lang.c (objc_language_defn): Initialise new field.
6161         * opencl-lang.c (opencl_language_defn): Initialise new field.
6162         * p-lang.c (pascal_is_string_type_p): New function.
6163         (pascal_language_defn): Initialise new field.
6164         * rust-lang.c (rust_is_string_type_p): New function.
6165         (rust_language_defn): Initialise new field.
6166
6167 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6170         New field.
6171         * ada-lang.c (ada_language_defn): Initialise new field.
6172         * c-lang.c (c_language_defn): Likewise.
6173         (cplus_language_defn): Likewise.
6174         (asm_language_defn): Likewise.
6175         (minimal_language_defn): Likewise.
6176         * d-lang.c (d_language_defn): Likewise.
6177         * f-lang.c (f_language_defn): Likewise.
6178         * go-lang.c (go_language_defn): Likewise.
6179         * language.c (unknown_language_defn): Likewise.
6180         (auto_language_defn): Likewise.
6181         * m2-lang.c (m2_language_defn): Likewise.
6182         * objc-lang.c (objc_language_defn): Likewise.
6183         * opencl-lang.c (opencl_language_defn): Likewise.
6184         * p-lang.c (pascal_language_defn): Likewise.
6185         * rust-lang.c (rust_language_defn): Likewise.
6186
6187 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * ada-lang.c (ada_is_character_type): Change return type to bool.
6190         (ada_is_string_type): Likewise.
6191         * ada-lang.h (ada_is_character_type): Update declaration
6192         (ada_is_string_type): Likewise.
6193
6194 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6195
6196         Support style in 'frame|thread apply'
6197
6198         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6199         * record.c (record_start, record_stop): Update callers of
6200         execute_command_to_string with false.
6201         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6202         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6203         methods.
6204         (class string_file): New constructor with term_out parameter.
6205         Override methods term_out and can_emit_style_escape.  New member
6206         term_out.
6207         (class stdio_file): Override can_emit_style_escape.
6208         (class tee_file): Override term_out and can_emit_style_escape.
6209         * utils.h (can_emit_style_escape): Remove.
6210         * utils.c (can_emit_style_escape): Likewise.
6211         Update all callers of can_emit_style_escape (SOMESTREAM) to
6212         SOMESTREAM->can_emit_style_escape.
6213         * source-cache.c (source_cache::get_source_lines): Likewise.
6214         * stack.c (frame_apply_command_count): Call execute_command_to_string
6215         passing the term_out characteristic of the current gdb_stdout.
6216         * thread.c (thr_try_catch_cmd): Likewise.
6217         * top.c (execute_command_to_string): pass term_out parameter
6218         to construct the string_file for the command output.
6219         * ui-file.c (term_cli_styling): New function (most code moved
6220         from utils.c can_emit_style_escape).
6221         (string_file::string_file, string_file::can_emit_style_escape,
6222         stdio_file::can_emit_style_escape, tee_file::term_out,
6223         tee_file::can_emit_style_escape): New functions.
6224
6225 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6226
6227         * NEWS: Mention the new set|show may-call-functions.
6228         * infcall.c (may_call_functions_p): New variable.
6229         (show_may_call_functions_p): New function.
6230         (call_function_by_hand_dummy): Throws an error if not
6231         may-call-functions.
6232         (_initialize_infcall): Call add_setshow_boolean_cmd for
6233         may-call-functions.
6234
6235 2019-04-25  Keith Seitz  <keiths@redhat.com>
6236
6237         PR c++/24367
6238         * cp-support.c (inspect_type): Don't attempt substitutions
6239         of symbol with the same name.
6240
6241 2019-04-25  Tom Tromey  <tromey@adacore.com>
6242
6243         PR gdb/24475:
6244         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6245         static.
6246
6247 2019-04-25  Tom Tromey  <tromey@adacore.com>
6248
6249         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6250         rvalue reference.
6251         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6252         (gdb_xml_parser::parse): Use std::move.
6253         * python/python-internal.h (gdbpy_convert_exception): Take a const
6254         reference.
6255         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6256         std::move.
6257         * python/py-utils.c (gdbpy_convert_exception): Take a const
6258         reference.
6259         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6260         Use std::move.
6261         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6262         Use std::move.
6263         * mi/mi-main.c (mi_print_exception): Take a const reference.
6264         * main.c (handle_command_errors): Take a const reference.
6265         * linespec.c (parse_linespec): Use std::move.
6266         * infcall.c (run_inferior_call): Use std::move.
6267         (call_function_by_hand_dummy): Use std::move.
6268         * exec.c (try_open_exec_file): Use std::move.
6269         * exceptions.h (exception_print, exception_fprintf)
6270         (exception_print_same): Update.
6271         * exceptions.c (print_exception, exception_print)
6272         (exception_fprintf, exception_print_same): Change parameters to
6273         const reference.
6274         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6275         * common/new-op.c: Use std::move.
6276         * common/common-exceptions.h (struct gdb_exception): Add move
6277         constructor.
6278         (struct gdb_exception_error, struct gdb_exception_quit, struct
6279         gdb_quit_bad_alloc): Change constructor to move constructor.
6280         (throw_exception): Change parameter to rvalue reference.
6281         * common/common-exceptions.c (throw_exception): Take rvalue
6282         reference.
6283         * cli/cli-interp.c (safe_execute_command): Use std::move.
6284         * breakpoint.c (insert_bp_location, location_to_sals): Use
6285         std::move.
6286
6287 2019-04-25  Tom Tromey  <tromey@adacore.com>
6288
6289         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6290         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6291         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6292         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6293         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6294         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6295         guile/scm-value.c: Use unpack.
6296         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6297         gdbscm_gdb_exception.
6298         (gdbscm_throw_gdb_exception): Likewise.
6299         (struct gdbscm_gdb_exception): New.
6300         (unpack): New function.
6301         (gdbscm_wrap): Use unpack.
6302
6303 2019-04-25  Tom Tromey  <tromey@adacore.com>
6304
6305         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6306         (gdb_rl_callback_handler): Use std::move.
6307         * common/common-exceptions.h (struct gdb_exception): Add move
6308         assignment operator.
6309         (throw_exception_sjlj): Change "exception" to const reference.
6310         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6311         (throw_exception_sjlj): Change "exception" to const reference.
6312
6313 2019-04-25  Tom Tromey  <tromey@adacore.com>
6314
6315         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6316         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6317         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6318         Update.
6319         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6320         Update.
6321         * mi/mi-interp.c (mi_interp::exec): Update.
6322         * linespec.c (parse_linespec): Update.
6323         * infcall.c (run_inferior_call): Update.
6324         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6325         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6326         (gdbscm_lookup_global_symbol): Update.
6327         * guile/scm-param.c (gdbscm_parameter_value): Update.
6328         * guile/scm-frame.c (gdbscm_frame_read_register)
6329         (gdbscm_frame_read_var): Update.
6330         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6331         * exec.c (try_open_exec_file): Update.
6332         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6333         (gdb_rl_callback_handler): Update.
6334         * common/common-exceptions.h (exception_none): Don't declare.
6335         * common/common-exceptions.c (exception_none): Don't define.
6336         (struct catcher) <exception>: Update.
6337         * cli/cli-interp.c (safe_execute_command): Update.
6338         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6339
6340 2019-04-25  Ali Tamur  <tamur@google.com>
6341
6342         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6343         (read_attribute_value): Likewise.
6344         (dwarf2_read_addr_index): Update comment.
6345         (read_str_index): Add DW_FORM_strx.
6346         (dwarf2_string_attr): Likewise.
6347         (dwarf2_const_value_attr): Likewise.
6348         (dump_die_shallow): Likewise.
6349         (dwarf2_fetch_constant_bytes): Likewise.
6350         (skip_form_bytes): Likewise.
6351         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6352
6353 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6354
6355         PR corefiles/11608
6356         PR corefiles/18187
6357         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6358         OFFSET.  Verify if current mapping contains an ELF header.
6359         (linux_find_memory_regions_full): Adjust call to
6360         dump_mapping_p.
6361
6362 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6363             Kang Li <kanglictf@gmail.com>
6364
6365         PR gdb/21600
6366
6367         * dwarf2-frame.c (read_initial_length): Be consistent about using
6368         unsigned representation of length.
6369         (decode_frame_entry_1): Likewise.  Check for wraparound of
6370         end pointer as well as buffer overflow.
6371
6372 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6373
6374         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6375         "vq".
6376
6377 2019-04-24  Tom Tromey  <tromey@adacore.com>
6378
6379         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6380
6381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6382
6383         * s12z-tdep.c (s12z_unwind_pc): Delete.
6384         (s12z_unwind_sp): Delete.
6385         (s12z_gdbarch_init): Don't register deleted functions with
6386         gdbarch.
6387
6388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * rl78-tdep.c (rl78_unwind_sp): Delete.
6391         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6392
6393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6394
6395         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6396         (xstormy16_unwind_pc): Delete.
6397         (xstormy16_dummy_id): Delete.
6398         (xstormy16_gdbarch_init): Don't register deleted functions with
6399         gdbarch.
6400
6401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * vax-tdep.c (vax_unwind_pc): Delete.
6404         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6405
6406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * v850-tdep.c (v850_unwind_sp): Delete.
6409         (v850_unwind_pc): Delete.
6410         (v850_dummy_id): Delete.
6411         (v850_gdbarch_init): Don't register deleted functions with
6412         gdbarch.
6413
6414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6417         (tilegx_unwind_pc): Delete.
6418         (tilegx_unwind_dummy_id): Delete.
6419         (tilegx_gdbarch_init): Don't register deleted functions with
6420         gdbarch.
6421
6422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6425         (tic6x_dummy_id): Delete.
6426         (tic6x_gdbarch_init): Don't register deleted functions with
6427         gdbarch.
6428
6429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * sparc-tdep.c (sparc_unwind_pc): Delete.
6432         (sparc32_gdbarch_init): Don't register deleted function with
6433         gdbarch.
6434
6435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6436
6437         * sh-tdep.c (sh_unwind_sp): Delete.
6438         (sh_unwind_pc): Delete.
6439         (sh_dummy_id): Delete.
6440         (sh_gdbarch_init): Don't register deleted functions with
6441         gdbarch.
6442
6443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * score-tdep.c (score_unwind_sp): Delete.
6446         (score_unwind_pc): Delete.
6447         (score_dummy_id): Delete.
6448         (score_gdbarch_init): Don't register deleted functions with
6449         gdbarch.
6450
6451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * rx-tdep.c (rx_unwind_pc): Delete.
6454         (rx_unwind_sp): Delete.
6455         (rx_dummy_id): Delete.
6456         (rx_gdbarch_init): Don't register deleted functions with
6457         gdbarch.  Update comment.
6458
6459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6462         (rs6000_dummy_id): Delete.
6463         (rs6000_gdbarch_init): Don't register deleted functions with
6464         gdbarch.
6465
6466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6467
6468         * or1k-tdep.c (or1k_dummy_id): Delete.
6469         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6470
6471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * nios2-tdep.c (nios2_dummy_id): Delete.
6474         (nios2_unwind_sp): Delete.
6475         (nios2_gdbarch_init): Don't register deleted functions with
6476         gdbarch.
6477
6478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6479
6480         * nds32-tdep.c (nds32_dummy_id): Delete.
6481         (nds32_unwind_pc): Delete.
6482         (nds32_unwind_sp): Delete.
6483         (nds32_gdbarch_init): Don't register deleted functions with
6484         gdbarch.
6485
6486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6487
6488         * msp430-tdep.c (msp430_unwind_pc): Delete.
6489         (msp430_unwind_sp): Delete.
6490         (msp430_dummy_id): Delete.
6491         (msp430_gdbarch_init): Don't register deleted functions with
6492         gdbarch.
6493
6494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * moxie-tdep.c (moxie_unwind_sp): Delete.
6497         (moxie_unwind_pc): Delete.
6498         (moxie_dummy_id): Delete.
6499         (moxie_gdbarch_init): Don't register deleted functions with
6500         gdbarch.
6501
6502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6503
6504         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6505         (mn10300_unwind_pc): Delete.
6506         (mn10300_unwind_sp): Delete.
6507         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6508         mn10300_unwind_sp.
6509         (mn10300_frame_unwind_init): Don't register deleted functions with
6510         gdbarch.
6511
6512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6513
6514         * mep-tdep.c (mep_unwind_pc): Delete.
6515         (mep_unwind_sp): Delete.
6516         (mep_dummy_id): Delete.
6517         (mep_gdbarch_init): Don't register deleted functions with
6518         gdbarch.
6519
6520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6523         (m68hc11_unwind_sp): Delete.
6524         (m68hc11_gdbarch_init): Don't register deleted functions with
6525         gdbarch.
6526
6527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6528
6529         * m32r-tdep.c (m32r_unwind_sp): Delete.
6530         (m32r_unwind_pc): Delete.
6531         (m32r_dummy_id): Delete.
6532         (m32r_gdbarch_init): Don't register deleted functions with
6533         gdbarch.
6534
6535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6536
6537         * m32c-tdep.c (m32c_unwind_pc): Delete.
6538         (m32c_unwind_sp): Delete.
6539         (m32c_dummy_id): Delete.
6540         (m32c_gdbarch_init): Don't register deleted functions with
6541         gdbarch.
6542
6543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6546         (lm32_unwind_pc): Delete.
6547         (lm32_dummy_id): Delete.
6548         (lm32_gdbarch_init): Don't register deleted functions with
6549         gdbarch.
6550
6551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6552
6553         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6554         (iq2000_unwind_pc): Delete.
6555         (iq2000_dummy_id): Delete.
6556         (iq2000_gdbarch_init): Don't register deleted functions with
6557         gdbarch.
6558
6559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6560
6561         * nds32-tdep.c (nds32_type_align): Delete.
6562         (nds32_push_dummy_call): Use type_align instead.
6563
6564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * arm-tdep.c (arm_type_align): Only handle vector override case.
6567         (arm_push_dummy_call): Use type_align.
6568         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6569
6570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6571
6572         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6573         case.
6574         (pass_on_stack): Use type_align.
6575         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6576         function.
6577
6578 2019-04-23  Tom Tromey  <tromey@adacore.com>
6579
6580         * dwarf2read.c (line_header::file_name_at): Remove unused
6581         overload.
6582
6583 2019-04-23  Tom de Vries  <tdevries@suse.de>
6584
6585         PR gdb/24438
6586         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6587         invocation.
6588
6589
6590 2019-03-27  Ali Tamur  <tamur@google.com>
6591
6592         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6593         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6594         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6595         (dwarf_expr_context::get_addr_index): Likewise
6596         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6597         (symbol_needs_eval_context::get_addr_index): Likewise
6598         (disassemble_dwarf_expression): Add DW_OP_addrx
6599         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6600         (read_cutu_die_from_dwo): Update comment
6601         (skip_one_die): Add DW_FORM_addrx
6602         (read_attribute_value): Likewise
6603         (var_decode_location): Add DW_OP_addrx
6604         (dwarf2_const_value_attr): Add DW_FORM_addrx
6605         (dump_die_shallow): Likewise
6606         (dwarf2_fetch_constant_bytes): Likewise
6607         (decode_locdesc): Add DW_OP_addrx
6608         (skip_form_bytes): Add DW_FORM_addrx
6609
6610 2019-04-22  Ali Tamur  <tamur@google.com>
6611
6612         * MAINTAINERS (Write After Approval): Add self.
6613
6614 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6615
6616         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6617         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6618         (open_symbol_file_object): Likewise.
6619         (svr4_default_sos): Add info parameter.
6620         (svr4_read_so_list): Likewise.
6621         (svr4_current_sos_direct): Adjust functions calls to pass down
6622         info.
6623         (svr4_current_sos_1): Add info parameter.
6624         (svr4_current_sos): Call get_svr4_info, pass info down to
6625         svr4_current_sos_1.
6626         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6627         get_svr4_info.
6628         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6629         get_svr4_info.
6630         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6631         to get_svr4_info.
6632         (probes_table_remove_objfile_probes): Likewise.
6633         (register_solib_event_probe): Add info parameter.
6634         (solist_update_incremental): Pass info parameter down to
6635         svr4_read_so_list.
6636         (disable_probes_interface): Add info parameter.
6637         (svr4_handle_solib_event): Pass current_program_space to
6638         get_svr4_info.  Adjust disable_probes_interface cleanup.
6639         (svr4_create_probe_breakpoints): Add info parameter, pass it
6640         down to register_solib_event_probe.
6641         (svr4_create_solib_event_breakpoints): Add info parameter,
6642         pass it down to svr4_create_probe_breakpoints.
6643         (enable_break): Pass info down to
6644         svr4_create_solib_event_breakpoints.
6645         (svr4_solib_create_inferior_hook): Pass current_program_space to
6646         get_svr4_info.
6647         (svr4_clear_solib): Likewise.
6648
6649 2019-04-22  Pedro Alves  <palves@redhat.com>
6650
6651         * solib-svr4.c (svr4_free_objfile_observer): New.
6652         (probe_and_action::objfile): New field.
6653         (probes_table_htab_remove_objfile_probes)
6654         (probes_table_remove_objfile_probes): New functions.
6655         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6656         in the new probe_and_action.  Don't store the probe in 'lookup'.
6657         (svr4_create_probe_breakpoints): Pass objfile to
6658         register_solib_event_probe.
6659         (_initialize_svr4_solib): Register a free_objfile observer.
6660
6661 2019-04-19  Tom Tromey  <tom@tromey.com>
6662
6663         * common/queue.h: Remove.
6664
6665 2019-04-19  Tom Tromey  <tom@tromey.com>
6666
6667         * event-loop.c: Don't include "common/queue.h".
6668
6669 2019-04-19  Tom Tromey  <tom@tromey.com>
6670
6671         * remote.c (remote_target): Use delete.
6672         * remote-notif.h: Include <list>, not "common/queue.h".
6673         (notif_client_p): Remove typedef.
6674         (remote_notif_state): Add constructor, destructor, initializer.
6675         <notif_queue>: Now a std::list.
6676         (remote_notif_state_xfree): Don't declare.
6677         * remote-notif.c (remote_notif_process, handle_notification)
6678         (remote_notif_state_allocate): Update.
6679         (~remote_notif_state): Rename from remote_notif_state_xfree.
6680
6681 2019-04-19  Tom Tromey  <tom@tromey.com>
6682
6683         * symfile.c (reread_symbols): Update.
6684         * objfiles.c (objfile_register_static_link)
6685         (objfile_lookup_static_link): Update
6686         (~objfile) Don't delete static_links.
6687         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6688
6689 2019-04-19  Tom Tromey  <tom@tromey.com>
6690
6691         * type-stack.h (struct type_stack) <insert>: Constify string.
6692         * type-stack.c (type_stack::insert): Constify string.
6693         * gdbtypes.h (lookup_template_type): Update.
6694         (address_space_name_to_int): Update.
6695         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6696         const.
6697         (lookup_template_type): Make name const.
6698         * c-exp.y: Update rules.
6699         (lex_one_token, classify_name, classify_inner_name)
6700         (c_print_token): Update.
6701         * p-exp.y: Update rules.
6702         (yylex): Update.
6703         * f-exp.y: Update rules.
6704         (yylex): Update.
6705         * d-exp.y: Update rules.
6706         (lex_one_token, classify_name, classify_inner_name): Update.
6707         * parse.c (write_dollar_variable, copy_name): Return std::string.
6708         * parser-defs.h (copy_name): Change return type.
6709         * m2-exp.y: Update rules.
6710         (yylex): Update.
6711         * go-exp.y (lex_one_token): Update.
6712         Update rules.
6713         (classify_unsafe_function, classify_packaged_name)
6714         (classify_name, yylex): Update.
6715
6716 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6717
6718         * configure.ac: add --enable-source-highlight switch.
6719         * configure: Regenerate.
6720         * top.c (print_gdb_version): plumb --enable-source-highlight
6721         status to "show configuration".
6722
6723 2019-04-19  Tom Tromey  <tromey@adacore.com>
6724
6725         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6726         Check ADA_TYPE_P.
6727         (empty_record, ada_template_to_fixed_record_type_1)
6728         (template_to_static_fixed_type)
6729         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6730         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6731         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6732         macros.
6733
6734 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6735
6736         PR symtab/24423:
6737         * source.c (print_source_lines_base): Advance "iter" when a
6738         control character is seen.
6739
6740 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6741
6742         * inferior.h (struct infcall_suspend_state_deleter):
6743         Catch exception in destructor to avoid crash.
6744
6745 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6746
6747         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6748         close to the add_com "shell".
6749
6750 2019-04-18  Tom Tromey  <tromey@adacore.com>
6751
6752         * process-stratum-target.h (class process_stratum_target)
6753         <stratum>: Add "final".
6754
6755 2019-04-17  Tom Tromey  <tromey@adacore.com>
6756
6757         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6758         against nullptr before use.
6759
6760 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6761
6762         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6763
6764 2019-04-17  Jim Wilson  <jimw@sifive.com>
6765             Andrew Burgess  <andrew.burgess@embecosm.com>
6766
6767         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6768         code read might fail, assume 4-byte breakpoint in that case.
6769
6770 2019-04-15  Leszek Swirski  <leszeks@google.com>
6771
6772         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6773         rather than a hand-rolled POD check when checking for forced MEMORY
6774         classification.
6775
6776 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6777
6778         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6779         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6780         function.
6781         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6782         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6783         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6784         declaration.
6785
6786 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6787
6788         * aarch64-linux-nat.c
6789         (aarch64_linux_nat_target::thread_architecture): Add override.
6790         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6791         each VQ.
6792
6793 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6794
6795         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6796
6797 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6798
6799         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6800         target types of size 96-bits, add some additional comments, and
6801         check that the builtin type we found was the correct size.
6802
6803 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6804
6805         * utils.c (prompt_for_continue): Don't restore the styling at the
6806         end, as applied_style has the wrong value.  This fixes styling in
6807         long lists of file names that are interrupted by the "Continue?"
6808         prompt.
6809
6810 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6811
6812         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6813         * c-lang.c (c_language_defn): Likewise.
6814         (cplus_language_defn): Likewise.
6815         (asm_language_defn): Likewise.
6816         (minimal_language_defn): Likewise.
6817         * d-lang.c (d_language_defn): Likewise.
6818         * f-lang.c (f_language_defn): Likewise.
6819         * go-lang.c (go_language_defn): Likewise.
6820         * language.c (unknown_language_defn): Likewise.
6821         (auto_language_defn): Likewise.
6822         * language.h (struct language_defn): Remove la_magic field.
6823         (LANG_MAGIC): Delete.
6824         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6825         * objc-lang.c (objc_language_defn): Likewise.
6826         * opencl-lang.c (opencl_language_defn): Likewise.
6827         * p-lang.c (pascal_language_defn): Likewise.
6828         * rust-lang.c (rust_language_defn): Likewise.
6829
6830 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6831
6832         * riscv-tdep.c (riscv_type_align): New function.
6833         (riscv_type_alignment): Delete.
6834         (riscv_arg_location): Use 'type_align'.
6835         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6836
6837 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6838
6839         * gdbtypes.c (type_align): A struct with no non-static fields also
6840         has alignment of 1.
6841
6842 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6845         component to 0.
6846         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6847         member.
6848         (riscv_struct_info::analyse): New implementation using new
6849         analyse_inner member function.
6850         (riscv_struct_info::field_offset): New member function.
6851         (riscv_struct_info::m_offsets): New member variable.
6852         (riscv_struct_info::analyse_inner): New private member function,
6853         takes the old implementation of riscv_struct_info::analyse but
6854         extended to track field offsets.
6855         (riscv_call_arg_struct): Update the struct folding special cases
6856         to handle cases where empty C++ structs, which are non-zero
6857         length, are found.
6858         (riscv_arg_location): Initialise the length of each location, a
6859         non-zero length now indicates the location is in use.
6860         (riscv_push_dummy_call): Allow for the first location having a
6861         non-zero offset when setting up arguments.
6862         (riscv_return_value): Likewise, but for return values.
6863
6864 2019-04-11  Tom Tromey  <tromey@adacore.com>
6865
6866         * utils.c (internal_vproblem): Make "msg" const.
6867
6868 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6869
6870         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6871         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6872         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6873         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6874
6875 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6876
6877         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6878         function.
6879         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6880         of amd64_collect_native_gregset.
6881         (amd64_linux_nat_target::store_registers): Likewise.
6882
6883 2019-04-10  Tom Tromey  <tom@tromey.com>
6884
6885         * symtab.c (lookup_global_symbol_from_objfile)
6886         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6887         * objfiles.h (class separate_debug_iterator): New.
6888         (class separate_debug_range): New.
6889         (struct objfile) <separate_debug_objfiles>: New method.
6890         (objfile_separate_debug_iterate): Don't declare.
6891         * objfiles.c (separate_debug_iterator::operator++): Rename from
6892         objfile_separate_debug_iterate.
6893         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6894         iterator.
6895         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6896         iterator.
6897
6898 2019-04-10  Tom Tromey  <tom@tromey.com>
6899
6900         * symfile.c (reread_symbols): Remove old comment.
6901         * objfiles.c (free_all_objfiles): Fix a typo.
6902
6903 2019-04-10  Tom Tromey  <tom@tromey.com>
6904
6905         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6906         * minsyms.c (lookup_minimal_symbol): Use foreach.
6907         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6908         (lookup_minimal_symbol_solib_trampoline): Likewise.
6909         * symfile.c (reread_symbols): Use foreach.
6910
6911 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6912             Tom Tromey  <tromey@adacore.com>
6913
6914         PR rust/24414:
6915         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6916         (rust_lex_int_test): Change "value" to be LONGEST.
6917         (rust_lex_tests): Add test for long integer literal.
6918
6919 2019-04-09  Tom Tromey  <tromey@adacore.com>
6920
6921         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6922         to bool.
6923         (extended_remote_target::attach): Update.
6924         (remote_target::remote_notice_new_inferior): Update.
6925         (remote_target::add_current_inferior_and_thread): Update.
6926         * inferior.c (exit_inferior_1): Use "false".
6927         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6928
6929 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6930
6931         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6932         the "start" command.
6933
6934 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6935
6936         * python/py-inferior.c (infpy_thread_from_thread_handle):
6937         Adjust comments to reflect renaming of thread_from_thread_handle
6938         to thread_from_handle.  Adjust keywords.  Fix type error message.
6939         (inferior_object_methods): Add thread_from_handle.  Retain
6940         thread_from_thread_handle, but mark it as deprecated.
6941
6942 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6943
6944         * gdbthread.h (find_thread_by_handle): Revise declaration.
6945         * thread.c (find_thread_by_handle): Likewise.  Adjust
6946         implementation too.
6947         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6948         support for buffer objects as handles.
6949
6950 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6951
6952         * python/py-infthread.c (thpy_thread_handle): New function.
6953         (thread_object_methods): Register thpy_thread_handle.
6954
6955 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6956
6957         * gdbthread.h (thread_to_thread_handle): Declare.
6958         * thread.c (gdbtypes.h): Include.
6959         (thread_to_thread_handle): New function.
6960
6961         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6962         (target_thread_info_to_thread_handle): Declare.
6963         * target.c (target_thread_info_to_thread_handle): New function.
6964         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6965         * target-delegates.c: Regenerate.
6966
6967         * linux-thread-db.c (class thread_db_target): Add method
6968         thread_info_to_thread_handle.
6969         (thread_db_target::thread_info_to_thread_handle): Define.
6970         * remote.c (class remote_target): Add new method
6971         thread_info_to_thread_handle.
6972         (remote_target::thread_info_to_thread_handle): Define.
6973
6974 2019-04-08  Pedro Alves  <palves@redhat.com>
6975
6976         * common/common-exceptions.c (throw_exception): Don't create
6977         named object to throw; throw directly.
6978         (throw_it): Likewise.  Don't initialize gdb_exception::message
6979         here, with new; pass FMT and AP to the ctor instead.
6980         * common/common-exceptions.h: Include <string>.
6981         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6982         const char *, va_list)): New ctor.  Use std::make_shared.
6983         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6984         errors)): Delete.
6985         (gdb_exception_error::gdb_exception_error(enum errors, const char
6986         *, va_list)): New.
6987         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6988         Add assertion.
6989         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6990         errors)): Delete.
6991         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6992         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6993         Add assertion.
6994
6995 2019-04-08  Tom Tromey  <tom@tromey.com>
6996
6997         * valops.c (value_rtti_indirect_type): Replace throw_exception
6998         with throw.
6999         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7000         with throw.
7001         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7002         throw.
7003         * target.c (target_translate_tls_address): Replace throw_exception
7004         with throw.
7005         * stack.c (frame_apply_command_count): Replace throw_exception
7006         with throw.
7007         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7008         throw.
7009         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7010         with throw.
7011         * rs6000-tdep.c (rs6000_frame_cache)
7012         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7013         * remote.c: Replace throw_exception with throw.
7014         * record-full.c (record_full_message, record_full_wait_1)
7015         (record_full_restore): Replace throw_exception with throw.
7016         * record-btrace.c:
7017         (get_thread_current_frame_id, record_btrace_start_replaying)
7018         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7019         (cmd_record_btrace_start): Replace throw_exception with throw.
7020         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7021         throw.
7022         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7023         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7024         * linespec.c:
7025         (find_linespec_symbols): Replace throw_exception with throw.
7026         * infrun.c (displaced_step_prepare, resume): Replace
7027         throw_exception with throw.
7028         * infcmd.c (post_create_inferior): Replace throw_exception with
7029         throw.
7030         * inf-loop.c (inferior_event_handler): Replace throw_exception
7031         with throw.
7032         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7033         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7034         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7035         (get_prev_frame_always, get_frame_pc_if_available)
7036         (get_frame_address_in_block_if_available, get_frame_language):
7037         Replace throw_exception with throw.
7038         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7039         throw_exception with throw.
7040         * eval.c (fetch_subexp_value, evaluate_var_value)
7041         (evaluate_funcall, evaluate_subexp_standard): Replace
7042         throw_exception with throw.
7043         * dwarf2loc.c (call_site_find_chain)
7044         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7045         Replace throw_exception with throw.
7046         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7047         with throw.
7048         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7049         throw.
7050         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7051         * completer.c (complete_line_internal): Replace throw_exception
7052         with throw.
7053         * compile/compile-object-run.c (compile_object_run): Replace
7054         throw_exception with throw.
7055         * cli/cli-script.c (process_next_line): Replace throw_exception
7056         with throw.
7057         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7058         (btrace_enable, btrace_maint_update_pt_packets): Replace
7059         throw_exception with throw.
7060         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7061         throw_exception with throw.
7062         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7063         throw_exception with throw.
7064         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7065         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7066         * aarch64-tdep.c (aarch64_make_prologue_cache)
7067         (aarch64_make_stub_cache): Replace throw_exception with throw.
7068
7069 2019-04-08  Tom Tromey  <tom@tromey.com>
7070
7071         * common/common-exceptions.c (throw_exception): Rename from
7072         throw_exception_cxx.  Remove old copy.  Make argument const.
7073         (throw_it): Create and throw exception objects directly.
7074         * common/common-exceptions.h (throw_exception): Make argument
7075         const.
7076         (struct gdb_exception_error): Add constructor.
7077         (struct gdb_exception_quit): Add constructor.
7078
7079 2019-04-08  Tom Tromey  <tom@tromey.com>
7080
7081         * common/common-exceptions.h (exception_rethrow): Don't declare.
7082         (TRY_SJLJ): Update comment.
7083         (TRY, CATCH, END_CATCH): Remove.
7084         * common/common-exceptions.c (exception_rethrow): Remove.
7085
7086 2019-04-08  Tom Tromey  <tom@tromey.com>
7087
7088         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7089         Remove.
7090         (gdb_exception_error): Rename from
7091         gdb_exception_RETURN_MASK_ERROR.
7092         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7093         (gdb_quit_bad_alloc): Update.
7094         * aarch64-tdep.c: Update.
7095         * ada-lang.c: Update.
7096         * ada-typeprint.c: Update.
7097         * ada-valprint.c: Update.
7098         * amd64-tdep.c: Update.
7099         * arch-utils.c: Update.
7100         * break-catch-throw.c: Update.
7101         * breakpoint.c: Update.
7102         * btrace.c: Update.
7103         * c-varobj.c: Update.
7104         * cli/cli-cmds.c: Update.
7105         * cli/cli-interp.c: Update.
7106         * cli/cli-script.c: Update.
7107         * common/common-exceptions.c: Update.
7108         * common/new-op.c: Update.
7109         * common/selftest.c: Update.
7110         * compile/compile-c-symbols.c: Update.
7111         * compile/compile-cplus-symbols.c: Update.
7112         * compile/compile-object-load.c: Update.
7113         * compile/compile-object-run.c: Update.
7114         * completer.c: Update.
7115         * corelow.c: Update.
7116         * cp-abi.c: Update.
7117         * cp-support.c: Update.
7118         * cp-valprint.c: Update.
7119         * darwin-nat.c: Update.
7120         * disasm-selftests.c: Update.
7121         * dtrace-probe.c: Update.
7122         * dwarf-index-cache.c: Update.
7123         * dwarf-index-write.c: Update.
7124         * dwarf2-frame-tailcall.c: Update.
7125         * dwarf2-frame.c: Update.
7126         * dwarf2loc.c: Update.
7127         * dwarf2read.c: Update.
7128         * eval.c: Update.
7129         * event-loop.c: Update.
7130         * event-top.c: Update.
7131         * exec.c: Update.
7132         * f-valprint.c: Update.
7133         * fbsd-tdep.c: Update.
7134         * frame-unwind.c: Update.
7135         * frame.c: Update.
7136         * gdbtypes.c: Update.
7137         * gnu-v3-abi.c: Update.
7138         * guile/guile-internal.h: Update.
7139         * guile/scm-block.c: Update.
7140         * guile/scm-breakpoint.c: Update.
7141         * guile/scm-cmd.c: Update.
7142         * guile/scm-disasm.c: Update.
7143         * guile/scm-frame.c: Update.
7144         * guile/scm-lazy-string.c: Update.
7145         * guile/scm-math.c: Update.
7146         * guile/scm-param.c: Update.
7147         * guile/scm-ports.c: Update.
7148         * guile/scm-pretty-print.c: Update.
7149         * guile/scm-symbol.c: Update.
7150         * guile/scm-symtab.c: Update.
7151         * guile/scm-type.c: Update.
7152         * guile/scm-value.c: Update.
7153         * i386-linux-tdep.c: Update.
7154         * i386-tdep.c: Update.
7155         * inf-loop.c: Update.
7156         * infcall.c: Update.
7157         * infcmd.c: Update.
7158         * infrun.c: Update.
7159         * jit.c: Update.
7160         * language.c: Update.
7161         * linespec.c: Update.
7162         * linux-fork.c: Update.
7163         * linux-nat.c: Update.
7164         * linux-tdep.c: Update.
7165         * linux-thread-db.c: Update.
7166         * main.c: Update.
7167         * mi/mi-cmd-break.c: Update.
7168         * mi/mi-cmd-stack.c: Update.
7169         * mi/mi-interp.c: Update.
7170         * mi/mi-main.c: Update.
7171         * objc-lang.c: Update.
7172         * p-valprint.c: Update.
7173         * parse.c: Update.
7174         * ppc-linux-tdep.c: Update.
7175         * printcmd.c: Update.
7176         * python/py-arch.c: Update.
7177         * python/py-breakpoint.c: Update.
7178         * python/py-cmd.c: Update.
7179         * python/py-finishbreakpoint.c: Update.
7180         * python/py-frame.c: Update.
7181         * python/py-framefilter.c: Update.
7182         * python/py-gdb-readline.c: Update.
7183         * python/py-inferior.c: Update.
7184         * python/py-infthread.c: Update.
7185         * python/py-lazy-string.c: Update.
7186         * python/py-linetable.c: Update.
7187         * python/py-objfile.c: Update.
7188         * python/py-param.c: Update.
7189         * python/py-prettyprint.c: Update.
7190         * python/py-progspace.c: Update.
7191         * python/py-record-btrace.c: Update.
7192         * python/py-record.c: Update.
7193         * python/py-symbol.c: Update.
7194         * python/py-type.c: Update.
7195         * python/py-unwind.c: Update.
7196         * python/py-utils.c: Update.
7197         * python/py-value.c: Update.
7198         * python/python.c: Update.
7199         * record-btrace.c: Update.
7200         * record-full.c: Update.
7201         * remote-fileio.c: Update.
7202         * remote.c: Update.
7203         * riscv-tdep.c: Update.
7204         * rs6000-aix-tdep.c: Update.
7205         * rs6000-tdep.c: Update.
7206         * rust-exp.y: Update.
7207         * rust-lang.c: Update.
7208         * s390-tdep.c: Update.
7209         * selftest-arch.c: Update.
7210         * solib-dsbt.c: Update.
7211         * solib-frv.c: Update.
7212         * solib-spu.c: Update.
7213         * solib-svr4.c: Update.
7214         * solib.c: Update.
7215         * sparc64-linux-tdep.c: Update.
7216         * stack.c: Update.
7217         * symfile-mem.c: Update.
7218         * symmisc.c: Update.
7219         * target.c: Update.
7220         * thread.c: Update.
7221         * top.c: Update.
7222         * tracefile-tfile.c: Update.
7223         * tui/tui.c: Update.
7224         * typeprint.c: Update.
7225         * unittests/cli-utils-selftests.c: Update.
7226         * unittests/parse-connection-spec-selftests.c: Update.
7227         * valops.c: Update.
7228         * valprint.c: Update.
7229         * value.c: Update.
7230         * varobj.c: Update.
7231         * windows-nat.c: Update.
7232         * x86-linux-nat.c: Update.
7233         * xml-support.c: Update.
7234
7235 2019-04-08  Tom Tromey  <tom@tromey.com>
7236
7237         * xml-support.c: Use C++ exception handling.
7238         * x86-linux-nat.c: Use C++ exception handling.
7239         * windows-nat.c: Use C++ exception handling.
7240         * varobj.c: Use C++ exception handling.
7241         * value.c: Use C++ exception handling.
7242         * valprint.c: Use C++ exception handling.
7243         * valops.c: Use C++ exception handling.
7244         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7245         handling.
7246         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7247         * typeprint.c: Use C++ exception handling.
7248         * tui/tui.c: Use C++ exception handling.
7249         * tracefile-tfile.c: Use C++ exception handling.
7250         * top.c: Use C++ exception handling.
7251         * thread.c: Use C++ exception handling.
7252         * target.c: Use C++ exception handling.
7253         * symmisc.c: Use C++ exception handling.
7254         * symfile-mem.c: Use C++ exception handling.
7255         * stack.c: Use C++ exception handling.
7256         * sparc64-linux-tdep.c: Use C++ exception handling.
7257         * solib.c: Use C++ exception handling.
7258         * solib-svr4.c: Use C++ exception handling.
7259         * solib-spu.c: Use C++ exception handling.
7260         * solib-frv.c: Use C++ exception handling.
7261         * solib-dsbt.c: Use C++ exception handling.
7262         * selftest-arch.c: Use C++ exception handling.
7263         * s390-tdep.c: Use C++ exception handling.
7264         * rust-lang.c: Use C++ exception handling.
7265         * rust-exp.y: Use C++ exception handling.
7266         * rs6000-tdep.c: Use C++ exception handling.
7267         * rs6000-aix-tdep.c: Use C++ exception handling.
7268         * riscv-tdep.c: Use C++ exception handling.
7269         * remote.c: Use C++ exception handling.
7270         * remote-fileio.c: Use C++ exception handling.
7271         * record-full.c: Use C++ exception handling.
7272         * record-btrace.c: Use C++ exception handling.
7273         * python/python.c: Use C++ exception handling.
7274         * python/py-value.c: Use C++ exception handling.
7275         * python/py-utils.c: Use C++ exception handling.
7276         * python/py-unwind.c: Use C++ exception handling.
7277         * python/py-type.c: Use C++ exception handling.
7278         * python/py-symbol.c: Use C++ exception handling.
7279         * python/py-record.c: Use C++ exception handling.
7280         * python/py-record-btrace.c: Use C++ exception handling.
7281         * python/py-progspace.c: Use C++ exception handling.
7282         * python/py-prettyprint.c: Use C++ exception handling.
7283         * python/py-param.c: Use C++ exception handling.
7284         * python/py-objfile.c: Use C++ exception handling.
7285         * python/py-linetable.c: Use C++ exception handling.
7286         * python/py-lazy-string.c: Use C++ exception handling.
7287         * python/py-infthread.c: Use C++ exception handling.
7288         * python/py-inferior.c: Use C++ exception handling.
7289         * python/py-gdb-readline.c: Use C++ exception handling.
7290         * python/py-framefilter.c: Use C++ exception handling.
7291         * python/py-frame.c: Use C++ exception handling.
7292         * python/py-finishbreakpoint.c: Use C++ exception handling.
7293         * python/py-cmd.c: Use C++ exception handling.
7294         * python/py-breakpoint.c: Use C++ exception handling.
7295         * python/py-arch.c: Use C++ exception handling.
7296         * printcmd.c: Use C++ exception handling.
7297         * ppc-linux-tdep.c: Use C++ exception handling.
7298         * parse.c: Use C++ exception handling.
7299         * p-valprint.c: Use C++ exception handling.
7300         * objc-lang.c: Use C++ exception handling.
7301         * mi/mi-main.c: Use C++ exception handling.
7302         * mi/mi-interp.c: Use C++ exception handling.
7303         * mi/mi-cmd-stack.c: Use C++ exception handling.
7304         * mi/mi-cmd-break.c: Use C++ exception handling.
7305         * main.c: Use C++ exception handling.
7306         * linux-thread-db.c: Use C++ exception handling.
7307         * linux-tdep.c: Use C++ exception handling.
7308         * linux-nat.c: Use C++ exception handling.
7309         * linux-fork.c: Use C++ exception handling.
7310         * linespec.c: Use C++ exception handling.
7311         * language.c: Use C++ exception handling.
7312         * jit.c: Use C++ exception handling.
7313         * infrun.c: Use C++ exception handling.
7314         * infcmd.c: Use C++ exception handling.
7315         * infcall.c: Use C++ exception handling.
7316         * inf-loop.c: Use C++ exception handling.
7317         * i386-tdep.c: Use C++ exception handling.
7318         * i386-linux-tdep.c: Use C++ exception handling.
7319         * guile/scm-value.c: Use C++ exception handling.
7320         * guile/scm-type.c: Use C++ exception handling.
7321         * guile/scm-symtab.c: Use C++ exception handling.
7322         * guile/scm-symbol.c: Use C++ exception handling.
7323         * guile/scm-pretty-print.c: Use C++ exception handling.
7324         * guile/scm-ports.c: Use C++ exception handling.
7325         * guile/scm-param.c: Use C++ exception handling.
7326         * guile/scm-math.c: Use C++ exception handling.
7327         * guile/scm-lazy-string.c: Use C++ exception handling.
7328         * guile/scm-frame.c: Use C++ exception handling.
7329         * guile/scm-disasm.c: Use C++ exception handling.
7330         * guile/scm-cmd.c: Use C++ exception handling.
7331         * guile/scm-breakpoint.c: Use C++ exception handling.
7332         * guile/scm-block.c: Use C++ exception handling.
7333         * guile/guile-internal.h: Use C++ exception handling.
7334         * gnu-v3-abi.c: Use C++ exception handling.
7335         * gdbtypes.c: Use C++ exception handling.
7336         * frame.c: Use C++ exception handling.
7337         * frame-unwind.c: Use C++ exception handling.
7338         * fbsd-tdep.c: Use C++ exception handling.
7339         * f-valprint.c: Use C++ exception handling.
7340         * exec.c: Use C++ exception handling.
7341         * event-top.c: Use C++ exception handling.
7342         * event-loop.c: Use C++ exception handling.
7343         * eval.c: Use C++ exception handling.
7344         * dwarf2read.c: Use C++ exception handling.
7345         * dwarf2loc.c: Use C++ exception handling.
7346         * dwarf2-frame.c: Use C++ exception handling.
7347         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7348         * dwarf-index-write.c: Use C++ exception handling.
7349         * dwarf-index-cache.c: Use C++ exception handling.
7350         * dtrace-probe.c: Use C++ exception handling.
7351         * disasm-selftests.c: Use C++ exception handling.
7352         * darwin-nat.c: Use C++ exception handling.
7353         * cp-valprint.c: Use C++ exception handling.
7354         * cp-support.c: Use C++ exception handling.
7355         * cp-abi.c: Use C++ exception handling.
7356         * corelow.c: Use C++ exception handling.
7357         * completer.c: Use C++ exception handling.
7358         * compile/compile-object-run.c: Use C++ exception handling.
7359         * compile/compile-object-load.c: Use C++ exception handling.
7360         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7361         * compile/compile-c-symbols.c: Use C++ exception handling.
7362         * common/selftest.c: Use C++ exception handling.
7363         * common/new-op.c: Use C++ exception handling.
7364         * cli/cli-script.c: Use C++ exception handling.
7365         * cli/cli-interp.c: Use C++ exception handling.
7366         * cli/cli-cmds.c: Use C++ exception handling.
7367         * c-varobj.c: Use C++ exception handling.
7368         * btrace.c: Use C++ exception handling.
7369         * breakpoint.c: Use C++ exception handling.
7370         * break-catch-throw.c: Use C++ exception handling.
7371         * arch-utils.c: Use C++ exception handling.
7372         * amd64-tdep.c: Use C++ exception handling.
7373         * ada-valprint.c: Use C++ exception handling.
7374         * ada-typeprint.c: Use C++ exception handling.
7375         * ada-lang.c: Use C++ exception handling.
7376         * aarch64-tdep.c: Use C++ exception handling.
7377
7378 2019-04-08  Tom Tromey  <tom@tromey.com>
7379
7380         * xml-support.c (gdb_xml_parser::parse): Update.
7381         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7382         * value.c (show_convenience): Update.
7383         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7384         (test_parse_flags_qcs): Update.
7385         * thread.c (thr_try_catch_cmd): Update.
7386         * target.c (target_translate_tls_address): Update.
7387         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7388         (info_frame_command_core, frame_apply_command_count): Update.
7389         * rust-exp.y (rust_lex_exception_test): Update.
7390         * riscv-tdep.c (riscv_print_one_register_info): Update.
7391         * remote.c (remote_target::enable_btrace): Update.
7392         * record-btrace.c (record_btrace_enable_warn): Update.
7393         * python/py-utils.c (gdbpy_convert_exception): Update.
7394         * printcmd.c (do_one_display, print_variable_and_value): Update.
7395         * mi/mi-main.c (mi_print_exception): Update.
7396         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7397         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7398         * linux-nat.c (linux_nat_target::attach): Update.
7399         * linux-fork.c (class scoped_switch_fork_info): Update.
7400         * infrun.c (displaced_step_prepare): Update.
7401         * infcall.c (call_function_by_hand_dummy): Update.
7402         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7403         * gnu-v3-abi.c (print_one_vtable): Update.
7404         * frame.c (get_prev_frame_always): Update.
7405         * f-valprint.c (info_common_command_for_block): Update.
7406         * exec.c (try_open_exec_file): Update.
7407         * exceptions.c (print_exception, exception_print)
7408         (exception_fprintf, exception_print_same): Update.
7409         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7410         * dwarf-index-cache.c (index_cache::store)
7411         (index_cache::lookup_gdb_index): Update.
7412         * darwin-nat.c (maybe_cache_shell): Update.
7413         * cp-valprint.c (cp_print_value_fields): Update.
7414         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7415         (gcc_cplus_symbol_address): Update.
7416         * compile/compile-c-symbols.c (gcc_convert_symbol)
7417         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7418         * common/selftest.c: Update.
7419         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7420         a std::string.
7421         (exception_try_scope_entry, exception_try_scope_exit): Don't
7422         declare.
7423         (struct exception_try_scope): Remove.
7424         (TRY): Don't use exception_try_scope.
7425         (struct gdb_exception): Add constructor, operator=.
7426         <what>: New method.
7427         (struct gdb_exception_RETURN_MASK_ALL)
7428         (struct gdb_exception_RETURN_MASK_ERROR)
7429         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7430         (struct gdb_quit_bad_alloc): Update.
7431         * common/common-exceptions.c (exception_none): Change
7432         initializer.
7433         (struct catcher) <state, exception>: Initialize inline.
7434         <prev>: Remove member.
7435         (current_catcher): Remove.
7436         (catchers): New global.
7437         (exceptions_state_mc_init): Simplify.
7438         (catcher_pop): Remove.
7439         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7440         (try_scope_depth, exception_try_scope_entry)
7441         (exception_try_scope_exit): Remove.
7442         (throw_exception_sjlj): Update.
7443         (exception_messages, exception_messages_size): Remove.
7444         (throw_it): Simplify.
7445         (gdb_exception_sliced_copy): Remove.
7446         (throw_exception_cxx): Update.
7447         * cli/cli-script.c (script_from_file): Update.
7448         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7449         Update.
7450         * ada-valprint.c (ada_val_print): Update.
7451         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7452         (create_excep_cond_exprs): Update.
7453
7454 2019-04-08  Tom Tromey  <tom@tromey.com>
7455
7456         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7457         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7458         (TRY, CATCH, END_CATCH): Remove some definitions.
7459         * common/common-exceptions.c: Don't use GDB_XCPT.
7460         (catcher_list_size): Remove.
7461         (throw_exception, throw_it): Simplify.
7462
7463 2019-04-05  Tom Tromey  <tom@tromey.com>
7464
7465         Revert the header-sorting patch.
7466         * ft32-tdep.c: Revert.
7467         * frv-tdep.c: Revert.
7468         * frv-linux-tdep.c: Revert.
7469         * frame.c: Revert.
7470         * frame-unwind.c: Revert.
7471         * frame-base.c: Revert.
7472         * fork-child.c: Revert.
7473         * findvar.c: Revert.
7474         * findcmd.c: Revert.
7475         * filesystem.c: Revert.
7476         * filename-seen-cache.h: Revert.
7477         * filename-seen-cache.c: Revert.
7478         * fbsd-tdep.c: Revert.
7479         * fbsd-nat.h: Revert.
7480         * fbsd-nat.c: Revert.
7481         * f-valprint.c: Revert.
7482         * f-typeprint.c: Revert.
7483         * f-lang.c: Revert.
7484         * extension.h: Revert.
7485         * extension.c: Revert.
7486         * extension-priv.h: Revert.
7487         * expprint.c: Revert.
7488         * exec.h: Revert.
7489         * exec.c: Revert.
7490         * exceptions.c: Revert.
7491         * event-top.c: Revert.
7492         * event-loop.c: Revert.
7493         * eval.c: Revert.
7494         * elfread.c: Revert.
7495         * dwarf2read.h: Revert.
7496         * dwarf2read.c: Revert.
7497         * dwarf2loc.c: Revert.
7498         * dwarf2expr.h: Revert.
7499         * dwarf2expr.c: Revert.
7500         * dwarf2-frame.c: Revert.
7501         * dwarf2-frame-tailcall.c: Revert.
7502         * dwarf-index-write.h: Revert.
7503         * dwarf-index-write.c: Revert.
7504         * dwarf-index-common.c: Revert.
7505         * dwarf-index-cache.h: Revert.
7506         * dwarf-index-cache.c: Revert.
7507         * dummy-frame.c: Revert.
7508         * dtrace-probe.c: Revert.
7509         * disasm.h: Revert.
7510         * disasm.c: Revert.
7511         * disasm-selftests.c: Revert.
7512         * dictionary.c: Revert.
7513         * dicos-tdep.c: Revert.
7514         * demangle.c: Revert.
7515         * dcache.h: Revert.
7516         * dcache.c: Revert.
7517         * darwin-nat.h: Revert.
7518         * darwin-nat.c: Revert.
7519         * darwin-nat-info.c: Revert.
7520         * d-valprint.c: Revert.
7521         * d-namespace.c: Revert.
7522         * d-lang.c: Revert.
7523         * ctf.c: Revert.
7524         * csky-tdep.c: Revert.
7525         * csky-linux-tdep.c: Revert.
7526         * cris-tdep.c: Revert.
7527         * cris-linux-tdep.c: Revert.
7528         * cp-valprint.c: Revert.
7529         * cp-support.c: Revert.
7530         * cp-namespace.c: Revert.
7531         * cp-abi.c: Revert.
7532         * corelow.c: Revert.
7533         * corefile.c: Revert.
7534         * continuations.c: Revert.
7535         * completer.h: Revert.
7536         * completer.c: Revert.
7537         * complaints.c: Revert.
7538         * coffread.c: Revert.
7539         * coff-pe-read.c: Revert.
7540         * cli-out.h: Revert.
7541         * cli-out.c: Revert.
7542         * charset.c: Revert.
7543         * c-varobj.c: Revert.
7544         * c-valprint.c: Revert.
7545         * c-typeprint.c: Revert.
7546         * c-lang.c: Revert.
7547         * buildsym.c: Revert.
7548         * buildsym-legacy.c: Revert.
7549         * build-id.h: Revert.
7550         * build-id.c: Revert.
7551         * btrace.c: Revert.
7552         * bsd-uthread.c: Revert.
7553         * breakpoint.h: Revert.
7554         * breakpoint.c: Revert.
7555         * break-catch-throw.c: Revert.
7556         * break-catch-syscall.c: Revert.
7557         * break-catch-sig.c: Revert.
7558         * blockframe.c: Revert.
7559         * block.c: Revert.
7560         * bfin-tdep.c: Revert.
7561         * bfin-linux-tdep.c: Revert.
7562         * bfd-target.c: Revert.
7563         * bcache.c: Revert.
7564         * ax-general.c: Revert.
7565         * ax-gdb.h: Revert.
7566         * ax-gdb.c: Revert.
7567         * avr-tdep.c: Revert.
7568         * auxv.c: Revert.
7569         * auto-load.c: Revert.
7570         * arm-wince-tdep.c: Revert.
7571         * arm-tdep.c: Revert.
7572         * arm-symbian-tdep.c: Revert.
7573         * arm-pikeos-tdep.c: Revert.
7574         * arm-obsd-tdep.c: Revert.
7575         * arm-nbsd-tdep.c: Revert.
7576         * arm-nbsd-nat.c: Revert.
7577         * arm-linux-tdep.c: Revert.
7578         * arm-linux-nat.c: Revert.
7579         * arm-fbsd-tdep.c: Revert.
7580         * arm-fbsd-nat.c: Revert.
7581         * arm-bsd-tdep.c: Revert.
7582         * arch-utils.c: Revert.
7583         * arc-tdep.c: Revert.
7584         * arc-newlib-tdep.c: Revert.
7585         * annotate.h: Revert.
7586         * annotate.c: Revert.
7587         * amd64-windows-tdep.c: Revert.
7588         * amd64-windows-nat.c: Revert.
7589         * amd64-tdep.c: Revert.
7590         * amd64-sol2-tdep.c: Revert.
7591         * amd64-obsd-tdep.c: Revert.
7592         * amd64-obsd-nat.c: Revert.
7593         * amd64-nbsd-tdep.c: Revert.
7594         * amd64-nbsd-nat.c: Revert.
7595         * amd64-nat.c: Revert.
7596         * amd64-linux-tdep.c: Revert.
7597         * amd64-linux-nat.c: Revert.
7598         * amd64-fbsd-tdep.c: Revert.
7599         * amd64-fbsd-nat.c: Revert.
7600         * amd64-dicos-tdep.c: Revert.
7601         * amd64-darwin-tdep.c: Revert.
7602         * amd64-bsd-nat.c: Revert.
7603         * alpha-tdep.c: Revert.
7604         * alpha-obsd-tdep.c: Revert.
7605         * alpha-nbsd-tdep.c: Revert.
7606         * alpha-mdebug-tdep.c: Revert.
7607         * alpha-linux-tdep.c: Revert.
7608         * alpha-linux-nat.c: Revert.
7609         * alpha-bsd-tdep.c: Revert.
7610         * alpha-bsd-nat.c: Revert.
7611         * aix-thread.c: Revert.
7612         * agent.c: Revert.
7613         * addrmap.c: Revert.
7614         * ada-varobj.c: Revert.
7615         * ada-valprint.c: Revert.
7616         * ada-typeprint.c: Revert.
7617         * ada-tasks.c: Revert.
7618         * ada-lang.c: Revert.
7619         * aarch64-tdep.c: Revert.
7620         * aarch64-ravenscar-thread.c: Revert.
7621         * aarch64-newlib-tdep.c: Revert.
7622         * aarch64-linux-tdep.c: Revert.
7623         * aarch64-linux-nat.c: Revert.
7624         * aarch64-fbsd-tdep.c: Revert.
7625         * aarch64-fbsd-nat.c: Revert.
7626         * aarch32-linux-nat.c: Revert.
7627
7628 2019-04-05  Tom Tromey  <tom@tromey.com>
7629
7630         * ft32-tdep.c: Sort headers.
7631         * frv-tdep.c: Sort headers.
7632         * frv-linux-tdep.c: Sort headers.
7633         * frame.c: Sort headers.
7634         * frame-unwind.c: Sort headers.
7635         * frame-base.c: Sort headers.
7636         * fork-child.c: Sort headers.
7637         * findvar.c: Sort headers.
7638         * findcmd.c: Sort headers.
7639         * filesystem.c: Sort headers.
7640         * filename-seen-cache.h: Sort headers.
7641         * filename-seen-cache.c: Sort headers.
7642         * fbsd-tdep.c: Sort headers.
7643         * fbsd-nat.h: Sort headers.
7644         * fbsd-nat.c: Sort headers.
7645         * f-valprint.c: Sort headers.
7646         * f-typeprint.c: Sort headers.
7647         * f-lang.c: Sort headers.
7648         * extension.h: Sort headers.
7649         * extension.c: Sort headers.
7650         * extension-priv.h: Sort headers.
7651         * expprint.c: Sort headers.
7652         * exec.h: Sort headers.
7653         * exec.c: Sort headers.
7654         * exceptions.c: Sort headers.
7655         * event-top.c: Sort headers.
7656         * event-loop.c: Sort headers.
7657         * eval.c: Sort headers.
7658         * elfread.c: Sort headers.
7659         * dwarf2read.h: Sort headers.
7660         * dwarf2read.c: Sort headers.
7661         * dwarf2loc.c: Sort headers.
7662         * dwarf2expr.h: Sort headers.
7663         * dwarf2expr.c: Sort headers.
7664         * dwarf2-frame.c: Sort headers.
7665         * dwarf2-frame-tailcall.c: Sort headers.
7666         * dwarf-index-write.h: Sort headers.
7667         * dwarf-index-write.c: Sort headers.
7668         * dwarf-index-common.c: Sort headers.
7669         * dwarf-index-cache.h: Sort headers.
7670         * dwarf-index-cache.c: Sort headers.
7671         * dummy-frame.c: Sort headers.
7672         * dtrace-probe.c: Sort headers.
7673         * disasm.h: Sort headers.
7674         * disasm.c: Sort headers.
7675         * disasm-selftests.c: Sort headers.
7676         * dictionary.c: Sort headers.
7677         * dicos-tdep.c: Sort headers.
7678         * demangle.c: Sort headers.
7679         * dcache.h: Sort headers.
7680         * dcache.c: Sort headers.
7681         * darwin-nat.h: Sort headers.
7682         * darwin-nat.c: Sort headers.
7683         * darwin-nat-info.c: Sort headers.
7684         * d-valprint.c: Sort headers.
7685         * d-namespace.c: Sort headers.
7686         * d-lang.c: Sort headers.
7687         * ctf.c: Sort headers.
7688         * csky-tdep.c: Sort headers.
7689         * csky-linux-tdep.c: Sort headers.
7690         * cris-tdep.c: Sort headers.
7691         * cris-linux-tdep.c: Sort headers.
7692         * cp-valprint.c: Sort headers.
7693         * cp-support.c: Sort headers.
7694         * cp-namespace.c: Sort headers.
7695         * cp-abi.c: Sort headers.
7696         * corelow.c: Sort headers.
7697         * corefile.c: Sort headers.
7698         * continuations.c: Sort headers.
7699         * completer.h: Sort headers.
7700         * completer.c: Sort headers.
7701         * complaints.c: Sort headers.
7702         * coffread.c: Sort headers.
7703         * coff-pe-read.c: Sort headers.
7704         * cli-out.h: Sort headers.
7705         * cli-out.c: Sort headers.
7706         * charset.c: Sort headers.
7707         * c-varobj.c: Sort headers.
7708         * c-valprint.c: Sort headers.
7709         * c-typeprint.c: Sort headers.
7710         * c-lang.c: Sort headers.
7711         * buildsym.c: Sort headers.
7712         * buildsym-legacy.c: Sort headers.
7713         * build-id.h: Sort headers.
7714         * build-id.c: Sort headers.
7715         * btrace.c: Sort headers.
7716         * bsd-uthread.c: Sort headers.
7717         * breakpoint.h: Sort headers.
7718         * breakpoint.c: Sort headers.
7719         * break-catch-throw.c: Sort headers.
7720         * break-catch-syscall.c: Sort headers.
7721         * break-catch-sig.c: Sort headers.
7722         * blockframe.c: Sort headers.
7723         * block.c: Sort headers.
7724         * bfin-tdep.c: Sort headers.
7725         * bfin-linux-tdep.c: Sort headers.
7726         * bfd-target.c: Sort headers.
7727         * bcache.c: Sort headers.
7728         * ax-general.c: Sort headers.
7729         * ax-gdb.h: Sort headers.
7730         * ax-gdb.c: Sort headers.
7731         * avr-tdep.c: Sort headers.
7732         * auxv.c: Sort headers.
7733         * auto-load.c: Sort headers.
7734         * arm-wince-tdep.c: Sort headers.
7735         * arm-tdep.c: Sort headers.
7736         * arm-symbian-tdep.c: Sort headers.
7737         * arm-pikeos-tdep.c: Sort headers.
7738         * arm-obsd-tdep.c: Sort headers.
7739         * arm-nbsd-tdep.c: Sort headers.
7740         * arm-nbsd-nat.c: Sort headers.
7741         * arm-linux-tdep.c: Sort headers.
7742         * arm-linux-nat.c: Sort headers.
7743         * arm-fbsd-tdep.c: Sort headers.
7744         * arm-fbsd-nat.c: Sort headers.
7745         * arm-bsd-tdep.c: Sort headers.
7746         * arch-utils.c: Sort headers.
7747         * arc-tdep.c: Sort headers.
7748         * arc-newlib-tdep.c: Sort headers.
7749         * annotate.h: Sort headers.
7750         * annotate.c: Sort headers.
7751         * amd64-windows-tdep.c: Sort headers.
7752         * amd64-windows-nat.c: Sort headers.
7753         * amd64-tdep.c: Sort headers.
7754         * amd64-sol2-tdep.c: Sort headers.
7755         * amd64-obsd-tdep.c: Sort headers.
7756         * amd64-obsd-nat.c: Sort headers.
7757         * amd64-nbsd-tdep.c: Sort headers.
7758         * amd64-nbsd-nat.c: Sort headers.
7759         * amd64-nat.c: Sort headers.
7760         * amd64-linux-tdep.c: Sort headers.
7761         * amd64-linux-nat.c: Sort headers.
7762         * amd64-fbsd-tdep.c: Sort headers.
7763         * amd64-fbsd-nat.c: Sort headers.
7764         * amd64-dicos-tdep.c: Sort headers.
7765         * amd64-darwin-tdep.c: Sort headers.
7766         * amd64-bsd-nat.c: Sort headers.
7767         * alpha-tdep.c: Sort headers.
7768         * alpha-obsd-tdep.c: Sort headers.
7769         * alpha-nbsd-tdep.c: Sort headers.
7770         * alpha-mdebug-tdep.c: Sort headers.
7771         * alpha-linux-tdep.c: Sort headers.
7772         * alpha-linux-nat.c: Sort headers.
7773         * alpha-bsd-tdep.c: Sort headers.
7774         * alpha-bsd-nat.c: Sort headers.
7775         * aix-thread.c: Sort headers.
7776         * agent.c: Sort headers.
7777         * addrmap.c: Sort headers.
7778         * ada-varobj.c: Sort headers.
7779         * ada-valprint.c: Sort headers.
7780         * ada-typeprint.c: Sort headers.
7781         * ada-tasks.c: Sort headers.
7782         * ada-lang.c: Sort headers.
7783         * aarch64-tdep.c: Sort headers.
7784         * aarch64-ravenscar-thread.c: Sort headers.
7785         * aarch64-newlib-tdep.c: Sort headers.
7786         * aarch64-linux-tdep.c: Sort headers.
7787         * aarch64-linux-nat.c: Sort headers.
7788         * aarch64-fbsd-tdep.c: Sort headers.
7789         * aarch64-fbsd-nat.c: Sort headers.
7790         * aarch32-linux-nat.c: Sort headers.
7791
7792 2019-04-04  Tom Tromey  <tom@tromey.com>
7793
7794         * varobj.c (varobj_create): Update.
7795         * rust-exp.y (struct rust_parser) <update_innermost_block,
7796         lookup_symbol>: New methods.
7797         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7798         Rename.
7799         (rust_parser::rust_lookup_type)
7800         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7801         * printcmd.c (display_command, do_one_display): Update.
7802         * parser-defs.h (struct parser_state) <parser_state>: Add
7803         "tracker" parameter.
7804         (block_tracker): New member.
7805         (class innermost_block_tracker) <innermost_block_tracker>: Add
7806         "types" parameter.
7807         <reset>: Remove method.
7808         (innermost_block): Don't declare.
7809         (null_post_parser): Update.
7810         * parse.c (innermost_block): Remove global.
7811         (write_dollar_variable): Update.
7812         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7813         Remove "tracker_types" parameter.
7814         (parse_expression): Add "tracker" parameter.
7815         (parse_expression_for_completion): Update.
7816         (null_post_parser): Add "tracker" parameter.
7817         * p-exp.y: Update rules.
7818         * m2-exp.y: Update rules.
7819         * language.h (struct language_defn) <la_post_parser>: Add
7820         "tracker" parameter.
7821         * go-exp.y: Update rules.
7822         * f-exp.y: Update rules.
7823         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7824         parameter.
7825         * d-exp.y: Update rules.
7826         * c-exp.y: Update rules.
7827         * breakpoint.c (set_breakpoint_condition): Create an
7828         innermost_block_tracker.
7829         (watch_command_1): Likewise.
7830         * ada-lang.c (resolve): Add "tracker" parameter.
7831         (resolve_subexp): Likewise.
7832         * ada-exp.y (write_var_from_sym): Update.
7833
7834 2019-04-04  Tom Tromey  <tom@tromey.com>
7835
7836         * type-stack.h: New file.
7837         * type-stack.c: New file.
7838         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7839         type-stack.h.
7840         (insert_into_type_stack, insert_type, push_type, push_type_int)
7841         (insert_type_address_space, pop_type, pop_type_int)
7842         (pop_typelist, pop_type_stack, append_type_stack)
7843         (push_type_stack, get_type_stack, push_typelist)
7844         (follow_type_instance_flags, follow_types): Don't declare.
7845         * parse.c (type_stack): Remove global.
7846         (parse_exp_in_context): Update.
7847         (insert_into_type_stack, insert_type, push_type, push_type_int)
7848         (insert_type_address_space, pop_type, pop_type_int)
7849         (pop_typelist, pop_type_stack, append_type_stack)
7850         (push_type_stack, get_type_stack, push_typelist)
7851         (follow_type_instance_flags, follow_types): Remove (moved to
7852         type-stack.c).
7853         * f-exp.y (type_stack): New global.
7854         Update rules.
7855         (push_kind_type, f_parse): Update.
7856         * d-exp.y (type_stack): New global.
7857         Update rules.
7858         (d_parse): Update.
7859         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7860         Update rules.
7861         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7862         (HFILES_NO_SRCDIR): Add type-stack.h.
7863
7864 2019-04-04  Tom Tromey  <tom@tromey.com>
7865
7866         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7867         (rust_parser::convert_ast_to_expression, rust_parse)
7868         (rust_lex_test_completion, rust_lex_tests): Update.
7869         * parser-defs.h (struct expr_completion_state): New.
7870         (struct parser_state) <parser_state>: Add completion parameter.
7871         <mark_struct_expression, mark_completion_tag>: New methods.
7872         <parse_completion, m_completion_state>: New members.
7873         (prefixify_expression, null_post_parser): Update.
7874         (mark_struct_expression, mark_completion_tag): Don't declare.
7875         * parse.c (parse_completion, expout_last_struct)
7876         (expout_tag_completion_type, expout_completion_name): Remove
7877         globals.
7878         (parser_state::mark_struct_expression)
7879         (parser_state::mark_completion_tag): Now methods.
7880         (prefixify_expression): Add last_struct parameter.
7881         (prefixify_subexp): Likewise.
7882         (parse_exp_1): Update.
7883         (parse_exp_in_context): Add cstate parameter.  Update.
7884         (parse_expression_for_completion): Create an
7885         expr_completion_state.
7886         (null_post_parser): Add "completion" parameter.
7887         * p-exp.y: Update rules.
7888         (yylex): Update.
7889         * language.h (struct language_defn) <la_post_parser>: Add
7890         "completing" parameter.
7891         * go-exp.y: Update rules.
7892         (lex_one_token): Update.
7893         * expression.h (parse_completion): Don't declare.
7894         * d-exp.y: Update rules.
7895         (lex_one_token): Update rules.
7896         * c-exp.y: Update rules.
7897         (lex_one_token): Update.
7898         * ada-lang.c (resolve): Add "parse_completion" parameter.
7899         (resolve_subexp): Likewise.
7900         (ada_resolve_function): Likewise.
7901
7902 2019-04-04  Tom Tromey  <tom@tromey.com>
7903
7904         * parser-defs.h (struct parser_state) <start_arglist,
7905         end_arglist>: New methods.
7906         <arglist_len, m_funcall_chain>: New members.
7907         (arglist_len, start_arglist, end_arglist): Don't declare.
7908         * parse.c (arglist_len, funcall_chain): Remove global.
7909         (start_arglist, end_arglist): Remove functions.
7910         (parse_exp_in_context): Update.
7911         * p-exp.y: Update rules.
7912         * m2-exp.y: Update rules.
7913         * go-exp.y: Update rules.
7914         * f-exp.y: Update rules.
7915         * d-exp.y: Update rules.
7916         * c-exp.y: Update rules.
7917
7918 2019-04-04  Tom Tromey  <tom@tromey.com>
7919
7920         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7921         lex_operator, push_back>: New methods.
7922         Update all rules.
7923         (rust_parser::lex_hex, lex_escape): Rename and update.
7924         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7925         (rust_parser::lex_operator): Rename and update.
7926         (rust_parser::lex_number, rustyylex, rustyyerror)
7927         (rust_lex_test_init, rust_lex_test_sequence)
7928         (rust_lex_test_push_back, rust_lex_tests): Update.
7929         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7930         parameter.
7931         <lexptr, prev_lexptr>: New members.
7932         (lexptr, prev_lexptr): Don't declare.
7933         * parse.c (lexptr, prev_lexptr): Remove globals.
7934         (parse_exp_in_context): Update.
7935         * p-exp.y (yylex, yyerror): Update.
7936         * m2-exp.y (parse_number, yylex, yyerror): Update.
7937         * go-exp.y (lex_one_token, yyerror): Update.
7938         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7939         * d-exp.y (lex_one_token, yyerror): Update.
7940         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7941         (lex_one_token, yyerror): Update.
7942         * ada-lex.l (YY_INPUT): Update.
7943         (rewind_to_char): Update.
7944         * ada-exp.y (yyerror): Update.
7945
7946 2019-04-04  Tom Tromey  <tom@tromey.com>
7947
7948         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7949         * parser-defs.h (struct parser_state) <parser_state>: Add new
7950         parameter.
7951         <comma_terminates>: New member.
7952         (comma_terminates): Don't declare global.
7953         * parse.c (comma_terminates): Remove global.
7954         (parse_exp_in_context): Update.
7955         * p-exp.y (yylex): Update.
7956         * m2-exp.y (yylex): Update.
7957         * go-exp.y (lex_one_token): Update.
7958         * f-exp.y (yylex): Update.
7959         * d-exp.y (lex_one_token): Update.
7960         * c-exp.y (lex_one_token): Update.
7961         * ada-lex.l: Update.
7962
7963 2019-04-04  Tom Tromey  <tom@tromey.com>
7964
7965         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7966         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7967         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7968         * parser-defs.h (paren_depth): Don't declare.
7969         * parse.c (paren_depth): Remove global.
7970         (parse_exp_in_context): Update.
7971         * p-exp.y (paren_depth): New global.
7972         (pascal_parse): Initialize it.
7973         * m2-exp.y (paren_depth): New global.
7974         (m2_parse): Initialize it.
7975         * go-exp.y (paren_depth): New global.
7976         (go_parse): Initialize it.
7977         * f-exp.y (paren_depth): New global.
7978         (f_parse): Initialize it.
7979         * d-exp.y (paren_depth): New global.
7980         (d_parse): Initialize it.
7981         * c-exp.y (paren_depth): New global.
7982         (c_parse): Initialize it.
7983         * ada-lex.l (paren_depth): New global.
7984         (lexer_init): Initialize it.
7985
7986 2019-04-04  Tom Tromey  <tom@tromey.com>
7987
7988         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7989         (rust_parser::convert_ast_to_type)
7990         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7991         * parser-defs.h (struct parser_state) <parser_state>: Add
7992         parameters.  Initialize new members.
7993         <expression_context_block, expression_context_pc>: New members.
7994         * parse.c (expression_context_block, expression_context_pc):
7995         Remove globals.
7996         (parse_exp_in_context): Update.
7997         * p-exp.y: Update all rules.
7998         (yylex): Update.
7999         * m2-exp.y: Update all rules.
8000         (yylex): Update.
8001         * go-exp.y (yylex): Update.
8002         * f-exp.y (yylex): Update.
8003         * d-exp.y: Update all rules.
8004         (yylex): Update.
8005         * c-exp.y: Update all rules.
8006         (lex_one_token, classify_name, yylex, c_parse): Update.
8007         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8008
8009 2019-04-04  Tom Tromey  <tom@tromey.com>
8010
8011         * gdbarch.h, gdbarch.c: Rebuild.
8012         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8013         * stap-probe.h:
8014         (struct stap_parse_info): Replace "parser_state" with
8015         "expr_builder".
8016         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8017         (parser_state): New class.
8018         * parse.c (expr_builder): Rename.
8019         (expr_builder::release): Rename.
8020         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8021         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8022         (write_exp_elt_longcst, write_exp_elt_floatcst)
8023         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8024         (write_exp_string_vector, write_exp_bitstring)
8025         (write_exp_msymbol, mark_struct_expression)
8026         (write_dollar_variable)
8027         (insert_type_address_space, increase_expout_size): Replace
8028         "parser_state" with "expr_builder".
8029         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8030         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8031         "parser_state" with "expr_builder".
8032
8033 2019-04-04  Tom Tromey  <tom@tromey.com>
8034
8035         * rust-exp.y: Replace "parse_language" with method call.
8036         * p-exp.y:
8037         (yylex): Replace "parse_language" with method call.
8038         * m2-exp.y:
8039         (yylex): Replace "parse_language" with method call.
8040         * go-exp.y (classify_name): Replace "parse_language" with method
8041         call.
8042         * f-exp.y (yylex): Replace "parse_language" with method call.
8043         * d-exp.y (lex_one_token): Replace "parse_language" with method
8044         call.
8045         * c-exp.y:
8046         (lex_one_token, classify_name, yylex): Replace "parse_language"
8047         with method call.
8048         * ada-exp.y (find_primitive_type, type_char)
8049         (type_system_address): Replace "parse_language" with method call.
8050
8051 2019-04-04  Tom Tromey  <tom@tromey.com>
8052
8053         * rust-exp.y: Replace "parse_gdbarch" with method call.
8054         * parse.c (write_dollar_variable, insert_type_address_space):
8055         Replace "parse_gdbarch" with method call.
8056         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8057         call.
8058         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8059         call.
8060         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8061         "parse_gdbarch" with method call.
8062         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8063         with method call.
8064         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8065         "parse_gdbarch" with method call.
8066         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8067         "parse_gdbarch" with method call.
8068         * c-exp.y (parse_type, parse_number, classify_name): Replace
8069         "parse_gdbarch" with method call.
8070         * ada-lex.l: Replace "parse_gdbarch" with method call.
8071         * ada-exp.y (parse_type, find_primitive_type, type_char)
8072         (type_system_address): Replace "parse_gdbarch" with method call.
8073
8074 2019-04-04  Tom Tromey  <tom@tromey.com>
8075
8076         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8077         * stap-probe.c (stap_parse_argument): Update.
8078         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8079         initial_size parameter.
8080         * rust-exp.y (rust_lex_tests): Update.
8081         * parse.c (parser_state): Update.
8082         (parse_exp_in_context): Update.
8083         * parser-defs.h (struct parser_state) <parser_state>: Remove
8084         "initial_size" parameter.
8085
8086 2019-04-04  Tom Tromey  <tom@tromey.com>
8087
8088         * parser-defs.h (increase_expout_size): Don't declare.
8089         * parse.c (increase_expout_size): Now static.
8090
8091 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8092
8093         * gnu-nat.c (gnu_nat_target::wait): Fix
8094         target_waitstatus_to_string call.
8095
8096 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * eval.c (evaluate_subexp_standard): Handle internal functions
8099         during Fortran function call handling.
8100
8101 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * NEWS: Mention new internal functions.
8104         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8105         (read_base_type): Use dwarf2_init_complex_target_type.
8106         * value.c (creal_internal_fn): New function.
8107         (cimag_internal_fn): New function.
8108         (_initialize_values): Register new internal functions.
8109
8110 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8111
8112         * infrun.c (stop_all_threads): If debug_infrun, always
8113         trace the wait status after wait_one, using
8114         target_waitstatus_to_string and target_pid_to_str.
8115         (handle_inferior_event): Replace various trace of
8116         wait status kind by a single trace.
8117         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8118         wait status kind image by target_waitstatus_to_string.
8119         * target/waitstatus.c (target_waitstatus_to_string): Fix
8120         obsolete comment.
8121
8122 2019-04-01  Tom Tromey  <tromey@adacore.com>
8123
8124         PR symtab/23331:
8125         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8126
8127 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8128             Pedro Alves  <palves@redhat.com>
8129
8130         * top.c (quit_force): Call 'finalize_values'.
8131         * value.c (finalize_values): New function.
8132         * value.h (finalize_values): Declare.
8133
8134 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8135
8136         * NEWS: Announce $_gdb_major and $_gdb_minor.
8137
8138         * top.c (init_gdb_version_vars): New function.
8139         (gdb_init): Call init_gdb_version_vars.
8140
8141 2019-03-29  Tom Tromey  <tromey@adacore.com>
8142
8143         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8144         help text.  Remove dead code.
8145
8146 2019-03-29  Keith Seitz  <keiths@redhat.com>
8147
8148         From Siddhesh Poyarekar:
8149         * f-lang.h (f77_get_upperbound): Return LONGEST.
8150         (f77_get_lowerbound): Likewise.
8151         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8152         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8153         print them.
8154         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8155         plongest to format print it.
8156         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8157         (f77_get_upperbound): Likewise.
8158         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8159         LOWER_BOUND to LONGEST.
8160         (f77_create_arrayprint_offset_tbl): Likewise.
8161
8162 2019-03-29  Keith Seitz  <keiths@redhat.com>
8163
8164         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8165         %s/pulongest for TYPE_LENGTH instead of %d in format
8166         strings.
8167         * ada-typerint.c (ada_print_type): Likewise.
8168         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8169         * compile/compile-c-support.c (generate_register_struct): Likewise.
8170         * gdbtypes.c (recursive_dump_type): Likewise.
8171         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8172         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8173         instead of %d in format strings.
8174         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8175         to std::min to ULONGEST.
8176         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8177         instead of %d in format strings.
8178         * tracepoint.c (info_scope_command): Likewise.
8179         * typeprint.c (print_offset_data::update)
8180         (print_offset_data::finish): Likewise.
8181         * xtensa-tdep.c (xtensa_store_return_value)
8182         (xtensa_push_dummy_call): Likewise.
8183
8184 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8185
8186         * windows-nat.c (display_selector): Fixed format specifications
8187         for 64-bit Cygwin.
8188
8189 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8190
8191         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8192
8193 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8194
8195         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8196         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8197         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8198         (nios2_linux_init_abi): Install it.
8199
8200 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8201
8202         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8203
8204 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8205
8206         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8207
8208 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8209             Tom Tromey  <tromey@adacore.com>
8210
8211         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8212
8213 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8214
8215         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8216         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8217         method to compute the bounds of range types. Also print "[evaluated]"
8218         if the bounds' values come from a dynamic evaluation.
8219
8220 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8223         whitespace when pretty printing is on.
8224
8225 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8226
8227         * ppc-linux-nat.c: Add include.
8228
8229 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8230
8231         * NEWS: Mention AArch64 Pointer Authentication.
8232
8233 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8234
8235         * arm-linux-nat.c: Add include.
8236
8237 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8238
8239         * source-cache.c (source_cache::get_source_lines): Re-read
8240         fullname after calling open_source_file.
8241
8242 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8243
8244         * NEWS: Mention TLS support for FreeBSD.
8245
8246 2019-03-25  Tom Tromey  <tromey@adacore.com>
8247
8248         * minsyms.c (BUNCH_SIZE): Update comment.
8249         (~minimal_symbol_reader): Remove old comment.
8250         (compact_minimal_symbols): Update comment.
8251         (minimal_symbol_reader::install): Remove old comment.  Update
8252         other comments.
8253
8254 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8255
8256         * s390-linux-nat.c: Add include.
8257
8258 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8259
8260         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8261         Call linux_get_hwcap.
8262         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8263         Likewise.
8264         (aarch64_linux_get_hwcap): Remove function.
8265         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8266         declaration.
8267         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8268         linux_get_hwcap.
8269         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8270         * linux-tdep.c (linux_get_hwcap): Add function.
8271         (linux_get_hwcap2): Likewise.
8272         * linux-tdep.h (linux_get_hwcap): Add declaration.
8273         (linux_get_hwcap2): Likewise.
8274         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8275         (ppc_linux_get_hwcap2): Likewise.
8276         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8277         linux_get_hwcap.
8278         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8279         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8280         (ppc_linux_nat_target::read_description): Likewise.
8281         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8282         * s390-linux-nat.c: Likewise.
8283         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8284
8285 2019-03-24  Tom Tromey  <tom@tromey.com>
8286
8287         * ada-lang.c (standard_lookup): Simplify initialization.
8288         (ada_lookup_symbol_nonlocal): Simplify return.
8289         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8290         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8291         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8292         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8293         initialization.
8294         * solib.c (solib_global_lookup): Simplify.
8295         * symtab.c (null_block_symbol): Remove.
8296         (symbol_cache_lookup): Simplify returns.
8297         (lookup_language_this): Simplify returns.
8298         (lookup_symbol_aux): Simplify return.
8299         (lookup_local_symbol): Simplify returns.
8300         (lookup_global_symbol_from_objfile): Simplify return.
8301         (lookup_symbol_in_objfile_symtabs)
8302         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8303         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8304         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8305         * cp-namespace.c (cp_lookup_bare_symbol)
8306         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8307         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8308         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8309         (cp_lookup_symbol_via_imports): Simplify initialization.
8310         (find_symbol_in_baseclass): Likewise.
8311         * symtab.h (null_block_symbol): Remove.
8312         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8313         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8314         (d_lookup_symbol_module): Likewise.
8315         (find_symbol_in_baseclass): Simplify initialization.
8316
8317 2019-03-24  Tom Tromey  <tom@tromey.com>
8318
8319         * expression.h: Don't include symtab.h.
8320         (struct block): Forward declare.
8321
8322 2019-03-24  Tom Tromey  <tom@tromey.com>
8323
8324         * c-exp.y (typebase): Remove casts.
8325         * gdbtypes.c (lookup_unsigned_typename, )
8326         (lookup_signed_typename): Remove cast.
8327         * eval.c (parse_to_comma_and_eval): Remove cast.
8328         * parse.c (write_dollar_variable): Remove cast.
8329         * block.h (struct block) <superblock>: Now const.
8330         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8331         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8332         (map_block): Make "block" const.
8333         * symfile.h (struct quick_symbol_functions)
8334         <map_matching_symbols>: Constify block argument to "callback".
8335         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8336         const.
8337         (find_pc_sect_compunit_symtab): Make "b" const.
8338         (find_symbol_at_address): Likewise.
8339         (search_symbols): Likewise.
8340         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8341         (dw2_debug_names_lookup_symbol): Likewise.
8342         (dw2_map_matching_symbols): Update.
8343         * p-valprint.c (pascal_val_print): Remove "block".
8344         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8345         (aux_add_nonlocal_symbols): Make "block" const.
8346         (resolve_subexp): Remove cast.
8347         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8348         const.
8349         (iterate_over_file_blocks): Likewise.
8350         * f-exp.y (%union) <bval>: Remove.
8351         * coffread.c (patch_opaque_types): Make "b" const.
8352         * spu-tdep.c (spu_catch_start): Make "block" const.
8353         * c-valprint.c (print_unpacked_pointer): Remove "block".
8354         * symmisc.c (dump_symtab_1): Make "b" const.
8355         (block_depth): Make "block" const.
8356         * d-exp.y (%union) <bval>: Remove.
8357         * cp-support.h (cp_lookup_rtti_type): Update.
8358         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8359         * psymtab.c (psym_lookup_symbol): Make "block" const.
8360         (maintenance_check_psymtabs): Make "b" const.
8361         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8362         (enumerate_locals, enumerate_args): Update.
8363         * python/py-symtab.c (stpy_global_block): Make "block" const.
8364         (stpy_static_block): Likewise.
8365         * inline-frame.c (block_starting_point_at): Make "new_block"
8366         const.
8367         * block.c (find_block_in_blockvector): Make return type const.
8368         (blockvector_for_pc_sect): Make "b" const.
8369         (find_block_in_blockvector): Make "b" const.
8370
8371 2019-03-23  Tom Tromey  <tom@tromey.com>
8372
8373         * varobj.c (varobj_create): Update.
8374         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8375         * printcmd.c (display_command, do_one_display): Don't reset
8376         innermost_block.
8377         * parser-defs.h (enum innermost_block_tracker_type): Move to
8378         expression.h.
8379         (innermost_block): Update comment.
8380         * parse.c (parse_exp_1): Add tracker_types parameter.
8381         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8382         tracker_types parameter.  Reset innermost_block.
8383         (parse_exp_in_context): Remove.
8384         (parse_expression_for_completion): Update.
8385         * objfiles.c (~objfile): Don't reset expression_context_block or
8386         innermost_block.
8387         * expression.h (enum innermost_block_tracker_type): Move from
8388         parser-defs.h.
8389         (parse_exp_1): Add tracker_types parameter.
8390         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8391         reset innermost_block.
8392
8393 2019-03-23  Tom Tromey  <tom@tromey.com>
8394
8395         * objfiles.h: Include bcache.h.
8396
8397 2019-03-23  Tom Tromey  <tom@tromey.com>
8398
8399         * linespec.c (get_current_search_block): Use
8400         scoped_restore_current_language.
8401         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8402
8403 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8404             Jiong Wang  <jiong.wang@arm.com>
8405
8406         * aarch64-linux-tdep.c
8407         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8408         section.
8409         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8410
8411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8412             Jiong Wang  <jiong.wang@arm.com>
8413
8414         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8415         instructions.
8416         (aarch64_analyze_prologue_test): Add PACIASP test.
8417         (aarch64_prologue_prev_register): Unmask PC value.
8418
8419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8420             Jiong Wang  <jiong.wang@arm.com>
8421
8422         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8423         (aarch64_dwarf2_prev_register): Unmask PC value.
8424         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8425         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8426         DW_CFA_AARCH64_negate_ra_state.
8427         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8428
8429 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8430             Jiong Wang  <jiong.wang@arm.com>
8431
8432         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8433         registers.
8434         (aarch64_pseudo_register_name): Likewise.
8435         (aarch64_pseudo_register_type): Likewise.
8436         (aarch64_pseudo_register_reggroup_p): Likewise.
8437         (aarch64_gdbarch_init): Add pauth registers.
8438         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8439         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8440         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8441         (struct gdbarch_tdep): Add regnum for ra_state.
8442
8443 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8444             Jiong Wang  <jiong.wang@arm.com>
8445
8446         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8447
8448 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8449             Jiong Wang  <jiong.wang@arm.com>
8450
8451         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8452         function.
8453         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8454         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8455         (aarch64_gdbarch_init): Add puth registers.
8456         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8457         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8458         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8459
8460 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8461             Jiong Wang  <jiong.wang@arm.com>
8462
8463         * aarch64-linux-nat.c
8464         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8465         * aarch64-linux-tdep.c
8466         (aarch64_linux_core_read_description): Likewise.
8467         (aarch64_linux_get_hwcap): New function.
8468         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8469         (aarch64_linux_get_hwcap): New declaration.
8470
8471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8472             Jiong Wang  <jiong.wang@arm.com>
8473
8474         * aarch64-linux-nat.c
8475         (aarch64_linux_nat_target::read_description): Add pauth param.
8476         * aarch64-linux-tdep.c
8477         (aarch64_linux_core_read_description): Likewise.
8478         * aarch64-tdep.c (struct target_desc): Add in pauth.
8479         (aarch64_read_description): Add pauth param.
8480         (aarch64_gdbarch_init): Likewise.
8481         * aarch64-tdep.h (aarch64_read_description): Likewise.
8482         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8483         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8484         * features/Makefile: Add new files.
8485         * features/aarch64-pauth.c: New file.
8486         * features/aarch64-pauth.xml: New file.
8487
8488 2019-03-20  Tom Tromey  <tromey@adacore.com>
8489
8490         * infrun.c (handle_inferior_event): Rename from
8491         handle_inferior_event_1.  Create a scoped_value_mark.
8492         (handle_inferior_event): Remove.
8493
8494 2019-03-19  Tom Tromey  <tromey@adacore.com>
8495
8496         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8497         * infrun.h (print_stop_event): Add "displays" parameter.
8498         * infrun.c (print_stop_event): Add "displays" parameter.
8499
8500 2019-03-19  Pedro Alves  <palves@redhat.com>
8501
8502         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8503         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8504         to -1.  Fix TABs vs spaces.
8505         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8506         * tui/tui-out.h (tui_ui_out) Add intro comments.
8507         <m_line, m_start_of_line>: In-class initialize, and add describing
8508         comment.
8509
8510 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8511
8512         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8513         variable names.
8514         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8515
8516 2019-03-18  Pedro Alves  <palves@redhat.com>
8517             Eli Zaretskii <eliz@gnu.org>
8518
8519         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8520         m_line and m_start_of_line.
8521
8522 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8523
8524         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8525         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8526         it returns a newline.  This fixes a regression in TU mode, whereby
8527         the next line is output on the same screen line as the user input.
8528
8529 2019-03-18  Tom Tromey  <tromey@adacore.com>
8530
8531         * minsyms.c (minimal_symbol_reader::install): Remove call to
8532         obstack_blank.
8533
8534 2019-03-18  Pedro Alves  <palves@redhat.com>
8535
8536         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8537         New globals.
8538         (apply_style): New, factored out from ...
8539         (apply_ansi_escape): ... this.  Handle reverse video mode.
8540         (tui_set_reverse_mode): New function.
8541         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8542         * tui/tui-winsource.c (tui_show_source_line): Use
8543         tui_set_reverse_mode instead of setting A_STANDOUT.
8544         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8545         New setter methods.
8546
8547 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8548
8549         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8550         Handle tabs.
8551
8552 2019-03-18  Tom Tromey  <tromey@adacore.com>
8553
8554         * ada-lang.c (empty_array): Add "high" parameter.
8555         (ada_evaluate_subexp): Update.
8556
8557 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8558
8559         * unittests/string_view-selftests.c: Define
8560         _initialize_string_view_selftests unconditionally.
8561
8562 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8563
8564         PR gdb/24350
8565         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8566
8567 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8568
8569         PR gdb/24351
8570         * windows-nat.c (display_selector): Fix format specifiers.
8571
8572 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8573
8574         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8575         tui_refill_source_window instead of tui_refresh_win, to update the
8576         current execution line.  This fixes redisplay of the current line
8577         when stepping through the code with "next" or "step".
8578
8579 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8580
8581         * source-cache.c (source_cache::get_source_lines): Call
8582         find_source_lines to initialize s->nlines.  This fixes vertical
8583         scrolling of TUI source window when the DOWN arrow is pressed.
8584
8585 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8586
8587         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8588         linux-thread-db.c (_initialize_thread_db): Likewise.
8589
8590 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8591
8592         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8593         wclrtoeol in tui_show_source_line".  This reverts changes made in
8594         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8595
8596 2019-03-15  Tom Tromey  <tom@tromey.com>
8597
8598         * symtab.h (struct minimal_symbol): Derive from
8599         general_symbol_info.
8600         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8601         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8602         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8603         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8604         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8605         (MSYMBOL_SEARCH_NAME): Update.
8606         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8607         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8608         * minsyms.c (minimal_symbol_reader::record_full): Update.
8609
8610 2019-03-15  Tom Tromey  <tom@tromey.com>
8611
8612         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8613
8614 2019-03-15  Tom Tromey  <tom@tromey.com>
8615
8616         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8617         unique_xmalloc_ptr.
8618         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8619         Update.
8620         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8621         (build_minimal_symbol_hash_tables)
8622         (minimal_symbol_reader::install): Update.
8623
8624 2019-03-15  Tom Tromey  <tom@tromey.com>
8625
8626         * symtab.c (create_demangled_names_hash): Update.
8627         (symbol_set_names): Update.
8628         * objfiles.h (struct objfile_per_bfd_storage)
8629         <demangled_names_hash>: Now an htab_up.
8630         * objfiles.c (objfile_per_bfd_storage): Simplify.
8631
8632 2019-03-15  Tom Tromey  <tom@tromey.com>
8633
8634         * objfiles.h (struct objfile_per_bfd_storage): Declare
8635         destructor.
8636         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8637         New.
8638         (get_objfile_bfd_data): Use new.  Don't initialize
8639         language_of_main.
8640         (free_objfile_per_bfd_storage): Remove.
8641         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8642
8643 2019-03-15  Tom Tromey  <tom@tromey.com>
8644
8645         * symfile.c (reread_symbols): Update.
8646         * objfiles.c (objfile::objfile): Update.
8647         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8648         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8649         comment.
8650         (minimal_symbol_reader::install): Update.
8651         (terminate_minimal_symbol_table): Remove.
8652         * jit.c (jit_object_close_impl): Update.
8653
8654 2019-03-15  Tom Tromey  <tom@tromey.com>
8655
8656         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8657         initializations.
8658
8659 2019-03-15  Tom Tromey  <tom@tromey.com>
8660
8661         * objfiles.h (struct objfile_per_bfd_storage)
8662         <demangled_hash_languages>: Now a bitset.
8663         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8664         (lookup_minimal_symbol): Update.
8665
8666 2019-03-15  Tom Tromey  <tom@tromey.com>
8667
8668         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8669         Don't return the symbol.
8670         * coffread.c (record_minimal_symbol): Use record_full.
8671
8672 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8673
8674         The MS-Windows port of ncurses fails to switch to a color pair if
8675         one or both of the colors are the implicit default colors.  This
8676         change records the default colors when TUI is initialized, and
8677         then specifies them explicitly when a color pair uses the default
8678         colors.  This allows color styling in TUI mode on MS-Windows.
8679
8680         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8681         ncurses_norm_attr.
8682         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8683         colors in ncurses_norm_attr.
8684         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8685         "none", replace it with the default color recorded in
8686         ncurses_norm_attr.
8687
8688 2019-03-14  Tom Tromey  <tromey@adacore.com>
8689
8690         * source-cache.h (class source_cache) <get_source_lines>: Return
8691         std::string.
8692         * source-cache.c (source_cache::extract_lines): Handle case where
8693         first_pos==npos.  Return std::string.
8694         (source_cache::get_source_lines): Update.
8695
8696 2019-03-14  Tom Tromey  <tromey@adacore.com>
8697
8698         * NEWS: Add item for "style sources" commands.
8699         * source-cache.c (source_cache::get_source_lines): Check
8700         source_styling.
8701         * cli/cli-style.c (source_styling): New global.
8702         (_initialize_cli_style): Add "style sources" commands.
8703         (show_style_sources): New function.
8704         * cli/cli-style.h (source_styling): Declare.
8705
8706 2019-03-14  Pedro Alves  <palves@redhat.com>
8707             Tom Tromey  <tromey@adacore.com>
8708
8709         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8710         * tui/tui-winsource.c (tui_refill_source_window): New function,
8711         from...
8712         (tui_horizontal_source_scroll): ... here.  Move some logic.
8713         * cli/cli-style.c (set_style_enabled): Notify new observable.
8714         * tui/tui-hooks.c (tui_redisplay_source): New function.
8715         (tui_attach_detach_observers): Attach or detach
8716         tui_redisplay_source.
8717         * observable.h (source_styling_changed): New observable.
8718         * observable.c: Define source_styling_changed observable.
8719
8720 2019-03-13  Tom Tromey  <tromey@adacore.com>
8721
8722         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8723         (i386_gnu_nat_target::store_registers): Update.
8724         * target-debug.h (target_debug_print_std_string): New macro.
8725         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8726         * windows-tdep.c (display_one_tib): Update.
8727         * tui/tui-stack.c (tui_make_status_line): Update.
8728         * top.c (print_inferior_quit_action): Update.
8729         * thread.c (thr_try_catch_cmd): Update.
8730         (add_thread_with_info): Update.
8731         (thread_target_id_str): Update.
8732         (thr_try_catch_cmd): Update.
8733         (thread_command): Update.
8734         (thread_find_command): Update.
8735         * record-btrace.c (record_btrace_target::info_record)
8736         (record_btrace_resume_thread, record_btrace_target::resume)
8737         (record_btrace_cancel_resume, record_btrace_step_thread)
8738         (record_btrace_target::wait, record_btrace_target::wait)
8739         (record_btrace_target::wait, record_btrace_target::stop): Update.
8740         * progspace.c (print_program_space): Update.
8741         * process-stratum-target.c
8742         (process_stratum_target::thread_address_space): Update.
8743         * linux-fork.c (linux_fork_mourn_inferior)
8744         (detach_checkpoint_command, info_checkpoints_command)
8745         (linux_fork_context): Update.
8746         (linux_fork_detach): Update.
8747         (class scoped_switch_fork_info): Update.
8748         (delete_checkpoint_command): Update.
8749         * infrun.c (follow_fork_inferior): Update.
8750         (follow_fork_inferior): Update.
8751         (proceed_after_vfork_done): Update.
8752         (handle_vfork_child_exec_or_exit): Update.
8753         (follow_exec): Update.
8754         (displaced_step_prepare_throw): Update.
8755         (displaced_step_restore): Update.
8756         (start_step_over): Update.
8757         (resume_1): Update.
8758         (clear_proceed_status_thread): Update.
8759         (proceed): Update.
8760         (print_target_wait_results): Update.
8761         (do_target_wait): Update.
8762         (context_switch): Update.
8763         (stop_all_threads): Update.
8764         (restart_threads): Update.
8765         (finish_step_over): Update.
8766         (handle_signal_stop): Update.
8767         (switch_back_to_stepped_thread): Update.
8768         (keep_going_pass_signal): Update.
8769         (print_exited_reason): Update.
8770         (normal_stop): Update.
8771         * inferior.c (inferior_pid_to_str): Change return type.
8772         (print_selected_inferior): Update.
8773         (add_inferior): Update.
8774         (detach_inferior): Update.
8775         * dummy-frame.c (fprint_dummy_frames): Update.
8776         * dcache.c (dcache_info_1): Update.
8777         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8778         (btrace_fetch, btrace_clear): Update.
8779         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8780         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8781         type.
8782         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8783         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8784         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8785         * gdbarch.c, gdbarch.h: Rebuild.
8786         * gdbarch.sh (core_pid_to_str): Change return type.
8787         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8788         return type.
8789         (windows_nat_target::pid_to_str): Change return type.
8790         (windows_delete_thread): Update.
8791         (windows_nat_target::attach): Update.
8792         (windows_nat_target::files_info): Update.
8793         * target-delegates.c: Rebuild.
8794         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8795         return type.
8796         (sol_thread_target::pid_to_str): Change return type.
8797         * remote.c (class remote_target) <pid_to_str>: Change return
8798         type.
8799         (remote_target::pid_to_str): Change return type.
8800         (extended_remote_target::attach, remote_target::remote_stop_ns)
8801         (remote_target::remote_notif_remove_queued_reply)
8802         (remote_target::push_stop_reply, remote_target::disable_btrace):
8803         Update.
8804         (extended_remote_target::attach): Update.
8805         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8806         type.
8807         (gdbsim_target::pid_to_str): Change return type.
8808         * ravenscar-thread.c (struct ravenscar_thread_target)
8809         <pid_to_str>: Change return type.
8810         (ravenscar_thread_target::pid_to_str): Change return type.
8811         * procfs.c (class procfs_target) <pid_to_str>: Change return
8812         type.
8813         (procfs_target::pid_to_str): Change return type.
8814         (procfs_target::attach): Update.
8815         (procfs_target::detach): Update.
8816         (procfs_target::fetch_registers): Update.
8817         (procfs_target::store_registers): Update.
8818         (procfs_target::wait): Update.
8819         (procfs_target::files_info): Update.
8820         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8821         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8822         return type.
8823         (nto_procfs_target::pid_to_str): Change return type.
8824         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8825         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8826         return type.
8827         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8828         (exit_lwp): Update.
8829         (attach_proc_task_lwp_callback, get_detach_signal)
8830         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8831         (linux_nat_target::resume, wait_lwp, stop_callback)
8832         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8833         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8834         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8835         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8836         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8837         type.
8838         (inf_ptrace_target::attach): Update.
8839         (inf_ptrace_target::files_info): Update.
8840         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8841         type.
8842         (go32_nat_target::pid_to_str): Change return type.
8843         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8844         (gnu_nat_target::wait): Update.
8845         (gnu_nat_target::wait): Update.
8846         (gnu_nat_target::resume): Update.
8847         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8848         (fbsd_nat_target::wait): Update.
8849         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8850         type.
8851         (darwin_nat_target::attach): Update.
8852         * corelow.c (class core_target) <pid_to_str>: Change return type.
8853         (core_target::pid_to_str): Change return type.
8854         * target.c (normal_pid_to_str): Change return type.
8855         (default_pid_to_str): Likewise.
8856         (target_pid_to_str): Change return type.
8857         (target_translate_tls_address): Update.
8858         (target_announce_detach): Update.
8859         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8860         return type.
8861         (bsd_uthread_target::pid_to_str): Change return type.
8862         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8863         type.
8864         (bsd_kvm_target::pid_to_str): Change return type.
8865         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8866         return type.
8867         (aix_thread_target::pid_to_str): Change return type.
8868         * target.h (struct target_ops) <pid_to_str>: Change return type.
8869         (target_pid_to_str, normal_pid_to_str): Likewise.
8870         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8871         type.
8872         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8873         type.
8874         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8875         return type.
8876         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8877         type.
8878         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8879         type.
8880         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8881         return type.
8882
8883 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8884
8885         * NEWS: Mention that the new default MI version is 3.  Mention
8886         changes to the output of commands and events that deal with
8887         multi-location breakpoints.
8888         * breakpoint.c: Include "mi/mi-out.h".
8889         (print_one_breakpoint): Change output syntax if using MI version
8890         >= 3.
8891         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8892         New.
8893         (mi_multi_location_breakpoint_output_fixed): New.
8894         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8895         (mi_cmd_fix_multi_location_breakpoint_output): New.
8896         (mi_multi_location_breakpoint_output_fixed): New.
8897         * mi/mi-cmds.c (mi_cmds): Register command
8898         -fix-multi-location-breakpoint-output.
8899         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8900         interpreter "mi".
8901
8902 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8903
8904         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8905         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8906         instantiate mi_ui_out based on interpreter name.
8907         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8908         * mi/mi-main.c (mi_load_progress): Likewise.
8909
8910 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8911
8912         * NEWS: Combine separate "New targets" sections for 8.3.
8913
8914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8915
8916         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8917         (ppcfbsd_init_abi): Install gdbarch
8918         "fetch_tls_load_module_address" and "get_thread_local_address"
8919         methods.
8920
8921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8922
8923         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8924         (riscv_fbsd_init_abi): Install gdbarch
8925         "fetch_tls_load_module_address" and "get_thread_local_address"
8926         methods.
8927
8928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8929
8930         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8931         (i386fbsd_init_abi): Install gdbarch
8932         "fetch_tls_load_module_address" and "get_thread_local_address"
8933         methods.
8934
8935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8936
8937         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8938         (amd64fbsd_init_abi): Install gdbarch
8939         "fetch_tls_load_module_address" and "get_thread_local_address"
8940         methods.
8941
8942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8943
8944         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8945         (struct fbsd_pspace_data): New type.
8946         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8947         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8948         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8949         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8950         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8951
8952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8953
8954         * gdbtypes.c (lookup_struct_elt): New function.
8955         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8956         * gdbtypes.h (struct struct_elt): New type.
8957         (lookup_struct_elt): New prototype.
8958
8959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8960
8961         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8962         remove disabled code block.
8963
8964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8965
8966         * gdbarch.sh (get_thread_local_address): New method.
8967         * gdbarch.h, gdbarch.c: Regenerate.
8968         * target.c (target_translate_tls_address): Use
8969         gdbarch_get_thread_local_address if present instead of
8970         target::get_thread_local_address.
8971
8972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8973
8974         * target.h (target::get_thread_local_address): Update comment.
8975
8976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8977
8978         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8979         objfile->separate_debug_objfile_backlink if not NULL.
8980
8981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8982
8983         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8984         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8985         (amd64bsd_store_inferior_registers): Likewise.
8986         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8987         Enable segment base registers.
8988         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8989         PT_GETFSBASE and PT_GETGSBASE.
8990         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8991         PT_SETGSBASE.
8992         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8993         segment base registers.
8994         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8995
8996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8997
8998         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8999         Update calls to i386_target_description to add 'segments'
9000         parameter.
9001         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9002         add segment base registers.
9003         * arch/i386.c (i386_create_target_description): Add 'segments'
9004         parameter to enable segment base registers.
9005         * arch/i386.h (i386_create_target_description): Likewise.
9006         * features/i386/32bit-segments.xml: New file.
9007         * features/i386/32bit-segments.c: Generate.
9008         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9009         call to i386_target_description to add 'segments' parameter.
9010         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9011         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9012         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9013         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9014         if feature is present.
9015         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9016         Add 'segments' parameter to call to i386_target_description.
9017         (i386_target_description): Add 'segments' parameter to enable
9018         segment base registers.
9019         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9020         to call to i386_target_description.
9021         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9022         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9023         Define I386_NUM_REGS.
9024         (i386_target_description): Add 'segments' parameter to enable
9025         segment base registers.
9026
9027 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9028
9029         PR/24325
9030         * source-cache.c: #undef open and close, to avoid unresolved
9031         externals during linking.
9032
9033 2019-03-12  Tom Tromey  <tromey@adacore.com>
9034
9035         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9036         const.  Add initializers.
9037         (_initialize_remote): Don't initialize ptid globals.
9038
9039 2019-03-12  Pedro Alves  <palves@redhat.com>
9040
9041         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9042
9043 2019-03-12  Pedro Alves  <palves@redhat.com>
9044
9045         * cp-name-parser.y (main): Remove unused 'len' variable.
9046
9047 2019-03-12  Tom Tromey  <tromey@adacore.com>
9048
9049         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9050         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9051
9052 2019-03-12  Tom Tromey  <tromey@adacore.com>
9053
9054         * linux-nat.c (iterate_over_lwps): Update.
9055         (stop_callback): Remove parameter.
9056         (stop_wait_callback, detach_callback, resume_set_callback)
9057         (select_singlestep_lwp_callback, set_ignore_sigint)
9058         (status_callback, resumed_callback, resume_clear_callback)
9059         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9060         data parameter.
9061         (linux_nat_target::detach, linux_nat_target::resume)
9062         (linux_stop_and_wait_all_lwps, select_event_lwp)
9063         (linux_nat_filter_event, linux_nat_wait_1)
9064         (linux_nat_target::kill, linux_nat_target::stop)
9065         (linux_nat_target::stop): Update.
9066         (linux_nat_resume_callback): Change type.
9067         (resume_stopped_resumed_lwps, count_events_callback)
9068         (select_event_lwp_callback): Likewise.
9069         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9070         * arm-linux-nat.c (struct update_registers_data): Remove.
9071         (update_registers_callback): Change type.
9072         (arm_linux_insert_hw_breakpoint1): Update.
9073         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9074         parameter.
9075         (x86_linux_dr_set_addr): Update.
9076         (x86_linux_dr_set_control): Update.
9077         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9078         (iterate_over_lwps): Use gdb::function_view.
9079         * nat/aarch64-linux-hw-point.c (struct
9080         aarch64_dr_update_callback_param): Remove.
9081         (debug_reg_change_callback): Change type.
9082         (aarch64_notify_debug_reg_change): Update.
9083         * s390-linux-nat.c (s390_refresh_per_info): Update.
9084
9085 2019-03-11  Tom Tromey  <tromey@adacore.com>
9086
9087         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9088         redundant assignment to "this_cu".
9089
9090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9091
9092         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9093
9094 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9095
9096         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9097         from...
9098         (rank_one_type): ... this.
9099
9100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9101
9102         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9103         from...
9104         (rank_one_type): ... this.
9105
9106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9107
9108         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9109         from...
9110         (rank_one_type): ... this.
9111
9112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9113
9114         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9115         from...
9116         (rank_one_type): ... this.
9117
9118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9119
9120         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9121         from...
9122         (rank_one_type): ... this.
9123
9124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9125
9126         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9127         from...
9128         (rank_one_type): ... this.
9129
9130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9131
9132         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9133         from...
9134         (rank_one_type): ... this.
9135
9136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9137
9138         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9139         from...
9140         (rank_one_type): ... this.
9141
9142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9143
9144         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9145         from...
9146         (rank_one_type): ... this.
9147
9148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9149
9150         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9151         from...
9152         (rank_one_type): ... this.
9153
9154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9155
9156         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9157         from...
9158         (rank_one_type): ... this.
9159
9160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9161
9162         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9163         from...
9164         (rank_one_type): ... this.
9165
9166 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9167
9168         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9169         inferior-events' shows the example events.
9170
9171 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9172
9173         Support styling on native MS-Windows console
9174
9175         PR/24315
9176         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9177         on MS-Windows if $TERM is not defined.
9178
9179         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9180
9181         * posix-hdep.c (gdb_console_fputs):
9182         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9183         functions.
9184         * ui-file.h (gdb_console_fputs): Add prototype.
9185
9186         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9187         back to fputs only if the former returns zero.
9188
9189 2019-03-07  Tom Tromey  <tom@tromey.com>
9190
9191         * symmisc.c (print_symbol_bcache_statistics): Update.
9192         (print_objfile_statistics): Update.
9193         * symfile.c (allocate_symtab): Update.
9194         * stabsread.c: Don't include bcache.h.
9195         * psymtab.h (struct psymbol_bcache): Don't declare.
9196         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9197         (psymbol_bcache_init, psymbol_bcache_free)
9198         (psymbol_bcache_get_bcache): Don't declare.
9199         * psymtab.c (struct psymbol_bcache): Remove.
9200         (psymtab_storage::psymtab_storage): Update.
9201         (psymtab_storage::~psymtab_storage): Update.
9202         (psymbol_bcache_init, psymbol_bcache_free)
9203         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9204         (add_psymbol_to_bcache): Update.
9205         (allocate_psymtab): Update.
9206         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9207         macro_cache>: No longer pointers.
9208         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9209         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9210         * macrotab.c (macro_bcache): Update.
9211         * macroexp.c: Don't include bcache.h.
9212         * gdbtypes.c (check_types_worklist): Update.
9213         (types_deeply_equal): Remove TRY/CATCH.  Update.
9214         * elfread.c (elf_symtab_read): Update.
9215         * dwarf2read.c: Don't include bcache.h.
9216         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9217         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9218         (print_bcache_statistics, bcache_memory_used): Don't declare.
9219         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9220         methods.  Rename all data members.
9221         * bcache.c (struct bcache): Move to bcache.h.
9222         (bcache::expand_hash_table): Rename from expand_hash_table.
9223         (bcache): Remove.
9224         (bcache::insert): Rename from bcache_full.
9225         (bcache::compare): Rename from bcache_compare.
9226         (bcache_xmalloc): Remove.
9227         (bcache::~bcache): Rename from bcache_xfree.
9228         (bcache::print_statistics): Rename from print_bcache_statistics.
9229         (bcache::memory_used): Rename from bcache_memory_used.
9230
9231 2019-03-07  Pedro Alves  <palves@redhat.com>
9232
9233         * infrun.c (normal_stop): Also check for
9234         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9235
9236 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9237
9238         * f-lang.c (value_from_host_double): Moved to...
9239         * value.c (value_from_host_double): ...here.
9240         * value.h (value_from_host_double): Declare.
9241         * guile/scm-math.c (vlscm_convert_typed_number): Use
9242         value_from_host_double.
9243         (vlscm_convert_number): Likewise.
9244         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9245         * python/py-value.c (convert_value_from_python): Likewise.
9246
9247 2019-03-06  Tom Tromey  <tom@tromey.com>
9248
9249         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9250
9251 2019-03-06  Tom Tromey  <tom@tromey.com>
9252
9253         * utils.h (free_current_contents): Don't declare.
9254         * utils.c (free_current_contents): Remove.
9255
9256 2019-03-06  Tom Tromey  <tom@tromey.com>
9257
9258         * top.c (quit_force): Update.
9259         * main.c (captured_command_loop): Update.
9260         * common/new-op.c (operator new): Update.
9261         * common/common-exceptions.c (struct catcher)
9262         <save_cleanup_chain>: Remove member.
9263         (exceptions_state_mc_init): Update.
9264         (exception_try_scope_entry): Return nullptr.
9265         (exception_try_scope_exit, exception_rethrow)
9266         (throw_exception_sjlj, throw_exception_cxx): Update.
9267         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9268         (all_cleanups, do_cleanups, discard_cleanups)
9269         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9270         (restore_cleanups, restore_final_cleanups): Don't declare.
9271         (do_final_cleanups): Remove parameter.
9272         * common/cleanups.c (cleanup_chain, make_cleanup)
9273         (make_cleanup_dtor, all_cleanups, do_cleanups)
9274         (discard_my_cleanups, discard_cleanups)
9275         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9276         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9277         (null_cleanup): Remove.
9278         (do_final_cleanups): Remove parameter.
9279
9280 2019-03-06  Tom Tromey  <tom@tromey.com>
9281
9282         * remote.c (remote_target::remote_parse_stop_reply): Use
9283         unique_xmalloc_ptr.
9284
9285 2019-03-06  Tom Tromey  <tom@tromey.com>
9286
9287         * stabsread.c (struct stabs_field_info): Rename from field_info.
9288         <list, fnlist>: Add initializers.
9289         <obstack>: New member.
9290         (read_member_functions, read_struct_fields, read_baseclasses):
9291         Allocate on obstack.  Don't use cleanups.
9292         (read_one_struct_field, read_member_functions, read_struct_fields)
9293         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9294         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9295         (read_struct_type): Update.
9296
9297 2019-03-06  Tom Tromey  <tom@tromey.com>
9298
9299         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9300         * common/filestuff.h (make_cleanup_close): Don't declare.
9301         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9302         Remove.
9303
9304 2019-03-06  Tom Tromey  <tom@tromey.com>
9305
9306         * solib-aix.c: Use make_scope_exit.
9307
9308 2019-03-06  Tom Tromey  <tom@tromey.com>
9309
9310         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9311         Use make_scope_exit.
9312
9313 2019-03-06  Tom Tromey  <tom@tromey.com>
9314
9315         * solib-svr4.c (disable_probes_interface): Remove parameter.
9316         (svr4_handle_solib_event): Use make_scope_exit.
9317
9318 2019-03-06  Tom Tromey  <tom@tromey.com>
9319
9320         * remote.c (struct stop_reply_deleter): Remove.
9321         (stop_reply_up): Update.
9322         (struct stop_reply): Derive from notif_event.  Don't typedef.
9323         <regcache>: Now a std::vector.
9324         (stop_reply_xfree): Remove.
9325         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9326         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9327         (remote_target::discard_pending_stop_replies): Use delete.
9328         (remote_target::remote_parse_stop_reply): Update.
9329         (remote_target::process_stop_reply): Update.
9330         * remote-notif.h (struct notif_event): Add virtual destructor.
9331         Remove "dtr" member.
9332         (struct notif_client) <alloc_event>: Return a unique_ptr.
9333         (notif_event_xfree): Don't declare.
9334         (notif_event_up): New typedef.
9335         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9336         (notif_event_xfree, do_notif_event_xfree): Remove.
9337         (remote_notif_state_xfree): Update.
9338
9339 2019-03-06  Tom Tromey  <tom@tromey.com>
9340
9341         * infrun.c (displaced_step_clear_cleanup): Now a
9342         forward_scope_exit type.
9343         (displaced_step_prepare_throw): Update.
9344         (displaced_step_fixup): Update.
9345
9346 2019-03-06  Tom Tromey  <tom@tromey.com>
9347
9348         * inferior.h (class inferior): Update comment.
9349         * gdbthread.h (class thread_info): Update comment.
9350
9351 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9352             Tom Tromey  <tom@tromey.com>
9353
9354         * stabsread.h (struct stab_section_list): Remove.
9355         (coffstab_build_psymtabs): Update.
9356         * dbxread.c (symbuf_sections): Now a std::vector.
9357         (sect_idx): New global.
9358         (fill_symbuf): Update.
9359         (coffstab_build_psymtabs): Change type of stabsects parameter.
9360         Update.
9361         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9362         std::vector.
9363         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9364         (coff_locate_sections): Update.
9365         (coff_symfile_read): Remove cleanups.  Update.
9366         (init_stringtab): Add storage parameter.
9367         (free_stringtab, free_stringtab_cleanup): Remove.
9368         (init_lineno): Add storage parameter.
9369         (free_linetab, free_linetab_cleanup): Remove.
9370
9371 2019-03-06  Pedro Alves  <palves@redhat.com>
9372
9373         * linux-fork.c (fork_info::clobber_regs): Delete.
9374         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9375         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9376         comment.  Adjust.
9377         (scoped_switch_fork_info::scoped_switch_fork_info)
9378         (checkpoint_command, linux_fork_context): Adjust
9379         fork_save_infrun_state calls.
9380
9381 2019-03-06  Pedro Alves  <palves@redhat.com>
9382
9383         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9384         (inf_has_multiple_threads): Return 'bool' and rewrite using
9385         inferior_info::threads().
9386
9387 2019-03-06  Pedro Alves  <palves@redhat.com>
9388
9389         * linux-fork.c: Include <list>.
9390         (fork_list): Now a std::list instance.
9391         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9392         (forks_exist_p, find_last_fork): Adjust.
9393         (new_fork): Delete.
9394         (one_fork_p): New.
9395         (add_fork): Adjust.
9396         (free_fork): Delete, folded into fork_info::~fork_info().
9397         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9398         Adjust.
9399         (init_fork_list): Delete.
9400         (linux_fork_killall, linux_fork_mourn_inferior)
9401         (linux_fork_detach, info_checkpoints_command): Adjust.
9402         (_initialize_linux_fork): No longer call init_fork_list.
9403
9404 2019-03-06  Pedro Alves  <palves@redhat.com>
9405
9406         * linux-fork.c (new_fork): New, split out of ...
9407         (add_fork): ... this.  Return void.  Move "first fork" special
9408         case from here, to ...
9409         (checkpoint_command): ... here.
9410         * linux-linux.h (add_fork): Return void.
9411
9412 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9413
9414         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9415
9416 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9417             Chris January  <chris.january@arm.com>
9418             David Lecomber  <david.lecomber@arm.com>
9419
9420         * f-exp.y: New token, UNOP_INTRINSIC.
9421         (exp): New pattern using UNOP_INTRINSIC token.
9422         (f77_keywords): Add 'abs' keyword.
9423         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9424         (value_from_host_double): New function.
9425         (evaluate_subexp_f): Support UNOP_ABS.
9426
9427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9430         types.
9431
9432 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9433
9434         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9435         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9436         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9437
9438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9439
9440         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9441
9442 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9443             Chris January  <chris.january@arm.com>
9444
9445         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9446         * f-exp.y: Define 'KIND' token.
9447         (exp): New pattern for KIND expressions.
9448         (ptype): Handle types with a kind extension.
9449         (direct_abs_decl): Extend to spot kind extensions.
9450         (f77_keywords): Add 'kind' to the list.
9451         (push_kind_type): New function.
9452         (convert_to_kind_type): New function.
9453         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9454         * parse.c (operator_length_standard): Likewise.
9455         * parser-defs.h (enum type_pieces): Add tp_kind.
9456         * std-operator.def: Add UNOP_KIND.
9457
9458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9459
9460         * f-exp.y (f_parse): Set yydebug.
9461
9462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9463
9464         * f-lang.c (evaluate_subexp_f): New function.
9465         (exp_descriptor_f): New global.
9466         (f_language_defn): Use exp_descriptor_f instead of
9467         exp_descriptor_standard.
9468
9469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9470
9471         * f-exp.y (struct token): Add comments.
9472         (dot_ops): Remove uppercase versions and the end marker.
9473         (f77_keywords): Likewise.
9474         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9475         entries in the dot_ops array are case insensitive, and use
9476         strncasecmp to compare strings.  Also some whitespace cleanup in
9477         this area.  Similar for the f77_keywords array, except entries in
9478         this list might be case sensitive.
9479
9480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9481
9482         * f-exp.y (struct f77_boolean_val): Add comments.
9483         (boolean_values): Remove uppercase versions, and end marker.
9484         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9485         and use strncasecmp to achieve case insensitivity.  Additionally,
9486         perform whitespace cleanup around this code.
9487
9488 2019-03-06  Tom Tromey  <tromey@adacore.com>
9489
9490         * remote-sim.c (gdbsim_target_open): Use result of
9491         gdb_argv::release.
9492
9493 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9494         Dirk Schubert  <dirk.schubert@arm.com>
9495         Chris January  <chris.january@arm.com>
9496
9497         * eval.c (evaluate_subexp_standard): Call Fortran argument
9498         wrapping logic.
9499         * f-lang.c (struct value): A value which can be passed into a
9500         Fortran function call.
9501         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9502         where appropriate.
9503         (struct type): Value ready for a Fortran function call.
9504         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9505         is needed.
9506         * f-lang.h (fortran_argument_convert): Declaration.
9507         (fortran_preserve_arg_pointer): Declaration.
9508         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9509
9510 2019-03-05  Tom Tromey  <tromey@adacore.com>
9511
9512         * python/py-prettyprint.c (print_string_repr): Remove #if.
9513         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9514
9515 2019-03-05  Tom Tromey  <tromey@adacore.com>
9516
9517         * target.c (the_dummy_target): Move later.  Change type to
9518         "dummy_target".
9519         (initialize_targets): Don't initialize the_dummy_target.
9520
9521 2019-03-05  Tom Tromey  <tromey@adacore.com>
9522
9523         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9524         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9525
9526 2019-03-05  Tom Tromey  <tromey@adacore.com>
9527
9528         * windows-nat.c (windows_nat_target::attach)
9529         (windows_nat_target::detach): Don't call gdb_flush.
9530         * valprint.c (generic_val_print, val_print, val_print_string):
9531         Don't call gdb_flush.
9532         * utils.c (defaulted_query): Don't call gdb_flush.
9533         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9534         * target.c (target_announce_detach): Don't call gdb_flush.
9535         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9536         * remote.c (extended_remote_target::attach): Don't call
9537         gdb_flush.
9538         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9539         * printcmd.c (do_examine): Don't call gdb_flush.
9540         (info_display_command): Don't call gdb_flush.
9541         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9542         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9543         * memattr.c (info_mem_command): Don't call gdb_flush.
9544         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9545         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9546         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9547         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9548         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9549         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9550         (gnu_nat_target::detach): Don't call gdb_flush.
9551         * f-valprint.c (f_val_print): Don't call gdb_flush.
9552         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9553         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9554         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9555         gdb_flush.
9556         * c-valprint.c (c_val_print): Don't call gdb_flush.
9557         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9558
9559 2019-03-05  Tom Tromey  <tromey@adacore.com>
9560
9561         * varobj.c (update_dynamic_varobj_children): Update.
9562         (install_default_visualizer): Use reset, not release.
9563         * value.c (set_internalvar): Update.
9564         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9565         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9566         ATTRIBUTE_UNUSED_RESULT.
9567
9568 2019-03-05  Tom Tromey  <tromey@adacore.com>
9569
9570         * remote.c (class scoped_remote_fd) <release>: Add
9571         ATTRIBUTE_UNUSED_RESULT.
9572
9573 2019-03-05  Tom Tromey  <tromey@adacore.com>
9574
9575         * macroexp.c (struct macro_buffer) <release>: Add
9576         ATTRIBUTE_UNUSED_RESULT.
9577
9578 2019-03-05  Tom Tromey  <tromey@adacore.com>
9579
9580         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9581         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9582         ATTRIBUTE_UNUSED_RESULT.
9583
9584 2019-03-05  Tom Tromey  <tromey@adacore.com>
9585
9586         * common/scoped_fd.h (class scoped_fd) <release>: Add
9587         ATTRIBUTE_UNUSED_RESULT.
9588
9589 2019-03-05  Tom Tromey  <tromey@adacore.com>
9590
9591         * parser-defs.h (struct parser_state) <release>: Add
9592         ATTRIBUTE_UNUSED_RESULT.
9593
9594 2019-03-05  Tom Tromey  <tromey@adacore.com>
9595
9596         * utils.h (class gdb_argv) <release>: Add
9597         ATTRIBUTE_UNUSED_RESULT.
9598         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9599
9600 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9601
9602         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9603         for-loop range, to avoid compiler warnings.
9604
9605         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9606         avoid compiler warnings about unused variables.
9607
9608         * NEWS: Mention end of support for native debugging on MS-Windows
9609         before XP.
9610
9611         PR gdb/24292
9612         * common/netstuff.c:
9613         * gdbserver/gdbreplay.c
9614         * gdbserver/remote-utils.c:
9615         * ser-tcp.c:
9616         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9617         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9618         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9619         'getaddrinfo' and 'freeaddrinfo' were not available before
9620         Windows XP, and mingw.org's MinGW headers by default define
9621         _WIN32_WINNT to 0x500.
9622
9623 2019-03-01  Gary Benson <gbenson@redhat.com>
9624
9625         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9626
9627 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9628             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9629
9630         PR gdb/8527
9631         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9632         set_sigint_trap, clear_sigint_trap.
9633
9634 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9635
9636         * target.c (target_detach): Clear the regcache and the
9637         frame cache.
9638
9639 2019-02-27  Pedro Alves  <palves@redhat.com>
9640
9641         * utils.c (set_screen_size): When we cap the height/width sizes,
9642         tweak the corresponding command variable to show "unlimited":
9643
9644 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9645             Pedro Alves  <palves@redhat.com>
9646
9647         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9648         before calling rl_set_screen_size.
9649
9650 2019-02-27  Tom Tromey  <tromey@adacore.com>
9651
9652         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9653         define.
9654         * python/py-value.c: Remove Python 2.4 workaround.
9655         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9656         workaround.
9657         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9658         Python 2.4 workaround.
9659         * python/python-internal.h: Remove Python 2.4 comment.
9660         (Py_ssize_t): Don't define.
9661         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9662         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9663         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9664         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9665         * python/python.c (do_start_initialization): Remove Python 2.4
9666         workaround.
9667         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9668         (print_children): Remove Python 2.4 workaround.
9669         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9670         workaround.
9671         (CHARBUFFERPROC_NAME): Remove.
9672         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9673         Python 2.4 workaround.
9674
9675 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9676
9677         * NEWS: Note minimum Python version.
9678
9679 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9680
9681         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9682         code from these functions.  Remove corresponding ifdefs.  Use
9683         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9684         Remove gotos and target of gotos.
9685         (infpy_search_memory): Likewise.
9686
9687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9688
9689         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9690         (hppa_gdbarch_init): Don't register deleted functions with
9691         gdbarch.
9692
9693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9694
9695         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9696         (h8300_unwind_sp): Delete.
9697         (h8300_dummy_id): Delete.
9698         (h8300_gdbarch_init): Don't register deleted functions with
9699         gdbarch.
9700
9701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9702
9703         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9704         (ft32_unwind_pc): Delete.
9705         (ft32_unwind_sp): Delete.
9706         (ft32_gdbarch_init): Don't register deleted functions with
9707         gdbarch.
9708
9709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9710
9711         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9712         (frv_unwind_pc): Delete.
9713         (frv_unwind_sp): Delete.
9714         (frv_gdbarch_init): Don't register deleted functions with
9715         gdbarch.
9716
9717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9718
9719         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9720         (riscv_unwind_pc): Delete.
9721         (riscv_unwind_sp): Delete.
9722         (riscv_gdbarch_init): Don't register deleted functions with
9723         gdbarch.
9724
9725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9726
9727         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9728         (csky_unwind_pc): Delete.
9729         (csky_unwind_sp): Delete.
9730         (csky_gdbarch_init): Don't register deleted functions with
9731         gdbarch.
9732
9733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9734
9735         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9736         (cris_unwind_pc): Delete.
9737         (cris_unwind_sp): Delete.
9738         (cris_gdbarch_init): Don't register deleted functions with
9739         gdbarch.
9740
9741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9742
9743         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9744         (bfin_unwind_pc): Delete.
9745         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9746
9747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9748
9749         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9750         (arm_unwind_pc): Delete.
9751         (arm_unwind_sp): Delete.
9752         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9753
9754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9755
9756         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9757         (arc_unwind_pc): Delete.
9758         (arc_unwind_sp): Delete.
9759         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9760
9761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9762
9763         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9764         (alpha_unwind_pc): Delete.
9765         (alpha_gdbarch_init): Don't register deleted functions with
9766         gdbarch.
9767
9768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9769
9770         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9771         (aarch64_unwind_pc): Delete.
9772         (aarch64_unwind_sp): Delete.
9773         (aarch64_gdbarch_init): Don't register deleted functions with
9774         gdbarch.
9775
9776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * gdbtypes.c (type_align): Don't consider static members when
9779         computing structure alignment.
9780
9781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9782
9783         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9784         return 0 for other types.
9785         * arch-utils.c (default_type_align): Always return 0.
9786         * gdbarch.h: Regenerate.
9787         * gdbarch.sh (type_align): Extend comment.
9788         * gdbtypes.c (type_align): Add additional comments, always call
9789         gdbarch_type_align before applying the default rules.
9790         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9791         generic code will then apply a suitable default.
9792         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9793         types, return 0 for other types.
9794
9795 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9796
9797         * NEWS: Create a new section for the next release branch.
9798         Rename the section of the current branch, now that it has
9799         been cut.
9800
9801 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9802
9803         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9804         * version.in: Bump version to 8.3.50.DATE-git.
9805
9806 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9807
9808         * aix-thread.c (ptid_cmp): Remove unused variable.
9809         (get_signaled_thread): Likewise.
9810         (store_regs_user_thread): Likewise.
9811         (store_regs_kernel_thread): Likewise.
9812         (fetch_regs_kernel_thread): Remove shadowed variable.
9813
9814 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9815
9816         * features/riscv/32bit-cpu.xml: Add register numbers.
9817         * features/riscv/32bit-fpu.c: Regenerate.
9818         * features/riscv/32bit-fpu.xml: Add register numbers.
9819         * features/riscv/64bit-cpu.xml: Add register numbers.
9820         * features/riscv/64bit-fpu.c: Regenerate.
9821         * features/riscv/64bit-fpu.xml: Add register numbers.
9822
9823 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9824
9825         * NEWS: Mention two argument form of gdb.Value constructor.
9826         * python/py-value.c (convert_buffer_and_type_to_value): New
9827         function.
9828         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9829         Add support for handling an optional second argument.  Call
9830         convert_buffer_and_type_to_value as appropriate.
9831         * python/python-internal.h (Py_buffer_deleter): New struct.
9832         (Py_buffer_up): New typedef.
9833
9834 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9835
9836         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9837         instead of releasing ownership.
9838
9839 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9840
9841         * dwarf2read.c (open_and_init_dwp_file): Call
9842         elf_numsections instead of bfd_count_sections to initialize
9843         dwp_file->num_sections.
9844
9845 2019-02-25  Tom Tromey  <tromey@adacore.com>
9846
9847         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9848
9849 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9850
9851         * gcore.in: Add '--readnever' option when invoking GDB.
9852
9853 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9854
9855         * MAINTAINERS: Update my email address.
9856
9857 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9858
9859         * build-id.c (build_id_to_debug_bfd_1): New function.
9860         (build_id_to_debug_bfd): Look for separate debug file in
9861         sysroot.
9862
9863 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9864
9865         * gdbarch.sh: Update the copyright year range that is placed into
9866         generated files.
9867
9868 2019-02-22  Keith Seitz  <keiths@redhat.com>
9869
9870         PR symtab/23853
9871         * linespec.c (create_sals_line_offset): Search for the default
9872         symtab's filename instead of its fullname.
9873
9874 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9875
9876         * NEWS: Update style defaults.
9877
9878 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9879
9880         * main.c (captured_main_1): Disable styling in batch mode.
9881
9882 2019-02-20  Tom Tromey  <tom@tromey.com>
9883
9884         * symtab.c (symtab_symbol_info): Fix typos.
9885
9886 2019-02-20  Tom Tromey  <tromey@adacore.com>
9887
9888         * findcmd.c (_initialize_mem_search): Use upper case for
9889         metasyntactic variables.
9890
9891 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9892
9893         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9894         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9895
9896 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9897
9898         * top.h (source_file_name): Change to std::string.
9899         * top.c (source_file_name): Likewise.
9900         (command_line_input): Adjust.
9901         * cli/cli-script.c (script_from_file): Adjust.
9902
9903 2019-02-19  Tom Tromey  <tromey@adacore.com>
9904
9905         * ravenscar-thread.c
9906         (ravenscar_thread_target::update_thread_list): Don't call
9907         ada_build_task_list.
9908         * ada-lang.h (ada_build_task_list): Don't declare.
9909         * ada-tasks.c (struct ada_tasks_inferior_data)
9910         <task_list_valid_p>: Now bool.
9911         (read_known_tasks, ada_task_list_changed)
9912         (ada_tasks_invalidate_inferior_data): Update.
9913         (read_known_tasks_array): Return bool.
9914         (read_known_tasks_list): Likewise.
9915         (read_known_tasks): Return void.
9916         (ada_build_task_list): Now static.
9917
9918 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9919
9920         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9921         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9922
9923 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9924
9925         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9926         variant for ada_tasks_pspace_data_handle and
9927         ada_tasks_inferior_data_handle.
9928         (ada_tasks_pspace_data_cleanup): New function.
9929         (ada_tasks_inferior_data_cleanup): New function.
9930
9931 2019-02-17  Tom Tromey  <tom@tromey.com>
9932
9933         * macrotab.h (macro_source_fullname): Return a std::string.
9934         * macrotab.c (macro_include, check_for_redefinition)
9935         (macro_undef, macro_lookup_definition, foreach_macro)
9936         (foreach_macro_in_scope): Update.
9937         (macro_source_fullname): Return a std::string.
9938         * macrocmd.c (show_pp_source_pos): Update.
9939
9940 2019-02-17  Tom Tromey  <tom@tromey.com>
9941
9942         * macrocmd.c (show_pp_source_pos): Style the file names.
9943
9944 2019-02-17  Tom Tromey  <tom@tromey.com>
9945
9946         PR tui/24197:
9947         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9948
9949 2019-02-17  Tom Tromey  <tom@tromey.com>
9950
9951         * ada-lang.c (user_select_syms): Use filtered printing.
9952         * utils.c (wrap_style): New global.
9953         (desired_style): Remove.
9954         (emit_style_escape): Add stream parameter.
9955         (set_output_style, reset_terminal_style, prompt_for_continue):
9956         Update.
9957         (flush_wrap_buffer): Only flush gdb_stdout.
9958         (wrap_here): Set wrap_style.
9959         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9960         treat escape sequences as a character.  Change when wrap buffer is
9961         flushed.
9962         (fputs_styled): Do not set the output style when the default is
9963         requested.
9964         * ui-style.h (struct ui_file_style) <is_default>: New method.
9965         * source.c (print_source_lines_base): Emit escape sequences in one
9966         piece.
9967
9968 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9969
9970         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9971         integers and enumeration types.
9972
9973 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9974
9975         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9976         instead of lookup_symbol_in_language
9977         (do_exact_match): New function.
9978         (ada_get_symbol_name_matcher): Return do_exact_match when
9979         doing a verbatim match.
9980
9981 2019-02-15  Tom Tromey  <tromey@adacore.com>
9982
9983         * ravenscar-thread.c (ravenscar_thread_target::resume)
9984         (ravenscar_thread_target::wait): Special case wildcard requests.
9985
9986 2019-02-15  Tom Tromey  <tromey@adacore.com>
9987
9988         * ravenscar-thread.c (base_ptid): Remove.
9989         (struct ravenscar_thread_target) <close>: New method.
9990         <m_base_ptid>: New member.
9991         <update_inferior_ptid, active_task, task_is_currently_active,
9992         runtime_initialized>: Declare methods.
9993         <ravenscar_thread_target>: Add constructor.
9994         (ravenscar_thread_target::task_is_currently_active)
9995         (ravenscar_thread_target::update_inferior_ptid)
9996         (ravenscar_runtime_initialized): Rename.  Now methods.
9997         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9998         (ravenscar_thread_target::update_thread_list): Update.
9999         (ravenscar_thread_target::active_task): Now method.
10000         (ravenscar_thread_target::store_registers)
10001         (ravenscar_thread_target::prepare_to_store)
10002         (ravenscar_thread_target::prepare_to_store)
10003         (ravenscar_thread_target::mourn_inferior): Update.
10004         (ravenscar_inferior_created): Use "new" to create target.
10005         (ravenscar_thread_target::get_ada_task_ptid): Update.
10006         (_initialize_ravenscar): Don't initialize base_ptid.
10007         (ravenscar_ops): Remove global.
10008
10009 2019-02-15  Tom Tromey  <tromey@adacore.com>
10010
10011         * target.h (push_target): Declare new overload.
10012         * target.c (push_target): New overload, taking an rvalue reference.
10013         * remote.c (remote_target::open_1): Use push_target overload.
10014         * corelow.c (core_target_open): Use push_target overload.
10015
10016 2019-02-15  Tom Tromey  <tromey@adacore.com>
10017
10018         * ravenscar-thread.c (is_ravenscar_task)
10019         (ravenscar_task_is_currently_active): Return bool.
10020         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10021         (_initialize_ravenscar): Remove "(void)".
10022         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10023         Return bool.
10024
10025 2019-02-15  Tom Tromey  <tromey@adacore.com>
10026
10027         * ravenscar-thread.c (ravenscar_runtime_initializer)
10028         (has_ravenscar_runtime, get_running_thread_id)
10029         (ravenscar_thread_target::resume): Fix indentation.
10030
10031 2019-02-15  Tom Tromey  <tromey@adacore.com>
10032
10033         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10034         from ravenscar_arch_ops.
10035         (sparc_ravenscar_ops::fetch_registers)
10036         (sparc_ravenscar_ops::store_registers): Now methods.
10037         (sparc_ravenscar_prepare_to_store): Remove.
10038         (sparc_ravenscar_ops): Redefine.
10039         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10040         methods and destructor.  Remove members.
10041         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10042         (ravenscar_thread_target::store_registers)
10043         (ravenscar_thread_target::prepare_to_store): Update.
10044         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10045         Remove.
10046         (struct ppc_ravenscar_powerpc_ops): Derive from
10047         ravenscar_arch_ops.
10048         (ppc_ravenscar_powerpc_ops::fetch_registers)
10049         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10050         (ppc_ravenscar_powerpc_ops): Redefine.
10051         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10052         (ppc_ravenscar_e500_ops::fetch_registers)
10053         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10054         (ppc_ravenscar_e500_ops): Redefine.
10055         * aarch64-ravenscar-thread.c
10056         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10057         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10058         (aarch64_ravenscar_fetch_registers)
10059         (aarch64_ravenscar_store_registers): Now methods.
10060         (aarch64_ravenscar_ops): Redefine.
10061
10062 2019-02-15  Tom Tromey  <tromey@adacore.com>
10063
10064         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10065         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10066         (ravenscar_thread_target::stopped_by_watchpoint)
10067         (ravenscar_thread_target::stopped_data_address)
10068         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10069
10070 2019-02-15  Tom Tromey  <tromey@adacore.com>
10071
10072         * ravenscar-thread.c: Fix some typos.
10073
10074 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10075             Tom Tromey  <tromey@adacore.com>
10076
10077         * ada-lang.c (ada_exception_sal): Change addr_string to a
10078         std::string.
10079         (create_ada_exception_catchpoint): Update.
10080
10081 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10082             Tom Tromey  <tromey@adacore.com>
10083
10084         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10085         (bp_location_ops): Remove.
10086         (base_breakpoint_allocate_location): Update.
10087         (free_bp_location): Update.
10088         * ada-lang.c (class ada_catchpoint_location)
10089         <ada_catchpoint_location>: Remove ops parameter.
10090         (ada_catchpoint_location_dtor): Remove.
10091         (ada_catchpoint_location_ops): Remove.
10092         (allocate_location_exception): Update.
10093         * breakpoint.h (struct bp_location_ops): Remove.
10094         (class bp_location) <bp_location>: Remove bp_location_ops
10095         parameter.
10096         <~bp_location>: Add destructor.
10097         <ops>: Remove.
10098
10099 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10100             Pedro Alves  <palves@redhat.com>
10101
10102         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10103         'PATH_MAX'.
10104
10105 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10106             Samuel Thibault  <samuel.thibault@gnu.org>
10107             Thomas Schwinge  <thomas@codesourcery.com>
10108
10109         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10110         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10111
10112 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10113
10114         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10115         (check_empty): Use "const char *".
10116
10117         * gnu-nat.c (gnu_nat_target::detach): Instead of
10118         'detach_inferior (pid)' call
10119         'detach_inferior (find_inferior_pid (pid))'.
10120
10121         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10122         'nat/fork-inferior.o'.
10123         * gnu-nat.c: #include "nat/fork-inferior.h".
10124
10125         * gnu-nat.c (gnu_nat_target::detach): Instead of
10126         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10127         * gnu-nat.h: #include "inf-child.h".
10128         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10129         'i386_gnu_nat_target::fetch_registers'.
10130         (gnu_store_registers): Rename/move to
10131         'i386_gnu_nat_target::store_registers'.
10132
10133         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10134         * gnu-nat.h (mach_thread_info): New function.
10135         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10136
10137         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10138
10139 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10140
10141         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10142
10143 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10144
10145         * windows-nat.c (windows_add_thread): Add new parameter
10146         "main_thread_p" with default value set to false.  Update
10147         function documentation as well as all callers.
10148         (windows_delete_thread): Likewise.
10149         (fake_create_process): Update call to windows_add_thread.
10150         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10151         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10152         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10153         call to windows_delete_thread.
10154
10155 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10156
10157         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10158
10159 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10160
10161         * symfile.c (find_separate_debug_file): Use canonical path of
10162         sysroot with child_path instead of gdb_sysroot if it is valid.
10163
10164 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10165
10166         * symfile.c (find_separate_debug_file): Use child_path to
10167         determine if an object file is under a sysroot.
10168
10169 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10170
10171         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10172         unittests/child-path-selftests.c.
10173         * common/pathstuff.c (child_path): New function.
10174         * common/pathstuff.h (child_path): New prototype.
10175         * unittests/child-path-selftests.c: New file.
10176
10177 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10178
10179         * symfile.c (find_separate_debug_file): Look for separate debug
10180         files in debug directories under the sysroot.
10181
10182 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10183
10184         * symtab.h (struct minimal_symbol data_p): New const method.
10185         (struct minimal_symbol text_p): Likewise.
10186         * symtab.c (output_source_filename): Use file name style
10187         to print file name.
10188         (print_symbol_info): Likewise.
10189         (print_msymbol_info): Use address style to print addresses.
10190         Use function name style to print executable text symbols.
10191         (expand_symtab_containing_pc): Use data_p.
10192         (find_pc_sect_compunit_symtab): Likewise.
10193
10194 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10195
10196         * breakpoint.c (describe_other_breakpoints): Use address style
10197         to print addresses.
10198         (say_where): Likewise.
10199
10200 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10201
10202         * ada-typeprint.c (print_func_type): Print function name
10203         style to print function name.
10204         * c-typeprint.c (c_print_type_1): Likewise.
10205
10206 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10207
10208         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10209         for execve.
10210
10211 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10212
10213         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10214         type_stack.
10215
10216 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10217
10218         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10219         TYPE_CODE_REF types.
10220
10221 2019-02-08  Jim Wilson  <jimw@sifive.com>
10222
10223         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10224         (riscv_linux_fregset): New.
10225         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10226
10227 2019-02-07  Tom Tromey  <tom@tromey.com>
10228
10229         * thread.c (thread_cancel_execution_command): Update.
10230         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10231         methods.
10232         (struct thread_fsm_ops): Remove.
10233         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10234         (thread_fsm_should_stop, thread_fsm_return_value)
10235         (thread_fsm_set_finished, thread_fsm_finished_p)
10236         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10237         Don't declare.
10238         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10239         * infrun.c (clear_proceed_status_thread)
10240         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10241         (print_stop_event): Update.
10242         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10243         Add constructor.
10244         (step_command_fsm_ops): Remove.
10245         (new_step_command_fsm): Remove.
10246         (step_1): Update.
10247         (step_command_fsm::should_stop): Rename from
10248         step_command_fsm_should_stop.
10249         (step_command_fsm::clean_up): Rename from
10250         step_command_fsm_clean_up.
10251         (step_command_fsm::do_async_reply_reason): Rename from
10252         step_command_fsm_async_reply_reason.
10253         (struct until_next_fsm): Inherit from thread_fsm.  Add
10254         constructor.
10255         (until_next_fsm_ops): Remove.
10256         (new_until_next_fsm): Remove.
10257         (until_next_fsm::should_stop): Rename from
10258         until_next_fsm_should_stop.
10259         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10260         (until_next_fsm::do_async_reply_reason): Rename from
10261         until_next_fsm_async_reply_reason.
10262         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10263         constructor.  Change type of breakpoint.
10264         (finish_command_fsm_ops): Remove.
10265         (new_finish_command_fsm): Remove.
10266         (finish_command_fsm::should_stop): Rename from
10267         finish_command_fsm_should_stop.
10268         (finish_command_fsm::clean_up): Rename from
10269         finish_command_fsm_clean_up.
10270         (finish_command_fsm::return_value): Rename from
10271         finish_command_fsm_return_value.
10272         (finish_command_fsm::do_async_reply_reason): Rename from
10273         finish_command_fsm_async_reply_reason.
10274         (finish_command): Update.
10275         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10276         Add constructor.
10277         (call_thread_fsm_ops): Remove.
10278         (call_thread_fsm::call_thread_fsm): Rename from
10279         new_call_thread_fsm.
10280         (call_thread_fsm::should_stop): Rename from
10281         call_thread_fsm_should_stop.
10282         (call_thread_fsm::should_notify_stop): Rename from
10283         call_thread_fsm_should_notify_stop.
10284         (run_inferior_call, call_function_by_hand_dummy): Update.
10285         * cli/cli-interp.c (should_print_stop_to_console): Update.
10286         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10287         Add constructor.  Change type of location_breakpoint,
10288         caller_breakpoint.
10289         (until_break_fsm_ops): Remove.
10290         (new_until_break_fsm): Remove.
10291         (until_break_fsm::should_stop): Rename from
10292         until_break_fsm_should_stop.
10293         (until_break_fsm::clean_up): Rename from
10294         until_break_fsm_clean_up.
10295         (until_break_fsm::do_async_reply_reason): Rename from
10296         until_break_fsm_async_reply_reason.
10297         (until_break_command): Update.
10298         * thread-fsm.c: Remove.
10299         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10300
10301 2019-02-07  Tom Tromey  <tom@tromey.com>
10302
10303         * yy-remap.h: Add include guard.
10304         * xtensa-tdep.h: Add include guard.
10305         * xcoffread.h: Rename include guard.
10306         * varobj-iter.h: Add include guard.
10307         * tui/tui.h: Rename include guard.
10308         * tui/tui-winsource.h: Rename include guard.
10309         * tui/tui-wingeneral.h: Rename include guard.
10310         * tui/tui-windata.h: Rename include guard.
10311         * tui/tui-win.h: Rename include guard.
10312         * tui/tui-stack.h: Rename include guard.
10313         * tui/tui-source.h: Rename include guard.
10314         * tui/tui-regs.h: Rename include guard.
10315         * tui/tui-out.h: Rename include guard.
10316         * tui/tui-layout.h: Rename include guard.
10317         * tui/tui-io.h: Rename include guard.
10318         * tui/tui-hooks.h: Rename include guard.
10319         * tui/tui-file.h: Rename include guard.
10320         * tui/tui-disasm.h: Rename include guard.
10321         * tui/tui-data.h: Rename include guard.
10322         * tui/tui-command.h: Rename include guard.
10323         * tic6x-tdep.h: Add include guard.
10324         * target/waitstatus.h: Rename include guard.
10325         * target/wait.h: Rename include guard.
10326         * target/target.h: Rename include guard.
10327         * target/resume.h: Rename include guard.
10328         * target-float.h: Rename include guard.
10329         * stabsread.h: Add include guard.
10330         * rs6000-tdep.h: Add include guard.
10331         * riscv-fbsd-tdep.h: Add include guard.
10332         * regformats/regdef.h: Rename include guard.
10333         * record.h: Rename include guard.
10334         * python/python.h: Rename include guard.
10335         * python/python-internal.h: Rename include guard.
10336         * python/py-stopevent.h: Rename include guard.
10337         * python/py-ref.h: Rename include guard.
10338         * python/py-record.h: Rename include guard.
10339         * python/py-record-full.h: Rename include guard.
10340         * python/py-record-btrace.h: Rename include guard.
10341         * python/py-instruction.h: Rename include guard.
10342         * python/py-events.h: Rename include guard.
10343         * python/py-event.h: Rename include guard.
10344         * procfs.h: Add include guard.
10345         * proc-utils.h: Add include guard.
10346         * p-lang.h: Add include guard.
10347         * or1k-tdep.h: Rename include guard.
10348         * observable.h: Rename include guard.
10349         * nto-tdep.h: Rename include guard.
10350         * nat/x86-linux.h: Rename include guard.
10351         * nat/x86-linux-dregs.h: Rename include guard.
10352         * nat/x86-gcc-cpuid.h: Add include guard.
10353         * nat/x86-dregs.h: Rename include guard.
10354         * nat/x86-cpuid.h: Rename include guard.
10355         * nat/ppc-linux.h: Rename include guard.
10356         * nat/mips-linux-watch.h: Rename include guard.
10357         * nat/linux-waitpid.h: Rename include guard.
10358         * nat/linux-ptrace.h: Rename include guard.
10359         * nat/linux-procfs.h: Rename include guard.
10360         * nat/linux-osdata.h: Rename include guard.
10361         * nat/linux-nat.h: Rename include guard.
10362         * nat/linux-namespaces.h: Rename include guard.
10363         * nat/linux-btrace.h: Rename include guard.
10364         * nat/glibc_thread_db.h: Rename include guard.
10365         * nat/gdb_thread_db.h: Rename include guard.
10366         * nat/gdb_ptrace.h: Rename include guard.
10367         * nat/fork-inferior.h: Rename include guard.
10368         * nat/amd64-linux-siginfo.h: Rename include guard.
10369         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10370         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10371         * nat/aarch64-linux.h: Rename include guard.
10372         * nat/aarch64-linux-hw-point.h: Rename include guard.
10373         * mn10300-tdep.h: Add include guard.
10374         * mips-linux-tdep.h: Add include guard.
10375         * mi/mi-parse.h: Rename include guard.
10376         * mi/mi-out.h: Rename include guard.
10377         * mi/mi-main.h: Rename include guard.
10378         * mi/mi-interp.h: Rename include guard.
10379         * mi/mi-getopt.h: Rename include guard.
10380         * mi/mi-console.h: Rename include guard.
10381         * mi/mi-common.h: Rename include guard.
10382         * mi/mi-cmds.h: Rename include guard.
10383         * mi/mi-cmd-break.h: Rename include guard.
10384         * m2-lang.h: Add include guard.
10385         * location.h: Rename include guard.
10386         * linux-record.h: Rename include guard.
10387         * linux-nat.h: Add include guard.
10388         * linux-fork.h: Add include guard.
10389         * i386-darwin-tdep.h: Rename include guard.
10390         * hppa-linux-offsets.h: Add include guard.
10391         * guile/guile.h: Rename include guard.
10392         * guile/guile-internal.h: Rename include guard.
10393         * gnu-nat.h: Rename include guard.
10394         * gdb-stabs.h: Rename include guard.
10395         * frv-tdep.h: Add include guard.
10396         * f-lang.h: Add include guard.
10397         * event-loop.h: Add include guard.
10398         * darwin-nat.h: Rename include guard.
10399         * cp-abi.h: Rename include guard.
10400         * config/sparc/nm-sol2.h: Rename include guard.
10401         * config/nm-nto.h: Rename include guard.
10402         * config/nm-linux.h: Add include guard.
10403         * config/i386/nm-i386gnu.h: Rename include guard.
10404         * config/djgpp/nl_types.h: Rename include guard.
10405         * config/djgpp/langinfo.h: Rename include guard.
10406         * compile/gcc-cp-plugin.h: Add include guard.
10407         * compile/gcc-c-plugin.h: Add include guard.
10408         * compile/compile.h: Rename include guard.
10409         * compile/compile-object-run.h: Rename include guard.
10410         * compile/compile-object-load.h: Rename include guard.
10411         * compile/compile-internal.h: Rename include guard.
10412         * compile/compile-cplus.h: Rename include guard.
10413         * compile/compile-c.h: Rename include guard.
10414         * common/xml-utils.h: Rename include guard.
10415         * common/x86-xstate.h: Rename include guard.
10416         * common/version.h: Rename include guard.
10417         * common/vec.h: Rename include guard.
10418         * common/tdesc.h: Rename include guard.
10419         * common/selftest.h: Rename include guard.
10420         * common/scoped_restore.h: Rename include guard.
10421         * common/scoped_mmap.h: Rename include guard.
10422         * common/scoped_fd.h: Rename include guard.
10423         * common/safe-iterator.h: Rename include guard.
10424         * common/run-time-clock.h: Rename include guard.
10425         * common/refcounted-object.h: Rename include guard.
10426         * common/queue.h: Rename include guard.
10427         * common/ptid.h: Rename include guard.
10428         * common/print-utils.h: Rename include guard.
10429         * common/preprocessor.h: Rename include guard.
10430         * common/pathstuff.h: Rename include guard.
10431         * common/observable.h: Rename include guard.
10432         * common/netstuff.h: Rename include guard.
10433         * common/job-control.h: Rename include guard.
10434         * common/host-defs.h: Rename include guard.
10435         * common/gdb_wait.h: Rename include guard.
10436         * common/gdb_vecs.h: Rename include guard.
10437         * common/gdb_unlinker.h: Rename include guard.
10438         * common/gdb_unique_ptr.h: Rename include guard.
10439         * common/gdb_tilde_expand.h: Rename include guard.
10440         * common/gdb_sys_time.h: Rename include guard.
10441         * common/gdb_string_view.h: Rename include guard.
10442         * common/gdb_splay_tree.h: Rename include guard.
10443         * common/gdb_setjmp.h: Rename include guard.
10444         * common/gdb_ref_ptr.h: Rename include guard.
10445         * common/gdb_optional.h: Rename include guard.
10446         * common/gdb_locale.h: Rename include guard.
10447         * common/gdb_assert.h: Rename include guard.
10448         * common/filtered-iterator.h: Rename include guard.
10449         * common/filestuff.h: Rename include guard.
10450         * common/fileio.h: Rename include guard.
10451         * common/environ.h: Rename include guard.
10452         * common/common-utils.h: Rename include guard.
10453         * common/common-types.h: Rename include guard.
10454         * common/common-regcache.h: Rename include guard.
10455         * common/common-inferior.h: Rename include guard.
10456         * common/common-gdbthread.h: Rename include guard.
10457         * common/common-exceptions.h: Rename include guard.
10458         * common/common-defs.h: Rename include guard.
10459         * common/common-debug.h: Rename include guard.
10460         * common/cleanups.h: Rename include guard.
10461         * common/buffer.h: Rename include guard.
10462         * common/btrace-common.h: Rename include guard.
10463         * common/break-common.h: Rename include guard.
10464         * cli/cli-utils.h: Rename include guard.
10465         * cli/cli-style.h: Rename include guard.
10466         * cli/cli-setshow.h: Rename include guard.
10467         * cli/cli-script.h: Rename include guard.
10468         * cli/cli-interp.h: Rename include guard.
10469         * cli/cli-decode.h: Rename include guard.
10470         * cli/cli-cmds.h: Rename include guard.
10471         * charset-list.h: Add include guard.
10472         * buildsym-legacy.h: Rename include guard.
10473         * bfin-tdep.h: Add include guard.
10474         * ax.h: Rename include guard.
10475         * arm-linux-tdep.h: Add include guard.
10476         * arm-fbsd-tdep.h: Add include guard.
10477         * arch/xtensa.h: Rename include guard.
10478         * arch/tic6x.h: Add include guard.
10479         * arch/i386.h: Add include guard.
10480         * arch/arm.h: Rename include guard.
10481         * arch/arm-linux.h: Rename include guard.
10482         * arch/arm-get-next-pcs.h: Rename include guard.
10483         * arch/amd64.h: Add include guard.
10484         * arch/aarch64-insn.h: Rename include guard.
10485         * arch-utils.h: Rename include guard.
10486         * annotate.h: Add include guard.
10487         * amd64-darwin-tdep.h: Rename include guard.
10488         * aarch64-linux-tdep.h: Add include guard.
10489         * aarch64-fbsd-tdep.h: Add include guard.
10490         * aarch32-linux-nat.h: Add include guard.
10491
10492 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10493
10494         * macrotab.c (macro_define_internal): New function that
10495         factorizes macro_define_object_internal and macro_define_function
10496         code.
10497         (macro_define_object_internal): Use macro_define_internal.
10498         (macro_define_function): Likewise.
10499
10500 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10501
10502         * macrocmd.c (extract_identifier): Return
10503         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10504         callers.
10505
10506 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10507
10508         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10509
10510 2019-02-05  Tom Tromey  <tom@tromey.com>
10511
10512         * target.c (target_stack::unpush): Move assertion earlier.
10513
10514 2019-01-30  Tom Tromey  <tom@tromey.com>
10515
10516         PR python/23615:
10517         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10518         (gdbpy_parse_and_eval): Likewise.
10519         * python/python-internal.h (gdbpy_allow_threads): New class.
10520
10521 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10522
10523         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10524         (aarch64_fbsd_fpregmap): Move earlier.
10525         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10526         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10527         instead of individual calls to trad_frame_set_reg_addr.
10528         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10529         earlier.
10530         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10531         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10532         instead of individual calls to trad_frame_set_reg_addr.
10533
10534 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10535
10536         * CONTRIBUTE: Replace contribution list with wiki link.
10537
10538 2019-01-25  Tom Tromey  <tom@tromey.com>
10539
10540         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10541
10542 2019-01-25  Tom Tromey  <tom@tromey.com>
10543
10544         * xtensa-linux-nat.c: Fix common/ includes.
10545         * xml-support.h: Fix common/ includes.
10546         * xml-support.c: Fix common/ includes.
10547         * x86-linux-nat.c: Fix common/ includes.
10548         * windows-nat.c: Fix common/ includes.
10549         * varobj.h: Fix common/ includes.
10550         * varobj.c: Fix common/ includes.
10551         * value.c: Fix common/ includes.
10552         * valops.c: Fix common/ includes.
10553         * utils.c: Fix common/ includes.
10554         * unittests/xml-utils-selftests.c: Fix common/ includes.
10555         * unittests/utils-selftests.c: Fix common/ includes.
10556         * unittests/unpack-selftests.c: Fix common/ includes.
10557         * unittests/tracepoint-selftests.c: Fix common/ includes.
10558         * unittests/style-selftests.c: Fix common/ includes.
10559         * unittests/string_view-selftests.c: Fix common/ includes.
10560         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10561         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10562         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10563         * unittests/rsp-low-selftests.c: Fix common/ includes.
10564         * unittests/parse-connection-spec-selftests.c: Fix common/
10565         includes.
10566         * unittests/optional-selftests.c: Fix common/ includes.
10567         * unittests/offset-type-selftests.c: Fix common/ includes.
10568         * unittests/observable-selftests.c: Fix common/ includes.
10569         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10570         * unittests/memrange-selftests.c: Fix common/ includes.
10571         * unittests/memory-map-selftests.c: Fix common/ includes.
10572         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10573         * unittests/function-view-selftests.c: Fix common/ includes.
10574         * unittests/environ-selftests.c: Fix common/ includes.
10575         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10576         * unittests/common-utils-selftests.c: Fix common/ includes.
10577         * unittests/cli-utils-selftests.c: Fix common/ includes.
10578         * unittests/array-view-selftests.c: Fix common/ includes.
10579         * ui-file.c: Fix common/ includes.
10580         * tui/tui-io.c: Fix common/ includes.
10581         * tracepoint.h: Fix common/ includes.
10582         * tracepoint.c: Fix common/ includes.
10583         * tracefile-tfile.c: Fix common/ includes.
10584         * top.h: Fix common/ includes.
10585         * top.c: Fix common/ includes.
10586         * thread.c: Fix common/ includes.
10587         * target/waitstatus.h: Fix common/ includes.
10588         * target/waitstatus.c: Fix common/ includes.
10589         * target.h: Fix common/ includes.
10590         * target.c: Fix common/ includes.
10591         * target-memory.c: Fix common/ includes.
10592         * target-descriptions.c: Fix common/ includes.
10593         * symtab.h: Fix common/ includes.
10594         * symfile.c: Fix common/ includes.
10595         * stap-probe.c: Fix common/ includes.
10596         * spu-linux-nat.c: Fix common/ includes.
10597         * sparc-nat.c: Fix common/ includes.
10598         * source.c: Fix common/ includes.
10599         * solib.c: Fix common/ includes.
10600         * solib-target.c: Fix common/ includes.
10601         * ser-unix.c: Fix common/ includes.
10602         * ser-tcp.c: Fix common/ includes.
10603         * ser-pipe.c: Fix common/ includes.
10604         * ser-base.c: Fix common/ includes.
10605         * selftest-arch.c: Fix common/ includes.
10606         * s12z-tdep.c: Fix common/ includes.
10607         * rust-exp.y: Fix common/ includes.
10608         * rs6000-aix-tdep.c: Fix common/ includes.
10609         * riscv-tdep.c: Fix common/ includes.
10610         * remote.c: Fix common/ includes.
10611         * remote-notif.h: Fix common/ includes.
10612         * remote-fileio.h: Fix common/ includes.
10613         * remote-fileio.c: Fix common/ includes.
10614         * regcache.h: Fix common/ includes.
10615         * regcache.c: Fix common/ includes.
10616         * record-btrace.c: Fix common/ includes.
10617         * python/python.c: Fix common/ includes.
10618         * python/py-type.c: Fix common/ includes.
10619         * python/py-inferior.c: Fix common/ includes.
10620         * progspace.h: Fix common/ includes.
10621         * producer.c: Fix common/ includes.
10622         * procfs.c: Fix common/ includes.
10623         * proc-api.c: Fix common/ includes.
10624         * printcmd.c: Fix common/ includes.
10625         * ppc-linux-nat.c: Fix common/ includes.
10626         * parser-defs.h: Fix common/ includes.
10627         * osdata.c: Fix common/ includes.
10628         * obsd-nat.c: Fix common/ includes.
10629         * nat/x86-linux.c: Fix common/ includes.
10630         * nat/x86-linux-dregs.c: Fix common/ includes.
10631         * nat/x86-dregs.h: Fix common/ includes.
10632         * nat/x86-dregs.c: Fix common/ includes.
10633         * nat/ppc-linux.c: Fix common/ includes.
10634         * nat/mips-linux-watch.h: Fix common/ includes.
10635         * nat/mips-linux-watch.c: Fix common/ includes.
10636         * nat/linux-waitpid.c: Fix common/ includes.
10637         * nat/linux-ptrace.h: Fix common/ includes.
10638         * nat/linux-ptrace.c: Fix common/ includes.
10639         * nat/linux-procfs.c: Fix common/ includes.
10640         * nat/linux-personality.c: Fix common/ includes.
10641         * nat/linux-osdata.c: Fix common/ includes.
10642         * nat/linux-namespaces.c: Fix common/ includes.
10643         * nat/linux-btrace.h: Fix common/ includes.
10644         * nat/linux-btrace.c: Fix common/ includes.
10645         * nat/fork-inferior.c: Fix common/ includes.
10646         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10647         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10648         * nat/aarch64-linux.c: Fix common/ includes.
10649         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10650         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10651         * namespace.h: Fix common/ includes.
10652         * mips-linux-tdep.c: Fix common/ includes.
10653         * minsyms.c: Fix common/ includes.
10654         * mi/mi-parse.h: Fix common/ includes.
10655         * mi/mi-main.c: Fix common/ includes.
10656         * mi/mi-cmd-env.c: Fix common/ includes.
10657         * memrange.h: Fix common/ includes.
10658         * memattr.c: Fix common/ includes.
10659         * maint.h: Fix common/ includes.
10660         * maint.c: Fix common/ includes.
10661         * main.c: Fix common/ includes.
10662         * machoread.c: Fix common/ includes.
10663         * location.c: Fix common/ includes.
10664         * linux-thread-db.c: Fix common/ includes.
10665         * linux-nat.c: Fix common/ includes.
10666         * linux-fork.c: Fix common/ includes.
10667         * inline-frame.c: Fix common/ includes.
10668         * infrun.c: Fix common/ includes.
10669         * inflow.c: Fix common/ includes.
10670         * inferior.h: Fix common/ includes.
10671         * inferior.c: Fix common/ includes.
10672         * infcmd.c: Fix common/ includes.
10673         * inf-ptrace.c: Fix common/ includes.
10674         * inf-child.c: Fix common/ includes.
10675         * ia64-linux-nat.c: Fix common/ includes.
10676         * i387-tdep.c: Fix common/ includes.
10677         * i386-tdep.c: Fix common/ includes.
10678         * i386-linux-tdep.c: Fix common/ includes.
10679         * i386-linux-nat.c: Fix common/ includes.
10680         * i386-go32-tdep.c: Fix common/ includes.
10681         * i386-fbsd-tdep.c: Fix common/ includes.
10682         * i386-fbsd-nat.c: Fix common/ includes.
10683         * guile/scm-type.c: Fix common/ includes.
10684         * guile/guile.c: Fix common/ includes.
10685         * go32-nat.c: Fix common/ includes.
10686         * gnu-nat.c: Fix common/ includes.
10687         * gdbthread.h: Fix common/ includes.
10688         * gdbarch-selftests.c: Fix common/ includes.
10689         * gdb_usleep.c: Fix common/ includes.
10690         * gdb_select.h: Fix common/ includes.
10691         * gdb_bfd.c: Fix common/ includes.
10692         * gcore.c: Fix common/ includes.
10693         * fork-child.c: Fix common/ includes.
10694         * findvar.c: Fix common/ includes.
10695         * fbsd-nat.c: Fix common/ includes.
10696         * event-top.c: Fix common/ includes.
10697         * event-loop.c: Fix common/ includes.
10698         * dwarf2read.c: Fix common/ includes.
10699         * dwarf2loc.c: Fix common/ includes.
10700         * dwarf2-frame.c: Fix common/ includes.
10701         * dwarf-index-cache.c: Fix common/ includes.
10702         * dtrace-probe.c: Fix common/ includes.
10703         * disasm-selftests.c: Fix common/ includes.
10704         * defs.h: Fix common/ includes.
10705         * csky-tdep.c: Fix common/ includes.
10706         * cp-valprint.c: Fix common/ includes.
10707         * cp-support.h: Fix common/ includes.
10708         * cp-support.c: Fix common/ includes.
10709         * corelow.c: Fix common/ includes.
10710         * completer.h: Fix common/ includes.
10711         * completer.c: Fix common/ includes.
10712         * compile/compile.c: Fix common/ includes.
10713         * compile/compile-loc2c.c: Fix common/ includes.
10714         * compile/compile-cplus-types.c: Fix common/ includes.
10715         * compile/compile-cplus-symbols.c: Fix common/ includes.
10716         * command.h: Fix common/ includes.
10717         * cli/cli-dump.c: Fix common/ includes.
10718         * cli/cli-cmds.c: Fix common/ includes.
10719         * charset.c: Fix common/ includes.
10720         * build-id.c: Fix common/ includes.
10721         * btrace.h: Fix common/ includes.
10722         * btrace.c: Fix common/ includes.
10723         * breakpoint.h: Fix common/ includes.
10724         * breakpoint.c: Fix common/ includes.
10725         * ax.h:
10726         (enum agent_op): Fix common/ includes.
10727         * ax-general.c (struct aop_map): Fix common/ includes.
10728         * ax-gdb.c: Fix common/ includes.
10729         * auxv.c: Fix common/ includes.
10730         * auto-load.c: Fix common/ includes.
10731         * arm-tdep.c: Fix common/ includes.
10732         * arch/riscv.c: Fix common/ includes.
10733         * arch/ppc-linux-common.c: Fix common/ includes.
10734         * arch/i386.c: Fix common/ includes.
10735         * arch/arm.c: Fix common/ includes.
10736         * arch/arm-linux.c: Fix common/ includes.
10737         * arch/arm-get-next-pcs.c: Fix common/ includes.
10738         * arch/amd64.c: Fix common/ includes.
10739         * arch/aarch64.c: Fix common/ includes.
10740         * arch/aarch64-insn.c: Fix common/ includes.
10741         * arch-utils.c: Fix common/ includes.
10742         * amd64-windows-tdep.c: Fix common/ includes.
10743         * amd64-tdep.c: Fix common/ includes.
10744         * amd64-sol2-tdep.c: Fix common/ includes.
10745         * amd64-obsd-tdep.c: Fix common/ includes.
10746         * amd64-nbsd-tdep.c: Fix common/ includes.
10747         * amd64-linux-tdep.c: Fix common/ includes.
10748         * amd64-linux-nat.c: Fix common/ includes.
10749         * amd64-fbsd-tdep.c: Fix common/ includes.
10750         * amd64-fbsd-nat.c: Fix common/ includes.
10751         * amd64-dicos-tdep.c: Fix common/ includes.
10752         * amd64-darwin-tdep.c: Fix common/ includes.
10753         * agent.c: Fix common/ includes.
10754         * ada-lang.h: Fix common/ includes.
10755         * ada-lang.c: Fix common/ includes.
10756         * aarch64-tdep.c: Fix common/ includes.
10757
10758 2019-01-25  Tom Tromey  <tom@tromey.com>
10759
10760         * common/create-version.sh: Use common/version.h.
10761
10762 2019-01-24  Pedro Alves  <palves@redhat.com>
10763
10764         * infrun.c (signal_stop, signal_print, signal_program)
10765         (signal_catch, signal_pass): Now arrays instead of pointers.
10766         (update_signals_program_target, do_target_resume)
10767         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10768         * linux-nat.c (linux_nat_target::pass_signals)
10769         (linux_nat_target::create_inferior, linux_nat_target::attach):
10770         Adjust.
10771         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10772         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10773         * procfs.c (procfs_target::pass_signals): Adjust.
10774         * record-full.c (record_full_target::resume): Adjust.
10775         * remote.c (remote_target::pass_signals)
10776         (remote_target::program_signals): Adjust.
10777         * target-debug.h (target_debug_print_signals): Now takes a
10778         gdb::array_view as parameter.  Adjust.
10779         * target.h (target_ops) <pass_signals, program_signals>: Replace
10780         pointer and length parameters with gdb::array_view.
10781         (target_pass_signals, target_program_signals): Likewise.
10782         * target-delegates.c: Regenerate.
10783
10784 2019-01-24  Pedro Alves  <palves@redhat.com>
10785
10786         * common/forward-scope-exit.h
10787         (forward_scope_exit::forward_scope_exit): Pass arguments to
10788         m_bind_function directly, instead of creating a std::bind and
10789         copying that.
10790
10791 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10792
10793         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10794         for static members.
10795         (pass_in_v_vfp_candidate): Likewise.
10796
10797 2019-01-23  Tom Tromey  <tom@tromey.com>
10798             Pedro Alves  <palves@redhat.com>
10799
10800         * regcache.c (class regcache_invalidator): Remove.
10801         (regcache::raw_write): Use make_scope_exit.
10802
10803 2019-01-23  Tom Tromey  <tom@tromey.com>
10804
10805         * ui-out.h (class ui_out_emit_type): Update comment.
10806
10807 2019-01-23  Tom Tromey  <tom@tromey.com>
10808
10809         * infrun.c (fetch_inferior_event): Update comment.
10810
10811 2019-01-23  Tom Tromey  <tom@tromey.com>
10812             Pedro Alves  <palves@redhat.com>
10813
10814         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10815         parameter.
10816         (fetch_inferior_event): Use SCOPE_EXIT.
10817
10818
10819 2019-01-23  Tom Tromey  <tom@tromey.com>
10820             Pedro Alves  <palves@redhat.com>
10821
10822         * infrun.c (disable_thread_events): Delete.
10823         (stop_all_threads): Use SCOPE_EXIT.
10824
10825 2019-01-23  Tom Tromey  <tom@tromey.com>
10826             Pedro Alves  <palves@redhat.com>
10827
10828         * symfile.c: Include forward-scope-exit.h.
10829         (clear_symtab_users_cleanup): Replace forward declaration with
10830         a FORWARD_SCOPE_EXIT.
10831         (syms_from_objfile_1): Use the forward_scope_exit and
10832         gdb::optional instead of cleanup_function.
10833         (reread_symbols): Use the forward_scope_exit instead of
10834         cleanup_function.
10835         (clear_symtab_users_cleanup): Remove function.
10836
10837 2019-01-23  Tom Tromey  <tom@tromey.com>
10838             Pedro Alves  <palves@redhat.com>
10839
10840         * linux-nat.c: Include scope-exit.h.
10841         (cleanup_target_stop): Remove.
10842         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10843         SCOPE_EXIT.
10844
10845 2019-01-23  Tom Tromey  <tom@tromey.com>
10846             Pedro Alves  <palves@redhat.com>
10847
10848         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10849         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10850
10851 2019-01-23  Tom Tromey  <tom@tromey.com>
10852             Andrew Burgess  <andrew.burgess@embecosm.com>
10853             Pedro Alves  <palves@redhat.com>
10854
10855         * infrun.c (fetch_inferior_event): Use scope_exit.
10856         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10857         * top.c (execute_command): Use scope_exit.
10858         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10859         * utils.c (do_bpstat_clear_actions_cleanup)
10860         (make_bpstat_clear_actions_cleanup): Remove.
10861
10862 2019-01-23  Tom Tromey  <tom@tromey.com>
10863             Pedro Alves  <palves@redhat.com>
10864
10865         * infrun.c: Include "common/scope-exit.h"
10866         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10867         (wait_for_inferior): Use SCOPE_EXIT.
10868         (fetch_inferior_event): Use scope_exit.
10869
10870 2019-01-23  Tom Tromey  <tom@tromey.com>
10871             Pedro Alves  <palves@redhat.com>
10872
10873         * breakpoint.c (create_breakpoint): Remove cleanup.
10874
10875 2019-01-23  Tom Tromey  <tom@tromey.com>
10876             Andrew Burgess  <andrew.burgess@embecosm.com>
10877             Pedro Alves  <palves@redhat.com>
10878
10879 2019-01-23  Pedro Alves  <palves@redhat.com>
10880
10881         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10882
10883 2019-01-23  Pedro Alves  <palves@redhat.com>
10884             Andrew Burgess  <andrew.burgess@embecosm.com>
10885
10886         * gdbthread.h: Include "common/forward-scope-exit.h".
10887         (scoped_finish_thread_state): Redefine custom class in terms of
10888         forward_scope_exit.
10889
10890 2019-01-23  Pedro Alves  <palves@redhat.com>
10891             Andrew Burgess  <andrew.burgess@embecosm.com>
10892
10893         * common/forward-scope-exit.h: New file.
10894
10895 2019-01-23  Pedro Alves  <palves@redhat.com>
10896             Andrew Burgess  <andrew.burgess@embecosm.com>
10897             Tom Tromey  <tom@tromey.com>
10898
10899         * common/scope-exit.h: New file.
10900
10901 2019-01-23  Pedro Alves  <palves@redhat.com>
10902
10903         * common/preprocessor.h (ESC): Rename to ...
10904         (ESC_PARENS): ... this.
10905         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10906         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10907
10908 2019-01-23  Tom Tromey  <tom@tromey.com>
10909
10910         * language.h (class scoped_switch_to_sym_language_if_auto):
10911         Initialize m_lang in both cases.
10912
10913 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10914
10915         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10916         with XCNEW.
10917
10918 2019-01-22  Tom Tromey  <tom@tromey.com>
10919
10920         * corelow.c: Do not include sys/file.h.
10921
10922 2019-01-22  Tom Tromey  <tom@tromey.com>
10923
10924         * tui/tui-wingeneral.h: Include gdb_curses.h.
10925
10926 2019-01-22  Tom Tromey  <tom@tromey.com>
10927
10928         * source-cache.h (class source_cache) <get_source_lines,
10929         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10930
10931 2019-01-22  Tom Tromey  <tom@tromey.com>
10932
10933         * remote-fileio.h (struct remote_target): Declare.
10934
10935 2019-01-22  Tom Tromey  <tom@tromey.com>
10936
10937         * python/py-arch.c: Do not include py-ref.h.
10938         * python/py-bpevent.c: Do not include py-ref.h.
10939         * python/py-cmd.c: Do not include py-ref.h.
10940         * python/py-continueevent.c: Do not include py-ref.h.
10941         * python/py-event.h: Do not include py-ref.h.
10942         * python/py-evtregistry.c: Do not include py-ref.h.
10943         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10944         * python/py-frame.c: Do not include py-ref.h.
10945         * python/py-framefilter.c: Do not include py-ref.h.
10946         * python/py-function.c: Do not include py-ref.h.
10947         * python/py-infevents.c: Do not include py-ref.h.
10948         * python/py-linetable.c: Do not include py-ref.h.
10949         * python/py-objfile.c: Do not include py-ref.h.
10950         * python/py-param.c: Do not include py-ref.h.
10951         * python/py-prettyprint.c: Do not include py-ref.h.
10952         * python/py-progspace.c: Do not include py-ref.h.
10953         * python/py-symbol.c: Do not include py-ref.h.
10954         * python/py-symtab.c: Do not include py-ref.h.
10955         * python/py-type.c: Do not include py-ref.h.
10956         * python/py-unwind.c: Do not include py-ref.h.
10957         * python/py-utils.c: Do not include py-ref.h.
10958         * python/py-value.c: Do not include py-ref.h.
10959         * python/py-varobj.c: Do not include py-ref.h.
10960         * python/py-xmethods.c: Do not include py-ref.h.
10961         * python/python.c: Do not include py-ref.h.
10962         * varobj.c: Do not include py-ref.h.
10963
10964 2019-01-22  Tom Tromey  <tom@tromey.com>
10965
10966         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10967         keyword for bcache.
10968
10969 2019-01-22  Tom Tromey  <tom@tromey.com>
10970
10971         * compile/compile-cplus-types.c: Remove a comment by #include.
10972
10973 2019-01-22  Tom Tromey  <tom@tromey.com>
10974
10975         * compile/gcc-c-plugin.h: Include compile-internal.h.
10976
10977 2019-01-22  Tom Tromey  <tom@tromey.com>
10978
10979         * stabsread.c (EXTERN): Do not define.
10980         (symnum, next_symbol_text_func, processing_gcc_compilation)
10981         (within_function, global_sym_chain, global_stabs)
10982         (previous_stab_code, this_object_header_files)
10983         (n_this_object_header_files)
10984         (n_allocated_this_object_header_files): Define.
10985         * stabsread.h (EXTERN): Never define.  Use "extern".
10986
10987 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10988
10989         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10990         history_value.
10991
10992 2019-01-21  Tom Tromey  <tom@tromey.com>
10993
10994         * ui-out.c: Fix includes.
10995         * tui/tui-source.c: Fix includes.
10996         * target.c: Fix includes.
10997         * remote.c: Fix includes.
10998         * regcache.c: Fix includes.
10999         * python/py-block.c: Fix includes.
11000         * printcmd.c: Fix includes.
11001         * or1k-tdep.c: Fix includes.
11002         * mi/mi-main.c: Fix includes.
11003         * m32r-tdep.c: Fix includes.
11004         * csky-tdep.c: Fix includes.
11005         * compile/compile-cplus-types.c: Fix includes.
11006         * cli/cli-interp.c: Fix includes.
11007
11008 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11009
11010         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11011         for padding.
11012
11013 2019-01-16  Tom Tromey  <tom@tromey.com>
11014
11015         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11016         earlier.
11017         (struct objfile) <msymbols_range>: Move from top level.
11018         <msymbols>: New method.
11019         (class objfile_msymbols): Remove.
11020         * symtab.c (default_collect_symbol_completion_matches_break_on):
11021         Update.
11022         * symmisc.c (dump_msymbols): Update.
11023         * stabsread.c (scan_file_globals): Update.
11024         * objc-lang.c (info_selectors_command, info_classes_command)
11025         (find_methods): Update.
11026         * minsyms.c (find_solib_trampoline_target): Update.
11027         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11028         * coffread.c (coff_symfile_read): Update.
11029         * ada-lang.c (ada_lookup_simple_minsym)
11030         (ada_collect_symbol_completion_matches): Update.
11031
11032 2019-01-16  Tom Tromey  <tom@tromey.com>
11033
11034         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11035         type.  Remove no-argument constructor.
11036         <iterator::operator++>: Simplify.
11037         <begin>: Update.
11038         <end>: Use minimal_symbol_count.
11039
11040 2019-01-16  Tom Tromey  <tom@tromey.com>
11041
11042         * objfiles.h (struct objfile) <psymtabs>: New method.
11043         (class objfile_psymtabs): Remove.
11044         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11045         typedef.
11046         <range>: New method.
11047         (require_partial_symbols): Change return type.
11048         * psymtab.c (require_partial_symbols)
11049         (psym_expand_symtabs_matching): Update.
11050         * mdebugread.c (parse_partial_symbols): Update.
11051         * dbxread.c (dbx_end_psymtab): Update.
11052
11053 2019-01-15  Tom Tromey  <tom@tromey.com>
11054
11055         * symtab.c (lookup_objfile_from_block)
11056         (lookup_symbol_in_objfile_symtabs)
11057         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11058         (find_line_symtab, info_sources_command)
11059         (default_collect_symbol_completion_matches_break_on)
11060         (make_source_files_completion_list): Update.
11061         * symmisc.c (print_objfile_statistics, dump_objfile)
11062         (maintenance_print_symbols, maintenance_info_symtabs)
11063         (maintenance_check_symtabs, maintenance_info_line_tables):
11064         Update.
11065         * source.c (select_source_symtab)
11066         (forget_cached_source_info_for_objfile): Update.
11067         * objfiles.h (class objfile_compunits): Remove.
11068         (struct objfile) <compunits_range>: New typedef.
11069         (compunits): New method.
11070         * objfiles.c (objfile_relocate1): Update.
11071         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11072         * maint.c (count_symtabs_and_blocks): Update.
11073         * linespec.c (iterate_over_all_matching_symtabs): Update.
11074         * cp-support.c (add_symbol_overload_list_qualified): Update.
11075         * coffread.c (coff_symtab_read): Update.
11076         * ada-lang.c (add_nonlocal_symbols)
11077         (ada_collect_symbol_completion_matches)
11078         (ada_add_global_exceptions): Update.
11079
11080 2019-01-15  Tom Tromey  <tom@tromey.com>
11081
11082         * progspace.h (program_space) <objfiles_safe_range>: New
11083         typedef.
11084         <objfiles_safe>: New method.
11085         * objfiles.h (class all_objfiles_safe): Remove.
11086         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11087         * jit.c (jit_inferior_exit_hook): Update.
11088
11089 2019-01-17  Tom Tromey  <tom@tromey.com>
11090
11091         * progspace.h (program_space) <objfiles_range>: New typedef.
11092         <objfiles>: New method.
11093         <objfiles_head>: Rename from objfiles.
11094         (object_files): Update.
11095         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11096         * guile/scm-pretty-print.c
11097         (ppscm_find_pretty_printer_from_objfiles): Update.
11098         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11099         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11100         Update.
11101         * python/py-progspace.c (pspy_get_objfiles): Update.
11102         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11103         Update.
11104         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11105         (objfpy_lookup_objfile_by_build_id): Update.
11106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11107         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11108         Update.
11109         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11110         (expand_symtab_containing_pc, lookup_objfile_from_block)
11111         (lookup_static_symbol, basic_lookup_transparent_type)
11112         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11113         (find_line_symtab, info_sources_command)
11114         (default_collect_symbol_completion_matches_break_on)
11115         (make_source_files_completion_list, find_main_name): Update.
11116         * symmisc.c (print_symbol_bcache_statistics)
11117         (print_objfile_statistics, maintenance_print_symbols)
11118         (maintenance_print_msymbols, maintenance_print_objfiles)
11119         (maintenance_info_symtabs, maintenance_check_symtabs)
11120         (maintenance_expand_symtabs, maintenance_info_line_tables):
11121         Update.
11122         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11123         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11124         (map_overlay_command, unmap_overlay_command)
11125         (simple_overlay_update, expand_symtabs_matching)
11126         (map_symbol_filenames): Update.
11127         * symfile-debug.c (set_debug_symfile): Update.
11128         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11129         Update.
11130         * source.c (select_source_symtab, forget_cached_source_info):
11131         Update.
11132         * solib.c (solib_read_symbols): Update.
11133         * solib-spu.c (append_ocl_sos): Update.
11134         * psymtab.c (maintenance_print_psymbols)
11135         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11136         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11137         * printcmd.c (info_symbol_command): Update.
11138         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11139         Update.
11140         * objfiles.h (class all_objfiles): Remove.
11141         * objfiles.c (have_partial_symbols, have_full_symbols)
11142         (have_minimal_symbols, qsort_cmp, update_section_map)
11143         (shared_objfile_contains_address_p)
11144         (default_iterate_over_objfiles_in_search_order): Update.
11145         * objc-lang.c (info_selectors_command, info_classes_command)
11146         (find_methods): Update.
11147         * minsyms.c (find_solib_trampoline_target): Update.
11148         * maint.c (maintenance_info_sections)
11149         (maintenance_translate_address, count_symtabs_and_blocks):
11150         Update.
11151         * main.c (captured_main_1): Update.
11152         * linux-thread-db.c (try_thread_db_load_from_pdir)
11153         (has_libpthread): Update.
11154         * linespec.c (iterate_over_all_matching_symtabs)
11155         (search_minsyms_for_name): Update.
11156         * jit.c (jit_find_objf_with_entry_addr): Update.
11157         * hppa-tdep.c (find_unwind_entry)
11158         (hppa_lookup_stub_minimal_symbol): Update.
11159         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11160         Update.
11161         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11162         (elf_gnu_ifunc_resolve_by_got): Update.
11163         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11164         * dwarf-index-write.c (save_gdb_index_command): Update.
11165         * cp-support.c (add_symbol_overload_list_qualified): Update.
11166         * breakpoint.c (create_overlay_event_breakpoint)
11167         (create_longjmp_master_breakpoint)
11168         (create_std_terminate_master_breakpoint)
11169         (create_exception_master_breakpoint): Update.
11170         * blockframe.c (find_pc_partial_function): Update.
11171         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11172         (ada_collect_symbol_completion_matches)
11173         (ada_add_global_exceptions): Update.
11174
11175 2019-01-17  Tom Tromey  <tom@tromey.com>
11176
11177         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11178         declare VEC.
11179         (solib_target_parse_libraries): Change return type.
11180         (library_list_start_segment, library_list_start_section)
11181         (library_list_end_library, library_list_start_library); Update.
11182         (solib_target_free_library_list): Remove.
11183         (solib_target_parse_libraries): Remove cleanup.  Change return
11184         type.
11185         (solib_target_current_sos): Update.
11186
11187 2019-01-17  Tom Tromey  <tromey@bapiya>
11188
11189         * valprint.c: Replace "the the" with "the".
11190         * symtab.c: Replace "the the" with "the".
11191         * solib.c: Replace "the the" with "the".
11192         * solib-dsbt.c: Replace "the the" with "the".
11193         * linespec.c: Replace "the the" with "the".
11194         * dwarf2loc.h: Replace "the the" with "the".
11195         * amd64-windows-tdep.c: Replace "the the" with "the".
11196         * aarch64-tdep.c: Replace "the the" with "the".
11197
11198 2019-01-16  Keith Seitz  <keiths@redhat.com>
11199
11200         PR gdb/23773
11201         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11202         <builder>: Rename to ..
11203         <m_builder>: ... this and make private.
11204         (dwarf2_cu::get_builder): New method.  Change all users of
11205         `builder' to use this method.
11206         (dwarf2_start_symtab): Move to ...
11207         (dwarf2_cu::start_symtab): ... here.  Update all callers
11208         (setup_type_unit_groups): Move to ...
11209         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11210         callers.
11211         (dwarf2_cu::reset_builder): New method.
11212         (process_full_compunit, process_full_type_unit): Use
11213         dwarf2_cu::reset_builder.
11214         (follow_die_offset): Record the ancestor CU if it is different
11215         from the followed DIE's CU.
11216         (follow_die_sig_1): Likewise.
11217
11218 2019-01-15  Tom Tromey  <tom@tromey.com>
11219
11220         * remote.c (class remote_state) <buf>: Now a char_vector.
11221         <buf_size>: Remove.
11222         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11223         parameter.
11224         (remote_target::getpkt_or_notif_sane_1)
11225         (remote_target::getpkt_sane)
11226         (remote_target::getpkt_or_notif_sane): Likewise.
11227         (class remote_target) <putpkt>: New overload.
11228         (remote_target::read_frame): Change type of "buf_p".  Remove
11229         sizeof_p parameter.
11230         (packet_ok): New overload.
11231         (packet_check_result): New overload.
11232         Update all uses.
11233
11234 2019-01-14  Tom Tromey  <tom@tromey.com>
11235
11236         * remote-notif.c (handle_notification, remote_notif_ack)
11237         (remote_notif_parse): Make "buf" const.
11238         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11239         const.
11240         (remote_notif_parse, remote_notif_ack, handle_notification):
11241         Likewise.
11242         * remote.c (remote_notif_stop_parse): Make "buf" const.
11243         (remote_target::remote_parse_stop_reply): Make "buf" const.
11244         (remote_notif_stop_ack): Make "buf" const.
11245
11246 2019-01-14  Tom Tromey  <tom@tromey.com>
11247
11248         * remote.c (remote_console_output): Make parameter const.
11249
11250 2019-01-14  Tom Tromey  <tom@tromey.com>
11251
11252         * target-debug.h (target_debug_print_signals): Constify.
11253         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11254         * procfs.c (procfs_target::pass_signals): Update.
11255         * linux-nat.c (linux_nat_target::pass_signals): Update.
11256         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11257         * target-delegates.c: Rebuild.
11258         * remote.c (remote_target::program_signals): Update.
11259         (remote_target::pass_signals): Update.
11260         * target.c (target_pass_signals): Constify argument.
11261         (target_program_signals): Likewise.
11262         * target.h (struct target_ops) <pass_signals, program_signals>:
11263         Constify argument.
11264         (target_pass_signals, target_program_signals): Constify argument.
11265
11266 2019-01-14  Tom Tromey  <tom@tromey.com>
11267
11268         PR tui/28819:
11269         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11270
11271 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11272
11273         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11274         field.
11275         * rs6000-tdep.c: Include reggroups.h.
11276         (IS_V_ALIAS_PSEUDOREG): Define.
11277         (rs6000_register_name): Return names for the "vX" aliases.
11278         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11279         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11280         aliases.  Call default_register_reggroup_p for all other
11281         pseudo-registers.
11282         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11283         New functions.
11284         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11285         Handle "vX" aliases.
11286         (v_alias_pseudo_register_collect): New function.
11287         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11288         (rs6000_gdbarch_init): Initialize "vX" aliases as
11289         pseudo-registers.  Restore registration of
11290         rs6000_pseudo_register_reggroup_p with
11291         set_tdesc_pseudo_register_reggroup_p.
11292
11293 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11294
11295         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11296         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11297         set_gdbarch_num_pseudo_regs.
11298
11299 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11300
11301         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11302         Remove arg prefixname, add do_set and do_show.
11303         Add member functions set_list and show_list.
11304         * cli/cli-style.c (class cli_style_option): Update accordingly.
11305         (style_set_list): Move to file scope.
11306         (style_show_list): Likewise.
11307         (set_style): Call help_list.
11308         (show_style): Call cmd_show_list.
11309         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11310         Update to use the new macro.
11311
11312 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11313
11314         * ada-lang.c (_initialize_ada_language): Expand the help text
11315         for the "catch exception" command.
11316
11317 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11318
11319         * symtab.c (matching_obj_sections): Initialize obj,
11320         declare it closer to its usage.
11321
11322 2019-01-10  Tom Tromey  <tom@tromey.com>
11323
11324         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11325         (basic_inf_threads_range): Remove.
11326         (inf_threads_range, inf_non_exited_threads_range)
11327         (safe_inf_threads_range): Use next_adapter.
11328
11329 2019-01-10  Keith Seitz  <keiths@redhat.com>
11330
11331         PR gdb/23712
11332         PR symtab/23010
11333         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11334         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11335
11336 2019-01-10  Keith Seitz  <keiths@redhat.com>
11337
11338         PR gdb/23712
11339         PR symtab/23010
11340         * dictionary.c (pending_to_vector): Remove.
11341         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11342         Remove _1 suffix, replacing functions of the same name.  Update
11343         all callers.
11344         (dict_create_hashed, dict_create_hashed_expandable)
11345         (dict_create_linear, dict_create_linear_expandable, dict_free)
11346         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11347         Make functions static.
11348
11349 2019-01-10  Keith Seitz  <keiths@redhat.com>
11350
11351         PR gdb/23712
11352         PR symtab/23010
11353         * dictionary.h (struct dictionary): Replace declaration with
11354         multidictionary.
11355         (dict_create_hashed, dict_create_hashed_expandable)
11356         (dict_create_linear, dict_create_linear_expandable)
11357         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11358         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11359         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11360         taking multidictionary argument.
11361         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11362         * block.h (struct block) <dict>: Change to multidictionary
11363         and rename `multidict'.
11364         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11365         symmisc.c: Update all dictionary references to multidictionary.
11366
11367 2019-01-10  Keith Seitz  <keiths@redhat.com>
11368
11369         PR gdb/23712
11370         PR symtab/23010
11371         * dictionary.c: Include unordered_map.
11372         (pending_to_vector): New function.
11373         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11374         Rewrite the non-"_1" functions to take vector instead
11375         of linked list.
11376         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11377         "new" _1 versions of the same name.
11378         (multidictionary): Define.
11379         (std::hash<enum language): New definition.
11380         (collate_pending_symbols_by_language, mdict_create_hashed)
11381         (mdict_create_hashed_expandable, mdict_create_linear)
11382         (mdict_create_linear_expandable, mdict_free)
11383         (find_language_dictionary, create_new_language_dictionary)
11384         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11385         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11386         (mdict_size, mdict_empty): New functions.
11387         * dictionary.h (mdict_iterator): Define.
11388
11389 2019-01-10  Pedro Alves  <palves@redhat.com>
11390
11391         * breakpoint.c (read_uploaded_action)
11392         (create_tracepoint_from_upload): Adjust to use
11393         gdb::unique_xmalloc_ptr.
11394         * ctf.c (ctf_write_uploaded_tp):
11395         (SET_ARRAY_FIELD): Use emplace_back.
11396         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11397         * tracefile-tfile.c (tfile_write_uploaded_tp):
11398         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11399         gdb::unique_xmalloc_ptr.
11400         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11401         at_string, cond_string, cmd_strings>: Replace char pointers
11402         with gdb::unique_xmalloc_ptr.
11403
11404 2019-01-10  Pedro Alves  <palves@redhat.com>
11405
11406         * solib-target.c (library_list_start_library): Don't xstrdup name.
11407
11408 2019-01-10  Pedro Alves  <palves@redhat.com>
11409
11410         * mdebugread.c (parse_partial_symbols): Use
11411         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11412
11413 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11414
11415         * linux-fork.c (scoped_switch_fork_info)
11416         <~scoped_switch_fork_info>: Fix incorrect variable name.
11417
11418 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11419
11420         * linux-fork.c (scoped_switch_fork_info)
11421         <scoped_switch_fork_info>: Make explicit.
11422         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11423
11424 2019-01-10  Tom Tromey  <tom@tromey.com>
11425
11426         * objfiles.h (objfile::reset_psymtabs): Update.
11427         * objfiles.c (objfile::objfile): Update.
11428         * psymtab.h (psymtab_storage::obstack): Update.
11429         (psymtab_storage::m_obstack): Use gdb::optional.
11430         (class psymtab_storage): Update comment.  Remove objfile
11431         parameter.
11432         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11433
11434 2019-01-10  Tom Tromey  <tom@tromey.com>
11435
11436         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11437         <free_psymtabs>: Now private.
11438         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11439         (allocate_psymtab): Use new method.
11440
11441 2019-01-10  Tom Tromey  <tom@tromey.com>
11442
11443         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11444         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11445         * mdebugread.c (parse_partial_symbols): Use
11446         allocate_dependencies.
11447         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11448         allocate_dependencies.
11449         (process_psymtab_comp_unit_reader)
11450         (build_type_psymtab_dependencies): Likewise.
11451         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11452
11453 2019-01-10  Tom Tromey  <tom@tromey.com>
11454
11455         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11456         PSYMBOL_SET_LANGUAGE.
11457         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11458
11459 2019-01-10  Tom Tromey  <tom@tromey.com>
11460
11461         * psymtab.h (psymtab_storage::obstack): New method.
11462         <m_obstack>: Rename from obstack; now private.
11463         * psymtab.c (psymtab_storage): Update.
11464         * dwarf2read.c (create_addrmap_from_index)
11465         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11466         Update.
11467
11468 2019-01-10  Tom Tromey  <tom@tromey.com>
11469
11470         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11471         * objfiles.h (objfile::reset_psymtabs): New method.
11472
11473 2019-01-10  Tom Tromey  <tom@tromey.com>
11474
11475         * symmisc.c (print_symbol_bcache_statistics): Update.
11476         (print_objfile_statistics): Update.
11477         * symfile.c (reread_symbols): Update.
11478         * psymtab.h (class psymtab_storage): New.
11479         * psymtab.c (psymtab_storage): New constructor.
11480         (~psymtab_storage): New destructor.
11481         (require_partial_symbols): Update.
11482         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11483         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11484         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11485         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11486         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11487         (start_psymtab_common, end_psymtab_common)
11488         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11489         (allocate_psymtab): Update.
11490         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11491         Update.
11492         (dump_psymtab_addrmap, maintenance_print_psymbols)
11493         (maintenance_check_psymtabs): Update.
11494         (class objfile_psymtabs): Move to objfiles.h.
11495         * psympriv.h (discard_psymtab): Now inline.
11496         (psymtab_discarder::psymtab_discarder): Update.
11497         (psymtab_discarder::~psymtab_discarder): Update.
11498         (ALL_OBJFILE_PSYMTABS): Rewrite.
11499         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11500         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11501         Remove fields.
11502         <partial_symtabs>: New field.
11503         (class objfile_psymtabs): Move from psymtab.h.  Update.
11504         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11505         psymbol_cache.
11506         (objfile::~objfile): Don't destroy psymbol_cache.
11507         * mdebugread.c (parse_partial_symbols): Update.
11508         * dwarf2read.c (create_addrmap_from_index)
11509         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11510         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11511         (add_partial_subprogram, dwarf2_ranges_read): Update.
11512         * dwarf-index-write.c (write_address_map)
11513         (write_one_signatured_type, recursively_write_psymbols)
11514         (class debug_names, class debug_names, write_psymtabs_to_index):
11515         Update.
11516
11517 2019-01-10  Tom Tromey  <tom@tromey.com>
11518
11519         * symtab.h (SYMBOL_SET_NAMES): Update.
11520         (symbol_set_names): Update.
11521         (MSYMBOL_SET_NAMES): Update.
11522         * symtab.c (symbol_set_names): Change argument to be an
11523         objfile_per_bfd_storage.
11524         * psymtab.c (add_psymbol_to_bcache): Update.
11525         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11526
11527 2019-01-10  Tom Tromey  <tom@tromey.com>
11528
11529         * symtab.c (create_demangled_names_hash): Change argument to be an
11530         objfile_per_bfd_storage.
11531         (symbol_set_names): Update.
11532
11533 2019-01-10  Tom Tromey  <tom@tromey.com>
11534
11535         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11536         init_psymbol_list.
11537         * psymtab.c (init_psymbol_list): Do nothing if already called.
11538         * psympriv.h (init_psymbol_list): Add comment.
11539         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11540         init_psymbol_list.
11541         * dbxread.c (dbx_symfile_read): Unconditionally call
11542         init_psymbol_list.
11543
11544 2019-01-10  Tom Tromey  <tom@tromey.com>
11545
11546         * xcoffread.c (scan_xcoff_symtab): Update.
11547         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11548         "where".
11549         * mdebugread.c (parse_partial_symbols)
11550         (handle_psymbol_enumerators): Update.
11551         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11552         * dbxread.c (read_dbx_symtab): Update.
11553         * psympriv.h (psymbol_placement): New enum.
11554         (add_psymbol_to_list): Update.
11555
11556 2019-01-10  Tom Tromey  <tom@tromey.com>
11557
11558         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11559         static_psymbols parameters.
11560         (scan_xcoff_symtab): Update.
11561         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11562         static_psymbols parameters.
11563         * psympriv.h (start_psymtab_common): Update.
11564         * mdebugread.c (parse_partial_symbols): Update.
11565         * dwarf2read.c (create_partial_symtab): Update.
11566         * dbxread.c (read_dbx_symtab): Update.
11567         (start_psymtab): Remove global_psymbols and static_psymbols
11568         parameters.
11569
11570 2019-01-10  Tom Tromey  <tom@tromey.com>
11571
11572         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11573         * psymtab.c (allocate_psymtab): Add comment.
11574         * psympriv.h (allocate_psymtab): Add comment.
11575         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11576         initializations.
11577         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11578
11579 2019-01-10  Tom Tromey  <tom@tromey.com>
11580
11581         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11582         Don't declare.
11583         * mipsread.c: Include mdebugread.h.
11584         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11585         Declare.
11586         * elfread.c: Include mdebugread.h.
11587
11588 2019-01-09  Tom Tromey  <tom@tromey.com>
11589
11590         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11591         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11592         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11593         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11594         (psym_lookup_symbol, psym_find_last_source_symtab)
11595         (psym_forget_cached_source_info, psym_print_stats)
11596         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11597         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11598         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11599         (psym_find_compunit_symtab_by_address)
11600         (maintenance_print_psymbols, maintenance_info_psymtabs)
11601         (maintenance_check_psymtabs): Use ranged for.
11602         * psymtab.h (class objfile_psymtabs): New.
11603         (require_partial_symbols): Return objfile_psymtabs.
11604         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11605
11606 2019-01-09  Tom Tromey  <tom@tromey.com>
11607
11608         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11609         (find_pc_mapped_section, list_overlays_command)
11610         (map_overlay_command, unmap_overlay_command)
11611         (simple_overlay_update): Use all_objfiles.
11612         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11613         * printcmd.c (info_symbol_command): Use all_objfiles.
11614         * objfiles.h (ALL_OBJSECTIONS): Remove.
11615         * maint.c (maintenance_translate_address): Use all_objfiles.
11616         * gcore.c (gcore_create_callback): Use all_objfiles.
11617         (objfile_find_memory_regions): Likewise.
11618
11619 2019-01-09  Tom Tromey  <tom@tromey.com>
11620
11621         * symtab.c (find_line_symtab, info_sources_command)
11622         (make_source_files_completion_list): Use objfile_compunits.
11623         * source.c (select_source_symtab): Use objfile_compunits.
11624         * objfiles.h (struct objfile): Update comment.
11625         (ALL_OBJFILES): Remove.
11626         (ALL_FILETABS): Remove.
11627         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11628         objfile_compunits.
11629
11630 2019-01-09  Tom Tromey  <tom@tromey.com>
11631
11632         * symmisc.c (print_objfile_statistics, dump_objfile)
11633         (maintenance_print_symbols): Use compunit_filetabs.
11634         * source.c (forget_cached_source_info_for_objfile): Use
11635         compunit_filetabs.
11636         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11637         (ALL_FILETABS): Use compunit_filetabs.
11638         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11639         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11640
11641 2019-01-09  Tom Tromey  <tom@tromey.com>
11642
11643         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11644         (compunit_filetabs): New.
11645         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11646         compunit_filetabs.
11647         (info_sources_command, make_source_files_completion_list): Remove
11648         declaration.
11649         * symmisc.c (print_objfile_statistics, dump_objfile)
11650         (maintenance_print_symbols): Remove declaration.
11651         (maintenance_info_symtabs): Use compunit_filetabs.
11652         (maintenance_info_line_tables): Likewise.
11653         * source.c (select_source_symtab): Change local variable name.
11654         (forget_cached_source_info_for_objfile): Remove declaration.
11655         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11656         * objfiles.c (objfile_relocate1): Remove declaration.
11657         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11658         declaration.
11659         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11660         * coffread.c (coff_symtab_read): Remove declaration.
11661         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11662         compunit_filetabs.
11663
11664 2019-01-09  Tom Tromey  <tom@tromey.com>
11665
11666         * symtab.c (lookup_objfile_from_block)
11667         (find_pc_sect_compunit_symtab, search_symbols)
11668         (default_collect_symbol_completion_matches_break_on): Use
11669         objfile_compunits.
11670         * objfiles.h (ALL_COMPUNITS): Remove.
11671         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11672         * cp-support.c (add_symbol_overload_list_qualified): Use
11673         objfile_compunits.
11674         * ada-lang.c (ada_collect_symbol_completion_matches)
11675         (ada_add_global_exceptions): Use objfile_compunits.
11676
11677 2019-01-09  Tom Tromey  <tom@tromey.com>
11678
11679         * source.c (select_source_symtab)
11680         (forget_cached_source_info_for_objfile): Remove declaration.
11681         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11682         declaration.
11683         * maint.c (count_symtabs_and_blocks): Remove declaration.
11684         * cp-support.c (add_symbol_overload_list_qualified): Remove
11685         declaration.
11686         * coffread.c (coff_symtab_read): Remove declaration.
11687         * symtab.c (lookup_symbol_in_objfile_symtabs)
11688         (basic_lookup_transparent_type_1): Use objfile_compunits.
11689         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11690         (info_sources_command, search_symbols)
11691         (default_collect_symbol_completion_matches_break_on)
11692         (make_source_files_completion_list): Remove declaration.
11693         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11694         (ada_collect_symbol_completion_matches)
11695         (ada_add_global_exceptions): Remove declaration.
11696         * linespec.c (iterate_over_all_matching_symtabs): Use
11697         objfile_compunits.
11698         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11699         (class objfile_compunits): New.
11700         (ALL_COMPUNITS): Use objfile_compunits.
11701         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11702         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11703         objfile_compunits.
11704         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11705
11706 2019-01-09  Tom Tromey  <tom@tromey.com>
11707
11708         * symtab.c (search_symbols)
11709         (default_collect_symbol_completion_matches_break_on): Use
11710         objfile_msymbols.
11711         * ada-lang.c (ada_lookup_simple_minsym)
11712         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11713         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11714         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11715         objfile_msymbols.
11716         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11717         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11718         * objc-lang.c (find_methods): Use objfile_msymbols.
11719         (info_selectors_command, info_classes_command): Likewise.
11720         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11721         * objfiles.h (class objfile_msymbols): New.
11722         (ALL_OBJFILE_MSYMBOLS): Remove.
11723         (ALL_MSYMBOLS): Remove.
11724
11725 2019-01-09  Tom Tromey  <tom@tromey.com>
11726
11727         * common/next-iterator.h (next_adapter): Add Iterator template
11728         parameter.
11729         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11730         (class all_objfiles_safe): New.
11731         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11732         * objfiles.c (put_objfile_before): Update comment.
11733         (add_separate_debug_objfile): Likewise.
11734         (free_all_objfiles): Use all_objfiles_safe.
11735         (objfile_purge_solibs): Likewise.
11736
11737 2019-01-09  Tom Tromey  <tom@tromey.com>
11738
11739         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11740         (expand_symtab_containing_pc, lookup_static_symbol)
11741         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11742         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11743         all_objfiles.
11744         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11745         * breakpoint.c (create_overlay_event_breakpoint)
11746         (create_longjmp_master_breakpoint)
11747         (create_std_terminate_master_breakpoint)
11748         (create_exception_master_breakpoint): Use all_objfiles.
11749         * linux-thread-db.c (try_thread_db_load_from_pdir)
11750         (has_libpthread): Use all_objfiles.
11751         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11752         * linespec.c (iterate_over_all_matching_symtabs)
11753         (search_minsyms_for_name): Use all_objfiles.
11754         * maint.c (maintenance_info_sections): Use all_objfiles.
11755         * main.c (captured_main_1): Use all_objfiles.
11756         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11757         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11758         * guile/scm-pretty-print.c
11759         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11760         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11761         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11762         (maintenance_print_msymbols): Use all_objfiles.
11763         * source.c (select_source_symtab): Use all_objfiles.
11764         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11765         * symfile.c (remove_symbol_file_command)
11766         (expand_symtabs_matching, map_symbol_filenames): Use
11767         all_objfiles.
11768         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11769         all_objfiles.
11770         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11771         * objc-lang.c (find_methods): Use all_objfiles.
11772         * objfiles.c (have_partial_symbols, have_full_symbols)
11773         (have_minimal_symbols, qsort_cmp)
11774         (default_iterate_over_objfiles_in_search_order): Use
11775         all_objfiles.
11776         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11777         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11778         (maintenance_check_psymtabs): Use all_objfiles.
11779         (ALL_PSYMTABS): Remove.
11780         * compile/compile-object-run.c (do_module_cleanup): Use
11781         all_objfiles.
11782         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11783         * cp-support.c (add_symbol_overload_list_qualified): Use
11784         all_objfiles.
11785         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11786         Use all_objfiles.
11787         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11788         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11789         all_objfiles.
11790         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11791         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11792         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11793         Uses all_objfiles.
11794         * solib.c (solib_read_symbols): Use all_objfiles
11795
11796 2019-01-09  Tom Tromey  <tom@tromey.com>
11797
11798         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11799         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11800         all_objfiles.
11801         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11802         * symmisc.c (print_symbol_bcache_statistics)
11803         (print_objfile_statistics, maintenance_print_objfiles)
11804         (maintenance_info_symtabs, maintenance_check_symtabs)
11805         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11806         all_objfiles.
11807         * source.c (forget_cached_source_info): Use all_objfiles.
11808         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11809         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11810         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11811         * objfiles.c (update_section_map): Use all_objfiles.
11812         (shared_objfile_contains_address_p): Likewise.
11813         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11814         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11815
11816 2019-01-09  Tom Tromey  <tom@tromey.com>
11817
11818         * common/next-iterator.h: New file.
11819         * objfiles.h (class all_objfiles): New.
11820         (struct objfile_iterator): New.
11821
11822 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11823
11824         * NEWS: Move the description of the changed "frame", "select-frame",
11825          and "info frame" commands to the Changed commands section.
11826
11827 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11828
11829         * gdbtypes.c (check_stub_method_group): Remove handling of old
11830         mangling schemes.
11831         * linespec.c (find_methods): Likewise.
11832         * stabsread.c (read_member_functions): Likewise.
11833         * valops.c (search_struct_method): Likewise.
11834         (value_struct_elt_for_reference): Likewise.
11835         * NEWS: Mention this change.
11836
11837 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11838
11839         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11840         print_source_lines.
11841         * source.c (print_source_lines_base): Update line number check.
11842         (print_source_lines): New function.
11843         (source_lines_range::source_lines_range): New function.
11844         * source.h (class source_lines_range): New class.
11845         (print_source_lines): New declaration.
11846
11847 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11848
11849         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11850
11851 2019-01-08  Tom Tromey  <tom@tromey.com>
11852             Simon Marchi  <simon.marchi@ericsson.com>
11853
11854         PR gdb/24060
11855         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11856         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11857         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11858         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11859         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11860         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11861
11862 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11863
11864         * source.c (select_source_symtab): Move header comment to
11865         declaration in source.h.
11866         (forget_cached_source_info_for_objfile): Likewise.
11867         (forget_cached_source_info): Likewise.
11868         (identify_source_line): Likewise.
11869         * source.h (identify_source_line): Move declaration from symtab.h
11870         and add comment from source.c
11871         (print_source_lines): Likewise.
11872         (forget_cached_source_info_for_objfile): Likewise.
11873         (forget_cached_source_info): Likewise.
11874         (select_source_symtab): Likewise.
11875         (enum print_source_lines_flag): Move definition from symtab.h.
11876         * symtab.h (identify_source_line): Move declaration to source.h.
11877         (print_source_lines): Likewise.
11878         (forget_cached_source_info_for_objfile): Likewise.
11879         (forget_cached_source_info): Likewise.
11880         (select_source_symtab): Likewise.
11881         (enum print_source_lines_flag): Move definition to source.h.
11882         * tui/tui-hooks.c: Add 'source.h' include.
11883
11884 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11885
11886         * source.c (print_source_lines_base): Handle requests to print
11887         reverse line number sequences, and guard against empty lines
11888         string.
11889
11890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11891
11892         * source.c (print_source_lines_base): Fix skip of '\r' if next
11893         character is '\n'.
11894
11895 2019-01-06  Tom Tromey  <tom@tromey.com>
11896
11897         * c-exp.y (struct c_parse_state) <macro_original_text,
11898         expansion_obstack>: New member.
11899         (macro_original_text, expansion_obstack): Remove globals.
11900         (scan_macro_expansion, scanning_macro_expansion)
11901         (finished_macro_expansion): Update.
11902         (scan_macro_cleanup): Remove.
11903         (yylex, c_parse): Update.
11904
11905 2019-01-06  Tom Tromey  <tom@tromey.com>
11906
11907         * c-exp.y (struct c_parse_state) <strings>: New member.
11908         (operator_stoken): Update.
11909
11910 2019-01-06  Tom Tromey  <tom@tromey.com>
11911
11912         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11913         (union type_stack_elt) <typelist_val>: Now a pointer to
11914         std::vector.
11915         (type_stack_cleanup): Don't declare.
11916         (push_typelist): Update.
11917         * parse.c (pop_typelist): Return a std::vector.
11918         (push_typelist): Take a std::vector.
11919         (follow_types): Update.  Do not free args.
11920         (type_stack_cleanup): Remove.
11921         * c-exp.y (struct c_parse_state): New.
11922         (cpstate): New global.
11923         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11924         (nonempty_typelist): Update.
11925         (func_mod): Create a new vector.
11926         (c_parse): Create a c_parse_state.
11927         (check_parameter_typelist): Do not delete params.
11928         (function_method): Update.  Do not delete type_list.
11929
11930 2019-01-06  Tom Tromey  <tom@tromey.com>
11931
11932         PR gdb/28155:
11933         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11934         check_typedef.
11935         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11936         (print_return_value): Likewise.
11937
11938 2019-01-05  Tom Tromey  <tom@tromey.com>
11939
11940         * contrib/cleanup_check.py: Remove.
11941         * contrib/gcc-with-excheck: Remove.
11942         * contrib/exsummary.py: Remove.
11943         * contrib/excheck.py: Remove.
11944
11945 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11946
11947         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11948         NULL. Initialize tpprev to NULL instead of assigning it
11949         to NULL on the next statement.
11950         * windows-nat.c (windows_delete_thread): Remove check for
11951         main_thread_id before printing thread exit notifications.
11952         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11953         Remove thread ID check against main_thread_id.
11954         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11955         windows_delete_thread.
11956         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11957
11958 2019-01-04  Tom Tromey  <tom@tromey.com>
11959
11960         * compile/compile.c (_initialize_compile): Use upper case for
11961         metasyntactic variables.
11962         * symmisc.c (_initialize_symmisc): Use upper case for
11963         metasyntactic variables.
11964         * psymtab.c (_initialize_psymtab): Use upper case for
11965         metasyntactic variables.
11966         * demangle.c (demangle_command): Use upper case for metasyntactic
11967         variables.
11968         (_initialize_demangler): Likewise.
11969         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11970         variables.
11971
11972 2019-01-03  Tom Tromey  <tom@tromey.com>
11973
11974         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11975
11976 2019-01-03  Tom Tromey  <tom@tromey.com>
11977
11978         * python/py-symtab.c (salpy_str): Update.
11979         (struct salpy_sal_object) <symtab>: Now a PyObject.
11980         (salpy_dealloc): Update.
11981         (del_objfile_sal): Use gdbpy_ref.
11982
11983 2019-01-03  Tom Tromey  <tom@tromey.com>
11984
11985         * python/py-type.c (convert_field): Use new_reference.  Return
11986         gdbpy_ref.
11987         (make_fielditem): Return gdbpy_ref.
11988         (typy_fields): Update.
11989         (typy_getitem): Update.
11990         (field_name): Return gdbpy_ref.  Use new_reference.
11991         (typy_iterator_iternext): Update.
11992
11993 2019-01-03  Tom Tromey  <tom@tromey.com>
11994
11995         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11996
11997 2019-01-03  Tom Tromey  <tom@tromey.com>
11998
11999         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12000         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12001         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12002         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12003         (pspy_set_type_printers): Likewise.
12004         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12005         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12006         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12007         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12008         (objfpy_set_type_printers): Likewise.
12009
12010 2019-01-03  Tom Tromey  <tom@tromey.com>
12011
12012         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12013         (gdbpy_print_stack): Use gdbpy_err_fetch.
12014         * python/python-internal.h (class gdbpy_err_fetch): New class.
12015         (class gdbpy_enter) <m_error_type, m_error_value,
12016         m_error_traceback>: Remove.
12017         <m_error>: New member.
12018         (gdbpy_exception_to_string): Don't declare.
12019         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12020         * python/py-value.c (convert_value_from_python): Use
12021         gdbpy_err_fetch.
12022         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12023         gdbpy_exception_to_string.
12024         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12025         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12026         gdbpy_err_fetch.
12027
12028 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12029
12030         * linux-nat.c (delete_lwp_cleanup): Delete.
12031         (struct lwp_deleter): New struct.
12032         (lwp_info_up): New typedef.
12033         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12034         lwp_info_up.
12035
12036 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12037
12038         * linux-fork.c (class scoped_switch_fork_info): New class.
12039         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12040
12041 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12042
12043         * valops.c (find_overload_match): Remove use of null_cleanup, and
12044         calls to do_cleanups.
12045
12046 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12047
12048         * compile/compile-cplus-types.c
12049         (compile_cplus_instance::decl_name): Handle changes to
12050         cp_func_name.
12051         * cp-support.c (cp_func_name): Update header comment, update
12052         return type.
12053         * cp-support.h (cp_func_name): Update return type in declaration.
12054         * valops.c (find_overload_match): Move temp_func local to top
12055         level of function and change its type.  Use temp_func to hold and
12056         delete temporary string obtained from cp_func_name.
12057
12058 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12059
12060         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12061         gdb::char_vector, remove cleanup, and update uses of `msg`.
12062
12063 2019-01-03  Jim Wilson  <jimw@sifive.com>
12064
12065         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12066
12067 2019-01-02  Tom Tromey  <tom@tromey.com>
12068
12069         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12070         (tdesc_parse_xml): Remove cleanups.
12071         * target-descriptions.h (make_cleanup_free_target_description):
12072         Don't declare.
12073         (target_desc_deleter): New struct.
12074         (target_desc_up): New typedef.
12075         * target-descriptions.c (target_desc_deleter::operator()): Rename
12076         from free_target_description.
12077         (make_cleanup_free_target_description): Remove.
12078
12079 2019-01-02  Tom Tromey  <tom@tromey.com>
12080
12081         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12082         constructor, destructor.
12083         (linespec_parser): Remove typedef.
12084         (~linespec_parser): Rename from linespec_parser_delete.
12085         (linespec_lex_to_end, linespec_complete_label)
12086         (linespec_complete): Update.
12087         (decode_line_full): Remove cleanups.
12088         (decode_line_1): Update.
12089
12090 2019-01-02  Tom Tromey  <tom@tromey.com>
12091
12092         * python/python-internal.h (inferior_to_inferior_object): Change
12093         return type.
12094         * python/py-exitedevent.c (create_exited_event_object): Update.
12095         * python/py-inferior.c (inferior_to_inferior_object): Return
12096         gdbpy_ref.
12097         (python_new_inferior, python_inferior_deleted)
12098         (thread_to_thread_object, delete_thread_object)
12099         (build_inferior_list, gdbpy_selected_inferior): Update.
12100         * python/py-infthread.c (create_thread_object): Update.  Also fail
12101         if inferior_to_inferior_object fails.
12102
12103 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12104
12105         * inferior.h (class inferior) <displaced_step_state>: New field.
12106         * infrun.h (struct displaced_step_state): Move here from
12107         infrun.c.  Initialize fields, add constructor.
12108         <inf>: Remove field.
12109         <reset>: New method.
12110         * infrun.c (struct displaced_step_inferior_state): Move to
12111         infrun.h.
12112         (displaced_step_inferior_states): Remove.
12113         (get_displaced_stepping_state): Adust.
12114         (displaced_step_in_progress_any_inferior): Adjust.
12115         (displaced_step_in_progress_thread): Adjust.
12116         (displaced_step_in_progress): Adjust.
12117         (add_displaced_stepping_state): Remove.
12118         (get_displaced_step_closure_by_addr): Adjust.
12119         (remove_displaced_stepping_state): Remove.
12120         (infrun_inferior_exit): Call displaced_step_state.reset.
12121         (use_displaced_stepping): Don't check for NULL.
12122         (displaced_step_prepare_throw): Call
12123         get_displaced_stepping_state.
12124         (displaced_step_fixup): Don't check for NULL.
12125         (prepare_for_detach): Don't check for NULL.
12126
12127 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12128
12129         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12130          in case of call that did not complete.
12131
12132 2019-01-02  Andrey Utkin  <autkin@undo.io>
12133
12134         * symfile.c (find_separate_debug_file): Fix search of debug files for
12135         remote debuggee.
12136
12137 2019-01-02  Tom Tromey  <tom@tromey.com>
12138
12139         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12140         indentation.
12141         * python/py-frame.c (frapy_older): Remove cast.
12142         (frapy_newer): Likewise.
12143         * python/py-breakpoint.c (local_setattro): Remove cast.
12144         * python/py-arch.c (archpy_name): Remove local variable.
12145         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12146
12147 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12148
12149         * unittests/basic_string_view/element_access/char/empty.cc:
12150         Fix year range in copyright header.
12151
12152 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12153
12154         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12155         Delete.
12156         <operator==>: Update with for removed field.
12157         <hash>: Likewise.
12158         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12159         <isa_features>: ...this.
12160         <abi_features>: New field.
12161         (riscv_isa_flen): Update comment.
12162         (riscv_abi_xlen): New declaration.
12163         (riscv_abi_flen): New declaration.
12164         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12165         isa_features.
12166         (riscv_abi_xlen): New function.
12167         (riscv_isa_flen): Update to get answer from isa_features.
12168         (riscv_abi_flen): New function.
12169         (riscv_has_fp_abi): Update to get answer from abi_features.
12170         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12171         xlen and flen.
12172         (riscv_call_info) <xlen, flen>: Update comment.
12173         (riscv_call_arg_struct): Remove invalid assertions
12174         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12175         is removed.
12176         (riscv_gdbarch_init): Gather isa features and abi features
12177         separately, ensure both match on the gdbarch when reusing an old
12178         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12179         a target with 64-bit float hardware.
12180
12181 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12182
12183         * source.c (search_command_helper): Stop reverse search
12184         when line 1 has been searched.
12185
12186 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12187
12188         * record-full.c (record_full_base_target::close): Rewrite
12189         record_full_core_buf_list free logic.
12190
12191 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12192
12193         * break-catch-syscall.c (print_one_catch_syscall): xfree
12194         the last text.
12195
12196 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12197
12198         * top.c (print_gdb_version): Update Copyright year in version
12199         message.
12200
12201 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12202
12203         Update copyright year range in all GDB files.
12204
12205 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12206
12207         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12208
12209 For older changes see ChangeLog-2018.
12210 \f
12211 Local Variables:
12212 mode: change-log
12213 left-margin: 8
12214 fill-column: 74
12215 version-control: never
12216 coding: utf-8
12217 End:
12218