gdb/ChangeLog

   1 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
   4         log10 to double to fix Solaris 11 with gcc 5.5.
   5
   6 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
   9         "sun" to "saddr_un".
  10
  11 2019-12-19  Tom Tromey  <tromey@adacore.com>
  12
  13         * ui-out.h (enum class field_kind): Fix comment.
  14
  15 2019-12-11  Tom Tromey  <tromey@adacore.com>
  16
  17         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
  18
  19 2019-12-18  Tom Tromey  <tromey@adacore.com>
  20
  21         PR build/25268:
  22         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
  23         type on macOS.  Add comment.
  24
  25 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  26
  27         * c-lang.c (c_get_string, asm_language_defn): Remove space
  28         before tab.
  29
  30 2019-12-18  Tom Tromey  <tromey@adacore.com>
  31
  32         PR build/25250:
  33         * ui-out.c (ui_out::vmessage): Update.
  34         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  35         Rename.
  36         (string_field): Update.
  37         (signed_field): Update.
  38
  39 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  40
  41         * top.c (print_gdb_configuration): Adjust indentation.
  42
  43 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
  44
  45         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
  46
  47 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
  48
  49         * tui/tui-layout.h (class tui_layout_base): Add virtual
  50         destructor.
  51
  52 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  53
  54         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  55         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  56         (process_event_stop_test): Keep stepping over skipped inline functions.
  57
  58 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  59
  60         * jit.c (struct gdb_block) <next>: Remove field.
  61         (struct gdb_symtab) <~gdb_symtab>: Remove.
  62         <blocks>: Change type to std::forward_list<gdb_block>.
  63         (compare_block): Remove.
  64         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  65         block at the beginning, don't mind about sorting.
  66         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  67         before using it.
  68
  69 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  70
  71         * jit.c (struct gdb_block): Add constructor, initialize
  72         real_block and next fields.
  73         <name>: Change type to gdb::unique_xmalloc_ptr.
  74         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  75         (jit_block_open_impl): Allocate gdb_block with new.
  76         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  77
  78 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  79
  80         * jit.c: Include forward_list.
  81         (struct gdb_symtab) <next>: Remove field.
  82         (struct gdb_object) <symtabs>: Change type to
  83         std::forward_list<gdb_symtab>.
  84         (jit_object_open_impl): Allocate gdb_object with new.
  85         (jit_symtab_open_impl): Adjust to std::forward_list.
  86         (finalize_symtab): Don't delete symtab.
  87         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  88         gdb_object with delete.
  89
  90 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  91
  92         * jit.c (struct gdb_symtab): Add constructor, destructor,
  93         initialize fields.
  94         <linetable>: Change type to unique_xmalloc_ptr.
  95         <file_name>: Change type to std::string.
  96         (jit_symtab_open_impl): Allocate gdb_symtab with new.
  97         (jit_symtab_line_mapping_add_impl): Adjust.
  98         (finalize_symtab): Adjust, call delete on stab.
  99
 100 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 101
 102         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 103
 104 2019-12-16  Tom Tromey  <tromey@adacore.com>
 105
 106         * windows-nat.c (windows_nat_target::attach): Update.
 107         * remote.c (extended_remote_target::attach): Update.
 108         * procfs.c (procfs_target::attach): Update.
 109         * nto-procfs.c (nto_procfs_target::attach): Update.
 110         (nto_procfs_target::create_inferior): Update.
 111         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 112         * gnu-nat.c (gnu_nat_target::attach): Update.
 113         (gnu_nat_target::detach): Update.
 114         * darwin-nat.c (darwin_nat_target::attach): Update.
 115         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 116         return.
 117         * bsd-kvm.c (bsd_kvm_target_open): Update.
 118         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 119
 120 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 121
 122         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 123         (we no longer need to include time.h before pathmax.h)
 124
 125 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 126
 127         * ada-exp.y (write_ambiguous_var): Update.
 128         * coffread.c (process_coff_symbol): Update.
 129         * ctfread.c (ctf_add_enum_member_cb): Update.
 130         (new_symbol): Update.
 131         * dwarf2read.c (fixup_go_packaging): Update.
 132         (new_symbol): Update.
 133         * language.c (language_alloc_type_symbol): Update.
 134         * mdebugread.c (new_symbol): Update.
 135         * minsyms.c (minimal_symbol_reader::record_full): Update.
 136         * psymtab.c (add_psymbol_to_bcache): Update.
 137         * stabsread.c (define_symbol): Update.
 138         (read_enum_type): Update.
 139         * symtab.c (symbol_set_language): Make this a member function...
 140         (general_symbol_info::set_language): ... here.
 141         * symtab.h (struct general_symbol_info) <set_language>: New function.
 142         (SYMBOL_SET_LANGUAGE): Remove.
 143         (symbol_set_language): Remove.
 144
 145 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 146
 147         * ada-lang.c (ada_add_block_symbols): Update.
 148         (ada_collect_symbol_completion_matches): Update.
 149         * ax-gdb.c (gen_expr): Update.
 150         * block.c (block_lookup_symbol): Update.
 151         (block_lookup_symbol_primary): Update.
 152         (block_find_symbol): Update.
 153         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 154         * dbxread.c (process_one_symbol): Update.
 155         * dictionary.c (insert_symbol_hashed): Update.
 156         (collate_pending_symbols_by_language): Update.
 157         (mdict_add_symbol): Update.
 158         * dwarf-index-write.c (write_psymbols): Update.
 159         * dwarf2read.c (fixup_go_packaging): Update.
 160         * findvar.c (read_var_value): Update.
 161         * ft32-tdep.c (ft32_skip_prologue): Update.
 162         * go-lang.c (go_symbol_package_name): Update.
 163         * language.h (scoped_switch_to_sym_language_if_auto::
 164         scoped_switch_to_sym_language_if_auto): Update.
 165         * linespec.c (find_method): Update.
 166         (find_label_symbols_in_block): Update.
 167         * mdebugread.c (parse_symbol): Update.
 168         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 169         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 170         (minimal_symbol_reader::install): Update.
 171         * moxie-tdep.c (moxie_skip_prologue): Update.
 172         * parse.c (parse_exp_in_context): Update.
 173         * psymtab.c (psymbol_name_matches): Update.
 174         (match_partial_symbol): Update.
 175         (lookup_partial_symbol): Update.
 176         (psymbol_hash): Update.
 177         (psymbol_compare): Update.
 178         * python/py-framefilter.c (extract_sym): Update.
 179         (py_print_single_arg): Update.
 180         * stabsread.c (define_symbol): Update.
 181         * stack.c (print_frame_arg): Update.
 182         (find_frame_funname): Update.
 183         (info_frame_command_core): Update.
 184         * symfile.c (set_initial_language): Update.
 185         * symtab.c (symbol_set_demangled_name): Update.
 186         (symbol_get_demangled_name): Update.
 187         (symbol_set_language): Update.
 188         (symbol_find_demangled_name): Update.
 189         (symbol_set_names): Update.
 190         (general_symbol_info::natural_name): Update.
 191         (general_symbol_info::demangled_name): Update.
 192         (general_symbol_info::search_name): Update.
 193         (symbol_matches_search_name): Update.
 194         (eq_symbol_entry): Update.
 195         (iterate_over_symbols): Update.
 196         (completion_list_add_symbol): Update.
 197         (completion_list_add_msymbol): Update.
 198         (completion_list_add_fields): Update.
 199         * symtab.h (struct general_symbol_info) <language>: New function.
 200         <language>: Rename to...
 201         <m_language>: ...this.
 202         (SYMBOL_LANGUAGE): Remove.
 203         (MSYMBOL_LANGUAGE): Remove.
 204         (struct symbol) <ctor>: Update.
 205         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 206
 207 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 208
 209         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 210         set the language of sym.
 211         * language.c (language_alloc_type_symbol): Likewise.
 212
 213 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 214
 215         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 216         PR gdb/23613
 217         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 218         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 219         (core_target_open): Use 'gdb_abspath'.
 220         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 221         'current_directory == NULL' case.
 222         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 223         explain what happens when 'current_directory' is NULL.
 224         * go32-nat.c (go32_nat_target::wait): Check if
 225         'current_directory' is NULL before call to 'chdir'.
 226         * source.c (add_path): Use 'gdb_abspath'.
 227         * top.c: Include 'gdbsupport/pathstuff.h'.
 228         (init_history): Use 'gdb_abspath'.
 229         (set_history_filename): Likewise.
 230         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 231         (tfile_target_open): Use 'gdb_abspath'.
 232
 233 2019-12-13  Tom Tromey  <tromey@adacore.com>
 234
 235         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 236         warning or error.
 237
 238 2019-12-13  Tom Tromey  <tromey@adacore.com>
 239
 240         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 241
 242 2019-12-13  Tom Tromey  <tromey@adacore.com>
 243
 244         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 245
 246 2019-12-13  Tom Tromey  <tromey@adacore.com>
 247
 248         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 249
 250 2019-12-13  Tom Tromey  <tromey@adacore.com>
 251
 252         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 253         (string_vappendf): Add ARI comment.
 254
 255 2019-12-13  Tom Tromey  <tromey@adacore.com>
 256
 257         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 258         floatformat_to_double.
 259         * target-float.c (host_float_ops<T>::from_target): Add ARI
 260         comment.
 261
 262 2019-12-13  Tom Tromey  <tromey@adacore.com>
 263
 264         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 265         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 266         ARI marker to abort.
 267         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 268
 269 2019-12-13  Tom Tromey  <tromey@adacore.com>
 270
 271         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 272
 273 2019-12-13  Tom Tromey  <tromey@adacore.com>
 274
 275         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 276
 277 2019-12-13  Tom Tromey  <tromey@adacore.com>
 278
 279         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 280         checks.
 281
 282 2019-12-13  Tom Tromey  <tromey@adacore.com>
 283
 284         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 285         end>: No longer "const".
 286
 287 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 288
 289         * jit.c: Fix indentation, replace spaces with tabs where
 290         applicable.
 291
 292 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 293
 294         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 295
 296 2019-12-12  Tom Tromey  <tom@tromey.com>
 297
 298         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 299         unique_ptr.
 300
 301 2019-12-12  Tom Tromey  <tom@tromey.com>
 302
 303         * progspace.h (objfile_list): New typedef.
 304         (class unwrapping_objfile_iterator)
 305         (struct unwrapping_objfile_range): Newl
 306         (struct program_space) <objfiles_range>: Change type.
 307         <objfiles>: Change return type.
 308         <add_objfile>: Change type of "objfile" parameter.
 309         <objfiles_list>: Now a list of shared_ptr.
 310         * progspace.c (program_space::add_objfile): Change type of
 311         "objfile".  Update.
 312         (program_space::remove_objfile): Update.
 313         * objfiles.h (struct objfile) <~objfile>: Make public.
 314         * objfiles.c (objfile::make): Update.
 315         (objfile::unlink): Don't call delete.
 316
 317 2019-12-12  Tom Tromey  <tom@tromey.com>
 318
 319         * symfile.c (symbol_file_clear): Update.
 320         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 321         method.
 322         * progspace.c (program_space::free_all_objfiles): New method.
 323         * objfiles.h (free_all_objfiles): Don't declare.
 324         * objfiles.c (free_all_objfiles): Move to program_space.
 325
 326 2019-12-12  Tom Tromey  <tom@tromey.com>
 327
 328         * progspace.c (program_space::add_objfile)
 329         (program_space::remove_objfile): Update.
 330         (program_space::multi_objfile_p): Remove.
 331         * objfiles.h (struct objfile) <next>: Remove.
 332         * objfiles.c (objfile::objfile): Update.
 333         (put_objfile_before): Update.
 334         (unlink_objfile): Update.
 335         * progspace.h (object_files): Remove.
 336         (struct program_space) <objfiles_head>: Remove.
 337         <objfiles_list>: New member.
 338         <objfiles_range, objfiles_safe_range>: Change type.
 339         (objfiles): Change return type.
 340         (objfiles_safe): Update.
 341         (multi_objfile_p): Rewrite and inline.
 342         (object_files): Remove macro.
 343
 344 2019-12-12  Tom Tromey  <tom@tromey.com>
 345
 346         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 347         second constructor.
 348         (basic_safe_range): New class.
 349
 350 2019-12-12  Tom Tromey  <tom@tromey.com>
 351
 352         * progspace.c (program_space::multi_objfile_p): New method.
 353         * printcmd.c (info_symbol_command): Update.
 354         * maint.c (maintenance_translate_address): Update.
 355         * objfiles.h (MULTI_OBJFILE_P): Remove.
 356         * progspace.h (struct program_space) <multi_objfile_p>: New
 357         method.
 358
 359 2019-12-12  Tom Tromey  <tom@tromey.com>
 360
 361         * progspace.h (struct program_space) <remove_objfile>: Declare.
 362         * progspace.c (program_space::remove_objfile): New method.
 363         * objfiles.c (unlink_objfile): Remove.
 364         (objfile::unlink): Call remove_objfile.
 365         (objfile): Don't call unlink_objfile.
 366
 367 2019-12-12  Tom Tromey  <tom@tromey.com>
 368
 369         * progspace.h (struct program_space) <add_objfile>: Declare
 370         method.
 371         * progspace.c (program_space::add_objfile): New method.
 372         * objfiles.c (~objfile): Don't unlink objfile.
 373         (put_objfile_before): Remove.
 374         (add_separate_debug_objfile): Don't call put_objfile_before.
 375         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 376         the per-program-space data.
 377
 378 2019-12-12  Tom Tromey  <tom@tromey.com>
 379
 380         * symfile.c (syms_from_objfile_1): Use objfile_up.
 381         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 382         method.
 383         (reread_symbols): Use objfile_up.
 384         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 385         unlink method.
 386         * objfiles.h (struct objfile) <~objfile>: Now private.
 387         <unlink>: New method.
 388         (struct objfile_deleter): New.
 389         (objfile_up): New typedef.
 390         * objfiles.c (objfile::unlink): New method.
 391         (free_objfile_separate_debug, free_all_objfiles)
 392         (objfile_purge_solibs): Use it.
 393         * jit.c (jit_unregister_code): Remove.
 394         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 395         objfile.
 396         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 397         objfile.
 398         * compile/compile-object-load.c (compile_object_load): Use
 399         objfile_up.
 400
 401 2019-12-12  Tom Tromey  <tom@tromey.com>
 402
 403         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 404         objfile::make.
 405         * objfiles.h (struct objjfile) <make>: No longer inline.
 406         (add_separate_debug_objfile): Don't declare.
 407         * objfiles.c (add_separate_debug_objfile): Now static.
 408         (objfile::make): Move from objfiles.h.  Call
 409         add_separate_debug_objfile.  Add "parent" parameter.
 410
 411 2019-12-12  Tom Tromey  <tom@tromey.com>
 412
 413         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 414         * objfiles.h (struct objfile): Make constructor private.
 415         <make>: New static method.
 416         * jit.c (jit_object_close_impl): Update.
 417
 418 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 419
 420         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 421         gdb::byte_vector.
 422
 423 2019-12-12  Tom Tromey  <tromey@adacore.com>
 424
 425         * xml-support.c (xml_fetch_content_from_file): Don't call
 426         malloc_failure.
 427         * utils.h (class gdb_argv): Remove malloc_failure comment.
 428         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 429
 430 2019-12-12  Tom Tromey  <tromey@adacore.com>
 431
 432         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 433         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 434         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 435         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 436         * riscv-ravenscar-thread.c: New file.
 437         * riscv-ravenscar-thread.h: New file.
 438         * riscv-tdep.c (riscv_gdbarch_init): Call
 439         register_riscv_ravenscar_ops.
 440
 441 2019-12-12  Tom Tromey  <tromey@adacore.com>
 442
 443         * gdbsupport/thread-pool.c (set_thread_name): Use
 444         ATTRIBUTE_UNUSED.
 445
 446 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 447
 448         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 449         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 450         macros.
 451
 452 2019-12-11  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-win.c (tui_set_win_height_command): Call
 455         tui_adjust_window_height.
 456         (tui_adjust_win_heights, new_height_ok): Remove.
 457         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 458         * tui/tui-layout.c (tui_adjust_window_height): New function.
 459
 460 2019-12-11  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-win.c (tui_resize_all): Remove code, call
 463         tui_apply_current_layout.
 464
 465 2019-12-11  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 468         * tui/tui-layout.c (standard_layouts, applied_layout): New
 469         globals.
 470         (tui_apply_current_layout): New function.
 471         (show_layout): Set applied_layout.  Call
 472         tui_apply_current_layout.
 473         (show_source_command, show_disasm_command)
 474         (show_source_disasm_command, show_data)
 475         (show_source_or_disasm_and_command): Remove.
 476         (initialize_layouts): New function.
 477         (_initialize_tui_layout): Call initialize_layouts.
 478
 479 2019-12-11  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-layout.h (class tui_layout_base)
 482         (class tui_layout_window, class tui_layout_split): New.
 483         * tui/tui-layout.c (tui_get_window_by_name)
 484         (tui_layout_window::clone, tui_layout_window::apply)
 485         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 486         (tui_layout_split::add_window, tui_layout_split::clone)
 487         (tui_layout_split::get_sizes)
 488         (tui_layout_split::set_weights_from_heights)
 489         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 490         functions.
 491         (tui_layout_split::add_split, tui_layout_split::add_split)
 492         (tui_layout_split::set_weights_from_heights)
 493         (tui_layout_split::set_weights_from_heights): New functions.
 494
 495 2019-12-11  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 498         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 499         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 500         * tui/tui-data.h (struct tui_point): Remove.
 501         (struct tui_gen_win_info) <origin>: Remove.
 502         <x, y>: New fields.
 503         * tui/tui-command.c (tui_cmd_window::resize): Update.
 504
 505 2019-12-11  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 508         Implement.
 509         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 510         Implement.
 511         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 512         method.
 513         (struct tui_win_info) <min_height>: Implement.
 514
 515 2019-12-11  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 518         (struct tui_win_info) <can_box>: Update.
 519
 520 2019-12-11  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 523         method.
 524         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 525         method.
 526         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 527         method.
 528         (struct tui_win_info) <max_height>: Now override.
 529
 530 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 531
 532         * NEWS: Create a new section for the next release branch.
 533         Rename the section of the current branch, now that it has
 534         been cut.
 535
 536 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 537
 538         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 539         * version.in: Bump version to 10.0.50.DATE-git.
 540
 541 2019-12-11  Tom Tromey  <tromey@adacore.com>
 542
 543         PR build/25268:
 544         * gdbsupport/thread-pool.c (set_thread_name): New function.
 545         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 546         (thread_pool::thread_function): Call set_thread_name.
 547
 548 2019-12-11  Tom Tromey  <tromey@adacore.com>
 549
 550         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 551         bfd_get_signed_8.
 552
 553 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 554
 555         * NEWS: Document -raw-values option and the related setting commands.
 556         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 557         only set it on when /r is given.
 558         * valprint.c (value_print_option_defs): New element raw-values.
 559         * Makefile.in: Add the new file.
 560
 561 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 562
 563         * gdbsupport/safe-strerror.c: Supress the unused function warning
 564         for select_strerror_r.
 565
 566 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 567
 568         * config.in: Regenerate.
 569         * configure: Regenerate.
 570         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 571         safe_strerror instead of strerror.
 572         * gdbsupport/common.m4: Don't check for strerror.
 573         * gdbsupport/safe-strerror.c: Support both the glibc version
 574         of strerror_r and the XSI version.
 575
 576 2019-12-10  Tom Tromey  <tromey@adacore.com>
 577
 578         * ada-typeprint.c (print_choices): Use a single "?".
 579         (print_variant_part): Print "?" if the discriminant name
 580         is not known.
 581
 582 2019-12-10  George Barrett  <bob@bob131.so>
 583
 584         Fix scripted probe breakpoints.
 585         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 586         declaration forward.
 587         (breakpoint_ops_for_event_location_type)
 588         (breakpoint_ops_for_event_location): Add function definitions.
 589         (break_command_1, trace_command): Use
 590         breakpoint_ops_for_event_location.
 591         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 592         declarations.
 593         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 594         breakpoint_ops_for_event_location.
 595         * python/py-breakpoint.c (bppy_init): Use
 596         breakpoint_ops_for_event_location.
 597
 598 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 599
 600         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 601         when ranking an lvalue argument for an rvalue parameter.
 602
 603 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 604
 605         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 606         template argument for scoped_restore_tmpl from bool to int.
 607
 608 2019-12-07  Keith Seitz  <keiths@redhat.com>
 609
 610         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 611         (build_id_to_debug_bfd): Make static, rewriting to use
 612         build_id_to_bfd_suffix.
 613         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 614         adding `suffix' parameter. Append SUFFIX to file names
 615         when searching for matching files.
 616         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 617         (build_id_to_exec_bfd): Likewise.
 618         * build-id.h (build_id_to_debug_bfd): Clarify that function
 619         searches for BFD of debug info file.
 620         (build_id_to_exec_bfd): Declare.
 621         * corelow.c: Include build-id.h.
 622         (locate_exec_from_corefile_build_id): New function.
 623         (core_target_open): If no executable BFD is found,
 624         search for a core file BFD using build-id.
 625
 626 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 627
 628         * bcache.c: Put in namespace gdb.
 629         * bcache.h: Likewise.
 630         * gdbtypes.c (check_types_worklist): Update.
 631         (types_deeply_equal): Update.
 632         * macrotab.c (struct macro_table) <bcache>: Update.
 633         (new_macro_table): Update.
 634         * macrotab.h (struct bcache): Put this forward declaration
 635         inside namespace gdb.
 636         (new_macro_table): Update.
 637         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 638         Update.
 639         <macro_cache>: Update.
 640         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 641
 642 2019-12-06  Tom de Vries  <tdevries@suse.de>
 643
 644         PR symtab/24971
 645         * block.c (best_symbol, better_symbol): New function.
 646         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 647         decl.
 648
 649 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 650
 651         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 652         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 653         for ranking see-through reference cases.
 654
 655 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 656         * stack.c (faas_command): Check a command is provided.
 657         * thread.c (taas_command, tfaas_command): Likewise.
 658
 659 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 660         * inferior.c (prune_inferiors):  Only call delete_inferior,
 661         Do not modify the inferior list.
 662
 663 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 664
 665         * c-exp.y: Update calls to lookup_typename,
 666         lookup_signed_typename and lookup_unsigned_typename.
 667         * c-lang.c (evaluate_subexp_c): Likewise.
 668         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 669         Likewise.
 670         * eval.c (binop_promote): Likewise.
 671         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 672         (lookup_unsigned_typename): Likewise.
 673         (lookup_signed_typename): Likewise.
 674         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 675         (lookup_signed_typename): Likewise.
 676         (lookup_typename): Likewise.
 677         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 678         lookup_typename, lookup_signed_typename,
 679         lookup_unsigned_typename.
 680         * m2-exp.y: Likewise.
 681         * printcmd.c (printf_wide_c_string): Likewise.
 682         (ui_printf): Likewise.
 683         * python/py-type.c (typy_lookup_typename): Likewise.
 684         * python/py-xmethods.c (python_xmethod_worker::invoke):
 685         Likewise.
 686         * rust-exp.y: Likewise.
 687
 688 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 689
 690         * configure.nat (obsd64): Add missing files x86-nat.o and
 691         nat/x86-dregs.o.
 692
 693 2019-12-04  Tom Tromey  <tom@tromey.com>
 694
 695         * valprint.c (val_print_string): Use metadata_style.
 696         * go-valprint.c (print_go_string): Use metadata style.
 697         * p-valprint.c (pascal_object_print_static_field): Use metadata
 698         style.
 699         * cp-valprint.c (cp_print_static_field): Use metadata style.
 700
 701 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 702             Chris January  <chris.january@arm.com>
 703
 704         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 705         tokens.
 706         (typebase): New patterns for complex, single/double precision, and
 707         single/double complex.
 708         (f77_keywords): Change token for complex keyword, and add single,
 709         double, and precision keywords.
 710
 711 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 712
 713         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 714         "info io_registers".
 715
 716 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 717
 718         * regcache.c (cooked_read_test): Initialize thread list of
 719         mock_inferior.
 720
 721 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 722
 723         * aarch64-linux-tdep.c: Remove includes.
 724
 725 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 726
 727         * aarch64-tdep.c: Remove includes.
 728
 729 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 730
 731         * filtered-iterator.h (filtered_iterator) <operator==,
 732         operator!=>: Compare wrapped iterators, not wrapped pointers.
 733         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 734         unittests/filtered_iterator-selftests.c.
 735         * unittests/filtered_iterator-selftests.c: New file.
 736
 737 2019-12-04  Tom Tromey  <tromey@adacore.com>
 738
 739         * gdbtypes.c (create_range_type): Inherit endianity
 740         from base type.
 741
 742 2019-12-04  Tom Tromey  <tromey@adacore.com>
 743
 744         * ada-lang.c (decode_constrained_packed_array)
 745         (ada_value_assign, value_assign_to_component): Update.
 746         * dwarf2loc.c (rw_pieced_value, access_memory)
 747         (dwarf2_compile_expr_to_ax): Update.
 748         * dwarf2read.c (dwarf2_add_field): Update.
 749         * eval.c (evaluate_subexp_standard): Update.
 750         * gdbarch.c, gdbarch.h: Rebuild.
 751         * gdbarch.sh (bits_big_endian): Remove.
 752         * gdbtypes.h (union field_location): Update comment.
 753         * target-descriptions.c (make_gdb_type): Update.
 754         * valarith.c (value_bit_index): Update.
 755         * value.c (struct value) <bitpos>: Update comment.
 756         (unpack_bits_as_long, modify_field): Update.
 757         * value.h (value_bitpos): Update comment.
 758
 759 2019-12-04  Tom Tromey  <tromey@adacore.com>
 760
 761         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 762         endian-ness.
 763
 764 2019-12-04  Tom Tromey  <tromey@adacore.com>
 765
 766         * dwarf2read.c (dwarf2_init_float_type)
 767         (dwarf2_init_complex_target_type): Add byte_order parameter.
 768         (read_base_type): Compute byte order earlier.
 769         * gdbtypes.c (init_float_type): Add byte_order parameter.
 770         * gdbtypes.h (init_float_type): Add byte_order parameter.
 771
 772 2019-12-04  Tom Tromey  <tromey@adacore.com>
 773
 774         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 775
 776 2019-12-04  Tom Tromey  <tromey@adacore.com>
 777
 778         * dwarf2read.c (process_structure_scope): Initialize
 779         "discr_offset".
 780
 781 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 782
 783         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 784         add it into the search spec.
 785         (parse_max_results_option): New function.
 786         (mi_info_functions_or_variables): Parse -max-results flag and pass
 787         it to mi_symbol_info.
 788         (mi_cmd_symbol_info_modules): Likewise.
 789         (mi_cmd_symbol_info_types): Likewise.
 790         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 791         return type to bool, change result container into a set, and don't
 792         add new results if we have enough already.
 793         (global_symbol_searcher::add_matching_msymbols): Change return
 794         type to bool, and don't add new results if we have enough already.
 795         (sort_search_symbols_remove_dups): Delete.
 796         (global_symbol_searcher::search): Early exit from search loop when
 797         we have enough results.  Use a std::set to collect the results
 798         from calling add_matching_symbols.
 799         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 800         member function.
 801         (global_symbol_searcher) <m_max_search_results>: New member
 802         variable.
 803         (global_symbol_searcher) <add_matching_symbols>: Update header
 804         comment and change return type to bool.
 805         (global_symbol_searcher) <add_matching_msymbols>: Update header
 806         comment and change return type to bool.
 807
 808 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * symtab.c (symbol_search::compare_search_syms): Update header
 811         comment.
 812         (global_symbol_searcher::is_suitable_msymbol): New function.
 813         (global_symbol_searcher::expand_symtabs): New function.
 814         (global_symbol_searcher::add_matching_symbols): New function.
 815         (global_symbol_searcher::add_matching_msymbols): New function.
 816         (global_symbol_searcher::search): Move most of the content
 817         into the new functions above, and call them as needed.
 818         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 819         function.
 820         (global_symbol_searcher) <add_matching_symbols>: New member
 821         function.
 822         (global_symbol_searcher) <add_matching_msymbols>: New member
 823         function.
 824         (global_symbol_searcher) <is_suitable_msymbol>: New member
 825         function.
 826
 827 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 830         -symbol-info-module-variables entries.
 831         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 832         (mi_cmd_symbol_info_module_variables): Declare.
 833         * mi/mi-symbol-cmds.c
 834         (module_symbol_search_iterator): New typedef.
 835         (output_module_symbols_in_single_module_and_file): New function.
 836         (output_module_symbols_in_single_module): New function.
 837         (mi_info_module_functions_or_variables): New function.
 838         (mi_cmd_symbol_info_module_functions): New function.
 839         (mi_cmd_symbol_info_module_variables): New function.
 840         * NEWS: Mention new MI command.
 841
 842 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 843
 844         * bcache.c (hash): Remove.
 845         (hash_continue): Remove.
 846         * bcache.h (hash): Remove.
 847         (hash_continue): Remove.
 848         (struct bcache) <ctor>: Update.
 849         * psymtab.c (psymbol_hash): Update.
 850         * stabsread.c (hashname): Update.
 851         * utils.h (fast_hash): Add an argument for a start value,
 852         defaulting to zero.
 853
 854 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 855         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 856         (destroy_block_symbol_cache): New function.
 857         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 858         (resize_symbol_cache): Likewise.
 859
 860 2019-12-02  Tom Tromey  <tom@tromey.com>
 861
 862         * unittests/tui-selftests.c (run_tests): Make conditional.
 863         (_initialize_tui_selftest): Make conditional.
 864
 865 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 866
 867         * aix-thread.c (debug_aix_thread): Change type to bool.
 868
 869 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 870
 871         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 872
 873 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 874
 875         * dwarf2read.c (read_tag_string_type): Read the fields required to
 876         make a dynamic string, and possibly create a dynamic range for the
 877         string.
 878         (attr_to_dynamic_prop): Setup is_reference based on the type of
 879         attribute being processed.
 880         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 881         (resolve_dynamic_array): Rename to...
 882         (resolve_dynamic_array_or_string): ...this, update header comment,
 883         and accept TYPE_CODE_STRING.
 884         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 885
 886 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 889         of its implementation from...
 890         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 891         the new function.
 892
 893 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 896         create a range with stride where appropriate.
 897         * f-valprint.c: Include 'gdbarch.h'.
 898         (f77_print_array_1): Take the stride into account when walking the
 899         array.  Also convert the stride into addressable units.
 900         * gdbtypes.c (create_range_type): Initialise the stride to
 901         constant zero.
 902         (create_range_type_with_stride): New function, initialise the
 903         range as normal, and then setup the stride.
 904         (has_static_range): Include the stride here.  Also change the
 905         return type to bool.
 906         (create_array_type_with_stride): Consider the range stride if the
 907         array isn't given its own stride.
 908         (resolve_dynamic_range): Resolve the stride if needed.
 909         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 910         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 911         (TYPE_BIT_STRIDE): Define.
 912         (TYPE_ARRAY_BIT_STRIDE): Define.
 913         (create_range_type_with_stride): Declare.
 914         * valarith.c (value_subscripted_rvalue): Take range stride into
 915         account when walking the array.
 916
 917 2019-12-01  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 920         specially.
 921
 922 2019-12-01  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 925         \0.
 926         * unittests/tui-selftests.c: New file.
 927         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 928
 929 2019-12-01  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 932
 933 2019-12-01  Tom Tromey  <tom@tromey.com>
 934
 935         * NEWS: Document new settings.
 936         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 937         * tui/tui-win.c (_initialize_tui_win): Add border style
 938         observers.
 939         * tui/tui-io.h (tui_apply_style): Declare.
 940         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 941         longer static.
 942         (apply_ansi_escape, tui_set_reverse_mode): Update.
 943         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 944         Add "skip_intensity" parameter.
 945         <changed>: New member.
 946         <do_set_value>: Declare.
 947         (tui_border_style, tui_active_border_style): Declare.
 948         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 949         globals.
 950         (cli_style_option): Initialize "changed".
 951         (cli_style_option::do_set_value): New function.
 952         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 953         parameter.  Update.
 954         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 955         (_initialize_cli_style): Update.  Create TUI border style
 956         commands.
 957
 958 2019-12-01  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 961         parameter.
 962         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 963         parameter.
 964         * tui/tui-win.h (compact_source): Declare.
 965         * tui/tui-win.c (compact_source): New global.
 966         (tui_set_compact_source, tui_show_compact_source): New functions.
 967         (_initialize_tui_win): Add "compact-source" setting.
 968         * tui/tui-source.c (tui_source_window::set_contents): Handle
 969         compact_source setting.
 970         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 971         * NEWS: Document new setting.
 972
 973 2019-11-30  Tom Tromey  <tom@tromey.com>
 974
 975         * dwarf2read.c (dwarf2_add_field): Include field offset when
 976         computing variant part length.
 977
 978 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 979         * NEWS:  Mention define-prefix.  Tell that command names can now
 980         contain a . character.
 981
 982 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 983
 984         * command.h (valid_cmd_char_p): Declare.
 985         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 986         the check of valid command char.
 987         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 988         valid_cmd_char_p.
 989         * cli/cli-script.c (validate_comname): Likewise.
 990         * completer.c (gdb_completer_command_word_break_characters):
 991         Do not remove . from the word break char, update comments.
 992         (complete_line_internal_1): Use valid_cmd_char_p.
 993         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 994         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 995
 996 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 997
 998         * cli/cli-script.c (do_define_command): Ensure a redefined
 999         prefix command is kept as a prefix command.
1000         (define_prefix_command): New function.
1001         (show_user_1): Report user defined prefixes.
1002         (_initialize_cli_script):  Create the new 'define-prefix' command.
1003         Add completers for 'define' and 'document'.
1004         * top.c (execute_command):  If command is a user-defined prefix only
1005         command, report the list of commands for this prefix command.
1006
1007 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1008
1009         * valops.c (find_oload_champ): Improve debug output.
1010
1011 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1012
1013         * valops.c (find_oload_champ): Print part of debug messages
1014         before the badness vector is std::move'd.
1015
1016 2019-11-28  Tom Tromey  <tom@tromey.com>
1017
1018         * value.c (creal_internal_fn): Fix comment.
1019
1020 2019-11-28  Tom Tromey  <tom@tromey.com>
1021
1022         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1023         flag_bound_evaluated>: Now unsigned.
1024
1025 2019-11-28  Tom Tromey  <tom@tromey.com>
1026
1027         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1028         declare.
1029
1030 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1031
1032         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1033         debug output.
1034         * jit.c (jit_unregister_code): Add debug print to match
1035         `jit_register_code`.
1036
1037 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1038
1039         * NEWS: Mention the new multithreaded symbol loading.
1040
1041 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1042
1043         * maint.c (n_worker_threads): Default to 0.
1044         (worker_threads_disabled): New function.
1045         * maint.h (worker_threads_disabled): New function.
1046         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1047         here if worker_threads_disabled () is true.
1048         (minimal_symbol_reader::install): Skip all threading if
1049         worker_threads_disabled () is true.
1050
1051 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1054         hash code if possible.
1055         (add_minsym_to_demangled_hash_table): Likewise.
1056         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1057         on the background thread.
1058         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1059         Add these fields.
1060
1061 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1062
1063         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1064         of the mangled name on the background thread.
1065         * symtab.c (symbol_set_names): Allow passing in the hash of the
1066         linkage_name.
1067         * symtab.h (symbol_set_names): Likewise.
1068
1069 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1070
1071         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1072         physnames are computed for inherited DIEs.
1073
1074 2019-11-27  Tom Tromey  <tromey@adacore.com>
1075
1076         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1077         backslashes.
1078         * cp-support.c: Remove unnecessary backslashes.
1079
1080 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1081
1082         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1083         with sym->set_linkage_name.
1084         * coffread.c (coff_read_enum_type): Likewise.
1085         * mdebugread.c (parse_symbol): Likewise.
1086         * stabsread.c (patch_block_stabs): Likewise.
1087         (define_symbol): Likewise.
1088         (read_enum_type): Likewise.
1089         (common_block_end): Likewise.
1090         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1091         function.
1092         (SYMBOL_SET_LINKAGE_NAME): Remove.
1093         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1094         with sym->set_linkage_name.
1095
1096 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1099         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1100         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1101         * NEWS: Mention new MI command.
1102
1103 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1106         '-symbol-info-types', and '-symbol-info-variables'.
1107         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1108         (mi_cmd_symbol_info_types): Declare.
1109         (mi_cmd_symbol_info_variables): Declare.
1110         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1111         (output_debug_symbol): New function.
1112         (output_nondebug_symbol): New function.
1113         (mi_symbol_info): New function.
1114         (mi_info_functions_or_variables): New function.
1115         (mi_cmd_symbol_info_functions): New function.
1116         (mi_cmd_symbol_info_types): New function.
1117         (mi_cmd_symbol_info_variables): New function.
1118         * NEWS: Mention new commands.
1119
1120 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1121
1122         * symtab.c (symbol_to_info_string): New function, most content
1123         moved from print_symbol_info, but updated to return a std::string.
1124         (print_symbol_info): Update to use symbol_to_info_string and print
1125         returned string.
1126         * symtab.h (symbol_to_info_string): Declare new function.
1127
1128 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * python/python.c (gdbpy_rbreak): Convert to using
1131         global_symbol_searcher.
1132         * symtab.c (file_matches): Convert return type to bool, change
1133         file list to std::vector, update header comment.
1134         (search_symbols): Rename to...
1135         (global_symbol_searcher::search): ...this and update now its
1136         a member function of global_symbol_searcher.  Take account of the
1137         changes to file_matches.
1138         (symtab_symbol_info): Convert to using global_symbol_searcher.
1139         (rbreak_command): Likewise.
1140         (search_module_symbols): Likewise.
1141         * symtab.h (enum symbol_search): Update comment.
1142         (search_symbols): Remove declaration.
1143         (class global_symbol_searcher): New class.
1144
1145 2019-11-26  Tom Tromey  <tromey@adacore.com>
1146
1147         * cp-support.c (_initialize_cp_support): Conditionally initialize
1148         gdb_demangle_attempt_core_dump.
1149
1150 2019-11-26  Tom Tromey  <tom@tromey.com>
1151
1152         * python/py-function.c (fnpy_init): Update.
1153         * value.h (add_internal_function): Adjust declaration.
1154         * value.c (function_destroyer): Remove.
1155         (do_add_internal_function): Don't set destroyer or copy name.
1156         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1157         Set name_allocated.
1158         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1159         (cmdpy_init): Set name_allocated.
1160         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1161         member.
1162         (~cmd_list_element): Free "name" if needed.
1163
1164 2019-11-26  Tom Tromey  <tom@tromey.com>
1165
1166         * value.h (add_internal_function): Add new overload.  Move
1167         documentation from value.h.
1168         * value.c (do_add_internal_function): New function.
1169         (add_internal_function): Use it.  Add new overload.
1170         (function_destroyer): Don't free doc.
1171         * python/py-function.c (fnpy_init): Update.
1172
1173 2019-11-26  Tom Tromey  <tom@tromey.com>
1174
1175         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1176         (cmdpy_init): Set "doc_allocated".
1177
1178 2019-11-26  Tom Tromey  <tom@tromey.com>
1179
1180         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1181         name of worker thread.
1182         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1183         pthread_setname_np.
1184         * configure, config.in: Rebuild.
1185
1186 2019-11-26  Tom Tromey  <tom@tromey.com>
1187
1188         * python/python.c (class gdbpy_gil): New.
1189         (struct gdbpy_event): Add constructor, destructor, operator().
1190         (gdbpy_post_event): Use run_on_main_thread.
1191         (gdbpy_initialize_events): Remove.
1192         (do_start_initialization): Update.
1193
1194 2019-11-26  Tom Tromey  <tom@tromey.com>
1195
1196         * NEWS: Add entry.
1197         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1198         commands.  Call update_thread_pool_size.
1199         (update_thread_pool_size, maintenance_set_worker_threads): New
1200         functions.
1201         (n_worker_threads): New global.
1202
1203 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1204             Tom Tromey  <tom@tromey.com>
1205
1206         * minsyms.c (minimal_symbol_reader::install): Use
1207         parallel_for_each.
1208         * gdbsupport/parallel-for.h: New file.
1209         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1210
1211 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1212             Tom Tromey  <tom@tromey.com>
1213
1214         * gdbsupport/thread-pool.h: New file.
1215         * gdbsupport/thread-pool.c: New file.
1216         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1217         (HFILES_NO_SRCDIR): Add thread-pool.h.
1218
1219 2019-11-26  Tom Tromey  <tom@tromey.com>
1220
1221         * event-top.h (thread_local_segv_handler): Declare.
1222         * event-top.c (thread_local_segv_handler): New global.
1223         (install_handle_sigsegv, handle_sigsegv): New functions.
1224         (async_init_signals): Install SIGSEGV handler.
1225         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1226         thread-local.
1227         (report_failed_demangle): New function.
1228         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1229         handler-setting code, instead use segv_handler.  Run warning code
1230         on main thread.
1231
1232 2019-11-26  Tom Tromey  <tom@tromey.com>
1233
1234         * run-on-main-thread.c: New file.
1235         * run-on-main-thread.h: New file.
1236         * unittests/main-thread-selftests.c: New file.
1237         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1238         main-thread-selftests.c.
1239         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1240         (COMMON_SFILES): Add run-on-main-thread.c.
1241
1242 2019-11-26  Tom Tromey  <tom@tromey.com>
1243
1244         * main.c (setup_alternate_signal_stack): Remove.
1245         (captured_main_1): Use gdb::alternate_signal_stack.
1246         * gdbsupport/alt-stack.h: New file.
1247
1248 2019-11-26  Tom Tromey  <tom@tromey.com>
1249
1250         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1251         Remove comment.
1252         (save_original_signals_state, restore_original_signals_state): Use
1253         gdb_sigmask.
1254         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1255         (_initialize_linux_nat): Use gdb_sigmask.
1256         * guile/guile.c (_initialize_guile): Use block_signals.
1257         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1258         * gdbsupport/gdb-sigmask.h: New file.
1259         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1260         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1261         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1262         pthread_sigmask.
1263         * configure, config.in: Rebuild.
1264         * gdbsupport/block-signals.h: New file.
1265
1266 2019-11-26  Tom Tromey  <tom@tromey.com>
1267
1268         * acinclude.m4: Include ax_pthread.m4.
1269         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1270         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1271         (CLIBS): Use PTHREAD_LIBS.
1272         (aclocal_m4_deps): Add ax_pthread.m4.
1273         * config.in, configure: Rebuild.
1274         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1275
1276 2019-11-26  Tom Tromey  <tom@tromey.com>
1277
1278         * symtab.h (struct minimal_symbol) <name_set>: New member.
1279         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1280         Don't call symbol_set_names.
1281         (minimal_symbol_reader::install): Call symbol_set_names.
1282
1283 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1284
1285         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1286         restore_active_ext_lang, as GIL is needed for (indirectly)
1287         called PyOS_InterruptOccurred.
1288
1289 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1290
1291         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1292         definition.
1293
1294 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1295
1296         * remote-sim.c (simulator_command): Make static, remove
1297         declaration.
1298
1299 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1300
1301         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1302         static.
1303         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1304         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1305         (main): Likewise.
1306         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1307         (main): Likewise.
1308         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1309         (main): Likewise.
1310         * unittests/basic_string_view/element_access/char/1.cc (test01):
1311         Likewise.
1312         (main): Likewise.
1313         * unittests/basic_string_view/element_access/char/empty.cc (main):
1314         Likewise.
1315         * unittests/basic_string_view/element_access/char/front_back.cc
1316         (test01): Likewise.
1317         (main): Likewise.
1318         * unittests/basic_string_view/inserters/char/2.cc (test05):
1319         Likewise.
1320         (main): Likewise.
1321         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1322         (test01): Likewise.
1323         (main): Likewise.
1324         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1325         (test01): Likewise.
1326         (main): Likewise.
1327         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1328         Likewise.
1329         * unittests/basic_string_view/operations/compare/char/1.cc
1330         (test01): Likewise.
1331         (main): Likewise.
1332         * unittests/basic_string_view/operations/compare/char/13650.cc
1333         (test01): Likewise.
1334         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1335         Likewise.
1336         (main): Likewise.
1337         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1338         Likewise.
1339         (main): Likewise.
1340         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1341         Likewise.
1342         (main): Likewise.
1343         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1344         Likewise.
1345         (main): Likewise.
1346         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1347         Likewise.
1348         (main): Likewise.
1349         * unittests/basic_string_view/operations/find/char/4.cc (main):
1350         Likewise.
1351         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1352         Likewise.
1353         (main): Likewise.
1354         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1355         Likewise.
1356         (main): Likewise.
1357         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1358         Likewise.
1359         (main): Likewise.
1360         * unittests/basic_string_view/operations/substr/char/1.cc
1361         (test01): Likewise.
1362         (main): Likewise.
1363         * unittests/basic_string_view/operators/char/2.cc (main):
1364         Likewise.
1365         * unittests/optional/assignment/1.cc (test): Likewise.
1366         * unittests/optional/assignment/2.cc (test): Likewise.
1367         * unittests/optional/assignment/3.cc (test): Likewise.
1368         * unittests/optional/assignment/4.cc (test): Likewise.
1369         * unittests/optional/assignment/5.cc (test): Likewise.
1370         * unittests/optional/assignment/6.cc (test): Likewise.
1371         * unittests/optional/assignment/7.cc (test): Likewise.
1372         * unittests/optional/cons/copy.cc (test): Likewise.
1373         * unittests/optional/cons/default.cc (test): Likewise.
1374         * unittests/optional/cons/move.cc (test): Likewise.
1375         * unittests/optional/cons/value.cc (test): Likewise.
1376         * unittests/optional/in_place.cc (test): Likewise.
1377         * unittests/optional/observers/1.cc (test): Likewise.
1378         * unittests/optional/observers/2.cc (test): Likewise.
1379
1380 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1381
1382         * tui-win.h (tui_set_var_cmd): Remove.
1383         * tui-win.c (tui_set_var_cmd): Make static.
1384
1385 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1386
1387         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1388         rbreak_command_wrapper): Remove.
1389         * symtab.c (rbreak_command_wrapper): Remove.
1390
1391 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1392
1393         * inferior.h (info_terminal_command): Remove declaration.
1394         * inflow.c (info_terminal_command): Make static.
1395
1396 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1397
1398         * inferior.c (exit_inferior_silent): Remove.
1399
1400 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1401
1402         * dictionary.c (dict_empty, mdict_empty): Remove.
1403         * dictionary.c (mdict_empty): Remove.
1404
1405 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1406
1407          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1408          (arc_insn_get_memory_offset): Likewise.
1409          (arc_insn_dump): Likewise.
1410          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1411          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1412          * dictionary.c (dict_iterator_next): Likewise.
1413          (dict_iter_match_first): Likewise.
1414          (dict_iter_match_next): Likewise.
1415          * f-lang.c (evaluate_subexp_f): Likewise.
1416          * hppa-tdep.c (hppa_read_pc): Likewise.
1417          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1418          * parse.c (write_exp_elt_msym): Likewise.
1419          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1420          * remote.c (remote_packet_size): Likewise.
1421          (remote_notif_stop_parse): Likewise.
1422          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1423          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1424          * source.c (prepare_path_for_appending): Likewise.
1425          * sparc64-linux-tdep.c
1426          (sparc64_linux_handle_segmentation_fault); Likewise.
1427          * stack.c (frame_selection_by_function_completer): Likewise.
1428
1429 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1430
1431         * completer.c (set_gdb_completion_word_break_characters):
1432         Remove.
1433
1434 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1435
1436         * dwarf-index-write.c: Include dwarf-index-write.h.
1437         * mi/mi-interp.c: Include mi/mi-interp.h.
1438
1439 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1440
1441         * aarch32-tdep.c: Include aarch32-tdep.h.
1442         * aarch32-tdep.h: Forward-declare struct target_desc.
1443
1444 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1445
1446         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1447         strerror.
1448         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1449         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1450
1451 2019-11-25  Tom de Vries  <tdevries@suse.de>
1452
1453         * contrib/words.sh: Add -c option.
1454
1455 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1456
1457         * solib.c (solib_find_1): Change int to bool.
1458         (exec_file_find): Change int to bool.
1459         (solib_find): Change int to bool.
1460         (solib_read_symbols): Change int to bool.
1461         (solib_used): Change int to bool.
1462         (solib_add): Change int to bool.
1463         (info_sharedlibrary_command): Change int to bool.
1464         (solib_contains_address_p): Change int to bool.
1465         (solib_keep_data_in_core): Change int to bool.
1466         (in_solib_dynsym_resolve_code): Change int to bool.
1467         (reload_shared_libraries_1): Change int to bool.
1468         (gdb_sysroot_changed): Change int to bool.
1469         * solib.h (solib_read_symbols): Change int to bool.
1470         (solib_contains_address_p): Change int to bool.
1471         (solib_keep_data_in_core): Change int to bool.
1472         (in_solib_dynsym_resolve_code): Change int to bool.
1473         (libpthread_name_p): Change int to bool.
1474
1475 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1476
1477         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1478         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1479         (remote_packet_max_chars): New static global.
1480         (show_remote_packet_max_chars): New function.
1481         (remote_target::putpkt_binary): Adjust to use new
1482         remote_packet_max_chars option.
1483         (remote_target::getpkt_or_notif_sane_1): Likewise.
1484         (_initialize_remote): Register new remote-packet-max-chars option.
1485
1486 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * m68k-linux-nat.c: Include gdbarch.h.
1489
1490 2019-11-24  Tom Tromey  <tom@tromey.com>
1491
1492         * symfile.c (read_symbols): Update.
1493         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1494         bool.
1495         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1496         (psym_lookup_symbol, psym_find_last_source_symtab)
1497         (psym_forget_cached_source_info, psym_print_stats)
1498         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1499         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1500         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1501         (psym_find_compunit_symtab_by_address)
1502         (maintenance_print_psymbols, maintenance_info_psymtabs)
1503         (maintenance_check_psymtabs): Update.
1504         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1505         bool.
1506
1507 2019-11-22  Tom Tromey  <tom@tromey.com>
1508
1509         * observable.h: Update comments.
1510
1511 2019-11-22  Tom Tromey  <tromey@adacore.com>
1512
1513         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1514         (print_ada_task_info): Don't try to fetch thread id if task is not
1515         alive.
1516
1517 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1518
1519         * ada-exp.y: Update.
1520         * ada-lang.c (sort_choices): Update.
1521         (ada_print_symbol_signature): Update.
1522         (resolve_subexp): Update.
1523         (ada_parse_renaming): Update.
1524         (ada_read_renaming_var_value): Update.
1525         (lesseq_defined_than): Update.
1526         (remove_extra_symbols): Update.
1527         (remove_irrelevant_renamings): Update.
1528         (ada_add_block_symbols): Update.
1529         (ada_collect_symbol_completion_matches): Update.
1530         (ada_is_renaming_symbol): Update.
1531         (aggregate_assign_from_choices): Update.
1532         (ada_evaluate_subexp): Update.
1533         (ada_has_this_exception_support): Update.
1534         (ada_is_non_standard_exception_sym): Update.
1535         (ada_add_exceptions_from_frame): Update.
1536         (ada_add_global_exceptions): Update.
1537         (ada_print_subexp): Update.
1538         * ax-gdb.c (gen_var_ref): Update.
1539         (gen_maybe_namespace_elt): Update.
1540         (gen_expr_for_cast): Update.
1541         (gen_expr): Update.
1542         * block.h: Update.
1543         * blockframe.c (find_pc_partial_function): Update.
1544         * breakpoint.c (print_breakpoint_location): Update.
1545         (update_static_tracepoint): Update.
1546         * btrace.c (ftrace_print_function_name): Update.
1547         (ftrace_function_switched): Update.
1548         * buildsym.c (find_symbol_in_list): Update.
1549         * c-exp.y: Update.
1550         * c-typeprint.c (c_print_typedef): Update.
1551         (c_type_print_template_args): Update.
1552         * cli/cli-cmds.c (edit_command): Update.
1553         (list_command): Update.
1554         (print_sal_location): Update.
1555         * coffread.c (patch_opaque_types): Update.
1556         (process_coff_symbol): Update.
1557         (coff_read_enum_type): Update.
1558         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1559         (convert_one_symbol): Update.
1560         (hash_symname): Update.
1561         (eq_symname): Update.
1562         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1563         * compile/compile-cplus-types.c (debug_print_scope): Update.
1564         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1565         * compile/compile-object-load.c (get_out_value_type): Update.
1566         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1567         (search_symbol_list): Update.
1568         (cp_lookup_symbol_imports_or_template): Update.
1569         * cp-support.c (overload_list_add_symbol): Update.
1570         * ctfread.c (psymtab_to_symtab): Update.
1571         * dbxread.c (cp_set_block_scope): Update.
1572         * dictionary.c (iter_match_first_hashed): Update.
1573         (iter_match_next_hashed): Update.
1574         (insert_symbol_hashed): Update.
1575         (iter_match_next_linear): Update.
1576         * dictionary.h: Update.
1577         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1578         (locexpr_describe_location_piece): Update.
1579         (locexpr_describe_location_1): Update.
1580         (locexpr_generate_c_location): Update.
1581         (loclist_describe_location): Update.
1582         (loclist_generate_c_location): Update.
1583         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1584         (read_func_scope): Update.
1585         (process_enumeration_scope): Update.
1586         (new_symbol): Update.
1587         (dwarf2_const_value): Update.
1588         (dwarf2_symbol_mark_computed): Update.
1589         * eval.c (evaluate_funcall): Update.
1590         (evaluate_subexp_standard): Update.
1591         * expprint.c (print_subexp_standard): Update.
1592         (dump_subexp_body_standard): Update.
1593         * f-valprint.c (info_common_command_for_block): Update.
1594         * findvar.c (get_hosting_frame): Update.
1595         (default_read_var_value): Update.
1596         * go-lang.c (go_symbol_package_name): Update.
1597         * guile/scm-block.c (bkscm_print_block_smob): Update.
1598         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1599         (gdbscm_symbol_name): Update.
1600         (gdbscm_symbol_linkage_name): Update.
1601         (gdbscm_symbol_print_name): Update.
1602         * infcall.c (get_function_name): Update.
1603         * infcmd.c (jump_command): Update.
1604         (finish_command): Update.
1605         * infrun.c (insert_exception_resume_breakpoint): Update.
1606         * linespec.c (canonicalize_linespec): Update.
1607         (create_sals_line_offset): Update.
1608         (convert_linespec_to_sals): Update.
1609         (complete_label): Update.
1610         (find_label_symbols_in_block): Update.
1611         * m2-typeprint.c (m2_print_typedef): Update.
1612         * mdebugread.c (mdebug_reg_to_regnum): Update.
1613         (parse_symbol): Update.
1614         (mylookup_symbol): Update.
1615         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1616         (list_args_or_locals): Update.
1617         * objc-lang.c (compare_selectors): Update.
1618         (info_selectors_command): Update.
1619         (compare_classes): Update.
1620         (info_classes_command): Update.
1621         (find_imps): Update.
1622         * p-typeprint.c (pascal_print_typedef): Update.
1623         * printcmd.c (build_address_symbolic): Update.
1624         (info_address_command): Update.
1625         (print_variable_and_value): Update.
1626         * python/py-framefilter.c (extract_sym): Update.
1627         (py_print_single_arg): Update.
1628         * python/py-symbol.c (sympy_str): Update.
1629         (sympy_get_name): Update.
1630         (sympy_get_linkage_name): Update.
1631         * python/python.c (gdbpy_rbreak): Update.
1632         * record-btrace.c (btrace_get_bfun_name): Update.
1633         (btrace_call_history): Update.
1634         * rust-lang.c (rust_print_typedef): Update.
1635         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1636         * stabsread.c (stab_reg_to_regnum): Update.
1637         (define_symbol): Update.
1638         (read_enum_type): Update.
1639         (common_block_end): Update.
1640         (cleanup_undefined_types_1): Update.
1641         (scan_file_globals): Update.
1642         * stack.c (print_frame_arg): Update.
1643         (print_frame_args): Update.
1644         (find_frame_funname): Update.
1645         (info_frame_command_core): Update.
1646         (iterate_over_block_locals): Update.
1647         (print_block_frame_labels): Update.
1648         (do_print_variable_and_value): Update.
1649         (iterate_over_block_arg_vars): Update.
1650         (return_command): Update.
1651         * symmisc.c (dump_symtab_1): Update.
1652         (print_symbol): Update.
1653         * symtab.c (eq_symbol_entry): Update.
1654         (symbol_cache_dump): Update.
1655         (lookup_language_this): Update.
1656         (find_pc_sect_line): Update.
1657         (skip_prologue_sal): Update.
1658         (symbol_search::compare_search_syms): Update.
1659         (treg_matches_sym_type_name): Update.
1660         (search_symbols): Update.
1661         (print_symbol_info): Update.
1662         (rbreak_command): Update.
1663         (completion_list_add_symbol): Update.
1664         (find_gnu_ifunc): Update.
1665         (get_symbol_address): Update.
1666         (search_module_symbols): Update.
1667         (info_module_subcommand): Update.
1668         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1669         (SYMBOL_LINKAGE_NAME): Remove.
1670         (SYMBOL_DEMANGLED_NAME): Remove.
1671         (SYMBOL_PRINT_NAME): Remove.
1672         (SYMBOL_SEARCH_NAME): Remove.
1673         * tracepoint.c (set_traceframe_context): Update.
1674         (validate_actionline): Update.
1675         (collection_list::collect_symbol): Update.
1676         (encode_actions_1): Update.
1677         (info_scope_command): Update.
1678         (print_one_static_tracepoint_marker): Update.
1679         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1680         * valops.c (address_of_variable): Update.
1681         (find_overload_match): Update.
1682         (find_oload_champ): Update.
1683
1684 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1685
1686         * ada-lang.c (ada_lookup_simple_minsym): Update.
1687         (ada_collect_symbol_completion_matches): Update.
1688         * ada-tasks.c (read_atcb): Update.
1689         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1690         (amd64_windows_skip_trampoline_code): Update.
1691         * arm-tdep.c (skip_prologue_function): Update.
1692         (arm_skip_stack_protector): Update.
1693         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1694         (arm_wince_skip_main_prologue): Update.
1695         * ax-gdb.c (gen_expr): Update.
1696         * block.c (call_site_for_pc): Update.
1697         * blockframe.c (find_pc_partial_function): Update.
1698         * breakpoint.c (set_breakpoint_location_function): Update.
1699         * btrace.c (ftrace_print_function_name): Update.
1700         (ftrace_function_switched): Update.
1701         * c-valprint.c (print_unpacked_pointer): Update.
1702         * coffread.c (coff_symfile_read): Update.
1703         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1704         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1705         * dwarf-index-write.c (write_psymbols): Update.
1706         * dwarf2loc.c (call_site_to_target_addr): Update.
1707         (func_verify_no_selftailcall): Update.
1708         (tailcall_dump): Update.
1709         (call_site_find_chain_1): Update.
1710         (dwarf_expr_reg_to_entry_parameter): Update.
1711         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1712         * eval.c (evaluate_funcall): Update.
1713         (evaluate_subexp_standard): Update.
1714         (evaluate_subexp_for_sizeof): Update.
1715         * expprint.c (print_subexp_standard): Update.
1716         (dump_subexp_body_standard): Update.
1717         * frame.c (get_prev_frame_always_1): Update.
1718         * frv-tdep.c (frv_skip_main_prologue): Update.
1719         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1720         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1721         (gnuv3_get_typename_from_type_info): Update.
1722         (gnuv3_skip_trampoline): Update.
1723         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1724         * i386-tdep.c (i386_skip_main_prologue): Update.
1725         (i386_pe_skip_trampoline_code): Update.
1726         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1727         * infcall.c (get_function_name): Update.
1728         * linespec.c (minsym_found): Update.
1729         * linux-fork.c (info_checkpoints_command): Update.
1730         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1731         (m32c_m16c_pointer_to_address): Update.
1732         * maint.c (maintenance_translate_address): Update.
1733         * minsyms.c (add_minsym_to_hash_table): Update.
1734         (add_minsym_to_demangled_hash_table): Update.
1735         (lookup_minimal_symbol_mangled): Update.
1736         (lookup_minimal_symbol_demangled): Update.
1737         (lookup_minimal_symbol_linkage): Update.
1738         (lookup_minimal_symbol_text): Update.
1739         (lookup_minimal_symbol_by_pc_name): Update.
1740         (minimal_symbol_is_less_than): Update.
1741         (compact_minimal_symbols): Update.
1742         (build_minimal_symbol_hash_tables): Update.
1743         (find_solib_trampoline_target): Update.
1744         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1745         (mips_skip_pic_trampoline_code): Update.
1746         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1747         * objc-lang.c (info_selectors_command): Update.
1748         (info_classes_command): Update.
1749         (find_methods): Update.
1750         (find_imps): Update.
1751         * p-valprint.c (pascal_val_print): Update.
1752         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1753         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1754         * printcmd.c (build_address_symbolic): Update.
1755         (info_symbol_command): Update.
1756         * psymtab.c (psymbol_name_matches): Update.
1757         (match_partial_symbol): Update.
1758         (lookup_partial_symbol): Update.
1759         (print_partial_symbols): Update.
1760         (sort_pst_symbols): Update.
1761         (maintenance_check_psymtabs): Update.
1762         * python/py-framefilter.c (py_print_frame): Update.
1763         * python/python.c (gdbpy_rbreak): Update.
1764         * record-btrace.c (btrace_get_bfun_name): Update.
1765         (btrace_call_history): Update.
1766         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1767         (rs6000_skip_trampoline_code): Update.
1768         * sol-thread.c (info_cb): Update.
1769         * stabsread.c (scan_file_globals): Update.
1770         * stack.c (find_frame_funname): Update.
1771         (info_frame_command_core): Update.
1772         * symmisc.c (dump_msymbols): Update.
1773         * symtab.c (symbol_natural_name): Rename to..,
1774         (general_symbol_info::natural_name): ...this.
1775         (symbol_demangled_name): Rename to...
1776         (general_symbol_info::demangled_name): ...this.
1777         (symbol_search_name): Rename to...
1778         (general_symbol_info::search_name): ...this.
1779         (symbol_matches_search_name): Update.
1780         (find_pc_sect_line): Update.
1781         (skip_prologue_sal): Update.
1782         (search_symbols): Update.
1783         (print_msymbol_info): Update.
1784         (rbreak_command): Update.
1785         (completion_list_add_msymbol): Update.
1786         (completion_list_objc_symbol): Update.
1787         (get_msymbol_address): Update.
1788         * symtab.h (struct general_symbol_info): Add member functions
1789         natural_name (), linkage_name (), print_name (), demangled_name (),
1790         and search_name ().
1791         (SYMBOL_NATURAL_NAME): Update.
1792         (symbol_natural_name): Move to a member function on general_symbol_info.
1793         (SYMBOL_DEMANGLED_NAME): Update.
1794         (symbol_demangled_name): Move to a member function on
1795         general_symbol_info.
1796         (SYMBOL_SEARCH_NAME): Update.
1797         (symbol_search_name): Move to a member function on general_symbol_info.
1798         (MSYMBOL_NATURAL_NAME): Remove.
1799         (MSYMBOL_LINKAGE_NAME): Remove.
1800         (MSYMBOL_PRINT_NAME): Remove.
1801         (MSYMBOL_DEMANGLED_NAME): Remove.
1802         (MSYMBOL_SEARCH_NAME): Remove.
1803         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1804
1805 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1806
1807         * symtab.c (create_demangled_names_hash): Use per_bfd->
1808         minimal_symbol_count for computing the initial size, if greater
1809         than our default size.
1810
1811 2019-11-22  Tom de Vries  <tdevries@suse.de>
1812
1813         * contrib/words.sh: Improve words extraction.
1814
1815 2019-11-22  Tom de Vries  <tdevries@suse.de>
1816
1817         * contrib/words.sh: Combine sed invocations.
1818
1819 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1820
1821         * Makefile.in: Update.
1822         * demangle.c: Rename to...
1823         * gdb-demangle.c: ..this.
1824         (is_cplus_marker): Change return type to bool.
1825         (_initialize_demangler): Rename to...
1826         (_initialize_gdb_demangle): ...this.
1827         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1828         * symtab.h (demangle): Remove declaration; instead include
1829         gdb-demangle.h.
1830
1831 2019-11-21  Tom Tromey  <tromey@adacore.com>
1832
1833         * gdbsupport/format.c (format_pieces): Parse %I64d.
1834         * unittests/format_pieces-selftests.c (test_windows_formats): New
1835         function.
1836         (run_tests): Call it.
1837
1838 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1839
1840         Byte reverse display of variables with DW_END_big, DW_END_little
1841         (DW_AT_endianity) dwarf attributes if different than the native
1842         byte order.
1843         * ada-lang.c (ada_value_binop):
1844         Use type_byte_order instead of gdbarch_byte_order.
1845         * ada-valprint.c (printstr):
1846         (ada_val_print_string):
1847         * ada-lang.c (value_pointer):
1848         (ada_value_binop):
1849         Use type_byte_order instead of gdbarch_byte_order.
1850         * c-lang.c (c_get_string):
1851         Use type_byte_order instead of gdbarch_byte_order.
1852         * c-valprint.c (c_val_print_array):
1853         Use type_byte_order instead of gdbarch_byte_order.
1854         * cp-valprint.c (cp_print_class_member):
1855         Use type_byte_order instead of gdbarch_byte_order.
1856         * dwarf2loc.c (rw_pieced_value):
1857         Use type_byte_order instead of gdbarch_byte_order.
1858         * dwarf2read.c (read_base_type): Handle DW_END_big,
1859         DW_END_little
1860         * f-lang.c (f_get_encoding):
1861         Use type_byte_order instead of gdbarch_byte_order.
1862         * findvar.c (default_read_var_value):
1863         Use type_byte_order instead of gdbarch_byte_order.
1864         * gdbtypes.c (check_types_equal):
1865         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1866         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1867         and TYPE_ENDIANITY_LITTLE if set.
1868         (type_byte_order): new function.
1869         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1870         (struct main_type) <flag_endianity_not_default>:
1871         New field.
1872         (type_byte_order): New function.
1873         * infcmd.c (default_print_one_register_info):
1874         Use type_byte_order instead of gdbarch_byte_order.
1875         * p-lang.c (pascal_printstr):
1876         Use type_byte_order instead of gdbarch_byte_order.
1877         * p-valprint.c (pascal_val_print):
1878         Use type_byte_order instead of gdbarch_byte_order.
1879         * printcmd.c (print_scalar_formatted):
1880         Use type_byte_order instead of gdbarch_byte_order.
1881         * solib-darwin.c (darwin_current_sos):
1882         Use type_byte_order instead of gdbarch_byte_order.
1883         * solib-svr4.c (solib_svr4_r_ldsomap):
1884         Use type_byte_order instead of gdbarch_byte_order.
1885         * stap-probe.c (stap_modify_semaphore):
1886         Use type_byte_order instead of gdbarch_byte_order.
1887         * target-float.c (target_float_same_format_p):
1888         Use type_byte_order instead of gdbarch_byte_order.
1889         * valarith.c (scalar_binop):
1890         (value_bit_index):
1891         Use type_byte_order instead of gdbarch_byte_order.
1892         * valops.c (value_cast):
1893         Use type_byte_order instead of gdbarch_byte_order.
1894         * valprint.c (generic_emit_char):
1895         (generic_printstr):
1896         (val_print_string):
1897         Use type_byte_order instead of gdbarch_byte_order.
1898         * value.c (unpack_long):
1899         (unpack_bits_as_long):
1900         (unpack_value_bitfield):
1901         (modify_field):
1902         (pack_long):
1903         (pack_unsigned_long):
1904         Use type_byte_order instead of gdbarch_byte_order.
1905         * findvar.c (unsigned_pointer_to_address):
1906         (signed_pointer_to_address):
1907         (unsigned_address_to_pointer):
1908         (address_to_signed_pointer):
1909         (default_read_var_value):
1910         (default_value_from_register):
1911         Use type_byte_order instead of gdbarch_byte_order.
1912         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1913         Use type_byte_order instead of gdbarch_byte_order.
1914         * riscv-tdep.c (riscv_print_one_register_info):
1915         Use type_byte_order instead of gdbarch_byte_order.
1916
1917 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1918
1919         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1920         (current_ui_gdb_stdin_ptr): Likewise.
1921         (current_ui_gdb_stderr_ptr): Likewise.
1922         (current_ui_gdb_stdlog_ptr): Likewise.
1923         (current_ui_current_uiout_ptr): Likewise.
1924         (gen_ret_current_ui_field_ptr): Remove.
1925
1926 2019-11-21  Tom de Vries  <tdevries@suse.de>
1927
1928         PR gdb/24956
1929         * cli/cli-script.c (execute_control_command): Only switch to
1930         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1931
1932 2019-11-19  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1935         Now static.  Change type of "name".
1936         (tui_set_win_height_command): Don't copy "arg".
1937         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1938         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1939
1940 2019-11-19  Ali Tamur <tamur@google.com>
1941
1942         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1943         "if (attr != nullptr)".
1944         (dwarf2_find_base_address): Likewise.
1945         (dwarf2_build_include_psymtabs): Likewise.
1946         (read_cutu_die_from_dwo): Likewise.
1947         (read_func_scope): Likewise.
1948         (read_call_site_scope): Likewise.
1949         (dwarf2_get_pc_bounds): Likewise.
1950         (dwarf2_record_block_ranges): Likewise.
1951         (dwarf2_add_field): Likewise.
1952         (dwarf2_add_member_fn): Likewise.
1953         (read_structure_type): Likewise.
1954         (read_enumeration_type): Likewise.
1955         (read_array_type): Likewise.
1956         (read_array_order): Likewise.
1957         (read_set_type): Likewise.
1958         (read_common_block): Likewise.
1959         (read_tag_reference_type): Likewise.
1960         (read_tag_string_type): Likewise.
1961         (read_subroutine_type): Likewise.
1962         (read_base_type): Likewise.
1963         (read_subrange_type): Likewise.
1964         (new_symbol): Likewise.
1965         (prepare_one_comp_unit): Likewise.
1966
1967 2019-11-19  Tom Tromey  <tromey@adacore.com>
1968
1969         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1970         result in error when DebugActiveProcess fails.
1971
1972 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1973             Pedro Alves  <palves@redhat.com>
1974
1975         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1976         * target.c (target_stack::push): Call 'unpush' if there's a
1977         target on top of the stack.
1978
1979 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1980
1981         * python/py-block.c (blpy_dealloc): Call tp_free.
1982         (blpy_block_syms_dealloc): Likewise.
1983         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1984         * python/py-inferior.c (infpy_dealloc): Likewise.
1985         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1986         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1987         * python/py-symbol.c (sympy_dealloc): Likewise.
1988         * python/py-symtab.c (stpy_dealloc): Likewise.
1989         * python/py-type.c (typy_iterator_dealloc): Likewise.
1990
1991 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1992
1993         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1994         constructor instead of using a class initializer.
1995
1996 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1997
1998         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1999         * configure: Regenerate.
2000         * configure.ac: Don't source common.host.
2001         * gdbsupport/common.host: Remove.
2002         * gdbsupport/mingw-strerror.c: Remove.
2003         * gdbsupport/posix-strerror.c: Rename to...
2004         * gdbsupport/safe-strerror.c: ...this.
2005
2006 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2007
2008         * maint.c (scoped_command_stats::print_time): Use localtime_r
2009         instead of localtime (provided through gnulib if necessary).
2010         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2011         of ctime.
2012
2013 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2014
2015         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2016         avoid compile errors.
2017
2018 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2019
2020         * config.in: Regenerate.
2021         * configure: Regenerate.
2022         * gdbsupport/common.m4: No longer check for strerror_r.
2023         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2024         POSIX version of strerror_r, now that gnulib provides it if
2025         necessary.
2026
2027 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2028
2029         * README (`configure' options): Update.
2030
2031 2019-11-14  Tom Tromey  <tromey@adacore.com>
2032
2033         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2034         expected type for the RHS if the LHS is a convenience variable.
2035
2036 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2037
2038         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2039         Provide explicit default and copy constructor.
2040
2041 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2042
2043         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2044         only call Py_INCREF (newbp) in the bppy_pending_object case.
2045
2046 2019-11-13  Tom Tromey  <tromey@adacore.com>
2047
2048         PR build/25182:
2049         * psympriv.h (partial_symbol): Remove static assert.
2050         * symtab.h (general_symbol_info, symbol): Remove static assert.
2051
2052 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2053
2054         * gdbsupport/format.c (format_pieces::format_pieces): Support
2055         printf 'z' size modifier.
2056         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2057         * printcmd.c (ui_printf):  Handle size_t_arg.
2058         * ui-out.c (ui_out::vmessage): Likewise.
2059         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2060         function.
2061         (run_tests): Call test_format_int_sizes.
2062
2063 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2064
2065         * ada-exp.y (write_ambiguous_var): Update.
2066         * buildsym.c (add_symbol_to_list): Update.
2067         * dwarf2read.c (read_variable): Update.
2068         (new_symbol): Update.
2069         * jit.c (finalize_symtab): Update.
2070         * language.c (language_alloc_type_symbol): Update.
2071         * symtab.c (fixup_symbol_section): Update.
2072         (initialize_objfile_symbol_1): Move code to...
2073         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2074         (allocate_symbol): Update.
2075         (allocate_template_symbol): Update.
2076         (get_symbol_address): Update.
2077         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2078         of having as a field, and add a constructor.
2079         (SYMBOL_VALUE): Update.
2080         (SYMBOL_VALUE_ADDRESS): Update.
2081         (SET_SYMBOL_VALUE_ADDRESS): Update.
2082         (SYMBOL_VALUE_BYTES): Update.
2083         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2084         (SYMBOL_BLOCK_VALUE): Update.
2085         (SYMBOL_VALUE_CHAIN): Update.
2086         (SYMBOL_LANGUAGE): Update.
2087         (SYMBOL_SECTION): Update.
2088         (SYMBOL_OBJ_SECTION): Update.
2089         (SYMBOL_SET_LANGUAGE): Update.
2090         (SYMBOL_SET_LINKAGE_NAME): Update.
2091         (SYMBOL_SET_NAMES): Update.
2092         (SYMBOL_NATURAL_NAME): Update.
2093         (SYMBOL_LINKAGE_NAME): Update.
2094         (SYMBOL_DEMANGLED_NAME): Update.
2095         (SYMBOL_SEARCH_NAME): Update.
2096         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2097         (struct symbol): Update.
2098         (struct template_symbol): Update.
2099         (struct rust_vtable_symbol): Update.
2100         * xcoffread.c (SYMBOL_DUP): Update.
2101
2102 2019-11-12  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-layout.c (show_layout): Set current_layout.
2105         (show_source_disasm_command, show_data)
2106         (show_source_or_disasm_and_command): Don't set current_layout.
2107
2108 2019-11-12  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2111
2112 2019-11-12  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-win.c (resize_message): New global.
2115         (show_tui_resize_message): New function.
2116         (tui_async_resize_screen): Print message if requested.
2117         (_initialize_tui_win): Add tui-resize-message setting.
2118         * NEWS: Add entry for new commands.
2119
2120 2019-11-11  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2123         functions.
2124
2125 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2126
2127         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2128
2129 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2130
2131         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2132         function.
2133         * python/python-internal.h (gdbpy_lookup_static_symbols):
2134         Declare new function.
2135         * python/python.c (python_GdbMethods): Add
2136         gdb.lookup_static_symbols method.
2137         * NEWS: Mention gdb.lookup_static_symbols.
2138
2139 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2142         static block of current object file first.  Also fix typo in
2143         header comment.
2144
2145 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2146
2147         * stack.c (set_last_displayed_sal): Delete.
2148         (last_displayed_sal_valid): Delete.
2149         (last_displayed_pspace): Delete.
2150         (last_displayed_addr): Delete.
2151         (last_displayed_symtab): Delete.
2152         (last_displayed_line): Delete.
2153         (class last_displayed_symtab_info_type): New.
2154         (last_displayed_symtab_info): New static global variable.
2155         (print_frame_info): Call methods on last_displayed_symtab_info.
2156         (clear_last_displayed_sal): Update header comment, and make use of
2157         last_displayed_symtab_info.
2158         (last_displayed_sal_is_valid): Likewise.
2159         (get_last_displayed_pspace): Likewise.
2160         (get_last_displayed_addr): Likewise.
2161         (get_last_displayed_symtab): Likewise.
2162         (get_last_displayed_line): Likewise.
2163         (get_last_displayed_sal): Likewise.
2164         * stack.h (clear_last_displayed_sal): Update header comment.
2165         (last_displayed_sal_is_valid): Likewise.
2166         (get_last_displayed_pspace): Likewise.
2167         (get_last_displayed_addr): Likewise.
2168         (get_last_displayed_symtab): Likewise.
2169         (get_last_displayed_line): Likewise.
2170         (get_last_displayed_sal): Likewise.
2171
2172 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * stack.c (frame_show_address): Convert return type to bool.
2175         * stack.h (frame_show_address): Likewise, and update header
2176         comment.
2177
2178 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2181         * unittests/vec-utils-selftests.c: New file.
2182         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2183
2184 2019-11-10  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2187         (tui_highlight_win): Likewise.
2188         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2189         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2190         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2191         Don't set can_highlight.
2192
2193 2019-11-10  Tom Tromey  <tom@tromey.com>
2194
2195         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2196         Remove unused declaration.
2197
2198 2019-11-08  Tom Tromey  <tromey@adacore.com>
2199
2200         * top.c (read_command_file): Update.
2201         (command_line_input): Make return type const.
2202         * python/py-gdb-readline.c: Update.
2203         * linespec.c (decode_line_2): Update.
2204         * defs.h (command_line_input): Make return type const.
2205         * cli/cli-script.c (read_next_line): Make return type const.
2206         * ada-lang.c (get_selections): Update.
2207
2208 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2209
2210         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2211         * mi/mi-main.c (output_cores): Likewise.
2212         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2213         (linux_xfer_osdata_modules): Likewise.
2214         * remote.c (register_remote_support_xml): Likewise.
2215         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2216         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2217
2218 2019-11-06  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-interp.c: Don't include readline.h.
2221         * tui/tui-hooks.c: Don't include readline.h.
2222         * symmisc.c: Include tilde.h, not readline.h.
2223         * symfile.c: Include tilde.h, not readline.h.
2224         * source.c: Include tilde.h, not readline.h.
2225         * solib.c: Include tilde.h, not readline.h.
2226         * psymtab.c: Include tilde.h, not readline.h.
2227         * exec.c: Include tilde.h, not readline.h.
2228         * corelow.c: Include tilde.h, not readline.h.
2229         * cli/cli-dump.c: Include tilde.h, not readline.h.
2230         * cli/cli-cmds.c: Don't include readline.h.
2231
2232 2019-11-05  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2235         (tui_disassemble): Set addr_size.
2236         (tui_disasm_window::set_contents): Use addr_size.
2237
2238 2019-11-05  Tom Tromey  <tom@tromey.com>
2239
2240         * rust-lang.c (rust_language_defn): Update.
2241         * python/py-value.c (valpy_string): Call c_get_string.
2242         * p-lang.c (pascal_language_defn): Update.
2243         * opencl-lang.c (opencl_language_defn): Update.
2244         * objc-lang.c (objc_language_defn): Update.
2245         * m2-lang.c (m2_language_defn): Update.
2246         * language.c (unknown_language_defn, auto_language_defn): Update.
2247         (default_get_string): Remove.
2248         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2249         * go-lang.c (go_language_defn): Update.
2250         * f-lang.c (f_language_defn): Update.
2251         * d-lang.c (d_language_defn): Update.
2252         * c-lang.c (c_language_defn, cplus_language_defn)
2253         (asm_language_defn, minimal_language_defn): Update.
2254         * ada-lang.c (ada_language_defn): Update.
2255         * language.h (struct language_defn) <la_get_string>: Remove.
2256         (LA_GET_STRING): Remove.
2257         (default_get_string): Don't declare.
2258
2259 2019-11-05  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-source.h (struct tui_source_window): Inline
2262         constructor.  Remove destructor.
2263         <style_changed, m_observable>: Move to superclass.
2264         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2265         (struct tui_source_window_base): Move private members to end.
2266         <style_changed, m_observable>: Move from tui_source_window.
2267         * tui/tui-winsource.c (tui_copy_source_line): Move from
2268         tui-source.c.  Rename from copy_source_line.  Add special handling
2269         for negative line number.
2270         (tui_source_window_base::style_changed): Move from
2271         tui_source_window.
2272         (tui_source_window_base): Register observer.
2273         (~tui_source_window_base): New.
2274         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2275         rename.
2276         (tui_source_window::set_contents): Use tui_copy_source_line.
2277         (tui_source_window::tui_source_window): Move to tui-source.h.
2278         (tui_source_window::~tui_source_window): Remove.
2279         (tui_source_window::style_changed): Move to superclass.
2280         * tui/tui-disasm.c (tui_disassemble): Create string file with
2281         styling, when possible.  Add "addr_size" parameter.
2282         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2283         Don't compute maximum size.
2284         (len_without_escapes): New function
2285
2286 2019-11-05  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2289         std::string.
2290         * tui/tui-winsource.c (tui_show_source_line): Update.
2291         * tui/tui-source.c (tui_source_window::set_contents): Update.
2292         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2293
2294 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2295
2296         * symtab.h (gdb_static_assert): Put && operator at the beginning
2297         of the line instead of the end.
2298
2299 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2300
2301         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2302         and sizeof (symbol).
2303         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2304
2305 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2306
2307         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2308         * configure.host: Mark *-*-solaris2.10* obsolete.
2309         * configure.tgt: Mark Solaris < 11 obsolete.
2310         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2311         Update target triplet.
2312
2313 2019-11-01  Tom Tromey  <tromey@adacore.com>
2314
2315         * utils.c (print_sys_errmsg): Simplify.
2316
2317 2019-11-01  Tom Tromey  <tromey@adacore.com>
2318
2319         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2320
2321 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2322
2323         * configure: Regenerate.
2324         * configure.ac: Remove check for strerror_r.
2325         * gdbsupport/common.m4: Check for strerror_r.
2326
2327 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2328
2329         PR gdb/25124
2330
2331         * arm-tdep.c (arm_per_objfile): Rename to ...
2332         (arm_per_bfd): ... this.
2333         (arm_objfile_data_key): Rename to ...
2334         (arm_bfd_data_key): ... this.
2335         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2336         data.
2337         (arm_record_special_symbol): Likewise.
2338
2339 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2342         end.
2343         * c-typeprint.c (c_print_typedef): Likewise.
2344         * f-typeprint.c (f_print_typedef): Likewise.
2345         * m2-typeprint.c (m2_print_typedef): Likewise.
2346         * p-typeprint.c (pascal_print_typedef): Likewise.
2347         * rust-lang.c (rust_print_typedef): Likewise.
2348         * symtab.c (print_symbol_info): Print a newline after calling
2349         typedef_print.
2350
2351 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * symtab.c (info_module_cmdlist): New variable.
2354         (info_module_command): New function.
2355         (search_module_symbols): New function.
2356         (info_module_subcommand): New function.
2357         (struct info_modules_var_func_options): New struct.
2358         (info_modules_var_func_options_defs): New variable.
2359         (make_info_modules_var_func_options_def_group): New function.
2360         (info_module_functions_command): New function.
2361         (info_module_variables_command): New function.
2362         (info_module_var_func_command_completer): New function.
2363         (_initialize_symtab): Register new 'info module functions' and
2364         'info module variables' commands.
2365         * symtab.h (typedef symbol_search_in_module): New typedef.
2366         (search_module_symbols): Declare new function.
2367         * NEWS: Mention new commands.
2368
2369 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2372         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2373         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2374         MODULES_DOMAIN.
2375         (scan_partial_symbols): Only create partial module symbols for non
2376         declarations.
2377         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2378         and MODULES_DOMAIN.
2379         * symtab.c (search_domain_name): Likewise.
2380         (search_symbols): Likewise.
2381         (print_symbol_info): Likewise.
2382         (symtab_symbol_info): Likewise.
2383         (info_modules_command): New function.
2384         (_initialize_symtab): Register 'info modules' command.
2385         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2386         * NEWS: Mention new 'info modules' command.
2387
2388 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2389
2390         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2391         and $_gdb_maint_setting_str.
2392
2393 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2394
2395         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2396         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2397         (str_value_from_setting, gdb_setting_str_internal_fn)
2398         (gdb_maint_setting_str_internal_fn): New functions.
2399         (_initialize_cli_cmds): Define the new convenience functions.
2400         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2401         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2402
2403 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2404
2405         * agent.c (set_can_use_agent): When the setting is turned on,
2406         look up agent symbols if we don't have them yet.
2407         (agent_new_objfile): Don't look up agent symbols when the agent
2408         setting is off.
2409
2410 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2411
2412         * config.in: Regenerate.
2413
2414 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2415
2416         * configure: Regenerate.
2417         * configure.ac: Check for strerror_r.
2418         * gdbsupport/common-utils.h (safe_strerror): Change return value
2419         to const char * and document that this function is now threadsafe.
2420         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2421         thread_local and call strerror_r, if available.
2422         * utils.c (perror_string): Update.
2423         (print_sys_errmsg): Update.
2424
2425 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2426
2427         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2428         objfile_key.
2429         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2430         objfile to fetch per-bfd data.
2431         (arm_find_exidx_entry): Likewise.
2432
2433 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2434
2435         * gdbsupport/agent.c (debug_agent): Change type to bool.
2436         (use_agent): Likewise.
2437         (all_agent_symbols_look_up): Likewise.
2438         (agent_loaded_p): Change return value to bool.
2439         (agent_look_up_symbols): Update.
2440         (agent_capability_check): Change return value to bool.
2441         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2442         (debug_agent): Change type to bool.
2443         (use_agent): Likewise.
2444         (agent_capability_check): Change return value to bool.
2445
2446 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2447
2448         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2449         (build_minimal_symbol_hash_tables): Code to clear the table moved
2450         to clear_minimal_symbol_hash_tables.
2451         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2452         when needed.
2453
2454 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2455
2456         * infcmd.c: Remove includes.
2457         * infrun.c: Remove includes.
2458
2459 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2460
2461         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2462         (grow_vect): Remove declaration.
2463         (ada_type_of_array): Remove declaration.
2464         (ada_update_initial_language): Remove declaration.
2465         (ada_fold_name): Remove declaration.
2466         (ada_fill_in_ada_prototype): Remove declaration.
2467         (user_select_syms): Remove declaration.
2468         (get_selections): Remove declaration.
2469         (ada_tag_type): Remove declaration.
2470         (ada_value_tag): Remove declaration.
2471         (ada_is_others_clause): Remove declaration.
2472         (ada_in_variant): Remove declaration.
2473         (ada_value_struct_elt): Remove declaration.
2474         (ada_attribute_name): Remove declaration.
2475         (ada_system_address_type): Remove declaration.
2476         * ada-lang.c (ada_watch_location_expression): Make static.
2477         (GROW_VECT): Move here from ada-lang.h.
2478         (grow_vect): Make static.
2479         (ada_update_initial_language): Make static.
2480         (ada_fold_name): Make static.
2481         (ada_type_of_array): Make static.
2482         (encoded_ordered_before): Move up.
2483         (sort_choices): Move up.
2484         (print_signatures): Move up.
2485         (ada_print_symbol_signature): Move up.
2486         (get_selections): Move up and make static.
2487         (user_select_syms): Move up and make static.
2488         (ada_value_struct_elt): Move up and make static.
2489         (ada_tag_type): Make static.
2490         (ada_value_tag): Make static.
2491         (ada_is_others_clause): Make static.
2492         (ada_in_variant): Make static.
2493         (ada_attribute_name): Make static.
2494
2495 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2496
2497         * ada-lang.c: Remove includes.
2498         * ada-typeprint.c: Remove includes.
2499         * ada-valprint.c: Remove includes.
2500
2501 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2502
2503         * addrmap.c: Add static assertions of type size, moved from
2504         _initialize_addrmap.
2505         (_initialize_addrmap): Remove.
2506
2507 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2508
2509         * coffread.c (record_minimal_symbol): Update.
2510         (process_coff_symbol): Update.
2511         * dbxread.c (read_dbx_symtab): Update.
2512         * dwarf2read.c (add_partial_symbol): Update.
2513         (fixup_go_packaging): Update.
2514         (load_partial_dies): Update.
2515         (new_symbol): Update.
2516         * elfread.c (record_minimal_symbol): Change signature to use
2517         gdb::string_view instead of name+len.
2518         (elf_symtab_read): Update.
2519         (elf_rel_plt_read): Update.
2520         * mdebugread.c (parse_partial_symbols): Update.
2521         (handle_psymbol_enumerators): Update.
2522         (new_symbol): Update.
2523         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2524         to use gdb::string_view instead of name+len.
2525         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2526         * psympriv.h (add_psymbol_to_list): Likewise.
2527         * psymtab.c (add_psymbol_to_bcache): Likewise.
2528         (add_psymbol_to_list): Likewise.
2529         * stabsread.c (define_symbol): Update.
2530         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2531         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2532         (symbol_set_names): Likewise.
2533         * xcoffread.c (scan_xcoff_symtab): Update.
2534
2535 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2536
2537         * symtab.h (symbol_set_names): Document that copy_name must be
2538         set to true for non-nullterminated strings.
2539         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2540         linkage_name if the entry was not found and we need to demangle.
2541
2542 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2543
2544         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2545         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2546         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2547         * gdbsupport/gdb_binary_search.h: New file.
2548
2549 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2550
2551         * NEWS: Mention new --with-system-gdbinit-dir option.
2552         * config.in: Regenerate.
2553         * configure: Regenerate.
2554         * configure.ac: Add new option --with-system-gdbinit-dir.
2555         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2556         for a ".gdb" suffix.
2557         * main.c (get_init_files): Change system_gdbinit argument to
2558         a vector and return the files in SYSTEM_GDBINIT_DIR in
2559         addition to SYSTEM_GDBINIT.
2560         (captured_main_1): Update.
2561         (print_gdb_help): Update.
2562         * top.c (print_gdb_configuration): Also print the value of
2563         SYSTEM_GDBINIT_DIR.
2564
2565 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2566
2567         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2568         that takes gdb::string_view arguments.
2569
2570 2019-10-26  Tom de Vries  <tdevries@suse.de>
2571
2572         * aarch64-linux-tdep.c: Fix typos in comments.
2573         * aarch64-tdep.c: Same.
2574         * ada-lang.c: Same.
2575         * amd64-nat.c: Same.
2576         * arc-tdep.c: Same.
2577         * arch/aarch64-insn.c: Same.
2578         * block.c: Same.
2579         * breakpoint.h: Same.
2580         * btrace.h: Same.
2581         * c-varobj.c: Same.
2582         * cli/cli-decode.c: Same.
2583         * cli/cli-script.c: Same.
2584         * cli/cli-utils.h: Same.
2585         * coff-pe-read.c: Same.
2586         * coffread.c: Same.
2587         * compile/compile-cplus-symbols.c: Same.
2588         * compile/compile-object-run.c: Same.
2589         * completer.c: Same.
2590         * corelow.c: Same.
2591         * cp-support.c: Same.
2592         * demangle.c: Same.
2593         * dwarf-index-write.c: Same.
2594         * dwarf2-frame.c: Same.
2595         * dwarf2-frame.h: Same.
2596         * eval.c: Same.
2597         * frame-base.h: Same.
2598         * frame.h: Same.
2599         * gdbcmd.h: Same.
2600         * gdbtypes.h: Same.
2601         * gnu-nat.c: Same.
2602         * guile/scm-objfile.c: Same.
2603         * i386-tdep.c: Same.
2604         * i386-tdep.h: Same.
2605         * infcall.c: Same.
2606         * infcall.h: Same.
2607         * linux-nat.c: Same.
2608         * m68k-tdep.c: Same.
2609         * macroexp.c: Same.
2610         * memattr.c: Same.
2611         * mi/mi-cmd-disas.c: Same.
2612         * mi/mi-getopt.h: Same.
2613         * mi/mi-main.c: Same.
2614         * minsyms.c: Same.
2615         * nat/aarch64-sve-linux-sigcontext.h: Same.
2616         * objfiles.h: Same.
2617         * ppc-linux-nat.c: Same.
2618         * ppc-linux-tdep.c: Same.
2619         * ppc-tdep.h: Same.
2620         * progspace.h: Same.
2621         * prologue-value.h: Same.
2622         * python/py-evtregistry.c: Same.
2623         * python/py-instruction.h: Same.
2624         * record-btrace.c: Same.
2625         * record-full.c: Same.
2626         * remote.c: Same.
2627         * rs6000-tdep.c: Same.
2628         * ser-tcp.c: Same.
2629         * sol-thread.c: Same.
2630         * sparc-sol2-tdep.c: Same.
2631         * sparc64-tdep.c: Same.
2632         * stabsread.c: Same.
2633         * symfile.c: Same.
2634         * symtab.h: Same.
2635         * target.c: Same.
2636         * tracepoint.c: Same.
2637         * tui/tui-data.h: Same.
2638         * tui/tui-io.c: Same.
2639         * tui/tui-win.c: Same.
2640         * tui/tui.c: Same.
2641         * unittests/rsp-low-selftests.c: Same.
2642         * user-regs.h: Same.
2643         * utils.c: Same.
2644         * utils.h: Same.
2645         * valarith.c: Same.
2646         * valops.c: Same.
2647         * valprint.c: Same.
2648         * valprint.h: Same.
2649         * value.c: Same.
2650         * value.h: Same.
2651         * varobj.c: Same.
2652         * x86-nat.h: Same.
2653         * xtensa-tdep.c: Same.
2654
2655 2019-10-25  Ali Tamur <tamur@google.com>
2656
2657         * charset.c (find_charset_names): Reflect API change.
2658
2659 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2660
2661         * symtab.c (struct demangled_name_entry): Change demangled name
2662         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2663         part of the struct anymore.
2664         (symbol_set_names): No longer obstack allocate + copy the demangled
2665         name, just store the allocated name from bfd.
2666
2667 2019-10-25  Tom Tromey  <tromey@adacore.com>
2668
2669         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2670         (bsearch_cie_cmp, add_cie): Remove.
2671         (find_cie): Reimplement.
2672         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2673         (dwarf2_build_frame_info): Update.
2674
2675 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2676
2677         PR gdb/25126
2678         * symfile.c (reread_symbols): Call forget_cached_source_info to
2679         clear the stale source cache.
2680
2681 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2682
2683         * configure: Regenerate.
2684         * configure.ac: Remove code that sets python_has_threads.
2685
2686 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2687
2688         * config.in: Regenerate.
2689         * configure: Regenerate.
2690         * configure.ac: Remove the code that uses sed to get the python
2691         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2692
2693 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2696         error paths.
2697
2698 2019-10-23  Tom Tromey  <tom@tromey.com>
2699
2700         * arc-tdep.c: Remove ".." from include.
2701         * frv-tdep.c: Remove ".." from include.
2702         * lm32-tdep.c: Remove ".." from include.
2703         * microblaze-tdep.c: Remove ".." from include.
2704         * or1k-tdep.h: Remove ".." from include.
2705         * s12z-tdep.c: Remove ".." from include.
2706         * Makefile.in (OPCODES_CFLAGS): Add comment.
2707         (TOP_CFLAGS): New variable.
2708         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2709
2710 2019-10-23  Tom Tromey  <tom@tromey.com>
2711
2712         * Makefile.in (READLINE_DIR): Update.
2713
2714 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2715
2716         * infcall.c (call_function_by_hand_dummy): Fix the function
2717         comment.  And extract out a code section into...
2718         (reserve_stack_space): ...this new function.
2719
2720 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2721
2722         * infcall.c (value_arg_coerce): Remove an unused parameter.
2723         (call_function_by_hand_dummy): Update the call to
2724         'value_arg_coerce'.
2725
2726 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2727
2728         * infcall.c (call_function_by_hand_dummy): Refactor.
2729
2730 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2731
2732         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2733
2734 2019-10-23  Tom Tromey  <tom@tromey.com>
2735
2736         * configure: Rebuild.
2737         * configure.ac: Don't check for sigprocmask.
2738         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2739
2740 2019-10-23  Tom Tromey  <tom@tromey.com>
2741
2742         * configure: Rebuild.
2743         * acinclude.m4: Use m4_include, not sinclude.
2744
2745 2019-10-23  Tom de Vries  <tdevries@suse.de>
2746
2747         PR breakpoints/24687
2748         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2749
2750 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2751
2752         * symtab.c (struct demangled_name_entry) <language>: Change from
2753         bitfield to regular variable.
2754
2755 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2756
2757         * symtab.c (struct demangled_name_entry): Add a constructor.
2758         (free_demangled_name_entry): New function to call the destructor
2759         for demangled_name_entry.
2760         (create_demangled_names_hash): Pass free_demangled_name_entry to
2761         htab_create_alloc.
2762         (symbol_set_names): Call placement new for demangled_name_entry.
2763         * utils.c: No longer include xxhash.h here, now that fast_hash
2764         is inlined in the header.
2765         * utils.h: Instead, include it here.
2766
2767 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2768
2769         * Makefile.in: Link with libxxhash.
2770         * config.in: Regenerate.
2771         * configure: Regenerate.
2772         * configure.ac: Search for libxxhash.
2773         * utils.c (fast_hash): Use xxhash if present.
2774
2775 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2776
2777         * utils.h (fast_hash): New function.
2778         * symtab.c (hash_demangled_name_entry): Call new function
2779         fast_hash.
2780
2781 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2782
2783         * symtab.c (struct demangled_name_entry): Change type of mangled
2784         to gdb::string_view. Also adds a constructor that takes the
2785         mangled name.
2786         (hash_demangled_name_entry): Update.
2787         (eq_demangled_name_entry): Update.
2788         (free_demangled_name_entry): New function to call the destructor
2789         now that this is not a POD anymore.
2790         (create_demangled_names_hash): Pass free_demangled_name_entry to
2791         htab_create_alloc.
2792         (symbol_set_names): Update.
2793
2794 2019-10-21  Ali Tamur  <tamu@google.com>
2795
2796         * dwarf2read.c (dir_index): Change type.
2797         (file_name_index): Likewise.
2798         (line_header::include_dir_at): Change comment and implementation on
2799         whether it is DWARF 5.
2800         (line_header::is_valid_file_index): New function.
2801         (line_header::file_name_at): Change comment and implementation on
2802         whether it is DWARF 5.
2803         (line_header::file_names): Change to private field renamed as
2804         m_file_names and introduce a new accessor method.
2805         (line_header::file_names_size): New method.
2806         (line_header::include_dirs): Change to private field and rename as
2807         m_include_dirs.
2808         (dw2_get_file_names_reader): Define local var at a smaller scope and
2809         reflect API change.
2810         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2811         (process_structure_scope): Likewise.
2812         (line_header::add_include_dir): Change message and reflect renaming.
2813         (line_header::add_file_name): Likewise.
2814         (read_formatted_entries): Handle DW_FORM_data16.
2815         (dwarf_decode_line_header): Fix line header length calculation.
2816         (psymtab_include_file_name): Change comment and API.
2817         (lnp_state_machine::m_file): Update comment and reflect type change.
2818         (lnp_state_machine::record_line): Reflect type change.
2819         (dwarf_decode_lines): Reflect API change.
2820         (file_file_name): Likewise.
2821         (file_full_name): Likewise.
2822
2823 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2826
2827 2019-10-21  Tom Tromey  <tom@tromey.com>
2828
2829         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2830
2831 2019-10-21  Tom Tromey  <tom@tromey.com>
2832
2833         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2834         NM_H.   Use AC_CONFIG_LINKS.
2835         * configure: Rebuild.
2836         * Makefile.in (NM_H): New variable.
2837         (generated_files): Add NM_H.  Remove gcore.
2838         (nm.h, stamp-nmh): New targets.
2839
2840 2019-10-20  Tom Tromey  <tom@tromey.com>
2841
2842         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2843         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2844         obsolete comment.
2845         (put_objfile_before): Now static.
2846
2847 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2848
2849         * gdbsupport/common-utils.h (startswith): Change return type to
2850         bool.
2851
2852 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2853
2854         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2855         * breakpoint.c (bp_locations_compare): Rename to...
2856         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2857         (update_global_location_list): Use std::sort instead of qsort.
2858         * buildsym.c (compare_line_numbers): Rename to...
2859         (lte_is_less_than): ...this, and change to std::sort semantics.
2860         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2861         instead of qsort.
2862         * disasm.c (compare_lines): Rename to...
2863         (line_is_less_than): ...this, and change to std::sort semantics.
2864         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2865         of qsort.
2866         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2867         (fde_is_less_than): ...this, and change to std::sort semantics.
2868         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2869         * mdebugread.c (compare_blocks):
2870         (block_is_less_than): ...this, and change to std::sort semantics.
2871         (sort_blocks): Call std::sort instead of qsort.
2872         * objfiles.c (qsort_cmp): Rename to...
2873         (sort_cmp): ...this, and change to std::sort semantics.
2874         (update_section_map): Call std::sort instead of qsort.
2875         * remote.c (compare_pnums): Remove.
2876         (map_regcache_remote_table): Call std::sort instead of qsort.
2877         * utils.c (compare_positive_ints): Remove.
2878         * utils.h (compare_positive_ints): Remove.
2879         * xcoffread.c (compare_lte): Remove.
2880         (arrange_linetable): Call std::sort instead of qsort.
2881
2882 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2883
2884         * symfile.c (init_entry_point_info): Fix typo.
2885         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2886
2887 2019-10-18  Tom de Vries  <tdevries@suse.de>
2888
2889         * aarch64-tdep.c: Fix typos in comments.
2890         * ada-lang.c: Same.
2891         * ada-tasks.c: Same.
2892         * alpha-tdep.c: Same.
2893         * alpha-tdep.h: Same.
2894         * amd64-nat.c: Same.
2895         * amd64-windows-tdep.c: Same.
2896         * arc-tdep.c: Same.
2897         * arc-tdep.h: Same.
2898         * arch-utils.c: Same.
2899         * arm-nbsd-tdep.c: Same.
2900         * arm-tdep.c: Same.
2901         * ax-gdb.c: Same.
2902         * blockframe.c: Same.
2903         * btrace.c: Same.
2904         * c-varobj.c: Same.
2905         * coff-pe-read.c: Same.
2906         * coffread.c: Same.
2907         * cris-tdep.c: Same.
2908         * darwin-nat.c: Same.
2909         * dbxread.c: Same.
2910         * dcache.c: Same.
2911         * disasm.c: Same.
2912         * dtrace-probe.c: Same.
2913         * dwarf-index-write.c: Same.
2914         * dwarf2-frame-tailcall.c: Same.
2915         * dwarf2-frame.c: Same.
2916         * dwarf2read.c: Same.
2917         * eval.c: Same.
2918         * exceptions.c: Same.
2919         * fbsd-tdep.c: Same.
2920         * findvar.c: Same.
2921         * frame.c: Same.
2922         * frv-tdep.c: Same.
2923         * gnu-v3-abi.c: Same.
2924         * go32-nat.c: Same.
2925         * h8300-tdep.c: Same.
2926         * hppa-tdep.c: Same.
2927         * i386-linux-tdep.c: Same.
2928         * i386-tdep.c: Same.
2929         * ia64-libunwind-tdep.c: Same.
2930         * ia64-tdep.c: Same.
2931         * infcmd.c: Same.
2932         * infrun.c: Same.
2933         * linespec.c: Same.
2934         * linux-nat.c: Same.
2935         * linux-thread-db.c: Same.
2936         * machoread.c: Same.
2937         * mdebugread.c: Same.
2938         * mep-tdep.c: Same.
2939         * mn10300-tdep.c: Same.
2940         * namespace.c: Same.
2941         * objfiles.c: Same.
2942         * opencl-lang.c: Same.
2943         * or1k-tdep.c: Same.
2944         * osabi.c: Same.
2945         * ppc-linux-nat.c: Same.
2946         * ppc-linux-tdep.c: Same.
2947         * ppc-sysv-tdep.c: Same.
2948         * printcmd.c: Same.
2949         * procfs.c: Same.
2950         * record-btrace.c: Same.
2951         * record-full.c: Same.
2952         * remote-fileio.c: Same.
2953         * remote.c: Same.
2954         * rs6000-tdep.c: Same.
2955         * s12z-tdep.c: Same.
2956         * score-tdep.c: Same.
2957         * ser-base.c: Same.
2958         * ser-go32.c: Same.
2959         * skip.c: Same.
2960         * sol-thread.c: Same.
2961         * solib-svr4.c: Same.
2962         * solib.c: Same.
2963         * source.c: Same.
2964         * sparc-nat.c: Same.
2965         * sparc-sol2-tdep.c: Same.
2966         * sparc-tdep.c: Same.
2967         * sparc64-tdep.c: Same.
2968         * stabsread.c: Same.
2969         * stack.c: Same.
2970         * symfile.c: Same.
2971         * symtab.c: Same.
2972         * target-descriptions.c: Same.
2973         * target-float.c: Same.
2974         * thread.c: Same.
2975         * utils.c: Same.
2976         * valops.c: Same.
2977         * valprint.c: Same.
2978         * value.c: Same.
2979         * varobj.c: Same.
2980         * windows-nat.c: Same.
2981         * xcoffread.c: Same.
2982         * xstormy16-tdep.c: Same.
2983         * xtensa-tdep.c: Same.
2984
2985 2019-10-17  Tom Tromey  <tromey@adacore.com>
2986
2987         * configure: Rebuild.
2988         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2989         in AC_CONFIG_FILES invocation.
2990         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2991         new-style config.status invocation.
2992
2993 2019-10-17  Tom de Vries  <tdevries@suse.de>
2994
2995         * arm-nbsd-nat.c: Fix typos in comments.
2996         * arm-tdep.c: Same.
2997         * darwin-nat-info.c: Same.
2998         * dwarf2read.c: Same.
2999         * elfread.c: Same.
3000         * event-top.c: Same.
3001         * findvar.c: Same.
3002         * gdbtypes.c: Same.
3003         * hppa-tdep.c: Same.
3004         * i386-tdep.c: Same.
3005         * jit.c: Same.
3006         * main.c: Same.
3007         * mdebugread.c: Same.
3008         * moxie-tdep.c: Same.
3009         * nto-procfs.c: Same.
3010         * osabi.c: Same.
3011         * ppc-linux-tdep.c: Same.
3012         * remote.c: Same.
3013         * riscv-tdep.c: Same.
3014         * s390-tdep.c: Same.
3015         * sh-tdep.c: Same.
3016         * sparc-linux-tdep.c: Same.
3017         * sparc-nat.c: Same.
3018         * stack.c: Same.
3019         * target-descriptions.c: Same.
3020         * top.c: Same.
3021         * varobj.c: Same.
3022
3023 2019-10-16  Tom Tromey  <tom@tromey.com>
3024
3025         * objfiles.h (struct objfile) <original_name>: Now const.
3026
3027 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3028
3029         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3030         pass on to sigsetjmp's second argument.
3031         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3032
3033 2019-10-16  Keith Seitz  <keiths@redhat.com>
3034
3035         PR gdb/23567
3036         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3037         sections whose size is greater than the file size.
3038
3039 2019-10-16  Jim Wilson  <jimw@sifive.com>
3040
3041         * riscv-tdep.c (riscv_gcc_target_options): New.
3042         (riscv_gnu_triplet_regexp): New.
3043         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3044         set_gdbarch_gnu_triplet_regexp.
3045
3046 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3047
3048         * Makefile.in: Add xml-builtin.h.
3049         * features/feature_to_c.sh: Add an include for xml-builtin.h
3050         to ensure that the compiler checks that the types match.
3051         * xml-builtin.h: New file.
3052         * xml-support.c (fetch_xml_builtin): Add missing const.
3053         * xml-support.h: Remove declaration of xml_builtins.
3054
3055 2019-10-16  Tom de Vries  <tdevries@suse.de>
3056
3057         PR tdep/25096
3058         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3059         (amd64_classify_aggregate): ... here.
3060         (amd64_classify_aggregate_field): Handled fiels of nested structs
3061         recursively.
3062
3063 2019-10-16  Tom de Vries  <tdevries@suse.de>
3064
3065         PR tdep/24104
3066         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3067         that handles 'theclass'.
3068
3069 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * linespec.c (decode_digits_ordinary): Update comment.
3072         * make-target-delegates: No longer need to handle VEC case.
3073         * memrange.c (normalize_mem_ranges): Update comment.
3074         * namespace.c (add_using_directive): Update comment.
3075         * objc-lang.c (uniquify_strings): Update comment.
3076         * ppc-linux-nat.c (struct thread_points): Update comment.
3077         * probe.h (find_probes_in_objfile): Update comment.
3078         * target.h (enum flash_preserve_mode): Update comment.
3079         * varobj.c (varobj_restrict_range): Update comment.
3080         * varobj.h (varobj_list_children): Update comment.
3081
3082 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3083
3084         * Makefile.in: Remove references to vec.h and vec.c.
3085         * aarch64-tdep.c: No longer include vec.h.
3086         * ada-lang.c: Likewise.
3087         * ada-lang.h: Likewise.
3088         * arm-tdep.c: Likewise.
3089         * ax.h: Likewise.
3090         * breakpoint.h: Likewise.
3091         * charset.c: Likewise.
3092         * cp-support.h: Likewise.
3093         * dtrace-probe.c: Likewise.
3094         * dwarf2read.c: Likewise.
3095         * extension.h: Likewise.
3096         * gdb_bfd.c: Likewise.
3097         * gdbsupport/gdb_vecs.h: Likewise.
3098         * gdbsupport/vec.c: Remove.
3099         * gdbsupport/vec.h: Remove.
3100         * gdbthread.h: Likewise.
3101         * guile/scm-type.c: Likewise.
3102         * inline-frame.c: Likewise.
3103         * machoread.c: Likewise.
3104         * memattr.c: Likewise.
3105         * memrange.h: Likewise.
3106         * namespace.h: Likewise.
3107         * nat/linux-btrace.h: Likewise.
3108         * osdata.c: Likewise.
3109         * parser-defs.h: Likewise.
3110         * progspace.h: Likewise.
3111         * python/py-type.c: Likewise.
3112         * record-btrace.c: Likewise.
3113         * rust-exp.y: Likewise.
3114         * solib-target.c: Likewise.
3115         * stap-probe.c: Likewise.
3116         * target-descriptions.c: Likewise.
3117         * target-memory.c: Likewise.
3118         * target.h: Likewise.
3119         * varobj.c: Likewise.
3120         * varobj.h: Likewise.
3121         * xml-support.h: Likewise.
3122
3123 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3126         Update for new std::vector based implementation.
3127         (process_psymtab_comp_unit_reader): Likewise.
3128         (scan_partial_symbols): Likewise.
3129         (recursively_compute_inclusions): Likewise.
3130         (compute_compunit_symtab_includes): Likewise.
3131         (process_imported_unit_die): Likewise.
3132         (queue_and_load_dwo_tu): Likewise.
3133         (follow_die_sig_1): Likewise.
3134         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3135         (typedef dwarf2_per_cu_ptr): Remove.
3136         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3137         function.
3138         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3139         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3140         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3141         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3142         std::vector.
3143
3144 2019-10-15  Tom Tromey  <tromey@adacore.com>
3145
3146         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3147         TID.
3148
3149 2019-10-15  Tom Tromey  <tromey@adacore.com>
3150
3151         * windows-nat.c (windows_nat_target::fetch_registers)
3152         (windows_nat_target::store_registers): Rename "pid" to "tid".
3153
3154 2019-10-15  Tom Tromey  <tromey@adacore.com>
3155
3156         * gdbarch.h, gdbarch.c: Rebuild.
3157         * gdbarch.sh (gcc_target_options): Change return type to
3158         std::string.
3159         * compile/compile.c (get_args): Update.
3160         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3161         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3162         std::string.
3163         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3164         std::string.
3165         * arch-utils.c (default_gcc_target_options): Return std::string.
3166         * arch-utils.h (default_gcc_target_options): Return std::string.
3167         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3168
3169 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3170
3171         * breakpoint.c (breakpoint_chain): Make static.
3172         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3173         of accessing breakpoint_chain.
3174
3175 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3176
3177         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3178         to a gdb::function_view and return value to bool.
3179         * breakpoint.h (iterate_over_breakpoints): Likewise.
3180         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3181         (pop_dummy_frame): Update.
3182         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3183         (gdbscm_breakpoints): Update.
3184         * python/py-breakpoint.c (build_bp_list): Update.
3185         (gdbpy_breakpoints): Update.
3186         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3187         Update.
3188         (bpfinishpy_handle_stop): Update.
3189         (bpfinishpy_handle_exit): Update.
3190         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3191         (svr4_update_solib_event_breakpoints): Update.
3192
3193 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3194
3195         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3196         when unwrapping single-field structs.
3197
3198 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3199
3200         * dwarf2read.c: Remove includes.
3201
3202 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3203
3204         * ui-out.c (ui_out::call_do_message): Silence
3205         -Wformat-nonliteral warning.
3206
3207 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3208
3209         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3210         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3211         include: readline/tilde.h.
3212
3213 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3214
3215         * remote.c (remote_target::get_trace_status): Remove declaration of
3216         trace_regblock_size.
3217
3218 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3219
3220         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3221         (show_user): Remove declaration of cmdlist.
3222         * cli/cli-cmds.h (max_user_call_depth): Declare.
3223         * cli/cli-script.c (execute_user_command): Remove declaration
3224         of max_user_call_depth.
3225
3226 2019-10-11  Jim Wilson  <jimw@sifive.com>
3227
3228         * gdbsupport/print-utils.h (pulongest): Fix comment.
3229         (plongest): Likewise.
3230         (phex): Add missing comment, mention leading zeros.
3231         (phex_nz): Add mention of no leading zeros to comment.
3232
3233         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3234         plongest instead of unsigned long long cast.
3235
3236 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3237
3238         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3239         for external_editor_command and gdbtk_test.
3240
3241 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3242
3243         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3244         * varobj.c (varobjdebug): Move comment to...
3245         * varobj.h (varobjdebug): ...here, and declare.
3246
3247 2019-10-09  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3250         erase_data_content.
3251
3252 2019-10-09  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3255         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3256         * tui/tui-command.c (tui_cmd_window::resize)
3257         (tui_refresh_cmd_win): Update.
3258         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3259         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3260         * tui/tui-data.c (~tui_gen_win_info): Remove.
3261         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3262         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3263         (tui_redisplay_readline, tui_mld_flush)
3264         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3265         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3266         (tui_data_window::erase_data_content)
3267         (tui_data_item_window::rerender)
3268         (tui_data_item_window::refresh_window): Update.
3269         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3270         (box_win, tui_gen_win_info::make_window)
3271         (tui_gen_win_info::make_visible): Update.
3272         (tui_delete_win): Remove.
3273         * tui/tui-winsource.c
3274         (tui_source_window_base::do_erase_source_content): Update.
3275         (tui_show_source_line, tui_source_window_base::update_tab_width)
3276         (tui_source_window_base::update_exec_info): Update.
3277         * tui/tui-data.h (struct curses_deleter): New.
3278         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3279         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3280
3281 2019-10-09  Tom Tromey  <tom@tromey.com>
3282
3283         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3284
3285 2019-10-09  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3288         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3289
3290 2019-10-09  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3293         window height directly.
3294         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3295         declare.
3296         * tui/tui-layout.c (tui_default_win_height): Remove.
3297         (tui_default_win_viewport_height): Remove.
3298
3299 2019-10-09  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui.h: Remove comments.
3302
3303 2019-10-09  Tom de Vries  <tdevries@suse.de>
3304
3305         * python/lib/gdb/printer/bound_registers.py: Use
3306         '^builtin_type_bound128' as regexp argument for
3307         add_builtin_pretty_printer.
3308
3309 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3310
3311         * guile/guile.c (guile_extension_script_ops): Remove forward
3312         declaration and mark as static.
3313         (guile_script_ops): Likewise.
3314         (extension_language_guile): Move further down in the file so
3315         it can reference the definitions for guile_{extension_,}script_ops.
3316
3317 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3318
3319         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3320         except SORTL, DFLTCC, and KDSA.
3321
3322 2019-10-08  Tom Tromey  <tromey@adacore.com>
3323
3324         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3325         (struct safe_symbol_file_add_args): Remove.
3326
3327 2019-10-08  Tom Tromey  <tromey@adacore.com>
3328
3329         * windows-nat.c: Don't include buildsym-legacy.h.
3330
3331 2019-10-08  Tom Tromey  <tromey@adacore.com>
3332
3333         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3334
3335 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3336
3337         * gdbtypes.c (overload_debug): Move comment to header.
3338         * gdbtypes.h (overload_debug): Declare.
3339         * valops.c: Remove declaration of overload_debug, instead
3340         include gdbtypes.h.
3341
3342 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3343
3344         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3345         through _().
3346         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3347         move comment...
3348         * language.h (lang_frame_mismatch_warn): ... here. Also add
3349         declaration.
3350         * top.c (lang_frame_mismatch_warn): Remove declaration.
3351         (check_frame_language_change): Pass lang_frame_mismatch_warn
3352         through _().
3353
3354 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3355
3356         * c-lang.h (vtbl_ptr_name): Declare.
3357         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3358         it from the header.
3359         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3360
3361 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3362
3363         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3364         gdb_static_assert.
3365
3366 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3367
3368         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3369         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3370         * ctfread.c: New file.
3371         * ctfread.h: New file.
3372         * elfread.c: Include ctfread.h.
3373         (struct elfinfo text_p): New member ctfsect.
3374         (elf_locate_sections): Mark CTF section.
3375         (elf_symfile_read): Call elfctf_build_psymtabs.
3376         * Makefile.in (LIBCTF): Add.
3377         (CLIBS): Use it.
3378         (CDEPS): Likewise.
3379         (DIST): Add ctfread.c.
3380
3381 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * ctfread.c (struct nextfield): Renamed to ...
3384         (struct ctf_nextfield): ... this.
3385         (struct field_info): Renamed to ...
3386         (strut ctf_field_info): ... this.
3387         (attach_fields_to_type): Update for renamed structures.
3388         (ctf_add_member_cb): Likewise.
3389         (ctf_add_enum_member_cb): Likewise.
3390         (process_struct_members): Likewise.
3391         (process_enum_type): Likewise.
3392
3393 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3394
3395         * tracectf.h: Rename, was ctf.h.
3396         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3397         * tracefile.c: Likewise.
3398         * tracepoint.c: Remove unused include ctf.h.
3399         * mi/mi-main.c: Likewise.
3400         * Makefile.in Replace ctf.c with tracectf.c.
3401
3402 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3403
3404         * version.in: Change version number to "9.0.50.DATE-git".
3405
3406 2019-10-03  Tom Tromey  <tom@tromey.com>
3407
3408         PR rust/24976:
3409         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3410
3411 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3414         cp_search_name_hash.
3415         * NEWS: Add entry about nested function support.
3416
3417 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3418             Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3421         for nested static variables when searchin VAR_DOMAIN.
3422         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3423         global scope, update comment.
3424         (add_partial_subprogram): Call add_partial_subprogram recursively
3425         for nested subroutines when processinng Fortran.
3426         (load_partial_dies): Process the child entities of a subprogram
3427         when processing Fortran.
3428         (partial_die_parent_scope): Handle building scope
3429         for Fortran nested functions.
3430         (process_die): Record that nested functions have a scope.
3431         (new_symbol): Always record Fortran subprograms on the global
3432         symbol list.
3433         (determine_prefix): How to build the prefix for Fortran
3434         subprograms.
3435
3436 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3437
3438         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3439         have just sent the thread a SIGSTOP and are waiting for it to
3440         arrive.
3441
3442 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * btrace.c (btrace_add_pc): Remove whitespace before the template
3445         parameter in 'std::vector <...>'.
3446         (parse_xml_btrace_block): Likewise.
3447         (btrace_maint_decode_pt): Likewise.
3448         (btrace_maint_update_packets): Likewise.
3449         (btrace_maint_print_packets): Likewise.
3450         * btrace.h (struct btrace_maint_info): Likewise.
3451         * dwarf2read.c (struct type_unit_group): Likewise.
3452         (build_type_psymtabs_reader): Likewise.
3453         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3454         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3455         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3456
3457 2019-10-03  Tom de Vries  <tdevries@suse.de>
3458
3459         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3460         the first line of the help text for set/show style metadata.
3461
3462 2019-10-02  Tom Tromey  <tromey@adacore.com>
3463
3464         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3465         * gdbsupport/common-inferior.c: New file.
3466         * infcmd.c (startup_with_shell): Don't define.
3467         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3468         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3469         * inferior.h (startup_with_shell): Don't declare.
3470
3471 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3472
3473         * gdbsupport/gdb_assert.h: Include errors.h.
3474         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3475
3476 2019-10-02  Tom Tromey  <tromey@adacore.com>
3477
3478         * NEWS: Add $_ada_exception entry.
3479         * ada-lang.c (struct ada_catchpoint): Add constructor.
3480         <m_kind>: New member.
3481         (allocate_location_exception, re_set_exception): Remove
3482         "ex" parameter.
3483         (should_stop_exception): Compute $_ada_exception.
3484         (check_status_exception, print_it_exception)
3485         (print_one_exception, print_mention_exception): Remove
3486         "ex" parameter.
3487         (allocate_location_catch_exception, re_set_catch_exception)
3488         (check_status_exception, print_it_catch_exception)
3489         (print_one_catch_exception, print_mention_catch_exception)
3490         (print_recreate_catch_exception)
3491         (allocate_location_catch_exception_unhandled)
3492         (re_set_catch_exception_unhandled)
3493         (check_status_exception, print_it_catch_exception_unhandled)
3494         (print_one_catch_exception_unhandled)
3495         (print_mention_catch_exception_unhandled)
3496         (print_recreate_catch_exception_unhandled)
3497         (allocate_location_catch_assert, re_set_catch_assert)
3498         (check_status_assert, print_it_catch_assert)
3499         (print_one_catch_assert, print_mention_catch_assert)
3500         (print_recreate_catch_assert)
3501         (allocate_location_catch_handlers, re_set_catch_handlers)
3502         (check_status_handlers, print_it_catch_handlers)
3503         (print_one_catch_handlers, print_mention_catch_handlers)
3504         (print_recreate_catch_handlers): Remove.
3505         (create_ada_exception_catchpoint): Update.
3506         (initialize_ada_catchpoint_ops): Update.
3507
3508 2019-10-02  Tom Tromey  <tromey@adacore.com>
3509
3510         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3511         (create_excep_cond_exprs): Simplify exception string computation.
3512         (ada_exception_catchpoint_cond_string): Likewise.
3513
3514 2019-10-02  Tom Tromey  <tromey@adacore.com>
3515
3516         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3517         * ada-lang.c (lesseq_defined_than): Handle
3518         LOC_STATIC.
3519         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3520         parameter.
3521         (dwarf2_has_info): Likewise.
3522         (new_symbol): Set maybe_copied on symbol when
3523         appropriate.
3524         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3525         parameter.
3526         <can_copy>: New member.
3527         * elfread.c (record_minimal_symbol): Set maybe_copied
3528         on symbol when appropriate.
3529         (elf_symfile_read): Update call to dwarf2_has_info.
3530         * minsyms.c (lookup_minimal_symbol_linkage): New
3531         function.
3532         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3533         * symtab.c (get_symbol_address, get_msymbol_address):
3534         New functions.
3535         * symtab.h (get_symbol_address, get_msymbol_address):
3536         Declare.
3537         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3538         maybe_copied.
3539         (struct symbol, struct minimal_symbol) <maybe_copied>:
3540         New member.
3541
3542 2019-10-02  Tom Tromey  <tromey@adacore.com>
3543
3544         * source.c (struct current_source_location): New.
3545         (current_source_key): New global.
3546         (current_source_symtab, current_source_line)
3547         (current_source_pspace): Remove.
3548         (get_source_location): New function.
3549         (get_current_source_symtab_and_line)
3550         (set_default_source_symtab_and_line)
3551         (set_current_source_symtab_and_line)
3552         (clear_current_source_symtab_and_line, select_source_symtab)
3553         (info_source_command, print_source_lines_base)
3554         (info_line_command, search_command_helper, _initialize_source):
3555         Update.
3556
3557 2019-10-02  Tom Tromey  <tromey@adacore.com>
3558
3559         * source.c (select_source_symtab): Don't call
3560         decode_line_with_current_source.
3561
3562 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3563
3564         * symtab.c (lookup_global_symbol): Search global block.
3565
3566 2019-10-02  Tom Tromey  <tromey@adacore.com>
3567
3568         * coffread.c (process_coff_symbol): Update.
3569         * dwarf2read.c (var_decode_location, new_symbol): Update.
3570         * mdebugread.c (parse_symbol): Update.
3571         * objfiles.c (relocate_one_symbol): Update.
3572         * stabsread.c (define_symbol, fix_common_block)
3573         (scan_file_globals): Update.
3574         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3575         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3576         * xcoffread.c (process_xcoff_symbol): Update.
3577
3578 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3579
3580         * MAINTAINERS: Update my email address.
3581
3582 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3585         std::vector.
3586         (build_type_psymtabs_reader): Update for std::vector.
3587         (build_type_psymtab_dependencies): Likewise.
3588         * dwarf2read.h: Remove use of DEF_VEC_P.
3589         (typedef sig_type_ptr): Delete.
3590
3591 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3592
3593         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3594         to std::vector.
3595         (btrace_maint_decode_pt): Likewise, and move allocation of the
3596         vector outside of the loop.
3597         (btrace_maint_update_packets): Update to handle change from VEC to
3598         std::vector.
3599         (btrace_maint_print_packets): Likewise.
3600         (maint_info_btrace_cmd): Likewise.
3601         * btrace.h: Remove use of DEF_VEC_O.
3602         (typedef btrace_pt_packet_s): Delete.
3603         (struct btrace_maint_info) <packets>: Change fromm VEC to
3604         std::vector.
3605         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3606
3607 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3608
3609         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3610         make accesses into the vector constant references.
3611         (btrace_add_pc): Update for std::vector.
3612         (btrace_stitch_bts): Likewise.
3613         (parse_xml_btrace_block): Likewise.
3614         (btrace_maint_update_packets): Likewise.
3615         (btrace_maint_print_packets): Likewise.
3616         (maint_info_btrace_cmd): Likewise.
3617         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3618         std::vector.
3619         (btrace_data::empty): Likewise.
3620         (btrace_data_append): Likewise.
3621         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3622         (typedef btrace_block_s): Delete.
3623         (struct btrace_block): Add constructor.
3624         (struct btrace_data_bts) <blocks>: Change to std::vector.
3625         * nat/linux-btrace.c (perf_event_read_bts): Update for
3626         std::vector.
3627         (linux_read_bts): Likewise.
3628
3629 2019-10-01  Tom Tromey  <tom@tromey.com>
3630
3631         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3632
3633 2019-10-01  Tom Tromey  <tom@tromey.com>
3634
3635         * stack.c (print_frame, info_frame_command_core): Use
3636         styled_string.
3637         * linux-thread-db.c (try_thread_db_load_1)
3638         (try_thread_db_load_from_pdir_1): Use styled_string.
3639         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3640         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3641         (maybe_print_unsupported_script_warning)
3642         (maybe_print_script_not_found_warning): Use styled_string.
3643         * ada-lang.c (user_select_syms): Use styled_string.
3644
3645 2019-10-01  Tom Tromey  <tom@tromey.com>
3646
3647         * p-lang.c (pascal_printstr): Use metadata style.
3648         * value.c (show_convenience): Use metadata style.
3649         * valprint.c (valprint_check_validity, val_print_optimized_out)
3650         (val_print_not_saved, val_print_unavailable)
3651         (val_print_invalid_address, generic_val_print, val_print)
3652         (value_check_printable, val_print_array_elements): Use metadata
3653         style.
3654         * ui-out.h (class ui_out) <field_fmt>: New overload.
3655         <do_field_fmt>: Add style parameter.
3656         * ui-out.c (ui_out::field_fmt): New overload.
3657         * typeprint.c (type_print_unknown_return_type)
3658         (val_print_not_allocated, val_print_not_associated): Use metadata
3659         style.
3660         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3661         parameter.
3662         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3663         * tracepoint.c (tvariables_info_1): Use metadata style.
3664         * stack.c (print_frame_arg, print_frame_info, print_frame)
3665         (info_frame_command_core): Use metadata style.
3666         * skip.c (info_skip_command): Use metadata style.
3667         * rust-lang.c (rust_print_enum): Use metadata style.
3668         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3669         metadata style.
3670         * python/py-framefilter.c (py_print_single_arg): Use metadata
3671         style.
3672         * printcmd.c (do_one_display, print_variable_and_value): Use
3673         metadata style.
3674         * p-valprint.c (pascal_val_print)
3675         (pascal_object_print_value_fields): Use metadata style.
3676         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3677         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3678         parameter.
3679         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3680         * m2-valprint.c (m2_print_long_set): Use metadata style.
3681         * m2-typeprint.c (m2_print_type): Use metadata style.
3682         * infcmd.c (print_return_value_1): Use metadata style.
3683         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3684         * f-valprint.c (info_common_command_for_block): Use metadata
3685         style.
3686         * f-typeprint.c (f_type_print_base): Use metadata style.
3687         * expprint.c (print_subexp_standard): Use metadata style.
3688         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3689         * cli/cli-style.h (class cli_style_option): Add constructor.
3690         (metadata_style): Declare.
3691         * cli/cli-style.c (metadata_style): New global.
3692         (_initialize_cli_style): Register metadata style.
3693         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3694         parameter.
3695         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3696         * c-typeprint.c (c_type_print_base_struct_union)
3697         (c_type_print_base_1): Use metadata style.
3698         * breakpoint.c (watchpoint_value_print)
3699         (print_one_breakpoint_location): Use metadata style.
3700         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3701         style.
3702         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3703         style.
3704         * ada-valprint.c (val_print_packed_array_elements, printstr)
3705         (print_field_values, ada_val_print_ref, ada_val_print): Use
3706         metadata style.
3707         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3708         style.
3709         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3710         style.
3711         * ada-lang.c (user_select_syms): Use metadata style.
3712
3713 2019-10-01  Tom Tromey  <tom@tromey.com>
3714
3715         * cli/cli-cmds.c (pwd_command): Style output.
3716
3717 2019-10-01  Pedro Alves  <palves@redhat.com>
3718             Tom Tromey  <tom@tromey.com>
3719
3720         * symtab.c (print_symbol_info): Use %ps.
3721         (print_msymbol_info): Use %ps.
3722         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3723         * printcmd.c (print_variable_and_value): Use %ps.
3724         * macrocmd.c (show_pp_source_pos): Use %ps.
3725         * infrun.c (print_exited_reason): Use ui_out::message.
3726         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3727         (describe_other_breakpoints): Use ui_out::message and new
3728         formats.
3729         (say_where): Use new formats.
3730         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3731         and new formats.
3732
3733 2019-10-01  Pedro Alves  <palves@redhat.com>
3734             Tom Tromey  <tom@tromey.com>
3735
3736         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3737         (test_gdb_formats): New function.
3738         (run_tests): Call it.
3739         (test_format_specifier): Update.
3740         * utils.h (fputs_filtered): Update comment.
3741         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3742         (fputs_styled_unfiltered): Declare.
3743         * utils.c (fputs_styled_unfiltered): New function.
3744         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3745         (vfprintf_filtered): Update.
3746         (vfprintf_unfiltered, vprintf_filtered): Update.
3747         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3748         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3749         disallow_ui_out_field>: New constants.
3750         (enum class field_kind): New.
3751         (struct base_field_s, struct signed_field_s): New.
3752         (signed_field): New function.
3753         (struct string_field_s): New.
3754         (string_field): New function.
3755         (struct styled_string_s): New.
3756         (styled_string): New function.
3757         (class ui_out) <message>: Add comment.
3758         <vmessage, call_do_message>: New methods.
3759         <do_message>: Add style parameter.
3760         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3761         methods.
3762         (ui_out::message): Rewrite.
3763         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3764         parameter.
3765         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3766         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3767         gdb_extensions parameter.
3768         (class format_piece): Add parameter to constructor.
3769         (n_int_args): New field.
3770         * gdbsupport/format.c (format_pieces::format_pieces): Add
3771         gdb_extensions parameter.  Handle '*'.
3772         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3773         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3774         vfprintf_styled_no_gdbfmt.
3775         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3776         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3777         unfiltered output.
3778         * ui-style.h (struct ui_file_style) <ptr>: New method.
3779
3780 2019-10-01  Tom Tromey  <tom@tromey.com>
3781
3782         * unittests/format_pieces-selftests.c: Update.  Add final format.
3783         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3784         empty literal pieces.
3785
3786 2019-10-01  Tom Tromey  <tom@tromey.com>
3787
3788         * ui-out.h (enum class ui_out_style_kind): Remove.
3789         (class ui_out) <field_string, field_stsream, do_field_string>:
3790         Change type of "style".
3791         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3792         (ui_out::field_string): Update.
3793         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3794         of "style".
3795         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3796         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3797         * stack.c (print_frame_arg, print_frame_info, print_frame):
3798         Update.
3799         * source.c (print_source_lines_base): Update.
3800         * solib.c (info_sharedlibrary_command): Update.
3801         * skip.c (info_skip_command): Update.
3802         * record-btrace.c (btrace_call_history_src_line)
3803         (btrace_call_history): Update.
3804         * python/py-framefilter.c (py_print_frame): Update.
3805         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3806         "style".
3807         * mi/mi-out.c (mi_ui_out::do_table_header)
3808         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3809         (mi_ui_out::do_field_string): Update.
3810         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3811         Update.
3812         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3813         "style".
3814         * cli-out.c (cli_ui_out::do_table_header)
3815         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3816         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3817         (cli_ui_out::do_field_fmt): Update.
3818         * breakpoint.c (print_breakpoint_location): Update.
3819         (update_static_tracepoint): Update.
3820
3821 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3822
3823         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3824         conversion of gdb_datadir.
3825         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3826         remove not needed c_str ().
3827
3828 2019-09-30  Ali Tamur <tamur@google.com>
3829
3830         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3831         (dwarf2_string_attr): Likewise.
3832
3833 2019-09-30  Ali Tamur <tamur@google.com>
3834
3835         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3836         (process_full_type_unit): Likewise.
3837         (dump_die_shallow): Likewise.
3838         (cu_debug_loc_section): Likewise.
3839
3840 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3841
3842         * minsyms.c (compare_minimal_symbols): Rename to...
3843         (minimal_symbol_is_less_than): ...this, and adjust to STL
3844         conventions (return bool, take arguments as references)
3845         (minimal_symbol_reader::install): Call std::sort instead
3846         of qsort.
3847
3848 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3849
3850         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3851         hash and why.
3852         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3853         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3854
3855 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3856
3857         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3858         * psympriv.h (add_psymbol_to_list): Move comment here and update
3859         it.
3860
3861 2019-09-29  Tom de Vries  <tdevries@suse.de>
3862
3863         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3864         Use $tmpdir/$(basename "$output_file").dwz instead of
3865         "${output_file}.dwz".
3866
3867 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3868
3869         PR gdb/25045
3870         * hppa-linux-nat.c: Include gdbarch.h.
3871
3872 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3873
3874         * blockframe.c (find_pc_partial_function): Change return type to bool.
3875         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3876         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3877         (stub_gnu_ifunc_resolve_name): Likewise.
3878         * symtab.c (compare_filenames_for_search): Likewise.
3879         (compare_glob_filenames_for_search): Likewise.
3880         (matching_obj_sections): Likewise.
3881         (symbol_matches_domain): Likewise.
3882         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3883         (find_line_pc): Change return type to bool.
3884         (find_line_pc_range): Likewise.
3885         (producer_is_realview): Likewise.
3886         * symtab.h (symbol_matches_domain): Likewise.
3887         (find_pc_partial_function): Likewise.
3888         (find_pc_line_pc_range): Likewise.
3889         (in_gnu_ifunc_stub): Likewise.
3890         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3891         (find_line_pc): Likewise.
3892         (find_line_pc_range): Likewise.
3893         (matching_obj_sections): Likewise.
3894         (find_line_symtab): Change out parameter to bool.
3895         (producer_is_realview): Change return type to bool.
3896         (compare_filenames_for_search): Likewise.
3897         (compare_glob_filenames_for_search): Likewise.
3898
3899 2019-09-26  Tom Tromey  <tom@tromey.com>
3900
3901         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3902         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3903         * gdb_usleep.h: Remove.
3904         * gdb_usleep.c: Remove.
3905         * utils.c: Don't include gdb_usleep.h.
3906
3907 2019-09-26  Tom Tromey  <tromey@adacore.com>
3908
3909         * python/py-type.c (type_to_type_object): Call check_typedef
3910         for stub types.
3911
3912 2019-09-26  Tom Tromey  <tom@tromey.com>
3913
3914         * utils.h (initialize_utils): Don't declare.
3915         * top.c (gdb_init): Don't call initialize_utils.
3916         * utils.c (initialize_utils): Remove.  Move contents...
3917         (_initialize_utils): ... here.
3918
3919 2019-09-25  Tom Tromey  <tom@tromey.com>
3920
3921         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3922         * utils.h (make_hex_string): Don't declare.
3923         * utils.c (make_hex_string): Remove.
3924
3925 2019-09-24  Tom de Vries  <tdevries@suse.de>
3926
3927         PR gdb/23815
3928         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3929         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3930
3931 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3932
3933         * NEWS: Mention new simulator port for PRU.
3934
3935 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3936
3937         * ada-exp.y (write_object_remaining): Update.
3938         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3939         and eliminate the static buffer.
3940         (ada_decode_symbol): Update.
3941         (ada_la_decode): Update.
3942         (ada_sniff_from_mangled_name): Update.
3943         (is_valid_name_for_wild_match): Update.
3944         (ada_lookup_name_info::matches): Update and simplify.
3945         (name_matches_regex): Update.
3946         (ada_add_global_exceptions): Update.
3947         * ada-lang.h (ada_decode): Update signature.
3948         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3949         * dwarf-index-write.c (debug_names::insert): Update.
3950
3951 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3952
3953         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3954         formatting.
3955
3956 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3957
3958         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3959         Change "nonzero" to "true" in documentation.
3960
3961 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3962
3963         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3964         (_initialize_darwin_solib): Don't set
3965         darwin_so_ops.lookup_lib_global_symbol.
3966         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3967         set_gdbarch_iterate_over_objfiles_in_search_order.
3968         (elf_lookup_lib_symbol): Rename to...
3969         (svr4_iterate_over_objfiles_in_search_order): this, and update
3970         to iterate semantics.
3971         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3972         * solib.c (solib_global_lookup): Remove.
3973         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3974         (solib_global_lookup): Remove.
3975         * symtab.c (lookup_global_or_static_symbol): Remove call to
3976         solib_global_lookup.
3977
3978 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3979
3980         * NEWS: Move entries about default MI version now being
3981         version 3, and about the GDB/MI fix for multi-location
3982         breakpoints to the "since GDB 8.3" section.
3983
3984 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3985
3986         GDB 8.3.1 released.
3987
3988 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3989
3990         * NEWS: Mention that Cell/B.E. debugging support was removed.
3991         * MAINTAINERS: Remove spu target.
3992
3993         * config/djgpp/fnchange.lst: Remove entries for removed files.
3994
3995         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3996         spu-multiarch.o, and spu-tdep.o.
3997         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3998         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3999         spu-multiarch.c, and spu-tdep.c.
4000         * spu-linux-nat.c: Remove file.
4001         * spu-multiarch.c: Remove file.
4002         * spu-tdep.c: Remove file.
4003         * spu-tdep.h: Remove file.
4004         * solib-spu.c: Remove file.
4005         * solib-spu.h: Remove file.
4006
4007         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4008         * configure.nat (spu-linux): Remove.
4009         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4010         solib-multiarch.o from gdb_target_obs.
4011         (spu*-*-*): Remove.
4012
4013         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4014         feature flag.
4015         (ppc_linux_no_features): Update.
4016         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4017         Cell/B.E. support.
4018         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4019         (tdesc_powerpc_cell64l): Likewise.
4020         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4021         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4022         Cell/B.E. support.
4023         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4024         Do not include "features/rs6000/powerpc-cell32l.c" or
4025         "features/rs6000/powerpc-cell64l.c".
4026         (ppc_linux_spu_section): Remove.
4027         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4028         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4029         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4030         (ppc_linux_spe_context_lookup): Remove.
4031         (ppc_linux_spe_context_inferior_created): Remove.
4032         (ppc_linux_spe_context_solib_loaded): Remove.
4033         (ppc_linux_spe_context_solib_unloaded): Remove.
4034         (ppc_linux_spe_context): Remove.
4035         (struct ppu2spu_cache): Remove.
4036         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4037         (struct ppu2spu_data): Remove.
4038         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4039         ppu2spu_unwind): Remove.
4040         (ppc_linux_init_abi): Remove Cell/B.E. support.
4041         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4042
4043         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4044         (rs6000/powerpc-cell64l-expedite): Likewise
4045         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4046         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4047         rs6000/powerpc-cell64l.xml.
4048         * features/rs6000/powerpc-cell32l.xml: Remove.
4049         * features/rs6000/powerpc-cell64l.xml: Likewise.
4050         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4051         * features/rs6000/powerpc-cell64l.c: Likewise.
4052         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4053         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4054         * regformats/reg-spu.dat: Remove.
4055
4056         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4057         * corelow.c (struct spuid_list): Remove.
4058         (add_to_spuid_list): Remove.
4059         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4060         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4061         (remote_protocol_features): Remove associated entries.
4062         (_initialize_remote): No longer initialize them.
4063         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4064         * linux-nat.c (SPUFS_MAGIC): Remove.
4065         (linux_proc_xfer_spu): Remove.
4066         (spu_enumerate_spu_ids): Remove.
4067         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4068         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4069         (linux_make_corefile_notes): No longer call it.
4070
4071         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4072         (cooked_write_test): Likewise.
4073
4074 2019-09-20  Tom Tromey  <tom@tromey.com>
4075
4076         * NEWS: Mention case-sensitivity of TUI commands.
4077         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4078         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4079         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4080
4081 2019-09-20  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-source.c (tui_source_window::set_contents): Use
4084         make_unique_xstrdup.
4085         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4086         make_unique_xstrdup.
4087
4088 2019-09-20  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-data.c: Remove separator comments.
4091         * tui/tui-layout.c: Remove separator comments.
4092         * tui/tui-win.c: Remove separator comments.
4093         * tui/tui-wingeneral.c: Remove separator comments.
4094
4095 2019-09-20  Tom Tromey  <tom@tromey.com>
4096
4097         * tui/tui.h (strcat_to_buf): Don't declare.
4098         * tui/tui.c (strcat_to_buf): Remove.
4099
4100 2019-09-20  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4103         from "fullname".
4104         * tui/tui-source.c (tui_source_window::set_contents)
4105         (tui_source_window::location_matches_p)
4106         (tui_source_window::maybe_update): Update.
4107
4108 2019-09-20  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4111         Update.
4112         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4113         prefix.
4114         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4115         (tui_data_window::line_from_reg_element_no)
4116         (tui_data_window::first_reg_element_no_inline)
4117         (tui_data_window::show_registers)
4118         (tui_data_window::show_register_group)
4119         (tui_data_window::display_registers_from)
4120         (tui_data_window::display_registers_from_line)
4121         (tui_data_window::first_data_item_displayed)
4122         (tui_data_window::delete_data_content_windows)
4123         (tui_data_window::erase_data_content)
4124         (tui_data_window::do_scroll_vertical)
4125         (tui_data_window::refresh_window)
4126         (tui_data_window::check_register_values): Update.
4127
4128 2019-09-20  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4131         (struct tui_locator_window) <full_name, proc_name>: Now
4132         std::string.
4133         * tui/tui-stack.c (tui_locator_window::make_status_line)
4134         (tui_locator_window::set_locator_fullname)
4135         (tui_locator_window::set_locator_info): Update.
4136         * tui/tui-source.c (tui_source_window::set_contents)
4137         (tui_source_window::showing_source_p): Update.
4138
4139 2019-09-20  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4142         Don't call tui_locator_win_info_ptr.
4143
4144 2019-09-20  Tom Tromey  <tom@tromey.com>
4145
4146         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4147
4148 2019-09-20  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4151         height for locator.
4152         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4153         * tui/tui-layout.c (show_source_disasm_command, show_data)
4154         (show_source_or_disasm_and_command): Use 1 as height for locator.
4155
4156 2019-09-20  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui.c (tui_enable): Update.
4159         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4160         Update.
4161         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4162         Update.
4163         * tui/tui-data.c (win_resized): Now bool.
4164         (tui_win_resized): Return bool.
4165         (tui_set_win_resized_to): Accept a bool.
4166
4167 2019-09-20  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4170         Change type of "refresh_values_only".
4171         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4172         type of "refresh_values_only".
4173
4174 2019-09-20  Tom Tromey  <tom@tromey.com>
4175
4176         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4177         std::string.
4178         (tui_disassemble): Add "pos" parameter.
4179         (tui_disasm_window::set_contents): Simplify.
4180
4181 2019-09-20  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-winsource.h (struct tui_source_window_base)
4184         <show_source_content>: Now private.
4185         * tui/tui-winsource.c
4186         (tui_source_window_base::show_source_content): Don't handle empty
4187         content case.
4188
4189 2019-09-20  Tom Tromey  <tom@tromey.com>
4190
4191         * tui/tui-layout.c (show_source_disasm_command)
4192         (show_source_or_disasm_and_command): Don't call
4193         show_source_content.
4194
4195 2019-09-20  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4198         Declare.
4199         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4200         from tui_make_status_line.
4201         (tui_locator_window::rerender): Update.
4202
4203 2019-09-20  Tom Tromey  <tom@tromey.com>
4204
4205         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4206         (tui_locator_window::rerender): Update.
4207
4208 2019-09-20  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui-winsource.h (struct tui_source_window_base)
4211         <~tui_source_window_base>: Don't declare.
4212         <fullname>: Remove.
4213         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4214         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4215         member.
4216         * tui/tui-source.c (tui_source_window::set_contents): Update.
4217         (tui_source_window::location_matches_p)
4218         (tui_source_window::maybe_update): Update.
4219
4220 2019-09-20  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-winsource.h (~tui_source_element): Remove.
4223         (tui_source_element): Update.
4224         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4225         * tui/tui-winsource.c (tui_show_source_line): Update.
4226         * tui/tui-source.c (tui_source_window::set_contents): Update.
4227         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4228
4229 2019-09-20  Tom Tromey  <tom@tromey.com>
4230
4231         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4232         declare.
4233         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4234         tui_clear_source_windows_detail.
4235         * tui/tui-winsource.h (struct tui_source_window_base)
4236         <clear_detail>: Don't declare.
4237         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4238         Remove.
4239         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4240
4241 2019-09-20  Tom Tromey  <tromey@adacore.com>
4242
4243         PR ada/24919:
4244         * block.c (contained_in): Fix final return value.
4245
4246 2019-09-20  Alan Modra  <amodra@gmail.com>
4247
4248         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4249         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4250         (read_indirect_string_from_dwz): Use bfd accessor.
4251         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4252         * machoread.c (macho_symfile_read_all_oso): Likewise.
4253         * solib.c (solib_bfd_open): Likewise.
4254
4255 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4256
4257         * eval.c: Move declaration of overload_resolution to...
4258         * value.h: ...here.
4259
4260 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4261
4262         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4263         * arm-linux-tdep.c: Likewise.
4264         * arm-nbsd-nat.c: Likewise.
4265         * arm-tdep.h: Declare arm_apcs_32.
4266         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4267
4268 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4269
4270         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4271         * dwarf2read.h: Declare dwarf_always_disassemble.
4272
4273 2019-09-19  Tom de Vries  <tdevries@suse.de>
4274
4275         PR gdb/25009
4276         * source-cache.c (source_cache::ensure): Catch exception thrown during
4277         construction of the highlighter.
4278
4279 2019-09-18  Alan Modra  <amodra@gmail.com>
4280
4281         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4282         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4283         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4284         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4285         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4286         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4287         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4288         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4289         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4290         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4291         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4292         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4293         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4294         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4295         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4296         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4297         * mi/mi-interp.c: Update throughout for bfd section macro and
4298         function changes.
4299         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4300         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4301
4302 2019-09-18  Tom Tromey  <tom@tromey.com>
4303
4304         * NEWS: Add entry.
4305         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4306         call rl_initialize.
4307         (tui_enable): Do not call rl_initialize.
4308
4309 2019-09-18  Christian Groessler  <chris@groessler.org>
4310
4311         * alpha-linux-nat.c: Include gdbarch.h.
4312
4313 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4314
4315         * ui-file.c: Include cli/cli-style.h.
4316         (term_cli_styling): Remove cli_styling declaration.
4317
4318 2019-09-18  Alan Modra  <amodra@gmail.com>
4319
4320         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4321         to bfd_asymbol_section.
4322
4323 2019-09-18  Alan Modra  <amodra@gmail.com>
4324
4325         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4326         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4327         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4328
4329 2019-09-18  Alan Modra  <amodra@gmail.com>
4330
4331         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4332         * spu-linux-nat.c (spu_bfd_open): Likewise.
4333
4334 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4335
4336         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4337         to bool to match definition in dwarf2read.c.
4338
4339 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4340
4341         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4342         (print_signatures): Likewise.
4343         (trust_pad_over_xvs): Likewise.
4344         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4345         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4346         * arm-linux-nat.c (arm_apcs_32): Likewise.
4347         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4348         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4349         * arm-tdep.c (arm_debug): Likewise.
4350         (arm_apcs_32): Likewise.
4351         * auto-load.c (debug_auto_load): Likewise.
4352         (auto_load_gdb_scripts): Likewise.
4353         (global_auto_load): Likewise.
4354         (auto_load_local_gdbinit): Likewise.
4355         (auto_load_local_gdbinit_loaded): Likewise.
4356         * auto-load.h (global_auto_load): Likewise.
4357         (auto_load_local_gdbinit): Likewise.
4358         (auto_load_local_gdbinit_loaded): Likewise.
4359         * breakpoint.c (disconnected_dprintf): Likewise.
4360         (breakpoint_proceeded): Likewise.
4361         (automatic_hardware_breakpoints): Likewise.
4362         (always_inserted_mode): Likewise.
4363         (target_exact_watchpoints): Likewise.
4364         (_initialize_breakpoint): Update.
4365         * breakpoint.h (target_exact_watchpoints): Change to bool.
4366         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4367         * cli/cli-cmds.c (trace_commands): Likewise.
4368         * cli/cli-cmds.h (trace_commands): Likewise.
4369         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4370         to bool*.
4371         * cli/cli-logging.c (logging_overwrite): Change to bool.
4372         (logging_redirect): Likewise.
4373         (debug_redirect): Likewise.
4374         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4375         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4376         to bool.
4377         <boolean_option_def>: Update.
4378         (struct flag_option_def): Change default type of Context to bool
4379         from int.
4380         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4381         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4382         (get_setshow_command_value_string): Likewise.
4383         * cli/cli-style.c (cli_styling): Change to bool.
4384         (source_styling): Likewise.
4385         * cli/cli-style.h (source_styling): Likewise.
4386         (cli_styling): Likewise.
4387         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4388         to bool.
4389         * command.h (var_types): Update comment.
4390         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4391         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4392         bool.
4393         (debug_compile_cplus_scopes): Likewise.
4394         * compile/compile-internal.h (compile_debug): Likewise.
4395         * compile/compile.c (compile_debug): Likewise.
4396         (struct compile_options) <raw>: Likewise.
4397         * cp-support.c (catch_demangler_crashes): Likewise.
4398         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4399         (usr_cmd_cris_dwarf2_cfi): Likewise.
4400         * csky-tdep.c (csky_debug): Likewise.
4401         * darwin-nat.c (enable_mach_exceptions): Likewise.
4402         * dcache.c (dcache_enabled_p): Likewise.
4403         * defs.h (info_verbose): Likewise.
4404         * demangle.c (demangle): Likewise.
4405         (asm_demangle): Likewise.
4406         * dwarf-index-cache.c (debug_index_cache): Likewise.
4407         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4408         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4409         * dwarf2read.c (check_physname): Likewise.
4410         (use_deprecated_index_sections): Likewise.
4411         (dwarf_always_disassemble): Likewise.
4412         * eval.c (overload_resolution): Likewise.
4413         * event-top.c (set_editing_cmd_var): Likewise.
4414         (exec_done_display_p): Likewise.
4415         * event-top.h (set_editing_cmd_var): Likewise.
4416         (exec_done_display_p): Likewise.
4417         * exec.c (write_files): Likewise.
4418         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4419         (debug_fbsd_nat): Likewise.
4420         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4421         Likewise.
4422         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4423         <backtrace_past_entry> Likewise.
4424         * gdb-demangle.h (demangle): Likewise.
4425         (asm_demangle): Likewise.
4426         * gdb_bfd.c (bfd_sharing): Likewise.
4427         * gdbcore.h (write_files): Likewise.
4428         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4429         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4430         * gdbthread.h (print_thread_events): Likewise.
4431         * gdbtypes.c (opaque_type_resolution): Likewise.
4432         (strict_type_checking): Likewise.
4433         * gnu-nat.c (gnu_debug_flag): Likewise.
4434         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4435         * guile/scm-param.c (pascm_variable): Add boolval.
4436         (add_setshow_generic): Update.
4437         (pascm_param_value): Update.
4438         (pascm_set_param_value_x): Update.
4439         * hppa-tdep.c (hppa_debug): Change to bool..
4440         * infcall.c (may_call_functions_p): Likewise.
4441         (coerce_float_to_double_p): Likewise.
4442         (unwind_on_signal_p): Likewise.
4443         (unwind_on_terminating_exception_p): Likewise.
4444         * infcmd.c (startup_with_shell): Likewise.
4445         * inferior.c (print_inferior_events): Likewise.
4446         * inferior.h (startup_with_shell): Likewise.
4447         (print_inferior_events): Likewise.
4448         * infrun.c (step_stop_if_no_debug): Likewise.
4449         (detach_fork): Likewise.
4450         (debug_displaced): Likewise.
4451         (disable_randomization): Likewise.
4452         (non_stop): Likewise.
4453         (non_stop_1): Likewise.
4454         (observer_mode): Likewise.
4455         (observer_mode_1): Likewise.
4456         (set_observer_mode): Update.
4457         (sched_multi): Change to bool.
4458         * infrun.h (debug_displaced): Likewise.
4459         (sched_multi): Likewise.
4460         (step_stop_if_no_debug): Likewise.
4461         (non_stop): Likewise.
4462         (disable_randomization): Likewise.
4463         * linux-tdep.c (use_coredump_filter): Likewise.
4464         (dump_excluded_mappings): Likewise.
4465         * linux-thread-db.c (auto_load_thread_db): Likewise.
4466         (check_thread_db_on_load): Likewise.
4467         * main.c (captured_main_1): Update.
4468         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4469         xx2_opt, boolean_opt>: Change to bool.
4470         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4471         * maint.c (maintenance_profile_p): Likewise.
4472         (per_command_time): Likewise.
4473         (per_command_space): Likewise.
4474         (per_command_symtab): Likewise.
4475         * memattr.c (inaccessible_by_default): Likewise.
4476         * mi/mi-main.c (mi_async): Likewise.
4477         (mi_async_1): Likewise.
4478         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4479         * nat/fork-inferior.h (startup_with_shell): Likewise.
4480         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4481         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4482         * nios2-tdep.c (nios2_debug): Likewise.
4483         * or1k-tdep.c (or1k_debug): Likewise.
4484         * parse.c (parser_debug): Likewise.
4485         * parser-defs.h (parser_debug): Likewise.
4486         * printcmd.c (print_symbol_filename): Likewise.
4487         * proc-api.c (procfs_trace): Likewise.
4488         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4489         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4490         (set_parameter_value): Update.
4491         (add_setshow_generic): Update.
4492         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4493         to bool*.
4494         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4495         int*.
4496         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4497         * record-btrace.c (record_btrace_target::store_registers): Update.
4498         * record-full.c (record_full_memory_query): Change to bool.
4499         (record_full_stop_at_limit): Likewise.
4500         * record-full.h (record_full_memory_query): Likewise.
4501         * remote-notif.c (notif_debug): Likewise.
4502         * remote-notif.h (notif_debug): Likewise.
4503         * remote.c (use_range_stepping): Likewise.
4504         (interrupt_on_connect): Likewise.
4505         (remote_break): Likewise.
4506         * ser-tcp.c (tcp_auto_retry): Likewise.
4507         * ser-unix.c (serial_hwflow): Likewise.
4508         * skip.c (debug_skip): Likewise.
4509         * solib-aix.c (solib_aix_debug): Likewise.
4510         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4511         (spu_auto_flush_cache_p): Likewise.
4512         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4513         Likewise.
4514         (struct info_print_options) <quiet>: Likewise.
4515         * symfile-debug.c (debug_symfile): Likewise.
4516         * symfile.c (auto_solib_add): Likewise.
4517         (separate_debug_file_debug): Likewise.
4518         * symfile.h (auto_solib_add): Likewise.
4519         (separate_debug_file_debug): Likewise.
4520         * symtab.c (basenames_may_differ): Likewise.
4521         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4522         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4523         (struct info_types_options) <quiet>: Likewise.
4524         * symtab.h (demangle): Likewise.
4525         (basenames_may_differ): Likewise.
4526         * target-dcache.c (stack_cache_enabled_1): Likewise.
4527         (code_cache_enabled_1): Likewise.
4528         * target.c (trust_readonly): Likewise.
4529         (may_write_registers): Likewise.
4530         (may_write_memory): Likewise.
4531         (may_insert_breakpoints): Likewise.
4532         (may_insert_tracepoints): Likewise.
4533         (may_insert_fast_tracepoints): Likewise.
4534         (may_stop): Likewise.
4535         (auto_connect_native_target): Likewise.
4536         (target_stop_and_wait): Update.
4537         (target_async_permitted): Change to bool.
4538         (target_async_permitted_1): Likewise.
4539         (may_write_registers_1): Likewise.
4540         (may_write_memory_1): Likewise.
4541         (may_insert_breakpoints_1): Likewise.
4542         (may_insert_tracepoints_1): Likewise.
4543         (may_insert_fast_tracepoints_1): Likewise.
4544         (may_stop_1): Likewise.
4545         * target.h (target_async_permitted): Likewise.
4546         (may_write_registers): Likewise.
4547         (may_write_memory): Likewise.
4548         (may_insert_breakpoints): Likewise.
4549         (may_insert_tracepoints): Likewise.
4550         (may_insert_fast_tracepoints): Likewise.
4551         (may_stop): Likewise.
4552         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4553         (make_thread_apply_all_options_def_group): Change argument from int*
4554         to bool*.
4555         (thread_apply_all_command): Update.
4556         (print_thread_events): Change to bool.
4557         * top.c (confirm): Likewise.
4558         (command_editing_p): Likewise.
4559         (history_expansion_p): Likewise.
4560         (write_history_p): Likewise.
4561         (info_verbose): Likewise.
4562         * top.h (confirm): Likewise.
4563         (history_expansion_p): Likewise.
4564         * tracepoint.c (disconnected_tracing): Likewise.
4565         (circular_trace_buffer): Likewise.
4566         * typeprint.c (print_methods): Likewise.
4567         (print_typedefs): Likewise.
4568         * utils.c (debug_timestamp): Likewise.
4569         (sevenbit_strings): Likewise.
4570         (pagination_enabled): Likewise.
4571         * utils.h (sevenbit_strings): Likewise.
4572         (pagination_enabled): Likewise.
4573         * valops.c (overload_resolution): Likewise.
4574         * valprint.h (struct value_print_options) <prettyformat_arrays,
4575         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4576         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4577         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4578         Likewise.
4579         * windows-nat.c (new_console): Likewise.
4580         (cygwin_exceptions): Likewise.
4581         (new_group): Likewise.
4582         (debug_exec): Likewise.
4583         (debug_events): Likewise.
4584         (debug_memory): Likewise.
4585         (debug_exceptions): Likewise.
4586         (useshell): Likewise.
4587         * windows-tdep.c (maint_display_all_tib): Likewise.
4588         * xml-support.c (debug_xml): Likewise.
4589
4590 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4591
4592         * source.c (prepare_path_for_appending): New function.
4593         (openp): Make use of new function.
4594         (find_and_open_source): Search for the compilation directory and
4595         source file as a relative path beneath the directory search path.
4596
4597 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4598
4599         * source-cache.c (source_cache::get_line_charpos): Catch
4600         exceptions and return false, this matches the behaviour documented
4601         in the header file.
4602
4603 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4604
4605         * ada-tasks.c (info_task): Remove quoting of the task's name.
4606
4607 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4608
4609         * symfile.c (auto_solib_add): Replace comment with a reference
4610         to the header file.
4611
4612 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4613
4614         * NEWS: Mention that gdb can now be compiled with Python 3
4615         on Windows.
4616
4617 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * maint.c (maint_print_section_data::maint_print_section_data):
4620         Force use of 'float log10 (float)' by casting the argument to
4621         float.
4622
4623 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4624
4625         * maint.c: Add 'cmath' include.
4626         (struct maint_print_section_data): New structure.
4627         (print_section_index): New function.
4628         (print_bfd_section_info): Add header comment, small whitespace
4629         cleanup, and update to call new print_section_index function.
4630         (print_objfile_section_info): Likewise.
4631         (maint_obj_section_from_bfd_section): New function.
4632         (print_bfd_section_info_maybe_relocated): New function.
4633         (maintenance_info_sections): Add header comment, always use
4634         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4635
4636 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4639         inner scope, add check that the objfile has psymtabs before
4640         checking psymtabs_addrmap.
4641         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4642
4643 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4644
4645         * NEWS: Announce that Ada task names are now shown at more places,
4646         and between quotes (except in info task output).
4647         * gdb/ada-tasks.c (task_to_str): New function.
4648         (display_current_task_id): Call task_to_str.
4649         (task_command_1): Likewise.
4650         (print_ada_task_info): In non-mi mode, Properly align headers and data
4651         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4652
4653 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4654
4655         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4656         prstatus.pr_lwp.pr_info instead of making it up.
4657
4658 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4659
4660         * auto-load.c (auto_load_expand_dir_vars): Update.
4661         * defs.h (gdb_datadir): Change to std::string.
4662         (python_libdir): Likewise.
4663         (relocate_gdb_directory): Change return type to std::string.
4664         * guile/guile.c (gdbscm_data_directory): Update.
4665         (initialize_scheme_side): Update.
4666         * jit.c (jit_reader_dir): Change to std::string.
4667         (jit_reader_load_command): Update.
4668         * main.c (gdb_datadir): Change to std::string.
4669         (python_libdir): Likewise.
4670         (set_gdb_data_directory): Update.
4671         (relocate_path): Change to return std::string.
4672         (relocate_gdb_directory): Change to return std::string.
4673         (relocate_gdbinit_path_maybe_in_datadir): Update.
4674         (captured_main_1): Update.
4675         * python/python.c (do_start_initialization): Update.
4676         * top.c (show_gdb_datadir): Update.
4677         * xml-syscall.c (xml_init_syscalls_info): Update.
4678         (init_syscalls_info): Update.
4679
4680 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4681
4682         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4683         out of get_init_files.
4684         (get_init_files): Update.
4685
4686 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4687
4688         * main.c (get_init_files): Change to use std::string.
4689         (captured_main_1): Update.
4690         (print_gdb_help): Update.
4691
4692 2019-09-11  Ali Tamur  <tamur@google.com>
4693
4694         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4695         implementation.
4696
4697 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4698
4699         * dbxread.c (read_dbx_symtab): Update.
4700         * dwarf2read.c (load_partial_dies): Update.
4701         * mdebugread.c (parse_partial_symbols): Update.
4702         (handle_psymbol_enumerators): Update.
4703         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4704         * psymtab.c (add_psymbol_to_bcache): Likewise.
4705         (add_psymbol_to_list): Likewise.
4706         * symtab.c (symbol_set_names): Likewise.
4707         * symtab.h (symbol_set_names): Likewise.
4708         * xcoffread.c (scan_xcoff_symtab): Update.
4709
4710 2019-09-11  Tom Tromey  <tom@tromey.com>
4711
4712         * symfile-mem.c (symbol_file_add_from_memory): Use
4713         bfd_set_filename.
4714         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4715         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4716
4717 2019-09-10  Tom Tromey  <tromey@adacore.com>
4718
4719         * dwarf-index-write.c (write_psymbols): Extend error message.
4720         (debug_names::insert): Add Ada code.
4721         (debug_names::write_psymbols): Remove Ada check.
4722         (debug_names) <m_string_obstack>: New member.
4723         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4724         (gdb_index_symbol_name_matcher::matches): Remove.
4725         (mapped_index_base::find_name_components_bounds): Add "lang"
4726         parameter.
4727         (mapped_index_base::build_name_components): Also split names
4728         according to Ada syntax.
4729         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4730         type of "match_callback".
4731         (check_match, check_find_bounds_finds)
4732         (dw2_expand_symtabs_matching): Update.
4733         (dw2_debug_names_iterator): Add new constructor.
4734         (dw2_debug_names_map_matching_symbols): New function.
4735         (dw2_debug_names_expand_symtabs_matching): Update.
4736         (dwarf2_debug_names_functions): Use
4737         dw2_debug_names_map_matching_symbols.
4738
4739 2019-09-10  Tom Tromey  <tromey@adacore.com>
4740
4741         * dwarf2read.c (dw2_get_file_names_reader): Add the
4742         CU's file name to the results.
4743
4744 2019-09-10  Tom Tromey  <tromey@adacore.com>
4745
4746         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4747         map_matching_symbols.  Update.
4748         * dwarf2read.c (dw2_map_matching_symbols): Update.
4749         * psymtab.c (match_partial_symbol): Change type; update.
4750         (psym_map_matching_symbols): Likewise.
4751         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4752         type; update.
4753         * symfile.h (struct quick_symbol_functions)
4754         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4755         Remove "match".
4756
4757 2019-09-10  Tom Tromey  <tromey@adacore.com>
4758
4759         * psymtab.c (map_block): Remove.
4760         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4761         * symtab.c (iterate_over_symbols_terminated): New function.
4762         * symtab.c (iterate_over_symbols_terminated): Declare.
4763
4764 2019-09-10  Tom Tromey  <tromey@adacore.com>
4765
4766         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4767         * language.h (struct language_defn) <la_iterate_over_symbols>:
4768         Return bool.
4769         * symtab.c (iterate_over_symbols): Return bool.
4770         * symtab.h (iterate_over_symbols): Return bool.
4771
4772 2019-09-10  Tom Tromey  <tromey@adacore.com>
4773
4774         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4775         (add_nonlocal_symbols): Update.
4776         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4777         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4778         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4779         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4780         Change type of "callback".  Remove "data".
4781
4782
4783 2019-09-09  Ali Tamur  <tamur@google.com>
4784
4785         * dwarf2read.c (comp_unit_head): Update comment.
4786         (dwarf2_dwo_name): New function declaration.
4787         (dwarf_unit_type_name): New function declaration.
4788         (read_comp_unit_head): Add support for new compilation units,
4789         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4790         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4791         (currently named as "signature") in their header. Also clarify error
4792         messages.
4793         (lookup_dwo_id): New function. Returns the dwo id of the given
4794         compile unit.
4795         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4796         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4797         functions.
4798         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4799         (dwarf2_dwo_name): Get the dwo name if present.
4800         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4801         purposes.
4802
4803 2019-09-09  Tom Tromey  <tom@tromey.com>
4804
4805         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4806
4807 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4808
4809         * python/python.c (do_start_initialization): Make progname_copy static,
4810         to avoid a leak report.
4811
4812 2019-09-08  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4815
4816 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4817
4818         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4819         Change type to gdb::optional<block_enum>.
4820         (dw2_symtab_iter_init): Change block_index parameter type
4821         to gdb::optional<block_enum>.
4822         (dw2_lookup_symbol): Change block_index parameter
4823         type to block_enum.c
4824         (dw2_debug_names_lookup_symbol): Likewise.
4825         * psymtab.c (psym_lookup_symbol): Likewise.
4826         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4827         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4828         Likewise.
4829
4830 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4831
4832         * defs.h (relocate_gdb_directory): Change int to bool in
4833         signature and rename flag to relocatable.
4834         * main.c (relocate_path): Likewise.
4835         (relocate_gdb_directory): Likewise.
4836
4837 2019-09-06  Alan Modra  <amodra@gmail.com>
4838
4839         * coffread.c (coff_symfile_read): Constify filename variable.
4840         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4841         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4842         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4843         * solib.c (reload_shared_libraries_1): Likewise.
4844         * symfile.c (reread_symbols): Likewise.
4845         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4846         * solib-darwin.c (darwin_bfd_open): Likewise.
4847         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4848
4849 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4852         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4853
4854 2019-09-03  Tom Tromey  <tromey@adacore.com>
4855
4856         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4857         types.
4858         (has_negatives): Unbias a range type bound.
4859         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4860         * gdbtypes.c (operator==): Handle new field.
4861         (create_range_type): Add "bias" parameter.
4862         (create_static_range_type, resolve_dynamic_range): Update.
4863         * gdbtypes.h (struct range_bounds) <bias>: New member.
4864         (create_range_type): Add bias parameter.
4865         * printcmd.c (print_scalar_formatted): Unbias range types.
4866         * value.c (unpack_long): Unbias range types.
4867         (pack_long): Bias range types.
4868
4869 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4870
4871         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4872         probe arguments.
4873
4874 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4875
4876         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4877         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4878         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4879         (compile_probe_arg): Likewise.
4880         * probe.h (get_argument_count): Likewise.
4881         * solib-svr4.c (solib_event_probe_action): Likewise.
4882         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4883
4884 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4885
4886         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4887         code to here...
4888         (svr4_create_solib_event_breakpoints): ...from here.
4889
4890 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4891
4892         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4893         suffix from warning message.
4894
4895 2019-08-30  Tom Tromey  <tom@tromey.com>
4896
4897         * tui/tui-winsource.h (struct tui_source_window_base)
4898         <refresh_all>: Don't declare.
4899         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4900         Remove.
4901         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4902         tui_show_locator_content.
4903         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4904         declare.
4905         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4906         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4907         declare.
4908
4909 2019-08-30  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4912
4913 2019-08-30  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4916         Remove unnecessary forward declarations.
4917
4918 2019-08-30  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4921         rerender.
4922         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4923         tui_show_locator_content.
4924
4925 2019-08-30  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4928         (tui_locator_window::rerender): Rewrite using body of previous
4929         tui_show_locator_content.
4930
4931 2019-08-30  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4934         set_locator_fullname>: New methods.
4935         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4936         Rename from tui_set_locator_fullname.
4937         (tui_locator_window::set_locator_info): Rename from
4938         tui_set_locator_info.  Return bool.
4939         (tui_update_locator_fullname, tui_show_frame_info): Update.
4940
4941 2019-08-30  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4944
4945 2019-08-30  Tom Tromey  <tom@tromey.com>
4946
4947         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4948         call touchwin.
4949
4950 2019-08-30  Tom Tromey  <tom@tromey.com>
4951
4952         * tui/tui-wingeneral.c (box_win): Assume win_info and
4953         win_info->handle cannot be NULL.
4954
4955 2019-08-30  Tom Tromey  <tom@tromey.com>
4956
4957         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4958         refresh_window>: Declare.
4959         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4960         resize.
4961         (tui_data_item_window::rerender): Rename from
4962         tui_display_register.
4963         (tui_data_item_window::refresh_window): New method.
4964         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4965         no-op.
4966
4967 2019-08-30  Tom Tromey  <tom@tromey.com>
4968
4969         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4970         regs_column_count, current_group>: Move later.  Now private.
4971         <get_current_group>: New method.
4972         * tui/tui-regs.c (tui_reg_command): Update.
4973         * tui/tui-layout.c (tui_set_layout): Update.
4974
4975 2019-08-30  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4978         (tui_data_window::rerender): Don't call
4979         check_and_display_highlight_if_needed.
4980         (tui_data_window::refresh_all): Remove call to
4981         erase_data_content.
4982
4983 2019-08-30  Tom Tromey  <tom@tromey.com>
4984
4985         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4986         (tui_data_window::display_registers_from)
4987         (tui_data_window::display_reg_element_at_line)
4988         (tui_data_window::display_registers_from_line): Remove checks of
4989         "empty".
4990
4991 2019-08-30  Tom Tromey  <tom@tromey.com>
4992
4993         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4994         Don't declare.
4995         * tui/tui-regs.c (tui_data_window::show_registers): Call
4996         rerender.
4997         (tui_data_window::rerender): Rename from display_all_data.
4998         (tui_data_window::rerender): Remove old implementation.
4999
5000 2019-08-30  Tom Tromey  <tom@tromey.com>
5001
5002         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5003         text.
5004         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5005
5006 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5007             Sergio Durigan Junior  <sergiodj@redhat.com>
5008
5009         PR win32/24284
5010         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5011
5012 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5015         when searching for types.
5016
5017 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * f-lang.c (f_language_defn): Use f_print_typedef.
5020         * f-lang.h (f_print_typedef): Declare.
5021         * f-typeprint.c (f_print_typedef): Define.
5022
5023 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5024
5025         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5026
5027 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * cli/cli-utils.c (info_print_options_defs): Delete.
5030         (make_info_print_options_def_group): Delete.
5031         (extract_info_print_options): Delete.
5032         (info_print_command_completer): Delete.
5033         (info_print_args_help): Add extra parameter, and optionally
5034         include text about -n flag.
5035         * cli/cli-utils.h (struct info_print_options): Delete.
5036         (extract_info_print_options): Delete declaration.
5037         (info_print_command_completer): Delete declaration.
5038         (info_print_args_help): Add extra parameter, extend header
5039         comment.
5040         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5041         search_symbols.
5042         * stack.c (struct info_print_options): New type.
5043         (info_print_options_defs): New file scoped variable.
5044         (make_info_print_options_def_group): New static function.
5045         (info_print_command_completer): New static function.
5046         (info_locals_command): Update to use new local functions.
5047         (info_args_command): Likewise.
5048         (_initialize_stack): Add extra parameter to calls to
5049         info_print_args_help.
5050         * symtab.c (search_symbols): Add extra parameter, use this to
5051         possibly excluse non-debug symbols.
5052         (symtab_symbol_info): Add extra parameter, which is passed on to
5053         search_symbols.
5054         (struct info_print_options): New type.
5055         (info_print_options_defs): New file scoped variable.
5056         (make_info_print_options_def_group): New static function.
5057         (info_print_command_completer): New static function.
5058         (info_variables_command): Update to use local functions, and pass
5059         extra parameter through to symtab_symbol_info.
5060         (info_functions_command): Likewise.
5061         (info_types_command): Pass additional argument through to
5062         symtab_symbol_info.
5063         (rbreak_command): Pass extra argument to search_symbols.
5064         (_initialize_symtab): Add extra arguments for calls to
5065         info_print_args_help, and update help text for 'info variables',
5066         'whereis', and 'info functions' commands.
5067         * symtab.h (search_symbols): Add extra argument to declaration.
5068         * NEWS: Mention new flags.
5069
5070 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5071
5072         * symtab.c (lookup_static_symbol): Call the new function (and move
5073         it down to be next to lookup_global_symbol).
5074         (struct global_sym_lookup_data): Add block_enum member and rename to...
5075         (struct global_or_static_sym_lookup_data): ...this.
5076         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5077         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5078         (lookup_symbol_global_or_static_iterator_cb): ...this.
5079         (lookup_global_or_static_symbol): New function.
5080         (lookup_global_symbol): Call new function.
5081
5082 2019-08-26  Tom de Vries  <tdevries@suse.de>
5083
5084         PR c++/24852
5085         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5086         when pc_probe.prob == NULL.
5087
5088 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5089
5090         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5091         variable symbol_linkage to symbol_linkage_.
5092
5093 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5094
5095         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5096         represent whether the symbol is static, dynamic, or we don't
5097         know.
5098
5099 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5100
5101         * gdb/rx-tdep.c (rx_register_names): New.
5102         (rx_register_name): Delete.
5103         (rx_psw_type): Delete.
5104         (rx_fpsw_type): Delete.
5105         (rx_register_type): Delete.
5106         (rx_gdbarch_init): Convert target-descriptions.
5107         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5108         * gdb/features/Makefile: Add rx.xml.
5109         * gdb/features/rx.xml: New.
5110         * gdb/features/rx.c: Generated.
5111         * gdb/NEWS: Mention target description support.
5112
5113 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5114
5115         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5116         *slot_ptr.
5117
5118 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5119
5120         * configure.ac: Don't check for 'dlfcn.h' (moved to
5121         gdbsupport/common.m4).
5122         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5123         'gdbsupport/'.
5124         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5125         * compile/compile-c-support.c: Include
5126         'gdbsupport/gdb-dlfcn.h'.
5127         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5128         * gdb-dlfcn.c: Move to...
5129         * gdbsupport/gdb-dlfcn.c: ... here.
5130         * gdb-dlfcn.h: Move to...
5131         * gdbsupport/gdb-dlfcn.h: ... here.
5132
5133 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5134
5135         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5136         the offset field signed.
5137
5138 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5139
5140         * python/lib/gdb/__init__.py (_execute_file): New function.
5141         * python/python.c (python_run_simple_file): Call gdb._execute_file
5142         on Windows.
5143
5144 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5147         all uses as this was never set to anything but a zero value.
5148
5149 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5150
5151         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5152
5153 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5154
5155         * tui/tui-data.h (tui_gen_win_info): Add an =default
5156         move constructor, required by some GCC versions.
5157
5158 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5159
5160         * go32-nat.c (go32_sysinfo): Add hygon_p.
5161
5162 2019-08-20  Tom Tromey  <tom@tromey.com>
5163
5164         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5165         line_from_reg_element_no, first_reg_element_no_inline,
5166         display_all_data, delete_data_content_windows,
5167         erase_data_content>: Now private.
5168
5169 2019-08-20  Tom Tromey  <tom@tromey.com>
5170
5171         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5172         (tui_unhighlight_win, tui_highlight_win)
5173         (tui_win_info::make_window): Update.
5174         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5175
5176 2019-08-20  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5179         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5180         (MAX_PID_WIDTH): Move to tui-stack.c.
5181         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5182         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5183         (MAX_PID_WIDTH): Move from tui-data.h.
5184
5185 2019-08-20  Tom Tromey  <tom@tromey.com>
5186
5187         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5188         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5189         (box_win): Update.
5190         (tui_gen_win_info::make_window): Rename from tui_make_window.
5191         (tui_win_info::make_window): New method.
5192         (tui_gen_win_info::make_visible): Update.
5193         * tui/tui-source.c (tui_source_window::set_contents): Update.
5194         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5195         (tui_data_window::display_registers_from): Update.
5196         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5197         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5198         Declare.
5199         <can_box>: Remove.
5200         <title>: Remove.
5201         (struct tui_win_info) <make_window>: Declare.
5202         <can_box>: Now virtual.
5203         <title>: New member.
5204         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5205         * tui/tui-command.c (tui_cmd_window::resize): Update.
5206
5207 2019-08-20  Tom Tromey  <tom@tromey.com>
5208
5209         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5210         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5211         (tui_data_window::check_register_values): Update.
5212
5213 2019-08-20  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-regs.h (struct tui_data_window): Use
5216         DISABLE_COPY_AND_ASSIGN.
5217         <regs_content>: Change type, removing unique_ptr.
5218         <tui_data_window>: Add move constructor.
5219         * tui/tui-regs.c (tui_data_window::show_registers)
5220         (tui_data_window::show_register_group)
5221         (tui_data_window::display_registers_from)
5222         (tui_data_window::display_registers_from)
5223         (tui_data_window::first_data_item_displayed)
5224         (tui_data_window::delete_data_content_windows)
5225         (tui_data_window::rerender, tui_data_window::refresh_window)
5226         (tui_data_window::check_register_values): Update.
5227
5228 2019-08-20  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5231         show_register_group>: Declare.
5232         (tui_show_register_group): Don't declare.
5233         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5234         tui_show_registers.
5235         (tui_data_window::show_register_group): Rename from
5236         tui_show_register_group.
5237         (tui_data_window::check_register_values, tui_reg_command):
5238         Update.
5239         * tui/tui-layout.c (tui_set_layout): Update.
5240
5241 2019-08-20  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5244         Declare.
5245         (tui_check_register_values): Don't declare.
5246         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5247         from tui_check_register_values.
5248         * tui/tui-hooks.c (tui_register_changed): Update.
5249
5250 2019-08-20  Tom Tromey  <tom@tromey.com>
5251
5252         * tui/tui-regs.c (tui_reg_layout): Move later.
5253         (tui_show_registers): Don't enable TUI mode or change layout.
5254
5255 2019-08-20  Tom Tromey  <tom@tromey.com>
5256
5257         * tui/tui-regs.h (struct tui_data_item_window)
5258         <~tui_data_item_window>: Remove.
5259         <content>: Now a unique_xmalloc_ptr.
5260         * tui/tui-regs.c (tui_register_format): Return a
5261         unique_xmalloc_ptr.
5262         (tui_get_register): Update.
5263         (~tui_data_item_window): Remove.
5264         (tui_data_window::display_registers_from, tui_display_register):
5265         Update.
5266         * tui/tui-io.h (tui_expand_tabs): Update.
5267         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5268         Remove "col" parameter.
5269
5270 2019-08-20  Tom Tromey  <tom@tromey.com>
5271
5272         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5273         field.
5274         * tui/tui-regs.c (~tui_data_item_window): Update.
5275
5276 2019-08-20  Tom Tromey  <tom@tromey.com>
5277
5278         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5279         earlier.
5280
5281 2019-08-20  Tom Tromey  <tom@tromey.com>
5282
5283         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5284
5285 2019-08-20  Tom Tromey  <tom@tromey.com>
5286
5287         * tui/tui-source.h (struct tui_source_window): Update.
5288         * tui/tui-regs.c (tui_show_registers): Update.
5289         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5290         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5291         (NO_REGS_STRING): Remove defines.
5292
5293 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5294
5295         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5296         unnecessary thread walk if remote doesn't support the packet.
5297
5298 2019-08-19  Tom Tromey  <tromey@adacore.com>
5299
5300         * python/py-value.c (value_has_field): Fix indentation.
5301
5302 2019-08-19  Tom Tromey  <tromey@adacore.com>
5303
5304         * printcmd.c (do_one_display, info_display_command): Update.
5305         * block.h (contained_in): Return bool.  Add allow_nested
5306         parameter.
5307         * block.c (contained_in): Return bool.  Add allow_nested
5308         parameter.
5309
5310 2019-08-19  Tom Tromey  <tom@tromey.com>
5311
5312         * configure: Rebuild.
5313         * configure.ac: Disallow the combination of -static-libstdc++ and
5314         source highlight.
5315         * source-cache.c (get_language_name): Handle rust.
5316         (source_cache::get_source_lines): Ignore highlighting exceptions.
5317
5318 2019-08-16  Tom Tromey  <tom@tromey.com>
5319
5320         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5321         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5322         (struct tui_source_window_base) <make_visible, refresh_window,
5323         resize>: Remove methods.
5324         <execution_info>: Remove field.
5325         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5326         (tui_show_source_line, tui_source_window_base)
5327         (~tui_source_window_base): Update.
5328         (tui_source_window_base::resize)
5329         (tui_source_window_base::make_visible)
5330         (tui_source_window_base::refresh_window): Remove.
5331         (tui_source_window_base::update_exec_info): Update.
5332         * tui/tui-source.c (tui_source_window::set_contents): Update.
5333         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5334
5335 2019-08-16  Tom Tromey  <tom@tromey.com>
5336
5337         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5338         deprecated_query_hook.
5339
5340 2019-08-16  Tom Tromey  <tom@tromey.com>
5341
5342         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5343         (tui_update_source_windows_with_line): Update.
5344         * tui/tui-source.h (struct tui_source_window)
5345         <show_symtab_source>: Declare.
5346         (tui_show_symtab_source): Don't declare.
5347         * tui/tui-source.c (tui_show_symtab_source): Rename from
5348         tui_show_symtab_source.
5349
5350 2019-08-16  Tom Tromey  <tom@tromey.com>
5351
5352         * tui/tui-winsource.h (struct tui_source_window_base)
5353         <set_contents>: Declare.
5354         * tui/tui-winsource.c
5355         (tui_source_window_base::update_source_window_as_is): Update.
5356         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5357         Declare.
5358         (tui_set_source_content): Don't declare.
5359         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5360         tui_set_source_content.
5361         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5362         Declare.
5363         (tui_set_disassem_content): Don't declare.
5364         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5365         tui_set_disassem_content.
5366
5367 2019-08-16  Tom Tromey  <tom@tromey.com>
5368
5369         * tui/tui-winsource.h (struct tui_source_window_base)
5370         <update_breakpoint_info>: Declare.
5371         (tui_update_breakpoint_info): Don't declare.
5372         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5373         (tui_update_all_breakpoint_info): Update.
5374         (tui_source_window_base::update_breakpoint_info): Rename from
5375         tui_update_breakpoint_info.
5376         (tui_source_window_base::update_exec_info): Update.
5377
5378 2019-08-16  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-winsource.h (struct tui_source_window_base)
5381         <update_source_window>: Declare.
5382         (tui_update_source_window): Don't declare.
5383         * tui/tui-winsource.c
5384         (tui_source_window_base::update_source_window): Rename from
5385         tui_update_source_window.
5386         (tui_source_window_base::rerender): Update.
5387         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5388         * tui/tui-disasm.c (tui_show_disassem)
5389         (tui_show_disassem_and_update_source)
5390         (tui_disasm_window::maybe_update): Update.
5391
5392 2019-08-16  Tom Tromey  <tom@tromey.com>
5393
5394         * tui/tui-winsource.h (struct tui_source_window_base)
5395         <update_source_window_as_is>: Declare.
5396         (tui_update_source_window_as_is): Don't declare.
5397         * tui/tui-winsource.c (tui_update_source_window): Update
5398         (tui_source_window_base::update_source_window_as_is): Rename from
5399         tui_update_source_window_as_is.
5400         (tui_source_window_base::refill): Update.
5401         * tui/tui-source.c (tui_show_symtab_source): Update.
5402         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5403         Update.
5404
5405 2019-08-16  Tom Tromey  <tom@tromey.com>
5406
5407         * tui/tui-winsource.h (tui_update_source_window)
5408         (tui_update_source_window_as_is): Remove "noerror" parameter.
5409         * tui/tui-winsource.c (tui_update_source_window)
5410         (tui_update_source_window_as_is): Remove "noerror" parameter.
5411         (tui_update_source_windows_with_addr)
5412         (tui_update_source_windows_with_line)
5413         (tui_source_window_base::rerender)
5414         (tui_source_window_base::refill): Update.
5415         * tui/tui-source.h (tui_set_source_content)
5416         (tui_show_symtab_source): Remove "noerror" parameter.
5417         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5418         parameter.
5419         (tui_show_symtab_source): Likewise.
5420         (tui_source_window::maybe_update): Update.
5421         * tui/tui-disasm.c (tui_show_disassem)
5422         (tui_show_disassem_and_update_source)
5423         (tui_disasm_window::do_scroll_vertical)
5424         (tui_disasm_window::maybe_update): Update.
5425
5426 2019-08-16  Tom Tromey  <tom@tromey.com>
5427
5428         * tui/tui.c (tui_is_window_visible): Update.
5429         * tui/tui-wingeneral.c (tui_make_window)
5430         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5431         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5432         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5433         (tui_set_win_height_command, parse_scrolling_args): Update.
5434         * tui/tui-source.c (tui_source_window::style_changed): Update.
5435         * tui/tui-regs.c (tui_show_registers)
5436         (tui_data_window::first_data_item_displayed)
5437         (tui_data_window::delete_data_content_windows)
5438         (tui_check_register_values, tui_reg_command): Update.
5439         * tui/tui-disasm.c (tui_show_disassem): Update.
5440         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5441         method.
5442         <is_visible>: Remove field.
5443         * tui/tui-data.c (tui_next_win, tui_prev_win)
5444         (tui_delete_invisible_windows): Update.
5445
5446 2019-08-16  Tom Tromey  <tom@tromey.com>
5447
5448         * tui/tui-winsource.h (struct tui_source_window_base)
5449         <m_has_locator>: Remove.
5450         * tui/tui-layout.c (show_source_disasm_command, show_data)
5451         (show_source_or_disasm_and_command): Update.
5452
5453 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5454
5455         * NEWS (Other MI changes): New subsection.
5456         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5457         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5458         * arch-utils.c (default_get_pc_address_flags): New function.
5459         * arch-utils.h (default_get_pc_address_flags): New declaration.
5460         * gdbarch.sh: Add get_pc_address_flags.
5461         * gdbarch.c: Regenerate.
5462         * gdbarch.h: Likewise.
5463         * stack.c (print_pc): New function.
5464         (print_frame_info) (print_frame): Call print_pc.
5465
5466 2019-08-16  Tom de Vries  <tdevries@suse.de>
5467
5468         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5469         print_objfile_section_info.
5470
5471 2019-08-15  Tom Tromey  <tom@tromey.com>
5472
5473         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5474         calling update_cmdwin_start_line.
5475         * tui/tui-winsource.h (struct tui_source_window_base)
5476         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5477         <rerender>: Declare.
5478         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5479         Call rerender.
5480         (tui_source_window_base::set_new_height): Remove.
5481         (tui_source_window_base::rerender): Rename from
5482         do_make_visible_with_new_height.
5483         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5484         resize method.
5485         (tui_win_info::make_invisible_and_set_new_height)
5486         (tui_win_info::make_visible_with_new_height): Remove.
5487         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5488         Declare.
5489         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5490         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5491         do_make_visible_with_new_height>: Don't declare.
5492         <rerender>: Declare.
5493         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5494         set_new_height.
5495         (tui_data_window::do_make_visible_with_new_height): Remove.
5496         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5497         call tui_show_locator_content.
5498         (tui_gen_win_info::resize): Call rerender.
5499         (show_source_or_disasm_and_command): Don't call
5500         tui_show_locator_content.
5501         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5502         method.
5503         (struct tui_win_info) <rerender>: Declare.
5504         <set_new_height, make_invisible_and_set_new_height,
5505         make_visible_with_new_height>: Don't declare.
5506         * tui/tui-data.c (tui_win_list::rerender): New method.
5507         * tui/tui-command.h (struct tui_cmd_window)
5508         <do_make_visible_with_new_height>: Don't declare.
5509         * tui/tui-command.c
5510         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5511
5512 2019-08-15  Tom Tromey  <tromey@adacore.com>
5513
5514         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5515         * ada-lang.c (ada_enum_name): Likewise.
5516
5517 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5518
5519         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5520         leading underscore.
5521         (GdbOutputErrorFile): Likewise.
5522         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5523         accordingly.
5524         (execute_unwinders): Rename to have a leading underscore.
5525         (auto_load_packages): Likewise.
5526         (global scope): Adjust call to auto_load_packages accordingly.
5527         (GdbSetPythonDirectory): Likewise.
5528         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5529         instead of execute_unwinders.
5530
5531 2019-08-15  Tom Tromey  <tom@tromey.com>
5532
5533         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5534         (show_data): Don't change window visibility.
5535         (tui_gen_win_info::resize): Remove special case for command
5536         window.  Use wresize, when available.
5537         (show_source_or_disasm_and_command): Don't change window
5538         visibility.
5539         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5540         <make_visible>: New method.
5541         * tui/tui-command.c (tui_cmd_window::resize): New method.
5542
5543 2019-08-15  Tom Tromey  <tom@tromey.com>
5544
5545         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5546         (struct tui_source_windows): New.
5547         * tui/tui-winsource.c (tui_display_main): Update.
5548         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5549         (new_height_ok, parse_scrolling_args): Update.
5550         * tui/tui-layout.c (show_layout, show_data): Update.
5551         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5552         (tui_add_to_source_windows): Don't declare.
5553         * tui/tui-data.c (source_windows, tui_source_windows)
5554         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5555
5556 2019-08-15  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5559         Rename from reset.
5560         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5561         * tui/tui-layout.c (show_source_disasm_command, show_data):
5562         Update.
5563         (tui_gen_win_info::resize): Rename.
5564         (show_source_or_disasm_and_command): Update.
5565         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5566         reset.
5567
5568 2019-08-15  Tom Tromey  <tom@tromey.com>
5569
5570         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5571         * tui/tui-interp.c (tui_interp::init): Don't call
5572         tui_initialize_static_data.
5573         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5574
5575 2019-08-15  Tom Tromey  <tom@tromey.com>
5576
5577         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5578         examine tui_win_list.
5579
5580 2019-08-15  Tom Tromey  <tom@tromey.com>
5581
5582         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5583         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5584         tui_clear_source_content.
5585         (tui_clear_source_content): Remove.
5586         (tui_source_window_base::do_erase_source_content): Hoist call to
5587         content.clear().
5588         * tui/tui-stack.c (tui_show_frame_info): Don't call
5589         tui_clear_source_content.
5590
5591 2019-08-15  Tom Tromey  <tom@tromey.com>
5592
5593         * tui/tui-winsource.h (struct tui_source_window_base)
5594         <do_erase_source_content>: New method.
5595         <erase_source_content>: New method.
5596         (tui_erase_source_content): Don't declare.
5597         * tui/tui-winsource.c (tui_clear_source_content): Update.
5598         (tui_source_window_base::do_erase_source_content): Rename from
5599         tui_erase_source_content.
5600         (tui_source_window_base::show_source_content): Update.
5601         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5602         * tui/tui-source.h (struct tui_source_window)
5603         <erase_source_content>: New method.
5604         * tui/tui-disasm.h (struct tui_disasm_window)
5605         <erase_source_content>: New method.
5606
5607 2019-08-15  Tom Tromey  <tom@tromey.com>
5608
5609         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5610         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5611         constructor.
5612         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5613         * tui/tui-source.c (tui_set_source_content): Update.
5614         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5615
5616 2019-08-15  Tom Tromey  <tom@tromey.com>
5617
5618         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5619         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5620         tui-source.c.
5621         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5622         Declare.
5623         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5624         method.
5625         (tui_source_window::maybe_update): Update.
5626
5627 2019-08-15  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5630         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5631         tui-disasm.c.
5632         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5633         Declare.
5634         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5635         method.
5636         (tui_disasm_window::maybe_update): Update.
5637
5638 2019-08-15  Tom Tromey  <tom@tromey.com>
5639
5640         * tui/tui-winsource.h (struct tui_source_window_base)
5641         <maybe_update>: Declare.
5642         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5643         method.
5644         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5645         Declare.
5646         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5647         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5648         Declare.
5649         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5650
5651 2019-08-15  Tom Tromey  <tom@tromey.com>
5652
5653         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5654
5655 2019-08-15  Tom Tromey  <tom@tromey.com>
5656
5657         * tui/tui-wingeneral.c: Include tui-stack.h.
5658         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5659         (struct tui_locator_window): Move from tui-data.h.
5660         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5661         (tui_initialize_static_data): Move from tui-data.c.
5662         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5663         (struct tui_locator_window): Move to tui-stack.c.
5664         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5665         (tui_initialize_static_data): Move to tui-stack.c.
5666
5667 2019-08-15  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui-layout.c (show_source_disasm_command)
5670         (show_source_or_disasm_and_command): Use make_visible method, not
5671         tui_make_window.
5672         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5673         Remove.
5674
5675 2019-08-15  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-wingeneral.h (tui_make_window): Update.
5678         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5679         parameter.
5680         (tui_gen_win_info::make_visible): Update.
5681         * tui/tui-regs.c (tui_data_window::display_registers_from):
5682         Update.
5683         * tui/tui-layout.c (show_source_disasm_command)
5684         (show_source_or_disasm_and_command): Update.
5685         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5686         (enum tui_box): Remove.
5687         (struct tui_win_info) <can_box>: New method.
5688         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5689         method.
5690
5691 2019-08-15  Tom de Vries  <tdevries@suse.de>
5692
5693         * linux-nat-trad.c: Include gdbarch.h.
5694
5695 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5696
5697         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5698         register sizes.
5699
5700 2019-08-14  Tom Tromey  <tromey@adacore.com>
5701
5702         * darwin-nat.c: Include gdbarch.h.
5703         * darwin-nat-info.c: Include gdbarch.h.
5704
5705 2019-08-13  Tom Tromey  <tom@tromey.com>
5706
5707         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5708         Remove.
5709         * tui/tui-data.c (tui_initialize_static_data): Update.
5710
5711 2019-08-13  Tom Tromey  <tom@tromey.com>
5712
5713         * tui/tui-winsource.h (struct tui_exec_info_window)
5714         <~tui_exec_info_window, maybe_allocate_content, get_content,
5715         m_content>: Remove.
5716         (struct tui_source_window_base) <set_exec_info_content,
5717         show_exec_info_content>: Don't declare.
5718         * tui/tui-winsource.c
5719         (tui_exec_info_window::maybe_allocate_content): Remove.
5720         (tui_source_window_base::update_exec_info): Rename from
5721         set_exec_info_content.
5722         (tui_source_window_base::show_exec_info_content)
5723         (tui_source_window_base::update_exec_info): Remove.
5724
5725 2019-08-13  Tom Tromey  <tom@tromey.com>
5726
5727         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5728         declare.
5729         * tui/tui-winsource.c (tui_update_source_window_as_is)
5730         (tui_update_source_windows_with_addr, tui_erase_source_content):
5731         Update.
5732         (tui_clear_exec_info_content): Remove.
5733
5734 2019-08-13  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5737         declare.
5738         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5739         call tui_erase_exec_info_content.
5740         (tui_clear_exec_info_content): Rename from
5741         tui_erase_exec_info_content.
5742         (tui_clear_exec_info_content): Delete.
5743
5744 2019-08-13  Tom Tromey  <tom@tromey.com>
5745
5746         * tui/tui-winsource.h (struct tui_source_window_base)
5747         <show_exec_info_content>: Declare.
5748         (tui_show_exec_info_content): Don't declare.
5749         * tui/tui-winsource.c
5750         (tui_source_window_base::show_exec_info_content): Rename from
5751         tui_show_exec_info_content.
5752         (tui_source_window_base::update_exec_info): Update.
5753
5754 2019-08-13  Tom Tromey  <tom@tromey.com>
5755
5756         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5757         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5758         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5759         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5760         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5761         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5762         ... here.
5763
5764 2019-08-13  Tom Tromey  <tom@tromey.com>
5765
5766         * tui/tui-winsource.h (struct tui_source_window_base)
5767         <update_exec_info>: Declare.
5768         (tui_update_exec_info): Don't declare.
5769         * tui/tui-winsource.c (tui_update_source_window_as_is)
5770         (tui_source_window_base::refresh_all)
5771         (tui_update_all_breakpoint_info): Update.
5772         (tui_source_window_base::update_exec_info): Rename from
5773         tui_update_exec_info.
5774         * tui/tui-stack.c (tui_show_frame_info): Update.
5775
5776 2019-08-13  Tom Tromey  <tom@tromey.com>
5777
5778         * tui/tui-winsource.h (struct tui_source_window_base)
5779         <set_exec_info_content>: Declare.
5780         (tui_set_exec_info_content): Don't declare.
5781         * tui/tui-winsource.c
5782         (tui_source_window_base::set_exec_info_content): Rename from
5783         tui_set_exec_info_content.
5784         (tui_update_exec_info): Update.
5785
5786 2019-08-13  Tom Tromey  <tom@tromey.com>
5787
5788         * tui/tui-winsource.h (struct tui_source_window_base)
5789         <show_source_content>: Declare.
5790         (tui_show_source_content): Don't declare.
5791         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5792         (tui_source_window_base::show_source_content): Rename from
5793         tui_show_source_content.
5794         (tui_source_window_base::refresh_all): Update.
5795         * tui/tui-layout.c (show_source_disasm_command)
5796         (show_source_or_disasm_and_command): Update.
5797
5798 2019-08-13  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-winsource.c (tui_erase_source_content)
5801         (tui_show_source_content, tui_source_window_base::refresh_all):
5802         Update.
5803         * tui/tui-wingeneral.h
5804         (tui_check_and_display_highlight_if_needed): Don't declare.
5805         * tui/tui-wingeneral.c
5806         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5807         check_and_display_highlight_if_needed.
5808         * tui/tui-win.c (tui_rehighlight_all)
5809         (tui_win_info::make_visible_with_new_height): Update.
5810         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5811         (tui_data_window::erase_data_content)
5812         (tui_data_window::display_all_data): Update.
5813         * tui/tui-data.h (struct tui_win_info)
5814         <check_and_display_highlight_if_needed>: Declare.
5815
5816 2019-08-13  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-win.c (tui_resize_all): Call
5819         tui_delete_invisible_windows.
5820         * tui/tui-layout.c (show_layout): Call
5821         tui_delete_invisible_windows.
5822         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5823         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5824
5825 2019-08-13  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5828         tui_add_win_to_layout.
5829
5830 2019-08-13  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5833         * tui/tui-layout.c (tui_default_win_height): Now static.
5834
5835 2019-08-13  Tom Tromey  <tom@tromey.com>
5836
5837         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5838         single switch.
5839         (show_source_disasm_command, show_source_or_disasm_and_command):
5840         Don't check current layout.
5841
5842 2019-08-13  Tom Tromey  <tom@tromey.com>
5843
5844         * tui/tui-wingeneral.c (make_all_visible): Remove.
5845         (tui_make_all_invisible): Simplify.
5846         * tui/tui-layout.c (tui_make_all_invisible): Move from
5847         tui-wingeneral.c; simplify.
5848         (show_layout): Hoist call to tui_make_all_invisible.
5849         (show_data): Don't call tui_make_all_invisible.
5850
5851 2019-08-13  Tom Tromey  <tom@tromey.com>
5852
5853         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5854         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5855
5856 2019-08-13  Tom Tromey  <tom@tromey.com>
5857
5858         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5859         tui-data.c.
5860         (show_source_disasm_command, show_data)
5861         (show_source_or_disasm_and_command): Don't use
5862         tui_set_current_layout_to.
5863         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5864         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5865         tui-layout.c.
5866         (tui_set_current_layout_to): Remove.
5867
5868 2019-08-13  Tom Tromey  <tom@tromey.com>
5869
5870         * tui/tui-layout.c (tui_set_layout): Update.
5871         * tui/tui-data.h (struct tui_layout_def): Remove.
5872         (tui_layout_def): Don't declare.
5873         * tui/tui-data.c (layout_def): Remove.
5874         (tui_layout_def): Remove.
5875
5876 2019-08-13  Tom Tromey  <tom@tromey.com>
5877
5878         * tui/tui-winsource.h (struct tui_source_window_base)
5879         <clear_detail>: No longer "override".
5880         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5881         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5882         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5883         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5884         Remove.
5885         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5886
5887 2019-08-13  Tom Tromey  <tromey@adacore.com>
5888
5889         * tracepoint.c: Don't include readline.h or history.h.
5890
5891 2019-08-12  Tom Tromey  <tom@tromey.com>
5892
5893         * configure: Rebuild.
5894         * configure.ac: Check for readline 7.
5895         * NEWS: Mention readline 7 requirement.
5896         * README: Update.
5897
5898 2019-08-12  Tom Tromey  <tom@tromey.com>
5899
5900         * mingw-hdep.c (gdb_select): Remove readline hack.
5901
5902 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5903
5904         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5905         when the function fails.
5906
5907 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5908
5909         * s390-tdep.c (s390_type_align): New function.
5910         (s390_gdbarch_init): Set it as type_align gdbarch method.
5911
5912 2019-08-09  Tom de Vries  <tdevries@suse.de>
5913
5914         PR gdb/24591
5915         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5916         pc_low with relocation offset.
5917
5918 2019-08-07  Tom Tromey  <tromey@adacore.com>
5919
5920         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5921         (print_frame_args): Update.
5922         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5923         Update.
5924         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5925         * frame.h (struct frame_arg): Add initializers.
5926         <error>: Now a unique_xmalloc_ptr.
5927
5928 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5929
5930         * NEWS: Expand the Pointer Authentication entry.
5931         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5932         (aarch64_frame_unmask_lr): ... to this.
5933         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5934         Call aarch64_frame_unmask_lr.
5935         * frame.c (struct frame_info): Add "masked" variable.
5936         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5937         (fprint_frame): Check for masked pc.
5938         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5939         declarations.
5940         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5941         * stack.c (print_frame): Check for masked pc.
5942
5943 2019-08-06  Tom Tromey  <tom@tromey.com>
5944
5945         * stabsread.c (patch_block_stabs, read_one_struct_field)
5946         (read_enum_type): Use obstack_strndup.
5947         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5948         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5949         * dwarf2read.c (guess_full_die_structure_name)
5950         (anonymous_struct_prefix): Use obstack_strndup.
5951         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5952         * c-exp.y (yylex): Use obstack_strndup.
5953         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5954         (write_var_or_type): Use obstack_strndup.
5955
5956 2019-08-06  Tom Tromey  <tom@tromey.com>
5957
5958         * symfile.c (reread_symbols): Use obstack_strdup.
5959         * stabsread.c (read_type): Use obstack_strdup.
5960         * gdb_obstack.h (obstack_strdup): New overload.
5961         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5962         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5963         (dwarf2_canonicalize_name): Use obstack_strdup.
5964         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5965         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5966         Use obstack_strdup.
5967
5968 2019-08-06  Tom Tromey  <tom@tromey.com>
5969
5970         * gdb_obstack.h (obstack_strdup): Define.
5971         * gdb_obstack.c (obstack_strdup): Don't define.
5972
5973 2019-08-06  Tom Tromey  <tom@tromey.com>
5974
5975         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5976         obstack_strdup.
5977         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5978         obstack_strdup.
5979         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5980         * stabsread.c (common_block_start): Use obstack_strdup.
5981         * objfiles.c (set_objfile_main_name, objfile): Use
5982         obstack_strdup.
5983         * namespace.c (add_using_directive): Use obstack_strdup.
5984         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5985         * jit.c (finalize_symtab): Use obstack_strdup.
5986         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5987         (guess_partial_die_structure_name, partial_die_info::fixup)
5988         (dwarf2_name): Use obstack_strdup.
5989         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5990         obstack_strdup.
5991         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5992         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5993         obstack_strdup.
5994         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5995
5996 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5997
5998         * unittests/help-doc-selftests.c: New file.
5999         * Makefile.in: Add the new file.
6000
6001 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6002
6003         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6004         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6005         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6006         the trailing '.' is not output, and the first character is uppercased.
6007         (print_help_for_command): Update call to print_doc_line.
6008         (print_doc_of_command): Likewise.
6009         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6010         * cli/cli-option.c (append_indented_doc): Do not append newline.
6011         (build_help_option): Append newline after first appended_indented_doc
6012         only if a second call is done.
6013         (build_help): Append 2 new lines before each option, except the first
6014         one.
6015         * compile/compile.c (_initialize_compile): Add new lines after
6016         %OPTIONS%, when not at the end of the help.
6017         Change help doc or code
6018         producing the help doc to respect the invariants.
6019         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6020         Also removed the new line after 'Options:', as all other commands
6021         do not put an empty line between 'Options:' and the first option.
6022         * printcmd.c (_initialize_printcmd): Likewise.
6023         * stack.c (_initialize_stack): Likewise.
6024         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6025         incorrectly telling COMMAND is optional.
6026         * ada-lang.c (_initialize_ada_language): Change help doc or code
6027         producing the help doc to respect the invariants.
6028         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6029         * breakpoint.c (_initialize_breakpoint): Likewise.
6030         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6031         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6032         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6033         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6034         _initialize_cli_style): Likewise.
6035         * corelow.c (core_target_info): Likewise.
6036         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6037         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6038         * filesystem.c (_initialize_filesystem): Likewise.
6039         * frame.c (_initialize_frame): Likewise.
6040         * gnu-nat.c (add_task_commands): Likewise.
6041         * infcall.c (_initialize_infcall): Likewise.
6042         * infcmd.c (_initialize_infcmd): Likewise.
6043         * interps.c (_initialize_interpreter): Likewise.
6044         * language.c (_initialize_language): Likewise.
6045         * linux-fork.c (_initialize_linux_fork): Likewise.
6046         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6047         * maint.c (_initialize_maint_cmds): Likewise.
6048         * memattr.c (_initialize_mem): Likewise.
6049         * printcmd.c (_initialize_printcmd): Likewise.
6050         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6051         _RegEx): Likewise.
6052         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6053         * record-btrace.c (_initialize_record_btrace): Likewise.
6054         * record-full.c (_initialize_record_full): Likewise.
6055         * record.c (_initialize_record): Likewise.
6056         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6057         * regcache.c (_initialize_regcache): Likewise.
6058         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6059         _initialize_remote): Likewise.
6060         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6061         * serial.c (_initialize_serial): Likewise.
6062         * skip.c (_initialize_step_skip): Likewise.
6063         * source.c (_initialize_source): Likewise.
6064         * stack.c (_initialize_stack): Likewise.
6065         * symfile.c (_initialize_symfile): Likewise.
6066         * symtab.c (_initialize_symtab): Likewise.
6067         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6068         * top.c (init_main): Likewise.
6069         * tracefile-tfile.c (tfile_target_info): Likewise.
6070         * tracepoint.c (_initialize_tracepoint): Likewise.
6071         * tui/tui-win.c (_initialize_tui_win): Likewise.
6072         * utils.c (add_internal_problem_command): Likewise.
6073         * valprint.c (value_print_option_defs): Likewise.
6074
6075 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6076
6077         PR build/24886
6078         * configure.ac: Drop enable-libmcheck support.
6079         * configure, config.in: Rebuild.
6080         * libmcheck.m4: Remove.
6081         * acinclude.m4: Don't include it.
6082         * Makefile.in: Don't distribute it.
6083         * top.c (print_gdb_configuration): Don't mention it.
6084
6085 2019-08-06  Tom Tromey  <tom@tromey.com>
6086
6087         * utils.c (set_output_style): Sometimes pass stream to
6088         emit_style_escape.
6089         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6090         * record-btrace.c (btrace_insn_history): Update.
6091         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6092         method.
6093         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6094         Update initializers.
6095         <m_uiout>: New field.
6096         <m_di>: Move lower.
6097         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6098         Remove "uiout" parameter.
6099         (dump_insns): Update.
6100         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6101         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6102
6103 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6104
6105         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6106         (error_in_psymtab_expansion): Likewise.
6107         (lookup_symbol_via_quick_fns): Likewise.
6108         (basic_lookup_transparent_type_quick): Likewise.
6109         (basic_lookup_transparent_type_1): Likewise.
6110
6111 2019-08-06  Tom Tromey  <tromey@adacore.com>
6112
6113         * source.c (last_source_error): Now bool.
6114         (print_source_lines_base): Make "noprint" bool.  Only open
6115         source file when last_source_visited changes.
6116
6117 2019-08-06  Tom Tromey  <tromey@adacore.com>
6118
6119         * annotate.c (annotate_source_line): Use g_source_cache.
6120         * source-cache.c (source_cache::get_plain_source_lines): Change
6121         parameters.  Populate m_offset_cache.
6122         (source_cache::ensure): New method.
6123         (source_cache::get_line_charpos): New method.
6124         (extract_lines): Move lower.  Change parameters.
6125         (source_cache::get_source_lines): Move lower.
6126         * source-cache.h (class source_cache): Update comment.
6127         <get_line_charpos>: New method.
6128         <get_source_lines>: Update comment.
6129         <clear>: Clear m_offset_cache.
6130         <get_plain_source_lines>: Change parameters.
6131         <ensure>: New method
6132         <m_offset_cache>: New member.
6133         * source.c (forget_cached_source_info_for_objfile): Update.
6134         (info_source_command): Use g_source_cache.
6135         (find_source_lines, open_source_file_with_line_charpos): Remove.
6136         (print_source_lines_base, search_command_helper): Use g_source_cache.
6137         * source.h (open_source_file_with_line_charpos): Don't declare.
6138         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6139         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6140         Use g_source_cache.
6141
6142 2019-08-06  Tom Tromey  <tromey@adacore.com>
6143
6144         * source-cache.c (source_cache::get_plain_source_lines):
6145         Remove "first_line" and "last_line" parameters.
6146         (source_cache::get_source_lines): Cache plain text.
6147         * source-cache.h (class source_cache)
6148         <get_plain_source_lines>: Update.
6149
6150 2019-08-06  Tom Tromey  <tromey@adacore.com>
6151
6152         * source-cache.c (extract_lines): No longer a method.
6153         Changed type of parameter.  Include final newline.
6154         (selftests::extract_lines_test): New function.
6155         (_initialize_source_cache): Likewise.
6156         * source-cache.h (class source_cache)
6157         <extract_lines>: Don't declare.
6158
6159 2019-08-06  Tom Tromey  <tromey@adacore.com>
6160
6161         * breakpoint.c (init_breakpoint_sal): Update.
6162         (breakpoint): Update.
6163         * breakpoint.h (struct breakpoint) <filter>: Now a
6164         unique_xmalloc_ptr.
6165
6166 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6167
6168         * NEWS: Mention dictionary access on blocks.
6169         * python/py-block.c (blpy_getitem): New function.
6170         (block_object_as_mapping): New struct.
6171         (block_object_type): Use new struct for tp_as_mapping field.
6172
6173 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6174
6175         * objfiles.h (objfile): Add a comment describing partial symbols.
6176
6177 2019-08-05  Tom Tromey  <tromey@adacore.com>
6178
6179         * compile/compile.c (_initialize_compile): Use _(), not N_().
6180         * thread.c (_initialize_thread): Use _(), not N_().
6181         * stack.c (_initialize_stack): Use _(), not N_().
6182         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6183
6184 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6185
6186         * dwarf2read.c (struct dw2_symtab_iterator):
6187         <want_specific_block>: Remove.
6188         <block_index>: Change type to gdb::optional.
6189         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6190         change type of BLOCK_INDEX parameter to gdb::optional.
6191         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6192         (dw2_lookup_symbol): Don't pass argument for
6193         WANT_SPECIFIC_BLOCK.
6194         (dw2_expand_symtabs_for_function): Don't pass argument for
6195         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6196         (class dw2_debug_names_iterator)
6197         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6198         parameter, change BLOCK_INDEX type to gdb::optional.
6199         <m_want_specific_block>: Remove.
6200         <m_block_index>: Change type to gdb::optional.
6201         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6202         gdb::optional.  Re-write in function of gdb::optional.
6203         (dw2_debug_names_lookup_symbol): Don't pass argument for
6204         WANT_SPECIFIC_BLOCK.
6205         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6206         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6207         BLOCK_INDEX.
6208
6209 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6210
6211         * NEWS: Mention changes to "info sources" command.
6212
6213 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6214
6215         * symtab.c (filename_partial_match_opts): New struct type.
6216         (struct output_source_filename_data): New members
6217         regexp, c_regexp, partial_match.
6218         (output_source_filename): Use new members to decide to print file.
6219         (info_sources_option_defs): New variable.
6220         (make_info_sources_options_def_group, print_info_sources_header,
6221         info_sources_command_completer):
6222         New functions.
6223         (info_sources_command): Read new optional arguments.
6224         (_initialize_symtab): Update info sources help.
6225
6226 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6227
6228         * ada-lang.c (exception_support_info_v0): Renamed from...
6229         (default_exception_support_info): ... this.  Create new
6230         definition for v1.
6231         (ada_has_this_exception_support): Look up catch_handlers_sym.
6232         (ada_exception_support_info_sniffer): Try v0 after default.
6233
6234 2019-08-01  Tom Tromey  <tromey@adacore.com>
6235
6236         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6237         gdbarch.h.
6238
6239 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6240
6241         * s12z-tdep.c: Fix include path for s12z-opc.h.
6242
6243 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6244
6245         * NEWS: Require GNU make 3.82.
6246
6247 2019-07-16  Tom Tromey  <tom@tromey.com>
6248
6249         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6250         declare.
6251
6252 2019-07-30  Tom Tromey  <tromey@adacore.com>
6253
6254         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6255
6256 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6257
6258         * printcmd.c (print_address_symbolic): Print negative offsets.
6259         (build_address_symbolic): Force signed arithmetic when computing
6260         offset.
6261
6262 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6263
6264         PR/24474: Add a function to lookup static variables.
6265         * NEWS: Mention this new function.
6266         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6267         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6268         * python/python.c (python_GdbMethods): Add new function.
6269
6270 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6271
6272         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6273         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6274         (objfpy_lookup_static_symbol): New function.
6275         (objfile_object_methods): Add new functions.
6276
6277 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6278
6279         * NEWS: Mention 'set|show print frame-info'.  Mention new
6280         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6281         backtrace argument.  Mention that python frame filtering code
6282         is now consistent with what 'backtrace' command prints.
6283
6284 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285
6286         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6287         comments.
6288         (print_frame_info_auto, print_frame_info_source_line,
6289         print_frame_info_location, print_frame_info_source_and_location,
6290         print_frame_info_location_and_address, print_frame_info_short_location):
6291         New declarations.
6292         (struct frame_print_options): New member print_frame_info.
6293         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6294         * stack.h (get_user_print_what_frame_info): New declaration.
6295         (frame_show_address): New declaration.
6296         * stack.c (print_frame_arguments_choices): New value 'presence'.
6297         (print_frame_info_auto, print_frame_info_source_line,
6298         print_frame_info_location, print_frame_info_source_and_location,
6299         print_frame_info_location_and_address, print_frame_info_short_location,
6300         print_frame_info_choices, print_frame_info_print_what): New definitions.
6301         (print_frame_args): Only print dots for args if print frame-arguments
6302         is 'presence'.
6303         (frame_print_option_defs): New element for "frame-info".
6304         (get_user_print_what_frame_info): New function.
6305         (frame_show_address): Make non static.  Move comment to stack.h.
6306         (print_frame_info_to_print_what): New function.
6307         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6308         to decide what to print.
6309         (backtrace_command_1): Handle the new print_frame_arguments_presence
6310         value.
6311         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6312         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6313         (py_print_frame): In non-mi mode, use LOCATION as default for
6314         print_what, similarly to frame information printed directly by
6315         backtrace command. Handle frame-info user option in non MI mode.
6316
6317 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6318
6319         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6320         Add case for debugging 32-bit target on 64-bit host.  Revise
6321         comment.
6322
6323 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6324
6325         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6326         instead of find_function_entry_range_from_pc.
6327
6328 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6329
6330         * stack.c (find_frame_funname): Remove code which preferred
6331         minsym over symtab sym in "certain pathological cases".
6332
6333         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6334         parameter.  Change type of "do_demangle" to bool.
6335         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6336         Pass suitable "prefer_sym_over_minsym" flag to
6337         build_address_symbolic().  Don't output "+" for negative offsets.
6338         * printcmd.c (print_address_symbolic): Update invocation of
6339         build_address_symbolic to include a "prefer_sym_over_minsym"
6340         flag.
6341         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6342         Restrict cases in which use of minimal symbol is preferred to that
6343         of a found symbol.  Update comments.
6344
6345         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6346         for entry pc when entry pc is out of range for that FDE.
6347
6348 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6349
6350         PR gdb/24839:
6351         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6352         type.
6353
6354 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6355
6356         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6357         this function's Python signature.
6358
6359
6360 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6361
6362         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6363         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6364         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6365         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6366         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6367
6368
6369 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6370
6371         * h8300-tdep.c (h8300_register_name_common): New.
6372         h8300_register_name): Use h8300_register_name_common.
6373         (h8300s_register_name): Likewise.
6374         (h8300sx_register_name): Likewise.
6375         (h8300h_register_nam): New.
6376         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6377
6378
6379 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6380
6381         * arm-tdep.c (arm_skip_cmse_entry): New function.
6382         (arm_is_sgstubs_section): New function.
6383         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6384
6385 2019-07-22  Tom Tromey  <tom@tromey.com>
6386
6387         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6388         Don't self-assign.
6389
6390 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6391
6392         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6393         type_print.
6394
6395 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6398         so that GDB doesn't match any msymbols when searching in the
6399         TYPES_DOMAIN.
6400         (print_symbol_info): Print using typedef_print or type_print based
6401         on the type of the symbol.  Add updated FIXME comment moved from...
6402         (_initialize_symtab): ... move and update FIXME comment to above.
6403
6404 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * NEWS: Mention adding -q option to "info types".
6407         * symtab.c (struct info_types_options): New struct.
6408         (info_types_options_defs): New variable.
6409         (make_info_types_options_def_group): New function.
6410         (info_types_command): Use gdb::option framework to parse options.
6411         (info_types_command_completer): New function.
6412         (_initialize_symtab): Extend the help text on "info types" and
6413         register command completer.
6414
6415 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6416
6417         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6418         (lookup_symbol_in_objfile): Change int to block_enum and add a
6419         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6420
6421 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6422
6423         * MAINTAINERS (Write After Approval): Add self.
6424
6425 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6426
6427         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6428         instruction to the dummy code region.
6429
6430 2019-07-19  Tom Tromey  <tromey@adacore.com>
6431
6432         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6433         (ARGSUSED, PARAMS, __func__): Remove rules.
6434
6435 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6436
6437         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6438         * features/arm/arm-with-iwmmxt.c: Remove.
6439         * features/arm/arm-with-iwmmxt.xml: Remove.
6440         * features/arm/arm-with-m-fpa-layout.c: Remove.
6441         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6442         * features/arm/arm-with-m-vfp-d16.c: Remove.
6443         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6444         * features/arm/arm-with-m.c: Remove.
6445         * features/arm/arm-with-m.xml: Remove.
6446         * features/arm/arm-with-neon.c: Remove.
6447         * features/arm/arm-with-neon.xml: Remove.
6448         * features/arm/arm-with-vfpv2.c: Remove.
6449         * features/arm/arm-with-vfpv2.xml: Remove.
6450         * features/arm/arm-with-vfpv3.c: Remove.
6451         * features/arm/arm-with-vfpv3.xml: Remove.
6452
6453 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6454
6455         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6456
6457 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6458
6459         * arch/aarch32.c (aarch32_create_target_description): Create
6460         target descriptions using features.
6461         * arch/arm.c (arm_create_target_description)
6462         (arm_create_mprofile_target_description): Likewise.
6463         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6464
6465 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6466
6467         * Makefile.in: Add new files.
6468         * aarch32-tdep.c: New file.
6469         * aarch32-tdep.h: New file.
6470         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6471         Call aarch32_read_description.
6472         * arch/aarch32.c: New file.
6473         * arch/aarch32.h: New file.
6474         * arch/arm.c (arm_create_target_description)
6475         (arm_create_mprofile_target_description): New function.
6476         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6477         (arm_create_target_description)
6478         (arm_create_mprofile_target_description): New declaration.
6479         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6480         read_description functions.
6481         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6482         Likewise.
6483         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6484         * arm-tdep.c (tdesc_arm_list): New variable.
6485         (arm_register_g_packet_guesses): Call create description functions.
6486         (arm_read_description) (arm_read_mprofile_description): New
6487         function.
6488         * arm-tdep.h (arm_read_description)
6489         (arm_read_mprofile_description): Add declaration.
6490         * configure.tgt: Add new files.
6491
6492 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6493
6494         * top.c (new_ui_command): Open specified terminal just once.
6495
6496 2019-07-18  Tom Tromey  <tromey@adacore.com>
6497
6498         * symtab.c (main_name): Constify return type.
6499         * symfile.c (set_initial_language): Update.
6500         * symtab.h (main_name): Constify return type.
6501
6502 2019-07-17  Tom Tromey  <tom@tromey.com>
6503
6504         * tui/tui-winsource.c (tui_update_source_window)
6505         (tui_update_source_window_as_is)
6506         (tui_update_source_windows_with_line): Remove return.
6507         * tui/tui-disasm.c (tui_show_disassem)
6508         (tui_show_disassem_and_update_source): Remove return.
6509         * tui/tui.c (tui_reset): Remove return.
6510         * tui/tui-wingeneral.c
6511         (tui_check_and_display_highlight_if_needed): Remove return.
6512
6513 2019-07-17  Tom Tromey  <tom@tromey.com>
6514
6515         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6516
6517 2019-07-17  Tom Tromey  <tom@tromey.com>
6518
6519         * tui/tui-winsource.h (struct tui_exec_info_window)
6520         (struct tui_source_window_base): Move from tui-data.h.
6521         * tui/tui-winsource.c: Move many method definitions from
6522         elsewhere.  Remove "structuring" comments.
6523         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6524         (tui_source_window_base::refresh_window): Move to
6525         tui-winsource.c.
6526         * tui/tui-win.c (tui_source_window_base::refresh_all)
6527         (tui_source_window_base::update_tab_width)
6528         (tui_source_window_base::set_new_height)
6529         (tui_source_window_base::do_make_visible_with_new_height): Move to
6530         tui-winsource.c.
6531         * tui/tui-source.h: Update.
6532         * tui/tui-source.c (tui_source_window_base::reset): Move to
6533         tui-winsource.c.
6534         * tui/tui-disasm.h: Update.
6535         * tui/tui-data.h (struct tui_exec_info_window): Move to
6536         tui-winsource.h.
6537         (struct tui_source_window_base): Likewise.
6538         * tui/tui-data.c (tui_source_window_base::clear_detail)
6539         (tui_source_window_base, ~tui_source_window_base): Move to
6540         tui-winsource.c.
6541
6542 2019-07-17  Tom Tromey  <tom@tromey.com>
6543
6544         * tui/tui-win.c (tui_resize_all)
6545         (tui_source_window_base::update_tab_width)
6546         (tui_adjust_win_heights): Update.
6547         (tui_win_info::make_invisible_and_set_new_height): Rename from
6548         make_invisible_and_set_new_height.
6549         * tui/tui-data.h (struct tui_win_info)
6550         <make_invisible_and_set_new_height>: New method.
6551
6552 2019-07-17  Tom Tromey  <tom@tromey.com>
6553
6554         * tui/tui.c: Update.
6555         * tui/tui-source.h (struct tui_source_window): Move from
6556         tui-data.h.
6557         * tui/tui-layout.c: Update.
6558         * tui/tui-disasm.c: Update.
6559         * tui/tui-data.h (struct tui_source_window): Move to
6560         tui-source.h.
6561
6562 2019-07-17  Tom Tromey  <tom@tromey.com>
6563
6564         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6565         tui-data.h.
6566         * tui/tui-data.h (struct tui_disasm_window): Move to
6567         tui-disasm.h.
6568
6569 2019-07-17  Tom Tromey  <tom@tromey.com>
6570
6571         * tui/tui-regs.h (struct tui_data_item_window): Move from
6572         tui-data.h.
6573         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6574         * tui/tui-data.h (struct tui_data_item_window): Move to
6575         tui-regs.h.
6576         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6577
6578 2019-07-17  Tom Tromey  <tom@tromey.com>
6579
6580         * tui/tui.c: Update.
6581         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6582         (tui_cmd_window::max_height): Move to tui-command.c.
6583         * tui/tui-layout.c: Update.
6584         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6585         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6586         tui-command.c.
6587         * tui/tui-command.h (struct tui_cmd_window): Move from
6588         tui-data.h.
6589         * tui/tui-command.c: Remove "structuring" comments.
6590         (tui_cmd_window::clear_detail)
6591         (tui_cmd_window::do_make_visible_with_new_height)
6592         (tui_cmd_window::max_height): Move from elsewhere.
6593
6594 2019-07-17  Tom Tromey  <tom@tromey.com>
6595
6596         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6597         Now static.
6598         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6599         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6600
6601 2019-07-17  Tom Tromey  <tom@tromey.com>
6602
6603         * tui/tui.c: Update.
6604         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6605         tui-regs.c.
6606         * tui/tui-windata.h: Remove file.
6607         * tui/tui-windata.c: Remove file.
6608         * tui/tui-win.c (tui_data_window::set_new_height)
6609         (tui_data_window::do_make_visible_with_new_height): Move to
6610         tui-regs.c.
6611         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6612         * tui/tui-regs.c: Remove "structuring" comments.
6613         (tui_data_window::first_data_item_displayed)
6614         (tui_data_window::delete_data_content_windows)
6615         (tui_data_window::erase_data_content)
6616         (tui_data_window::display_all_data)
6617         (tui_data_window::refresh_all)
6618         (tui_data_window::do_scroll_vertical)
6619         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6620         (tui_data_window::do_make_visible_with_new_height)
6621         (tui_data_window::refresh_window): Move from elsewhere.
6622         (_initialize_tui_regs): Move to end of file.
6623         * tui/tui-layout.c: Update.
6624         * tui/tui-hooks.c: Update.
6625         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6626         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6627         tui-regs.c.
6628         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6629
6630 2019-07-17  Tom Tromey  <tom@tromey.com>
6631
6632         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6633         seen.
6634
6635 2019-07-17  Tom Tromey  <tom@tromey.com>
6636
6637         * tui/tui-win.c (tui_source_window_base::set_new_height)
6638         (tui_source_window_base::do_make_visible_with_new_height): Use
6639         m_has_locator field directly.
6640         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6641         method.
6642         (struct tui_source_window_base) <has_locator>: Likewise.
6643
6644 2019-07-17  Tom Tromey  <tom@tromey.com>
6645
6646         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6647         Don't declare.
6648         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6649         Remove.
6650         * tui/tui-win.c (tui_source_window_base::set_new_height)
6651         (tui_source_window_base::set_new_height)
6652         (make_invisible_and_set_new_height)
6653         (tui_source_window_base::do_make_visible_with_new_height)
6654         (tui_source_window_base::do_make_visible_with_new_height):
6655         Update.
6656         * tui/tui-layout.c (show_source_disasm_command, show_data)
6657         (show_source_or_disasm_and_command): Update.
6658         * tui/tui-layout.c (show_layout): Update.
6659
6660 2019-07-17  Tom Tromey  <tom@tromey.com>
6661
6662         * tui/tui-layout.c (make_data_window): Remove.
6663         (show_data): Unify creation and re-initialization cases.
6664
6665 2019-07-17  Tom Tromey  <tom@tromey.com>
6666
6667         * tui/tui-layout.c (make_source_window, make_disasm_window):
6668         Remove.
6669         (show_data): Unify creation and re-initialization cases.
6670
6671 2019-07-17  Tom Tromey  <tom@tromey.com>
6672
6673         * tui/tui-layout.c (make_command_window): Remove.
6674         (show_source_disasm_command, show_source_or_disasm_and_command):
6675         Unify creation and re-initialization cases.
6676
6677 2019-07-17  Tom Tromey  <tom@tromey.com>
6678
6679         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6680         creation and re-initialization cases.
6681
6682 2019-07-17  Tom Tromey  <tom@tromey.com>
6683
6684         * tui/tui-regs.c (tui_get_register): Return void.
6685
6686 2019-07-17  Tom Tromey  <tom@tromey.com>
6687
6688         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6689         Simplify.
6690
6691 2019-07-17  Tom Tromey  <tom@tromey.com>
6692
6693         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6694         resetting.
6695
6696 2019-07-17  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6699         * tui/tui-regs.c (tui_reg_layout): New function.
6700         (tui_show_registers, tui_reg_command): Use it.
6701         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6702         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6703         parameters.
6704         (tui_layout_command): Remove.
6705
6706 2019-07-17  Tom Tromey  <tom@tromey.com>
6707
6708         * tui/tui-layout.h (tui/tui-layout): Return void.
6709         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6710
6711 2019-07-17  Tom Tromey  <tom@tromey.com>
6712
6713         * tui/tui-layout.c (show_source_disasm_command, show_data):
6714         Update.
6715         (reset_locator): Remove.
6716         (show_source_or_disasm_and_command): Update.
6717
6718 2019-07-17  Tom Tromey  <tom@tromey.com>
6719
6720         * tui/tui-source.c (tui_source_window_base::reset): Remove
6721         win_type parameter.
6722         * tui/tui-layout.c (make_command_window, make_source_window)
6723         (make_disasm_window, make_data_window)
6724         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6725         (reset_locator, show_source_or_disasm_and_command): Update.
6726         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6727         win_type parameter.
6728         (struct tui_source_window_base) <reset>: Likewise.
6729
6730 2019-07-17  Tom Tromey  <tom@tromey.com>
6731
6732         * tui/tui-layout.c (show_source_disasm_command): Use
6733         reset_locator.
6734         (reset_locator): New function.
6735         (init_and_make_win): Remove.
6736         (show_source_or_disasm_and_command): Use reset_locator.
6737
6738 2019-07-17  Tom Tromey  <tom@tromey.com>
6739
6740         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6741         condition.
6742         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6743         Remove condition.
6744         * tui/tui-source.c (tui_source_window_base::reset): New method.
6745         * tui/tui-layout.c (make_command_window): Don't call
6746         init_and_make_win.
6747         (make_source_window, make_disasm_window): Don't call
6748         make_source_or_disasm_window.
6749         (make_data_window): Don't call init_and_make_win.  Change calling
6750         convention.
6751         (show_source_disasm_command, show_data): Simplify.
6752         (make_source_or_disasm_window): Remove.
6753         (show_source_or_disasm_and_command): Simplify.
6754         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6755         (struct tui_source_window_base) <reset>: Likewise.
6756         <execution_info>: Remove initializer.
6757         * tui/tui-data.c (tui_source_window_base): Initialize
6758         execution_info.
6759
6760 2019-07-17  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6763         variable.
6764
6765 2019-07-17  Tom Tromey  <tom@tromey.com>
6766
6767         * tui/tui.c (tui_rl_other_window): Update.
6768         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6769         superclass method first.  Always iterate over regs_content.
6770         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6771         method.
6772         * tui/tui-win.c (tui_set_focus_command): Update.
6773
6774 2019-07-17  Tom Tromey  <tom@tromey.com>
6775
6776         * tui/tui-win.c (tui_set_focus_command): Rename from
6777         tui_set_focus.  Call tui_enable.
6778         (tui_set_focus_command): Remove.
6779
6780 2019-07-17  Tom Tromey  <tom@tromey.com>
6781
6782         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6783         refresh_window.
6784         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6785         touchwin.
6786         (tui_data_window::refresh_window): Call refresh_window on data
6787         items.  Always call superclass refresh_window.
6788         (tui_win_info::refresh): Remove.
6789         (tui_source_window_base::refresh_window): Update.
6790         (tui_refresh_all): Update.
6791         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6792         refresh_window.
6793         (show_source_or_disasm_and_command): Likewise.
6794         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6795         (struct tui_source_window_base) <refresh>: Likewise.
6796
6797 2019-07-17  Tom Tromey  <tom@tromey.com>
6798
6799         * tui/tui-winsource.c (tui_clear_source_content)
6800         (tui_show_source_content): Update.
6801         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6802         whether content is empty.
6803         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6804         Remove.
6805
6806 2019-07-17  Tom Tromey  <tom@tromey.com>
6807
6808         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6809         window's contents.
6810         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6811         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6812
6813 2019-07-17  Tom Tromey  <tom@tromey.com>
6814
6815         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6816         (struct tui_data_item_window): Update.
6817
6818 2019-07-17  Tom Tromey  <tom@tromey.com>
6819
6820         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6821         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6822         defines.
6823
6824 2019-07-17  Tom Tromey  <tom@tromey.com>
6825
6826         * tui/tui-winsource.h (tui_erase_source_content)
6827         (tui_clear_source_content): Remove "display_prompt" parameter.
6828         * tui/tui-winsource.c (tui_update_source_window_as_is)
6829         (tui_update_source_windows_with_addr): Update.
6830         (tui_clear_source_content): Remove "display_prompt" parameter.
6831         (tui_erase_source_content): Likewise.  Simplify.
6832         (tui_show_source_content): Update.
6833         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6834         * tui/tui-stack.c (tui_show_frame_info): Update.
6835         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6836         Remove defines.
6837
6838 2019-07-17  Tom Tromey  <tom@tromey.com>
6839
6840         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6841         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6842         parameter.
6843         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6844         parameter.
6845
6846 2019-07-17  Tom Tromey  <tom@tromey.com>
6847
6848         * tui/tui-winsource.c (tui_clear_source_content)
6849         (tui_show_source_content, tui_show_exec_info_content)
6850         (tui_clear_exec_info_content): Update.
6851         * tui/tui-stack.c (tui_show_locator_content): Update.
6852         (tui_show_frame_info): Update.
6853         * tui/tui-source.h (tui_source_window): Don't declare.
6854         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6855         from tui_source_is_displayed.
6856         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6857         Remove field.
6858         (struct tui_source_window_base) <content_in_use>: New field.  Now
6859         bool.
6860         (struct tui_source_window) <showing_source_p>: New method.
6861         (TUI_SRC_WIN): Change cast.
6862         * tui/tui-data.c (tui_initialize_static_data): Update.
6863
6864 2019-07-17  Tom Tromey  <tom@tromey.com>
6865
6866         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6867         location_matches_p.
6868         * tui/tui-source.c (tui_source_window::location_matches_p): New
6869         method.
6870         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6871         method.
6872         * tui/tui-data.h (struct tui_source_window_base)
6873         <location_matches_p>: New method.
6874         (struct tui_source_window, struct tui_disasm_window)
6875         <location_matches_p>: Likewise.
6876
6877 2019-07-17  Tom Tromey  <tom@tromey.com>
6878
6879         * tui/tui-win.c (tui_set_win_height_command): Rename from
6880         tui_set_win_height.
6881         (tui_set_win_height_command): Remove.
6882
6883 2019-07-17  Tom Tromey  <tom@tromey.com>
6884
6885         * tui/tui-source.c (tui_source_window): New constructor.  Add
6886         observer.
6887         (~tui_source_window): New destructor.
6888         (tui_source_window::style_changed): New method.
6889         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6890         (tui_attach_detach_observers): Update.
6891         * tui/tui-data.h (struct tui_source_window): Make constructor not
6892         inline.  Add destructor.
6893         (struct tui_source_window) <style_changed>: New method.
6894         <m_observable>: New member.
6895
6896 2019-07-17  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6899         * tui/tui-win.c (tui_resize_all): Fix typo.
6900
6901 2019-07-17  Tom Tromey  <tom@tromey.com>
6902
6903         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6904         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6905         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6906         * tui/tui-win.c (window_name_completer): Use foreach.
6907         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6908         (update_tab_width): Likewise.
6909         * tui/tui-layout.c (show_layout): Update.
6910         * tui/tui-data.h (class tui_window_iterator): New.
6911         (struct all_tui_windows): New.
6912         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6913
6914 2019-07-17  Tom Tromey  <tom@tromey.com>
6915
6916         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6917         parameter.  Don't reference globals.
6918         (tui_reg_command): Update.
6919
6920 2019-07-17  Tom Tromey  <tom@tromey.com>
6921
6922         * tui/tui-regs.c (tui_show_registers): Simplify.
6923
6924 2019-07-17  Tom Tromey  <tom@tromey.com>
6925
6926         * tui/tui-regs.c (tui_show_registers): Update.
6927         (tui_show_register_group): Add win_info parameter.
6928
6929 2019-07-17  Tom Tromey  <tom@tromey.com>
6930
6931         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6932         Rename from tui_display_reg_element_at_line.
6933         (tui_data_window::display_registers_from_line): Update.
6934         * tui/tui-data.h (struct tui_data_window)
6935         <display_reg_element_at_line>: New method.
6936
6937 2019-07-17  Tom Tromey  <tom@tromey.com>
6938
6939         * tui/tui-regs.h (tui_display_registers_from)
6940         (tui_display_registers_from_line): Don't declare.
6941         * tui/tui-windata.c (tui_data_window::display_all_data)
6942         (tui_data_window::refresh_all)
6943         (tui_data_window::do_scroll_vertical): Update.
6944         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6945         from tui_display_registers_from.
6946         (tui_display_reg_element_at_line): Update.
6947         (tui_data_window::display_registers_from_line): Rename from
6948         tui_display_registers_from_line.
6949         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6950         display_registers_from_line>: New methods.
6951
6952 2019-07-17  Tom Tromey  <tom@tromey.com>
6953
6954         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6955         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6956         from tui_erase_data_content.
6957         (tui_data_window::display_all_data)
6958         (tui_data_window::refresh_all)
6959         (tui_data_window::do_scroll_vertical): Update.
6960         * tui/tui-regs.c (tui_show_registers): Update.
6961         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6962         New method.
6963
6964 2019-07-17  Tom Tromey  <tom@tromey.com>
6965
6966         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6967         declare.
6968         * tui/tui-windata.c
6969         (tui_data_window::delete_data_content_windows): Rename from
6970         tui_delete_data_content_windows.
6971         (tui_data_window::display_all_data)
6972         (tui_data_window::do_scroll_vertical): Update.
6973         * tui/tui-data.h (struct tui_data_window)
6974         <delete_data_content_windows>: New method.
6975
6976 2019-07-17  Tom Tromey  <tom@tromey.com>
6977
6978         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6979         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6980
6981 2019-07-17  Tom Tromey  <tom@tromey.com>
6982
6983         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6984         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6985         from tui_display_all_data.
6986         * tui/tui-win.c
6987         (tui_data_window::do_make_visible_with_new_height): Update.
6988         * tui/tui-regs.c (tui_show_registers): Update.
6989         * tui/tui-layout.c (tui_set_layout): Update.
6990         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6991         method.
6992
6993 2019-07-17  Tom Tromey  <tom@tromey.com>
6994
6995         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6996         * tui/tui-windata.c (tui_display_data_from): Remove.
6997         (tui_data_window::refresh_all): Update.
6998
6999 2019-07-17  Tom Tromey  <tom@tromey.com>
7000
7001         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7002         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7003         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7004         tui_display_registers_from_line.
7005         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7006         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7007         "force_display" parameter.
7008
7009 2019-07-17  Tom Tromey  <tom@tromey.com>
7010
7011         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7012         declare.
7013         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7014         Rename from tui_first_reg_element_no_inline.
7015         (tui_display_reg_element_at_line)
7016         (tui_display_registers_from_line): Update.
7017         * tui/tui-data.h (struct tui_data_window)
7018         <first_reg_element_no_inline>: New method.
7019
7020 2019-07-17  Tom Tromey  <tom@tromey.com>
7021
7022         * tui/tui-windata.c (tui_display_data_from)
7023         (tui_data_window::do_scroll_vertical): Update.
7024         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7025         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7026         Rename from tui_line_from_reg_element_no.
7027         (tui_display_registers_from_line): Update.
7028         * tui/tui-data.h (struct tui_data_window)
7029         <line_from_reg_element_no>: New method.
7030
7031 2019-07-17  Tom Tromey  <tom@tromey.com>
7032
7033         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7034         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7035         tui_last_regs_line_no.
7036         (tui_display_reg_element_at_line)
7037         (tui_display_registers_from_line): Update.
7038         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7039         method.
7040
7041 2019-07-17  Tom Tromey  <tom@tromey.com>
7042
7043         PR tui/24722:
7044         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7045         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7046         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7047         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7048         (tui_update_breakpoint_info): Likewise.
7049         * tui/tui-hooks.c (tui_event_create_breakpoint)
7050         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7051         Update.
7052
7053 2019-07-17  Tom Tromey  <tom@tromey.com>
7054
7055         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7056
7057 2019-07-17  Tom Tromey  <tom@tromey.com>
7058
7059         * tui/tui-winsource.c (tui_update_source_window_as_is)
7060         (tui_update_source_windows_with_addr): Update.
7061         * tui/tui-source.h (tui_set_source_content)
7062         (tui_show_symtab_source): Add "win_info" parameter.
7063         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7064         parameter.
7065         (tui_show_symtab_source): Likewise.
7066
7067 2019-07-17  Tom Tromey  <tom@tromey.com>
7068
7069         * tui/tui-wingeneral.c
7070         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7071
7072 2019-07-17  Tom Tromey  <tom@tromey.com>
7073
7074         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7075         (struct tui_cmd_window) <can_scroll>: New method.
7076         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7077         method.
7078
7079 2019-07-17  Tom Tromey  <tromey@adacore.com>
7080
7081         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7082         do_field_signed>: Rename.  Change type of "value".
7083         * ui-out.c (ui_out::field_signed): Rename from field_int.
7084         Change type of "value".
7085         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7086         type of "value".
7087         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7088         do_field_int.  Change type of "value".
7089         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7090         do_field_int.  Change type of "value".
7091         * tracepoint.c (trace_status_mi, tfind_1)
7092         (print_one_static_tracepoint_marker): Update.
7093         * thread.c (print_thread_info_1, print_selected_thread_frame):
7094         Update.
7095         * stack.c (print_frame, print_frame_info): Update.
7096         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7097         Update.
7098         * source.c (print_source_lines_base): Update.
7099         * skip.c (info_skip_command): Update.
7100         * record-btrace.c (btrace_ui_out_decode_error)
7101         (btrace_call_history_src_line): Update.
7102         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7103         Update.
7104         * progspace.c (print_program_space): Update.
7105         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7106         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7107         do_field_int.  Change type of "value".
7108         * mi/mi-out.c (mi_ui_out::do_table_begin)
7109         (mi_ui_out::do_table_header): Update.
7110         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7111         type of "value".
7112         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7113         (mi_cmd_data_list_changed_registers, output_register)
7114         (mi_cmd_data_read_memory, mi_load_progress)
7115         (mi_cmd_trace_frame_collected): Update.
7116         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7117         Update.
7118         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7119         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7120         (mi_cmd_var_list_children, varobj_update_one): Update.
7121         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7122         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7123         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7124         * inferior.c (print_inferior): Update.
7125         * gdb_bfd.c (print_one_bfd): Update.
7126         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7127         Update.
7128         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7129         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7130         do_field_int.  Change type of "value".
7131         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7132         do_field_int.  Change type of "value".
7133         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7134         (print_one_breakpoint_location, print_it_catch_fork)
7135         (print_one_catch_fork, print_it_catch_vfork)
7136         (print_one_catch_vfork, print_it_catch_solib)
7137         (print_it_catch_exec, print_it_ranged_breakpoint)
7138         (print_mention_watchpoint, print_mention_masked_watchpoint)
7139         (bkpt_print_it, update_static_tracepoint): Update.
7140         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7141         * break-catch-syscall.c (print_it_catch_syscall): Update.
7142         * ada-tasks.c (print_ada_task_info): Update.
7143         * ada-lang.c (print_it_exception, print_mention_exception):
7144         Update.
7145
7146 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         PR breakpoints/24541
7149         * gdbarch.c: Regenerate.
7150         * gdbarch.h: Regenerate.
7151         * gdbarch.sh: Adjust return type and parameter types for
7152         'stap_adjust_register'.
7153         (i386_stap_adjust_register): Adjust signature and return new
7154         register name.
7155         * stap-probe.c (stap_parse_register_operand): Adjust use of
7156         'gdbarch_stap_adjust_register'.
7157
7158 2019-07-17  Tom Tromey  <tromey@adacore.com>
7159
7160         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7161         declare VEC.
7162         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7163         std::vector.
7164         (struct s390_process_info): Add initializers.
7165         (s390_add_process): Use new.
7166         (s390_linux_nat_target::low_forget_process): Use delete.
7167         (s390_linux_nat_target::low_new_fork)
7168         (s390_linux_nat_target::stopped_by_watchpoint)
7169         (s390_linux_nat_target::low_prepare_to_resume)
7170         (s390_linux_nat_target::insert_watchpoint)
7171         (s390_linux_nat_target::insert_hw_breakpoint)
7172         (s390_linux_nat_target::remove_watchpoint)
7173         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7174
7175 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7176
7177         * aarch64-fbsd-nat.c: Include regcache.h.
7178         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7179         argument.
7180         (aarch64_fbsd_nat_target::fetch_registers)
7181         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7182         variable.
7183         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7184
7185 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7186
7187         * fbsd-nat.c: Include gdbarch.h.
7188
7189 2019-07-15  Tom Tromey  <tromey@adacore.com>
7190
7191         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7192
7193 2019-07-15  Tom Tromey  <tromey@adacore.com>
7194
7195         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7196         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7197         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7198         * cli-out.c (cli_ui_out::do_field_int): New method.
7199         * ui-out.c (ui_out::field_unsigned): New method.
7200         * symfile.c (generic_load): Use field_unsigned.
7201         (print_transfer_performance): Likewise.
7202         * record-btrace.c (ui_out_field_uint): Remove.
7203         (btrace_call_history_insn_range, btrace_call_history): Use
7204         field_unsigned.
7205         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7206         field_unsigned.
7207         * ui-out.h (class ui_out) <field_unsigned>: New method.
7208         <do_field_unsigned>: Likewise.
7209
7210 2019-07-15  Tom Tromey  <tromey@adacore.com>
7211
7212         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7213         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7214         * target.c (flash_erase_command): Use field_string.
7215         * infrun.c (print_signal_received_reason): Use field_string.
7216         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7217         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7218         field_string.
7219         * ada-tasks.c (print_ada_task_info): Use field_string.
7220
7221 2019-07-15  Tom Tromey  <tromey@adacore.com>
7222
7223         * target.c (flash_erase_command): Use field_core_addr.
7224         * symfile.c (generic_load): Use field_core_addr.
7225         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7226         Use field_core_addr.
7227         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7228         field_core_addr.
7229
7230 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7233         value if its desired type is smaller than a CORE_ADDR and signed.
7234
7235 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7238         of changes to field names, and use new is_reference field to
7239         decide if a property is a reference or not.
7240         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7241         field.
7242         (struct dwarf2_property_baton): Update header comment, rename
7243         'referenced_type' to 'property_type' and update comments.
7244         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7245         default property type, store in property baton, update to take
7246         accound of renamed field.
7247         (read_func_scope): Update call to attr_to_dynamic_prop.
7248         (read_array_type): Likewise.
7249         (dwarf2_per_cu_addr_sized_int_type): New function.
7250         (read_subrange_index_type): Move type finding code to
7251         dwarf2_per_cu_addr_sized_int_type.
7252         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7253         (dwarf2_per_cu_addr_type): New function.
7254         (set_die_type): Update calls to attr_to_dynamic_prop.
7255
7256 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7257
7258         * dwarf2read.c (read_subrange_index_type): New function.
7259         (read_subrange_type): Move code into new function and call it.
7260         * gdbtypes.c (create_range_type): Add some asserts.
7261
7262 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7265         update return statements.
7266         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7267         declaration, and update comment to match.
7268         * gdbtypes.c (resolve_dynamic_array): Update call to
7269         dwarf2_evaluate_property to match new return type.
7270
7271 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         * valarith.c (value_subscripted_rvalue): Change lowerbound
7274         parameter type from int to LONGEST.
7275         * value.h (value_subscripted_rvalue): Likewise in declaration.
7276
7277 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7278
7279         * cli/cli-utils.c (info_print_command_completer): New function.
7280         * cli/cli-utils.h: Add 'completer.h' include, and forward
7281         declaration for 'struct cmd_list_element'.
7282         (info_print_command_completer): Declare.
7283         * stack.c (_initialize_stack): Add completer for 'info locals' and
7284         'info args'.
7285         * symtab.c (_initialize_symtab): Add completer for 'info
7286         variables' and 'info functions'.
7287         * NEWS: Mention completion for additional info commands.
7288
7289 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * cli/cli-utils.c (extract_info_print_args): Delete.
7292         (extract_arg_maybe_quoted): Delete.
7293         (info_print_options_defs): New variable.
7294         (make_info_print_options_def_group): New function.
7295         (extract_info_print_options): Define new function.
7296         * cli/cli-utils.h (extract_info_print_args): Delete.
7297         (struct info_print_options): New structure.
7298         (extract_info_print_options): Declare new function.
7299         * stack.c (info_locals_command): Update to use new
7300         extract_info_print_options, also add a header comment.
7301         (info_args_command): Likewise.
7302         * symtab.c (info_variables_command): Likewise.
7303         (info_functions_command): Likewise.
7304
7305 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7308         to extract string arguments.
7309         * common/common-utils.c (extract_string_maybe_quoted): New function.
7310         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7311
7312 2019-07-11  Tom Tromey  <tromey@adacore.com>
7313
7314         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7315         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7316         * top.h (gdbinit): Don't declare.
7317         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7318         into...
7319         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7320         * top.c (gdb_init): Don't call init_cli_cmds.
7321         (gdbinit): Remove.
7322         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7323
7324 2019-07-11  Tom Tromey  <tromey@adacore.com>
7325
7326         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7327         after it has been moved.
7328
7329 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7330
7331         * valops.c (value_must_coerce_to_target): Change return type to
7332         bool.
7333         * value.h (value_must_coerce_to_target): Likewise.
7334
7335 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7336
7337         * breakpoint.c (is_hardware_watchpoint): Remove
7338         forward-declaration.
7339         (is_masked_watchpoint): Change return type to bool.
7340         (is_tracepoint): Likewise.
7341         (is_breakpoint): Likewise.
7342         (is_hardware_watchpoint): Likewise.
7343         (is_watchpoint): Likewise.
7344         (is_no_memory_software_watchpoint): Likewise.
7345         (is_catchpoint): Likewise.
7346         (breakpoint_1): Make FILTER parameter's return type bool.
7347         is_masked_watchpoint): Change return type to bool.
7348         (save_breakpoints): Make FILTER parameter's return type bool.
7349         * breakpoint.h (is_breakpoint): Change return type to bool.
7350         (is_watchpoint): Likewise.
7351         (is_catchpoint): Likewise.
7352         (is_tracepoint): Likewise.
7353
7354 2019-07-10  Tom Tromey  <tom@tromey.com>
7355
7356         * defs.h: Don't include gdbarch.h.
7357         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7358         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7359         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7360         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7361         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7362         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7363         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7364         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7365         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7366         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7367         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7368         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7369         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7370         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7371         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7372         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7373         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7374         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7375         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7376         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7377         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7378         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7379         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7380         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7381         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7382         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7383         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7384
7385 2019-07-10  Tom Tromey  <tromey@adacore.com>
7386
7387         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7388         * breakpoint.c (init_ada_exception_breakpoint): Register as
7389         bp_catchpoint.
7390         (print_one_breakpoint_location, print_one_breakpoint): Use
7391         is_ada_exception_catchpoint.
7392         * ada-lang.c (class ada_catchpoint_location): Pass
7393         bp_loc_software_breakpoint to bp_location constructor.
7394         (is_ada_exception_catchpoint): New function.
7395
7396 2019-07-10  Tom Tromey  <tromey@adacore.com>
7397
7398         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7399         VEC.
7400         (struct arm_exidx_entry): New method operator<.
7401         (struct arm_exidx_data) <section_maps>: Change type.
7402         (arm_exidx_data_free): Remove.
7403         (arm_exidx_data_key): Change type.  Move lower.
7404         (arm_exidx_new_objfile): Update.
7405         (arm_compare_exidx_entries): Remove.
7406         (arm_find_exidx_entry, _initialize_arm_tdep)
7407
7408 2019-07-10  Tom Tromey  <tromey@adacore.com>
7409
7410         * solib-spu.c (ocl_program_data_key): Change type.
7411         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7412         Update.
7413
7414 2019-07-10  Tom Tromey  <tromey@adacore.com>
7415
7416         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7417         (struct solib_aix_inferior_data) <library_list>: Change type.
7418         (solib_aix_inferior_data_handle): Change type.
7419         (get_solib_aix_inferior_data): Update.
7420         (solib_aix_free_library_list): Remove.
7421         (library_list_start_library): Update.
7422         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7423         return type.
7424         (solib_aix_get_library_list)
7425         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7426         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7427
7428 2019-07-10  Tom Tromey  <tromey@adacore.com>
7429
7430         * solib-dsbt.c (struct dsbt_info): Add initializers.
7431         (solib_dsbt_pspace_data): Change type.
7432         (dsbt_pspace_data_cleanup): Remove.
7433         (get_dsbt_info, _initialize_dsbt_solib): Update.
7434
7435 2019-07-10  Tom Tromey  <tromey@adacore.com>
7436
7437         * spu-tdep.c (spu_overlay_data): Change type.
7438         (spu_get_overlay_table, spu_overlay_new_objfile)
7439         (_initialize_spu_tdep): Update.
7440
7441 2019-07-10  Tom Tromey  <tromey@adacore.com>
7442
7443         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7444         destructor.
7445         (dbx_objfile_data_key): Change type and declare later.
7446         (DBX_SYMFILE_INFO): Rewrite.
7447         * dbxread.c (dbx_objfile_data_key): Change type.
7448         (dbx_symfile_init): Update.
7449         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7450         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7451         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7452
7453 2019-07-10  Tom Tromey  <tromey@adacore.com>
7454
7455         * jit.c (jit_program_space_key): Change type.  Move lower.
7456         (get_jit_program_space_data): Update.
7457         (jit_program_space_data_cleanup): Remove.
7458         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7459         Update.
7460         (struct jit_program_space_data): Add initializers.
7461
7462 2019-07-10  Tom Tromey  <tromey@adacore.com>
7463
7464         * solib-darwin.c (struct darwin_info): Add initializers.
7465         (solib_darwin_pspace_data): Change type.
7466         (darwin_pspace_data_cleanup): Remove.
7467         (get_darwin_info, _initialize_darwin_solib): Update.
7468
7469 2019-07-10  Tom Tromey  <tromey@adacore.com>
7470
7471         * remote-sim.c (struct sim_inferior_data): Add initializers,
7472         constructor, and destructor.
7473         (sim_inferior_data_key): Change type.  Move lower.
7474         (check_for_duplicate_sim_descriptor): Update.
7475         (get_sim_inferior_data): Use new.  Update.
7476         (~sim_inferior_data_cleanup): Rename from
7477         sim_inferior_data_cleanup.  Simplify.
7478         (gdbsim_close_inferior, simulator_command)
7479         (sim_command_completer, _initialize_remote_sim): Update.
7480         (next_pid, INITIAL_PID): Move earlier.
7481
7482 2019-07-10  Tom Tromey  <tromey@adacore.com>
7483
7484         * python/python-internal.h (create_thread_object): Return
7485         gdbpy_ref.
7486         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7487         * python/py-inferior.c (struct threadlist_entry): Add
7488         constructor.
7489         <thread_obj>: Now a gdbpy_ref.
7490         (thread_to_thread_object): Update.
7491         (add_thread_object): Use new.
7492         (delete_thread_object): Use delete.
7493         (infpy_threads): Update.
7494         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7495         GIL.
7496
7497 2019-07-10  Tom Tromey  <tromey@adacore.com>
7498
7499         * valops.c (value_cast): Specialize error message for Ada.
7500
7501 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7502
7503         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7504
7505 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7506
7507         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7508         bpstat_should_step): Return bool, adjust comments.
7509         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7510         bpstat_should_step): Likewise.
7511
7512 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7513
7514         * features/Makefile: Use feature target descriptions for Arm.
7515         * features/arm/arm-core.c: Generate new file.
7516         * features/arm/arm-fpa.c: Likewise.
7517         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7518         * features/arm/arm-m-profile.c: Likewise.
7519         * features/arm/arm-vfpv2.c: Likewise.
7520         * features/arm/arm-vfpv3.c: Likewise.
7521         * features/arm/xscale-iwmmxt.c: Likewise.
7522         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7523
7524 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7525
7526         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7527         ptrace earlier.
7528
7529 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7530
7531         * features/aarch64-pauth.c: Regenerate.
7532
7533 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7534
7535         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7536         bool.
7537         (bpstat_what): Use false instead of 0.
7538
7539 2019-07-09  Pedro Alves  <palves@redhat.com>
7540
7541         * break-catch-throw.c (is_exception_catchpoint): New.
7542         * breakpoint.c (print_one_breakpoint_location): New parameter
7543         'raw_loc'.  Handle it.  Use
7544         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7545         looking at the breakpoint's type.
7546         (print_one_breakpoint): If handling "maint info breakpoints", also
7547         print locations of exception catchpoints.
7548         * breakpoint.h (is_exception_catchpoint): Declare.
7549
7550 2019-07-09  Pedro Alves  <palves@redhat.com>
7551
7552         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7553         "addr" field.
7554         (allocate_location_exception_catchpoint): New.
7555         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7556         (initialize_throw_catchpoint_ops): Install
7557         allocate_location_exception_catchpoint as allocate_location
7558         method.
7559         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7560         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7561         bp_loc_other.
7562         (breakpoint_address_is_meaningful): Delete.
7563         (bl_address_is_meaningful): New.
7564         (breakpoint_locations_match): Adjust comment.
7565         (bp_location_from_bp_type): New, factored out of...
7566         (bp_location::bp_location(breakpoint *)): ... this.
7567         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7568         factored out of...
7569         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7570         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7571         breakpoint_address_is_meaningful.
7572         (bp_locations_compare): Adjust comment.
7573         (update_global_location_list): Use bl_address_is_meaningful
7574         instead of breakpoint_address_is_meaningful.
7575         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7576         explicit.
7577         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7578         * python/py-breakpoint.c (bppy_get_location): No longer check
7579         whether location is null.
7580
7581 2019-07-09  Pedro Alves  <palves@redhat.com>
7582
7583         PR c++/15468
7584         * breakpoint.c (print_one_breakpoint_location): Remove
7585         single-location assert.
7586
7587 2019-07-09  Tom Tromey  <tom@tromey.com>
7588
7589         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7590         * configure: Rebuild.
7591         * configure.ac: Change common to gdbsupport.
7592         * gdbsupport: Rename from common.
7593         * acinclude.m4: Change common to gdbsupport.
7594         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7595         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7596         gdbsupport.
7597         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7598         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7599         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7600         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7601         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7602         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7603         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7604         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7605         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7606         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7607         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7608         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7609         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7610         coff-pe-read.c, command.h, compile/compile-c-support.c,
7611         compile/compile-c.h, compile/compile-cplus-symbols.c,
7612         compile/compile-cplus-types.c, compile/compile-cplus.h,
7613         compile/compile-loc2c.c, compile/compile.c, completer.c,
7614         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7615         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7616         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7617         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7618         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7619         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7620         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7621         features/aarch64-core.c, features/aarch64-fpu.c,
7622         features/aarch64-pauth.c, features/aarch64-sve.c,
7623         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7624         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7625         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7626         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7627         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7628         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7629         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7630         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7631         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7632         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7633         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7634         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7635         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7636         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7637         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7638         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7639         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7640         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7641         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7642         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7643         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7644         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7645         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7646         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7647         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7648         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7649         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7650         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7651         minsyms.c, mips-linux-tdep.c, namespace.h,
7652         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7653         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7654         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7655         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7656         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7657         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7658         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7659         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7660         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7661         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7662         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7663         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7664         procfs.c, producer.c, progspace.h, psymtab.h,
7665         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7666         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7667         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7668         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7669         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7670         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7671         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7672         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7673         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7674         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7675         target-memory.c, target.c, target.h, target/waitstatus.c,
7676         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7677         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7678         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7679         unittests/array-view-selftests.c,
7680         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7681         unittests/common-utils-selftests.c,
7682         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7683         unittests/format_pieces-selftests.c,
7684         unittests/function-view-selftests.c,
7685         unittests/lookup_name_info-selftests.c,
7686         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7687         unittests/mkdir-recursive-selftests.c,
7688         unittests/observable-selftests.c,
7689         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7690         unittests/parse-connection-spec-selftests.c,
7691         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7692         unittests/scoped_fd-selftests.c,
7693         unittests/scoped_mmap-selftests.c,
7694         unittests/scoped_restore-selftests.c,
7695         unittests/string_view-selftests.c, unittests/style-selftests.c,
7696         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7697         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7698         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7699         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7700         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7701         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7702
7703 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7704
7705         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7706         bool value.
7707         (decode_digits_ordinary): Set explicit_line field in sal.
7708         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7709         symtab_and_line that was set on an explicit line number in
7710         assembler code.  Do always update the recorded symtab and line if
7711         we do skip the prologue.
7712
7713 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * breakpoint.c (set_breakpoint_location_function): Remove
7716         explicit_loc parameter.
7717         (momentary_breakpoint_from_master): Update call to
7718         set_breakpoint_location_function.
7719         (add_location_to_breakpoint): Likewise.
7720
7721 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7724         required features based on default bfd type when no specific bfd
7725         is present.
7726
7727 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7728
7729         * NEWS: Mention that GDB printf and eval commands can now print
7730         C-style and Ada-style convenience var strings without
7731         calling the inferior.
7732         * printcmd.c (printf_c_string): Locally print GDB internal var
7733         instead of transiting via the inferior.
7734         (printf_wide_c_string): Likewise.
7735
7736 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7737
7738         PR breakpoints/25011
7739         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7740
7741 2019-07-04  Tom Tromey  <tom@tromey.com>
7742
7743         PR tui/24724:
7744         * tui/tui-winsource.c (tui_clear_source_content): Update.
7745         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7746         (tui_update_breakpoint_info): Update.
7747         (tui_set_exec_info_content): Update.
7748         * tui/tui-source.c (tui_set_source_content_nil): Update.
7749         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7750         has_break.
7751         * tui/tui-data.h (enum tui_bp_flag): New.
7752         (tui_bp_flags): New enum flags type.
7753         (struct tui_source_element) <break_mode>: Change type.  Rename
7754         from has_break.
7755         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7756         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7757         constants.
7758         * tui/tui-winsource.h: Fix comment.
7759
7760 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7761
7762         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7763         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7764         (store_fpregs_to_thread)
7765         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7766         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7767         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7768         (IWMMXT_REGS_SIZE): Add define.
7769         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7770         (fetch_vfp_regs, store_vfp_regs)
7771         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7772         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7773
7774 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7775
7776         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7777         defines.
7778         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7779         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7780         (ARM_INT_REGISTER_SIZE): ...to this.
7781         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7782         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7783         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7784         (arm_linux_collect_gregset, supply_nwfpe_register)
7785         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7786         defines.
7787         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7788         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7789         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7790         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7791         (arm_return_in_memory, arm_store_return_value)
7792         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7793         (arm_record_ld_st_multiple): Likewise.
7794         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7795         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7796
7797 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7798
7799         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7800         AARCH64_DISPLACED_MODIFIED_INSNS.
7801         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7802         (aarch64_displaced_step_copy_insn): Likewise.
7803         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7804         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7805         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7806         ARM_DISPLACED_MODIFIED_INSNS.
7807         * arm-tdep.c (arm_gdbarch_init): Likewise.
7808         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7809         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7810         (struct arm_displaced_step_closure): Use
7811         ARM_DISPLACED_MODIFIED_INSNS.
7812
7813 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7814
7815         * features/Makefile: Remove unused xml files.
7816         * features/aarch64.xml: Remove.
7817         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7818         * features/i386/amd64-avx-avx512.xml: Remove.
7819         * features/i386/amd64-avx-linux.xml: Remove.
7820         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7821         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7822         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7823         * features/i386/amd64-avx-mpx.xml: Remove.
7824         * features/i386/amd64-avx.xml: Remove.
7825         * features/i386/amd64-linux.xml: Remove.
7826         * features/i386/amd64-mpx-linux.xml: Remove.
7827         * features/i386/amd64-mpx.xml: Remove.
7828         * features/i386/amd64.xml: Remove.
7829         * features/i386/i386-avx-avx512-linux.xml: Remove.
7830         * features/i386/i386-avx-avx512.xml: Remove.
7831         * features/i386/i386-avx-linux.xml: Remove.
7832         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7833         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7834         * features/i386/i386-avx-mpx-linux.xml: Remove.
7835         * features/i386/i386-avx-mpx.xml: Remove.
7836         * features/i386/i386-avx.xml: Remove.
7837         * features/i386/i386-linux.xml: Remove.
7838         * features/i386/i386-mmx-linux.xml: Remove.
7839         * features/i386/i386-mmx.xml: Remove.
7840         * features/i386/i386-mpx-linux.xml: Remove.
7841         * features/i386/i386-mpx.xml: Remove.
7842         * features/i386/i386.xml: Remove.
7843         * features/i386/x32-avx-avx512-linux.xml: Remove.
7844         * features/i386/x32-avx-linux.xml: Remove.
7845         * features/i386/x32-linux.xml: Remove.
7846
7847 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7848
7849         * regformats/aarch64.dat: Remove.
7850         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7851         * regformats/i386/amd64-avx-linux.dat: Remove.
7852         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7853         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7854         * regformats/i386/amd64-linux.dat: Remove.
7855         * regformats/i386/amd64-mpx-linux.dat: Remove.
7856         * regformats/i386/amd64.dat: Remove.
7857         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7858         * regformats/i386/i386-avx-linux.dat: Remove.
7859         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7860         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7861         * regformats/i386/i386-linux.dat: Remove.
7862         * regformats/i386/i386-mmx-linux.dat: Remove.
7863         * regformats/i386/i386-mpx-linux.dat: Remove.
7864         * regformats/i386/i386.dat: Remove.
7865         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7866         * regformats/i386/x32-avx-linux.dat: Remove.
7867         * regformats/i386/x32-linux.dat: Remove.
7868
7869 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7870
7871         * aarch64-tdep.c: Remove xml self tests.
7872         * amd64-linux-tdep.c: Likewise.
7873         * amd64-tdep.c: Likewise.
7874         * i386-linux-tdep.c: Likewise.
7875         * i386-tdep.c: Likewise.
7876
7877 2019-07-03  Pedro Alves  <palves@redhat.com>
7878
7879         PR cli/24732
7880         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7881         (pipe_cmd_option_defs): New.
7882         (make_pipe_cmd_options_def_group): New.
7883         (pipe_command): Use gdb::option::process_options.
7884         (pipe_command_completer): New function.
7885         (_initialize_cli_cmds): Install completer for "pipe" command.
7886
7887 2019-07-03  Pedro Alves  <palves@redhat.com>
7888
7889         * cli/cli-option.c (union option_value) <string>: New field.
7890         (struct option_def_and_value): Add ctor, move ctor, dtor and
7891         use DISABLE_COPY_AND_ASSIGN.
7892         (option_def_and_value::clear_value): New.
7893         (parse_option, save_option_value_in_ctx, get_val_type_str)
7894         (add_setshow_cmds_for_options): Handle var_string.
7895         * cli-option.h (union option_def::var_address) <string>: New
7896         field.
7897         (struct string_option_def): New.
7898         * maint-test-options.c (struct test_options_opts): Add default
7899         ctor and use DISABLE_COPY_AND_ASSIGN.
7900         <string_opt>: New field.
7901         (test_options_opts::~test_options_opts): New.
7902         (test_options_opts::dump): Also dump "-string".
7903         (test_options_option_defs): Install "string.
7904
7905 2019-07-03  Pedro Alves  <palves@redhat.com>
7906
7907         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7908         option_value with a null enumeration.
7909         (complete_options): Save the option values in the context.
7910         (save_option_value_in_ctx): New, factored out from ...
7911         (process_options): ... here.
7912         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7913         of the function.
7914         * maint-test-options.c (test_options_opts::dump): New, factored
7915         out from ...
7916         (maintenance_test_options_command_mode): ... here.
7917         (maintenance_test_options_command_completion_result): Delete.
7918         (maintenance_test_options_command_completion_text): Update
7919         comment.
7920         (maintenance_show_test_options_completion_result): Change
7921         prototype.  Just print
7922         maintenance_test_options_command_completion_text.
7923         (save_completion_result): New.
7924         (maintenance_test_options_completer_mode): Pass options context to
7925         complete_options, and then save a dump.
7926         (_initialize_maint_test_options): Use add_cmd to install "maint
7927         show test-options-completion-result".
7928
7929 2019-07-03  Pedro Alves  <palves@redhat.com>
7930
7931         * NEWS (New commands): Mention "with" and "maint with".
7932         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7933         (with_command, with_command_completer): New.
7934         (pipe_command): Adjust to new repeat_previous
7935         interface.
7936         (_initialize_cli_cmds): Install the "with" command and its "w"
7937         alias.
7938         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7939         declarations.
7940         * cli/cli-setshow.c (parse_cli_var_uinteger)
7941         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7942         argument strings for all var_types.
7943         (get_setshow_command_value_string): New, factored out from ...
7944         (do_show_command): ... this.
7945         * cli/cli-setshow.h: Include <string>.
7946         (get_setshow_command_value_string): Declare.
7947         * command.h (repeat_previous): Now returns const char *.  Adjust
7948         comment.
7949         * maint.c: Include "cli/cli-cmds.h".
7950         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7951         (_initialize_maint_cmds): Register the "maintenance with" command.
7952         * top.c (repeat_previous): Move bits from pipe_command here:
7953         Return the saved command line, if any; error out if there's no
7954         command to relaunch.
7955
7956 2019-07-03  Pedro Alves  <palves@redhat.com>
7957
7958         * NEWS (New commands): Mention "maint set/show test-settings"
7959         instead of "maint test-settings".
7960         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7961         (maintenance_test_settings_set_list): Rename to ...
7962         (maintenance_set_test_settings_list): ... this.
7963         (maintenance_test_settings_show_list): Rename to  ...
7964         (maintenance_show_test_settings_list): ... this.
7965         (maintenance_test_settings_cmd): Delete.
7966         (maintenance_test_settings_set_cmd): ...
7967         (maintenance_set_test_settings_cmd): ... this.
7968         (maintenance_test_settings_show_cmd): ...
7969         (maintenance_show_test_settings_cmd): ... this.
7970         (maintenance_test_settings_show_value_cmd):
7971         (maintenance_show_test_settings_value_cmd): ... this.
7972         (_initialize_maint_test_settings): No longer install the "maint
7973         test-settings" prefix command.  Rename "maint test-settings set"
7974         to "maint set test-settings", and "maint test-settings show" to
7975         "maint show test-settings".  Adjust all subcommands.
7976
7977 2019-07-03  Pedro Alves  <palves@redhat.com>
7978
7979         * maint-test-settings.c: Fix file's intro comment.  Replace all
7980         references to "test-options" with references to "test-settings",
7981         in comments.
7982
7983 2019-07-03  Pedro Alves  <palves@redhat.com>
7984
7985         * maint-test-settings.c (maintenance_test_settings_xxx)
7986         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7987         New.
7988         (maintenance_test_settings_enums): Use them.
7989         (maintenance_test_settings_enum): Default to
7990         maintenance_test_settings_xxx.
7991         (_initialize_maint_test_settings): Initialize
7992         MAINTENANCE_TEST_SETTINGS_FILENAME.
7993
7994 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7995
7996         * breakpoint.h (remove_breakpoints_inf): Change return type to
7997         void, move function documentation here.
7998         * breakpoint.c (remove_breakpoints_inf): Change return type to
7999         void, move function documentation to header.
8000
8001 2019-07-02  Pedro Alves  <palves@redhat.com>
8002
8003         * NEWS (Completion improvements): Mention "info threads".
8004         * thread.c (struct info_threads_opts, info_threads_option_defs)
8005         (make_info_threads_options_def_group): New.
8006         (info_threads_command): Use gdb::option::process_options.
8007         (info_threads_command_completer): New.
8008         (_initialize_thread): Use gdb::option::build_help to build the
8009         help text for "info threads".
8010
8011 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8012
8013         * defs.h (generic_load): Move from here...
8014         * symfile.h (generic_load): ... to here.  Rename name parameter
8015         to args.
8016         * symfile.c (generic_load): Add comment.
8017
8018 2019-07-01  Tom Tromey  <tromey@adacore.com>
8019
8020         * dwarf2read.c
8021         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8022         declaration of without_params.  Fix formatting.
8023
8024 2019-07-01  Tom Tromey  <tromey@adacore.com>
8025
8026         * ada-exp.y (find_primitive_type): Update.
8027         * ada-lang.h (ada_lookup_symbol): Update.
8028         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8029         parameter.
8030         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8031
8032 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8033
8034         PR breakpoints/24541
8035         * gdbarch.c: Regenerate.
8036         * gdbarch.h: Regenerate.
8037         * gdbarch.sh: Add 'stap_adjust_register'.
8038         * i386-tdep.c: Include '<unordered_set>'.
8039         (i386_stap_adjust_register): New function.
8040         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8041         * stap-probe.c (stap_parse_register_operand): Call
8042         'gdbarch_stap_adjust_register'.
8043
8044 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8045
8046         PR python/24742
8047         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8048         * python/python.c (do_start_initialization): Use 'xmalloc'
8049         instead of 'PyMem_Malloc'.
8050
8051 2019-06-28  Tom Tromey  <tromey@adacore.com>
8052
8053         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8054         for Ada.
8055
8056 2019-06-27  Tom Tromey  <tromey@adacore.com>
8057
8058         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8059         objfile_key.
8060         (arm_find_mapping_symbol, arm_record_special_symbol)
8061         (_initialize_arm_tdep): Update.
8062         (arm_objfile_data_free): Remove.
8063
8064 2019-06-27  Tom Tromey  <tromey@adacore.com>
8065
8066         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8067         to cp_print_static_field.
8068
8069 2019-06-26  Tom Tromey  <tromey@adacore.com>
8070
8071         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8072         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8073         declare.
8074
8075 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8076
8077         * features/aarch64-core.c (create_feature_aarch64_core):
8078         Regenerate.
8079         * features/aarch64-core.xml: Add cpsr flags.
8080
8081 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8082
8083         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8084         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8085
8086 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8087
8088         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8089         field.
8090         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8091         use.
8092         (arm_record_special_symbol): Don't insert new symbol in sorted
8093         position, push it at the end.
8094
8095 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8096
8097         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8098         (arm_mapping_symbol_s): Remove.
8099         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8100         (arm_mapping_symbol_vec): New typedef.
8101         (struct arm_per_objfile): Add constructor.
8102         <section_maps>: Change type to
8103         std::unique_ptr<arm_mapping_symbol_vec[]>.
8104         (arm_compare_mapping_symbols): Remove.
8105         (arm_find_mapping_symbol): Adjust to section_maps type change.
8106         (arm_objfile_data_free): Call delete on arm_per_objfile.
8107         (arm_record_special_symbol): Adjust to section_maps type change.
8108         Allocate arm_per_objfile with new.
8109
8110 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8111
8112         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8113         with the command prefix.
8114
8115 2019-06-25  Tom Tromey  <tom@tromey.com>
8116
8117         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8118         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8119
8120 2019-06-25  Tom Tromey  <tom@tromey.com>
8121
8122         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8123         type.
8124         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8125         protected.
8126
8127 2019-06-25  Tom Tromey  <tom@tromey.com>
8128
8129         * tui/tui-winsource.c
8130         (tui_source_window_base::set_is_exec_point_at): Add check against
8131         LOA_ADDRESS.
8132
8133 2019-06-25  Tom Tromey  <tom@tromey.com>
8134
8135         * tui/tui-source.c (tui_set_source_content): Don't check before
8136         xfree.
8137         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8138
8139 2019-06-25  Tom Tromey  <tom@tromey.com>
8140
8141         * tui/tui-winsource.h (tui_update_source_window_as_is)
8142         (tui_alloc_source_buffer, tui_line_is_displayed)
8143         (tui_addr_is_displayed): Change type of win_info.
8144         * tui/tui-winsource.c (tui_update_source_window_as_is)
8145         (tui_clear_source_content, tui_show_source_line)
8146         (tui_show_source_content, tui_source_window_base::refill)
8147         (tui_source_window_base::set_is_exec_point_at)
8148         (tui_source_window_base::set_is_exec_point_at)
8149         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8150         (tui_alloc_source_buffer, tui_line_is_displayed)
8151         (tui_addr_is_displayed): Change type of win_info.  Update.
8152         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8153         (tui_source_window_base::do_make_visible_with_new_height):
8154         Update.
8155         * tui/tui-source.c (tui_set_source_content)
8156         (tui_set_source_content_nil)
8157         (tui_source_window::do_scroll_vertical): Update.
8158         * tui/tui-layout.c (show_layout): Update.
8159         * tui/tui-disasm.c (tui_set_disassem_content)
8160         (tui_disasm_window::do_scroll_vertical): Update.
8161         * tui/tui-data.h (tui_win_content): Remove.
8162         (struct tui_gen_win_info) <content, content_size>: Remove.
8163         (struct tui_source_element): Add initializers and destructor.
8164         (union tui_which_element, struct tui_win_element): Remove.
8165         (struct tui_source_window_base) <content>: New field.
8166         (struct tui_data_window): Remove destructor.
8167         (tui_alloc_content, tui_free_win_content)
8168         (tui_free_all_source_wins_content): Don't declare.
8169         * tui/tui-data.c (tui_initialize_static_data): Update.
8170         (init_content_element, tui_alloc_content): Remove.
8171         (~tui_gen_win_info): Update.
8172         (~tui_data_window, tui_free_all_source_wins_content)
8173         (tui_free_win_content, free_content, free_content_elements):
8174         Remove.
8175
8176 2019-06-25  Tom Tromey  <tom@tromey.com>
8177
8178         * tui/tui-winsource.h (tui_clear_source_content)
8179         (tui_erase_source_content, tui_show_source_content): Change type
8180         of win_info.
8181         * tui/tui-winsource.c (tui_clear_source_content)
8182         (tui_erase_source_content, tui_show_source_content): Change type
8183         of win_info.
8184         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8185         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8186         win_info.
8187         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8188         win_info.
8189         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8190
8191 2019-06-25  Tom Tromey  <tom@tromey.com>
8192
8193         * tui/tui-winsource.c (tui_clear_source_content)
8194         (tui_source_window_base::set_is_exec_point_at): Update.
8195         * tui/tui-source.c (tui_set_source_content_nil): Update.
8196         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8197         a bool.
8198         * tui/tui-data.c (init_content_element): Update.
8199
8200 2019-06-25  Tom Tromey  <tom@tromey.com>
8201
8202         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8203         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8204         * tui/tui-layout.c (init_and_make_win): Update.
8205         * tui/tui.h (enum tui_win_type): Update.
8206         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8207         tui_win_is_auxillary.
8208         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8209         tui_win_is_auxillary.
8210
8211 2019-06-25  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8214         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8215         (tui_delete_data_content_windows, tui_display_all_data)
8216         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8217         Update.
8218         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8219         * tui/tui-regs.c (tui_last_regs_line_no)
8220         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8221         (tui_show_registers): Update.
8222         (tui_show_register_group): Return void.  Update.
8223         (tui_display_registers_from, tui_display_reg_element_at_line)
8224         (tui_display_registers_from_line, tui_check_register_values):
8225         Update.
8226         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8227         member.
8228         (struct tui_data_window) <regs_content>: Now a std::vector.
8229         <regs_content_count>: Remove.
8230         (tui_add_content_elements, tui_free_data_content): Don't declare.
8231         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8232         (init_content_element): Remove DATA_WIN case.  Add assert.
8233         (tui_add_content_elements): Remove.
8234         (tui_data_window): Update.
8235         (tui_free_data_content): Remove.
8236         (free_content_elements): Remove DATA_WIN case.
8237
8238 2019-06-25  Tom Tromey  <tom@tromey.com>
8239
8240         * tui/tui-data.c (tui_data_item_window): Update.
8241         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8242         * tui/tui-windata.c (tui_display_all_data)
8243         (tui_display_data_from_line): Update.
8244         (tui_check_data_values): Remove.
8245         * tui/tui-regs.c (tui_show_register_group)
8246         (tui_display_reg_element_at_line): Update.
8247         * tui/tui-hooks.c (tui_register_changed)
8248         (tui_refresh_frame_and_register_information): Call
8249         tui_check_register_values.
8250         * tui/tui-data.h (struct tui_data_window) <data_content,
8251         data_content_count, data_type>: Remove.
8252         (enum tui_data_type): Remove.
8253
8254         * tui/tui-data.c (tui_data_window::clear_detail)
8255         (~tui_data_window): Update.
8256
8257 2019-06-25  Tom Tromey  <tom@tromey.com>
8258
8259         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8260         declare.
8261         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8262         Rename from tui_first_data_item_displayed.  Update.
8263         (tui_data_window::refresh_all)
8264         (tui_data_window::do_scroll_vertical): Update.
8265         * tui/tui-data.h (struct tui_data_window)
8266         <first_data_item_displayed>: Declare new method.
8267
8268 2019-06-25  Tom Tromey  <tom@tromey.com>
8269
8270         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8271         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8272         contents...
8273         (tui_initialize_static_data): ...here.
8274
8275 2019-06-25  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8278         (tui_display_registers_from, tui_check_register_values): Update.
8279         (tui_display_register): Remove win_info parameter; update.
8280         (tui_get_register): Change type of parameters.
8281         * tui/tui-data.h (struct tui_data_element): Remove.
8282         (union tui_which_element) <data>: Remove.
8283         <data_window>: Change type.
8284         (struct tui_data_item_window): New.
8285         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8286         case.  Add assert.
8287         (~tui_data_item_window): New destructor.
8288         (free_content_elements): Remove DATA_ITEM_WIN case.
8289
8290 2019-06-25  Tom Tromey  <tom@tromey.com>
8291
8292         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8293         Remove.
8294
8295 2019-06-25  Tom Tromey  <tom@tromey.com>
8296
8297         * tui/tui-data.h (struct tui_command_element): Remove.
8298         (union tui_which_element) <command>: Remove.
8299         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8300         assert.
8301         (free_content_elements): Remove CMD_WIN case.
8302
8303 2019-06-25  Tom Tromey  <tom@tromey.com>
8304
8305         * tui/tui-layout.c (tui_set_layout): Update.
8306         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8307         * tui/tui-data.c (layout_def): Update.
8308
8309 2019-06-25  Tom Tromey  <tom@tromey.com>
8310
8311         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8312         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8313         (tui_source_window_base::set_new_height): Update.
8314         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8315         Update.
8316         (tui_set_locator_fullname, tui_set_locator_info)
8317         (tui_show_frame_info): Update.
8318         * tui/tui-source.c (tui_set_source_content)
8319         (tui_source_is_displayed): Update.
8320         * tui/tui-layout.c (show_source_disasm_command, show_data)
8321         (show_source_or_disasm_and_command): Update.
8322         * tui/tui-disasm.c (tui_set_disassem_content)
8323         (tui_get_begin_asm_address): Update.
8324         * tui/tui-data.h (struct tui_locator_element): Remove.
8325         (union tui_which_element) <locator>: Remove.
8326         (struct tui_locator_window): New.
8327         (tui_locator_win_info_ptr): Change return type.
8328         * tui/tui-data.c (_locator): Change type.
8329         (tui_locator_win_info_ptr): Change return type.
8330         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8331         (tui_alloc_content): Add assert.
8332
8333 2019-06-25  Tom Tromey  <tom@tromey.com>
8334
8335         * tui/tui-winsource.c
8336         (tui_exec_info_window::maybe_allocate_content): New method.
8337         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8338         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8339         (make_source_or_disasm_window): Add cast.
8340         * tui/tui-data.h (union tui_which_element) <simple_string>:
8341         Remove.
8342         (struct tui_source_info): New.
8343         (struct tui_source_window_base) <execution_info>: Change type.
8344         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8345         case, and add assert.
8346         (tui_alloc_content): Add assert.
8347
8348 2019-06-25  Tom Tromey  <tom@tromey.com>
8349
8350         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8351         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8352         * tui/tui-data.c (tui_alloc_win_info): Remove.
8353
8354 2019-06-25  Tom Tromey  <tom@tromey.com>
8355
8356         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8357         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8358         can_highlight.
8359
8360 2019-06-25  Tom Tromey  <tom@tromey.com>
8361
8362         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8363         make_visible_with_new_height method.
8364         (tui_win_info::make_visible_with_new_height): New method.
8365         (tui_source_window_base::do_make_visible_with_new_height)
8366         (tui_data_window::do_make_visible_with_new_height)
8367         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8368         (make_visible_with_new_height): Remove.
8369         (tui_resize_all, tui_adjust_win_heights): Use
8370         make_visible_with_new_height method.
8371         * tui/tui-data.h (struct tui_win_info)
8372         <do_make_visible_with_new_height, make_visible_with_new_height>:
8373         New methods.
8374         (struct tui_source_window_base, struct tui_data_window)
8375         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8376         methods.
8377
8378 2019-06-25  Tom Tromey  <tom@tromey.com>
8379
8380         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8381         method.
8382         (update_tab_width): Call update_tab_width method.
8383         * tui/tui-data.h (struct tui_win_info)
8384         (struct tui_source_window_base) <update_tab_width>: New methods.
8385
8386 2019-06-25  Tom Tromey  <tom@tromey.com>
8387
8388         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8389         parameter.
8390         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8391         parameter.
8392         (tui_gen_win_info::make_visible): Update.
8393         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8394         parameter.
8395         * tui/tui-data.h (enum tui_box): New enum.
8396         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8397
8398 2019-06-25  Tom Tromey  <tom@tromey.com>
8399
8400         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8401         init_and_make_win for EXEC_INFO_WIN.
8402         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8403         longer inline.
8404         (struct tui_win_info) <~tui_win_info>: Inline.
8405         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8406         Don't declare.
8407         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8408         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8409         Remove.
8410         (tui_initialize_static_data): Update.
8411         (~tui_gen_win_info): Handle more cleanup here.
8412         (~tui_source_window_base): Delete "execution_info".
8413         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8414
8415 2019-06-25  Tom Tromey  <tom@tromey.com>
8416
8417         * tui/tui-layout.c (make_command_window): Don't set
8418         can_highlight.
8419         (show_source_disasm_command): Call the reset method.
8420         (show_data): Don't set can_highlight.  Call the reset method.
8421         (tui_gen_win_info::reset): Rename from init_gen_win_info
8422         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8423         (show_source_or_disasm_and_command): Call the reset method.
8424         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8425         (struct tui_cmd_window): Set can_highlight.
8426
8427 2019-06-25  Tom Tromey  <tom@tromey.com>
8428
8429         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8430         from make_visible.
8431         (tui_make_visible, tui_make_invisible): Rewrite.
8432         (tui_win_info::make_visible): Remove.
8433         (tui_source_window_base::make_visible): Update.
8434         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8435         method.  Moved from...
8436         (struct tui_win_info) <make_visible>: ...here.
8437
8438 2019-06-25  Tom Tromey  <tom@tromey.com>
8439
8440         * tui/tui-winsource.c
8441         (tui_source_window_base::do_scroll_horizontal): Remove direction
8442         parameter.
8443         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8444         direction parameter.
8445         * tui/tui-win.c (tui_win_info::forward_scroll)
8446         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8447         (tui_win_info::right_scroll): Update.
8448         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8449         direction parameter.
8450         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8451         direction parameter.
8452         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8453         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8454         Remove direction parameter.
8455         (struct tui_source_window_base, struct tui_source_window)
8456         (struct tui_disasm_window, struct tui_data_window)
8457         (struct tui_cmd_window): Update.
8458
8459 2019-06-25  Tom Tromey  <tom@tromey.com>
8460
8461         * tui/tui-winsource.h (tui_set_exec_info_content)
8462         (tui_show_exec_info_content, tui_erase_exec_info_content)
8463         (tui_clear_exec_info_content, tui_update_exec_info): Change
8464         argument to tui_source_window_base.
8465         * tui/tui-winsource.c (tui_set_exec_info_content)
8466         (tui_show_exec_info_content, tui_erase_exec_info_content)
8467         (tui_clear_exec_info_content, tui_update_exec_info): Change
8468         argument to tui_source_window_base.
8469
8470 2019-06-25  Tom Tromey  <tom@tromey.com>
8471
8472         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8473         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8474
8475 2019-06-25  Tom Tromey  <tom@tromey.com>
8476
8477         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8478         check.
8479
8480 2019-06-25  Tom Tromey  <tom@tromey.com>
8481
8482         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8483         type to void.
8484         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8485         type to void.
8486         * tui/tui-source.c (tui_set_source_content): Update.
8487         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8488
8489 2019-06-25  Tom Tromey  <tom@tromey.com>
8490
8491         * tui/tui-win.c (window_name_completer, tui_set_focus)
8492         (tui_all_windows_info): Use name method.
8493         * tui/tui-data.h (struct tui_gen_win_info)
8494         (struct tui_source_window, struct tui_disasm_window)
8495         (struct tui_data_window, struct tui_cmd_window) <name>: New
8496         method.
8497         (tui_win_name): Don't declare.
8498         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8499         (tui_win_name): Remove.
8500
8501 2019-06-25  Tom Tromey  <tom@tromey.com>
8502
8503         * tui/tui-winsource.h (tui_update_source_window)
8504         (tui_update_source_window_as_is): Change parameter type.
8505         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8506         to be a tui_source_window_base.
8507         (tui_update_source_window_as_is): Likewise.
8508         * tui/tui-win.c (make_visible_with_new_height): Update.
8509
8510 2019-06-25  Tom Tromey  <tom@tromey.com>
8511
8512         * tui/tui-winsource.c (tui_erase_source_content)
8513         (tui_show_source_content, tui_show_exec_info_content)
8514         (tui_erase_exec_info_content): Use refresh_window method.
8515         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8516         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8517         from tui_refresh_win.
8518         (tui_data_window::refresh_window): New method.
8519         (tui_win_info::refresh, tui_source_window_base::refresh)
8520         (tui_refresh_all): Use refresh_window method.
8521         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8522         method.
8523         * tui/tui-regs.c (tui_display_register): Call refresh_window
8524         method.
8525         * tui/tui-layout.c (show_source_disasm_command)
8526         (show_source_or_disasm_and_command): Call refresh_window method.
8527         * tui/tui-data.h (struct tui_gen_win_info)
8528         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8529         New method.
8530
8531 2019-06-25  Tom Tromey  <tom@tromey.com>
8532
8533         * tui/tui.c (tui_rl_other_window, tui_enable)
8534         (tui_is_window_visible, tui_get_command_dimension): Update.
8535         * tui/tui-winsource.c (tui_update_source_window_as_is)
8536         (tui_clear_source_content, tui_erase_source_content)
8537         (tui_show_source_line, tui_source_window_base::refill)
8538         (tui_source_window_base::do_scroll_horizontal)
8539         (tui_source_window_base::set_is_exec_point_at)
8540         (tui_update_breakpoint_info, tui_set_exec_info_content)
8541         (tui_alloc_source_buffer, tui_line_is_displayed)
8542         (tui_addr_is_displayed): Update.
8543         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8544         (tui_check_and_display_highlight_if_needed)
8545         (tui_win_info::make_visible, tui_win_info::refresh)
8546         (tui_refresh_all): Update.
8547         * tui/tui-windata.c (tui_first_data_item_displayed)
8548         (tui_delete_data_content_windows, tui_erase_data_content)
8549         (tui_display_all_data, tui_data_window::refresh_all)
8550         (tui_check_data_values): Update.
8551         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8552         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8553         (tui_win_info::backward_scroll, tui_refresh_all_win)
8554         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8555         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8556         (tui_source_window_base::set_new_height)
8557         (tui_data_window::set_new_height)
8558         (make_invisible_and_set_new_height)
8559         (make_visible_with_new_height, new_height_ok)
8560         (parse_scrolling_args): Update.
8561         * tui/tui-stack.c (tui_show_frame_info): Update.
8562         * tui/tui-source.c (tui_set_source_content)
8563         (tui_set_source_content_nil, tui_source_is_displayed)
8564         (tui_source_window::do_scroll_vertical): Update.
8565         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8566         (tui_display_registers_from, tui_display_reg_element_at_line)
8567         (tui_check_register_values, tui_reg_command): Update.
8568         * tui/tui-layout.c (tui_default_win_height)
8569         (show_source_disasm_command, show_data, init_and_make_win)
8570         (show_source_or_disasm_and_command): Update.
8571         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8572         (tui_redisplay_readline, tui_mld_flush)
8573         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8574         (tui_getc): Update.
8575         * tui/tui-disasm.c (tui_set_disassem_content)
8576         (tui_disasm_window::do_scroll_vertical): Update.
8577         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8578         Now virtual.
8579         (struct tui_win_info): Derive from tui_gen_win_info.
8580         <~tui_win_info>: Mark as override.
8581         <generic>: Remove member.
8582         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8583         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8584         (~tui_data_window, ~tui_win_info)
8585         (tui_free_all_source_wins_content): Update.
8586         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8587
8588 2019-06-25  Tom Tromey  <tom@tromey.com>
8589
8590         * tui/tui-layout.c (init_and_make_win): Use new.
8591         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8592         destructor, initializers.
8593         (tui_alloc_generic_win_info): Don't declare.
8594         * tui/tui-data.c (_locator): Add argument to constructor.
8595         (source_win, disasm_win): New globals.
8596         (exec_info): Remove.
8597         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8598         Update.
8599         (tui_alloc_generic_win_info): Remove.
8600         (init_content_element): Use new.
8601         (tui_win_info::tui_win_info): Update.
8602         (free_content_elements) <case DATA_WIN>: Use delete.
8603
8604 2019-06-25  Tom Tromey  <tom@tromey.com>
8605
8606         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8607         * tui/tui-windata.c (tui_first_data_item_displayed)
8608         (tui_delete_data_content_windows): Update.
8609         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8610         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8611         (tui_display_registers_from, tui_check_register_values): Update.
8612         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8613         pointer.
8614         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8615         window.
8616         (tui_free_data_content): Update.
8617         (free_content_elements) <case DATA_WIN>: Free the window.
8618
8619 2019-06-25  Tom Tromey  <tom@tromey.com>
8620
8621         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8622         Update.
8623         * tui/tui-layout.c (make_command_window)
8624         (show_source_disasm_command, show_data, init_and_make_win)
8625         (show_source_or_disasm_and_command): Update.
8626         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8627         method.
8628         <can_highight, is_highlighted>: Now bool.
8629         (tui_set_win_highlight): Don't declare.
8630         * tui/tui-data.c (tui_set_win_highlight): Remove.
8631
8632 2019-06-25  Tom Tromey  <tom@tromey.com>
8633
8634         * tui/tui-wingeneral.c (make_visible): Remove check of window
8635         type.
8636
8637 2019-06-25  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-win.c (tui_win_info::max_height)
8640         (tui_cmd_window::max_height): New methods.
8641         (new_height_ok): Call max_height.
8642         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8643         <max_height>: New method.
8644
8645 2019-06-25  Tom Tromey  <tom@tromey.com>
8646
8647         * tui/tui-win.c (tui_source_window_base::set_new_height)
8648         (tui_data_window::set_new_height): New methods.
8649         (make_invisible_and_set_new_height): Call set_new_height method.
8650         * tui/tui-data.h (struct tui_win_info)
8651         (struct tui_source_window_base, struct tui_data_window)
8652         <set_new_height>: New method.
8653
8654 2019-06-25  Tom Tromey  <tom@tromey.com>
8655
8656         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8657         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8658         tui_refresh_data_win.
8659         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8660         method.
8661         (tui_refresh_all_win): Call the refresh_all method.
8662         (tui_set_focus): Likewise.
8663         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8664         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8665         Likewise.
8666
8667 2019-06-25  Tom Tromey  <tom@tromey.com>
8668
8669         * tui/tui-winsource.h (tui_refill_source_window)
8670         (tui_set_is_exec_point_at): Don't declare.
8671         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8672         (tui_source_window_base::refill): Rename from
8673         tui_refill_source_window.
8674         (tui_source_window_base::do_scroll_horizontal): Update.
8675         (tui_source_window_base::set_is_exec_point_at): Rename from
8676         tui_set_is_exec_point_at.
8677         (tui_update_all_breakpoint_info): Update.
8678         * tui/tui-stack.c (tui_show_frame_info): Update.
8679         * tui/tui-layout.c (show_data): Add cast.
8680         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8681         * tui/tui-data.h (struct tui_source_window_base) <refill,
8682         set_is_exec_point_at>: New methods.
8683         (tui_source_windows, tui_add_to_source_windows): Update types.
8684         (tui_add_to_source_windows): Remove redundant declaration.
8685         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8686         (tui_source_windows): Change return type.
8687         (tui_clear_source_windows_detail): Update.
8688         (tui_add_to_source_windows): Change type of parameter.
8689         (tui_free_all_source_wins_content): Update.
8690
8691 2019-06-25  Tom Tromey  <tom@tromey.com>
8692
8693         * tui/tui-wingeneral.c (tui_win_info::refresh)
8694         (tui_source_window_base::refresh): New methods.
8695         (tui_refresh_all): Call the refresh method.
8696         * tui/tui-data.h (struct tui_win_info)
8697         (struct tui_source_window_base) <refresh>: New method.
8698
8699 2019-06-25  Tom Tromey  <tom@tromey.com>
8700
8701         * tui/tui.h (tui_is_window_visible): Return bool.
8702         * tui/tui.c (tui_is_window_visible): Return bool.
8703         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8704         (tui_make_visible, tui_make_invisible)
8705         (tui_win_info::make_visible)
8706         (tui_source_window_base::make_visible, make_all_visible)
8707         (tui_make_all_visible, tui_make_all_invisible): Update.
8708         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8709         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8710         bool.
8711         (struct tui_win_info, struct tui_source_window_base)
8712         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8713         * tui/tui-data.c (tui_init_generic_part): Update.
8714
8715 2019-06-25  Tom Tromey  <tom@tromey.com>
8716
8717         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8718         (tui_source_window_base::make_visible): New methods.
8719         (make_all_visible): Make method call.
8720         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8721         (struct tui_source_window_base, struct tui_cmd_window): Override
8722         make_visible.
8723         (tui_win_is_source_type): Don't declare.
8724         * tui/tui-data.c (tui_win_is_source_type): Remove.
8725
8726 2019-06-25  Tom Tromey  <tom@tromey.com>
8727
8728         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8729         NULL check.
8730
8731 2019-06-25  Tom Tromey  <tom@tromey.com>
8732
8733         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8734         Inline constructor.  Add initializers for members.
8735         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8736         constructors; now inline in class.
8737
8738 2019-06-25  Tom Tromey  <tom@tromey.com>
8739
8740         * tui/tui-regs.c (tui_show_registers): Update.
8741         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8742         bool.
8743         * tui/tui-data.c (tui_data_window::clear_detail)
8744         (tui_data_window): Update.
8745
8746 2019-06-25  Tom Tromey  <tom@tromey.com>
8747
8748         * tui/tui-windata.c (tui_display_all_data)
8749         (tui_display_data_from_line, tui_display_data_from)
8750         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8751         Update.
8752         * tui/tui-regs.c (tui_last_regs_line_no)
8753         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8754         (tui_show_registers, tui_show_register_group)
8755         (tui_display_registers_from, tui_display_reg_element_at_line)
8756         (tui_display_registers_from_line, tui_check_register_values)
8757         (tui_reg_next, tui_reg_prev): Update.
8758         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8759         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8760         tui_data_window.
8761         (struct tui_win_info) <detail>: Remove.  Add new fields from
8762         tui_data_info.
8763         (TUI_DATA_WIN): Add cast.
8764         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8765         (~tui_data_window): Simplify.
8766
8767 2019-06-25  Tom Tromey  <tom@tromey.com>
8768
8769         * tui/tui-layout.c (show_source_disasm_command)
8770         (show_source_or_disasm_and_command): Update.
8771         * tui/tui-io.c (update_cmdwin_start_line)
8772         (tui_redisplay_readline): Update.
8773         * tui/tui-data.h (struct tui_command_info): Remove.
8774         (struct tui_win_info) <detail>: Remove command_info member.
8775         (struct tui_data_window) <start_line>: New member, from
8776         tui_command_info.
8777         (TUI_CMD_WIN): Add casts.
8778
8779 2019-06-25  Tom Tromey  <tom@tromey.com>
8780
8781         * tui/tui-winsource.c (tui_update_source_window)
8782         (tui_refill_source_window)
8783         (tui_source_window_base::do_scroll_horizontal)
8784         (tui_update_breakpoint_info, tui_set_exec_info_content)
8785         (tui_show_exec_info_content, tui_erase_exec_info_content)
8786         (tui_clear_exec_info_content): Update.
8787         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8788         Update.
8789         * tui/tui-win.c (make_invisible_and_set_new_height)
8790         (make_visible_with_new_height): Update.
8791         * tui/tui-source.c (tui_set_source_content)
8792         (tui_show_symtab_source): Update.
8793         * tui/tui-layout.c (extract_display_start_addr)
8794         (show_source_disasm_command, show_data)
8795         (make_source_or_disasm_window)
8796         (show_source_or_disasm_and_command): Update.
8797         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8798         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8799         "gdbarch".
8800         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8801         to tui_source_window_base.
8802         (struct tui_win_info) <detail>: Remove source_info member.
8803         (struct tui_source_window_base) <has_locator>: Inline.
8804         Move contents from tui_source_info; rename has_locator member to
8805         m_has_locator.
8806         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8807         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8808         header file.
8809         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8810         Simplify.
8811         (tui_free_all_source_wins_content): Cast to
8812         tui_source_window_base.
8813
8814 2019-06-25  Tom Tromey  <tom@tromey.com>
8815
8816         * tui/tui-win.c (make_invisible_and_set_new_height)
8817         (make_visible_with_new_height): Call has_locator method.
8818         * tui/tui-layout.c (show_source_disasm_command, show_data)
8819         (show_source_or_disasm_and_command): Update for bool change.
8820         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8821         (tui_win_info) <has_locator>: New method.
8822         (struct tui_source_window_base) <has_locator>: New method.
8823         (tui_win_has_locator): Don't declare.
8824         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8825         from tui_win_has_locator.
8826         (tui_source_window_base): Use false, not FALSE.
8827
8828 2019-06-25  Tom Tromey  <tom@tromey.com>
8829
8830         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8831         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8832         clear_detail method directly.
8833         (tui_clear_win_detail): Remove.
8834
8835 2019-06-25  Tom Tromey  <tom@tromey.com>
8836
8837         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8838         "this", not TUI_DISASM_WIN.
8839
8840 2019-06-25  Tom Tromey  <tom@tromey.com>
8841
8842         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8843         declare.
8844         * tui/tui-winsource.c
8845         (tui_source_window_base::do_scroll_horizontal): Rename from
8846         tui_horizontal_source_scroll.
8847         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8848         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8849         from tui_vertical_data_scroll.
8850         * tui/tui-win.h (tui_scroll): Don't declare.
8851         * tui/tui-win.c (tui_win_info::forward_scroll)
8852         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8853         (tui_win_info::right_scroll): Rename and update.
8854         (tui_scroll_forward_command, tui_scroll_backward_command)
8855         (tui_scroll_left_command, tui_scroll_right_command): Update.
8856         (tui_scroll): Remove.
8857         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8858         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8859         from tui_vertical_source_scroll.
8860         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8861         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8862         from tui_vertical_disassem_scroll.
8863         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8864         do_scroll_horizontal>: New methods.
8865         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8866         Likewise.
8867         (struct tui_source_window_base): Add do_scroll_horizontal.
8868         (struct tui_source_window, struct tui_disasm_window): Add
8869         do_scroll_vertical.
8870         (struct tui_data_window, struct tui_cmd_window): Add
8871         do_scroll_horizontal and do_scroll_vertical.
8872         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8873
8874 2019-06-25  Tom Tromey  <tom@tromey.com>
8875
8876         * tui/tui-data.h (struct tui_source_window_base): New struct.
8877         (struct tui_source_window): Derive from tui_source_window_base.
8878         (struct tui_disasm_window): New struct.
8879         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8880         from tui_source_window::clear_detail.
8881         (tui_source_window_base): Rename from tui_source_window.
8882         (~tui_source_window_base): Rename from ~tui_source_window.
8883         (tui_alloc_win_info): Create a tui_disasm_window.
8884
8885 2019-06-25  Tom Tromey  <tom@tromey.com>
8886
8887         * tui/tui-data.h (struct tui_source_window)
8888         (struct tui_data_window): Declare destructors.
8889         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8890         destructors.
8891         (tui_win_info): Simplify.
8892
8893 2019-06-25  Tom Tromey  <tom@tromey.com>
8894
8895         * tui/tui-winsource.c (tui_display_main)
8896         (tui_update_source_windows_with_addr)
8897         (tui_update_all_breakpoint_info): Update.
8898         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8899         (new_height_ok, parse_scrolling_args): Update.
8900         * tui/tui-stack.c (tui_show_frame_info): Update.
8901         * tui/tui-data.h (struct tui_list): Remove.
8902         (tui_source_windows): Return a reference to a std::vector.
8903         * tui/tui-data.c (source_windows): Now a std::vector.
8904         (tui_source_windows): Change return type.
8905         (tui_clear_source_windows): Rewrite.
8906         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8907         (tui_free_all_source_wins_content): Rewrite.
8908
8909 2019-06-25  Tom Tromey  <tom@tromey.com>
8910
8911         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8912         (struct tui_data_window, struct tui_cmd_window): Declare
8913         clear_detail method.
8914         * tui/tui-data.c (tui_source_window::clear_detail)
8915         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8916         methods.
8917         (tui_clear_win_detail): Simplify.
8918
8919 2019-06-25  Tom Tromey  <tom@tromey.com>
8920
8921         * tui/tui-layout.c (make_source_window, make_disasm_window)
8922         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8923         Return the new window.
8924         (show_source_disasm_command, show_data)
8925         (show_source_or_disasm_and_command): Update.
8926
8927 2019-06-25  Tom Tromey  <tom@tromey.com>
8928
8929         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8930         parameter.  Return the new window.
8931         (show_source_disasm_command): Update and remove NULL check.
8932         (show_source_or_disasm_and_command): Update.
8933
8934 2019-06-25  Tom Tromey  <tom@tromey.com>
8935
8936         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8937
8938 2019-06-25  Tom Tromey  <tom@tromey.com>
8939
8940         * tui/tui-data.h (struct tui_win_info): Make constructor
8941         protected.  Make destructor virtual.  Add initializers.
8942         (tui_source_window, tui_data_window, tui_cmd_window): New
8943         classes.
8944         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8945         constructor.  Add "type" parameter.
8946         (tui_source_window, tui_data_window, tui_cmd_window): New
8947         constructors.
8948         (tui_alloc_win_info): Instantiate the appropriate subclass.
8949
8950 2019-06-25  Tom Tromey  <tom@tromey.com>
8951
8952         * tui/tui-win.c (tui_resize_all): Use delete.
8953         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8954         destructor.
8955         (tui_free_window): Don't declare.
8956         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8957         Update.
8958
8959 2019-06-25  Tom Tromey  <tom@tromey.com>
8960
8961         * tui/tui-data.h (struct tui_win_info): Add constructor.
8962         * tui/tui-data.c (tui_alloc_win_info): Use new.
8963         (tui_free_window): Use delete.
8964
8965 2019-06-22  Tom Tromey  <tom@tromey.com>
8966
8967         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8968         declare.
8969         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8970
8971 2019-06-22  Tom Tromey  <tom@tromey.com>
8972
8973         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8974         declare.
8975         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8976
8977 2019-06-22  Tom de Vries  <tdevries@suse.de>
8978
8979         * dwarf2read.c (create_addrmap_from_aranges)
8980         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8981         instead of '%zu'.
8982
8983 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8984
8985         * dwarf2read.h (dwarf2_section_info_def): Remove.
8986         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8987         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8988         std::vector<dwarf2_section_info>.
8989         (struct dwo_file) <~dwo_file>: Remove.
8990         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8991         types field.
8992         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8993         (dwarf2_read_debug_names): Likewise.
8994         (create_debug_types_hash_table): Change parameter type to
8995         array_view, adjust code accordingly.
8996         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8997         (partial_die_info::fixup): Likewise.
8998         (determine_prefix): Likewise.
8999         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9000
9001 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9002
9003         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9004         gdb_bfd_ref_ptr.
9005         <~dwo_file>: Remove call to gdb_bfd_unref.
9006         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9007         gdb_bfd_ref_ptr::get.
9008
9009 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9010
9011         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9012         type to htab_up.
9013         * dwarf2read.c (struct dwo_file): Initialize fields.
9014         <~dwo_file>: New.
9015         (free_dwo_file): Remove, move content to ~dwo_file.
9016         (struct dwo_file_deleter): Remove.
9017         (dwo_file_up>: Remove custom deleter.
9018         (free_dwo_files): Remove.
9019         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9020         dwo_files.
9021         (process_skeletonless_type_units): Call unique_ptr::get.
9022         (allocate_dwo_file_hash_table): Add deleter to created hash
9023         table.  Change return type to htab_up.
9024         (lookup_dwo_file_slot): Don't memset dwo_file, call
9025         unique_ptr::get.
9026         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9027         (create_dwo_unit_in_dwp_v2): Likewise.
9028         (open_and_init_dwo_file): Likewise.
9029         (free_dwo_file_from_slot): Remove.
9030
9031 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9032
9033         * dwarf2read.h (struct dwarf2_section_info) <readin,
9034         is_virtual>: Change type to bool.
9035         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9036         true instead of 1.
9037
9038 2019-06-19  Tom Tromey  <tom@tromey.com>
9039
9040         * tui/tui-data.h (tui_init_content_element): Don't declare.
9041
9042 2019-06-19  Tom Tromey  <tom@tromey.com>
9043
9044         * tui/tui-data.h (tui_init_win_info): Don't declare.
9045
9046 2019-06-19  Tom de Vries  <tdevries@suse.de>
9047
9048         * dwarf2read.h (abstract_to_concrete): Change type to
9049         std::unordered_map<sect_offset, std::vector<sect_offset>,
9050         gdb::hash_enum<sect_offset>>.
9051
9052 2019-06-19  Tom Tromey  <tromey@adacore.com>
9053
9054         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9055         EVAL_AVOID_SIDE_EFFECTS specially.
9056
9057 2019-06-19  Tom Tromey  <tromey@adacore.com>
9058
9059         * source-cache.c (highlighter): New global.
9060         (source_cache::get_source_lines): Create a highlighter on demand.
9061
9062 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9063
9064         * defs.h (deprecated_interactive_hook): Delete declaration.
9065         * interps.c (clear_interpreter_hooks): Remove use of
9066         deprecated_interactive_hook.
9067         * top.c (deprecated_interactive_hook): Delete definition.
9068         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9069
9070 2019-06-18  Tom de Vries  <tdevries@suse.de>
9071
9072         PR gdb/24515
9073         * dwarf2read.h (abstract_to_concrete): Change type from
9074         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9075         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9076         * dwarf2read.c (read_variable): Update.
9077         (dwarf2_fetch_die_loc_sect_off): Update.
9078
9079 2019-06-17  Tom de Vries  <tdevries@suse.de>
9080
9081         PR gdb/24617
9082         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9083         accessing parent[parent_len - 1].
9084
9085 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9086
9087         PR gdb/24364
9088         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9089         call dtrace_process_dof with NULL dof.
9090
9091 2019-06-16  Tom de Vries  <tdevries@suse.de>
9092
9093         PR gdb/24445
9094         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9095
9096 2019-06-16  Tom Tromey  <tom@tromey.com>
9097
9098         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9099         (make_all_visible): Use address of member.
9100
9101 2019-06-16  Tom Tromey  <tom@tromey.com>
9102
9103         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9104         (tui_free_window, free_content, free_content_elements): Remove
9105         unnecessary cast.
9106         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9107         cast.
9108         * tui/tui-regs.c (tui_show_register_group)
9109         (tui_display_registers_from, tui_display_reg_element_at_line):
9110         Remove unnecessary cast.
9111
9112 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9113
9114         * linux-nat.c (normal_mask): Delete.
9115         (_initialize_linux_nat): Don't initialise normal_mask.
9116
9117 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9118
9119         PR gdb/24445
9120         * dwarf-index-write.h (write_psymtabs_to_index): Add
9121         dwz_basename parameter.
9122         * dwarf-index-write.c (write_gdbindex): Move file writing to
9123         write_gdbindex_1.  Change return type void.
9124         (assert_file_size): Move up, remove filename parameter.
9125         (write_gdbindex_1): New function.
9126         (write_debug_names): Change return type to void, call
9127         assert_file_size.
9128         (struct index_wip_file): New struct.
9129         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9130         file logic to index_wip_file.  Write index for dwz file if
9131         needed.
9132         (save_gdb_index_command): Pass basename of dwz file, if present.
9133         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9134         build-id of dwz file, if present.
9135         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9136         (dwarf2_get_dwz_file): Likewise.
9137         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9138         (dwarf2_get_dwz_file): Likewise.
9139
9140 2019-06-16  Tom Tromey  <tom@tromey.com>
9141
9142         * coffread.c (process_coff_symbol): Use xstrdup.
9143         * value.c (create_internalvar): Use xstrdup.
9144
9145 2019-06-16  Tom Tromey  <tom@tromey.com>
9146
9147         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9148         * breakpoint.c (stopin_command, stopat_command)
9149         (until_break_command, decode_location_default): Remove unnecessary
9150         cast.
9151         * utils.c (subset_compare): Remove unnecessary cast.
9152         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9153         cast.
9154         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9155         cast.
9156         * infcmd.c (path_command): Remove unnecessary cast.
9157         * coffread.c (decode_type): Remove unnecessary cast.
9158         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9159         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9160         * tui/tui-stack.c (tui_show_locator_content)
9161         (tui_show_frame_info): Remove unnecessary cast.
9162         * tui/tui-win.c (tui_scroll_forward_command)
9163         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9164         (parse_scrolling_args): Remove unnecessary cast.
9165         * tui/tui-data.c (init_win_info, tui_del_window)
9166         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9167         (free_content_elements): Remove unnecessary cast.
9168         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9169         unnecessary cast.
9170         * tui/tui-source.c (tui_set_source_content)
9171         (tui_vertical_source_scroll): Remove unnecessary cast.
9172         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9173         cast.
9174         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9175         * tui/tui-regs.c (tui_display_registers_from)
9176         (tui_display_register): Remove unnecessary cast.
9177         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9178         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9179         (make_visible): Remove unnecessary cast.
9180         * tui/tui-winsource.c (tui_erase_source_content)
9181         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9182         unnecessary cast.
9183         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9184         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9185         * stabsread.c (read_type, read_array_type, read_range_type):
9186         Remove unnecessary cast.
9187         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9188         (parse_symbol, parse_type, upgrade_type, parse_external)
9189         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9190         unnecessary cast.
9191         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9192
9193 2019-06-16  Tom Tromey  <tom@tromey.com>
9194
9195         * tui/tui-data.c (tui_alloc_generic_win_info)
9196         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9197         checks.
9198
9199 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9200             Andrew Burgess  <andrew.burgess@embecosm.com>
9201
9202         * f-typeprint.c (f_print_type): Don't return early for not
9203         associated or not allocated types.
9204         (f_type_print_varspec_suffix): Add print_rank parameter and print
9205         ranks of array types in case they dangling.
9206         (f_type_print_base): Add print_rank parameter.
9207
9208 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9209
9210         * NEWS: Mention new MI commands.
9211         * break-catch-throw.c (enum exception_event_kind): Move to
9212         breakpoint.h.
9213         (print_mention_exception_catchpoint): Output text as a single
9214         message.
9215         (catch_exception_command_1): Rename to...
9216         (catch_exception_event): ...this, make non-static, update header
9217         command, and change some parameter types.
9218         (catch_catch_command): Update for changes to
9219         catch_exception_command_1.
9220         (catch_throw_command): Likewise.
9221         (catch_rethrow_command): Likewise.
9222         * breakpoint.c (enum exception_event_kind): Delete.
9223         * breakpoint.h (enum exception_event_kind): Moved here from
9224         break-catch-throw.c.
9225         (catch_exception_event): Declare.
9226         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9227         (mi_cmd_catch_throw): New function.
9228         (mi_cmd_catch_rethrow): New function.
9229         (mi_cmd_catch_catch): New function.
9230         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9231         'catch-catch' entries.
9232         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9233         (mi_cmd_catch_rethrow): Declare.
9234         (mi_cmd_catch_catch): Declare.
9235
9236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9237
9238         * annotate.c (annotate_source_line): Change return type to void,
9239         update implementation to match.
9240         * annotate.h (annotate_source_line): Change return type to void,
9241         update header comment.
9242         * stack.c (print_frame_info): Don't change what frame information
9243         is printed based on whether annotations are on or not.
9244
9245 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9246
9247         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9248         (annotate_source): Make static.
9249         (annotate_source_line): Moved from source.c and renamed from
9250         identify_source_line.  Update the return type.
9251         * annotate.h (annotate_source): Delete declaration.
9252         (annotate_source_line): Declaration moved from source.h, and
9253         renamed from identify_source_line.  Return type updated.
9254         * source.c (identify_source_line): Moved to annotate.c and renamed
9255         to annotate_source_line.
9256         (info_line_command): Remove check of annotation_level.
9257         * source.h (identify_source_line): Move declaration to annotate.h
9258         and rename to annotate_source_line.
9259         * stack.c: Add 'annotate.h' include.
9260         (print_frame_info): Remove check of annotation_level before
9261         calling annotate_source_line.
9262
9263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * source-cache.c (source_cache::get_plain_source_lines): Use
9266         open_source_file_with_line_charpos instead of just
9267         open_source_file, remove call to find_source_lines.
9268         (source_cache::get_source_lines): Likewise.
9269         * source.c (find_source_lines): Make static.
9270         (get_filename_and_charpos): Renamed into...
9271         (open_source_file_with_line_charpos): ..this along with changes to
9272         return a scoped_fd, and some other minor clean ups.
9273         (identify_source_line): Use open_source_file_with_line_charpos.
9274         (search_command_helper): Use open_source_file_with_line_charpos
9275         instead of just open_source_file, remove call to
9276         find_source_lines.
9277         * source.h (open_source_file_with_line_charpos): Declare new
9278         function.
9279         (find_source_lines): Delete declaration.
9280
9281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9282
9283         * source.c (get_filename_and_charpos): Remove fullname
9284         parameter.
9285         (identify_source_line): Update call to get_filename_and_charpos.
9286
9287 2019-06-14  Tom Tromey  <tromey@adacore.com>
9288
9289         PR gdb/24502:
9290         * ui-style.h (skip_ansi_escape): Update comment.
9291         * ui-file.h (class no_terminal_escape_file): New class.
9292         * ui-file.c (no_terminal_escape_file::write)
9293         (no_terminal_escape_file::puts): New methods.
9294         * cli/cli-logging.c (handle_redirections): Use
9295         no_terminal_escape_file.
9296
9297 2019-06-14  Tom Tromey  <tromey@adacore.com>
9298
9299         * NEWS: Move convenience variable news above Python news.
9300
9301 2019-06-14  Tom Tromey  <tom@tromey.com>
9302
9303         * gnulib: Move directory to top-level.
9304         * configure.ac: Don't configure gnulib.
9305         * configure: Rebuild.
9306         * common/common-defs.h: Use new path to gnulib.
9307         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9308         (GNULIB_H): Remove.
9309         (INCGNU): Look in new gnulib location.
9310         (HFILES_NO_SRCDIR): Remove gnulib files.
9311         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9312         (generated_files): Remove GNULIB_H.
9313         ($(LIBGNU), all-lib): Remove targets.
9314         (distclean): Don't mention GNULIB_BUILDDIR.
9315         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9316
9317 2019-06-14  Tom Tromey  <tromey@adacore.com>
9318
9319         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9320         Warn if symbol file does not provide any symbols.
9321
9322 2019-06-14  Tom Tromey  <tromey@adacore.com>
9323
9324         * source.c (find_and_open_source): Respect basenames_may_differ.
9325
9326 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * annotate.c (annotate_breakpoints_invalid): Make use of
9329         scoped_restore_terminal_state.
9330         (annotate_frames_invalid): Likewise.
9331
9332 2019-06-14  Tom Tromey  <tromey@adacore.com>
9333
9334         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9335         allow assignment to an internalvar.
9336
9337 2019-06-14  Tom Tromey  <tromey@adacore.com>
9338
9339         * ada-lex.l: Allow "_" in attribute names.
9340
9341 2019-06-14  Tom Tromey  <tromey@adacore.com>
9342
9343         PR gdb/24653:
9344         * regcache.c (registers_changed): Don't call alloca.
9345         * top.c (execute_command): Don't call alloca.
9346
9347 2019-06-13  Pedro Alves  <palves@redhat.com>
9348
9349         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9350         'expression'.  When parsing an expression, error out if there's
9351         junk after "unlimited".
9352         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9353         (do_set_command): Adjust calls to is_unlimited_literal.
9354
9355 2019-06-13  Pedro Alves  <palves@redhat.com>
9356
9357         * compile/compile.c (make_compile_options_def_group): Add braces
9358         around array_view initializer.
9359         * thread.c (make_thread_apply_all_options_def_group)
9360         (make_thread_apply_all_options_def_group): Likewise.
9361
9362 2019-06-13  Pedro Alves  <palves@redhat.com>
9363
9364         * NEWS (New commands): Mention "maint test-options
9365         require-delimiter", "maint test-options unknown-is-error", "maint
9366         test-options unknown-is-operand" and "maint show
9367         test-options-completion-result".
9368         (New command options, command completion): New section.
9369         (Completion improvements): New section.
9370         Mention that you can abbreviate "unlimited".
9371
9372 2019-06-13  Pedro Alves  <palves@redhat.com>
9373
9374         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9375         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9376         * unittests/cli-utils-selftests.c (test_parse_flags)
9377         (test_parse_flags_qcs): Delete.
9378         (test_cli_utils): Don't call deleted functions.
9379
9380 2019-06-13  Pedro Alves  <palves@redhat.com>
9381
9382         * thread.c: Include "cli/cli-option.h".
9383         (tp_array_compar_ascending): Global.
9384         (tp_array_compar): Delete function.
9385         (tp_array_compar_ascending, tp_array_compar_descending): New
9386         functions.
9387         (ascending_option_def, qcs_flag_option_def)
9388         (thr_qcs_flags_option_defs)
9389         (make_thread_apply_all_options_def_group)
9390         (make_thread_apply_options_def_group): New.
9391         (thread_apply_all_command): Use gdb::option::process_options.
9392         (thread_apply_command_completer)
9393         (thread_apply_all_command_completer): New.
9394         (thread_apply_command): Use gdb::option::process_options.
9395         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9396         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9397         to generate help text of "thread apply".  Adjust "taas"'s help.
9398         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9399         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9400
9401 2019-06-13  Pedro Alves  <palves@redhat.com>
9402
9403         * thread.c (thread_apply_command): Check for invalid TID with
9404         isdigit instead of !isalpha.
9405
9406 2019-06-13  Pedro Alves  <palves@redhat.com>
9407
9408         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9409         (validate_flags_qcs): New.
9410         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9411         (validate_flags_qcs): Declare.
9412         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9413         (make_frame_apply_options_def_group): New.
9414         (frame_apply_command_count): Process options with
9415         gdb::option::process_options.
9416         (frame_apply_completer): New.
9417         (frame_apply_level_completer, frame_apply_all_completer)
9418         (frame_apply_completer): New.
9419         (_initialize_stack): Update help of "frame apply", "frame apply
9420         level", "frame apply all" and "faas" to mention supported options
9421         and install command completers.
9422         * stack.h (frame_apply_all_completer): Declare.
9423         * thread.c: Include "stack.h".
9424         (tfaas_command): Add "--".
9425         (_initialize_thread): Update help "tfaas" to mention supported
9426         options and install command completer.
9427
9428 2019-06-13  Pedro Alves  <palves@redhat.com>
9429
9430         * completer.c (complete_nested_command_line): New.
9431         (gdb_completion_word_break_characters_throw): Add assertion.
9432         * completer.h (complete_nested_command_line): Declare.
9433
9434 2019-06-13  Pedro Alves  <palves@redhat.com>
9435
9436         * stack.c (parse_backtrace_qualifiers): New.
9437         (backtrace_command): Use it.
9438         (backtrace_command_completer): Complete on qualifiers.
9439
9440 2019-06-13  Pedro Alves  <palves@redhat.com>
9441
9442         * frame.c: Include "cli/cli-option.h.
9443         (user_set_backtrace_options): New.
9444         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9445         Delete.
9446         (get_prev_frame): Adjust.
9447         (boolean_option_def, uinteger_option_def)
9448         (set_backtrace_option_defs): New.
9449         (_initialize_frame): Adjust and use
9450         gdb::option::add_setshow_cmds_for_options to install "set
9451         backtrace past-main" and "set backtrace past-entry".
9452         * frame.h: Include "cli/cli-option.h".
9453         (struct frame_print_options): Forward declare.
9454         (print_frame_arguments_all, print_frame_arguments_scalars)
9455         (print_frame_arguments_none): Declare.
9456         (print_entry_values): Delete declaration.
9457         (struct frame_print_options, user_frame_print_options): New.
9458         (struct set_backtrace_options): New.
9459         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9460         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9461         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9462         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9463         (list_args_or_locals): Add frame_print_options parameter.
9464         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9465         * python/py-framefilter.c (enumerate_args): Pass down
9466         USER_FRAME_PRINT_OPTIONS.
9467         * stack.c: Include "cli/cli-option.h".
9468         (print_frame_arguments_all, print_frame_arguments_scalars)
9469         (print_frame_arguments_none): Declare.
9470         (print_raw_frame_arguments, print_entry_values): Delete.
9471         (user_frame_print_options): New.
9472         (boolean_option_def, enum_option_def, frame_print_option_defs):
9473         New.
9474         (struct backtrace_cmd_options): New.
9475         (bt_flag_option_def): New.
9476         (backtrace_command_option_defs): New.
9477         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9478         (print_frame_arg, read_frame_arg, print_frame_args)
9479         (print_frame_info, print_frame): Add frame_print_options parameter
9480         and use it.
9481         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9482         (backtrace_command_1): Add frame_print_options and
9483         backtrace_cmd_options parameters and use them.
9484         (make_backtrace_options_def_group): New.
9485         (backtrace_command): Process command options with
9486         gdb::option::process_options.
9487         (backtrace_command_completer): New.
9488         (_initialize_stack): Extend "backtrace"'s help to mention
9489         supported options.  Install completer for "backtrace".
9490         Install some settings commands with add_setshow_cmds_for_options.
9491
9492 2019-06-13  Pedro Alves  <palves@redhat.com>
9493
9494         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9495         and that "set/show print raw frame-arguments" are now deprecated.
9496
9497         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9498         command.
9499         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9500         * stack.c (_initialize_stack): Install "set/show print
9501         raw-frame-arguments", and deprecate "set/show print raw
9502         frame-arguments".
9503         * valprint.c (_initialize_valprint): Deprecate "set/show print
9504         raw".
9505
9506 2019-06-13  Pedro Alves  <palves@redhat.com>
9507
9508         * compile/compile.c (struct compile_options): New.
9509         (compile_flag_option_def, compile_command_option_defs)
9510         (make_compile_options_def_group): New.
9511         (compile_file_command): Handle options with
9512         gdb::option::process_options.
9513         (compile_file_command_completer): New function.
9514         (compile_code_command): Handle options with
9515         gdb::option::process_options.
9516         (compile_code_command_completer): New function.
9517         (_initialize_compiler): Install completers for "compile code" and
9518         "compile file".  Mention available options in "compile code" and
9519         "compile code"'s help.
9520         * completer.c (advance_to_completion_word): New, factored out from
9521         ...
9522         (advance_to_expression_complete_word_point): ... this.
9523         (advance_to_filename_complete_word_point): New.
9524         * completer.h (advance_to_filename_complete_word_point): New
9525         declaration.
9526
9527 2019-06-13  Pedro Alves  <palves@redhat.com>
9528
9529         * compile/compile.c: Include "cli/cli-option.h".
9530         (compile_print_value): Scope data pointer is now a
9531         value_print_options pointer; adjust.
9532         (compile_print_command): Process options.  Scope data pointer is
9533         now a value_print_options pointer; adjust.
9534         (_initialize_compile): Update "compile print"'s help to include
9535         supported options.  Install a completer for "compile print".
9536         * cp-valprint.c (show_vtblprint, show_objectprint)
9537         (show_static_field_print): Delete.
9538         (_initialize_cp_valprint): Don't install "set print
9539         static-members", "set print vtbl", "set print object" here.
9540         * printcmd.c: Include "cli/cli-option.h" and
9541         "common/gdb_optional.h".
9542         (print_command_parse_format): Rework to fill in a
9543         value_print_options instead of a format_data.
9544         (print_value): Change parameter type from format_data pointer to
9545         value_print_options reference.  Adjust.
9546         (print_command_1): Process options.  Adjust to pass down a
9547         value_print_options.
9548         (print_command_completer): New.
9549         (_initialize_printcmd): Install print_command_completer as
9550         handle_brkchars completer for the "print" command.  Update
9551         "print"'s help to include supported options.
9552         * valprint.c: Include "cli/cli-option.h".
9553         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9554         here from cp-valprint.c.
9555         (boolean_option_def, uinteger_option_def)
9556         (value_print_option_defs, make_value_print_options_def_group):
9557         New.  Use gdb::option::add_setshow_cmds_for_options to install
9558         "set print elements", "set print null-stop", "set print repeats",
9559         "set print pretty", "set print union", "set print array", "set
9560         print address", "set print symbol", "set print array-indexes".
9561         * valprint.h: Include <string> and "cli/cli-option.h".
9562         (make_value_print_options_def_group): Declare.
9563         (print_value): Change parameter type from format_data pointer to
9564         value_print_options reference.
9565         (print_command_completer): Declare.
9566
9567 2019-06-13  Pedro Alves  <palves@redhat.com>
9568
9569         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9570         (COMMON_SFILES): Add maint-test-settings.c.
9571         * cli/cli-decode.c (boolean_enums): New global, factored out from
9572         ...
9573         (add_setshow_boolean_cmd): ... here.
9574         * cli/cli-decode.h (boolean_enums): Declare.
9575         * cli/cli-option.c: New file.
9576         * cli/cli-option.h: New file.
9577         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9578         factored out from ...
9579         (parse_cli_boolean_value(const char *)): ... this.
9580         (is_unlimited_literal): Change parameter type to pointer to
9581         pointer.  Adjust and advance ARG pointer.
9582         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9583         (parse_cli_var_enum): New, factored out from ...
9584         (do_set_command): ... this.  Adjust.
9585         * cli/cli-setshow.h (parse_cli_boolean_value)
9586         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9587         (parse_cli_var_enum): Declare.
9588         * cli/cli-utils.c: Include "cli/cli-option.h".
9589         (get_ulongest): New.
9590         * cli/cli-utils.h (get_ulongest): Declare.
9591         (check_for_argument): New overloads.
9592         * maint-test-options.c: New file.
9593
9594 2019-06-13  Pedro Alves  <palves@redhat.com>
9595
9596         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9597         parse a range if "-" is at the end of the string.
9598
9599 2019-06-13  Pedro Alves  <palves@redhat.com>
9600
9601         * cli/cli-setshow.c (parse_auto_binary_operation)
9602         (parse_cli_boolean_value): Don't allow "o".
9603
9604 2019-06-13  Pedro Alves  <palves@redhat.com>
9605
9606         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9607         * NEWS: Mention maint test-settings KIND.
9608         * maint-test-settings.c: New file.
9609
9610 2019-06-13  Pedro Alves  <palves@redhat.com>
9611
9612         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9613         completer.
9614         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9615         "set" completers.
9616
9617 2019-06-13  Pedro Alves  <palves@redhat.com>
9618
9619         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9620         after item.
9621
9622 2019-06-13  Pedro Alves  <palves@redhat.com>
9623
9624         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9625
9626 2019-06-13  Pedro Alves <palves@redhat.com>
9627
9628         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9629         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9630         call.
9631         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9632         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9633         calls.
9634         (check_for_argument): Skip spaces after argument.
9635
9636 2019-06-13  Pedro Alves  <palves@redhat.com>
9637
9638         * thread.c (thread_apply_command): Adjust TID parsing.
9639         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9640         detected before end of string.
9641         (tid_is_in_list): Error out if LIST is invalid.
9642
9643 2019-06-13  Pedro Alves  <palves@redhat.com>
9644
9645         * completer.c (complete_line_internal_1): Rewind completion word
9646         point.
9647         (completion_tracker::advance_custom_word_point_by): Change
9648         parameter type to int.
9649         * completer.h (completion_tracker::advance_custom_word_point_by):
9650         Likewise.
9651
9652 2019-06-13  Pedro Alves  <palves@redhat.com>
9653
9654         * completer.c (advance_to_completion_word): Handle delimiters.
9655
9656 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9657
9658         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9659
9660 2019-06-11  Tom Tromey  <tom@tromey.com>
9661
9662         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9663         (xmalloc_failed): Move to alloc.c.
9664         * alloc.c: New file.
9665         * Makefile.in (COMMON_SFILES): Add alloc.c.
9666
9667 2019-06-11  Tom Tromey  <tom@tromey.com>
9668
9669         * nat/linux-waitpid.c: Don't include server.h.
9670         (linux_debug): Remove.
9671         (my_waitpid): Update.
9672
9673 2019-06-11  Tom Tromey  <tromey@adacore.com>
9674
9675         * infcall.c (_initialize_infcall): Remove trailing newline from
9676         help.
9677         * user-regs.c (_initialize_user_regs): Remove trailing newline
9678         from help.
9679         * typeprint.c (_initialize_typeprint): Remove trailing newline
9680         from help.
9681         * reverse.c (_initialize_reverse): Remove trailing newlines from
9682         help.
9683         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9684         from help.
9685         * language.c (add_set_language_command): Remove trailing newline
9686         from help.
9687         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9688         help.
9689         * disasm.c (_initialize_disasm): Remove trailing newline from
9690         help.
9691         * top.c (init_main): Remove trailing newline from help.
9692         * interps.c (_initialize_interpreter): Remove trailing newline
9693         from help.
9694         * btrace.c (_initialize_btrace): Remove trailing newlines from
9695         help.
9696         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9697         from help.
9698         * python/python.c (_initialize_python): Remove trailing newline
9699         from help.
9700         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9701         help.
9702         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9703         from help.  Reformat some text.
9704         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9705         from help.
9706         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9707         newline from help.
9708
9709 2019-06-11  Tom Tromey  <tromey@adacore.com>
9710
9711         * darwin-nat.c (darwin_decode_exception_message)
9712         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9713
9714 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9715
9716         * valops.c (value_slice): Check for not allocated or not
9717         associated values.
9718
9719 2019-06-10  Tom de Vries  <tdevries@suse.de>
9720
9721         PR gdb/24618
9722         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9723         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9724         invalid.
9725
9726 2019-06-10  Tom de Vries  <tdevries@suse.de>
9727
9728         PR gdb/24611
9729         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9730         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9731
9732 2019-06-10  Tom de Vries  <tdevries@suse.de>
9733
9734         PR symtab/24545
9735         * symtab.c (struct demangled_name_entry): Add language field.
9736         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9737         static minimal symbol".  Set and use language field.
9738
9739 2019-06-10  Tom Tromey  <tromey@adacore.com>
9740
9741         * ada-lang.c (_initialize_ada_language): Update help text.
9742
9743 2019-06-10  Tom Tromey  <tromey@adacore.com>
9744
9745         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9746         with a newline.
9747         * guile/guile.c (handle_boot_error): Don't end warning with a
9748         newline.
9749         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9750         warning with a newline.
9751         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9752         newline.
9753         (s12z_frame_cache): Likewise.
9754         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9755         a newline.
9756         * solib-svr4.c (disable_probes_interface): Don't end warning with
9757         a newline.
9758         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9759         newline.
9760         * python/python.c (do_finish_initialization): Don't end warning
9761         with a newline.
9762
9763 2019-06-10  Tom Tromey  <tom@tromey.com>
9764
9765         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9766         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9767         gdbpy_enter.
9768
9769 2019-06-10  Tom Tromey  <tromey@adacore.com>
9770
9771         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9772         data.
9773         (elf_new_init): Don't call stabsread_new_init.
9774         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9775         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9776         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9777
9778 2019-06-10  Tom de Vries  <tdevries@suse.de>
9779
9780         PR symtab/16264
9781         PR symtab/24517
9782         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9783
9784 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9785
9786         * source.c (find_and_open_source): Also rewrite relative file
9787         names.
9788
9789 2019-04-26  Amos Bird  <amosbird@gmail.com>
9790
9791         * annotate.c (annotate_thread_exited): Add "thread-exited"
9792         annotation.
9793
9794 2019-06-06  Tom Tromey  <tromey@adacore.com>
9795
9796         * maint.h (class scoped_command_stats): Use
9797         DISABLE_COPY_AND_ASSIGN.
9798         <print_time>: New method.
9799         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9800         print_time.
9801         (scoped_command_stats::print_time): New method.
9802
9803 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9804
9805         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9806         instructions of lengths 6 or 8 bytes.
9807
9808 2019-06-04  Pedro Alves  <palves@redhat.com>
9809
9810         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9811
9812         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9813         * breakpoint.c (condition_completer): Likewise.
9814         * cli/cli-dump.c (scan_expression): Likewise.
9815         * common/filestuff.c (mkdir_recursive): Likewise.
9816         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9817         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9818         (gdb_abspath): Likewise.
9819         * compile/compile-cplus-types.c
9820         (compile_cplus_instance::decl_name): Likewise.
9821         * completer.c (complete_explicit_location):
9822         (signal_completer, reg_or_group_completer_1): Likewise.
9823         * cp-support.c (cp_remove_params_if_any): Likewise.
9824         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9825         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9826         * infcmd.c (strip_bg_char): Likewise.
9827         * linespec.c (copy_token_string): Likewise.
9828         * mi/mi-main.c (output_cores): Likewise.
9829         * psymtab.c (psymtab_search_name):
9830         * symfile.c (test_set_ext_lang_command): Likewise.
9831         * target.c (target_fileio_read_stralloc): Likewise.
9832         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9833         * value.c (complete_internalvar): Likewise.
9834
9835 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9836
9837         Add objfile property to gdb.Type.
9838         * NEWS: Mention Python API addition.
9839         * python/py-type.c (typy_get_objfile): New method.
9840
9841 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9842
9843         * NEWS: Mention the new set|show style [title|highlight].
9844         Mention changes to "show style", "help" and "apropos".
9845
9846 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9847
9848         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9849         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9850         instead of print_help_for_command.
9851         (print_doc_of_command): New function.
9852         (help_list): Add 'apropos -v word' suggestion.
9853         (print_help_for_command): Style the command name using title style.
9854         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9855         (_initialize_cli_cmds): Describe -v in apropos_command help.
9856
9857 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9858
9859         * cli/cli-style.h (cli_style_option): Add name in constructor,
9860         add m_name class member, add constructor with intensity,
9861         add name class function.
9862         (cli_style_option::add_setshow_commands): Remove name argument.
9863         (highlight_style, title_style): New styles.
9864         * cli/cli-style.c (do_show): New function that shows a style
9865         characteristic styling the style name with itself.
9866         (set_style_name): New function.
9867         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9868         Update all callers according to the changes in cli/cli-style.h.
9869         * utils.h (fputs_highlighted): New function.
9870         * utils.c (fputs_highlighted): Likewise.
9871
9872 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9873
9874         * NEWS: Mention new pipe command and new convenience variables.
9875
9876 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9877
9878         * cli/cli-cmds.c (pipe_command): New function.
9879         (_initialize_cli_cmds): Call add_com for pipe_command.
9880         Define | as an alias for pipe.
9881         (exit_status_set_internal_vars): New function.
9882         (shell_escape): Call exit_status_set_internal_vars.
9883         cli/cli-decode.c (find_command_name_length): Recognize | as
9884         a single character command.
9885
9886 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9887
9888         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9889         top.c (execute_command_to_ui_file): New function, mostly a copy
9890         of execute_command_to_string.
9891         (execute_command_to_string): Implement by calling
9892         execute_command_to_ui_file.
9893
9894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9895
9896         * top.h (saved_command_line): Remove declaration.
9897         * top.c (previous_saved_command_line, previous_repeat_arguments):
9898         New variables.
9899         (saved_command_line): Make static, define together with other
9900         'repeat variables'.
9901         (dont_repeat): Clear repeat_arguments.
9902         (repeat_previous, get_saved_command_line, save_command_line):
9903         New functions.
9904         (gdb_init): Initialize saved_command_line
9905         and previous_saved_command_line.
9906         * main.c (captured_main_1): Remove saved_command_line initialization.
9907         * event-top.c (handle_line_of_input): Update to use
9908         the new 'repeat' related functions instead of direct access to
9909         saved_command_line.
9910         * command.h (repeat_previous, get_saved_command_line,
9911         save_command_line): New declarations.
9912         (dont_repeat): Add comment.
9913
9914 2019-05-30  Tom Tromey  <tromey@adacore.com>
9915
9916         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9917         Fix comment.
9918         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9919
9920 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9921
9922         PR cli/24587
9923         * completer.c (complete): Initialize variable word.
9924
9925 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9926
9927         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9928         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9929         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9930         'body' is NULL to the outter 'if', protecting the '!is_define'
9931         situation as well.
9932
9933 2019-05-29  Tom Tromey  <tromey@adacore.com>
9934
9935         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9936         (dwarf_unknown): New function.
9937         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9938         (dwarf_type_encoding_name): Use dwarf_unknown.
9939
9940 2019-05-29  Tom Tromey  <tromey@adacore.com>
9941
9942         PR c++/20020:
9943         * cp-valprint.c (cp_print_value_fields): Call
9944         cp_print_static_field inside "try".
9945
9946 2019-05-29  Tom Tromey  <tromey@adacore.com>
9947
9948         * inflow.c (struct terminal_info): Add default operator=.
9949         * configure: Rebuild.
9950         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9951         -Wdeprecated-copy-dtor, -Wredundant-move.
9952
9953 2019-05-29  Tom Tromey  <tromey@adacore.com>
9954
9955         * NEWS: Add entry.
9956         * infcmd.c (print_return_value_1): Handle finish_print
9957         option.
9958         (show_print_finish): New function.
9959         (_initialize_infcmd): Add "set/show print finish" commands.
9960         * valprint.c (user_print_options): Initialize new member.
9961         * valprint.h (struct value_print_options) <finish_print>: New
9962         member.
9963
9964 2019-05-28  Tom Tromey  <tromey@adacore.com>
9965
9966         * ada-lang.c (ada_remove_Xbn_suffix)
9967         (find_old_style_renaming_symbol)
9968         (parse_old_style_renaming): Remove.
9969         (ada_find_renaming_symbol): Don't call
9970         find_old_style_renaming_symbol.
9971         (ada_is_renaming_symbol): Rename from
9972         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9973         bool.  Now static.
9974         (ada_read_var_value): Update and simplify.
9975         * ada-exp.y (write_var_or_type): Remove old code.
9976
9977 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9978
9979         PR gdb/25010
9980         * event-top.c: Remove include comment.
9981         * inflow.c (class scoped_ignore_sigttou): Move from here...
9982         * inflow.h (class scoped_ignore_sigttou): ...to here.
9983         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9984         * top.c:  Remove include comment.
9985
9986 2019-05-27  Tom Tromey  <tom@tromey.com>
9987
9988         * NEWS: Fix typo.
9989
9990 2019-05-22  Tom Tromey  <tromey@adacore.com>
9991
9992         * target.c (target_follow_exec): Constify parameter.
9993         * target-delegates.c: Rebuild.
9994         * remote.c (remote_target::follow_exec): Constify parameter.
9995         * infrun.c (follow_exec): Constify parameter.
9996         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9997         (target_follow_exec): Likewise.
9998
9999 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10000
10001         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10002         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10003
10004 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10005
10006         * NEWS: Add debugredirect and testsuite sections.
10007
10008 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10009
10010         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10011         target descriptions using exclusively floating point register name
10012         aliases.
10013
10014 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10015
10016         PR gdb/18644:
10017         * f-lang.c (build_fortran_types): Handle the case where
10018         gdbarch_floatformat_for_type returns a nullptr.
10019
10020 2019-05-21  Tom de Vries  <tdevries@suse.de>
10021
10022         PR cli/24587
10023         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10024
10025 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10026
10027         PR gdb/18644:
10028         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10029         16-byte floats.
10030         * i386-tdep.c (i386_floatformat_for_type): Use
10031         floatformats_ia64_quad for the 16-byte floating point component
10032         within a fortran 32-byte complex number.
10033
10034 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10035
10036         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10037         delete default constructor.
10038         (find_partial_die): Update to return const struct.
10039         (partial_die_parent_scope): Move variable declaration into scope
10040         of its use and change its type to auto.
10041         (guess_partial_die_structure_name): Likewise.
10042         (partial_die_info::fixup): Likewise.
10043
10044 2019-05-17  Tom Tromey  <tromey@adacore.com>
10045
10046         * source.c (find_and_open_source): Remove cast.
10047
10048 2019-05-17  Tom Tromey  <tromey@adacore.com>
10049
10050         * annotate.c (annotate_source): Make "filename" const.
10051         * annotate.h (annotate_source): Use const.
10052
10053 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10054
10055         * disasm.c (set_disassembler_options): Send errors to stderr.
10056
10057 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10058
10059         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10060         (cli_interp_base::set_logging): Check debug_redirect.
10061         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10062         * cli/cli-logging.c (debug_redirect): Add static variable.
10063         (pop_output_files): Add default param.
10064         (handle_redirections): Print debug setting.
10065         (show_logging_command): Likewise.
10066         (_initialize_cli_logging): Add debugredirect command.
10067         * interps.c (current_interp_set_logging): Add debug_redirect
10068         parameter.
10069         * interps.h (set_logging): Add debug_redirect parameter.
10070         (current_interp_set_logging): Likewise.
10071         * mi/mi-common.h: Likewise.
10072         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10073
10074 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10075             Tom Tromey  <tromey@adacore.com>
10076
10077         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10078         directly.
10079         * cli/cli-interp.h (make_logging_output): Remove declaration.
10080         * cli/cli-logging.c (make_logging_output): Remove function.
10081         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10082         directly.
10083         * ui-file.c (tee_file::tee_file): Remove bools.
10084         (tee_file::~tee_file): Remove deletes.
10085         * ui-file.h (tee_file): Remove bools.
10086
10087 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10088
10089         * mi/mi-cmds.h (mi_cmd_complete): New function.
10090         * mi/mi-main.c (mi_cmd_complete): Likewise.
10091         * mi/mi-cmds.c: Define new MI command -complete.
10092         * NEWS: Mention new -complete command.
10093
10094 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10095
10096         * completer.h (complete): New function.
10097         * completer.c (complete): Likewise.
10098         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10099         function defined in completer.h.
10100
10101 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10102
10103         * MAINTAINERS (Write After Approval): Add myself.
10104
10105 2019-05-17  Tom de Vries  <tdevries@suse.de>
10106
10107         PR gdb/24094
10108         * dwarf2read.c (struct cu_partial_die_info): New struct.
10109         (find_partial_die): Return cu_partial_die_info.
10110         (partial_die_parent_scope, guess_partial_die_structure_name)
10111         (partial_die_info::fixup): Handle new return type of find_partial_die.
10112
10113 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10114
10115         PR breakpoints/24541
10116         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10117         "std::string", simplifying the algorithm.
10118
10119 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10120
10121         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10122         (stap_static_probe_ops::get_probes): Likewise.
10123
10124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10125
10126         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10127         '-')" and "else if".
10128         (stap_parse_single_operand): Join checks for
10129         "gdbarch_stap_parse_special_token_p" and
10130         "gdbarch_stap_parse_special_token" in the same "if" statement.
10131         Invert check when verifying for operation on register
10132         displacement.
10133
10134 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10135
10136         * stap-probe.c (stap_get_opcode): Update comment.
10137         (stap_get_expected_argument_type): Likewise.
10138         (handle_stap_probe): Likewise.
10139
10140 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10141
10142         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10143         return type to 'bool'.  Adjust comment.  Use 'bool' when
10144         appropriate.
10145         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10146         * stap-probe.c (stap_parse_argument_1): Likewise.
10147         (stap_is_operator): Likewise.
10148         (stap_is_generic_prefix): Likewise.
10149         (stap_is_register_prefix): Likewise.
10150         (stap_is_register_indirection_prefix): Likewise.
10151         (stap_is_integer_prefix): Likewise.
10152         (stap_generic_check_suffix): Likewise.
10153         (stap_check_integer_suffix): Likewise.
10154         (stap_check_register_suffix): Likewise.
10155         (stap_check_register_indirection_suffix): Likewise.
10156         (stap_parse_register_operand): Likewise.
10157         (stap_parse_single_operand): Likewise.
10158         (stap_parse_argument_1): Likewise.
10159         (stap_probe::get_argument_count): Likewise.
10160         (stap_is_operator): Likewise.
10161
10162 2019-05-16  Tom Tromey  <tromey@adacore.com>
10163
10164         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10165         keyword to foreach.
10166
10167 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10168
10169         * linux-thread-db.c (try_thread_db_load_1): Change return type
10170         to bool.
10171         (try_thread_db_load): Likewise.
10172         (try_thread_db_load_from_pdir_1): Likewise.
10173         (try_thread_db_load_from_pdir): Likewise.
10174         (try_thread_db_load_from_sdir): Likewise.
10175         (try_thread_db_load_from_dir): Likewise.
10176         (thread_db_load_search): Likewise.
10177         (has_libpthread): Likewise.
10178         (thread_db_load): Likewise.
10179
10180 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10181
10182         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10183         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10184         NULL, and complain/return if that's the case.
10185
10186 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10187
10188         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10189         (advance, posn, abstract_read_memory): New functions.
10190         [struct mem_read_abstraction]: New struct.
10191         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10192
10193 2019-05-14  Tom Tromey  <tromey@adacore.com>
10194
10195         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10196         value is not lval_memory.
10197
10198 2019-05-14  Tom Tromey  <tromey@adacore.com>
10199
10200         * solib.c (info_sharedlibrary_command): Style the file name.
10201
10202 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10203
10204         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10205         (aarch64_vnv_type): Likewise.
10206         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10207         * common/tdesc.c: Likewise.
10208         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10209         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10210         * features/aarch64-fpu.xml: Add ieee half view.
10211         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10212         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10213         * gdbtypes.h (struct builtin_type): Likewise.
10214         (struct objfile_type): Likewise.
10215
10216 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10217
10218         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10219         typo.
10220         * location.h (string_to_event_location): Likewise.
10221
10222 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10223
10224         GDB 8.3 released.
10225
10226 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10227
10228         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10229         New variable declaration.
10230         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10231         New variable.
10232         (print_one_breakpoint): Use ui_out::test_flags and new global
10233         variable to compute use_fixed_output.
10234         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10235         Remove.
10236         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10237         (mi_multi_location_breakpoint_output_fixed): Remove.
10238         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10239         new variable.
10240         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10241         fix_multi_location_breakpoint_output flag if version >= 3.
10242         * ui-out.h (enum ui_out_flag)
10243         <fix_multi_location_breakpoint_output>: New enumerator.
10244
10245 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10246
10247         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10248
10249 2019-05-10  Tom Tromey  <tromey@adacore.com>
10250
10251         * ada-lang.c (catch_ada_completer): New function.
10252         (_initialize_ada_language): Use it.
10253
10254 2019-05-10  Tom Tromey  <tromey@adacore.com>
10255
10256         * thread.c (print_thread_info): Make "requested_threads" const.
10257         * gdbthread.h (print_thread_info): Make "requested_threads"
10258         const.
10259         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10260         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10261
10262 2019-05-08  Tom Tromey  <tom@tromey.com>
10263
10264         * gdbtypes.c (objfile_type_data): Change type.
10265         (objfile_type, _initialize_gdbtypes): Update.
10266
10267 2019-05-08  Tom Tromey  <tom@tromey.com>
10268
10269         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10270         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10271         (_initialize_dwarf2_frame): Update.
10272
10273 2019-05-08  Tom Tromey  <tom@tromey.com>
10274
10275         * objc-lang.c (objc_objfile_data): Change type.
10276         (find_methods): Update.
10277         (_initialize_objc_lang): Remove.
10278
10279 2019-05-08  Tom Tromey  <tom@tromey.com>
10280
10281         * stabsread.c (rs6000_builtin_type_data): Change type.
10282         (rs6000_builtin_type, _initialize_stabsread): Update.
10283
10284 2019-05-08  Tom Tromey  <tom@tromey.com>
10285
10286         * mips-tdep.c (mips_pdr_data): Remove.
10287         (_initialize_mips_tdep): Update.
10288
10289 2019-05-08  Tom Tromey  <tom@tromey.com>
10290
10291         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10292         (hppa_init_objfile_priv_data, read_unwind_info)
10293         (find_unwind_entry, _initialize_hppa_tdep): Update.
10294
10295 2019-05-08  Tom Tromey  <tom@tromey.com>
10296
10297         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10298         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10299         on obstack.
10300         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10301
10302 2019-05-08  Tom Tromey  <tom@tromey.com>
10303
10304         * mdebugread.c (basic_type_data): Change type.
10305         (basic_type, _initialize_mdebugread): Update.
10306
10307 2019-05-08  Tom Tromey  <tom@tromey.com>
10308
10309         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10310
10311 2019-05-08  Tom Tromey  <tom@tromey.com>
10312
10313         * nto-tdep.c (nto_inferior_data_reg): Change type.
10314         (nto_inferior_data): Update.
10315         (nto_inferior_data_cleanup, nto_new_inferior_data)
10316         (_initialize_nto_tdep): Remove.
10317         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10318
10319 2019-05-08  Tom Tromey  <tom@tromey.com>
10320
10321         * ada-lang.c (struct ada_inferior_data): Add initializers.
10322         (ada_inferior_data): Change type.
10323         (ada_inferior_data_cleanup): Remove.
10324         (get_ada_inferior_data, ada_inferior_exit)
10325         (struct ada_pspace_data): Add initializers, destructor.
10326         (ada_pspace_data_handle): Change type.
10327         (get_ada_pspace_data): Update.
10328         (ada_pspace_data_cleanup): Remove.
10329
10330 2019-05-08  Tom Tromey  <tom@tromey.com>
10331
10332         * coffread.c (struct coff_symfile_info): Add initializers.
10333         (coff_objfile_data_key): Move lower.  Change type.
10334         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10335         Update.
10336         (coff_free_info): Remove.
10337
10338 2019-05-08  Tom Tromey  <tom@tromey.com>
10339
10340         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10341         (fbsd_pspace_data_handle): Move lower.  Change type.
10342         (get_fbsd_pspace_data): Update.
10343         (fbsd_pspace_data_cleanup): Remove.
10344         (_initialize_fbsd_tdep): Update.
10345
10346 2019-05-08  Tom Tromey  <tom@tromey.com>
10347
10348         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10349         (get_ada_tasks_pspace_data): Update.
10350         (ada_tasks_pspace_data_cleanup): Remove.
10351         (_initialize_tasks): Update.
10352         (ada_tasks_inferior_data_handle): Change type.
10353         (get_ada_tasks_inferior_data): Update.
10354         (ada_tasks_inferior_data_cleanup): Remove.
10355         (struct ada_tasks_pspace_data): Add initializers.
10356
10357 2019-05-08  Tom Tromey  <tom@tromey.com>
10358
10359         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10360         * symfile-debug.c (debug_sym_get_probes): Change type.
10361         * stap-probe.c (handle_stap_probe):
10362         (stap_static_probe_ops::get_probes): Change type.
10363         * probe.h (class static_probe_ops) <get_probes>: Change type.
10364         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10365         (parse_probes_in_pspace): Update.
10366         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10367         Update.
10368         (any_static_probe_ops::get_probes): Change type.
10369         * elfread.c (elfread_data): New typedef.
10370         (probe_key): Change type.
10371         (elf_get_probes): Likewise.  Update.
10372         (probe_key_free): Remove.
10373         (_initialize_elfread): Update.
10374         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10375         Change type.
10376         (dtrace_process_dof_probe, dtrace_process_dof)
10377         (dtrace_static_probe_ops::get_probe): Change type.
10378
10379 2019-05-08  Tom Tromey  <tom@tromey.com>
10380
10381         * xcoffread.c (struct xcoff_symfile_info): Rename from
10382         coff_symfile_info.  Add initializers.
10383         (xcoff_objfile_data_key): Move lower.  Change type.
10384         (XCOFF_DATA): Rewrite.
10385         (xcoff_free_info): Remove.
10386         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10387         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10388         (xcoff_initial_scan): Update.
10389
10390 2019-05-08  Tom Tromey  <tom@tromey.com>
10391
10392         * solib-svr4.c (struct svr4_info): Add initializers and
10393         destructor.
10394         <probes_table>: Now an htab_up.
10395         (solib_svr4_pspace_data): Change type.
10396         (free_probes_table): Simplify.
10397         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10398         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10399         (probes_table_remove_objfile_probes, register_solib_event_probe)
10400         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10401         (_initialize_svr4_solib): Update.
10402
10403 2019-05-08  Tom Tromey  <tom@tromey.com>
10404
10405         * remote.c (remote_pspace_data): Change type.
10406         (remote_pspace_data_cleanup): Remove.
10407         (get_remote_exec_file, set_pspace_remote_exec_file)
10408         (_initialize_remote): Update.
10409
10410 2019-05-08  Tom Tromey  <tom@tromey.com>
10411
10412         * breakpoint.c (breakpoint_objfile_key): Change type.
10413         (get_breakpoint_objfile_data): Update.
10414         (free_breakpoint_objfile_data): Remove.
10415         (_initialize_breakpoint): Update.
10416
10417 2019-05-08  Tom Tromey  <tom@tromey.com>
10418
10419         * linux-tdep.c (struct linux_info): Add initializers.
10420         (linux_inferior_data): Move.  Change type.
10421         (invalidate_linux_cache_inf): Update.
10422         (linux_inferior_data_cleanup): Remove.
10423         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10424
10425 2019-05-08  Tom Tromey  <tom@tromey.com>
10426
10427         * auxv.c (auxv_inferior_data): Move.  Change type.
10428         (auxv_inferior_data_cleanup): Remove.
10429         (invalidate_auxv_cache_inf): Rewrite.
10430         (get_auxv_inferior_data, _initialize_auxv): Update.
10431
10432 2019-05-08  Tom Tromey  <tom@tromey.com>
10433
10434         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10435         (symfile_debug_objfile_data_key): Change type.
10436         (symfile_debug_installed, debug_qf_has_symbols)
10437         (debug_qf_find_last_source_symtab)
10438         (debug_qf_forget_cached_source_info)
10439         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10440         (debug_qf_print_stats, debug_qf_dump)
10441         (debug_qf_expand_symtabs_for_function)
10442         (debug_qf_expand_all_symtabs)
10443         (debug_qf_expand_symtabs_with_fullname)
10444         (debug_qf_map_matching_symbols)
10445         (debug_qf_expand_symtabs_matching)
10446         (debug_qf_find_pc_sect_compunit_symtab)
10447         (debug_qf_map_symbol_filenames)
10448         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10449         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10450         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10451         (debug_sym_read_linetable, debug_sym_relocate): Update.
10452         (symfile_debug_free_objfile): Remove.
10453         (install_symfile_debug_logging, _initialize_symfile_debug):
10454         Update.
10455
10456 2019-05-08  Tom Tromey  <tom@tromey.com>
10457
10458         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10459         allocate_on_obstack.
10460         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10461         (get_dwarf2_per_objfile): Update.
10462         (set_dwarf2_per_objfile): Remove.
10463         (dwarf2_has_info, dwarf2_get_section_info): Update.
10464         (dwarf2_free_objfile): Remove.
10465         (_initialize_dwarf2_read): Update.
10466
10467 2019-05-08  Tom Tromey  <tom@tromey.com>
10468
10469         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10470         initializers.
10471         <unsupported_script_warning_printed,
10472         script_not_found_warning_printed>: Now bool.
10473         (auto_load_pspace_data): Change type.
10474         (~auto_load_pspace_info): Rename from
10475         auto_load_pspace_data_cleanup.
10476         (get_auto_load_pspace_data, init_loaded_scripts_info)
10477         (clear_section_scripts, maybe_print_unsupported_script_warning)
10478         (maybe_print_script_not_found_warning, _initialize_auto_load):
10479         Update.
10480
10481 2019-05-08  Tom Tromey  <tom@tromey.com>
10482
10483         * objfiles.c (objfile_pspace_info): Add destructor and
10484         initializers.
10485         (objfiles_pspace_data): Change type.
10486         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10487         (get_objfile_pspace_data): Update.
10488         (objfiles_bfd_data): Change type.
10489         (get_objfile_bfd_data): Update.
10490         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10491
10492 2019-05-08  Tom Tromey  <tom@tromey.com>
10493
10494         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10495         Change type.
10496         (get_catch_syscall_inferior_data): Update.
10497         (catch_syscall_inferior_data_cleanup): Remove.
10498         (_initialize_break_catch_syscall): Update.
10499
10500 2019-05-08  Tom Tromey  <tom@tromey.com>
10501
10502         * inflow.c (struct terminal_info): Add destructor and
10503         initializers.
10504         (inflow_inferior_data): Change type.
10505         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10506         (get_inflow_inferior_data, inflow_inferior_exit)
10507         (swap_terminal_info, _initialize_inflow): Update.
10508
10509 2019-05-08  Tom Tromey  <tom@tromey.com>
10510
10511         * target-dcache.c (target_dcache_cleanup): Remove.
10512         (target_dcache_aspace_key): Change type.
10513         (target_dcache_init_p, target_dcache_invalidate)
10514         (target_dcache_get, target_dcache_get_or_init)
10515         (_initialize_target_dcache): Update.
10516         * dcache.h (struct dcache_deleter): New.
10517
10518 2019-05-08  Tom Tromey  <tom@tromey.com>
10519
10520         * symtab.c (struct symbol_cache): Add destructor and
10521         initializers.
10522         (symbol_cache_key): Move.  Change type.
10523         (make_symbol_cache, free_symbol_cache): Remove.
10524         (get_symbol_cache): Update.
10525         (symbol_cache_cleanup): Remove.
10526         (ALL_PSPACES, symbol_cache_flush)
10527         (maintenance_print_symbol_cache)
10528         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10529         Update.
10530
10531 2019-05-08  Tom Tromey  <tom@tromey.com>
10532
10533         * symtab.c (struct main_info): Add destructor and initializers.
10534         (main_progspace_key): Move.  Change type.
10535         (get_main_info): Update.
10536         (main_info_cleanup): Remove.
10537         (_initialize_symtab): Update.
10538
10539 2019-05-08  Tom Tromey  <tom@tromey.com>
10540
10541         * registry.h (DECLARE_REGISTRY): Define the _key class.
10542
10543 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10544
10545         * NEWS: Merge two 'New commands' sections.
10546
10547 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10548
10549         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10550         parameter and use Ada language definition instead.
10551         (ada_val_print_ptr): Remove unused language parameter.
10552         (ada_val_print_num): Remove language parameter and use Ada language
10553         definition instead.
10554         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10555         parameter.
10556         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10557         parameter and use Ada language definition instead.
10558         (ada_val_print_1): Update all ada_val_print_xxx calls.
10559         Remove language parameter.
10560         (ada_val_print): Update ada_val_print_1 call.
10561
10562 2019-05-08  Tom Tromey  <tromey@adacore.com>
10563
10564         * remote.c (remote_hw_watchpoint_limit)
10565         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10566         Now static.
10567
10568 2019-05-08  Tom Tromey  <tromey@adacore.com>
10569
10570         * maint.c (_initialize_maint_cmds): Move initialization code to
10571         remote.c.
10572         (watchdog, show_watchdog): Move to remote.c.
10573         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10574         "watchdog" static.
10575         (_initialize_remote): Move initialization code from maint.c.
10576         * defs.h (watchdog): Don't declare.
10577
10578 2019-05-08  Tom Tromey  <tromey@adacore.com>
10579
10580         * tui/tui-interp.c: Include main.h.
10581         * interps.c: Include main.h.
10582         * main.h (interpreter_p): Declare.
10583         * defs.h (interpreter_p): Don't declare.
10584
10585 2019-05-08  Tom Tromey  <tromey@adacore.com>
10586
10587         * dwarf2loc.c: Include dwarf2read.h.
10588         * defs.h (read_unsigned_leb128): Don't declare.
10589         * dwarf2read.h (read_unsigned_leb128): Declare.
10590
10591 2019-05-08  Tom Tromey  <tromey@adacore.com>
10592
10593         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10594         method.
10595
10596 2019-05-08  Tom Tromey  <tromey@adacore.com>
10597
10598         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10599         when no wrap column is set.
10600
10601 2019-05-08  Tom Tromey  <tromey@adacore.com>
10602
10603         * c-lang.c (c_get_string): Handle non-C-style arrays.
10604
10605 2019-05-08  Tom Tromey  <tromey@adacore.com>
10606
10607         * typeprint.c (print_offset_data::update): Print the bit offset,
10608         not the number of bits remaining.
10609
10610 2019-05-08  Tom Tromey  <tromey@adacore.com>
10611
10612         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10613         padding at end of comment.
10614
10615 2019-05-08  Tom Tromey  <tromey@adacore.com>
10616
10617         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10618         Compare main types.
10619
10620 2019-05-06  Tom Tromey  <tom@tromey.com>
10621
10622         * common/scoped_mmap.c: Include common-defs.h.
10623         * common/scoped_mmap.h: Don't include config.h.
10624
10625 2019-05-04  Tom Tromey  <tom@tromey.com>
10626
10627         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10628         (struct aarch64_call_info): Add initializers.
10629         <si>: Now a std::vector.
10630         (pass_on_stack, aarch64_push_dummy_call): Update.
10631
10632 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10633             Tom Tromey  <tom@tromey.com>
10634
10635         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10636         (ppc_threads): Now a std::vector.  Now static.
10637         (hwdebug_find_thread_points_by_tid)
10638         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10639         Update.
10640
10641 2019-05-04  Tom Tromey  <tom@tromey.com>
10642
10643         * arc-tdep.c (arc_tdesc_init): Return bool.
10644
10645 2019-05-04  Tom Tromey  <tom@tromey.com>
10646
10647         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10648         Use gdb_assert_not_reached.
10649
10650 2019-05-04  Tom Tromey  <tom@tromey.com>
10651
10652         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10653         "false".
10654
10655 2019-05-04  Tom Tromey  <tom@tromey.com>
10656
10657         * arc-tdep.c (arc_tdesc_init): Use bool.
10658
10659 2019-05-04  Tom Tromey  <tom@tromey.com>
10660
10661         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10662
10663 2019-05-04  Tom Tromey  <tom@tromey.com>
10664
10665         * cli/cli-cmds.c (valid_command_p): Return bool.
10666
10667 2019-05-04  Tom Tromey  <tom@tromey.com>
10668
10669         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10670         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10671
10672 2019-05-04  Raul Tambre  <raul@tambre.ee>
10673
10674         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10675         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10676         operator for comparison.
10677
10678 2019-05-04  Tom Tromey  <tom@tromey.com>
10679
10680         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10681         (lookup_partial_symbol, print_partial_symbols)
10682         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10683         (psymbol_compare): Update.
10684         (add_psymbol_to_bcache): Clear the entire psymbol.
10685         (maintenance_check_psymtabs): Update.
10686         * psympriv.h (struct partial_symbol): Don't derive from
10687         general_symbol_info.
10688         <obj_section, unrelocated_address, address,
10689         set_unrelocated_address>: Update.
10690         <ginfo>: New member.
10691         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10692         (debug_names::write_psymbols): Update.
10693
10694 2019-05-04  Tom de Vries  <tdevries@suse.de>
10695
10696         * contrib/cc-with-tweaks.sh: Support -n arg.
10697
10698 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10699
10700         * corelow.c (core_target::detach): Ensure frame cache and
10701         register caches are cleared.
10702         inferior.c (exit_inferior_1): Likewise.
10703
10704 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10705             Tom Tromey  <tom@tromey.com>
10706
10707         * dictionary.c (collate_pending_symbols_by_language): Remove
10708         "struct" from foreach.
10709         * symtab.c (lookup_global_symbol_from_objfile)
10710         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10711         foreach.
10712         * ser-tcp.c (net_open): Remove "struct" from foreach.
10713         * objfiles.c (objfile_relocate, objfile_rebase)
10714         (objfile_has_symbols): Remove "struct" from foreach.
10715         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10716         from foreach.
10717         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10718         foreach.
10719         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10720         "struct" from foreach.
10721         * ada-lang.c (create_excep_cond_exprs)
10722         (ada_exception_catchpoint_cond_string): Remove "struct" from
10723         foreach.
10724
10725 2019-05-03  Tom Tromey  <tromey@adacore.com>
10726
10727         * ada-exp.y (convert_char_literal): Check suffix of each
10728         enumerator.
10729
10730 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10731
10732         PR ada/21406:
10733         * ada-exp.y (yywrap): Don't define.
10734         * ada-lex.l (%option): Add noyywrap
10735         (yywrap): Remove.
10736
10737 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10738
10739         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10740         _WIN32_WINNT to the XP level, unless already defined to a higher
10741         level.
10742
10743         * unittests/parse-connection-spec-selftests.c:
10744         * ser-tcp.c:
10745         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10746         override.
10747
10748         * symfile.c (find_separate_debug_file): Remove colon from the
10749         drive spec of DOS/Windows file names of the target, so that the
10750         file name produced from DEBUGDIR and the target's directory will
10751         be valid on DOS/Windows systems.
10752
10753 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10754
10755         * rust-lang.c (val_print_struct): Handle printing structures
10756         containing strings.
10757
10758 2019-05-02  Tom Tromey  <tromey@adacore.com>
10759
10760         * valarith.c (_initialize_valarith): Remove.
10761
10762 2019-05-01  Tom Tromey  <tromey@adacore.com>
10763
10764         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10765         bitfields.
10766
10767 2019-05-01  Tom Tromey  <tromey@adacore.com>
10768
10769         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10770         for big-endian copies.
10771
10772 2019-04-30  Ali Tamur  <tamur@google.com>
10773         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10774         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10775         (read_3_bytes): New function.
10776
10777 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10778
10779         * windows-nat.c (main_thread_id): Delete.
10780         (handle_output_debug_string): Replace main_thread_id by
10781         current_event.dwThreadId.
10782         (fake_create_process): Likewise.
10783         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10784         Do not set main_thread_id.
10785         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10786         current_event.dwThreadId.
10787         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10788
10789 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10790
10791         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10792         Use current_event.dwThreadId instead of main_thread_id.
10793
10794 2019-04-30  Tom Tromey  <tromey@adacore.com>
10795
10796         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10797         (create_excep_cond_exprs): Iterate over program spaces.
10798         (ada_exception_catchpoint_cond_string): Examine all minimal
10799         symbols for exception types.
10800
10801 2019-04-30  Tom Tromey  <tromey@adacore.com>
10802
10803         PR c++/24470:
10804         * dwarf2read.c (process_structure_scope): Handle case where type
10805         has template parameters but no symbol was created.
10806
10807 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10808             Chris January  <chris.january@arm.com>
10809
10810         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10811         qualifier.
10812         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10813
10814 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10815
10816         * f-typeprint.c (f_print_type): Update rules for printing
10817         whitespace.
10818         (f_type_print_varspec_suffix): Likewise.
10819
10820 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10821             Chris January  <chris.january@arm.com>
10822
10823         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10824         function arguments.
10825
10826 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10827
10828         * f-lang.c (build_fortran_types): Change name of void type to
10829         lower case.
10830         * f-typeprint.c (f_type_print_base): Print the name of the void
10831         type, rather than a fixed string.
10832         * f-valprint.c (f_decorations): Use lower case void string.
10833
10834 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10835             Chris January  <chris.january@arm.com>
10836
10837         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10838         types for Fortran.
10839
10840 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10841             Chris January  <chris.january@arm.com>
10842             David Lecomber  <david.lecomber@arm.com>
10843
10844         * f-exp.y (BINOP_INTRINSIC): New token.
10845         (exp): New parser rule handling BINOP_INTRINSIC.
10846         (f77_keywords): Add new builtin procedures.
10847         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10848         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10849         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10850         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10851         (print_unop_subexp_f): New function.
10852         (print_binop_subexp_f): New function.
10853         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10854         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10855         (dump_subexp_body_f): Likewise.
10856         (operator_check_f): Likewise.
10857         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10858         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10859
10860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10861
10862         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10863         UNOP_KIND.
10864         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10865         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10866         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10867         (operator_length_f): New fuction.
10868         (print_subexp_f): New function.
10869         (op_name_f): New function.
10870         (dump_subexp_body_f): New function.
10871         (operator_check_f): New function.
10872         (exp_descriptor_f): Replace standard expression handling functions
10873         with new functions.
10874         * gdb/fortran-operator.def: New file.
10875         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10876         * gdb/std-operator.def: Remove UNOP_KIND.
10877
10878 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10879
10880         * std-operator.def: Remove unbalanced, stray double quote
10881         character.
10882
10883 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10884             Chris January  <chris.january@arm.com>
10885             Daniel Everett  <daniel.everett@arm.com>
10886             Nick Forrington  <nick.forrington@arm.com>
10887             Richard Bunt  <richard.bunt@arm.com>
10888
10889         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10890         of depth when printing anonymous structs or unions.
10891         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10892         Don't print either the top-level value, or the children if the
10893         max-depth is exceeded.
10894         (ppscm_print_children): When printing the key of a map, allow one
10895         extra level of depth.
10896         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10897         print either the top-level value, or the children if the max-depth
10898         is exceeded.
10899         (print_children): When printing the key of a map, allow one extra
10900         level of depth.
10901         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10902         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10903         (user_print_options): Initialise max_depth field.
10904         (val_print_scalar_or_string_type_p): New function.
10905         (val_print): Check to see if the max depth has been reached.
10906         (val_print_check_max_depth): Define new function.
10907         (show_print_max_depth): New function.
10908         (_initialize_valprint): Add 'print max-depth' option.
10909         * valprint.h (struct value_print_options) <max_depth>: New field.
10910         (val_print_check_max_depth): Declare new function.
10911         * NEWS: Document new feature.
10912
10913 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10914
10915         * ada-lang.c (ada_language_defn): Initialise new field.
10916         * c-lang.c (c_is_string_type_p): New function.
10917         (c_language_defn): Initialise new field.
10918         (cplus_language_defn): Initialise new field.
10919         (asm_language_defn): Initialise new field.
10920         (minimal_language_defn): Initialise new field.
10921         * c-lang.h (c_is_string_type_p): Declare new function.
10922         * d-lang.c (d_language_defn): Initialise new field.
10923         * f-lang.c (f_is_string_type_p): New function.
10924         (f_language_defn): Initialise new field.
10925         * go-lang.c (go_is_string_type_p): New function.
10926         (go_language_defn): Initialise new field.
10927         * language.c (default_is_string_type_p): New function.
10928         (unknown_language_defn): Initialise new field.
10929         (auto_language_defn): Initialise new field.
10930         * language.h (struct language_defn) <la_is_string_type_p>: New
10931         member variable.
10932         (default_is_string_type_p): Declare new function.
10933         * m2-lang.c (m2_language_defn): Initialise new field.
10934         * objc-lang.c (objc_language_defn): Initialise new field.
10935         * opencl-lang.c (opencl_language_defn): Initialise new field.
10936         * p-lang.c (pascal_is_string_type_p): New function.
10937         (pascal_language_defn): Initialise new field.
10938         * rust-lang.c (rust_is_string_type_p): New function.
10939         (rust_language_defn): Initialise new field.
10940
10941 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10942
10943         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10944         New field.
10945         * ada-lang.c (ada_language_defn): Initialise new field.
10946         * c-lang.c (c_language_defn): Likewise.
10947         (cplus_language_defn): Likewise.
10948         (asm_language_defn): Likewise.
10949         (minimal_language_defn): Likewise.
10950         * d-lang.c (d_language_defn): Likewise.
10951         * f-lang.c (f_language_defn): Likewise.
10952         * go-lang.c (go_language_defn): Likewise.
10953         * language.c (unknown_language_defn): Likewise.
10954         (auto_language_defn): Likewise.
10955         * m2-lang.c (m2_language_defn): Likewise.
10956         * objc-lang.c (objc_language_defn): Likewise.
10957         * opencl-lang.c (opencl_language_defn): Likewise.
10958         * p-lang.c (pascal_language_defn): Likewise.
10959         * rust-lang.c (rust_language_defn): Likewise.
10960
10961 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10962
10963         * ada-lang.c (ada_is_character_type): Change return type to bool.
10964         (ada_is_string_type): Likewise.
10965         * ada-lang.h (ada_is_character_type): Update declaration
10966         (ada_is_string_type): Likewise.
10967
10968 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10969
10970         Support style in 'frame|thread apply'
10971
10972         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10973         * record.c (record_start, record_stop): Update callers of
10974         execute_command_to_string with false.
10975         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10976         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10977         methods.
10978         (class string_file): New constructor with term_out parameter.
10979         Override methods term_out and can_emit_style_escape.  New member
10980         term_out.
10981         (class stdio_file): Override can_emit_style_escape.
10982         (class tee_file): Override term_out and can_emit_style_escape.
10983         * utils.h (can_emit_style_escape): Remove.
10984         * utils.c (can_emit_style_escape): Likewise.
10985         Update all callers of can_emit_style_escape (SOMESTREAM) to
10986         SOMESTREAM->can_emit_style_escape.
10987         * source-cache.c (source_cache::get_source_lines): Likewise.
10988         * stack.c (frame_apply_command_count): Call execute_command_to_string
10989         passing the term_out characteristic of the current gdb_stdout.
10990         * thread.c (thr_try_catch_cmd): Likewise.
10991         * top.c (execute_command_to_string): pass term_out parameter
10992         to construct the string_file for the command output.
10993         * ui-file.c (term_cli_styling): New function (most code moved
10994         from utils.c can_emit_style_escape).
10995         (string_file::string_file, string_file::can_emit_style_escape,
10996         stdio_file::can_emit_style_escape, tee_file::term_out,
10997         tee_file::can_emit_style_escape): New functions.
10998
10999 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11000
11001         * NEWS: Mention the new set|show may-call-functions.
11002         * infcall.c (may_call_functions_p): New variable.
11003         (show_may_call_functions_p): New function.
11004         (call_function_by_hand_dummy): Throws an error if not
11005         may-call-functions.
11006         (_initialize_infcall): Call add_setshow_boolean_cmd for
11007         may-call-functions.
11008
11009 2019-04-25  Keith Seitz  <keiths@redhat.com>
11010
11011         PR c++/24367
11012         * cp-support.c (inspect_type): Don't attempt substitutions
11013         of symbol with the same name.
11014
11015 2019-04-25  Tom Tromey  <tromey@adacore.com>
11016
11017         PR gdb/24475:
11018         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11019         static.
11020
11021 2019-04-25  Tom Tromey  <tromey@adacore.com>
11022
11023         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11024         rvalue reference.
11025         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11026         (gdb_xml_parser::parse): Use std::move.
11027         * python/python-internal.h (gdbpy_convert_exception): Take a const
11028         reference.
11029         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11030         std::move.
11031         * python/py-utils.c (gdbpy_convert_exception): Take a const
11032         reference.
11033         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11034         Use std::move.
11035         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11036         Use std::move.
11037         * mi/mi-main.c (mi_print_exception): Take a const reference.
11038         * main.c (handle_command_errors): Take a const reference.
11039         * linespec.c (parse_linespec): Use std::move.
11040         * infcall.c (run_inferior_call): Use std::move.
11041         (call_function_by_hand_dummy): Use std::move.
11042         * exec.c (try_open_exec_file): Use std::move.
11043         * exceptions.h (exception_print, exception_fprintf)
11044         (exception_print_same): Update.
11045         * exceptions.c (print_exception, exception_print)
11046         (exception_fprintf, exception_print_same): Change parameters to
11047         const reference.
11048         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11049         * common/new-op.c: Use std::move.
11050         * common/common-exceptions.h (struct gdb_exception): Add move
11051         constructor.
11052         (struct gdb_exception_error, struct gdb_exception_quit, struct
11053         gdb_quit_bad_alloc): Change constructor to move constructor.
11054         (throw_exception): Change parameter to rvalue reference.
11055         * common/common-exceptions.c (throw_exception): Take rvalue
11056         reference.
11057         * cli/cli-interp.c (safe_execute_command): Use std::move.
11058         * breakpoint.c (insert_bp_location, location_to_sals): Use
11059         std::move.
11060
11061 2019-04-25  Tom Tromey  <tromey@adacore.com>
11062
11063         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11064         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11065         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11066         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11067         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11068         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11069         guile/scm-value.c: Use unpack.
11070         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11071         gdbscm_gdb_exception.
11072         (gdbscm_throw_gdb_exception): Likewise.
11073         (struct gdbscm_gdb_exception): New.
11074         (unpack): New function.
11075         (gdbscm_wrap): Use unpack.
11076
11077 2019-04-25  Tom Tromey  <tromey@adacore.com>
11078
11079         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11080         (gdb_rl_callback_handler): Use std::move.
11081         * common/common-exceptions.h (struct gdb_exception): Add move
11082         assignment operator.
11083         (throw_exception_sjlj): Change "exception" to const reference.
11084         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11085         (throw_exception_sjlj): Change "exception" to const reference.
11086
11087 2019-04-25  Tom Tromey  <tromey@adacore.com>
11088
11089         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11090         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11091         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11092         Update.
11093         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11094         Update.
11095         * mi/mi-interp.c (mi_interp::exec): Update.
11096         * linespec.c (parse_linespec): Update.
11097         * infcall.c (run_inferior_call): Update.
11098         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11099         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11100         (gdbscm_lookup_global_symbol): Update.
11101         * guile/scm-param.c (gdbscm_parameter_value): Update.
11102         * guile/scm-frame.c (gdbscm_frame_read_register)
11103         (gdbscm_frame_read_var): Update.
11104         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11105         * exec.c (try_open_exec_file): Update.
11106         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11107         (gdb_rl_callback_handler): Update.
11108         * common/common-exceptions.h (exception_none): Don't declare.
11109         * common/common-exceptions.c (exception_none): Don't define.
11110         (struct catcher) <exception>: Update.
11111         * cli/cli-interp.c (safe_execute_command): Update.
11112         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11113
11114 2019-04-25  Ali Tamur  <tamur@google.com>
11115
11116         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11117         (read_attribute_value): Likewise.
11118         (dwarf2_read_addr_index): Update comment.
11119         (read_str_index): Add DW_FORM_strx.
11120         (dwarf2_string_attr): Likewise.
11121         (dwarf2_const_value_attr): Likewise.
11122         (dump_die_shallow): Likewise.
11123         (dwarf2_fetch_constant_bytes): Likewise.
11124         (skip_form_bytes): Likewise.
11125         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11126
11127 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11128
11129         PR corefiles/11608
11130         PR corefiles/18187
11131         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11132         OFFSET.  Verify if current mapping contains an ELF header.
11133         (linux_find_memory_regions_full): Adjust call to
11134         dump_mapping_p.
11135
11136 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11137             Kang Li <kanglictf@gmail.com>
11138
11139         PR gdb/21600
11140
11141         * dwarf2-frame.c (read_initial_length): Be consistent about using
11142         unsigned representation of length.
11143         (decode_frame_entry_1): Likewise.  Check for wraparound of
11144         end pointer as well as buffer overflow.
11145
11146 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11147
11148         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11149         "vq".
11150
11151 2019-04-24  Tom Tromey  <tromey@adacore.com>
11152
11153         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11154
11155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11156
11157         * s12z-tdep.c (s12z_unwind_pc): Delete.
11158         (s12z_unwind_sp): Delete.
11159         (s12z_gdbarch_init): Don't register deleted functions with
11160         gdbarch.
11161
11162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11163
11164         * rl78-tdep.c (rl78_unwind_sp): Delete.
11165         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11166
11167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11168
11169         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11170         (xstormy16_unwind_pc): Delete.
11171         (xstormy16_dummy_id): Delete.
11172         (xstormy16_gdbarch_init): Don't register deleted functions with
11173         gdbarch.
11174
11175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11176
11177         * vax-tdep.c (vax_unwind_pc): Delete.
11178         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11179
11180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11181
11182         * v850-tdep.c (v850_unwind_sp): Delete.
11183         (v850_unwind_pc): Delete.
11184         (v850_dummy_id): Delete.
11185         (v850_gdbarch_init): Don't register deleted functions with
11186         gdbarch.
11187
11188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11189
11190         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11191         (tilegx_unwind_pc): Delete.
11192         (tilegx_unwind_dummy_id): Delete.
11193         (tilegx_gdbarch_init): Don't register deleted functions with
11194         gdbarch.
11195
11196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11197
11198         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11199         (tic6x_dummy_id): Delete.
11200         (tic6x_gdbarch_init): Don't register deleted functions with
11201         gdbarch.
11202
11203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11204
11205         * sparc-tdep.c (sparc_unwind_pc): Delete.
11206         (sparc32_gdbarch_init): Don't register deleted function with
11207         gdbarch.
11208
11209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11210
11211         * sh-tdep.c (sh_unwind_sp): Delete.
11212         (sh_unwind_pc): Delete.
11213         (sh_dummy_id): Delete.
11214         (sh_gdbarch_init): Don't register deleted functions with
11215         gdbarch.
11216
11217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11218
11219         * score-tdep.c (score_unwind_sp): Delete.
11220         (score_unwind_pc): Delete.
11221         (score_dummy_id): Delete.
11222         (score_gdbarch_init): Don't register deleted functions with
11223         gdbarch.
11224
11225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11226
11227         * rx-tdep.c (rx_unwind_pc): Delete.
11228         (rx_unwind_sp): Delete.
11229         (rx_dummy_id): Delete.
11230         (rx_gdbarch_init): Don't register deleted functions with
11231         gdbarch.  Update comment.
11232
11233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11234
11235         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11236         (rs6000_dummy_id): Delete.
11237         (rs6000_gdbarch_init): Don't register deleted functions with
11238         gdbarch.
11239
11240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11241
11242         * or1k-tdep.c (or1k_dummy_id): Delete.
11243         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11244
11245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11246
11247         * nios2-tdep.c (nios2_dummy_id): Delete.
11248         (nios2_unwind_sp): Delete.
11249         (nios2_gdbarch_init): Don't register deleted functions with
11250         gdbarch.
11251
11252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11253
11254         * nds32-tdep.c (nds32_dummy_id): Delete.
11255         (nds32_unwind_pc): Delete.
11256         (nds32_unwind_sp): Delete.
11257         (nds32_gdbarch_init): Don't register deleted functions with
11258         gdbarch.
11259
11260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11261
11262         * msp430-tdep.c (msp430_unwind_pc): Delete.
11263         (msp430_unwind_sp): Delete.
11264         (msp430_dummy_id): Delete.
11265         (msp430_gdbarch_init): Don't register deleted functions with
11266         gdbarch.
11267
11268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11269
11270         * moxie-tdep.c (moxie_unwind_sp): Delete.
11271         (moxie_unwind_pc): Delete.
11272         (moxie_dummy_id): Delete.
11273         (moxie_gdbarch_init): Don't register deleted functions with
11274         gdbarch.
11275
11276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11277
11278         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11279         (mn10300_unwind_pc): Delete.
11280         (mn10300_unwind_sp): Delete.
11281         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11282         mn10300_unwind_sp.
11283         (mn10300_frame_unwind_init): Don't register deleted functions with
11284         gdbarch.
11285
11286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11287
11288         * mep-tdep.c (mep_unwind_pc): Delete.
11289         (mep_unwind_sp): Delete.
11290         (mep_dummy_id): Delete.
11291         (mep_gdbarch_init): Don't register deleted functions with
11292         gdbarch.
11293
11294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11295
11296         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11297         (m68hc11_unwind_sp): Delete.
11298         (m68hc11_gdbarch_init): Don't register deleted functions with
11299         gdbarch.
11300
11301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * m32r-tdep.c (m32r_unwind_sp): Delete.
11304         (m32r_unwind_pc): Delete.
11305         (m32r_dummy_id): Delete.
11306         (m32r_gdbarch_init): Don't register deleted functions with
11307         gdbarch.
11308
11309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11310
11311         * m32c-tdep.c (m32c_unwind_pc): Delete.
11312         (m32c_unwind_sp): Delete.
11313         (m32c_dummy_id): Delete.
11314         (m32c_gdbarch_init): Don't register deleted functions with
11315         gdbarch.
11316
11317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11318
11319         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11320         (lm32_unwind_pc): Delete.
11321         (lm32_dummy_id): Delete.
11322         (lm32_gdbarch_init): Don't register deleted functions with
11323         gdbarch.
11324
11325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11326
11327         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11328         (iq2000_unwind_pc): Delete.
11329         (iq2000_dummy_id): Delete.
11330         (iq2000_gdbarch_init): Don't register deleted functions with
11331         gdbarch.
11332
11333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11334
11335         * nds32-tdep.c (nds32_type_align): Delete.
11336         (nds32_push_dummy_call): Use type_align instead.
11337
11338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11339
11340         * arm-tdep.c (arm_type_align): Only handle vector override case.
11341         (arm_push_dummy_call): Use type_align.
11342         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11343
11344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11345
11346         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11347         case.
11348         (pass_on_stack): Use type_align.
11349         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11350         function.
11351
11352 2019-04-23  Tom Tromey  <tromey@adacore.com>
11353
11354         * dwarf2read.c (line_header::file_name_at): Remove unused
11355         overload.
11356
11357 2019-04-23  Tom de Vries  <tdevries@suse.de>
11358
11359         PR gdb/24438
11360         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11361         invocation.
11362
11363
11364 2019-03-27  Ali Tamur  <tamur@google.com>
11365
11366         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11367         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11368         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11369         (dwarf_expr_context::get_addr_index): Likewise
11370         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11371         (symbol_needs_eval_context::get_addr_index): Likewise
11372         (disassemble_dwarf_expression): Add DW_OP_addrx
11373         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11374         (read_cutu_die_from_dwo): Update comment
11375         (skip_one_die): Add DW_FORM_addrx
11376         (read_attribute_value): Likewise
11377         (var_decode_location): Add DW_OP_addrx
11378         (dwarf2_const_value_attr): Add DW_FORM_addrx
11379         (dump_die_shallow): Likewise
11380         (dwarf2_fetch_constant_bytes): Likewise
11381         (decode_locdesc): Add DW_OP_addrx
11382         (skip_form_bytes): Add DW_FORM_addrx
11383
11384 2019-04-22  Ali Tamur  <tamur@google.com>
11385
11386         * MAINTAINERS (Write After Approval): Add self.
11387
11388 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11389
11390         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11391         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11392         (open_symbol_file_object): Likewise.
11393         (svr4_default_sos): Add info parameter.
11394         (svr4_read_so_list): Likewise.
11395         (svr4_current_sos_direct): Adjust functions calls to pass down
11396         info.
11397         (svr4_current_sos_1): Add info parameter.
11398         (svr4_current_sos): Call get_svr4_info, pass info down to
11399         svr4_current_sos_1.
11400         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11401         get_svr4_info.
11402         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11403         get_svr4_info.
11404         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11405         to get_svr4_info.
11406         (probes_table_remove_objfile_probes): Likewise.
11407         (register_solib_event_probe): Add info parameter.
11408         (solist_update_incremental): Pass info parameter down to
11409         svr4_read_so_list.
11410         (disable_probes_interface): Add info parameter.
11411         (svr4_handle_solib_event): Pass current_program_space to
11412         get_svr4_info.  Adjust disable_probes_interface cleanup.
11413         (svr4_create_probe_breakpoints): Add info parameter, pass it
11414         down to register_solib_event_probe.
11415         (svr4_create_solib_event_breakpoints): Add info parameter,
11416         pass it down to svr4_create_probe_breakpoints.
11417         (enable_break): Pass info down to
11418         svr4_create_solib_event_breakpoints.
11419         (svr4_solib_create_inferior_hook): Pass current_program_space to
11420         get_svr4_info.
11421         (svr4_clear_solib): Likewise.
11422
11423 2019-04-22  Pedro Alves  <palves@redhat.com>
11424
11425         * solib-svr4.c (svr4_free_objfile_observer): New.
11426         (probe_and_action::objfile): New field.
11427         (probes_table_htab_remove_objfile_probes)
11428         (probes_table_remove_objfile_probes): New functions.
11429         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11430         in the new probe_and_action.  Don't store the probe in 'lookup'.
11431         (svr4_create_probe_breakpoints): Pass objfile to
11432         register_solib_event_probe.
11433         (_initialize_svr4_solib): Register a free_objfile observer.
11434
11435 2019-04-19  Tom Tromey  <tom@tromey.com>
11436
11437         * common/queue.h: Remove.
11438
11439 2019-04-19  Tom Tromey  <tom@tromey.com>
11440
11441         * event-loop.c: Don't include "common/queue.h".
11442
11443 2019-04-19  Tom Tromey  <tom@tromey.com>
11444
11445         * remote.c (remote_target): Use delete.
11446         * remote-notif.h: Include <list>, not "common/queue.h".
11447         (notif_client_p): Remove typedef.
11448         (remote_notif_state): Add constructor, destructor, initializer.
11449         <notif_queue>: Now a std::list.
11450         (remote_notif_state_xfree): Don't declare.
11451         * remote-notif.c (remote_notif_process, handle_notification)
11452         (remote_notif_state_allocate): Update.
11453         (~remote_notif_state): Rename from remote_notif_state_xfree.
11454
11455 2019-04-19  Tom Tromey  <tom@tromey.com>
11456
11457         * symfile.c (reread_symbols): Update.
11458         * objfiles.c (objfile_register_static_link)
11459         (objfile_lookup_static_link): Update
11460         (~objfile) Don't delete static_links.
11461         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11462
11463 2019-04-19  Tom Tromey  <tom@tromey.com>
11464
11465         * type-stack.h (struct type_stack) <insert>: Constify string.
11466         * type-stack.c (type_stack::insert): Constify string.
11467         * gdbtypes.h (lookup_template_type): Update.
11468         (address_space_name_to_int): Update.
11469         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11470         const.
11471         (lookup_template_type): Make name const.
11472         * c-exp.y: Update rules.
11473         (lex_one_token, classify_name, classify_inner_name)
11474         (c_print_token): Update.
11475         * p-exp.y: Update rules.
11476         (yylex): Update.
11477         * f-exp.y: Update rules.
11478         (yylex): Update.
11479         * d-exp.y: Update rules.
11480         (lex_one_token, classify_name, classify_inner_name): Update.
11481         * parse.c (write_dollar_variable, copy_name): Return std::string.
11482         * parser-defs.h (copy_name): Change return type.
11483         * m2-exp.y: Update rules.
11484         (yylex): Update.
11485         * go-exp.y (lex_one_token): Update.
11486         Update rules.
11487         (classify_unsafe_function, classify_packaged_name)
11488         (classify_name, yylex): Update.
11489
11490 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11491
11492         * configure.ac: add --enable-source-highlight switch.
11493         * configure: Regenerate.
11494         * top.c (print_gdb_version): plumb --enable-source-highlight
11495         status to "show configuration".
11496
11497 2019-04-19  Tom Tromey  <tromey@adacore.com>
11498
11499         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11500         Check ADA_TYPE_P.
11501         (empty_record, ada_template_to_fixed_record_type_1)
11502         (template_to_static_fixed_type)
11503         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11504         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11505         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11506         macros.
11507
11508 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11509
11510         PR symtab/24423:
11511         * source.c (print_source_lines_base): Advance "iter" when a
11512         control character is seen.
11513
11514 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11515
11516         * inferior.h (struct infcall_suspend_state_deleter):
11517         Catch exception in destructor to avoid crash.
11518
11519 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11520
11521         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11522         close to the add_com "shell".
11523
11524 2019-04-18  Tom Tromey  <tromey@adacore.com>
11525
11526         * process-stratum-target.h (class process_stratum_target)
11527         <stratum>: Add "final".
11528
11529 2019-04-17  Tom Tromey  <tromey@adacore.com>
11530
11531         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11532         against nullptr before use.
11533
11534 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11535
11536         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11537
11538 2019-04-17  Jim Wilson  <jimw@sifive.com>
11539             Andrew Burgess  <andrew.burgess@embecosm.com>
11540
11541         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11542         code read might fail, assume 4-byte breakpoint in that case.
11543
11544 2019-04-15  Leszek Swirski  <leszeks@google.com>
11545
11546         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11547         rather than a hand-rolled POD check when checking for forced MEMORY
11548         classification.
11549
11550 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11551
11552         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11553         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11554         function.
11555         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11556         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11557         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11558         declaration.
11559
11560 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11561
11562         * aarch64-linux-nat.c
11563         (aarch64_linux_nat_target::thread_architecture): Add override.
11564         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11565         each VQ.
11566
11567 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11568
11569         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11570
11571 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11572
11573         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11574         target types of size 96-bits, add some additional comments, and
11575         check that the builtin type we found was the correct size.
11576
11577 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11578
11579         * utils.c (prompt_for_continue): Don't restore the styling at the
11580         end, as applied_style has the wrong value.  This fixes styling in
11581         long lists of file names that are interrupted by the "Continue?"
11582         prompt.
11583
11584 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11585
11586         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11587         * c-lang.c (c_language_defn): Likewise.
11588         (cplus_language_defn): Likewise.
11589         (asm_language_defn): Likewise.
11590         (minimal_language_defn): Likewise.
11591         * d-lang.c (d_language_defn): Likewise.
11592         * f-lang.c (f_language_defn): Likewise.
11593         * go-lang.c (go_language_defn): Likewise.
11594         * language.c (unknown_language_defn): Likewise.
11595         (auto_language_defn): Likewise.
11596         * language.h (struct language_defn): Remove la_magic field.
11597         (LANG_MAGIC): Delete.
11598         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11599         * objc-lang.c (objc_language_defn): Likewise.
11600         * opencl-lang.c (opencl_language_defn): Likewise.
11601         * p-lang.c (pascal_language_defn): Likewise.
11602         * rust-lang.c (rust_language_defn): Likewise.
11603
11604 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11605
11606         * riscv-tdep.c (riscv_type_align): New function.
11607         (riscv_type_alignment): Delete.
11608         (riscv_arg_location): Use 'type_align'.
11609         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11610
11611 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11612
11613         * gdbtypes.c (type_align): A struct with no non-static fields also
11614         has alignment of 1.
11615
11616 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11617
11618         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11619         component to 0.
11620         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11621         member.
11622         (riscv_struct_info::analyse): New implementation using new
11623         analyse_inner member function.
11624         (riscv_struct_info::field_offset): New member function.
11625         (riscv_struct_info::m_offsets): New member variable.
11626         (riscv_struct_info::analyse_inner): New private member function,
11627         takes the old implementation of riscv_struct_info::analyse but
11628         extended to track field offsets.
11629         (riscv_call_arg_struct): Update the struct folding special cases
11630         to handle cases where empty C++ structs, which are non-zero
11631         length, are found.
11632         (riscv_arg_location): Initialise the length of each location, a
11633         non-zero length now indicates the location is in use.
11634         (riscv_push_dummy_call): Allow for the first location having a
11635         non-zero offset when setting up arguments.
11636         (riscv_return_value): Likewise, but for return values.
11637
11638 2019-04-11  Tom Tromey  <tromey@adacore.com>
11639
11640         * utils.c (internal_vproblem): Make "msg" const.
11641
11642 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11643
11644         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11645         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11646         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11647         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11648
11649 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11650
11651         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11652         function.
11653         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11654         of amd64_collect_native_gregset.
11655         (amd64_linux_nat_target::store_registers): Likewise.
11656
11657 2019-04-10  Tom Tromey  <tom@tromey.com>
11658
11659         * symtab.c (lookup_global_symbol_from_objfile)
11660         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11661         * objfiles.h (class separate_debug_iterator): New.
11662         (class separate_debug_range): New.
11663         (struct objfile) <separate_debug_objfiles>: New method.
11664         (objfile_separate_debug_iterate): Don't declare.
11665         * objfiles.c (separate_debug_iterator::operator++): Rename from
11666         objfile_separate_debug_iterate.
11667         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11668         iterator.
11669         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11670         iterator.
11671
11672 2019-04-10  Tom Tromey  <tom@tromey.com>
11673
11674         * symfile.c (reread_symbols): Remove old comment.
11675         * objfiles.c (free_all_objfiles): Fix a typo.
11676
11677 2019-04-10  Tom Tromey  <tom@tromey.com>
11678
11679         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11680         * minsyms.c (lookup_minimal_symbol): Use foreach.
11681         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11682         (lookup_minimal_symbol_solib_trampoline): Likewise.
11683         * symfile.c (reread_symbols): Use foreach.
11684
11685 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11686             Tom Tromey  <tromey@adacore.com>
11687
11688         PR rust/24414:
11689         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11690         (rust_lex_int_test): Change "value" to be LONGEST.
11691         (rust_lex_tests): Add test for long integer literal.
11692
11693 2019-04-09  Tom Tromey  <tromey@adacore.com>
11694
11695         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11696         to bool.
11697         (extended_remote_target::attach): Update.
11698         (remote_target::remote_notice_new_inferior): Update.
11699         (remote_target::add_current_inferior_and_thread): Update.
11700         * inferior.c (exit_inferior_1): Use "false".
11701         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11702
11703 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11704
11705         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11706         the "start" command.
11707
11708 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11709
11710         * python/py-inferior.c (infpy_thread_from_thread_handle):
11711         Adjust comments to reflect renaming of thread_from_thread_handle
11712         to thread_from_handle.  Adjust keywords.  Fix type error message.
11713         (inferior_object_methods): Add thread_from_handle.  Retain
11714         thread_from_thread_handle, but mark it as deprecated.
11715
11716 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11717
11718         * gdbthread.h (find_thread_by_handle): Revise declaration.
11719         * thread.c (find_thread_by_handle): Likewise.  Adjust
11720         implementation too.
11721         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11722         support for buffer objects as handles.
11723
11724 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11725
11726         * python/py-infthread.c (thpy_thread_handle): New function.
11727         (thread_object_methods): Register thpy_thread_handle.
11728
11729 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11730
11731         * gdbthread.h (thread_to_thread_handle): Declare.
11732         * thread.c (gdbtypes.h): Include.
11733         (thread_to_thread_handle): New function.
11734
11735         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11736         (target_thread_info_to_thread_handle): Declare.
11737         * target.c (target_thread_info_to_thread_handle): New function.
11738         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11739         * target-delegates.c: Regenerate.
11740
11741         * linux-thread-db.c (class thread_db_target): Add method
11742         thread_info_to_thread_handle.
11743         (thread_db_target::thread_info_to_thread_handle): Define.
11744         * remote.c (class remote_target): Add new method
11745         thread_info_to_thread_handle.
11746         (remote_target::thread_info_to_thread_handle): Define.
11747
11748 2019-04-08  Pedro Alves  <palves@redhat.com>
11749
11750         * common/common-exceptions.c (throw_exception): Don't create
11751         named object to throw; throw directly.
11752         (throw_it): Likewise.  Don't initialize gdb_exception::message
11753         here, with new; pass FMT and AP to the ctor instead.
11754         * common/common-exceptions.h: Include <string>.
11755         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11756         const char *, va_list)): New ctor.  Use std::make_shared.
11757         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11758         errors)): Delete.
11759         (gdb_exception_error::gdb_exception_error(enum errors, const char
11760         *, va_list)): New.
11761         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11762         Add assertion.
11763         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11764         errors)): Delete.
11765         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11766         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11767         Add assertion.
11768
11769 2019-04-08  Tom Tromey  <tom@tromey.com>
11770
11771         * valops.c (value_rtti_indirect_type): Replace throw_exception
11772         with throw.
11773         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11774         with throw.
11775         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11776         throw.
11777         * target.c (target_translate_tls_address): Replace throw_exception
11778         with throw.
11779         * stack.c (frame_apply_command_count): Replace throw_exception
11780         with throw.
11781         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11782         throw.
11783         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11784         with throw.
11785         * rs6000-tdep.c (rs6000_frame_cache)
11786         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11787         * remote.c: Replace throw_exception with throw.
11788         * record-full.c (record_full_message, record_full_wait_1)
11789         (record_full_restore): Replace throw_exception with throw.
11790         * record-btrace.c:
11791         (get_thread_current_frame_id, record_btrace_start_replaying)
11792         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11793         (cmd_record_btrace_start): Replace throw_exception with throw.
11794         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11795         throw.
11796         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11797         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11798         * linespec.c:
11799         (find_linespec_symbols): Replace throw_exception with throw.
11800         * infrun.c (displaced_step_prepare, resume): Replace
11801         throw_exception with throw.
11802         * infcmd.c (post_create_inferior): Replace throw_exception with
11803         throw.
11804         * inf-loop.c (inferior_event_handler): Replace throw_exception
11805         with throw.
11806         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11807         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11808         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11809         (get_prev_frame_always, get_frame_pc_if_available)
11810         (get_frame_address_in_block_if_available, get_frame_language):
11811         Replace throw_exception with throw.
11812         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11813         throw_exception with throw.
11814         * eval.c (fetch_subexp_value, evaluate_var_value)
11815         (evaluate_funcall, evaluate_subexp_standard): Replace
11816         throw_exception with throw.
11817         * dwarf2loc.c (call_site_find_chain)
11818         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11819         Replace throw_exception with throw.
11820         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11821         with throw.
11822         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11823         throw.
11824         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11825         * completer.c (complete_line_internal): Replace throw_exception
11826         with throw.
11827         * compile/compile-object-run.c (compile_object_run): Replace
11828         throw_exception with throw.
11829         * cli/cli-script.c (process_next_line): Replace throw_exception
11830         with throw.
11831         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11832         (btrace_enable, btrace_maint_update_pt_packets): Replace
11833         throw_exception with throw.
11834         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11835         throw_exception with throw.
11836         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11837         throw_exception with throw.
11838         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11839         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11840         * aarch64-tdep.c (aarch64_make_prologue_cache)
11841         (aarch64_make_stub_cache): Replace throw_exception with throw.
11842
11843 2019-04-08  Tom Tromey  <tom@tromey.com>
11844
11845         * common/common-exceptions.c (throw_exception): Rename from
11846         throw_exception_cxx.  Remove old copy.  Make argument const.
11847         (throw_it): Create and throw exception objects directly.
11848         * common/common-exceptions.h (throw_exception): Make argument
11849         const.
11850         (struct gdb_exception_error): Add constructor.
11851         (struct gdb_exception_quit): Add constructor.
11852
11853 2019-04-08  Tom Tromey  <tom@tromey.com>
11854
11855         * common/common-exceptions.h (exception_rethrow): Don't declare.
11856         (TRY_SJLJ): Update comment.
11857         (TRY, CATCH, END_CATCH): Remove.
11858         * common/common-exceptions.c (exception_rethrow): Remove.
11859
11860 2019-04-08  Tom Tromey  <tom@tromey.com>
11861
11862         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11863         Remove.
11864         (gdb_exception_error): Rename from
11865         gdb_exception_RETURN_MASK_ERROR.
11866         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11867         (gdb_quit_bad_alloc): Update.
11868         * aarch64-tdep.c: Update.
11869         * ada-lang.c: Update.
11870         * ada-typeprint.c: Update.
11871         * ada-valprint.c: Update.
11872         * amd64-tdep.c: Update.
11873         * arch-utils.c: Update.
11874         * break-catch-throw.c: Update.
11875         * breakpoint.c: Update.
11876         * btrace.c: Update.
11877         * c-varobj.c: Update.
11878         * cli/cli-cmds.c: Update.
11879         * cli/cli-interp.c: Update.
11880         * cli/cli-script.c: Update.
11881         * common/common-exceptions.c: Update.
11882         * common/new-op.c: Update.
11883         * common/selftest.c: Update.
11884         * compile/compile-c-symbols.c: Update.
11885         * compile/compile-cplus-symbols.c: Update.
11886         * compile/compile-object-load.c: Update.
11887         * compile/compile-object-run.c: Update.
11888         * completer.c: Update.
11889         * corelow.c: Update.
11890         * cp-abi.c: Update.
11891         * cp-support.c: Update.
11892         * cp-valprint.c: Update.
11893         * darwin-nat.c: Update.
11894         * disasm-selftests.c: Update.
11895         * dtrace-probe.c: Update.
11896         * dwarf-index-cache.c: Update.
11897         * dwarf-index-write.c: Update.
11898         * dwarf2-frame-tailcall.c: Update.
11899         * dwarf2-frame.c: Update.
11900         * dwarf2loc.c: Update.
11901         * dwarf2read.c: Update.
11902         * eval.c: Update.
11903         * event-loop.c: Update.
11904         * event-top.c: Update.
11905         * exec.c: Update.
11906         * f-valprint.c: Update.
11907         * fbsd-tdep.c: Update.
11908         * frame-unwind.c: Update.
11909         * frame.c: Update.
11910         * gdbtypes.c: Update.
11911         * gnu-v3-abi.c: Update.
11912         * guile/guile-internal.h: Update.
11913         * guile/scm-block.c: Update.
11914         * guile/scm-breakpoint.c: Update.
11915         * guile/scm-cmd.c: Update.
11916         * guile/scm-disasm.c: Update.
11917         * guile/scm-frame.c: Update.
11918         * guile/scm-lazy-string.c: Update.
11919         * guile/scm-math.c: Update.
11920         * guile/scm-param.c: Update.
11921         * guile/scm-ports.c: Update.
11922         * guile/scm-pretty-print.c: Update.
11923         * guile/scm-symbol.c: Update.
11924         * guile/scm-symtab.c: Update.
11925         * guile/scm-type.c: Update.
11926         * guile/scm-value.c: Update.
11927         * i386-linux-tdep.c: Update.
11928         * i386-tdep.c: Update.
11929         * inf-loop.c: Update.
11930         * infcall.c: Update.
11931         * infcmd.c: Update.
11932         * infrun.c: Update.
11933         * jit.c: Update.
11934         * language.c: Update.
11935         * linespec.c: Update.
11936         * linux-fork.c: Update.
11937         * linux-nat.c: Update.
11938         * linux-tdep.c: Update.
11939         * linux-thread-db.c: Update.
11940         * main.c: Update.
11941         * mi/mi-cmd-break.c: Update.
11942         * mi/mi-cmd-stack.c: Update.
11943         * mi/mi-interp.c: Update.
11944         * mi/mi-main.c: Update.
11945         * objc-lang.c: Update.
11946         * p-valprint.c: Update.
11947         * parse.c: Update.
11948         * ppc-linux-tdep.c: Update.
11949         * printcmd.c: Update.
11950         * python/py-arch.c: Update.
11951         * python/py-breakpoint.c: Update.
11952         * python/py-cmd.c: Update.
11953         * python/py-finishbreakpoint.c: Update.
11954         * python/py-frame.c: Update.
11955         * python/py-framefilter.c: Update.
11956         * python/py-gdb-readline.c: Update.
11957         * python/py-inferior.c: Update.
11958         * python/py-infthread.c: Update.
11959         * python/py-lazy-string.c: Update.
11960         * python/py-linetable.c: Update.
11961         * python/py-objfile.c: Update.
11962         * python/py-param.c: Update.
11963         * python/py-prettyprint.c: Update.
11964         * python/py-progspace.c: Update.
11965         * python/py-record-btrace.c: Update.
11966         * python/py-record.c: Update.
11967         * python/py-symbol.c: Update.
11968         * python/py-type.c: Update.
11969         * python/py-unwind.c: Update.
11970         * python/py-utils.c: Update.
11971         * python/py-value.c: Update.
11972         * python/python.c: Update.
11973         * record-btrace.c: Update.
11974         * record-full.c: Update.
11975         * remote-fileio.c: Update.
11976         * remote.c: Update.
11977         * riscv-tdep.c: Update.
11978         * rs6000-aix-tdep.c: Update.
11979         * rs6000-tdep.c: Update.
11980         * rust-exp.y: Update.
11981         * rust-lang.c: Update.
11982         * s390-tdep.c: Update.
11983         * selftest-arch.c: Update.
11984         * solib-dsbt.c: Update.
11985         * solib-frv.c: Update.
11986         * solib-spu.c: Update.
11987         * solib-svr4.c: Update.
11988         * solib.c: Update.
11989         * sparc64-linux-tdep.c: Update.
11990         * stack.c: Update.
11991         * symfile-mem.c: Update.
11992         * symmisc.c: Update.
11993         * target.c: Update.
11994         * thread.c: Update.
11995         * top.c: Update.
11996         * tracefile-tfile.c: Update.
11997         * tui/tui.c: Update.
11998         * typeprint.c: Update.
11999         * unittests/cli-utils-selftests.c: Update.
12000         * unittests/parse-connection-spec-selftests.c: Update.
12001         * valops.c: Update.
12002         * valprint.c: Update.
12003         * value.c: Update.
12004         * varobj.c: Update.
12005         * windows-nat.c: Update.
12006         * x86-linux-nat.c: Update.
12007         * xml-support.c: Update.
12008
12009 2019-04-08  Tom Tromey  <tom@tromey.com>
12010
12011         * xml-support.c: Use C++ exception handling.
12012         * x86-linux-nat.c: Use C++ exception handling.
12013         * windows-nat.c: Use C++ exception handling.
12014         * varobj.c: Use C++ exception handling.
12015         * value.c: Use C++ exception handling.
12016         * valprint.c: Use C++ exception handling.
12017         * valops.c: Use C++ exception handling.
12018         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12019         handling.
12020         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12021         * typeprint.c: Use C++ exception handling.
12022         * tui/tui.c: Use C++ exception handling.
12023         * tracefile-tfile.c: Use C++ exception handling.
12024         * top.c: Use C++ exception handling.
12025         * thread.c: Use C++ exception handling.
12026         * target.c: Use C++ exception handling.
12027         * symmisc.c: Use C++ exception handling.
12028         * symfile-mem.c: Use C++ exception handling.
12029         * stack.c: Use C++ exception handling.
12030         * sparc64-linux-tdep.c: Use C++ exception handling.
12031         * solib.c: Use C++ exception handling.
12032         * solib-svr4.c: Use C++ exception handling.
12033         * solib-spu.c: Use C++ exception handling.
12034         * solib-frv.c: Use C++ exception handling.
12035         * solib-dsbt.c: Use C++ exception handling.
12036         * selftest-arch.c: Use C++ exception handling.
12037         * s390-tdep.c: Use C++ exception handling.
12038         * rust-lang.c: Use C++ exception handling.
12039         * rust-exp.y: Use C++ exception handling.
12040         * rs6000-tdep.c: Use C++ exception handling.
12041         * rs6000-aix-tdep.c: Use C++ exception handling.
12042         * riscv-tdep.c: Use C++ exception handling.
12043         * remote.c: Use C++ exception handling.
12044         * remote-fileio.c: Use C++ exception handling.
12045         * record-full.c: Use C++ exception handling.
12046         * record-btrace.c: Use C++ exception handling.
12047         * python/python.c: Use C++ exception handling.
12048         * python/py-value.c: Use C++ exception handling.
12049         * python/py-utils.c: Use C++ exception handling.
12050         * python/py-unwind.c: Use C++ exception handling.
12051         * python/py-type.c: Use C++ exception handling.
12052         * python/py-symbol.c: Use C++ exception handling.
12053         * python/py-record.c: Use C++ exception handling.
12054         * python/py-record-btrace.c: Use C++ exception handling.
12055         * python/py-progspace.c: Use C++ exception handling.
12056         * python/py-prettyprint.c: Use C++ exception handling.
12057         * python/py-param.c: Use C++ exception handling.
12058         * python/py-objfile.c: Use C++ exception handling.
12059         * python/py-linetable.c: Use C++ exception handling.
12060         * python/py-lazy-string.c: Use C++ exception handling.
12061         * python/py-infthread.c: Use C++ exception handling.
12062         * python/py-inferior.c: Use C++ exception handling.
12063         * python/py-gdb-readline.c: Use C++ exception handling.
12064         * python/py-framefilter.c: Use C++ exception handling.
12065         * python/py-frame.c: Use C++ exception handling.
12066         * python/py-finishbreakpoint.c: Use C++ exception handling.
12067         * python/py-cmd.c: Use C++ exception handling.
12068         * python/py-breakpoint.c: Use C++ exception handling.
12069         * python/py-arch.c: Use C++ exception handling.
12070         * printcmd.c: Use C++ exception handling.
12071         * ppc-linux-tdep.c: Use C++ exception handling.
12072         * parse.c: Use C++ exception handling.
12073         * p-valprint.c: Use C++ exception handling.
12074         * objc-lang.c: Use C++ exception handling.
12075         * mi/mi-main.c: Use C++ exception handling.
12076         * mi/mi-interp.c: Use C++ exception handling.
12077         * mi/mi-cmd-stack.c: Use C++ exception handling.
12078         * mi/mi-cmd-break.c: Use C++ exception handling.
12079         * main.c: Use C++ exception handling.
12080         * linux-thread-db.c: Use C++ exception handling.
12081         * linux-tdep.c: Use C++ exception handling.
12082         * linux-nat.c: Use C++ exception handling.
12083         * linux-fork.c: Use C++ exception handling.
12084         * linespec.c: Use C++ exception handling.
12085         * language.c: Use C++ exception handling.
12086         * jit.c: Use C++ exception handling.
12087         * infrun.c: Use C++ exception handling.
12088         * infcmd.c: Use C++ exception handling.
12089         * infcall.c: Use C++ exception handling.
12090         * inf-loop.c: Use C++ exception handling.
12091         * i386-tdep.c: Use C++ exception handling.
12092         * i386-linux-tdep.c: Use C++ exception handling.
12093         * guile/scm-value.c: Use C++ exception handling.
12094         * guile/scm-type.c: Use C++ exception handling.
12095         * guile/scm-symtab.c: Use C++ exception handling.
12096         * guile/scm-symbol.c: Use C++ exception handling.
12097         * guile/scm-pretty-print.c: Use C++ exception handling.
12098         * guile/scm-ports.c: Use C++ exception handling.
12099         * guile/scm-param.c: Use C++ exception handling.
12100         * guile/scm-math.c: Use C++ exception handling.
12101         * guile/scm-lazy-string.c: Use C++ exception handling.
12102         * guile/scm-frame.c: Use C++ exception handling.
12103         * guile/scm-disasm.c: Use C++ exception handling.
12104         * guile/scm-cmd.c: Use C++ exception handling.
12105         * guile/scm-breakpoint.c: Use C++ exception handling.
12106         * guile/scm-block.c: Use C++ exception handling.
12107         * guile/guile-internal.h: Use C++ exception handling.
12108         * gnu-v3-abi.c: Use C++ exception handling.
12109         * gdbtypes.c: Use C++ exception handling.
12110         * frame.c: Use C++ exception handling.
12111         * frame-unwind.c: Use C++ exception handling.
12112         * fbsd-tdep.c: Use C++ exception handling.
12113         * f-valprint.c: Use C++ exception handling.
12114         * exec.c: Use C++ exception handling.
12115         * event-top.c: Use C++ exception handling.
12116         * event-loop.c: Use C++ exception handling.
12117         * eval.c: Use C++ exception handling.
12118         * dwarf2read.c: Use C++ exception handling.
12119         * dwarf2loc.c: Use C++ exception handling.
12120         * dwarf2-frame.c: Use C++ exception handling.
12121         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12122         * dwarf-index-write.c: Use C++ exception handling.
12123         * dwarf-index-cache.c: Use C++ exception handling.
12124         * dtrace-probe.c: Use C++ exception handling.
12125         * disasm-selftests.c: Use C++ exception handling.
12126         * darwin-nat.c: Use C++ exception handling.
12127         * cp-valprint.c: Use C++ exception handling.
12128         * cp-support.c: Use C++ exception handling.
12129         * cp-abi.c: Use C++ exception handling.
12130         * corelow.c: Use C++ exception handling.
12131         * completer.c: Use C++ exception handling.
12132         * compile/compile-object-run.c: Use C++ exception handling.
12133         * compile/compile-object-load.c: Use C++ exception handling.
12134         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12135         * compile/compile-c-symbols.c: Use C++ exception handling.
12136         * common/selftest.c: Use C++ exception handling.
12137         * common/new-op.c: Use C++ exception handling.
12138         * cli/cli-script.c: Use C++ exception handling.
12139         * cli/cli-interp.c: Use C++ exception handling.
12140         * cli/cli-cmds.c: Use C++ exception handling.
12141         * c-varobj.c: Use C++ exception handling.
12142         * btrace.c: Use C++ exception handling.
12143         * breakpoint.c: Use C++ exception handling.
12144         * break-catch-throw.c: Use C++ exception handling.
12145         * arch-utils.c: Use C++ exception handling.
12146         * amd64-tdep.c: Use C++ exception handling.
12147         * ada-valprint.c: Use C++ exception handling.
12148         * ada-typeprint.c: Use C++ exception handling.
12149         * ada-lang.c: Use C++ exception handling.
12150         * aarch64-tdep.c: Use C++ exception handling.
12151
12152 2019-04-08  Tom Tromey  <tom@tromey.com>
12153
12154         * xml-support.c (gdb_xml_parser::parse): Update.
12155         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12156         * value.c (show_convenience): Update.
12157         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12158         (test_parse_flags_qcs): Update.
12159         * thread.c (thr_try_catch_cmd): Update.
12160         * target.c (target_translate_tls_address): Update.
12161         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12162         (info_frame_command_core, frame_apply_command_count): Update.
12163         * rust-exp.y (rust_lex_exception_test): Update.
12164         * riscv-tdep.c (riscv_print_one_register_info): Update.
12165         * remote.c (remote_target::enable_btrace): Update.
12166         * record-btrace.c (record_btrace_enable_warn): Update.
12167         * python/py-utils.c (gdbpy_convert_exception): Update.
12168         * printcmd.c (do_one_display, print_variable_and_value): Update.
12169         * mi/mi-main.c (mi_print_exception): Update.
12170         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12171         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12172         * linux-nat.c (linux_nat_target::attach): Update.
12173         * linux-fork.c (class scoped_switch_fork_info): Update.
12174         * infrun.c (displaced_step_prepare): Update.
12175         * infcall.c (call_function_by_hand_dummy): Update.
12176         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12177         * gnu-v3-abi.c (print_one_vtable): Update.
12178         * frame.c (get_prev_frame_always): Update.
12179         * f-valprint.c (info_common_command_for_block): Update.
12180         * exec.c (try_open_exec_file): Update.
12181         * exceptions.c (print_exception, exception_print)
12182         (exception_fprintf, exception_print_same): Update.
12183         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12184         * dwarf-index-cache.c (index_cache::store)
12185         (index_cache::lookup_gdb_index): Update.
12186         * darwin-nat.c (maybe_cache_shell): Update.
12187         * cp-valprint.c (cp_print_value_fields): Update.
12188         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12189         (gcc_cplus_symbol_address): Update.
12190         * compile/compile-c-symbols.c (gcc_convert_symbol)
12191         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12192         * common/selftest.c: Update.
12193         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12194         a std::string.
12195         (exception_try_scope_entry, exception_try_scope_exit): Don't
12196         declare.
12197         (struct exception_try_scope): Remove.
12198         (TRY): Don't use exception_try_scope.
12199         (struct gdb_exception): Add constructor, operator=.
12200         <what>: New method.
12201         (struct gdb_exception_RETURN_MASK_ALL)
12202         (struct gdb_exception_RETURN_MASK_ERROR)
12203         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12204         (struct gdb_quit_bad_alloc): Update.
12205         * common/common-exceptions.c (exception_none): Change
12206         initializer.
12207         (struct catcher) <state, exception>: Initialize inline.
12208         <prev>: Remove member.
12209         (current_catcher): Remove.
12210         (catchers): New global.
12211         (exceptions_state_mc_init): Simplify.
12212         (catcher_pop): Remove.
12213         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12214         (try_scope_depth, exception_try_scope_entry)
12215         (exception_try_scope_exit): Remove.
12216         (throw_exception_sjlj): Update.
12217         (exception_messages, exception_messages_size): Remove.
12218         (throw_it): Simplify.
12219         (gdb_exception_sliced_copy): Remove.
12220         (throw_exception_cxx): Update.
12221         * cli/cli-script.c (script_from_file): Update.
12222         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12223         Update.
12224         * ada-valprint.c (ada_val_print): Update.
12225         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12226         (create_excep_cond_exprs): Update.
12227
12228 2019-04-08  Tom Tromey  <tom@tromey.com>
12229
12230         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12231         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12232         (TRY, CATCH, END_CATCH): Remove some definitions.
12233         * common/common-exceptions.c: Don't use GDB_XCPT.
12234         (catcher_list_size): Remove.
12235         (throw_exception, throw_it): Simplify.
12236
12237 2019-04-05  Tom Tromey  <tom@tromey.com>
12238
12239         Revert the header-sorting patch.
12240         * ft32-tdep.c: Revert.
12241         * frv-tdep.c: Revert.
12242         * frv-linux-tdep.c: Revert.
12243         * frame.c: Revert.
12244         * frame-unwind.c: Revert.
12245         * frame-base.c: Revert.
12246         * fork-child.c: Revert.
12247         * findvar.c: Revert.
12248         * findcmd.c: Revert.
12249         * filesystem.c: Revert.
12250         * filename-seen-cache.h: Revert.
12251         * filename-seen-cache.c: Revert.
12252         * fbsd-tdep.c: Revert.
12253         * fbsd-nat.h: Revert.
12254         * fbsd-nat.c: Revert.
12255         * f-valprint.c: Revert.
12256         * f-typeprint.c: Revert.
12257         * f-lang.c: Revert.
12258         * extension.h: Revert.
12259         * extension.c: Revert.
12260         * extension-priv.h: Revert.
12261         * expprint.c: Revert.
12262         * exec.h: Revert.
12263         * exec.c: Revert.
12264         * exceptions.c: Revert.
12265         * event-top.c: Revert.
12266         * event-loop.c: Revert.
12267         * eval.c: Revert.
12268         * elfread.c: Revert.
12269         * dwarf2read.h: Revert.
12270         * dwarf2read.c: Revert.
12271         * dwarf2loc.c: Revert.
12272         * dwarf2expr.h: Revert.
12273         * dwarf2expr.c: Revert.
12274         * dwarf2-frame.c: Revert.
12275         * dwarf2-frame-tailcall.c: Revert.
12276         * dwarf-index-write.h: Revert.
12277         * dwarf-index-write.c: Revert.
12278         * dwarf-index-common.c: Revert.
12279         * dwarf-index-cache.h: Revert.
12280         * dwarf-index-cache.c: Revert.
12281         * dummy-frame.c: Revert.
12282         * dtrace-probe.c: Revert.
12283         * disasm.h: Revert.
12284         * disasm.c: Revert.
12285         * disasm-selftests.c: Revert.
12286         * dictionary.c: Revert.
12287         * dicos-tdep.c: Revert.
12288         * demangle.c: Revert.
12289         * dcache.h: Revert.
12290         * dcache.c: Revert.
12291         * darwin-nat.h: Revert.
12292         * darwin-nat.c: Revert.
12293         * darwin-nat-info.c: Revert.
12294         * d-valprint.c: Revert.
12295         * d-namespace.c: Revert.
12296         * d-lang.c: Revert.
12297         * ctf.c: Revert.
12298         * csky-tdep.c: Revert.
12299         * csky-linux-tdep.c: Revert.
12300         * cris-tdep.c: Revert.
12301         * cris-linux-tdep.c: Revert.
12302         * cp-valprint.c: Revert.
12303         * cp-support.c: Revert.
12304         * cp-namespace.c: Revert.
12305         * cp-abi.c: Revert.
12306         * corelow.c: Revert.
12307         * corefile.c: Revert.
12308         * continuations.c: Revert.
12309         * completer.h: Revert.
12310         * completer.c: Revert.
12311         * complaints.c: Revert.
12312         * coffread.c: Revert.
12313         * coff-pe-read.c: Revert.
12314         * cli-out.h: Revert.
12315         * cli-out.c: Revert.
12316         * charset.c: Revert.
12317         * c-varobj.c: Revert.
12318         * c-valprint.c: Revert.
12319         * c-typeprint.c: Revert.
12320         * c-lang.c: Revert.
12321         * buildsym.c: Revert.
12322         * buildsym-legacy.c: Revert.
12323         * build-id.h: Revert.
12324         * build-id.c: Revert.
12325         * btrace.c: Revert.
12326         * bsd-uthread.c: Revert.
12327         * breakpoint.h: Revert.
12328         * breakpoint.c: Revert.
12329         * break-catch-throw.c: Revert.
12330         * break-catch-syscall.c: Revert.
12331         * break-catch-sig.c: Revert.
12332         * blockframe.c: Revert.
12333         * block.c: Revert.
12334         * bfin-tdep.c: Revert.
12335         * bfin-linux-tdep.c: Revert.
12336         * bfd-target.c: Revert.
12337         * bcache.c: Revert.
12338         * ax-general.c: Revert.
12339         * ax-gdb.h: Revert.
12340         * ax-gdb.c: Revert.
12341         * avr-tdep.c: Revert.
12342         * auxv.c: Revert.
12343         * auto-load.c: Revert.
12344         * arm-wince-tdep.c: Revert.
12345         * arm-tdep.c: Revert.
12346         * arm-symbian-tdep.c: Revert.
12347         * arm-pikeos-tdep.c: Revert.
12348         * arm-obsd-tdep.c: Revert.
12349         * arm-nbsd-tdep.c: Revert.
12350         * arm-nbsd-nat.c: Revert.
12351         * arm-linux-tdep.c: Revert.
12352         * arm-linux-nat.c: Revert.
12353         * arm-fbsd-tdep.c: Revert.
12354         * arm-fbsd-nat.c: Revert.
12355         * arm-bsd-tdep.c: Revert.
12356         * arch-utils.c: Revert.
12357         * arc-tdep.c: Revert.
12358         * arc-newlib-tdep.c: Revert.
12359         * annotate.h: Revert.
12360         * annotate.c: Revert.
12361         * amd64-windows-tdep.c: Revert.
12362         * amd64-windows-nat.c: Revert.
12363         * amd64-tdep.c: Revert.
12364         * amd64-sol2-tdep.c: Revert.
12365         * amd64-obsd-tdep.c: Revert.
12366         * amd64-obsd-nat.c: Revert.
12367         * amd64-nbsd-tdep.c: Revert.
12368         * amd64-nbsd-nat.c: Revert.
12369         * amd64-nat.c: Revert.
12370         * amd64-linux-tdep.c: Revert.
12371         * amd64-linux-nat.c: Revert.
12372         * amd64-fbsd-tdep.c: Revert.
12373         * amd64-fbsd-nat.c: Revert.
12374         * amd64-dicos-tdep.c: Revert.
12375         * amd64-darwin-tdep.c: Revert.
12376         * amd64-bsd-nat.c: Revert.
12377         * alpha-tdep.c: Revert.
12378         * alpha-obsd-tdep.c: Revert.
12379         * alpha-nbsd-tdep.c: Revert.
12380         * alpha-mdebug-tdep.c: Revert.
12381         * alpha-linux-tdep.c: Revert.
12382         * alpha-linux-nat.c: Revert.
12383         * alpha-bsd-tdep.c: Revert.
12384         * alpha-bsd-nat.c: Revert.
12385         * aix-thread.c: Revert.
12386         * agent.c: Revert.
12387         * addrmap.c: Revert.
12388         * ada-varobj.c: Revert.
12389         * ada-valprint.c: Revert.
12390         * ada-typeprint.c: Revert.
12391         * ada-tasks.c: Revert.
12392         * ada-lang.c: Revert.
12393         * aarch64-tdep.c: Revert.
12394         * aarch64-ravenscar-thread.c: Revert.
12395         * aarch64-newlib-tdep.c: Revert.
12396         * aarch64-linux-tdep.c: Revert.
12397         * aarch64-linux-nat.c: Revert.
12398         * aarch64-fbsd-tdep.c: Revert.
12399         * aarch64-fbsd-nat.c: Revert.
12400         * aarch32-linux-nat.c: Revert.
12401
12402 2019-04-05  Tom Tromey  <tom@tromey.com>
12403
12404         * ft32-tdep.c: Sort headers.
12405         * frv-tdep.c: Sort headers.
12406         * frv-linux-tdep.c: Sort headers.
12407         * frame.c: Sort headers.
12408         * frame-unwind.c: Sort headers.
12409         * frame-base.c: Sort headers.
12410         * fork-child.c: Sort headers.
12411         * findvar.c: Sort headers.
12412         * findcmd.c: Sort headers.
12413         * filesystem.c: Sort headers.
12414         * filename-seen-cache.h: Sort headers.
12415         * filename-seen-cache.c: Sort headers.
12416         * fbsd-tdep.c: Sort headers.
12417         * fbsd-nat.h: Sort headers.
12418         * fbsd-nat.c: Sort headers.
12419         * f-valprint.c: Sort headers.
12420         * f-typeprint.c: Sort headers.
12421         * f-lang.c: Sort headers.
12422         * extension.h: Sort headers.
12423         * extension.c: Sort headers.
12424         * extension-priv.h: Sort headers.
12425         * expprint.c: Sort headers.
12426         * exec.h: Sort headers.
12427         * exec.c: Sort headers.
12428         * exceptions.c: Sort headers.
12429         * event-top.c: Sort headers.
12430         * event-loop.c: Sort headers.
12431         * eval.c: Sort headers.
12432         * elfread.c: Sort headers.
12433         * dwarf2read.h: Sort headers.
12434         * dwarf2read.c: Sort headers.
12435         * dwarf2loc.c: Sort headers.
12436         * dwarf2expr.h: Sort headers.
12437         * dwarf2expr.c: Sort headers.
12438         * dwarf2-frame.c: Sort headers.
12439         * dwarf2-frame-tailcall.c: Sort headers.
12440         * dwarf-index-write.h: Sort headers.
12441         * dwarf-index-write.c: Sort headers.
12442         * dwarf-index-common.c: Sort headers.
12443         * dwarf-index-cache.h: Sort headers.
12444         * dwarf-index-cache.c: Sort headers.
12445         * dummy-frame.c: Sort headers.
12446         * dtrace-probe.c: Sort headers.
12447         * disasm.h: Sort headers.
12448         * disasm.c: Sort headers.
12449         * disasm-selftests.c: Sort headers.
12450         * dictionary.c: Sort headers.
12451         * dicos-tdep.c: Sort headers.
12452         * demangle.c: Sort headers.
12453         * dcache.h: Sort headers.
12454         * dcache.c: Sort headers.
12455         * darwin-nat.h: Sort headers.
12456         * darwin-nat.c: Sort headers.
12457         * darwin-nat-info.c: Sort headers.
12458         * d-valprint.c: Sort headers.
12459         * d-namespace.c: Sort headers.
12460         * d-lang.c: Sort headers.
12461         * ctf.c: Sort headers.
12462         * csky-tdep.c: Sort headers.
12463         * csky-linux-tdep.c: Sort headers.
12464         * cris-tdep.c: Sort headers.
12465         * cris-linux-tdep.c: Sort headers.
12466         * cp-valprint.c: Sort headers.
12467         * cp-support.c: Sort headers.
12468         * cp-namespace.c: Sort headers.
12469         * cp-abi.c: Sort headers.
12470         * corelow.c: Sort headers.
12471         * corefile.c: Sort headers.
12472         * continuations.c: Sort headers.
12473         * completer.h: Sort headers.
12474         * completer.c: Sort headers.
12475         * complaints.c: Sort headers.
12476         * coffread.c: Sort headers.
12477         * coff-pe-read.c: Sort headers.
12478         * cli-out.h: Sort headers.
12479         * cli-out.c: Sort headers.
12480         * charset.c: Sort headers.
12481         * c-varobj.c: Sort headers.
12482         * c-valprint.c: Sort headers.
12483         * c-typeprint.c: Sort headers.
12484         * c-lang.c: Sort headers.
12485         * buildsym.c: Sort headers.
12486         * buildsym-legacy.c: Sort headers.
12487         * build-id.h: Sort headers.
12488         * build-id.c: Sort headers.
12489         * btrace.c: Sort headers.
12490         * bsd-uthread.c: Sort headers.
12491         * breakpoint.h: Sort headers.
12492         * breakpoint.c: Sort headers.
12493         * break-catch-throw.c: Sort headers.
12494         * break-catch-syscall.c: Sort headers.
12495         * break-catch-sig.c: Sort headers.
12496         * blockframe.c: Sort headers.
12497         * block.c: Sort headers.
12498         * bfin-tdep.c: Sort headers.
12499         * bfin-linux-tdep.c: Sort headers.
12500         * bfd-target.c: Sort headers.
12501         * bcache.c: Sort headers.
12502         * ax-general.c: Sort headers.
12503         * ax-gdb.h: Sort headers.
12504         * ax-gdb.c: Sort headers.
12505         * avr-tdep.c: Sort headers.
12506         * auxv.c: Sort headers.
12507         * auto-load.c: Sort headers.
12508         * arm-wince-tdep.c: Sort headers.
12509         * arm-tdep.c: Sort headers.
12510         * arm-symbian-tdep.c: Sort headers.
12511         * arm-pikeos-tdep.c: Sort headers.
12512         * arm-obsd-tdep.c: Sort headers.
12513         * arm-nbsd-tdep.c: Sort headers.
12514         * arm-nbsd-nat.c: Sort headers.
12515         * arm-linux-tdep.c: Sort headers.
12516         * arm-linux-nat.c: Sort headers.
12517         * arm-fbsd-tdep.c: Sort headers.
12518         * arm-fbsd-nat.c: Sort headers.
12519         * arm-bsd-tdep.c: Sort headers.
12520         * arch-utils.c: Sort headers.
12521         * arc-tdep.c: Sort headers.
12522         * arc-newlib-tdep.c: Sort headers.
12523         * annotate.h: Sort headers.
12524         * annotate.c: Sort headers.
12525         * amd64-windows-tdep.c: Sort headers.
12526         * amd64-windows-nat.c: Sort headers.
12527         * amd64-tdep.c: Sort headers.
12528         * amd64-sol2-tdep.c: Sort headers.
12529         * amd64-obsd-tdep.c: Sort headers.
12530         * amd64-obsd-nat.c: Sort headers.
12531         * amd64-nbsd-tdep.c: Sort headers.
12532         * amd64-nbsd-nat.c: Sort headers.
12533         * amd64-nat.c: Sort headers.
12534         * amd64-linux-tdep.c: Sort headers.
12535         * amd64-linux-nat.c: Sort headers.
12536         * amd64-fbsd-tdep.c: Sort headers.
12537         * amd64-fbsd-nat.c: Sort headers.
12538         * amd64-dicos-tdep.c: Sort headers.
12539         * amd64-darwin-tdep.c: Sort headers.
12540         * amd64-bsd-nat.c: Sort headers.
12541         * alpha-tdep.c: Sort headers.
12542         * alpha-obsd-tdep.c: Sort headers.
12543         * alpha-nbsd-tdep.c: Sort headers.
12544         * alpha-mdebug-tdep.c: Sort headers.
12545         * alpha-linux-tdep.c: Sort headers.
12546         * alpha-linux-nat.c: Sort headers.
12547         * alpha-bsd-tdep.c: Sort headers.
12548         * alpha-bsd-nat.c: Sort headers.
12549         * aix-thread.c: Sort headers.
12550         * agent.c: Sort headers.
12551         * addrmap.c: Sort headers.
12552         * ada-varobj.c: Sort headers.
12553         * ada-valprint.c: Sort headers.
12554         * ada-typeprint.c: Sort headers.
12555         * ada-tasks.c: Sort headers.
12556         * ada-lang.c: Sort headers.
12557         * aarch64-tdep.c: Sort headers.
12558         * aarch64-ravenscar-thread.c: Sort headers.
12559         * aarch64-newlib-tdep.c: Sort headers.
12560         * aarch64-linux-tdep.c: Sort headers.
12561         * aarch64-linux-nat.c: Sort headers.
12562         * aarch64-fbsd-tdep.c: Sort headers.
12563         * aarch64-fbsd-nat.c: Sort headers.
12564         * aarch32-linux-nat.c: Sort headers.
12565
12566 2019-04-04  Tom Tromey  <tom@tromey.com>
12567
12568         * varobj.c (varobj_create): Update.
12569         * rust-exp.y (struct rust_parser) <update_innermost_block,
12570         lookup_symbol>: New methods.
12571         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12572         Rename.
12573         (rust_parser::rust_lookup_type)
12574         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12575         * printcmd.c (display_command, do_one_display): Update.
12576         * parser-defs.h (struct parser_state) <parser_state>: Add
12577         "tracker" parameter.
12578         (block_tracker): New member.
12579         (class innermost_block_tracker) <innermost_block_tracker>: Add
12580         "types" parameter.
12581         <reset>: Remove method.
12582         (innermost_block): Don't declare.
12583         (null_post_parser): Update.
12584         * parse.c (innermost_block): Remove global.
12585         (write_dollar_variable): Update.
12586         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12587         Remove "tracker_types" parameter.
12588         (parse_expression): Add "tracker" parameter.
12589         (parse_expression_for_completion): Update.
12590         (null_post_parser): Add "tracker" parameter.
12591         * p-exp.y: Update rules.
12592         * m2-exp.y: Update rules.
12593         * language.h (struct language_defn) <la_post_parser>: Add
12594         "tracker" parameter.
12595         * go-exp.y: Update rules.
12596         * f-exp.y: Update rules.
12597         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12598         parameter.
12599         * d-exp.y: Update rules.
12600         * c-exp.y: Update rules.
12601         * breakpoint.c (set_breakpoint_condition): Create an
12602         innermost_block_tracker.
12603         (watch_command_1): Likewise.
12604         * ada-lang.c (resolve): Add "tracker" parameter.
12605         (resolve_subexp): Likewise.
12606         * ada-exp.y (write_var_from_sym): Update.
12607
12608 2019-04-04  Tom Tromey  <tom@tromey.com>
12609
12610         * type-stack.h: New file.
12611         * type-stack.c: New file.
12612         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12613         type-stack.h.
12614         (insert_into_type_stack, insert_type, push_type, push_type_int)
12615         (insert_type_address_space, pop_type, pop_type_int)
12616         (pop_typelist, pop_type_stack, append_type_stack)
12617         (push_type_stack, get_type_stack, push_typelist)
12618         (follow_type_instance_flags, follow_types): Don't declare.
12619         * parse.c (type_stack): Remove global.
12620         (parse_exp_in_context): Update.
12621         (insert_into_type_stack, insert_type, push_type, push_type_int)
12622         (insert_type_address_space, pop_type, pop_type_int)
12623         (pop_typelist, pop_type_stack, append_type_stack)
12624         (push_type_stack, get_type_stack, push_typelist)
12625         (follow_type_instance_flags, follow_types): Remove (moved to
12626         type-stack.c).
12627         * f-exp.y (type_stack): New global.
12628         Update rules.
12629         (push_kind_type, f_parse): Update.
12630         * d-exp.y (type_stack): New global.
12631         Update rules.
12632         (d_parse): Update.
12633         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12634         Update rules.
12635         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12636         (HFILES_NO_SRCDIR): Add type-stack.h.
12637
12638 2019-04-04  Tom Tromey  <tom@tromey.com>
12639
12640         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12641         (rust_parser::convert_ast_to_expression, rust_parse)
12642         (rust_lex_test_completion, rust_lex_tests): Update.
12643         * parser-defs.h (struct expr_completion_state): New.
12644         (struct parser_state) <parser_state>: Add completion parameter.
12645         <mark_struct_expression, mark_completion_tag>: New methods.
12646         <parse_completion, m_completion_state>: New members.
12647         (prefixify_expression, null_post_parser): Update.
12648         (mark_struct_expression, mark_completion_tag): Don't declare.
12649         * parse.c (parse_completion, expout_last_struct)
12650         (expout_tag_completion_type, expout_completion_name): Remove
12651         globals.
12652         (parser_state::mark_struct_expression)
12653         (parser_state::mark_completion_tag): Now methods.
12654         (prefixify_expression): Add last_struct parameter.
12655         (prefixify_subexp): Likewise.
12656         (parse_exp_1): Update.
12657         (parse_exp_in_context): Add cstate parameter.  Update.
12658         (parse_expression_for_completion): Create an
12659         expr_completion_state.
12660         (null_post_parser): Add "completion" parameter.
12661         * p-exp.y: Update rules.
12662         (yylex): Update.
12663         * language.h (struct language_defn) <la_post_parser>: Add
12664         "completing" parameter.
12665         * go-exp.y: Update rules.
12666         (lex_one_token): Update.
12667         * expression.h (parse_completion): Don't declare.
12668         * d-exp.y: Update rules.
12669         (lex_one_token): Update rules.
12670         * c-exp.y: Update rules.
12671         (lex_one_token): Update.
12672         * ada-lang.c (resolve): Add "parse_completion" parameter.
12673         (resolve_subexp): Likewise.
12674         (ada_resolve_function): Likewise.
12675
12676 2019-04-04  Tom Tromey  <tom@tromey.com>
12677
12678         * parser-defs.h (struct parser_state) <start_arglist,
12679         end_arglist>: New methods.
12680         <arglist_len, m_funcall_chain>: New members.
12681         (arglist_len, start_arglist, end_arglist): Don't declare.
12682         * parse.c (arglist_len, funcall_chain): Remove global.
12683         (start_arglist, end_arglist): Remove functions.
12684         (parse_exp_in_context): Update.
12685         * p-exp.y: Update rules.
12686         * m2-exp.y: Update rules.
12687         * go-exp.y: Update rules.
12688         * f-exp.y: Update rules.
12689         * d-exp.y: Update rules.
12690         * c-exp.y: Update rules.
12691
12692 2019-04-04  Tom Tromey  <tom@tromey.com>
12693
12694         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12695         lex_operator, push_back>: New methods.
12696         Update all rules.
12697         (rust_parser::lex_hex, lex_escape): Rename and update.
12698         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12699         (rust_parser::lex_operator): Rename and update.
12700         (rust_parser::lex_number, rustyylex, rustyyerror)
12701         (rust_lex_test_init, rust_lex_test_sequence)
12702         (rust_lex_test_push_back, rust_lex_tests): Update.
12703         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12704         parameter.
12705         <lexptr, prev_lexptr>: New members.
12706         (lexptr, prev_lexptr): Don't declare.
12707         * parse.c (lexptr, prev_lexptr): Remove globals.
12708         (parse_exp_in_context): Update.
12709         * p-exp.y (yylex, yyerror): Update.
12710         * m2-exp.y (parse_number, yylex, yyerror): Update.
12711         * go-exp.y (lex_one_token, yyerror): Update.
12712         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12713         * d-exp.y (lex_one_token, yyerror): Update.
12714         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12715         (lex_one_token, yyerror): Update.
12716         * ada-lex.l (YY_INPUT): Update.
12717         (rewind_to_char): Update.
12718         * ada-exp.y (yyerror): Update.
12719
12720 2019-04-04  Tom Tromey  <tom@tromey.com>
12721
12722         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12723         * parser-defs.h (struct parser_state) <parser_state>: Add new
12724         parameter.
12725         <comma_terminates>: New member.
12726         (comma_terminates): Don't declare global.
12727         * parse.c (comma_terminates): Remove global.
12728         (parse_exp_in_context): Update.
12729         * p-exp.y (yylex): Update.
12730         * m2-exp.y (yylex): Update.
12731         * go-exp.y (lex_one_token): Update.
12732         * f-exp.y (yylex): Update.
12733         * d-exp.y (lex_one_token): Update.
12734         * c-exp.y (lex_one_token): Update.
12735         * ada-lex.l: Update.
12736
12737 2019-04-04  Tom Tromey  <tom@tromey.com>
12738
12739         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12740         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12741         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12742         * parser-defs.h (paren_depth): Don't declare.
12743         * parse.c (paren_depth): Remove global.
12744         (parse_exp_in_context): Update.
12745         * p-exp.y (paren_depth): New global.
12746         (pascal_parse): Initialize it.
12747         * m2-exp.y (paren_depth): New global.
12748         (m2_parse): Initialize it.
12749         * go-exp.y (paren_depth): New global.
12750         (go_parse): Initialize it.
12751         * f-exp.y (paren_depth): New global.
12752         (f_parse): Initialize it.
12753         * d-exp.y (paren_depth): New global.
12754         (d_parse): Initialize it.
12755         * c-exp.y (paren_depth): New global.
12756         (c_parse): Initialize it.
12757         * ada-lex.l (paren_depth): New global.
12758         (lexer_init): Initialize it.
12759
12760 2019-04-04  Tom Tromey  <tom@tromey.com>
12761
12762         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12763         (rust_parser::convert_ast_to_type)
12764         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12765         * parser-defs.h (struct parser_state) <parser_state>: Add
12766         parameters.  Initialize new members.
12767         <expression_context_block, expression_context_pc>: New members.
12768         * parse.c (expression_context_block, expression_context_pc):
12769         Remove globals.
12770         (parse_exp_in_context): Update.
12771         * p-exp.y: Update all rules.
12772         (yylex): Update.
12773         * m2-exp.y: Update all rules.
12774         (yylex): Update.
12775         * go-exp.y (yylex): Update.
12776         * f-exp.y (yylex): Update.
12777         * d-exp.y: Update all rules.
12778         (yylex): Update.
12779         * c-exp.y: Update all rules.
12780         (lex_one_token, classify_name, yylex, c_parse): Update.
12781         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12782
12783 2019-04-04  Tom Tromey  <tom@tromey.com>
12784
12785         * gdbarch.h, gdbarch.c: Rebuild.
12786         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12787         * stap-probe.h:
12788         (struct stap_parse_info): Replace "parser_state" with
12789         "expr_builder".
12790         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12791         (parser_state): New class.
12792         * parse.c (expr_builder): Rename.
12793         (expr_builder::release): Rename.
12794         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12795         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12796         (write_exp_elt_longcst, write_exp_elt_floatcst)
12797         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12798         (write_exp_string_vector, write_exp_bitstring)
12799         (write_exp_msymbol, mark_struct_expression)
12800         (write_dollar_variable)
12801         (insert_type_address_space, increase_expout_size): Replace
12802         "parser_state" with "expr_builder".
12803         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12804         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12805         "parser_state" with "expr_builder".
12806
12807 2019-04-04  Tom Tromey  <tom@tromey.com>
12808
12809         * rust-exp.y: Replace "parse_language" with method call.
12810         * p-exp.y:
12811         (yylex): Replace "parse_language" with method call.
12812         * m2-exp.y:
12813         (yylex): Replace "parse_language" with method call.
12814         * go-exp.y (classify_name): Replace "parse_language" with method
12815         call.
12816         * f-exp.y (yylex): Replace "parse_language" with method call.
12817         * d-exp.y (lex_one_token): Replace "parse_language" with method
12818         call.
12819         * c-exp.y:
12820         (lex_one_token, classify_name, yylex): Replace "parse_language"
12821         with method call.
12822         * ada-exp.y (find_primitive_type, type_char)
12823         (type_system_address): Replace "parse_language" with method call.
12824
12825 2019-04-04  Tom Tromey  <tom@tromey.com>
12826
12827         * rust-exp.y: Replace "parse_gdbarch" with method call.
12828         * parse.c (write_dollar_variable, insert_type_address_space):
12829         Replace "parse_gdbarch" with method call.
12830         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12831         call.
12832         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12833         call.
12834         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12835         "parse_gdbarch" with method call.
12836         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12837         with method call.
12838         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12839         "parse_gdbarch" with method call.
12840         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12841         "parse_gdbarch" with method call.
12842         * c-exp.y (parse_type, parse_number, classify_name): Replace
12843         "parse_gdbarch" with method call.
12844         * ada-lex.l: Replace "parse_gdbarch" with method call.
12845         * ada-exp.y (parse_type, find_primitive_type, type_char)
12846         (type_system_address): Replace "parse_gdbarch" with method call.
12847
12848 2019-04-04  Tom Tromey  <tom@tromey.com>
12849
12850         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12851         * stap-probe.c (stap_parse_argument): Update.
12852         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12853         initial_size parameter.
12854         * rust-exp.y (rust_lex_tests): Update.
12855         * parse.c (parser_state): Update.
12856         (parse_exp_in_context): Update.
12857         * parser-defs.h (struct parser_state) <parser_state>: Remove
12858         "initial_size" parameter.
12859
12860 2019-04-04  Tom Tromey  <tom@tromey.com>
12861
12862         * parser-defs.h (increase_expout_size): Don't declare.
12863         * parse.c (increase_expout_size): Now static.
12864
12865 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12866
12867         * gnu-nat.c (gnu_nat_target::wait): Fix
12868         target_waitstatus_to_string call.
12869
12870 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12871
12872         * eval.c (evaluate_subexp_standard): Handle internal functions
12873         during Fortran function call handling.
12874
12875 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12876
12877         * NEWS: Mention new internal functions.
12878         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12879         (read_base_type): Use dwarf2_init_complex_target_type.
12880         * value.c (creal_internal_fn): New function.
12881         (cimag_internal_fn): New function.
12882         (_initialize_values): Register new internal functions.
12883
12884 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12885
12886         * infrun.c (stop_all_threads): If debug_infrun, always
12887         trace the wait status after wait_one, using
12888         target_waitstatus_to_string and target_pid_to_str.
12889         (handle_inferior_event): Replace various trace of
12890         wait status kind by a single trace.
12891         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12892         wait status kind image by target_waitstatus_to_string.
12893         * target/waitstatus.c (target_waitstatus_to_string): Fix
12894         obsolete comment.
12895
12896 2019-04-01  Tom Tromey  <tromey@adacore.com>
12897
12898         PR symtab/23331:
12899         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12900
12901 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12902             Pedro Alves  <palves@redhat.com>
12903
12904         * top.c (quit_force): Call 'finalize_values'.
12905         * value.c (finalize_values): New function.
12906         * value.h (finalize_values): Declare.
12907
12908 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12909
12910         * NEWS: Announce $_gdb_major and $_gdb_minor.
12911
12912         * top.c (init_gdb_version_vars): New function.
12913         (gdb_init): Call init_gdb_version_vars.
12914
12915 2019-03-29  Tom Tromey  <tromey@adacore.com>
12916
12917         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12918         help text.  Remove dead code.
12919
12920 2019-03-29  Keith Seitz  <keiths@redhat.com>
12921
12922         From Siddhesh Poyarekar:
12923         * f-lang.h (f77_get_upperbound): Return LONGEST.
12924         (f77_get_lowerbound): Likewise.
12925         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12926         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12927         print them.
12928         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12929         plongest to format print it.
12930         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12931         (f77_get_upperbound): Likewise.
12932         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12933         LOWER_BOUND to LONGEST.
12934         (f77_create_arrayprint_offset_tbl): Likewise.
12935
12936 2019-03-29  Keith Seitz  <keiths@redhat.com>
12937
12938         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12939         %s/pulongest for TYPE_LENGTH instead of %d in format
12940         strings.
12941         * ada-typerint.c (ada_print_type): Likewise.
12942         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12943         * compile/compile-c-support.c (generate_register_struct): Likewise.
12944         * gdbtypes.c (recursive_dump_type): Likewise.
12945         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12946         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12947         instead of %d in format strings.
12948         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12949         to std::min to ULONGEST.
12950         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12951         instead of %d in format strings.
12952         * tracepoint.c (info_scope_command): Likewise.
12953         * typeprint.c (print_offset_data::update)
12954         (print_offset_data::finish): Likewise.
12955         * xtensa-tdep.c (xtensa_store_return_value)
12956         (xtensa_push_dummy_call): Likewise.
12957
12958 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12959
12960         * windows-nat.c (display_selector): Fixed format specifications
12961         for 64-bit Cygwin.
12962
12963 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12964
12965         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12966
12967 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12968
12969         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12970         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12971         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12972         (nios2_linux_init_abi): Install it.
12973
12974 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12975
12976         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12977
12978 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12979
12980         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12981
12982 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12983             Tom Tromey  <tromey@adacore.com>
12984
12985         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12986
12987 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12988
12989         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12990         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12991         method to compute the bounds of range types. Also print "[evaluated]"
12992         if the bounds' values come from a dynamic evaluation.
12993
12994 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12995
12996         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12997         whitespace when pretty printing is on.
12998
12999 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13000
13001         * ppc-linux-nat.c: Add include.
13002
13003 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13004
13005         * NEWS: Mention AArch64 Pointer Authentication.
13006
13007 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13008
13009         * arm-linux-nat.c: Add include.
13010
13011 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13012
13013         * source-cache.c (source_cache::get_source_lines): Re-read
13014         fullname after calling open_source_file.
13015
13016 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13017
13018         * NEWS: Mention TLS support for FreeBSD.
13019
13020 2019-03-25  Tom Tromey  <tromey@adacore.com>
13021
13022         * minsyms.c (BUNCH_SIZE): Update comment.
13023         (~minimal_symbol_reader): Remove old comment.
13024         (compact_minimal_symbols): Update comment.
13025         (minimal_symbol_reader::install): Remove old comment.  Update
13026         other comments.
13027
13028 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13029
13030         * s390-linux-nat.c: Add include.
13031
13032 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13033
13034         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13035         Call linux_get_hwcap.
13036         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13037         Likewise.
13038         (aarch64_linux_get_hwcap): Remove function.
13039         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13040         declaration.
13041         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13042         linux_get_hwcap.
13043         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13044         * linux-tdep.c (linux_get_hwcap): Add function.
13045         (linux_get_hwcap2): Likewise.
13046         * linux-tdep.h (linux_get_hwcap): Add declaration.
13047         (linux_get_hwcap2): Likewise.
13048         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13049         (ppc_linux_get_hwcap2): Likewise.
13050         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13051         linux_get_hwcap.
13052         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13053         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13054         (ppc_linux_nat_target::read_description): Likewise.
13055         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13056         * s390-linux-nat.c: Likewise.
13057         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13058
13059 2019-03-24  Tom Tromey  <tom@tromey.com>
13060
13061         * ada-lang.c (standard_lookup): Simplify initialization.
13062         (ada_lookup_symbol_nonlocal): Simplify return.
13063         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13064         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13065         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13066         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13067         initialization.
13068         * solib.c (solib_global_lookup): Simplify.
13069         * symtab.c (null_block_symbol): Remove.
13070         (symbol_cache_lookup): Simplify returns.
13071         (lookup_language_this): Simplify returns.
13072         (lookup_symbol_aux): Simplify return.
13073         (lookup_local_symbol): Simplify returns.
13074         (lookup_global_symbol_from_objfile): Simplify return.
13075         (lookup_symbol_in_objfile_symtabs)
13076         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13077         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13078         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13079         * cp-namespace.c (cp_lookup_bare_symbol)
13080         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13081         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13082         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13083         (cp_lookup_symbol_via_imports): Simplify initialization.
13084         (find_symbol_in_baseclass): Likewise.
13085         * symtab.h (null_block_symbol): Remove.
13086         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13087         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13088         (d_lookup_symbol_module): Likewise.
13089         (find_symbol_in_baseclass): Simplify initialization.
13090
13091 2019-03-24  Tom Tromey  <tom@tromey.com>
13092
13093         * expression.h: Don't include symtab.h.
13094         (struct block): Forward declare.
13095
13096 2019-03-24  Tom Tromey  <tom@tromey.com>
13097
13098         * c-exp.y (typebase): Remove casts.
13099         * gdbtypes.c (lookup_unsigned_typename, )
13100         (lookup_signed_typename): Remove cast.
13101         * eval.c (parse_to_comma_and_eval): Remove cast.
13102         * parse.c (write_dollar_variable): Remove cast.
13103         * block.h (struct block) <superblock>: Now const.
13104         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13105         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13106         (map_block): Make "block" const.
13107         * symfile.h (struct quick_symbol_functions)
13108         <map_matching_symbols>: Constify block argument to "callback".
13109         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13110         const.
13111         (find_pc_sect_compunit_symtab): Make "b" const.
13112         (find_symbol_at_address): Likewise.
13113         (search_symbols): Likewise.
13114         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13115         (dw2_debug_names_lookup_symbol): Likewise.
13116         (dw2_map_matching_symbols): Update.
13117         * p-valprint.c (pascal_val_print): Remove "block".
13118         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13119         (aux_add_nonlocal_symbols): Make "block" const.
13120         (resolve_subexp): Remove cast.
13121         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13122         const.
13123         (iterate_over_file_blocks): Likewise.
13124         * f-exp.y (%union) <bval>: Remove.
13125         * coffread.c (patch_opaque_types): Make "b" const.
13126         * spu-tdep.c (spu_catch_start): Make "block" const.
13127         * c-valprint.c (print_unpacked_pointer): Remove "block".
13128         * symmisc.c (dump_symtab_1): Make "b" const.
13129         (block_depth): Make "block" const.
13130         * d-exp.y (%union) <bval>: Remove.
13131         * cp-support.h (cp_lookup_rtti_type): Update.
13132         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13133         * psymtab.c (psym_lookup_symbol): Make "block" const.
13134         (maintenance_check_psymtabs): Make "b" const.
13135         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13136         (enumerate_locals, enumerate_args): Update.
13137         * python/py-symtab.c (stpy_global_block): Make "block" const.
13138         (stpy_static_block): Likewise.
13139         * inline-frame.c (block_starting_point_at): Make "new_block"
13140         const.
13141         * block.c (find_block_in_blockvector): Make return type const.
13142         (blockvector_for_pc_sect): Make "b" const.
13143         (find_block_in_blockvector): Make "b" const.
13144
13145 2019-03-23  Tom Tromey  <tom@tromey.com>
13146
13147         * varobj.c (varobj_create): Update.
13148         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13149         * printcmd.c (display_command, do_one_display): Don't reset
13150         innermost_block.
13151         * parser-defs.h (enum innermost_block_tracker_type): Move to
13152         expression.h.
13153         (innermost_block): Update comment.
13154         * parse.c (parse_exp_1): Add tracker_types parameter.
13155         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13156         tracker_types parameter.  Reset innermost_block.
13157         (parse_exp_in_context): Remove.
13158         (parse_expression_for_completion): Update.
13159         * objfiles.c (~objfile): Don't reset expression_context_block or
13160         innermost_block.
13161         * expression.h (enum innermost_block_tracker_type): Move from
13162         parser-defs.h.
13163         (parse_exp_1): Add tracker_types parameter.
13164         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13165         reset innermost_block.
13166
13167 2019-03-23  Tom Tromey  <tom@tromey.com>
13168
13169         * objfiles.h: Include bcache.h.
13170
13171 2019-03-23  Tom Tromey  <tom@tromey.com>
13172
13173         * linespec.c (get_current_search_block): Use
13174         scoped_restore_current_language.
13175         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13176
13177 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13178             Jiong Wang  <jiong.wang@arm.com>
13179
13180         * aarch64-linux-tdep.c
13181         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13182         section.
13183         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13184
13185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13186             Jiong Wang  <jiong.wang@arm.com>
13187
13188         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13189         instructions.
13190         (aarch64_analyze_prologue_test): Add PACIASP test.
13191         (aarch64_prologue_prev_register): Unmask PC value.
13192
13193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13194             Jiong Wang  <jiong.wang@arm.com>
13195
13196         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13197         (aarch64_dwarf2_prev_register): Unmask PC value.
13198         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13199         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13200         DW_CFA_AARCH64_negate_ra_state.
13201         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13202
13203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13204             Jiong Wang  <jiong.wang@arm.com>
13205
13206         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13207         registers.
13208         (aarch64_pseudo_register_name): Likewise.
13209         (aarch64_pseudo_register_type): Likewise.
13210         (aarch64_pseudo_register_reggroup_p): Likewise.
13211         (aarch64_gdbarch_init): Add pauth registers.
13212         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13213         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13214         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13215         (struct gdbarch_tdep): Add regnum for ra_state.
13216
13217 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13218             Jiong Wang  <jiong.wang@arm.com>
13219
13220         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13221
13222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13223             Jiong Wang  <jiong.wang@arm.com>
13224
13225         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13226         function.
13227         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13228         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13229         (aarch64_gdbarch_init): Add puth registers.
13230         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13231         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13232         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13233
13234 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13235             Jiong Wang  <jiong.wang@arm.com>
13236
13237         * aarch64-linux-nat.c
13238         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13239         * aarch64-linux-tdep.c
13240         (aarch64_linux_core_read_description): Likewise.
13241         (aarch64_linux_get_hwcap): New function.
13242         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13243         (aarch64_linux_get_hwcap): New declaration.
13244
13245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13246             Jiong Wang  <jiong.wang@arm.com>
13247
13248         * aarch64-linux-nat.c
13249         (aarch64_linux_nat_target::read_description): Add pauth param.
13250         * aarch64-linux-tdep.c
13251         (aarch64_linux_core_read_description): Likewise.
13252         * aarch64-tdep.c (struct target_desc): Add in pauth.
13253         (aarch64_read_description): Add pauth param.
13254         (aarch64_gdbarch_init): Likewise.
13255         * aarch64-tdep.h (aarch64_read_description): Likewise.
13256         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13257         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13258         * features/Makefile: Add new files.
13259         * features/aarch64-pauth.c: New file.
13260         * features/aarch64-pauth.xml: New file.
13261
13262 2019-03-20  Tom Tromey  <tromey@adacore.com>
13263
13264         * infrun.c (handle_inferior_event): Rename from
13265         handle_inferior_event_1.  Create a scoped_value_mark.
13266         (handle_inferior_event): Remove.
13267
13268 2019-03-19  Tom Tromey  <tromey@adacore.com>
13269
13270         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13271         * infrun.h (print_stop_event): Add "displays" parameter.
13272         * infrun.c (print_stop_event): Add "displays" parameter.
13273
13274 2019-03-19  Pedro Alves  <palves@redhat.com>
13275
13276         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13277         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13278         to -1.  Fix TABs vs spaces.
13279         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13280         * tui/tui-out.h (tui_ui_out) Add intro comments.
13281         <m_line, m_start_of_line>: In-class initialize, and add describing
13282         comment.
13283
13284 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13285
13286         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13287         variable names.
13288         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13289
13290 2019-03-18  Pedro Alves  <palves@redhat.com>
13291             Eli Zaretskii <eliz@gnu.org>
13292
13293         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13294         m_line and m_start_of_line.
13295
13296 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13297
13298         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13299         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13300         it returns a newline.  This fixes a regression in TU mode, whereby
13301         the next line is output on the same screen line as the user input.
13302
13303 2019-03-18  Tom Tromey  <tromey@adacore.com>
13304
13305         * minsyms.c (minimal_symbol_reader::install): Remove call to
13306         obstack_blank.
13307
13308 2019-03-18  Pedro Alves  <palves@redhat.com>
13309
13310         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13311         New globals.
13312         (apply_style): New, factored out from ...
13313         (apply_ansi_escape): ... this.  Handle reverse video mode.
13314         (tui_set_reverse_mode): New function.
13315         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13316         * tui/tui-winsource.c (tui_show_source_line): Use
13317         tui_set_reverse_mode instead of setting A_STANDOUT.
13318         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13319         New setter methods.
13320
13321 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13322
13323         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13324         Handle tabs.
13325
13326 2019-03-18  Tom Tromey  <tromey@adacore.com>
13327
13328         * ada-lang.c (empty_array): Add "high" parameter.
13329         (ada_evaluate_subexp): Update.
13330
13331 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13332
13333         * unittests/string_view-selftests.c: Define
13334         _initialize_string_view_selftests unconditionally.
13335
13336 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13337
13338         PR gdb/24350
13339         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13340
13341 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13342
13343         PR gdb/24351
13344         * windows-nat.c (display_selector): Fix format specifiers.
13345
13346 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13347
13348         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13349         tui_refill_source_window instead of tui_refresh_win, to update the
13350         current execution line.  This fixes redisplay of the current line
13351         when stepping through the code with "next" or "step".
13352
13353 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13354
13355         * source-cache.c (source_cache::get_source_lines): Call
13356         find_source_lines to initialize s->nlines.  This fixes vertical
13357         scrolling of TUI source window when the DOWN arrow is pressed.
13358
13359 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13360
13361         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13362         linux-thread-db.c (_initialize_thread_db): Likewise.
13363
13364 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13365
13366         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13367         wclrtoeol in tui_show_source_line".  This reverts changes made in
13368         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13369
13370 2019-03-15  Tom Tromey  <tom@tromey.com>
13371
13372         * symtab.h (struct minimal_symbol): Derive from
13373         general_symbol_info.
13374         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13375         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13376         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13377         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13378         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13379         (MSYMBOL_SEARCH_NAME): Update.
13380         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13381         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13382         * minsyms.c (minimal_symbol_reader::record_full): Update.
13383
13384 2019-03-15  Tom Tromey  <tom@tromey.com>
13385
13386         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13387
13388 2019-03-15  Tom Tromey  <tom@tromey.com>
13389
13390         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13391         unique_xmalloc_ptr.
13392         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13393         Update.
13394         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13395         (build_minimal_symbol_hash_tables)
13396         (minimal_symbol_reader::install): Update.
13397
13398 2019-03-15  Tom Tromey  <tom@tromey.com>
13399
13400         * symtab.c (create_demangled_names_hash): Update.
13401         (symbol_set_names): Update.
13402         * objfiles.h (struct objfile_per_bfd_storage)
13403         <demangled_names_hash>: Now an htab_up.
13404         * objfiles.c (objfile_per_bfd_storage): Simplify.
13405
13406 2019-03-15  Tom Tromey  <tom@tromey.com>
13407
13408         * objfiles.h (struct objfile_per_bfd_storage): Declare
13409         destructor.
13410         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13411         New.
13412         (get_objfile_bfd_data): Use new.  Don't initialize
13413         language_of_main.
13414         (free_objfile_per_bfd_storage): Remove.
13415         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13416
13417 2019-03-15  Tom Tromey  <tom@tromey.com>
13418
13419         * symfile.c (reread_symbols): Update.
13420         * objfiles.c (objfile::objfile): Update.
13421         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13422         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13423         comment.
13424         (minimal_symbol_reader::install): Update.
13425         (terminate_minimal_symbol_table): Remove.
13426         * jit.c (jit_object_close_impl): Update.
13427
13428 2019-03-15  Tom Tromey  <tom@tromey.com>
13429
13430         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13431         initializations.
13432
13433 2019-03-15  Tom Tromey  <tom@tromey.com>
13434
13435         * objfiles.h (struct objfile_per_bfd_storage)
13436         <demangled_hash_languages>: Now a bitset.
13437         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13438         (lookup_minimal_symbol): Update.
13439
13440 2019-03-15  Tom Tromey  <tom@tromey.com>
13441
13442         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13443         Don't return the symbol.
13444         * coffread.c (record_minimal_symbol): Use record_full.
13445
13446 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13447
13448         The MS-Windows port of ncurses fails to switch to a color pair if
13449         one or both of the colors are the implicit default colors.  This
13450         change records the default colors when TUI is initialized, and
13451         then specifies them explicitly when a color pair uses the default
13452         colors.  This allows color styling in TUI mode on MS-Windows.
13453
13454         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13455         ncurses_norm_attr.
13456         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13457         colors in ncurses_norm_attr.
13458         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13459         "none", replace it with the default color recorded in
13460         ncurses_norm_attr.
13461
13462 2019-03-14  Tom Tromey  <tromey@adacore.com>
13463
13464         * source-cache.h (class source_cache) <get_source_lines>: Return
13465         std::string.
13466         * source-cache.c (source_cache::extract_lines): Handle case where
13467         first_pos==npos.  Return std::string.
13468         (source_cache::get_source_lines): Update.
13469
13470 2019-03-14  Tom Tromey  <tromey@adacore.com>
13471
13472         * NEWS: Add item for "style sources" commands.
13473         * source-cache.c (source_cache::get_source_lines): Check
13474         source_styling.
13475         * cli/cli-style.c (source_styling): New global.
13476         (_initialize_cli_style): Add "style sources" commands.
13477         (show_style_sources): New function.
13478         * cli/cli-style.h (source_styling): Declare.
13479
13480 2019-03-14  Pedro Alves  <palves@redhat.com>
13481             Tom Tromey  <tromey@adacore.com>
13482
13483         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13484         * tui/tui-winsource.c (tui_refill_source_window): New function,
13485         from...
13486         (tui_horizontal_source_scroll): ... here.  Move some logic.
13487         * cli/cli-style.c (set_style_enabled): Notify new observable.
13488         * tui/tui-hooks.c (tui_redisplay_source): New function.
13489         (tui_attach_detach_observers): Attach or detach
13490         tui_redisplay_source.
13491         * observable.h (source_styling_changed): New observable.
13492         * observable.c: Define source_styling_changed observable.
13493
13494 2019-03-13  Tom Tromey  <tromey@adacore.com>
13495
13496         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13497         (i386_gnu_nat_target::store_registers): Update.
13498         * target-debug.h (target_debug_print_std_string): New macro.
13499         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13500         * windows-tdep.c (display_one_tib): Update.
13501         * tui/tui-stack.c (tui_make_status_line): Update.
13502         * top.c (print_inferior_quit_action): Update.
13503         * thread.c (thr_try_catch_cmd): Update.
13504         (add_thread_with_info): Update.
13505         (thread_target_id_str): Update.
13506         (thr_try_catch_cmd): Update.
13507         (thread_command): Update.
13508         (thread_find_command): Update.
13509         * record-btrace.c (record_btrace_target::info_record)
13510         (record_btrace_resume_thread, record_btrace_target::resume)
13511         (record_btrace_cancel_resume, record_btrace_step_thread)
13512         (record_btrace_target::wait, record_btrace_target::wait)
13513         (record_btrace_target::wait, record_btrace_target::stop): Update.
13514         * progspace.c (print_program_space): Update.
13515         * process-stratum-target.c
13516         (process_stratum_target::thread_address_space): Update.
13517         * linux-fork.c (linux_fork_mourn_inferior)
13518         (detach_checkpoint_command, info_checkpoints_command)
13519         (linux_fork_context): Update.
13520         (linux_fork_detach): Update.
13521         (class scoped_switch_fork_info): Update.
13522         (delete_checkpoint_command): Update.
13523         * infrun.c (follow_fork_inferior): Update.
13524         (follow_fork_inferior): Update.
13525         (proceed_after_vfork_done): Update.
13526         (handle_vfork_child_exec_or_exit): Update.
13527         (follow_exec): Update.
13528         (displaced_step_prepare_throw): Update.
13529         (displaced_step_restore): Update.
13530         (start_step_over): Update.
13531         (resume_1): Update.
13532         (clear_proceed_status_thread): Update.
13533         (proceed): Update.
13534         (print_target_wait_results): Update.
13535         (do_target_wait): Update.
13536         (context_switch): Update.
13537         (stop_all_threads): Update.
13538         (restart_threads): Update.
13539         (finish_step_over): Update.
13540         (handle_signal_stop): Update.
13541         (switch_back_to_stepped_thread): Update.
13542         (keep_going_pass_signal): Update.
13543         (print_exited_reason): Update.
13544         (normal_stop): Update.
13545         * inferior.c (inferior_pid_to_str): Change return type.
13546         (print_selected_inferior): Update.
13547         (add_inferior): Update.
13548         (detach_inferior): Update.
13549         * dummy-frame.c (fprint_dummy_frames): Update.
13550         * dcache.c (dcache_info_1): Update.
13551         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13552         (btrace_fetch, btrace_clear): Update.
13553         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13554         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13555         type.
13556         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13557         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13558         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13559         * gdbarch.c, gdbarch.h: Rebuild.
13560         * gdbarch.sh (core_pid_to_str): Change return type.
13561         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13562         return type.
13563         (windows_nat_target::pid_to_str): Change return type.
13564         (windows_delete_thread): Update.
13565         (windows_nat_target::attach): Update.
13566         (windows_nat_target::files_info): Update.
13567         * target-delegates.c: Rebuild.
13568         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13569         return type.
13570         (sol_thread_target::pid_to_str): Change return type.
13571         * remote.c (class remote_target) <pid_to_str>: Change return
13572         type.
13573         (remote_target::pid_to_str): Change return type.
13574         (extended_remote_target::attach, remote_target::remote_stop_ns)
13575         (remote_target::remote_notif_remove_queued_reply)
13576         (remote_target::push_stop_reply, remote_target::disable_btrace):
13577         Update.
13578         (extended_remote_target::attach): Update.
13579         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13580         type.
13581         (gdbsim_target::pid_to_str): Change return type.
13582         * ravenscar-thread.c (struct ravenscar_thread_target)
13583         <pid_to_str>: Change return type.
13584         (ravenscar_thread_target::pid_to_str): Change return type.
13585         * procfs.c (class procfs_target) <pid_to_str>: Change return
13586         type.
13587         (procfs_target::pid_to_str): Change return type.
13588         (procfs_target::attach): Update.
13589         (procfs_target::detach): Update.
13590         (procfs_target::fetch_registers): Update.
13591         (procfs_target::store_registers): Update.
13592         (procfs_target::wait): Update.
13593         (procfs_target::files_info): Update.
13594         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13595         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13596         return type.
13597         (nto_procfs_target::pid_to_str): Change return type.
13598         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13599         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13600         return type.
13601         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13602         (exit_lwp): Update.
13603         (attach_proc_task_lwp_callback, get_detach_signal)
13604         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13605         (linux_nat_target::resume, wait_lwp, stop_callback)
13606         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13607         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13608         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13609         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13610         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13611         type.
13612         (inf_ptrace_target::attach): Update.
13613         (inf_ptrace_target::files_info): Update.
13614         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13615         type.
13616         (go32_nat_target::pid_to_str): Change return type.
13617         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13618         (gnu_nat_target::wait): Update.
13619         (gnu_nat_target::wait): Update.
13620         (gnu_nat_target::resume): Update.
13621         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13622         (fbsd_nat_target::wait): Update.
13623         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13624         type.
13625         (darwin_nat_target::attach): Update.
13626         * corelow.c (class core_target) <pid_to_str>: Change return type.
13627         (core_target::pid_to_str): Change return type.
13628         * target.c (normal_pid_to_str): Change return type.
13629         (default_pid_to_str): Likewise.
13630         (target_pid_to_str): Change return type.
13631         (target_translate_tls_address): Update.
13632         (target_announce_detach): Update.
13633         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13634         return type.
13635         (bsd_uthread_target::pid_to_str): Change return type.
13636         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13637         type.
13638         (bsd_kvm_target::pid_to_str): Change return type.
13639         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13640         return type.
13641         (aix_thread_target::pid_to_str): Change return type.
13642         * target.h (struct target_ops) <pid_to_str>: Change return type.
13643         (target_pid_to_str, normal_pid_to_str): Likewise.
13644         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13645         type.
13646         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13647         type.
13648         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13649         return type.
13650         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13651         type.
13652         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13653         type.
13654         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13655         return type.
13656
13657 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13658
13659         * NEWS: Mention that the new default MI version is 3.  Mention
13660         changes to the output of commands and events that deal with
13661         multi-location breakpoints.
13662         * breakpoint.c: Include "mi/mi-out.h".
13663         (print_one_breakpoint): Change output syntax if using MI version
13664         >= 3.
13665         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13666         New.
13667         (mi_multi_location_breakpoint_output_fixed): New.
13668         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13669         (mi_cmd_fix_multi_location_breakpoint_output): New.
13670         (mi_multi_location_breakpoint_output_fixed): New.
13671         * mi/mi-cmds.c (mi_cmds): Register command
13672         -fix-multi-location-breakpoint-output.
13673         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13674         interpreter "mi".
13675
13676 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13677
13678         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13679         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13680         instantiate mi_ui_out based on interpreter name.
13681         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13682         * mi/mi-main.c (mi_load_progress): Likewise.
13683
13684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13685
13686         * NEWS: Combine separate "New targets" sections for 8.3.
13687
13688 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13689
13690         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13691         (ppcfbsd_init_abi): Install gdbarch
13692         "fetch_tls_load_module_address" and "get_thread_local_address"
13693         methods.
13694
13695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13696
13697         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13698         (riscv_fbsd_init_abi): Install gdbarch
13699         "fetch_tls_load_module_address" and "get_thread_local_address"
13700         methods.
13701
13702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13703
13704         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13705         (i386fbsd_init_abi): Install gdbarch
13706         "fetch_tls_load_module_address" and "get_thread_local_address"
13707         methods.
13708
13709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13710
13711         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13712         (amd64fbsd_init_abi): Install gdbarch
13713         "fetch_tls_load_module_address" and "get_thread_local_address"
13714         methods.
13715
13716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13717
13718         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13719         (struct fbsd_pspace_data): New type.
13720         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13721         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13722         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13723         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13724         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13725
13726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13727
13728         * gdbtypes.c (lookup_struct_elt): New function.
13729         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13730         * gdbtypes.h (struct struct_elt): New type.
13731         (lookup_struct_elt): New prototype.
13732
13733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13734
13735         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13736         remove disabled code block.
13737
13738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13739
13740         * gdbarch.sh (get_thread_local_address): New method.
13741         * gdbarch.h, gdbarch.c: Regenerate.
13742         * target.c (target_translate_tls_address): Use
13743         gdbarch_get_thread_local_address if present instead of
13744         target::get_thread_local_address.
13745
13746 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13747
13748         * target.h (target::get_thread_local_address): Update comment.
13749
13750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13751
13752         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13753         objfile->separate_debug_objfile_backlink if not NULL.
13754
13755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13756
13757         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13758         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13759         (amd64bsd_store_inferior_registers): Likewise.
13760         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13761         Enable segment base registers.
13762         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13763         PT_GETFSBASE and PT_GETGSBASE.
13764         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13765         PT_SETGSBASE.
13766         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13767         segment base registers.
13768         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13769
13770 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13771
13772         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13773         Update calls to i386_target_description to add 'segments'
13774         parameter.
13775         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13776         add segment base registers.
13777         * arch/i386.c (i386_create_target_description): Add 'segments'
13778         parameter to enable segment base registers.
13779         * arch/i386.h (i386_create_target_description): Likewise.
13780         * features/i386/32bit-segments.xml: New file.
13781         * features/i386/32bit-segments.c: Generate.
13782         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13783         call to i386_target_description to add 'segments' parameter.
13784         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13785         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13786         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13787         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13788         if feature is present.
13789         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13790         Add 'segments' parameter to call to i386_target_description.
13791         (i386_target_description): Add 'segments' parameter to enable
13792         segment base registers.
13793         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13794         to call to i386_target_description.
13795         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13796         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13797         Define I386_NUM_REGS.
13798         (i386_target_description): Add 'segments' parameter to enable
13799         segment base registers.
13800
13801 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13802
13803         PR/24325
13804         * source-cache.c: #undef open and close, to avoid unresolved
13805         externals during linking.
13806
13807 2019-03-12  Tom Tromey  <tromey@adacore.com>
13808
13809         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13810         const.  Add initializers.
13811         (_initialize_remote): Don't initialize ptid globals.
13812
13813 2019-03-12  Pedro Alves  <palves@redhat.com>
13814
13815         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13816
13817 2019-03-12  Pedro Alves  <palves@redhat.com>
13818
13819         * cp-name-parser.y (main): Remove unused 'len' variable.
13820
13821 2019-03-12  Tom Tromey  <tromey@adacore.com>
13822
13823         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13824         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13825
13826 2019-03-12  Tom Tromey  <tromey@adacore.com>
13827
13828         * linux-nat.c (iterate_over_lwps): Update.
13829         (stop_callback): Remove parameter.
13830         (stop_wait_callback, detach_callback, resume_set_callback)
13831         (select_singlestep_lwp_callback, set_ignore_sigint)
13832         (status_callback, resumed_callback, resume_clear_callback)
13833         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13834         data parameter.
13835         (linux_nat_target::detach, linux_nat_target::resume)
13836         (linux_stop_and_wait_all_lwps, select_event_lwp)
13837         (linux_nat_filter_event, linux_nat_wait_1)
13838         (linux_nat_target::kill, linux_nat_target::stop)
13839         (linux_nat_target::stop): Update.
13840         (linux_nat_resume_callback): Change type.
13841         (resume_stopped_resumed_lwps, count_events_callback)
13842         (select_event_lwp_callback): Likewise.
13843         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13844         * arm-linux-nat.c (struct update_registers_data): Remove.
13845         (update_registers_callback): Change type.
13846         (arm_linux_insert_hw_breakpoint1): Update.
13847         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13848         parameter.
13849         (x86_linux_dr_set_addr): Update.
13850         (x86_linux_dr_set_control): Update.
13851         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13852         (iterate_over_lwps): Use gdb::function_view.
13853         * nat/aarch64-linux-hw-point.c (struct
13854         aarch64_dr_update_callback_param): Remove.
13855         (debug_reg_change_callback): Change type.
13856         (aarch64_notify_debug_reg_change): Update.
13857         * s390-linux-nat.c (s390_refresh_per_info): Update.
13858
13859 2019-03-11  Tom Tromey  <tromey@adacore.com>
13860
13861         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13862         redundant assignment to "this_cu".
13863
13864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13865
13866         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13867
13868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13869
13870         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13871         from...
13872         (rank_one_type): ... this.
13873
13874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13875
13876         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13877         from...
13878         (rank_one_type): ... this.
13879
13880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13881
13882         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13883         from...
13884         (rank_one_type): ... this.
13885
13886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13887
13888         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13889         from...
13890         (rank_one_type): ... this.
13891
13892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13893
13894         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13895         from...
13896         (rank_one_type): ... this.
13897
13898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13899
13900         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13901         from...
13902         (rank_one_type): ... this.
13903
13904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13905
13906         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13907         from...
13908         (rank_one_type): ... this.
13909
13910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13911
13912         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13913         from...
13914         (rank_one_type): ... this.
13915
13916 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13917
13918         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13919         from...
13920         (rank_one_type): ... this.
13921
13922 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13923
13924         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13925         from...
13926         (rank_one_type): ... this.
13927
13928 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13929
13930         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13931         from...
13932         (rank_one_type): ... this.
13933
13934 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13935
13936         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13937         from...
13938         (rank_one_type): ... this.
13939
13940 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13941
13942         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13943         inferior-events' shows the example events.
13944
13945 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13946
13947         Support styling on native MS-Windows console
13948
13949         PR/24315
13950         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13951         on MS-Windows if $TERM is not defined.
13952
13953         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13954
13955         * posix-hdep.c (gdb_console_fputs):
13956         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13957         functions.
13958         * ui-file.h (gdb_console_fputs): Add prototype.
13959
13960         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13961         back to fputs only if the former returns zero.
13962
13963 2019-03-07  Tom Tromey  <tom@tromey.com>
13964
13965         * symmisc.c (print_symbol_bcache_statistics): Update.
13966         (print_objfile_statistics): Update.
13967         * symfile.c (allocate_symtab): Update.
13968         * stabsread.c: Don't include bcache.h.
13969         * psymtab.h (struct psymbol_bcache): Don't declare.
13970         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13971         (psymbol_bcache_init, psymbol_bcache_free)
13972         (psymbol_bcache_get_bcache): Don't declare.
13973         * psymtab.c (struct psymbol_bcache): Remove.
13974         (psymtab_storage::psymtab_storage): Update.
13975         (psymtab_storage::~psymtab_storage): Update.
13976         (psymbol_bcache_init, psymbol_bcache_free)
13977         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13978         (add_psymbol_to_bcache): Update.
13979         (allocate_psymtab): Update.
13980         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13981         macro_cache>: No longer pointers.
13982         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13983         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13984         * macrotab.c (macro_bcache): Update.
13985         * macroexp.c: Don't include bcache.h.
13986         * gdbtypes.c (check_types_worklist): Update.
13987         (types_deeply_equal): Remove TRY/CATCH.  Update.
13988         * elfread.c (elf_symtab_read): Update.
13989         * dwarf2read.c: Don't include bcache.h.
13990         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13991         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13992         (print_bcache_statistics, bcache_memory_used): Don't declare.
13993         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13994         methods.  Rename all data members.
13995         * bcache.c (struct bcache): Move to bcache.h.
13996         (bcache::expand_hash_table): Rename from expand_hash_table.
13997         (bcache): Remove.
13998         (bcache::insert): Rename from bcache_full.
13999         (bcache::compare): Rename from bcache_compare.
14000         (bcache_xmalloc): Remove.
14001         (bcache::~bcache): Rename from bcache_xfree.
14002         (bcache::print_statistics): Rename from print_bcache_statistics.
14003         (bcache::memory_used): Rename from bcache_memory_used.
14004
14005 2019-03-07  Pedro Alves  <palves@redhat.com>
14006
14007         * infrun.c (normal_stop): Also check for
14008         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14009
14010 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14011
14012         * f-lang.c (value_from_host_double): Moved to...
14013         * value.c (value_from_host_double): ...here.
14014         * value.h (value_from_host_double): Declare.
14015         * guile/scm-math.c (vlscm_convert_typed_number): Use
14016         value_from_host_double.
14017         (vlscm_convert_number): Likewise.
14018         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14019         * python/py-value.c (convert_value_from_python): Likewise.
14020
14021 2019-03-06  Tom Tromey  <tom@tromey.com>
14022
14023         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14024
14025 2019-03-06  Tom Tromey  <tom@tromey.com>
14026
14027         * utils.h (free_current_contents): Don't declare.
14028         * utils.c (free_current_contents): Remove.
14029
14030 2019-03-06  Tom Tromey  <tom@tromey.com>
14031
14032         * top.c (quit_force): Update.
14033         * main.c (captured_command_loop): Update.
14034         * common/new-op.c (operator new): Update.
14035         * common/common-exceptions.c (struct catcher)
14036         <save_cleanup_chain>: Remove member.
14037         (exceptions_state_mc_init): Update.
14038         (exception_try_scope_entry): Return nullptr.
14039         (exception_try_scope_exit, exception_rethrow)
14040         (throw_exception_sjlj, throw_exception_cxx): Update.
14041         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14042         (all_cleanups, do_cleanups, discard_cleanups)
14043         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14044         (restore_cleanups, restore_final_cleanups): Don't declare.
14045         (do_final_cleanups): Remove parameter.
14046         * common/cleanups.c (cleanup_chain, make_cleanup)
14047         (make_cleanup_dtor, all_cleanups, do_cleanups)
14048         (discard_my_cleanups, discard_cleanups)
14049         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14050         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14051         (null_cleanup): Remove.
14052         (do_final_cleanups): Remove parameter.
14053
14054 2019-03-06  Tom Tromey  <tom@tromey.com>
14055
14056         * remote.c (remote_target::remote_parse_stop_reply): Use
14057         unique_xmalloc_ptr.
14058
14059 2019-03-06  Tom Tromey  <tom@tromey.com>
14060
14061         * stabsread.c (struct stabs_field_info): Rename from field_info.
14062         <list, fnlist>: Add initializers.
14063         <obstack>: New member.
14064         (read_member_functions, read_struct_fields, read_baseclasses):
14065         Allocate on obstack.  Don't use cleanups.
14066         (read_one_struct_field, read_member_functions, read_struct_fields)
14067         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14068         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14069         (read_struct_type): Update.
14070
14071 2019-03-06  Tom Tromey  <tom@tromey.com>
14072
14073         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14074         * common/filestuff.h (make_cleanup_close): Don't declare.
14075         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14076         Remove.
14077
14078 2019-03-06  Tom Tromey  <tom@tromey.com>
14079
14080         * solib-aix.c: Use make_scope_exit.
14081
14082 2019-03-06  Tom Tromey  <tom@tromey.com>
14083
14084         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14085         Use make_scope_exit.
14086
14087 2019-03-06  Tom Tromey  <tom@tromey.com>
14088
14089         * solib-svr4.c (disable_probes_interface): Remove parameter.
14090         (svr4_handle_solib_event): Use make_scope_exit.
14091
14092 2019-03-06  Tom Tromey  <tom@tromey.com>
14093
14094         * remote.c (struct stop_reply_deleter): Remove.
14095         (stop_reply_up): Update.
14096         (struct stop_reply): Derive from notif_event.  Don't typedef.
14097         <regcache>: Now a std::vector.
14098         (stop_reply_xfree): Remove.
14099         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14100         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14101         (remote_target::discard_pending_stop_replies): Use delete.
14102         (remote_target::remote_parse_stop_reply): Update.
14103         (remote_target::process_stop_reply): Update.
14104         * remote-notif.h (struct notif_event): Add virtual destructor.
14105         Remove "dtr" member.
14106         (struct notif_client) <alloc_event>: Return a unique_ptr.
14107         (notif_event_xfree): Don't declare.
14108         (notif_event_up): New typedef.
14109         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14110         (notif_event_xfree, do_notif_event_xfree): Remove.
14111         (remote_notif_state_xfree): Update.
14112
14113 2019-03-06  Tom Tromey  <tom@tromey.com>
14114
14115         * infrun.c (displaced_step_clear_cleanup): Now a
14116         forward_scope_exit type.
14117         (displaced_step_prepare_throw): Update.
14118         (displaced_step_fixup): Update.
14119
14120 2019-03-06  Tom Tromey  <tom@tromey.com>
14121
14122         * inferior.h (class inferior): Update comment.
14123         * gdbthread.h (class thread_info): Update comment.
14124
14125 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14126             Tom Tromey  <tom@tromey.com>
14127
14128         * stabsread.h (struct stab_section_list): Remove.
14129         (coffstab_build_psymtabs): Update.
14130         * dbxread.c (symbuf_sections): Now a std::vector.
14131         (sect_idx): New global.
14132         (fill_symbuf): Update.
14133         (coffstab_build_psymtabs): Change type of stabsects parameter.
14134         Update.
14135         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14136         std::vector.
14137         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14138         (coff_locate_sections): Update.
14139         (coff_symfile_read): Remove cleanups.  Update.
14140         (init_stringtab): Add storage parameter.
14141         (free_stringtab, free_stringtab_cleanup): Remove.
14142         (init_lineno): Add storage parameter.
14143         (free_linetab, free_linetab_cleanup): Remove.
14144
14145 2019-03-06  Pedro Alves  <palves@redhat.com>
14146
14147         * linux-fork.c (fork_info::clobber_regs): Delete.
14148         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14149         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14150         comment.  Adjust.
14151         (scoped_switch_fork_info::scoped_switch_fork_info)
14152         (checkpoint_command, linux_fork_context): Adjust
14153         fork_save_infrun_state calls.
14154
14155 2019-03-06  Pedro Alves  <palves@redhat.com>
14156
14157         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14158         (inf_has_multiple_threads): Return 'bool' and rewrite using
14159         inferior_info::threads().
14160
14161 2019-03-06  Pedro Alves  <palves@redhat.com>
14162
14163         * linux-fork.c: Include <list>.
14164         (fork_list): Now a std::list instance.
14165         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14166         (forks_exist_p, find_last_fork): Adjust.
14167         (new_fork): Delete.
14168         (one_fork_p): New.
14169         (add_fork): Adjust.
14170         (free_fork): Delete, folded into fork_info::~fork_info().
14171         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14172         Adjust.
14173         (init_fork_list): Delete.
14174         (linux_fork_killall, linux_fork_mourn_inferior)
14175         (linux_fork_detach, info_checkpoints_command): Adjust.
14176         (_initialize_linux_fork): No longer call init_fork_list.
14177
14178 2019-03-06  Pedro Alves  <palves@redhat.com>
14179
14180         * linux-fork.c (new_fork): New, split out of ...
14181         (add_fork): ... this.  Return void.  Move "first fork" special
14182         case from here, to ...
14183         (checkpoint_command): ... here.
14184         * linux-linux.h (add_fork): Return void.
14185
14186 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14187
14188         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14189
14190 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14191             Chris January  <chris.january@arm.com>
14192             David Lecomber  <david.lecomber@arm.com>
14193
14194         * f-exp.y: New token, UNOP_INTRINSIC.
14195         (exp): New pattern using UNOP_INTRINSIC token.
14196         (f77_keywords): Add 'abs' keyword.
14197         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14198         (value_from_host_double): New function.
14199         (evaluate_subexp_f): Support UNOP_ABS.
14200
14201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14202
14203         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14204         types.
14205
14206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14207
14208         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14209         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14210         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14211
14212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14213
14214         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14215
14216 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14217             Chris January  <chris.january@arm.com>
14218
14219         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14220         * f-exp.y: Define 'KIND' token.
14221         (exp): New pattern for KIND expressions.
14222         (ptype): Handle types with a kind extension.
14223         (direct_abs_decl): Extend to spot kind extensions.
14224         (f77_keywords): Add 'kind' to the list.
14225         (push_kind_type): New function.
14226         (convert_to_kind_type): New function.
14227         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14228         * parse.c (operator_length_standard): Likewise.
14229         * parser-defs.h (enum type_pieces): Add tp_kind.
14230         * std-operator.def: Add UNOP_KIND.
14231
14232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14233
14234         * f-exp.y (f_parse): Set yydebug.
14235
14236 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14237
14238         * f-lang.c (evaluate_subexp_f): New function.
14239         (exp_descriptor_f): New global.
14240         (f_language_defn): Use exp_descriptor_f instead of
14241         exp_descriptor_standard.
14242
14243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14244
14245         * f-exp.y (struct token): Add comments.
14246         (dot_ops): Remove uppercase versions and the end marker.
14247         (f77_keywords): Likewise.
14248         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14249         entries in the dot_ops array are case insensitive, and use
14250         strncasecmp to compare strings.  Also some whitespace cleanup in
14251         this area.  Similar for the f77_keywords array, except entries in
14252         this list might be case sensitive.
14253
14254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14255
14256         * f-exp.y (struct f77_boolean_val): Add comments.
14257         (boolean_values): Remove uppercase versions, and end marker.
14258         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14259         and use strncasecmp to achieve case insensitivity.  Additionally,
14260         perform whitespace cleanup around this code.
14261
14262 2019-03-06  Tom Tromey  <tromey@adacore.com>
14263
14264         * remote-sim.c (gdbsim_target_open): Use result of
14265         gdb_argv::release.
14266
14267 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14268         Dirk Schubert  <dirk.schubert@arm.com>
14269         Chris January  <chris.january@arm.com>
14270
14271         * eval.c (evaluate_subexp_standard): Call Fortran argument
14272         wrapping logic.
14273         * f-lang.c (struct value): A value which can be passed into a
14274         Fortran function call.
14275         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14276         where appropriate.
14277         (struct type): Value ready for a Fortran function call.
14278         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14279         is needed.
14280         * f-lang.h (fortran_argument_convert): Declaration.
14281         (fortran_preserve_arg_pointer): Declaration.
14282         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14283
14284 2019-03-05  Tom Tromey  <tromey@adacore.com>
14285
14286         * python/py-prettyprint.c (print_string_repr): Remove #if.
14287         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14288
14289 2019-03-05  Tom Tromey  <tromey@adacore.com>
14290
14291         * target.c (the_dummy_target): Move later.  Change type to
14292         "dummy_target".
14293         (initialize_targets): Don't initialize the_dummy_target.
14294
14295 2019-03-05  Tom Tromey  <tromey@adacore.com>
14296
14297         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14298         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14299
14300 2019-03-05  Tom Tromey  <tromey@adacore.com>
14301
14302         * windows-nat.c (windows_nat_target::attach)
14303         (windows_nat_target::detach): Don't call gdb_flush.
14304         * valprint.c (generic_val_print, val_print, val_print_string):
14305         Don't call gdb_flush.
14306         * utils.c (defaulted_query): Don't call gdb_flush.
14307         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14308         * target.c (target_announce_detach): Don't call gdb_flush.
14309         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14310         * remote.c (extended_remote_target::attach): Don't call
14311         gdb_flush.
14312         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14313         * printcmd.c (do_examine): Don't call gdb_flush.
14314         (info_display_command): Don't call gdb_flush.
14315         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14316         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14317         * memattr.c (info_mem_command): Don't call gdb_flush.
14318         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14319         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14320         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14321         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14322         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14323         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14324         (gnu_nat_target::detach): Don't call gdb_flush.
14325         * f-valprint.c (f_val_print): Don't call gdb_flush.
14326         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14327         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14328         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14329         gdb_flush.
14330         * c-valprint.c (c_val_print): Don't call gdb_flush.
14331         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14332
14333 2019-03-05  Tom Tromey  <tromey@adacore.com>
14334
14335         * varobj.c (update_dynamic_varobj_children): Update.
14336         (install_default_visualizer): Use reset, not release.
14337         * value.c (set_internalvar): Update.
14338         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14339         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14340         ATTRIBUTE_UNUSED_RESULT.
14341
14342 2019-03-05  Tom Tromey  <tromey@adacore.com>
14343
14344         * remote.c (class scoped_remote_fd) <release>: Add
14345         ATTRIBUTE_UNUSED_RESULT.
14346
14347 2019-03-05  Tom Tromey  <tromey@adacore.com>
14348
14349         * macroexp.c (struct macro_buffer) <release>: Add
14350         ATTRIBUTE_UNUSED_RESULT.
14351
14352 2019-03-05  Tom Tromey  <tromey@adacore.com>
14353
14354         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14355         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14356         ATTRIBUTE_UNUSED_RESULT.
14357
14358 2019-03-05  Tom Tromey  <tromey@adacore.com>
14359
14360         * common/scoped_fd.h (class scoped_fd) <release>: Add
14361         ATTRIBUTE_UNUSED_RESULT.
14362
14363 2019-03-05  Tom Tromey  <tromey@adacore.com>
14364
14365         * parser-defs.h (struct parser_state) <release>: Add
14366         ATTRIBUTE_UNUSED_RESULT.
14367
14368 2019-03-05  Tom Tromey  <tromey@adacore.com>
14369
14370         * utils.h (class gdb_argv) <release>: Add
14371         ATTRIBUTE_UNUSED_RESULT.
14372         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14373
14374 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14375
14376         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14377         for-loop range, to avoid compiler warnings.
14378
14379         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14380         avoid compiler warnings about unused variables.
14381
14382         * NEWS: Mention end of support for native debugging on MS-Windows
14383         before XP.
14384
14385         PR gdb/24292
14386         * common/netstuff.c:
14387         * gdbserver/gdbreplay.c
14388         * gdbserver/remote-utils.c:
14389         * ser-tcp.c:
14390         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14391         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14392         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14393         'getaddrinfo' and 'freeaddrinfo' were not available before
14394         Windows XP, and mingw.org's MinGW headers by default define
14395         _WIN32_WINNT to 0x500.
14396
14397 2019-03-01  Gary Benson <gbenson@redhat.com>
14398
14399         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14400
14401 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14402             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14403
14404         PR gdb/8527
14405         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14406         set_sigint_trap, clear_sigint_trap.
14407
14408 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14409
14410         * target.c (target_detach): Clear the regcache and the
14411         frame cache.
14412
14413 2019-02-27  Pedro Alves  <palves@redhat.com>
14414
14415         * utils.c (set_screen_size): When we cap the height/width sizes,
14416         tweak the corresponding command variable to show "unlimited":
14417
14418 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14419             Pedro Alves  <palves@redhat.com>
14420
14421         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14422         before calling rl_set_screen_size.
14423
14424 2019-02-27  Tom Tromey  <tromey@adacore.com>
14425
14426         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14427         define.
14428         * python/py-value.c: Remove Python 2.4 workaround.
14429         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14430         workaround.
14431         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14432         Python 2.4 workaround.
14433         * python/python-internal.h: Remove Python 2.4 comment.
14434         (Py_ssize_t): Don't define.
14435         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14436         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14437         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14438         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14439         * python/python.c (do_start_initialization): Remove Python 2.4
14440         workaround.
14441         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14442         (print_children): Remove Python 2.4 workaround.
14443         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14444         workaround.
14445         (CHARBUFFERPROC_NAME): Remove.
14446         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14447         Python 2.4 workaround.
14448
14449 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14450
14451         * NEWS: Note minimum Python version.
14452
14453 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14454
14455         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14456         code from these functions.  Remove corresponding ifdefs.  Use
14457         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14458         Remove gotos and target of gotos.
14459         (infpy_search_memory): Likewise.
14460
14461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14462
14463         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14464         (hppa_gdbarch_init): Don't register deleted functions with
14465         gdbarch.
14466
14467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14468
14469         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14470         (h8300_unwind_sp): Delete.
14471         (h8300_dummy_id): Delete.
14472         (h8300_gdbarch_init): Don't register deleted functions with
14473         gdbarch.
14474
14475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14476
14477         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14478         (ft32_unwind_pc): Delete.
14479         (ft32_unwind_sp): Delete.
14480         (ft32_gdbarch_init): Don't register deleted functions with
14481         gdbarch.
14482
14483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14484
14485         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14486         (frv_unwind_pc): Delete.
14487         (frv_unwind_sp): Delete.
14488         (frv_gdbarch_init): Don't register deleted functions with
14489         gdbarch.
14490
14491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14492
14493         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14494         (riscv_unwind_pc): Delete.
14495         (riscv_unwind_sp): Delete.
14496         (riscv_gdbarch_init): Don't register deleted functions with
14497         gdbarch.
14498
14499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14500
14501         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14502         (csky_unwind_pc): Delete.
14503         (csky_unwind_sp): Delete.
14504         (csky_gdbarch_init): Don't register deleted functions with
14505         gdbarch.
14506
14507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14508
14509         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14510         (cris_unwind_pc): Delete.
14511         (cris_unwind_sp): Delete.
14512         (cris_gdbarch_init): Don't register deleted functions with
14513         gdbarch.
14514
14515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14516
14517         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14518         (bfin_unwind_pc): Delete.
14519         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14520
14521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14522
14523         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14524         (arm_unwind_pc): Delete.
14525         (arm_unwind_sp): Delete.
14526         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14527
14528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14529
14530         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14531         (arc_unwind_pc): Delete.
14532         (arc_unwind_sp): Delete.
14533         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14534
14535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14536
14537         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14538         (alpha_unwind_pc): Delete.
14539         (alpha_gdbarch_init): Don't register deleted functions with
14540         gdbarch.
14541
14542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14543
14544         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14545         (aarch64_unwind_pc): Delete.
14546         (aarch64_unwind_sp): Delete.
14547         (aarch64_gdbarch_init): Don't register deleted functions with
14548         gdbarch.
14549
14550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14551
14552         * gdbtypes.c (type_align): Don't consider static members when
14553         computing structure alignment.
14554
14555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14556
14557         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14558         return 0 for other types.
14559         * arch-utils.c (default_type_align): Always return 0.
14560         * gdbarch.h: Regenerate.
14561         * gdbarch.sh (type_align): Extend comment.
14562         * gdbtypes.c (type_align): Add additional comments, always call
14563         gdbarch_type_align before applying the default rules.
14564         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14565         generic code will then apply a suitable default.
14566         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14567         types, return 0 for other types.
14568
14569 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14570
14571         * NEWS: Create a new section for the next release branch.
14572         Rename the section of the current branch, now that it has
14573         been cut.
14574
14575 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14576
14577         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14578         * version.in: Bump version to 8.3.50.DATE-git.
14579
14580 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14581
14582         * aix-thread.c (ptid_cmp): Remove unused variable.
14583         (get_signaled_thread): Likewise.
14584         (store_regs_user_thread): Likewise.
14585         (store_regs_kernel_thread): Likewise.
14586         (fetch_regs_kernel_thread): Remove shadowed variable.
14587
14588 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14589
14590         * features/riscv/32bit-cpu.xml: Add register numbers.
14591         * features/riscv/32bit-fpu.c: Regenerate.
14592         * features/riscv/32bit-fpu.xml: Add register numbers.
14593         * features/riscv/64bit-cpu.xml: Add register numbers.
14594         * features/riscv/64bit-fpu.c: Regenerate.
14595         * features/riscv/64bit-fpu.xml: Add register numbers.
14596
14597 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14598
14599         * NEWS: Mention two argument form of gdb.Value constructor.
14600         * python/py-value.c (convert_buffer_and_type_to_value): New
14601         function.
14602         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14603         Add support for handling an optional second argument.  Call
14604         convert_buffer_and_type_to_value as appropriate.
14605         * python/python-internal.h (Py_buffer_deleter): New struct.
14606         (Py_buffer_up): New typedef.
14607
14608 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14609
14610         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14611         instead of releasing ownership.
14612
14613 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14614
14615         * dwarf2read.c (open_and_init_dwp_file): Call
14616         elf_numsections instead of bfd_count_sections to initialize
14617         dwp_file->num_sections.
14618
14619 2019-02-25  Tom Tromey  <tromey@adacore.com>
14620
14621         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14622
14623 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14624
14625         * gcore.in: Add '--readnever' option when invoking GDB.
14626
14627 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14628
14629         * MAINTAINERS: Update my email address.
14630
14631 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14632
14633         * build-id.c (build_id_to_debug_bfd_1): New function.
14634         (build_id_to_debug_bfd): Look for separate debug file in
14635         sysroot.
14636
14637 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14638
14639         * gdbarch.sh: Update the copyright year range that is placed into
14640         generated files.
14641
14642 2019-02-22  Keith Seitz  <keiths@redhat.com>
14643
14644         PR symtab/23853
14645         * linespec.c (create_sals_line_offset): Search for the default
14646         symtab's filename instead of its fullname.
14647
14648 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14649
14650         * NEWS: Update style defaults.
14651
14652 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14653
14654         * main.c (captured_main_1): Disable styling in batch mode.
14655
14656 2019-02-20  Tom Tromey  <tom@tromey.com>
14657
14658         * symtab.c (symtab_symbol_info): Fix typos.
14659
14660 2019-02-20  Tom Tromey  <tromey@adacore.com>
14661
14662         * findcmd.c (_initialize_mem_search): Use upper case for
14663         metasyntactic variables.
14664
14665 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14666
14667         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14668         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14669
14670 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14671
14672         * top.h (source_file_name): Change to std::string.
14673         * top.c (source_file_name): Likewise.
14674         (command_line_input): Adjust.
14675         * cli/cli-script.c (script_from_file): Adjust.
14676
14677 2019-02-19  Tom Tromey  <tromey@adacore.com>
14678
14679         * ravenscar-thread.c
14680         (ravenscar_thread_target::update_thread_list): Don't call
14681         ada_build_task_list.
14682         * ada-lang.h (ada_build_task_list): Don't declare.
14683         * ada-tasks.c (struct ada_tasks_inferior_data)
14684         <task_list_valid_p>: Now bool.
14685         (read_known_tasks, ada_task_list_changed)
14686         (ada_tasks_invalidate_inferior_data): Update.
14687         (read_known_tasks_array): Return bool.
14688         (read_known_tasks_list): Likewise.
14689         (read_known_tasks): Return void.
14690         (ada_build_task_list): Now static.
14691
14692 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14693
14694         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14695         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14696
14697 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14698
14699         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14700         variant for ada_tasks_pspace_data_handle and
14701         ada_tasks_inferior_data_handle.
14702         (ada_tasks_pspace_data_cleanup): New function.
14703         (ada_tasks_inferior_data_cleanup): New function.
14704
14705 2019-02-17  Tom Tromey  <tom@tromey.com>
14706
14707         * macrotab.h (macro_source_fullname): Return a std::string.
14708         * macrotab.c (macro_include, check_for_redefinition)
14709         (macro_undef, macro_lookup_definition, foreach_macro)
14710         (foreach_macro_in_scope): Update.
14711         (macro_source_fullname): Return a std::string.
14712         * macrocmd.c (show_pp_source_pos): Update.
14713
14714 2019-02-17  Tom Tromey  <tom@tromey.com>
14715
14716         * macrocmd.c (show_pp_source_pos): Style the file names.
14717
14718 2019-02-17  Tom Tromey  <tom@tromey.com>
14719
14720         PR tui/24197:
14721         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14722
14723 2019-02-17  Tom Tromey  <tom@tromey.com>
14724
14725         * ada-lang.c (user_select_syms): Use filtered printing.
14726         * utils.c (wrap_style): New global.
14727         (desired_style): Remove.
14728         (emit_style_escape): Add stream parameter.
14729         (set_output_style, reset_terminal_style, prompt_for_continue):
14730         Update.
14731         (flush_wrap_buffer): Only flush gdb_stdout.
14732         (wrap_here): Set wrap_style.
14733         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14734         treat escape sequences as a character.  Change when wrap buffer is
14735         flushed.
14736         (fputs_styled): Do not set the output style when the default is
14737         requested.
14738         * ui-style.h (struct ui_file_style) <is_default>: New method.
14739         * source.c (print_source_lines_base): Emit escape sequences in one
14740         piece.
14741
14742 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14743
14744         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14745         integers and enumeration types.
14746
14747 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14748
14749         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14750         instead of lookup_symbol_in_language
14751         (do_exact_match): New function.
14752         (ada_get_symbol_name_matcher): Return do_exact_match when
14753         doing a verbatim match.
14754
14755 2019-02-15  Tom Tromey  <tromey@adacore.com>
14756
14757         * ravenscar-thread.c (ravenscar_thread_target::resume)
14758         (ravenscar_thread_target::wait): Special case wildcard requests.
14759
14760 2019-02-15  Tom Tromey  <tromey@adacore.com>
14761
14762         * ravenscar-thread.c (base_ptid): Remove.
14763         (struct ravenscar_thread_target) <close>: New method.
14764         <m_base_ptid>: New member.
14765         <update_inferior_ptid, active_task, task_is_currently_active,
14766         runtime_initialized>: Declare methods.
14767         <ravenscar_thread_target>: Add constructor.
14768         (ravenscar_thread_target::task_is_currently_active)
14769         (ravenscar_thread_target::update_inferior_ptid)
14770         (ravenscar_runtime_initialized): Rename.  Now methods.
14771         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14772         (ravenscar_thread_target::update_thread_list): Update.
14773         (ravenscar_thread_target::active_task): Now method.
14774         (ravenscar_thread_target::store_registers)
14775         (ravenscar_thread_target::prepare_to_store)
14776         (ravenscar_thread_target::prepare_to_store)
14777         (ravenscar_thread_target::mourn_inferior): Update.
14778         (ravenscar_inferior_created): Use "new" to create target.
14779         (ravenscar_thread_target::get_ada_task_ptid): Update.
14780         (_initialize_ravenscar): Don't initialize base_ptid.
14781         (ravenscar_ops): Remove global.
14782
14783 2019-02-15  Tom Tromey  <tromey@adacore.com>
14784
14785         * target.h (push_target): Declare new overload.
14786         * target.c (push_target): New overload, taking an rvalue reference.
14787         * remote.c (remote_target::open_1): Use push_target overload.
14788         * corelow.c (core_target_open): Use push_target overload.
14789
14790 2019-02-15  Tom Tromey  <tromey@adacore.com>
14791
14792         * ravenscar-thread.c (is_ravenscar_task)
14793         (ravenscar_task_is_currently_active): Return bool.
14794         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14795         (_initialize_ravenscar): Remove "(void)".
14796         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14797         Return bool.
14798
14799 2019-02-15  Tom Tromey  <tromey@adacore.com>
14800
14801         * ravenscar-thread.c (ravenscar_runtime_initializer)
14802         (has_ravenscar_runtime, get_running_thread_id)
14803         (ravenscar_thread_target::resume): Fix indentation.
14804
14805 2019-02-15  Tom Tromey  <tromey@adacore.com>
14806
14807         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14808         from ravenscar_arch_ops.
14809         (sparc_ravenscar_ops::fetch_registers)
14810         (sparc_ravenscar_ops::store_registers): Now methods.
14811         (sparc_ravenscar_prepare_to_store): Remove.
14812         (sparc_ravenscar_ops): Redefine.
14813         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14814         methods and destructor.  Remove members.
14815         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14816         (ravenscar_thread_target::store_registers)
14817         (ravenscar_thread_target::prepare_to_store): Update.
14818         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14819         Remove.
14820         (struct ppc_ravenscar_powerpc_ops): Derive from
14821         ravenscar_arch_ops.
14822         (ppc_ravenscar_powerpc_ops::fetch_registers)
14823         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14824         (ppc_ravenscar_powerpc_ops): Redefine.
14825         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14826         (ppc_ravenscar_e500_ops::fetch_registers)
14827         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14828         (ppc_ravenscar_e500_ops): Redefine.
14829         * aarch64-ravenscar-thread.c
14830         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14831         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14832         (aarch64_ravenscar_fetch_registers)
14833         (aarch64_ravenscar_store_registers): Now methods.
14834         (aarch64_ravenscar_ops): Redefine.
14835
14836 2019-02-15  Tom Tromey  <tromey@adacore.com>
14837
14838         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14839         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14840         (ravenscar_thread_target::stopped_by_watchpoint)
14841         (ravenscar_thread_target::stopped_data_address)
14842         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14843
14844 2019-02-15  Tom Tromey  <tromey@adacore.com>
14845
14846         * ravenscar-thread.c: Fix some typos.
14847
14848 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14849             Tom Tromey  <tromey@adacore.com>
14850
14851         * ada-lang.c (ada_exception_sal): Change addr_string to a
14852         std::string.
14853         (create_ada_exception_catchpoint): Update.
14854
14855 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14856             Tom Tromey  <tromey@adacore.com>
14857
14858         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14859         (bp_location_ops): Remove.
14860         (base_breakpoint_allocate_location): Update.
14861         (free_bp_location): Update.
14862         * ada-lang.c (class ada_catchpoint_location)
14863         <ada_catchpoint_location>: Remove ops parameter.
14864         (ada_catchpoint_location_dtor): Remove.
14865         (ada_catchpoint_location_ops): Remove.
14866         (allocate_location_exception): Update.
14867         * breakpoint.h (struct bp_location_ops): Remove.
14868         (class bp_location) <bp_location>: Remove bp_location_ops
14869         parameter.
14870         <~bp_location>: Add destructor.
14871         <ops>: Remove.
14872
14873 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14874             Pedro Alves  <palves@redhat.com>
14875
14876         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14877         'PATH_MAX'.
14878
14879 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14880             Samuel Thibault  <samuel.thibault@gnu.org>
14881             Thomas Schwinge  <thomas@codesourcery.com>
14882
14883         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14884         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14885
14886 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14887
14888         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14889         (check_empty): Use "const char *".
14890
14891         * gnu-nat.c (gnu_nat_target::detach): Instead of
14892         'detach_inferior (pid)' call
14893         'detach_inferior (find_inferior_pid (pid))'.
14894
14895         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14896         'nat/fork-inferior.o'.
14897         * gnu-nat.c: #include "nat/fork-inferior.h".
14898
14899         * gnu-nat.c (gnu_nat_target::detach): Instead of
14900         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14901         * gnu-nat.h: #include "inf-child.h".
14902         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14903         'i386_gnu_nat_target::fetch_registers'.
14904         (gnu_store_registers): Rename/move to
14905         'i386_gnu_nat_target::store_registers'.
14906
14907         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14908         * gnu-nat.h (mach_thread_info): New function.
14909         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14910
14911         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14912
14913 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14914
14915         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14916
14917 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14918
14919         * windows-nat.c (windows_add_thread): Add new parameter
14920         "main_thread_p" with default value set to false.  Update
14921         function documentation as well as all callers.
14922         (windows_delete_thread): Likewise.
14923         (fake_create_process): Update call to windows_add_thread.
14924         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14925         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14926         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14927         call to windows_delete_thread.
14928
14929 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14930
14931         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14932
14933 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14934
14935         * symfile.c (find_separate_debug_file): Use canonical path of
14936         sysroot with child_path instead of gdb_sysroot if it is valid.
14937
14938 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14939
14940         * symfile.c (find_separate_debug_file): Use child_path to
14941         determine if an object file is under a sysroot.
14942
14943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14944
14945         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14946         unittests/child-path-selftests.c.
14947         * common/pathstuff.c (child_path): New function.
14948         * common/pathstuff.h (child_path): New prototype.
14949         * unittests/child-path-selftests.c: New file.
14950
14951 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14952
14953         * symfile.c (find_separate_debug_file): Look for separate debug
14954         files in debug directories under the sysroot.
14955
14956 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14957
14958         * symtab.h (struct minimal_symbol data_p): New const method.
14959         (struct minimal_symbol text_p): Likewise.
14960         * symtab.c (output_source_filename): Use file name style
14961         to print file name.
14962         (print_symbol_info): Likewise.
14963         (print_msymbol_info): Use address style to print addresses.
14964         Use function name style to print executable text symbols.
14965         (expand_symtab_containing_pc): Use data_p.
14966         (find_pc_sect_compunit_symtab): Likewise.
14967
14968 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14969
14970         * breakpoint.c (describe_other_breakpoints): Use address style
14971         to print addresses.
14972         (say_where): Likewise.
14973
14974 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14975
14976         * ada-typeprint.c (print_func_type): Print function name
14977         style to print function name.
14978         * c-typeprint.c (c_print_type_1): Likewise.
14979
14980 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14981
14982         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14983         for execve.
14984
14985 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14986
14987         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14988         type_stack.
14989
14990 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14991
14992         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14993         TYPE_CODE_REF types.
14994
14995 2019-02-08  Jim Wilson  <jimw@sifive.com>
14996
14997         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14998         (riscv_linux_fregset): New.
14999         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15000
15001 2019-02-07  Tom Tromey  <tom@tromey.com>
15002
15003         * thread.c (thread_cancel_execution_command): Update.
15004         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15005         methods.
15006         (struct thread_fsm_ops): Remove.
15007         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15008         (thread_fsm_should_stop, thread_fsm_return_value)
15009         (thread_fsm_set_finished, thread_fsm_finished_p)
15010         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15011         Don't declare.
15012         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15013         * infrun.c (clear_proceed_status_thread)
15014         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15015         (print_stop_event): Update.
15016         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15017         Add constructor.
15018         (step_command_fsm_ops): Remove.
15019         (new_step_command_fsm): Remove.
15020         (step_1): Update.
15021         (step_command_fsm::should_stop): Rename from
15022         step_command_fsm_should_stop.
15023         (step_command_fsm::clean_up): Rename from
15024         step_command_fsm_clean_up.
15025         (step_command_fsm::do_async_reply_reason): Rename from
15026         step_command_fsm_async_reply_reason.
15027         (struct until_next_fsm): Inherit from thread_fsm.  Add
15028         constructor.
15029         (until_next_fsm_ops): Remove.
15030         (new_until_next_fsm): Remove.
15031         (until_next_fsm::should_stop): Rename from
15032         until_next_fsm_should_stop.
15033         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15034         (until_next_fsm::do_async_reply_reason): Rename from
15035         until_next_fsm_async_reply_reason.
15036         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15037         constructor.  Change type of breakpoint.
15038         (finish_command_fsm_ops): Remove.
15039         (new_finish_command_fsm): Remove.
15040         (finish_command_fsm::should_stop): Rename from
15041         finish_command_fsm_should_stop.
15042         (finish_command_fsm::clean_up): Rename from
15043         finish_command_fsm_clean_up.
15044         (finish_command_fsm::return_value): Rename from
15045         finish_command_fsm_return_value.
15046         (finish_command_fsm::do_async_reply_reason): Rename from
15047         finish_command_fsm_async_reply_reason.
15048         (finish_command): Update.
15049         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15050         Add constructor.
15051         (call_thread_fsm_ops): Remove.
15052         (call_thread_fsm::call_thread_fsm): Rename from
15053         new_call_thread_fsm.
15054         (call_thread_fsm::should_stop): Rename from
15055         call_thread_fsm_should_stop.
15056         (call_thread_fsm::should_notify_stop): Rename from
15057         call_thread_fsm_should_notify_stop.
15058         (run_inferior_call, call_function_by_hand_dummy): Update.
15059         * cli/cli-interp.c (should_print_stop_to_console): Update.
15060         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15061         Add constructor.  Change type of location_breakpoint,
15062         caller_breakpoint.
15063         (until_break_fsm_ops): Remove.
15064         (new_until_break_fsm): Remove.
15065         (until_break_fsm::should_stop): Rename from
15066         until_break_fsm_should_stop.
15067         (until_break_fsm::clean_up): Rename from
15068         until_break_fsm_clean_up.
15069         (until_break_fsm::do_async_reply_reason): Rename from
15070         until_break_fsm_async_reply_reason.
15071         (until_break_command): Update.
15072         * thread-fsm.c: Remove.
15073         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15074
15075 2019-02-07  Tom Tromey  <tom@tromey.com>
15076
15077         * yy-remap.h: Add include guard.
15078         * xtensa-tdep.h: Add include guard.
15079         * xcoffread.h: Rename include guard.
15080         * varobj-iter.h: Add include guard.
15081         * tui/tui.h: Rename include guard.
15082         * tui/tui-winsource.h: Rename include guard.
15083         * tui/tui-wingeneral.h: Rename include guard.
15084         * tui/tui-windata.h: Rename include guard.
15085         * tui/tui-win.h: Rename include guard.
15086         * tui/tui-stack.h: Rename include guard.
15087         * tui/tui-source.h: Rename include guard.
15088         * tui/tui-regs.h: Rename include guard.
15089         * tui/tui-out.h: Rename include guard.
15090         * tui/tui-layout.h: Rename include guard.
15091         * tui/tui-io.h: Rename include guard.
15092         * tui/tui-hooks.h: Rename include guard.
15093         * tui/tui-file.h: Rename include guard.
15094         * tui/tui-disasm.h: Rename include guard.
15095         * tui/tui-data.h: Rename include guard.
15096         * tui/tui-command.h: Rename include guard.
15097         * tic6x-tdep.h: Add include guard.
15098         * target/waitstatus.h: Rename include guard.
15099         * target/wait.h: Rename include guard.
15100         * target/target.h: Rename include guard.
15101         * target/resume.h: Rename include guard.
15102         * target-float.h: Rename include guard.
15103         * stabsread.h: Add include guard.
15104         * rs6000-tdep.h: Add include guard.
15105         * riscv-fbsd-tdep.h: Add include guard.
15106         * regformats/regdef.h: Rename include guard.
15107         * record.h: Rename include guard.
15108         * python/python.h: Rename include guard.
15109         * python/python-internal.h: Rename include guard.
15110         * python/py-stopevent.h: Rename include guard.
15111         * python/py-ref.h: Rename include guard.
15112         * python/py-record.h: Rename include guard.
15113         * python/py-record-full.h: Rename include guard.
15114         * python/py-record-btrace.h: Rename include guard.
15115         * python/py-instruction.h: Rename include guard.
15116         * python/py-events.h: Rename include guard.
15117         * python/py-event.h: Rename include guard.
15118         * procfs.h: Add include guard.
15119         * proc-utils.h: Add include guard.
15120         * p-lang.h: Add include guard.
15121         * or1k-tdep.h: Rename include guard.
15122         * observable.h: Rename include guard.
15123         * nto-tdep.h: Rename include guard.
15124         * nat/x86-linux.h: Rename include guard.
15125         * nat/x86-linux-dregs.h: Rename include guard.
15126         * nat/x86-gcc-cpuid.h: Add include guard.
15127         * nat/x86-dregs.h: Rename include guard.
15128         * nat/x86-cpuid.h: Rename include guard.
15129         * nat/ppc-linux.h: Rename include guard.
15130         * nat/mips-linux-watch.h: Rename include guard.
15131         * nat/linux-waitpid.h: Rename include guard.
15132         * nat/linux-ptrace.h: Rename include guard.
15133         * nat/linux-procfs.h: Rename include guard.
15134         * nat/linux-osdata.h: Rename include guard.
15135         * nat/linux-nat.h: Rename include guard.
15136         * nat/linux-namespaces.h: Rename include guard.
15137         * nat/linux-btrace.h: Rename include guard.
15138         * nat/glibc_thread_db.h: Rename include guard.
15139         * nat/gdb_thread_db.h: Rename include guard.
15140         * nat/gdb_ptrace.h: Rename include guard.
15141         * nat/fork-inferior.h: Rename include guard.
15142         * nat/amd64-linux-siginfo.h: Rename include guard.
15143         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15144         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15145         * nat/aarch64-linux.h: Rename include guard.
15146         * nat/aarch64-linux-hw-point.h: Rename include guard.
15147         * mn10300-tdep.h: Add include guard.
15148         * mips-linux-tdep.h: Add include guard.
15149         * mi/mi-parse.h: Rename include guard.
15150         * mi/mi-out.h: Rename include guard.
15151         * mi/mi-main.h: Rename include guard.
15152         * mi/mi-interp.h: Rename include guard.
15153         * mi/mi-getopt.h: Rename include guard.
15154         * mi/mi-console.h: Rename include guard.
15155         * mi/mi-common.h: Rename include guard.
15156         * mi/mi-cmds.h: Rename include guard.
15157         * mi/mi-cmd-break.h: Rename include guard.
15158         * m2-lang.h: Add include guard.
15159         * location.h: Rename include guard.
15160         * linux-record.h: Rename include guard.
15161         * linux-nat.h: Add include guard.
15162         * linux-fork.h: Add include guard.
15163         * i386-darwin-tdep.h: Rename include guard.
15164         * hppa-linux-offsets.h: Add include guard.
15165         * guile/guile.h: Rename include guard.
15166         * guile/guile-internal.h: Rename include guard.
15167         * gnu-nat.h: Rename include guard.
15168         * gdb-stabs.h: Rename include guard.
15169         * frv-tdep.h: Add include guard.
15170         * f-lang.h: Add include guard.
15171         * event-loop.h: Add include guard.
15172         * darwin-nat.h: Rename include guard.
15173         * cp-abi.h: Rename include guard.
15174         * config/sparc/nm-sol2.h: Rename include guard.
15175         * config/nm-nto.h: Rename include guard.
15176         * config/nm-linux.h: Add include guard.
15177         * config/i386/nm-i386gnu.h: Rename include guard.
15178         * config/djgpp/nl_types.h: Rename include guard.
15179         * config/djgpp/langinfo.h: Rename include guard.
15180         * compile/gcc-cp-plugin.h: Add include guard.
15181         * compile/gcc-c-plugin.h: Add include guard.
15182         * compile/compile.h: Rename include guard.
15183         * compile/compile-object-run.h: Rename include guard.
15184         * compile/compile-object-load.h: Rename include guard.
15185         * compile/compile-internal.h: Rename include guard.
15186         * compile/compile-cplus.h: Rename include guard.
15187         * compile/compile-c.h: Rename include guard.
15188         * common/xml-utils.h: Rename include guard.
15189         * common/x86-xstate.h: Rename include guard.
15190         * common/version.h: Rename include guard.
15191         * common/vec.h: Rename include guard.
15192         * common/tdesc.h: Rename include guard.
15193         * common/selftest.h: Rename include guard.
15194         * common/scoped_restore.h: Rename include guard.
15195         * common/scoped_mmap.h: Rename include guard.
15196         * common/scoped_fd.h: Rename include guard.
15197         * common/safe-iterator.h: Rename include guard.
15198         * common/run-time-clock.h: Rename include guard.
15199         * common/refcounted-object.h: Rename include guard.
15200         * common/queue.h: Rename include guard.
15201         * common/ptid.h: Rename include guard.
15202         * common/print-utils.h: Rename include guard.
15203         * common/preprocessor.h: Rename include guard.
15204         * common/pathstuff.h: Rename include guard.
15205         * common/observable.h: Rename include guard.
15206         * common/netstuff.h: Rename include guard.
15207         * common/job-control.h: Rename include guard.
15208         * common/host-defs.h: Rename include guard.
15209         * common/gdb_wait.h: Rename include guard.
15210         * common/gdb_vecs.h: Rename include guard.
15211         * common/gdb_unlinker.h: Rename include guard.
15212         * common/gdb_unique_ptr.h: Rename include guard.
15213         * common/gdb_tilde_expand.h: Rename include guard.
15214         * common/gdb_sys_time.h: Rename include guard.
15215         * common/gdb_string_view.h: Rename include guard.
15216         * common/gdb_splay_tree.h: Rename include guard.
15217         * common/gdb_setjmp.h: Rename include guard.
15218         * common/gdb_ref_ptr.h: Rename include guard.
15219         * common/gdb_optional.h: Rename include guard.
15220         * common/gdb_locale.h: Rename include guard.
15221         * common/gdb_assert.h: Rename include guard.
15222         * common/filtered-iterator.h: Rename include guard.
15223         * common/filestuff.h: Rename include guard.
15224         * common/fileio.h: Rename include guard.
15225         * common/environ.h: Rename include guard.
15226         * common/common-utils.h: Rename include guard.
15227         * common/common-types.h: Rename include guard.
15228         * common/common-regcache.h: Rename include guard.
15229         * common/common-inferior.h: Rename include guard.
15230         * common/common-gdbthread.h: Rename include guard.
15231         * common/common-exceptions.h: Rename include guard.
15232         * common/common-defs.h: Rename include guard.
15233         * common/common-debug.h: Rename include guard.
15234         * common/cleanups.h: Rename include guard.
15235         * common/buffer.h: Rename include guard.
15236         * common/btrace-common.h: Rename include guard.
15237         * common/break-common.h: Rename include guard.
15238         * cli/cli-utils.h: Rename include guard.
15239         * cli/cli-style.h: Rename include guard.
15240         * cli/cli-setshow.h: Rename include guard.
15241         * cli/cli-script.h: Rename include guard.
15242         * cli/cli-interp.h: Rename include guard.
15243         * cli/cli-decode.h: Rename include guard.
15244         * cli/cli-cmds.h: Rename include guard.
15245         * charset-list.h: Add include guard.
15246         * buildsym-legacy.h: Rename include guard.
15247         * bfin-tdep.h: Add include guard.
15248         * ax.h: Rename include guard.
15249         * arm-linux-tdep.h: Add include guard.
15250         * arm-fbsd-tdep.h: Add include guard.
15251         * arch/xtensa.h: Rename include guard.
15252         * arch/tic6x.h: Add include guard.
15253         * arch/i386.h: Add include guard.
15254         * arch/arm.h: Rename include guard.
15255         * arch/arm-linux.h: Rename include guard.
15256         * arch/arm-get-next-pcs.h: Rename include guard.
15257         * arch/amd64.h: Add include guard.
15258         * arch/aarch64-insn.h: Rename include guard.
15259         * arch-utils.h: Rename include guard.
15260         * annotate.h: Add include guard.
15261         * amd64-darwin-tdep.h: Rename include guard.
15262         * aarch64-linux-tdep.h: Add include guard.
15263         * aarch64-fbsd-tdep.h: Add include guard.
15264         * aarch32-linux-nat.h: Add include guard.
15265
15266 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15267
15268         * macrotab.c (macro_define_internal): New function that
15269         factorizes macro_define_object_internal and macro_define_function
15270         code.
15271         (macro_define_object_internal): Use macro_define_internal.
15272         (macro_define_function): Likewise.
15273
15274 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15275
15276         * macrocmd.c (extract_identifier): Return
15277         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15278         callers.
15279
15280 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15281
15282         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15283
15284 2019-02-05  Tom Tromey  <tom@tromey.com>
15285
15286         * target.c (target_stack::unpush): Move assertion earlier.
15287
15288 2019-01-30  Tom Tromey  <tom@tromey.com>
15289
15290         PR python/23615:
15291         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15292         (gdbpy_parse_and_eval): Likewise.
15293         * python/python-internal.h (gdbpy_allow_threads): New class.
15294
15295 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15296
15297         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15298         (aarch64_fbsd_fpregmap): Move earlier.
15299         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15300         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15301         instead of individual calls to trad_frame_set_reg_addr.
15302         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15303         earlier.
15304         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15305         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15306         instead of individual calls to trad_frame_set_reg_addr.
15307
15308 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15309
15310         * CONTRIBUTE: Replace contribution list with wiki link.
15311
15312 2019-01-25  Tom Tromey  <tom@tromey.com>
15313
15314         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15315
15316 2019-01-25  Tom Tromey  <tom@tromey.com>
15317
15318         * xtensa-linux-nat.c: Fix common/ includes.
15319         * xml-support.h: Fix common/ includes.
15320         * xml-support.c: Fix common/ includes.
15321         * x86-linux-nat.c: Fix common/ includes.
15322         * windows-nat.c: Fix common/ includes.
15323         * varobj.h: Fix common/ includes.
15324         * varobj.c: Fix common/ includes.
15325         * value.c: Fix common/ includes.
15326         * valops.c: Fix common/ includes.
15327         * utils.c: Fix common/ includes.
15328         * unittests/xml-utils-selftests.c: Fix common/ includes.
15329         * unittests/utils-selftests.c: Fix common/ includes.
15330         * unittests/unpack-selftests.c: Fix common/ includes.
15331         * unittests/tracepoint-selftests.c: Fix common/ includes.
15332         * unittests/style-selftests.c: Fix common/ includes.
15333         * unittests/string_view-selftests.c: Fix common/ includes.
15334         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15335         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15336         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15337         * unittests/rsp-low-selftests.c: Fix common/ includes.
15338         * unittests/parse-connection-spec-selftests.c: Fix common/
15339         includes.
15340         * unittests/optional-selftests.c: Fix common/ includes.
15341         * unittests/offset-type-selftests.c: Fix common/ includes.
15342         * unittests/observable-selftests.c: Fix common/ includes.
15343         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15344         * unittests/memrange-selftests.c: Fix common/ includes.
15345         * unittests/memory-map-selftests.c: Fix common/ includes.
15346         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15347         * unittests/function-view-selftests.c: Fix common/ includes.
15348         * unittests/environ-selftests.c: Fix common/ includes.
15349         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15350         * unittests/common-utils-selftests.c: Fix common/ includes.
15351         * unittests/cli-utils-selftests.c: Fix common/ includes.
15352         * unittests/array-view-selftests.c: Fix common/ includes.
15353         * ui-file.c: Fix common/ includes.
15354         * tui/tui-io.c: Fix common/ includes.
15355         * tracepoint.h: Fix common/ includes.
15356         * tracepoint.c: Fix common/ includes.
15357         * tracefile-tfile.c: Fix common/ includes.
15358         * top.h: Fix common/ includes.
15359         * top.c: Fix common/ includes.
15360         * thread.c: Fix common/ includes.
15361         * target/waitstatus.h: Fix common/ includes.
15362         * target/waitstatus.c: Fix common/ includes.
15363         * target.h: Fix common/ includes.
15364         * target.c: Fix common/ includes.
15365         * target-memory.c: Fix common/ includes.
15366         * target-descriptions.c: Fix common/ includes.
15367         * symtab.h: Fix common/ includes.
15368         * symfile.c: Fix common/ includes.
15369         * stap-probe.c: Fix common/ includes.
15370         * spu-linux-nat.c: Fix common/ includes.
15371         * sparc-nat.c: Fix common/ includes.
15372         * source.c: Fix common/ includes.
15373         * solib.c: Fix common/ includes.
15374         * solib-target.c: Fix common/ includes.
15375         * ser-unix.c: Fix common/ includes.
15376         * ser-tcp.c: Fix common/ includes.
15377         * ser-pipe.c: Fix common/ includes.
15378         * ser-base.c: Fix common/ includes.
15379         * selftest-arch.c: Fix common/ includes.
15380         * s12z-tdep.c: Fix common/ includes.
15381         * rust-exp.y: Fix common/ includes.
15382         * rs6000-aix-tdep.c: Fix common/ includes.
15383         * riscv-tdep.c: Fix common/ includes.
15384         * remote.c: Fix common/ includes.
15385         * remote-notif.h: Fix common/ includes.
15386         * remote-fileio.h: Fix common/ includes.
15387         * remote-fileio.c: Fix common/ includes.
15388         * regcache.h: Fix common/ includes.
15389         * regcache.c: Fix common/ includes.
15390         * record-btrace.c: Fix common/ includes.
15391         * python/python.c: Fix common/ includes.
15392         * python/py-type.c: Fix common/ includes.
15393         * python/py-inferior.c: Fix common/ includes.
15394         * progspace.h: Fix common/ includes.
15395         * producer.c: Fix common/ includes.
15396         * procfs.c: Fix common/ includes.
15397         * proc-api.c: Fix common/ includes.
15398         * printcmd.c: Fix common/ includes.
15399         * ppc-linux-nat.c: Fix common/ includes.
15400         * parser-defs.h: Fix common/ includes.
15401         * osdata.c: Fix common/ includes.
15402         * obsd-nat.c: Fix common/ includes.
15403         * nat/x86-linux.c: Fix common/ includes.
15404         * nat/x86-linux-dregs.c: Fix common/ includes.
15405         * nat/x86-dregs.h: Fix common/ includes.
15406         * nat/x86-dregs.c: Fix common/ includes.
15407         * nat/ppc-linux.c: Fix common/ includes.
15408         * nat/mips-linux-watch.h: Fix common/ includes.
15409         * nat/mips-linux-watch.c: Fix common/ includes.
15410         * nat/linux-waitpid.c: Fix common/ includes.
15411         * nat/linux-ptrace.h: Fix common/ includes.
15412         * nat/linux-ptrace.c: Fix common/ includes.
15413         * nat/linux-procfs.c: Fix common/ includes.
15414         * nat/linux-personality.c: Fix common/ includes.
15415         * nat/linux-osdata.c: Fix common/ includes.
15416         * nat/linux-namespaces.c: Fix common/ includes.
15417         * nat/linux-btrace.h: Fix common/ includes.
15418         * nat/linux-btrace.c: Fix common/ includes.
15419         * nat/fork-inferior.c: Fix common/ includes.
15420         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15421         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15422         * nat/aarch64-linux.c: Fix common/ includes.
15423         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15424         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15425         * namespace.h: Fix common/ includes.
15426         * mips-linux-tdep.c: Fix common/ includes.
15427         * minsyms.c: Fix common/ includes.
15428         * mi/mi-parse.h: Fix common/ includes.
15429         * mi/mi-main.c: Fix common/ includes.
15430         * mi/mi-cmd-env.c: Fix common/ includes.
15431         * memrange.h: Fix common/ includes.
15432         * memattr.c: Fix common/ includes.
15433         * maint.h: Fix common/ includes.
15434         * maint.c: Fix common/ includes.
15435         * main.c: Fix common/ includes.
15436         * machoread.c: Fix common/ includes.
15437         * location.c: Fix common/ includes.
15438         * linux-thread-db.c: Fix common/ includes.
15439         * linux-nat.c: Fix common/ includes.
15440         * linux-fork.c: Fix common/ includes.
15441         * inline-frame.c: Fix common/ includes.
15442         * infrun.c: Fix common/ includes.
15443         * inflow.c: Fix common/ includes.
15444         * inferior.h: Fix common/ includes.
15445         * inferior.c: Fix common/ includes.
15446         * infcmd.c: Fix common/ includes.
15447         * inf-ptrace.c: Fix common/ includes.
15448         * inf-child.c: Fix common/ includes.
15449         * ia64-linux-nat.c: Fix common/ includes.
15450         * i387-tdep.c: Fix common/ includes.
15451         * i386-tdep.c: Fix common/ includes.
15452         * i386-linux-tdep.c: Fix common/ includes.
15453         * i386-linux-nat.c: Fix common/ includes.
15454         * i386-go32-tdep.c: Fix common/ includes.
15455         * i386-fbsd-tdep.c: Fix common/ includes.
15456         * i386-fbsd-nat.c: Fix common/ includes.
15457         * guile/scm-type.c: Fix common/ includes.
15458         * guile/guile.c: Fix common/ includes.
15459         * go32-nat.c: Fix common/ includes.
15460         * gnu-nat.c: Fix common/ includes.
15461         * gdbthread.h: Fix common/ includes.
15462         * gdbarch-selftests.c: Fix common/ includes.
15463         * gdb_usleep.c: Fix common/ includes.
15464         * gdb_select.h: Fix common/ includes.
15465         * gdb_bfd.c: Fix common/ includes.
15466         * gcore.c: Fix common/ includes.
15467         * fork-child.c: Fix common/ includes.
15468         * findvar.c: Fix common/ includes.
15469         * fbsd-nat.c: Fix common/ includes.
15470         * event-top.c: Fix common/ includes.
15471         * event-loop.c: Fix common/ includes.
15472         * dwarf2read.c: Fix common/ includes.
15473         * dwarf2loc.c: Fix common/ includes.
15474         * dwarf2-frame.c: Fix common/ includes.
15475         * dwarf-index-cache.c: Fix common/ includes.
15476         * dtrace-probe.c: Fix common/ includes.
15477         * disasm-selftests.c: Fix common/ includes.
15478         * defs.h: Fix common/ includes.
15479         * csky-tdep.c: Fix common/ includes.
15480         * cp-valprint.c: Fix common/ includes.
15481         * cp-support.h: Fix common/ includes.
15482         * cp-support.c: Fix common/ includes.
15483         * corelow.c: Fix common/ includes.
15484         * completer.h: Fix common/ includes.
15485         * completer.c: Fix common/ includes.
15486         * compile/compile.c: Fix common/ includes.
15487         * compile/compile-loc2c.c: Fix common/ includes.
15488         * compile/compile-cplus-types.c: Fix common/ includes.
15489         * compile/compile-cplus-symbols.c: Fix common/ includes.
15490         * command.h: Fix common/ includes.
15491         * cli/cli-dump.c: Fix common/ includes.
15492         * cli/cli-cmds.c: Fix common/ includes.
15493         * charset.c: Fix common/ includes.
15494         * build-id.c: Fix common/ includes.
15495         * btrace.h: Fix common/ includes.
15496         * btrace.c: Fix common/ includes.
15497         * breakpoint.h: Fix common/ includes.
15498         * breakpoint.c: Fix common/ includes.
15499         * ax.h:
15500         (enum agent_op): Fix common/ includes.
15501         * ax-general.c (struct aop_map): Fix common/ includes.
15502         * ax-gdb.c: Fix common/ includes.
15503         * auxv.c: Fix common/ includes.
15504         * auto-load.c: Fix common/ includes.
15505         * arm-tdep.c: Fix common/ includes.
15506         * arch/riscv.c: Fix common/ includes.
15507         * arch/ppc-linux-common.c: Fix common/ includes.
15508         * arch/i386.c: Fix common/ includes.
15509         * arch/arm.c: Fix common/ includes.
15510         * arch/arm-linux.c: Fix common/ includes.
15511         * arch/arm-get-next-pcs.c: Fix common/ includes.
15512         * arch/amd64.c: Fix common/ includes.
15513         * arch/aarch64.c: Fix common/ includes.
15514         * arch/aarch64-insn.c: Fix common/ includes.
15515         * arch-utils.c: Fix common/ includes.
15516         * amd64-windows-tdep.c: Fix common/ includes.
15517         * amd64-tdep.c: Fix common/ includes.
15518         * amd64-sol2-tdep.c: Fix common/ includes.
15519         * amd64-obsd-tdep.c: Fix common/ includes.
15520         * amd64-nbsd-tdep.c: Fix common/ includes.
15521         * amd64-linux-tdep.c: Fix common/ includes.
15522         * amd64-linux-nat.c: Fix common/ includes.
15523         * amd64-fbsd-tdep.c: Fix common/ includes.
15524         * amd64-fbsd-nat.c: Fix common/ includes.
15525         * amd64-dicos-tdep.c: Fix common/ includes.
15526         * amd64-darwin-tdep.c: Fix common/ includes.
15527         * agent.c: Fix common/ includes.
15528         * ada-lang.h: Fix common/ includes.
15529         * ada-lang.c: Fix common/ includes.
15530         * aarch64-tdep.c: Fix common/ includes.
15531
15532 2019-01-25  Tom Tromey  <tom@tromey.com>
15533
15534         * common/create-version.sh: Use common/version.h.
15535
15536 2019-01-24  Pedro Alves  <palves@redhat.com>
15537
15538         * infrun.c (signal_stop, signal_print, signal_program)
15539         (signal_catch, signal_pass): Now arrays instead of pointers.
15540         (update_signals_program_target, do_target_resume)
15541         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15542         * linux-nat.c (linux_nat_target::pass_signals)
15543         (linux_nat_target::create_inferior, linux_nat_target::attach):
15544         Adjust.
15545         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15546         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15547         * procfs.c (procfs_target::pass_signals): Adjust.
15548         * record-full.c (record_full_target::resume): Adjust.
15549         * remote.c (remote_target::pass_signals)
15550         (remote_target::program_signals): Adjust.
15551         * target-debug.h (target_debug_print_signals): Now takes a
15552         gdb::array_view as parameter.  Adjust.
15553         * target.h (target_ops) <pass_signals, program_signals>: Replace
15554         pointer and length parameters with gdb::array_view.
15555         (target_pass_signals, target_program_signals): Likewise.
15556         * target-delegates.c: Regenerate.
15557
15558 2019-01-24  Pedro Alves  <palves@redhat.com>
15559
15560         * common/forward-scope-exit.h
15561         (forward_scope_exit::forward_scope_exit): Pass arguments to
15562         m_bind_function directly, instead of creating a std::bind and
15563         copying that.
15564
15565 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15566
15567         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15568         for static members.
15569         (pass_in_v_vfp_candidate): Likewise.
15570
15571 2019-01-23  Tom Tromey  <tom@tromey.com>
15572             Pedro Alves  <palves@redhat.com>
15573
15574         * regcache.c (class regcache_invalidator): Remove.
15575         (regcache::raw_write): Use make_scope_exit.
15576
15577 2019-01-23  Tom Tromey  <tom@tromey.com>
15578
15579         * ui-out.h (class ui_out_emit_type): Update comment.
15580
15581 2019-01-23  Tom Tromey  <tom@tromey.com>
15582
15583         * infrun.c (fetch_inferior_event): Update comment.
15584
15585 2019-01-23  Tom Tromey  <tom@tromey.com>
15586             Pedro Alves  <palves@redhat.com>
15587
15588         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15589         parameter.
15590         (fetch_inferior_event): Use SCOPE_EXIT.
15591
15592
15593 2019-01-23  Tom Tromey  <tom@tromey.com>
15594             Pedro Alves  <palves@redhat.com>
15595
15596         * infrun.c (disable_thread_events): Delete.
15597         (stop_all_threads): Use SCOPE_EXIT.
15598
15599 2019-01-23  Tom Tromey  <tom@tromey.com>
15600             Pedro Alves  <palves@redhat.com>
15601
15602         * symfile.c: Include forward-scope-exit.h.
15603         (clear_symtab_users_cleanup): Replace forward declaration with
15604         a FORWARD_SCOPE_EXIT.
15605         (syms_from_objfile_1): Use the forward_scope_exit and
15606         gdb::optional instead of cleanup_function.
15607         (reread_symbols): Use the forward_scope_exit instead of
15608         cleanup_function.
15609         (clear_symtab_users_cleanup): Remove function.
15610
15611 2019-01-23  Tom Tromey  <tom@tromey.com>
15612             Pedro Alves  <palves@redhat.com>
15613
15614         * linux-nat.c: Include scope-exit.h.
15615         (cleanup_target_stop): Remove.
15616         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15617         SCOPE_EXIT.
15618
15619 2019-01-23  Tom Tromey  <tom@tromey.com>
15620             Pedro Alves  <palves@redhat.com>
15621
15622         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15623         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15624
15625 2019-01-23  Tom Tromey  <tom@tromey.com>
15626             Andrew Burgess  <andrew.burgess@embecosm.com>
15627             Pedro Alves  <palves@redhat.com>
15628
15629         * infrun.c (fetch_inferior_event): Use scope_exit.
15630         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15631         * top.c (execute_command): Use scope_exit.
15632         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15633         * utils.c (do_bpstat_clear_actions_cleanup)
15634         (make_bpstat_clear_actions_cleanup): Remove.
15635
15636 2019-01-23  Tom Tromey  <tom@tromey.com>
15637             Pedro Alves  <palves@redhat.com>
15638
15639         * infrun.c: Include "common/scope-exit.h"
15640         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15641         (wait_for_inferior): Use SCOPE_EXIT.
15642         (fetch_inferior_event): Use scope_exit.
15643
15644 2019-01-23  Tom Tromey  <tom@tromey.com>
15645             Pedro Alves  <palves@redhat.com>
15646
15647         * breakpoint.c (create_breakpoint): Remove cleanup.
15648
15649 2019-01-23  Tom Tromey  <tom@tromey.com>
15650             Andrew Burgess  <andrew.burgess@embecosm.com>
15651             Pedro Alves  <palves@redhat.com>
15652
15653 2019-01-23  Pedro Alves  <palves@redhat.com>
15654
15655         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15656
15657 2019-01-23  Pedro Alves  <palves@redhat.com>
15658             Andrew Burgess  <andrew.burgess@embecosm.com>
15659
15660         * gdbthread.h: Include "common/forward-scope-exit.h".
15661         (scoped_finish_thread_state): Redefine custom class in terms of
15662         forward_scope_exit.
15663
15664 2019-01-23  Pedro Alves  <palves@redhat.com>
15665             Andrew Burgess  <andrew.burgess@embecosm.com>
15666
15667         * common/forward-scope-exit.h: New file.
15668
15669 2019-01-23  Pedro Alves  <palves@redhat.com>
15670             Andrew Burgess  <andrew.burgess@embecosm.com>
15671             Tom Tromey  <tom@tromey.com>
15672
15673         * common/scope-exit.h: New file.
15674
15675 2019-01-23  Pedro Alves  <palves@redhat.com>
15676
15677         * common/preprocessor.h (ESC): Rename to ...
15678         (ESC_PARENS): ... this.
15679         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15680         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15681
15682 2019-01-23  Tom Tromey  <tom@tromey.com>
15683
15684         * language.h (class scoped_switch_to_sym_language_if_auto):
15685         Initialize m_lang in both cases.
15686
15687 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15688
15689         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15690         with XCNEW.
15691
15692 2019-01-22  Tom Tromey  <tom@tromey.com>
15693
15694         * corelow.c: Do not include sys/file.h.
15695
15696 2019-01-22  Tom Tromey  <tom@tromey.com>
15697
15698         * tui/tui-wingeneral.h: Include gdb_curses.h.
15699
15700 2019-01-22  Tom Tromey  <tom@tromey.com>
15701
15702         * source-cache.h (class source_cache) <get_source_lines,
15703         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15704
15705 2019-01-22  Tom Tromey  <tom@tromey.com>
15706
15707         * remote-fileio.h (struct remote_target): Declare.
15708
15709 2019-01-22  Tom Tromey  <tom@tromey.com>
15710
15711         * python/py-arch.c: Do not include py-ref.h.
15712         * python/py-bpevent.c: Do not include py-ref.h.
15713         * python/py-cmd.c: Do not include py-ref.h.
15714         * python/py-continueevent.c: Do not include py-ref.h.
15715         * python/py-event.h: Do not include py-ref.h.
15716         * python/py-evtregistry.c: Do not include py-ref.h.
15717         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15718         * python/py-frame.c: Do not include py-ref.h.
15719         * python/py-framefilter.c: Do not include py-ref.h.
15720         * python/py-function.c: Do not include py-ref.h.
15721         * python/py-infevents.c: Do not include py-ref.h.
15722         * python/py-linetable.c: Do not include py-ref.h.
15723         * python/py-objfile.c: Do not include py-ref.h.
15724         * python/py-param.c: Do not include py-ref.h.
15725         * python/py-prettyprint.c: Do not include py-ref.h.
15726         * python/py-progspace.c: Do not include py-ref.h.
15727         * python/py-symbol.c: Do not include py-ref.h.
15728         * python/py-symtab.c: Do not include py-ref.h.
15729         * python/py-type.c: Do not include py-ref.h.
15730         * python/py-unwind.c: Do not include py-ref.h.
15731         * python/py-utils.c: Do not include py-ref.h.
15732         * python/py-value.c: Do not include py-ref.h.
15733         * python/py-varobj.c: Do not include py-ref.h.
15734         * python/py-xmethods.c: Do not include py-ref.h.
15735         * python/python.c: Do not include py-ref.h.
15736         * varobj.c: Do not include py-ref.h.
15737
15738 2019-01-22  Tom Tromey  <tom@tromey.com>
15739
15740         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15741         keyword for bcache.
15742
15743 2019-01-22  Tom Tromey  <tom@tromey.com>
15744
15745         * compile/compile-cplus-types.c: Remove a comment by #include.
15746
15747 2019-01-22  Tom Tromey  <tom@tromey.com>
15748
15749         * compile/gcc-c-plugin.h: Include compile-internal.h.
15750
15751 2019-01-22  Tom Tromey  <tom@tromey.com>
15752
15753         * stabsread.c (EXTERN): Do not define.
15754         (symnum, next_symbol_text_func, processing_gcc_compilation)
15755         (within_function, global_sym_chain, global_stabs)
15756         (previous_stab_code, this_object_header_files)
15757         (n_this_object_header_files)
15758         (n_allocated_this_object_header_files): Define.
15759         * stabsread.h (EXTERN): Never define.  Use "extern".
15760
15761 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15762
15763         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15764         history_value.
15765
15766 2019-01-21  Tom Tromey  <tom@tromey.com>
15767
15768         * ui-out.c: Fix includes.
15769         * tui/tui-source.c: Fix includes.
15770         * target.c: Fix includes.
15771         * remote.c: Fix includes.
15772         * regcache.c: Fix includes.
15773         * python/py-block.c: Fix includes.
15774         * printcmd.c: Fix includes.
15775         * or1k-tdep.c: Fix includes.
15776         * mi/mi-main.c: Fix includes.
15777         * m32r-tdep.c: Fix includes.
15778         * csky-tdep.c: Fix includes.
15779         * compile/compile-cplus-types.c: Fix includes.
15780         * cli/cli-interp.c: Fix includes.
15781
15782 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15783
15784         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15785         for padding.
15786
15787 2019-01-16  Tom Tromey  <tom@tromey.com>
15788
15789         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15790         earlier.
15791         (struct objfile) <msymbols_range>: Move from top level.
15792         <msymbols>: New method.
15793         (class objfile_msymbols): Remove.
15794         * symtab.c (default_collect_symbol_completion_matches_break_on):
15795         Update.
15796         * symmisc.c (dump_msymbols): Update.
15797         * stabsread.c (scan_file_globals): Update.
15798         * objc-lang.c (info_selectors_command, info_classes_command)
15799         (find_methods): Update.
15800         * minsyms.c (find_solib_trampoline_target): Update.
15801         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15802         * coffread.c (coff_symfile_read): Update.
15803         * ada-lang.c (ada_lookup_simple_minsym)
15804         (ada_collect_symbol_completion_matches): Update.
15805
15806 2019-01-16  Tom Tromey  <tom@tromey.com>
15807
15808         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15809         type.  Remove no-argument constructor.
15810         <iterator::operator++>: Simplify.
15811         <begin>: Update.
15812         <end>: Use minimal_symbol_count.
15813
15814 2019-01-16  Tom Tromey  <tom@tromey.com>
15815
15816         * objfiles.h (struct objfile) <psymtabs>: New method.
15817         (class objfile_psymtabs): Remove.
15818         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15819         typedef.
15820         <range>: New method.
15821         (require_partial_symbols): Change return type.
15822         * psymtab.c (require_partial_symbols)
15823         (psym_expand_symtabs_matching): Update.
15824         * mdebugread.c (parse_partial_symbols): Update.
15825         * dbxread.c (dbx_end_psymtab): Update.
15826
15827 2019-01-15  Tom Tromey  <tom@tromey.com>
15828
15829         * symtab.c (lookup_objfile_from_block)
15830         (lookup_symbol_in_objfile_symtabs)
15831         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15832         (find_line_symtab, info_sources_command)
15833         (default_collect_symbol_completion_matches_break_on)
15834         (make_source_files_completion_list): Update.
15835         * symmisc.c (print_objfile_statistics, dump_objfile)
15836         (maintenance_print_symbols, maintenance_info_symtabs)
15837         (maintenance_check_symtabs, maintenance_info_line_tables):
15838         Update.
15839         * source.c (select_source_symtab)
15840         (forget_cached_source_info_for_objfile): Update.
15841         * objfiles.h (class objfile_compunits): Remove.
15842         (struct objfile) <compunits_range>: New typedef.
15843         (compunits): New method.
15844         * objfiles.c (objfile_relocate1): Update.
15845         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15846         * maint.c (count_symtabs_and_blocks): Update.
15847         * linespec.c (iterate_over_all_matching_symtabs): Update.
15848         * cp-support.c (add_symbol_overload_list_qualified): Update.
15849         * coffread.c (coff_symtab_read): Update.
15850         * ada-lang.c (add_nonlocal_symbols)
15851         (ada_collect_symbol_completion_matches)
15852         (ada_add_global_exceptions): Update.
15853
15854 2019-01-15  Tom Tromey  <tom@tromey.com>
15855
15856         * progspace.h (program_space) <objfiles_safe_range>: New
15857         typedef.
15858         <objfiles_safe>: New method.
15859         * objfiles.h (class all_objfiles_safe): Remove.
15860         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15861         * jit.c (jit_inferior_exit_hook): Update.
15862
15863 2019-01-17  Tom Tromey  <tom@tromey.com>
15864
15865         * progspace.h (program_space) <objfiles_range>: New typedef.
15866         <objfiles>: New method.
15867         <objfiles_head>: Rename from objfiles.
15868         (object_files): Update.
15869         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15870         * guile/scm-pretty-print.c
15871         (ppscm_find_pretty_printer_from_objfiles): Update.
15872         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15873         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15874         Update.
15875         * python/py-progspace.c (pspy_get_objfiles): Update.
15876         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15877         Update.
15878         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15879         (objfpy_lookup_objfile_by_build_id): Update.
15880         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15881         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15882         Update.
15883         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15884         (expand_symtab_containing_pc, lookup_objfile_from_block)
15885         (lookup_static_symbol, basic_lookup_transparent_type)
15886         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15887         (find_line_symtab, info_sources_command)
15888         (default_collect_symbol_completion_matches_break_on)
15889         (make_source_files_completion_list, find_main_name): Update.
15890         * symmisc.c (print_symbol_bcache_statistics)
15891         (print_objfile_statistics, maintenance_print_symbols)
15892         (maintenance_print_msymbols, maintenance_print_objfiles)
15893         (maintenance_info_symtabs, maintenance_check_symtabs)
15894         (maintenance_expand_symtabs, maintenance_info_line_tables):
15895         Update.
15896         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15897         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15898         (map_overlay_command, unmap_overlay_command)
15899         (simple_overlay_update, expand_symtabs_matching)
15900         (map_symbol_filenames): Update.
15901         * symfile-debug.c (set_debug_symfile): Update.
15902         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15903         Update.
15904         * source.c (select_source_symtab, forget_cached_source_info):
15905         Update.
15906         * solib.c (solib_read_symbols): Update.
15907         * solib-spu.c (append_ocl_sos): Update.
15908         * psymtab.c (maintenance_print_psymbols)
15909         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15910         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15911         * printcmd.c (info_symbol_command): Update.
15912         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15913         Update.
15914         * objfiles.h (class all_objfiles): Remove.
15915         * objfiles.c (have_partial_symbols, have_full_symbols)
15916         (have_minimal_symbols, qsort_cmp, update_section_map)
15917         (shared_objfile_contains_address_p)
15918         (default_iterate_over_objfiles_in_search_order): Update.
15919         * objc-lang.c (info_selectors_command, info_classes_command)
15920         (find_methods): Update.
15921         * minsyms.c (find_solib_trampoline_target): Update.
15922         * maint.c (maintenance_info_sections)
15923         (maintenance_translate_address, count_symtabs_and_blocks):
15924         Update.
15925         * main.c (captured_main_1): Update.
15926         * linux-thread-db.c (try_thread_db_load_from_pdir)
15927         (has_libpthread): Update.
15928         * linespec.c (iterate_over_all_matching_symtabs)
15929         (search_minsyms_for_name): Update.
15930         * jit.c (jit_find_objf_with_entry_addr): Update.
15931         * hppa-tdep.c (find_unwind_entry)
15932         (hppa_lookup_stub_minimal_symbol): Update.
15933         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15934         Update.
15935         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15936         (elf_gnu_ifunc_resolve_by_got): Update.
15937         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15938         * dwarf-index-write.c (save_gdb_index_command): Update.
15939         * cp-support.c (add_symbol_overload_list_qualified): Update.
15940         * breakpoint.c (create_overlay_event_breakpoint)
15941         (create_longjmp_master_breakpoint)
15942         (create_std_terminate_master_breakpoint)
15943         (create_exception_master_breakpoint): Update.
15944         * blockframe.c (find_pc_partial_function): Update.
15945         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15946         (ada_collect_symbol_completion_matches)
15947         (ada_add_global_exceptions): Update.
15948
15949 2019-01-17  Tom Tromey  <tom@tromey.com>
15950
15951         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15952         declare VEC.
15953         (solib_target_parse_libraries): Change return type.
15954         (library_list_start_segment, library_list_start_section)
15955         (library_list_end_library, library_list_start_library); Update.
15956         (solib_target_free_library_list): Remove.
15957         (solib_target_parse_libraries): Remove cleanup.  Change return
15958         type.
15959         (solib_target_current_sos): Update.
15960
15961 2019-01-17  Tom Tromey  <tromey@bapiya>
15962
15963         * valprint.c: Replace "the the" with "the".
15964         * symtab.c: Replace "the the" with "the".
15965         * solib.c: Replace "the the" with "the".
15966         * solib-dsbt.c: Replace "the the" with "the".
15967         * linespec.c: Replace "the the" with "the".
15968         * dwarf2loc.h: Replace "the the" with "the".
15969         * amd64-windows-tdep.c: Replace "the the" with "the".
15970         * aarch64-tdep.c: Replace "the the" with "the".
15971
15972 2019-01-16  Keith Seitz  <keiths@redhat.com>
15973
15974         PR gdb/23773
15975         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15976         <builder>: Rename to ..
15977         <m_builder>: ... this and make private.
15978         (dwarf2_cu::get_builder): New method.  Change all users of
15979         `builder' to use this method.
15980         (dwarf2_start_symtab): Move to ...
15981         (dwarf2_cu::start_symtab): ... here.  Update all callers
15982         (setup_type_unit_groups): Move to ...
15983         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15984         callers.
15985         (dwarf2_cu::reset_builder): New method.
15986         (process_full_compunit, process_full_type_unit): Use
15987         dwarf2_cu::reset_builder.
15988         (follow_die_offset): Record the ancestor CU if it is different
15989         from the followed DIE's CU.
15990         (follow_die_sig_1): Likewise.
15991
15992 2019-01-15  Tom Tromey  <tom@tromey.com>
15993
15994         * remote.c (class remote_state) <buf>: Now a char_vector.
15995         <buf_size>: Remove.
15996         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15997         parameter.
15998         (remote_target::getpkt_or_notif_sane_1)
15999         (remote_target::getpkt_sane)
16000         (remote_target::getpkt_or_notif_sane): Likewise.
16001         (class remote_target) <putpkt>: New overload.
16002         (remote_target::read_frame): Change type of "buf_p".  Remove
16003         sizeof_p parameter.
16004         (packet_ok): New overload.
16005         (packet_check_result): New overload.
16006         Update all uses.
16007
16008 2019-01-14  Tom Tromey  <tom@tromey.com>
16009
16010         * remote-notif.c (handle_notification, remote_notif_ack)
16011         (remote_notif_parse): Make "buf" const.
16012         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16013         const.
16014         (remote_notif_parse, remote_notif_ack, handle_notification):
16015         Likewise.
16016         * remote.c (remote_notif_stop_parse): Make "buf" const.
16017         (remote_target::remote_parse_stop_reply): Make "buf" const.
16018         (remote_notif_stop_ack): Make "buf" const.
16019
16020 2019-01-14  Tom Tromey  <tom@tromey.com>
16021
16022         * remote.c (remote_console_output): Make parameter const.
16023
16024 2019-01-14  Tom Tromey  <tom@tromey.com>
16025
16026         * target-debug.h (target_debug_print_signals): Constify.
16027         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16028         * procfs.c (procfs_target::pass_signals): Update.
16029         * linux-nat.c (linux_nat_target::pass_signals): Update.
16030         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16031         * target-delegates.c: Rebuild.
16032         * remote.c (remote_target::program_signals): Update.
16033         (remote_target::pass_signals): Update.
16034         * target.c (target_pass_signals): Constify argument.
16035         (target_program_signals): Likewise.
16036         * target.h (struct target_ops) <pass_signals, program_signals>:
16037         Constify argument.
16038         (target_pass_signals, target_program_signals): Constify argument.
16039
16040 2019-01-14  Tom Tromey  <tom@tromey.com>
16041
16042         PR tui/28819:
16043         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16044
16045 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16046
16047         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16048         field.
16049         * rs6000-tdep.c: Include reggroups.h.
16050         (IS_V_ALIAS_PSEUDOREG): Define.
16051         (rs6000_register_name): Return names for the "vX" aliases.
16052         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16053         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16054         aliases.  Call default_register_reggroup_p for all other
16055         pseudo-registers.
16056         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16057         New functions.
16058         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16059         Handle "vX" aliases.
16060         (v_alias_pseudo_register_collect): New function.
16061         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16062         (rs6000_gdbarch_init): Initialize "vX" aliases as
16063         pseudo-registers.  Restore registration of
16064         rs6000_pseudo_register_reggroup_p with
16065         set_tdesc_pseudo_register_reggroup_p.
16066
16067 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16068
16069         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16070         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16071         set_gdbarch_num_pseudo_regs.
16072
16073 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16074
16075         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16076         Remove arg prefixname, add do_set and do_show.
16077         Add member functions set_list and show_list.
16078         * cli/cli-style.c (class cli_style_option): Update accordingly.
16079         (style_set_list): Move to file scope.
16080         (style_show_list): Likewise.
16081         (set_style): Call help_list.
16082         (show_style): Call cmd_show_list.
16083         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16084         Update to use the new macro.
16085
16086 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16087
16088         * ada-lang.c (_initialize_ada_language): Expand the help text
16089         for the "catch exception" command.
16090
16091 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16092
16093         * symtab.c (matching_obj_sections): Initialize obj,
16094         declare it closer to its usage.
16095
16096 2019-01-10  Tom Tromey  <tom@tromey.com>
16097
16098         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16099         (basic_inf_threads_range): Remove.
16100         (inf_threads_range, inf_non_exited_threads_range)
16101         (safe_inf_threads_range): Use next_adapter.
16102
16103 2019-01-10  Keith Seitz  <keiths@redhat.com>
16104
16105         PR gdb/23712
16106         PR symtab/23010
16107         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16108         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16109
16110 2019-01-10  Keith Seitz  <keiths@redhat.com>
16111
16112         PR gdb/23712
16113         PR symtab/23010
16114         * dictionary.c (pending_to_vector): Remove.
16115         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16116         Remove _1 suffix, replacing functions of the same name.  Update
16117         all callers.
16118         (dict_create_hashed, dict_create_hashed_expandable)
16119         (dict_create_linear, dict_create_linear_expandable, dict_free)
16120         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16121         Make functions static.
16122
16123 2019-01-10  Keith Seitz  <keiths@redhat.com>
16124
16125         PR gdb/23712
16126         PR symtab/23010
16127         * dictionary.h (struct dictionary): Replace declaration with
16128         multidictionary.
16129         (dict_create_hashed, dict_create_hashed_expandable)
16130         (dict_create_linear, dict_create_linear_expandable)
16131         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16132         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16133         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16134         taking multidictionary argument.
16135         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16136         * block.h (struct block) <dict>: Change to multidictionary
16137         and rename `multidict'.
16138         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16139         symmisc.c: Update all dictionary references to multidictionary.
16140
16141 2019-01-10  Keith Seitz  <keiths@redhat.com>
16142
16143         PR gdb/23712
16144         PR symtab/23010
16145         * dictionary.c: Include unordered_map.
16146         (pending_to_vector): New function.
16147         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16148         Rewrite the non-"_1" functions to take vector instead
16149         of linked list.
16150         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16151         "new" _1 versions of the same name.
16152         (multidictionary): Define.
16153         (std::hash<enum language): New definition.
16154         (collate_pending_symbols_by_language, mdict_create_hashed)
16155         (mdict_create_hashed_expandable, mdict_create_linear)
16156         (mdict_create_linear_expandable, mdict_free)
16157         (find_language_dictionary, create_new_language_dictionary)
16158         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16159         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16160         (mdict_size, mdict_empty): New functions.
16161         * dictionary.h (mdict_iterator): Define.
16162
16163 2019-01-10  Pedro Alves  <palves@redhat.com>
16164
16165         * breakpoint.c (read_uploaded_action)
16166         (create_tracepoint_from_upload): Adjust to use
16167         gdb::unique_xmalloc_ptr.
16168         * ctf.c (ctf_write_uploaded_tp):
16169         (SET_ARRAY_FIELD): Use emplace_back.
16170         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16171         * tracefile-tfile.c (tfile_write_uploaded_tp):
16172         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16173         gdb::unique_xmalloc_ptr.
16174         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16175         at_string, cond_string, cmd_strings>: Replace char pointers
16176         with gdb::unique_xmalloc_ptr.
16177
16178 2019-01-10  Pedro Alves  <palves@redhat.com>
16179
16180         * solib-target.c (library_list_start_library): Don't xstrdup name.
16181
16182 2019-01-10  Pedro Alves  <palves@redhat.com>
16183
16184         * mdebugread.c (parse_partial_symbols): Use
16185         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16186
16187 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16188
16189         * linux-fork.c (scoped_switch_fork_info)
16190         <~scoped_switch_fork_info>: Fix incorrect variable name.
16191
16192 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16193
16194         * linux-fork.c (scoped_switch_fork_info)
16195         <scoped_switch_fork_info>: Make explicit.
16196         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16197
16198 2019-01-10  Tom Tromey  <tom@tromey.com>
16199
16200         * objfiles.h (objfile::reset_psymtabs): Update.
16201         * objfiles.c (objfile::objfile): Update.
16202         * psymtab.h (psymtab_storage::obstack): Update.
16203         (psymtab_storage::m_obstack): Use gdb::optional.
16204         (class psymtab_storage): Update comment.  Remove objfile
16205         parameter.
16206         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16207
16208 2019-01-10  Tom Tromey  <tom@tromey.com>
16209
16210         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16211         <free_psymtabs>: Now private.
16212         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16213         (allocate_psymtab): Use new method.
16214
16215 2019-01-10  Tom Tromey  <tom@tromey.com>
16216
16217         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16218         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16219         * mdebugread.c (parse_partial_symbols): Use
16220         allocate_dependencies.
16221         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16222         allocate_dependencies.
16223         (process_psymtab_comp_unit_reader)
16224         (build_type_psymtab_dependencies): Likewise.
16225         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16226
16227 2019-01-10  Tom Tromey  <tom@tromey.com>
16228
16229         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16230         PSYMBOL_SET_LANGUAGE.
16231         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16232
16233 2019-01-10  Tom Tromey  <tom@tromey.com>
16234
16235         * psymtab.h (psymtab_storage::obstack): New method.
16236         <m_obstack>: Rename from obstack; now private.
16237         * psymtab.c (psymtab_storage): Update.
16238         * dwarf2read.c (create_addrmap_from_index)
16239         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16240         Update.
16241
16242 2019-01-10  Tom Tromey  <tom@tromey.com>
16243
16244         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16245         * objfiles.h (objfile::reset_psymtabs): New method.
16246
16247 2019-01-10  Tom Tromey  <tom@tromey.com>
16248
16249         * symmisc.c (print_symbol_bcache_statistics): Update.
16250         (print_objfile_statistics): Update.
16251         * symfile.c (reread_symbols): Update.
16252         * psymtab.h (class psymtab_storage): New.
16253         * psymtab.c (psymtab_storage): New constructor.
16254         (~psymtab_storage): New destructor.
16255         (require_partial_symbols): Update.
16256         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16257         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16258         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16259         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16260         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16261         (start_psymtab_common, end_psymtab_common)
16262         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16263         (allocate_psymtab): Update.
16264         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16265         Update.
16266         (dump_psymtab_addrmap, maintenance_print_psymbols)
16267         (maintenance_check_psymtabs): Update.
16268         (class objfile_psymtabs): Move to objfiles.h.
16269         * psympriv.h (discard_psymtab): Now inline.
16270         (psymtab_discarder::psymtab_discarder): Update.
16271         (psymtab_discarder::~psymtab_discarder): Update.
16272         (ALL_OBJFILE_PSYMTABS): Rewrite.
16273         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16274         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16275         Remove fields.
16276         <partial_symtabs>: New field.
16277         (class objfile_psymtabs): Move from psymtab.h.  Update.
16278         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16279         psymbol_cache.
16280         (objfile::~objfile): Don't destroy psymbol_cache.
16281         * mdebugread.c (parse_partial_symbols): Update.
16282         * dwarf2read.c (create_addrmap_from_index)
16283         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16284         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16285         (add_partial_subprogram, dwarf2_ranges_read): Update.
16286         * dwarf-index-write.c (write_address_map)
16287         (write_one_signatured_type, recursively_write_psymbols)
16288         (class debug_names, class debug_names, write_psymtabs_to_index):
16289         Update.
16290
16291 2019-01-10  Tom Tromey  <tom@tromey.com>
16292
16293         * symtab.h (SYMBOL_SET_NAMES): Update.
16294         (symbol_set_names): Update.
16295         (MSYMBOL_SET_NAMES): Update.
16296         * symtab.c (symbol_set_names): Change argument to be an
16297         objfile_per_bfd_storage.
16298         * psymtab.c (add_psymbol_to_bcache): Update.
16299         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16300
16301 2019-01-10  Tom Tromey  <tom@tromey.com>
16302
16303         * symtab.c (create_demangled_names_hash): Change argument to be an
16304         objfile_per_bfd_storage.
16305         (symbol_set_names): Update.
16306
16307 2019-01-10  Tom Tromey  <tom@tromey.com>
16308
16309         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16310         init_psymbol_list.
16311         * psymtab.c (init_psymbol_list): Do nothing if already called.
16312         * psympriv.h (init_psymbol_list): Add comment.
16313         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16314         init_psymbol_list.
16315         * dbxread.c (dbx_symfile_read): Unconditionally call
16316         init_psymbol_list.
16317
16318 2019-01-10  Tom Tromey  <tom@tromey.com>
16319
16320         * xcoffread.c (scan_xcoff_symtab): Update.
16321         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16322         "where".
16323         * mdebugread.c (parse_partial_symbols)
16324         (handle_psymbol_enumerators): Update.
16325         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16326         * dbxread.c (read_dbx_symtab): Update.
16327         * psympriv.h (psymbol_placement): New enum.
16328         (add_psymbol_to_list): Update.
16329
16330 2019-01-10  Tom Tromey  <tom@tromey.com>
16331
16332         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16333         static_psymbols parameters.
16334         (scan_xcoff_symtab): Update.
16335         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16336         static_psymbols parameters.
16337         * psympriv.h (start_psymtab_common): Update.
16338         * mdebugread.c (parse_partial_symbols): Update.
16339         * dwarf2read.c (create_partial_symtab): Update.
16340         * dbxread.c (read_dbx_symtab): Update.
16341         (start_psymtab): Remove global_psymbols and static_psymbols
16342         parameters.
16343
16344 2019-01-10  Tom Tromey  <tom@tromey.com>
16345
16346         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16347         * psymtab.c (allocate_psymtab): Add comment.
16348         * psympriv.h (allocate_psymtab): Add comment.
16349         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16350         initializations.
16351         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16352
16353 2019-01-10  Tom Tromey  <tom@tromey.com>
16354
16355         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16356         Don't declare.
16357         * mipsread.c: Include mdebugread.h.
16358         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16359         Declare.
16360         * elfread.c: Include mdebugread.h.
16361
16362 2019-01-09  Tom Tromey  <tom@tromey.com>
16363
16364         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16365         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16366         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16367         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16368         (psym_lookup_symbol, psym_find_last_source_symtab)
16369         (psym_forget_cached_source_info, psym_print_stats)
16370         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16371         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16372         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16373         (psym_find_compunit_symtab_by_address)
16374         (maintenance_print_psymbols, maintenance_info_psymtabs)
16375         (maintenance_check_psymtabs): Use ranged for.
16376         * psymtab.h (class objfile_psymtabs): New.
16377         (require_partial_symbols): Return objfile_psymtabs.
16378         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16379
16380 2019-01-09  Tom Tromey  <tom@tromey.com>
16381
16382         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16383         (find_pc_mapped_section, list_overlays_command)
16384         (map_overlay_command, unmap_overlay_command)
16385         (simple_overlay_update): Use all_objfiles.
16386         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16387         * printcmd.c (info_symbol_command): Use all_objfiles.
16388         * objfiles.h (ALL_OBJSECTIONS): Remove.
16389         * maint.c (maintenance_translate_address): Use all_objfiles.
16390         * gcore.c (gcore_create_callback): Use all_objfiles.
16391         (objfile_find_memory_regions): Likewise.
16392
16393 2019-01-09  Tom Tromey  <tom@tromey.com>
16394
16395         * symtab.c (find_line_symtab, info_sources_command)
16396         (make_source_files_completion_list): Use objfile_compunits.
16397         * source.c (select_source_symtab): Use objfile_compunits.
16398         * objfiles.h (struct objfile): Update comment.
16399         (ALL_OBJFILES): Remove.
16400         (ALL_FILETABS): Remove.
16401         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16402         objfile_compunits.
16403
16404 2019-01-09  Tom Tromey  <tom@tromey.com>
16405
16406         * symmisc.c (print_objfile_statistics, dump_objfile)
16407         (maintenance_print_symbols): Use compunit_filetabs.
16408         * source.c (forget_cached_source_info_for_objfile): Use
16409         compunit_filetabs.
16410         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16411         (ALL_FILETABS): Use compunit_filetabs.
16412         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16413         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16414
16415 2019-01-09  Tom Tromey  <tom@tromey.com>
16416
16417         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16418         (compunit_filetabs): New.
16419         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16420         compunit_filetabs.
16421         (info_sources_command, make_source_files_completion_list): Remove
16422         declaration.
16423         * symmisc.c (print_objfile_statistics, dump_objfile)
16424         (maintenance_print_symbols): Remove declaration.
16425         (maintenance_info_symtabs): Use compunit_filetabs.
16426         (maintenance_info_line_tables): Likewise.
16427         * source.c (select_source_symtab): Change local variable name.
16428         (forget_cached_source_info_for_objfile): Remove declaration.
16429         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16430         * objfiles.c (objfile_relocate1): Remove declaration.
16431         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16432         declaration.
16433         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16434         * coffread.c (coff_symtab_read): Remove declaration.
16435         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16436         compunit_filetabs.
16437
16438 2019-01-09  Tom Tromey  <tom@tromey.com>
16439
16440         * symtab.c (lookup_objfile_from_block)
16441         (find_pc_sect_compunit_symtab, search_symbols)
16442         (default_collect_symbol_completion_matches_break_on): Use
16443         objfile_compunits.
16444         * objfiles.h (ALL_COMPUNITS): Remove.
16445         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16446         * cp-support.c (add_symbol_overload_list_qualified): Use
16447         objfile_compunits.
16448         * ada-lang.c (ada_collect_symbol_completion_matches)
16449         (ada_add_global_exceptions): Use objfile_compunits.
16450
16451 2019-01-09  Tom Tromey  <tom@tromey.com>
16452
16453         * source.c (select_source_symtab)
16454         (forget_cached_source_info_for_objfile): Remove declaration.
16455         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16456         declaration.
16457         * maint.c (count_symtabs_and_blocks): Remove declaration.
16458         * cp-support.c (add_symbol_overload_list_qualified): Remove
16459         declaration.
16460         * coffread.c (coff_symtab_read): Remove declaration.
16461         * symtab.c (lookup_symbol_in_objfile_symtabs)
16462         (basic_lookup_transparent_type_1): Use objfile_compunits.
16463         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16464         (info_sources_command, search_symbols)
16465         (default_collect_symbol_completion_matches_break_on)
16466         (make_source_files_completion_list): Remove declaration.
16467         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16468         (ada_collect_symbol_completion_matches)
16469         (ada_add_global_exceptions): Remove declaration.
16470         * linespec.c (iterate_over_all_matching_symtabs): Use
16471         objfile_compunits.
16472         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16473         (class objfile_compunits): New.
16474         (ALL_COMPUNITS): Use objfile_compunits.
16475         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16476         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16477         objfile_compunits.
16478         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16479
16480 2019-01-09  Tom Tromey  <tom@tromey.com>
16481
16482         * symtab.c (search_symbols)
16483         (default_collect_symbol_completion_matches_break_on): Use
16484         objfile_msymbols.
16485         * ada-lang.c (ada_lookup_simple_minsym)
16486         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16487         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16488         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16489         objfile_msymbols.
16490         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16491         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16492         * objc-lang.c (find_methods): Use objfile_msymbols.
16493         (info_selectors_command, info_classes_command): Likewise.
16494         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16495         * objfiles.h (class objfile_msymbols): New.
16496         (ALL_OBJFILE_MSYMBOLS): Remove.
16497         (ALL_MSYMBOLS): Remove.
16498
16499 2019-01-09  Tom Tromey  <tom@tromey.com>
16500
16501         * common/next-iterator.h (next_adapter): Add Iterator template
16502         parameter.
16503         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16504         (class all_objfiles_safe): New.
16505         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16506         * objfiles.c (put_objfile_before): Update comment.
16507         (add_separate_debug_objfile): Likewise.
16508         (free_all_objfiles): Use all_objfiles_safe.
16509         (objfile_purge_solibs): Likewise.
16510
16511 2019-01-09  Tom Tromey  <tom@tromey.com>
16512
16513         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16514         (expand_symtab_containing_pc, lookup_static_symbol)
16515         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16516         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16517         all_objfiles.
16518         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16519         * breakpoint.c (create_overlay_event_breakpoint)
16520         (create_longjmp_master_breakpoint)
16521         (create_std_terminate_master_breakpoint)
16522         (create_exception_master_breakpoint): Use all_objfiles.
16523         * linux-thread-db.c (try_thread_db_load_from_pdir)
16524         (has_libpthread): Use all_objfiles.
16525         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16526         * linespec.c (iterate_over_all_matching_symtabs)
16527         (search_minsyms_for_name): Use all_objfiles.
16528         * maint.c (maintenance_info_sections): Use all_objfiles.
16529         * main.c (captured_main_1): Use all_objfiles.
16530         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16531         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16532         * guile/scm-pretty-print.c
16533         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16534         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16535         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16536         (maintenance_print_msymbols): Use all_objfiles.
16537         * source.c (select_source_symtab): Use all_objfiles.
16538         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16539         * symfile.c (remove_symbol_file_command)
16540         (expand_symtabs_matching, map_symbol_filenames): Use
16541         all_objfiles.
16542         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16543         all_objfiles.
16544         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16545         * objc-lang.c (find_methods): Use all_objfiles.
16546         * objfiles.c (have_partial_symbols, have_full_symbols)
16547         (have_minimal_symbols, qsort_cmp)
16548         (default_iterate_over_objfiles_in_search_order): Use
16549         all_objfiles.
16550         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16551         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16552         (maintenance_check_psymtabs): Use all_objfiles.
16553         (ALL_PSYMTABS): Remove.
16554         * compile/compile-object-run.c (do_module_cleanup): Use
16555         all_objfiles.
16556         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16557         * cp-support.c (add_symbol_overload_list_qualified): Use
16558         all_objfiles.
16559         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16560         Use all_objfiles.
16561         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16562         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16563         all_objfiles.
16564         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16565         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16566         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16567         Uses all_objfiles.
16568         * solib.c (solib_read_symbols): Use all_objfiles
16569
16570 2019-01-09  Tom Tromey  <tom@tromey.com>
16571
16572         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16573         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16574         all_objfiles.
16575         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16576         * symmisc.c (print_symbol_bcache_statistics)
16577         (print_objfile_statistics, maintenance_print_objfiles)
16578         (maintenance_info_symtabs, maintenance_check_symtabs)
16579         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16580         all_objfiles.
16581         * source.c (forget_cached_source_info): Use all_objfiles.
16582         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16583         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16584         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16585         * objfiles.c (update_section_map): Use all_objfiles.
16586         (shared_objfile_contains_address_p): Likewise.
16587         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16588         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16589
16590 2019-01-09  Tom Tromey  <tom@tromey.com>
16591
16592         * common/next-iterator.h: New file.
16593         * objfiles.h (class all_objfiles): New.
16594         (struct objfile_iterator): New.
16595
16596 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16597
16598         * NEWS: Move the description of the changed "frame", "select-frame",
16599          and "info frame" commands to the Changed commands section.
16600
16601 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16602
16603         * gdbtypes.c (check_stub_method_group): Remove handling of old
16604         mangling schemes.
16605         * linespec.c (find_methods): Likewise.
16606         * stabsread.c (read_member_functions): Likewise.
16607         * valops.c (search_struct_method): Likewise.
16608         (value_struct_elt_for_reference): Likewise.
16609         * NEWS: Mention this change.
16610
16611 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16612
16613         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16614         print_source_lines.
16615         * source.c (print_source_lines_base): Update line number check.
16616         (print_source_lines): New function.
16617         (source_lines_range::source_lines_range): New function.
16618         * source.h (class source_lines_range): New class.
16619         (print_source_lines): New declaration.
16620
16621 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16622
16623         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16624
16625 2019-01-08  Tom Tromey  <tom@tromey.com>
16626             Simon Marchi  <simon.marchi@ericsson.com>
16627
16628         PR gdb/24060
16629         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16630         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16631         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16632         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16633         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16634         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16635
16636 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16637
16638         * source.c (select_source_symtab): Move header comment to
16639         declaration in source.h.
16640         (forget_cached_source_info_for_objfile): Likewise.
16641         (forget_cached_source_info): Likewise.
16642         (identify_source_line): Likewise.
16643         * source.h (identify_source_line): Move declaration from symtab.h
16644         and add comment from source.c
16645         (print_source_lines): Likewise.
16646         (forget_cached_source_info_for_objfile): Likewise.
16647         (forget_cached_source_info): Likewise.
16648         (select_source_symtab): Likewise.
16649         (enum print_source_lines_flag): Move definition from symtab.h.
16650         * symtab.h (identify_source_line): Move declaration to source.h.
16651         (print_source_lines): Likewise.
16652         (forget_cached_source_info_for_objfile): Likewise.
16653         (forget_cached_source_info): Likewise.
16654         (select_source_symtab): Likewise.
16655         (enum print_source_lines_flag): Move definition to source.h.
16656         * tui/tui-hooks.c: Add 'source.h' include.
16657
16658 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16659
16660         * source.c (print_source_lines_base): Handle requests to print
16661         reverse line number sequences, and guard against empty lines
16662         string.
16663
16664 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16665
16666         * source.c (print_source_lines_base): Fix skip of '\r' if next
16667         character is '\n'.
16668
16669 2019-01-06  Tom Tromey  <tom@tromey.com>
16670
16671         * c-exp.y (struct c_parse_state) <macro_original_text,
16672         expansion_obstack>: New member.
16673         (macro_original_text, expansion_obstack): Remove globals.
16674         (scan_macro_expansion, scanning_macro_expansion)
16675         (finished_macro_expansion): Update.
16676         (scan_macro_cleanup): Remove.
16677         (yylex, c_parse): Update.
16678
16679 2019-01-06  Tom Tromey  <tom@tromey.com>
16680
16681         * c-exp.y (struct c_parse_state) <strings>: New member.
16682         (operator_stoken): Update.
16683
16684 2019-01-06  Tom Tromey  <tom@tromey.com>
16685
16686         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16687         (union type_stack_elt) <typelist_val>: Now a pointer to
16688         std::vector.
16689         (type_stack_cleanup): Don't declare.
16690         (push_typelist): Update.
16691         * parse.c (pop_typelist): Return a std::vector.
16692         (push_typelist): Take a std::vector.
16693         (follow_types): Update.  Do not free args.
16694         (type_stack_cleanup): Remove.
16695         * c-exp.y (struct c_parse_state): New.
16696         (cpstate): New global.
16697         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16698         (nonempty_typelist): Update.
16699         (func_mod): Create a new vector.
16700         (c_parse): Create a c_parse_state.
16701         (check_parameter_typelist): Do not delete params.
16702         (function_method): Update.  Do not delete type_list.
16703
16704 2019-01-06  Tom Tromey  <tom@tromey.com>
16705
16706         PR gdb/28155:
16707         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16708         check_typedef.
16709         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16710         (print_return_value): Likewise.
16711
16712 2019-01-05  Tom Tromey  <tom@tromey.com>
16713
16714         * contrib/cleanup_check.py: Remove.
16715         * contrib/gcc-with-excheck: Remove.
16716         * contrib/exsummary.py: Remove.
16717         * contrib/excheck.py: Remove.
16718
16719 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16720
16721         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16722         NULL. Initialize tpprev to NULL instead of assigning it
16723         to NULL on the next statement.
16724         * windows-nat.c (windows_delete_thread): Remove check for
16725         main_thread_id before printing thread exit notifications.
16726         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16727         Remove thread ID check against main_thread_id.
16728         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16729         windows_delete_thread.
16730         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16731
16732 2019-01-04  Tom Tromey  <tom@tromey.com>
16733
16734         * compile/compile.c (_initialize_compile): Use upper case for
16735         metasyntactic variables.
16736         * symmisc.c (_initialize_symmisc): Use upper case for
16737         metasyntactic variables.
16738         * psymtab.c (_initialize_psymtab): Use upper case for
16739         metasyntactic variables.
16740         * demangle.c (demangle_command): Use upper case for metasyntactic
16741         variables.
16742         (_initialize_demangler): Likewise.
16743         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16744         variables.
16745
16746 2019-01-03  Tom Tromey  <tom@tromey.com>
16747
16748         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16749
16750 2019-01-03  Tom Tromey  <tom@tromey.com>
16751
16752         * python/py-symtab.c (salpy_str): Update.
16753         (struct salpy_sal_object) <symtab>: Now a PyObject.
16754         (salpy_dealloc): Update.
16755         (del_objfile_sal): Use gdbpy_ref.
16756
16757 2019-01-03  Tom Tromey  <tom@tromey.com>
16758
16759         * python/py-type.c (convert_field): Use new_reference.  Return
16760         gdbpy_ref.
16761         (make_fielditem): Return gdbpy_ref.
16762         (typy_fields): Update.
16763         (typy_getitem): Update.
16764         (field_name): Return gdbpy_ref.  Use new_reference.
16765         (typy_iterator_iternext): Update.
16766
16767 2019-01-03  Tom Tromey  <tom@tromey.com>
16768
16769         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16770
16771 2019-01-03  Tom Tromey  <tom@tromey.com>
16772
16773         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16774         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16775         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16776         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16777         (pspy_set_type_printers): Likewise.
16778         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16779         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16780         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16781         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16782         (objfpy_set_type_printers): Likewise.
16783
16784 2019-01-03  Tom Tromey  <tom@tromey.com>
16785
16786         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16787         (gdbpy_print_stack): Use gdbpy_err_fetch.
16788         * python/python-internal.h (class gdbpy_err_fetch): New class.
16789         (class gdbpy_enter) <m_error_type, m_error_value,
16790         m_error_traceback>: Remove.
16791         <m_error>: New member.
16792         (gdbpy_exception_to_string): Don't declare.
16793         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16794         * python/py-value.c (convert_value_from_python): Use
16795         gdbpy_err_fetch.
16796         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16797         gdbpy_exception_to_string.
16798         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16799         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16800         gdbpy_err_fetch.
16801
16802 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16803
16804         * linux-nat.c (delete_lwp_cleanup): Delete.
16805         (struct lwp_deleter): New struct.
16806         (lwp_info_up): New typedef.
16807         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16808         lwp_info_up.
16809
16810 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16811
16812         * linux-fork.c (class scoped_switch_fork_info): New class.
16813         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16814
16815 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16816
16817         * valops.c (find_overload_match): Remove use of null_cleanup, and
16818         calls to do_cleanups.
16819
16820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16821
16822         * compile/compile-cplus-types.c
16823         (compile_cplus_instance::decl_name): Handle changes to
16824         cp_func_name.
16825         * cp-support.c (cp_func_name): Update header comment, update
16826         return type.
16827         * cp-support.h (cp_func_name): Update return type in declaration.
16828         * valops.c (find_overload_match): Move temp_func local to top
16829         level of function and change its type.  Use temp_func to hold and
16830         delete temporary string obtained from cp_func_name.
16831
16832 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16833
16834         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16835         gdb::char_vector, remove cleanup, and update uses of `msg`.
16836
16837 2019-01-03  Jim Wilson  <jimw@sifive.com>
16838
16839         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16840
16841 2019-01-02  Tom Tromey  <tom@tromey.com>
16842
16843         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16844         (tdesc_parse_xml): Remove cleanups.
16845         * target-descriptions.h (make_cleanup_free_target_description):
16846         Don't declare.
16847         (target_desc_deleter): New struct.
16848         (target_desc_up): New typedef.
16849         * target-descriptions.c (target_desc_deleter::operator()): Rename
16850         from free_target_description.
16851         (make_cleanup_free_target_description): Remove.
16852
16853 2019-01-02  Tom Tromey  <tom@tromey.com>
16854
16855         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16856         constructor, destructor.
16857         (linespec_parser): Remove typedef.
16858         (~linespec_parser): Rename from linespec_parser_delete.
16859         (linespec_lex_to_end, linespec_complete_label)
16860         (linespec_complete): Update.
16861         (decode_line_full): Remove cleanups.
16862         (decode_line_1): Update.
16863
16864 2019-01-02  Tom Tromey  <tom@tromey.com>
16865
16866         * python/python-internal.h (inferior_to_inferior_object): Change
16867         return type.
16868         * python/py-exitedevent.c (create_exited_event_object): Update.
16869         * python/py-inferior.c (inferior_to_inferior_object): Return
16870         gdbpy_ref.
16871         (python_new_inferior, python_inferior_deleted)
16872         (thread_to_thread_object, delete_thread_object)
16873         (build_inferior_list, gdbpy_selected_inferior): Update.
16874         * python/py-infthread.c (create_thread_object): Update.  Also fail
16875         if inferior_to_inferior_object fails.
16876
16877 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16878
16879         * inferior.h (class inferior) <displaced_step_state>: New field.
16880         * infrun.h (struct displaced_step_state): Move here from
16881         infrun.c.  Initialize fields, add constructor.
16882         <inf>: Remove field.
16883         <reset>: New method.
16884         * infrun.c (struct displaced_step_inferior_state): Move to
16885         infrun.h.
16886         (displaced_step_inferior_states): Remove.
16887         (get_displaced_stepping_state): Adust.
16888         (displaced_step_in_progress_any_inferior): Adjust.
16889         (displaced_step_in_progress_thread): Adjust.
16890         (displaced_step_in_progress): Adjust.
16891         (add_displaced_stepping_state): Remove.
16892         (get_displaced_step_closure_by_addr): Adjust.
16893         (remove_displaced_stepping_state): Remove.
16894         (infrun_inferior_exit): Call displaced_step_state.reset.
16895         (use_displaced_stepping): Don't check for NULL.
16896         (displaced_step_prepare_throw): Call
16897         get_displaced_stepping_state.
16898         (displaced_step_fixup): Don't check for NULL.
16899         (prepare_for_detach): Don't check for NULL.
16900
16901 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16902
16903         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16904          in case of call that did not complete.
16905
16906 2019-01-02  Andrey Utkin  <autkin@undo.io>
16907
16908         * symfile.c (find_separate_debug_file): Fix search of debug files for
16909         remote debuggee.
16910
16911 2019-01-02  Tom Tromey  <tom@tromey.com>
16912
16913         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16914         indentation.
16915         * python/py-frame.c (frapy_older): Remove cast.
16916         (frapy_newer): Likewise.
16917         * python/py-breakpoint.c (local_setattro): Remove cast.
16918         * python/py-arch.c (archpy_name): Remove local variable.
16919         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16920
16921 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16922
16923         * unittests/basic_string_view/element_access/char/empty.cc:
16924         Fix year range in copyright header.
16925
16926 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16927
16928         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16929         Delete.
16930         <operator==>: Update with for removed field.
16931         <hash>: Likewise.
16932         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16933         <isa_features>: ...this.
16934         <abi_features>: New field.
16935         (riscv_isa_flen): Update comment.
16936         (riscv_abi_xlen): New declaration.
16937         (riscv_abi_flen): New declaration.
16938         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16939         isa_features.
16940         (riscv_abi_xlen): New function.
16941         (riscv_isa_flen): Update to get answer from isa_features.
16942         (riscv_abi_flen): New function.
16943         (riscv_has_fp_abi): Update to get answer from abi_features.
16944         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16945         xlen and flen.
16946         (riscv_call_info) <xlen, flen>: Update comment.
16947         (riscv_call_arg_struct): Remove invalid assertions
16948         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16949         is removed.
16950         (riscv_gdbarch_init): Gather isa features and abi features
16951         separately, ensure both match on the gdbarch when reusing an old
16952         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16953         a target with 64-bit float hardware.
16954
16955 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16956
16957         * source.c (search_command_helper): Stop reverse search
16958         when line 1 has been searched.
16959
16960 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16961
16962         * record-full.c (record_full_base_target::close): Rewrite
16963         record_full_core_buf_list free logic.
16964
16965 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16966
16967         * break-catch-syscall.c (print_one_catch_syscall): xfree
16968         the last text.
16969
16970 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16971
16972         * top.c (print_gdb_version): Update Copyright year in version
16973         message.
16974
16975 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16976
16977         Update copyright year range in all GDB files.
16978
16979 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16980
16981         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16982
16983 For older changes see ChangeLog-2018.
16984 \f
16985 Local Variables:
16986 mode: change-log
16987 left-margin: 8
16988 fill-column: 74
16989 version-control: never
16990 coding: utf-8
16991 End:
16992