gdb/ChangeLog

   1 2020-02-08  Tom Tromey  <tom@tromey.com>
   2
   3         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
   4         Rewrite.
   5         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
   6         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
   7         (abbrev_table::abbrev_table): No longer inline.
   8         (ABBREV_HASH_SIZE): Remove.
   9         (abbrev_table::m_abbrevs): Now an htab_up.
  10
  11 2020-02-08  Tom Tromey  <tom@tromey.com>
  12
  13         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
  14         (cutu_reader): Update.
  15         (build_type_psymtabs_1): Update.
  16         * dwarf2/abbrev.c (abbrev_table::read): Rename.
  17         (abbrev_table::alloc_abbrev): Update.
  18         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
  19         (abbrev_table::read): New static method, renamed from
  20         abbrev_table_read_table.
  21         (abbrev_table::alloc_abbrev)
  22         (abbrev_table::add_abbrev): Now private.
  23         (abbrev_table::abbrev_table): Now private.
  24         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
  25
  26 2020-02-08  Tom Tromey  <tom@tromey.com>
  27
  28         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
  29         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
  30         htab_up.
  31
  32 2020-02-08  Tom Tromey  <tom@tromey.com>
  33
  34         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
  35         htab_up.
  36         (lookup_dwo_unit_in_dwp): Update.
  37         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
  38         on obstack.
  39
  40 2020-02-08  Tom Tromey  <tom@tromey.com>
  41
  42         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
  43         obstack.
  44
  45 2020-02-08  Tom Tromey  <tom@tromey.com>
  46
  47         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
  48         line_header_hash.
  49         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
  50         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
  51         Change type to htab_up.
  52
  53 2020-02-08  Tom Tromey  <tom@tromey.com>
  54
  55         * dwarf2/read.c (allocate_type_unit_groups_table): Return
  56         htab_up.  Don't allocate on obstack.
  57         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
  58         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
  59         Change type to htab_up.
  60
  61 2020-02-08  Tom Tromey  <tom@tromey.com>
  62
  63         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
  64         Change type to htab_up.
  65         * dwarf2/read.c (create_signatured_type_table_from_index)
  66         (create_signatured_type_table_from_debug_names)
  67         (create_all_type_units, add_type_unit)
  68         (lookup_dwo_signatured_type, lookup_signatured_type)
  69         (process_skeletonless_type_unit): Update.
  70         (create_debug_type_hash_table, create_debug_types_hash_table):
  71         Change type of types_htab.
  72         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
  73         htab_up.  Don't allocate on obstack.
  74         (create_cus_hash_table): Change type of cus_htab parameter.
  75         (struct dwo_file) <cus, tus>: Now htab_up.
  76         (lookup_dwo_signatured_type, lookup_dwo_cutu)
  77         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
  78         (queue_and_load_all_dwo_tus): Update.
  79         * dwarf2/index-write.c (write_gdbindex): Update.
  80         (write_debug_names): Update.
  81
  82 2020-02-08  Tom Tromey  <tom@tromey.com>
  83
  84         * dwarf2/read.h (struct dwarf2_queue_item): Move from
  85         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
  86         destructor.
  87         (struct dwarf2_per_objfile) <queue>: New member.
  88         * dwarf2/read.c (struct dwarf2_queue_item): Move to
  89         dwarf2/read.h.
  90         (dwarf2_queue, dwarf2_queue_tail): Remove.
  91         (class dwarf2_queue_guard): Add parameter to constructor.  Use
  92         DISABLE_COPY_AND_ASSIGN.
  93         <m_per_objfile>: New member.
  94         <~dwarf2_queue_guard>: Rewrite.
  95         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
  96         Update.
  97         (~dwarf2_queue_item): New.
  98
  99 2020-02-08  Tom Tromey  <tom@tromey.com>
 100
 101         * dwarf2/read.c (struct die_info) <has_children>: New member.
 102         (dw2_get_file_names_reader): Remove has_children.
 103         (dw2_get_file_names): Update.
 104         (read_cutu_die_from_dwo): Remove has_children.
 105         (cutu_reader::init_tu_and_read_dwo_dies)
 106         (cutu_reader::cutu_reader): Update.
 107         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
 108         Remove has_children.
 109         (build_type_psymtabs_1, process_skeletonless_type_unit)
 110         (load_partial_comp_unit, load_full_comp_unit): Update.
 111         (create_dwo_cu_reader): Remove has_children.
 112         (create_cus_hash_table, read_die_and_children): Update.
 113         (read_full_die_1,read_full_die): Remove has_children.
 114         (read_signatured_type): Update.
 115         (class cutu_reader) <has_children>: Remove.
 116
 117 2020-02-08  Tom Tromey  <tom@tromey.com>
 118
 119         * dwarf2/expr.c: Rename from dwarf2expr.c.
 120         * dwarf2/expr.h: Rename from dwarf2expr.h.
 121         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
 122         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
 123         * dwarf2/frame.c: Rename from dwarf2-frame.c.
 124         * dwarf2/frame.h: Rename from dwarf2-frame.h.
 125         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
 126         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
 127         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
 128         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
 129         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
 130         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
 131         * dwarf2/loc.c: Rename from dwarf2loc.c.
 132         * dwarf2/loc.h: Rename from dwarf2loc.h.
 133         * dwarf2/read.c: Rename from dwarf2read.c.
 134         * dwarf2/read.h: Rename from dwarf2read.h.
 135         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
 136         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
 137         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
 138         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
 139         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
 140         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
 141         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
 142         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
 143         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
 144         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
 145         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
 146         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
 147         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
 148         Update.
 149         * Makefile.in (COMMON_SFILES): Update.
 150         (HFILES_NO_SRCDIR): Update.
 151
 152 2020-02-08  Tom Tromey  <tom@tromey.com>
 153
 154         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
 155         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
 156
 157 2020-02-08  Tom Tromey  <tom@tromey.com>
 158
 159         * dwarf2read.h (struct die_info): Don't declare.
 160
 161 2020-02-08  Tom Tromey  <tom@tromey.com>
 162
 163         * dwarf2read.h (die_info_ptr): Remove typedef.
 164
 165 2020-02-08  Tom Tromey  <tom@tromey.com>
 166
 167         * dwarf2read.c (read_call_site_scope)
 168         (handle_data_member_location, dwarf2_add_member_fn)
 169         (mark_common_block_symbol_computed, read_common_block)
 170         (attr_to_dynamic_prop, partial_die_info::read)
 171         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
 172         (dwarf2_symbol_mark_computed, set_die_type): Update.
 173         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
 174         method.
 175         (attr_form_is_block): Don't declare.
 176         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
 177
 178 2020-02-08  Tom Tromey  <tom@tromey.com>
 179
 180         * dwarf2read.c (dwarf2_find_base_address, )
 181         (read_call_site_scope, rust_containing_type)
 182         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
 183         (handle_data_member_location, dwarf2_add_member_fn)
 184         (get_alignment, read_structure_type, process_structure_scope)
 185         (mark_common_block_symbol_computed, read_common_block)
 186         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
 187         (partial_die_info::read, read_attribute_value, new_symbol)
 188         (lookup_die_type, dwarf2_get_ref_die_offset)
 189         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
 190         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
 191         (dwarf2_symbol_mark_computed): Update.
 192         * dwarf2/attribute.h (struct attribute) <value_as_address,
 193         form_is_section_offset, form_is_constant, form_is_ref>: Declare
 194         methods.
 195         (value_as_address, attr_form_is_section_offset)
 196         (attr_form_is_constant, attr_form_is_ref): Don't declare.
 197         * dwarf2/attribute.c (attribute::value_as_address)
 198         (attribute::form_is_section_offset, attribute::form_is_constant)
 199         (attribute::form_is_ref): Now methods.
 200
 201 2020-02-08  Tom Tromey  <tom@tromey.com>
 202
 203         * dwarf2read.c (struct attribute, DW_STRING)
 204         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
 205         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
 206         (attr_form_is_block, attr_form_is_section_offset)
 207         (attr_form_is_constant, attr_form_is_ref): Move.
 208         * dwarf2/attribute.h: New file.
 209         * dwarf2/attribute.c: New file, from dwarf2read.c.
 210         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
 211
 212 2020-02-08  Tom Tromey  <tom@tromey.com>
 213
 214         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
 215         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
 216         Move.
 217         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
 218         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
 219         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
 220         abbrev.c.
 221         * dwarf2/abbrev.h: New file.
 222         * dwarf2/abbrev.c: New file, from dwarf2read.c.
 223         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
 224
 225 2020-02-08  Tom Tromey  <tom@tromey.com>
 226
 227         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
 228         (dwarf2_section_size, dwarf2_get_section_info)
 229         (create_signatured_type_table_from_debug_names)
 230         (create_addrmap_from_aranges, read_debug_names_from_section)
 231         (get_gdb_index_contents_from_section, read_comp_unit_head)
 232         (error_check_comp_unit_head, read_abbrev_offset)
 233         (create_debug_type_hash_table, init_cu_die_reader)
 234         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
 235         (read_comp_units_from_section, create_cus_hash_table)
 236         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
 237         (create_dwp_v2_section, dwarf2_rnglists_process)
 238         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
 239         (abbrev_table_read_table, read_indirect_string_at_offset_from)
 240         (read_indirect_string_from_dwz, read_addr_index_1)
 241         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
 242         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 243         (fill_in_loclist_baton): Update.
 244         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
 245         get_containing_section, get_bfd_owner, get_bfd_section,
 246         get_file_name, get_id, get_flags, empty, read>: Declare methods.
 247         (dwarf2_read_section, get_section_name, get_section_file_name)
 248         (get_containing_section, get_section_bfd_owner)
 249         (get_section_bfd_section, get_section_name, get_section_file_name)
 250         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
 251         declare.
 252         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
 253         (dwarf2_section_info::get_bfd_owner)
 254         (dwarf2_section_info::get_bfd_section)
 255         (dwarf2_section_info::get_name)
 256         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
 257         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
 258         (dwarf2_section_info::read): Now methods.
 259         * dwarf-index-write.c (class debug_names): Update.
 260
 261 2020-02-08  Tom Tromey  <tom@tromey.com>
 262
 263         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
 264         Move to dwarf2/section.h.
 265         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
 266         (get_section_bfd_section, get_section_name)
 267         (get_section_file_name, get_section_id, get_section_flags)
 268         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
 269         dwarf2/section.c.
 270         * dwarf2/section.h: New file.
 271         * dwarf2/section.c: New file, from dwarf2read.c.
 272         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
 273
 274 2020-02-08  Tom Tromey  <tom@tromey.com>
 275
 276         * dwarf2read.h (read_unsigned_leb128): Don't declare.
 277         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
 278         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
 279         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
 280         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
 281         * dwarf2/leb.h: New file, from dwarf2read.c.
 282         * dwarf2/leb.c: New file, from dwarf2read.c.
 283         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
 284         Remove.
 285         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
 286         (COMMON_SFILES): Add dwarf2/leb.c.
 287
 288 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
 289
 290         GDB 9.1 released.
 291
 292 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
 293
 294         PR gdb/25190:
 295         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
 296         * gdb/remote.c (remote_console_output): Update.
 297         * gdb/ui-file.c (fputs_unfiltered): Rename to...
 298         (ui_file_puts): ...this.
 299         * gdb/ui-file.h (ui_file_puts): Add declaration.
 300         * gdb/utils.c (emit_style_escape): Update.
 301         (flush_wrap_buffer): Update.
 302         (fputs_maybe_filtered): Update.
 303         (fputs_unfiltered): Add function.
 304
 305 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
 306
 307         * gdb/event-loop.c (gdb_wait_for_event): Update.
 308         * gdb/printcmd.c (printf_command): Update.
 309         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
 310         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
 311         (gdb_os_flush_stderr): Update.
 312         * gdb/remote.c (remote_console_output): Update.
 313         * gdb/ui-file.c (gdb_flush): Rename to...
 314         (ui_file_flush): ...this.
 315         (stderr_file::write): Update.
 316         (stderr_file::puts): Update.
 317         * gdb/ui-file.h (gdb_flush): Rename to...
 318         (ui_file_flush): ...this.
 319         * gdb/utils.c (gdb_flush): Add function.
 320         * gdb/utils.h (gdb_flush): Add declaration.
 321
 322 2020-02-07  Tom Tromey  <tromey@adacore.com>
 323
 324         PR breakpoints/24915:
 325         * source.c (find_and_open_source): Do not check basenames_may_differ.
 326
 327 2020-02-07  Tom Tromey  <tom@tromey.com>
 328
 329         * README: Update gdbserver documentation.
 330         * gdbserver: Move to top level.
 331         * configure.tgt (build_gdbserver): Remove.
 332         * configure.ac: Remove --enable-gdbserver.
 333         * configure: Rebuild.
 334         * Makefile.in (distclean): Don't mention gdbserver.
 335
 336 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
 337
 338         * source-cache.c (source_cache::ensure): Surround
 339         get_plain_source_lines with a try/catch.
 340         (source_cache::get_line_charpos): Get rid of try/catch
 341         and only check for the return value of "ensure".
 342         * tui/tui-source.c (tui_source_window::set_contents):
 343         Simplify "nlines" calculation.
 344
 345 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
 346
 347         * MAINTAINERS (Write After Approval): Add myself.
 348
 349 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
 350
 351         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
 352         function call.
 353
 354 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
 355
 356         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
 357
 358 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
 359
 360         * nat/riscv-linux-tdesc.h: New file.
 361         * nat/riscv-linux-tdesc.c: New file, taking code from...
 362         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 363         ... here.
 364         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
 365         NATDEPFILES.
 366
 367 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
 370         we don't set the fake simulator ptid to the null_ptid.
 371
 372 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
 373
 374         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
 375         * gdbthread.h (class thread_info) <resumed>: Likewise.
 376         * infrun.c (resume_1): Likewise.
 377         (proceed): Likewise.
 378         (infrun_thread_stop_requested): Likewise.
 379         (stop_all_threads): Likewise.
 380         (handle_inferior_event): Likewise.
 381         (restart_threads): Likewise.
 382         (finish_step_over): Likewise.
 383         (keep_going_stepped_thread): Likewise.
 384         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
 385         (linux_handle_extended_wait): Likewise.
 386         * record-btrace.c (get_thread_current_frame_id): Likewise.
 387         * record-full.c (record_full_wait_1): Likewise.
 388         * remote.c (remote_target::process_initial_stop_replies): Likewise.
 389         * target.c (target_resume): Likewise.
 390         * thread.c (set_running_thread): Likewise.
 391
 392 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 393
 394         * f-valprint.c (f77_print_array_1): Changed datatype of index
 395         variable to LONGEST from int to enable it to contain bound
 396         values correctly.
 397
 398 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
 399
 400         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
 401         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
 402         offsets according to FLEN determined.
 403         (riscv_linux_nat_target::read_description): Determine FLEN
 404         dynamically.
 405         (riscv_linux_nat_target::fetch_registers): Size regset buffer
 406         according to FLEN determined.
 407         (riscv_linux_nat_target::store_registers): Likewise.
 408
 409 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 410
 411         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 412         when reg->group is empty and reggroup is not.
 413
 414 2020-01-31  Tom Tromey  <tromey@adacore.com>
 415
 416         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
 417         Call beneath target's mourn_inferior after unpushing.
 418
 419 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         PR tui/9765
 422         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
 423         have enough lines to fill the screen, still return the lowest
 424         address we found.
 425
 426 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
 429         '-', '<', and '>' commands.
 430
 431 2020-01-29  Pedro Alves  <palves@redhat.com>
 432             Sergio Durigan Junior  <sergiodj@redhat.com>
 433
 434         * infcmd.c (construct_inferior_arguments): Assert that
 435         'argc' is greater than 0.
 436
 437 2020-01-29  Luis Machado  <luis.machado@linaro.org>
 438
 439         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
 440         (BRK_INSN_MASK): Define to 0xd4200000.
 441         (aarch64_program_breakpoint_here_p): New function.
 442         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
 443         * arch-utils.c (default_program_breakpoint_here_p): Moved from
 444         breakpoint.c.
 445         * arch-utils.h (default_program_breakpoint_here_p): Moved from
 446         breakpoint.h
 447         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
 448         call gdbarch_program_breakpoint_here_p.
 449         (program_breakpoint_here): Moved to arch-utils.c, renamed to
 450         default_program_breakpoint_here_p, changed return type to bool and
 451         simplified.
 452         * breakpoint.h (program_breakpoint_here): Moved prototype to
 453         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
 454         return type to bool.
 455         * gdbarch.c: Regenerate.
 456         * gdbarch.h: Regenerate.
 457         * gdbarch.sh (program_breakpoint_here_p): New method.
 458         * infrun.c (handle_signal_stop): Call
 459         gdbarch_program_breakpoint_here_p.
 460
 461 2020-01-26  Tom Tromey  <tom@tromey.com>
 462
 463         * ctfread.c (struct ctf_fp_info): Reindent.
 464         (_initialize_ctfread): Remove.
 465
 466 2020-01-26  Tom Tromey  <tom@tromey.com>
 467
 468         * psymtab.c (partial_map_expand_apply)
 469         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
 470         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
 471         (psym_print_stats, psym_expand_symtabs_for_function)
 472         (psym_map_symbol_filenames, psym_map_matching_symbols)
 473         (psym_expand_symtabs_matching)
 474         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
 475         (maintenance_check_psymtabs): Use new methods.
 476         * psympriv.h (struct partial_symtab) <readin_p,
 477         get_compunit_symtab>: New methods.
 478         <readin, compunit_symtab>: Remove members.
 479         (struct standard_psymtab): New.
 480         (struct legacy_psymtab): Derive from standard_psymtab.
 481         * dwarf2read.h (struct dwarf2_psymtab): Derive from
 482         standard_psymtab.
 483         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
 484
 485 2020-01-26  Tom Tromey  <tom@tromey.com>
 486
 487         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
 488         read_dependencies.  Add assert.
 489         * psymtab.c (partial_symtab::read_dependencies): New method.
 490         * psympriv.h (struct partial_symtab) <read_dependencies>: New
 491         method.
 492         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
 493         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
 494         read_dependencies.
 495         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
 496         Add assert.
 497
 498 2020-01-26  Tom Tromey  <tom@tromey.com>
 499
 500         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
 501         Call expand_psymtab.
 502         (xcoff_read_symtab): Call expand_psymtab.
 503         (xcoff_start_psymtab, xcoff_end_psymtab): Set
 504         legacy_expand_psymtab.
 505         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
 506         method.
 507         (struct legacy_psymtab) <expand_psymtab>: Implement.
 508         <legacy_expand_psymtab>: New member.
 509         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
 510         (parse_partial_symbols): Set legacy_expand_psymtab.
 511         (psymtab_to_symtab_1): Change argument order.  Call
 512         expand_psymtab.
 513         (new_psymtab): Set legacy_expand_psymtab.
 514         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
 515         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
 516         expand_psymtab.
 517         (dwarf2_psymtab::expand_psymtab): Rename from
 518         psymtab_to_symtab_1.  Call expand_psymtab.
 519         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
 520         (dbx_end_psymtab): Likewise.
 521         (dbx_psymtab_to_symtab_1): Change argument order. Call
 522         expand_psymtab.
 523         (dbx_read_symtab): Call expand_psymtab.
 524         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
 525         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
 526         (ctf_psymtab::read_symtab): Call expand_psymtab.
 527
 528 2020-01-26  Tom Tromey  <tom@tromey.com>
 529
 530         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
 531         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
 532         messages.
 533         * mdebugread.c (mdebug_read_symtab): Remove prints.
 534         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
 535         assert.
 536         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
 537
 538 2020-01-26  Tom Tromey  <tom@tromey.com>
 539
 540         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
 541         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
 542         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
 543         legacy_symtab.
 544         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
 545         * psymtab.c (psymtab_to_symtab): Call method.
 546         (dump_psymtab): Update.
 547         * psympriv.h (struct partial_symtab): Add virtual destructor.
 548         <read_symtab>: New method.
 549         (struct legacy_symtab): New.
 550         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
 551         (struct pst_map) <pst>: Now a legacy_psymtab.
 552         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
 553         (new_psymtab): Use legacy_psymtab.
 554         * dwarf2read.h (struct dwarf2_psymtab): New.
 555         (struct dwarf2_per_cu_data) <psymtab>: Use it.
 556         * dwarf2read.c (dwarf2_create_include_psymtab)
 557         (dwarf2_build_include_psymtabs, create_type_unit_group)
 558         (create_partial_symtab, process_psymtab_comp_unit_reader)
 559         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
 560         (set_partial_user): Use dwarf2_psymtab.
 561         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
 562         (psymtab_to_symtab_1, process_full_comp_unit)
 563         (process_full_type_unit, dwarf2_ranges_read)
 564         (dwarf2_get_pc_bounds, psymtab_include_file_name)
 565         (dwarf_decode_lines): Use dwarf2_psymtab.
 566         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
 567         (add_address_entry_worker, write_one_signatured_type)
 568         (recursively_count_psymbols, recursively_write_psymbols)
 569         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
 570         (write_debug_names): Likewise.
 571         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
 572         <pst>: Now a legacy_psymtab.
 573         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
 574         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
 575         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
 576         * ctfread.c (struct ctf_psymtab): New.
 577         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
 578         ctf_psymtab.
 579         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
 580         (create_partial_symtab): Return a ctf_psymtab.
 581         (scan_partial_symbols): Update.
 582
 583 2020-01-26  Tom Tromey  <tom@tromey.com>
 584
 585         * xcoffread.c (xcoff_start_psymtab): Use new.
 586         * psymtab.c (partial_symtab::partial_symtab): New constructor,
 587         renamed from start_psymtab_common.
 588         * psympriv.h (struct partial_symtab): Add new constructor.
 589         (start_psymtab_common): Don't declare.
 590         * mdebugread.c (parse_partial_symbols): Use new.
 591         * dwarf2read.c (create_partial_symtab): Use new.
 592         * dbxread.c (start_psymtab): Use new.
 593         * ctfread.c (create_partial_symtab): Use new.
 594
 595 2020-01-26  Tom Tromey  <tom@tromey.com>
 596
 597         * xcoffread.c (xcoff_end_psymtab): Use new.
 598         * psymtab.c (start_psymtab_common): Use new.
 599         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
 600         Update.
 601         * psympriv.h (struct partial_symtab): Add parameters to
 602         constructor.  Don't inline.
 603         (allocate_psymtab): Don't declare.
 604         * mdebugread.c (new_psymtab): Use new.
 605         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
 606         * dbxread.c (dbx_end_psymtab): Use new.
 607
 608 2020-01-26  Tom Tromey  <tom@tromey.com>
 609
 610         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
 611         allocate_psymtab.  Update documentation.
 612         * psymtab.c (psymtab_storage::install_psymtab): Rename from
 613         allocate_psymtab.  Do not use new.
 614         (allocate_psymtab): Use new.  Update.
 615
 616 2020-01-26  Tom Tromey  <tom@tromey.com>
 617
 618         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
 619         * psymtab.c (psym_print_stats): Update.
 620         * psympriv.h (struct partial_symtab) <readin,
 621         psymtabs_addrmap_supported, anonymous>: Now bool.
 622         * mdebugread.c (psymtab_to_symtab_1): Update.
 623         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
 624         (build_type_psymtabs_reader, psymtab_to_symtab_1)
 625         (process_full_comp_unit, process_full_type_unit): Update.
 626         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
 627         * ctfread.c (psymtab_to_symtab): Update.
 628
 629 2020-01-26  Tom Tromey  <tom@tromey.com>
 630
 631         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
 632         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
 633         * psymtab.c (psymtab_storage): Delete psymtabs.
 634         (psymtab_storage::allocate_psymtab): Use new.
 635         (psymtab_storage::discard_psymtab): Use delete.
 636         * psympriv.h (struct partial_symtab): Add constructor and
 637         initializers.
 638
 639 2020-01-26  Tom Tromey  <tom@tromey.com>
 640
 641         * machoread.c: Do not include psympriv.h.
 642
 643 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 644
 645         * NEWS: Mention the new option and the set/show commands.
 646
 647 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 648
 649         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
 650         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
 651         (validate_exec_file): New variables, enums, functions.
 652         (exec_file_locate_attach, print_section_info): Style the filenames.
 653         (_initialize_exec): Install show_exec_file_mismatch_command and
 654          set_exec_file_mismatch_command.
 655         * gdbcore.h (validate_exec_file): Declare.
 656         * infcmd.c (attach_command): Call validate_exec_file.
 657         * remote.c ( remote_target::remote_add_inferior): Likewise.
 658
 659 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         * frame.c (find_frame_sal): Move call to get_next_frame into more
 662         inner scope.
 663         * inline-frame.c (inilne_state) <inline_state>: Update argument
 664         types.
 665         (inilne_state) <skipped_symbol>: Rename to...
 666         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
 667         (skip_inline_frames): Build vector of skipped symbols and use this
 668         to reate the inline_state.
 669         (inline_skipped_symbol): Add a comment and some assertions, fetch
 670         skipped symbol from the list.
 671
 672 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * buildsym.c (lte_is_less_than): Delete.
 675         (buildsym_compunit::end_symtab_with_blockvector): Create local
 676         lambda function to sort line table entries, and use
 677         std::stable_sort instead of std::sort.
 678         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
 679         markers when looking for a previous line.
 680
 681 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 682
 683         * dwarf2read.c (lnp_state_machine::record_line): Include
 684         end_sequence parameter in debug print out.  Record the line if we
 685         are at an end_sequence marker even if it's not the start of a
 686         statement.
 687         * symmisc.c (maintenance_print_one_line_table): Print end of
 688         sequence markers with 'END' not '0'.
 689
 690 2020-01-24  Pedro Alves  <palves@redhat.com>
 691
 692         PR gdb/25410
 693         * thread.c (scoped_restore_current_thread::restore): Use
 694         switch_to_inferior_no_thread.
 695         * exec.c: Include "progspace-and-thread.h".
 696         (add_target_sections, remove_target_sections):
 697         scoped_restore_current_pspace_and_thread instead of
 698         scoped_restore_current_thread.
 699         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
 700         and aspace to the inferior before calling clone_program_space.
 701         Remove stale comment.
 702
 703 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
 706         (arm_netbsd_nat_target::fetch_registers): ...this.
 707         (arm_nbsd_nat_target::store_registers): Rename to...
 708         (arm_netbsd_nat_target::store_registers): ...this.
 709
 710 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
 711
 712         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
 713         register_t.
 714
 715 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
 716
 717         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
 718         Update comment.
 719         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
 720         Likewise.
 721         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
 722         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
 723         the correct replacement (iterate_over_regset_sections).
 724         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
 725         Update comment.
 726
 727 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
 728
 729         PR gdb/23718
 730         * gdb/python/python.c (execute_gdb_command): Call
 731         async_enable_stdin in catch block.
 732
 733 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
 736         SWITCH_THRU_ALL_UIS.
 737
 738 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         PR tui/9765
 741         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
 742         comment, add extra parameter, and update to store previous symbol
 743         when appropriate.
 744         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
 745         add extra parameter.
 746         * tui/tui-disasm.c (tui_disassemble): Update header comment,
 747         remove unneeded parameter, add try/catch around gdb_print_insn,
 748         rewrite to add items to asm_lines vector.
 749         (tui_find_backward_disassembly_start_address): New function.
 750         (tui_find_disassembly_address): Updated throughout.
 751         (tui_disasm_window::set_contents): Update for changes to
 752         tui_disassemble.
 753         (tui_disasm_window::do_scroll_vertical): No need to adjust the
 754         number of lines to scroll.
 755
 756 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
 757
 758         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
 759         (SECT_OFF_DATA): Likewise.
 760         (SECT_OFF_RODATA): Likewise.
 761         (SECT_OFF_TEXT): Likewise.
 762         (SECT_OFF_BSS): Likewise.
 763         (struct objfile) <text_section_offset, data_section_offset>: New
 764         methods.
 765         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
 766         objfile::text_section_offset.
 767         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
 768         * coffread.c (coff_symtab_read): Likewise.
 769         (enter_linenos): Likewise.
 770         (process_coff_symbol): Likewise.
 771         * ctfread.c (get_objfile_text_range): Likewise.
 772         * dtrace-probe.c (dtrace_probe::get_relocated_address):
 773         Use objfile::data_section_offset.
 774         * dwarf2-frame.c (execute_cfa_program): Use
 775         objfile::text_section_offset.
 776         (dwarf2_frame_find_fde): Likewise.
 777         * dwarf2read.c (create_addrmap_from_index): Likewise.
 778         (create_addrmap_from_aranges): Likewise.
 779         (dw2_find_pc_sect_compunit_symtab): Likewise.
 780         (process_psymtab_comp_unit_reader): Likewise.
 781         (add_partial_symbol): Likewise.
 782         (add_partial_subprogram): Likewise.
 783         (process_full_comp_unit): Likewise.
 784         (read_file_scope): Likewise.
 785         (read_func_scope): Likewise.
 786         (read_lexical_block_scope): Likewise.
 787         (read_call_site_scope): Likewise.
 788         (dwarf2_rnglists_process): Likewise.
 789         (dwarf2_ranges_process): Likewise.
 790         (dwarf2_ranges_read): Likewise.
 791         (dwarf_decode_lines_1): Likewise.
 792         (new_symbol): Likewise.
 793         (dwarf2_fetch_die_loc_sect_off): Likewise.
 794         (dwarf2_per_cu_text_offset): Likewise.
 795         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
 796         * hppa-tdep.c (read_unwind_info): Likewise.
 797         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
 798         * psympriv.h (struct partial_symtab): Likewise.
 799         * psymtab.c (find_pc_sect_psymtab): Likewise.
 800         * solib-svr4.c (enable_break): Likewise.
 801         * stap-probe.c (relocate_address): Use
 802         objfile::data_section_offset.
 803         * xcoffread.c (enter_line_range): Use
 804         objfile::text_section_offset.
 805         (read_xcoff_symtab): Likewise.
 806
 807 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
 808
 809         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
 810         declaration to narrower scopes.
 811
 812 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
 813
 814         * darwin-nat.h (struct darwin_exception_msg, enum
 815         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
 816         Move up.
 817         (class darwin_nat_target) <wait_1, check_new_threads,
 818         decode_exception_message, decode_message, stop_inferior,
 819         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
 820         * darwin-nat.c (darwin_check_new_threads): Rename to...
 821         (darwin_nat_target::check_new_threads): ... this.
 822         (darwin_suspend_inferior_it): Remove.
 823         (darwin_decode_exception_message): Rename to...
 824         (darwin_nat_target::decode_exception_message): ... this.
 825         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
 826         (darwin_decode_message): Rename to...
 827         (darwin_nat_target::decode_message): ... this.
 828         (cancel_breakpoint): Rename to...
 829         (darwin_nat_target::cancel_breakpoint): ... this.
 830         (darwin_wait): Rename to...
 831         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
 832         instead of iterate_over_inferiors.
 833         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
 834         (darwin_stop_inferior): Rename to...
 835         (darwin_nat_target::stop_inferior): ... this.
 836         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
 837         (darwin_init_thread_list): Rename to...
 838         (darwin_nat_target::init_thread_list): ... this.
 839         (darwin_ptrace_him): Rename to...
 840         (darwin_nat_target::ptrace_him): ... this.
 841         (darwin_nat_target::create_inferior): Pass lambda function to
 842         fork_inferior.
 843         (darwin_nat_target::detach): Call stop_inferior instead of
 844         darwin_stop_inferior.
 845         * fork-inferior.h (fork_inferior): Change init_trace_fun
 846         parameter to gdb::function_view.
 847         * fork-inferior.c (fork_inferior): Likewise.
 848
 849 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
 850
 851         * i386-cygwin-tdep.c (core_process_module_section): Update.
 852         * windows-nat.c (struct lm_info_windows): Add text_offset.
 853         (windows_xfer_shared_libraries): Update.
 854         * windows-tdep.c (windows_xfer_shared_library):
 855         Add text_offset_cached argument.
 856         * windows-tdep.h (windows_xfer_shared_library): Update.
 857
 858 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
 859
 860         * gdbarch.sh: Add declaration for _initialize_gdbarch.
 861
 862 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
 863
 864         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
 865         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
 866         replace with range-based for.
 867         (gdbsim_interrupt_inferior): Remove.
 868         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
 869         with a range-based for.  Inline code from
 870         gdbsim_interrupt_inferior.
 871
 872 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
 873
 874         * infrun.c (proceed): Fix indentation.
 875
 876 2020-01-21  Tom Tromey  <tromey@adacore.com>
 877
 878         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
 879         * python/python.c (python_extension_ops): Update.
 880         (gdbpy_colorize): New function.
 881         * python/lib/gdb/__init__.py (colorize): New function.
 882         * extension.h (ext_lang_colorize): Declare.
 883         * extension.c (ext_lang_colorize): New function.
 884         * extension-priv.h (struct extension_language_ops) <colorize>: New
 885         member.
 886         * cli/cli-style.c (_initialize_cli_style): Update help text.
 887
 888 2020-01-21  Luis Machado  <luis.machado@linaro.org>
 889
 890         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
 891         <cond>: Change type to bool.
 892         (aarch64_displaced_step_b_cond): Update cond to use bool type.
 893         (aarch64_displaced_step_cb): Likewise.
 894         (aarch64_displaced_step_tb): Likewise.
 895
 896 2020-01-21  Luis Machado  <luis.machado@linaro.org>
 897
 898         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
 899         output.
 900
 901 2020-01-21  Luis Machado  <luis.machado@linaro.org>
 902
 903         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
 904         <pc_adjust>: Adjust the documentation.
 905         (aarch64_displaced_step_fixup): Check if PC really moved before
 906         adjusting it.
 907
 908 2020-01-19  Tom Tromey  <tom@tromey.com>
 909
 910         * disasm.c (~gdb_disassembler): New destructor.
 911         (gdb_buffered_insn_length): Call disassemble_free_target.
 912         * disasm.h (class gdb_disassembler): Declare destructor.  Use
 913         DISABLE_COPY_AND_ASSIGN.
 914
 915 2020-01-19  Tom Tromey  <tom@tromey.com>
 916
 917         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
 918         (die_reader_func_ftype): Remove.
 919         (cutu_reader): New class.
 920         (dw2_get_file_names_reader): Remove "data" parameter.
 921         (dw2_get_file_names): Use cutu_reader.
 922         (create_debug_type_hash_table): Update.
 923         (read_cutu_die_from_dwo): Update comment.
 924         (lookup_dwo_unit): Add dwo_name parameter.
 925         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
 926         die_reader_func_ftype and data parameters.
 927         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
 928         Remove die_reader_func_ftype and data parameters.
 929         (~cutu_reader): New; from init_cutu_and_read_dies.
 930         (cutu_reader::cutu_reader): Rename from
 931         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
 932         and data parameters.
 933         (init_cutu_and_read_dies_simple): Remove.
 934         (struct process_psymtab_comp_unit_data): Remove.
 935         (process_psymtab_comp_unit_reader): Remove data parameter; add
 936         want_partial_unit and pretend_language parameters.
 937         (process_psymtab_comp_unit): Use cutu_reader.
 938         (build_type_psymtabs_reader): Remove data parameter.
 939         (build_type_psymtabs_1): Use cutu_reader.
 940         (process_skeletonless_type_unit): Likewise.
 941         (load_partial_comp_unit_reader): Remove.
 942         (load_partial_comp_unit): Use cutu_reader.
 943         (load_full_comp_unit_reader): Remove.
 944         (load_full_comp_unit): Use cutu_reader.
 945         (struct create_dwo_cu_data): Remove.
 946         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
 947         dwo_unit parameters.
 948         (create_cus_hash_table): Use cutu_reader.
 949         (struct dwarf2_read_addr_index_data): Remove.
 950         (dwarf2_read_addr_index_reader): Remove.
 951         (dwarf2_read_addr_index): Use cutu_reader.
 952         (read_signatured_type_reader): Remove.
 953         (read_signatured_type): Use cutu_reader.
 954
 955 2020-01-19  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
 958         * tui/tui-wingeneral.h (class tui_suppress_output): New.
 959         (tui_wrefresh): Declare.
 960         * tui/tui-wingeneral.c (suppress_output): New global.
 961         (tui_suppress_output, ~tui_suppress_output): New constructor and
 962         destructor.
 963         (tui_wrefresh): New function.
 964         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
 965         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
 966         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
 967         method.
 968         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
 969         tui_wrefresh.
 970         (tui_data_window::no_refresh): New method.
 971         (tui_data_item_window::refresh_window): Call tui_wrefresh.
 972         (tui_reg_command): Use tui_suppress_output
 973         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
 974         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
 975         method.
 976         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
 977
 978 2020-01-19  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 981         Handle case where symtab is null.
 982
 983 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
 984
 985         * linux-fork.c (one_fork_p): Simplify.
 986
 987 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
 988
 989         * top.c (struct qt_args): Remove.
 990         (kill_or_detach): Change return type to void, replace `void *`
 991         parameter with a proper one.
 992         (print_inferior_quit_action):  Likewise.
 993         (quit_confirm): Use range-based for loop to iterate over inferiors.
 994         (quit_force): Likewise.
 995
 996 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
 997
 998         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
 999         `void *` parameter with proper parameters.
1000         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
1001         (print_one_inferior): Change return type to void, replace `void *`
1002         parameter with proper parameters.
1003         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
1004         inferiors.
1005         (get_other_inferior): Remove.
1006         (mi_cmd_remove_inferior): Use range-based loop to iterate over
1007         inferiors.
1008
1009 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1010
1011         * mi/mi-interp.c (report_initial_inferior): Remove.
1012         (mi_interp::init): Use range-based for to iterate over inferiors.
1013
1014 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1015
1016         * python/py-inferior.c (build_inferior_list): Remove.
1017         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
1018
1019 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
1020
1021         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
1022         (btrace_stitch_trace): Likewise.
1023         * charset.c (intermediate_encoding): Likewise (vaild).
1024         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
1025         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
1026         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
1027
1028 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
1029
1030         * windows-tdep.c (windows_get_tlb_type):
1031         Add rtl_user_process_parameters type.
1032
1033 2020-01-16  Pedro Alves  <palves@redhat.com>
1034             Norbert Lange  <nolange79@gmail.com>
1035
1036         PR build/24805
1037         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
1038         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
1039         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
1040         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
1041         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
1042         (ps_plog): Redeclare exported functions with default visibility.
1043
1044 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
1045
1046         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
1047         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
1048
1049 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
1050
1051         * infcmd.c (post_create_inferior): Use get_thread_regcache
1052         instead of get_current_regcache.
1053
1054 2020-01-14  Tom Tromey  <tom@tromey.com>
1055
1056         PR symtab/12535:
1057         * python/python.c (gdbpy_decode_line): Treat empty string the same
1058         as no argument.
1059
1060 2020-01-14  Tom Tromey  <tom@tromey.com>
1061
1062         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
1063
1064 2020-01-14  Tom Tromey  <tom@tromey.com>
1065
1066         * nat/linux-btrace.c: Don't include <config.h>.
1067         * nat/linux-ptrace.c: Don't include <config.h>.
1068         * nat/x86-linux-dregs.c: Don't include <config.h>.
1069
1070 2020-01-14  Tom Tromey  <tom@tromey.com>
1071
1072         * configure: Rebuild.
1073         * configure.ac: Move many checks to ../gdbsupport/common.m4.
1074
1075 2020-01-14  Tom Tromey  <tom@tromey.com>
1076
1077         * nat/x86-linux-dregs.c: Include configh.h.
1078         * nat/linux-ptrace.c: Include configh.h.
1079         * nat/linux-btrace.c: Include configh.h.
1080         * defs.h: Include config.h, bfd.h.
1081         * configure.ac: Don't source common.host.
1082         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
1083         * configure: Rebuild.
1084         * acinclude.m4: Update path.
1085         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
1086         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
1087         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
1088         (CLIBS): Add LIBSUPPORT.
1089         (CDEPS): Likewise.
1090         (COMMON_SFILES): Remove gdbsupport files.
1091         (HFILES_NO_SRCDIR): Likewise.
1092         (stamp-version): Update path to create-version.sh.
1093         (ALLDEPFILES): Remove gdbsupport files.
1094
1095 2020-01-14  Tom Tromey  <tom@tromey.com>
1096
1097         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
1098         USE_WIN32API when needed.
1099         * configure.ac (USE_WIN32API): Don't define.
1100         (WIN32LIBS): Use WIN32APILIBS.
1101         * configure: Rebuild.
1102
1103 2020-01-14  Tom Tromey  <tom@tromey.com>
1104
1105         * configure: Rebuild.
1106         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
1107
1108 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1109
1110         * skip.c (skip_function_command): Make skip w/o arguments use the
1111         name of the inlined function if pc is inside any inlined function.
1112
1113 2020-01-14  Luis Machado  <luis.machado@linaro.org>
1114
1115         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
1116         * infrun.c (resume_1): Likewise.
1117         (handle_inferior_event): Remove stale comment.
1118         * linux-nat.c (linux_nat_target::resume): Update comments.
1119         (save_stop_reason): Likewise.
1120         (linux_nat_filter_event): Likewise.
1121         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
1122
1123 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * elfread.c (record_minimal_symbol): Set section index to 0 for
1126         non-allocatable sections.
1127
1128
1129 2020-01-13  Ali Tamur <tamur@google.com>
1130
1131         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
1132         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
1133         to gdb::optional.  Update comments.
1134         (dwo_file): Update comments.
1135         (read_attribute): Update API to take an additional out parameter,
1136         need_reprocess.  This is used to mark attributes that need other
1137         attributes (e.g. str_offsets_base) for correct computation which may not
1138         have been read yet.
1139         (read_attribute_reprocess): New function declaration.
1140         (read_addr_index): Likewise.
1141         (read_dwo_str_index): Likewise.
1142         (read_stub_str_index): Likewise.
1143         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
1144         (lookup_addr_base): New function definition.
1145         (lookup_ranges_base): Likewise.
1146         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
1147         lookup_ranges_base.
1148         (init_cutu_and_read_dies): Update comments.
1149         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
1150         unit.  This is used to inherit parent's str_offsets_base and addr_base.
1151         Update comments.
1152         (init_cutu_and_read_dies_simple): Reflect API changes.
1153         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
1154         (create_cus_hash_table): Change API to take parent compile unit.
1155         Reflect API changes.
1156         (open_and_init_dwo_file): Reflect API changes.
1157         (dwarf2_get_pc_bounds): Update comments.
1158         (dwarf2_record_block_ranges): Likewise.
1159         (read_full_die_1): Change implementation to reprocess attributes that
1160         need str_offsets_base and addr_base.
1161         (partial_die_info::read): Likewise.
1162         (read_attribute_reprocess): New function definition.
1163         (read_attribute_value): Change API to take an additional out parameter,
1164         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
1165         when a non-dwo compile unit has index based attributes.
1166         (read_attribute): Reflect API changes.
1167         (read_addr_index_1): Reflect API changes.  Update comments.
1168         (dwarf2_read_addr_index_data): Reflect API changes.
1169         (dwarf2_read_addr_index): Likewise.
1170         (read_str_index): Change API and implementation.  This becomes a helper
1171         to be used by the new string index related methods.  Update error
1172         message and comments.
1173         (read_dwo_str_index): New function definition.
1174         (read_stub_str_index): Likewise.
1175         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
1176         * symfile.h (dwarf2_debug_sections): Likewise.
1177         * xcoffread.c (dwarf2_debug_sections): Likewise.
1178
1179 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1180
1181         * gdbcore.h (struct core_fns) <core_read_registers>: Change
1182         core_reg_sect type to gdb_byte *.
1183         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
1184         * cris-tdep.c (fetch_core_registers): Likewise.
1185         * corelow.c (core_target::get_core_register_section): Change
1186         type of `contents` to gdb::byte_vector.
1187
1188 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * tui/tui-wingeneral.c (box_win): Position the title in the center
1191         of the border.
1192
1193 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
1194
1195         * corelow.c (core_target::get_core_register_section): Use
1196           std::vector instead of alloca.
1197
1198 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1199
1200         * warning.m4: Add -Wmissing-declarations to build_warnings.
1201         * configure: Re-generate.
1202
1203 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1204
1205         * python/python.c (init__gdb_module): Add declaration.
1206
1207 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1208
1209         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
1210         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
1211         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
1212         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
1213         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
1214         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
1215         * ada-exp.y (_initialize_ada_exp): Add declaration.
1216         * ada-lang.c (_initialize_ada_language): Add declaration.
1217         * ada-tasks.c (_initialize_tasks): Add declaration.
1218         * agent.c (_initialize_agent): Add declaration.
1219         * aix-thread.c (_initialize_aix_thread): Add declaration.
1220         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
1221         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
1222         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
1223         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
1224         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
1225         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
1226         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
1227         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
1228         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
1229         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
1230         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
1231         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
1232         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
1233         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
1234         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
1235         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
1236         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
1237         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
1238         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
1239         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
1240         * annotate.c (_initialize_annotate): Add declaration.
1241         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
1242         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
1243         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
1244         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
1245         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
1246         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
1247         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
1248         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
1249         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
1250         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
1251         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
1252         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
1253         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
1254         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
1255         * auto-load.c (_initialize_auto_load): Add declaration.
1256         * auxv.c (_initialize_auxv): Add declaration.
1257         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
1258         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
1259         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
1260         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
1261         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
1262         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
1263         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
1264         * breakpoint.c (_initialize_breakpoint): Add declaration.
1265         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
1266         * btrace.c (_initialize_btrace): Add declaration.
1267         * charset.c (_initialize_charset): Add declaration.
1268         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
1269         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
1270         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
1271         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
1272         * cli/cli-script.c (_initialize_cli_script): Add declaration.
1273         * cli/cli-style.c (_initialize_cli_style): Add declaration.
1274         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
1275         * coffread.c (_initialize_coffread): Add declaration.
1276         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
1277         * compile/compile.c (_initialize_compile): Add declaration.
1278         * complaints.c (_initialize_complaints): Add declaration.
1279         * completer.c (_initialize_completer): Add declaration.
1280         * copying.c (_initialize_copying): Add declaration.
1281         * corefile.c (_initialize_core): Add declaration.
1282         * corelow.c (_initialize_corelow): Add declaration.
1283         * cp-abi.c (_initialize_cp_abi): Add declaration.
1284         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
1285         * cp-support.c (_initialize_cp_support): Add declaration.
1286         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
1287         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
1288         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
1289         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
1290         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
1291         * ctfread.c (_initialize_ctfread): Add declaration.
1292         * d-lang.c (_initialize_d_language): Add declaration.
1293         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
1294         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
1295         * dbxread.c (_initialize_dbxread): Add declaration.
1296         * dcache.c (_initialize_dcache): Add declaration.
1297         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
1298         * disasm.c (_initialize_disasm): Add declaration.
1299         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
1300         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
1301         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
1302         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
1303         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
1304         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
1305         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
1306         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
1307         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
1308         * elfread.c (_initialize_elfread): Add declaration.
1309         * exec.c (_initialize_exec): Add declaration.
1310         * extension.c (_initialize_extension): Add declaration.
1311         * f-lang.c (_initialize_f_language): Add declaration.
1312         * f-valprint.c (_initialize_f_valprint): Add declaration.
1313         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
1314         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
1315         * filesystem.c (_initialize_filesystem): Add declaration.
1316         * findcmd.c (_initialize_mem_search): Add declaration.
1317         * findvar.c (_initialize_findvar): Add declaration.
1318         * fork-child.c (_initialize_fork_child): Add declaration.
1319         * frame-base.c (_initialize_frame_base): Add declaration.
1320         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
1321         * frame.c (_initialize_frame): Add declaration.
1322         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
1323         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
1324         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
1325         * gcore.c (_initialize_gcore): Add declaration.
1326         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
1327         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
1328         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
1329         * gdbarch.c (_initialize_gdbarch): Add declaration.
1330         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
1331         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
1332         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
1333         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
1334         * go-lang.c (_initialize_go_language): Add declaration.
1335         * go32-nat.c (_initialize_go32_nat): Add declaration.
1336         * guile/guile.c (_initialize_guile): Add declaration.
1337         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
1338         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
1339         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
1340         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
1341         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
1342         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
1343         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
1344         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
1345         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
1346         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
1347         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
1348         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
1349         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
1350         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
1351         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
1352         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
1353         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
1354         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
1355         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
1356         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
1357         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
1358         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
1359         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
1360         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
1361         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
1362         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
1363         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
1364         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
1365         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
1366         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
1367         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
1368         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
1369         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
1370         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
1371         * infcall.c (_initialize_infcall): Add declaration.
1372         * infcmd.c (_initialize_infcmd): Add declaration.
1373         * inflow.c (_initialize_inflow): Add declaration.
1374         * infrun.c (_initialize_infrun): Add declaration.
1375         * interps.c (_initialize_interpreter): Add declaration.
1376         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
1377         * jit.c (_initialize_jit): Add declaration.
1378         * language.c (_initialize_language): Add declaration.
1379         * linux-fork.c (_initialize_linux_fork): Add declaration.
1380         * linux-nat.c (_initialize_linux_nat): Add declaration.
1381         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
1382         * linux-thread-db.c (_initialize_thread_db): Add declaration.
1383         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
1384         * m2-lang.c (_initialize_m2_language): Add declaration.
1385         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
1386         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
1387         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
1388         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
1389         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
1390         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
1391         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
1392         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
1393         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
1394         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
1395         * machoread.c (_initialize_machoread): Add declaration.
1396         * macrocmd.c (_initialize_macrocmd): Add declaration.
1397         * macroscope.c (_initialize_macroscope): Add declaration.
1398         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
1399         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
1400         * maint.c (_initialize_maint_cmds): Add declaration.
1401         * mdebugread.c (_initialize_mdebugread): Add declaration.
1402         * memattr.c (_initialize_mem): Add declaration.
1403         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
1404         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
1405         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
1406         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
1407         * mi/mi-main.c (_initialize_mi_main): Add declaration.
1408         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
1409         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
1410         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
1411         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
1412         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
1413         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
1414         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
1415         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
1416         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
1417         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
1418         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
1419         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
1420         * mipsread.c (_initialize_mipsread): Add declaration.
1421         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
1422         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
1423         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
1424         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
1425         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
1426         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
1427         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
1428         * nto-procfs.c (_initialize_procfs): Add declaration.
1429         * objc-lang.c (_initialize_objc_language): Add declaration.
1430         * observable.c (_initialize_observer): Add declaration.
1431         * opencl-lang.c (_initialize_opencl_language): Add declaration.
1432         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
1433         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
1434         * osabi.c (_initialize_gdb_osabi): Add declaration.
1435         * osdata.c (_initialize_osdata): Add declaration.
1436         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
1437         * parse.c (_initialize_parse): Add declaration.
1438         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
1439         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
1440         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
1441         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
1442         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
1443         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
1444         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
1445         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
1446         * printcmd.c (_initialize_printcmd): Add declaration.
1447         * probe.c (_initialize_probe): Add declaration.
1448         * proc-api.c (_initialize_proc_api): Add declaration.
1449         * proc-events.c (_initialize_proc_events): Add declaration.
1450         * proc-service.c (_initialize_proc_service): Add declaration.
1451         * procfs.c (_initialize_procfs): Add declaration.
1452         * producer.c (_initialize_producer): Add declaration.
1453         * psymtab.c (_initialize_psymtab): Add declaration.
1454         * python/python.c (_initialize_python): Add declaration.
1455         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
1456         * record-btrace.c (_initialize_record_btrace): Add declaration.
1457         * record-full.c (_initialize_record_full): Add declaration.
1458         * record.c (_initialize_record): Add declaration.
1459         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
1460         * regcache.c (_initialize_regcache): Add declaration.
1461         * reggroups.c (_initialize_reggroup): Add declaration.
1462         * remote-notif.c (_initialize_notif): Add declaration.
1463         * remote-sim.c (_initialize_remote_sim): Add declaration.
1464         * remote.c (_initialize_remote): Add declaration.
1465         * reverse.c (_initialize_reverse): Add declaration.
1466         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
1467         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
1468         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
1469         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
1470         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
1471         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
1472         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
1473         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
1474         Add declaration.
1475         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
1476         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
1477         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
1478         * rust-exp.y (_initialize_rust_exp): Add declaration.
1479         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
1480         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
1481         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
1482         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
1483         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
1484         * score-tdep.c (_initialize_score_tdep): Add declaration.
1485         * ser-go32.c (_initialize_ser_dos): Add declaration.
1486         * ser-mingw.c (_initialize_ser_windows): Add declaration.
1487         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
1488         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
1489         * ser-uds.c (_initialize_ser_socket): Add declaration.
1490         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
1491         * serial.c (_initialize_serial): Add declaration.
1492         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
1493         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
1494         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
1495         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
1496         * skip.c (_initialize_step_skip): Add declaration.
1497         * sol-thread.c (_initialize_sol_thread): Add declaration.
1498         * solib-aix.c (_initialize_solib_aix): Add declaration.
1499         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
1500         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
1501         * solib-frv.c (_initialize_frv_solib): Add declaration.
1502         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
1503         * solib-target.c (_initialize_solib_target): Add declaration.
1504         * solib.c (_initialize_solib): Add declaration.
1505         * source-cache.c (_initialize_source_cache): Add declaration.
1506         * source.c (_initialize_source): Add declaration.
1507         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
1508         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
1509         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
1510         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
1511         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
1512         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
1513         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
1514         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
1515         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
1516         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
1517         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
1518         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
1519         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
1520         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
1521         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
1522         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
1523         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
1524         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
1525         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
1526         * stabsread.c (_initialize_stabsread): Add declaration.
1527         * stack.c (_initialize_stack): Add declaration.
1528         * stap-probe.c (_initialize_stap_probe): Add declaration.
1529         * std-regs.c (_initialize_frame_reg): Add declaration.
1530         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
1531         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
1532         * symfile.c (_initialize_symfile): Add declaration.
1533         * symmisc.c (_initialize_symmisc): Add declaration.
1534         * symtab.c (_initialize_symtab): Add declaration.
1535         * target.c (_initialize_target): Add declaration.
1536         * target-connection.c (_initialize_target_connection): Add
1537         declaration.
1538         * target-dcache.c (_initialize_target_dcache): Add declaration.
1539         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
1540         * thread.c (_initialize_thread): Add declaration.
1541         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
1542         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
1543         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
1544         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
1545         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
1546         * tracectf.c (_initialize_ctf): Add declaration.
1547         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
1548         * tracefile.c (_initialize_tracefile): Add declaration.
1549         * tracepoint.c (_initialize_tracepoint): Add declaration.
1550         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
1551         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
1552         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
1553         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
1554         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
1555         * tui/tui-win.c (_initialize_tui_win): Add declaration.
1556         * tui/tui.c (_initialize_tui): Add declaration.
1557         * typeprint.c (_initialize_typeprint): Add declaration.
1558         * ui-style.c (_initialize_ui_style): Add declaration.
1559         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
1560         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
1561         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
1562         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
1563         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
1564         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
1565         * unittests/filtered_iterator-selftests.c
1566         (_initialize_filtered_iterator_selftests): Add declaration.
1567         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
1568         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
1569         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
1570         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
1571         * unittests/main-thread-selftests.c
1572         (_initialize_main_thread_selftests): Add declaration.
1573         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
1574         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
1575         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
1576         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
1577         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
1578         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
1579         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
1580         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
1581         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
1582         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
1583         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
1584         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
1585         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
1586         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
1587         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
1588         declaration.
1589         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
1590         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
1591         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
1592         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
1593         * user-regs.c (_initialize_user_regs): Add declaration.
1594         * utils.c (_initialize_utils): Add declaration.
1595         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
1596         * valops.c (_initialize_valops): Add declaration.
1597         * valprint.c (_initialize_valprint): Add declaration.
1598         * value.c (_initialize_values): Add declaration.
1599         * varobj.c (_initialize_varobj): Add declaration.
1600         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
1601         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
1602         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
1603         * windows-nat.c (_initialize_windows_nat): Add declaration.
1604         (_initialize_check_for_gdb_ini): Add declaration.
1605         (_initialize_loadable): Add declaration.
1606         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
1607         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
1608         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
1609         * xcoffread.c (_initialize_xcoffread): Add declaration.
1610         * xml-support.c (_initialize_xml_support): Add declaration.
1611         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
1612         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
1613         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
1614         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
1615
1616 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
1617
1618         * regformats/regdat.sh: Generate declaration for init function.
1619
1620 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
1621
1622         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
1623         up.
1624         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
1625         close_one_inferior>: New methods.
1626         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
1627         pass down target to find_inferior_pid.
1628         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
1629         Pass down target to find_inferior_ptid.
1630         (gdbsim_target::create_inferior): Pass down target to
1631         add_thread_silent.
1632         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
1633         target down to find_inferior_ptid and switch_to_thread.
1634         (gdbsim_target::close): Update to call close_one_inferior.
1635         (struct resume_data): Remove.
1636         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
1637         directly, rather than through a void pointer.
1638         (gdbsim_target::resume): Update to call resume_one_inferior.
1639
1640 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
1641
1642         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
1643
1644 2020-01-12  Pedro Alves  <palves@redhat.com>
1645
1646         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
1647         directly for the current inferior instead of
1648         discard_all_inferiors.
1649         (discard_all_inferiors): Delete.
1650
1651 2020-01-11  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-wingeneral.c (box_win): Check cli_styling.
1654         * tui/tui-winsource.c (tui_source_window_base::refill): Use
1655         deprecated_safe_get_selected_frame.
1656
1657 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1658
1659         * inferior.c (print_inferior): Switch inferior before printing it.
1660
1661 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
1662             Pedro Alves  <palves@redhat.com>
1663
1664         * progspace-and-thread.c (switch_to_program_space_and_thread):
1665         Assert there's an inferior for PSPACE.  Use
1666         switch_to_inferior_no_thread to switch the inferior too.
1667         * progspace.c (program_space::~program_space): Call
1668         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
1669         (program_space::free_all_objfiles): Don't call clear_symtab_users
1670         here.
1671         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
1672
1673 2020-01-10  Pedro Alves  <palves@redhat.com>
1674
1675         * NEWS: Mention multi-target debugging, "info connections", and
1676         "add-inferior -no-connection".
1677
1678 2020-01-10  Pedro Alves  <palves@redhat.com>
1679
1680         * infrun.c: Include "target-connection.h".
1681         (check_multi_target_resumption): New.
1682         (proceed): Call it.
1683         * target-connection.c (make_target_connection_string): Make
1684         extern.
1685         * target-connection.h (make_target_connection_string): Declare.
1686
1687 2020-01-10  Pedro Alves  <palves@redhat.com>
1688
1689         * Makefile.in (COMMON_SFILES): Add target-connection.c.
1690         * inferior.c (uiout_field_connection): New function.
1691         (print_inferior): Add new "connection-id" column.
1692         (add_inferior_command): Show connection number/string of added
1693         inferior.
1694         * process-stratum-target.h
1695         (process_stratum_target::connection_string): New virtual method.
1696         (process_stratum_target::connection_number): New field.
1697         * remote.c (remote_target::connection_string): New override.
1698         * target-connection.c: New file.
1699         * target-connection.h: New file.
1700         * target.c (decref_target): Remove process_stratum targets from
1701         the connection list.
1702         (target_stack::push): Add process_stratum targets to the
1703         connection list.
1704
1705 2020-01-10  Pedro Alves  <palves@redhat.com>
1706
1707         Revert:
1708         2016-04-12  Pedro Alves  <palves@redhat.com>
1709         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
1710         Remove references to name.
1711         * serial.h (struct serial) <name>: Delete.
1712
1713 2020-01-10  Pedro Alves  <palves@redhat.com>
1714
1715         * gdbarch-selftests.c (register_to_value_test): Remove "target
1716         already pushed" check.
1717
1718 2020-01-10  Pedro Alves  <palves@redhat.com>
1719             John Baldwin  <jhb@FreeBSD.org>
1720
1721         * aarch64-linux-nat.c
1722         (aarch64_linux_nat_target::thread_architecture): Adjust.
1723         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
1724         (task_command_1): Likewise.
1725         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
1726         (aix_thread_target::wait, aix_thread_target::fetch_registers)
1727         (aix_thread_target::store_registers)
1728         (aix_thread_target::thread_alive): Adjust.
1729         * amd64-fbsd-tdep.c: Include "inferior.h".
1730         (amd64fbsd_get_thread_local_address): Pass down target.
1731         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
1732         thread's gdbarch instead of target_gdbarch.
1733         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
1734         get_last_target_status.
1735         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
1736         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
1737         inferiors.
1738         (update_inserted_breakpoint_locations): Skip if inferiors with no
1739         execution.
1740         (update_global_location_list): When handling moribund locations,
1741         find representative inferior for location's pspace, and use thread
1742         count of its process_stratum target.
1743         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
1744         * bsd-uthread.c (bsd_uthread_target::wait): Use
1745         as_process_stratum_target and adjust thread_change_ptid and
1746         add_thread calls.
1747         (bsd_uthread_target::update_thread_list): Use
1748         as_process_stratum_target and adjust find_thread_ptid,
1749         thread_change_ptid and add_thread calls.
1750         * btrace.c (maint_btrace_packet_history_cmd): Adjust
1751         find_thread_ptid call.
1752         * corelow.c (add_to_thread_list): Adjust add_thread call.
1753         (core_target_open): Adjust add_thread_silent and thread_count
1754         calls.
1755         (core_target::pid_to_str): Adjust find_inferior_ptid call.
1756         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
1757         * event-top.c (async_disconnect): Pop targets from all inferiors.
1758         * exec.c (add_target_sections): Push exec target on all inferiors
1759         sharing the program space.
1760         (remove_target_sections): Remove the exec target from all
1761         inferiors sharing the program space.
1762         (exec_on_vfork): New.
1763         * exec.h (exec_on_vfork): Declare.
1764         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
1765         Pass it down.
1766         (fbsd_nat_target::update_thread_list): Adjust.
1767         (fbsd_nat_target::resume): Adjust.
1768         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
1769         down.
1770         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
1771         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
1772         get_thread_arch_regcache call.
1773         * fork-child.c (gdb_startup_inferior): Pass target down to
1774         startup_inferior and set_executing.
1775         * gdbthread.h (struct process_stratum_target): Forward declare.
1776         (add_thread, add_thread_silent, add_thread_with_info)
1777         (in_thread_list): Add process_stratum_target parameter.
1778         (find_thread_ptid(inferior*, ptid_t)): New overload.
1779         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
1780         parameter.
1781         (all_threads()): Delete overload.
1782         (all_threads, all_non_exited_threads): Add process_stratum_target
1783         parameter.
1784         (all_threads_safe): Use brace initialization.
1785         (thread_count): Add process_stratum_target parameter.
1786         (set_resumed, set_running, set_stop_requested, set_executing)
1787         (threads_are_executing, finish_thread_state): Add
1788         process_stratum_target parameter.
1789         (switch_to_thread): Use is_current_thread.
1790         * i386-fbsd-tdep.c: Include "inferior.h".
1791         (i386fbsd_get_thread_local_address): Pass down target.
1792         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
1793         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
1794         have_inferiors check.
1795         * inf-ptrace.c (inf_ptrace_target::create_inferior)
1796         (inf_ptrace_target::attach): Adjust.
1797         * infcall.c (run_inferior_call): Adjust.
1798         * infcmd.c (run_command_1): Pass target to
1799         scoped_finish_thread_state.
1800         (proceed_thread_callback): Skip inferiors with no execution.
1801         (continue_command): Rename 'all_threads' local to avoid hiding
1802         'all_threads' function.  Adjust get_last_target_status call.
1803         (prepare_one_step): Adjust set_running call.
1804         (signal_command): Use user_visible_resume_target.  Compare thread
1805         pointers instead of inferior_ptid.
1806         (info_program_command): Adjust to pass down target.
1807         (attach_command): Mark target's 'thread_executing' flag.
1808         (stop_current_target_threads_ns): New, factored out from ...
1809         (interrupt_target_1): ... this.  Switch inferior before making
1810         target calls.
1811         * inferior-iter.h
1812         (struct all_inferiors_iterator, struct all_inferiors_range)
1813         (struct all_inferiors_safe_range)
1814         (struct all_non_exited_inferiors_range): Filter on
1815         process_stratum_target too.  Remove explicit.
1816         * inferior.c (inferior::inferior): Push dummy target on target
1817         stack.
1818         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
1819         Add process_stratum_target parameter, and pass it down.
1820         (have_live_inferiors): Adjust.
1821         (switch_to_inferior_and_push_target): New.
1822         (add_inferior_command, clone_inferior_command): Handle
1823         "-no-connection" parameter.  Use
1824         switch_to_inferior_and_push_target.
1825         (_initialize_inferior): Mention "-no-connection" option in
1826         the help of "add-inferior" and "clone-inferior" commands.
1827         * inferior.h: Include "process-stratum-target.h".
1828         (interrupt_target_1): Use bool.
1829         (struct inferior) <push_target, unpush_target, target_is_pushed,
1830         find_target_beneath, top_target, process_target, target_at,
1831         m_stack>: New.
1832         (discard_all_inferiors): Delete.
1833         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
1834         (all_inferiors, all_non_exited_inferiors): Add
1835         process_stratum_target parameter.
1836         * infrun.c: Include "gdb_select.h" and <unordered_map>.
1837         (target_last_proc_target): New global.
1838         (follow_fork_inferior): Push target on new inferior.  Pass target
1839         to add_thread_silent.  Call exec_on_vfork.  Handle target's
1840         reference count.
1841         (follow_fork): Adjust get_last_target_status call.  Also consider
1842         target.
1843         (follow_exec): Push target on new inferior.
1844         (struct execution_control_state) <target>: New field.
1845         (user_visible_resume_target): New.
1846         (do_target_resume): Call target_async.
1847         (resume_1): Set target's threads_executing flag.  Consider resume
1848         target.
1849         (commit_resume_all_targets): New.
1850         (proceed): Also consider resume target.  Skip threads of inferiors
1851         with no execution.  Commit resumtion in all targets.
1852         (start_remote): Pass current inferior to wait_for_inferior.
1853         (infrun_thread_stop_requested): Consider target as well.  Pass
1854         thread_info pointer to clear_inline_frame_state instead of ptid.
1855         (infrun_thread_thread_exit): Consider target as well.
1856         (random_pending_event_thread): New inferior parameter.  Use it.
1857         (do_target_wait): Rename to ...
1858         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
1859         down.
1860         (threads_are_resumed_pending_p, do_target_wait): New.
1861         (prepare_for_detach): Adjust calls.
1862         (wait_for_inferior): New inferior parameter.  Handle it.  Use
1863         do_target_wait_1 instead of do_target_wait.
1864         (fetch_inferior_event): Adjust.  Switch to representative
1865         inferior.  Pass target down.
1866         (set_last_target_status): Add process_stratum_target parameter.
1867         Save target in global.
1868         (get_last_target_status): Add process_stratum_target parameter and
1869         handle it.
1870         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
1871         (context_switch): Check inferior_ptid == null_ptid before calling
1872         inferior_thread().
1873         (get_inferior_stop_soon): Pass down target.
1874         (wait_one): Rename to ...
1875         (poll_one_curr_target): ... this.
1876         (struct wait_one_event): New.
1877         (wait_one): New.
1878         (stop_all_threads): Adjust.
1879         (handle_no_resumed, handle_inferior_event): Adjust to consider the
1880         event's target.
1881         (switch_back_to_stepped_thread): Also consider target.
1882         (print_stop_event): Update.
1883         (normal_stop): Update.  Also consider the resume target.
1884         * infrun.h (wait_for_inferior): Remove declaration.
1885         (user_visible_resume_target): New declaration.
1886         (get_last_target_status, set_last_target_status): New
1887         process_stratum_target parameter.
1888         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
1889         process_stratum_target parameter, and use it.
1890         (clear_inline_frame_state (thread_info*)): New.
1891         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
1892         process_stratum_target parameter.
1893         (clear_inline_frame_state (thread_info*)): Declare.
1894         * linux-fork.c (delete_checkpoint_command): Pass target down to
1895         find_thread_ptid.
1896         (checkpoint_command): Adjust.
1897         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
1898         instead of just tweaking inferior_ptid.
1899         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
1900         (exit_lwp): Pass target down to find_thread_ptid.
1901         (attach_proc_task_lwp_callback): Pass target down to
1902         add_thread/set_running/set_executing.
1903         (linux_nat_target::attach): Pass target down to
1904         thread_change_ptid.
1905         (get_detach_signal): Pass target down to find_thread_ptid.
1906         Consider last target status's target.
1907         (linux_resume_one_lwp_throw, resume_lwp)
1908         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
1909         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
1910         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
1911         (linux_nat_target::async_wait_fd): New.
1912         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
1913         target down.
1914         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
1915         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
1916         * linux-thread-db.c (struct thread_db_info::process_target): New
1917         field.
1918         (add_thread_db_info): Save target.
1919         (get_thread_db_info): New process_stratum_target parameter.  Also
1920         match target.
1921         (delete_thread_db_info): New process_stratum_target parameter.
1922         Also match target.
1923         (thread_from_lwp): Adjust to pass down target.
1924         (thread_db_notice_clone): Pass down target.
1925         (check_thread_db_callback): Pass down target.
1926         (try_thread_db_load_1): Always push the thread_db target.
1927         (try_thread_db_load, record_thread): Pass target down.
1928         (thread_db_target::detach): Pass target down.  Always unpush the
1929         thread_db target.
1930         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
1931         target down.  Always unpush the thread_db target.
1932         (find_new_threads_callback, thread_db_find_new_threads_2)
1933         (thread_db_target::update_thread_list): Pass target down.
1934         (thread_db_target::pid_to_str): Pass current inferior down.
1935         (thread_db_target::get_thread_local_address): Pass target down.
1936         (thread_db_target::resume, maintenance_check_libthread_db): Pass
1937         target down.
1938         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
1939         * procfs.c (procfs_target::procfs_init_inferior): Declare.
1940         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
1941         (procfs_init_inferior): Rename to ...
1942         (procfs_target::procfs_init_inferior): ... this and adjust.
1943         (procfs_target::create_inferior, procfs_notice_thread)
1944         (procfs_do_thread_registers): Adjust.
1945         * ppc-fbsd-tdep.c: Include "inferior.h".
1946         (ppcfbsd_get_thread_local_address): Pass down target.
1947         * proc-service.c (ps_xfer_memory): Switch current inferior and
1948         program space as well.
1949         (get_ps_regcache): Pass target down.
1950         * process-stratum-target.c
1951         (process_stratum_target::thread_address_space)
1952         (process_stratum_target::thread_architecture): Pass target down.
1953         * process-stratum-target.h
1954         (process_stratum_target::threads_executing): New field.
1955         (as_process_stratum_target): New.
1956         * ravenscar-thread.c
1957         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
1958         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
1959         down.
1960         * record-btrace.c (record_btrace_target::info_record): Adjust.
1961         (record_btrace_target::record_method)
1962         (record_btrace_target::record_is_replaying)
1963         (record_btrace_target::fetch_registers)
1964         (get_thread_current_frame_id, record_btrace_target::resume)
1965         (record_btrace_target::wait, record_btrace_target::stop): Pass
1966         target down.
1967         * record-full.c (record_full_wait_1): Switch to event thread.
1968         Pass target down.
1969         * regcache.c (regcache::regcache)
1970         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
1971         process_stratum_target parameter and handle it.
1972         (current_thread_target): New global.
1973         (get_thread_regcache): Add process_stratum_target parameter and
1974         handle it.  Switch inferior before calling target method.
1975         (get_thread_regcache): Pass target down.
1976         (get_thread_regcache_for_ptid): Pass target down.
1977         (registers_changed_ptid): Add process_stratum_target parameter and
1978         handle it.
1979         (registers_changed_thread, registers_changed): Pass target down.
1980         (test_get_thread_arch_aspace_regcache): New.
1981         (current_regcache_test): Define a couple local test_target_ops
1982         instances and use them for testing.
1983         (readwrite_regcache): Pass process_stratum_target parameter.
1984         (cooked_read_test, cooked_write_test): Pass mock_target down.
1985         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
1986         (get_thread_arch_aspace_regcache): Add process_stratum_target
1987         parameter.
1988         (regcache::target): New method.
1989         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
1990         (regcache::registers_changed_ptid): Add process_stratum_target
1991         parameter.
1992         (regcache::m_target): New field.
1993         (registers_changed_ptid): Add process_stratum_target parameter.
1994         * remote.c (remote_state::supports_vCont_probed): New field.
1995         (remote_target::async_wait_fd): New method.
1996         (remote_unpush_and_throw): Add remote_target parameter.
1997         (get_current_remote_target): Adjust.
1998         (remote_target::remote_add_inferior): Push target.
1999         (remote_target::remote_add_thread)
2000         (remote_target::remote_notice_new_inferior)
2001         (get_remote_thread_info): Pass target down.
2002         (remote_target::update_thread_list): Skip threads of inferiors
2003         bound to other targets.  (remote_target::close): Don't discard
2004         inferiors.  (remote_target::add_current_inferior_and_thread)
2005         (remote_target::process_initial_stop_replies)
2006         (remote_target::start_remote)
2007         (remote_target::remote_serial_quit_handler): Pass down target.
2008         (remote_target::remote_unpush_target): New remote_target
2009         parameter.  Unpush the target from all inferiors.
2010         (remote_target::remote_unpush_and_throw): New remote_target
2011         parameter.  Pass it down.
2012         (remote_target::open_1): Check whether the current inferior has
2013         execution instead of checking whether any inferior is live.  Pass
2014         target down.
2015         (remote_target::remote_detach_1): Pass down target.  Use
2016         remote_unpush_target.
2017         (extended_remote_target::attach): Pass down target.
2018         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
2019         (remote_target::append_resumption): Pass down target.
2020         (remote_target::append_pending_thread_resumptions)
2021         (remote_target::remote_resume_with_hc, remote_target::resume)
2022         (remote_target::commit_resume): Pass down target.
2023         (remote_target::remote_stop_ns): Check supports_vCont_probed.
2024         (remote_target::interrupt_query)
2025         (remote_target::remove_new_fork_children)
2026         (remote_target::check_pending_events_prevent_wildcard_vcont)
2027         (remote_target::remote_parse_stop_reply)
2028         (remote_target::process_stop_reply): Pass down target.
2029         (first_remote_resumed_thread): New remote_target parameter.  Pass
2030         it down.
2031         (remote_target::wait_as): Pass down target.
2032         (unpush_and_perror): New remote_target parameter.  Pass it down.
2033         (remote_target::readchar, remote_target::remote_serial_write)
2034         (remote_target::getpkt_or_notif_sane_1)
2035         (remote_target::kill_new_fork_children, remote_target::kill): Pass
2036         down target.
2037         (remote_target::mourn_inferior): Pass down target.  Use
2038         remote_unpush_target.
2039         (remote_target::core_of_thread)
2040         (remote_target::remote_btrace_maybe_reopen): Pass down target.
2041         (remote_target::pid_to_exec_file)
2042         (remote_target::thread_handle_to_thread_info): Pass down target.
2043         (remote_target::async_wait_fd): New.
2044         * riscv-fbsd-tdep.c: Include "inferior.h".
2045         (riscv_fbsd_get_thread_local_address): Pass down target.
2046         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
2047         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
2048         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
2049         Adjust.
2050         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
2051         * solib-svr4.c (enable_break): Pass down target.
2052         * spu-multiarch.c (parse_spufs_run): Pass down target.
2053         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
2054         * target-delegates.c: Regenerate.
2055         * target.c (g_target_stack): Delete.
2056         (current_top_target): Return the current inferior's top target.
2057         (target_has_execution_1): Refer to the passed-in inferior's top
2058         target.
2059         (target_supports_terminal_ours): Check whether the initial
2060         inferior was already created.
2061         (decref_target): New.
2062         (target_stack::push): Incref/decref the target.
2063         (push_target, push_target, unpush_target): Adjust.
2064         (target_stack::unpush): Defref target.
2065         (target_is_pushed): Return bool.  Adjust to refer to the current
2066         inferior's target stack.
2067         (dispose_inferior): Delete, and inline parts ...
2068         (target_preopen): ... here.  Only dispose of the current inferior.
2069         (target_detach): Hold strong target reference while detaching.
2070         Pass target down.
2071         (target_thread_name): Add assertion.
2072         (target_resume): Pass down target.
2073         (target_ops::beneath, find_target_at): Adjust to refer to the
2074         current inferior's target stack.
2075         (get_dummy_target): New.
2076         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
2077         has a thread running.
2078         (initialize_targets): Rename to ...
2079         (_initialize_target): ... this.
2080         * target.h: Include "gdbsupport/refcounted-object.h".
2081         (struct target_ops): Inherit refcounted_object.
2082         (target_ops::shortname, target_ops::longname): Make const.
2083         (target_ops::async_wait_fd): New method.
2084         (decref_target): Declare.
2085         (struct target_ops_ref_policy): New.
2086         (target_ops_ref): New typedef.
2087         (get_dummy_target): Declare function.
2088         (target_is_pushed): Return bool.
2089         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
2090         (all_matching_threads_iterator::all_matching_threads_iterator):
2091         Handle filter target.
2092         * thread-iter.h (struct all_matching_threads_iterator, struct
2093         all_matching_threads_range, class all_non_exited_threads_range):
2094         Filter by target too.  Remove explicit.
2095         * thread.c (threads_executing): Delete.
2096         (inferior_thread): Pass down current inferior.
2097         (clear_thread_inferior_resources): Pass down thread pointer
2098         instead of ptid_t.
2099         (add_thread_silent, add_thread_with_info, add_thread): Add
2100         process_stratum_target parameter.  Use it for thread and inferior
2101         searches.
2102         (is_current_thread): New.
2103         (thread_info::deletable): Use it.
2104         (find_thread_ptid, thread_count, in_thread_list)
2105         (thread_change_ptid, set_resumed, set_running): New
2106         process_stratum_target parameter.  Pass it down.
2107         (set_executing): New process_stratum_target parameter.  Pass it
2108         down.  Adjust reference to 'threads_executing'.
2109         (threads_are_executing): New process_stratum_target parameter.
2110         Adjust reference to 'threads_executing'.
2111         (set_stop_requested, finish_thread_state): New
2112         process_stratum_target parameter.  Pass it down.
2113         (switch_to_thread): Also match inferior.
2114         (switch_to_thread): New process_stratum_target parameter.  Pass it
2115         down.
2116         (update_threads_executing): Reimplement.
2117         * top.c (quit_force): Pop targets from all inferior.
2118         (gdb_init): Don't call initialize_targets.
2119         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
2120         Declare.
2121         (windows_add_thread, windows_delete_thread): Adjust.
2122         (get_windows_debug_event): Rename to ...
2123         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
2124         * tracefile-tfile.c (tfile_target_open): Pass down target.
2125         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
2126         Forward declare.
2127         (switch_to_thread): Add process_stratum_target parameter.
2128         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
2129         parameter.  Use it.
2130         (mi_on_resume): Pass target down.
2131         * nat/fork-inferior.c (startup_inferior): Add
2132         process_stratum_target parameter.  Pass it down.
2133         * nat/fork-inferior.h (startup_inferior): Add
2134         process_stratum_target parameter.
2135         * python/py-threadevent.c (py_get_event_thread): Pass target down.
2136
2137 2020-01-10  Pedro Alves  <palves@redhat.com>
2138
2139         * remote.c (remote_target::start_remote): Don't set inferior_ptid
2140         directly.  Instead find the first thread in the thread list and
2141         use switch_to_thread.
2142
2143 2020-01-10  Pedro Alves  <palves@redhat.com>
2144
2145         * remote.c (remote_target::remote_add_inferior): Don't bind a
2146         process to the current inferior if the current inferior is already
2147         bound to a process.
2148
2149 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2150             Pedro Alves  <palves@redhat.com>
2151
2152         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
2153         If no process is specified, return null_ptid instead of
2154         inferior_ptid.
2155         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
2156         TARGET_WAITKIND_SIGNALLED with no pid.
2157
2158 2020-01-10  Pedro Alves  <palves@redhat.com>
2159
2160         * remote.c (first_remote_resumed_thread): New.
2161         (remote_target::wait_as): Use it as default event_ptid instead of
2162         inferior_ptid.
2163
2164 2020-01-10  Pedro Alves  <palves@redhat.com>
2165
2166         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
2167
2168 2020-01-10  Pedro Alves  <palves@redhat.com>
2169
2170         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
2171         not -1.
2172
2173 2020-01-10  Pedro Alves  <palves@redhat.com>
2174
2175         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
2176         ptid to get_last_target_status.
2177         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
2178         ptid to get_last_target_status.
2179         * infcmd.c (continue_command): Don't pass a target_waitstatus to
2180         get_last_target_status.
2181         (info_program_command): Don't pass a target_waitstatus to
2182         get_last_target_status.
2183         * infrun.c (init_wait_for_inferior): Use
2184         nullify_last_target_wait_ptid.
2185         (get_last_target_status): Handle nullptr arguments.
2186         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
2187         (print_stop_event): Don't pass a ptid to get_last_target_status.
2188         (normal_stop): Don't pass a ptid to get_last_target_status.
2189         * infrun.h (get_last_target_status, set_last_target_status): Move
2190         comments here and update.
2191         (nullify_last_target_wait_ptid): Declare.
2192         * linux-fork.c (fork_load_infrun_state): Remove local extern
2193         declaration of nullify_last_target_wait_ptid.
2194         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
2195         to get_last_target_status.
2196
2197 2020-01-10  Pedro Alves  <palves@redhat.com>
2198
2199         * gdbthread.h (scoped_restore_current_thread)
2200         <dont_restore, restore, m_dont_restore>: Declare.
2201         * thread.c (thread_alive): Add assertion.  Return bool.
2202         (switch_to_thread_if_alive): New.
2203         (prune_threads): Switch inferior/thread.
2204         (print_thread_info_1): Switch thread before calling target methods.
2205         (scoped_restore_current_thread::restore): New, factored out from
2206         ...
2207         (scoped_restore_current_thread::~scoped_restore_current_thread):
2208         ... this.
2209         (scoped_restore_current_thread::scoped_restore_current_thread):
2210         Add assertion.
2211         (thread_apply_all_command, thread_select): Use
2212         switch_to_thread_if_alive.
2213         * infrun.c (proceed, restart_threads, handle_signal_stop)
2214         (switch_back_to_stepped_thread): Switch current thread before
2215         calling target methods.
2216
2217 2020-01-10  Pedro Alves <palves@redhat.com>
2218
2219         * inferior.c (switch_to_inferior_no_thread): New function,
2220         factored out from ...
2221         (inferior_command): ... here.
2222         * inferior.h (switch_to_inferior_no_thread): Declare.
2223         * mi/mi-main.c (run_one_inferior): Use
2224         switch_to_inferior_no_thread.
2225
2226 2020-01-10  Pedro Alves  <palves@redhat.com>
2227
2228         * infcmd.c (kill_command): Remove dead code.
2229
2230 2020-01-10  Pedro Alves  <palves@redhat.com>
2231
2232         * remote.c (remote_target::mourn_inferior): No longer check
2233         whether the target is running.
2234
2235 2020-01-10  Pedro Alves  <palves@redhat.com>
2236
2237         * corelow.c (core_target::has_execution): Change parameter type to
2238         inferior pointer.
2239         * inferior.c (number_of_live_inferiors): Use
2240         inferior::has_execution instead of target_has_execution_1.
2241         * inferior.h (inferior::has_execution): New.
2242         * linux-thread-db.c (thread_db_target::update_thread_list): Use
2243         inferior::has_execution instead of target_has_execution_1.
2244         * process-stratum-target.c
2245         (process_stratum_target::has_execution): Change parameter type to
2246         inferior pointer.  Check the inferior's PID instead of
2247         inferior_ptid.
2248         * process-stratum-target.h
2249         (process_stratum_target::has_execution): Change parameter type to
2250         inferior pointer.
2251         * record-full.c (record_full_core_target::has_execution): Change
2252         parameter type to inferior pointer.
2253         * target.c (target_has_execution_1): Change parameter type to
2254         inferior pointer.
2255         (target_has_execution_current): Adjust.
2256         * target.h (target_ops::has_execution): Change parameter type to
2257         inferior pointer.
2258         (target_has_execution_1): Change parameter type to inferior
2259         pointer.  Change return type to bool.
2260         * tracefile.h (tracefile_target::has_execution): Change parameter
2261         type to inferior pointer.
2262
2263 2020-01-10  Pedro Alves  <palves@redhat.com>
2264
2265         * exceptions.c (print_flush): Remove current_top_target() check.
2266
2267 2020-01-10  Pedro Alves  <palves@redhat.com>
2268
2269         * remote.c (show_remote_exec_file): Show the current inferior's
2270         exec-file instead of the command variable's value.
2271
2272 2020-01-10  Pedro Alves  <palves@redhat.com>
2273
2274         * record-full.c (record_full_resume_ptid): New global.
2275         (record_full_target::resume): Set it.
2276         (record_full_wait_1): Use record_full_resume_ptid instead of
2277         inferior_ptid.
2278
2279 2020-01-10  Pedro Alves  <palves@redhat.com>
2280
2281         * gdbthread.h (scoped_restore_current_thread)
2282         <dont_restore, restore, m_dont_restore>: Declare.
2283         * thread.c (thread_alive): Add assertion.  Return bool.
2284         (switch_to_thread_if_alive): New.
2285         (prune_threads): Switch inferior/thread.
2286         (print_thread_info_1): Switch thread before calling target methods.
2287         (scoped_restore_current_thread::restore): New, factored out from
2288         ...
2289         (scoped_restore_current_thread::~scoped_restore_current_thread):
2290         ... this.
2291         (scoped_restore_current_thread::scoped_restore_current_thread):
2292         Add assertion.
2293         (thread_apply_all_command, thread_select): Use
2294         switch_to_thread_if_alive.
2295
2296 2020-01-10  George Barrett  <bob@bob131.so>
2297
2298         * stap-probe.c (stap_modify_semaphore): Don't check for null
2299         semaphores.
2300         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
2301         for null semaphores.
2302
2303 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
2306         all source windows, and maintain horizontal scroll status while
2307         doing so.
2308
2309 2020-01-09  Tom Tromey  <tom@tromey.com>
2310
2311         PR tui/18932:
2312         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
2313         update_source_window, not print_source_lines.
2314
2315 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * tui/tui.c (tui_enable): Register tui hooks after calling
2318         tui_display_main.
2319
2320 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
2323
2324 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
2325
2326         * thread.c (print_thread_info_1): Fix indentation.
2327
2328 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
2329
2330         * symtab.c (general_symbol_info::compute_and_set_names): Move the
2331         unique_xmalloc_ptr outside the if to always free the demangled name.
2332
2333 2020-01-08  Tom Tromey  <tromey@adacore.com>
2334
2335         * xcoffread.c (enter_line_range, read_xcoff_symtab)
2336         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
2337         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
2338         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
2339         Remove.
2340         (section_offsets): New typedef.
2341         * symtab.c (fixup_section, get_msymbol_address): Update.
2342         * symmisc.c (dump_msymbols): Update.
2343         * symfile.h (relative_addr_info_to_section_offsets)
2344         (symfile_map_offsets_to_segments): Update.
2345         * symfile.c (build_section_addr_info_from_objfile)
2346         (init_objfile_sect_indices): Update.
2347         (struct place_section_arg): Change type of "offsets".
2348         (place_section): Update.
2349         (relative_addr_info_to_section_offsets): Change type of
2350         "section_offsets".  Remove "num_sections" parameter.
2351         (default_symfile_offsets, syms_from_objfile_1)
2352         (set_objfile_default_section_offset): Update.
2353         (reread_symbols): No need to preserve section offsets by hand.
2354         (symfile_map_offsets_to_segments): Change type of "offsets".
2355         * stap-probe.c (relocate_address): Update.
2356         * stabsread.h (process_one_symbol): Update.
2357         * solib-target.c (struct lm_info_target) <offsets>: Change type.
2358         (solib_target_relocate_section_addresses): Update.
2359         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
2360         Update.
2361         * solib-frv.c (frv_relocate_main_executable): Update.
2362         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
2363         * solib-aix.c (solib_aix_get_section_offsets): Change return
2364         type.
2365         (solib_aix_solib_create_inferior_hook): Update.
2366         * remote.c (remote_target::get_offsets): Update.
2367         * psymtab.c (find_pc_sect_psymtab): Update.
2368         * psympriv.h (struct partial_symbol) <address, text_low,
2369         text_high>: Update.
2370         * objfiles.h (obj_section_offset): Update.
2371         (struct objfile) <section_offsets>: Change type.
2372         <num_sections>: Remove.
2373         (objfile_relocate): Update.
2374         * objfiles.c (entry_point_address_query): Update
2375         (relocate_one_symbol): Change type of "section_offsets".
2376         (objfile_relocate1, objfile_relocate1): Change type of
2377         "new_offsets".
2378         (objfile_rebase1): Update.
2379         * mipsread.c (mipscoff_symfile_read): Update.
2380         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
2381         parameter.
2382         * mdebugread.c (parse_symbol): Change type of "section_offsets".
2383         (parse_external, psymtab_to_symtab_1): Update.
2384         * machoread.c (macho_symfile_offsets): Update.
2385         * ia64-tdep.c (ia64_find_unwind_table): Update.
2386         * hppa-tdep.c (read_unwind_info): Update.
2387         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
2388         * dwarf2read.c (create_addrmap_from_index)
2389         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2390         (process_psymtab_comp_unit_reader, add_partial_symbol)
2391         (add_partial_subprogram, process_full_comp_unit)
2392         (read_file_scope, read_func_scope, read_lexical_block_scope)
2393         (read_call_site_scope, dwarf2_rnglists_process)
2394         (dwarf2_ranges_process, dwarf2_ranges_read)
2395         (dwarf_decode_lines_1, var_decode_location, new_symbol)
2396         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
2397         Update.
2398         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
2399         Update.
2400         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
2401         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
2402         (process_one_symbol): Change type of "section_offsets".
2403         * ctfread.c (get_objfile_text_range): Update.
2404         * coffread.c (coff_symtab_read, enter_linenos)
2405         (process_coff_symbol): Update.
2406         * coff-pe-read.c (add_pe_forwarded_sym): Update.
2407         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
2408
2409 2020-01-08  Tom Tromey  <tromey@adacore.com>
2410
2411         * dwarf2read.c (parse_macro_definition): Use std::string.
2412         (parse_macro_definition): Likewise.
2413
2414 2020-01-08  Tom Tromey  <tromey@adacore.com>
2415
2416         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
2417         (ATTR_ALLOC_CHUNK): Remove.
2418
2419 2020-01-08  Tom Tromey  <tromey@adacore.com>
2420
2421         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
2422
2423 2020-01-08  Tom Tromey  <tromey@adacore.com>
2424
2425         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
2426         (dwarf2_compute_name, open_dwo_file): Likewise.
2427         (process_enumeration_scope): Use std::vector.
2428         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
2429         (partial_die_info::fixup, dwarf2_start_subfile)
2430         (guess_full_die_structure_name, dwarf2_name): Likewise.
2431         (determine_prefix): Update.
2432         (guess_full_die_structure_name): Make return type const.
2433         (partial_die_full_name): Return unique_xmalloc_ptr.
2434         (DW_FIELD_ALLOC_CHUNK): Remove.
2435
2436 2020-01-07  Tom Tromey  <tromey@adacore.com>
2437
2438         PR build/24937:
2439         * stap-probe.c (class stap_static_probe_ops): Add constructor.
2440
2441 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
2442
2443         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
2444
2445 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2446
2447         * stack.c (print_frame_info): Move disassemble_next_line code
2448         inside source_print block.
2449
2450 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2451
2452         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
2453         gdb/signals.h, as we are now using native signal symbols.
2454
2455 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
2456
2457         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
2458         overflow by an early check of content vs threshold.
2459         * tui/tui-source.c (tui_source_window::line_is_displayed):
2460         Likewise.
2461
2462 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2463
2464         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
2465
2466 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
2467
2468         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
2469         export table if no section contains it's RVA.
2470
2471 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2472
2473         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
2474
2475 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
2476
2477         * source.c (print_source_lines_base): Set last_line_listed.
2478
2479 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
2480
2481         * tui/tui-disasm.c: Remove trailing spaces.
2482
2483 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2484             Pedro Alves  <palves@redhat.com>
2485
2486         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
2487         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
2488         (windows_gdb_signal_to_target): New function, uses the above
2489         enumeration to convert GDB internal signal codes to equivalent
2490         Windows codes.
2491         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
2492         * windows-nat.c: Include "gdb_wait.h".
2493         (get_windows_debug_event): Extract the fatal exception from the
2494         exit status and convert to the equivalent Posix signal number.
2495         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
2496         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
2497         * gdbsupport/gdb_wait.c: New file, implements
2498         windows_status_to_termsig.
2499         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
2500         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
2501
2502 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2503
2504         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
2505         show_layout.
2506
2507 2020-01-05  Luis Machado  <luis.machado@linaro.org>
2508
2509         * aarch64-linux-nat.c
2510         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
2511         and bfd_mach_aarch64.
2512
2513 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2514
2515         * ui-file.c (stdio_file::can_emit_style_escape)
2516         (tee_file::can_emit_style_escape): Ensure style is used also on
2517         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
2518         to gdb_stdout.
2519         * main.c (set_gdb_data_directory): Use file style to output the
2520         warning that the given pathname is not a directory.
2521         * top.c (show_history_filename, gdb_safe_append_history)
2522         (show_gdb_datadir): Use file style.
2523
2524 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
2525
2526         * solib-target.c (struct lm_info_target):
2527         Change offsets to be a unique_xmalloc_ptr.
2528         (solib_target_relocate_section_addresses): Update.
2529
2530 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
2531
2532         * windows-nat.c (windows_clear_solib): Free so_list linked list.
2533
2534 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2535
2536         * MAINTAINERS (Write After Approval): Add myself.
2537
2538 2020-01-02  Luis Machado  <luis.machado@linaro.org>
2539
2540         * proc-service.c (get_ps_regcache): Remove reference to obsolete
2541         Cell BE architecture.
2542         * target.h (struct target_ops) <thread_architecture>: Likewise.
2543
2544 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
2545
2546         * Makefile.in: Use INSTALL_PROGRAM_ENV.
2547
2548 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
2549
2550         * MAINTAINERS (Write After Approval): Add myself.
2551
2552 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2553
2554         * gdbarch.sh: Update copyright year range of generated files.
2555
2556 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2557
2558         Update copyright year range in all GDB files.
2559
2560 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2561
2562         * copyright.py: Convert to Python 3.
2563
2564 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2565
2566         * copyright.py: Adapt after move of gnulib directory from gdb
2567         directory to toplevel directory.
2568
2569 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2570
2571         * copyright.py (main): Exit if run from the wrong directory.
2572
2573 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2574
2575         * top.c (print_gdb_version): Change copyright year to 2020.
2576
2577 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2578
2579         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
2580
2581 For older changes see ChangeLog-2019.
2582 \f
2583 Local Variables:
2584 mode: change-log
2585 left-margin: 8
2586 fill-column: 74
2587 version-control: never
2588 coding: utf-8
2589 End: