gdb/ChangeLog

   1 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * f-lang.c (f_language_defn): Use f_print_typedef.
   4         * f-lang.h (f_print_typedef): Declare.
   5         * f-typeprint.c (f_print_typedef): Define.
   6
   7 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
   8
   9         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  10
  11 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * cli/cli-utils.c (info_print_options_defs): Delete.
  14         (make_info_print_options_def_group): Delete.
  15         (extract_info_print_options): Delete.
  16         (info_print_command_completer): Delete.
  17         (info_print_args_help): Add extra parameter, and optionally
  18         include text about -n flag.
  19         * cli/cli-utils.h (struct info_print_options): Delete.
  20         (extract_info_print_options): Delete declaration.
  21         (info_print_command_completer): Delete declaration.
  22         (info_print_args_help): Add extra parameter, extend header
  23         comment.
  24         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  25         search_symbols.
  26         * stack.c (struct info_print_options): New type.
  27         (info_print_options_defs): New file scoped variable.
  28         (make_info_print_options_def_group): New static function.
  29         (info_print_command_completer): New static function.
  30         (info_locals_command): Update to use new local functions.
  31         (info_args_command): Likewise.
  32         (_initialize_stack): Add extra parameter to calls to
  33         info_print_args_help.
  34         * symtab.c (search_symbols): Add extra parameter, use this to
  35         possibly excluse non-debug symbols.
  36         (symtab_symbol_info): Add extra parameter, which is passed on to
  37         search_symbols.
  38         (struct info_print_options): New type.
  39         (info_print_options_defs): New file scoped variable.
  40         (make_info_print_options_def_group): New static function.
  41         (info_print_command_completer): New static function.
  42         (info_variables_command): Update to use local functions, and pass
  43         extra parameter through to symtab_symbol_info.
  44         (info_functions_command): Likewise.
  45         (info_types_command): Pass additional argument through to
  46         symtab_symbol_info.
  47         (rbreak_command): Pass extra argument to search_symbols.
  48         (_initialize_symtab): Add extra arguments for calls to
  49         info_print_args_help, and update help text for 'info variables',
  50         'whereis', and 'info functions' commands.
  51         * symtab.h (search_symbols): Add extra argument to declaration.
  52         * NEWS: Mention new flags.
  53
  54 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
  55
  56         * symtab.c (lookup_static_symbol): Call the new function (and move
  57         it down to be next to lookup_global_symbol).
  58         (struct global_sym_lookup_data): Add block_enum member and rename to...
  59         (struct global_or_static_sym_lookup_data): ...this.
  60         (lookup_symbol_global_iterator_cb): Pass block_index instead of
  61         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
  62         (lookup_symbol_global_or_static_iterator_cb): ...this.
  63         (lookup_global_or_static_symbol): New function.
  64         (lookup_global_symbol): Call new function.
  65
  66 2019-08-26  Tom de Vries  <tdevries@suse.de>
  67
  68         PR c++/24852
  69         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
  70         when pc_probe.prob == NULL.
  71
  72 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  73
  74         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
  75         variable symbol_linkage to symbol_linkage_.
  76
  77 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  78
  79         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
  80         represent whether the symbol is static, dynamic, or we don't
  81         know.
  82
  83 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
  84
  85         * gdb/rx-tdep.c (rx_register_names): New.
  86         (rx_register_name): Delete.
  87         (rx_psw_type): Delete.
  88         (rx_fpsw_type): Delete.
  89         (rx_register_type): Delete.
  90         (rx_gdbarch_init): Convert target-descriptions.
  91         (_initialize_rx_tdep): Add initialize_tdesc_rx.
  92         * gdb/features/Makefile: Add rx.xml.
  93         * gdb/features/rx.xml: New.
  94         * gdb/features/rx.c: Generated.
  95         * gdb/NEWS: Mention target description support.
  96
  97 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 100         *slot_ptr.
 101
 102 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 103
 104         * configure.ac: Don't check for 'dlfcn.h' (moved to
 105         gdbsupport/common.m4).
 106         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 107         'gdbsupport/'.
 108         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 109         * compile/compile-c-support.c: Include
 110         'gdbsupport/gdb-dlfcn.h'.
 111         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 112         * gdb-dlfcn.c: Move to...
 113         * gdbsupport/gdb-dlfcn.c: ... here.
 114         * gdb-dlfcn.h: Move to...
 115         * gdbsupport/gdb-dlfcn.h: ... here.
 116
 117 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 118
 119         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 120         the offset field signed.
 121
 122 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 123
 124         * python/lib/gdb/__init__.py (_execute_file): New function.
 125         * python/python.c (python_run_simple_file): Call gdb._execute_file
 126         on Windows.
 127
 128 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 131         all uses as this was never set to anything but a zero value.
 132
 133 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 134
 135         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 136
 137 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 138
 139         * tui/tui-data.h (tui_gen_win_info): Add an =default
 140         move constructor, required by some GCC versions.
 141
 142 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 143
 144         * go32-nat.c (go32_sysinfo): Add hygon_p.
 145
 146 2019-08-20  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 149         line_from_reg_element_no, first_reg_element_no_inline,
 150         display_all_data, delete_data_content_windows,
 151         erase_data_content>: Now private.
 152
 153 2019-08-20  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 156         (tui_unhighlight_win, tui_highlight_win)
 157         (tui_win_info::make_window): Update.
 158         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 159
 160 2019-08-20  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 163         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 164         (MAX_PID_WIDTH): Move to tui-stack.c.
 165         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 166         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 167         (MAX_PID_WIDTH): Move from tui-data.h.
 168
 169 2019-08-20  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 172         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 173         (box_win): Update.
 174         (tui_gen_win_info::make_window): Rename from tui_make_window.
 175         (tui_win_info::make_window): New method.
 176         (tui_gen_win_info::make_visible): Update.
 177         * tui/tui-source.c (tui_source_window::set_contents): Update.
 178         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 179         (tui_data_window::display_registers_from): Update.
 180         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 181         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 182         Declare.
 183         <can_box>: Remove.
 184         <title>: Remove.
 185         (struct tui_win_info) <make_window>: Declare.
 186         <can_box>: Now virtual.
 187         <title>: New member.
 188         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 189         * tui/tui-command.c (tui_cmd_window::resize): Update.
 190
 191 2019-08-20  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 194         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 195         (tui_data_window::check_register_values): Update.
 196
 197 2019-08-20  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-regs.h (struct tui_data_window): Use
 200         DISABLE_COPY_AND_ASSIGN.
 201         <regs_content>: Change type, removing unique_ptr.
 202         <tui_data_window>: Add move constructor.
 203         * tui/tui-regs.c (tui_data_window::show_registers)
 204         (tui_data_window::show_register_group)
 205         (tui_data_window::display_registers_from)
 206         (tui_data_window::display_registers_from)
 207         (tui_data_window::first_data_item_displayed)
 208         (tui_data_window::delete_data_content_windows)
 209         (tui_data_window::rerender, tui_data_window::refresh_window)
 210         (tui_data_window::check_register_values): Update.
 211
 212 2019-08-20  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 215         show_register_group>: Declare.
 216         (tui_show_register_group): Don't declare.
 217         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 218         tui_show_registers.
 219         (tui_data_window::show_register_group): Rename from
 220         tui_show_register_group.
 221         (tui_data_window::check_register_values, tui_reg_command):
 222         Update.
 223         * tui/tui-layout.c (tui_set_layout): Update.
 224
 225 2019-08-20  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 228         Declare.
 229         (tui_check_register_values): Don't declare.
 230         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 231         from tui_check_register_values.
 232         * tui/tui-hooks.c (tui_register_changed): Update.
 233
 234 2019-08-20  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-regs.c (tui_reg_layout): Move later.
 237         (tui_show_registers): Don't enable TUI mode or change layout.
 238
 239 2019-08-20  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-regs.h (struct tui_data_item_window)
 242         <~tui_data_item_window>: Remove.
 243         <content>: Now a unique_xmalloc_ptr.
 244         * tui/tui-regs.c (tui_register_format): Return a
 245         unique_xmalloc_ptr.
 246         (tui_get_register): Update.
 247         (~tui_data_item_window): Remove.
 248         (tui_data_window::display_registers_from, tui_display_register):
 249         Update.
 250         * tui/tui-io.h (tui_expand_tabs): Update.
 251         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 252         Remove "col" parameter.
 253
 254 2019-08-20  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 257         field.
 258         * tui/tui-regs.c (~tui_data_item_window): Update.
 259
 260 2019-08-20  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 263         earlier.
 264
 265 2019-08-20  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 268
 269 2019-08-20  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-source.h (struct tui_source_window): Update.
 272         * tui/tui-regs.c (tui_show_registers): Update.
 273         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 274         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 275         (NO_REGS_STRING): Remove defines.
 276
 277 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 278
 279         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 280         unnecessary thread walk if remote doesn't support the packet.
 281
 282 2019-08-19  Tom Tromey  <tromey@adacore.com>
 283
 284         * python/py-value.c (value_has_field): Fix indentation.
 285
 286 2019-08-19  Tom Tromey  <tromey@adacore.com>
 287
 288         * printcmd.c (do_one_display, info_display_command): Update.
 289         * block.h (contained_in): Return bool.  Add allow_nested
 290         parameter.
 291         * block.c (contained_in): Return bool.  Add allow_nested
 292         parameter.
 293
 294 2019-08-19  Tom Tromey  <tom@tromey.com>
 295
 296         * configure: Rebuild.
 297         * configure.ac: Disallow the combination of -static-libstdc++ and
 298         source highlight.
 299         * source-cache.c (get_language_name): Handle rust.
 300         (source_cache::get_source_lines): Ignore highlighting exceptions.
 301
 302 2019-08-16  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 305         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 306         (struct tui_source_window_base) <make_visible, refresh_window,
 307         resize>: Remove methods.
 308         <execution_info>: Remove field.
 309         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 310         (tui_show_source_line, tui_source_window_base)
 311         (~tui_source_window_base): Update.
 312         (tui_source_window_base::resize)
 313         (tui_source_window_base::make_visible)
 314         (tui_source_window_base::refresh_window): Remove.
 315         (tui_source_window_base::update_exec_info): Update.
 316         * tui/tui-source.c (tui_source_window::set_contents): Update.
 317         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 318
 319 2019-08-16  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 322         deprecated_query_hook.
 323
 324 2019-08-16  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 327         (tui_update_source_windows_with_line): Update.
 328         * tui/tui-source.h (struct tui_source_window)
 329         <show_symtab_source>: Declare.
 330         (tui_show_symtab_source): Don't declare.
 331         * tui/tui-source.c (tui_show_symtab_source): Rename from
 332         tui_show_symtab_source.
 333
 334 2019-08-16  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-winsource.h (struct tui_source_window_base)
 337         <set_contents>: Declare.
 338         * tui/tui-winsource.c
 339         (tui_source_window_base::update_source_window_as_is): Update.
 340         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 341         Declare.
 342         (tui_set_source_content): Don't declare.
 343         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 344         tui_set_source_content.
 345         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 346         Declare.
 347         (tui_set_disassem_content): Don't declare.
 348         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 349         tui_set_disassem_content.
 350
 351 2019-08-16  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-winsource.h (struct tui_source_window_base)
 354         <update_breakpoint_info>: Declare.
 355         (tui_update_breakpoint_info): Don't declare.
 356         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 357         (tui_update_all_breakpoint_info): Update.
 358         (tui_source_window_base::update_breakpoint_info): Rename from
 359         tui_update_breakpoint_info.
 360         (tui_source_window_base::update_exec_info): Update.
 361
 362 2019-08-16  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-winsource.h (struct tui_source_window_base)
 365         <update_source_window>: Declare.
 366         (tui_update_source_window): Don't declare.
 367         * tui/tui-winsource.c
 368         (tui_source_window_base::update_source_window): Rename from
 369         tui_update_source_window.
 370         (tui_source_window_base::rerender): Update.
 371         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 372         * tui/tui-disasm.c (tui_show_disassem)
 373         (tui_show_disassem_and_update_source)
 374         (tui_disasm_window::maybe_update): Update.
 375
 376 2019-08-16  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.h (struct tui_source_window_base)
 379         <update_source_window_as_is>: Declare.
 380         (tui_update_source_window_as_is): Don't declare.
 381         * tui/tui-winsource.c (tui_update_source_window): Update
 382         (tui_source_window_base::update_source_window_as_is): Rename from
 383         tui_update_source_window_as_is.
 384         (tui_source_window_base::refill): Update.
 385         * tui/tui-source.c (tui_show_symtab_source): Update.
 386         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 387         Update.
 388
 389 2019-08-16  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-winsource.h (tui_update_source_window)
 392         (tui_update_source_window_as_is): Remove "noerror" parameter.
 393         * tui/tui-winsource.c (tui_update_source_window)
 394         (tui_update_source_window_as_is): Remove "noerror" parameter.
 395         (tui_update_source_windows_with_addr)
 396         (tui_update_source_windows_with_line)
 397         (tui_source_window_base::rerender)
 398         (tui_source_window_base::refill): Update.
 399         * tui/tui-source.h (tui_set_source_content)
 400         (tui_show_symtab_source): Remove "noerror" parameter.
 401         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 402         parameter.
 403         (tui_show_symtab_source): Likewise.
 404         (tui_source_window::maybe_update): Update.
 405         * tui/tui-disasm.c (tui_show_disassem)
 406         (tui_show_disassem_and_update_source)
 407         (tui_disasm_window::do_scroll_vertical)
 408         (tui_disasm_window::maybe_update): Update.
 409
 410 2019-08-16  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui.c (tui_is_window_visible): Update.
 413         * tui/tui-wingeneral.c (tui_make_window)
 414         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 415         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 416         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 417         (tui_set_win_height_command, parse_scrolling_args): Update.
 418         * tui/tui-source.c (tui_source_window::style_changed): Update.
 419         * tui/tui-regs.c (tui_show_registers)
 420         (tui_data_window::first_data_item_displayed)
 421         (tui_data_window::delete_data_content_windows)
 422         (tui_check_register_values, tui_reg_command): Update.
 423         * tui/tui-disasm.c (tui_show_disassem): Update.
 424         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 425         method.
 426         <is_visible>: Remove field.
 427         * tui/tui-data.c (tui_next_win, tui_prev_win)
 428         (tui_delete_invisible_windows): Update.
 429
 430 2019-08-16  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-winsource.h (struct tui_source_window_base)
 433         <m_has_locator>: Remove.
 434         * tui/tui-layout.c (show_source_disasm_command, show_data)
 435         (show_source_or_disasm_and_command): Update.
 436
 437 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 438
 439         * NEWS (Other MI changes): New subsection.
 440         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 441         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 442         * arch-utils.c (default_get_pc_address_flags): New function.
 443         * arch-utils.h (default_get_pc_address_flags): New declaration.
 444         * gdbarch.sh: Add get_pc_address_flags.
 445         * gdbarch.c: Regenerate.
 446         * gdbarch.h: Likewise.
 447         * stack.c (print_pc): New function.
 448         (print_frame_info) (print_frame): Call print_pc.
 449
 450 2019-08-16  Tom de Vries  <tdevries@suse.de>
 451
 452         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 453         print_objfile_section_info.
 454
 455 2019-08-15  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 458         calling update_cmdwin_start_line.
 459         * tui/tui-winsource.h (struct tui_source_window_base)
 460         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 461         <rerender>: Declare.
 462         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 463         Call rerender.
 464         (tui_source_window_base::set_new_height): Remove.
 465         (tui_source_window_base::rerender): Rename from
 466         do_make_visible_with_new_height.
 467         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 468         resize method.
 469         (tui_win_info::make_invisible_and_set_new_height)
 470         (tui_win_info::make_visible_with_new_height): Remove.
 471         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 472         Declare.
 473         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 474         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 475         do_make_visible_with_new_height>: Don't declare.
 476         <rerender>: Declare.
 477         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 478         set_new_height.
 479         (tui_data_window::do_make_visible_with_new_height): Remove.
 480         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 481         call tui_show_locator_content.
 482         (tui_gen_win_info::resize): Call rerender.
 483         (show_source_or_disasm_and_command): Don't call
 484         tui_show_locator_content.
 485         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 486         method.
 487         (struct tui_win_info) <rerender>: Declare.
 488         <set_new_height, make_invisible_and_set_new_height,
 489         make_visible_with_new_height>: Don't declare.
 490         * tui/tui-data.c (tui_win_list::rerender): New method.
 491         * tui/tui-command.h (struct tui_cmd_window)
 492         <do_make_visible_with_new_height>: Don't declare.
 493         * tui/tui-command.c
 494         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 495
 496 2019-08-15  Tom Tromey  <tromey@adacore.com>
 497
 498         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 499         * ada-lang.c (ada_enum_name): Likewise.
 500
 501 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 502
 503         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 504         leading underscore.
 505         (GdbOutputErrorFile): Likewise.
 506         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 507         accordingly.
 508         (execute_unwinders): Rename to have a leading underscore.
 509         (auto_load_packages): Likewise.
 510         (global scope): Adjust call to auto_load_packages accordingly.
 511         (GdbSetPythonDirectory): Likewise.
 512         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 513         instead of execute_unwinders.
 514
 515 2019-08-15  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 518         (show_data): Don't change window visibility.
 519         (tui_gen_win_info::resize): Remove special case for command
 520         window.  Use wresize, when available.
 521         (show_source_or_disasm_and_command): Don't change window
 522         visibility.
 523         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 524         <make_visible>: New method.
 525         * tui/tui-command.c (tui_cmd_window::resize): New method.
 526
 527 2019-08-15  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 530         (struct tui_source_windows): New.
 531         * tui/tui-winsource.c (tui_display_main): Update.
 532         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 533         (new_height_ok, parse_scrolling_args): Update.
 534         * tui/tui-layout.c (show_layout, show_data): Update.
 535         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 536         (tui_add_to_source_windows): Don't declare.
 537         * tui/tui-data.c (source_windows, tui_source_windows)
 538         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 539
 540 2019-08-15  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 543         Rename from reset.
 544         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 545         * tui/tui-layout.c (show_source_disasm_command, show_data):
 546         Update.
 547         (tui_gen_win_info::resize): Rename.
 548         (show_source_or_disasm_and_command): Update.
 549         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 550         reset.
 551
 552 2019-08-15  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 555         * tui/tui-interp.c (tui_interp::init): Don't call
 556         tui_initialize_static_data.
 557         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 558
 559 2019-08-15  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 562         examine tui_win_list.
 563
 564 2019-08-15  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 567         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 568         tui_clear_source_content.
 569         (tui_clear_source_content): Remove.
 570         (tui_source_window_base::do_erase_source_content): Hoist call to
 571         content.clear().
 572         * tui/tui-stack.c (tui_show_frame_info): Don't call
 573         tui_clear_source_content.
 574
 575 2019-08-15  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-winsource.h (struct tui_source_window_base)
 578         <do_erase_source_content>: New method.
 579         <erase_source_content>: New method.
 580         (tui_erase_source_content): Don't declare.
 581         * tui/tui-winsource.c (tui_clear_source_content): Update.
 582         (tui_source_window_base::do_erase_source_content): Rename from
 583         tui_erase_source_content.
 584         (tui_source_window_base::show_source_content): Update.
 585         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 586         * tui/tui-source.h (struct tui_source_window)
 587         <erase_source_content>: New method.
 588         * tui/tui-disasm.h (struct tui_disasm_window)
 589         <erase_source_content>: New method.
 590
 591 2019-08-15  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 594         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 595         constructor.
 596         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 597         * tui/tui-source.c (tui_set_source_content): Update.
 598         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 599
 600 2019-08-15  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 603         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 604         tui-source.c.
 605         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 606         Declare.
 607         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 608         method.
 609         (tui_source_window::maybe_update): Update.
 610
 611 2019-08-15  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 614         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 615         tui-disasm.c.
 616         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 617         Declare.
 618         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 619         method.
 620         (tui_disasm_window::maybe_update): Update.
 621
 622 2019-08-15  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.h (struct tui_source_window_base)
 625         <maybe_update>: Declare.
 626         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 627         method.
 628         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 629         Declare.
 630         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 631         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 632         Declare.
 633         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 634
 635 2019-08-15  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 638
 639 2019-08-15  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-wingeneral.c: Include tui-stack.h.
 642         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 643         (struct tui_locator_window): Move from tui-data.h.
 644         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 645         (tui_initialize_static_data): Move from tui-data.c.
 646         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 647         (struct tui_locator_window): Move to tui-stack.c.
 648         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 649         (tui_initialize_static_data): Move to tui-stack.c.
 650
 651 2019-08-15  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-layout.c (show_source_disasm_command)
 654         (show_source_or_disasm_and_command): Use make_visible method, not
 655         tui_make_window.
 656         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 657         Remove.
 658
 659 2019-08-15  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-wingeneral.h (tui_make_window): Update.
 662         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 663         parameter.
 664         (tui_gen_win_info::make_visible): Update.
 665         * tui/tui-regs.c (tui_data_window::display_registers_from):
 666         Update.
 667         * tui/tui-layout.c (show_source_disasm_command)
 668         (show_source_or_disasm_and_command): Update.
 669         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 670         (enum tui_box): Remove.
 671         (struct tui_win_info) <can_box>: New method.
 672         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 673         method.
 674
 675 2019-08-15  Tom de Vries  <tdevries@suse.de>
 676
 677         * linux-nat-trad.c: Include gdbarch.h.
 678
 679 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 680
 681         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 682         register sizes.
 683
 684 2019-08-14  Tom Tromey  <tromey@adacore.com>
 685
 686         * darwin-nat.c: Include gdbarch.h.
 687         * darwin-nat-info.c: Include gdbarch.h.
 688
 689 2019-08-13  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 692         Remove.
 693         * tui/tui-data.c (tui_initialize_static_data): Update.
 694
 695 2019-08-13  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-winsource.h (struct tui_exec_info_window)
 698         <~tui_exec_info_window, maybe_allocate_content, get_content,
 699         m_content>: Remove.
 700         (struct tui_source_window_base) <set_exec_info_content,
 701         show_exec_info_content>: Don't declare.
 702         * tui/tui-winsource.c
 703         (tui_exec_info_window::maybe_allocate_content): Remove.
 704         (tui_source_window_base::update_exec_info): Rename from
 705         set_exec_info_content.
 706         (tui_source_window_base::show_exec_info_content)
 707         (tui_source_window_base::update_exec_info): Remove.
 708
 709 2019-08-13  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 712         declare.
 713         * tui/tui-winsource.c (tui_update_source_window_as_is)
 714         (tui_update_source_windows_with_addr, tui_erase_source_content):
 715         Update.
 716         (tui_clear_exec_info_content): Remove.
 717
 718 2019-08-13  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 721         declare.
 722         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 723         call tui_erase_exec_info_content.
 724         (tui_clear_exec_info_content): Rename from
 725         tui_erase_exec_info_content.
 726         (tui_clear_exec_info_content): Delete.
 727
 728 2019-08-13  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-winsource.h (struct tui_source_window_base)
 731         <show_exec_info_content>: Declare.
 732         (tui_show_exec_info_content): Don't declare.
 733         * tui/tui-winsource.c
 734         (tui_source_window_base::show_exec_info_content): Rename from
 735         tui_show_exec_info_content.
 736         (tui_source_window_base::update_exec_info): Update.
 737
 738 2019-08-13  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 741         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 742         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 743         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 744         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 745         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 746         ... here.
 747
 748 2019-08-13  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-winsource.h (struct tui_source_window_base)
 751         <update_exec_info>: Declare.
 752         (tui_update_exec_info): Don't declare.
 753         * tui/tui-winsource.c (tui_update_source_window_as_is)
 754         (tui_source_window_base::refresh_all)
 755         (tui_update_all_breakpoint_info): Update.
 756         (tui_source_window_base::update_exec_info): Rename from
 757         tui_update_exec_info.
 758         * tui/tui-stack.c (tui_show_frame_info): Update.
 759
 760 2019-08-13  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-winsource.h (struct tui_source_window_base)
 763         <set_exec_info_content>: Declare.
 764         (tui_set_exec_info_content): Don't declare.
 765         * tui/tui-winsource.c
 766         (tui_source_window_base::set_exec_info_content): Rename from
 767         tui_set_exec_info_content.
 768         (tui_update_exec_info): Update.
 769
 770 2019-08-13  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-winsource.h (struct tui_source_window_base)
 773         <show_source_content>: Declare.
 774         (tui_show_source_content): Don't declare.
 775         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 776         (tui_source_window_base::show_source_content): Rename from
 777         tui_show_source_content.
 778         (tui_source_window_base::refresh_all): Update.
 779         * tui/tui-layout.c (show_source_disasm_command)
 780         (show_source_or_disasm_and_command): Update.
 781
 782 2019-08-13  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-winsource.c (tui_erase_source_content)
 785         (tui_show_source_content, tui_source_window_base::refresh_all):
 786         Update.
 787         * tui/tui-wingeneral.h
 788         (tui_check_and_display_highlight_if_needed): Don't declare.
 789         * tui/tui-wingeneral.c
 790         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 791         check_and_display_highlight_if_needed.
 792         * tui/tui-win.c (tui_rehighlight_all)
 793         (tui_win_info::make_visible_with_new_height): Update.
 794         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 795         (tui_data_window::erase_data_content)
 796         (tui_data_window::display_all_data): Update.
 797         * tui/tui-data.h (struct tui_win_info)
 798         <check_and_display_highlight_if_needed>: Declare.
 799
 800 2019-08-13  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-win.c (tui_resize_all): Call
 803         tui_delete_invisible_windows.
 804         * tui/tui-layout.c (show_layout): Call
 805         tui_delete_invisible_windows.
 806         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 807         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 808
 809 2019-08-13  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 812         tui_add_win_to_layout.
 813
 814 2019-08-13  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 817         * tui/tui-layout.c (tui_default_win_height): Now static.
 818
 819 2019-08-13  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 822         single switch.
 823         (show_source_disasm_command, show_source_or_disasm_and_command):
 824         Don't check current layout.
 825
 826 2019-08-13  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-wingeneral.c (make_all_visible): Remove.
 829         (tui_make_all_invisible): Simplify.
 830         * tui/tui-layout.c (tui_make_all_invisible): Move from
 831         tui-wingeneral.c; simplify.
 832         (show_layout): Hoist call to tui_make_all_invisible.
 833         (show_data): Don't call tui_make_all_invisible.
 834
 835 2019-08-13  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 838         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 839
 840 2019-08-13  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 843         tui-data.c.
 844         (show_source_disasm_command, show_data)
 845         (show_source_or_disasm_and_command): Don't use
 846         tui_set_current_layout_to.
 847         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 848         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 849         tui-layout.c.
 850         (tui_set_current_layout_to): Remove.
 851
 852 2019-08-13  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-layout.c (tui_set_layout): Update.
 855         * tui/tui-data.h (struct tui_layout_def): Remove.
 856         (tui_layout_def): Don't declare.
 857         * tui/tui-data.c (layout_def): Remove.
 858         (tui_layout_def): Remove.
 859
 860 2019-08-13  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-winsource.h (struct tui_source_window_base)
 863         <clear_detail>: No longer "override".
 864         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 865         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 866         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 867         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 868         Remove.
 869         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 870
 871 2019-08-13  Tom Tromey  <tromey@adacore.com>
 872
 873         * tracepoint.c: Don't include readline.h or history.h.
 874
 875 2019-08-12  Tom Tromey  <tom@tromey.com>
 876
 877         * configure: Rebuild.
 878         * configure.ac: Check for readline 7.
 879         * NEWS: Mention readline 7 requirement.
 880         * README: Update.
 881
 882 2019-08-12  Tom Tromey  <tom@tromey.com>
 883
 884         * mingw-hdep.c (gdb_select): Remove readline hack.
 885
 886 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 887
 888         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 889         when the function fails.
 890
 891 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 892
 893         * s390-tdep.c (s390_type_align): New function.
 894         (s390_gdbarch_init): Set it as type_align gdbarch method.
 895
 896 2019-08-09  Tom de Vries  <tdevries@suse.de>
 897
 898         PR gdb/24591
 899         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 900         pc_low with relocation offset.
 901
 902 2019-08-07  Tom Tromey  <tromey@adacore.com>
 903
 904         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 905         (print_frame_args): Update.
 906         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 907         Update.
 908         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 909         * frame.h (struct frame_arg): Add initializers.
 910         <error>: Now a unique_xmalloc_ptr.
 911
 912 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 913
 914         * NEWS: Expand the Pointer Authentication entry.
 915         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 916         (aarch64_frame_unmask_lr): ... to this.
 917         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 918         Call aarch64_frame_unmask_lr.
 919         * frame.c (struct frame_info): Add "masked" variable.
 920         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 921         (fprint_frame): Check for masked pc.
 922         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 923         declarations.
 924         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 925         * stack.c (print_frame): Check for masked pc.
 926
 927 2019-08-06  Tom Tromey  <tom@tromey.com>
 928
 929         * stabsread.c (patch_block_stabs, read_one_struct_field)
 930         (read_enum_type): Use obstack_strndup.
 931         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 932         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 933         * dwarf2read.c (guess_full_die_structure_name)
 934         (anonymous_struct_prefix): Use obstack_strndup.
 935         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 936         * c-exp.y (yylex): Use obstack_strndup.
 937         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 938         (write_var_or_type): Use obstack_strndup.
 939
 940 2019-08-06  Tom Tromey  <tom@tromey.com>
 941
 942         * symfile.c (reread_symbols): Use obstack_strdup.
 943         * stabsread.c (read_type): Use obstack_strdup.
 944         * gdb_obstack.h (obstack_strdup): New overload.
 945         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 946         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 947         (dwarf2_canonicalize_name): Use obstack_strdup.
 948         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 949         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 950         Use obstack_strdup.
 951
 952 2019-08-06  Tom Tromey  <tom@tromey.com>
 953
 954         * gdb_obstack.h (obstack_strdup): Define.
 955         * gdb_obstack.c (obstack_strdup): Don't define.
 956
 957 2019-08-06  Tom Tromey  <tom@tromey.com>
 958
 959         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 960         obstack_strdup.
 961         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 962         obstack_strdup.
 963         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 964         * stabsread.c (common_block_start): Use obstack_strdup.
 965         * objfiles.c (set_objfile_main_name, objfile): Use
 966         obstack_strdup.
 967         * namespace.c (add_using_directive): Use obstack_strdup.
 968         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 969         * jit.c (finalize_symtab): Use obstack_strdup.
 970         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 971         (guess_partial_die_structure_name, partial_die_info::fixup)
 972         (dwarf2_name): Use obstack_strdup.
 973         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 974         obstack_strdup.
 975         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 976         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 977         obstack_strdup.
 978         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 979
 980 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 981
 982         * unittests/help-doc-selftests.c: New file.
 983         * Makefile.in: Add the new file.
 984
 985 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 986
 987         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 988         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 989         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 990         the trailing '.' is not output, and the first character is uppercased.
 991         (print_help_for_command): Update call to print_doc_line.
 992         (print_doc_of_command): Likewise.
 993         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 994         * cli/cli-option.c (append_indented_doc): Do not append newline.
 995         (build_help_option): Append newline after first appended_indented_doc
 996         only if a second call is done.
 997         (build_help): Append 2 new lines before each option, except the first
 998         one.
 999         * compile/compile.c (_initialize_compile): Add new lines after
1000         %OPTIONS%, when not at the end of the help.
1001         Change help doc or code
1002         producing the help doc to respect the invariants.
1003         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1004         Also removed the new line after 'Options:', as all other commands
1005         do not put an empty line between 'Options:' and the first option.
1006         * printcmd.c (_initialize_printcmd): Likewise.
1007         * stack.c (_initialize_stack): Likewise.
1008         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1009         incorrectly telling COMMAND is optional.
1010         * ada-lang.c (_initialize_ada_language): Change help doc or code
1011         producing the help doc to respect the invariants.
1012         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1013         * breakpoint.c (_initialize_breakpoint): Likewise.
1014         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1015         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1016         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1017         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1018         _initialize_cli_style): Likewise.
1019         * corelow.c (core_target_info): Likewise.
1020         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1021         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1022         * filesystem.c (_initialize_filesystem): Likewise.
1023         * frame.c (_initialize_frame): Likewise.
1024         * gnu-nat.c (add_task_commands): Likewise.
1025         * infcall.c (_initialize_infcall): Likewise.
1026         * infcmd.c (_initialize_infcmd): Likewise.
1027         * interps.c (_initialize_interpreter): Likewise.
1028         * language.c (_initialize_language): Likewise.
1029         * linux-fork.c (_initialize_linux_fork): Likewise.
1030         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1031         * maint.c (_initialize_maint_cmds): Likewise.
1032         * memattr.c (_initialize_mem): Likewise.
1033         * printcmd.c (_initialize_printcmd): Likewise.
1034         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1035         _RegEx): Likewise.
1036         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1037         * record-btrace.c (_initialize_record_btrace): Likewise.
1038         * record-full.c (_initialize_record_full): Likewise.
1039         * record.c (_initialize_record): Likewise.
1040         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1041         * regcache.c (_initialize_regcache): Likewise.
1042         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1043         _initialize_remote): Likewise.
1044         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1045         * serial.c (_initialize_serial): Likewise.
1046         * skip.c (_initialize_step_skip): Likewise.
1047         * source.c (_initialize_source): Likewise.
1048         * stack.c (_initialize_stack): Likewise.
1049         * symfile.c (_initialize_symfile): Likewise.
1050         * symtab.c (_initialize_symtab): Likewise.
1051         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1052         * top.c (init_main): Likewise.
1053         * tracefile-tfile.c (tfile_target_info): Likewise.
1054         * tracepoint.c (_initialize_tracepoint): Likewise.
1055         * tui/tui-win.c (_initialize_tui_win): Likewise.
1056         * utils.c (add_internal_problem_command): Likewise.
1057         * valprint.c (value_print_option_defs): Likewise.
1058
1059 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1060
1061         PR build/24886
1062         * configure.ac: Drop enable-libmcheck support.
1063         * configure, config.in: Rebuild.
1064         * libmcheck.m4: Remove.
1065         * acinclude.m4: Don't include it.
1066         * Makefile.in: Don't distribute it.
1067         * top.c (print_gdb_configuration): Don't mention it.
1068
1069 2019-08-06  Tom Tromey  <tom@tromey.com>
1070
1071         * utils.c (set_output_style): Sometimes pass stream to
1072         emit_style_escape.
1073         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1074         * record-btrace.c (btrace_insn_history): Update.
1075         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1076         method.
1077         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1078         Update initializers.
1079         <m_uiout>: New field.
1080         <m_di>: Move lower.
1081         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1082         Remove "uiout" parameter.
1083         (dump_insns): Update.
1084         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1085         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1086
1087 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1088
1089         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1090         (error_in_psymtab_expansion): Likewise.
1091         (lookup_symbol_via_quick_fns): Likewise.
1092         (basic_lookup_transparent_type_quick): Likewise.
1093         (basic_lookup_transparent_type_1): Likewise.
1094
1095 2019-08-06  Tom Tromey  <tromey@adacore.com>
1096
1097         * source.c (last_source_error): Now bool.
1098         (print_source_lines_base): Make "noprint" bool.  Only open
1099         source file when last_source_visited changes.
1100
1101 2019-08-06  Tom Tromey  <tromey@adacore.com>
1102
1103         * annotate.c (annotate_source_line): Use g_source_cache.
1104         * source-cache.c (source_cache::get_plain_source_lines): Change
1105         parameters.  Populate m_offset_cache.
1106         (source_cache::ensure): New method.
1107         (source_cache::get_line_charpos): New method.
1108         (extract_lines): Move lower.  Change parameters.
1109         (source_cache::get_source_lines): Move lower.
1110         * source-cache.h (class source_cache): Update comment.
1111         <get_line_charpos>: New method.
1112         <get_source_lines>: Update comment.
1113         <clear>: Clear m_offset_cache.
1114         <get_plain_source_lines>: Change parameters.
1115         <ensure>: New method
1116         <m_offset_cache>: New member.
1117         * source.c (forget_cached_source_info_for_objfile): Update.
1118         (info_source_command): Use g_source_cache.
1119         (find_source_lines, open_source_file_with_line_charpos): Remove.
1120         (print_source_lines_base, search_command_helper): Use g_source_cache.
1121         * source.h (open_source_file_with_line_charpos): Don't declare.
1122         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1123         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1124         Use g_source_cache.
1125
1126 2019-08-06  Tom Tromey  <tromey@adacore.com>
1127
1128         * source-cache.c (source_cache::get_plain_source_lines):
1129         Remove "first_line" and "last_line" parameters.
1130         (source_cache::get_source_lines): Cache plain text.
1131         * source-cache.h (class source_cache)
1132         <get_plain_source_lines>: Update.
1133
1134 2019-08-06  Tom Tromey  <tromey@adacore.com>
1135
1136         * source-cache.c (extract_lines): No longer a method.
1137         Changed type of parameter.  Include final newline.
1138         (selftests::extract_lines_test): New function.
1139         (_initialize_source_cache): Likewise.
1140         * source-cache.h (class source_cache)
1141         <extract_lines>: Don't declare.
1142
1143 2019-08-06  Tom Tromey  <tromey@adacore.com>
1144
1145         * breakpoint.c (init_breakpoint_sal): Update.
1146         (breakpoint): Update.
1147         * breakpoint.h (struct breakpoint) <filter>: Now a
1148         unique_xmalloc_ptr.
1149
1150 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1151
1152         * NEWS: Mention dictionary access on blocks.
1153         * python/py-block.c (blpy_getitem): New function.
1154         (block_object_as_mapping): New struct.
1155         (block_object_type): Use new struct for tp_as_mapping field.
1156
1157 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1158
1159         * objfiles.h (objfile): Add a comment describing partial symbols.
1160
1161 2019-08-05  Tom Tromey  <tromey@adacore.com>
1162
1163         * compile/compile.c (_initialize_compile): Use _(), not N_().
1164         * thread.c (_initialize_thread): Use _(), not N_().
1165         * stack.c (_initialize_stack): Use _(), not N_().
1166         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1167
1168 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1169
1170         * dwarf2read.c (struct dw2_symtab_iterator):
1171         <want_specific_block>: Remove.
1172         <block_index>: Change type to gdb::optional.
1173         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1174         change type of BLOCK_INDEX parameter to gdb::optional.
1175         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1176         (dw2_lookup_symbol): Don't pass argument for
1177         WANT_SPECIFIC_BLOCK.
1178         (dw2_expand_symtabs_for_function): Don't pass argument for
1179         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1180         (class dw2_debug_names_iterator)
1181         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1182         parameter, change BLOCK_INDEX type to gdb::optional.
1183         <m_want_specific_block>: Remove.
1184         <m_block_index>: Change type to gdb::optional.
1185         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1186         gdb::optional.  Re-write in function of gdb::optional.
1187         (dw2_debug_names_lookup_symbol): Don't pass argument for
1188         WANT_SPECIFIC_BLOCK.
1189         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1190         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1191         BLOCK_INDEX.
1192
1193 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1194
1195         * NEWS: Mention changes to "info sources" command.
1196
1197 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1198
1199         * symtab.c (filename_partial_match_opts): New struct type.
1200         (struct output_source_filename_data): New members
1201         regexp, c_regexp, partial_match.
1202         (output_source_filename): Use new members to decide to print file.
1203         (info_sources_option_defs): New variable.
1204         (make_info_sources_options_def_group, print_info_sources_header,
1205         info_sources_command_completer):
1206         New functions.
1207         (info_sources_command): Read new optional arguments.
1208         (_initialize_symtab): Update info sources help.
1209
1210 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1211
1212         * ada-lang.c (exception_support_info_v0): Renamed from...
1213         (default_exception_support_info): ... this.  Create new
1214         definition for v1.
1215         (ada_has_this_exception_support): Look up catch_handlers_sym.
1216         (ada_exception_support_info_sniffer): Try v0 after default.
1217
1218 2019-08-01  Tom Tromey  <tromey@adacore.com>
1219
1220         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1221         gdbarch.h.
1222
1223 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1224
1225         * s12z-tdep.c: Fix include path for s12z-opc.h.
1226
1227 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1228
1229         * NEWS: Require GNU make 3.82.
1230
1231 2019-07-16  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1234         declare.
1235
1236 2019-07-30  Tom Tromey  <tromey@adacore.com>
1237
1238         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1239
1240 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1241
1242         * printcmd.c (print_address_symbolic): Print negative offsets.
1243         (build_address_symbolic): Force signed arithmetic when computing
1244         offset.
1245
1246 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1247
1248         PR/24474: Add a function to lookup static variables.
1249         * NEWS: Mention this new function.
1250         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1251         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1252         * python/python.c (python_GdbMethods): Add new function.
1253
1254 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1255
1256         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1257         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1258         (objfpy_lookup_static_symbol): New function.
1259         (objfile_object_methods): Add new functions.
1260
1261 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1262
1263         * NEWS: Mention 'set|show print frame-info'.  Mention new
1264         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1265         backtrace argument.  Mention that python frame filtering code
1266         is now consistent with what 'backtrace' command prints.
1267
1268 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1269
1270         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1271         comments.
1272         (print_frame_info_auto, print_frame_info_source_line,
1273         print_frame_info_location, print_frame_info_source_and_location,
1274         print_frame_info_location_and_address, print_frame_info_short_location):
1275         New declarations.
1276         (struct frame_print_options): New member print_frame_info.
1277         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1278         * stack.h (get_user_print_what_frame_info): New declaration.
1279         (frame_show_address): New declaration.
1280         * stack.c (print_frame_arguments_choices): New value 'presence'.
1281         (print_frame_info_auto, print_frame_info_source_line,
1282         print_frame_info_location, print_frame_info_source_and_location,
1283         print_frame_info_location_and_address, print_frame_info_short_location,
1284         print_frame_info_choices, print_frame_info_print_what): New definitions.
1285         (print_frame_args): Only print dots for args if print frame-arguments
1286         is 'presence'.
1287         (frame_print_option_defs): New element for "frame-info".
1288         (get_user_print_what_frame_info): New function.
1289         (frame_show_address): Make non static.  Move comment to stack.h.
1290         (print_frame_info_to_print_what): New function.
1291         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1292         to decide what to print.
1293         (backtrace_command_1): Handle the new print_frame_arguments_presence
1294         value.
1295         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1296         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1297         (py_print_frame): In non-mi mode, use LOCATION as default for
1298         print_what, similarly to frame information printed directly by
1299         backtrace command. Handle frame-info user option in non MI mode.
1300
1301 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1302
1303         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1304         Add case for debugging 32-bit target on 64-bit host.  Revise
1305         comment.
1306
1307 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1308
1309         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1310         instead of find_function_entry_range_from_pc.
1311
1312 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1313
1314         * stack.c (find_frame_funname): Remove code which preferred
1315         minsym over symtab sym in "certain pathological cases".
1316
1317         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1318         parameter.  Change type of "do_demangle" to bool.
1319         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1320         Pass suitable "prefer_sym_over_minsym" flag to
1321         build_address_symbolic().  Don't output "+" for negative offsets.
1322         * printcmd.c (print_address_symbolic): Update invocation of
1323         build_address_symbolic to include a "prefer_sym_over_minsym"
1324         flag.
1325         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1326         Restrict cases in which use of minimal symbol is preferred to that
1327         of a found symbol.  Update comments.
1328
1329         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1330         for entry pc when entry pc is out of range for that FDE.
1331
1332 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1333
1334         PR gdb/24839:
1335         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1336         type.
1337
1338 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1339
1340         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1341         this function's Python signature.
1342
1343
1344 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1345
1346         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1347         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1348         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1349         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1350         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1351
1352
1353 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1354
1355         * h8300-tdep.c (h8300_register_name_common): New.
1356         h8300_register_name): Use h8300_register_name_common.
1357         (h8300s_register_name): Likewise.
1358         (h8300sx_register_name): Likewise.
1359         (h8300h_register_nam): New.
1360         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1361
1362
1363 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1364
1365         * arm-tdep.c (arm_skip_cmse_entry): New function.
1366         (arm_is_sgstubs_section): New function.
1367         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1368
1369 2019-07-22  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1372         Don't self-assign.
1373
1374 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1375
1376         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1377         type_print.
1378
1379 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1382         so that GDB doesn't match any msymbols when searching in the
1383         TYPES_DOMAIN.
1384         (print_symbol_info): Print using typedef_print or type_print based
1385         on the type of the symbol.  Add updated FIXME comment moved from...
1386         (_initialize_symtab): ... move and update FIXME comment to above.
1387
1388 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * NEWS: Mention adding -q option to "info types".
1391         * symtab.c (struct info_types_options): New struct.
1392         (info_types_options_defs): New variable.
1393         (make_info_types_options_def_group): New function.
1394         (info_types_command): Use gdb::option framework to parse options.
1395         (info_types_command_completer): New function.
1396         (_initialize_symtab): Extend the help text on "info types" and
1397         register command completer.
1398
1399 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1400
1401         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1402         (lookup_symbol_in_objfile): Change int to block_enum and add a
1403         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1404
1405 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1406
1407         * MAINTAINERS (Write After Approval): Add self.
1408
1409 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1410
1411         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1412         instruction to the dummy code region.
1413
1414 2019-07-19  Tom Tromey  <tromey@adacore.com>
1415
1416         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1417         (ARGSUSED, PARAMS, __func__): Remove rules.
1418
1419 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1420
1421         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1422         * features/arm/arm-with-iwmmxt.c: Remove.
1423         * features/arm/arm-with-iwmmxt.xml: Remove.
1424         * features/arm/arm-with-m-fpa-layout.c: Remove.
1425         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1426         * features/arm/arm-with-m-vfp-d16.c: Remove.
1427         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1428         * features/arm/arm-with-m.c: Remove.
1429         * features/arm/arm-with-m.xml: Remove.
1430         * features/arm/arm-with-neon.c: Remove.
1431         * features/arm/arm-with-neon.xml: Remove.
1432         * features/arm/arm-with-vfpv2.c: Remove.
1433         * features/arm/arm-with-vfpv2.xml: Remove.
1434         * features/arm/arm-with-vfpv3.c: Remove.
1435         * features/arm/arm-with-vfpv3.xml: Remove.
1436
1437 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1440
1441 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1442
1443         * arch/aarch32.c (aarch32_create_target_description): Create
1444         target descriptions using features.
1445         * arch/arm.c (arm_create_target_description)
1446         (arm_create_mprofile_target_description): Likewise.
1447         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1448
1449 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1450
1451         * Makefile.in: Add new files.
1452         * aarch32-tdep.c: New file.
1453         * aarch32-tdep.h: New file.
1454         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1455         Call aarch32_read_description.
1456         * arch/aarch32.c: New file.
1457         * arch/aarch32.h: New file.
1458         * arch/arm.c (arm_create_target_description)
1459         (arm_create_mprofile_target_description): New function.
1460         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1461         (arm_create_target_description)
1462         (arm_create_mprofile_target_description): New declaration.
1463         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1464         read_description functions.
1465         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1466         Likewise.
1467         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1468         * arm-tdep.c (tdesc_arm_list): New variable.
1469         (arm_register_g_packet_guesses): Call create description functions.
1470         (arm_read_description) (arm_read_mprofile_description): New
1471         function.
1472         * arm-tdep.h (arm_read_description)
1473         (arm_read_mprofile_description): Add declaration.
1474         * configure.tgt: Add new files.
1475
1476 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1477
1478         * top.c (new_ui_command): Open specified terminal just once.
1479
1480 2019-07-18  Tom Tromey  <tromey@adacore.com>
1481
1482         * symtab.c (main_name): Constify return type.
1483         * symfile.c (set_initial_language): Update.
1484         * symtab.h (main_name): Constify return type.
1485
1486 2019-07-17  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-winsource.c (tui_update_source_window)
1489         (tui_update_source_window_as_is)
1490         (tui_update_source_windows_with_line): Remove return.
1491         * tui/tui-disasm.c (tui_show_disassem)
1492         (tui_show_disassem_and_update_source): Remove return.
1493         * tui/tui.c (tui_reset): Remove return.
1494         * tui/tui-wingeneral.c
1495         (tui_check_and_display_highlight_if_needed): Remove return.
1496
1497 2019-07-17  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1500
1501 2019-07-17  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-winsource.h (struct tui_exec_info_window)
1504         (struct tui_source_window_base): Move from tui-data.h.
1505         * tui/tui-winsource.c: Move many method definitions from
1506         elsewhere.  Remove "structuring" comments.
1507         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1508         (tui_source_window_base::refresh_window): Move to
1509         tui-winsource.c.
1510         * tui/tui-win.c (tui_source_window_base::refresh_all)
1511         (tui_source_window_base::update_tab_width)
1512         (tui_source_window_base::set_new_height)
1513         (tui_source_window_base::do_make_visible_with_new_height): Move to
1514         tui-winsource.c.
1515         * tui/tui-source.h: Update.
1516         * tui/tui-source.c (tui_source_window_base::reset): Move to
1517         tui-winsource.c.
1518         * tui/tui-disasm.h: Update.
1519         * tui/tui-data.h (struct tui_exec_info_window): Move to
1520         tui-winsource.h.
1521         (struct tui_source_window_base): Likewise.
1522         * tui/tui-data.c (tui_source_window_base::clear_detail)
1523         (tui_source_window_base, ~tui_source_window_base): Move to
1524         tui-winsource.c.
1525
1526 2019-07-17  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-win.c (tui_resize_all)
1529         (tui_source_window_base::update_tab_width)
1530         (tui_adjust_win_heights): Update.
1531         (tui_win_info::make_invisible_and_set_new_height): Rename from
1532         make_invisible_and_set_new_height.
1533         * tui/tui-data.h (struct tui_win_info)
1534         <make_invisible_and_set_new_height>: New method.
1535
1536 2019-07-17  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui.c: Update.
1539         * tui/tui-source.h (struct tui_source_window): Move from
1540         tui-data.h.
1541         * tui/tui-layout.c: Update.
1542         * tui/tui-disasm.c: Update.
1543         * tui/tui-data.h (struct tui_source_window): Move to
1544         tui-source.h.
1545
1546 2019-07-17  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1549         tui-data.h.
1550         * tui/tui-data.h (struct tui_disasm_window): Move to
1551         tui-disasm.h.
1552
1553 2019-07-17  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-regs.h (struct tui_data_item_window): Move from
1556         tui-data.h.
1557         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1558         * tui/tui-data.h (struct tui_data_item_window): Move to
1559         tui-regs.h.
1560         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui.c: Update.
1565         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1566         (tui_cmd_window::max_height): Move to tui-command.c.
1567         * tui/tui-layout.c: Update.
1568         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1569         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1570         tui-command.c.
1571         * tui/tui-command.h (struct tui_cmd_window): Move from
1572         tui-data.h.
1573         * tui/tui-command.c: Remove "structuring" comments.
1574         (tui_cmd_window::clear_detail)
1575         (tui_cmd_window::do_make_visible_with_new_height)
1576         (tui_cmd_window::max_height): Move from elsewhere.
1577
1578 2019-07-17  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1581         Now static.
1582         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1583         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1584
1585 2019-07-17  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui.c: Update.
1588         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1589         tui-regs.c.
1590         * tui/tui-windata.h: Remove file.
1591         * tui/tui-windata.c: Remove file.
1592         * tui/tui-win.c (tui_data_window::set_new_height)
1593         (tui_data_window::do_make_visible_with_new_height): Move to
1594         tui-regs.c.
1595         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1596         * tui/tui-regs.c: Remove "structuring" comments.
1597         (tui_data_window::first_data_item_displayed)
1598         (tui_data_window::delete_data_content_windows)
1599         (tui_data_window::erase_data_content)
1600         (tui_data_window::display_all_data)
1601         (tui_data_window::refresh_all)
1602         (tui_data_window::do_scroll_vertical)
1603         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1604         (tui_data_window::do_make_visible_with_new_height)
1605         (tui_data_window::refresh_window): Move from elsewhere.
1606         (_initialize_tui_regs): Move to end of file.
1607         * tui/tui-layout.c: Update.
1608         * tui/tui-hooks.c: Update.
1609         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1610         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1611         tui-regs.c.
1612         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1613
1614 2019-07-17  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1617         seen.
1618
1619 2019-07-17  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-win.c (tui_source_window_base::set_new_height)
1622         (tui_source_window_base::do_make_visible_with_new_height): Use
1623         m_has_locator field directly.
1624         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1625         method.
1626         (struct tui_source_window_base) <has_locator>: Likewise.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1631         Don't declare.
1632         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1633         Remove.
1634         * tui/tui-win.c (tui_source_window_base::set_new_height)
1635         (tui_source_window_base::set_new_height)
1636         (make_invisible_and_set_new_height)
1637         (tui_source_window_base::do_make_visible_with_new_height)
1638         (tui_source_window_base::do_make_visible_with_new_height):
1639         Update.
1640         * tui/tui-layout.c (show_source_disasm_command, show_data)
1641         (show_source_or_disasm_and_command): Update.
1642         * tui/tui-layout.c (show_layout): Update.
1643
1644 2019-07-17  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui-layout.c (make_data_window): Remove.
1647         (show_data): Unify creation and re-initialization cases.
1648
1649 2019-07-17  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-layout.c (make_source_window, make_disasm_window):
1652         Remove.
1653         (show_data): Unify creation and re-initialization cases.
1654
1655 2019-07-17  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-layout.c (make_command_window): Remove.
1658         (show_source_disasm_command, show_source_or_disasm_and_command):
1659         Unify creation and re-initialization cases.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1664         creation and re-initialization cases.
1665
1666 2019-07-17  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-regs.c (tui_get_register): Return void.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1673         Simplify.
1674
1675 2019-07-17  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1678         resetting.
1679
1680 2019-07-17  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1683         * tui/tui-regs.c (tui_reg_layout): New function.
1684         (tui_show_registers, tui_reg_command): Use it.
1685         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1686         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1687         parameters.
1688         (tui_layout_command): Remove.
1689
1690 2019-07-17  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-layout.h (tui/tui-layout): Return void.
1693         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1694
1695 2019-07-17  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-layout.c (show_source_disasm_command, show_data):
1698         Update.
1699         (reset_locator): Remove.
1700         (show_source_or_disasm_and_command): Update.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-source.c (tui_source_window_base::reset): Remove
1705         win_type parameter.
1706         * tui/tui-layout.c (make_command_window, make_source_window)
1707         (make_disasm_window, make_data_window)
1708         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1709         (reset_locator, show_source_or_disasm_and_command): Update.
1710         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1711         win_type parameter.
1712         (struct tui_source_window_base) <reset>: Likewise.
1713
1714 2019-07-17  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-layout.c (show_source_disasm_command): Use
1717         reset_locator.
1718         (reset_locator): New function.
1719         (init_and_make_win): Remove.
1720         (show_source_or_disasm_and_command): Use reset_locator.
1721
1722 2019-07-17  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1725         condition.
1726         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1727         Remove condition.
1728         * tui/tui-source.c (tui_source_window_base::reset): New method.
1729         * tui/tui-layout.c (make_command_window): Don't call
1730         init_and_make_win.
1731         (make_source_window, make_disasm_window): Don't call
1732         make_source_or_disasm_window.
1733         (make_data_window): Don't call init_and_make_win.  Change calling
1734         convention.
1735         (show_source_disasm_command, show_data): Simplify.
1736         (make_source_or_disasm_window): Remove.
1737         (show_source_or_disasm_and_command): Simplify.
1738         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1739         (struct tui_source_window_base) <reset>: Likewise.
1740         <execution_info>: Remove initializer.
1741         * tui/tui-data.c (tui_source_window_base): Initialize
1742         execution_info.
1743
1744 2019-07-17  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1747         variable.
1748
1749 2019-07-17  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui.c (tui_rl_other_window): Update.
1752         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1753         superclass method first.  Always iterate over regs_content.
1754         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1755         method.
1756         * tui/tui-win.c (tui_set_focus_command): Update.
1757
1758 2019-07-17  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-win.c (tui_set_focus_command): Rename from
1761         tui_set_focus.  Call tui_enable.
1762         (tui_set_focus_command): Remove.
1763
1764 2019-07-17  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1767         refresh_window.
1768         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1769         touchwin.
1770         (tui_data_window::refresh_window): Call refresh_window on data
1771         items.  Always call superclass refresh_window.
1772         (tui_win_info::refresh): Remove.
1773         (tui_source_window_base::refresh_window): Update.
1774         (tui_refresh_all): Update.
1775         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1776         refresh_window.
1777         (show_source_or_disasm_and_command): Likewise.
1778         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1779         (struct tui_source_window_base) <refresh>: Likewise.
1780
1781 2019-07-17  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-winsource.c (tui_clear_source_content)
1784         (tui_show_source_content): Update.
1785         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1786         whether content is empty.
1787         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1788         Remove.
1789
1790 2019-07-17  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1793         window's contents.
1794         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1795         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1800         (struct tui_data_item_window): Update.
1801
1802 2019-07-17  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1805         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1806         defines.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-winsource.h (tui_erase_source_content)
1811         (tui_clear_source_content): Remove "display_prompt" parameter.
1812         * tui/tui-winsource.c (tui_update_source_window_as_is)
1813         (tui_update_source_windows_with_addr): Update.
1814         (tui_clear_source_content): Remove "display_prompt" parameter.
1815         (tui_erase_source_content): Likewise.  Simplify.
1816         (tui_show_source_content): Update.
1817         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1818         * tui/tui-stack.c (tui_show_frame_info): Update.
1819         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1820         Remove defines.
1821
1822 2019-07-17  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1825         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1826         parameter.
1827         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1828         parameter.
1829
1830 2019-07-17  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-winsource.c (tui_clear_source_content)
1833         (tui_show_source_content, tui_show_exec_info_content)
1834         (tui_clear_exec_info_content): Update.
1835         * tui/tui-stack.c (tui_show_locator_content): Update.
1836         (tui_show_frame_info): Update.
1837         * tui/tui-source.h (tui_source_window): Don't declare.
1838         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1839         from tui_source_is_displayed.
1840         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1841         Remove field.
1842         (struct tui_source_window_base) <content_in_use>: New field.  Now
1843         bool.
1844         (struct tui_source_window) <showing_source_p>: New method.
1845         (TUI_SRC_WIN): Change cast.
1846         * tui/tui-data.c (tui_initialize_static_data): Update.
1847
1848 2019-07-17  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1851         location_matches_p.
1852         * tui/tui-source.c (tui_source_window::location_matches_p): New
1853         method.
1854         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1855         method.
1856         * tui/tui-data.h (struct tui_source_window_base)
1857         <location_matches_p>: New method.
1858         (struct tui_source_window, struct tui_disasm_window)
1859         <location_matches_p>: Likewise.
1860
1861 2019-07-17  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-win.c (tui_set_win_height_command): Rename from
1864         tui_set_win_height.
1865         (tui_set_win_height_command): Remove.
1866
1867 2019-07-17  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-source.c (tui_source_window): New constructor.  Add
1870         observer.
1871         (~tui_source_window): New destructor.
1872         (tui_source_window::style_changed): New method.
1873         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1874         (tui_attach_detach_observers): Update.
1875         * tui/tui-data.h (struct tui_source_window): Make constructor not
1876         inline.  Add destructor.
1877         (struct tui_source_window) <style_changed>: New method.
1878         <m_observable>: New member.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1883         * tui/tui-win.c (tui_resize_all): Fix typo.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1888         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1889         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1890         * tui/tui-win.c (window_name_completer): Use foreach.
1891         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1892         (update_tab_width): Likewise.
1893         * tui/tui-layout.c (show_layout): Update.
1894         * tui/tui-data.h (class tui_window_iterator): New.
1895         (struct all_tui_windows): New.
1896         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1897
1898 2019-07-17  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1901         parameter.  Don't reference globals.
1902         (tui_reg_command): Update.
1903
1904 2019-07-17  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-regs.c (tui_show_registers): Simplify.
1907
1908 2019-07-17  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-regs.c (tui_show_registers): Update.
1911         (tui_show_register_group): Add win_info parameter.
1912
1913 2019-07-17  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1916         Rename from tui_display_reg_element_at_line.
1917         (tui_data_window::display_registers_from_line): Update.
1918         * tui/tui-data.h (struct tui_data_window)
1919         <display_reg_element_at_line>: New method.
1920
1921 2019-07-17  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-regs.h (tui_display_registers_from)
1924         (tui_display_registers_from_line): Don't declare.
1925         * tui/tui-windata.c (tui_data_window::display_all_data)
1926         (tui_data_window::refresh_all)
1927         (tui_data_window::do_scroll_vertical): Update.
1928         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1929         from tui_display_registers_from.
1930         (tui_display_reg_element_at_line): Update.
1931         (tui_data_window::display_registers_from_line): Rename from
1932         tui_display_registers_from_line.
1933         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1934         display_registers_from_line>: New methods.
1935
1936 2019-07-17  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1939         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1940         from tui_erase_data_content.
1941         (tui_data_window::display_all_data)
1942         (tui_data_window::refresh_all)
1943         (tui_data_window::do_scroll_vertical): Update.
1944         * tui/tui-regs.c (tui_show_registers): Update.
1945         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1946         New method.
1947
1948 2019-07-17  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1951         declare.
1952         * tui/tui-windata.c
1953         (tui_data_window::delete_data_content_windows): Rename from
1954         tui_delete_data_content_windows.
1955         (tui_data_window::display_all_data)
1956         (tui_data_window::do_scroll_vertical): Update.
1957         * tui/tui-data.h (struct tui_data_window)
1958         <delete_data_content_windows>: New method.
1959
1960 2019-07-17  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1963         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1964
1965 2019-07-17  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1968         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1969         from tui_display_all_data.
1970         * tui/tui-win.c
1971         (tui_data_window::do_make_visible_with_new_height): Update.
1972         * tui/tui-regs.c (tui_show_registers): Update.
1973         * tui/tui-layout.c (tui_set_layout): Update.
1974         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1975         method.
1976
1977 2019-07-17  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1980         * tui/tui-windata.c (tui_display_data_from): Remove.
1981         (tui_data_window::refresh_all): Update.
1982
1983 2019-07-17  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1986         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1987         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1988         tui_display_registers_from_line.
1989         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1990         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1991         "force_display" parameter.
1992
1993 2019-07-17  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1996         declare.
1997         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1998         Rename from tui_first_reg_element_no_inline.
1999         (tui_display_reg_element_at_line)
2000         (tui_display_registers_from_line): Update.
2001         * tui/tui-data.h (struct tui_data_window)
2002         <first_reg_element_no_inline>: New method.
2003
2004 2019-07-17  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-windata.c (tui_display_data_from)
2007         (tui_data_window::do_scroll_vertical): Update.
2008         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2009         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2010         Rename from tui_line_from_reg_element_no.
2011         (tui_display_registers_from_line): Update.
2012         * tui/tui-data.h (struct tui_data_window)
2013         <line_from_reg_element_no>: New method.
2014
2015 2019-07-17  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2018         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2019         tui_last_regs_line_no.
2020         (tui_display_reg_element_at_line)
2021         (tui_display_registers_from_line): Update.
2022         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2023         method.
2024
2025 2019-07-17  Tom Tromey  <tom@tromey.com>
2026
2027         PR tui/24722:
2028         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2029         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2030         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2031         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2032         (tui_update_breakpoint_info): Likewise.
2033         * tui/tui-hooks.c (tui_event_create_breakpoint)
2034         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2035         Update.
2036
2037 2019-07-17  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2040
2041 2019-07-17  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-winsource.c (tui_update_source_window_as_is)
2044         (tui_update_source_windows_with_addr): Update.
2045         * tui/tui-source.h (tui_set_source_content)
2046         (tui_show_symtab_source): Add "win_info" parameter.
2047         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2048         parameter.
2049         (tui_show_symtab_source): Likewise.
2050
2051 2019-07-17  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-wingeneral.c
2054         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2055
2056 2019-07-17  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2059         (struct tui_cmd_window) <can_scroll>: New method.
2060         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2061         method.
2062
2063 2019-07-17  Tom Tromey  <tromey@adacore.com>
2064
2065         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2066         do_field_signed>: Rename.  Change type of "value".
2067         * ui-out.c (ui_out::field_signed): Rename from field_int.
2068         Change type of "value".
2069         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2070         type of "value".
2071         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2072         do_field_int.  Change type of "value".
2073         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2074         do_field_int.  Change type of "value".
2075         * tracepoint.c (trace_status_mi, tfind_1)
2076         (print_one_static_tracepoint_marker): Update.
2077         * thread.c (print_thread_info_1, print_selected_thread_frame):
2078         Update.
2079         * stack.c (print_frame, print_frame_info): Update.
2080         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2081         Update.
2082         * source.c (print_source_lines_base): Update.
2083         * skip.c (info_skip_command): Update.
2084         * record-btrace.c (btrace_ui_out_decode_error)
2085         (btrace_call_history_src_line): Update.
2086         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2087         Update.
2088         * progspace.c (print_program_space): Update.
2089         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2090         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2091         do_field_int.  Change type of "value".
2092         * mi/mi-out.c (mi_ui_out::do_table_begin)
2093         (mi_ui_out::do_table_header): Update.
2094         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2095         type of "value".
2096         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2097         (mi_cmd_data_list_changed_registers, output_register)
2098         (mi_cmd_data_read_memory, mi_load_progress)
2099         (mi_cmd_trace_frame_collected): Update.
2100         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2101         Update.
2102         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2103         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2104         (mi_cmd_var_list_children, varobj_update_one): Update.
2105         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2106         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2107         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2108         * inferior.c (print_inferior): Update.
2109         * gdb_bfd.c (print_one_bfd): Update.
2110         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2111         Update.
2112         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2113         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2114         do_field_int.  Change type of "value".
2115         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2116         do_field_int.  Change type of "value".
2117         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2118         (print_one_breakpoint_location, print_it_catch_fork)
2119         (print_one_catch_fork, print_it_catch_vfork)
2120         (print_one_catch_vfork, print_it_catch_solib)
2121         (print_it_catch_exec, print_it_ranged_breakpoint)
2122         (print_mention_watchpoint, print_mention_masked_watchpoint)
2123         (bkpt_print_it, update_static_tracepoint): Update.
2124         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2125         * break-catch-syscall.c (print_it_catch_syscall): Update.
2126         * ada-tasks.c (print_ada_task_info): Update.
2127         * ada-lang.c (print_it_exception, print_mention_exception):
2128         Update.
2129
2130 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         PR breakpoints/24541
2133         * gdbarch.c: Regenerate.
2134         * gdbarch.h: Regenerate.
2135         * gdbarch.sh: Adjust return type and parameter types for
2136         'stap_adjust_register'.
2137         (i386_stap_adjust_register): Adjust signature and return new
2138         register name.
2139         * stap-probe.c (stap_parse_register_operand): Adjust use of
2140         'gdbarch_stap_adjust_register'.
2141
2142 2019-07-17  Tom Tromey  <tromey@adacore.com>
2143
2144         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2145         declare VEC.
2146         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2147         std::vector.
2148         (struct s390_process_info): Add initializers.
2149         (s390_add_process): Use new.
2150         (s390_linux_nat_target::low_forget_process): Use delete.
2151         (s390_linux_nat_target::low_new_fork)
2152         (s390_linux_nat_target::stopped_by_watchpoint)
2153         (s390_linux_nat_target::low_prepare_to_resume)
2154         (s390_linux_nat_target::insert_watchpoint)
2155         (s390_linux_nat_target::insert_hw_breakpoint)
2156         (s390_linux_nat_target::remove_watchpoint)
2157         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2158
2159 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2160
2161         * aarch64-fbsd-nat.c: Include regcache.h.
2162         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2163         argument.
2164         (aarch64_fbsd_nat_target::fetch_registers)
2165         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2166         variable.
2167         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2168
2169 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2170
2171         * fbsd-nat.c: Include gdbarch.h.
2172
2173 2019-07-15  Tom Tromey  <tromey@adacore.com>
2174
2175         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2176
2177 2019-07-15  Tom Tromey  <tromey@adacore.com>
2178
2179         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2180         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2181         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2182         * cli-out.c (cli_ui_out::do_field_int): New method.
2183         * ui-out.c (ui_out::field_unsigned): New method.
2184         * symfile.c (generic_load): Use field_unsigned.
2185         (print_transfer_performance): Likewise.
2186         * record-btrace.c (ui_out_field_uint): Remove.
2187         (btrace_call_history_insn_range, btrace_call_history): Use
2188         field_unsigned.
2189         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2190         field_unsigned.
2191         * ui-out.h (class ui_out) <field_unsigned>: New method.
2192         <do_field_unsigned>: Likewise.
2193
2194 2019-07-15  Tom Tromey  <tromey@adacore.com>
2195
2196         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2197         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2198         * target.c (flash_erase_command): Use field_string.
2199         * infrun.c (print_signal_received_reason): Use field_string.
2200         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2201         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2202         field_string.
2203         * ada-tasks.c (print_ada_task_info): Use field_string.
2204
2205 2019-07-15  Tom Tromey  <tromey@adacore.com>
2206
2207         * target.c (flash_erase_command): Use field_core_addr.
2208         * symfile.c (generic_load): Use field_core_addr.
2209         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2210         Use field_core_addr.
2211         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2212         field_core_addr.
2213
2214 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2217         value if its desired type is smaller than a CORE_ADDR and signed.
2218
2219 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2222         of changes to field names, and use new is_reference field to
2223         decide if a property is a reference or not.
2224         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2225         field.
2226         (struct dwarf2_property_baton): Update header comment, rename
2227         'referenced_type' to 'property_type' and update comments.
2228         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2229         default property type, store in property baton, update to take
2230         accound of renamed field.
2231         (read_func_scope): Update call to attr_to_dynamic_prop.
2232         (read_array_type): Likewise.
2233         (dwarf2_per_cu_addr_sized_int_type): New function.
2234         (read_subrange_index_type): Move type finding code to
2235         dwarf2_per_cu_addr_sized_int_type.
2236         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2237         (dwarf2_per_cu_addr_type): New function.
2238         (set_die_type): Update calls to attr_to_dynamic_prop.
2239
2240 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2241
2242         * dwarf2read.c (read_subrange_index_type): New function.
2243         (read_subrange_type): Move code into new function and call it.
2244         * gdbtypes.c (create_range_type): Add some asserts.
2245
2246 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2249         update return statements.
2250         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2251         declaration, and update comment to match.
2252         * gdbtypes.c (resolve_dynamic_array): Update call to
2253         dwarf2_evaluate_property to match new return type.
2254
2255 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * valarith.c (value_subscripted_rvalue): Change lowerbound
2258         parameter type from int to LONGEST.
2259         * value.h (value_subscripted_rvalue): Likewise in declaration.
2260
2261 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * cli/cli-utils.c (info_print_command_completer): New function.
2264         * cli/cli-utils.h: Add 'completer.h' include, and forward
2265         declaration for 'struct cmd_list_element'.
2266         (info_print_command_completer): Declare.
2267         * stack.c (_initialize_stack): Add completer for 'info locals' and
2268         'info args'.
2269         * symtab.c (_initialize_symtab): Add completer for 'info
2270         variables' and 'info functions'.
2271         * NEWS: Mention completion for additional info commands.
2272
2273 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * cli/cli-utils.c (extract_info_print_args): Delete.
2276         (extract_arg_maybe_quoted): Delete.
2277         (info_print_options_defs): New variable.
2278         (make_info_print_options_def_group): New function.
2279         (extract_info_print_options): Define new function.
2280         * cli/cli-utils.h (extract_info_print_args): Delete.
2281         (struct info_print_options): New structure.
2282         (extract_info_print_options): Declare new function.
2283         * stack.c (info_locals_command): Update to use new
2284         extract_info_print_options, also add a header comment.
2285         (info_args_command): Likewise.
2286         * symtab.c (info_variables_command): Likewise.
2287         (info_functions_command): Likewise.
2288
2289 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2290
2291         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2292         to extract string arguments.
2293         * common/common-utils.c (extract_string_maybe_quoted): New function.
2294         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2295
2296 2019-07-11  Tom Tromey  <tromey@adacore.com>
2297
2298         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2299         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2300         * top.h (gdbinit): Don't declare.
2301         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2302         into...
2303         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2304         * top.c (gdb_init): Don't call init_cli_cmds.
2305         (gdbinit): Remove.
2306         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2307
2308 2019-07-11  Tom Tromey  <tromey@adacore.com>
2309
2310         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2311         after it has been moved.
2312
2313 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2314
2315         * valops.c (value_must_coerce_to_target): Change return type to
2316         bool.
2317         * value.h (value_must_coerce_to_target): Likewise.
2318
2319 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2320
2321         * breakpoint.c (is_hardware_watchpoint): Remove
2322         forward-declaration.
2323         (is_masked_watchpoint): Change return type to bool.
2324         (is_tracepoint): Likewise.
2325         (is_breakpoint): Likewise.
2326         (is_hardware_watchpoint): Likewise.
2327         (is_watchpoint): Likewise.
2328         (is_no_memory_software_watchpoint): Likewise.
2329         (is_catchpoint): Likewise.
2330         (breakpoint_1): Make FILTER parameter's return type bool.
2331         is_masked_watchpoint): Change return type to bool.
2332         (save_breakpoints): Make FILTER parameter's return type bool.
2333         * breakpoint.h (is_breakpoint): Change return type to bool.
2334         (is_watchpoint): Likewise.
2335         (is_catchpoint): Likewise.
2336         (is_tracepoint): Likewise.
2337
2338 2019-07-10  Tom Tromey  <tom@tromey.com>
2339
2340         * defs.h: Don't include gdbarch.h.
2341         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2342         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2343         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2344         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2345         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2346         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2347         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2348         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2349         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2350         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2351         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2352         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2353         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2354         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2355         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2356         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2357         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2358         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2359         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2360         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2361         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2362         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2363         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2364         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2365         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2366         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2367         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2368
2369 2019-07-10  Tom Tromey  <tromey@adacore.com>
2370
2371         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2372         * breakpoint.c (init_ada_exception_breakpoint): Register as
2373         bp_catchpoint.
2374         (print_one_breakpoint_location, print_one_breakpoint): Use
2375         is_ada_exception_catchpoint.
2376         * ada-lang.c (class ada_catchpoint_location): Pass
2377         bp_loc_software_breakpoint to bp_location constructor.
2378         (is_ada_exception_catchpoint): New function.
2379
2380 2019-07-10  Tom Tromey  <tromey@adacore.com>
2381
2382         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2383         VEC.
2384         (struct arm_exidx_entry): New method operator<.
2385         (struct arm_exidx_data) <section_maps>: Change type.
2386         (arm_exidx_data_free): Remove.
2387         (arm_exidx_data_key): Change type.  Move lower.
2388         (arm_exidx_new_objfile): Update.
2389         (arm_compare_exidx_entries): Remove.
2390         (arm_find_exidx_entry, _initialize_arm_tdep)
2391
2392 2019-07-10  Tom Tromey  <tromey@adacore.com>
2393
2394         * solib-spu.c (ocl_program_data_key): Change type.
2395         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2396         Update.
2397
2398 2019-07-10  Tom Tromey  <tromey@adacore.com>
2399
2400         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2401         (struct solib_aix_inferior_data) <library_list>: Change type.
2402         (solib_aix_inferior_data_handle): Change type.
2403         (get_solib_aix_inferior_data): Update.
2404         (solib_aix_free_library_list): Remove.
2405         (library_list_start_library): Update.
2406         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2407         return type.
2408         (solib_aix_get_library_list)
2409         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2410         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2411
2412 2019-07-10  Tom Tromey  <tromey@adacore.com>
2413
2414         * solib-dsbt.c (struct dsbt_info): Add initializers.
2415         (solib_dsbt_pspace_data): Change type.
2416         (dsbt_pspace_data_cleanup): Remove.
2417         (get_dsbt_info, _initialize_dsbt_solib): Update.
2418
2419 2019-07-10  Tom Tromey  <tromey@adacore.com>
2420
2421         * spu-tdep.c (spu_overlay_data): Change type.
2422         (spu_get_overlay_table, spu_overlay_new_objfile)
2423         (_initialize_spu_tdep): Update.
2424
2425 2019-07-10  Tom Tromey  <tromey@adacore.com>
2426
2427         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2428         destructor.
2429         (dbx_objfile_data_key): Change type and declare later.
2430         (DBX_SYMFILE_INFO): Rewrite.
2431         * dbxread.c (dbx_objfile_data_key): Change type.
2432         (dbx_symfile_init): Update.
2433         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2434         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2435         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2436
2437 2019-07-10  Tom Tromey  <tromey@adacore.com>
2438
2439         * jit.c (jit_program_space_key): Change type.  Move lower.
2440         (get_jit_program_space_data): Update.
2441         (jit_program_space_data_cleanup): Remove.
2442         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2443         Update.
2444         (struct jit_program_space_data): Add initializers.
2445
2446 2019-07-10  Tom Tromey  <tromey@adacore.com>
2447
2448         * solib-darwin.c (struct darwin_info): Add initializers.
2449         (solib_darwin_pspace_data): Change type.
2450         (darwin_pspace_data_cleanup): Remove.
2451         (get_darwin_info, _initialize_darwin_solib): Update.
2452
2453 2019-07-10  Tom Tromey  <tromey@adacore.com>
2454
2455         * remote-sim.c (struct sim_inferior_data): Add initializers,
2456         constructor, and destructor.
2457         (sim_inferior_data_key): Change type.  Move lower.
2458         (check_for_duplicate_sim_descriptor): Update.
2459         (get_sim_inferior_data): Use new.  Update.
2460         (~sim_inferior_data_cleanup): Rename from
2461         sim_inferior_data_cleanup.  Simplify.
2462         (gdbsim_close_inferior, simulator_command)
2463         (sim_command_completer, _initialize_remote_sim): Update.
2464         (next_pid, INITIAL_PID): Move earlier.
2465
2466 2019-07-10  Tom Tromey  <tromey@adacore.com>
2467
2468         * python/python-internal.h (create_thread_object): Return
2469         gdbpy_ref.
2470         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2471         * python/py-inferior.c (struct threadlist_entry): Add
2472         constructor.
2473         <thread_obj>: Now a gdbpy_ref.
2474         (thread_to_thread_object): Update.
2475         (add_thread_object): Use new.
2476         (delete_thread_object): Use delete.
2477         (infpy_threads): Update.
2478         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2479         GIL.
2480
2481 2019-07-10  Tom Tromey  <tromey@adacore.com>
2482
2483         * valops.c (value_cast): Specialize error message for Ada.
2484
2485 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2486
2487         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2488
2489 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2490
2491         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2492         bpstat_should_step): Return bool, adjust comments.
2493         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2494         bpstat_should_step): Likewise.
2495
2496 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2497
2498         * features/Makefile: Use feature target descriptions for Arm.
2499         * features/arm/arm-core.c: Generate new file.
2500         * features/arm/arm-fpa.c: Likewise.
2501         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2502         * features/arm/arm-m-profile.c: Likewise.
2503         * features/arm/arm-vfpv2.c: Likewise.
2504         * features/arm/arm-vfpv3.c: Likewise.
2505         * features/arm/xscale-iwmmxt.c: Likewise.
2506         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2507
2508 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2509
2510         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2511         ptrace earlier.
2512
2513 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2514
2515         * features/aarch64-pauth.c: Regenerate.
2516
2517 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2518
2519         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2520         bool.
2521         (bpstat_what): Use false instead of 0.
2522
2523 2019-07-09  Pedro Alves  <palves@redhat.com>
2524
2525         * break-catch-throw.c (is_exception_catchpoint): New.
2526         * breakpoint.c (print_one_breakpoint_location): New parameter
2527         'raw_loc'.  Handle it.  Use
2528         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2529         looking at the breakpoint's type.
2530         (print_one_breakpoint): If handling "maint info breakpoints", also
2531         print locations of exception catchpoints.
2532         * breakpoint.h (is_exception_catchpoint): Declare.
2533
2534 2019-07-09  Pedro Alves  <palves@redhat.com>
2535
2536         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2537         "addr" field.
2538         (allocate_location_exception_catchpoint): New.
2539         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2540         (initialize_throw_catchpoint_ops): Install
2541         allocate_location_exception_catchpoint as allocate_location
2542         method.
2543         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2544         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2545         bp_loc_other.
2546         (breakpoint_address_is_meaningful): Delete.
2547         (bl_address_is_meaningful): New.
2548         (breakpoint_locations_match): Adjust comment.
2549         (bp_location_from_bp_type): New, factored out of...
2550         (bp_location::bp_location(breakpoint *)): ... this.
2551         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2552         factored out of...
2553         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2554         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2555         breakpoint_address_is_meaningful.
2556         (bp_locations_compare): Adjust comment.
2557         (update_global_location_list): Use bl_address_is_meaningful
2558         instead of breakpoint_address_is_meaningful.
2559         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2560         explicit.
2561         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2562         * python/py-breakpoint.c (bppy_get_location): No longer check
2563         whether location is null.
2564
2565 2019-07-09  Pedro Alves  <palves@redhat.com>
2566
2567         PR c++/15468
2568         * breakpoint.c (print_one_breakpoint_location): Remove
2569         single-location assert.
2570
2571 2019-07-09  Tom Tromey  <tom@tromey.com>
2572
2573         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2574         * configure: Rebuild.
2575         * configure.ac: Change common to gdbsupport.
2576         * gdbsupport: Rename from common.
2577         * acinclude.m4: Change common to gdbsupport.
2578         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2579         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2580         gdbsupport.
2581         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2582         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2583         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2584         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2585         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2586         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2587         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2588         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2589         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2590         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2591         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2592         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2593         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2594         coff-pe-read.c, command.h, compile/compile-c-support.c,
2595         compile/compile-c.h, compile/compile-cplus-symbols.c,
2596         compile/compile-cplus-types.c, compile/compile-cplus.h,
2597         compile/compile-loc2c.c, compile/compile.c, completer.c,
2598         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2599         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2600         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2601         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2602         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2603         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2604         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2605         features/aarch64-core.c, features/aarch64-fpu.c,
2606         features/aarch64-pauth.c, features/aarch64-sve.c,
2607         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2608         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2609         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2610         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2611         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2612         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2613         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2614         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2615         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2616         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2617         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2618         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2619         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2620         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2621         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2622         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2623         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2624         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2625         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2626         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2627         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2628         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2629         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2630         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2631         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2632         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2633         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2634         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2635         minsyms.c, mips-linux-tdep.c, namespace.h,
2636         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2637         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2638         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2639         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2640         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2641         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2642         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2643         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2644         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2645         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2646         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2647         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2648         procfs.c, producer.c, progspace.h, psymtab.h,
2649         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2650         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2651         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2652         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2653         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2654         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2655         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2656         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2657         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2658         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2659         target-memory.c, target.c, target.h, target/waitstatus.c,
2660         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2661         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2662         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2663         unittests/array-view-selftests.c,
2664         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2665         unittests/common-utils-selftests.c,
2666         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2667         unittests/format_pieces-selftests.c,
2668         unittests/function-view-selftests.c,
2669         unittests/lookup_name_info-selftests.c,
2670         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2671         unittests/mkdir-recursive-selftests.c,
2672         unittests/observable-selftests.c,
2673         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2674         unittests/parse-connection-spec-selftests.c,
2675         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2676         unittests/scoped_fd-selftests.c,
2677         unittests/scoped_mmap-selftests.c,
2678         unittests/scoped_restore-selftests.c,
2679         unittests/string_view-selftests.c, unittests/style-selftests.c,
2680         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2681         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2682         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2683         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2684         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2685         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2686
2687 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2688
2689         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2690         bool value.
2691         (decode_digits_ordinary): Set explicit_line field in sal.
2692         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2693         symtab_and_line that was set on an explicit line number in
2694         assembler code.  Do always update the recorded symtab and line if
2695         we do skip the prologue.
2696
2697 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2698
2699         * breakpoint.c (set_breakpoint_location_function): Remove
2700         explicit_loc parameter.
2701         (momentary_breakpoint_from_master): Update call to
2702         set_breakpoint_location_function.
2703         (add_location_to_breakpoint): Likewise.
2704
2705 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2708         required features based on default bfd type when no specific bfd
2709         is present.
2710
2711 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2712
2713         * NEWS: Mention that GDB printf and eval commands can now print
2714         C-style and Ada-style convenience var strings without
2715         calling the inferior.
2716         * printcmd.c (printf_c_string): Locally print GDB internal var
2717         instead of transiting via the inferior.
2718         (printf_wide_c_string): Likewise.
2719
2720 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2721
2722         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2723
2724 2019-07-04  Tom Tromey  <tom@tromey.com>
2725
2726         PR tui/24724:
2727         * tui/tui-winsource.c (tui_clear_source_content): Update.
2728         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2729         (tui_update_breakpoint_info): Update.
2730         (tui_set_exec_info_content): Update.
2731         * tui/tui-source.c (tui_set_source_content_nil): Update.
2732         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2733         has_break.
2734         * tui/tui-data.h (enum tui_bp_flag): New.
2735         (tui_bp_flags): New enum flags type.
2736         (struct tui_source_element) <break_mode>: Change type.  Rename
2737         from has_break.
2738         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2739         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2740         constants.
2741         * tui/tui-winsource.h: Fix comment.
2742
2743 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2744
2745         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2746         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2747         (store_fpregs_to_thread)
2748         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2749         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2750         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2751         (IWMMXT_REGS_SIZE): Add define.
2752         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2753         (fetch_vfp_regs, store_vfp_regs)
2754         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2755         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2756
2757 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2758
2759         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2760         defines.
2761         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2762         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2763         (ARM_INT_REGISTER_SIZE): ...to this.
2764         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2765         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2766         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2767         (arm_linux_collect_gregset, supply_nwfpe_register)
2768         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2769         defines.
2770         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2771         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2772         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2773         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2774         (arm_return_in_memory, arm_store_return_value)
2775         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2776         (arm_record_ld_st_multiple): Likewise.
2777         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2778         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2779
2780 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2781
2782         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2783         AARCH64_DISPLACED_MODIFIED_INSNS.
2784         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2785         (aarch64_displaced_step_copy_insn): Likewise.
2786         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2787         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2788         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2789         ARM_DISPLACED_MODIFIED_INSNS.
2790         * arm-tdep.c (arm_gdbarch_init): Likewise.
2791         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2792         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2793         (struct arm_displaced_step_closure): Use
2794         ARM_DISPLACED_MODIFIED_INSNS.
2795
2796 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2797
2798         * features/Makefile: Remove unused xml files.
2799         * features/aarch64.xml: Remove.
2800         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2801         * features/i386/amd64-avx-avx512.xml: Remove.
2802         * features/i386/amd64-avx-linux.xml: Remove.
2803         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2804         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2805         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2806         * features/i386/amd64-avx-mpx.xml: Remove.
2807         * features/i386/amd64-avx.xml: Remove.
2808         * features/i386/amd64-linux.xml: Remove.
2809         * features/i386/amd64-mpx-linux.xml: Remove.
2810         * features/i386/amd64-mpx.xml: Remove.
2811         * features/i386/amd64.xml: Remove.
2812         * features/i386/i386-avx-avx512-linux.xml: Remove.
2813         * features/i386/i386-avx-avx512.xml: Remove.
2814         * features/i386/i386-avx-linux.xml: Remove.
2815         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2816         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2817         * features/i386/i386-avx-mpx-linux.xml: Remove.
2818         * features/i386/i386-avx-mpx.xml: Remove.
2819         * features/i386/i386-avx.xml: Remove.
2820         * features/i386/i386-linux.xml: Remove.
2821         * features/i386/i386-mmx-linux.xml: Remove.
2822         * features/i386/i386-mmx.xml: Remove.
2823         * features/i386/i386-mpx-linux.xml: Remove.
2824         * features/i386/i386-mpx.xml: Remove.
2825         * features/i386/i386.xml: Remove.
2826         * features/i386/x32-avx-avx512-linux.xml: Remove.
2827         * features/i386/x32-avx-linux.xml: Remove.
2828         * features/i386/x32-linux.xml: Remove.
2829
2830 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2831
2832         * regformats/aarch64.dat: Remove.
2833         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2834         * regformats/i386/amd64-avx-linux.dat: Remove.
2835         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2836         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2837         * regformats/i386/amd64-linux.dat: Remove.
2838         * regformats/i386/amd64-mpx-linux.dat: Remove.
2839         * regformats/i386/amd64.dat: Remove.
2840         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2841         * regformats/i386/i386-avx-linux.dat: Remove.
2842         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2843         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2844         * regformats/i386/i386-linux.dat: Remove.
2845         * regformats/i386/i386-mmx-linux.dat: Remove.
2846         * regformats/i386/i386-mpx-linux.dat: Remove.
2847         * regformats/i386/i386.dat: Remove.
2848         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2849         * regformats/i386/x32-avx-linux.dat: Remove.
2850         * regformats/i386/x32-linux.dat: Remove.
2851
2852 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2853
2854         * aarch64-tdep.c: Remove xml self tests.
2855         * amd64-linux-tdep.c: Likewise.
2856         * amd64-tdep.c: Likewise.
2857         * i386-linux-tdep.c: Likewise.
2858         * i386-tdep.c: Likewise.
2859
2860 2019-07-03  Pedro Alves  <palves@redhat.com>
2861
2862         PR cli/24732
2863         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2864         (pipe_cmd_option_defs): New.
2865         (make_pipe_cmd_options_def_group): New.
2866         (pipe_command): Use gdb::option::process_options.
2867         (pipe_command_completer): New function.
2868         (_initialize_cli_cmds): Install completer for "pipe" command.
2869
2870 2019-07-03  Pedro Alves  <palves@redhat.com>
2871
2872         * cli/cli-option.c (union option_value) <string>: New field.
2873         (struct option_def_and_value): Add ctor, move ctor, dtor and
2874         use DISABLE_COPY_AND_ASSIGN.
2875         (option_def_and_value::clear_value): New.
2876         (parse_option, save_option_value_in_ctx, get_val_type_str)
2877         (add_setshow_cmds_for_options): Handle var_string.
2878         * cli-option.h (union option_def::var_address) <string>: New
2879         field.
2880         (struct string_option_def): New.
2881         * maint-test-options.c (struct test_options_opts): Add default
2882         ctor and use DISABLE_COPY_AND_ASSIGN.
2883         <string_opt>: New field.
2884         (test_options_opts::~test_options_opts): New.
2885         (test_options_opts::dump): Also dump "-string".
2886         (test_options_option_defs): Install "string.
2887
2888 2019-07-03  Pedro Alves  <palves@redhat.com>
2889
2890         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2891         option_value with a null enumeration.
2892         (complete_options): Save the option values in the context.
2893         (save_option_value_in_ctx): New, factored out from ...
2894         (process_options): ... here.
2895         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2896         of the function.
2897         * maint-test-options.c (test_options_opts::dump): New, factored
2898         out from ...
2899         (maintenance_test_options_command_mode): ... here.
2900         (maintenance_test_options_command_completion_result): Delete.
2901         (maintenance_test_options_command_completion_text): Update
2902         comment.
2903         (maintenance_show_test_options_completion_result): Change
2904         prototype.  Just print
2905         maintenance_test_options_command_completion_text.
2906         (save_completion_result): New.
2907         (maintenance_test_options_completer_mode): Pass options context to
2908         complete_options, and then save a dump.
2909         (_initialize_maint_test_options): Use add_cmd to install "maint
2910         show test-options-completion-result".
2911
2912 2019-07-03  Pedro Alves  <palves@redhat.com>
2913
2914         * NEWS (New commands): Mention "with" and "maint with".
2915         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2916         (with_command, with_command_completer): New.
2917         (pipe_command): Adjust to new repeat_previous
2918         interface.
2919         (_initialize_cli_cmds): Install the "with" command and its "w"
2920         alias.
2921         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2922         declarations.
2923         * cli/cli-setshow.c (parse_cli_var_uinteger)
2924         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2925         argument strings for all var_types.
2926         (get_setshow_command_value_string): New, factored out from ...
2927         (do_show_command): ... this.
2928         * cli/cli-setshow.h: Include <string>.
2929         (get_setshow_command_value_string): Declare.
2930         * command.h (repeat_previous): Now returns const char *.  Adjust
2931         comment.
2932         * maint.c: Include "cli/cli-cmds.h".
2933         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2934         (_initialize_maint_cmds): Register the "maintenance with" command.
2935         * top.c (repeat_previous): Move bits from pipe_command here:
2936         Return the saved command line, if any; error out if there's no
2937         command to relaunch.
2938
2939 2019-07-03  Pedro Alves  <palves@redhat.com>
2940
2941         * NEWS (New commands): Mention "maint set/show test-settings"
2942         instead of "maint test-settings".
2943         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2944         (maintenance_test_settings_set_list): Rename to ...
2945         (maintenance_set_test_settings_list): ... this.
2946         (maintenance_test_settings_show_list): Rename to  ...
2947         (maintenance_show_test_settings_list): ... this.
2948         (maintenance_test_settings_cmd): Delete.
2949         (maintenance_test_settings_set_cmd): ...
2950         (maintenance_set_test_settings_cmd): ... this.
2951         (maintenance_test_settings_show_cmd): ...
2952         (maintenance_show_test_settings_cmd): ... this.
2953         (maintenance_test_settings_show_value_cmd):
2954         (maintenance_show_test_settings_value_cmd): ... this.
2955         (_initialize_maint_test_settings): No longer install the "maint
2956         test-settings" prefix command.  Rename "maint test-settings set"
2957         to "maint set test-settings", and "maint test-settings show" to
2958         "maint show test-settings".  Adjust all subcommands.
2959
2960 2019-07-03  Pedro Alves  <palves@redhat.com>
2961
2962         * maint-test-settings.c: Fix file's intro comment.  Replace all
2963         references to "test-options" with references to "test-settings",
2964         in comments.
2965
2966 2019-07-03  Pedro Alves  <palves@redhat.com>
2967
2968         * maint-test-settings.c (maintenance_test_settings_xxx)
2969         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2970         New.
2971         (maintenance_test_settings_enums): Use them.
2972         (maintenance_test_settings_enum): Default to
2973         maintenance_test_settings_xxx.
2974         (_initialize_maint_test_settings): Initialize
2975         MAINTENANCE_TEST_SETTINGS_FILENAME.
2976
2977 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2978
2979         * breakpoint.h (remove_breakpoints_inf): Change return type to
2980         void, move function documentation here.
2981         * breakpoint.c (remove_breakpoints_inf): Change return type to
2982         void, move function documentation to header.
2983
2984 2019-07-02  Pedro Alves  <palves@redhat.com>
2985
2986         * NEWS (Completion improvements): Mention "info threads".
2987         * thread.c (struct info_threads_opts, info_threads_option_defs)
2988         (make_info_threads_options_def_group): New.
2989         (info_threads_command): Use gdb::option::process_options.
2990         (info_threads_command_completer): New.
2991         (_initialize_thread): Use gdb::option::build_help to build the
2992         help text for "info threads".
2993
2994 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2995
2996         * defs.h (generic_load): Move from here...
2997         * symfile.h (generic_load): ... to here.  Rename name parameter
2998         to args.
2999         * symfile.c (generic_load): Add comment.
3000
3001 2019-07-01  Tom Tromey  <tromey@adacore.com>
3002
3003         * dwarf2read.c
3004         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3005         declaration of without_params.  Fix formatting.
3006
3007 2019-07-01  Tom Tromey  <tromey@adacore.com>
3008
3009         * ada-exp.y (find_primitive_type): Update.
3010         * ada-lang.h (ada_lookup_symbol): Update.
3011         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3012         parameter.
3013         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3014
3015 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3016
3017         PR breakpoints/24541
3018         * gdbarch.c: Regenerate.
3019         * gdbarch.h: Regenerate.
3020         * gdbarch.sh: Add 'stap_adjust_register'.
3021         * i386-tdep.c: Include '<unordered_set>'.
3022         (i386_stap_adjust_register): New function.
3023         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3024         * stap-probe.c (stap_parse_register_operand): Call
3025         'gdbarch_stap_adjust_register'.
3026
3027 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3028
3029         PR python/24742
3030         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3031         * python/python.c (do_start_initialization): Use 'xmalloc'
3032         instead of 'PyMem_Malloc'.
3033
3034 2019-06-28  Tom Tromey  <tromey@adacore.com>
3035
3036         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3037         for Ada.
3038
3039 2019-06-27  Tom Tromey  <tromey@adacore.com>
3040
3041         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3042         objfile_key.
3043         (arm_find_mapping_symbol, arm_record_special_symbol)
3044         (_initialize_arm_tdep): Update.
3045         (arm_objfile_data_free): Remove.
3046
3047 2019-06-27  Tom Tromey  <tromey@adacore.com>
3048
3049         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3050         to cp_print_static_field.
3051
3052 2019-06-26  Tom Tromey  <tromey@adacore.com>
3053
3054         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3055         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3056         declare.
3057
3058 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3059
3060         * features/aarch64-core.c (create_feature_aarch64_core):
3061         Regenerate.
3062         * features/aarch64-core.xml: Add cpsr flags.
3063
3064 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3065
3066         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3067         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3068
3069 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3070
3071         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3072         field.
3073         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3074         use.
3075         (arm_record_special_symbol): Don't insert new symbol in sorted
3076         position, push it at the end.
3077
3078 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3079
3080         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3081         (arm_mapping_symbol_s): Remove.
3082         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3083         (arm_mapping_symbol_vec): New typedef.
3084         (struct arm_per_objfile): Add constructor.
3085         <section_maps>: Change type to
3086         std::unique_ptr<arm_mapping_symbol_vec[]>.
3087         (arm_compare_mapping_symbols): Remove.
3088         (arm_find_mapping_symbol): Adjust to section_maps type change.
3089         (arm_objfile_data_free): Call delete on arm_per_objfile.
3090         (arm_record_special_symbol): Adjust to section_maps type change.
3091         Allocate arm_per_objfile with new.
3092
3093 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3094
3095         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3096         with the command prefix.
3097
3098 2019-06-25  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3101         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3102
3103 2019-06-25  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3106         type.
3107         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3108         protected.
3109
3110 2019-06-25  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-winsource.c
3113         (tui_source_window_base::set_is_exec_point_at): Add check against
3114         LOA_ADDRESS.
3115
3116 2019-06-25  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-source.c (tui_set_source_content): Don't check before
3119         xfree.
3120         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3121
3122 2019-06-25  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-winsource.h (tui_update_source_window_as_is)
3125         (tui_alloc_source_buffer, tui_line_is_displayed)
3126         (tui_addr_is_displayed): Change type of win_info.
3127         * tui/tui-winsource.c (tui_update_source_window_as_is)
3128         (tui_clear_source_content, tui_show_source_line)
3129         (tui_show_source_content, tui_source_window_base::refill)
3130         (tui_source_window_base::set_is_exec_point_at)
3131         (tui_source_window_base::set_is_exec_point_at)
3132         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3133         (tui_alloc_source_buffer, tui_line_is_displayed)
3134         (tui_addr_is_displayed): Change type of win_info.  Update.
3135         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3136         (tui_source_window_base::do_make_visible_with_new_height):
3137         Update.
3138         * tui/tui-source.c (tui_set_source_content)
3139         (tui_set_source_content_nil)
3140         (tui_source_window::do_scroll_vertical): Update.
3141         * tui/tui-layout.c (show_layout): Update.
3142         * tui/tui-disasm.c (tui_set_disassem_content)
3143         (tui_disasm_window::do_scroll_vertical): Update.
3144         * tui/tui-data.h (tui_win_content): Remove.
3145         (struct tui_gen_win_info) <content, content_size>: Remove.
3146         (struct tui_source_element): Add initializers and destructor.
3147         (union tui_which_element, struct tui_win_element): Remove.
3148         (struct tui_source_window_base) <content>: New field.
3149         (struct tui_data_window): Remove destructor.
3150         (tui_alloc_content, tui_free_win_content)
3151         (tui_free_all_source_wins_content): Don't declare.
3152         * tui/tui-data.c (tui_initialize_static_data): Update.
3153         (init_content_element, tui_alloc_content): Remove.
3154         (~tui_gen_win_info): Update.
3155         (~tui_data_window, tui_free_all_source_wins_content)
3156         (tui_free_win_content, free_content, free_content_elements):
3157         Remove.
3158
3159 2019-06-25  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-winsource.h (tui_clear_source_content)
3162         (tui_erase_source_content, tui_show_source_content): Change type
3163         of win_info.
3164         * tui/tui-winsource.c (tui_clear_source_content)
3165         (tui_erase_source_content, tui_show_source_content): Change type
3166         of win_info.
3167         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3168         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3169         win_info.
3170         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3171         win_info.
3172         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3173
3174 2019-06-25  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-winsource.c (tui_clear_source_content)
3177         (tui_source_window_base::set_is_exec_point_at): Update.
3178         * tui/tui-source.c (tui_set_source_content_nil): Update.
3179         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3180         a bool.
3181         * tui/tui-data.c (init_content_element): Update.
3182
3183 2019-06-25  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3186         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3187         * tui/tui-layout.c (init_and_make_win): Update.
3188         * tui/tui.h (enum tui_win_type): Update.
3189         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3190         tui_win_is_auxillary.
3191         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3192         tui_win_is_auxillary.
3193
3194 2019-06-25  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3197         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3198         (tui_delete_data_content_windows, tui_display_all_data)
3199         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3200         Update.
3201         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3202         * tui/tui-regs.c (tui_last_regs_line_no)
3203         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3204         (tui_show_registers): Update.
3205         (tui_show_register_group): Return void.  Update.
3206         (tui_display_registers_from, tui_display_reg_element_at_line)
3207         (tui_display_registers_from_line, tui_check_register_values):
3208         Update.
3209         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3210         member.
3211         (struct tui_data_window) <regs_content>: Now a std::vector.
3212         <regs_content_count>: Remove.
3213         (tui_add_content_elements, tui_free_data_content): Don't declare.
3214         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3215         (init_content_element): Remove DATA_WIN case.  Add assert.
3216         (tui_add_content_elements): Remove.
3217         (tui_data_window): Update.
3218         (tui_free_data_content): Remove.
3219         (free_content_elements): Remove DATA_WIN case.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-data.c (tui_data_item_window): Update.
3224         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3225         * tui/tui-windata.c (tui_display_all_data)
3226         (tui_display_data_from_line): Update.
3227         (tui_check_data_values): Remove.
3228         * tui/tui-regs.c (tui_show_register_group)
3229         (tui_display_reg_element_at_line): Update.
3230         * tui/tui-hooks.c (tui_register_changed)
3231         (tui_refresh_frame_and_register_information): Call
3232         tui_check_register_values.
3233         * tui/tui-data.h (struct tui_data_window) <data_content,
3234         data_content_count, data_type>: Remove.
3235         (enum tui_data_type): Remove.
3236
3237         * tui/tui-data.c (tui_data_window::clear_detail)
3238         (~tui_data_window): Update.
3239
3240 2019-06-25  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3243         declare.
3244         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3245         Rename from tui_first_data_item_displayed.  Update.
3246         (tui_data_window::refresh_all)
3247         (tui_data_window::do_scroll_vertical): Update.
3248         * tui/tui-data.h (struct tui_data_window)
3249         <first_data_item_displayed>: Declare new method.
3250
3251 2019-06-25  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3254         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3255         contents...
3256         (tui_initialize_static_data): ...here.
3257
3258 2019-06-25  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3261         (tui_display_registers_from, tui_check_register_values): Update.
3262         (tui_display_register): Remove win_info parameter; update.
3263         (tui_get_register): Change type of parameters.
3264         * tui/tui-data.h (struct tui_data_element): Remove.
3265         (union tui_which_element) <data>: Remove.
3266         <data_window>: Change type.
3267         (struct tui_data_item_window): New.
3268         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3269         case.  Add assert.
3270         (~tui_data_item_window): New destructor.
3271         (free_content_elements): Remove DATA_ITEM_WIN case.
3272
3273 2019-06-25  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3276         Remove.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-data.h (struct tui_command_element): Remove.
3281         (union tui_which_element) <command>: Remove.
3282         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3283         assert.
3284         (free_content_elements): Remove CMD_WIN case.
3285
3286 2019-06-25  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-layout.c (tui_set_layout): Update.
3289         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3290         * tui/tui-data.c (layout_def): Update.
3291
3292 2019-06-25  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3295         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3296         (tui_source_window_base::set_new_height): Update.
3297         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3298         Update.
3299         (tui_set_locator_fullname, tui_set_locator_info)
3300         (tui_show_frame_info): Update.
3301         * tui/tui-source.c (tui_set_source_content)
3302         (tui_source_is_displayed): Update.
3303         * tui/tui-layout.c (show_source_disasm_command, show_data)
3304         (show_source_or_disasm_and_command): Update.
3305         * tui/tui-disasm.c (tui_set_disassem_content)
3306         (tui_get_begin_asm_address): Update.
3307         * tui/tui-data.h (struct tui_locator_element): Remove.
3308         (union tui_which_element) <locator>: Remove.
3309         (struct tui_locator_window): New.
3310         (tui_locator_win_info_ptr): Change return type.
3311         * tui/tui-data.c (_locator): Change type.
3312         (tui_locator_win_info_ptr): Change return type.
3313         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3314         (tui_alloc_content): Add assert.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-winsource.c
3319         (tui_exec_info_window::maybe_allocate_content): New method.
3320         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3321         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3322         (make_source_or_disasm_window): Add cast.
3323         * tui/tui-data.h (union tui_which_element) <simple_string>:
3324         Remove.
3325         (struct tui_source_info): New.
3326         (struct tui_source_window_base) <execution_info>: Change type.
3327         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3328         case, and add assert.
3329         (tui_alloc_content): Add assert.
3330
3331 2019-06-25  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3334         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3335         * tui/tui-data.c (tui_alloc_win_info): Remove.
3336
3337 2019-06-25  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3340         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3341         can_highlight.
3342
3343 2019-06-25  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3346         make_visible_with_new_height method.
3347         (tui_win_info::make_visible_with_new_height): New method.
3348         (tui_source_window_base::do_make_visible_with_new_height)
3349         (tui_data_window::do_make_visible_with_new_height)
3350         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3351         (make_visible_with_new_height): Remove.
3352         (tui_resize_all, tui_adjust_win_heights): Use
3353         make_visible_with_new_height method.
3354         * tui/tui-data.h (struct tui_win_info)
3355         <do_make_visible_with_new_height, make_visible_with_new_height>:
3356         New methods.
3357         (struct tui_source_window_base, struct tui_data_window)
3358         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3359         methods.
3360
3361 2019-06-25  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3364         method.
3365         (update_tab_width): Call update_tab_width method.
3366         * tui/tui-data.h (struct tui_win_info)
3367         (struct tui_source_window_base) <update_tab_width>: New methods.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3372         parameter.
3373         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3374         parameter.
3375         (tui_gen_win_info::make_visible): Update.
3376         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3377         parameter.
3378         * tui/tui-data.h (enum tui_box): New enum.
3379         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3384         init_and_make_win for EXEC_INFO_WIN.
3385         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3386         longer inline.
3387         (struct tui_win_info) <~tui_win_info>: Inline.
3388         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3389         Don't declare.
3390         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3391         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3392         Remove.
3393         (tui_initialize_static_data): Update.
3394         (~tui_gen_win_info): Handle more cleanup here.
3395         (~tui_source_window_base): Delete "execution_info".
3396         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3397
3398 2019-06-25  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-layout.c (make_command_window): Don't set
3401         can_highlight.
3402         (show_source_disasm_command): Call the reset method.
3403         (show_data): Don't set can_highlight.  Call the reset method.
3404         (tui_gen_win_info::reset): Rename from init_gen_win_info
3405         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3406         (show_source_or_disasm_and_command): Call the reset method.
3407         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3408         (struct tui_cmd_window): Set can_highlight.
3409
3410 2019-06-25  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3413         from make_visible.
3414         (tui_make_visible, tui_make_invisible): Rewrite.
3415         (tui_win_info::make_visible): Remove.
3416         (tui_source_window_base::make_visible): Update.
3417         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3418         method.  Moved from...
3419         (struct tui_win_info) <make_visible>: ...here.
3420
3421 2019-06-25  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-winsource.c
3424         (tui_source_window_base::do_scroll_horizontal): Remove direction
3425         parameter.
3426         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3427         direction parameter.
3428         * tui/tui-win.c (tui_win_info::forward_scroll)
3429         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3430         (tui_win_info::right_scroll): Update.
3431         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3432         direction parameter.
3433         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3434         direction parameter.
3435         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3436         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3437         Remove direction parameter.
3438         (struct tui_source_window_base, struct tui_source_window)
3439         (struct tui_disasm_window, struct tui_data_window)
3440         (struct tui_cmd_window): Update.
3441
3442 2019-06-25  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-winsource.h (tui_set_exec_info_content)
3445         (tui_show_exec_info_content, tui_erase_exec_info_content)
3446         (tui_clear_exec_info_content, tui_update_exec_info): Change
3447         argument to tui_source_window_base.
3448         * tui/tui-winsource.c (tui_set_exec_info_content)
3449         (tui_show_exec_info_content, tui_erase_exec_info_content)
3450         (tui_clear_exec_info_content, tui_update_exec_info): Change
3451         argument to tui_source_window_base.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3456         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3457
3458 2019-06-25  Tom Tromey  <tom@tromey.com>
3459
3460         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3461         check.
3462
3463 2019-06-25  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3466         type to void.
3467         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3468         type to void.
3469         * tui/tui-source.c (tui_set_source_content): Update.
3470         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3471
3472 2019-06-25  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-win.c (window_name_completer, tui_set_focus)
3475         (tui_all_windows_info): Use name method.
3476         * tui/tui-data.h (struct tui_gen_win_info)
3477         (struct tui_source_window, struct tui_disasm_window)
3478         (struct tui_data_window, struct tui_cmd_window) <name>: New
3479         method.
3480         (tui_win_name): Don't declare.
3481         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3482         (tui_win_name): Remove.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-winsource.h (tui_update_source_window)
3487         (tui_update_source_window_as_is): Change parameter type.
3488         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3489         to be a tui_source_window_base.
3490         (tui_update_source_window_as_is): Likewise.
3491         * tui/tui-win.c (make_visible_with_new_height): Update.
3492
3493 2019-06-25  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-winsource.c (tui_erase_source_content)
3496         (tui_show_source_content, tui_show_exec_info_content)
3497         (tui_erase_exec_info_content): Use refresh_window method.
3498         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3499         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3500         from tui_refresh_win.
3501         (tui_data_window::refresh_window): New method.
3502         (tui_win_info::refresh, tui_source_window_base::refresh)
3503         (tui_refresh_all): Use refresh_window method.
3504         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3505         method.
3506         * tui/tui-regs.c (tui_display_register): Call refresh_window
3507         method.
3508         * tui/tui-layout.c (show_source_disasm_command)
3509         (show_source_or_disasm_and_command): Call refresh_window method.
3510         * tui/tui-data.h (struct tui_gen_win_info)
3511         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3512         New method.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui.c (tui_rl_other_window, tui_enable)
3517         (tui_is_window_visible, tui_get_command_dimension): Update.
3518         * tui/tui-winsource.c (tui_update_source_window_as_is)
3519         (tui_clear_source_content, tui_erase_source_content)
3520         (tui_show_source_line, tui_source_window_base::refill)
3521         (tui_source_window_base::do_scroll_horizontal)
3522         (tui_source_window_base::set_is_exec_point_at)
3523         (tui_update_breakpoint_info, tui_set_exec_info_content)
3524         (tui_alloc_source_buffer, tui_line_is_displayed)
3525         (tui_addr_is_displayed): Update.
3526         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3527         (tui_check_and_display_highlight_if_needed)
3528         (tui_win_info::make_visible, tui_win_info::refresh)
3529         (tui_refresh_all): Update.
3530         * tui/tui-windata.c (tui_first_data_item_displayed)
3531         (tui_delete_data_content_windows, tui_erase_data_content)
3532         (tui_display_all_data, tui_data_window::refresh_all)
3533         (tui_check_data_values): Update.
3534         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3535         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3536         (tui_win_info::backward_scroll, tui_refresh_all_win)
3537         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3538         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3539         (tui_source_window_base::set_new_height)
3540         (tui_data_window::set_new_height)
3541         (make_invisible_and_set_new_height)
3542         (make_visible_with_new_height, new_height_ok)
3543         (parse_scrolling_args): Update.
3544         * tui/tui-stack.c (tui_show_frame_info): Update.
3545         * tui/tui-source.c (tui_set_source_content)
3546         (tui_set_source_content_nil, tui_source_is_displayed)
3547         (tui_source_window::do_scroll_vertical): Update.
3548         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3549         (tui_display_registers_from, tui_display_reg_element_at_line)
3550         (tui_check_register_values, tui_reg_command): Update.
3551         * tui/tui-layout.c (tui_default_win_height)
3552         (show_source_disasm_command, show_data, init_and_make_win)
3553         (show_source_or_disasm_and_command): Update.
3554         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3555         (tui_redisplay_readline, tui_mld_flush)
3556         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3557         (tui_getc): Update.
3558         * tui/tui-disasm.c (tui_set_disassem_content)
3559         (tui_disasm_window::do_scroll_vertical): Update.
3560         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3561         Now virtual.
3562         (struct tui_win_info): Derive from tui_gen_win_info.
3563         <~tui_win_info>: Mark as override.
3564         <generic>: Remove member.
3565         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3566         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3567         (~tui_data_window, ~tui_win_info)
3568         (tui_free_all_source_wins_content): Update.
3569         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3570
3571 2019-06-25  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-layout.c (init_and_make_win): Use new.
3574         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3575         destructor, initializers.
3576         (tui_alloc_generic_win_info): Don't declare.
3577         * tui/tui-data.c (_locator): Add argument to constructor.
3578         (source_win, disasm_win): New globals.
3579         (exec_info): Remove.
3580         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3581         Update.
3582         (tui_alloc_generic_win_info): Remove.
3583         (init_content_element): Use new.
3584         (tui_win_info::tui_win_info): Update.
3585         (free_content_elements) <case DATA_WIN>: Use delete.
3586
3587 2019-06-25  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3590         * tui/tui-windata.c (tui_first_data_item_displayed)
3591         (tui_delete_data_content_windows): Update.
3592         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3593         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3594         (tui_display_registers_from, tui_check_register_values): Update.
3595         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3596         pointer.
3597         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3598         window.
3599         (tui_free_data_content): Update.
3600         (free_content_elements) <case DATA_WIN>: Free the window.
3601
3602 2019-06-25  Tom Tromey  <tom@tromey.com>
3603
3604         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3605         Update.
3606         * tui/tui-layout.c (make_command_window)
3607         (show_source_disasm_command, show_data, init_and_make_win)
3608         (show_source_or_disasm_and_command): Update.
3609         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3610         method.
3611         <can_highight, is_highlighted>: Now bool.
3612         (tui_set_win_highlight): Don't declare.
3613         * tui/tui-data.c (tui_set_win_highlight): Remove.
3614
3615 2019-06-25  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-wingeneral.c (make_visible): Remove check of window
3618         type.
3619
3620 2019-06-25  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-win.c (tui_win_info::max_height)
3623         (tui_cmd_window::max_height): New methods.
3624         (new_height_ok): Call max_height.
3625         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3626         <max_height>: New method.
3627
3628 2019-06-25  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-win.c (tui_source_window_base::set_new_height)
3631         (tui_data_window::set_new_height): New methods.
3632         (make_invisible_and_set_new_height): Call set_new_height method.
3633         * tui/tui-data.h (struct tui_win_info)
3634         (struct tui_source_window_base, struct tui_data_window)
3635         <set_new_height>: New method.
3636
3637 2019-06-25  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3640         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3641         tui_refresh_data_win.
3642         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3643         method.
3644         (tui_refresh_all_win): Call the refresh_all method.
3645         (tui_set_focus): Likewise.
3646         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3647         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3648         Likewise.
3649
3650 2019-06-25  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-winsource.h (tui_refill_source_window)
3653         (tui_set_is_exec_point_at): Don't declare.
3654         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3655         (tui_source_window_base::refill): Rename from
3656         tui_refill_source_window.
3657         (tui_source_window_base::do_scroll_horizontal): Update.
3658         (tui_source_window_base::set_is_exec_point_at): Rename from
3659         tui_set_is_exec_point_at.
3660         (tui_update_all_breakpoint_info): Update.
3661         * tui/tui-stack.c (tui_show_frame_info): Update.
3662         * tui/tui-layout.c (show_data): Add cast.
3663         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3664         * tui/tui-data.h (struct tui_source_window_base) <refill,
3665         set_is_exec_point_at>: New methods.
3666         (tui_source_windows, tui_add_to_source_windows): Update types.
3667         (tui_add_to_source_windows): Remove redundant declaration.
3668         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3669         (tui_source_windows): Change return type.
3670         (tui_clear_source_windows_detail): Update.
3671         (tui_add_to_source_windows): Change type of parameter.
3672         (tui_free_all_source_wins_content): Update.
3673
3674 2019-06-25  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-wingeneral.c (tui_win_info::refresh)
3677         (tui_source_window_base::refresh): New methods.
3678         (tui_refresh_all): Call the refresh method.
3679         * tui/tui-data.h (struct tui_win_info)
3680         (struct tui_source_window_base) <refresh>: New method.
3681
3682 2019-06-25  Tom Tromey  <tom@tromey.com>
3683
3684         * tui/tui.h (tui_is_window_visible): Return bool.
3685         * tui/tui.c (tui_is_window_visible): Return bool.
3686         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3687         (tui_make_visible, tui_make_invisible)
3688         (tui_win_info::make_visible)
3689         (tui_source_window_base::make_visible, make_all_visible)
3690         (tui_make_all_visible, tui_make_all_invisible): Update.
3691         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3692         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3693         bool.
3694         (struct tui_win_info, struct tui_source_window_base)
3695         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3696         * tui/tui-data.c (tui_init_generic_part): Update.
3697
3698 2019-06-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3701         (tui_source_window_base::make_visible): New methods.
3702         (make_all_visible): Make method call.
3703         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3704         (struct tui_source_window_base, struct tui_cmd_window): Override
3705         make_visible.
3706         (tui_win_is_source_type): Don't declare.
3707         * tui/tui-data.c (tui_win_is_source_type): Remove.
3708
3709 2019-06-25  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3712         NULL check.
3713
3714 2019-06-25  Tom Tromey  <tom@tromey.com>
3715
3716         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3717         Inline constructor.  Add initializers for members.
3718         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3719         constructors; now inline in class.
3720
3721 2019-06-25  Tom Tromey  <tom@tromey.com>
3722
3723         * tui/tui-regs.c (tui_show_registers): Update.
3724         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3725         bool.
3726         * tui/tui-data.c (tui_data_window::clear_detail)
3727         (tui_data_window): Update.
3728
3729 2019-06-25  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-windata.c (tui_display_all_data)
3732         (tui_display_data_from_line, tui_display_data_from)
3733         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3734         Update.
3735         * tui/tui-regs.c (tui_last_regs_line_no)
3736         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3737         (tui_show_registers, tui_show_register_group)
3738         (tui_display_registers_from, tui_display_reg_element_at_line)
3739         (tui_display_registers_from_line, tui_check_register_values)
3740         (tui_reg_next, tui_reg_prev): Update.
3741         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3742         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3743         tui_data_window.
3744         (struct tui_win_info) <detail>: Remove.  Add new fields from
3745         tui_data_info.
3746         (TUI_DATA_WIN): Add cast.
3747         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3748         (~tui_data_window): Simplify.
3749
3750 2019-06-25  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-layout.c (show_source_disasm_command)
3753         (show_source_or_disasm_and_command): Update.
3754         * tui/tui-io.c (update_cmdwin_start_line)
3755         (tui_redisplay_readline): Update.
3756         * tui/tui-data.h (struct tui_command_info): Remove.
3757         (struct tui_win_info) <detail>: Remove command_info member.
3758         (struct tui_data_window) <start_line>: New member, from
3759         tui_command_info.
3760         (TUI_CMD_WIN): Add casts.
3761
3762 2019-06-25  Tom Tromey  <tom@tromey.com>
3763
3764         * tui/tui-winsource.c (tui_update_source_window)
3765         (tui_refill_source_window)
3766         (tui_source_window_base::do_scroll_horizontal)
3767         (tui_update_breakpoint_info, tui_set_exec_info_content)
3768         (tui_show_exec_info_content, tui_erase_exec_info_content)
3769         (tui_clear_exec_info_content): Update.
3770         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3771         Update.
3772         * tui/tui-win.c (make_invisible_and_set_new_height)
3773         (make_visible_with_new_height): Update.
3774         * tui/tui-source.c (tui_set_source_content)
3775         (tui_show_symtab_source): Update.
3776         * tui/tui-layout.c (extract_display_start_addr)
3777         (show_source_disasm_command, show_data)
3778         (make_source_or_disasm_window)
3779         (show_source_or_disasm_and_command): Update.
3780         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3781         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3782         "gdbarch".
3783         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3784         to tui_source_window_base.
3785         (struct tui_win_info) <detail>: Remove source_info member.
3786         (struct tui_source_window_base) <has_locator>: Inline.
3787         Move contents from tui_source_info; rename has_locator member to
3788         m_has_locator.
3789         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3790         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3791         header file.
3792         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3793         Simplify.
3794         (tui_free_all_source_wins_content): Cast to
3795         tui_source_window_base.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-win.c (make_invisible_and_set_new_height)
3800         (make_visible_with_new_height): Call has_locator method.
3801         * tui/tui-layout.c (show_source_disasm_command, show_data)
3802         (show_source_or_disasm_and_command): Update for bool change.
3803         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3804         (tui_win_info) <has_locator>: New method.
3805         (struct tui_source_window_base) <has_locator>: New method.
3806         (tui_win_has_locator): Don't declare.
3807         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3808         from tui_win_has_locator.
3809         (tui_source_window_base): Use false, not FALSE.
3810
3811 2019-06-25  Tom Tromey  <tom@tromey.com>
3812
3813         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3814         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3815         clear_detail method directly.
3816         (tui_clear_win_detail): Remove.
3817
3818 2019-06-25  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3821         "this", not TUI_DISASM_WIN.
3822
3823 2019-06-25  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3826         declare.
3827         * tui/tui-winsource.c
3828         (tui_source_window_base::do_scroll_horizontal): Rename from
3829         tui_horizontal_source_scroll.
3830         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3831         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3832         from tui_vertical_data_scroll.
3833         * tui/tui-win.h (tui_scroll): Don't declare.
3834         * tui/tui-win.c (tui_win_info::forward_scroll)
3835         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3836         (tui_win_info::right_scroll): Rename and update.
3837         (tui_scroll_forward_command, tui_scroll_backward_command)
3838         (tui_scroll_left_command, tui_scroll_right_command): Update.
3839         (tui_scroll): Remove.
3840         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3841         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3842         from tui_vertical_source_scroll.
3843         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3844         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3845         from tui_vertical_disassem_scroll.
3846         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3847         do_scroll_horizontal>: New methods.
3848         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3849         Likewise.
3850         (struct tui_source_window_base): Add do_scroll_horizontal.
3851         (struct tui_source_window, struct tui_disasm_window): Add
3852         do_scroll_vertical.
3853         (struct tui_data_window, struct tui_cmd_window): Add
3854         do_scroll_horizontal and do_scroll_vertical.
3855         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3856
3857 2019-06-25  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-data.h (struct tui_source_window_base): New struct.
3860         (struct tui_source_window): Derive from tui_source_window_base.
3861         (struct tui_disasm_window): New struct.
3862         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3863         from tui_source_window::clear_detail.
3864         (tui_source_window_base): Rename from tui_source_window.
3865         (~tui_source_window_base): Rename from ~tui_source_window.
3866         (tui_alloc_win_info): Create a tui_disasm_window.
3867
3868 2019-06-25  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-data.h (struct tui_source_window)
3871         (struct tui_data_window): Declare destructors.
3872         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3873         destructors.
3874         (tui_win_info): Simplify.
3875
3876 2019-06-25  Tom Tromey  <tom@tromey.com>
3877
3878         * tui/tui-winsource.c (tui_display_main)
3879         (tui_update_source_windows_with_addr)
3880         (tui_update_all_breakpoint_info): Update.
3881         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3882         (new_height_ok, parse_scrolling_args): Update.
3883         * tui/tui-stack.c (tui_show_frame_info): Update.
3884         * tui/tui-data.h (struct tui_list): Remove.
3885         (tui_source_windows): Return a reference to a std::vector.
3886         * tui/tui-data.c (source_windows): Now a std::vector.
3887         (tui_source_windows): Change return type.
3888         (tui_clear_source_windows): Rewrite.
3889         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3890         (tui_free_all_source_wins_content): Rewrite.
3891
3892 2019-06-25  Tom Tromey  <tom@tromey.com>
3893
3894         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3895         (struct tui_data_window, struct tui_cmd_window): Declare
3896         clear_detail method.
3897         * tui/tui-data.c (tui_source_window::clear_detail)
3898         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3899         methods.
3900         (tui_clear_win_detail): Simplify.
3901
3902 2019-06-25  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-layout.c (make_source_window, make_disasm_window)
3905         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3906         Return the new window.
3907         (show_source_disasm_command, show_data)
3908         (show_source_or_disasm_and_command): Update.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3913         parameter.  Return the new window.
3914         (show_source_disasm_command): Update and remove NULL check.
3915         (show_source_or_disasm_and_command): Update.
3916
3917 2019-06-25  Tom Tromey  <tom@tromey.com>
3918
3919         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3920
3921 2019-06-25  Tom Tromey  <tom@tromey.com>
3922
3923         * tui/tui-data.h (struct tui_win_info): Make constructor
3924         protected.  Make destructor virtual.  Add initializers.
3925         (tui_source_window, tui_data_window, tui_cmd_window): New
3926         classes.
3927         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3928         constructor.  Add "type" parameter.
3929         (tui_source_window, tui_data_window, tui_cmd_window): New
3930         constructors.
3931         (tui_alloc_win_info): Instantiate the appropriate subclass.
3932
3933 2019-06-25  Tom Tromey  <tom@tromey.com>
3934
3935         * tui/tui-win.c (tui_resize_all): Use delete.
3936         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3937         destructor.
3938         (tui_free_window): Don't declare.
3939         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3940         Update.
3941
3942 2019-06-25  Tom Tromey  <tom@tromey.com>
3943
3944         * tui/tui-data.h (struct tui_win_info): Add constructor.
3945         * tui/tui-data.c (tui_alloc_win_info): Use new.
3946         (tui_free_window): Use delete.
3947
3948 2019-06-22  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3951         declare.
3952         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3953
3954 2019-06-22  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3957         declare.
3958         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3959
3960 2019-06-22  Tom de Vries  <tdevries@suse.de>
3961
3962         * dwarf2read.c (create_addrmap_from_aranges)
3963         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3964         instead of '%zu'.
3965
3966 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3967
3968         * dwarf2read.h (dwarf2_section_info_def): Remove.
3969         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3970         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3971         std::vector<dwarf2_section_info>.
3972         (struct dwo_file) <~dwo_file>: Remove.
3973         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3974         types field.
3975         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3976         (dwarf2_read_debug_names): Likewise.
3977         (create_debug_types_hash_table): Change parameter type to
3978         array_view, adjust code accordingly.
3979         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3980         (partial_die_info::fixup): Likewise.
3981         (determine_prefix): Likewise.
3982         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3983
3984 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3985
3986         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3987         gdb_bfd_ref_ptr.
3988         <~dwo_file>: Remove call to gdb_bfd_unref.
3989         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3990         gdb_bfd_ref_ptr::get.
3991
3992 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3993
3994         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3995         type to htab_up.
3996         * dwarf2read.c (struct dwo_file): Initialize fields.
3997         <~dwo_file>: New.
3998         (free_dwo_file): Remove, move content to ~dwo_file.
3999         (struct dwo_file_deleter): Remove.
4000         (dwo_file_up>: Remove custom deleter.
4001         (free_dwo_files): Remove.
4002         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4003         dwo_files.
4004         (process_skeletonless_type_units): Call unique_ptr::get.
4005         (allocate_dwo_file_hash_table): Add deleter to created hash
4006         table.  Change return type to htab_up.
4007         (lookup_dwo_file_slot): Don't memset dwo_file, call
4008         unique_ptr::get.
4009         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4010         (create_dwo_unit_in_dwp_v2): Likewise.
4011         (open_and_init_dwo_file): Likewise.
4012         (free_dwo_file_from_slot): Remove.
4013
4014 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4015
4016         * dwarf2read.h (struct dwarf2_section_info) <readin,
4017         is_virtual>: Change type to bool.
4018         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4019         true instead of 1.
4020
4021 2019-06-19  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-data.h (tui_init_content_element): Don't declare.
4024
4025 2019-06-19  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-data.h (tui_init_win_info): Don't declare.
4028
4029 2019-06-19  Tom de Vries  <tdevries@suse.de>
4030
4031         * dwarf2read.h (abstract_to_concrete): Change type to
4032         std::unordered_map<sect_offset, std::vector<sect_offset>,
4033         gdb::hash_enum<sect_offset>>.
4034
4035 2019-06-19  Tom Tromey  <tromey@adacore.com>
4036
4037         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4038         EVAL_AVOID_SIDE_EFFECTS specially.
4039
4040 2019-06-19  Tom Tromey  <tromey@adacore.com>
4041
4042         * source-cache.c (highlighter): New global.
4043         (source_cache::get_source_lines): Create a highlighter on demand.
4044
4045 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * defs.h (deprecated_interactive_hook): Delete declaration.
4048         * interps.c (clear_interpreter_hooks): Remove use of
4049         deprecated_interactive_hook.
4050         * top.c (deprecated_interactive_hook): Delete definition.
4051         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4052
4053 2019-06-18  Tom de Vries  <tdevries@suse.de>
4054
4055         PR gdb/24515
4056         * dwarf2read.h (abstract_to_concrete): Change type from
4057         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4058         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4059         * dwarf2read.c (read_variable): Update.
4060         (dwarf2_fetch_die_loc_sect_off): Update.
4061
4062 2019-06-17  Tom de Vries  <tdevries@suse.de>
4063
4064         PR gdb/24617
4065         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4066         accessing parent[parent_len - 1].
4067
4068 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4069
4070         PR gdb/24364
4071         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4072         call dtrace_process_dof with NULL dof.
4073
4074 2019-06-16  Tom de Vries  <tdevries@suse.de>
4075
4076         PR gdb/24445
4077         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4078
4079 2019-06-16  Tom Tromey  <tom@tromey.com>
4080
4081         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4082         (make_all_visible): Use address of member.
4083
4084 2019-06-16  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4087         (tui_free_window, free_content, free_content_elements): Remove
4088         unnecessary cast.
4089         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4090         cast.
4091         * tui/tui-regs.c (tui_show_register_group)
4092         (tui_display_registers_from, tui_display_reg_element_at_line):
4093         Remove unnecessary cast.
4094
4095 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * linux-nat.c (normal_mask): Delete.
4098         (_initialize_linux_nat): Don't initialise normal_mask.
4099
4100 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4101
4102         PR gdb/24445
4103         * dwarf-index-write.h (write_psymtabs_to_index): Add
4104         dwz_basename parameter.
4105         * dwarf-index-write.c (write_gdbindex): Move file writing to
4106         write_gdbindex_1.  Change return type void.
4107         (assert_file_size): Move up, remove filename parameter.
4108         (write_gdbindex_1): New function.
4109         (write_debug_names): Change return type to void, call
4110         assert_file_size.
4111         (struct index_wip_file): New struct.
4112         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4113         file logic to index_wip_file.  Write index for dwz file if
4114         needed.
4115         (save_gdb_index_command): Pass basename of dwz file, if present.
4116         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4117         build-id of dwz file, if present.
4118         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4119         (dwarf2_get_dwz_file): Likewise.
4120         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4121         (dwarf2_get_dwz_file): Likewise.
4122
4123 2019-06-16  Tom Tromey  <tom@tromey.com>
4124
4125         * coffread.c (process_coff_symbol): Use xstrdup.
4126         * value.c (create_internalvar): Use xstrdup.
4127
4128 2019-06-16  Tom Tromey  <tom@tromey.com>
4129
4130         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4131         * breakpoint.c (stopin_command, stopat_command)
4132         (until_break_command, decode_location_default): Remove unnecessary
4133         cast.
4134         * utils.c (subset_compare): Remove unnecessary cast.
4135         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4136         cast.
4137         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4138         cast.
4139         * infcmd.c (path_command): Remove unnecessary cast.
4140         * coffread.c (decode_type): Remove unnecessary cast.
4141         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4142         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4143         * tui/tui-stack.c (tui_show_locator_content)
4144         (tui_show_frame_info): Remove unnecessary cast.
4145         * tui/tui-win.c (tui_scroll_forward_command)
4146         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4147         (parse_scrolling_args): Remove unnecessary cast.
4148         * tui/tui-data.c (init_win_info, tui_del_window)
4149         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4150         (free_content_elements): Remove unnecessary cast.
4151         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4152         unnecessary cast.
4153         * tui/tui-source.c (tui_set_source_content)
4154         (tui_vertical_source_scroll): Remove unnecessary cast.
4155         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4156         cast.
4157         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4158         * tui/tui-regs.c (tui_display_registers_from)
4159         (tui_display_register): Remove unnecessary cast.
4160         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4161         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4162         (make_visible): Remove unnecessary cast.
4163         * tui/tui-winsource.c (tui_erase_source_content)
4164         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4165         unnecessary cast.
4166         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4167         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4168         * stabsread.c (read_type, read_array_type, read_range_type):
4169         Remove unnecessary cast.
4170         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4171         (parse_symbol, parse_type, upgrade_type, parse_external)
4172         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4173         unnecessary cast.
4174         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4175
4176 2019-06-16  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui-data.c (tui_alloc_generic_win_info)
4179         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4180         checks.
4181
4182 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4183             Andrew Burgess  <andrew.burgess@embecosm.com>
4184
4185         * f-typeprint.c (f_print_type): Don't return early for not
4186         associated or not allocated types.
4187         (f_type_print_varspec_suffix): Add print_rank parameter and print
4188         ranks of array types in case they dangling.
4189         (f_type_print_base): Add print_rank parameter.
4190
4191 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4192
4193         * NEWS: Mention new MI commands.
4194         * break-catch-throw.c (enum exception_event_kind): Move to
4195         breakpoint.h.
4196         (print_mention_exception_catchpoint): Output text as a single
4197         message.
4198         (catch_exception_command_1): Rename to...
4199         (catch_exception_event): ...this, make non-static, update header
4200         command, and change some parameter types.
4201         (catch_catch_command): Update for changes to
4202         catch_exception_command_1.
4203         (catch_throw_command): Likewise.
4204         (catch_rethrow_command): Likewise.
4205         * breakpoint.c (enum exception_event_kind): Delete.
4206         * breakpoint.h (enum exception_event_kind): Moved here from
4207         break-catch-throw.c.
4208         (catch_exception_event): Declare.
4209         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4210         (mi_cmd_catch_throw): New function.
4211         (mi_cmd_catch_rethrow): New function.
4212         (mi_cmd_catch_catch): New function.
4213         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4214         'catch-catch' entries.
4215         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4216         (mi_cmd_catch_rethrow): Declare.
4217         (mi_cmd_catch_catch): Declare.
4218
4219 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4220
4221         * annotate.c (annotate_source_line): Change return type to void,
4222         update implementation to match.
4223         * annotate.h (annotate_source_line): Change return type to void,
4224         update header comment.
4225         * stack.c (print_frame_info): Don't change what frame information
4226         is printed based on whether annotations are on or not.
4227
4228 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4231         (annotate_source): Make static.
4232         (annotate_source_line): Moved from source.c and renamed from
4233         identify_source_line.  Update the return type.
4234         * annotate.h (annotate_source): Delete declaration.
4235         (annotate_source_line): Declaration moved from source.h, and
4236         renamed from identify_source_line.  Return type updated.
4237         * source.c (identify_source_line): Moved to annotate.c and renamed
4238         to annotate_source_line.
4239         (info_line_command): Remove check of annotation_level.
4240         * source.h (identify_source_line): Move declaration to annotate.h
4241         and rename to annotate_source_line.
4242         * stack.c: Add 'annotate.h' include.
4243         (print_frame_info): Remove check of annotation_level before
4244         calling annotate_source_line.
4245
4246 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * source-cache.c (source_cache::get_plain_source_lines): Use
4249         open_source_file_with_line_charpos instead of just
4250         open_source_file, remove call to find_source_lines.
4251         (source_cache::get_source_lines): Likewise.
4252         * source.c (find_source_lines): Make static.
4253         (get_filename_and_charpos): Renamed into...
4254         (open_source_file_with_line_charpos): ..this along with changes to
4255         return a scoped_fd, and some other minor clean ups.
4256         (identify_source_line): Use open_source_file_with_line_charpos.
4257         (search_command_helper): Use open_source_file_with_line_charpos
4258         instead of just open_source_file, remove call to
4259         find_source_lines.
4260         * source.h (open_source_file_with_line_charpos): Declare new
4261         function.
4262         (find_source_lines): Delete declaration.
4263
4264 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * source.c (get_filename_and_charpos): Remove fullname
4267         parameter.
4268         (identify_source_line): Update call to get_filename_and_charpos.
4269
4270 2019-06-14  Tom Tromey  <tromey@adacore.com>
4271
4272         PR gdb/24502:
4273         * ui-style.h (skip_ansi_escape): Update comment.
4274         * ui-file.h (class no_terminal_escape_file): New class.
4275         * ui-file.c (no_terminal_escape_file::write)
4276         (no_terminal_escape_file::puts): New methods.
4277         * cli/cli-logging.c (handle_redirections): Use
4278         no_terminal_escape_file.
4279
4280 2019-06-14  Tom Tromey  <tromey@adacore.com>
4281
4282         * NEWS: Move convenience variable news above Python news.
4283
4284 2019-06-14  Tom Tromey  <tom@tromey.com>
4285
4286         * gnulib: Move directory to top-level.
4287         * configure.ac: Don't configure gnulib.
4288         * configure: Rebuild.
4289         * common/common-defs.h: Use new path to gnulib.
4290         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4291         (GNULIB_H): Remove.
4292         (INCGNU): Look in new gnulib location.
4293         (HFILES_NO_SRCDIR): Remove gnulib files.
4294         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4295         (generated_files): Remove GNULIB_H.
4296         ($(LIBGNU), all-lib): Remove targets.
4297         (distclean): Don't mention GNULIB_BUILDDIR.
4298         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4299
4300 2019-06-14  Tom Tromey  <tromey@adacore.com>
4301
4302         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4303         Warn if symbol file does not provide any symbols.
4304
4305 2019-06-14  Tom Tromey  <tromey@adacore.com>
4306
4307         * source.c (find_and_open_source): Respect basenames_may_differ.
4308
4309 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * annotate.c (annotate_breakpoints_invalid): Make use of
4312         scoped_restore_terminal_state.
4313         (annotate_frames_invalid): Likewise.
4314
4315 2019-06-14  Tom Tromey  <tromey@adacore.com>
4316
4317         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4318         allow assignment to an internalvar.
4319
4320 2019-06-14  Tom Tromey  <tromey@adacore.com>
4321
4322         * ada-lex.l: Allow "_" in attribute names.
4323
4324 2019-06-14  Tom Tromey  <tromey@adacore.com>
4325
4326         PR gdb/24653:
4327         * regcache.c (registers_changed): Don't call alloca.
4328         * top.c (execute_command): Don't call alloca.
4329
4330 2019-06-13  Pedro Alves  <palves@redhat.com>
4331
4332         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4333         'expression'.  When parsing an expression, error out if there's
4334         junk after "unlimited".
4335         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4336         (do_set_command): Adjust calls to is_unlimited_literal.
4337
4338 2019-06-13  Pedro Alves  <palves@redhat.com>
4339
4340         * compile/compile.c (make_compile_options_def_group): Add braces
4341         around array_view initializer.
4342         * thread.c (make_thread_apply_all_options_def_group)
4343         (make_thread_apply_all_options_def_group): Likewise.
4344
4345 2019-06-13  Pedro Alves  <palves@redhat.com>
4346
4347         * NEWS (New commands): Mention "maint test-options
4348         require-delimiter", "maint test-options unknown-is-error", "maint
4349         test-options unknown-is-operand" and "maint show
4350         test-options-completion-result".
4351         (New command options, command completion): New section.
4352         (Completion improvements): New section.
4353         Mention that you can abbreviate "unlimited".
4354
4355 2019-06-13  Pedro Alves  <palves@redhat.com>
4356
4357         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4358         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4359         * unittests/cli-utils-selftests.c (test_parse_flags)
4360         (test_parse_flags_qcs): Delete.
4361         (test_cli_utils): Don't call deleted functions.
4362
4363 2019-06-13  Pedro Alves  <palves@redhat.com>
4364
4365         * thread.c: Include "cli/cli-option.h".
4366         (tp_array_compar_ascending): Global.
4367         (tp_array_compar): Delete function.
4368         (tp_array_compar_ascending, tp_array_compar_descending): New
4369         functions.
4370         (ascending_option_def, qcs_flag_option_def)
4371         (thr_qcs_flags_option_defs)
4372         (make_thread_apply_all_options_def_group)
4373         (make_thread_apply_options_def_group): New.
4374         (thread_apply_all_command): Use gdb::option::process_options.
4375         (thread_apply_command_completer)
4376         (thread_apply_all_command_completer): New.
4377         (thread_apply_command): Use gdb::option::process_options.
4378         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4379         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4380         to generate help text of "thread apply".  Adjust "taas"'s help.
4381         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4382         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4383
4384 2019-06-13  Pedro Alves  <palves@redhat.com>
4385
4386         * thread.c (thread_apply_command): Check for invalid TID with
4387         isdigit instead of !isalpha.
4388
4389 2019-06-13  Pedro Alves  <palves@redhat.com>
4390
4391         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4392         (validate_flags_qcs): New.
4393         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4394         (validate_flags_qcs): Declare.
4395         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4396         (make_frame_apply_options_def_group): New.
4397         (frame_apply_command_count): Process options with
4398         gdb::option::process_options.
4399         (frame_apply_completer): New.
4400         (frame_apply_level_completer, frame_apply_all_completer)
4401         (frame_apply_completer): New.
4402         (_initialize_stack): Update help of "frame apply", "frame apply
4403         level", "frame apply all" and "faas" to mention supported options
4404         and install command completers.
4405         * stack.h (frame_apply_all_completer): Declare.
4406         * thread.c: Include "stack.h".
4407         (tfaas_command): Add "--".
4408         (_initialize_thread): Update help "tfaas" to mention supported
4409         options and install command completer.
4410
4411 2019-06-13  Pedro Alves  <palves@redhat.com>
4412
4413         * completer.c (complete_nested_command_line): New.
4414         (gdb_completion_word_break_characters_throw): Add assertion.
4415         * completer.h (complete_nested_command_line): Declare.
4416
4417 2019-06-13  Pedro Alves  <palves@redhat.com>
4418
4419         * stack.c (parse_backtrace_qualifiers): New.
4420         (backtrace_command): Use it.
4421         (backtrace_command_completer): Complete on qualifiers.
4422
4423 2019-06-13  Pedro Alves  <palves@redhat.com>
4424
4425         * frame.c: Include "cli/cli-option.h.
4426         (user_set_backtrace_options): New.
4427         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4428         Delete.
4429         (get_prev_frame): Adjust.
4430         (boolean_option_def, uinteger_option_def)
4431         (set_backtrace_option_defs): New.
4432         (_initialize_frame): Adjust and use
4433         gdb::option::add_setshow_cmds_for_options to install "set
4434         backtrace past-main" and "set backtrace past-entry".
4435         * frame.h: Include "cli/cli-option.h".
4436         (struct frame_print_options): Forward declare.
4437         (print_frame_arguments_all, print_frame_arguments_scalars)
4438         (print_frame_arguments_none): Declare.
4439         (print_entry_values): Delete declaration.
4440         (struct frame_print_options, user_frame_print_options): New.
4441         (struct set_backtrace_options): New.
4442         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4443         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4444         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4445         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4446         (list_args_or_locals): Add frame_print_options parameter.
4447         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4448         * python/py-framefilter.c (enumerate_args): Pass down
4449         USER_FRAME_PRINT_OPTIONS.
4450         * stack.c: Include "cli/cli-option.h".
4451         (print_frame_arguments_all, print_frame_arguments_scalars)
4452         (print_frame_arguments_none): Declare.
4453         (print_raw_frame_arguments, print_entry_values): Delete.
4454         (user_frame_print_options): New.
4455         (boolean_option_def, enum_option_def, frame_print_option_defs):
4456         New.
4457         (struct backtrace_cmd_options): New.
4458         (bt_flag_option_def): New.
4459         (backtrace_command_option_defs): New.
4460         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4461         (print_frame_arg, read_frame_arg, print_frame_args)
4462         (print_frame_info, print_frame): Add frame_print_options parameter
4463         and use it.
4464         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4465         (backtrace_command_1): Add frame_print_options and
4466         backtrace_cmd_options parameters and use them.
4467         (make_backtrace_options_def_group): New.
4468         (backtrace_command): Process command options with
4469         gdb::option::process_options.
4470         (backtrace_command_completer): New.
4471         (_initialize_stack): Extend "backtrace"'s help to mention
4472         supported options.  Install completer for "backtrace".
4473         Install some settings commands with add_setshow_cmds_for_options.
4474
4475 2019-06-13  Pedro Alves  <palves@redhat.com>
4476
4477         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4478         and that "set/show print raw frame-arguments" are now deprecated.
4479
4480         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4481         command.
4482         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4483         * stack.c (_initialize_stack): Install "set/show print
4484         raw-frame-arguments", and deprecate "set/show print raw
4485         frame-arguments".
4486         * valprint.c (_initialize_valprint): Deprecate "set/show print
4487         raw".
4488
4489 2019-06-13  Pedro Alves  <palves@redhat.com>
4490
4491         * compile/compile.c (struct compile_options): New.
4492         (compile_flag_option_def, compile_command_option_defs)
4493         (make_compile_options_def_group): New.
4494         (compile_file_command): Handle options with
4495         gdb::option::process_options.
4496         (compile_file_command_completer): New function.
4497         (compile_code_command): Handle options with
4498         gdb::option::process_options.
4499         (compile_code_command_completer): New function.
4500         (_initialize_compiler): Install completers for "compile code" and
4501         "compile file".  Mention available options in "compile code" and
4502         "compile code"'s help.
4503         * completer.c (advance_to_completion_word): New, factored out from
4504         ...
4505         (advance_to_expression_complete_word_point): ... this.
4506         (advance_to_filename_complete_word_point): New.
4507         * completer.h (advance_to_filename_complete_word_point): New
4508         declaration.
4509
4510 2019-06-13  Pedro Alves  <palves@redhat.com>
4511
4512         * compile/compile.c: Include "cli/cli-option.h".
4513         (compile_print_value): Scope data pointer is now a
4514         value_print_options pointer; adjust.
4515         (compile_print_command): Process options.  Scope data pointer is
4516         now a value_print_options pointer; adjust.
4517         (_initialize_compile): Update "compile print"'s help to include
4518         supported options.  Install a completer for "compile print".
4519         * cp-valprint.c (show_vtblprint, show_objectprint)
4520         (show_static_field_print): Delete.
4521         (_initialize_cp_valprint): Don't install "set print
4522         static-members", "set print vtbl", "set print object" here.
4523         * printcmd.c: Include "cli/cli-option.h" and
4524         "common/gdb_optional.h".
4525         (print_command_parse_format): Rework to fill in a
4526         value_print_options instead of a format_data.
4527         (print_value): Change parameter type from format_data pointer to
4528         value_print_options reference.  Adjust.
4529         (print_command_1): Process options.  Adjust to pass down a
4530         value_print_options.
4531         (print_command_completer): New.
4532         (_initialize_printcmd): Install print_command_completer as
4533         handle_brkchars completer for the "print" command.  Update
4534         "print"'s help to include supported options.
4535         * valprint.c: Include "cli/cli-option.h".
4536         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4537         here from cp-valprint.c.
4538         (boolean_option_def, uinteger_option_def)
4539         (value_print_option_defs, make_value_print_options_def_group):
4540         New.  Use gdb::option::add_setshow_cmds_for_options to install
4541         "set print elements", "set print null-stop", "set print repeats",
4542         "set print pretty", "set print union", "set print array", "set
4543         print address", "set print symbol", "set print array-indexes".
4544         * valprint.h: Include <string> and "cli/cli-option.h".
4545         (make_value_print_options_def_group): Declare.
4546         (print_value): Change parameter type from format_data pointer to
4547         value_print_options reference.
4548         (print_command_completer): Declare.
4549
4550 2019-06-13  Pedro Alves  <palves@redhat.com>
4551
4552         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4553         (COMMON_SFILES): Add maint-test-settings.c.
4554         * cli/cli-decode.c (boolean_enums): New global, factored out from
4555         ...
4556         (add_setshow_boolean_cmd): ... here.
4557         * cli/cli-decode.h (boolean_enums): Declare.
4558         * cli/cli-option.c: New file.
4559         * cli/cli-option.h: New file.
4560         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4561         factored out from ...
4562         (parse_cli_boolean_value(const char *)): ... this.
4563         (is_unlimited_literal): Change parameter type to pointer to
4564         pointer.  Adjust and advance ARG pointer.
4565         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4566         (parse_cli_var_enum): New, factored out from ...
4567         (do_set_command): ... this.  Adjust.
4568         * cli/cli-setshow.h (parse_cli_boolean_value)
4569         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4570         (parse_cli_var_enum): Declare.
4571         * cli/cli-utils.c: Include "cli/cli-option.h".
4572         (get_ulongest): New.
4573         * cli/cli-utils.h (get_ulongest): Declare.
4574         (check_for_argument): New overloads.
4575         * maint-test-options.c: New file.
4576
4577 2019-06-13  Pedro Alves  <palves@redhat.com>
4578
4579         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4580         parse a range if "-" is at the end of the string.
4581
4582 2019-06-13  Pedro Alves  <palves@redhat.com>
4583
4584         * cli/cli-setshow.c (parse_auto_binary_operation)
4585         (parse_cli_boolean_value): Don't allow "o".
4586
4587 2019-06-13  Pedro Alves  <palves@redhat.com>
4588
4589         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4590         * NEWS: Mention maint test-settings KIND.
4591         * maint-test-settings.c: New file.
4592
4593 2019-06-13  Pedro Alves  <palves@redhat.com>
4594
4595         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4596         completer.
4597         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4598         "set" completers.
4599
4600 2019-06-13  Pedro Alves  <palves@redhat.com>
4601
4602         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4603         after item.
4604
4605 2019-06-13  Pedro Alves  <palves@redhat.com>
4606
4607         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4608
4609 2019-06-13  Pedro Alves <palves@redhat.com>
4610
4611         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4612         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4613         call.
4614         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4615         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4616         calls.
4617         (check_for_argument): Skip spaces after argument.
4618
4619 2019-06-13  Pedro Alves  <palves@redhat.com>
4620
4621         * thread.c (thread_apply_command): Adjust TID parsing.
4622         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4623         detected before end of string.
4624         (tid_is_in_list): Error out if LIST is invalid.
4625
4626 2019-06-13  Pedro Alves  <palves@redhat.com>
4627
4628         * completer.c (complete_line_internal_1): Rewind completion word
4629         point.
4630         (completion_tracker::advance_custom_word_point_by): Change
4631         parameter type to int.
4632         * completer.h (completion_tracker::advance_custom_word_point_by):
4633         Likewise.
4634
4635 2019-06-13  Pedro Alves  <palves@redhat.com>
4636
4637         * completer.c (advance_to_completion_word): Handle delimiters.
4638
4639 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4640
4641         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4642
4643 2019-06-11  Tom Tromey  <tom@tromey.com>
4644
4645         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4646         (xmalloc_failed): Move to alloc.c.
4647         * alloc.c: New file.
4648         * Makefile.in (COMMON_SFILES): Add alloc.c.
4649
4650 2019-06-11  Tom Tromey  <tom@tromey.com>
4651
4652         * nat/linux-waitpid.c: Don't include server.h.
4653         (linux_debug): Remove.
4654         (my_waitpid): Update.
4655
4656 2019-06-11  Tom Tromey  <tromey@adacore.com>
4657
4658         * infcall.c (_initialize_infcall): Remove trailing newline from
4659         help.
4660         * user-regs.c (_initialize_user_regs): Remove trailing newline
4661         from help.
4662         * typeprint.c (_initialize_typeprint): Remove trailing newline
4663         from help.
4664         * reverse.c (_initialize_reverse): Remove trailing newlines from
4665         help.
4666         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4667         from help.
4668         * language.c (add_set_language_command): Remove trailing newline
4669         from help.
4670         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4671         help.
4672         * disasm.c (_initialize_disasm): Remove trailing newline from
4673         help.
4674         * top.c (init_main): Remove trailing newline from help.
4675         * interps.c (_initialize_interpreter): Remove trailing newline
4676         from help.
4677         * btrace.c (_initialize_btrace): Remove trailing newlines from
4678         help.
4679         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4680         from help.
4681         * python/python.c (_initialize_python): Remove trailing newline
4682         from help.
4683         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4684         help.
4685         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4686         from help.  Reformat some text.
4687         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4688         from help.
4689         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4690         newline from help.
4691
4692 2019-06-11  Tom Tromey  <tromey@adacore.com>
4693
4694         * darwin-nat.c (darwin_decode_exception_message)
4695         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4696
4697 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4698
4699         * valops.c (value_slice): Check for not allocated or not
4700         associated values.
4701
4702 2019-06-10  Tom de Vries  <tdevries@suse.de>
4703
4704         PR gdb/24618
4705         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4706         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4707         invalid.
4708
4709 2019-06-10  Tom de Vries  <tdevries@suse.de>
4710
4711         PR gdb/24611
4712         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4713         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4714
4715 2019-06-10  Tom de Vries  <tdevries@suse.de>
4716
4717         PR symtab/24545
4718         * symtab.c (struct demangled_name_entry): Add language field.
4719         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4720         static minimal symbol".  Set and use language field.
4721
4722 2019-06-10  Tom Tromey  <tromey@adacore.com>
4723
4724         * ada-lang.c (_initialize_ada_language): Update help text.
4725
4726 2019-06-10  Tom Tromey  <tromey@adacore.com>
4727
4728         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4729         with a newline.
4730         * guile/guile.c (handle_boot_error): Don't end warning with a
4731         newline.
4732         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4733         warning with a newline.
4734         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4735         newline.
4736         (s12z_frame_cache): Likewise.
4737         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4738         a newline.
4739         * solib-svr4.c (disable_probes_interface): Don't end warning with
4740         a newline.
4741         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4742         newline.
4743         * python/python.c (do_finish_initialization): Don't end warning
4744         with a newline.
4745
4746 2019-06-10  Tom Tromey  <tom@tromey.com>
4747
4748         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4749         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4750         gdbpy_enter.
4751
4752 2019-06-10  Tom Tromey  <tromey@adacore.com>
4753
4754         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4755         data.
4756         (elf_new_init): Don't call stabsread_new_init.
4757         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4758         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4759         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4760
4761 2019-06-10  Tom de Vries  <tdevries@suse.de>
4762
4763         PR symtab/16264
4764         PR symtab/24517
4765         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4766
4767 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4768
4769         * source.c (find_and_open_source): Also rewrite relative file
4770         names.
4771
4772 2019-04-26  Amos Bird  <amosbird@gmail.com>
4773
4774         * annotate.c (annotate_thread_exited): Add "thread-exited"
4775         annotation.
4776
4777 2019-06-06  Tom Tromey  <tromey@adacore.com>
4778
4779         * maint.h (class scoped_command_stats): Use
4780         DISABLE_COPY_AND_ASSIGN.
4781         <print_time>: New method.
4782         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4783         print_time.
4784         (scoped_command_stats::print_time): New method.
4785
4786 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4789         instructions of lengths 6 or 8 bytes.
4790
4791 2019-06-04  Pedro Alves  <palves@redhat.com>
4792
4793         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4794
4795         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4796         * breakpoint.c (condition_completer): Likewise.
4797         * cli/cli-dump.c (scan_expression): Likewise.
4798         * common/filestuff.c (mkdir_recursive): Likewise.
4799         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4800         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4801         (gdb_abspath): Likewise.
4802         * compile/compile-cplus-types.c
4803         (compile_cplus_instance::decl_name): Likewise.
4804         * completer.c (complete_explicit_location):
4805         (signal_completer, reg_or_group_completer_1): Likewise.
4806         * cp-support.c (cp_remove_params_if_any): Likewise.
4807         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4808         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4809         * infcmd.c (strip_bg_char): Likewise.
4810         * linespec.c (copy_token_string): Likewise.
4811         * mi/mi-main.c (output_cores): Likewise.
4812         * psymtab.c (psymtab_search_name):
4813         * symfile.c (test_set_ext_lang_command): Likewise.
4814         * target.c (target_fileio_read_stralloc): Likewise.
4815         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4816         * value.c (complete_internalvar): Likewise.
4817
4818 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4819
4820         Add objfile property to gdb.Type.
4821         * NEWS: Mention Python API addition.
4822         * python/py-type.c (typy_get_objfile): New method.
4823
4824 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4825
4826         * NEWS: Mention the new set|show style [title|highlight].
4827         Mention changes to "show style", "help" and "apropos".
4828
4829 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4830
4831         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4832         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4833         instead of print_help_for_command.
4834         (print_doc_of_command): New function.
4835         (help_list): Add 'apropos -v word' suggestion.
4836         (print_help_for_command): Style the command name using title style.
4837         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4838         (_initialize_cli_cmds): Describe -v in apropos_command help.
4839
4840 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4841
4842         * cli/cli-style.h (cli_style_option): Add name in constructor,
4843         add m_name class member, add constructor with intensity,
4844         add name class function.
4845         (cli_style_option::add_setshow_commands): Remove name argument.
4846         (highlight_style, title_style): New styles.
4847         * cli/cli-style.c (do_show): New function that shows a style
4848         characteristic styling the style name with itself.
4849         (set_style_name): New function.
4850         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4851         Update all callers according to the changes in cli/cli-style.h.
4852         * utils.h (fputs_highlighted): New function.
4853         * utils.c (fputs_highlighted): Likewise.
4854
4855 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4856
4857         * NEWS: Mention new pipe command and new convenience variables.
4858
4859 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4860
4861         * cli/cli-cmds.c (pipe_command): New function.
4862         (_initialize_cli_cmds): Call add_com for pipe_command.
4863         Define | as an alias for pipe.
4864         (exit_status_set_internal_vars): New function.
4865         (shell_escape): Call exit_status_set_internal_vars.
4866         cli/cli-decode.c (find_command_name_length): Recognize | as
4867         a single character command.
4868
4869 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4870
4871         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4872         top.c (execute_command_to_ui_file): New function, mostly a copy
4873         of execute_command_to_string.
4874         (execute_command_to_string): Implement by calling
4875         execute_command_to_ui_file.
4876
4877 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4878
4879         * top.h (saved_command_line): Remove declaration.
4880         * top.c (previous_saved_command_line, previous_repeat_arguments):
4881         New variables.
4882         (saved_command_line): Make static, define together with other
4883         'repeat variables'.
4884         (dont_repeat): Clear repeat_arguments.
4885         (repeat_previous, get_saved_command_line, save_command_line):
4886         New functions.
4887         (gdb_init): Initialize saved_command_line
4888         and previous_saved_command_line.
4889         * main.c (captured_main_1): Remove saved_command_line initialization.
4890         * event-top.c (handle_line_of_input): Update to use
4891         the new 'repeat' related functions instead of direct access to
4892         saved_command_line.
4893         * command.h (repeat_previous, get_saved_command_line,
4894         save_command_line): New declarations.
4895         (dont_repeat): Add comment.
4896
4897 2019-05-30  Tom Tromey  <tromey@adacore.com>
4898
4899         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4900         Fix comment.
4901         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4902
4903 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4904
4905         PR cli/24587
4906         * completer.c (complete): Initialize variable word.
4907
4908 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4909
4910         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4911         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4912         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4913         'body' is NULL to the outter 'if', protecting the '!is_define'
4914         situation as well.
4915
4916 2019-05-29  Tom Tromey  <tromey@adacore.com>
4917
4918         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4919         (dwarf_unknown): New function.
4920         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4921         (dwarf_type_encoding_name): Use dwarf_unknown.
4922
4923 2019-05-29  Tom Tromey  <tromey@adacore.com>
4924
4925         PR c++/20020:
4926         * cp-valprint.c (cp_print_value_fields): Call
4927         cp_print_static_field inside "try".
4928
4929 2019-05-29  Tom Tromey  <tromey@adacore.com>
4930
4931         * inflow.c (struct terminal_info): Add default operator=.
4932         * configure: Rebuild.
4933         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4934         -Wdeprecated-copy-dtor, -Wredundant-move.
4935
4936 2019-05-29  Tom Tromey  <tromey@adacore.com>
4937
4938         * NEWS: Add entry.
4939         * infcmd.c (print_return_value_1): Handle finish_print
4940         option.
4941         (show_print_finish): New function.
4942         (_initialize_infcmd): Add "set/show print finish" commands.
4943         * valprint.c (user_print_options): Initialize new member.
4944         * valprint.h (struct value_print_options) <finish_print>: New
4945         member.
4946
4947 2019-05-28  Tom Tromey  <tromey@adacore.com>
4948
4949         * ada-lang.c (ada_remove_Xbn_suffix)
4950         (find_old_style_renaming_symbol)
4951         (parse_old_style_renaming): Remove.
4952         (ada_find_renaming_symbol): Don't call
4953         find_old_style_renaming_symbol.
4954         (ada_is_renaming_symbol): Rename from
4955         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4956         bool.  Now static.
4957         (ada_read_var_value): Update and simplify.
4958         * ada-exp.y (write_var_or_type): Remove old code.
4959
4960 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4961
4962         * event-top.c: Remove include comment.
4963         * inflow.c (class scoped_ignore_sigttou): Move from here...
4964         * inflow.h (class scoped_ignore_sigttou): ...to here.
4965         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4966         * top.c:  Remove include comment.
4967
4968 2019-05-27  Tom Tromey  <tom@tromey.com>
4969
4970         * NEWS: Fix typo.
4971
4972 2019-05-22  Tom Tromey  <tromey@adacore.com>
4973
4974         * target.c (target_follow_exec): Constify parameter.
4975         * target-delegates.c: Rebuild.
4976         * remote.c (remote_target::follow_exec): Constify parameter.
4977         * infrun.c (follow_exec): Constify parameter.
4978         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4979         (target_follow_exec): Likewise.
4980
4981 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4982
4983         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4984         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4985
4986 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4987
4988         * NEWS: Add debugredirect and testsuite sections.
4989
4990 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4991
4992         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4993         target descriptions using exclusively floating point register name
4994         aliases.
4995
4996 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         PR gdb/18644:
4999         * f-lang.c (build_fortran_types): Handle the case where
5000         gdbarch_floatformat_for_type returns a nullptr.
5001
5002 2019-05-21  Tom de Vries  <tdevries@suse.de>
5003
5004         PR cli/24587
5005         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5006
5007 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         PR gdb/18644:
5010         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5011         16-byte floats.
5012         * i386-tdep.c (i386_floatformat_for_type): Use
5013         floatformats_ia64_quad for the 16-byte floating point component
5014         within a fortran 32-byte complex number.
5015
5016 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5019         delete default constructor.
5020         (find_partial_die): Update to return const struct.
5021         (partial_die_parent_scope): Move variable declaration into scope
5022         of its use and change its type to auto.
5023         (guess_partial_die_structure_name): Likewise.
5024         (partial_die_info::fixup): Likewise.
5025
5026 2019-05-17  Tom Tromey  <tromey@adacore.com>
5027
5028         * source.c (find_and_open_source): Remove cast.
5029
5030 2019-05-17  Tom Tromey  <tromey@adacore.com>
5031
5032         * annotate.c (annotate_source): Make "filename" const.
5033         * annotate.h (annotate_source): Use const.
5034
5035 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5036
5037         * disasm.c (set_disassembler_options): Send errors to stderr.
5038
5039 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5040
5041         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5042         (cli_interp_base::set_logging): Check debug_redirect.
5043         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5044         * cli/cli-logging.c (debug_redirect): Add static variable.
5045         (pop_output_files): Add default param.
5046         (handle_redirections): Print debug setting.
5047         (show_logging_command): Likewise.
5048         (_initialize_cli_logging): Add debugredirect command.
5049         * interps.c (current_interp_set_logging): Add debug_redirect
5050         parameter.
5051         * interps.h (set_logging): Add debug_redirect parameter.
5052         (current_interp_set_logging): Likewise.
5053         * mi/mi-common.h: Likewise.
5054         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5055
5056 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5057             Tom Tromey  <tromey@adacore.com>
5058
5059         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5060         directly.
5061         * cli/cli-interp.h (make_logging_output): Remove declaration.
5062         * cli/cli-logging.c (make_logging_output): Remove function.
5063         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5064         directly.
5065         * ui-file.c (tee_file::tee_file): Remove bools.
5066         (tee_file::~tee_file): Remove deletes.
5067         * ui-file.h (tee_file): Remove bools.
5068
5069 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5070
5071         * mi/mi-cmds.h (mi_cmd_complete): New function.
5072         * mi/mi-main.c (mi_cmd_complete): Likewise.
5073         * mi/mi-cmds.c: Define new MI command -complete.
5074         * NEWS: Mention new -complete command.
5075
5076 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5077
5078         * completer.h (complete): New function.
5079         * completer.c (complete): Likewise.
5080         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5081         function defined in completer.h.
5082
5083 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5084
5085         * MAINTAINERS (Write After Approval): Add myself.
5086
5087 2019-05-17  Tom de Vries  <tdevries@suse.de>
5088
5089         PR gdb/24094
5090         * dwarf2read.c (struct cu_partial_die_info): New struct.
5091         (find_partial_die): Return cu_partial_die_info.
5092         (partial_die_parent_scope, guess_partial_die_structure_name)
5093         (partial_die_info::fixup): Handle new return type of find_partial_die.
5094
5095 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5096
5097         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5098         "std::string", simplifying the algorithm.
5099
5100 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5101
5102         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5103         (stap_static_probe_ops::get_probes): Likewise.
5104
5105 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5106
5107         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5108         '-')" and "else if".
5109         (stap_parse_single_operand): Join checks for
5110         "gdbarch_stap_parse_special_token_p" and
5111         "gdbarch_stap_parse_special_token" in the same "if" statement.
5112         Invert check when verifying for operation on register
5113         displacement.
5114
5115 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5116
5117         * stap-probe.c (stap_get_opcode): Update comment.
5118         (stap_get_expected_argument_type): Likewise.
5119         (handle_stap_probe): Likewise.
5120
5121 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5122
5123         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5124         return type to 'bool'.  Adjust comment.  Use 'bool' when
5125         appropriate.
5126         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5127         * stap-probe.c (stap_parse_argument_1): Likewise.
5128         (stap_is_operator): Likewise.
5129         (stap_is_generic_prefix): Likewise.
5130         (stap_is_register_prefix): Likewise.
5131         (stap_is_register_indirection_prefix): Likewise.
5132         (stap_is_integer_prefix): Likewise.
5133         (stap_generic_check_suffix): Likewise.
5134         (stap_check_integer_suffix): Likewise.
5135         (stap_check_register_suffix): Likewise.
5136         (stap_check_register_indirection_suffix): Likewise.
5137         (stap_parse_register_operand): Likewise.
5138         (stap_parse_single_operand): Likewise.
5139         (stap_parse_argument_1): Likewise.
5140         (stap_probe::get_argument_count): Likewise.
5141         (stap_is_operator): Likewise.
5142
5143 2019-05-16  Tom Tromey  <tromey@adacore.com>
5144
5145         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5146         keyword to foreach.
5147
5148 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5149
5150         * linux-thread-db.c (try_thread_db_load_1): Change return type
5151         to bool.
5152         (try_thread_db_load): Likewise.
5153         (try_thread_db_load_from_pdir_1): Likewise.
5154         (try_thread_db_load_from_pdir): Likewise.
5155         (try_thread_db_load_from_sdir): Likewise.
5156         (try_thread_db_load_from_dir): Likewise.
5157         (thread_db_load_search): Likewise.
5158         (has_libpthread): Likewise.
5159         (thread_db_load): Likewise.
5160
5161 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5162
5163         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5164         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5165         NULL, and complain/return if that's the case.
5166
5167 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5168
5169         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5170         (advance, posn, abstract_read_memory): New functions.
5171         [struct mem_read_abstraction]: New struct.
5172         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5173
5174 2019-05-14  Tom Tromey  <tromey@adacore.com>
5175
5176         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5177         value is not lval_memory.
5178
5179 2019-05-14  Tom Tromey  <tromey@adacore.com>
5180
5181         * solib.c (info_sharedlibrary_command): Style the file name.
5182
5183 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5184
5185         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5186         (aarch64_vnv_type): Likewise.
5187         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5188         * common/tdesc.c: Likewise.
5189         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5190         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5191         * features/aarch64-fpu.xml: Add ieee half view.
5192         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5193         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5194         * gdbtypes.h (struct builtin_type): Likewise.
5195         (struct objfile_type): Likewise.
5196
5197 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5198
5199         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5200         typo.
5201         * location.h (string_to_event_location): Likewise.
5202
5203 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5204
5205         GDB 8.3 released.
5206
5207 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5208
5209         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5210         New variable declaration.
5211         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5212         New variable.
5213         (print_one_breakpoint): Use ui_out::test_flags and new global
5214         variable to compute use_fixed_output.
5215         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5216         Remove.
5217         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5218         (mi_multi_location_breakpoint_output_fixed): Remove.
5219         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5220         new variable.
5221         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5222         fix_multi_location_breakpoint_output flag if version >= 3.
5223         * ui-out.h (enum ui_out_flag)
5224         <fix_multi_location_breakpoint_output>: New enumerator.
5225
5226 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5227
5228         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5229
5230 2019-05-10  Tom Tromey  <tromey@adacore.com>
5231
5232         * ada-lang.c (catch_ada_completer): New function.
5233         (_initialize_ada_language): Use it.
5234
5235 2019-05-10  Tom Tromey  <tromey@adacore.com>
5236
5237         * thread.c (print_thread_info): Make "requested_threads" const.
5238         * gdbthread.h (print_thread_info): Make "requested_threads"
5239         const.
5240         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5241         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5242
5243 2019-05-08  Tom Tromey  <tom@tromey.com>
5244
5245         * gdbtypes.c (objfile_type_data): Change type.
5246         (objfile_type, _initialize_gdbtypes): Update.
5247
5248 2019-05-08  Tom Tromey  <tom@tromey.com>
5249
5250         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5251         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5252         (_initialize_dwarf2_frame): Update.
5253
5254 2019-05-08  Tom Tromey  <tom@tromey.com>
5255
5256         * objc-lang.c (objc_objfile_data): Change type.
5257         (find_methods): Update.
5258         (_initialize_objc_lang): Remove.
5259
5260 2019-05-08  Tom Tromey  <tom@tromey.com>
5261
5262         * stabsread.c (rs6000_builtin_type_data): Change type.
5263         (rs6000_builtin_type, _initialize_stabsread): Update.
5264
5265 2019-05-08  Tom Tromey  <tom@tromey.com>
5266
5267         * mips-tdep.c (mips_pdr_data): Remove.
5268         (_initialize_mips_tdep): Update.
5269
5270 2019-05-08  Tom Tromey  <tom@tromey.com>
5271
5272         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5273         (hppa_init_objfile_priv_data, read_unwind_info)
5274         (find_unwind_entry, _initialize_hppa_tdep): Update.
5275
5276 2019-05-08  Tom Tromey  <tom@tromey.com>
5277
5278         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5279         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5280         on obstack.
5281         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5282
5283 2019-05-08  Tom Tromey  <tom@tromey.com>
5284
5285         * mdebugread.c (basic_type_data): Change type.
5286         (basic_type, _initialize_mdebugread): Update.
5287
5288 2019-05-08  Tom Tromey  <tom@tromey.com>
5289
5290         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5291
5292 2019-05-08  Tom Tromey  <tom@tromey.com>
5293
5294         * nto-tdep.c (nto_inferior_data_reg): Change type.
5295         (nto_inferior_data): Update.
5296         (nto_inferior_data_cleanup, nto_new_inferior_data)
5297         (_initialize_nto_tdep): Remove.
5298         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5299
5300 2019-05-08  Tom Tromey  <tom@tromey.com>
5301
5302         * ada-lang.c (struct ada_inferior_data): Add initializers.
5303         (ada_inferior_data): Change type.
5304         (ada_inferior_data_cleanup): Remove.
5305         (get_ada_inferior_data, ada_inferior_exit)
5306         (struct ada_pspace_data): Add initializers, destructor.
5307         (ada_pspace_data_handle): Change type.
5308         (get_ada_pspace_data): Update.
5309         (ada_pspace_data_cleanup): Remove.
5310
5311 2019-05-08  Tom Tromey  <tom@tromey.com>
5312
5313         * coffread.c (struct coff_symfile_info): Add initializers.
5314         (coff_objfile_data_key): Move lower.  Change type.
5315         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5316         Update.
5317         (coff_free_info): Remove.
5318
5319 2019-05-08  Tom Tromey  <tom@tromey.com>
5320
5321         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5322         (fbsd_pspace_data_handle): Move lower.  Change type.
5323         (get_fbsd_pspace_data): Update.
5324         (fbsd_pspace_data_cleanup): Remove.
5325         (_initialize_fbsd_tdep): Update.
5326
5327 2019-05-08  Tom Tromey  <tom@tromey.com>
5328
5329         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5330         (get_ada_tasks_pspace_data): Update.
5331         (ada_tasks_pspace_data_cleanup): Remove.
5332         (_initialize_tasks): Update.
5333         (ada_tasks_inferior_data_handle): Change type.
5334         (get_ada_tasks_inferior_data): Update.
5335         (ada_tasks_inferior_data_cleanup): Remove.
5336         (struct ada_tasks_pspace_data): Add initializers.
5337
5338 2019-05-08  Tom Tromey  <tom@tromey.com>
5339
5340         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5341         * symfile-debug.c (debug_sym_get_probes): Change type.
5342         * stap-probe.c (handle_stap_probe):
5343         (stap_static_probe_ops::get_probes): Change type.
5344         * probe.h (class static_probe_ops) <get_probes>: Change type.
5345         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5346         (parse_probes_in_pspace): Update.
5347         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5348         Update.
5349         (any_static_probe_ops::get_probes): Change type.
5350         * elfread.c (elfread_data): New typedef.
5351         (probe_key): Change type.
5352         (elf_get_probes): Likewise.  Update.
5353         (probe_key_free): Remove.
5354         (_initialize_elfread): Update.
5355         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5356         Change type.
5357         (dtrace_process_dof_probe, dtrace_process_dof)
5358         (dtrace_static_probe_ops::get_probe): Change type.
5359
5360 2019-05-08  Tom Tromey  <tom@tromey.com>
5361
5362         * xcoffread.c (struct xcoff_symfile_info): Rename from
5363         coff_symfile_info.  Add initializers.
5364         (xcoff_objfile_data_key): Move lower.  Change type.
5365         (XCOFF_DATA): Rewrite.
5366         (xcoff_free_info): Remove.
5367         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5368         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5369         (xcoff_initial_scan): Update.
5370
5371 2019-05-08  Tom Tromey  <tom@tromey.com>
5372
5373         * solib-svr4.c (struct svr4_info): Add initializers and
5374         destructor.
5375         <probes_table>: Now an htab_up.
5376         (solib_svr4_pspace_data): Change type.
5377         (free_probes_table): Simplify.
5378         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5379         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5380         (probes_table_remove_objfile_probes, register_solib_event_probe)
5381         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5382         (_initialize_svr4_solib): Update.
5383
5384 2019-05-08  Tom Tromey  <tom@tromey.com>
5385
5386         * remote.c (remote_pspace_data): Change type.
5387         (remote_pspace_data_cleanup): Remove.
5388         (get_remote_exec_file, set_pspace_remote_exec_file)
5389         (_initialize_remote): Update.
5390
5391 2019-05-08  Tom Tromey  <tom@tromey.com>
5392
5393         * breakpoint.c (breakpoint_objfile_key): Change type.
5394         (get_breakpoint_objfile_data): Update.
5395         (free_breakpoint_objfile_data): Remove.
5396         (_initialize_breakpoint): Update.
5397
5398 2019-05-08  Tom Tromey  <tom@tromey.com>
5399
5400         * linux-tdep.c (struct linux_info): Add initializers.
5401         (linux_inferior_data): Move.  Change type.
5402         (invalidate_linux_cache_inf): Update.
5403         (linux_inferior_data_cleanup): Remove.
5404         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5405
5406 2019-05-08  Tom Tromey  <tom@tromey.com>
5407
5408         * auxv.c (auxv_inferior_data): Move.  Change type.
5409         (auxv_inferior_data_cleanup): Remove.
5410         (invalidate_auxv_cache_inf): Rewrite.
5411         (get_auxv_inferior_data, _initialize_auxv): Update.
5412
5413 2019-05-08  Tom Tromey  <tom@tromey.com>
5414
5415         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5416         (symfile_debug_objfile_data_key): Change type.
5417         (symfile_debug_installed, debug_qf_has_symbols)
5418         (debug_qf_find_last_source_symtab)
5419         (debug_qf_forget_cached_source_info)
5420         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5421         (debug_qf_print_stats, debug_qf_dump)
5422         (debug_qf_expand_symtabs_for_function)
5423         (debug_qf_expand_all_symtabs)
5424         (debug_qf_expand_symtabs_with_fullname)
5425         (debug_qf_map_matching_symbols)
5426         (debug_qf_expand_symtabs_matching)
5427         (debug_qf_find_pc_sect_compunit_symtab)
5428         (debug_qf_map_symbol_filenames)
5429         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5430         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5431         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5432         (debug_sym_read_linetable, debug_sym_relocate): Update.
5433         (symfile_debug_free_objfile): Remove.
5434         (install_symfile_debug_logging, _initialize_symfile_debug):
5435         Update.
5436
5437 2019-05-08  Tom Tromey  <tom@tromey.com>
5438
5439         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5440         allocate_on_obstack.
5441         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5442         (get_dwarf2_per_objfile): Update.
5443         (set_dwarf2_per_objfile): Remove.
5444         (dwarf2_has_info, dwarf2_get_section_info): Update.
5445         (dwarf2_free_objfile): Remove.
5446         (_initialize_dwarf2_read): Update.
5447
5448 2019-05-08  Tom Tromey  <tom@tromey.com>
5449
5450         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5451         initializers.
5452         <unsupported_script_warning_printed,
5453         script_not_found_warning_printed>: Now bool.
5454         (auto_load_pspace_data): Change type.
5455         (~auto_load_pspace_info): Rename from
5456         auto_load_pspace_data_cleanup.
5457         (get_auto_load_pspace_data, init_loaded_scripts_info)
5458         (clear_section_scripts, maybe_print_unsupported_script_warning)
5459         (maybe_print_script_not_found_warning, _initialize_auto_load):
5460         Update.
5461
5462 2019-05-08  Tom Tromey  <tom@tromey.com>
5463
5464         * objfiles.c (objfile_pspace_info): Add destructor and
5465         initializers.
5466         (objfiles_pspace_data): Change type.
5467         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5468         (get_objfile_pspace_data): Update.
5469         (objfiles_bfd_data): Change type.
5470         (get_objfile_bfd_data): Update.
5471         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5472
5473 2019-05-08  Tom Tromey  <tom@tromey.com>
5474
5475         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5476         Change type.
5477         (get_catch_syscall_inferior_data): Update.
5478         (catch_syscall_inferior_data_cleanup): Remove.
5479         (_initialize_break_catch_syscall): Update.
5480
5481 2019-05-08  Tom Tromey  <tom@tromey.com>
5482
5483         * inflow.c (struct terminal_info): Add destructor and
5484         initializers.
5485         (inflow_inferior_data): Change type.
5486         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5487         (get_inflow_inferior_data, inflow_inferior_exit)
5488         (swap_terminal_info, _initialize_inflow): Update.
5489
5490 2019-05-08  Tom Tromey  <tom@tromey.com>
5491
5492         * target-dcache.c (target_dcache_cleanup): Remove.
5493         (target_dcache_aspace_key): Change type.
5494         (target_dcache_init_p, target_dcache_invalidate)
5495         (target_dcache_get, target_dcache_get_or_init)
5496         (_initialize_target_dcache): Update.
5497         * dcache.h (struct dcache_deleter): New.
5498
5499 2019-05-08  Tom Tromey  <tom@tromey.com>
5500
5501         * symtab.c (struct symbol_cache): Add destructor and
5502         initializers.
5503         (symbol_cache_key): Move.  Change type.
5504         (make_symbol_cache, free_symbol_cache): Remove.
5505         (get_symbol_cache): Update.
5506         (symbol_cache_cleanup): Remove.
5507         (ALL_PSPACES, symbol_cache_flush)
5508         (maintenance_print_symbol_cache)
5509         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5510         Update.
5511
5512 2019-05-08  Tom Tromey  <tom@tromey.com>
5513
5514         * symtab.c (struct main_info): Add destructor and initializers.
5515         (main_progspace_key): Move.  Change type.
5516         (get_main_info): Update.
5517         (main_info_cleanup): Remove.
5518         (_initialize_symtab): Update.
5519
5520 2019-05-08  Tom Tromey  <tom@tromey.com>
5521
5522         * registry.h (DECLARE_REGISTRY): Define the _key class.
5523
5524 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5525
5526         * NEWS: Merge two 'New commands' sections.
5527
5528 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5529
5530         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5531         parameter and use Ada language definition instead.
5532         (ada_val_print_ptr): Remove unused language parameter.
5533         (ada_val_print_num): Remove language parameter and use Ada language
5534         definition instead.
5535         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5536         parameter.
5537         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5538         parameter and use Ada language definition instead.
5539         (ada_val_print_1): Update all ada_val_print_xxx calls.
5540         Remove language parameter.
5541         (ada_val_print): Update ada_val_print_1 call.
5542
5543 2019-05-08  Tom Tromey  <tromey@adacore.com>
5544
5545         * remote.c (remote_hw_watchpoint_limit)
5546         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5547         Now static.
5548
5549 2019-05-08  Tom Tromey  <tromey@adacore.com>
5550
5551         * maint.c (_initialize_maint_cmds): Move initialization code to
5552         remote.c.
5553         (watchdog, show_watchdog): Move to remote.c.
5554         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5555         "watchdog" static.
5556         (_initialize_remote): Move initialization code from maint.c.
5557         * defs.h (watchdog): Don't declare.
5558
5559 2019-05-08  Tom Tromey  <tromey@adacore.com>
5560
5561         * tui/tui-interp.c: Include main.h.
5562         * interps.c: Include main.h.
5563         * main.h (interpreter_p): Declare.
5564         * defs.h (interpreter_p): Don't declare.
5565
5566 2019-05-08  Tom Tromey  <tromey@adacore.com>
5567
5568         * dwarf2loc.c: Include dwarf2read.h.
5569         * defs.h (read_unsigned_leb128): Don't declare.
5570         * dwarf2read.h (read_unsigned_leb128): Declare.
5571
5572 2019-05-08  Tom Tromey  <tromey@adacore.com>
5573
5574         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5575         method.
5576
5577 2019-05-08  Tom Tromey  <tromey@adacore.com>
5578
5579         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5580         when no wrap column is set.
5581
5582 2019-05-08  Tom Tromey  <tromey@adacore.com>
5583
5584         * c-lang.c (c_get_string): Handle non-C-style arrays.
5585
5586 2019-05-08  Tom Tromey  <tromey@adacore.com>
5587
5588         * typeprint.c (print_offset_data::update): Print the bit offset,
5589         not the number of bits remaining.
5590
5591 2019-05-08  Tom Tromey  <tromey@adacore.com>
5592
5593         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5594         padding at end of comment.
5595
5596 2019-05-08  Tom Tromey  <tromey@adacore.com>
5597
5598         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5599         Compare main types.
5600
5601 2019-05-06  Tom Tromey  <tom@tromey.com>
5602
5603         * common/scoped_mmap.c: Include common-defs.h.
5604         * common/scoped_mmap.h: Don't include config.h.
5605
5606 2019-05-04  Tom Tromey  <tom@tromey.com>
5607
5608         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5609         (struct aarch64_call_info): Add initializers.
5610         <si>: Now a std::vector.
5611         (pass_on_stack, aarch64_push_dummy_call): Update.
5612
5613 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5614             Tom Tromey  <tom@tromey.com>
5615
5616         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5617         (ppc_threads): Now a std::vector.  Now static.
5618         (hwdebug_find_thread_points_by_tid)
5619         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5620         Update.
5621
5622 2019-05-04  Tom Tromey  <tom@tromey.com>
5623
5624         * arc-tdep.c (arc_tdesc_init): Return bool.
5625
5626 2019-05-04  Tom Tromey  <tom@tromey.com>
5627
5628         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5629         Use gdb_assert_not_reached.
5630
5631 2019-05-04  Tom Tromey  <tom@tromey.com>
5632
5633         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5634         "false".
5635
5636 2019-05-04  Tom Tromey  <tom@tromey.com>
5637
5638         * arc-tdep.c (arc_tdesc_init): Use bool.
5639
5640 2019-05-04  Tom Tromey  <tom@tromey.com>
5641
5642         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5643
5644 2019-05-04  Tom Tromey  <tom@tromey.com>
5645
5646         * cli/cli-cmds.c (valid_command_p): Return bool.
5647
5648 2019-05-04  Tom Tromey  <tom@tromey.com>
5649
5650         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5651         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5652
5653 2019-05-04  Raul Tambre  <raul@tambre.ee>
5654
5655         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5656         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5657         operator for comparison.
5658
5659 2019-05-04  Tom Tromey  <tom@tromey.com>
5660
5661         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5662         (lookup_partial_symbol, print_partial_symbols)
5663         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5664         (psymbol_compare): Update.
5665         (add_psymbol_to_bcache): Clear the entire psymbol.
5666         (maintenance_check_psymtabs): Update.
5667         * psympriv.h (struct partial_symbol): Don't derive from
5668         general_symbol_info.
5669         <obj_section, unrelocated_address, address,
5670         set_unrelocated_address>: Update.
5671         <ginfo>: New member.
5672         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5673         (debug_names::write_psymbols): Update.
5674
5675 2019-05-04  Tom de Vries  <tdevries@suse.de>
5676
5677         * contrib/cc-with-tweaks.sh: Support -n arg.
5678
5679 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5680
5681         * corelow.c (core_target::detach): Ensure frame cache and
5682         register caches are cleared.
5683         inferior.c (exit_inferior_1): Likewise.
5684
5685 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5686             Tom Tromey  <tom@tromey.com>
5687
5688         * dictionary.c (collate_pending_symbols_by_language): Remove
5689         "struct" from foreach.
5690         * symtab.c (lookup_global_symbol_from_objfile)
5691         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5692         foreach.
5693         * ser-tcp.c (net_open): Remove "struct" from foreach.
5694         * objfiles.c (objfile_relocate, objfile_rebase)
5695         (objfile_has_symbols): Remove "struct" from foreach.
5696         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5697         from foreach.
5698         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5699         foreach.
5700         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5701         "struct" from foreach.
5702         * ada-lang.c (create_excep_cond_exprs)
5703         (ada_exception_catchpoint_cond_string): Remove "struct" from
5704         foreach.
5705
5706 2019-05-03  Tom Tromey  <tromey@adacore.com>
5707
5708         * ada-exp.y (convert_char_literal): Check suffix of each
5709         enumerator.
5710
5711 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5712
5713         PR ada/21406:
5714         * ada-exp.y (yywrap): Don't define.
5715         * ada-lex.l (%option): Add noyywrap
5716         (yywrap): Remove.
5717
5718 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5719
5720         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5721         _WIN32_WINNT to the XP level, unless already defined to a higher
5722         level.
5723
5724         * unittests/parse-connection-spec-selftests.c:
5725         * ser-tcp.c:
5726         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5727         override.
5728
5729         * symfile.c (find_separate_debug_file): Remove colon from the
5730         drive spec of DOS/Windows file names of the target, so that the
5731         file name produced from DEBUGDIR and the target's directory will
5732         be valid on DOS/Windows systems.
5733
5734 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5735
5736         * rust-lang.c (val_print_struct): Handle printing structures
5737         containing strings.
5738
5739 2019-05-02  Tom Tromey  <tromey@adacore.com>
5740
5741         * valarith.c (_initialize_valarith): Remove.
5742
5743 2019-05-01  Tom Tromey  <tromey@adacore.com>
5744
5745         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5746         bitfields.
5747
5748 2019-05-01  Tom Tromey  <tromey@adacore.com>
5749
5750         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5751         for big-endian copies.
5752
5753 2019-04-30  Ali Tamur  <tamur@google.com>
5754         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5755         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5756         (read_3_bytes): New function.
5757
5758 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5759
5760         * windows-nat.c (main_thread_id): Delete.
5761         (handle_output_debug_string): Replace main_thread_id by
5762         current_event.dwThreadId.
5763         (fake_create_process): Likewise.
5764         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5765         Do not set main_thread_id.
5766         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5767         current_event.dwThreadId.
5768         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5769
5770 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5771
5772         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5773         Use current_event.dwThreadId instead of main_thread_id.
5774
5775 2019-04-30  Tom Tromey  <tromey@adacore.com>
5776
5777         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5778         (create_excep_cond_exprs): Iterate over program spaces.
5779         (ada_exception_catchpoint_cond_string): Examine all minimal
5780         symbols for exception types.
5781
5782 2019-04-30  Tom Tromey  <tromey@adacore.com>
5783
5784         PR c++/24470:
5785         * dwarf2read.c (process_structure_scope): Handle case where type
5786         has template parameters but no symbol was created.
5787
5788 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5789             Chris January  <chris.january@arm.com>
5790
5791         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5792         qualifier.
5793         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5794
5795 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5796
5797         * f-typeprint.c (f_print_type): Update rules for printing
5798         whitespace.
5799         (f_type_print_varspec_suffix): Likewise.
5800
5801 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5802             Chris January  <chris.january@arm.com>
5803
5804         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5805         function arguments.
5806
5807 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5808
5809         * f-lang.c (build_fortran_types): Change name of void type to
5810         lower case.
5811         * f-typeprint.c (f_type_print_base): Print the name of the void
5812         type, rather than a fixed string.
5813         * f-valprint.c (f_decorations): Use lower case void string.
5814
5815 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5816             Chris January  <chris.january@arm.com>
5817
5818         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5819         types for Fortran.
5820
5821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5822             Chris January  <chris.january@arm.com>
5823             David Lecomber  <david.lecomber@arm.com>
5824
5825         * f-exp.y (BINOP_INTRINSIC): New token.
5826         (exp): New parser rule handling BINOP_INTRINSIC.
5827         (f77_keywords): Add new builtin procedures.
5828         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5829         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5830         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5831         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5832         (print_unop_subexp_f): New function.
5833         (print_binop_subexp_f): New function.
5834         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5835         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5836         (dump_subexp_body_f): Likewise.
5837         (operator_check_f): Likewise.
5838         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5839         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5840
5841 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5842
5843         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5844         UNOP_KIND.
5845         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5846         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5847         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5848         (operator_length_f): New fuction.
5849         (print_subexp_f): New function.
5850         (op_name_f): New function.
5851         (dump_subexp_body_f): New function.
5852         (operator_check_f): New function.
5853         (exp_descriptor_f): Replace standard expression handling functions
5854         with new functions.
5855         * gdb/fortran-operator.def: New file.
5856         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5857         * gdb/std-operator.def: Remove UNOP_KIND.
5858
5859 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5860
5861         * std-operator.def: Remove unbalanced, stray double quote
5862         character.
5863
5864 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5865             Chris January  <chris.january@arm.com>
5866             Daniel Everett  <daniel.everett@arm.com>
5867             Nick Forrington  <nick.forrington@arm.com>
5868             Richard Bunt  <richard.bunt@arm.com>
5869
5870         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5871         of depth when printing anonymous structs or unions.
5872         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5873         Don't print either the top-level value, or the children if the
5874         max-depth is exceeded.
5875         (ppscm_print_children): When printing the key of a map, allow one
5876         extra level of depth.
5877         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5878         print either the top-level value, or the children if the max-depth
5879         is exceeded.
5880         (print_children): When printing the key of a map, allow one extra
5881         level of depth.
5882         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5883         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5884         (user_print_options): Initialise max_depth field.
5885         (val_print_scalar_or_string_type_p): New function.
5886         (val_print): Check to see if the max depth has been reached.
5887         (val_print_check_max_depth): Define new function.
5888         (show_print_max_depth): New function.
5889         (_initialize_valprint): Add 'print max-depth' option.
5890         * valprint.h (struct value_print_options) <max_depth>: New field.
5891         (val_print_check_max_depth): Declare new function.
5892         * NEWS: Document new feature.
5893
5894 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * ada-lang.c (ada_language_defn): Initialise new field.
5897         * c-lang.c (c_is_string_type_p): New function.
5898         (c_language_defn): Initialise new field.
5899         (cplus_language_defn): Initialise new field.
5900         (asm_language_defn): Initialise new field.
5901         (minimal_language_defn): Initialise new field.
5902         * c-lang.h (c_is_string_type_p): Declare new function.
5903         * d-lang.c (d_language_defn): Initialise new field.
5904         * f-lang.c (f_is_string_type_p): New function.
5905         (f_language_defn): Initialise new field.
5906         * go-lang.c (go_is_string_type_p): New function.
5907         (go_language_defn): Initialise new field.
5908         * language.c (default_is_string_type_p): New function.
5909         (unknown_language_defn): Initialise new field.
5910         (auto_language_defn): Initialise new field.
5911         * language.h (struct language_defn) <la_is_string_type_p>: New
5912         member variable.
5913         (default_is_string_type_p): Declare new function.
5914         * m2-lang.c (m2_language_defn): Initialise new field.
5915         * objc-lang.c (objc_language_defn): Initialise new field.
5916         * opencl-lang.c (opencl_language_defn): Initialise new field.
5917         * p-lang.c (pascal_is_string_type_p): New function.
5918         (pascal_language_defn): Initialise new field.
5919         * rust-lang.c (rust_is_string_type_p): New function.
5920         (rust_language_defn): Initialise new field.
5921
5922 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5923
5924         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5925         New field.
5926         * ada-lang.c (ada_language_defn): Initialise new field.
5927         * c-lang.c (c_language_defn): Likewise.
5928         (cplus_language_defn): Likewise.
5929         (asm_language_defn): Likewise.
5930         (minimal_language_defn): Likewise.
5931         * d-lang.c (d_language_defn): Likewise.
5932         * f-lang.c (f_language_defn): Likewise.
5933         * go-lang.c (go_language_defn): Likewise.
5934         * language.c (unknown_language_defn): Likewise.
5935         (auto_language_defn): Likewise.
5936         * m2-lang.c (m2_language_defn): Likewise.
5937         * objc-lang.c (objc_language_defn): Likewise.
5938         * opencl-lang.c (opencl_language_defn): Likewise.
5939         * p-lang.c (pascal_language_defn): Likewise.
5940         * rust-lang.c (rust_language_defn): Likewise.
5941
5942 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5943
5944         * ada-lang.c (ada_is_character_type): Change return type to bool.
5945         (ada_is_string_type): Likewise.
5946         * ada-lang.h (ada_is_character_type): Update declaration
5947         (ada_is_string_type): Likewise.
5948
5949 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5950
5951         Support style in 'frame|thread apply'
5952
5953         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5954         * record.c (record_start, record_stop): Update callers of
5955         execute_command_to_string with false.
5956         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5957         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5958         methods.
5959         (class string_file): New constructor with term_out parameter.
5960         Override methods term_out and can_emit_style_escape.  New member
5961         term_out.
5962         (class stdio_file): Override can_emit_style_escape.
5963         (class tee_file): Override term_out and can_emit_style_escape.
5964         * utils.h (can_emit_style_escape): Remove.
5965         * utils.c (can_emit_style_escape): Likewise.
5966         Update all callers of can_emit_style_escape (SOMESTREAM) to
5967         SOMESTREAM->can_emit_style_escape.
5968         * source-cache.c (source_cache::get_source_lines): Likewise.
5969         * stack.c (frame_apply_command_count): Call execute_command_to_string
5970         passing the term_out characteristic of the current gdb_stdout.
5971         * thread.c (thr_try_catch_cmd): Likewise.
5972         * top.c (execute_command_to_string): pass term_out parameter
5973         to construct the string_file for the command output.
5974         * ui-file.c (term_cli_styling): New function (most code moved
5975         from utils.c can_emit_style_escape).
5976         (string_file::string_file, string_file::can_emit_style_escape,
5977         stdio_file::can_emit_style_escape, tee_file::term_out,
5978         tee_file::can_emit_style_escape): New functions.
5979
5980 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5981
5982         * NEWS: Mention the new set|show may-call-functions.
5983         * infcall.c (may_call_functions_p): New variable.
5984         (show_may_call_functions_p): New function.
5985         (call_function_by_hand_dummy): Throws an error if not
5986         may-call-functions.
5987         (_initialize_infcall): Call add_setshow_boolean_cmd for
5988         may-call-functions.
5989
5990 2019-04-25  Keith Seitz  <keiths@redhat.com>
5991
5992         PR c++/24367
5993         * cp-support.c (inspect_type): Don't attempt substitutions
5994         of symbol with the same name.
5995
5996 2019-04-25  Tom Tromey  <tromey@adacore.com>
5997
5998         PR gdb/24475:
5999         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6000         static.
6001
6002 2019-04-25  Tom Tromey  <tromey@adacore.com>
6003
6004         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6005         rvalue reference.
6006         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6007         (gdb_xml_parser::parse): Use std::move.
6008         * python/python-internal.h (gdbpy_convert_exception): Take a const
6009         reference.
6010         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6011         std::move.
6012         * python/py-utils.c (gdbpy_convert_exception): Take a const
6013         reference.
6014         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6015         Use std::move.
6016         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6017         Use std::move.
6018         * mi/mi-main.c (mi_print_exception): Take a const reference.
6019         * main.c (handle_command_errors): Take a const reference.
6020         * linespec.c (parse_linespec): Use std::move.
6021         * infcall.c (run_inferior_call): Use std::move.
6022         (call_function_by_hand_dummy): Use std::move.
6023         * exec.c (try_open_exec_file): Use std::move.
6024         * exceptions.h (exception_print, exception_fprintf)
6025         (exception_print_same): Update.
6026         * exceptions.c (print_exception, exception_print)
6027         (exception_fprintf, exception_print_same): Change parameters to
6028         const reference.
6029         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6030         * common/new-op.c: Use std::move.
6031         * common/common-exceptions.h (struct gdb_exception): Add move
6032         constructor.
6033         (struct gdb_exception_error, struct gdb_exception_quit, struct
6034         gdb_quit_bad_alloc): Change constructor to move constructor.
6035         (throw_exception): Change parameter to rvalue reference.
6036         * common/common-exceptions.c (throw_exception): Take rvalue
6037         reference.
6038         * cli/cli-interp.c (safe_execute_command): Use std::move.
6039         * breakpoint.c (insert_bp_location, location_to_sals): Use
6040         std::move.
6041
6042 2019-04-25  Tom Tromey  <tromey@adacore.com>
6043
6044         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6045         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6046         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6047         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6048         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6049         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6050         guile/scm-value.c: Use unpack.
6051         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6052         gdbscm_gdb_exception.
6053         (gdbscm_throw_gdb_exception): Likewise.
6054         (struct gdbscm_gdb_exception): New.
6055         (unpack): New function.
6056         (gdbscm_wrap): Use unpack.
6057
6058 2019-04-25  Tom Tromey  <tromey@adacore.com>
6059
6060         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6061         (gdb_rl_callback_handler): Use std::move.
6062         * common/common-exceptions.h (struct gdb_exception): Add move
6063         assignment operator.
6064         (throw_exception_sjlj): Change "exception" to const reference.
6065         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6066         (throw_exception_sjlj): Change "exception" to const reference.
6067
6068 2019-04-25  Tom Tromey  <tromey@adacore.com>
6069
6070         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6071         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6072         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6073         Update.
6074         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6075         Update.
6076         * mi/mi-interp.c (mi_interp::exec): Update.
6077         * linespec.c (parse_linespec): Update.
6078         * infcall.c (run_inferior_call): Update.
6079         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6080         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6081         (gdbscm_lookup_global_symbol): Update.
6082         * guile/scm-param.c (gdbscm_parameter_value): Update.
6083         * guile/scm-frame.c (gdbscm_frame_read_register)
6084         (gdbscm_frame_read_var): Update.
6085         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6086         * exec.c (try_open_exec_file): Update.
6087         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6088         (gdb_rl_callback_handler): Update.
6089         * common/common-exceptions.h (exception_none): Don't declare.
6090         * common/common-exceptions.c (exception_none): Don't define.
6091         (struct catcher) <exception>: Update.
6092         * cli/cli-interp.c (safe_execute_command): Update.
6093         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6094
6095 2019-04-25  Ali Tamur  <tamur@google.com>
6096
6097         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6098         (read_attribute_value): Likewise.
6099         (dwarf2_read_addr_index): Update comment.
6100         (read_str_index): Add DW_FORM_strx.
6101         (dwarf2_string_attr): Likewise.
6102         (dwarf2_const_value_attr): Likewise.
6103         (dump_die_shallow): Likewise.
6104         (dwarf2_fetch_constant_bytes): Likewise.
6105         (skip_form_bytes): Likewise.
6106         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6107
6108 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6109
6110         PR corefiles/11608
6111         PR corefiles/18187
6112         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6113         OFFSET.  Verify if current mapping contains an ELF header.
6114         (linux_find_memory_regions_full): Adjust call to
6115         dump_mapping_p.
6116
6117 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6118             Kang Li <kanglictf@gmail.com>
6119
6120         PR gdb/21600
6121
6122         * dwarf2-frame.c (read_initial_length): Be consistent about using
6123         unsigned representation of length.
6124         (decode_frame_entry_1): Likewise.  Check for wraparound of
6125         end pointer as well as buffer overflow.
6126
6127 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6128
6129         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6130         "vq".
6131
6132 2019-04-24  Tom Tromey  <tromey@adacore.com>
6133
6134         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6135
6136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * s12z-tdep.c (s12z_unwind_pc): Delete.
6139         (s12z_unwind_sp): Delete.
6140         (s12z_gdbarch_init): Don't register deleted functions with
6141         gdbarch.
6142
6143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * rl78-tdep.c (rl78_unwind_sp): Delete.
6146         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6147
6148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6149
6150         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6151         (xstormy16_unwind_pc): Delete.
6152         (xstormy16_dummy_id): Delete.
6153         (xstormy16_gdbarch_init): Don't register deleted functions with
6154         gdbarch.
6155
6156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * vax-tdep.c (vax_unwind_pc): Delete.
6159         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6160
6161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * v850-tdep.c (v850_unwind_sp): Delete.
6164         (v850_unwind_pc): Delete.
6165         (v850_dummy_id): Delete.
6166         (v850_gdbarch_init): Don't register deleted functions with
6167         gdbarch.
6168
6169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6172         (tilegx_unwind_pc): Delete.
6173         (tilegx_unwind_dummy_id): Delete.
6174         (tilegx_gdbarch_init): Don't register deleted functions with
6175         gdbarch.
6176
6177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6178
6179         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6180         (tic6x_dummy_id): Delete.
6181         (tic6x_gdbarch_init): Don't register deleted functions with
6182         gdbarch.
6183
6184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * sparc-tdep.c (sparc_unwind_pc): Delete.
6187         (sparc32_gdbarch_init): Don't register deleted function with
6188         gdbarch.
6189
6190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6191
6192         * sh-tdep.c (sh_unwind_sp): Delete.
6193         (sh_unwind_pc): Delete.
6194         (sh_dummy_id): Delete.
6195         (sh_gdbarch_init): Don't register deleted functions with
6196         gdbarch.
6197
6198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6199
6200         * score-tdep.c (score_unwind_sp): Delete.
6201         (score_unwind_pc): Delete.
6202         (score_dummy_id): Delete.
6203         (score_gdbarch_init): Don't register deleted functions with
6204         gdbarch.
6205
6206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * rx-tdep.c (rx_unwind_pc): Delete.
6209         (rx_unwind_sp): Delete.
6210         (rx_dummy_id): Delete.
6211         (rx_gdbarch_init): Don't register deleted functions with
6212         gdbarch.  Update comment.
6213
6214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6215
6216         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6217         (rs6000_dummy_id): Delete.
6218         (rs6000_gdbarch_init): Don't register deleted functions with
6219         gdbarch.
6220
6221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6222
6223         * or1k-tdep.c (or1k_dummy_id): Delete.
6224         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6225
6226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6227
6228         * nios2-tdep.c (nios2_dummy_id): Delete.
6229         (nios2_unwind_sp): Delete.
6230         (nios2_gdbarch_init): Don't register deleted functions with
6231         gdbarch.
6232
6233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * nds32-tdep.c (nds32_dummy_id): Delete.
6236         (nds32_unwind_pc): Delete.
6237         (nds32_unwind_sp): Delete.
6238         (nds32_gdbarch_init): Don't register deleted functions with
6239         gdbarch.
6240
6241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6242
6243         * msp430-tdep.c (msp430_unwind_pc): Delete.
6244         (msp430_unwind_sp): Delete.
6245         (msp430_dummy_id): Delete.
6246         (msp430_gdbarch_init): Don't register deleted functions with
6247         gdbarch.
6248
6249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * moxie-tdep.c (moxie_unwind_sp): Delete.
6252         (moxie_unwind_pc): Delete.
6253         (moxie_dummy_id): Delete.
6254         (moxie_gdbarch_init): Don't register deleted functions with
6255         gdbarch.
6256
6257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6258
6259         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6260         (mn10300_unwind_pc): Delete.
6261         (mn10300_unwind_sp): Delete.
6262         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6263         mn10300_unwind_sp.
6264         (mn10300_frame_unwind_init): Don't register deleted functions with
6265         gdbarch.
6266
6267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6268
6269         * mep-tdep.c (mep_unwind_pc): Delete.
6270         (mep_unwind_sp): Delete.
6271         (mep_dummy_id): Delete.
6272         (mep_gdbarch_init): Don't register deleted functions with
6273         gdbarch.
6274
6275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6276
6277         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6278         (m68hc11_unwind_sp): Delete.
6279         (m68hc11_gdbarch_init): Don't register deleted functions with
6280         gdbarch.
6281
6282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * m32r-tdep.c (m32r_unwind_sp): Delete.
6285         (m32r_unwind_pc): Delete.
6286         (m32r_dummy_id): Delete.
6287         (m32r_gdbarch_init): Don't register deleted functions with
6288         gdbarch.
6289
6290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * m32c-tdep.c (m32c_unwind_pc): Delete.
6293         (m32c_unwind_sp): Delete.
6294         (m32c_dummy_id): Delete.
6295         (m32c_gdbarch_init): Don't register deleted functions with
6296         gdbarch.
6297
6298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6301         (lm32_unwind_pc): Delete.
6302         (lm32_dummy_id): Delete.
6303         (lm32_gdbarch_init): Don't register deleted functions with
6304         gdbarch.
6305
6306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6309         (iq2000_unwind_pc): Delete.
6310         (iq2000_dummy_id): Delete.
6311         (iq2000_gdbarch_init): Don't register deleted functions with
6312         gdbarch.
6313
6314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * nds32-tdep.c (nds32_type_align): Delete.
6317         (nds32_push_dummy_call): Use type_align instead.
6318
6319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6320
6321         * arm-tdep.c (arm_type_align): Only handle vector override case.
6322         (arm_push_dummy_call): Use type_align.
6323         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6328         case.
6329         (pass_on_stack): Use type_align.
6330         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6331         function.
6332
6333 2019-04-23  Tom Tromey  <tromey@adacore.com>
6334
6335         * dwarf2read.c (line_header::file_name_at): Remove unused
6336         overload.
6337
6338 2019-04-23  Tom de Vries  <tdevries@suse.de>
6339
6340         PR gdb/24438
6341         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6342         invocation.
6343
6344
6345 2019-03-27  Ali Tamur  <tamur@google.com>
6346
6347         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6348         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6349         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6350         (dwarf_expr_context::get_addr_index): Likewise
6351         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6352         (symbol_needs_eval_context::get_addr_index): Likewise
6353         (disassemble_dwarf_expression): Add DW_OP_addrx
6354         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6355         (read_cutu_die_from_dwo): Update comment
6356         (skip_one_die): Add DW_FORM_addrx
6357         (read_attribute_value): Likewise
6358         (var_decode_location): Add DW_OP_addrx
6359         (dwarf2_const_value_attr): Add DW_FORM_addrx
6360         (dump_die_shallow): Likewise
6361         (dwarf2_fetch_constant_bytes): Likewise
6362         (decode_locdesc): Add DW_OP_addrx
6363         (skip_form_bytes): Add DW_FORM_addrx
6364
6365 2019-04-22  Ali Tamur  <tamur@google.com>
6366
6367         * MAINTAINERS (Write After Approval): Add self.
6368
6369 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6370
6371         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6372         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6373         (open_symbol_file_object): Likewise.
6374         (svr4_default_sos): Add info parameter.
6375         (svr4_read_so_list): Likewise.
6376         (svr4_current_sos_direct): Adjust functions calls to pass down
6377         info.
6378         (svr4_current_sos_1): Add info parameter.
6379         (svr4_current_sos): Call get_svr4_info, pass info down to
6380         svr4_current_sos_1.
6381         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6382         get_svr4_info.
6383         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6384         get_svr4_info.
6385         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6386         to get_svr4_info.
6387         (probes_table_remove_objfile_probes): Likewise.
6388         (register_solib_event_probe): Add info parameter.
6389         (solist_update_incremental): Pass info parameter down to
6390         svr4_read_so_list.
6391         (disable_probes_interface): Add info parameter.
6392         (svr4_handle_solib_event): Pass current_program_space to
6393         get_svr4_info.  Adjust disable_probes_interface cleanup.
6394         (svr4_create_probe_breakpoints): Add info parameter, pass it
6395         down to register_solib_event_probe.
6396         (svr4_create_solib_event_breakpoints): Add info parameter,
6397         pass it down to svr4_create_probe_breakpoints.
6398         (enable_break): Pass info down to
6399         svr4_create_solib_event_breakpoints.
6400         (svr4_solib_create_inferior_hook): Pass current_program_space to
6401         get_svr4_info.
6402         (svr4_clear_solib): Likewise.
6403
6404 2019-04-22  Pedro Alves  <palves@redhat.com>
6405
6406         * solib-svr4.c (svr4_free_objfile_observer): New.
6407         (probe_and_action::objfile): New field.
6408         (probes_table_htab_remove_objfile_probes)
6409         (probes_table_remove_objfile_probes): New functions.
6410         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6411         in the new probe_and_action.  Don't store the probe in 'lookup'.
6412         (svr4_create_probe_breakpoints): Pass objfile to
6413         register_solib_event_probe.
6414         (_initialize_svr4_solib): Register a free_objfile observer.
6415
6416 2019-04-19  Tom Tromey  <tom@tromey.com>
6417
6418         * common/queue.h: Remove.
6419
6420 2019-04-19  Tom Tromey  <tom@tromey.com>
6421
6422         * event-loop.c: Don't include "common/queue.h".
6423
6424 2019-04-19  Tom Tromey  <tom@tromey.com>
6425
6426         * remote.c (remote_target): Use delete.
6427         * remote-notif.h: Include <list>, not "common/queue.h".
6428         (notif_client_p): Remove typedef.
6429         (remote_notif_state): Add constructor, destructor, initializer.
6430         <notif_queue>: Now a std::list.
6431         (remote_notif_state_xfree): Don't declare.
6432         * remote-notif.c (remote_notif_process, handle_notification)
6433         (remote_notif_state_allocate): Update.
6434         (~remote_notif_state): Rename from remote_notif_state_xfree.
6435
6436 2019-04-19  Tom Tromey  <tom@tromey.com>
6437
6438         * symfile.c (reread_symbols): Update.
6439         * objfiles.c (objfile_register_static_link)
6440         (objfile_lookup_static_link): Update
6441         (~objfile) Don't delete static_links.
6442         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6443
6444 2019-04-19  Tom Tromey  <tom@tromey.com>
6445
6446         * type-stack.h (struct type_stack) <insert>: Constify string.
6447         * type-stack.c (type_stack::insert): Constify string.
6448         * gdbtypes.h (lookup_template_type): Update.
6449         (address_space_name_to_int): Update.
6450         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6451         const.
6452         (lookup_template_type): Make name const.
6453         * c-exp.y: Update rules.
6454         (lex_one_token, classify_name, classify_inner_name)
6455         (c_print_token): Update.
6456         * p-exp.y: Update rules.
6457         (yylex): Update.
6458         * f-exp.y: Update rules.
6459         (yylex): Update.
6460         * d-exp.y: Update rules.
6461         (lex_one_token, classify_name, classify_inner_name): Update.
6462         * parse.c (write_dollar_variable, copy_name): Return std::string.
6463         * parser-defs.h (copy_name): Change return type.
6464         * m2-exp.y: Update rules.
6465         (yylex): Update.
6466         * go-exp.y (lex_one_token): Update.
6467         Update rules.
6468         (classify_unsafe_function, classify_packaged_name)
6469         (classify_name, yylex): Update.
6470
6471 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6472
6473         * configure.ac: add --enable-source-highlight switch.
6474         * configure: Regenerate.
6475         * top.c (print_gdb_version): plumb --enable-source-highlight
6476         status to "show configuration".
6477
6478 2019-04-19  Tom Tromey  <tromey@adacore.com>
6479
6480         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6481         Check ADA_TYPE_P.
6482         (empty_record, ada_template_to_fixed_record_type_1)
6483         (template_to_static_fixed_type)
6484         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6485         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6486         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6487         macros.
6488
6489 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6490
6491         PR symtab/24423:
6492         * source.c (print_source_lines_base): Advance "iter" when a
6493         control character is seen.
6494
6495 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6496
6497         * inferior.h (struct infcall_suspend_state_deleter):
6498         Catch exception in destructor to avoid crash.
6499
6500 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6501
6502         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6503         close to the add_com "shell".
6504
6505 2019-04-18  Tom Tromey  <tromey@adacore.com>
6506
6507         * process-stratum-target.h (class process_stratum_target)
6508         <stratum>: Add "final".
6509
6510 2019-04-17  Tom Tromey  <tromey@adacore.com>
6511
6512         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6513         against nullptr before use.
6514
6515 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6516
6517         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6518
6519 2019-04-17  Jim Wilson  <jimw@sifive.com>
6520             Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6523         code read might fail, assume 4-byte breakpoint in that case.
6524
6525 2019-04-15  Leszek Swirski  <leszeks@google.com>
6526
6527         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6528         rather than a hand-rolled POD check when checking for forced MEMORY
6529         classification.
6530
6531 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6532
6533         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6534         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6535         function.
6536         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6537         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6538         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6539         declaration.
6540
6541 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6542
6543         * aarch64-linux-nat.c
6544         (aarch64_linux_nat_target::thread_architecture): Add override.
6545         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6546         each VQ.
6547
6548 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6549
6550         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6551
6552 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6553
6554         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6555         target types of size 96-bits, add some additional comments, and
6556         check that the builtin type we found was the correct size.
6557
6558 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6559
6560         * utils.c (prompt_for_continue): Don't restore the styling at the
6561         end, as applied_style has the wrong value.  This fixes styling in
6562         long lists of file names that are interrupted by the "Continue?"
6563         prompt.
6564
6565 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6566
6567         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6568         * c-lang.c (c_language_defn): Likewise.
6569         (cplus_language_defn): Likewise.
6570         (asm_language_defn): Likewise.
6571         (minimal_language_defn): Likewise.
6572         * d-lang.c (d_language_defn): Likewise.
6573         * f-lang.c (f_language_defn): Likewise.
6574         * go-lang.c (go_language_defn): Likewise.
6575         * language.c (unknown_language_defn): Likewise.
6576         (auto_language_defn): Likewise.
6577         * language.h (struct language_defn): Remove la_magic field.
6578         (LANG_MAGIC): Delete.
6579         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6580         * objc-lang.c (objc_language_defn): Likewise.
6581         * opencl-lang.c (opencl_language_defn): Likewise.
6582         * p-lang.c (pascal_language_defn): Likewise.
6583         * rust-lang.c (rust_language_defn): Likewise.
6584
6585 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6586
6587         * riscv-tdep.c (riscv_type_align): New function.
6588         (riscv_type_alignment): Delete.
6589         (riscv_arg_location): Use 'type_align'.
6590         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6591
6592 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * gdbtypes.c (type_align): A struct with no non-static fields also
6595         has alignment of 1.
6596
6597 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6600         component to 0.
6601         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6602         member.
6603         (riscv_struct_info::analyse): New implementation using new
6604         analyse_inner member function.
6605         (riscv_struct_info::field_offset): New member function.
6606         (riscv_struct_info::m_offsets): New member variable.
6607         (riscv_struct_info::analyse_inner): New private member function,
6608         takes the old implementation of riscv_struct_info::analyse but
6609         extended to track field offsets.
6610         (riscv_call_arg_struct): Update the struct folding special cases
6611         to handle cases where empty C++ structs, which are non-zero
6612         length, are found.
6613         (riscv_arg_location): Initialise the length of each location, a
6614         non-zero length now indicates the location is in use.
6615         (riscv_push_dummy_call): Allow for the first location having a
6616         non-zero offset when setting up arguments.
6617         (riscv_return_value): Likewise, but for return values.
6618
6619 2019-04-11  Tom Tromey  <tromey@adacore.com>
6620
6621         * utils.c (internal_vproblem): Make "msg" const.
6622
6623 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6624
6625         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6626         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6627         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6628         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6629
6630 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6631
6632         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6633         function.
6634         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6635         of amd64_collect_native_gregset.
6636         (amd64_linux_nat_target::store_registers): Likewise.
6637
6638 2019-04-10  Tom Tromey  <tom@tromey.com>
6639
6640         * symtab.c (lookup_global_symbol_from_objfile)
6641         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6642         * objfiles.h (class separate_debug_iterator): New.
6643         (class separate_debug_range): New.
6644         (struct objfile) <separate_debug_objfiles>: New method.
6645         (objfile_separate_debug_iterate): Don't declare.
6646         * objfiles.c (separate_debug_iterator::operator++): Rename from
6647         objfile_separate_debug_iterate.
6648         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6649         iterator.
6650         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6651         iterator.
6652
6653 2019-04-10  Tom Tromey  <tom@tromey.com>
6654
6655         * symfile.c (reread_symbols): Remove old comment.
6656         * objfiles.c (free_all_objfiles): Fix a typo.
6657
6658 2019-04-10  Tom Tromey  <tom@tromey.com>
6659
6660         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6661         * minsyms.c (lookup_minimal_symbol): Use foreach.
6662         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6663         (lookup_minimal_symbol_solib_trampoline): Likewise.
6664         * symfile.c (reread_symbols): Use foreach.
6665
6666 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6667             Tom Tromey  <tromey@adacore.com>
6668
6669         PR rust/24414:
6670         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6671         (rust_lex_int_test): Change "value" to be LONGEST.
6672         (rust_lex_tests): Add test for long integer literal.
6673
6674 2019-04-09  Tom Tromey  <tromey@adacore.com>
6675
6676         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6677         to bool.
6678         (extended_remote_target::attach): Update.
6679         (remote_target::remote_notice_new_inferior): Update.
6680         (remote_target::add_current_inferior_and_thread): Update.
6681         * inferior.c (exit_inferior_1): Use "false".
6682         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6683
6684 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6685
6686         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6687         the "start" command.
6688
6689 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6690
6691         * python/py-inferior.c (infpy_thread_from_thread_handle):
6692         Adjust comments to reflect renaming of thread_from_thread_handle
6693         to thread_from_handle.  Adjust keywords.  Fix type error message.
6694         (inferior_object_methods): Add thread_from_handle.  Retain
6695         thread_from_thread_handle, but mark it as deprecated.
6696
6697 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6698
6699         * gdbthread.h (find_thread_by_handle): Revise declaration.
6700         * thread.c (find_thread_by_handle): Likewise.  Adjust
6701         implementation too.
6702         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6703         support for buffer objects as handles.
6704
6705 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6706
6707         * python/py-infthread.c (thpy_thread_handle): New function.
6708         (thread_object_methods): Register thpy_thread_handle.
6709
6710 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6711
6712         * gdbthread.h (thread_to_thread_handle): Declare.
6713         * thread.c (gdbtypes.h): Include.
6714         (thread_to_thread_handle): New function.
6715
6716         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6717         (target_thread_info_to_thread_handle): Declare.
6718         * target.c (target_thread_info_to_thread_handle): New function.
6719         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6720         * target-delegates.c: Regenerate.
6721
6722         * linux-thread-db.c (class thread_db_target): Add method
6723         thread_info_to_thread_handle.
6724         (thread_db_target::thread_info_to_thread_handle): Define.
6725         * remote.c (class remote_target): Add new method
6726         thread_info_to_thread_handle.
6727         (remote_target::thread_info_to_thread_handle): Define.
6728
6729 2019-04-08  Pedro Alves  <palves@redhat.com>
6730
6731         * common/common-exceptions.c (throw_exception): Don't create
6732         named object to throw; throw directly.
6733         (throw_it): Likewise.  Don't initialize gdb_exception::message
6734         here, with new; pass FMT and AP to the ctor instead.
6735         * common/common-exceptions.h: Include <string>.
6736         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6737         const char *, va_list)): New ctor.  Use std::make_shared.
6738         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6739         errors)): Delete.
6740         (gdb_exception_error::gdb_exception_error(enum errors, const char
6741         *, va_list)): New.
6742         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6743         Add assertion.
6744         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6745         errors)): Delete.
6746         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6747         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6748         Add assertion.
6749
6750 2019-04-08  Tom Tromey  <tom@tromey.com>
6751
6752         * valops.c (value_rtti_indirect_type): Replace throw_exception
6753         with throw.
6754         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6755         with throw.
6756         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6757         throw.
6758         * target.c (target_translate_tls_address): Replace throw_exception
6759         with throw.
6760         * stack.c (frame_apply_command_count): Replace throw_exception
6761         with throw.
6762         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6763         throw.
6764         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6765         with throw.
6766         * rs6000-tdep.c (rs6000_frame_cache)
6767         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6768         * remote.c: Replace throw_exception with throw.
6769         * record-full.c (record_full_message, record_full_wait_1)
6770         (record_full_restore): Replace throw_exception with throw.
6771         * record-btrace.c:
6772         (get_thread_current_frame_id, record_btrace_start_replaying)
6773         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6774         (cmd_record_btrace_start): Replace throw_exception with throw.
6775         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6776         throw.
6777         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6778         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6779         * linespec.c:
6780         (find_linespec_symbols): Replace throw_exception with throw.
6781         * infrun.c (displaced_step_prepare, resume): Replace
6782         throw_exception with throw.
6783         * infcmd.c (post_create_inferior): Replace throw_exception with
6784         throw.
6785         * inf-loop.c (inferior_event_handler): Replace throw_exception
6786         with throw.
6787         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6788         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6789         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6790         (get_prev_frame_always, get_frame_pc_if_available)
6791         (get_frame_address_in_block_if_available, get_frame_language):
6792         Replace throw_exception with throw.
6793         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6794         throw_exception with throw.
6795         * eval.c (fetch_subexp_value, evaluate_var_value)
6796         (evaluate_funcall, evaluate_subexp_standard): Replace
6797         throw_exception with throw.
6798         * dwarf2loc.c (call_site_find_chain)
6799         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6800         Replace throw_exception with throw.
6801         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6802         with throw.
6803         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6804         throw.
6805         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6806         * completer.c (complete_line_internal): Replace throw_exception
6807         with throw.
6808         * compile/compile-object-run.c (compile_object_run): Replace
6809         throw_exception with throw.
6810         * cli/cli-script.c (process_next_line): Replace throw_exception
6811         with throw.
6812         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6813         (btrace_enable, btrace_maint_update_pt_packets): Replace
6814         throw_exception with throw.
6815         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6816         throw_exception with throw.
6817         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6818         throw_exception with throw.
6819         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6820         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6821         * aarch64-tdep.c (aarch64_make_prologue_cache)
6822         (aarch64_make_stub_cache): Replace throw_exception with throw.
6823
6824 2019-04-08  Tom Tromey  <tom@tromey.com>
6825
6826         * common/common-exceptions.c (throw_exception): Rename from
6827         throw_exception_cxx.  Remove old copy.  Make argument const.
6828         (throw_it): Create and throw exception objects directly.
6829         * common/common-exceptions.h (throw_exception): Make argument
6830         const.
6831         (struct gdb_exception_error): Add constructor.
6832         (struct gdb_exception_quit): Add constructor.
6833
6834 2019-04-08  Tom Tromey  <tom@tromey.com>
6835
6836         * common/common-exceptions.h (exception_rethrow): Don't declare.
6837         (TRY_SJLJ): Update comment.
6838         (TRY, CATCH, END_CATCH): Remove.
6839         * common/common-exceptions.c (exception_rethrow): Remove.
6840
6841 2019-04-08  Tom Tromey  <tom@tromey.com>
6842
6843         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6844         Remove.
6845         (gdb_exception_error): Rename from
6846         gdb_exception_RETURN_MASK_ERROR.
6847         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6848         (gdb_quit_bad_alloc): Update.
6849         * aarch64-tdep.c: Update.
6850         * ada-lang.c: Update.
6851         * ada-typeprint.c: Update.
6852         * ada-valprint.c: Update.
6853         * amd64-tdep.c: Update.
6854         * arch-utils.c: Update.
6855         * break-catch-throw.c: Update.
6856         * breakpoint.c: Update.
6857         * btrace.c: Update.
6858         * c-varobj.c: Update.
6859         * cli/cli-cmds.c: Update.
6860         * cli/cli-interp.c: Update.
6861         * cli/cli-script.c: Update.
6862         * common/common-exceptions.c: Update.
6863         * common/new-op.c: Update.
6864         * common/selftest.c: Update.
6865         * compile/compile-c-symbols.c: Update.
6866         * compile/compile-cplus-symbols.c: Update.
6867         * compile/compile-object-load.c: Update.
6868         * compile/compile-object-run.c: Update.
6869         * completer.c: Update.
6870         * corelow.c: Update.
6871         * cp-abi.c: Update.
6872         * cp-support.c: Update.
6873         * cp-valprint.c: Update.
6874         * darwin-nat.c: Update.
6875         * disasm-selftests.c: Update.
6876         * dtrace-probe.c: Update.
6877         * dwarf-index-cache.c: Update.
6878         * dwarf-index-write.c: Update.
6879         * dwarf2-frame-tailcall.c: Update.
6880         * dwarf2-frame.c: Update.
6881         * dwarf2loc.c: Update.
6882         * dwarf2read.c: Update.
6883         * eval.c: Update.
6884         * event-loop.c: Update.
6885         * event-top.c: Update.
6886         * exec.c: Update.
6887         * f-valprint.c: Update.
6888         * fbsd-tdep.c: Update.
6889         * frame-unwind.c: Update.
6890         * frame.c: Update.
6891         * gdbtypes.c: Update.
6892         * gnu-v3-abi.c: Update.
6893         * guile/guile-internal.h: Update.
6894         * guile/scm-block.c: Update.
6895         * guile/scm-breakpoint.c: Update.
6896         * guile/scm-cmd.c: Update.
6897         * guile/scm-disasm.c: Update.
6898         * guile/scm-frame.c: Update.
6899         * guile/scm-lazy-string.c: Update.
6900         * guile/scm-math.c: Update.
6901         * guile/scm-param.c: Update.
6902         * guile/scm-ports.c: Update.
6903         * guile/scm-pretty-print.c: Update.
6904         * guile/scm-symbol.c: Update.
6905         * guile/scm-symtab.c: Update.
6906         * guile/scm-type.c: Update.
6907         * guile/scm-value.c: Update.
6908         * i386-linux-tdep.c: Update.
6909         * i386-tdep.c: Update.
6910         * inf-loop.c: Update.
6911         * infcall.c: Update.
6912         * infcmd.c: Update.
6913         * infrun.c: Update.
6914         * jit.c: Update.
6915         * language.c: Update.
6916         * linespec.c: Update.
6917         * linux-fork.c: Update.
6918         * linux-nat.c: Update.
6919         * linux-tdep.c: Update.
6920         * linux-thread-db.c: Update.
6921         * main.c: Update.
6922         * mi/mi-cmd-break.c: Update.
6923         * mi/mi-cmd-stack.c: Update.
6924         * mi/mi-interp.c: Update.
6925         * mi/mi-main.c: Update.
6926         * objc-lang.c: Update.
6927         * p-valprint.c: Update.
6928         * parse.c: Update.
6929         * ppc-linux-tdep.c: Update.
6930         * printcmd.c: Update.
6931         * python/py-arch.c: Update.
6932         * python/py-breakpoint.c: Update.
6933         * python/py-cmd.c: Update.
6934         * python/py-finishbreakpoint.c: Update.
6935         * python/py-frame.c: Update.
6936         * python/py-framefilter.c: Update.
6937         * python/py-gdb-readline.c: Update.
6938         * python/py-inferior.c: Update.
6939         * python/py-infthread.c: Update.
6940         * python/py-lazy-string.c: Update.
6941         * python/py-linetable.c: Update.
6942         * python/py-objfile.c: Update.
6943         * python/py-param.c: Update.
6944         * python/py-prettyprint.c: Update.
6945         * python/py-progspace.c: Update.
6946         * python/py-record-btrace.c: Update.
6947         * python/py-record.c: Update.
6948         * python/py-symbol.c: Update.
6949         * python/py-type.c: Update.
6950         * python/py-unwind.c: Update.
6951         * python/py-utils.c: Update.
6952         * python/py-value.c: Update.
6953         * python/python.c: Update.
6954         * record-btrace.c: Update.
6955         * record-full.c: Update.
6956         * remote-fileio.c: Update.
6957         * remote.c: Update.
6958         * riscv-tdep.c: Update.
6959         * rs6000-aix-tdep.c: Update.
6960         * rs6000-tdep.c: Update.
6961         * rust-exp.y: Update.
6962         * rust-lang.c: Update.
6963         * s390-tdep.c: Update.
6964         * selftest-arch.c: Update.
6965         * solib-dsbt.c: Update.
6966         * solib-frv.c: Update.
6967         * solib-spu.c: Update.
6968         * solib-svr4.c: Update.
6969         * solib.c: Update.
6970         * sparc64-linux-tdep.c: Update.
6971         * stack.c: Update.
6972         * symfile-mem.c: Update.
6973         * symmisc.c: Update.
6974         * target.c: Update.
6975         * thread.c: Update.
6976         * top.c: Update.
6977         * tracefile-tfile.c: Update.
6978         * tui/tui.c: Update.
6979         * typeprint.c: Update.
6980         * unittests/cli-utils-selftests.c: Update.
6981         * unittests/parse-connection-spec-selftests.c: Update.
6982         * valops.c: Update.
6983         * valprint.c: Update.
6984         * value.c: Update.
6985         * varobj.c: Update.
6986         * windows-nat.c: Update.
6987         * x86-linux-nat.c: Update.
6988         * xml-support.c: Update.
6989
6990 2019-04-08  Tom Tromey  <tom@tromey.com>
6991
6992         * xml-support.c: Use C++ exception handling.
6993         * x86-linux-nat.c: Use C++ exception handling.
6994         * windows-nat.c: Use C++ exception handling.
6995         * varobj.c: Use C++ exception handling.
6996         * value.c: Use C++ exception handling.
6997         * valprint.c: Use C++ exception handling.
6998         * valops.c: Use C++ exception handling.
6999         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7000         handling.
7001         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7002         * typeprint.c: Use C++ exception handling.
7003         * tui/tui.c: Use C++ exception handling.
7004         * tracefile-tfile.c: Use C++ exception handling.
7005         * top.c: Use C++ exception handling.
7006         * thread.c: Use C++ exception handling.
7007         * target.c: Use C++ exception handling.
7008         * symmisc.c: Use C++ exception handling.
7009         * symfile-mem.c: Use C++ exception handling.
7010         * stack.c: Use C++ exception handling.
7011         * sparc64-linux-tdep.c: Use C++ exception handling.
7012         * solib.c: Use C++ exception handling.
7013         * solib-svr4.c: Use C++ exception handling.
7014         * solib-spu.c: Use C++ exception handling.
7015         * solib-frv.c: Use C++ exception handling.
7016         * solib-dsbt.c: Use C++ exception handling.
7017         * selftest-arch.c: Use C++ exception handling.
7018         * s390-tdep.c: Use C++ exception handling.
7019         * rust-lang.c: Use C++ exception handling.
7020         * rust-exp.y: Use C++ exception handling.
7021         * rs6000-tdep.c: Use C++ exception handling.
7022         * rs6000-aix-tdep.c: Use C++ exception handling.
7023         * riscv-tdep.c: Use C++ exception handling.
7024         * remote.c: Use C++ exception handling.
7025         * remote-fileio.c: Use C++ exception handling.
7026         * record-full.c: Use C++ exception handling.
7027         * record-btrace.c: Use C++ exception handling.
7028         * python/python.c: Use C++ exception handling.
7029         * python/py-value.c: Use C++ exception handling.
7030         * python/py-utils.c: Use C++ exception handling.
7031         * python/py-unwind.c: Use C++ exception handling.
7032         * python/py-type.c: Use C++ exception handling.
7033         * python/py-symbol.c: Use C++ exception handling.
7034         * python/py-record.c: Use C++ exception handling.
7035         * python/py-record-btrace.c: Use C++ exception handling.
7036         * python/py-progspace.c: Use C++ exception handling.
7037         * python/py-prettyprint.c: Use C++ exception handling.
7038         * python/py-param.c: Use C++ exception handling.
7039         * python/py-objfile.c: Use C++ exception handling.
7040         * python/py-linetable.c: Use C++ exception handling.
7041         * python/py-lazy-string.c: Use C++ exception handling.
7042         * python/py-infthread.c: Use C++ exception handling.
7043         * python/py-inferior.c: Use C++ exception handling.
7044         * python/py-gdb-readline.c: Use C++ exception handling.
7045         * python/py-framefilter.c: Use C++ exception handling.
7046         * python/py-frame.c: Use C++ exception handling.
7047         * python/py-finishbreakpoint.c: Use C++ exception handling.
7048         * python/py-cmd.c: Use C++ exception handling.
7049         * python/py-breakpoint.c: Use C++ exception handling.
7050         * python/py-arch.c: Use C++ exception handling.
7051         * printcmd.c: Use C++ exception handling.
7052         * ppc-linux-tdep.c: Use C++ exception handling.
7053         * parse.c: Use C++ exception handling.
7054         * p-valprint.c: Use C++ exception handling.
7055         * objc-lang.c: Use C++ exception handling.
7056         * mi/mi-main.c: Use C++ exception handling.
7057         * mi/mi-interp.c: Use C++ exception handling.
7058         * mi/mi-cmd-stack.c: Use C++ exception handling.
7059         * mi/mi-cmd-break.c: Use C++ exception handling.
7060         * main.c: Use C++ exception handling.
7061         * linux-thread-db.c: Use C++ exception handling.
7062         * linux-tdep.c: Use C++ exception handling.
7063         * linux-nat.c: Use C++ exception handling.
7064         * linux-fork.c: Use C++ exception handling.
7065         * linespec.c: Use C++ exception handling.
7066         * language.c: Use C++ exception handling.
7067         * jit.c: Use C++ exception handling.
7068         * infrun.c: Use C++ exception handling.
7069         * infcmd.c: Use C++ exception handling.
7070         * infcall.c: Use C++ exception handling.
7071         * inf-loop.c: Use C++ exception handling.
7072         * i386-tdep.c: Use C++ exception handling.
7073         * i386-linux-tdep.c: Use C++ exception handling.
7074         * guile/scm-value.c: Use C++ exception handling.
7075         * guile/scm-type.c: Use C++ exception handling.
7076         * guile/scm-symtab.c: Use C++ exception handling.
7077         * guile/scm-symbol.c: Use C++ exception handling.
7078         * guile/scm-pretty-print.c: Use C++ exception handling.
7079         * guile/scm-ports.c: Use C++ exception handling.
7080         * guile/scm-param.c: Use C++ exception handling.
7081         * guile/scm-math.c: Use C++ exception handling.
7082         * guile/scm-lazy-string.c: Use C++ exception handling.
7083         * guile/scm-frame.c: Use C++ exception handling.
7084         * guile/scm-disasm.c: Use C++ exception handling.
7085         * guile/scm-cmd.c: Use C++ exception handling.
7086         * guile/scm-breakpoint.c: Use C++ exception handling.
7087         * guile/scm-block.c: Use C++ exception handling.
7088         * guile/guile-internal.h: Use C++ exception handling.
7089         * gnu-v3-abi.c: Use C++ exception handling.
7090         * gdbtypes.c: Use C++ exception handling.
7091         * frame.c: Use C++ exception handling.
7092         * frame-unwind.c: Use C++ exception handling.
7093         * fbsd-tdep.c: Use C++ exception handling.
7094         * f-valprint.c: Use C++ exception handling.
7095         * exec.c: Use C++ exception handling.
7096         * event-top.c: Use C++ exception handling.
7097         * event-loop.c: Use C++ exception handling.
7098         * eval.c: Use C++ exception handling.
7099         * dwarf2read.c: Use C++ exception handling.
7100         * dwarf2loc.c: Use C++ exception handling.
7101         * dwarf2-frame.c: Use C++ exception handling.
7102         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7103         * dwarf-index-write.c: Use C++ exception handling.
7104         * dwarf-index-cache.c: Use C++ exception handling.
7105         * dtrace-probe.c: Use C++ exception handling.
7106         * disasm-selftests.c: Use C++ exception handling.
7107         * darwin-nat.c: Use C++ exception handling.
7108         * cp-valprint.c: Use C++ exception handling.
7109         * cp-support.c: Use C++ exception handling.
7110         * cp-abi.c: Use C++ exception handling.
7111         * corelow.c: Use C++ exception handling.
7112         * completer.c: Use C++ exception handling.
7113         * compile/compile-object-run.c: Use C++ exception handling.
7114         * compile/compile-object-load.c: Use C++ exception handling.
7115         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7116         * compile/compile-c-symbols.c: Use C++ exception handling.
7117         * common/selftest.c: Use C++ exception handling.
7118         * common/new-op.c: Use C++ exception handling.
7119         * cli/cli-script.c: Use C++ exception handling.
7120         * cli/cli-interp.c: Use C++ exception handling.
7121         * cli/cli-cmds.c: Use C++ exception handling.
7122         * c-varobj.c: Use C++ exception handling.
7123         * btrace.c: Use C++ exception handling.
7124         * breakpoint.c: Use C++ exception handling.
7125         * break-catch-throw.c: Use C++ exception handling.
7126         * arch-utils.c: Use C++ exception handling.
7127         * amd64-tdep.c: Use C++ exception handling.
7128         * ada-valprint.c: Use C++ exception handling.
7129         * ada-typeprint.c: Use C++ exception handling.
7130         * ada-lang.c: Use C++ exception handling.
7131         * aarch64-tdep.c: Use C++ exception handling.
7132
7133 2019-04-08  Tom Tromey  <tom@tromey.com>
7134
7135         * xml-support.c (gdb_xml_parser::parse): Update.
7136         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7137         * value.c (show_convenience): Update.
7138         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7139         (test_parse_flags_qcs): Update.
7140         * thread.c (thr_try_catch_cmd): Update.
7141         * target.c (target_translate_tls_address): Update.
7142         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7143         (info_frame_command_core, frame_apply_command_count): Update.
7144         * rust-exp.y (rust_lex_exception_test): Update.
7145         * riscv-tdep.c (riscv_print_one_register_info): Update.
7146         * remote.c (remote_target::enable_btrace): Update.
7147         * record-btrace.c (record_btrace_enable_warn): Update.
7148         * python/py-utils.c (gdbpy_convert_exception): Update.
7149         * printcmd.c (do_one_display, print_variable_and_value): Update.
7150         * mi/mi-main.c (mi_print_exception): Update.
7151         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7152         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7153         * linux-nat.c (linux_nat_target::attach): Update.
7154         * linux-fork.c (class scoped_switch_fork_info): Update.
7155         * infrun.c (displaced_step_prepare): Update.
7156         * infcall.c (call_function_by_hand_dummy): Update.
7157         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7158         * gnu-v3-abi.c (print_one_vtable): Update.
7159         * frame.c (get_prev_frame_always): Update.
7160         * f-valprint.c (info_common_command_for_block): Update.
7161         * exec.c (try_open_exec_file): Update.
7162         * exceptions.c (print_exception, exception_print)
7163         (exception_fprintf, exception_print_same): Update.
7164         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7165         * dwarf-index-cache.c (index_cache::store)
7166         (index_cache::lookup_gdb_index): Update.
7167         * darwin-nat.c (maybe_cache_shell): Update.
7168         * cp-valprint.c (cp_print_value_fields): Update.
7169         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7170         (gcc_cplus_symbol_address): Update.
7171         * compile/compile-c-symbols.c (gcc_convert_symbol)
7172         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7173         * common/selftest.c: Update.
7174         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7175         a std::string.
7176         (exception_try_scope_entry, exception_try_scope_exit): Don't
7177         declare.
7178         (struct exception_try_scope): Remove.
7179         (TRY): Don't use exception_try_scope.
7180         (struct gdb_exception): Add constructor, operator=.
7181         <what>: New method.
7182         (struct gdb_exception_RETURN_MASK_ALL)
7183         (struct gdb_exception_RETURN_MASK_ERROR)
7184         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7185         (struct gdb_quit_bad_alloc): Update.
7186         * common/common-exceptions.c (exception_none): Change
7187         initializer.
7188         (struct catcher) <state, exception>: Initialize inline.
7189         <prev>: Remove member.
7190         (current_catcher): Remove.
7191         (catchers): New global.
7192         (exceptions_state_mc_init): Simplify.
7193         (catcher_pop): Remove.
7194         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7195         (try_scope_depth, exception_try_scope_entry)
7196         (exception_try_scope_exit): Remove.
7197         (throw_exception_sjlj): Update.
7198         (exception_messages, exception_messages_size): Remove.
7199         (throw_it): Simplify.
7200         (gdb_exception_sliced_copy): Remove.
7201         (throw_exception_cxx): Update.
7202         * cli/cli-script.c (script_from_file): Update.
7203         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7204         Update.
7205         * ada-valprint.c (ada_val_print): Update.
7206         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7207         (create_excep_cond_exprs): Update.
7208
7209 2019-04-08  Tom Tromey  <tom@tromey.com>
7210
7211         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7212         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7213         (TRY, CATCH, END_CATCH): Remove some definitions.
7214         * common/common-exceptions.c: Don't use GDB_XCPT.
7215         (catcher_list_size): Remove.
7216         (throw_exception, throw_it): Simplify.
7217
7218 2019-04-05  Tom Tromey  <tom@tromey.com>
7219
7220         Revert the header-sorting patch.
7221         * ft32-tdep.c: Revert.
7222         * frv-tdep.c: Revert.
7223         * frv-linux-tdep.c: Revert.
7224         * frame.c: Revert.
7225         * frame-unwind.c: Revert.
7226         * frame-base.c: Revert.
7227         * fork-child.c: Revert.
7228         * findvar.c: Revert.
7229         * findcmd.c: Revert.
7230         * filesystem.c: Revert.
7231         * filename-seen-cache.h: Revert.
7232         * filename-seen-cache.c: Revert.
7233         * fbsd-tdep.c: Revert.
7234         * fbsd-nat.h: Revert.
7235         * fbsd-nat.c: Revert.
7236         * f-valprint.c: Revert.
7237         * f-typeprint.c: Revert.
7238         * f-lang.c: Revert.
7239         * extension.h: Revert.
7240         * extension.c: Revert.
7241         * extension-priv.h: Revert.
7242         * expprint.c: Revert.
7243         * exec.h: Revert.
7244         * exec.c: Revert.
7245         * exceptions.c: Revert.
7246         * event-top.c: Revert.
7247         * event-loop.c: Revert.
7248         * eval.c: Revert.
7249         * elfread.c: Revert.
7250         * dwarf2read.h: Revert.
7251         * dwarf2read.c: Revert.
7252         * dwarf2loc.c: Revert.
7253         * dwarf2expr.h: Revert.
7254         * dwarf2expr.c: Revert.
7255         * dwarf2-frame.c: Revert.
7256         * dwarf2-frame-tailcall.c: Revert.
7257         * dwarf-index-write.h: Revert.
7258         * dwarf-index-write.c: Revert.
7259         * dwarf-index-common.c: Revert.
7260         * dwarf-index-cache.h: Revert.
7261         * dwarf-index-cache.c: Revert.
7262         * dummy-frame.c: Revert.
7263         * dtrace-probe.c: Revert.
7264         * disasm.h: Revert.
7265         * disasm.c: Revert.
7266         * disasm-selftests.c: Revert.
7267         * dictionary.c: Revert.
7268         * dicos-tdep.c: Revert.
7269         * demangle.c: Revert.
7270         * dcache.h: Revert.
7271         * dcache.c: Revert.
7272         * darwin-nat.h: Revert.
7273         * darwin-nat.c: Revert.
7274         * darwin-nat-info.c: Revert.
7275         * d-valprint.c: Revert.
7276         * d-namespace.c: Revert.
7277         * d-lang.c: Revert.
7278         * ctf.c: Revert.
7279         * csky-tdep.c: Revert.
7280         * csky-linux-tdep.c: Revert.
7281         * cris-tdep.c: Revert.
7282         * cris-linux-tdep.c: Revert.
7283         * cp-valprint.c: Revert.
7284         * cp-support.c: Revert.
7285         * cp-namespace.c: Revert.
7286         * cp-abi.c: Revert.
7287         * corelow.c: Revert.
7288         * corefile.c: Revert.
7289         * continuations.c: Revert.
7290         * completer.h: Revert.
7291         * completer.c: Revert.
7292         * complaints.c: Revert.
7293         * coffread.c: Revert.
7294         * coff-pe-read.c: Revert.
7295         * cli-out.h: Revert.
7296         * cli-out.c: Revert.
7297         * charset.c: Revert.
7298         * c-varobj.c: Revert.
7299         * c-valprint.c: Revert.
7300         * c-typeprint.c: Revert.
7301         * c-lang.c: Revert.
7302         * buildsym.c: Revert.
7303         * buildsym-legacy.c: Revert.
7304         * build-id.h: Revert.
7305         * build-id.c: Revert.
7306         * btrace.c: Revert.
7307         * bsd-uthread.c: Revert.
7308         * breakpoint.h: Revert.
7309         * breakpoint.c: Revert.
7310         * break-catch-throw.c: Revert.
7311         * break-catch-syscall.c: Revert.
7312         * break-catch-sig.c: Revert.
7313         * blockframe.c: Revert.
7314         * block.c: Revert.
7315         * bfin-tdep.c: Revert.
7316         * bfin-linux-tdep.c: Revert.
7317         * bfd-target.c: Revert.
7318         * bcache.c: Revert.
7319         * ax-general.c: Revert.
7320         * ax-gdb.h: Revert.
7321         * ax-gdb.c: Revert.
7322         * avr-tdep.c: Revert.
7323         * auxv.c: Revert.
7324         * auto-load.c: Revert.
7325         * arm-wince-tdep.c: Revert.
7326         * arm-tdep.c: Revert.
7327         * arm-symbian-tdep.c: Revert.
7328         * arm-pikeos-tdep.c: Revert.
7329         * arm-obsd-tdep.c: Revert.
7330         * arm-nbsd-tdep.c: Revert.
7331         * arm-nbsd-nat.c: Revert.
7332         * arm-linux-tdep.c: Revert.
7333         * arm-linux-nat.c: Revert.
7334         * arm-fbsd-tdep.c: Revert.
7335         * arm-fbsd-nat.c: Revert.
7336         * arm-bsd-tdep.c: Revert.
7337         * arch-utils.c: Revert.
7338         * arc-tdep.c: Revert.
7339         * arc-newlib-tdep.c: Revert.
7340         * annotate.h: Revert.
7341         * annotate.c: Revert.
7342         * amd64-windows-tdep.c: Revert.
7343         * amd64-windows-nat.c: Revert.
7344         * amd64-tdep.c: Revert.
7345         * amd64-sol2-tdep.c: Revert.
7346         * amd64-obsd-tdep.c: Revert.
7347         * amd64-obsd-nat.c: Revert.
7348         * amd64-nbsd-tdep.c: Revert.
7349         * amd64-nbsd-nat.c: Revert.
7350         * amd64-nat.c: Revert.
7351         * amd64-linux-tdep.c: Revert.
7352         * amd64-linux-nat.c: Revert.
7353         * amd64-fbsd-tdep.c: Revert.
7354         * amd64-fbsd-nat.c: Revert.
7355         * amd64-dicos-tdep.c: Revert.
7356         * amd64-darwin-tdep.c: Revert.
7357         * amd64-bsd-nat.c: Revert.
7358         * alpha-tdep.c: Revert.
7359         * alpha-obsd-tdep.c: Revert.
7360         * alpha-nbsd-tdep.c: Revert.
7361         * alpha-mdebug-tdep.c: Revert.
7362         * alpha-linux-tdep.c: Revert.
7363         * alpha-linux-nat.c: Revert.
7364         * alpha-bsd-tdep.c: Revert.
7365         * alpha-bsd-nat.c: Revert.
7366         * aix-thread.c: Revert.
7367         * agent.c: Revert.
7368         * addrmap.c: Revert.
7369         * ada-varobj.c: Revert.
7370         * ada-valprint.c: Revert.
7371         * ada-typeprint.c: Revert.
7372         * ada-tasks.c: Revert.
7373         * ada-lang.c: Revert.
7374         * aarch64-tdep.c: Revert.
7375         * aarch64-ravenscar-thread.c: Revert.
7376         * aarch64-newlib-tdep.c: Revert.
7377         * aarch64-linux-tdep.c: Revert.
7378         * aarch64-linux-nat.c: Revert.
7379         * aarch64-fbsd-tdep.c: Revert.
7380         * aarch64-fbsd-nat.c: Revert.
7381         * aarch32-linux-nat.c: Revert.
7382
7383 2019-04-05  Tom Tromey  <tom@tromey.com>
7384
7385         * ft32-tdep.c: Sort headers.
7386         * frv-tdep.c: Sort headers.
7387         * frv-linux-tdep.c: Sort headers.
7388         * frame.c: Sort headers.
7389         * frame-unwind.c: Sort headers.
7390         * frame-base.c: Sort headers.
7391         * fork-child.c: Sort headers.
7392         * findvar.c: Sort headers.
7393         * findcmd.c: Sort headers.
7394         * filesystem.c: Sort headers.
7395         * filename-seen-cache.h: Sort headers.
7396         * filename-seen-cache.c: Sort headers.
7397         * fbsd-tdep.c: Sort headers.
7398         * fbsd-nat.h: Sort headers.
7399         * fbsd-nat.c: Sort headers.
7400         * f-valprint.c: Sort headers.
7401         * f-typeprint.c: Sort headers.
7402         * f-lang.c: Sort headers.
7403         * extension.h: Sort headers.
7404         * extension.c: Sort headers.
7405         * extension-priv.h: Sort headers.
7406         * expprint.c: Sort headers.
7407         * exec.h: Sort headers.
7408         * exec.c: Sort headers.
7409         * exceptions.c: Sort headers.
7410         * event-top.c: Sort headers.
7411         * event-loop.c: Sort headers.
7412         * eval.c: Sort headers.
7413         * elfread.c: Sort headers.
7414         * dwarf2read.h: Sort headers.
7415         * dwarf2read.c: Sort headers.
7416         * dwarf2loc.c: Sort headers.
7417         * dwarf2expr.h: Sort headers.
7418         * dwarf2expr.c: Sort headers.
7419         * dwarf2-frame.c: Sort headers.
7420         * dwarf2-frame-tailcall.c: Sort headers.
7421         * dwarf-index-write.h: Sort headers.
7422         * dwarf-index-write.c: Sort headers.
7423         * dwarf-index-common.c: Sort headers.
7424         * dwarf-index-cache.h: Sort headers.
7425         * dwarf-index-cache.c: Sort headers.
7426         * dummy-frame.c: Sort headers.
7427         * dtrace-probe.c: Sort headers.
7428         * disasm.h: Sort headers.
7429         * disasm.c: Sort headers.
7430         * disasm-selftests.c: Sort headers.
7431         * dictionary.c: Sort headers.
7432         * dicos-tdep.c: Sort headers.
7433         * demangle.c: Sort headers.
7434         * dcache.h: Sort headers.
7435         * dcache.c: Sort headers.
7436         * darwin-nat.h: Sort headers.
7437         * darwin-nat.c: Sort headers.
7438         * darwin-nat-info.c: Sort headers.
7439         * d-valprint.c: Sort headers.
7440         * d-namespace.c: Sort headers.
7441         * d-lang.c: Sort headers.
7442         * ctf.c: Sort headers.
7443         * csky-tdep.c: Sort headers.
7444         * csky-linux-tdep.c: Sort headers.
7445         * cris-tdep.c: Sort headers.
7446         * cris-linux-tdep.c: Sort headers.
7447         * cp-valprint.c: Sort headers.
7448         * cp-support.c: Sort headers.
7449         * cp-namespace.c: Sort headers.
7450         * cp-abi.c: Sort headers.
7451         * corelow.c: Sort headers.
7452         * corefile.c: Sort headers.
7453         * continuations.c: Sort headers.
7454         * completer.h: Sort headers.
7455         * completer.c: Sort headers.
7456         * complaints.c: Sort headers.
7457         * coffread.c: Sort headers.
7458         * coff-pe-read.c: Sort headers.
7459         * cli-out.h: Sort headers.
7460         * cli-out.c: Sort headers.
7461         * charset.c: Sort headers.
7462         * c-varobj.c: Sort headers.
7463         * c-valprint.c: Sort headers.
7464         * c-typeprint.c: Sort headers.
7465         * c-lang.c: Sort headers.
7466         * buildsym.c: Sort headers.
7467         * buildsym-legacy.c: Sort headers.
7468         * build-id.h: Sort headers.
7469         * build-id.c: Sort headers.
7470         * btrace.c: Sort headers.
7471         * bsd-uthread.c: Sort headers.
7472         * breakpoint.h: Sort headers.
7473         * breakpoint.c: Sort headers.
7474         * break-catch-throw.c: Sort headers.
7475         * break-catch-syscall.c: Sort headers.
7476         * break-catch-sig.c: Sort headers.
7477         * blockframe.c: Sort headers.
7478         * block.c: Sort headers.
7479         * bfin-tdep.c: Sort headers.
7480         * bfin-linux-tdep.c: Sort headers.
7481         * bfd-target.c: Sort headers.
7482         * bcache.c: Sort headers.
7483         * ax-general.c: Sort headers.
7484         * ax-gdb.h: Sort headers.
7485         * ax-gdb.c: Sort headers.
7486         * avr-tdep.c: Sort headers.
7487         * auxv.c: Sort headers.
7488         * auto-load.c: Sort headers.
7489         * arm-wince-tdep.c: Sort headers.
7490         * arm-tdep.c: Sort headers.
7491         * arm-symbian-tdep.c: Sort headers.
7492         * arm-pikeos-tdep.c: Sort headers.
7493         * arm-obsd-tdep.c: Sort headers.
7494         * arm-nbsd-tdep.c: Sort headers.
7495         * arm-nbsd-nat.c: Sort headers.
7496         * arm-linux-tdep.c: Sort headers.
7497         * arm-linux-nat.c: Sort headers.
7498         * arm-fbsd-tdep.c: Sort headers.
7499         * arm-fbsd-nat.c: Sort headers.
7500         * arm-bsd-tdep.c: Sort headers.
7501         * arch-utils.c: Sort headers.
7502         * arc-tdep.c: Sort headers.
7503         * arc-newlib-tdep.c: Sort headers.
7504         * annotate.h: Sort headers.
7505         * annotate.c: Sort headers.
7506         * amd64-windows-tdep.c: Sort headers.
7507         * amd64-windows-nat.c: Sort headers.
7508         * amd64-tdep.c: Sort headers.
7509         * amd64-sol2-tdep.c: Sort headers.
7510         * amd64-obsd-tdep.c: Sort headers.
7511         * amd64-obsd-nat.c: Sort headers.
7512         * amd64-nbsd-tdep.c: Sort headers.
7513         * amd64-nbsd-nat.c: Sort headers.
7514         * amd64-nat.c: Sort headers.
7515         * amd64-linux-tdep.c: Sort headers.
7516         * amd64-linux-nat.c: Sort headers.
7517         * amd64-fbsd-tdep.c: Sort headers.
7518         * amd64-fbsd-nat.c: Sort headers.
7519         * amd64-dicos-tdep.c: Sort headers.
7520         * amd64-darwin-tdep.c: Sort headers.
7521         * amd64-bsd-nat.c: Sort headers.
7522         * alpha-tdep.c: Sort headers.
7523         * alpha-obsd-tdep.c: Sort headers.
7524         * alpha-nbsd-tdep.c: Sort headers.
7525         * alpha-mdebug-tdep.c: Sort headers.
7526         * alpha-linux-tdep.c: Sort headers.
7527         * alpha-linux-nat.c: Sort headers.
7528         * alpha-bsd-tdep.c: Sort headers.
7529         * alpha-bsd-nat.c: Sort headers.
7530         * aix-thread.c: Sort headers.
7531         * agent.c: Sort headers.
7532         * addrmap.c: Sort headers.
7533         * ada-varobj.c: Sort headers.
7534         * ada-valprint.c: Sort headers.
7535         * ada-typeprint.c: Sort headers.
7536         * ada-tasks.c: Sort headers.
7537         * ada-lang.c: Sort headers.
7538         * aarch64-tdep.c: Sort headers.
7539         * aarch64-ravenscar-thread.c: Sort headers.
7540         * aarch64-newlib-tdep.c: Sort headers.
7541         * aarch64-linux-tdep.c: Sort headers.
7542         * aarch64-linux-nat.c: Sort headers.
7543         * aarch64-fbsd-tdep.c: Sort headers.
7544         * aarch64-fbsd-nat.c: Sort headers.
7545         * aarch32-linux-nat.c: Sort headers.
7546
7547 2019-04-04  Tom Tromey  <tom@tromey.com>
7548
7549         * varobj.c (varobj_create): Update.
7550         * rust-exp.y (struct rust_parser) <update_innermost_block,
7551         lookup_symbol>: New methods.
7552         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7553         Rename.
7554         (rust_parser::rust_lookup_type)
7555         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7556         * printcmd.c (display_command, do_one_display): Update.
7557         * parser-defs.h (struct parser_state) <parser_state>: Add
7558         "tracker" parameter.
7559         (block_tracker): New member.
7560         (class innermost_block_tracker) <innermost_block_tracker>: Add
7561         "types" parameter.
7562         <reset>: Remove method.
7563         (innermost_block): Don't declare.
7564         (null_post_parser): Update.
7565         * parse.c (innermost_block): Remove global.
7566         (write_dollar_variable): Update.
7567         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7568         Remove "tracker_types" parameter.
7569         (parse_expression): Add "tracker" parameter.
7570         (parse_expression_for_completion): Update.
7571         (null_post_parser): Add "tracker" parameter.
7572         * p-exp.y: Update rules.
7573         * m2-exp.y: Update rules.
7574         * language.h (struct language_defn) <la_post_parser>: Add
7575         "tracker" parameter.
7576         * go-exp.y: Update rules.
7577         * f-exp.y: Update rules.
7578         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7579         parameter.
7580         * d-exp.y: Update rules.
7581         * c-exp.y: Update rules.
7582         * breakpoint.c (set_breakpoint_condition): Create an
7583         innermost_block_tracker.
7584         (watch_command_1): Likewise.
7585         * ada-lang.c (resolve): Add "tracker" parameter.
7586         (resolve_subexp): Likewise.
7587         * ada-exp.y (write_var_from_sym): Update.
7588
7589 2019-04-04  Tom Tromey  <tom@tromey.com>
7590
7591         * type-stack.h: New file.
7592         * type-stack.c: New file.
7593         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7594         type-stack.h.
7595         (insert_into_type_stack, insert_type, push_type, push_type_int)
7596         (insert_type_address_space, pop_type, pop_type_int)
7597         (pop_typelist, pop_type_stack, append_type_stack)
7598         (push_type_stack, get_type_stack, push_typelist)
7599         (follow_type_instance_flags, follow_types): Don't declare.
7600         * parse.c (type_stack): Remove global.
7601         (parse_exp_in_context): Update.
7602         (insert_into_type_stack, insert_type, push_type, push_type_int)
7603         (insert_type_address_space, pop_type, pop_type_int)
7604         (pop_typelist, pop_type_stack, append_type_stack)
7605         (push_type_stack, get_type_stack, push_typelist)
7606         (follow_type_instance_flags, follow_types): Remove (moved to
7607         type-stack.c).
7608         * f-exp.y (type_stack): New global.
7609         Update rules.
7610         (push_kind_type, f_parse): Update.
7611         * d-exp.y (type_stack): New global.
7612         Update rules.
7613         (d_parse): Update.
7614         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7615         Update rules.
7616         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7617         (HFILES_NO_SRCDIR): Add type-stack.h.
7618
7619 2019-04-04  Tom Tromey  <tom@tromey.com>
7620
7621         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7622         (rust_parser::convert_ast_to_expression, rust_parse)
7623         (rust_lex_test_completion, rust_lex_tests): Update.
7624         * parser-defs.h (struct expr_completion_state): New.
7625         (struct parser_state) <parser_state>: Add completion parameter.
7626         <mark_struct_expression, mark_completion_tag>: New methods.
7627         <parse_completion, m_completion_state>: New members.
7628         (prefixify_expression, null_post_parser): Update.
7629         (mark_struct_expression, mark_completion_tag): Don't declare.
7630         * parse.c (parse_completion, expout_last_struct)
7631         (expout_tag_completion_type, expout_completion_name): Remove
7632         globals.
7633         (parser_state::mark_struct_expression)
7634         (parser_state::mark_completion_tag): Now methods.
7635         (prefixify_expression): Add last_struct parameter.
7636         (prefixify_subexp): Likewise.
7637         (parse_exp_1): Update.
7638         (parse_exp_in_context): Add cstate parameter.  Update.
7639         (parse_expression_for_completion): Create an
7640         expr_completion_state.
7641         (null_post_parser): Add "completion" parameter.
7642         * p-exp.y: Update rules.
7643         (yylex): Update.
7644         * language.h (struct language_defn) <la_post_parser>: Add
7645         "completing" parameter.
7646         * go-exp.y: Update rules.
7647         (lex_one_token): Update.
7648         * expression.h (parse_completion): Don't declare.
7649         * d-exp.y: Update rules.
7650         (lex_one_token): Update rules.
7651         * c-exp.y: Update rules.
7652         (lex_one_token): Update.
7653         * ada-lang.c (resolve): Add "parse_completion" parameter.
7654         (resolve_subexp): Likewise.
7655         (ada_resolve_function): Likewise.
7656
7657 2019-04-04  Tom Tromey  <tom@tromey.com>
7658
7659         * parser-defs.h (struct parser_state) <start_arglist,
7660         end_arglist>: New methods.
7661         <arglist_len, m_funcall_chain>: New members.
7662         (arglist_len, start_arglist, end_arglist): Don't declare.
7663         * parse.c (arglist_len, funcall_chain): Remove global.
7664         (start_arglist, end_arglist): Remove functions.
7665         (parse_exp_in_context): Update.
7666         * p-exp.y: Update rules.
7667         * m2-exp.y: Update rules.
7668         * go-exp.y: Update rules.
7669         * f-exp.y: Update rules.
7670         * d-exp.y: Update rules.
7671         * c-exp.y: Update rules.
7672
7673 2019-04-04  Tom Tromey  <tom@tromey.com>
7674
7675         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7676         lex_operator, push_back>: New methods.
7677         Update all rules.
7678         (rust_parser::lex_hex, lex_escape): Rename and update.
7679         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7680         (rust_parser::lex_operator): Rename and update.
7681         (rust_parser::lex_number, rustyylex, rustyyerror)
7682         (rust_lex_test_init, rust_lex_test_sequence)
7683         (rust_lex_test_push_back, rust_lex_tests): Update.
7684         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7685         parameter.
7686         <lexptr, prev_lexptr>: New members.
7687         (lexptr, prev_lexptr): Don't declare.
7688         * parse.c (lexptr, prev_lexptr): Remove globals.
7689         (parse_exp_in_context): Update.
7690         * p-exp.y (yylex, yyerror): Update.
7691         * m2-exp.y (parse_number, yylex, yyerror): Update.
7692         * go-exp.y (lex_one_token, yyerror): Update.
7693         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7694         * d-exp.y (lex_one_token, yyerror): Update.
7695         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7696         (lex_one_token, yyerror): Update.
7697         * ada-lex.l (YY_INPUT): Update.
7698         (rewind_to_char): Update.
7699         * ada-exp.y (yyerror): Update.
7700
7701 2019-04-04  Tom Tromey  <tom@tromey.com>
7702
7703         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7704         * parser-defs.h (struct parser_state) <parser_state>: Add new
7705         parameter.
7706         <comma_terminates>: New member.
7707         (comma_terminates): Don't declare global.
7708         * parse.c (comma_terminates): Remove global.
7709         (parse_exp_in_context): Update.
7710         * p-exp.y (yylex): Update.
7711         * m2-exp.y (yylex): Update.
7712         * go-exp.y (lex_one_token): Update.
7713         * f-exp.y (yylex): Update.
7714         * d-exp.y (lex_one_token): Update.
7715         * c-exp.y (lex_one_token): Update.
7716         * ada-lex.l: Update.
7717
7718 2019-04-04  Tom Tromey  <tom@tromey.com>
7719
7720         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7721         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7722         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7723         * parser-defs.h (paren_depth): Don't declare.
7724         * parse.c (paren_depth): Remove global.
7725         (parse_exp_in_context): Update.
7726         * p-exp.y (paren_depth): New global.
7727         (pascal_parse): Initialize it.
7728         * m2-exp.y (paren_depth): New global.
7729         (m2_parse): Initialize it.
7730         * go-exp.y (paren_depth): New global.
7731         (go_parse): Initialize it.
7732         * f-exp.y (paren_depth): New global.
7733         (f_parse): Initialize it.
7734         * d-exp.y (paren_depth): New global.
7735         (d_parse): Initialize it.
7736         * c-exp.y (paren_depth): New global.
7737         (c_parse): Initialize it.
7738         * ada-lex.l (paren_depth): New global.
7739         (lexer_init): Initialize it.
7740
7741 2019-04-04  Tom Tromey  <tom@tromey.com>
7742
7743         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7744         (rust_parser::convert_ast_to_type)
7745         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7746         * parser-defs.h (struct parser_state) <parser_state>: Add
7747         parameters.  Initialize new members.
7748         <expression_context_block, expression_context_pc>: New members.
7749         * parse.c (expression_context_block, expression_context_pc):
7750         Remove globals.
7751         (parse_exp_in_context): Update.
7752         * p-exp.y: Update all rules.
7753         (yylex): Update.
7754         * m2-exp.y: Update all rules.
7755         (yylex): Update.
7756         * go-exp.y (yylex): Update.
7757         * f-exp.y (yylex): Update.
7758         * d-exp.y: Update all rules.
7759         (yylex): Update.
7760         * c-exp.y: Update all rules.
7761         (lex_one_token, classify_name, yylex, c_parse): Update.
7762         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7763
7764 2019-04-04  Tom Tromey  <tom@tromey.com>
7765
7766         * gdbarch.h, gdbarch.c: Rebuild.
7767         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7768         * stap-probe.h:
7769         (struct stap_parse_info): Replace "parser_state" with
7770         "expr_builder".
7771         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7772         (parser_state): New class.
7773         * parse.c (expr_builder): Rename.
7774         (expr_builder::release): Rename.
7775         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7776         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7777         (write_exp_elt_longcst, write_exp_elt_floatcst)
7778         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7779         (write_exp_string_vector, write_exp_bitstring)
7780         (write_exp_msymbol, mark_struct_expression)
7781         (write_dollar_variable)
7782         (insert_type_address_space, increase_expout_size): Replace
7783         "parser_state" with "expr_builder".
7784         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7785         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7786         "parser_state" with "expr_builder".
7787
7788 2019-04-04  Tom Tromey  <tom@tromey.com>
7789
7790         * rust-exp.y: Replace "parse_language" with method call.
7791         * p-exp.y:
7792         (yylex): Replace "parse_language" with method call.
7793         * m2-exp.y:
7794         (yylex): Replace "parse_language" with method call.
7795         * go-exp.y (classify_name): Replace "parse_language" with method
7796         call.
7797         * f-exp.y (yylex): Replace "parse_language" with method call.
7798         * d-exp.y (lex_one_token): Replace "parse_language" with method
7799         call.
7800         * c-exp.y:
7801         (lex_one_token, classify_name, yylex): Replace "parse_language"
7802         with method call.
7803         * ada-exp.y (find_primitive_type, type_char)
7804         (type_system_address): Replace "parse_language" with method call.
7805
7806 2019-04-04  Tom Tromey  <tom@tromey.com>
7807
7808         * rust-exp.y: Replace "parse_gdbarch" with method call.
7809         * parse.c (write_dollar_variable, insert_type_address_space):
7810         Replace "parse_gdbarch" with method call.
7811         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7812         call.
7813         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7814         call.
7815         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7816         "parse_gdbarch" with method call.
7817         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7818         with method call.
7819         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7820         "parse_gdbarch" with method call.
7821         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7822         "parse_gdbarch" with method call.
7823         * c-exp.y (parse_type, parse_number, classify_name): Replace
7824         "parse_gdbarch" with method call.
7825         * ada-lex.l: Replace "parse_gdbarch" with method call.
7826         * ada-exp.y (parse_type, find_primitive_type, type_char)
7827         (type_system_address): Replace "parse_gdbarch" with method call.
7828
7829 2019-04-04  Tom Tromey  <tom@tromey.com>
7830
7831         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7832         * stap-probe.c (stap_parse_argument): Update.
7833         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7834         initial_size parameter.
7835         * rust-exp.y (rust_lex_tests): Update.
7836         * parse.c (parser_state): Update.
7837         (parse_exp_in_context): Update.
7838         * parser-defs.h (struct parser_state) <parser_state>: Remove
7839         "initial_size" parameter.
7840
7841 2019-04-04  Tom Tromey  <tom@tromey.com>
7842
7843         * parser-defs.h (increase_expout_size): Don't declare.
7844         * parse.c (increase_expout_size): Now static.
7845
7846 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7847
7848         * gnu-nat.c (gnu_nat_target::wait): Fix
7849         target_waitstatus_to_string call.
7850
7851 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * eval.c (evaluate_subexp_standard): Handle internal functions
7854         during Fortran function call handling.
7855
7856 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * NEWS: Mention new internal functions.
7859         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7860         (read_base_type): Use dwarf2_init_complex_target_type.
7861         * value.c (creal_internal_fn): New function.
7862         (cimag_internal_fn): New function.
7863         (_initialize_values): Register new internal functions.
7864
7865 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7866
7867         * infrun.c (stop_all_threads): If debug_infrun, always
7868         trace the wait status after wait_one, using
7869         target_waitstatus_to_string and target_pid_to_str.
7870         (handle_inferior_event): Replace various trace of
7871         wait status kind by a single trace.
7872         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7873         wait status kind image by target_waitstatus_to_string.
7874         * target/waitstatus.c (target_waitstatus_to_string): Fix
7875         obsolete comment.
7876
7877 2019-04-01  Tom Tromey  <tromey@adacore.com>
7878
7879         PR symtab/23331:
7880         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7881
7882 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7883             Pedro Alves  <palves@redhat.com>
7884
7885         * top.c (quit_force): Call 'finalize_values'.
7886         * value.c (finalize_values): New function.
7887         * value.h (finalize_values): Declare.
7888
7889 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7890
7891         * NEWS: Announce $_gdb_major and $_gdb_minor.
7892
7893         * top.c (init_gdb_version_vars): New function.
7894         (gdb_init): Call init_gdb_version_vars.
7895
7896 2019-03-29  Tom Tromey  <tromey@adacore.com>
7897
7898         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7899         help text.  Remove dead code.
7900
7901 2019-03-29  Keith Seitz  <keiths@redhat.com>
7902
7903         From Siddhesh Poyarekar:
7904         * f-lang.h (f77_get_upperbound): Return LONGEST.
7905         (f77_get_lowerbound): Likewise.
7906         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7907         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7908         print them.
7909         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7910         plongest to format print it.
7911         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7912         (f77_get_upperbound): Likewise.
7913         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7914         LOWER_BOUND to LONGEST.
7915         (f77_create_arrayprint_offset_tbl): Likewise.
7916
7917 2019-03-29  Keith Seitz  <keiths@redhat.com>
7918
7919         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7920         %s/pulongest for TYPE_LENGTH instead of %d in format
7921         strings.
7922         * ada-typerint.c (ada_print_type): Likewise.
7923         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7924         * compile/compile-c-support.c (generate_register_struct): Likewise.
7925         * gdbtypes.c (recursive_dump_type): Likewise.
7926         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7927         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7928         instead of %d in format strings.
7929         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7930         to std::min to ULONGEST.
7931         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7932         instead of %d in format strings.
7933         * tracepoint.c (info_scope_command): Likewise.
7934         * typeprint.c (print_offset_data::update)
7935         (print_offset_data::finish): Likewise.
7936         * xtensa-tdep.c (xtensa_store_return_value)
7937         (xtensa_push_dummy_call): Likewise.
7938
7939 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7940
7941         * windows-nat.c (display_selector): Fixed format specifications
7942         for 64-bit Cygwin.
7943
7944 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7945
7946         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7947
7948 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7949
7950         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7951         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7952         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7953         (nios2_linux_init_abi): Install it.
7954
7955 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7956
7957         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7958
7959 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7960
7961         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7962
7963 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964             Tom Tromey  <tromey@adacore.com>
7965
7966         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7967
7968 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7969
7970         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7971         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7972         method to compute the bounds of range types. Also print "[evaluated]"
7973         if the bounds' values come from a dynamic evaluation.
7974
7975 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7976
7977         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7978         whitespace when pretty printing is on.
7979
7980 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7981
7982         * ppc-linux-nat.c: Add include.
7983
7984 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7985
7986         * NEWS: Mention AArch64 Pointer Authentication.
7987
7988 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7989
7990         * arm-linux-nat.c: Add include.
7991
7992 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7993
7994         * source-cache.c (source_cache::get_source_lines): Re-read
7995         fullname after calling open_source_file.
7996
7997 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7998
7999         * NEWS: Mention TLS support for FreeBSD.
8000
8001 2019-03-25  Tom Tromey  <tromey@adacore.com>
8002
8003         * minsyms.c (BUNCH_SIZE): Update comment.
8004         (~minimal_symbol_reader): Remove old comment.
8005         (compact_minimal_symbols): Update comment.
8006         (minimal_symbol_reader::install): Remove old comment.  Update
8007         other comments.
8008
8009 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8010
8011         * s390-linux-nat.c: Add include.
8012
8013 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8014
8015         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8016         Call linux_get_hwcap.
8017         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8018         Likewise.
8019         (aarch64_linux_get_hwcap): Remove function.
8020         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8021         declaration.
8022         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8023         linux_get_hwcap.
8024         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8025         * linux-tdep.c (linux_get_hwcap): Add function.
8026         (linux_get_hwcap2): Likewise.
8027         * linux-tdep.h (linux_get_hwcap): Add declaration.
8028         (linux_get_hwcap2): Likewise.
8029         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8030         (ppc_linux_get_hwcap2): Likewise.
8031         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8032         linux_get_hwcap.
8033         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8034         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8035         (ppc_linux_nat_target::read_description): Likewise.
8036         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8037         * s390-linux-nat.c: Likewise.
8038         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8039
8040 2019-03-24  Tom Tromey  <tom@tromey.com>
8041
8042         * ada-lang.c (standard_lookup): Simplify initialization.
8043         (ada_lookup_symbol_nonlocal): Simplify return.
8044         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8045         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8046         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8047         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8048         initialization.
8049         * solib.c (solib_global_lookup): Simplify.
8050         * symtab.c (null_block_symbol): Remove.
8051         (symbol_cache_lookup): Simplify returns.
8052         (lookup_language_this): Simplify returns.
8053         (lookup_symbol_aux): Simplify return.
8054         (lookup_local_symbol): Simplify returns.
8055         (lookup_global_symbol_from_objfile): Simplify return.
8056         (lookup_symbol_in_objfile_symtabs)
8057         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8058         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8059         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8060         * cp-namespace.c (cp_lookup_bare_symbol)
8061         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8062         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8063         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8064         (cp_lookup_symbol_via_imports): Simplify initialization.
8065         (find_symbol_in_baseclass): Likewise.
8066         * symtab.h (null_block_symbol): Remove.
8067         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8068         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8069         (d_lookup_symbol_module): Likewise.
8070         (find_symbol_in_baseclass): Simplify initialization.
8071
8072 2019-03-24  Tom Tromey  <tom@tromey.com>
8073
8074         * expression.h: Don't include symtab.h.
8075         (struct block): Forward declare.
8076
8077 2019-03-24  Tom Tromey  <tom@tromey.com>
8078
8079         * c-exp.y (typebase): Remove casts.
8080         * gdbtypes.c (lookup_unsigned_typename, )
8081         (lookup_signed_typename): Remove cast.
8082         * eval.c (parse_to_comma_and_eval): Remove cast.
8083         * parse.c (write_dollar_variable): Remove cast.
8084         * block.h (struct block) <superblock>: Now const.
8085         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8086         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8087         (map_block): Make "block" const.
8088         * symfile.h (struct quick_symbol_functions)
8089         <map_matching_symbols>: Constify block argument to "callback".
8090         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8091         const.
8092         (find_pc_sect_compunit_symtab): Make "b" const.
8093         (find_symbol_at_address): Likewise.
8094         (search_symbols): Likewise.
8095         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8096         (dw2_debug_names_lookup_symbol): Likewise.
8097         (dw2_map_matching_symbols): Update.
8098         * p-valprint.c (pascal_val_print): Remove "block".
8099         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8100         (aux_add_nonlocal_symbols): Make "block" const.
8101         (resolve_subexp): Remove cast.
8102         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8103         const.
8104         (iterate_over_file_blocks): Likewise.
8105         * f-exp.y (%union) <bval>: Remove.
8106         * coffread.c (patch_opaque_types): Make "b" const.
8107         * spu-tdep.c (spu_catch_start): Make "block" const.
8108         * c-valprint.c (print_unpacked_pointer): Remove "block".
8109         * symmisc.c (dump_symtab_1): Make "b" const.
8110         (block_depth): Make "block" const.
8111         * d-exp.y (%union) <bval>: Remove.
8112         * cp-support.h (cp_lookup_rtti_type): Update.
8113         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8114         * psymtab.c (psym_lookup_symbol): Make "block" const.
8115         (maintenance_check_psymtabs): Make "b" const.
8116         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8117         (enumerate_locals, enumerate_args): Update.
8118         * python/py-symtab.c (stpy_global_block): Make "block" const.
8119         (stpy_static_block): Likewise.
8120         * inline-frame.c (block_starting_point_at): Make "new_block"
8121         const.
8122         * block.c (find_block_in_blockvector): Make return type const.
8123         (blockvector_for_pc_sect): Make "b" const.
8124         (find_block_in_blockvector): Make "b" const.
8125
8126 2019-03-23  Tom Tromey  <tom@tromey.com>
8127
8128         * varobj.c (varobj_create): Update.
8129         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8130         * printcmd.c (display_command, do_one_display): Don't reset
8131         innermost_block.
8132         * parser-defs.h (enum innermost_block_tracker_type): Move to
8133         expression.h.
8134         (innermost_block): Update comment.
8135         * parse.c (parse_exp_1): Add tracker_types parameter.
8136         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8137         tracker_types parameter.  Reset innermost_block.
8138         (parse_exp_in_context): Remove.
8139         (parse_expression_for_completion): Update.
8140         * objfiles.c (~objfile): Don't reset expression_context_block or
8141         innermost_block.
8142         * expression.h (enum innermost_block_tracker_type): Move from
8143         parser-defs.h.
8144         (parse_exp_1): Add tracker_types parameter.
8145         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8146         reset innermost_block.
8147
8148 2019-03-23  Tom Tromey  <tom@tromey.com>
8149
8150         * objfiles.h: Include bcache.h.
8151
8152 2019-03-23  Tom Tromey  <tom@tromey.com>
8153
8154         * linespec.c (get_current_search_block): Use
8155         scoped_restore_current_language.
8156         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8157
8158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8159             Jiong Wang  <jiong.wang@arm.com>
8160
8161         * aarch64-linux-tdep.c
8162         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8163         section.
8164         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8165
8166 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8167             Jiong Wang  <jiong.wang@arm.com>
8168
8169         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8170         instructions.
8171         (aarch64_analyze_prologue_test): Add PACIASP test.
8172         (aarch64_prologue_prev_register): Unmask PC value.
8173
8174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8175             Jiong Wang  <jiong.wang@arm.com>
8176
8177         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8178         (aarch64_dwarf2_prev_register): Unmask PC value.
8179         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8180         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8181         DW_CFA_AARCH64_negate_ra_state.
8182         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8183
8184 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8185             Jiong Wang  <jiong.wang@arm.com>
8186
8187         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8188         registers.
8189         (aarch64_pseudo_register_name): Likewise.
8190         (aarch64_pseudo_register_type): Likewise.
8191         (aarch64_pseudo_register_reggroup_p): Likewise.
8192         (aarch64_gdbarch_init): Add pauth registers.
8193         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8194         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8195         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8196         (struct gdbarch_tdep): Add regnum for ra_state.
8197
8198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8199             Jiong Wang  <jiong.wang@arm.com>
8200
8201         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8202
8203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8204             Jiong Wang  <jiong.wang@arm.com>
8205
8206         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8207         function.
8208         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8209         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8210         (aarch64_gdbarch_init): Add puth registers.
8211         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8212         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8213         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8214
8215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8216             Jiong Wang  <jiong.wang@arm.com>
8217
8218         * aarch64-linux-nat.c
8219         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8220         * aarch64-linux-tdep.c
8221         (aarch64_linux_core_read_description): Likewise.
8222         (aarch64_linux_get_hwcap): New function.
8223         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8224         (aarch64_linux_get_hwcap): New declaration.
8225
8226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8227             Jiong Wang  <jiong.wang@arm.com>
8228
8229         * aarch64-linux-nat.c
8230         (aarch64_linux_nat_target::read_description): Add pauth param.
8231         * aarch64-linux-tdep.c
8232         (aarch64_linux_core_read_description): Likewise.
8233         * aarch64-tdep.c (struct target_desc): Add in pauth.
8234         (aarch64_read_description): Add pauth param.
8235         (aarch64_gdbarch_init): Likewise.
8236         * aarch64-tdep.h (aarch64_read_description): Likewise.
8237         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8238         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8239         * features/Makefile: Add new files.
8240         * features/aarch64-pauth.c: New file.
8241         * features/aarch64-pauth.xml: New file.
8242
8243 2019-03-20  Tom Tromey  <tromey@adacore.com>
8244
8245         * infrun.c (handle_inferior_event): Rename from
8246         handle_inferior_event_1.  Create a scoped_value_mark.
8247         (handle_inferior_event): Remove.
8248
8249 2019-03-19  Tom Tromey  <tromey@adacore.com>
8250
8251         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8252         * infrun.h (print_stop_event): Add "displays" parameter.
8253         * infrun.c (print_stop_event): Add "displays" parameter.
8254
8255 2019-03-19  Pedro Alves  <palves@redhat.com>
8256
8257         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8258         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8259         to -1.  Fix TABs vs spaces.
8260         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8261         * tui/tui-out.h (tui_ui_out) Add intro comments.
8262         <m_line, m_start_of_line>: In-class initialize, and add describing
8263         comment.
8264
8265 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8266
8267         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8268         variable names.
8269         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8270
8271 2019-03-18  Pedro Alves  <palves@redhat.com>
8272             Eli Zaretskii <eliz@gnu.org>
8273
8274         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8275         m_line and m_start_of_line.
8276
8277 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8278
8279         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8280         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8281         it returns a newline.  This fixes a regression in TU mode, whereby
8282         the next line is output on the same screen line as the user input.
8283
8284 2019-03-18  Tom Tromey  <tromey@adacore.com>
8285
8286         * minsyms.c (minimal_symbol_reader::install): Remove call to
8287         obstack_blank.
8288
8289 2019-03-18  Pedro Alves  <palves@redhat.com>
8290
8291         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8292         New globals.
8293         (apply_style): New, factored out from ...
8294         (apply_ansi_escape): ... this.  Handle reverse video mode.
8295         (tui_set_reverse_mode): New function.
8296         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8297         * tui/tui-winsource.c (tui_show_source_line): Use
8298         tui_set_reverse_mode instead of setting A_STANDOUT.
8299         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8300         New setter methods.
8301
8302 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8303
8304         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8305         Handle tabs.
8306
8307 2019-03-18  Tom Tromey  <tromey@adacore.com>
8308
8309         * ada-lang.c (empty_array): Add "high" parameter.
8310         (ada_evaluate_subexp): Update.
8311
8312 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8313
8314         * unittests/string_view-selftests.c: Define
8315         _initialize_string_view_selftests unconditionally.
8316
8317 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8318
8319         PR gdb/24350
8320         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8321
8322 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8323
8324         PR gdb/24351
8325         * windows-nat.c (display_selector): Fix format specifiers.
8326
8327 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8328
8329         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8330         tui_refill_source_window instead of tui_refresh_win, to update the
8331         current execution line.  This fixes redisplay of the current line
8332         when stepping through the code with "next" or "step".
8333
8334 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8335
8336         * source-cache.c (source_cache::get_source_lines): Call
8337         find_source_lines to initialize s->nlines.  This fixes vertical
8338         scrolling of TUI source window when the DOWN arrow is pressed.
8339
8340 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8341
8342         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8343         linux-thread-db.c (_initialize_thread_db): Likewise.
8344
8345 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8346
8347         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8348         wclrtoeol in tui_show_source_line".  This reverts changes made in
8349         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8350
8351 2019-03-15  Tom Tromey  <tom@tromey.com>
8352
8353         * symtab.h (struct minimal_symbol): Derive from
8354         general_symbol_info.
8355         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8356         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8357         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8358         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8359         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8360         (MSYMBOL_SEARCH_NAME): Update.
8361         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8362         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8363         * minsyms.c (minimal_symbol_reader::record_full): Update.
8364
8365 2019-03-15  Tom Tromey  <tom@tromey.com>
8366
8367         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8368
8369 2019-03-15  Tom Tromey  <tom@tromey.com>
8370
8371         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8372         unique_xmalloc_ptr.
8373         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8374         Update.
8375         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8376         (build_minimal_symbol_hash_tables)
8377         (minimal_symbol_reader::install): Update.
8378
8379 2019-03-15  Tom Tromey  <tom@tromey.com>
8380
8381         * symtab.c (create_demangled_names_hash): Update.
8382         (symbol_set_names): Update.
8383         * objfiles.h (struct objfile_per_bfd_storage)
8384         <demangled_names_hash>: Now an htab_up.
8385         * objfiles.c (objfile_per_bfd_storage): Simplify.
8386
8387 2019-03-15  Tom Tromey  <tom@tromey.com>
8388
8389         * objfiles.h (struct objfile_per_bfd_storage): Declare
8390         destructor.
8391         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8392         New.
8393         (get_objfile_bfd_data): Use new.  Don't initialize
8394         language_of_main.
8395         (free_objfile_per_bfd_storage): Remove.
8396         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8397
8398 2019-03-15  Tom Tromey  <tom@tromey.com>
8399
8400         * symfile.c (reread_symbols): Update.
8401         * objfiles.c (objfile::objfile): Update.
8402         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8403         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8404         comment.
8405         (minimal_symbol_reader::install): Update.
8406         (terminate_minimal_symbol_table): Remove.
8407         * jit.c (jit_object_close_impl): Update.
8408
8409 2019-03-15  Tom Tromey  <tom@tromey.com>
8410
8411         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8412         initializations.
8413
8414 2019-03-15  Tom Tromey  <tom@tromey.com>
8415
8416         * objfiles.h (struct objfile_per_bfd_storage)
8417         <demangled_hash_languages>: Now a bitset.
8418         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8419         (lookup_minimal_symbol): Update.
8420
8421 2019-03-15  Tom Tromey  <tom@tromey.com>
8422
8423         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8424         Don't return the symbol.
8425         * coffread.c (record_minimal_symbol): Use record_full.
8426
8427 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8428
8429         The MS-Windows port of ncurses fails to switch to a color pair if
8430         one or both of the colors are the implicit default colors.  This
8431         change records the default colors when TUI is initialized, and
8432         then specifies them explicitly when a color pair uses the default
8433         colors.  This allows color styling in TUI mode on MS-Windows.
8434
8435         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8436         ncurses_norm_attr.
8437         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8438         colors in ncurses_norm_attr.
8439         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8440         "none", replace it with the default color recorded in
8441         ncurses_norm_attr.
8442
8443 2019-03-14  Tom Tromey  <tromey@adacore.com>
8444
8445         * source-cache.h (class source_cache) <get_source_lines>: Return
8446         std::string.
8447         * source-cache.c (source_cache::extract_lines): Handle case where
8448         first_pos==npos.  Return std::string.
8449         (source_cache::get_source_lines): Update.
8450
8451 2019-03-14  Tom Tromey  <tromey@adacore.com>
8452
8453         * NEWS: Add item for "style sources" commands.
8454         * source-cache.c (source_cache::get_source_lines): Check
8455         source_styling.
8456         * cli/cli-style.c (source_styling): New global.
8457         (_initialize_cli_style): Add "style sources" commands.
8458         (show_style_sources): New function.
8459         * cli/cli-style.h (source_styling): Declare.
8460
8461 2019-03-14  Pedro Alves  <palves@redhat.com>
8462             Tom Tromey  <tromey@adacore.com>
8463
8464         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8465         * tui/tui-winsource.c (tui_refill_source_window): New function,
8466         from...
8467         (tui_horizontal_source_scroll): ... here.  Move some logic.
8468         * cli/cli-style.c (set_style_enabled): Notify new observable.
8469         * tui/tui-hooks.c (tui_redisplay_source): New function.
8470         (tui_attach_detach_observers): Attach or detach
8471         tui_redisplay_source.
8472         * observable.h (source_styling_changed): New observable.
8473         * observable.c: Define source_styling_changed observable.
8474
8475 2019-03-13  Tom Tromey  <tromey@adacore.com>
8476
8477         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8478         (i386_gnu_nat_target::store_registers): Update.
8479         * target-debug.h (target_debug_print_std_string): New macro.
8480         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8481         * windows-tdep.c (display_one_tib): Update.
8482         * tui/tui-stack.c (tui_make_status_line): Update.
8483         * top.c (print_inferior_quit_action): Update.
8484         * thread.c (thr_try_catch_cmd): Update.
8485         (add_thread_with_info): Update.
8486         (thread_target_id_str): Update.
8487         (thr_try_catch_cmd): Update.
8488         (thread_command): Update.
8489         (thread_find_command): Update.
8490         * record-btrace.c (record_btrace_target::info_record)
8491         (record_btrace_resume_thread, record_btrace_target::resume)
8492         (record_btrace_cancel_resume, record_btrace_step_thread)
8493         (record_btrace_target::wait, record_btrace_target::wait)
8494         (record_btrace_target::wait, record_btrace_target::stop): Update.
8495         * progspace.c (print_program_space): Update.
8496         * process-stratum-target.c
8497         (process_stratum_target::thread_address_space): Update.
8498         * linux-fork.c (linux_fork_mourn_inferior)
8499         (detach_checkpoint_command, info_checkpoints_command)
8500         (linux_fork_context): Update.
8501         (linux_fork_detach): Update.
8502         (class scoped_switch_fork_info): Update.
8503         (delete_checkpoint_command): Update.
8504         * infrun.c (follow_fork_inferior): Update.
8505         (follow_fork_inferior): Update.
8506         (proceed_after_vfork_done): Update.
8507         (handle_vfork_child_exec_or_exit): Update.
8508         (follow_exec): Update.
8509         (displaced_step_prepare_throw): Update.
8510         (displaced_step_restore): Update.
8511         (start_step_over): Update.
8512         (resume_1): Update.
8513         (clear_proceed_status_thread): Update.
8514         (proceed): Update.
8515         (print_target_wait_results): Update.
8516         (do_target_wait): Update.
8517         (context_switch): Update.
8518         (stop_all_threads): Update.
8519         (restart_threads): Update.
8520         (finish_step_over): Update.
8521         (handle_signal_stop): Update.
8522         (switch_back_to_stepped_thread): Update.
8523         (keep_going_pass_signal): Update.
8524         (print_exited_reason): Update.
8525         (normal_stop): Update.
8526         * inferior.c (inferior_pid_to_str): Change return type.
8527         (print_selected_inferior): Update.
8528         (add_inferior): Update.
8529         (detach_inferior): Update.
8530         * dummy-frame.c (fprint_dummy_frames): Update.
8531         * dcache.c (dcache_info_1): Update.
8532         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8533         (btrace_fetch, btrace_clear): Update.
8534         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8535         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8536         type.
8537         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8538         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8539         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8540         * gdbarch.c, gdbarch.h: Rebuild.
8541         * gdbarch.sh (core_pid_to_str): Change return type.
8542         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8543         return type.
8544         (windows_nat_target::pid_to_str): Change return type.
8545         (windows_delete_thread): Update.
8546         (windows_nat_target::attach): Update.
8547         (windows_nat_target::files_info): Update.
8548         * target-delegates.c: Rebuild.
8549         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8550         return type.
8551         (sol_thread_target::pid_to_str): Change return type.
8552         * remote.c (class remote_target) <pid_to_str>: Change return
8553         type.
8554         (remote_target::pid_to_str): Change return type.
8555         (extended_remote_target::attach, remote_target::remote_stop_ns)
8556         (remote_target::remote_notif_remove_queued_reply)
8557         (remote_target::push_stop_reply, remote_target::disable_btrace):
8558         Update.
8559         (extended_remote_target::attach): Update.
8560         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8561         type.
8562         (gdbsim_target::pid_to_str): Change return type.
8563         * ravenscar-thread.c (struct ravenscar_thread_target)
8564         <pid_to_str>: Change return type.
8565         (ravenscar_thread_target::pid_to_str): Change return type.
8566         * procfs.c (class procfs_target) <pid_to_str>: Change return
8567         type.
8568         (procfs_target::pid_to_str): Change return type.
8569         (procfs_target::attach): Update.
8570         (procfs_target::detach): Update.
8571         (procfs_target::fetch_registers): Update.
8572         (procfs_target::store_registers): Update.
8573         (procfs_target::wait): Update.
8574         (procfs_target::files_info): Update.
8575         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8576         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8577         return type.
8578         (nto_procfs_target::pid_to_str): Change return type.
8579         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8580         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8581         return type.
8582         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8583         (exit_lwp): Update.
8584         (attach_proc_task_lwp_callback, get_detach_signal)
8585         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8586         (linux_nat_target::resume, wait_lwp, stop_callback)
8587         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8588         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8589         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8590         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8591         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8592         type.
8593         (inf_ptrace_target::attach): Update.
8594         (inf_ptrace_target::files_info): Update.
8595         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8596         type.
8597         (go32_nat_target::pid_to_str): Change return type.
8598         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8599         (gnu_nat_target::wait): Update.
8600         (gnu_nat_target::wait): Update.
8601         (gnu_nat_target::resume): Update.
8602         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8603         (fbsd_nat_target::wait): Update.
8604         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8605         type.
8606         (darwin_nat_target::attach): Update.
8607         * corelow.c (class core_target) <pid_to_str>: Change return type.
8608         (core_target::pid_to_str): Change return type.
8609         * target.c (normal_pid_to_str): Change return type.
8610         (default_pid_to_str): Likewise.
8611         (target_pid_to_str): Change return type.
8612         (target_translate_tls_address): Update.
8613         (target_announce_detach): Update.
8614         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8615         return type.
8616         (bsd_uthread_target::pid_to_str): Change return type.
8617         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8618         type.
8619         (bsd_kvm_target::pid_to_str): Change return type.
8620         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8621         return type.
8622         (aix_thread_target::pid_to_str): Change return type.
8623         * target.h (struct target_ops) <pid_to_str>: Change return type.
8624         (target_pid_to_str, normal_pid_to_str): Likewise.
8625         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8626         type.
8627         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8628         type.
8629         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8630         return type.
8631         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8632         type.
8633         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8634         type.
8635         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8636         return type.
8637
8638 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8639
8640         * NEWS: Mention that the new default MI version is 3.  Mention
8641         changes to the output of commands and events that deal with
8642         multi-location breakpoints.
8643         * breakpoint.c: Include "mi/mi-out.h".
8644         (print_one_breakpoint): Change output syntax if using MI version
8645         >= 3.
8646         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8647         New.
8648         (mi_multi_location_breakpoint_output_fixed): New.
8649         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8650         (mi_cmd_fix_multi_location_breakpoint_output): New.
8651         (mi_multi_location_breakpoint_output_fixed): New.
8652         * mi/mi-cmds.c (mi_cmds): Register command
8653         -fix-multi-location-breakpoint-output.
8654         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8655         interpreter "mi".
8656
8657 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8658
8659         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8660         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8661         instantiate mi_ui_out based on interpreter name.
8662         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8663         * mi/mi-main.c (mi_load_progress): Likewise.
8664
8665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8666
8667         * NEWS: Combine separate "New targets" sections for 8.3.
8668
8669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8670
8671         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8672         (ppcfbsd_init_abi): Install gdbarch
8673         "fetch_tls_load_module_address" and "get_thread_local_address"
8674         methods.
8675
8676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8677
8678         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8679         (riscv_fbsd_init_abi): Install gdbarch
8680         "fetch_tls_load_module_address" and "get_thread_local_address"
8681         methods.
8682
8683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8684
8685         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8686         (i386fbsd_init_abi): Install gdbarch
8687         "fetch_tls_load_module_address" and "get_thread_local_address"
8688         methods.
8689
8690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8691
8692         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8693         (amd64fbsd_init_abi): Install gdbarch
8694         "fetch_tls_load_module_address" and "get_thread_local_address"
8695         methods.
8696
8697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8698
8699         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8700         (struct fbsd_pspace_data): New type.
8701         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8702         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8703         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8704         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8705         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8706
8707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8708
8709         * gdbtypes.c (lookup_struct_elt): New function.
8710         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8711         * gdbtypes.h (struct struct_elt): New type.
8712         (lookup_struct_elt): New prototype.
8713
8714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8715
8716         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8717         remove disabled code block.
8718
8719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8720
8721         * gdbarch.sh (get_thread_local_address): New method.
8722         * gdbarch.h, gdbarch.c: Regenerate.
8723         * target.c (target_translate_tls_address): Use
8724         gdbarch_get_thread_local_address if present instead of
8725         target::get_thread_local_address.
8726
8727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8728
8729         * target.h (target::get_thread_local_address): Update comment.
8730
8731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8732
8733         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8734         objfile->separate_debug_objfile_backlink if not NULL.
8735
8736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8737
8738         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8739         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8740         (amd64bsd_store_inferior_registers): Likewise.
8741         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8742         Enable segment base registers.
8743         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8744         PT_GETFSBASE and PT_GETGSBASE.
8745         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8746         PT_SETGSBASE.
8747         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8748         segment base registers.
8749         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8750
8751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8752
8753         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8754         Update calls to i386_target_description to add 'segments'
8755         parameter.
8756         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8757         add segment base registers.
8758         * arch/i386.c (i386_create_target_description): Add 'segments'
8759         parameter to enable segment base registers.
8760         * arch/i386.h (i386_create_target_description): Likewise.
8761         * features/i386/32bit-segments.xml: New file.
8762         * features/i386/32bit-segments.c: Generate.
8763         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8764         call to i386_target_description to add 'segments' parameter.
8765         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8766         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8767         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8768         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8769         if feature is present.
8770         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8771         Add 'segments' parameter to call to i386_target_description.
8772         (i386_target_description): Add 'segments' parameter to enable
8773         segment base registers.
8774         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8775         to call to i386_target_description.
8776         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8777         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8778         Define I386_NUM_REGS.
8779         (i386_target_description): Add 'segments' parameter to enable
8780         segment base registers.
8781
8782 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8783
8784         PR/24325
8785         * source-cache.c: #undef open and close, to avoid unresolved
8786         externals during linking.
8787
8788 2019-03-12  Tom Tromey  <tromey@adacore.com>
8789
8790         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8791         const.  Add initializers.
8792         (_initialize_remote): Don't initialize ptid globals.
8793
8794 2019-03-12  Pedro Alves  <palves@redhat.com>
8795
8796         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8797
8798 2019-03-12  Pedro Alves  <palves@redhat.com>
8799
8800         * cp-name-parser.y (main): Remove unused 'len' variable.
8801
8802 2019-03-12  Tom Tromey  <tromey@adacore.com>
8803
8804         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8805         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8806
8807 2019-03-12  Tom Tromey  <tromey@adacore.com>
8808
8809         * linux-nat.c (iterate_over_lwps): Update.
8810         (stop_callback): Remove parameter.
8811         (stop_wait_callback, detach_callback, resume_set_callback)
8812         (select_singlestep_lwp_callback, set_ignore_sigint)
8813         (status_callback, resumed_callback, resume_clear_callback)
8814         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8815         data parameter.
8816         (linux_nat_target::detach, linux_nat_target::resume)
8817         (linux_stop_and_wait_all_lwps, select_event_lwp)
8818         (linux_nat_filter_event, linux_nat_wait_1)
8819         (linux_nat_target::kill, linux_nat_target::stop)
8820         (linux_nat_target::stop): Update.
8821         (linux_nat_resume_callback): Change type.
8822         (resume_stopped_resumed_lwps, count_events_callback)
8823         (select_event_lwp_callback): Likewise.
8824         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8825         * arm-linux-nat.c (struct update_registers_data): Remove.
8826         (update_registers_callback): Change type.
8827         (arm_linux_insert_hw_breakpoint1): Update.
8828         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8829         parameter.
8830         (x86_linux_dr_set_addr): Update.
8831         (x86_linux_dr_set_control): Update.
8832         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8833         (iterate_over_lwps): Use gdb::function_view.
8834         * nat/aarch64-linux-hw-point.c (struct
8835         aarch64_dr_update_callback_param): Remove.
8836         (debug_reg_change_callback): Change type.
8837         (aarch64_notify_debug_reg_change): Update.
8838         * s390-linux-nat.c (s390_refresh_per_info): Update.
8839
8840 2019-03-11  Tom Tromey  <tromey@adacore.com>
8841
8842         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8843         redundant assignment to "this_cu".
8844
8845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8846
8847         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8848
8849 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8850
8851         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8852         from...
8853         (rank_one_type): ... this.
8854
8855 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8856
8857         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8858         from...
8859         (rank_one_type): ... this.
8860
8861 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8862
8863         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8864         from...
8865         (rank_one_type): ... this.
8866
8867 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8868
8869         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8870         from...
8871         (rank_one_type): ... this.
8872
8873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8874
8875         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8876         from...
8877         (rank_one_type): ... this.
8878
8879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8880
8881         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8882         from...
8883         (rank_one_type): ... this.
8884
8885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8886
8887         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8888         from...
8889         (rank_one_type): ... this.
8890
8891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8892
8893         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8894         from...
8895         (rank_one_type): ... this.
8896
8897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8898
8899         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8900         from...
8901         (rank_one_type): ... this.
8902
8903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8904
8905         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8906         from...
8907         (rank_one_type): ... this.
8908
8909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8910
8911         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8912         from...
8913         (rank_one_type): ... this.
8914
8915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8916
8917         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8918         from...
8919         (rank_one_type): ... this.
8920
8921 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8922
8923         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8924         inferior-events' shows the example events.
8925
8926 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8927
8928         Support styling on native MS-Windows console
8929
8930         PR/24315
8931         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8932         on MS-Windows if $TERM is not defined.
8933
8934         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8935
8936         * posix-hdep.c (gdb_console_fputs):
8937         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8938         functions.
8939         * ui-file.h (gdb_console_fputs): Add prototype.
8940
8941         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8942         back to fputs only if the former returns zero.
8943
8944 2019-03-07  Tom Tromey  <tom@tromey.com>
8945
8946         * symmisc.c (print_symbol_bcache_statistics): Update.
8947         (print_objfile_statistics): Update.
8948         * symfile.c (allocate_symtab): Update.
8949         * stabsread.c: Don't include bcache.h.
8950         * psymtab.h (struct psymbol_bcache): Don't declare.
8951         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8952         (psymbol_bcache_init, psymbol_bcache_free)
8953         (psymbol_bcache_get_bcache): Don't declare.
8954         * psymtab.c (struct psymbol_bcache): Remove.
8955         (psymtab_storage::psymtab_storage): Update.
8956         (psymtab_storage::~psymtab_storage): Update.
8957         (psymbol_bcache_init, psymbol_bcache_free)
8958         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8959         (add_psymbol_to_bcache): Update.
8960         (allocate_psymtab): Update.
8961         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8962         macro_cache>: No longer pointers.
8963         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8964         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8965         * macrotab.c (macro_bcache): Update.
8966         * macroexp.c: Don't include bcache.h.
8967         * gdbtypes.c (check_types_worklist): Update.
8968         (types_deeply_equal): Remove TRY/CATCH.  Update.
8969         * elfread.c (elf_symtab_read): Update.
8970         * dwarf2read.c: Don't include bcache.h.
8971         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8972         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8973         (print_bcache_statistics, bcache_memory_used): Don't declare.
8974         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8975         methods.  Rename all data members.
8976         * bcache.c (struct bcache): Move to bcache.h.
8977         (bcache::expand_hash_table): Rename from expand_hash_table.
8978         (bcache): Remove.
8979         (bcache::insert): Rename from bcache_full.
8980         (bcache::compare): Rename from bcache_compare.
8981         (bcache_xmalloc): Remove.
8982         (bcache::~bcache): Rename from bcache_xfree.
8983         (bcache::print_statistics): Rename from print_bcache_statistics.
8984         (bcache::memory_used): Rename from bcache_memory_used.
8985
8986 2019-03-07  Pedro Alves  <palves@redhat.com>
8987
8988         * infrun.c (normal_stop): Also check for
8989         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8990
8991 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8992
8993         * f-lang.c (value_from_host_double): Moved to...
8994         * value.c (value_from_host_double): ...here.
8995         * value.h (value_from_host_double): Declare.
8996         * guile/scm-math.c (vlscm_convert_typed_number): Use
8997         value_from_host_double.
8998         (vlscm_convert_number): Likewise.
8999         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9000         * python/py-value.c (convert_value_from_python): Likewise.
9001
9002 2019-03-06  Tom Tromey  <tom@tromey.com>
9003
9004         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9005
9006 2019-03-06  Tom Tromey  <tom@tromey.com>
9007
9008         * utils.h (free_current_contents): Don't declare.
9009         * utils.c (free_current_contents): Remove.
9010
9011 2019-03-06  Tom Tromey  <tom@tromey.com>
9012
9013         * top.c (quit_force): Update.
9014         * main.c (captured_command_loop): Update.
9015         * common/new-op.c (operator new): Update.
9016         * common/common-exceptions.c (struct catcher)
9017         <save_cleanup_chain>: Remove member.
9018         (exceptions_state_mc_init): Update.
9019         (exception_try_scope_entry): Return nullptr.
9020         (exception_try_scope_exit, exception_rethrow)
9021         (throw_exception_sjlj, throw_exception_cxx): Update.
9022         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9023         (all_cleanups, do_cleanups, discard_cleanups)
9024         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9025         (restore_cleanups, restore_final_cleanups): Don't declare.
9026         (do_final_cleanups): Remove parameter.
9027         * common/cleanups.c (cleanup_chain, make_cleanup)
9028         (make_cleanup_dtor, all_cleanups, do_cleanups)
9029         (discard_my_cleanups, discard_cleanups)
9030         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9031         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9032         (null_cleanup): Remove.
9033         (do_final_cleanups): Remove parameter.
9034
9035 2019-03-06  Tom Tromey  <tom@tromey.com>
9036
9037         * remote.c (remote_target::remote_parse_stop_reply): Use
9038         unique_xmalloc_ptr.
9039
9040 2019-03-06  Tom Tromey  <tom@tromey.com>
9041
9042         * stabsread.c (struct stabs_field_info): Rename from field_info.
9043         <list, fnlist>: Add initializers.
9044         <obstack>: New member.
9045         (read_member_functions, read_struct_fields, read_baseclasses):
9046         Allocate on obstack.  Don't use cleanups.
9047         (read_one_struct_field, read_member_functions, read_struct_fields)
9048         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9049         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9050         (read_struct_type): Update.
9051
9052 2019-03-06  Tom Tromey  <tom@tromey.com>
9053
9054         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9055         * common/filestuff.h (make_cleanup_close): Don't declare.
9056         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9057         Remove.
9058
9059 2019-03-06  Tom Tromey  <tom@tromey.com>
9060
9061         * solib-aix.c: Use make_scope_exit.
9062
9063 2019-03-06  Tom Tromey  <tom@tromey.com>
9064
9065         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9066         Use make_scope_exit.
9067
9068 2019-03-06  Tom Tromey  <tom@tromey.com>
9069
9070         * solib-svr4.c (disable_probes_interface): Remove parameter.
9071         (svr4_handle_solib_event): Use make_scope_exit.
9072
9073 2019-03-06  Tom Tromey  <tom@tromey.com>
9074
9075         * remote.c (struct stop_reply_deleter): Remove.
9076         (stop_reply_up): Update.
9077         (struct stop_reply): Derive from notif_event.  Don't typedef.
9078         <regcache>: Now a std::vector.
9079         (stop_reply_xfree): Remove.
9080         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9081         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9082         (remote_target::discard_pending_stop_replies): Use delete.
9083         (remote_target::remote_parse_stop_reply): Update.
9084         (remote_target::process_stop_reply): Update.
9085         * remote-notif.h (struct notif_event): Add virtual destructor.
9086         Remove "dtr" member.
9087         (struct notif_client) <alloc_event>: Return a unique_ptr.
9088         (notif_event_xfree): Don't declare.
9089         (notif_event_up): New typedef.
9090         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9091         (notif_event_xfree, do_notif_event_xfree): Remove.
9092         (remote_notif_state_xfree): Update.
9093
9094 2019-03-06  Tom Tromey  <tom@tromey.com>
9095
9096         * infrun.c (displaced_step_clear_cleanup): Now a
9097         forward_scope_exit type.
9098         (displaced_step_prepare_throw): Update.
9099         (displaced_step_fixup): Update.
9100
9101 2019-03-06  Tom Tromey  <tom@tromey.com>
9102
9103         * inferior.h (class inferior): Update comment.
9104         * gdbthread.h (class thread_info): Update comment.
9105
9106 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9107             Tom Tromey  <tom@tromey.com>
9108
9109         * stabsread.h (struct stab_section_list): Remove.
9110         (coffstab_build_psymtabs): Update.
9111         * dbxread.c (symbuf_sections): Now a std::vector.
9112         (sect_idx): New global.
9113         (fill_symbuf): Update.
9114         (coffstab_build_psymtabs): Change type of stabsects parameter.
9115         Update.
9116         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9117         std::vector.
9118         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9119         (coff_locate_sections): Update.
9120         (coff_symfile_read): Remove cleanups.  Update.
9121         (init_stringtab): Add storage parameter.
9122         (free_stringtab, free_stringtab_cleanup): Remove.
9123         (init_lineno): Add storage parameter.
9124         (free_linetab, free_linetab_cleanup): Remove.
9125
9126 2019-03-06  Pedro Alves  <palves@redhat.com>
9127
9128         * linux-fork.c (fork_info::clobber_regs): Delete.
9129         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9130         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9131         comment.  Adjust.
9132         (scoped_switch_fork_info::scoped_switch_fork_info)
9133         (checkpoint_command, linux_fork_context): Adjust
9134         fork_save_infrun_state calls.
9135
9136 2019-03-06  Pedro Alves  <palves@redhat.com>
9137
9138         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9139         (inf_has_multiple_threads): Return 'bool' and rewrite using
9140         inferior_info::threads().
9141
9142 2019-03-06  Pedro Alves  <palves@redhat.com>
9143
9144         * linux-fork.c: Include <list>.
9145         (fork_list): Now a std::list instance.
9146         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9147         (forks_exist_p, find_last_fork): Adjust.
9148         (new_fork): Delete.
9149         (one_fork_p): New.
9150         (add_fork): Adjust.
9151         (free_fork): Delete, folded into fork_info::~fork_info().
9152         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9153         Adjust.
9154         (init_fork_list): Delete.
9155         (linux_fork_killall, linux_fork_mourn_inferior)
9156         (linux_fork_detach, info_checkpoints_command): Adjust.
9157         (_initialize_linux_fork): No longer call init_fork_list.
9158
9159 2019-03-06  Pedro Alves  <palves@redhat.com>
9160
9161         * linux-fork.c (new_fork): New, split out of ...
9162         (add_fork): ... this.  Return void.  Move "first fork" special
9163         case from here, to ...
9164         (checkpoint_command): ... here.
9165         * linux-linux.h (add_fork): Return void.
9166
9167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9168
9169         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9170
9171 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9172             Chris January  <chris.january@arm.com>
9173             David Lecomber  <david.lecomber@arm.com>
9174
9175         * f-exp.y: New token, UNOP_INTRINSIC.
9176         (exp): New pattern using UNOP_INTRINSIC token.
9177         (f77_keywords): Add 'abs' keyword.
9178         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9179         (value_from_host_double): New function.
9180         (evaluate_subexp_f): Support UNOP_ABS.
9181
9182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9183
9184         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9185         types.
9186
9187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9188
9189         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9190         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9191         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9192
9193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9194
9195         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9196
9197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9198             Chris January  <chris.january@arm.com>
9199
9200         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9201         * f-exp.y: Define 'KIND' token.
9202         (exp): New pattern for KIND expressions.
9203         (ptype): Handle types with a kind extension.
9204         (direct_abs_decl): Extend to spot kind extensions.
9205         (f77_keywords): Add 'kind' to the list.
9206         (push_kind_type): New function.
9207         (convert_to_kind_type): New function.
9208         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9209         * parse.c (operator_length_standard): Likewise.
9210         * parser-defs.h (enum type_pieces): Add tp_kind.
9211         * std-operator.def: Add UNOP_KIND.
9212
9213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * f-exp.y (f_parse): Set yydebug.
9216
9217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9218
9219         * f-lang.c (evaluate_subexp_f): New function.
9220         (exp_descriptor_f): New global.
9221         (f_language_defn): Use exp_descriptor_f instead of
9222         exp_descriptor_standard.
9223
9224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * f-exp.y (struct token): Add comments.
9227         (dot_ops): Remove uppercase versions and the end marker.
9228         (f77_keywords): Likewise.
9229         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9230         entries in the dot_ops array are case insensitive, and use
9231         strncasecmp to compare strings.  Also some whitespace cleanup in
9232         this area.  Similar for the f77_keywords array, except entries in
9233         this list might be case sensitive.
9234
9235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * f-exp.y (struct f77_boolean_val): Add comments.
9238         (boolean_values): Remove uppercase versions, and end marker.
9239         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9240         and use strncasecmp to achieve case insensitivity.  Additionally,
9241         perform whitespace cleanup around this code.
9242
9243 2019-03-06  Tom Tromey  <tromey@adacore.com>
9244
9245         * remote-sim.c (gdbsim_target_open): Use result of
9246         gdb_argv::release.
9247
9248 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9249         Dirk Schubert  <dirk.schubert@arm.com>
9250         Chris January  <chris.january@arm.com>
9251
9252         * eval.c (evaluate_subexp_standard): Call Fortran argument
9253         wrapping logic.
9254         * f-lang.c (struct value): A value which can be passed into a
9255         Fortran function call.
9256         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9257         where appropriate.
9258         (struct type): Value ready for a Fortran function call.
9259         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9260         is needed.
9261         * f-lang.h (fortran_argument_convert): Declaration.
9262         (fortran_preserve_arg_pointer): Declaration.
9263         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9264
9265 2019-03-05  Tom Tromey  <tromey@adacore.com>
9266
9267         * python/py-prettyprint.c (print_string_repr): Remove #if.
9268         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9269
9270 2019-03-05  Tom Tromey  <tromey@adacore.com>
9271
9272         * target.c (the_dummy_target): Move later.  Change type to
9273         "dummy_target".
9274         (initialize_targets): Don't initialize the_dummy_target.
9275
9276 2019-03-05  Tom Tromey  <tromey@adacore.com>
9277
9278         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9279         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9280
9281 2019-03-05  Tom Tromey  <tromey@adacore.com>
9282
9283         * windows-nat.c (windows_nat_target::attach)
9284         (windows_nat_target::detach): Don't call gdb_flush.
9285         * valprint.c (generic_val_print, val_print, val_print_string):
9286         Don't call gdb_flush.
9287         * utils.c (defaulted_query): Don't call gdb_flush.
9288         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9289         * target.c (target_announce_detach): Don't call gdb_flush.
9290         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9291         * remote.c (extended_remote_target::attach): Don't call
9292         gdb_flush.
9293         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9294         * printcmd.c (do_examine): Don't call gdb_flush.
9295         (info_display_command): Don't call gdb_flush.
9296         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9297         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9298         * memattr.c (info_mem_command): Don't call gdb_flush.
9299         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9300         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9301         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9302         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9303         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9304         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9305         (gnu_nat_target::detach): Don't call gdb_flush.
9306         * f-valprint.c (f_val_print): Don't call gdb_flush.
9307         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9308         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9309         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9310         gdb_flush.
9311         * c-valprint.c (c_val_print): Don't call gdb_flush.
9312         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9313
9314 2019-03-05  Tom Tromey  <tromey@adacore.com>
9315
9316         * varobj.c (update_dynamic_varobj_children): Update.
9317         (install_default_visualizer): Use reset, not release.
9318         * value.c (set_internalvar): Update.
9319         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9320         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9321         ATTRIBUTE_UNUSED_RESULT.
9322
9323 2019-03-05  Tom Tromey  <tromey@adacore.com>
9324
9325         * remote.c (class scoped_remote_fd) <release>: Add
9326         ATTRIBUTE_UNUSED_RESULT.
9327
9328 2019-03-05  Tom Tromey  <tromey@adacore.com>
9329
9330         * macroexp.c (struct macro_buffer) <release>: Add
9331         ATTRIBUTE_UNUSED_RESULT.
9332
9333 2019-03-05  Tom Tromey  <tromey@adacore.com>
9334
9335         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9336         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9337         ATTRIBUTE_UNUSED_RESULT.
9338
9339 2019-03-05  Tom Tromey  <tromey@adacore.com>
9340
9341         * common/scoped_fd.h (class scoped_fd) <release>: Add
9342         ATTRIBUTE_UNUSED_RESULT.
9343
9344 2019-03-05  Tom Tromey  <tromey@adacore.com>
9345
9346         * parser-defs.h (struct parser_state) <release>: Add
9347         ATTRIBUTE_UNUSED_RESULT.
9348
9349 2019-03-05  Tom Tromey  <tromey@adacore.com>
9350
9351         * utils.h (class gdb_argv) <release>: Add
9352         ATTRIBUTE_UNUSED_RESULT.
9353         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9354
9355 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9356
9357         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9358         for-loop range, to avoid compiler warnings.
9359
9360         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9361         avoid compiler warnings about unused variables.
9362
9363         * NEWS: Mention end of support for native debugging on MS-Windows
9364         before XP.
9365
9366         PR gdb/24292
9367         * common/netstuff.c:
9368         * gdbserver/gdbreplay.c
9369         * gdbserver/remote-utils.c:
9370         * ser-tcp.c:
9371         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9372         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9373         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9374         'getaddrinfo' and 'freeaddrinfo' were not available before
9375         Windows XP, and mingw.org's MinGW headers by default define
9376         _WIN32_WINNT to 0x500.
9377
9378 2019-03-01  Gary Benson <gbenson@redhat.com>
9379
9380         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9381
9382 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9383             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9384
9385         PR gdb/8527
9386         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9387         set_sigint_trap, clear_sigint_trap.
9388
9389 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9390
9391         * target.c (target_detach): Clear the regcache and the
9392         frame cache.
9393
9394 2019-02-27  Pedro Alves  <palves@redhat.com>
9395
9396         * utils.c (set_screen_size): When we cap the height/width sizes,
9397         tweak the corresponding command variable to show "unlimited":
9398
9399 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9400             Pedro Alves  <palves@redhat.com>
9401
9402         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9403         before calling rl_set_screen_size.
9404
9405 2019-02-27  Tom Tromey  <tromey@adacore.com>
9406
9407         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9408         define.
9409         * python/py-value.c: Remove Python 2.4 workaround.
9410         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9411         workaround.
9412         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9413         Python 2.4 workaround.
9414         * python/python-internal.h: Remove Python 2.4 comment.
9415         (Py_ssize_t): Don't define.
9416         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9417         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9418         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9419         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9420         * python/python.c (do_start_initialization): Remove Python 2.4
9421         workaround.
9422         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9423         (print_children): Remove Python 2.4 workaround.
9424         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9425         workaround.
9426         (CHARBUFFERPROC_NAME): Remove.
9427         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9428         Python 2.4 workaround.
9429
9430 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9431
9432         * NEWS: Note minimum Python version.
9433
9434 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9435
9436         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9437         code from these functions.  Remove corresponding ifdefs.  Use
9438         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9439         Remove gotos and target of gotos.
9440         (infpy_search_memory): Likewise.
9441
9442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9443
9444         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9445         (hppa_gdbarch_init): Don't register deleted functions with
9446         gdbarch.
9447
9448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9449
9450         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9451         (h8300_unwind_sp): Delete.
9452         (h8300_dummy_id): Delete.
9453         (h8300_gdbarch_init): Don't register deleted functions with
9454         gdbarch.
9455
9456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9457
9458         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9459         (ft32_unwind_pc): Delete.
9460         (ft32_unwind_sp): Delete.
9461         (ft32_gdbarch_init): Don't register deleted functions with
9462         gdbarch.
9463
9464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9465
9466         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9467         (frv_unwind_pc): Delete.
9468         (frv_unwind_sp): Delete.
9469         (frv_gdbarch_init): Don't register deleted functions with
9470         gdbarch.
9471
9472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9473
9474         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9475         (riscv_unwind_pc): Delete.
9476         (riscv_unwind_sp): Delete.
9477         (riscv_gdbarch_init): Don't register deleted functions with
9478         gdbarch.
9479
9480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9481
9482         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9483         (csky_unwind_pc): Delete.
9484         (csky_unwind_sp): Delete.
9485         (csky_gdbarch_init): Don't register deleted functions with
9486         gdbarch.
9487
9488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9489
9490         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9491         (cris_unwind_pc): Delete.
9492         (cris_unwind_sp): Delete.
9493         (cris_gdbarch_init): Don't register deleted functions with
9494         gdbarch.
9495
9496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9497
9498         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9499         (bfin_unwind_pc): Delete.
9500         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9501
9502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9503
9504         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9505         (arm_unwind_pc): Delete.
9506         (arm_unwind_sp): Delete.
9507         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9508
9509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9510
9511         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9512         (arc_unwind_pc): Delete.
9513         (arc_unwind_sp): Delete.
9514         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9515
9516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9517
9518         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9519         (alpha_unwind_pc): Delete.
9520         (alpha_gdbarch_init): Don't register deleted functions with
9521         gdbarch.
9522
9523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9524
9525         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9526         (aarch64_unwind_pc): Delete.
9527         (aarch64_unwind_sp): Delete.
9528         (aarch64_gdbarch_init): Don't register deleted functions with
9529         gdbarch.
9530
9531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9532
9533         * gdbtypes.c (type_align): Don't consider static members when
9534         computing structure alignment.
9535
9536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9537
9538         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9539         return 0 for other types.
9540         * arch-utils.c (default_type_align): Always return 0.
9541         * gdbarch.h: Regenerate.
9542         * gdbarch.sh (type_align): Extend comment.
9543         * gdbtypes.c (type_align): Add additional comments, always call
9544         gdbarch_type_align before applying the default rules.
9545         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9546         generic code will then apply a suitable default.
9547         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9548         types, return 0 for other types.
9549
9550 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9551
9552         * NEWS: Create a new section for the next release branch.
9553         Rename the section of the current branch, now that it has
9554         been cut.
9555
9556 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9557
9558         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9559         * version.in: Bump version to 8.3.50.DATE-git.
9560
9561 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9562
9563         * aix-thread.c (ptid_cmp): Remove unused variable.
9564         (get_signaled_thread): Likewise.
9565         (store_regs_user_thread): Likewise.
9566         (store_regs_kernel_thread): Likewise.
9567         (fetch_regs_kernel_thread): Remove shadowed variable.
9568
9569 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9570
9571         * features/riscv/32bit-cpu.xml: Add register numbers.
9572         * features/riscv/32bit-fpu.c: Regenerate.
9573         * features/riscv/32bit-fpu.xml: Add register numbers.
9574         * features/riscv/64bit-cpu.xml: Add register numbers.
9575         * features/riscv/64bit-fpu.c: Regenerate.
9576         * features/riscv/64bit-fpu.xml: Add register numbers.
9577
9578 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9579
9580         * NEWS: Mention two argument form of gdb.Value constructor.
9581         * python/py-value.c (convert_buffer_and_type_to_value): New
9582         function.
9583         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9584         Add support for handling an optional second argument.  Call
9585         convert_buffer_and_type_to_value as appropriate.
9586         * python/python-internal.h (Py_buffer_deleter): New struct.
9587         (Py_buffer_up): New typedef.
9588
9589 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9590
9591         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9592         instead of releasing ownership.
9593
9594 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9595
9596         * dwarf2read.c (open_and_init_dwp_file): Call
9597         elf_numsections instead of bfd_count_sections to initialize
9598         dwp_file->num_sections.
9599
9600 2019-02-25  Tom Tromey  <tromey@adacore.com>
9601
9602         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9603
9604 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9605
9606         * gcore.in: Add '--readnever' option when invoking GDB.
9607
9608 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9609
9610         * MAINTAINERS: Update my email address.
9611
9612 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9613
9614         * build-id.c (build_id_to_debug_bfd_1): New function.
9615         (build_id_to_debug_bfd): Look for separate debug file in
9616         sysroot.
9617
9618 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9619
9620         * gdbarch.sh: Update the copyright year range that is placed into
9621         generated files.
9622
9623 2019-02-22  Keith Seitz  <keiths@redhat.com>
9624
9625         PR symtab/23853
9626         * linespec.c (create_sals_line_offset): Search for the default
9627         symtab's filename instead of its fullname.
9628
9629 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9630
9631         * NEWS: Update style defaults.
9632
9633 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9634
9635         * main.c (captured_main_1): Disable styling in batch mode.
9636
9637 2019-02-20  Tom Tromey  <tom@tromey.com>
9638
9639         * symtab.c (symtab_symbol_info): Fix typos.
9640
9641 2019-02-20  Tom Tromey  <tromey@adacore.com>
9642
9643         * findcmd.c (_initialize_mem_search): Use upper case for
9644         metasyntactic variables.
9645
9646 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9647
9648         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9649         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9650
9651 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9652
9653         * top.h (source_file_name): Change to std::string.
9654         * top.c (source_file_name): Likewise.
9655         (command_line_input): Adjust.
9656         * cli/cli-script.c (script_from_file): Adjust.
9657
9658 2019-02-19  Tom Tromey  <tromey@adacore.com>
9659
9660         * ravenscar-thread.c
9661         (ravenscar_thread_target::update_thread_list): Don't call
9662         ada_build_task_list.
9663         * ada-lang.h (ada_build_task_list): Don't declare.
9664         * ada-tasks.c (struct ada_tasks_inferior_data)
9665         <task_list_valid_p>: Now bool.
9666         (read_known_tasks, ada_task_list_changed)
9667         (ada_tasks_invalidate_inferior_data): Update.
9668         (read_known_tasks_array): Return bool.
9669         (read_known_tasks_list): Likewise.
9670         (read_known_tasks): Return void.
9671         (ada_build_task_list): Now static.
9672
9673 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9674
9675         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9676         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9677
9678 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9679
9680         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9681         variant for ada_tasks_pspace_data_handle and
9682         ada_tasks_inferior_data_handle.
9683         (ada_tasks_pspace_data_cleanup): New function.
9684         (ada_tasks_inferior_data_cleanup): New function.
9685
9686 2019-02-17  Tom Tromey  <tom@tromey.com>
9687
9688         * macrotab.h (macro_source_fullname): Return a std::string.
9689         * macrotab.c (macro_include, check_for_redefinition)
9690         (macro_undef, macro_lookup_definition, foreach_macro)
9691         (foreach_macro_in_scope): Update.
9692         (macro_source_fullname): Return a std::string.
9693         * macrocmd.c (show_pp_source_pos): Update.
9694
9695 2019-02-17  Tom Tromey  <tom@tromey.com>
9696
9697         * macrocmd.c (show_pp_source_pos): Style the file names.
9698
9699 2019-02-17  Tom Tromey  <tom@tromey.com>
9700
9701         PR tui/24197:
9702         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9703
9704 2019-02-17  Tom Tromey  <tom@tromey.com>
9705
9706         * ada-lang.c (user_select_syms): Use filtered printing.
9707         * utils.c (wrap_style): New global.
9708         (desired_style): Remove.
9709         (emit_style_escape): Add stream parameter.
9710         (set_output_style, reset_terminal_style, prompt_for_continue):
9711         Update.
9712         (flush_wrap_buffer): Only flush gdb_stdout.
9713         (wrap_here): Set wrap_style.
9714         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9715         treat escape sequences as a character.  Change when wrap buffer is
9716         flushed.
9717         (fputs_styled): Do not set the output style when the default is
9718         requested.
9719         * ui-style.h (struct ui_file_style) <is_default>: New method.
9720         * source.c (print_source_lines_base): Emit escape sequences in one
9721         piece.
9722
9723 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9724
9725         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9726         integers and enumeration types.
9727
9728 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9729
9730         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9731         instead of lookup_symbol_in_language
9732         (do_exact_match): New function.
9733         (ada_get_symbol_name_matcher): Return do_exact_match when
9734         doing a verbatim match.
9735
9736 2019-02-15  Tom Tromey  <tromey@adacore.com>
9737
9738         * ravenscar-thread.c (ravenscar_thread_target::resume)
9739         (ravenscar_thread_target::wait): Special case wildcard requests.
9740
9741 2019-02-15  Tom Tromey  <tromey@adacore.com>
9742
9743         * ravenscar-thread.c (base_ptid): Remove.
9744         (struct ravenscar_thread_target) <close>: New method.
9745         <m_base_ptid>: New member.
9746         <update_inferior_ptid, active_task, task_is_currently_active,
9747         runtime_initialized>: Declare methods.
9748         <ravenscar_thread_target>: Add constructor.
9749         (ravenscar_thread_target::task_is_currently_active)
9750         (ravenscar_thread_target::update_inferior_ptid)
9751         (ravenscar_runtime_initialized): Rename.  Now methods.
9752         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9753         (ravenscar_thread_target::update_thread_list): Update.
9754         (ravenscar_thread_target::active_task): Now method.
9755         (ravenscar_thread_target::store_registers)
9756         (ravenscar_thread_target::prepare_to_store)
9757         (ravenscar_thread_target::prepare_to_store)
9758         (ravenscar_thread_target::mourn_inferior): Update.
9759         (ravenscar_inferior_created): Use "new" to create target.
9760         (ravenscar_thread_target::get_ada_task_ptid): Update.
9761         (_initialize_ravenscar): Don't initialize base_ptid.
9762         (ravenscar_ops): Remove global.
9763
9764 2019-02-15  Tom Tromey  <tromey@adacore.com>
9765
9766         * target.h (push_target): Declare new overload.
9767         * target.c (push_target): New overload, taking an rvalue reference.
9768         * remote.c (remote_target::open_1): Use push_target overload.
9769         * corelow.c (core_target_open): Use push_target overload.
9770
9771 2019-02-15  Tom Tromey  <tromey@adacore.com>
9772
9773         * ravenscar-thread.c (is_ravenscar_task)
9774         (ravenscar_task_is_currently_active): Return bool.
9775         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9776         (_initialize_ravenscar): Remove "(void)".
9777         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9778         Return bool.
9779
9780 2019-02-15  Tom Tromey  <tromey@adacore.com>
9781
9782         * ravenscar-thread.c (ravenscar_runtime_initializer)
9783         (has_ravenscar_runtime, get_running_thread_id)
9784         (ravenscar_thread_target::resume): Fix indentation.
9785
9786 2019-02-15  Tom Tromey  <tromey@adacore.com>
9787
9788         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9789         from ravenscar_arch_ops.
9790         (sparc_ravenscar_ops::fetch_registers)
9791         (sparc_ravenscar_ops::store_registers): Now methods.
9792         (sparc_ravenscar_prepare_to_store): Remove.
9793         (sparc_ravenscar_ops): Redefine.
9794         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9795         methods and destructor.  Remove members.
9796         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9797         (ravenscar_thread_target::store_registers)
9798         (ravenscar_thread_target::prepare_to_store): Update.
9799         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9800         Remove.
9801         (struct ppc_ravenscar_powerpc_ops): Derive from
9802         ravenscar_arch_ops.
9803         (ppc_ravenscar_powerpc_ops::fetch_registers)
9804         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9805         (ppc_ravenscar_powerpc_ops): Redefine.
9806         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9807         (ppc_ravenscar_e500_ops::fetch_registers)
9808         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9809         (ppc_ravenscar_e500_ops): Redefine.
9810         * aarch64-ravenscar-thread.c
9811         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9812         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9813         (aarch64_ravenscar_fetch_registers)
9814         (aarch64_ravenscar_store_registers): Now methods.
9815         (aarch64_ravenscar_ops): Redefine.
9816
9817 2019-02-15  Tom Tromey  <tromey@adacore.com>
9818
9819         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9820         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9821         (ravenscar_thread_target::stopped_by_watchpoint)
9822         (ravenscar_thread_target::stopped_data_address)
9823         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9824
9825 2019-02-15  Tom Tromey  <tromey@adacore.com>
9826
9827         * ravenscar-thread.c: Fix some typos.
9828
9829 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9830             Tom Tromey  <tromey@adacore.com>
9831
9832         * ada-lang.c (ada_exception_sal): Change addr_string to a
9833         std::string.
9834         (create_ada_exception_catchpoint): Update.
9835
9836 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9837             Tom Tromey  <tromey@adacore.com>
9838
9839         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9840         (bp_location_ops): Remove.
9841         (base_breakpoint_allocate_location): Update.
9842         (free_bp_location): Update.
9843         * ada-lang.c (class ada_catchpoint_location)
9844         <ada_catchpoint_location>: Remove ops parameter.
9845         (ada_catchpoint_location_dtor): Remove.
9846         (ada_catchpoint_location_ops): Remove.
9847         (allocate_location_exception): Update.
9848         * breakpoint.h (struct bp_location_ops): Remove.
9849         (class bp_location) <bp_location>: Remove bp_location_ops
9850         parameter.
9851         <~bp_location>: Add destructor.
9852         <ops>: Remove.
9853
9854 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9855             Pedro Alves  <palves@redhat.com>
9856
9857         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9858         'PATH_MAX'.
9859
9860 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9861             Samuel Thibault  <samuel.thibault@gnu.org>
9862             Thomas Schwinge  <thomas@codesourcery.com>
9863
9864         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9865         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9866
9867 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9868
9869         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9870         (check_empty): Use "const char *".
9871
9872         * gnu-nat.c (gnu_nat_target::detach): Instead of
9873         'detach_inferior (pid)' call
9874         'detach_inferior (find_inferior_pid (pid))'.
9875
9876         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9877         'nat/fork-inferior.o'.
9878         * gnu-nat.c: #include "nat/fork-inferior.h".
9879
9880         * gnu-nat.c (gnu_nat_target::detach): Instead of
9881         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9882         * gnu-nat.h: #include "inf-child.h".
9883         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9884         'i386_gnu_nat_target::fetch_registers'.
9885         (gnu_store_registers): Rename/move to
9886         'i386_gnu_nat_target::store_registers'.
9887
9888         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9889         * gnu-nat.h (mach_thread_info): New function.
9890         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9891
9892         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9893
9894 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9895
9896         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9897
9898 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9899
9900         * windows-nat.c (windows_add_thread): Add new parameter
9901         "main_thread_p" with default value set to false.  Update
9902         function documentation as well as all callers.
9903         (windows_delete_thread): Likewise.
9904         (fake_create_process): Update call to windows_add_thread.
9905         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9906         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9907         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9908         call to windows_delete_thread.
9909
9910 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9911
9912         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9913
9914 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9915
9916         * symfile.c (find_separate_debug_file): Use canonical path of
9917         sysroot with child_path instead of gdb_sysroot if it is valid.
9918
9919 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9920
9921         * symfile.c (find_separate_debug_file): Use child_path to
9922         determine if an object file is under a sysroot.
9923
9924 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9925
9926         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9927         unittests/child-path-selftests.c.
9928         * common/pathstuff.c (child_path): New function.
9929         * common/pathstuff.h (child_path): New prototype.
9930         * unittests/child-path-selftests.c: New file.
9931
9932 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9933
9934         * symfile.c (find_separate_debug_file): Look for separate debug
9935         files in debug directories under the sysroot.
9936
9937 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9938
9939         * symtab.h (struct minimal_symbol data_p): New const method.
9940         (struct minimal_symbol text_p): Likewise.
9941         * symtab.c (output_source_filename): Use file name style
9942         to print file name.
9943         (print_symbol_info): Likewise.
9944         (print_msymbol_info): Use address style to print addresses.
9945         Use function name style to print executable text symbols.
9946         (expand_symtab_containing_pc): Use data_p.
9947         (find_pc_sect_compunit_symtab): Likewise.
9948
9949 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9950
9951         * breakpoint.c (describe_other_breakpoints): Use address style
9952         to print addresses.
9953         (say_where): Likewise.
9954
9955 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9956
9957         * ada-typeprint.c (print_func_type): Print function name
9958         style to print function name.
9959         * c-typeprint.c (c_print_type_1): Likewise.
9960
9961 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9962
9963         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9964         for execve.
9965
9966 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9967
9968         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9969         type_stack.
9970
9971 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9972
9973         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9974         TYPE_CODE_REF types.
9975
9976 2019-02-08  Jim Wilson  <jimw@sifive.com>
9977
9978         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9979         (riscv_linux_fregset): New.
9980         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9981
9982 2019-02-07  Tom Tromey  <tom@tromey.com>
9983
9984         * thread.c (thread_cancel_execution_command): Update.
9985         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9986         methods.
9987         (struct thread_fsm_ops): Remove.
9988         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9989         (thread_fsm_should_stop, thread_fsm_return_value)
9990         (thread_fsm_set_finished, thread_fsm_finished_p)
9991         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9992         Don't declare.
9993         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9994         * infrun.c (clear_proceed_status_thread)
9995         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9996         (print_stop_event): Update.
9997         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9998         Add constructor.
9999         (step_command_fsm_ops): Remove.
10000         (new_step_command_fsm): Remove.
10001         (step_1): Update.
10002         (step_command_fsm::should_stop): Rename from
10003         step_command_fsm_should_stop.
10004         (step_command_fsm::clean_up): Rename from
10005         step_command_fsm_clean_up.
10006         (step_command_fsm::do_async_reply_reason): Rename from
10007         step_command_fsm_async_reply_reason.
10008         (struct until_next_fsm): Inherit from thread_fsm.  Add
10009         constructor.
10010         (until_next_fsm_ops): Remove.
10011         (new_until_next_fsm): Remove.
10012         (until_next_fsm::should_stop): Rename from
10013         until_next_fsm_should_stop.
10014         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10015         (until_next_fsm::do_async_reply_reason): Rename from
10016         until_next_fsm_async_reply_reason.
10017         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10018         constructor.  Change type of breakpoint.
10019         (finish_command_fsm_ops): Remove.
10020         (new_finish_command_fsm): Remove.
10021         (finish_command_fsm::should_stop): Rename from
10022         finish_command_fsm_should_stop.
10023         (finish_command_fsm::clean_up): Rename from
10024         finish_command_fsm_clean_up.
10025         (finish_command_fsm::return_value): Rename from
10026         finish_command_fsm_return_value.
10027         (finish_command_fsm::do_async_reply_reason): Rename from
10028         finish_command_fsm_async_reply_reason.
10029         (finish_command): Update.
10030         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10031         Add constructor.
10032         (call_thread_fsm_ops): Remove.
10033         (call_thread_fsm::call_thread_fsm): Rename from
10034         new_call_thread_fsm.
10035         (call_thread_fsm::should_stop): Rename from
10036         call_thread_fsm_should_stop.
10037         (call_thread_fsm::should_notify_stop): Rename from
10038         call_thread_fsm_should_notify_stop.
10039         (run_inferior_call, call_function_by_hand_dummy): Update.
10040         * cli/cli-interp.c (should_print_stop_to_console): Update.
10041         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10042         Add constructor.  Change type of location_breakpoint,
10043         caller_breakpoint.
10044         (until_break_fsm_ops): Remove.
10045         (new_until_break_fsm): Remove.
10046         (until_break_fsm::should_stop): Rename from
10047         until_break_fsm_should_stop.
10048         (until_break_fsm::clean_up): Rename from
10049         until_break_fsm_clean_up.
10050         (until_break_fsm::do_async_reply_reason): Rename from
10051         until_break_fsm_async_reply_reason.
10052         (until_break_command): Update.
10053         * thread-fsm.c: Remove.
10054         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10055
10056 2019-02-07  Tom Tromey  <tom@tromey.com>
10057
10058         * yy-remap.h: Add include guard.
10059         * xtensa-tdep.h: Add include guard.
10060         * xcoffread.h: Rename include guard.
10061         * varobj-iter.h: Add include guard.
10062         * tui/tui.h: Rename include guard.
10063         * tui/tui-winsource.h: Rename include guard.
10064         * tui/tui-wingeneral.h: Rename include guard.
10065         * tui/tui-windata.h: Rename include guard.
10066         * tui/tui-win.h: Rename include guard.
10067         * tui/tui-stack.h: Rename include guard.
10068         * tui/tui-source.h: Rename include guard.
10069         * tui/tui-regs.h: Rename include guard.
10070         * tui/tui-out.h: Rename include guard.
10071         * tui/tui-layout.h: Rename include guard.
10072         * tui/tui-io.h: Rename include guard.
10073         * tui/tui-hooks.h: Rename include guard.
10074         * tui/tui-file.h: Rename include guard.
10075         * tui/tui-disasm.h: Rename include guard.
10076         * tui/tui-data.h: Rename include guard.
10077         * tui/tui-command.h: Rename include guard.
10078         * tic6x-tdep.h: Add include guard.
10079         * target/waitstatus.h: Rename include guard.
10080         * target/wait.h: Rename include guard.
10081         * target/target.h: Rename include guard.
10082         * target/resume.h: Rename include guard.
10083         * target-float.h: Rename include guard.
10084         * stabsread.h: Add include guard.
10085         * rs6000-tdep.h: Add include guard.
10086         * riscv-fbsd-tdep.h: Add include guard.
10087         * regformats/regdef.h: Rename include guard.
10088         * record.h: Rename include guard.
10089         * python/python.h: Rename include guard.
10090         * python/python-internal.h: Rename include guard.
10091         * python/py-stopevent.h: Rename include guard.
10092         * python/py-ref.h: Rename include guard.
10093         * python/py-record.h: Rename include guard.
10094         * python/py-record-full.h: Rename include guard.
10095         * python/py-record-btrace.h: Rename include guard.
10096         * python/py-instruction.h: Rename include guard.
10097         * python/py-events.h: Rename include guard.
10098         * python/py-event.h: Rename include guard.
10099         * procfs.h: Add include guard.
10100         * proc-utils.h: Add include guard.
10101         * p-lang.h: Add include guard.
10102         * or1k-tdep.h: Rename include guard.
10103         * observable.h: Rename include guard.
10104         * nto-tdep.h: Rename include guard.
10105         * nat/x86-linux.h: Rename include guard.
10106         * nat/x86-linux-dregs.h: Rename include guard.
10107         * nat/x86-gcc-cpuid.h: Add include guard.
10108         * nat/x86-dregs.h: Rename include guard.
10109         * nat/x86-cpuid.h: Rename include guard.
10110         * nat/ppc-linux.h: Rename include guard.
10111         * nat/mips-linux-watch.h: Rename include guard.
10112         * nat/linux-waitpid.h: Rename include guard.
10113         * nat/linux-ptrace.h: Rename include guard.
10114         * nat/linux-procfs.h: Rename include guard.
10115         * nat/linux-osdata.h: Rename include guard.
10116         * nat/linux-nat.h: Rename include guard.
10117         * nat/linux-namespaces.h: Rename include guard.
10118         * nat/linux-btrace.h: Rename include guard.
10119         * nat/glibc_thread_db.h: Rename include guard.
10120         * nat/gdb_thread_db.h: Rename include guard.
10121         * nat/gdb_ptrace.h: Rename include guard.
10122         * nat/fork-inferior.h: Rename include guard.
10123         * nat/amd64-linux-siginfo.h: Rename include guard.
10124         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10125         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10126         * nat/aarch64-linux.h: Rename include guard.
10127         * nat/aarch64-linux-hw-point.h: Rename include guard.
10128         * mn10300-tdep.h: Add include guard.
10129         * mips-linux-tdep.h: Add include guard.
10130         * mi/mi-parse.h: Rename include guard.
10131         * mi/mi-out.h: Rename include guard.
10132         * mi/mi-main.h: Rename include guard.
10133         * mi/mi-interp.h: Rename include guard.
10134         * mi/mi-getopt.h: Rename include guard.
10135         * mi/mi-console.h: Rename include guard.
10136         * mi/mi-common.h: Rename include guard.
10137         * mi/mi-cmds.h: Rename include guard.
10138         * mi/mi-cmd-break.h: Rename include guard.
10139         * m2-lang.h: Add include guard.
10140         * location.h: Rename include guard.
10141         * linux-record.h: Rename include guard.
10142         * linux-nat.h: Add include guard.
10143         * linux-fork.h: Add include guard.
10144         * i386-darwin-tdep.h: Rename include guard.
10145         * hppa-linux-offsets.h: Add include guard.
10146         * guile/guile.h: Rename include guard.
10147         * guile/guile-internal.h: Rename include guard.
10148         * gnu-nat.h: Rename include guard.
10149         * gdb-stabs.h: Rename include guard.
10150         * frv-tdep.h: Add include guard.
10151         * f-lang.h: Add include guard.
10152         * event-loop.h: Add include guard.
10153         * darwin-nat.h: Rename include guard.
10154         * cp-abi.h: Rename include guard.
10155         * config/sparc/nm-sol2.h: Rename include guard.
10156         * config/nm-nto.h: Rename include guard.
10157         * config/nm-linux.h: Add include guard.
10158         * config/i386/nm-i386gnu.h: Rename include guard.
10159         * config/djgpp/nl_types.h: Rename include guard.
10160         * config/djgpp/langinfo.h: Rename include guard.
10161         * compile/gcc-cp-plugin.h: Add include guard.
10162         * compile/gcc-c-plugin.h: Add include guard.
10163         * compile/compile.h: Rename include guard.
10164         * compile/compile-object-run.h: Rename include guard.
10165         * compile/compile-object-load.h: Rename include guard.
10166         * compile/compile-internal.h: Rename include guard.
10167         * compile/compile-cplus.h: Rename include guard.
10168         * compile/compile-c.h: Rename include guard.
10169         * common/xml-utils.h: Rename include guard.
10170         * common/x86-xstate.h: Rename include guard.
10171         * common/version.h: Rename include guard.
10172         * common/vec.h: Rename include guard.
10173         * common/tdesc.h: Rename include guard.
10174         * common/selftest.h: Rename include guard.
10175         * common/scoped_restore.h: Rename include guard.
10176         * common/scoped_mmap.h: Rename include guard.
10177         * common/scoped_fd.h: Rename include guard.
10178         * common/safe-iterator.h: Rename include guard.
10179         * common/run-time-clock.h: Rename include guard.
10180         * common/refcounted-object.h: Rename include guard.
10181         * common/queue.h: Rename include guard.
10182         * common/ptid.h: Rename include guard.
10183         * common/print-utils.h: Rename include guard.
10184         * common/preprocessor.h: Rename include guard.
10185         * common/pathstuff.h: Rename include guard.
10186         * common/observable.h: Rename include guard.
10187         * common/netstuff.h: Rename include guard.
10188         * common/job-control.h: Rename include guard.
10189         * common/host-defs.h: Rename include guard.
10190         * common/gdb_wait.h: Rename include guard.
10191         * common/gdb_vecs.h: Rename include guard.
10192         * common/gdb_unlinker.h: Rename include guard.
10193         * common/gdb_unique_ptr.h: Rename include guard.
10194         * common/gdb_tilde_expand.h: Rename include guard.
10195         * common/gdb_sys_time.h: Rename include guard.
10196         * common/gdb_string_view.h: Rename include guard.
10197         * common/gdb_splay_tree.h: Rename include guard.
10198         * common/gdb_setjmp.h: Rename include guard.
10199         * common/gdb_ref_ptr.h: Rename include guard.
10200         * common/gdb_optional.h: Rename include guard.
10201         * common/gdb_locale.h: Rename include guard.
10202         * common/gdb_assert.h: Rename include guard.
10203         * common/filtered-iterator.h: Rename include guard.
10204         * common/filestuff.h: Rename include guard.
10205         * common/fileio.h: Rename include guard.
10206         * common/environ.h: Rename include guard.
10207         * common/common-utils.h: Rename include guard.
10208         * common/common-types.h: Rename include guard.
10209         * common/common-regcache.h: Rename include guard.
10210         * common/common-inferior.h: Rename include guard.
10211         * common/common-gdbthread.h: Rename include guard.
10212         * common/common-exceptions.h: Rename include guard.
10213         * common/common-defs.h: Rename include guard.
10214         * common/common-debug.h: Rename include guard.
10215         * common/cleanups.h: Rename include guard.
10216         * common/buffer.h: Rename include guard.
10217         * common/btrace-common.h: Rename include guard.
10218         * common/break-common.h: Rename include guard.
10219         * cli/cli-utils.h: Rename include guard.
10220         * cli/cli-style.h: Rename include guard.
10221         * cli/cli-setshow.h: Rename include guard.
10222         * cli/cli-script.h: Rename include guard.
10223         * cli/cli-interp.h: Rename include guard.
10224         * cli/cli-decode.h: Rename include guard.
10225         * cli/cli-cmds.h: Rename include guard.
10226         * charset-list.h: Add include guard.
10227         * buildsym-legacy.h: Rename include guard.
10228         * bfin-tdep.h: Add include guard.
10229         * ax.h: Rename include guard.
10230         * arm-linux-tdep.h: Add include guard.
10231         * arm-fbsd-tdep.h: Add include guard.
10232         * arch/xtensa.h: Rename include guard.
10233         * arch/tic6x.h: Add include guard.
10234         * arch/i386.h: Add include guard.
10235         * arch/arm.h: Rename include guard.
10236         * arch/arm-linux.h: Rename include guard.
10237         * arch/arm-get-next-pcs.h: Rename include guard.
10238         * arch/amd64.h: Add include guard.
10239         * arch/aarch64-insn.h: Rename include guard.
10240         * arch-utils.h: Rename include guard.
10241         * annotate.h: Add include guard.
10242         * amd64-darwin-tdep.h: Rename include guard.
10243         * aarch64-linux-tdep.h: Add include guard.
10244         * aarch64-fbsd-tdep.h: Add include guard.
10245         * aarch32-linux-nat.h: Add include guard.
10246
10247 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10248
10249         * macrotab.c (macro_define_internal): New function that
10250         factorizes macro_define_object_internal and macro_define_function
10251         code.
10252         (macro_define_object_internal): Use macro_define_internal.
10253         (macro_define_function): Likewise.
10254
10255 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10256
10257         * macrocmd.c (extract_identifier): Return
10258         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10259         callers.
10260
10261 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10262
10263         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10264
10265 2019-02-05  Tom Tromey  <tom@tromey.com>
10266
10267         * target.c (target_stack::unpush): Move assertion earlier.
10268
10269 2019-01-30  Tom Tromey  <tom@tromey.com>
10270
10271         PR python/23615:
10272         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10273         (gdbpy_parse_and_eval): Likewise.
10274         * python/python-internal.h (gdbpy_allow_threads): New class.
10275
10276 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10277
10278         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10279         (aarch64_fbsd_fpregmap): Move earlier.
10280         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10281         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10282         instead of individual calls to trad_frame_set_reg_addr.
10283         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10284         earlier.
10285         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10286         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10287         instead of individual calls to trad_frame_set_reg_addr.
10288
10289 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10290
10291         * CONTRIBUTE: Replace contribution list with wiki link.
10292
10293 2019-01-25  Tom Tromey  <tom@tromey.com>
10294
10295         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10296
10297 2019-01-25  Tom Tromey  <tom@tromey.com>
10298
10299         * xtensa-linux-nat.c: Fix common/ includes.
10300         * xml-support.h: Fix common/ includes.
10301         * xml-support.c: Fix common/ includes.
10302         * x86-linux-nat.c: Fix common/ includes.
10303         * windows-nat.c: Fix common/ includes.
10304         * varobj.h: Fix common/ includes.
10305         * varobj.c: Fix common/ includes.
10306         * value.c: Fix common/ includes.
10307         * valops.c: Fix common/ includes.
10308         * utils.c: Fix common/ includes.
10309         * unittests/xml-utils-selftests.c: Fix common/ includes.
10310         * unittests/utils-selftests.c: Fix common/ includes.
10311         * unittests/unpack-selftests.c: Fix common/ includes.
10312         * unittests/tracepoint-selftests.c: Fix common/ includes.
10313         * unittests/style-selftests.c: Fix common/ includes.
10314         * unittests/string_view-selftests.c: Fix common/ includes.
10315         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10316         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10317         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10318         * unittests/rsp-low-selftests.c: Fix common/ includes.
10319         * unittests/parse-connection-spec-selftests.c: Fix common/
10320         includes.
10321         * unittests/optional-selftests.c: Fix common/ includes.
10322         * unittests/offset-type-selftests.c: Fix common/ includes.
10323         * unittests/observable-selftests.c: Fix common/ includes.
10324         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10325         * unittests/memrange-selftests.c: Fix common/ includes.
10326         * unittests/memory-map-selftests.c: Fix common/ includes.
10327         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10328         * unittests/function-view-selftests.c: Fix common/ includes.
10329         * unittests/environ-selftests.c: Fix common/ includes.
10330         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10331         * unittests/common-utils-selftests.c: Fix common/ includes.
10332         * unittests/cli-utils-selftests.c: Fix common/ includes.
10333         * unittests/array-view-selftests.c: Fix common/ includes.
10334         * ui-file.c: Fix common/ includes.
10335         * tui/tui-io.c: Fix common/ includes.
10336         * tracepoint.h: Fix common/ includes.
10337         * tracepoint.c: Fix common/ includes.
10338         * tracefile-tfile.c: Fix common/ includes.
10339         * top.h: Fix common/ includes.
10340         * top.c: Fix common/ includes.
10341         * thread.c: Fix common/ includes.
10342         * target/waitstatus.h: Fix common/ includes.
10343         * target/waitstatus.c: Fix common/ includes.
10344         * target.h: Fix common/ includes.
10345         * target.c: Fix common/ includes.
10346         * target-memory.c: Fix common/ includes.
10347         * target-descriptions.c: Fix common/ includes.
10348         * symtab.h: Fix common/ includes.
10349         * symfile.c: Fix common/ includes.
10350         * stap-probe.c: Fix common/ includes.
10351         * spu-linux-nat.c: Fix common/ includes.
10352         * sparc-nat.c: Fix common/ includes.
10353         * source.c: Fix common/ includes.
10354         * solib.c: Fix common/ includes.
10355         * solib-target.c: Fix common/ includes.
10356         * ser-unix.c: Fix common/ includes.
10357         * ser-tcp.c: Fix common/ includes.
10358         * ser-pipe.c: Fix common/ includes.
10359         * ser-base.c: Fix common/ includes.
10360         * selftest-arch.c: Fix common/ includes.
10361         * s12z-tdep.c: Fix common/ includes.
10362         * rust-exp.y: Fix common/ includes.
10363         * rs6000-aix-tdep.c: Fix common/ includes.
10364         * riscv-tdep.c: Fix common/ includes.
10365         * remote.c: Fix common/ includes.
10366         * remote-notif.h: Fix common/ includes.
10367         * remote-fileio.h: Fix common/ includes.
10368         * remote-fileio.c: Fix common/ includes.
10369         * regcache.h: Fix common/ includes.
10370         * regcache.c: Fix common/ includes.
10371         * record-btrace.c: Fix common/ includes.
10372         * python/python.c: Fix common/ includes.
10373         * python/py-type.c: Fix common/ includes.
10374         * python/py-inferior.c: Fix common/ includes.
10375         * progspace.h: Fix common/ includes.
10376         * producer.c: Fix common/ includes.
10377         * procfs.c: Fix common/ includes.
10378         * proc-api.c: Fix common/ includes.
10379         * printcmd.c: Fix common/ includes.
10380         * ppc-linux-nat.c: Fix common/ includes.
10381         * parser-defs.h: Fix common/ includes.
10382         * osdata.c: Fix common/ includes.
10383         * obsd-nat.c: Fix common/ includes.
10384         * nat/x86-linux.c: Fix common/ includes.
10385         * nat/x86-linux-dregs.c: Fix common/ includes.
10386         * nat/x86-dregs.h: Fix common/ includes.
10387         * nat/x86-dregs.c: Fix common/ includes.
10388         * nat/ppc-linux.c: Fix common/ includes.
10389         * nat/mips-linux-watch.h: Fix common/ includes.
10390         * nat/mips-linux-watch.c: Fix common/ includes.
10391         * nat/linux-waitpid.c: Fix common/ includes.
10392         * nat/linux-ptrace.h: Fix common/ includes.
10393         * nat/linux-ptrace.c: Fix common/ includes.
10394         * nat/linux-procfs.c: Fix common/ includes.
10395         * nat/linux-personality.c: Fix common/ includes.
10396         * nat/linux-osdata.c: Fix common/ includes.
10397         * nat/linux-namespaces.c: Fix common/ includes.
10398         * nat/linux-btrace.h: Fix common/ includes.
10399         * nat/linux-btrace.c: Fix common/ includes.
10400         * nat/fork-inferior.c: Fix common/ includes.
10401         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10402         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10403         * nat/aarch64-linux.c: Fix common/ includes.
10404         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10405         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10406         * namespace.h: Fix common/ includes.
10407         * mips-linux-tdep.c: Fix common/ includes.
10408         * minsyms.c: Fix common/ includes.
10409         * mi/mi-parse.h: Fix common/ includes.
10410         * mi/mi-main.c: Fix common/ includes.
10411         * mi/mi-cmd-env.c: Fix common/ includes.
10412         * memrange.h: Fix common/ includes.
10413         * memattr.c: Fix common/ includes.
10414         * maint.h: Fix common/ includes.
10415         * maint.c: Fix common/ includes.
10416         * main.c: Fix common/ includes.
10417         * machoread.c: Fix common/ includes.
10418         * location.c: Fix common/ includes.
10419         * linux-thread-db.c: Fix common/ includes.
10420         * linux-nat.c: Fix common/ includes.
10421         * linux-fork.c: Fix common/ includes.
10422         * inline-frame.c: Fix common/ includes.
10423         * infrun.c: Fix common/ includes.
10424         * inflow.c: Fix common/ includes.
10425         * inferior.h: Fix common/ includes.
10426         * inferior.c: Fix common/ includes.
10427         * infcmd.c: Fix common/ includes.
10428         * inf-ptrace.c: Fix common/ includes.
10429         * inf-child.c: Fix common/ includes.
10430         * ia64-linux-nat.c: Fix common/ includes.
10431         * i387-tdep.c: Fix common/ includes.
10432         * i386-tdep.c: Fix common/ includes.
10433         * i386-linux-tdep.c: Fix common/ includes.
10434         * i386-linux-nat.c: Fix common/ includes.
10435         * i386-go32-tdep.c: Fix common/ includes.
10436         * i386-fbsd-tdep.c: Fix common/ includes.
10437         * i386-fbsd-nat.c: Fix common/ includes.
10438         * guile/scm-type.c: Fix common/ includes.
10439         * guile/guile.c: Fix common/ includes.
10440         * go32-nat.c: Fix common/ includes.
10441         * gnu-nat.c: Fix common/ includes.
10442         * gdbthread.h: Fix common/ includes.
10443         * gdbarch-selftests.c: Fix common/ includes.
10444         * gdb_usleep.c: Fix common/ includes.
10445         * gdb_select.h: Fix common/ includes.
10446         * gdb_bfd.c: Fix common/ includes.
10447         * gcore.c: Fix common/ includes.
10448         * fork-child.c: Fix common/ includes.
10449         * findvar.c: Fix common/ includes.
10450         * fbsd-nat.c: Fix common/ includes.
10451         * event-top.c: Fix common/ includes.
10452         * event-loop.c: Fix common/ includes.
10453         * dwarf2read.c: Fix common/ includes.
10454         * dwarf2loc.c: Fix common/ includes.
10455         * dwarf2-frame.c: Fix common/ includes.
10456         * dwarf-index-cache.c: Fix common/ includes.
10457         * dtrace-probe.c: Fix common/ includes.
10458         * disasm-selftests.c: Fix common/ includes.
10459         * defs.h: Fix common/ includes.
10460         * csky-tdep.c: Fix common/ includes.
10461         * cp-valprint.c: Fix common/ includes.
10462         * cp-support.h: Fix common/ includes.
10463         * cp-support.c: Fix common/ includes.
10464         * corelow.c: Fix common/ includes.
10465         * completer.h: Fix common/ includes.
10466         * completer.c: Fix common/ includes.
10467         * compile/compile.c: Fix common/ includes.
10468         * compile/compile-loc2c.c: Fix common/ includes.
10469         * compile/compile-cplus-types.c: Fix common/ includes.
10470         * compile/compile-cplus-symbols.c: Fix common/ includes.
10471         * command.h: Fix common/ includes.
10472         * cli/cli-dump.c: Fix common/ includes.
10473         * cli/cli-cmds.c: Fix common/ includes.
10474         * charset.c: Fix common/ includes.
10475         * build-id.c: Fix common/ includes.
10476         * btrace.h: Fix common/ includes.
10477         * btrace.c: Fix common/ includes.
10478         * breakpoint.h: Fix common/ includes.
10479         * breakpoint.c: Fix common/ includes.
10480         * ax.h:
10481         (enum agent_op): Fix common/ includes.
10482         * ax-general.c (struct aop_map): Fix common/ includes.
10483         * ax-gdb.c: Fix common/ includes.
10484         * auxv.c: Fix common/ includes.
10485         * auto-load.c: Fix common/ includes.
10486         * arm-tdep.c: Fix common/ includes.
10487         * arch/riscv.c: Fix common/ includes.
10488         * arch/ppc-linux-common.c: Fix common/ includes.
10489         * arch/i386.c: Fix common/ includes.
10490         * arch/arm.c: Fix common/ includes.
10491         * arch/arm-linux.c: Fix common/ includes.
10492         * arch/arm-get-next-pcs.c: Fix common/ includes.
10493         * arch/amd64.c: Fix common/ includes.
10494         * arch/aarch64.c: Fix common/ includes.
10495         * arch/aarch64-insn.c: Fix common/ includes.
10496         * arch-utils.c: Fix common/ includes.
10497         * amd64-windows-tdep.c: Fix common/ includes.
10498         * amd64-tdep.c: Fix common/ includes.
10499         * amd64-sol2-tdep.c: Fix common/ includes.
10500         * amd64-obsd-tdep.c: Fix common/ includes.
10501         * amd64-nbsd-tdep.c: Fix common/ includes.
10502         * amd64-linux-tdep.c: Fix common/ includes.
10503         * amd64-linux-nat.c: Fix common/ includes.
10504         * amd64-fbsd-tdep.c: Fix common/ includes.
10505         * amd64-fbsd-nat.c: Fix common/ includes.
10506         * amd64-dicos-tdep.c: Fix common/ includes.
10507         * amd64-darwin-tdep.c: Fix common/ includes.
10508         * agent.c: Fix common/ includes.
10509         * ada-lang.h: Fix common/ includes.
10510         * ada-lang.c: Fix common/ includes.
10511         * aarch64-tdep.c: Fix common/ includes.
10512
10513 2019-01-25  Tom Tromey  <tom@tromey.com>
10514
10515         * common/create-version.sh: Use common/version.h.
10516
10517 2019-01-24  Pedro Alves  <palves@redhat.com>
10518
10519         * infrun.c (signal_stop, signal_print, signal_program)
10520         (signal_catch, signal_pass): Now arrays instead of pointers.
10521         (update_signals_program_target, do_target_resume)
10522         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10523         * linux-nat.c (linux_nat_target::pass_signals)
10524         (linux_nat_target::create_inferior, linux_nat_target::attach):
10525         Adjust.
10526         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10527         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10528         * procfs.c (procfs_target::pass_signals): Adjust.
10529         * record-full.c (record_full_target::resume): Adjust.
10530         * remote.c (remote_target::pass_signals)
10531         (remote_target::program_signals): Adjust.
10532         * target-debug.h (target_debug_print_signals): Now takes a
10533         gdb::array_view as parameter.  Adjust.
10534         * target.h (target_ops) <pass_signals, program_signals>: Replace
10535         pointer and length parameters with gdb::array_view.
10536         (target_pass_signals, target_program_signals): Likewise.
10537         * target-delegates.c: Regenerate.
10538
10539 2019-01-24  Pedro Alves  <palves@redhat.com>
10540
10541         * common/forward-scope-exit.h
10542         (forward_scope_exit::forward_scope_exit): Pass arguments to
10543         m_bind_function directly, instead of creating a std::bind and
10544         copying that.
10545
10546 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10547
10548         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10549         for static members.
10550         (pass_in_v_vfp_candidate): Likewise.
10551
10552 2019-01-23  Tom Tromey  <tom@tromey.com>
10553             Pedro Alves  <palves@redhat.com>
10554
10555         * regcache.c (class regcache_invalidator): Remove.
10556         (regcache::raw_write): Use make_scope_exit.
10557
10558 2019-01-23  Tom Tromey  <tom@tromey.com>
10559
10560         * ui-out.h (class ui_out_emit_type): Update comment.
10561
10562 2019-01-23  Tom Tromey  <tom@tromey.com>
10563
10564         * infrun.c (fetch_inferior_event): Update comment.
10565
10566 2019-01-23  Tom Tromey  <tom@tromey.com>
10567             Pedro Alves  <palves@redhat.com>
10568
10569         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10570         parameter.
10571         (fetch_inferior_event): Use SCOPE_EXIT.
10572
10573
10574 2019-01-23  Tom Tromey  <tom@tromey.com>
10575             Pedro Alves  <palves@redhat.com>
10576
10577         * infrun.c (disable_thread_events): Delete.
10578         (stop_all_threads): Use SCOPE_EXIT.
10579
10580 2019-01-23  Tom Tromey  <tom@tromey.com>
10581             Pedro Alves  <palves@redhat.com>
10582
10583         * symfile.c: Include forward-scope-exit.h.
10584         (clear_symtab_users_cleanup): Replace forward declaration with
10585         a FORWARD_SCOPE_EXIT.
10586         (syms_from_objfile_1): Use the forward_scope_exit and
10587         gdb::optional instead of cleanup_function.
10588         (reread_symbols): Use the forward_scope_exit instead of
10589         cleanup_function.
10590         (clear_symtab_users_cleanup): Remove function.
10591
10592 2019-01-23  Tom Tromey  <tom@tromey.com>
10593             Pedro Alves  <palves@redhat.com>
10594
10595         * linux-nat.c: Include scope-exit.h.
10596         (cleanup_target_stop): Remove.
10597         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10598         SCOPE_EXIT.
10599
10600 2019-01-23  Tom Tromey  <tom@tromey.com>
10601             Pedro Alves  <palves@redhat.com>
10602
10603         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10604         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10605
10606 2019-01-23  Tom Tromey  <tom@tromey.com>
10607             Andrew Burgess  <andrew.burgess@embecosm.com>
10608             Pedro Alves  <palves@redhat.com>
10609
10610         * infrun.c (fetch_inferior_event): Use scope_exit.
10611         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10612         * top.c (execute_command): Use scope_exit.
10613         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10614         * utils.c (do_bpstat_clear_actions_cleanup)
10615         (make_bpstat_clear_actions_cleanup): Remove.
10616
10617 2019-01-23  Tom Tromey  <tom@tromey.com>
10618             Pedro Alves  <palves@redhat.com>
10619
10620         * infrun.c: Include "common/scope-exit.h"
10621         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10622         (wait_for_inferior): Use SCOPE_EXIT.
10623         (fetch_inferior_event): Use scope_exit.
10624
10625 2019-01-23  Tom Tromey  <tom@tromey.com>
10626             Pedro Alves  <palves@redhat.com>
10627
10628         * breakpoint.c (create_breakpoint): Remove cleanup.
10629
10630 2019-01-23  Tom Tromey  <tom@tromey.com>
10631             Andrew Burgess  <andrew.burgess@embecosm.com>
10632             Pedro Alves  <palves@redhat.com>
10633
10634 2019-01-23  Pedro Alves  <palves@redhat.com>
10635
10636         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10637
10638 2019-01-23  Pedro Alves  <palves@redhat.com>
10639             Andrew Burgess  <andrew.burgess@embecosm.com>
10640
10641         * gdbthread.h: Include "common/forward-scope-exit.h".
10642         (scoped_finish_thread_state): Redefine custom class in terms of
10643         forward_scope_exit.
10644
10645 2019-01-23  Pedro Alves  <palves@redhat.com>
10646             Andrew Burgess  <andrew.burgess@embecosm.com>
10647
10648         * common/forward-scope-exit.h: New file.
10649
10650 2019-01-23  Pedro Alves  <palves@redhat.com>
10651             Andrew Burgess  <andrew.burgess@embecosm.com>
10652             Tom Tromey  <tom@tromey.com>
10653
10654         * common/scope-exit.h: New file.
10655
10656 2019-01-23  Pedro Alves  <palves@redhat.com>
10657
10658         * common/preprocessor.h (ESC): Rename to ...
10659         (ESC_PARENS): ... this.
10660         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10661         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10662
10663 2019-01-23  Tom Tromey  <tom@tromey.com>
10664
10665         * language.h (class scoped_switch_to_sym_language_if_auto):
10666         Initialize m_lang in both cases.
10667
10668 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10669
10670         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10671         with XCNEW.
10672
10673 2019-01-22  Tom Tromey  <tom@tromey.com>
10674
10675         * corelow.c: Do not include sys/file.h.
10676
10677 2019-01-22  Tom Tromey  <tom@tromey.com>
10678
10679         * tui/tui-wingeneral.h: Include gdb_curses.h.
10680
10681 2019-01-22  Tom Tromey  <tom@tromey.com>
10682
10683         * source-cache.h (class source_cache) <get_source_lines,
10684         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10685
10686 2019-01-22  Tom Tromey  <tom@tromey.com>
10687
10688         * remote-fileio.h (struct remote_target): Declare.
10689
10690 2019-01-22  Tom Tromey  <tom@tromey.com>
10691
10692         * python/py-arch.c: Do not include py-ref.h.
10693         * python/py-bpevent.c: Do not include py-ref.h.
10694         * python/py-cmd.c: Do not include py-ref.h.
10695         * python/py-continueevent.c: Do not include py-ref.h.
10696         * python/py-event.h: Do not include py-ref.h.
10697         * python/py-evtregistry.c: Do not include py-ref.h.
10698         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10699         * python/py-frame.c: Do not include py-ref.h.
10700         * python/py-framefilter.c: Do not include py-ref.h.
10701         * python/py-function.c: Do not include py-ref.h.
10702         * python/py-infevents.c: Do not include py-ref.h.
10703         * python/py-linetable.c: Do not include py-ref.h.
10704         * python/py-objfile.c: Do not include py-ref.h.
10705         * python/py-param.c: Do not include py-ref.h.
10706         * python/py-prettyprint.c: Do not include py-ref.h.
10707         * python/py-progspace.c: Do not include py-ref.h.
10708         * python/py-symbol.c: Do not include py-ref.h.
10709         * python/py-symtab.c: Do not include py-ref.h.
10710         * python/py-type.c: Do not include py-ref.h.
10711         * python/py-unwind.c: Do not include py-ref.h.
10712         * python/py-utils.c: Do not include py-ref.h.
10713         * python/py-value.c: Do not include py-ref.h.
10714         * python/py-varobj.c: Do not include py-ref.h.
10715         * python/py-xmethods.c: Do not include py-ref.h.
10716         * python/python.c: Do not include py-ref.h.
10717         * varobj.c: Do not include py-ref.h.
10718
10719 2019-01-22  Tom Tromey  <tom@tromey.com>
10720
10721         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10722         keyword for bcache.
10723
10724 2019-01-22  Tom Tromey  <tom@tromey.com>
10725
10726         * compile/compile-cplus-types.c: Remove a comment by #include.
10727
10728 2019-01-22  Tom Tromey  <tom@tromey.com>
10729
10730         * compile/gcc-c-plugin.h: Include compile-internal.h.
10731
10732 2019-01-22  Tom Tromey  <tom@tromey.com>
10733
10734         * stabsread.c (EXTERN): Do not define.
10735         (symnum, next_symbol_text_func, processing_gcc_compilation)
10736         (within_function, global_sym_chain, global_stabs)
10737         (previous_stab_code, this_object_header_files)
10738         (n_this_object_header_files)
10739         (n_allocated_this_object_header_files): Define.
10740         * stabsread.h (EXTERN): Never define.  Use "extern".
10741
10742 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10743
10744         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10745         history_value.
10746
10747 2019-01-21  Tom Tromey  <tom@tromey.com>
10748
10749         * ui-out.c: Fix includes.
10750         * tui/tui-source.c: Fix includes.
10751         * target.c: Fix includes.
10752         * remote.c: Fix includes.
10753         * regcache.c: Fix includes.
10754         * python/py-block.c: Fix includes.
10755         * printcmd.c: Fix includes.
10756         * or1k-tdep.c: Fix includes.
10757         * mi/mi-main.c: Fix includes.
10758         * m32r-tdep.c: Fix includes.
10759         * csky-tdep.c: Fix includes.
10760         * compile/compile-cplus-types.c: Fix includes.
10761         * cli/cli-interp.c: Fix includes.
10762
10763 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10764
10765         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10766         for padding.
10767
10768 2019-01-16  Tom Tromey  <tom@tromey.com>
10769
10770         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10771         earlier.
10772         (struct objfile) <msymbols_range>: Move from top level.
10773         <msymbols>: New method.
10774         (class objfile_msymbols): Remove.
10775         * symtab.c (default_collect_symbol_completion_matches_break_on):
10776         Update.
10777         * symmisc.c (dump_msymbols): Update.
10778         * stabsread.c (scan_file_globals): Update.
10779         * objc-lang.c (info_selectors_command, info_classes_command)
10780         (find_methods): Update.
10781         * minsyms.c (find_solib_trampoline_target): Update.
10782         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10783         * coffread.c (coff_symfile_read): Update.
10784         * ada-lang.c (ada_lookup_simple_minsym)
10785         (ada_collect_symbol_completion_matches): Update.
10786
10787 2019-01-16  Tom Tromey  <tom@tromey.com>
10788
10789         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10790         type.  Remove no-argument constructor.
10791         <iterator::operator++>: Simplify.
10792         <begin>: Update.
10793         <end>: Use minimal_symbol_count.
10794
10795 2019-01-16  Tom Tromey  <tom@tromey.com>
10796
10797         * objfiles.h (struct objfile) <psymtabs>: New method.
10798         (class objfile_psymtabs): Remove.
10799         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10800         typedef.
10801         <range>: New method.
10802         (require_partial_symbols): Change return type.
10803         * psymtab.c (require_partial_symbols)
10804         (psym_expand_symtabs_matching): Update.
10805         * mdebugread.c (parse_partial_symbols): Update.
10806         * dbxread.c (dbx_end_psymtab): Update.
10807
10808 2019-01-15  Tom Tromey  <tom@tromey.com>
10809
10810         * symtab.c (lookup_objfile_from_block)
10811         (lookup_symbol_in_objfile_symtabs)
10812         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10813         (find_line_symtab, info_sources_command)
10814         (default_collect_symbol_completion_matches_break_on)
10815         (make_source_files_completion_list): Update.
10816         * symmisc.c (print_objfile_statistics, dump_objfile)
10817         (maintenance_print_symbols, maintenance_info_symtabs)
10818         (maintenance_check_symtabs, maintenance_info_line_tables):
10819         Update.
10820         * source.c (select_source_symtab)
10821         (forget_cached_source_info_for_objfile): Update.
10822         * objfiles.h (class objfile_compunits): Remove.
10823         (struct objfile) <compunits_range>: New typedef.
10824         (compunits): New method.
10825         * objfiles.c (objfile_relocate1): Update.
10826         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10827         * maint.c (count_symtabs_and_blocks): Update.
10828         * linespec.c (iterate_over_all_matching_symtabs): Update.
10829         * cp-support.c (add_symbol_overload_list_qualified): Update.
10830         * coffread.c (coff_symtab_read): Update.
10831         * ada-lang.c (add_nonlocal_symbols)
10832         (ada_collect_symbol_completion_matches)
10833         (ada_add_global_exceptions): Update.
10834
10835 2019-01-15  Tom Tromey  <tom@tromey.com>
10836
10837         * progspace.h (program_space) <objfiles_safe_range>: New
10838         typedef.
10839         <objfiles_safe>: New method.
10840         * objfiles.h (class all_objfiles_safe): Remove.
10841         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10842         * jit.c (jit_inferior_exit_hook): Update.
10843
10844 2019-01-17  Tom Tromey  <tom@tromey.com>
10845
10846         * progspace.h (program_space) <objfiles_range>: New typedef.
10847         <objfiles>: New method.
10848         <objfiles_head>: Rename from objfiles.
10849         (object_files): Update.
10850         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10851         * guile/scm-pretty-print.c
10852         (ppscm_find_pretty_printer_from_objfiles): Update.
10853         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10854         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10855         Update.
10856         * python/py-progspace.c (pspy_get_objfiles): Update.
10857         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10858         Update.
10859         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10860         (objfpy_lookup_objfile_by_build_id): Update.
10861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10862         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10863         Update.
10864         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10865         (expand_symtab_containing_pc, lookup_objfile_from_block)
10866         (lookup_static_symbol, basic_lookup_transparent_type)
10867         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10868         (find_line_symtab, info_sources_command)
10869         (default_collect_symbol_completion_matches_break_on)
10870         (make_source_files_completion_list, find_main_name): Update.
10871         * symmisc.c (print_symbol_bcache_statistics)
10872         (print_objfile_statistics, maintenance_print_symbols)
10873         (maintenance_print_msymbols, maintenance_print_objfiles)
10874         (maintenance_info_symtabs, maintenance_check_symtabs)
10875         (maintenance_expand_symtabs, maintenance_info_line_tables):
10876         Update.
10877         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10878         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10879         (map_overlay_command, unmap_overlay_command)
10880         (simple_overlay_update, expand_symtabs_matching)
10881         (map_symbol_filenames): Update.
10882         * symfile-debug.c (set_debug_symfile): Update.
10883         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10884         Update.
10885         * source.c (select_source_symtab, forget_cached_source_info):
10886         Update.
10887         * solib.c (solib_read_symbols): Update.
10888         * solib-spu.c (append_ocl_sos): Update.
10889         * psymtab.c (maintenance_print_psymbols)
10890         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10891         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10892         * printcmd.c (info_symbol_command): Update.
10893         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10894         Update.
10895         * objfiles.h (class all_objfiles): Remove.
10896         * objfiles.c (have_partial_symbols, have_full_symbols)
10897         (have_minimal_symbols, qsort_cmp, update_section_map)
10898         (shared_objfile_contains_address_p)
10899         (default_iterate_over_objfiles_in_search_order): Update.
10900         * objc-lang.c (info_selectors_command, info_classes_command)
10901         (find_methods): Update.
10902         * minsyms.c (find_solib_trampoline_target): Update.
10903         * maint.c (maintenance_info_sections)
10904         (maintenance_translate_address, count_symtabs_and_blocks):
10905         Update.
10906         * main.c (captured_main_1): Update.
10907         * linux-thread-db.c (try_thread_db_load_from_pdir)
10908         (has_libpthread): Update.
10909         * linespec.c (iterate_over_all_matching_symtabs)
10910         (search_minsyms_for_name): Update.
10911         * jit.c (jit_find_objf_with_entry_addr): Update.
10912         * hppa-tdep.c (find_unwind_entry)
10913         (hppa_lookup_stub_minimal_symbol): Update.
10914         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10915         Update.
10916         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10917         (elf_gnu_ifunc_resolve_by_got): Update.
10918         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10919         * dwarf-index-write.c (save_gdb_index_command): Update.
10920         * cp-support.c (add_symbol_overload_list_qualified): Update.
10921         * breakpoint.c (create_overlay_event_breakpoint)
10922         (create_longjmp_master_breakpoint)
10923         (create_std_terminate_master_breakpoint)
10924         (create_exception_master_breakpoint): Update.
10925         * blockframe.c (find_pc_partial_function): Update.
10926         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10927         (ada_collect_symbol_completion_matches)
10928         (ada_add_global_exceptions): Update.
10929
10930 2019-01-17  Tom Tromey  <tom@tromey.com>
10931
10932         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10933         declare VEC.
10934         (solib_target_parse_libraries): Change return type.
10935         (library_list_start_segment, library_list_start_section)
10936         (library_list_end_library, library_list_start_library); Update.
10937         (solib_target_free_library_list): Remove.
10938         (solib_target_parse_libraries): Remove cleanup.  Change return
10939         type.
10940         (solib_target_current_sos): Update.
10941
10942 2019-01-17  Tom Tromey  <tromey@bapiya>
10943
10944         * valprint.c: Replace "the the" with "the".
10945         * symtab.c: Replace "the the" with "the".
10946         * solib.c: Replace "the the" with "the".
10947         * solib-dsbt.c: Replace "the the" with "the".
10948         * linespec.c: Replace "the the" with "the".
10949         * dwarf2loc.h: Replace "the the" with "the".
10950         * amd64-windows-tdep.c: Replace "the the" with "the".
10951         * aarch64-tdep.c: Replace "the the" with "the".
10952
10953 2019-01-16  Keith Seitz  <keiths@redhat.com>
10954
10955         PR gdb/23773
10956         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10957         <builder>: Rename to ..
10958         <m_builder>: ... this and make private.
10959         (dwarf2_cu::get_builder): New method.  Change all users of
10960         `builder' to use this method.
10961         (dwarf2_start_symtab): Move to ...
10962         (dwarf2_cu::start_symtab): ... here.  Update all callers
10963         (setup_type_unit_groups): Move to ...
10964         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10965         callers.
10966         (dwarf2_cu::reset_builder): New method.
10967         (process_full_compunit, process_full_type_unit): Use
10968         dwarf2_cu::reset_builder.
10969         (follow_die_offset): Record the ancestor CU if it is different
10970         from the followed DIE's CU.
10971         (follow_die_sig_1): Likewise.
10972
10973 2019-01-15  Tom Tromey  <tom@tromey.com>
10974
10975         * remote.c (class remote_state) <buf>: Now a char_vector.
10976         <buf_size>: Remove.
10977         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10978         parameter.
10979         (remote_target::getpkt_or_notif_sane_1)
10980         (remote_target::getpkt_sane)
10981         (remote_target::getpkt_or_notif_sane): Likewise.
10982         (class remote_target) <putpkt>: New overload.
10983         (remote_target::read_frame): Change type of "buf_p".  Remove
10984         sizeof_p parameter.
10985         (packet_ok): New overload.
10986         (packet_check_result): New overload.
10987         Update all uses.
10988
10989 2019-01-14  Tom Tromey  <tom@tromey.com>
10990
10991         * remote-notif.c (handle_notification, remote_notif_ack)
10992         (remote_notif_parse): Make "buf" const.
10993         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10994         const.
10995         (remote_notif_parse, remote_notif_ack, handle_notification):
10996         Likewise.
10997         * remote.c (remote_notif_stop_parse): Make "buf" const.
10998         (remote_target::remote_parse_stop_reply): Make "buf" const.
10999         (remote_notif_stop_ack): Make "buf" const.
11000
11001 2019-01-14  Tom Tromey  <tom@tromey.com>
11002
11003         * remote.c (remote_console_output): Make parameter const.
11004
11005 2019-01-14  Tom Tromey  <tom@tromey.com>
11006
11007         * target-debug.h (target_debug_print_signals): Constify.
11008         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11009         * procfs.c (procfs_target::pass_signals): Update.
11010         * linux-nat.c (linux_nat_target::pass_signals): Update.
11011         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11012         * target-delegates.c: Rebuild.
11013         * remote.c (remote_target::program_signals): Update.
11014         (remote_target::pass_signals): Update.
11015         * target.c (target_pass_signals): Constify argument.
11016         (target_program_signals): Likewise.
11017         * target.h (struct target_ops) <pass_signals, program_signals>:
11018         Constify argument.
11019         (target_pass_signals, target_program_signals): Constify argument.
11020
11021 2019-01-14  Tom Tromey  <tom@tromey.com>
11022
11023         PR tui/28819:
11024         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11025
11026 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11027
11028         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11029         field.
11030         * rs6000-tdep.c: Include reggroups.h.
11031         (IS_V_ALIAS_PSEUDOREG): Define.
11032         (rs6000_register_name): Return names for the "vX" aliases.
11033         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11034         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11035         aliases.  Call default_register_reggroup_p for all other
11036         pseudo-registers.
11037         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11038         New functions.
11039         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11040         Handle "vX" aliases.
11041         (v_alias_pseudo_register_collect): New function.
11042         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11043         (rs6000_gdbarch_init): Initialize "vX" aliases as
11044         pseudo-registers.  Restore registration of
11045         rs6000_pseudo_register_reggroup_p with
11046         set_tdesc_pseudo_register_reggroup_p.
11047
11048 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11049
11050         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11051         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11052         set_gdbarch_num_pseudo_regs.
11053
11054 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11055
11056         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11057         Remove arg prefixname, add do_set and do_show.
11058         Add member functions set_list and show_list.
11059         * cli/cli-style.c (class cli_style_option): Update accordingly.
11060         (style_set_list): Move to file scope.
11061         (style_show_list): Likewise.
11062         (set_style): Call help_list.
11063         (show_style): Call cmd_show_list.
11064         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11065         Update to use the new macro.
11066
11067 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11068
11069         * ada-lang.c (_initialize_ada_language): Expand the help text
11070         for the "catch exception" command.
11071
11072 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11073
11074         * symtab.c (matching_obj_sections): Initialize obj,
11075         declare it closer to its usage.
11076
11077 2019-01-10  Tom Tromey  <tom@tromey.com>
11078
11079         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11080         (basic_inf_threads_range): Remove.
11081         (inf_threads_range, inf_non_exited_threads_range)
11082         (safe_inf_threads_range): Use next_adapter.
11083
11084 2019-01-10  Keith Seitz  <keiths@redhat.com>
11085
11086         PR gdb/23712
11087         PR symtab/23010
11088         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11089         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11090
11091 2019-01-10  Keith Seitz  <keiths@redhat.com>
11092
11093         PR gdb/23712
11094         PR symtab/23010
11095         * dictionary.c (pending_to_vector): Remove.
11096         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11097         Remove _1 suffix, replacing functions of the same name.  Update
11098         all callers.
11099         (dict_create_hashed, dict_create_hashed_expandable)
11100         (dict_create_linear, dict_create_linear_expandable, dict_free)
11101         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11102         Make functions static.
11103
11104 2019-01-10  Keith Seitz  <keiths@redhat.com>
11105
11106         PR gdb/23712
11107         PR symtab/23010
11108         * dictionary.h (struct dictionary): Replace declaration with
11109         multidictionary.
11110         (dict_create_hashed, dict_create_hashed_expandable)
11111         (dict_create_linear, dict_create_linear_expandable)
11112         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11113         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11114         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11115         taking multidictionary argument.
11116         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11117         * block.h (struct block) <dict>: Change to multidictionary
11118         and rename `multidict'.
11119         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11120         symmisc.c: Update all dictionary references to multidictionary.
11121
11122 2019-01-10  Keith Seitz  <keiths@redhat.com>
11123
11124         PR gdb/23712
11125         PR symtab/23010
11126         * dictionary.c: Include unordered_map.
11127         (pending_to_vector): New function.
11128         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11129         Rewrite the non-"_1" functions to take vector instead
11130         of linked list.
11131         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11132         "new" _1 versions of the same name.
11133         (multidictionary): Define.
11134         (std::hash<enum language): New definition.
11135         (collate_pending_symbols_by_language, mdict_create_hashed)
11136         (mdict_create_hashed_expandable, mdict_create_linear)
11137         (mdict_create_linear_expandable, mdict_free)
11138         (find_language_dictionary, create_new_language_dictionary)
11139         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11140         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11141         (mdict_size, mdict_empty): New functions.
11142         * dictionary.h (mdict_iterator): Define.
11143
11144 2019-01-10  Pedro Alves  <palves@redhat.com>
11145
11146         * breakpoint.c (read_uploaded_action)
11147         (create_tracepoint_from_upload): Adjust to use
11148         gdb::unique_xmalloc_ptr.
11149         * ctf.c (ctf_write_uploaded_tp):
11150         (SET_ARRAY_FIELD): Use emplace_back.
11151         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11152         * tracefile-tfile.c (tfile_write_uploaded_tp):
11153         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11154         gdb::unique_xmalloc_ptr.
11155         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11156         at_string, cond_string, cmd_strings>: Replace char pointers
11157         with gdb::unique_xmalloc_ptr.
11158
11159 2019-01-10  Pedro Alves  <palves@redhat.com>
11160
11161         * solib-target.c (library_list_start_library): Don't xstrdup name.
11162
11163 2019-01-10  Pedro Alves  <palves@redhat.com>
11164
11165         * mdebugread.c (parse_partial_symbols): Use
11166         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11167
11168 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11169
11170         * linux-fork.c (scoped_switch_fork_info)
11171         <~scoped_switch_fork_info>: Fix incorrect variable name.
11172
11173 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11174
11175         * linux-fork.c (scoped_switch_fork_info)
11176         <scoped_switch_fork_info>: Make explicit.
11177         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11178
11179 2019-01-10  Tom Tromey  <tom@tromey.com>
11180
11181         * objfiles.h (objfile::reset_psymtabs): Update.
11182         * objfiles.c (objfile::objfile): Update.
11183         * psymtab.h (psymtab_storage::obstack): Update.
11184         (psymtab_storage::m_obstack): Use gdb::optional.
11185         (class psymtab_storage): Update comment.  Remove objfile
11186         parameter.
11187         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11188
11189 2019-01-10  Tom Tromey  <tom@tromey.com>
11190
11191         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11192         <free_psymtabs>: Now private.
11193         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11194         (allocate_psymtab): Use new method.
11195
11196 2019-01-10  Tom Tromey  <tom@tromey.com>
11197
11198         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11199         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11200         * mdebugread.c (parse_partial_symbols): Use
11201         allocate_dependencies.
11202         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11203         allocate_dependencies.
11204         (process_psymtab_comp_unit_reader)
11205         (build_type_psymtab_dependencies): Likewise.
11206         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11207
11208 2019-01-10  Tom Tromey  <tom@tromey.com>
11209
11210         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11211         PSYMBOL_SET_LANGUAGE.
11212         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11213
11214 2019-01-10  Tom Tromey  <tom@tromey.com>
11215
11216         * psymtab.h (psymtab_storage::obstack): New method.
11217         <m_obstack>: Rename from obstack; now private.
11218         * psymtab.c (psymtab_storage): Update.
11219         * dwarf2read.c (create_addrmap_from_index)
11220         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11221         Update.
11222
11223 2019-01-10  Tom Tromey  <tom@tromey.com>
11224
11225         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11226         * objfiles.h (objfile::reset_psymtabs): New method.
11227
11228 2019-01-10  Tom Tromey  <tom@tromey.com>
11229
11230         * symmisc.c (print_symbol_bcache_statistics): Update.
11231         (print_objfile_statistics): Update.
11232         * symfile.c (reread_symbols): Update.
11233         * psymtab.h (class psymtab_storage): New.
11234         * psymtab.c (psymtab_storage): New constructor.
11235         (~psymtab_storage): New destructor.
11236         (require_partial_symbols): Update.
11237         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11238         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11239         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11240         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11241         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11242         (start_psymtab_common, end_psymtab_common)
11243         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11244         (allocate_psymtab): Update.
11245         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11246         Update.
11247         (dump_psymtab_addrmap, maintenance_print_psymbols)
11248         (maintenance_check_psymtabs): Update.
11249         (class objfile_psymtabs): Move to objfiles.h.
11250         * psympriv.h (discard_psymtab): Now inline.
11251         (psymtab_discarder::psymtab_discarder): Update.
11252         (psymtab_discarder::~psymtab_discarder): Update.
11253         (ALL_OBJFILE_PSYMTABS): Rewrite.
11254         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11255         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11256         Remove fields.
11257         <partial_symtabs>: New field.
11258         (class objfile_psymtabs): Move from psymtab.h.  Update.
11259         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11260         psymbol_cache.
11261         (objfile::~objfile): Don't destroy psymbol_cache.
11262         * mdebugread.c (parse_partial_symbols): Update.
11263         * dwarf2read.c (create_addrmap_from_index)
11264         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11265         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11266         (add_partial_subprogram, dwarf2_ranges_read): Update.
11267         * dwarf-index-write.c (write_address_map)
11268         (write_one_signatured_type, recursively_write_psymbols)
11269         (class debug_names, class debug_names, write_psymtabs_to_index):
11270         Update.
11271
11272 2019-01-10  Tom Tromey  <tom@tromey.com>
11273
11274         * symtab.h (SYMBOL_SET_NAMES): Update.
11275         (symbol_set_names): Update.
11276         (MSYMBOL_SET_NAMES): Update.
11277         * symtab.c (symbol_set_names): Change argument to be an
11278         objfile_per_bfd_storage.
11279         * psymtab.c (add_psymbol_to_bcache): Update.
11280         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11281
11282 2019-01-10  Tom Tromey  <tom@tromey.com>
11283
11284         * symtab.c (create_demangled_names_hash): Change argument to be an
11285         objfile_per_bfd_storage.
11286         (symbol_set_names): Update.
11287
11288 2019-01-10  Tom Tromey  <tom@tromey.com>
11289
11290         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11291         init_psymbol_list.
11292         * psymtab.c (init_psymbol_list): Do nothing if already called.
11293         * psympriv.h (init_psymbol_list): Add comment.
11294         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11295         init_psymbol_list.
11296         * dbxread.c (dbx_symfile_read): Unconditionally call
11297         init_psymbol_list.
11298
11299 2019-01-10  Tom Tromey  <tom@tromey.com>
11300
11301         * xcoffread.c (scan_xcoff_symtab): Update.
11302         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11303         "where".
11304         * mdebugread.c (parse_partial_symbols)
11305         (handle_psymbol_enumerators): Update.
11306         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11307         * dbxread.c (read_dbx_symtab): Update.
11308         * psympriv.h (psymbol_placement): New enum.
11309         (add_psymbol_to_list): Update.
11310
11311 2019-01-10  Tom Tromey  <tom@tromey.com>
11312
11313         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11314         static_psymbols parameters.
11315         (scan_xcoff_symtab): Update.
11316         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11317         static_psymbols parameters.
11318         * psympriv.h (start_psymtab_common): Update.
11319         * mdebugread.c (parse_partial_symbols): Update.
11320         * dwarf2read.c (create_partial_symtab): Update.
11321         * dbxread.c (read_dbx_symtab): Update.
11322         (start_psymtab): Remove global_psymbols and static_psymbols
11323         parameters.
11324
11325 2019-01-10  Tom Tromey  <tom@tromey.com>
11326
11327         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11328         * psymtab.c (allocate_psymtab): Add comment.
11329         * psympriv.h (allocate_psymtab): Add comment.
11330         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11331         initializations.
11332         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11333
11334 2019-01-10  Tom Tromey  <tom@tromey.com>
11335
11336         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11337         Don't declare.
11338         * mipsread.c: Include mdebugread.h.
11339         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11340         Declare.
11341         * elfread.c: Include mdebugread.h.
11342
11343 2019-01-09  Tom Tromey  <tom@tromey.com>
11344
11345         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11346         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11347         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11348         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11349         (psym_lookup_symbol, psym_find_last_source_symtab)
11350         (psym_forget_cached_source_info, psym_print_stats)
11351         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11352         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11353         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11354         (psym_find_compunit_symtab_by_address)
11355         (maintenance_print_psymbols, maintenance_info_psymtabs)
11356         (maintenance_check_psymtabs): Use ranged for.
11357         * psymtab.h (class objfile_psymtabs): New.
11358         (require_partial_symbols): Return objfile_psymtabs.
11359         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11360
11361 2019-01-09  Tom Tromey  <tom@tromey.com>
11362
11363         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11364         (find_pc_mapped_section, list_overlays_command)
11365         (map_overlay_command, unmap_overlay_command)
11366         (simple_overlay_update): Use all_objfiles.
11367         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11368         * printcmd.c (info_symbol_command): Use all_objfiles.
11369         * objfiles.h (ALL_OBJSECTIONS): Remove.
11370         * maint.c (maintenance_translate_address): Use all_objfiles.
11371         * gcore.c (gcore_create_callback): Use all_objfiles.
11372         (objfile_find_memory_regions): Likewise.
11373
11374 2019-01-09  Tom Tromey  <tom@tromey.com>
11375
11376         * symtab.c (find_line_symtab, info_sources_command)
11377         (make_source_files_completion_list): Use objfile_compunits.
11378         * source.c (select_source_symtab): Use objfile_compunits.
11379         * objfiles.h (struct objfile): Update comment.
11380         (ALL_OBJFILES): Remove.
11381         (ALL_FILETABS): Remove.
11382         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11383         objfile_compunits.
11384
11385 2019-01-09  Tom Tromey  <tom@tromey.com>
11386
11387         * symmisc.c (print_objfile_statistics, dump_objfile)
11388         (maintenance_print_symbols): Use compunit_filetabs.
11389         * source.c (forget_cached_source_info_for_objfile): Use
11390         compunit_filetabs.
11391         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11392         (ALL_FILETABS): Use compunit_filetabs.
11393         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11394         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11395
11396 2019-01-09  Tom Tromey  <tom@tromey.com>
11397
11398         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11399         (compunit_filetabs): New.
11400         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11401         compunit_filetabs.
11402         (info_sources_command, make_source_files_completion_list): Remove
11403         declaration.
11404         * symmisc.c (print_objfile_statistics, dump_objfile)
11405         (maintenance_print_symbols): Remove declaration.
11406         (maintenance_info_symtabs): Use compunit_filetabs.
11407         (maintenance_info_line_tables): Likewise.
11408         * source.c (select_source_symtab): Change local variable name.
11409         (forget_cached_source_info_for_objfile): Remove declaration.
11410         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11411         * objfiles.c (objfile_relocate1): Remove declaration.
11412         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11413         declaration.
11414         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11415         * coffread.c (coff_symtab_read): Remove declaration.
11416         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11417         compunit_filetabs.
11418
11419 2019-01-09  Tom Tromey  <tom@tromey.com>
11420
11421         * symtab.c (lookup_objfile_from_block)
11422         (find_pc_sect_compunit_symtab, search_symbols)
11423         (default_collect_symbol_completion_matches_break_on): Use
11424         objfile_compunits.
11425         * objfiles.h (ALL_COMPUNITS): Remove.
11426         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11427         * cp-support.c (add_symbol_overload_list_qualified): Use
11428         objfile_compunits.
11429         * ada-lang.c (ada_collect_symbol_completion_matches)
11430         (ada_add_global_exceptions): Use objfile_compunits.
11431
11432 2019-01-09  Tom Tromey  <tom@tromey.com>
11433
11434         * source.c (select_source_symtab)
11435         (forget_cached_source_info_for_objfile): Remove declaration.
11436         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11437         declaration.
11438         * maint.c (count_symtabs_and_blocks): Remove declaration.
11439         * cp-support.c (add_symbol_overload_list_qualified): Remove
11440         declaration.
11441         * coffread.c (coff_symtab_read): Remove declaration.
11442         * symtab.c (lookup_symbol_in_objfile_symtabs)
11443         (basic_lookup_transparent_type_1): Use objfile_compunits.
11444         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11445         (info_sources_command, search_symbols)
11446         (default_collect_symbol_completion_matches_break_on)
11447         (make_source_files_completion_list): Remove declaration.
11448         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11449         (ada_collect_symbol_completion_matches)
11450         (ada_add_global_exceptions): Remove declaration.
11451         * linespec.c (iterate_over_all_matching_symtabs): Use
11452         objfile_compunits.
11453         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11454         (class objfile_compunits): New.
11455         (ALL_COMPUNITS): Use objfile_compunits.
11456         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11457         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11458         objfile_compunits.
11459         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11460
11461 2019-01-09  Tom Tromey  <tom@tromey.com>
11462
11463         * symtab.c (search_symbols)
11464         (default_collect_symbol_completion_matches_break_on): Use
11465         objfile_msymbols.
11466         * ada-lang.c (ada_lookup_simple_minsym)
11467         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11468         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11469         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11470         objfile_msymbols.
11471         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11472         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11473         * objc-lang.c (find_methods): Use objfile_msymbols.
11474         (info_selectors_command, info_classes_command): Likewise.
11475         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11476         * objfiles.h (class objfile_msymbols): New.
11477         (ALL_OBJFILE_MSYMBOLS): Remove.
11478         (ALL_MSYMBOLS): Remove.
11479
11480 2019-01-09  Tom Tromey  <tom@tromey.com>
11481
11482         * common/next-iterator.h (next_adapter): Add Iterator template
11483         parameter.
11484         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11485         (class all_objfiles_safe): New.
11486         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11487         * objfiles.c (put_objfile_before): Update comment.
11488         (add_separate_debug_objfile): Likewise.
11489         (free_all_objfiles): Use all_objfiles_safe.
11490         (objfile_purge_solibs): Likewise.
11491
11492 2019-01-09  Tom Tromey  <tom@tromey.com>
11493
11494         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11495         (expand_symtab_containing_pc, lookup_static_symbol)
11496         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11497         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11498         all_objfiles.
11499         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11500         * breakpoint.c (create_overlay_event_breakpoint)
11501         (create_longjmp_master_breakpoint)
11502         (create_std_terminate_master_breakpoint)
11503         (create_exception_master_breakpoint): Use all_objfiles.
11504         * linux-thread-db.c (try_thread_db_load_from_pdir)
11505         (has_libpthread): Use all_objfiles.
11506         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11507         * linespec.c (iterate_over_all_matching_symtabs)
11508         (search_minsyms_for_name): Use all_objfiles.
11509         * maint.c (maintenance_info_sections): Use all_objfiles.
11510         * main.c (captured_main_1): Use all_objfiles.
11511         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11512         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11513         * guile/scm-pretty-print.c
11514         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11515         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11516         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11517         (maintenance_print_msymbols): Use all_objfiles.
11518         * source.c (select_source_symtab): Use all_objfiles.
11519         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11520         * symfile.c (remove_symbol_file_command)
11521         (expand_symtabs_matching, map_symbol_filenames): Use
11522         all_objfiles.
11523         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11524         all_objfiles.
11525         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11526         * objc-lang.c (find_methods): Use all_objfiles.
11527         * objfiles.c (have_partial_symbols, have_full_symbols)
11528         (have_minimal_symbols, qsort_cmp)
11529         (default_iterate_over_objfiles_in_search_order): Use
11530         all_objfiles.
11531         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11532         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11533         (maintenance_check_psymtabs): Use all_objfiles.
11534         (ALL_PSYMTABS): Remove.
11535         * compile/compile-object-run.c (do_module_cleanup): Use
11536         all_objfiles.
11537         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11538         * cp-support.c (add_symbol_overload_list_qualified): Use
11539         all_objfiles.
11540         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11541         Use all_objfiles.
11542         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11543         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11544         all_objfiles.
11545         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11546         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11547         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11548         Uses all_objfiles.
11549         * solib.c (solib_read_symbols): Use all_objfiles
11550
11551 2019-01-09  Tom Tromey  <tom@tromey.com>
11552
11553         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11554         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11555         all_objfiles.
11556         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11557         * symmisc.c (print_symbol_bcache_statistics)
11558         (print_objfile_statistics, maintenance_print_objfiles)
11559         (maintenance_info_symtabs, maintenance_check_symtabs)
11560         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11561         all_objfiles.
11562         * source.c (forget_cached_source_info): Use all_objfiles.
11563         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11564         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11565         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11566         * objfiles.c (update_section_map): Use all_objfiles.
11567         (shared_objfile_contains_address_p): Likewise.
11568         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11569         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11570
11571 2019-01-09  Tom Tromey  <tom@tromey.com>
11572
11573         * common/next-iterator.h: New file.
11574         * objfiles.h (class all_objfiles): New.
11575         (struct objfile_iterator): New.
11576
11577 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11578
11579         * NEWS: Move the description of the changed "frame", "select-frame",
11580          and "info frame" commands to the Changed commands section.
11581
11582 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11583
11584         * gdbtypes.c (check_stub_method_group): Remove handling of old
11585         mangling schemes.
11586         * linespec.c (find_methods): Likewise.
11587         * stabsread.c (read_member_functions): Likewise.
11588         * valops.c (search_struct_method): Likewise.
11589         (value_struct_elt_for_reference): Likewise.
11590         * NEWS: Mention this change.
11591
11592 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11593
11594         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11595         print_source_lines.
11596         * source.c (print_source_lines_base): Update line number check.
11597         (print_source_lines): New function.
11598         (source_lines_range::source_lines_range): New function.
11599         * source.h (class source_lines_range): New class.
11600         (print_source_lines): New declaration.
11601
11602 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11603
11604         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11605
11606 2019-01-08  Tom Tromey  <tom@tromey.com>
11607             Simon Marchi  <simon.marchi@ericsson.com>
11608
11609         PR gdb/24060
11610         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11611         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11612         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11613         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11614         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11615         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11616
11617 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11618
11619         * source.c (select_source_symtab): Move header comment to
11620         declaration in source.h.
11621         (forget_cached_source_info_for_objfile): Likewise.
11622         (forget_cached_source_info): Likewise.
11623         (identify_source_line): Likewise.
11624         * source.h (identify_source_line): Move declaration from symtab.h
11625         and add comment from source.c
11626         (print_source_lines): Likewise.
11627         (forget_cached_source_info_for_objfile): Likewise.
11628         (forget_cached_source_info): Likewise.
11629         (select_source_symtab): Likewise.
11630         (enum print_source_lines_flag): Move definition from symtab.h.
11631         * symtab.h (identify_source_line): Move declaration to source.h.
11632         (print_source_lines): Likewise.
11633         (forget_cached_source_info_for_objfile): Likewise.
11634         (forget_cached_source_info): Likewise.
11635         (select_source_symtab): Likewise.
11636         (enum print_source_lines_flag): Move definition to source.h.
11637         * tui/tui-hooks.c: Add 'source.h' include.
11638
11639 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11640
11641         * source.c (print_source_lines_base): Handle requests to print
11642         reverse line number sequences, and guard against empty lines
11643         string.
11644
11645 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11646
11647         * source.c (print_source_lines_base): Fix skip of '\r' if next
11648         character is '\n'.
11649
11650 2019-01-06  Tom Tromey  <tom@tromey.com>
11651
11652         * c-exp.y (struct c_parse_state) <macro_original_text,
11653         expansion_obstack>: New member.
11654         (macro_original_text, expansion_obstack): Remove globals.
11655         (scan_macro_expansion, scanning_macro_expansion)
11656         (finished_macro_expansion): Update.
11657         (scan_macro_cleanup): Remove.
11658         (yylex, c_parse): Update.
11659
11660 2019-01-06  Tom Tromey  <tom@tromey.com>
11661
11662         * c-exp.y (struct c_parse_state) <strings>: New member.
11663         (operator_stoken): Update.
11664
11665 2019-01-06  Tom Tromey  <tom@tromey.com>
11666
11667         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11668         (union type_stack_elt) <typelist_val>: Now a pointer to
11669         std::vector.
11670         (type_stack_cleanup): Don't declare.
11671         (push_typelist): Update.
11672         * parse.c (pop_typelist): Return a std::vector.
11673         (push_typelist): Take a std::vector.
11674         (follow_types): Update.  Do not free args.
11675         (type_stack_cleanup): Remove.
11676         * c-exp.y (struct c_parse_state): New.
11677         (cpstate): New global.
11678         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11679         (nonempty_typelist): Update.
11680         (func_mod): Create a new vector.
11681         (c_parse): Create a c_parse_state.
11682         (check_parameter_typelist): Do not delete params.
11683         (function_method): Update.  Do not delete type_list.
11684
11685 2019-01-06  Tom Tromey  <tom@tromey.com>
11686
11687         PR gdb/28155:
11688         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11689         check_typedef.
11690         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11691         (print_return_value): Likewise.
11692
11693 2019-01-05  Tom Tromey  <tom@tromey.com>
11694
11695         * contrib/cleanup_check.py: Remove.
11696         * contrib/gcc-with-excheck: Remove.
11697         * contrib/exsummary.py: Remove.
11698         * contrib/excheck.py: Remove.
11699
11700 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11701
11702         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11703         NULL. Initialize tpprev to NULL instead of assigning it
11704         to NULL on the next statement.
11705         * windows-nat.c (windows_delete_thread): Remove check for
11706         main_thread_id before printing thread exit notifications.
11707         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11708         Remove thread ID check against main_thread_id.
11709         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11710         windows_delete_thread.
11711         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11712
11713 2019-01-04  Tom Tromey  <tom@tromey.com>
11714
11715         * compile/compile.c (_initialize_compile): Use upper case for
11716         metasyntactic variables.
11717         * symmisc.c (_initialize_symmisc): Use upper case for
11718         metasyntactic variables.
11719         * psymtab.c (_initialize_psymtab): Use upper case for
11720         metasyntactic variables.
11721         * demangle.c (demangle_command): Use upper case for metasyntactic
11722         variables.
11723         (_initialize_demangler): Likewise.
11724         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11725         variables.
11726
11727 2019-01-03  Tom Tromey  <tom@tromey.com>
11728
11729         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11730
11731 2019-01-03  Tom Tromey  <tom@tromey.com>
11732
11733         * python/py-symtab.c (salpy_str): Update.
11734         (struct salpy_sal_object) <symtab>: Now a PyObject.
11735         (salpy_dealloc): Update.
11736         (del_objfile_sal): Use gdbpy_ref.
11737
11738 2019-01-03  Tom Tromey  <tom@tromey.com>
11739
11740         * python/py-type.c (convert_field): Use new_reference.  Return
11741         gdbpy_ref.
11742         (make_fielditem): Return gdbpy_ref.
11743         (typy_fields): Update.
11744         (typy_getitem): Update.
11745         (field_name): Return gdbpy_ref.  Use new_reference.
11746         (typy_iterator_iternext): Update.
11747
11748 2019-01-03  Tom Tromey  <tom@tromey.com>
11749
11750         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11751
11752 2019-01-03  Tom Tromey  <tom@tromey.com>
11753
11754         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11755         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11756         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11757         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11758         (pspy_set_type_printers): Likewise.
11759         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11760         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11761         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11762         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11763         (objfpy_set_type_printers): Likewise.
11764
11765 2019-01-03  Tom Tromey  <tom@tromey.com>
11766
11767         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11768         (gdbpy_print_stack): Use gdbpy_err_fetch.
11769         * python/python-internal.h (class gdbpy_err_fetch): New class.
11770         (class gdbpy_enter) <m_error_type, m_error_value,
11771         m_error_traceback>: Remove.
11772         <m_error>: New member.
11773         (gdbpy_exception_to_string): Don't declare.
11774         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11775         * python/py-value.c (convert_value_from_python): Use
11776         gdbpy_err_fetch.
11777         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11778         gdbpy_exception_to_string.
11779         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11780         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11781         gdbpy_err_fetch.
11782
11783 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11784
11785         * linux-nat.c (delete_lwp_cleanup): Delete.
11786         (struct lwp_deleter): New struct.
11787         (lwp_info_up): New typedef.
11788         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11789         lwp_info_up.
11790
11791 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11792
11793         * linux-fork.c (class scoped_switch_fork_info): New class.
11794         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11795
11796 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11797
11798         * valops.c (find_overload_match): Remove use of null_cleanup, and
11799         calls to do_cleanups.
11800
11801 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11802
11803         * compile/compile-cplus-types.c
11804         (compile_cplus_instance::decl_name): Handle changes to
11805         cp_func_name.
11806         * cp-support.c (cp_func_name): Update header comment, update
11807         return type.
11808         * cp-support.h (cp_func_name): Update return type in declaration.
11809         * valops.c (find_overload_match): Move temp_func local to top
11810         level of function and change its type.  Use temp_func to hold and
11811         delete temporary string obtained from cp_func_name.
11812
11813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11814
11815         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11816         gdb::char_vector, remove cleanup, and update uses of `msg`.
11817
11818 2019-01-03  Jim Wilson  <jimw@sifive.com>
11819
11820         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11821
11822 2019-01-02  Tom Tromey  <tom@tromey.com>
11823
11824         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11825         (tdesc_parse_xml): Remove cleanups.
11826         * target-descriptions.h (make_cleanup_free_target_description):
11827         Don't declare.
11828         (target_desc_deleter): New struct.
11829         (target_desc_up): New typedef.
11830         * target-descriptions.c (target_desc_deleter::operator()): Rename
11831         from free_target_description.
11832         (make_cleanup_free_target_description): Remove.
11833
11834 2019-01-02  Tom Tromey  <tom@tromey.com>
11835
11836         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11837         constructor, destructor.
11838         (linespec_parser): Remove typedef.
11839         (~linespec_parser): Rename from linespec_parser_delete.
11840         (linespec_lex_to_end, linespec_complete_label)
11841         (linespec_complete): Update.
11842         (decode_line_full): Remove cleanups.
11843         (decode_line_1): Update.
11844
11845 2019-01-02  Tom Tromey  <tom@tromey.com>
11846
11847         * python/python-internal.h (inferior_to_inferior_object): Change
11848         return type.
11849         * python/py-exitedevent.c (create_exited_event_object): Update.
11850         * python/py-inferior.c (inferior_to_inferior_object): Return
11851         gdbpy_ref.
11852         (python_new_inferior, python_inferior_deleted)
11853         (thread_to_thread_object, delete_thread_object)
11854         (build_inferior_list, gdbpy_selected_inferior): Update.
11855         * python/py-infthread.c (create_thread_object): Update.  Also fail
11856         if inferior_to_inferior_object fails.
11857
11858 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11859
11860         * inferior.h (class inferior) <displaced_step_state>: New field.
11861         * infrun.h (struct displaced_step_state): Move here from
11862         infrun.c.  Initialize fields, add constructor.
11863         <inf>: Remove field.
11864         <reset>: New method.
11865         * infrun.c (struct displaced_step_inferior_state): Move to
11866         infrun.h.
11867         (displaced_step_inferior_states): Remove.
11868         (get_displaced_stepping_state): Adust.
11869         (displaced_step_in_progress_any_inferior): Adjust.
11870         (displaced_step_in_progress_thread): Adjust.
11871         (displaced_step_in_progress): Adjust.
11872         (add_displaced_stepping_state): Remove.
11873         (get_displaced_step_closure_by_addr): Adjust.
11874         (remove_displaced_stepping_state): Remove.
11875         (infrun_inferior_exit): Call displaced_step_state.reset.
11876         (use_displaced_stepping): Don't check for NULL.
11877         (displaced_step_prepare_throw): Call
11878         get_displaced_stepping_state.
11879         (displaced_step_fixup): Don't check for NULL.
11880         (prepare_for_detach): Don't check for NULL.
11881
11882 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11883
11884         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11885          in case of call that did not complete.
11886
11887 2019-01-02  Andrey Utkin  <autkin@undo.io>
11888
11889         * symfile.c (find_separate_debug_file): Fix search of debug files for
11890         remote debuggee.
11891
11892 2019-01-02  Tom Tromey  <tom@tromey.com>
11893
11894         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11895         indentation.
11896         * python/py-frame.c (frapy_older): Remove cast.
11897         (frapy_newer): Likewise.
11898         * python/py-breakpoint.c (local_setattro): Remove cast.
11899         * python/py-arch.c (archpy_name): Remove local variable.
11900         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11901
11902 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11903
11904         * unittests/basic_string_view/element_access/char/empty.cc:
11905         Fix year range in copyright header.
11906
11907 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11908
11909         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11910         Delete.
11911         <operator==>: Update with for removed field.
11912         <hash>: Likewise.
11913         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11914         <isa_features>: ...this.
11915         <abi_features>: New field.
11916         (riscv_isa_flen): Update comment.
11917         (riscv_abi_xlen): New declaration.
11918         (riscv_abi_flen): New declaration.
11919         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11920         isa_features.
11921         (riscv_abi_xlen): New function.
11922         (riscv_isa_flen): Update to get answer from isa_features.
11923         (riscv_abi_flen): New function.
11924         (riscv_has_fp_abi): Update to get answer from abi_features.
11925         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11926         xlen and flen.
11927         (riscv_call_info) <xlen, flen>: Update comment.
11928         (riscv_call_arg_struct): Remove invalid assertions
11929         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11930         is removed.
11931         (riscv_gdbarch_init): Gather isa features and abi features
11932         separately, ensure both match on the gdbarch when reusing an old
11933         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11934         a target with 64-bit float hardware.
11935
11936 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11937
11938         * source.c (search_command_helper): Stop reverse search
11939         when line 1 has been searched.
11940
11941 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11942
11943         * record-full.c (record_full_base_target::close): Rewrite
11944         record_full_core_buf_list free logic.
11945
11946 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11947
11948         * break-catch-syscall.c (print_one_catch_syscall): xfree
11949         the last text.
11950
11951 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11952
11953         * top.c (print_gdb_version): Update Copyright year in version
11954         message.
11955
11956 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11957
11958         Update copyright year range in all GDB files.
11959
11960 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11961
11962         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11963
11964 For older changes see ChangeLog-2018.
11965 \f
11966 Local Variables:
11967 mode: change-log
11968 left-margin: 8
11969 fill-column: 74
11970 version-control: never
11971 coding: utf-8
11972 End:
11973