gdb/ChangeLog

   1 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * regformats/reg-arm.dat: Remove.
   4         * regformats/reg-bfin.dat: Remove.
   5         * regformats/reg-cris.dat: Remove.
   6         * regformats/reg-crisv32.dat: Remove.
   7         * regformats/reg-m32r.dat: Remove.
   8         * regformats/reg-tilegx.dat: Remove.
   9         * regformats/reg-tilegx32.dat: Remove.
  10
  11 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
  12
  13         * features/Makefile (WHICH): Remove arm files.
  14         * regformats/arm/arm-with-iwmmxt.dat: Remove.
  15         * regformats/arm/arm-with-neon.dat: Remove.
  16         * regformats/arm/arm-with-vfpv2.dat: Remove.
  17         * regformats/arm/arm-with-vfpv3.dat: Remove.
  18
  19 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
  20
  21         * features/Makefile (XMLTOC): Remove rx.xml.
  22
  23 2020-06-17  Pedro Alves  <palves@redhat.com>
  24
  25         * gdbthread.h (thread_control_state) <trap_expected> Update
  26         comments.
  27
  28 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
  31         ada_language::lookup_symbol_nonlocal.
  32         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
  33         (ada_language::lookup_symbol_nonlocal): New member function,
  34         implementation from ada_lookup_symbol_nonlocal.
  35         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
  36         initializer.
  37         (cplus_language_data): Delete la_lookup_symbol_nonlocal
  38         initializer.
  39         (cplus_language::lookup_symbol_nonlocal): New member function.
  40         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
  41         (minimal_language_data) Likewise.
  42         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
  43         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
  44         initializer.
  45         (d_language::lookup_symbol_nonlocal): New member function.
  46         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
  47         initializer.
  48         (f_language::lookup_symbol_nonlocal): New member function.
  49         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
  50         initializer.
  51         * language.c (unknown_language_data): Likewise.
  52         (auto_language_data): Likewise.
  53         * language.h (language_data): Delete la_lookup_symbol_nonlocal
  54         field.
  55         (language_defn::lookup_symbol_nonlocal): New member function.
  56         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
  57         initializer.
  58         * objc-lang.c (objc_language_data): Likewise.
  59         * opencl-lang.c (opencl_language_data): Likewise.
  60         * p-lang.c (pascal_language_data): Likewise.
  61         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
  62         rust_language::lookup_symbol_nonlocal.
  63         (rust_language_data): Delete la_lookup_symbol_nonlocal
  64         initializer.
  65         (rust_language::lookup_symbol_nonlocal): New member function,
  66         implementation from rust_lookup_symbol_nonlocal.
  67         * symtab.c (lookup_symbol_aux): Update call to
  68         lookup_symbol_nonlocal.
  69         (basic_lookup_symbol_nonlocal): Rename to...
  70         (language_defn::lookup_symbol_nonlocal): ...this, and update
  71         header comment.  Remove language_defn parameter, and replace with
  72         uses of `this'.
  73         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
  74
  75 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  76
  77         * ada-lang.c (ada_language_data): Delete la_value_print_inner
  78         initializer.
  79         (ada_language::value_print_inner): New member function.
  80         * c-lang.c (c_language_data): Delete la_value_print_inner
  81         initializer.
  82         (cplus_language_data): Likewise.
  83         (asm_language_data): Likewise.
  84         (minimal_language_data): Likewise.
  85         * d-lang.c (d_language_data): Likewise.
  86         (d_language::value_print_inner): New member function.
  87         * f-lang.c (f_language_data): Delete la_value_print_inner
  88         initializer.
  89         (f_language::value_print_inner): New member function.
  90         * f-lang.h (f_value_print_innner): Rename to...
  91         (f_value_print_inner): ...this (note spelling of 'inner').
  92         * f-valprint.c (f_value_print_innner): Rename to...
  93         (f_value_print_inner): ...this (note spelling of 'inner').
  94         * go-lang.c (go_language_data): Delete la_value_print_inner
  95         initializer.
  96         (go_language::value_print_inner): New member function.
  97         * language.c (language_defn::value_print_inner): Define new member
  98         function.
  99         (unk_lang_value_print_inner): Delete.
 100         (unknown_language_data): Delete la_value_print_inner initializer.
 101         (unknown_language::value_print_inner): New member function.
 102         (auto_language_data): Delete la_value_print_inner initializer.
 103         (auto_language::value_print_inner): New member function.
 104         * language.h (language_data): Delete la_value_print_inner field.
 105         (language_defn::value_print_inner): Delcare new member function.
 106         * m2-lang.c (m2_language_data): Delete la_value_print_inner
 107         initializer.
 108         (m2_language::value_print_inner): New member function.
 109         * objc-lang.c (objc_language_data): Delete la_value_print_inner
 110         initializer.
 111         * opencl-lang.c (opencl_language_data): Likewise.
 112         * p-lang.c (pascal_language_data): Likewise.
 113         (pascal_language::value_print_inner): New member function.
 114         * rust-lang.c (rust_language_data): Delete la_value_print_inner
 115         initializer.
 116         (rust_language::value_print_inner): New member function.
 117         * valprint.c (do_val_print): Update call to value_print_inner.
 118
 119 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 120
 121         * ada-lang.c (ada_language_data): Delete la_value_print
 122         initializer.
 123         (ada_language::value_print): New member function.
 124         * c-lang.c (c_language_data): Delete la_value_print initializer.
 125         (cplus_language_data): Likewise.
 126         (asm_language_data): Likewise.
 127         (minimal_language_data): Likewise.
 128         * d-lang.c (d_language_data): Likewise.
 129         * f-lang.c (f_language_data): Likewise.
 130         * go-lang.c (go_language_data): Likewise.
 131         * language.c (unk_lang_value_print): Delete.
 132         (language_defn::value_print): Define new member function.
 133         (unknown_language_data): Delete la_value_print initializer.
 134         (unknown_language::value_print): New member function.
 135         (auto_language_data): Delete la_value_print initializer.
 136         (auto_language::value_print): New member function.
 137         * language.h (language_data): Delete la_value_print field.
 138         (language_defn::value_print): Declare new member function.
 139         (LA_VALUE_PRINT): Update call to value_print.
 140         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
 141         * objc-lang.c (objc_language_data): Likewise.
 142         * opencl-lang.c (opencl_language_data): Likewise.
 143         * p-lang.c (pascal_language_data): Likewise.
 144         (pascal_language::value_print): New member function.
 145         * rust-lang.c (rust_language_data): Delete la_value_print
 146         initializer.
 147
 148 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * ada-lang.c (ada_watch_location_expression): Rename to
 151         ada_language::watch_location_expression.
 152         (ada_language_data): Delete la_watch_location_expression
 153         initializer.
 154         (ada_language::watch_location_expression): New member function,
 155         implementation from ada_watch_location_expression.
 156         * breakpoint.c (watch_command_1): Update call to
 157         watch_location_expression.
 158         * c-lang.c (c_watch_location_expression): Rename to
 159         language_defn::watch_location_expression.
 160         (c_language_data): Delete la_watch_location_expression
 161         initializer.
 162         (cplus_language_data): Likewise.
 163         (asm_language_data): Likewise.
 164         (minimal_language_data): Likewise.
 165         * c-lang.h (c_watch_location_expression): Delete declaration.
 166         * d-lang.c (d_language_data): Delete la_watch_location_expression
 167         initializer.
 168         * f-lang.c (f_language_data): Likewise.
 169         * go-lang.c (go_language_data): Likewise.
 170         * language.c (language_defn::watch_location_expression): Member
 171         function implementation from c_watch_location_expression.
 172         (unknown_language_data): Delete la_watch_location_expression
 173         initializer.
 174         (auto_language_data): Likewise.
 175         * language.h (language_data): Delete la_watch_location_expression
 176         field.
 177         (language_defn::watch_location_expression): Declare new member
 178         function.
 179         * m2-lang.c (m2_language_data): Delete
 180         la_watch_location_expression initializer.
 181         * objc-lang.c (objc_language_data): Likewise.
 182         * opencl-lang.c (opencl_language_data): Likewise.
 183         * p-lang.c (pascal_language_data): Likewise.
 184         * rust-lang.c (rust_watch_location_expression): Rename to
 185         rust_language::watch_location_expression.
 186         (rust_language_data): Delete la_watch_location_expression
 187         initializer.
 188         (rust_language::watch_location_expression): New member function,
 189         implementation from rust_watch_location_expression.
 190
 191 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 192
 193         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
 194         ada_language::collect_symbol_completion_matches.
 195         (ada_language_data): Delete la_collect_symbol_completion_matches
 196         initializer.
 197         (ada_language::collect_symbol_completion_matches): New member
 198         function, implementation from
 199         ada_collect_symbol_completion_matches.
 200         * c-lang.c (c_language_data): Delete
 201         la_collect_symbol_completion_matches initializer.
 202         (cplus_language_data): Likewise.
 203         (asm_language_data): Likewise.
 204         (minimal_language_data): Likewise.
 205         * d-lang.c (d_language_data): Likewise.
 206         * f-lang.c (f_collect_symbol_completion_matches): Rename to
 207         f_language::collect_symbol_completion_matches.
 208         (f_language_data): Delete la_collect_symbol_completion_matches
 209         initializer.
 210         (f_language::collect_symbol_completion_matches) New member
 211         function, implementation from f_collect_symbol_completion_matches.
 212         * go-lang.c (go_language_data): Delete
 213         la_collect_symbol_completion_matches initializer.
 214         * language.c (unknown_language_data): Likewise.
 215         (auto_language_data): Likewise.
 216         * language.h (language_data): Delete
 217         la_collect_symbol_completion_matches field.
 218         (language_defn::collect_symbol_completion_matches): New member
 219         function.
 220         * m2-lang.c (m2_language_data): Delete
 221         la_collect_symbol_completion_matches initializer.
 222         * objc-lang.c (objc_language_data): Likewise.
 223         * opencl-lang.c (opencl_language_data): Likewise.
 224         * p-lang.c (pascal_language_data): Likewise.
 225         * rust-lang.c (rust_language_data): Likewise.
 226         * symtab.c (default_collect_symbol_completion_matches): Delete.
 227         (collect_symbol_completion_matches): Update call to
 228         collect_symbol_completion_matches.
 229         (collect_symbol_completion_matches_type): Likewise.
 230         * symtab.h (default_collect_symbol_completion_matches): Delete
 231         declaration.
 232
 233 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
 236         (ada_language_data): Delete la_word_break_characters initializer.
 237         (ada_language::word_break_characters): New member function.
 238         * c-lang.c (c_language_data): Delete la_word_break_characters
 239         initializer.
 240         (cplus_language_data): Likewise.
 241         (asm_language_data): Likewise.
 242         (minimal_language_data): Likewise.
 243         * completer.c: Update global comment.
 244         (advance_to_expression_complete_word_point): Update call to
 245         word_break_characters.
 246         (complete_files_symbols): Likewise.
 247         (complete_line_internal_1): Likewise.
 248         (default_completer_handle_brkchars): Likewise.
 249         (skip_quoted_chars): Likewise.
 250         * d-lang.c (d_language_data): Delete la_word_break_characters
 251         initializer.
 252         * f-lang.c (f_word_break_characters): Delete.
 253         (f_language_data): Delete la_word_break_characters initializer.
 254         (f_language::word_break_characters): New member function.
 255         * go-lang.c (go_language_data): Delete la_word_break_characters
 256         initializer.
 257         * language.c (unknown_language_data): Likewise.
 258         (auto_language_data): Likewise.
 259         * language.h (default_word_break_characters): Move declaration to
 260         earlier in the file.
 261         (language_data): Delete la_word_break_characters field.
 262         (language_defn::word_break_characters): New member function.
 263         * m2-lang.c (m2_language_data): Delete la_word_break_characters
 264         initializer.
 265         * objc-lang.c (objc_language_data): Likewise.
 266         * opencl-lang.c (opencl_language_data): Likewise.
 267         * p-lang.c (pascal_language_data): Likewise.
 268         * rust-lang.c (rust_language_data): Likewise.
 269
 270 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 271
 272         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
 273         (ada_language_data): Delete la_get_symbol_name_matcher
 274         initializer.
 275         (language_defn::get_symbol_name_matcher_inner): New member
 276         function.
 277         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
 278         initializer.
 279         (cplus_language_data): Likewise.
 280         (cplus_language::get_symbol_name_matcher_inner): New member
 281         function.
 282         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
 283         (minimal_language_data): Likewise.
 284         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
 285         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
 286         initializer.
 287         * dictionary.c (iter_match_first_hashed): Update call to
 288         get_symbol_name_matcher.
 289         (iter_match_next_hashed): Likewise.
 290         (iter_match_next_linear): Likewise.
 291         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
 292         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
 293         initializer.
 294         (f_language::get_symbol_name_matcher_inner): New member function.
 295         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
 296         initializer.
 297         * language.c (default_symbol_name_matcher): Update header comment,
 298         make static.
 299         (language_defn::get_symbol_name_matcher): New definition.
 300         (language_defn::get_symbol_name_matcher_inner): Likewise.
 301         (get_symbol_name_matcher): Delete.
 302         (unknown_language_data): Delete la_get_symbol_name_matcher
 303         initializer.
 304         (auto_language_data): Likewise.
 305         * language.h (language_data): Delete la_get_symbol_name_matcher
 306         field.
 307         (language_defn::get_symbol_name_matcher): New member function.
 308         (language_defn::get_symbol_name_matcher_inner): Likewise.
 309         (default_symbol_name_matcher): Delete declaration.
 310         * linespec.c (find_methods): Update call to
 311         get_symbol_name_matcher.
 312         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
 313         initializer.
 314         * minsyms.c (lookup_minimal_symbol): Update call to
 315         get_symbol_name_matcher.
 316         (iterate_over_minimal_symbols): Likewise.
 317         * objc-lang.c (objc_language_data): Delete
 318         la_get_symbol_name_matcher initializer.
 319         * opencl-lang.c (opencl_language_data): Likewise.
 320         * p-lang.c (pascal_language_data): Likewise.
 321         * psymtab.c (psymbol_name_matches): Update call to
 322         get_symbol_name_matcher.
 323         * rust-lang.c (rust_language_data): Delete
 324         la_get_symbol_name_matcher initializer.
 325         * symtab.c (symbol_matches_search_name): Update call to
 326         get_symbol_name_matcher.
 327         (compare_symbol_name): Likewise.
 328
 329 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         * ada-lang.c (ada_language_data): Delete la_compute_program
 332         initializer.
 333         * c-lang.c (c_language_data): Likewise.
 334         (c_language::compute_program): New member function.
 335         (cplus_language_data): Delete la_compute_program initializer.
 336         (cplus_language::compute_program): New member function.
 337         (asm_language_data): Delete la_compute_program initializer.
 338         (minimal_language_data): Likewise.
 339         * c-lang.h (c_compute_program): Update comment.
 340         (cplus_compute_program): Likewise.
 341         * compile/compile-c-support.c (c_compute_program): Likewise.
 342         (cplus_compute_program): Likewise.
 343         * compile/compile.c (compile_to_object): Update call to
 344         la_compute_program.
 345         * d-lang.c (d_language_data): Delete la_compute_program
 346         initializer.
 347         * f-lang.c (f_language_data): Likewise.
 348         * go-lang.c (go_language_data): Likewise.
 349         * language.c (unknown_language_data): Likewise.
 350         (auto_language_data): Likewise.
 351         * language.h (language_data): Delete la_compute_program field.
 352         (language_defn::compute_program): New member function.
 353         * m2-lang.c (m2_language_data): Delete la_compute_program
 354         initializer.
 355         * objc-lang.c (objc_language_data): Likewise.
 356         * opencl-lang.c (opencl_language_data): Likewise.
 357         * p-lang.c (pascal_language_data): Likewise.
 358         * rust-lang.c (rust_language_data): Likewise.
 359
 360 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 361
 362         * ada-lang.c (ada_language_data) Delete
 363         la_class_name_from_physname initializer.
 364         * c-lang.c (c_language_data): Likewise.
 365         (cplus_language_data): Likewise.
 366         (cplus_language::class_name_from_physname): New member function.
 367         (asm_language_data): Delete la_class_name_from_physname
 368         initializer.
 369         (minimal_language_data): Likewise.
 370         * d-lang.c (d_language_data): Likewise.
 371         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
 372         method on language_defn class.
 373         (guess_full_die_structure_name): Likewise.
 374         * f-lang.c (f_language_data): Delete la_class_name_from_physname
 375         initializer.
 376         * go-lang.c (go_language_data): Likewise.
 377         * language.c (language_class_name_from_physname): Delete.
 378         (unk_lang_class_name): Delete.
 379         (unknown_language_data): Delete la_class_name_from_physname
 380         initializer.
 381         (auto_language_data): Likewise.
 382         * language.h (language_data): Delete la_class_name_from_physname
 383         field.
 384         (language_defn::class_name_from_physname): New function.
 385         (language_class_name_from_physname): Delete declaration.
 386         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
 387         initializer.
 388         * objc-lang.c (objc_language_data): Likewise.
 389         * opencl-lang.c (opencl_language_data): Likewise.
 390         * p-lang.c (pascal_language_data): Likewise.
 391         * rust-lang.c (rust_language_data): Likewise.
 392
 393 2020-06-16  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-data.h (STATUS_NAME): New macro.
 396         * tui/tui-layout.c (tui_remove_some_windows)
 397         (initialize_known_windows, tui_register_window)
 398         (tui_layout_split::remove_windows, initialize_layouts)
 399         (tui_new_layout_command): Don't use hard-coded window names.
 400
 401 2020-06-16  Tom Tromey  <tom@tromey.com>
 402
 403         PR tui/25348:
 404         * tui/tui.c (tui_ensure_readline_initialized): Rename from
 405         tui_initialize_readline.  Only run once.  Call rl_initialize.
 406         * tui/tui.h (tui_ensure_readline_initialized): Rename from
 407         tui_initialize_readline.
 408         * tui/tui-io.c (tui_setup_io): Call
 409         tui_ensure_readline_initialized.
 410         * tui/tui-interp.c (tui_interp::init): Update.
 411
 412 2020-06-16  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
 415         Also preserve the status window.
 416
 417 2020-06-16  Tom Tromey  <tom@tromey.com>
 418
 419         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
 420         where m_window==nullptr.
 421
 422 2020-06-15  Tom Tromey  <tromey@adacore.com>
 423
 424         * windows-nat.c (windows_nat::handle_output_debug_string):
 425         Update.
 426         (windows_nat::handle_ms_vc_exception): Update.
 427         * target.h (target_read_string): Change API.
 428         * target.c (target_read_string): Change API.
 429         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
 430         Update.
 431         * solib-frv.c (frv_current_sos): Update.
 432         * solib-dsbt.c (dsbt_current_sos): Update.
 433         * solib-darwin.c (darwin_current_sos): Update.
 434         * linux-thread-db.c (inferior_has_bug): Update.
 435         * expprint.c (print_subexp_standard): Update.
 436         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
 437         (ada_exception_message_1): Update.
 438
 439 2020-06-15  Tom Tromey  <tromey@adacore.com>
 440
 441         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
 442
 443 2020-06-15  Tom Tromey  <tromey@adacore.com>
 444
 445         * valprint.c (read_string): Update comment.
 446         * target.c (MIN): Remove.
 447         (target_read_string): Rewrite.
 448
 449 2020-06-15  Tom Tromey  <tromey@adacore.com>
 450
 451         * corefile.c (read_memory_string): Remove.
 452         * ada-valprint.c (ada_value_print_ptr): Update.
 453         * ada-lang.h (ada_tag_name): Change return type.
 454         * ada-lang.c (type_from_tag): Update.
 455         (ada_tag_name_from_tsd): Change return type.  Use
 456         target_read_string.
 457         (ada_tag_name): Likewise.
 458         * gdbcore.h (read_memory_string): Don't declare.
 459
 460 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
 461
 462         * symtab.c (rbreak_command): Ignore Windows drive colon.
 463
 464 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
 465
 466         * NEWS: Mention removed GDBserver host support.
 467
 468 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
 469
 470         * features/riscv/rebuild-csr-xml.sh: Updated.
 471
 472 2020-06-11  Tom Tromey  <tom@tromey.com>
 473
 474         PR gdb/18318:
 475         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
 476
 477 2020-06-09  Jonny Grant  <jg@jguk.org>
 478 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
 479
 480         * main.c (captured_main_1): Don't print new line after help.
 481         (print_gdb_help): add mailing list and IRC channel information
 482         to --help.  Add new lines between items in the footer.  Remove
 483         quotes around bug url.
 484
 485 2020-06-11  Keith Seitz  <keiths@redhat.com>
 486
 487         PR gdb/21356
 488         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
 489         Resolve typedefs for type length calculations.
 490
 491 2020-06-10  Tom de Vries  <tdevries@suse.de>
 492
 493         PR ada/24713
 494         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
 495         (write_psymbols): Enable .gdb_index for ada.
 496         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
 497         ada.
 498
 499 2020-06-10  Tom de Vries  <tdevries@suse.de>
 500
 501         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
 502         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
 503         namei" instead of "const char *name" argument.
 504         (dw2_map_matching_symbols): Use "offset_type namei" variant of
 505         dw2_symtab_iter_init.
 506
 507 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 508
 509         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
 510         to use type::field and field::type instead.
 511
 512 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 513
 514         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
 515         to use field::type instead.
 516
 517 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 518
 519         * gdbtypes.h (struct field) <type, set_type>: New methods.
 520         Rename `type` field to...
 521         <m_type>: ... this.  Change references throughout to use type or
 522         set_type methods.
 523         (FIELD_TYPE): Use field::type.  Change call sites that modify
 524         the field's type to use field::set_type instead.
 525
 526 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 527
 528         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
 529         to use type::index_type instead.
 530
 531 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 532
 533         * gdbtypes.h (struct type) <index_type, set_index_type>: New
 534         methods.
 535         (TYPE_INDEX_TYPE): Use type::index_type.
 536         * gdbtypes.c (create_array_type_with_stride): Likewise.
 537
 538 2020-06-07  Tom Tromey  <tom@tromey.com>
 539
 540         * valprint.c (generic_val_print_float): Remove "embedded_offset"
 541         parameter.
 542         (generic_value_print): Update.
 543
 544 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         Revert commit 982a38f60b0.
 547         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
 548
 549 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
 552         avoid use after free.
 553
 554 2020-06-05  Tom de Vries  <tdevries@suse.de>
 555
 556         * NEWS: Fix typos.
 557
 558 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
 559
 560         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
 561         the per_bfd object.
 562         (dwarf2_read_debug_names): Likewise.
 563         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
 564         object when re-using a per_bfd object with an index.
 565
 566 2020-06-03  Tom de Vries  <tdevries@suse.de>
 567
 568         PR symtab/26046
 569         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
 570         children for C++.
 571         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
 572         DW_TAG_subprogram.
 573
 574 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 575
 576         * ada-lang.c (ada_language_data): Delete skip_trampoline
 577         initializer.
 578         * c-lang.c (c_language_data): Likewise.
 579         (cplus_language_data): Likewise.
 580         (cplus_language::skip_trampoline): New member function.
 581         (asm_language_data): Delete skip_trampoline initializer.
 582         (minimal_language_data): Likewise.
 583         * d-lang.c (d_language_data): Likewise.
 584         * f-lang.c (f_language_data): Likewise.
 585         * go-lang.c (go_language_data): Likewise.
 586         * language.c (unk_lang_trampoline): Delete function.
 587         (skip_language_trampoline): Update.
 588         (unknown_language_data): Delete skip_trampoline initializer.
 589         (auto_language_data): Likewise.
 590         * language.h (language_data): Delete skip_trampoline field.
 591         (language_defn::skip_trampoline): New function.
 592         * m2-lang.c (m2_language_data): Delete skip_trampoline
 593         initializer.
 594         * objc-lang.c (objc_skip_trampoline): Delete function, move
 595         implementation to objc_language::skip_trampoline.
 596         (objc_language_data): Delete skip_trampoline initializer.
 597         (objc_language::skip_trampoline): New member function with
 598         implementation from objc_skip_trampoline.
 599         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
 600         initializer.
 601         * p-lang.c (pascal_language_data): Likewise.
 602         * rust-lang.c (rust_language_data): Likewise.
 603
 604 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 605
 606         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
 607         (ada_language::demangle): New member function.
 608         * c-lang.c (c_language_data): Delete la_demangle initializer.
 609         (cplus_language_data): Delete la_demangle initializer.
 610         (cplus_language::demangle): New member function.
 611         (asm_language_data): Delete la_demangle initializer.
 612         (minimal_language_data): Delete la_demangle initializer.
 613         * d-lang.c (d_language_data): Delete la_demangle initializer.
 614         (d_language::demangle): New member function.
 615         * f-lang.c (f_language_data): Delete la_demangle initializer.
 616         (f_language::demangle): New member function.
 617         * go-lang.c (go_language_data): Delete la_demangle initializer.
 618         (go_language::demangle): New member function.
 619         * language.c (language_demangle): Update.
 620         (unk_lang_demangle): Delete.
 621         (unknown_language_data): Delete la_demangle initializer.
 622         (unknown_language::demangle): New member function.
 623         (auto_language_data): Delete la_demangle initializer.
 624         (auto_language::demangle): New member function.
 625         * language.h (language_data): Delete la_demangle field.
 626         (language_defn::demangle): New function.
 627         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
 628         * objc-lang.c (objc_language_data): Delete la_demangle
 629         initializer.
 630         (objc_language::demangle): New member function.
 631         * opencl-lang.c (opencl_language_data): Delete la_demangle
 632         initializer.
 633         * p-lang.c (pascal_language_data): Likewise.
 634         * rust-lang.c (rust_language_data): Likewise.
 635         (rust_language::demangle): New member function.
 636
 637 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * ada-lang.c (ada_language_data): Delete la_print_type
 640         initializer.
 641         (ada_language::print_type): New member function.
 642         * c-lang.c (c_language_data): Delete la_print_type initializer.
 643         (c_language::print_type): New member function.
 644         (cplus_language_data): Delete la_print_type initializer.
 645         (cplus_language::print_type): New member function.
 646         (asm_language_data): Delete la_print_type initializer.
 647         (asm_language::print_type): New member function.
 648         (minimal_language_data): Delete la_print_type initializer.
 649         (minimal_language::print_type): New member function.
 650         * d-lang.c (d_language_data): Delete la_print_type initializer.
 651         (d_language::print_type): New member function.
 652         * f-lang.c (f_language_data): Delete la_print_type initializer.
 653         (f_language::print_type): New member function.
 654         * go-lang.c (go_language_data): Delete la_print_type initializer.
 655         (go_language::print_type): New member function.
 656         * language.c (unk_lang_print_type): Delete.
 657         (unknown_language_data): Delete la_print_type initializer.
 658         (unknown_language::print_type): New member function.
 659         (auto_language_data): Delete la_print_type initializer.
 660         (auto_language::print_type): New member function.
 661         * language.h (language_data): Delete la_print_type field.
 662         (language_defn::print_type): New function.
 663         (LA_PRINT_TYPE): Update.
 664         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
 665         (m2_language::print_type): New member function.
 666         * objc-lang.c (objc_language_data): Delete la_print_type
 667         initializer.
 668         (objc_language::print_type): New member function.
 669         * opencl-lang.c (opencl_print_type): Delete, implementation moved
 670         to opencl_language::print_type.
 671         (opencl_language_data): Delete la_print_type initializer.
 672         (opencl_language::print_type): New member function, implementation
 673         from opencl_print_type.
 674         * p-lang.c (pascal_language_data): Delete la_print_type
 675         initializer.
 676         (pascal_language::print_type): New member function.
 677         * rust-lang.c (rust_print_type): Delete, implementation moved to
 678         rust_language::print_type.
 679         (rust_language_data): Delete la_print_type initializer.
 680         (rust_language::print_type): New member function, implementation
 681         from rust_print_type.
 682
 683 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 684
 685         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
 686         implementation moves to...
 687         (ada_language::sniff_from_mangled_name): ...here.  Update return
 688         type.
 689         (ada_language_data): Delete la_sniff_from_mangled_name
 690         initializer.
 691         * c-lang.c (c_language_data): Likewise.
 692         (cplus_language_data): Likewise.
 693         (cplus_language::sniff_from_mangled_name): New member function,
 694         implementation taken from gdb_sniff_from_mangled_name.
 695         (asm_language_data): Delete la_sniff_from_mangled_name
 696         initializer.
 697         (minimal_language_data): Likewise.
 698         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
 699         implementation moves to cplus_language::sniff_from_mangled_name.
 700         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
 701         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
 702         moves to...
 703         (d_language::sniff_from_mangled_name): ...here.
 704         (d_language_data): Delete la_sniff_from_mangled_name initializer.
 705         * f-lang.c (f_language_data): Likewise.
 706         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
 707         moves to...
 708         (go_language::sniff_from_mangled_name): ...here.
 709         (go_language_data): Delete la_sniff_from_mangled_name initializer.
 710         * language.c (language_sniff_from_mangled_name): Delete.
 711         (unknown_language_data): Delete la_sniff_from_mangled_name
 712         initializer.
 713         (auto_language_data): Likewise.
 714         * language.h (language_data): Delete la_sniff_from_mangled_name
 715         field.
 716         (language_defn::sniff_from_mangled_name): New function.
 717         (language_sniff_from_mangled_name): Delete declaration.
 718         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
 719         field.
 720         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
 721         implementation moves to...
 722         (objc_language::sniff_from_mangled_name): ...here.
 723         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
 724         * opencl-lang.c (opencl_language_data): Likewise.
 725         * p-lang.c (pascal_language_data): Likewise.
 726         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
 727         implementation moves to...
 728         (rust_language::sniff_from_mangled_name): ...here.
 729         (rust_language_data): Delete la_sniff_from_mangled_name
 730         initializer.
 731         * symtab.c (symbol_find_demangled_name): Call
 732         sniff_from_mangled_name member function.
 733
 734 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * ada-lang.c (ada_language_data): Delete la_search_name_hash
 737         initializer.
 738         * c-lang.c (c_language_data): Likewise.
 739         (cplus_language_data): Likewise.
 740         (cplus_language::search_name_hash): New member function.
 741         (asm_language_data): Delete la_search_name_hash initializer.
 742         (minimal_language_data): Likewise.
 743         * d-lang.c (d_language_data): Likewise.
 744         * dictionary.c (default_search_name_hash): Rename to...
 745         (language_defn::search_name_hash): ...this.
 746         * f-lang.c (f_language_data): Likewise.
 747         (f_language::search_name_hash): New member function.
 748         * go-lang.c (go_language_data): Delete la_search_name_hash
 749         initializer.
 750         * language.c (unknown_language_data): Likewise.
 751         (auto_language_data): Likewise.
 752         * language.h (struct language_data): Delete la_search_name_hash
 753         field.
 754         (language_defn::search_name_hash): Declare new member function.
 755         (default_search_name_hash): Delete declaration.
 756         * m2-lang.c (m2_language_data): Delete la_search_name_hash
 757         initializer.
 758         * objc-lang.c (objc_language_data): Likewise.
 759         * opencl-lang.c (opencl_language_data): Likewise.
 760         * p-lang.c (pascal_language_data): Likewise.
 761         * rust-lang.c (rust_language_data): Likewise.
 762         * symtab.c (search_name_hash): Update call.
 763
 764 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 765
 766         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
 767         initializer.
 768         * c-lang.c (class compile_instance): Declare.
 769         (c_language_data): Delete la_get_compile_instance initializer.
 770         (c_language::get_compile_instance): New member function.
 771         (cplus_language_data): Delete la_get_compile_instance initializer.
 772         (cplus_language::get_compile_instance): New member function.
 773         (asm_language_data): Delete la_get_compile_instance initializer.
 774         (minimal_language_data): Likewise.
 775         * c-lang.h (c_get_compile_context): Update comment.
 776         (cplus_get_compile_context): Update comment.
 777         * compile/compile.c (compile_to_object): Update calls, don't rely
 778         on function pointer being NULL.
 779         * d-lang.c (d_language_data): Delete la_get_compile_instance
 780         initializer.
 781         * f-lang.c (f_language_data): Likewise.
 782         * go-lang.c (go_language_data): Likewise.
 783         * language.c (unknown_language_data): Likewise.
 784         (auto_language_data): Likewise.
 785         * language.h (language_data): Delete la_get_compile_instance field.
 786         (language_defn::get_compile_instance): New member function.
 787         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
 788         initializer.
 789         * objc-lang.c (objc_language_data): Likewise.
 790         * opencl-lang.c (opencl_language_data): Likewise.
 791         * p-lang.c (pascal_language_data): Likewise.
 792         * rust-lang.c (rust_language_data): Likewise.
 793
 794 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * ada-lang.c (ada_add_all_symbols): Update comment.
 797         (ada_iterate_over_symbols): Delete, move implementation to...
 798         (ada_language::iterate_over_symbols): ...here, a new member
 799         function, rewrite to use range based for loop.
 800         (ada_language_data): Delete la_iterate_over_symbols initializer.
 801         * c-lang.c (c_language_data): Likewise.
 802         (cplus_language_data): Likewise.
 803         (asm_language_data): Likewise.
 804         (minimal_language_data): Likewise.
 805         * d-lang.c (d_language_data): Likewise.
 806         * f-lang.c (f_language_data): Likewise.
 807         * go-lang.c (go_language_data): Likewise.
 808         * language.c (unknown_language_data): Likewise.
 809         (auto_language_data): Likewise.
 810         * language.h (language_data): Delete la_iterate_over_symbols field.
 811         (language_defn::iterate_over_symbols): New member function.
 812         (LA_ITERATE_OVER_SYMBOLS): Update.
 813         * linespec.c (iterate_over_all_matching_symtabs): Update.
 814         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
 815         initializer.
 816         * objc-lang.c (objc_language_data): Likewise.
 817         * opencl-lang.c (opencl_language_data): Likewise.
 818         * p-lang.c (pascal_language_data): Likewise.
 819         * rust-lang.c (rust_language_data): Likewise.
 820
 821 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * ada-lang.c (ada_language_data): Delete
 824         la_lookup_transparent_type initializer.
 825         * c-lang.c (c_language_data): Likewise.
 826         (cplus_language_data): Likewise.
 827         (cplus_language::lookup_transparent_type): New member function.
 828         (asm_language_data): Delete la_lookup_transparent_type
 829         initializer.
 830         (minimal_language_data): Likewise.
 831         * d-lang.c (d_language_data): Likewise.
 832         * f-lang.c (f_language_data): Likewise.
 833         * go-lang.c (go_language_data): Likewise.
 834         * language.c (unknown_language_data): Likewise.
 835         (auto_language_data): Likewise.
 836         * language.h (struct language_data): Delete
 837         la_lookup_transparent_type field.
 838         (language_defn::lookup_transparent_type): New member function.
 839         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
 840         initializer.
 841         * objc-lang.c (objc_language_data): Likewise.
 842         * opencl-lang.c (opencl_language_data): Likewise.
 843         * p-lang.c (pascal_language_data): Likewise.
 844         * rust-lang.c (rust_language_data): Likewise.
 845         * symtab.c (symbol_matches_domain): Update call.
 846
 847 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * ada-lang.c (ada_language_arch_info): Delete function, move
 850         implementation to...
 851         (ada_language::language_arch_info): ...here, a new member
 852         function.
 853         (ada_language_data): Delete la_language_arch_info.
 854         * c-lang.c (c_language_data): Likewise.
 855         (c_language::language_arch_info): New member function.
 856         (cplus_language_arch_info): Delete function, move
 857         implementation to...
 858         (cplus_language::language_arch_info): ...here, a new member
 859         function.
 860         (cplus_language_data): Delete la_language_arch_info.
 861         (asm_language_data): Likewise.
 862         (asm_language::language_arch_info): New member function.
 863         (minimal_language_data): Delete la_language_arch_info.
 864         (minimal_language::language_arch_info): New member function.
 865         * d-lang.c (d_language_arch_info): Delete function, move
 866         implementation to...
 867         (d_language::language_arch_info): ...here, a new member
 868         function.
 869         (d_language_data): Delete la_language_arch_info.
 870         * f-lang.c (f_language_arch_info): Delete function, move
 871         implementation to...
 872         (f_language::language_arch_info): ...here, a new member
 873         function.
 874         (f_language_data): Delete la_language_arch_info.
 875         * go-lang.c (go_language_arch_info): Delete function, move
 876         implementation to...
 877         (go_language::language_arch_info): ...here, a new member
 878         function.
 879         (go_language_data): Delete la_language_arch_info.
 880         * language.c (unknown_language_data): Likewise.
 881         (unknown_language::language_arch_info): New member function.
 882         (auto_language_data): Delete la_language_arch_info.
 883         (auto_language::language_arch_info): New member function.
 884         (language_gdbarch_post_init): Update call to
 885         la_language_arch_info.
 886         * language.h (language_data): Delete la_language_arch_info
 887         function pointer.
 888         (language_defn::language_arch_info): New function.
 889         * m2-lang.c (m2_language_arch_info): Delete function, move
 890         implementation to...
 891         (m2_language::language_arch_info): ...here, a new member
 892         function.
 893         (m2_language_data): Delete la_language_arch_info.
 894         * objc-lang.c (objc_language_arch_info): Delete function, move
 895         implementation to...
 896         (objc_language::language_arch_info): ...here, a new member
 897         function.
 898         (objc_language_data): Delete la_language_arch_info.
 899         * opencl-lang.c (opencl_language_arch_info): Delete function, move
 900         implementation to...
 901         (opencl_language::language_arch_info): ...here, a new member
 902         function.
 903         (opencl_language_data): Delete la_language_arch_info.
 904         * p-lang.c (pascal_language_arch_info): Delete function, move
 905         implementation to...
 906         (pascal_language::language_arch_info): ...here, a new member
 907         function.
 908         (pascal_language_data): Delete la_language_arch_info.
 909         * rust-lang.c (rust_language_arch_info): Delete function, move
 910         implementation to...
 911         (rust_language::language_arch_info): ...here, a new member
 912         function.
 913         (rust_language_data): Delete la_language_arch_info.
 914
 915 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
 918         initializer.
 919         * c-lang.c (c_language_data): Likewise.
 920         (cplus_language_data): Likewise.
 921         (cplus_language::pass_by_reference_info): New method.
 922         (asm_language_data): Delete la_pass_by_reference initializer.
 923         (minimal_language_data): Likewise.
 924         * cp-abi.c (cp_pass_by_reference): Remove use of
 925         default_pass_by_reference.
 926         * d-lang.c (d_language_data): Likewise.
 927         * f-lang.c (f_language_data): Likewise.
 928         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
 929         default_pass_by_reference.
 930         * go-lang.c (go_language_data): Likewise.
 931         * language.c (language_pass_by_reference): Update.
 932         (default_pass_by_reference): Delete.
 933         (unknown_language_data): Delete la_pass_by_reference
 934         initializer.
 935         (auto_language_data): Likewise.
 936         * language.h (struct language_data): Delete la_pass_by_reference
 937         field.
 938         (language_defn::pass_by_reference_info): New member function.
 939         (default_pass_by_reference): Delete declaration.
 940         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
 941         initializer.
 942         * objc-lang.c (objc_language_data): Likewise.
 943         * opencl-lang.c (opencl_language_data): Likewise.
 944         * p-lang.c (pascal_language_data): Likewise.
 945         * rust-lang.c (rust_language_data): Likewise.
 946
 947 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * ada-lang.c (ada_read_var_value): Delete function, move
 950         implementation to...
 951         (ada_language::read_var_value): ...here.
 952         (ada_language_data): Delete la_read_var_value initializer.
 953         * c-lang.c (c_language_data): Likewise.
 954         (cplus_language_data): Likewise.
 955         (minimal_language_data): Likewise.
 956         * d-lang.c (d_language_data): Likewise.
 957         * f-lang.c (f_language_data): Likewise.
 958         * findvar.c (default_read_var_value): Rename to...
 959         (language_defn::read_var_value): ...this.
 960         * findvar.c (read_var_value): Update header comment, and change to
 961         call member function instead of function pointer.
 962         * go-lang.c (go_language_data): Likewise.
 963         * language.c (unknown_language_data): Delete la_read_var_value
 964         initializer.
 965         (auto_language_data): Likewise.
 966         * language.h (struct language_data): Delete la_read_var_value
 967         field.
 968         (language_defn::read_var_value): New member function.
 969         (default_read_var_value): Delete declaration.
 970         * m2-lang.c (m2_language_data): Delete la_read_var_value
 971         initializer.
 972         * objc-lang.c (objc_language_data): Likewise.
 973         * opencl-lang.c (opencl_language_data): Likewise.
 974         * p-lang.c (pascal_language_data): Likewise.
 975         * rust-lang.c (rust_language_data): Likewise.
 976         * value.h (default_read_var_value): Delete declaration.
 977
 978 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 979
 980         * ada-lang.c (ada_print_array_index): Delete function, move
 981         implementation to...
 982         (ada_language::print_array_index): ...here.
 983         (ada_language_data): Delete la_print_array_index initializer.
 984         * c-lang.c (c_language_data): Likewise.
 985         (cplus_language_data): Likewise.
 986         (minimal_language_data): Likewise.
 987         * d-lang.c (d_language_data): Likewise.
 988         * f-lang.c (f_language_data): Likewise.
 989         * go-lang.c (go_language_data): Likewise.
 990         * language.c (default_print_array_index): Delete function, move
 991         implementation to...
 992         (language_defn::print_array_index): ...here.
 993         (unknown_language_data): Delete la_print_array_index initializer.
 994         (auto_language_data): Likewise.
 995         * language.h (struct language_data): Delete la_print_array_index
 996         field.
 997         (language_defn::print_array_index): New member function.
 998         (LA_PRINT_ARRAY_INDEX): Update.
 999         (default_print_array_index): Delete declaration.
1000         * m2-lang.c (m2_language_data): Delete la_print_array_index
1001         initializer.
1002         * objc-lang.c (objc_language_data): Likewise.
1003         * opencl-lang.c (opencl_language_data): Likewise.
1004         * p-lang.c (pascal_language_data): Likewise.
1005         * rust-lang.c (rust_language_data): Likewise.
1006
1007 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * gdb/ada-lang.c (ada_language_defn): Convert to...
1010         (ada_language_data): ...this.
1011         (class ada_language): New class.
1012         (ada_language_defn): New static global.
1013         * gdb/c-lang.c (c_language_defn): Convert to...
1014         (c_language_data): ...this.
1015         (class c_language): New class.
1016         (c_language_defn): New static global.
1017         (cplus_language_defn): Convert to...
1018         (cplus_language_data): ...this.
1019         (class cplus_language): New class.
1020         (cplus_language_defn): New static global.
1021         (asm_language_defn): Convert to...
1022         (asm_language_data): ...this.
1023         (class asm_language): New class.
1024         (asm_language_defn): New static global.
1025         (minimal_language_defn): Convert to...
1026         (minimal_language_data): ...this.
1027         (class minimal_language): New class.
1028         (minimal_language_defn): New static global.
1029         * gdb/d-lang.c (d_language_defn): Convert to...
1030         (d_language_data): ...this.
1031         (class d_language): New class.
1032         (d_language_defn): New static global.
1033         * gdb/f-lang.c (f_language_defn): Convert to...
1034         (f_language_data): ...this.
1035         (class f_language): New class.
1036         (f_language_defn): New static global.
1037         * gdb/go-lang.c (go_language_defn): Convert to...
1038         (go_language_data): ...this.
1039         (class go_language): New class.
1040         (go_language_defn): New static global.
1041         * gdb/language.c (unknown_language_defn): Remove declaration.
1042         (current_language): Initialize to nullptr, real initialization is
1043         moved to _initialize_language.
1044         (languages): Delete global.
1045         (language_defn::languages): Define.
1046         (set_language_command): Use language_defn::languages.
1047         (set_language): Likewise.
1048         (range_error): Likewise.
1049         (language_enum): Likewise.
1050         (language_def): Likewise.
1051         (add_set_language_command): Use language_def::languages for the
1052         language list, and language_def to lookup language pointers.
1053         (skip_language_trampoline): Use language_defn::languages.
1054         (unknown_language_defn): Convert to...
1055         (unknown_language_data): ...this.
1056         (class unknown_language): New class.
1057         (unknown_language_defn): New static global.
1058         (auto_language_defn): Convert to...
1059         (auto_language_data): ...this.
1060         (class auto_language): New class.
1061         (auto_language_defn): New static global.
1062         (language_gdbarch_post_init): Use language_defn::languages.
1063         (_initialize_language): Initialize current_language.
1064         * gdb/language.h (struct language_defn): Rename to...
1065         (struct language_data): ...this.
1066         (struct language_defn): New.
1067         (auto_language_defn): Delete.
1068         (unknown_language_defn): Delete.
1069         (minimal_language_defn): Delete.
1070         (ada_language_defn): Delete.
1071         (asm_language_defn): Delete.
1072         (c_language_defn): Delete.
1073         (cplus_language_defn): Delete.
1074         (d_language_defn): Delete.
1075         (f_language_defn): Delete.
1076         (go_language_defn): Delete.
1077         (m2_language_defn): Delete.
1078         (objc_language_defn): Delete.
1079         (opencl_language_defn): Delete.
1080         (pascal_language_defn): Delete.
1081         (rust_language_defn): Delete.
1082         * gdb/m2-lang.c (m2_language_defn): Convert to...
1083         (m2_language_data): ...this.
1084         (class m2_language): New class.
1085         (m2_language_defn): New static global.
1086         * gdb/objc-lang.c (objc_language_defn): Convert to...
1087         (objc_language_data): ...this.
1088         (class objc_language): New class.
1089         (objc_language_defn): New static global.
1090         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
1091         (opencl_language_data): ...this.
1092         (class opencl_language): New class.
1093         (opencl_language_defn): New static global.
1094         * gdb/p-lang.c (pascal_language_defn): Convert to...
1095         (pascal_language_data): ...this.
1096         (class pascal_language): New class.
1097         (pascal_language_defn): New static global.
1098         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
1099         language pointer, update comment format.
1100         * gdb/rust-lang.c (rust_language_defn): Convert to...
1101         (rust_language_data): ...this.
1102         (class rust_language): New class.
1103         (rust_language_defn): New static global.
1104
1105 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
1108         member variable.
1109         <m_stmt_at_address>: New member variable.
1110         (lnp_state_machine::record_line): Don't record some lines, update
1111         tracking of is_stmt at the same address.
1112         (lnp_state_machine::lnp_state_machine): Initialise new member
1113         variables.
1114
1115 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1116
1117         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
1118         "-include gnu-nat-mig.h".
1119         * gnu-nat-mig.h: New file.
1120         * gnu-nat.c: Include "gnu-nat-mig.h".
1121         (exc_server, msg_reply_server, notify_server,
1122         process_reply_server): Remove declarations.
1123
1124 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1125
1126         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
1127         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
1128         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
1129         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
1130         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
1131         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
1132         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
1133         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
1134         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
1135         to gnu_nat_target class.
1136         * gnu-nat.c: Likewise.
1137         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
1138         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
1139         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
1140         object.
1141         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
1142         instead of `gnu_target'.
1143
1144 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1145
1146         * i386-gnu-tdep.c: Include "gdbcore.h"
1147         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
1148         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
1149         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
1150         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
1151         i386_gnu_sigcontext_addr): New functions
1152         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
1153         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
1154         tdep.
1155
1156 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1157
1158         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
1159         before fork_inferior call. Avoid calling it if target_is_pushed returns
1160         true.
1161
1162 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1163
1164         * gnu-nat.h (gnu_target): New variable declaration.
1165         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
1166         gnu_target.
1167         * gnu-nat.c (gnu_target): New variable.
1168         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
1169         add_thread_silent, and add_thread calls.
1170         (gnu_nat_target::create_inferior): Pass gnu_target to
1171         add_thread_silent, thread_change_ptid call.
1172         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
1173         call.
1174
1175 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1176
1177         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
1178         (gnu_nat_target::find_memory_regions): Remove unused
1179         `old_address' variable.
1180
1181 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1182
1183         * gnu-nat.c: Include "gdbarch.h".
1184
1185 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1186
1187         * reply_mig_hack.awk (Error return): Cast function through
1188         void *, to bypass compiler function call check.
1189
1190 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1191
1192         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
1193         $(srcdir)/reply_mig_hack.awk.
1194
1195 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1196
1197         * gnu-nat.h (gnu_debug_flag): Set type to bool.
1198
1199 2020-05-30  Jonny Grant  <jg@jguk.org>
1200
1201         * configure.ac (ACX_BUGURL): change bug URL to https.
1202
1203 2020-05-30  Pedro Alves  <palves@redhat.com>
1204
1205         * cp-support.c (replace_typedefs_template): New.
1206         (replace_typedefs_qualified_name): Handle
1207         DEMANGLE_COMPONENT_TEMPLATE.
1208
1209 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
1210
1211         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
1212         dwarf2/index-cache.h, dwarf2/index-write.c,
1213         dwarf2/index-write.h, dwarf2/line-header.c,
1214         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
1215         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
1216         variables and fields from `dwarf2_per_objfile` to just
1217         `per_objfile` throughout.
1218
1219 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
1220
1221         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1222         <push_dwarf_reg_entry_value>: Add comment.
1223
1224 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
1225             Keith Seitz  <keiths@redhat.com>
1226
1227         * python/python.c (do_start_initialization): Call PyEval_SaveThread
1228         instead of PyEval_ReleaseLock.
1229         (class gdbpy_gil): Move to earlier in file.
1230         (finalize_python): Set gdb_python_initialized.
1231         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
1232         when not initialized.
1233
1234 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
1235
1236         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1237         <push_dwarf_reg_entry_value>: Remove assert.  Override
1238         per_objfile with caller_per_objfile.
1239
1240 2020-05-28  Tom de Vries  <tdevries@suse.de>
1241
1242         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
1243         PR gold/15646 workaround to symbol kind "type".
1244
1245 2020-05-27  Tom Tromey  <tromey@adacore.com>
1246
1247         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
1248
1249 2020-05-27  Tom Tromey  <tromey@adacore.com>
1250
1251         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
1252         Use htab_find_with_hash.
1253         <add_abbrev>: Remove "abbrev_number" parameter.
1254         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
1255         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
1256         (hash_abbrev): Add comment.
1257         (abbrev_table::lookup_abbrev): Move to header file.
1258         (abbrev_table::read): Update.
1259
1260 2020-05-27  Tom Tromey  <tromey@adacore.com>
1261
1262         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
1263         method.
1264         <canonical_name>: New member.
1265         <raw_name>: Rename from "name".
1266         (partial_die_info): Initialize canonical_name.
1267         (scan_partial_symbols): Check raw_name.
1268         (partial_die_parent_scope, partial_die_full_name)
1269         (add_partial_symbol, add_partial_subprogram)
1270         (add_partial_enumeration, load_partial_dies): Use "name" method.
1271         (partial_die_info::name): New method.
1272         (partial_die_info::read, guess_partial_die_structure_name)
1273         (partial_die_info::fixup): Update.
1274
1275 2020-05-27  Tom Tromey  <tromey@adacore.com>
1276
1277         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
1278         <get_ref_die_offset>: Inline.
1279         <get_ref_die_offset_complaint>: New method.
1280         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
1281         (attribute::get_ref_die_offset_complaint): Rename from
1282         get_ref_die_offset.  Just issue complaint.
1283
1284 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1285
1286         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
1287
1288 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1289
1290         * exec.c (exec_file_attach): Use errno value of first openp failure.
1291
1292 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1293
1294         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
1295         Don't close thread handle.
1296
1297 2020-05-27  Tom Tromey  <tom@tromey.com>
1298             Simon Marchi  <simon.marchi@efficios.com>
1299
1300         * objfiles.h (struct objfile) <partial_symtabs>: Now a
1301         shared_ptr.
1302         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
1303         member.
1304         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
1305         dwarf2_per_bfd_objfile_data_key>: New globals.
1306         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
1307         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
1308         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
1309         shared.
1310         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
1311         short-circuit when sharing.
1312         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
1313         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
1314
1315 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1316
1317         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
1318         to...
1319         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
1320         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
1321
1322 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1323
1324         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
1325         build_name_components, find_name_components_bounds>:
1326         Add per_objfile parameter.
1327         (struct mapped_index) <symbol_name_at>: Likewise.
1328         (struct mapped_debug_names): Remove constructor.
1329         <dwarf2_per_objfile>: Remove field.
1330         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
1331         (mapped_index_base::find_name_components_bounds,
1332         mapped_index_base::build_name_components,
1333         dw2_expand_symtabs_matching_symbol): Likewise.
1334         (class mock_mapped_index) <symbol_name_at>: Likewise.
1335         (check_match): Likewise.
1336         (check_find_bounds_finds): Likewise.
1337         (test_mapped_index_find_name_component_bounds): Update.
1338         (CHECK_MATCH): Update.
1339         (dw2_expand_symtabs_matching): Update.
1340         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
1341         per_objfile parameter.
1342         <find_vec_in_debug_names>: Likewise.
1343         <m_per_objfile>: New field.
1344         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
1345         parameter.
1346         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
1347         (dw2_debug_names_iterator::next): Update.
1348         (dw2_debug_names_lookup_symbol): Update.
1349         (dw2_debug_names_expand_symtabs_for_function): Update.
1350         (dw2_debug_names_map_matching_symbols): Update.
1351         (dw2_debug_names_expand_symtabs_matching): Update.
1352         (dwarf2_read_debug_names): Update.
1353
1354 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1355
1356         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
1357         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
1358         move to dwarf2_per_objfile.
1359         <read_in_chain>: Remove.
1360         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
1361         remove_all_cus, age_comp_units>: New methods.
1362         <m_dwarf2_cus>: New member.
1363         (struct dwarf2_per_cu_data) <cu>: Remove.
1364         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
1365         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
1366         moved to methods of dwarf2_per_objfile.
1367         (dwarf2_clear_marks): Remove.
1368         (dwarf2_queue_item::~dwarf2_queue_item): Update.
1369         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
1370         (dwarf2_per_bfd::free_cached_comp_units): Remove.
1371         (dwarf2_per_objfile::remove_all_cus): New.
1372         (class free_cached_comp_units) <~free_cached_comp_units>:
1373         Update.
1374         (load_cu): Update.
1375         (dw2_do_instantiate_symtab): Adjust.
1376         (fill_in_sig_entry_from_dwo_entry): Adjust.
1377         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1378         (cutu_reader::cutu_reader): Likewise.
1379         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
1380         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
1381         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
1382         and dwarf2_per_objfile::age_comp_units.
1383         (load_partial_comp_unit): Update.
1384         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
1385         (process_queue): Likewise.
1386         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
1387         backlink.
1388         (dwarf2_read_addr_index): Likewise.
1389         (follow_die_offset): Likewise.
1390         (dwarf2_fetch_die_loc_sect_off): Likewise.
1391         (dwarf2_fetch_constant_bytes): Likewise.
1392         (dwarf2_fetch_die_type_sect_off): Likewise.
1393         (follow_die_sig_1): Likewise.
1394         (load_full_type_unit): Likewise.
1395         (read_signatured_type): Likewise.
1396         (dwarf2_cu::dwarf2_cu): Don't set cu field.
1397         (dwarf2_cu::~dwarf2_cu): Remove.
1398         (dwarf2_per_objfile::get_cu): New.
1399         (dwarf2_per_objfile::set_cu): New.
1400         (age_cached_comp_units): Rename to...
1401         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
1402         to std::unordered_map.
1403         (free_one_cached_comp_unit): Rename to...
1404         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
1405         to std::unordered_map.
1406         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
1407         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
1408         a dwarf2_per_objfile in data.
1409         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
1410         (dwarf2_clear_marks): Remove.
1411
1412 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1413
1414         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
1415         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
1416         (init_tu_and_read_dwo_dies): Likewise.
1417         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
1418         (cutu_reader::cutu_reader): Likewise.
1419         (load_partial_comp_unit): Likewise.
1420         (process_psymtab_comp_unit): Update.
1421         (build_type_psymtabs_1): Update.
1422         (process_skeletonless_type_unit): Update.
1423         (load_full_comp_unit): Update.
1424         (find_partial_die): Update.
1425         (dwarf2_read_addr_index): Update.
1426         (read_signatured_type): Update.
1427
1428 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1429
1430         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
1431         m_header_read_in>: New fields.
1432         <get_header>: New method.
1433         * dwarf2/read.c (per_cu_header_read_in): Remove.
1434         (dwarf2_per_cu_data::get_header): New.
1435         (dwarf2_per_cu_data::addr_size): Update.
1436         (dwarf2_per_cu_data::offset_size): Update.
1437         (dwarf2_per_cu_data::ref_addr_size): Update.
1438
1439 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1440
1441         * dwarf2/read.c (load_cu): Return dwarf2_cu.
1442         (dw2_do_instantiate_symtab): Update.
1443         (queue_and_load_all_dwo_tus): Change parameter from
1444         dwarf2_per_cu_data to dwarf2_cu.
1445         (dwarf2_fetch_die_loc_sect_off): Update.
1446         (dwarf2_fetch_constant_bytes): Update.
1447         (dwarf2_fetch_die_type_sect_off): Update.
1448
1449 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1450
1451         * dwarf2/read.c (process_full_comp_unit,
1452         process_full_type_unit): Remove per_cu, per_objfile paramters.
1453         Add dwarf2_cu parameter.
1454         (process_queue): Update.
1455
1456 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1457
1458         * dwarf2/read.c (create_cu_from_index_list): Replace
1459         dwarf2_per_objfile parameter with dwarf2_per_bfd.
1460         (create_cus_from_index_list): Likewise.
1461         (create_cus_from_index): Likewise.
1462         (create_signatured_type_table_from_index): Likewise.
1463         (create_cus_from_debug_names_list): Likewise.
1464         (create_cus_from_debug_names): Likewise.
1465         (dwarf2_read_gdb_index): Update.
1466         (dwarf2_read_debug_names): Update.
1467
1468 2020-05-27  Tom Tromey  <tom@tromey.com>
1469             Simon Marchi  <simon.marchi@efficios.com>
1470
1471         * dwarf2/read.h (struct dwarf2_per_objfile)
1472         <get_type_for_signatured_type, set_type_for_signatured_type>:
1473         New methods.
1474         <m_type_map>: New member.
1475         (struct signatured_type) <type>: Remove.
1476         * dwarf2/read.c
1477         (dwarf2_per_objfile::get_type_for_signatured_type,
1478         dwarf2_per_objfile::set_type_for_signatured_type): New.
1479         (get_signatured_type): Use new methods.
1480
1481 2020-05-27  Tom Tromey  <tom@tromey.com>
1482             Simon Marchi  <simon.marchi@efficios.com>
1483
1484         * dwarf2/read.h (struct type_unit_group_unshareable): New.
1485         (struct dwarf2_per_objfile) <type_units>: New member.
1486         <get_type_unit_group_unshareable>: New method.
1487         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
1488         num_symtabs, symtabs>: Remove; move to
1489         type_unit_group_unshareable.
1490         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
1491         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
1492         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
1493
1494 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1495
1496         * dwarf2/read.h (struct dwarf2_per_cu_data):
1497         <dwarf2_per_objfile>: Remove.
1498         * dwarf2/read.c (create_cu_from_index_list): Don't assign
1499         dwarf2_per_objfile.
1500         (create_signatured_type_table_from_index): Likewise.
1501         (create_signatured_type_table_from_debug_names): Likewise.
1502         (create_debug_type_hash_table): Likewise.
1503         (fill_in_sig_entry_from_dwo_entry): Likewise.
1504         (create_type_unit_group): Likewise.
1505         (read_comp_units_from_section): Likewise.
1506         (create_cus_hash_table): Likewise.
1507
1508 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1509
1510         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
1511         dwarf2_per_cu_data::dwarf2_per_objfile.
1512         (compute_compunit_symtab_includes): Likewise.
1513         (dwarf2_cu::start_symtab): Likewise.
1514
1515 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1516
1517         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
1518         parameter.
1519         * dwarf2/read.c (get_die_type_at_offset): Likewise.
1520         (read_namespace_alias): Update.
1521         (lookup_die_type): Update.
1522         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
1523         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
1524         Update.
1525         (disassemble_dwarf_expression): Update.
1526
1527 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1528
1529         * dwarf2/read.h (struct dwarf2_queue_item): Add
1530         dwarf2_per_objfile parameter, assign new parameter.
1531         <per_objfile>: New field.
1532         * dwarf2/read.c (free_one_cached_comp_unit): Add
1533         dwarf2_per_objfile parameter.
1534         (queue_comp_unit): Likewise.
1535         (dw2_do_instantiate_symtab): Update.
1536         (process_psymtab_comp_unit): Update.
1537         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
1538         (process_imported_unit_die): Update.
1539         (queue_and_load_dwo_tu): Update.
1540         (follow_die_offset): Update.
1541         (follow_die_sig_1): Update.
1542
1543 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1544
1545         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
1546         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
1547         (read_call_site_scope): Assign per_objfile.
1548         (dwarf2_per_cu_data::objfile): Remove.
1549         * gdbtypes.h (struct call_site) <per_objfile>: New member.
1550         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
1551         dwarf2_per_objfile parameter.
1552         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
1553         dwarf2_per_objfile parameter.
1554         (dwarf_expr_reg_to_entry_parameter): Add output
1555         dwarf2_per_objfile parameter.
1556         (locexpr_get_frame_base): Update.
1557         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
1558         <push_dwarf_reg_entry_value>: Update.
1559         <call_site_to_target_addr>: Update.
1560         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
1561         parameter.
1562         (value_of_dwarf_reg_entry): Update.
1563         (rw_pieced_value): Update.
1564         (indirect_synthetic_pointer): Update.
1565         (dwarf2_evaluate_property): Update.
1566         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
1567         parameter.
1568         (locexpr_read_variable): Update.
1569         (locexpr_get_symbol_read_needs): Update.
1570         (loclist_read_variable): Update.
1571
1572 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1573
1574         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
1575         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1576         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1577         parameter.
1578         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
1579         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1580         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1581         parameter.
1582         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
1583         sect_variable_value): Add dwarf2_per_objfile parameter.
1584         (class dwarf_evaluate_loc_desc) <dwarf_call,
1585         dwarf_variable_value>: Update.
1586         (fetch_const_value_from_synthetic_pointer): Add
1587         dwarf2_per_objfile parameter.
1588         (fetch_const_value_from_synthetic_pointer): Update.
1589         (coerced_pieced_ref): Update.
1590         (class symbol_needs_eval_context) <dwarf_call,
1591         dwarf_variable_value>: Update.
1592         (dwarf2_compile_expr_to_ax): Update.
1593
1594 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1595
1596         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
1597         parameter.
1598         (dwarf2_evaluate_loc_desc_full): Update.
1599
1600 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1601
1602         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
1603         parameter.
1604         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
1605         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
1606         dwarf2_per_objfile parameter.
1607         (decode_debug_loc_dwo_addresses): Likewise.
1608         (dwarf2_find_location_expression): Update.
1609         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
1610         (locexpr_describe_location_piece): Add dwarf2_per_objfile
1611         parameter.
1612         (disassemble_dwarf_expression): Add dwarf2_per_objfile
1613         parameter.
1614         (locexpr_describe_location_1): Likewise.
1615         (locexpr_describe_location): Update.
1616
1617 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1618
1619         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
1620         Remove.
1621         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
1622         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
1623         (dwarf2_compile_property_to_c): Update.
1624         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
1625         use text offset from objfile.
1626         (locexpr_tracepoint_var_ref): Update.
1627         (locexpr_generate_c_location): Update.
1628         (loclist_describe_location): Update.
1629         (loclist_tracepoint_var_ref): Update.
1630         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
1631         dwarf2_per_objfile parameter.
1632         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
1633         use text offset from objfile.
1634         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
1635
1636 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1637
1638         * dwarf2/expr.h (struct dwarf_expr_context)
1639         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
1640         <offset>: Remove.
1641         <per_objfile>: New member.
1642         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
1643         dwarf2_per_objfile parameter.  Don't set offset, set
1644         per_objfile.
1645         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
1646         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
1647         a dwarf2_per_objfile object instead of an offset.
1648         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
1649         constructor.
1650         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
1651         to dwarf2_expr_executor constructor.  Don't set offset.
1652         (dwarf2_fetch_cfa_info): Update.
1653         (struct dwarf2_frame_cache) <text_offset>: Remove.
1654         <per_objfile>: New field.
1655         (dwarf2_frame_cache): Update.
1656         (dwarf2_frame_prev_register): Update.
1657         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1658         <dwarf_evaluate_loc_desc>: Add constructor.
1659         (dwarf2_evaluate_loc_desc_full): Update.
1660         (dwarf2_locexpr_baton_eval): Update.
1661         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
1662         Add constructor.
1663         (dwarf2_loc_desc_get_symbol_read_needs): Update.
1664
1665 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1666
1667         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
1668         addr_sized_int_type>: Move to dwarf2_cu.
1669         <int_type>: Move to dwarf2_per_objfile.
1670         (struct dwarf2_per_objfile) <int_type>: Move here.
1671         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
1672         addr_sized_int_type>: Move here.
1673         (read_func_scope): Update.
1674         (read_array_type): Update.
1675         (read_tag_string_type): Update.
1676         (attr_to_dynamic_prop): Update.
1677         (dwarf2_per_cu_data::int_type): Rename to...
1678         (dwarf2_per_objfile::int_type): ... this.
1679         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
1680         (dwarf2_cu::addr_sized_int_type): ... this.
1681         (read_subrange_type): Update.
1682         (dwarf2_per_cu_data::addr_type): Rename to...
1683         (dwarf2_cu::addr_type): ... this.
1684         (set_die_type): Update.
1685
1686 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1687
1688         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
1689         data through per_cu->cu.
1690
1691 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1692
1693         * dwarf2/read.c (lookup_dwo_comp_unit): Change
1694         dwarf2_per_cu_data parameter fo dwarf2_cu.
1695         (lookup_dwo_type_unit): Likewise.
1696         (read_cutu_die_from_dwo): Likewise.
1697         (lookup_dwo_unit): Likewise.
1698         (open_and_init_dwo_file): Likewise.
1699         (lookup_dwo_cutu): Likewise.
1700         (lookup_dwo_comp_unit): Likewise.
1701         (lookup_dwo_type_unit): Likewise.
1702         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1703         (cutu_reader::cutu_reader): Update.
1704
1705 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1706
1707         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
1708         parameter.
1709         (process_full_type_unit): Likewise.
1710         (process_queue): Update.
1711
1712 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1713
1714         * dwarf2/read.c (recursively_compute_inclusions): Add
1715         dwarf2_per_objfile parameter.
1716         (compute_compunit_symtab_includes): Likewise.
1717         (process_cu_includes): Update.
1718
1719 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1720
1721         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
1722         parameter.
1723         (create_type_unit_group): Update.
1724         (process_psymtab_comp_unit_reader): Update.
1725         (build_type_psymtabs_reader): Update.
1726
1727 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1728
1729         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
1730         object through m_this_cu->cu.
1731
1732 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1733
1734         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
1735         the info parameter.
1736         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
1737
1738 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1739
1740         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
1741         per_objfile parameter.
1742         (load_full_type_unit): Add per_objfile parameter.
1743         (read_signatured_type): Likewise.
1744         (load_full_comp_unit): Likewise.
1745         (load_cu): Likewise.
1746         (dw2_do_instantiate_symtab): Likewise.
1747         (dw2_get_file_names): Likewise.
1748         (dw2_map_symtabs_matching_filename): Update.
1749         (dw_expand_symtabs_matching_file_matcher): Update.
1750         (dw2_map_symbol_filenames): Update.
1751         (process_psymtab_comp_unit): Add per_objfile parameter.
1752         (build_type_psymtabs_1): Update.
1753         (process_skeletonless_type_unit): Update.
1754         (dwarf2_build_psymtabs_hard): Update.
1755         (load_partial_comp_unit): Add per_objfile parameter.
1756         (scan_partial_symbols): Update.
1757         (load_full_comp_unit): Add per_objfile parameter.
1758         (process_imported_unit_die): Update.
1759         (create_cus_hash_table): Update.
1760         (find_partial_die): Update.
1761         (dwarf2_read_addr_index): Update.
1762         (follow_die_offset): Update.
1763         (dwarf2_fetch_die_loc_sect_off): Update.
1764         (dwarf2_fetch_constant_bytes): Update.
1765         (dwarf2_fetch_die_type_sect_off): Update.
1766         (follow_die_sig_1): Update.
1767         (load_full_type_unit): Add per_objfile parameter.
1768         (read_signatured_type): Likewise.
1769
1770 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1771
1772         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
1773         of objfile_name.
1774
1775 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1776
1777         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
1778         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1779         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
1780         field.
1781         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1782         (create_cus_from_index): Update.
1783         (dwarf2_read_gdb_index): Update.
1784         (create_cus_from_debug_names): Update.
1785         (dwarf2_read_debug_names): Update.
1786         (get_abbrev_section_for_cu): Update.
1787         (create_all_comp_units): Update.
1788         (read_attribute_value): Update.
1789         (get_debug_line_section): Update.
1790         * dwarf2/index-cache.c (index_cache::store): Update.
1791         * dwarf2/index-write.c (save_gdb_index_command): Update.
1792         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
1793
1794 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1795
1796         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
1797         member.
1798         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
1799         dwarf2_per_cu_data::per_bfd.
1800         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
1801         (create_type_unit_group): Likewise.
1802         (queue_comp_unit): Remove reference to
1803         per_cu->dwarf2_per_objfile.
1804         (maybe_queue_comp_unit): Likewise.
1805         (fill_in_sig_entry_from_dwo_entry): Assign new field.
1806         (create_cus_hash_table): Assign new field.
1807
1808 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1809
1810         * dwarf2/read.c: Replace
1811         dwarf2_cu->per_cu->dwarf2_per_objfile references with
1812         dwarf2_cu->per_objfile throughout.
1813
1814 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1815
1816         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
1817         parameter, don't use per_cu->dwarf2_per_objfile.
1818         (dw2_instantiate_symtab): Likewise.
1819         (dw2_find_last_source_symtab): Update.
1820         (dw2_map_expand_apply): Update.
1821         (dw2_lookup_symbol): Update.
1822         (dw2_expand_symtabs_for_function): Update.
1823         (dw2_expand_all_symtabs): Update.
1824         (dw2_expand_symtabs_with_fullname): Update.
1825         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
1826         don't use per_cu->dwarf2_per_objfile.
1827         (dw2_expand_marked_cus): Update.
1828         (dw2_find_pc_sect_compunit_symtab): Update.
1829         (dw2_debug_names_lookup_symbol): Update.
1830         (dw2_debug_names_expand_symtabs_for_function): Update.
1831         (dw2_debug_names_map_matching_symbols): Update.
1832         (dwarf2_psymtab::expand_psymtab): Update.
1833
1834 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1835
1836         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
1837         <per_objfile>: New member.
1838         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
1839         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
1840         call to dwarf2_cu.
1841         (cutu_reader::cutu_reader): Update.
1842         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
1843
1844 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1845
1846         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
1847         struct dwarf2_per_objfile.
1848         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
1849         dwarf2_per_bfd.
1850         * dwarf2/read.c (set_die_type): Update.
1851         (get_die_type_at_offset): Update.
1852
1853 2020-05-27  Tom Tromey  <tom@tromey.com>
1854             Simon Marchi  <simon.marchi@efficios.com>
1855
1856         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
1857         method.
1858         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
1859         get_symtab, set_symtab>: New methods.
1860         <m_symtabs>: New field.
1861         (struct dwarf2_psymtab): Derive from partial_symtab.
1862         <readin_p, get_compunit_symtab>: Declare methods.
1863         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
1864         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
1865         New methods.
1866         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
1867         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
1868         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
1869         (dw2_symtab_iter_next, dw2_print_stats)
1870         (dw2_expand_symtabs_with_fullname)
1871         (dw2_expand_symtabs_matching_one)
1872         (dw_expand_symtabs_matching_file_matcher)
1873         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
1874         (dw2_debug_names_iterator::next)
1875         (dw2_debug_names_map_matching_symbols)
1876         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
1877         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
1878         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
1879         New methods.
1880         (get_compunit_symtab, process_full_comp_unit)
1881         (process_full_type_unit): Update.
1882         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
1883
1884 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1885
1886         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
1887         then introduce a new dwarf2_per_objfile type.
1888         <read_line_string>: Move to the new dwarf2_per_objfile type.
1889         <objfile>: Likewise.
1890         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
1891         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
1892         dwarf2_per_objfile->per_bfd.
1893         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
1894         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
1895         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
1896         (dwarf2_per_bfd::free_cached_comp_units): ... this.
1897         (dwarf2_has_info): Allocate dwarf2_per_bfd.
1898         (dwarf2_per_objfile::locate_sections): Rename to...
1899         (dwarf2_per_bfd::locate_sections): ... this.
1900         (dwarf2_per_objfile::get_cutu): Rename to...
1901         (dwarf2_per_bfd::get_cutu): ... this.
1902         (dwarf2_per_objfile::get_cu): Rename to...
1903         (dwarf2_per_bfd::get_cu): ... this.
1904         (dwarf2_per_objfile::get_tu): Rename to...
1905         (dwarf2_per_bfd::get_tu): ... this.
1906         (dwarf2_per_objfile::allocate_per_cu): Rename to...
1907         (dwarf2_per_bfd::allocate_per_cu): ... this.
1908         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
1909         (dwarf2_per_bfd::allocate_signatured_type): ... this.
1910         (get_gdb_index_contents_ftype): Change parameter from
1911         dwarf2_per_objfile to dwarf2_per_bfd.
1912         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
1913         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
1914
1915 2020-05-27  Tom Tromey  <tom@tromey.com>
1916             Simon Marchi  <simon.marchi@efficios.com>
1917
1918         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
1919         (allocate_piece_closure): Set "per_objfile" member.
1920         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
1921         (locexpr_describe_location, loclist_describe_location): Use new
1922         member.
1923         * dwarf2/read.c (read_call_site_scope)
1924         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
1925         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
1926         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
1927         handle_data_member_location): Set per_objfile member.
1928         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
1929         member.
1930         (struct dwarf2_loclist_baton) <per_objfile>: New member.
1931
1932 2020-05-27  Tom Tromey  <tom@tromey.com>
1933
1934         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
1935         allocate_signatured_type>: Declare new methods.
1936         <m_num_psymtabs>: New member.
1937         (struct dwarf2_per_cu_data) <index>: New member.
1938         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
1939         (dwarf2_per_objfile::allocate_signatured_type): New methods.
1940         (create_cu_from_index_list): Use allocate_per_cu.
1941         (create_signatured_type_table_from_index)
1942         (create_signatured_type_table_from_debug_names)
1943         (create_debug_type_hash_table, add_type_unit)
1944         (read_comp_units_from_section): Use allocate_signatured_type.
1945
1946 2020-05-27  Tom Tromey  <tom@tromey.com>
1947
1948         * psymtab.c (partial_map_expand_apply)
1949         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1950         (psym_lookup_global_symbol_language)
1951         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1952         (psym_print_stats, psym_expand_symtabs_for_function)
1953         (psym_map_symbol_filenames, psym_map_matching_symbols)
1954         (psym_expand_symtabs_matching)
1955         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1956         (maintenance_check_psymtabs): Update.
1957         * psympriv.h (struct partial_symtab) <readin_p,
1958         get_compunit_symtab>: Add objfile parameter.
1959         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
1960         Likewise.
1961         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
1962         get_compunit_symtab>: Likewise.
1963         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
1964
1965 2020-05-27  Tom Tromey  <tom@tromey.com>
1966
1967         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
1968         member.
1969         * dwarf2/read.c (delete_file_name_entry): Fix comment.
1970         (create_cu_from_index_list)
1971         (create_signatured_type_table_from_index)
1972         (create_signatured_type_table_from_debug_names)
1973         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
1974         (dwarf2_create_include_psymtab)
1975         (create_debug_type_hash_table, add_type_unit)
1976         (create_type_unit_group, read_comp_units_from_section)
1977         (dwarf2_compute_name, create_cus_hash_table)
1978         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1979         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
1980         obstack.
1981         (dw2_get_real_path): Likewise.  Change argument to
1982         dwarf2_per_objfile.
1983
1984 2020-05-27  Luis Machado  <luis.machado@linaro.org>
1985
1986         PR tdep/26000
1987         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
1988         for ldrd (immediate).
1989
1990 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1991
1992         * command.h: Add comment giving the name of class_tui.
1993         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
1994         create the fake command for the help for class_tui.
1995
1996 2020-05-26  Tom Tromey  <tromey@adacore.com>
1997
1998         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
1999         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2000         (val_atr): New function.
2001         (value_val_atr): Use it.
2002         * ada-valprint.c (print_optional_low_bound): Change low bound
2003         handling for enums.
2004         (val_print_packed_array_elements): Don't call discrete_position.
2005         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2006         discrete_position for enum types.
2007         * language.c (default_print_array_index): Change type.
2008         * language.h (struct language_defn) <la_print_array_index>: Add
2009         index_type parameter, change type of index_value.
2010         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2011         (default_print_array_index): Update.
2012         * valprint.c (maybe_print_array_index): Don't call
2013         value_from_longest.  Update.
2014         (value_print_array_elements): Don't call discrete_position.
2015
2016 2020-05-26  Tom Tromey  <tromey@adacore.com>
2017
2018         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2019         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2020
2021 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2022
2023         PR gdb/13519
2024         * avr-tdep.c (avr_integer_to_address): Return data or code
2025         address accordingly to the second 'type' argument of the
2026         function.
2027
2028 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2029
2030         * infcmd.c, inferior.h: (construct_inferior_arguments):
2031         Moved function from here to gdbsupport/common-inferior.{h,cc}
2032
2033 2020-05-23  Tom Tromey  <tom@tromey.com>
2034
2035         Revert commit eca1f90c:
2036         * NEWS: Remove entry for completion styling.
2037         * completer.c (_rl_completion_prefix_display_length): Move
2038         declaration later.
2039         (gdb_fnprint): Revert.
2040         (gdb_display_match_list_1): Likewise.
2041         * cli/cli-style.c (completion_prefix_style)
2042         (completion_difference_style, completion_suffix_style): Remove.
2043         (_initialize_cli_style): Revert.
2044         * cli/cli-style.h (completion_prefix_style)
2045         (completion_difference_style, completion_suffix_style): Don't
2046         declare.
2047
2048 2020-05-24  Pedro Alves  <palves@redhat.com>
2049
2050         * symtab.c (completion_list_add_name): Return boolean indication
2051         of whether the symbol matched.
2052         (completion_list_add_symbol): Don't try to remove C++ aliases if
2053         the symbol didn't match in the first place.
2054         * symtab.h (completion_list_add_name): Return bool.
2055
2056 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2057
2058         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2059         type::field.
2060
2061 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2062
2063         GDB 9.2 released.
2064
2065 2020-05-23  Tom Tromey  <tom@tromey.com>
2066
2067         * NEWS: Add entry for completion styling.
2068         * completer.c (_rl_completion_prefix_display_length): Move
2069         declaration earlier.
2070         (gdb_fnprint): Use completion_style.
2071         (gdb_display_match_list_1): Likewise.
2072         * cli/cli-style.c (completion_prefix_style)
2073         (completion_difference_style, completion_suffix_style): New
2074         globals.
2075         (_initialize_cli_style): Register new globals.
2076         * cli/cli-style.h (completion_prefix_style)
2077         (completion_difference_style, completion_suffix_style): Declare.
2078
2079 2020-05-23  Pedro Alves  <palves@redhat.com>
2080
2081         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2082         (parse_escape): Use ISDIGIT instead of isdigit.
2083         (puts_debug): Use gdb_isprint instead of isprint.
2084         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2085         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
2086         ISSPACE instead of isspace.
2087         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
2088         instead of isspace.
2089         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
2090         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
2091         instead of isxdigit and ISDIGIT instead of isdigit.
2092
2093 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2094
2095         * gdbtypes.h (struct type) <field>: New method.
2096         (TYPE_FIELDS): Remove, replace all uses with either type::fields
2097         or type::field.
2098
2099 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2100
2101         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
2102         (TYPE_FIELDS): Use type::fields.  Change all call sites that
2103         modify the propery to use type::set_fields instead.
2104
2105 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2106
2107         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
2108         type::num_fields instead.
2109
2110 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2111
2112         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
2113         methods.
2114         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
2115         that modify the number of fields to use type::set_num_fields
2116         instead.
2117
2118 2020-05-22  Tom Tromey  <tromey@adacore.com>
2119
2120         * compile/compile-object-load.h (munmap_list_free): Don't
2121         declare.
2122
2123 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * annotate.c (annotate_source_line): Update return type, add call
2126         to update current symtab and line.
2127         * annotate.h (annotate_source_line): Update return type, and
2128         extend header comment.
2129         * source.c (info_line_command): Check annotation_level before
2130         calling annotate_source_line.
2131         * stack.c (print_frame_info): If calling annotate_source_line
2132         returns true, then don't print any other source line information.
2133
2134 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2135
2136         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
2137
2138 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2139
2140         * coffread.c (patch_type): Remove NULL check before xfree.
2141         * corefile.c (set_gnutarget): Likewise.
2142         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
2143         * exec.c (build_section_table): Likewise.
2144         * remote.c (remote_target::pass_signals): Likewise.
2145         * utils.c (n_spaces): Likewise.
2146         * cli/cli-script.c (document_command): Likewise.
2147         * i386-windows-tdep.c (core_process_module_section): Likewise.
2148         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
2149
2150 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
2151
2152         * symfile.c (reread_symbols): Clear objfile's section_offsets
2153         vector and section indices, re-compute them by calling
2154         sym_offsets.
2155
2156 2020-05-20  Tom Tromey  <tromey@adacore.com>
2157
2158         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
2159         (desc_one_bound, desc_index_type): Compute field name.
2160
2161 2020-05-20  Tom de Vries  <tdevries@suse.de>
2162
2163         PR symtab/25833
2164         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
2165
2166 2020-05-20  Alan Modra  <amodra@gmail.com>
2167
2168         PR 25993
2169         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
2170         bfd_set_filename.
2171         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
2172         passed to bfd_set_filename.
2173         * symfile-mem.c (add_vsyscall_page): Likewise for string
2174         passed to symbol_file_add_from_memory.
2175         (symbol_file_add_from_memory): Make name param a const char* and
2176         don't strdup.
2177
2178 2020-05-20  Alan Modra  <amodra@gmail.com>
2179
2180         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
2181         rather than accessing bfd->filename directly.
2182         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
2183         and use bfd_section_name.
2184         * dwarf2/frame.c (decode_frame_entry): Likewise.
2185         * exec.c (exec_set_section_address): Likewise.
2186         * solib-aix.c (solib_aix_bfd_open): Likewise.
2187         * stap-probe.c (get_stap_base_address): Likewise.
2188         * symfile.c (reread_symbols): Likewise.
2189
2190 2020-05-19  Tom Tromey  <tromey@adacore.com>
2191
2192         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
2193
2194 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2195
2196         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
2197
2198 2020-05-19  Pedro Alves  <palves@redhat.com>
2199
2200         * NEWS (set exec-file-mismatch): Adjust entry.
2201         * exec.c: Include "build-id.h".
2202         (validate_exec_file): Try to match build IDs instead of filenames.
2203         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
2204         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
2205         and pass down 'warn_if_slow'.
2206         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
2207         gdb_bfd_open_closure to pass it down.
2208         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
2209
2210 2020-05-19  Pedro Alves  <palves@redhat.com>
2211
2212         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
2213         * target.c (target_fileio_open_1): Rename to target_fileio_open
2214         and make extern.  Use bool.
2215         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
2216         (target_fileio_read_alloc_1): Adjust.
2217         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
2218         (target_fileio_open_warn_if_slow): Delete declaration.
2219
2220 2020-05-19  Pedro Alves  <palves@redhat.com>
2221
2222         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
2223         Adjust all callers.
2224
2225 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
2226
2227         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
2228         whether disp is negative.
2229
2230 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2231
2232         * symfile.h (struct symfile_segment_data)
2233         <~symfile_segment_data>: Remove.
2234         <segment_info>: Change to std::vector.
2235         * symfile.c (default_symfile_segments): Update.
2236         * elfread.c (elf_symfile_segments): Update.
2237
2238 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2239
2240         * symfile.h (struct symfile_segment_data) <struct segment>: New.
2241         <segments>: New.
2242         <segment_bases, segment_sizes>: Remove.
2243         * symfile.c (default_symfile_segments): Update.
2244         * elfread.c (elf_symfile_segments): Update.
2245         * remote.c (remote_target::get_offsets): Update.
2246         * solib-target.c (solib_target_relocate_section_addresses):
2247         Update.
2248
2249 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2250
2251         * symfile.h (struct symfile_segment_data): Initialize fields.
2252         <~symfile_segment_data>: Add.
2253         (symfile_segment_data_up): New.
2254         (struct sym_fns) <sym_segments>: Return a
2255         symfile_segment_data_up.
2256         (default_symfile_segments): Return a symfile_segment_data_up.
2257         (free_symfile_segment_data): Remove.
2258         (get_symfile_segment_data): Return a symfile_segment_data_up.
2259         * symfile.c (default_symfile_segments): Likewise.
2260         (get_symfile_segment_data): Likewise.
2261         (free_symfile_segment_data): Remove.
2262         (symfile_find_segment_sections): Update.
2263         * elfread.c (elf_symfile_segments): Return a
2264         symfile_segment_data_up.
2265         * remote.c (remote_target::get_offsets): Update.
2266         * solib-target.c (solib_target_relocate_section_addresses):
2267         Update.
2268         * symfile-debug.c (debug_sym_segments): Return a
2269         symfile_segment_data_up.
2270
2271 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2272
2273         PR build/25981
2274         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
2275         Hardcode register numbers.
2276
2277         PR build/25981
2278         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
2279         procfs_find_LDT_entry): Remove.
2280         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
2281         procfs_find_LDT_entry): Remove.
2282         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
2283         Remove.
2284
2285 2020-05-17  Pedro Alves  <palves@redhat.com>
2286             Andrew Burgess  <andrew.burgess@embecosm.com>
2287             Keno Fischer  <keno@juliacomputing.com>
2288
2289         PR gdb/25741
2290         * breakpoint.c (build_target_condition_list): Update comments.
2291         (build_target_command_list): Update comments and skip matching
2292         locations.
2293         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
2294         a separate function.  Simplify "set breakpoint auto-hw off"
2295         handling.
2296         (insert_breakpoints): Update comment.
2297         (tracepoint_locations_match): New parameter.  For breakpoints,
2298         compare location types too, if the caller wants to.
2299         (handle_automatic_hardware_breakpoints): New functions.
2300         (bp_location_is_less_than): Also sort by location type and
2301         hardware breakpoint length.
2302         (update_global_location_list): Handle "set breakpoint auto-hw on"
2303         here.
2304         (update_breakpoint_locations): Ask breakpoint_locations_match to
2305         ignore location types.
2306
2307 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2308
2309         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
2310         type::name instead.
2311
2312 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2313
2314         * gdbtypes.h (struct type) <name, set_name>: New methods.
2315         (TYPE_CODE): Use type::name.  Change all call sites used to set
2316         the name to use type::set_name instead.
2317
2318 2020-05-16  Tom Tromey  <tom@tromey.com>
2319
2320         * top.c (quit_force): Update.
2321         * infrun.c (handle_no_resumed): Update.
2322         * top.h (all_uis): New function.
2323         (ALL_UIS): Remove.
2324
2325 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2326
2327         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
2328
2329 2020-05-16  Pedro Alves  <palves@redhat.com>
2330
2331         * ia64-linux-nat.c
2332         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
2333         Declare method.
2334         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
2335
2336 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
2337
2338         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
2339         (sparc64_adi_info): Likewise.
2340
2341 2020-05-15  Tom Tromey  <tom@tromey.com>
2342
2343         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
2344         block_objfile.
2345         (lookup_objfile_from_block): Remove.
2346         (lookup_symbol_in_block, lookup_symbol_in_static_block)
2347         (lookup_global_symbol): Use block_objfile.
2348         * symtab.h (lookup_objfile_from_block): Don't declare.
2349         * printcmd.c (clear_dangling_display_expressions): Use
2350         block_objfile.
2351         * parse.c (operator_check_standard): Use block_objfile.
2352
2353 2020-05-15  Tom Tromey  <tom@tromey.com>
2354
2355         * language.c (language_alloc_type_symbol): Set
2356         SYMBOL_SECTION.
2357         * symtab.c (initialize_objfile_symbol): Remove.
2358         (allocate_symbol): Remove.
2359         (allocate_template_symbol): Remove.
2360         * dwarf2/read.c (fixup_go_packaging): Use "new".
2361         (new_symbol): Use "new".
2362         (read_variable): Don't call initialize_objfile_symbol.  Use
2363         "new".
2364         (read_func_scope): Use "new".
2365         * xcoffread.c (process_xcoff_symbol): Don't call
2366         initialize_objfile_symbol.
2367         (SYMBOL_DUP): Remove.
2368         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
2369         "new".
2370         * symtab.h (allocate_symbol, initialize_objfile_symbol)
2371         (allocate_template_symbol): Don't declare.
2372         (struct symbol): Add copy constructor.  Change defaults.
2373         * jit.c (finalize_symtab): Use "new".
2374         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
2375         Use "new".
2376         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
2377         (common_block_end): Use "new".
2378         * mdebugread.c (parse_symbol): Use "new".
2379         (new_symbol): Likewise.
2380
2381 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2382
2383         * NEWS: Mention changes to help and apropos.
2384
2385 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2386
2387         * command.h (enum command_class): Improve comments, document
2388         that class_alias is for user-defined aliases, give the class
2389         name for each class, remove unused class_xdb.
2390         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
2391         * breakpoint.c (_initialize_breakpoint): Replace class_alias
2392         by a precise class.
2393         * infcmd.c (_initialize_infcmd): Likewise.
2394         * reverse.c (_initialize_reverse): Likewise.
2395         * stack.c (_initialize_stack): Likewise.
2396         * symfile.c (_initialize_symfile): Likewise.
2397         * tracepoint.c (_initialize_tracepoint): Likewise.
2398
2399 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2400
2401         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
2402         when their aliased command is traversed.
2403         (help_cmd): Add fput_command_names_styled call to
2404         output command name and aliases when command has an alias.
2405
2406 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2407
2408         * cli/cli-decode.h (help_cmd_list): Remove declaration.
2409         * cli/cli-decode.c (help_cmd_list): Declare as static,
2410         remove prefix argument, use bool for recurse arg, rework to show the aliases of
2411         a command together with the command.
2412         (fput_command_name_styled, fput_command_names_styled): New functions.
2413         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
2414         fput_command_name_styled.
2415         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
2416         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
2417
2418 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2419
2420         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
2421         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
2422         * command.h (cmd_show_list): Likewise.
2423         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
2424         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
2425
2426 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2427
2428         * unittests/command-def-selftests.c (traverse_command_structure):
2429         Verify all commands of a list have the same prefix command and
2430         that only the top cmdlist commands have a null prefix.
2431
2432 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2433
2434         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
2435         as prefix, not one of its aliases.
2436         (set_cmd_prefix): Remove.
2437         (do_add_cmd): Centralize the setting of the prefix of a command, when
2438         command is defined after its full chain of prefix commands.
2439         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
2440         (add_setshow_cmd_full): Likewise.
2441         (update_prefix_field_of_prefixed_commands): New function.
2442         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
2443         update_prefix_field_of_prefixed_commands.
2444         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
2445         addresses of remote_set_cmdlist and remote_show_cmdlist given
2446         as argument, not the address of an argument.
2447         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
2448         * gdb/remote.c (_initialize_remote): Likewise.
2449
2450 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2451
2452         * cli/cli-cmds.c (alias_command): Check for an existing alias
2453         using lookup_cmd_composition, as valid_command_p is too strict
2454         and forbids aliases that are the prefix of an existing alias
2455         or command.
2456         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
2457         command is properly recognised as a valid command.
2458
2459 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2460
2461         * unittests/help-doc-selftests.c: Rename to
2462         unittests/command-def-selftests.c
2463         * unittests/command-def-selftests.c (help_doc_tests): Update some
2464         comments.
2465         (command_structure_tests, traverse_command_structure): New namespace
2466         and function.
2467         (command_structure_invariants_tests): New function.
2468         (_initialize_command_def_selftests) Renamed from
2469         _initialize_help_doc_selftests, register command_structure_invariants
2470         selftest.
2471
2472 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2473
2474         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
2475         an alias of 'show'.
2476
2477 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
2478
2479         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
2480         ada_is_fixed_point_type.  Update all callers.
2481         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
2482         all callers.
2483         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
2484         Update all callers.
2485         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
2486         print_fixed_point_type.  Update all callers.
2487         * ada-valprint.c (ada_value_print_num): Replace call to
2488         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
2489
2490 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
2491
2492         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
2493         processors.
2494         (cpu_supports_bts): Add CV_AMD case.
2495
2496 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
2497             Simon Marchi  <simon.marchi@efficios.com>
2498
2499         * infrun.c (stop_all_threads): Collect multiple wait events at
2500         each pass.
2501
2502 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2503
2504         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
2505         type::code instead.
2506
2507 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2508
2509         * gdbtypes.h (struct type) <code, set_code>: New methods.
2510         (TYPE_CODE): Use type::code.  Change all call sites used to set
2511         the code to use type::set_code instead.
2512
2513 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2514             Tom de Vries  <tdevries@suse.de>
2515             Pedro Alves  <palves@redhat.com>
2516
2517         PR threads/25478
2518         * infrun.c (stop_all_threads): Do NOT ignore
2519         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
2520         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
2521         received.
2522         (handle_no_resumed): Remove code handling a live inferior with no
2523         threads.
2524         * remote.c (has_single_non_exited_thread): New.
2525         (remote_target::update_thread_list): Do not delete a thread if is
2526         the last thread of the process.
2527         * thread.c (thread_select): Call delete_exited_threads instead of
2528         prune_threads.
2529
2530 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2531
2532         * infrun.c (stop_all_threads): Enable/disable thread events of all
2533         targets.  Move a debug message denoting the end of the function
2534         into the SCOPED_EXIT block.
2535
2536 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2537
2538         * process-stratum-target.h: Include <set>.
2539         (all_non_exited_process_targets, switch_to_target_no_thread): New
2540         function declarations.
2541         * process-stratum-target.c (all_non_exited_process_targets)
2542         (switch_to_target_no_thread): New function implementations.
2543
2544 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2545
2546         * infrun.c (handle_inferior_event): Extract out a piece of code
2547         into...
2548         (mark_non_executing_threads): ...this new function.
2549
2550 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2551
2552         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
2553         use.
2554
2555 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2556
2557         * regcache.c (regcache_read_pc_protected): New function
2558         implementation that returns 0 if the PC cannot read via
2559         'regcache_read_pc'.
2560         * infrun.c (proceed): Call 'regcache_read_pc_protected'
2561         instead of 'regcache_read_pc'.
2562         (keep_going_pass_signal): Ditto.
2563
2564 2020-05-13  Tom Tromey  <tromey@adacore.com>
2565
2566         * ada-lang.c (align_value): Remove.
2567         (ada_template_to_fixed_record_type_1): Use align_up.
2568
2569 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2570
2571         * async-event.c: Update the copyright year.
2572         * async-event.h: Update the copyright year.
2573
2574 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
2575
2576         * objfiles.h (is_addr_in_objfile,
2577         shared_objfile_contains_address_p): Return bool.
2578         * objfile.c (is_addr_in_objfile,
2579         shared_objfile_contains_address_p): Return bool.
2580
2581 2020-05-11  Tom Tromey  <tromey@adacore.com>
2582
2583         * cli/cli-cmds.c (info_command): Restore.
2584         (_initialize_cli_cmds): Use add_prefix_command for "info".
2585         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
2586
2587 2020-05-11  Tom Tromey  <tromey@adacore.com>
2588
2589         * ada-lang.c (ada_value_primitive_field): Now public.
2590         * ada-lang.h (ada_value_primitive_field): Declare.
2591         * ada-valprint.c (print_field_values): Use
2592         ada_value_primitive_field for wrapper fields.
2593
2594 2020-05-11  Tom de Vries  <tdevries@suse.de>
2595
2596         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
2597         MODULE_DOMAIN.
2598
2599 2020-05-11  Tom de Vries  <tdevries@suse.de>
2600
2601         PR symtab/25941
2602         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
2603         with length 0, if not gdb-produced.
2604         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
2605
2606 2020-05-09  Tom de Vries  <tdevries@suse.de>
2607
2608         PR gdb/25955
2609         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
2610         calculation.
2611
2612 2020-05-09  Tom Tromey  <tom@tromey.com>
2613
2614         * top.c (server_command): Now bool.
2615         * top.h (server_command): Now bool.
2616
2617 2020-05-08  Tom Tromey  <tromey@adacore.com>
2618
2619         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
2620         already being processed.
2621
2622 2020-05-08  Tom Tromey  <tom@tromey.com>
2623
2624         * printcmd.c (struct display) <next>: Remove.
2625         <display>: New constructor.
2626         <exp_string>: Now a std::string.
2627         <enabled_p>: Now a bool.
2628         (display_number): Move definition earlier.
2629         (displays): Rename from display_chain.  Now a std::vector.
2630         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
2631         (display_command): Update.
2632         (do_one_display, disable_display)
2633         (enable_disable_display_command, do_enable_disable_display):
2634         Update.
2635         (free_display): Remove.
2636         (clear_displays): Rewrite.
2637         (delete_display): Update.
2638         (map_display_numbers): Use function_view.  Remove "data"
2639         parameter.  Update.
2640         (do_delete_display): Remove.
2641         (undisplay_command): Update.
2642         (do_one_display, do_displays, disable_display)
2643         (info_display_command): Update.
2644         (do_enable_disable_display): Remove.
2645         (enable_disable_display_command)
2646         (clear_dangling_display_expressions): Update.
2647
2648 2020-05-08  Tom Tromey  <tom@tromey.com>
2649
2650         * symtab.c (set_symbol_cache_size)
2651         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
2652         (maintenance_print_symbol_cache_statistics): Update.
2653         * symmisc.c (print_symbol_bcache_statistics)
2654         (print_objfile_statistics, maintenance_print_objfiles)
2655         (maintenance_info_symtabs, maintenance_check_symtabs)
2656         (maintenance_expand_symtabs, maintenance_info_line_tables):
2657         Update.
2658         * symfile-debug.c (set_debug_symfile): Update.
2659         * source.c (forget_cached_source_info): Update.
2660         * python/python.c (gdbpy_progspaces): Update.
2661         * psymtab.c (maintenance_info_psymtabs): Update.
2662         * probe.c (parse_probes): Update.
2663         * linespec.c (iterate_over_all_matching_symtabs)
2664         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
2665         * guile/scm-progspace.c (gdbscm_progspaces): Update.
2666         * exec.c (exec_target::close): Update.
2667         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
2668         * breakpoint.c (print_one_breakpoint_location)
2669         (create_longjmp_master_breakpoint)
2670         (create_std_terminate_master_breakpoint): Update.
2671         * progspace.c (program_spaces): Now a std::vector.
2672         (maybe_new_address_space): Update.
2673         (add_program_space): Remove.
2674         (program_space::program_space): Update.
2675         (remove_program_space): Update.
2676         (number_of_program_spaces): Remove.
2677         (print_program_space, update_address_spaces): Update.
2678         * progspace.h (program_spaces): Change type.
2679         (ALL_PSPACES): Remove.
2680         (number_of_program_spaces): Don't declare.
2681         (struct program_space) <next>: Remove.
2682
2683 2020-05-08  Tom Tromey  <tom@tromey.com>
2684
2685         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
2686         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
2687         (enable_break): Update.
2688         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
2689         (frv_fdpic_find_canonical_descriptor): Update.
2690         (frv_fetch_objfile_link_map): Update.
2691         * progspace.c (program_space::free_all_objfiles): Update.
2692         (program_space::solibs): New method.
2693         * progspace.h (struct program_space) <solibs>: New method.
2694         * solist.h (master_so_list): Don't declare.
2695         (ALL_SO_LIBS): Remove.
2696         * solib.h (so_list_head): Remove.
2697         (update_solib_list): Update comment.
2698         * solib.c (master_so_list): Remove.
2699         (solib_used, update_solib_list, solib_add)
2700         (info_sharedlibrary_command, clear_solib)
2701         (reload_shared_libraries_1, remove_user_added_objfile): Update.
2702
2703 2020-05-08  Tom Tromey  <tom@tromey.com>
2704
2705         * extension.c (extension_languages): Now a std::array.
2706         (ALL_EXTENSION_LANGUAGES): Remove.
2707         (get_ext_lang_defn, get_ext_lang_of_file)
2708         (eval_ext_lang_from_control_command): Update.
2709         (finish_ext_lang_initialization)
2710         (auto_load_ext_lang_scripts_for_objfile)
2711         (ext_lang_type_printers::ext_lang_type_printers)
2712         (apply_ext_lang_type_printers)
2713         (ext_lang_type_printers::~ext_lang_type_printers)
2714         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
2715         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
2716         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
2717         (get_matching_xmethod_workers, ext_lang_colorize)
2718         (ext_lang_before_prompt): Update.
2719         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
2720
2721 2020-05-08  Tom Tromey  <tom@tromey.com>
2722
2723         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
2724         overload.
2725         <swap_string, m_string>: Remove.
2726         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
2727         Update.
2728         * stabsread.c (define_symbol, read_type): Update.
2729         * linespec.c (find_linespec_symbols): Update.
2730         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
2731         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
2732         * dbxread.c (read_dbx_symtab): Update.
2733         * cp-support.h (cp_canonicalize_string_full)
2734         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
2735         Return unique_xmalloc_ptr.
2736         * cp-support.c (inspect_type): Update.
2737         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
2738         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
2739         Likewise.
2740         * c-typeprint.c (print_name_maybe_canonical): Update.
2741         * break-catch-throw.c (check_status_exception_catchpoint):
2742         Update.
2743
2744 2020-05-08  Tom de Vries  <tdevries@suse.de>
2745
2746         * infrun.c (follow_fork): Copy current_line and current_symtab to
2747         child thread.
2748
2749 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2750
2751         * async-event.c (struct async_signal_handler, struct
2752         async_event_handler): Reformat, remove typedef.
2753
2754 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2755
2756         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
2757         access thistype->main_type->dyn_prop_list directly.
2758
2759 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2760
2761         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
2762         (remove_dyn_prop): Remove.  Update all users to use
2763         type::remove_dyn_prop.
2764         * gdbtypes.c (remove_dyn_prop): Rename to...
2765         (type::remove_dyn_prop): ... this.
2766
2767 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
2768
2769         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
2770         (add_dyn_prop): Remove.  Update all users to use
2771         type::add_dyn_prop.
2772         * gdbtypes.c (add_dyn_prop): Rename to...
2773         (type::add_dyn_prop): ... this.
2774
2775 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2776
2777         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
2778         (get_dyn_prop): Remove.  Update all users to use
2779         type::dyn_prop.
2780         * gdbtypes.c (get_dyn_prop): Rename to...
2781         (type::dyn_prop): ... this.
2782
2783 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2784
2785         * gdbtypes.h (struct main_type) <flag_static>: Remove.
2786
2787 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2788
2789         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
2790         instruction, skip it if it's there.
2791
2792 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
2793
2794         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
2795
2796 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
2797
2798         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
2799         * gdbtypes.c (recursive_dump_type): Remove use of
2800         TYPE_INCOMPLETE.
2801
2802 2020-05-03  Tom Tromey  <tom@tromey.com>
2803
2804         * breakpoint.c (catch_command, tcatch_command): Remove.
2805         (_initialize_breakpoint): Use add_basic_prefix_cmd,
2806         add_show_prefix_cmd.
2807         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
2808         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
2809         Remove.
2810         (add_internal_problem_command): Use add_basic_prefix_cmd,
2811         add_show_prefix_cmd.
2812         * mips-tdep.c (set_mipsfpu_command): Remove.
2813         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
2814         * dwarf2/index-cache.c (set_index_cache_command): Remove.
2815         (_initialize_index_cache): Use add_basic_prefix_cmd.
2816         * memattr.c (dummy_cmd): Remove.
2817         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
2818         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
2819         (_initialize_tui_win): Use add_basic_prefix_cmd,
2820         add_show_prefix_cmd.
2821         * cli/cli-logging.c (set_logging_command): Remove.
2822         (_initialize_cli_logging): Use add_basic_prefix_cmd,
2823         add_show_prefix_cmd.
2824         (show_logging_command): Remove.
2825         * target.c (target_command): Remove.
2826         (add_target): Use add_basic_prefix_cmd.
2827
2828 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
2829
2830         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
2831
2832 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2833
2834         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
2835         info_command.
2836
2837 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
2838
2839         * nbsd-nat.c (nbsd_enable_proc_events)
2840         (nbsd_nat_target::post_startup_inferior): Add.
2841         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
2842         (nbsd_nat_target::update_thread_list): Rewrite.
2843         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
2844         "PTRACE_LWP_CREATE".
2845         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
2846
2847 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2848
2849         * stack.c (_initialize_stack): Remove duplicated creation
2850         of "frame" command and "f" alias.
2851
2852 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2853
2854         PR gdb/18706
2855         * gdbtypes.c (check_typedef): Calculate size of array of
2856         stubbed type.
2857
2858 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2859
2860         PR gdb/15559
2861         * i386-tdep.c (i386_push_dummy_call): Call
2862         i386_thiscall_push_dummy_call.
2863         (i386_thiscall_push_dummy_call): New function.
2864         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
2865         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
2866         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
2867
2868 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2869
2870         * gdbarch.sh (do_read): Add shellcheck disable directive for
2871         warning SC2162.
2872
2873 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2874
2875         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
2876         "referenced but not assigned" warning.
2877
2878 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2879
2880         * gdbarch.sh: Remove code that sets fallbackdefault.
2881
2882 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2883
2884         * gdbarch.sh: Use shell operators && and || instead of
2885         -a and -o.
2886
2887 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2888
2889         * gdbarch.sh: Use $(...) instead of `...`.
2890
2891 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2892
2893         * gdbarch.sh: Use double quotes around variables.
2894
2895 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2896
2897         * gdbarch.sh: Use %s with printf, instead of variables in the
2898         format string.
2899
2900 2020-04-29  Tom Tromey  <tromey@adacore.com>
2901
2902         PR ada/25875:
2903         * dwarf2/read.c (update_enumeration_type_from_children): Compute
2904         type fields here.
2905         (read_enumeration_type): Call
2906         update_enumeration_type_from_children later.  Update comments.
2907         (process_enumeration_scope): Don't create type fields.
2908
2909 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
2910
2911         * nbsd-tdep.c: Include "xml-syscall.h".
2912         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
2913
2914 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
2915
2916         * nbsd-nat.c: Include "sys/wait.h".
2917         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
2918         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
2919         (nbsd_nat_target::remove_exec_catchpoint)
2920         (nbsd_nat_target::set_syscall_catchpoint): Add.
2921         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
2922         (nbsd_nat_target::insert_exec_catchpoint)
2923         (nbsd_nat_target::remove_exec_catchpoint)
2924         (nbsd_nat_target::set_syscall_catchpoint): Add.
2925         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
2926         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
2927         `nbsd_get_syscall_number'.
2928
2929 2020-04-29  Tom Tromey  <tom@tromey.com>
2930
2931         * stack.c (print_block_frame_labels): Remove.
2932
2933 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
2934
2935         PR gdb/17320
2936         * ada-valprint.c (val_print_packed_array_elements): Move array
2937         end bracket to new line.
2938         (ada_val_print_string): Remove extra spaces before first array
2939         element.
2940         * c-valprint.c (c_value_print_array): Likewise.
2941         * m2-valprint.c (m2_print_array_contents): Likewise.
2942         (m2_value_print_inner): Likewise.
2943         * p-valprint.c (pascal_value_print_inner): Likewise.
2944         * valprint.c (generic_val_print_array): Likewise.
2945         (value_print_array_elements): Move first array element and array
2946         end bracket to new line.
2947
2948 2020-04-29  Tom de Vries  <tdevries@suse.de>
2949
2950         PR symtab/25889
2951         * linespec.c (find_method): Fix ix calculation.
2952
2953 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
2954
2955         * syscalls/update-netbsd.sh: New file.
2956         * syscalls/netbsd.xml: Regenerate.
2957         * data-directory/Makefile.in: Register `netbsd.xml' in
2958         `SYSCALLS_FILES'.
2959
2960 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
2961
2962         * syscalls/update-freebsd.sh: Add double quotes.
2963
2964 2020-04-28  Tom Tromey  <tom@tromey.com>
2965
2966         * NEWS: Update.
2967         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
2968         (cmdpy_init): Allow class_tui.
2969
2970 2020-04-28 Mark Williams <mark@myosotissp.com>
2971
2972         PR gdb/24480
2973         * dwarf2read.c: Add missing assingments to list_in_scope when
2974         start_symtab was already called.
2975
2976 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
2977
2978         PR gdb/25881
2979         * dwarf2/read.c (offset_map_type): Use
2980         gdb:hash_enum<sect_offset> as hash function.
2981
2982 2020-04-28  Tom de Vries  <tdevries@suse.de>
2983
2984         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
2985         with DW_AT_signature.
2986
2987 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
2988
2989         * configure.ac: Remove check for fs_base/gs_base in
2990         user_regs_struct.
2991         * configure: Re-generate.
2992         * config.in: Re-generate.
2993         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
2994         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
2995         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
2996
2997 2020-04-27  Luis Machado  <luis.machado@linaro.org>
2998
2999         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3000         problematic inline frame unwinding situation.
3001         * frame.c (frame_id_computed_p): New function.
3002         * frame.h (frame_id_computed_p): New prototype.
3003
3004 2020-04-26  Tom Tromey  <tom@tromey.com>
3005
3006         * command.h (enum command_class) <class_pseudo>: Remove.
3007
3008 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3009
3010         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3011         and whitespace.
3012
3013 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3014
3015         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3016         `PT_GET_PROCESS_STATE' block.
3017
3018 2020-04-24  Tom Tromey  <tom@tromey.com>
3019
3020         * symtab.h (symbol_get_demangled_name): Don't declare.
3021         * symtab.c (symbol_get_demangled_name): Remove.
3022         (general_symbol_info::natural_name)
3023         (general_symbol_info::demangled_name): Update.
3024
3025 2020-04-24  Tom Tromey  <tom@tromey.com>
3026
3027         PR rust/25025:
3028         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3029
3030 2020-04-24  Tom Tromey  <tom@tromey.com>
3031
3032         PR symtab/12707:
3033         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3034         exists.
3035         (new_symbol): Likewise.
3036         * compile/compile-object-load.c (get_out_value_type): Use
3037         symbol_matches_search_name.
3038
3039 2020-04-24  Tom Tromey  <tom@tromey.com>
3040
3041         * dwarf2/read.c (add_partial_symbol): Do not call
3042         compute_and_set_names.
3043
3044 2020-04-24  Tom Tromey  <tom@tromey.com>
3045
3046         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3047         overload.
3048
3049 2020-04-24  Tom Tromey  <tom@tromey.com>
3050
3051         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3052         (add_psymbol_to_list): New overload.  Make old overload call new
3053         one.
3054         * psympriv.h (add_psymbol_to_list): New overload.
3055
3056 2020-04-24  Tom Tromey  <tom@tromey.com>
3057
3058         * dwarf2/read.c (partial_die_info::read) <case
3059         DW_AT_linkage_name>: Use value_as_string.
3060         (dwarf2_string_attr): Use value_as_string.
3061         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3062         method.
3063         * dwarf2/attribute.c (attribute::value_as_string): New method.
3064
3065 2020-04-24  Tom Tromey  <tom@tromey.com>
3066
3067         * symtab.c (general_symbol_info::natural_name)
3068         (general_symbol_info::demangled_name): Check for language_rust.
3069
3070 2020-04-24  Tom Tromey  <tom@tromey.com>
3071
3072         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3073         (dwarf2_physname): ... from here.
3074         (partial_die_info::read): Add Rust "{" hack.
3075
3076 2020-04-24  Tom Tromey  <tom@tromey.com>
3077
3078         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3079         method.
3080         (symbol_set_demangled_name): Don't declare.
3081         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3082         symbol_set_demangled_name.
3083         (general_symbol_info::set_language)
3084         (general_symbol_info::compute_and_set_names): Update.
3085         * minsyms.c (minimal_symbol_reader::install): Update.
3086         * dwarf2/read.c (new_symbol): Update.
3087
3088 2020-04-24  Tom Tromey  <tromey@adacore.com>
3089
3090         PR python/23662:
3091         * python/py-type.c (convert_field): Handle
3092         FIELD_LOC_KIND_DWARF_BLOCK.
3093         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
3094         (typy_get_dynamic): Nw function.
3095         (type_object_getset): Add "dynamic".
3096         * NEWS: Add entry.
3097
3098 2020-04-24  Tom Tromey  <tromey@adacore.com>
3099
3100         * ada-typeprint.c (print_choices, print_variant_part)
3101         (print_record_field_types_dynamic): New functions.
3102         (print_record_field_types): Use print_record_field_types_dynamic.
3103
3104 2020-04-24  Tom Tromey  <tromey@adacore.com>
3105
3106         * dwarf2/read.c (handle_data_member_location): New overload.
3107         (dwarf2_add_field): Use it.
3108         (decode_locdesc): Add "computed" parameter.  Update comment.
3109         * gdbtypes.c (is_dynamic_type_internal): Also look for
3110         FIELD_LOC_KIND_DWARF_BLOCK.
3111         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
3112         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
3113         virtual base classes.
3114         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
3115         FIELD_LOC_KIND_DWARF_BLOCK.
3116
3117 2020-04-24  Tom Tromey  <tromey@adacore.com>
3118
3119         * dwarf2/read.c (read_structure_type): Handle dynamic length.
3120         * gdbtypes.c (is_dynamic_type_internal): Check
3121         TYPE_HAS_DYNAMIC_LENGTH.
3122         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
3123         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
3124         New macros.
3125         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
3126         constant.
3127
3128 2020-04-24  Tom Tromey  <tromey@adacore.com>
3129
3130         * dwarf2/read.c (struct variant_field): Rewrite.
3131         (struct variant_part_builder): New.
3132         (struct nextfield): Remove "variant" field.  Add "offset".
3133         (struct field_info): Add "current_variant_part" and
3134         "variant_parts".
3135         (alloc_discriminant_info): Remove.
3136         (alloc_rust_variant): New function.
3137         (quirk_rust_enum): Update.
3138         (dwarf2_add_field): Set "offset" member.  Don't handle
3139         DW_TAG_variant_part.
3140         (offset_map_type): New typedef.
3141         (convert_variant_range, create_one_variant)
3142         (create_one_variant_part, create_variant_parts)
3143         (add_variant_property): New functions.
3144         (dwarf2_attach_fields_to_type): Call add_variant_property.
3145         (read_structure_type): Don't handle DW_TAG_variant_part.
3146         (handle_variant_part, handle_variant): New functions.
3147         (handle_struct_member_die): Use them.
3148         (process_structure_scope): Don't handle variant parts.
3149         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
3150         (struct discriminant_info): Remove.
3151         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
3152         (struct main_type) <flag_discriminated_union>: Remove.
3153         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
3154         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
3155         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
3156         Update.
3157         * valops.c (value_union_variant): Remove.
3158         * value.h (value_union_variant): Don't declare.
3159
3160 2020-04-24  Tom Tromey  <tromey@adacore.com>
3161
3162         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
3163         (ada_value_primitive_packed_val): Update.
3164         * ada-valprint.c (ada_value_print_1): Update.
3165         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
3166         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
3167         just an address.  Use evaluate_for_locexpr_baton.
3168         (dwarf2_evaluate_property): Update.
3169         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
3170         array_view.
3171         * findvar.c (default_read_var_value): Update.
3172         * gdbtypes.c (compute_variant_fields_inner)
3173         (resolve_dynamic_type_internal): Update.
3174         (resolve_dynamic_type): Change type of valaddr parameter.
3175         * gdbtypes.h (resolve_dynamic_type): Update.
3176         * valarith.c (value_subscripted_rvalue): Update.
3177         * value.c (value_from_contents_and_address): Update.
3178
3179 2020-04-24  Tom Tromey  <tromey@adacore.com>
3180
3181         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
3182         "push_initial_value" parameter.
3183         (dwarf2_evaluate_property): Likewise.
3184         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
3185
3186 2020-04-24  Tom Tromey  <tromey@adacore.com>
3187
3188         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
3189         (variant::matches, compute_variant_fields_recurse)
3190         (compute_variant_fields_inner, compute_variant_fields): New
3191         functions.
3192         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
3193         Use resolved_type after type is made.
3194         (operator==): Add new cases.
3195         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
3196         (struct discriminant_range, struct variant, struct variant_part):
3197         New.
3198         (union dynamic_prop_data) <variant_parts, original_type>: New
3199         members.
3200         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
3201         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
3202         constants.
3203         * value.c (unpack_bits_as_long): Now public.
3204         * value.h (unpack_bits_as_long): Declare.
3205
3206 2020-04-24  Tom Tromey  <tromey@adacore.com>
3207
3208         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
3209         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
3210
3211 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
3212
3213         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
3214
3215 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
3216
3217         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
3218         (remove_fork_catchpoint, post_startup_inferior)
3219         (post_attach): Move...
3220         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
3221         (remove_fork_catchpoint, post_startup_inferior)
3222         (post_attach): ...here.
3223         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
3224         (remove_fork_catchpoint, post_startup_inferior)
3225         (post_attach): Move...
3226         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
3227         (remove_fork_catchpoint, post_startup_inferior)
3228         (post_attach): ...here.
3229
3230 2020-04-24  Tom Tromey  <tromey@adacore.com>
3231
3232         * nat/windows-nat.h (struct windows_thread_info)
3233         <pc_adjusted>: New member.
3234         * windows-nat.c (windows_fetch_one_register): Check
3235         pc_adjusted.
3236         (windows_nat_target::get_windows_debug_event)
3237         (windows_nat_target::wait): Set pc_adjusted.
3238
3239 2020-04-24  Tom de Vries  <tdevries@suse.de>
3240
3241         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
3242         Run gdb-add-index inside temp dir.
3243
3244 2020-04-23  Tom Tromey  <tromey@adacore.com>
3245
3246         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
3247         in loop.
3248
3249 2020-04-23  Luis Machado  <luis.machado@linaro.org>
3250
3251         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
3252         get_frame_register instead of gdbarch_unwind_pc.
3253
3254 2020-04-23  Tom de Vries  <tdevries@suse.de>
3255
3256         * symtab.c (lookup_global_symbol): Prefer def over decl.
3257
3258 2020-04-23  Tom de Vries  <tdevries@suse.de>
3259
3260         PR symtab/25807
3261         * block.c (best_symbol, better_symbol): Promote to external.
3262         * block.h (best_symbol, better_symbol): Declare.
3263         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
3264         decl.
3265
3266 2020-04-23  Tom Tromey  <tromey@adacore.com>
3267
3268         PR ada/25837:
3269         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
3270         "const char *", not a "const std::string &".
3271         <name_and_matcher::operator==>: Update.
3272         * unittests/lookup_name_info-selftests.c: Change type of
3273         "result".
3274
3275 2020-04-23  Tom Tromey  <tom@tromey.com>
3276
3277         * inferior.h (iterate_over_inferiors): Don't declare.
3278         * inferior.c (iterate_over_inferiors): Remove.
3279         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
3280         Remove.
3281         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
3282         use iterate_over_inferiors.
3283         (darwin_resume_inferior_it)
3284         (struct resume_inferior_threads_param)
3285         (darwin_resume_inferior_threads_it): Remove.
3286         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
3287
3288 2020-04-23  Tom de Vries  <tdevries@suse.de>
3289
3290         * blockframe.c (find_pc_partial_function): Use
3291         find_pc_sect_compunit_symtab rather than
3292         objfile->sf->qf->find_pc_sect_compunit_symtab.
3293
3294 2020-04-22  Tom de Vries  <tdevries@suse.de>
3295
3296         PR symtab/25764
3297         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
3298         in psymtabs.
3299
3300 2020-04-22  Tom de Vries  <tdevries@suse.de>
3301
3302         PR symtab/25801
3303         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
3304         symtabs.
3305
3306 2020-04-22  Tom de Vries  <tdevries@suse.de>
3307
3308         PR symtab/25700
3309         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
3310         CU if already created.
3311
3312 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3313
3314         * infrun.c (displaced_step_fixup): Switch to the event_thread
3315         before calling displaced_step_restore, not after.
3316
3317 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3318
3319         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
3320         its inferior is not recorded by us.
3321         (record_btrace_target_open): Replace call to
3322         all_non_exited_threads () with call to current_inferior
3323         ()->non_exited_threads ().
3324         (record_btrace_target::stop_recording): Likewise.
3325         (record_btrace_target::close): Likewise.
3326         (record_btrace_target::wait): Likewise.
3327         (record_btrace_target::record_stop_replaying): Likewise.
3328
3329 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3330
3331         * btrace.c (btrace_enable): Throw an error on double enables and
3332         when enabling recording fails.
3333         (btrace_disable): Throw an error if the thread is not recorded.
3334
3335 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3336
3337         * record-btrace.c (record_btrace_target::fetch_registers): Forward
3338         request if we do not have a thread_info.
3339
3340 2020-04-21  Tom de Vries  <tdevries@suse.de>
3341
3342         PR gdb/25471
3343         * thread.c
3344         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
3345         exception in get_frame_id.
3346
3347 2020-04-20  Tom Tromey  <tromey@adacore.com>
3348
3349         * python/python.c (struct gdbpy_event): Mark move constructor as
3350         noexcept.
3351         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
3352         constructor as noexcept.
3353         * completer.h (struct completion_result): Mark move constructor as
3354         noexcept.
3355         * completer.c (completion_result::completion_result): Use
3356         initialization style.  Don't call reset_match_list.
3357
3358 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
3359
3360         * MAINTAINERS (Write After Approval): Add myself.
3361
3362 2020-04-18  Tom Tromey  <tom@tromey.com>
3363
3364         * windows-tdep.c (init_w32_command_list)
3365         (w32_prefix_command_valid): Restore.
3366         (_initialize_windows_tdep): Call init_w32_command_list.
3367
3368 2020-04-18  Tom Tromey  <tom@tromey.com>
3369
3370         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
3371         * value.c (value_fn_field): Update.
3372         * valops.c (find_function_in_inferior)
3373         (value_allocate_space_in_inferior): Update.
3374         * tui/tui-winsource.c (tui_update_source_windows_with_line):
3375         Update.
3376         * tui/tui-source.c (tui_source_window::set_contents): Update.
3377         * symtab.c (lookup_global_or_static_symbol)
3378         (find_function_start_sal_1, skip_prologue_sal)
3379         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
3380         * symmisc.c (dump_msymbols, dump_symtab_1)
3381         (maintenance_print_one_line_table): Update.
3382         * symfile.c (init_entry_point_info, section_is_mapped)
3383         (list_overlays_command, simple_read_overlay_table)
3384         (simple_overlay_update_1): Update.
3385         * stap-probe.c (handle_stap_probe): Update.
3386         * stabsread.c (dbx_init_float_type, define_symbol)
3387         (read_one_struct_field, read_enum_type, read_range_type): Update.
3388         * source.c (info_line_command): Update.
3389         * python/python.c (gdbpy_source_objfile_script)
3390         (gdbpy_execute_objfile_script): Update.
3391         * python/py-type.c (save_objfile_types): Update.
3392         * python/py-objfile.c (py_free_objfile): Update.
3393         * python/py-inferior.c (python_new_objfile): Update.
3394         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
3395         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
3396         (maintenance_check_psymtabs): Update.
3397         * printcmd.c (info_address_command): Update.
3398         * objfiles.h (struct objfile) <arch>: New method, from
3399         get_objfile_arch.
3400         (get_objfile_arch): Don't declare.
3401         * objfiles.c (get_objfile_arch): Remove.
3402         (filter_overlapping_sections): Update.
3403         * minsyms.c (msymbol_is_function): Update.
3404         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
3405         (output_nondebug_symbol): Update.
3406         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
3407         (mdebug_expand_psymtab): Update.
3408         * machoread.c (macho_add_oso_symfile): Update.
3409         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
3410         Update.
3411         * linux-fork.c (checkpoint_command): Update.
3412         * linespec.c (convert_linespec_to_sals): Update.
3413         * jit.c (finalize_symtab): Update.
3414         * infrun.c (insert_exception_resume_from_probe): Update.
3415         * ia64-tdep.c (ia64_find_unwind_table): Update.
3416         * hppa-tdep.c (internalize_unwinds): Update.
3417         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
3418         Update.
3419         * gcore.c (call_target_sbrk): Update.
3420         * elfread.c (record_minimal_symbol, elf_symtab_read)
3421         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
3422         (elf_gnu_ifunc_resolve_by_got): Update.
3423         * dwarf2/read.c (create_addrmap_from_index)
3424         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3425         (read_debug_names_from_section)
3426         (process_psymtab_comp_unit_reader, add_partial_symbol)
3427         (add_partial_subprogram, process_full_comp_unit)
3428         (read_file_scope, read_func_scope, read_lexical_block_scope)
3429         (read_call_site_scope, dwarf2_ranges_read)
3430         (dwarf2_record_block_ranges, dwarf2_add_field)
3431         (mark_common_block_symbol_computed, read_tag_pointer_type)
3432         (read_tag_string_type, dwarf2_init_float_type)
3433         (dwarf2_init_complex_target_type, read_base_type)
3434         (partial_die_info::read, partial_die_info::read)
3435         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
3436         (dwarf2_fetch_die_loc_sect_off): Update.
3437         * dwarf2/loc.c (dwarf2_find_location_expression)
3438         (class dwarf_evaluate_loc_desc, rw_pieced_value)
3439         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
3440         (dwarf2_loc_desc_get_symbol_read_needs)
3441         (locexpr_describe_location_piece, locexpr_describe_location_1)
3442         (loclist_describe_location): Update.
3443         * dwarf2/index-write.c (write_debug_names): Update.
3444         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
3445         * dtrace-probe.c (dtrace_process_dof): Update.
3446         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
3447         (process_one_symbol): Update.
3448         * ctfread.c (ctf_init_float_type, read_base_type): Update.
3449         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
3450         (coff_read_enum_type): Update.
3451         * cli/cli-cmds.c (edit_command, list_command): Update.
3452         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
3453         * breakpoint.c (create_overlay_event_breakpoint)
3454         (create_longjmp_master_breakpoint)
3455         (create_std_terminate_master_breakpoint)
3456         (create_exception_master_breakpoint, get_sal_arch): Update.
3457         * block.c (block_gdbarch): Update.
3458         * annotate.c (annotate_source_line): Update.
3459
3460 2020-04-17  Tom Tromey  <tromey@adacore.com>
3461
3462         * auto-load.c (show_auto_load_cmd): Remove.
3463         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
3464         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
3465         (maintenance_print_arc_command): Remove.
3466         * tui/tui-win.c (tui_command): Remove.
3467         (tui_get_cmd_list): Use add_basic_prefix_cmd.
3468         * tui/tui-layout.c (tui_layout_command): Remove.
3469         (_initialize_tui_layout): Use add_basic_prefix_cmd.
3470         * python/python.c (user_set_python, user_show_python): Remove.
3471         (_initialize_python): Use add_basic_prefix_cmd,
3472         add_show_prefix_cmd.
3473         * guile/guile.c (set_guile_command, show_guile_command): Remove.
3474         (install_gdb_commands): Use add_basic_prefix_cmd,
3475         add_show_prefix_cmd.
3476         (info_guile_command): Remove.
3477         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
3478         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
3479         add_show_prefix_cmd.
3480         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
3481         Remove do_set and do_show parameters.
3482         * cli/cli-style.c (set_style, show_style): Remove.
3483         (_initialize_cli_style): Use add_basic_prefix_cmd,
3484         add_show_prefix_cmd.
3485         (cli_style_option::add_setshow_commands): Remove do_set and
3486         do_show parameters.
3487         (cli_style_option::add_setshow_commands): Use
3488         add_basic_prefix_cmd, add_show_prefix_cmd.
3489         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
3490         (set_style_name): Remove.
3491         * cli/cli-dump.c (dump_command, append_command): Remove.
3492         (srec_dump_command, ihex_dump_command, verilog_dump_command)
3493         (tekhex_dump_command, binary_dump_command)
3494         (binary_append_command): Remove.
3495         (_initialize_cli_dump): Use add_basic_prefix_cmd.
3496         * windows-tdep.c (w32_prefix_command_valid): Remove global.
3497         (init_w32_command_list): Remove; move into ...
3498         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
3499         * valprint.c (set_print, show_print, set_print_raw)
3500         (show_print_raw): Remove.
3501         (_initialize_valprint): Use add_basic_prefix_cmd,
3502         add_show_prefix_cmd.
3503         * typeprint.c (set_print_type, show_print_type): Remove.
3504         (_initialize_typeprint): Use add_basic_prefix_cmd,
3505         add_show_prefix_cmd.
3506         * record.c (set_record_command, show_record_command): Remove.
3507         (_initialize_record): Use add_basic_prefix_cmd,
3508         add_show_prefix_cmd.
3509         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
3510         add_show_prefix_cmd.
3511         (info_command, show_command, set_debug, show_debug): Remove.
3512         * top.h (set_history, show_history): Don't declare.
3513         * top.c (set_history, show_history): Remove.
3514         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
3515         (unset_tdesc_cmd): Remove.
3516         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
3517         add_show_prefix_cmd.
3518         * symtab.c (info_module_command): Remove.
3519         (_initialize_symtab): Use add_basic_prefix_cmd.
3520         * symfile.c (overlay_command): Remove.
3521         (_initialize_symfile): Use add_basic_prefix_cmd.
3522         * sparc64-tdep.c (info_adi_command): Remove.
3523         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
3524         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
3525         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
3526         add_show_prefix_cmd.
3527         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
3528         (_initialize_serial): Use add_basic_prefix_cmd,
3529         add_show_prefix_cmd.
3530         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
3531         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
3532         add_show_prefix_cmd.
3533         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
3534         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
3535         add_show_prefix_cmd.
3536         * riscv-tdep.c (show_riscv_command, set_riscv_command)
3537         (show_debug_riscv_command, set_debug_riscv_command): Remove.
3538         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
3539         add_show_prefix_cmd.
3540         * remote.c (remote_command, set_remote_cmd): Remove.
3541         (_initialize_remote): Use add_basic_prefix_cmd.
3542         * record-full.c (set_record_full_command)
3543         (show_record_full_command): Remove.
3544         (_initialize_record_full): Use add_basic_prefix_cmd,
3545         add_show_prefix_cmd.
3546         * record-btrace.c (cmd_set_record_btrace)
3547         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
3548         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
3549         (cmd_show_record_btrace_pt): Remove.
3550         (_initialize_record_btrace): Use add_basic_prefix_cmd,
3551         add_show_prefix_cmd.
3552         * ravenscar-thread.c (set_ravenscar_command)
3553         (show_ravenscar_command): Remove.
3554         (_initialize_ravenscar): Use add_basic_prefix_cmd,
3555         add_show_prefix_cmd.
3556         * mips-tdep.c (show_mips_command, set_mips_command)
3557         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
3558         add_show_prefix_cmd.
3559         * maint.c (maintenance_command, maintenance_info_command)
3560         (maintenance_check_command, maintenance_print_command)
3561         (maintenance_set_cmd, maintenance_show_cmd): Remove.
3562         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
3563         add_show_prefix_cmd.
3564         (show_per_command_cmd): Remove.
3565         * maint-test-settings.c (maintenance_set_test_settings_cmd):
3566         Remove.
3567         (maintenance_show_test_settings_cmd): Remove.
3568         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
3569         add_show_prefix_cmd.
3570         * maint-test-options.c (maintenance_test_options_command):
3571         Remove.
3572         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
3573         * macrocmd.c (macro_command): Remove
3574         (_initialize_macrocmd): Use add_basic_prefix_cmd.
3575         * language.c (set_check, show_check): Remove.
3576         (_initialize_language): Use add_basic_prefix_cmd,
3577         add_show_prefix_cmd.
3578         * infcmd.c (unset_command): Remove.
3579         (_initialize_infcmd): Use add_basic_prefix_cmd.
3580         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
3581         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
3582         add_show_prefix_cmd.
3583         * go32-nat.c (go32_info_dos_command): Remove.
3584         (_initialize_go32_nat): Use add_basic_prefix_cmd.
3585         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
3586         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
3587         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
3588         (_initialize_frame): Use add_basic_prefix_cmd,
3589         add_show_prefix_cmd.
3590         * dcache.c (set_dcache_command, show_dcache_command): Remove.
3591         (_initialize_dcache): Use add_basic_prefix_cmd,
3592         add_show_prefix_cmd.
3593         * cp-support.c (maint_cplus_command): Remove.
3594         (_initialize_cp_support): Use add_basic_prefix_cmd.
3595         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
3596         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
3597         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
3598         add_basic_prefix_cmd, add_show_prefix_cmd.
3599         * breakpoint.c (save_command): Remove.
3600         (_initialize_breakpoint): Use add_basic_prefix_cmd.
3601         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
3602         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
3603         add_show_prefix_cmd.
3604         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
3605         (set_ada_command, show_ada_command): Remove.
3606         (_initialize_ada_language): Use add_basic_prefix_cmd,
3607         add_show_prefix_cmd.
3608         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
3609
3610 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
3611
3612         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
3613         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
3614
3615 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3616
3617         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
3618         warning messages.
3619
3620 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3621
3622         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
3623         import table is not at beginning of .idata section.
3624
3625 2020-04-16  Pedro Alves  <palves@redhat.com>
3626
3627         * inferior.c (delete_inferior): Use delete operator directly
3628         instead of delete_program_space.
3629         * progspace.c (add_program_space): New, factored out from
3630         program_space::program_space.
3631         (remove_program_space): New, factored out from
3632         delete_program_space.
3633         (program_space::program_space): Remove intro comment.  Rewrite.
3634         (program_space::~program_space): Remove intro comment.  Call
3635         remove_program_space.
3636         (delete_program_space): Delete.
3637         * progspace.h (program_space::program_space): Make explicit.  Move
3638         intro comment here, adjusted.
3639         (program_space::~program_space): Move intro comment here,
3640         adjusted.
3641         (delete_program_space): Remove.
3642
3643 2020-04-16  Tom Tromey  <tromey@adacore.com>
3644
3645         * windows-nat.c (windows_nat::handle_access_violation): New
3646         function.
3647         * nat/windows-nat.h (handle_access_violation): Declare.
3648         * nat/windows-nat.c (handle_exception): Move Cygwin code to
3649         windows-nat.c.  Call handle_access_violation.
3650
3651 2020-04-16  Tom de Vries  <tdevries@suse.de>
3652
3653         PR symtab/25791
3654         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
3655         CUs without psymtab.
3656
3657 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
3658
3659         * python/python.c (do_start_initialization): Don't call
3660         PyEval_InitThreads for Python 3.9 and beyond.
3661
3662 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
3663
3664         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
3665         thread functions.
3666         (obsd_nat_target::wait): Likewise.
3667
3668 2020-04-15  Tom Tromey  <tromey@adacore.com>
3669
3670         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
3671         (DEBUG_EXCEPT): Use debug_printf.
3672
3673 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * completer.c (class completion_tracker::completion_hash_entry)
3676         <hash_name>: New member function.
3677         (completion_tracker::discard_completions): New callback to hash a
3678         completion_hash_entry, pass this to htab_create_alloc.
3679
3680 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
3681
3682         * windows-nat.c (windows_make_so): Warn rather than stopping with
3683         an error if realpath() fails.
3684
3685 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
3686
3687         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
3688         (nbsd_nat_target::info_proc): Add do_status.
3689
3690 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
3691             Tom de Vries  <tdevries@suse.de>
3692
3693         PR symtab/25718
3694         * psympriv.h (struct partial_symtab::read_symtab)
3695         (struct partial_symtab::expand_psymtab)
3696         (struct partial_symtab::read_dependencies): Update comments.
3697         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
3698         read_symtab for includer.
3699         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
3700         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
3701         (struct dwarf2_include_psymtab::m_readin): Remove.
3702         (struct dwarf2_include_psymtab::includer): New member function.
3703         (dwarf2_psymtab::expand_psymtab): Assert !readin.
3704
3705 2020-04-14  Tom de Vries  <tdevries@suse.de>
3706
3707         PR symtab/25720
3708         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
3709         with NULL symbol_matcher and lookup_name.
3710         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
3711         and lookup_name.
3712         * dwarf2/read.c (dw2_expand_symtabs_matching)
3713         (dw2_debug_names_expand_symtabs_matching): Same.
3714         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
3715         Make lookup_name a pointer.  Update comment.
3716         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
3717         lookup_name being a pointer.
3718         * symfile.c (expand_symtabs_matching): Same.
3719         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
3720         * linespec.c (iterate_over_all_matching_symtabs): Same.
3721
3722 2020-04-13  Tom Tromey  <tom@tromey.com>
3723
3724         * run-on-main-thread.c: Update include.
3725         * unittests/main-thread-selftests.c: Update include.
3726         * tui/tui-win.c: Update include.
3727         * tui/tui-io.c: Update include.
3728         * tui/tui-interp.c: Update include.
3729         * tui/tui-hooks.c: Update include.
3730         * top.h: Update include.
3731         * top.c: Update include.
3732         * ser-base.c: Update include.
3733         * remote.c: Update include.
3734         * remote-notif.c: Update include.
3735         * remote-fileio.c: Update include.
3736         * record-full.c: Update include.
3737         * record-btrace.c: Update include.
3738         * python/python.c: Update include.
3739         * posix-hdep.c: Update include.
3740         * mingw-hdep.c: Update include.
3741         * mi/mi-main.c: Update include.
3742         * mi/mi-interp.c: Update include.
3743         * main.c: Update include.
3744         * linux-nat.c: Update include.
3745         * interps.c: Update include.
3746         * infrun.c: Update include.
3747         * inf-loop.c: Update include.
3748         * event-top.c: Update include.
3749         * event-loop.c: Move to ../gdbsupport/.
3750         * event-loop.h: Move to ../gdbsupport/.
3751         * async-event.h: Update include.
3752         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
3753
3754 2020-04-13  Tom Tromey  <tom@tromey.com>
3755
3756         * tui/tui-win.c: Include async-event.h.
3757         * remote.c: Include async-event.h.
3758         * remote-notif.c: Include async-event.h.
3759         * record-full.c: Include async-event.h.
3760         * record-btrace.c: Include async-event.h.
3761         * infrun.c: Include async-event.h.
3762         * event-top.c: Include async-event.h.
3763         * event-loop.h: Move some declarations to async-event.h.
3764         * event-loop.c: Don't include ser-event.h or top.h.  Move some
3765         code to async-event.c.
3766         * async-event.h: New file.
3767         * async-event.c: New file.
3768         * Makefile.in (COMMON_SFILES): Add async-event.c.
3769         (HFILES_NO_SRCDIR): Add async-event.h.
3770
3771 2020-04-13  Tom Tromey  <tom@tromey.com>
3772
3773         * utils.c (flush_streams): New function.
3774         * event-loop.c (gdb_wait_for_event): Call flush_streams.
3775
3776 2020-04-13  Tom Tromey  <tom@tromey.com>
3777
3778         * event-loop.c (handle_file_event): Use warning, not
3779         printf_unfiltered.
3780
3781 2020-04-13  Tom Tromey  <tom@tromey.com>
3782
3783         * event-loop.c: Include <chrono>.
3784
3785 2020-04-13  Tom Tromey  <tom@tromey.com>
3786
3787         * gdb_select.h: Move to ../gdbsupport/.
3788         * event-loop.c: Update include path.
3789         * top.c: Update include path.
3790         * ser-base.c: Update include path.
3791         * ui-file.c: Update include path.
3792         * ser-tcp.c: Update include path.
3793         * guile/scm-ports.c: Update include path.
3794         * posix-hdep.c: Update include path.
3795         * ser-unix.c: Update include path.
3796         * gdb_usleep.c: Update include path.
3797         * mingw-hdep.c: Update include path.
3798         * inflow.c: Update include path.
3799         * infrun.c: Update include path.
3800         * event-top.c: Update include path.
3801
3802 2020-04-13  Tom Tromey  <tom@tromey.com>
3803
3804         * configure: Rebuild.
3805         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
3806
3807 2020-04-13  Tom Tromey  <tom@tromey.com>
3808
3809         * event-loop.h (start_event_loop): Don't declare.
3810         * event-loop.c (start_event_loop): Move...
3811         * main.c (start_event_loop): ...here.  Now static.
3812
3813 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
3814
3815         * MAINTAINERS: Update my email address.
3816
3817 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3818
3819         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
3820         IP_ALL.
3821
3822 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3823
3824         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
3825         (nbsd_nat_target::info_proc): Add do_cmdline.
3826
3827 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3828
3829         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
3830         (nbsd_nat_target::info_proc): Add do_cwd.
3831
3832 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3833
3834         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
3835
3836 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
3837
3838         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
3839         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
3840         (nbsd_nat_target::info_proc): New functions.
3841         * nbsd-nat.c (kinfo_get_vmmap): New function.
3842         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
3843         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
3844         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
3845         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
3846         functions.
3847         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
3848         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
3849         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
3850         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
3851         (KINFO_VME_FLAG_GROWS_DOWN): New.
3852
3853 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
3854
3855         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
3856         bit shift.
3857
3858 2020-04-10  Tom Tromey  <tromey@adacore.com>
3859
3860         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
3861
3862 2020-04-10  Tom Tromey  <tromey@adacore.com>
3863
3864         * symtab.c (get_symbol_address, get_msymbol_address): Skip
3865         separate debug files.
3866
3867 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
3868
3869         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
3870         Move to...
3871         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
3872         ... here.
3873         * windows-nat.c (windows_nat_target::get_windows_debug_event):
3874         Check for STATUS_WX86_BREAKPOINT.
3875         (windows_nat_target::wait): Same.
3876
3877 2020-04-10  Tom de Vries  <tdevries@suse.de>
3878
3879         PR cli/25808
3880         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
3881
3882 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3883
3884         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
3885         (Write After Approval): Remove Tom de Vries.
3886
3887 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3888
3889         revert partially:
3890         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3891
3892         * buildsym.c (record_line): Fix undefined behavior and preserve
3893         lines at eof.
3894
3895 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
3896
3897         * auxv.h (svr4_auxv_parse): New.
3898         * auxv.c (default_auxv_parse): Split into default_auxv_parse
3899         and generic_auxv_parse.
3900         (svr4_auxv_parse): Add.
3901         * obsd-tdep.c: Include "auxv.h".
3902         (obsd_auxv_parse): Remove.
3903         (obsd_init_abi): Remove comment.
3904         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
3905         from `obsd_auxv_parse' to `svr4_auxv_parse'.
3906         * nbsd-tdep.c: Include "auxv.h".
3907         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
3908
3909 2020-04-08  Tom Tromey  <tromey@adacore.com>
3910
3911         * nat/windows-nat.h (last_wait_event): Don't declare.
3912         (wait_for_debug_event): Update comment.
3913         * nat/windows-nat.c (last_wait_event): Now static.
3914
3915 2020-04-08  Tom Tromey  <tromey@adacore.com>
3916
3917         * windows-nat.c (wait_for_debug_event): Move to
3918         nat/windows-nat.c.
3919         * nat/windows-nat.h (wait_for_debug_event): Declare.
3920         * nat/windows-nat.c (wait_for_debug_event): Move from
3921         windows-nat.c.  No longer static.
3922
3923 2020-04-08  Tom Tromey  <tromey@adacore.com>
3924
3925         * windows-nat.c (get_windows_debug_event): Use
3926         fetch_pending_stop.
3927         * nat/windows-nat.h (fetch_pending_stop): Declare.
3928         * nat/windows-nat.c (fetch_pending_stop): New function.
3929
3930 2020-04-08  Tom Tromey  <tromey@adacore.com>
3931
3932         * windows-nat.c (windows_continue): Use matching_pending_stop and
3933         continue_last_debug_event.
3934         * nat/windows-nat.h (matching_pending_stop)
3935         (continue_last_debug_event): Declare.
3936         * nat/windows-nat.c (DEBUG_EVENTS): New define.
3937         (matching_pending_stop, continue_last_debug_event): New
3938         functions.
3939
3940 2020-04-08  Tom Tromey  <tromey@adacore.com>
3941
3942         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
3943         (handle_exception_result): Move to nat/windows-nat.h.
3944         (DEBUG_EXCEPTION_SIMPLE): Remove.
3945         (windows_nat::handle_ms_vc_exception): New function.
3946         (handle_exception): Move to nat/windows-nat.c.
3947         (get_windows_debug_event): Update.
3948         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
3949         nat/windows-nat.c.
3950         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
3951         (handle_exception_result): Move from windows-nat.c.
3952         (handle_exception): Declare.
3953         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
3954         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
3955         windows-nat.c.
3956
3957 2020-04-08  Tom Tromey  <tromey@adacore.com>
3958
3959         * windows-nat.c (exception_count, event_count): Remove.
3960         (handle_exception, get_windows_debug_event)
3961         (do_initial_windows_stuff): Update.
3962
3963 2020-04-08  Tom Tromey  <tromey@adacore.com>
3964
3965         * windows-nat.c (windows_nat::handle_load_dll)
3966         (windows_nat::handle_unload_dll): Rename.  No longer static.
3967         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
3968         Declare.
3969
3970 2020-04-08  Tom Tromey  <tromey@adacore.com>
3971
3972         * complaints.h (stop_whining): Declare at top-level.
3973         (complaint): Don't declare stop_whining.
3974
3975 2020-04-08  Tom Tromey  <tromey@adacore.com>
3976
3977         * windows-nat.c (windows_nat::handle_output_debug_string):
3978         Rename.  No longer static.
3979         * nat/windows-nat.h (handle_output_debug_string): Declare.
3980
3981 2020-04-08  Tom Tromey  <tromey@adacore.com>
3982
3983         * windows-nat.c (current_process_handle, current_process_id)
3984         (main_thread_id, last_sig, current_event, last_wait_event)
3985         (current_windows_thread, desired_stop_thread_id, pending_stops)
3986         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
3987         (display_selectors, fake_create_process)
3988         (get_windows_debug_event): Update.
3989         * nat/windows-nat.h (current_process_handle, current_process_id)
3990         (main_thread_id, last_sig, current_event, last_wait_event)
3991         (current_windows_thread, desired_stop_thread_id, pending_stops)
3992         (struct pending_stop, siginfo_er): Move from windows-nat.c.
3993         * nat/windows-nat.c (current_process_handle, current_process_id)
3994         (main_thread_id, last_sig, current_event, last_wait_event)
3995         (current_windows_thread, desired_stop_thread_id, pending_stops)
3996         (siginfo_er): New globals.  Move from windows-nat.c.
3997
3998 2020-04-08  Tom Tromey  <tromey@adacore.com>
3999
4000         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4001         (handle_load_dll): Update.
4002         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4003
4004 2020-04-08  Tom Tromey  <tromey@adacore.com>
4005
4006         * windows-nat.c (enum thread_disposition_type): Move to
4007         nat/windows-nat.h.
4008         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4009         static.
4010         (windows_add_thread, windows_nat_target::fetch_registers)
4011         (windows_nat_target::store_registers, handle_exception)
4012         (windows_nat_target::resume, get_windows_debug_event)
4013         (windows_nat_target::get_tib_address)
4014         (windows_nat_target::thread_name)
4015         (windows_nat_target::thread_alive): Update.
4016         * nat/windows-nat.h (enum thread_disposition_type): Move from
4017         windows-nat.c.
4018         (thread_rec): Declare.
4019
4020 2020-04-08  Tom Tromey  <tromey@adacore.com>
4021
4022         * windows-nat.c: Add "using namespace".
4023         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4024         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4025
4026 2020-04-08  Tom Tromey  <tromey@adacore.com>
4027
4028         * nat/windows-nat.h (struct windows_thread_info): Declare
4029         destructor.
4030         * nat/windows-nat.c (~windows_thread_info): New.
4031
4032 2020-04-08  Tom Tromey  <tromey@adacore.com>
4033
4034         PR gdb/22992
4035         * windows-nat.c (current_event): Update comment.
4036         (last_wait_event, desired_stop_thread_id): New globals.
4037         (struct pending_stop): New.
4038         (pending_stops): New global.
4039         (windows_nat_target) <stopped_by_sw_breakpoint>
4040         <supports_stopped_by_sw_breakpoint>: New methods.
4041         (windows_fetch_one_register): Add assertions.  Adjust PC.
4042         (windows_continue): Handle pending stops.  Suspend other threads
4043         when stepping.  Use last_wait_event
4044         (wait_for_debug_event): New function.
4045         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4046         pending stops.  Queue spurious stops.
4047         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4048         (windows_nat_target::kill): Use wait_for_debug_event.
4049         * nat/windows-nat.h (struct windows_thread_info)
4050         <stopped_at_software_breakpoint>: New field.
4051         * nat/windows-nat.c (windows_thread_info::resume): Clear
4052         stopped_at_software_breakpoint.
4053
4054 2020-04-08  Tom Tromey  <tromey@adacore.com>
4055
4056         * windows-nat.c (enum thread_disposition_type): New.
4057         (thread_rec): Replace "get_context" parameter with "disposition";
4058         change type.
4059         (windows_add_thread, windows_nat_target::fetch_registers)
4060         (windows_nat_target::store_registers, handle_exception)
4061         (windows_nat_target::resume, get_windows_debug_event)
4062         (windows_nat_target::get_tib_address)
4063         (windows_nat_target::thread_name)
4064         (windows_nat_target::thread_alive): Update.
4065
4066 2020-04-08  Tom Tromey  <tromey@adacore.com>
4067
4068         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4069         (windows_continue): Use windows_continue::resume.
4070         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4071         resume>: Declare new methods.
4072         * nat/windows-nat.c: New file.
4073         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4074
4075 2020-04-08  Tom Tromey  <tromey@adacore.com>
4076
4077         * windows-nat.c (windows_add_thread, windows_delete_thread)
4078         (windows_nat_target::fetch_registers)
4079         (windows_nat_target::store_registers, fake_create_process)
4080         (windows_nat_target::resume, windows_nat_target::resume)
4081         (get_windows_debug_event, windows_nat_target::wait)
4082         (windows_nat_target::pid_to_str)
4083         (windows_nat_target::get_tib_address)
4084         (windows_nat_target::get_ada_task_ptid)
4085         (windows_nat_target::thread_name)
4086         (windows_nat_target::thread_alive): Use lwp, not tid.
4087
4088 2020-04-08  Tom Tromey  <tromey@adacore.com>
4089
4090         * windows-nat.c (handle_exception)
4091         (windows_nat_target::thread_name): Update.
4092         * nat/windows-nat.h (windows_thread_info): Remove destructor.
4093         <name>: Now unique_xmalloc_ptr.
4094
4095 2020-04-08  Tom Tromey  <tromey@adacore.com>
4096
4097         * windows-nat.c (thread_rec)
4098         (windows_nat_target::fetch_registers): Update.
4099         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
4100         Update comment.
4101         <debug_registers_changed, reload_context>: Now bool.
4102
4103 2020-04-08  Tom Tromey  <tromey@adacore.com>
4104
4105         * windows-nat.c (windows_add_thread): Use new.
4106         (windows_init_thread_list, windows_delete_thread): Use delete.
4107         (get_windows_debug_event): Update.
4108         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
4109         destructor, and initializers.
4110
4111 2020-04-08  Tom Tromey  <tromey@adacore.com>
4112
4113         * windows-nat.c (struct windows_thread_info): Remove.
4114         * nat/windows-nat.h: New file.
4115
4116 2020-04-08  Tom Tromey  <tromey@adacore.com>
4117
4118         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
4119         (thread_rec, windows_add_thread, windows_delete_thread)
4120         (windows_continue): Update.
4121
4122 2020-04-08  Tom Tromey  <tromey@adacore.com>
4123
4124         * windows-nat.c (struct windows_thread_info): Remove typedef.
4125         (thread_head): Remove.
4126         (thread_list): New global.
4127         (thread_rec, windows_add_thread, windows_init_thread_list)
4128         (windows_delete_thread, windows_continue): Update.
4129
4130 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4131
4132         * windows-tdep.h (windows_init_abi): Add comment.
4133         (cygwin_init_abi): New declaration.
4134         * windows-tdep.c: Split signal enumeration in two, one for
4135         Windows and one for Cygwin.
4136         (windows_gdb_signal_to_target): Only deal with signal of the
4137         Windows OS ABI.
4138         (cygwin_gdb_signal_to_target): New function.
4139         (windows_init_abi): Rename to windows_init_abi_common, don't set
4140         gdb_signal_to_target gdbarch method.  Add new new function with
4141         this name.
4142         (cygwin_init_abi): New function.
4143         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
4144         comment.  Don't call windows_init_abi.
4145         (amd64_windows_init_abi): Add comment, call windows_init_abi.
4146         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
4147         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
4148         i386_windows_init_abi_common, don't call windows_init_abi.  Add
4149         a new function of this name.
4150         (i386_cygwin_init_abi): New function.
4151         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
4152         OS ABI Cygwin.
4153
4154 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4155
4156         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
4157         parameter.c.
4158         (dwarf2_read_gdb_index): Update.
4159
4160 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
4161
4162         * nbsd-tdep.c: Include "objfiles.h".
4163         (nbsd_skip_solib_resolver): New.
4164         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
4165
4166 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4167
4168         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
4169         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
4170         with DW_LLE_base_addressx are being emitted in DWARFv5.
4171         Add the newly added kind DW_LOC_OFFSET_PAIR also.
4172         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
4173         unsigned integer.
4174
4175 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4176
4177         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
4178         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
4179         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
4180         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
4181         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
4182         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
4183         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
4184
4185
4186 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4187
4188         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
4189         (read_loclist_index): New function definition.
4190         (lookup_loclist_base): New function definition.
4191         (read_loclist_header): New function definition.
4192         (dwarf2_cu): Add loclist_base and loclist_header field.
4193         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
4194         (read_full_die_1): Read the value of DW_AT_loclists_base.
4195         (read_attribute_reprocess): Handle DW_FORM_loclistx.
4196         (read_attribute_value): Handle DW_FORM_loclistx.
4197         (skip_one_die): Handle DW_FORM_loclistx.
4198         (loclist_header): New structure declaration.
4199         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
4200
4201 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4202
4203         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
4204         constructor.  Remove `addr` parameter from other constructor and
4205         add `per_cu` parameter.
4206         * dwarf2/read.c (create_partial_symtab): Update.
4207
4208 2020-04-07  Tom de Vries  <tdevries@suse.de>
4209
4210         PR symtab/25796
4211         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
4212         (partial_die_info::fixup): Inherit has_const_value.
4213
4214 2020-04-07  Tom de Vries  <tdevries@suse.de>
4215
4216         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
4217         symbols without address.
4218
4219 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4220
4221         * nbsd-nat.h (struct thread_info): Add forward declaration.
4222         (nbsd_nat_target::thread_alive): Add.
4223         (nbsd_nat_target::thread_name): Likewise.
4224         (nbsd_nat_target::update_thread_list): Likewise.
4225         (update_thread_list::post_attach): Likewise.
4226         (post_attach::pid_to_str): Likewise.
4227         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
4228         (nbsd_thread_lister): Add.
4229         (nbsd_nat_target::thread_alive): Likewise.
4230         (nbsd_nat_target::thread_name): Likewise.
4231         (nbsd_add_threads): Likewise.
4232         (update_thread_list::post_attach): Likewise.
4233         (nbsd_nat_target::update_thread_list): Likewise.
4234         (post_attach::pid_to_str): Likewise.
4235
4236 2020-04-06  Tom Tromey  <tromey@adacore.com>
4237
4238         * ada-valprint.c (print_variant_part): Extract the variant field.
4239         (print_field_values): Use the field as the outer value when
4240         recursing.
4241
4242 2020-04-06  Tom Tromey  <tromey@adacore.com>
4243
4244         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
4245         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
4246         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
4247         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
4248         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
4249
4250 2020-04-06  Tom Tromey  <tromey@adacore.com>
4251
4252         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
4253         TYPE_CODE_ERROR.
4254
4255 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4256
4257         * nbsd-tdep.c: Include "gdbarch.h".
4258         Define enum with NetBSD signal numbers.
4259         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
4260         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
4261         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
4262         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
4263         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
4264         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
4265         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
4266         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
4267         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
4268         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
4269         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
4270         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
4271
4272 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
4273
4274         PR gdb/25325
4275         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
4276
4277 2020-04-03  Tom Tromey  <tromey@adacore.com>
4278
4279         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
4280         Read constant block.
4281
4282 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4283
4284         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
4285         (gdb_bfd_get_full_section_contents): New declaration.
4286         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
4287         * windows-tdep.c (is_linked_with_cygwin_dll): Use
4288         gdb_bfd_get_full_section_contents.
4289
4290 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4291
4292         * exec.c (build_section_table): Replace internal_error with
4293         gdb_assert.
4294         (section_table_xfer_memory_partial): Likewise.
4295         * mdebugread.c (parse_partial_symbols): Likewise.
4296         * psymtab.c (lookup_partial_symbol): Likewise.
4297         * utils.c (wrap_here): Likewise.
4298
4299 2020-04-02  Tom Tromey  <tromey@adacore.com>
4300
4301         * f-lang.c (build_fortran_types): Use arch_type to initialize
4302         builtin_complex_s32 in the TYPE_CODE_ERROR case.
4303
4304 2020-04-02  Tom Tromey  <tromey@adacore.com>
4305
4306         * dwarf2/read.c (partial_die_info::read): Do not create a vector
4307         of attributes.
4308
4309 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4310             Bernd Edlinger <bernd.edlinger@hotmail.de>
4311             Tom Tromey  <tromey@adacore.com>
4312
4313         * buildsym.c (buildsym_compunit::record_line): Remove
4314         deduplication code.
4315
4316 2020-04-02  Tom de Vries  <tdevries@suse.de>
4317
4318         PR ada/24671
4319         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
4320
4321 2020-04-02  Tom de Vries  <tdevries@suse.de>
4322
4323         * dwarf2/read.c (dwarf2_gdb_index_functions,
4324         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
4325         NULL.
4326         * psymtab.c (psym_lookup_global_symbol_language): New function.
4327         (psym_functions): Init psym_lookup_global_symbol_language with
4328         psym_lookup_global_symbol_language.
4329         * symfile-debug.c (debug_sym_quick_functions): Init
4330         lookup_global_symbol_language with NULL.
4331         * symfile.c (set_initial_language): Remove fixme comment.
4332         * symfile.h (struct quick_symbol_functions): Add
4333         lookup_global_symbol_language.
4334         * symtab.c (find_quick_global_symbol_language): New function.
4335         (find_main_name): Use find_quick_global_symbol_language.
4336
4337 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4338
4339         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
4340
4341 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4342
4343         * buildsym.c (record_line): Fix undefined behavior and preserve
4344         lines at eof.
4345
4346 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4347
4348         * buildsym.c (record_line): Fix the resizing condition.
4349
4350 2020-04-01  Tom Tromey  <tom@tromey.com>
4351
4352         * value.h (value_literal_complex): Add comment.
4353         * valops.c (value_literal_complex): Refer to value.h.
4354
4355 2020-04-01  Tom Tromey  <tom@tromey.com>
4356
4357         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
4358         (scalar_type): New rule, from typebase.
4359         (typebase): Use scalar_type.  Recognize complex types.
4360         (field_name): Handle FLOAT_KEYWORD.
4361         (ident_tokens): Add _Complex and __complex__.
4362
4363 2020-04-01  Tom Tromey  <tom@tromey.com>
4364
4365         PR exp/25299:
4366         * valarith.c (promotion_type, complex_binop): New functions.
4367         (scalar_binop): Handle complex numbers.  Use promotion_type.
4368         (value_pos, value_neg, value_complement): Handle complex numbers.
4369
4370 2020-04-01  Tom Tromey  <tom@tromey.com>
4371
4372         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
4373         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
4374         (parse_number): Handle complex numbers.
4375
4376 2020-04-01  Tom Tromey  <tom@tromey.com>
4377
4378         * c-valprint.c (c_decorations): Change complex suffix to "i".
4379
4380 2020-04-01  Tom Tromey  <tom@tromey.com>
4381
4382         * valprint.c (generic_value_print_complex): Use accessors.
4383         * value.h (value_real_part, value_imaginary_part): Declare.
4384         * valops.c (value_real_part, value_imaginary_part): New
4385         functions.
4386         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
4387
4388 2020-04-01  Tom Tromey  <tom@tromey.com>
4389
4390         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
4391         (read_range_type): Update.
4392         * mdebugread.c (basic_type): Update.
4393         * go-lang.c (build_go_types): Use init_complex_type.
4394         * gdbtypes.h (struct main_type) <complex_type>: New member.
4395         (init_complex_type): Update.
4396         (arch_complex_type): Don't declare.
4397         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
4398         Make name if none given.  Use alloc_type_copy.  Look for cached
4399         complex type.
4400         (arch_complex_type): Remove.
4401         (gdbtypes_post_init): Use init_complex_type.
4402         * f-lang.c (build_fortran_types): Use init_complex_type.
4403         * dwarf2/read.c (read_base_type): Update.
4404         * d-lang.c (build_d_types): Use init_complex_type.
4405         * ctfread.c (read_base_type): Update.
4406
4407 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4408
4409         * infrun.c (stop_all_threads): Update assertion, plus when
4410         stopping threads, take into account that we might be trying
4411         to stop an all-stop target.
4412         (stop_waiting): Call 'stop_all_threads' if there exists a
4413         non-stop target.
4414
4415 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4416
4417         * target.h (exists_non_stop_target): New function declaration.
4418         * target.c (exists_non_stop_target): New function.
4419
4420 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
4421
4422         PR gdb/24789
4423         * eval.c (is_integral_or_integral_reference): New function.
4424         (evaluate_subexp_standard): Allow integer references in
4425         pointer arithmetic.
4426
4427 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4428
4429         * remote.c (remote_target::remote_parse_stop_reply): Remove the
4430         check for no ptid in the stop reply when the target is non-stop.
4431
4432 2020-04-01  Tom Tromey  <tromey@adacore.com>
4433
4434         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
4435         "name" parameter to rvalue reference.  Initialize m_name_holder.
4436         <lookup_name_info>: New overloads.
4437         <name>: Return gdb::string_view.
4438         <c_str>: New method.
4439         <make_ignore_params>: Update.
4440         <search_name_hash>: Update.
4441         <language_lookup_name>: Return const char *.
4442         <m_name>: Change type.
4443         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
4444         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
4445         (lookup_name_info::match_any): Update.
4446         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
4447         Update.
4448         * minsyms.c (linkage_name_str): Update.
4449         * language.c (default_symbol_name_matcher): Update.
4450         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
4451         Update.
4452         * ada-lang.c (ada_fold_name): Change parameter to string_view.
4453         (ada_lookup_name_info::ada_lookup_name_info): Update.
4454         (literal_symbol_name_matcher): Update.
4455
4456 2020-04-01  Tom Tromey  <tromey@adacore.com>
4457
4458         * psymtab.c (psymtab_search_name): Remove function.
4459         (psym_lookup_symbol): Create search name and lookup name here.
4460         (lookup_partial_symbol): Remove "name" parameter; add
4461         lookup_name.
4462         (psym_expand_symtabs_for_function): Update.
4463
4464 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
4465
4466         PR tui/25597:
4467         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
4468
4469 2020-03-31  Tom Tromey  <tromey@adacore.com>
4470
4471         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
4472         memcpy.
4473
4474 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
4475
4476         * features/riscv/32bit-csr.xml: Regenerated.
4477         * features/riscv/64bit-csr.xml: Regenerated.
4478
4479 2020-03-30  Tom Tromey  <tromey@adacore.com>
4480
4481         * ada-valprint.c (print_variant_part): Update.
4482         * ada-lang.h (ada_which_variant_applies): Update.
4483         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
4484         outer_valaddr parameters; replace with "outer" value parameter.
4485         (to_fixed_variant_branch_type): Update.
4486
4487 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4488
4489         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
4490         <list>.  Remove inclusion of observable.h.
4491         (PPC_DEBUG_CURRENT_VERSION): Move up define.
4492         (struct arch_lwp_info): New struct.
4493         (class ppc_linux_dreg_interface): New class.
4494         (struct ppc_linux_process_info): New struct.
4495         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
4496         <low_new_clone, low_forget_process, low_prepare_to_resume>
4497         <copy_thread_dreg_state, mark_thread_stale>
4498         <mark_debug_registers_changed, register_hw_breakpoint>
4499         <clear_hw_breakpoint, register_wp, clear_wp>
4500         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
4501         <num_memory_accesses, get_trigger_type>
4502         <create_watchpoint_request, hwdebug_point_cmp>
4503         <init_arch_lwp_info, get_arch_lwp_info>
4504         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
4505         methods.
4506         <struct ptid_hash>: New inner struct.
4507         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
4508         members.
4509         (saved_dabr_value, hwdebug_info, max_slots_number)
4510         (struct hw_break_tuple, struct thread_points, ppc_threads)
4511         (have_ptrace_hwdebug_interface)
4512         (hwdebug_find_thread_points_by_tid)
4513         (hwdebug_insert_point, hwdebug_remove_point): Remove.
4514         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
4515         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
4516         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
4517         use m_dreg_interface.
4518         (hwdebug_point_cmp): Change to...
4519         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
4520         reference arguments instead of pointers.
4521         (ppc_linux_nat_target::ranged_break_num_registers): Use
4522         m_dreg_interface.
4523         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
4524         m_dreg_interface.  Call register_hw_breakpoint.
4525         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
4526         m_dreg_interface.  Call clear_hw_breakpoint.
4527         (get_trigger_type): Change to...
4528         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
4529         comment.
4530         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
4531         use m_dreg_interface.  Call register_hw_breakpoint.
4532         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
4533         use m_dreg_interface.  Call clear_hw_breakpoint.
4534         (can_use_watchpoint_cond_accel): Change to...
4535         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
4536         method.  Update comment, use m_dreg_interface and
4537         m_process_info.
4538         (calculate_dvc): Change to...
4539         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
4540         m_dreg_interface.
4541         (num_memory_accesses): Change to...
4542         (ppc_linux_nat_target::num_memory_accesses): ...this method.
4543         (check_condition): Change to...
4544         (ppc_linux_nat_target::check_condition): ...this method.
4545         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
4546         comment, use m_dreg_interface.
4547         (create_watchpoint_request): Change to...
4548         (ppc_linux_nat_target::create_watchpoint_request): ...this
4549         method.  Use m_dreg_interface.
4550         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
4551         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
4552         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
4553         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
4554         (ppc_linux_nat_target::low_forget_process)
4555         (ppc_linux_nat_target::low_new_fork)
4556         (ppc_linux_nat_target::low_new_clone)
4557         (ppc_linux_nat_target::low_delete_thread)
4558         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
4559         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
4560         only call mark_thread_stale.
4561         (ppc_linux_thread_exit): Remove.
4562         (ppc_linux_nat_target::stopped_data_address): Change to...
4563         (ppc_linux_nat_target::low_stopped_data_address): This. Add
4564         comment, use m_dreg_interface and m_thread_hw_breakpoints.
4565         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
4566         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
4567         comment.  Call low_stopped_data_address.
4568         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
4569         m_dreg_interface.
4570         (ppc_linux_nat_target::masked_watch_num_registers): Use
4571         m_dreg_interface.
4572         (ppc_linux_nat_target::copy_thread_dreg_state)
4573         (ppc_linux_nat_target::mark_thread_stale)
4574         (ppc_linux_nat_target::mark_debug_registers_changed)
4575         (ppc_linux_nat_target::register_hw_breakpoint)
4576         (ppc_linux_nat_target::clear_hw_breakpoint)
4577         (ppc_linux_nat_target::register_wp)
4578         (ppc_linux_nat_target::clear_wp)
4579         (ppc_linux_nat_target::init_arch_lwp_info)
4580         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
4581         (_initialize_ppc_linux_nat): Remove observer callback.
4582
4583 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4584
4585         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
4586         (ppc_linux_nat_target::auxv_parse)
4587         (ppc_linux_nat_target::read_description)
4588         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
4589         Move up.
4590
4591 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4592
4593         * linux-nat.h (low_new_clone): New method.
4594         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
4595
4596 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4597
4598         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
4599         (dbx_expand_psymtab): ... this.
4600         (start_psymtab): Update.
4601         * mdebugread.c (psymtab_to_symtab_1): Rename to...
4602         (mdebug_expand_psymtab): ... this.
4603         (parse_partial_symbols): Update.
4604         (new_psymtab): Update.
4605         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
4606         (xcoff_expand_psymtab): ... this.
4607         (xcoff_start_psymtab): Update.
4608
4609 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4610
4611         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
4612         <expand_dependencies>: ... this.
4613         * psymtab.c (partial_symtab::read_dependencies): Rename to...
4614         (partial_symtab::expand_dependencies): ... this.
4615         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
4616         Update.
4617         (dwarf2_psymtab::expand_psymtab): Update.
4618         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
4619         * mdebugread.c (psymtab_to_symtab_1): Update.
4620         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
4621
4622 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4623
4624         * psympriv.h (discard_psymtab): Remove.
4625         * dbxread.c (dbx_end_psymtab): Update.
4626         * xcoffread.c (xcoff_end_psymtab): Update.
4627
4628 2020-03-28  Tom Tromey  <tom@tromey.com>
4629
4630         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
4631         comment.
4632
4633 2020-03-28  Tom Tromey  <tom@tromey.com>
4634
4635         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
4636
4637 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
4638
4639         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4640
4641 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
4642
4643         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
4644
4645 2020-03-26  Tom Tromey  <tom@tromey.com>
4646
4647         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
4648         (mark_common_block_symbol_computed, read_tag_string_type)
4649         (attr_to_dynamic_prop, read_subrange_type): Update.
4650         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
4651         to be methods on struct attribute.
4652         (skip_one_die, process_imported_unit_die, read_namespace_alias)
4653         (read_call_site_scope, partial_die_info::read)
4654         (partial_die_info::read, lookup_die_type, follow_die_ref):
4655         Update.
4656         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
4657         from dwarf2_get_ref_die_offset.
4658         (attribute::constant_value): New method, from
4659         dwarf2_get_attr_constant_value.
4660         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
4661         Declare method.
4662         <constant_value>: New method.
4663
4664 2020-03-26  Tom Tromey  <tom@tromey.com>
4665
4666         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
4667         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
4668         (dwarf_type_encoding_name): Move to stringify.c.
4669         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
4670         * dwarf2/stringify.c: New file.
4671         * dwarf2/stringify.h: New file.
4672
4673 2020-03-26  Tom Tromey  <tom@tromey.com>
4674
4675         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
4676         Rewrite.
4677
4678 2020-03-26  Tom Tromey  <tom@tromey.com>
4679
4680         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
4681         methods.
4682         * dwarf2/read.c (lookup_addr_base): Move to die.h.
4683         (lookup_ranges_base): Likewise.
4684         (read_cutu_die_from_dwo, read_full_die_1): Update.
4685
4686 2020-03-26  Tom Tromey  <tom@tromey.com>
4687
4688         * dwarf2/read.c (read_import_statement, read_file_scope)
4689         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
4690         (read_lexical_block_scope, read_call_site_scope)
4691         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
4692         (handle_struct_member_die, process_structure_scope)
4693         (update_enumeration_type_from_children)
4694         (process_enumeration_scope, read_array_type, read_common_block)
4695         (read_namespace, read_module, read_subroutine_type): Update.
4696         (sibling_die): Remove.
4697
4698 2020-03-26  Tom Tromey  <tom@tromey.com>
4699
4700         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
4701         (build_type_psymtabs_reader, read_structure_type)
4702         (read_enumeration_type, read_full_die_1): Update.
4703         (dwarf2_attr_no_follow): Move to die.h.
4704         * dwarf2/die.h (struct die_info) <attr>: New method.
4705
4706 2020-03-26  Tom Tromey  <tom@tromey.com>
4707
4708         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
4709         <base_address>: Now an optional.
4710         (dwarf2_find_base_address, dwarf2_rnglists_process)
4711         (dwarf2_ranges_process, fill_in_loclist_baton)
4712         (dwarf2_symbol_mark_computed): Update.
4713
4714 2020-03-26  Tom Tromey  <tom@tromey.com>
4715
4716         * dwarf2/read.c (struct die_info): Move to die.h.
4717         * dwarf2/die.h: New file.
4718
4719 2020-03-26  Tom Tromey  <tom@tromey.com>
4720
4721         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
4722         * dwarf2/read.c
4723         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4724         Move to line-header.c.
4725         (read_checked_initial_length_and_offset, read_formatted_entries):
4726         Likewise.
4727         (dwarf_decode_line_header): Split into two.
4728         * dwarf2/line-header.c
4729         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4730         Move from read.c.
4731         (read_checked_initial_length_and_offset, read_formatted_entries):
4732         Likewise.
4733         (dwarf_decode_line_header): New function, split from read.c.
4734
4735 2020-03-26  Tom Tromey  <tom@tromey.com>
4736
4737         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
4738         Declare method.
4739         * dwarf2/read.c (read_attribute_value): Update.
4740         (dwarf2_per_objfile::read_line_string): Rename from
4741         read_indirect_line_string.
4742         (read_formatted_entries): Update.
4743
4744 2020-03-26  Tom Tromey  <tom@tromey.com>
4745
4746         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
4747         variable.
4748
4749 2020-03-26  Tom Tromey  <tom@tromey.com>
4750
4751         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
4752         const.
4753         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
4754         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
4755         parameter const.
4756
4757 2020-03-26  Tom Tromey  <tom@tromey.com>
4758
4759         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
4760         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
4761         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
4762         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
4763
4764 2020-03-26  Tom Tromey  <tom@tromey.com>
4765
4766         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
4767         file_names_size, file_full_name, file_file_name>: Use const.
4768         <file_name_at, file_names>: Add const overload.
4769         * dwarf2/line-header.c (line_header::file_file_name)
4770         (line_header::file_full_name): Update.
4771
4772 2020-03-26  Tom Tromey  <tom@tromey.com>
4773
4774         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
4775         (macro_start_file, consume_improper_spaces)
4776         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
4777         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
4778         (dwarf_decode_macros): Move to macro.c.
4779         * dwarf2/macro.c: New file.
4780         * dwarf2/macro.h: New file.
4781         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
4782
4783 2020-03-26  Tom Tromey  <tom@tromey.com>
4784
4785         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
4786         method.
4787         * dwarf2/section.c: New method.  From
4788         read_indirect_string_at_offset_from.
4789         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
4790         (read_indirect_string_at_offset_from): Move to section.c.
4791         (read_indirect_string_at_offset): Rewrite.
4792         (read_indirect_line_string_at_offset): Remove.
4793         (read_indirect_string, read_indirect_line_string)
4794         (dwarf_decode_macro_bytes): Update.
4795
4796 2020-03-26  Tom Tromey  <tom@tromey.com>
4797
4798         * dwarf2/section.h (struct dwarf2_section_info)
4799         <overload_complaint>: Declare.
4800         (dwarf2_section_buffer_overflow_complaint): Don't declare.
4801         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
4802         Rename from dwarf2_section_buffer_overflow_complaint.
4803         * dwarf2/read.c (skip_one_die, partial_die_info::read)
4804         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
4805
4806 2020-03-26  Tom Tromey  <tom@tromey.com>
4807
4808         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
4809         Declare.
4810         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
4811         Move from read.c.
4812         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
4813         to section.c.
4814
4815 2020-03-26  Tom Tromey  <tom@tromey.com>
4816
4817         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
4818
4819 2020-03-26  Tom Tromey  <tom@tromey.com>
4820
4821         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
4822         "builder".
4823         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
4824         parameter.
4825         (dwarf_decode_macros): Update.
4826
4827 2020-03-26  Tom Tromey  <tom@tromey.com>
4828
4829         * dwarf2/read.c (read_attribute_value): Update.
4830         (read_indirect_string_from_dwz): Move to dwz.c; change into
4831         method.
4832         (dwarf_decode_macro_bytes): Update.
4833         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
4834         * dwarf2/dwz.c: New file.
4835         * Makefile.in (COMMON_SFILES): Add dwz.c.
4836
4837 2020-03-26  Tom Tromey  <tom@tromey.com>
4838
4839         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
4840         * dwarf2/read.c: Add include.
4841         * dwarf2/index-write.c: Add include.
4842         * dwarf2/index-cache.c: Add include.
4843         * dwarf2/dwz.h: New file.
4844
4845 2020-03-25  Tom Tromey  <tom@tromey.com>
4846
4847         * compile/compile-object-load.c (get_out_value_type): Mention
4848         correct symbol name in error message.
4849
4850 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
4851
4852         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4853
4854 2020-03-25  Tom de Vries  <tdevries@suse.de>
4855
4856         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
4857         * symmisc.c (dump_symtab_1): Print user and includes fields.
4858         (maintenance_info_symtabs): Same.
4859
4860 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         PR gdb/25534
4863         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
4864         (riscv_regcache_cooked_write): New function.
4865         (riscv_push_dummy_call): Use new function.
4866         (riscv_return_value): Likewise.
4867
4868 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
4869
4870         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
4871         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
4872         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
4873         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
4874         * infrun.c (follow_fork): Likewise.
4875         (follow_fork_inferior): Likewise.
4876         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
4877         * linux-nat.h (class linux_nat_target): Likewise.
4878         * remote.c (class remote_target) <follow_fork>: Likewise.
4879         (remote_target::follow_fork): Likewise.
4880         * target-delegates.c: Re-generate.
4881         * target.c (default_follow_fork): Likewise.
4882         (target_follow_fork): Likewise.
4883         * target.h (struct target_ops) <follow_fork>: Likewise.
4884         (target_follow_fork): Likewise.
4885
4886 2020-03-24  Tom de Vries  <tdevries@suse.de>
4887
4888         * psymtab.c (maintenance_info_psymtabs): Print user field.
4889
4890 2020-03-20  Tom Tromey  <tromey@adacore.com>
4891
4892         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
4893         const.
4894         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
4895         const.
4896
4897 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
4898
4899         * ptrace.m4: Don't check for ptrace declaration.
4900         * config.in: Re-generate.
4901         * configure: Re-generate.
4902         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
4903         not defined.
4904
4905 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4906
4907         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
4908         `PTRACE_TYPE_RET'.
4909         * i386-bsd-nat.c (gdb_ptrace): Likewise.
4910         * sparc-nat.c (gdb_ptrace): Likewise.
4911         * x86-bsd-nat.c (gdb_ptrace): Likewise.
4912
4913 2020-03-20  Tom Tromey  <tromey@adacore.com>
4914
4915         * c-exp.y (lex_one_token): Fix assert.
4916
4917 2020-03-20  Tom Tromey  <tromey@adacore.com>
4918
4919         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
4920         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
4921         strncpy call.
4922
4923 2020-03-20  Tom Tromey  <tromey@adacore.com>
4924
4925         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
4926
4927 2020-03-20  Tom Tromey  <tromey@adacore.com>
4928
4929         * ada-valprint.c (print_variant_part): Remove parameters; switch
4930         to value-based API.
4931         (print_field_values): Likewise.
4932         (ada_val_print_struct_union): Likewise.
4933         (ada_value_print_1): Update.
4934
4935 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4936
4937         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
4938         nbsd_nat_target instead of inf_ptrace_target.
4939         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
4940         nbsd_nat_target.
4941
4942 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4943
4944         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
4945         it to the ptrace call.
4946         * (store_registers): Likewise.
4947
4948 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4949
4950         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
4951         it to the ptrace call.
4952         * (store_registers): Likewise.
4953
4954 2020-03-19  Luis Machado  <luis.machado@linaro.org>
4955
4956         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
4957         valid, fetch vg value from ptrace.
4958
4959 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
4960         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
4961         * inf-ptrace.c: Likewise.
4962         * (gdb_ptrace): Add.
4963         * (inf_ptrace_target::resume): Update.
4964         * (inf_ptrace_target::xfer_partial): Likewise.
4965         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
4966         * (inf_ptrace_peek_poke): Update.
4967
4968 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
4969
4970         * x86-bsd-nat.c (gdb_ptrace): New.
4971         * (x86bsd_dr_set): Add new argument `ptid'.
4972         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
4973         x86bsd_dr_set_addr): Update.
4974
4975 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * remote.c (remote_target::process_stop_reply): Handle events for
4978         all threads differently.
4979
4980 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * completer.c (completion_tracker::remove_completion): Define new
4983         function.
4984         * completer.h (completion_tracker::remove_completion): Declare new
4985         function.
4986         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
4987         when adding a C++ function symbol.
4988
4989 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4990
4991         * completer.c (completion_tracker::completion_hash_entry): Define
4992         new class.
4993         (advance_to_filename_complete_word_point): Call
4994         recompute_lowest_common_denominator.
4995         (completion_tracker::completion_tracker): Call discard_completions
4996         to setup the hash table.
4997         (completion_tracker::discard_completions): Allow for being called
4998         from the constructor, pass new equal function, and element deleter
4999         when constructing the hash table.  Initialise new class member
5000         variables.
5001         (completion_tracker::maybe_add_completion): Remove use of
5002         m_entries_vec, and store more information into m_entries_hash.
5003         (completion_tracker::recompute_lcd_visitor): New function, most
5004         content taken from...
5005         (completion_tracker::recompute_lowest_common_denominator):
5006         ...here, this now just visits each item in the hash calling the
5007         above visitor.
5008         (completion_tracker::build_completion_result): Remove use of
5009         m_entries_vec, call recompute_lowest_common_denominator.
5010         * completer.h (completion_tracker::have_completions): Remove use
5011         of m_entries_vec.
5012         (completion_tracker::completion_hash_entry): Declare new class.
5013         (completion_tracker::recompute_lowest_common_denominator): Change
5014         function signature.
5015         (completion_tracker::recompute_lcd_visitor): Declare new function.
5016         (completion_tracker::m_entries_vec): Delete.
5017         (completion_tracker::m_entries_hash): Initialize to NULL.
5018         (completion_tracker::m_lowest_common_denominator_valid): New
5019         member variable.
5020         (completion_tracker::m_lowest_common_denominator_max_length): New
5021         member variable.
5022
5023 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5024
5025         * regformats/regdef.h: Put reg in gdb namespace.
5026
5027 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5028
5029         * i386-bsd-nat.c (gdb_ptrace): New.
5030         * (i386bsd_fetch_inferior_registers,
5031         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5032         * (i386bsd_fetch_inferior_registers,
5033         i386bsd_store_inferior_registers) Use gdb_ptrace.
5034
5035 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5036
5037         * amd64-bsd-nat.c (gdb_ptrace): New.
5038         * (amd64bsd_fetch_inferior_registers,
5039         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5040         * (amd64bsd_fetch_inferior_registers,
5041         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5042
5043 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5044
5045         * user-regs.c (user_reg::read): Rename to...
5046         (user_reg::xread): ...this.
5047         * (append_user_reg): Rename argument `read' to `xread'.
5048         * (user_reg_add_builtin): Likewise.
5049         * (user_reg_add): Likewise.
5050         * (value_of_user_reg): Likewise.
5051
5052 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5053
5054         * sparc-nat.c (gdb_ptrace): New.
5055         * sparc-nat.c (sparc_fetch_inferior_registers)
5056         (sparc_store_inferior_registers) Remove obsolete comment.
5057         * sparc-nat.c (sparc_fetch_inferior_registers)
5058         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5059         * sparc-nat.c (sparc_fetch_inferior_registers)
5060         (sparc_store_inferior_registers) Use gdb_ptrace.
5061
5062 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5063
5064         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5065         it to the ptrace call.
5066         * sh-nbsd-nat.c (store_registers): Likewise.
5067
5068 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5069
5070         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5071         nbsd_nat_target instead of inf_ptrace_target.
5072         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5073         nbsd_nat_target.
5074
5075 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5076
5077         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5078
5079 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5080
5081         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5082         <sys/sysctl.h>.
5083         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5084
5085 2020-03-17  Tom de Vries  <tdevries@suse.de>
5086
5087         PR gdb/23710
5088         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
5089         fields.
5090         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
5091         fields.
5092         (process_imported_unit_die): Skip import of c++ CUs.
5093
5094 2020-03-16  Tom Tromey  <tom@tromey.com>
5095
5096         * p-valprint.c (pascal_object_print_value): Initialize
5097         base_value.
5098
5099 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
5100             Shahab Vahedi  <shahab@synopsys.com>
5101
5102         * Makefile.in: Add arch/arc.o
5103         * configure.tgt: Likewise.
5104         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
5105         (_initialize_arc_tdep): Don't initialize old target descriptions.
5106         (arc_read_description): New function to cache target descriptions.
5107         * arc-tdep.h (arc_read_description): Add proto type.
5108         * arch/arc.c: New file.
5109         * arch/arc.h: Likewise.
5110         * features/Makefile: Replace old target descriptions with new.
5111         * features/arc-arcompact.c: Remove.
5112         * features/arc-arcompact.xml: Likewise.
5113         * features/arc-v2.c: Likewise
5114         * features/arc-v2.xml: Likewise
5115         * features/arc/aux-arcompact.xml: New file.
5116         * features/arc/aux-v2.xml: Likewise.
5117         * features/arc/core-arcompact.xml: Likewise.
5118         * features/arc/core-v2.xml: Likewise.
5119         * features/arc/aux-arcompact.c: Generate.
5120         * features/arc/aux-v2.c: Likewise.
5121         * features/arc/core-arcompact.c: Likewise.
5122         * features/arc/core-v2.c: Likewise.
5123         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
5124
5125 2020-03-16  Tom Tromey  <tromey@adacore.com>
5126
5127         PR gdb/25663:
5128         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
5129         putting value into bcache.
5130
5131 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5132
5133         PR gdb/21500
5134         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
5135         to...
5136         (amd64_windows_init_abi_common): ... this.  Don't set size of
5137         long type.
5138         (amd64_windows_init_abi): New function.
5139         (amd64_cygwin_init_abi): New function.
5140         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
5141         the Cygwin OS ABI.
5142         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
5143         comment.
5144
5145 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5146
5147         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
5148         * windows-tdep.c (CYGWIN_DLL_NAME): New.
5149         (pe_import_directory_entry): New struct type.
5150         (is_linked_with_cygwin_dll): New function.
5151         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
5152         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
5153         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
5154
5155 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5156
5157         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
5158         i386_cygwin_core_osabi_sniffer.
5159
5160 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5161
5162         * i386-cygwin-tdep.c: Rename to...
5163         * i386-windows-tdep.c: ... this.
5164         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
5165         i386-windows-tdep.c.
5166         * configure.tgt: Likewise.
5167
5168 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5169
5170         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
5171         * osabi.c (gdb_osabi_names): Add "Windows".
5172         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
5173         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
5174         (i386_cygwin_core_osabi_sniffer): New function, extracted from
5175         i386_cygwin_osabi_sniffer.
5176         (_initialize_i386_cygwin_tdep): Register OS ABI
5177         GDB_OSABI_WINDOWS for i386.
5178         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
5179         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
5180         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
5181         for x86-64.
5182         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
5183         when the target matches '*-*-mingw*'.
5184
5185 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5186
5187         * defs.h (enum gdb_osabi): Move to...
5188         * osabi.h (enum gdb_osabi): ... here.
5189         * gdbarch.sh: Include osabi.h in gdbarch.h.
5190         * gdbarch.h: Re-generate.
5191
5192 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5193
5194         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
5195         function.
5196         (_initialize_amd64_windows_tdep): Register osabi sniffer.
5197
5198 2020-03-14  Tom Tromey  <tom@tromey.com>
5199
5200         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
5201         for C++.
5202         (c_type_print_modifier): Likewise.  Add "language" parameter.
5203         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
5204         (c_type_print_base_1): Update.
5205         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
5206         constants.
5207         * type-stack.c (type_stack::insert): Handle tp_atomic and
5208         tp_restrict.
5209         (type_stack::follow_type_instance_flags): Likewise.
5210         (type_stack::follow_types): Likewise.  Merge type-following code.
5211         * c-exp.y (RESTRICT, ATOMIC): New tokens.
5212         (space_identifier, cv_with_space_id)
5213         (const_or_volatile_or_space_identifier_noopt)
5214         (const_or_volatile_or_space_identifier): Remove.
5215         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
5216         rules.
5217         (ptr_operator, typebase): Update.
5218         (enum token_flag) <FLAG_C>: New constant.
5219         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
5220         "_Atomic".
5221         (lex_one_token): Handle FLAG_C.
5222
5223 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5224
5225         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
5226         it to the ptrace call.
5227         * m68k-bsd-nat.c (store_registers): Likewise.
5228
5229 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5230
5231         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
5232         gdb_byte *.
5233         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
5234         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
5235         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
5236
5237 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5238
5239         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
5240         nbsd_nat_target instead of inf_ptrace_target.
5241         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5242         nbsd_nat_target.
5243
5244 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5245
5246         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
5247         register_t.
5248
5249 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5250
5251         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
5252         it to the ptrace call.
5253         * alpha-bsd-nat.c (store_registers): Likewise.
5254
5255 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5256
5257         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
5258         includes.
5259         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
5260         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
5261         fill_fpregset): Likewise.
5262
5263 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5264
5265         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
5266         nbsd_nat_target instead of inf_ptrace_target.
5267         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5268         nbsd_nat_target.
5269
5270 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5271
5272         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
5273         register_t.
5274
5275 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5276
5277         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
5278         it to the ptrace call.
5279         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
5280         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
5281         * arm-nbsd-nat.c (store_register): Likewise.
5282         * arm-nbsd-nat.c (store_regs): Likewise.
5283         * arm-nbsd-nat.c (store_fp_register): Likewise.
5284         * arm-nbsd-nat.c (store_fp_regs): Likewise.
5285
5286 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5287
5288         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
5289         nbsd_nat_target instead of inf_ptrace_target.
5290         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5291         nbsd_nat_target.
5292
5293 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5294
5295         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
5296         it to the ptrace call.
5297         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
5298
5299 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5300
5301         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
5302         it to the ptrace call.
5303         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
5304
5305 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5306
5307         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
5308         gdb_byte *.
5309         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
5310
5311 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5312
5313         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
5314         instead of inf_ptrace_target.
5315         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5316         nbsd_nat_target.
5317
5318 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5319
5320         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5321         register_t.
5322
5323 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5324
5325         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5326         register_t.
5327
5328 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5329
5330         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
5331         register_t.
5332
5333 2020-03-13  Tom Tromey  <tom@tromey.com>
5334
5335         * value.h (val_print): Don't declare.
5336         * valprint.h (val_print_array_elements)
5337         (val_print_scalar_formatted, generic_val_print): Don't declare.
5338         * valprint.c (generic_val_print_array): Take a struct value.
5339         (generic_val_print_ptr, generic_val_print_memberptr)
5340         (generic_val_print_bool, generic_val_print_int)
5341         (generic_val_print_char, generic_val_print_complex)
5342         (generic_val_print): Remove.
5343         (generic_value_print): Update.
5344         (do_val_print): Remove unused parameters.  Don't call
5345         la_val_print.
5346         (val_print): Remove.
5347         (common_val_print): Update.  Don't call value_check_printable.
5348         (val_print_scalar_formatted, val_print_array_elements): Remove.
5349         * rust-lang.c (rust_val_print): Remove.
5350         (rust_language_defn): Update.
5351         * p-valprint.c (pascal_val_print): Remove.
5352         (pascal_value_print_inner): Update.
5353         (pascal_object_print_val_fields, pascal_object_print_val):
5354         Remove.
5355         (pascal_object_print_static_field): Update.
5356         * p-lang.h (pascal_val_print): Don't declare.
5357         * p-lang.c (pascal_language_defn): Update.
5358         * opencl-lang.c (opencl_language_defn): Update.
5359         * objc-lang.c (objc_language_defn): Update.
5360         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
5361         * m2-lang.h (m2_val_print): Don't declare.
5362         * m2-lang.c (m2_language_defn): Update.
5363         * language.h (struct language_defn) <la_val_print>: Remove.
5364         * language.c (unk_lang_value_print_inner): Rename.  Change
5365         argument types.
5366         (unknown_language_defn, auto_language_defn): Update.
5367         * go-valprint.c (go_val_print): Remove.
5368         * go-lang.h (go_val_print): Don't declare.
5369         * go-lang.c (go_language_defn): Update.
5370         * f-valprint.c (f_val_print): Remove.
5371         * f-lang.h (f_value_print): Don't declare.
5372         * f-lang.c (f_language_defn): Update.
5373         * d-valprint.c (d_val_print): Remove.
5374         * d-lang.h (d_value_print): Don't declare.
5375         * d-lang.c (d_language_defn): Update.
5376         * cp-valprint.c (cp_print_value_fields)
5377         (cp_print_value_fields_rtti, cp_print_value): Remove.
5378         (cp_print_static_field): Update.
5379         * c-valprint.c (c_val_print_array, c_val_print_ptr)
5380         (c_val_print_struct, c_val_print_union, c_val_print_int)
5381         (c_val_print_memberptr, c_val_print): Remove.
5382         * c-lang.h (c_val_print_array, cp_print_value_fields)
5383         (cp_print_value_fields_rtti): Don't declare.
5384         * c-lang.c (c_language_defn, cplus_language_defn)
5385         (asm_language_defn, minimal_language_defn): Update.
5386         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
5387         (ada_val_print_enum): Take a struct value.
5388         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
5389         (ada_val_print): Remove.
5390         (ada_value_print_1): Update.
5391         (printable_val_type): Remove.
5392         * ada-lang.h (ada_val_print): Don't declare.
5393         * ada-lang.c (ada_language_defn): Update.
5394
5395 2020-03-13  Tom Tromey  <tom@tromey.com>
5396
5397         * valprint.c (do_val_print): Update.
5398         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
5399         a struct value.
5400         (value_to_value_object_no_release): Declare.
5401         * python/py-value.c (value_to_value_object_no_release): New
5402         function.
5403         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
5404         struct value.
5405         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
5406         function.
5407         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
5408         a struct value.
5409         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
5410         Declare.
5411         (gdbscm_apply_val_pretty_printer): Take a struct value.
5412         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
5413         value.
5414         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
5415         value.
5416         * extension-priv.h (struct extension_language_ops)
5417         <apply_val_pretty_printer>: Take a struct value.
5418         * cp-valprint.c (cp_print_value): Create a struct value.
5419         (cp_print_value): Update.
5420
5421 2020-03-13  Tom Tromey  <tom@tromey.com>
5422
5423         * ada-valprint.c (print_field_values): Call common_val_print.
5424
5425 2020-03-13  Tom Tromey  <tom@tromey.com>
5426
5427         * ada-valprint.c (val_print_packed_array_elements): Remove
5428         bitoffset and val parameters.  Call common_val_print.
5429         (ada_val_print_string): Remove offset, address, and original_value
5430         parameters.
5431         (ada_val_print_array): Update.
5432         (ada_value_print_array): New function.
5433         (ada_value_print_1): Call it.
5434
5435 2020-03-13  Tom Tromey  <tom@tromey.com>
5436
5437         * ada-valprint.c (ada_value_print): Use common_val_print.
5438
5439 2020-03-13  Tom Tromey  <tom@tromey.com>
5440
5441         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
5442
5443 2020-03-13  Tom Tromey  <tom@tromey.com>
5444
5445         * ada-valprint.c (ada_value_print_num): New function.
5446         (ada_value_print_1): Use it.
5447
5448 2020-03-13  Tom Tromey  <tom@tromey.com>
5449
5450         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
5451
5452 2020-03-13  Tom Tromey  <tom@tromey.com>
5453
5454         * ada-valprint.c (ada_value_print_ptr): New function.
5455         (ada_value_print_1): Use it.
5456
5457 2020-03-13  Tom Tromey  <tom@tromey.com>
5458
5459         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
5460         call common_val_print.
5461         (ada_val_print_1): Update.
5462         (ada_value_print_1): New function.
5463         (ada_value_print_inner): Rewrite.
5464
5465 2020-03-13  Tom Tromey  <tom@tromey.com>
5466
5467         * cp-valprint.c (cp_print_value_fields): Update.
5468         (cp_print_value): New function.
5469
5470 2020-03-13  Tom Tromey  <tom@tromey.com>
5471
5472         * m2-valprint.c (m2_value_print_inner): Use
5473         cp_print_value_fields.
5474         * cp-valprint.c (cp_print_value_fields): New function.
5475         * c-valprint.c (c_value_print_struct): New function.
5476         (c_value_print_inner): Use c_value_print_struct.
5477         * c-lang.h (cp_print_value_fields): Declare.
5478
5479 2020-03-13  Tom Tromey  <tom@tromey.com>
5480
5481         * c-valprint.c (c_value_print_array): New function.
5482         (c_value_print_inner): Use it.
5483
5484 2020-03-13  Tom Tromey  <tom@tromey.com>
5485
5486         * c-valprint.c (c_value_print_memberptr): New function.
5487         (c_value_print_inner): Use it.
5488
5489 2020-03-13  Tom Tromey  <tom@tromey.com>
5490
5491         * c-valprint.c (c_value_print_int): New function.
5492         (c_value_print_inner): Use it.
5493
5494 2020-03-13  Tom Tromey  <tom@tromey.com>
5495
5496         * c-valprint.c (c_value_print_ptr): New function.
5497         (c_value_print_inner): Use it.
5498
5499 2020-03-13  Tom Tromey  <tom@tromey.com>
5500
5501         * c-valprint.c (c_value_print_inner): Rewrite.
5502
5503 2020-03-13  Tom Tromey  <tom@tromey.com>
5504
5505         * valprint.c (generic_value_print_complex): New function.
5506         (generic_value_print): Use it.
5507
5508 2020-03-13  Tom Tromey  <tom@tromey.com>
5509
5510         * valprint.c (generic_val_print_float): Don't call
5511         val_print_scalar_formatted.
5512         (generic_val_print, generic_value_print): Update.
5513
5514 2020-03-13  Tom Tromey  <tom@tromey.com>
5515
5516         * valprint.c (generic_value_print_char): New function
5517         (generic_value_print): Use it.
5518
5519 2020-03-13  Tom Tromey  <tom@tromey.com>
5520
5521         * valprint.c (generic_value_print_int): New function.
5522         (generic_value_print): Use it.
5523
5524 2020-03-13  Tom Tromey  <tom@tromey.com>
5525
5526         * valprint.c (generic_value_print_bool): New function.
5527         (generic_value_print): Use it.
5528
5529 2020-03-13  Tom Tromey  <tom@tromey.com>
5530
5531         * valprint.c (generic_val_print_func): Simplify.
5532         (generic_val_print, generic_value_print): Update.
5533
5534 2020-03-13  Tom Tromey  <tom@tromey.com>
5535
5536         * valprint.c (generic_val_print_flags): Remove.
5537         (generic_val_print, generic_value_print): Update.
5538         (val_print_type_code_flags): Add original_value parameter.
5539
5540 2020-03-13  Tom Tromey  <tom@tromey.com>
5541
5542         * valprint.c (generic_val_print): Update.
5543         (generic_value_print): Update.
5544         * valprint.c (generic_val_print_enum): Don't call
5545         val_print_scalar_formatted.
5546
5547 2020-03-13  Tom Tromey  <tom@tromey.com>
5548
5549         * valprint.c (generic_value_print): Call generic_value_print_ptr.
5550         * valprint.c (generic_value_print_ptr): New function.
5551
5552 2020-03-13  Tom Tromey  <tom@tromey.com>
5553
5554         * valprint.c (generic_value_print): Rewrite.
5555
5556 2020-03-13  Tom Tromey  <tom@tromey.com>
5557
5558         * p-valprint.c (pascal_object_print_value_fields)
5559         (pascal_object_print_value): New functions.
5560
5561 2020-03-13  Tom Tromey  <tom@tromey.com>
5562
5563         * p-valprint.c (pascal_value_print_inner): Rewrite.
5564
5565 2020-03-13  Tom Tromey  <tom@tromey.com>
5566
5567         * f-valprint.c (f_value_print_innner): Rewrite.
5568
5569 2020-03-13  Tom Tromey  <tom@tromey.com>
5570
5571         * m2-valprint.c (m2_print_unbounded_array): New overload.
5572         (m2_print_unbounded_array): Update.
5573         (m2_print_array_contents): Take a struct value.
5574         (m2_value_print_inner): Rewrite.
5575
5576 2020-03-13  Tom Tromey  <tom@tromey.com>
5577
5578         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
5579         (d_value_print_inner): New function.
5580         * d-lang.h (d_value_print_inner): Declare.
5581         * d-lang.c (d_language_defn): Use d_value_print_inner.
5582
5583 2020-03-13  Tom Tromey  <tom@tromey.com>
5584
5585         * go-valprint.c (go_value_print_inner): New function.
5586         * go-lang.h (go_value_print_inner): Declare.
5587         * go-lang.c (go_language_defn): Use go_value_print_inner.
5588
5589 2020-03-13  Tom Tromey  <tom@tromey.com>
5590
5591         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
5592         API.
5593         (rust_val_print): Rewrite.
5594         (rust_value_print_inner): New function, from rust_val_print.
5595         (rust_language_defn): Use rust_value_print_inner.
5596
5597 2020-03-13  Tom Tromey  <tom@tromey.com>
5598
5599         * ada-valprint.c (ada_value_print_inner): New function.
5600         * ada-lang.h (ada_value_print_inner): Declare.
5601         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
5602
5603 2020-03-13  Tom Tromey  <tom@tromey.com>
5604
5605         * f-valprint.c (f_value_print_innner): New function.
5606         * f-lang.h (f_value_print_innner): Declare.
5607         * f-lang.c (f_language_defn): Use f_value_print_innner.
5608
5609 2020-03-13  Tom Tromey  <tom@tromey.com>
5610
5611         * p-valprint.c (pascal_value_print_inner): New function.
5612         * p-lang.h (pascal_value_print_inner): Declare.
5613         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
5614
5615 2020-03-13  Tom Tromey  <tom@tromey.com>
5616
5617         * m2-valprint.c (m2_value_print_inner): New function.
5618         * m2-lang.h (m2_value_print_inner): Declare.
5619         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
5620
5621 2020-03-13  Tom Tromey  <tom@tromey.com>
5622
5623         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
5624         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
5625         * c-valprint.c (c_value_print_inner): New function.
5626         * c-lang.h (c_value_print_inner): Declare.
5627         * c-lang.c (c_language_defn, cplus_language_defn)
5628         (asm_language_defn, minimal_language_defn): Use
5629         c_value_print_inner.
5630
5631 2020-03-13  Tom Tromey  <tom@tromey.com>
5632
5633         * p-valprint.c (pascal_object_print_value_fields): Now static.
5634         * p-lang.h (pascal_object_print_value_fields): Don't declare.
5635
5636 2020-03-13  Tom Tromey  <tom@tromey.com>
5637
5638         * c-valprint.c (c_val_print_array): Simplify.
5639
5640 2020-03-13  Tom Tromey  <tom@tromey.com>
5641
5642         * valprint.c (value_print_array_elements): New function.
5643         * valprint.h (value_print_array_elements): Declare.
5644
5645 2020-03-13  Tom Tromey  <tom@tromey.com>
5646
5647         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
5648         * mips-tdep.c (mips_print_register): Use
5649         value_print_scalar_formatted.
5650
5651 2020-03-13  Tom Tromey  <tom@tromey.com>
5652
5653         * valprint.h (value_print_scalar_formatted): Declare.
5654         * valprint.c (value_print_scalar_formatted): New function.
5655
5656 2020-03-13  Tom Tromey  <tom@tromey.com>
5657
5658         * valprint.h (generic_value_print): Declare.
5659         * valprint.c (generic_value_print): New function.
5660
5661 2020-03-13  Tom Tromey  <tom@tromey.com>
5662
5663         * valprint.c (do_val_print): Call la_value_print_inner, if
5664         available.
5665         * rust-lang.c (rust_language_defn): Update.
5666         * p-lang.c (pascal_language_defn): Update.
5667         * opencl-lang.c (opencl_language_defn): Update.
5668         * objc-lang.c (objc_language_defn): Update.
5669         * m2-lang.c (m2_language_defn): Update.
5670         * language.h (struct language_defn) <la_value_print_inner>: New
5671         member.
5672         * language.c (unknown_language_defn, auto_language_defn): Update.
5673         * go-lang.c (go_language_defn): Update.
5674         * f-lang.c (f_language_defn): Update.
5675         * d-lang.c (d_language_defn): Update.
5676         * c-lang.c (c_language_defn, cplus_language_defn)
5677         (asm_language_defn, minimal_language_defn): Update.
5678         * ada-lang.c (ada_language_defn): Update.
5679
5680 2020-03-13  Tom Tromey  <tom@tromey.com>
5681
5682         * c-valprint.c (c_value_print): Use common_val_print.
5683
5684 2020-03-13  Tom Tromey  <tom@tromey.com>
5685
5686         * cp-valprint.c (cp_print_static_field): Use common_val_print.
5687
5688 2020-03-13  Tom Tromey  <tom@tromey.com>
5689
5690         * f-valprint.c (f77_print_array_1, f_val_print): Use
5691         common_val_print.
5692
5693 2020-03-13  Tom Tromey  <tom@tromey.com>
5694
5695         * riscv-tdep.c (riscv_print_one_register_info): Use
5696         common_val_print.
5697
5698 2020-03-13  Tom Tromey  <tom@tromey.com>
5699
5700         * mi/mi-main.c (output_register): Use common_val_print.
5701
5702 2020-03-13  Tom Tromey  <tom@tromey.com>
5703
5704         * infcmd.c (default_print_one_register_info): Use
5705         common_val_print.
5706
5707 2020-03-13  Tom Tromey  <tom@tromey.com>
5708
5709         * valprint.h (common_val_print_checked): Declare.
5710         * valprint.c (common_val_print_checked): New function.
5711         * stack.c (print_frame_arg): Use common_val_print_checked.
5712
5713 2020-03-13  Tom Tromey  <tom@tromey.com>
5714
5715         * valprint.c (do_val_print): New function, from val_print.
5716         (val_print): Use do_val_print.
5717         (common_val_print): Use do_val_print.
5718
5719 2020-03-13  Tom Tromey  <tom@tromey.com>
5720
5721         * valprint.c (value_print): Use scoped_value_mark.
5722
5723 2020-03-13  Tom de Vries  <tdevries@suse.de>
5724
5725         PR symtab/25646
5726         * psymtab.c (partial_symtab::partial_symtab): Don't set
5727         globals_offset and statics_offset.  Push element onto
5728         current_global_psymbols and current_static_psymbols stacks.
5729         (concat): New function.
5730         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
5731         element from current_global_psymbols and current_static_psymbols
5732         stacks.  Concat popped elements to global_psymbols and
5733         static_symbols.
5734         (add_psymbol_to_list): Use current_global_psymbols and
5735         current_static_psymbols stacks.
5736         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
5737         current_static_psymbols fields.
5738
5739 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5740
5741         * corelow.c (sniff_core_bfd): Remove.
5742         (class core_target) <m_core_vec>: Remove.
5743         (core_target::core_target): Update.
5744         (core_file_fns): Remove.
5745         (deprecated_add_core_fns): Remove.
5746         (default_core_sniffer): Remove.
5747         (sniff_core_bfd): Remove.
5748         (default_check_format): Remove.
5749         (gdb_check_format): Remove.
5750         (core_target_open): Update.
5751         (core_target::get_core_register_section): Update.
5752         (get_core_registers_cb): Update.
5753         (core_target::fetch_registers): Update.
5754         * gdbcore.h (struct core_fns): Remove.
5755         (deprecated_add_core_fns): Remove.
5756         (default_core_sniffer): Remove.
5757         (default_check_format): Remove.
5758
5759 2020-03-12  Tom Tromey  <tom@tromey.com>
5760
5761         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
5762         CORE_ADDR.
5763         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
5764
5765 2020-03-12  Tom Tromey  <tom@tromey.com>
5766
5767         * remote.c (remote_target::download_tracepoint)
5768         (remote_target::enable_tracepoint)
5769         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
5770         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
5771         sprintf_vma.
5772
5773 2020-03-12  Tom Tromey  <tom@tromey.com>
5774
5775         * symfile-mem.c: Update CORE_ADDR size assert.
5776
5777 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5778
5779         * selftest.m4: Move to gdbsupport/.
5780         * acinclude.m4: Update path to selftest.m4.
5781
5782 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5783
5784         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
5785         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
5786         gdbarch-selfselftests.c and selftest-arch.c.
5787         (SUBDIR_UNITTESTS_OBS): Rename to...
5788         (SELFTESTS_OBS): ... this.
5789         (COMMON_SFILES): Remove disasm-selftests.c and
5790         gdbarch-selftests.c.
5791         * configure.ac: Don't add selftest-arch.{c,o} to
5792         CONFIG_{SRCS,OBS}.
5793         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
5794         preprocessor conditions.
5795
5796 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5797
5798         * configure.ac: Don't source bfd/development.sh.
5799         * selftest.m4: Modify comment.
5800         * configure: Re-generate.
5801
5802 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5803
5804         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
5805         not "true" or "false".
5806         * configure: Re-generate.
5807
5808 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5809
5810         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
5811         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
5812         renamed to arm_nbsd_supply_gregset.
5813         (fetch_register): Update to call arm_nbsd_supply_gregset.
5814         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
5815         (arm_netbsd_nat_target::fetch_registers): Update.
5816         (fetch_elfcore_registers): Removed.
5817         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
5818         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
5819         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
5820         not require NetBSD system headers.
5821         (arm_nbsd_regset): New struct.
5822         (arm_nbsd_iterate_over_regset_sections): New function.
5823         (arm_netbsd_init_abi_common): Updated to call
5824         set_gdbarch_iterate_over_regset_sections.
5825         * arm-nbsd-tdep.h: New file.
5826
5827 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
5828
5829         * symtab.c (find_pc_sect_line): Add check which prevents infinite
5830         recursion.
5831
5832 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
5833
5834         * configure: Re-generate.
5835
5836 2020-03-11  Tom Tromey  <tromey@adacore.com>
5837
5838         * ada-typeprint.c (print_choices): Fix comment.
5839
5840 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5841
5842         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
5843         previous item in the list, when the list has no items.
5844
5845 2020-03-11  Tom de Vries  <tdevries@suse.de>
5846
5847         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
5848         PROP_LOCLIST handling code.
5849
5850 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * buildsym-legacy.c (record_line): Pass extra parameter to
5853         record_line.
5854         * buildsym.c (buildsym_compunit::record_line): Take an extra
5855         parameter, reduce duplication in the line table, and record the
5856         is_stmt flag in the line table.
5857         * buildsym.h (buildsym_compunit::record_line): Add extra
5858         parameter.
5859         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
5860         non-statement lines.
5861         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
5862         this to the symtab builder.
5863         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
5864         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
5865         through to dwarf_record_line_1.
5866         * infrun.c (process_event_stop_test): When stepping, don't stop at
5867         a non-statement instruction, and only refresh the step info when
5868         we land in the middle of a line's range.  Also add an extra
5869         comment.
5870         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
5871         field.
5872         * record-btrace.c (btrace_find_line_range): Only record lines
5873         marked as is-statement.
5874         * stack.c (frame_show_address): Show the frame address if we are
5875         in a non-statement sal.
5876         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
5877         (maintenance_print_one_line_table): Print a header for the is_stmt
5878         column, and include is_stmt information in the output.
5879         * symtab.c (find_pc_sect_line): Find lines marked as statements in
5880         preference to non-statements.
5881         (find_pcs_for_symtab_line): Prefer is-statement entries.
5882         (find_line_common): Likewise.
5883         * symtab.h (struct linetable_entry): Add is_stmt field.
5884         (struct symtab_and_line): Likewise.
5885         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
5886         arranging the line table.
5887
5888 2020-03-07  Tom de Vries  <tdevries@suse.de>
5889
5890         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
5891         DIE.
5892
5893 2020-03-07  Tom Tromey  <tom@tromey.com>
5894
5895         * valops.c (value_literal_complex): Remove obsolete comment.
5896         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
5897         comment.
5898
5899 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5900
5901         * infrun.h: Forward-declare thread_info.
5902         (set_step_info): Add thread_info parameter, add doc.
5903         * infrun.c (set_step_info): Add thread_info parameter, move doc
5904         to header.
5905         * infrun.c (process_event_stop_test): Pass thread to
5906         set_step_info call.
5907         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
5908         set_step_info.
5909         (prepare_one_step): Add thread_info parameter, pass it to
5910         set_step_frame and prepare_one_step (recursive) call.
5911         (step_1): Pass thread to prepare_one_step call.
5912         (step_command_fsm::should_stop): Pass thread to
5913         prepare_one_step.
5914         (until_next_fsm): Pass thread to set_step_frame call.
5915         (finish_command): Pass thread to set_step_info call.
5916
5917 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
5918
5919         * windows-tdep.c (windows_solib_create_inferior_hook):
5920         Check if inferior is running.
5921
5922 2020-03-06  Tom de Vries  <tdevries@suse.de>
5923
5924         * NEWS: Fix "the the".
5925         * ctfread.c: Same.
5926
5927 2020-03-06  Tom de Vries  <tdevries@suse.de>
5928
5929         * psymtab.c (psymtab_to_symtab): Don't print "done.".
5930
5931 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * .dir-locals.el: Add a comment referencing the other copies of
5934         this file.
5935
5936 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
5937
5938         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
5939         psargs.
5940
5941 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5942
5943         * .gitattributes: New file.
5944
5945 2020-03-04  Tom Tromey  <tom@tromey.com>
5946
5947         * symmisc.c (print_symbol_bcache_statistics)
5948         (print_objfile_statistics): Update.
5949         * symfile.c (allocate_symtab): Use intern.
5950         * psymtab.c (partial_symtab::partial_symtab): Use intern.
5951         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5952         macro_cache>: Remove.
5953         <string_cache>: New member.
5954         (struct objfile) <intern>: New methods.
5955         * elfread.c (elf_symtab_read): Use intern.
5956         * dwarf2/read.c (fixup_go_packaging): Intern package name.
5957         (dwarf2_compute_name, dwarf2_physname)
5958         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
5959         names.
5960         (guess_partial_die_structure_name): Update.
5961         (partial_die_info::fixup): Intern name.
5962         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
5963         name.
5964         (dwarf2_name): Intern name.  Update.
5965         * buildsym.c (buildsym_compunit::get_macro_table): Use
5966         string_cache.
5967
5968 2020-03-04  Tom Tromey  <tom@tromey.com>
5969
5970         * jit.c (bfd_open_from_target_memory): Make "target" const.
5971         * corefile.c (gnutarget): Now const.
5972         * gdbcore.h (gnutarget): Now const.
5973
5974 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
5975
5976         * NEWS: Mention support for WOW64 processes.
5977         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
5978         (amd64_windows_segment_register_p): Remove static.
5979         (_initialize_amd64_windows_nat): Update.
5980         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
5981         * i386-windows-nat.c (context_offset): Update.
5982         (i386_mappings): Rename and remove static.
5983         (i386_windows_segment_register_p): Remove static.
5984         (_initialize_i386_windows_nat): Update.
5985         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
5986         (STATUS_WX86_SINGLE_STEP): New macro.
5987         (EnumProcessModulesEx): New macro.
5988         (Wow64SuspendThread): New macro.
5989         (Wow64GetThreadContext): New macro.
5990         (Wow64SetThreadContext): New macro.
5991         (Wow64GetThreadSelectorEntry): New macro.
5992         (windows_set_context_register_offsets): Add static.
5993         (windows_set_segment_register_p): Likewise.
5994         (windows_add_thread): Adapt for WOW64 processes.
5995         (windows_fetch_one_register): Likewise.
5996         (windows_nat_target::fetch_registers): Likewise.
5997         (windows_store_one_register): Likewise.
5998         (display_selector): Likewise.
5999         (display_selectors): Likewise.
6000         (handle_exception): Likewise.
6001         (windows_continue): Likewise.
6002         (windows_nat_target::resume): Likewise.
6003         (windows_add_all_dlls): Likewise.
6004         (do_initial_windows_stuff): Likewise.
6005         (windows_nat_target::attach): Likewise.
6006         (windows_get_exec_module_filename): Likewise.
6007         (windows_nat_target::create_inferior): Likewise.
6008         (windows_xfer_siginfo): Likewise.
6009         (_initialize_loadable): Initialize Wow64SuspendThread,
6010         Wow64GetThreadContext, Wow64SetThreadContext,
6011         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6012         * windows-nat.h (windows_set_context_register_offsets):
6013         Remove declaration.
6014         (windows_set_segment_register_p): Likewise.
6015         (i386_windows_segment_register_p): Add declaration.
6016         (amd64_windows_segment_register_p): Likewise.
6017
6018 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6019
6020         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6021         in "info registers" for AArch64/ARM.
6022
6023         The change caused "info registers" to not print GPR's.
6024
6025         gdb/ChangeLog:
6026
6027         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6028
6029         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6030         when reg->group is empty and reggroup is not.
6031
6032 2020-03-03  Tom Tromey  <tromey@adacore.com>
6033
6034         * dwarf2/frame.c (struct dwarf2_frame_cache)
6035         <checked_tailcall_bottom, entry_cfa_sp_offset,
6036         entry_cfa_sp_offset_p>: Remove members.
6037         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6038         (dwarf2_frame_prev_register): Don't call
6039         dwarf2_tailcall_sniffer_first.
6040         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6041         * frame-unwind.c (add_unwinder): New fuction.
6042         (frame_unwind_init): Use it.  Add tailcall unwinder.
6043
6044 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6045             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6046
6047         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6048         value should be printed as true.
6049
6050 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6051
6052         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6053         (windows_init_abi): Set and use windows_so_ops.
6054
6055 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6056
6057         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6058         when verifying if dealing with a convenience variable.
6059
6060 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6061
6062         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6063
6064 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6065
6066         * infrun.c (gdbarch_supports_displaced_stepping): New.
6067         (use_displaced_stepping): Break up conditions in smaller pieces.
6068         Use gdbarch_supports_displaced_stepping.
6069         (displaced_step_prepare_throw): Use
6070         gdbarch_supports_displaced_stepping.
6071
6072 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6073
6074         * NEWS: Mention new behaviour of the history filename.
6075         * top.c (write_history_p): Add comment.
6076         (show_write_history_p): Add header comment, give a different
6077         message when history writing is on, but the history filename is
6078         empty.
6079         (history_filename): Add comment.
6080         (history_filename_empty): New function.
6081         (show_history_filename): Add header comment, give a different
6082         message when the filename is empty.
6083         (init_history): Compare history_filename against nullptr, and only
6084         read history if the filename is not empty.
6085         (set_history_filename): Add header comment, and only make
6086         non-empty filenames absolute.
6087         (init_main): Make the filename argument to 'set history filename'
6088         optional.
6089
6090 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
6091
6092         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
6093         (arm_supply_vfpregset): ...this, and update to use VFP registers.
6094         (fetch_fp_register): Update.
6095         (fetch_fp_regs): Update.
6096         (store_fp_register): Update.
6097         (store_fp_regs): Update.
6098         (arm_netbsd_nat_target::read_description): New function.
6099         (fetch_elfcore_registers): Update.
6100
6101 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6102
6103         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
6104         general_thread if the stop reply is missing a thread-id.
6105         (remote_target::process_stop_reply): Use the first non-exited
6106         thread if the target didn't pass a thread-id.
6107         * infrun.c (do_target_wait): Move call to
6108         switch_to_inferior_no_thread to ....
6109         (do_target_wait_1): ... here.
6110
6111 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
6112
6113         * debuginfod-support.c: Include defs.h first.
6114
6115 2020-02-28  Tom de Vries  <tdevries@suse.de>
6116
6117         * symfile.c (set_initial_language): Use default language for lookup.
6118
6119 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
6120
6121         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
6122         reader variable, pass `this` to read_cutu_die_from_dwo.
6123
6124 2020-02-27  Aaron Merey  <amerey@redhat.com>
6125
6126         * source.c (open_source_file): Check for nullptr when computing
6127         srcpath.
6128
6129 2020-02-27  Tom Tromey  <tromey@adacore.com>
6130
6131         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
6132         member.
6133         (dwarf2_add_field): Don't update nfields.
6134         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
6135
6136 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
6139         abs.
6140
6141 2020-02-26  Tom Tromey  <tom@tromey.com>
6142
6143         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
6144         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
6145         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
6146         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
6147         per_cu_data.
6148
6149 2020-02-26  Tom Tromey  <tom@tromey.com>
6150
6151         * dwarf2/index-write.c (psym_index_map): Change type.
6152         (add_address_entry_worker, write_one_signatured_type)
6153         (recursively_count_psymbols, recursively_write_psymbols)
6154         (class debug_names, psyms_seen_size, write_gdbindex)
6155         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
6156
6157 2020-02-26  Aaron Merey  <amerey@redhat.com>
6158
6159         * Makefile.in: Handle optional debuginfod support.
6160         * NEWS: Update.
6161         * README: Add --with-debuginfod summary.
6162         * config.in: Regenerate.
6163         * configure: Regenerate.
6164         * configure.ac: Handle optional debuginfod support.
6165         * debuginfod-support.c: debuginfod helper functions.
6166         * debuginfod-support.h: Ditto.
6167         * doc/gdb.texinfo: Add --with-debuginfod to configure options
6168         summary.
6169         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
6170         when a dwz file cannot be found.
6171         * elfread.c (elf_symfile_read): Query debuginfod servers when a
6172         debuginfo file cannot be found.
6173         * source.c (open_source_file): Query debuginfod servers when a
6174         source file cannot be found.
6175         * top.c (print_gdb_configuration): Include
6176         --{with,without}-debuginfod in the output.
6177
6178 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
6179
6180         * thread.c (thr_try_catch_cmd): Print thread name.
6181
6182 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
6183
6184         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
6185         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6186         dwarf2_fetch_die_type_sect_off): Move to...
6187         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
6188         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6189         dwarf2_fetch_die_type_sect_off): ... here.
6190         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
6191         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6192         dwarf2_fetch_die_type_sect_off): Move doc to header file.
6193
6194 2020-02-26  Tom de Vries  <tdevries@suse.de>
6195
6196         PR gdb/25603
6197         * symfile.c (set_initial_language): Exit-early if
6198         language_mode == language_mode_manual.
6199
6200 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6201
6202         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
6203         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
6204         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
6205
6206 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * gdbtypes.c (create_array_type_with_stride): Handle negative
6209         array strides.
6210         * valarith.c (value_subscripted_rvalue): Likewise.
6211
6212 2020-02-25  Luis Machado  <luis.machado@linaro.org>
6213
6214         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
6215
6216 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6217
6218         * loc.h (dwarf2_get_die_type): Move to...
6219         * read.h (dwarf2_get_die_type): ... here.
6220         * read.c (dwarf2_get_die_type): Move doc to header.
6221
6222 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
6223
6224         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
6225         'gnulib/Makefile.in' to the list.
6226
6227 2020-02-24  Tom Tromey  <tom@tromey.com>
6228
6229         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
6230         Remove.
6231         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
6232         XOBNEWVEC.
6233
6234 2020-02-24  Tom Tromey  <tom@tromey.com>
6235
6236         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
6237         New method.
6238         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
6239         (dw2_do_instantiate_symtab, dw2_get_file_names)
6240         (build_type_psymtab_dependencies, load_full_type_unit): Update.
6241
6242 2020-02-24  Tom Tromey  <tom@tromey.com>
6243
6244         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
6245         make_scoped_restore.
6246         (dwarf2_psymtab::read_symtab): Don't clear
6247         reading_partial_symbols.
6248
6249 2020-02-24  Tom de Vries  <tdevries@suse.de>
6250
6251         PR gdb/25592
6252         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
6253
6254 2020-02-24  Tom de Vries  <tdevries@suse.de>
6255
6256         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
6257         commands layout next/prev/regs.
6258
6259 2020-02-22  Tom Tromey  <tom@tromey.com>
6260
6261         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
6262         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
6263
6264 2020-02-22  Tom Tromey  <tom@tromey.com>
6265
6266         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
6267
6268 2020-02-22  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-win.c (_initialize_tui_win): Add usage text.
6271         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
6272         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
6273         * tui/tui.c (_initialize_tui): Add usage text.
6274
6275 2020-02-22  Tom Tromey  <tom@tromey.com>
6276
6277         * tui/tui-win.c (tui_set_focus_command)
6278         (tui_set_win_height_command): Use error_no_arg.
6279         (_initialize_tui_win): Update help text.
6280         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
6281
6282 2020-02-22  Tom Tromey  <tom@tromey.com>
6283
6284         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
6285         * tui/tui-disasm.h (struct tui_disasm_window)
6286         <display_start_addr>: Declare.
6287         * tui/tui-source.h (struct tui_source_window)
6288         <display_start_addr>: Declare.
6289         * tui/tui-winsource.h (struct tui_source_window_base)
6290         <show_source_line, display_start_addr>: New methods.
6291         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
6292         Rename and move to protected section.
6293         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
6294         (tui_source_window_base::do_erase_source_content): Update.
6295         (tui_source_window_base::show_source_line): Now a method.
6296         (tui_source_window_base::show_source_content)
6297         (tui_source_window_base::tui_source_window_base)
6298         (tui_source_window_base::rerender)
6299         (tui_source_window_base::refill)
6300         (tui_source_window_base::do_scroll_horizontal)
6301         (tui_source_window_base::set_is_exec_point_at)
6302         (tui_source_window_base::update_breakpoint_info)
6303         (tui_source_window_base::update_exec_info): Update.
6304         * tui/tui-source.c (tui_source_window::set_contents)
6305         (tui_source_window::showing_source_p)
6306         (tui_source_window::do_scroll_vertical)
6307         (tui_source_window::location_matches_p)
6308         (tui_source_window::line_is_displayed): Update.
6309         (tui_source_window::display_start_addr): New method.
6310         * tui/tui-disasm.c (tui_disasm_window::set_contents)
6311         (tui_disasm_window::do_scroll_vertical)
6312         (tui_disasm_window::location_matches_p): Update.
6313         (tui_disasm_window::display_start_addr): New method.
6314
6315 2020-02-22  Tom Tromey  <tom@tromey.com>
6316
6317         * NEWS: Add entry for gdb.register_window_type.
6318         * tui/tui-layout.h (window_factory): New typedef.
6319         (tui_register_window): Declare.
6320         * tui/tui-layout.c (saved_tui_windows): New global.
6321         (tui_apply_current_layout): Use it.
6322         (tui_register_window): New function.
6323         * python/python.c (do_start_initialization): Call
6324         gdbpy_initialize_tui.
6325         (python_GdbMethods): Add "register_window_type" function.
6326         * python/python-internal.h (gdbpy_register_tui_window)
6327         (gdbpy_initialize_tui): Declare.
6328         * python/py-tui.c: New file.
6329         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
6330
6331 2020-02-22  Tom Tromey  <tom@tromey.com>
6332
6333         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
6334
6335 2020-02-22  Tom Tromey  <tom@tromey.com>
6336
6337         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
6338         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
6339         * tui/tui-data.c (tui_set_win_with_focus): Remove.
6340         (tui_set_win_focus_to): Move from tui-win.c.
6341
6342 2020-02-22  Tom Tromey  <tom@tromey.com>
6343
6344         * tui/tui-layout.c (make_standard_window, get_locator_window): New
6345         functions.
6346         (known_window_types): New global.
6347         (tui_get_window_by_name): Reimplement.
6348         (initialize_known_windows): New function.
6349         (validate_window_name): Rewrite.
6350         (_initialize_tui_layout): Call initialize_known_windows.
6351
6352 2020-02-22  Tom Tromey  <tom@tromey.com>
6353
6354         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
6355         Remove constants.
6356         * tui/tui-winsource.h (struct tui_source_window_base)
6357         <tui_source_window_base>: Remove parameter.
6358         * tui/tui-winsource.c
6359         (tui_source_window_base::tui_source_window_base): Remove
6360         parameter.
6361         (tui_source_window_base::refill): Update.
6362         * tui/tui-stack.h (struct tui_locator_window)
6363         <tui_locator_window>: Update.
6364         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
6365         Default the constructor.
6366         * tui/tui-regs.h (struct tui_data_item_window)
6367         <tui_data_item_window>: Default the constructor.
6368         (struct tui_data_window) <tui_data_window>: Likewise.
6369         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
6370         Default the constructor.
6371         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
6372         Default the constructor.
6373         <type>: Remove.
6374         (struct tui_win_info) <tui_win_info>: Default the constructor.
6375         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
6376         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
6377         Default the constructor.
6378
6379 2020-02-22  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
6382         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
6383         * tui/tui-win.c (tui_resize_all): Don't call
6384         tui_delete_invisible_windows.
6385         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
6386         done.
6387         (tui_set_layout): Update.
6388         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
6389         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
6390         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
6391
6392 2020-02-22  Tom Tromey  <tom@tromey.com>
6393
6394         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
6395         correctly.
6396
6397 2020-02-22  Tom Tromey  <tom@tromey.com>
6398
6399         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
6400
6401 2020-02-22  Tom Tromey  <tom@tromey.com>
6402
6403         * tui/tui-winsource.h (struct tui_source_window_iterator)
6404         <inner_iterator>: New etytypedef.
6405         <tui_source_window_iterator>: Take "end" parameter.
6406         <tui_source_window_iterator>: Take iterator.
6407         <operator*, advance>: Update.
6408         <m_iter>: Change type.
6409         <m_end>: New field.
6410         (struct tui_source_windows) <begin, end>: Update.
6411         * tui/tui-layout.c (tui_windows): New global.
6412         (tui_apply_current_layout): Clear tui_windows.
6413         (tui_layout_window::apply): Update tui_windows.
6414         * tui/tui-data.h (tui_windows): Declare.
6415         (all_tui_windows): Now inline function.
6416         (class tui_window_iterator, struct all_tui_windows): Remove.
6417
6418 2020-02-22  Tom Tromey  <tom@tromey.com>
6419
6420         PR tui/17850:
6421         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
6422         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
6423         "height" argument.
6424         (class tui_layout_window) <get_sizes>: Likewise.
6425         (class tui_layout_split) <tui_layout_split>: Add "vertical"
6426         argument.
6427         <get_sizes>: Add "height" argument.
6428         <m_vertical>: New field.
6429         * tui/tui-layout.c (tui_layout_split::clone): Update.
6430         (tui_layout_split::get_sizes): Add "height" argument.
6431         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
6432         (tui_new_layout_command): Parse "-horizontal".
6433         (_initialize_tui_layout): Update help string.
6434         (tui_layout_split::specification): Add "-horizontal" when needed.
6435         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
6436         argument.
6437         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
6438         New methods.
6439
6440 2020-02-22  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui-layout.h (enum tui_adjust_result): New.
6443         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
6444         (class tui_layout_window) <adjust_size>: Return
6445         tui_adjust_result.  Rewrite.
6446         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
6447         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
6448
6449 2020-02-22  Tom Tromey  <tom@tromey.com>
6450
6451         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
6452         parameter and return types.
6453         (class tui_layout_base) <specification>: Add "depth".
6454         (class tui_layout_window) <specification>: Add "depth".
6455         (class tui_layout_split) <specification>: Add "depth".
6456         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
6457         and return types.
6458         (tui_new_layout_command): Parse sub-layouts.
6459         (_initialize_tui_layout): Update help string.
6460         (tui_layout_window::specification): Add "depth".
6461         (add_layout_command): Update.
6462
6463 2020-02-22  Tom Tromey  <tom@tromey.com>
6464
6465         * NEWS: Add "tui new-layout" item.
6466         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
6467         Add new-layout command to help text.
6468         (validate_window_name): New function.
6469         (tui_new_layout_command): New function.
6470         (_initialize_tui_layout): Register "new-layout".
6471         (tui_layout_window::specification): New method.
6472         (tui_layout_window::specification): New method.
6473         * tui/tui-layout.h (class tui_layout_base) <specification>: New
6474         method.
6475         (class tui_layout_window) <specification>: New method.
6476         (class tui_layout_split) <specification>: New method.
6477
6478 2020-02-22  Tom Tromey  <tom@tromey.com>
6479
6480         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
6481         * tui/tui-win.c (window_name_completer): Update comment.
6482         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
6483         Declare method.
6484         (class tui_layout_window) <replace_window>: Likewise.
6485         (class tui_layout_split) <replace_window>: Likewise.
6486         (tui_set_layout): Don't declare.
6487         (tui_set_initial_layout): Declare function.
6488         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
6489         (asm_regs_layout): New globals.
6490         (tui_current_layout, show_layout): Remove.
6491         (tui_set_layout, tui_add_win_to_layout): Rewrite.
6492         (find_layout, tui_apply_layout): New function.
6493         (layout_completer): Remove.
6494         (tui_next_layout): Reimplement.
6495         (tui_next_layout_command): New function.
6496         (tui_set_initial_layout, tui_prev_layout_command): New functions.
6497         (tui_regs_layout): Reimplement.
6498         (tui_regs_layout_command): New function.
6499         (extract_display_start_addr): Rewrite.
6500         (next_layout, prev_layout): Remove.
6501         (tui_layout_window::replace_window): New method.
6502         (tui_layout_split::replace_window): New method.
6503         (destroy_layout): New function.
6504         (layout_list): New global.
6505         (add_layout_command): New function.
6506         (initialize_layouts): Update.
6507         (tui_layout_command): New function.
6508         (_initialize_tui_layout): Install "layout" commands.
6509         * tui/tui-data.h (enum tui_layout_type): Remove.
6510         (tui_current_layout): Don't declare.
6511
6512 2020-02-22  Tom Tromey  <tom@tromey.com>
6513
6514         * tui/tui-regs.c (tui_reg_layout): Remove.
6515         (tui_reg_command): Use tui_regs_layout.
6516         * tui/tui-layout.h (tui_reg_command): Declare.
6517         * tui/tui-layout.c (tui_reg_command): New function.
6518
6519 2020-02-22  Tom Tromey  <tom@tromey.com>
6520
6521         * tui/tui.c (tui_rl_delete_other_windows): Call
6522         tui_remove_some_windows.
6523         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
6524         Declare method.
6525         (class tui_layout_window) <remove_windows>: New method.
6526         (class tui_layout_split) <remove_windows>: Declare.
6527         (tui_remove_some_windows): Declare.
6528         * tui/tui-layout.c (tui_remove_some_windows): New function.
6529         (tui_layout_split::remove_windows): New method.
6530
6531 2020-02-22  Tom Tromey  <tom@tromey.com>
6532
6533         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
6534         * tui/tui-layout.h (tui_next_layout): Declare.
6535         * tui/tui-layout.c (tui_next_layout): New function.
6536
6537 2020-02-22  Tom Tromey  <tom@tromey.com>
6538
6539         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
6540         correct coordinates.
6541
6542 2020-02-22  Tom Tromey  <tom@tromey.com>
6543
6544         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
6545         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
6546         DATA_WIN case.
6547
6548 2020-02-22  Tom Tromey  <tom@tromey.com>
6549
6550         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
6551         TUI_DISASM_WIN, not tui_win_list.
6552
6553 2020-02-22  Tom Tromey  <tom@tromey.com>
6554
6555         * valprint.c (generic_val_print_enum_1)
6556         (val_print_type_code_flags): Style member names.
6557         * rust-lang.c (val_print_struct, rust_print_enum)
6558         (rust_print_struct_def, rust_internal_print_type): Style member
6559         names.
6560         * p-valprint.c (pascal_object_print_value_fields): Style member
6561         names.  Only call fprintf_symbol_filtered for static members.
6562         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
6563         * f-valprint.c (f_val_print): Style member names.
6564         * f-typeprint.c (f_type_print_base): Style member names.
6565         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
6566         call fprintf_symbol_filtered for static members.
6567         (cp_print_class_member): Style member names.
6568         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
6569         member names.
6570         * ada-valprint.c (ada_print_scalar): Style enum names.
6571         (ada_val_print_enum): Likewise.
6572         * ada-typeprint.c (print_enum_type): Style enum names.
6573
6574 2020-02-21  Tom Tromey  <tom@tromey.com>
6575
6576         * psympriv.h (struct partial_symtab): Update comment.
6577
6578 2020-02-21  Tom Tromey  <tromey@adacore.com>
6579
6580         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
6581         type is CORE_ADDR.
6582
6583 2020-02-21  Tom de Vries  <tdevries@suse.de>
6584
6585         PR gdb/25534
6586         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
6587         if dependencies[i]->user != NULL.
6588
6589 2020-02-21  Ali Tamur  <tamur@google.com>
6590
6591         * dwarf2/read.c (dwarf2_name): Add null check.
6592
6593 2020-02-20  Tom Tromey  <tom@tromey.com>
6594
6595         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
6596         ">=", in binary search.
6597         (dwarf2_find_containing_comp_unit): New overload.
6598         (run_test): New self-test.
6599         (_initialize_dwarf2_read): Register new test.
6600
6601 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
6602
6603         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
6604         * riscv-tdep.h: Likewise.
6605         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
6606         rv32-only CSR.
6607         * features/riscv/64bit-csr.xml: Regenerated.
6608
6609 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
6610             Tom Tromey  <tom@tromey.com>
6611
6612         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
6613         of 'fputc_unfiltered'.
6614         (putchar_unfiltered): Call 'fputc_unfiltered'.
6615         (fputc_unfiltered): Call 'fputs_unfiltered'.
6616
6617 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * config.in: Regenerate.
6620         * configure: Regenerate.
6621         * configure.ac: Add --with-python-libdir option.
6622         * main.c: Use WITH_PYTHON_LIBDIR.
6623
6624 2020-02-19  Tom Tromey  <tom@tromey.com>
6625
6626         * symtab.c (general_symbol_info::compute_and_set_names): Use
6627         obstack_strndup.  Simplify call to symbol_set_demangled_name.
6628
6629 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
6630
6631         * dwarf2/read.c (allocate_signatured_type_table,
6632         allocate_dwo_unit_table, allocate_type_unit_groups_table,
6633         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
6634         Remove objfile parameter, update all callers.
6635
6636 2020-02-19  Doug Evans  <dje@google.com>
6637
6638         PR rust/25535
6639         * rust-lang.c (rust_print_enum): Apply embedded_offset to
6640         rust_enum_variant calculation.
6641
6642 2020-02-19  Tom Tromey  <tromey@adacore.com>
6643
6644         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
6645
6646 2020-02-19  Tom Tromey  <tromey@adacore.com>
6647
6648         * ada-lang.c (cache_symbol): Use obstack_strdup.
6649
6650 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * configure: Regenerate.
6653
6654 2020-02-19  Tom Tromey  <tromey@adacore.com>
6655
6656         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
6657         NULL check.
6658
6659 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
6660
6661         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
6662
6663 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6664
6665         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
6666         if GDBSERVER is not defined.
6667         (riscv_tdesc_cache): Likewise, also store const target_desc.
6668         (STATIC_IN_GDB): Define.
6669         (riscv_create_target_description): Update declaration with
6670         STATIC_IN_GDB.
6671         (riscv_lookup_target_description): New function, only define if
6672         GDBSERVER is not defined.
6673         * arch/riscv.h (riscv_create_target_description): Declare only
6674         when GDBSERVER is defined.
6675         (riscv_lookup_target_description): New declaration when GDBSERVER
6676         is not defined.
6677         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
6678         (riscv_linux_read_features): ...this, and return
6679         riscv_gdbarch_features instead of target_desc.
6680         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
6681         (riscv_linux_read_description): Rename to...
6682         (riscv_linux_read_features): ...this.
6683         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
6684         Update to use riscv_gdbarch_features and
6685         riscv_lookup_target_description.
6686         * riscv-tdep.c (riscv_find_default_target_description): Use
6687         riscv_lookup_target_description instead of
6688         riscv_create_target_description.
6689
6690 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6691
6692         * valprint.c (generic_val_print_enum_1): When printing a flag
6693         enum with value 0 and there is no enumerator with value 0, print
6694         just "0" instead of "(unknown: 0x0)".
6695
6696 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6697
6698         * valprint.c (generic_val_print_enum_1): Print unknown part of
6699         flag enum in hex.
6700
6701 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6702
6703         * dwarf2/read.c (update_enumeration_type_from_children): Allow
6704         flag enums to contain duplicate enumerators.
6705         * valprint.c (generic_val_print_enum_1): Update comment.
6706
6707 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6708
6709         * dwarf2/read.c: Include "count-one-bits.h".
6710         (update_enumeration_type_from_children): If an enumerator has
6711         multiple bits set, don't treat the enumeration as a "flag enum".
6712         * valprint.c (generic_val_print_enum_1): Assert that enumerators
6713         of flag enums have 0 or 1 bit set.
6714
6715 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6716
6717         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
6718         conversion.
6719         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6720         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6721         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6722         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6723         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6724
6725 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6726
6727         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
6728
6729 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6730
6731         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
6732         displaced_step_closure_up.
6733         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6734         (struct displaced_step_closure_up):
6735         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6736         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6737         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
6738         Likewise.
6739         * gdbarch.sh (displaced_step_copy_insn): Likewise.
6740         * gdbarch.c, gdbarch.h: Re-generate.
6741         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
6742         displaced_step_closure_up.
6743         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6744         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6745         * infrun.h (displaced_step_closure_up): New type alias.
6746         (struct displaced_step_inferior_state) <step_closure>: Change
6747         type to displaced_step_closure_up.
6748         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
6749         displaced_step_closure_up.
6750         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6751
6752 2020-02-14  Tom Tromey  <tom@tromey.com>
6753
6754         * minidebug.c (gnu_debug_key): New global.
6755         (find_separate_debug_file_in_section): Use it.
6756
6757 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6758
6759         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
6760         std::unique_ptr.
6761         * gdbarch.c: Re-generate.
6762         * gdbarch.h: Re-generate.
6763         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
6764         change.
6765         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
6766         type to std::unique_ptr.
6767         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6768         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6769         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6770         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6771         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
6772         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6773         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6774         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6775         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6776
6777 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6778
6779         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
6780         std::unique_ptr.
6781         (displaced_step_clear): Rename to...
6782         (displaced_step_reset): ... this.  Just call displaced->reset ().
6783         (displaced_step_clear_cleanup): Rename to...
6784         (displaced_step_reset_cleanup): ... this.
6785         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
6786         (displaced_step_fixup): Likewise.
6787         (resume_1): Likewise.
6788         (handle_inferior_event): Restore child's memory before calling
6789         displaced_step_fixup on the parent.
6790         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
6791         to std::unique_ptr.
6792         <step_closure>: Change type to std::unique_ptr.
6793
6794 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6795
6796         * arm-tdep.c: Include count-one-bits.h.
6797         (cleanup_block_store_pc): Use count_one_bits.
6798         (cleanup_block_load_pc): Use count_one_bits.
6799         (arm_copy_block_xfer): Use count_one_bits.
6800         (thumb2_copy_block_xfer): Use count_one_bits.
6801         (thumb_copy_pop_pc_16bit): Use count_one_bits.
6802         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
6803         (thumb_get_next_pcs_raw): Use count_one_bits.
6804         (arm_get_next_pcs_raw): Use count_one_bits_l.
6805         * arch/arm.c (bitcount): Remove.
6806         * arch/arm.h (bitcount): Remove.
6807
6808 2020-02-14  Tom Tromey  <tromey@adacore.com>
6809
6810         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
6811         Update.
6812         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
6813         * dwarf2/loc.c (call_site_find_chain_1): Return
6814         unique_xmalloc_ptr.
6815         (call_site_find_chain): Likewise.
6816
6817 2020-02-14  Richard Biener  <rguenther@suse.de>
6818
6819         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
6820         on expression with division operators.
6821
6822 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6823
6824         * MAINTAINERS (Write After Approval): Adding myself.
6825
6826 2020-02-12  Tom Tromey  <tom@tromey.com>
6827
6828         * event-loop.c (event_data, gdb_event, event_handler_func):
6829         Remove.
6830
6831 2020-02-12  Tom Tromey  <tom@tromey.com>
6832
6833         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
6834         (dwarf2_frame_objfile_data): Add comment.
6835         (find_comp_unit, set_comp_unit): New functions.
6836         (dwarf2_frame_find_fde): Use find_comp_unit.
6837         (dwarf2_build_frame_info): Use set_comp_unit.
6838
6839 2020-02-12  Tom Tromey  <tom@tromey.com>
6840
6841         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
6842         (comp_unit): Don't initialize objfile.
6843         (execute_cfa_program): Add text_offset parameter.
6844         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
6845         (dwarf2_frame_cache): Update.
6846         (dwarf2_build_frame_info): Don't set "objfile" member.
6847
6848 2020-02-12  Tom Tromey  <tom@tromey.com>
6849
6850         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
6851         (decode_frame_entry): Likewise.
6852         (dwarf2_build_frame_info): Update.
6853
6854 2020-02-12  Tom Tromey  <tom@tromey.com>
6855
6856         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
6857         (decode_frame_entry_1): Use the comp_unit obstack.
6858
6859 2020-02-12  Tom Tromey  <tom@tromey.com>
6860
6861         * dwarf2/frame.c (struct comp_unit): Add initializers and
6862         constructor.
6863         (dwarf2_frame_objfile_data): Store a comp_unit.
6864         (dwarf2_frame_find_fde): Update.
6865         (dwarf2_build_frame_info): Use "new".
6866
6867 2020-02-12  Tom Tromey  <tom@tromey.com>
6868
6869         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
6870         (dwarf2_fde_table): Typedef for std::vector.
6871         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
6872         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
6873         (decode_frame_entry): Update.
6874         (dwarf2_build_frame_info): Use "new".
6875
6876 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
6877
6878         * arm-tdep.c (arm_gdbarch_init): Update.
6879         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
6880         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
6881         have_neon, is_m>: Change to bool.
6882
6883 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
6884
6885         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
6886
6887 2020-02-12  Tom Tromey  <tom@tromey.com>
6888
6889         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
6890
6891 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
6892
6893         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
6894         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
6895
6896 2020-02-11  Tom Tromey  <tom@tromey.com>
6897
6898         * psymtab.h: Update comment.
6899
6900 2020-02-11  Tom Tromey  <tom@tromey.com>
6901
6902         * gdb_obstack.h (struct auto_obstack): Use
6903         DISABLE_COPY_AND_ASSIGN.
6904
6905 2020-02-11  Tom Tromey  <tom@tromey.com>
6906
6907         * dwarf2/frame.h (struct objfile): Don't forward declare.
6908
6909 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
6910
6911         * cris-tdep.c (cris_supply_gregset): Change signature to match
6912         what struct regset expects.
6913         (cris_regset): New struct.
6914         (fetch_core_registers): Remove.
6915         (cris_iterate_over_regset_sections): New function.
6916         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
6917         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
6918
6919 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
6920
6921         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
6922         registers.
6923
6924 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
6925
6926         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
6927
6928 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
6929
6930         * configure: Re-generate.
6931
6932 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
6933
6934         * configure: Re-generate.
6935
6936 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
6937
6938         * acinclude: Update warning.m4 path.
6939         * warning.m4: Move to gdbsupport.
6940
6941 2020-02-11  Tom Tromey  <tromey@adacore.com>
6942
6943         * remote.c (remote_console_output): Update.
6944         * printcmd.c (printf_command): Update.
6945         * event-loop.c (gdb_wait_for_event): Update.
6946         * linux-nat.c (sigchld_handler): Update.
6947         * remote-sim.c (gdb_os_write_stdout): Update.
6948         (gdb_os_flush_stdout): Update.
6949         (gdb_os_flush_stderr): Update.
6950         (gdb_os_write_stderr): Update.
6951         * exceptions.c (print_exception): Update.
6952         * remote-fileio.c (remote_fileio_func_read): Update.
6953         (remote_fileio_func_write): Update.
6954         * tui/tui.c (tui_enable): Update.
6955         * tui/tui-interp.c (tui_interp::init): Update.
6956         * utils.c (init_page_info): Update.
6957         (putchar_unfiltered, fputc_unfiltered): Update.
6958         (gdb_flush): Update.
6959         (emit_style_escape): Update.
6960         (flush_wrap_buffer, fputs_maybe_filtered): Update.
6961         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
6962         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
6963         (stderr_file::write): Update.
6964         (stderr_file::puts): Update.
6965         * ui-file.h (ui_file_isatty, ui_file_write)
6966         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
6967         (ui_file_puts): Don't declare.
6968
6969 2020-02-10  Tom de Vries  <tdevries@suse.de>
6970
6971         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
6972         sentinel to char *.
6973
6974 2020-02-09  Tom de Vries  <tdevries@suse.de>
6975
6976         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
6977         filename if it matches "<artificial>".
6978
6979 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
6980
6981         * windows-tdep.c (struct enum_value_name): New struct.
6982         (create_enum): New function.
6983         (windows_get_siginfo_type): Create and use enum types.
6984
6985 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
6986
6987         * NEWS: Mention $_siginfo support for Windows.
6988         * windows-nat.c (handle_exception): Set siginfo_er.
6989         (windows_nat_target::mourn_inferior): Reset siginfo_er.
6990         (windows_xfer_siginfo): New function.
6991         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
6992         * windows-tdep.c (struct windows_gdbarch_data): New struct.
6993         (init_windows_gdbarch_data): New function.
6994         (get_windows_gdbarch_data): New function.
6995         (windows_get_siginfo_type): New function.
6996         (windows_init_abi): Register windows_get_siginfo_type.
6997         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
6998
6999 2020-02-08  Tom Tromey  <tom@tromey.com>
7000
7001         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7002         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7003         <keep>: Declare method.
7004         <m_keep>: Remove member.
7005         <~cutu_reader>: Remove.
7006         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7007         (cutu_reader::cutu_reader): Update.
7008         (cutu_reader::keep): Rename from ~cutu_reader.
7009         (process_psymtab_comp_unit, build_type_psymtabs_1)
7010         (process_skeletonless_type_unit, load_partial_comp_unit)
7011         (load_full_comp_unit, dwarf2_read_addr_index)
7012         (read_signatured_type): Update.
7013
7014 2020-02-08  Tom Tromey  <tom@tromey.com>
7015
7016         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7017         "want_partial_unit" parameter.
7018         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7019         Inline check for DW_TAG_partial_unit.
7020         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7021
7022 2020-02-08  Tom Tromey  <tom@tromey.com>
7023
7024         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7025         read.c.
7026         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7027         read.c.
7028
7029 2020-02-08  Tom Tromey  <tom@tromey.com>
7030
7031         * dwarf2/read.c (read_address): Move to comp-unit.c.
7032         (dwarf2_rnglists_process, dwarf2_ranges_process)
7033         (read_attribute_value, dwarf_decode_lines_1)
7034         (var_decode_location, decode_locdesc): Update.
7035         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7036         read.c.  Remove "cu" parameter.
7037         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7038         method.
7039
7040 2020-02-08  Tom Tromey  <tom@tromey.com>
7041
7042         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7043         (read_indirect_line_string): Update.
7044         * dwarf2/comp-unit.c (read_offset): Remove.
7045         (read_comp_unit_head): Update.
7046         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7047         method.
7048         (read_offset): Don't declare.
7049
7050 2020-02-08  Tom Tromey  <tom@tromey.com>
7051
7052         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7053         * dwarf2/read.c (struct comp_unit_head): Move to
7054         dwarf2/comp-unit.h.
7055         (enum class rcuh_kind): Move to comp-unit.h.
7056         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7057         (read_comp_unit_head, error_check_comp_unit_head)
7058         (read_and_check_comp_unit_head): Move to comp-unit.c.
7059         (read_offset, dwarf_unit_type_name): Likewise.
7060         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7061         (cutu_reader::cutu_reader, read_call_site_scope)
7062         (find_partial_die, follow_die_offset): Update.
7063         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7064
7065 2020-02-08  Tom Tromey  <tom@tromey.com>
7066
7067         * dwarf2/read.c (read_offset_1): Move to leb.c.
7068         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7069         (dwarf_decode_macro_bytes): Update.
7070         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7071         * dwarf2/leb.h (read_offset): Declare.
7072
7073 2020-02-08  Tom Tromey  <tom@tromey.com>
7074
7075         * dwarf2/read.c (dwarf2_section_size): Remove.
7076         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7077         Update.
7078         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7079
7080 2020-02-08  Tom Tromey  <tom@tromey.com>
7081
7082         * dwarf2/read.c (read_initial_length): Move to leb.c.
7083         * dwarf2/leb.h (read_initial_length): Declare.
7084         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7085         handle_nonstd parameter.
7086         * dwarf2/frame.c (read_initial_length): Remove.
7087         (decode_frame_entry_1): Update.
7088
7089 2020-02-08  Tom Tromey  <tom@tromey.com>
7090
7091         * dwarf2/loc.c (dwarf2_find_location_expression)
7092         (dwarf_evaluate_loc_desc::get_tls_address)
7093         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
7094         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
7095         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
7096         (dwarf2_compile_property_to_c)
7097         (dwarf2_loc_desc_get_symbol_read_needs)
7098         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
7099         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
7100         (loclist_describe_location, loclist_tracepoint_var_ref)
7101         (loclist_generate_c_location): Update.
7102         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
7103         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
7104         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
7105         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
7106         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
7107         (dwarf2_per_cu_data::addr_size)
7108         (dwarf2_per_cu_data::ref_addr_size)
7109         (dwarf2_per_cu_data::text_offset)
7110         (dwarf2_per_cu_data::addr_type): Now methods.
7111         (per_cu_header_read_in): Make per_cu "const".
7112         (dwarf2_version): Remove.
7113         (dwarf2_per_cu_data::int_type): Now a method.
7114         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
7115         (set_die_type, read_array_type, read_subrange_index_type)
7116         (read_tag_string_type, read_subrange_type): Update.
7117         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
7118         offset_size, ref_addr_size, text_offset, addr_type, version,
7119         objfile, int_type, addr_sized_int_type>: Declare methods.
7120
7121 2020-02-08  Tom Tromey  <tom@tromey.com>
7122
7123         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
7124         Move earlier.
7125
7126 2020-02-08  Tom Tromey  <tom@tromey.com>
7127
7128         * dwarf2/read.h (dwarf_line_debug): Declare.
7129         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
7130         * dwarf2/read.c: Move line_header code to new files.
7131         (dwarf_line_debug): No longer static.
7132         * dwarf2/line-header.c: New file.
7133         * dwarf2/line-header.h: New file.
7134
7135 2020-02-08  Tom Tromey  <tom@tromey.com>
7136
7137         * dwarf2/read.c (struct line_header) <file_full_name,
7138         file_file_name>: Return unique_xmalloc_ptr.
7139         (line_header::file_file_name): Update.
7140         (line_header::file_full_name): Update.
7141         (dw2_get_file_names_reader): Update.
7142         (macro_start_file): Update.
7143
7144 2020-02-08  Tom Tromey  <tom@tromey.com>
7145
7146         * dwarf2/read.c (struct line_header) <file_full_name,
7147         file_file_name>: Declare methods.
7148         (dw2_get_file_names_reader): Update.
7149         (file_file_name): Now a method.
7150         (file_full_name): Likewise.
7151         (macro_start_file): Update.
7152
7153 2020-02-08  Tom Tromey  <tom@tromey.com>
7154
7155         * dwarf2/read.c (dwarf_always_disassemble)
7156         (show_dwarf_always_disassemble): Move to loc.c.
7157         (_initialize_dwarf2_read): Move "always-disassemble" registration
7158         to loc.c.
7159         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
7160         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
7161         static.
7162         (show_dwarf_always_disassemble): Move from read.c.
7163         (_initialize_dwarf2loc): Move always-disassemble from read.c.
7164
7165 2020-02-08  Tom Tromey  <tom@tromey.com>
7166
7167         * dwarf2/read.c (~dwarf2_per_objfile): Update.
7168         (create_quick_file_names_table): Return htab_up.
7169         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
7170         Update.
7171         * dwarf2/read.h (struct dwarf2_per_objfile)
7172         <quick_file_names_table>: Now htab_up.
7173
7174 2020-02-08  Tom Tromey  <tom@tromey.com>
7175
7176         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
7177
7178 2020-02-08  Tom Tromey  <tom@tromey.com>
7179
7180         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
7181         Rewrite.
7182         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
7183         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
7184         (abbrev_table::abbrev_table): No longer inline.
7185         (ABBREV_HASH_SIZE): Remove.
7186         (abbrev_table::m_abbrevs): Now an htab_up.
7187
7188 2020-02-08  Tom Tromey  <tom@tromey.com>
7189
7190         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
7191         (cutu_reader): Update.
7192         (build_type_psymtabs_1): Update.
7193         * dwarf2/abbrev.c (abbrev_table::read): Rename.
7194         (abbrev_table::alloc_abbrev): Update.
7195         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
7196         (abbrev_table::read): New static method, renamed from
7197         abbrev_table_read_table.
7198         (abbrev_table::alloc_abbrev)
7199         (abbrev_table::add_abbrev): Now private.
7200         (abbrev_table::abbrev_table): Now private.
7201         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
7202
7203 2020-02-08  Tom Tromey  <tom@tromey.com>
7204
7205         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
7206         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
7207         htab_up.
7208
7209 2020-02-08  Tom Tromey  <tom@tromey.com>
7210
7211         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
7212         htab_up.
7213         (lookup_dwo_unit_in_dwp): Update.
7214         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
7215         on obstack.
7216
7217 2020-02-08  Tom Tromey  <tom@tromey.com>
7218
7219         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
7220         obstack.
7221
7222 2020-02-08  Tom Tromey  <tom@tromey.com>
7223
7224         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
7225         line_header_hash.
7226         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
7227         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
7228         Change type to htab_up.
7229
7230 2020-02-08  Tom Tromey  <tom@tromey.com>
7231
7232         * dwarf2/read.c (allocate_type_unit_groups_table): Return
7233         htab_up.  Don't allocate on obstack.
7234         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
7235         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
7236         Change type to htab_up.
7237
7238 2020-02-08  Tom Tromey  <tom@tromey.com>
7239
7240         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
7241         Change type to htab_up.
7242         * dwarf2/read.c (create_signatured_type_table_from_index)
7243         (create_signatured_type_table_from_debug_names)
7244         (create_all_type_units, add_type_unit)
7245         (lookup_dwo_signatured_type, lookup_signatured_type)
7246         (process_skeletonless_type_unit): Update.
7247         (create_debug_type_hash_table, create_debug_types_hash_table):
7248         Change type of types_htab.
7249         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
7250         htab_up.  Don't allocate on obstack.
7251         (create_cus_hash_table): Change type of cus_htab parameter.
7252         (struct dwo_file) <cus, tus>: Now htab_up.
7253         (lookup_dwo_signatured_type, lookup_dwo_cutu)
7254         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
7255         (queue_and_load_all_dwo_tus): Update.
7256         * dwarf2/index-write.c (write_gdbindex): Update.
7257         (write_debug_names): Update.
7258
7259 2020-02-08  Tom Tromey  <tom@tromey.com>
7260
7261         * dwarf2/read.h (struct dwarf2_queue_item): Move from
7262         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
7263         destructor.
7264         (struct dwarf2_per_objfile) <queue>: New member.
7265         * dwarf2/read.c (struct dwarf2_queue_item): Move to
7266         dwarf2/read.h.
7267         (dwarf2_queue, dwarf2_queue_tail): Remove.
7268         (class dwarf2_queue_guard): Add parameter to constructor.  Use
7269         DISABLE_COPY_AND_ASSIGN.
7270         <m_per_objfile>: New member.
7271         <~dwarf2_queue_guard>: Rewrite.
7272         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
7273         Update.
7274         (~dwarf2_queue_item): New.
7275
7276 2020-02-08  Tom Tromey  <tom@tromey.com>
7277
7278         * dwarf2/read.c (struct die_info) <has_children>: New member.
7279         (dw2_get_file_names_reader): Remove has_children.
7280         (dw2_get_file_names): Update.
7281         (read_cutu_die_from_dwo): Remove has_children.
7282         (cutu_reader::init_tu_and_read_dwo_dies)
7283         (cutu_reader::cutu_reader): Update.
7284         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
7285         Remove has_children.
7286         (build_type_psymtabs_1, process_skeletonless_type_unit)
7287         (load_partial_comp_unit, load_full_comp_unit): Update.
7288         (create_dwo_cu_reader): Remove has_children.
7289         (create_cus_hash_table, read_die_and_children): Update.
7290         (read_full_die_1,read_full_die): Remove has_children.
7291         (read_signatured_type): Update.
7292         (class cutu_reader) <has_children>: Remove.
7293
7294 2020-02-08  Tom Tromey  <tom@tromey.com>
7295
7296         * dwarf2/expr.c: Rename from dwarf2expr.c.
7297         * dwarf2/expr.h: Rename from dwarf2expr.h.
7298         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
7299         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
7300         * dwarf2/frame.c: Rename from dwarf2-frame.c.
7301         * dwarf2/frame.h: Rename from dwarf2-frame.h.
7302         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
7303         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
7304         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
7305         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
7306         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
7307         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
7308         * dwarf2/loc.c: Rename from dwarf2loc.c.
7309         * dwarf2/loc.h: Rename from dwarf2loc.h.
7310         * dwarf2/read.c: Rename from dwarf2read.c.
7311         * dwarf2/read.h: Rename from dwarf2read.h.
7312         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
7313         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
7314         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
7315         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
7316         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
7317         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
7318         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
7319         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
7320         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
7321         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
7322         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
7323         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
7324         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
7325         Update.
7326         * Makefile.in (COMMON_SFILES): Update.
7327         (HFILES_NO_SRCDIR): Update.
7328
7329 2020-02-08  Tom Tromey  <tom@tromey.com>
7330
7331         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
7332         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
7333
7334 2020-02-08  Tom Tromey  <tom@tromey.com>
7335
7336         * dwarf2read.h (struct die_info): Don't declare.
7337
7338 2020-02-08  Tom Tromey  <tom@tromey.com>
7339
7340         * dwarf2read.h (die_info_ptr): Remove typedef.
7341
7342 2020-02-08  Tom Tromey  <tom@tromey.com>
7343
7344         * dwarf2read.c (read_call_site_scope)
7345         (handle_data_member_location, dwarf2_add_member_fn)
7346         (mark_common_block_symbol_computed, read_common_block)
7347         (attr_to_dynamic_prop, partial_die_info::read)
7348         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
7349         (dwarf2_symbol_mark_computed, set_die_type): Update.
7350         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
7351         method.
7352         (attr_form_is_block): Don't declare.
7353         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
7354
7355 2020-02-08  Tom Tromey  <tom@tromey.com>
7356
7357         * dwarf2read.c (dwarf2_find_base_address, )
7358         (read_call_site_scope, rust_containing_type)
7359         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
7360         (handle_data_member_location, dwarf2_add_member_fn)
7361         (get_alignment, read_structure_type, process_structure_scope)
7362         (mark_common_block_symbol_computed, read_common_block)
7363         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
7364         (partial_die_info::read, read_attribute_value, new_symbol)
7365         (lookup_die_type, dwarf2_get_ref_die_offset)
7366         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
7367         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
7368         (dwarf2_symbol_mark_computed): Update.
7369         * dwarf2/attribute.h (struct attribute) <value_as_address,
7370         form_is_section_offset, form_is_constant, form_is_ref>: Declare
7371         methods.
7372         (value_as_address, attr_form_is_section_offset)
7373         (attr_form_is_constant, attr_form_is_ref): Don't declare.
7374         * dwarf2/attribute.c (attribute::value_as_address)
7375         (attribute::form_is_section_offset, attribute::form_is_constant)
7376         (attribute::form_is_ref): Now methods.
7377
7378 2020-02-08  Tom Tromey  <tom@tromey.com>
7379
7380         * dwarf2read.c (struct attribute, DW_STRING)
7381         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
7382         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
7383         (attr_form_is_block, attr_form_is_section_offset)
7384         (attr_form_is_constant, attr_form_is_ref): Move.
7385         * dwarf2/attribute.h: New file.
7386         * dwarf2/attribute.c: New file, from dwarf2read.c.
7387         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
7388
7389 2020-02-08  Tom Tromey  <tom@tromey.com>
7390
7391         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
7392         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
7393         Move.
7394         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
7395         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
7396         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
7397         abbrev.c.
7398         * dwarf2/abbrev.h: New file.
7399         * dwarf2/abbrev.c: New file, from dwarf2read.c.
7400         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
7401
7402 2020-02-08  Tom Tromey  <tom@tromey.com>
7403
7404         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
7405         (dwarf2_section_size, dwarf2_get_section_info)
7406         (create_signatured_type_table_from_debug_names)
7407         (create_addrmap_from_aranges, read_debug_names_from_section)
7408         (get_gdb_index_contents_from_section, read_comp_unit_head)
7409         (error_check_comp_unit_head, read_abbrev_offset)
7410         (create_debug_type_hash_table, init_cu_die_reader)
7411         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
7412         (read_comp_units_from_section, create_cus_hash_table)
7413         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
7414         (create_dwp_v2_section, dwarf2_rnglists_process)
7415         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
7416         (abbrev_table_read_table, read_indirect_string_at_offset_from)
7417         (read_indirect_string_from_dwz, read_addr_index_1)
7418         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
7419         (dwarf_decode_macro_bytes, dwarf_decode_macros)
7420         (fill_in_loclist_baton): Update.
7421         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
7422         get_containing_section, get_bfd_owner, get_bfd_section,
7423         get_file_name, get_id, get_flags, empty, read>: Declare methods.
7424         (dwarf2_read_section, get_section_name, get_section_file_name)
7425         (get_containing_section, get_section_bfd_owner)
7426         (get_section_bfd_section, get_section_name, get_section_file_name)
7427         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
7428         declare.
7429         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
7430         (dwarf2_section_info::get_bfd_owner)
7431         (dwarf2_section_info::get_bfd_section)
7432         (dwarf2_section_info::get_name)
7433         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
7434         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
7435         (dwarf2_section_info::read): Now methods.
7436         * dwarf-index-write.c (class debug_names): Update.
7437
7438 2020-02-08  Tom Tromey  <tom@tromey.com>
7439
7440         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
7441         Move to dwarf2/section.h.
7442         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
7443         (get_section_bfd_section, get_section_name)
7444         (get_section_file_name, get_section_id, get_section_flags)
7445         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
7446         dwarf2/section.c.
7447         * dwarf2/section.h: New file.
7448         * dwarf2/section.c: New file, from dwarf2read.c.
7449         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
7450
7451 2020-02-08  Tom Tromey  <tom@tromey.com>
7452
7453         * dwarf2read.h (read_unsigned_leb128): Don't declare.
7454         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
7455         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
7456         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
7457         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
7458         * dwarf2/leb.h: New file, from dwarf2read.c.
7459         * dwarf2/leb.c: New file, from dwarf2read.c.
7460         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
7461         Remove.
7462         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
7463         (COMMON_SFILES): Add dwarf2/leb.c.
7464
7465 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
7466
7467         GDB 9.1 released.
7468
7469 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7470
7471         PR gdb/25190:
7472         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
7473         * gdb/remote.c (remote_console_output): Update.
7474         * gdb/ui-file.c (fputs_unfiltered): Rename to...
7475         (ui_file_puts): ...this.
7476         * gdb/ui-file.h (ui_file_puts): Add declaration.
7477         * gdb/utils.c (emit_style_escape): Update.
7478         (flush_wrap_buffer): Update.
7479         (fputs_maybe_filtered): Update.
7480         (fputs_unfiltered): Add function.
7481
7482 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7483
7484         * gdb/event-loop.c (gdb_wait_for_event): Update.
7485         * gdb/printcmd.c (printf_command): Update.
7486         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
7487         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
7488         (gdb_os_flush_stderr): Update.
7489         * gdb/remote.c (remote_console_output): Update.
7490         * gdb/ui-file.c (gdb_flush): Rename to...
7491         (ui_file_flush): ...this.
7492         (stderr_file::write): Update.
7493         (stderr_file::puts): Update.
7494         * gdb/ui-file.h (gdb_flush): Rename to...
7495         (ui_file_flush): ...this.
7496         * gdb/utils.c (gdb_flush): Add function.
7497         * gdb/utils.h (gdb_flush): Add declaration.
7498
7499 2020-02-07  Tom Tromey  <tromey@adacore.com>
7500
7501         PR breakpoints/24915:
7502         * source.c (find_and_open_source): Do not check basenames_may_differ.
7503
7504 2020-02-07  Tom Tromey  <tom@tromey.com>
7505
7506         * README: Update gdbserver documentation.
7507         * gdbserver: Move to top level.
7508         * configure.tgt (build_gdbserver): Remove.
7509         * configure.ac: Remove --enable-gdbserver.
7510         * configure: Rebuild.
7511         * Makefile.in (distclean): Don't mention gdbserver.
7512
7513 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7514
7515         * source-cache.c (source_cache::ensure): Surround
7516         get_plain_source_lines with a try/catch.
7517         (source_cache::get_line_charpos): Get rid of try/catch
7518         and only check for the return value of "ensure".
7519         * tui/tui-source.c (tui_source_window::set_contents):
7520         Simplify "nlines" calculation.
7521
7522 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7523
7524         * MAINTAINERS (Write After Approval): Add myself.
7525
7526 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7527
7528         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
7529         function call.
7530
7531 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7532
7533         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
7534
7535 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
7536
7537         * nat/riscv-linux-tdesc.h: New file.
7538         * nat/riscv-linux-tdesc.c: New file, taking code from...
7539         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7540         ... here.
7541         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
7542         NATDEPFILES.
7543
7544 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
7547         we don't set the fake simulator ptid to the null_ptid.
7548
7549 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
7550
7551         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
7552         * gdbthread.h (class thread_info) <resumed>: Likewise.
7553         * infrun.c (resume_1): Likewise.
7554         (proceed): Likewise.
7555         (infrun_thread_stop_requested): Likewise.
7556         (stop_all_threads): Likewise.
7557         (handle_inferior_event): Likewise.
7558         (restart_threads): Likewise.
7559         (finish_step_over): Likewise.
7560         (keep_going_stepped_thread): Likewise.
7561         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
7562         (linux_handle_extended_wait): Likewise.
7563         * record-btrace.c (get_thread_current_frame_id): Likewise.
7564         * record-full.c (record_full_wait_1): Likewise.
7565         * remote.c (remote_target::process_initial_stop_replies): Likewise.
7566         * target.c (target_resume): Likewise.
7567         * thread.c (set_running_thread): Likewise.
7568
7569 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7570
7571         * f-valprint.c (f77_print_array_1): Changed datatype of index
7572         variable to LONGEST from int to enable it to contain bound
7573         values correctly.
7574
7575 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
7576
7577         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
7578         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
7579         offsets according to FLEN determined.
7580         (riscv_linux_nat_target::read_description): Determine FLEN
7581         dynamically.
7582         (riscv_linux_nat_target::fetch_registers): Size regset buffer
7583         according to FLEN determined.
7584         (riscv_linux_nat_target::store_registers): Likewise.
7585
7586 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
7587
7588         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7589         when reg->group is empty and reggroup is not.
7590
7591 2020-01-31  Tom Tromey  <tromey@adacore.com>
7592
7593         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
7594         Call beneath target's mourn_inferior after unpushing.
7595
7596 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7597
7598         PR tui/9765
7599         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
7600         have enough lines to fill the screen, still return the lowest
7601         address we found.
7602
7603 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
7606         '-', '<', and '>' commands.
7607
7608 2020-01-29  Pedro Alves  <palves@redhat.com>
7609             Sergio Durigan Junior  <sergiodj@redhat.com>
7610
7611         * infcmd.c (construct_inferior_arguments): Assert that
7612         'argc' is greater than 0.
7613
7614 2020-01-29  Luis Machado  <luis.machado@linaro.org>
7615
7616         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
7617         (BRK_INSN_MASK): Define to 0xd4200000.
7618         (aarch64_program_breakpoint_here_p): New function.
7619         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
7620         * arch-utils.c (default_program_breakpoint_here_p): Moved from
7621         breakpoint.c.
7622         * arch-utils.h (default_program_breakpoint_here_p): Moved from
7623         breakpoint.h
7624         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
7625         call gdbarch_program_breakpoint_here_p.
7626         (program_breakpoint_here): Moved to arch-utils.c, renamed to
7627         default_program_breakpoint_here_p, changed return type to bool and
7628         simplified.
7629         * breakpoint.h (program_breakpoint_here): Moved prototype to
7630         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
7631         return type to bool.
7632         * gdbarch.c: Regenerate.
7633         * gdbarch.h: Regenerate.
7634         * gdbarch.sh (program_breakpoint_here_p): New method.
7635         * infrun.c (handle_signal_stop): Call
7636         gdbarch_program_breakpoint_here_p.
7637
7638 2020-01-26  Tom Tromey  <tom@tromey.com>
7639
7640         * ctfread.c (struct ctf_fp_info): Reindent.
7641         (_initialize_ctfread): Remove.
7642
7643 2020-01-26  Tom Tromey  <tom@tromey.com>
7644
7645         * psymtab.c (partial_map_expand_apply)
7646         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
7647         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
7648         (psym_print_stats, psym_expand_symtabs_for_function)
7649         (psym_map_symbol_filenames, psym_map_matching_symbols)
7650         (psym_expand_symtabs_matching)
7651         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
7652         (maintenance_check_psymtabs): Use new methods.
7653         * psympriv.h (struct partial_symtab) <readin_p,
7654         get_compunit_symtab>: New methods.
7655         <readin, compunit_symtab>: Remove members.
7656         (struct standard_psymtab): New.
7657         (struct legacy_psymtab): Derive from standard_psymtab.
7658         * dwarf2read.h (struct dwarf2_psymtab): Derive from
7659         standard_psymtab.
7660         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
7661
7662 2020-01-26  Tom Tromey  <tom@tromey.com>
7663
7664         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
7665         read_dependencies.  Add assert.
7666         * psymtab.c (partial_symtab::read_dependencies): New method.
7667         * psympriv.h (struct partial_symtab) <read_dependencies>: New
7668         method.
7669         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
7670         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
7671         read_dependencies.
7672         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
7673         Add assert.
7674
7675 2020-01-26  Tom Tromey  <tom@tromey.com>
7676
7677         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
7678         Call expand_psymtab.
7679         (xcoff_read_symtab): Call expand_psymtab.
7680         (xcoff_start_psymtab, xcoff_end_psymtab): Set
7681         legacy_expand_psymtab.
7682         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
7683         method.
7684         (struct legacy_psymtab) <expand_psymtab>: Implement.
7685         <legacy_expand_psymtab>: New member.
7686         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
7687         (parse_partial_symbols): Set legacy_expand_psymtab.
7688         (psymtab_to_symtab_1): Change argument order.  Call
7689         expand_psymtab.
7690         (new_psymtab): Set legacy_expand_psymtab.
7691         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
7692         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
7693         expand_psymtab.
7694         (dwarf2_psymtab::expand_psymtab): Rename from
7695         psymtab_to_symtab_1.  Call expand_psymtab.
7696         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
7697         (dbx_end_psymtab): Likewise.
7698         (dbx_psymtab_to_symtab_1): Change argument order. Call
7699         expand_psymtab.
7700         (dbx_read_symtab): Call expand_psymtab.
7701         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
7702         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
7703         (ctf_psymtab::read_symtab): Call expand_psymtab.
7704
7705 2020-01-26  Tom Tromey  <tom@tromey.com>
7706
7707         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
7708         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
7709         messages.
7710         * mdebugread.c (mdebug_read_symtab): Remove prints.
7711         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
7712         assert.
7713         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
7714
7715 2020-01-26  Tom Tromey  <tom@tromey.com>
7716
7717         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
7718         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
7719         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
7720         legacy_symtab.
7721         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
7722         * psymtab.c (psymtab_to_symtab): Call method.
7723         (dump_psymtab): Update.
7724         * psympriv.h (struct partial_symtab): Add virtual destructor.
7725         <read_symtab>: New method.
7726         (struct legacy_symtab): New.
7727         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
7728         (struct pst_map) <pst>: Now a legacy_psymtab.
7729         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
7730         (new_psymtab): Use legacy_psymtab.
7731         * dwarf2read.h (struct dwarf2_psymtab): New.
7732         (struct dwarf2_per_cu_data) <psymtab>: Use it.
7733         * dwarf2read.c (dwarf2_create_include_psymtab)
7734         (dwarf2_build_include_psymtabs, create_type_unit_group)
7735         (create_partial_symtab, process_psymtab_comp_unit_reader)
7736         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
7737         (set_partial_user): Use dwarf2_psymtab.
7738         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
7739         (psymtab_to_symtab_1, process_full_comp_unit)
7740         (process_full_type_unit, dwarf2_ranges_read)
7741         (dwarf2_get_pc_bounds, psymtab_include_file_name)
7742         (dwarf_decode_lines): Use dwarf2_psymtab.
7743         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
7744         (add_address_entry_worker, write_one_signatured_type)
7745         (recursively_count_psymbols, recursively_write_psymbols)
7746         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
7747         (write_debug_names): Likewise.
7748         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
7749         <pst>: Now a legacy_psymtab.
7750         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
7751         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
7752         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
7753         * ctfread.c (struct ctf_psymtab): New.
7754         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
7755         ctf_psymtab.
7756         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
7757         (create_partial_symtab): Return a ctf_psymtab.
7758         (scan_partial_symbols): Update.
7759
7760 2020-01-26  Tom Tromey  <tom@tromey.com>
7761
7762         * xcoffread.c (xcoff_start_psymtab): Use new.
7763         * psymtab.c (partial_symtab::partial_symtab): New constructor,
7764         renamed from start_psymtab_common.
7765         * psympriv.h (struct partial_symtab): Add new constructor.
7766         (start_psymtab_common): Don't declare.
7767         * mdebugread.c (parse_partial_symbols): Use new.
7768         * dwarf2read.c (create_partial_symtab): Use new.
7769         * dbxread.c (start_psymtab): Use new.
7770         * ctfread.c (create_partial_symtab): Use new.
7771
7772 2020-01-26  Tom Tromey  <tom@tromey.com>
7773
7774         * xcoffread.c (xcoff_end_psymtab): Use new.
7775         * psymtab.c (start_psymtab_common): Use new.
7776         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
7777         Update.
7778         * psympriv.h (struct partial_symtab): Add parameters to
7779         constructor.  Don't inline.
7780         (allocate_psymtab): Don't declare.
7781         * mdebugread.c (new_psymtab): Use new.
7782         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
7783         * dbxread.c (dbx_end_psymtab): Use new.
7784
7785 2020-01-26  Tom Tromey  <tom@tromey.com>
7786
7787         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
7788         allocate_psymtab.  Update documentation.
7789         * psymtab.c (psymtab_storage::install_psymtab): Rename from
7790         allocate_psymtab.  Do not use new.
7791         (allocate_psymtab): Use new.  Update.
7792
7793 2020-01-26  Tom Tromey  <tom@tromey.com>
7794
7795         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
7796         * psymtab.c (psym_print_stats): Update.
7797         * psympriv.h (struct partial_symtab) <readin,
7798         psymtabs_addrmap_supported, anonymous>: Now bool.
7799         * mdebugread.c (psymtab_to_symtab_1): Update.
7800         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
7801         (build_type_psymtabs_reader, psymtab_to_symtab_1)
7802         (process_full_comp_unit, process_full_type_unit): Update.
7803         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
7804         * ctfread.c (psymtab_to_symtab): Update.
7805
7806 2020-01-26  Tom Tromey  <tom@tromey.com>
7807
7808         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
7809         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
7810         * psymtab.c (psymtab_storage): Delete psymtabs.
7811         (psymtab_storage::allocate_psymtab): Use new.
7812         (psymtab_storage::discard_psymtab): Use delete.
7813         * psympriv.h (struct partial_symtab): Add constructor and
7814         initializers.
7815
7816 2020-01-26  Tom Tromey  <tom@tromey.com>
7817
7818         * machoread.c: Do not include psympriv.h.
7819
7820 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7821
7822         * NEWS: Mention the new option and the set/show commands.
7823
7824 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7825
7826         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
7827         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
7828         (validate_exec_file): New variables, enums, functions.
7829         (exec_file_locate_attach, print_section_info): Style the filenames.
7830         (_initialize_exec): Install show_exec_file_mismatch_command and
7831          set_exec_file_mismatch_command.
7832         * gdbcore.h (validate_exec_file): Declare.
7833         * infcmd.c (attach_command): Call validate_exec_file.
7834         * remote.c ( remote_target::remote_add_inferior): Likewise.
7835
7836 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * frame.c (find_frame_sal): Move call to get_next_frame into more
7839         inner scope.
7840         * inline-frame.c (inilne_state) <inline_state>: Update argument
7841         types.
7842         (inilne_state) <skipped_symbol>: Rename to...
7843         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
7844         (skip_inline_frames): Build vector of skipped symbols and use this
7845         to reate the inline_state.
7846         (inline_skipped_symbol): Add a comment and some assertions, fetch
7847         skipped symbol from the list.
7848
7849 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * buildsym.c (lte_is_less_than): Delete.
7852         (buildsym_compunit::end_symtab_with_blockvector): Create local
7853         lambda function to sort line table entries, and use
7854         std::stable_sort instead of std::sort.
7855         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
7856         markers when looking for a previous line.
7857
7858 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * dwarf2read.c (lnp_state_machine::record_line): Include
7861         end_sequence parameter in debug print out.  Record the line if we
7862         are at an end_sequence marker even if it's not the start of a
7863         statement.
7864         * symmisc.c (maintenance_print_one_line_table): Print end of
7865         sequence markers with 'END' not '0'.
7866
7867 2020-01-24  Pedro Alves  <palves@redhat.com>
7868
7869         PR gdb/25410
7870         * thread.c (scoped_restore_current_thread::restore): Use
7871         switch_to_inferior_no_thread.
7872         * exec.c: Include "progspace-and-thread.h".
7873         (add_target_sections, remove_target_sections):
7874         scoped_restore_current_pspace_and_thread instead of
7875         scoped_restore_current_thread.
7876         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
7877         and aspace to the inferior before calling clone_program_space.
7878         Remove stale comment.
7879
7880 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7881
7882         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
7883         (arm_netbsd_nat_target::fetch_registers): ...this.
7884         (arm_nbsd_nat_target::store_registers): Rename to...
7885         (arm_netbsd_nat_target::store_registers): ...this.
7886
7887 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7888
7889         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7890         register_t.
7891
7892 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7893
7894         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
7895         Update comment.
7896         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
7897         Likewise.
7898         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
7899         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
7900         the correct replacement (iterate_over_regset_sections).
7901         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
7902         Update comment.
7903
7904 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
7905
7906         PR gdb/23718
7907         * gdb/python/python.c (execute_gdb_command): Call
7908         async_enable_stdin in catch block.
7909
7910 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7911
7912         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
7913         SWITCH_THRU_ALL_UIS.
7914
7915 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7916
7917         PR tui/9765
7918         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
7919         comment, add extra parameter, and update to store previous symbol
7920         when appropriate.
7921         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
7922         add extra parameter.
7923         * tui/tui-disasm.c (tui_disassemble): Update header comment,
7924         remove unneeded parameter, add try/catch around gdb_print_insn,
7925         rewrite to add items to asm_lines vector.
7926         (tui_find_backward_disassembly_start_address): New function.
7927         (tui_find_disassembly_address): Updated throughout.
7928         (tui_disasm_window::set_contents): Update for changes to
7929         tui_disassemble.
7930         (tui_disasm_window::do_scroll_vertical): No need to adjust the
7931         number of lines to scroll.
7932
7933 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
7934
7935         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
7936         (SECT_OFF_DATA): Likewise.
7937         (SECT_OFF_RODATA): Likewise.
7938         (SECT_OFF_TEXT): Likewise.
7939         (SECT_OFF_BSS): Likewise.
7940         (struct objfile) <text_section_offset, data_section_offset>: New
7941         methods.
7942         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
7943         objfile::text_section_offset.
7944         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
7945         * coffread.c (coff_symtab_read): Likewise.
7946         (enter_linenos): Likewise.
7947         (process_coff_symbol): Likewise.
7948         * ctfread.c (get_objfile_text_range): Likewise.
7949         * dtrace-probe.c (dtrace_probe::get_relocated_address):
7950         Use objfile::data_section_offset.
7951         * dwarf2-frame.c (execute_cfa_program): Use
7952         objfile::text_section_offset.
7953         (dwarf2_frame_find_fde): Likewise.
7954         * dwarf2read.c (create_addrmap_from_index): Likewise.
7955         (create_addrmap_from_aranges): Likewise.
7956         (dw2_find_pc_sect_compunit_symtab): Likewise.
7957         (process_psymtab_comp_unit_reader): Likewise.
7958         (add_partial_symbol): Likewise.
7959         (add_partial_subprogram): Likewise.
7960         (process_full_comp_unit): Likewise.
7961         (read_file_scope): Likewise.
7962         (read_func_scope): Likewise.
7963         (read_lexical_block_scope): Likewise.
7964         (read_call_site_scope): Likewise.
7965         (dwarf2_rnglists_process): Likewise.
7966         (dwarf2_ranges_process): Likewise.
7967         (dwarf2_ranges_read): Likewise.
7968         (dwarf_decode_lines_1): Likewise.
7969         (new_symbol): Likewise.
7970         (dwarf2_fetch_die_loc_sect_off): Likewise.
7971         (dwarf2_per_cu_text_offset): Likewise.
7972         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
7973         * hppa-tdep.c (read_unwind_info): Likewise.
7974         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
7975         * psympriv.h (struct partial_symtab): Likewise.
7976         * psymtab.c (find_pc_sect_psymtab): Likewise.
7977         * solib-svr4.c (enable_break): Likewise.
7978         * stap-probe.c (relocate_address): Use
7979         objfile::data_section_offset.
7980         * xcoffread.c (enter_line_range): Use
7981         objfile::text_section_offset.
7982         (read_xcoff_symtab): Likewise.
7983
7984 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
7985
7986         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
7987         declaration to narrower scopes.
7988
7989 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
7990
7991         * darwin-nat.h (struct darwin_exception_msg, enum
7992         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
7993         Move up.
7994         (class darwin_nat_target) <wait_1, check_new_threads,
7995         decode_exception_message, decode_message, stop_inferior,
7996         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
7997         * darwin-nat.c (darwin_check_new_threads): Rename to...
7998         (darwin_nat_target::check_new_threads): ... this.
7999         (darwin_suspend_inferior_it): Remove.
8000         (darwin_decode_exception_message): Rename to...
8001         (darwin_nat_target::decode_exception_message): ... this.
8002         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8003         (darwin_decode_message): Rename to...
8004         (darwin_nat_target::decode_message): ... this.
8005         (cancel_breakpoint): Rename to...
8006         (darwin_nat_target::cancel_breakpoint): ... this.
8007         (darwin_wait): Rename to...
8008         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8009         instead of iterate_over_inferiors.
8010         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8011         (darwin_stop_inferior): Rename to...
8012         (darwin_nat_target::stop_inferior): ... this.
8013         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8014         (darwin_init_thread_list): Rename to...
8015         (darwin_nat_target::init_thread_list): ... this.
8016         (darwin_ptrace_him): Rename to...
8017         (darwin_nat_target::ptrace_him): ... this.
8018         (darwin_nat_target::create_inferior): Pass lambda function to
8019         fork_inferior.
8020         (darwin_nat_target::detach): Call stop_inferior instead of
8021         darwin_stop_inferior.
8022         * fork-inferior.h (fork_inferior): Change init_trace_fun
8023         parameter to gdb::function_view.
8024         * fork-inferior.c (fork_inferior): Likewise.
8025
8026 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8027
8028         * i386-cygwin-tdep.c (core_process_module_section): Update.
8029         * windows-nat.c (struct lm_info_windows): Add text_offset.
8030         (windows_xfer_shared_libraries): Update.
8031         * windows-tdep.c (windows_xfer_shared_library):
8032         Add text_offset_cached argument.
8033         * windows-tdep.h (windows_xfer_shared_library): Update.
8034
8035 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8036
8037         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8038
8039 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8040
8041         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8042         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8043         replace with range-based for.
8044         (gdbsim_interrupt_inferior): Remove.
8045         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8046         with a range-based for.  Inline code from
8047         gdbsim_interrupt_inferior.
8048
8049 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8050
8051         * infrun.c (proceed): Fix indentation.
8052
8053 2020-01-21  Tom Tromey  <tromey@adacore.com>
8054
8055         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8056         * python/python.c (python_extension_ops): Update.
8057         (gdbpy_colorize): New function.
8058         * python/lib/gdb/__init__.py (colorize): New function.
8059         * extension.h (ext_lang_colorize): Declare.
8060         * extension.c (ext_lang_colorize): New function.
8061         * extension-priv.h (struct extension_language_ops) <colorize>: New
8062         member.
8063         * cli/cli-style.c (_initialize_cli_style): Update help text.
8064
8065 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8066
8067         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8068         <cond>: Change type to bool.
8069         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8070         (aarch64_displaced_step_cb): Likewise.
8071         (aarch64_displaced_step_tb): Likewise.
8072
8073 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8074
8075         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8076         output.
8077
8078 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8079
8080         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8081         <pc_adjust>: Adjust the documentation.
8082         (aarch64_displaced_step_fixup): Check if PC really moved before
8083         adjusting it.
8084
8085 2020-01-19  Tom Tromey  <tom@tromey.com>
8086
8087         * disasm.c (~gdb_disassembler): New destructor.
8088         (gdb_buffered_insn_length): Call disassemble_free_target.
8089         * disasm.h (class gdb_disassembler): Declare destructor.  Use
8090         DISABLE_COPY_AND_ASSIGN.
8091
8092 2020-01-19  Tom Tromey  <tom@tromey.com>
8093
8094         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
8095         (die_reader_func_ftype): Remove.
8096         (cutu_reader): New class.
8097         (dw2_get_file_names_reader): Remove "data" parameter.
8098         (dw2_get_file_names): Use cutu_reader.
8099         (create_debug_type_hash_table): Update.
8100         (read_cutu_die_from_dwo): Update comment.
8101         (lookup_dwo_unit): Add dwo_name parameter.
8102         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
8103         die_reader_func_ftype and data parameters.
8104         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
8105         Remove die_reader_func_ftype and data parameters.
8106         (~cutu_reader): New; from init_cutu_and_read_dies.
8107         (cutu_reader::cutu_reader): Rename from
8108         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
8109         and data parameters.
8110         (init_cutu_and_read_dies_simple): Remove.
8111         (struct process_psymtab_comp_unit_data): Remove.
8112         (process_psymtab_comp_unit_reader): Remove data parameter; add
8113         want_partial_unit and pretend_language parameters.
8114         (process_psymtab_comp_unit): Use cutu_reader.
8115         (build_type_psymtabs_reader): Remove data parameter.
8116         (build_type_psymtabs_1): Use cutu_reader.
8117         (process_skeletonless_type_unit): Likewise.
8118         (load_partial_comp_unit_reader): Remove.
8119         (load_partial_comp_unit): Use cutu_reader.
8120         (load_full_comp_unit_reader): Remove.
8121         (load_full_comp_unit): Use cutu_reader.
8122         (struct create_dwo_cu_data): Remove.
8123         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
8124         dwo_unit parameters.
8125         (create_cus_hash_table): Use cutu_reader.
8126         (struct dwarf2_read_addr_index_data): Remove.
8127         (dwarf2_read_addr_index_reader): Remove.
8128         (dwarf2_read_addr_index): Use cutu_reader.
8129         (read_signatured_type_reader): Remove.
8130         (read_signatured_type): Use cutu_reader.
8131
8132 2020-01-19  Tom Tromey  <tom@tromey.com>
8133
8134         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
8135         * tui/tui-wingeneral.h (class tui_suppress_output): New.
8136         (tui_wrefresh): Declare.
8137         * tui/tui-wingeneral.c (suppress_output): New global.
8138         (tui_suppress_output, ~tui_suppress_output): New constructor and
8139         destructor.
8140         (tui_wrefresh): New function.
8141         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
8142         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
8143         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
8144         method.
8145         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
8146         tui_wrefresh.
8147         (tui_data_window::no_refresh): New method.
8148         (tui_data_item_window::refresh_window): Call tui_wrefresh.
8149         (tui_reg_command): Use tui_suppress_output
8150         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
8151         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
8152         method.
8153         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
8154
8155 2020-01-19  Tom Tromey  <tom@tromey.com>
8156
8157         * tui/tui-winsource.c (tui_update_source_windows_with_line):
8158         Handle case where symtab is null.
8159
8160 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
8161
8162         * linux-fork.c (one_fork_p): Simplify.
8163
8164 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8165
8166         * top.c (struct qt_args): Remove.
8167         (kill_or_detach): Change return type to void, replace `void *`
8168         parameter with a proper one.
8169         (print_inferior_quit_action):  Likewise.
8170         (quit_confirm): Use range-based for loop to iterate over inferiors.
8171         (quit_force): Likewise.
8172
8173 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8174
8175         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
8176         `void *` parameter with proper parameters.
8177         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
8178         (print_one_inferior): Change return type to void, replace `void *`
8179         parameter with proper parameters.
8180         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
8181         inferiors.
8182         (get_other_inferior): Remove.
8183         (mi_cmd_remove_inferior): Use range-based loop to iterate over
8184         inferiors.
8185
8186 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8187
8188         * mi/mi-interp.c (report_initial_inferior): Remove.
8189         (mi_interp::init): Use range-based for to iterate over inferiors.
8190
8191 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8192
8193         * python/py-inferior.c (build_inferior_list): Remove.
8194         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
8195
8196 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
8197
8198         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
8199         (btrace_stitch_trace): Likewise.
8200         * charset.c (intermediate_encoding): Likewise (vaild).
8201         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
8202         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
8203         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
8204
8205 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
8206
8207         * windows-tdep.c (windows_get_tlb_type):
8208         Add rtl_user_process_parameters type.
8209
8210 2020-01-16  Pedro Alves  <palves@redhat.com>
8211             Norbert Lange  <nolange79@gmail.com>
8212
8213         PR build/24805
8214         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
8215         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
8216         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
8217         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
8218         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
8219         (ps_plog): Redeclare exported functions with default visibility.
8220
8221 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
8222
8223         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
8224         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
8225
8226 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
8227
8228         * infcmd.c (post_create_inferior): Use get_thread_regcache
8229         instead of get_current_regcache.
8230
8231 2020-01-14  Tom Tromey  <tom@tromey.com>
8232
8233         PR symtab/12535:
8234         * python/python.c (gdbpy_decode_line): Treat empty string the same
8235         as no argument.
8236
8237 2020-01-14  Tom Tromey  <tom@tromey.com>
8238
8239         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
8240
8241 2020-01-14  Tom Tromey  <tom@tromey.com>
8242
8243         * nat/linux-btrace.c: Don't include <config.h>.
8244         * nat/linux-ptrace.c: Don't include <config.h>.
8245         * nat/x86-linux-dregs.c: Don't include <config.h>.
8246
8247 2020-01-14  Tom Tromey  <tom@tromey.com>
8248
8249         * configure: Rebuild.
8250         * configure.ac: Move many checks to ../gdbsupport/common.m4.
8251
8252 2020-01-14  Tom Tromey  <tom@tromey.com>
8253
8254         * nat/x86-linux-dregs.c: Include configh.h.
8255         * nat/linux-ptrace.c: Include configh.h.
8256         * nat/linux-btrace.c: Include configh.h.
8257         * defs.h: Include config.h, bfd.h.
8258         * configure.ac: Don't source common.host.
8259         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
8260         * configure: Rebuild.
8261         * acinclude.m4: Update path.
8262         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
8263         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
8264         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
8265         (CLIBS): Add LIBSUPPORT.
8266         (CDEPS): Likewise.
8267         (COMMON_SFILES): Remove gdbsupport files.
8268         (HFILES_NO_SRCDIR): Likewise.
8269         (stamp-version): Update path to create-version.sh.
8270         (ALLDEPFILES): Remove gdbsupport files.
8271
8272 2020-01-14  Tom Tromey  <tom@tromey.com>
8273
8274         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
8275         USE_WIN32API when needed.
8276         * configure.ac (USE_WIN32API): Don't define.
8277         (WIN32LIBS): Use WIN32APILIBS.
8278         * configure: Rebuild.
8279
8280 2020-01-14  Tom Tromey  <tom@tromey.com>
8281
8282         * configure: Rebuild.
8283         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
8284
8285 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8286
8287         * skip.c (skip_function_command): Make skip w/o arguments use the
8288         name of the inlined function if pc is inside any inlined function.
8289
8290 2020-01-14  Luis Machado  <luis.machado@linaro.org>
8291
8292         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
8293         * infrun.c (resume_1): Likewise.
8294         (handle_inferior_event): Remove stale comment.
8295         * linux-nat.c (linux_nat_target::resume): Update comments.
8296         (save_stop_reason): Likewise.
8297         (linux_nat_filter_event): Likewise.
8298         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
8299
8300 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * elfread.c (record_minimal_symbol): Set section index to 0 for
8303         non-allocatable sections.
8304
8305
8306 2020-01-13  Ali Tamur <tamur@google.com>
8307
8308         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
8309         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
8310         to gdb::optional.  Update comments.
8311         (dwo_file): Update comments.
8312         (read_attribute): Update API to take an additional out parameter,
8313         need_reprocess.  This is used to mark attributes that need other
8314         attributes (e.g. str_offsets_base) for correct computation which may not
8315         have been read yet.
8316         (read_attribute_reprocess): New function declaration.
8317         (read_addr_index): Likewise.
8318         (read_dwo_str_index): Likewise.
8319         (read_stub_str_index): Likewise.
8320         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
8321         (lookup_addr_base): New function definition.
8322         (lookup_ranges_base): Likewise.
8323         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
8324         lookup_ranges_base.
8325         (init_cutu_and_read_dies): Update comments.
8326         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
8327         unit.  This is used to inherit parent's str_offsets_base and addr_base.
8328         Update comments.
8329         (init_cutu_and_read_dies_simple): Reflect API changes.
8330         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
8331         (create_cus_hash_table): Change API to take parent compile unit.
8332         Reflect API changes.
8333         (open_and_init_dwo_file): Reflect API changes.
8334         (dwarf2_get_pc_bounds): Update comments.
8335         (dwarf2_record_block_ranges): Likewise.
8336         (read_full_die_1): Change implementation to reprocess attributes that
8337         need str_offsets_base and addr_base.
8338         (partial_die_info::read): Likewise.
8339         (read_attribute_reprocess): New function definition.
8340         (read_attribute_value): Change API to take an additional out parameter,
8341         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
8342         when a non-dwo compile unit has index based attributes.
8343         (read_attribute): Reflect API changes.
8344         (read_addr_index_1): Reflect API changes.  Update comments.
8345         (dwarf2_read_addr_index_data): Reflect API changes.
8346         (dwarf2_read_addr_index): Likewise.
8347         (read_str_index): Change API and implementation.  This becomes a helper
8348         to be used by the new string index related methods.  Update error
8349         message and comments.
8350         (read_dwo_str_index): New function definition.
8351         (read_stub_str_index): Likewise.
8352         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
8353         * symfile.h (dwarf2_debug_sections): Likewise.
8354         * xcoffread.c (dwarf2_debug_sections): Likewise.
8355
8356 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8357
8358         * gdbcore.h (struct core_fns) <core_read_registers>: Change
8359         core_reg_sect type to gdb_byte *.
8360         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
8361         * cris-tdep.c (fetch_core_registers): Likewise.
8362         * corelow.c (core_target::get_core_register_section): Change
8363         type of `contents` to gdb::byte_vector.
8364
8365 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8366
8367         * tui/tui-wingeneral.c (box_win): Position the title in the center
8368         of the border.
8369
8370 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8371
8372         * corelow.c (core_target::get_core_register_section): Use
8373           std::vector instead of alloca.
8374
8375 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8376
8377         * warning.m4: Add -Wmissing-declarations to build_warnings.
8378         * configure: Re-generate.
8379
8380 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8381
8382         * python/python.c (init__gdb_module): Add declaration.
8383
8384 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8385
8386         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
8387         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
8388         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
8389         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
8390         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
8391         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
8392         * ada-exp.y (_initialize_ada_exp): Add declaration.
8393         * ada-lang.c (_initialize_ada_language): Add declaration.
8394         * ada-tasks.c (_initialize_tasks): Add declaration.
8395         * agent.c (_initialize_agent): Add declaration.
8396         * aix-thread.c (_initialize_aix_thread): Add declaration.
8397         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
8398         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
8399         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
8400         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
8401         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
8402         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
8403         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
8404         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
8405         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
8406         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
8407         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
8408         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
8409         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
8410         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
8411         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
8412         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
8413         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
8414         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
8415         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
8416         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
8417         * annotate.c (_initialize_annotate): Add declaration.
8418         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
8419         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
8420         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
8421         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
8422         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
8423         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
8424         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
8425         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
8426         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
8427         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
8428         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
8429         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
8430         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
8431         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
8432         * auto-load.c (_initialize_auto_load): Add declaration.
8433         * auxv.c (_initialize_auxv): Add declaration.
8434         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
8435         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
8436         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
8437         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
8438         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
8439         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
8440         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
8441         * breakpoint.c (_initialize_breakpoint): Add declaration.
8442         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
8443         * btrace.c (_initialize_btrace): Add declaration.
8444         * charset.c (_initialize_charset): Add declaration.
8445         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
8446         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
8447         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
8448         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
8449         * cli/cli-script.c (_initialize_cli_script): Add declaration.
8450         * cli/cli-style.c (_initialize_cli_style): Add declaration.
8451         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
8452         * coffread.c (_initialize_coffread): Add declaration.
8453         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
8454         * compile/compile.c (_initialize_compile): Add declaration.
8455         * complaints.c (_initialize_complaints): Add declaration.
8456         * completer.c (_initialize_completer): Add declaration.
8457         * copying.c (_initialize_copying): Add declaration.
8458         * corefile.c (_initialize_core): Add declaration.
8459         * corelow.c (_initialize_corelow): Add declaration.
8460         * cp-abi.c (_initialize_cp_abi): Add declaration.
8461         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
8462         * cp-support.c (_initialize_cp_support): Add declaration.
8463         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
8464         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
8465         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
8466         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
8467         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
8468         * ctfread.c (_initialize_ctfread): Add declaration.
8469         * d-lang.c (_initialize_d_language): Add declaration.
8470         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
8471         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
8472         * dbxread.c (_initialize_dbxread): Add declaration.
8473         * dcache.c (_initialize_dcache): Add declaration.
8474         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
8475         * disasm.c (_initialize_disasm): Add declaration.
8476         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
8477         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
8478         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
8479         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
8480         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
8481         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
8482         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
8483         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
8484         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
8485         * elfread.c (_initialize_elfread): Add declaration.
8486         * exec.c (_initialize_exec): Add declaration.
8487         * extension.c (_initialize_extension): Add declaration.
8488         * f-lang.c (_initialize_f_language): Add declaration.
8489         * f-valprint.c (_initialize_f_valprint): Add declaration.
8490         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
8491         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
8492         * filesystem.c (_initialize_filesystem): Add declaration.
8493         * findcmd.c (_initialize_mem_search): Add declaration.
8494         * findvar.c (_initialize_findvar): Add declaration.
8495         * fork-child.c (_initialize_fork_child): Add declaration.
8496         * frame-base.c (_initialize_frame_base): Add declaration.
8497         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
8498         * frame.c (_initialize_frame): Add declaration.
8499         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
8500         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
8501         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
8502         * gcore.c (_initialize_gcore): Add declaration.
8503         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
8504         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
8505         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
8506         * gdbarch.c (_initialize_gdbarch): Add declaration.
8507         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
8508         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
8509         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
8510         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
8511         * go-lang.c (_initialize_go_language): Add declaration.
8512         * go32-nat.c (_initialize_go32_nat): Add declaration.
8513         * guile/guile.c (_initialize_guile): Add declaration.
8514         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
8515         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
8516         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
8517         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
8518         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
8519         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
8520         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
8521         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
8522         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
8523         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
8524         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
8525         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
8526         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
8527         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
8528         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
8529         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
8530         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
8531         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
8532         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
8533         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
8534         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
8535         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
8536         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
8537         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
8538         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
8539         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
8540         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
8541         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
8542         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
8543         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
8544         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
8545         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
8546         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
8547         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
8548         * infcall.c (_initialize_infcall): Add declaration.
8549         * infcmd.c (_initialize_infcmd): Add declaration.
8550         * inflow.c (_initialize_inflow): Add declaration.
8551         * infrun.c (_initialize_infrun): Add declaration.
8552         * interps.c (_initialize_interpreter): Add declaration.
8553         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
8554         * jit.c (_initialize_jit): Add declaration.
8555         * language.c (_initialize_language): Add declaration.
8556         * linux-fork.c (_initialize_linux_fork): Add declaration.
8557         * linux-nat.c (_initialize_linux_nat): Add declaration.
8558         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
8559         * linux-thread-db.c (_initialize_thread_db): Add declaration.
8560         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
8561         * m2-lang.c (_initialize_m2_language): Add declaration.
8562         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
8563         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
8564         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
8565         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
8566         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
8567         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
8568         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
8569         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
8570         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
8571         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
8572         * machoread.c (_initialize_machoread): Add declaration.
8573         * macrocmd.c (_initialize_macrocmd): Add declaration.
8574         * macroscope.c (_initialize_macroscope): Add declaration.
8575         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
8576         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
8577         * maint.c (_initialize_maint_cmds): Add declaration.
8578         * mdebugread.c (_initialize_mdebugread): Add declaration.
8579         * memattr.c (_initialize_mem): Add declaration.
8580         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
8581         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
8582         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
8583         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
8584         * mi/mi-main.c (_initialize_mi_main): Add declaration.
8585         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
8586         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
8587         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
8588         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
8589         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
8590         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
8591         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
8592         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
8593         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
8594         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
8595         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
8596         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
8597         * mipsread.c (_initialize_mipsread): Add declaration.
8598         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
8599         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
8600         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
8601         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
8602         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
8603         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
8604         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
8605         * nto-procfs.c (_initialize_procfs): Add declaration.
8606         * objc-lang.c (_initialize_objc_language): Add declaration.
8607         * observable.c (_initialize_observer): Add declaration.
8608         * opencl-lang.c (_initialize_opencl_language): Add declaration.
8609         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
8610         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
8611         * osabi.c (_initialize_gdb_osabi): Add declaration.
8612         * osdata.c (_initialize_osdata): Add declaration.
8613         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
8614         * parse.c (_initialize_parse): Add declaration.
8615         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
8616         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
8617         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
8618         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
8619         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
8620         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
8621         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
8622         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
8623         * printcmd.c (_initialize_printcmd): Add declaration.
8624         * probe.c (_initialize_probe): Add declaration.
8625         * proc-api.c (_initialize_proc_api): Add declaration.
8626         * proc-events.c (_initialize_proc_events): Add declaration.
8627         * proc-service.c (_initialize_proc_service): Add declaration.
8628         * procfs.c (_initialize_procfs): Add declaration.
8629         * producer.c (_initialize_producer): Add declaration.
8630         * psymtab.c (_initialize_psymtab): Add declaration.
8631         * python/python.c (_initialize_python): Add declaration.
8632         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
8633         * record-btrace.c (_initialize_record_btrace): Add declaration.
8634         * record-full.c (_initialize_record_full): Add declaration.
8635         * record.c (_initialize_record): Add declaration.
8636         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
8637         * regcache.c (_initialize_regcache): Add declaration.
8638         * reggroups.c (_initialize_reggroup): Add declaration.
8639         * remote-notif.c (_initialize_notif): Add declaration.
8640         * remote-sim.c (_initialize_remote_sim): Add declaration.
8641         * remote.c (_initialize_remote): Add declaration.
8642         * reverse.c (_initialize_reverse): Add declaration.
8643         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
8644         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
8645         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
8646         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
8647         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
8648         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
8649         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
8650         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
8651         Add declaration.
8652         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
8653         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
8654         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
8655         * rust-exp.y (_initialize_rust_exp): Add declaration.
8656         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
8657         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
8658         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
8659         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
8660         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
8661         * score-tdep.c (_initialize_score_tdep): Add declaration.
8662         * ser-go32.c (_initialize_ser_dos): Add declaration.
8663         * ser-mingw.c (_initialize_ser_windows): Add declaration.
8664         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
8665         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
8666         * ser-uds.c (_initialize_ser_socket): Add declaration.
8667         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
8668         * serial.c (_initialize_serial): Add declaration.
8669         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
8670         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
8671         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
8672         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
8673         * skip.c (_initialize_step_skip): Add declaration.
8674         * sol-thread.c (_initialize_sol_thread): Add declaration.
8675         * solib-aix.c (_initialize_solib_aix): Add declaration.
8676         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
8677         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
8678         * solib-frv.c (_initialize_frv_solib): Add declaration.
8679         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
8680         * solib-target.c (_initialize_solib_target): Add declaration.
8681         * solib.c (_initialize_solib): Add declaration.
8682         * source-cache.c (_initialize_source_cache): Add declaration.
8683         * source.c (_initialize_source): Add declaration.
8684         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
8685         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
8686         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
8687         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
8688         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
8689         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
8690         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
8691         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
8692         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
8693         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
8694         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
8695         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
8696         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
8697         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
8698         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
8699         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
8700         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
8701         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
8702         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
8703         * stabsread.c (_initialize_stabsread): Add declaration.
8704         * stack.c (_initialize_stack): Add declaration.
8705         * stap-probe.c (_initialize_stap_probe): Add declaration.
8706         * std-regs.c (_initialize_frame_reg): Add declaration.
8707         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
8708         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
8709         * symfile.c (_initialize_symfile): Add declaration.
8710         * symmisc.c (_initialize_symmisc): Add declaration.
8711         * symtab.c (_initialize_symtab): Add declaration.
8712         * target.c (_initialize_target): Add declaration.
8713         * target-connection.c (_initialize_target_connection): Add
8714         declaration.
8715         * target-dcache.c (_initialize_target_dcache): Add declaration.
8716         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
8717         * thread.c (_initialize_thread): Add declaration.
8718         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
8719         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
8720         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
8721         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
8722         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
8723         * tracectf.c (_initialize_ctf): Add declaration.
8724         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
8725         * tracefile.c (_initialize_tracefile): Add declaration.
8726         * tracepoint.c (_initialize_tracepoint): Add declaration.
8727         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
8728         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
8729         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
8730         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
8731         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
8732         * tui/tui-win.c (_initialize_tui_win): Add declaration.
8733         * tui/tui.c (_initialize_tui): Add declaration.
8734         * typeprint.c (_initialize_typeprint): Add declaration.
8735         * ui-style.c (_initialize_ui_style): Add declaration.
8736         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
8737         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
8738         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
8739         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
8740         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
8741         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
8742         * unittests/filtered_iterator-selftests.c
8743         (_initialize_filtered_iterator_selftests): Add declaration.
8744         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
8745         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
8746         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
8747         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
8748         * unittests/main-thread-selftests.c
8749         (_initialize_main_thread_selftests): Add declaration.
8750         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
8751         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
8752         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
8753         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
8754         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
8755         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
8756         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
8757         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
8758         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
8759         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
8760         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
8761         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
8762         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
8763         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
8764         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
8765         declaration.
8766         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
8767         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
8768         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
8769         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
8770         * user-regs.c (_initialize_user_regs): Add declaration.
8771         * utils.c (_initialize_utils): Add declaration.
8772         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
8773         * valops.c (_initialize_valops): Add declaration.
8774         * valprint.c (_initialize_valprint): Add declaration.
8775         * value.c (_initialize_values): Add declaration.
8776         * varobj.c (_initialize_varobj): Add declaration.
8777         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
8778         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
8779         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
8780         * windows-nat.c (_initialize_windows_nat): Add declaration.
8781         (_initialize_check_for_gdb_ini): Add declaration.
8782         (_initialize_loadable): Add declaration.
8783         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
8784         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
8785         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
8786         * xcoffread.c (_initialize_xcoffread): Add declaration.
8787         * xml-support.c (_initialize_xml_support): Add declaration.
8788         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
8789         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
8790         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
8791         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
8792
8793 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8794
8795         * regformats/regdat.sh: Generate declaration for init function.
8796
8797 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8798
8799         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
8800         up.
8801         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
8802         close_one_inferior>: New methods.
8803         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
8804         pass down target to find_inferior_pid.
8805         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
8806         Pass down target to find_inferior_ptid.
8807         (gdbsim_target::create_inferior): Pass down target to
8808         add_thread_silent.
8809         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
8810         target down to find_inferior_ptid and switch_to_thread.
8811         (gdbsim_target::close): Update to call close_one_inferior.
8812         (struct resume_data): Remove.
8813         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
8814         directly, rather than through a void pointer.
8815         (gdbsim_target::resume): Update to call resume_one_inferior.
8816
8817 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
8818
8819         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
8820
8821 2020-01-12  Pedro Alves  <palves@redhat.com>
8822
8823         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
8824         directly for the current inferior instead of
8825         discard_all_inferiors.
8826         (discard_all_inferiors): Delete.
8827
8828 2020-01-11  Tom Tromey  <tom@tromey.com>
8829
8830         * tui/tui-wingeneral.c (box_win): Check cli_styling.
8831         * tui/tui-winsource.c (tui_source_window_base::refill): Use
8832         deprecated_safe_get_selected_frame.
8833
8834 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
8835
8836         * inferior.c (print_inferior): Switch inferior before printing it.
8837
8838 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
8839             Pedro Alves  <palves@redhat.com>
8840
8841         * progspace-and-thread.c (switch_to_program_space_and_thread):
8842         Assert there's an inferior for PSPACE.  Use
8843         switch_to_inferior_no_thread to switch the inferior too.
8844         * progspace.c (program_space::~program_space): Call
8845         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
8846         (program_space::free_all_objfiles): Don't call clear_symtab_users
8847         here.
8848         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
8849
8850 2020-01-10  Pedro Alves  <palves@redhat.com>
8851
8852         * NEWS: Mention multi-target debugging, "info connections", and
8853         "add-inferior -no-connection".
8854
8855 2020-01-10  Pedro Alves  <palves@redhat.com>
8856
8857         * infrun.c: Include "target-connection.h".
8858         (check_multi_target_resumption): New.
8859         (proceed): Call it.
8860         * target-connection.c (make_target_connection_string): Make
8861         extern.
8862         * target-connection.h (make_target_connection_string): Declare.
8863
8864 2020-01-10  Pedro Alves  <palves@redhat.com>
8865
8866         * Makefile.in (COMMON_SFILES): Add target-connection.c.
8867         * inferior.c (uiout_field_connection): New function.
8868         (print_inferior): Add new "connection-id" column.
8869         (add_inferior_command): Show connection number/string of added
8870         inferior.
8871         * process-stratum-target.h
8872         (process_stratum_target::connection_string): New virtual method.
8873         (process_stratum_target::connection_number): New field.
8874         * remote.c (remote_target::connection_string): New override.
8875         * target-connection.c: New file.
8876         * target-connection.h: New file.
8877         * target.c (decref_target): Remove process_stratum targets from
8878         the connection list.
8879         (target_stack::push): Add process_stratum targets to the
8880         connection list.
8881
8882 2020-01-10  Pedro Alves  <palves@redhat.com>
8883
8884         Revert:
8885         2016-04-12  Pedro Alves  <palves@redhat.com>
8886         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
8887         Remove references to name.
8888         * serial.h (struct serial) <name>: Delete.
8889
8890 2020-01-10  Pedro Alves  <palves@redhat.com>
8891
8892         * gdbarch-selftests.c (register_to_value_test): Remove "target
8893         already pushed" check.
8894
8895 2020-01-10  Pedro Alves  <palves@redhat.com>
8896             John Baldwin  <jhb@FreeBSD.org>
8897
8898         * aarch64-linux-nat.c
8899         (aarch64_linux_nat_target::thread_architecture): Adjust.
8900         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
8901         (task_command_1): Likewise.
8902         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
8903         (aix_thread_target::wait, aix_thread_target::fetch_registers)
8904         (aix_thread_target::store_registers)
8905         (aix_thread_target::thread_alive): Adjust.
8906         * amd64-fbsd-tdep.c: Include "inferior.h".
8907         (amd64fbsd_get_thread_local_address): Pass down target.
8908         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
8909         thread's gdbarch instead of target_gdbarch.
8910         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
8911         get_last_target_status.
8912         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
8913         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
8914         inferiors.
8915         (update_inserted_breakpoint_locations): Skip if inferiors with no
8916         execution.
8917         (update_global_location_list): When handling moribund locations,
8918         find representative inferior for location's pspace, and use thread
8919         count of its process_stratum target.
8920         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
8921         * bsd-uthread.c (bsd_uthread_target::wait): Use
8922         as_process_stratum_target and adjust thread_change_ptid and
8923         add_thread calls.
8924         (bsd_uthread_target::update_thread_list): Use
8925         as_process_stratum_target and adjust find_thread_ptid,
8926         thread_change_ptid and add_thread calls.
8927         * btrace.c (maint_btrace_packet_history_cmd): Adjust
8928         find_thread_ptid call.
8929         * corelow.c (add_to_thread_list): Adjust add_thread call.
8930         (core_target_open): Adjust add_thread_silent and thread_count
8931         calls.
8932         (core_target::pid_to_str): Adjust find_inferior_ptid call.
8933         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
8934         * event-top.c (async_disconnect): Pop targets from all inferiors.
8935         * exec.c (add_target_sections): Push exec target on all inferiors
8936         sharing the program space.
8937         (remove_target_sections): Remove the exec target from all
8938         inferiors sharing the program space.
8939         (exec_on_vfork): New.
8940         * exec.h (exec_on_vfork): Declare.
8941         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
8942         Pass it down.
8943         (fbsd_nat_target::update_thread_list): Adjust.
8944         (fbsd_nat_target::resume): Adjust.
8945         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
8946         down.
8947         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
8948         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
8949         get_thread_arch_regcache call.
8950         * fork-child.c (gdb_startup_inferior): Pass target down to
8951         startup_inferior and set_executing.
8952         * gdbthread.h (struct process_stratum_target): Forward declare.
8953         (add_thread, add_thread_silent, add_thread_with_info)
8954         (in_thread_list): Add process_stratum_target parameter.
8955         (find_thread_ptid(inferior*, ptid_t)): New overload.
8956         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
8957         parameter.
8958         (all_threads()): Delete overload.
8959         (all_threads, all_non_exited_threads): Add process_stratum_target
8960         parameter.
8961         (all_threads_safe): Use brace initialization.
8962         (thread_count): Add process_stratum_target parameter.
8963         (set_resumed, set_running, set_stop_requested, set_executing)
8964         (threads_are_executing, finish_thread_state): Add
8965         process_stratum_target parameter.
8966         (switch_to_thread): Use is_current_thread.
8967         * i386-fbsd-tdep.c: Include "inferior.h".
8968         (i386fbsd_get_thread_local_address): Pass down target.
8969         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
8970         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
8971         have_inferiors check.
8972         * inf-ptrace.c (inf_ptrace_target::create_inferior)
8973         (inf_ptrace_target::attach): Adjust.
8974         * infcall.c (run_inferior_call): Adjust.
8975         * infcmd.c (run_command_1): Pass target to
8976         scoped_finish_thread_state.
8977         (proceed_thread_callback): Skip inferiors with no execution.
8978         (continue_command): Rename 'all_threads' local to avoid hiding
8979         'all_threads' function.  Adjust get_last_target_status call.
8980         (prepare_one_step): Adjust set_running call.
8981         (signal_command): Use user_visible_resume_target.  Compare thread
8982         pointers instead of inferior_ptid.
8983         (info_program_command): Adjust to pass down target.
8984         (attach_command): Mark target's 'thread_executing' flag.
8985         (stop_current_target_threads_ns): New, factored out from ...
8986         (interrupt_target_1): ... this.  Switch inferior before making
8987         target calls.
8988         * inferior-iter.h
8989         (struct all_inferiors_iterator, struct all_inferiors_range)
8990         (struct all_inferiors_safe_range)
8991         (struct all_non_exited_inferiors_range): Filter on
8992         process_stratum_target too.  Remove explicit.
8993         * inferior.c (inferior::inferior): Push dummy target on target
8994         stack.
8995         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
8996         Add process_stratum_target parameter, and pass it down.
8997         (have_live_inferiors): Adjust.
8998         (switch_to_inferior_and_push_target): New.
8999         (add_inferior_command, clone_inferior_command): Handle
9000         "-no-connection" parameter.  Use
9001         switch_to_inferior_and_push_target.
9002         (_initialize_inferior): Mention "-no-connection" option in
9003         the help of "add-inferior" and "clone-inferior" commands.
9004         * inferior.h: Include "process-stratum-target.h".
9005         (interrupt_target_1): Use bool.
9006         (struct inferior) <push_target, unpush_target, target_is_pushed,
9007         find_target_beneath, top_target, process_target, target_at,
9008         m_stack>: New.
9009         (discard_all_inferiors): Delete.
9010         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9011         (all_inferiors, all_non_exited_inferiors): Add
9012         process_stratum_target parameter.
9013         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9014         (target_last_proc_target): New global.
9015         (follow_fork_inferior): Push target on new inferior.  Pass target
9016         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9017         reference count.
9018         (follow_fork): Adjust get_last_target_status call.  Also consider
9019         target.
9020         (follow_exec): Push target on new inferior.
9021         (struct execution_control_state) <target>: New field.
9022         (user_visible_resume_target): New.
9023         (do_target_resume): Call target_async.
9024         (resume_1): Set target's threads_executing flag.  Consider resume
9025         target.
9026         (commit_resume_all_targets): New.
9027         (proceed): Also consider resume target.  Skip threads of inferiors
9028         with no execution.  Commit resumtion in all targets.
9029         (start_remote): Pass current inferior to wait_for_inferior.
9030         (infrun_thread_stop_requested): Consider target as well.  Pass
9031         thread_info pointer to clear_inline_frame_state instead of ptid.
9032         (infrun_thread_thread_exit): Consider target as well.
9033         (random_pending_event_thread): New inferior parameter.  Use it.
9034         (do_target_wait): Rename to ...
9035         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9036         down.
9037         (threads_are_resumed_pending_p, do_target_wait): New.
9038         (prepare_for_detach): Adjust calls.
9039         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9040         do_target_wait_1 instead of do_target_wait.
9041         (fetch_inferior_event): Adjust.  Switch to representative
9042         inferior.  Pass target down.
9043         (set_last_target_status): Add process_stratum_target parameter.
9044         Save target in global.
9045         (get_last_target_status): Add process_stratum_target parameter and
9046         handle it.
9047         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9048         (context_switch): Check inferior_ptid == null_ptid before calling
9049         inferior_thread().
9050         (get_inferior_stop_soon): Pass down target.
9051         (wait_one): Rename to ...
9052         (poll_one_curr_target): ... this.
9053         (struct wait_one_event): New.
9054         (wait_one): New.
9055         (stop_all_threads): Adjust.
9056         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9057         event's target.
9058         (switch_back_to_stepped_thread): Also consider target.
9059         (print_stop_event): Update.
9060         (normal_stop): Update.  Also consider the resume target.
9061         * infrun.h (wait_for_inferior): Remove declaration.
9062         (user_visible_resume_target): New declaration.
9063         (get_last_target_status, set_last_target_status): New
9064         process_stratum_target parameter.
9065         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9066         process_stratum_target parameter, and use it.
9067         (clear_inline_frame_state (thread_info*)): New.
9068         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9069         process_stratum_target parameter.
9070         (clear_inline_frame_state (thread_info*)): Declare.
9071         * linux-fork.c (delete_checkpoint_command): Pass target down to
9072         find_thread_ptid.
9073         (checkpoint_command): Adjust.
9074         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9075         instead of just tweaking inferior_ptid.
9076         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9077         (exit_lwp): Pass target down to find_thread_ptid.
9078         (attach_proc_task_lwp_callback): Pass target down to
9079         add_thread/set_running/set_executing.
9080         (linux_nat_target::attach): Pass target down to
9081         thread_change_ptid.
9082         (get_detach_signal): Pass target down to find_thread_ptid.
9083         Consider last target status's target.
9084         (linux_resume_one_lwp_throw, resume_lwp)
9085         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
9086         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
9087         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
9088         (linux_nat_target::async_wait_fd): New.
9089         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
9090         target down.
9091         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
9092         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
9093         * linux-thread-db.c (struct thread_db_info::process_target): New
9094         field.
9095         (add_thread_db_info): Save target.
9096         (get_thread_db_info): New process_stratum_target parameter.  Also
9097         match target.
9098         (delete_thread_db_info): New process_stratum_target parameter.
9099         Also match target.
9100         (thread_from_lwp): Adjust to pass down target.
9101         (thread_db_notice_clone): Pass down target.
9102         (check_thread_db_callback): Pass down target.
9103         (try_thread_db_load_1): Always push the thread_db target.
9104         (try_thread_db_load, record_thread): Pass target down.
9105         (thread_db_target::detach): Pass target down.  Always unpush the
9106         thread_db target.
9107         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
9108         target down.  Always unpush the thread_db target.
9109         (find_new_threads_callback, thread_db_find_new_threads_2)
9110         (thread_db_target::update_thread_list): Pass target down.
9111         (thread_db_target::pid_to_str): Pass current inferior down.
9112         (thread_db_target::get_thread_local_address): Pass target down.
9113         (thread_db_target::resume, maintenance_check_libthread_db): Pass
9114         target down.
9115         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
9116         * procfs.c (procfs_target::procfs_init_inferior): Declare.
9117         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
9118         (procfs_init_inferior): Rename to ...
9119         (procfs_target::procfs_init_inferior): ... this and adjust.
9120         (procfs_target::create_inferior, procfs_notice_thread)
9121         (procfs_do_thread_registers): Adjust.
9122         * ppc-fbsd-tdep.c: Include "inferior.h".
9123         (ppcfbsd_get_thread_local_address): Pass down target.
9124         * proc-service.c (ps_xfer_memory): Switch current inferior and
9125         program space as well.
9126         (get_ps_regcache): Pass target down.
9127         * process-stratum-target.c
9128         (process_stratum_target::thread_address_space)
9129         (process_stratum_target::thread_architecture): Pass target down.
9130         * process-stratum-target.h
9131         (process_stratum_target::threads_executing): New field.
9132         (as_process_stratum_target): New.
9133         * ravenscar-thread.c
9134         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
9135         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
9136         down.
9137         * record-btrace.c (record_btrace_target::info_record): Adjust.
9138         (record_btrace_target::record_method)
9139         (record_btrace_target::record_is_replaying)
9140         (record_btrace_target::fetch_registers)
9141         (get_thread_current_frame_id, record_btrace_target::resume)
9142         (record_btrace_target::wait, record_btrace_target::stop): Pass
9143         target down.
9144         * record-full.c (record_full_wait_1): Switch to event thread.
9145         Pass target down.
9146         * regcache.c (regcache::regcache)
9147         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
9148         process_stratum_target parameter and handle it.
9149         (current_thread_target): New global.
9150         (get_thread_regcache): Add process_stratum_target parameter and
9151         handle it.  Switch inferior before calling target method.
9152         (get_thread_regcache): Pass target down.
9153         (get_thread_regcache_for_ptid): Pass target down.
9154         (registers_changed_ptid): Add process_stratum_target parameter and
9155         handle it.
9156         (registers_changed_thread, registers_changed): Pass target down.
9157         (test_get_thread_arch_aspace_regcache): New.
9158         (current_regcache_test): Define a couple local test_target_ops
9159         instances and use them for testing.
9160         (readwrite_regcache): Pass process_stratum_target parameter.
9161         (cooked_read_test, cooked_write_test): Pass mock_target down.
9162         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
9163         (get_thread_arch_aspace_regcache): Add process_stratum_target
9164         parameter.
9165         (regcache::target): New method.
9166         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
9167         (regcache::registers_changed_ptid): Add process_stratum_target
9168         parameter.
9169         (regcache::m_target): New field.
9170         (registers_changed_ptid): Add process_stratum_target parameter.
9171         * remote.c (remote_state::supports_vCont_probed): New field.
9172         (remote_target::async_wait_fd): New method.
9173         (remote_unpush_and_throw): Add remote_target parameter.
9174         (get_current_remote_target): Adjust.
9175         (remote_target::remote_add_inferior): Push target.
9176         (remote_target::remote_add_thread)
9177         (remote_target::remote_notice_new_inferior)
9178         (get_remote_thread_info): Pass target down.
9179         (remote_target::update_thread_list): Skip threads of inferiors
9180         bound to other targets.  (remote_target::close): Don't discard
9181         inferiors.  (remote_target::add_current_inferior_and_thread)
9182         (remote_target::process_initial_stop_replies)
9183         (remote_target::start_remote)
9184         (remote_target::remote_serial_quit_handler): Pass down target.
9185         (remote_target::remote_unpush_target): New remote_target
9186         parameter.  Unpush the target from all inferiors.
9187         (remote_target::remote_unpush_and_throw): New remote_target
9188         parameter.  Pass it down.
9189         (remote_target::open_1): Check whether the current inferior has
9190         execution instead of checking whether any inferior is live.  Pass
9191         target down.
9192         (remote_target::remote_detach_1): Pass down target.  Use
9193         remote_unpush_target.
9194         (extended_remote_target::attach): Pass down target.
9195         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
9196         (remote_target::append_resumption): Pass down target.
9197         (remote_target::append_pending_thread_resumptions)
9198         (remote_target::remote_resume_with_hc, remote_target::resume)
9199         (remote_target::commit_resume): Pass down target.
9200         (remote_target::remote_stop_ns): Check supports_vCont_probed.
9201         (remote_target::interrupt_query)
9202         (remote_target::remove_new_fork_children)
9203         (remote_target::check_pending_events_prevent_wildcard_vcont)
9204         (remote_target::remote_parse_stop_reply)
9205         (remote_target::process_stop_reply): Pass down target.
9206         (first_remote_resumed_thread): New remote_target parameter.  Pass
9207         it down.
9208         (remote_target::wait_as): Pass down target.
9209         (unpush_and_perror): New remote_target parameter.  Pass it down.
9210         (remote_target::readchar, remote_target::remote_serial_write)
9211         (remote_target::getpkt_or_notif_sane_1)
9212         (remote_target::kill_new_fork_children, remote_target::kill): Pass
9213         down target.
9214         (remote_target::mourn_inferior): Pass down target.  Use
9215         remote_unpush_target.
9216         (remote_target::core_of_thread)
9217         (remote_target::remote_btrace_maybe_reopen): Pass down target.
9218         (remote_target::pid_to_exec_file)
9219         (remote_target::thread_handle_to_thread_info): Pass down target.
9220         (remote_target::async_wait_fd): New.
9221         * riscv-fbsd-tdep.c: Include "inferior.h".
9222         (riscv_fbsd_get_thread_local_address): Pass down target.
9223         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
9224         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
9225         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
9226         Adjust.
9227         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
9228         * solib-svr4.c (enable_break): Pass down target.
9229         * spu-multiarch.c (parse_spufs_run): Pass down target.
9230         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
9231         * target-delegates.c: Regenerate.
9232         * target.c (g_target_stack): Delete.
9233         (current_top_target): Return the current inferior's top target.
9234         (target_has_execution_1): Refer to the passed-in inferior's top
9235         target.
9236         (target_supports_terminal_ours): Check whether the initial
9237         inferior was already created.
9238         (decref_target): New.
9239         (target_stack::push): Incref/decref the target.
9240         (push_target, push_target, unpush_target): Adjust.
9241         (target_stack::unpush): Defref target.
9242         (target_is_pushed): Return bool.  Adjust to refer to the current
9243         inferior's target stack.
9244         (dispose_inferior): Delete, and inline parts ...
9245         (target_preopen): ... here.  Only dispose of the current inferior.
9246         (target_detach): Hold strong target reference while detaching.
9247         Pass target down.
9248         (target_thread_name): Add assertion.
9249         (target_resume): Pass down target.
9250         (target_ops::beneath, find_target_at): Adjust to refer to the
9251         current inferior's target stack.
9252         (get_dummy_target): New.
9253         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
9254         has a thread running.
9255         (initialize_targets): Rename to ...
9256         (_initialize_target): ... this.
9257         * target.h: Include "gdbsupport/refcounted-object.h".
9258         (struct target_ops): Inherit refcounted_object.
9259         (target_ops::shortname, target_ops::longname): Make const.
9260         (target_ops::async_wait_fd): New method.
9261         (decref_target): Declare.
9262         (struct target_ops_ref_policy): New.
9263         (target_ops_ref): New typedef.
9264         (get_dummy_target): Declare function.
9265         (target_is_pushed): Return bool.
9266         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
9267         (all_matching_threads_iterator::all_matching_threads_iterator):
9268         Handle filter target.
9269         * thread-iter.h (struct all_matching_threads_iterator, struct
9270         all_matching_threads_range, class all_non_exited_threads_range):
9271         Filter by target too.  Remove explicit.
9272         * thread.c (threads_executing): Delete.
9273         (inferior_thread): Pass down current inferior.
9274         (clear_thread_inferior_resources): Pass down thread pointer
9275         instead of ptid_t.
9276         (add_thread_silent, add_thread_with_info, add_thread): Add
9277         process_stratum_target parameter.  Use it for thread and inferior
9278         searches.
9279         (is_current_thread): New.
9280         (thread_info::deletable): Use it.
9281         (find_thread_ptid, thread_count, in_thread_list)
9282         (thread_change_ptid, set_resumed, set_running): New
9283         process_stratum_target parameter.  Pass it down.
9284         (set_executing): New process_stratum_target parameter.  Pass it
9285         down.  Adjust reference to 'threads_executing'.
9286         (threads_are_executing): New process_stratum_target parameter.
9287         Adjust reference to 'threads_executing'.
9288         (set_stop_requested, finish_thread_state): New
9289         process_stratum_target parameter.  Pass it down.
9290         (switch_to_thread): Also match inferior.
9291         (switch_to_thread): New process_stratum_target parameter.  Pass it
9292         down.
9293         (update_threads_executing): Reimplement.
9294         * top.c (quit_force): Pop targets from all inferior.
9295         (gdb_init): Don't call initialize_targets.
9296         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
9297         Declare.
9298         (windows_add_thread, windows_delete_thread): Adjust.
9299         (get_windows_debug_event): Rename to ...
9300         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
9301         * tracefile-tfile.c (tfile_target_open): Pass down target.
9302         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
9303         Forward declare.
9304         (switch_to_thread): Add process_stratum_target parameter.
9305         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
9306         parameter.  Use it.
9307         (mi_on_resume): Pass target down.
9308         * nat/fork-inferior.c (startup_inferior): Add
9309         process_stratum_target parameter.  Pass it down.
9310         * nat/fork-inferior.h (startup_inferior): Add
9311         process_stratum_target parameter.
9312         * python/py-threadevent.c (py_get_event_thread): Pass target down.
9313
9314 2020-01-10  Pedro Alves  <palves@redhat.com>
9315
9316         * remote.c (remote_target::start_remote): Don't set inferior_ptid
9317         directly.  Instead find the first thread in the thread list and
9318         use switch_to_thread.
9319
9320 2020-01-10  Pedro Alves  <palves@redhat.com>
9321
9322         * remote.c (remote_target::remote_add_inferior): Don't bind a
9323         process to the current inferior if the current inferior is already
9324         bound to a process.
9325
9326 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9327             Pedro Alves  <palves@redhat.com>
9328
9329         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
9330         If no process is specified, return null_ptid instead of
9331         inferior_ptid.
9332         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
9333         TARGET_WAITKIND_SIGNALLED with no pid.
9334
9335 2020-01-10  Pedro Alves  <palves@redhat.com>
9336
9337         * remote.c (first_remote_resumed_thread): New.
9338         (remote_target::wait_as): Use it as default event_ptid instead of
9339         inferior_ptid.
9340
9341 2020-01-10  Pedro Alves  <palves@redhat.com>
9342
9343         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
9344
9345 2020-01-10  Pedro Alves  <palves@redhat.com>
9346
9347         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
9348         not -1.
9349
9350 2020-01-10  Pedro Alves  <palves@redhat.com>
9351
9352         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
9353         ptid to get_last_target_status.
9354         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
9355         ptid to get_last_target_status.
9356         * infcmd.c (continue_command): Don't pass a target_waitstatus to
9357         get_last_target_status.
9358         (info_program_command): Don't pass a target_waitstatus to
9359         get_last_target_status.
9360         * infrun.c (init_wait_for_inferior): Use
9361         nullify_last_target_wait_ptid.
9362         (get_last_target_status): Handle nullptr arguments.
9363         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
9364         (print_stop_event): Don't pass a ptid to get_last_target_status.
9365         (normal_stop): Don't pass a ptid to get_last_target_status.
9366         * infrun.h (get_last_target_status, set_last_target_status): Move
9367         comments here and update.
9368         (nullify_last_target_wait_ptid): Declare.
9369         * linux-fork.c (fork_load_infrun_state): Remove local extern
9370         declaration of nullify_last_target_wait_ptid.
9371         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
9372         to get_last_target_status.
9373
9374 2020-01-10  Pedro Alves  <palves@redhat.com>
9375
9376         * gdbthread.h (scoped_restore_current_thread)
9377         <dont_restore, restore, m_dont_restore>: Declare.
9378         * thread.c (thread_alive): Add assertion.  Return bool.
9379         (switch_to_thread_if_alive): New.
9380         (prune_threads): Switch inferior/thread.
9381         (print_thread_info_1): Switch thread before calling target methods.
9382         (scoped_restore_current_thread::restore): New, factored out from
9383         ...
9384         (scoped_restore_current_thread::~scoped_restore_current_thread):
9385         ... this.
9386         (scoped_restore_current_thread::scoped_restore_current_thread):
9387         Add assertion.
9388         (thread_apply_all_command, thread_select): Use
9389         switch_to_thread_if_alive.
9390         * infrun.c (proceed, restart_threads, handle_signal_stop)
9391         (switch_back_to_stepped_thread): Switch current thread before
9392         calling target methods.
9393
9394 2020-01-10  Pedro Alves <palves@redhat.com>
9395
9396         * inferior.c (switch_to_inferior_no_thread): New function,
9397         factored out from ...
9398         (inferior_command): ... here.
9399         * inferior.h (switch_to_inferior_no_thread): Declare.
9400         * mi/mi-main.c (run_one_inferior): Use
9401         switch_to_inferior_no_thread.
9402
9403 2020-01-10  Pedro Alves  <palves@redhat.com>
9404
9405         * infcmd.c (kill_command): Remove dead code.
9406
9407 2020-01-10  Pedro Alves  <palves@redhat.com>
9408
9409         * remote.c (remote_target::mourn_inferior): No longer check
9410         whether the target is running.
9411
9412 2020-01-10  Pedro Alves  <palves@redhat.com>
9413
9414         * corelow.c (core_target::has_execution): Change parameter type to
9415         inferior pointer.
9416         * inferior.c (number_of_live_inferiors): Use
9417         inferior::has_execution instead of target_has_execution_1.
9418         * inferior.h (inferior::has_execution): New.
9419         * linux-thread-db.c (thread_db_target::update_thread_list): Use
9420         inferior::has_execution instead of target_has_execution_1.
9421         * process-stratum-target.c
9422         (process_stratum_target::has_execution): Change parameter type to
9423         inferior pointer.  Check the inferior's PID instead of
9424         inferior_ptid.
9425         * process-stratum-target.h
9426         (process_stratum_target::has_execution): Change parameter type to
9427         inferior pointer.
9428         * record-full.c (record_full_core_target::has_execution): Change
9429         parameter type to inferior pointer.
9430         * target.c (target_has_execution_1): Change parameter type to
9431         inferior pointer.
9432         (target_has_execution_current): Adjust.
9433         * target.h (target_ops::has_execution): Change parameter type to
9434         inferior pointer.
9435         (target_has_execution_1): Change parameter type to inferior
9436         pointer.  Change return type to bool.
9437         * tracefile.h (tracefile_target::has_execution): Change parameter
9438         type to inferior pointer.
9439
9440 2020-01-10  Pedro Alves  <palves@redhat.com>
9441
9442         * exceptions.c (print_flush): Remove current_top_target() check.
9443
9444 2020-01-10  Pedro Alves  <palves@redhat.com>
9445
9446         * remote.c (show_remote_exec_file): Show the current inferior's
9447         exec-file instead of the command variable's value.
9448
9449 2020-01-10  Pedro Alves  <palves@redhat.com>
9450
9451         * record-full.c (record_full_resume_ptid): New global.
9452         (record_full_target::resume): Set it.
9453         (record_full_wait_1): Use record_full_resume_ptid instead of
9454         inferior_ptid.
9455
9456 2020-01-10  Pedro Alves  <palves@redhat.com>
9457
9458         * gdbthread.h (scoped_restore_current_thread)
9459         <dont_restore, restore, m_dont_restore>: Declare.
9460         * thread.c (thread_alive): Add assertion.  Return bool.
9461         (switch_to_thread_if_alive): New.
9462         (prune_threads): Switch inferior/thread.
9463         (print_thread_info_1): Switch thread before calling target methods.
9464         (scoped_restore_current_thread::restore): New, factored out from
9465         ...
9466         (scoped_restore_current_thread::~scoped_restore_current_thread):
9467         ... this.
9468         (scoped_restore_current_thread::scoped_restore_current_thread):
9469         Add assertion.
9470         (thread_apply_all_command, thread_select): Use
9471         switch_to_thread_if_alive.
9472
9473 2020-01-10  George Barrett  <bob@bob131.so>
9474
9475         * stap-probe.c (stap_modify_semaphore): Don't check for null
9476         semaphores.
9477         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
9478         for null semaphores.
9479
9480 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9481
9482         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
9483         all source windows, and maintain horizontal scroll status while
9484         doing so.
9485
9486 2020-01-09  Tom Tromey  <tom@tromey.com>
9487
9488         PR tui/18932:
9489         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
9490         update_source_window, not print_source_lines.
9491
9492 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9493
9494         * tui/tui.c (tui_enable): Register tui hooks after calling
9495         tui_display_main.
9496
9497 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9498
9499         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
9500
9501 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
9502
9503         * thread.c (print_thread_info_1): Fix indentation.
9504
9505 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9506
9507         * symtab.c (general_symbol_info::compute_and_set_names): Move the
9508         unique_xmalloc_ptr outside the if to always free the demangled name.
9509
9510 2020-01-08  Tom Tromey  <tromey@adacore.com>
9511
9512         * xcoffread.c (enter_line_range, read_xcoff_symtab)
9513         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
9514         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
9515         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
9516         Remove.
9517         (section_offsets): New typedef.
9518         * symtab.c (fixup_section, get_msymbol_address): Update.
9519         * symmisc.c (dump_msymbols): Update.
9520         * symfile.h (relative_addr_info_to_section_offsets)
9521         (symfile_map_offsets_to_segments): Update.
9522         * symfile.c (build_section_addr_info_from_objfile)
9523         (init_objfile_sect_indices): Update.
9524         (struct place_section_arg): Change type of "offsets".
9525         (place_section): Update.
9526         (relative_addr_info_to_section_offsets): Change type of
9527         "section_offsets".  Remove "num_sections" parameter.
9528         (default_symfile_offsets, syms_from_objfile_1)
9529         (set_objfile_default_section_offset): Update.
9530         (reread_symbols): No need to preserve section offsets by hand.
9531         (symfile_map_offsets_to_segments): Change type of "offsets".
9532         * stap-probe.c (relocate_address): Update.
9533         * stabsread.h (process_one_symbol): Update.
9534         * solib-target.c (struct lm_info_target) <offsets>: Change type.
9535         (solib_target_relocate_section_addresses): Update.
9536         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
9537         Update.
9538         * solib-frv.c (frv_relocate_main_executable): Update.
9539         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
9540         * solib-aix.c (solib_aix_get_section_offsets): Change return
9541         type.
9542         (solib_aix_solib_create_inferior_hook): Update.
9543         * remote.c (remote_target::get_offsets): Update.
9544         * psymtab.c (find_pc_sect_psymtab): Update.
9545         * psympriv.h (struct partial_symbol) <address, text_low,
9546         text_high>: Update.
9547         * objfiles.h (obj_section_offset): Update.
9548         (struct objfile) <section_offsets>: Change type.
9549         <num_sections>: Remove.
9550         (objfile_relocate): Update.
9551         * objfiles.c (entry_point_address_query): Update
9552         (relocate_one_symbol): Change type of "section_offsets".
9553         (objfile_relocate1, objfile_relocate1): Change type of
9554         "new_offsets".
9555         (objfile_rebase1): Update.
9556         * mipsread.c (mipscoff_symfile_read): Update.
9557         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
9558         parameter.
9559         * mdebugread.c (parse_symbol): Change type of "section_offsets".
9560         (parse_external, psymtab_to_symtab_1): Update.
9561         * machoread.c (macho_symfile_offsets): Update.
9562         * ia64-tdep.c (ia64_find_unwind_table): Update.
9563         * hppa-tdep.c (read_unwind_info): Update.
9564         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
9565         * dwarf2read.c (create_addrmap_from_index)
9566         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9567         (process_psymtab_comp_unit_reader, add_partial_symbol)
9568         (add_partial_subprogram, process_full_comp_unit)
9569         (read_file_scope, read_func_scope, read_lexical_block_scope)
9570         (read_call_site_scope, dwarf2_rnglists_process)
9571         (dwarf2_ranges_process, dwarf2_ranges_read)
9572         (dwarf_decode_lines_1, var_decode_location, new_symbol)
9573         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
9574         Update.
9575         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
9576         Update.
9577         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
9578         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
9579         (process_one_symbol): Change type of "section_offsets".
9580         * ctfread.c (get_objfile_text_range): Update.
9581         * coffread.c (coff_symtab_read, enter_linenos)
9582         (process_coff_symbol): Update.
9583         * coff-pe-read.c (add_pe_forwarded_sym): Update.
9584         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
9585
9586 2020-01-08  Tom Tromey  <tromey@adacore.com>
9587
9588         * dwarf2read.c (parse_macro_definition): Use std::string.
9589         (parse_macro_definition): Likewise.
9590
9591 2020-01-08  Tom Tromey  <tromey@adacore.com>
9592
9593         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
9594         (ATTR_ALLOC_CHUNK): Remove.
9595
9596 2020-01-08  Tom Tromey  <tromey@adacore.com>
9597
9598         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
9599
9600 2020-01-08  Tom Tromey  <tromey@adacore.com>
9601
9602         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
9603         (dwarf2_compute_name, open_dwo_file): Likewise.
9604         (process_enumeration_scope): Use std::vector.
9605         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
9606         (partial_die_info::fixup, dwarf2_start_subfile)
9607         (guess_full_die_structure_name, dwarf2_name): Likewise.
9608         (determine_prefix): Update.
9609         (guess_full_die_structure_name): Make return type const.
9610         (partial_die_full_name): Return unique_xmalloc_ptr.
9611         (DW_FIELD_ALLOC_CHUNK): Remove.
9612
9613 2020-01-07  Tom Tromey  <tromey@adacore.com>
9614
9615         PR build/24937:
9616         * stap-probe.c (class stap_static_probe_ops): Add constructor.
9617
9618 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9619
9620         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
9621
9622 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9623
9624         * stack.c (print_frame_info): Move disassemble_next_line code
9625         inside source_print block.
9626
9627 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9628
9629         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
9630         gdb/signals.h, as we are now using native signal symbols.
9631
9632 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9633
9634         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
9635         overflow by an early check of content vs threshold.
9636         * tui/tui-source.c (tui_source_window::line_is_displayed):
9637         Likewise.
9638
9639 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9640
9641         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
9642
9643 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9644
9645         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
9646         export table if no section contains it's RVA.
9647
9648 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9649
9650         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
9651
9652 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
9653
9654         * source.c (print_source_lines_base): Set last_line_listed.
9655
9656 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9657
9658         * tui/tui-disasm.c: Remove trailing spaces.
9659
9660 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9661             Pedro Alves  <palves@redhat.com>
9662
9663         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
9664         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
9665         (windows_gdb_signal_to_target): New function, uses the above
9666         enumeration to convert GDB internal signal codes to equivalent
9667         Windows codes.
9668         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
9669         * windows-nat.c: Include "gdb_wait.h".
9670         (get_windows_debug_event): Extract the fatal exception from the
9671         exit status and convert to the equivalent Posix signal number.
9672         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
9673         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
9674         * gdbsupport/gdb_wait.c: New file, implements
9675         windows_status_to_termsig.
9676         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
9677         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
9678
9679 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9680
9681         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
9682         show_layout.
9683
9684 2020-01-05  Luis Machado  <luis.machado@linaro.org>
9685
9686         * aarch64-linux-nat.c
9687         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
9688         and bfd_mach_aarch64.
9689
9690 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9691
9692         * ui-file.c (stdio_file::can_emit_style_escape)
9693         (tee_file::can_emit_style_escape): Ensure style is used also on
9694         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
9695         to gdb_stdout.
9696         * main.c (set_gdb_data_directory): Use file style to output the
9697         warning that the given pathname is not a directory.
9698         * top.c (show_history_filename, gdb_safe_append_history)
9699         (show_gdb_datadir): Use file style.
9700
9701 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9702
9703         * solib-target.c (struct lm_info_target):
9704         Change offsets to be a unique_xmalloc_ptr.
9705         (solib_target_relocate_section_addresses): Update.
9706
9707 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9708
9709         * windows-nat.c (windows_clear_solib): Free so_list linked list.
9710
9711 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9712
9713         * MAINTAINERS (Write After Approval): Add myself.
9714
9715 2020-01-02  Luis Machado  <luis.machado@linaro.org>
9716
9717         * proc-service.c (get_ps_regcache): Remove reference to obsolete
9718         Cell BE architecture.
9719         * target.h (struct target_ops) <thread_architecture>: Likewise.
9720
9721 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9722
9723         * Makefile.in: Use INSTALL_PROGRAM_ENV.
9724
9725 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9726
9727         * MAINTAINERS (Write After Approval): Add myself.
9728
9729 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9730
9731         * gdbarch.sh: Update copyright year range of generated files.
9732
9733 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9734
9735         Update copyright year range in all GDB files.
9736
9737 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9738
9739         * copyright.py: Convert to Python 3.
9740
9741 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9742
9743         * copyright.py: Adapt after move of gnulib directory from gdb
9744         directory to toplevel directory.
9745
9746 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9747
9748         * copyright.py (main): Exit if run from the wrong directory.
9749
9750 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9751
9752         * top.c (print_gdb_version): Change copyright year to 2020.
9753
9754 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9755
9756         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
9757
9758 For older changes see ChangeLog-2019.
9759 \f
9760 Local Variables:
9761 mode: change-log
9762 left-margin: 8
9763 fill-column: 74
9764 version-control: never
9765 coding: utf-8
9766 End: