gdb/ChangeLog

   1 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * config.in: Regenerate.
   4
   5 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
   6
   7         * configure: Regenerate.
   8         * configure.ac: Check for strerror_r.
   9         * gdbsupport/common-utils.h (safe_strerror): Change return value
  10         to const char * and document that this function is now threadsafe.
  11         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
  12         thread_local and call strerror_r, if available.
  13         * utils.c (perror_string): Update.
  14         (print_sys_errmsg): Update.
  15
  16 2019-10-31  Luis Machado  <luis.machado@linaro.org>
  17
  18         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
  19         objfile_key.
  20         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
  21         objfile to fetch per-bfd data.
  22         (arm_find_exidx_entry): Likewise.
  23
  24 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * gdbsupport/agent.c (debug_agent): Change type to bool.
  27         (use_agent): Likewise.
  28         (all_agent_symbols_look_up): Likewise.
  29         (agent_loaded_p): Change return value to bool.
  30         (agent_look_up_symbols): Update.
  31         (agent_capability_check): Change return value to bool.
  32         * gdbsupport/agent.h (agent_loaded_p): Likewise.
  33         (debug_agent): Change type to bool.
  34         (use_agent): Likewise.
  35         (agent_capability_check): Change return value to bool.
  36
  37 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
  38
  39         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
  40         (build_minimal_symbol_hash_tables): Code to clear the table moved
  41         to clear_minimal_symbol_hash_tables.
  42         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
  43         when needed.
  44
  45 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  46
  47         * infcmd.c: Remove includes.
  48         * infrun.c: Remove includes.
  49
  50 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  51
  52         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
  53         (grow_vect): Remove declaration.
  54         (ada_type_of_array): Remove declaration.
  55         (ada_update_initial_language): Remove declaration.
  56         (ada_fold_name): Remove declaration.
  57         (ada_fill_in_ada_prototype): Remove declaration.
  58         (user_select_syms): Remove declaration.
  59         (get_selections): Remove declaration.
  60         (ada_tag_type): Remove declaration.
  61         (ada_value_tag): Remove declaration.
  62         (ada_is_others_clause): Remove declaration.
  63         (ada_in_variant): Remove declaration.
  64         (ada_value_struct_elt): Remove declaration.
  65         (ada_attribute_name): Remove declaration.
  66         (ada_system_address_type): Remove declaration.
  67         * ada-lang.c (ada_watch_location_expression): Make static.
  68         (GROW_VECT): Move here from ada-lang.h.
  69         (grow_vect): Make static.
  70         (ada_update_initial_language): Make static.
  71         (ada_fold_name): Make static.
  72         (ada_type_of_array): Make static.
  73         (encoded_ordered_before): Move up.
  74         (sort_choices): Move up.
  75         (print_signatures): Move up.
  76         (ada_print_symbol_signature): Move up.
  77         (get_selections): Move up and make static.
  78         (user_select_syms): Move up and make static.
  79         (ada_value_struct_elt): Move up and make static.
  80         (ada_tag_type): Make static.
  81         (ada_value_tag): Make static.
  82         (ada_is_others_clause): Make static.
  83         (ada_in_variant): Make static.
  84         (ada_attribute_name): Make static.
  85
  86 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  87
  88         * ada-lang.c: Remove includes.
  89         * ada-typeprint.c: Remove includes.
  90         * ada-valprint.c: Remove includes.
  91
  92 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
  93
  94         * addrmap.c: Add static assertions of type size, moved from
  95         _initialize_addrmap.
  96         (_initialize_addrmap): Remove.
  97
  98 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  99
 100         * coffread.c (record_minimal_symbol): Update.
 101         (process_coff_symbol): Update.
 102         * dbxread.c (read_dbx_symtab): Update.
 103         * dwarf2read.c (add_partial_symbol): Update.
 104         (fixup_go_packaging): Update.
 105         (load_partial_dies): Update.
 106         (new_symbol): Update.
 107         * elfread.c (record_minimal_symbol): Change signature to use
 108         gdb::string_view instead of name+len.
 109         (elf_symtab_read): Update.
 110         (elf_rel_plt_read): Update.
 111         * mdebugread.c (parse_partial_symbols): Update.
 112         (handle_psymbol_enumerators): Update.
 113         (new_symbol): Update.
 114         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 115         to use gdb::string_view instead of name+len.
 116         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 117         * psympriv.h (add_psymbol_to_list): Likewise.
 118         * psymtab.c (add_psymbol_to_bcache): Likewise.
 119         (add_psymbol_to_list): Likewise.
 120         * stabsread.c (define_symbol): Update.
 121         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 122         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 123         (symbol_set_names): Likewise.
 124         * xcoffread.c (scan_xcoff_symtab): Update.
 125
 126 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 127
 128         * symtab.h (symbol_set_names): Document that copy_name must be
 129         set to true for non-nullterminated strings.
 130         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 131         linkage_name if the entry was not found and we need to demangle.
 132
 133 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 134
 135         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 136         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 137         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 138         * gdbsupport/gdb_binary_search.h: New file.
 139
 140 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 141
 142         * NEWS: Mention new --with-system-gdbinit-dir option.
 143         * config.in: Regenerate.
 144         * configure: Regenerate.
 145         * configure.ac: Add new option --with-system-gdbinit-dir.
 146         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 147         for a ".gdb" suffix.
 148         * main.c (get_init_files): Change system_gdbinit argument to
 149         a vector and return the files in SYSTEM_GDBINIT_DIR in
 150         addition to SYSTEM_GDBINIT.
 151         (captured_main_1): Update.
 152         (print_gdb_help): Update.
 153         * top.c (print_gdb_configuration): Also print the value of
 154         SYSTEM_GDBINIT_DIR.
 155
 156 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 159         that takes gdb::string_view arguments.
 160
 161 2019-10-26  Tom de Vries  <tdevries@suse.de>
 162
 163         * aarch64-linux-tdep.c: Fix typos in comments.
 164         * aarch64-tdep.c: Same.
 165         * ada-lang.c: Same.
 166         * amd64-nat.c: Same.
 167         * arc-tdep.c: Same.
 168         * arch/aarch64-insn.c: Same.
 169         * block.c: Same.
 170         * breakpoint.h: Same.
 171         * btrace.h: Same.
 172         * c-varobj.c: Same.
 173         * cli/cli-decode.c: Same.
 174         * cli/cli-script.c: Same.
 175         * cli/cli-utils.h: Same.
 176         * coff-pe-read.c: Same.
 177         * coffread.c: Same.
 178         * compile/compile-cplus-symbols.c: Same.
 179         * compile/compile-object-run.c: Same.
 180         * completer.c: Same.
 181         * corelow.c: Same.
 182         * cp-support.c: Same.
 183         * demangle.c: Same.
 184         * dwarf-index-write.c: Same.
 185         * dwarf2-frame.c: Same.
 186         * dwarf2-frame.h: Same.
 187         * eval.c: Same.
 188         * frame-base.h: Same.
 189         * frame.h: Same.
 190         * gdbcmd.h: Same.
 191         * gdbtypes.h: Same.
 192         * gnu-nat.c: Same.
 193         * guile/scm-objfile.c: Same.
 194         * i386-tdep.c: Same.
 195         * i386-tdep.h: Same.
 196         * infcall.c: Same.
 197         * infcall.h: Same.
 198         * linux-nat.c: Same.
 199         * m68k-tdep.c: Same.
 200         * macroexp.c: Same.
 201         * memattr.c: Same.
 202         * mi/mi-cmd-disas.c: Same.
 203         * mi/mi-getopt.h: Same.
 204         * mi/mi-main.c: Same.
 205         * minsyms.c: Same.
 206         * nat/aarch64-sve-linux-sigcontext.h: Same.
 207         * objfiles.h: Same.
 208         * ppc-linux-nat.c: Same.
 209         * ppc-linux-tdep.c: Same.
 210         * ppc-tdep.h: Same.
 211         * progspace.h: Same.
 212         * prologue-value.h: Same.
 213         * python/py-evtregistry.c: Same.
 214         * python/py-instruction.h: Same.
 215         * record-btrace.c: Same.
 216         * record-full.c: Same.
 217         * remote.c: Same.
 218         * rs6000-tdep.c: Same.
 219         * ser-tcp.c: Same.
 220         * sol-thread.c: Same.
 221         * sparc-sol2-tdep.c: Same.
 222         * sparc64-tdep.c: Same.
 223         * stabsread.c: Same.
 224         * symfile.c: Same.
 225         * symtab.h: Same.
 226         * target.c: Same.
 227         * tracepoint.c: Same.
 228         * tui/tui-data.h: Same.
 229         * tui/tui-io.c: Same.
 230         * tui/tui-win.c: Same.
 231         * tui/tui.c: Same.
 232         * unittests/rsp-low-selftests.c: Same.
 233         * user-regs.h: Same.
 234         * utils.c: Same.
 235         * utils.h: Same.
 236         * valarith.c: Same.
 237         * valops.c: Same.
 238         * valprint.c: Same.
 239         * valprint.h: Same.
 240         * value.c: Same.
 241         * value.h: Same.
 242         * varobj.c: Same.
 243         * x86-nat.h: Same.
 244         * xtensa-tdep.c: Same.
 245
 246 2019-10-25  Ali Tamur <tamur@google.com>
 247
 248         * charset.c (find_charset_names): Reflect API change.
 249
 250 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 251
 252         * symtab.c (struct demangled_name_entry): Change demangled name
 253         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 254         part of the struct anymore.
 255         (symbol_set_names): No longer obstack allocate + copy the demangled
 256         name, just store the allocated name from bfd.
 257
 258 2019-10-25  Tom Tromey  <tromey@adacore.com>
 259
 260         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 261         (bsearch_cie_cmp, add_cie): Remove.
 262         (find_cie): Reimplement.
 263         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 264         (dwarf2_build_frame_info): Update.
 265
 266 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 267
 268         PR gdb/25126
 269         * symfile.c (reread_symbols): Call forget_cached_source_info to
 270         clear the stale source cache.
 271
 272 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 273
 274         * configure: Regenerate.
 275         * configure.ac: Remove code that sets python_has_threads.
 276
 277 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * config.in: Regenerate.
 280         * configure: Regenerate.
 281         * configure.ac: Remove the code that uses sed to get the python
 282         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 283
 284 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 285
 286         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 287         error paths.
 288
 289 2019-10-23  Tom Tromey  <tom@tromey.com>
 290
 291         * arc-tdep.c: Remove ".." from include.
 292         * frv-tdep.c: Remove ".." from include.
 293         * lm32-tdep.c: Remove ".." from include.
 294         * microblaze-tdep.c: Remove ".." from include.
 295         * or1k-tdep.h: Remove ".." from include.
 296         * s12z-tdep.c: Remove ".." from include.
 297         * Makefile.in (OPCODES_CFLAGS): Add comment.
 298         (TOP_CFLAGS): New variable.
 299         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 300
 301 2019-10-23  Tom Tromey  <tom@tromey.com>
 302
 303         * Makefile.in (READLINE_DIR): Update.
 304
 305 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 306
 307         * infcall.c (call_function_by_hand_dummy): Fix the function
 308         comment.  And extract out a code section into...
 309         (reserve_stack_space): ...this new function.
 310
 311 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 312
 313         * infcall.c (value_arg_coerce): Remove an unused parameter.
 314         (call_function_by_hand_dummy): Update the call to
 315         'value_arg_coerce'.
 316
 317 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 318
 319         * infcall.c (call_function_by_hand_dummy): Refactor.
 320
 321 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 322
 323         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 324
 325 2019-10-23  Tom Tromey  <tom@tromey.com>
 326
 327         * configure: Rebuild.
 328         * configure.ac: Don't check for sigprocmask.
 329         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 330
 331 2019-10-23  Tom Tromey  <tom@tromey.com>
 332
 333         * configure: Rebuild.
 334         * acinclude.m4: Use m4_include, not sinclude.
 335
 336 2019-10-23  Tom de Vries  <tdevries@suse.de>
 337
 338         PR breakpoints/24687
 339         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 340
 341 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 342
 343         * symtab.c (struct demangled_name_entry) <language>: Change from
 344         bitfield to regular variable.
 345
 346 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 347
 348         * symtab.c (struct demangled_name_entry): Add a constructor.
 349         (free_demangled_name_entry): New function to call the destructor
 350         for demangled_name_entry.
 351         (create_demangled_names_hash): Pass free_demangled_name_entry to
 352         htab_create_alloc.
 353         (symbol_set_names): Call placement new for demangled_name_entry.
 354         * utils.c: No longer include xxhash.h here, now that fast_hash
 355         is inlined in the header.
 356         * utils.h: Instead, include it here.
 357
 358 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 359
 360         * Makefile.in: Link with libxxhash.
 361         * config.in: Regenerate.
 362         * configure: Regenerate.
 363         * configure.ac: Search for libxxhash.
 364         * utils.c (fast_hash): Use xxhash if present.
 365
 366 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 367
 368         * utils.h (fast_hash): New function.
 369         * symtab.c (hash_demangled_name_entry): Call new function
 370         fast_hash.
 371
 372 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 373
 374         * symtab.c (struct demangled_name_entry): Change type of mangled
 375         to gdb::string_view. Also adds a constructor that takes the
 376         mangled name.
 377         (hash_demangled_name_entry): Update.
 378         (eq_demangled_name_entry): Update.
 379         (free_demangled_name_entry): New function to call the destructor
 380         now that this is not a POD anymore.
 381         (create_demangled_names_hash): Pass free_demangled_name_entry to
 382         htab_create_alloc.
 383         (symbol_set_names): Update.
 384
 385 2019-10-21  Ali Tamur  <tamu@google.com>
 386
 387         * dwarf2read.c (dir_index): Change type.
 388         (file_name_index): Likewise.
 389         (line_header::include_dir_at): Change comment and implementation on
 390         whether it is DWARF 5.
 391         (line_header::is_valid_file_index): New function.
 392         (line_header::file_name_at): Change comment and implementation on
 393         whether it is DWARF 5.
 394         (line_header::file_names): Change to private field renamed as
 395         m_file_names and introduce a new accessor method.
 396         (line_header::file_names_size): New method.
 397         (line_header::include_dirs): Change to private field and rename as
 398         m_include_dirs.
 399         (dw2_get_file_names_reader): Define local var at a smaller scope and
 400         reflect API change.
 401         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 402         (process_structure_scope): Likewise.
 403         (line_header::add_include_dir): Change message and reflect renaming.
 404         (line_header::add_file_name): Likewise.
 405         (read_formatted_entries): Handle DW_FORM_data16.
 406         (dwarf_decode_line_header): Fix line header length calculation.
 407         (psymtab_include_file_name): Change comment and API.
 408         (lnp_state_machine::m_file): Update comment and reflect type change.
 409         (lnp_state_machine::record_line): Reflect type change.
 410         (dwarf_decode_lines): Reflect API change.
 411         (file_file_name): Likewise.
 412         (file_full_name): Likewise.
 413
 414 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 415
 416         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 417
 418 2019-10-21  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 421
 422 2019-10-21  Tom Tromey  <tom@tromey.com>
 423
 424         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 425         NM_H.   Use AC_CONFIG_LINKS.
 426         * configure: Rebuild.
 427         * Makefile.in (NM_H): New variable.
 428         (generated_files): Add NM_H.  Remove gcore.
 429         (nm.h, stamp-nmh): New targets.
 430
 431 2019-10-20  Tom Tromey  <tom@tromey.com>
 432
 433         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 434         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 435         obsolete comment.
 436         (put_objfile_before): Now static.
 437
 438 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 439
 440         * gdbsupport/common-utils.h (startswith): Change return type to
 441         bool.
 442
 443 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 444
 445         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 446         * breakpoint.c (bp_locations_compare): Rename to...
 447         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 448         (update_global_location_list): Use std::sort instead of qsort.
 449         * buildsym.c (compare_line_numbers): Rename to...
 450         (lte_is_less_than): ...this, and change to std::sort semantics.
 451         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 452         instead of qsort.
 453         * disasm.c (compare_lines): Rename to...
 454         (line_is_less_than): ...this, and change to std::sort semantics.
 455         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 456         of qsort.
 457         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 458         (fde_is_less_than): ...this, and change to std::sort semantics.
 459         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 460         * mdebugread.c (compare_blocks):
 461         (block_is_less_than): ...this, and change to std::sort semantics.
 462         (sort_blocks): Call std::sort instead of qsort.
 463         * objfiles.c (qsort_cmp): Rename to...
 464         (sort_cmp): ...this, and change to std::sort semantics.
 465         (update_section_map): Call std::sort instead of qsort.
 466         * remote.c (compare_pnums): Remove.
 467         (map_regcache_remote_table): Call std::sort instead of qsort.
 468         * utils.c (compare_positive_ints): Remove.
 469         * utils.h (compare_positive_ints): Remove.
 470         * xcoffread.c (compare_lte): Remove.
 471         (arrange_linetable): Call std::sort instead of qsort.
 472
 473 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 474
 475         * symfile.c (init_entry_point_info): Fix typo.
 476         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 477
 478 2019-10-18  Tom de Vries  <tdevries@suse.de>
 479
 480         * aarch64-tdep.c: Fix typos in comments.
 481         * ada-lang.c: Same.
 482         * ada-tasks.c: Same.
 483         * alpha-tdep.c: Same.
 484         * alpha-tdep.h: Same.
 485         * amd64-nat.c: Same.
 486         * amd64-windows-tdep.c: Same.
 487         * arc-tdep.c: Same.
 488         * arc-tdep.h: Same.
 489         * arch-utils.c: Same.
 490         * arm-nbsd-tdep.c: Same.
 491         * arm-tdep.c: Same.
 492         * ax-gdb.c: Same.
 493         * blockframe.c: Same.
 494         * btrace.c: Same.
 495         * c-varobj.c: Same.
 496         * coff-pe-read.c: Same.
 497         * coffread.c: Same.
 498         * cris-tdep.c: Same.
 499         * darwin-nat.c: Same.
 500         * dbxread.c: Same.
 501         * dcache.c: Same.
 502         * disasm.c: Same.
 503         * dtrace-probe.c: Same.
 504         * dwarf-index-write.c: Same.
 505         * dwarf2-frame-tailcall.c: Same.
 506         * dwarf2-frame.c: Same.
 507         * dwarf2read.c: Same.
 508         * eval.c: Same.
 509         * exceptions.c: Same.
 510         * fbsd-tdep.c: Same.
 511         * findvar.c: Same.
 512         * frame.c: Same.
 513         * frv-tdep.c: Same.
 514         * gnu-v3-abi.c: Same.
 515         * go32-nat.c: Same.
 516         * h8300-tdep.c: Same.
 517         * hppa-tdep.c: Same.
 518         * i386-linux-tdep.c: Same.
 519         * i386-tdep.c: Same.
 520         * ia64-libunwind-tdep.c: Same.
 521         * ia64-tdep.c: Same.
 522         * infcmd.c: Same.
 523         * infrun.c: Same.
 524         * linespec.c: Same.
 525         * linux-nat.c: Same.
 526         * linux-thread-db.c: Same.
 527         * machoread.c: Same.
 528         * mdebugread.c: Same.
 529         * mep-tdep.c: Same.
 530         * mn10300-tdep.c: Same.
 531         * namespace.c: Same.
 532         * objfiles.c: Same.
 533         * opencl-lang.c: Same.
 534         * or1k-tdep.c: Same.
 535         * osabi.c: Same.
 536         * ppc-linux-nat.c: Same.
 537         * ppc-linux-tdep.c: Same.
 538         * ppc-sysv-tdep.c: Same.
 539         * printcmd.c: Same.
 540         * procfs.c: Same.
 541         * record-btrace.c: Same.
 542         * record-full.c: Same.
 543         * remote-fileio.c: Same.
 544         * remote.c: Same.
 545         * rs6000-tdep.c: Same.
 546         * s12z-tdep.c: Same.
 547         * score-tdep.c: Same.
 548         * ser-base.c: Same.
 549         * ser-go32.c: Same.
 550         * skip.c: Same.
 551         * sol-thread.c: Same.
 552         * solib-svr4.c: Same.
 553         * solib.c: Same.
 554         * source.c: Same.
 555         * sparc-nat.c: Same.
 556         * sparc-sol2-tdep.c: Same.
 557         * sparc-tdep.c: Same.
 558         * sparc64-tdep.c: Same.
 559         * stabsread.c: Same.
 560         * stack.c: Same.
 561         * symfile.c: Same.
 562         * symtab.c: Same.
 563         * target-descriptions.c: Same.
 564         * target-float.c: Same.
 565         * thread.c: Same.
 566         * utils.c: Same.
 567         * valops.c: Same.
 568         * valprint.c: Same.
 569         * value.c: Same.
 570         * varobj.c: Same.
 571         * windows-nat.c: Same.
 572         * xcoffread.c: Same.
 573         * xstormy16-tdep.c: Same.
 574         * xtensa-tdep.c: Same.
 575
 576 2019-10-17  Tom Tromey  <tromey@adacore.com>
 577
 578         * configure: Rebuild.
 579         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 580         in AC_CONFIG_FILES invocation.
 581         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 582         new-style config.status invocation.
 583
 584 2019-10-17  Tom de Vries  <tdevries@suse.de>
 585
 586         * arm-nbsd-nat.c: Fix typos in comments.
 587         * arm-tdep.c: Same.
 588         * darwin-nat-info.c: Same.
 589         * dwarf2read.c: Same.
 590         * elfread.c: Same.
 591         * event-top.c: Same.
 592         * findvar.c: Same.
 593         * gdbtypes.c: Same.
 594         * hppa-tdep.c: Same.
 595         * i386-tdep.c: Same.
 596         * jit.c: Same.
 597         * main.c: Same.
 598         * mdebugread.c: Same.
 599         * moxie-tdep.c: Same.
 600         * nto-procfs.c: Same.
 601         * osabi.c: Same.
 602         * ppc-linux-tdep.c: Same.
 603         * remote.c: Same.
 604         * riscv-tdep.c: Same.
 605         * s390-tdep.c: Same.
 606         * sh-tdep.c: Same.
 607         * sparc-linux-tdep.c: Same.
 608         * sparc-nat.c: Same.
 609         * stack.c: Same.
 610         * target-descriptions.c: Same.
 611         * top.c: Same.
 612         * varobj.c: Same.
 613
 614 2019-10-16  Tom Tromey  <tom@tromey.com>
 615
 616         * objfiles.h (struct objfile) <original_name>: Now const.
 617
 618 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 619
 620         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 621         pass on to sigsetjmp's second argument.
 622         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 623
 624 2019-10-16  Keith Seitz  <keiths@redhat.com>
 625
 626         PR gdb/23567
 627         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 628         sections whose size is greater than the file size.
 629
 630 2019-10-16  Jim Wilson  <jimw@sifive.com>
 631
 632         * riscv-tdep.c (riscv_gcc_target_options): New.
 633         (riscv_gnu_triplet_regexp): New.
 634         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 635         set_gdbarch_gnu_triplet_regexp.
 636
 637 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 638
 639         * Makefile.in: Add xml-builtin.h.
 640         * features/feature_to_c.sh: Add an include for xml-builtin.h
 641         to ensure that the compiler checks that the types match.
 642         * xml-builtin.h: New file.
 643         * xml-support.c (fetch_xml_builtin): Add missing const.
 644         * xml-support.h: Remove declaration of xml_builtins.
 645
 646 2019-10-16  Tom de Vries  <tdevries@suse.de>
 647
 648         PR tdep/25096
 649         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 650         (amd64_classify_aggregate): ... here.
 651         (amd64_classify_aggregate_field): Handled fiels of nested structs
 652         recursively.
 653
 654 2019-10-16  Tom de Vries  <tdevries@suse.de>
 655
 656         PR tdep/24104
 657         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 658         that handles 'theclass'.
 659
 660 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * linespec.c (decode_digits_ordinary): Update comment.
 663         * make-target-delegates: No longer need to handle VEC case.
 664         * memrange.c (normalize_mem_ranges): Update comment.
 665         * namespace.c (add_using_directive): Update comment.
 666         * objc-lang.c (uniquify_strings): Update comment.
 667         * ppc-linux-nat.c (struct thread_points): Update comment.
 668         * probe.h (find_probes_in_objfile): Update comment.
 669         * target.h (enum flash_preserve_mode): Update comment.
 670         * varobj.c (varobj_restrict_range): Update comment.
 671         * varobj.h (varobj_list_children): Update comment.
 672
 673 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 674
 675         * Makefile.in: Remove references to vec.h and vec.c.
 676         * aarch64-tdep.c: No longer include vec.h.
 677         * ada-lang.c: Likewise.
 678         * ada-lang.h: Likewise.
 679         * arm-tdep.c: Likewise.
 680         * ax.h: Likewise.
 681         * breakpoint.h: Likewise.
 682         * charset.c: Likewise.
 683         * cp-support.h: Likewise.
 684         * dtrace-probe.c: Likewise.
 685         * dwarf2read.c: Likewise.
 686         * extension.h: Likewise.
 687         * gdb_bfd.c: Likewise.
 688         * gdbsupport/gdb_vecs.h: Likewise.
 689         * gdbsupport/vec.c: Remove.
 690         * gdbsupport/vec.h: Remove.
 691         * gdbthread.h: Likewise.
 692         * guile/scm-type.c: Likewise.
 693         * inline-frame.c: Likewise.
 694         * machoread.c: Likewise.
 695         * memattr.c: Likewise.
 696         * memrange.h: Likewise.
 697         * namespace.h: Likewise.
 698         * nat/linux-btrace.h: Likewise.
 699         * osdata.c: Likewise.
 700         * parser-defs.h: Likewise.
 701         * progspace.h: Likewise.
 702         * python/py-type.c: Likewise.
 703         * record-btrace.c: Likewise.
 704         * rust-exp.y: Likewise.
 705         * solib-target.c: Likewise.
 706         * stap-probe.c: Likewise.
 707         * target-descriptions.c: Likewise.
 708         * target-memory.c: Likewise.
 709         * target.h: Likewise.
 710         * varobj.c: Likewise.
 711         * varobj.h: Likewise.
 712         * xml-support.h: Likewise.
 713
 714 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 717         Update for new std::vector based implementation.
 718         (process_psymtab_comp_unit_reader): Likewise.
 719         (scan_partial_symbols): Likewise.
 720         (recursively_compute_inclusions): Likewise.
 721         (compute_compunit_symtab_includes): Likewise.
 722         (process_imported_unit_die): Likewise.
 723         (queue_and_load_dwo_tu): Likewise.
 724         (follow_die_sig_1): Likewise.
 725         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 726         (typedef dwarf2_per_cu_ptr): Remove.
 727         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 728         function.
 729         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 730         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 731         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 732         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 733         std::vector.
 734
 735 2019-10-15  Tom Tromey  <tromey@adacore.com>
 736
 737         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 738         TID.
 739
 740 2019-10-15  Tom Tromey  <tromey@adacore.com>
 741
 742         * windows-nat.c (windows_nat_target::fetch_registers)
 743         (windows_nat_target::store_registers): Rename "pid" to "tid".
 744
 745 2019-10-15  Tom Tromey  <tromey@adacore.com>
 746
 747         * gdbarch.h, gdbarch.c: Rebuild.
 748         * gdbarch.sh (gcc_target_options): Change return type to
 749         std::string.
 750         * compile/compile.c (get_args): Update.
 751         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 752         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 753         std::string.
 754         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 755         std::string.
 756         * arch-utils.c (default_gcc_target_options): Return std::string.
 757         * arch-utils.h (default_gcc_target_options): Return std::string.
 758         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 759
 760 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 761
 762         * breakpoint.c (breakpoint_chain): Make static.
 763         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 764         of accessing breakpoint_chain.
 765
 766 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 767
 768         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 769         to a gdb::function_view and return value to bool.
 770         * breakpoint.h (iterate_over_breakpoints): Likewise.
 771         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 772         (pop_dummy_frame): Update.
 773         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 774         (gdbscm_breakpoints): Update.
 775         * python/py-breakpoint.c (build_bp_list): Update.
 776         (gdbpy_breakpoints): Update.
 777         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 778         Update.
 779         (bpfinishpy_handle_stop): Update.
 780         (bpfinishpy_handle_exit): Update.
 781         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 782         (svr4_update_solib_event_breakpoints): Update.
 783
 784 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 785
 786         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 787         when unwrapping single-field structs.
 788
 789 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 790
 791         * dwarf2read.c: Remove includes.
 792
 793 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 794
 795         * ui-out.c (ui_out::call_do_message): Silence
 796         -Wformat-nonliteral warning.
 797
 798 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 799
 800         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 801         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 802         include: readline/tilde.h.
 803
 804 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 805
 806         * remote.c (remote_target::get_trace_status): Remove declaration of
 807         trace_regblock_size.
 808
 809 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 810
 811         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 812         (show_user): Remove declaration of cmdlist.
 813         * cli/cli-cmds.h (max_user_call_depth): Declare.
 814         * cli/cli-script.c (execute_user_command): Remove declaration
 815         of max_user_call_depth.
 816
 817 2019-10-11  Jim Wilson  <jimw@sifive.com>
 818
 819         * gdbsupport/print-utils.h (pulongest): Fix comment.
 820         (plongest): Likewise.
 821         (phex): Add missing comment, mention leading zeros.
 822         (phex_nz): Add mention of no leading zeros to comment.
 823
 824         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 825         plongest instead of unsigned long long cast.
 826
 827 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 828
 829         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 830         for external_editor_command and gdbtk_test.
 831
 832 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 833
 834         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 835         * varobj.c (varobjdebug): Move comment to...
 836         * varobj.h (varobjdebug): ...here, and declare.
 837
 838 2019-10-09  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 841         erase_data_content.
 842
 843 2019-10-09  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 846         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 847         * tui/tui-command.c (tui_cmd_window::resize)
 848         (tui_refresh_cmd_win): Update.
 849         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 850         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 851         * tui/tui-data.c (~tui_gen_win_info): Remove.
 852         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 853         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 854         (tui_redisplay_readline, tui_mld_flush)
 855         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 856         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 857         (tui_data_window::erase_data_content)
 858         (tui_data_item_window::rerender)
 859         (tui_data_item_window::refresh_window): Update.
 860         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 861         (box_win, tui_gen_win_info::make_window)
 862         (tui_gen_win_info::make_visible): Update.
 863         (tui_delete_win): Remove.
 864         * tui/tui-winsource.c
 865         (tui_source_window_base::do_erase_source_content): Update.
 866         (tui_show_source_line, tui_source_window_base::update_tab_width)
 867         (tui_source_window_base::update_exec_info): Update.
 868         * tui/tui-data.h (struct curses_deleter): New.
 869         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 870         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 871
 872 2019-10-09  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 875
 876 2019-10-09  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 879         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 880
 881 2019-10-09  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 884         window height directly.
 885         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 886         declare.
 887         * tui/tui-layout.c (tui_default_win_height): Remove.
 888         (tui_default_win_viewport_height): Remove.
 889
 890 2019-10-09  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui.h: Remove comments.
 893
 894 2019-10-09  Tom de Vries  <tdevries@suse.de>
 895
 896         * python/lib/gdb/printer/bound_registers.py: Use
 897         '^builtin_type_bound128' as regexp argument for
 898         add_builtin_pretty_printer.
 899
 900 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 901
 902         * guile/guile.c (guile_extension_script_ops): Remove forward
 903         declaration and mark as static.
 904         (guile_script_ops): Likewise.
 905         (extension_language_guile): Move further down in the file so
 906         it can reference the definitions for guile_{extension_,}script_ops.
 907
 908 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 909
 910         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 911         except SORTL, DFLTCC, and KDSA.
 912
 913 2019-10-08  Tom Tromey  <tromey@adacore.com>
 914
 915         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 916         (struct safe_symbol_file_add_args): Remove.
 917
 918 2019-10-08  Tom Tromey  <tromey@adacore.com>
 919
 920         * windows-nat.c: Don't include buildsym-legacy.h.
 921
 922 2019-10-08  Tom Tromey  <tromey@adacore.com>
 923
 924         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 925
 926 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 927
 928         * gdbtypes.c (overload_debug): Move comment to header.
 929         * gdbtypes.h (overload_debug): Declare.
 930         * valops.c: Remove declaration of overload_debug, instead
 931         include gdbtypes.h.
 932
 933 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 934
 935         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 936         through _().
 937         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 938         move comment...
 939         * language.h (lang_frame_mismatch_warn): ... here. Also add
 940         declaration.
 941         * top.c (lang_frame_mismatch_warn): Remove declaration.
 942         (check_frame_language_change): Pass lang_frame_mismatch_warn
 943         through _().
 944
 945 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 946
 947         * c-lang.h (vtbl_ptr_name): Declare.
 948         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 949         it from the header.
 950         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 951
 952 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 953
 954         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 955         gdb_static_assert.
 956
 957 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 958
 959         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 960         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 961         * ctfread.c: New file.
 962         * ctfread.h: New file.
 963         * elfread.c: Include ctfread.h.
 964         (struct elfinfo text_p): New member ctfsect.
 965         (elf_locate_sections): Mark CTF section.
 966         (elf_symfile_read): Call elfctf_build_psymtabs.
 967         * Makefile.in (LIBCTF): Add.
 968         (CLIBS): Use it.
 969         (CDEPS): Likewise.
 970         (DIST): Add ctfread.c.
 971
 972 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * ctfread.c (struct nextfield): Renamed to ...
 975         (struct ctf_nextfield): ... this.
 976         (struct field_info): Renamed to ...
 977         (strut ctf_field_info): ... this.
 978         (attach_fields_to_type): Update for renamed structures.
 979         (ctf_add_member_cb): Likewise.
 980         (ctf_add_enum_member_cb): Likewise.
 981         (process_struct_members): Likewise.
 982         (process_enum_type): Likewise.
 983
 984 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 985
 986         * tracectf.h: Rename, was ctf.h.
 987         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 988         * tracefile.c: Likewise.
 989         * tracepoint.c: Remove unused include ctf.h.
 990         * mi/mi-main.c: Likewise.
 991         * Makefile.in Replace ctf.c with tracectf.c.
 992
 993 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 994
 995         * version.in: Change version number to "9.0.50.DATE-git".
 996
 997 2019-10-03  Tom Tromey  <tom@tromey.com>
 998
 999         PR rust/24976:
1000         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1001
1002 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1005         cp_search_name_hash.
1006         * NEWS: Add entry about nested function support.
1007
1008 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1009             Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1012         for nested static variables when searchin VAR_DOMAIN.
1013         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1014         global scope, update comment.
1015         (add_partial_subprogram): Call add_partial_subprogram recursively
1016         for nested subroutines when processinng Fortran.
1017         (load_partial_dies): Process the child entities of a subprogram
1018         when processing Fortran.
1019         (partial_die_parent_scope): Handle building scope
1020         for Fortran nested functions.
1021         (process_die): Record that nested functions have a scope.
1022         (new_symbol): Always record Fortran subprograms on the global
1023         symbol list.
1024         (determine_prefix): How to build the prefix for Fortran
1025         subprograms.
1026
1027 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1030         have just sent the thread a SIGSTOP and are waiting for it to
1031         arrive.
1032
1033 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * btrace.c (btrace_add_pc): Remove whitespace before the template
1036         parameter in 'std::vector <...>'.
1037         (parse_xml_btrace_block): Likewise.
1038         (btrace_maint_decode_pt): Likewise.
1039         (btrace_maint_update_packets): Likewise.
1040         (btrace_maint_print_packets): Likewise.
1041         * btrace.h (struct btrace_maint_info): Likewise.
1042         * dwarf2read.c (struct type_unit_group): Likewise.
1043         (build_type_psymtabs_reader): Likewise.
1044         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1045         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1046         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1047
1048 2019-10-03  Tom de Vries  <tdevries@suse.de>
1049
1050         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1051         the first line of the help text for set/show style metadata.
1052
1053 2019-10-02  Tom Tromey  <tromey@adacore.com>
1054
1055         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1056         * gdbsupport/common-inferior.c: New file.
1057         * infcmd.c (startup_with_shell): Don't define.
1058         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1059         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1060         * inferior.h (startup_with_shell): Don't declare.
1061
1062 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1063
1064         * gdbsupport/gdb_assert.h: Include errors.h.
1065         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1066
1067 2019-10-02  Tom Tromey  <tromey@adacore.com>
1068
1069         * NEWS: Add $_ada_exception entry.
1070         * ada-lang.c (struct ada_catchpoint): Add constructor.
1071         <m_kind>: New member.
1072         (allocate_location_exception, re_set_exception): Remove
1073         "ex" parameter.
1074         (should_stop_exception): Compute $_ada_exception.
1075         (check_status_exception, print_it_exception)
1076         (print_one_exception, print_mention_exception): Remove
1077         "ex" parameter.
1078         (allocate_location_catch_exception, re_set_catch_exception)
1079         (check_status_exception, print_it_catch_exception)
1080         (print_one_catch_exception, print_mention_catch_exception)
1081         (print_recreate_catch_exception)
1082         (allocate_location_catch_exception_unhandled)
1083         (re_set_catch_exception_unhandled)
1084         (check_status_exception, print_it_catch_exception_unhandled)
1085         (print_one_catch_exception_unhandled)
1086         (print_mention_catch_exception_unhandled)
1087         (print_recreate_catch_exception_unhandled)
1088         (allocate_location_catch_assert, re_set_catch_assert)
1089         (check_status_assert, print_it_catch_assert)
1090         (print_one_catch_assert, print_mention_catch_assert)
1091         (print_recreate_catch_assert)
1092         (allocate_location_catch_handlers, re_set_catch_handlers)
1093         (check_status_handlers, print_it_catch_handlers)
1094         (print_one_catch_handlers, print_mention_catch_handlers)
1095         (print_recreate_catch_handlers): Remove.
1096         (create_ada_exception_catchpoint): Update.
1097         (initialize_ada_catchpoint_ops): Update.
1098
1099 2019-10-02  Tom Tromey  <tromey@adacore.com>
1100
1101         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1102         (create_excep_cond_exprs): Simplify exception string computation.
1103         (ada_exception_catchpoint_cond_string): Likewise.
1104
1105 2019-10-02  Tom Tromey  <tromey@adacore.com>
1106
1107         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1108         * ada-lang.c (lesseq_defined_than): Handle
1109         LOC_STATIC.
1110         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1111         parameter.
1112         (dwarf2_has_info): Likewise.
1113         (new_symbol): Set maybe_copied on symbol when
1114         appropriate.
1115         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1116         parameter.
1117         <can_copy>: New member.
1118         * elfread.c (record_minimal_symbol): Set maybe_copied
1119         on symbol when appropriate.
1120         (elf_symfile_read): Update call to dwarf2_has_info.
1121         * minsyms.c (lookup_minimal_symbol_linkage): New
1122         function.
1123         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1124         * symtab.c (get_symbol_address, get_msymbol_address):
1125         New functions.
1126         * symtab.h (get_symbol_address, get_msymbol_address):
1127         Declare.
1128         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1129         maybe_copied.
1130         (struct symbol, struct minimal_symbol) <maybe_copied>:
1131         New member.
1132
1133 2019-10-02  Tom Tromey  <tromey@adacore.com>
1134
1135         * source.c (struct current_source_location): New.
1136         (current_source_key): New global.
1137         (current_source_symtab, current_source_line)
1138         (current_source_pspace): Remove.
1139         (get_source_location): New function.
1140         (get_current_source_symtab_and_line)
1141         (set_default_source_symtab_and_line)
1142         (set_current_source_symtab_and_line)
1143         (clear_current_source_symtab_and_line, select_source_symtab)
1144         (info_source_command, print_source_lines_base)
1145         (info_line_command, search_command_helper, _initialize_source):
1146         Update.
1147
1148 2019-10-02  Tom Tromey  <tromey@adacore.com>
1149
1150         * source.c (select_source_symtab): Don't call
1151         decode_line_with_current_source.
1152
1153 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * symtab.c (lookup_global_symbol): Search global block.
1156
1157 2019-10-02  Tom Tromey  <tromey@adacore.com>
1158
1159         * coffread.c (process_coff_symbol): Update.
1160         * dwarf2read.c (var_decode_location, new_symbol): Update.
1161         * mdebugread.c (parse_symbol): Update.
1162         * objfiles.c (relocate_one_symbol): Update.
1163         * stabsread.c (define_symbol, fix_common_block)
1164         (scan_file_globals): Update.
1165         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1166         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1167         * xcoffread.c (process_xcoff_symbol): Update.
1168
1169 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1170
1171         * MAINTAINERS: Update my email address.
1172
1173 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1176         std::vector.
1177         (build_type_psymtabs_reader): Update for std::vector.
1178         (build_type_psymtab_dependencies): Likewise.
1179         * dwarf2read.h: Remove use of DEF_VEC_P.
1180         (typedef sig_type_ptr): Delete.
1181
1182 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1185         to std::vector.
1186         (btrace_maint_decode_pt): Likewise, and move allocation of the
1187         vector outside of the loop.
1188         (btrace_maint_update_packets): Update to handle change from VEC to
1189         std::vector.
1190         (btrace_maint_print_packets): Likewise.
1191         (maint_info_btrace_cmd): Likewise.
1192         * btrace.h: Remove use of DEF_VEC_O.
1193         (typedef btrace_pt_packet_s): Delete.
1194         (struct btrace_maint_info) <packets>: Change fromm VEC to
1195         std::vector.
1196         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1197
1198 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1201         make accesses into the vector constant references.
1202         (btrace_add_pc): Update for std::vector.
1203         (btrace_stitch_bts): Likewise.
1204         (parse_xml_btrace_block): Likewise.
1205         (btrace_maint_update_packets): Likewise.
1206         (btrace_maint_print_packets): Likewise.
1207         (maint_info_btrace_cmd): Likewise.
1208         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1209         std::vector.
1210         (btrace_data::empty): Likewise.
1211         (btrace_data_append): Likewise.
1212         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1213         (typedef btrace_block_s): Delete.
1214         (struct btrace_block): Add constructor.
1215         (struct btrace_data_bts) <blocks>: Change to std::vector.
1216         * nat/linux-btrace.c (perf_event_read_bts): Update for
1217         std::vector.
1218         (linux_read_bts): Likewise.
1219
1220 2019-10-01  Tom Tromey  <tom@tromey.com>
1221
1222         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1223
1224 2019-10-01  Tom Tromey  <tom@tromey.com>
1225
1226         * stack.c (print_frame, info_frame_command_core): Use
1227         styled_string.
1228         * linux-thread-db.c (try_thread_db_load_1)
1229         (try_thread_db_load_from_pdir_1): Use styled_string.
1230         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1231         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1232         (maybe_print_unsupported_script_warning)
1233         (maybe_print_script_not_found_warning): Use styled_string.
1234         * ada-lang.c (user_select_syms): Use styled_string.
1235
1236 2019-10-01  Tom Tromey  <tom@tromey.com>
1237
1238         * p-lang.c (pascal_printstr): Use metadata style.
1239         * value.c (show_convenience): Use metadata style.
1240         * valprint.c (valprint_check_validity, val_print_optimized_out)
1241         (val_print_not_saved, val_print_unavailable)
1242         (val_print_invalid_address, generic_val_print, val_print)
1243         (value_check_printable, val_print_array_elements): Use metadata
1244         style.
1245         * ui-out.h (class ui_out) <field_fmt>: New overload.
1246         <do_field_fmt>: Add style parameter.
1247         * ui-out.c (ui_out::field_fmt): New overload.
1248         * typeprint.c (type_print_unknown_return_type)
1249         (val_print_not_allocated, val_print_not_associated): Use metadata
1250         style.
1251         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1252         parameter.
1253         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1254         * tracepoint.c (tvariables_info_1): Use metadata style.
1255         * stack.c (print_frame_arg, print_frame_info, print_frame)
1256         (info_frame_command_core): Use metadata style.
1257         * skip.c (info_skip_command): Use metadata style.
1258         * rust-lang.c (rust_print_enum): Use metadata style.
1259         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1260         metadata style.
1261         * python/py-framefilter.c (py_print_single_arg): Use metadata
1262         style.
1263         * printcmd.c (do_one_display, print_variable_and_value): Use
1264         metadata style.
1265         * p-valprint.c (pascal_val_print)
1266         (pascal_object_print_value_fields): Use metadata style.
1267         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1268         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1269         parameter.
1270         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1271         * m2-valprint.c (m2_print_long_set): Use metadata style.
1272         * m2-typeprint.c (m2_print_type): Use metadata style.
1273         * infcmd.c (print_return_value_1): Use metadata style.
1274         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1275         * f-valprint.c (info_common_command_for_block): Use metadata
1276         style.
1277         * f-typeprint.c (f_type_print_base): Use metadata style.
1278         * expprint.c (print_subexp_standard): Use metadata style.
1279         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1280         * cli/cli-style.h (class cli_style_option): Add constructor.
1281         (metadata_style): Declare.
1282         * cli/cli-style.c (metadata_style): New global.
1283         (_initialize_cli_style): Register metadata style.
1284         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1285         parameter.
1286         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1287         * c-typeprint.c (c_type_print_base_struct_union)
1288         (c_type_print_base_1): Use metadata style.
1289         * breakpoint.c (watchpoint_value_print)
1290         (print_one_breakpoint_location): Use metadata style.
1291         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1292         style.
1293         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1294         style.
1295         * ada-valprint.c (val_print_packed_array_elements, printstr)
1296         (print_field_values, ada_val_print_ref, ada_val_print): Use
1297         metadata style.
1298         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1299         style.
1300         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1301         style.
1302         * ada-lang.c (user_select_syms): Use metadata style.
1303
1304 2019-10-01  Tom Tromey  <tom@tromey.com>
1305
1306         * cli/cli-cmds.c (pwd_command): Style output.
1307
1308 2019-10-01  Pedro Alves  <palves@redhat.com>
1309             Tom Tromey  <tom@tromey.com>
1310
1311         * symtab.c (print_symbol_info): Use %ps.
1312         (print_msymbol_info): Use %ps.
1313         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1314         * printcmd.c (print_variable_and_value): Use %ps.
1315         * macrocmd.c (show_pp_source_pos): Use %ps.
1316         * infrun.c (print_exited_reason): Use ui_out::message.
1317         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1318         (describe_other_breakpoints): Use ui_out::message and new
1319         formats.
1320         (say_where): Use new formats.
1321         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1322         and new formats.
1323
1324 2019-10-01  Pedro Alves  <palves@redhat.com>
1325             Tom Tromey  <tom@tromey.com>
1326
1327         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1328         (test_gdb_formats): New function.
1329         (run_tests): Call it.
1330         (test_format_specifier): Update.
1331         * utils.h (fputs_filtered): Update comment.
1332         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1333         (fputs_styled_unfiltered): Declare.
1334         * utils.c (fputs_styled_unfiltered): New function.
1335         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1336         (vfprintf_filtered): Update.
1337         (vfprintf_unfiltered, vprintf_filtered): Update.
1338         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1339         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1340         disallow_ui_out_field>: New constants.
1341         (enum class field_kind): New.
1342         (struct base_field_s, struct signed_field_s): New.
1343         (signed_field): New function.
1344         (struct string_field_s): New.
1345         (string_field): New function.
1346         (struct styled_string_s): New.
1347         (styled_string): New function.
1348         (class ui_out) <message>: Add comment.
1349         <vmessage, call_do_message>: New methods.
1350         <do_message>: Add style parameter.
1351         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1352         methods.
1353         (ui_out::message): Rewrite.
1354         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1355         parameter.
1356         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1357         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1358         gdb_extensions parameter.
1359         (class format_piece): Add parameter to constructor.
1360         (n_int_args): New field.
1361         * gdbsupport/format.c (format_pieces::format_pieces): Add
1362         gdb_extensions parameter.  Handle '*'.
1363         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1364         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1365         vfprintf_styled_no_gdbfmt.
1366         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1367         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1368         unfiltered output.
1369         * ui-style.h (struct ui_file_style) <ptr>: New method.
1370
1371 2019-10-01  Tom Tromey  <tom@tromey.com>
1372
1373         * unittests/format_pieces-selftests.c: Update.  Add final format.
1374         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1375         empty literal pieces.
1376
1377 2019-10-01  Tom Tromey  <tom@tromey.com>
1378
1379         * ui-out.h (enum class ui_out_style_kind): Remove.
1380         (class ui_out) <field_string, field_stsream, do_field_string>:
1381         Change type of "style".
1382         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1383         (ui_out::field_string): Update.
1384         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1385         of "style".
1386         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1387         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1388         * stack.c (print_frame_arg, print_frame_info, print_frame):
1389         Update.
1390         * source.c (print_source_lines_base): Update.
1391         * solib.c (info_sharedlibrary_command): Update.
1392         * skip.c (info_skip_command): Update.
1393         * record-btrace.c (btrace_call_history_src_line)
1394         (btrace_call_history): Update.
1395         * python/py-framefilter.c (py_print_frame): Update.
1396         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1397         "style".
1398         * mi/mi-out.c (mi_ui_out::do_table_header)
1399         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1400         (mi_ui_out::do_field_string): Update.
1401         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1402         Update.
1403         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1404         "style".
1405         * cli-out.c (cli_ui_out::do_table_header)
1406         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1407         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1408         (cli_ui_out::do_field_fmt): Update.
1409         * breakpoint.c (print_breakpoint_location): Update.
1410         (update_static_tracepoint): Update.
1411
1412 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1413
1414         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1415         conversion of gdb_datadir.
1416         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1417         remove not needed c_str ().
1418
1419 2019-09-30  Ali Tamur <tamur@google.com>
1420
1421         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1422         (dwarf2_string_attr): Likewise.
1423
1424 2019-09-30  Ali Tamur <tamur@google.com>
1425
1426         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1427         (process_full_type_unit): Likewise.
1428         (dump_die_shallow): Likewise.
1429         (cu_debug_loc_section): Likewise.
1430
1431 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1432
1433         * minsyms.c (compare_minimal_symbols): Rename to...
1434         (minimal_symbol_is_less_than): ...this, and adjust to STL
1435         conventions (return bool, take arguments as references)
1436         (minimal_symbol_reader::install): Call std::sort instead
1437         of qsort.
1438
1439 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1440
1441         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1442         hash and why.
1443         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1444         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1445
1446 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1447
1448         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1449         * psympriv.h (add_psymbol_to_list): Move comment here and update
1450         it.
1451
1452 2019-09-29  Tom de Vries  <tdevries@suse.de>
1453
1454         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1455         Use $tmpdir/$(basename "$output_file").dwz instead of
1456         "${output_file}.dwz".
1457
1458 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1459
1460         PR gdb/25045
1461         * hppa-linux-nat.c: Include gdbarch.h.
1462
1463 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1464
1465         * blockframe.c (find_pc_partial_function): Change return type to bool.
1466         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1467         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1468         (stub_gnu_ifunc_resolve_name): Likewise.
1469         * symtab.c (compare_filenames_for_search): Likewise.
1470         (compare_glob_filenames_for_search): Likewise.
1471         (matching_obj_sections): Likewise.
1472         (symbol_matches_domain): Likewise.
1473         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1474         (find_line_pc): Change return type to bool.
1475         (find_line_pc_range): Likewise.
1476         (producer_is_realview): Likewise.
1477         * symtab.h (symbol_matches_domain): Likewise.
1478         (find_pc_partial_function): Likewise.
1479         (find_pc_line_pc_range): Likewise.
1480         (in_gnu_ifunc_stub): Likewise.
1481         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1482         (find_line_pc): Likewise.
1483         (find_line_pc_range): Likewise.
1484         (matching_obj_sections): Likewise.
1485         (find_line_symtab): Change out parameter to bool.
1486         (producer_is_realview): Change return type to bool.
1487         (compare_filenames_for_search): Likewise.
1488         (compare_glob_filenames_for_search): Likewise.
1489
1490 2019-09-26  Tom Tromey  <tom@tromey.com>
1491
1492         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1493         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1494         * gdb_usleep.h: Remove.
1495         * gdb_usleep.c: Remove.
1496         * utils.c: Don't include gdb_usleep.h.
1497
1498 2019-09-26  Tom Tromey  <tromey@adacore.com>
1499
1500         * python/py-type.c (type_to_type_object): Call check_typedef
1501         for stub types.
1502
1503 2019-09-26  Tom Tromey  <tom@tromey.com>
1504
1505         * utils.h (initialize_utils): Don't declare.
1506         * top.c (gdb_init): Don't call initialize_utils.
1507         * utils.c (initialize_utils): Remove.  Move contents...
1508         (_initialize_utils): ... here.
1509
1510 2019-09-25  Tom Tromey  <tom@tromey.com>
1511
1512         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1513         * utils.h (make_hex_string): Don't declare.
1514         * utils.c (make_hex_string): Remove.
1515
1516 2019-09-24  Tom de Vries  <tdevries@suse.de>
1517
1518         PR gdb/23815
1519         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1520         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1521
1522 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1523
1524         * NEWS: Mention new simulator port for PRU.
1525
1526 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1527
1528         * ada-exp.y (write_object_remaining): Update.
1529         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1530         and eliminate the static buffer.
1531         (ada_decode_symbol): Update.
1532         (ada_la_decode): Update.
1533         (ada_sniff_from_mangled_name): Update.
1534         (is_valid_name_for_wild_match): Update.
1535         (ada_lookup_name_info::matches): Update and simplify.
1536         (name_matches_regex): Update.
1537         (ada_add_global_exceptions): Update.
1538         * ada-lang.h (ada_decode): Update signature.
1539         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1540         * dwarf-index-write.c (debug_names::insert): Update.
1541
1542 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1543
1544         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1545         formatting.
1546
1547 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1548
1549         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1550         Change "nonzero" to "true" in documentation.
1551
1552 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1553
1554         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1555         (_initialize_darwin_solib): Don't set
1556         darwin_so_ops.lookup_lib_global_symbol.
1557         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1558         set_gdbarch_iterate_over_objfiles_in_search_order.
1559         (elf_lookup_lib_symbol): Rename to...
1560         (svr4_iterate_over_objfiles_in_search_order): this, and update
1561         to iterate semantics.
1562         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1563         * solib.c (solib_global_lookup): Remove.
1564         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1565         (solib_global_lookup): Remove.
1566         * symtab.c (lookup_global_or_static_symbol): Remove call to
1567         solib_global_lookup.
1568
1569 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1570
1571         * NEWS: Move entries about default MI version now being
1572         version 3, and about the GDB/MI fix for multi-location
1573         breakpoints to the "since GDB 8.3" section.
1574
1575 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1576
1577         GDB 8.3.1 released.
1578
1579 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1580
1581         * NEWS: Mention that Cell/B.E. debugging support was removed.
1582         * MAINTAINERS: Remove spu target.
1583
1584         * config/djgpp/fnchange.lst: Remove entries for removed files.
1585
1586         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1587         spu-multiarch.o, and spu-tdep.o.
1588         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1589         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1590         spu-multiarch.c, and spu-tdep.c.
1591         * spu-linux-nat.c: Remove file.
1592         * spu-multiarch.c: Remove file.
1593         * spu-tdep.c: Remove file.
1594         * spu-tdep.h: Remove file.
1595         * solib-spu.c: Remove file.
1596         * solib-spu.h: Remove file.
1597
1598         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1599         * configure.nat (spu-linux): Remove.
1600         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1601         solib-multiarch.o from gdb_target_obs.
1602         (spu*-*-*): Remove.
1603
1604         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1605         feature flag.
1606         (ppc_linux_no_features): Update.
1607         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1608         Cell/B.E. support.
1609         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1610         (tdesc_powerpc_cell64l): Likewise.
1611         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1612         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1613         Cell/B.E. support.
1614         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1615         Do not include "features/rs6000/powerpc-cell32l.c" or
1616         "features/rs6000/powerpc-cell64l.c".
1617         (ppc_linux_spu_section): Remove.
1618         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1619         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1620         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1621         (ppc_linux_spe_context_lookup): Remove.
1622         (ppc_linux_spe_context_inferior_created): Remove.
1623         (ppc_linux_spe_context_solib_loaded): Remove.
1624         (ppc_linux_spe_context_solib_unloaded): Remove.
1625         (ppc_linux_spe_context): Remove.
1626         (struct ppu2spu_cache): Remove.
1627         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1628         (struct ppu2spu_data): Remove.
1629         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1630         ppu2spu_unwind): Remove.
1631         (ppc_linux_init_abi): Remove Cell/B.E. support.
1632         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1633
1634         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1635         (rs6000/powerpc-cell64l-expedite): Likewise
1636         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1637         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1638         rs6000/powerpc-cell64l.xml.
1639         * features/rs6000/powerpc-cell32l.xml: Remove.
1640         * features/rs6000/powerpc-cell64l.xml: Likewise.
1641         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1642         * features/rs6000/powerpc-cell64l.c: Likewise.
1643         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1644         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1645         * regformats/reg-spu.dat: Remove.
1646
1647         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1648         * corelow.c (struct spuid_list): Remove.
1649         (add_to_spuid_list): Remove.
1650         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1651         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1652         (remote_protocol_features): Remove associated entries.
1653         (_initialize_remote): No longer initialize them.
1654         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1655         * linux-nat.c (SPUFS_MAGIC): Remove.
1656         (linux_proc_xfer_spu): Remove.
1657         (spu_enumerate_spu_ids): Remove.
1658         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1659         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1660         (linux_make_corefile_notes): No longer call it.
1661
1662         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1663         (cooked_write_test): Likewise.
1664
1665 2019-09-20  Tom Tromey  <tom@tromey.com>
1666
1667         * NEWS: Mention case-sensitivity of TUI commands.
1668         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1669         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1670         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1671
1672 2019-09-20  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-source.c (tui_source_window::set_contents): Use
1675         make_unique_xstrdup.
1676         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1677         make_unique_xstrdup.
1678
1679 2019-09-20  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-data.c: Remove separator comments.
1682         * tui/tui-layout.c: Remove separator comments.
1683         * tui/tui-win.c: Remove separator comments.
1684         * tui/tui-wingeneral.c: Remove separator comments.
1685
1686 2019-09-20  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui.h (strcat_to_buf): Don't declare.
1689         * tui/tui.c (strcat_to_buf): Remove.
1690
1691 2019-09-20  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1694         from "fullname".
1695         * tui/tui-source.c (tui_source_window::set_contents)
1696         (tui_source_window::location_matches_p)
1697         (tui_source_window::maybe_update): Update.
1698
1699 2019-09-20  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1702         Update.
1703         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1704         prefix.
1705         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1706         (tui_data_window::line_from_reg_element_no)
1707         (tui_data_window::first_reg_element_no_inline)
1708         (tui_data_window::show_registers)
1709         (tui_data_window::show_register_group)
1710         (tui_data_window::display_registers_from)
1711         (tui_data_window::display_registers_from_line)
1712         (tui_data_window::first_data_item_displayed)
1713         (tui_data_window::delete_data_content_windows)
1714         (tui_data_window::erase_data_content)
1715         (tui_data_window::do_scroll_vertical)
1716         (tui_data_window::refresh_window)
1717         (tui_data_window::check_register_values): Update.
1718
1719 2019-09-20  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1722         (struct tui_locator_window) <full_name, proc_name>: Now
1723         std::string.
1724         * tui/tui-stack.c (tui_locator_window::make_status_line)
1725         (tui_locator_window::set_locator_fullname)
1726         (tui_locator_window::set_locator_info): Update.
1727         * tui/tui-source.c (tui_source_window::set_contents)
1728         (tui_source_window::showing_source_p): Update.
1729
1730 2019-09-20  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1733         Don't call tui_locator_win_info_ptr.
1734
1735 2019-09-20  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1738
1739 2019-09-20  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1742         height for locator.
1743         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1744         * tui/tui-layout.c (show_source_disasm_command, show_data)
1745         (show_source_or_disasm_and_command): Use 1 as height for locator.
1746
1747 2019-09-20  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui.c (tui_enable): Update.
1750         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1751         Update.
1752         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1753         Update.
1754         * tui/tui-data.c (win_resized): Now bool.
1755         (tui_win_resized): Return bool.
1756         (tui_set_win_resized_to): Accept a bool.
1757
1758 2019-09-20  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1761         Change type of "refresh_values_only".
1762         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1763         type of "refresh_values_only".
1764
1765 2019-09-20  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1768         std::string.
1769         (tui_disassemble): Add "pos" parameter.
1770         (tui_disasm_window::set_contents): Simplify.
1771
1772 2019-09-20  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-winsource.h (struct tui_source_window_base)
1775         <show_source_content>: Now private.
1776         * tui/tui-winsource.c
1777         (tui_source_window_base::show_source_content): Don't handle empty
1778         content case.
1779
1780 2019-09-20  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-layout.c (show_source_disasm_command)
1783         (show_source_or_disasm_and_command): Don't call
1784         show_source_content.
1785
1786 2019-09-20  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1789         Declare.
1790         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1791         from tui_make_status_line.
1792         (tui_locator_window::rerender): Update.
1793
1794 2019-09-20  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1797         (tui_locator_window::rerender): Update.
1798
1799 2019-09-20  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.h (struct tui_source_window_base)
1802         <~tui_source_window_base>: Don't declare.
1803         <fullname>: Remove.
1804         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1805         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1806         member.
1807         * tui/tui-source.c (tui_source_window::set_contents): Update.
1808         (tui_source_window::location_matches_p)
1809         (tui_source_window::maybe_update): Update.
1810
1811 2019-09-20  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-winsource.h (~tui_source_element): Remove.
1814         (tui_source_element): Update.
1815         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1816         * tui/tui-winsource.c (tui_show_source_line): Update.
1817         * tui/tui-source.c (tui_source_window::set_contents): Update.
1818         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1819
1820 2019-09-20  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1823         declare.
1824         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1825         tui_clear_source_windows_detail.
1826         * tui/tui-winsource.h (struct tui_source_window_base)
1827         <clear_detail>: Don't declare.
1828         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1829         Remove.
1830         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1831
1832 2019-09-20  Tom Tromey  <tromey@adacore.com>
1833
1834         PR ada/24919:
1835         * block.c (contained_in): Fix final return value.
1836
1837 2019-09-20  Alan Modra  <amodra@gmail.com>
1838
1839         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1840         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1841         (read_indirect_string_from_dwz): Use bfd accessor.
1842         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1843         * machoread.c (macho_symfile_read_all_oso): Likewise.
1844         * solib.c (solib_bfd_open): Likewise.
1845
1846 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1847
1848         * eval.c: Move declaration of overload_resolution to...
1849         * value.h: ...here.
1850
1851 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1852
1853         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1854         * arm-linux-tdep.c: Likewise.
1855         * arm-nbsd-nat.c: Likewise.
1856         * arm-tdep.h: Declare arm_apcs_32.
1857         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1858
1859 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1860
1861         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1862         * dwarf2read.h: Declare dwarf_always_disassemble.
1863
1864 2019-09-19  Tom de Vries  <tdevries@suse.de>
1865
1866         PR gdb/25009
1867         * source-cache.c (source_cache::ensure): Catch exception thrown during
1868         construction of the highlighter.
1869
1870 2019-09-18  Alan Modra  <amodra@gmail.com>
1871
1872         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1873         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1874         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1875         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1876         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1877         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1878         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1879         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1880         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1881         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1882         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1883         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1884         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1885         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1886         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1887         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1888         * mi/mi-interp.c: Update throughout for bfd section macro and
1889         function changes.
1890         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1891         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1892
1893 2019-09-18  Tom Tromey  <tom@tromey.com>
1894
1895         * NEWS: Add entry.
1896         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1897         call rl_initialize.
1898         (tui_enable): Do not call rl_initialize.
1899
1900 2019-09-18  Christian Groessler  <chris@groessler.org>
1901
1902         * alpha-linux-nat.c: Include gdbarch.h.
1903
1904 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1905
1906         * ui-file.c: Include cli/cli-style.h.
1907         (term_cli_styling): Remove cli_styling declaration.
1908
1909 2019-09-18  Alan Modra  <amodra@gmail.com>
1910
1911         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1912         to bfd_asymbol_section.
1913
1914 2019-09-18  Alan Modra  <amodra@gmail.com>
1915
1916         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1917         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1918         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1919
1920 2019-09-18  Alan Modra  <amodra@gmail.com>
1921
1922         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1923         * spu-linux-nat.c (spu_bfd_open): Likewise.
1924
1925 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1926
1927         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1928         to bool to match definition in dwarf2read.c.
1929
1930 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1931
1932         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1933         (print_signatures): Likewise.
1934         (trust_pad_over_xvs): Likewise.
1935         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1936         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1937         * arm-linux-nat.c (arm_apcs_32): Likewise.
1938         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1939         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1940         * arm-tdep.c (arm_debug): Likewise.
1941         (arm_apcs_32): Likewise.
1942         * auto-load.c (debug_auto_load): Likewise.
1943         (auto_load_gdb_scripts): Likewise.
1944         (global_auto_load): Likewise.
1945         (auto_load_local_gdbinit): Likewise.
1946         (auto_load_local_gdbinit_loaded): Likewise.
1947         * auto-load.h (global_auto_load): Likewise.
1948         (auto_load_local_gdbinit): Likewise.
1949         (auto_load_local_gdbinit_loaded): Likewise.
1950         * breakpoint.c (disconnected_dprintf): Likewise.
1951         (breakpoint_proceeded): Likewise.
1952         (automatic_hardware_breakpoints): Likewise.
1953         (always_inserted_mode): Likewise.
1954         (target_exact_watchpoints): Likewise.
1955         (_initialize_breakpoint): Update.
1956         * breakpoint.h (target_exact_watchpoints): Change to bool.
1957         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1958         * cli/cli-cmds.c (trace_commands): Likewise.
1959         * cli/cli-cmds.h (trace_commands): Likewise.
1960         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1961         to bool*.
1962         * cli/cli-logging.c (logging_overwrite): Change to bool.
1963         (logging_redirect): Likewise.
1964         (debug_redirect): Likewise.
1965         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1966         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1967         to bool.
1968         <boolean_option_def>: Update.
1969         (struct flag_option_def): Change default type of Context to bool
1970         from int.
1971         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1972         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1973         (get_setshow_command_value_string): Likewise.
1974         * cli/cli-style.c (cli_styling): Change to bool.
1975         (source_styling): Likewise.
1976         * cli/cli-style.h (source_styling): Likewise.
1977         (cli_styling): Likewise.
1978         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1979         to bool.
1980         * command.h (var_types): Update comment.
1981         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1982         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1983         bool.
1984         (debug_compile_cplus_scopes): Likewise.
1985         * compile/compile-internal.h (compile_debug): Likewise.
1986         * compile/compile.c (compile_debug): Likewise.
1987         (struct compile_options) <raw>: Likewise.
1988         * cp-support.c (catch_demangler_crashes): Likewise.
1989         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1990         (usr_cmd_cris_dwarf2_cfi): Likewise.
1991         * csky-tdep.c (csky_debug): Likewise.
1992         * darwin-nat.c (enable_mach_exceptions): Likewise.
1993         * dcache.c (dcache_enabled_p): Likewise.
1994         * defs.h (info_verbose): Likewise.
1995         * demangle.c (demangle): Likewise.
1996         (asm_demangle): Likewise.
1997         * dwarf-index-cache.c (debug_index_cache): Likewise.
1998         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1999         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2000         * dwarf2read.c (check_physname): Likewise.
2001         (use_deprecated_index_sections): Likewise.
2002         (dwarf_always_disassemble): Likewise.
2003         * eval.c (overload_resolution): Likewise.
2004         * event-top.c (set_editing_cmd_var): Likewise.
2005         (exec_done_display_p): Likewise.
2006         * event-top.h (set_editing_cmd_var): Likewise.
2007         (exec_done_display_p): Likewise.
2008         * exec.c (write_files): Likewise.
2009         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2010         (debug_fbsd_nat): Likewise.
2011         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2012         Likewise.
2013         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2014         <backtrace_past_entry> Likewise.
2015         * gdb-demangle.h (demangle): Likewise.
2016         (asm_demangle): Likewise.
2017         * gdb_bfd.c (bfd_sharing): Likewise.
2018         * gdbcore.h (write_files): Likewise.
2019         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2020         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2021         * gdbthread.h (print_thread_events): Likewise.
2022         * gdbtypes.c (opaque_type_resolution): Likewise.
2023         (strict_type_checking): Likewise.
2024         * gnu-nat.c (gnu_debug_flag): Likewise.
2025         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2026         * guile/scm-param.c (pascm_variable): Add boolval.
2027         (add_setshow_generic): Update.
2028         (pascm_param_value): Update.
2029         (pascm_set_param_value_x): Update.
2030         * hppa-tdep.c (hppa_debug): Change to bool..
2031         * infcall.c (may_call_functions_p): Likewise.
2032         (coerce_float_to_double_p): Likewise.
2033         (unwind_on_signal_p): Likewise.
2034         (unwind_on_terminating_exception_p): Likewise.
2035         * infcmd.c (startup_with_shell): Likewise.
2036         * inferior.c (print_inferior_events): Likewise.
2037         * inferior.h (startup_with_shell): Likewise.
2038         (print_inferior_events): Likewise.
2039         * infrun.c (step_stop_if_no_debug): Likewise.
2040         (detach_fork): Likewise.
2041         (debug_displaced): Likewise.
2042         (disable_randomization): Likewise.
2043         (non_stop): Likewise.
2044         (non_stop_1): Likewise.
2045         (observer_mode): Likewise.
2046         (observer_mode_1): Likewise.
2047         (set_observer_mode): Update.
2048         (sched_multi): Change to bool.
2049         * infrun.h (debug_displaced): Likewise.
2050         (sched_multi): Likewise.
2051         (step_stop_if_no_debug): Likewise.
2052         (non_stop): Likewise.
2053         (disable_randomization): Likewise.
2054         * linux-tdep.c (use_coredump_filter): Likewise.
2055         (dump_excluded_mappings): Likewise.
2056         * linux-thread-db.c (auto_load_thread_db): Likewise.
2057         (check_thread_db_on_load): Likewise.
2058         * main.c (captured_main_1): Update.
2059         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2060         xx2_opt, boolean_opt>: Change to bool.
2061         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2062         * maint.c (maintenance_profile_p): Likewise.
2063         (per_command_time): Likewise.
2064         (per_command_space): Likewise.
2065         (per_command_symtab): Likewise.
2066         * memattr.c (inaccessible_by_default): Likewise.
2067         * mi/mi-main.c (mi_async): Likewise.
2068         (mi_async_1): Likewise.
2069         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2070         * nat/fork-inferior.h (startup_with_shell): Likewise.
2071         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2072         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2073         * nios2-tdep.c (nios2_debug): Likewise.
2074         * or1k-tdep.c (or1k_debug): Likewise.
2075         * parse.c (parser_debug): Likewise.
2076         * parser-defs.h (parser_debug): Likewise.
2077         * printcmd.c (print_symbol_filename): Likewise.
2078         * proc-api.c (procfs_trace): Likewise.
2079         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2080         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2081         (set_parameter_value): Update.
2082         (add_setshow_generic): Update.
2083         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2084         to bool*.
2085         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2086         int*.
2087         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2088         * record-btrace.c (record_btrace_target::store_registers): Update.
2089         * record-full.c (record_full_memory_query): Change to bool.
2090         (record_full_stop_at_limit): Likewise.
2091         * record-full.h (record_full_memory_query): Likewise.
2092         * remote-notif.c (notif_debug): Likewise.
2093         * remote-notif.h (notif_debug): Likewise.
2094         * remote.c (use_range_stepping): Likewise.
2095         (interrupt_on_connect): Likewise.
2096         (remote_break): Likewise.
2097         * ser-tcp.c (tcp_auto_retry): Likewise.
2098         * ser-unix.c (serial_hwflow): Likewise.
2099         * skip.c (debug_skip): Likewise.
2100         * solib-aix.c (solib_aix_debug): Likewise.
2101         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2102         (spu_auto_flush_cache_p): Likewise.
2103         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2104         Likewise.
2105         (struct info_print_options) <quiet>: Likewise.
2106         * symfile-debug.c (debug_symfile): Likewise.
2107         * symfile.c (auto_solib_add): Likewise.
2108         (separate_debug_file_debug): Likewise.
2109         * symfile.h (auto_solib_add): Likewise.
2110         (separate_debug_file_debug): Likewise.
2111         * symtab.c (basenames_may_differ): Likewise.
2112         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2113         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2114         (struct info_types_options) <quiet>: Likewise.
2115         * symtab.h (demangle): Likewise.
2116         (basenames_may_differ): Likewise.
2117         * target-dcache.c (stack_cache_enabled_1): Likewise.
2118         (code_cache_enabled_1): Likewise.
2119         * target.c (trust_readonly): Likewise.
2120         (may_write_registers): Likewise.
2121         (may_write_memory): Likewise.
2122         (may_insert_breakpoints): Likewise.
2123         (may_insert_tracepoints): Likewise.
2124         (may_insert_fast_tracepoints): Likewise.
2125         (may_stop): Likewise.
2126         (auto_connect_native_target): Likewise.
2127         (target_stop_and_wait): Update.
2128         (target_async_permitted): Change to bool.
2129         (target_async_permitted_1): Likewise.
2130         (may_write_registers_1): Likewise.
2131         (may_write_memory_1): Likewise.
2132         (may_insert_breakpoints_1): Likewise.
2133         (may_insert_tracepoints_1): Likewise.
2134         (may_insert_fast_tracepoints_1): Likewise.
2135         (may_stop_1): Likewise.
2136         * target.h (target_async_permitted): Likewise.
2137         (may_write_registers): Likewise.
2138         (may_write_memory): Likewise.
2139         (may_insert_breakpoints): Likewise.
2140         (may_insert_tracepoints): Likewise.
2141         (may_insert_fast_tracepoints): Likewise.
2142         (may_stop): Likewise.
2143         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2144         (make_thread_apply_all_options_def_group): Change argument from int*
2145         to bool*.
2146         (thread_apply_all_command): Update.
2147         (print_thread_events): Change to bool.
2148         * top.c (confirm): Likewise.
2149         (command_editing_p): Likewise.
2150         (history_expansion_p): Likewise.
2151         (write_history_p): Likewise.
2152         (info_verbose): Likewise.
2153         * top.h (confirm): Likewise.
2154         (history_expansion_p): Likewise.
2155         * tracepoint.c (disconnected_tracing): Likewise.
2156         (circular_trace_buffer): Likewise.
2157         * typeprint.c (print_methods): Likewise.
2158         (print_typedefs): Likewise.
2159         * utils.c (debug_timestamp): Likewise.
2160         (sevenbit_strings): Likewise.
2161         (pagination_enabled): Likewise.
2162         * utils.h (sevenbit_strings): Likewise.
2163         (pagination_enabled): Likewise.
2164         * valops.c (overload_resolution): Likewise.
2165         * valprint.h (struct value_print_options) <prettyformat_arrays,
2166         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2167         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2168         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2169         Likewise.
2170         * windows-nat.c (new_console): Likewise.
2171         (cygwin_exceptions): Likewise.
2172         (new_group): Likewise.
2173         (debug_exec): Likewise.
2174         (debug_events): Likewise.
2175         (debug_memory): Likewise.
2176         (debug_exceptions): Likewise.
2177         (useshell): Likewise.
2178         * windows-tdep.c (maint_display_all_tib): Likewise.
2179         * xml-support.c (debug_xml): Likewise.
2180
2181 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2182
2183         * source.c (prepare_path_for_appending): New function.
2184         (openp): Make use of new function.
2185         (find_and_open_source): Search for the compilation directory and
2186         source file as a relative path beneath the directory search path.
2187
2188 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * source-cache.c (source_cache::get_line_charpos): Catch
2191         exceptions and return false, this matches the behaviour documented
2192         in the header file.
2193
2194 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2195
2196         * ada-tasks.c (info_task): Remove quoting of the task's name.
2197
2198 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2199
2200         * symfile.c (auto_solib_add): Replace comment with a reference
2201         to the header file.
2202
2203 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2204
2205         * NEWS: Mention that gdb can now be compiled with Python 3
2206         on Windows.
2207
2208 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * maint.c (maint_print_section_data::maint_print_section_data):
2211         Force use of 'float log10 (float)' by casting the argument to
2212         float.
2213
2214 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * maint.c: Add 'cmath' include.
2217         (struct maint_print_section_data): New structure.
2218         (print_section_index): New function.
2219         (print_bfd_section_info): Add header comment, small whitespace
2220         cleanup, and update to call new print_section_index function.
2221         (print_objfile_section_info): Likewise.
2222         (maint_obj_section_from_bfd_section): New function.
2223         (print_bfd_section_info_maybe_relocated): New function.
2224         (maintenance_info_sections): Add header comment, always use
2225         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2226
2227 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2228
2229         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2230         inner scope, add check that the objfile has psymtabs before
2231         checking psymtabs_addrmap.
2232         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2233
2234 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2235
2236         * NEWS: Announce that Ada task names are now shown at more places,
2237         and between quotes (except in info task output).
2238         * gdb/ada-tasks.c (task_to_str): New function.
2239         (display_current_task_id): Call task_to_str.
2240         (task_command_1): Likewise.
2241         (print_ada_task_info): In non-mi mode, Properly align headers and data
2242         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2243
2244 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2245
2246         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2247         prstatus.pr_lwp.pr_info instead of making it up.
2248
2249 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2250
2251         * auto-load.c (auto_load_expand_dir_vars): Update.
2252         * defs.h (gdb_datadir): Change to std::string.
2253         (python_libdir): Likewise.
2254         (relocate_gdb_directory): Change return type to std::string.
2255         * guile/guile.c (gdbscm_data_directory): Update.
2256         (initialize_scheme_side): Update.
2257         * jit.c (jit_reader_dir): Change to std::string.
2258         (jit_reader_load_command): Update.
2259         * main.c (gdb_datadir): Change to std::string.
2260         (python_libdir): Likewise.
2261         (set_gdb_data_directory): Update.
2262         (relocate_path): Change to return std::string.
2263         (relocate_gdb_directory): Change to return std::string.
2264         (relocate_gdbinit_path_maybe_in_datadir): Update.
2265         (captured_main_1): Update.
2266         * python/python.c (do_start_initialization): Update.
2267         * top.c (show_gdb_datadir): Update.
2268         * xml-syscall.c (xml_init_syscalls_info): Update.
2269         (init_syscalls_info): Update.
2270
2271 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2272
2273         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2274         out of get_init_files.
2275         (get_init_files): Update.
2276
2277 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2278
2279         * main.c (get_init_files): Change to use std::string.
2280         (captured_main_1): Update.
2281         (print_gdb_help): Update.
2282
2283 2019-09-11  Ali Tamur  <tamur@google.com>
2284
2285         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2286         implementation.
2287
2288 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2289
2290         * dbxread.c (read_dbx_symtab): Update.
2291         * dwarf2read.c (load_partial_dies): Update.
2292         * mdebugread.c (parse_partial_symbols): Update.
2293         (handle_psymbol_enumerators): Update.
2294         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2295         * psymtab.c (add_psymbol_to_bcache): Likewise.
2296         (add_psymbol_to_list): Likewise.
2297         * symtab.c (symbol_set_names): Likewise.
2298         * symtab.h (symbol_set_names): Likewise.
2299         * xcoffread.c (scan_xcoff_symtab): Update.
2300
2301 2019-09-11  Tom Tromey  <tom@tromey.com>
2302
2303         * symfile-mem.c (symbol_file_add_from_memory): Use
2304         bfd_set_filename.
2305         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2306         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2307
2308 2019-09-10  Tom Tromey  <tromey@adacore.com>
2309
2310         * dwarf-index-write.c (write_psymbols): Extend error message.
2311         (debug_names::insert): Add Ada code.
2312         (debug_names::write_psymbols): Remove Ada check.
2313         (debug_names) <m_string_obstack>: New member.
2314         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2315         (gdb_index_symbol_name_matcher::matches): Remove.
2316         (mapped_index_base::find_name_components_bounds): Add "lang"
2317         parameter.
2318         (mapped_index_base::build_name_components): Also split names
2319         according to Ada syntax.
2320         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2321         type of "match_callback".
2322         (check_match, check_find_bounds_finds)
2323         (dw2_expand_symtabs_matching): Update.
2324         (dw2_debug_names_iterator): Add new constructor.
2325         (dw2_debug_names_map_matching_symbols): New function.
2326         (dw2_debug_names_expand_symtabs_matching): Update.
2327         (dwarf2_debug_names_functions): Use
2328         dw2_debug_names_map_matching_symbols.
2329
2330 2019-09-10  Tom Tromey  <tromey@adacore.com>
2331
2332         * dwarf2read.c (dw2_get_file_names_reader): Add the
2333         CU's file name to the results.
2334
2335 2019-09-10  Tom Tromey  <tromey@adacore.com>
2336
2337         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2338         map_matching_symbols.  Update.
2339         * dwarf2read.c (dw2_map_matching_symbols): Update.
2340         * psymtab.c (match_partial_symbol): Change type; update.
2341         (psym_map_matching_symbols): Likewise.
2342         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2343         type; update.
2344         * symfile.h (struct quick_symbol_functions)
2345         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2346         Remove "match".
2347
2348 2019-09-10  Tom Tromey  <tromey@adacore.com>
2349
2350         * psymtab.c (map_block): Remove.
2351         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2352         * symtab.c (iterate_over_symbols_terminated): New function.
2353         * symtab.c (iterate_over_symbols_terminated): Declare.
2354
2355 2019-09-10  Tom Tromey  <tromey@adacore.com>
2356
2357         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2358         * language.h (struct language_defn) <la_iterate_over_symbols>:
2359         Return bool.
2360         * symtab.c (iterate_over_symbols): Return bool.
2361         * symtab.h (iterate_over_symbols): Return bool.
2362
2363 2019-09-10  Tom Tromey  <tromey@adacore.com>
2364
2365         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2366         (add_nonlocal_symbols): Update.
2367         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2368         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2369         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2370         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2371         Change type of "callback".  Remove "data".
2372
2373
2374 2019-09-09  Ali Tamur  <tamur@google.com>
2375
2376         * dwarf2read.c (comp_unit_head): Update comment.
2377         (dwarf2_dwo_name): New function declaration.
2378         (dwarf_unit_type_name): New function declaration.
2379         (read_comp_unit_head): Add support for new compilation units,
2380         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2381         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2382         (currently named as "signature") in their header. Also clarify error
2383         messages.
2384         (lookup_dwo_id): New function. Returns the dwo id of the given
2385         compile unit.
2386         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2387         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2388         functions.
2389         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2390         (dwarf2_dwo_name): Get the dwo name if present.
2391         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2392         purposes.
2393
2394 2019-09-09  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2397
2398 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2399
2400         * python/python.c (do_start_initialization): Make progname_copy static,
2401         to avoid a leak report.
2402
2403 2019-09-08  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2406
2407 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2408
2409         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2410         Change type to gdb::optional<block_enum>.
2411         (dw2_symtab_iter_init): Change block_index parameter type
2412         to gdb::optional<block_enum>.
2413         (dw2_lookup_symbol): Change block_index parameter
2414         type to block_enum.c
2415         (dw2_debug_names_lookup_symbol): Likewise.
2416         * psymtab.c (psym_lookup_symbol): Likewise.
2417         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2418         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2419         Likewise.
2420
2421 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2422
2423         * defs.h (relocate_gdb_directory): Change int to bool in
2424         signature and rename flag to relocatable.
2425         * main.c (relocate_path): Likewise.
2426         (relocate_gdb_directory): Likewise.
2427
2428 2019-09-06  Alan Modra  <amodra@gmail.com>
2429
2430         * coffread.c (coff_symfile_read): Constify filename variable.
2431         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2432         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2433         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2434         * solib.c (reload_shared_libraries_1): Likewise.
2435         * symfile.c (reread_symbols): Likewise.
2436         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2437         * solib-darwin.c (darwin_bfd_open): Likewise.
2438         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2439
2440 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2441
2442         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2443         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2444
2445 2019-09-03  Tom Tromey  <tromey@adacore.com>
2446
2447         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2448         types.
2449         (has_negatives): Unbias a range type bound.
2450         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2451         * gdbtypes.c (operator==): Handle new field.
2452         (create_range_type): Add "bias" parameter.
2453         (create_static_range_type, resolve_dynamic_range): Update.
2454         * gdbtypes.h (struct range_bounds) <bias>: New member.
2455         (create_range_type): Add bias parameter.
2456         * printcmd.c (print_scalar_formatted): Unbias range types.
2457         * value.c (unpack_long): Unbias range types.
2458         (pack_long): Bias range types.
2459
2460 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2461
2462         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2463         probe arguments.
2464
2465 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2466
2467         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2468         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2469         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2470         (compile_probe_arg): Likewise.
2471         * probe.h (get_argument_count): Likewise.
2472         * solib-svr4.c (solib_event_probe_action): Likewise.
2473         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2474
2475 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2476
2477         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2478         code to here...
2479         (svr4_create_solib_event_breakpoints): ...from here.
2480
2481 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2482
2483         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2484         suffix from warning message.
2485
2486 2019-08-30  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-winsource.h (struct tui_source_window_base)
2489         <refresh_all>: Don't declare.
2490         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2491         Remove.
2492         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2493         tui_show_locator_content.
2494         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2495         declare.
2496         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2497         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2498         declare.
2499
2500 2019-08-30  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2503
2504 2019-08-30  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2507         Remove unnecessary forward declarations.
2508
2509 2019-08-30  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2512         rerender.
2513         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2514         tui_show_locator_content.
2515
2516 2019-08-30  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2519         (tui_locator_window::rerender): Rewrite using body of previous
2520         tui_show_locator_content.
2521
2522 2019-08-30  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2525         set_locator_fullname>: New methods.
2526         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2527         Rename from tui_set_locator_fullname.
2528         (tui_locator_window::set_locator_info): Rename from
2529         tui_set_locator_info.  Return bool.
2530         (tui_update_locator_fullname, tui_show_frame_info): Update.
2531
2532 2019-08-30  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2535
2536 2019-08-30  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2539         call touchwin.
2540
2541 2019-08-30  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-wingeneral.c (box_win): Assume win_info and
2544         win_info->handle cannot be NULL.
2545
2546 2019-08-30  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2549         refresh_window>: Declare.
2550         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2551         resize.
2552         (tui_data_item_window::rerender): Rename from
2553         tui_display_register.
2554         (tui_data_item_window::refresh_window): New method.
2555         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2556         no-op.
2557
2558 2019-08-30  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2561         regs_column_count, current_group>: Move later.  Now private.
2562         <get_current_group>: New method.
2563         * tui/tui-regs.c (tui_reg_command): Update.
2564         * tui/tui-layout.c (tui_set_layout): Update.
2565
2566 2019-08-30  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2569         (tui_data_window::rerender): Don't call
2570         check_and_display_highlight_if_needed.
2571         (tui_data_window::refresh_all): Remove call to
2572         erase_data_content.
2573
2574 2019-08-30  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2577         (tui_data_window::display_registers_from)
2578         (tui_data_window::display_reg_element_at_line)
2579         (tui_data_window::display_registers_from_line): Remove checks of
2580         "empty".
2581
2582 2019-08-30  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2585         Don't declare.
2586         * tui/tui-regs.c (tui_data_window::show_registers): Call
2587         rerender.
2588         (tui_data_window::rerender): Rename from display_all_data.
2589         (tui_data_window::rerender): Remove old implementation.
2590
2591 2019-08-30  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2594         text.
2595         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2596
2597 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2598             Sergio Durigan Junior  <sergiodj@redhat.com>
2599
2600         PR win32/24284
2601         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2602
2603 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2604
2605         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2606         when searching for types.
2607
2608 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2609
2610         * f-lang.c (f_language_defn): Use f_print_typedef.
2611         * f-lang.h (f_print_typedef): Declare.
2612         * f-typeprint.c (f_print_typedef): Define.
2613
2614 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2615
2616         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2617
2618 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * cli/cli-utils.c (info_print_options_defs): Delete.
2621         (make_info_print_options_def_group): Delete.
2622         (extract_info_print_options): Delete.
2623         (info_print_command_completer): Delete.
2624         (info_print_args_help): Add extra parameter, and optionally
2625         include text about -n flag.
2626         * cli/cli-utils.h (struct info_print_options): Delete.
2627         (extract_info_print_options): Delete declaration.
2628         (info_print_command_completer): Delete declaration.
2629         (info_print_args_help): Add extra parameter, extend header
2630         comment.
2631         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2632         search_symbols.
2633         * stack.c (struct info_print_options): New type.
2634         (info_print_options_defs): New file scoped variable.
2635         (make_info_print_options_def_group): New static function.
2636         (info_print_command_completer): New static function.
2637         (info_locals_command): Update to use new local functions.
2638         (info_args_command): Likewise.
2639         (_initialize_stack): Add extra parameter to calls to
2640         info_print_args_help.
2641         * symtab.c (search_symbols): Add extra parameter, use this to
2642         possibly excluse non-debug symbols.
2643         (symtab_symbol_info): Add extra parameter, which is passed on to
2644         search_symbols.
2645         (struct info_print_options): New type.
2646         (info_print_options_defs): New file scoped variable.
2647         (make_info_print_options_def_group): New static function.
2648         (info_print_command_completer): New static function.
2649         (info_variables_command): Update to use local functions, and pass
2650         extra parameter through to symtab_symbol_info.
2651         (info_functions_command): Likewise.
2652         (info_types_command): Pass additional argument through to
2653         symtab_symbol_info.
2654         (rbreak_command): Pass extra argument to search_symbols.
2655         (_initialize_symtab): Add extra arguments for calls to
2656         info_print_args_help, and update help text for 'info variables',
2657         'whereis', and 'info functions' commands.
2658         * symtab.h (search_symbols): Add extra argument to declaration.
2659         * NEWS: Mention new flags.
2660
2661 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2662
2663         * symtab.c (lookup_static_symbol): Call the new function (and move
2664         it down to be next to lookup_global_symbol).
2665         (struct global_sym_lookup_data): Add block_enum member and rename to...
2666         (struct global_or_static_sym_lookup_data): ...this.
2667         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2668         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2669         (lookup_symbol_global_or_static_iterator_cb): ...this.
2670         (lookup_global_or_static_symbol): New function.
2671         (lookup_global_symbol): Call new function.
2672
2673 2019-08-26  Tom de Vries  <tdevries@suse.de>
2674
2675         PR c++/24852
2676         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2677         when pc_probe.prob == NULL.
2678
2679 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2680
2681         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2682         variable symbol_linkage to symbol_linkage_.
2683
2684 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2685
2686         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2687         represent whether the symbol is static, dynamic, or we don't
2688         know.
2689
2690 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2691
2692         * gdb/rx-tdep.c (rx_register_names): New.
2693         (rx_register_name): Delete.
2694         (rx_psw_type): Delete.
2695         (rx_fpsw_type): Delete.
2696         (rx_register_type): Delete.
2697         (rx_gdbarch_init): Convert target-descriptions.
2698         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2699         * gdb/features/Makefile: Add rx.xml.
2700         * gdb/features/rx.xml: New.
2701         * gdb/features/rx.c: Generated.
2702         * gdb/NEWS: Mention target description support.
2703
2704 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2705
2706         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2707         *slot_ptr.
2708
2709 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2710
2711         * configure.ac: Don't check for 'dlfcn.h' (moved to
2712         gdbsupport/common.m4).
2713         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2714         'gdbsupport/'.
2715         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2716         * compile/compile-c-support.c: Include
2717         'gdbsupport/gdb-dlfcn.h'.
2718         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2719         * gdb-dlfcn.c: Move to...
2720         * gdbsupport/gdb-dlfcn.c: ... here.
2721         * gdb-dlfcn.h: Move to...
2722         * gdbsupport/gdb-dlfcn.h: ... here.
2723
2724 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2725
2726         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2727         the offset field signed.
2728
2729 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2730
2731         * python/lib/gdb/__init__.py (_execute_file): New function.
2732         * python/python.c (python_run_simple_file): Call gdb._execute_file
2733         on Windows.
2734
2735 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2736
2737         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2738         all uses as this was never set to anything but a zero value.
2739
2740 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2741
2742         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2743
2744 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2745
2746         * tui/tui-data.h (tui_gen_win_info): Add an =default
2747         move constructor, required by some GCC versions.
2748
2749 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2750
2751         * go32-nat.c (go32_sysinfo): Add hygon_p.
2752
2753 2019-08-20  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2756         line_from_reg_element_no, first_reg_element_no_inline,
2757         display_all_data, delete_data_content_windows,
2758         erase_data_content>: Now private.
2759
2760 2019-08-20  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2763         (tui_unhighlight_win, tui_highlight_win)
2764         (tui_win_info::make_window): Update.
2765         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2766
2767 2019-08-20  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2770         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2771         (MAX_PID_WIDTH): Move to tui-stack.c.
2772         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2773         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2774         (MAX_PID_WIDTH): Move from tui-data.h.
2775
2776 2019-08-20  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2779         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2780         (box_win): Update.
2781         (tui_gen_win_info::make_window): Rename from tui_make_window.
2782         (tui_win_info::make_window): New method.
2783         (tui_gen_win_info::make_visible): Update.
2784         * tui/tui-source.c (tui_source_window::set_contents): Update.
2785         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2786         (tui_data_window::display_registers_from): Update.
2787         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2788         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2789         Declare.
2790         <can_box>: Remove.
2791         <title>: Remove.
2792         (struct tui_win_info) <make_window>: Declare.
2793         <can_box>: Now virtual.
2794         <title>: New member.
2795         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2796         * tui/tui-command.c (tui_cmd_window::resize): Update.
2797
2798 2019-08-20  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2801         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2802         (tui_data_window::check_register_values): Update.
2803
2804 2019-08-20  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-regs.h (struct tui_data_window): Use
2807         DISABLE_COPY_AND_ASSIGN.
2808         <regs_content>: Change type, removing unique_ptr.
2809         <tui_data_window>: Add move constructor.
2810         * tui/tui-regs.c (tui_data_window::show_registers)
2811         (tui_data_window::show_register_group)
2812         (tui_data_window::display_registers_from)
2813         (tui_data_window::display_registers_from)
2814         (tui_data_window::first_data_item_displayed)
2815         (tui_data_window::delete_data_content_windows)
2816         (tui_data_window::rerender, tui_data_window::refresh_window)
2817         (tui_data_window::check_register_values): Update.
2818
2819 2019-08-20  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2822         show_register_group>: Declare.
2823         (tui_show_register_group): Don't declare.
2824         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2825         tui_show_registers.
2826         (tui_data_window::show_register_group): Rename from
2827         tui_show_register_group.
2828         (tui_data_window::check_register_values, tui_reg_command):
2829         Update.
2830         * tui/tui-layout.c (tui_set_layout): Update.
2831
2832 2019-08-20  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2835         Declare.
2836         (tui_check_register_values): Don't declare.
2837         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2838         from tui_check_register_values.
2839         * tui/tui-hooks.c (tui_register_changed): Update.
2840
2841 2019-08-20  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-regs.c (tui_reg_layout): Move later.
2844         (tui_show_registers): Don't enable TUI mode or change layout.
2845
2846 2019-08-20  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-regs.h (struct tui_data_item_window)
2849         <~tui_data_item_window>: Remove.
2850         <content>: Now a unique_xmalloc_ptr.
2851         * tui/tui-regs.c (tui_register_format): Return a
2852         unique_xmalloc_ptr.
2853         (tui_get_register): Update.
2854         (~tui_data_item_window): Remove.
2855         (tui_data_window::display_registers_from, tui_display_register):
2856         Update.
2857         * tui/tui-io.h (tui_expand_tabs): Update.
2858         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2859         Remove "col" parameter.
2860
2861 2019-08-20  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2864         field.
2865         * tui/tui-regs.c (~tui_data_item_window): Update.
2866
2867 2019-08-20  Tom Tromey  <tom@tromey.com>
2868
2869         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2870         earlier.
2871
2872 2019-08-20  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2875
2876 2019-08-20  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-source.h (struct tui_source_window): Update.
2879         * tui/tui-regs.c (tui_show_registers): Update.
2880         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2881         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2882         (NO_REGS_STRING): Remove defines.
2883
2884 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2885
2886         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2887         unnecessary thread walk if remote doesn't support the packet.
2888
2889 2019-08-19  Tom Tromey  <tromey@adacore.com>
2890
2891         * python/py-value.c (value_has_field): Fix indentation.
2892
2893 2019-08-19  Tom Tromey  <tromey@adacore.com>
2894
2895         * printcmd.c (do_one_display, info_display_command): Update.
2896         * block.h (contained_in): Return bool.  Add allow_nested
2897         parameter.
2898         * block.c (contained_in): Return bool.  Add allow_nested
2899         parameter.
2900
2901 2019-08-19  Tom Tromey  <tom@tromey.com>
2902
2903         * configure: Rebuild.
2904         * configure.ac: Disallow the combination of -static-libstdc++ and
2905         source highlight.
2906         * source-cache.c (get_language_name): Handle rust.
2907         (source_cache::get_source_lines): Ignore highlighting exceptions.
2908
2909 2019-08-16  Tom Tromey  <tom@tromey.com>
2910
2911         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2912         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2913         (struct tui_source_window_base) <make_visible, refresh_window,
2914         resize>: Remove methods.
2915         <execution_info>: Remove field.
2916         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2917         (tui_show_source_line, tui_source_window_base)
2918         (~tui_source_window_base): Update.
2919         (tui_source_window_base::resize)
2920         (tui_source_window_base::make_visible)
2921         (tui_source_window_base::refresh_window): Remove.
2922         (tui_source_window_base::update_exec_info): Update.
2923         * tui/tui-source.c (tui_source_window::set_contents): Update.
2924         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2925
2926 2019-08-16  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2929         deprecated_query_hook.
2930
2931 2019-08-16  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2934         (tui_update_source_windows_with_line): Update.
2935         * tui/tui-source.h (struct tui_source_window)
2936         <show_symtab_source>: Declare.
2937         (tui_show_symtab_source): Don't declare.
2938         * tui/tui-source.c (tui_show_symtab_source): Rename from
2939         tui_show_symtab_source.
2940
2941 2019-08-16  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-winsource.h (struct tui_source_window_base)
2944         <set_contents>: Declare.
2945         * tui/tui-winsource.c
2946         (tui_source_window_base::update_source_window_as_is): Update.
2947         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2948         Declare.
2949         (tui_set_source_content): Don't declare.
2950         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2951         tui_set_source_content.
2952         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2953         Declare.
2954         (tui_set_disassem_content): Don't declare.
2955         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2956         tui_set_disassem_content.
2957
2958 2019-08-16  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.h (struct tui_source_window_base)
2961         <update_breakpoint_info>: Declare.
2962         (tui_update_breakpoint_info): Don't declare.
2963         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2964         (tui_update_all_breakpoint_info): Update.
2965         (tui_source_window_base::update_breakpoint_info): Rename from
2966         tui_update_breakpoint_info.
2967         (tui_source_window_base::update_exec_info): Update.
2968
2969 2019-08-16  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-winsource.h (struct tui_source_window_base)
2972         <update_source_window>: Declare.
2973         (tui_update_source_window): Don't declare.
2974         * tui/tui-winsource.c
2975         (tui_source_window_base::update_source_window): Rename from
2976         tui_update_source_window.
2977         (tui_source_window_base::rerender): Update.
2978         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2979         * tui/tui-disasm.c (tui_show_disassem)
2980         (tui_show_disassem_and_update_source)
2981         (tui_disasm_window::maybe_update): Update.
2982
2983 2019-08-16  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-winsource.h (struct tui_source_window_base)
2986         <update_source_window_as_is>: Declare.
2987         (tui_update_source_window_as_is): Don't declare.
2988         * tui/tui-winsource.c (tui_update_source_window): Update
2989         (tui_source_window_base::update_source_window_as_is): Rename from
2990         tui_update_source_window_as_is.
2991         (tui_source_window_base::refill): Update.
2992         * tui/tui-source.c (tui_show_symtab_source): Update.
2993         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2994         Update.
2995
2996 2019-08-16  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui-winsource.h (tui_update_source_window)
2999         (tui_update_source_window_as_is): Remove "noerror" parameter.
3000         * tui/tui-winsource.c (tui_update_source_window)
3001         (tui_update_source_window_as_is): Remove "noerror" parameter.
3002         (tui_update_source_windows_with_addr)
3003         (tui_update_source_windows_with_line)
3004         (tui_source_window_base::rerender)
3005         (tui_source_window_base::refill): Update.
3006         * tui/tui-source.h (tui_set_source_content)
3007         (tui_show_symtab_source): Remove "noerror" parameter.
3008         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3009         parameter.
3010         (tui_show_symtab_source): Likewise.
3011         (tui_source_window::maybe_update): Update.
3012         * tui/tui-disasm.c (tui_show_disassem)
3013         (tui_show_disassem_and_update_source)
3014         (tui_disasm_window::do_scroll_vertical)
3015         (tui_disasm_window::maybe_update): Update.
3016
3017 2019-08-16  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui.c (tui_is_window_visible): Update.
3020         * tui/tui-wingeneral.c (tui_make_window)
3021         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3022         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3023         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3024         (tui_set_win_height_command, parse_scrolling_args): Update.
3025         * tui/tui-source.c (tui_source_window::style_changed): Update.
3026         * tui/tui-regs.c (tui_show_registers)
3027         (tui_data_window::first_data_item_displayed)
3028         (tui_data_window::delete_data_content_windows)
3029         (tui_check_register_values, tui_reg_command): Update.
3030         * tui/tui-disasm.c (tui_show_disassem): Update.
3031         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3032         method.
3033         <is_visible>: Remove field.
3034         * tui/tui-data.c (tui_next_win, tui_prev_win)
3035         (tui_delete_invisible_windows): Update.
3036
3037 2019-08-16  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-winsource.h (struct tui_source_window_base)
3040         <m_has_locator>: Remove.
3041         * tui/tui-layout.c (show_source_disasm_command, show_data)
3042         (show_source_or_disasm_and_command): Update.
3043
3044 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3045
3046         * NEWS (Other MI changes): New subsection.
3047         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3048         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3049         * arch-utils.c (default_get_pc_address_flags): New function.
3050         * arch-utils.h (default_get_pc_address_flags): New declaration.
3051         * gdbarch.sh: Add get_pc_address_flags.
3052         * gdbarch.c: Regenerate.
3053         * gdbarch.h: Likewise.
3054         * stack.c (print_pc): New function.
3055         (print_frame_info) (print_frame): Call print_pc.
3056
3057 2019-08-16  Tom de Vries  <tdevries@suse.de>
3058
3059         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3060         print_objfile_section_info.
3061
3062 2019-08-15  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3065         calling update_cmdwin_start_line.
3066         * tui/tui-winsource.h (struct tui_source_window_base)
3067         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3068         <rerender>: Declare.
3069         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3070         Call rerender.
3071         (tui_source_window_base::set_new_height): Remove.
3072         (tui_source_window_base::rerender): Rename from
3073         do_make_visible_with_new_height.
3074         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3075         resize method.
3076         (tui_win_info::make_invisible_and_set_new_height)
3077         (tui_win_info::make_visible_with_new_height): Remove.
3078         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3079         Declare.
3080         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3081         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3082         do_make_visible_with_new_height>: Don't declare.
3083         <rerender>: Declare.
3084         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3085         set_new_height.
3086         (tui_data_window::do_make_visible_with_new_height): Remove.
3087         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3088         call tui_show_locator_content.
3089         (tui_gen_win_info::resize): Call rerender.
3090         (show_source_or_disasm_and_command): Don't call
3091         tui_show_locator_content.
3092         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3093         method.
3094         (struct tui_win_info) <rerender>: Declare.
3095         <set_new_height, make_invisible_and_set_new_height,
3096         make_visible_with_new_height>: Don't declare.
3097         * tui/tui-data.c (tui_win_list::rerender): New method.
3098         * tui/tui-command.h (struct tui_cmd_window)
3099         <do_make_visible_with_new_height>: Don't declare.
3100         * tui/tui-command.c
3101         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3102
3103 2019-08-15  Tom Tromey  <tromey@adacore.com>
3104
3105         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3106         * ada-lang.c (ada_enum_name): Likewise.
3107
3108 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3109
3110         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3111         leading underscore.
3112         (GdbOutputErrorFile): Likewise.
3113         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3114         accordingly.
3115         (execute_unwinders): Rename to have a leading underscore.
3116         (auto_load_packages): Likewise.
3117         (global scope): Adjust call to auto_load_packages accordingly.
3118         (GdbSetPythonDirectory): Likewise.
3119         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3120         instead of execute_unwinders.
3121
3122 2019-08-15  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3125         (show_data): Don't change window visibility.
3126         (tui_gen_win_info::resize): Remove special case for command
3127         window.  Use wresize, when available.
3128         (show_source_or_disasm_and_command): Don't change window
3129         visibility.
3130         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3131         <make_visible>: New method.
3132         * tui/tui-command.c (tui_cmd_window::resize): New method.
3133
3134 2019-08-15  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3137         (struct tui_source_windows): New.
3138         * tui/tui-winsource.c (tui_display_main): Update.
3139         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3140         (new_height_ok, parse_scrolling_args): Update.
3141         * tui/tui-layout.c (show_layout, show_data): Update.
3142         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3143         (tui_add_to_source_windows): Don't declare.
3144         * tui/tui-data.c (source_windows, tui_source_windows)
3145         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3146
3147 2019-08-15  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3150         Rename from reset.
3151         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3152         * tui/tui-layout.c (show_source_disasm_command, show_data):
3153         Update.
3154         (tui_gen_win_info::resize): Rename.
3155         (show_source_or_disasm_and_command): Update.
3156         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3157         reset.
3158
3159 2019-08-15  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3162         * tui/tui-interp.c (tui_interp::init): Don't call
3163         tui_initialize_static_data.
3164         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3165
3166 2019-08-15  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3169         examine tui_win_list.
3170
3171 2019-08-15  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3174         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3175         tui_clear_source_content.
3176         (tui_clear_source_content): Remove.
3177         (tui_source_window_base::do_erase_source_content): Hoist call to
3178         content.clear().
3179         * tui/tui-stack.c (tui_show_frame_info): Don't call
3180         tui_clear_source_content.
3181
3182 2019-08-15  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-winsource.h (struct tui_source_window_base)
3185         <do_erase_source_content>: New method.
3186         <erase_source_content>: New method.
3187         (tui_erase_source_content): Don't declare.
3188         * tui/tui-winsource.c (tui_clear_source_content): Update.
3189         (tui_source_window_base::do_erase_source_content): Rename from
3190         tui_erase_source_content.
3191         (tui_source_window_base::show_source_content): Update.
3192         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3193         * tui/tui-source.h (struct tui_source_window)
3194         <erase_source_content>: New method.
3195         * tui/tui-disasm.h (struct tui_disasm_window)
3196         <erase_source_content>: New method.
3197
3198 2019-08-15  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3201         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3202         constructor.
3203         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3204         * tui/tui-source.c (tui_set_source_content): Update.
3205         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3206
3207 2019-08-15  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3210         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3211         tui-source.c.
3212         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3213         Declare.
3214         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3215         method.
3216         (tui_source_window::maybe_update): Update.
3217
3218 2019-08-15  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3221         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3222         tui-disasm.c.
3223         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3224         Declare.
3225         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3226         method.
3227         (tui_disasm_window::maybe_update): Update.
3228
3229 2019-08-15  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-winsource.h (struct tui_source_window_base)
3232         <maybe_update>: Declare.
3233         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3234         method.
3235         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3236         Declare.
3237         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3238         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3239         Declare.
3240         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3241
3242 2019-08-15  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3245
3246 2019-08-15  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-wingeneral.c: Include tui-stack.h.
3249         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3250         (struct tui_locator_window): Move from tui-data.h.
3251         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3252         (tui_initialize_static_data): Move from tui-data.c.
3253         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3254         (struct tui_locator_window): Move to tui-stack.c.
3255         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3256         (tui_initialize_static_data): Move to tui-stack.c.
3257
3258 2019-08-15  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-layout.c (show_source_disasm_command)
3261         (show_source_or_disasm_and_command): Use make_visible method, not
3262         tui_make_window.
3263         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3264         Remove.
3265
3266 2019-08-15  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-wingeneral.h (tui_make_window): Update.
3269         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3270         parameter.
3271         (tui_gen_win_info::make_visible): Update.
3272         * tui/tui-regs.c (tui_data_window::display_registers_from):
3273         Update.
3274         * tui/tui-layout.c (show_source_disasm_command)
3275         (show_source_or_disasm_and_command): Update.
3276         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3277         (enum tui_box): Remove.
3278         (struct tui_win_info) <can_box>: New method.
3279         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3280         method.
3281
3282 2019-08-15  Tom de Vries  <tdevries@suse.de>
3283
3284         * linux-nat-trad.c: Include gdbarch.h.
3285
3286 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3287
3288         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3289         register sizes.
3290
3291 2019-08-14  Tom Tromey  <tromey@adacore.com>
3292
3293         * darwin-nat.c: Include gdbarch.h.
3294         * darwin-nat-info.c: Include gdbarch.h.
3295
3296 2019-08-13  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3299         Remove.
3300         * tui/tui-data.c (tui_initialize_static_data): Update.
3301
3302 2019-08-13  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-winsource.h (struct tui_exec_info_window)
3305         <~tui_exec_info_window, maybe_allocate_content, get_content,
3306         m_content>: Remove.
3307         (struct tui_source_window_base) <set_exec_info_content,
3308         show_exec_info_content>: Don't declare.
3309         * tui/tui-winsource.c
3310         (tui_exec_info_window::maybe_allocate_content): Remove.
3311         (tui_source_window_base::update_exec_info): Rename from
3312         set_exec_info_content.
3313         (tui_source_window_base::show_exec_info_content)
3314         (tui_source_window_base::update_exec_info): Remove.
3315
3316 2019-08-13  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3319         declare.
3320         * tui/tui-winsource.c (tui_update_source_window_as_is)
3321         (tui_update_source_windows_with_addr, tui_erase_source_content):
3322         Update.
3323         (tui_clear_exec_info_content): Remove.
3324
3325 2019-08-13  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3328         declare.
3329         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3330         call tui_erase_exec_info_content.
3331         (tui_clear_exec_info_content): Rename from
3332         tui_erase_exec_info_content.
3333         (tui_clear_exec_info_content): Delete.
3334
3335 2019-08-13  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui-winsource.h (struct tui_source_window_base)
3338         <show_exec_info_content>: Declare.
3339         (tui_show_exec_info_content): Don't declare.
3340         * tui/tui-winsource.c
3341         (tui_source_window_base::show_exec_info_content): Rename from
3342         tui_show_exec_info_content.
3343         (tui_source_window_base::update_exec_info): Update.
3344
3345 2019-08-13  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3348         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3349         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3350         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3351         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3352         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3353         ... here.
3354
3355 2019-08-13  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-winsource.h (struct tui_source_window_base)
3358         <update_exec_info>: Declare.
3359         (tui_update_exec_info): Don't declare.
3360         * tui/tui-winsource.c (tui_update_source_window_as_is)
3361         (tui_source_window_base::refresh_all)
3362         (tui_update_all_breakpoint_info): Update.
3363         (tui_source_window_base::update_exec_info): Rename from
3364         tui_update_exec_info.
3365         * tui/tui-stack.c (tui_show_frame_info): Update.
3366
3367 2019-08-13  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-winsource.h (struct tui_source_window_base)
3370         <set_exec_info_content>: Declare.
3371         (tui_set_exec_info_content): Don't declare.
3372         * tui/tui-winsource.c
3373         (tui_source_window_base::set_exec_info_content): Rename from
3374         tui_set_exec_info_content.
3375         (tui_update_exec_info): Update.
3376
3377 2019-08-13  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-winsource.h (struct tui_source_window_base)
3380         <show_source_content>: Declare.
3381         (tui_show_source_content): Don't declare.
3382         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3383         (tui_source_window_base::show_source_content): Rename from
3384         tui_show_source_content.
3385         (tui_source_window_base::refresh_all): Update.
3386         * tui/tui-layout.c (show_source_disasm_command)
3387         (show_source_or_disasm_and_command): Update.
3388
3389 2019-08-13  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-winsource.c (tui_erase_source_content)
3392         (tui_show_source_content, tui_source_window_base::refresh_all):
3393         Update.
3394         * tui/tui-wingeneral.h
3395         (tui_check_and_display_highlight_if_needed): Don't declare.
3396         * tui/tui-wingeneral.c
3397         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3398         check_and_display_highlight_if_needed.
3399         * tui/tui-win.c (tui_rehighlight_all)
3400         (tui_win_info::make_visible_with_new_height): Update.
3401         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3402         (tui_data_window::erase_data_content)
3403         (tui_data_window::display_all_data): Update.
3404         * tui/tui-data.h (struct tui_win_info)
3405         <check_and_display_highlight_if_needed>: Declare.
3406
3407 2019-08-13  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-win.c (tui_resize_all): Call
3410         tui_delete_invisible_windows.
3411         * tui/tui-layout.c (show_layout): Call
3412         tui_delete_invisible_windows.
3413         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3414         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3415
3416 2019-08-13  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3419         tui_add_win_to_layout.
3420
3421 2019-08-13  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3424         * tui/tui-layout.c (tui_default_win_height): Now static.
3425
3426 2019-08-13  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3429         single switch.
3430         (show_source_disasm_command, show_source_or_disasm_and_command):
3431         Don't check current layout.
3432
3433 2019-08-13  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-wingeneral.c (make_all_visible): Remove.
3436         (tui_make_all_invisible): Simplify.
3437         * tui/tui-layout.c (tui_make_all_invisible): Move from
3438         tui-wingeneral.c; simplify.
3439         (show_layout): Hoist call to tui_make_all_invisible.
3440         (show_data): Don't call tui_make_all_invisible.
3441
3442 2019-08-13  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3445         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3446
3447 2019-08-13  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3450         tui-data.c.
3451         (show_source_disasm_command, show_data)
3452         (show_source_or_disasm_and_command): Don't use
3453         tui_set_current_layout_to.
3454         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3455         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3456         tui-layout.c.
3457         (tui_set_current_layout_to): Remove.
3458
3459 2019-08-13  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-layout.c (tui_set_layout): Update.
3462         * tui/tui-data.h (struct tui_layout_def): Remove.
3463         (tui_layout_def): Don't declare.
3464         * tui/tui-data.c (layout_def): Remove.
3465         (tui_layout_def): Remove.
3466
3467 2019-08-13  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-winsource.h (struct tui_source_window_base)
3470         <clear_detail>: No longer "override".
3471         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3472         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3473         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3474         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3475         Remove.
3476         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3477
3478 2019-08-13  Tom Tromey  <tromey@adacore.com>
3479
3480         * tracepoint.c: Don't include readline.h or history.h.
3481
3482 2019-08-12  Tom Tromey  <tom@tromey.com>
3483
3484         * configure: Rebuild.
3485         * configure.ac: Check for readline 7.
3486         * NEWS: Mention readline 7 requirement.
3487         * README: Update.
3488
3489 2019-08-12  Tom Tromey  <tom@tromey.com>
3490
3491         * mingw-hdep.c (gdb_select): Remove readline hack.
3492
3493 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3494
3495         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3496         when the function fails.
3497
3498 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3499
3500         * s390-tdep.c (s390_type_align): New function.
3501         (s390_gdbarch_init): Set it as type_align gdbarch method.
3502
3503 2019-08-09  Tom de Vries  <tdevries@suse.de>
3504
3505         PR gdb/24591
3506         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3507         pc_low with relocation offset.
3508
3509 2019-08-07  Tom Tromey  <tromey@adacore.com>
3510
3511         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3512         (print_frame_args): Update.
3513         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3514         Update.
3515         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3516         * frame.h (struct frame_arg): Add initializers.
3517         <error>: Now a unique_xmalloc_ptr.
3518
3519 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3520
3521         * NEWS: Expand the Pointer Authentication entry.
3522         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3523         (aarch64_frame_unmask_lr): ... to this.
3524         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3525         Call aarch64_frame_unmask_lr.
3526         * frame.c (struct frame_info): Add "masked" variable.
3527         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3528         (fprint_frame): Check for masked pc.
3529         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3530         declarations.
3531         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3532         * stack.c (print_frame): Check for masked pc.
3533
3534 2019-08-06  Tom Tromey  <tom@tromey.com>
3535
3536         * stabsread.c (patch_block_stabs, read_one_struct_field)
3537         (read_enum_type): Use obstack_strndup.
3538         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3539         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3540         * dwarf2read.c (guess_full_die_structure_name)
3541         (anonymous_struct_prefix): Use obstack_strndup.
3542         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3543         * c-exp.y (yylex): Use obstack_strndup.
3544         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3545         (write_var_or_type): Use obstack_strndup.
3546
3547 2019-08-06  Tom Tromey  <tom@tromey.com>
3548
3549         * symfile.c (reread_symbols): Use obstack_strdup.
3550         * stabsread.c (read_type): Use obstack_strdup.
3551         * gdb_obstack.h (obstack_strdup): New overload.
3552         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3553         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3554         (dwarf2_canonicalize_name): Use obstack_strdup.
3555         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3556         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3557         Use obstack_strdup.
3558
3559 2019-08-06  Tom Tromey  <tom@tromey.com>
3560
3561         * gdb_obstack.h (obstack_strdup): Define.
3562         * gdb_obstack.c (obstack_strdup): Don't define.
3563
3564 2019-08-06  Tom Tromey  <tom@tromey.com>
3565
3566         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3567         obstack_strdup.
3568         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3569         obstack_strdup.
3570         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3571         * stabsread.c (common_block_start): Use obstack_strdup.
3572         * objfiles.c (set_objfile_main_name, objfile): Use
3573         obstack_strdup.
3574         * namespace.c (add_using_directive): Use obstack_strdup.
3575         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3576         * jit.c (finalize_symtab): Use obstack_strdup.
3577         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3578         (guess_partial_die_structure_name, partial_die_info::fixup)
3579         (dwarf2_name): Use obstack_strdup.
3580         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3581         obstack_strdup.
3582         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3583         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3584         obstack_strdup.
3585         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3586
3587 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3588
3589         * unittests/help-doc-selftests.c: New file.
3590         * Makefile.in: Add the new file.
3591
3592 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3593
3594         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3595         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3596         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3597         the trailing '.' is not output, and the first character is uppercased.
3598         (print_help_for_command): Update call to print_doc_line.
3599         (print_doc_of_command): Likewise.
3600         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3601         * cli/cli-option.c (append_indented_doc): Do not append newline.
3602         (build_help_option): Append newline after first appended_indented_doc
3603         only if a second call is done.
3604         (build_help): Append 2 new lines before each option, except the first
3605         one.
3606         * compile/compile.c (_initialize_compile): Add new lines after
3607         %OPTIONS%, when not at the end of the help.
3608         Change help doc or code
3609         producing the help doc to respect the invariants.
3610         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3611         Also removed the new line after 'Options:', as all other commands
3612         do not put an empty line between 'Options:' and the first option.
3613         * printcmd.c (_initialize_printcmd): Likewise.
3614         * stack.c (_initialize_stack): Likewise.
3615         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3616         incorrectly telling COMMAND is optional.
3617         * ada-lang.c (_initialize_ada_language): Change help doc or code
3618         producing the help doc to respect the invariants.
3619         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3620         * breakpoint.c (_initialize_breakpoint): Likewise.
3621         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3622         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3623         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3624         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3625         _initialize_cli_style): Likewise.
3626         * corelow.c (core_target_info): Likewise.
3627         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3628         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3629         * filesystem.c (_initialize_filesystem): Likewise.
3630         * frame.c (_initialize_frame): Likewise.
3631         * gnu-nat.c (add_task_commands): Likewise.
3632         * infcall.c (_initialize_infcall): Likewise.
3633         * infcmd.c (_initialize_infcmd): Likewise.
3634         * interps.c (_initialize_interpreter): Likewise.
3635         * language.c (_initialize_language): Likewise.
3636         * linux-fork.c (_initialize_linux_fork): Likewise.
3637         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3638         * maint.c (_initialize_maint_cmds): Likewise.
3639         * memattr.c (_initialize_mem): Likewise.
3640         * printcmd.c (_initialize_printcmd): Likewise.
3641         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3642         _RegEx): Likewise.
3643         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3644         * record-btrace.c (_initialize_record_btrace): Likewise.
3645         * record-full.c (_initialize_record_full): Likewise.
3646         * record.c (_initialize_record): Likewise.
3647         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3648         * regcache.c (_initialize_regcache): Likewise.
3649         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3650         _initialize_remote): Likewise.
3651         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3652         * serial.c (_initialize_serial): Likewise.
3653         * skip.c (_initialize_step_skip): Likewise.
3654         * source.c (_initialize_source): Likewise.
3655         * stack.c (_initialize_stack): Likewise.
3656         * symfile.c (_initialize_symfile): Likewise.
3657         * symtab.c (_initialize_symtab): Likewise.
3658         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3659         * top.c (init_main): Likewise.
3660         * tracefile-tfile.c (tfile_target_info): Likewise.
3661         * tracepoint.c (_initialize_tracepoint): Likewise.
3662         * tui/tui-win.c (_initialize_tui_win): Likewise.
3663         * utils.c (add_internal_problem_command): Likewise.
3664         * valprint.c (value_print_option_defs): Likewise.
3665
3666 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3667
3668         PR build/24886
3669         * configure.ac: Drop enable-libmcheck support.
3670         * configure, config.in: Rebuild.
3671         * libmcheck.m4: Remove.
3672         * acinclude.m4: Don't include it.
3673         * Makefile.in: Don't distribute it.
3674         * top.c (print_gdb_configuration): Don't mention it.
3675
3676 2019-08-06  Tom Tromey  <tom@tromey.com>
3677
3678         * utils.c (set_output_style): Sometimes pass stream to
3679         emit_style_escape.
3680         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3681         * record-btrace.c (btrace_insn_history): Update.
3682         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3683         method.
3684         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3685         Update initializers.
3686         <m_uiout>: New field.
3687         <m_di>: Move lower.
3688         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3689         Remove "uiout" parameter.
3690         (dump_insns): Update.
3691         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3692         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3693
3694 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3695
3696         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3697         (error_in_psymtab_expansion): Likewise.
3698         (lookup_symbol_via_quick_fns): Likewise.
3699         (basic_lookup_transparent_type_quick): Likewise.
3700         (basic_lookup_transparent_type_1): Likewise.
3701
3702 2019-08-06  Tom Tromey  <tromey@adacore.com>
3703
3704         * source.c (last_source_error): Now bool.
3705         (print_source_lines_base): Make "noprint" bool.  Only open
3706         source file when last_source_visited changes.
3707
3708 2019-08-06  Tom Tromey  <tromey@adacore.com>
3709
3710         * annotate.c (annotate_source_line): Use g_source_cache.
3711         * source-cache.c (source_cache::get_plain_source_lines): Change
3712         parameters.  Populate m_offset_cache.
3713         (source_cache::ensure): New method.
3714         (source_cache::get_line_charpos): New method.
3715         (extract_lines): Move lower.  Change parameters.
3716         (source_cache::get_source_lines): Move lower.
3717         * source-cache.h (class source_cache): Update comment.
3718         <get_line_charpos>: New method.
3719         <get_source_lines>: Update comment.
3720         <clear>: Clear m_offset_cache.
3721         <get_plain_source_lines>: Change parameters.
3722         <ensure>: New method
3723         <m_offset_cache>: New member.
3724         * source.c (forget_cached_source_info_for_objfile): Update.
3725         (info_source_command): Use g_source_cache.
3726         (find_source_lines, open_source_file_with_line_charpos): Remove.
3727         (print_source_lines_base, search_command_helper): Use g_source_cache.
3728         * source.h (open_source_file_with_line_charpos): Don't declare.
3729         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3730         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3731         Use g_source_cache.
3732
3733 2019-08-06  Tom Tromey  <tromey@adacore.com>
3734
3735         * source-cache.c (source_cache::get_plain_source_lines):
3736         Remove "first_line" and "last_line" parameters.
3737         (source_cache::get_source_lines): Cache plain text.
3738         * source-cache.h (class source_cache)
3739         <get_plain_source_lines>: Update.
3740
3741 2019-08-06  Tom Tromey  <tromey@adacore.com>
3742
3743         * source-cache.c (extract_lines): No longer a method.
3744         Changed type of parameter.  Include final newline.
3745         (selftests::extract_lines_test): New function.
3746         (_initialize_source_cache): Likewise.
3747         * source-cache.h (class source_cache)
3748         <extract_lines>: Don't declare.
3749
3750 2019-08-06  Tom Tromey  <tromey@adacore.com>
3751
3752         * breakpoint.c (init_breakpoint_sal): Update.
3753         (breakpoint): Update.
3754         * breakpoint.h (struct breakpoint) <filter>: Now a
3755         unique_xmalloc_ptr.
3756
3757 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3758
3759         * NEWS: Mention dictionary access on blocks.
3760         * python/py-block.c (blpy_getitem): New function.
3761         (block_object_as_mapping): New struct.
3762         (block_object_type): Use new struct for tp_as_mapping field.
3763
3764 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3765
3766         * objfiles.h (objfile): Add a comment describing partial symbols.
3767
3768 2019-08-05  Tom Tromey  <tromey@adacore.com>
3769
3770         * compile/compile.c (_initialize_compile): Use _(), not N_().
3771         * thread.c (_initialize_thread): Use _(), not N_().
3772         * stack.c (_initialize_stack): Use _(), not N_().
3773         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3774
3775 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3776
3777         * dwarf2read.c (struct dw2_symtab_iterator):
3778         <want_specific_block>: Remove.
3779         <block_index>: Change type to gdb::optional.
3780         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3781         change type of BLOCK_INDEX parameter to gdb::optional.
3782         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3783         (dw2_lookup_symbol): Don't pass argument for
3784         WANT_SPECIFIC_BLOCK.
3785         (dw2_expand_symtabs_for_function): Don't pass argument for
3786         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3787         (class dw2_debug_names_iterator)
3788         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3789         parameter, change BLOCK_INDEX type to gdb::optional.
3790         <m_want_specific_block>: Remove.
3791         <m_block_index>: Change type to gdb::optional.
3792         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3793         gdb::optional.  Re-write in function of gdb::optional.
3794         (dw2_debug_names_lookup_symbol): Don't pass argument for
3795         WANT_SPECIFIC_BLOCK.
3796         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3797         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3798         BLOCK_INDEX.
3799
3800 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3801
3802         * NEWS: Mention changes to "info sources" command.
3803
3804 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3805
3806         * symtab.c (filename_partial_match_opts): New struct type.
3807         (struct output_source_filename_data): New members
3808         regexp, c_regexp, partial_match.
3809         (output_source_filename): Use new members to decide to print file.
3810         (info_sources_option_defs): New variable.
3811         (make_info_sources_options_def_group, print_info_sources_header,
3812         info_sources_command_completer):
3813         New functions.
3814         (info_sources_command): Read new optional arguments.
3815         (_initialize_symtab): Update info sources help.
3816
3817 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3818
3819         * ada-lang.c (exception_support_info_v0): Renamed from...
3820         (default_exception_support_info): ... this.  Create new
3821         definition for v1.
3822         (ada_has_this_exception_support): Look up catch_handlers_sym.
3823         (ada_exception_support_info_sniffer): Try v0 after default.
3824
3825 2019-08-01  Tom Tromey  <tromey@adacore.com>
3826
3827         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3828         gdbarch.h.
3829
3830 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3831
3832         * s12z-tdep.c: Fix include path for s12z-opc.h.
3833
3834 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3835
3836         * NEWS: Require GNU make 3.82.
3837
3838 2019-07-16  Tom Tromey  <tom@tromey.com>
3839
3840         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3841         declare.
3842
3843 2019-07-30  Tom Tromey  <tromey@adacore.com>
3844
3845         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3846
3847 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3848
3849         * printcmd.c (print_address_symbolic): Print negative offsets.
3850         (build_address_symbolic): Force signed arithmetic when computing
3851         offset.
3852
3853 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3854
3855         PR/24474: Add a function to lookup static variables.
3856         * NEWS: Mention this new function.
3857         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3858         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3859         * python/python.c (python_GdbMethods): Add new function.
3860
3861 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3862
3863         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3864         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3865         (objfpy_lookup_static_symbol): New function.
3866         (objfile_object_methods): Add new functions.
3867
3868 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3869
3870         * NEWS: Mention 'set|show print frame-info'.  Mention new
3871         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3872         backtrace argument.  Mention that python frame filtering code
3873         is now consistent with what 'backtrace' command prints.
3874
3875 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3876
3877         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3878         comments.
3879         (print_frame_info_auto, print_frame_info_source_line,
3880         print_frame_info_location, print_frame_info_source_and_location,
3881         print_frame_info_location_and_address, print_frame_info_short_location):
3882         New declarations.
3883         (struct frame_print_options): New member print_frame_info.
3884         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3885         * stack.h (get_user_print_what_frame_info): New declaration.
3886         (frame_show_address): New declaration.
3887         * stack.c (print_frame_arguments_choices): New value 'presence'.
3888         (print_frame_info_auto, print_frame_info_source_line,
3889         print_frame_info_location, print_frame_info_source_and_location,
3890         print_frame_info_location_and_address, print_frame_info_short_location,
3891         print_frame_info_choices, print_frame_info_print_what): New definitions.
3892         (print_frame_args): Only print dots for args if print frame-arguments
3893         is 'presence'.
3894         (frame_print_option_defs): New element for "frame-info".
3895         (get_user_print_what_frame_info): New function.
3896         (frame_show_address): Make non static.  Move comment to stack.h.
3897         (print_frame_info_to_print_what): New function.
3898         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3899         to decide what to print.
3900         (backtrace_command_1): Handle the new print_frame_arguments_presence
3901         value.
3902         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3903         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3904         (py_print_frame): In non-mi mode, use LOCATION as default for
3905         print_what, similarly to frame information printed directly by
3906         backtrace command. Handle frame-info user option in non MI mode.
3907
3908 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3909
3910         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3911         Add case for debugging 32-bit target on 64-bit host.  Revise
3912         comment.
3913
3914 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3915
3916         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3917         instead of find_function_entry_range_from_pc.
3918
3919 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3920
3921         * stack.c (find_frame_funname): Remove code which preferred
3922         minsym over symtab sym in "certain pathological cases".
3923
3924         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3925         parameter.  Change type of "do_demangle" to bool.
3926         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3927         Pass suitable "prefer_sym_over_minsym" flag to
3928         build_address_symbolic().  Don't output "+" for negative offsets.
3929         * printcmd.c (print_address_symbolic): Update invocation of
3930         build_address_symbolic to include a "prefer_sym_over_minsym"
3931         flag.
3932         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3933         Restrict cases in which use of minimal symbol is preferred to that
3934         of a found symbol.  Update comments.
3935
3936         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3937         for entry pc when entry pc is out of range for that FDE.
3938
3939 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3940
3941         PR gdb/24839:
3942         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3943         type.
3944
3945 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3946
3947         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3948         this function's Python signature.
3949
3950
3951 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3952
3953         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3954         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3955         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3956         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3957         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3958
3959
3960 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3961
3962         * h8300-tdep.c (h8300_register_name_common): New.
3963         h8300_register_name): Use h8300_register_name_common.
3964         (h8300s_register_name): Likewise.
3965         (h8300sx_register_name): Likewise.
3966         (h8300h_register_nam): New.
3967         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3968
3969
3970 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3971
3972         * arm-tdep.c (arm_skip_cmse_entry): New function.
3973         (arm_is_sgstubs_section): New function.
3974         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3975
3976 2019-07-22  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3979         Don't self-assign.
3980
3981 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3984         type_print.
3985
3986 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3987
3988         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3989         so that GDB doesn't match any msymbols when searching in the
3990         TYPES_DOMAIN.
3991         (print_symbol_info): Print using typedef_print or type_print based
3992         on the type of the symbol.  Add updated FIXME comment moved from...
3993         (_initialize_symtab): ... move and update FIXME comment to above.
3994
3995 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * NEWS: Mention adding -q option to "info types".
3998         * symtab.c (struct info_types_options): New struct.
3999         (info_types_options_defs): New variable.
4000         (make_info_types_options_def_group): New function.
4001         (info_types_command): Use gdb::option framework to parse options.
4002         (info_types_command_completer): New function.
4003         (_initialize_symtab): Extend the help text on "info types" and
4004         register command completer.
4005
4006 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4007
4008         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4009         (lookup_symbol_in_objfile): Change int to block_enum and add a
4010         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4011
4012 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4013
4014         * MAINTAINERS (Write After Approval): Add self.
4015
4016 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4017
4018         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4019         instruction to the dummy code region.
4020
4021 2019-07-19  Tom Tromey  <tromey@adacore.com>
4022
4023         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4024         (ARGSUSED, PARAMS, __func__): Remove rules.
4025
4026 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4027
4028         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4029         * features/arm/arm-with-iwmmxt.c: Remove.
4030         * features/arm/arm-with-iwmmxt.xml: Remove.
4031         * features/arm/arm-with-m-fpa-layout.c: Remove.
4032         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4033         * features/arm/arm-with-m-vfp-d16.c: Remove.
4034         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4035         * features/arm/arm-with-m.c: Remove.
4036         * features/arm/arm-with-m.xml: Remove.
4037         * features/arm/arm-with-neon.c: Remove.
4038         * features/arm/arm-with-neon.xml: Remove.
4039         * features/arm/arm-with-vfpv2.c: Remove.
4040         * features/arm/arm-with-vfpv2.xml: Remove.
4041         * features/arm/arm-with-vfpv3.c: Remove.
4042         * features/arm/arm-with-vfpv3.xml: Remove.
4043
4044 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4045
4046         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4047
4048 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4049
4050         * arch/aarch32.c (aarch32_create_target_description): Create
4051         target descriptions using features.
4052         * arch/arm.c (arm_create_target_description)
4053         (arm_create_mprofile_target_description): Likewise.
4054         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4055
4056 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4057
4058         * Makefile.in: Add new files.
4059         * aarch32-tdep.c: New file.
4060         * aarch32-tdep.h: New file.
4061         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4062         Call aarch32_read_description.
4063         * arch/aarch32.c: New file.
4064         * arch/aarch32.h: New file.
4065         * arch/arm.c (arm_create_target_description)
4066         (arm_create_mprofile_target_description): New function.
4067         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4068         (arm_create_target_description)
4069         (arm_create_mprofile_target_description): New declaration.
4070         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4071         read_description functions.
4072         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4073         Likewise.
4074         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4075         * arm-tdep.c (tdesc_arm_list): New variable.
4076         (arm_register_g_packet_guesses): Call create description functions.
4077         (arm_read_description) (arm_read_mprofile_description): New
4078         function.
4079         * arm-tdep.h (arm_read_description)
4080         (arm_read_mprofile_description): Add declaration.
4081         * configure.tgt: Add new files.
4082
4083 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4084
4085         * top.c (new_ui_command): Open specified terminal just once.
4086
4087 2019-07-18  Tom Tromey  <tromey@adacore.com>
4088
4089         * symtab.c (main_name): Constify return type.
4090         * symfile.c (set_initial_language): Update.
4091         * symtab.h (main_name): Constify return type.
4092
4093 2019-07-17  Tom Tromey  <tom@tromey.com>
4094
4095         * tui/tui-winsource.c (tui_update_source_window)
4096         (tui_update_source_window_as_is)
4097         (tui_update_source_windows_with_line): Remove return.
4098         * tui/tui-disasm.c (tui_show_disassem)
4099         (tui_show_disassem_and_update_source): Remove return.
4100         * tui/tui.c (tui_reset): Remove return.
4101         * tui/tui-wingeneral.c
4102         (tui_check_and_display_highlight_if_needed): Remove return.
4103
4104 2019-07-17  Tom Tromey  <tom@tromey.com>
4105
4106         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4107
4108 2019-07-17  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-winsource.h (struct tui_exec_info_window)
4111         (struct tui_source_window_base): Move from tui-data.h.
4112         * tui/tui-winsource.c: Move many method definitions from
4113         elsewhere.  Remove "structuring" comments.
4114         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4115         (tui_source_window_base::refresh_window): Move to
4116         tui-winsource.c.
4117         * tui/tui-win.c (tui_source_window_base::refresh_all)
4118         (tui_source_window_base::update_tab_width)
4119         (tui_source_window_base::set_new_height)
4120         (tui_source_window_base::do_make_visible_with_new_height): Move to
4121         tui-winsource.c.
4122         * tui/tui-source.h: Update.
4123         * tui/tui-source.c (tui_source_window_base::reset): Move to
4124         tui-winsource.c.
4125         * tui/tui-disasm.h: Update.
4126         * tui/tui-data.h (struct tui_exec_info_window): Move to
4127         tui-winsource.h.
4128         (struct tui_source_window_base): Likewise.
4129         * tui/tui-data.c (tui_source_window_base::clear_detail)
4130         (tui_source_window_base, ~tui_source_window_base): Move to
4131         tui-winsource.c.
4132
4133 2019-07-17  Tom Tromey  <tom@tromey.com>
4134
4135         * tui/tui-win.c (tui_resize_all)
4136         (tui_source_window_base::update_tab_width)
4137         (tui_adjust_win_heights): Update.
4138         (tui_win_info::make_invisible_and_set_new_height): Rename from
4139         make_invisible_and_set_new_height.
4140         * tui/tui-data.h (struct tui_win_info)
4141         <make_invisible_and_set_new_height>: New method.
4142
4143 2019-07-17  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui.c: Update.
4146         * tui/tui-source.h (struct tui_source_window): Move from
4147         tui-data.h.
4148         * tui/tui-layout.c: Update.
4149         * tui/tui-disasm.c: Update.
4150         * tui/tui-data.h (struct tui_source_window): Move to
4151         tui-source.h.
4152
4153 2019-07-17  Tom Tromey  <tom@tromey.com>
4154
4155         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4156         tui-data.h.
4157         * tui/tui-data.h (struct tui_disasm_window): Move to
4158         tui-disasm.h.
4159
4160 2019-07-17  Tom Tromey  <tom@tromey.com>
4161
4162         * tui/tui-regs.h (struct tui_data_item_window): Move from
4163         tui-data.h.
4164         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4165         * tui/tui-data.h (struct tui_data_item_window): Move to
4166         tui-regs.h.
4167         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4168
4169 2019-07-17  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui.c: Update.
4172         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4173         (tui_cmd_window::max_height): Move to tui-command.c.
4174         * tui/tui-layout.c: Update.
4175         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4176         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4177         tui-command.c.
4178         * tui/tui-command.h (struct tui_cmd_window): Move from
4179         tui-data.h.
4180         * tui/tui-command.c: Remove "structuring" comments.
4181         (tui_cmd_window::clear_detail)
4182         (tui_cmd_window::do_make_visible_with_new_height)
4183         (tui_cmd_window::max_height): Move from elsewhere.
4184
4185 2019-07-17  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4188         Now static.
4189         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4190         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4191
4192 2019-07-17  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui.c: Update.
4195         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4196         tui-regs.c.
4197         * tui/tui-windata.h: Remove file.
4198         * tui/tui-windata.c: Remove file.
4199         * tui/tui-win.c (tui_data_window::set_new_height)
4200         (tui_data_window::do_make_visible_with_new_height): Move to
4201         tui-regs.c.
4202         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4203         * tui/tui-regs.c: Remove "structuring" comments.
4204         (tui_data_window::first_data_item_displayed)
4205         (tui_data_window::delete_data_content_windows)
4206         (tui_data_window::erase_data_content)
4207         (tui_data_window::display_all_data)
4208         (tui_data_window::refresh_all)
4209         (tui_data_window::do_scroll_vertical)
4210         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4211         (tui_data_window::do_make_visible_with_new_height)
4212         (tui_data_window::refresh_window): Move from elsewhere.
4213         (_initialize_tui_regs): Move to end of file.
4214         * tui/tui-layout.c: Update.
4215         * tui/tui-hooks.c: Update.
4216         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4217         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4218         tui-regs.c.
4219         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4220
4221 2019-07-17  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4224         seen.
4225
4226 2019-07-17  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-win.c (tui_source_window_base::set_new_height)
4229         (tui_source_window_base::do_make_visible_with_new_height): Use
4230         m_has_locator field directly.
4231         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4232         method.
4233         (struct tui_source_window_base) <has_locator>: Likewise.
4234
4235 2019-07-17  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4238         Don't declare.
4239         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4240         Remove.
4241         * tui/tui-win.c (tui_source_window_base::set_new_height)
4242         (tui_source_window_base::set_new_height)
4243         (make_invisible_and_set_new_height)
4244         (tui_source_window_base::do_make_visible_with_new_height)
4245         (tui_source_window_base::do_make_visible_with_new_height):
4246         Update.
4247         * tui/tui-layout.c (show_source_disasm_command, show_data)
4248         (show_source_or_disasm_and_command): Update.
4249         * tui/tui-layout.c (show_layout): Update.
4250
4251 2019-07-17  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui-layout.c (make_data_window): Remove.
4254         (show_data): Unify creation and re-initialization cases.
4255
4256 2019-07-17  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-layout.c (make_source_window, make_disasm_window):
4259         Remove.
4260         (show_data): Unify creation and re-initialization cases.
4261
4262 2019-07-17  Tom Tromey  <tom@tromey.com>
4263
4264         * tui/tui-layout.c (make_command_window): Remove.
4265         (show_source_disasm_command, show_source_or_disasm_and_command):
4266         Unify creation and re-initialization cases.
4267
4268 2019-07-17  Tom Tromey  <tom@tromey.com>
4269
4270         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4271         creation and re-initialization cases.
4272
4273 2019-07-17  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-regs.c (tui_get_register): Return void.
4276
4277 2019-07-17  Tom Tromey  <tom@tromey.com>
4278
4279         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4280         Simplify.
4281
4282 2019-07-17  Tom Tromey  <tom@tromey.com>
4283
4284         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4285         resetting.
4286
4287 2019-07-17  Tom Tromey  <tom@tromey.com>
4288
4289         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4290         * tui/tui-regs.c (tui_reg_layout): New function.
4291         (tui_show_registers, tui_reg_command): Use it.
4292         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4293         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4294         parameters.
4295         (tui_layout_command): Remove.
4296
4297 2019-07-17  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui-layout.h (tui/tui-layout): Return void.
4300         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4301
4302 2019-07-17  Tom Tromey  <tom@tromey.com>
4303
4304         * tui/tui-layout.c (show_source_disasm_command, show_data):
4305         Update.
4306         (reset_locator): Remove.
4307         (show_source_or_disasm_and_command): Update.
4308
4309 2019-07-17  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui-source.c (tui_source_window_base::reset): Remove
4312         win_type parameter.
4313         * tui/tui-layout.c (make_command_window, make_source_window)
4314         (make_disasm_window, make_data_window)
4315         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4316         (reset_locator, show_source_or_disasm_and_command): Update.
4317         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4318         win_type parameter.
4319         (struct tui_source_window_base) <reset>: Likewise.
4320
4321 2019-07-17  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui-layout.c (show_source_disasm_command): Use
4324         reset_locator.
4325         (reset_locator): New function.
4326         (init_and_make_win): Remove.
4327         (show_source_or_disasm_and_command): Use reset_locator.
4328
4329 2019-07-17  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4332         condition.
4333         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4334         Remove condition.
4335         * tui/tui-source.c (tui_source_window_base::reset): New method.
4336         * tui/tui-layout.c (make_command_window): Don't call
4337         init_and_make_win.
4338         (make_source_window, make_disasm_window): Don't call
4339         make_source_or_disasm_window.
4340         (make_data_window): Don't call init_and_make_win.  Change calling
4341         convention.
4342         (show_source_disasm_command, show_data): Simplify.
4343         (make_source_or_disasm_window): Remove.
4344         (show_source_or_disasm_and_command): Simplify.
4345         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4346         (struct tui_source_window_base) <reset>: Likewise.
4347         <execution_info>: Remove initializer.
4348         * tui/tui-data.c (tui_source_window_base): Initialize
4349         execution_info.
4350
4351 2019-07-17  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4354         variable.
4355
4356 2019-07-17  Tom Tromey  <tom@tromey.com>
4357
4358         * tui/tui.c (tui_rl_other_window): Update.
4359         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4360         superclass method first.  Always iterate over regs_content.
4361         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4362         method.
4363         * tui/tui-win.c (tui_set_focus_command): Update.
4364
4365 2019-07-17  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-win.c (tui_set_focus_command): Rename from
4368         tui_set_focus.  Call tui_enable.
4369         (tui_set_focus_command): Remove.
4370
4371 2019-07-17  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4374         refresh_window.
4375         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4376         touchwin.
4377         (tui_data_window::refresh_window): Call refresh_window on data
4378         items.  Always call superclass refresh_window.
4379         (tui_win_info::refresh): Remove.
4380         (tui_source_window_base::refresh_window): Update.
4381         (tui_refresh_all): Update.
4382         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4383         refresh_window.
4384         (show_source_or_disasm_and_command): Likewise.
4385         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4386         (struct tui_source_window_base) <refresh>: Likewise.
4387
4388 2019-07-17  Tom Tromey  <tom@tromey.com>
4389
4390         * tui/tui-winsource.c (tui_clear_source_content)
4391         (tui_show_source_content): Update.
4392         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4393         whether content is empty.
4394         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4395         Remove.
4396
4397 2019-07-17  Tom Tromey  <tom@tromey.com>
4398
4399         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4400         window's contents.
4401         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4402         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4403
4404 2019-07-17  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4407         (struct tui_data_item_window): Update.
4408
4409 2019-07-17  Tom Tromey  <tom@tromey.com>
4410
4411         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4412         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4413         defines.
4414
4415 2019-07-17  Tom Tromey  <tom@tromey.com>
4416
4417         * tui/tui-winsource.h (tui_erase_source_content)
4418         (tui_clear_source_content): Remove "display_prompt" parameter.
4419         * tui/tui-winsource.c (tui_update_source_window_as_is)
4420         (tui_update_source_windows_with_addr): Update.
4421         (tui_clear_source_content): Remove "display_prompt" parameter.
4422         (tui_erase_source_content): Likewise.  Simplify.
4423         (tui_show_source_content): Update.
4424         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4425         * tui/tui-stack.c (tui_show_frame_info): Update.
4426         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4427         Remove defines.
4428
4429 2019-07-17  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4432         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4433         parameter.
4434         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4435         parameter.
4436
4437 2019-07-17  Tom Tromey  <tom@tromey.com>
4438
4439         * tui/tui-winsource.c (tui_clear_source_content)
4440         (tui_show_source_content, tui_show_exec_info_content)
4441         (tui_clear_exec_info_content): Update.
4442         * tui/tui-stack.c (tui_show_locator_content): Update.
4443         (tui_show_frame_info): Update.
4444         * tui/tui-source.h (tui_source_window): Don't declare.
4445         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4446         from tui_source_is_displayed.
4447         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4448         Remove field.
4449         (struct tui_source_window_base) <content_in_use>: New field.  Now
4450         bool.
4451         (struct tui_source_window) <showing_source_p>: New method.
4452         (TUI_SRC_WIN): Change cast.
4453         * tui/tui-data.c (tui_initialize_static_data): Update.
4454
4455 2019-07-17  Tom Tromey  <tom@tromey.com>
4456
4457         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4458         location_matches_p.
4459         * tui/tui-source.c (tui_source_window::location_matches_p): New
4460         method.
4461         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4462         method.
4463         * tui/tui-data.h (struct tui_source_window_base)
4464         <location_matches_p>: New method.
4465         (struct tui_source_window, struct tui_disasm_window)
4466         <location_matches_p>: Likewise.
4467
4468 2019-07-17  Tom Tromey  <tom@tromey.com>
4469
4470         * tui/tui-win.c (tui_set_win_height_command): Rename from
4471         tui_set_win_height.
4472         (tui_set_win_height_command): Remove.
4473
4474 2019-07-17  Tom Tromey  <tom@tromey.com>
4475
4476         * tui/tui-source.c (tui_source_window): New constructor.  Add
4477         observer.
4478         (~tui_source_window): New destructor.
4479         (tui_source_window::style_changed): New method.
4480         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4481         (tui_attach_detach_observers): Update.
4482         * tui/tui-data.h (struct tui_source_window): Make constructor not
4483         inline.  Add destructor.
4484         (struct tui_source_window) <style_changed>: New method.
4485         <m_observable>: New member.
4486
4487 2019-07-17  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4490         * tui/tui-win.c (tui_resize_all): Fix typo.
4491
4492 2019-07-17  Tom Tromey  <tom@tromey.com>
4493
4494         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4495         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4496         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4497         * tui/tui-win.c (window_name_completer): Use foreach.
4498         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4499         (update_tab_width): Likewise.
4500         * tui/tui-layout.c (show_layout): Update.
4501         * tui/tui-data.h (class tui_window_iterator): New.
4502         (struct all_tui_windows): New.
4503         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4504
4505 2019-07-17  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4508         parameter.  Don't reference globals.
4509         (tui_reg_command): Update.
4510
4511 2019-07-17  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-regs.c (tui_show_registers): Simplify.
4514
4515 2019-07-17  Tom Tromey  <tom@tromey.com>
4516
4517         * tui/tui-regs.c (tui_show_registers): Update.
4518         (tui_show_register_group): Add win_info parameter.
4519
4520 2019-07-17  Tom Tromey  <tom@tromey.com>
4521
4522         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4523         Rename from tui_display_reg_element_at_line.
4524         (tui_data_window::display_registers_from_line): Update.
4525         * tui/tui-data.h (struct tui_data_window)
4526         <display_reg_element_at_line>: New method.
4527
4528 2019-07-17  Tom Tromey  <tom@tromey.com>
4529
4530         * tui/tui-regs.h (tui_display_registers_from)
4531         (tui_display_registers_from_line): Don't declare.
4532         * tui/tui-windata.c (tui_data_window::display_all_data)
4533         (tui_data_window::refresh_all)
4534         (tui_data_window::do_scroll_vertical): Update.
4535         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4536         from tui_display_registers_from.
4537         (tui_display_reg_element_at_line): Update.
4538         (tui_data_window::display_registers_from_line): Rename from
4539         tui_display_registers_from_line.
4540         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4541         display_registers_from_line>: New methods.
4542
4543 2019-07-17  Tom Tromey  <tom@tromey.com>
4544
4545         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4546         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4547         from tui_erase_data_content.
4548         (tui_data_window::display_all_data)
4549         (tui_data_window::refresh_all)
4550         (tui_data_window::do_scroll_vertical): Update.
4551         * tui/tui-regs.c (tui_show_registers): Update.
4552         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4553         New method.
4554
4555 2019-07-17  Tom Tromey  <tom@tromey.com>
4556
4557         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4558         declare.
4559         * tui/tui-windata.c
4560         (tui_data_window::delete_data_content_windows): Rename from
4561         tui_delete_data_content_windows.
4562         (tui_data_window::display_all_data)
4563         (tui_data_window::do_scroll_vertical): Update.
4564         * tui/tui-data.h (struct tui_data_window)
4565         <delete_data_content_windows>: New method.
4566
4567 2019-07-17  Tom Tromey  <tom@tromey.com>
4568
4569         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4570         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4571
4572 2019-07-17  Tom Tromey  <tom@tromey.com>
4573
4574         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4575         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4576         from tui_display_all_data.
4577         * tui/tui-win.c
4578         (tui_data_window::do_make_visible_with_new_height): Update.
4579         * tui/tui-regs.c (tui_show_registers): Update.
4580         * tui/tui-layout.c (tui_set_layout): Update.
4581         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4582         method.
4583
4584 2019-07-17  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4587         * tui/tui-windata.c (tui_display_data_from): Remove.
4588         (tui_data_window::refresh_all): Update.
4589
4590 2019-07-17  Tom Tromey  <tom@tromey.com>
4591
4592         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4593         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4594         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4595         tui_display_registers_from_line.
4596         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4597         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4598         "force_display" parameter.
4599
4600 2019-07-17  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4603         declare.
4604         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4605         Rename from tui_first_reg_element_no_inline.
4606         (tui_display_reg_element_at_line)
4607         (tui_display_registers_from_line): Update.
4608         * tui/tui-data.h (struct tui_data_window)
4609         <first_reg_element_no_inline>: New method.
4610
4611 2019-07-17  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-windata.c (tui_display_data_from)
4614         (tui_data_window::do_scroll_vertical): Update.
4615         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4616         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4617         Rename from tui_line_from_reg_element_no.
4618         (tui_display_registers_from_line): Update.
4619         * tui/tui-data.h (struct tui_data_window)
4620         <line_from_reg_element_no>: New method.
4621
4622 2019-07-17  Tom Tromey  <tom@tromey.com>
4623
4624         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4625         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4626         tui_last_regs_line_no.
4627         (tui_display_reg_element_at_line)
4628         (tui_display_registers_from_line): Update.
4629         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4630         method.
4631
4632 2019-07-17  Tom Tromey  <tom@tromey.com>
4633
4634         PR tui/24722:
4635         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4636         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4637         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4638         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4639         (tui_update_breakpoint_info): Likewise.
4640         * tui/tui-hooks.c (tui_event_create_breakpoint)
4641         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4642         Update.
4643
4644 2019-07-17  Tom Tromey  <tom@tromey.com>
4645
4646         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4647
4648 2019-07-17  Tom Tromey  <tom@tromey.com>
4649
4650         * tui/tui-winsource.c (tui_update_source_window_as_is)
4651         (tui_update_source_windows_with_addr): Update.
4652         * tui/tui-source.h (tui_set_source_content)
4653         (tui_show_symtab_source): Add "win_info" parameter.
4654         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4655         parameter.
4656         (tui_show_symtab_source): Likewise.
4657
4658 2019-07-17  Tom Tromey  <tom@tromey.com>
4659
4660         * tui/tui-wingeneral.c
4661         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4662
4663 2019-07-17  Tom Tromey  <tom@tromey.com>
4664
4665         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4666         (struct tui_cmd_window) <can_scroll>: New method.
4667         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4668         method.
4669
4670 2019-07-17  Tom Tromey  <tromey@adacore.com>
4671
4672         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4673         do_field_signed>: Rename.  Change type of "value".
4674         * ui-out.c (ui_out::field_signed): Rename from field_int.
4675         Change type of "value".
4676         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4677         type of "value".
4678         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4679         do_field_int.  Change type of "value".
4680         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4681         do_field_int.  Change type of "value".
4682         * tracepoint.c (trace_status_mi, tfind_1)
4683         (print_one_static_tracepoint_marker): Update.
4684         * thread.c (print_thread_info_1, print_selected_thread_frame):
4685         Update.
4686         * stack.c (print_frame, print_frame_info): Update.
4687         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4688         Update.
4689         * source.c (print_source_lines_base): Update.
4690         * skip.c (info_skip_command): Update.
4691         * record-btrace.c (btrace_ui_out_decode_error)
4692         (btrace_call_history_src_line): Update.
4693         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4694         Update.
4695         * progspace.c (print_program_space): Update.
4696         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4697         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4698         do_field_int.  Change type of "value".
4699         * mi/mi-out.c (mi_ui_out::do_table_begin)
4700         (mi_ui_out::do_table_header): Update.
4701         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4702         type of "value".
4703         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4704         (mi_cmd_data_list_changed_registers, output_register)
4705         (mi_cmd_data_read_memory, mi_load_progress)
4706         (mi_cmd_trace_frame_collected): Update.
4707         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4708         Update.
4709         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4710         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4711         (mi_cmd_var_list_children, varobj_update_one): Update.
4712         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4713         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4714         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4715         * inferior.c (print_inferior): Update.
4716         * gdb_bfd.c (print_one_bfd): Update.
4717         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4718         Update.
4719         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4720         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4721         do_field_int.  Change type of "value".
4722         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4723         do_field_int.  Change type of "value".
4724         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4725         (print_one_breakpoint_location, print_it_catch_fork)
4726         (print_one_catch_fork, print_it_catch_vfork)
4727         (print_one_catch_vfork, print_it_catch_solib)
4728         (print_it_catch_exec, print_it_ranged_breakpoint)
4729         (print_mention_watchpoint, print_mention_masked_watchpoint)
4730         (bkpt_print_it, update_static_tracepoint): Update.
4731         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4732         * break-catch-syscall.c (print_it_catch_syscall): Update.
4733         * ada-tasks.c (print_ada_task_info): Update.
4734         * ada-lang.c (print_it_exception, print_mention_exception):
4735         Update.
4736
4737 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         PR breakpoints/24541
4740         * gdbarch.c: Regenerate.
4741         * gdbarch.h: Regenerate.
4742         * gdbarch.sh: Adjust return type and parameter types for
4743         'stap_adjust_register'.
4744         (i386_stap_adjust_register): Adjust signature and return new
4745         register name.
4746         * stap-probe.c (stap_parse_register_operand): Adjust use of
4747         'gdbarch_stap_adjust_register'.
4748
4749 2019-07-17  Tom Tromey  <tromey@adacore.com>
4750
4751         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4752         declare VEC.
4753         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4754         std::vector.
4755         (struct s390_process_info): Add initializers.
4756         (s390_add_process): Use new.
4757         (s390_linux_nat_target::low_forget_process): Use delete.
4758         (s390_linux_nat_target::low_new_fork)
4759         (s390_linux_nat_target::stopped_by_watchpoint)
4760         (s390_linux_nat_target::low_prepare_to_resume)
4761         (s390_linux_nat_target::insert_watchpoint)
4762         (s390_linux_nat_target::insert_hw_breakpoint)
4763         (s390_linux_nat_target::remove_watchpoint)
4764         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4765
4766 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4767
4768         * aarch64-fbsd-nat.c: Include regcache.h.
4769         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4770         argument.
4771         (aarch64_fbsd_nat_target::fetch_registers)
4772         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4773         variable.
4774         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4775
4776 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4777
4778         * fbsd-nat.c: Include gdbarch.h.
4779
4780 2019-07-15  Tom Tromey  <tromey@adacore.com>
4781
4782         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4783
4784 2019-07-15  Tom Tromey  <tromey@adacore.com>
4785
4786         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4787         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4788         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4789         * cli-out.c (cli_ui_out::do_field_int): New method.
4790         * ui-out.c (ui_out::field_unsigned): New method.
4791         * symfile.c (generic_load): Use field_unsigned.
4792         (print_transfer_performance): Likewise.
4793         * record-btrace.c (ui_out_field_uint): Remove.
4794         (btrace_call_history_insn_range, btrace_call_history): Use
4795         field_unsigned.
4796         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4797         field_unsigned.
4798         * ui-out.h (class ui_out) <field_unsigned>: New method.
4799         <do_field_unsigned>: Likewise.
4800
4801 2019-07-15  Tom Tromey  <tromey@adacore.com>
4802
4803         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4804         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4805         * target.c (flash_erase_command): Use field_string.
4806         * infrun.c (print_signal_received_reason): Use field_string.
4807         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4808         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4809         field_string.
4810         * ada-tasks.c (print_ada_task_info): Use field_string.
4811
4812 2019-07-15  Tom Tromey  <tromey@adacore.com>
4813
4814         * target.c (flash_erase_command): Use field_core_addr.
4815         * symfile.c (generic_load): Use field_core_addr.
4816         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4817         Use field_core_addr.
4818         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4819         field_core_addr.
4820
4821 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4822
4823         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4824         value if its desired type is smaller than a CORE_ADDR and signed.
4825
4826 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4827
4828         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4829         of changes to field names, and use new is_reference field to
4830         decide if a property is a reference or not.
4831         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4832         field.
4833         (struct dwarf2_property_baton): Update header comment, rename
4834         'referenced_type' to 'property_type' and update comments.
4835         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4836         default property type, store in property baton, update to take
4837         accound of renamed field.
4838         (read_func_scope): Update call to attr_to_dynamic_prop.
4839         (read_array_type): Likewise.
4840         (dwarf2_per_cu_addr_sized_int_type): New function.
4841         (read_subrange_index_type): Move type finding code to
4842         dwarf2_per_cu_addr_sized_int_type.
4843         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4844         (dwarf2_per_cu_addr_type): New function.
4845         (set_die_type): Update calls to attr_to_dynamic_prop.
4846
4847 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4848
4849         * dwarf2read.c (read_subrange_index_type): New function.
4850         (read_subrange_type): Move code into new function and call it.
4851         * gdbtypes.c (create_range_type): Add some asserts.
4852
4853 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4854
4855         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4856         update return statements.
4857         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4858         declaration, and update comment to match.
4859         * gdbtypes.c (resolve_dynamic_array): Update call to
4860         dwarf2_evaluate_property to match new return type.
4861
4862 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * valarith.c (value_subscripted_rvalue): Change lowerbound
4865         parameter type from int to LONGEST.
4866         * value.h (value_subscripted_rvalue): Likewise in declaration.
4867
4868 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4869
4870         * cli/cli-utils.c (info_print_command_completer): New function.
4871         * cli/cli-utils.h: Add 'completer.h' include, and forward
4872         declaration for 'struct cmd_list_element'.
4873         (info_print_command_completer): Declare.
4874         * stack.c (_initialize_stack): Add completer for 'info locals' and
4875         'info args'.
4876         * symtab.c (_initialize_symtab): Add completer for 'info
4877         variables' and 'info functions'.
4878         * NEWS: Mention completion for additional info commands.
4879
4880 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * cli/cli-utils.c (extract_info_print_args): Delete.
4883         (extract_arg_maybe_quoted): Delete.
4884         (info_print_options_defs): New variable.
4885         (make_info_print_options_def_group): New function.
4886         (extract_info_print_options): Define new function.
4887         * cli/cli-utils.h (extract_info_print_args): Delete.
4888         (struct info_print_options): New structure.
4889         (extract_info_print_options): Declare new function.
4890         * stack.c (info_locals_command): Update to use new
4891         extract_info_print_options, also add a header comment.
4892         (info_args_command): Likewise.
4893         * symtab.c (info_variables_command): Likewise.
4894         (info_functions_command): Likewise.
4895
4896 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4899         to extract string arguments.
4900         * common/common-utils.c (extract_string_maybe_quoted): New function.
4901         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4902
4903 2019-07-11  Tom Tromey  <tromey@adacore.com>
4904
4905         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4906         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4907         * top.h (gdbinit): Don't declare.
4908         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4909         into...
4910         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4911         * top.c (gdb_init): Don't call init_cli_cmds.
4912         (gdbinit): Remove.
4913         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4914
4915 2019-07-11  Tom Tromey  <tromey@adacore.com>
4916
4917         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4918         after it has been moved.
4919
4920 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4921
4922         * valops.c (value_must_coerce_to_target): Change return type to
4923         bool.
4924         * value.h (value_must_coerce_to_target): Likewise.
4925
4926 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * breakpoint.c (is_hardware_watchpoint): Remove
4929         forward-declaration.
4930         (is_masked_watchpoint): Change return type to bool.
4931         (is_tracepoint): Likewise.
4932         (is_breakpoint): Likewise.
4933         (is_hardware_watchpoint): Likewise.
4934         (is_watchpoint): Likewise.
4935         (is_no_memory_software_watchpoint): Likewise.
4936         (is_catchpoint): Likewise.
4937         (breakpoint_1): Make FILTER parameter's return type bool.
4938         is_masked_watchpoint): Change return type to bool.
4939         (save_breakpoints): Make FILTER parameter's return type bool.
4940         * breakpoint.h (is_breakpoint): Change return type to bool.
4941         (is_watchpoint): Likewise.
4942         (is_catchpoint): Likewise.
4943         (is_tracepoint): Likewise.
4944
4945 2019-07-10  Tom Tromey  <tom@tromey.com>
4946
4947         * defs.h: Don't include gdbarch.h.
4948         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4949         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4950         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4951         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4952         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4953         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4954         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4955         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4956         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4957         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4958         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4959         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4960         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4961         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4962         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4963         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4964         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4965         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4966         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4967         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4968         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4969         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4970         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4971         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4972         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4973         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4974         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4975
4976 2019-07-10  Tom Tromey  <tromey@adacore.com>
4977
4978         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4979         * breakpoint.c (init_ada_exception_breakpoint): Register as
4980         bp_catchpoint.
4981         (print_one_breakpoint_location, print_one_breakpoint): Use
4982         is_ada_exception_catchpoint.
4983         * ada-lang.c (class ada_catchpoint_location): Pass
4984         bp_loc_software_breakpoint to bp_location constructor.
4985         (is_ada_exception_catchpoint): New function.
4986
4987 2019-07-10  Tom Tromey  <tromey@adacore.com>
4988
4989         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4990         VEC.
4991         (struct arm_exidx_entry): New method operator<.
4992         (struct arm_exidx_data) <section_maps>: Change type.
4993         (arm_exidx_data_free): Remove.
4994         (arm_exidx_data_key): Change type.  Move lower.
4995         (arm_exidx_new_objfile): Update.
4996         (arm_compare_exidx_entries): Remove.
4997         (arm_find_exidx_entry, _initialize_arm_tdep)
4998
4999 2019-07-10  Tom Tromey  <tromey@adacore.com>
5000
5001         * solib-spu.c (ocl_program_data_key): Change type.
5002         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5003         Update.
5004
5005 2019-07-10  Tom Tromey  <tromey@adacore.com>
5006
5007         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5008         (struct solib_aix_inferior_data) <library_list>: Change type.
5009         (solib_aix_inferior_data_handle): Change type.
5010         (get_solib_aix_inferior_data): Update.
5011         (solib_aix_free_library_list): Remove.
5012         (library_list_start_library): Update.
5013         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5014         return type.
5015         (solib_aix_get_library_list)
5016         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5017         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5018
5019 2019-07-10  Tom Tromey  <tromey@adacore.com>
5020
5021         * solib-dsbt.c (struct dsbt_info): Add initializers.
5022         (solib_dsbt_pspace_data): Change type.
5023         (dsbt_pspace_data_cleanup): Remove.
5024         (get_dsbt_info, _initialize_dsbt_solib): Update.
5025
5026 2019-07-10  Tom Tromey  <tromey@adacore.com>
5027
5028         * spu-tdep.c (spu_overlay_data): Change type.
5029         (spu_get_overlay_table, spu_overlay_new_objfile)
5030         (_initialize_spu_tdep): Update.
5031
5032 2019-07-10  Tom Tromey  <tromey@adacore.com>
5033
5034         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5035         destructor.
5036         (dbx_objfile_data_key): Change type and declare later.
5037         (DBX_SYMFILE_INFO): Rewrite.
5038         * dbxread.c (dbx_objfile_data_key): Change type.
5039         (dbx_symfile_init): Update.
5040         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5041         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5042         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5043
5044 2019-07-10  Tom Tromey  <tromey@adacore.com>
5045
5046         * jit.c (jit_program_space_key): Change type.  Move lower.
5047         (get_jit_program_space_data): Update.
5048         (jit_program_space_data_cleanup): Remove.
5049         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5050         Update.
5051         (struct jit_program_space_data): Add initializers.
5052
5053 2019-07-10  Tom Tromey  <tromey@adacore.com>
5054
5055         * solib-darwin.c (struct darwin_info): Add initializers.
5056         (solib_darwin_pspace_data): Change type.
5057         (darwin_pspace_data_cleanup): Remove.
5058         (get_darwin_info, _initialize_darwin_solib): Update.
5059
5060 2019-07-10  Tom Tromey  <tromey@adacore.com>
5061
5062         * remote-sim.c (struct sim_inferior_data): Add initializers,
5063         constructor, and destructor.
5064         (sim_inferior_data_key): Change type.  Move lower.
5065         (check_for_duplicate_sim_descriptor): Update.
5066         (get_sim_inferior_data): Use new.  Update.
5067         (~sim_inferior_data_cleanup): Rename from
5068         sim_inferior_data_cleanup.  Simplify.
5069         (gdbsim_close_inferior, simulator_command)
5070         (sim_command_completer, _initialize_remote_sim): Update.
5071         (next_pid, INITIAL_PID): Move earlier.
5072
5073 2019-07-10  Tom Tromey  <tromey@adacore.com>
5074
5075         * python/python-internal.h (create_thread_object): Return
5076         gdbpy_ref.
5077         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5078         * python/py-inferior.c (struct threadlist_entry): Add
5079         constructor.
5080         <thread_obj>: Now a gdbpy_ref.
5081         (thread_to_thread_object): Update.
5082         (add_thread_object): Use new.
5083         (delete_thread_object): Use delete.
5084         (infpy_threads): Update.
5085         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5086         GIL.
5087
5088 2019-07-10  Tom Tromey  <tromey@adacore.com>
5089
5090         * valops.c (value_cast): Specialize error message for Ada.
5091
5092 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5093
5094         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5095
5096 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5097
5098         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5099         bpstat_should_step): Return bool, adjust comments.
5100         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5101         bpstat_should_step): Likewise.
5102
5103 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5104
5105         * features/Makefile: Use feature target descriptions for Arm.
5106         * features/arm/arm-core.c: Generate new file.
5107         * features/arm/arm-fpa.c: Likewise.
5108         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5109         * features/arm/arm-m-profile.c: Likewise.
5110         * features/arm/arm-vfpv2.c: Likewise.
5111         * features/arm/arm-vfpv3.c: Likewise.
5112         * features/arm/xscale-iwmmxt.c: Likewise.
5113         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5114
5115 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5116
5117         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5118         ptrace earlier.
5119
5120 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5121
5122         * features/aarch64-pauth.c: Regenerate.
5123
5124 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5125
5126         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5127         bool.
5128         (bpstat_what): Use false instead of 0.
5129
5130 2019-07-09  Pedro Alves  <palves@redhat.com>
5131
5132         * break-catch-throw.c (is_exception_catchpoint): New.
5133         * breakpoint.c (print_one_breakpoint_location): New parameter
5134         'raw_loc'.  Handle it.  Use
5135         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5136         looking at the breakpoint's type.
5137         (print_one_breakpoint): If handling "maint info breakpoints", also
5138         print locations of exception catchpoints.
5139         * breakpoint.h (is_exception_catchpoint): Declare.
5140
5141 2019-07-09  Pedro Alves  <palves@redhat.com>
5142
5143         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5144         "addr" field.
5145         (allocate_location_exception_catchpoint): New.
5146         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5147         (initialize_throw_catchpoint_ops): Install
5148         allocate_location_exception_catchpoint as allocate_location
5149         method.
5150         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5151         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5152         bp_loc_other.
5153         (breakpoint_address_is_meaningful): Delete.
5154         (bl_address_is_meaningful): New.
5155         (breakpoint_locations_match): Adjust comment.
5156         (bp_location_from_bp_type): New, factored out of...
5157         (bp_location::bp_location(breakpoint *)): ... this.
5158         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5159         factored out of...
5160         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5161         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5162         breakpoint_address_is_meaningful.
5163         (bp_locations_compare): Adjust comment.
5164         (update_global_location_list): Use bl_address_is_meaningful
5165         instead of breakpoint_address_is_meaningful.
5166         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5167         explicit.
5168         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5169         * python/py-breakpoint.c (bppy_get_location): No longer check
5170         whether location is null.
5171
5172 2019-07-09  Pedro Alves  <palves@redhat.com>
5173
5174         PR c++/15468
5175         * breakpoint.c (print_one_breakpoint_location): Remove
5176         single-location assert.
5177
5178 2019-07-09  Tom Tromey  <tom@tromey.com>
5179
5180         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5181         * configure: Rebuild.
5182         * configure.ac: Change common to gdbsupport.
5183         * gdbsupport: Rename from common.
5184         * acinclude.m4: Change common to gdbsupport.
5185         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5186         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5187         gdbsupport.
5188         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5189         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5190         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5191         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5192         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5193         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5194         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5195         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5196         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5197         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5198         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5199         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5200         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5201         coff-pe-read.c, command.h, compile/compile-c-support.c,
5202         compile/compile-c.h, compile/compile-cplus-symbols.c,
5203         compile/compile-cplus-types.c, compile/compile-cplus.h,
5204         compile/compile-loc2c.c, compile/compile.c, completer.c,
5205         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5206         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5207         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5208         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5209         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5210         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5211         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5212         features/aarch64-core.c, features/aarch64-fpu.c,
5213         features/aarch64-pauth.c, features/aarch64-sve.c,
5214         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5215         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5216         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5217         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5218         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5219         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5220         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5221         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5222         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5223         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5224         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5225         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5226         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5227         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5228         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5229         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5230         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5231         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5232         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5233         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5234         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5235         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5236         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5237         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5238         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5239         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5240         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5241         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5242         minsyms.c, mips-linux-tdep.c, namespace.h,
5243         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5244         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5245         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5246         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5247         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5248         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5249         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5250         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5251         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5252         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5253         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5254         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5255         procfs.c, producer.c, progspace.h, psymtab.h,
5256         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5257         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5258         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5259         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5260         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5261         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5262         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5263         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5264         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5265         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5266         target-memory.c, target.c, target.h, target/waitstatus.c,
5267         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5268         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5269         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5270         unittests/array-view-selftests.c,
5271         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5272         unittests/common-utils-selftests.c,
5273         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5274         unittests/format_pieces-selftests.c,
5275         unittests/function-view-selftests.c,
5276         unittests/lookup_name_info-selftests.c,
5277         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5278         unittests/mkdir-recursive-selftests.c,
5279         unittests/observable-selftests.c,
5280         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5281         unittests/parse-connection-spec-selftests.c,
5282         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5283         unittests/scoped_fd-selftests.c,
5284         unittests/scoped_mmap-selftests.c,
5285         unittests/scoped_restore-selftests.c,
5286         unittests/string_view-selftests.c, unittests/style-selftests.c,
5287         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5288         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5289         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5290         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5291         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5292         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5293
5294 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5295
5296         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5297         bool value.
5298         (decode_digits_ordinary): Set explicit_line field in sal.
5299         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5300         symtab_and_line that was set on an explicit line number in
5301         assembler code.  Do always update the recorded symtab and line if
5302         we do skip the prologue.
5303
5304 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * breakpoint.c (set_breakpoint_location_function): Remove
5307         explicit_loc parameter.
5308         (momentary_breakpoint_from_master): Update call to
5309         set_breakpoint_location_function.
5310         (add_location_to_breakpoint): Likewise.
5311
5312 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5313
5314         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5315         required features based on default bfd type when no specific bfd
5316         is present.
5317
5318 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5319
5320         * NEWS: Mention that GDB printf and eval commands can now print
5321         C-style and Ada-style convenience var strings without
5322         calling the inferior.
5323         * printcmd.c (printf_c_string): Locally print GDB internal var
5324         instead of transiting via the inferior.
5325         (printf_wide_c_string): Likewise.
5326
5327 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5328
5329         PR breakpoints/25011
5330         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5331
5332 2019-07-04  Tom Tromey  <tom@tromey.com>
5333
5334         PR tui/24724:
5335         * tui/tui-winsource.c (tui_clear_source_content): Update.
5336         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5337         (tui_update_breakpoint_info): Update.
5338         (tui_set_exec_info_content): Update.
5339         * tui/tui-source.c (tui_set_source_content_nil): Update.
5340         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5341         has_break.
5342         * tui/tui-data.h (enum tui_bp_flag): New.
5343         (tui_bp_flags): New enum flags type.
5344         (struct tui_source_element) <break_mode>: Change type.  Rename
5345         from has_break.
5346         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5347         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5348         constants.
5349         * tui/tui-winsource.h: Fix comment.
5350
5351 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5352
5353         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5354         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5355         (store_fpregs_to_thread)
5356         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5357         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5358         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5359         (IWMMXT_REGS_SIZE): Add define.
5360         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5361         (fetch_vfp_regs, store_vfp_regs)
5362         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5363         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5364
5365 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5366
5367         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5368         defines.
5369         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5370         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5371         (ARM_INT_REGISTER_SIZE): ...to this.
5372         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5373         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5374         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5375         (arm_linux_collect_gregset, supply_nwfpe_register)
5376         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5377         defines.
5378         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5379         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5380         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5381         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5382         (arm_return_in_memory, arm_store_return_value)
5383         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5384         (arm_record_ld_st_multiple): Likewise.
5385         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5386         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5387
5388 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5389
5390         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5391         AARCH64_DISPLACED_MODIFIED_INSNS.
5392         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5393         (aarch64_displaced_step_copy_insn): Likewise.
5394         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5395         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5396         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5397         ARM_DISPLACED_MODIFIED_INSNS.
5398         * arm-tdep.c (arm_gdbarch_init): Likewise.
5399         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5400         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5401         (struct arm_displaced_step_closure): Use
5402         ARM_DISPLACED_MODIFIED_INSNS.
5403
5404 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5405
5406         * features/Makefile: Remove unused xml files.
5407         * features/aarch64.xml: Remove.
5408         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5409         * features/i386/amd64-avx-avx512.xml: Remove.
5410         * features/i386/amd64-avx-linux.xml: Remove.
5411         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5412         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5413         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5414         * features/i386/amd64-avx-mpx.xml: Remove.
5415         * features/i386/amd64-avx.xml: Remove.
5416         * features/i386/amd64-linux.xml: Remove.
5417         * features/i386/amd64-mpx-linux.xml: Remove.
5418         * features/i386/amd64-mpx.xml: Remove.
5419         * features/i386/amd64.xml: Remove.
5420         * features/i386/i386-avx-avx512-linux.xml: Remove.
5421         * features/i386/i386-avx-avx512.xml: Remove.
5422         * features/i386/i386-avx-linux.xml: Remove.
5423         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5424         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5425         * features/i386/i386-avx-mpx-linux.xml: Remove.
5426         * features/i386/i386-avx-mpx.xml: Remove.
5427         * features/i386/i386-avx.xml: Remove.
5428         * features/i386/i386-linux.xml: Remove.
5429         * features/i386/i386-mmx-linux.xml: Remove.
5430         * features/i386/i386-mmx.xml: Remove.
5431         * features/i386/i386-mpx-linux.xml: Remove.
5432         * features/i386/i386-mpx.xml: Remove.
5433         * features/i386/i386.xml: Remove.
5434         * features/i386/x32-avx-avx512-linux.xml: Remove.
5435         * features/i386/x32-avx-linux.xml: Remove.
5436         * features/i386/x32-linux.xml: Remove.
5437
5438 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5439
5440         * regformats/aarch64.dat: Remove.
5441         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5442         * regformats/i386/amd64-avx-linux.dat: Remove.
5443         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5444         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5445         * regformats/i386/amd64-linux.dat: Remove.
5446         * regformats/i386/amd64-mpx-linux.dat: Remove.
5447         * regformats/i386/amd64.dat: Remove.
5448         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5449         * regformats/i386/i386-avx-linux.dat: Remove.
5450         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5451         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5452         * regformats/i386/i386-linux.dat: Remove.
5453         * regformats/i386/i386-mmx-linux.dat: Remove.
5454         * regformats/i386/i386-mpx-linux.dat: Remove.
5455         * regformats/i386/i386.dat: Remove.
5456         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5457         * regformats/i386/x32-avx-linux.dat: Remove.
5458         * regformats/i386/x32-linux.dat: Remove.
5459
5460 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5461
5462         * aarch64-tdep.c: Remove xml self tests.
5463         * amd64-linux-tdep.c: Likewise.
5464         * amd64-tdep.c: Likewise.
5465         * i386-linux-tdep.c: Likewise.
5466         * i386-tdep.c: Likewise.
5467
5468 2019-07-03  Pedro Alves  <palves@redhat.com>
5469
5470         PR cli/24732
5471         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5472         (pipe_cmd_option_defs): New.
5473         (make_pipe_cmd_options_def_group): New.
5474         (pipe_command): Use gdb::option::process_options.
5475         (pipe_command_completer): New function.
5476         (_initialize_cli_cmds): Install completer for "pipe" command.
5477
5478 2019-07-03  Pedro Alves  <palves@redhat.com>
5479
5480         * cli/cli-option.c (union option_value) <string>: New field.
5481         (struct option_def_and_value): Add ctor, move ctor, dtor and
5482         use DISABLE_COPY_AND_ASSIGN.
5483         (option_def_and_value::clear_value): New.
5484         (parse_option, save_option_value_in_ctx, get_val_type_str)
5485         (add_setshow_cmds_for_options): Handle var_string.
5486         * cli-option.h (union option_def::var_address) <string>: New
5487         field.
5488         (struct string_option_def): New.
5489         * maint-test-options.c (struct test_options_opts): Add default
5490         ctor and use DISABLE_COPY_AND_ASSIGN.
5491         <string_opt>: New field.
5492         (test_options_opts::~test_options_opts): New.
5493         (test_options_opts::dump): Also dump "-string".
5494         (test_options_option_defs): Install "string.
5495
5496 2019-07-03  Pedro Alves  <palves@redhat.com>
5497
5498         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5499         option_value with a null enumeration.
5500         (complete_options): Save the option values in the context.
5501         (save_option_value_in_ctx): New, factored out from ...
5502         (process_options): ... here.
5503         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5504         of the function.
5505         * maint-test-options.c (test_options_opts::dump): New, factored
5506         out from ...
5507         (maintenance_test_options_command_mode): ... here.
5508         (maintenance_test_options_command_completion_result): Delete.
5509         (maintenance_test_options_command_completion_text): Update
5510         comment.
5511         (maintenance_show_test_options_completion_result): Change
5512         prototype.  Just print
5513         maintenance_test_options_command_completion_text.
5514         (save_completion_result): New.
5515         (maintenance_test_options_completer_mode): Pass options context to
5516         complete_options, and then save a dump.
5517         (_initialize_maint_test_options): Use add_cmd to install "maint
5518         show test-options-completion-result".
5519
5520 2019-07-03  Pedro Alves  <palves@redhat.com>
5521
5522         * NEWS (New commands): Mention "with" and "maint with".
5523         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5524         (with_command, with_command_completer): New.
5525         (pipe_command): Adjust to new repeat_previous
5526         interface.
5527         (_initialize_cli_cmds): Install the "with" command and its "w"
5528         alias.
5529         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5530         declarations.
5531         * cli/cli-setshow.c (parse_cli_var_uinteger)
5532         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5533         argument strings for all var_types.
5534         (get_setshow_command_value_string): New, factored out from ...
5535         (do_show_command): ... this.
5536         * cli/cli-setshow.h: Include <string>.
5537         (get_setshow_command_value_string): Declare.
5538         * command.h (repeat_previous): Now returns const char *.  Adjust
5539         comment.
5540         * maint.c: Include "cli/cli-cmds.h".
5541         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5542         (_initialize_maint_cmds): Register the "maintenance with" command.
5543         * top.c (repeat_previous): Move bits from pipe_command here:
5544         Return the saved command line, if any; error out if there's no
5545         command to relaunch.
5546
5547 2019-07-03  Pedro Alves  <palves@redhat.com>
5548
5549         * NEWS (New commands): Mention "maint set/show test-settings"
5550         instead of "maint test-settings".
5551         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5552         (maintenance_test_settings_set_list): Rename to ...
5553         (maintenance_set_test_settings_list): ... this.
5554         (maintenance_test_settings_show_list): Rename to  ...
5555         (maintenance_show_test_settings_list): ... this.
5556         (maintenance_test_settings_cmd): Delete.
5557         (maintenance_test_settings_set_cmd): ...
5558         (maintenance_set_test_settings_cmd): ... this.
5559         (maintenance_test_settings_show_cmd): ...
5560         (maintenance_show_test_settings_cmd): ... this.
5561         (maintenance_test_settings_show_value_cmd):
5562         (maintenance_show_test_settings_value_cmd): ... this.
5563         (_initialize_maint_test_settings): No longer install the "maint
5564         test-settings" prefix command.  Rename "maint test-settings set"
5565         to "maint set test-settings", and "maint test-settings show" to
5566         "maint show test-settings".  Adjust all subcommands.
5567
5568 2019-07-03  Pedro Alves  <palves@redhat.com>
5569
5570         * maint-test-settings.c: Fix file's intro comment.  Replace all
5571         references to "test-options" with references to "test-settings",
5572         in comments.
5573
5574 2019-07-03  Pedro Alves  <palves@redhat.com>
5575
5576         * maint-test-settings.c (maintenance_test_settings_xxx)
5577         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5578         New.
5579         (maintenance_test_settings_enums): Use them.
5580         (maintenance_test_settings_enum): Default to
5581         maintenance_test_settings_xxx.
5582         (_initialize_maint_test_settings): Initialize
5583         MAINTENANCE_TEST_SETTINGS_FILENAME.
5584
5585 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5586
5587         * breakpoint.h (remove_breakpoints_inf): Change return type to
5588         void, move function documentation here.
5589         * breakpoint.c (remove_breakpoints_inf): Change return type to
5590         void, move function documentation to header.
5591
5592 2019-07-02  Pedro Alves  <palves@redhat.com>
5593
5594         * NEWS (Completion improvements): Mention "info threads".
5595         * thread.c (struct info_threads_opts, info_threads_option_defs)
5596         (make_info_threads_options_def_group): New.
5597         (info_threads_command): Use gdb::option::process_options.
5598         (info_threads_command_completer): New.
5599         (_initialize_thread): Use gdb::option::build_help to build the
5600         help text for "info threads".
5601
5602 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5603
5604         * defs.h (generic_load): Move from here...
5605         * symfile.h (generic_load): ... to here.  Rename name parameter
5606         to args.
5607         * symfile.c (generic_load): Add comment.
5608
5609 2019-07-01  Tom Tromey  <tromey@adacore.com>
5610
5611         * dwarf2read.c
5612         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5613         declaration of without_params.  Fix formatting.
5614
5615 2019-07-01  Tom Tromey  <tromey@adacore.com>
5616
5617         * ada-exp.y (find_primitive_type): Update.
5618         * ada-lang.h (ada_lookup_symbol): Update.
5619         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5620         parameter.
5621         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5622
5623 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5624
5625         PR breakpoints/24541
5626         * gdbarch.c: Regenerate.
5627         * gdbarch.h: Regenerate.
5628         * gdbarch.sh: Add 'stap_adjust_register'.
5629         * i386-tdep.c: Include '<unordered_set>'.
5630         (i386_stap_adjust_register): New function.
5631         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5632         * stap-probe.c (stap_parse_register_operand): Call
5633         'gdbarch_stap_adjust_register'.
5634
5635 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5636
5637         PR python/24742
5638         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5639         * python/python.c (do_start_initialization): Use 'xmalloc'
5640         instead of 'PyMem_Malloc'.
5641
5642 2019-06-28  Tom Tromey  <tromey@adacore.com>
5643
5644         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5645         for Ada.
5646
5647 2019-06-27  Tom Tromey  <tromey@adacore.com>
5648
5649         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5650         objfile_key.
5651         (arm_find_mapping_symbol, arm_record_special_symbol)
5652         (_initialize_arm_tdep): Update.
5653         (arm_objfile_data_free): Remove.
5654
5655 2019-06-27  Tom Tromey  <tromey@adacore.com>
5656
5657         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5658         to cp_print_static_field.
5659
5660 2019-06-26  Tom Tromey  <tromey@adacore.com>
5661
5662         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5663         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5664         declare.
5665
5666 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5667
5668         * features/aarch64-core.c (create_feature_aarch64_core):
5669         Regenerate.
5670         * features/aarch64-core.xml: Add cpsr flags.
5671
5672 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5673
5674         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5675         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5676
5677 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5678
5679         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5680         field.
5681         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5682         use.
5683         (arm_record_special_symbol): Don't insert new symbol in sorted
5684         position, push it at the end.
5685
5686 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5687
5688         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5689         (arm_mapping_symbol_s): Remove.
5690         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5691         (arm_mapping_symbol_vec): New typedef.
5692         (struct arm_per_objfile): Add constructor.
5693         <section_maps>: Change type to
5694         std::unique_ptr<arm_mapping_symbol_vec[]>.
5695         (arm_compare_mapping_symbols): Remove.
5696         (arm_find_mapping_symbol): Adjust to section_maps type change.
5697         (arm_objfile_data_free): Call delete on arm_per_objfile.
5698         (arm_record_special_symbol): Adjust to section_maps type change.
5699         Allocate arm_per_objfile with new.
5700
5701 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5702
5703         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5704         with the command prefix.
5705
5706 2019-06-25  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5709         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5710
5711 2019-06-25  Tom Tromey  <tom@tromey.com>
5712
5713         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5714         type.
5715         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5716         protected.
5717
5718 2019-06-25  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-winsource.c
5721         (tui_source_window_base::set_is_exec_point_at): Add check against
5722         LOA_ADDRESS.
5723
5724 2019-06-25  Tom Tromey  <tom@tromey.com>
5725
5726         * tui/tui-source.c (tui_set_source_content): Don't check before
5727         xfree.
5728         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5729
5730 2019-06-25  Tom Tromey  <tom@tromey.com>
5731
5732         * tui/tui-winsource.h (tui_update_source_window_as_is)
5733         (tui_alloc_source_buffer, tui_line_is_displayed)
5734         (tui_addr_is_displayed): Change type of win_info.
5735         * tui/tui-winsource.c (tui_update_source_window_as_is)
5736         (tui_clear_source_content, tui_show_source_line)
5737         (tui_show_source_content, tui_source_window_base::refill)
5738         (tui_source_window_base::set_is_exec_point_at)
5739         (tui_source_window_base::set_is_exec_point_at)
5740         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5741         (tui_alloc_source_buffer, tui_line_is_displayed)
5742         (tui_addr_is_displayed): Change type of win_info.  Update.
5743         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5744         (tui_source_window_base::do_make_visible_with_new_height):
5745         Update.
5746         * tui/tui-source.c (tui_set_source_content)
5747         (tui_set_source_content_nil)
5748         (tui_source_window::do_scroll_vertical): Update.
5749         * tui/tui-layout.c (show_layout): Update.
5750         * tui/tui-disasm.c (tui_set_disassem_content)
5751         (tui_disasm_window::do_scroll_vertical): Update.
5752         * tui/tui-data.h (tui_win_content): Remove.
5753         (struct tui_gen_win_info) <content, content_size>: Remove.
5754         (struct tui_source_element): Add initializers and destructor.
5755         (union tui_which_element, struct tui_win_element): Remove.
5756         (struct tui_source_window_base) <content>: New field.
5757         (struct tui_data_window): Remove destructor.
5758         (tui_alloc_content, tui_free_win_content)
5759         (tui_free_all_source_wins_content): Don't declare.
5760         * tui/tui-data.c (tui_initialize_static_data): Update.
5761         (init_content_element, tui_alloc_content): Remove.
5762         (~tui_gen_win_info): Update.
5763         (~tui_data_window, tui_free_all_source_wins_content)
5764         (tui_free_win_content, free_content, free_content_elements):
5765         Remove.
5766
5767 2019-06-25  Tom Tromey  <tom@tromey.com>
5768
5769         * tui/tui-winsource.h (tui_clear_source_content)
5770         (tui_erase_source_content, tui_show_source_content): Change type
5771         of win_info.
5772         * tui/tui-winsource.c (tui_clear_source_content)
5773         (tui_erase_source_content, tui_show_source_content): Change type
5774         of win_info.
5775         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5776         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5777         win_info.
5778         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5779         win_info.
5780         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5781
5782 2019-06-25  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui-winsource.c (tui_clear_source_content)
5785         (tui_source_window_base::set_is_exec_point_at): Update.
5786         * tui/tui-source.c (tui_set_source_content_nil): Update.
5787         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5788         a bool.
5789         * tui/tui-data.c (init_content_element): Update.
5790
5791 2019-06-25  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5794         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5795         * tui/tui-layout.c (init_and_make_win): Update.
5796         * tui/tui.h (enum tui_win_type): Update.
5797         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5798         tui_win_is_auxillary.
5799         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5800         tui_win_is_auxillary.
5801
5802 2019-06-25  Tom Tromey  <tom@tromey.com>
5803
5804         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5805         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5806         (tui_delete_data_content_windows, tui_display_all_data)
5807         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5808         Update.
5809         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5810         * tui/tui-regs.c (tui_last_regs_line_no)
5811         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5812         (tui_show_registers): Update.
5813         (tui_show_register_group): Return void.  Update.
5814         (tui_display_registers_from, tui_display_reg_element_at_line)
5815         (tui_display_registers_from_line, tui_check_register_values):
5816         Update.
5817         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5818         member.
5819         (struct tui_data_window) <regs_content>: Now a std::vector.
5820         <regs_content_count>: Remove.
5821         (tui_add_content_elements, tui_free_data_content): Don't declare.
5822         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5823         (init_content_element): Remove DATA_WIN case.  Add assert.
5824         (tui_add_content_elements): Remove.
5825         (tui_data_window): Update.
5826         (tui_free_data_content): Remove.
5827         (free_content_elements): Remove DATA_WIN case.
5828
5829 2019-06-25  Tom Tromey  <tom@tromey.com>
5830
5831         * tui/tui-data.c (tui_data_item_window): Update.
5832         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5833         * tui/tui-windata.c (tui_display_all_data)
5834         (tui_display_data_from_line): Update.
5835         (tui_check_data_values): Remove.
5836         * tui/tui-regs.c (tui_show_register_group)
5837         (tui_display_reg_element_at_line): Update.
5838         * tui/tui-hooks.c (tui_register_changed)
5839         (tui_refresh_frame_and_register_information): Call
5840         tui_check_register_values.
5841         * tui/tui-data.h (struct tui_data_window) <data_content,
5842         data_content_count, data_type>: Remove.
5843         (enum tui_data_type): Remove.
5844
5845         * tui/tui-data.c (tui_data_window::clear_detail)
5846         (~tui_data_window): Update.
5847
5848 2019-06-25  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5851         declare.
5852         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5853         Rename from tui_first_data_item_displayed.  Update.
5854         (tui_data_window::refresh_all)
5855         (tui_data_window::do_scroll_vertical): Update.
5856         * tui/tui-data.h (struct tui_data_window)
5857         <first_data_item_displayed>: Declare new method.
5858
5859 2019-06-25  Tom Tromey  <tom@tromey.com>
5860
5861         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5862         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5863         contents...
5864         (tui_initialize_static_data): ...here.
5865
5866 2019-06-25  Tom Tromey  <tom@tromey.com>
5867
5868         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5869         (tui_display_registers_from, tui_check_register_values): Update.
5870         (tui_display_register): Remove win_info parameter; update.
5871         (tui_get_register): Change type of parameters.
5872         * tui/tui-data.h (struct tui_data_element): Remove.
5873         (union tui_which_element) <data>: Remove.
5874         <data_window>: Change type.
5875         (struct tui_data_item_window): New.
5876         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5877         case.  Add assert.
5878         (~tui_data_item_window): New destructor.
5879         (free_content_elements): Remove DATA_ITEM_WIN case.
5880
5881 2019-06-25  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5884         Remove.
5885
5886 2019-06-25  Tom Tromey  <tom@tromey.com>
5887
5888         * tui/tui-data.h (struct tui_command_element): Remove.
5889         (union tui_which_element) <command>: Remove.
5890         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5891         assert.
5892         (free_content_elements): Remove CMD_WIN case.
5893
5894 2019-06-25  Tom Tromey  <tom@tromey.com>
5895
5896         * tui/tui-layout.c (tui_set_layout): Update.
5897         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5898         * tui/tui-data.c (layout_def): Update.
5899
5900 2019-06-25  Tom Tromey  <tom@tromey.com>
5901
5902         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5903         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5904         (tui_source_window_base::set_new_height): Update.
5905         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5906         Update.
5907         (tui_set_locator_fullname, tui_set_locator_info)
5908         (tui_show_frame_info): Update.
5909         * tui/tui-source.c (tui_set_source_content)
5910         (tui_source_is_displayed): Update.
5911         * tui/tui-layout.c (show_source_disasm_command, show_data)
5912         (show_source_or_disasm_and_command): Update.
5913         * tui/tui-disasm.c (tui_set_disassem_content)
5914         (tui_get_begin_asm_address): Update.
5915         * tui/tui-data.h (struct tui_locator_element): Remove.
5916         (union tui_which_element) <locator>: Remove.
5917         (struct tui_locator_window): New.
5918         (tui_locator_win_info_ptr): Change return type.
5919         * tui/tui-data.c (_locator): Change type.
5920         (tui_locator_win_info_ptr): Change return type.
5921         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5922         (tui_alloc_content): Add assert.
5923
5924 2019-06-25  Tom Tromey  <tom@tromey.com>
5925
5926         * tui/tui-winsource.c
5927         (tui_exec_info_window::maybe_allocate_content): New method.
5928         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5929         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5930         (make_source_or_disasm_window): Add cast.
5931         * tui/tui-data.h (union tui_which_element) <simple_string>:
5932         Remove.
5933         (struct tui_source_info): New.
5934         (struct tui_source_window_base) <execution_info>: Change type.
5935         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5936         case, and add assert.
5937         (tui_alloc_content): Add assert.
5938
5939 2019-06-25  Tom Tromey  <tom@tromey.com>
5940
5941         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5942         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5943         * tui/tui-data.c (tui_alloc_win_info): Remove.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5948         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5949         can_highlight.
5950
5951 2019-06-25  Tom Tromey  <tom@tromey.com>
5952
5953         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5954         make_visible_with_new_height method.
5955         (tui_win_info::make_visible_with_new_height): New method.
5956         (tui_source_window_base::do_make_visible_with_new_height)
5957         (tui_data_window::do_make_visible_with_new_height)
5958         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5959         (make_visible_with_new_height): Remove.
5960         (tui_resize_all, tui_adjust_win_heights): Use
5961         make_visible_with_new_height method.
5962         * tui/tui-data.h (struct tui_win_info)
5963         <do_make_visible_with_new_height, make_visible_with_new_height>:
5964         New methods.
5965         (struct tui_source_window_base, struct tui_data_window)
5966         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5967         methods.
5968
5969 2019-06-25  Tom Tromey  <tom@tromey.com>
5970
5971         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5972         method.
5973         (update_tab_width): Call update_tab_width method.
5974         * tui/tui-data.h (struct tui_win_info)
5975         (struct tui_source_window_base) <update_tab_width>: New methods.
5976
5977 2019-06-25  Tom Tromey  <tom@tromey.com>
5978
5979         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5980         parameter.
5981         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5982         parameter.
5983         (tui_gen_win_info::make_visible): Update.
5984         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5985         parameter.
5986         * tui/tui-data.h (enum tui_box): New enum.
5987         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5988
5989 2019-06-25  Tom Tromey  <tom@tromey.com>
5990
5991         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5992         init_and_make_win for EXEC_INFO_WIN.
5993         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5994         longer inline.
5995         (struct tui_win_info) <~tui_win_info>: Inline.
5996         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5997         Don't declare.
5998         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5999         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6000         Remove.
6001         (tui_initialize_static_data): Update.
6002         (~tui_gen_win_info): Handle more cleanup here.
6003         (~tui_source_window_base): Delete "execution_info".
6004         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6005
6006 2019-06-25  Tom Tromey  <tom@tromey.com>
6007
6008         * tui/tui-layout.c (make_command_window): Don't set
6009         can_highlight.
6010         (show_source_disasm_command): Call the reset method.
6011         (show_data): Don't set can_highlight.  Call the reset method.
6012         (tui_gen_win_info::reset): Rename from init_gen_win_info
6013         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6014         (show_source_or_disasm_and_command): Call the reset method.
6015         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6016         (struct tui_cmd_window): Set can_highlight.
6017
6018 2019-06-25  Tom Tromey  <tom@tromey.com>
6019
6020         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6021         from make_visible.
6022         (tui_make_visible, tui_make_invisible): Rewrite.
6023         (tui_win_info::make_visible): Remove.
6024         (tui_source_window_base::make_visible): Update.
6025         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6026         method.  Moved from...
6027         (struct tui_win_info) <make_visible>: ...here.
6028
6029 2019-06-25  Tom Tromey  <tom@tromey.com>
6030
6031         * tui/tui-winsource.c
6032         (tui_source_window_base::do_scroll_horizontal): Remove direction
6033         parameter.
6034         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6035         direction parameter.
6036         * tui/tui-win.c (tui_win_info::forward_scroll)
6037         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6038         (tui_win_info::right_scroll): Update.
6039         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6040         direction parameter.
6041         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6042         direction parameter.
6043         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6044         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6045         Remove direction parameter.
6046         (struct tui_source_window_base, struct tui_source_window)
6047         (struct tui_disasm_window, struct tui_data_window)
6048         (struct tui_cmd_window): Update.
6049
6050 2019-06-25  Tom Tromey  <tom@tromey.com>
6051
6052         * tui/tui-winsource.h (tui_set_exec_info_content)
6053         (tui_show_exec_info_content, tui_erase_exec_info_content)
6054         (tui_clear_exec_info_content, tui_update_exec_info): Change
6055         argument to tui_source_window_base.
6056         * tui/tui-winsource.c (tui_set_exec_info_content)
6057         (tui_show_exec_info_content, tui_erase_exec_info_content)
6058         (tui_clear_exec_info_content, tui_update_exec_info): Change
6059         argument to tui_source_window_base.
6060
6061 2019-06-25  Tom Tromey  <tom@tromey.com>
6062
6063         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6064         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6065
6066 2019-06-25  Tom Tromey  <tom@tromey.com>
6067
6068         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6069         check.
6070
6071 2019-06-25  Tom Tromey  <tom@tromey.com>
6072
6073         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6074         type to void.
6075         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6076         type to void.
6077         * tui/tui-source.c (tui_set_source_content): Update.
6078         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6079
6080 2019-06-25  Tom Tromey  <tom@tromey.com>
6081
6082         * tui/tui-win.c (window_name_completer, tui_set_focus)
6083         (tui_all_windows_info): Use name method.
6084         * tui/tui-data.h (struct tui_gen_win_info)
6085         (struct tui_source_window, struct tui_disasm_window)
6086         (struct tui_data_window, struct tui_cmd_window) <name>: New
6087         method.
6088         (tui_win_name): Don't declare.
6089         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6090         (tui_win_name): Remove.
6091
6092 2019-06-25  Tom Tromey  <tom@tromey.com>
6093
6094         * tui/tui-winsource.h (tui_update_source_window)
6095         (tui_update_source_window_as_is): Change parameter type.
6096         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6097         to be a tui_source_window_base.
6098         (tui_update_source_window_as_is): Likewise.
6099         * tui/tui-win.c (make_visible_with_new_height): Update.
6100
6101 2019-06-25  Tom Tromey  <tom@tromey.com>
6102
6103         * tui/tui-winsource.c (tui_erase_source_content)
6104         (tui_show_source_content, tui_show_exec_info_content)
6105         (tui_erase_exec_info_content): Use refresh_window method.
6106         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6107         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6108         from tui_refresh_win.
6109         (tui_data_window::refresh_window): New method.
6110         (tui_win_info::refresh, tui_source_window_base::refresh)
6111         (tui_refresh_all): Use refresh_window method.
6112         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6113         method.
6114         * tui/tui-regs.c (tui_display_register): Call refresh_window
6115         method.
6116         * tui/tui-layout.c (show_source_disasm_command)
6117         (show_source_or_disasm_and_command): Call refresh_window method.
6118         * tui/tui-data.h (struct tui_gen_win_info)
6119         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6120         New method.
6121
6122 2019-06-25  Tom Tromey  <tom@tromey.com>
6123
6124         * tui/tui.c (tui_rl_other_window, tui_enable)
6125         (tui_is_window_visible, tui_get_command_dimension): Update.
6126         * tui/tui-winsource.c (tui_update_source_window_as_is)
6127         (tui_clear_source_content, tui_erase_source_content)
6128         (tui_show_source_line, tui_source_window_base::refill)
6129         (tui_source_window_base::do_scroll_horizontal)
6130         (tui_source_window_base::set_is_exec_point_at)
6131         (tui_update_breakpoint_info, tui_set_exec_info_content)
6132         (tui_alloc_source_buffer, tui_line_is_displayed)
6133         (tui_addr_is_displayed): Update.
6134         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6135         (tui_check_and_display_highlight_if_needed)
6136         (tui_win_info::make_visible, tui_win_info::refresh)
6137         (tui_refresh_all): Update.
6138         * tui/tui-windata.c (tui_first_data_item_displayed)
6139         (tui_delete_data_content_windows, tui_erase_data_content)
6140         (tui_display_all_data, tui_data_window::refresh_all)
6141         (tui_check_data_values): Update.
6142         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6143         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6144         (tui_win_info::backward_scroll, tui_refresh_all_win)
6145         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6146         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6147         (tui_source_window_base::set_new_height)
6148         (tui_data_window::set_new_height)
6149         (make_invisible_and_set_new_height)
6150         (make_visible_with_new_height, new_height_ok)
6151         (parse_scrolling_args): Update.
6152         * tui/tui-stack.c (tui_show_frame_info): Update.
6153         * tui/tui-source.c (tui_set_source_content)
6154         (tui_set_source_content_nil, tui_source_is_displayed)
6155         (tui_source_window::do_scroll_vertical): Update.
6156         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6157         (tui_display_registers_from, tui_display_reg_element_at_line)
6158         (tui_check_register_values, tui_reg_command): Update.
6159         * tui/tui-layout.c (tui_default_win_height)
6160         (show_source_disasm_command, show_data, init_and_make_win)
6161         (show_source_or_disasm_and_command): Update.
6162         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6163         (tui_redisplay_readline, tui_mld_flush)
6164         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6165         (tui_getc): Update.
6166         * tui/tui-disasm.c (tui_set_disassem_content)
6167         (tui_disasm_window::do_scroll_vertical): Update.
6168         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6169         Now virtual.
6170         (struct tui_win_info): Derive from tui_gen_win_info.
6171         <~tui_win_info>: Mark as override.
6172         <generic>: Remove member.
6173         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6174         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6175         (~tui_data_window, ~tui_win_info)
6176         (tui_free_all_source_wins_content): Update.
6177         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6178
6179 2019-06-25  Tom Tromey  <tom@tromey.com>
6180
6181         * tui/tui-layout.c (init_and_make_win): Use new.
6182         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6183         destructor, initializers.
6184         (tui_alloc_generic_win_info): Don't declare.
6185         * tui/tui-data.c (_locator): Add argument to constructor.
6186         (source_win, disasm_win): New globals.
6187         (exec_info): Remove.
6188         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6189         Update.
6190         (tui_alloc_generic_win_info): Remove.
6191         (init_content_element): Use new.
6192         (tui_win_info::tui_win_info): Update.
6193         (free_content_elements) <case DATA_WIN>: Use delete.
6194
6195 2019-06-25  Tom Tromey  <tom@tromey.com>
6196
6197         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6198         * tui/tui-windata.c (tui_first_data_item_displayed)
6199         (tui_delete_data_content_windows): Update.
6200         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6201         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6202         (tui_display_registers_from, tui_check_register_values): Update.
6203         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6204         pointer.
6205         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6206         window.
6207         (tui_free_data_content): Update.
6208         (free_content_elements) <case DATA_WIN>: Free the window.
6209
6210 2019-06-25  Tom Tromey  <tom@tromey.com>
6211
6212         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6213         Update.
6214         * tui/tui-layout.c (make_command_window)
6215         (show_source_disasm_command, show_data, init_and_make_win)
6216         (show_source_or_disasm_and_command): Update.
6217         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6218         method.
6219         <can_highight, is_highlighted>: Now bool.
6220         (tui_set_win_highlight): Don't declare.
6221         * tui/tui-data.c (tui_set_win_highlight): Remove.
6222
6223 2019-06-25  Tom Tromey  <tom@tromey.com>
6224
6225         * tui/tui-wingeneral.c (make_visible): Remove check of window
6226         type.
6227
6228 2019-06-25  Tom Tromey  <tom@tromey.com>
6229
6230         * tui/tui-win.c (tui_win_info::max_height)
6231         (tui_cmd_window::max_height): New methods.
6232         (new_height_ok): Call max_height.
6233         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6234         <max_height>: New method.
6235
6236 2019-06-25  Tom Tromey  <tom@tromey.com>
6237
6238         * tui/tui-win.c (tui_source_window_base::set_new_height)
6239         (tui_data_window::set_new_height): New methods.
6240         (make_invisible_and_set_new_height): Call set_new_height method.
6241         * tui/tui-data.h (struct tui_win_info)
6242         (struct tui_source_window_base, struct tui_data_window)
6243         <set_new_height>: New method.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6248         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6249         tui_refresh_data_win.
6250         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6251         method.
6252         (tui_refresh_all_win): Call the refresh_all method.
6253         (tui_set_focus): Likewise.
6254         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6255         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6256         Likewise.
6257
6258 2019-06-25  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-winsource.h (tui_refill_source_window)
6261         (tui_set_is_exec_point_at): Don't declare.
6262         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6263         (tui_source_window_base::refill): Rename from
6264         tui_refill_source_window.
6265         (tui_source_window_base::do_scroll_horizontal): Update.
6266         (tui_source_window_base::set_is_exec_point_at): Rename from
6267         tui_set_is_exec_point_at.
6268         (tui_update_all_breakpoint_info): Update.
6269         * tui/tui-stack.c (tui_show_frame_info): Update.
6270         * tui/tui-layout.c (show_data): Add cast.
6271         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6272         * tui/tui-data.h (struct tui_source_window_base) <refill,
6273         set_is_exec_point_at>: New methods.
6274         (tui_source_windows, tui_add_to_source_windows): Update types.
6275         (tui_add_to_source_windows): Remove redundant declaration.
6276         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6277         (tui_source_windows): Change return type.
6278         (tui_clear_source_windows_detail): Update.
6279         (tui_add_to_source_windows): Change type of parameter.
6280         (tui_free_all_source_wins_content): Update.
6281
6282 2019-06-25  Tom Tromey  <tom@tromey.com>
6283
6284         * tui/tui-wingeneral.c (tui_win_info::refresh)
6285         (tui_source_window_base::refresh): New methods.
6286         (tui_refresh_all): Call the refresh method.
6287         * tui/tui-data.h (struct tui_win_info)
6288         (struct tui_source_window_base) <refresh>: New method.
6289
6290 2019-06-25  Tom Tromey  <tom@tromey.com>
6291
6292         * tui/tui.h (tui_is_window_visible): Return bool.
6293         * tui/tui.c (tui_is_window_visible): Return bool.
6294         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6295         (tui_make_visible, tui_make_invisible)
6296         (tui_win_info::make_visible)
6297         (tui_source_window_base::make_visible, make_all_visible)
6298         (tui_make_all_visible, tui_make_all_invisible): Update.
6299         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6300         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6301         bool.
6302         (struct tui_win_info, struct tui_source_window_base)
6303         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6304         * tui/tui-data.c (tui_init_generic_part): Update.
6305
6306 2019-06-25  Tom Tromey  <tom@tromey.com>
6307
6308         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6309         (tui_source_window_base::make_visible): New methods.
6310         (make_all_visible): Make method call.
6311         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6312         (struct tui_source_window_base, struct tui_cmd_window): Override
6313         make_visible.
6314         (tui_win_is_source_type): Don't declare.
6315         * tui/tui-data.c (tui_win_is_source_type): Remove.
6316
6317 2019-06-25  Tom Tromey  <tom@tromey.com>
6318
6319         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6320         NULL check.
6321
6322 2019-06-25  Tom Tromey  <tom@tromey.com>
6323
6324         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6325         Inline constructor.  Add initializers for members.
6326         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6327         constructors; now inline in class.
6328
6329 2019-06-25  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-regs.c (tui_show_registers): Update.
6332         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6333         bool.
6334         * tui/tui-data.c (tui_data_window::clear_detail)
6335         (tui_data_window): Update.
6336
6337 2019-06-25  Tom Tromey  <tom@tromey.com>
6338
6339         * tui/tui-windata.c (tui_display_all_data)
6340         (tui_display_data_from_line, tui_display_data_from)
6341         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6342         Update.
6343         * tui/tui-regs.c (tui_last_regs_line_no)
6344         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6345         (tui_show_registers, tui_show_register_group)
6346         (tui_display_registers_from, tui_display_reg_element_at_line)
6347         (tui_display_registers_from_line, tui_check_register_values)
6348         (tui_reg_next, tui_reg_prev): Update.
6349         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6350         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6351         tui_data_window.
6352         (struct tui_win_info) <detail>: Remove.  Add new fields from
6353         tui_data_info.
6354         (TUI_DATA_WIN): Add cast.
6355         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6356         (~tui_data_window): Simplify.
6357
6358 2019-06-25  Tom Tromey  <tom@tromey.com>
6359
6360         * tui/tui-layout.c (show_source_disasm_command)
6361         (show_source_or_disasm_and_command): Update.
6362         * tui/tui-io.c (update_cmdwin_start_line)
6363         (tui_redisplay_readline): Update.
6364         * tui/tui-data.h (struct tui_command_info): Remove.
6365         (struct tui_win_info) <detail>: Remove command_info member.
6366         (struct tui_data_window) <start_line>: New member, from
6367         tui_command_info.
6368         (TUI_CMD_WIN): Add casts.
6369
6370 2019-06-25  Tom Tromey  <tom@tromey.com>
6371
6372         * tui/tui-winsource.c (tui_update_source_window)
6373         (tui_refill_source_window)
6374         (tui_source_window_base::do_scroll_horizontal)
6375         (tui_update_breakpoint_info, tui_set_exec_info_content)
6376         (tui_show_exec_info_content, tui_erase_exec_info_content)
6377         (tui_clear_exec_info_content): Update.
6378         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6379         Update.
6380         * tui/tui-win.c (make_invisible_and_set_new_height)
6381         (make_visible_with_new_height): Update.
6382         * tui/tui-source.c (tui_set_source_content)
6383         (tui_show_symtab_source): Update.
6384         * tui/tui-layout.c (extract_display_start_addr)
6385         (show_source_disasm_command, show_data)
6386         (make_source_or_disasm_window)
6387         (show_source_or_disasm_and_command): Update.
6388         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6389         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6390         "gdbarch".
6391         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6392         to tui_source_window_base.
6393         (struct tui_win_info) <detail>: Remove source_info member.
6394         (struct tui_source_window_base) <has_locator>: Inline.
6395         Move contents from tui_source_info; rename has_locator member to
6396         m_has_locator.
6397         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6398         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6399         header file.
6400         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6401         Simplify.
6402         (tui_free_all_source_wins_content): Cast to
6403         tui_source_window_base.
6404
6405 2019-06-25  Tom Tromey  <tom@tromey.com>
6406
6407         * tui/tui-win.c (make_invisible_and_set_new_height)
6408         (make_visible_with_new_height): Call has_locator method.
6409         * tui/tui-layout.c (show_source_disasm_command, show_data)
6410         (show_source_or_disasm_and_command): Update for bool change.
6411         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6412         (tui_win_info) <has_locator>: New method.
6413         (struct tui_source_window_base) <has_locator>: New method.
6414         (tui_win_has_locator): Don't declare.
6415         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6416         from tui_win_has_locator.
6417         (tui_source_window_base): Use false, not FALSE.
6418
6419 2019-06-25  Tom Tromey  <tom@tromey.com>
6420
6421         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6422         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6423         clear_detail method directly.
6424         (tui_clear_win_detail): Remove.
6425
6426 2019-06-25  Tom Tromey  <tom@tromey.com>
6427
6428         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6429         "this", not TUI_DISASM_WIN.
6430
6431 2019-06-25  Tom Tromey  <tom@tromey.com>
6432
6433         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6434         declare.
6435         * tui/tui-winsource.c
6436         (tui_source_window_base::do_scroll_horizontal): Rename from
6437         tui_horizontal_source_scroll.
6438         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6439         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6440         from tui_vertical_data_scroll.
6441         * tui/tui-win.h (tui_scroll): Don't declare.
6442         * tui/tui-win.c (tui_win_info::forward_scroll)
6443         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6444         (tui_win_info::right_scroll): Rename and update.
6445         (tui_scroll_forward_command, tui_scroll_backward_command)
6446         (tui_scroll_left_command, tui_scroll_right_command): Update.
6447         (tui_scroll): Remove.
6448         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6449         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6450         from tui_vertical_source_scroll.
6451         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6452         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6453         from tui_vertical_disassem_scroll.
6454         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6455         do_scroll_horizontal>: New methods.
6456         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6457         Likewise.
6458         (struct tui_source_window_base): Add do_scroll_horizontal.
6459         (struct tui_source_window, struct tui_disasm_window): Add
6460         do_scroll_vertical.
6461         (struct tui_data_window, struct tui_cmd_window): Add
6462         do_scroll_horizontal and do_scroll_vertical.
6463         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6464
6465 2019-06-25  Tom Tromey  <tom@tromey.com>
6466
6467         * tui/tui-data.h (struct tui_source_window_base): New struct.
6468         (struct tui_source_window): Derive from tui_source_window_base.
6469         (struct tui_disasm_window): New struct.
6470         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6471         from tui_source_window::clear_detail.
6472         (tui_source_window_base): Rename from tui_source_window.
6473         (~tui_source_window_base): Rename from ~tui_source_window.
6474         (tui_alloc_win_info): Create a tui_disasm_window.
6475
6476 2019-06-25  Tom Tromey  <tom@tromey.com>
6477
6478         * tui/tui-data.h (struct tui_source_window)
6479         (struct tui_data_window): Declare destructors.
6480         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6481         destructors.
6482         (tui_win_info): Simplify.
6483
6484 2019-06-25  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-winsource.c (tui_display_main)
6487         (tui_update_source_windows_with_addr)
6488         (tui_update_all_breakpoint_info): Update.
6489         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6490         (new_height_ok, parse_scrolling_args): Update.
6491         * tui/tui-stack.c (tui_show_frame_info): Update.
6492         * tui/tui-data.h (struct tui_list): Remove.
6493         (tui_source_windows): Return a reference to a std::vector.
6494         * tui/tui-data.c (source_windows): Now a std::vector.
6495         (tui_source_windows): Change return type.
6496         (tui_clear_source_windows): Rewrite.
6497         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6498         (tui_free_all_source_wins_content): Rewrite.
6499
6500 2019-06-25  Tom Tromey  <tom@tromey.com>
6501
6502         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6503         (struct tui_data_window, struct tui_cmd_window): Declare
6504         clear_detail method.
6505         * tui/tui-data.c (tui_source_window::clear_detail)
6506         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6507         methods.
6508         (tui_clear_win_detail): Simplify.
6509
6510 2019-06-25  Tom Tromey  <tom@tromey.com>
6511
6512         * tui/tui-layout.c (make_source_window, make_disasm_window)
6513         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6514         Return the new window.
6515         (show_source_disasm_command, show_data)
6516         (show_source_or_disasm_and_command): Update.
6517
6518 2019-06-25  Tom Tromey  <tom@tromey.com>
6519
6520         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6521         parameter.  Return the new window.
6522         (show_source_disasm_command): Update and remove NULL check.
6523         (show_source_or_disasm_and_command): Update.
6524
6525 2019-06-25  Tom Tromey  <tom@tromey.com>
6526
6527         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6528
6529 2019-06-25  Tom Tromey  <tom@tromey.com>
6530
6531         * tui/tui-data.h (struct tui_win_info): Make constructor
6532         protected.  Make destructor virtual.  Add initializers.
6533         (tui_source_window, tui_data_window, tui_cmd_window): New
6534         classes.
6535         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6536         constructor.  Add "type" parameter.
6537         (tui_source_window, tui_data_window, tui_cmd_window): New
6538         constructors.
6539         (tui_alloc_win_info): Instantiate the appropriate subclass.
6540
6541 2019-06-25  Tom Tromey  <tom@tromey.com>
6542
6543         * tui/tui-win.c (tui_resize_all): Use delete.
6544         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6545         destructor.
6546         (tui_free_window): Don't declare.
6547         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6548         Update.
6549
6550 2019-06-25  Tom Tromey  <tom@tromey.com>
6551
6552         * tui/tui-data.h (struct tui_win_info): Add constructor.
6553         * tui/tui-data.c (tui_alloc_win_info): Use new.
6554         (tui_free_window): Use delete.
6555
6556 2019-06-22  Tom Tromey  <tom@tromey.com>
6557
6558         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6559         declare.
6560         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6561
6562 2019-06-22  Tom Tromey  <tom@tromey.com>
6563
6564         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6565         declare.
6566         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6567
6568 2019-06-22  Tom de Vries  <tdevries@suse.de>
6569
6570         * dwarf2read.c (create_addrmap_from_aranges)
6571         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6572         instead of '%zu'.
6573
6574 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6575
6576         * dwarf2read.h (dwarf2_section_info_def): Remove.
6577         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6578         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6579         std::vector<dwarf2_section_info>.
6580         (struct dwo_file) <~dwo_file>: Remove.
6581         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6582         types field.
6583         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6584         (dwarf2_read_debug_names): Likewise.
6585         (create_debug_types_hash_table): Change parameter type to
6586         array_view, adjust code accordingly.
6587         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6588         (partial_die_info::fixup): Likewise.
6589         (determine_prefix): Likewise.
6590         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6591
6592 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6593
6594         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6595         gdb_bfd_ref_ptr.
6596         <~dwo_file>: Remove call to gdb_bfd_unref.
6597         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6598         gdb_bfd_ref_ptr::get.
6599
6600 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6601
6602         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6603         type to htab_up.
6604         * dwarf2read.c (struct dwo_file): Initialize fields.
6605         <~dwo_file>: New.
6606         (free_dwo_file): Remove, move content to ~dwo_file.
6607         (struct dwo_file_deleter): Remove.
6608         (dwo_file_up>: Remove custom deleter.
6609         (free_dwo_files): Remove.
6610         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6611         dwo_files.
6612         (process_skeletonless_type_units): Call unique_ptr::get.
6613         (allocate_dwo_file_hash_table): Add deleter to created hash
6614         table.  Change return type to htab_up.
6615         (lookup_dwo_file_slot): Don't memset dwo_file, call
6616         unique_ptr::get.
6617         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6618         (create_dwo_unit_in_dwp_v2): Likewise.
6619         (open_and_init_dwo_file): Likewise.
6620         (free_dwo_file_from_slot): Remove.
6621
6622 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6623
6624         * dwarf2read.h (struct dwarf2_section_info) <readin,
6625         is_virtual>: Change type to bool.
6626         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6627         true instead of 1.
6628
6629 2019-06-19  Tom Tromey  <tom@tromey.com>
6630
6631         * tui/tui-data.h (tui_init_content_element): Don't declare.
6632
6633 2019-06-19  Tom Tromey  <tom@tromey.com>
6634
6635         * tui/tui-data.h (tui_init_win_info): Don't declare.
6636
6637 2019-06-19  Tom de Vries  <tdevries@suse.de>
6638
6639         * dwarf2read.h (abstract_to_concrete): Change type to
6640         std::unordered_map<sect_offset, std::vector<sect_offset>,
6641         gdb::hash_enum<sect_offset>>.
6642
6643 2019-06-19  Tom Tromey  <tromey@adacore.com>
6644
6645         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6646         EVAL_AVOID_SIDE_EFFECTS specially.
6647
6648 2019-06-19  Tom Tromey  <tromey@adacore.com>
6649
6650         * source-cache.c (highlighter): New global.
6651         (source_cache::get_source_lines): Create a highlighter on demand.
6652
6653 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6654
6655         * defs.h (deprecated_interactive_hook): Delete declaration.
6656         * interps.c (clear_interpreter_hooks): Remove use of
6657         deprecated_interactive_hook.
6658         * top.c (deprecated_interactive_hook): Delete definition.
6659         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6660
6661 2019-06-18  Tom de Vries  <tdevries@suse.de>
6662
6663         PR gdb/24515
6664         * dwarf2read.h (abstract_to_concrete): Change type from
6665         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6666         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6667         * dwarf2read.c (read_variable): Update.
6668         (dwarf2_fetch_die_loc_sect_off): Update.
6669
6670 2019-06-17  Tom de Vries  <tdevries@suse.de>
6671
6672         PR gdb/24617
6673         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6674         accessing parent[parent_len - 1].
6675
6676 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6677
6678         PR gdb/24364
6679         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6680         call dtrace_process_dof with NULL dof.
6681
6682 2019-06-16  Tom de Vries  <tdevries@suse.de>
6683
6684         PR gdb/24445
6685         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6686
6687 2019-06-16  Tom Tromey  <tom@tromey.com>
6688
6689         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6690         (make_all_visible): Use address of member.
6691
6692 2019-06-16  Tom Tromey  <tom@tromey.com>
6693
6694         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6695         (tui_free_window, free_content, free_content_elements): Remove
6696         unnecessary cast.
6697         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6698         cast.
6699         * tui/tui-regs.c (tui_show_register_group)
6700         (tui_display_registers_from, tui_display_reg_element_at_line):
6701         Remove unnecessary cast.
6702
6703 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6704
6705         * linux-nat.c (normal_mask): Delete.
6706         (_initialize_linux_nat): Don't initialise normal_mask.
6707
6708 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6709
6710         PR gdb/24445
6711         * dwarf-index-write.h (write_psymtabs_to_index): Add
6712         dwz_basename parameter.
6713         * dwarf-index-write.c (write_gdbindex): Move file writing to
6714         write_gdbindex_1.  Change return type void.
6715         (assert_file_size): Move up, remove filename parameter.
6716         (write_gdbindex_1): New function.
6717         (write_debug_names): Change return type to void, call
6718         assert_file_size.
6719         (struct index_wip_file): New struct.
6720         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6721         file logic to index_wip_file.  Write index for dwz file if
6722         needed.
6723         (save_gdb_index_command): Pass basename of dwz file, if present.
6724         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6725         build-id of dwz file, if present.
6726         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6727         (dwarf2_get_dwz_file): Likewise.
6728         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6729         (dwarf2_get_dwz_file): Likewise.
6730
6731 2019-06-16  Tom Tromey  <tom@tromey.com>
6732
6733         * coffread.c (process_coff_symbol): Use xstrdup.
6734         * value.c (create_internalvar): Use xstrdup.
6735
6736 2019-06-16  Tom Tromey  <tom@tromey.com>
6737
6738         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6739         * breakpoint.c (stopin_command, stopat_command)
6740         (until_break_command, decode_location_default): Remove unnecessary
6741         cast.
6742         * utils.c (subset_compare): Remove unnecessary cast.
6743         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6744         cast.
6745         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6746         cast.
6747         * infcmd.c (path_command): Remove unnecessary cast.
6748         * coffread.c (decode_type): Remove unnecessary cast.
6749         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6750         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6751         * tui/tui-stack.c (tui_show_locator_content)
6752         (tui_show_frame_info): Remove unnecessary cast.
6753         * tui/tui-win.c (tui_scroll_forward_command)
6754         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6755         (parse_scrolling_args): Remove unnecessary cast.
6756         * tui/tui-data.c (init_win_info, tui_del_window)
6757         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6758         (free_content_elements): Remove unnecessary cast.
6759         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6760         unnecessary cast.
6761         * tui/tui-source.c (tui_set_source_content)
6762         (tui_vertical_source_scroll): Remove unnecessary cast.
6763         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6764         cast.
6765         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6766         * tui/tui-regs.c (tui_display_registers_from)
6767         (tui_display_register): Remove unnecessary cast.
6768         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6769         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6770         (make_visible): Remove unnecessary cast.
6771         * tui/tui-winsource.c (tui_erase_source_content)
6772         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6773         unnecessary cast.
6774         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6775         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6776         * stabsread.c (read_type, read_array_type, read_range_type):
6777         Remove unnecessary cast.
6778         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6779         (parse_symbol, parse_type, upgrade_type, parse_external)
6780         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6781         unnecessary cast.
6782         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6783
6784 2019-06-16  Tom Tromey  <tom@tromey.com>
6785
6786         * tui/tui-data.c (tui_alloc_generic_win_info)
6787         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6788         checks.
6789
6790 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6791             Andrew Burgess  <andrew.burgess@embecosm.com>
6792
6793         * f-typeprint.c (f_print_type): Don't return early for not
6794         associated or not allocated types.
6795         (f_type_print_varspec_suffix): Add print_rank parameter and print
6796         ranks of array types in case they dangling.
6797         (f_type_print_base): Add print_rank parameter.
6798
6799 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6800
6801         * NEWS: Mention new MI commands.
6802         * break-catch-throw.c (enum exception_event_kind): Move to
6803         breakpoint.h.
6804         (print_mention_exception_catchpoint): Output text as a single
6805         message.
6806         (catch_exception_command_1): Rename to...
6807         (catch_exception_event): ...this, make non-static, update header
6808         command, and change some parameter types.
6809         (catch_catch_command): Update for changes to
6810         catch_exception_command_1.
6811         (catch_throw_command): Likewise.
6812         (catch_rethrow_command): Likewise.
6813         * breakpoint.c (enum exception_event_kind): Delete.
6814         * breakpoint.h (enum exception_event_kind): Moved here from
6815         break-catch-throw.c.
6816         (catch_exception_event): Declare.
6817         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6818         (mi_cmd_catch_throw): New function.
6819         (mi_cmd_catch_rethrow): New function.
6820         (mi_cmd_catch_catch): New function.
6821         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6822         'catch-catch' entries.
6823         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6824         (mi_cmd_catch_rethrow): Declare.
6825         (mi_cmd_catch_catch): Declare.
6826
6827 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6828
6829         * annotate.c (annotate_source_line): Change return type to void,
6830         update implementation to match.
6831         * annotate.h (annotate_source_line): Change return type to void,
6832         update header comment.
6833         * stack.c (print_frame_info): Don't change what frame information
6834         is printed based on whether annotations are on or not.
6835
6836 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6837
6838         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6839         (annotate_source): Make static.
6840         (annotate_source_line): Moved from source.c and renamed from
6841         identify_source_line.  Update the return type.
6842         * annotate.h (annotate_source): Delete declaration.
6843         (annotate_source_line): Declaration moved from source.h, and
6844         renamed from identify_source_line.  Return type updated.
6845         * source.c (identify_source_line): Moved to annotate.c and renamed
6846         to annotate_source_line.
6847         (info_line_command): Remove check of annotation_level.
6848         * source.h (identify_source_line): Move declaration to annotate.h
6849         and rename to annotate_source_line.
6850         * stack.c: Add 'annotate.h' include.
6851         (print_frame_info): Remove check of annotation_level before
6852         calling annotate_source_line.
6853
6854 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6855
6856         * source-cache.c (source_cache::get_plain_source_lines): Use
6857         open_source_file_with_line_charpos instead of just
6858         open_source_file, remove call to find_source_lines.
6859         (source_cache::get_source_lines): Likewise.
6860         * source.c (find_source_lines): Make static.
6861         (get_filename_and_charpos): Renamed into...
6862         (open_source_file_with_line_charpos): ..this along with changes to
6863         return a scoped_fd, and some other minor clean ups.
6864         (identify_source_line): Use open_source_file_with_line_charpos.
6865         (search_command_helper): Use open_source_file_with_line_charpos
6866         instead of just open_source_file, remove call to
6867         find_source_lines.
6868         * source.h (open_source_file_with_line_charpos): Declare new
6869         function.
6870         (find_source_lines): Delete declaration.
6871
6872 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6873
6874         * source.c (get_filename_and_charpos): Remove fullname
6875         parameter.
6876         (identify_source_line): Update call to get_filename_and_charpos.
6877
6878 2019-06-14  Tom Tromey  <tromey@adacore.com>
6879
6880         PR gdb/24502:
6881         * ui-style.h (skip_ansi_escape): Update comment.
6882         * ui-file.h (class no_terminal_escape_file): New class.
6883         * ui-file.c (no_terminal_escape_file::write)
6884         (no_terminal_escape_file::puts): New methods.
6885         * cli/cli-logging.c (handle_redirections): Use
6886         no_terminal_escape_file.
6887
6888 2019-06-14  Tom Tromey  <tromey@adacore.com>
6889
6890         * NEWS: Move convenience variable news above Python news.
6891
6892 2019-06-14  Tom Tromey  <tom@tromey.com>
6893
6894         * gnulib: Move directory to top-level.
6895         * configure.ac: Don't configure gnulib.
6896         * configure: Rebuild.
6897         * common/common-defs.h: Use new path to gnulib.
6898         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6899         (GNULIB_H): Remove.
6900         (INCGNU): Look in new gnulib location.
6901         (HFILES_NO_SRCDIR): Remove gnulib files.
6902         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6903         (generated_files): Remove GNULIB_H.
6904         ($(LIBGNU), all-lib): Remove targets.
6905         (distclean): Don't mention GNULIB_BUILDDIR.
6906         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6907
6908 2019-06-14  Tom Tromey  <tromey@adacore.com>
6909
6910         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6911         Warn if symbol file does not provide any symbols.
6912
6913 2019-06-14  Tom Tromey  <tromey@adacore.com>
6914
6915         * source.c (find_and_open_source): Respect basenames_may_differ.
6916
6917 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * annotate.c (annotate_breakpoints_invalid): Make use of
6920         scoped_restore_terminal_state.
6921         (annotate_frames_invalid): Likewise.
6922
6923 2019-06-14  Tom Tromey  <tromey@adacore.com>
6924
6925         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6926         allow assignment to an internalvar.
6927
6928 2019-06-14  Tom Tromey  <tromey@adacore.com>
6929
6930         * ada-lex.l: Allow "_" in attribute names.
6931
6932 2019-06-14  Tom Tromey  <tromey@adacore.com>
6933
6934         PR gdb/24653:
6935         * regcache.c (registers_changed): Don't call alloca.
6936         * top.c (execute_command): Don't call alloca.
6937
6938 2019-06-13  Pedro Alves  <palves@redhat.com>
6939
6940         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6941         'expression'.  When parsing an expression, error out if there's
6942         junk after "unlimited".
6943         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6944         (do_set_command): Adjust calls to is_unlimited_literal.
6945
6946 2019-06-13  Pedro Alves  <palves@redhat.com>
6947
6948         * compile/compile.c (make_compile_options_def_group): Add braces
6949         around array_view initializer.
6950         * thread.c (make_thread_apply_all_options_def_group)
6951         (make_thread_apply_all_options_def_group): Likewise.
6952
6953 2019-06-13  Pedro Alves  <palves@redhat.com>
6954
6955         * NEWS (New commands): Mention "maint test-options
6956         require-delimiter", "maint test-options unknown-is-error", "maint
6957         test-options unknown-is-operand" and "maint show
6958         test-options-completion-result".
6959         (New command options, command completion): New section.
6960         (Completion improvements): New section.
6961         Mention that you can abbreviate "unlimited".
6962
6963 2019-06-13  Pedro Alves  <palves@redhat.com>
6964
6965         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6966         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6967         * unittests/cli-utils-selftests.c (test_parse_flags)
6968         (test_parse_flags_qcs): Delete.
6969         (test_cli_utils): Don't call deleted functions.
6970
6971 2019-06-13  Pedro Alves  <palves@redhat.com>
6972
6973         * thread.c: Include "cli/cli-option.h".
6974         (tp_array_compar_ascending): Global.
6975         (tp_array_compar): Delete function.
6976         (tp_array_compar_ascending, tp_array_compar_descending): New
6977         functions.
6978         (ascending_option_def, qcs_flag_option_def)
6979         (thr_qcs_flags_option_defs)
6980         (make_thread_apply_all_options_def_group)
6981         (make_thread_apply_options_def_group): New.
6982         (thread_apply_all_command): Use gdb::option::process_options.
6983         (thread_apply_command_completer)
6984         (thread_apply_all_command_completer): New.
6985         (thread_apply_command): Use gdb::option::process_options.
6986         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6987         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6988         to generate help text of "thread apply".  Adjust "taas"'s help.
6989         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6990         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6991
6992 2019-06-13  Pedro Alves  <palves@redhat.com>
6993
6994         * thread.c (thread_apply_command): Check for invalid TID with
6995         isdigit instead of !isalpha.
6996
6997 2019-06-13  Pedro Alves  <palves@redhat.com>
6998
6999         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7000         (validate_flags_qcs): New.
7001         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7002         (validate_flags_qcs): Declare.
7003         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7004         (make_frame_apply_options_def_group): New.
7005         (frame_apply_command_count): Process options with
7006         gdb::option::process_options.
7007         (frame_apply_completer): New.
7008         (frame_apply_level_completer, frame_apply_all_completer)
7009         (frame_apply_completer): New.
7010         (_initialize_stack): Update help of "frame apply", "frame apply
7011         level", "frame apply all" and "faas" to mention supported options
7012         and install command completers.
7013         * stack.h (frame_apply_all_completer): Declare.
7014         * thread.c: Include "stack.h".
7015         (tfaas_command): Add "--".
7016         (_initialize_thread): Update help "tfaas" to mention supported
7017         options and install command completer.
7018
7019 2019-06-13  Pedro Alves  <palves@redhat.com>
7020
7021         * completer.c (complete_nested_command_line): New.
7022         (gdb_completion_word_break_characters_throw): Add assertion.
7023         * completer.h (complete_nested_command_line): Declare.
7024
7025 2019-06-13  Pedro Alves  <palves@redhat.com>
7026
7027         * stack.c (parse_backtrace_qualifiers): New.
7028         (backtrace_command): Use it.
7029         (backtrace_command_completer): Complete on qualifiers.
7030
7031 2019-06-13  Pedro Alves  <palves@redhat.com>
7032
7033         * frame.c: Include "cli/cli-option.h.
7034         (user_set_backtrace_options): New.
7035         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7036         Delete.
7037         (get_prev_frame): Adjust.
7038         (boolean_option_def, uinteger_option_def)
7039         (set_backtrace_option_defs): New.
7040         (_initialize_frame): Adjust and use
7041         gdb::option::add_setshow_cmds_for_options to install "set
7042         backtrace past-main" and "set backtrace past-entry".
7043         * frame.h: Include "cli/cli-option.h".
7044         (struct frame_print_options): Forward declare.
7045         (print_frame_arguments_all, print_frame_arguments_scalars)
7046         (print_frame_arguments_none): Declare.
7047         (print_entry_values): Delete declaration.
7048         (struct frame_print_options, user_frame_print_options): New.
7049         (struct set_backtrace_options): New.
7050         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7051         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7052         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7053         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7054         (list_args_or_locals): Add frame_print_options parameter.
7055         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7056         * python/py-framefilter.c (enumerate_args): Pass down
7057         USER_FRAME_PRINT_OPTIONS.
7058         * stack.c: Include "cli/cli-option.h".
7059         (print_frame_arguments_all, print_frame_arguments_scalars)
7060         (print_frame_arguments_none): Declare.
7061         (print_raw_frame_arguments, print_entry_values): Delete.
7062         (user_frame_print_options): New.
7063         (boolean_option_def, enum_option_def, frame_print_option_defs):
7064         New.
7065         (struct backtrace_cmd_options): New.
7066         (bt_flag_option_def): New.
7067         (backtrace_command_option_defs): New.
7068         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7069         (print_frame_arg, read_frame_arg, print_frame_args)
7070         (print_frame_info, print_frame): Add frame_print_options parameter
7071         and use it.
7072         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7073         (backtrace_command_1): Add frame_print_options and
7074         backtrace_cmd_options parameters and use them.
7075         (make_backtrace_options_def_group): New.
7076         (backtrace_command): Process command options with
7077         gdb::option::process_options.
7078         (backtrace_command_completer): New.
7079         (_initialize_stack): Extend "backtrace"'s help to mention
7080         supported options.  Install completer for "backtrace".
7081         Install some settings commands with add_setshow_cmds_for_options.
7082
7083 2019-06-13  Pedro Alves  <palves@redhat.com>
7084
7085         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7086         and that "set/show print raw frame-arguments" are now deprecated.
7087
7088         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7089         command.
7090         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7091         * stack.c (_initialize_stack): Install "set/show print
7092         raw-frame-arguments", and deprecate "set/show print raw
7093         frame-arguments".
7094         * valprint.c (_initialize_valprint): Deprecate "set/show print
7095         raw".
7096
7097 2019-06-13  Pedro Alves  <palves@redhat.com>
7098
7099         * compile/compile.c (struct compile_options): New.
7100         (compile_flag_option_def, compile_command_option_defs)
7101         (make_compile_options_def_group): New.
7102         (compile_file_command): Handle options with
7103         gdb::option::process_options.
7104         (compile_file_command_completer): New function.
7105         (compile_code_command): Handle options with
7106         gdb::option::process_options.
7107         (compile_code_command_completer): New function.
7108         (_initialize_compiler): Install completers for "compile code" and
7109         "compile file".  Mention available options in "compile code" and
7110         "compile code"'s help.
7111         * completer.c (advance_to_completion_word): New, factored out from
7112         ...
7113         (advance_to_expression_complete_word_point): ... this.
7114         (advance_to_filename_complete_word_point): New.
7115         * completer.h (advance_to_filename_complete_word_point): New
7116         declaration.
7117
7118 2019-06-13  Pedro Alves  <palves@redhat.com>
7119
7120         * compile/compile.c: Include "cli/cli-option.h".
7121         (compile_print_value): Scope data pointer is now a
7122         value_print_options pointer; adjust.
7123         (compile_print_command): Process options.  Scope data pointer is
7124         now a value_print_options pointer; adjust.
7125         (_initialize_compile): Update "compile print"'s help to include
7126         supported options.  Install a completer for "compile print".
7127         * cp-valprint.c (show_vtblprint, show_objectprint)
7128         (show_static_field_print): Delete.
7129         (_initialize_cp_valprint): Don't install "set print
7130         static-members", "set print vtbl", "set print object" here.
7131         * printcmd.c: Include "cli/cli-option.h" and
7132         "common/gdb_optional.h".
7133         (print_command_parse_format): Rework to fill in a
7134         value_print_options instead of a format_data.
7135         (print_value): Change parameter type from format_data pointer to
7136         value_print_options reference.  Adjust.
7137         (print_command_1): Process options.  Adjust to pass down a
7138         value_print_options.
7139         (print_command_completer): New.
7140         (_initialize_printcmd): Install print_command_completer as
7141         handle_brkchars completer for the "print" command.  Update
7142         "print"'s help to include supported options.
7143         * valprint.c: Include "cli/cli-option.h".
7144         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7145         here from cp-valprint.c.
7146         (boolean_option_def, uinteger_option_def)
7147         (value_print_option_defs, make_value_print_options_def_group):
7148         New.  Use gdb::option::add_setshow_cmds_for_options to install
7149         "set print elements", "set print null-stop", "set print repeats",
7150         "set print pretty", "set print union", "set print array", "set
7151         print address", "set print symbol", "set print array-indexes".
7152         * valprint.h: Include <string> and "cli/cli-option.h".
7153         (make_value_print_options_def_group): Declare.
7154         (print_value): Change parameter type from format_data pointer to
7155         value_print_options reference.
7156         (print_command_completer): Declare.
7157
7158 2019-06-13  Pedro Alves  <palves@redhat.com>
7159
7160         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7161         (COMMON_SFILES): Add maint-test-settings.c.
7162         * cli/cli-decode.c (boolean_enums): New global, factored out from
7163         ...
7164         (add_setshow_boolean_cmd): ... here.
7165         * cli/cli-decode.h (boolean_enums): Declare.
7166         * cli/cli-option.c: New file.
7167         * cli/cli-option.h: New file.
7168         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7169         factored out from ...
7170         (parse_cli_boolean_value(const char *)): ... this.
7171         (is_unlimited_literal): Change parameter type to pointer to
7172         pointer.  Adjust and advance ARG pointer.
7173         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7174         (parse_cli_var_enum): New, factored out from ...
7175         (do_set_command): ... this.  Adjust.
7176         * cli/cli-setshow.h (parse_cli_boolean_value)
7177         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7178         (parse_cli_var_enum): Declare.
7179         * cli/cli-utils.c: Include "cli/cli-option.h".
7180         (get_ulongest): New.
7181         * cli/cli-utils.h (get_ulongest): Declare.
7182         (check_for_argument): New overloads.
7183         * maint-test-options.c: New file.
7184
7185 2019-06-13  Pedro Alves  <palves@redhat.com>
7186
7187         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7188         parse a range if "-" is at the end of the string.
7189
7190 2019-06-13  Pedro Alves  <palves@redhat.com>
7191
7192         * cli/cli-setshow.c (parse_auto_binary_operation)
7193         (parse_cli_boolean_value): Don't allow "o".
7194
7195 2019-06-13  Pedro Alves  <palves@redhat.com>
7196
7197         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7198         * NEWS: Mention maint test-settings KIND.
7199         * maint-test-settings.c: New file.
7200
7201 2019-06-13  Pedro Alves  <palves@redhat.com>
7202
7203         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7204         completer.
7205         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7206         "set" completers.
7207
7208 2019-06-13  Pedro Alves  <palves@redhat.com>
7209
7210         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7211         after item.
7212
7213 2019-06-13  Pedro Alves  <palves@redhat.com>
7214
7215         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7216
7217 2019-06-13  Pedro Alves <palves@redhat.com>
7218
7219         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7220         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7221         call.
7222         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7223         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7224         calls.
7225         (check_for_argument): Skip spaces after argument.
7226
7227 2019-06-13  Pedro Alves  <palves@redhat.com>
7228
7229         * thread.c (thread_apply_command): Adjust TID parsing.
7230         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7231         detected before end of string.
7232         (tid_is_in_list): Error out if LIST is invalid.
7233
7234 2019-06-13  Pedro Alves  <palves@redhat.com>
7235
7236         * completer.c (complete_line_internal_1): Rewind completion word
7237         point.
7238         (completion_tracker::advance_custom_word_point_by): Change
7239         parameter type to int.
7240         * completer.h (completion_tracker::advance_custom_word_point_by):
7241         Likewise.
7242
7243 2019-06-13  Pedro Alves  <palves@redhat.com>
7244
7245         * completer.c (advance_to_completion_word): Handle delimiters.
7246
7247 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7248
7249         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7250
7251 2019-06-11  Tom Tromey  <tom@tromey.com>
7252
7253         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7254         (xmalloc_failed): Move to alloc.c.
7255         * alloc.c: New file.
7256         * Makefile.in (COMMON_SFILES): Add alloc.c.
7257
7258 2019-06-11  Tom Tromey  <tom@tromey.com>
7259
7260         * nat/linux-waitpid.c: Don't include server.h.
7261         (linux_debug): Remove.
7262         (my_waitpid): Update.
7263
7264 2019-06-11  Tom Tromey  <tromey@adacore.com>
7265
7266         * infcall.c (_initialize_infcall): Remove trailing newline from
7267         help.
7268         * user-regs.c (_initialize_user_regs): Remove trailing newline
7269         from help.
7270         * typeprint.c (_initialize_typeprint): Remove trailing newline
7271         from help.
7272         * reverse.c (_initialize_reverse): Remove trailing newlines from
7273         help.
7274         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7275         from help.
7276         * language.c (add_set_language_command): Remove trailing newline
7277         from help.
7278         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7279         help.
7280         * disasm.c (_initialize_disasm): Remove trailing newline from
7281         help.
7282         * top.c (init_main): Remove trailing newline from help.
7283         * interps.c (_initialize_interpreter): Remove trailing newline
7284         from help.
7285         * btrace.c (_initialize_btrace): Remove trailing newlines from
7286         help.
7287         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7288         from help.
7289         * python/python.c (_initialize_python): Remove trailing newline
7290         from help.
7291         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7292         help.
7293         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7294         from help.  Reformat some text.
7295         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7296         from help.
7297         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7298         newline from help.
7299
7300 2019-06-11  Tom Tromey  <tromey@adacore.com>
7301
7302         * darwin-nat.c (darwin_decode_exception_message)
7303         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7304
7305 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * valops.c (value_slice): Check for not allocated or not
7308         associated values.
7309
7310 2019-06-10  Tom de Vries  <tdevries@suse.de>
7311
7312         PR gdb/24618
7313         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7314         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7315         invalid.
7316
7317 2019-06-10  Tom de Vries  <tdevries@suse.de>
7318
7319         PR gdb/24611
7320         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7321         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7322
7323 2019-06-10  Tom de Vries  <tdevries@suse.de>
7324
7325         PR symtab/24545
7326         * symtab.c (struct demangled_name_entry): Add language field.
7327         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7328         static minimal symbol".  Set and use language field.
7329
7330 2019-06-10  Tom Tromey  <tromey@adacore.com>
7331
7332         * ada-lang.c (_initialize_ada_language): Update help text.
7333
7334 2019-06-10  Tom Tromey  <tromey@adacore.com>
7335
7336         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7337         with a newline.
7338         * guile/guile.c (handle_boot_error): Don't end warning with a
7339         newline.
7340         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7341         warning with a newline.
7342         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7343         newline.
7344         (s12z_frame_cache): Likewise.
7345         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7346         a newline.
7347         * solib-svr4.c (disable_probes_interface): Don't end warning with
7348         a newline.
7349         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7350         newline.
7351         * python/python.c (do_finish_initialization): Don't end warning
7352         with a newline.
7353
7354 2019-06-10  Tom Tromey  <tom@tromey.com>
7355
7356         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7357         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7358         gdbpy_enter.
7359
7360 2019-06-10  Tom Tromey  <tromey@adacore.com>
7361
7362         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7363         data.
7364         (elf_new_init): Don't call stabsread_new_init.
7365         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7366         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7367         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7368
7369 2019-06-10  Tom de Vries  <tdevries@suse.de>
7370
7371         PR symtab/16264
7372         PR symtab/24517
7373         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7374
7375 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7376
7377         * source.c (find_and_open_source): Also rewrite relative file
7378         names.
7379
7380 2019-04-26  Amos Bird  <amosbird@gmail.com>
7381
7382         * annotate.c (annotate_thread_exited): Add "thread-exited"
7383         annotation.
7384
7385 2019-06-06  Tom Tromey  <tromey@adacore.com>
7386
7387         * maint.h (class scoped_command_stats): Use
7388         DISABLE_COPY_AND_ASSIGN.
7389         <print_time>: New method.
7390         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7391         print_time.
7392         (scoped_command_stats::print_time): New method.
7393
7394 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7395
7396         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7397         instructions of lengths 6 or 8 bytes.
7398
7399 2019-06-04  Pedro Alves  <palves@redhat.com>
7400
7401         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7402
7403         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7404         * breakpoint.c (condition_completer): Likewise.
7405         * cli/cli-dump.c (scan_expression): Likewise.
7406         * common/filestuff.c (mkdir_recursive): Likewise.
7407         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7408         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7409         (gdb_abspath): Likewise.
7410         * compile/compile-cplus-types.c
7411         (compile_cplus_instance::decl_name): Likewise.
7412         * completer.c (complete_explicit_location):
7413         (signal_completer, reg_or_group_completer_1): Likewise.
7414         * cp-support.c (cp_remove_params_if_any): Likewise.
7415         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7416         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7417         * infcmd.c (strip_bg_char): Likewise.
7418         * linespec.c (copy_token_string): Likewise.
7419         * mi/mi-main.c (output_cores): Likewise.
7420         * psymtab.c (psymtab_search_name):
7421         * symfile.c (test_set_ext_lang_command): Likewise.
7422         * target.c (target_fileio_read_stralloc): Likewise.
7423         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7424         * value.c (complete_internalvar): Likewise.
7425
7426 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7427
7428         Add objfile property to gdb.Type.
7429         * NEWS: Mention Python API addition.
7430         * python/py-type.c (typy_get_objfile): New method.
7431
7432 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7433
7434         * NEWS: Mention the new set|show style [title|highlight].
7435         Mention changes to "show style", "help" and "apropos".
7436
7437 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7438
7439         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7440         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7441         instead of print_help_for_command.
7442         (print_doc_of_command): New function.
7443         (help_list): Add 'apropos -v word' suggestion.
7444         (print_help_for_command): Style the command name using title style.
7445         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7446         (_initialize_cli_cmds): Describe -v in apropos_command help.
7447
7448 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7449
7450         * cli/cli-style.h (cli_style_option): Add name in constructor,
7451         add m_name class member, add constructor with intensity,
7452         add name class function.
7453         (cli_style_option::add_setshow_commands): Remove name argument.
7454         (highlight_style, title_style): New styles.
7455         * cli/cli-style.c (do_show): New function that shows a style
7456         characteristic styling the style name with itself.
7457         (set_style_name): New function.
7458         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7459         Update all callers according to the changes in cli/cli-style.h.
7460         * utils.h (fputs_highlighted): New function.
7461         * utils.c (fputs_highlighted): Likewise.
7462
7463 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7464
7465         * NEWS: Mention new pipe command and new convenience variables.
7466
7467 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7468
7469         * cli/cli-cmds.c (pipe_command): New function.
7470         (_initialize_cli_cmds): Call add_com for pipe_command.
7471         Define | as an alias for pipe.
7472         (exit_status_set_internal_vars): New function.
7473         (shell_escape): Call exit_status_set_internal_vars.
7474         cli/cli-decode.c (find_command_name_length): Recognize | as
7475         a single character command.
7476
7477 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7478
7479         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7480         top.c (execute_command_to_ui_file): New function, mostly a copy
7481         of execute_command_to_string.
7482         (execute_command_to_string): Implement by calling
7483         execute_command_to_ui_file.
7484
7485 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7486
7487         * top.h (saved_command_line): Remove declaration.
7488         * top.c (previous_saved_command_line, previous_repeat_arguments):
7489         New variables.
7490         (saved_command_line): Make static, define together with other
7491         'repeat variables'.
7492         (dont_repeat): Clear repeat_arguments.
7493         (repeat_previous, get_saved_command_line, save_command_line):
7494         New functions.
7495         (gdb_init): Initialize saved_command_line
7496         and previous_saved_command_line.
7497         * main.c (captured_main_1): Remove saved_command_line initialization.
7498         * event-top.c (handle_line_of_input): Update to use
7499         the new 'repeat' related functions instead of direct access to
7500         saved_command_line.
7501         * command.h (repeat_previous, get_saved_command_line,
7502         save_command_line): New declarations.
7503         (dont_repeat): Add comment.
7504
7505 2019-05-30  Tom Tromey  <tromey@adacore.com>
7506
7507         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7508         Fix comment.
7509         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7510
7511 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7512
7513         PR cli/24587
7514         * completer.c (complete): Initialize variable word.
7515
7516 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7517
7518         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7519         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7520         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7521         'body' is NULL to the outter 'if', protecting the '!is_define'
7522         situation as well.
7523
7524 2019-05-29  Tom Tromey  <tromey@adacore.com>
7525
7526         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7527         (dwarf_unknown): New function.
7528         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7529         (dwarf_type_encoding_name): Use dwarf_unknown.
7530
7531 2019-05-29  Tom Tromey  <tromey@adacore.com>
7532
7533         PR c++/20020:
7534         * cp-valprint.c (cp_print_value_fields): Call
7535         cp_print_static_field inside "try".
7536
7537 2019-05-29  Tom Tromey  <tromey@adacore.com>
7538
7539         * inflow.c (struct terminal_info): Add default operator=.
7540         * configure: Rebuild.
7541         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7542         -Wdeprecated-copy-dtor, -Wredundant-move.
7543
7544 2019-05-29  Tom Tromey  <tromey@adacore.com>
7545
7546         * NEWS: Add entry.
7547         * infcmd.c (print_return_value_1): Handle finish_print
7548         option.
7549         (show_print_finish): New function.
7550         (_initialize_infcmd): Add "set/show print finish" commands.
7551         * valprint.c (user_print_options): Initialize new member.
7552         * valprint.h (struct value_print_options) <finish_print>: New
7553         member.
7554
7555 2019-05-28  Tom Tromey  <tromey@adacore.com>
7556
7557         * ada-lang.c (ada_remove_Xbn_suffix)
7558         (find_old_style_renaming_symbol)
7559         (parse_old_style_renaming): Remove.
7560         (ada_find_renaming_symbol): Don't call
7561         find_old_style_renaming_symbol.
7562         (ada_is_renaming_symbol): Rename from
7563         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7564         bool.  Now static.
7565         (ada_read_var_value): Update and simplify.
7566         * ada-exp.y (write_var_or_type): Remove old code.
7567
7568 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7569
7570         PR gdb/25010
7571         * event-top.c: Remove include comment.
7572         * inflow.c (class scoped_ignore_sigttou): Move from here...
7573         * inflow.h (class scoped_ignore_sigttou): ...to here.
7574         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7575         * top.c:  Remove include comment.
7576
7577 2019-05-27  Tom Tromey  <tom@tromey.com>
7578
7579         * NEWS: Fix typo.
7580
7581 2019-05-22  Tom Tromey  <tromey@adacore.com>
7582
7583         * target.c (target_follow_exec): Constify parameter.
7584         * target-delegates.c: Rebuild.
7585         * remote.c (remote_target::follow_exec): Constify parameter.
7586         * infrun.c (follow_exec): Constify parameter.
7587         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7588         (target_follow_exec): Likewise.
7589
7590 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7591
7592         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7593         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7594
7595 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7596
7597         * NEWS: Add debugredirect and testsuite sections.
7598
7599 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7600
7601         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7602         target descriptions using exclusively floating point register name
7603         aliases.
7604
7605 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7606
7607         PR gdb/18644:
7608         * f-lang.c (build_fortran_types): Handle the case where
7609         gdbarch_floatformat_for_type returns a nullptr.
7610
7611 2019-05-21  Tom de Vries  <tdevries@suse.de>
7612
7613         PR cli/24587
7614         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7615
7616 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7617
7618         PR gdb/18644:
7619         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7620         16-byte floats.
7621         * i386-tdep.c (i386_floatformat_for_type): Use
7622         floatformats_ia64_quad for the 16-byte floating point component
7623         within a fortran 32-byte complex number.
7624
7625 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7628         delete default constructor.
7629         (find_partial_die): Update to return const struct.
7630         (partial_die_parent_scope): Move variable declaration into scope
7631         of its use and change its type to auto.
7632         (guess_partial_die_structure_name): Likewise.
7633         (partial_die_info::fixup): Likewise.
7634
7635 2019-05-17  Tom Tromey  <tromey@adacore.com>
7636
7637         * source.c (find_and_open_source): Remove cast.
7638
7639 2019-05-17  Tom Tromey  <tromey@adacore.com>
7640
7641         * annotate.c (annotate_source): Make "filename" const.
7642         * annotate.h (annotate_source): Use const.
7643
7644 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7645
7646         * disasm.c (set_disassembler_options): Send errors to stderr.
7647
7648 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7649
7650         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7651         (cli_interp_base::set_logging): Check debug_redirect.
7652         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7653         * cli/cli-logging.c (debug_redirect): Add static variable.
7654         (pop_output_files): Add default param.
7655         (handle_redirections): Print debug setting.
7656         (show_logging_command): Likewise.
7657         (_initialize_cli_logging): Add debugredirect command.
7658         * interps.c (current_interp_set_logging): Add debug_redirect
7659         parameter.
7660         * interps.h (set_logging): Add debug_redirect parameter.
7661         (current_interp_set_logging): Likewise.
7662         * mi/mi-common.h: Likewise.
7663         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7664
7665 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7666             Tom Tromey  <tromey@adacore.com>
7667
7668         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7669         directly.
7670         * cli/cli-interp.h (make_logging_output): Remove declaration.
7671         * cli/cli-logging.c (make_logging_output): Remove function.
7672         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7673         directly.
7674         * ui-file.c (tee_file::tee_file): Remove bools.
7675         (tee_file::~tee_file): Remove deletes.
7676         * ui-file.h (tee_file): Remove bools.
7677
7678 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7679
7680         * mi/mi-cmds.h (mi_cmd_complete): New function.
7681         * mi/mi-main.c (mi_cmd_complete): Likewise.
7682         * mi/mi-cmds.c: Define new MI command -complete.
7683         * NEWS: Mention new -complete command.
7684
7685 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7686
7687         * completer.h (complete): New function.
7688         * completer.c (complete): Likewise.
7689         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7690         function defined in completer.h.
7691
7692 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7693
7694         * MAINTAINERS (Write After Approval): Add myself.
7695
7696 2019-05-17  Tom de Vries  <tdevries@suse.de>
7697
7698         PR gdb/24094
7699         * dwarf2read.c (struct cu_partial_die_info): New struct.
7700         (find_partial_die): Return cu_partial_die_info.
7701         (partial_die_parent_scope, guess_partial_die_structure_name)
7702         (partial_die_info::fixup): Handle new return type of find_partial_die.
7703
7704 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7705
7706         PR breakpoints/24541
7707         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7708         "std::string", simplifying the algorithm.
7709
7710 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7711
7712         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7713         (stap_static_probe_ops::get_probes): Likewise.
7714
7715 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7716
7717         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7718         '-')" and "else if".
7719         (stap_parse_single_operand): Join checks for
7720         "gdbarch_stap_parse_special_token_p" and
7721         "gdbarch_stap_parse_special_token" in the same "if" statement.
7722         Invert check when verifying for operation on register
7723         displacement.
7724
7725 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7726
7727         * stap-probe.c (stap_get_opcode): Update comment.
7728         (stap_get_expected_argument_type): Likewise.
7729         (handle_stap_probe): Likewise.
7730
7731 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7732
7733         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7734         return type to 'bool'.  Adjust comment.  Use 'bool' when
7735         appropriate.
7736         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7737         * stap-probe.c (stap_parse_argument_1): Likewise.
7738         (stap_is_operator): Likewise.
7739         (stap_is_generic_prefix): Likewise.
7740         (stap_is_register_prefix): Likewise.
7741         (stap_is_register_indirection_prefix): Likewise.
7742         (stap_is_integer_prefix): Likewise.
7743         (stap_generic_check_suffix): Likewise.
7744         (stap_check_integer_suffix): Likewise.
7745         (stap_check_register_suffix): Likewise.
7746         (stap_check_register_indirection_suffix): Likewise.
7747         (stap_parse_register_operand): Likewise.
7748         (stap_parse_single_operand): Likewise.
7749         (stap_parse_argument_1): Likewise.
7750         (stap_probe::get_argument_count): Likewise.
7751         (stap_is_operator): Likewise.
7752
7753 2019-05-16  Tom Tromey  <tromey@adacore.com>
7754
7755         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7756         keyword to foreach.
7757
7758 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7759
7760         * linux-thread-db.c (try_thread_db_load_1): Change return type
7761         to bool.
7762         (try_thread_db_load): Likewise.
7763         (try_thread_db_load_from_pdir_1): Likewise.
7764         (try_thread_db_load_from_pdir): Likewise.
7765         (try_thread_db_load_from_sdir): Likewise.
7766         (try_thread_db_load_from_dir): Likewise.
7767         (thread_db_load_search): Likewise.
7768         (has_libpthread): Likewise.
7769         (thread_db_load): Likewise.
7770
7771 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7772
7773         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7774         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7775         NULL, and complain/return if that's the case.
7776
7777 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7778
7779         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7780         (advance, posn, abstract_read_memory): New functions.
7781         [struct mem_read_abstraction]: New struct.
7782         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7783
7784 2019-05-14  Tom Tromey  <tromey@adacore.com>
7785
7786         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7787         value is not lval_memory.
7788
7789 2019-05-14  Tom Tromey  <tromey@adacore.com>
7790
7791         * solib.c (info_sharedlibrary_command): Style the file name.
7792
7793 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7794
7795         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7796         (aarch64_vnv_type): Likewise.
7797         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7798         * common/tdesc.c: Likewise.
7799         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7800         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7801         * features/aarch64-fpu.xml: Add ieee half view.
7802         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7803         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7804         * gdbtypes.h (struct builtin_type): Likewise.
7805         (struct objfile_type): Likewise.
7806
7807 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7808
7809         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7810         typo.
7811         * location.h (string_to_event_location): Likewise.
7812
7813 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7814
7815         GDB 8.3 released.
7816
7817 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7818
7819         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7820         New variable declaration.
7821         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7822         New variable.
7823         (print_one_breakpoint): Use ui_out::test_flags and new global
7824         variable to compute use_fixed_output.
7825         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7826         Remove.
7827         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7828         (mi_multi_location_breakpoint_output_fixed): Remove.
7829         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7830         new variable.
7831         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7832         fix_multi_location_breakpoint_output flag if version >= 3.
7833         * ui-out.h (enum ui_out_flag)
7834         <fix_multi_location_breakpoint_output>: New enumerator.
7835
7836 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7837
7838         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7839
7840 2019-05-10  Tom Tromey  <tromey@adacore.com>
7841
7842         * ada-lang.c (catch_ada_completer): New function.
7843         (_initialize_ada_language): Use it.
7844
7845 2019-05-10  Tom Tromey  <tromey@adacore.com>
7846
7847         * thread.c (print_thread_info): Make "requested_threads" const.
7848         * gdbthread.h (print_thread_info): Make "requested_threads"
7849         const.
7850         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7851         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7852
7853 2019-05-08  Tom Tromey  <tom@tromey.com>
7854
7855         * gdbtypes.c (objfile_type_data): Change type.
7856         (objfile_type, _initialize_gdbtypes): Update.
7857
7858 2019-05-08  Tom Tromey  <tom@tromey.com>
7859
7860         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7861         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7862         (_initialize_dwarf2_frame): Update.
7863
7864 2019-05-08  Tom Tromey  <tom@tromey.com>
7865
7866         * objc-lang.c (objc_objfile_data): Change type.
7867         (find_methods): Update.
7868         (_initialize_objc_lang): Remove.
7869
7870 2019-05-08  Tom Tromey  <tom@tromey.com>
7871
7872         * stabsread.c (rs6000_builtin_type_data): Change type.
7873         (rs6000_builtin_type, _initialize_stabsread): Update.
7874
7875 2019-05-08  Tom Tromey  <tom@tromey.com>
7876
7877         * mips-tdep.c (mips_pdr_data): Remove.
7878         (_initialize_mips_tdep): Update.
7879
7880 2019-05-08  Tom Tromey  <tom@tromey.com>
7881
7882         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7883         (hppa_init_objfile_priv_data, read_unwind_info)
7884         (find_unwind_entry, _initialize_hppa_tdep): Update.
7885
7886 2019-05-08  Tom Tromey  <tom@tromey.com>
7887
7888         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7889         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7890         on obstack.
7891         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7892
7893 2019-05-08  Tom Tromey  <tom@tromey.com>
7894
7895         * mdebugread.c (basic_type_data): Change type.
7896         (basic_type, _initialize_mdebugread): Update.
7897
7898 2019-05-08  Tom Tromey  <tom@tromey.com>
7899
7900         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7901
7902 2019-05-08  Tom Tromey  <tom@tromey.com>
7903
7904         * nto-tdep.c (nto_inferior_data_reg): Change type.
7905         (nto_inferior_data): Update.
7906         (nto_inferior_data_cleanup, nto_new_inferior_data)
7907         (_initialize_nto_tdep): Remove.
7908         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7909
7910 2019-05-08  Tom Tromey  <tom@tromey.com>
7911
7912         * ada-lang.c (struct ada_inferior_data): Add initializers.
7913         (ada_inferior_data): Change type.
7914         (ada_inferior_data_cleanup): Remove.
7915         (get_ada_inferior_data, ada_inferior_exit)
7916         (struct ada_pspace_data): Add initializers, destructor.
7917         (ada_pspace_data_handle): Change type.
7918         (get_ada_pspace_data): Update.
7919         (ada_pspace_data_cleanup): Remove.
7920
7921 2019-05-08  Tom Tromey  <tom@tromey.com>
7922
7923         * coffread.c (struct coff_symfile_info): Add initializers.
7924         (coff_objfile_data_key): Move lower.  Change type.
7925         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7926         Update.
7927         (coff_free_info): Remove.
7928
7929 2019-05-08  Tom Tromey  <tom@tromey.com>
7930
7931         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7932         (fbsd_pspace_data_handle): Move lower.  Change type.
7933         (get_fbsd_pspace_data): Update.
7934         (fbsd_pspace_data_cleanup): Remove.
7935         (_initialize_fbsd_tdep): Update.
7936
7937 2019-05-08  Tom Tromey  <tom@tromey.com>
7938
7939         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7940         (get_ada_tasks_pspace_data): Update.
7941         (ada_tasks_pspace_data_cleanup): Remove.
7942         (_initialize_tasks): Update.
7943         (ada_tasks_inferior_data_handle): Change type.
7944         (get_ada_tasks_inferior_data): Update.
7945         (ada_tasks_inferior_data_cleanup): Remove.
7946         (struct ada_tasks_pspace_data): Add initializers.
7947
7948 2019-05-08  Tom Tromey  <tom@tromey.com>
7949
7950         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7951         * symfile-debug.c (debug_sym_get_probes): Change type.
7952         * stap-probe.c (handle_stap_probe):
7953         (stap_static_probe_ops::get_probes): Change type.
7954         * probe.h (class static_probe_ops) <get_probes>: Change type.
7955         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7956         (parse_probes_in_pspace): Update.
7957         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7958         Update.
7959         (any_static_probe_ops::get_probes): Change type.
7960         * elfread.c (elfread_data): New typedef.
7961         (probe_key): Change type.
7962         (elf_get_probes): Likewise.  Update.
7963         (probe_key_free): Remove.
7964         (_initialize_elfread): Update.
7965         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7966         Change type.
7967         (dtrace_process_dof_probe, dtrace_process_dof)
7968         (dtrace_static_probe_ops::get_probe): Change type.
7969
7970 2019-05-08  Tom Tromey  <tom@tromey.com>
7971
7972         * xcoffread.c (struct xcoff_symfile_info): Rename from
7973         coff_symfile_info.  Add initializers.
7974         (xcoff_objfile_data_key): Move lower.  Change type.
7975         (XCOFF_DATA): Rewrite.
7976         (xcoff_free_info): Remove.
7977         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7978         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7979         (xcoff_initial_scan): Update.
7980
7981 2019-05-08  Tom Tromey  <tom@tromey.com>
7982
7983         * solib-svr4.c (struct svr4_info): Add initializers and
7984         destructor.
7985         <probes_table>: Now an htab_up.
7986         (solib_svr4_pspace_data): Change type.
7987         (free_probes_table): Simplify.
7988         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7989         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7990         (probes_table_remove_objfile_probes, register_solib_event_probe)
7991         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7992         (_initialize_svr4_solib): Update.
7993
7994 2019-05-08  Tom Tromey  <tom@tromey.com>
7995
7996         * remote.c (remote_pspace_data): Change type.
7997         (remote_pspace_data_cleanup): Remove.
7998         (get_remote_exec_file, set_pspace_remote_exec_file)
7999         (_initialize_remote): Update.
8000
8001 2019-05-08  Tom Tromey  <tom@tromey.com>
8002
8003         * breakpoint.c (breakpoint_objfile_key): Change type.
8004         (get_breakpoint_objfile_data): Update.
8005         (free_breakpoint_objfile_data): Remove.
8006         (_initialize_breakpoint): Update.
8007
8008 2019-05-08  Tom Tromey  <tom@tromey.com>
8009
8010         * linux-tdep.c (struct linux_info): Add initializers.
8011         (linux_inferior_data): Move.  Change type.
8012         (invalidate_linux_cache_inf): Update.
8013         (linux_inferior_data_cleanup): Remove.
8014         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8015
8016 2019-05-08  Tom Tromey  <tom@tromey.com>
8017
8018         * auxv.c (auxv_inferior_data): Move.  Change type.
8019         (auxv_inferior_data_cleanup): Remove.
8020         (invalidate_auxv_cache_inf): Rewrite.
8021         (get_auxv_inferior_data, _initialize_auxv): Update.
8022
8023 2019-05-08  Tom Tromey  <tom@tromey.com>
8024
8025         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8026         (symfile_debug_objfile_data_key): Change type.
8027         (symfile_debug_installed, debug_qf_has_symbols)
8028         (debug_qf_find_last_source_symtab)
8029         (debug_qf_forget_cached_source_info)
8030         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8031         (debug_qf_print_stats, debug_qf_dump)
8032         (debug_qf_expand_symtabs_for_function)
8033         (debug_qf_expand_all_symtabs)
8034         (debug_qf_expand_symtabs_with_fullname)
8035         (debug_qf_map_matching_symbols)
8036         (debug_qf_expand_symtabs_matching)
8037         (debug_qf_find_pc_sect_compunit_symtab)
8038         (debug_qf_map_symbol_filenames)
8039         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8040         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8041         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8042         (debug_sym_read_linetable, debug_sym_relocate): Update.
8043         (symfile_debug_free_objfile): Remove.
8044         (install_symfile_debug_logging, _initialize_symfile_debug):
8045         Update.
8046
8047 2019-05-08  Tom Tromey  <tom@tromey.com>
8048
8049         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8050         allocate_on_obstack.
8051         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8052         (get_dwarf2_per_objfile): Update.
8053         (set_dwarf2_per_objfile): Remove.
8054         (dwarf2_has_info, dwarf2_get_section_info): Update.
8055         (dwarf2_free_objfile): Remove.
8056         (_initialize_dwarf2_read): Update.
8057
8058 2019-05-08  Tom Tromey  <tom@tromey.com>
8059
8060         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8061         initializers.
8062         <unsupported_script_warning_printed,
8063         script_not_found_warning_printed>: Now bool.
8064         (auto_load_pspace_data): Change type.
8065         (~auto_load_pspace_info): Rename from
8066         auto_load_pspace_data_cleanup.
8067         (get_auto_load_pspace_data, init_loaded_scripts_info)
8068         (clear_section_scripts, maybe_print_unsupported_script_warning)
8069         (maybe_print_script_not_found_warning, _initialize_auto_load):
8070         Update.
8071
8072 2019-05-08  Tom Tromey  <tom@tromey.com>
8073
8074         * objfiles.c (objfile_pspace_info): Add destructor and
8075         initializers.
8076         (objfiles_pspace_data): Change type.
8077         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8078         (get_objfile_pspace_data): Update.
8079         (objfiles_bfd_data): Change type.
8080         (get_objfile_bfd_data): Update.
8081         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8082
8083 2019-05-08  Tom Tromey  <tom@tromey.com>
8084
8085         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8086         Change type.
8087         (get_catch_syscall_inferior_data): Update.
8088         (catch_syscall_inferior_data_cleanup): Remove.
8089         (_initialize_break_catch_syscall): Update.
8090
8091 2019-05-08  Tom Tromey  <tom@tromey.com>
8092
8093         * inflow.c (struct terminal_info): Add destructor and
8094         initializers.
8095         (inflow_inferior_data): Change type.
8096         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8097         (get_inflow_inferior_data, inflow_inferior_exit)
8098         (swap_terminal_info, _initialize_inflow): Update.
8099
8100 2019-05-08  Tom Tromey  <tom@tromey.com>
8101
8102         * target-dcache.c (target_dcache_cleanup): Remove.
8103         (target_dcache_aspace_key): Change type.
8104         (target_dcache_init_p, target_dcache_invalidate)
8105         (target_dcache_get, target_dcache_get_or_init)
8106         (_initialize_target_dcache): Update.
8107         * dcache.h (struct dcache_deleter): New.
8108
8109 2019-05-08  Tom Tromey  <tom@tromey.com>
8110
8111         * symtab.c (struct symbol_cache): Add destructor and
8112         initializers.
8113         (symbol_cache_key): Move.  Change type.
8114         (make_symbol_cache, free_symbol_cache): Remove.
8115         (get_symbol_cache): Update.
8116         (symbol_cache_cleanup): Remove.
8117         (ALL_PSPACES, symbol_cache_flush)
8118         (maintenance_print_symbol_cache)
8119         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8120         Update.
8121
8122 2019-05-08  Tom Tromey  <tom@tromey.com>
8123
8124         * symtab.c (struct main_info): Add destructor and initializers.
8125         (main_progspace_key): Move.  Change type.
8126         (get_main_info): Update.
8127         (main_info_cleanup): Remove.
8128         (_initialize_symtab): Update.
8129
8130 2019-05-08  Tom Tromey  <tom@tromey.com>
8131
8132         * registry.h (DECLARE_REGISTRY): Define the _key class.
8133
8134 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * NEWS: Merge two 'New commands' sections.
8137
8138 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8139
8140         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8141         parameter and use Ada language definition instead.
8142         (ada_val_print_ptr): Remove unused language parameter.
8143         (ada_val_print_num): Remove language parameter and use Ada language
8144         definition instead.
8145         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8146         parameter.
8147         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8148         parameter and use Ada language definition instead.
8149         (ada_val_print_1): Update all ada_val_print_xxx calls.
8150         Remove language parameter.
8151         (ada_val_print): Update ada_val_print_1 call.
8152
8153 2019-05-08  Tom Tromey  <tromey@adacore.com>
8154
8155         * remote.c (remote_hw_watchpoint_limit)
8156         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8157         Now static.
8158
8159 2019-05-08  Tom Tromey  <tromey@adacore.com>
8160
8161         * maint.c (_initialize_maint_cmds): Move initialization code to
8162         remote.c.
8163         (watchdog, show_watchdog): Move to remote.c.
8164         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8165         "watchdog" static.
8166         (_initialize_remote): Move initialization code from maint.c.
8167         * defs.h (watchdog): Don't declare.
8168
8169 2019-05-08  Tom Tromey  <tromey@adacore.com>
8170
8171         * tui/tui-interp.c: Include main.h.
8172         * interps.c: Include main.h.
8173         * main.h (interpreter_p): Declare.
8174         * defs.h (interpreter_p): Don't declare.
8175
8176 2019-05-08  Tom Tromey  <tromey@adacore.com>
8177
8178         * dwarf2loc.c: Include dwarf2read.h.
8179         * defs.h (read_unsigned_leb128): Don't declare.
8180         * dwarf2read.h (read_unsigned_leb128): Declare.
8181
8182 2019-05-08  Tom Tromey  <tromey@adacore.com>
8183
8184         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8185         method.
8186
8187 2019-05-08  Tom Tromey  <tromey@adacore.com>
8188
8189         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8190         when no wrap column is set.
8191
8192 2019-05-08  Tom Tromey  <tromey@adacore.com>
8193
8194         * c-lang.c (c_get_string): Handle non-C-style arrays.
8195
8196 2019-05-08  Tom Tromey  <tromey@adacore.com>
8197
8198         * typeprint.c (print_offset_data::update): Print the bit offset,
8199         not the number of bits remaining.
8200
8201 2019-05-08  Tom Tromey  <tromey@adacore.com>
8202
8203         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8204         padding at end of comment.
8205
8206 2019-05-08  Tom Tromey  <tromey@adacore.com>
8207
8208         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8209         Compare main types.
8210
8211 2019-05-06  Tom Tromey  <tom@tromey.com>
8212
8213         * common/scoped_mmap.c: Include common-defs.h.
8214         * common/scoped_mmap.h: Don't include config.h.
8215
8216 2019-05-04  Tom Tromey  <tom@tromey.com>
8217
8218         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8219         (struct aarch64_call_info): Add initializers.
8220         <si>: Now a std::vector.
8221         (pass_on_stack, aarch64_push_dummy_call): Update.
8222
8223 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8224             Tom Tromey  <tom@tromey.com>
8225
8226         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8227         (ppc_threads): Now a std::vector.  Now static.
8228         (hwdebug_find_thread_points_by_tid)
8229         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8230         Update.
8231
8232 2019-05-04  Tom Tromey  <tom@tromey.com>
8233
8234         * arc-tdep.c (arc_tdesc_init): Return bool.
8235
8236 2019-05-04  Tom Tromey  <tom@tromey.com>
8237
8238         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8239         Use gdb_assert_not_reached.
8240
8241 2019-05-04  Tom Tromey  <tom@tromey.com>
8242
8243         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8244         "false".
8245
8246 2019-05-04  Tom Tromey  <tom@tromey.com>
8247
8248         * arc-tdep.c (arc_tdesc_init): Use bool.
8249
8250 2019-05-04  Tom Tromey  <tom@tromey.com>
8251
8252         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8253
8254 2019-05-04  Tom Tromey  <tom@tromey.com>
8255
8256         * cli/cli-cmds.c (valid_command_p): Return bool.
8257
8258 2019-05-04  Tom Tromey  <tom@tromey.com>
8259
8260         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8261         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8262
8263 2019-05-04  Raul Tambre  <raul@tambre.ee>
8264
8265         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8266         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8267         operator for comparison.
8268
8269 2019-05-04  Tom Tromey  <tom@tromey.com>
8270
8271         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8272         (lookup_partial_symbol, print_partial_symbols)
8273         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8274         (psymbol_compare): Update.
8275         (add_psymbol_to_bcache): Clear the entire psymbol.
8276         (maintenance_check_psymtabs): Update.
8277         * psympriv.h (struct partial_symbol): Don't derive from
8278         general_symbol_info.
8279         <obj_section, unrelocated_address, address,
8280         set_unrelocated_address>: Update.
8281         <ginfo>: New member.
8282         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8283         (debug_names::write_psymbols): Update.
8284
8285 2019-05-04  Tom de Vries  <tdevries@suse.de>
8286
8287         * contrib/cc-with-tweaks.sh: Support -n arg.
8288
8289 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8290
8291         * corelow.c (core_target::detach): Ensure frame cache and
8292         register caches are cleared.
8293         inferior.c (exit_inferior_1): Likewise.
8294
8295 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8296             Tom Tromey  <tom@tromey.com>
8297
8298         * dictionary.c (collate_pending_symbols_by_language): Remove
8299         "struct" from foreach.
8300         * symtab.c (lookup_global_symbol_from_objfile)
8301         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8302         foreach.
8303         * ser-tcp.c (net_open): Remove "struct" from foreach.
8304         * objfiles.c (objfile_relocate, objfile_rebase)
8305         (objfile_has_symbols): Remove "struct" from foreach.
8306         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8307         from foreach.
8308         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8309         foreach.
8310         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8311         "struct" from foreach.
8312         * ada-lang.c (create_excep_cond_exprs)
8313         (ada_exception_catchpoint_cond_string): Remove "struct" from
8314         foreach.
8315
8316 2019-05-03  Tom Tromey  <tromey@adacore.com>
8317
8318         * ada-exp.y (convert_char_literal): Check suffix of each
8319         enumerator.
8320
8321 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8322
8323         PR ada/21406:
8324         * ada-exp.y (yywrap): Don't define.
8325         * ada-lex.l (%option): Add noyywrap
8326         (yywrap): Remove.
8327
8328 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8329
8330         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8331         _WIN32_WINNT to the XP level, unless already defined to a higher
8332         level.
8333
8334         * unittests/parse-connection-spec-selftests.c:
8335         * ser-tcp.c:
8336         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8337         override.
8338
8339         * symfile.c (find_separate_debug_file): Remove colon from the
8340         drive spec of DOS/Windows file names of the target, so that the
8341         file name produced from DEBUGDIR and the target's directory will
8342         be valid on DOS/Windows systems.
8343
8344 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8345
8346         * rust-lang.c (val_print_struct): Handle printing structures
8347         containing strings.
8348
8349 2019-05-02  Tom Tromey  <tromey@adacore.com>
8350
8351         * valarith.c (_initialize_valarith): Remove.
8352
8353 2019-05-01  Tom Tromey  <tromey@adacore.com>
8354
8355         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8356         bitfields.
8357
8358 2019-05-01  Tom Tromey  <tromey@adacore.com>
8359
8360         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8361         for big-endian copies.
8362
8363 2019-04-30  Ali Tamur  <tamur@google.com>
8364         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8365         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8366         (read_3_bytes): New function.
8367
8368 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8369
8370         * windows-nat.c (main_thread_id): Delete.
8371         (handle_output_debug_string): Replace main_thread_id by
8372         current_event.dwThreadId.
8373         (fake_create_process): Likewise.
8374         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8375         Do not set main_thread_id.
8376         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8377         current_event.dwThreadId.
8378         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8379
8380 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8381
8382         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8383         Use current_event.dwThreadId instead of main_thread_id.
8384
8385 2019-04-30  Tom Tromey  <tromey@adacore.com>
8386
8387         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8388         (create_excep_cond_exprs): Iterate over program spaces.
8389         (ada_exception_catchpoint_cond_string): Examine all minimal
8390         symbols for exception types.
8391
8392 2019-04-30  Tom Tromey  <tromey@adacore.com>
8393
8394         PR c++/24470:
8395         * dwarf2read.c (process_structure_scope): Handle case where type
8396         has template parameters but no symbol was created.
8397
8398 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8399             Chris January  <chris.january@arm.com>
8400
8401         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8402         qualifier.
8403         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8404
8405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8406
8407         * f-typeprint.c (f_print_type): Update rules for printing
8408         whitespace.
8409         (f_type_print_varspec_suffix): Likewise.
8410
8411 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8412             Chris January  <chris.january@arm.com>
8413
8414         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8415         function arguments.
8416
8417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8418
8419         * f-lang.c (build_fortran_types): Change name of void type to
8420         lower case.
8421         * f-typeprint.c (f_type_print_base): Print the name of the void
8422         type, rather than a fixed string.
8423         * f-valprint.c (f_decorations): Use lower case void string.
8424
8425 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8426             Chris January  <chris.january@arm.com>
8427
8428         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8429         types for Fortran.
8430
8431 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8432             Chris January  <chris.january@arm.com>
8433             David Lecomber  <david.lecomber@arm.com>
8434
8435         * f-exp.y (BINOP_INTRINSIC): New token.
8436         (exp): New parser rule handling BINOP_INTRINSIC.
8437         (f77_keywords): Add new builtin procedures.
8438         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8439         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8440         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8441         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8442         (print_unop_subexp_f): New function.
8443         (print_binop_subexp_f): New function.
8444         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8445         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8446         (dump_subexp_body_f): Likewise.
8447         (operator_check_f): Likewise.
8448         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8449         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8450
8451 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8452
8453         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8454         UNOP_KIND.
8455         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8456         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8457         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8458         (operator_length_f): New fuction.
8459         (print_subexp_f): New function.
8460         (op_name_f): New function.
8461         (dump_subexp_body_f): New function.
8462         (operator_check_f): New function.
8463         (exp_descriptor_f): Replace standard expression handling functions
8464         with new functions.
8465         * gdb/fortran-operator.def: New file.
8466         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8467         * gdb/std-operator.def: Remove UNOP_KIND.
8468
8469 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8470
8471         * std-operator.def: Remove unbalanced, stray double quote
8472         character.
8473
8474 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8475             Chris January  <chris.january@arm.com>
8476             Daniel Everett  <daniel.everett@arm.com>
8477             Nick Forrington  <nick.forrington@arm.com>
8478             Richard Bunt  <richard.bunt@arm.com>
8479
8480         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8481         of depth when printing anonymous structs or unions.
8482         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8483         Don't print either the top-level value, or the children if the
8484         max-depth is exceeded.
8485         (ppscm_print_children): When printing the key of a map, allow one
8486         extra level of depth.
8487         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8488         print either the top-level value, or the children if the max-depth
8489         is exceeded.
8490         (print_children): When printing the key of a map, allow one extra
8491         level of depth.
8492         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8493         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8494         (user_print_options): Initialise max_depth field.
8495         (val_print_scalar_or_string_type_p): New function.
8496         (val_print): Check to see if the max depth has been reached.
8497         (val_print_check_max_depth): Define new function.
8498         (show_print_max_depth): New function.
8499         (_initialize_valprint): Add 'print max-depth' option.
8500         * valprint.h (struct value_print_options) <max_depth>: New field.
8501         (val_print_check_max_depth): Declare new function.
8502         * NEWS: Document new feature.
8503
8504 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8505
8506         * ada-lang.c (ada_language_defn): Initialise new field.
8507         * c-lang.c (c_is_string_type_p): New function.
8508         (c_language_defn): Initialise new field.
8509         (cplus_language_defn): Initialise new field.
8510         (asm_language_defn): Initialise new field.
8511         (minimal_language_defn): Initialise new field.
8512         * c-lang.h (c_is_string_type_p): Declare new function.
8513         * d-lang.c (d_language_defn): Initialise new field.
8514         * f-lang.c (f_is_string_type_p): New function.
8515         (f_language_defn): Initialise new field.
8516         * go-lang.c (go_is_string_type_p): New function.
8517         (go_language_defn): Initialise new field.
8518         * language.c (default_is_string_type_p): New function.
8519         (unknown_language_defn): Initialise new field.
8520         (auto_language_defn): Initialise new field.
8521         * language.h (struct language_defn) <la_is_string_type_p>: New
8522         member variable.
8523         (default_is_string_type_p): Declare new function.
8524         * m2-lang.c (m2_language_defn): Initialise new field.
8525         * objc-lang.c (objc_language_defn): Initialise new field.
8526         * opencl-lang.c (opencl_language_defn): Initialise new field.
8527         * p-lang.c (pascal_is_string_type_p): New function.
8528         (pascal_language_defn): Initialise new field.
8529         * rust-lang.c (rust_is_string_type_p): New function.
8530         (rust_language_defn): Initialise new field.
8531
8532 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8533
8534         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8535         New field.
8536         * ada-lang.c (ada_language_defn): Initialise new field.
8537         * c-lang.c (c_language_defn): Likewise.
8538         (cplus_language_defn): Likewise.
8539         (asm_language_defn): Likewise.
8540         (minimal_language_defn): Likewise.
8541         * d-lang.c (d_language_defn): Likewise.
8542         * f-lang.c (f_language_defn): Likewise.
8543         * go-lang.c (go_language_defn): Likewise.
8544         * language.c (unknown_language_defn): Likewise.
8545         (auto_language_defn): Likewise.
8546         * m2-lang.c (m2_language_defn): Likewise.
8547         * objc-lang.c (objc_language_defn): Likewise.
8548         * opencl-lang.c (opencl_language_defn): Likewise.
8549         * p-lang.c (pascal_language_defn): Likewise.
8550         * rust-lang.c (rust_language_defn): Likewise.
8551
8552 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8553
8554         * ada-lang.c (ada_is_character_type): Change return type to bool.
8555         (ada_is_string_type): Likewise.
8556         * ada-lang.h (ada_is_character_type): Update declaration
8557         (ada_is_string_type): Likewise.
8558
8559 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8560
8561         Support style in 'frame|thread apply'
8562
8563         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8564         * record.c (record_start, record_stop): Update callers of
8565         execute_command_to_string with false.
8566         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8567         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8568         methods.
8569         (class string_file): New constructor with term_out parameter.
8570         Override methods term_out and can_emit_style_escape.  New member
8571         term_out.
8572         (class stdio_file): Override can_emit_style_escape.
8573         (class tee_file): Override term_out and can_emit_style_escape.
8574         * utils.h (can_emit_style_escape): Remove.
8575         * utils.c (can_emit_style_escape): Likewise.
8576         Update all callers of can_emit_style_escape (SOMESTREAM) to
8577         SOMESTREAM->can_emit_style_escape.
8578         * source-cache.c (source_cache::get_source_lines): Likewise.
8579         * stack.c (frame_apply_command_count): Call execute_command_to_string
8580         passing the term_out characteristic of the current gdb_stdout.
8581         * thread.c (thr_try_catch_cmd): Likewise.
8582         * top.c (execute_command_to_string): pass term_out parameter
8583         to construct the string_file for the command output.
8584         * ui-file.c (term_cli_styling): New function (most code moved
8585         from utils.c can_emit_style_escape).
8586         (string_file::string_file, string_file::can_emit_style_escape,
8587         stdio_file::can_emit_style_escape, tee_file::term_out,
8588         tee_file::can_emit_style_escape): New functions.
8589
8590 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8591
8592         * NEWS: Mention the new set|show may-call-functions.
8593         * infcall.c (may_call_functions_p): New variable.
8594         (show_may_call_functions_p): New function.
8595         (call_function_by_hand_dummy): Throws an error if not
8596         may-call-functions.
8597         (_initialize_infcall): Call add_setshow_boolean_cmd for
8598         may-call-functions.
8599
8600 2019-04-25  Keith Seitz  <keiths@redhat.com>
8601
8602         PR c++/24367
8603         * cp-support.c (inspect_type): Don't attempt substitutions
8604         of symbol with the same name.
8605
8606 2019-04-25  Tom Tromey  <tromey@adacore.com>
8607
8608         PR gdb/24475:
8609         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8610         static.
8611
8612 2019-04-25  Tom Tromey  <tromey@adacore.com>
8613
8614         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8615         rvalue reference.
8616         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8617         (gdb_xml_parser::parse): Use std::move.
8618         * python/python-internal.h (gdbpy_convert_exception): Take a const
8619         reference.
8620         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8621         std::move.
8622         * python/py-utils.c (gdbpy_convert_exception): Take a const
8623         reference.
8624         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8625         Use std::move.
8626         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8627         Use std::move.
8628         * mi/mi-main.c (mi_print_exception): Take a const reference.
8629         * main.c (handle_command_errors): Take a const reference.
8630         * linespec.c (parse_linespec): Use std::move.
8631         * infcall.c (run_inferior_call): Use std::move.
8632         (call_function_by_hand_dummy): Use std::move.
8633         * exec.c (try_open_exec_file): Use std::move.
8634         * exceptions.h (exception_print, exception_fprintf)
8635         (exception_print_same): Update.
8636         * exceptions.c (print_exception, exception_print)
8637         (exception_fprintf, exception_print_same): Change parameters to
8638         const reference.
8639         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8640         * common/new-op.c: Use std::move.
8641         * common/common-exceptions.h (struct gdb_exception): Add move
8642         constructor.
8643         (struct gdb_exception_error, struct gdb_exception_quit, struct
8644         gdb_quit_bad_alloc): Change constructor to move constructor.
8645         (throw_exception): Change parameter to rvalue reference.
8646         * common/common-exceptions.c (throw_exception): Take rvalue
8647         reference.
8648         * cli/cli-interp.c (safe_execute_command): Use std::move.
8649         * breakpoint.c (insert_bp_location, location_to_sals): Use
8650         std::move.
8651
8652 2019-04-25  Tom Tromey  <tromey@adacore.com>
8653
8654         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8655         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8656         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8657         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8658         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8659         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8660         guile/scm-value.c: Use unpack.
8661         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8662         gdbscm_gdb_exception.
8663         (gdbscm_throw_gdb_exception): Likewise.
8664         (struct gdbscm_gdb_exception): New.
8665         (unpack): New function.
8666         (gdbscm_wrap): Use unpack.
8667
8668 2019-04-25  Tom Tromey  <tromey@adacore.com>
8669
8670         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8671         (gdb_rl_callback_handler): Use std::move.
8672         * common/common-exceptions.h (struct gdb_exception): Add move
8673         assignment operator.
8674         (throw_exception_sjlj): Change "exception" to const reference.
8675         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8676         (throw_exception_sjlj): Change "exception" to const reference.
8677
8678 2019-04-25  Tom Tromey  <tromey@adacore.com>
8679
8680         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8681         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8682         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8683         Update.
8684         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8685         Update.
8686         * mi/mi-interp.c (mi_interp::exec): Update.
8687         * linespec.c (parse_linespec): Update.
8688         * infcall.c (run_inferior_call): Update.
8689         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8690         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8691         (gdbscm_lookup_global_symbol): Update.
8692         * guile/scm-param.c (gdbscm_parameter_value): Update.
8693         * guile/scm-frame.c (gdbscm_frame_read_register)
8694         (gdbscm_frame_read_var): Update.
8695         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8696         * exec.c (try_open_exec_file): Update.
8697         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8698         (gdb_rl_callback_handler): Update.
8699         * common/common-exceptions.h (exception_none): Don't declare.
8700         * common/common-exceptions.c (exception_none): Don't define.
8701         (struct catcher) <exception>: Update.
8702         * cli/cli-interp.c (safe_execute_command): Update.
8703         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8704
8705 2019-04-25  Ali Tamur  <tamur@google.com>
8706
8707         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8708         (read_attribute_value): Likewise.
8709         (dwarf2_read_addr_index): Update comment.
8710         (read_str_index): Add DW_FORM_strx.
8711         (dwarf2_string_attr): Likewise.
8712         (dwarf2_const_value_attr): Likewise.
8713         (dump_die_shallow): Likewise.
8714         (dwarf2_fetch_constant_bytes): Likewise.
8715         (skip_form_bytes): Likewise.
8716         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8717
8718 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8719
8720         PR corefiles/11608
8721         PR corefiles/18187
8722         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8723         OFFSET.  Verify if current mapping contains an ELF header.
8724         (linux_find_memory_regions_full): Adjust call to
8725         dump_mapping_p.
8726
8727 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8728             Kang Li <kanglictf@gmail.com>
8729
8730         PR gdb/21600
8731
8732         * dwarf2-frame.c (read_initial_length): Be consistent about using
8733         unsigned representation of length.
8734         (decode_frame_entry_1): Likewise.  Check for wraparound of
8735         end pointer as well as buffer overflow.
8736
8737 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8738
8739         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8740         "vq".
8741
8742 2019-04-24  Tom Tromey  <tromey@adacore.com>
8743
8744         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8745
8746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8747
8748         * s12z-tdep.c (s12z_unwind_pc): Delete.
8749         (s12z_unwind_sp): Delete.
8750         (s12z_gdbarch_init): Don't register deleted functions with
8751         gdbarch.
8752
8753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * rl78-tdep.c (rl78_unwind_sp): Delete.
8756         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8757
8758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8759
8760         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8761         (xstormy16_unwind_pc): Delete.
8762         (xstormy16_dummy_id): Delete.
8763         (xstormy16_gdbarch_init): Don't register deleted functions with
8764         gdbarch.
8765
8766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8767
8768         * vax-tdep.c (vax_unwind_pc): Delete.
8769         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8770
8771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8772
8773         * v850-tdep.c (v850_unwind_sp): Delete.
8774         (v850_unwind_pc): Delete.
8775         (v850_dummy_id): Delete.
8776         (v850_gdbarch_init): Don't register deleted functions with
8777         gdbarch.
8778
8779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8780
8781         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8782         (tilegx_unwind_pc): Delete.
8783         (tilegx_unwind_dummy_id): Delete.
8784         (tilegx_gdbarch_init): Don't register deleted functions with
8785         gdbarch.
8786
8787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8788
8789         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8790         (tic6x_dummy_id): Delete.
8791         (tic6x_gdbarch_init): Don't register deleted functions with
8792         gdbarch.
8793
8794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * sparc-tdep.c (sparc_unwind_pc): Delete.
8797         (sparc32_gdbarch_init): Don't register deleted function with
8798         gdbarch.
8799
8800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8801
8802         * sh-tdep.c (sh_unwind_sp): Delete.
8803         (sh_unwind_pc): Delete.
8804         (sh_dummy_id): Delete.
8805         (sh_gdbarch_init): Don't register deleted functions with
8806         gdbarch.
8807
8808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8809
8810         * score-tdep.c (score_unwind_sp): Delete.
8811         (score_unwind_pc): Delete.
8812         (score_dummy_id): Delete.
8813         (score_gdbarch_init): Don't register deleted functions with
8814         gdbarch.
8815
8816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8817
8818         * rx-tdep.c (rx_unwind_pc): Delete.
8819         (rx_unwind_sp): Delete.
8820         (rx_dummy_id): Delete.
8821         (rx_gdbarch_init): Don't register deleted functions with
8822         gdbarch.  Update comment.
8823
8824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8825
8826         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8827         (rs6000_dummy_id): Delete.
8828         (rs6000_gdbarch_init): Don't register deleted functions with
8829         gdbarch.
8830
8831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8832
8833         * or1k-tdep.c (or1k_dummy_id): Delete.
8834         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8835
8836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8837
8838         * nios2-tdep.c (nios2_dummy_id): Delete.
8839         (nios2_unwind_sp): Delete.
8840         (nios2_gdbarch_init): Don't register deleted functions with
8841         gdbarch.
8842
8843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * nds32-tdep.c (nds32_dummy_id): Delete.
8846         (nds32_unwind_pc): Delete.
8847         (nds32_unwind_sp): Delete.
8848         (nds32_gdbarch_init): Don't register deleted functions with
8849         gdbarch.
8850
8851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8852
8853         * msp430-tdep.c (msp430_unwind_pc): Delete.
8854         (msp430_unwind_sp): Delete.
8855         (msp430_dummy_id): Delete.
8856         (msp430_gdbarch_init): Don't register deleted functions with
8857         gdbarch.
8858
8859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * moxie-tdep.c (moxie_unwind_sp): Delete.
8862         (moxie_unwind_pc): Delete.
8863         (moxie_dummy_id): Delete.
8864         (moxie_gdbarch_init): Don't register deleted functions with
8865         gdbarch.
8866
8867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8868
8869         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8870         (mn10300_unwind_pc): Delete.
8871         (mn10300_unwind_sp): Delete.
8872         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8873         mn10300_unwind_sp.
8874         (mn10300_frame_unwind_init): Don't register deleted functions with
8875         gdbarch.
8876
8877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8878
8879         * mep-tdep.c (mep_unwind_pc): Delete.
8880         (mep_unwind_sp): Delete.
8881         (mep_dummy_id): Delete.
8882         (mep_gdbarch_init): Don't register deleted functions with
8883         gdbarch.
8884
8885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8886
8887         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8888         (m68hc11_unwind_sp): Delete.
8889         (m68hc11_gdbarch_init): Don't register deleted functions with
8890         gdbarch.
8891
8892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8893
8894         * m32r-tdep.c (m32r_unwind_sp): Delete.
8895         (m32r_unwind_pc): Delete.
8896         (m32r_dummy_id): Delete.
8897         (m32r_gdbarch_init): Don't register deleted functions with
8898         gdbarch.
8899
8900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8901
8902         * m32c-tdep.c (m32c_unwind_pc): Delete.
8903         (m32c_unwind_sp): Delete.
8904         (m32c_dummy_id): Delete.
8905         (m32c_gdbarch_init): Don't register deleted functions with
8906         gdbarch.
8907
8908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8909
8910         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8911         (lm32_unwind_pc): Delete.
8912         (lm32_dummy_id): Delete.
8913         (lm32_gdbarch_init): Don't register deleted functions with
8914         gdbarch.
8915
8916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8917
8918         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8919         (iq2000_unwind_pc): Delete.
8920         (iq2000_dummy_id): Delete.
8921         (iq2000_gdbarch_init): Don't register deleted functions with
8922         gdbarch.
8923
8924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * nds32-tdep.c (nds32_type_align): Delete.
8927         (nds32_push_dummy_call): Use type_align instead.
8928
8929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * arm-tdep.c (arm_type_align): Only handle vector override case.
8932         (arm_push_dummy_call): Use type_align.
8933         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8934
8935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8936
8937         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8938         case.
8939         (pass_on_stack): Use type_align.
8940         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8941         function.
8942
8943 2019-04-23  Tom Tromey  <tromey@adacore.com>
8944
8945         * dwarf2read.c (line_header::file_name_at): Remove unused
8946         overload.
8947
8948 2019-04-23  Tom de Vries  <tdevries@suse.de>
8949
8950         PR gdb/24438
8951         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8952         invocation.
8953
8954
8955 2019-03-27  Ali Tamur  <tamur@google.com>
8956
8957         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8958         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8959         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8960         (dwarf_expr_context::get_addr_index): Likewise
8961         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8962         (symbol_needs_eval_context::get_addr_index): Likewise
8963         (disassemble_dwarf_expression): Add DW_OP_addrx
8964         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8965         (read_cutu_die_from_dwo): Update comment
8966         (skip_one_die): Add DW_FORM_addrx
8967         (read_attribute_value): Likewise
8968         (var_decode_location): Add DW_OP_addrx
8969         (dwarf2_const_value_attr): Add DW_FORM_addrx
8970         (dump_die_shallow): Likewise
8971         (dwarf2_fetch_constant_bytes): Likewise
8972         (decode_locdesc): Add DW_OP_addrx
8973         (skip_form_bytes): Add DW_FORM_addrx
8974
8975 2019-04-22  Ali Tamur  <tamur@google.com>
8976
8977         * MAINTAINERS (Write After Approval): Add self.
8978
8979 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8980
8981         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8982         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8983         (open_symbol_file_object): Likewise.
8984         (svr4_default_sos): Add info parameter.
8985         (svr4_read_so_list): Likewise.
8986         (svr4_current_sos_direct): Adjust functions calls to pass down
8987         info.
8988         (svr4_current_sos_1): Add info parameter.
8989         (svr4_current_sos): Call get_svr4_info, pass info down to
8990         svr4_current_sos_1.
8991         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8992         get_svr4_info.
8993         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8994         get_svr4_info.
8995         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8996         to get_svr4_info.
8997         (probes_table_remove_objfile_probes): Likewise.
8998         (register_solib_event_probe): Add info parameter.
8999         (solist_update_incremental): Pass info parameter down to
9000         svr4_read_so_list.
9001         (disable_probes_interface): Add info parameter.
9002         (svr4_handle_solib_event): Pass current_program_space to
9003         get_svr4_info.  Adjust disable_probes_interface cleanup.
9004         (svr4_create_probe_breakpoints): Add info parameter, pass it
9005         down to register_solib_event_probe.
9006         (svr4_create_solib_event_breakpoints): Add info parameter,
9007         pass it down to svr4_create_probe_breakpoints.
9008         (enable_break): Pass info down to
9009         svr4_create_solib_event_breakpoints.
9010         (svr4_solib_create_inferior_hook): Pass current_program_space to
9011         get_svr4_info.
9012         (svr4_clear_solib): Likewise.
9013
9014 2019-04-22  Pedro Alves  <palves@redhat.com>
9015
9016         * solib-svr4.c (svr4_free_objfile_observer): New.
9017         (probe_and_action::objfile): New field.
9018         (probes_table_htab_remove_objfile_probes)
9019         (probes_table_remove_objfile_probes): New functions.
9020         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9021         in the new probe_and_action.  Don't store the probe in 'lookup'.
9022         (svr4_create_probe_breakpoints): Pass objfile to
9023         register_solib_event_probe.
9024         (_initialize_svr4_solib): Register a free_objfile observer.
9025
9026 2019-04-19  Tom Tromey  <tom@tromey.com>
9027
9028         * common/queue.h: Remove.
9029
9030 2019-04-19  Tom Tromey  <tom@tromey.com>
9031
9032         * event-loop.c: Don't include "common/queue.h".
9033
9034 2019-04-19  Tom Tromey  <tom@tromey.com>
9035
9036         * remote.c (remote_target): Use delete.
9037         * remote-notif.h: Include <list>, not "common/queue.h".
9038         (notif_client_p): Remove typedef.
9039         (remote_notif_state): Add constructor, destructor, initializer.
9040         <notif_queue>: Now a std::list.
9041         (remote_notif_state_xfree): Don't declare.
9042         * remote-notif.c (remote_notif_process, handle_notification)
9043         (remote_notif_state_allocate): Update.
9044         (~remote_notif_state): Rename from remote_notif_state_xfree.
9045
9046 2019-04-19  Tom Tromey  <tom@tromey.com>
9047
9048         * symfile.c (reread_symbols): Update.
9049         * objfiles.c (objfile_register_static_link)
9050         (objfile_lookup_static_link): Update
9051         (~objfile) Don't delete static_links.
9052         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9053
9054 2019-04-19  Tom Tromey  <tom@tromey.com>
9055
9056         * type-stack.h (struct type_stack) <insert>: Constify string.
9057         * type-stack.c (type_stack::insert): Constify string.
9058         * gdbtypes.h (lookup_template_type): Update.
9059         (address_space_name_to_int): Update.
9060         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9061         const.
9062         (lookup_template_type): Make name const.
9063         * c-exp.y: Update rules.
9064         (lex_one_token, classify_name, classify_inner_name)
9065         (c_print_token): Update.
9066         * p-exp.y: Update rules.
9067         (yylex): Update.
9068         * f-exp.y: Update rules.
9069         (yylex): Update.
9070         * d-exp.y: Update rules.
9071         (lex_one_token, classify_name, classify_inner_name): Update.
9072         * parse.c (write_dollar_variable, copy_name): Return std::string.
9073         * parser-defs.h (copy_name): Change return type.
9074         * m2-exp.y: Update rules.
9075         (yylex): Update.
9076         * go-exp.y (lex_one_token): Update.
9077         Update rules.
9078         (classify_unsafe_function, classify_packaged_name)
9079         (classify_name, yylex): Update.
9080
9081 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9082
9083         * configure.ac: add --enable-source-highlight switch.
9084         * configure: Regenerate.
9085         * top.c (print_gdb_version): plumb --enable-source-highlight
9086         status to "show configuration".
9087
9088 2019-04-19  Tom Tromey  <tromey@adacore.com>
9089
9090         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9091         Check ADA_TYPE_P.
9092         (empty_record, ada_template_to_fixed_record_type_1)
9093         (template_to_static_fixed_type)
9094         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9095         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9096         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9097         macros.
9098
9099 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9100
9101         PR symtab/24423:
9102         * source.c (print_source_lines_base): Advance "iter" when a
9103         control character is seen.
9104
9105 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9106
9107         * inferior.h (struct infcall_suspend_state_deleter):
9108         Catch exception in destructor to avoid crash.
9109
9110 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9111
9112         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9113         close to the add_com "shell".
9114
9115 2019-04-18  Tom Tromey  <tromey@adacore.com>
9116
9117         * process-stratum-target.h (class process_stratum_target)
9118         <stratum>: Add "final".
9119
9120 2019-04-17  Tom Tromey  <tromey@adacore.com>
9121
9122         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9123         against nullptr before use.
9124
9125 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9126
9127         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9128
9129 2019-04-17  Jim Wilson  <jimw@sifive.com>
9130             Andrew Burgess  <andrew.burgess@embecosm.com>
9131
9132         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9133         code read might fail, assume 4-byte breakpoint in that case.
9134
9135 2019-04-15  Leszek Swirski  <leszeks@google.com>
9136
9137         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9138         rather than a hand-rolled POD check when checking for forced MEMORY
9139         classification.
9140
9141 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9142
9143         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9144         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9145         function.
9146         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9147         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9148         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9149         declaration.
9150
9151 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9152
9153         * aarch64-linux-nat.c
9154         (aarch64_linux_nat_target::thread_architecture): Add override.
9155         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9156         each VQ.
9157
9158 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9159
9160         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9161
9162 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9163
9164         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9165         target types of size 96-bits, add some additional comments, and
9166         check that the builtin type we found was the correct size.
9167
9168 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9169
9170         * utils.c (prompt_for_continue): Don't restore the styling at the
9171         end, as applied_style has the wrong value.  This fixes styling in
9172         long lists of file names that are interrupted by the "Continue?"
9173         prompt.
9174
9175 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9176
9177         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9178         * c-lang.c (c_language_defn): Likewise.
9179         (cplus_language_defn): Likewise.
9180         (asm_language_defn): Likewise.
9181         (minimal_language_defn): Likewise.
9182         * d-lang.c (d_language_defn): Likewise.
9183         * f-lang.c (f_language_defn): Likewise.
9184         * go-lang.c (go_language_defn): Likewise.
9185         * language.c (unknown_language_defn): Likewise.
9186         (auto_language_defn): Likewise.
9187         * language.h (struct language_defn): Remove la_magic field.
9188         (LANG_MAGIC): Delete.
9189         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9190         * objc-lang.c (objc_language_defn): Likewise.
9191         * opencl-lang.c (opencl_language_defn): Likewise.
9192         * p-lang.c (pascal_language_defn): Likewise.
9193         * rust-lang.c (rust_language_defn): Likewise.
9194
9195 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9196
9197         * riscv-tdep.c (riscv_type_align): New function.
9198         (riscv_type_alignment): Delete.
9199         (riscv_arg_location): Use 'type_align'.
9200         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9201
9202 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9203
9204         * gdbtypes.c (type_align): A struct with no non-static fields also
9205         has alignment of 1.
9206
9207 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9208
9209         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9210         component to 0.
9211         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9212         member.
9213         (riscv_struct_info::analyse): New implementation using new
9214         analyse_inner member function.
9215         (riscv_struct_info::field_offset): New member function.
9216         (riscv_struct_info::m_offsets): New member variable.
9217         (riscv_struct_info::analyse_inner): New private member function,
9218         takes the old implementation of riscv_struct_info::analyse but
9219         extended to track field offsets.
9220         (riscv_call_arg_struct): Update the struct folding special cases
9221         to handle cases where empty C++ structs, which are non-zero
9222         length, are found.
9223         (riscv_arg_location): Initialise the length of each location, a
9224         non-zero length now indicates the location is in use.
9225         (riscv_push_dummy_call): Allow for the first location having a
9226         non-zero offset when setting up arguments.
9227         (riscv_return_value): Likewise, but for return values.
9228
9229 2019-04-11  Tom Tromey  <tromey@adacore.com>
9230
9231         * utils.c (internal_vproblem): Make "msg" const.
9232
9233 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9234
9235         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9236         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9237         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9238         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9239
9240 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9241
9242         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9243         function.
9244         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9245         of amd64_collect_native_gregset.
9246         (amd64_linux_nat_target::store_registers): Likewise.
9247
9248 2019-04-10  Tom Tromey  <tom@tromey.com>
9249
9250         * symtab.c (lookup_global_symbol_from_objfile)
9251         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9252         * objfiles.h (class separate_debug_iterator): New.
9253         (class separate_debug_range): New.
9254         (struct objfile) <separate_debug_objfiles>: New method.
9255         (objfile_separate_debug_iterate): Don't declare.
9256         * objfiles.c (separate_debug_iterator::operator++): Rename from
9257         objfile_separate_debug_iterate.
9258         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9259         iterator.
9260         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9261         iterator.
9262
9263 2019-04-10  Tom Tromey  <tom@tromey.com>
9264
9265         * symfile.c (reread_symbols): Remove old comment.
9266         * objfiles.c (free_all_objfiles): Fix a typo.
9267
9268 2019-04-10  Tom Tromey  <tom@tromey.com>
9269
9270         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9271         * minsyms.c (lookup_minimal_symbol): Use foreach.
9272         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9273         (lookup_minimal_symbol_solib_trampoline): Likewise.
9274         * symfile.c (reread_symbols): Use foreach.
9275
9276 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9277             Tom Tromey  <tromey@adacore.com>
9278
9279         PR rust/24414:
9280         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9281         (rust_lex_int_test): Change "value" to be LONGEST.
9282         (rust_lex_tests): Add test for long integer literal.
9283
9284 2019-04-09  Tom Tromey  <tromey@adacore.com>
9285
9286         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9287         to bool.
9288         (extended_remote_target::attach): Update.
9289         (remote_target::remote_notice_new_inferior): Update.
9290         (remote_target::add_current_inferior_and_thread): Update.
9291         * inferior.c (exit_inferior_1): Use "false".
9292         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9293
9294 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9295
9296         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9297         the "start" command.
9298
9299 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9300
9301         * python/py-inferior.c (infpy_thread_from_thread_handle):
9302         Adjust comments to reflect renaming of thread_from_thread_handle
9303         to thread_from_handle.  Adjust keywords.  Fix type error message.
9304         (inferior_object_methods): Add thread_from_handle.  Retain
9305         thread_from_thread_handle, but mark it as deprecated.
9306
9307 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9308
9309         * gdbthread.h (find_thread_by_handle): Revise declaration.
9310         * thread.c (find_thread_by_handle): Likewise.  Adjust
9311         implementation too.
9312         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9313         support for buffer objects as handles.
9314
9315 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9316
9317         * python/py-infthread.c (thpy_thread_handle): New function.
9318         (thread_object_methods): Register thpy_thread_handle.
9319
9320 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9321
9322         * gdbthread.h (thread_to_thread_handle): Declare.
9323         * thread.c (gdbtypes.h): Include.
9324         (thread_to_thread_handle): New function.
9325
9326         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9327         (target_thread_info_to_thread_handle): Declare.
9328         * target.c (target_thread_info_to_thread_handle): New function.
9329         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9330         * target-delegates.c: Regenerate.
9331
9332         * linux-thread-db.c (class thread_db_target): Add method
9333         thread_info_to_thread_handle.
9334         (thread_db_target::thread_info_to_thread_handle): Define.
9335         * remote.c (class remote_target): Add new method
9336         thread_info_to_thread_handle.
9337         (remote_target::thread_info_to_thread_handle): Define.
9338
9339 2019-04-08  Pedro Alves  <palves@redhat.com>
9340
9341         * common/common-exceptions.c (throw_exception): Don't create
9342         named object to throw; throw directly.
9343         (throw_it): Likewise.  Don't initialize gdb_exception::message
9344         here, with new; pass FMT and AP to the ctor instead.
9345         * common/common-exceptions.h: Include <string>.
9346         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9347         const char *, va_list)): New ctor.  Use std::make_shared.
9348         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9349         errors)): Delete.
9350         (gdb_exception_error::gdb_exception_error(enum errors, const char
9351         *, va_list)): New.
9352         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9353         Add assertion.
9354         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9355         errors)): Delete.
9356         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9357         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9358         Add assertion.
9359
9360 2019-04-08  Tom Tromey  <tom@tromey.com>
9361
9362         * valops.c (value_rtti_indirect_type): Replace throw_exception
9363         with throw.
9364         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9365         with throw.
9366         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9367         throw.
9368         * target.c (target_translate_tls_address): Replace throw_exception
9369         with throw.
9370         * stack.c (frame_apply_command_count): Replace throw_exception
9371         with throw.
9372         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9373         throw.
9374         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9375         with throw.
9376         * rs6000-tdep.c (rs6000_frame_cache)
9377         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9378         * remote.c: Replace throw_exception with throw.
9379         * record-full.c (record_full_message, record_full_wait_1)
9380         (record_full_restore): Replace throw_exception with throw.
9381         * record-btrace.c:
9382         (get_thread_current_frame_id, record_btrace_start_replaying)
9383         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9384         (cmd_record_btrace_start): Replace throw_exception with throw.
9385         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9386         throw.
9387         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9388         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9389         * linespec.c:
9390         (find_linespec_symbols): Replace throw_exception with throw.
9391         * infrun.c (displaced_step_prepare, resume): Replace
9392         throw_exception with throw.
9393         * infcmd.c (post_create_inferior): Replace throw_exception with
9394         throw.
9395         * inf-loop.c (inferior_event_handler): Replace throw_exception
9396         with throw.
9397         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9398         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9399         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9400         (get_prev_frame_always, get_frame_pc_if_available)
9401         (get_frame_address_in_block_if_available, get_frame_language):
9402         Replace throw_exception with throw.
9403         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9404         throw_exception with throw.
9405         * eval.c (fetch_subexp_value, evaluate_var_value)
9406         (evaluate_funcall, evaluate_subexp_standard): Replace
9407         throw_exception with throw.
9408         * dwarf2loc.c (call_site_find_chain)
9409         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9410         Replace throw_exception with throw.
9411         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9412         with throw.
9413         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9414         throw.
9415         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9416         * completer.c (complete_line_internal): Replace throw_exception
9417         with throw.
9418         * compile/compile-object-run.c (compile_object_run): Replace
9419         throw_exception with throw.
9420         * cli/cli-script.c (process_next_line): Replace throw_exception
9421         with throw.
9422         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9423         (btrace_enable, btrace_maint_update_pt_packets): Replace
9424         throw_exception with throw.
9425         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9426         throw_exception with throw.
9427         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9428         throw_exception with throw.
9429         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9430         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9431         * aarch64-tdep.c (aarch64_make_prologue_cache)
9432         (aarch64_make_stub_cache): Replace throw_exception with throw.
9433
9434 2019-04-08  Tom Tromey  <tom@tromey.com>
9435
9436         * common/common-exceptions.c (throw_exception): Rename from
9437         throw_exception_cxx.  Remove old copy.  Make argument const.
9438         (throw_it): Create and throw exception objects directly.
9439         * common/common-exceptions.h (throw_exception): Make argument
9440         const.
9441         (struct gdb_exception_error): Add constructor.
9442         (struct gdb_exception_quit): Add constructor.
9443
9444 2019-04-08  Tom Tromey  <tom@tromey.com>
9445
9446         * common/common-exceptions.h (exception_rethrow): Don't declare.
9447         (TRY_SJLJ): Update comment.
9448         (TRY, CATCH, END_CATCH): Remove.
9449         * common/common-exceptions.c (exception_rethrow): Remove.
9450
9451 2019-04-08  Tom Tromey  <tom@tromey.com>
9452
9453         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9454         Remove.
9455         (gdb_exception_error): Rename from
9456         gdb_exception_RETURN_MASK_ERROR.
9457         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9458         (gdb_quit_bad_alloc): Update.
9459         * aarch64-tdep.c: Update.
9460         * ada-lang.c: Update.
9461         * ada-typeprint.c: Update.
9462         * ada-valprint.c: Update.
9463         * amd64-tdep.c: Update.
9464         * arch-utils.c: Update.
9465         * break-catch-throw.c: Update.
9466         * breakpoint.c: Update.
9467         * btrace.c: Update.
9468         * c-varobj.c: Update.
9469         * cli/cli-cmds.c: Update.
9470         * cli/cli-interp.c: Update.
9471         * cli/cli-script.c: Update.
9472         * common/common-exceptions.c: Update.
9473         * common/new-op.c: Update.
9474         * common/selftest.c: Update.
9475         * compile/compile-c-symbols.c: Update.
9476         * compile/compile-cplus-symbols.c: Update.
9477         * compile/compile-object-load.c: Update.
9478         * compile/compile-object-run.c: Update.
9479         * completer.c: Update.
9480         * corelow.c: Update.
9481         * cp-abi.c: Update.
9482         * cp-support.c: Update.
9483         * cp-valprint.c: Update.
9484         * darwin-nat.c: Update.
9485         * disasm-selftests.c: Update.
9486         * dtrace-probe.c: Update.
9487         * dwarf-index-cache.c: Update.
9488         * dwarf-index-write.c: Update.
9489         * dwarf2-frame-tailcall.c: Update.
9490         * dwarf2-frame.c: Update.
9491         * dwarf2loc.c: Update.
9492         * dwarf2read.c: Update.
9493         * eval.c: Update.
9494         * event-loop.c: Update.
9495         * event-top.c: Update.
9496         * exec.c: Update.
9497         * f-valprint.c: Update.
9498         * fbsd-tdep.c: Update.
9499         * frame-unwind.c: Update.
9500         * frame.c: Update.
9501         * gdbtypes.c: Update.
9502         * gnu-v3-abi.c: Update.
9503         * guile/guile-internal.h: Update.
9504         * guile/scm-block.c: Update.
9505         * guile/scm-breakpoint.c: Update.
9506         * guile/scm-cmd.c: Update.
9507         * guile/scm-disasm.c: Update.
9508         * guile/scm-frame.c: Update.
9509         * guile/scm-lazy-string.c: Update.
9510         * guile/scm-math.c: Update.
9511         * guile/scm-param.c: Update.
9512         * guile/scm-ports.c: Update.
9513         * guile/scm-pretty-print.c: Update.
9514         * guile/scm-symbol.c: Update.
9515         * guile/scm-symtab.c: Update.
9516         * guile/scm-type.c: Update.
9517         * guile/scm-value.c: Update.
9518         * i386-linux-tdep.c: Update.
9519         * i386-tdep.c: Update.
9520         * inf-loop.c: Update.
9521         * infcall.c: Update.
9522         * infcmd.c: Update.
9523         * infrun.c: Update.
9524         * jit.c: Update.
9525         * language.c: Update.
9526         * linespec.c: Update.
9527         * linux-fork.c: Update.
9528         * linux-nat.c: Update.
9529         * linux-tdep.c: Update.
9530         * linux-thread-db.c: Update.
9531         * main.c: Update.
9532         * mi/mi-cmd-break.c: Update.
9533         * mi/mi-cmd-stack.c: Update.
9534         * mi/mi-interp.c: Update.
9535         * mi/mi-main.c: Update.
9536         * objc-lang.c: Update.
9537         * p-valprint.c: Update.
9538         * parse.c: Update.
9539         * ppc-linux-tdep.c: Update.
9540         * printcmd.c: Update.
9541         * python/py-arch.c: Update.
9542         * python/py-breakpoint.c: Update.
9543         * python/py-cmd.c: Update.
9544         * python/py-finishbreakpoint.c: Update.
9545         * python/py-frame.c: Update.
9546         * python/py-framefilter.c: Update.
9547         * python/py-gdb-readline.c: Update.
9548         * python/py-inferior.c: Update.
9549         * python/py-infthread.c: Update.
9550         * python/py-lazy-string.c: Update.
9551         * python/py-linetable.c: Update.
9552         * python/py-objfile.c: Update.
9553         * python/py-param.c: Update.
9554         * python/py-prettyprint.c: Update.
9555         * python/py-progspace.c: Update.
9556         * python/py-record-btrace.c: Update.
9557         * python/py-record.c: Update.
9558         * python/py-symbol.c: Update.
9559         * python/py-type.c: Update.
9560         * python/py-unwind.c: Update.
9561         * python/py-utils.c: Update.
9562         * python/py-value.c: Update.
9563         * python/python.c: Update.
9564         * record-btrace.c: Update.
9565         * record-full.c: Update.
9566         * remote-fileio.c: Update.
9567         * remote.c: Update.
9568         * riscv-tdep.c: Update.
9569         * rs6000-aix-tdep.c: Update.
9570         * rs6000-tdep.c: Update.
9571         * rust-exp.y: Update.
9572         * rust-lang.c: Update.
9573         * s390-tdep.c: Update.
9574         * selftest-arch.c: Update.
9575         * solib-dsbt.c: Update.
9576         * solib-frv.c: Update.
9577         * solib-spu.c: Update.
9578         * solib-svr4.c: Update.
9579         * solib.c: Update.
9580         * sparc64-linux-tdep.c: Update.
9581         * stack.c: Update.
9582         * symfile-mem.c: Update.
9583         * symmisc.c: Update.
9584         * target.c: Update.
9585         * thread.c: Update.
9586         * top.c: Update.
9587         * tracefile-tfile.c: Update.
9588         * tui/tui.c: Update.
9589         * typeprint.c: Update.
9590         * unittests/cli-utils-selftests.c: Update.
9591         * unittests/parse-connection-spec-selftests.c: Update.
9592         * valops.c: Update.
9593         * valprint.c: Update.
9594         * value.c: Update.
9595         * varobj.c: Update.
9596         * windows-nat.c: Update.
9597         * x86-linux-nat.c: Update.
9598         * xml-support.c: Update.
9599
9600 2019-04-08  Tom Tromey  <tom@tromey.com>
9601
9602         * xml-support.c: Use C++ exception handling.
9603         * x86-linux-nat.c: Use C++ exception handling.
9604         * windows-nat.c: Use C++ exception handling.
9605         * varobj.c: Use C++ exception handling.
9606         * value.c: Use C++ exception handling.
9607         * valprint.c: Use C++ exception handling.
9608         * valops.c: Use C++ exception handling.
9609         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9610         handling.
9611         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9612         * typeprint.c: Use C++ exception handling.
9613         * tui/tui.c: Use C++ exception handling.
9614         * tracefile-tfile.c: Use C++ exception handling.
9615         * top.c: Use C++ exception handling.
9616         * thread.c: Use C++ exception handling.
9617         * target.c: Use C++ exception handling.
9618         * symmisc.c: Use C++ exception handling.
9619         * symfile-mem.c: Use C++ exception handling.
9620         * stack.c: Use C++ exception handling.
9621         * sparc64-linux-tdep.c: Use C++ exception handling.
9622         * solib.c: Use C++ exception handling.
9623         * solib-svr4.c: Use C++ exception handling.
9624         * solib-spu.c: Use C++ exception handling.
9625         * solib-frv.c: Use C++ exception handling.
9626         * solib-dsbt.c: Use C++ exception handling.
9627         * selftest-arch.c: Use C++ exception handling.
9628         * s390-tdep.c: Use C++ exception handling.
9629         * rust-lang.c: Use C++ exception handling.
9630         * rust-exp.y: Use C++ exception handling.
9631         * rs6000-tdep.c: Use C++ exception handling.
9632         * rs6000-aix-tdep.c: Use C++ exception handling.
9633         * riscv-tdep.c: Use C++ exception handling.
9634         * remote.c: Use C++ exception handling.
9635         * remote-fileio.c: Use C++ exception handling.
9636         * record-full.c: Use C++ exception handling.
9637         * record-btrace.c: Use C++ exception handling.
9638         * python/python.c: Use C++ exception handling.
9639         * python/py-value.c: Use C++ exception handling.
9640         * python/py-utils.c: Use C++ exception handling.
9641         * python/py-unwind.c: Use C++ exception handling.
9642         * python/py-type.c: Use C++ exception handling.
9643         * python/py-symbol.c: Use C++ exception handling.
9644         * python/py-record.c: Use C++ exception handling.
9645         * python/py-record-btrace.c: Use C++ exception handling.
9646         * python/py-progspace.c: Use C++ exception handling.
9647         * python/py-prettyprint.c: Use C++ exception handling.
9648         * python/py-param.c: Use C++ exception handling.
9649         * python/py-objfile.c: Use C++ exception handling.
9650         * python/py-linetable.c: Use C++ exception handling.
9651         * python/py-lazy-string.c: Use C++ exception handling.
9652         * python/py-infthread.c: Use C++ exception handling.
9653         * python/py-inferior.c: Use C++ exception handling.
9654         * python/py-gdb-readline.c: Use C++ exception handling.
9655         * python/py-framefilter.c: Use C++ exception handling.
9656         * python/py-frame.c: Use C++ exception handling.
9657         * python/py-finishbreakpoint.c: Use C++ exception handling.
9658         * python/py-cmd.c: Use C++ exception handling.
9659         * python/py-breakpoint.c: Use C++ exception handling.
9660         * python/py-arch.c: Use C++ exception handling.
9661         * printcmd.c: Use C++ exception handling.
9662         * ppc-linux-tdep.c: Use C++ exception handling.
9663         * parse.c: Use C++ exception handling.
9664         * p-valprint.c: Use C++ exception handling.
9665         * objc-lang.c: Use C++ exception handling.
9666         * mi/mi-main.c: Use C++ exception handling.
9667         * mi/mi-interp.c: Use C++ exception handling.
9668         * mi/mi-cmd-stack.c: Use C++ exception handling.
9669         * mi/mi-cmd-break.c: Use C++ exception handling.
9670         * main.c: Use C++ exception handling.
9671         * linux-thread-db.c: Use C++ exception handling.
9672         * linux-tdep.c: Use C++ exception handling.
9673         * linux-nat.c: Use C++ exception handling.
9674         * linux-fork.c: Use C++ exception handling.
9675         * linespec.c: Use C++ exception handling.
9676         * language.c: Use C++ exception handling.
9677         * jit.c: Use C++ exception handling.
9678         * infrun.c: Use C++ exception handling.
9679         * infcmd.c: Use C++ exception handling.
9680         * infcall.c: Use C++ exception handling.
9681         * inf-loop.c: Use C++ exception handling.
9682         * i386-tdep.c: Use C++ exception handling.
9683         * i386-linux-tdep.c: Use C++ exception handling.
9684         * guile/scm-value.c: Use C++ exception handling.
9685         * guile/scm-type.c: Use C++ exception handling.
9686         * guile/scm-symtab.c: Use C++ exception handling.
9687         * guile/scm-symbol.c: Use C++ exception handling.
9688         * guile/scm-pretty-print.c: Use C++ exception handling.
9689         * guile/scm-ports.c: Use C++ exception handling.
9690         * guile/scm-param.c: Use C++ exception handling.
9691         * guile/scm-math.c: Use C++ exception handling.
9692         * guile/scm-lazy-string.c: Use C++ exception handling.
9693         * guile/scm-frame.c: Use C++ exception handling.
9694         * guile/scm-disasm.c: Use C++ exception handling.
9695         * guile/scm-cmd.c: Use C++ exception handling.
9696         * guile/scm-breakpoint.c: Use C++ exception handling.
9697         * guile/scm-block.c: Use C++ exception handling.
9698         * guile/guile-internal.h: Use C++ exception handling.
9699         * gnu-v3-abi.c: Use C++ exception handling.
9700         * gdbtypes.c: Use C++ exception handling.
9701         * frame.c: Use C++ exception handling.
9702         * frame-unwind.c: Use C++ exception handling.
9703         * fbsd-tdep.c: Use C++ exception handling.
9704         * f-valprint.c: Use C++ exception handling.
9705         * exec.c: Use C++ exception handling.
9706         * event-top.c: Use C++ exception handling.
9707         * event-loop.c: Use C++ exception handling.
9708         * eval.c: Use C++ exception handling.
9709         * dwarf2read.c: Use C++ exception handling.
9710         * dwarf2loc.c: Use C++ exception handling.
9711         * dwarf2-frame.c: Use C++ exception handling.
9712         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9713         * dwarf-index-write.c: Use C++ exception handling.
9714         * dwarf-index-cache.c: Use C++ exception handling.
9715         * dtrace-probe.c: Use C++ exception handling.
9716         * disasm-selftests.c: Use C++ exception handling.
9717         * darwin-nat.c: Use C++ exception handling.
9718         * cp-valprint.c: Use C++ exception handling.
9719         * cp-support.c: Use C++ exception handling.
9720         * cp-abi.c: Use C++ exception handling.
9721         * corelow.c: Use C++ exception handling.
9722         * completer.c: Use C++ exception handling.
9723         * compile/compile-object-run.c: Use C++ exception handling.
9724         * compile/compile-object-load.c: Use C++ exception handling.
9725         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9726         * compile/compile-c-symbols.c: Use C++ exception handling.
9727         * common/selftest.c: Use C++ exception handling.
9728         * common/new-op.c: Use C++ exception handling.
9729         * cli/cli-script.c: Use C++ exception handling.
9730         * cli/cli-interp.c: Use C++ exception handling.
9731         * cli/cli-cmds.c: Use C++ exception handling.
9732         * c-varobj.c: Use C++ exception handling.
9733         * btrace.c: Use C++ exception handling.
9734         * breakpoint.c: Use C++ exception handling.
9735         * break-catch-throw.c: Use C++ exception handling.
9736         * arch-utils.c: Use C++ exception handling.
9737         * amd64-tdep.c: Use C++ exception handling.
9738         * ada-valprint.c: Use C++ exception handling.
9739         * ada-typeprint.c: Use C++ exception handling.
9740         * ada-lang.c: Use C++ exception handling.
9741         * aarch64-tdep.c: Use C++ exception handling.
9742
9743 2019-04-08  Tom Tromey  <tom@tromey.com>
9744
9745         * xml-support.c (gdb_xml_parser::parse): Update.
9746         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9747         * value.c (show_convenience): Update.
9748         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9749         (test_parse_flags_qcs): Update.
9750         * thread.c (thr_try_catch_cmd): Update.
9751         * target.c (target_translate_tls_address): Update.
9752         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9753         (info_frame_command_core, frame_apply_command_count): Update.
9754         * rust-exp.y (rust_lex_exception_test): Update.
9755         * riscv-tdep.c (riscv_print_one_register_info): Update.
9756         * remote.c (remote_target::enable_btrace): Update.
9757         * record-btrace.c (record_btrace_enable_warn): Update.
9758         * python/py-utils.c (gdbpy_convert_exception): Update.
9759         * printcmd.c (do_one_display, print_variable_and_value): Update.
9760         * mi/mi-main.c (mi_print_exception): Update.
9761         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9762         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9763         * linux-nat.c (linux_nat_target::attach): Update.
9764         * linux-fork.c (class scoped_switch_fork_info): Update.
9765         * infrun.c (displaced_step_prepare): Update.
9766         * infcall.c (call_function_by_hand_dummy): Update.
9767         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9768         * gnu-v3-abi.c (print_one_vtable): Update.
9769         * frame.c (get_prev_frame_always): Update.
9770         * f-valprint.c (info_common_command_for_block): Update.
9771         * exec.c (try_open_exec_file): Update.
9772         * exceptions.c (print_exception, exception_print)
9773         (exception_fprintf, exception_print_same): Update.
9774         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9775         * dwarf-index-cache.c (index_cache::store)
9776         (index_cache::lookup_gdb_index): Update.
9777         * darwin-nat.c (maybe_cache_shell): Update.
9778         * cp-valprint.c (cp_print_value_fields): Update.
9779         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9780         (gcc_cplus_symbol_address): Update.
9781         * compile/compile-c-symbols.c (gcc_convert_symbol)
9782         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9783         * common/selftest.c: Update.
9784         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9785         a std::string.
9786         (exception_try_scope_entry, exception_try_scope_exit): Don't
9787         declare.
9788         (struct exception_try_scope): Remove.
9789         (TRY): Don't use exception_try_scope.
9790         (struct gdb_exception): Add constructor, operator=.
9791         <what>: New method.
9792         (struct gdb_exception_RETURN_MASK_ALL)
9793         (struct gdb_exception_RETURN_MASK_ERROR)
9794         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9795         (struct gdb_quit_bad_alloc): Update.
9796         * common/common-exceptions.c (exception_none): Change
9797         initializer.
9798         (struct catcher) <state, exception>: Initialize inline.
9799         <prev>: Remove member.
9800         (current_catcher): Remove.
9801         (catchers): New global.
9802         (exceptions_state_mc_init): Simplify.
9803         (catcher_pop): Remove.
9804         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9805         (try_scope_depth, exception_try_scope_entry)
9806         (exception_try_scope_exit): Remove.
9807         (throw_exception_sjlj): Update.
9808         (exception_messages, exception_messages_size): Remove.
9809         (throw_it): Simplify.
9810         (gdb_exception_sliced_copy): Remove.
9811         (throw_exception_cxx): Update.
9812         * cli/cli-script.c (script_from_file): Update.
9813         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9814         Update.
9815         * ada-valprint.c (ada_val_print): Update.
9816         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9817         (create_excep_cond_exprs): Update.
9818
9819 2019-04-08  Tom Tromey  <tom@tromey.com>
9820
9821         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9822         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9823         (TRY, CATCH, END_CATCH): Remove some definitions.
9824         * common/common-exceptions.c: Don't use GDB_XCPT.
9825         (catcher_list_size): Remove.
9826         (throw_exception, throw_it): Simplify.
9827
9828 2019-04-05  Tom Tromey  <tom@tromey.com>
9829
9830         Revert the header-sorting patch.
9831         * ft32-tdep.c: Revert.
9832         * frv-tdep.c: Revert.
9833         * frv-linux-tdep.c: Revert.
9834         * frame.c: Revert.
9835         * frame-unwind.c: Revert.
9836         * frame-base.c: Revert.
9837         * fork-child.c: Revert.
9838         * findvar.c: Revert.
9839         * findcmd.c: Revert.
9840         * filesystem.c: Revert.
9841         * filename-seen-cache.h: Revert.
9842         * filename-seen-cache.c: Revert.
9843         * fbsd-tdep.c: Revert.
9844         * fbsd-nat.h: Revert.
9845         * fbsd-nat.c: Revert.
9846         * f-valprint.c: Revert.
9847         * f-typeprint.c: Revert.
9848         * f-lang.c: Revert.
9849         * extension.h: Revert.
9850         * extension.c: Revert.
9851         * extension-priv.h: Revert.
9852         * expprint.c: Revert.
9853         * exec.h: Revert.
9854         * exec.c: Revert.
9855         * exceptions.c: Revert.
9856         * event-top.c: Revert.
9857         * event-loop.c: Revert.
9858         * eval.c: Revert.
9859         * elfread.c: Revert.
9860         * dwarf2read.h: Revert.
9861         * dwarf2read.c: Revert.
9862         * dwarf2loc.c: Revert.
9863         * dwarf2expr.h: Revert.
9864         * dwarf2expr.c: Revert.
9865         * dwarf2-frame.c: Revert.
9866         * dwarf2-frame-tailcall.c: Revert.
9867         * dwarf-index-write.h: Revert.
9868         * dwarf-index-write.c: Revert.
9869         * dwarf-index-common.c: Revert.
9870         * dwarf-index-cache.h: Revert.
9871         * dwarf-index-cache.c: Revert.
9872         * dummy-frame.c: Revert.
9873         * dtrace-probe.c: Revert.
9874         * disasm.h: Revert.
9875         * disasm.c: Revert.
9876         * disasm-selftests.c: Revert.
9877         * dictionary.c: Revert.
9878         * dicos-tdep.c: Revert.
9879         * demangle.c: Revert.
9880         * dcache.h: Revert.
9881         * dcache.c: Revert.
9882         * darwin-nat.h: Revert.
9883         * darwin-nat.c: Revert.
9884         * darwin-nat-info.c: Revert.
9885         * d-valprint.c: Revert.
9886         * d-namespace.c: Revert.
9887         * d-lang.c: Revert.
9888         * ctf.c: Revert.
9889         * csky-tdep.c: Revert.
9890         * csky-linux-tdep.c: Revert.
9891         * cris-tdep.c: Revert.
9892         * cris-linux-tdep.c: Revert.
9893         * cp-valprint.c: Revert.
9894         * cp-support.c: Revert.
9895         * cp-namespace.c: Revert.
9896         * cp-abi.c: Revert.
9897         * corelow.c: Revert.
9898         * corefile.c: Revert.
9899         * continuations.c: Revert.
9900         * completer.h: Revert.
9901         * completer.c: Revert.
9902         * complaints.c: Revert.
9903         * coffread.c: Revert.
9904         * coff-pe-read.c: Revert.
9905         * cli-out.h: Revert.
9906         * cli-out.c: Revert.
9907         * charset.c: Revert.
9908         * c-varobj.c: Revert.
9909         * c-valprint.c: Revert.
9910         * c-typeprint.c: Revert.
9911         * c-lang.c: Revert.
9912         * buildsym.c: Revert.
9913         * buildsym-legacy.c: Revert.
9914         * build-id.h: Revert.
9915         * build-id.c: Revert.
9916         * btrace.c: Revert.
9917         * bsd-uthread.c: Revert.
9918         * breakpoint.h: Revert.
9919         * breakpoint.c: Revert.
9920         * break-catch-throw.c: Revert.
9921         * break-catch-syscall.c: Revert.
9922         * break-catch-sig.c: Revert.
9923         * blockframe.c: Revert.
9924         * block.c: Revert.
9925         * bfin-tdep.c: Revert.
9926         * bfin-linux-tdep.c: Revert.
9927         * bfd-target.c: Revert.
9928         * bcache.c: Revert.
9929         * ax-general.c: Revert.
9930         * ax-gdb.h: Revert.
9931         * ax-gdb.c: Revert.
9932         * avr-tdep.c: Revert.
9933         * auxv.c: Revert.
9934         * auto-load.c: Revert.
9935         * arm-wince-tdep.c: Revert.
9936         * arm-tdep.c: Revert.
9937         * arm-symbian-tdep.c: Revert.
9938         * arm-pikeos-tdep.c: Revert.
9939         * arm-obsd-tdep.c: Revert.
9940         * arm-nbsd-tdep.c: Revert.
9941         * arm-nbsd-nat.c: Revert.
9942         * arm-linux-tdep.c: Revert.
9943         * arm-linux-nat.c: Revert.
9944         * arm-fbsd-tdep.c: Revert.
9945         * arm-fbsd-nat.c: Revert.
9946         * arm-bsd-tdep.c: Revert.
9947         * arch-utils.c: Revert.
9948         * arc-tdep.c: Revert.
9949         * arc-newlib-tdep.c: Revert.
9950         * annotate.h: Revert.
9951         * annotate.c: Revert.
9952         * amd64-windows-tdep.c: Revert.
9953         * amd64-windows-nat.c: Revert.
9954         * amd64-tdep.c: Revert.
9955         * amd64-sol2-tdep.c: Revert.
9956         * amd64-obsd-tdep.c: Revert.
9957         * amd64-obsd-nat.c: Revert.
9958         * amd64-nbsd-tdep.c: Revert.
9959         * amd64-nbsd-nat.c: Revert.
9960         * amd64-nat.c: Revert.
9961         * amd64-linux-tdep.c: Revert.
9962         * amd64-linux-nat.c: Revert.
9963         * amd64-fbsd-tdep.c: Revert.
9964         * amd64-fbsd-nat.c: Revert.
9965         * amd64-dicos-tdep.c: Revert.
9966         * amd64-darwin-tdep.c: Revert.
9967         * amd64-bsd-nat.c: Revert.
9968         * alpha-tdep.c: Revert.
9969         * alpha-obsd-tdep.c: Revert.
9970         * alpha-nbsd-tdep.c: Revert.
9971         * alpha-mdebug-tdep.c: Revert.
9972         * alpha-linux-tdep.c: Revert.
9973         * alpha-linux-nat.c: Revert.
9974         * alpha-bsd-tdep.c: Revert.
9975         * alpha-bsd-nat.c: Revert.
9976         * aix-thread.c: Revert.
9977         * agent.c: Revert.
9978         * addrmap.c: Revert.
9979         * ada-varobj.c: Revert.
9980         * ada-valprint.c: Revert.
9981         * ada-typeprint.c: Revert.
9982         * ada-tasks.c: Revert.
9983         * ada-lang.c: Revert.
9984         * aarch64-tdep.c: Revert.
9985         * aarch64-ravenscar-thread.c: Revert.
9986         * aarch64-newlib-tdep.c: Revert.
9987         * aarch64-linux-tdep.c: Revert.
9988         * aarch64-linux-nat.c: Revert.
9989         * aarch64-fbsd-tdep.c: Revert.
9990         * aarch64-fbsd-nat.c: Revert.
9991         * aarch32-linux-nat.c: Revert.
9992
9993 2019-04-05  Tom Tromey  <tom@tromey.com>
9994
9995         * ft32-tdep.c: Sort headers.
9996         * frv-tdep.c: Sort headers.
9997         * frv-linux-tdep.c: Sort headers.
9998         * frame.c: Sort headers.
9999         * frame-unwind.c: Sort headers.
10000         * frame-base.c: Sort headers.
10001         * fork-child.c: Sort headers.
10002         * findvar.c: Sort headers.
10003         * findcmd.c: Sort headers.
10004         * filesystem.c: Sort headers.
10005         * filename-seen-cache.h: Sort headers.
10006         * filename-seen-cache.c: Sort headers.
10007         * fbsd-tdep.c: Sort headers.
10008         * fbsd-nat.h: Sort headers.
10009         * fbsd-nat.c: Sort headers.
10010         * f-valprint.c: Sort headers.
10011         * f-typeprint.c: Sort headers.
10012         * f-lang.c: Sort headers.
10013         * extension.h: Sort headers.
10014         * extension.c: Sort headers.
10015         * extension-priv.h: Sort headers.
10016         * expprint.c: Sort headers.
10017         * exec.h: Sort headers.
10018         * exec.c: Sort headers.
10019         * exceptions.c: Sort headers.
10020         * event-top.c: Sort headers.
10021         * event-loop.c: Sort headers.
10022         * eval.c: Sort headers.
10023         * elfread.c: Sort headers.
10024         * dwarf2read.h: Sort headers.
10025         * dwarf2read.c: Sort headers.
10026         * dwarf2loc.c: Sort headers.
10027         * dwarf2expr.h: Sort headers.
10028         * dwarf2expr.c: Sort headers.
10029         * dwarf2-frame.c: Sort headers.
10030         * dwarf2-frame-tailcall.c: Sort headers.
10031         * dwarf-index-write.h: Sort headers.
10032         * dwarf-index-write.c: Sort headers.
10033         * dwarf-index-common.c: Sort headers.
10034         * dwarf-index-cache.h: Sort headers.
10035         * dwarf-index-cache.c: Sort headers.
10036         * dummy-frame.c: Sort headers.
10037         * dtrace-probe.c: Sort headers.
10038         * disasm.h: Sort headers.
10039         * disasm.c: Sort headers.
10040         * disasm-selftests.c: Sort headers.
10041         * dictionary.c: Sort headers.
10042         * dicos-tdep.c: Sort headers.
10043         * demangle.c: Sort headers.
10044         * dcache.h: Sort headers.
10045         * dcache.c: Sort headers.
10046         * darwin-nat.h: Sort headers.
10047         * darwin-nat.c: Sort headers.
10048         * darwin-nat-info.c: Sort headers.
10049         * d-valprint.c: Sort headers.
10050         * d-namespace.c: Sort headers.
10051         * d-lang.c: Sort headers.
10052         * ctf.c: Sort headers.
10053         * csky-tdep.c: Sort headers.
10054         * csky-linux-tdep.c: Sort headers.
10055         * cris-tdep.c: Sort headers.
10056         * cris-linux-tdep.c: Sort headers.
10057         * cp-valprint.c: Sort headers.
10058         * cp-support.c: Sort headers.
10059         * cp-namespace.c: Sort headers.
10060         * cp-abi.c: Sort headers.
10061         * corelow.c: Sort headers.
10062         * corefile.c: Sort headers.
10063         * continuations.c: Sort headers.
10064         * completer.h: Sort headers.
10065         * completer.c: Sort headers.
10066         * complaints.c: Sort headers.
10067         * coffread.c: Sort headers.
10068         * coff-pe-read.c: Sort headers.
10069         * cli-out.h: Sort headers.
10070         * cli-out.c: Sort headers.
10071         * charset.c: Sort headers.
10072         * c-varobj.c: Sort headers.
10073         * c-valprint.c: Sort headers.
10074         * c-typeprint.c: Sort headers.
10075         * c-lang.c: Sort headers.
10076         * buildsym.c: Sort headers.
10077         * buildsym-legacy.c: Sort headers.
10078         * build-id.h: Sort headers.
10079         * build-id.c: Sort headers.
10080         * btrace.c: Sort headers.
10081         * bsd-uthread.c: Sort headers.
10082         * breakpoint.h: Sort headers.
10083         * breakpoint.c: Sort headers.
10084         * break-catch-throw.c: Sort headers.
10085         * break-catch-syscall.c: Sort headers.
10086         * break-catch-sig.c: Sort headers.
10087         * blockframe.c: Sort headers.
10088         * block.c: Sort headers.
10089         * bfin-tdep.c: Sort headers.
10090         * bfin-linux-tdep.c: Sort headers.
10091         * bfd-target.c: Sort headers.
10092         * bcache.c: Sort headers.
10093         * ax-general.c: Sort headers.
10094         * ax-gdb.h: Sort headers.
10095         * ax-gdb.c: Sort headers.
10096         * avr-tdep.c: Sort headers.
10097         * auxv.c: Sort headers.
10098         * auto-load.c: Sort headers.
10099         * arm-wince-tdep.c: Sort headers.
10100         * arm-tdep.c: Sort headers.
10101         * arm-symbian-tdep.c: Sort headers.
10102         * arm-pikeos-tdep.c: Sort headers.
10103         * arm-obsd-tdep.c: Sort headers.
10104         * arm-nbsd-tdep.c: Sort headers.
10105         * arm-nbsd-nat.c: Sort headers.
10106         * arm-linux-tdep.c: Sort headers.
10107         * arm-linux-nat.c: Sort headers.
10108         * arm-fbsd-tdep.c: Sort headers.
10109         * arm-fbsd-nat.c: Sort headers.
10110         * arm-bsd-tdep.c: Sort headers.
10111         * arch-utils.c: Sort headers.
10112         * arc-tdep.c: Sort headers.
10113         * arc-newlib-tdep.c: Sort headers.
10114         * annotate.h: Sort headers.
10115         * annotate.c: Sort headers.
10116         * amd64-windows-tdep.c: Sort headers.
10117         * amd64-windows-nat.c: Sort headers.
10118         * amd64-tdep.c: Sort headers.
10119         * amd64-sol2-tdep.c: Sort headers.
10120         * amd64-obsd-tdep.c: Sort headers.
10121         * amd64-obsd-nat.c: Sort headers.
10122         * amd64-nbsd-tdep.c: Sort headers.
10123         * amd64-nbsd-nat.c: Sort headers.
10124         * amd64-nat.c: Sort headers.
10125         * amd64-linux-tdep.c: Sort headers.
10126         * amd64-linux-nat.c: Sort headers.
10127         * amd64-fbsd-tdep.c: Sort headers.
10128         * amd64-fbsd-nat.c: Sort headers.
10129         * amd64-dicos-tdep.c: Sort headers.
10130         * amd64-darwin-tdep.c: Sort headers.
10131         * amd64-bsd-nat.c: Sort headers.
10132         * alpha-tdep.c: Sort headers.
10133         * alpha-obsd-tdep.c: Sort headers.
10134         * alpha-nbsd-tdep.c: Sort headers.
10135         * alpha-mdebug-tdep.c: Sort headers.
10136         * alpha-linux-tdep.c: Sort headers.
10137         * alpha-linux-nat.c: Sort headers.
10138         * alpha-bsd-tdep.c: Sort headers.
10139         * alpha-bsd-nat.c: Sort headers.
10140         * aix-thread.c: Sort headers.
10141         * agent.c: Sort headers.
10142         * addrmap.c: Sort headers.
10143         * ada-varobj.c: Sort headers.
10144         * ada-valprint.c: Sort headers.
10145         * ada-typeprint.c: Sort headers.
10146         * ada-tasks.c: Sort headers.
10147         * ada-lang.c: Sort headers.
10148         * aarch64-tdep.c: Sort headers.
10149         * aarch64-ravenscar-thread.c: Sort headers.
10150         * aarch64-newlib-tdep.c: Sort headers.
10151         * aarch64-linux-tdep.c: Sort headers.
10152         * aarch64-linux-nat.c: Sort headers.
10153         * aarch64-fbsd-tdep.c: Sort headers.
10154         * aarch64-fbsd-nat.c: Sort headers.
10155         * aarch32-linux-nat.c: Sort headers.
10156
10157 2019-04-04  Tom Tromey  <tom@tromey.com>
10158
10159         * varobj.c (varobj_create): Update.
10160         * rust-exp.y (struct rust_parser) <update_innermost_block,
10161         lookup_symbol>: New methods.
10162         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10163         Rename.
10164         (rust_parser::rust_lookup_type)
10165         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10166         * printcmd.c (display_command, do_one_display): Update.
10167         * parser-defs.h (struct parser_state) <parser_state>: Add
10168         "tracker" parameter.
10169         (block_tracker): New member.
10170         (class innermost_block_tracker) <innermost_block_tracker>: Add
10171         "types" parameter.
10172         <reset>: Remove method.
10173         (innermost_block): Don't declare.
10174         (null_post_parser): Update.
10175         * parse.c (innermost_block): Remove global.
10176         (write_dollar_variable): Update.
10177         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10178         Remove "tracker_types" parameter.
10179         (parse_expression): Add "tracker" parameter.
10180         (parse_expression_for_completion): Update.
10181         (null_post_parser): Add "tracker" parameter.
10182         * p-exp.y: Update rules.
10183         * m2-exp.y: Update rules.
10184         * language.h (struct language_defn) <la_post_parser>: Add
10185         "tracker" parameter.
10186         * go-exp.y: Update rules.
10187         * f-exp.y: Update rules.
10188         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10189         parameter.
10190         * d-exp.y: Update rules.
10191         * c-exp.y: Update rules.
10192         * breakpoint.c (set_breakpoint_condition): Create an
10193         innermost_block_tracker.
10194         (watch_command_1): Likewise.
10195         * ada-lang.c (resolve): Add "tracker" parameter.
10196         (resolve_subexp): Likewise.
10197         * ada-exp.y (write_var_from_sym): Update.
10198
10199 2019-04-04  Tom Tromey  <tom@tromey.com>
10200
10201         * type-stack.h: New file.
10202         * type-stack.c: New file.
10203         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10204         type-stack.h.
10205         (insert_into_type_stack, insert_type, push_type, push_type_int)
10206         (insert_type_address_space, pop_type, pop_type_int)
10207         (pop_typelist, pop_type_stack, append_type_stack)
10208         (push_type_stack, get_type_stack, push_typelist)
10209         (follow_type_instance_flags, follow_types): Don't declare.
10210         * parse.c (type_stack): Remove global.
10211         (parse_exp_in_context): Update.
10212         (insert_into_type_stack, insert_type, push_type, push_type_int)
10213         (insert_type_address_space, pop_type, pop_type_int)
10214         (pop_typelist, pop_type_stack, append_type_stack)
10215         (push_type_stack, get_type_stack, push_typelist)
10216         (follow_type_instance_flags, follow_types): Remove (moved to
10217         type-stack.c).
10218         * f-exp.y (type_stack): New global.
10219         Update rules.
10220         (push_kind_type, f_parse): Update.
10221         * d-exp.y (type_stack): New global.
10222         Update rules.
10223         (d_parse): Update.
10224         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10225         Update rules.
10226         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10227         (HFILES_NO_SRCDIR): Add type-stack.h.
10228
10229 2019-04-04  Tom Tromey  <tom@tromey.com>
10230
10231         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10232         (rust_parser::convert_ast_to_expression, rust_parse)
10233         (rust_lex_test_completion, rust_lex_tests): Update.
10234         * parser-defs.h (struct expr_completion_state): New.
10235         (struct parser_state) <parser_state>: Add completion parameter.
10236         <mark_struct_expression, mark_completion_tag>: New methods.
10237         <parse_completion, m_completion_state>: New members.
10238         (prefixify_expression, null_post_parser): Update.
10239         (mark_struct_expression, mark_completion_tag): Don't declare.
10240         * parse.c (parse_completion, expout_last_struct)
10241         (expout_tag_completion_type, expout_completion_name): Remove
10242         globals.
10243         (parser_state::mark_struct_expression)
10244         (parser_state::mark_completion_tag): Now methods.
10245         (prefixify_expression): Add last_struct parameter.
10246         (prefixify_subexp): Likewise.
10247         (parse_exp_1): Update.
10248         (parse_exp_in_context): Add cstate parameter.  Update.
10249         (parse_expression_for_completion): Create an
10250         expr_completion_state.
10251         (null_post_parser): Add "completion" parameter.
10252         * p-exp.y: Update rules.
10253         (yylex): Update.
10254         * language.h (struct language_defn) <la_post_parser>: Add
10255         "completing" parameter.
10256         * go-exp.y: Update rules.
10257         (lex_one_token): Update.
10258         * expression.h (parse_completion): Don't declare.
10259         * d-exp.y: Update rules.
10260         (lex_one_token): Update rules.
10261         * c-exp.y: Update rules.
10262         (lex_one_token): Update.
10263         * ada-lang.c (resolve): Add "parse_completion" parameter.
10264         (resolve_subexp): Likewise.
10265         (ada_resolve_function): Likewise.
10266
10267 2019-04-04  Tom Tromey  <tom@tromey.com>
10268
10269         * parser-defs.h (struct parser_state) <start_arglist,
10270         end_arglist>: New methods.
10271         <arglist_len, m_funcall_chain>: New members.
10272         (arglist_len, start_arglist, end_arglist): Don't declare.
10273         * parse.c (arglist_len, funcall_chain): Remove global.
10274         (start_arglist, end_arglist): Remove functions.
10275         (parse_exp_in_context): Update.
10276         * p-exp.y: Update rules.
10277         * m2-exp.y: Update rules.
10278         * go-exp.y: Update rules.
10279         * f-exp.y: Update rules.
10280         * d-exp.y: Update rules.
10281         * c-exp.y: Update rules.
10282
10283 2019-04-04  Tom Tromey  <tom@tromey.com>
10284
10285         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10286         lex_operator, push_back>: New methods.
10287         Update all rules.
10288         (rust_parser::lex_hex, lex_escape): Rename and update.
10289         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10290         (rust_parser::lex_operator): Rename and update.
10291         (rust_parser::lex_number, rustyylex, rustyyerror)
10292         (rust_lex_test_init, rust_lex_test_sequence)
10293         (rust_lex_test_push_back, rust_lex_tests): Update.
10294         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10295         parameter.
10296         <lexptr, prev_lexptr>: New members.
10297         (lexptr, prev_lexptr): Don't declare.
10298         * parse.c (lexptr, prev_lexptr): Remove globals.
10299         (parse_exp_in_context): Update.
10300         * p-exp.y (yylex, yyerror): Update.
10301         * m2-exp.y (parse_number, yylex, yyerror): Update.
10302         * go-exp.y (lex_one_token, yyerror): Update.
10303         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10304         * d-exp.y (lex_one_token, yyerror): Update.
10305         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10306         (lex_one_token, yyerror): Update.
10307         * ada-lex.l (YY_INPUT): Update.
10308         (rewind_to_char): Update.
10309         * ada-exp.y (yyerror): Update.
10310
10311 2019-04-04  Tom Tromey  <tom@tromey.com>
10312
10313         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10314         * parser-defs.h (struct parser_state) <parser_state>: Add new
10315         parameter.
10316         <comma_terminates>: New member.
10317         (comma_terminates): Don't declare global.
10318         * parse.c (comma_terminates): Remove global.
10319         (parse_exp_in_context): Update.
10320         * p-exp.y (yylex): Update.
10321         * m2-exp.y (yylex): Update.
10322         * go-exp.y (lex_one_token): Update.
10323         * f-exp.y (yylex): Update.
10324         * d-exp.y (lex_one_token): Update.
10325         * c-exp.y (lex_one_token): Update.
10326         * ada-lex.l: Update.
10327
10328 2019-04-04  Tom Tromey  <tom@tromey.com>
10329
10330         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10331         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10332         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10333         * parser-defs.h (paren_depth): Don't declare.
10334         * parse.c (paren_depth): Remove global.
10335         (parse_exp_in_context): Update.
10336         * p-exp.y (paren_depth): New global.
10337         (pascal_parse): Initialize it.
10338         * m2-exp.y (paren_depth): New global.
10339         (m2_parse): Initialize it.
10340         * go-exp.y (paren_depth): New global.
10341         (go_parse): Initialize it.
10342         * f-exp.y (paren_depth): New global.
10343         (f_parse): Initialize it.
10344         * d-exp.y (paren_depth): New global.
10345         (d_parse): Initialize it.
10346         * c-exp.y (paren_depth): New global.
10347         (c_parse): Initialize it.
10348         * ada-lex.l (paren_depth): New global.
10349         (lexer_init): Initialize it.
10350
10351 2019-04-04  Tom Tromey  <tom@tromey.com>
10352
10353         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10354         (rust_parser::convert_ast_to_type)
10355         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10356         * parser-defs.h (struct parser_state) <parser_state>: Add
10357         parameters.  Initialize new members.
10358         <expression_context_block, expression_context_pc>: New members.
10359         * parse.c (expression_context_block, expression_context_pc):
10360         Remove globals.
10361         (parse_exp_in_context): Update.
10362         * p-exp.y: Update all rules.
10363         (yylex): Update.
10364         * m2-exp.y: Update all rules.
10365         (yylex): Update.
10366         * go-exp.y (yylex): Update.
10367         * f-exp.y (yylex): Update.
10368         * d-exp.y: Update all rules.
10369         (yylex): Update.
10370         * c-exp.y: Update all rules.
10371         (lex_one_token, classify_name, yylex, c_parse): Update.
10372         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10373
10374 2019-04-04  Tom Tromey  <tom@tromey.com>
10375
10376         * gdbarch.h, gdbarch.c: Rebuild.
10377         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10378         * stap-probe.h:
10379         (struct stap_parse_info): Replace "parser_state" with
10380         "expr_builder".
10381         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10382         (parser_state): New class.
10383         * parse.c (expr_builder): Rename.
10384         (expr_builder::release): Rename.
10385         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10386         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10387         (write_exp_elt_longcst, write_exp_elt_floatcst)
10388         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10389         (write_exp_string_vector, write_exp_bitstring)
10390         (write_exp_msymbol, mark_struct_expression)
10391         (write_dollar_variable)
10392         (insert_type_address_space, increase_expout_size): Replace
10393         "parser_state" with "expr_builder".
10394         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10395         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10396         "parser_state" with "expr_builder".
10397
10398 2019-04-04  Tom Tromey  <tom@tromey.com>
10399
10400         * rust-exp.y: Replace "parse_language" with method call.
10401         * p-exp.y:
10402         (yylex): Replace "parse_language" with method call.
10403         * m2-exp.y:
10404         (yylex): Replace "parse_language" with method call.
10405         * go-exp.y (classify_name): Replace "parse_language" with method
10406         call.
10407         * f-exp.y (yylex): Replace "parse_language" with method call.
10408         * d-exp.y (lex_one_token): Replace "parse_language" with method
10409         call.
10410         * c-exp.y:
10411         (lex_one_token, classify_name, yylex): Replace "parse_language"
10412         with method call.
10413         * ada-exp.y (find_primitive_type, type_char)
10414         (type_system_address): Replace "parse_language" with method call.
10415
10416 2019-04-04  Tom Tromey  <tom@tromey.com>
10417
10418         * rust-exp.y: Replace "parse_gdbarch" with method call.
10419         * parse.c (write_dollar_variable, insert_type_address_space):
10420         Replace "parse_gdbarch" with method call.
10421         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10422         call.
10423         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10424         call.
10425         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10426         "parse_gdbarch" with method call.
10427         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10428         with method call.
10429         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10430         "parse_gdbarch" with method call.
10431         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10432         "parse_gdbarch" with method call.
10433         * c-exp.y (parse_type, parse_number, classify_name): Replace
10434         "parse_gdbarch" with method call.
10435         * ada-lex.l: Replace "parse_gdbarch" with method call.
10436         * ada-exp.y (parse_type, find_primitive_type, type_char)
10437         (type_system_address): Replace "parse_gdbarch" with method call.
10438
10439 2019-04-04  Tom Tromey  <tom@tromey.com>
10440
10441         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10442         * stap-probe.c (stap_parse_argument): Update.
10443         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10444         initial_size parameter.
10445         * rust-exp.y (rust_lex_tests): Update.
10446         * parse.c (parser_state): Update.
10447         (parse_exp_in_context): Update.
10448         * parser-defs.h (struct parser_state) <parser_state>: Remove
10449         "initial_size" parameter.
10450
10451 2019-04-04  Tom Tromey  <tom@tromey.com>
10452
10453         * parser-defs.h (increase_expout_size): Don't declare.
10454         * parse.c (increase_expout_size): Now static.
10455
10456 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10457
10458         * gnu-nat.c (gnu_nat_target::wait): Fix
10459         target_waitstatus_to_string call.
10460
10461 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10462
10463         * eval.c (evaluate_subexp_standard): Handle internal functions
10464         during Fortran function call handling.
10465
10466 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10467
10468         * NEWS: Mention new internal functions.
10469         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10470         (read_base_type): Use dwarf2_init_complex_target_type.
10471         * value.c (creal_internal_fn): New function.
10472         (cimag_internal_fn): New function.
10473         (_initialize_values): Register new internal functions.
10474
10475 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10476
10477         * infrun.c (stop_all_threads): If debug_infrun, always
10478         trace the wait status after wait_one, using
10479         target_waitstatus_to_string and target_pid_to_str.
10480         (handle_inferior_event): Replace various trace of
10481         wait status kind by a single trace.
10482         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10483         wait status kind image by target_waitstatus_to_string.
10484         * target/waitstatus.c (target_waitstatus_to_string): Fix
10485         obsolete comment.
10486
10487 2019-04-01  Tom Tromey  <tromey@adacore.com>
10488
10489         PR symtab/23331:
10490         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10491
10492 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10493             Pedro Alves  <palves@redhat.com>
10494
10495         * top.c (quit_force): Call 'finalize_values'.
10496         * value.c (finalize_values): New function.
10497         * value.h (finalize_values): Declare.
10498
10499 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10500
10501         * NEWS: Announce $_gdb_major and $_gdb_minor.
10502
10503         * top.c (init_gdb_version_vars): New function.
10504         (gdb_init): Call init_gdb_version_vars.
10505
10506 2019-03-29  Tom Tromey  <tromey@adacore.com>
10507
10508         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10509         help text.  Remove dead code.
10510
10511 2019-03-29  Keith Seitz  <keiths@redhat.com>
10512
10513         From Siddhesh Poyarekar:
10514         * f-lang.h (f77_get_upperbound): Return LONGEST.
10515         (f77_get_lowerbound): Likewise.
10516         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10517         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10518         print them.
10519         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10520         plongest to format print it.
10521         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10522         (f77_get_upperbound): Likewise.
10523         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10524         LOWER_BOUND to LONGEST.
10525         (f77_create_arrayprint_offset_tbl): Likewise.
10526
10527 2019-03-29  Keith Seitz  <keiths@redhat.com>
10528
10529         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10530         %s/pulongest for TYPE_LENGTH instead of %d in format
10531         strings.
10532         * ada-typerint.c (ada_print_type): Likewise.
10533         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10534         * compile/compile-c-support.c (generate_register_struct): Likewise.
10535         * gdbtypes.c (recursive_dump_type): Likewise.
10536         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10537         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10538         instead of %d in format strings.
10539         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10540         to std::min to ULONGEST.
10541         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10542         instead of %d in format strings.
10543         * tracepoint.c (info_scope_command): Likewise.
10544         * typeprint.c (print_offset_data::update)
10545         (print_offset_data::finish): Likewise.
10546         * xtensa-tdep.c (xtensa_store_return_value)
10547         (xtensa_push_dummy_call): Likewise.
10548
10549 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10550
10551         * windows-nat.c (display_selector): Fixed format specifications
10552         for 64-bit Cygwin.
10553
10554 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10555
10556         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10557
10558 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10559
10560         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10561         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10562         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10563         (nios2_linux_init_abi): Install it.
10564
10565 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10566
10567         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10568
10569 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10570
10571         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10572
10573 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10574             Tom Tromey  <tromey@adacore.com>
10575
10576         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10577
10578 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10579
10580         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10581         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10582         method to compute the bounds of range types. Also print "[evaluated]"
10583         if the bounds' values come from a dynamic evaluation.
10584
10585 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10586
10587         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10588         whitespace when pretty printing is on.
10589
10590 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10591
10592         * ppc-linux-nat.c: Add include.
10593
10594 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10595
10596         * NEWS: Mention AArch64 Pointer Authentication.
10597
10598 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10599
10600         * arm-linux-nat.c: Add include.
10601
10602 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10603
10604         * source-cache.c (source_cache::get_source_lines): Re-read
10605         fullname after calling open_source_file.
10606
10607 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10608
10609         * NEWS: Mention TLS support for FreeBSD.
10610
10611 2019-03-25  Tom Tromey  <tromey@adacore.com>
10612
10613         * minsyms.c (BUNCH_SIZE): Update comment.
10614         (~minimal_symbol_reader): Remove old comment.
10615         (compact_minimal_symbols): Update comment.
10616         (minimal_symbol_reader::install): Remove old comment.  Update
10617         other comments.
10618
10619 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10620
10621         * s390-linux-nat.c: Add include.
10622
10623 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10624
10625         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10626         Call linux_get_hwcap.
10627         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10628         Likewise.
10629         (aarch64_linux_get_hwcap): Remove function.
10630         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10631         declaration.
10632         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10633         linux_get_hwcap.
10634         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10635         * linux-tdep.c (linux_get_hwcap): Add function.
10636         (linux_get_hwcap2): Likewise.
10637         * linux-tdep.h (linux_get_hwcap): Add declaration.
10638         (linux_get_hwcap2): Likewise.
10639         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10640         (ppc_linux_get_hwcap2): Likewise.
10641         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10642         linux_get_hwcap.
10643         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10644         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10645         (ppc_linux_nat_target::read_description): Likewise.
10646         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10647         * s390-linux-nat.c: Likewise.
10648         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10649
10650 2019-03-24  Tom Tromey  <tom@tromey.com>
10651
10652         * ada-lang.c (standard_lookup): Simplify initialization.
10653         (ada_lookup_symbol_nonlocal): Simplify return.
10654         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10655         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10656         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10657         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10658         initialization.
10659         * solib.c (solib_global_lookup): Simplify.
10660         * symtab.c (null_block_symbol): Remove.
10661         (symbol_cache_lookup): Simplify returns.
10662         (lookup_language_this): Simplify returns.
10663         (lookup_symbol_aux): Simplify return.
10664         (lookup_local_symbol): Simplify returns.
10665         (lookup_global_symbol_from_objfile): Simplify return.
10666         (lookup_symbol_in_objfile_symtabs)
10667         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10668         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10669         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10670         * cp-namespace.c (cp_lookup_bare_symbol)
10671         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10672         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10673         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10674         (cp_lookup_symbol_via_imports): Simplify initialization.
10675         (find_symbol_in_baseclass): Likewise.
10676         * symtab.h (null_block_symbol): Remove.
10677         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10678         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10679         (d_lookup_symbol_module): Likewise.
10680         (find_symbol_in_baseclass): Simplify initialization.
10681
10682 2019-03-24  Tom Tromey  <tom@tromey.com>
10683
10684         * expression.h: Don't include symtab.h.
10685         (struct block): Forward declare.
10686
10687 2019-03-24  Tom Tromey  <tom@tromey.com>
10688
10689         * c-exp.y (typebase): Remove casts.
10690         * gdbtypes.c (lookup_unsigned_typename, )
10691         (lookup_signed_typename): Remove cast.
10692         * eval.c (parse_to_comma_and_eval): Remove cast.
10693         * parse.c (write_dollar_variable): Remove cast.
10694         * block.h (struct block) <superblock>: Now const.
10695         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10696         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10697         (map_block): Make "block" const.
10698         * symfile.h (struct quick_symbol_functions)
10699         <map_matching_symbols>: Constify block argument to "callback".
10700         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10701         const.
10702         (find_pc_sect_compunit_symtab): Make "b" const.
10703         (find_symbol_at_address): Likewise.
10704         (search_symbols): Likewise.
10705         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10706         (dw2_debug_names_lookup_symbol): Likewise.
10707         (dw2_map_matching_symbols): Update.
10708         * p-valprint.c (pascal_val_print): Remove "block".
10709         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10710         (aux_add_nonlocal_symbols): Make "block" const.
10711         (resolve_subexp): Remove cast.
10712         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10713         const.
10714         (iterate_over_file_blocks): Likewise.
10715         * f-exp.y (%union) <bval>: Remove.
10716         * coffread.c (patch_opaque_types): Make "b" const.
10717         * spu-tdep.c (spu_catch_start): Make "block" const.
10718         * c-valprint.c (print_unpacked_pointer): Remove "block".
10719         * symmisc.c (dump_symtab_1): Make "b" const.
10720         (block_depth): Make "block" const.
10721         * d-exp.y (%union) <bval>: Remove.
10722         * cp-support.h (cp_lookup_rtti_type): Update.
10723         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10724         * psymtab.c (psym_lookup_symbol): Make "block" const.
10725         (maintenance_check_psymtabs): Make "b" const.
10726         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10727         (enumerate_locals, enumerate_args): Update.
10728         * python/py-symtab.c (stpy_global_block): Make "block" const.
10729         (stpy_static_block): Likewise.
10730         * inline-frame.c (block_starting_point_at): Make "new_block"
10731         const.
10732         * block.c (find_block_in_blockvector): Make return type const.
10733         (blockvector_for_pc_sect): Make "b" const.
10734         (find_block_in_blockvector): Make "b" const.
10735
10736 2019-03-23  Tom Tromey  <tom@tromey.com>
10737
10738         * varobj.c (varobj_create): Update.
10739         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10740         * printcmd.c (display_command, do_one_display): Don't reset
10741         innermost_block.
10742         * parser-defs.h (enum innermost_block_tracker_type): Move to
10743         expression.h.
10744         (innermost_block): Update comment.
10745         * parse.c (parse_exp_1): Add tracker_types parameter.
10746         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10747         tracker_types parameter.  Reset innermost_block.
10748         (parse_exp_in_context): Remove.
10749         (parse_expression_for_completion): Update.
10750         * objfiles.c (~objfile): Don't reset expression_context_block or
10751         innermost_block.
10752         * expression.h (enum innermost_block_tracker_type): Move from
10753         parser-defs.h.
10754         (parse_exp_1): Add tracker_types parameter.
10755         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10756         reset innermost_block.
10757
10758 2019-03-23  Tom Tromey  <tom@tromey.com>
10759
10760         * objfiles.h: Include bcache.h.
10761
10762 2019-03-23  Tom Tromey  <tom@tromey.com>
10763
10764         * linespec.c (get_current_search_block): Use
10765         scoped_restore_current_language.
10766         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10767
10768 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10769             Jiong Wang  <jiong.wang@arm.com>
10770
10771         * aarch64-linux-tdep.c
10772         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10773         section.
10774         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10775
10776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10777             Jiong Wang  <jiong.wang@arm.com>
10778
10779         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10780         instructions.
10781         (aarch64_analyze_prologue_test): Add PACIASP test.
10782         (aarch64_prologue_prev_register): Unmask PC value.
10783
10784 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10785             Jiong Wang  <jiong.wang@arm.com>
10786
10787         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10788         (aarch64_dwarf2_prev_register): Unmask PC value.
10789         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10790         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10791         DW_CFA_AARCH64_negate_ra_state.
10792         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10793
10794 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10795             Jiong Wang  <jiong.wang@arm.com>
10796
10797         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10798         registers.
10799         (aarch64_pseudo_register_name): Likewise.
10800         (aarch64_pseudo_register_type): Likewise.
10801         (aarch64_pseudo_register_reggroup_p): Likewise.
10802         (aarch64_gdbarch_init): Add pauth registers.
10803         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10804         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10805         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10806         (struct gdbarch_tdep): Add regnum for ra_state.
10807
10808 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10809             Jiong Wang  <jiong.wang@arm.com>
10810
10811         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10812
10813 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10814             Jiong Wang  <jiong.wang@arm.com>
10815
10816         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10817         function.
10818         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10819         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10820         (aarch64_gdbarch_init): Add puth registers.
10821         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10822         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10823         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10824
10825 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10826             Jiong Wang  <jiong.wang@arm.com>
10827
10828         * aarch64-linux-nat.c
10829         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10830         * aarch64-linux-tdep.c
10831         (aarch64_linux_core_read_description): Likewise.
10832         (aarch64_linux_get_hwcap): New function.
10833         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10834         (aarch64_linux_get_hwcap): New declaration.
10835
10836 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10837             Jiong Wang  <jiong.wang@arm.com>
10838
10839         * aarch64-linux-nat.c
10840         (aarch64_linux_nat_target::read_description): Add pauth param.
10841         * aarch64-linux-tdep.c
10842         (aarch64_linux_core_read_description): Likewise.
10843         * aarch64-tdep.c (struct target_desc): Add in pauth.
10844         (aarch64_read_description): Add pauth param.
10845         (aarch64_gdbarch_init): Likewise.
10846         * aarch64-tdep.h (aarch64_read_description): Likewise.
10847         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10848         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10849         * features/Makefile: Add new files.
10850         * features/aarch64-pauth.c: New file.
10851         * features/aarch64-pauth.xml: New file.
10852
10853 2019-03-20  Tom Tromey  <tromey@adacore.com>
10854
10855         * infrun.c (handle_inferior_event): Rename from
10856         handle_inferior_event_1.  Create a scoped_value_mark.
10857         (handle_inferior_event): Remove.
10858
10859 2019-03-19  Tom Tromey  <tromey@adacore.com>
10860
10861         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10862         * infrun.h (print_stop_event): Add "displays" parameter.
10863         * infrun.c (print_stop_event): Add "displays" parameter.
10864
10865 2019-03-19  Pedro Alves  <palves@redhat.com>
10866
10867         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10868         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10869         to -1.  Fix TABs vs spaces.
10870         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10871         * tui/tui-out.h (tui_ui_out) Add intro comments.
10872         <m_line, m_start_of_line>: In-class initialize, and add describing
10873         comment.
10874
10875 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10876
10877         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10878         variable names.
10879         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10880
10881 2019-03-18  Pedro Alves  <palves@redhat.com>
10882             Eli Zaretskii <eliz@gnu.org>
10883
10884         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10885         m_line and m_start_of_line.
10886
10887 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10888
10889         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10890         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10891         it returns a newline.  This fixes a regression in TU mode, whereby
10892         the next line is output on the same screen line as the user input.
10893
10894 2019-03-18  Tom Tromey  <tromey@adacore.com>
10895
10896         * minsyms.c (minimal_symbol_reader::install): Remove call to
10897         obstack_blank.
10898
10899 2019-03-18  Pedro Alves  <palves@redhat.com>
10900
10901         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10902         New globals.
10903         (apply_style): New, factored out from ...
10904         (apply_ansi_escape): ... this.  Handle reverse video mode.
10905         (tui_set_reverse_mode): New function.
10906         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10907         * tui/tui-winsource.c (tui_show_source_line): Use
10908         tui_set_reverse_mode instead of setting A_STANDOUT.
10909         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10910         New setter methods.
10911
10912 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10913
10914         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10915         Handle tabs.
10916
10917 2019-03-18  Tom Tromey  <tromey@adacore.com>
10918
10919         * ada-lang.c (empty_array): Add "high" parameter.
10920         (ada_evaluate_subexp): Update.
10921
10922 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10923
10924         * unittests/string_view-selftests.c: Define
10925         _initialize_string_view_selftests unconditionally.
10926
10927 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10928
10929         PR gdb/24350
10930         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10931
10932 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10933
10934         PR gdb/24351
10935         * windows-nat.c (display_selector): Fix format specifiers.
10936
10937 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10938
10939         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10940         tui_refill_source_window instead of tui_refresh_win, to update the
10941         current execution line.  This fixes redisplay of the current line
10942         when stepping through the code with "next" or "step".
10943
10944 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10945
10946         * source-cache.c (source_cache::get_source_lines): Call
10947         find_source_lines to initialize s->nlines.  This fixes vertical
10948         scrolling of TUI source window when the DOWN arrow is pressed.
10949
10950 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10951
10952         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10953         linux-thread-db.c (_initialize_thread_db): Likewise.
10954
10955 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10956
10957         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10958         wclrtoeol in tui_show_source_line".  This reverts changes made in
10959         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10960
10961 2019-03-15  Tom Tromey  <tom@tromey.com>
10962
10963         * symtab.h (struct minimal_symbol): Derive from
10964         general_symbol_info.
10965         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10966         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10967         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10968         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10969         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10970         (MSYMBOL_SEARCH_NAME): Update.
10971         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10972         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10973         * minsyms.c (minimal_symbol_reader::record_full): Update.
10974
10975 2019-03-15  Tom Tromey  <tom@tromey.com>
10976
10977         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10978
10979 2019-03-15  Tom Tromey  <tom@tromey.com>
10980
10981         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10982         unique_xmalloc_ptr.
10983         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10984         Update.
10985         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10986         (build_minimal_symbol_hash_tables)
10987         (minimal_symbol_reader::install): Update.
10988
10989 2019-03-15  Tom Tromey  <tom@tromey.com>
10990
10991         * symtab.c (create_demangled_names_hash): Update.
10992         (symbol_set_names): Update.
10993         * objfiles.h (struct objfile_per_bfd_storage)
10994         <demangled_names_hash>: Now an htab_up.
10995         * objfiles.c (objfile_per_bfd_storage): Simplify.
10996
10997 2019-03-15  Tom Tromey  <tom@tromey.com>
10998
10999         * objfiles.h (struct objfile_per_bfd_storage): Declare
11000         destructor.
11001         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11002         New.
11003         (get_objfile_bfd_data): Use new.  Don't initialize
11004         language_of_main.
11005         (free_objfile_per_bfd_storage): Remove.
11006         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11007
11008 2019-03-15  Tom Tromey  <tom@tromey.com>
11009
11010         * symfile.c (reread_symbols): Update.
11011         * objfiles.c (objfile::objfile): Update.
11012         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11013         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11014         comment.
11015         (minimal_symbol_reader::install): Update.
11016         (terminate_minimal_symbol_table): Remove.
11017         * jit.c (jit_object_close_impl): Update.
11018
11019 2019-03-15  Tom Tromey  <tom@tromey.com>
11020
11021         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11022         initializations.
11023
11024 2019-03-15  Tom Tromey  <tom@tromey.com>
11025
11026         * objfiles.h (struct objfile_per_bfd_storage)
11027         <demangled_hash_languages>: Now a bitset.
11028         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11029         (lookup_minimal_symbol): Update.
11030
11031 2019-03-15  Tom Tromey  <tom@tromey.com>
11032
11033         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11034         Don't return the symbol.
11035         * coffread.c (record_minimal_symbol): Use record_full.
11036
11037 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11038
11039         The MS-Windows port of ncurses fails to switch to a color pair if
11040         one or both of the colors are the implicit default colors.  This
11041         change records the default colors when TUI is initialized, and
11042         then specifies them explicitly when a color pair uses the default
11043         colors.  This allows color styling in TUI mode on MS-Windows.
11044
11045         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11046         ncurses_norm_attr.
11047         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11048         colors in ncurses_norm_attr.
11049         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11050         "none", replace it with the default color recorded in
11051         ncurses_norm_attr.
11052
11053 2019-03-14  Tom Tromey  <tromey@adacore.com>
11054
11055         * source-cache.h (class source_cache) <get_source_lines>: Return
11056         std::string.
11057         * source-cache.c (source_cache::extract_lines): Handle case where
11058         first_pos==npos.  Return std::string.
11059         (source_cache::get_source_lines): Update.
11060
11061 2019-03-14  Tom Tromey  <tromey@adacore.com>
11062
11063         * NEWS: Add item for "style sources" commands.
11064         * source-cache.c (source_cache::get_source_lines): Check
11065         source_styling.
11066         * cli/cli-style.c (source_styling): New global.
11067         (_initialize_cli_style): Add "style sources" commands.
11068         (show_style_sources): New function.
11069         * cli/cli-style.h (source_styling): Declare.
11070
11071 2019-03-14  Pedro Alves  <palves@redhat.com>
11072             Tom Tromey  <tromey@adacore.com>
11073
11074         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11075         * tui/tui-winsource.c (tui_refill_source_window): New function,
11076         from...
11077         (tui_horizontal_source_scroll): ... here.  Move some logic.
11078         * cli/cli-style.c (set_style_enabled): Notify new observable.
11079         * tui/tui-hooks.c (tui_redisplay_source): New function.
11080         (tui_attach_detach_observers): Attach or detach
11081         tui_redisplay_source.
11082         * observable.h (source_styling_changed): New observable.
11083         * observable.c: Define source_styling_changed observable.
11084
11085 2019-03-13  Tom Tromey  <tromey@adacore.com>
11086
11087         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11088         (i386_gnu_nat_target::store_registers): Update.
11089         * target-debug.h (target_debug_print_std_string): New macro.
11090         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11091         * windows-tdep.c (display_one_tib): Update.
11092         * tui/tui-stack.c (tui_make_status_line): Update.
11093         * top.c (print_inferior_quit_action): Update.
11094         * thread.c (thr_try_catch_cmd): Update.
11095         (add_thread_with_info): Update.
11096         (thread_target_id_str): Update.
11097         (thr_try_catch_cmd): Update.
11098         (thread_command): Update.
11099         (thread_find_command): Update.
11100         * record-btrace.c (record_btrace_target::info_record)
11101         (record_btrace_resume_thread, record_btrace_target::resume)
11102         (record_btrace_cancel_resume, record_btrace_step_thread)
11103         (record_btrace_target::wait, record_btrace_target::wait)
11104         (record_btrace_target::wait, record_btrace_target::stop): Update.
11105         * progspace.c (print_program_space): Update.
11106         * process-stratum-target.c
11107         (process_stratum_target::thread_address_space): Update.
11108         * linux-fork.c (linux_fork_mourn_inferior)
11109         (detach_checkpoint_command, info_checkpoints_command)
11110         (linux_fork_context): Update.
11111         (linux_fork_detach): Update.
11112         (class scoped_switch_fork_info): Update.
11113         (delete_checkpoint_command): Update.
11114         * infrun.c (follow_fork_inferior): Update.
11115         (follow_fork_inferior): Update.
11116         (proceed_after_vfork_done): Update.
11117         (handle_vfork_child_exec_or_exit): Update.
11118         (follow_exec): Update.
11119         (displaced_step_prepare_throw): Update.
11120         (displaced_step_restore): Update.
11121         (start_step_over): Update.
11122         (resume_1): Update.
11123         (clear_proceed_status_thread): Update.
11124         (proceed): Update.
11125         (print_target_wait_results): Update.
11126         (do_target_wait): Update.
11127         (context_switch): Update.
11128         (stop_all_threads): Update.
11129         (restart_threads): Update.
11130         (finish_step_over): Update.
11131         (handle_signal_stop): Update.
11132         (switch_back_to_stepped_thread): Update.
11133         (keep_going_pass_signal): Update.
11134         (print_exited_reason): Update.
11135         (normal_stop): Update.
11136         * inferior.c (inferior_pid_to_str): Change return type.
11137         (print_selected_inferior): Update.
11138         (add_inferior): Update.
11139         (detach_inferior): Update.
11140         * dummy-frame.c (fprint_dummy_frames): Update.
11141         * dcache.c (dcache_info_1): Update.
11142         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11143         (btrace_fetch, btrace_clear): Update.
11144         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11145         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11146         type.
11147         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11148         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11149         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11150         * gdbarch.c, gdbarch.h: Rebuild.
11151         * gdbarch.sh (core_pid_to_str): Change return type.
11152         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11153         return type.
11154         (windows_nat_target::pid_to_str): Change return type.
11155         (windows_delete_thread): Update.
11156         (windows_nat_target::attach): Update.
11157         (windows_nat_target::files_info): Update.
11158         * target-delegates.c: Rebuild.
11159         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11160         return type.
11161         (sol_thread_target::pid_to_str): Change return type.
11162         * remote.c (class remote_target) <pid_to_str>: Change return
11163         type.
11164         (remote_target::pid_to_str): Change return type.
11165         (extended_remote_target::attach, remote_target::remote_stop_ns)
11166         (remote_target::remote_notif_remove_queued_reply)
11167         (remote_target::push_stop_reply, remote_target::disable_btrace):
11168         Update.
11169         (extended_remote_target::attach): Update.
11170         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11171         type.
11172         (gdbsim_target::pid_to_str): Change return type.
11173         * ravenscar-thread.c (struct ravenscar_thread_target)
11174         <pid_to_str>: Change return type.
11175         (ravenscar_thread_target::pid_to_str): Change return type.
11176         * procfs.c (class procfs_target) <pid_to_str>: Change return
11177         type.
11178         (procfs_target::pid_to_str): Change return type.
11179         (procfs_target::attach): Update.
11180         (procfs_target::detach): Update.
11181         (procfs_target::fetch_registers): Update.
11182         (procfs_target::store_registers): Update.
11183         (procfs_target::wait): Update.
11184         (procfs_target::files_info): Update.
11185         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11186         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11187         return type.
11188         (nto_procfs_target::pid_to_str): Change return type.
11189         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11190         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11191         return type.
11192         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11193         (exit_lwp): Update.
11194         (attach_proc_task_lwp_callback, get_detach_signal)
11195         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11196         (linux_nat_target::resume, wait_lwp, stop_callback)
11197         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11198         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11199         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11200         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11201         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11202         type.
11203         (inf_ptrace_target::attach): Update.
11204         (inf_ptrace_target::files_info): Update.
11205         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11206         type.
11207         (go32_nat_target::pid_to_str): Change return type.
11208         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11209         (gnu_nat_target::wait): Update.
11210         (gnu_nat_target::wait): Update.
11211         (gnu_nat_target::resume): Update.
11212         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11213         (fbsd_nat_target::wait): Update.
11214         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11215         type.
11216         (darwin_nat_target::attach): Update.
11217         * corelow.c (class core_target) <pid_to_str>: Change return type.
11218         (core_target::pid_to_str): Change return type.
11219         * target.c (normal_pid_to_str): Change return type.
11220         (default_pid_to_str): Likewise.
11221         (target_pid_to_str): Change return type.
11222         (target_translate_tls_address): Update.
11223         (target_announce_detach): Update.
11224         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11225         return type.
11226         (bsd_uthread_target::pid_to_str): Change return type.
11227         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11228         type.
11229         (bsd_kvm_target::pid_to_str): Change return type.
11230         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11231         return type.
11232         (aix_thread_target::pid_to_str): Change return type.
11233         * target.h (struct target_ops) <pid_to_str>: Change return type.
11234         (target_pid_to_str, normal_pid_to_str): Likewise.
11235         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11236         type.
11237         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11238         type.
11239         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11240         return type.
11241         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11242         type.
11243         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11244         type.
11245         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11246         return type.
11247
11248 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11249
11250         * NEWS: Mention that the new default MI version is 3.  Mention
11251         changes to the output of commands and events that deal with
11252         multi-location breakpoints.
11253         * breakpoint.c: Include "mi/mi-out.h".
11254         (print_one_breakpoint): Change output syntax if using MI version
11255         >= 3.
11256         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11257         New.
11258         (mi_multi_location_breakpoint_output_fixed): New.
11259         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11260         (mi_cmd_fix_multi_location_breakpoint_output): New.
11261         (mi_multi_location_breakpoint_output_fixed): New.
11262         * mi/mi-cmds.c (mi_cmds): Register command
11263         -fix-multi-location-breakpoint-output.
11264         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11265         interpreter "mi".
11266
11267 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11268
11269         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11270         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11271         instantiate mi_ui_out based on interpreter name.
11272         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11273         * mi/mi-main.c (mi_load_progress): Likewise.
11274
11275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11276
11277         * NEWS: Combine separate "New targets" sections for 8.3.
11278
11279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11280
11281         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11282         (ppcfbsd_init_abi): Install gdbarch
11283         "fetch_tls_load_module_address" and "get_thread_local_address"
11284         methods.
11285
11286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11287
11288         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11289         (riscv_fbsd_init_abi): Install gdbarch
11290         "fetch_tls_load_module_address" and "get_thread_local_address"
11291         methods.
11292
11293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11294
11295         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11296         (i386fbsd_init_abi): Install gdbarch
11297         "fetch_tls_load_module_address" and "get_thread_local_address"
11298         methods.
11299
11300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11301
11302         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11303         (amd64fbsd_init_abi): Install gdbarch
11304         "fetch_tls_load_module_address" and "get_thread_local_address"
11305         methods.
11306
11307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11308
11309         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11310         (struct fbsd_pspace_data): New type.
11311         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11312         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11313         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11314         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11315         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11316
11317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11318
11319         * gdbtypes.c (lookup_struct_elt): New function.
11320         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11321         * gdbtypes.h (struct struct_elt): New type.
11322         (lookup_struct_elt): New prototype.
11323
11324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11325
11326         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11327         remove disabled code block.
11328
11329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11330
11331         * gdbarch.sh (get_thread_local_address): New method.
11332         * gdbarch.h, gdbarch.c: Regenerate.
11333         * target.c (target_translate_tls_address): Use
11334         gdbarch_get_thread_local_address if present instead of
11335         target::get_thread_local_address.
11336
11337 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11338
11339         * target.h (target::get_thread_local_address): Update comment.
11340
11341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11342
11343         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11344         objfile->separate_debug_objfile_backlink if not NULL.
11345
11346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11347
11348         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11349         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11350         (amd64bsd_store_inferior_registers): Likewise.
11351         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11352         Enable segment base registers.
11353         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11354         PT_GETFSBASE and PT_GETGSBASE.
11355         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11356         PT_SETGSBASE.
11357         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11358         segment base registers.
11359         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11360
11361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11362
11363         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11364         Update calls to i386_target_description to add 'segments'
11365         parameter.
11366         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11367         add segment base registers.
11368         * arch/i386.c (i386_create_target_description): Add 'segments'
11369         parameter to enable segment base registers.
11370         * arch/i386.h (i386_create_target_description): Likewise.
11371         * features/i386/32bit-segments.xml: New file.
11372         * features/i386/32bit-segments.c: Generate.
11373         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11374         call to i386_target_description to add 'segments' parameter.
11375         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11376         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11377         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11378         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11379         if feature is present.
11380         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11381         Add 'segments' parameter to call to i386_target_description.
11382         (i386_target_description): Add 'segments' parameter to enable
11383         segment base registers.
11384         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11385         to call to i386_target_description.
11386         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11387         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11388         Define I386_NUM_REGS.
11389         (i386_target_description): Add 'segments' parameter to enable
11390         segment base registers.
11391
11392 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11393
11394         PR/24325
11395         * source-cache.c: #undef open and close, to avoid unresolved
11396         externals during linking.
11397
11398 2019-03-12  Tom Tromey  <tromey@adacore.com>
11399
11400         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11401         const.  Add initializers.
11402         (_initialize_remote): Don't initialize ptid globals.
11403
11404 2019-03-12  Pedro Alves  <palves@redhat.com>
11405
11406         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11407
11408 2019-03-12  Pedro Alves  <palves@redhat.com>
11409
11410         * cp-name-parser.y (main): Remove unused 'len' variable.
11411
11412 2019-03-12  Tom Tromey  <tromey@adacore.com>
11413
11414         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11415         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11416
11417 2019-03-12  Tom Tromey  <tromey@adacore.com>
11418
11419         * linux-nat.c (iterate_over_lwps): Update.
11420         (stop_callback): Remove parameter.
11421         (stop_wait_callback, detach_callback, resume_set_callback)
11422         (select_singlestep_lwp_callback, set_ignore_sigint)
11423         (status_callback, resumed_callback, resume_clear_callback)
11424         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11425         data parameter.
11426         (linux_nat_target::detach, linux_nat_target::resume)
11427         (linux_stop_and_wait_all_lwps, select_event_lwp)
11428         (linux_nat_filter_event, linux_nat_wait_1)
11429         (linux_nat_target::kill, linux_nat_target::stop)
11430         (linux_nat_target::stop): Update.
11431         (linux_nat_resume_callback): Change type.
11432         (resume_stopped_resumed_lwps, count_events_callback)
11433         (select_event_lwp_callback): Likewise.
11434         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11435         * arm-linux-nat.c (struct update_registers_data): Remove.
11436         (update_registers_callback): Change type.
11437         (arm_linux_insert_hw_breakpoint1): Update.
11438         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11439         parameter.
11440         (x86_linux_dr_set_addr): Update.
11441         (x86_linux_dr_set_control): Update.
11442         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11443         (iterate_over_lwps): Use gdb::function_view.
11444         * nat/aarch64-linux-hw-point.c (struct
11445         aarch64_dr_update_callback_param): Remove.
11446         (debug_reg_change_callback): Change type.
11447         (aarch64_notify_debug_reg_change): Update.
11448         * s390-linux-nat.c (s390_refresh_per_info): Update.
11449
11450 2019-03-11  Tom Tromey  <tromey@adacore.com>
11451
11452         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11453         redundant assignment to "this_cu".
11454
11455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11456
11457         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11458
11459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11460
11461         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11462         from...
11463         (rank_one_type): ... this.
11464
11465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11466
11467         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11468         from...
11469         (rank_one_type): ... this.
11470
11471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11472
11473         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11474         from...
11475         (rank_one_type): ... this.
11476
11477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11478
11479         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11480         from...
11481         (rank_one_type): ... this.
11482
11483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11484
11485         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11486         from...
11487         (rank_one_type): ... this.
11488
11489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11490
11491         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11492         from...
11493         (rank_one_type): ... this.
11494
11495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11496
11497         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11498         from...
11499         (rank_one_type): ... this.
11500
11501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11502
11503         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11504         from...
11505         (rank_one_type): ... this.
11506
11507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11508
11509         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11510         from...
11511         (rank_one_type): ... this.
11512
11513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11514
11515         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11516         from...
11517         (rank_one_type): ... this.
11518
11519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11520
11521         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11522         from...
11523         (rank_one_type): ... this.
11524
11525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11526
11527         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11528         from...
11529         (rank_one_type): ... this.
11530
11531 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11532
11533         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11534         inferior-events' shows the example events.
11535
11536 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11537
11538         Support styling on native MS-Windows console
11539
11540         PR/24315
11541         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11542         on MS-Windows if $TERM is not defined.
11543
11544         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11545
11546         * posix-hdep.c (gdb_console_fputs):
11547         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11548         functions.
11549         * ui-file.h (gdb_console_fputs): Add prototype.
11550
11551         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11552         back to fputs only if the former returns zero.
11553
11554 2019-03-07  Tom Tromey  <tom@tromey.com>
11555
11556         * symmisc.c (print_symbol_bcache_statistics): Update.
11557         (print_objfile_statistics): Update.
11558         * symfile.c (allocate_symtab): Update.
11559         * stabsread.c: Don't include bcache.h.
11560         * psymtab.h (struct psymbol_bcache): Don't declare.
11561         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11562         (psymbol_bcache_init, psymbol_bcache_free)
11563         (psymbol_bcache_get_bcache): Don't declare.
11564         * psymtab.c (struct psymbol_bcache): Remove.
11565         (psymtab_storage::psymtab_storage): Update.
11566         (psymtab_storage::~psymtab_storage): Update.
11567         (psymbol_bcache_init, psymbol_bcache_free)
11568         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11569         (add_psymbol_to_bcache): Update.
11570         (allocate_psymtab): Update.
11571         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11572         macro_cache>: No longer pointers.
11573         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11574         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11575         * macrotab.c (macro_bcache): Update.
11576         * macroexp.c: Don't include bcache.h.
11577         * gdbtypes.c (check_types_worklist): Update.
11578         (types_deeply_equal): Remove TRY/CATCH.  Update.
11579         * elfread.c (elf_symtab_read): Update.
11580         * dwarf2read.c: Don't include bcache.h.
11581         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11582         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11583         (print_bcache_statistics, bcache_memory_used): Don't declare.
11584         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11585         methods.  Rename all data members.
11586         * bcache.c (struct bcache): Move to bcache.h.
11587         (bcache::expand_hash_table): Rename from expand_hash_table.
11588         (bcache): Remove.
11589         (bcache::insert): Rename from bcache_full.
11590         (bcache::compare): Rename from bcache_compare.
11591         (bcache_xmalloc): Remove.
11592         (bcache::~bcache): Rename from bcache_xfree.
11593         (bcache::print_statistics): Rename from print_bcache_statistics.
11594         (bcache::memory_used): Rename from bcache_memory_used.
11595
11596 2019-03-07  Pedro Alves  <palves@redhat.com>
11597
11598         * infrun.c (normal_stop): Also check for
11599         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11600
11601 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11602
11603         * f-lang.c (value_from_host_double): Moved to...
11604         * value.c (value_from_host_double): ...here.
11605         * value.h (value_from_host_double): Declare.
11606         * guile/scm-math.c (vlscm_convert_typed_number): Use
11607         value_from_host_double.
11608         (vlscm_convert_number): Likewise.
11609         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11610         * python/py-value.c (convert_value_from_python): Likewise.
11611
11612 2019-03-06  Tom Tromey  <tom@tromey.com>
11613
11614         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11615
11616 2019-03-06  Tom Tromey  <tom@tromey.com>
11617
11618         * utils.h (free_current_contents): Don't declare.
11619         * utils.c (free_current_contents): Remove.
11620
11621 2019-03-06  Tom Tromey  <tom@tromey.com>
11622
11623         * top.c (quit_force): Update.
11624         * main.c (captured_command_loop): Update.
11625         * common/new-op.c (operator new): Update.
11626         * common/common-exceptions.c (struct catcher)
11627         <save_cleanup_chain>: Remove member.
11628         (exceptions_state_mc_init): Update.
11629         (exception_try_scope_entry): Return nullptr.
11630         (exception_try_scope_exit, exception_rethrow)
11631         (throw_exception_sjlj, throw_exception_cxx): Update.
11632         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11633         (all_cleanups, do_cleanups, discard_cleanups)
11634         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11635         (restore_cleanups, restore_final_cleanups): Don't declare.
11636         (do_final_cleanups): Remove parameter.
11637         * common/cleanups.c (cleanup_chain, make_cleanup)
11638         (make_cleanup_dtor, all_cleanups, do_cleanups)
11639         (discard_my_cleanups, discard_cleanups)
11640         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11641         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11642         (null_cleanup): Remove.
11643         (do_final_cleanups): Remove parameter.
11644
11645 2019-03-06  Tom Tromey  <tom@tromey.com>
11646
11647         * remote.c (remote_target::remote_parse_stop_reply): Use
11648         unique_xmalloc_ptr.
11649
11650 2019-03-06  Tom Tromey  <tom@tromey.com>
11651
11652         * stabsread.c (struct stabs_field_info): Rename from field_info.
11653         <list, fnlist>: Add initializers.
11654         <obstack>: New member.
11655         (read_member_functions, read_struct_fields, read_baseclasses):
11656         Allocate on obstack.  Don't use cleanups.
11657         (read_one_struct_field, read_member_functions, read_struct_fields)
11658         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11659         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11660         (read_struct_type): Update.
11661
11662 2019-03-06  Tom Tromey  <tom@tromey.com>
11663
11664         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11665         * common/filestuff.h (make_cleanup_close): Don't declare.
11666         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11667         Remove.
11668
11669 2019-03-06  Tom Tromey  <tom@tromey.com>
11670
11671         * solib-aix.c: Use make_scope_exit.
11672
11673 2019-03-06  Tom Tromey  <tom@tromey.com>
11674
11675         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11676         Use make_scope_exit.
11677
11678 2019-03-06  Tom Tromey  <tom@tromey.com>
11679
11680         * solib-svr4.c (disable_probes_interface): Remove parameter.
11681         (svr4_handle_solib_event): Use make_scope_exit.
11682
11683 2019-03-06  Tom Tromey  <tom@tromey.com>
11684
11685         * remote.c (struct stop_reply_deleter): Remove.
11686         (stop_reply_up): Update.
11687         (struct stop_reply): Derive from notif_event.  Don't typedef.
11688         <regcache>: Now a std::vector.
11689         (stop_reply_xfree): Remove.
11690         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11691         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11692         (remote_target::discard_pending_stop_replies): Use delete.
11693         (remote_target::remote_parse_stop_reply): Update.
11694         (remote_target::process_stop_reply): Update.
11695         * remote-notif.h (struct notif_event): Add virtual destructor.
11696         Remove "dtr" member.
11697         (struct notif_client) <alloc_event>: Return a unique_ptr.
11698         (notif_event_xfree): Don't declare.
11699         (notif_event_up): New typedef.
11700         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11701         (notif_event_xfree, do_notif_event_xfree): Remove.
11702         (remote_notif_state_xfree): Update.
11703
11704 2019-03-06  Tom Tromey  <tom@tromey.com>
11705
11706         * infrun.c (displaced_step_clear_cleanup): Now a
11707         forward_scope_exit type.
11708         (displaced_step_prepare_throw): Update.
11709         (displaced_step_fixup): Update.
11710
11711 2019-03-06  Tom Tromey  <tom@tromey.com>
11712
11713         * inferior.h (class inferior): Update comment.
11714         * gdbthread.h (class thread_info): Update comment.
11715
11716 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11717             Tom Tromey  <tom@tromey.com>
11718
11719         * stabsread.h (struct stab_section_list): Remove.
11720         (coffstab_build_psymtabs): Update.
11721         * dbxread.c (symbuf_sections): Now a std::vector.
11722         (sect_idx): New global.
11723         (fill_symbuf): Update.
11724         (coffstab_build_psymtabs): Change type of stabsects parameter.
11725         Update.
11726         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11727         std::vector.
11728         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11729         (coff_locate_sections): Update.
11730         (coff_symfile_read): Remove cleanups.  Update.
11731         (init_stringtab): Add storage parameter.
11732         (free_stringtab, free_stringtab_cleanup): Remove.
11733         (init_lineno): Add storage parameter.
11734         (free_linetab, free_linetab_cleanup): Remove.
11735
11736 2019-03-06  Pedro Alves  <palves@redhat.com>
11737
11738         * linux-fork.c (fork_info::clobber_regs): Delete.
11739         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11740         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11741         comment.  Adjust.
11742         (scoped_switch_fork_info::scoped_switch_fork_info)
11743         (checkpoint_command, linux_fork_context): Adjust
11744         fork_save_infrun_state calls.
11745
11746 2019-03-06  Pedro Alves  <palves@redhat.com>
11747
11748         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11749         (inf_has_multiple_threads): Return 'bool' and rewrite using
11750         inferior_info::threads().
11751
11752 2019-03-06  Pedro Alves  <palves@redhat.com>
11753
11754         * linux-fork.c: Include <list>.
11755         (fork_list): Now a std::list instance.
11756         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11757         (forks_exist_p, find_last_fork): Adjust.
11758         (new_fork): Delete.
11759         (one_fork_p): New.
11760         (add_fork): Adjust.
11761         (free_fork): Delete, folded into fork_info::~fork_info().
11762         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11763         Adjust.
11764         (init_fork_list): Delete.
11765         (linux_fork_killall, linux_fork_mourn_inferior)
11766         (linux_fork_detach, info_checkpoints_command): Adjust.
11767         (_initialize_linux_fork): No longer call init_fork_list.
11768
11769 2019-03-06  Pedro Alves  <palves@redhat.com>
11770
11771         * linux-fork.c (new_fork): New, split out of ...
11772         (add_fork): ... this.  Return void.  Move "first fork" special
11773         case from here, to ...
11774         (checkpoint_command): ... here.
11775         * linux-linux.h (add_fork): Return void.
11776
11777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11778
11779         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11780
11781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11782             Chris January  <chris.january@arm.com>
11783             David Lecomber  <david.lecomber@arm.com>
11784
11785         * f-exp.y: New token, UNOP_INTRINSIC.
11786         (exp): New pattern using UNOP_INTRINSIC token.
11787         (f77_keywords): Add 'abs' keyword.
11788         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11789         (value_from_host_double): New function.
11790         (evaluate_subexp_f): Support UNOP_ABS.
11791
11792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11793
11794         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11795         types.
11796
11797 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11798
11799         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11800         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11801         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11802
11803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11804
11805         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11806
11807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11808             Chris January  <chris.january@arm.com>
11809
11810         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11811         * f-exp.y: Define 'KIND' token.
11812         (exp): New pattern for KIND expressions.
11813         (ptype): Handle types with a kind extension.
11814         (direct_abs_decl): Extend to spot kind extensions.
11815         (f77_keywords): Add 'kind' to the list.
11816         (push_kind_type): New function.
11817         (convert_to_kind_type): New function.
11818         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11819         * parse.c (operator_length_standard): Likewise.
11820         * parser-defs.h (enum type_pieces): Add tp_kind.
11821         * std-operator.def: Add UNOP_KIND.
11822
11823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11824
11825         * f-exp.y (f_parse): Set yydebug.
11826
11827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11828
11829         * f-lang.c (evaluate_subexp_f): New function.
11830         (exp_descriptor_f): New global.
11831         (f_language_defn): Use exp_descriptor_f instead of
11832         exp_descriptor_standard.
11833
11834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11835
11836         * f-exp.y (struct token): Add comments.
11837         (dot_ops): Remove uppercase versions and the end marker.
11838         (f77_keywords): Likewise.
11839         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11840         entries in the dot_ops array are case insensitive, and use
11841         strncasecmp to compare strings.  Also some whitespace cleanup in
11842         this area.  Similar for the f77_keywords array, except entries in
11843         this list might be case sensitive.
11844
11845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11846
11847         * f-exp.y (struct f77_boolean_val): Add comments.
11848         (boolean_values): Remove uppercase versions, and end marker.
11849         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11850         and use strncasecmp to achieve case insensitivity.  Additionally,
11851         perform whitespace cleanup around this code.
11852
11853 2019-03-06  Tom Tromey  <tromey@adacore.com>
11854
11855         * remote-sim.c (gdbsim_target_open): Use result of
11856         gdb_argv::release.
11857
11858 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11859         Dirk Schubert  <dirk.schubert@arm.com>
11860         Chris January  <chris.january@arm.com>
11861
11862         * eval.c (evaluate_subexp_standard): Call Fortran argument
11863         wrapping logic.
11864         * f-lang.c (struct value): A value which can be passed into a
11865         Fortran function call.
11866         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11867         where appropriate.
11868         (struct type): Value ready for a Fortran function call.
11869         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11870         is needed.
11871         * f-lang.h (fortran_argument_convert): Declaration.
11872         (fortran_preserve_arg_pointer): Declaration.
11873         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11874
11875 2019-03-05  Tom Tromey  <tromey@adacore.com>
11876
11877         * python/py-prettyprint.c (print_string_repr): Remove #if.
11878         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11879
11880 2019-03-05  Tom Tromey  <tromey@adacore.com>
11881
11882         * target.c (the_dummy_target): Move later.  Change type to
11883         "dummy_target".
11884         (initialize_targets): Don't initialize the_dummy_target.
11885
11886 2019-03-05  Tom Tromey  <tromey@adacore.com>
11887
11888         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11889         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11890
11891 2019-03-05  Tom Tromey  <tromey@adacore.com>
11892
11893         * windows-nat.c (windows_nat_target::attach)
11894         (windows_nat_target::detach): Don't call gdb_flush.
11895         * valprint.c (generic_val_print, val_print, val_print_string):
11896         Don't call gdb_flush.
11897         * utils.c (defaulted_query): Don't call gdb_flush.
11898         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11899         * target.c (target_announce_detach): Don't call gdb_flush.
11900         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11901         * remote.c (extended_remote_target::attach): Don't call
11902         gdb_flush.
11903         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11904         * printcmd.c (do_examine): Don't call gdb_flush.
11905         (info_display_command): Don't call gdb_flush.
11906         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11907         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11908         * memattr.c (info_mem_command): Don't call gdb_flush.
11909         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11910         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11911         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11912         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11913         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11914         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11915         (gnu_nat_target::detach): Don't call gdb_flush.
11916         * f-valprint.c (f_val_print): Don't call gdb_flush.
11917         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11918         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11919         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11920         gdb_flush.
11921         * c-valprint.c (c_val_print): Don't call gdb_flush.
11922         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11923
11924 2019-03-05  Tom Tromey  <tromey@adacore.com>
11925
11926         * varobj.c (update_dynamic_varobj_children): Update.
11927         (install_default_visualizer): Use reset, not release.
11928         * value.c (set_internalvar): Update.
11929         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11930         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11931         ATTRIBUTE_UNUSED_RESULT.
11932
11933 2019-03-05  Tom Tromey  <tromey@adacore.com>
11934
11935         * remote.c (class scoped_remote_fd) <release>: Add
11936         ATTRIBUTE_UNUSED_RESULT.
11937
11938 2019-03-05  Tom Tromey  <tromey@adacore.com>
11939
11940         * macroexp.c (struct macro_buffer) <release>: Add
11941         ATTRIBUTE_UNUSED_RESULT.
11942
11943 2019-03-05  Tom Tromey  <tromey@adacore.com>
11944
11945         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11946         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11947         ATTRIBUTE_UNUSED_RESULT.
11948
11949 2019-03-05  Tom Tromey  <tromey@adacore.com>
11950
11951         * common/scoped_fd.h (class scoped_fd) <release>: Add
11952         ATTRIBUTE_UNUSED_RESULT.
11953
11954 2019-03-05  Tom Tromey  <tromey@adacore.com>
11955
11956         * parser-defs.h (struct parser_state) <release>: Add
11957         ATTRIBUTE_UNUSED_RESULT.
11958
11959 2019-03-05  Tom Tromey  <tromey@adacore.com>
11960
11961         * utils.h (class gdb_argv) <release>: Add
11962         ATTRIBUTE_UNUSED_RESULT.
11963         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11964
11965 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11966
11967         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11968         for-loop range, to avoid compiler warnings.
11969
11970         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11971         avoid compiler warnings about unused variables.
11972
11973         * NEWS: Mention end of support for native debugging on MS-Windows
11974         before XP.
11975
11976         PR gdb/24292
11977         * common/netstuff.c:
11978         * gdbserver/gdbreplay.c
11979         * gdbserver/remote-utils.c:
11980         * ser-tcp.c:
11981         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11982         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11983         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11984         'getaddrinfo' and 'freeaddrinfo' were not available before
11985         Windows XP, and mingw.org's MinGW headers by default define
11986         _WIN32_WINNT to 0x500.
11987
11988 2019-03-01  Gary Benson <gbenson@redhat.com>
11989
11990         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11991
11992 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11993             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11994
11995         PR gdb/8527
11996         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11997         set_sigint_trap, clear_sigint_trap.
11998
11999 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12000
12001         * target.c (target_detach): Clear the regcache and the
12002         frame cache.
12003
12004 2019-02-27  Pedro Alves  <palves@redhat.com>
12005
12006         * utils.c (set_screen_size): When we cap the height/width sizes,
12007         tweak the corresponding command variable to show "unlimited":
12008
12009 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12010             Pedro Alves  <palves@redhat.com>
12011
12012         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12013         before calling rl_set_screen_size.
12014
12015 2019-02-27  Tom Tromey  <tromey@adacore.com>
12016
12017         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12018         define.
12019         * python/py-value.c: Remove Python 2.4 workaround.
12020         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12021         workaround.
12022         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12023         Python 2.4 workaround.
12024         * python/python-internal.h: Remove Python 2.4 comment.
12025         (Py_ssize_t): Don't define.
12026         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12027         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12028         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12029         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12030         * python/python.c (do_start_initialization): Remove Python 2.4
12031         workaround.
12032         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12033         (print_children): Remove Python 2.4 workaround.
12034         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12035         workaround.
12036         (CHARBUFFERPROC_NAME): Remove.
12037         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12038         Python 2.4 workaround.
12039
12040 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12041
12042         * NEWS: Note minimum Python version.
12043
12044 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12045
12046         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12047         code from these functions.  Remove corresponding ifdefs.  Use
12048         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12049         Remove gotos and target of gotos.
12050         (infpy_search_memory): Likewise.
12051
12052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12053
12054         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12055         (hppa_gdbarch_init): Don't register deleted functions with
12056         gdbarch.
12057
12058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12059
12060         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12061         (h8300_unwind_sp): Delete.
12062         (h8300_dummy_id): Delete.
12063         (h8300_gdbarch_init): Don't register deleted functions with
12064         gdbarch.
12065
12066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12067
12068         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12069         (ft32_unwind_pc): Delete.
12070         (ft32_unwind_sp): Delete.
12071         (ft32_gdbarch_init): Don't register deleted functions with
12072         gdbarch.
12073
12074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12075
12076         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12077         (frv_unwind_pc): Delete.
12078         (frv_unwind_sp): Delete.
12079         (frv_gdbarch_init): Don't register deleted functions with
12080         gdbarch.
12081
12082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12083
12084         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12085         (riscv_unwind_pc): Delete.
12086         (riscv_unwind_sp): Delete.
12087         (riscv_gdbarch_init): Don't register deleted functions with
12088         gdbarch.
12089
12090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12091
12092         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12093         (csky_unwind_pc): Delete.
12094         (csky_unwind_sp): Delete.
12095         (csky_gdbarch_init): Don't register deleted functions with
12096         gdbarch.
12097
12098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12099
12100         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12101         (cris_unwind_pc): Delete.
12102         (cris_unwind_sp): Delete.
12103         (cris_gdbarch_init): Don't register deleted functions with
12104         gdbarch.
12105
12106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12107
12108         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12109         (bfin_unwind_pc): Delete.
12110         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12111
12112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12113
12114         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12115         (arm_unwind_pc): Delete.
12116         (arm_unwind_sp): Delete.
12117         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12118
12119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12120
12121         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12122         (arc_unwind_pc): Delete.
12123         (arc_unwind_sp): Delete.
12124         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12125
12126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12127
12128         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12129         (alpha_unwind_pc): Delete.
12130         (alpha_gdbarch_init): Don't register deleted functions with
12131         gdbarch.
12132
12133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12134
12135         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12136         (aarch64_unwind_pc): Delete.
12137         (aarch64_unwind_sp): Delete.
12138         (aarch64_gdbarch_init): Don't register deleted functions with
12139         gdbarch.
12140
12141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12142
12143         * gdbtypes.c (type_align): Don't consider static members when
12144         computing structure alignment.
12145
12146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12147
12148         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12149         return 0 for other types.
12150         * arch-utils.c (default_type_align): Always return 0.
12151         * gdbarch.h: Regenerate.
12152         * gdbarch.sh (type_align): Extend comment.
12153         * gdbtypes.c (type_align): Add additional comments, always call
12154         gdbarch_type_align before applying the default rules.
12155         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12156         generic code will then apply a suitable default.
12157         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12158         types, return 0 for other types.
12159
12160 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12161
12162         * NEWS: Create a new section for the next release branch.
12163         Rename the section of the current branch, now that it has
12164         been cut.
12165
12166 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12167
12168         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12169         * version.in: Bump version to 8.3.50.DATE-git.
12170
12171 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12172
12173         * aix-thread.c (ptid_cmp): Remove unused variable.
12174         (get_signaled_thread): Likewise.
12175         (store_regs_user_thread): Likewise.
12176         (store_regs_kernel_thread): Likewise.
12177         (fetch_regs_kernel_thread): Remove shadowed variable.
12178
12179 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12180
12181         * features/riscv/32bit-cpu.xml: Add register numbers.
12182         * features/riscv/32bit-fpu.c: Regenerate.
12183         * features/riscv/32bit-fpu.xml: Add register numbers.
12184         * features/riscv/64bit-cpu.xml: Add register numbers.
12185         * features/riscv/64bit-fpu.c: Regenerate.
12186         * features/riscv/64bit-fpu.xml: Add register numbers.
12187
12188 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12189
12190         * NEWS: Mention two argument form of gdb.Value constructor.
12191         * python/py-value.c (convert_buffer_and_type_to_value): New
12192         function.
12193         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12194         Add support for handling an optional second argument.  Call
12195         convert_buffer_and_type_to_value as appropriate.
12196         * python/python-internal.h (Py_buffer_deleter): New struct.
12197         (Py_buffer_up): New typedef.
12198
12199 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12200
12201         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12202         instead of releasing ownership.
12203
12204 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12205
12206         * dwarf2read.c (open_and_init_dwp_file): Call
12207         elf_numsections instead of bfd_count_sections to initialize
12208         dwp_file->num_sections.
12209
12210 2019-02-25  Tom Tromey  <tromey@adacore.com>
12211
12212         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12213
12214 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12215
12216         * gcore.in: Add '--readnever' option when invoking GDB.
12217
12218 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12219
12220         * MAINTAINERS: Update my email address.
12221
12222 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12223
12224         * build-id.c (build_id_to_debug_bfd_1): New function.
12225         (build_id_to_debug_bfd): Look for separate debug file in
12226         sysroot.
12227
12228 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12229
12230         * gdbarch.sh: Update the copyright year range that is placed into
12231         generated files.
12232
12233 2019-02-22  Keith Seitz  <keiths@redhat.com>
12234
12235         PR symtab/23853
12236         * linespec.c (create_sals_line_offset): Search for the default
12237         symtab's filename instead of its fullname.
12238
12239 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12240
12241         * NEWS: Update style defaults.
12242
12243 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12244
12245         * main.c (captured_main_1): Disable styling in batch mode.
12246
12247 2019-02-20  Tom Tromey  <tom@tromey.com>
12248
12249         * symtab.c (symtab_symbol_info): Fix typos.
12250
12251 2019-02-20  Tom Tromey  <tromey@adacore.com>
12252
12253         * findcmd.c (_initialize_mem_search): Use upper case for
12254         metasyntactic variables.
12255
12256 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12257
12258         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12259         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12260
12261 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12262
12263         * top.h (source_file_name): Change to std::string.
12264         * top.c (source_file_name): Likewise.
12265         (command_line_input): Adjust.
12266         * cli/cli-script.c (script_from_file): Adjust.
12267
12268 2019-02-19  Tom Tromey  <tromey@adacore.com>
12269
12270         * ravenscar-thread.c
12271         (ravenscar_thread_target::update_thread_list): Don't call
12272         ada_build_task_list.
12273         * ada-lang.h (ada_build_task_list): Don't declare.
12274         * ada-tasks.c (struct ada_tasks_inferior_data)
12275         <task_list_valid_p>: Now bool.
12276         (read_known_tasks, ada_task_list_changed)
12277         (ada_tasks_invalidate_inferior_data): Update.
12278         (read_known_tasks_array): Return bool.
12279         (read_known_tasks_list): Likewise.
12280         (read_known_tasks): Return void.
12281         (ada_build_task_list): Now static.
12282
12283 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12284
12285         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12286         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12287
12288 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12289
12290         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12291         variant for ada_tasks_pspace_data_handle and
12292         ada_tasks_inferior_data_handle.
12293         (ada_tasks_pspace_data_cleanup): New function.
12294         (ada_tasks_inferior_data_cleanup): New function.
12295
12296 2019-02-17  Tom Tromey  <tom@tromey.com>
12297
12298         * macrotab.h (macro_source_fullname): Return a std::string.
12299         * macrotab.c (macro_include, check_for_redefinition)
12300         (macro_undef, macro_lookup_definition, foreach_macro)
12301         (foreach_macro_in_scope): Update.
12302         (macro_source_fullname): Return a std::string.
12303         * macrocmd.c (show_pp_source_pos): Update.
12304
12305 2019-02-17  Tom Tromey  <tom@tromey.com>
12306
12307         * macrocmd.c (show_pp_source_pos): Style the file names.
12308
12309 2019-02-17  Tom Tromey  <tom@tromey.com>
12310
12311         PR tui/24197:
12312         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12313
12314 2019-02-17  Tom Tromey  <tom@tromey.com>
12315
12316         * ada-lang.c (user_select_syms): Use filtered printing.
12317         * utils.c (wrap_style): New global.
12318         (desired_style): Remove.
12319         (emit_style_escape): Add stream parameter.
12320         (set_output_style, reset_terminal_style, prompt_for_continue):
12321         Update.
12322         (flush_wrap_buffer): Only flush gdb_stdout.
12323         (wrap_here): Set wrap_style.
12324         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12325         treat escape sequences as a character.  Change when wrap buffer is
12326         flushed.
12327         (fputs_styled): Do not set the output style when the default is
12328         requested.
12329         * ui-style.h (struct ui_file_style) <is_default>: New method.
12330         * source.c (print_source_lines_base): Emit escape sequences in one
12331         piece.
12332
12333 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12334
12335         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12336         integers and enumeration types.
12337
12338 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12339
12340         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12341         instead of lookup_symbol_in_language
12342         (do_exact_match): New function.
12343         (ada_get_symbol_name_matcher): Return do_exact_match when
12344         doing a verbatim match.
12345
12346 2019-02-15  Tom Tromey  <tromey@adacore.com>
12347
12348         * ravenscar-thread.c (ravenscar_thread_target::resume)
12349         (ravenscar_thread_target::wait): Special case wildcard requests.
12350
12351 2019-02-15  Tom Tromey  <tromey@adacore.com>
12352
12353         * ravenscar-thread.c (base_ptid): Remove.
12354         (struct ravenscar_thread_target) <close>: New method.
12355         <m_base_ptid>: New member.
12356         <update_inferior_ptid, active_task, task_is_currently_active,
12357         runtime_initialized>: Declare methods.
12358         <ravenscar_thread_target>: Add constructor.
12359         (ravenscar_thread_target::task_is_currently_active)
12360         (ravenscar_thread_target::update_inferior_ptid)
12361         (ravenscar_runtime_initialized): Rename.  Now methods.
12362         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12363         (ravenscar_thread_target::update_thread_list): Update.
12364         (ravenscar_thread_target::active_task): Now method.
12365         (ravenscar_thread_target::store_registers)
12366         (ravenscar_thread_target::prepare_to_store)
12367         (ravenscar_thread_target::prepare_to_store)
12368         (ravenscar_thread_target::mourn_inferior): Update.
12369         (ravenscar_inferior_created): Use "new" to create target.
12370         (ravenscar_thread_target::get_ada_task_ptid): Update.
12371         (_initialize_ravenscar): Don't initialize base_ptid.
12372         (ravenscar_ops): Remove global.
12373
12374 2019-02-15  Tom Tromey  <tromey@adacore.com>
12375
12376         * target.h (push_target): Declare new overload.
12377         * target.c (push_target): New overload, taking an rvalue reference.
12378         * remote.c (remote_target::open_1): Use push_target overload.
12379         * corelow.c (core_target_open): Use push_target overload.
12380
12381 2019-02-15  Tom Tromey  <tromey@adacore.com>
12382
12383         * ravenscar-thread.c (is_ravenscar_task)
12384         (ravenscar_task_is_currently_active): Return bool.
12385         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12386         (_initialize_ravenscar): Remove "(void)".
12387         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12388         Return bool.
12389
12390 2019-02-15  Tom Tromey  <tromey@adacore.com>
12391
12392         * ravenscar-thread.c (ravenscar_runtime_initializer)
12393         (has_ravenscar_runtime, get_running_thread_id)
12394         (ravenscar_thread_target::resume): Fix indentation.
12395
12396 2019-02-15  Tom Tromey  <tromey@adacore.com>
12397
12398         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12399         from ravenscar_arch_ops.
12400         (sparc_ravenscar_ops::fetch_registers)
12401         (sparc_ravenscar_ops::store_registers): Now methods.
12402         (sparc_ravenscar_prepare_to_store): Remove.
12403         (sparc_ravenscar_ops): Redefine.
12404         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12405         methods and destructor.  Remove members.
12406         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12407         (ravenscar_thread_target::store_registers)
12408         (ravenscar_thread_target::prepare_to_store): Update.
12409         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12410         Remove.
12411         (struct ppc_ravenscar_powerpc_ops): Derive from
12412         ravenscar_arch_ops.
12413         (ppc_ravenscar_powerpc_ops::fetch_registers)
12414         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12415         (ppc_ravenscar_powerpc_ops): Redefine.
12416         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12417         (ppc_ravenscar_e500_ops::fetch_registers)
12418         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12419         (ppc_ravenscar_e500_ops): Redefine.
12420         * aarch64-ravenscar-thread.c
12421         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12422         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12423         (aarch64_ravenscar_fetch_registers)
12424         (aarch64_ravenscar_store_registers): Now methods.
12425         (aarch64_ravenscar_ops): Redefine.
12426
12427 2019-02-15  Tom Tromey  <tromey@adacore.com>
12428
12429         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12430         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12431         (ravenscar_thread_target::stopped_by_watchpoint)
12432         (ravenscar_thread_target::stopped_data_address)
12433         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12434
12435 2019-02-15  Tom Tromey  <tromey@adacore.com>
12436
12437         * ravenscar-thread.c: Fix some typos.
12438
12439 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12440             Tom Tromey  <tromey@adacore.com>
12441
12442         * ada-lang.c (ada_exception_sal): Change addr_string to a
12443         std::string.
12444         (create_ada_exception_catchpoint): Update.
12445
12446 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12447             Tom Tromey  <tromey@adacore.com>
12448
12449         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12450         (bp_location_ops): Remove.
12451         (base_breakpoint_allocate_location): Update.
12452         (free_bp_location): Update.
12453         * ada-lang.c (class ada_catchpoint_location)
12454         <ada_catchpoint_location>: Remove ops parameter.
12455         (ada_catchpoint_location_dtor): Remove.
12456         (ada_catchpoint_location_ops): Remove.
12457         (allocate_location_exception): Update.
12458         * breakpoint.h (struct bp_location_ops): Remove.
12459         (class bp_location) <bp_location>: Remove bp_location_ops
12460         parameter.
12461         <~bp_location>: Add destructor.
12462         <ops>: Remove.
12463
12464 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12465             Pedro Alves  <palves@redhat.com>
12466
12467         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12468         'PATH_MAX'.
12469
12470 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12471             Samuel Thibault  <samuel.thibault@gnu.org>
12472             Thomas Schwinge  <thomas@codesourcery.com>
12473
12474         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12475         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12476
12477 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12478
12479         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12480         (check_empty): Use "const char *".
12481
12482         * gnu-nat.c (gnu_nat_target::detach): Instead of
12483         'detach_inferior (pid)' call
12484         'detach_inferior (find_inferior_pid (pid))'.
12485
12486         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12487         'nat/fork-inferior.o'.
12488         * gnu-nat.c: #include "nat/fork-inferior.h".
12489
12490         * gnu-nat.c (gnu_nat_target::detach): Instead of
12491         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12492         * gnu-nat.h: #include "inf-child.h".
12493         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12494         'i386_gnu_nat_target::fetch_registers'.
12495         (gnu_store_registers): Rename/move to
12496         'i386_gnu_nat_target::store_registers'.
12497
12498         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12499         * gnu-nat.h (mach_thread_info): New function.
12500         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12501
12502         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12503
12504 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12505
12506         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12507
12508 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12509
12510         * windows-nat.c (windows_add_thread): Add new parameter
12511         "main_thread_p" with default value set to false.  Update
12512         function documentation as well as all callers.
12513         (windows_delete_thread): Likewise.
12514         (fake_create_process): Update call to windows_add_thread.
12515         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12516         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12517         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12518         call to windows_delete_thread.
12519
12520 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12521
12522         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12523
12524 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12525
12526         * symfile.c (find_separate_debug_file): Use canonical path of
12527         sysroot with child_path instead of gdb_sysroot if it is valid.
12528
12529 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12530
12531         * symfile.c (find_separate_debug_file): Use child_path to
12532         determine if an object file is under a sysroot.
12533
12534 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12535
12536         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12537         unittests/child-path-selftests.c.
12538         * common/pathstuff.c (child_path): New function.
12539         * common/pathstuff.h (child_path): New prototype.
12540         * unittests/child-path-selftests.c: New file.
12541
12542 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12543
12544         * symfile.c (find_separate_debug_file): Look for separate debug
12545         files in debug directories under the sysroot.
12546
12547 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12548
12549         * symtab.h (struct minimal_symbol data_p): New const method.
12550         (struct minimal_symbol text_p): Likewise.
12551         * symtab.c (output_source_filename): Use file name style
12552         to print file name.
12553         (print_symbol_info): Likewise.
12554         (print_msymbol_info): Use address style to print addresses.
12555         Use function name style to print executable text symbols.
12556         (expand_symtab_containing_pc): Use data_p.
12557         (find_pc_sect_compunit_symtab): Likewise.
12558
12559 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12560
12561         * breakpoint.c (describe_other_breakpoints): Use address style
12562         to print addresses.
12563         (say_where): Likewise.
12564
12565 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12566
12567         * ada-typeprint.c (print_func_type): Print function name
12568         style to print function name.
12569         * c-typeprint.c (c_print_type_1): Likewise.
12570
12571 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12572
12573         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12574         for execve.
12575
12576 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12577
12578         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12579         type_stack.
12580
12581 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12582
12583         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12584         TYPE_CODE_REF types.
12585
12586 2019-02-08  Jim Wilson  <jimw@sifive.com>
12587
12588         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12589         (riscv_linux_fregset): New.
12590         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12591
12592 2019-02-07  Tom Tromey  <tom@tromey.com>
12593
12594         * thread.c (thread_cancel_execution_command): Update.
12595         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12596         methods.
12597         (struct thread_fsm_ops): Remove.
12598         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12599         (thread_fsm_should_stop, thread_fsm_return_value)
12600         (thread_fsm_set_finished, thread_fsm_finished_p)
12601         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12602         Don't declare.
12603         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12604         * infrun.c (clear_proceed_status_thread)
12605         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12606         (print_stop_event): Update.
12607         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12608         Add constructor.
12609         (step_command_fsm_ops): Remove.
12610         (new_step_command_fsm): Remove.
12611         (step_1): Update.
12612         (step_command_fsm::should_stop): Rename from
12613         step_command_fsm_should_stop.
12614         (step_command_fsm::clean_up): Rename from
12615         step_command_fsm_clean_up.
12616         (step_command_fsm::do_async_reply_reason): Rename from
12617         step_command_fsm_async_reply_reason.
12618         (struct until_next_fsm): Inherit from thread_fsm.  Add
12619         constructor.
12620         (until_next_fsm_ops): Remove.
12621         (new_until_next_fsm): Remove.
12622         (until_next_fsm::should_stop): Rename from
12623         until_next_fsm_should_stop.
12624         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12625         (until_next_fsm::do_async_reply_reason): Rename from
12626         until_next_fsm_async_reply_reason.
12627         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12628         constructor.  Change type of breakpoint.
12629         (finish_command_fsm_ops): Remove.
12630         (new_finish_command_fsm): Remove.
12631         (finish_command_fsm::should_stop): Rename from
12632         finish_command_fsm_should_stop.
12633         (finish_command_fsm::clean_up): Rename from
12634         finish_command_fsm_clean_up.
12635         (finish_command_fsm::return_value): Rename from
12636         finish_command_fsm_return_value.
12637         (finish_command_fsm::do_async_reply_reason): Rename from
12638         finish_command_fsm_async_reply_reason.
12639         (finish_command): Update.
12640         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12641         Add constructor.
12642         (call_thread_fsm_ops): Remove.
12643         (call_thread_fsm::call_thread_fsm): Rename from
12644         new_call_thread_fsm.
12645         (call_thread_fsm::should_stop): Rename from
12646         call_thread_fsm_should_stop.
12647         (call_thread_fsm::should_notify_stop): Rename from
12648         call_thread_fsm_should_notify_stop.
12649         (run_inferior_call, call_function_by_hand_dummy): Update.
12650         * cli/cli-interp.c (should_print_stop_to_console): Update.
12651         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12652         Add constructor.  Change type of location_breakpoint,
12653         caller_breakpoint.
12654         (until_break_fsm_ops): Remove.
12655         (new_until_break_fsm): Remove.
12656         (until_break_fsm::should_stop): Rename from
12657         until_break_fsm_should_stop.
12658         (until_break_fsm::clean_up): Rename from
12659         until_break_fsm_clean_up.
12660         (until_break_fsm::do_async_reply_reason): Rename from
12661         until_break_fsm_async_reply_reason.
12662         (until_break_command): Update.
12663         * thread-fsm.c: Remove.
12664         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12665
12666 2019-02-07  Tom Tromey  <tom@tromey.com>
12667
12668         * yy-remap.h: Add include guard.
12669         * xtensa-tdep.h: Add include guard.
12670         * xcoffread.h: Rename include guard.
12671         * varobj-iter.h: Add include guard.
12672         * tui/tui.h: Rename include guard.
12673         * tui/tui-winsource.h: Rename include guard.
12674         * tui/tui-wingeneral.h: Rename include guard.
12675         * tui/tui-windata.h: Rename include guard.
12676         * tui/tui-win.h: Rename include guard.
12677         * tui/tui-stack.h: Rename include guard.
12678         * tui/tui-source.h: Rename include guard.
12679         * tui/tui-regs.h: Rename include guard.
12680         * tui/tui-out.h: Rename include guard.
12681         * tui/tui-layout.h: Rename include guard.
12682         * tui/tui-io.h: Rename include guard.
12683         * tui/tui-hooks.h: Rename include guard.
12684         * tui/tui-file.h: Rename include guard.
12685         * tui/tui-disasm.h: Rename include guard.
12686         * tui/tui-data.h: Rename include guard.
12687         * tui/tui-command.h: Rename include guard.
12688         * tic6x-tdep.h: Add include guard.
12689         * target/waitstatus.h: Rename include guard.
12690         * target/wait.h: Rename include guard.
12691         * target/target.h: Rename include guard.
12692         * target/resume.h: Rename include guard.
12693         * target-float.h: Rename include guard.
12694         * stabsread.h: Add include guard.
12695         * rs6000-tdep.h: Add include guard.
12696         * riscv-fbsd-tdep.h: Add include guard.
12697         * regformats/regdef.h: Rename include guard.
12698         * record.h: Rename include guard.
12699         * python/python.h: Rename include guard.
12700         * python/python-internal.h: Rename include guard.
12701         * python/py-stopevent.h: Rename include guard.
12702         * python/py-ref.h: Rename include guard.
12703         * python/py-record.h: Rename include guard.
12704         * python/py-record-full.h: Rename include guard.
12705         * python/py-record-btrace.h: Rename include guard.
12706         * python/py-instruction.h: Rename include guard.
12707         * python/py-events.h: Rename include guard.
12708         * python/py-event.h: Rename include guard.
12709         * procfs.h: Add include guard.
12710         * proc-utils.h: Add include guard.
12711         * p-lang.h: Add include guard.
12712         * or1k-tdep.h: Rename include guard.
12713         * observable.h: Rename include guard.
12714         * nto-tdep.h: Rename include guard.
12715         * nat/x86-linux.h: Rename include guard.
12716         * nat/x86-linux-dregs.h: Rename include guard.
12717         * nat/x86-gcc-cpuid.h: Add include guard.
12718         * nat/x86-dregs.h: Rename include guard.
12719         * nat/x86-cpuid.h: Rename include guard.
12720         * nat/ppc-linux.h: Rename include guard.
12721         * nat/mips-linux-watch.h: Rename include guard.
12722         * nat/linux-waitpid.h: Rename include guard.
12723         * nat/linux-ptrace.h: Rename include guard.
12724         * nat/linux-procfs.h: Rename include guard.
12725         * nat/linux-osdata.h: Rename include guard.
12726         * nat/linux-nat.h: Rename include guard.
12727         * nat/linux-namespaces.h: Rename include guard.
12728         * nat/linux-btrace.h: Rename include guard.
12729         * nat/glibc_thread_db.h: Rename include guard.
12730         * nat/gdb_thread_db.h: Rename include guard.
12731         * nat/gdb_ptrace.h: Rename include guard.
12732         * nat/fork-inferior.h: Rename include guard.
12733         * nat/amd64-linux-siginfo.h: Rename include guard.
12734         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12735         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12736         * nat/aarch64-linux.h: Rename include guard.
12737         * nat/aarch64-linux-hw-point.h: Rename include guard.
12738         * mn10300-tdep.h: Add include guard.
12739         * mips-linux-tdep.h: Add include guard.
12740         * mi/mi-parse.h: Rename include guard.
12741         * mi/mi-out.h: Rename include guard.
12742         * mi/mi-main.h: Rename include guard.
12743         * mi/mi-interp.h: Rename include guard.
12744         * mi/mi-getopt.h: Rename include guard.
12745         * mi/mi-console.h: Rename include guard.
12746         * mi/mi-common.h: Rename include guard.
12747         * mi/mi-cmds.h: Rename include guard.
12748         * mi/mi-cmd-break.h: Rename include guard.
12749         * m2-lang.h: Add include guard.
12750         * location.h: Rename include guard.
12751         * linux-record.h: Rename include guard.
12752         * linux-nat.h: Add include guard.
12753         * linux-fork.h: Add include guard.
12754         * i386-darwin-tdep.h: Rename include guard.
12755         * hppa-linux-offsets.h: Add include guard.
12756         * guile/guile.h: Rename include guard.
12757         * guile/guile-internal.h: Rename include guard.
12758         * gnu-nat.h: Rename include guard.
12759         * gdb-stabs.h: Rename include guard.
12760         * frv-tdep.h: Add include guard.
12761         * f-lang.h: Add include guard.
12762         * event-loop.h: Add include guard.
12763         * darwin-nat.h: Rename include guard.
12764         * cp-abi.h: Rename include guard.
12765         * config/sparc/nm-sol2.h: Rename include guard.
12766         * config/nm-nto.h: Rename include guard.
12767         * config/nm-linux.h: Add include guard.
12768         * config/i386/nm-i386gnu.h: Rename include guard.
12769         * config/djgpp/nl_types.h: Rename include guard.
12770         * config/djgpp/langinfo.h: Rename include guard.
12771         * compile/gcc-cp-plugin.h: Add include guard.
12772         * compile/gcc-c-plugin.h: Add include guard.
12773         * compile/compile.h: Rename include guard.
12774         * compile/compile-object-run.h: Rename include guard.
12775         * compile/compile-object-load.h: Rename include guard.
12776         * compile/compile-internal.h: Rename include guard.
12777         * compile/compile-cplus.h: Rename include guard.
12778         * compile/compile-c.h: Rename include guard.
12779         * common/xml-utils.h: Rename include guard.
12780         * common/x86-xstate.h: Rename include guard.
12781         * common/version.h: Rename include guard.
12782         * common/vec.h: Rename include guard.
12783         * common/tdesc.h: Rename include guard.
12784         * common/selftest.h: Rename include guard.
12785         * common/scoped_restore.h: Rename include guard.
12786         * common/scoped_mmap.h: Rename include guard.
12787         * common/scoped_fd.h: Rename include guard.
12788         * common/safe-iterator.h: Rename include guard.
12789         * common/run-time-clock.h: Rename include guard.
12790         * common/refcounted-object.h: Rename include guard.
12791         * common/queue.h: Rename include guard.
12792         * common/ptid.h: Rename include guard.
12793         * common/print-utils.h: Rename include guard.
12794         * common/preprocessor.h: Rename include guard.
12795         * common/pathstuff.h: Rename include guard.
12796         * common/observable.h: Rename include guard.
12797         * common/netstuff.h: Rename include guard.
12798         * common/job-control.h: Rename include guard.
12799         * common/host-defs.h: Rename include guard.
12800         * common/gdb_wait.h: Rename include guard.
12801         * common/gdb_vecs.h: Rename include guard.
12802         * common/gdb_unlinker.h: Rename include guard.
12803         * common/gdb_unique_ptr.h: Rename include guard.
12804         * common/gdb_tilde_expand.h: Rename include guard.
12805         * common/gdb_sys_time.h: Rename include guard.
12806         * common/gdb_string_view.h: Rename include guard.
12807         * common/gdb_splay_tree.h: Rename include guard.
12808         * common/gdb_setjmp.h: Rename include guard.
12809         * common/gdb_ref_ptr.h: Rename include guard.
12810         * common/gdb_optional.h: Rename include guard.
12811         * common/gdb_locale.h: Rename include guard.
12812         * common/gdb_assert.h: Rename include guard.
12813         * common/filtered-iterator.h: Rename include guard.
12814         * common/filestuff.h: Rename include guard.
12815         * common/fileio.h: Rename include guard.
12816         * common/environ.h: Rename include guard.
12817         * common/common-utils.h: Rename include guard.
12818         * common/common-types.h: Rename include guard.
12819         * common/common-regcache.h: Rename include guard.
12820         * common/common-inferior.h: Rename include guard.
12821         * common/common-gdbthread.h: Rename include guard.
12822         * common/common-exceptions.h: Rename include guard.
12823         * common/common-defs.h: Rename include guard.
12824         * common/common-debug.h: Rename include guard.
12825         * common/cleanups.h: Rename include guard.
12826         * common/buffer.h: Rename include guard.
12827         * common/btrace-common.h: Rename include guard.
12828         * common/break-common.h: Rename include guard.
12829         * cli/cli-utils.h: Rename include guard.
12830         * cli/cli-style.h: Rename include guard.
12831         * cli/cli-setshow.h: Rename include guard.
12832         * cli/cli-script.h: Rename include guard.
12833         * cli/cli-interp.h: Rename include guard.
12834         * cli/cli-decode.h: Rename include guard.
12835         * cli/cli-cmds.h: Rename include guard.
12836         * charset-list.h: Add include guard.
12837         * buildsym-legacy.h: Rename include guard.
12838         * bfin-tdep.h: Add include guard.
12839         * ax.h: Rename include guard.
12840         * arm-linux-tdep.h: Add include guard.
12841         * arm-fbsd-tdep.h: Add include guard.
12842         * arch/xtensa.h: Rename include guard.
12843         * arch/tic6x.h: Add include guard.
12844         * arch/i386.h: Add include guard.
12845         * arch/arm.h: Rename include guard.
12846         * arch/arm-linux.h: Rename include guard.
12847         * arch/arm-get-next-pcs.h: Rename include guard.
12848         * arch/amd64.h: Add include guard.
12849         * arch/aarch64-insn.h: Rename include guard.
12850         * arch-utils.h: Rename include guard.
12851         * annotate.h: Add include guard.
12852         * amd64-darwin-tdep.h: Rename include guard.
12853         * aarch64-linux-tdep.h: Add include guard.
12854         * aarch64-fbsd-tdep.h: Add include guard.
12855         * aarch32-linux-nat.h: Add include guard.
12856
12857 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12858
12859         * macrotab.c (macro_define_internal): New function that
12860         factorizes macro_define_object_internal and macro_define_function
12861         code.
12862         (macro_define_object_internal): Use macro_define_internal.
12863         (macro_define_function): Likewise.
12864
12865 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12866
12867         * macrocmd.c (extract_identifier): Return
12868         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12869         callers.
12870
12871 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12872
12873         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12874
12875 2019-02-05  Tom Tromey  <tom@tromey.com>
12876
12877         * target.c (target_stack::unpush): Move assertion earlier.
12878
12879 2019-01-30  Tom Tromey  <tom@tromey.com>
12880
12881         PR python/23615:
12882         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12883         (gdbpy_parse_and_eval): Likewise.
12884         * python/python-internal.h (gdbpy_allow_threads): New class.
12885
12886 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12887
12888         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12889         (aarch64_fbsd_fpregmap): Move earlier.
12890         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12891         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12892         instead of individual calls to trad_frame_set_reg_addr.
12893         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12894         earlier.
12895         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12896         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12897         instead of individual calls to trad_frame_set_reg_addr.
12898
12899 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12900
12901         * CONTRIBUTE: Replace contribution list with wiki link.
12902
12903 2019-01-25  Tom Tromey  <tom@tromey.com>
12904
12905         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12906
12907 2019-01-25  Tom Tromey  <tom@tromey.com>
12908
12909         * xtensa-linux-nat.c: Fix common/ includes.
12910         * xml-support.h: Fix common/ includes.
12911         * xml-support.c: Fix common/ includes.
12912         * x86-linux-nat.c: Fix common/ includes.
12913         * windows-nat.c: Fix common/ includes.
12914         * varobj.h: Fix common/ includes.
12915         * varobj.c: Fix common/ includes.
12916         * value.c: Fix common/ includes.
12917         * valops.c: Fix common/ includes.
12918         * utils.c: Fix common/ includes.
12919         * unittests/xml-utils-selftests.c: Fix common/ includes.
12920         * unittests/utils-selftests.c: Fix common/ includes.
12921         * unittests/unpack-selftests.c: Fix common/ includes.
12922         * unittests/tracepoint-selftests.c: Fix common/ includes.
12923         * unittests/style-selftests.c: Fix common/ includes.
12924         * unittests/string_view-selftests.c: Fix common/ includes.
12925         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12926         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12927         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12928         * unittests/rsp-low-selftests.c: Fix common/ includes.
12929         * unittests/parse-connection-spec-selftests.c: Fix common/
12930         includes.
12931         * unittests/optional-selftests.c: Fix common/ includes.
12932         * unittests/offset-type-selftests.c: Fix common/ includes.
12933         * unittests/observable-selftests.c: Fix common/ includes.
12934         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12935         * unittests/memrange-selftests.c: Fix common/ includes.
12936         * unittests/memory-map-selftests.c: Fix common/ includes.
12937         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12938         * unittests/function-view-selftests.c: Fix common/ includes.
12939         * unittests/environ-selftests.c: Fix common/ includes.
12940         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12941         * unittests/common-utils-selftests.c: Fix common/ includes.
12942         * unittests/cli-utils-selftests.c: Fix common/ includes.
12943         * unittests/array-view-selftests.c: Fix common/ includes.
12944         * ui-file.c: Fix common/ includes.
12945         * tui/tui-io.c: Fix common/ includes.
12946         * tracepoint.h: Fix common/ includes.
12947         * tracepoint.c: Fix common/ includes.
12948         * tracefile-tfile.c: Fix common/ includes.
12949         * top.h: Fix common/ includes.
12950         * top.c: Fix common/ includes.
12951         * thread.c: Fix common/ includes.
12952         * target/waitstatus.h: Fix common/ includes.
12953         * target/waitstatus.c: Fix common/ includes.
12954         * target.h: Fix common/ includes.
12955         * target.c: Fix common/ includes.
12956         * target-memory.c: Fix common/ includes.
12957         * target-descriptions.c: Fix common/ includes.
12958         * symtab.h: Fix common/ includes.
12959         * symfile.c: Fix common/ includes.
12960         * stap-probe.c: Fix common/ includes.
12961         * spu-linux-nat.c: Fix common/ includes.
12962         * sparc-nat.c: Fix common/ includes.
12963         * source.c: Fix common/ includes.
12964         * solib.c: Fix common/ includes.
12965         * solib-target.c: Fix common/ includes.
12966         * ser-unix.c: Fix common/ includes.
12967         * ser-tcp.c: Fix common/ includes.
12968         * ser-pipe.c: Fix common/ includes.
12969         * ser-base.c: Fix common/ includes.
12970         * selftest-arch.c: Fix common/ includes.
12971         * s12z-tdep.c: Fix common/ includes.
12972         * rust-exp.y: Fix common/ includes.
12973         * rs6000-aix-tdep.c: Fix common/ includes.
12974         * riscv-tdep.c: Fix common/ includes.
12975         * remote.c: Fix common/ includes.
12976         * remote-notif.h: Fix common/ includes.
12977         * remote-fileio.h: Fix common/ includes.
12978         * remote-fileio.c: Fix common/ includes.
12979         * regcache.h: Fix common/ includes.
12980         * regcache.c: Fix common/ includes.
12981         * record-btrace.c: Fix common/ includes.
12982         * python/python.c: Fix common/ includes.
12983         * python/py-type.c: Fix common/ includes.
12984         * python/py-inferior.c: Fix common/ includes.
12985         * progspace.h: Fix common/ includes.
12986         * producer.c: Fix common/ includes.
12987         * procfs.c: Fix common/ includes.
12988         * proc-api.c: Fix common/ includes.
12989         * printcmd.c: Fix common/ includes.
12990         * ppc-linux-nat.c: Fix common/ includes.
12991         * parser-defs.h: Fix common/ includes.
12992         * osdata.c: Fix common/ includes.
12993         * obsd-nat.c: Fix common/ includes.
12994         * nat/x86-linux.c: Fix common/ includes.
12995         * nat/x86-linux-dregs.c: Fix common/ includes.
12996         * nat/x86-dregs.h: Fix common/ includes.
12997         * nat/x86-dregs.c: Fix common/ includes.
12998         * nat/ppc-linux.c: Fix common/ includes.
12999         * nat/mips-linux-watch.h: Fix common/ includes.
13000         * nat/mips-linux-watch.c: Fix common/ includes.
13001         * nat/linux-waitpid.c: Fix common/ includes.
13002         * nat/linux-ptrace.h: Fix common/ includes.
13003         * nat/linux-ptrace.c: Fix common/ includes.
13004         * nat/linux-procfs.c: Fix common/ includes.
13005         * nat/linux-personality.c: Fix common/ includes.
13006         * nat/linux-osdata.c: Fix common/ includes.
13007         * nat/linux-namespaces.c: Fix common/ includes.
13008         * nat/linux-btrace.h: Fix common/ includes.
13009         * nat/linux-btrace.c: Fix common/ includes.
13010         * nat/fork-inferior.c: Fix common/ includes.
13011         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13012         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13013         * nat/aarch64-linux.c: Fix common/ includes.
13014         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13015         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13016         * namespace.h: Fix common/ includes.
13017         * mips-linux-tdep.c: Fix common/ includes.
13018         * minsyms.c: Fix common/ includes.
13019         * mi/mi-parse.h: Fix common/ includes.
13020         * mi/mi-main.c: Fix common/ includes.
13021         * mi/mi-cmd-env.c: Fix common/ includes.
13022         * memrange.h: Fix common/ includes.
13023         * memattr.c: Fix common/ includes.
13024         * maint.h: Fix common/ includes.
13025         * maint.c: Fix common/ includes.
13026         * main.c: Fix common/ includes.
13027         * machoread.c: Fix common/ includes.
13028         * location.c: Fix common/ includes.
13029         * linux-thread-db.c: Fix common/ includes.
13030         * linux-nat.c: Fix common/ includes.
13031         * linux-fork.c: Fix common/ includes.
13032         * inline-frame.c: Fix common/ includes.
13033         * infrun.c: Fix common/ includes.
13034         * inflow.c: Fix common/ includes.
13035         * inferior.h: Fix common/ includes.
13036         * inferior.c: Fix common/ includes.
13037         * infcmd.c: Fix common/ includes.
13038         * inf-ptrace.c: Fix common/ includes.
13039         * inf-child.c: Fix common/ includes.
13040         * ia64-linux-nat.c: Fix common/ includes.
13041         * i387-tdep.c: Fix common/ includes.
13042         * i386-tdep.c: Fix common/ includes.
13043         * i386-linux-tdep.c: Fix common/ includes.
13044         * i386-linux-nat.c: Fix common/ includes.
13045         * i386-go32-tdep.c: Fix common/ includes.
13046         * i386-fbsd-tdep.c: Fix common/ includes.
13047         * i386-fbsd-nat.c: Fix common/ includes.
13048         * guile/scm-type.c: Fix common/ includes.
13049         * guile/guile.c: Fix common/ includes.
13050         * go32-nat.c: Fix common/ includes.
13051         * gnu-nat.c: Fix common/ includes.
13052         * gdbthread.h: Fix common/ includes.
13053         * gdbarch-selftests.c: Fix common/ includes.
13054         * gdb_usleep.c: Fix common/ includes.
13055         * gdb_select.h: Fix common/ includes.
13056         * gdb_bfd.c: Fix common/ includes.
13057         * gcore.c: Fix common/ includes.
13058         * fork-child.c: Fix common/ includes.
13059         * findvar.c: Fix common/ includes.
13060         * fbsd-nat.c: Fix common/ includes.
13061         * event-top.c: Fix common/ includes.
13062         * event-loop.c: Fix common/ includes.
13063         * dwarf2read.c: Fix common/ includes.
13064         * dwarf2loc.c: Fix common/ includes.
13065         * dwarf2-frame.c: Fix common/ includes.
13066         * dwarf-index-cache.c: Fix common/ includes.
13067         * dtrace-probe.c: Fix common/ includes.
13068         * disasm-selftests.c: Fix common/ includes.
13069         * defs.h: Fix common/ includes.
13070         * csky-tdep.c: Fix common/ includes.
13071         * cp-valprint.c: Fix common/ includes.
13072         * cp-support.h: Fix common/ includes.
13073         * cp-support.c: Fix common/ includes.
13074         * corelow.c: Fix common/ includes.
13075         * completer.h: Fix common/ includes.
13076         * completer.c: Fix common/ includes.
13077         * compile/compile.c: Fix common/ includes.
13078         * compile/compile-loc2c.c: Fix common/ includes.
13079         * compile/compile-cplus-types.c: Fix common/ includes.
13080         * compile/compile-cplus-symbols.c: Fix common/ includes.
13081         * command.h: Fix common/ includes.
13082         * cli/cli-dump.c: Fix common/ includes.
13083         * cli/cli-cmds.c: Fix common/ includes.
13084         * charset.c: Fix common/ includes.
13085         * build-id.c: Fix common/ includes.
13086         * btrace.h: Fix common/ includes.
13087         * btrace.c: Fix common/ includes.
13088         * breakpoint.h: Fix common/ includes.
13089         * breakpoint.c: Fix common/ includes.
13090         * ax.h:
13091         (enum agent_op): Fix common/ includes.
13092         * ax-general.c (struct aop_map): Fix common/ includes.
13093         * ax-gdb.c: Fix common/ includes.
13094         * auxv.c: Fix common/ includes.
13095         * auto-load.c: Fix common/ includes.
13096         * arm-tdep.c: Fix common/ includes.
13097         * arch/riscv.c: Fix common/ includes.
13098         * arch/ppc-linux-common.c: Fix common/ includes.
13099         * arch/i386.c: Fix common/ includes.
13100         * arch/arm.c: Fix common/ includes.
13101         * arch/arm-linux.c: Fix common/ includes.
13102         * arch/arm-get-next-pcs.c: Fix common/ includes.
13103         * arch/amd64.c: Fix common/ includes.
13104         * arch/aarch64.c: Fix common/ includes.
13105         * arch/aarch64-insn.c: Fix common/ includes.
13106         * arch-utils.c: Fix common/ includes.
13107         * amd64-windows-tdep.c: Fix common/ includes.
13108         * amd64-tdep.c: Fix common/ includes.
13109         * amd64-sol2-tdep.c: Fix common/ includes.
13110         * amd64-obsd-tdep.c: Fix common/ includes.
13111         * amd64-nbsd-tdep.c: Fix common/ includes.
13112         * amd64-linux-tdep.c: Fix common/ includes.
13113         * amd64-linux-nat.c: Fix common/ includes.
13114         * amd64-fbsd-tdep.c: Fix common/ includes.
13115         * amd64-fbsd-nat.c: Fix common/ includes.
13116         * amd64-dicos-tdep.c: Fix common/ includes.
13117         * amd64-darwin-tdep.c: Fix common/ includes.
13118         * agent.c: Fix common/ includes.
13119         * ada-lang.h: Fix common/ includes.
13120         * ada-lang.c: Fix common/ includes.
13121         * aarch64-tdep.c: Fix common/ includes.
13122
13123 2019-01-25  Tom Tromey  <tom@tromey.com>
13124
13125         * common/create-version.sh: Use common/version.h.
13126
13127 2019-01-24  Pedro Alves  <palves@redhat.com>
13128
13129         * infrun.c (signal_stop, signal_print, signal_program)
13130         (signal_catch, signal_pass): Now arrays instead of pointers.
13131         (update_signals_program_target, do_target_resume)
13132         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13133         * linux-nat.c (linux_nat_target::pass_signals)
13134         (linux_nat_target::create_inferior, linux_nat_target::attach):
13135         Adjust.
13136         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13137         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13138         * procfs.c (procfs_target::pass_signals): Adjust.
13139         * record-full.c (record_full_target::resume): Adjust.
13140         * remote.c (remote_target::pass_signals)
13141         (remote_target::program_signals): Adjust.
13142         * target-debug.h (target_debug_print_signals): Now takes a
13143         gdb::array_view as parameter.  Adjust.
13144         * target.h (target_ops) <pass_signals, program_signals>: Replace
13145         pointer and length parameters with gdb::array_view.
13146         (target_pass_signals, target_program_signals): Likewise.
13147         * target-delegates.c: Regenerate.
13148
13149 2019-01-24  Pedro Alves  <palves@redhat.com>
13150
13151         * common/forward-scope-exit.h
13152         (forward_scope_exit::forward_scope_exit): Pass arguments to
13153         m_bind_function directly, instead of creating a std::bind and
13154         copying that.
13155
13156 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13157
13158         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13159         for static members.
13160         (pass_in_v_vfp_candidate): Likewise.
13161
13162 2019-01-23  Tom Tromey  <tom@tromey.com>
13163             Pedro Alves  <palves@redhat.com>
13164
13165         * regcache.c (class regcache_invalidator): Remove.
13166         (regcache::raw_write): Use make_scope_exit.
13167
13168 2019-01-23  Tom Tromey  <tom@tromey.com>
13169
13170         * ui-out.h (class ui_out_emit_type): Update comment.
13171
13172 2019-01-23  Tom Tromey  <tom@tromey.com>
13173
13174         * infrun.c (fetch_inferior_event): Update comment.
13175
13176 2019-01-23  Tom Tromey  <tom@tromey.com>
13177             Pedro Alves  <palves@redhat.com>
13178
13179         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13180         parameter.
13181         (fetch_inferior_event): Use SCOPE_EXIT.
13182
13183
13184 2019-01-23  Tom Tromey  <tom@tromey.com>
13185             Pedro Alves  <palves@redhat.com>
13186
13187         * infrun.c (disable_thread_events): Delete.
13188         (stop_all_threads): Use SCOPE_EXIT.
13189
13190 2019-01-23  Tom Tromey  <tom@tromey.com>
13191             Pedro Alves  <palves@redhat.com>
13192
13193         * symfile.c: Include forward-scope-exit.h.
13194         (clear_symtab_users_cleanup): Replace forward declaration with
13195         a FORWARD_SCOPE_EXIT.
13196         (syms_from_objfile_1): Use the forward_scope_exit and
13197         gdb::optional instead of cleanup_function.
13198         (reread_symbols): Use the forward_scope_exit instead of
13199         cleanup_function.
13200         (clear_symtab_users_cleanup): Remove function.
13201
13202 2019-01-23  Tom Tromey  <tom@tromey.com>
13203             Pedro Alves  <palves@redhat.com>
13204
13205         * linux-nat.c: Include scope-exit.h.
13206         (cleanup_target_stop): Remove.
13207         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13208         SCOPE_EXIT.
13209
13210 2019-01-23  Tom Tromey  <tom@tromey.com>
13211             Pedro Alves  <palves@redhat.com>
13212
13213         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13214         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13215
13216 2019-01-23  Tom Tromey  <tom@tromey.com>
13217             Andrew Burgess  <andrew.burgess@embecosm.com>
13218             Pedro Alves  <palves@redhat.com>
13219
13220         * infrun.c (fetch_inferior_event): Use scope_exit.
13221         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13222         * top.c (execute_command): Use scope_exit.
13223         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13224         * utils.c (do_bpstat_clear_actions_cleanup)
13225         (make_bpstat_clear_actions_cleanup): Remove.
13226
13227 2019-01-23  Tom Tromey  <tom@tromey.com>
13228             Pedro Alves  <palves@redhat.com>
13229
13230         * infrun.c: Include "common/scope-exit.h"
13231         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13232         (wait_for_inferior): Use SCOPE_EXIT.
13233         (fetch_inferior_event): Use scope_exit.
13234
13235 2019-01-23  Tom Tromey  <tom@tromey.com>
13236             Pedro Alves  <palves@redhat.com>
13237
13238         * breakpoint.c (create_breakpoint): Remove cleanup.
13239
13240 2019-01-23  Tom Tromey  <tom@tromey.com>
13241             Andrew Burgess  <andrew.burgess@embecosm.com>
13242             Pedro Alves  <palves@redhat.com>
13243
13244 2019-01-23  Pedro Alves  <palves@redhat.com>
13245
13246         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13247
13248 2019-01-23  Pedro Alves  <palves@redhat.com>
13249             Andrew Burgess  <andrew.burgess@embecosm.com>
13250
13251         * gdbthread.h: Include "common/forward-scope-exit.h".
13252         (scoped_finish_thread_state): Redefine custom class in terms of
13253         forward_scope_exit.
13254
13255 2019-01-23  Pedro Alves  <palves@redhat.com>
13256             Andrew Burgess  <andrew.burgess@embecosm.com>
13257
13258         * common/forward-scope-exit.h: New file.
13259
13260 2019-01-23  Pedro Alves  <palves@redhat.com>
13261             Andrew Burgess  <andrew.burgess@embecosm.com>
13262             Tom Tromey  <tom@tromey.com>
13263
13264         * common/scope-exit.h: New file.
13265
13266 2019-01-23  Pedro Alves  <palves@redhat.com>
13267
13268         * common/preprocessor.h (ESC): Rename to ...
13269         (ESC_PARENS): ... this.
13270         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13271         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13272
13273 2019-01-23  Tom Tromey  <tom@tromey.com>
13274
13275         * language.h (class scoped_switch_to_sym_language_if_auto):
13276         Initialize m_lang in both cases.
13277
13278 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13279
13280         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13281         with XCNEW.
13282
13283 2019-01-22  Tom Tromey  <tom@tromey.com>
13284
13285         * corelow.c: Do not include sys/file.h.
13286
13287 2019-01-22  Tom Tromey  <tom@tromey.com>
13288
13289         * tui/tui-wingeneral.h: Include gdb_curses.h.
13290
13291 2019-01-22  Tom Tromey  <tom@tromey.com>
13292
13293         * source-cache.h (class source_cache) <get_source_lines,
13294         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13295
13296 2019-01-22  Tom Tromey  <tom@tromey.com>
13297
13298         * remote-fileio.h (struct remote_target): Declare.
13299
13300 2019-01-22  Tom Tromey  <tom@tromey.com>
13301
13302         * python/py-arch.c: Do not include py-ref.h.
13303         * python/py-bpevent.c: Do not include py-ref.h.
13304         * python/py-cmd.c: Do not include py-ref.h.
13305         * python/py-continueevent.c: Do not include py-ref.h.
13306         * python/py-event.h: Do not include py-ref.h.
13307         * python/py-evtregistry.c: Do not include py-ref.h.
13308         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13309         * python/py-frame.c: Do not include py-ref.h.
13310         * python/py-framefilter.c: Do not include py-ref.h.
13311         * python/py-function.c: Do not include py-ref.h.
13312         * python/py-infevents.c: Do not include py-ref.h.
13313         * python/py-linetable.c: Do not include py-ref.h.
13314         * python/py-objfile.c: Do not include py-ref.h.
13315         * python/py-param.c: Do not include py-ref.h.
13316         * python/py-prettyprint.c: Do not include py-ref.h.
13317         * python/py-progspace.c: Do not include py-ref.h.
13318         * python/py-symbol.c: Do not include py-ref.h.
13319         * python/py-symtab.c: Do not include py-ref.h.
13320         * python/py-type.c: Do not include py-ref.h.
13321         * python/py-unwind.c: Do not include py-ref.h.
13322         * python/py-utils.c: Do not include py-ref.h.
13323         * python/py-value.c: Do not include py-ref.h.
13324         * python/py-varobj.c: Do not include py-ref.h.
13325         * python/py-xmethods.c: Do not include py-ref.h.
13326         * python/python.c: Do not include py-ref.h.
13327         * varobj.c: Do not include py-ref.h.
13328
13329 2019-01-22  Tom Tromey  <tom@tromey.com>
13330
13331         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13332         keyword for bcache.
13333
13334 2019-01-22  Tom Tromey  <tom@tromey.com>
13335
13336         * compile/compile-cplus-types.c: Remove a comment by #include.
13337
13338 2019-01-22  Tom Tromey  <tom@tromey.com>
13339
13340         * compile/gcc-c-plugin.h: Include compile-internal.h.
13341
13342 2019-01-22  Tom Tromey  <tom@tromey.com>
13343
13344         * stabsread.c (EXTERN): Do not define.
13345         (symnum, next_symbol_text_func, processing_gcc_compilation)
13346         (within_function, global_sym_chain, global_stabs)
13347         (previous_stab_code, this_object_header_files)
13348         (n_this_object_header_files)
13349         (n_allocated_this_object_header_files): Define.
13350         * stabsread.h (EXTERN): Never define.  Use "extern".
13351
13352 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13353
13354         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13355         history_value.
13356
13357 2019-01-21  Tom Tromey  <tom@tromey.com>
13358
13359         * ui-out.c: Fix includes.
13360         * tui/tui-source.c: Fix includes.
13361         * target.c: Fix includes.
13362         * remote.c: Fix includes.
13363         * regcache.c: Fix includes.
13364         * python/py-block.c: Fix includes.
13365         * printcmd.c: Fix includes.
13366         * or1k-tdep.c: Fix includes.
13367         * mi/mi-main.c: Fix includes.
13368         * m32r-tdep.c: Fix includes.
13369         * csky-tdep.c: Fix includes.
13370         * compile/compile-cplus-types.c: Fix includes.
13371         * cli/cli-interp.c: Fix includes.
13372
13373 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13374
13375         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13376         for padding.
13377
13378 2019-01-16  Tom Tromey  <tom@tromey.com>
13379
13380         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13381         earlier.
13382         (struct objfile) <msymbols_range>: Move from top level.
13383         <msymbols>: New method.
13384         (class objfile_msymbols): Remove.
13385         * symtab.c (default_collect_symbol_completion_matches_break_on):
13386         Update.
13387         * symmisc.c (dump_msymbols): Update.
13388         * stabsread.c (scan_file_globals): Update.
13389         * objc-lang.c (info_selectors_command, info_classes_command)
13390         (find_methods): Update.
13391         * minsyms.c (find_solib_trampoline_target): Update.
13392         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13393         * coffread.c (coff_symfile_read): Update.
13394         * ada-lang.c (ada_lookup_simple_minsym)
13395         (ada_collect_symbol_completion_matches): Update.
13396
13397 2019-01-16  Tom Tromey  <tom@tromey.com>
13398
13399         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13400         type.  Remove no-argument constructor.
13401         <iterator::operator++>: Simplify.
13402         <begin>: Update.
13403         <end>: Use minimal_symbol_count.
13404
13405 2019-01-16  Tom Tromey  <tom@tromey.com>
13406
13407         * objfiles.h (struct objfile) <psymtabs>: New method.
13408         (class objfile_psymtabs): Remove.
13409         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13410         typedef.
13411         <range>: New method.
13412         (require_partial_symbols): Change return type.
13413         * psymtab.c (require_partial_symbols)
13414         (psym_expand_symtabs_matching): Update.
13415         * mdebugread.c (parse_partial_symbols): Update.
13416         * dbxread.c (dbx_end_psymtab): Update.
13417
13418 2019-01-15  Tom Tromey  <tom@tromey.com>
13419
13420         * symtab.c (lookup_objfile_from_block)
13421         (lookup_symbol_in_objfile_symtabs)
13422         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13423         (find_line_symtab, info_sources_command)
13424         (default_collect_symbol_completion_matches_break_on)
13425         (make_source_files_completion_list): Update.
13426         * symmisc.c (print_objfile_statistics, dump_objfile)
13427         (maintenance_print_symbols, maintenance_info_symtabs)
13428         (maintenance_check_symtabs, maintenance_info_line_tables):
13429         Update.
13430         * source.c (select_source_symtab)
13431         (forget_cached_source_info_for_objfile): Update.
13432         * objfiles.h (class objfile_compunits): Remove.
13433         (struct objfile) <compunits_range>: New typedef.
13434         (compunits): New method.
13435         * objfiles.c (objfile_relocate1): Update.
13436         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13437         * maint.c (count_symtabs_and_blocks): Update.
13438         * linespec.c (iterate_over_all_matching_symtabs): Update.
13439         * cp-support.c (add_symbol_overload_list_qualified): Update.
13440         * coffread.c (coff_symtab_read): Update.
13441         * ada-lang.c (add_nonlocal_symbols)
13442         (ada_collect_symbol_completion_matches)
13443         (ada_add_global_exceptions): Update.
13444
13445 2019-01-15  Tom Tromey  <tom@tromey.com>
13446
13447         * progspace.h (program_space) <objfiles_safe_range>: New
13448         typedef.
13449         <objfiles_safe>: New method.
13450         * objfiles.h (class all_objfiles_safe): Remove.
13451         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13452         * jit.c (jit_inferior_exit_hook): Update.
13453
13454 2019-01-17  Tom Tromey  <tom@tromey.com>
13455
13456         * progspace.h (program_space) <objfiles_range>: New typedef.
13457         <objfiles>: New method.
13458         <objfiles_head>: Rename from objfiles.
13459         (object_files): Update.
13460         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13461         * guile/scm-pretty-print.c
13462         (ppscm_find_pretty_printer_from_objfiles): Update.
13463         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13464         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13465         Update.
13466         * python/py-progspace.c (pspy_get_objfiles): Update.
13467         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13468         Update.
13469         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13470         (objfpy_lookup_objfile_by_build_id): Update.
13471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13472         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13473         Update.
13474         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13475         (expand_symtab_containing_pc, lookup_objfile_from_block)
13476         (lookup_static_symbol, basic_lookup_transparent_type)
13477         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13478         (find_line_symtab, info_sources_command)
13479         (default_collect_symbol_completion_matches_break_on)
13480         (make_source_files_completion_list, find_main_name): Update.
13481         * symmisc.c (print_symbol_bcache_statistics)
13482         (print_objfile_statistics, maintenance_print_symbols)
13483         (maintenance_print_msymbols, maintenance_print_objfiles)
13484         (maintenance_info_symtabs, maintenance_check_symtabs)
13485         (maintenance_expand_symtabs, maintenance_info_line_tables):
13486         Update.
13487         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13488         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13489         (map_overlay_command, unmap_overlay_command)
13490         (simple_overlay_update, expand_symtabs_matching)
13491         (map_symbol_filenames): Update.
13492         * symfile-debug.c (set_debug_symfile): Update.
13493         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13494         Update.
13495         * source.c (select_source_symtab, forget_cached_source_info):
13496         Update.
13497         * solib.c (solib_read_symbols): Update.
13498         * solib-spu.c (append_ocl_sos): Update.
13499         * psymtab.c (maintenance_print_psymbols)
13500         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13501         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13502         * printcmd.c (info_symbol_command): Update.
13503         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13504         Update.
13505         * objfiles.h (class all_objfiles): Remove.
13506         * objfiles.c (have_partial_symbols, have_full_symbols)
13507         (have_minimal_symbols, qsort_cmp, update_section_map)
13508         (shared_objfile_contains_address_p)
13509         (default_iterate_over_objfiles_in_search_order): Update.
13510         * objc-lang.c (info_selectors_command, info_classes_command)
13511         (find_methods): Update.
13512         * minsyms.c (find_solib_trampoline_target): Update.
13513         * maint.c (maintenance_info_sections)
13514         (maintenance_translate_address, count_symtabs_and_blocks):
13515         Update.
13516         * main.c (captured_main_1): Update.
13517         * linux-thread-db.c (try_thread_db_load_from_pdir)
13518         (has_libpthread): Update.
13519         * linespec.c (iterate_over_all_matching_symtabs)
13520         (search_minsyms_for_name): Update.
13521         * jit.c (jit_find_objf_with_entry_addr): Update.
13522         * hppa-tdep.c (find_unwind_entry)
13523         (hppa_lookup_stub_minimal_symbol): Update.
13524         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13525         Update.
13526         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13527         (elf_gnu_ifunc_resolve_by_got): Update.
13528         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13529         * dwarf-index-write.c (save_gdb_index_command): Update.
13530         * cp-support.c (add_symbol_overload_list_qualified): Update.
13531         * breakpoint.c (create_overlay_event_breakpoint)
13532         (create_longjmp_master_breakpoint)
13533         (create_std_terminate_master_breakpoint)
13534         (create_exception_master_breakpoint): Update.
13535         * blockframe.c (find_pc_partial_function): Update.
13536         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13537         (ada_collect_symbol_completion_matches)
13538         (ada_add_global_exceptions): Update.
13539
13540 2019-01-17  Tom Tromey  <tom@tromey.com>
13541
13542         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13543         declare VEC.
13544         (solib_target_parse_libraries): Change return type.
13545         (library_list_start_segment, library_list_start_section)
13546         (library_list_end_library, library_list_start_library); Update.
13547         (solib_target_free_library_list): Remove.
13548         (solib_target_parse_libraries): Remove cleanup.  Change return
13549         type.
13550         (solib_target_current_sos): Update.
13551
13552 2019-01-17  Tom Tromey  <tromey@bapiya>
13553
13554         * valprint.c: Replace "the the" with "the".
13555         * symtab.c: Replace "the the" with "the".
13556         * solib.c: Replace "the the" with "the".
13557         * solib-dsbt.c: Replace "the the" with "the".
13558         * linespec.c: Replace "the the" with "the".
13559         * dwarf2loc.h: Replace "the the" with "the".
13560         * amd64-windows-tdep.c: Replace "the the" with "the".
13561         * aarch64-tdep.c: Replace "the the" with "the".
13562
13563 2019-01-16  Keith Seitz  <keiths@redhat.com>
13564
13565         PR gdb/23773
13566         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13567         <builder>: Rename to ..
13568         <m_builder>: ... this and make private.
13569         (dwarf2_cu::get_builder): New method.  Change all users of
13570         `builder' to use this method.
13571         (dwarf2_start_symtab): Move to ...
13572         (dwarf2_cu::start_symtab): ... here.  Update all callers
13573         (setup_type_unit_groups): Move to ...
13574         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13575         callers.
13576         (dwarf2_cu::reset_builder): New method.
13577         (process_full_compunit, process_full_type_unit): Use
13578         dwarf2_cu::reset_builder.
13579         (follow_die_offset): Record the ancestor CU if it is different
13580         from the followed DIE's CU.
13581         (follow_die_sig_1): Likewise.
13582
13583 2019-01-15  Tom Tromey  <tom@tromey.com>
13584
13585         * remote.c (class remote_state) <buf>: Now a char_vector.
13586         <buf_size>: Remove.
13587         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13588         parameter.
13589         (remote_target::getpkt_or_notif_sane_1)
13590         (remote_target::getpkt_sane)
13591         (remote_target::getpkt_or_notif_sane): Likewise.
13592         (class remote_target) <putpkt>: New overload.
13593         (remote_target::read_frame): Change type of "buf_p".  Remove
13594         sizeof_p parameter.
13595         (packet_ok): New overload.
13596         (packet_check_result): New overload.
13597         Update all uses.
13598
13599 2019-01-14  Tom Tromey  <tom@tromey.com>
13600
13601         * remote-notif.c (handle_notification, remote_notif_ack)
13602         (remote_notif_parse): Make "buf" const.
13603         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13604         const.
13605         (remote_notif_parse, remote_notif_ack, handle_notification):
13606         Likewise.
13607         * remote.c (remote_notif_stop_parse): Make "buf" const.
13608         (remote_target::remote_parse_stop_reply): Make "buf" const.
13609         (remote_notif_stop_ack): Make "buf" const.
13610
13611 2019-01-14  Tom Tromey  <tom@tromey.com>
13612
13613         * remote.c (remote_console_output): Make parameter const.
13614
13615 2019-01-14  Tom Tromey  <tom@tromey.com>
13616
13617         * target-debug.h (target_debug_print_signals): Constify.
13618         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13619         * procfs.c (procfs_target::pass_signals): Update.
13620         * linux-nat.c (linux_nat_target::pass_signals): Update.
13621         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13622         * target-delegates.c: Rebuild.
13623         * remote.c (remote_target::program_signals): Update.
13624         (remote_target::pass_signals): Update.
13625         * target.c (target_pass_signals): Constify argument.
13626         (target_program_signals): Likewise.
13627         * target.h (struct target_ops) <pass_signals, program_signals>:
13628         Constify argument.
13629         (target_pass_signals, target_program_signals): Constify argument.
13630
13631 2019-01-14  Tom Tromey  <tom@tromey.com>
13632
13633         PR tui/28819:
13634         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13635
13636 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13637
13638         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13639         field.
13640         * rs6000-tdep.c: Include reggroups.h.
13641         (IS_V_ALIAS_PSEUDOREG): Define.
13642         (rs6000_register_name): Return names for the "vX" aliases.
13643         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13644         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13645         aliases.  Call default_register_reggroup_p for all other
13646         pseudo-registers.
13647         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13648         New functions.
13649         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13650         Handle "vX" aliases.
13651         (v_alias_pseudo_register_collect): New function.
13652         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13653         (rs6000_gdbarch_init): Initialize "vX" aliases as
13654         pseudo-registers.  Restore registration of
13655         rs6000_pseudo_register_reggroup_p with
13656         set_tdesc_pseudo_register_reggroup_p.
13657
13658 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13659
13660         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13661         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13662         set_gdbarch_num_pseudo_regs.
13663
13664 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13665
13666         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13667         Remove arg prefixname, add do_set and do_show.
13668         Add member functions set_list and show_list.
13669         * cli/cli-style.c (class cli_style_option): Update accordingly.
13670         (style_set_list): Move to file scope.
13671         (style_show_list): Likewise.
13672         (set_style): Call help_list.
13673         (show_style): Call cmd_show_list.
13674         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13675         Update to use the new macro.
13676
13677 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13678
13679         * ada-lang.c (_initialize_ada_language): Expand the help text
13680         for the "catch exception" command.
13681
13682 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13683
13684         * symtab.c (matching_obj_sections): Initialize obj,
13685         declare it closer to its usage.
13686
13687 2019-01-10  Tom Tromey  <tom@tromey.com>
13688
13689         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13690         (basic_inf_threads_range): Remove.
13691         (inf_threads_range, inf_non_exited_threads_range)
13692         (safe_inf_threads_range): Use next_adapter.
13693
13694 2019-01-10  Keith Seitz  <keiths@redhat.com>
13695
13696         PR gdb/23712
13697         PR symtab/23010
13698         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13699         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13700
13701 2019-01-10  Keith Seitz  <keiths@redhat.com>
13702
13703         PR gdb/23712
13704         PR symtab/23010
13705         * dictionary.c (pending_to_vector): Remove.
13706         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13707         Remove _1 suffix, replacing functions of the same name.  Update
13708         all callers.
13709         (dict_create_hashed, dict_create_hashed_expandable)
13710         (dict_create_linear, dict_create_linear_expandable, dict_free)
13711         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13712         Make functions static.
13713
13714 2019-01-10  Keith Seitz  <keiths@redhat.com>
13715
13716         PR gdb/23712
13717         PR symtab/23010
13718         * dictionary.h (struct dictionary): Replace declaration with
13719         multidictionary.
13720         (dict_create_hashed, dict_create_hashed_expandable)
13721         (dict_create_linear, dict_create_linear_expandable)
13722         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13723         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13724         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13725         taking multidictionary argument.
13726         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13727         * block.h (struct block) <dict>: Change to multidictionary
13728         and rename `multidict'.
13729         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13730         symmisc.c: Update all dictionary references to multidictionary.
13731
13732 2019-01-10  Keith Seitz  <keiths@redhat.com>
13733
13734         PR gdb/23712
13735         PR symtab/23010
13736         * dictionary.c: Include unordered_map.
13737         (pending_to_vector): New function.
13738         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13739         Rewrite the non-"_1" functions to take vector instead
13740         of linked list.
13741         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13742         "new" _1 versions of the same name.
13743         (multidictionary): Define.
13744         (std::hash<enum language): New definition.
13745         (collate_pending_symbols_by_language, mdict_create_hashed)
13746         (mdict_create_hashed_expandable, mdict_create_linear)
13747         (mdict_create_linear_expandable, mdict_free)
13748         (find_language_dictionary, create_new_language_dictionary)
13749         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13750         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13751         (mdict_size, mdict_empty): New functions.
13752         * dictionary.h (mdict_iterator): Define.
13753
13754 2019-01-10  Pedro Alves  <palves@redhat.com>
13755
13756         * breakpoint.c (read_uploaded_action)
13757         (create_tracepoint_from_upload): Adjust to use
13758         gdb::unique_xmalloc_ptr.
13759         * ctf.c (ctf_write_uploaded_tp):
13760         (SET_ARRAY_FIELD): Use emplace_back.
13761         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13762         * tracefile-tfile.c (tfile_write_uploaded_tp):
13763         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13764         gdb::unique_xmalloc_ptr.
13765         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13766         at_string, cond_string, cmd_strings>: Replace char pointers
13767         with gdb::unique_xmalloc_ptr.
13768
13769 2019-01-10  Pedro Alves  <palves@redhat.com>
13770
13771         * solib-target.c (library_list_start_library): Don't xstrdup name.
13772
13773 2019-01-10  Pedro Alves  <palves@redhat.com>
13774
13775         * mdebugread.c (parse_partial_symbols): Use
13776         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13777
13778 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13779
13780         * linux-fork.c (scoped_switch_fork_info)
13781         <~scoped_switch_fork_info>: Fix incorrect variable name.
13782
13783 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13784
13785         * linux-fork.c (scoped_switch_fork_info)
13786         <scoped_switch_fork_info>: Make explicit.
13787         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13788
13789 2019-01-10  Tom Tromey  <tom@tromey.com>
13790
13791         * objfiles.h (objfile::reset_psymtabs): Update.
13792         * objfiles.c (objfile::objfile): Update.
13793         * psymtab.h (psymtab_storage::obstack): Update.
13794         (psymtab_storage::m_obstack): Use gdb::optional.
13795         (class psymtab_storage): Update comment.  Remove objfile
13796         parameter.
13797         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13798
13799 2019-01-10  Tom Tromey  <tom@tromey.com>
13800
13801         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13802         <free_psymtabs>: Now private.
13803         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13804         (allocate_psymtab): Use new method.
13805
13806 2019-01-10  Tom Tromey  <tom@tromey.com>
13807
13808         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13809         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13810         * mdebugread.c (parse_partial_symbols): Use
13811         allocate_dependencies.
13812         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13813         allocate_dependencies.
13814         (process_psymtab_comp_unit_reader)
13815         (build_type_psymtab_dependencies): Likewise.
13816         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13817
13818 2019-01-10  Tom Tromey  <tom@tromey.com>
13819
13820         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13821         PSYMBOL_SET_LANGUAGE.
13822         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13823
13824 2019-01-10  Tom Tromey  <tom@tromey.com>
13825
13826         * psymtab.h (psymtab_storage::obstack): New method.
13827         <m_obstack>: Rename from obstack; now private.
13828         * psymtab.c (psymtab_storage): Update.
13829         * dwarf2read.c (create_addrmap_from_index)
13830         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13831         Update.
13832
13833 2019-01-10  Tom Tromey  <tom@tromey.com>
13834
13835         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13836         * objfiles.h (objfile::reset_psymtabs): New method.
13837
13838 2019-01-10  Tom Tromey  <tom@tromey.com>
13839
13840         * symmisc.c (print_symbol_bcache_statistics): Update.
13841         (print_objfile_statistics): Update.
13842         * symfile.c (reread_symbols): Update.
13843         * psymtab.h (class psymtab_storage): New.
13844         * psymtab.c (psymtab_storage): New constructor.
13845         (~psymtab_storage): New destructor.
13846         (require_partial_symbols): Update.
13847         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13848         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13849         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13850         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13851         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13852         (start_psymtab_common, end_psymtab_common)
13853         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13854         (allocate_psymtab): Update.
13855         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13856         Update.
13857         (dump_psymtab_addrmap, maintenance_print_psymbols)
13858         (maintenance_check_psymtabs): Update.
13859         (class objfile_psymtabs): Move to objfiles.h.
13860         * psympriv.h (discard_psymtab): Now inline.
13861         (psymtab_discarder::psymtab_discarder): Update.
13862         (psymtab_discarder::~psymtab_discarder): Update.
13863         (ALL_OBJFILE_PSYMTABS): Rewrite.
13864         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13865         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13866         Remove fields.
13867         <partial_symtabs>: New field.
13868         (class objfile_psymtabs): Move from psymtab.h.  Update.
13869         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13870         psymbol_cache.
13871         (objfile::~objfile): Don't destroy psymbol_cache.
13872         * mdebugread.c (parse_partial_symbols): Update.
13873         * dwarf2read.c (create_addrmap_from_index)
13874         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13875         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13876         (add_partial_subprogram, dwarf2_ranges_read): Update.
13877         * dwarf-index-write.c (write_address_map)
13878         (write_one_signatured_type, recursively_write_psymbols)
13879         (class debug_names, class debug_names, write_psymtabs_to_index):
13880         Update.
13881
13882 2019-01-10  Tom Tromey  <tom@tromey.com>
13883
13884         * symtab.h (SYMBOL_SET_NAMES): Update.
13885         (symbol_set_names): Update.
13886         (MSYMBOL_SET_NAMES): Update.
13887         * symtab.c (symbol_set_names): Change argument to be an
13888         objfile_per_bfd_storage.
13889         * psymtab.c (add_psymbol_to_bcache): Update.
13890         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13891
13892 2019-01-10  Tom Tromey  <tom@tromey.com>
13893
13894         * symtab.c (create_demangled_names_hash): Change argument to be an
13895         objfile_per_bfd_storage.
13896         (symbol_set_names): Update.
13897
13898 2019-01-10  Tom Tromey  <tom@tromey.com>
13899
13900         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13901         init_psymbol_list.
13902         * psymtab.c (init_psymbol_list): Do nothing if already called.
13903         * psympriv.h (init_psymbol_list): Add comment.
13904         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13905         init_psymbol_list.
13906         * dbxread.c (dbx_symfile_read): Unconditionally call
13907         init_psymbol_list.
13908
13909 2019-01-10  Tom Tromey  <tom@tromey.com>
13910
13911         * xcoffread.c (scan_xcoff_symtab): Update.
13912         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13913         "where".
13914         * mdebugread.c (parse_partial_symbols)
13915         (handle_psymbol_enumerators): Update.
13916         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13917         * dbxread.c (read_dbx_symtab): Update.
13918         * psympriv.h (psymbol_placement): New enum.
13919         (add_psymbol_to_list): Update.
13920
13921 2019-01-10  Tom Tromey  <tom@tromey.com>
13922
13923         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13924         static_psymbols parameters.
13925         (scan_xcoff_symtab): Update.
13926         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13927         static_psymbols parameters.
13928         * psympriv.h (start_psymtab_common): Update.
13929         * mdebugread.c (parse_partial_symbols): Update.
13930         * dwarf2read.c (create_partial_symtab): Update.
13931         * dbxread.c (read_dbx_symtab): Update.
13932         (start_psymtab): Remove global_psymbols and static_psymbols
13933         parameters.
13934
13935 2019-01-10  Tom Tromey  <tom@tromey.com>
13936
13937         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13938         * psymtab.c (allocate_psymtab): Add comment.
13939         * psympriv.h (allocate_psymtab): Add comment.
13940         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13941         initializations.
13942         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13943
13944 2019-01-10  Tom Tromey  <tom@tromey.com>
13945
13946         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13947         Don't declare.
13948         * mipsread.c: Include mdebugread.h.
13949         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13950         Declare.
13951         * elfread.c: Include mdebugread.h.
13952
13953 2019-01-09  Tom Tromey  <tom@tromey.com>
13954
13955         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13956         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13957         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13958         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13959         (psym_lookup_symbol, psym_find_last_source_symtab)
13960         (psym_forget_cached_source_info, psym_print_stats)
13961         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13962         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13963         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13964         (psym_find_compunit_symtab_by_address)
13965         (maintenance_print_psymbols, maintenance_info_psymtabs)
13966         (maintenance_check_psymtabs): Use ranged for.
13967         * psymtab.h (class objfile_psymtabs): New.
13968         (require_partial_symbols): Return objfile_psymtabs.
13969         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13970
13971 2019-01-09  Tom Tromey  <tom@tromey.com>
13972
13973         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13974         (find_pc_mapped_section, list_overlays_command)
13975         (map_overlay_command, unmap_overlay_command)
13976         (simple_overlay_update): Use all_objfiles.
13977         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13978         * printcmd.c (info_symbol_command): Use all_objfiles.
13979         * objfiles.h (ALL_OBJSECTIONS): Remove.
13980         * maint.c (maintenance_translate_address): Use all_objfiles.
13981         * gcore.c (gcore_create_callback): Use all_objfiles.
13982         (objfile_find_memory_regions): Likewise.
13983
13984 2019-01-09  Tom Tromey  <tom@tromey.com>
13985
13986         * symtab.c (find_line_symtab, info_sources_command)
13987         (make_source_files_completion_list): Use objfile_compunits.
13988         * source.c (select_source_symtab): Use objfile_compunits.
13989         * objfiles.h (struct objfile): Update comment.
13990         (ALL_OBJFILES): Remove.
13991         (ALL_FILETABS): Remove.
13992         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13993         objfile_compunits.
13994
13995 2019-01-09  Tom Tromey  <tom@tromey.com>
13996
13997         * symmisc.c (print_objfile_statistics, dump_objfile)
13998         (maintenance_print_symbols): Use compunit_filetabs.
13999         * source.c (forget_cached_source_info_for_objfile): Use
14000         compunit_filetabs.
14001         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14002         (ALL_FILETABS): Use compunit_filetabs.
14003         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14004         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14005
14006 2019-01-09  Tom Tromey  <tom@tromey.com>
14007
14008         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14009         (compunit_filetabs): New.
14010         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14011         compunit_filetabs.
14012         (info_sources_command, make_source_files_completion_list): Remove
14013         declaration.
14014         * symmisc.c (print_objfile_statistics, dump_objfile)
14015         (maintenance_print_symbols): Remove declaration.
14016         (maintenance_info_symtabs): Use compunit_filetabs.
14017         (maintenance_info_line_tables): Likewise.
14018         * source.c (select_source_symtab): Change local variable name.
14019         (forget_cached_source_info_for_objfile): Remove declaration.
14020         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14021         * objfiles.c (objfile_relocate1): Remove declaration.
14022         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14023         declaration.
14024         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14025         * coffread.c (coff_symtab_read): Remove declaration.
14026         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14027         compunit_filetabs.
14028
14029 2019-01-09  Tom Tromey  <tom@tromey.com>
14030
14031         * symtab.c (lookup_objfile_from_block)
14032         (find_pc_sect_compunit_symtab, search_symbols)
14033         (default_collect_symbol_completion_matches_break_on): Use
14034         objfile_compunits.
14035         * objfiles.h (ALL_COMPUNITS): Remove.
14036         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14037         * cp-support.c (add_symbol_overload_list_qualified): Use
14038         objfile_compunits.
14039         * ada-lang.c (ada_collect_symbol_completion_matches)
14040         (ada_add_global_exceptions): Use objfile_compunits.
14041
14042 2019-01-09  Tom Tromey  <tom@tromey.com>
14043
14044         * source.c (select_source_symtab)
14045         (forget_cached_source_info_for_objfile): Remove declaration.
14046         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14047         declaration.
14048         * maint.c (count_symtabs_and_blocks): Remove declaration.
14049         * cp-support.c (add_symbol_overload_list_qualified): Remove
14050         declaration.
14051         * coffread.c (coff_symtab_read): Remove declaration.
14052         * symtab.c (lookup_symbol_in_objfile_symtabs)
14053         (basic_lookup_transparent_type_1): Use objfile_compunits.
14054         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14055         (info_sources_command, search_symbols)
14056         (default_collect_symbol_completion_matches_break_on)
14057         (make_source_files_completion_list): Remove declaration.
14058         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14059         (ada_collect_symbol_completion_matches)
14060         (ada_add_global_exceptions): Remove declaration.
14061         * linespec.c (iterate_over_all_matching_symtabs): Use
14062         objfile_compunits.
14063         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14064         (class objfile_compunits): New.
14065         (ALL_COMPUNITS): Use objfile_compunits.
14066         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14067         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14068         objfile_compunits.
14069         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14070
14071 2019-01-09  Tom Tromey  <tom@tromey.com>
14072
14073         * symtab.c (search_symbols)
14074         (default_collect_symbol_completion_matches_break_on): Use
14075         objfile_msymbols.
14076         * ada-lang.c (ada_lookup_simple_minsym)
14077         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14078         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14079         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14080         objfile_msymbols.
14081         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14082         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14083         * objc-lang.c (find_methods): Use objfile_msymbols.
14084         (info_selectors_command, info_classes_command): Likewise.
14085         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14086         * objfiles.h (class objfile_msymbols): New.
14087         (ALL_OBJFILE_MSYMBOLS): Remove.
14088         (ALL_MSYMBOLS): Remove.
14089
14090 2019-01-09  Tom Tromey  <tom@tromey.com>
14091
14092         * common/next-iterator.h (next_adapter): Add Iterator template
14093         parameter.
14094         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14095         (class all_objfiles_safe): New.
14096         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14097         * objfiles.c (put_objfile_before): Update comment.
14098         (add_separate_debug_objfile): Likewise.
14099         (free_all_objfiles): Use all_objfiles_safe.
14100         (objfile_purge_solibs): Likewise.
14101
14102 2019-01-09  Tom Tromey  <tom@tromey.com>
14103
14104         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14105         (expand_symtab_containing_pc, lookup_static_symbol)
14106         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14107         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14108         all_objfiles.
14109         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14110         * breakpoint.c (create_overlay_event_breakpoint)
14111         (create_longjmp_master_breakpoint)
14112         (create_std_terminate_master_breakpoint)
14113         (create_exception_master_breakpoint): Use all_objfiles.
14114         * linux-thread-db.c (try_thread_db_load_from_pdir)
14115         (has_libpthread): Use all_objfiles.
14116         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14117         * linespec.c (iterate_over_all_matching_symtabs)
14118         (search_minsyms_for_name): Use all_objfiles.
14119         * maint.c (maintenance_info_sections): Use all_objfiles.
14120         * main.c (captured_main_1): Use all_objfiles.
14121         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14122         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14123         * guile/scm-pretty-print.c
14124         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14125         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14126         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14127         (maintenance_print_msymbols): Use all_objfiles.
14128         * source.c (select_source_symtab): Use all_objfiles.
14129         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14130         * symfile.c (remove_symbol_file_command)
14131         (expand_symtabs_matching, map_symbol_filenames): Use
14132         all_objfiles.
14133         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14134         all_objfiles.
14135         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14136         * objc-lang.c (find_methods): Use all_objfiles.
14137         * objfiles.c (have_partial_symbols, have_full_symbols)
14138         (have_minimal_symbols, qsort_cmp)
14139         (default_iterate_over_objfiles_in_search_order): Use
14140         all_objfiles.
14141         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14142         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14143         (maintenance_check_psymtabs): Use all_objfiles.
14144         (ALL_PSYMTABS): Remove.
14145         * compile/compile-object-run.c (do_module_cleanup): Use
14146         all_objfiles.
14147         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14148         * cp-support.c (add_symbol_overload_list_qualified): Use
14149         all_objfiles.
14150         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14151         Use all_objfiles.
14152         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14153         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14154         all_objfiles.
14155         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14156         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14157         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14158         Uses all_objfiles.
14159         * solib.c (solib_read_symbols): Use all_objfiles
14160
14161 2019-01-09  Tom Tromey  <tom@tromey.com>
14162
14163         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14164         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14165         all_objfiles.
14166         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14167         * symmisc.c (print_symbol_bcache_statistics)
14168         (print_objfile_statistics, maintenance_print_objfiles)
14169         (maintenance_info_symtabs, maintenance_check_symtabs)
14170         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14171         all_objfiles.
14172         * source.c (forget_cached_source_info): Use all_objfiles.
14173         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14174         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14175         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14176         * objfiles.c (update_section_map): Use all_objfiles.
14177         (shared_objfile_contains_address_p): Likewise.
14178         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14179         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14180
14181 2019-01-09  Tom Tromey  <tom@tromey.com>
14182
14183         * common/next-iterator.h: New file.
14184         * objfiles.h (class all_objfiles): New.
14185         (struct objfile_iterator): New.
14186
14187 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14188
14189         * NEWS: Move the description of the changed "frame", "select-frame",
14190          and "info frame" commands to the Changed commands section.
14191
14192 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14193
14194         * gdbtypes.c (check_stub_method_group): Remove handling of old
14195         mangling schemes.
14196         * linespec.c (find_methods): Likewise.
14197         * stabsread.c (read_member_functions): Likewise.
14198         * valops.c (search_struct_method): Likewise.
14199         (value_struct_elt_for_reference): Likewise.
14200         * NEWS: Mention this change.
14201
14202 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14203
14204         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14205         print_source_lines.
14206         * source.c (print_source_lines_base): Update line number check.
14207         (print_source_lines): New function.
14208         (source_lines_range::source_lines_range): New function.
14209         * source.h (class source_lines_range): New class.
14210         (print_source_lines): New declaration.
14211
14212 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14213
14214         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14215
14216 2019-01-08  Tom Tromey  <tom@tromey.com>
14217             Simon Marchi  <simon.marchi@ericsson.com>
14218
14219         PR gdb/24060
14220         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14221         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14222         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14223         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14224         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14225         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14226
14227 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14228
14229         * source.c (select_source_symtab): Move header comment to
14230         declaration in source.h.
14231         (forget_cached_source_info_for_objfile): Likewise.
14232         (forget_cached_source_info): Likewise.
14233         (identify_source_line): Likewise.
14234         * source.h (identify_source_line): Move declaration from symtab.h
14235         and add comment from source.c
14236         (print_source_lines): Likewise.
14237         (forget_cached_source_info_for_objfile): Likewise.
14238         (forget_cached_source_info): Likewise.
14239         (select_source_symtab): Likewise.
14240         (enum print_source_lines_flag): Move definition from symtab.h.
14241         * symtab.h (identify_source_line): Move declaration to source.h.
14242         (print_source_lines): Likewise.
14243         (forget_cached_source_info_for_objfile): Likewise.
14244         (forget_cached_source_info): Likewise.
14245         (select_source_symtab): Likewise.
14246         (enum print_source_lines_flag): Move definition to source.h.
14247         * tui/tui-hooks.c: Add 'source.h' include.
14248
14249 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14250
14251         * source.c (print_source_lines_base): Handle requests to print
14252         reverse line number sequences, and guard against empty lines
14253         string.
14254
14255 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14256
14257         * source.c (print_source_lines_base): Fix skip of '\r' if next
14258         character is '\n'.
14259
14260 2019-01-06  Tom Tromey  <tom@tromey.com>
14261
14262         * c-exp.y (struct c_parse_state) <macro_original_text,
14263         expansion_obstack>: New member.
14264         (macro_original_text, expansion_obstack): Remove globals.
14265         (scan_macro_expansion, scanning_macro_expansion)
14266         (finished_macro_expansion): Update.
14267         (scan_macro_cleanup): Remove.
14268         (yylex, c_parse): Update.
14269
14270 2019-01-06  Tom Tromey  <tom@tromey.com>
14271
14272         * c-exp.y (struct c_parse_state) <strings>: New member.
14273         (operator_stoken): Update.
14274
14275 2019-01-06  Tom Tromey  <tom@tromey.com>
14276
14277         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14278         (union type_stack_elt) <typelist_val>: Now a pointer to
14279         std::vector.
14280         (type_stack_cleanup): Don't declare.
14281         (push_typelist): Update.
14282         * parse.c (pop_typelist): Return a std::vector.
14283         (push_typelist): Take a std::vector.
14284         (follow_types): Update.  Do not free args.
14285         (type_stack_cleanup): Remove.
14286         * c-exp.y (struct c_parse_state): New.
14287         (cpstate): New global.
14288         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14289         (nonempty_typelist): Update.
14290         (func_mod): Create a new vector.
14291         (c_parse): Create a c_parse_state.
14292         (check_parameter_typelist): Do not delete params.
14293         (function_method): Update.  Do not delete type_list.
14294
14295 2019-01-06  Tom Tromey  <tom@tromey.com>
14296
14297         PR gdb/28155:
14298         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14299         check_typedef.
14300         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14301         (print_return_value): Likewise.
14302
14303 2019-01-05  Tom Tromey  <tom@tromey.com>
14304
14305         * contrib/cleanup_check.py: Remove.
14306         * contrib/gcc-with-excheck: Remove.
14307         * contrib/exsummary.py: Remove.
14308         * contrib/excheck.py: Remove.
14309
14310 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14311
14312         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14313         NULL. Initialize tpprev to NULL instead of assigning it
14314         to NULL on the next statement.
14315         * windows-nat.c (windows_delete_thread): Remove check for
14316         main_thread_id before printing thread exit notifications.
14317         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14318         Remove thread ID check against main_thread_id.
14319         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14320         windows_delete_thread.
14321         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14322
14323 2019-01-04  Tom Tromey  <tom@tromey.com>
14324
14325         * compile/compile.c (_initialize_compile): Use upper case for
14326         metasyntactic variables.
14327         * symmisc.c (_initialize_symmisc): Use upper case for
14328         metasyntactic variables.
14329         * psymtab.c (_initialize_psymtab): Use upper case for
14330         metasyntactic variables.
14331         * demangle.c (demangle_command): Use upper case for metasyntactic
14332         variables.
14333         (_initialize_demangler): Likewise.
14334         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14335         variables.
14336
14337 2019-01-03  Tom Tromey  <tom@tromey.com>
14338
14339         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14340
14341 2019-01-03  Tom Tromey  <tom@tromey.com>
14342
14343         * python/py-symtab.c (salpy_str): Update.
14344         (struct salpy_sal_object) <symtab>: Now a PyObject.
14345         (salpy_dealloc): Update.
14346         (del_objfile_sal): Use gdbpy_ref.
14347
14348 2019-01-03  Tom Tromey  <tom@tromey.com>
14349
14350         * python/py-type.c (convert_field): Use new_reference.  Return
14351         gdbpy_ref.
14352         (make_fielditem): Return gdbpy_ref.
14353         (typy_fields): Update.
14354         (typy_getitem): Update.
14355         (field_name): Return gdbpy_ref.  Use new_reference.
14356         (typy_iterator_iternext): Update.
14357
14358 2019-01-03  Tom Tromey  <tom@tromey.com>
14359
14360         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14361
14362 2019-01-03  Tom Tromey  <tom@tromey.com>
14363
14364         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14365         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14366         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14367         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14368         (pspy_set_type_printers): Likewise.
14369         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14370         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14371         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14372         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14373         (objfpy_set_type_printers): Likewise.
14374
14375 2019-01-03  Tom Tromey  <tom@tromey.com>
14376
14377         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14378         (gdbpy_print_stack): Use gdbpy_err_fetch.
14379         * python/python-internal.h (class gdbpy_err_fetch): New class.
14380         (class gdbpy_enter) <m_error_type, m_error_value,
14381         m_error_traceback>: Remove.
14382         <m_error>: New member.
14383         (gdbpy_exception_to_string): Don't declare.
14384         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14385         * python/py-value.c (convert_value_from_python): Use
14386         gdbpy_err_fetch.
14387         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14388         gdbpy_exception_to_string.
14389         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14390         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14391         gdbpy_err_fetch.
14392
14393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14394
14395         * linux-nat.c (delete_lwp_cleanup): Delete.
14396         (struct lwp_deleter): New struct.
14397         (lwp_info_up): New typedef.
14398         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14399         lwp_info_up.
14400
14401 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14402
14403         * linux-fork.c (class scoped_switch_fork_info): New class.
14404         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14405
14406 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14407
14408         * valops.c (find_overload_match): Remove use of null_cleanup, and
14409         calls to do_cleanups.
14410
14411 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14412
14413         * compile/compile-cplus-types.c
14414         (compile_cplus_instance::decl_name): Handle changes to
14415         cp_func_name.
14416         * cp-support.c (cp_func_name): Update header comment, update
14417         return type.
14418         * cp-support.h (cp_func_name): Update return type in declaration.
14419         * valops.c (find_overload_match): Move temp_func local to top
14420         level of function and change its type.  Use temp_func to hold and
14421         delete temporary string obtained from cp_func_name.
14422
14423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14424
14425         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14426         gdb::char_vector, remove cleanup, and update uses of `msg`.
14427
14428 2019-01-03  Jim Wilson  <jimw@sifive.com>
14429
14430         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14431
14432 2019-01-02  Tom Tromey  <tom@tromey.com>
14433
14434         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14435         (tdesc_parse_xml): Remove cleanups.
14436         * target-descriptions.h (make_cleanup_free_target_description):
14437         Don't declare.
14438         (target_desc_deleter): New struct.
14439         (target_desc_up): New typedef.
14440         * target-descriptions.c (target_desc_deleter::operator()): Rename
14441         from free_target_description.
14442         (make_cleanup_free_target_description): Remove.
14443
14444 2019-01-02  Tom Tromey  <tom@tromey.com>
14445
14446         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14447         constructor, destructor.
14448         (linespec_parser): Remove typedef.
14449         (~linespec_parser): Rename from linespec_parser_delete.
14450         (linespec_lex_to_end, linespec_complete_label)
14451         (linespec_complete): Update.
14452         (decode_line_full): Remove cleanups.
14453         (decode_line_1): Update.
14454
14455 2019-01-02  Tom Tromey  <tom@tromey.com>
14456
14457         * python/python-internal.h (inferior_to_inferior_object): Change
14458         return type.
14459         * python/py-exitedevent.c (create_exited_event_object): Update.
14460         * python/py-inferior.c (inferior_to_inferior_object): Return
14461         gdbpy_ref.
14462         (python_new_inferior, python_inferior_deleted)
14463         (thread_to_thread_object, delete_thread_object)
14464         (build_inferior_list, gdbpy_selected_inferior): Update.
14465         * python/py-infthread.c (create_thread_object): Update.  Also fail
14466         if inferior_to_inferior_object fails.
14467
14468 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14469
14470         * inferior.h (class inferior) <displaced_step_state>: New field.
14471         * infrun.h (struct displaced_step_state): Move here from
14472         infrun.c.  Initialize fields, add constructor.
14473         <inf>: Remove field.
14474         <reset>: New method.
14475         * infrun.c (struct displaced_step_inferior_state): Move to
14476         infrun.h.
14477         (displaced_step_inferior_states): Remove.
14478         (get_displaced_stepping_state): Adust.
14479         (displaced_step_in_progress_any_inferior): Adjust.
14480         (displaced_step_in_progress_thread): Adjust.
14481         (displaced_step_in_progress): Adjust.
14482         (add_displaced_stepping_state): Remove.
14483         (get_displaced_step_closure_by_addr): Adjust.
14484         (remove_displaced_stepping_state): Remove.
14485         (infrun_inferior_exit): Call displaced_step_state.reset.
14486         (use_displaced_stepping): Don't check for NULL.
14487         (displaced_step_prepare_throw): Call
14488         get_displaced_stepping_state.
14489         (displaced_step_fixup): Don't check for NULL.
14490         (prepare_for_detach): Don't check for NULL.
14491
14492 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14493
14494         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14495          in case of call that did not complete.
14496
14497 2019-01-02  Andrey Utkin  <autkin@undo.io>
14498
14499         * symfile.c (find_separate_debug_file): Fix search of debug files for
14500         remote debuggee.
14501
14502 2019-01-02  Tom Tromey  <tom@tromey.com>
14503
14504         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14505         indentation.
14506         * python/py-frame.c (frapy_older): Remove cast.
14507         (frapy_newer): Likewise.
14508         * python/py-breakpoint.c (local_setattro): Remove cast.
14509         * python/py-arch.c (archpy_name): Remove local variable.
14510         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14511
14512 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14513
14514         * unittests/basic_string_view/element_access/char/empty.cc:
14515         Fix year range in copyright header.
14516
14517 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14518
14519         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14520         Delete.
14521         <operator==>: Update with for removed field.
14522         <hash>: Likewise.
14523         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14524         <isa_features>: ...this.
14525         <abi_features>: New field.
14526         (riscv_isa_flen): Update comment.
14527         (riscv_abi_xlen): New declaration.
14528         (riscv_abi_flen): New declaration.
14529         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14530         isa_features.
14531         (riscv_abi_xlen): New function.
14532         (riscv_isa_flen): Update to get answer from isa_features.
14533         (riscv_abi_flen): New function.
14534         (riscv_has_fp_abi): Update to get answer from abi_features.
14535         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14536         xlen and flen.
14537         (riscv_call_info) <xlen, flen>: Update comment.
14538         (riscv_call_arg_struct): Remove invalid assertions
14539         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14540         is removed.
14541         (riscv_gdbarch_init): Gather isa features and abi features
14542         separately, ensure both match on the gdbarch when reusing an old
14543         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14544         a target with 64-bit float hardware.
14545
14546 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14547
14548         * source.c (search_command_helper): Stop reverse search
14549         when line 1 has been searched.
14550
14551 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14552
14553         * record-full.c (record_full_base_target::close): Rewrite
14554         record_full_core_buf_list free logic.
14555
14556 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14557
14558         * break-catch-syscall.c (print_one_catch_syscall): xfree
14559         the last text.
14560
14561 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14562
14563         * top.c (print_gdb_version): Update Copyright year in version
14564         message.
14565
14566 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14567
14568         Update copyright year range in all GDB files.
14569
14570 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14571
14572         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14573
14574 For older changes see ChangeLog-2018.
14575 \f
14576 Local Variables:
14577 mode: change-log
14578 left-margin: 8
14579 fill-column: 74
14580 version-control: never
14581 coding: utf-8
14582 End:
14583