gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
   4         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
   5         (struct tui_source_window_base) <make_visible, refresh_window,
   6         resize>: Remove methods.
   7         <execution_info>: Remove field.
   8         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
   9         (tui_show_source_line, tui_source_window_base)
  10         (~tui_source_window_base): Update.
  11         (tui_source_window_base::resize)
  12         (tui_source_window_base::make_visible)
  13         (tui_source_window_base::refresh_window): Remove.
  14         (tui_source_window_base::update_exec_info): Update.
  15         * tui/tui-source.c (tui_source_window::set_contents): Update.
  16         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  17
  18 2019-08-16  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  21         deprecated_query_hook.
  22
  23 2019-08-16  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  26         (tui_update_source_windows_with_line): Update.
  27         * tui/tui-source.h (struct tui_source_window)
  28         <show_symtab_source>: Declare.
  29         (tui_show_symtab_source): Don't declare.
  30         * tui/tui-source.c (tui_show_symtab_source): Rename from
  31         tui_show_symtab_source.
  32
  33 2019-08-16  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.h (struct tui_source_window_base)
  36         <set_contents>: Declare.
  37         * tui/tui-winsource.c
  38         (tui_source_window_base::update_source_window_as_is): Update.
  39         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  40         Declare.
  41         (tui_set_source_content): Don't declare.
  42         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  43         tui_set_source_content.
  44         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  45         Declare.
  46         (tui_set_disassem_content): Don't declare.
  47         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  48         tui_set_disassem_content.
  49
  50 2019-08-16  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-winsource.h (struct tui_source_window_base)
  53         <update_breakpoint_info>: Declare.
  54         (tui_update_breakpoint_info): Don't declare.
  55         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  56         (tui_update_all_breakpoint_info): Update.
  57         (tui_source_window_base::update_breakpoint_info): Rename from
  58         tui_update_breakpoint_info.
  59         (tui_source_window_base::update_exec_info): Update.
  60
  61 2019-08-16  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-winsource.h (struct tui_source_window_base)
  64         <update_source_window>: Declare.
  65         (tui_update_source_window): Don't declare.
  66         * tui/tui-winsource.c
  67         (tui_source_window_base::update_source_window): Rename from
  68         tui_update_source_window.
  69         (tui_source_window_base::rerender): Update.
  70         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  71         * tui/tui-disasm.c (tui_show_disassem)
  72         (tui_show_disassem_and_update_source)
  73         (tui_disasm_window::maybe_update): Update.
  74
  75 2019-08-16  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-winsource.h (struct tui_source_window_base)
  78         <update_source_window_as_is>: Declare.
  79         (tui_update_source_window_as_is): Don't declare.
  80         * tui/tui-winsource.c (tui_update_source_window): Update
  81         (tui_source_window_base::update_source_window_as_is): Rename from
  82         tui_update_source_window_as_is.
  83         (tui_source_window_base::refill): Update.
  84         * tui/tui-source.c (tui_show_symtab_source): Update.
  85         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  86         Update.
  87
  88 2019-08-16  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-winsource.h (tui_update_source_window)
  91         (tui_update_source_window_as_is): Remove "noerror" parameter.
  92         * tui/tui-winsource.c (tui_update_source_window)
  93         (tui_update_source_window_as_is): Remove "noerror" parameter.
  94         (tui_update_source_windows_with_addr)
  95         (tui_update_source_windows_with_line)
  96         (tui_source_window_base::rerender)
  97         (tui_source_window_base::refill): Update.
  98         * tui/tui-source.h (tui_set_source_content)
  99         (tui_show_symtab_source): Remove "noerror" parameter.
 100         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 101         parameter.
 102         (tui_show_symtab_source): Likewise.
 103         (tui_source_window::maybe_update): Update.
 104         * tui/tui-disasm.c (tui_show_disassem)
 105         (tui_show_disassem_and_update_source)
 106         (tui_disasm_window::do_scroll_vertical)
 107         (tui_disasm_window::maybe_update): Update.
 108
 109 2019-08-16  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui.c (tui_is_window_visible): Update.
 112         * tui/tui-wingeneral.c (tui_make_window)
 113         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 114         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 115         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 116         (tui_set_win_height_command, parse_scrolling_args): Update.
 117         * tui/tui-source.c (tui_source_window::style_changed): Update.
 118         * tui/tui-regs.c (tui_show_registers)
 119         (tui_data_window::first_data_item_displayed)
 120         (tui_data_window::delete_data_content_windows)
 121         (tui_check_register_values, tui_reg_command): Update.
 122         * tui/tui-disasm.c (tui_show_disassem): Update.
 123         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 124         method.
 125         <is_visible>: Remove field.
 126         * tui/tui-data.c (tui_next_win, tui_prev_win)
 127         (tui_delete_invisible_windows): Update.
 128
 129 2019-08-16  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-winsource.h (struct tui_source_window_base)
 132         <m_has_locator>: Remove.
 133         * tui/tui-layout.c (show_source_disasm_command, show_data)
 134         (show_source_or_disasm_and_command): Update.
 135
 136 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 137
 138         * NEWS (Other MI changes): New subsection.
 139         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 140         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 141         * arch-utils.c (default_get_pc_address_flags): New function.
 142         * arch-utils.h (default_get_pc_address_flags): New declaration.
 143         * gdbarch.sh: Add get_pc_address_flags.
 144         * gdbarch.c: Regenerate.
 145         * gdbarch.h: Likewise.
 146         * stack.c (print_pc): New function.
 147         (print_frame_info) (print_frame): Call print_pc.
 148
 149 2019-08-16  Tom de Vries  <tdevries@suse.de>
 150
 151         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 152         print_objfile_section_info.
 153
 154 2019-08-15  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 157         calling update_cmdwin_start_line.
 158         * tui/tui-winsource.h (struct tui_source_window_base)
 159         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 160         <rerender>: Declare.
 161         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 162         Call rerender.
 163         (tui_source_window_base::set_new_height): Remove.
 164         (tui_source_window_base::rerender): Rename from
 165         do_make_visible_with_new_height.
 166         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 167         resize method.
 168         (tui_win_info::make_invisible_and_set_new_height)
 169         (tui_win_info::make_visible_with_new_height): Remove.
 170         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 171         Declare.
 172         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 173         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 174         do_make_visible_with_new_height>: Don't declare.
 175         <rerender>: Declare.
 176         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 177         set_new_height.
 178         (tui_data_window::do_make_visible_with_new_height): Remove.
 179         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 180         call tui_show_locator_content.
 181         (tui_gen_win_info::resize): Call rerender.
 182         (show_source_or_disasm_and_command): Don't call
 183         tui_show_locator_content.
 184         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 185         method.
 186         (struct tui_win_info) <rerender>: Declare.
 187         <set_new_height, make_invisible_and_set_new_height,
 188         make_visible_with_new_height>: Don't declare.
 189         * tui/tui-data.c (tui_win_list::rerender): New method.
 190         * tui/tui-command.h (struct tui_cmd_window)
 191         <do_make_visible_with_new_height>: Don't declare.
 192         * tui/tui-command.c
 193         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 194
 195 2019-08-15  Tom Tromey  <tromey@adacore.com>
 196
 197         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 198         * ada-lang.c (ada_enum_name): Likewise.
 199
 200 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 201
 202         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 203         leading underscore.
 204         (GdbOutputErrorFile): Likewise.
 205         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 206         accordingly.
 207         (execute_unwinders): Rename to have a leading underscore.
 208         (auto_load_packages): Likewise.
 209         (global scope): Adjust call to auto_load_packages accordingly.
 210         (GdbSetPythonDirectory): Likewise.
 211         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 212         instead of execute_unwinders.
 213
 214 2019-08-15  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 217         (show_data): Don't change window visibility.
 218         (tui_gen_win_info::resize): Remove special case for command
 219         window.  Use wresize, when available.
 220         (show_source_or_disasm_and_command): Don't change window
 221         visibility.
 222         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 223         <make_visible>: New method.
 224         * tui/tui-command.c (tui_cmd_window::resize): New method.
 225
 226 2019-08-15  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 229         (struct tui_source_windows): New.
 230         * tui/tui-winsource.c (tui_display_main): Update.
 231         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 232         (new_height_ok, parse_scrolling_args): Update.
 233         * tui/tui-layout.c (show_layout, show_data): Update.
 234         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 235         (tui_add_to_source_windows): Don't declare.
 236         * tui/tui-data.c (source_windows, tui_source_windows)
 237         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 238
 239 2019-08-15  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 242         Rename from reset.
 243         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 244         * tui/tui-layout.c (show_source_disasm_command, show_data):
 245         Update.
 246         (tui_gen_win_info::resize): Rename.
 247         (show_source_or_disasm_and_command): Update.
 248         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 249         reset.
 250
 251 2019-08-15  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 254         * tui/tui-interp.c (tui_interp::init): Don't call
 255         tui_initialize_static_data.
 256         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 257
 258 2019-08-15  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 261         examine tui_win_list.
 262
 263 2019-08-15  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 266         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 267         tui_clear_source_content.
 268         (tui_clear_source_content): Remove.
 269         (tui_source_window_base::do_erase_source_content): Hoist call to
 270         content.clear().
 271         * tui/tui-stack.c (tui_show_frame_info): Don't call
 272         tui_clear_source_content.
 273
 274 2019-08-15  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-winsource.h (struct tui_source_window_base)
 277         <do_erase_source_content>: New method.
 278         <erase_source_content>: New method.
 279         (tui_erase_source_content): Don't declare.
 280         * tui/tui-winsource.c (tui_clear_source_content): Update.
 281         (tui_source_window_base::do_erase_source_content): Rename from
 282         tui_erase_source_content.
 283         (tui_source_window_base::show_source_content): Update.
 284         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 285         * tui/tui-source.h (struct tui_source_window)
 286         <erase_source_content>: New method.
 287         * tui/tui-disasm.h (struct tui_disasm_window)
 288         <erase_source_content>: New method.
 289
 290 2019-08-15  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 293         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 294         constructor.
 295         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 296         * tui/tui-source.c (tui_set_source_content): Update.
 297         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 298
 299 2019-08-15  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 302         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 303         tui-source.c.
 304         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 305         Declare.
 306         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 307         method.
 308         (tui_source_window::maybe_update): Update.
 309
 310 2019-08-15  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 313         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 314         tui-disasm.c.
 315         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 316         Declare.
 317         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 318         method.
 319         (tui_disasm_window::maybe_update): Update.
 320
 321 2019-08-15  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-winsource.h (struct tui_source_window_base)
 324         <maybe_update>: Declare.
 325         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 326         method.
 327         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 328         Declare.
 329         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 330         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 331         Declare.
 332         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 333
 334 2019-08-15  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 337
 338 2019-08-15  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-wingeneral.c: Include tui-stack.h.
 341         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 342         (struct tui_locator_window): Move from tui-data.h.
 343         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 344         (tui_initialize_static_data): Move from tui-data.c.
 345         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 346         (struct tui_locator_window): Move to tui-stack.c.
 347         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 348         (tui_initialize_static_data): Move to tui-stack.c.
 349
 350 2019-08-15  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-layout.c (show_source_disasm_command)
 353         (show_source_or_disasm_and_command): Use make_visible method, not
 354         tui_make_window.
 355         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 356         Remove.
 357
 358 2019-08-15  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-wingeneral.h (tui_make_window): Update.
 361         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 362         parameter.
 363         (tui_gen_win_info::make_visible): Update.
 364         * tui/tui-regs.c (tui_data_window::display_registers_from):
 365         Update.
 366         * tui/tui-layout.c (show_source_disasm_command)
 367         (show_source_or_disasm_and_command): Update.
 368         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 369         (enum tui_box): Remove.
 370         (struct tui_win_info) <can_box>: New method.
 371         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 372         method.
 373
 374 2019-08-15  Tom de Vries  <tdevries@suse.de>
 375
 376         * linux-nat-trad.c: Include gdbarch.h.
 377
 378 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 379
 380         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 381         register sizes.
 382
 383 2019-08-14  Tom Tromey  <tromey@adacore.com>
 384
 385         * darwin-nat.c: Include gdbarch.h.
 386         * darwin-nat-info.c: Include gdbarch.h.
 387
 388 2019-08-13  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 391         Remove.
 392         * tui/tui-data.c (tui_initialize_static_data): Update.
 393
 394 2019-08-13  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-winsource.h (struct tui_exec_info_window)
 397         <~tui_exec_info_window, maybe_allocate_content, get_content,
 398         m_content>: Remove.
 399         (struct tui_source_window_base) <set_exec_info_content,
 400         show_exec_info_content>: Don't declare.
 401         * tui/tui-winsource.c
 402         (tui_exec_info_window::maybe_allocate_content): Remove.
 403         (tui_source_window_base::update_exec_info): Rename from
 404         set_exec_info_content.
 405         (tui_source_window_base::show_exec_info_content)
 406         (tui_source_window_base::update_exec_info): Remove.
 407
 408 2019-08-13  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 411         declare.
 412         * tui/tui-winsource.c (tui_update_source_window_as_is)
 413         (tui_update_source_windows_with_addr, tui_erase_source_content):
 414         Update.
 415         (tui_clear_exec_info_content): Remove.
 416
 417 2019-08-13  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 420         declare.
 421         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 422         call tui_erase_exec_info_content.
 423         (tui_clear_exec_info_content): Rename from
 424         tui_erase_exec_info_content.
 425         (tui_clear_exec_info_content): Delete.
 426
 427 2019-08-13  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-winsource.h (struct tui_source_window_base)
 430         <show_exec_info_content>: Declare.
 431         (tui_show_exec_info_content): Don't declare.
 432         * tui/tui-winsource.c
 433         (tui_source_window_base::show_exec_info_content): Rename from
 434         tui_show_exec_info_content.
 435         (tui_source_window_base::update_exec_info): Update.
 436
 437 2019-08-13  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 440         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 441         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 442         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 443         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 444         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 445         ... here.
 446
 447 2019-08-13  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.h (struct tui_source_window_base)
 450         <update_exec_info>: Declare.
 451         (tui_update_exec_info): Don't declare.
 452         * tui/tui-winsource.c (tui_update_source_window_as_is)
 453         (tui_source_window_base::refresh_all)
 454         (tui_update_all_breakpoint_info): Update.
 455         (tui_source_window_base::update_exec_info): Rename from
 456         tui_update_exec_info.
 457         * tui/tui-stack.c (tui_show_frame_info): Update.
 458
 459 2019-08-13  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.h (struct tui_source_window_base)
 462         <set_exec_info_content>: Declare.
 463         (tui_set_exec_info_content): Don't declare.
 464         * tui/tui-winsource.c
 465         (tui_source_window_base::set_exec_info_content): Rename from
 466         tui_set_exec_info_content.
 467         (tui_update_exec_info): Update.
 468
 469 2019-08-13  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-winsource.h (struct tui_source_window_base)
 472         <show_source_content>: Declare.
 473         (tui_show_source_content): Don't declare.
 474         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 475         (tui_source_window_base::show_source_content): Rename from
 476         tui_show_source_content.
 477         (tui_source_window_base::refresh_all): Update.
 478         * tui/tui-layout.c (show_source_disasm_command)
 479         (show_source_or_disasm_and_command): Update.
 480
 481 2019-08-13  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-winsource.c (tui_erase_source_content)
 484         (tui_show_source_content, tui_source_window_base::refresh_all):
 485         Update.
 486         * tui/tui-wingeneral.h
 487         (tui_check_and_display_highlight_if_needed): Don't declare.
 488         * tui/tui-wingeneral.c
 489         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 490         check_and_display_highlight_if_needed.
 491         * tui/tui-win.c (tui_rehighlight_all)
 492         (tui_win_info::make_visible_with_new_height): Update.
 493         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 494         (tui_data_window::erase_data_content)
 495         (tui_data_window::display_all_data): Update.
 496         * tui/tui-data.h (struct tui_win_info)
 497         <check_and_display_highlight_if_needed>: Declare.
 498
 499 2019-08-13  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-win.c (tui_resize_all): Call
 502         tui_delete_invisible_windows.
 503         * tui/tui-layout.c (show_layout): Call
 504         tui_delete_invisible_windows.
 505         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 506         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 507
 508 2019-08-13  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 511         tui_add_win_to_layout.
 512
 513 2019-08-13  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 516         * tui/tui-layout.c (tui_default_win_height): Now static.
 517
 518 2019-08-13  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 521         single switch.
 522         (show_source_disasm_command, show_source_or_disasm_and_command):
 523         Don't check current layout.
 524
 525 2019-08-13  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-wingeneral.c (make_all_visible): Remove.
 528         (tui_make_all_invisible): Simplify.
 529         * tui/tui-layout.c (tui_make_all_invisible): Move from
 530         tui-wingeneral.c; simplify.
 531         (show_layout): Hoist call to tui_make_all_invisible.
 532         (show_data): Don't call tui_make_all_invisible.
 533
 534 2019-08-13  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 537         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 538
 539 2019-08-13  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 542         tui-data.c.
 543         (show_source_disasm_command, show_data)
 544         (show_source_or_disasm_and_command): Don't use
 545         tui_set_current_layout_to.
 546         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 547         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 548         tui-layout.c.
 549         (tui_set_current_layout_to): Remove.
 550
 551 2019-08-13  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-layout.c (tui_set_layout): Update.
 554         * tui/tui-data.h (struct tui_layout_def): Remove.
 555         (tui_layout_def): Don't declare.
 556         * tui/tui-data.c (layout_def): Remove.
 557         (tui_layout_def): Remove.
 558
 559 2019-08-13  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-winsource.h (struct tui_source_window_base)
 562         <clear_detail>: No longer "override".
 563         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 564         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 565         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 566         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 567         Remove.
 568         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 569
 570 2019-08-13  Tom Tromey  <tromey@adacore.com>
 571
 572         * tracepoint.c: Don't include readline.h or history.h.
 573
 574 2019-08-12  Tom Tromey  <tom@tromey.com>
 575
 576         * configure: Rebuild.
 577         * configure.ac: Check for readline 7.
 578         * NEWS: Mention readline 7 requirement.
 579         * README: Update.
 580
 581 2019-08-12  Tom Tromey  <tom@tromey.com>
 582
 583         * mingw-hdep.c (gdb_select): Remove readline hack.
 584
 585 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 586
 587         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 588         when the function fails.
 589
 590 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 591
 592         * s390-tdep.c (s390_type_align): New function.
 593         (s390_gdbarch_init): Set it as type_align gdbarch method.
 594
 595 2019-08-09  Tom de Vries  <tdevries@suse.de>
 596
 597         PR gdb/24591
 598         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 599         pc_low with relocation offset.
 600
 601 2019-08-07  Tom Tromey  <tromey@adacore.com>
 602
 603         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 604         (print_frame_args): Update.
 605         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 606         Update.
 607         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 608         * frame.h (struct frame_arg): Add initializers.
 609         <error>: Now a unique_xmalloc_ptr.
 610
 611 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 612
 613         * NEWS: Expand the Pointer Authentication entry.
 614         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 615         (aarch64_frame_unmask_lr): ... to this.
 616         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 617         Call aarch64_frame_unmask_lr.
 618         * frame.c (struct frame_info): Add "masked" variable.
 619         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 620         (fprint_frame): Check for masked pc.
 621         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 622         declarations.
 623         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 624         * stack.c (print_frame): Check for masked pc.
 625
 626 2019-08-06  Tom Tromey  <tom@tromey.com>
 627
 628         * stabsread.c (patch_block_stabs, read_one_struct_field)
 629         (read_enum_type): Use obstack_strndup.
 630         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 631         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 632         * dwarf2read.c (guess_full_die_structure_name)
 633         (anonymous_struct_prefix): Use obstack_strndup.
 634         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 635         * c-exp.y (yylex): Use obstack_strndup.
 636         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 637         (write_var_or_type): Use obstack_strndup.
 638
 639 2019-08-06  Tom Tromey  <tom@tromey.com>
 640
 641         * symfile.c (reread_symbols): Use obstack_strdup.
 642         * stabsread.c (read_type): Use obstack_strdup.
 643         * gdb_obstack.h (obstack_strdup): New overload.
 644         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 645         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 646         (dwarf2_canonicalize_name): Use obstack_strdup.
 647         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 648         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 649         Use obstack_strdup.
 650
 651 2019-08-06  Tom Tromey  <tom@tromey.com>
 652
 653         * gdb_obstack.h (obstack_strdup): Define.
 654         * gdb_obstack.c (obstack_strdup): Don't define.
 655
 656 2019-08-06  Tom Tromey  <tom@tromey.com>
 657
 658         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 659         obstack_strdup.
 660         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 661         obstack_strdup.
 662         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 663         * stabsread.c (common_block_start): Use obstack_strdup.
 664         * objfiles.c (set_objfile_main_name, objfile): Use
 665         obstack_strdup.
 666         * namespace.c (add_using_directive): Use obstack_strdup.
 667         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 668         * jit.c (finalize_symtab): Use obstack_strdup.
 669         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 670         (guess_partial_die_structure_name, partial_die_info::fixup)
 671         (dwarf2_name): Use obstack_strdup.
 672         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 673         obstack_strdup.
 674         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 675         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 676         obstack_strdup.
 677         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 678
 679 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 680
 681         * unittests/help-doc-selftests.c: New file.
 682         * Makefile.in: Add the new file.
 683
 684 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 685
 686         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 687         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 688         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 689         the trailing '.' is not output, and the first character is uppercased.
 690         (print_help_for_command): Update call to print_doc_line.
 691         (print_doc_of_command): Likewise.
 692         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 693         * cli/cli-option.c (append_indented_doc): Do not append newline.
 694         (build_help_option): Append newline after first appended_indented_doc
 695         only if a second call is done.
 696         (build_help): Append 2 new lines before each option, except the first
 697         one.
 698         * compile/compile.c (_initialize_compile): Add new lines after
 699         %OPTIONS%, when not at the end of the help.
 700         Change help doc or code
 701         producing the help doc to respect the invariants.
 702         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 703         Also removed the new line after 'Options:', as all other commands
 704         do not put an empty line between 'Options:' and the first option.
 705         * printcmd.c (_initialize_printcmd): Likewise.
 706         * stack.c (_initialize_stack): Likewise.
 707         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 708         incorrectly telling COMMAND is optional.
 709         * ada-lang.c (_initialize_ada_language): Change help doc or code
 710         producing the help doc to respect the invariants.
 711         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 712         * breakpoint.c (_initialize_breakpoint): Likewise.
 713         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 714         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 715         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 716         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 717         _initialize_cli_style): Likewise.
 718         * corelow.c (core_target_info): Likewise.
 719         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 720         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 721         * filesystem.c (_initialize_filesystem): Likewise.
 722         * frame.c (_initialize_frame): Likewise.
 723         * gnu-nat.c (add_task_commands): Likewise.
 724         * infcall.c (_initialize_infcall): Likewise.
 725         * infcmd.c (_initialize_infcmd): Likewise.
 726         * interps.c (_initialize_interpreter): Likewise.
 727         * language.c (_initialize_language): Likewise.
 728         * linux-fork.c (_initialize_linux_fork): Likewise.
 729         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 730         * maint.c (_initialize_maint_cmds): Likewise.
 731         * memattr.c (_initialize_mem): Likewise.
 732         * printcmd.c (_initialize_printcmd): Likewise.
 733         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 734         _RegEx): Likewise.
 735         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 736         * record-btrace.c (_initialize_record_btrace): Likewise.
 737         * record-full.c (_initialize_record_full): Likewise.
 738         * record.c (_initialize_record): Likewise.
 739         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 740         * regcache.c (_initialize_regcache): Likewise.
 741         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 742         _initialize_remote): Likewise.
 743         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 744         * serial.c (_initialize_serial): Likewise.
 745         * skip.c (_initialize_step_skip): Likewise.
 746         * source.c (_initialize_source): Likewise.
 747         * stack.c (_initialize_stack): Likewise.
 748         * symfile.c (_initialize_symfile): Likewise.
 749         * symtab.c (_initialize_symtab): Likewise.
 750         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 751         * top.c (init_main): Likewise.
 752         * tracefile-tfile.c (tfile_target_info): Likewise.
 753         * tracepoint.c (_initialize_tracepoint): Likewise.
 754         * tui/tui-win.c (_initialize_tui_win): Likewise.
 755         * utils.c (add_internal_problem_command): Likewise.
 756         * valprint.c (value_print_option_defs): Likewise.
 757
 758 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 759
 760         PR build/24886
 761         * configure.ac: Drop enable-libmcheck support.
 762         * configure, config.in: Rebuild.
 763         * libmcheck.m4: Remove.
 764         * acinclude.m4: Don't include it.
 765         * Makefile.in: Don't distribute it.
 766         * top.c (print_gdb_configuration): Don't mention it.
 767
 768 2019-08-06  Tom Tromey  <tom@tromey.com>
 769
 770         * utils.c (set_output_style): Sometimes pass stream to
 771         emit_style_escape.
 772         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 773         * record-btrace.c (btrace_insn_history): Update.
 774         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 775         method.
 776         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 777         Update initializers.
 778         <m_uiout>: New field.
 779         <m_di>: Move lower.
 780         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 781         Remove "uiout" parameter.
 782         (dump_insns): Update.
 783         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 784         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 785
 786 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 787
 788         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 789         (error_in_psymtab_expansion): Likewise.
 790         (lookup_symbol_via_quick_fns): Likewise.
 791         (basic_lookup_transparent_type_quick): Likewise.
 792         (basic_lookup_transparent_type_1): Likewise.
 793
 794 2019-08-06  Tom Tromey  <tromey@adacore.com>
 795
 796         * source.c (last_source_error): Now bool.
 797         (print_source_lines_base): Make "noprint" bool.  Only open
 798         source file when last_source_visited changes.
 799
 800 2019-08-06  Tom Tromey  <tromey@adacore.com>
 801
 802         * annotate.c (annotate_source_line): Use g_source_cache.
 803         * source-cache.c (source_cache::get_plain_source_lines): Change
 804         parameters.  Populate m_offset_cache.
 805         (source_cache::ensure): New method.
 806         (source_cache::get_line_charpos): New method.
 807         (extract_lines): Move lower.  Change parameters.
 808         (source_cache::get_source_lines): Move lower.
 809         * source-cache.h (class source_cache): Update comment.
 810         <get_line_charpos>: New method.
 811         <get_source_lines>: Update comment.
 812         <clear>: Clear m_offset_cache.
 813         <get_plain_source_lines>: Change parameters.
 814         <ensure>: New method
 815         <m_offset_cache>: New member.
 816         * source.c (forget_cached_source_info_for_objfile): Update.
 817         (info_source_command): Use g_source_cache.
 818         (find_source_lines, open_source_file_with_line_charpos): Remove.
 819         (print_source_lines_base, search_command_helper): Use g_source_cache.
 820         * source.h (open_source_file_with_line_charpos): Don't declare.
 821         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 822         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 823         Use g_source_cache.
 824
 825 2019-08-06  Tom Tromey  <tromey@adacore.com>
 826
 827         * source-cache.c (source_cache::get_plain_source_lines):
 828         Remove "first_line" and "last_line" parameters.
 829         (source_cache::get_source_lines): Cache plain text.
 830         * source-cache.h (class source_cache)
 831         <get_plain_source_lines>: Update.
 832
 833 2019-08-06  Tom Tromey  <tromey@adacore.com>
 834
 835         * source-cache.c (extract_lines): No longer a method.
 836         Changed type of parameter.  Include final newline.
 837         (selftests::extract_lines_test): New function.
 838         (_initialize_source_cache): Likewise.
 839         * source-cache.h (class source_cache)
 840         <extract_lines>: Don't declare.
 841
 842 2019-08-06  Tom Tromey  <tromey@adacore.com>
 843
 844         * breakpoint.c (init_breakpoint_sal): Update.
 845         (breakpoint): Update.
 846         * breakpoint.h (struct breakpoint) <filter>: Now a
 847         unique_xmalloc_ptr.
 848
 849 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 850
 851         * NEWS: Mention dictionary access on blocks.
 852         * python/py-block.c (blpy_getitem): New function.
 853         (block_object_as_mapping): New struct.
 854         (block_object_type): Use new struct for tp_as_mapping field.
 855
 856 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 857
 858         * objfiles.h (objfile): Add a comment describing partial symbols.
 859
 860 2019-08-05  Tom Tromey  <tromey@adacore.com>
 861
 862         * compile/compile.c (_initialize_compile): Use _(), not N_().
 863         * thread.c (_initialize_thread): Use _(), not N_().
 864         * stack.c (_initialize_stack): Use _(), not N_().
 865         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 866
 867 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 868
 869         * dwarf2read.c (struct dw2_symtab_iterator):
 870         <want_specific_block>: Remove.
 871         <block_index>: Change type to gdb::optional.
 872         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 873         change type of BLOCK_INDEX parameter to gdb::optional.
 874         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 875         (dw2_lookup_symbol): Don't pass argument for
 876         WANT_SPECIFIC_BLOCK.
 877         (dw2_expand_symtabs_for_function): Don't pass argument for
 878         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 879         (class dw2_debug_names_iterator)
 880         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 881         parameter, change BLOCK_INDEX type to gdb::optional.
 882         <m_want_specific_block>: Remove.
 883         <m_block_index>: Change type to gdb::optional.
 884         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 885         gdb::optional.  Re-write in function of gdb::optional.
 886         (dw2_debug_names_lookup_symbol): Don't pass argument for
 887         WANT_SPECIFIC_BLOCK.
 888         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 889         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 890         BLOCK_INDEX.
 891
 892 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 893
 894         * NEWS: Mention changes to "info sources" command.
 895
 896 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 897
 898         * symtab.c (filename_partial_match_opts): New struct type.
 899         (struct output_source_filename_data): New members
 900         regexp, c_regexp, partial_match.
 901         (output_source_filename): Use new members to decide to print file.
 902         (info_sources_option_defs): New variable.
 903         (make_info_sources_options_def_group, print_info_sources_header,
 904         info_sources_command_completer):
 905         New functions.
 906         (info_sources_command): Read new optional arguments.
 907         (_initialize_symtab): Update info sources help.
 908
 909 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 910
 911         * ada-lang.c (exception_support_info_v0): Renamed from...
 912         (default_exception_support_info): ... this.  Create new
 913         definition for v1.
 914         (ada_has_this_exception_support): Look up catch_handlers_sym.
 915         (ada_exception_support_info_sniffer): Try v0 after default.
 916
 917 2019-08-01  Tom Tromey  <tromey@adacore.com>
 918
 919         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 920         gdbarch.h.
 921
 922 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 923
 924         * s12z-tdep.c: Fix include path for s12z-opc.h.
 925
 926 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 927
 928         * NEWS: Require GNU make 3.82.
 929
 930 2019-07-16  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 933         declare.
 934
 935 2019-07-30  Tom Tromey  <tromey@adacore.com>
 936
 937         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 938
 939 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 940
 941         * printcmd.c (print_address_symbolic): Print negative offsets.
 942         (build_address_symbolic): Force signed arithmetic when computing
 943         offset.
 944
 945 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 946
 947         PR/24474: Add a function to lookup static variables.
 948         * NEWS: Mention this new function.
 949         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 950         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 951         * python/python.c (python_GdbMethods): Add new function.
 952
 953 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 954
 955         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 956         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 957         (objfpy_lookup_static_symbol): New function.
 958         (objfile_object_methods): Add new functions.
 959
 960 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 961
 962         * NEWS: Mention 'set|show print frame-info'.  Mention new
 963         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 964         backtrace argument.  Mention that python frame filtering code
 965         is now consistent with what 'backtrace' command prints.
 966
 967 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 968
 969         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 970         comments.
 971         (print_frame_info_auto, print_frame_info_source_line,
 972         print_frame_info_location, print_frame_info_source_and_location,
 973         print_frame_info_location_and_address, print_frame_info_short_location):
 974         New declarations.
 975         (struct frame_print_options): New member print_frame_info.
 976         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 977         * stack.h (get_user_print_what_frame_info): New declaration.
 978         (frame_show_address): New declaration.
 979         * stack.c (print_frame_arguments_choices): New value 'presence'.
 980         (print_frame_info_auto, print_frame_info_source_line,
 981         print_frame_info_location, print_frame_info_source_and_location,
 982         print_frame_info_location_and_address, print_frame_info_short_location,
 983         print_frame_info_choices, print_frame_info_print_what): New definitions.
 984         (print_frame_args): Only print dots for args if print frame-arguments
 985         is 'presence'.
 986         (frame_print_option_defs): New element for "frame-info".
 987         (get_user_print_what_frame_info): New function.
 988         (frame_show_address): Make non static.  Move comment to stack.h.
 989         (print_frame_info_to_print_what): New function.
 990         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 991         to decide what to print.
 992         (backtrace_command_1): Handle the new print_frame_arguments_presence
 993         value.
 994         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 995         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 996         (py_print_frame): In non-mi mode, use LOCATION as default for
 997         print_what, similarly to frame information printed directly by
 998         backtrace command. Handle frame-info user option in non MI mode.
 999
1000 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1001
1002         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1003         Add case for debugging 32-bit target on 64-bit host.  Revise
1004         comment.
1005
1006 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1007
1008         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1009         instead of find_function_entry_range_from_pc.
1010
1011 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1012
1013         * stack.c (find_frame_funname): Remove code which preferred
1014         minsym over symtab sym in "certain pathological cases".
1015
1016         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1017         parameter.  Change type of "do_demangle" to bool.
1018         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1019         Pass suitable "prefer_sym_over_minsym" flag to
1020         build_address_symbolic().  Don't output "+" for negative offsets.
1021         * printcmd.c (print_address_symbolic): Update invocation of
1022         build_address_symbolic to include a "prefer_sym_over_minsym"
1023         flag.
1024         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1025         Restrict cases in which use of minimal symbol is preferred to that
1026         of a found symbol.  Update comments.
1027
1028         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1029         for entry pc when entry pc is out of range for that FDE.
1030
1031 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1032
1033         PR gdb/24839:
1034         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1035         type.
1036
1037 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1038
1039         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1040         this function's Python signature.
1041
1042
1043 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1044
1045         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1046         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1047         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1048         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1049         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1050
1051
1052 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1053
1054         * h8300-tdep.c (h8300_register_name_common): New.
1055         h8300_register_name): Use h8300_register_name_common.
1056         (h8300s_register_name): Likewise.
1057         (h8300sx_register_name): Likewise.
1058         (h8300h_register_nam): New.
1059         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1060
1061
1062 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1063
1064         * arm-tdep.c (arm_skip_cmse_entry): New function.
1065         (arm_is_sgstubs_section): New function.
1066         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1067
1068 2019-07-22  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1071         Don't self-assign.
1072
1073 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1076         type_print.
1077
1078 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1081         so that GDB doesn't match any msymbols when searching in the
1082         TYPES_DOMAIN.
1083         (print_symbol_info): Print using typedef_print or type_print based
1084         on the type of the symbol.  Add updated FIXME comment moved from...
1085         (_initialize_symtab): ... move and update FIXME comment to above.
1086
1087 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1088
1089         * NEWS: Mention adding -q option to "info types".
1090         * symtab.c (struct info_types_options): New struct.
1091         (info_types_options_defs): New variable.
1092         (make_info_types_options_def_group): New function.
1093         (info_types_command): Use gdb::option framework to parse options.
1094         (info_types_command_completer): New function.
1095         (_initialize_symtab): Extend the help text on "info types" and
1096         register command completer.
1097
1098 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1099
1100         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1101         (lookup_symbol_in_objfile): Change int to block_enum and add a
1102         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1103
1104 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1105
1106         * MAINTAINERS (Write After Approval): Add self.
1107
1108 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1111         instruction to the dummy code region.
1112
1113 2019-07-19  Tom Tromey  <tromey@adacore.com>
1114
1115         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1116         (ARGSUSED, PARAMS, __func__): Remove rules.
1117
1118 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1119
1120         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1121         * features/arm/arm-with-iwmmxt.c: Remove.
1122         * features/arm/arm-with-iwmmxt.xml: Remove.
1123         * features/arm/arm-with-m-fpa-layout.c: Remove.
1124         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1125         * features/arm/arm-with-m-vfp-d16.c: Remove.
1126         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1127         * features/arm/arm-with-m.c: Remove.
1128         * features/arm/arm-with-m.xml: Remove.
1129         * features/arm/arm-with-neon.c: Remove.
1130         * features/arm/arm-with-neon.xml: Remove.
1131         * features/arm/arm-with-vfpv2.c: Remove.
1132         * features/arm/arm-with-vfpv2.xml: Remove.
1133         * features/arm/arm-with-vfpv3.c: Remove.
1134         * features/arm/arm-with-vfpv3.xml: Remove.
1135
1136 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1139
1140 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1141
1142         * arch/aarch32.c (aarch32_create_target_description): Create
1143         target descriptions using features.
1144         * arch/arm.c (arm_create_target_description)
1145         (arm_create_mprofile_target_description): Likewise.
1146         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1147
1148 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1149
1150         * Makefile.in: Add new files.
1151         * aarch32-tdep.c: New file.
1152         * aarch32-tdep.h: New file.
1153         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1154         Call aarch32_read_description.
1155         * arch/aarch32.c: New file.
1156         * arch/aarch32.h: New file.
1157         * arch/arm.c (arm_create_target_description)
1158         (arm_create_mprofile_target_description): New function.
1159         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1160         (arm_create_target_description)
1161         (arm_create_mprofile_target_description): New declaration.
1162         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1163         read_description functions.
1164         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1165         Likewise.
1166         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1167         * arm-tdep.c (tdesc_arm_list): New variable.
1168         (arm_register_g_packet_guesses): Call create description functions.
1169         (arm_read_description) (arm_read_mprofile_description): New
1170         function.
1171         * arm-tdep.h (arm_read_description)
1172         (arm_read_mprofile_description): Add declaration.
1173         * configure.tgt: Add new files.
1174
1175 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1176
1177         * top.c (new_ui_command): Open specified terminal just once.
1178
1179 2019-07-18  Tom Tromey  <tromey@adacore.com>
1180
1181         * symtab.c (main_name): Constify return type.
1182         * symfile.c (set_initial_language): Update.
1183         * symtab.h (main_name): Constify return type.
1184
1185 2019-07-17  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-winsource.c (tui_update_source_window)
1188         (tui_update_source_window_as_is)
1189         (tui_update_source_windows_with_line): Remove return.
1190         * tui/tui-disasm.c (tui_show_disassem)
1191         (tui_show_disassem_and_update_source): Remove return.
1192         * tui/tui.c (tui_reset): Remove return.
1193         * tui/tui-wingeneral.c
1194         (tui_check_and_display_highlight_if_needed): Remove return.
1195
1196 2019-07-17  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1199
1200 2019-07-17  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-winsource.h (struct tui_exec_info_window)
1203         (struct tui_source_window_base): Move from tui-data.h.
1204         * tui/tui-winsource.c: Move many method definitions from
1205         elsewhere.  Remove "structuring" comments.
1206         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1207         (tui_source_window_base::refresh_window): Move to
1208         tui-winsource.c.
1209         * tui/tui-win.c (tui_source_window_base::refresh_all)
1210         (tui_source_window_base::update_tab_width)
1211         (tui_source_window_base::set_new_height)
1212         (tui_source_window_base::do_make_visible_with_new_height): Move to
1213         tui-winsource.c.
1214         * tui/tui-source.h: Update.
1215         * tui/tui-source.c (tui_source_window_base::reset): Move to
1216         tui-winsource.c.
1217         * tui/tui-disasm.h: Update.
1218         * tui/tui-data.h (struct tui_exec_info_window): Move to
1219         tui-winsource.h.
1220         (struct tui_source_window_base): Likewise.
1221         * tui/tui-data.c (tui_source_window_base::clear_detail)
1222         (tui_source_window_base, ~tui_source_window_base): Move to
1223         tui-winsource.c.
1224
1225 2019-07-17  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-win.c (tui_resize_all)
1228         (tui_source_window_base::update_tab_width)
1229         (tui_adjust_win_heights): Update.
1230         (tui_win_info::make_invisible_and_set_new_height): Rename from
1231         make_invisible_and_set_new_height.
1232         * tui/tui-data.h (struct tui_win_info)
1233         <make_invisible_and_set_new_height>: New method.
1234
1235 2019-07-17  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui.c: Update.
1238         * tui/tui-source.h (struct tui_source_window): Move from
1239         tui-data.h.
1240         * tui/tui-layout.c: Update.
1241         * tui/tui-disasm.c: Update.
1242         * tui/tui-data.h (struct tui_source_window): Move to
1243         tui-source.h.
1244
1245 2019-07-17  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1248         tui-data.h.
1249         * tui/tui-data.h (struct tui_disasm_window): Move to
1250         tui-disasm.h.
1251
1252 2019-07-17  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-regs.h (struct tui_data_item_window): Move from
1255         tui-data.h.
1256         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1257         * tui/tui-data.h (struct tui_data_item_window): Move to
1258         tui-regs.h.
1259         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1260
1261 2019-07-17  Tom Tromey  <tom@tromey.com>
1262
1263         * tui/tui.c: Update.
1264         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1265         (tui_cmd_window::max_height): Move to tui-command.c.
1266         * tui/tui-layout.c: Update.
1267         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1268         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1269         tui-command.c.
1270         * tui/tui-command.h (struct tui_cmd_window): Move from
1271         tui-data.h.
1272         * tui/tui-command.c: Remove "structuring" comments.
1273         (tui_cmd_window::clear_detail)
1274         (tui_cmd_window::do_make_visible_with_new_height)
1275         (tui_cmd_window::max_height): Move from elsewhere.
1276
1277 2019-07-17  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1280         Now static.
1281         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1282         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1283
1284 2019-07-17  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui.c: Update.
1287         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1288         tui-regs.c.
1289         * tui/tui-windata.h: Remove file.
1290         * tui/tui-windata.c: Remove file.
1291         * tui/tui-win.c (tui_data_window::set_new_height)
1292         (tui_data_window::do_make_visible_with_new_height): Move to
1293         tui-regs.c.
1294         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1295         * tui/tui-regs.c: Remove "structuring" comments.
1296         (tui_data_window::first_data_item_displayed)
1297         (tui_data_window::delete_data_content_windows)
1298         (tui_data_window::erase_data_content)
1299         (tui_data_window::display_all_data)
1300         (tui_data_window::refresh_all)
1301         (tui_data_window::do_scroll_vertical)
1302         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1303         (tui_data_window::do_make_visible_with_new_height)
1304         (tui_data_window::refresh_window): Move from elsewhere.
1305         (_initialize_tui_regs): Move to end of file.
1306         * tui/tui-layout.c: Update.
1307         * tui/tui-hooks.c: Update.
1308         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1309         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1310         tui-regs.c.
1311         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1312
1313 2019-07-17  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1316         seen.
1317
1318 2019-07-17  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-win.c (tui_source_window_base::set_new_height)
1321         (tui_source_window_base::do_make_visible_with_new_height): Use
1322         m_has_locator field directly.
1323         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1324         method.
1325         (struct tui_source_window_base) <has_locator>: Likewise.
1326
1327 2019-07-17  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1330         Don't declare.
1331         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1332         Remove.
1333         * tui/tui-win.c (tui_source_window_base::set_new_height)
1334         (tui_source_window_base::set_new_height)
1335         (make_invisible_and_set_new_height)
1336         (tui_source_window_base::do_make_visible_with_new_height)
1337         (tui_source_window_base::do_make_visible_with_new_height):
1338         Update.
1339         * tui/tui-layout.c (show_source_disasm_command, show_data)
1340         (show_source_or_disasm_and_command): Update.
1341         * tui/tui-layout.c (show_layout): Update.
1342
1343 2019-07-17  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-layout.c (make_data_window): Remove.
1346         (show_data): Unify creation and re-initialization cases.
1347
1348 2019-07-17  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-layout.c (make_source_window, make_disasm_window):
1351         Remove.
1352         (show_data): Unify creation and re-initialization cases.
1353
1354 2019-07-17  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-layout.c (make_command_window): Remove.
1357         (show_source_disasm_command, show_source_or_disasm_and_command):
1358         Unify creation and re-initialization cases.
1359
1360 2019-07-17  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1363         creation and re-initialization cases.
1364
1365 2019-07-17  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-regs.c (tui_get_register): Return void.
1368
1369 2019-07-17  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1372         Simplify.
1373
1374 2019-07-17  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1377         resetting.
1378
1379 2019-07-17  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1382         * tui/tui-regs.c (tui_reg_layout): New function.
1383         (tui_show_registers, tui_reg_command): Use it.
1384         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1385         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1386         parameters.
1387         (tui_layout_command): Remove.
1388
1389 2019-07-17  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-layout.h (tui/tui-layout): Return void.
1392         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-layout.c (show_source_disasm_command, show_data):
1397         Update.
1398         (reset_locator): Remove.
1399         (show_source_or_disasm_and_command): Update.
1400
1401 2019-07-17  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-source.c (tui_source_window_base::reset): Remove
1404         win_type parameter.
1405         * tui/tui-layout.c (make_command_window, make_source_window)
1406         (make_disasm_window, make_data_window)
1407         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1408         (reset_locator, show_source_or_disasm_and_command): Update.
1409         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1410         win_type parameter.
1411         (struct tui_source_window_base) <reset>: Likewise.
1412
1413 2019-07-17  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-layout.c (show_source_disasm_command): Use
1416         reset_locator.
1417         (reset_locator): New function.
1418         (init_and_make_win): Remove.
1419         (show_source_or_disasm_and_command): Use reset_locator.
1420
1421 2019-07-17  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1424         condition.
1425         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1426         Remove condition.
1427         * tui/tui-source.c (tui_source_window_base::reset): New method.
1428         * tui/tui-layout.c (make_command_window): Don't call
1429         init_and_make_win.
1430         (make_source_window, make_disasm_window): Don't call
1431         make_source_or_disasm_window.
1432         (make_data_window): Don't call init_and_make_win.  Change calling
1433         convention.
1434         (show_source_disasm_command, show_data): Simplify.
1435         (make_source_or_disasm_window): Remove.
1436         (show_source_or_disasm_and_command): Simplify.
1437         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1438         (struct tui_source_window_base) <reset>: Likewise.
1439         <execution_info>: Remove initializer.
1440         * tui/tui-data.c (tui_source_window_base): Initialize
1441         execution_info.
1442
1443 2019-07-17  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1446         variable.
1447
1448 2019-07-17  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui.c (tui_rl_other_window): Update.
1451         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1452         superclass method first.  Always iterate over regs_content.
1453         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1454         method.
1455         * tui/tui-win.c (tui_set_focus_command): Update.
1456
1457 2019-07-17  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-win.c (tui_set_focus_command): Rename from
1460         tui_set_focus.  Call tui_enable.
1461         (tui_set_focus_command): Remove.
1462
1463 2019-07-17  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1466         refresh_window.
1467         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1468         touchwin.
1469         (tui_data_window::refresh_window): Call refresh_window on data
1470         items.  Always call superclass refresh_window.
1471         (tui_win_info::refresh): Remove.
1472         (tui_source_window_base::refresh_window): Update.
1473         (tui_refresh_all): Update.
1474         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1475         refresh_window.
1476         (show_source_or_disasm_and_command): Likewise.
1477         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1478         (struct tui_source_window_base) <refresh>: Likewise.
1479
1480 2019-07-17  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-winsource.c (tui_clear_source_content)
1483         (tui_show_source_content): Update.
1484         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1485         whether content is empty.
1486         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1487         Remove.
1488
1489 2019-07-17  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1492         window's contents.
1493         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1494         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1495
1496 2019-07-17  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1499         (struct tui_data_item_window): Update.
1500
1501 2019-07-17  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1504         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1505         defines.
1506
1507 2019-07-17  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-winsource.h (tui_erase_source_content)
1510         (tui_clear_source_content): Remove "display_prompt" parameter.
1511         * tui/tui-winsource.c (tui_update_source_window_as_is)
1512         (tui_update_source_windows_with_addr): Update.
1513         (tui_clear_source_content): Remove "display_prompt" parameter.
1514         (tui_erase_source_content): Likewise.  Simplify.
1515         (tui_show_source_content): Update.
1516         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1517         * tui/tui-stack.c (tui_show_frame_info): Update.
1518         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1519         Remove defines.
1520
1521 2019-07-17  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1524         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1525         parameter.
1526         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1527         parameter.
1528
1529 2019-07-17  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-winsource.c (tui_clear_source_content)
1532         (tui_show_source_content, tui_show_exec_info_content)
1533         (tui_clear_exec_info_content): Update.
1534         * tui/tui-stack.c (tui_show_locator_content): Update.
1535         (tui_show_frame_info): Update.
1536         * tui/tui-source.h (tui_source_window): Don't declare.
1537         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1538         from tui_source_is_displayed.
1539         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1540         Remove field.
1541         (struct tui_source_window_base) <content_in_use>: New field.  Now
1542         bool.
1543         (struct tui_source_window) <showing_source_p>: New method.
1544         (TUI_SRC_WIN): Change cast.
1545         * tui/tui-data.c (tui_initialize_static_data): Update.
1546
1547 2019-07-17  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1550         location_matches_p.
1551         * tui/tui-source.c (tui_source_window::location_matches_p): New
1552         method.
1553         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1554         method.
1555         * tui/tui-data.h (struct tui_source_window_base)
1556         <location_matches_p>: New method.
1557         (struct tui_source_window, struct tui_disasm_window)
1558         <location_matches_p>: Likewise.
1559
1560 2019-07-17  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-win.c (tui_set_win_height_command): Rename from
1563         tui_set_win_height.
1564         (tui_set_win_height_command): Remove.
1565
1566 2019-07-17  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-source.c (tui_source_window): New constructor.  Add
1569         observer.
1570         (~tui_source_window): New destructor.
1571         (tui_source_window::style_changed): New method.
1572         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1573         (tui_attach_detach_observers): Update.
1574         * tui/tui-data.h (struct tui_source_window): Make constructor not
1575         inline.  Add destructor.
1576         (struct tui_source_window) <style_changed>: New method.
1577         <m_observable>: New member.
1578
1579 2019-07-17  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1582         * tui/tui-win.c (tui_resize_all): Fix typo.
1583
1584 2019-07-17  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1587         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1588         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1589         * tui/tui-win.c (window_name_completer): Use foreach.
1590         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1591         (update_tab_width): Likewise.
1592         * tui/tui-layout.c (show_layout): Update.
1593         * tui/tui-data.h (class tui_window_iterator): New.
1594         (struct all_tui_windows): New.
1595         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1596
1597 2019-07-17  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1600         parameter.  Don't reference globals.
1601         (tui_reg_command): Update.
1602
1603 2019-07-17  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-regs.c (tui_show_registers): Simplify.
1606
1607 2019-07-17  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-regs.c (tui_show_registers): Update.
1610         (tui_show_register_group): Add win_info parameter.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1615         Rename from tui_display_reg_element_at_line.
1616         (tui_data_window::display_registers_from_line): Update.
1617         * tui/tui-data.h (struct tui_data_window)
1618         <display_reg_element_at_line>: New method.
1619
1620 2019-07-17  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-regs.h (tui_display_registers_from)
1623         (tui_display_registers_from_line): Don't declare.
1624         * tui/tui-windata.c (tui_data_window::display_all_data)
1625         (tui_data_window::refresh_all)
1626         (tui_data_window::do_scroll_vertical): Update.
1627         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1628         from tui_display_registers_from.
1629         (tui_display_reg_element_at_line): Update.
1630         (tui_data_window::display_registers_from_line): Rename from
1631         tui_display_registers_from_line.
1632         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1633         display_registers_from_line>: New methods.
1634
1635 2019-07-17  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1638         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1639         from tui_erase_data_content.
1640         (tui_data_window::display_all_data)
1641         (tui_data_window::refresh_all)
1642         (tui_data_window::do_scroll_vertical): Update.
1643         * tui/tui-regs.c (tui_show_registers): Update.
1644         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1645         New method.
1646
1647 2019-07-17  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1650         declare.
1651         * tui/tui-windata.c
1652         (tui_data_window::delete_data_content_windows): Rename from
1653         tui_delete_data_content_windows.
1654         (tui_data_window::display_all_data)
1655         (tui_data_window::do_scroll_vertical): Update.
1656         * tui/tui-data.h (struct tui_data_window)
1657         <delete_data_content_windows>: New method.
1658
1659 2019-07-17  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1662         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1663
1664 2019-07-17  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1667         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1668         from tui_display_all_data.
1669         * tui/tui-win.c
1670         (tui_data_window::do_make_visible_with_new_height): Update.
1671         * tui/tui-regs.c (tui_show_registers): Update.
1672         * tui/tui-layout.c (tui_set_layout): Update.
1673         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1674         method.
1675
1676 2019-07-17  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1679         * tui/tui-windata.c (tui_display_data_from): Remove.
1680         (tui_data_window::refresh_all): Update.
1681
1682 2019-07-17  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1685         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1686         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1687         tui_display_registers_from_line.
1688         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1689         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1690         "force_display" parameter.
1691
1692 2019-07-17  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1695         declare.
1696         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1697         Rename from tui_first_reg_element_no_inline.
1698         (tui_display_reg_element_at_line)
1699         (tui_display_registers_from_line): Update.
1700         * tui/tui-data.h (struct tui_data_window)
1701         <first_reg_element_no_inline>: New method.
1702
1703 2019-07-17  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-windata.c (tui_display_data_from)
1706         (tui_data_window::do_scroll_vertical): Update.
1707         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1708         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1709         Rename from tui_line_from_reg_element_no.
1710         (tui_display_registers_from_line): Update.
1711         * tui/tui-data.h (struct tui_data_window)
1712         <line_from_reg_element_no>: New method.
1713
1714 2019-07-17  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1717         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1718         tui_last_regs_line_no.
1719         (tui_display_reg_element_at_line)
1720         (tui_display_registers_from_line): Update.
1721         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1722         method.
1723
1724 2019-07-17  Tom Tromey  <tom@tromey.com>
1725
1726         PR tui/24722:
1727         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1728         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1729         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1730         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1731         (tui_update_breakpoint_info): Likewise.
1732         * tui/tui-hooks.c (tui_event_create_breakpoint)
1733         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1734         Update.
1735
1736 2019-07-17  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-winsource.c (tui_update_source_window_as_is)
1743         (tui_update_source_windows_with_addr): Update.
1744         * tui/tui-source.h (tui_set_source_content)
1745         (tui_show_symtab_source): Add "win_info" parameter.
1746         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1747         parameter.
1748         (tui_show_symtab_source): Likewise.
1749
1750 2019-07-17  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-wingeneral.c
1753         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1754
1755 2019-07-17  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1758         (struct tui_cmd_window) <can_scroll>: New method.
1759         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1760         method.
1761
1762 2019-07-17  Tom Tromey  <tromey@adacore.com>
1763
1764         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1765         do_field_signed>: Rename.  Change type of "value".
1766         * ui-out.c (ui_out::field_signed): Rename from field_int.
1767         Change type of "value".
1768         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1769         type of "value".
1770         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1771         do_field_int.  Change type of "value".
1772         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1773         do_field_int.  Change type of "value".
1774         * tracepoint.c (trace_status_mi, tfind_1)
1775         (print_one_static_tracepoint_marker): Update.
1776         * thread.c (print_thread_info_1, print_selected_thread_frame):
1777         Update.
1778         * stack.c (print_frame, print_frame_info): Update.
1779         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1780         Update.
1781         * source.c (print_source_lines_base): Update.
1782         * skip.c (info_skip_command): Update.
1783         * record-btrace.c (btrace_ui_out_decode_error)
1784         (btrace_call_history_src_line): Update.
1785         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1786         Update.
1787         * progspace.c (print_program_space): Update.
1788         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1789         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1790         do_field_int.  Change type of "value".
1791         * mi/mi-out.c (mi_ui_out::do_table_begin)
1792         (mi_ui_out::do_table_header): Update.
1793         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1794         type of "value".
1795         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1796         (mi_cmd_data_list_changed_registers, output_register)
1797         (mi_cmd_data_read_memory, mi_load_progress)
1798         (mi_cmd_trace_frame_collected): Update.
1799         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1800         Update.
1801         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1802         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1803         (mi_cmd_var_list_children, varobj_update_one): Update.
1804         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1805         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1806         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1807         * inferior.c (print_inferior): Update.
1808         * gdb_bfd.c (print_one_bfd): Update.
1809         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1810         Update.
1811         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1812         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1813         do_field_int.  Change type of "value".
1814         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1815         do_field_int.  Change type of "value".
1816         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1817         (print_one_breakpoint_location, print_it_catch_fork)
1818         (print_one_catch_fork, print_it_catch_vfork)
1819         (print_one_catch_vfork, print_it_catch_solib)
1820         (print_it_catch_exec, print_it_ranged_breakpoint)
1821         (print_mention_watchpoint, print_mention_masked_watchpoint)
1822         (bkpt_print_it, update_static_tracepoint): Update.
1823         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1824         * break-catch-syscall.c (print_it_catch_syscall): Update.
1825         * ada-tasks.c (print_ada_task_info): Update.
1826         * ada-lang.c (print_it_exception, print_mention_exception):
1827         Update.
1828
1829 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         PR breakpoints/24541
1832         * gdbarch.c: Regenerate.
1833         * gdbarch.h: Regenerate.
1834         * gdbarch.sh: Adjust return type and parameter types for
1835         'stap_adjust_register'.
1836         (i386_stap_adjust_register): Adjust signature and return new
1837         register name.
1838         * stap-probe.c (stap_parse_register_operand): Adjust use of
1839         'gdbarch_stap_adjust_register'.
1840
1841 2019-07-17  Tom Tromey  <tromey@adacore.com>
1842
1843         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1844         declare VEC.
1845         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1846         std::vector.
1847         (struct s390_process_info): Add initializers.
1848         (s390_add_process): Use new.
1849         (s390_linux_nat_target::low_forget_process): Use delete.
1850         (s390_linux_nat_target::low_new_fork)
1851         (s390_linux_nat_target::stopped_by_watchpoint)
1852         (s390_linux_nat_target::low_prepare_to_resume)
1853         (s390_linux_nat_target::insert_watchpoint)
1854         (s390_linux_nat_target::insert_hw_breakpoint)
1855         (s390_linux_nat_target::remove_watchpoint)
1856         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1857
1858 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1859
1860         * aarch64-fbsd-nat.c: Include regcache.h.
1861         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1862         argument.
1863         (aarch64_fbsd_nat_target::fetch_registers)
1864         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1865         variable.
1866         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1867
1868 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1869
1870         * fbsd-nat.c: Include gdbarch.h.
1871
1872 2019-07-15  Tom Tromey  <tromey@adacore.com>
1873
1874         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1875
1876 2019-07-15  Tom Tromey  <tromey@adacore.com>
1877
1878         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1879         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1880         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1881         * cli-out.c (cli_ui_out::do_field_int): New method.
1882         * ui-out.c (ui_out::field_unsigned): New method.
1883         * symfile.c (generic_load): Use field_unsigned.
1884         (print_transfer_performance): Likewise.
1885         * record-btrace.c (ui_out_field_uint): Remove.
1886         (btrace_call_history_insn_range, btrace_call_history): Use
1887         field_unsigned.
1888         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1889         field_unsigned.
1890         * ui-out.h (class ui_out) <field_unsigned>: New method.
1891         <do_field_unsigned>: Likewise.
1892
1893 2019-07-15  Tom Tromey  <tromey@adacore.com>
1894
1895         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1896         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1897         * target.c (flash_erase_command): Use field_string.
1898         * infrun.c (print_signal_received_reason): Use field_string.
1899         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1900         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1901         field_string.
1902         * ada-tasks.c (print_ada_task_info): Use field_string.
1903
1904 2019-07-15  Tom Tromey  <tromey@adacore.com>
1905
1906         * target.c (flash_erase_command): Use field_core_addr.
1907         * symfile.c (generic_load): Use field_core_addr.
1908         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1909         Use field_core_addr.
1910         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1911         field_core_addr.
1912
1913 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1916         value if its desired type is smaller than a CORE_ADDR and signed.
1917
1918 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1921         of changes to field names, and use new is_reference field to
1922         decide if a property is a reference or not.
1923         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1924         field.
1925         (struct dwarf2_property_baton): Update header comment, rename
1926         'referenced_type' to 'property_type' and update comments.
1927         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1928         default property type, store in property baton, update to take
1929         accound of renamed field.
1930         (read_func_scope): Update call to attr_to_dynamic_prop.
1931         (read_array_type): Likewise.
1932         (dwarf2_per_cu_addr_sized_int_type): New function.
1933         (read_subrange_index_type): Move type finding code to
1934         dwarf2_per_cu_addr_sized_int_type.
1935         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1936         (dwarf2_per_cu_addr_type): New function.
1937         (set_die_type): Update calls to attr_to_dynamic_prop.
1938
1939 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * dwarf2read.c (read_subrange_index_type): New function.
1942         (read_subrange_type): Move code into new function and call it.
1943         * gdbtypes.c (create_range_type): Add some asserts.
1944
1945 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1946
1947         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1948         update return statements.
1949         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1950         declaration, and update comment to match.
1951         * gdbtypes.c (resolve_dynamic_array): Update call to
1952         dwarf2_evaluate_property to match new return type.
1953
1954 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1955
1956         * valarith.c (value_subscripted_rvalue): Change lowerbound
1957         parameter type from int to LONGEST.
1958         * value.h (value_subscripted_rvalue): Likewise in declaration.
1959
1960 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * cli/cli-utils.c (info_print_command_completer): New function.
1963         * cli/cli-utils.h: Add 'completer.h' include, and forward
1964         declaration for 'struct cmd_list_element'.
1965         (info_print_command_completer): Declare.
1966         * stack.c (_initialize_stack): Add completer for 'info locals' and
1967         'info args'.
1968         * symtab.c (_initialize_symtab): Add completer for 'info
1969         variables' and 'info functions'.
1970         * NEWS: Mention completion for additional info commands.
1971
1972 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1973
1974         * cli/cli-utils.c (extract_info_print_args): Delete.
1975         (extract_arg_maybe_quoted): Delete.
1976         (info_print_options_defs): New variable.
1977         (make_info_print_options_def_group): New function.
1978         (extract_info_print_options): Define new function.
1979         * cli/cli-utils.h (extract_info_print_args): Delete.
1980         (struct info_print_options): New structure.
1981         (extract_info_print_options): Declare new function.
1982         * stack.c (info_locals_command): Update to use new
1983         extract_info_print_options, also add a header comment.
1984         (info_args_command): Likewise.
1985         * symtab.c (info_variables_command): Likewise.
1986         (info_functions_command): Likewise.
1987
1988 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1991         to extract string arguments.
1992         * common/common-utils.c (extract_string_maybe_quoted): New function.
1993         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1994
1995 2019-07-11  Tom Tromey  <tromey@adacore.com>
1996
1997         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1998         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1999         * top.h (gdbinit): Don't declare.
2000         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2001         into...
2002         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2003         * top.c (gdb_init): Don't call init_cli_cmds.
2004         (gdbinit): Remove.
2005         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2006
2007 2019-07-11  Tom Tromey  <tromey@adacore.com>
2008
2009         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2010         after it has been moved.
2011
2012 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2013
2014         * valops.c (value_must_coerce_to_target): Change return type to
2015         bool.
2016         * value.h (value_must_coerce_to_target): Likewise.
2017
2018 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2019
2020         * breakpoint.c (is_hardware_watchpoint): Remove
2021         forward-declaration.
2022         (is_masked_watchpoint): Change return type to bool.
2023         (is_tracepoint): Likewise.
2024         (is_breakpoint): Likewise.
2025         (is_hardware_watchpoint): Likewise.
2026         (is_watchpoint): Likewise.
2027         (is_no_memory_software_watchpoint): Likewise.
2028         (is_catchpoint): Likewise.
2029         (breakpoint_1): Make FILTER parameter's return type bool.
2030         is_masked_watchpoint): Change return type to bool.
2031         (save_breakpoints): Make FILTER parameter's return type bool.
2032         * breakpoint.h (is_breakpoint): Change return type to bool.
2033         (is_watchpoint): Likewise.
2034         (is_catchpoint): Likewise.
2035         (is_tracepoint): Likewise.
2036
2037 2019-07-10  Tom Tromey  <tom@tromey.com>
2038
2039         * defs.h: Don't include gdbarch.h.
2040         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2041         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2042         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2043         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2044         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2045         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2046         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2047         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2048         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2049         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2050         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2051         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2052         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2053         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2054         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2055         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2056         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2057         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2058         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2059         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2060         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2061         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2062         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2063         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2064         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2065         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2066         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2067
2068 2019-07-10  Tom Tromey  <tromey@adacore.com>
2069
2070         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2071         * breakpoint.c (init_ada_exception_breakpoint): Register as
2072         bp_catchpoint.
2073         (print_one_breakpoint_location, print_one_breakpoint): Use
2074         is_ada_exception_catchpoint.
2075         * ada-lang.c (class ada_catchpoint_location): Pass
2076         bp_loc_software_breakpoint to bp_location constructor.
2077         (is_ada_exception_catchpoint): New function.
2078
2079 2019-07-10  Tom Tromey  <tromey@adacore.com>
2080
2081         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2082         VEC.
2083         (struct arm_exidx_entry): New method operator<.
2084         (struct arm_exidx_data) <section_maps>: Change type.
2085         (arm_exidx_data_free): Remove.
2086         (arm_exidx_data_key): Change type.  Move lower.
2087         (arm_exidx_new_objfile): Update.
2088         (arm_compare_exidx_entries): Remove.
2089         (arm_find_exidx_entry, _initialize_arm_tdep)
2090
2091 2019-07-10  Tom Tromey  <tromey@adacore.com>
2092
2093         * solib-spu.c (ocl_program_data_key): Change type.
2094         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2095         Update.
2096
2097 2019-07-10  Tom Tromey  <tromey@adacore.com>
2098
2099         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2100         (struct solib_aix_inferior_data) <library_list>: Change type.
2101         (solib_aix_inferior_data_handle): Change type.
2102         (get_solib_aix_inferior_data): Update.
2103         (solib_aix_free_library_list): Remove.
2104         (library_list_start_library): Update.
2105         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2106         return type.
2107         (solib_aix_get_library_list)
2108         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2109         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2110
2111 2019-07-10  Tom Tromey  <tromey@adacore.com>
2112
2113         * solib-dsbt.c (struct dsbt_info): Add initializers.
2114         (solib_dsbt_pspace_data): Change type.
2115         (dsbt_pspace_data_cleanup): Remove.
2116         (get_dsbt_info, _initialize_dsbt_solib): Update.
2117
2118 2019-07-10  Tom Tromey  <tromey@adacore.com>
2119
2120         * spu-tdep.c (spu_overlay_data): Change type.
2121         (spu_get_overlay_table, spu_overlay_new_objfile)
2122         (_initialize_spu_tdep): Update.
2123
2124 2019-07-10  Tom Tromey  <tromey@adacore.com>
2125
2126         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2127         destructor.
2128         (dbx_objfile_data_key): Change type and declare later.
2129         (DBX_SYMFILE_INFO): Rewrite.
2130         * dbxread.c (dbx_objfile_data_key): Change type.
2131         (dbx_symfile_init): Update.
2132         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2133         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2134         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2135
2136 2019-07-10  Tom Tromey  <tromey@adacore.com>
2137
2138         * jit.c (jit_program_space_key): Change type.  Move lower.
2139         (get_jit_program_space_data): Update.
2140         (jit_program_space_data_cleanup): Remove.
2141         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2142         Update.
2143         (struct jit_program_space_data): Add initializers.
2144
2145 2019-07-10  Tom Tromey  <tromey@adacore.com>
2146
2147         * solib-darwin.c (struct darwin_info): Add initializers.
2148         (solib_darwin_pspace_data): Change type.
2149         (darwin_pspace_data_cleanup): Remove.
2150         (get_darwin_info, _initialize_darwin_solib): Update.
2151
2152 2019-07-10  Tom Tromey  <tromey@adacore.com>
2153
2154         * remote-sim.c (struct sim_inferior_data): Add initializers,
2155         constructor, and destructor.
2156         (sim_inferior_data_key): Change type.  Move lower.
2157         (check_for_duplicate_sim_descriptor): Update.
2158         (get_sim_inferior_data): Use new.  Update.
2159         (~sim_inferior_data_cleanup): Rename from
2160         sim_inferior_data_cleanup.  Simplify.
2161         (gdbsim_close_inferior, simulator_command)
2162         (sim_command_completer, _initialize_remote_sim): Update.
2163         (next_pid, INITIAL_PID): Move earlier.
2164
2165 2019-07-10  Tom Tromey  <tromey@adacore.com>
2166
2167         * python/python-internal.h (create_thread_object): Return
2168         gdbpy_ref.
2169         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2170         * python/py-inferior.c (struct threadlist_entry): Add
2171         constructor.
2172         <thread_obj>: Now a gdbpy_ref.
2173         (thread_to_thread_object): Update.
2174         (add_thread_object): Use new.
2175         (delete_thread_object): Use delete.
2176         (infpy_threads): Update.
2177         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2178         GIL.
2179
2180 2019-07-10  Tom Tromey  <tromey@adacore.com>
2181
2182         * valops.c (value_cast): Specialize error message for Ada.
2183
2184 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2185
2186         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2187
2188 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2189
2190         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2191         bpstat_should_step): Return bool, adjust comments.
2192         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2193         bpstat_should_step): Likewise.
2194
2195 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2196
2197         * features/Makefile: Use feature target descriptions for Arm.
2198         * features/arm/arm-core.c: Generate new file.
2199         * features/arm/arm-fpa.c: Likewise.
2200         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2201         * features/arm/arm-m-profile.c: Likewise.
2202         * features/arm/arm-vfpv2.c: Likewise.
2203         * features/arm/arm-vfpv3.c: Likewise.
2204         * features/arm/xscale-iwmmxt.c: Likewise.
2205         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2206
2207 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2208
2209         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2210         ptrace earlier.
2211
2212 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2213
2214         * features/aarch64-pauth.c: Regenerate.
2215
2216 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2217
2218         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2219         bool.
2220         (bpstat_what): Use false instead of 0.
2221
2222 2019-07-09  Pedro Alves  <palves@redhat.com>
2223
2224         * break-catch-throw.c (is_exception_catchpoint): New.
2225         * breakpoint.c (print_one_breakpoint_location): New parameter
2226         'raw_loc'.  Handle it.  Use
2227         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2228         looking at the breakpoint's type.
2229         (print_one_breakpoint): If handling "maint info breakpoints", also
2230         print locations of exception catchpoints.
2231         * breakpoint.h (is_exception_catchpoint): Declare.
2232
2233 2019-07-09  Pedro Alves  <palves@redhat.com>
2234
2235         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2236         "addr" field.
2237         (allocate_location_exception_catchpoint): New.
2238         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2239         (initialize_throw_catchpoint_ops): Install
2240         allocate_location_exception_catchpoint as allocate_location
2241         method.
2242         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2243         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2244         bp_loc_other.
2245         (breakpoint_address_is_meaningful): Delete.
2246         (bl_address_is_meaningful): New.
2247         (breakpoint_locations_match): Adjust comment.
2248         (bp_location_from_bp_type): New, factored out of...
2249         (bp_location::bp_location(breakpoint *)): ... this.
2250         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2251         factored out of...
2252         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2253         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2254         breakpoint_address_is_meaningful.
2255         (bp_locations_compare): Adjust comment.
2256         (update_global_location_list): Use bl_address_is_meaningful
2257         instead of breakpoint_address_is_meaningful.
2258         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2259         explicit.
2260         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2261         * python/py-breakpoint.c (bppy_get_location): No longer check
2262         whether location is null.
2263
2264 2019-07-09  Pedro Alves  <palves@redhat.com>
2265
2266         PR c++/15468
2267         * breakpoint.c (print_one_breakpoint_location): Remove
2268         single-location assert.
2269
2270 2019-07-09  Tom Tromey  <tom@tromey.com>
2271
2272         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2273         * configure: Rebuild.
2274         * configure.ac: Change common to gdbsupport.
2275         * gdbsupport: Rename from common.
2276         * acinclude.m4: Change common to gdbsupport.
2277         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2278         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2279         gdbsupport.
2280         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2281         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2282         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2283         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2284         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2285         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2286         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2287         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2288         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2289         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2290         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2291         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2292         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2293         coff-pe-read.c, command.h, compile/compile-c-support.c,
2294         compile/compile-c.h, compile/compile-cplus-symbols.c,
2295         compile/compile-cplus-types.c, compile/compile-cplus.h,
2296         compile/compile-loc2c.c, compile/compile.c, completer.c,
2297         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2298         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2299         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2300         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2301         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2302         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2303         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2304         features/aarch64-core.c, features/aarch64-fpu.c,
2305         features/aarch64-pauth.c, features/aarch64-sve.c,
2306         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2307         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2308         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2309         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2310         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2311         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2312         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2313         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2314         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2315         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2316         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2317         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2318         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2319         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2320         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2321         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2322         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2323         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2324         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2325         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2326         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2327         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2328         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2329         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2330         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2331         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2332         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2333         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2334         minsyms.c, mips-linux-tdep.c, namespace.h,
2335         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2336         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2337         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2338         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2339         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2340         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2341         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2342         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2343         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2344         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2345         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2346         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2347         procfs.c, producer.c, progspace.h, psymtab.h,
2348         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2349         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2350         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2351         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2352         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2353         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2354         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2355         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2356         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2357         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2358         target-memory.c, target.c, target.h, target/waitstatus.c,
2359         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2360         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2361         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2362         unittests/array-view-selftests.c,
2363         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2364         unittests/common-utils-selftests.c,
2365         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2366         unittests/format_pieces-selftests.c,
2367         unittests/function-view-selftests.c,
2368         unittests/lookup_name_info-selftests.c,
2369         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2370         unittests/mkdir-recursive-selftests.c,
2371         unittests/observable-selftests.c,
2372         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2373         unittests/parse-connection-spec-selftests.c,
2374         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2375         unittests/scoped_fd-selftests.c,
2376         unittests/scoped_mmap-selftests.c,
2377         unittests/scoped_restore-selftests.c,
2378         unittests/string_view-selftests.c, unittests/style-selftests.c,
2379         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2380         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2381         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2382         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2383         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2384         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2385
2386 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2389         bool value.
2390         (decode_digits_ordinary): Set explicit_line field in sal.
2391         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2392         symtab_and_line that was set on an explicit line number in
2393         assembler code.  Do always update the recorded symtab and line if
2394         we do skip the prologue.
2395
2396 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2397
2398         * breakpoint.c (set_breakpoint_location_function): Remove
2399         explicit_loc parameter.
2400         (momentary_breakpoint_from_master): Update call to
2401         set_breakpoint_location_function.
2402         (add_location_to_breakpoint): Likewise.
2403
2404 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2407         required features based on default bfd type when no specific bfd
2408         is present.
2409
2410 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2411
2412         * NEWS: Mention that GDB printf and eval commands can now print
2413         C-style and Ada-style convenience var strings without
2414         calling the inferior.
2415         * printcmd.c (printf_c_string): Locally print GDB internal var
2416         instead of transiting via the inferior.
2417         (printf_wide_c_string): Likewise.
2418
2419 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2420
2421         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2422
2423 2019-07-04  Tom Tromey  <tom@tromey.com>
2424
2425         PR tui/24724:
2426         * tui/tui-winsource.c (tui_clear_source_content): Update.
2427         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2428         (tui_update_breakpoint_info): Update.
2429         (tui_set_exec_info_content): Update.
2430         * tui/tui-source.c (tui_set_source_content_nil): Update.
2431         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2432         has_break.
2433         * tui/tui-data.h (enum tui_bp_flag): New.
2434         (tui_bp_flags): New enum flags type.
2435         (struct tui_source_element) <break_mode>: Change type.  Rename
2436         from has_break.
2437         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2438         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2439         constants.
2440         * tui/tui-winsource.h: Fix comment.
2441
2442 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2443
2444         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2445         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2446         (store_fpregs_to_thread)
2447         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2448         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2449         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2450         (IWMMXT_REGS_SIZE): Add define.
2451         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2452         (fetch_vfp_regs, store_vfp_regs)
2453         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2454         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2455
2456 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2457
2458         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2459         defines.
2460         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2461         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2462         (ARM_INT_REGISTER_SIZE): ...to this.
2463         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2464         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2465         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2466         (arm_linux_collect_gregset, supply_nwfpe_register)
2467         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2468         defines.
2469         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2470         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2471         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2472         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2473         (arm_return_in_memory, arm_store_return_value)
2474         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2475         (arm_record_ld_st_multiple): Likewise.
2476         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2477         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2478
2479 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2480
2481         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2482         AARCH64_DISPLACED_MODIFIED_INSNS.
2483         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2484         (aarch64_displaced_step_copy_insn): Likewise.
2485         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2486         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2487         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2488         ARM_DISPLACED_MODIFIED_INSNS.
2489         * arm-tdep.c (arm_gdbarch_init): Likewise.
2490         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2491         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2492         (struct arm_displaced_step_closure): Use
2493         ARM_DISPLACED_MODIFIED_INSNS.
2494
2495 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2496
2497         * features/Makefile: Remove unused xml files.
2498         * features/aarch64.xml: Remove.
2499         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2500         * features/i386/amd64-avx-avx512.xml: Remove.
2501         * features/i386/amd64-avx-linux.xml: Remove.
2502         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2503         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2504         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2505         * features/i386/amd64-avx-mpx.xml: Remove.
2506         * features/i386/amd64-avx.xml: Remove.
2507         * features/i386/amd64-linux.xml: Remove.
2508         * features/i386/amd64-mpx-linux.xml: Remove.
2509         * features/i386/amd64-mpx.xml: Remove.
2510         * features/i386/amd64.xml: Remove.
2511         * features/i386/i386-avx-avx512-linux.xml: Remove.
2512         * features/i386/i386-avx-avx512.xml: Remove.
2513         * features/i386/i386-avx-linux.xml: Remove.
2514         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2515         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2516         * features/i386/i386-avx-mpx-linux.xml: Remove.
2517         * features/i386/i386-avx-mpx.xml: Remove.
2518         * features/i386/i386-avx.xml: Remove.
2519         * features/i386/i386-linux.xml: Remove.
2520         * features/i386/i386-mmx-linux.xml: Remove.
2521         * features/i386/i386-mmx.xml: Remove.
2522         * features/i386/i386-mpx-linux.xml: Remove.
2523         * features/i386/i386-mpx.xml: Remove.
2524         * features/i386/i386.xml: Remove.
2525         * features/i386/x32-avx-avx512-linux.xml: Remove.
2526         * features/i386/x32-avx-linux.xml: Remove.
2527         * features/i386/x32-linux.xml: Remove.
2528
2529 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2530
2531         * regformats/aarch64.dat: Remove.
2532         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2533         * regformats/i386/amd64-avx-linux.dat: Remove.
2534         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2535         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2536         * regformats/i386/amd64-linux.dat: Remove.
2537         * regformats/i386/amd64-mpx-linux.dat: Remove.
2538         * regformats/i386/amd64.dat: Remove.
2539         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2540         * regformats/i386/i386-avx-linux.dat: Remove.
2541         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2542         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2543         * regformats/i386/i386-linux.dat: Remove.
2544         * regformats/i386/i386-mmx-linux.dat: Remove.
2545         * regformats/i386/i386-mpx-linux.dat: Remove.
2546         * regformats/i386/i386.dat: Remove.
2547         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2548         * regformats/i386/x32-avx-linux.dat: Remove.
2549         * regformats/i386/x32-linux.dat: Remove.
2550
2551 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2552
2553         * aarch64-tdep.c: Remove xml self tests.
2554         * amd64-linux-tdep.c: Likewise.
2555         * amd64-tdep.c: Likewise.
2556         * i386-linux-tdep.c: Likewise.
2557         * i386-tdep.c: Likewise.
2558
2559 2019-07-03  Pedro Alves  <palves@redhat.com>
2560
2561         PR cli/24732
2562         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2563         (pipe_cmd_option_defs): New.
2564         (make_pipe_cmd_options_def_group): New.
2565         (pipe_command): Use gdb::option::process_options.
2566         (pipe_command_completer): New function.
2567         (_initialize_cli_cmds): Install completer for "pipe" command.
2568
2569 2019-07-03  Pedro Alves  <palves@redhat.com>
2570
2571         * cli/cli-option.c (union option_value) <string>: New field.
2572         (struct option_def_and_value): Add ctor, move ctor, dtor and
2573         use DISABLE_COPY_AND_ASSIGN.
2574         (option_def_and_value::clear_value): New.
2575         (parse_option, save_option_value_in_ctx, get_val_type_str)
2576         (add_setshow_cmds_for_options): Handle var_string.
2577         * cli-option.h (union option_def::var_address) <string>: New
2578         field.
2579         (struct string_option_def): New.
2580         * maint-test-options.c (struct test_options_opts): Add default
2581         ctor and use DISABLE_COPY_AND_ASSIGN.
2582         <string_opt>: New field.
2583         (test_options_opts::~test_options_opts): New.
2584         (test_options_opts::dump): Also dump "-string".
2585         (test_options_option_defs): Install "string.
2586
2587 2019-07-03  Pedro Alves  <palves@redhat.com>
2588
2589         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2590         option_value with a null enumeration.
2591         (complete_options): Save the option values in the context.
2592         (save_option_value_in_ctx): New, factored out from ...
2593         (process_options): ... here.
2594         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2595         of the function.
2596         * maint-test-options.c (test_options_opts::dump): New, factored
2597         out from ...
2598         (maintenance_test_options_command_mode): ... here.
2599         (maintenance_test_options_command_completion_result): Delete.
2600         (maintenance_test_options_command_completion_text): Update
2601         comment.
2602         (maintenance_show_test_options_completion_result): Change
2603         prototype.  Just print
2604         maintenance_test_options_command_completion_text.
2605         (save_completion_result): New.
2606         (maintenance_test_options_completer_mode): Pass options context to
2607         complete_options, and then save a dump.
2608         (_initialize_maint_test_options): Use add_cmd to install "maint
2609         show test-options-completion-result".
2610
2611 2019-07-03  Pedro Alves  <palves@redhat.com>
2612
2613         * NEWS (New commands): Mention "with" and "maint with".
2614         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2615         (with_command, with_command_completer): New.
2616         (pipe_command): Adjust to new repeat_previous
2617         interface.
2618         (_initialize_cli_cmds): Install the "with" command and its "w"
2619         alias.
2620         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2621         declarations.
2622         * cli/cli-setshow.c (parse_cli_var_uinteger)
2623         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2624         argument strings for all var_types.
2625         (get_setshow_command_value_string): New, factored out from ...
2626         (do_show_command): ... this.
2627         * cli/cli-setshow.h: Include <string>.
2628         (get_setshow_command_value_string): Declare.
2629         * command.h (repeat_previous): Now returns const char *.  Adjust
2630         comment.
2631         * maint.c: Include "cli/cli-cmds.h".
2632         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2633         (_initialize_maint_cmds): Register the "maintenance with" command.
2634         * top.c (repeat_previous): Move bits from pipe_command here:
2635         Return the saved command line, if any; error out if there's no
2636         command to relaunch.
2637
2638 2019-07-03  Pedro Alves  <palves@redhat.com>
2639
2640         * NEWS (New commands): Mention "maint set/show test-settings"
2641         instead of "maint test-settings".
2642         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2643         (maintenance_test_settings_set_list): Rename to ...
2644         (maintenance_set_test_settings_list): ... this.
2645         (maintenance_test_settings_show_list): Rename to  ...
2646         (maintenance_show_test_settings_list): ... this.
2647         (maintenance_test_settings_cmd): Delete.
2648         (maintenance_test_settings_set_cmd): ...
2649         (maintenance_set_test_settings_cmd): ... this.
2650         (maintenance_test_settings_show_cmd): ...
2651         (maintenance_show_test_settings_cmd): ... this.
2652         (maintenance_test_settings_show_value_cmd):
2653         (maintenance_show_test_settings_value_cmd): ... this.
2654         (_initialize_maint_test_settings): No longer install the "maint
2655         test-settings" prefix command.  Rename "maint test-settings set"
2656         to "maint set test-settings", and "maint test-settings show" to
2657         "maint show test-settings".  Adjust all subcommands.
2658
2659 2019-07-03  Pedro Alves  <palves@redhat.com>
2660
2661         * maint-test-settings.c: Fix file's intro comment.  Replace all
2662         references to "test-options" with references to "test-settings",
2663         in comments.
2664
2665 2019-07-03  Pedro Alves  <palves@redhat.com>
2666
2667         * maint-test-settings.c (maintenance_test_settings_xxx)
2668         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2669         New.
2670         (maintenance_test_settings_enums): Use them.
2671         (maintenance_test_settings_enum): Default to
2672         maintenance_test_settings_xxx.
2673         (_initialize_maint_test_settings): Initialize
2674         MAINTENANCE_TEST_SETTINGS_FILENAME.
2675
2676 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2677
2678         * breakpoint.h (remove_breakpoints_inf): Change return type to
2679         void, move function documentation here.
2680         * breakpoint.c (remove_breakpoints_inf): Change return type to
2681         void, move function documentation to header.
2682
2683 2019-07-02  Pedro Alves  <palves@redhat.com>
2684
2685         * NEWS (Completion improvements): Mention "info threads".
2686         * thread.c (struct info_threads_opts, info_threads_option_defs)
2687         (make_info_threads_options_def_group): New.
2688         (info_threads_command): Use gdb::option::process_options.
2689         (info_threads_command_completer): New.
2690         (_initialize_thread): Use gdb::option::build_help to build the
2691         help text for "info threads".
2692
2693 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2694
2695         * defs.h (generic_load): Move from here...
2696         * symfile.h (generic_load): ... to here.  Rename name parameter
2697         to args.
2698         * symfile.c (generic_load): Add comment.
2699
2700 2019-07-01  Tom Tromey  <tromey@adacore.com>
2701
2702         * dwarf2read.c
2703         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2704         declaration of without_params.  Fix formatting.
2705
2706 2019-07-01  Tom Tromey  <tromey@adacore.com>
2707
2708         * ada-exp.y (find_primitive_type): Update.
2709         * ada-lang.h (ada_lookup_symbol): Update.
2710         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2711         parameter.
2712         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2713
2714 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2715
2716         PR breakpoints/24541
2717         * gdbarch.c: Regenerate.
2718         * gdbarch.h: Regenerate.
2719         * gdbarch.sh: Add 'stap_adjust_register'.
2720         * i386-tdep.c: Include '<unordered_set>'.
2721         (i386_stap_adjust_register): New function.
2722         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2723         * stap-probe.c (stap_parse_register_operand): Call
2724         'gdbarch_stap_adjust_register'.
2725
2726 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2727
2728         PR python/24742
2729         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2730         * python/python.c (do_start_initialization): Use 'xmalloc'
2731         instead of 'PyMem_Malloc'.
2732
2733 2019-06-28  Tom Tromey  <tromey@adacore.com>
2734
2735         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2736         for Ada.
2737
2738 2019-06-27  Tom Tromey  <tromey@adacore.com>
2739
2740         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2741         objfile_key.
2742         (arm_find_mapping_symbol, arm_record_special_symbol)
2743         (_initialize_arm_tdep): Update.
2744         (arm_objfile_data_free): Remove.
2745
2746 2019-06-27  Tom Tromey  <tromey@adacore.com>
2747
2748         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2749         to cp_print_static_field.
2750
2751 2019-06-26  Tom Tromey  <tromey@adacore.com>
2752
2753         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2754         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2755         declare.
2756
2757 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2758
2759         * features/aarch64-core.c (create_feature_aarch64_core):
2760         Regenerate.
2761         * features/aarch64-core.xml: Add cpsr flags.
2762
2763 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2764
2765         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2766         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2767
2768 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2769
2770         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2771         field.
2772         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2773         use.
2774         (arm_record_special_symbol): Don't insert new symbol in sorted
2775         position, push it at the end.
2776
2777 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2778
2779         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2780         (arm_mapping_symbol_s): Remove.
2781         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2782         (arm_mapping_symbol_vec): New typedef.
2783         (struct arm_per_objfile): Add constructor.
2784         <section_maps>: Change type to
2785         std::unique_ptr<arm_mapping_symbol_vec[]>.
2786         (arm_compare_mapping_symbols): Remove.
2787         (arm_find_mapping_symbol): Adjust to section_maps type change.
2788         (arm_objfile_data_free): Call delete on arm_per_objfile.
2789         (arm_record_special_symbol): Adjust to section_maps type change.
2790         Allocate arm_per_objfile with new.
2791
2792 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2793
2794         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2795         with the command prefix.
2796
2797 2019-06-25  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2800         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2801
2802 2019-06-25  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2805         type.
2806         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2807         protected.
2808
2809 2019-06-25  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-winsource.c
2812         (tui_source_window_base::set_is_exec_point_at): Add check against
2813         LOA_ADDRESS.
2814
2815 2019-06-25  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-source.c (tui_set_source_content): Don't check before
2818         xfree.
2819         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2820
2821 2019-06-25  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-winsource.h (tui_update_source_window_as_is)
2824         (tui_alloc_source_buffer, tui_line_is_displayed)
2825         (tui_addr_is_displayed): Change type of win_info.
2826         * tui/tui-winsource.c (tui_update_source_window_as_is)
2827         (tui_clear_source_content, tui_show_source_line)
2828         (tui_show_source_content, tui_source_window_base::refill)
2829         (tui_source_window_base::set_is_exec_point_at)
2830         (tui_source_window_base::set_is_exec_point_at)
2831         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2832         (tui_alloc_source_buffer, tui_line_is_displayed)
2833         (tui_addr_is_displayed): Change type of win_info.  Update.
2834         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2835         (tui_source_window_base::do_make_visible_with_new_height):
2836         Update.
2837         * tui/tui-source.c (tui_set_source_content)
2838         (tui_set_source_content_nil)
2839         (tui_source_window::do_scroll_vertical): Update.
2840         * tui/tui-layout.c (show_layout): Update.
2841         * tui/tui-disasm.c (tui_set_disassem_content)
2842         (tui_disasm_window::do_scroll_vertical): Update.
2843         * tui/tui-data.h (tui_win_content): Remove.
2844         (struct tui_gen_win_info) <content, content_size>: Remove.
2845         (struct tui_source_element): Add initializers and destructor.
2846         (union tui_which_element, struct tui_win_element): Remove.
2847         (struct tui_source_window_base) <content>: New field.
2848         (struct tui_data_window): Remove destructor.
2849         (tui_alloc_content, tui_free_win_content)
2850         (tui_free_all_source_wins_content): Don't declare.
2851         * tui/tui-data.c (tui_initialize_static_data): Update.
2852         (init_content_element, tui_alloc_content): Remove.
2853         (~tui_gen_win_info): Update.
2854         (~tui_data_window, tui_free_all_source_wins_content)
2855         (tui_free_win_content, free_content, free_content_elements):
2856         Remove.
2857
2858 2019-06-25  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-winsource.h (tui_clear_source_content)
2861         (tui_erase_source_content, tui_show_source_content): Change type
2862         of win_info.
2863         * tui/tui-winsource.c (tui_clear_source_content)
2864         (tui_erase_source_content, tui_show_source_content): Change type
2865         of win_info.
2866         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2867         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2868         win_info.
2869         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2870         win_info.
2871         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2872
2873 2019-06-25  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-winsource.c (tui_clear_source_content)
2876         (tui_source_window_base::set_is_exec_point_at): Update.
2877         * tui/tui-source.c (tui_set_source_content_nil): Update.
2878         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2879         a bool.
2880         * tui/tui-data.c (init_content_element): Update.
2881
2882 2019-06-25  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2885         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2886         * tui/tui-layout.c (init_and_make_win): Update.
2887         * tui/tui.h (enum tui_win_type): Update.
2888         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2889         tui_win_is_auxillary.
2890         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2891         tui_win_is_auxillary.
2892
2893 2019-06-25  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2896         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2897         (tui_delete_data_content_windows, tui_display_all_data)
2898         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2899         Update.
2900         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2901         * tui/tui-regs.c (tui_last_regs_line_no)
2902         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2903         (tui_show_registers): Update.
2904         (tui_show_register_group): Return void.  Update.
2905         (tui_display_registers_from, tui_display_reg_element_at_line)
2906         (tui_display_registers_from_line, tui_check_register_values):
2907         Update.
2908         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2909         member.
2910         (struct tui_data_window) <regs_content>: Now a std::vector.
2911         <regs_content_count>: Remove.
2912         (tui_add_content_elements, tui_free_data_content): Don't declare.
2913         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2914         (init_content_element): Remove DATA_WIN case.  Add assert.
2915         (tui_add_content_elements): Remove.
2916         (tui_data_window): Update.
2917         (tui_free_data_content): Remove.
2918         (free_content_elements): Remove DATA_WIN case.
2919
2920 2019-06-25  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-data.c (tui_data_item_window): Update.
2923         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2924         * tui/tui-windata.c (tui_display_all_data)
2925         (tui_display_data_from_line): Update.
2926         (tui_check_data_values): Remove.
2927         * tui/tui-regs.c (tui_show_register_group)
2928         (tui_display_reg_element_at_line): Update.
2929         * tui/tui-hooks.c (tui_register_changed)
2930         (tui_refresh_frame_and_register_information): Call
2931         tui_check_register_values.
2932         * tui/tui-data.h (struct tui_data_window) <data_content,
2933         data_content_count, data_type>: Remove.
2934         (enum tui_data_type): Remove.
2935
2936         * tui/tui-data.c (tui_data_window::clear_detail)
2937         (~tui_data_window): Update.
2938
2939 2019-06-25  Tom Tromey  <tom@tromey.com>
2940
2941         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2942         declare.
2943         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2944         Rename from tui_first_data_item_displayed.  Update.
2945         (tui_data_window::refresh_all)
2946         (tui_data_window::do_scroll_vertical): Update.
2947         * tui/tui-data.h (struct tui_data_window)
2948         <first_data_item_displayed>: Declare new method.
2949
2950 2019-06-25  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2953         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2954         contents...
2955         (tui_initialize_static_data): ...here.
2956
2957 2019-06-25  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2960         (tui_display_registers_from, tui_check_register_values): Update.
2961         (tui_display_register): Remove win_info parameter; update.
2962         (tui_get_register): Change type of parameters.
2963         * tui/tui-data.h (struct tui_data_element): Remove.
2964         (union tui_which_element) <data>: Remove.
2965         <data_window>: Change type.
2966         (struct tui_data_item_window): New.
2967         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2968         case.  Add assert.
2969         (~tui_data_item_window): New destructor.
2970         (free_content_elements): Remove DATA_ITEM_WIN case.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2975         Remove.
2976
2977 2019-06-25  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-data.h (struct tui_command_element): Remove.
2980         (union tui_which_element) <command>: Remove.
2981         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2982         assert.
2983         (free_content_elements): Remove CMD_WIN case.
2984
2985 2019-06-25  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-layout.c (tui_set_layout): Update.
2988         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2989         * tui/tui-data.c (layout_def): Update.
2990
2991 2019-06-25  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2994         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2995         (tui_source_window_base::set_new_height): Update.
2996         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2997         Update.
2998         (tui_set_locator_fullname, tui_set_locator_info)
2999         (tui_show_frame_info): Update.
3000         * tui/tui-source.c (tui_set_source_content)
3001         (tui_source_is_displayed): Update.
3002         * tui/tui-layout.c (show_source_disasm_command, show_data)
3003         (show_source_or_disasm_and_command): Update.
3004         * tui/tui-disasm.c (tui_set_disassem_content)
3005         (tui_get_begin_asm_address): Update.
3006         * tui/tui-data.h (struct tui_locator_element): Remove.
3007         (union tui_which_element) <locator>: Remove.
3008         (struct tui_locator_window): New.
3009         (tui_locator_win_info_ptr): Change return type.
3010         * tui/tui-data.c (_locator): Change type.
3011         (tui_locator_win_info_ptr): Change return type.
3012         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3013         (tui_alloc_content): Add assert.
3014
3015 2019-06-25  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-winsource.c
3018         (tui_exec_info_window::maybe_allocate_content): New method.
3019         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3020         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3021         (make_source_or_disasm_window): Add cast.
3022         * tui/tui-data.h (union tui_which_element) <simple_string>:
3023         Remove.
3024         (struct tui_source_info): New.
3025         (struct tui_source_window_base) <execution_info>: Change type.
3026         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3027         case, and add assert.
3028         (tui_alloc_content): Add assert.
3029
3030 2019-06-25  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3033         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3034         * tui/tui-data.c (tui_alloc_win_info): Remove.
3035
3036 2019-06-25  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3039         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3040         can_highlight.
3041
3042 2019-06-25  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3045         make_visible_with_new_height method.
3046         (tui_win_info::make_visible_with_new_height): New method.
3047         (tui_source_window_base::do_make_visible_with_new_height)
3048         (tui_data_window::do_make_visible_with_new_height)
3049         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3050         (make_visible_with_new_height): Remove.
3051         (tui_resize_all, tui_adjust_win_heights): Use
3052         make_visible_with_new_height method.
3053         * tui/tui-data.h (struct tui_win_info)
3054         <do_make_visible_with_new_height, make_visible_with_new_height>:
3055         New methods.
3056         (struct tui_source_window_base, struct tui_data_window)
3057         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3058         methods.
3059
3060 2019-06-25  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3063         method.
3064         (update_tab_width): Call update_tab_width method.
3065         * tui/tui-data.h (struct tui_win_info)
3066         (struct tui_source_window_base) <update_tab_width>: New methods.
3067
3068 2019-06-25  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3071         parameter.
3072         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3073         parameter.
3074         (tui_gen_win_info::make_visible): Update.
3075         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3076         parameter.
3077         * tui/tui-data.h (enum tui_box): New enum.
3078         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3079
3080 2019-06-25  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3083         init_and_make_win for EXEC_INFO_WIN.
3084         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3085         longer inline.
3086         (struct tui_win_info) <~tui_win_info>: Inline.
3087         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3088         Don't declare.
3089         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3090         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3091         Remove.
3092         (tui_initialize_static_data): Update.
3093         (~tui_gen_win_info): Handle more cleanup here.
3094         (~tui_source_window_base): Delete "execution_info".
3095         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3096
3097 2019-06-25  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-layout.c (make_command_window): Don't set
3100         can_highlight.
3101         (show_source_disasm_command): Call the reset method.
3102         (show_data): Don't set can_highlight.  Call the reset method.
3103         (tui_gen_win_info::reset): Rename from init_gen_win_info
3104         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3105         (show_source_or_disasm_and_command): Call the reset method.
3106         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3107         (struct tui_cmd_window): Set can_highlight.
3108
3109 2019-06-25  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3112         from make_visible.
3113         (tui_make_visible, tui_make_invisible): Rewrite.
3114         (tui_win_info::make_visible): Remove.
3115         (tui_source_window_base::make_visible): Update.
3116         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3117         method.  Moved from...
3118         (struct tui_win_info) <make_visible>: ...here.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-winsource.c
3123         (tui_source_window_base::do_scroll_horizontal): Remove direction
3124         parameter.
3125         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3126         direction parameter.
3127         * tui/tui-win.c (tui_win_info::forward_scroll)
3128         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3129         (tui_win_info::right_scroll): Update.
3130         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3131         direction parameter.
3132         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3133         direction parameter.
3134         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3135         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3136         Remove direction parameter.
3137         (struct tui_source_window_base, struct tui_source_window)
3138         (struct tui_disasm_window, struct tui_data_window)
3139         (struct tui_cmd_window): Update.
3140
3141 2019-06-25  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-winsource.h (tui_set_exec_info_content)
3144         (tui_show_exec_info_content, tui_erase_exec_info_content)
3145         (tui_clear_exec_info_content, tui_update_exec_info): Change
3146         argument to tui_source_window_base.
3147         * tui/tui-winsource.c (tui_set_exec_info_content)
3148         (tui_show_exec_info_content, tui_erase_exec_info_content)
3149         (tui_clear_exec_info_content, tui_update_exec_info): Change
3150         argument to tui_source_window_base.
3151
3152 2019-06-25  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3155         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3156
3157 2019-06-25  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3160         check.
3161
3162 2019-06-25  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3165         type to void.
3166         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3167         type to void.
3168         * tui/tui-source.c (tui_set_source_content): Update.
3169         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3170
3171 2019-06-25  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-win.c (window_name_completer, tui_set_focus)
3174         (tui_all_windows_info): Use name method.
3175         * tui/tui-data.h (struct tui_gen_win_info)
3176         (struct tui_source_window, struct tui_disasm_window)
3177         (struct tui_data_window, struct tui_cmd_window) <name>: New
3178         method.
3179         (tui_win_name): Don't declare.
3180         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3181         (tui_win_name): Remove.
3182
3183 2019-06-25  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-winsource.h (tui_update_source_window)
3186         (tui_update_source_window_as_is): Change parameter type.
3187         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3188         to be a tui_source_window_base.
3189         (tui_update_source_window_as_is): Likewise.
3190         * tui/tui-win.c (make_visible_with_new_height): Update.
3191
3192 2019-06-25  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-winsource.c (tui_erase_source_content)
3195         (tui_show_source_content, tui_show_exec_info_content)
3196         (tui_erase_exec_info_content): Use refresh_window method.
3197         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3198         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3199         from tui_refresh_win.
3200         (tui_data_window::refresh_window): New method.
3201         (tui_win_info::refresh, tui_source_window_base::refresh)
3202         (tui_refresh_all): Use refresh_window method.
3203         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3204         method.
3205         * tui/tui-regs.c (tui_display_register): Call refresh_window
3206         method.
3207         * tui/tui-layout.c (show_source_disasm_command)
3208         (show_source_or_disasm_and_command): Call refresh_window method.
3209         * tui/tui-data.h (struct tui_gen_win_info)
3210         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3211         New method.
3212
3213 2019-06-25  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui.c (tui_rl_other_window, tui_enable)
3216         (tui_is_window_visible, tui_get_command_dimension): Update.
3217         * tui/tui-winsource.c (tui_update_source_window_as_is)
3218         (tui_clear_source_content, tui_erase_source_content)
3219         (tui_show_source_line, tui_source_window_base::refill)
3220         (tui_source_window_base::do_scroll_horizontal)
3221         (tui_source_window_base::set_is_exec_point_at)
3222         (tui_update_breakpoint_info, tui_set_exec_info_content)
3223         (tui_alloc_source_buffer, tui_line_is_displayed)
3224         (tui_addr_is_displayed): Update.
3225         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3226         (tui_check_and_display_highlight_if_needed)
3227         (tui_win_info::make_visible, tui_win_info::refresh)
3228         (tui_refresh_all): Update.
3229         * tui/tui-windata.c (tui_first_data_item_displayed)
3230         (tui_delete_data_content_windows, tui_erase_data_content)
3231         (tui_display_all_data, tui_data_window::refresh_all)
3232         (tui_check_data_values): Update.
3233         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3234         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3235         (tui_win_info::backward_scroll, tui_refresh_all_win)
3236         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3237         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3238         (tui_source_window_base::set_new_height)
3239         (tui_data_window::set_new_height)
3240         (make_invisible_and_set_new_height)
3241         (make_visible_with_new_height, new_height_ok)
3242         (parse_scrolling_args): Update.
3243         * tui/tui-stack.c (tui_show_frame_info): Update.
3244         * tui/tui-source.c (tui_set_source_content)
3245         (tui_set_source_content_nil, tui_source_is_displayed)
3246         (tui_source_window::do_scroll_vertical): Update.
3247         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3248         (tui_display_registers_from, tui_display_reg_element_at_line)
3249         (tui_check_register_values, tui_reg_command): Update.
3250         * tui/tui-layout.c (tui_default_win_height)
3251         (show_source_disasm_command, show_data, init_and_make_win)
3252         (show_source_or_disasm_and_command): Update.
3253         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3254         (tui_redisplay_readline, tui_mld_flush)
3255         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3256         (tui_getc): Update.
3257         * tui/tui-disasm.c (tui_set_disassem_content)
3258         (tui_disasm_window::do_scroll_vertical): Update.
3259         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3260         Now virtual.
3261         (struct tui_win_info): Derive from tui_gen_win_info.
3262         <~tui_win_info>: Mark as override.
3263         <generic>: Remove member.
3264         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3265         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3266         (~tui_data_window, ~tui_win_info)
3267         (tui_free_all_source_wins_content): Update.
3268         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3269
3270 2019-06-25  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-layout.c (init_and_make_win): Use new.
3273         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3274         destructor, initializers.
3275         (tui_alloc_generic_win_info): Don't declare.
3276         * tui/tui-data.c (_locator): Add argument to constructor.
3277         (source_win, disasm_win): New globals.
3278         (exec_info): Remove.
3279         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3280         Update.
3281         (tui_alloc_generic_win_info): Remove.
3282         (init_content_element): Use new.
3283         (tui_win_info::tui_win_info): Update.
3284         (free_content_elements) <case DATA_WIN>: Use delete.
3285
3286 2019-06-25  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3289         * tui/tui-windata.c (tui_first_data_item_displayed)
3290         (tui_delete_data_content_windows): Update.
3291         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3292         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3293         (tui_display_registers_from, tui_check_register_values): Update.
3294         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3295         pointer.
3296         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3297         window.
3298         (tui_free_data_content): Update.
3299         (free_content_elements) <case DATA_WIN>: Free the window.
3300
3301 2019-06-25  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3304         Update.
3305         * tui/tui-layout.c (make_command_window)
3306         (show_source_disasm_command, show_data, init_and_make_win)
3307         (show_source_or_disasm_and_command): Update.
3308         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3309         method.
3310         <can_highight, is_highlighted>: Now bool.
3311         (tui_set_win_highlight): Don't declare.
3312         * tui/tui-data.c (tui_set_win_highlight): Remove.
3313
3314 2019-06-25  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-wingeneral.c (make_visible): Remove check of window
3317         type.
3318
3319 2019-06-25  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-win.c (tui_win_info::max_height)
3322         (tui_cmd_window::max_height): New methods.
3323         (new_height_ok): Call max_height.
3324         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3325         <max_height>: New method.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-win.c (tui_source_window_base::set_new_height)
3330         (tui_data_window::set_new_height): New methods.
3331         (make_invisible_and_set_new_height): Call set_new_height method.
3332         * tui/tui-data.h (struct tui_win_info)
3333         (struct tui_source_window_base, struct tui_data_window)
3334         <set_new_height>: New method.
3335
3336 2019-06-25  Tom Tromey  <tom@tromey.com>
3337
3338         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3339         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3340         tui_refresh_data_win.
3341         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3342         method.
3343         (tui_refresh_all_win): Call the refresh_all method.
3344         (tui_set_focus): Likewise.
3345         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3346         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3347         Likewise.
3348
3349 2019-06-25  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-winsource.h (tui_refill_source_window)
3352         (tui_set_is_exec_point_at): Don't declare.
3353         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3354         (tui_source_window_base::refill): Rename from
3355         tui_refill_source_window.
3356         (tui_source_window_base::do_scroll_horizontal): Update.
3357         (tui_source_window_base::set_is_exec_point_at): Rename from
3358         tui_set_is_exec_point_at.
3359         (tui_update_all_breakpoint_info): Update.
3360         * tui/tui-stack.c (tui_show_frame_info): Update.
3361         * tui/tui-layout.c (show_data): Add cast.
3362         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3363         * tui/tui-data.h (struct tui_source_window_base) <refill,
3364         set_is_exec_point_at>: New methods.
3365         (tui_source_windows, tui_add_to_source_windows): Update types.
3366         (tui_add_to_source_windows): Remove redundant declaration.
3367         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3368         (tui_source_windows): Change return type.
3369         (tui_clear_source_windows_detail): Update.
3370         (tui_add_to_source_windows): Change type of parameter.
3371         (tui_free_all_source_wins_content): Update.
3372
3373 2019-06-25  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-wingeneral.c (tui_win_info::refresh)
3376         (tui_source_window_base::refresh): New methods.
3377         (tui_refresh_all): Call the refresh method.
3378         * tui/tui-data.h (struct tui_win_info)
3379         (struct tui_source_window_base) <refresh>: New method.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui.h (tui_is_window_visible): Return bool.
3384         * tui/tui.c (tui_is_window_visible): Return bool.
3385         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3386         (tui_make_visible, tui_make_invisible)
3387         (tui_win_info::make_visible)
3388         (tui_source_window_base::make_visible, make_all_visible)
3389         (tui_make_all_visible, tui_make_all_invisible): Update.
3390         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3391         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3392         bool.
3393         (struct tui_win_info, struct tui_source_window_base)
3394         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3395         * tui/tui-data.c (tui_init_generic_part): Update.
3396
3397 2019-06-25  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3400         (tui_source_window_base::make_visible): New methods.
3401         (make_all_visible): Make method call.
3402         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3403         (struct tui_source_window_base, struct tui_cmd_window): Override
3404         make_visible.
3405         (tui_win_is_source_type): Don't declare.
3406         * tui/tui-data.c (tui_win_is_source_type): Remove.
3407
3408 2019-06-25  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3411         NULL check.
3412
3413 2019-06-25  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3416         Inline constructor.  Add initializers for members.
3417         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3418         constructors; now inline in class.
3419
3420 2019-06-25  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-regs.c (tui_show_registers): Update.
3423         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3424         bool.
3425         * tui/tui-data.c (tui_data_window::clear_detail)
3426         (tui_data_window): Update.
3427
3428 2019-06-25  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-windata.c (tui_display_all_data)
3431         (tui_display_data_from_line, tui_display_data_from)
3432         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3433         Update.
3434         * tui/tui-regs.c (tui_last_regs_line_no)
3435         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3436         (tui_show_registers, tui_show_register_group)
3437         (tui_display_registers_from, tui_display_reg_element_at_line)
3438         (tui_display_registers_from_line, tui_check_register_values)
3439         (tui_reg_next, tui_reg_prev): Update.
3440         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3441         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3442         tui_data_window.
3443         (struct tui_win_info) <detail>: Remove.  Add new fields from
3444         tui_data_info.
3445         (TUI_DATA_WIN): Add cast.
3446         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3447         (~tui_data_window): Simplify.
3448
3449 2019-06-25  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-layout.c (show_source_disasm_command)
3452         (show_source_or_disasm_and_command): Update.
3453         * tui/tui-io.c (update_cmdwin_start_line)
3454         (tui_redisplay_readline): Update.
3455         * tui/tui-data.h (struct tui_command_info): Remove.
3456         (struct tui_win_info) <detail>: Remove command_info member.
3457         (struct tui_data_window) <start_line>: New member, from
3458         tui_command_info.
3459         (TUI_CMD_WIN): Add casts.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-winsource.c (tui_update_source_window)
3464         (tui_refill_source_window)
3465         (tui_source_window_base::do_scroll_horizontal)
3466         (tui_update_breakpoint_info, tui_set_exec_info_content)
3467         (tui_show_exec_info_content, tui_erase_exec_info_content)
3468         (tui_clear_exec_info_content): Update.
3469         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3470         Update.
3471         * tui/tui-win.c (make_invisible_and_set_new_height)
3472         (make_visible_with_new_height): Update.
3473         * tui/tui-source.c (tui_set_source_content)
3474         (tui_show_symtab_source): Update.
3475         * tui/tui-layout.c (extract_display_start_addr)
3476         (show_source_disasm_command, show_data)
3477         (make_source_or_disasm_window)
3478         (show_source_or_disasm_and_command): Update.
3479         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3480         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3481         "gdbarch".
3482         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3483         to tui_source_window_base.
3484         (struct tui_win_info) <detail>: Remove source_info member.
3485         (struct tui_source_window_base) <has_locator>: Inline.
3486         Move contents from tui_source_info; rename has_locator member to
3487         m_has_locator.
3488         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3489         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3490         header file.
3491         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3492         Simplify.
3493         (tui_free_all_source_wins_content): Cast to
3494         tui_source_window_base.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-win.c (make_invisible_and_set_new_height)
3499         (make_visible_with_new_height): Call has_locator method.
3500         * tui/tui-layout.c (show_source_disasm_command, show_data)
3501         (show_source_or_disasm_and_command): Update for bool change.
3502         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3503         (tui_win_info) <has_locator>: New method.
3504         (struct tui_source_window_base) <has_locator>: New method.
3505         (tui_win_has_locator): Don't declare.
3506         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3507         from tui_win_has_locator.
3508         (tui_source_window_base): Use false, not FALSE.
3509
3510 2019-06-25  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3513         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3514         clear_detail method directly.
3515         (tui_clear_win_detail): Remove.
3516
3517 2019-06-25  Tom Tromey  <tom@tromey.com>
3518
3519         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3520         "this", not TUI_DISASM_WIN.
3521
3522 2019-06-25  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3525         declare.
3526         * tui/tui-winsource.c
3527         (tui_source_window_base::do_scroll_horizontal): Rename from
3528         tui_horizontal_source_scroll.
3529         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3530         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3531         from tui_vertical_data_scroll.
3532         * tui/tui-win.h (tui_scroll): Don't declare.
3533         * tui/tui-win.c (tui_win_info::forward_scroll)
3534         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3535         (tui_win_info::right_scroll): Rename and update.
3536         (tui_scroll_forward_command, tui_scroll_backward_command)
3537         (tui_scroll_left_command, tui_scroll_right_command): Update.
3538         (tui_scroll): Remove.
3539         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3540         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3541         from tui_vertical_source_scroll.
3542         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3543         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3544         from tui_vertical_disassem_scroll.
3545         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3546         do_scroll_horizontal>: New methods.
3547         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3548         Likewise.
3549         (struct tui_source_window_base): Add do_scroll_horizontal.
3550         (struct tui_source_window, struct tui_disasm_window): Add
3551         do_scroll_vertical.
3552         (struct tui_data_window, struct tui_cmd_window): Add
3553         do_scroll_horizontal and do_scroll_vertical.
3554         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3555
3556 2019-06-25  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-data.h (struct tui_source_window_base): New struct.
3559         (struct tui_source_window): Derive from tui_source_window_base.
3560         (struct tui_disasm_window): New struct.
3561         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3562         from tui_source_window::clear_detail.
3563         (tui_source_window_base): Rename from tui_source_window.
3564         (~tui_source_window_base): Rename from ~tui_source_window.
3565         (tui_alloc_win_info): Create a tui_disasm_window.
3566
3567 2019-06-25  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-data.h (struct tui_source_window)
3570         (struct tui_data_window): Declare destructors.
3571         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3572         destructors.
3573         (tui_win_info): Simplify.
3574
3575 2019-06-25  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-winsource.c (tui_display_main)
3578         (tui_update_source_windows_with_addr)
3579         (tui_update_all_breakpoint_info): Update.
3580         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3581         (new_height_ok, parse_scrolling_args): Update.
3582         * tui/tui-stack.c (tui_show_frame_info): Update.
3583         * tui/tui-data.h (struct tui_list): Remove.
3584         (tui_source_windows): Return a reference to a std::vector.
3585         * tui/tui-data.c (source_windows): Now a std::vector.
3586         (tui_source_windows): Change return type.
3587         (tui_clear_source_windows): Rewrite.
3588         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3589         (tui_free_all_source_wins_content): Rewrite.
3590
3591 2019-06-25  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3594         (struct tui_data_window, struct tui_cmd_window): Declare
3595         clear_detail method.
3596         * tui/tui-data.c (tui_source_window::clear_detail)
3597         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3598         methods.
3599         (tui_clear_win_detail): Simplify.
3600
3601 2019-06-25  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-layout.c (make_source_window, make_disasm_window)
3604         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3605         Return the new window.
3606         (show_source_disasm_command, show_data)
3607         (show_source_or_disasm_and_command): Update.
3608
3609 2019-06-25  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3612         parameter.  Return the new window.
3613         (show_source_disasm_command): Update and remove NULL check.
3614         (show_source_or_disasm_and_command): Update.
3615
3616 2019-06-25  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3619
3620 2019-06-25  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-data.h (struct tui_win_info): Make constructor
3623         protected.  Make destructor virtual.  Add initializers.
3624         (tui_source_window, tui_data_window, tui_cmd_window): New
3625         classes.
3626         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3627         constructor.  Add "type" parameter.
3628         (tui_source_window, tui_data_window, tui_cmd_window): New
3629         constructors.
3630         (tui_alloc_win_info): Instantiate the appropriate subclass.
3631
3632 2019-06-25  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-win.c (tui_resize_all): Use delete.
3635         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3636         destructor.
3637         (tui_free_window): Don't declare.
3638         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3639         Update.
3640
3641 2019-06-25  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-data.h (struct tui_win_info): Add constructor.
3644         * tui/tui-data.c (tui_alloc_win_info): Use new.
3645         (tui_free_window): Use delete.
3646
3647 2019-06-22  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3650         declare.
3651         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3652
3653 2019-06-22  Tom Tromey  <tom@tromey.com>
3654
3655         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3656         declare.
3657         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3658
3659 2019-06-22  Tom de Vries  <tdevries@suse.de>
3660
3661         * dwarf2read.c (create_addrmap_from_aranges)
3662         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3663         instead of '%zu'.
3664
3665 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3666
3667         * dwarf2read.h (dwarf2_section_info_def): Remove.
3668         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3669         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3670         std::vector<dwarf2_section_info>.
3671         (struct dwo_file) <~dwo_file>: Remove.
3672         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3673         types field.
3674         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3675         (dwarf2_read_debug_names): Likewise.
3676         (create_debug_types_hash_table): Change parameter type to
3677         array_view, adjust code accordingly.
3678         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3679         (partial_die_info::fixup): Likewise.
3680         (determine_prefix): Likewise.
3681         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3682
3683 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3684
3685         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3686         gdb_bfd_ref_ptr.
3687         <~dwo_file>: Remove call to gdb_bfd_unref.
3688         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3689         gdb_bfd_ref_ptr::get.
3690
3691 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3692
3693         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3694         type to htab_up.
3695         * dwarf2read.c (struct dwo_file): Initialize fields.
3696         <~dwo_file>: New.
3697         (free_dwo_file): Remove, move content to ~dwo_file.
3698         (struct dwo_file_deleter): Remove.
3699         (dwo_file_up>: Remove custom deleter.
3700         (free_dwo_files): Remove.
3701         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3702         dwo_files.
3703         (process_skeletonless_type_units): Call unique_ptr::get.
3704         (allocate_dwo_file_hash_table): Add deleter to created hash
3705         table.  Change return type to htab_up.
3706         (lookup_dwo_file_slot): Don't memset dwo_file, call
3707         unique_ptr::get.
3708         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3709         (create_dwo_unit_in_dwp_v2): Likewise.
3710         (open_and_init_dwo_file): Likewise.
3711         (free_dwo_file_from_slot): Remove.
3712
3713 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3714
3715         * dwarf2read.h (struct dwarf2_section_info) <readin,
3716         is_virtual>: Change type to bool.
3717         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3718         true instead of 1.
3719
3720 2019-06-19  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-data.h (tui_init_content_element): Don't declare.
3723
3724 2019-06-19  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-data.h (tui_init_win_info): Don't declare.
3727
3728 2019-06-19  Tom de Vries  <tdevries@suse.de>
3729
3730         * dwarf2read.h (abstract_to_concrete): Change type to
3731         std::unordered_map<sect_offset, std::vector<sect_offset>,
3732         gdb::hash_enum<sect_offset>>.
3733
3734 2019-06-19  Tom Tromey  <tromey@adacore.com>
3735
3736         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3737         EVAL_AVOID_SIDE_EFFECTS specially.
3738
3739 2019-06-19  Tom Tromey  <tromey@adacore.com>
3740
3741         * source-cache.c (highlighter): New global.
3742         (source_cache::get_source_lines): Create a highlighter on demand.
3743
3744 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * defs.h (deprecated_interactive_hook): Delete declaration.
3747         * interps.c (clear_interpreter_hooks): Remove use of
3748         deprecated_interactive_hook.
3749         * top.c (deprecated_interactive_hook): Delete definition.
3750         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3751
3752 2019-06-18  Tom de Vries  <tdevries@suse.de>
3753
3754         PR gdb/24515
3755         * dwarf2read.h (abstract_to_concrete): Change type from
3756         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3757         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3758         * dwarf2read.c (read_variable): Update.
3759         (dwarf2_fetch_die_loc_sect_off): Update.
3760
3761 2019-06-17  Tom de Vries  <tdevries@suse.de>
3762
3763         PR gdb/24617
3764         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3765         accessing parent[parent_len - 1].
3766
3767 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3768
3769         PR gdb/24364
3770         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3771         call dtrace_process_dof with NULL dof.
3772
3773 2019-06-16  Tom de Vries  <tdevries@suse.de>
3774
3775         PR gdb/24445
3776         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3777
3778 2019-06-16  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3781         (make_all_visible): Use address of member.
3782
3783 2019-06-16  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3786         (tui_free_window, free_content, free_content_elements): Remove
3787         unnecessary cast.
3788         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3789         cast.
3790         * tui/tui-regs.c (tui_show_register_group)
3791         (tui_display_registers_from, tui_display_reg_element_at_line):
3792         Remove unnecessary cast.
3793
3794 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * linux-nat.c (normal_mask): Delete.
3797         (_initialize_linux_nat): Don't initialise normal_mask.
3798
3799 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3800
3801         PR gdb/24445
3802         * dwarf-index-write.h (write_psymtabs_to_index): Add
3803         dwz_basename parameter.
3804         * dwarf-index-write.c (write_gdbindex): Move file writing to
3805         write_gdbindex_1.  Change return type void.
3806         (assert_file_size): Move up, remove filename parameter.
3807         (write_gdbindex_1): New function.
3808         (write_debug_names): Change return type to void, call
3809         assert_file_size.
3810         (struct index_wip_file): New struct.
3811         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3812         file logic to index_wip_file.  Write index for dwz file if
3813         needed.
3814         (save_gdb_index_command): Pass basename of dwz file, if present.
3815         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3816         build-id of dwz file, if present.
3817         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3818         (dwarf2_get_dwz_file): Likewise.
3819         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3820         (dwarf2_get_dwz_file): Likewise.
3821
3822 2019-06-16  Tom Tromey  <tom@tromey.com>
3823
3824         * coffread.c (process_coff_symbol): Use xstrdup.
3825         * value.c (create_internalvar): Use xstrdup.
3826
3827 2019-06-16  Tom Tromey  <tom@tromey.com>
3828
3829         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3830         * breakpoint.c (stopin_command, stopat_command)
3831         (until_break_command, decode_location_default): Remove unnecessary
3832         cast.
3833         * utils.c (subset_compare): Remove unnecessary cast.
3834         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3835         cast.
3836         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3837         cast.
3838         * infcmd.c (path_command): Remove unnecessary cast.
3839         * coffread.c (decode_type): Remove unnecessary cast.
3840         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3841         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3842         * tui/tui-stack.c (tui_show_locator_content)
3843         (tui_show_frame_info): Remove unnecessary cast.
3844         * tui/tui-win.c (tui_scroll_forward_command)
3845         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3846         (parse_scrolling_args): Remove unnecessary cast.
3847         * tui/tui-data.c (init_win_info, tui_del_window)
3848         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3849         (free_content_elements): Remove unnecessary cast.
3850         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3851         unnecessary cast.
3852         * tui/tui-source.c (tui_set_source_content)
3853         (tui_vertical_source_scroll): Remove unnecessary cast.
3854         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3855         cast.
3856         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3857         * tui/tui-regs.c (tui_display_registers_from)
3858         (tui_display_register): Remove unnecessary cast.
3859         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3860         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3861         (make_visible): Remove unnecessary cast.
3862         * tui/tui-winsource.c (tui_erase_source_content)
3863         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3864         unnecessary cast.
3865         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3866         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3867         * stabsread.c (read_type, read_array_type, read_range_type):
3868         Remove unnecessary cast.
3869         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3870         (parse_symbol, parse_type, upgrade_type, parse_external)
3871         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3872         unnecessary cast.
3873         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3874
3875 2019-06-16  Tom Tromey  <tom@tromey.com>
3876
3877         * tui/tui-data.c (tui_alloc_generic_win_info)
3878         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3879         checks.
3880
3881 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3882             Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * f-typeprint.c (f_print_type): Don't return early for not
3885         associated or not allocated types.
3886         (f_type_print_varspec_suffix): Add print_rank parameter and print
3887         ranks of array types in case they dangling.
3888         (f_type_print_base): Add print_rank parameter.
3889
3890 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3891
3892         * NEWS: Mention new MI commands.
3893         * break-catch-throw.c (enum exception_event_kind): Move to
3894         breakpoint.h.
3895         (print_mention_exception_catchpoint): Output text as a single
3896         message.
3897         (catch_exception_command_1): Rename to...
3898         (catch_exception_event): ...this, make non-static, update header
3899         command, and change some parameter types.
3900         (catch_catch_command): Update for changes to
3901         catch_exception_command_1.
3902         (catch_throw_command): Likewise.
3903         (catch_rethrow_command): Likewise.
3904         * breakpoint.c (enum exception_event_kind): Delete.
3905         * breakpoint.h (enum exception_event_kind): Moved here from
3906         break-catch-throw.c.
3907         (catch_exception_event): Declare.
3908         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3909         (mi_cmd_catch_throw): New function.
3910         (mi_cmd_catch_rethrow): New function.
3911         (mi_cmd_catch_catch): New function.
3912         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3913         'catch-catch' entries.
3914         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3915         (mi_cmd_catch_rethrow): Declare.
3916         (mi_cmd_catch_catch): Declare.
3917
3918 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * annotate.c (annotate_source_line): Change return type to void,
3921         update implementation to match.
3922         * annotate.h (annotate_source_line): Change return type to void,
3923         update header comment.
3924         * stack.c (print_frame_info): Don't change what frame information
3925         is printed based on whether annotations are on or not.
3926
3927 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3928
3929         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3930         (annotate_source): Make static.
3931         (annotate_source_line): Moved from source.c and renamed from
3932         identify_source_line.  Update the return type.
3933         * annotate.h (annotate_source): Delete declaration.
3934         (annotate_source_line): Declaration moved from source.h, and
3935         renamed from identify_source_line.  Return type updated.
3936         * source.c (identify_source_line): Moved to annotate.c and renamed
3937         to annotate_source_line.
3938         (info_line_command): Remove check of annotation_level.
3939         * source.h (identify_source_line): Move declaration to annotate.h
3940         and rename to annotate_source_line.
3941         * stack.c: Add 'annotate.h' include.
3942         (print_frame_info): Remove check of annotation_level before
3943         calling annotate_source_line.
3944
3945 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * source-cache.c (source_cache::get_plain_source_lines): Use
3948         open_source_file_with_line_charpos instead of just
3949         open_source_file, remove call to find_source_lines.
3950         (source_cache::get_source_lines): Likewise.
3951         * source.c (find_source_lines): Make static.
3952         (get_filename_and_charpos): Renamed into...
3953         (open_source_file_with_line_charpos): ..this along with changes to
3954         return a scoped_fd, and some other minor clean ups.
3955         (identify_source_line): Use open_source_file_with_line_charpos.
3956         (search_command_helper): Use open_source_file_with_line_charpos
3957         instead of just open_source_file, remove call to
3958         find_source_lines.
3959         * source.h (open_source_file_with_line_charpos): Declare new
3960         function.
3961         (find_source_lines): Delete declaration.
3962
3963 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * source.c (get_filename_and_charpos): Remove fullname
3966         parameter.
3967         (identify_source_line): Update call to get_filename_and_charpos.
3968
3969 2019-06-14  Tom Tromey  <tromey@adacore.com>
3970
3971         PR gdb/24502:
3972         * ui-style.h (skip_ansi_escape): Update comment.
3973         * ui-file.h (class no_terminal_escape_file): New class.
3974         * ui-file.c (no_terminal_escape_file::write)
3975         (no_terminal_escape_file::puts): New methods.
3976         * cli/cli-logging.c (handle_redirections): Use
3977         no_terminal_escape_file.
3978
3979 2019-06-14  Tom Tromey  <tromey@adacore.com>
3980
3981         * NEWS: Move convenience variable news above Python news.
3982
3983 2019-06-14  Tom Tromey  <tom@tromey.com>
3984
3985         * gnulib: Move directory to top-level.
3986         * configure.ac: Don't configure gnulib.
3987         * configure: Rebuild.
3988         * common/common-defs.h: Use new path to gnulib.
3989         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3990         (GNULIB_H): Remove.
3991         (INCGNU): Look in new gnulib location.
3992         (HFILES_NO_SRCDIR): Remove gnulib files.
3993         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3994         (generated_files): Remove GNULIB_H.
3995         ($(LIBGNU), all-lib): Remove targets.
3996         (distclean): Don't mention GNULIB_BUILDDIR.
3997         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3998
3999 2019-06-14  Tom Tromey  <tromey@adacore.com>
4000
4001         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4002         Warn if symbol file does not provide any symbols.
4003
4004 2019-06-14  Tom Tromey  <tromey@adacore.com>
4005
4006         * source.c (find_and_open_source): Respect basenames_may_differ.
4007
4008 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * annotate.c (annotate_breakpoints_invalid): Make use of
4011         scoped_restore_terminal_state.
4012         (annotate_frames_invalid): Likewise.
4013
4014 2019-06-14  Tom Tromey  <tromey@adacore.com>
4015
4016         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4017         allow assignment to an internalvar.
4018
4019 2019-06-14  Tom Tromey  <tromey@adacore.com>
4020
4021         * ada-lex.l: Allow "_" in attribute names.
4022
4023 2019-06-14  Tom Tromey  <tromey@adacore.com>
4024
4025         PR gdb/24653:
4026         * regcache.c (registers_changed): Don't call alloca.
4027         * top.c (execute_command): Don't call alloca.
4028
4029 2019-06-13  Pedro Alves  <palves@redhat.com>
4030
4031         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4032         'expression'.  When parsing an expression, error out if there's
4033         junk after "unlimited".
4034         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4035         (do_set_command): Adjust calls to is_unlimited_literal.
4036
4037 2019-06-13  Pedro Alves  <palves@redhat.com>
4038
4039         * compile/compile.c (make_compile_options_def_group): Add braces
4040         around array_view initializer.
4041         * thread.c (make_thread_apply_all_options_def_group)
4042         (make_thread_apply_all_options_def_group): Likewise.
4043
4044 2019-06-13  Pedro Alves  <palves@redhat.com>
4045
4046         * NEWS (New commands): Mention "maint test-options
4047         require-delimiter", "maint test-options unknown-is-error", "maint
4048         test-options unknown-is-operand" and "maint show
4049         test-options-completion-result".
4050         (New command options, command completion): New section.
4051         (Completion improvements): New section.
4052         Mention that you can abbreviate "unlimited".
4053
4054 2019-06-13  Pedro Alves  <palves@redhat.com>
4055
4056         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4057         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4058         * unittests/cli-utils-selftests.c (test_parse_flags)
4059         (test_parse_flags_qcs): Delete.
4060         (test_cli_utils): Don't call deleted functions.
4061
4062 2019-06-13  Pedro Alves  <palves@redhat.com>
4063
4064         * thread.c: Include "cli/cli-option.h".
4065         (tp_array_compar_ascending): Global.
4066         (tp_array_compar): Delete function.
4067         (tp_array_compar_ascending, tp_array_compar_descending): New
4068         functions.
4069         (ascending_option_def, qcs_flag_option_def)
4070         (thr_qcs_flags_option_defs)
4071         (make_thread_apply_all_options_def_group)
4072         (make_thread_apply_options_def_group): New.
4073         (thread_apply_all_command): Use gdb::option::process_options.
4074         (thread_apply_command_completer)
4075         (thread_apply_all_command_completer): New.
4076         (thread_apply_command): Use gdb::option::process_options.
4077         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4078         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4079         to generate help text of "thread apply".  Adjust "taas"'s help.
4080         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4081         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4082
4083 2019-06-13  Pedro Alves  <palves@redhat.com>
4084
4085         * thread.c (thread_apply_command): Check for invalid TID with
4086         isdigit instead of !isalpha.
4087
4088 2019-06-13  Pedro Alves  <palves@redhat.com>
4089
4090         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4091         (validate_flags_qcs): New.
4092         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4093         (validate_flags_qcs): Declare.
4094         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4095         (make_frame_apply_options_def_group): New.
4096         (frame_apply_command_count): Process options with
4097         gdb::option::process_options.
4098         (frame_apply_completer): New.
4099         (frame_apply_level_completer, frame_apply_all_completer)
4100         (frame_apply_completer): New.
4101         (_initialize_stack): Update help of "frame apply", "frame apply
4102         level", "frame apply all" and "faas" to mention supported options
4103         and install command completers.
4104         * stack.h (frame_apply_all_completer): Declare.
4105         * thread.c: Include "stack.h".
4106         (tfaas_command): Add "--".
4107         (_initialize_thread): Update help "tfaas" to mention supported
4108         options and install command completer.
4109
4110 2019-06-13  Pedro Alves  <palves@redhat.com>
4111
4112         * completer.c (complete_nested_command_line): New.
4113         (gdb_completion_word_break_characters_throw): Add assertion.
4114         * completer.h (complete_nested_command_line): Declare.
4115
4116 2019-06-13  Pedro Alves  <palves@redhat.com>
4117
4118         * stack.c (parse_backtrace_qualifiers): New.
4119         (backtrace_command): Use it.
4120         (backtrace_command_completer): Complete on qualifiers.
4121
4122 2019-06-13  Pedro Alves  <palves@redhat.com>
4123
4124         * frame.c: Include "cli/cli-option.h.
4125         (user_set_backtrace_options): New.
4126         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4127         Delete.
4128         (get_prev_frame): Adjust.
4129         (boolean_option_def, uinteger_option_def)
4130         (set_backtrace_option_defs): New.
4131         (_initialize_frame): Adjust and use
4132         gdb::option::add_setshow_cmds_for_options to install "set
4133         backtrace past-main" and "set backtrace past-entry".
4134         * frame.h: Include "cli/cli-option.h".
4135         (struct frame_print_options): Forward declare.
4136         (print_frame_arguments_all, print_frame_arguments_scalars)
4137         (print_frame_arguments_none): Declare.
4138         (print_entry_values): Delete declaration.
4139         (struct frame_print_options, user_frame_print_options): New.
4140         (struct set_backtrace_options): New.
4141         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4142         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4143         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4144         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4145         (list_args_or_locals): Add frame_print_options parameter.
4146         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4147         * python/py-framefilter.c (enumerate_args): Pass down
4148         USER_FRAME_PRINT_OPTIONS.
4149         * stack.c: Include "cli/cli-option.h".
4150         (print_frame_arguments_all, print_frame_arguments_scalars)
4151         (print_frame_arguments_none): Declare.
4152         (print_raw_frame_arguments, print_entry_values): Delete.
4153         (user_frame_print_options): New.
4154         (boolean_option_def, enum_option_def, frame_print_option_defs):
4155         New.
4156         (struct backtrace_cmd_options): New.
4157         (bt_flag_option_def): New.
4158         (backtrace_command_option_defs): New.
4159         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4160         (print_frame_arg, read_frame_arg, print_frame_args)
4161         (print_frame_info, print_frame): Add frame_print_options parameter
4162         and use it.
4163         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4164         (backtrace_command_1): Add frame_print_options and
4165         backtrace_cmd_options parameters and use them.
4166         (make_backtrace_options_def_group): New.
4167         (backtrace_command): Process command options with
4168         gdb::option::process_options.
4169         (backtrace_command_completer): New.
4170         (_initialize_stack): Extend "backtrace"'s help to mention
4171         supported options.  Install completer for "backtrace".
4172         Install some settings commands with add_setshow_cmds_for_options.
4173
4174 2019-06-13  Pedro Alves  <palves@redhat.com>
4175
4176         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4177         and that "set/show print raw frame-arguments" are now deprecated.
4178
4179         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4180         command.
4181         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4182         * stack.c (_initialize_stack): Install "set/show print
4183         raw-frame-arguments", and deprecate "set/show print raw
4184         frame-arguments".
4185         * valprint.c (_initialize_valprint): Deprecate "set/show print
4186         raw".
4187
4188 2019-06-13  Pedro Alves  <palves@redhat.com>
4189
4190         * compile/compile.c (struct compile_options): New.
4191         (compile_flag_option_def, compile_command_option_defs)
4192         (make_compile_options_def_group): New.
4193         (compile_file_command): Handle options with
4194         gdb::option::process_options.
4195         (compile_file_command_completer): New function.
4196         (compile_code_command): Handle options with
4197         gdb::option::process_options.
4198         (compile_code_command_completer): New function.
4199         (_initialize_compiler): Install completers for "compile code" and
4200         "compile file".  Mention available options in "compile code" and
4201         "compile code"'s help.
4202         * completer.c (advance_to_completion_word): New, factored out from
4203         ...
4204         (advance_to_expression_complete_word_point): ... this.
4205         (advance_to_filename_complete_word_point): New.
4206         * completer.h (advance_to_filename_complete_word_point): New
4207         declaration.
4208
4209 2019-06-13  Pedro Alves  <palves@redhat.com>
4210
4211         * compile/compile.c: Include "cli/cli-option.h".
4212         (compile_print_value): Scope data pointer is now a
4213         value_print_options pointer; adjust.
4214         (compile_print_command): Process options.  Scope data pointer is
4215         now a value_print_options pointer; adjust.
4216         (_initialize_compile): Update "compile print"'s help to include
4217         supported options.  Install a completer for "compile print".
4218         * cp-valprint.c (show_vtblprint, show_objectprint)
4219         (show_static_field_print): Delete.
4220         (_initialize_cp_valprint): Don't install "set print
4221         static-members", "set print vtbl", "set print object" here.
4222         * printcmd.c: Include "cli/cli-option.h" and
4223         "common/gdb_optional.h".
4224         (print_command_parse_format): Rework to fill in a
4225         value_print_options instead of a format_data.
4226         (print_value): Change parameter type from format_data pointer to
4227         value_print_options reference.  Adjust.
4228         (print_command_1): Process options.  Adjust to pass down a
4229         value_print_options.
4230         (print_command_completer): New.
4231         (_initialize_printcmd): Install print_command_completer as
4232         handle_brkchars completer for the "print" command.  Update
4233         "print"'s help to include supported options.
4234         * valprint.c: Include "cli/cli-option.h".
4235         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4236         here from cp-valprint.c.
4237         (boolean_option_def, uinteger_option_def)
4238         (value_print_option_defs, make_value_print_options_def_group):
4239         New.  Use gdb::option::add_setshow_cmds_for_options to install
4240         "set print elements", "set print null-stop", "set print repeats",
4241         "set print pretty", "set print union", "set print array", "set
4242         print address", "set print symbol", "set print array-indexes".
4243         * valprint.h: Include <string> and "cli/cli-option.h".
4244         (make_value_print_options_def_group): Declare.
4245         (print_value): Change parameter type from format_data pointer to
4246         value_print_options reference.
4247         (print_command_completer): Declare.
4248
4249 2019-06-13  Pedro Alves  <palves@redhat.com>
4250
4251         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4252         (COMMON_SFILES): Add maint-test-settings.c.
4253         * cli/cli-decode.c (boolean_enums): New global, factored out from
4254         ...
4255         (add_setshow_boolean_cmd): ... here.
4256         * cli/cli-decode.h (boolean_enums): Declare.
4257         * cli/cli-option.c: New file.
4258         * cli/cli-option.h: New file.
4259         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4260         factored out from ...
4261         (parse_cli_boolean_value(const char *)): ... this.
4262         (is_unlimited_literal): Change parameter type to pointer to
4263         pointer.  Adjust and advance ARG pointer.
4264         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4265         (parse_cli_var_enum): New, factored out from ...
4266         (do_set_command): ... this.  Adjust.
4267         * cli/cli-setshow.h (parse_cli_boolean_value)
4268         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4269         (parse_cli_var_enum): Declare.
4270         * cli/cli-utils.c: Include "cli/cli-option.h".
4271         (get_ulongest): New.
4272         * cli/cli-utils.h (get_ulongest): Declare.
4273         (check_for_argument): New overloads.
4274         * maint-test-options.c: New file.
4275
4276 2019-06-13  Pedro Alves  <palves@redhat.com>
4277
4278         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4279         parse a range if "-" is at the end of the string.
4280
4281 2019-06-13  Pedro Alves  <palves@redhat.com>
4282
4283         * cli/cli-setshow.c (parse_auto_binary_operation)
4284         (parse_cli_boolean_value): Don't allow "o".
4285
4286 2019-06-13  Pedro Alves  <palves@redhat.com>
4287
4288         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4289         * NEWS: Mention maint test-settings KIND.
4290         * maint-test-settings.c: New file.
4291
4292 2019-06-13  Pedro Alves  <palves@redhat.com>
4293
4294         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4295         completer.
4296         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4297         "set" completers.
4298
4299 2019-06-13  Pedro Alves  <palves@redhat.com>
4300
4301         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4302         after item.
4303
4304 2019-06-13  Pedro Alves  <palves@redhat.com>
4305
4306         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4307
4308 2019-06-13  Pedro Alves <palves@redhat.com>
4309
4310         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4311         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4312         call.
4313         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4314         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4315         calls.
4316         (check_for_argument): Skip spaces after argument.
4317
4318 2019-06-13  Pedro Alves  <palves@redhat.com>
4319
4320         * thread.c (thread_apply_command): Adjust TID parsing.
4321         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4322         detected before end of string.
4323         (tid_is_in_list): Error out if LIST is invalid.
4324
4325 2019-06-13  Pedro Alves  <palves@redhat.com>
4326
4327         * completer.c (complete_line_internal_1): Rewind completion word
4328         point.
4329         (completion_tracker::advance_custom_word_point_by): Change
4330         parameter type to int.
4331         * completer.h (completion_tracker::advance_custom_word_point_by):
4332         Likewise.
4333
4334 2019-06-13  Pedro Alves  <palves@redhat.com>
4335
4336         * completer.c (advance_to_completion_word): Handle delimiters.
4337
4338 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4339
4340         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4341
4342 2019-06-11  Tom Tromey  <tom@tromey.com>
4343
4344         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4345         (xmalloc_failed): Move to alloc.c.
4346         * alloc.c: New file.
4347         * Makefile.in (COMMON_SFILES): Add alloc.c.
4348
4349 2019-06-11  Tom Tromey  <tom@tromey.com>
4350
4351         * nat/linux-waitpid.c: Don't include server.h.
4352         (linux_debug): Remove.
4353         (my_waitpid): Update.
4354
4355 2019-06-11  Tom Tromey  <tromey@adacore.com>
4356
4357         * infcall.c (_initialize_infcall): Remove trailing newline from
4358         help.
4359         * user-regs.c (_initialize_user_regs): Remove trailing newline
4360         from help.
4361         * typeprint.c (_initialize_typeprint): Remove trailing newline
4362         from help.
4363         * reverse.c (_initialize_reverse): Remove trailing newlines from
4364         help.
4365         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4366         from help.
4367         * language.c (add_set_language_command): Remove trailing newline
4368         from help.
4369         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4370         help.
4371         * disasm.c (_initialize_disasm): Remove trailing newline from
4372         help.
4373         * top.c (init_main): Remove trailing newline from help.
4374         * interps.c (_initialize_interpreter): Remove trailing newline
4375         from help.
4376         * btrace.c (_initialize_btrace): Remove trailing newlines from
4377         help.
4378         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4379         from help.
4380         * python/python.c (_initialize_python): Remove trailing newline
4381         from help.
4382         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4383         help.
4384         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4385         from help.  Reformat some text.
4386         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4387         from help.
4388         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4389         newline from help.
4390
4391 2019-06-11  Tom Tromey  <tromey@adacore.com>
4392
4393         * darwin-nat.c (darwin_decode_exception_message)
4394         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4395
4396 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4397
4398         * valops.c (value_slice): Check for not allocated or not
4399         associated values.
4400
4401 2019-06-10  Tom de Vries  <tdevries@suse.de>
4402
4403         PR gdb/24618
4404         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4405         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4406         invalid.
4407
4408 2019-06-10  Tom de Vries  <tdevries@suse.de>
4409
4410         PR gdb/24611
4411         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4412         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4413
4414 2019-06-10  Tom de Vries  <tdevries@suse.de>
4415
4416         PR symtab/24545
4417         * symtab.c (struct demangled_name_entry): Add language field.
4418         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4419         static minimal symbol".  Set and use language field.
4420
4421 2019-06-10  Tom Tromey  <tromey@adacore.com>
4422
4423         * ada-lang.c (_initialize_ada_language): Update help text.
4424
4425 2019-06-10  Tom Tromey  <tromey@adacore.com>
4426
4427         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4428         with a newline.
4429         * guile/guile.c (handle_boot_error): Don't end warning with a
4430         newline.
4431         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4432         warning with a newline.
4433         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4434         newline.
4435         (s12z_frame_cache): Likewise.
4436         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4437         a newline.
4438         * solib-svr4.c (disable_probes_interface): Don't end warning with
4439         a newline.
4440         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4441         newline.
4442         * python/python.c (do_finish_initialization): Don't end warning
4443         with a newline.
4444
4445 2019-06-10  Tom Tromey  <tom@tromey.com>
4446
4447         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4448         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4449         gdbpy_enter.
4450
4451 2019-06-10  Tom Tromey  <tromey@adacore.com>
4452
4453         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4454         data.
4455         (elf_new_init): Don't call stabsread_new_init.
4456         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4457         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4458         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4459
4460 2019-06-10  Tom de Vries  <tdevries@suse.de>
4461
4462         PR symtab/16264
4463         PR symtab/24517
4464         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4465
4466 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4467
4468         * source.c (find_and_open_source): Also rewrite relative file
4469         names.
4470
4471 2019-04-26  Amos Bird  <amosbird@gmail.com>
4472
4473         * annotate.c (annotate_thread_exited): Add "thread-exited"
4474         annotation.
4475
4476 2019-06-06  Tom Tromey  <tromey@adacore.com>
4477
4478         * maint.h (class scoped_command_stats): Use
4479         DISABLE_COPY_AND_ASSIGN.
4480         <print_time>: New method.
4481         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4482         print_time.
4483         (scoped_command_stats::print_time): New method.
4484
4485 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4488         instructions of lengths 6 or 8 bytes.
4489
4490 2019-06-04  Pedro Alves  <palves@redhat.com>
4491
4492         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4493
4494         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4495         * breakpoint.c (condition_completer): Likewise.
4496         * cli/cli-dump.c (scan_expression): Likewise.
4497         * common/filestuff.c (mkdir_recursive): Likewise.
4498         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4499         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4500         (gdb_abspath): Likewise.
4501         * compile/compile-cplus-types.c
4502         (compile_cplus_instance::decl_name): Likewise.
4503         * completer.c (complete_explicit_location):
4504         (signal_completer, reg_or_group_completer_1): Likewise.
4505         * cp-support.c (cp_remove_params_if_any): Likewise.
4506         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4507         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4508         * infcmd.c (strip_bg_char): Likewise.
4509         * linespec.c (copy_token_string): Likewise.
4510         * mi/mi-main.c (output_cores): Likewise.
4511         * psymtab.c (psymtab_search_name):
4512         * symfile.c (test_set_ext_lang_command): Likewise.
4513         * target.c (target_fileio_read_stralloc): Likewise.
4514         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4515         * value.c (complete_internalvar): Likewise.
4516
4517 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4518
4519         Add objfile property to gdb.Type.
4520         * NEWS: Mention Python API addition.
4521         * python/py-type.c (typy_get_objfile): New method.
4522
4523 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4524
4525         * NEWS: Mention the new set|show style [title|highlight].
4526         Mention changes to "show style", "help" and "apropos".
4527
4528 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4529
4530         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4531         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4532         instead of print_help_for_command.
4533         (print_doc_of_command): New function.
4534         (help_list): Add 'apropos -v word' suggestion.
4535         (print_help_for_command): Style the command name using title style.
4536         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4537         (_initialize_cli_cmds): Describe -v in apropos_command help.
4538
4539 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4540
4541         * cli/cli-style.h (cli_style_option): Add name in constructor,
4542         add m_name class member, add constructor with intensity,
4543         add name class function.
4544         (cli_style_option::add_setshow_commands): Remove name argument.
4545         (highlight_style, title_style): New styles.
4546         * cli/cli-style.c (do_show): New function that shows a style
4547         characteristic styling the style name with itself.
4548         (set_style_name): New function.
4549         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4550         Update all callers according to the changes in cli/cli-style.h.
4551         * utils.h (fputs_highlighted): New function.
4552         * utils.c (fputs_highlighted): Likewise.
4553
4554 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * NEWS: Mention new pipe command and new convenience variables.
4557
4558 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4559
4560         * cli/cli-cmds.c (pipe_command): New function.
4561         (_initialize_cli_cmds): Call add_com for pipe_command.
4562         Define | as an alias for pipe.
4563         (exit_status_set_internal_vars): New function.
4564         (shell_escape): Call exit_status_set_internal_vars.
4565         cli/cli-decode.c (find_command_name_length): Recognize | as
4566         a single character command.
4567
4568 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4569
4570         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4571         top.c (execute_command_to_ui_file): New function, mostly a copy
4572         of execute_command_to_string.
4573         (execute_command_to_string): Implement by calling
4574         execute_command_to_ui_file.
4575
4576 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577
4578         * top.h (saved_command_line): Remove declaration.
4579         * top.c (previous_saved_command_line, previous_repeat_arguments):
4580         New variables.
4581         (saved_command_line): Make static, define together with other
4582         'repeat variables'.
4583         (dont_repeat): Clear repeat_arguments.
4584         (repeat_previous, get_saved_command_line, save_command_line):
4585         New functions.
4586         (gdb_init): Initialize saved_command_line
4587         and previous_saved_command_line.
4588         * main.c (captured_main_1): Remove saved_command_line initialization.
4589         * event-top.c (handle_line_of_input): Update to use
4590         the new 'repeat' related functions instead of direct access to
4591         saved_command_line.
4592         * command.h (repeat_previous, get_saved_command_line,
4593         save_command_line): New declarations.
4594         (dont_repeat): Add comment.
4595
4596 2019-05-30  Tom Tromey  <tromey@adacore.com>
4597
4598         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4599         Fix comment.
4600         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4601
4602 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4603
4604         PR cli/24587
4605         * completer.c (complete): Initialize variable word.
4606
4607 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4608
4609         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4610         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4611         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4612         'body' is NULL to the outter 'if', protecting the '!is_define'
4613         situation as well.
4614
4615 2019-05-29  Tom Tromey  <tromey@adacore.com>
4616
4617         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4618         (dwarf_unknown): New function.
4619         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4620         (dwarf_type_encoding_name): Use dwarf_unknown.
4621
4622 2019-05-29  Tom Tromey  <tromey@adacore.com>
4623
4624         PR c++/20020:
4625         * cp-valprint.c (cp_print_value_fields): Call
4626         cp_print_static_field inside "try".
4627
4628 2019-05-29  Tom Tromey  <tromey@adacore.com>
4629
4630         * inflow.c (struct terminal_info): Add default operator=.
4631         * configure: Rebuild.
4632         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4633         -Wdeprecated-copy-dtor, -Wredundant-move.
4634
4635 2019-05-29  Tom Tromey  <tromey@adacore.com>
4636
4637         * NEWS: Add entry.
4638         * infcmd.c (print_return_value_1): Handle finish_print
4639         option.
4640         (show_print_finish): New function.
4641         (_initialize_infcmd): Add "set/show print finish" commands.
4642         * valprint.c (user_print_options): Initialize new member.
4643         * valprint.h (struct value_print_options) <finish_print>: New
4644         member.
4645
4646 2019-05-28  Tom Tromey  <tromey@adacore.com>
4647
4648         * ada-lang.c (ada_remove_Xbn_suffix)
4649         (find_old_style_renaming_symbol)
4650         (parse_old_style_renaming): Remove.
4651         (ada_find_renaming_symbol): Don't call
4652         find_old_style_renaming_symbol.
4653         (ada_is_renaming_symbol): Rename from
4654         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4655         bool.  Now static.
4656         (ada_read_var_value): Update and simplify.
4657         * ada-exp.y (write_var_or_type): Remove old code.
4658
4659 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4660
4661         * event-top.c: Remove include comment.
4662         * inflow.c (class scoped_ignore_sigttou): Move from here...
4663         * inflow.h (class scoped_ignore_sigttou): ...to here.
4664         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4665         * top.c:  Remove include comment.
4666
4667 2019-05-27  Tom Tromey  <tom@tromey.com>
4668
4669         * NEWS: Fix typo.
4670
4671 2019-05-22  Tom Tromey  <tromey@adacore.com>
4672
4673         * target.c (target_follow_exec): Constify parameter.
4674         * target-delegates.c: Rebuild.
4675         * remote.c (remote_target::follow_exec): Constify parameter.
4676         * infrun.c (follow_exec): Constify parameter.
4677         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4678         (target_follow_exec): Likewise.
4679
4680 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4681
4682         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4683         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4684
4685 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4686
4687         * NEWS: Add debugredirect and testsuite sections.
4688
4689 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4690
4691         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4692         target descriptions using exclusively floating point register name
4693         aliases.
4694
4695 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4696
4697         PR gdb/18644:
4698         * f-lang.c (build_fortran_types): Handle the case where
4699         gdbarch_floatformat_for_type returns a nullptr.
4700
4701 2019-05-21  Tom de Vries  <tdevries@suse.de>
4702
4703         PR cli/24587
4704         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4705
4706 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         PR gdb/18644:
4709         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4710         16-byte floats.
4711         * i386-tdep.c (i386_floatformat_for_type): Use
4712         floatformats_ia64_quad for the 16-byte floating point component
4713         within a fortran 32-byte complex number.
4714
4715 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4716
4717         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4718         delete default constructor.
4719         (find_partial_die): Update to return const struct.
4720         (partial_die_parent_scope): Move variable declaration into scope
4721         of its use and change its type to auto.
4722         (guess_partial_die_structure_name): Likewise.
4723         (partial_die_info::fixup): Likewise.
4724
4725 2019-05-17  Tom Tromey  <tromey@adacore.com>
4726
4727         * source.c (find_and_open_source): Remove cast.
4728
4729 2019-05-17  Tom Tromey  <tromey@adacore.com>
4730
4731         * annotate.c (annotate_source): Make "filename" const.
4732         * annotate.h (annotate_source): Use const.
4733
4734 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4735
4736         * disasm.c (set_disassembler_options): Send errors to stderr.
4737
4738 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4739
4740         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4741         (cli_interp_base::set_logging): Check debug_redirect.
4742         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4743         * cli/cli-logging.c (debug_redirect): Add static variable.
4744         (pop_output_files): Add default param.
4745         (handle_redirections): Print debug setting.
4746         (show_logging_command): Likewise.
4747         (_initialize_cli_logging): Add debugredirect command.
4748         * interps.c (current_interp_set_logging): Add debug_redirect
4749         parameter.
4750         * interps.h (set_logging): Add debug_redirect parameter.
4751         (current_interp_set_logging): Likewise.
4752         * mi/mi-common.h: Likewise.
4753         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4754
4755 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4756             Tom Tromey  <tromey@adacore.com>
4757
4758         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4759         directly.
4760         * cli/cli-interp.h (make_logging_output): Remove declaration.
4761         * cli/cli-logging.c (make_logging_output): Remove function.
4762         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4763         directly.
4764         * ui-file.c (tee_file::tee_file): Remove bools.
4765         (tee_file::~tee_file): Remove deletes.
4766         * ui-file.h (tee_file): Remove bools.
4767
4768 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4769
4770         * mi/mi-cmds.h (mi_cmd_complete): New function.
4771         * mi/mi-main.c (mi_cmd_complete): Likewise.
4772         * mi/mi-cmds.c: Define new MI command -complete.
4773         * NEWS: Mention new -complete command.
4774
4775 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4776
4777         * completer.h (complete): New function.
4778         * completer.c (complete): Likewise.
4779         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4780         function defined in completer.h.
4781
4782 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4783
4784         * MAINTAINERS (Write After Approval): Add myself.
4785
4786 2019-05-17  Tom de Vries  <tdevries@suse.de>
4787
4788         PR gdb/24094
4789         * dwarf2read.c (struct cu_partial_die_info): New struct.
4790         (find_partial_die): Return cu_partial_die_info.
4791         (partial_die_parent_scope, guess_partial_die_structure_name)
4792         (partial_die_info::fixup): Handle new return type of find_partial_die.
4793
4794 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4795
4796         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4797         "std::string", simplifying the algorithm.
4798
4799 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4800
4801         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4802         (stap_static_probe_ops::get_probes): Likewise.
4803
4804 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4805
4806         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4807         '-')" and "else if".
4808         (stap_parse_single_operand): Join checks for
4809         "gdbarch_stap_parse_special_token_p" and
4810         "gdbarch_stap_parse_special_token" in the same "if" statement.
4811         Invert check when verifying for operation on register
4812         displacement.
4813
4814 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4815
4816         * stap-probe.c (stap_get_opcode): Update comment.
4817         (stap_get_expected_argument_type): Likewise.
4818         (handle_stap_probe): Likewise.
4819
4820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4821
4822         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4823         return type to 'bool'.  Adjust comment.  Use 'bool' when
4824         appropriate.
4825         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4826         * stap-probe.c (stap_parse_argument_1): Likewise.
4827         (stap_is_operator): Likewise.
4828         (stap_is_generic_prefix): Likewise.
4829         (stap_is_register_prefix): Likewise.
4830         (stap_is_register_indirection_prefix): Likewise.
4831         (stap_is_integer_prefix): Likewise.
4832         (stap_generic_check_suffix): Likewise.
4833         (stap_check_integer_suffix): Likewise.
4834         (stap_check_register_suffix): Likewise.
4835         (stap_check_register_indirection_suffix): Likewise.
4836         (stap_parse_register_operand): Likewise.
4837         (stap_parse_single_operand): Likewise.
4838         (stap_parse_argument_1): Likewise.
4839         (stap_probe::get_argument_count): Likewise.
4840         (stap_is_operator): Likewise.
4841
4842 2019-05-16  Tom Tromey  <tromey@adacore.com>
4843
4844         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4845         keyword to foreach.
4846
4847 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4848
4849         * linux-thread-db.c (try_thread_db_load_1): Change return type
4850         to bool.
4851         (try_thread_db_load): Likewise.
4852         (try_thread_db_load_from_pdir_1): Likewise.
4853         (try_thread_db_load_from_pdir): Likewise.
4854         (try_thread_db_load_from_sdir): Likewise.
4855         (try_thread_db_load_from_dir): Likewise.
4856         (thread_db_load_search): Likewise.
4857         (has_libpthread): Likewise.
4858         (thread_db_load): Likewise.
4859
4860 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4861
4862         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4863         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4864         NULL, and complain/return if that's the case.
4865
4866 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4867
4868         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4869         (advance, posn, abstract_read_memory): New functions.
4870         [struct mem_read_abstraction]: New struct.
4871         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4872
4873 2019-05-14  Tom Tromey  <tromey@adacore.com>
4874
4875         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4876         value is not lval_memory.
4877
4878 2019-05-14  Tom Tromey  <tromey@adacore.com>
4879
4880         * solib.c (info_sharedlibrary_command): Style the file name.
4881
4882 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4883
4884         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4885         (aarch64_vnv_type): Likewise.
4886         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4887         * common/tdesc.c: Likewise.
4888         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4889         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4890         * features/aarch64-fpu.xml: Add ieee half view.
4891         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4892         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4893         * gdbtypes.h (struct builtin_type): Likewise.
4894         (struct objfile_type): Likewise.
4895
4896 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4897
4898         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4899         typo.
4900         * location.h (string_to_event_location): Likewise.
4901
4902 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4903
4904         GDB 8.3 released.
4905
4906 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4907
4908         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4909         New variable declaration.
4910         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4911         New variable.
4912         (print_one_breakpoint): Use ui_out::test_flags and new global
4913         variable to compute use_fixed_output.
4914         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4915         Remove.
4916         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4917         (mi_multi_location_breakpoint_output_fixed): Remove.
4918         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4919         new variable.
4920         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4921         fix_multi_location_breakpoint_output flag if version >= 3.
4922         * ui-out.h (enum ui_out_flag)
4923         <fix_multi_location_breakpoint_output>: New enumerator.
4924
4925 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4926
4927         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4928
4929 2019-05-10  Tom Tromey  <tromey@adacore.com>
4930
4931         * ada-lang.c (catch_ada_completer): New function.
4932         (_initialize_ada_language): Use it.
4933
4934 2019-05-10  Tom Tromey  <tromey@adacore.com>
4935
4936         * thread.c (print_thread_info): Make "requested_threads" const.
4937         * gdbthread.h (print_thread_info): Make "requested_threads"
4938         const.
4939         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4940         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4941
4942 2019-05-08  Tom Tromey  <tom@tromey.com>
4943
4944         * gdbtypes.c (objfile_type_data): Change type.
4945         (objfile_type, _initialize_gdbtypes): Update.
4946
4947 2019-05-08  Tom Tromey  <tom@tromey.com>
4948
4949         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4950         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4951         (_initialize_dwarf2_frame): Update.
4952
4953 2019-05-08  Tom Tromey  <tom@tromey.com>
4954
4955         * objc-lang.c (objc_objfile_data): Change type.
4956         (find_methods): Update.
4957         (_initialize_objc_lang): Remove.
4958
4959 2019-05-08  Tom Tromey  <tom@tromey.com>
4960
4961         * stabsread.c (rs6000_builtin_type_data): Change type.
4962         (rs6000_builtin_type, _initialize_stabsread): Update.
4963
4964 2019-05-08  Tom Tromey  <tom@tromey.com>
4965
4966         * mips-tdep.c (mips_pdr_data): Remove.
4967         (_initialize_mips_tdep): Update.
4968
4969 2019-05-08  Tom Tromey  <tom@tromey.com>
4970
4971         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4972         (hppa_init_objfile_priv_data, read_unwind_info)
4973         (find_unwind_entry, _initialize_hppa_tdep): Update.
4974
4975 2019-05-08  Tom Tromey  <tom@tromey.com>
4976
4977         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4978         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4979         on obstack.
4980         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4981
4982 2019-05-08  Tom Tromey  <tom@tromey.com>
4983
4984         * mdebugread.c (basic_type_data): Change type.
4985         (basic_type, _initialize_mdebugread): Update.
4986
4987 2019-05-08  Tom Tromey  <tom@tromey.com>
4988
4989         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4990
4991 2019-05-08  Tom Tromey  <tom@tromey.com>
4992
4993         * nto-tdep.c (nto_inferior_data_reg): Change type.
4994         (nto_inferior_data): Update.
4995         (nto_inferior_data_cleanup, nto_new_inferior_data)
4996         (_initialize_nto_tdep): Remove.
4997         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4998
4999 2019-05-08  Tom Tromey  <tom@tromey.com>
5000
5001         * ada-lang.c (struct ada_inferior_data): Add initializers.
5002         (ada_inferior_data): Change type.
5003         (ada_inferior_data_cleanup): Remove.
5004         (get_ada_inferior_data, ada_inferior_exit)
5005         (struct ada_pspace_data): Add initializers, destructor.
5006         (ada_pspace_data_handle): Change type.
5007         (get_ada_pspace_data): Update.
5008         (ada_pspace_data_cleanup): Remove.
5009
5010 2019-05-08  Tom Tromey  <tom@tromey.com>
5011
5012         * coffread.c (struct coff_symfile_info): Add initializers.
5013         (coff_objfile_data_key): Move lower.  Change type.
5014         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5015         Update.
5016         (coff_free_info): Remove.
5017
5018 2019-05-08  Tom Tromey  <tom@tromey.com>
5019
5020         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5021         (fbsd_pspace_data_handle): Move lower.  Change type.
5022         (get_fbsd_pspace_data): Update.
5023         (fbsd_pspace_data_cleanup): Remove.
5024         (_initialize_fbsd_tdep): Update.
5025
5026 2019-05-08  Tom Tromey  <tom@tromey.com>
5027
5028         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5029         (get_ada_tasks_pspace_data): Update.
5030         (ada_tasks_pspace_data_cleanup): Remove.
5031         (_initialize_tasks): Update.
5032         (ada_tasks_inferior_data_handle): Change type.
5033         (get_ada_tasks_inferior_data): Update.
5034         (ada_tasks_inferior_data_cleanup): Remove.
5035         (struct ada_tasks_pspace_data): Add initializers.
5036
5037 2019-05-08  Tom Tromey  <tom@tromey.com>
5038
5039         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5040         * symfile-debug.c (debug_sym_get_probes): Change type.
5041         * stap-probe.c (handle_stap_probe):
5042         (stap_static_probe_ops::get_probes): Change type.
5043         * probe.h (class static_probe_ops) <get_probes>: Change type.
5044         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5045         (parse_probes_in_pspace): Update.
5046         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5047         Update.
5048         (any_static_probe_ops::get_probes): Change type.
5049         * elfread.c (elfread_data): New typedef.
5050         (probe_key): Change type.
5051         (elf_get_probes): Likewise.  Update.
5052         (probe_key_free): Remove.
5053         (_initialize_elfread): Update.
5054         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5055         Change type.
5056         (dtrace_process_dof_probe, dtrace_process_dof)
5057         (dtrace_static_probe_ops::get_probe): Change type.
5058
5059 2019-05-08  Tom Tromey  <tom@tromey.com>
5060
5061         * xcoffread.c (struct xcoff_symfile_info): Rename from
5062         coff_symfile_info.  Add initializers.
5063         (xcoff_objfile_data_key): Move lower.  Change type.
5064         (XCOFF_DATA): Rewrite.
5065         (xcoff_free_info): Remove.
5066         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5067         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5068         (xcoff_initial_scan): Update.
5069
5070 2019-05-08  Tom Tromey  <tom@tromey.com>
5071
5072         * solib-svr4.c (struct svr4_info): Add initializers and
5073         destructor.
5074         <probes_table>: Now an htab_up.
5075         (solib_svr4_pspace_data): Change type.
5076         (free_probes_table): Simplify.
5077         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5078         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5079         (probes_table_remove_objfile_probes, register_solib_event_probe)
5080         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5081         (_initialize_svr4_solib): Update.
5082
5083 2019-05-08  Tom Tromey  <tom@tromey.com>
5084
5085         * remote.c (remote_pspace_data): Change type.
5086         (remote_pspace_data_cleanup): Remove.
5087         (get_remote_exec_file, set_pspace_remote_exec_file)
5088         (_initialize_remote): Update.
5089
5090 2019-05-08  Tom Tromey  <tom@tromey.com>
5091
5092         * breakpoint.c (breakpoint_objfile_key): Change type.
5093         (get_breakpoint_objfile_data): Update.
5094         (free_breakpoint_objfile_data): Remove.
5095         (_initialize_breakpoint): Update.
5096
5097 2019-05-08  Tom Tromey  <tom@tromey.com>
5098
5099         * linux-tdep.c (struct linux_info): Add initializers.
5100         (linux_inferior_data): Move.  Change type.
5101         (invalidate_linux_cache_inf): Update.
5102         (linux_inferior_data_cleanup): Remove.
5103         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5104
5105 2019-05-08  Tom Tromey  <tom@tromey.com>
5106
5107         * auxv.c (auxv_inferior_data): Move.  Change type.
5108         (auxv_inferior_data_cleanup): Remove.
5109         (invalidate_auxv_cache_inf): Rewrite.
5110         (get_auxv_inferior_data, _initialize_auxv): Update.
5111
5112 2019-05-08  Tom Tromey  <tom@tromey.com>
5113
5114         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5115         (symfile_debug_objfile_data_key): Change type.
5116         (symfile_debug_installed, debug_qf_has_symbols)
5117         (debug_qf_find_last_source_symtab)
5118         (debug_qf_forget_cached_source_info)
5119         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5120         (debug_qf_print_stats, debug_qf_dump)
5121         (debug_qf_expand_symtabs_for_function)
5122         (debug_qf_expand_all_symtabs)
5123         (debug_qf_expand_symtabs_with_fullname)
5124         (debug_qf_map_matching_symbols)
5125         (debug_qf_expand_symtabs_matching)
5126         (debug_qf_find_pc_sect_compunit_symtab)
5127         (debug_qf_map_symbol_filenames)
5128         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5129         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5130         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5131         (debug_sym_read_linetable, debug_sym_relocate): Update.
5132         (symfile_debug_free_objfile): Remove.
5133         (install_symfile_debug_logging, _initialize_symfile_debug):
5134         Update.
5135
5136 2019-05-08  Tom Tromey  <tom@tromey.com>
5137
5138         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5139         allocate_on_obstack.
5140         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5141         (get_dwarf2_per_objfile): Update.
5142         (set_dwarf2_per_objfile): Remove.
5143         (dwarf2_has_info, dwarf2_get_section_info): Update.
5144         (dwarf2_free_objfile): Remove.
5145         (_initialize_dwarf2_read): Update.
5146
5147 2019-05-08  Tom Tromey  <tom@tromey.com>
5148
5149         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5150         initializers.
5151         <unsupported_script_warning_printed,
5152         script_not_found_warning_printed>: Now bool.
5153         (auto_load_pspace_data): Change type.
5154         (~auto_load_pspace_info): Rename from
5155         auto_load_pspace_data_cleanup.
5156         (get_auto_load_pspace_data, init_loaded_scripts_info)
5157         (clear_section_scripts, maybe_print_unsupported_script_warning)
5158         (maybe_print_script_not_found_warning, _initialize_auto_load):
5159         Update.
5160
5161 2019-05-08  Tom Tromey  <tom@tromey.com>
5162
5163         * objfiles.c (objfile_pspace_info): Add destructor and
5164         initializers.
5165         (objfiles_pspace_data): Change type.
5166         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5167         (get_objfile_pspace_data): Update.
5168         (objfiles_bfd_data): Change type.
5169         (get_objfile_bfd_data): Update.
5170         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5171
5172 2019-05-08  Tom Tromey  <tom@tromey.com>
5173
5174         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5175         Change type.
5176         (get_catch_syscall_inferior_data): Update.
5177         (catch_syscall_inferior_data_cleanup): Remove.
5178         (_initialize_break_catch_syscall): Update.
5179
5180 2019-05-08  Tom Tromey  <tom@tromey.com>
5181
5182         * inflow.c (struct terminal_info): Add destructor and
5183         initializers.
5184         (inflow_inferior_data): Change type.
5185         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5186         (get_inflow_inferior_data, inflow_inferior_exit)
5187         (swap_terminal_info, _initialize_inflow): Update.
5188
5189 2019-05-08  Tom Tromey  <tom@tromey.com>
5190
5191         * target-dcache.c (target_dcache_cleanup): Remove.
5192         (target_dcache_aspace_key): Change type.
5193         (target_dcache_init_p, target_dcache_invalidate)
5194         (target_dcache_get, target_dcache_get_or_init)
5195         (_initialize_target_dcache): Update.
5196         * dcache.h (struct dcache_deleter): New.
5197
5198 2019-05-08  Tom Tromey  <tom@tromey.com>
5199
5200         * symtab.c (struct symbol_cache): Add destructor and
5201         initializers.
5202         (symbol_cache_key): Move.  Change type.
5203         (make_symbol_cache, free_symbol_cache): Remove.
5204         (get_symbol_cache): Update.
5205         (symbol_cache_cleanup): Remove.
5206         (ALL_PSPACES, symbol_cache_flush)
5207         (maintenance_print_symbol_cache)
5208         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5209         Update.
5210
5211 2019-05-08  Tom Tromey  <tom@tromey.com>
5212
5213         * symtab.c (struct main_info): Add destructor and initializers.
5214         (main_progspace_key): Move.  Change type.
5215         (get_main_info): Update.
5216         (main_info_cleanup): Remove.
5217         (_initialize_symtab): Update.
5218
5219 2019-05-08  Tom Tromey  <tom@tromey.com>
5220
5221         * registry.h (DECLARE_REGISTRY): Define the _key class.
5222
5223 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5224
5225         * NEWS: Merge two 'New commands' sections.
5226
5227 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5228
5229         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5230         parameter and use Ada language definition instead.
5231         (ada_val_print_ptr): Remove unused language parameter.
5232         (ada_val_print_num): Remove language parameter and use Ada language
5233         definition instead.
5234         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5235         parameter.
5236         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5237         parameter and use Ada language definition instead.
5238         (ada_val_print_1): Update all ada_val_print_xxx calls.
5239         Remove language parameter.
5240         (ada_val_print): Update ada_val_print_1 call.
5241
5242 2019-05-08  Tom Tromey  <tromey@adacore.com>
5243
5244         * remote.c (remote_hw_watchpoint_limit)
5245         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5246         Now static.
5247
5248 2019-05-08  Tom Tromey  <tromey@adacore.com>
5249
5250         * maint.c (_initialize_maint_cmds): Move initialization code to
5251         remote.c.
5252         (watchdog, show_watchdog): Move to remote.c.
5253         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5254         "watchdog" static.
5255         (_initialize_remote): Move initialization code from maint.c.
5256         * defs.h (watchdog): Don't declare.
5257
5258 2019-05-08  Tom Tromey  <tromey@adacore.com>
5259
5260         * tui/tui-interp.c: Include main.h.
5261         * interps.c: Include main.h.
5262         * main.h (interpreter_p): Declare.
5263         * defs.h (interpreter_p): Don't declare.
5264
5265 2019-05-08  Tom Tromey  <tromey@adacore.com>
5266
5267         * dwarf2loc.c: Include dwarf2read.h.
5268         * defs.h (read_unsigned_leb128): Don't declare.
5269         * dwarf2read.h (read_unsigned_leb128): Declare.
5270
5271 2019-05-08  Tom Tromey  <tromey@adacore.com>
5272
5273         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5274         method.
5275
5276 2019-05-08  Tom Tromey  <tromey@adacore.com>
5277
5278         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5279         when no wrap column is set.
5280
5281 2019-05-08  Tom Tromey  <tromey@adacore.com>
5282
5283         * c-lang.c (c_get_string): Handle non-C-style arrays.
5284
5285 2019-05-08  Tom Tromey  <tromey@adacore.com>
5286
5287         * typeprint.c (print_offset_data::update): Print the bit offset,
5288         not the number of bits remaining.
5289
5290 2019-05-08  Tom Tromey  <tromey@adacore.com>
5291
5292         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5293         padding at end of comment.
5294
5295 2019-05-08  Tom Tromey  <tromey@adacore.com>
5296
5297         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5298         Compare main types.
5299
5300 2019-05-06  Tom Tromey  <tom@tromey.com>
5301
5302         * common/scoped_mmap.c: Include common-defs.h.
5303         * common/scoped_mmap.h: Don't include config.h.
5304
5305 2019-05-04  Tom Tromey  <tom@tromey.com>
5306
5307         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5308         (struct aarch64_call_info): Add initializers.
5309         <si>: Now a std::vector.
5310         (pass_on_stack, aarch64_push_dummy_call): Update.
5311
5312 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5313             Tom Tromey  <tom@tromey.com>
5314
5315         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5316         (ppc_threads): Now a std::vector.  Now static.
5317         (hwdebug_find_thread_points_by_tid)
5318         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5319         Update.
5320
5321 2019-05-04  Tom Tromey  <tom@tromey.com>
5322
5323         * arc-tdep.c (arc_tdesc_init): Return bool.
5324
5325 2019-05-04  Tom Tromey  <tom@tromey.com>
5326
5327         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5328         Use gdb_assert_not_reached.
5329
5330 2019-05-04  Tom Tromey  <tom@tromey.com>
5331
5332         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5333         "false".
5334
5335 2019-05-04  Tom Tromey  <tom@tromey.com>
5336
5337         * arc-tdep.c (arc_tdesc_init): Use bool.
5338
5339 2019-05-04  Tom Tromey  <tom@tromey.com>
5340
5341         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5342
5343 2019-05-04  Tom Tromey  <tom@tromey.com>
5344
5345         * cli/cli-cmds.c (valid_command_p): Return bool.
5346
5347 2019-05-04  Tom Tromey  <tom@tromey.com>
5348
5349         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5350         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5351
5352 2019-05-04  Raul Tambre  <raul@tambre.ee>
5353
5354         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5355         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5356         operator for comparison.
5357
5358 2019-05-04  Tom Tromey  <tom@tromey.com>
5359
5360         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5361         (lookup_partial_symbol, print_partial_symbols)
5362         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5363         (psymbol_compare): Update.
5364         (add_psymbol_to_bcache): Clear the entire psymbol.
5365         (maintenance_check_psymtabs): Update.
5366         * psympriv.h (struct partial_symbol): Don't derive from
5367         general_symbol_info.
5368         <obj_section, unrelocated_address, address,
5369         set_unrelocated_address>: Update.
5370         <ginfo>: New member.
5371         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5372         (debug_names::write_psymbols): Update.
5373
5374 2019-05-04  Tom de Vries  <tdevries@suse.de>
5375
5376         * contrib/cc-with-tweaks.sh: Support -n arg.
5377
5378 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5379
5380         * corelow.c (core_target::detach): Ensure frame cache and
5381         register caches are cleared.
5382         inferior.c (exit_inferior_1): Likewise.
5383
5384 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5385             Tom Tromey  <tom@tromey.com>
5386
5387         * dictionary.c (collate_pending_symbols_by_language): Remove
5388         "struct" from foreach.
5389         * symtab.c (lookup_global_symbol_from_objfile)
5390         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5391         foreach.
5392         * ser-tcp.c (net_open): Remove "struct" from foreach.
5393         * objfiles.c (objfile_relocate, objfile_rebase)
5394         (objfile_has_symbols): Remove "struct" from foreach.
5395         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5396         from foreach.
5397         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5398         foreach.
5399         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5400         "struct" from foreach.
5401         * ada-lang.c (create_excep_cond_exprs)
5402         (ada_exception_catchpoint_cond_string): Remove "struct" from
5403         foreach.
5404
5405 2019-05-03  Tom Tromey  <tromey@adacore.com>
5406
5407         * ada-exp.y (convert_char_literal): Check suffix of each
5408         enumerator.
5409
5410 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5411
5412         PR ada/21406:
5413         * ada-exp.y (yywrap): Don't define.
5414         * ada-lex.l (%option): Add noyywrap
5415         (yywrap): Remove.
5416
5417 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5418
5419         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5420         _WIN32_WINNT to the XP level, unless already defined to a higher
5421         level.
5422
5423         * unittests/parse-connection-spec-selftests.c:
5424         * ser-tcp.c:
5425         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5426         override.
5427
5428         * symfile.c (find_separate_debug_file): Remove colon from the
5429         drive spec of DOS/Windows file names of the target, so that the
5430         file name produced from DEBUGDIR and the target's directory will
5431         be valid on DOS/Windows systems.
5432
5433 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * rust-lang.c (val_print_struct): Handle printing structures
5436         containing strings.
5437
5438 2019-05-02  Tom Tromey  <tromey@adacore.com>
5439
5440         * valarith.c (_initialize_valarith): Remove.
5441
5442 2019-05-01  Tom Tromey  <tromey@adacore.com>
5443
5444         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5445         bitfields.
5446
5447 2019-05-01  Tom Tromey  <tromey@adacore.com>
5448
5449         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5450         for big-endian copies.
5451
5452 2019-04-30  Ali Tamur  <tamur@google.com>
5453         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5454         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5455         (read_3_bytes): New function.
5456
5457 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5458
5459         * windows-nat.c (main_thread_id): Delete.
5460         (handle_output_debug_string): Replace main_thread_id by
5461         current_event.dwThreadId.
5462         (fake_create_process): Likewise.
5463         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5464         Do not set main_thread_id.
5465         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5466         current_event.dwThreadId.
5467         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5468
5469 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5470
5471         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5472         Use current_event.dwThreadId instead of main_thread_id.
5473
5474 2019-04-30  Tom Tromey  <tromey@adacore.com>
5475
5476         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5477         (create_excep_cond_exprs): Iterate over program spaces.
5478         (ada_exception_catchpoint_cond_string): Examine all minimal
5479         symbols for exception types.
5480
5481 2019-04-30  Tom Tromey  <tromey@adacore.com>
5482
5483         PR c++/24470:
5484         * dwarf2read.c (process_structure_scope): Handle case where type
5485         has template parameters but no symbol was created.
5486
5487 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5488             Chris January  <chris.january@arm.com>
5489
5490         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5491         qualifier.
5492         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5493
5494 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * f-typeprint.c (f_print_type): Update rules for printing
5497         whitespace.
5498         (f_type_print_varspec_suffix): Likewise.
5499
5500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5501             Chris January  <chris.january@arm.com>
5502
5503         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5504         function arguments.
5505
5506 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5507
5508         * f-lang.c (build_fortran_types): Change name of void type to
5509         lower case.
5510         * f-typeprint.c (f_type_print_base): Print the name of the void
5511         type, rather than a fixed string.
5512         * f-valprint.c (f_decorations): Use lower case void string.
5513
5514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5515             Chris January  <chris.january@arm.com>
5516
5517         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5518         types for Fortran.
5519
5520 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5521             Chris January  <chris.january@arm.com>
5522             David Lecomber  <david.lecomber@arm.com>
5523
5524         * f-exp.y (BINOP_INTRINSIC): New token.
5525         (exp): New parser rule handling BINOP_INTRINSIC.
5526         (f77_keywords): Add new builtin procedures.
5527         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5528         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5529         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5530         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5531         (print_unop_subexp_f): New function.
5532         (print_binop_subexp_f): New function.
5533         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5534         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5535         (dump_subexp_body_f): Likewise.
5536         (operator_check_f): Likewise.
5537         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5538         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5539
5540 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5543         UNOP_KIND.
5544         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5545         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5546         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5547         (operator_length_f): New fuction.
5548         (print_subexp_f): New function.
5549         (op_name_f): New function.
5550         (dump_subexp_body_f): New function.
5551         (operator_check_f): New function.
5552         (exp_descriptor_f): Replace standard expression handling functions
5553         with new functions.
5554         * gdb/fortran-operator.def: New file.
5555         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5556         * gdb/std-operator.def: Remove UNOP_KIND.
5557
5558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5559
5560         * std-operator.def: Remove unbalanced, stray double quote
5561         character.
5562
5563 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5564             Chris January  <chris.january@arm.com>
5565             Daniel Everett  <daniel.everett@arm.com>
5566             Nick Forrington  <nick.forrington@arm.com>
5567             Richard Bunt  <richard.bunt@arm.com>
5568
5569         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5570         of depth when printing anonymous structs or unions.
5571         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5572         Don't print either the top-level value, or the children if the
5573         max-depth is exceeded.
5574         (ppscm_print_children): When printing the key of a map, allow one
5575         extra level of depth.
5576         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5577         print either the top-level value, or the children if the max-depth
5578         is exceeded.
5579         (print_children): When printing the key of a map, allow one extra
5580         level of depth.
5581         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5582         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5583         (user_print_options): Initialise max_depth field.
5584         (val_print_scalar_or_string_type_p): New function.
5585         (val_print): Check to see if the max depth has been reached.
5586         (val_print_check_max_depth): Define new function.
5587         (show_print_max_depth): New function.
5588         (_initialize_valprint): Add 'print max-depth' option.
5589         * valprint.h (struct value_print_options) <max_depth>: New field.
5590         (val_print_check_max_depth): Declare new function.
5591         * NEWS: Document new feature.
5592
5593 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5594
5595         * ada-lang.c (ada_language_defn): Initialise new field.
5596         * c-lang.c (c_is_string_type_p): New function.
5597         (c_language_defn): Initialise new field.
5598         (cplus_language_defn): Initialise new field.
5599         (asm_language_defn): Initialise new field.
5600         (minimal_language_defn): Initialise new field.
5601         * c-lang.h (c_is_string_type_p): Declare new function.
5602         * d-lang.c (d_language_defn): Initialise new field.
5603         * f-lang.c (f_is_string_type_p): New function.
5604         (f_language_defn): Initialise new field.
5605         * go-lang.c (go_is_string_type_p): New function.
5606         (go_language_defn): Initialise new field.
5607         * language.c (default_is_string_type_p): New function.
5608         (unknown_language_defn): Initialise new field.
5609         (auto_language_defn): Initialise new field.
5610         * language.h (struct language_defn) <la_is_string_type_p>: New
5611         member variable.
5612         (default_is_string_type_p): Declare new function.
5613         * m2-lang.c (m2_language_defn): Initialise new field.
5614         * objc-lang.c (objc_language_defn): Initialise new field.
5615         * opencl-lang.c (opencl_language_defn): Initialise new field.
5616         * p-lang.c (pascal_is_string_type_p): New function.
5617         (pascal_language_defn): Initialise new field.
5618         * rust-lang.c (rust_is_string_type_p): New function.
5619         (rust_language_defn): Initialise new field.
5620
5621 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5622
5623         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5624         New field.
5625         * ada-lang.c (ada_language_defn): Initialise new field.
5626         * c-lang.c (c_language_defn): Likewise.
5627         (cplus_language_defn): Likewise.
5628         (asm_language_defn): Likewise.
5629         (minimal_language_defn): Likewise.
5630         * d-lang.c (d_language_defn): Likewise.
5631         * f-lang.c (f_language_defn): Likewise.
5632         * go-lang.c (go_language_defn): Likewise.
5633         * language.c (unknown_language_defn): Likewise.
5634         (auto_language_defn): Likewise.
5635         * m2-lang.c (m2_language_defn): Likewise.
5636         * objc-lang.c (objc_language_defn): Likewise.
5637         * opencl-lang.c (opencl_language_defn): Likewise.
5638         * p-lang.c (pascal_language_defn): Likewise.
5639         * rust-lang.c (rust_language_defn): Likewise.
5640
5641 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * ada-lang.c (ada_is_character_type): Change return type to bool.
5644         (ada_is_string_type): Likewise.
5645         * ada-lang.h (ada_is_character_type): Update declaration
5646         (ada_is_string_type): Likewise.
5647
5648 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5649
5650         Support style in 'frame|thread apply'
5651
5652         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5653         * record.c (record_start, record_stop): Update callers of
5654         execute_command_to_string with false.
5655         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5656         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5657         methods.
5658         (class string_file): New constructor with term_out parameter.
5659         Override methods term_out and can_emit_style_escape.  New member
5660         term_out.
5661         (class stdio_file): Override can_emit_style_escape.
5662         (class tee_file): Override term_out and can_emit_style_escape.
5663         * utils.h (can_emit_style_escape): Remove.
5664         * utils.c (can_emit_style_escape): Likewise.
5665         Update all callers of can_emit_style_escape (SOMESTREAM) to
5666         SOMESTREAM->can_emit_style_escape.
5667         * source-cache.c (source_cache::get_source_lines): Likewise.
5668         * stack.c (frame_apply_command_count): Call execute_command_to_string
5669         passing the term_out characteristic of the current gdb_stdout.
5670         * thread.c (thr_try_catch_cmd): Likewise.
5671         * top.c (execute_command_to_string): pass term_out parameter
5672         to construct the string_file for the command output.
5673         * ui-file.c (term_cli_styling): New function (most code moved
5674         from utils.c can_emit_style_escape).
5675         (string_file::string_file, string_file::can_emit_style_escape,
5676         stdio_file::can_emit_style_escape, tee_file::term_out,
5677         tee_file::can_emit_style_escape): New functions.
5678
5679 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5680
5681         * NEWS: Mention the new set|show may-call-functions.
5682         * infcall.c (may_call_functions_p): New variable.
5683         (show_may_call_functions_p): New function.
5684         (call_function_by_hand_dummy): Throws an error if not
5685         may-call-functions.
5686         (_initialize_infcall): Call add_setshow_boolean_cmd for
5687         may-call-functions.
5688
5689 2019-04-25  Keith Seitz  <keiths@redhat.com>
5690
5691         PR c++/24367
5692         * cp-support.c (inspect_type): Don't attempt substitutions
5693         of symbol with the same name.
5694
5695 2019-04-25  Tom Tromey  <tromey@adacore.com>
5696
5697         PR gdb/24475:
5698         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5699         static.
5700
5701 2019-04-25  Tom Tromey  <tromey@adacore.com>
5702
5703         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5704         rvalue reference.
5705         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5706         (gdb_xml_parser::parse): Use std::move.
5707         * python/python-internal.h (gdbpy_convert_exception): Take a const
5708         reference.
5709         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5710         std::move.
5711         * python/py-utils.c (gdbpy_convert_exception): Take a const
5712         reference.
5713         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5714         Use std::move.
5715         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5716         Use std::move.
5717         * mi/mi-main.c (mi_print_exception): Take a const reference.
5718         * main.c (handle_command_errors): Take a const reference.
5719         * linespec.c (parse_linespec): Use std::move.
5720         * infcall.c (run_inferior_call): Use std::move.
5721         (call_function_by_hand_dummy): Use std::move.
5722         * exec.c (try_open_exec_file): Use std::move.
5723         * exceptions.h (exception_print, exception_fprintf)
5724         (exception_print_same): Update.
5725         * exceptions.c (print_exception, exception_print)
5726         (exception_fprintf, exception_print_same): Change parameters to
5727         const reference.
5728         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5729         * common/new-op.c: Use std::move.
5730         * common/common-exceptions.h (struct gdb_exception): Add move
5731         constructor.
5732         (struct gdb_exception_error, struct gdb_exception_quit, struct
5733         gdb_quit_bad_alloc): Change constructor to move constructor.
5734         (throw_exception): Change parameter to rvalue reference.
5735         * common/common-exceptions.c (throw_exception): Take rvalue
5736         reference.
5737         * cli/cli-interp.c (safe_execute_command): Use std::move.
5738         * breakpoint.c (insert_bp_location, location_to_sals): Use
5739         std::move.
5740
5741 2019-04-25  Tom Tromey  <tromey@adacore.com>
5742
5743         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5744         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5745         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5746         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5747         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5748         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5749         guile/scm-value.c: Use unpack.
5750         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5751         gdbscm_gdb_exception.
5752         (gdbscm_throw_gdb_exception): Likewise.
5753         (struct gdbscm_gdb_exception): New.
5754         (unpack): New function.
5755         (gdbscm_wrap): Use unpack.
5756
5757 2019-04-25  Tom Tromey  <tromey@adacore.com>
5758
5759         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5760         (gdb_rl_callback_handler): Use std::move.
5761         * common/common-exceptions.h (struct gdb_exception): Add move
5762         assignment operator.
5763         (throw_exception_sjlj): Change "exception" to const reference.
5764         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5765         (throw_exception_sjlj): Change "exception" to const reference.
5766
5767 2019-04-25  Tom Tromey  <tromey@adacore.com>
5768
5769         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5770         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5771         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5772         Update.
5773         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5774         Update.
5775         * mi/mi-interp.c (mi_interp::exec): Update.
5776         * linespec.c (parse_linespec): Update.
5777         * infcall.c (run_inferior_call): Update.
5778         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5779         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5780         (gdbscm_lookup_global_symbol): Update.
5781         * guile/scm-param.c (gdbscm_parameter_value): Update.
5782         * guile/scm-frame.c (gdbscm_frame_read_register)
5783         (gdbscm_frame_read_var): Update.
5784         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5785         * exec.c (try_open_exec_file): Update.
5786         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5787         (gdb_rl_callback_handler): Update.
5788         * common/common-exceptions.h (exception_none): Don't declare.
5789         * common/common-exceptions.c (exception_none): Don't define.
5790         (struct catcher) <exception>: Update.
5791         * cli/cli-interp.c (safe_execute_command): Update.
5792         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5793
5794 2019-04-25  Ali Tamur  <tamur@google.com>
5795
5796         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5797         (read_attribute_value): Likewise.
5798         (dwarf2_read_addr_index): Update comment.
5799         (read_str_index): Add DW_FORM_strx.
5800         (dwarf2_string_attr): Likewise.
5801         (dwarf2_const_value_attr): Likewise.
5802         (dump_die_shallow): Likewise.
5803         (dwarf2_fetch_constant_bytes): Likewise.
5804         (skip_form_bytes): Likewise.
5805         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5806
5807 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5808
5809         PR corefiles/11608
5810         PR corefiles/18187
5811         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5812         OFFSET.  Verify if current mapping contains an ELF header.
5813         (linux_find_memory_regions_full): Adjust call to
5814         dump_mapping_p.
5815
5816 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5817             Kang Li <kanglictf@gmail.com>
5818
5819         PR gdb/21600
5820
5821         * dwarf2-frame.c (read_initial_length): Be consistent about using
5822         unsigned representation of length.
5823         (decode_frame_entry_1): Likewise.  Check for wraparound of
5824         end pointer as well as buffer overflow.
5825
5826 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5827
5828         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5829         "vq".
5830
5831 2019-04-24  Tom Tromey  <tromey@adacore.com>
5832
5833         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5834
5835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5836
5837         * s12z-tdep.c (s12z_unwind_pc): Delete.
5838         (s12z_unwind_sp): Delete.
5839         (s12z_gdbarch_init): Don't register deleted functions with
5840         gdbarch.
5841
5842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5843
5844         * rl78-tdep.c (rl78_unwind_sp): Delete.
5845         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5846
5847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5848
5849         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5850         (xstormy16_unwind_pc): Delete.
5851         (xstormy16_dummy_id): Delete.
5852         (xstormy16_gdbarch_init): Don't register deleted functions with
5853         gdbarch.
5854
5855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * vax-tdep.c (vax_unwind_pc): Delete.
5858         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5859
5860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * v850-tdep.c (v850_unwind_sp): Delete.
5863         (v850_unwind_pc): Delete.
5864         (v850_dummy_id): Delete.
5865         (v850_gdbarch_init): Don't register deleted functions with
5866         gdbarch.
5867
5868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5869
5870         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5871         (tilegx_unwind_pc): Delete.
5872         (tilegx_unwind_dummy_id): Delete.
5873         (tilegx_gdbarch_init): Don't register deleted functions with
5874         gdbarch.
5875
5876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5877
5878         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5879         (tic6x_dummy_id): Delete.
5880         (tic6x_gdbarch_init): Don't register deleted functions with
5881         gdbarch.
5882
5883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * sparc-tdep.c (sparc_unwind_pc): Delete.
5886         (sparc32_gdbarch_init): Don't register deleted function with
5887         gdbarch.
5888
5889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5890
5891         * sh-tdep.c (sh_unwind_sp): Delete.
5892         (sh_unwind_pc): Delete.
5893         (sh_dummy_id): Delete.
5894         (sh_gdbarch_init): Don't register deleted functions with
5895         gdbarch.
5896
5897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * score-tdep.c (score_unwind_sp): Delete.
5900         (score_unwind_pc): Delete.
5901         (score_dummy_id): Delete.
5902         (score_gdbarch_init): Don't register deleted functions with
5903         gdbarch.
5904
5905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * rx-tdep.c (rx_unwind_pc): Delete.
5908         (rx_unwind_sp): Delete.
5909         (rx_dummy_id): Delete.
5910         (rx_gdbarch_init): Don't register deleted functions with
5911         gdbarch.  Update comment.
5912
5913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5916         (rs6000_dummy_id): Delete.
5917         (rs6000_gdbarch_init): Don't register deleted functions with
5918         gdbarch.
5919
5920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * or1k-tdep.c (or1k_dummy_id): Delete.
5923         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5924
5925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * nios2-tdep.c (nios2_dummy_id): Delete.
5928         (nios2_unwind_sp): Delete.
5929         (nios2_gdbarch_init): Don't register deleted functions with
5930         gdbarch.
5931
5932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * nds32-tdep.c (nds32_dummy_id): Delete.
5935         (nds32_unwind_pc): Delete.
5936         (nds32_unwind_sp): Delete.
5937         (nds32_gdbarch_init): Don't register deleted functions with
5938         gdbarch.
5939
5940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * msp430-tdep.c (msp430_unwind_pc): Delete.
5943         (msp430_unwind_sp): Delete.
5944         (msp430_dummy_id): Delete.
5945         (msp430_gdbarch_init): Don't register deleted functions with
5946         gdbarch.
5947
5948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * moxie-tdep.c (moxie_unwind_sp): Delete.
5951         (moxie_unwind_pc): Delete.
5952         (moxie_dummy_id): Delete.
5953         (moxie_gdbarch_init): Don't register deleted functions with
5954         gdbarch.
5955
5956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5959         (mn10300_unwind_pc): Delete.
5960         (mn10300_unwind_sp): Delete.
5961         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5962         mn10300_unwind_sp.
5963         (mn10300_frame_unwind_init): Don't register deleted functions with
5964         gdbarch.
5965
5966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * mep-tdep.c (mep_unwind_pc): Delete.
5969         (mep_unwind_sp): Delete.
5970         (mep_dummy_id): Delete.
5971         (mep_gdbarch_init): Don't register deleted functions with
5972         gdbarch.
5973
5974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5975
5976         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5977         (m68hc11_unwind_sp): Delete.
5978         (m68hc11_gdbarch_init): Don't register deleted functions with
5979         gdbarch.
5980
5981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * m32r-tdep.c (m32r_unwind_sp): Delete.
5984         (m32r_unwind_pc): Delete.
5985         (m32r_dummy_id): Delete.
5986         (m32r_gdbarch_init): Don't register deleted functions with
5987         gdbarch.
5988
5989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5990
5991         * m32c-tdep.c (m32c_unwind_pc): Delete.
5992         (m32c_unwind_sp): Delete.
5993         (m32c_dummy_id): Delete.
5994         (m32c_gdbarch_init): Don't register deleted functions with
5995         gdbarch.
5996
5997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6000         (lm32_unwind_pc): Delete.
6001         (lm32_dummy_id): Delete.
6002         (lm32_gdbarch_init): Don't register deleted functions with
6003         gdbarch.
6004
6005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6006
6007         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6008         (iq2000_unwind_pc): Delete.
6009         (iq2000_dummy_id): Delete.
6010         (iq2000_gdbarch_init): Don't register deleted functions with
6011         gdbarch.
6012
6013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6014
6015         * nds32-tdep.c (nds32_type_align): Delete.
6016         (nds32_push_dummy_call): Use type_align instead.
6017
6018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6019
6020         * arm-tdep.c (arm_type_align): Only handle vector override case.
6021         (arm_push_dummy_call): Use type_align.
6022         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6023
6024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6025
6026         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6027         case.
6028         (pass_on_stack): Use type_align.
6029         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6030         function.
6031
6032 2019-04-23  Tom Tromey  <tromey@adacore.com>
6033
6034         * dwarf2read.c (line_header::file_name_at): Remove unused
6035         overload.
6036
6037 2019-04-23  Tom de Vries  <tdevries@suse.de>
6038
6039         PR gdb/24438
6040         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6041         invocation.
6042
6043
6044 2019-03-27  Ali Tamur  <tamur@google.com>
6045
6046         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6047         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6048         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6049         (dwarf_expr_context::get_addr_index): Likewise
6050         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6051         (symbol_needs_eval_context::get_addr_index): Likewise
6052         (disassemble_dwarf_expression): Add DW_OP_addrx
6053         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6054         (read_cutu_die_from_dwo): Update comment
6055         (skip_one_die): Add DW_FORM_addrx
6056         (read_attribute_value): Likewise
6057         (var_decode_location): Add DW_OP_addrx
6058         (dwarf2_const_value_attr): Add DW_FORM_addrx
6059         (dump_die_shallow): Likewise
6060         (dwarf2_fetch_constant_bytes): Likewise
6061         (decode_locdesc): Add DW_OP_addrx
6062         (skip_form_bytes): Add DW_FORM_addrx
6063
6064 2019-04-22  Ali Tamur  <tamur@google.com>
6065
6066         * MAINTAINERS (Write After Approval): Add self.
6067
6068 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6069
6070         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6071         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6072         (open_symbol_file_object): Likewise.
6073         (svr4_default_sos): Add info parameter.
6074         (svr4_read_so_list): Likewise.
6075         (svr4_current_sos_direct): Adjust functions calls to pass down
6076         info.
6077         (svr4_current_sos_1): Add info parameter.
6078         (svr4_current_sos): Call get_svr4_info, pass info down to
6079         svr4_current_sos_1.
6080         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6081         get_svr4_info.
6082         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6083         get_svr4_info.
6084         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6085         to get_svr4_info.
6086         (probes_table_remove_objfile_probes): Likewise.
6087         (register_solib_event_probe): Add info parameter.
6088         (solist_update_incremental): Pass info parameter down to
6089         svr4_read_so_list.
6090         (disable_probes_interface): Add info parameter.
6091         (svr4_handle_solib_event): Pass current_program_space to
6092         get_svr4_info.  Adjust disable_probes_interface cleanup.
6093         (svr4_create_probe_breakpoints): Add info parameter, pass it
6094         down to register_solib_event_probe.
6095         (svr4_create_solib_event_breakpoints): Add info parameter,
6096         pass it down to svr4_create_probe_breakpoints.
6097         (enable_break): Pass info down to
6098         svr4_create_solib_event_breakpoints.
6099         (svr4_solib_create_inferior_hook): Pass current_program_space to
6100         get_svr4_info.
6101         (svr4_clear_solib): Likewise.
6102
6103 2019-04-22  Pedro Alves  <palves@redhat.com>
6104
6105         * solib-svr4.c (svr4_free_objfile_observer): New.
6106         (probe_and_action::objfile): New field.
6107         (probes_table_htab_remove_objfile_probes)
6108         (probes_table_remove_objfile_probes): New functions.
6109         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6110         in the new probe_and_action.  Don't store the probe in 'lookup'.
6111         (svr4_create_probe_breakpoints): Pass objfile to
6112         register_solib_event_probe.
6113         (_initialize_svr4_solib): Register a free_objfile observer.
6114
6115 2019-04-19  Tom Tromey  <tom@tromey.com>
6116
6117         * common/queue.h: Remove.
6118
6119 2019-04-19  Tom Tromey  <tom@tromey.com>
6120
6121         * event-loop.c: Don't include "common/queue.h".
6122
6123 2019-04-19  Tom Tromey  <tom@tromey.com>
6124
6125         * remote.c (remote_target): Use delete.
6126         * remote-notif.h: Include <list>, not "common/queue.h".
6127         (notif_client_p): Remove typedef.
6128         (remote_notif_state): Add constructor, destructor, initializer.
6129         <notif_queue>: Now a std::list.
6130         (remote_notif_state_xfree): Don't declare.
6131         * remote-notif.c (remote_notif_process, handle_notification)
6132         (remote_notif_state_allocate): Update.
6133         (~remote_notif_state): Rename from remote_notif_state_xfree.
6134
6135 2019-04-19  Tom Tromey  <tom@tromey.com>
6136
6137         * symfile.c (reread_symbols): Update.
6138         * objfiles.c (objfile_register_static_link)
6139         (objfile_lookup_static_link): Update
6140         (~objfile) Don't delete static_links.
6141         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6142
6143 2019-04-19  Tom Tromey  <tom@tromey.com>
6144
6145         * type-stack.h (struct type_stack) <insert>: Constify string.
6146         * type-stack.c (type_stack::insert): Constify string.
6147         * gdbtypes.h (lookup_template_type): Update.
6148         (address_space_name_to_int): Update.
6149         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6150         const.
6151         (lookup_template_type): Make name const.
6152         * c-exp.y: Update rules.
6153         (lex_one_token, classify_name, classify_inner_name)
6154         (c_print_token): Update.
6155         * p-exp.y: Update rules.
6156         (yylex): Update.
6157         * f-exp.y: Update rules.
6158         (yylex): Update.
6159         * d-exp.y: Update rules.
6160         (lex_one_token, classify_name, classify_inner_name): Update.
6161         * parse.c (write_dollar_variable, copy_name): Return std::string.
6162         * parser-defs.h (copy_name): Change return type.
6163         * m2-exp.y: Update rules.
6164         (yylex): Update.
6165         * go-exp.y (lex_one_token): Update.
6166         Update rules.
6167         (classify_unsafe_function, classify_packaged_name)
6168         (classify_name, yylex): Update.
6169
6170 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6171
6172         * configure.ac: add --enable-source-highlight switch.
6173         * configure: Regenerate.
6174         * top.c (print_gdb_version): plumb --enable-source-highlight
6175         status to "show configuration".
6176
6177 2019-04-19  Tom Tromey  <tromey@adacore.com>
6178
6179         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6180         Check ADA_TYPE_P.
6181         (empty_record, ada_template_to_fixed_record_type_1)
6182         (template_to_static_fixed_type)
6183         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6184         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6185         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6186         macros.
6187
6188 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6189
6190         PR symtab/24423:
6191         * source.c (print_source_lines_base): Advance "iter" when a
6192         control character is seen.
6193
6194 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6195
6196         * inferior.h (struct infcall_suspend_state_deleter):
6197         Catch exception in destructor to avoid crash.
6198
6199 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6200
6201         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6202         close to the add_com "shell".
6203
6204 2019-04-18  Tom Tromey  <tromey@adacore.com>
6205
6206         * process-stratum-target.h (class process_stratum_target)
6207         <stratum>: Add "final".
6208
6209 2019-04-17  Tom Tromey  <tromey@adacore.com>
6210
6211         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6212         against nullptr before use.
6213
6214 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6215
6216         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6217
6218 2019-04-17  Jim Wilson  <jimw@sifive.com>
6219             Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6222         code read might fail, assume 4-byte breakpoint in that case.
6223
6224 2019-04-15  Leszek Swirski  <leszeks@google.com>
6225
6226         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6227         rather than a hand-rolled POD check when checking for forced MEMORY
6228         classification.
6229
6230 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6231
6232         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6233         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6234         function.
6235         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6236         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6237         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6238         declaration.
6239
6240 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6241
6242         * aarch64-linux-nat.c
6243         (aarch64_linux_nat_target::thread_architecture): Add override.
6244         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6245         each VQ.
6246
6247 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6248
6249         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6250
6251 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6252
6253         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6254         target types of size 96-bits, add some additional comments, and
6255         check that the builtin type we found was the correct size.
6256
6257 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6258
6259         * utils.c (prompt_for_continue): Don't restore the styling at the
6260         end, as applied_style has the wrong value.  This fixes styling in
6261         long lists of file names that are interrupted by the "Continue?"
6262         prompt.
6263
6264 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6267         * c-lang.c (c_language_defn): Likewise.
6268         (cplus_language_defn): Likewise.
6269         (asm_language_defn): Likewise.
6270         (minimal_language_defn): Likewise.
6271         * d-lang.c (d_language_defn): Likewise.
6272         * f-lang.c (f_language_defn): Likewise.
6273         * go-lang.c (go_language_defn): Likewise.
6274         * language.c (unknown_language_defn): Likewise.
6275         (auto_language_defn): Likewise.
6276         * language.h (struct language_defn): Remove la_magic field.
6277         (LANG_MAGIC): Delete.
6278         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6279         * objc-lang.c (objc_language_defn): Likewise.
6280         * opencl-lang.c (opencl_language_defn): Likewise.
6281         * p-lang.c (pascal_language_defn): Likewise.
6282         * rust-lang.c (rust_language_defn): Likewise.
6283
6284 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * riscv-tdep.c (riscv_type_align): New function.
6287         (riscv_type_alignment): Delete.
6288         (riscv_arg_location): Use 'type_align'.
6289         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6290
6291 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6292
6293         * gdbtypes.c (type_align): A struct with no non-static fields also
6294         has alignment of 1.
6295
6296 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6299         component to 0.
6300         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6301         member.
6302         (riscv_struct_info::analyse): New implementation using new
6303         analyse_inner member function.
6304         (riscv_struct_info::field_offset): New member function.
6305         (riscv_struct_info::m_offsets): New member variable.
6306         (riscv_struct_info::analyse_inner): New private member function,
6307         takes the old implementation of riscv_struct_info::analyse but
6308         extended to track field offsets.
6309         (riscv_call_arg_struct): Update the struct folding special cases
6310         to handle cases where empty C++ structs, which are non-zero
6311         length, are found.
6312         (riscv_arg_location): Initialise the length of each location, a
6313         non-zero length now indicates the location is in use.
6314         (riscv_push_dummy_call): Allow for the first location having a
6315         non-zero offset when setting up arguments.
6316         (riscv_return_value): Likewise, but for return values.
6317
6318 2019-04-11  Tom Tromey  <tromey@adacore.com>
6319
6320         * utils.c (internal_vproblem): Make "msg" const.
6321
6322 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6323
6324         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6325         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6326         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6327         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6328
6329 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6330
6331         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6332         function.
6333         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6334         of amd64_collect_native_gregset.
6335         (amd64_linux_nat_target::store_registers): Likewise.
6336
6337 2019-04-10  Tom Tromey  <tom@tromey.com>
6338
6339         * symtab.c (lookup_global_symbol_from_objfile)
6340         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6341         * objfiles.h (class separate_debug_iterator): New.
6342         (class separate_debug_range): New.
6343         (struct objfile) <separate_debug_objfiles>: New method.
6344         (objfile_separate_debug_iterate): Don't declare.
6345         * objfiles.c (separate_debug_iterator::operator++): Rename from
6346         objfile_separate_debug_iterate.
6347         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6348         iterator.
6349         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6350         iterator.
6351
6352 2019-04-10  Tom Tromey  <tom@tromey.com>
6353
6354         * symfile.c (reread_symbols): Remove old comment.
6355         * objfiles.c (free_all_objfiles): Fix a typo.
6356
6357 2019-04-10  Tom Tromey  <tom@tromey.com>
6358
6359         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6360         * minsyms.c (lookup_minimal_symbol): Use foreach.
6361         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6362         (lookup_minimal_symbol_solib_trampoline): Likewise.
6363         * symfile.c (reread_symbols): Use foreach.
6364
6365 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6366             Tom Tromey  <tromey@adacore.com>
6367
6368         PR rust/24414:
6369         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6370         (rust_lex_int_test): Change "value" to be LONGEST.
6371         (rust_lex_tests): Add test for long integer literal.
6372
6373 2019-04-09  Tom Tromey  <tromey@adacore.com>
6374
6375         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6376         to bool.
6377         (extended_remote_target::attach): Update.
6378         (remote_target::remote_notice_new_inferior): Update.
6379         (remote_target::add_current_inferior_and_thread): Update.
6380         * inferior.c (exit_inferior_1): Use "false".
6381         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6382
6383 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6384
6385         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6386         the "start" command.
6387
6388 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6389
6390         * python/py-inferior.c (infpy_thread_from_thread_handle):
6391         Adjust comments to reflect renaming of thread_from_thread_handle
6392         to thread_from_handle.  Adjust keywords.  Fix type error message.
6393         (inferior_object_methods): Add thread_from_handle.  Retain
6394         thread_from_thread_handle, but mark it as deprecated.
6395
6396 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6397
6398         * gdbthread.h (find_thread_by_handle): Revise declaration.
6399         * thread.c (find_thread_by_handle): Likewise.  Adjust
6400         implementation too.
6401         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6402         support for buffer objects as handles.
6403
6404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6405
6406         * python/py-infthread.c (thpy_thread_handle): New function.
6407         (thread_object_methods): Register thpy_thread_handle.
6408
6409 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6410
6411         * gdbthread.h (thread_to_thread_handle): Declare.
6412         * thread.c (gdbtypes.h): Include.
6413         (thread_to_thread_handle): New function.
6414
6415         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6416         (target_thread_info_to_thread_handle): Declare.
6417         * target.c (target_thread_info_to_thread_handle): New function.
6418         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6419         * target-delegates.c: Regenerate.
6420
6421         * linux-thread-db.c (class thread_db_target): Add method
6422         thread_info_to_thread_handle.
6423         (thread_db_target::thread_info_to_thread_handle): Define.
6424         * remote.c (class remote_target): Add new method
6425         thread_info_to_thread_handle.
6426         (remote_target::thread_info_to_thread_handle): Define.
6427
6428 2019-04-08  Pedro Alves  <palves@redhat.com>
6429
6430         * common/common-exceptions.c (throw_exception): Don't create
6431         named object to throw; throw directly.
6432         (throw_it): Likewise.  Don't initialize gdb_exception::message
6433         here, with new; pass FMT and AP to the ctor instead.
6434         * common/common-exceptions.h: Include <string>.
6435         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6436         const char *, va_list)): New ctor.  Use std::make_shared.
6437         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6438         errors)): Delete.
6439         (gdb_exception_error::gdb_exception_error(enum errors, const char
6440         *, va_list)): New.
6441         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6442         Add assertion.
6443         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6444         errors)): Delete.
6445         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6446         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6447         Add assertion.
6448
6449 2019-04-08  Tom Tromey  <tom@tromey.com>
6450
6451         * valops.c (value_rtti_indirect_type): Replace throw_exception
6452         with throw.
6453         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6454         with throw.
6455         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6456         throw.
6457         * target.c (target_translate_tls_address): Replace throw_exception
6458         with throw.
6459         * stack.c (frame_apply_command_count): Replace throw_exception
6460         with throw.
6461         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6462         throw.
6463         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6464         with throw.
6465         * rs6000-tdep.c (rs6000_frame_cache)
6466         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6467         * remote.c: Replace throw_exception with throw.
6468         * record-full.c (record_full_message, record_full_wait_1)
6469         (record_full_restore): Replace throw_exception with throw.
6470         * record-btrace.c:
6471         (get_thread_current_frame_id, record_btrace_start_replaying)
6472         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6473         (cmd_record_btrace_start): Replace throw_exception with throw.
6474         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6475         throw.
6476         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6477         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6478         * linespec.c:
6479         (find_linespec_symbols): Replace throw_exception with throw.
6480         * infrun.c (displaced_step_prepare, resume): Replace
6481         throw_exception with throw.
6482         * infcmd.c (post_create_inferior): Replace throw_exception with
6483         throw.
6484         * inf-loop.c (inferior_event_handler): Replace throw_exception
6485         with throw.
6486         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6487         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6488         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6489         (get_prev_frame_always, get_frame_pc_if_available)
6490         (get_frame_address_in_block_if_available, get_frame_language):
6491         Replace throw_exception with throw.
6492         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6493         throw_exception with throw.
6494         * eval.c (fetch_subexp_value, evaluate_var_value)
6495         (evaluate_funcall, evaluate_subexp_standard): Replace
6496         throw_exception with throw.
6497         * dwarf2loc.c (call_site_find_chain)
6498         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6499         Replace throw_exception with throw.
6500         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6501         with throw.
6502         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6503         throw.
6504         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6505         * completer.c (complete_line_internal): Replace throw_exception
6506         with throw.
6507         * compile/compile-object-run.c (compile_object_run): Replace
6508         throw_exception with throw.
6509         * cli/cli-script.c (process_next_line): Replace throw_exception
6510         with throw.
6511         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6512         (btrace_enable, btrace_maint_update_pt_packets): Replace
6513         throw_exception with throw.
6514         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6515         throw_exception with throw.
6516         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6517         throw_exception with throw.
6518         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6519         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6520         * aarch64-tdep.c (aarch64_make_prologue_cache)
6521         (aarch64_make_stub_cache): Replace throw_exception with throw.
6522
6523 2019-04-08  Tom Tromey  <tom@tromey.com>
6524
6525         * common/common-exceptions.c (throw_exception): Rename from
6526         throw_exception_cxx.  Remove old copy.  Make argument const.
6527         (throw_it): Create and throw exception objects directly.
6528         * common/common-exceptions.h (throw_exception): Make argument
6529         const.
6530         (struct gdb_exception_error): Add constructor.
6531         (struct gdb_exception_quit): Add constructor.
6532
6533 2019-04-08  Tom Tromey  <tom@tromey.com>
6534
6535         * common/common-exceptions.h (exception_rethrow): Don't declare.
6536         (TRY_SJLJ): Update comment.
6537         (TRY, CATCH, END_CATCH): Remove.
6538         * common/common-exceptions.c (exception_rethrow): Remove.
6539
6540 2019-04-08  Tom Tromey  <tom@tromey.com>
6541
6542         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6543         Remove.
6544         (gdb_exception_error): Rename from
6545         gdb_exception_RETURN_MASK_ERROR.
6546         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6547         (gdb_quit_bad_alloc): Update.
6548         * aarch64-tdep.c: Update.
6549         * ada-lang.c: Update.
6550         * ada-typeprint.c: Update.
6551         * ada-valprint.c: Update.
6552         * amd64-tdep.c: Update.
6553         * arch-utils.c: Update.
6554         * break-catch-throw.c: Update.
6555         * breakpoint.c: Update.
6556         * btrace.c: Update.
6557         * c-varobj.c: Update.
6558         * cli/cli-cmds.c: Update.
6559         * cli/cli-interp.c: Update.
6560         * cli/cli-script.c: Update.
6561         * common/common-exceptions.c: Update.
6562         * common/new-op.c: Update.
6563         * common/selftest.c: Update.
6564         * compile/compile-c-symbols.c: Update.
6565         * compile/compile-cplus-symbols.c: Update.
6566         * compile/compile-object-load.c: Update.
6567         * compile/compile-object-run.c: Update.
6568         * completer.c: Update.
6569         * corelow.c: Update.
6570         * cp-abi.c: Update.
6571         * cp-support.c: Update.
6572         * cp-valprint.c: Update.
6573         * darwin-nat.c: Update.
6574         * disasm-selftests.c: Update.
6575         * dtrace-probe.c: Update.
6576         * dwarf-index-cache.c: Update.
6577         * dwarf-index-write.c: Update.
6578         * dwarf2-frame-tailcall.c: Update.
6579         * dwarf2-frame.c: Update.
6580         * dwarf2loc.c: Update.
6581         * dwarf2read.c: Update.
6582         * eval.c: Update.
6583         * event-loop.c: Update.
6584         * event-top.c: Update.
6585         * exec.c: Update.
6586         * f-valprint.c: Update.
6587         * fbsd-tdep.c: Update.
6588         * frame-unwind.c: Update.
6589         * frame.c: Update.
6590         * gdbtypes.c: Update.
6591         * gnu-v3-abi.c: Update.
6592         * guile/guile-internal.h: Update.
6593         * guile/scm-block.c: Update.
6594         * guile/scm-breakpoint.c: Update.
6595         * guile/scm-cmd.c: Update.
6596         * guile/scm-disasm.c: Update.
6597         * guile/scm-frame.c: Update.
6598         * guile/scm-lazy-string.c: Update.
6599         * guile/scm-math.c: Update.
6600         * guile/scm-param.c: Update.
6601         * guile/scm-ports.c: Update.
6602         * guile/scm-pretty-print.c: Update.
6603         * guile/scm-symbol.c: Update.
6604         * guile/scm-symtab.c: Update.
6605         * guile/scm-type.c: Update.
6606         * guile/scm-value.c: Update.
6607         * i386-linux-tdep.c: Update.
6608         * i386-tdep.c: Update.
6609         * inf-loop.c: Update.
6610         * infcall.c: Update.
6611         * infcmd.c: Update.
6612         * infrun.c: Update.
6613         * jit.c: Update.
6614         * language.c: Update.
6615         * linespec.c: Update.
6616         * linux-fork.c: Update.
6617         * linux-nat.c: Update.
6618         * linux-tdep.c: Update.
6619         * linux-thread-db.c: Update.
6620         * main.c: Update.
6621         * mi/mi-cmd-break.c: Update.
6622         * mi/mi-cmd-stack.c: Update.
6623         * mi/mi-interp.c: Update.
6624         * mi/mi-main.c: Update.
6625         * objc-lang.c: Update.
6626         * p-valprint.c: Update.
6627         * parse.c: Update.
6628         * ppc-linux-tdep.c: Update.
6629         * printcmd.c: Update.
6630         * python/py-arch.c: Update.
6631         * python/py-breakpoint.c: Update.
6632         * python/py-cmd.c: Update.
6633         * python/py-finishbreakpoint.c: Update.
6634         * python/py-frame.c: Update.
6635         * python/py-framefilter.c: Update.
6636         * python/py-gdb-readline.c: Update.
6637         * python/py-inferior.c: Update.
6638         * python/py-infthread.c: Update.
6639         * python/py-lazy-string.c: Update.
6640         * python/py-linetable.c: Update.
6641         * python/py-objfile.c: Update.
6642         * python/py-param.c: Update.
6643         * python/py-prettyprint.c: Update.
6644         * python/py-progspace.c: Update.
6645         * python/py-record-btrace.c: Update.
6646         * python/py-record.c: Update.
6647         * python/py-symbol.c: Update.
6648         * python/py-type.c: Update.
6649         * python/py-unwind.c: Update.
6650         * python/py-utils.c: Update.
6651         * python/py-value.c: Update.
6652         * python/python.c: Update.
6653         * record-btrace.c: Update.
6654         * record-full.c: Update.
6655         * remote-fileio.c: Update.
6656         * remote.c: Update.
6657         * riscv-tdep.c: Update.
6658         * rs6000-aix-tdep.c: Update.
6659         * rs6000-tdep.c: Update.
6660         * rust-exp.y: Update.
6661         * rust-lang.c: Update.
6662         * s390-tdep.c: Update.
6663         * selftest-arch.c: Update.
6664         * solib-dsbt.c: Update.
6665         * solib-frv.c: Update.
6666         * solib-spu.c: Update.
6667         * solib-svr4.c: Update.
6668         * solib.c: Update.
6669         * sparc64-linux-tdep.c: Update.
6670         * stack.c: Update.
6671         * symfile-mem.c: Update.
6672         * symmisc.c: Update.
6673         * target.c: Update.
6674         * thread.c: Update.
6675         * top.c: Update.
6676         * tracefile-tfile.c: Update.
6677         * tui/tui.c: Update.
6678         * typeprint.c: Update.
6679         * unittests/cli-utils-selftests.c: Update.
6680         * unittests/parse-connection-spec-selftests.c: Update.
6681         * valops.c: Update.
6682         * valprint.c: Update.
6683         * value.c: Update.
6684         * varobj.c: Update.
6685         * windows-nat.c: Update.
6686         * x86-linux-nat.c: Update.
6687         * xml-support.c: Update.
6688
6689 2019-04-08  Tom Tromey  <tom@tromey.com>
6690
6691         * xml-support.c: Use C++ exception handling.
6692         * x86-linux-nat.c: Use C++ exception handling.
6693         * windows-nat.c: Use C++ exception handling.
6694         * varobj.c: Use C++ exception handling.
6695         * value.c: Use C++ exception handling.
6696         * valprint.c: Use C++ exception handling.
6697         * valops.c: Use C++ exception handling.
6698         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6699         handling.
6700         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6701         * typeprint.c: Use C++ exception handling.
6702         * tui/tui.c: Use C++ exception handling.
6703         * tracefile-tfile.c: Use C++ exception handling.
6704         * top.c: Use C++ exception handling.
6705         * thread.c: Use C++ exception handling.
6706         * target.c: Use C++ exception handling.
6707         * symmisc.c: Use C++ exception handling.
6708         * symfile-mem.c: Use C++ exception handling.
6709         * stack.c: Use C++ exception handling.
6710         * sparc64-linux-tdep.c: Use C++ exception handling.
6711         * solib.c: Use C++ exception handling.
6712         * solib-svr4.c: Use C++ exception handling.
6713         * solib-spu.c: Use C++ exception handling.
6714         * solib-frv.c: Use C++ exception handling.
6715         * solib-dsbt.c: Use C++ exception handling.
6716         * selftest-arch.c: Use C++ exception handling.
6717         * s390-tdep.c: Use C++ exception handling.
6718         * rust-lang.c: Use C++ exception handling.
6719         * rust-exp.y: Use C++ exception handling.
6720         * rs6000-tdep.c: Use C++ exception handling.
6721         * rs6000-aix-tdep.c: Use C++ exception handling.
6722         * riscv-tdep.c: Use C++ exception handling.
6723         * remote.c: Use C++ exception handling.
6724         * remote-fileio.c: Use C++ exception handling.
6725         * record-full.c: Use C++ exception handling.
6726         * record-btrace.c: Use C++ exception handling.
6727         * python/python.c: Use C++ exception handling.
6728         * python/py-value.c: Use C++ exception handling.
6729         * python/py-utils.c: Use C++ exception handling.
6730         * python/py-unwind.c: Use C++ exception handling.
6731         * python/py-type.c: Use C++ exception handling.
6732         * python/py-symbol.c: Use C++ exception handling.
6733         * python/py-record.c: Use C++ exception handling.
6734         * python/py-record-btrace.c: Use C++ exception handling.
6735         * python/py-progspace.c: Use C++ exception handling.
6736         * python/py-prettyprint.c: Use C++ exception handling.
6737         * python/py-param.c: Use C++ exception handling.
6738         * python/py-objfile.c: Use C++ exception handling.
6739         * python/py-linetable.c: Use C++ exception handling.
6740         * python/py-lazy-string.c: Use C++ exception handling.
6741         * python/py-infthread.c: Use C++ exception handling.
6742         * python/py-inferior.c: Use C++ exception handling.
6743         * python/py-gdb-readline.c: Use C++ exception handling.
6744         * python/py-framefilter.c: Use C++ exception handling.
6745         * python/py-frame.c: Use C++ exception handling.
6746         * python/py-finishbreakpoint.c: Use C++ exception handling.
6747         * python/py-cmd.c: Use C++ exception handling.
6748         * python/py-breakpoint.c: Use C++ exception handling.
6749         * python/py-arch.c: Use C++ exception handling.
6750         * printcmd.c: Use C++ exception handling.
6751         * ppc-linux-tdep.c: Use C++ exception handling.
6752         * parse.c: Use C++ exception handling.
6753         * p-valprint.c: Use C++ exception handling.
6754         * objc-lang.c: Use C++ exception handling.
6755         * mi/mi-main.c: Use C++ exception handling.
6756         * mi/mi-interp.c: Use C++ exception handling.
6757         * mi/mi-cmd-stack.c: Use C++ exception handling.
6758         * mi/mi-cmd-break.c: Use C++ exception handling.
6759         * main.c: Use C++ exception handling.
6760         * linux-thread-db.c: Use C++ exception handling.
6761         * linux-tdep.c: Use C++ exception handling.
6762         * linux-nat.c: Use C++ exception handling.
6763         * linux-fork.c: Use C++ exception handling.
6764         * linespec.c: Use C++ exception handling.
6765         * language.c: Use C++ exception handling.
6766         * jit.c: Use C++ exception handling.
6767         * infrun.c: Use C++ exception handling.
6768         * infcmd.c: Use C++ exception handling.
6769         * infcall.c: Use C++ exception handling.
6770         * inf-loop.c: Use C++ exception handling.
6771         * i386-tdep.c: Use C++ exception handling.
6772         * i386-linux-tdep.c: Use C++ exception handling.
6773         * guile/scm-value.c: Use C++ exception handling.
6774         * guile/scm-type.c: Use C++ exception handling.
6775         * guile/scm-symtab.c: Use C++ exception handling.
6776         * guile/scm-symbol.c: Use C++ exception handling.
6777         * guile/scm-pretty-print.c: Use C++ exception handling.
6778         * guile/scm-ports.c: Use C++ exception handling.
6779         * guile/scm-param.c: Use C++ exception handling.
6780         * guile/scm-math.c: Use C++ exception handling.
6781         * guile/scm-lazy-string.c: Use C++ exception handling.
6782         * guile/scm-frame.c: Use C++ exception handling.
6783         * guile/scm-disasm.c: Use C++ exception handling.
6784         * guile/scm-cmd.c: Use C++ exception handling.
6785         * guile/scm-breakpoint.c: Use C++ exception handling.
6786         * guile/scm-block.c: Use C++ exception handling.
6787         * guile/guile-internal.h: Use C++ exception handling.
6788         * gnu-v3-abi.c: Use C++ exception handling.
6789         * gdbtypes.c: Use C++ exception handling.
6790         * frame.c: Use C++ exception handling.
6791         * frame-unwind.c: Use C++ exception handling.
6792         * fbsd-tdep.c: Use C++ exception handling.
6793         * f-valprint.c: Use C++ exception handling.
6794         * exec.c: Use C++ exception handling.
6795         * event-top.c: Use C++ exception handling.
6796         * event-loop.c: Use C++ exception handling.
6797         * eval.c: Use C++ exception handling.
6798         * dwarf2read.c: Use C++ exception handling.
6799         * dwarf2loc.c: Use C++ exception handling.
6800         * dwarf2-frame.c: Use C++ exception handling.
6801         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6802         * dwarf-index-write.c: Use C++ exception handling.
6803         * dwarf-index-cache.c: Use C++ exception handling.
6804         * dtrace-probe.c: Use C++ exception handling.
6805         * disasm-selftests.c: Use C++ exception handling.
6806         * darwin-nat.c: Use C++ exception handling.
6807         * cp-valprint.c: Use C++ exception handling.
6808         * cp-support.c: Use C++ exception handling.
6809         * cp-abi.c: Use C++ exception handling.
6810         * corelow.c: Use C++ exception handling.
6811         * completer.c: Use C++ exception handling.
6812         * compile/compile-object-run.c: Use C++ exception handling.
6813         * compile/compile-object-load.c: Use C++ exception handling.
6814         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6815         * compile/compile-c-symbols.c: Use C++ exception handling.
6816         * common/selftest.c: Use C++ exception handling.
6817         * common/new-op.c: Use C++ exception handling.
6818         * cli/cli-script.c: Use C++ exception handling.
6819         * cli/cli-interp.c: Use C++ exception handling.
6820         * cli/cli-cmds.c: Use C++ exception handling.
6821         * c-varobj.c: Use C++ exception handling.
6822         * btrace.c: Use C++ exception handling.
6823         * breakpoint.c: Use C++ exception handling.
6824         * break-catch-throw.c: Use C++ exception handling.
6825         * arch-utils.c: Use C++ exception handling.
6826         * amd64-tdep.c: Use C++ exception handling.
6827         * ada-valprint.c: Use C++ exception handling.
6828         * ada-typeprint.c: Use C++ exception handling.
6829         * ada-lang.c: Use C++ exception handling.
6830         * aarch64-tdep.c: Use C++ exception handling.
6831
6832 2019-04-08  Tom Tromey  <tom@tromey.com>
6833
6834         * xml-support.c (gdb_xml_parser::parse): Update.
6835         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6836         * value.c (show_convenience): Update.
6837         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6838         (test_parse_flags_qcs): Update.
6839         * thread.c (thr_try_catch_cmd): Update.
6840         * target.c (target_translate_tls_address): Update.
6841         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6842         (info_frame_command_core, frame_apply_command_count): Update.
6843         * rust-exp.y (rust_lex_exception_test): Update.
6844         * riscv-tdep.c (riscv_print_one_register_info): Update.
6845         * remote.c (remote_target::enable_btrace): Update.
6846         * record-btrace.c (record_btrace_enable_warn): Update.
6847         * python/py-utils.c (gdbpy_convert_exception): Update.
6848         * printcmd.c (do_one_display, print_variable_and_value): Update.
6849         * mi/mi-main.c (mi_print_exception): Update.
6850         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6851         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6852         * linux-nat.c (linux_nat_target::attach): Update.
6853         * linux-fork.c (class scoped_switch_fork_info): Update.
6854         * infrun.c (displaced_step_prepare): Update.
6855         * infcall.c (call_function_by_hand_dummy): Update.
6856         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6857         * gnu-v3-abi.c (print_one_vtable): Update.
6858         * frame.c (get_prev_frame_always): Update.
6859         * f-valprint.c (info_common_command_for_block): Update.
6860         * exec.c (try_open_exec_file): Update.
6861         * exceptions.c (print_exception, exception_print)
6862         (exception_fprintf, exception_print_same): Update.
6863         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6864         * dwarf-index-cache.c (index_cache::store)
6865         (index_cache::lookup_gdb_index): Update.
6866         * darwin-nat.c (maybe_cache_shell): Update.
6867         * cp-valprint.c (cp_print_value_fields): Update.
6868         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6869         (gcc_cplus_symbol_address): Update.
6870         * compile/compile-c-symbols.c (gcc_convert_symbol)
6871         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6872         * common/selftest.c: Update.
6873         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6874         a std::string.
6875         (exception_try_scope_entry, exception_try_scope_exit): Don't
6876         declare.
6877         (struct exception_try_scope): Remove.
6878         (TRY): Don't use exception_try_scope.
6879         (struct gdb_exception): Add constructor, operator=.
6880         <what>: New method.
6881         (struct gdb_exception_RETURN_MASK_ALL)
6882         (struct gdb_exception_RETURN_MASK_ERROR)
6883         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6884         (struct gdb_quit_bad_alloc): Update.
6885         * common/common-exceptions.c (exception_none): Change
6886         initializer.
6887         (struct catcher) <state, exception>: Initialize inline.
6888         <prev>: Remove member.
6889         (current_catcher): Remove.
6890         (catchers): New global.
6891         (exceptions_state_mc_init): Simplify.
6892         (catcher_pop): Remove.
6893         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6894         (try_scope_depth, exception_try_scope_entry)
6895         (exception_try_scope_exit): Remove.
6896         (throw_exception_sjlj): Update.
6897         (exception_messages, exception_messages_size): Remove.
6898         (throw_it): Simplify.
6899         (gdb_exception_sliced_copy): Remove.
6900         (throw_exception_cxx): Update.
6901         * cli/cli-script.c (script_from_file): Update.
6902         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6903         Update.
6904         * ada-valprint.c (ada_val_print): Update.
6905         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6906         (create_excep_cond_exprs): Update.
6907
6908 2019-04-08  Tom Tromey  <tom@tromey.com>
6909
6910         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6911         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6912         (TRY, CATCH, END_CATCH): Remove some definitions.
6913         * common/common-exceptions.c: Don't use GDB_XCPT.
6914         (catcher_list_size): Remove.
6915         (throw_exception, throw_it): Simplify.
6916
6917 2019-04-05  Tom Tromey  <tom@tromey.com>
6918
6919         Revert the header-sorting patch.
6920         * ft32-tdep.c: Revert.
6921         * frv-tdep.c: Revert.
6922         * frv-linux-tdep.c: Revert.
6923         * frame.c: Revert.
6924         * frame-unwind.c: Revert.
6925         * frame-base.c: Revert.
6926         * fork-child.c: Revert.
6927         * findvar.c: Revert.
6928         * findcmd.c: Revert.
6929         * filesystem.c: Revert.
6930         * filename-seen-cache.h: Revert.
6931         * filename-seen-cache.c: Revert.
6932         * fbsd-tdep.c: Revert.
6933         * fbsd-nat.h: Revert.
6934         * fbsd-nat.c: Revert.
6935         * f-valprint.c: Revert.
6936         * f-typeprint.c: Revert.
6937         * f-lang.c: Revert.
6938         * extension.h: Revert.
6939         * extension.c: Revert.
6940         * extension-priv.h: Revert.
6941         * expprint.c: Revert.
6942         * exec.h: Revert.
6943         * exec.c: Revert.
6944         * exceptions.c: Revert.
6945         * event-top.c: Revert.
6946         * event-loop.c: Revert.
6947         * eval.c: Revert.
6948         * elfread.c: Revert.
6949         * dwarf2read.h: Revert.
6950         * dwarf2read.c: Revert.
6951         * dwarf2loc.c: Revert.
6952         * dwarf2expr.h: Revert.
6953         * dwarf2expr.c: Revert.
6954         * dwarf2-frame.c: Revert.
6955         * dwarf2-frame-tailcall.c: Revert.
6956         * dwarf-index-write.h: Revert.
6957         * dwarf-index-write.c: Revert.
6958         * dwarf-index-common.c: Revert.
6959         * dwarf-index-cache.h: Revert.
6960         * dwarf-index-cache.c: Revert.
6961         * dummy-frame.c: Revert.
6962         * dtrace-probe.c: Revert.
6963         * disasm.h: Revert.
6964         * disasm.c: Revert.
6965         * disasm-selftests.c: Revert.
6966         * dictionary.c: Revert.
6967         * dicos-tdep.c: Revert.
6968         * demangle.c: Revert.
6969         * dcache.h: Revert.
6970         * dcache.c: Revert.
6971         * darwin-nat.h: Revert.
6972         * darwin-nat.c: Revert.
6973         * darwin-nat-info.c: Revert.
6974         * d-valprint.c: Revert.
6975         * d-namespace.c: Revert.
6976         * d-lang.c: Revert.
6977         * ctf.c: Revert.
6978         * csky-tdep.c: Revert.
6979         * csky-linux-tdep.c: Revert.
6980         * cris-tdep.c: Revert.
6981         * cris-linux-tdep.c: Revert.
6982         * cp-valprint.c: Revert.
6983         * cp-support.c: Revert.
6984         * cp-namespace.c: Revert.
6985         * cp-abi.c: Revert.
6986         * corelow.c: Revert.
6987         * corefile.c: Revert.
6988         * continuations.c: Revert.
6989         * completer.h: Revert.
6990         * completer.c: Revert.
6991         * complaints.c: Revert.
6992         * coffread.c: Revert.
6993         * coff-pe-read.c: Revert.
6994         * cli-out.h: Revert.
6995         * cli-out.c: Revert.
6996         * charset.c: Revert.
6997         * c-varobj.c: Revert.
6998         * c-valprint.c: Revert.
6999         * c-typeprint.c: Revert.
7000         * c-lang.c: Revert.
7001         * buildsym.c: Revert.
7002         * buildsym-legacy.c: Revert.
7003         * build-id.h: Revert.
7004         * build-id.c: Revert.
7005         * btrace.c: Revert.
7006         * bsd-uthread.c: Revert.
7007         * breakpoint.h: Revert.
7008         * breakpoint.c: Revert.
7009         * break-catch-throw.c: Revert.
7010         * break-catch-syscall.c: Revert.
7011         * break-catch-sig.c: Revert.
7012         * blockframe.c: Revert.
7013         * block.c: Revert.
7014         * bfin-tdep.c: Revert.
7015         * bfin-linux-tdep.c: Revert.
7016         * bfd-target.c: Revert.
7017         * bcache.c: Revert.
7018         * ax-general.c: Revert.
7019         * ax-gdb.h: Revert.
7020         * ax-gdb.c: Revert.
7021         * avr-tdep.c: Revert.
7022         * auxv.c: Revert.
7023         * auto-load.c: Revert.
7024         * arm-wince-tdep.c: Revert.
7025         * arm-tdep.c: Revert.
7026         * arm-symbian-tdep.c: Revert.
7027         * arm-pikeos-tdep.c: Revert.
7028         * arm-obsd-tdep.c: Revert.
7029         * arm-nbsd-tdep.c: Revert.
7030         * arm-nbsd-nat.c: Revert.
7031         * arm-linux-tdep.c: Revert.
7032         * arm-linux-nat.c: Revert.
7033         * arm-fbsd-tdep.c: Revert.
7034         * arm-fbsd-nat.c: Revert.
7035         * arm-bsd-tdep.c: Revert.
7036         * arch-utils.c: Revert.
7037         * arc-tdep.c: Revert.
7038         * arc-newlib-tdep.c: Revert.
7039         * annotate.h: Revert.
7040         * annotate.c: Revert.
7041         * amd64-windows-tdep.c: Revert.
7042         * amd64-windows-nat.c: Revert.
7043         * amd64-tdep.c: Revert.
7044         * amd64-sol2-tdep.c: Revert.
7045         * amd64-obsd-tdep.c: Revert.
7046         * amd64-obsd-nat.c: Revert.
7047         * amd64-nbsd-tdep.c: Revert.
7048         * amd64-nbsd-nat.c: Revert.
7049         * amd64-nat.c: Revert.
7050         * amd64-linux-tdep.c: Revert.
7051         * amd64-linux-nat.c: Revert.
7052         * amd64-fbsd-tdep.c: Revert.
7053         * amd64-fbsd-nat.c: Revert.
7054         * amd64-dicos-tdep.c: Revert.
7055         * amd64-darwin-tdep.c: Revert.
7056         * amd64-bsd-nat.c: Revert.
7057         * alpha-tdep.c: Revert.
7058         * alpha-obsd-tdep.c: Revert.
7059         * alpha-nbsd-tdep.c: Revert.
7060         * alpha-mdebug-tdep.c: Revert.
7061         * alpha-linux-tdep.c: Revert.
7062         * alpha-linux-nat.c: Revert.
7063         * alpha-bsd-tdep.c: Revert.
7064         * alpha-bsd-nat.c: Revert.
7065         * aix-thread.c: Revert.
7066         * agent.c: Revert.
7067         * addrmap.c: Revert.
7068         * ada-varobj.c: Revert.
7069         * ada-valprint.c: Revert.
7070         * ada-typeprint.c: Revert.
7071         * ada-tasks.c: Revert.
7072         * ada-lang.c: Revert.
7073         * aarch64-tdep.c: Revert.
7074         * aarch64-ravenscar-thread.c: Revert.
7075         * aarch64-newlib-tdep.c: Revert.
7076         * aarch64-linux-tdep.c: Revert.
7077         * aarch64-linux-nat.c: Revert.
7078         * aarch64-fbsd-tdep.c: Revert.
7079         * aarch64-fbsd-nat.c: Revert.
7080         * aarch32-linux-nat.c: Revert.
7081
7082 2019-04-05  Tom Tromey  <tom@tromey.com>
7083
7084         * ft32-tdep.c: Sort headers.
7085         * frv-tdep.c: Sort headers.
7086         * frv-linux-tdep.c: Sort headers.
7087         * frame.c: Sort headers.
7088         * frame-unwind.c: Sort headers.
7089         * frame-base.c: Sort headers.
7090         * fork-child.c: Sort headers.
7091         * findvar.c: Sort headers.
7092         * findcmd.c: Sort headers.
7093         * filesystem.c: Sort headers.
7094         * filename-seen-cache.h: Sort headers.
7095         * filename-seen-cache.c: Sort headers.
7096         * fbsd-tdep.c: Sort headers.
7097         * fbsd-nat.h: Sort headers.
7098         * fbsd-nat.c: Sort headers.
7099         * f-valprint.c: Sort headers.
7100         * f-typeprint.c: Sort headers.
7101         * f-lang.c: Sort headers.
7102         * extension.h: Sort headers.
7103         * extension.c: Sort headers.
7104         * extension-priv.h: Sort headers.
7105         * expprint.c: Sort headers.
7106         * exec.h: Sort headers.
7107         * exec.c: Sort headers.
7108         * exceptions.c: Sort headers.
7109         * event-top.c: Sort headers.
7110         * event-loop.c: Sort headers.
7111         * eval.c: Sort headers.
7112         * elfread.c: Sort headers.
7113         * dwarf2read.h: Sort headers.
7114         * dwarf2read.c: Sort headers.
7115         * dwarf2loc.c: Sort headers.
7116         * dwarf2expr.h: Sort headers.
7117         * dwarf2expr.c: Sort headers.
7118         * dwarf2-frame.c: Sort headers.
7119         * dwarf2-frame-tailcall.c: Sort headers.
7120         * dwarf-index-write.h: Sort headers.
7121         * dwarf-index-write.c: Sort headers.
7122         * dwarf-index-common.c: Sort headers.
7123         * dwarf-index-cache.h: Sort headers.
7124         * dwarf-index-cache.c: Sort headers.
7125         * dummy-frame.c: Sort headers.
7126         * dtrace-probe.c: Sort headers.
7127         * disasm.h: Sort headers.
7128         * disasm.c: Sort headers.
7129         * disasm-selftests.c: Sort headers.
7130         * dictionary.c: Sort headers.
7131         * dicos-tdep.c: Sort headers.
7132         * demangle.c: Sort headers.
7133         * dcache.h: Sort headers.
7134         * dcache.c: Sort headers.
7135         * darwin-nat.h: Sort headers.
7136         * darwin-nat.c: Sort headers.
7137         * darwin-nat-info.c: Sort headers.
7138         * d-valprint.c: Sort headers.
7139         * d-namespace.c: Sort headers.
7140         * d-lang.c: Sort headers.
7141         * ctf.c: Sort headers.
7142         * csky-tdep.c: Sort headers.
7143         * csky-linux-tdep.c: Sort headers.
7144         * cris-tdep.c: Sort headers.
7145         * cris-linux-tdep.c: Sort headers.
7146         * cp-valprint.c: Sort headers.
7147         * cp-support.c: Sort headers.
7148         * cp-namespace.c: Sort headers.
7149         * cp-abi.c: Sort headers.
7150         * corelow.c: Sort headers.
7151         * corefile.c: Sort headers.
7152         * continuations.c: Sort headers.
7153         * completer.h: Sort headers.
7154         * completer.c: Sort headers.
7155         * complaints.c: Sort headers.
7156         * coffread.c: Sort headers.
7157         * coff-pe-read.c: Sort headers.
7158         * cli-out.h: Sort headers.
7159         * cli-out.c: Sort headers.
7160         * charset.c: Sort headers.
7161         * c-varobj.c: Sort headers.
7162         * c-valprint.c: Sort headers.
7163         * c-typeprint.c: Sort headers.
7164         * c-lang.c: Sort headers.
7165         * buildsym.c: Sort headers.
7166         * buildsym-legacy.c: Sort headers.
7167         * build-id.h: Sort headers.
7168         * build-id.c: Sort headers.
7169         * btrace.c: Sort headers.
7170         * bsd-uthread.c: Sort headers.
7171         * breakpoint.h: Sort headers.
7172         * breakpoint.c: Sort headers.
7173         * break-catch-throw.c: Sort headers.
7174         * break-catch-syscall.c: Sort headers.
7175         * break-catch-sig.c: Sort headers.
7176         * blockframe.c: Sort headers.
7177         * block.c: Sort headers.
7178         * bfin-tdep.c: Sort headers.
7179         * bfin-linux-tdep.c: Sort headers.
7180         * bfd-target.c: Sort headers.
7181         * bcache.c: Sort headers.
7182         * ax-general.c: Sort headers.
7183         * ax-gdb.h: Sort headers.
7184         * ax-gdb.c: Sort headers.
7185         * avr-tdep.c: Sort headers.
7186         * auxv.c: Sort headers.
7187         * auto-load.c: Sort headers.
7188         * arm-wince-tdep.c: Sort headers.
7189         * arm-tdep.c: Sort headers.
7190         * arm-symbian-tdep.c: Sort headers.
7191         * arm-pikeos-tdep.c: Sort headers.
7192         * arm-obsd-tdep.c: Sort headers.
7193         * arm-nbsd-tdep.c: Sort headers.
7194         * arm-nbsd-nat.c: Sort headers.
7195         * arm-linux-tdep.c: Sort headers.
7196         * arm-linux-nat.c: Sort headers.
7197         * arm-fbsd-tdep.c: Sort headers.
7198         * arm-fbsd-nat.c: Sort headers.
7199         * arm-bsd-tdep.c: Sort headers.
7200         * arch-utils.c: Sort headers.
7201         * arc-tdep.c: Sort headers.
7202         * arc-newlib-tdep.c: Sort headers.
7203         * annotate.h: Sort headers.
7204         * annotate.c: Sort headers.
7205         * amd64-windows-tdep.c: Sort headers.
7206         * amd64-windows-nat.c: Sort headers.
7207         * amd64-tdep.c: Sort headers.
7208         * amd64-sol2-tdep.c: Sort headers.
7209         * amd64-obsd-tdep.c: Sort headers.
7210         * amd64-obsd-nat.c: Sort headers.
7211         * amd64-nbsd-tdep.c: Sort headers.
7212         * amd64-nbsd-nat.c: Sort headers.
7213         * amd64-nat.c: Sort headers.
7214         * amd64-linux-tdep.c: Sort headers.
7215         * amd64-linux-nat.c: Sort headers.
7216         * amd64-fbsd-tdep.c: Sort headers.
7217         * amd64-fbsd-nat.c: Sort headers.
7218         * amd64-dicos-tdep.c: Sort headers.
7219         * amd64-darwin-tdep.c: Sort headers.
7220         * amd64-bsd-nat.c: Sort headers.
7221         * alpha-tdep.c: Sort headers.
7222         * alpha-obsd-tdep.c: Sort headers.
7223         * alpha-nbsd-tdep.c: Sort headers.
7224         * alpha-mdebug-tdep.c: Sort headers.
7225         * alpha-linux-tdep.c: Sort headers.
7226         * alpha-linux-nat.c: Sort headers.
7227         * alpha-bsd-tdep.c: Sort headers.
7228         * alpha-bsd-nat.c: Sort headers.
7229         * aix-thread.c: Sort headers.
7230         * agent.c: Sort headers.
7231         * addrmap.c: Sort headers.
7232         * ada-varobj.c: Sort headers.
7233         * ada-valprint.c: Sort headers.
7234         * ada-typeprint.c: Sort headers.
7235         * ada-tasks.c: Sort headers.
7236         * ada-lang.c: Sort headers.
7237         * aarch64-tdep.c: Sort headers.
7238         * aarch64-ravenscar-thread.c: Sort headers.
7239         * aarch64-newlib-tdep.c: Sort headers.
7240         * aarch64-linux-tdep.c: Sort headers.
7241         * aarch64-linux-nat.c: Sort headers.
7242         * aarch64-fbsd-tdep.c: Sort headers.
7243         * aarch64-fbsd-nat.c: Sort headers.
7244         * aarch32-linux-nat.c: Sort headers.
7245
7246 2019-04-04  Tom Tromey  <tom@tromey.com>
7247
7248         * varobj.c (varobj_create): Update.
7249         * rust-exp.y (struct rust_parser) <update_innermost_block,
7250         lookup_symbol>: New methods.
7251         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7252         Rename.
7253         (rust_parser::rust_lookup_type)
7254         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7255         * printcmd.c (display_command, do_one_display): Update.
7256         * parser-defs.h (struct parser_state) <parser_state>: Add
7257         "tracker" parameter.
7258         (block_tracker): New member.
7259         (class innermost_block_tracker) <innermost_block_tracker>: Add
7260         "types" parameter.
7261         <reset>: Remove method.
7262         (innermost_block): Don't declare.
7263         (null_post_parser): Update.
7264         * parse.c (innermost_block): Remove global.
7265         (write_dollar_variable): Update.
7266         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7267         Remove "tracker_types" parameter.
7268         (parse_expression): Add "tracker" parameter.
7269         (parse_expression_for_completion): Update.
7270         (null_post_parser): Add "tracker" parameter.
7271         * p-exp.y: Update rules.
7272         * m2-exp.y: Update rules.
7273         * language.h (struct language_defn) <la_post_parser>: Add
7274         "tracker" parameter.
7275         * go-exp.y: Update rules.
7276         * f-exp.y: Update rules.
7277         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7278         parameter.
7279         * d-exp.y: Update rules.
7280         * c-exp.y: Update rules.
7281         * breakpoint.c (set_breakpoint_condition): Create an
7282         innermost_block_tracker.
7283         (watch_command_1): Likewise.
7284         * ada-lang.c (resolve): Add "tracker" parameter.
7285         (resolve_subexp): Likewise.
7286         * ada-exp.y (write_var_from_sym): Update.
7287
7288 2019-04-04  Tom Tromey  <tom@tromey.com>
7289
7290         * type-stack.h: New file.
7291         * type-stack.c: New file.
7292         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7293         type-stack.h.
7294         (insert_into_type_stack, insert_type, push_type, push_type_int)
7295         (insert_type_address_space, pop_type, pop_type_int)
7296         (pop_typelist, pop_type_stack, append_type_stack)
7297         (push_type_stack, get_type_stack, push_typelist)
7298         (follow_type_instance_flags, follow_types): Don't declare.
7299         * parse.c (type_stack): Remove global.
7300         (parse_exp_in_context): Update.
7301         (insert_into_type_stack, insert_type, push_type, push_type_int)
7302         (insert_type_address_space, pop_type, pop_type_int)
7303         (pop_typelist, pop_type_stack, append_type_stack)
7304         (push_type_stack, get_type_stack, push_typelist)
7305         (follow_type_instance_flags, follow_types): Remove (moved to
7306         type-stack.c).
7307         * f-exp.y (type_stack): New global.
7308         Update rules.
7309         (push_kind_type, f_parse): Update.
7310         * d-exp.y (type_stack): New global.
7311         Update rules.
7312         (d_parse): Update.
7313         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7314         Update rules.
7315         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7316         (HFILES_NO_SRCDIR): Add type-stack.h.
7317
7318 2019-04-04  Tom Tromey  <tom@tromey.com>
7319
7320         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7321         (rust_parser::convert_ast_to_expression, rust_parse)
7322         (rust_lex_test_completion, rust_lex_tests): Update.
7323         * parser-defs.h (struct expr_completion_state): New.
7324         (struct parser_state) <parser_state>: Add completion parameter.
7325         <mark_struct_expression, mark_completion_tag>: New methods.
7326         <parse_completion, m_completion_state>: New members.
7327         (prefixify_expression, null_post_parser): Update.
7328         (mark_struct_expression, mark_completion_tag): Don't declare.
7329         * parse.c (parse_completion, expout_last_struct)
7330         (expout_tag_completion_type, expout_completion_name): Remove
7331         globals.
7332         (parser_state::mark_struct_expression)
7333         (parser_state::mark_completion_tag): Now methods.
7334         (prefixify_expression): Add last_struct parameter.
7335         (prefixify_subexp): Likewise.
7336         (parse_exp_1): Update.
7337         (parse_exp_in_context): Add cstate parameter.  Update.
7338         (parse_expression_for_completion): Create an
7339         expr_completion_state.
7340         (null_post_parser): Add "completion" parameter.
7341         * p-exp.y: Update rules.
7342         (yylex): Update.
7343         * language.h (struct language_defn) <la_post_parser>: Add
7344         "completing" parameter.
7345         * go-exp.y: Update rules.
7346         (lex_one_token): Update.
7347         * expression.h (parse_completion): Don't declare.
7348         * d-exp.y: Update rules.
7349         (lex_one_token): Update rules.
7350         * c-exp.y: Update rules.
7351         (lex_one_token): Update.
7352         * ada-lang.c (resolve): Add "parse_completion" parameter.
7353         (resolve_subexp): Likewise.
7354         (ada_resolve_function): Likewise.
7355
7356 2019-04-04  Tom Tromey  <tom@tromey.com>
7357
7358         * parser-defs.h (struct parser_state) <start_arglist,
7359         end_arglist>: New methods.
7360         <arglist_len, m_funcall_chain>: New members.
7361         (arglist_len, start_arglist, end_arglist): Don't declare.
7362         * parse.c (arglist_len, funcall_chain): Remove global.
7363         (start_arglist, end_arglist): Remove functions.
7364         (parse_exp_in_context): Update.
7365         * p-exp.y: Update rules.
7366         * m2-exp.y: Update rules.
7367         * go-exp.y: Update rules.
7368         * f-exp.y: Update rules.
7369         * d-exp.y: Update rules.
7370         * c-exp.y: Update rules.
7371
7372 2019-04-04  Tom Tromey  <tom@tromey.com>
7373
7374         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7375         lex_operator, push_back>: New methods.
7376         Update all rules.
7377         (rust_parser::lex_hex, lex_escape): Rename and update.
7378         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7379         (rust_parser::lex_operator): Rename and update.
7380         (rust_parser::lex_number, rustyylex, rustyyerror)
7381         (rust_lex_test_init, rust_lex_test_sequence)
7382         (rust_lex_test_push_back, rust_lex_tests): Update.
7383         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7384         parameter.
7385         <lexptr, prev_lexptr>: New members.
7386         (lexptr, prev_lexptr): Don't declare.
7387         * parse.c (lexptr, prev_lexptr): Remove globals.
7388         (parse_exp_in_context): Update.
7389         * p-exp.y (yylex, yyerror): Update.
7390         * m2-exp.y (parse_number, yylex, yyerror): Update.
7391         * go-exp.y (lex_one_token, yyerror): Update.
7392         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7393         * d-exp.y (lex_one_token, yyerror): Update.
7394         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7395         (lex_one_token, yyerror): Update.
7396         * ada-lex.l (YY_INPUT): Update.
7397         (rewind_to_char): Update.
7398         * ada-exp.y (yyerror): Update.
7399
7400 2019-04-04  Tom Tromey  <tom@tromey.com>
7401
7402         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7403         * parser-defs.h (struct parser_state) <parser_state>: Add new
7404         parameter.
7405         <comma_terminates>: New member.
7406         (comma_terminates): Don't declare global.
7407         * parse.c (comma_terminates): Remove global.
7408         (parse_exp_in_context): Update.
7409         * p-exp.y (yylex): Update.
7410         * m2-exp.y (yylex): Update.
7411         * go-exp.y (lex_one_token): Update.
7412         * f-exp.y (yylex): Update.
7413         * d-exp.y (lex_one_token): Update.
7414         * c-exp.y (lex_one_token): Update.
7415         * ada-lex.l: Update.
7416
7417 2019-04-04  Tom Tromey  <tom@tromey.com>
7418
7419         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7420         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7421         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7422         * parser-defs.h (paren_depth): Don't declare.
7423         * parse.c (paren_depth): Remove global.
7424         (parse_exp_in_context): Update.
7425         * p-exp.y (paren_depth): New global.
7426         (pascal_parse): Initialize it.
7427         * m2-exp.y (paren_depth): New global.
7428         (m2_parse): Initialize it.
7429         * go-exp.y (paren_depth): New global.
7430         (go_parse): Initialize it.
7431         * f-exp.y (paren_depth): New global.
7432         (f_parse): Initialize it.
7433         * d-exp.y (paren_depth): New global.
7434         (d_parse): Initialize it.
7435         * c-exp.y (paren_depth): New global.
7436         (c_parse): Initialize it.
7437         * ada-lex.l (paren_depth): New global.
7438         (lexer_init): Initialize it.
7439
7440 2019-04-04  Tom Tromey  <tom@tromey.com>
7441
7442         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7443         (rust_parser::convert_ast_to_type)
7444         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7445         * parser-defs.h (struct parser_state) <parser_state>: Add
7446         parameters.  Initialize new members.
7447         <expression_context_block, expression_context_pc>: New members.
7448         * parse.c (expression_context_block, expression_context_pc):
7449         Remove globals.
7450         (parse_exp_in_context): Update.
7451         * p-exp.y: Update all rules.
7452         (yylex): Update.
7453         * m2-exp.y: Update all rules.
7454         (yylex): Update.
7455         * go-exp.y (yylex): Update.
7456         * f-exp.y (yylex): Update.
7457         * d-exp.y: Update all rules.
7458         (yylex): Update.
7459         * c-exp.y: Update all rules.
7460         (lex_one_token, classify_name, yylex, c_parse): Update.
7461         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7462
7463 2019-04-04  Tom Tromey  <tom@tromey.com>
7464
7465         * gdbarch.h, gdbarch.c: Rebuild.
7466         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7467         * stap-probe.h:
7468         (struct stap_parse_info): Replace "parser_state" with
7469         "expr_builder".
7470         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7471         (parser_state): New class.
7472         * parse.c (expr_builder): Rename.
7473         (expr_builder::release): Rename.
7474         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7475         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7476         (write_exp_elt_longcst, write_exp_elt_floatcst)
7477         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7478         (write_exp_string_vector, write_exp_bitstring)
7479         (write_exp_msymbol, mark_struct_expression)
7480         (write_dollar_variable)
7481         (insert_type_address_space, increase_expout_size): Replace
7482         "parser_state" with "expr_builder".
7483         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7484         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7485         "parser_state" with "expr_builder".
7486
7487 2019-04-04  Tom Tromey  <tom@tromey.com>
7488
7489         * rust-exp.y: Replace "parse_language" with method call.
7490         * p-exp.y:
7491         (yylex): Replace "parse_language" with method call.
7492         * m2-exp.y:
7493         (yylex): Replace "parse_language" with method call.
7494         * go-exp.y (classify_name): Replace "parse_language" with method
7495         call.
7496         * f-exp.y (yylex): Replace "parse_language" with method call.
7497         * d-exp.y (lex_one_token): Replace "parse_language" with method
7498         call.
7499         * c-exp.y:
7500         (lex_one_token, classify_name, yylex): Replace "parse_language"
7501         with method call.
7502         * ada-exp.y (find_primitive_type, type_char)
7503         (type_system_address): Replace "parse_language" with method call.
7504
7505 2019-04-04  Tom Tromey  <tom@tromey.com>
7506
7507         * rust-exp.y: Replace "parse_gdbarch" with method call.
7508         * parse.c (write_dollar_variable, insert_type_address_space):
7509         Replace "parse_gdbarch" with method call.
7510         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7511         call.
7512         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7513         call.
7514         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7515         "parse_gdbarch" with method call.
7516         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7517         with method call.
7518         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7519         "parse_gdbarch" with method call.
7520         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7521         "parse_gdbarch" with method call.
7522         * c-exp.y (parse_type, parse_number, classify_name): Replace
7523         "parse_gdbarch" with method call.
7524         * ada-lex.l: Replace "parse_gdbarch" with method call.
7525         * ada-exp.y (parse_type, find_primitive_type, type_char)
7526         (type_system_address): Replace "parse_gdbarch" with method call.
7527
7528 2019-04-04  Tom Tromey  <tom@tromey.com>
7529
7530         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7531         * stap-probe.c (stap_parse_argument): Update.
7532         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7533         initial_size parameter.
7534         * rust-exp.y (rust_lex_tests): Update.
7535         * parse.c (parser_state): Update.
7536         (parse_exp_in_context): Update.
7537         * parser-defs.h (struct parser_state) <parser_state>: Remove
7538         "initial_size" parameter.
7539
7540 2019-04-04  Tom Tromey  <tom@tromey.com>
7541
7542         * parser-defs.h (increase_expout_size): Don't declare.
7543         * parse.c (increase_expout_size): Now static.
7544
7545 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7546
7547         * gnu-nat.c (gnu_nat_target::wait): Fix
7548         target_waitstatus_to_string call.
7549
7550 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * eval.c (evaluate_subexp_standard): Handle internal functions
7553         during Fortran function call handling.
7554
7555 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7556
7557         * NEWS: Mention new internal functions.
7558         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7559         (read_base_type): Use dwarf2_init_complex_target_type.
7560         * value.c (creal_internal_fn): New function.
7561         (cimag_internal_fn): New function.
7562         (_initialize_values): Register new internal functions.
7563
7564 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7565
7566         * infrun.c (stop_all_threads): If debug_infrun, always
7567         trace the wait status after wait_one, using
7568         target_waitstatus_to_string and target_pid_to_str.
7569         (handle_inferior_event): Replace various trace of
7570         wait status kind by a single trace.
7571         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7572         wait status kind image by target_waitstatus_to_string.
7573         * target/waitstatus.c (target_waitstatus_to_string): Fix
7574         obsolete comment.
7575
7576 2019-04-01  Tom Tromey  <tromey@adacore.com>
7577
7578         PR symtab/23331:
7579         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7580
7581 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7582             Pedro Alves  <palves@redhat.com>
7583
7584         * top.c (quit_force): Call 'finalize_values'.
7585         * value.c (finalize_values): New function.
7586         * value.h (finalize_values): Declare.
7587
7588 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7589
7590         * NEWS: Announce $_gdb_major and $_gdb_minor.
7591
7592         * top.c (init_gdb_version_vars): New function.
7593         (gdb_init): Call init_gdb_version_vars.
7594
7595 2019-03-29  Tom Tromey  <tromey@adacore.com>
7596
7597         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7598         help text.  Remove dead code.
7599
7600 2019-03-29  Keith Seitz  <keiths@redhat.com>
7601
7602         From Siddhesh Poyarekar:
7603         * f-lang.h (f77_get_upperbound): Return LONGEST.
7604         (f77_get_lowerbound): Likewise.
7605         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7606         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7607         print them.
7608         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7609         plongest to format print it.
7610         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7611         (f77_get_upperbound): Likewise.
7612         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7613         LOWER_BOUND to LONGEST.
7614         (f77_create_arrayprint_offset_tbl): Likewise.
7615
7616 2019-03-29  Keith Seitz  <keiths@redhat.com>
7617
7618         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7619         %s/pulongest for TYPE_LENGTH instead of %d in format
7620         strings.
7621         * ada-typerint.c (ada_print_type): Likewise.
7622         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7623         * compile/compile-c-support.c (generate_register_struct): Likewise.
7624         * gdbtypes.c (recursive_dump_type): Likewise.
7625         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7626         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7627         instead of %d in format strings.
7628         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7629         to std::min to ULONGEST.
7630         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7631         instead of %d in format strings.
7632         * tracepoint.c (info_scope_command): Likewise.
7633         * typeprint.c (print_offset_data::update)
7634         (print_offset_data::finish): Likewise.
7635         * xtensa-tdep.c (xtensa_store_return_value)
7636         (xtensa_push_dummy_call): Likewise.
7637
7638 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7639
7640         * windows-nat.c (display_selector): Fixed format specifications
7641         for 64-bit Cygwin.
7642
7643 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7644
7645         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7646
7647 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7648
7649         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7650         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7651         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7652         (nios2_linux_init_abi): Install it.
7653
7654 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7655
7656         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7657
7658 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7659
7660         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7661
7662 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7663             Tom Tromey  <tromey@adacore.com>
7664
7665         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7666
7667 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7668
7669         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7670         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7671         method to compute the bounds of range types. Also print "[evaluated]"
7672         if the bounds' values come from a dynamic evaluation.
7673
7674 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7675
7676         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7677         whitespace when pretty printing is on.
7678
7679 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7680
7681         * ppc-linux-nat.c: Add include.
7682
7683 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7684
7685         * NEWS: Mention AArch64 Pointer Authentication.
7686
7687 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7688
7689         * arm-linux-nat.c: Add include.
7690
7691 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7692
7693         * source-cache.c (source_cache::get_source_lines): Re-read
7694         fullname after calling open_source_file.
7695
7696 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7697
7698         * NEWS: Mention TLS support for FreeBSD.
7699
7700 2019-03-25  Tom Tromey  <tromey@adacore.com>
7701
7702         * minsyms.c (BUNCH_SIZE): Update comment.
7703         (~minimal_symbol_reader): Remove old comment.
7704         (compact_minimal_symbols): Update comment.
7705         (minimal_symbol_reader::install): Remove old comment.  Update
7706         other comments.
7707
7708 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7709
7710         * s390-linux-nat.c: Add include.
7711
7712 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7713
7714         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7715         Call linux_get_hwcap.
7716         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7717         Likewise.
7718         (aarch64_linux_get_hwcap): Remove function.
7719         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7720         declaration.
7721         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7722         linux_get_hwcap.
7723         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7724         * linux-tdep.c (linux_get_hwcap): Add function.
7725         (linux_get_hwcap2): Likewise.
7726         * linux-tdep.h (linux_get_hwcap): Add declaration.
7727         (linux_get_hwcap2): Likewise.
7728         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7729         (ppc_linux_get_hwcap2): Likewise.
7730         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7731         linux_get_hwcap.
7732         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7733         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7734         (ppc_linux_nat_target::read_description): Likewise.
7735         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7736         * s390-linux-nat.c: Likewise.
7737         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7738
7739 2019-03-24  Tom Tromey  <tom@tromey.com>
7740
7741         * ada-lang.c (standard_lookup): Simplify initialization.
7742         (ada_lookup_symbol_nonlocal): Simplify return.
7743         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7744         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7745         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7746         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7747         initialization.
7748         * solib.c (solib_global_lookup): Simplify.
7749         * symtab.c (null_block_symbol): Remove.
7750         (symbol_cache_lookup): Simplify returns.
7751         (lookup_language_this): Simplify returns.
7752         (lookup_symbol_aux): Simplify return.
7753         (lookup_local_symbol): Simplify returns.
7754         (lookup_global_symbol_from_objfile): Simplify return.
7755         (lookup_symbol_in_objfile_symtabs)
7756         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7757         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7758         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7759         * cp-namespace.c (cp_lookup_bare_symbol)
7760         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7761         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7762         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7763         (cp_lookup_symbol_via_imports): Simplify initialization.
7764         (find_symbol_in_baseclass): Likewise.
7765         * symtab.h (null_block_symbol): Remove.
7766         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7767         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7768         (d_lookup_symbol_module): Likewise.
7769         (find_symbol_in_baseclass): Simplify initialization.
7770
7771 2019-03-24  Tom Tromey  <tom@tromey.com>
7772
7773         * expression.h: Don't include symtab.h.
7774         (struct block): Forward declare.
7775
7776 2019-03-24  Tom Tromey  <tom@tromey.com>
7777
7778         * c-exp.y (typebase): Remove casts.
7779         * gdbtypes.c (lookup_unsigned_typename, )
7780         (lookup_signed_typename): Remove cast.
7781         * eval.c (parse_to_comma_and_eval): Remove cast.
7782         * parse.c (write_dollar_variable): Remove cast.
7783         * block.h (struct block) <superblock>: Now const.
7784         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7785         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7786         (map_block): Make "block" const.
7787         * symfile.h (struct quick_symbol_functions)
7788         <map_matching_symbols>: Constify block argument to "callback".
7789         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7790         const.
7791         (find_pc_sect_compunit_symtab): Make "b" const.
7792         (find_symbol_at_address): Likewise.
7793         (search_symbols): Likewise.
7794         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7795         (dw2_debug_names_lookup_symbol): Likewise.
7796         (dw2_map_matching_symbols): Update.
7797         * p-valprint.c (pascal_val_print): Remove "block".
7798         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7799         (aux_add_nonlocal_symbols): Make "block" const.
7800         (resolve_subexp): Remove cast.
7801         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7802         const.
7803         (iterate_over_file_blocks): Likewise.
7804         * f-exp.y (%union) <bval>: Remove.
7805         * coffread.c (patch_opaque_types): Make "b" const.
7806         * spu-tdep.c (spu_catch_start): Make "block" const.
7807         * c-valprint.c (print_unpacked_pointer): Remove "block".
7808         * symmisc.c (dump_symtab_1): Make "b" const.
7809         (block_depth): Make "block" const.
7810         * d-exp.y (%union) <bval>: Remove.
7811         * cp-support.h (cp_lookup_rtti_type): Update.
7812         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7813         * psymtab.c (psym_lookup_symbol): Make "block" const.
7814         (maintenance_check_psymtabs): Make "b" const.
7815         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7816         (enumerate_locals, enumerate_args): Update.
7817         * python/py-symtab.c (stpy_global_block): Make "block" const.
7818         (stpy_static_block): Likewise.
7819         * inline-frame.c (block_starting_point_at): Make "new_block"
7820         const.
7821         * block.c (find_block_in_blockvector): Make return type const.
7822         (blockvector_for_pc_sect): Make "b" const.
7823         (find_block_in_blockvector): Make "b" const.
7824
7825 2019-03-23  Tom Tromey  <tom@tromey.com>
7826
7827         * varobj.c (varobj_create): Update.
7828         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7829         * printcmd.c (display_command, do_one_display): Don't reset
7830         innermost_block.
7831         * parser-defs.h (enum innermost_block_tracker_type): Move to
7832         expression.h.
7833         (innermost_block): Update comment.
7834         * parse.c (parse_exp_1): Add tracker_types parameter.
7835         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7836         tracker_types parameter.  Reset innermost_block.
7837         (parse_exp_in_context): Remove.
7838         (parse_expression_for_completion): Update.
7839         * objfiles.c (~objfile): Don't reset expression_context_block or
7840         innermost_block.
7841         * expression.h (enum innermost_block_tracker_type): Move from
7842         parser-defs.h.
7843         (parse_exp_1): Add tracker_types parameter.
7844         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7845         reset innermost_block.
7846
7847 2019-03-23  Tom Tromey  <tom@tromey.com>
7848
7849         * objfiles.h: Include bcache.h.
7850
7851 2019-03-23  Tom Tromey  <tom@tromey.com>
7852
7853         * linespec.c (get_current_search_block): Use
7854         scoped_restore_current_language.
7855         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7856
7857 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7858             Jiong Wang  <jiong.wang@arm.com>
7859
7860         * aarch64-linux-tdep.c
7861         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7862         section.
7863         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7864
7865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7866             Jiong Wang  <jiong.wang@arm.com>
7867
7868         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7869         instructions.
7870         (aarch64_analyze_prologue_test): Add PACIASP test.
7871         (aarch64_prologue_prev_register): Unmask PC value.
7872
7873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7874             Jiong Wang  <jiong.wang@arm.com>
7875
7876         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7877         (aarch64_dwarf2_prev_register): Unmask PC value.
7878         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7879         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7880         DW_CFA_AARCH64_negate_ra_state.
7881         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7882
7883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7884             Jiong Wang  <jiong.wang@arm.com>
7885
7886         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7887         registers.
7888         (aarch64_pseudo_register_name): Likewise.
7889         (aarch64_pseudo_register_type): Likewise.
7890         (aarch64_pseudo_register_reggroup_p): Likewise.
7891         (aarch64_gdbarch_init): Add pauth registers.
7892         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7893         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7894         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7895         (struct gdbarch_tdep): Add regnum for ra_state.
7896
7897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7898             Jiong Wang  <jiong.wang@arm.com>
7899
7900         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7901
7902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7903             Jiong Wang  <jiong.wang@arm.com>
7904
7905         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7906         function.
7907         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7908         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7909         (aarch64_gdbarch_init): Add puth registers.
7910         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7911         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7912         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7913
7914 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7915             Jiong Wang  <jiong.wang@arm.com>
7916
7917         * aarch64-linux-nat.c
7918         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7919         * aarch64-linux-tdep.c
7920         (aarch64_linux_core_read_description): Likewise.
7921         (aarch64_linux_get_hwcap): New function.
7922         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7923         (aarch64_linux_get_hwcap): New declaration.
7924
7925 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7926             Jiong Wang  <jiong.wang@arm.com>
7927
7928         * aarch64-linux-nat.c
7929         (aarch64_linux_nat_target::read_description): Add pauth param.
7930         * aarch64-linux-tdep.c
7931         (aarch64_linux_core_read_description): Likewise.
7932         * aarch64-tdep.c (struct target_desc): Add in pauth.
7933         (aarch64_read_description): Add pauth param.
7934         (aarch64_gdbarch_init): Likewise.
7935         * aarch64-tdep.h (aarch64_read_description): Likewise.
7936         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7937         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7938         * features/Makefile: Add new files.
7939         * features/aarch64-pauth.c: New file.
7940         * features/aarch64-pauth.xml: New file.
7941
7942 2019-03-20  Tom Tromey  <tromey@adacore.com>
7943
7944         * infrun.c (handle_inferior_event): Rename from
7945         handle_inferior_event_1.  Create a scoped_value_mark.
7946         (handle_inferior_event): Remove.
7947
7948 2019-03-19  Tom Tromey  <tromey@adacore.com>
7949
7950         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7951         * infrun.h (print_stop_event): Add "displays" parameter.
7952         * infrun.c (print_stop_event): Add "displays" parameter.
7953
7954 2019-03-19  Pedro Alves  <palves@redhat.com>
7955
7956         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7957         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7958         to -1.  Fix TABs vs spaces.
7959         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7960         * tui/tui-out.h (tui_ui_out) Add intro comments.
7961         <m_line, m_start_of_line>: In-class initialize, and add describing
7962         comment.
7963
7964 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7965
7966         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7967         variable names.
7968         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7969
7970 2019-03-18  Pedro Alves  <palves@redhat.com>
7971             Eli Zaretskii <eliz@gnu.org>
7972
7973         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7974         m_line and m_start_of_line.
7975
7976 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7977
7978         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7979         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7980         it returns a newline.  This fixes a regression in TU mode, whereby
7981         the next line is output on the same screen line as the user input.
7982
7983 2019-03-18  Tom Tromey  <tromey@adacore.com>
7984
7985         * minsyms.c (minimal_symbol_reader::install): Remove call to
7986         obstack_blank.
7987
7988 2019-03-18  Pedro Alves  <palves@redhat.com>
7989
7990         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7991         New globals.
7992         (apply_style): New, factored out from ...
7993         (apply_ansi_escape): ... this.  Handle reverse video mode.
7994         (tui_set_reverse_mode): New function.
7995         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7996         * tui/tui-winsource.c (tui_show_source_line): Use
7997         tui_set_reverse_mode instead of setting A_STANDOUT.
7998         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7999         New setter methods.
8000
8001 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8002
8003         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8004         Handle tabs.
8005
8006 2019-03-18  Tom Tromey  <tromey@adacore.com>
8007
8008         * ada-lang.c (empty_array): Add "high" parameter.
8009         (ada_evaluate_subexp): Update.
8010
8011 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8012
8013         * unittests/string_view-selftests.c: Define
8014         _initialize_string_view_selftests unconditionally.
8015
8016 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8017
8018         PR gdb/24350
8019         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8020
8021 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8022
8023         PR gdb/24351
8024         * windows-nat.c (display_selector): Fix format specifiers.
8025
8026 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8027
8028         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8029         tui_refill_source_window instead of tui_refresh_win, to update the
8030         current execution line.  This fixes redisplay of the current line
8031         when stepping through the code with "next" or "step".
8032
8033 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8034
8035         * source-cache.c (source_cache::get_source_lines): Call
8036         find_source_lines to initialize s->nlines.  This fixes vertical
8037         scrolling of TUI source window when the DOWN arrow is pressed.
8038
8039 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8040
8041         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8042         linux-thread-db.c (_initialize_thread_db): Likewise.
8043
8044 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8045
8046         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8047         wclrtoeol in tui_show_source_line".  This reverts changes made in
8048         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8049
8050 2019-03-15  Tom Tromey  <tom@tromey.com>
8051
8052         * symtab.h (struct minimal_symbol): Derive from
8053         general_symbol_info.
8054         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8055         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8056         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8057         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8058         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8059         (MSYMBOL_SEARCH_NAME): Update.
8060         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8061         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8062         * minsyms.c (minimal_symbol_reader::record_full): Update.
8063
8064 2019-03-15  Tom Tromey  <tom@tromey.com>
8065
8066         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8067
8068 2019-03-15  Tom Tromey  <tom@tromey.com>
8069
8070         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8071         unique_xmalloc_ptr.
8072         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8073         Update.
8074         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8075         (build_minimal_symbol_hash_tables)
8076         (minimal_symbol_reader::install): Update.
8077
8078 2019-03-15  Tom Tromey  <tom@tromey.com>
8079
8080         * symtab.c (create_demangled_names_hash): Update.
8081         (symbol_set_names): Update.
8082         * objfiles.h (struct objfile_per_bfd_storage)
8083         <demangled_names_hash>: Now an htab_up.
8084         * objfiles.c (objfile_per_bfd_storage): Simplify.
8085
8086 2019-03-15  Tom Tromey  <tom@tromey.com>
8087
8088         * objfiles.h (struct objfile_per_bfd_storage): Declare
8089         destructor.
8090         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8091         New.
8092         (get_objfile_bfd_data): Use new.  Don't initialize
8093         language_of_main.
8094         (free_objfile_per_bfd_storage): Remove.
8095         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8096
8097 2019-03-15  Tom Tromey  <tom@tromey.com>
8098
8099         * symfile.c (reread_symbols): Update.
8100         * objfiles.c (objfile::objfile): Update.
8101         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8102         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8103         comment.
8104         (minimal_symbol_reader::install): Update.
8105         (terminate_minimal_symbol_table): Remove.
8106         * jit.c (jit_object_close_impl): Update.
8107
8108 2019-03-15  Tom Tromey  <tom@tromey.com>
8109
8110         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8111         initializations.
8112
8113 2019-03-15  Tom Tromey  <tom@tromey.com>
8114
8115         * objfiles.h (struct objfile_per_bfd_storage)
8116         <demangled_hash_languages>: Now a bitset.
8117         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8118         (lookup_minimal_symbol): Update.
8119
8120 2019-03-15  Tom Tromey  <tom@tromey.com>
8121
8122         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8123         Don't return the symbol.
8124         * coffread.c (record_minimal_symbol): Use record_full.
8125
8126 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8127
8128         The MS-Windows port of ncurses fails to switch to a color pair if
8129         one or both of the colors are the implicit default colors.  This
8130         change records the default colors when TUI is initialized, and
8131         then specifies them explicitly when a color pair uses the default
8132         colors.  This allows color styling in TUI mode on MS-Windows.
8133
8134         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8135         ncurses_norm_attr.
8136         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8137         colors in ncurses_norm_attr.
8138         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8139         "none", replace it with the default color recorded in
8140         ncurses_norm_attr.
8141
8142 2019-03-14  Tom Tromey  <tromey@adacore.com>
8143
8144         * source-cache.h (class source_cache) <get_source_lines>: Return
8145         std::string.
8146         * source-cache.c (source_cache::extract_lines): Handle case where
8147         first_pos==npos.  Return std::string.
8148         (source_cache::get_source_lines): Update.
8149
8150 2019-03-14  Tom Tromey  <tromey@adacore.com>
8151
8152         * NEWS: Add item for "style sources" commands.
8153         * source-cache.c (source_cache::get_source_lines): Check
8154         source_styling.
8155         * cli/cli-style.c (source_styling): New global.
8156         (_initialize_cli_style): Add "style sources" commands.
8157         (show_style_sources): New function.
8158         * cli/cli-style.h (source_styling): Declare.
8159
8160 2019-03-14  Pedro Alves  <palves@redhat.com>
8161             Tom Tromey  <tromey@adacore.com>
8162
8163         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8164         * tui/tui-winsource.c (tui_refill_source_window): New function,
8165         from...
8166         (tui_horizontal_source_scroll): ... here.  Move some logic.
8167         * cli/cli-style.c (set_style_enabled): Notify new observable.
8168         * tui/tui-hooks.c (tui_redisplay_source): New function.
8169         (tui_attach_detach_observers): Attach or detach
8170         tui_redisplay_source.
8171         * observable.h (source_styling_changed): New observable.
8172         * observable.c: Define source_styling_changed observable.
8173
8174 2019-03-13  Tom Tromey  <tromey@adacore.com>
8175
8176         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8177         (i386_gnu_nat_target::store_registers): Update.
8178         * target-debug.h (target_debug_print_std_string): New macro.
8179         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8180         * windows-tdep.c (display_one_tib): Update.
8181         * tui/tui-stack.c (tui_make_status_line): Update.
8182         * top.c (print_inferior_quit_action): Update.
8183         * thread.c (thr_try_catch_cmd): Update.
8184         (add_thread_with_info): Update.
8185         (thread_target_id_str): Update.
8186         (thr_try_catch_cmd): Update.
8187         (thread_command): Update.
8188         (thread_find_command): Update.
8189         * record-btrace.c (record_btrace_target::info_record)
8190         (record_btrace_resume_thread, record_btrace_target::resume)
8191         (record_btrace_cancel_resume, record_btrace_step_thread)
8192         (record_btrace_target::wait, record_btrace_target::wait)
8193         (record_btrace_target::wait, record_btrace_target::stop): Update.
8194         * progspace.c (print_program_space): Update.
8195         * process-stratum-target.c
8196         (process_stratum_target::thread_address_space): Update.
8197         * linux-fork.c (linux_fork_mourn_inferior)
8198         (detach_checkpoint_command, info_checkpoints_command)
8199         (linux_fork_context): Update.
8200         (linux_fork_detach): Update.
8201         (class scoped_switch_fork_info): Update.
8202         (delete_checkpoint_command): Update.
8203         * infrun.c (follow_fork_inferior): Update.
8204         (follow_fork_inferior): Update.
8205         (proceed_after_vfork_done): Update.
8206         (handle_vfork_child_exec_or_exit): Update.
8207         (follow_exec): Update.
8208         (displaced_step_prepare_throw): Update.
8209         (displaced_step_restore): Update.
8210         (start_step_over): Update.
8211         (resume_1): Update.
8212         (clear_proceed_status_thread): Update.
8213         (proceed): Update.
8214         (print_target_wait_results): Update.
8215         (do_target_wait): Update.
8216         (context_switch): Update.
8217         (stop_all_threads): Update.
8218         (restart_threads): Update.
8219         (finish_step_over): Update.
8220         (handle_signal_stop): Update.
8221         (switch_back_to_stepped_thread): Update.
8222         (keep_going_pass_signal): Update.
8223         (print_exited_reason): Update.
8224         (normal_stop): Update.
8225         * inferior.c (inferior_pid_to_str): Change return type.
8226         (print_selected_inferior): Update.
8227         (add_inferior): Update.
8228         (detach_inferior): Update.
8229         * dummy-frame.c (fprint_dummy_frames): Update.
8230         * dcache.c (dcache_info_1): Update.
8231         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8232         (btrace_fetch, btrace_clear): Update.
8233         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8234         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8235         type.
8236         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8237         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8238         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8239         * gdbarch.c, gdbarch.h: Rebuild.
8240         * gdbarch.sh (core_pid_to_str): Change return type.
8241         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8242         return type.
8243         (windows_nat_target::pid_to_str): Change return type.
8244         (windows_delete_thread): Update.
8245         (windows_nat_target::attach): Update.
8246         (windows_nat_target::files_info): Update.
8247         * target-delegates.c: Rebuild.
8248         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8249         return type.
8250         (sol_thread_target::pid_to_str): Change return type.
8251         * remote.c (class remote_target) <pid_to_str>: Change return
8252         type.
8253         (remote_target::pid_to_str): Change return type.
8254         (extended_remote_target::attach, remote_target::remote_stop_ns)
8255         (remote_target::remote_notif_remove_queued_reply)
8256         (remote_target::push_stop_reply, remote_target::disable_btrace):
8257         Update.
8258         (extended_remote_target::attach): Update.
8259         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8260         type.
8261         (gdbsim_target::pid_to_str): Change return type.
8262         * ravenscar-thread.c (struct ravenscar_thread_target)
8263         <pid_to_str>: Change return type.
8264         (ravenscar_thread_target::pid_to_str): Change return type.
8265         * procfs.c (class procfs_target) <pid_to_str>: Change return
8266         type.
8267         (procfs_target::pid_to_str): Change return type.
8268         (procfs_target::attach): Update.
8269         (procfs_target::detach): Update.
8270         (procfs_target::fetch_registers): Update.
8271         (procfs_target::store_registers): Update.
8272         (procfs_target::wait): Update.
8273         (procfs_target::files_info): Update.
8274         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8275         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8276         return type.
8277         (nto_procfs_target::pid_to_str): Change return type.
8278         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8279         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8280         return type.
8281         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8282         (exit_lwp): Update.
8283         (attach_proc_task_lwp_callback, get_detach_signal)
8284         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8285         (linux_nat_target::resume, wait_lwp, stop_callback)
8286         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8287         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8288         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8289         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8290         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8291         type.
8292         (inf_ptrace_target::attach): Update.
8293         (inf_ptrace_target::files_info): Update.
8294         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8295         type.
8296         (go32_nat_target::pid_to_str): Change return type.
8297         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8298         (gnu_nat_target::wait): Update.
8299         (gnu_nat_target::wait): Update.
8300         (gnu_nat_target::resume): Update.
8301         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8302         (fbsd_nat_target::wait): Update.
8303         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8304         type.
8305         (darwin_nat_target::attach): Update.
8306         * corelow.c (class core_target) <pid_to_str>: Change return type.
8307         (core_target::pid_to_str): Change return type.
8308         * target.c (normal_pid_to_str): Change return type.
8309         (default_pid_to_str): Likewise.
8310         (target_pid_to_str): Change return type.
8311         (target_translate_tls_address): Update.
8312         (target_announce_detach): Update.
8313         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8314         return type.
8315         (bsd_uthread_target::pid_to_str): Change return type.
8316         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8317         type.
8318         (bsd_kvm_target::pid_to_str): Change return type.
8319         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8320         return type.
8321         (aix_thread_target::pid_to_str): Change return type.
8322         * target.h (struct target_ops) <pid_to_str>: Change return type.
8323         (target_pid_to_str, normal_pid_to_str): Likewise.
8324         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8325         type.
8326         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8327         type.
8328         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8329         return type.
8330         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8331         type.
8332         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8333         type.
8334         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8335         return type.
8336
8337 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8338
8339         * NEWS: Mention that the new default MI version is 3.  Mention
8340         changes to the output of commands and events that deal with
8341         multi-location breakpoints.
8342         * breakpoint.c: Include "mi/mi-out.h".
8343         (print_one_breakpoint): Change output syntax if using MI version
8344         >= 3.
8345         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8346         New.
8347         (mi_multi_location_breakpoint_output_fixed): New.
8348         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8349         (mi_cmd_fix_multi_location_breakpoint_output): New.
8350         (mi_multi_location_breakpoint_output_fixed): New.
8351         * mi/mi-cmds.c (mi_cmds): Register command
8352         -fix-multi-location-breakpoint-output.
8353         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8354         interpreter "mi".
8355
8356 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8357
8358         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8359         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8360         instantiate mi_ui_out based on interpreter name.
8361         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8362         * mi/mi-main.c (mi_load_progress): Likewise.
8363
8364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8365
8366         * NEWS: Combine separate "New targets" sections for 8.3.
8367
8368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8369
8370         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8371         (ppcfbsd_init_abi): Install gdbarch
8372         "fetch_tls_load_module_address" and "get_thread_local_address"
8373         methods.
8374
8375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8376
8377         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8378         (riscv_fbsd_init_abi): Install gdbarch
8379         "fetch_tls_load_module_address" and "get_thread_local_address"
8380         methods.
8381
8382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8383
8384         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8385         (i386fbsd_init_abi): Install gdbarch
8386         "fetch_tls_load_module_address" and "get_thread_local_address"
8387         methods.
8388
8389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8390
8391         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8392         (amd64fbsd_init_abi): Install gdbarch
8393         "fetch_tls_load_module_address" and "get_thread_local_address"
8394         methods.
8395
8396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8397
8398         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8399         (struct fbsd_pspace_data): New type.
8400         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8401         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8402         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8403         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8404         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8405
8406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8407
8408         * gdbtypes.c (lookup_struct_elt): New function.
8409         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8410         * gdbtypes.h (struct struct_elt): New type.
8411         (lookup_struct_elt): New prototype.
8412
8413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8414
8415         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8416         remove disabled code block.
8417
8418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8419
8420         * gdbarch.sh (get_thread_local_address): New method.
8421         * gdbarch.h, gdbarch.c: Regenerate.
8422         * target.c (target_translate_tls_address): Use
8423         gdbarch_get_thread_local_address if present instead of
8424         target::get_thread_local_address.
8425
8426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8427
8428         * target.h (target::get_thread_local_address): Update comment.
8429
8430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8431
8432         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8433         objfile->separate_debug_objfile_backlink if not NULL.
8434
8435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8436
8437         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8438         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8439         (amd64bsd_store_inferior_registers): Likewise.
8440         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8441         Enable segment base registers.
8442         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8443         PT_GETFSBASE and PT_GETGSBASE.
8444         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8445         PT_SETGSBASE.
8446         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8447         segment base registers.
8448         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8449
8450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8451
8452         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8453         Update calls to i386_target_description to add 'segments'
8454         parameter.
8455         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8456         add segment base registers.
8457         * arch/i386.c (i386_create_target_description): Add 'segments'
8458         parameter to enable segment base registers.
8459         * arch/i386.h (i386_create_target_description): Likewise.
8460         * features/i386/32bit-segments.xml: New file.
8461         * features/i386/32bit-segments.c: Generate.
8462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8463         call to i386_target_description to add 'segments' parameter.
8464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8465         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8466         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8467         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8468         if feature is present.
8469         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8470         Add 'segments' parameter to call to i386_target_description.
8471         (i386_target_description): Add 'segments' parameter to enable
8472         segment base registers.
8473         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8474         to call to i386_target_description.
8475         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8476         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8477         Define I386_NUM_REGS.
8478         (i386_target_description): Add 'segments' parameter to enable
8479         segment base registers.
8480
8481 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8482
8483         PR/24325
8484         * source-cache.c: #undef open and close, to avoid unresolved
8485         externals during linking.
8486
8487 2019-03-12  Tom Tromey  <tromey@adacore.com>
8488
8489         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8490         const.  Add initializers.
8491         (_initialize_remote): Don't initialize ptid globals.
8492
8493 2019-03-12  Pedro Alves  <palves@redhat.com>
8494
8495         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8496
8497 2019-03-12  Pedro Alves  <palves@redhat.com>
8498
8499         * cp-name-parser.y (main): Remove unused 'len' variable.
8500
8501 2019-03-12  Tom Tromey  <tromey@adacore.com>
8502
8503         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8504         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8505
8506 2019-03-12  Tom Tromey  <tromey@adacore.com>
8507
8508         * linux-nat.c (iterate_over_lwps): Update.
8509         (stop_callback): Remove parameter.
8510         (stop_wait_callback, detach_callback, resume_set_callback)
8511         (select_singlestep_lwp_callback, set_ignore_sigint)
8512         (status_callback, resumed_callback, resume_clear_callback)
8513         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8514         data parameter.
8515         (linux_nat_target::detach, linux_nat_target::resume)
8516         (linux_stop_and_wait_all_lwps, select_event_lwp)
8517         (linux_nat_filter_event, linux_nat_wait_1)
8518         (linux_nat_target::kill, linux_nat_target::stop)
8519         (linux_nat_target::stop): Update.
8520         (linux_nat_resume_callback): Change type.
8521         (resume_stopped_resumed_lwps, count_events_callback)
8522         (select_event_lwp_callback): Likewise.
8523         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8524         * arm-linux-nat.c (struct update_registers_data): Remove.
8525         (update_registers_callback): Change type.
8526         (arm_linux_insert_hw_breakpoint1): Update.
8527         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8528         parameter.
8529         (x86_linux_dr_set_addr): Update.
8530         (x86_linux_dr_set_control): Update.
8531         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8532         (iterate_over_lwps): Use gdb::function_view.
8533         * nat/aarch64-linux-hw-point.c (struct
8534         aarch64_dr_update_callback_param): Remove.
8535         (debug_reg_change_callback): Change type.
8536         (aarch64_notify_debug_reg_change): Update.
8537         * s390-linux-nat.c (s390_refresh_per_info): Update.
8538
8539 2019-03-11  Tom Tromey  <tromey@adacore.com>
8540
8541         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8542         redundant assignment to "this_cu".
8543
8544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8545
8546         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8547
8548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8549
8550         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8551         from...
8552         (rank_one_type): ... this.
8553
8554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8555
8556         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8557         from...
8558         (rank_one_type): ... this.
8559
8560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8561
8562         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8563         from...
8564         (rank_one_type): ... this.
8565
8566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8567
8568         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8569         from...
8570         (rank_one_type): ... this.
8571
8572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8573
8574         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8575         from...
8576         (rank_one_type): ... this.
8577
8578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8579
8580         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8581         from...
8582         (rank_one_type): ... this.
8583
8584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8585
8586         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8587         from...
8588         (rank_one_type): ... this.
8589
8590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8591
8592         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8593         from...
8594         (rank_one_type): ... this.
8595
8596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8597
8598         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8599         from...
8600         (rank_one_type): ... this.
8601
8602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8603
8604         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8605         from...
8606         (rank_one_type): ... this.
8607
8608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8609
8610         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8611         from...
8612         (rank_one_type): ... this.
8613
8614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8615
8616         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8617         from...
8618         (rank_one_type): ... this.
8619
8620 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8621
8622         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8623         inferior-events' shows the example events.
8624
8625 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8626
8627         Support styling on native MS-Windows console
8628
8629         PR/24315
8630         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8631         on MS-Windows if $TERM is not defined.
8632
8633         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8634
8635         * posix-hdep.c (gdb_console_fputs):
8636         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8637         functions.
8638         * ui-file.h (gdb_console_fputs): Add prototype.
8639
8640         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8641         back to fputs only if the former returns zero.
8642
8643 2019-03-07  Tom Tromey  <tom@tromey.com>
8644
8645         * symmisc.c (print_symbol_bcache_statistics): Update.
8646         (print_objfile_statistics): Update.
8647         * symfile.c (allocate_symtab): Update.
8648         * stabsread.c: Don't include bcache.h.
8649         * psymtab.h (struct psymbol_bcache): Don't declare.
8650         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8651         (psymbol_bcache_init, psymbol_bcache_free)
8652         (psymbol_bcache_get_bcache): Don't declare.
8653         * psymtab.c (struct psymbol_bcache): Remove.
8654         (psymtab_storage::psymtab_storage): Update.
8655         (psymtab_storage::~psymtab_storage): Update.
8656         (psymbol_bcache_init, psymbol_bcache_free)
8657         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8658         (add_psymbol_to_bcache): Update.
8659         (allocate_psymtab): Update.
8660         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8661         macro_cache>: No longer pointers.
8662         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8663         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8664         * macrotab.c (macro_bcache): Update.
8665         * macroexp.c: Don't include bcache.h.
8666         * gdbtypes.c (check_types_worklist): Update.
8667         (types_deeply_equal): Remove TRY/CATCH.  Update.
8668         * elfread.c (elf_symtab_read): Update.
8669         * dwarf2read.c: Don't include bcache.h.
8670         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8671         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8672         (print_bcache_statistics, bcache_memory_used): Don't declare.
8673         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8674         methods.  Rename all data members.
8675         * bcache.c (struct bcache): Move to bcache.h.
8676         (bcache::expand_hash_table): Rename from expand_hash_table.
8677         (bcache): Remove.
8678         (bcache::insert): Rename from bcache_full.
8679         (bcache::compare): Rename from bcache_compare.
8680         (bcache_xmalloc): Remove.
8681         (bcache::~bcache): Rename from bcache_xfree.
8682         (bcache::print_statistics): Rename from print_bcache_statistics.
8683         (bcache::memory_used): Rename from bcache_memory_used.
8684
8685 2019-03-07  Pedro Alves  <palves@redhat.com>
8686
8687         * infrun.c (normal_stop): Also check for
8688         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8689
8690 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8691
8692         * f-lang.c (value_from_host_double): Moved to...
8693         * value.c (value_from_host_double): ...here.
8694         * value.h (value_from_host_double): Declare.
8695         * guile/scm-math.c (vlscm_convert_typed_number): Use
8696         value_from_host_double.
8697         (vlscm_convert_number): Likewise.
8698         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8699         * python/py-value.c (convert_value_from_python): Likewise.
8700
8701 2019-03-06  Tom Tromey  <tom@tromey.com>
8702
8703         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8704
8705 2019-03-06  Tom Tromey  <tom@tromey.com>
8706
8707         * utils.h (free_current_contents): Don't declare.
8708         * utils.c (free_current_contents): Remove.
8709
8710 2019-03-06  Tom Tromey  <tom@tromey.com>
8711
8712         * top.c (quit_force): Update.
8713         * main.c (captured_command_loop): Update.
8714         * common/new-op.c (operator new): Update.
8715         * common/common-exceptions.c (struct catcher)
8716         <save_cleanup_chain>: Remove member.
8717         (exceptions_state_mc_init): Update.
8718         (exception_try_scope_entry): Return nullptr.
8719         (exception_try_scope_exit, exception_rethrow)
8720         (throw_exception_sjlj, throw_exception_cxx): Update.
8721         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8722         (all_cleanups, do_cleanups, discard_cleanups)
8723         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8724         (restore_cleanups, restore_final_cleanups): Don't declare.
8725         (do_final_cleanups): Remove parameter.
8726         * common/cleanups.c (cleanup_chain, make_cleanup)
8727         (make_cleanup_dtor, all_cleanups, do_cleanups)
8728         (discard_my_cleanups, discard_cleanups)
8729         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8730         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8731         (null_cleanup): Remove.
8732         (do_final_cleanups): Remove parameter.
8733
8734 2019-03-06  Tom Tromey  <tom@tromey.com>
8735
8736         * remote.c (remote_target::remote_parse_stop_reply): Use
8737         unique_xmalloc_ptr.
8738
8739 2019-03-06  Tom Tromey  <tom@tromey.com>
8740
8741         * stabsread.c (struct stabs_field_info): Rename from field_info.
8742         <list, fnlist>: Add initializers.
8743         <obstack>: New member.
8744         (read_member_functions, read_struct_fields, read_baseclasses):
8745         Allocate on obstack.  Don't use cleanups.
8746         (read_one_struct_field, read_member_functions, read_struct_fields)
8747         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8748         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8749         (read_struct_type): Update.
8750
8751 2019-03-06  Tom Tromey  <tom@tromey.com>
8752
8753         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8754         * common/filestuff.h (make_cleanup_close): Don't declare.
8755         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8756         Remove.
8757
8758 2019-03-06  Tom Tromey  <tom@tromey.com>
8759
8760         * solib-aix.c: Use make_scope_exit.
8761
8762 2019-03-06  Tom Tromey  <tom@tromey.com>
8763
8764         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8765         Use make_scope_exit.
8766
8767 2019-03-06  Tom Tromey  <tom@tromey.com>
8768
8769         * solib-svr4.c (disable_probes_interface): Remove parameter.
8770         (svr4_handle_solib_event): Use make_scope_exit.
8771
8772 2019-03-06  Tom Tromey  <tom@tromey.com>
8773
8774         * remote.c (struct stop_reply_deleter): Remove.
8775         (stop_reply_up): Update.
8776         (struct stop_reply): Derive from notif_event.  Don't typedef.
8777         <regcache>: Now a std::vector.
8778         (stop_reply_xfree): Remove.
8779         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8780         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8781         (remote_target::discard_pending_stop_replies): Use delete.
8782         (remote_target::remote_parse_stop_reply): Update.
8783         (remote_target::process_stop_reply): Update.
8784         * remote-notif.h (struct notif_event): Add virtual destructor.
8785         Remove "dtr" member.
8786         (struct notif_client) <alloc_event>: Return a unique_ptr.
8787         (notif_event_xfree): Don't declare.
8788         (notif_event_up): New typedef.
8789         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8790         (notif_event_xfree, do_notif_event_xfree): Remove.
8791         (remote_notif_state_xfree): Update.
8792
8793 2019-03-06  Tom Tromey  <tom@tromey.com>
8794
8795         * infrun.c (displaced_step_clear_cleanup): Now a
8796         forward_scope_exit type.
8797         (displaced_step_prepare_throw): Update.
8798         (displaced_step_fixup): Update.
8799
8800 2019-03-06  Tom Tromey  <tom@tromey.com>
8801
8802         * inferior.h (class inferior): Update comment.
8803         * gdbthread.h (class thread_info): Update comment.
8804
8805 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8806             Tom Tromey  <tom@tromey.com>
8807
8808         * stabsread.h (struct stab_section_list): Remove.
8809         (coffstab_build_psymtabs): Update.
8810         * dbxread.c (symbuf_sections): Now a std::vector.
8811         (sect_idx): New global.
8812         (fill_symbuf): Update.
8813         (coffstab_build_psymtabs): Change type of stabsects parameter.
8814         Update.
8815         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8816         std::vector.
8817         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8818         (coff_locate_sections): Update.
8819         (coff_symfile_read): Remove cleanups.  Update.
8820         (init_stringtab): Add storage parameter.
8821         (free_stringtab, free_stringtab_cleanup): Remove.
8822         (init_lineno): Add storage parameter.
8823         (free_linetab, free_linetab_cleanup): Remove.
8824
8825 2019-03-06  Pedro Alves  <palves@redhat.com>
8826
8827         * linux-fork.c (fork_info::clobber_regs): Delete.
8828         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8829         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8830         comment.  Adjust.
8831         (scoped_switch_fork_info::scoped_switch_fork_info)
8832         (checkpoint_command, linux_fork_context): Adjust
8833         fork_save_infrun_state calls.
8834
8835 2019-03-06  Pedro Alves  <palves@redhat.com>
8836
8837         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8838         (inf_has_multiple_threads): Return 'bool' and rewrite using
8839         inferior_info::threads().
8840
8841 2019-03-06  Pedro Alves  <palves@redhat.com>
8842
8843         * linux-fork.c: Include <list>.
8844         (fork_list): Now a std::list instance.
8845         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8846         (forks_exist_p, find_last_fork): Adjust.
8847         (new_fork): Delete.
8848         (one_fork_p): New.
8849         (add_fork): Adjust.
8850         (free_fork): Delete, folded into fork_info::~fork_info().
8851         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8852         Adjust.
8853         (init_fork_list): Delete.
8854         (linux_fork_killall, linux_fork_mourn_inferior)
8855         (linux_fork_detach, info_checkpoints_command): Adjust.
8856         (_initialize_linux_fork): No longer call init_fork_list.
8857
8858 2019-03-06  Pedro Alves  <palves@redhat.com>
8859
8860         * linux-fork.c (new_fork): New, split out of ...
8861         (add_fork): ... this.  Return void.  Move "first fork" special
8862         case from here, to ...
8863         (checkpoint_command): ... here.
8864         * linux-linux.h (add_fork): Return void.
8865
8866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8867
8868         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8869
8870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8871             Chris January  <chris.january@arm.com>
8872             David Lecomber  <david.lecomber@arm.com>
8873
8874         * f-exp.y: New token, UNOP_INTRINSIC.
8875         (exp): New pattern using UNOP_INTRINSIC token.
8876         (f77_keywords): Add 'abs' keyword.
8877         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8878         (value_from_host_double): New function.
8879         (evaluate_subexp_f): Support UNOP_ABS.
8880
8881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8884         types.
8885
8886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8887
8888         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8889         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8890         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8891
8892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8893
8894         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8895
8896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8897             Chris January  <chris.january@arm.com>
8898
8899         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8900         * f-exp.y: Define 'KIND' token.
8901         (exp): New pattern for KIND expressions.
8902         (ptype): Handle types with a kind extension.
8903         (direct_abs_decl): Extend to spot kind extensions.
8904         (f77_keywords): Add 'kind' to the list.
8905         (push_kind_type): New function.
8906         (convert_to_kind_type): New function.
8907         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8908         * parse.c (operator_length_standard): Likewise.
8909         * parser-defs.h (enum type_pieces): Add tp_kind.
8910         * std-operator.def: Add UNOP_KIND.
8911
8912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * f-exp.y (f_parse): Set yydebug.
8915
8916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8917
8918         * f-lang.c (evaluate_subexp_f): New function.
8919         (exp_descriptor_f): New global.
8920         (f_language_defn): Use exp_descriptor_f instead of
8921         exp_descriptor_standard.
8922
8923 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8924
8925         * f-exp.y (struct token): Add comments.
8926         (dot_ops): Remove uppercase versions and the end marker.
8927         (f77_keywords): Likewise.
8928         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8929         entries in the dot_ops array are case insensitive, and use
8930         strncasecmp to compare strings.  Also some whitespace cleanup in
8931         this area.  Similar for the f77_keywords array, except entries in
8932         this list might be case sensitive.
8933
8934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8935
8936         * f-exp.y (struct f77_boolean_val): Add comments.
8937         (boolean_values): Remove uppercase versions, and end marker.
8938         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8939         and use strncasecmp to achieve case insensitivity.  Additionally,
8940         perform whitespace cleanup around this code.
8941
8942 2019-03-06  Tom Tromey  <tromey@adacore.com>
8943
8944         * remote-sim.c (gdbsim_target_open): Use result of
8945         gdb_argv::release.
8946
8947 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8948         Dirk Schubert  <dirk.schubert@arm.com>
8949         Chris January  <chris.january@arm.com>
8950
8951         * eval.c (evaluate_subexp_standard): Call Fortran argument
8952         wrapping logic.
8953         * f-lang.c (struct value): A value which can be passed into a
8954         Fortran function call.
8955         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8956         where appropriate.
8957         (struct type): Value ready for a Fortran function call.
8958         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8959         is needed.
8960         * f-lang.h (fortran_argument_convert): Declaration.
8961         (fortran_preserve_arg_pointer): Declaration.
8962         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8963
8964 2019-03-05  Tom Tromey  <tromey@adacore.com>
8965
8966         * python/py-prettyprint.c (print_string_repr): Remove #if.
8967         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8968
8969 2019-03-05  Tom Tromey  <tromey@adacore.com>
8970
8971         * target.c (the_dummy_target): Move later.  Change type to
8972         "dummy_target".
8973         (initialize_targets): Don't initialize the_dummy_target.
8974
8975 2019-03-05  Tom Tromey  <tromey@adacore.com>
8976
8977         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8978         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8979
8980 2019-03-05  Tom Tromey  <tromey@adacore.com>
8981
8982         * windows-nat.c (windows_nat_target::attach)
8983         (windows_nat_target::detach): Don't call gdb_flush.
8984         * valprint.c (generic_val_print, val_print, val_print_string):
8985         Don't call gdb_flush.
8986         * utils.c (defaulted_query): Don't call gdb_flush.
8987         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8988         * target.c (target_announce_detach): Don't call gdb_flush.
8989         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8990         * remote.c (extended_remote_target::attach): Don't call
8991         gdb_flush.
8992         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8993         * printcmd.c (do_examine): Don't call gdb_flush.
8994         (info_display_command): Don't call gdb_flush.
8995         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8996         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8997         * memattr.c (info_mem_command): Don't call gdb_flush.
8998         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8999         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9000         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9001         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9002         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9003         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9004         (gnu_nat_target::detach): Don't call gdb_flush.
9005         * f-valprint.c (f_val_print): Don't call gdb_flush.
9006         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9007         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9008         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9009         gdb_flush.
9010         * c-valprint.c (c_val_print): Don't call gdb_flush.
9011         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9012
9013 2019-03-05  Tom Tromey  <tromey@adacore.com>
9014
9015         * varobj.c (update_dynamic_varobj_children): Update.
9016         (install_default_visualizer): Use reset, not release.
9017         * value.c (set_internalvar): Update.
9018         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9019         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9020         ATTRIBUTE_UNUSED_RESULT.
9021
9022 2019-03-05  Tom Tromey  <tromey@adacore.com>
9023
9024         * remote.c (class scoped_remote_fd) <release>: Add
9025         ATTRIBUTE_UNUSED_RESULT.
9026
9027 2019-03-05  Tom Tromey  <tromey@adacore.com>
9028
9029         * macroexp.c (struct macro_buffer) <release>: Add
9030         ATTRIBUTE_UNUSED_RESULT.
9031
9032 2019-03-05  Tom Tromey  <tromey@adacore.com>
9033
9034         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9035         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9036         ATTRIBUTE_UNUSED_RESULT.
9037
9038 2019-03-05  Tom Tromey  <tromey@adacore.com>
9039
9040         * common/scoped_fd.h (class scoped_fd) <release>: Add
9041         ATTRIBUTE_UNUSED_RESULT.
9042
9043 2019-03-05  Tom Tromey  <tromey@adacore.com>
9044
9045         * parser-defs.h (struct parser_state) <release>: Add
9046         ATTRIBUTE_UNUSED_RESULT.
9047
9048 2019-03-05  Tom Tromey  <tromey@adacore.com>
9049
9050         * utils.h (class gdb_argv) <release>: Add
9051         ATTRIBUTE_UNUSED_RESULT.
9052         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9053
9054 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9055
9056         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9057         for-loop range, to avoid compiler warnings.
9058
9059         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9060         avoid compiler warnings about unused variables.
9061
9062         * NEWS: Mention end of support for native debugging on MS-Windows
9063         before XP.
9064
9065         PR gdb/24292
9066         * common/netstuff.c:
9067         * gdbserver/gdbreplay.c
9068         * gdbserver/remote-utils.c:
9069         * ser-tcp.c:
9070         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9071         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9072         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9073         'getaddrinfo' and 'freeaddrinfo' were not available before
9074         Windows XP, and mingw.org's MinGW headers by default define
9075         _WIN32_WINNT to 0x500.
9076
9077 2019-03-01  Gary Benson <gbenson@redhat.com>
9078
9079         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9080
9081 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9082             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9083
9084         PR gdb/8527
9085         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9086         set_sigint_trap, clear_sigint_trap.
9087
9088 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9089
9090         * target.c (target_detach): Clear the regcache and the
9091         frame cache.
9092
9093 2019-02-27  Pedro Alves  <palves@redhat.com>
9094
9095         * utils.c (set_screen_size): When we cap the height/width sizes,
9096         tweak the corresponding command variable to show "unlimited":
9097
9098 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9099             Pedro Alves  <palves@redhat.com>
9100
9101         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9102         before calling rl_set_screen_size.
9103
9104 2019-02-27  Tom Tromey  <tromey@adacore.com>
9105
9106         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9107         define.
9108         * python/py-value.c: Remove Python 2.4 workaround.
9109         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9110         workaround.
9111         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9112         Python 2.4 workaround.
9113         * python/python-internal.h: Remove Python 2.4 comment.
9114         (Py_ssize_t): Don't define.
9115         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9116         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9117         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9118         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9119         * python/python.c (do_start_initialization): Remove Python 2.4
9120         workaround.
9121         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9122         (print_children): Remove Python 2.4 workaround.
9123         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9124         workaround.
9125         (CHARBUFFERPROC_NAME): Remove.
9126         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9127         Python 2.4 workaround.
9128
9129 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9130
9131         * NEWS: Note minimum Python version.
9132
9133 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9134
9135         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9136         code from these functions.  Remove corresponding ifdefs.  Use
9137         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9138         Remove gotos and target of gotos.
9139         (infpy_search_memory): Likewise.
9140
9141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9142
9143         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9144         (hppa_gdbarch_init): Don't register deleted functions with
9145         gdbarch.
9146
9147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9148
9149         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9150         (h8300_unwind_sp): Delete.
9151         (h8300_dummy_id): Delete.
9152         (h8300_gdbarch_init): Don't register deleted functions with
9153         gdbarch.
9154
9155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9156
9157         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9158         (ft32_unwind_pc): Delete.
9159         (ft32_unwind_sp): Delete.
9160         (ft32_gdbarch_init): Don't register deleted functions with
9161         gdbarch.
9162
9163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9164
9165         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9166         (frv_unwind_pc): Delete.
9167         (frv_unwind_sp): Delete.
9168         (frv_gdbarch_init): Don't register deleted functions with
9169         gdbarch.
9170
9171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9174         (riscv_unwind_pc): Delete.
9175         (riscv_unwind_sp): Delete.
9176         (riscv_gdbarch_init): Don't register deleted functions with
9177         gdbarch.
9178
9179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9180
9181         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9182         (csky_unwind_pc): Delete.
9183         (csky_unwind_sp): Delete.
9184         (csky_gdbarch_init): Don't register deleted functions with
9185         gdbarch.
9186
9187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9188
9189         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9190         (cris_unwind_pc): Delete.
9191         (cris_unwind_sp): Delete.
9192         (cris_gdbarch_init): Don't register deleted functions with
9193         gdbarch.
9194
9195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9196
9197         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9198         (bfin_unwind_pc): Delete.
9199         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9200
9201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9202
9203         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9204         (arm_unwind_pc): Delete.
9205         (arm_unwind_sp): Delete.
9206         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9207
9208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9209
9210         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9211         (arc_unwind_pc): Delete.
9212         (arc_unwind_sp): Delete.
9213         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9214
9215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9216
9217         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9218         (alpha_unwind_pc): Delete.
9219         (alpha_gdbarch_init): Don't register deleted functions with
9220         gdbarch.
9221
9222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9223
9224         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9225         (aarch64_unwind_pc): Delete.
9226         (aarch64_unwind_sp): Delete.
9227         (aarch64_gdbarch_init): Don't register deleted functions with
9228         gdbarch.
9229
9230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9231
9232         * gdbtypes.c (type_align): Don't consider static members when
9233         computing structure alignment.
9234
9235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9238         return 0 for other types.
9239         * arch-utils.c (default_type_align): Always return 0.
9240         * gdbarch.h: Regenerate.
9241         * gdbarch.sh (type_align): Extend comment.
9242         * gdbtypes.c (type_align): Add additional comments, always call
9243         gdbarch_type_align before applying the default rules.
9244         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9245         generic code will then apply a suitable default.
9246         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9247         types, return 0 for other types.
9248
9249 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9250
9251         * NEWS: Create a new section for the next release branch.
9252         Rename the section of the current branch, now that it has
9253         been cut.
9254
9255 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9256
9257         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9258         * version.in: Bump version to 8.3.50.DATE-git.
9259
9260 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9261
9262         * aix-thread.c (ptid_cmp): Remove unused variable.
9263         (get_signaled_thread): Likewise.
9264         (store_regs_user_thread): Likewise.
9265         (store_regs_kernel_thread): Likewise.
9266         (fetch_regs_kernel_thread): Remove shadowed variable.
9267
9268 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9269
9270         * features/riscv/32bit-cpu.xml: Add register numbers.
9271         * features/riscv/32bit-fpu.c: Regenerate.
9272         * features/riscv/32bit-fpu.xml: Add register numbers.
9273         * features/riscv/64bit-cpu.xml: Add register numbers.
9274         * features/riscv/64bit-fpu.c: Regenerate.
9275         * features/riscv/64bit-fpu.xml: Add register numbers.
9276
9277 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9278
9279         * NEWS: Mention two argument form of gdb.Value constructor.
9280         * python/py-value.c (convert_buffer_and_type_to_value): New
9281         function.
9282         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9283         Add support for handling an optional second argument.  Call
9284         convert_buffer_and_type_to_value as appropriate.
9285         * python/python-internal.h (Py_buffer_deleter): New struct.
9286         (Py_buffer_up): New typedef.
9287
9288 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9289
9290         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9291         instead of releasing ownership.
9292
9293 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9294
9295         * dwarf2read.c (open_and_init_dwp_file): Call
9296         elf_numsections instead of bfd_count_sections to initialize
9297         dwp_file->num_sections.
9298
9299 2019-02-25  Tom Tromey  <tromey@adacore.com>
9300
9301         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9302
9303 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9304
9305         * gcore.in: Add '--readnever' option when invoking GDB.
9306
9307 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9308
9309         * MAINTAINERS: Update my email address.
9310
9311 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9312
9313         * build-id.c (build_id_to_debug_bfd_1): New function.
9314         (build_id_to_debug_bfd): Look for separate debug file in
9315         sysroot.
9316
9317 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9318
9319         * gdbarch.sh: Update the copyright year range that is placed into
9320         generated files.
9321
9322 2019-02-22  Keith Seitz  <keiths@redhat.com>
9323
9324         PR symtab/23853
9325         * linespec.c (create_sals_line_offset): Search for the default
9326         symtab's filename instead of its fullname.
9327
9328 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9329
9330         * NEWS: Update style defaults.
9331
9332 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9333
9334         * main.c (captured_main_1): Disable styling in batch mode.
9335
9336 2019-02-20  Tom Tromey  <tom@tromey.com>
9337
9338         * symtab.c (symtab_symbol_info): Fix typos.
9339
9340 2019-02-20  Tom Tromey  <tromey@adacore.com>
9341
9342         * findcmd.c (_initialize_mem_search): Use upper case for
9343         metasyntactic variables.
9344
9345 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9346
9347         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9348         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9349
9350 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9351
9352         * top.h (source_file_name): Change to std::string.
9353         * top.c (source_file_name): Likewise.
9354         (command_line_input): Adjust.
9355         * cli/cli-script.c (script_from_file): Adjust.
9356
9357 2019-02-19  Tom Tromey  <tromey@adacore.com>
9358
9359         * ravenscar-thread.c
9360         (ravenscar_thread_target::update_thread_list): Don't call
9361         ada_build_task_list.
9362         * ada-lang.h (ada_build_task_list): Don't declare.
9363         * ada-tasks.c (struct ada_tasks_inferior_data)
9364         <task_list_valid_p>: Now bool.
9365         (read_known_tasks, ada_task_list_changed)
9366         (ada_tasks_invalidate_inferior_data): Update.
9367         (read_known_tasks_array): Return bool.
9368         (read_known_tasks_list): Likewise.
9369         (read_known_tasks): Return void.
9370         (ada_build_task_list): Now static.
9371
9372 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9375         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9376
9377 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9378
9379         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9380         variant for ada_tasks_pspace_data_handle and
9381         ada_tasks_inferior_data_handle.
9382         (ada_tasks_pspace_data_cleanup): New function.
9383         (ada_tasks_inferior_data_cleanup): New function.
9384
9385 2019-02-17  Tom Tromey  <tom@tromey.com>
9386
9387         * macrotab.h (macro_source_fullname): Return a std::string.
9388         * macrotab.c (macro_include, check_for_redefinition)
9389         (macro_undef, macro_lookup_definition, foreach_macro)
9390         (foreach_macro_in_scope): Update.
9391         (macro_source_fullname): Return a std::string.
9392         * macrocmd.c (show_pp_source_pos): Update.
9393
9394 2019-02-17  Tom Tromey  <tom@tromey.com>
9395
9396         * macrocmd.c (show_pp_source_pos): Style the file names.
9397
9398 2019-02-17  Tom Tromey  <tom@tromey.com>
9399
9400         PR tui/24197:
9401         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9402
9403 2019-02-17  Tom Tromey  <tom@tromey.com>
9404
9405         * ada-lang.c (user_select_syms): Use filtered printing.
9406         * utils.c (wrap_style): New global.
9407         (desired_style): Remove.
9408         (emit_style_escape): Add stream parameter.
9409         (set_output_style, reset_terminal_style, prompt_for_continue):
9410         Update.
9411         (flush_wrap_buffer): Only flush gdb_stdout.
9412         (wrap_here): Set wrap_style.
9413         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9414         treat escape sequences as a character.  Change when wrap buffer is
9415         flushed.
9416         (fputs_styled): Do not set the output style when the default is
9417         requested.
9418         * ui-style.h (struct ui_file_style) <is_default>: New method.
9419         * source.c (print_source_lines_base): Emit escape sequences in one
9420         piece.
9421
9422 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9423
9424         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9425         integers and enumeration types.
9426
9427 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9428
9429         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9430         instead of lookup_symbol_in_language
9431         (do_exact_match): New function.
9432         (ada_get_symbol_name_matcher): Return do_exact_match when
9433         doing a verbatim match.
9434
9435 2019-02-15  Tom Tromey  <tromey@adacore.com>
9436
9437         * ravenscar-thread.c (ravenscar_thread_target::resume)
9438         (ravenscar_thread_target::wait): Special case wildcard requests.
9439
9440 2019-02-15  Tom Tromey  <tromey@adacore.com>
9441
9442         * ravenscar-thread.c (base_ptid): Remove.
9443         (struct ravenscar_thread_target) <close>: New method.
9444         <m_base_ptid>: New member.
9445         <update_inferior_ptid, active_task, task_is_currently_active,
9446         runtime_initialized>: Declare methods.
9447         <ravenscar_thread_target>: Add constructor.
9448         (ravenscar_thread_target::task_is_currently_active)
9449         (ravenscar_thread_target::update_inferior_ptid)
9450         (ravenscar_runtime_initialized): Rename.  Now methods.
9451         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9452         (ravenscar_thread_target::update_thread_list): Update.
9453         (ravenscar_thread_target::active_task): Now method.
9454         (ravenscar_thread_target::store_registers)
9455         (ravenscar_thread_target::prepare_to_store)
9456         (ravenscar_thread_target::prepare_to_store)
9457         (ravenscar_thread_target::mourn_inferior): Update.
9458         (ravenscar_inferior_created): Use "new" to create target.
9459         (ravenscar_thread_target::get_ada_task_ptid): Update.
9460         (_initialize_ravenscar): Don't initialize base_ptid.
9461         (ravenscar_ops): Remove global.
9462
9463 2019-02-15  Tom Tromey  <tromey@adacore.com>
9464
9465         * target.h (push_target): Declare new overload.
9466         * target.c (push_target): New overload, taking an rvalue reference.
9467         * remote.c (remote_target::open_1): Use push_target overload.
9468         * corelow.c (core_target_open): Use push_target overload.
9469
9470 2019-02-15  Tom Tromey  <tromey@adacore.com>
9471
9472         * ravenscar-thread.c (is_ravenscar_task)
9473         (ravenscar_task_is_currently_active): Return bool.
9474         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9475         (_initialize_ravenscar): Remove "(void)".
9476         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9477         Return bool.
9478
9479 2019-02-15  Tom Tromey  <tromey@adacore.com>
9480
9481         * ravenscar-thread.c (ravenscar_runtime_initializer)
9482         (has_ravenscar_runtime, get_running_thread_id)
9483         (ravenscar_thread_target::resume): Fix indentation.
9484
9485 2019-02-15  Tom Tromey  <tromey@adacore.com>
9486
9487         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9488         from ravenscar_arch_ops.
9489         (sparc_ravenscar_ops::fetch_registers)
9490         (sparc_ravenscar_ops::store_registers): Now methods.
9491         (sparc_ravenscar_prepare_to_store): Remove.
9492         (sparc_ravenscar_ops): Redefine.
9493         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9494         methods and destructor.  Remove members.
9495         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9496         (ravenscar_thread_target::store_registers)
9497         (ravenscar_thread_target::prepare_to_store): Update.
9498         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9499         Remove.
9500         (struct ppc_ravenscar_powerpc_ops): Derive from
9501         ravenscar_arch_ops.
9502         (ppc_ravenscar_powerpc_ops::fetch_registers)
9503         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9504         (ppc_ravenscar_powerpc_ops): Redefine.
9505         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9506         (ppc_ravenscar_e500_ops::fetch_registers)
9507         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9508         (ppc_ravenscar_e500_ops): Redefine.
9509         * aarch64-ravenscar-thread.c
9510         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9511         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9512         (aarch64_ravenscar_fetch_registers)
9513         (aarch64_ravenscar_store_registers): Now methods.
9514         (aarch64_ravenscar_ops): Redefine.
9515
9516 2019-02-15  Tom Tromey  <tromey@adacore.com>
9517
9518         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9519         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9520         (ravenscar_thread_target::stopped_by_watchpoint)
9521         (ravenscar_thread_target::stopped_data_address)
9522         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9523
9524 2019-02-15  Tom Tromey  <tromey@adacore.com>
9525
9526         * ravenscar-thread.c: Fix some typos.
9527
9528 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9529             Tom Tromey  <tromey@adacore.com>
9530
9531         * ada-lang.c (ada_exception_sal): Change addr_string to a
9532         std::string.
9533         (create_ada_exception_catchpoint): Update.
9534
9535 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9536             Tom Tromey  <tromey@adacore.com>
9537
9538         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9539         (bp_location_ops): Remove.
9540         (base_breakpoint_allocate_location): Update.
9541         (free_bp_location): Update.
9542         * ada-lang.c (class ada_catchpoint_location)
9543         <ada_catchpoint_location>: Remove ops parameter.
9544         (ada_catchpoint_location_dtor): Remove.
9545         (ada_catchpoint_location_ops): Remove.
9546         (allocate_location_exception): Update.
9547         * breakpoint.h (struct bp_location_ops): Remove.
9548         (class bp_location) <bp_location>: Remove bp_location_ops
9549         parameter.
9550         <~bp_location>: Add destructor.
9551         <ops>: Remove.
9552
9553 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9554             Pedro Alves  <palves@redhat.com>
9555
9556         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9557         'PATH_MAX'.
9558
9559 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9560             Samuel Thibault  <samuel.thibault@gnu.org>
9561             Thomas Schwinge  <thomas@codesourcery.com>
9562
9563         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9564         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9565
9566 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9567
9568         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9569         (check_empty): Use "const char *".
9570
9571         * gnu-nat.c (gnu_nat_target::detach): Instead of
9572         'detach_inferior (pid)' call
9573         'detach_inferior (find_inferior_pid (pid))'.
9574
9575         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9576         'nat/fork-inferior.o'.
9577         * gnu-nat.c: #include "nat/fork-inferior.h".
9578
9579         * gnu-nat.c (gnu_nat_target::detach): Instead of
9580         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9581         * gnu-nat.h: #include "inf-child.h".
9582         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9583         'i386_gnu_nat_target::fetch_registers'.
9584         (gnu_store_registers): Rename/move to
9585         'i386_gnu_nat_target::store_registers'.
9586
9587         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9588         * gnu-nat.h (mach_thread_info): New function.
9589         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9590
9591         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9592
9593 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9594
9595         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9596
9597 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9598
9599         * windows-nat.c (windows_add_thread): Add new parameter
9600         "main_thread_p" with default value set to false.  Update
9601         function documentation as well as all callers.
9602         (windows_delete_thread): Likewise.
9603         (fake_create_process): Update call to windows_add_thread.
9604         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9605         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9606         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9607         call to windows_delete_thread.
9608
9609 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9610
9611         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9612
9613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9614
9615         * symfile.c (find_separate_debug_file): Use canonical path of
9616         sysroot with child_path instead of gdb_sysroot if it is valid.
9617
9618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9619
9620         * symfile.c (find_separate_debug_file): Use child_path to
9621         determine if an object file is under a sysroot.
9622
9623 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9624
9625         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9626         unittests/child-path-selftests.c.
9627         * common/pathstuff.c (child_path): New function.
9628         * common/pathstuff.h (child_path): New prototype.
9629         * unittests/child-path-selftests.c: New file.
9630
9631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9632
9633         * symfile.c (find_separate_debug_file): Look for separate debug
9634         files in debug directories under the sysroot.
9635
9636 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9637
9638         * symtab.h (struct minimal_symbol data_p): New const method.
9639         (struct minimal_symbol text_p): Likewise.
9640         * symtab.c (output_source_filename): Use file name style
9641         to print file name.
9642         (print_symbol_info): Likewise.
9643         (print_msymbol_info): Use address style to print addresses.
9644         Use function name style to print executable text symbols.
9645         (expand_symtab_containing_pc): Use data_p.
9646         (find_pc_sect_compunit_symtab): Likewise.
9647
9648 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9649
9650         * breakpoint.c (describe_other_breakpoints): Use address style
9651         to print addresses.
9652         (say_where): Likewise.
9653
9654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9655
9656         * ada-typeprint.c (print_func_type): Print function name
9657         style to print function name.
9658         * c-typeprint.c (c_print_type_1): Likewise.
9659
9660 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9661
9662         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9663         for execve.
9664
9665 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9666
9667         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9668         type_stack.
9669
9670 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9671
9672         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9673         TYPE_CODE_REF types.
9674
9675 2019-02-08  Jim Wilson  <jimw@sifive.com>
9676
9677         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9678         (riscv_linux_fregset): New.
9679         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9680
9681 2019-02-07  Tom Tromey  <tom@tromey.com>
9682
9683         * thread.c (thread_cancel_execution_command): Update.
9684         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9685         methods.
9686         (struct thread_fsm_ops): Remove.
9687         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9688         (thread_fsm_should_stop, thread_fsm_return_value)
9689         (thread_fsm_set_finished, thread_fsm_finished_p)
9690         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9691         Don't declare.
9692         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9693         * infrun.c (clear_proceed_status_thread)
9694         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9695         (print_stop_event): Update.
9696         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9697         Add constructor.
9698         (step_command_fsm_ops): Remove.
9699         (new_step_command_fsm): Remove.
9700         (step_1): Update.
9701         (step_command_fsm::should_stop): Rename from
9702         step_command_fsm_should_stop.
9703         (step_command_fsm::clean_up): Rename from
9704         step_command_fsm_clean_up.
9705         (step_command_fsm::do_async_reply_reason): Rename from
9706         step_command_fsm_async_reply_reason.
9707         (struct until_next_fsm): Inherit from thread_fsm.  Add
9708         constructor.
9709         (until_next_fsm_ops): Remove.
9710         (new_until_next_fsm): Remove.
9711         (until_next_fsm::should_stop): Rename from
9712         until_next_fsm_should_stop.
9713         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9714         (until_next_fsm::do_async_reply_reason): Rename from
9715         until_next_fsm_async_reply_reason.
9716         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9717         constructor.  Change type of breakpoint.
9718         (finish_command_fsm_ops): Remove.
9719         (new_finish_command_fsm): Remove.
9720         (finish_command_fsm::should_stop): Rename from
9721         finish_command_fsm_should_stop.
9722         (finish_command_fsm::clean_up): Rename from
9723         finish_command_fsm_clean_up.
9724         (finish_command_fsm::return_value): Rename from
9725         finish_command_fsm_return_value.
9726         (finish_command_fsm::do_async_reply_reason): Rename from
9727         finish_command_fsm_async_reply_reason.
9728         (finish_command): Update.
9729         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9730         Add constructor.
9731         (call_thread_fsm_ops): Remove.
9732         (call_thread_fsm::call_thread_fsm): Rename from
9733         new_call_thread_fsm.
9734         (call_thread_fsm::should_stop): Rename from
9735         call_thread_fsm_should_stop.
9736         (call_thread_fsm::should_notify_stop): Rename from
9737         call_thread_fsm_should_notify_stop.
9738         (run_inferior_call, call_function_by_hand_dummy): Update.
9739         * cli/cli-interp.c (should_print_stop_to_console): Update.
9740         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9741         Add constructor.  Change type of location_breakpoint,
9742         caller_breakpoint.
9743         (until_break_fsm_ops): Remove.
9744         (new_until_break_fsm): Remove.
9745         (until_break_fsm::should_stop): Rename from
9746         until_break_fsm_should_stop.
9747         (until_break_fsm::clean_up): Rename from
9748         until_break_fsm_clean_up.
9749         (until_break_fsm::do_async_reply_reason): Rename from
9750         until_break_fsm_async_reply_reason.
9751         (until_break_command): Update.
9752         * thread-fsm.c: Remove.
9753         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9754
9755 2019-02-07  Tom Tromey  <tom@tromey.com>
9756
9757         * yy-remap.h: Add include guard.
9758         * xtensa-tdep.h: Add include guard.
9759         * xcoffread.h: Rename include guard.
9760         * varobj-iter.h: Add include guard.
9761         * tui/tui.h: Rename include guard.
9762         * tui/tui-winsource.h: Rename include guard.
9763         * tui/tui-wingeneral.h: Rename include guard.
9764         * tui/tui-windata.h: Rename include guard.
9765         * tui/tui-win.h: Rename include guard.
9766         * tui/tui-stack.h: Rename include guard.
9767         * tui/tui-source.h: Rename include guard.
9768         * tui/tui-regs.h: Rename include guard.
9769         * tui/tui-out.h: Rename include guard.
9770         * tui/tui-layout.h: Rename include guard.
9771         * tui/tui-io.h: Rename include guard.
9772         * tui/tui-hooks.h: Rename include guard.
9773         * tui/tui-file.h: Rename include guard.
9774         * tui/tui-disasm.h: Rename include guard.
9775         * tui/tui-data.h: Rename include guard.
9776         * tui/tui-command.h: Rename include guard.
9777         * tic6x-tdep.h: Add include guard.
9778         * target/waitstatus.h: Rename include guard.
9779         * target/wait.h: Rename include guard.
9780         * target/target.h: Rename include guard.
9781         * target/resume.h: Rename include guard.
9782         * target-float.h: Rename include guard.
9783         * stabsread.h: Add include guard.
9784         * rs6000-tdep.h: Add include guard.
9785         * riscv-fbsd-tdep.h: Add include guard.
9786         * regformats/regdef.h: Rename include guard.
9787         * record.h: Rename include guard.
9788         * python/python.h: Rename include guard.
9789         * python/python-internal.h: Rename include guard.
9790         * python/py-stopevent.h: Rename include guard.
9791         * python/py-ref.h: Rename include guard.
9792         * python/py-record.h: Rename include guard.
9793         * python/py-record-full.h: Rename include guard.
9794         * python/py-record-btrace.h: Rename include guard.
9795         * python/py-instruction.h: Rename include guard.
9796         * python/py-events.h: Rename include guard.
9797         * python/py-event.h: Rename include guard.
9798         * procfs.h: Add include guard.
9799         * proc-utils.h: Add include guard.
9800         * p-lang.h: Add include guard.
9801         * or1k-tdep.h: Rename include guard.
9802         * observable.h: Rename include guard.
9803         * nto-tdep.h: Rename include guard.
9804         * nat/x86-linux.h: Rename include guard.
9805         * nat/x86-linux-dregs.h: Rename include guard.
9806         * nat/x86-gcc-cpuid.h: Add include guard.
9807         * nat/x86-dregs.h: Rename include guard.
9808         * nat/x86-cpuid.h: Rename include guard.
9809         * nat/ppc-linux.h: Rename include guard.
9810         * nat/mips-linux-watch.h: Rename include guard.
9811         * nat/linux-waitpid.h: Rename include guard.
9812         * nat/linux-ptrace.h: Rename include guard.
9813         * nat/linux-procfs.h: Rename include guard.
9814         * nat/linux-osdata.h: Rename include guard.
9815         * nat/linux-nat.h: Rename include guard.
9816         * nat/linux-namespaces.h: Rename include guard.
9817         * nat/linux-btrace.h: Rename include guard.
9818         * nat/glibc_thread_db.h: Rename include guard.
9819         * nat/gdb_thread_db.h: Rename include guard.
9820         * nat/gdb_ptrace.h: Rename include guard.
9821         * nat/fork-inferior.h: Rename include guard.
9822         * nat/amd64-linux-siginfo.h: Rename include guard.
9823         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9824         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9825         * nat/aarch64-linux.h: Rename include guard.
9826         * nat/aarch64-linux-hw-point.h: Rename include guard.
9827         * mn10300-tdep.h: Add include guard.
9828         * mips-linux-tdep.h: Add include guard.
9829         * mi/mi-parse.h: Rename include guard.
9830         * mi/mi-out.h: Rename include guard.
9831         * mi/mi-main.h: Rename include guard.
9832         * mi/mi-interp.h: Rename include guard.
9833         * mi/mi-getopt.h: Rename include guard.
9834         * mi/mi-console.h: Rename include guard.
9835         * mi/mi-common.h: Rename include guard.
9836         * mi/mi-cmds.h: Rename include guard.
9837         * mi/mi-cmd-break.h: Rename include guard.
9838         * m2-lang.h: Add include guard.
9839         * location.h: Rename include guard.
9840         * linux-record.h: Rename include guard.
9841         * linux-nat.h: Add include guard.
9842         * linux-fork.h: Add include guard.
9843         * i386-darwin-tdep.h: Rename include guard.
9844         * hppa-linux-offsets.h: Add include guard.
9845         * guile/guile.h: Rename include guard.
9846         * guile/guile-internal.h: Rename include guard.
9847         * gnu-nat.h: Rename include guard.
9848         * gdb-stabs.h: Rename include guard.
9849         * frv-tdep.h: Add include guard.
9850         * f-lang.h: Add include guard.
9851         * event-loop.h: Add include guard.
9852         * darwin-nat.h: Rename include guard.
9853         * cp-abi.h: Rename include guard.
9854         * config/sparc/nm-sol2.h: Rename include guard.
9855         * config/nm-nto.h: Rename include guard.
9856         * config/nm-linux.h: Add include guard.
9857         * config/i386/nm-i386gnu.h: Rename include guard.
9858         * config/djgpp/nl_types.h: Rename include guard.
9859         * config/djgpp/langinfo.h: Rename include guard.
9860         * compile/gcc-cp-plugin.h: Add include guard.
9861         * compile/gcc-c-plugin.h: Add include guard.
9862         * compile/compile.h: Rename include guard.
9863         * compile/compile-object-run.h: Rename include guard.
9864         * compile/compile-object-load.h: Rename include guard.
9865         * compile/compile-internal.h: Rename include guard.
9866         * compile/compile-cplus.h: Rename include guard.
9867         * compile/compile-c.h: Rename include guard.
9868         * common/xml-utils.h: Rename include guard.
9869         * common/x86-xstate.h: Rename include guard.
9870         * common/version.h: Rename include guard.
9871         * common/vec.h: Rename include guard.
9872         * common/tdesc.h: Rename include guard.
9873         * common/selftest.h: Rename include guard.
9874         * common/scoped_restore.h: Rename include guard.
9875         * common/scoped_mmap.h: Rename include guard.
9876         * common/scoped_fd.h: Rename include guard.
9877         * common/safe-iterator.h: Rename include guard.
9878         * common/run-time-clock.h: Rename include guard.
9879         * common/refcounted-object.h: Rename include guard.
9880         * common/queue.h: Rename include guard.
9881         * common/ptid.h: Rename include guard.
9882         * common/print-utils.h: Rename include guard.
9883         * common/preprocessor.h: Rename include guard.
9884         * common/pathstuff.h: Rename include guard.
9885         * common/observable.h: Rename include guard.
9886         * common/netstuff.h: Rename include guard.
9887         * common/job-control.h: Rename include guard.
9888         * common/host-defs.h: Rename include guard.
9889         * common/gdb_wait.h: Rename include guard.
9890         * common/gdb_vecs.h: Rename include guard.
9891         * common/gdb_unlinker.h: Rename include guard.
9892         * common/gdb_unique_ptr.h: Rename include guard.
9893         * common/gdb_tilde_expand.h: Rename include guard.
9894         * common/gdb_sys_time.h: Rename include guard.
9895         * common/gdb_string_view.h: Rename include guard.
9896         * common/gdb_splay_tree.h: Rename include guard.
9897         * common/gdb_setjmp.h: Rename include guard.
9898         * common/gdb_ref_ptr.h: Rename include guard.
9899         * common/gdb_optional.h: Rename include guard.
9900         * common/gdb_locale.h: Rename include guard.
9901         * common/gdb_assert.h: Rename include guard.
9902         * common/filtered-iterator.h: Rename include guard.
9903         * common/filestuff.h: Rename include guard.
9904         * common/fileio.h: Rename include guard.
9905         * common/environ.h: Rename include guard.
9906         * common/common-utils.h: Rename include guard.
9907         * common/common-types.h: Rename include guard.
9908         * common/common-regcache.h: Rename include guard.
9909         * common/common-inferior.h: Rename include guard.
9910         * common/common-gdbthread.h: Rename include guard.
9911         * common/common-exceptions.h: Rename include guard.
9912         * common/common-defs.h: Rename include guard.
9913         * common/common-debug.h: Rename include guard.
9914         * common/cleanups.h: Rename include guard.
9915         * common/buffer.h: Rename include guard.
9916         * common/btrace-common.h: Rename include guard.
9917         * common/break-common.h: Rename include guard.
9918         * cli/cli-utils.h: Rename include guard.
9919         * cli/cli-style.h: Rename include guard.
9920         * cli/cli-setshow.h: Rename include guard.
9921         * cli/cli-script.h: Rename include guard.
9922         * cli/cli-interp.h: Rename include guard.
9923         * cli/cli-decode.h: Rename include guard.
9924         * cli/cli-cmds.h: Rename include guard.
9925         * charset-list.h: Add include guard.
9926         * buildsym-legacy.h: Rename include guard.
9927         * bfin-tdep.h: Add include guard.
9928         * ax.h: Rename include guard.
9929         * arm-linux-tdep.h: Add include guard.
9930         * arm-fbsd-tdep.h: Add include guard.
9931         * arch/xtensa.h: Rename include guard.
9932         * arch/tic6x.h: Add include guard.
9933         * arch/i386.h: Add include guard.
9934         * arch/arm.h: Rename include guard.
9935         * arch/arm-linux.h: Rename include guard.
9936         * arch/arm-get-next-pcs.h: Rename include guard.
9937         * arch/amd64.h: Add include guard.
9938         * arch/aarch64-insn.h: Rename include guard.
9939         * arch-utils.h: Rename include guard.
9940         * annotate.h: Add include guard.
9941         * amd64-darwin-tdep.h: Rename include guard.
9942         * aarch64-linux-tdep.h: Add include guard.
9943         * aarch64-fbsd-tdep.h: Add include guard.
9944         * aarch32-linux-nat.h: Add include guard.
9945
9946 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9947
9948         * macrotab.c (macro_define_internal): New function that
9949         factorizes macro_define_object_internal and macro_define_function
9950         code.
9951         (macro_define_object_internal): Use macro_define_internal.
9952         (macro_define_function): Likewise.
9953
9954 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9955
9956         * macrocmd.c (extract_identifier): Return
9957         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9958         callers.
9959
9960 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9961
9962         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9963
9964 2019-02-05  Tom Tromey  <tom@tromey.com>
9965
9966         * target.c (target_stack::unpush): Move assertion earlier.
9967
9968 2019-01-30  Tom Tromey  <tom@tromey.com>
9969
9970         PR python/23615:
9971         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9972         (gdbpy_parse_and_eval): Likewise.
9973         * python/python-internal.h (gdbpy_allow_threads): New class.
9974
9975 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9976
9977         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9978         (aarch64_fbsd_fpregmap): Move earlier.
9979         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9980         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9981         instead of individual calls to trad_frame_set_reg_addr.
9982         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9983         earlier.
9984         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9985         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9986         instead of individual calls to trad_frame_set_reg_addr.
9987
9988 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9989
9990         * CONTRIBUTE: Replace contribution list with wiki link.
9991
9992 2019-01-25  Tom Tromey  <tom@tromey.com>
9993
9994         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9995
9996 2019-01-25  Tom Tromey  <tom@tromey.com>
9997
9998         * xtensa-linux-nat.c: Fix common/ includes.
9999         * xml-support.h: Fix common/ includes.
10000         * xml-support.c: Fix common/ includes.
10001         * x86-linux-nat.c: Fix common/ includes.
10002         * windows-nat.c: Fix common/ includes.
10003         * varobj.h: Fix common/ includes.
10004         * varobj.c: Fix common/ includes.
10005         * value.c: Fix common/ includes.
10006         * valops.c: Fix common/ includes.
10007         * utils.c: Fix common/ includes.
10008         * unittests/xml-utils-selftests.c: Fix common/ includes.
10009         * unittests/utils-selftests.c: Fix common/ includes.
10010         * unittests/unpack-selftests.c: Fix common/ includes.
10011         * unittests/tracepoint-selftests.c: Fix common/ includes.
10012         * unittests/style-selftests.c: Fix common/ includes.
10013         * unittests/string_view-selftests.c: Fix common/ includes.
10014         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10015         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10016         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10017         * unittests/rsp-low-selftests.c: Fix common/ includes.
10018         * unittests/parse-connection-spec-selftests.c: Fix common/
10019         includes.
10020         * unittests/optional-selftests.c: Fix common/ includes.
10021         * unittests/offset-type-selftests.c: Fix common/ includes.
10022         * unittests/observable-selftests.c: Fix common/ includes.
10023         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10024         * unittests/memrange-selftests.c: Fix common/ includes.
10025         * unittests/memory-map-selftests.c: Fix common/ includes.
10026         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10027         * unittests/function-view-selftests.c: Fix common/ includes.
10028         * unittests/environ-selftests.c: Fix common/ includes.
10029         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10030         * unittests/common-utils-selftests.c: Fix common/ includes.
10031         * unittests/cli-utils-selftests.c: Fix common/ includes.
10032         * unittests/array-view-selftests.c: Fix common/ includes.
10033         * ui-file.c: Fix common/ includes.
10034         * tui/tui-io.c: Fix common/ includes.
10035         * tracepoint.h: Fix common/ includes.
10036         * tracepoint.c: Fix common/ includes.
10037         * tracefile-tfile.c: Fix common/ includes.
10038         * top.h: Fix common/ includes.
10039         * top.c: Fix common/ includes.
10040         * thread.c: Fix common/ includes.
10041         * target/waitstatus.h: Fix common/ includes.
10042         * target/waitstatus.c: Fix common/ includes.
10043         * target.h: Fix common/ includes.
10044         * target.c: Fix common/ includes.
10045         * target-memory.c: Fix common/ includes.
10046         * target-descriptions.c: Fix common/ includes.
10047         * symtab.h: Fix common/ includes.
10048         * symfile.c: Fix common/ includes.
10049         * stap-probe.c: Fix common/ includes.
10050         * spu-linux-nat.c: Fix common/ includes.
10051         * sparc-nat.c: Fix common/ includes.
10052         * source.c: Fix common/ includes.
10053         * solib.c: Fix common/ includes.
10054         * solib-target.c: Fix common/ includes.
10055         * ser-unix.c: Fix common/ includes.
10056         * ser-tcp.c: Fix common/ includes.
10057         * ser-pipe.c: Fix common/ includes.
10058         * ser-base.c: Fix common/ includes.
10059         * selftest-arch.c: Fix common/ includes.
10060         * s12z-tdep.c: Fix common/ includes.
10061         * rust-exp.y: Fix common/ includes.
10062         * rs6000-aix-tdep.c: Fix common/ includes.
10063         * riscv-tdep.c: Fix common/ includes.
10064         * remote.c: Fix common/ includes.
10065         * remote-notif.h: Fix common/ includes.
10066         * remote-fileio.h: Fix common/ includes.
10067         * remote-fileio.c: Fix common/ includes.
10068         * regcache.h: Fix common/ includes.
10069         * regcache.c: Fix common/ includes.
10070         * record-btrace.c: Fix common/ includes.
10071         * python/python.c: Fix common/ includes.
10072         * python/py-type.c: Fix common/ includes.
10073         * python/py-inferior.c: Fix common/ includes.
10074         * progspace.h: Fix common/ includes.
10075         * producer.c: Fix common/ includes.
10076         * procfs.c: Fix common/ includes.
10077         * proc-api.c: Fix common/ includes.
10078         * printcmd.c: Fix common/ includes.
10079         * ppc-linux-nat.c: Fix common/ includes.
10080         * parser-defs.h: Fix common/ includes.
10081         * osdata.c: Fix common/ includes.
10082         * obsd-nat.c: Fix common/ includes.
10083         * nat/x86-linux.c: Fix common/ includes.
10084         * nat/x86-linux-dregs.c: Fix common/ includes.
10085         * nat/x86-dregs.h: Fix common/ includes.
10086         * nat/x86-dregs.c: Fix common/ includes.
10087         * nat/ppc-linux.c: Fix common/ includes.
10088         * nat/mips-linux-watch.h: Fix common/ includes.
10089         * nat/mips-linux-watch.c: Fix common/ includes.
10090         * nat/linux-waitpid.c: Fix common/ includes.
10091         * nat/linux-ptrace.h: Fix common/ includes.
10092         * nat/linux-ptrace.c: Fix common/ includes.
10093         * nat/linux-procfs.c: Fix common/ includes.
10094         * nat/linux-personality.c: Fix common/ includes.
10095         * nat/linux-osdata.c: Fix common/ includes.
10096         * nat/linux-namespaces.c: Fix common/ includes.
10097         * nat/linux-btrace.h: Fix common/ includes.
10098         * nat/linux-btrace.c: Fix common/ includes.
10099         * nat/fork-inferior.c: Fix common/ includes.
10100         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10101         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10102         * nat/aarch64-linux.c: Fix common/ includes.
10103         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10104         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10105         * namespace.h: Fix common/ includes.
10106         * mips-linux-tdep.c: Fix common/ includes.
10107         * minsyms.c: Fix common/ includes.
10108         * mi/mi-parse.h: Fix common/ includes.
10109         * mi/mi-main.c: Fix common/ includes.
10110         * mi/mi-cmd-env.c: Fix common/ includes.
10111         * memrange.h: Fix common/ includes.
10112         * memattr.c: Fix common/ includes.
10113         * maint.h: Fix common/ includes.
10114         * maint.c: Fix common/ includes.
10115         * main.c: Fix common/ includes.
10116         * machoread.c: Fix common/ includes.
10117         * location.c: Fix common/ includes.
10118         * linux-thread-db.c: Fix common/ includes.
10119         * linux-nat.c: Fix common/ includes.
10120         * linux-fork.c: Fix common/ includes.
10121         * inline-frame.c: Fix common/ includes.
10122         * infrun.c: Fix common/ includes.
10123         * inflow.c: Fix common/ includes.
10124         * inferior.h: Fix common/ includes.
10125         * inferior.c: Fix common/ includes.
10126         * infcmd.c: Fix common/ includes.
10127         * inf-ptrace.c: Fix common/ includes.
10128         * inf-child.c: Fix common/ includes.
10129         * ia64-linux-nat.c: Fix common/ includes.
10130         * i387-tdep.c: Fix common/ includes.
10131         * i386-tdep.c: Fix common/ includes.
10132         * i386-linux-tdep.c: Fix common/ includes.
10133         * i386-linux-nat.c: Fix common/ includes.
10134         * i386-go32-tdep.c: Fix common/ includes.
10135         * i386-fbsd-tdep.c: Fix common/ includes.
10136         * i386-fbsd-nat.c: Fix common/ includes.
10137         * guile/scm-type.c: Fix common/ includes.
10138         * guile/guile.c: Fix common/ includes.
10139         * go32-nat.c: Fix common/ includes.
10140         * gnu-nat.c: Fix common/ includes.
10141         * gdbthread.h: Fix common/ includes.
10142         * gdbarch-selftests.c: Fix common/ includes.
10143         * gdb_usleep.c: Fix common/ includes.
10144         * gdb_select.h: Fix common/ includes.
10145         * gdb_bfd.c: Fix common/ includes.
10146         * gcore.c: Fix common/ includes.
10147         * fork-child.c: Fix common/ includes.
10148         * findvar.c: Fix common/ includes.
10149         * fbsd-nat.c: Fix common/ includes.
10150         * event-top.c: Fix common/ includes.
10151         * event-loop.c: Fix common/ includes.
10152         * dwarf2read.c: Fix common/ includes.
10153         * dwarf2loc.c: Fix common/ includes.
10154         * dwarf2-frame.c: Fix common/ includes.
10155         * dwarf-index-cache.c: Fix common/ includes.
10156         * dtrace-probe.c: Fix common/ includes.
10157         * disasm-selftests.c: Fix common/ includes.
10158         * defs.h: Fix common/ includes.
10159         * csky-tdep.c: Fix common/ includes.
10160         * cp-valprint.c: Fix common/ includes.
10161         * cp-support.h: Fix common/ includes.
10162         * cp-support.c: Fix common/ includes.
10163         * corelow.c: Fix common/ includes.
10164         * completer.h: Fix common/ includes.
10165         * completer.c: Fix common/ includes.
10166         * compile/compile.c: Fix common/ includes.
10167         * compile/compile-loc2c.c: Fix common/ includes.
10168         * compile/compile-cplus-types.c: Fix common/ includes.
10169         * compile/compile-cplus-symbols.c: Fix common/ includes.
10170         * command.h: Fix common/ includes.
10171         * cli/cli-dump.c: Fix common/ includes.
10172         * cli/cli-cmds.c: Fix common/ includes.
10173         * charset.c: Fix common/ includes.
10174         * build-id.c: Fix common/ includes.
10175         * btrace.h: Fix common/ includes.
10176         * btrace.c: Fix common/ includes.
10177         * breakpoint.h: Fix common/ includes.
10178         * breakpoint.c: Fix common/ includes.
10179         * ax.h:
10180         (enum agent_op): Fix common/ includes.
10181         * ax-general.c (struct aop_map): Fix common/ includes.
10182         * ax-gdb.c: Fix common/ includes.
10183         * auxv.c: Fix common/ includes.
10184         * auto-load.c: Fix common/ includes.
10185         * arm-tdep.c: Fix common/ includes.
10186         * arch/riscv.c: Fix common/ includes.
10187         * arch/ppc-linux-common.c: Fix common/ includes.
10188         * arch/i386.c: Fix common/ includes.
10189         * arch/arm.c: Fix common/ includes.
10190         * arch/arm-linux.c: Fix common/ includes.
10191         * arch/arm-get-next-pcs.c: Fix common/ includes.
10192         * arch/amd64.c: Fix common/ includes.
10193         * arch/aarch64.c: Fix common/ includes.
10194         * arch/aarch64-insn.c: Fix common/ includes.
10195         * arch-utils.c: Fix common/ includes.
10196         * amd64-windows-tdep.c: Fix common/ includes.
10197         * amd64-tdep.c: Fix common/ includes.
10198         * amd64-sol2-tdep.c: Fix common/ includes.
10199         * amd64-obsd-tdep.c: Fix common/ includes.
10200         * amd64-nbsd-tdep.c: Fix common/ includes.
10201         * amd64-linux-tdep.c: Fix common/ includes.
10202         * amd64-linux-nat.c: Fix common/ includes.
10203         * amd64-fbsd-tdep.c: Fix common/ includes.
10204         * amd64-fbsd-nat.c: Fix common/ includes.
10205         * amd64-dicos-tdep.c: Fix common/ includes.
10206         * amd64-darwin-tdep.c: Fix common/ includes.
10207         * agent.c: Fix common/ includes.
10208         * ada-lang.h: Fix common/ includes.
10209         * ada-lang.c: Fix common/ includes.
10210         * aarch64-tdep.c: Fix common/ includes.
10211
10212 2019-01-25  Tom Tromey  <tom@tromey.com>
10213
10214         * common/create-version.sh: Use common/version.h.
10215
10216 2019-01-24  Pedro Alves  <palves@redhat.com>
10217
10218         * infrun.c (signal_stop, signal_print, signal_program)
10219         (signal_catch, signal_pass): Now arrays instead of pointers.
10220         (update_signals_program_target, do_target_resume)
10221         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10222         * linux-nat.c (linux_nat_target::pass_signals)
10223         (linux_nat_target::create_inferior, linux_nat_target::attach):
10224         Adjust.
10225         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10226         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10227         * procfs.c (procfs_target::pass_signals): Adjust.
10228         * record-full.c (record_full_target::resume): Adjust.
10229         * remote.c (remote_target::pass_signals)
10230         (remote_target::program_signals): Adjust.
10231         * target-debug.h (target_debug_print_signals): Now takes a
10232         gdb::array_view as parameter.  Adjust.
10233         * target.h (target_ops) <pass_signals, program_signals>: Replace
10234         pointer and length parameters with gdb::array_view.
10235         (target_pass_signals, target_program_signals): Likewise.
10236         * target-delegates.c: Regenerate.
10237
10238 2019-01-24  Pedro Alves  <palves@redhat.com>
10239
10240         * common/forward-scope-exit.h
10241         (forward_scope_exit::forward_scope_exit): Pass arguments to
10242         m_bind_function directly, instead of creating a std::bind and
10243         copying that.
10244
10245 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10246
10247         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10248         for static members.
10249         (pass_in_v_vfp_candidate): Likewise.
10250
10251 2019-01-23  Tom Tromey  <tom@tromey.com>
10252             Pedro Alves  <palves@redhat.com>
10253
10254         * regcache.c (class regcache_invalidator): Remove.
10255         (regcache::raw_write): Use make_scope_exit.
10256
10257 2019-01-23  Tom Tromey  <tom@tromey.com>
10258
10259         * ui-out.h (class ui_out_emit_type): Update comment.
10260
10261 2019-01-23  Tom Tromey  <tom@tromey.com>
10262
10263         * infrun.c (fetch_inferior_event): Update comment.
10264
10265 2019-01-23  Tom Tromey  <tom@tromey.com>
10266             Pedro Alves  <palves@redhat.com>
10267
10268         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10269         parameter.
10270         (fetch_inferior_event): Use SCOPE_EXIT.
10271
10272
10273 2019-01-23  Tom Tromey  <tom@tromey.com>
10274             Pedro Alves  <palves@redhat.com>
10275
10276         * infrun.c (disable_thread_events): Delete.
10277         (stop_all_threads): Use SCOPE_EXIT.
10278
10279 2019-01-23  Tom Tromey  <tom@tromey.com>
10280             Pedro Alves  <palves@redhat.com>
10281
10282         * symfile.c: Include forward-scope-exit.h.
10283         (clear_symtab_users_cleanup): Replace forward declaration with
10284         a FORWARD_SCOPE_EXIT.
10285         (syms_from_objfile_1): Use the forward_scope_exit and
10286         gdb::optional instead of cleanup_function.
10287         (reread_symbols): Use the forward_scope_exit instead of
10288         cleanup_function.
10289         (clear_symtab_users_cleanup): Remove function.
10290
10291 2019-01-23  Tom Tromey  <tom@tromey.com>
10292             Pedro Alves  <palves@redhat.com>
10293
10294         * linux-nat.c: Include scope-exit.h.
10295         (cleanup_target_stop): Remove.
10296         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10297         SCOPE_EXIT.
10298
10299 2019-01-23  Tom Tromey  <tom@tromey.com>
10300             Pedro Alves  <palves@redhat.com>
10301
10302         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10303         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10304
10305 2019-01-23  Tom Tromey  <tom@tromey.com>
10306             Andrew Burgess  <andrew.burgess@embecosm.com>
10307             Pedro Alves  <palves@redhat.com>
10308
10309         * infrun.c (fetch_inferior_event): Use scope_exit.
10310         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10311         * top.c (execute_command): Use scope_exit.
10312         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10313         * utils.c (do_bpstat_clear_actions_cleanup)
10314         (make_bpstat_clear_actions_cleanup): Remove.
10315
10316 2019-01-23  Tom Tromey  <tom@tromey.com>
10317             Pedro Alves  <palves@redhat.com>
10318
10319         * infrun.c: Include "common/scope-exit.h"
10320         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10321         (wait_for_inferior): Use SCOPE_EXIT.
10322         (fetch_inferior_event): Use scope_exit.
10323
10324 2019-01-23  Tom Tromey  <tom@tromey.com>
10325             Pedro Alves  <palves@redhat.com>
10326
10327         * breakpoint.c (create_breakpoint): Remove cleanup.
10328
10329 2019-01-23  Tom Tromey  <tom@tromey.com>
10330             Andrew Burgess  <andrew.burgess@embecosm.com>
10331             Pedro Alves  <palves@redhat.com>
10332
10333 2019-01-23  Pedro Alves  <palves@redhat.com>
10334
10335         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10336
10337 2019-01-23  Pedro Alves  <palves@redhat.com>
10338             Andrew Burgess  <andrew.burgess@embecosm.com>
10339
10340         * gdbthread.h: Include "common/forward-scope-exit.h".
10341         (scoped_finish_thread_state): Redefine custom class in terms of
10342         forward_scope_exit.
10343
10344 2019-01-23  Pedro Alves  <palves@redhat.com>
10345             Andrew Burgess  <andrew.burgess@embecosm.com>
10346
10347         * common/forward-scope-exit.h: New file.
10348
10349 2019-01-23  Pedro Alves  <palves@redhat.com>
10350             Andrew Burgess  <andrew.burgess@embecosm.com>
10351             Tom Tromey  <tom@tromey.com>
10352
10353         * common/scope-exit.h: New file.
10354
10355 2019-01-23  Pedro Alves  <palves@redhat.com>
10356
10357         * common/preprocessor.h (ESC): Rename to ...
10358         (ESC_PARENS): ... this.
10359         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10360         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10361
10362 2019-01-23  Tom Tromey  <tom@tromey.com>
10363
10364         * language.h (class scoped_switch_to_sym_language_if_auto):
10365         Initialize m_lang in both cases.
10366
10367 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10368
10369         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10370         with XCNEW.
10371
10372 2019-01-22  Tom Tromey  <tom@tromey.com>
10373
10374         * corelow.c: Do not include sys/file.h.
10375
10376 2019-01-22  Tom Tromey  <tom@tromey.com>
10377
10378         * tui/tui-wingeneral.h: Include gdb_curses.h.
10379
10380 2019-01-22  Tom Tromey  <tom@tromey.com>
10381
10382         * source-cache.h (class source_cache) <get_source_lines,
10383         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10384
10385 2019-01-22  Tom Tromey  <tom@tromey.com>
10386
10387         * remote-fileio.h (struct remote_target): Declare.
10388
10389 2019-01-22  Tom Tromey  <tom@tromey.com>
10390
10391         * python/py-arch.c: Do not include py-ref.h.
10392         * python/py-bpevent.c: Do not include py-ref.h.
10393         * python/py-cmd.c: Do not include py-ref.h.
10394         * python/py-continueevent.c: Do not include py-ref.h.
10395         * python/py-event.h: Do not include py-ref.h.
10396         * python/py-evtregistry.c: Do not include py-ref.h.
10397         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10398         * python/py-frame.c: Do not include py-ref.h.
10399         * python/py-framefilter.c: Do not include py-ref.h.
10400         * python/py-function.c: Do not include py-ref.h.
10401         * python/py-infevents.c: Do not include py-ref.h.
10402         * python/py-linetable.c: Do not include py-ref.h.
10403         * python/py-objfile.c: Do not include py-ref.h.
10404         * python/py-param.c: Do not include py-ref.h.
10405         * python/py-prettyprint.c: Do not include py-ref.h.
10406         * python/py-progspace.c: Do not include py-ref.h.
10407         * python/py-symbol.c: Do not include py-ref.h.
10408         * python/py-symtab.c: Do not include py-ref.h.
10409         * python/py-type.c: Do not include py-ref.h.
10410         * python/py-unwind.c: Do not include py-ref.h.
10411         * python/py-utils.c: Do not include py-ref.h.
10412         * python/py-value.c: Do not include py-ref.h.
10413         * python/py-varobj.c: Do not include py-ref.h.
10414         * python/py-xmethods.c: Do not include py-ref.h.
10415         * python/python.c: Do not include py-ref.h.
10416         * varobj.c: Do not include py-ref.h.
10417
10418 2019-01-22  Tom Tromey  <tom@tromey.com>
10419
10420         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10421         keyword for bcache.
10422
10423 2019-01-22  Tom Tromey  <tom@tromey.com>
10424
10425         * compile/compile-cplus-types.c: Remove a comment by #include.
10426
10427 2019-01-22  Tom Tromey  <tom@tromey.com>
10428
10429         * compile/gcc-c-plugin.h: Include compile-internal.h.
10430
10431 2019-01-22  Tom Tromey  <tom@tromey.com>
10432
10433         * stabsread.c (EXTERN): Do not define.
10434         (symnum, next_symbol_text_func, processing_gcc_compilation)
10435         (within_function, global_sym_chain, global_stabs)
10436         (previous_stab_code, this_object_header_files)
10437         (n_this_object_header_files)
10438         (n_allocated_this_object_header_files): Define.
10439         * stabsread.h (EXTERN): Never define.  Use "extern".
10440
10441 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10442
10443         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10444         history_value.
10445
10446 2019-01-21  Tom Tromey  <tom@tromey.com>
10447
10448         * ui-out.c: Fix includes.
10449         * tui/tui-source.c: Fix includes.
10450         * target.c: Fix includes.
10451         * remote.c: Fix includes.
10452         * regcache.c: Fix includes.
10453         * python/py-block.c: Fix includes.
10454         * printcmd.c: Fix includes.
10455         * or1k-tdep.c: Fix includes.
10456         * mi/mi-main.c: Fix includes.
10457         * m32r-tdep.c: Fix includes.
10458         * csky-tdep.c: Fix includes.
10459         * compile/compile-cplus-types.c: Fix includes.
10460         * cli/cli-interp.c: Fix includes.
10461
10462 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10463
10464         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10465         for padding.
10466
10467 2019-01-16  Tom Tromey  <tom@tromey.com>
10468
10469         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10470         earlier.
10471         (struct objfile) <msymbols_range>: Move from top level.
10472         <msymbols>: New method.
10473         (class objfile_msymbols): Remove.
10474         * symtab.c (default_collect_symbol_completion_matches_break_on):
10475         Update.
10476         * symmisc.c (dump_msymbols): Update.
10477         * stabsread.c (scan_file_globals): Update.
10478         * objc-lang.c (info_selectors_command, info_classes_command)
10479         (find_methods): Update.
10480         * minsyms.c (find_solib_trampoline_target): Update.
10481         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10482         * coffread.c (coff_symfile_read): Update.
10483         * ada-lang.c (ada_lookup_simple_minsym)
10484         (ada_collect_symbol_completion_matches): Update.
10485
10486 2019-01-16  Tom Tromey  <tom@tromey.com>
10487
10488         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10489         type.  Remove no-argument constructor.
10490         <iterator::operator++>: Simplify.
10491         <begin>: Update.
10492         <end>: Use minimal_symbol_count.
10493
10494 2019-01-16  Tom Tromey  <tom@tromey.com>
10495
10496         * objfiles.h (struct objfile) <psymtabs>: New method.
10497         (class objfile_psymtabs): Remove.
10498         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10499         typedef.
10500         <range>: New method.
10501         (require_partial_symbols): Change return type.
10502         * psymtab.c (require_partial_symbols)
10503         (psym_expand_symtabs_matching): Update.
10504         * mdebugread.c (parse_partial_symbols): Update.
10505         * dbxread.c (dbx_end_psymtab): Update.
10506
10507 2019-01-15  Tom Tromey  <tom@tromey.com>
10508
10509         * symtab.c (lookup_objfile_from_block)
10510         (lookup_symbol_in_objfile_symtabs)
10511         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10512         (find_line_symtab, info_sources_command)
10513         (default_collect_symbol_completion_matches_break_on)
10514         (make_source_files_completion_list): Update.
10515         * symmisc.c (print_objfile_statistics, dump_objfile)
10516         (maintenance_print_symbols, maintenance_info_symtabs)
10517         (maintenance_check_symtabs, maintenance_info_line_tables):
10518         Update.
10519         * source.c (select_source_symtab)
10520         (forget_cached_source_info_for_objfile): Update.
10521         * objfiles.h (class objfile_compunits): Remove.
10522         (struct objfile) <compunits_range>: New typedef.
10523         (compunits): New method.
10524         * objfiles.c (objfile_relocate1): Update.
10525         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10526         * maint.c (count_symtabs_and_blocks): Update.
10527         * linespec.c (iterate_over_all_matching_symtabs): Update.
10528         * cp-support.c (add_symbol_overload_list_qualified): Update.
10529         * coffread.c (coff_symtab_read): Update.
10530         * ada-lang.c (add_nonlocal_symbols)
10531         (ada_collect_symbol_completion_matches)
10532         (ada_add_global_exceptions): Update.
10533
10534 2019-01-15  Tom Tromey  <tom@tromey.com>
10535
10536         * progspace.h (program_space) <objfiles_safe_range>: New
10537         typedef.
10538         <objfiles_safe>: New method.
10539         * objfiles.h (class all_objfiles_safe): Remove.
10540         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10541         * jit.c (jit_inferior_exit_hook): Update.
10542
10543 2019-01-17  Tom Tromey  <tom@tromey.com>
10544
10545         * progspace.h (program_space) <objfiles_range>: New typedef.
10546         <objfiles>: New method.
10547         <objfiles_head>: Rename from objfiles.
10548         (object_files): Update.
10549         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10550         * guile/scm-pretty-print.c
10551         (ppscm_find_pretty_printer_from_objfiles): Update.
10552         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10553         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10554         Update.
10555         * python/py-progspace.c (pspy_get_objfiles): Update.
10556         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10557         Update.
10558         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10559         (objfpy_lookup_objfile_by_build_id): Update.
10560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10561         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10562         Update.
10563         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10564         (expand_symtab_containing_pc, lookup_objfile_from_block)
10565         (lookup_static_symbol, basic_lookup_transparent_type)
10566         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10567         (find_line_symtab, info_sources_command)
10568         (default_collect_symbol_completion_matches_break_on)
10569         (make_source_files_completion_list, find_main_name): Update.
10570         * symmisc.c (print_symbol_bcache_statistics)
10571         (print_objfile_statistics, maintenance_print_symbols)
10572         (maintenance_print_msymbols, maintenance_print_objfiles)
10573         (maintenance_info_symtabs, maintenance_check_symtabs)
10574         (maintenance_expand_symtabs, maintenance_info_line_tables):
10575         Update.
10576         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10577         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10578         (map_overlay_command, unmap_overlay_command)
10579         (simple_overlay_update, expand_symtabs_matching)
10580         (map_symbol_filenames): Update.
10581         * symfile-debug.c (set_debug_symfile): Update.
10582         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10583         Update.
10584         * source.c (select_source_symtab, forget_cached_source_info):
10585         Update.
10586         * solib.c (solib_read_symbols): Update.
10587         * solib-spu.c (append_ocl_sos): Update.
10588         * psymtab.c (maintenance_print_psymbols)
10589         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10590         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10591         * printcmd.c (info_symbol_command): Update.
10592         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10593         Update.
10594         * objfiles.h (class all_objfiles): Remove.
10595         * objfiles.c (have_partial_symbols, have_full_symbols)
10596         (have_minimal_symbols, qsort_cmp, update_section_map)
10597         (shared_objfile_contains_address_p)
10598         (default_iterate_over_objfiles_in_search_order): Update.
10599         * objc-lang.c (info_selectors_command, info_classes_command)
10600         (find_methods): Update.
10601         * minsyms.c (find_solib_trampoline_target): Update.
10602         * maint.c (maintenance_info_sections)
10603         (maintenance_translate_address, count_symtabs_and_blocks):
10604         Update.
10605         * main.c (captured_main_1): Update.
10606         * linux-thread-db.c (try_thread_db_load_from_pdir)
10607         (has_libpthread): Update.
10608         * linespec.c (iterate_over_all_matching_symtabs)
10609         (search_minsyms_for_name): Update.
10610         * jit.c (jit_find_objf_with_entry_addr): Update.
10611         * hppa-tdep.c (find_unwind_entry)
10612         (hppa_lookup_stub_minimal_symbol): Update.
10613         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10614         Update.
10615         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10616         (elf_gnu_ifunc_resolve_by_got): Update.
10617         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10618         * dwarf-index-write.c (save_gdb_index_command): Update.
10619         * cp-support.c (add_symbol_overload_list_qualified): Update.
10620         * breakpoint.c (create_overlay_event_breakpoint)
10621         (create_longjmp_master_breakpoint)
10622         (create_std_terminate_master_breakpoint)
10623         (create_exception_master_breakpoint): Update.
10624         * blockframe.c (find_pc_partial_function): Update.
10625         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10626         (ada_collect_symbol_completion_matches)
10627         (ada_add_global_exceptions): Update.
10628
10629 2019-01-17  Tom Tromey  <tom@tromey.com>
10630
10631         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10632         declare VEC.
10633         (solib_target_parse_libraries): Change return type.
10634         (library_list_start_segment, library_list_start_section)
10635         (library_list_end_library, library_list_start_library); Update.
10636         (solib_target_free_library_list): Remove.
10637         (solib_target_parse_libraries): Remove cleanup.  Change return
10638         type.
10639         (solib_target_current_sos): Update.
10640
10641 2019-01-17  Tom Tromey  <tromey@bapiya>
10642
10643         * valprint.c: Replace "the the" with "the".
10644         * symtab.c: Replace "the the" with "the".
10645         * solib.c: Replace "the the" with "the".
10646         * solib-dsbt.c: Replace "the the" with "the".
10647         * linespec.c: Replace "the the" with "the".
10648         * dwarf2loc.h: Replace "the the" with "the".
10649         * amd64-windows-tdep.c: Replace "the the" with "the".
10650         * aarch64-tdep.c: Replace "the the" with "the".
10651
10652 2019-01-16  Keith Seitz  <keiths@redhat.com>
10653
10654         PR gdb/23773
10655         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10656         <builder>: Rename to ..
10657         <m_builder>: ... this and make private.
10658         (dwarf2_cu::get_builder): New method.  Change all users of
10659         `builder' to use this method.
10660         (dwarf2_start_symtab): Move to ...
10661         (dwarf2_cu::start_symtab): ... here.  Update all callers
10662         (setup_type_unit_groups): Move to ...
10663         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10664         callers.
10665         (dwarf2_cu::reset_builder): New method.
10666         (process_full_compunit, process_full_type_unit): Use
10667         dwarf2_cu::reset_builder.
10668         (follow_die_offset): Record the ancestor CU if it is different
10669         from the followed DIE's CU.
10670         (follow_die_sig_1): Likewise.
10671
10672 2019-01-15  Tom Tromey  <tom@tromey.com>
10673
10674         * remote.c (class remote_state) <buf>: Now a char_vector.
10675         <buf_size>: Remove.
10676         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10677         parameter.
10678         (remote_target::getpkt_or_notif_sane_1)
10679         (remote_target::getpkt_sane)
10680         (remote_target::getpkt_or_notif_sane): Likewise.
10681         (class remote_target) <putpkt>: New overload.
10682         (remote_target::read_frame): Change type of "buf_p".  Remove
10683         sizeof_p parameter.
10684         (packet_ok): New overload.
10685         (packet_check_result): New overload.
10686         Update all uses.
10687
10688 2019-01-14  Tom Tromey  <tom@tromey.com>
10689
10690         * remote-notif.c (handle_notification, remote_notif_ack)
10691         (remote_notif_parse): Make "buf" const.
10692         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10693         const.
10694         (remote_notif_parse, remote_notif_ack, handle_notification):
10695         Likewise.
10696         * remote.c (remote_notif_stop_parse): Make "buf" const.
10697         (remote_target::remote_parse_stop_reply): Make "buf" const.
10698         (remote_notif_stop_ack): Make "buf" const.
10699
10700 2019-01-14  Tom Tromey  <tom@tromey.com>
10701
10702         * remote.c (remote_console_output): Make parameter const.
10703
10704 2019-01-14  Tom Tromey  <tom@tromey.com>
10705
10706         * target-debug.h (target_debug_print_signals): Constify.
10707         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10708         * procfs.c (procfs_target::pass_signals): Update.
10709         * linux-nat.c (linux_nat_target::pass_signals): Update.
10710         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10711         * target-delegates.c: Rebuild.
10712         * remote.c (remote_target::program_signals): Update.
10713         (remote_target::pass_signals): Update.
10714         * target.c (target_pass_signals): Constify argument.
10715         (target_program_signals): Likewise.
10716         * target.h (struct target_ops) <pass_signals, program_signals>:
10717         Constify argument.
10718         (target_pass_signals, target_program_signals): Constify argument.
10719
10720 2019-01-14  Tom Tromey  <tom@tromey.com>
10721
10722         PR tui/28819:
10723         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10724
10725 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10726
10727         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10728         field.
10729         * rs6000-tdep.c: Include reggroups.h.
10730         (IS_V_ALIAS_PSEUDOREG): Define.
10731         (rs6000_register_name): Return names for the "vX" aliases.
10732         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10733         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10734         aliases.  Call default_register_reggroup_p for all other
10735         pseudo-registers.
10736         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10737         New functions.
10738         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10739         Handle "vX" aliases.
10740         (v_alias_pseudo_register_collect): New function.
10741         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10742         (rs6000_gdbarch_init): Initialize "vX" aliases as
10743         pseudo-registers.  Restore registration of
10744         rs6000_pseudo_register_reggroup_p with
10745         set_tdesc_pseudo_register_reggroup_p.
10746
10747 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10748
10749         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10750         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10751         set_gdbarch_num_pseudo_regs.
10752
10753 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10754
10755         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10756         Remove arg prefixname, add do_set and do_show.
10757         Add member functions set_list and show_list.
10758         * cli/cli-style.c (class cli_style_option): Update accordingly.
10759         (style_set_list): Move to file scope.
10760         (style_show_list): Likewise.
10761         (set_style): Call help_list.
10762         (show_style): Call cmd_show_list.
10763         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10764         Update to use the new macro.
10765
10766 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10767
10768         * ada-lang.c (_initialize_ada_language): Expand the help text
10769         for the "catch exception" command.
10770
10771 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10772
10773         * symtab.c (matching_obj_sections): Initialize obj,
10774         declare it closer to its usage.
10775
10776 2019-01-10  Tom Tromey  <tom@tromey.com>
10777
10778         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10779         (basic_inf_threads_range): Remove.
10780         (inf_threads_range, inf_non_exited_threads_range)
10781         (safe_inf_threads_range): Use next_adapter.
10782
10783 2019-01-10  Keith Seitz  <keiths@redhat.com>
10784
10785         PR gdb/23712
10786         PR symtab/23010
10787         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10788         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10789
10790 2019-01-10  Keith Seitz  <keiths@redhat.com>
10791
10792         PR gdb/23712
10793         PR symtab/23010
10794         * dictionary.c (pending_to_vector): Remove.
10795         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10796         Remove _1 suffix, replacing functions of the same name.  Update
10797         all callers.
10798         (dict_create_hashed, dict_create_hashed_expandable)
10799         (dict_create_linear, dict_create_linear_expandable, dict_free)
10800         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10801         Make functions static.
10802
10803 2019-01-10  Keith Seitz  <keiths@redhat.com>
10804
10805         PR gdb/23712
10806         PR symtab/23010
10807         * dictionary.h (struct dictionary): Replace declaration with
10808         multidictionary.
10809         (dict_create_hashed, dict_create_hashed_expandable)
10810         (dict_create_linear, dict_create_linear_expandable)
10811         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10812         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10813         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10814         taking multidictionary argument.
10815         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10816         * block.h (struct block) <dict>: Change to multidictionary
10817         and rename `multidict'.
10818         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10819         symmisc.c: Update all dictionary references to multidictionary.
10820
10821 2019-01-10  Keith Seitz  <keiths@redhat.com>
10822
10823         PR gdb/23712
10824         PR symtab/23010
10825         * dictionary.c: Include unordered_map.
10826         (pending_to_vector): New function.
10827         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10828         Rewrite the non-"_1" functions to take vector instead
10829         of linked list.
10830         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10831         "new" _1 versions of the same name.
10832         (multidictionary): Define.
10833         (std::hash<enum language): New definition.
10834         (collate_pending_symbols_by_language, mdict_create_hashed)
10835         (mdict_create_hashed_expandable, mdict_create_linear)
10836         (mdict_create_linear_expandable, mdict_free)
10837         (find_language_dictionary, create_new_language_dictionary)
10838         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10839         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10840         (mdict_size, mdict_empty): New functions.
10841         * dictionary.h (mdict_iterator): Define.
10842
10843 2019-01-10  Pedro Alves  <palves@redhat.com>
10844
10845         * breakpoint.c (read_uploaded_action)
10846         (create_tracepoint_from_upload): Adjust to use
10847         gdb::unique_xmalloc_ptr.
10848         * ctf.c (ctf_write_uploaded_tp):
10849         (SET_ARRAY_FIELD): Use emplace_back.
10850         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10851         * tracefile-tfile.c (tfile_write_uploaded_tp):
10852         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10853         gdb::unique_xmalloc_ptr.
10854         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10855         at_string, cond_string, cmd_strings>: Replace char pointers
10856         with gdb::unique_xmalloc_ptr.
10857
10858 2019-01-10  Pedro Alves  <palves@redhat.com>
10859
10860         * solib-target.c (library_list_start_library): Don't xstrdup name.
10861
10862 2019-01-10  Pedro Alves  <palves@redhat.com>
10863
10864         * mdebugread.c (parse_partial_symbols): Use
10865         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10866
10867 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10868
10869         * linux-fork.c (scoped_switch_fork_info)
10870         <~scoped_switch_fork_info>: Fix incorrect variable name.
10871
10872 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10873
10874         * linux-fork.c (scoped_switch_fork_info)
10875         <scoped_switch_fork_info>: Make explicit.
10876         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10877
10878 2019-01-10  Tom Tromey  <tom@tromey.com>
10879
10880         * objfiles.h (objfile::reset_psymtabs): Update.
10881         * objfiles.c (objfile::objfile): Update.
10882         * psymtab.h (psymtab_storage::obstack): Update.
10883         (psymtab_storage::m_obstack): Use gdb::optional.
10884         (class psymtab_storage): Update comment.  Remove objfile
10885         parameter.
10886         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10887
10888 2019-01-10  Tom Tromey  <tom@tromey.com>
10889
10890         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10891         <free_psymtabs>: Now private.
10892         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10893         (allocate_psymtab): Use new method.
10894
10895 2019-01-10  Tom Tromey  <tom@tromey.com>
10896
10897         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10898         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10899         * mdebugread.c (parse_partial_symbols): Use
10900         allocate_dependencies.
10901         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10902         allocate_dependencies.
10903         (process_psymtab_comp_unit_reader)
10904         (build_type_psymtab_dependencies): Likewise.
10905         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10906
10907 2019-01-10  Tom Tromey  <tom@tromey.com>
10908
10909         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10910         PSYMBOL_SET_LANGUAGE.
10911         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10912
10913 2019-01-10  Tom Tromey  <tom@tromey.com>
10914
10915         * psymtab.h (psymtab_storage::obstack): New method.
10916         <m_obstack>: Rename from obstack; now private.
10917         * psymtab.c (psymtab_storage): Update.
10918         * dwarf2read.c (create_addrmap_from_index)
10919         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10920         Update.
10921
10922 2019-01-10  Tom Tromey  <tom@tromey.com>
10923
10924         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10925         * objfiles.h (objfile::reset_psymtabs): New method.
10926
10927 2019-01-10  Tom Tromey  <tom@tromey.com>
10928
10929         * symmisc.c (print_symbol_bcache_statistics): Update.
10930         (print_objfile_statistics): Update.
10931         * symfile.c (reread_symbols): Update.
10932         * psymtab.h (class psymtab_storage): New.
10933         * psymtab.c (psymtab_storage): New constructor.
10934         (~psymtab_storage): New destructor.
10935         (require_partial_symbols): Update.
10936         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10937         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10938         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10939         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10940         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10941         (start_psymtab_common, end_psymtab_common)
10942         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10943         (allocate_psymtab): Update.
10944         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10945         Update.
10946         (dump_psymtab_addrmap, maintenance_print_psymbols)
10947         (maintenance_check_psymtabs): Update.
10948         (class objfile_psymtabs): Move to objfiles.h.
10949         * psympriv.h (discard_psymtab): Now inline.
10950         (psymtab_discarder::psymtab_discarder): Update.
10951         (psymtab_discarder::~psymtab_discarder): Update.
10952         (ALL_OBJFILE_PSYMTABS): Rewrite.
10953         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10954         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10955         Remove fields.
10956         <partial_symtabs>: New field.
10957         (class objfile_psymtabs): Move from psymtab.h.  Update.
10958         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10959         psymbol_cache.
10960         (objfile::~objfile): Don't destroy psymbol_cache.
10961         * mdebugread.c (parse_partial_symbols): Update.
10962         * dwarf2read.c (create_addrmap_from_index)
10963         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10964         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10965         (add_partial_subprogram, dwarf2_ranges_read): Update.
10966         * dwarf-index-write.c (write_address_map)
10967         (write_one_signatured_type, recursively_write_psymbols)
10968         (class debug_names, class debug_names, write_psymtabs_to_index):
10969         Update.
10970
10971 2019-01-10  Tom Tromey  <tom@tromey.com>
10972
10973         * symtab.h (SYMBOL_SET_NAMES): Update.
10974         (symbol_set_names): Update.
10975         (MSYMBOL_SET_NAMES): Update.
10976         * symtab.c (symbol_set_names): Change argument to be an
10977         objfile_per_bfd_storage.
10978         * psymtab.c (add_psymbol_to_bcache): Update.
10979         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10980
10981 2019-01-10  Tom Tromey  <tom@tromey.com>
10982
10983         * symtab.c (create_demangled_names_hash): Change argument to be an
10984         objfile_per_bfd_storage.
10985         (symbol_set_names): Update.
10986
10987 2019-01-10  Tom Tromey  <tom@tromey.com>
10988
10989         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10990         init_psymbol_list.
10991         * psymtab.c (init_psymbol_list): Do nothing if already called.
10992         * psympriv.h (init_psymbol_list): Add comment.
10993         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10994         init_psymbol_list.
10995         * dbxread.c (dbx_symfile_read): Unconditionally call
10996         init_psymbol_list.
10997
10998 2019-01-10  Tom Tromey  <tom@tromey.com>
10999
11000         * xcoffread.c (scan_xcoff_symtab): Update.
11001         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11002         "where".
11003         * mdebugread.c (parse_partial_symbols)
11004         (handle_psymbol_enumerators): Update.
11005         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11006         * dbxread.c (read_dbx_symtab): Update.
11007         * psympriv.h (psymbol_placement): New enum.
11008         (add_psymbol_to_list): Update.
11009
11010 2019-01-10  Tom Tromey  <tom@tromey.com>
11011
11012         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11013         static_psymbols parameters.
11014         (scan_xcoff_symtab): Update.
11015         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11016         static_psymbols parameters.
11017         * psympriv.h (start_psymtab_common): Update.
11018         * mdebugread.c (parse_partial_symbols): Update.
11019         * dwarf2read.c (create_partial_symtab): Update.
11020         * dbxread.c (read_dbx_symtab): Update.
11021         (start_psymtab): Remove global_psymbols and static_psymbols
11022         parameters.
11023
11024 2019-01-10  Tom Tromey  <tom@tromey.com>
11025
11026         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11027         * psymtab.c (allocate_psymtab): Add comment.
11028         * psympriv.h (allocate_psymtab): Add comment.
11029         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11030         initializations.
11031         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11032
11033 2019-01-10  Tom Tromey  <tom@tromey.com>
11034
11035         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11036         Don't declare.
11037         * mipsread.c: Include mdebugread.h.
11038         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11039         Declare.
11040         * elfread.c: Include mdebugread.h.
11041
11042 2019-01-09  Tom Tromey  <tom@tromey.com>
11043
11044         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11045         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11046         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11047         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11048         (psym_lookup_symbol, psym_find_last_source_symtab)
11049         (psym_forget_cached_source_info, psym_print_stats)
11050         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11051         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11052         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11053         (psym_find_compunit_symtab_by_address)
11054         (maintenance_print_psymbols, maintenance_info_psymtabs)
11055         (maintenance_check_psymtabs): Use ranged for.
11056         * psymtab.h (class objfile_psymtabs): New.
11057         (require_partial_symbols): Return objfile_psymtabs.
11058         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11059
11060 2019-01-09  Tom Tromey  <tom@tromey.com>
11061
11062         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11063         (find_pc_mapped_section, list_overlays_command)
11064         (map_overlay_command, unmap_overlay_command)
11065         (simple_overlay_update): Use all_objfiles.
11066         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11067         * printcmd.c (info_symbol_command): Use all_objfiles.
11068         * objfiles.h (ALL_OBJSECTIONS): Remove.
11069         * maint.c (maintenance_translate_address): Use all_objfiles.
11070         * gcore.c (gcore_create_callback): Use all_objfiles.
11071         (objfile_find_memory_regions): Likewise.
11072
11073 2019-01-09  Tom Tromey  <tom@tromey.com>
11074
11075         * symtab.c (find_line_symtab, info_sources_command)
11076         (make_source_files_completion_list): Use objfile_compunits.
11077         * source.c (select_source_symtab): Use objfile_compunits.
11078         * objfiles.h (struct objfile): Update comment.
11079         (ALL_OBJFILES): Remove.
11080         (ALL_FILETABS): Remove.
11081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11082         objfile_compunits.
11083
11084 2019-01-09  Tom Tromey  <tom@tromey.com>
11085
11086         * symmisc.c (print_objfile_statistics, dump_objfile)
11087         (maintenance_print_symbols): Use compunit_filetabs.
11088         * source.c (forget_cached_source_info_for_objfile): Use
11089         compunit_filetabs.
11090         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11091         (ALL_FILETABS): Use compunit_filetabs.
11092         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11093         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11094
11095 2019-01-09  Tom Tromey  <tom@tromey.com>
11096
11097         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11098         (compunit_filetabs): New.
11099         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11100         compunit_filetabs.
11101         (info_sources_command, make_source_files_completion_list): Remove
11102         declaration.
11103         * symmisc.c (print_objfile_statistics, dump_objfile)
11104         (maintenance_print_symbols): Remove declaration.
11105         (maintenance_info_symtabs): Use compunit_filetabs.
11106         (maintenance_info_line_tables): Likewise.
11107         * source.c (select_source_symtab): Change local variable name.
11108         (forget_cached_source_info_for_objfile): Remove declaration.
11109         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11110         * objfiles.c (objfile_relocate1): Remove declaration.
11111         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11112         declaration.
11113         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11114         * coffread.c (coff_symtab_read): Remove declaration.
11115         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11116         compunit_filetabs.
11117
11118 2019-01-09  Tom Tromey  <tom@tromey.com>
11119
11120         * symtab.c (lookup_objfile_from_block)
11121         (find_pc_sect_compunit_symtab, search_symbols)
11122         (default_collect_symbol_completion_matches_break_on): Use
11123         objfile_compunits.
11124         * objfiles.h (ALL_COMPUNITS): Remove.
11125         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11126         * cp-support.c (add_symbol_overload_list_qualified): Use
11127         objfile_compunits.
11128         * ada-lang.c (ada_collect_symbol_completion_matches)
11129         (ada_add_global_exceptions): Use objfile_compunits.
11130
11131 2019-01-09  Tom Tromey  <tom@tromey.com>
11132
11133         * source.c (select_source_symtab)
11134         (forget_cached_source_info_for_objfile): Remove declaration.
11135         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11136         declaration.
11137         * maint.c (count_symtabs_and_blocks): Remove declaration.
11138         * cp-support.c (add_symbol_overload_list_qualified): Remove
11139         declaration.
11140         * coffread.c (coff_symtab_read): Remove declaration.
11141         * symtab.c (lookup_symbol_in_objfile_symtabs)
11142         (basic_lookup_transparent_type_1): Use objfile_compunits.
11143         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11144         (info_sources_command, search_symbols)
11145         (default_collect_symbol_completion_matches_break_on)
11146         (make_source_files_completion_list): Remove declaration.
11147         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11148         (ada_collect_symbol_completion_matches)
11149         (ada_add_global_exceptions): Remove declaration.
11150         * linespec.c (iterate_over_all_matching_symtabs): Use
11151         objfile_compunits.
11152         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11153         (class objfile_compunits): New.
11154         (ALL_COMPUNITS): Use objfile_compunits.
11155         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11156         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11157         objfile_compunits.
11158         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11159
11160 2019-01-09  Tom Tromey  <tom@tromey.com>
11161
11162         * symtab.c (search_symbols)
11163         (default_collect_symbol_completion_matches_break_on): Use
11164         objfile_msymbols.
11165         * ada-lang.c (ada_lookup_simple_minsym)
11166         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11167         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11168         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11169         objfile_msymbols.
11170         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11171         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11172         * objc-lang.c (find_methods): Use objfile_msymbols.
11173         (info_selectors_command, info_classes_command): Likewise.
11174         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11175         * objfiles.h (class objfile_msymbols): New.
11176         (ALL_OBJFILE_MSYMBOLS): Remove.
11177         (ALL_MSYMBOLS): Remove.
11178
11179 2019-01-09  Tom Tromey  <tom@tromey.com>
11180
11181         * common/next-iterator.h (next_adapter): Add Iterator template
11182         parameter.
11183         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11184         (class all_objfiles_safe): New.
11185         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11186         * objfiles.c (put_objfile_before): Update comment.
11187         (add_separate_debug_objfile): Likewise.
11188         (free_all_objfiles): Use all_objfiles_safe.
11189         (objfile_purge_solibs): Likewise.
11190
11191 2019-01-09  Tom Tromey  <tom@tromey.com>
11192
11193         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11194         (expand_symtab_containing_pc, lookup_static_symbol)
11195         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11196         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11197         all_objfiles.
11198         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11199         * breakpoint.c (create_overlay_event_breakpoint)
11200         (create_longjmp_master_breakpoint)
11201         (create_std_terminate_master_breakpoint)
11202         (create_exception_master_breakpoint): Use all_objfiles.
11203         * linux-thread-db.c (try_thread_db_load_from_pdir)
11204         (has_libpthread): Use all_objfiles.
11205         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11206         * linespec.c (iterate_over_all_matching_symtabs)
11207         (search_minsyms_for_name): Use all_objfiles.
11208         * maint.c (maintenance_info_sections): Use all_objfiles.
11209         * main.c (captured_main_1): Use all_objfiles.
11210         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11211         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11212         * guile/scm-pretty-print.c
11213         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11214         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11215         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11216         (maintenance_print_msymbols): Use all_objfiles.
11217         * source.c (select_source_symtab): Use all_objfiles.
11218         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11219         * symfile.c (remove_symbol_file_command)
11220         (expand_symtabs_matching, map_symbol_filenames): Use
11221         all_objfiles.
11222         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11223         all_objfiles.
11224         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11225         * objc-lang.c (find_methods): Use all_objfiles.
11226         * objfiles.c (have_partial_symbols, have_full_symbols)
11227         (have_minimal_symbols, qsort_cmp)
11228         (default_iterate_over_objfiles_in_search_order): Use
11229         all_objfiles.
11230         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11231         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11232         (maintenance_check_psymtabs): Use all_objfiles.
11233         (ALL_PSYMTABS): Remove.
11234         * compile/compile-object-run.c (do_module_cleanup): Use
11235         all_objfiles.
11236         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11237         * cp-support.c (add_symbol_overload_list_qualified): Use
11238         all_objfiles.
11239         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11240         Use all_objfiles.
11241         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11242         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11243         all_objfiles.
11244         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11245         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11246         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11247         Uses all_objfiles.
11248         * solib.c (solib_read_symbols): Use all_objfiles
11249
11250 2019-01-09  Tom Tromey  <tom@tromey.com>
11251
11252         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11253         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11254         all_objfiles.
11255         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11256         * symmisc.c (print_symbol_bcache_statistics)
11257         (print_objfile_statistics, maintenance_print_objfiles)
11258         (maintenance_info_symtabs, maintenance_check_symtabs)
11259         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11260         all_objfiles.
11261         * source.c (forget_cached_source_info): Use all_objfiles.
11262         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11263         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11264         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11265         * objfiles.c (update_section_map): Use all_objfiles.
11266         (shared_objfile_contains_address_p): Likewise.
11267         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11268         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11269
11270 2019-01-09  Tom Tromey  <tom@tromey.com>
11271
11272         * common/next-iterator.h: New file.
11273         * objfiles.h (class all_objfiles): New.
11274         (struct objfile_iterator): New.
11275
11276 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11277
11278         * NEWS: Move the description of the changed "frame", "select-frame",
11279          and "info frame" commands to the Changed commands section.
11280
11281 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11282
11283         * gdbtypes.c (check_stub_method_group): Remove handling of old
11284         mangling schemes.
11285         * linespec.c (find_methods): Likewise.
11286         * stabsread.c (read_member_functions): Likewise.
11287         * valops.c (search_struct_method): Likewise.
11288         (value_struct_elt_for_reference): Likewise.
11289         * NEWS: Mention this change.
11290
11291 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11294         print_source_lines.
11295         * source.c (print_source_lines_base): Update line number check.
11296         (print_source_lines): New function.
11297         (source_lines_range::source_lines_range): New function.
11298         * source.h (class source_lines_range): New class.
11299         (print_source_lines): New declaration.
11300
11301 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11302
11303         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11304
11305 2019-01-08  Tom Tromey  <tom@tromey.com>
11306             Simon Marchi  <simon.marchi@ericsson.com>
11307
11308         PR gdb/24060
11309         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11310         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11311         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11312         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11313         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11314         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11315
11316 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11317
11318         * source.c (select_source_symtab): Move header comment to
11319         declaration in source.h.
11320         (forget_cached_source_info_for_objfile): Likewise.
11321         (forget_cached_source_info): Likewise.
11322         (identify_source_line): Likewise.
11323         * source.h (identify_source_line): Move declaration from symtab.h
11324         and add comment from source.c
11325         (print_source_lines): Likewise.
11326         (forget_cached_source_info_for_objfile): Likewise.
11327         (forget_cached_source_info): Likewise.
11328         (select_source_symtab): Likewise.
11329         (enum print_source_lines_flag): Move definition from symtab.h.
11330         * symtab.h (identify_source_line): Move declaration to source.h.
11331         (print_source_lines): Likewise.
11332         (forget_cached_source_info_for_objfile): Likewise.
11333         (forget_cached_source_info): Likewise.
11334         (select_source_symtab): Likewise.
11335         (enum print_source_lines_flag): Move definition to source.h.
11336         * tui/tui-hooks.c: Add 'source.h' include.
11337
11338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11339
11340         * source.c (print_source_lines_base): Handle requests to print
11341         reverse line number sequences, and guard against empty lines
11342         string.
11343
11344 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11345
11346         * source.c (print_source_lines_base): Fix skip of '\r' if next
11347         character is '\n'.
11348
11349 2019-01-06  Tom Tromey  <tom@tromey.com>
11350
11351         * c-exp.y (struct c_parse_state) <macro_original_text,
11352         expansion_obstack>: New member.
11353         (macro_original_text, expansion_obstack): Remove globals.
11354         (scan_macro_expansion, scanning_macro_expansion)
11355         (finished_macro_expansion): Update.
11356         (scan_macro_cleanup): Remove.
11357         (yylex, c_parse): Update.
11358
11359 2019-01-06  Tom Tromey  <tom@tromey.com>
11360
11361         * c-exp.y (struct c_parse_state) <strings>: New member.
11362         (operator_stoken): Update.
11363
11364 2019-01-06  Tom Tromey  <tom@tromey.com>
11365
11366         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11367         (union type_stack_elt) <typelist_val>: Now a pointer to
11368         std::vector.
11369         (type_stack_cleanup): Don't declare.
11370         (push_typelist): Update.
11371         * parse.c (pop_typelist): Return a std::vector.
11372         (push_typelist): Take a std::vector.
11373         (follow_types): Update.  Do not free args.
11374         (type_stack_cleanup): Remove.
11375         * c-exp.y (struct c_parse_state): New.
11376         (cpstate): New global.
11377         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11378         (nonempty_typelist): Update.
11379         (func_mod): Create a new vector.
11380         (c_parse): Create a c_parse_state.
11381         (check_parameter_typelist): Do not delete params.
11382         (function_method): Update.  Do not delete type_list.
11383
11384 2019-01-06  Tom Tromey  <tom@tromey.com>
11385
11386         PR gdb/28155:
11387         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11388         check_typedef.
11389         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11390         (print_return_value): Likewise.
11391
11392 2019-01-05  Tom Tromey  <tom@tromey.com>
11393
11394         * contrib/cleanup_check.py: Remove.
11395         * contrib/gcc-with-excheck: Remove.
11396         * contrib/exsummary.py: Remove.
11397         * contrib/excheck.py: Remove.
11398
11399 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11400
11401         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11402         NULL. Initialize tpprev to NULL instead of assigning it
11403         to NULL on the next statement.
11404         * windows-nat.c (windows_delete_thread): Remove check for
11405         main_thread_id before printing thread exit notifications.
11406         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11407         Remove thread ID check against main_thread_id.
11408         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11409         windows_delete_thread.
11410         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11411
11412 2019-01-04  Tom Tromey  <tom@tromey.com>
11413
11414         * compile/compile.c (_initialize_compile): Use upper case for
11415         metasyntactic variables.
11416         * symmisc.c (_initialize_symmisc): Use upper case for
11417         metasyntactic variables.
11418         * psymtab.c (_initialize_psymtab): Use upper case for
11419         metasyntactic variables.
11420         * demangle.c (demangle_command): Use upper case for metasyntactic
11421         variables.
11422         (_initialize_demangler): Likewise.
11423         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11424         variables.
11425
11426 2019-01-03  Tom Tromey  <tom@tromey.com>
11427
11428         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11429
11430 2019-01-03  Tom Tromey  <tom@tromey.com>
11431
11432         * python/py-symtab.c (salpy_str): Update.
11433         (struct salpy_sal_object) <symtab>: Now a PyObject.
11434         (salpy_dealloc): Update.
11435         (del_objfile_sal): Use gdbpy_ref.
11436
11437 2019-01-03  Tom Tromey  <tom@tromey.com>
11438
11439         * python/py-type.c (convert_field): Use new_reference.  Return
11440         gdbpy_ref.
11441         (make_fielditem): Return gdbpy_ref.
11442         (typy_fields): Update.
11443         (typy_getitem): Update.
11444         (field_name): Return gdbpy_ref.  Use new_reference.
11445         (typy_iterator_iternext): Update.
11446
11447 2019-01-03  Tom Tromey  <tom@tromey.com>
11448
11449         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11450
11451 2019-01-03  Tom Tromey  <tom@tromey.com>
11452
11453         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11454         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11455         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11456         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11457         (pspy_set_type_printers): Likewise.
11458         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11459         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11460         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11461         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11462         (objfpy_set_type_printers): Likewise.
11463
11464 2019-01-03  Tom Tromey  <tom@tromey.com>
11465
11466         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11467         (gdbpy_print_stack): Use gdbpy_err_fetch.
11468         * python/python-internal.h (class gdbpy_err_fetch): New class.
11469         (class gdbpy_enter) <m_error_type, m_error_value,
11470         m_error_traceback>: Remove.
11471         <m_error>: New member.
11472         (gdbpy_exception_to_string): Don't declare.
11473         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11474         * python/py-value.c (convert_value_from_python): Use
11475         gdbpy_err_fetch.
11476         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11477         gdbpy_exception_to_string.
11478         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11479         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11480         gdbpy_err_fetch.
11481
11482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11483
11484         * linux-nat.c (delete_lwp_cleanup): Delete.
11485         (struct lwp_deleter): New struct.
11486         (lwp_info_up): New typedef.
11487         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11488         lwp_info_up.
11489
11490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11491
11492         * linux-fork.c (class scoped_switch_fork_info): New class.
11493         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11494
11495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11496
11497         * valops.c (find_overload_match): Remove use of null_cleanup, and
11498         calls to do_cleanups.
11499
11500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11501
11502         * compile/compile-cplus-types.c
11503         (compile_cplus_instance::decl_name): Handle changes to
11504         cp_func_name.
11505         * cp-support.c (cp_func_name): Update header comment, update
11506         return type.
11507         * cp-support.h (cp_func_name): Update return type in declaration.
11508         * valops.c (find_overload_match): Move temp_func local to top
11509         level of function and change its type.  Use temp_func to hold and
11510         delete temporary string obtained from cp_func_name.
11511
11512 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11513
11514         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11515         gdb::char_vector, remove cleanup, and update uses of `msg`.
11516
11517 2019-01-03  Jim Wilson  <jimw@sifive.com>
11518
11519         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11520
11521 2019-01-02  Tom Tromey  <tom@tromey.com>
11522
11523         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11524         (tdesc_parse_xml): Remove cleanups.
11525         * target-descriptions.h (make_cleanup_free_target_description):
11526         Don't declare.
11527         (target_desc_deleter): New struct.
11528         (target_desc_up): New typedef.
11529         * target-descriptions.c (target_desc_deleter::operator()): Rename
11530         from free_target_description.
11531         (make_cleanup_free_target_description): Remove.
11532
11533 2019-01-02  Tom Tromey  <tom@tromey.com>
11534
11535         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11536         constructor, destructor.
11537         (linespec_parser): Remove typedef.
11538         (~linespec_parser): Rename from linespec_parser_delete.
11539         (linespec_lex_to_end, linespec_complete_label)
11540         (linespec_complete): Update.
11541         (decode_line_full): Remove cleanups.
11542         (decode_line_1): Update.
11543
11544 2019-01-02  Tom Tromey  <tom@tromey.com>
11545
11546         * python/python-internal.h (inferior_to_inferior_object): Change
11547         return type.
11548         * python/py-exitedevent.c (create_exited_event_object): Update.
11549         * python/py-inferior.c (inferior_to_inferior_object): Return
11550         gdbpy_ref.
11551         (python_new_inferior, python_inferior_deleted)
11552         (thread_to_thread_object, delete_thread_object)
11553         (build_inferior_list, gdbpy_selected_inferior): Update.
11554         * python/py-infthread.c (create_thread_object): Update.  Also fail
11555         if inferior_to_inferior_object fails.
11556
11557 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11558
11559         * inferior.h (class inferior) <displaced_step_state>: New field.
11560         * infrun.h (struct displaced_step_state): Move here from
11561         infrun.c.  Initialize fields, add constructor.
11562         <inf>: Remove field.
11563         <reset>: New method.
11564         * infrun.c (struct displaced_step_inferior_state): Move to
11565         infrun.h.
11566         (displaced_step_inferior_states): Remove.
11567         (get_displaced_stepping_state): Adust.
11568         (displaced_step_in_progress_any_inferior): Adjust.
11569         (displaced_step_in_progress_thread): Adjust.
11570         (displaced_step_in_progress): Adjust.
11571         (add_displaced_stepping_state): Remove.
11572         (get_displaced_step_closure_by_addr): Adjust.
11573         (remove_displaced_stepping_state): Remove.
11574         (infrun_inferior_exit): Call displaced_step_state.reset.
11575         (use_displaced_stepping): Don't check for NULL.
11576         (displaced_step_prepare_throw): Call
11577         get_displaced_stepping_state.
11578         (displaced_step_fixup): Don't check for NULL.
11579         (prepare_for_detach): Don't check for NULL.
11580
11581 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11582
11583         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11584          in case of call that did not complete.
11585
11586 2019-01-02  Andrey Utkin  <autkin@undo.io>
11587
11588         * symfile.c (find_separate_debug_file): Fix search of debug files for
11589         remote debuggee.
11590
11591 2019-01-02  Tom Tromey  <tom@tromey.com>
11592
11593         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11594         indentation.
11595         * python/py-frame.c (frapy_older): Remove cast.
11596         (frapy_newer): Likewise.
11597         * python/py-breakpoint.c (local_setattro): Remove cast.
11598         * python/py-arch.c (archpy_name): Remove local variable.
11599         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11600
11601 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11602
11603         * unittests/basic_string_view/element_access/char/empty.cc:
11604         Fix year range in copyright header.
11605
11606 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11607
11608         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11609         Delete.
11610         <operator==>: Update with for removed field.
11611         <hash>: Likewise.
11612         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11613         <isa_features>: ...this.
11614         <abi_features>: New field.
11615         (riscv_isa_flen): Update comment.
11616         (riscv_abi_xlen): New declaration.
11617         (riscv_abi_flen): New declaration.
11618         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11619         isa_features.
11620         (riscv_abi_xlen): New function.
11621         (riscv_isa_flen): Update to get answer from isa_features.
11622         (riscv_abi_flen): New function.
11623         (riscv_has_fp_abi): Update to get answer from abi_features.
11624         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11625         xlen and flen.
11626         (riscv_call_info) <xlen, flen>: Update comment.
11627         (riscv_call_arg_struct): Remove invalid assertions
11628         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11629         is removed.
11630         (riscv_gdbarch_init): Gather isa features and abi features
11631         separately, ensure both match on the gdbarch when reusing an old
11632         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11633         a target with 64-bit float hardware.
11634
11635 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11636
11637         * source.c (search_command_helper): Stop reverse search
11638         when line 1 has been searched.
11639
11640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11641
11642         * record-full.c (record_full_base_target::close): Rewrite
11643         record_full_core_buf_list free logic.
11644
11645 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11646
11647         * break-catch-syscall.c (print_one_catch_syscall): xfree
11648         the last text.
11649
11650 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11651
11652         * top.c (print_gdb_version): Update Copyright year in version
11653         message.
11654
11655 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11656
11657         Update copyright year range in all GDB files.
11658
11659 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11660
11661         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11662
11663 For older changes see ChangeLog-2018.
11664 \f
11665 Local Variables:
11666 mode: change-log
11667 left-margin: 8
11668 fill-column: 74
11669 version-control: never
11670 coding: utf-8
11671 End:
11672