gdb/ChangeLog

   1 2019-09-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * dwarf-index-write.c (write_psymbols): Extend error message.
   4         (debug_names::insert): Add Ada code.
   5         (debug_names::write_psymbols): Remove Ada check.
   6         (debug_names) <m_string_obstack>: New member.
   7         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
   8         (gdb_index_symbol_name_matcher::matches): Remove.
   9         (mapped_index_base::find_name_components_bounds): Add "lang"
  10         parameter.
  11         (mapped_index_base::build_name_components): Also split names
  12         according to Ada syntax.
  13         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
  14         type of "match_callback".
  15         (check_match, check_find_bounds_finds)
  16         (dw2_expand_symtabs_matching): Update.
  17         (dw2_debug_names_iterator): Add new constructor.
  18         (dw2_debug_names_map_matching_symbols): New function.
  19         (dw2_debug_names_expand_symtabs_matching): Update.
  20         (dwarf2_debug_names_functions): Use
  21         dw2_debug_names_map_matching_symbols.
  22
  23 2019-09-10  Tom Tromey  <tromey@adacore.com>
  24
  25         * dwarf2read.c (dw2_get_file_names_reader): Add the
  26         CU's file name to the results.
  27
  28 2019-09-10  Tom Tromey  <tromey@adacore.com>
  29
  30         * ada-lang.c (add_nonlocal_symbols): Combine calls to
  31         map_matching_symbols.  Update.
  32         * dwarf2read.c (dw2_map_matching_symbols): Update.
  33         * psymtab.c (match_partial_symbol): Change type; update.
  34         (psym_map_matching_symbols): Likewise.
  35         * symfile-debug.c (debug_qf_map_matching_symbols): Change
  36         type; update.
  37         * symfile.h (struct quick_symbol_functions)
  38         <map_matching_symbols>: Change "name" to be a lookup_name_info.
  39         Remove "match".
  40
  41 2019-09-10  Tom Tromey  <tromey@adacore.com>
  42
  43         * psymtab.c (map_block): Remove.
  44         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
  45         * symtab.c (iterate_over_symbols_terminated): New function.
  46         * symtab.c (iterate_over_symbols_terminated): Declare.
  47
  48 2019-09-10  Tom Tromey  <tromey@adacore.com>
  49
  50         * ada-lang.c (ada_iterate_over_symbols): Return bool.
  51         * language.h (struct language_defn) <la_iterate_over_symbols>:
  52         Return bool.
  53         * symtab.c (iterate_over_symbols): Return bool.
  54         * symtab.h (iterate_over_symbols): Return bool.
  55
  56 2019-09-10  Tom Tromey  <tromey@adacore.com>
  57
  58         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
  59         (add_nonlocal_symbols): Update.
  60         * dwarf2read.c (dw2_map_matching_symbols): Change type.
  61         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
  62         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
  63         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
  64         Change type of "callback".  Remove "data".
  65
  66
  67 2019-09-09  Ali Tamur  <tamur@google.com>
  68
  69         * dwarf2read.c (comp_unit_head): Update comment.
  70         (dwarf2_dwo_name): New function declaration.
  71         (dwarf_unit_type_name): New function declaration.
  72         (read_comp_unit_head): Add support for new compilation units,
  73         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
  74         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
  75         (currently named as "signature") in their header. Also clarify error
  76         messages.
  77         (lookup_dwo_id): New function. Returns the dwo id of the given
  78         compile unit.
  79         (lookup_dwo_unit): Use the new lookup_dwo_id function.
  80         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
  81         functions.
  82         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
  83         (dwarf2_dwo_name): Get the dwo name if present.
  84         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
  85         purposes.
  86
  87 2019-09-09  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
  90
  91 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  92
  93         * python/python.c (do_start_initialization): Make progname_copy static,
  94         to avoid a leak report.
  95
  96 2019-09-08  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
  99
 100 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 101
 102         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 103         Change type to gdb::optional<block_enum>.
 104         (dw2_symtab_iter_init): Change block_index parameter type
 105         to gdb::optional<block_enum>.
 106         (dw2_lookup_symbol): Change block_index parameter
 107         type to block_enum.c
 108         (dw2_debug_names_lookup_symbol): Likewise.
 109         * psymtab.c (psym_lookup_symbol): Likewise.
 110         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 111         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 112         Likewise.
 113
 114 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 115
 116         * defs.h (relocate_gdb_directory): Change int to bool in
 117         signature and rename flag to relocatable.
 118         * main.c (relocate_path): Likewise.
 119         (relocate_gdb_directory): Likewise.
 120
 121 2019-09-06  Alan Modra  <amodra@gmail.com>
 122
 123         * coffread.c (coff_symfile_read): Constify filename variable.
 124         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 125         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 126         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 127         * solib.c (reload_shared_libraries_1): Likewise.
 128         * symfile.c (reread_symbols): Likewise.
 129         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 130         * solib-darwin.c (darwin_bfd_open): Likewise.
 131         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 132
 133 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 134
 135         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 136         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 137
 138 2019-09-03  Tom Tromey  <tromey@adacore.com>
 139
 140         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 141         types.
 142         (has_negatives): Unbias a range type bound.
 143         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 144         * gdbtypes.c (operator==): Handle new field.
 145         (create_range_type): Add "bias" parameter.
 146         (create_static_range_type, resolve_dynamic_range): Update.
 147         * gdbtypes.h (struct range_bounds) <bias>: New member.
 148         (create_range_type): Add bias parameter.
 149         * printcmd.c (print_scalar_formatted): Unbias range types.
 150         * value.c (unpack_long): Unbias range types.
 151         (pack_long): Bias range types.
 152
 153 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 154
 155         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 156         probe arguments.
 157
 158 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 159
 160         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 161         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 162         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 163         (compile_probe_arg): Likewise.
 164         * probe.h (get_argument_count): Likewise.
 165         * solib-svr4.c (solib_event_probe_action): Likewise.
 166         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 167
 168 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 169
 170         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 171         code to here...
 172         (svr4_create_solib_event_breakpoints): ...from here.
 173
 174 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 175
 176         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 177         suffix from warning message.
 178
 179 2019-08-30  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-winsource.h (struct tui_source_window_base)
 182         <refresh_all>: Don't declare.
 183         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 184         Remove.
 185         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 186         tui_show_locator_content.
 187         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 188         declare.
 189         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 190         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 191         declare.
 192
 193 2019-08-30  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 196
 197 2019-08-30  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 200         Remove unnecessary forward declarations.
 201
 202 2019-08-30  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 205         rerender.
 206         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 207         tui_show_locator_content.
 208
 209 2019-08-30  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 212         (tui_locator_window::rerender): Rewrite using body of previous
 213         tui_show_locator_content.
 214
 215 2019-08-30  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 218         set_locator_fullname>: New methods.
 219         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 220         Rename from tui_set_locator_fullname.
 221         (tui_locator_window::set_locator_info): Rename from
 222         tui_set_locator_info.  Return bool.
 223         (tui_update_locator_fullname, tui_show_frame_info): Update.
 224
 225 2019-08-30  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 228
 229 2019-08-30  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 232         call touchwin.
 233
 234 2019-08-30  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-wingeneral.c (box_win): Assume win_info and
 237         win_info->handle cannot be NULL.
 238
 239 2019-08-30  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 242         refresh_window>: Declare.
 243         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 244         resize.
 245         (tui_data_item_window::rerender): Rename from
 246         tui_display_register.
 247         (tui_data_item_window::refresh_window): New method.
 248         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 249         no-op.
 250
 251 2019-08-30  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 254         regs_column_count, current_group>: Move later.  Now private.
 255         <get_current_group>: New method.
 256         * tui/tui-regs.c (tui_reg_command): Update.
 257         * tui/tui-layout.c (tui_set_layout): Update.
 258
 259 2019-08-30  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 262         (tui_data_window::rerender): Don't call
 263         check_and_display_highlight_if_needed.
 264         (tui_data_window::refresh_all): Remove call to
 265         erase_data_content.
 266
 267 2019-08-30  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 270         (tui_data_window::display_registers_from)
 271         (tui_data_window::display_reg_element_at_line)
 272         (tui_data_window::display_registers_from_line): Remove checks of
 273         "empty".
 274
 275 2019-08-30  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 278         Don't declare.
 279         * tui/tui-regs.c (tui_data_window::show_registers): Call
 280         rerender.
 281         (tui_data_window::rerender): Rename from display_all_data.
 282         (tui_data_window::rerender): Remove old implementation.
 283
 284 2019-08-30  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 287         text.
 288         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 289
 290 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 291             Sergio Durigan Junior  <sergiodj@redhat.com>
 292
 293         PR win32/24284
 294         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 295
 296 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 299         when searching for types.
 300
 301 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 302
 303         * f-lang.c (f_language_defn): Use f_print_typedef.
 304         * f-lang.h (f_print_typedef): Declare.
 305         * f-typeprint.c (f_print_typedef): Define.
 306
 307 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 310
 311 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 312
 313         * cli/cli-utils.c (info_print_options_defs): Delete.
 314         (make_info_print_options_def_group): Delete.
 315         (extract_info_print_options): Delete.
 316         (info_print_command_completer): Delete.
 317         (info_print_args_help): Add extra parameter, and optionally
 318         include text about -n flag.
 319         * cli/cli-utils.h (struct info_print_options): Delete.
 320         (extract_info_print_options): Delete declaration.
 321         (info_print_command_completer): Delete declaration.
 322         (info_print_args_help): Add extra parameter, extend header
 323         comment.
 324         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 325         search_symbols.
 326         * stack.c (struct info_print_options): New type.
 327         (info_print_options_defs): New file scoped variable.
 328         (make_info_print_options_def_group): New static function.
 329         (info_print_command_completer): New static function.
 330         (info_locals_command): Update to use new local functions.
 331         (info_args_command): Likewise.
 332         (_initialize_stack): Add extra parameter to calls to
 333         info_print_args_help.
 334         * symtab.c (search_symbols): Add extra parameter, use this to
 335         possibly excluse non-debug symbols.
 336         (symtab_symbol_info): Add extra parameter, which is passed on to
 337         search_symbols.
 338         (struct info_print_options): New type.
 339         (info_print_options_defs): New file scoped variable.
 340         (make_info_print_options_def_group): New static function.
 341         (info_print_command_completer): New static function.
 342         (info_variables_command): Update to use local functions, and pass
 343         extra parameter through to symtab_symbol_info.
 344         (info_functions_command): Likewise.
 345         (info_types_command): Pass additional argument through to
 346         symtab_symbol_info.
 347         (rbreak_command): Pass extra argument to search_symbols.
 348         (_initialize_symtab): Add extra arguments for calls to
 349         info_print_args_help, and update help text for 'info variables',
 350         'whereis', and 'info functions' commands.
 351         * symtab.h (search_symbols): Add extra argument to declaration.
 352         * NEWS: Mention new flags.
 353
 354 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 355
 356         * symtab.c (lookup_static_symbol): Call the new function (and move
 357         it down to be next to lookup_global_symbol).
 358         (struct global_sym_lookup_data): Add block_enum member and rename to...
 359         (struct global_or_static_sym_lookup_data): ...this.
 360         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 361         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 362         (lookup_symbol_global_or_static_iterator_cb): ...this.
 363         (lookup_global_or_static_symbol): New function.
 364         (lookup_global_symbol): Call new function.
 365
 366 2019-08-26  Tom de Vries  <tdevries@suse.de>
 367
 368         PR c++/24852
 369         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 370         when pc_probe.prob == NULL.
 371
 372 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 373
 374         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 375         variable symbol_linkage to symbol_linkage_.
 376
 377 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 378
 379         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 380         represent whether the symbol is static, dynamic, or we don't
 381         know.
 382
 383 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 384
 385         * gdb/rx-tdep.c (rx_register_names): New.
 386         (rx_register_name): Delete.
 387         (rx_psw_type): Delete.
 388         (rx_fpsw_type): Delete.
 389         (rx_register_type): Delete.
 390         (rx_gdbarch_init): Convert target-descriptions.
 391         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 392         * gdb/features/Makefile: Add rx.xml.
 393         * gdb/features/rx.xml: New.
 394         * gdb/features/rx.c: Generated.
 395         * gdb/NEWS: Mention target description support.
 396
 397 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 398
 399         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 400         *slot_ptr.
 401
 402 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 403
 404         * configure.ac: Don't check for 'dlfcn.h' (moved to
 405         gdbsupport/common.m4).
 406         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 407         'gdbsupport/'.
 408         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 409         * compile/compile-c-support.c: Include
 410         'gdbsupport/gdb-dlfcn.h'.
 411         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 412         * gdb-dlfcn.c: Move to...
 413         * gdbsupport/gdb-dlfcn.c: ... here.
 414         * gdb-dlfcn.h: Move to...
 415         * gdbsupport/gdb-dlfcn.h: ... here.
 416
 417 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 418
 419         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 420         the offset field signed.
 421
 422 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 423
 424         * python/lib/gdb/__init__.py (_execute_file): New function.
 425         * python/python.c (python_run_simple_file): Call gdb._execute_file
 426         on Windows.
 427
 428 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 431         all uses as this was never set to anything but a zero value.
 432
 433 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 434
 435         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 436
 437 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 438
 439         * tui/tui-data.h (tui_gen_win_info): Add an =default
 440         move constructor, required by some GCC versions.
 441
 442 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 443
 444         * go32-nat.c (go32_sysinfo): Add hygon_p.
 445
 446 2019-08-20  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 449         line_from_reg_element_no, first_reg_element_no_inline,
 450         display_all_data, delete_data_content_windows,
 451         erase_data_content>: Now private.
 452
 453 2019-08-20  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 456         (tui_unhighlight_win, tui_highlight_win)
 457         (tui_win_info::make_window): Update.
 458         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 459
 460 2019-08-20  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 463         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 464         (MAX_PID_WIDTH): Move to tui-stack.c.
 465         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 466         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 467         (MAX_PID_WIDTH): Move from tui-data.h.
 468
 469 2019-08-20  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 472         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 473         (box_win): Update.
 474         (tui_gen_win_info::make_window): Rename from tui_make_window.
 475         (tui_win_info::make_window): New method.
 476         (tui_gen_win_info::make_visible): Update.
 477         * tui/tui-source.c (tui_source_window::set_contents): Update.
 478         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 479         (tui_data_window::display_registers_from): Update.
 480         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 481         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 482         Declare.
 483         <can_box>: Remove.
 484         <title>: Remove.
 485         (struct tui_win_info) <make_window>: Declare.
 486         <can_box>: Now virtual.
 487         <title>: New member.
 488         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 489         * tui/tui-command.c (tui_cmd_window::resize): Update.
 490
 491 2019-08-20  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 494         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 495         (tui_data_window::check_register_values): Update.
 496
 497 2019-08-20  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-regs.h (struct tui_data_window): Use
 500         DISABLE_COPY_AND_ASSIGN.
 501         <regs_content>: Change type, removing unique_ptr.
 502         <tui_data_window>: Add move constructor.
 503         * tui/tui-regs.c (tui_data_window::show_registers)
 504         (tui_data_window::show_register_group)
 505         (tui_data_window::display_registers_from)
 506         (tui_data_window::display_registers_from)
 507         (tui_data_window::first_data_item_displayed)
 508         (tui_data_window::delete_data_content_windows)
 509         (tui_data_window::rerender, tui_data_window::refresh_window)
 510         (tui_data_window::check_register_values): Update.
 511
 512 2019-08-20  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 515         show_register_group>: Declare.
 516         (tui_show_register_group): Don't declare.
 517         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 518         tui_show_registers.
 519         (tui_data_window::show_register_group): Rename from
 520         tui_show_register_group.
 521         (tui_data_window::check_register_values, tui_reg_command):
 522         Update.
 523         * tui/tui-layout.c (tui_set_layout): Update.
 524
 525 2019-08-20  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 528         Declare.
 529         (tui_check_register_values): Don't declare.
 530         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 531         from tui_check_register_values.
 532         * tui/tui-hooks.c (tui_register_changed): Update.
 533
 534 2019-08-20  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-regs.c (tui_reg_layout): Move later.
 537         (tui_show_registers): Don't enable TUI mode or change layout.
 538
 539 2019-08-20  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-regs.h (struct tui_data_item_window)
 542         <~tui_data_item_window>: Remove.
 543         <content>: Now a unique_xmalloc_ptr.
 544         * tui/tui-regs.c (tui_register_format): Return a
 545         unique_xmalloc_ptr.
 546         (tui_get_register): Update.
 547         (~tui_data_item_window): Remove.
 548         (tui_data_window::display_registers_from, tui_display_register):
 549         Update.
 550         * tui/tui-io.h (tui_expand_tabs): Update.
 551         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 552         Remove "col" parameter.
 553
 554 2019-08-20  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 557         field.
 558         * tui/tui-regs.c (~tui_data_item_window): Update.
 559
 560 2019-08-20  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 563         earlier.
 564
 565 2019-08-20  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 568
 569 2019-08-20  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-source.h (struct tui_source_window): Update.
 572         * tui/tui-regs.c (tui_show_registers): Update.
 573         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 574         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 575         (NO_REGS_STRING): Remove defines.
 576
 577 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 578
 579         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 580         unnecessary thread walk if remote doesn't support the packet.
 581
 582 2019-08-19  Tom Tromey  <tromey@adacore.com>
 583
 584         * python/py-value.c (value_has_field): Fix indentation.
 585
 586 2019-08-19  Tom Tromey  <tromey@adacore.com>
 587
 588         * printcmd.c (do_one_display, info_display_command): Update.
 589         * block.h (contained_in): Return bool.  Add allow_nested
 590         parameter.
 591         * block.c (contained_in): Return bool.  Add allow_nested
 592         parameter.
 593
 594 2019-08-19  Tom Tromey  <tom@tromey.com>
 595
 596         * configure: Rebuild.
 597         * configure.ac: Disallow the combination of -static-libstdc++ and
 598         source highlight.
 599         * source-cache.c (get_language_name): Handle rust.
 600         (source_cache::get_source_lines): Ignore highlighting exceptions.
 601
 602 2019-08-16  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 605         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 606         (struct tui_source_window_base) <make_visible, refresh_window,
 607         resize>: Remove methods.
 608         <execution_info>: Remove field.
 609         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 610         (tui_show_source_line, tui_source_window_base)
 611         (~tui_source_window_base): Update.
 612         (tui_source_window_base::resize)
 613         (tui_source_window_base::make_visible)
 614         (tui_source_window_base::refresh_window): Remove.
 615         (tui_source_window_base::update_exec_info): Update.
 616         * tui/tui-source.c (tui_source_window::set_contents): Update.
 617         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 618
 619 2019-08-16  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 622         deprecated_query_hook.
 623
 624 2019-08-16  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 627         (tui_update_source_windows_with_line): Update.
 628         * tui/tui-source.h (struct tui_source_window)
 629         <show_symtab_source>: Declare.
 630         (tui_show_symtab_source): Don't declare.
 631         * tui/tui-source.c (tui_show_symtab_source): Rename from
 632         tui_show_symtab_source.
 633
 634 2019-08-16  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.h (struct tui_source_window_base)
 637         <set_contents>: Declare.
 638         * tui/tui-winsource.c
 639         (tui_source_window_base::update_source_window_as_is): Update.
 640         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 641         Declare.
 642         (tui_set_source_content): Don't declare.
 643         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 644         tui_set_source_content.
 645         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 646         Declare.
 647         (tui_set_disassem_content): Don't declare.
 648         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 649         tui_set_disassem_content.
 650
 651 2019-08-16  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-winsource.h (struct tui_source_window_base)
 654         <update_breakpoint_info>: Declare.
 655         (tui_update_breakpoint_info): Don't declare.
 656         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 657         (tui_update_all_breakpoint_info): Update.
 658         (tui_source_window_base::update_breakpoint_info): Rename from
 659         tui_update_breakpoint_info.
 660         (tui_source_window_base::update_exec_info): Update.
 661
 662 2019-08-16  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-winsource.h (struct tui_source_window_base)
 665         <update_source_window>: Declare.
 666         (tui_update_source_window): Don't declare.
 667         * tui/tui-winsource.c
 668         (tui_source_window_base::update_source_window): Rename from
 669         tui_update_source_window.
 670         (tui_source_window_base::rerender): Update.
 671         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 672         * tui/tui-disasm.c (tui_show_disassem)
 673         (tui_show_disassem_and_update_source)
 674         (tui_disasm_window::maybe_update): Update.
 675
 676 2019-08-16  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-winsource.h (struct tui_source_window_base)
 679         <update_source_window_as_is>: Declare.
 680         (tui_update_source_window_as_is): Don't declare.
 681         * tui/tui-winsource.c (tui_update_source_window): Update
 682         (tui_source_window_base::update_source_window_as_is): Rename from
 683         tui_update_source_window_as_is.
 684         (tui_source_window_base::refill): Update.
 685         * tui/tui-source.c (tui_show_symtab_source): Update.
 686         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 687         Update.
 688
 689 2019-08-16  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-winsource.h (tui_update_source_window)
 692         (tui_update_source_window_as_is): Remove "noerror" parameter.
 693         * tui/tui-winsource.c (tui_update_source_window)
 694         (tui_update_source_window_as_is): Remove "noerror" parameter.
 695         (tui_update_source_windows_with_addr)
 696         (tui_update_source_windows_with_line)
 697         (tui_source_window_base::rerender)
 698         (tui_source_window_base::refill): Update.
 699         * tui/tui-source.h (tui_set_source_content)
 700         (tui_show_symtab_source): Remove "noerror" parameter.
 701         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 702         parameter.
 703         (tui_show_symtab_source): Likewise.
 704         (tui_source_window::maybe_update): Update.
 705         * tui/tui-disasm.c (tui_show_disassem)
 706         (tui_show_disassem_and_update_source)
 707         (tui_disasm_window::do_scroll_vertical)
 708         (tui_disasm_window::maybe_update): Update.
 709
 710 2019-08-16  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui.c (tui_is_window_visible): Update.
 713         * tui/tui-wingeneral.c (tui_make_window)
 714         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 715         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 716         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 717         (tui_set_win_height_command, parse_scrolling_args): Update.
 718         * tui/tui-source.c (tui_source_window::style_changed): Update.
 719         * tui/tui-regs.c (tui_show_registers)
 720         (tui_data_window::first_data_item_displayed)
 721         (tui_data_window::delete_data_content_windows)
 722         (tui_check_register_values, tui_reg_command): Update.
 723         * tui/tui-disasm.c (tui_show_disassem): Update.
 724         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 725         method.
 726         <is_visible>: Remove field.
 727         * tui/tui-data.c (tui_next_win, tui_prev_win)
 728         (tui_delete_invisible_windows): Update.
 729
 730 2019-08-16  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-winsource.h (struct tui_source_window_base)
 733         <m_has_locator>: Remove.
 734         * tui/tui-layout.c (show_source_disasm_command, show_data)
 735         (show_source_or_disasm_and_command): Update.
 736
 737 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 738
 739         * NEWS (Other MI changes): New subsection.
 740         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 741         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 742         * arch-utils.c (default_get_pc_address_flags): New function.
 743         * arch-utils.h (default_get_pc_address_flags): New declaration.
 744         * gdbarch.sh: Add get_pc_address_flags.
 745         * gdbarch.c: Regenerate.
 746         * gdbarch.h: Likewise.
 747         * stack.c (print_pc): New function.
 748         (print_frame_info) (print_frame): Call print_pc.
 749
 750 2019-08-16  Tom de Vries  <tdevries@suse.de>
 751
 752         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 753         print_objfile_section_info.
 754
 755 2019-08-15  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 758         calling update_cmdwin_start_line.
 759         * tui/tui-winsource.h (struct tui_source_window_base)
 760         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 761         <rerender>: Declare.
 762         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 763         Call rerender.
 764         (tui_source_window_base::set_new_height): Remove.
 765         (tui_source_window_base::rerender): Rename from
 766         do_make_visible_with_new_height.
 767         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 768         resize method.
 769         (tui_win_info::make_invisible_and_set_new_height)
 770         (tui_win_info::make_visible_with_new_height): Remove.
 771         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 772         Declare.
 773         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 774         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 775         do_make_visible_with_new_height>: Don't declare.
 776         <rerender>: Declare.
 777         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 778         set_new_height.
 779         (tui_data_window::do_make_visible_with_new_height): Remove.
 780         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 781         call tui_show_locator_content.
 782         (tui_gen_win_info::resize): Call rerender.
 783         (show_source_or_disasm_and_command): Don't call
 784         tui_show_locator_content.
 785         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 786         method.
 787         (struct tui_win_info) <rerender>: Declare.
 788         <set_new_height, make_invisible_and_set_new_height,
 789         make_visible_with_new_height>: Don't declare.
 790         * tui/tui-data.c (tui_win_list::rerender): New method.
 791         * tui/tui-command.h (struct tui_cmd_window)
 792         <do_make_visible_with_new_height>: Don't declare.
 793         * tui/tui-command.c
 794         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 795
 796 2019-08-15  Tom Tromey  <tromey@adacore.com>
 797
 798         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 799         * ada-lang.c (ada_enum_name): Likewise.
 800
 801 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 802
 803         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 804         leading underscore.
 805         (GdbOutputErrorFile): Likewise.
 806         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 807         accordingly.
 808         (execute_unwinders): Rename to have a leading underscore.
 809         (auto_load_packages): Likewise.
 810         (global scope): Adjust call to auto_load_packages accordingly.
 811         (GdbSetPythonDirectory): Likewise.
 812         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 813         instead of execute_unwinders.
 814
 815 2019-08-15  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 818         (show_data): Don't change window visibility.
 819         (tui_gen_win_info::resize): Remove special case for command
 820         window.  Use wresize, when available.
 821         (show_source_or_disasm_and_command): Don't change window
 822         visibility.
 823         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 824         <make_visible>: New method.
 825         * tui/tui-command.c (tui_cmd_window::resize): New method.
 826
 827 2019-08-15  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 830         (struct tui_source_windows): New.
 831         * tui/tui-winsource.c (tui_display_main): Update.
 832         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 833         (new_height_ok, parse_scrolling_args): Update.
 834         * tui/tui-layout.c (show_layout, show_data): Update.
 835         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 836         (tui_add_to_source_windows): Don't declare.
 837         * tui/tui-data.c (source_windows, tui_source_windows)
 838         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 839
 840 2019-08-15  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 843         Rename from reset.
 844         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 845         * tui/tui-layout.c (show_source_disasm_command, show_data):
 846         Update.
 847         (tui_gen_win_info::resize): Rename.
 848         (show_source_or_disasm_and_command): Update.
 849         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 850         reset.
 851
 852 2019-08-15  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 855         * tui/tui-interp.c (tui_interp::init): Don't call
 856         tui_initialize_static_data.
 857         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 858
 859 2019-08-15  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 862         examine tui_win_list.
 863
 864 2019-08-15  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 867         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 868         tui_clear_source_content.
 869         (tui_clear_source_content): Remove.
 870         (tui_source_window_base::do_erase_source_content): Hoist call to
 871         content.clear().
 872         * tui/tui-stack.c (tui_show_frame_info): Don't call
 873         tui_clear_source_content.
 874
 875 2019-08-15  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-winsource.h (struct tui_source_window_base)
 878         <do_erase_source_content>: New method.
 879         <erase_source_content>: New method.
 880         (tui_erase_source_content): Don't declare.
 881         * tui/tui-winsource.c (tui_clear_source_content): Update.
 882         (tui_source_window_base::do_erase_source_content): Rename from
 883         tui_erase_source_content.
 884         (tui_source_window_base::show_source_content): Update.
 885         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 886         * tui/tui-source.h (struct tui_source_window)
 887         <erase_source_content>: New method.
 888         * tui/tui-disasm.h (struct tui_disasm_window)
 889         <erase_source_content>: New method.
 890
 891 2019-08-15  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 894         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 895         constructor.
 896         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 897         * tui/tui-source.c (tui_set_source_content): Update.
 898         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 899
 900 2019-08-15  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 903         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 904         tui-source.c.
 905         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 906         Declare.
 907         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 908         method.
 909         (tui_source_window::maybe_update): Update.
 910
 911 2019-08-15  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 914         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 915         tui-disasm.c.
 916         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 917         Declare.
 918         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 919         method.
 920         (tui_disasm_window::maybe_update): Update.
 921
 922 2019-08-15  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-winsource.h (struct tui_source_window_base)
 925         <maybe_update>: Declare.
 926         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 927         method.
 928         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 929         Declare.
 930         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 931         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 932         Declare.
 933         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 934
 935 2019-08-15  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 938
 939 2019-08-15  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-wingeneral.c: Include tui-stack.h.
 942         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 943         (struct tui_locator_window): Move from tui-data.h.
 944         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 945         (tui_initialize_static_data): Move from tui-data.c.
 946         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 947         (struct tui_locator_window): Move to tui-stack.c.
 948         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 949         (tui_initialize_static_data): Move to tui-stack.c.
 950
 951 2019-08-15  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-layout.c (show_source_disasm_command)
 954         (show_source_or_disasm_and_command): Use make_visible method, not
 955         tui_make_window.
 956         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 957         Remove.
 958
 959 2019-08-15  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-wingeneral.h (tui_make_window): Update.
 962         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 963         parameter.
 964         (tui_gen_win_info::make_visible): Update.
 965         * tui/tui-regs.c (tui_data_window::display_registers_from):
 966         Update.
 967         * tui/tui-layout.c (show_source_disasm_command)
 968         (show_source_or_disasm_and_command): Update.
 969         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 970         (enum tui_box): Remove.
 971         (struct tui_win_info) <can_box>: New method.
 972         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 973         method.
 974
 975 2019-08-15  Tom de Vries  <tdevries@suse.de>
 976
 977         * linux-nat-trad.c: Include gdbarch.h.
 978
 979 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 980
 981         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 982         register sizes.
 983
 984 2019-08-14  Tom Tromey  <tromey@adacore.com>
 985
 986         * darwin-nat.c: Include gdbarch.h.
 987         * darwin-nat-info.c: Include gdbarch.h.
 988
 989 2019-08-13  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 992         Remove.
 993         * tui/tui-data.c (tui_initialize_static_data): Update.
 994
 995 2019-08-13  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-winsource.h (struct tui_exec_info_window)
 998         <~tui_exec_info_window, maybe_allocate_content, get_content,
 999         m_content>: Remove.
1000         (struct tui_source_window_base) <set_exec_info_content,
1001         show_exec_info_content>: Don't declare.
1002         * tui/tui-winsource.c
1003         (tui_exec_info_window::maybe_allocate_content): Remove.
1004         (tui_source_window_base::update_exec_info): Rename from
1005         set_exec_info_content.
1006         (tui_source_window_base::show_exec_info_content)
1007         (tui_source_window_base::update_exec_info): Remove.
1008
1009 2019-08-13  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1012         declare.
1013         * tui/tui-winsource.c (tui_update_source_window_as_is)
1014         (tui_update_source_windows_with_addr, tui_erase_source_content):
1015         Update.
1016         (tui_clear_exec_info_content): Remove.
1017
1018 2019-08-13  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1021         declare.
1022         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1023         call tui_erase_exec_info_content.
1024         (tui_clear_exec_info_content): Rename from
1025         tui_erase_exec_info_content.
1026         (tui_clear_exec_info_content): Delete.
1027
1028 2019-08-13  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-winsource.h (struct tui_source_window_base)
1031         <show_exec_info_content>: Declare.
1032         (tui_show_exec_info_content): Don't declare.
1033         * tui/tui-winsource.c
1034         (tui_source_window_base::show_exec_info_content): Rename from
1035         tui_show_exec_info_content.
1036         (tui_source_window_base::update_exec_info): Update.
1037
1038 2019-08-13  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1041         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1042         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1043         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1044         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1045         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1046         ... here.
1047
1048 2019-08-13  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-winsource.h (struct tui_source_window_base)
1051         <update_exec_info>: Declare.
1052         (tui_update_exec_info): Don't declare.
1053         * tui/tui-winsource.c (tui_update_source_window_as_is)
1054         (tui_source_window_base::refresh_all)
1055         (tui_update_all_breakpoint_info): Update.
1056         (tui_source_window_base::update_exec_info): Rename from
1057         tui_update_exec_info.
1058         * tui/tui-stack.c (tui_show_frame_info): Update.
1059
1060 2019-08-13  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-winsource.h (struct tui_source_window_base)
1063         <set_exec_info_content>: Declare.
1064         (tui_set_exec_info_content): Don't declare.
1065         * tui/tui-winsource.c
1066         (tui_source_window_base::set_exec_info_content): Rename from
1067         tui_set_exec_info_content.
1068         (tui_update_exec_info): Update.
1069
1070 2019-08-13  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-winsource.h (struct tui_source_window_base)
1073         <show_source_content>: Declare.
1074         (tui_show_source_content): Don't declare.
1075         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1076         (tui_source_window_base::show_source_content): Rename from
1077         tui_show_source_content.
1078         (tui_source_window_base::refresh_all): Update.
1079         * tui/tui-layout.c (show_source_disasm_command)
1080         (show_source_or_disasm_and_command): Update.
1081
1082 2019-08-13  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-winsource.c (tui_erase_source_content)
1085         (tui_show_source_content, tui_source_window_base::refresh_all):
1086         Update.
1087         * tui/tui-wingeneral.h
1088         (tui_check_and_display_highlight_if_needed): Don't declare.
1089         * tui/tui-wingeneral.c
1090         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1091         check_and_display_highlight_if_needed.
1092         * tui/tui-win.c (tui_rehighlight_all)
1093         (tui_win_info::make_visible_with_new_height): Update.
1094         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1095         (tui_data_window::erase_data_content)
1096         (tui_data_window::display_all_data): Update.
1097         * tui/tui-data.h (struct tui_win_info)
1098         <check_and_display_highlight_if_needed>: Declare.
1099
1100 2019-08-13  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-win.c (tui_resize_all): Call
1103         tui_delete_invisible_windows.
1104         * tui/tui-layout.c (show_layout): Call
1105         tui_delete_invisible_windows.
1106         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1107         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1108
1109 2019-08-13  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1112         tui_add_win_to_layout.
1113
1114 2019-08-13  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1117         * tui/tui-layout.c (tui_default_win_height): Now static.
1118
1119 2019-08-13  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1122         single switch.
1123         (show_source_disasm_command, show_source_or_disasm_and_command):
1124         Don't check current layout.
1125
1126 2019-08-13  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-wingeneral.c (make_all_visible): Remove.
1129         (tui_make_all_invisible): Simplify.
1130         * tui/tui-layout.c (tui_make_all_invisible): Move from
1131         tui-wingeneral.c; simplify.
1132         (show_layout): Hoist call to tui_make_all_invisible.
1133         (show_data): Don't call tui_make_all_invisible.
1134
1135 2019-08-13  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1138         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1139
1140 2019-08-13  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1143         tui-data.c.
1144         (show_source_disasm_command, show_data)
1145         (show_source_or_disasm_and_command): Don't use
1146         tui_set_current_layout_to.
1147         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1148         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1149         tui-layout.c.
1150         (tui_set_current_layout_to): Remove.
1151
1152 2019-08-13  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-layout.c (tui_set_layout): Update.
1155         * tui/tui-data.h (struct tui_layout_def): Remove.
1156         (tui_layout_def): Don't declare.
1157         * tui/tui-data.c (layout_def): Remove.
1158         (tui_layout_def): Remove.
1159
1160 2019-08-13  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-winsource.h (struct tui_source_window_base)
1163         <clear_detail>: No longer "override".
1164         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1165         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1166         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1167         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1168         Remove.
1169         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1170
1171 2019-08-13  Tom Tromey  <tromey@adacore.com>
1172
1173         * tracepoint.c: Don't include readline.h or history.h.
1174
1175 2019-08-12  Tom Tromey  <tom@tromey.com>
1176
1177         * configure: Rebuild.
1178         * configure.ac: Check for readline 7.
1179         * NEWS: Mention readline 7 requirement.
1180         * README: Update.
1181
1182 2019-08-12  Tom Tromey  <tom@tromey.com>
1183
1184         * mingw-hdep.c (gdb_select): Remove readline hack.
1185
1186 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1187
1188         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1189         when the function fails.
1190
1191 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1192
1193         * s390-tdep.c (s390_type_align): New function.
1194         (s390_gdbarch_init): Set it as type_align gdbarch method.
1195
1196 2019-08-09  Tom de Vries  <tdevries@suse.de>
1197
1198         PR gdb/24591
1199         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1200         pc_low with relocation offset.
1201
1202 2019-08-07  Tom Tromey  <tromey@adacore.com>
1203
1204         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1205         (print_frame_args): Update.
1206         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1207         Update.
1208         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1209         * frame.h (struct frame_arg): Add initializers.
1210         <error>: Now a unique_xmalloc_ptr.
1211
1212 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1213
1214         * NEWS: Expand the Pointer Authentication entry.
1215         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1216         (aarch64_frame_unmask_lr): ... to this.
1217         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1218         Call aarch64_frame_unmask_lr.
1219         * frame.c (struct frame_info): Add "masked" variable.
1220         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1221         (fprint_frame): Check for masked pc.
1222         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1223         declarations.
1224         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1225         * stack.c (print_frame): Check for masked pc.
1226
1227 2019-08-06  Tom Tromey  <tom@tromey.com>
1228
1229         * stabsread.c (patch_block_stabs, read_one_struct_field)
1230         (read_enum_type): Use obstack_strndup.
1231         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1232         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1233         * dwarf2read.c (guess_full_die_structure_name)
1234         (anonymous_struct_prefix): Use obstack_strndup.
1235         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1236         * c-exp.y (yylex): Use obstack_strndup.
1237         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1238         (write_var_or_type): Use obstack_strndup.
1239
1240 2019-08-06  Tom Tromey  <tom@tromey.com>
1241
1242         * symfile.c (reread_symbols): Use obstack_strdup.
1243         * stabsread.c (read_type): Use obstack_strdup.
1244         * gdb_obstack.h (obstack_strdup): New overload.
1245         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1246         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1247         (dwarf2_canonicalize_name): Use obstack_strdup.
1248         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1249         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1250         Use obstack_strdup.
1251
1252 2019-08-06  Tom Tromey  <tom@tromey.com>
1253
1254         * gdb_obstack.h (obstack_strdup): Define.
1255         * gdb_obstack.c (obstack_strdup): Don't define.
1256
1257 2019-08-06  Tom Tromey  <tom@tromey.com>
1258
1259         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1260         obstack_strdup.
1261         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1262         obstack_strdup.
1263         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1264         * stabsread.c (common_block_start): Use obstack_strdup.
1265         * objfiles.c (set_objfile_main_name, objfile): Use
1266         obstack_strdup.
1267         * namespace.c (add_using_directive): Use obstack_strdup.
1268         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1269         * jit.c (finalize_symtab): Use obstack_strdup.
1270         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1271         (guess_partial_die_structure_name, partial_die_info::fixup)
1272         (dwarf2_name): Use obstack_strdup.
1273         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1274         obstack_strdup.
1275         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1276         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1277         obstack_strdup.
1278         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1279
1280 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1281
1282         * unittests/help-doc-selftests.c: New file.
1283         * Makefile.in: Add the new file.
1284
1285 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1286
1287         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1288         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1289         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1290         the trailing '.' is not output, and the first character is uppercased.
1291         (print_help_for_command): Update call to print_doc_line.
1292         (print_doc_of_command): Likewise.
1293         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1294         * cli/cli-option.c (append_indented_doc): Do not append newline.
1295         (build_help_option): Append newline after first appended_indented_doc
1296         only if a second call is done.
1297         (build_help): Append 2 new lines before each option, except the first
1298         one.
1299         * compile/compile.c (_initialize_compile): Add new lines after
1300         %OPTIONS%, when not at the end of the help.
1301         Change help doc or code
1302         producing the help doc to respect the invariants.
1303         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1304         Also removed the new line after 'Options:', as all other commands
1305         do not put an empty line between 'Options:' and the first option.
1306         * printcmd.c (_initialize_printcmd): Likewise.
1307         * stack.c (_initialize_stack): Likewise.
1308         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1309         incorrectly telling COMMAND is optional.
1310         * ada-lang.c (_initialize_ada_language): Change help doc or code
1311         producing the help doc to respect the invariants.
1312         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1313         * breakpoint.c (_initialize_breakpoint): Likewise.
1314         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1315         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1316         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1317         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1318         _initialize_cli_style): Likewise.
1319         * corelow.c (core_target_info): Likewise.
1320         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1321         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1322         * filesystem.c (_initialize_filesystem): Likewise.
1323         * frame.c (_initialize_frame): Likewise.
1324         * gnu-nat.c (add_task_commands): Likewise.
1325         * infcall.c (_initialize_infcall): Likewise.
1326         * infcmd.c (_initialize_infcmd): Likewise.
1327         * interps.c (_initialize_interpreter): Likewise.
1328         * language.c (_initialize_language): Likewise.
1329         * linux-fork.c (_initialize_linux_fork): Likewise.
1330         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1331         * maint.c (_initialize_maint_cmds): Likewise.
1332         * memattr.c (_initialize_mem): Likewise.
1333         * printcmd.c (_initialize_printcmd): Likewise.
1334         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1335         _RegEx): Likewise.
1336         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1337         * record-btrace.c (_initialize_record_btrace): Likewise.
1338         * record-full.c (_initialize_record_full): Likewise.
1339         * record.c (_initialize_record): Likewise.
1340         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1341         * regcache.c (_initialize_regcache): Likewise.
1342         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1343         _initialize_remote): Likewise.
1344         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1345         * serial.c (_initialize_serial): Likewise.
1346         * skip.c (_initialize_step_skip): Likewise.
1347         * source.c (_initialize_source): Likewise.
1348         * stack.c (_initialize_stack): Likewise.
1349         * symfile.c (_initialize_symfile): Likewise.
1350         * symtab.c (_initialize_symtab): Likewise.
1351         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1352         * top.c (init_main): Likewise.
1353         * tracefile-tfile.c (tfile_target_info): Likewise.
1354         * tracepoint.c (_initialize_tracepoint): Likewise.
1355         * tui/tui-win.c (_initialize_tui_win): Likewise.
1356         * utils.c (add_internal_problem_command): Likewise.
1357         * valprint.c (value_print_option_defs): Likewise.
1358
1359 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1360
1361         PR build/24886
1362         * configure.ac: Drop enable-libmcheck support.
1363         * configure, config.in: Rebuild.
1364         * libmcheck.m4: Remove.
1365         * acinclude.m4: Don't include it.
1366         * Makefile.in: Don't distribute it.
1367         * top.c (print_gdb_configuration): Don't mention it.
1368
1369 2019-08-06  Tom Tromey  <tom@tromey.com>
1370
1371         * utils.c (set_output_style): Sometimes pass stream to
1372         emit_style_escape.
1373         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1374         * record-btrace.c (btrace_insn_history): Update.
1375         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1376         method.
1377         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1378         Update initializers.
1379         <m_uiout>: New field.
1380         <m_di>: Move lower.
1381         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1382         Remove "uiout" parameter.
1383         (dump_insns): Update.
1384         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1385         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1386
1387 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1388
1389         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1390         (error_in_psymtab_expansion): Likewise.
1391         (lookup_symbol_via_quick_fns): Likewise.
1392         (basic_lookup_transparent_type_quick): Likewise.
1393         (basic_lookup_transparent_type_1): Likewise.
1394
1395 2019-08-06  Tom Tromey  <tromey@adacore.com>
1396
1397         * source.c (last_source_error): Now bool.
1398         (print_source_lines_base): Make "noprint" bool.  Only open
1399         source file when last_source_visited changes.
1400
1401 2019-08-06  Tom Tromey  <tromey@adacore.com>
1402
1403         * annotate.c (annotate_source_line): Use g_source_cache.
1404         * source-cache.c (source_cache::get_plain_source_lines): Change
1405         parameters.  Populate m_offset_cache.
1406         (source_cache::ensure): New method.
1407         (source_cache::get_line_charpos): New method.
1408         (extract_lines): Move lower.  Change parameters.
1409         (source_cache::get_source_lines): Move lower.
1410         * source-cache.h (class source_cache): Update comment.
1411         <get_line_charpos>: New method.
1412         <get_source_lines>: Update comment.
1413         <clear>: Clear m_offset_cache.
1414         <get_plain_source_lines>: Change parameters.
1415         <ensure>: New method
1416         <m_offset_cache>: New member.
1417         * source.c (forget_cached_source_info_for_objfile): Update.
1418         (info_source_command): Use g_source_cache.
1419         (find_source_lines, open_source_file_with_line_charpos): Remove.
1420         (print_source_lines_base, search_command_helper): Use g_source_cache.
1421         * source.h (open_source_file_with_line_charpos): Don't declare.
1422         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1423         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1424         Use g_source_cache.
1425
1426 2019-08-06  Tom Tromey  <tromey@adacore.com>
1427
1428         * source-cache.c (source_cache::get_plain_source_lines):
1429         Remove "first_line" and "last_line" parameters.
1430         (source_cache::get_source_lines): Cache plain text.
1431         * source-cache.h (class source_cache)
1432         <get_plain_source_lines>: Update.
1433
1434 2019-08-06  Tom Tromey  <tromey@adacore.com>
1435
1436         * source-cache.c (extract_lines): No longer a method.
1437         Changed type of parameter.  Include final newline.
1438         (selftests::extract_lines_test): New function.
1439         (_initialize_source_cache): Likewise.
1440         * source-cache.h (class source_cache)
1441         <extract_lines>: Don't declare.
1442
1443 2019-08-06  Tom Tromey  <tromey@adacore.com>
1444
1445         * breakpoint.c (init_breakpoint_sal): Update.
1446         (breakpoint): Update.
1447         * breakpoint.h (struct breakpoint) <filter>: Now a
1448         unique_xmalloc_ptr.
1449
1450 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1451
1452         * NEWS: Mention dictionary access on blocks.
1453         * python/py-block.c (blpy_getitem): New function.
1454         (block_object_as_mapping): New struct.
1455         (block_object_type): Use new struct for tp_as_mapping field.
1456
1457 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1458
1459         * objfiles.h (objfile): Add a comment describing partial symbols.
1460
1461 2019-08-05  Tom Tromey  <tromey@adacore.com>
1462
1463         * compile/compile.c (_initialize_compile): Use _(), not N_().
1464         * thread.c (_initialize_thread): Use _(), not N_().
1465         * stack.c (_initialize_stack): Use _(), not N_().
1466         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1467
1468 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1469
1470         * dwarf2read.c (struct dw2_symtab_iterator):
1471         <want_specific_block>: Remove.
1472         <block_index>: Change type to gdb::optional.
1473         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1474         change type of BLOCK_INDEX parameter to gdb::optional.
1475         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1476         (dw2_lookup_symbol): Don't pass argument for
1477         WANT_SPECIFIC_BLOCK.
1478         (dw2_expand_symtabs_for_function): Don't pass argument for
1479         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1480         (class dw2_debug_names_iterator)
1481         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1482         parameter, change BLOCK_INDEX type to gdb::optional.
1483         <m_want_specific_block>: Remove.
1484         <m_block_index>: Change type to gdb::optional.
1485         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1486         gdb::optional.  Re-write in function of gdb::optional.
1487         (dw2_debug_names_lookup_symbol): Don't pass argument for
1488         WANT_SPECIFIC_BLOCK.
1489         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1490         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1491         BLOCK_INDEX.
1492
1493 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1494
1495         * NEWS: Mention changes to "info sources" command.
1496
1497 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1498
1499         * symtab.c (filename_partial_match_opts): New struct type.
1500         (struct output_source_filename_data): New members
1501         regexp, c_regexp, partial_match.
1502         (output_source_filename): Use new members to decide to print file.
1503         (info_sources_option_defs): New variable.
1504         (make_info_sources_options_def_group, print_info_sources_header,
1505         info_sources_command_completer):
1506         New functions.
1507         (info_sources_command): Read new optional arguments.
1508         (_initialize_symtab): Update info sources help.
1509
1510 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1511
1512         * ada-lang.c (exception_support_info_v0): Renamed from...
1513         (default_exception_support_info): ... this.  Create new
1514         definition for v1.
1515         (ada_has_this_exception_support): Look up catch_handlers_sym.
1516         (ada_exception_support_info_sniffer): Try v0 after default.
1517
1518 2019-08-01  Tom Tromey  <tromey@adacore.com>
1519
1520         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1521         gdbarch.h.
1522
1523 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1524
1525         * s12z-tdep.c: Fix include path for s12z-opc.h.
1526
1527 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1528
1529         * NEWS: Require GNU make 3.82.
1530
1531 2019-07-16  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1534         declare.
1535
1536 2019-07-30  Tom Tromey  <tromey@adacore.com>
1537
1538         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1539
1540 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1541
1542         * printcmd.c (print_address_symbolic): Print negative offsets.
1543         (build_address_symbolic): Force signed arithmetic when computing
1544         offset.
1545
1546 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1547
1548         PR/24474: Add a function to lookup static variables.
1549         * NEWS: Mention this new function.
1550         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1551         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1552         * python/python.c (python_GdbMethods): Add new function.
1553
1554 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1555
1556         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1557         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1558         (objfpy_lookup_static_symbol): New function.
1559         (objfile_object_methods): Add new functions.
1560
1561 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1562
1563         * NEWS: Mention 'set|show print frame-info'.  Mention new
1564         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1565         backtrace argument.  Mention that python frame filtering code
1566         is now consistent with what 'backtrace' command prints.
1567
1568 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1569
1570         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1571         comments.
1572         (print_frame_info_auto, print_frame_info_source_line,
1573         print_frame_info_location, print_frame_info_source_and_location,
1574         print_frame_info_location_and_address, print_frame_info_short_location):
1575         New declarations.
1576         (struct frame_print_options): New member print_frame_info.
1577         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1578         * stack.h (get_user_print_what_frame_info): New declaration.
1579         (frame_show_address): New declaration.
1580         * stack.c (print_frame_arguments_choices): New value 'presence'.
1581         (print_frame_info_auto, print_frame_info_source_line,
1582         print_frame_info_location, print_frame_info_source_and_location,
1583         print_frame_info_location_and_address, print_frame_info_short_location,
1584         print_frame_info_choices, print_frame_info_print_what): New definitions.
1585         (print_frame_args): Only print dots for args if print frame-arguments
1586         is 'presence'.
1587         (frame_print_option_defs): New element for "frame-info".
1588         (get_user_print_what_frame_info): New function.
1589         (frame_show_address): Make non static.  Move comment to stack.h.
1590         (print_frame_info_to_print_what): New function.
1591         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1592         to decide what to print.
1593         (backtrace_command_1): Handle the new print_frame_arguments_presence
1594         value.
1595         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1596         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1597         (py_print_frame): In non-mi mode, use LOCATION as default for
1598         print_what, similarly to frame information printed directly by
1599         backtrace command. Handle frame-info user option in non MI mode.
1600
1601 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1602
1603         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1604         Add case for debugging 32-bit target on 64-bit host.  Revise
1605         comment.
1606
1607 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1608
1609         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1610         instead of find_function_entry_range_from_pc.
1611
1612 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1613
1614         * stack.c (find_frame_funname): Remove code which preferred
1615         minsym over symtab sym in "certain pathological cases".
1616
1617         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1618         parameter.  Change type of "do_demangle" to bool.
1619         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1620         Pass suitable "prefer_sym_over_minsym" flag to
1621         build_address_symbolic().  Don't output "+" for negative offsets.
1622         * printcmd.c (print_address_symbolic): Update invocation of
1623         build_address_symbolic to include a "prefer_sym_over_minsym"
1624         flag.
1625         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1626         Restrict cases in which use of minimal symbol is preferred to that
1627         of a found symbol.  Update comments.
1628
1629         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1630         for entry pc when entry pc is out of range for that FDE.
1631
1632 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1633
1634         PR gdb/24839:
1635         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1636         type.
1637
1638 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1639
1640         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1641         this function's Python signature.
1642
1643
1644 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1645
1646         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1647         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1648         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1649         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1650         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1651
1652
1653 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1654
1655         * h8300-tdep.c (h8300_register_name_common): New.
1656         h8300_register_name): Use h8300_register_name_common.
1657         (h8300s_register_name): Likewise.
1658         (h8300sx_register_name): Likewise.
1659         (h8300h_register_nam): New.
1660         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1661
1662
1663 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1664
1665         * arm-tdep.c (arm_skip_cmse_entry): New function.
1666         (arm_is_sgstubs_section): New function.
1667         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1668
1669 2019-07-22  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1672         Don't self-assign.
1673
1674 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1677         type_print.
1678
1679 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1680
1681         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1682         so that GDB doesn't match any msymbols when searching in the
1683         TYPES_DOMAIN.
1684         (print_symbol_info): Print using typedef_print or type_print based
1685         on the type of the symbol.  Add updated FIXME comment moved from...
1686         (_initialize_symtab): ... move and update FIXME comment to above.
1687
1688 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * NEWS: Mention adding -q option to "info types".
1691         * symtab.c (struct info_types_options): New struct.
1692         (info_types_options_defs): New variable.
1693         (make_info_types_options_def_group): New function.
1694         (info_types_command): Use gdb::option framework to parse options.
1695         (info_types_command_completer): New function.
1696         (_initialize_symtab): Extend the help text on "info types" and
1697         register command completer.
1698
1699 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1700
1701         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1702         (lookup_symbol_in_objfile): Change int to block_enum and add a
1703         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1704
1705 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1706
1707         * MAINTAINERS (Write After Approval): Add self.
1708
1709 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1710
1711         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1712         instruction to the dummy code region.
1713
1714 2019-07-19  Tom Tromey  <tromey@adacore.com>
1715
1716         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1717         (ARGSUSED, PARAMS, __func__): Remove rules.
1718
1719 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1720
1721         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1722         * features/arm/arm-with-iwmmxt.c: Remove.
1723         * features/arm/arm-with-iwmmxt.xml: Remove.
1724         * features/arm/arm-with-m-fpa-layout.c: Remove.
1725         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1726         * features/arm/arm-with-m-vfp-d16.c: Remove.
1727         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1728         * features/arm/arm-with-m.c: Remove.
1729         * features/arm/arm-with-m.xml: Remove.
1730         * features/arm/arm-with-neon.c: Remove.
1731         * features/arm/arm-with-neon.xml: Remove.
1732         * features/arm/arm-with-vfpv2.c: Remove.
1733         * features/arm/arm-with-vfpv2.xml: Remove.
1734         * features/arm/arm-with-vfpv3.c: Remove.
1735         * features/arm/arm-with-vfpv3.xml: Remove.
1736
1737 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1738
1739         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1740
1741 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1742
1743         * arch/aarch32.c (aarch32_create_target_description): Create
1744         target descriptions using features.
1745         * arch/arm.c (arm_create_target_description)
1746         (arm_create_mprofile_target_description): Likewise.
1747         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1748
1749 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1750
1751         * Makefile.in: Add new files.
1752         * aarch32-tdep.c: New file.
1753         * aarch32-tdep.h: New file.
1754         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1755         Call aarch32_read_description.
1756         * arch/aarch32.c: New file.
1757         * arch/aarch32.h: New file.
1758         * arch/arm.c (arm_create_target_description)
1759         (arm_create_mprofile_target_description): New function.
1760         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1761         (arm_create_target_description)
1762         (arm_create_mprofile_target_description): New declaration.
1763         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1764         read_description functions.
1765         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1766         Likewise.
1767         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1768         * arm-tdep.c (tdesc_arm_list): New variable.
1769         (arm_register_g_packet_guesses): Call create description functions.
1770         (arm_read_description) (arm_read_mprofile_description): New
1771         function.
1772         * arm-tdep.h (arm_read_description)
1773         (arm_read_mprofile_description): Add declaration.
1774         * configure.tgt: Add new files.
1775
1776 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1777
1778         * top.c (new_ui_command): Open specified terminal just once.
1779
1780 2019-07-18  Tom Tromey  <tromey@adacore.com>
1781
1782         * symtab.c (main_name): Constify return type.
1783         * symfile.c (set_initial_language): Update.
1784         * symtab.h (main_name): Constify return type.
1785
1786 2019-07-17  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-winsource.c (tui_update_source_window)
1789         (tui_update_source_window_as_is)
1790         (tui_update_source_windows_with_line): Remove return.
1791         * tui/tui-disasm.c (tui_show_disassem)
1792         (tui_show_disassem_and_update_source): Remove return.
1793         * tui/tui.c (tui_reset): Remove return.
1794         * tui/tui-wingeneral.c
1795         (tui_check_and_display_highlight_if_needed): Remove return.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1800
1801 2019-07-17  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-winsource.h (struct tui_exec_info_window)
1804         (struct tui_source_window_base): Move from tui-data.h.
1805         * tui/tui-winsource.c: Move many method definitions from
1806         elsewhere.  Remove "structuring" comments.
1807         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1808         (tui_source_window_base::refresh_window): Move to
1809         tui-winsource.c.
1810         * tui/tui-win.c (tui_source_window_base::refresh_all)
1811         (tui_source_window_base::update_tab_width)
1812         (tui_source_window_base::set_new_height)
1813         (tui_source_window_base::do_make_visible_with_new_height): Move to
1814         tui-winsource.c.
1815         * tui/tui-source.h: Update.
1816         * tui/tui-source.c (tui_source_window_base::reset): Move to
1817         tui-winsource.c.
1818         * tui/tui-disasm.h: Update.
1819         * tui/tui-data.h (struct tui_exec_info_window): Move to
1820         tui-winsource.h.
1821         (struct tui_source_window_base): Likewise.
1822         * tui/tui-data.c (tui_source_window_base::clear_detail)
1823         (tui_source_window_base, ~tui_source_window_base): Move to
1824         tui-winsource.c.
1825
1826 2019-07-17  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-win.c (tui_resize_all)
1829         (tui_source_window_base::update_tab_width)
1830         (tui_adjust_win_heights): Update.
1831         (tui_win_info::make_invisible_and_set_new_height): Rename from
1832         make_invisible_and_set_new_height.
1833         * tui/tui-data.h (struct tui_win_info)
1834         <make_invisible_and_set_new_height>: New method.
1835
1836 2019-07-17  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui.c: Update.
1839         * tui/tui-source.h (struct tui_source_window): Move from
1840         tui-data.h.
1841         * tui/tui-layout.c: Update.
1842         * tui/tui-disasm.c: Update.
1843         * tui/tui-data.h (struct tui_source_window): Move to
1844         tui-source.h.
1845
1846 2019-07-17  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1849         tui-data.h.
1850         * tui/tui-data.h (struct tui_disasm_window): Move to
1851         tui-disasm.h.
1852
1853 2019-07-17  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-regs.h (struct tui_data_item_window): Move from
1856         tui-data.h.
1857         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1858         * tui/tui-data.h (struct tui_data_item_window): Move to
1859         tui-regs.h.
1860         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1861
1862 2019-07-17  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui.c: Update.
1865         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1866         (tui_cmd_window::max_height): Move to tui-command.c.
1867         * tui/tui-layout.c: Update.
1868         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1869         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1870         tui-command.c.
1871         * tui/tui-command.h (struct tui_cmd_window): Move from
1872         tui-data.h.
1873         * tui/tui-command.c: Remove "structuring" comments.
1874         (tui_cmd_window::clear_detail)
1875         (tui_cmd_window::do_make_visible_with_new_height)
1876         (tui_cmd_window::max_height): Move from elsewhere.
1877
1878 2019-07-17  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1881         Now static.
1882         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1883         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui.c: Update.
1888         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1889         tui-regs.c.
1890         * tui/tui-windata.h: Remove file.
1891         * tui/tui-windata.c: Remove file.
1892         * tui/tui-win.c (tui_data_window::set_new_height)
1893         (tui_data_window::do_make_visible_with_new_height): Move to
1894         tui-regs.c.
1895         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1896         * tui/tui-regs.c: Remove "structuring" comments.
1897         (tui_data_window::first_data_item_displayed)
1898         (tui_data_window::delete_data_content_windows)
1899         (tui_data_window::erase_data_content)
1900         (tui_data_window::display_all_data)
1901         (tui_data_window::refresh_all)
1902         (tui_data_window::do_scroll_vertical)
1903         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1904         (tui_data_window::do_make_visible_with_new_height)
1905         (tui_data_window::refresh_window): Move from elsewhere.
1906         (_initialize_tui_regs): Move to end of file.
1907         * tui/tui-layout.c: Update.
1908         * tui/tui-hooks.c: Update.
1909         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1910         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1911         tui-regs.c.
1912         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1913
1914 2019-07-17  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1917         seen.
1918
1919 2019-07-17  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-win.c (tui_source_window_base::set_new_height)
1922         (tui_source_window_base::do_make_visible_with_new_height): Use
1923         m_has_locator field directly.
1924         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1925         method.
1926         (struct tui_source_window_base) <has_locator>: Likewise.
1927
1928 2019-07-17  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1931         Don't declare.
1932         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1933         Remove.
1934         * tui/tui-win.c (tui_source_window_base::set_new_height)
1935         (tui_source_window_base::set_new_height)
1936         (make_invisible_and_set_new_height)
1937         (tui_source_window_base::do_make_visible_with_new_height)
1938         (tui_source_window_base::do_make_visible_with_new_height):
1939         Update.
1940         * tui/tui-layout.c (show_source_disasm_command, show_data)
1941         (show_source_or_disasm_and_command): Update.
1942         * tui/tui-layout.c (show_layout): Update.
1943
1944 2019-07-17  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-layout.c (make_data_window): Remove.
1947         (show_data): Unify creation and re-initialization cases.
1948
1949 2019-07-17  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-layout.c (make_source_window, make_disasm_window):
1952         Remove.
1953         (show_data): Unify creation and re-initialization cases.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-layout.c (make_command_window): Remove.
1958         (show_source_disasm_command, show_source_or_disasm_and_command):
1959         Unify creation and re-initialization cases.
1960
1961 2019-07-17  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1964         creation and re-initialization cases.
1965
1966 2019-07-17  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-regs.c (tui_get_register): Return void.
1969
1970 2019-07-17  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1973         Simplify.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1978         resetting.
1979
1980 2019-07-17  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1983         * tui/tui-regs.c (tui_reg_layout): New function.
1984         (tui_show_registers, tui_reg_command): Use it.
1985         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1986         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1987         parameters.
1988         (tui_layout_command): Remove.
1989
1990 2019-07-17  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-layout.h (tui/tui-layout): Return void.
1993         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1994
1995 2019-07-17  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-layout.c (show_source_disasm_command, show_data):
1998         Update.
1999         (reset_locator): Remove.
2000         (show_source_or_disasm_and_command): Update.
2001
2002 2019-07-17  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-source.c (tui_source_window_base::reset): Remove
2005         win_type parameter.
2006         * tui/tui-layout.c (make_command_window, make_source_window)
2007         (make_disasm_window, make_data_window)
2008         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2009         (reset_locator, show_source_or_disasm_and_command): Update.
2010         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2011         win_type parameter.
2012         (struct tui_source_window_base) <reset>: Likewise.
2013
2014 2019-07-17  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-layout.c (show_source_disasm_command): Use
2017         reset_locator.
2018         (reset_locator): New function.
2019         (init_and_make_win): Remove.
2020         (show_source_or_disasm_and_command): Use reset_locator.
2021
2022 2019-07-17  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2025         condition.
2026         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2027         Remove condition.
2028         * tui/tui-source.c (tui_source_window_base::reset): New method.
2029         * tui/tui-layout.c (make_command_window): Don't call
2030         init_and_make_win.
2031         (make_source_window, make_disasm_window): Don't call
2032         make_source_or_disasm_window.
2033         (make_data_window): Don't call init_and_make_win.  Change calling
2034         convention.
2035         (show_source_disasm_command, show_data): Simplify.
2036         (make_source_or_disasm_window): Remove.
2037         (show_source_or_disasm_and_command): Simplify.
2038         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2039         (struct tui_source_window_base) <reset>: Likewise.
2040         <execution_info>: Remove initializer.
2041         * tui/tui-data.c (tui_source_window_base): Initialize
2042         execution_info.
2043
2044 2019-07-17  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2047         variable.
2048
2049 2019-07-17  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui.c (tui_rl_other_window): Update.
2052         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2053         superclass method first.  Always iterate over regs_content.
2054         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2055         method.
2056         * tui/tui-win.c (tui_set_focus_command): Update.
2057
2058 2019-07-17  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-win.c (tui_set_focus_command): Rename from
2061         tui_set_focus.  Call tui_enable.
2062         (tui_set_focus_command): Remove.
2063
2064 2019-07-17  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2067         refresh_window.
2068         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2069         touchwin.
2070         (tui_data_window::refresh_window): Call refresh_window on data
2071         items.  Always call superclass refresh_window.
2072         (tui_win_info::refresh): Remove.
2073         (tui_source_window_base::refresh_window): Update.
2074         (tui_refresh_all): Update.
2075         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2076         refresh_window.
2077         (show_source_or_disasm_and_command): Likewise.
2078         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2079         (struct tui_source_window_base) <refresh>: Likewise.
2080
2081 2019-07-17  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-winsource.c (tui_clear_source_content)
2084         (tui_show_source_content): Update.
2085         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2086         whether content is empty.
2087         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2088         Remove.
2089
2090 2019-07-17  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2093         window's contents.
2094         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2095         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2096
2097 2019-07-17  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2100         (struct tui_data_item_window): Update.
2101
2102 2019-07-17  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2105         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2106         defines.
2107
2108 2019-07-17  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-winsource.h (tui_erase_source_content)
2111         (tui_clear_source_content): Remove "display_prompt" parameter.
2112         * tui/tui-winsource.c (tui_update_source_window_as_is)
2113         (tui_update_source_windows_with_addr): Update.
2114         (tui_clear_source_content): Remove "display_prompt" parameter.
2115         (tui_erase_source_content): Likewise.  Simplify.
2116         (tui_show_source_content): Update.
2117         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2118         * tui/tui-stack.c (tui_show_frame_info): Update.
2119         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2120         Remove defines.
2121
2122 2019-07-17  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2125         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2126         parameter.
2127         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2128         parameter.
2129
2130 2019-07-17  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-winsource.c (tui_clear_source_content)
2133         (tui_show_source_content, tui_show_exec_info_content)
2134         (tui_clear_exec_info_content): Update.
2135         * tui/tui-stack.c (tui_show_locator_content): Update.
2136         (tui_show_frame_info): Update.
2137         * tui/tui-source.h (tui_source_window): Don't declare.
2138         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2139         from tui_source_is_displayed.
2140         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2141         Remove field.
2142         (struct tui_source_window_base) <content_in_use>: New field.  Now
2143         bool.
2144         (struct tui_source_window) <showing_source_p>: New method.
2145         (TUI_SRC_WIN): Change cast.
2146         * tui/tui-data.c (tui_initialize_static_data): Update.
2147
2148 2019-07-17  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2151         location_matches_p.
2152         * tui/tui-source.c (tui_source_window::location_matches_p): New
2153         method.
2154         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2155         method.
2156         * tui/tui-data.h (struct tui_source_window_base)
2157         <location_matches_p>: New method.
2158         (struct tui_source_window, struct tui_disasm_window)
2159         <location_matches_p>: Likewise.
2160
2161 2019-07-17  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-win.c (tui_set_win_height_command): Rename from
2164         tui_set_win_height.
2165         (tui_set_win_height_command): Remove.
2166
2167 2019-07-17  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-source.c (tui_source_window): New constructor.  Add
2170         observer.
2171         (~tui_source_window): New destructor.
2172         (tui_source_window::style_changed): New method.
2173         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2174         (tui_attach_detach_observers): Update.
2175         * tui/tui-data.h (struct tui_source_window): Make constructor not
2176         inline.  Add destructor.
2177         (struct tui_source_window) <style_changed>: New method.
2178         <m_observable>: New member.
2179
2180 2019-07-17  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2183         * tui/tui-win.c (tui_resize_all): Fix typo.
2184
2185 2019-07-17  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2188         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2189         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2190         * tui/tui-win.c (window_name_completer): Use foreach.
2191         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2192         (update_tab_width): Likewise.
2193         * tui/tui-layout.c (show_layout): Update.
2194         * tui/tui-data.h (class tui_window_iterator): New.
2195         (struct all_tui_windows): New.
2196         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2197
2198 2019-07-17  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2201         parameter.  Don't reference globals.
2202         (tui_reg_command): Update.
2203
2204 2019-07-17  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-regs.c (tui_show_registers): Simplify.
2207
2208 2019-07-17  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-regs.c (tui_show_registers): Update.
2211         (tui_show_register_group): Add win_info parameter.
2212
2213 2019-07-17  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2216         Rename from tui_display_reg_element_at_line.
2217         (tui_data_window::display_registers_from_line): Update.
2218         * tui/tui-data.h (struct tui_data_window)
2219         <display_reg_element_at_line>: New method.
2220
2221 2019-07-17  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-regs.h (tui_display_registers_from)
2224         (tui_display_registers_from_line): Don't declare.
2225         * tui/tui-windata.c (tui_data_window::display_all_data)
2226         (tui_data_window::refresh_all)
2227         (tui_data_window::do_scroll_vertical): Update.
2228         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2229         from tui_display_registers_from.
2230         (tui_display_reg_element_at_line): Update.
2231         (tui_data_window::display_registers_from_line): Rename from
2232         tui_display_registers_from_line.
2233         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2234         display_registers_from_line>: New methods.
2235
2236 2019-07-17  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2239         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2240         from tui_erase_data_content.
2241         (tui_data_window::display_all_data)
2242         (tui_data_window::refresh_all)
2243         (tui_data_window::do_scroll_vertical): Update.
2244         * tui/tui-regs.c (tui_show_registers): Update.
2245         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2246         New method.
2247
2248 2019-07-17  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2251         declare.
2252         * tui/tui-windata.c
2253         (tui_data_window::delete_data_content_windows): Rename from
2254         tui_delete_data_content_windows.
2255         (tui_data_window::display_all_data)
2256         (tui_data_window::do_scroll_vertical): Update.
2257         * tui/tui-data.h (struct tui_data_window)
2258         <delete_data_content_windows>: New method.
2259
2260 2019-07-17  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2263         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2264
2265 2019-07-17  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2268         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2269         from tui_display_all_data.
2270         * tui/tui-win.c
2271         (tui_data_window::do_make_visible_with_new_height): Update.
2272         * tui/tui-regs.c (tui_show_registers): Update.
2273         * tui/tui-layout.c (tui_set_layout): Update.
2274         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2275         method.
2276
2277 2019-07-17  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2280         * tui/tui-windata.c (tui_display_data_from): Remove.
2281         (tui_data_window::refresh_all): Update.
2282
2283 2019-07-17  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2286         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2287         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2288         tui_display_registers_from_line.
2289         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2290         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2291         "force_display" parameter.
2292
2293 2019-07-17  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2296         declare.
2297         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2298         Rename from tui_first_reg_element_no_inline.
2299         (tui_display_reg_element_at_line)
2300         (tui_display_registers_from_line): Update.
2301         * tui/tui-data.h (struct tui_data_window)
2302         <first_reg_element_no_inline>: New method.
2303
2304 2019-07-17  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-windata.c (tui_display_data_from)
2307         (tui_data_window::do_scroll_vertical): Update.
2308         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2309         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2310         Rename from tui_line_from_reg_element_no.
2311         (tui_display_registers_from_line): Update.
2312         * tui/tui-data.h (struct tui_data_window)
2313         <line_from_reg_element_no>: New method.
2314
2315 2019-07-17  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2318         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2319         tui_last_regs_line_no.
2320         (tui_display_reg_element_at_line)
2321         (tui_display_registers_from_line): Update.
2322         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2323         method.
2324
2325 2019-07-17  Tom Tromey  <tom@tromey.com>
2326
2327         PR tui/24722:
2328         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2329         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2330         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2331         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2332         (tui_update_breakpoint_info): Likewise.
2333         * tui/tui-hooks.c (tui_event_create_breakpoint)
2334         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2335         Update.
2336
2337 2019-07-17  Tom Tromey  <tom@tromey.com>
2338
2339         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2340
2341 2019-07-17  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-winsource.c (tui_update_source_window_as_is)
2344         (tui_update_source_windows_with_addr): Update.
2345         * tui/tui-source.h (tui_set_source_content)
2346         (tui_show_symtab_source): Add "win_info" parameter.
2347         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2348         parameter.
2349         (tui_show_symtab_source): Likewise.
2350
2351 2019-07-17  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-wingeneral.c
2354         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2355
2356 2019-07-17  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2359         (struct tui_cmd_window) <can_scroll>: New method.
2360         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2361         method.
2362
2363 2019-07-17  Tom Tromey  <tromey@adacore.com>
2364
2365         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2366         do_field_signed>: Rename.  Change type of "value".
2367         * ui-out.c (ui_out::field_signed): Rename from field_int.
2368         Change type of "value".
2369         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2370         type of "value".
2371         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2372         do_field_int.  Change type of "value".
2373         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2374         do_field_int.  Change type of "value".
2375         * tracepoint.c (trace_status_mi, tfind_1)
2376         (print_one_static_tracepoint_marker): Update.
2377         * thread.c (print_thread_info_1, print_selected_thread_frame):
2378         Update.
2379         * stack.c (print_frame, print_frame_info): Update.
2380         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2381         Update.
2382         * source.c (print_source_lines_base): Update.
2383         * skip.c (info_skip_command): Update.
2384         * record-btrace.c (btrace_ui_out_decode_error)
2385         (btrace_call_history_src_line): Update.
2386         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2387         Update.
2388         * progspace.c (print_program_space): Update.
2389         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2390         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2391         do_field_int.  Change type of "value".
2392         * mi/mi-out.c (mi_ui_out::do_table_begin)
2393         (mi_ui_out::do_table_header): Update.
2394         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2395         type of "value".
2396         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2397         (mi_cmd_data_list_changed_registers, output_register)
2398         (mi_cmd_data_read_memory, mi_load_progress)
2399         (mi_cmd_trace_frame_collected): Update.
2400         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2401         Update.
2402         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2403         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2404         (mi_cmd_var_list_children, varobj_update_one): Update.
2405         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2406         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2407         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2408         * inferior.c (print_inferior): Update.
2409         * gdb_bfd.c (print_one_bfd): Update.
2410         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2411         Update.
2412         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2413         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2414         do_field_int.  Change type of "value".
2415         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2416         do_field_int.  Change type of "value".
2417         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2418         (print_one_breakpoint_location, print_it_catch_fork)
2419         (print_one_catch_fork, print_it_catch_vfork)
2420         (print_one_catch_vfork, print_it_catch_solib)
2421         (print_it_catch_exec, print_it_ranged_breakpoint)
2422         (print_mention_watchpoint, print_mention_masked_watchpoint)
2423         (bkpt_print_it, update_static_tracepoint): Update.
2424         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2425         * break-catch-syscall.c (print_it_catch_syscall): Update.
2426         * ada-tasks.c (print_ada_task_info): Update.
2427         * ada-lang.c (print_it_exception, print_mention_exception):
2428         Update.
2429
2430 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         PR breakpoints/24541
2433         * gdbarch.c: Regenerate.
2434         * gdbarch.h: Regenerate.
2435         * gdbarch.sh: Adjust return type and parameter types for
2436         'stap_adjust_register'.
2437         (i386_stap_adjust_register): Adjust signature and return new
2438         register name.
2439         * stap-probe.c (stap_parse_register_operand): Adjust use of
2440         'gdbarch_stap_adjust_register'.
2441
2442 2019-07-17  Tom Tromey  <tromey@adacore.com>
2443
2444         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2445         declare VEC.
2446         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2447         std::vector.
2448         (struct s390_process_info): Add initializers.
2449         (s390_add_process): Use new.
2450         (s390_linux_nat_target::low_forget_process): Use delete.
2451         (s390_linux_nat_target::low_new_fork)
2452         (s390_linux_nat_target::stopped_by_watchpoint)
2453         (s390_linux_nat_target::low_prepare_to_resume)
2454         (s390_linux_nat_target::insert_watchpoint)
2455         (s390_linux_nat_target::insert_hw_breakpoint)
2456         (s390_linux_nat_target::remove_watchpoint)
2457         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2458
2459 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2460
2461         * aarch64-fbsd-nat.c: Include regcache.h.
2462         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2463         argument.
2464         (aarch64_fbsd_nat_target::fetch_registers)
2465         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2466         variable.
2467         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2468
2469 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2470
2471         * fbsd-nat.c: Include gdbarch.h.
2472
2473 2019-07-15  Tom Tromey  <tromey@adacore.com>
2474
2475         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2476
2477 2019-07-15  Tom Tromey  <tromey@adacore.com>
2478
2479         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2480         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2481         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2482         * cli-out.c (cli_ui_out::do_field_int): New method.
2483         * ui-out.c (ui_out::field_unsigned): New method.
2484         * symfile.c (generic_load): Use field_unsigned.
2485         (print_transfer_performance): Likewise.
2486         * record-btrace.c (ui_out_field_uint): Remove.
2487         (btrace_call_history_insn_range, btrace_call_history): Use
2488         field_unsigned.
2489         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2490         field_unsigned.
2491         * ui-out.h (class ui_out) <field_unsigned>: New method.
2492         <do_field_unsigned>: Likewise.
2493
2494 2019-07-15  Tom Tromey  <tromey@adacore.com>
2495
2496         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2497         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2498         * target.c (flash_erase_command): Use field_string.
2499         * infrun.c (print_signal_received_reason): Use field_string.
2500         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2501         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2502         field_string.
2503         * ada-tasks.c (print_ada_task_info): Use field_string.
2504
2505 2019-07-15  Tom Tromey  <tromey@adacore.com>
2506
2507         * target.c (flash_erase_command): Use field_core_addr.
2508         * symfile.c (generic_load): Use field_core_addr.
2509         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2510         Use field_core_addr.
2511         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2512         field_core_addr.
2513
2514 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2517         value if its desired type is smaller than a CORE_ADDR and signed.
2518
2519 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2522         of changes to field names, and use new is_reference field to
2523         decide if a property is a reference or not.
2524         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2525         field.
2526         (struct dwarf2_property_baton): Update header comment, rename
2527         'referenced_type' to 'property_type' and update comments.
2528         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2529         default property type, store in property baton, update to take
2530         accound of renamed field.
2531         (read_func_scope): Update call to attr_to_dynamic_prop.
2532         (read_array_type): Likewise.
2533         (dwarf2_per_cu_addr_sized_int_type): New function.
2534         (read_subrange_index_type): Move type finding code to
2535         dwarf2_per_cu_addr_sized_int_type.
2536         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2537         (dwarf2_per_cu_addr_type): New function.
2538         (set_die_type): Update calls to attr_to_dynamic_prop.
2539
2540 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2541
2542         * dwarf2read.c (read_subrange_index_type): New function.
2543         (read_subrange_type): Move code into new function and call it.
2544         * gdbtypes.c (create_range_type): Add some asserts.
2545
2546 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2549         update return statements.
2550         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2551         declaration, and update comment to match.
2552         * gdbtypes.c (resolve_dynamic_array): Update call to
2553         dwarf2_evaluate_property to match new return type.
2554
2555 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2556
2557         * valarith.c (value_subscripted_rvalue): Change lowerbound
2558         parameter type from int to LONGEST.
2559         * value.h (value_subscripted_rvalue): Likewise in declaration.
2560
2561 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * cli/cli-utils.c (info_print_command_completer): New function.
2564         * cli/cli-utils.h: Add 'completer.h' include, and forward
2565         declaration for 'struct cmd_list_element'.
2566         (info_print_command_completer): Declare.
2567         * stack.c (_initialize_stack): Add completer for 'info locals' and
2568         'info args'.
2569         * symtab.c (_initialize_symtab): Add completer for 'info
2570         variables' and 'info functions'.
2571         * NEWS: Mention completion for additional info commands.
2572
2573 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2574
2575         * cli/cli-utils.c (extract_info_print_args): Delete.
2576         (extract_arg_maybe_quoted): Delete.
2577         (info_print_options_defs): New variable.
2578         (make_info_print_options_def_group): New function.
2579         (extract_info_print_options): Define new function.
2580         * cli/cli-utils.h (extract_info_print_args): Delete.
2581         (struct info_print_options): New structure.
2582         (extract_info_print_options): Declare new function.
2583         * stack.c (info_locals_command): Update to use new
2584         extract_info_print_options, also add a header comment.
2585         (info_args_command): Likewise.
2586         * symtab.c (info_variables_command): Likewise.
2587         (info_functions_command): Likewise.
2588
2589 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2590
2591         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2592         to extract string arguments.
2593         * common/common-utils.c (extract_string_maybe_quoted): New function.
2594         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2595
2596 2019-07-11  Tom Tromey  <tromey@adacore.com>
2597
2598         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2599         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2600         * top.h (gdbinit): Don't declare.
2601         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2602         into...
2603         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2604         * top.c (gdb_init): Don't call init_cli_cmds.
2605         (gdbinit): Remove.
2606         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2607
2608 2019-07-11  Tom Tromey  <tromey@adacore.com>
2609
2610         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2611         after it has been moved.
2612
2613 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2614
2615         * valops.c (value_must_coerce_to_target): Change return type to
2616         bool.
2617         * value.h (value_must_coerce_to_target): Likewise.
2618
2619 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2620
2621         * breakpoint.c (is_hardware_watchpoint): Remove
2622         forward-declaration.
2623         (is_masked_watchpoint): Change return type to bool.
2624         (is_tracepoint): Likewise.
2625         (is_breakpoint): Likewise.
2626         (is_hardware_watchpoint): Likewise.
2627         (is_watchpoint): Likewise.
2628         (is_no_memory_software_watchpoint): Likewise.
2629         (is_catchpoint): Likewise.
2630         (breakpoint_1): Make FILTER parameter's return type bool.
2631         is_masked_watchpoint): Change return type to bool.
2632         (save_breakpoints): Make FILTER parameter's return type bool.
2633         * breakpoint.h (is_breakpoint): Change return type to bool.
2634         (is_watchpoint): Likewise.
2635         (is_catchpoint): Likewise.
2636         (is_tracepoint): Likewise.
2637
2638 2019-07-10  Tom Tromey  <tom@tromey.com>
2639
2640         * defs.h: Don't include gdbarch.h.
2641         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2642         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2643         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2644         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2645         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2646         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2647         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2648         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2649         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2650         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2651         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2652         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2653         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2654         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2655         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2656         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2657         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2658         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2659         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2660         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2661         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2662         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2663         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2664         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2665         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2666         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2667         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2668
2669 2019-07-10  Tom Tromey  <tromey@adacore.com>
2670
2671         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2672         * breakpoint.c (init_ada_exception_breakpoint): Register as
2673         bp_catchpoint.
2674         (print_one_breakpoint_location, print_one_breakpoint): Use
2675         is_ada_exception_catchpoint.
2676         * ada-lang.c (class ada_catchpoint_location): Pass
2677         bp_loc_software_breakpoint to bp_location constructor.
2678         (is_ada_exception_catchpoint): New function.
2679
2680 2019-07-10  Tom Tromey  <tromey@adacore.com>
2681
2682         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2683         VEC.
2684         (struct arm_exidx_entry): New method operator<.
2685         (struct arm_exidx_data) <section_maps>: Change type.
2686         (arm_exidx_data_free): Remove.
2687         (arm_exidx_data_key): Change type.  Move lower.
2688         (arm_exidx_new_objfile): Update.
2689         (arm_compare_exidx_entries): Remove.
2690         (arm_find_exidx_entry, _initialize_arm_tdep)
2691
2692 2019-07-10  Tom Tromey  <tromey@adacore.com>
2693
2694         * solib-spu.c (ocl_program_data_key): Change type.
2695         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2696         Update.
2697
2698 2019-07-10  Tom Tromey  <tromey@adacore.com>
2699
2700         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2701         (struct solib_aix_inferior_data) <library_list>: Change type.
2702         (solib_aix_inferior_data_handle): Change type.
2703         (get_solib_aix_inferior_data): Update.
2704         (solib_aix_free_library_list): Remove.
2705         (library_list_start_library): Update.
2706         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2707         return type.
2708         (solib_aix_get_library_list)
2709         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2710         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2711
2712 2019-07-10  Tom Tromey  <tromey@adacore.com>
2713
2714         * solib-dsbt.c (struct dsbt_info): Add initializers.
2715         (solib_dsbt_pspace_data): Change type.
2716         (dsbt_pspace_data_cleanup): Remove.
2717         (get_dsbt_info, _initialize_dsbt_solib): Update.
2718
2719 2019-07-10  Tom Tromey  <tromey@adacore.com>
2720
2721         * spu-tdep.c (spu_overlay_data): Change type.
2722         (spu_get_overlay_table, spu_overlay_new_objfile)
2723         (_initialize_spu_tdep): Update.
2724
2725 2019-07-10  Tom Tromey  <tromey@adacore.com>
2726
2727         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2728         destructor.
2729         (dbx_objfile_data_key): Change type and declare later.
2730         (DBX_SYMFILE_INFO): Rewrite.
2731         * dbxread.c (dbx_objfile_data_key): Change type.
2732         (dbx_symfile_init): Update.
2733         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2734         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2735         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2736
2737 2019-07-10  Tom Tromey  <tromey@adacore.com>
2738
2739         * jit.c (jit_program_space_key): Change type.  Move lower.
2740         (get_jit_program_space_data): Update.
2741         (jit_program_space_data_cleanup): Remove.
2742         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2743         Update.
2744         (struct jit_program_space_data): Add initializers.
2745
2746 2019-07-10  Tom Tromey  <tromey@adacore.com>
2747
2748         * solib-darwin.c (struct darwin_info): Add initializers.
2749         (solib_darwin_pspace_data): Change type.
2750         (darwin_pspace_data_cleanup): Remove.
2751         (get_darwin_info, _initialize_darwin_solib): Update.
2752
2753 2019-07-10  Tom Tromey  <tromey@adacore.com>
2754
2755         * remote-sim.c (struct sim_inferior_data): Add initializers,
2756         constructor, and destructor.
2757         (sim_inferior_data_key): Change type.  Move lower.
2758         (check_for_duplicate_sim_descriptor): Update.
2759         (get_sim_inferior_data): Use new.  Update.
2760         (~sim_inferior_data_cleanup): Rename from
2761         sim_inferior_data_cleanup.  Simplify.
2762         (gdbsim_close_inferior, simulator_command)
2763         (sim_command_completer, _initialize_remote_sim): Update.
2764         (next_pid, INITIAL_PID): Move earlier.
2765
2766 2019-07-10  Tom Tromey  <tromey@adacore.com>
2767
2768         * python/python-internal.h (create_thread_object): Return
2769         gdbpy_ref.
2770         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2771         * python/py-inferior.c (struct threadlist_entry): Add
2772         constructor.
2773         <thread_obj>: Now a gdbpy_ref.
2774         (thread_to_thread_object): Update.
2775         (add_thread_object): Use new.
2776         (delete_thread_object): Use delete.
2777         (infpy_threads): Update.
2778         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2779         GIL.
2780
2781 2019-07-10  Tom Tromey  <tromey@adacore.com>
2782
2783         * valops.c (value_cast): Specialize error message for Ada.
2784
2785 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2786
2787         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2788
2789 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2790
2791         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2792         bpstat_should_step): Return bool, adjust comments.
2793         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2794         bpstat_should_step): Likewise.
2795
2796 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2797
2798         * features/Makefile: Use feature target descriptions for Arm.
2799         * features/arm/arm-core.c: Generate new file.
2800         * features/arm/arm-fpa.c: Likewise.
2801         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2802         * features/arm/arm-m-profile.c: Likewise.
2803         * features/arm/arm-vfpv2.c: Likewise.
2804         * features/arm/arm-vfpv3.c: Likewise.
2805         * features/arm/xscale-iwmmxt.c: Likewise.
2806         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2807
2808 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2809
2810         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2811         ptrace earlier.
2812
2813 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2814
2815         * features/aarch64-pauth.c: Regenerate.
2816
2817 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2818
2819         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2820         bool.
2821         (bpstat_what): Use false instead of 0.
2822
2823 2019-07-09  Pedro Alves  <palves@redhat.com>
2824
2825         * break-catch-throw.c (is_exception_catchpoint): New.
2826         * breakpoint.c (print_one_breakpoint_location): New parameter
2827         'raw_loc'.  Handle it.  Use
2828         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2829         looking at the breakpoint's type.
2830         (print_one_breakpoint): If handling "maint info breakpoints", also
2831         print locations of exception catchpoints.
2832         * breakpoint.h (is_exception_catchpoint): Declare.
2833
2834 2019-07-09  Pedro Alves  <palves@redhat.com>
2835
2836         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2837         "addr" field.
2838         (allocate_location_exception_catchpoint): New.
2839         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2840         (initialize_throw_catchpoint_ops): Install
2841         allocate_location_exception_catchpoint as allocate_location
2842         method.
2843         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2844         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2845         bp_loc_other.
2846         (breakpoint_address_is_meaningful): Delete.
2847         (bl_address_is_meaningful): New.
2848         (breakpoint_locations_match): Adjust comment.
2849         (bp_location_from_bp_type): New, factored out of...
2850         (bp_location::bp_location(breakpoint *)): ... this.
2851         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2852         factored out of...
2853         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2854         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2855         breakpoint_address_is_meaningful.
2856         (bp_locations_compare): Adjust comment.
2857         (update_global_location_list): Use bl_address_is_meaningful
2858         instead of breakpoint_address_is_meaningful.
2859         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2860         explicit.
2861         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2862         * python/py-breakpoint.c (bppy_get_location): No longer check
2863         whether location is null.
2864
2865 2019-07-09  Pedro Alves  <palves@redhat.com>
2866
2867         PR c++/15468
2868         * breakpoint.c (print_one_breakpoint_location): Remove
2869         single-location assert.
2870
2871 2019-07-09  Tom Tromey  <tom@tromey.com>
2872
2873         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2874         * configure: Rebuild.
2875         * configure.ac: Change common to gdbsupport.
2876         * gdbsupport: Rename from common.
2877         * acinclude.m4: Change common to gdbsupport.
2878         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2879         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2880         gdbsupport.
2881         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2882         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2883         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2884         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2885         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2886         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2887         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2888         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2889         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2890         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2891         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2892         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2893         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2894         coff-pe-read.c, command.h, compile/compile-c-support.c,
2895         compile/compile-c.h, compile/compile-cplus-symbols.c,
2896         compile/compile-cplus-types.c, compile/compile-cplus.h,
2897         compile/compile-loc2c.c, compile/compile.c, completer.c,
2898         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2899         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2900         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2901         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2902         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2903         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2904         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2905         features/aarch64-core.c, features/aarch64-fpu.c,
2906         features/aarch64-pauth.c, features/aarch64-sve.c,
2907         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2908         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2909         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2910         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2911         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2912         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2913         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2914         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2915         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2916         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2917         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2918         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2919         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2920         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2921         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2922         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2923         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2924         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2925         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2926         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2927         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2928         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2929         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2930         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2931         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2932         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2933         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2934         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2935         minsyms.c, mips-linux-tdep.c, namespace.h,
2936         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2937         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2938         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2939         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2940         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2941         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2942         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2943         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2944         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2945         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2946         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2947         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2948         procfs.c, producer.c, progspace.h, psymtab.h,
2949         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2950         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2951         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2952         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2953         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2954         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2955         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2956         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2957         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2958         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2959         target-memory.c, target.c, target.h, target/waitstatus.c,
2960         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2961         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2962         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2963         unittests/array-view-selftests.c,
2964         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2965         unittests/common-utils-selftests.c,
2966         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2967         unittests/format_pieces-selftests.c,
2968         unittests/function-view-selftests.c,
2969         unittests/lookup_name_info-selftests.c,
2970         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2971         unittests/mkdir-recursive-selftests.c,
2972         unittests/observable-selftests.c,
2973         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2974         unittests/parse-connection-spec-selftests.c,
2975         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2976         unittests/scoped_fd-selftests.c,
2977         unittests/scoped_mmap-selftests.c,
2978         unittests/scoped_restore-selftests.c,
2979         unittests/string_view-selftests.c, unittests/style-selftests.c,
2980         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2981         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2982         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2983         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2984         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2985         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2986
2987 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2990         bool value.
2991         (decode_digits_ordinary): Set explicit_line field in sal.
2992         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2993         symtab_and_line that was set on an explicit line number in
2994         assembler code.  Do always update the recorded symtab and line if
2995         we do skip the prologue.
2996
2997 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * breakpoint.c (set_breakpoint_location_function): Remove
3000         explicit_loc parameter.
3001         (momentary_breakpoint_from_master): Update call to
3002         set_breakpoint_location_function.
3003         (add_location_to_breakpoint): Likewise.
3004
3005 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3008         required features based on default bfd type when no specific bfd
3009         is present.
3010
3011 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3012
3013         * NEWS: Mention that GDB printf and eval commands can now print
3014         C-style and Ada-style convenience var strings without
3015         calling the inferior.
3016         * printcmd.c (printf_c_string): Locally print GDB internal var
3017         instead of transiting via the inferior.
3018         (printf_wide_c_string): Likewise.
3019
3020 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3021
3022         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3023
3024 2019-07-04  Tom Tromey  <tom@tromey.com>
3025
3026         PR tui/24724:
3027         * tui/tui-winsource.c (tui_clear_source_content): Update.
3028         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3029         (tui_update_breakpoint_info): Update.
3030         (tui_set_exec_info_content): Update.
3031         * tui/tui-source.c (tui_set_source_content_nil): Update.
3032         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3033         has_break.
3034         * tui/tui-data.h (enum tui_bp_flag): New.
3035         (tui_bp_flags): New enum flags type.
3036         (struct tui_source_element) <break_mode>: Change type.  Rename
3037         from has_break.
3038         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3039         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3040         constants.
3041         * tui/tui-winsource.h: Fix comment.
3042
3043 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3044
3045         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3046         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3047         (store_fpregs_to_thread)
3048         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3049         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3050         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3051         (IWMMXT_REGS_SIZE): Add define.
3052         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3053         (fetch_vfp_regs, store_vfp_regs)
3054         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3055         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3056
3057 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3058
3059         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3060         defines.
3061         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3062         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3063         (ARM_INT_REGISTER_SIZE): ...to this.
3064         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3065         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3066         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3067         (arm_linux_collect_gregset, supply_nwfpe_register)
3068         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3069         defines.
3070         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3071         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3072         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3073         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3074         (arm_return_in_memory, arm_store_return_value)
3075         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3076         (arm_record_ld_st_multiple): Likewise.
3077         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3078         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3079
3080 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3081
3082         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3083         AARCH64_DISPLACED_MODIFIED_INSNS.
3084         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3085         (aarch64_displaced_step_copy_insn): Likewise.
3086         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3087         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3088         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3089         ARM_DISPLACED_MODIFIED_INSNS.
3090         * arm-tdep.c (arm_gdbarch_init): Likewise.
3091         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3092         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3093         (struct arm_displaced_step_closure): Use
3094         ARM_DISPLACED_MODIFIED_INSNS.
3095
3096 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3097
3098         * features/Makefile: Remove unused xml files.
3099         * features/aarch64.xml: Remove.
3100         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3101         * features/i386/amd64-avx-avx512.xml: Remove.
3102         * features/i386/amd64-avx-linux.xml: Remove.
3103         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3104         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3105         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3106         * features/i386/amd64-avx-mpx.xml: Remove.
3107         * features/i386/amd64-avx.xml: Remove.
3108         * features/i386/amd64-linux.xml: Remove.
3109         * features/i386/amd64-mpx-linux.xml: Remove.
3110         * features/i386/amd64-mpx.xml: Remove.
3111         * features/i386/amd64.xml: Remove.
3112         * features/i386/i386-avx-avx512-linux.xml: Remove.
3113         * features/i386/i386-avx-avx512.xml: Remove.
3114         * features/i386/i386-avx-linux.xml: Remove.
3115         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3116         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3117         * features/i386/i386-avx-mpx-linux.xml: Remove.
3118         * features/i386/i386-avx-mpx.xml: Remove.
3119         * features/i386/i386-avx.xml: Remove.
3120         * features/i386/i386-linux.xml: Remove.
3121         * features/i386/i386-mmx-linux.xml: Remove.
3122         * features/i386/i386-mmx.xml: Remove.
3123         * features/i386/i386-mpx-linux.xml: Remove.
3124         * features/i386/i386-mpx.xml: Remove.
3125         * features/i386/i386.xml: Remove.
3126         * features/i386/x32-avx-avx512-linux.xml: Remove.
3127         * features/i386/x32-avx-linux.xml: Remove.
3128         * features/i386/x32-linux.xml: Remove.
3129
3130 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3131
3132         * regformats/aarch64.dat: Remove.
3133         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3134         * regformats/i386/amd64-avx-linux.dat: Remove.
3135         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3136         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3137         * regformats/i386/amd64-linux.dat: Remove.
3138         * regformats/i386/amd64-mpx-linux.dat: Remove.
3139         * regformats/i386/amd64.dat: Remove.
3140         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3141         * regformats/i386/i386-avx-linux.dat: Remove.
3142         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3143         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3144         * regformats/i386/i386-linux.dat: Remove.
3145         * regformats/i386/i386-mmx-linux.dat: Remove.
3146         * regformats/i386/i386-mpx-linux.dat: Remove.
3147         * regformats/i386/i386.dat: Remove.
3148         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3149         * regformats/i386/x32-avx-linux.dat: Remove.
3150         * regformats/i386/x32-linux.dat: Remove.
3151
3152 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3153
3154         * aarch64-tdep.c: Remove xml self tests.
3155         * amd64-linux-tdep.c: Likewise.
3156         * amd64-tdep.c: Likewise.
3157         * i386-linux-tdep.c: Likewise.
3158         * i386-tdep.c: Likewise.
3159
3160 2019-07-03  Pedro Alves  <palves@redhat.com>
3161
3162         PR cli/24732
3163         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3164         (pipe_cmd_option_defs): New.
3165         (make_pipe_cmd_options_def_group): New.
3166         (pipe_command): Use gdb::option::process_options.
3167         (pipe_command_completer): New function.
3168         (_initialize_cli_cmds): Install completer for "pipe" command.
3169
3170 2019-07-03  Pedro Alves  <palves@redhat.com>
3171
3172         * cli/cli-option.c (union option_value) <string>: New field.
3173         (struct option_def_and_value): Add ctor, move ctor, dtor and
3174         use DISABLE_COPY_AND_ASSIGN.
3175         (option_def_and_value::clear_value): New.
3176         (parse_option, save_option_value_in_ctx, get_val_type_str)
3177         (add_setshow_cmds_for_options): Handle var_string.
3178         * cli-option.h (union option_def::var_address) <string>: New
3179         field.
3180         (struct string_option_def): New.
3181         * maint-test-options.c (struct test_options_opts): Add default
3182         ctor and use DISABLE_COPY_AND_ASSIGN.
3183         <string_opt>: New field.
3184         (test_options_opts::~test_options_opts): New.
3185         (test_options_opts::dump): Also dump "-string".
3186         (test_options_option_defs): Install "string.
3187
3188 2019-07-03  Pedro Alves  <palves@redhat.com>
3189
3190         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3191         option_value with a null enumeration.
3192         (complete_options): Save the option values in the context.
3193         (save_option_value_in_ctx): New, factored out from ...
3194         (process_options): ... here.
3195         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3196         of the function.
3197         * maint-test-options.c (test_options_opts::dump): New, factored
3198         out from ...
3199         (maintenance_test_options_command_mode): ... here.
3200         (maintenance_test_options_command_completion_result): Delete.
3201         (maintenance_test_options_command_completion_text): Update
3202         comment.
3203         (maintenance_show_test_options_completion_result): Change
3204         prototype.  Just print
3205         maintenance_test_options_command_completion_text.
3206         (save_completion_result): New.
3207         (maintenance_test_options_completer_mode): Pass options context to
3208         complete_options, and then save a dump.
3209         (_initialize_maint_test_options): Use add_cmd to install "maint
3210         show test-options-completion-result".
3211
3212 2019-07-03  Pedro Alves  <palves@redhat.com>
3213
3214         * NEWS (New commands): Mention "with" and "maint with".
3215         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3216         (with_command, with_command_completer): New.
3217         (pipe_command): Adjust to new repeat_previous
3218         interface.
3219         (_initialize_cli_cmds): Install the "with" command and its "w"
3220         alias.
3221         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3222         declarations.
3223         * cli/cli-setshow.c (parse_cli_var_uinteger)
3224         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3225         argument strings for all var_types.
3226         (get_setshow_command_value_string): New, factored out from ...
3227         (do_show_command): ... this.
3228         * cli/cli-setshow.h: Include <string>.
3229         (get_setshow_command_value_string): Declare.
3230         * command.h (repeat_previous): Now returns const char *.  Adjust
3231         comment.
3232         * maint.c: Include "cli/cli-cmds.h".
3233         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3234         (_initialize_maint_cmds): Register the "maintenance with" command.
3235         * top.c (repeat_previous): Move bits from pipe_command here:
3236         Return the saved command line, if any; error out if there's no
3237         command to relaunch.
3238
3239 2019-07-03  Pedro Alves  <palves@redhat.com>
3240
3241         * NEWS (New commands): Mention "maint set/show test-settings"
3242         instead of "maint test-settings".
3243         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3244         (maintenance_test_settings_set_list): Rename to ...
3245         (maintenance_set_test_settings_list): ... this.
3246         (maintenance_test_settings_show_list): Rename to  ...
3247         (maintenance_show_test_settings_list): ... this.
3248         (maintenance_test_settings_cmd): Delete.
3249         (maintenance_test_settings_set_cmd): ...
3250         (maintenance_set_test_settings_cmd): ... this.
3251         (maintenance_test_settings_show_cmd): ...
3252         (maintenance_show_test_settings_cmd): ... this.
3253         (maintenance_test_settings_show_value_cmd):
3254         (maintenance_show_test_settings_value_cmd): ... this.
3255         (_initialize_maint_test_settings): No longer install the "maint
3256         test-settings" prefix command.  Rename "maint test-settings set"
3257         to "maint set test-settings", and "maint test-settings show" to
3258         "maint show test-settings".  Adjust all subcommands.
3259
3260 2019-07-03  Pedro Alves  <palves@redhat.com>
3261
3262         * maint-test-settings.c: Fix file's intro comment.  Replace all
3263         references to "test-options" with references to "test-settings",
3264         in comments.
3265
3266 2019-07-03  Pedro Alves  <palves@redhat.com>
3267
3268         * maint-test-settings.c (maintenance_test_settings_xxx)
3269         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3270         New.
3271         (maintenance_test_settings_enums): Use them.
3272         (maintenance_test_settings_enum): Default to
3273         maintenance_test_settings_xxx.
3274         (_initialize_maint_test_settings): Initialize
3275         MAINTENANCE_TEST_SETTINGS_FILENAME.
3276
3277 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3278
3279         * breakpoint.h (remove_breakpoints_inf): Change return type to
3280         void, move function documentation here.
3281         * breakpoint.c (remove_breakpoints_inf): Change return type to
3282         void, move function documentation to header.
3283
3284 2019-07-02  Pedro Alves  <palves@redhat.com>
3285
3286         * NEWS (Completion improvements): Mention "info threads".
3287         * thread.c (struct info_threads_opts, info_threads_option_defs)
3288         (make_info_threads_options_def_group): New.
3289         (info_threads_command): Use gdb::option::process_options.
3290         (info_threads_command_completer): New.
3291         (_initialize_thread): Use gdb::option::build_help to build the
3292         help text for "info threads".
3293
3294 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3295
3296         * defs.h (generic_load): Move from here...
3297         * symfile.h (generic_load): ... to here.  Rename name parameter
3298         to args.
3299         * symfile.c (generic_load): Add comment.
3300
3301 2019-07-01  Tom Tromey  <tromey@adacore.com>
3302
3303         * dwarf2read.c
3304         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3305         declaration of without_params.  Fix formatting.
3306
3307 2019-07-01  Tom Tromey  <tromey@adacore.com>
3308
3309         * ada-exp.y (find_primitive_type): Update.
3310         * ada-lang.h (ada_lookup_symbol): Update.
3311         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3312         parameter.
3313         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3314
3315 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3316
3317         PR breakpoints/24541
3318         * gdbarch.c: Regenerate.
3319         * gdbarch.h: Regenerate.
3320         * gdbarch.sh: Add 'stap_adjust_register'.
3321         * i386-tdep.c: Include '<unordered_set>'.
3322         (i386_stap_adjust_register): New function.
3323         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3324         * stap-probe.c (stap_parse_register_operand): Call
3325         'gdbarch_stap_adjust_register'.
3326
3327 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3328
3329         PR python/24742
3330         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3331         * python/python.c (do_start_initialization): Use 'xmalloc'
3332         instead of 'PyMem_Malloc'.
3333
3334 2019-06-28  Tom Tromey  <tromey@adacore.com>
3335
3336         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3337         for Ada.
3338
3339 2019-06-27  Tom Tromey  <tromey@adacore.com>
3340
3341         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3342         objfile_key.
3343         (arm_find_mapping_symbol, arm_record_special_symbol)
3344         (_initialize_arm_tdep): Update.
3345         (arm_objfile_data_free): Remove.
3346
3347 2019-06-27  Tom Tromey  <tromey@adacore.com>
3348
3349         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3350         to cp_print_static_field.
3351
3352 2019-06-26  Tom Tromey  <tromey@adacore.com>
3353
3354         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3355         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3356         declare.
3357
3358 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3359
3360         * features/aarch64-core.c (create_feature_aarch64_core):
3361         Regenerate.
3362         * features/aarch64-core.xml: Add cpsr flags.
3363
3364 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3365
3366         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3367         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3368
3369 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3370
3371         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3372         field.
3373         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3374         use.
3375         (arm_record_special_symbol): Don't insert new symbol in sorted
3376         position, push it at the end.
3377
3378 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3379
3380         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3381         (arm_mapping_symbol_s): Remove.
3382         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3383         (arm_mapping_symbol_vec): New typedef.
3384         (struct arm_per_objfile): Add constructor.
3385         <section_maps>: Change type to
3386         std::unique_ptr<arm_mapping_symbol_vec[]>.
3387         (arm_compare_mapping_symbols): Remove.
3388         (arm_find_mapping_symbol): Adjust to section_maps type change.
3389         (arm_objfile_data_free): Call delete on arm_per_objfile.
3390         (arm_record_special_symbol): Adjust to section_maps type change.
3391         Allocate arm_per_objfile with new.
3392
3393 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3394
3395         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3396         with the command prefix.
3397
3398 2019-06-25  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3401         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3402
3403 2019-06-25  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3406         type.
3407         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3408         protected.
3409
3410 2019-06-25  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-winsource.c
3413         (tui_source_window_base::set_is_exec_point_at): Add check against
3414         LOA_ADDRESS.
3415
3416 2019-06-25  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-source.c (tui_set_source_content): Don't check before
3419         xfree.
3420         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3421
3422 2019-06-25  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-winsource.h (tui_update_source_window_as_is)
3425         (tui_alloc_source_buffer, tui_line_is_displayed)
3426         (tui_addr_is_displayed): Change type of win_info.
3427         * tui/tui-winsource.c (tui_update_source_window_as_is)
3428         (tui_clear_source_content, tui_show_source_line)
3429         (tui_show_source_content, tui_source_window_base::refill)
3430         (tui_source_window_base::set_is_exec_point_at)
3431         (tui_source_window_base::set_is_exec_point_at)
3432         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3433         (tui_alloc_source_buffer, tui_line_is_displayed)
3434         (tui_addr_is_displayed): Change type of win_info.  Update.
3435         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3436         (tui_source_window_base::do_make_visible_with_new_height):
3437         Update.
3438         * tui/tui-source.c (tui_set_source_content)
3439         (tui_set_source_content_nil)
3440         (tui_source_window::do_scroll_vertical): Update.
3441         * tui/tui-layout.c (show_layout): Update.
3442         * tui/tui-disasm.c (tui_set_disassem_content)
3443         (tui_disasm_window::do_scroll_vertical): Update.
3444         * tui/tui-data.h (tui_win_content): Remove.
3445         (struct tui_gen_win_info) <content, content_size>: Remove.
3446         (struct tui_source_element): Add initializers and destructor.
3447         (union tui_which_element, struct tui_win_element): Remove.
3448         (struct tui_source_window_base) <content>: New field.
3449         (struct tui_data_window): Remove destructor.
3450         (tui_alloc_content, tui_free_win_content)
3451         (tui_free_all_source_wins_content): Don't declare.
3452         * tui/tui-data.c (tui_initialize_static_data): Update.
3453         (init_content_element, tui_alloc_content): Remove.
3454         (~tui_gen_win_info): Update.
3455         (~tui_data_window, tui_free_all_source_wins_content)
3456         (tui_free_win_content, free_content, free_content_elements):
3457         Remove.
3458
3459 2019-06-25  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-winsource.h (tui_clear_source_content)
3462         (tui_erase_source_content, tui_show_source_content): Change type
3463         of win_info.
3464         * tui/tui-winsource.c (tui_clear_source_content)
3465         (tui_erase_source_content, tui_show_source_content): Change type
3466         of win_info.
3467         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3468         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3469         win_info.
3470         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3471         win_info.
3472         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-winsource.c (tui_clear_source_content)
3477         (tui_source_window_base::set_is_exec_point_at): Update.
3478         * tui/tui-source.c (tui_set_source_content_nil): Update.
3479         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3480         a bool.
3481         * tui/tui-data.c (init_content_element): Update.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3486         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3487         * tui/tui-layout.c (init_and_make_win): Update.
3488         * tui/tui.h (enum tui_win_type): Update.
3489         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3490         tui_win_is_auxillary.
3491         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3492         tui_win_is_auxillary.
3493
3494 2019-06-25  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3497         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3498         (tui_delete_data_content_windows, tui_display_all_data)
3499         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3500         Update.
3501         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3502         * tui/tui-regs.c (tui_last_regs_line_no)
3503         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3504         (tui_show_registers): Update.
3505         (tui_show_register_group): Return void.  Update.
3506         (tui_display_registers_from, tui_display_reg_element_at_line)
3507         (tui_display_registers_from_line, tui_check_register_values):
3508         Update.
3509         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3510         member.
3511         (struct tui_data_window) <regs_content>: Now a std::vector.
3512         <regs_content_count>: Remove.
3513         (tui_add_content_elements, tui_free_data_content): Don't declare.
3514         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3515         (init_content_element): Remove DATA_WIN case.  Add assert.
3516         (tui_add_content_elements): Remove.
3517         (tui_data_window): Update.
3518         (tui_free_data_content): Remove.
3519         (free_content_elements): Remove DATA_WIN case.
3520
3521 2019-06-25  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-data.c (tui_data_item_window): Update.
3524         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3525         * tui/tui-windata.c (tui_display_all_data)
3526         (tui_display_data_from_line): Update.
3527         (tui_check_data_values): Remove.
3528         * tui/tui-regs.c (tui_show_register_group)
3529         (tui_display_reg_element_at_line): Update.
3530         * tui/tui-hooks.c (tui_register_changed)
3531         (tui_refresh_frame_and_register_information): Call
3532         tui_check_register_values.
3533         * tui/tui-data.h (struct tui_data_window) <data_content,
3534         data_content_count, data_type>: Remove.
3535         (enum tui_data_type): Remove.
3536
3537         * tui/tui-data.c (tui_data_window::clear_detail)
3538         (~tui_data_window): Update.
3539
3540 2019-06-25  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3543         declare.
3544         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3545         Rename from tui_first_data_item_displayed.  Update.
3546         (tui_data_window::refresh_all)
3547         (tui_data_window::do_scroll_vertical): Update.
3548         * tui/tui-data.h (struct tui_data_window)
3549         <first_data_item_displayed>: Declare new method.
3550
3551 2019-06-25  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3554         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3555         contents...
3556         (tui_initialize_static_data): ...here.
3557
3558 2019-06-25  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3561         (tui_display_registers_from, tui_check_register_values): Update.
3562         (tui_display_register): Remove win_info parameter; update.
3563         (tui_get_register): Change type of parameters.
3564         * tui/tui-data.h (struct tui_data_element): Remove.
3565         (union tui_which_element) <data>: Remove.
3566         <data_window>: Change type.
3567         (struct tui_data_item_window): New.
3568         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3569         case.  Add assert.
3570         (~tui_data_item_window): New destructor.
3571         (free_content_elements): Remove DATA_ITEM_WIN case.
3572
3573 2019-06-25  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3576         Remove.
3577
3578 2019-06-25  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-data.h (struct tui_command_element): Remove.
3581         (union tui_which_element) <command>: Remove.
3582         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3583         assert.
3584         (free_content_elements): Remove CMD_WIN case.
3585
3586 2019-06-25  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-layout.c (tui_set_layout): Update.
3589         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3590         * tui/tui-data.c (layout_def): Update.
3591
3592 2019-06-25  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3595         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3596         (tui_source_window_base::set_new_height): Update.
3597         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3598         Update.
3599         (tui_set_locator_fullname, tui_set_locator_info)
3600         (tui_show_frame_info): Update.
3601         * tui/tui-source.c (tui_set_source_content)
3602         (tui_source_is_displayed): Update.
3603         * tui/tui-layout.c (show_source_disasm_command, show_data)
3604         (show_source_or_disasm_and_command): Update.
3605         * tui/tui-disasm.c (tui_set_disassem_content)
3606         (tui_get_begin_asm_address): Update.
3607         * tui/tui-data.h (struct tui_locator_element): Remove.
3608         (union tui_which_element) <locator>: Remove.
3609         (struct tui_locator_window): New.
3610         (tui_locator_win_info_ptr): Change return type.
3611         * tui/tui-data.c (_locator): Change type.
3612         (tui_locator_win_info_ptr): Change return type.
3613         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3614         (tui_alloc_content): Add assert.
3615
3616 2019-06-25  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-winsource.c
3619         (tui_exec_info_window::maybe_allocate_content): New method.
3620         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3621         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3622         (make_source_or_disasm_window): Add cast.
3623         * tui/tui-data.h (union tui_which_element) <simple_string>:
3624         Remove.
3625         (struct tui_source_info): New.
3626         (struct tui_source_window_base) <execution_info>: Change type.
3627         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3628         case, and add assert.
3629         (tui_alloc_content): Add assert.
3630
3631 2019-06-25  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3634         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3635         * tui/tui-data.c (tui_alloc_win_info): Remove.
3636
3637 2019-06-25  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3640         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3641         can_highlight.
3642
3643 2019-06-25  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3646         make_visible_with_new_height method.
3647         (tui_win_info::make_visible_with_new_height): New method.
3648         (tui_source_window_base::do_make_visible_with_new_height)
3649         (tui_data_window::do_make_visible_with_new_height)
3650         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3651         (make_visible_with_new_height): Remove.
3652         (tui_resize_all, tui_adjust_win_heights): Use
3653         make_visible_with_new_height method.
3654         * tui/tui-data.h (struct tui_win_info)
3655         <do_make_visible_with_new_height, make_visible_with_new_height>:
3656         New methods.
3657         (struct tui_source_window_base, struct tui_data_window)
3658         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3659         methods.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3664         method.
3665         (update_tab_width): Call update_tab_width method.
3666         * tui/tui-data.h (struct tui_win_info)
3667         (struct tui_source_window_base) <update_tab_width>: New methods.
3668
3669 2019-06-25  Tom Tromey  <tom@tromey.com>
3670
3671         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3672         parameter.
3673         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3674         parameter.
3675         (tui_gen_win_info::make_visible): Update.
3676         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3677         parameter.
3678         * tui/tui-data.h (enum tui_box): New enum.
3679         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3680
3681 2019-06-25  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3684         init_and_make_win for EXEC_INFO_WIN.
3685         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3686         longer inline.
3687         (struct tui_win_info) <~tui_win_info>: Inline.
3688         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3689         Don't declare.
3690         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3691         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3692         Remove.
3693         (tui_initialize_static_data): Update.
3694         (~tui_gen_win_info): Handle more cleanup here.
3695         (~tui_source_window_base): Delete "execution_info".
3696         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3697
3698 2019-06-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-layout.c (make_command_window): Don't set
3701         can_highlight.
3702         (show_source_disasm_command): Call the reset method.
3703         (show_data): Don't set can_highlight.  Call the reset method.
3704         (tui_gen_win_info::reset): Rename from init_gen_win_info
3705         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3706         (show_source_or_disasm_and_command): Call the reset method.
3707         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3708         (struct tui_cmd_window): Set can_highlight.
3709
3710 2019-06-25  Tom Tromey  <tom@tromey.com>
3711
3712         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3713         from make_visible.
3714         (tui_make_visible, tui_make_invisible): Rewrite.
3715         (tui_win_info::make_visible): Remove.
3716         (tui_source_window_base::make_visible): Update.
3717         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3718         method.  Moved from...
3719         (struct tui_win_info) <make_visible>: ...here.
3720
3721 2019-06-25  Tom Tromey  <tom@tromey.com>
3722
3723         * tui/tui-winsource.c
3724         (tui_source_window_base::do_scroll_horizontal): Remove direction
3725         parameter.
3726         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3727         direction parameter.
3728         * tui/tui-win.c (tui_win_info::forward_scroll)
3729         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3730         (tui_win_info::right_scroll): Update.
3731         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3732         direction parameter.
3733         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3734         direction parameter.
3735         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3736         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3737         Remove direction parameter.
3738         (struct tui_source_window_base, struct tui_source_window)
3739         (struct tui_disasm_window, struct tui_data_window)
3740         (struct tui_cmd_window): Update.
3741
3742 2019-06-25  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-winsource.h (tui_set_exec_info_content)
3745         (tui_show_exec_info_content, tui_erase_exec_info_content)
3746         (tui_clear_exec_info_content, tui_update_exec_info): Change
3747         argument to tui_source_window_base.
3748         * tui/tui-winsource.c (tui_set_exec_info_content)
3749         (tui_show_exec_info_content, tui_erase_exec_info_content)
3750         (tui_clear_exec_info_content, tui_update_exec_info): Change
3751         argument to tui_source_window_base.
3752
3753 2019-06-25  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3756         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3757
3758 2019-06-25  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3761         check.
3762
3763 2019-06-25  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3766         type to void.
3767         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3768         type to void.
3769         * tui/tui-source.c (tui_set_source_content): Update.
3770         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3771
3772 2019-06-25  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-win.c (window_name_completer, tui_set_focus)
3775         (tui_all_windows_info): Use name method.
3776         * tui/tui-data.h (struct tui_gen_win_info)
3777         (struct tui_source_window, struct tui_disasm_window)
3778         (struct tui_data_window, struct tui_cmd_window) <name>: New
3779         method.
3780         (tui_win_name): Don't declare.
3781         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3782         (tui_win_name): Remove.
3783
3784 2019-06-25  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-winsource.h (tui_update_source_window)
3787         (tui_update_source_window_as_is): Change parameter type.
3788         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3789         to be a tui_source_window_base.
3790         (tui_update_source_window_as_is): Likewise.
3791         * tui/tui-win.c (make_visible_with_new_height): Update.
3792
3793 2019-06-25  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-winsource.c (tui_erase_source_content)
3796         (tui_show_source_content, tui_show_exec_info_content)
3797         (tui_erase_exec_info_content): Use refresh_window method.
3798         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3799         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3800         from tui_refresh_win.
3801         (tui_data_window::refresh_window): New method.
3802         (tui_win_info::refresh, tui_source_window_base::refresh)
3803         (tui_refresh_all): Use refresh_window method.
3804         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3805         method.
3806         * tui/tui-regs.c (tui_display_register): Call refresh_window
3807         method.
3808         * tui/tui-layout.c (show_source_disasm_command)
3809         (show_source_or_disasm_and_command): Call refresh_window method.
3810         * tui/tui-data.h (struct tui_gen_win_info)
3811         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3812         New method.
3813
3814 2019-06-25  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui.c (tui_rl_other_window, tui_enable)
3817         (tui_is_window_visible, tui_get_command_dimension): Update.
3818         * tui/tui-winsource.c (tui_update_source_window_as_is)
3819         (tui_clear_source_content, tui_erase_source_content)
3820         (tui_show_source_line, tui_source_window_base::refill)
3821         (tui_source_window_base::do_scroll_horizontal)
3822         (tui_source_window_base::set_is_exec_point_at)
3823         (tui_update_breakpoint_info, tui_set_exec_info_content)
3824         (tui_alloc_source_buffer, tui_line_is_displayed)
3825         (tui_addr_is_displayed): Update.
3826         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3827         (tui_check_and_display_highlight_if_needed)
3828         (tui_win_info::make_visible, tui_win_info::refresh)
3829         (tui_refresh_all): Update.
3830         * tui/tui-windata.c (tui_first_data_item_displayed)
3831         (tui_delete_data_content_windows, tui_erase_data_content)
3832         (tui_display_all_data, tui_data_window::refresh_all)
3833         (tui_check_data_values): Update.
3834         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3835         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3836         (tui_win_info::backward_scroll, tui_refresh_all_win)
3837         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3838         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3839         (tui_source_window_base::set_new_height)
3840         (tui_data_window::set_new_height)
3841         (make_invisible_and_set_new_height)
3842         (make_visible_with_new_height, new_height_ok)
3843         (parse_scrolling_args): Update.
3844         * tui/tui-stack.c (tui_show_frame_info): Update.
3845         * tui/tui-source.c (tui_set_source_content)
3846         (tui_set_source_content_nil, tui_source_is_displayed)
3847         (tui_source_window::do_scroll_vertical): Update.
3848         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3849         (tui_display_registers_from, tui_display_reg_element_at_line)
3850         (tui_check_register_values, tui_reg_command): Update.
3851         * tui/tui-layout.c (tui_default_win_height)
3852         (show_source_disasm_command, show_data, init_and_make_win)
3853         (show_source_or_disasm_and_command): Update.
3854         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3855         (tui_redisplay_readline, tui_mld_flush)
3856         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3857         (tui_getc): Update.
3858         * tui/tui-disasm.c (tui_set_disassem_content)
3859         (tui_disasm_window::do_scroll_vertical): Update.
3860         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3861         Now virtual.
3862         (struct tui_win_info): Derive from tui_gen_win_info.
3863         <~tui_win_info>: Mark as override.
3864         <generic>: Remove member.
3865         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3866         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3867         (~tui_data_window, ~tui_win_info)
3868         (tui_free_all_source_wins_content): Update.
3869         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3870
3871 2019-06-25  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-layout.c (init_and_make_win): Use new.
3874         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3875         destructor, initializers.
3876         (tui_alloc_generic_win_info): Don't declare.
3877         * tui/tui-data.c (_locator): Add argument to constructor.
3878         (source_win, disasm_win): New globals.
3879         (exec_info): Remove.
3880         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3881         Update.
3882         (tui_alloc_generic_win_info): Remove.
3883         (init_content_element): Use new.
3884         (tui_win_info::tui_win_info): Update.
3885         (free_content_elements) <case DATA_WIN>: Use delete.
3886
3887 2019-06-25  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3890         * tui/tui-windata.c (tui_first_data_item_displayed)
3891         (tui_delete_data_content_windows): Update.
3892         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3893         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3894         (tui_display_registers_from, tui_check_register_values): Update.
3895         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3896         pointer.
3897         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3898         window.
3899         (tui_free_data_content): Update.
3900         (free_content_elements) <case DATA_WIN>: Free the window.
3901
3902 2019-06-25  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3905         Update.
3906         * tui/tui-layout.c (make_command_window)
3907         (show_source_disasm_command, show_data, init_and_make_win)
3908         (show_source_or_disasm_and_command): Update.
3909         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3910         method.
3911         <can_highight, is_highlighted>: Now bool.
3912         (tui_set_win_highlight): Don't declare.
3913         * tui/tui-data.c (tui_set_win_highlight): Remove.
3914
3915 2019-06-25  Tom Tromey  <tom@tromey.com>
3916
3917         * tui/tui-wingeneral.c (make_visible): Remove check of window
3918         type.
3919
3920 2019-06-25  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-win.c (tui_win_info::max_height)
3923         (tui_cmd_window::max_height): New methods.
3924         (new_height_ok): Call max_height.
3925         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3926         <max_height>: New method.
3927
3928 2019-06-25  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-win.c (tui_source_window_base::set_new_height)
3931         (tui_data_window::set_new_height): New methods.
3932         (make_invisible_and_set_new_height): Call set_new_height method.
3933         * tui/tui-data.h (struct tui_win_info)
3934         (struct tui_source_window_base, struct tui_data_window)
3935         <set_new_height>: New method.
3936
3937 2019-06-25  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3940         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3941         tui_refresh_data_win.
3942         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3943         method.
3944         (tui_refresh_all_win): Call the refresh_all method.
3945         (tui_set_focus): Likewise.
3946         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3947         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3948         Likewise.
3949
3950 2019-06-25  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-winsource.h (tui_refill_source_window)
3953         (tui_set_is_exec_point_at): Don't declare.
3954         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3955         (tui_source_window_base::refill): Rename from
3956         tui_refill_source_window.
3957         (tui_source_window_base::do_scroll_horizontal): Update.
3958         (tui_source_window_base::set_is_exec_point_at): Rename from
3959         tui_set_is_exec_point_at.
3960         (tui_update_all_breakpoint_info): Update.
3961         * tui/tui-stack.c (tui_show_frame_info): Update.
3962         * tui/tui-layout.c (show_data): Add cast.
3963         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3964         * tui/tui-data.h (struct tui_source_window_base) <refill,
3965         set_is_exec_point_at>: New methods.
3966         (tui_source_windows, tui_add_to_source_windows): Update types.
3967         (tui_add_to_source_windows): Remove redundant declaration.
3968         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3969         (tui_source_windows): Change return type.
3970         (tui_clear_source_windows_detail): Update.
3971         (tui_add_to_source_windows): Change type of parameter.
3972         (tui_free_all_source_wins_content): Update.
3973
3974 2019-06-25  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-wingeneral.c (tui_win_info::refresh)
3977         (tui_source_window_base::refresh): New methods.
3978         (tui_refresh_all): Call the refresh method.
3979         * tui/tui-data.h (struct tui_win_info)
3980         (struct tui_source_window_base) <refresh>: New method.
3981
3982 2019-06-25  Tom Tromey  <tom@tromey.com>
3983
3984         * tui/tui.h (tui_is_window_visible): Return bool.
3985         * tui/tui.c (tui_is_window_visible): Return bool.
3986         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3987         (tui_make_visible, tui_make_invisible)
3988         (tui_win_info::make_visible)
3989         (tui_source_window_base::make_visible, make_all_visible)
3990         (tui_make_all_visible, tui_make_all_invisible): Update.
3991         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3992         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3993         bool.
3994         (struct tui_win_info, struct tui_source_window_base)
3995         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3996         * tui/tui-data.c (tui_init_generic_part): Update.
3997
3998 2019-06-25  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4001         (tui_source_window_base::make_visible): New methods.
4002         (make_all_visible): Make method call.
4003         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4004         (struct tui_source_window_base, struct tui_cmd_window): Override
4005         make_visible.
4006         (tui_win_is_source_type): Don't declare.
4007         * tui/tui-data.c (tui_win_is_source_type): Remove.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4012         NULL check.
4013
4014 2019-06-25  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4017         Inline constructor.  Add initializers for members.
4018         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4019         constructors; now inline in class.
4020
4021 2019-06-25  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-regs.c (tui_show_registers): Update.
4024         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4025         bool.
4026         * tui/tui-data.c (tui_data_window::clear_detail)
4027         (tui_data_window): Update.
4028
4029 2019-06-25  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-windata.c (tui_display_all_data)
4032         (tui_display_data_from_line, tui_display_data_from)
4033         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4034         Update.
4035         * tui/tui-regs.c (tui_last_regs_line_no)
4036         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4037         (tui_show_registers, tui_show_register_group)
4038         (tui_display_registers_from, tui_display_reg_element_at_line)
4039         (tui_display_registers_from_line, tui_check_register_values)
4040         (tui_reg_next, tui_reg_prev): Update.
4041         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4042         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4043         tui_data_window.
4044         (struct tui_win_info) <detail>: Remove.  Add new fields from
4045         tui_data_info.
4046         (TUI_DATA_WIN): Add cast.
4047         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4048         (~tui_data_window): Simplify.
4049
4050 2019-06-25  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-layout.c (show_source_disasm_command)
4053         (show_source_or_disasm_and_command): Update.
4054         * tui/tui-io.c (update_cmdwin_start_line)
4055         (tui_redisplay_readline): Update.
4056         * tui/tui-data.h (struct tui_command_info): Remove.
4057         (struct tui_win_info) <detail>: Remove command_info member.
4058         (struct tui_data_window) <start_line>: New member, from
4059         tui_command_info.
4060         (TUI_CMD_WIN): Add casts.
4061
4062 2019-06-25  Tom Tromey  <tom@tromey.com>
4063
4064         * tui/tui-winsource.c (tui_update_source_window)
4065         (tui_refill_source_window)
4066         (tui_source_window_base::do_scroll_horizontal)
4067         (tui_update_breakpoint_info, tui_set_exec_info_content)
4068         (tui_show_exec_info_content, tui_erase_exec_info_content)
4069         (tui_clear_exec_info_content): Update.
4070         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4071         Update.
4072         * tui/tui-win.c (make_invisible_and_set_new_height)
4073         (make_visible_with_new_height): Update.
4074         * tui/tui-source.c (tui_set_source_content)
4075         (tui_show_symtab_source): Update.
4076         * tui/tui-layout.c (extract_display_start_addr)
4077         (show_source_disasm_command, show_data)
4078         (make_source_or_disasm_window)
4079         (show_source_or_disasm_and_command): Update.
4080         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4081         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4082         "gdbarch".
4083         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4084         to tui_source_window_base.
4085         (struct tui_win_info) <detail>: Remove source_info member.
4086         (struct tui_source_window_base) <has_locator>: Inline.
4087         Move contents from tui_source_info; rename has_locator member to
4088         m_has_locator.
4089         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4090         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4091         header file.
4092         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4093         Simplify.
4094         (tui_free_all_source_wins_content): Cast to
4095         tui_source_window_base.
4096
4097 2019-06-25  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-win.c (make_invisible_and_set_new_height)
4100         (make_visible_with_new_height): Call has_locator method.
4101         * tui/tui-layout.c (show_source_disasm_command, show_data)
4102         (show_source_or_disasm_and_command): Update for bool change.
4103         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4104         (tui_win_info) <has_locator>: New method.
4105         (struct tui_source_window_base) <has_locator>: New method.
4106         (tui_win_has_locator): Don't declare.
4107         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4108         from tui_win_has_locator.
4109         (tui_source_window_base): Use false, not FALSE.
4110
4111 2019-06-25  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4114         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4115         clear_detail method directly.
4116         (tui_clear_win_detail): Remove.
4117
4118 2019-06-25  Tom Tromey  <tom@tromey.com>
4119
4120         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4121         "this", not TUI_DISASM_WIN.
4122
4123 2019-06-25  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4126         declare.
4127         * tui/tui-winsource.c
4128         (tui_source_window_base::do_scroll_horizontal): Rename from
4129         tui_horizontal_source_scroll.
4130         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4131         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4132         from tui_vertical_data_scroll.
4133         * tui/tui-win.h (tui_scroll): Don't declare.
4134         * tui/tui-win.c (tui_win_info::forward_scroll)
4135         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4136         (tui_win_info::right_scroll): Rename and update.
4137         (tui_scroll_forward_command, tui_scroll_backward_command)
4138         (tui_scroll_left_command, tui_scroll_right_command): Update.
4139         (tui_scroll): Remove.
4140         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4141         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4142         from tui_vertical_source_scroll.
4143         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4144         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4145         from tui_vertical_disassem_scroll.
4146         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4147         do_scroll_horizontal>: New methods.
4148         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4149         Likewise.
4150         (struct tui_source_window_base): Add do_scroll_horizontal.
4151         (struct tui_source_window, struct tui_disasm_window): Add
4152         do_scroll_vertical.
4153         (struct tui_data_window, struct tui_cmd_window): Add
4154         do_scroll_horizontal and do_scroll_vertical.
4155         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4156
4157 2019-06-25  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-data.h (struct tui_source_window_base): New struct.
4160         (struct tui_source_window): Derive from tui_source_window_base.
4161         (struct tui_disasm_window): New struct.
4162         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4163         from tui_source_window::clear_detail.
4164         (tui_source_window_base): Rename from tui_source_window.
4165         (~tui_source_window_base): Rename from ~tui_source_window.
4166         (tui_alloc_win_info): Create a tui_disasm_window.
4167
4168 2019-06-25  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-data.h (struct tui_source_window)
4171         (struct tui_data_window): Declare destructors.
4172         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4173         destructors.
4174         (tui_win_info): Simplify.
4175
4176 2019-06-25  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui-winsource.c (tui_display_main)
4179         (tui_update_source_windows_with_addr)
4180         (tui_update_all_breakpoint_info): Update.
4181         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4182         (new_height_ok, parse_scrolling_args): Update.
4183         * tui/tui-stack.c (tui_show_frame_info): Update.
4184         * tui/tui-data.h (struct tui_list): Remove.
4185         (tui_source_windows): Return a reference to a std::vector.
4186         * tui/tui-data.c (source_windows): Now a std::vector.
4187         (tui_source_windows): Change return type.
4188         (tui_clear_source_windows): Rewrite.
4189         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4190         (tui_free_all_source_wins_content): Rewrite.
4191
4192 2019-06-25  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4195         (struct tui_data_window, struct tui_cmd_window): Declare
4196         clear_detail method.
4197         * tui/tui-data.c (tui_source_window::clear_detail)
4198         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4199         methods.
4200         (tui_clear_win_detail): Simplify.
4201
4202 2019-06-25  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-layout.c (make_source_window, make_disasm_window)
4205         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4206         Return the new window.
4207         (show_source_disasm_command, show_data)
4208         (show_source_or_disasm_and_command): Update.
4209
4210 2019-06-25  Tom Tromey  <tom@tromey.com>
4211
4212         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4213         parameter.  Return the new window.
4214         (show_source_disasm_command): Update and remove NULL check.
4215         (show_source_or_disasm_and_command): Update.
4216
4217 2019-06-25  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4220
4221 2019-06-25  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-data.h (struct tui_win_info): Make constructor
4224         protected.  Make destructor virtual.  Add initializers.
4225         (tui_source_window, tui_data_window, tui_cmd_window): New
4226         classes.
4227         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4228         constructor.  Add "type" parameter.
4229         (tui_source_window, tui_data_window, tui_cmd_window): New
4230         constructors.
4231         (tui_alloc_win_info): Instantiate the appropriate subclass.
4232
4233 2019-06-25  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-win.c (tui_resize_all): Use delete.
4236         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4237         destructor.
4238         (tui_free_window): Don't declare.
4239         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4240         Update.
4241
4242 2019-06-25  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-data.h (struct tui_win_info): Add constructor.
4245         * tui/tui-data.c (tui_alloc_win_info): Use new.
4246         (tui_free_window): Use delete.
4247
4248 2019-06-22  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4251         declare.
4252         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4253
4254 2019-06-22  Tom Tromey  <tom@tromey.com>
4255
4256         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4257         declare.
4258         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4259
4260 2019-06-22  Tom de Vries  <tdevries@suse.de>
4261
4262         * dwarf2read.c (create_addrmap_from_aranges)
4263         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4264         instead of '%zu'.
4265
4266 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4267
4268         * dwarf2read.h (dwarf2_section_info_def): Remove.
4269         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4270         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4271         std::vector<dwarf2_section_info>.
4272         (struct dwo_file) <~dwo_file>: Remove.
4273         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4274         types field.
4275         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4276         (dwarf2_read_debug_names): Likewise.
4277         (create_debug_types_hash_table): Change parameter type to
4278         array_view, adjust code accordingly.
4279         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4280         (partial_die_info::fixup): Likewise.
4281         (determine_prefix): Likewise.
4282         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4283
4284 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4285
4286         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4287         gdb_bfd_ref_ptr.
4288         <~dwo_file>: Remove call to gdb_bfd_unref.
4289         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4290         gdb_bfd_ref_ptr::get.
4291
4292 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4293
4294         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4295         type to htab_up.
4296         * dwarf2read.c (struct dwo_file): Initialize fields.
4297         <~dwo_file>: New.
4298         (free_dwo_file): Remove, move content to ~dwo_file.
4299         (struct dwo_file_deleter): Remove.
4300         (dwo_file_up>: Remove custom deleter.
4301         (free_dwo_files): Remove.
4302         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4303         dwo_files.
4304         (process_skeletonless_type_units): Call unique_ptr::get.
4305         (allocate_dwo_file_hash_table): Add deleter to created hash
4306         table.  Change return type to htab_up.
4307         (lookup_dwo_file_slot): Don't memset dwo_file, call
4308         unique_ptr::get.
4309         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4310         (create_dwo_unit_in_dwp_v2): Likewise.
4311         (open_and_init_dwo_file): Likewise.
4312         (free_dwo_file_from_slot): Remove.
4313
4314 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4315
4316         * dwarf2read.h (struct dwarf2_section_info) <readin,
4317         is_virtual>: Change type to bool.
4318         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4319         true instead of 1.
4320
4321 2019-06-19  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui-data.h (tui_init_content_element): Don't declare.
4324
4325 2019-06-19  Tom Tromey  <tom@tromey.com>
4326
4327         * tui/tui-data.h (tui_init_win_info): Don't declare.
4328
4329 2019-06-19  Tom de Vries  <tdevries@suse.de>
4330
4331         * dwarf2read.h (abstract_to_concrete): Change type to
4332         std::unordered_map<sect_offset, std::vector<sect_offset>,
4333         gdb::hash_enum<sect_offset>>.
4334
4335 2019-06-19  Tom Tromey  <tromey@adacore.com>
4336
4337         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4338         EVAL_AVOID_SIDE_EFFECTS specially.
4339
4340 2019-06-19  Tom Tromey  <tromey@adacore.com>
4341
4342         * source-cache.c (highlighter): New global.
4343         (source_cache::get_source_lines): Create a highlighter on demand.
4344
4345 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * defs.h (deprecated_interactive_hook): Delete declaration.
4348         * interps.c (clear_interpreter_hooks): Remove use of
4349         deprecated_interactive_hook.
4350         * top.c (deprecated_interactive_hook): Delete definition.
4351         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4352
4353 2019-06-18  Tom de Vries  <tdevries@suse.de>
4354
4355         PR gdb/24515
4356         * dwarf2read.h (abstract_to_concrete): Change type from
4357         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4358         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4359         * dwarf2read.c (read_variable): Update.
4360         (dwarf2_fetch_die_loc_sect_off): Update.
4361
4362 2019-06-17  Tom de Vries  <tdevries@suse.de>
4363
4364         PR gdb/24617
4365         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4366         accessing parent[parent_len - 1].
4367
4368 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4369
4370         PR gdb/24364
4371         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4372         call dtrace_process_dof with NULL dof.
4373
4374 2019-06-16  Tom de Vries  <tdevries@suse.de>
4375
4376         PR gdb/24445
4377         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4378
4379 2019-06-16  Tom Tromey  <tom@tromey.com>
4380
4381         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4382         (make_all_visible): Use address of member.
4383
4384 2019-06-16  Tom Tromey  <tom@tromey.com>
4385
4386         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4387         (tui_free_window, free_content, free_content_elements): Remove
4388         unnecessary cast.
4389         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4390         cast.
4391         * tui/tui-regs.c (tui_show_register_group)
4392         (tui_display_registers_from, tui_display_reg_element_at_line):
4393         Remove unnecessary cast.
4394
4395 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4396
4397         * linux-nat.c (normal_mask): Delete.
4398         (_initialize_linux_nat): Don't initialise normal_mask.
4399
4400 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4401
4402         PR gdb/24445
4403         * dwarf-index-write.h (write_psymtabs_to_index): Add
4404         dwz_basename parameter.
4405         * dwarf-index-write.c (write_gdbindex): Move file writing to
4406         write_gdbindex_1.  Change return type void.
4407         (assert_file_size): Move up, remove filename parameter.
4408         (write_gdbindex_1): New function.
4409         (write_debug_names): Change return type to void, call
4410         assert_file_size.
4411         (struct index_wip_file): New struct.
4412         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4413         file logic to index_wip_file.  Write index for dwz file if
4414         needed.
4415         (save_gdb_index_command): Pass basename of dwz file, if present.
4416         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4417         build-id of dwz file, if present.
4418         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4419         (dwarf2_get_dwz_file): Likewise.
4420         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4421         (dwarf2_get_dwz_file): Likewise.
4422
4423 2019-06-16  Tom Tromey  <tom@tromey.com>
4424
4425         * coffread.c (process_coff_symbol): Use xstrdup.
4426         * value.c (create_internalvar): Use xstrdup.
4427
4428 2019-06-16  Tom Tromey  <tom@tromey.com>
4429
4430         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4431         * breakpoint.c (stopin_command, stopat_command)
4432         (until_break_command, decode_location_default): Remove unnecessary
4433         cast.
4434         * utils.c (subset_compare): Remove unnecessary cast.
4435         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4436         cast.
4437         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4438         cast.
4439         * infcmd.c (path_command): Remove unnecessary cast.
4440         * coffread.c (decode_type): Remove unnecessary cast.
4441         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4442         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4443         * tui/tui-stack.c (tui_show_locator_content)
4444         (tui_show_frame_info): Remove unnecessary cast.
4445         * tui/tui-win.c (tui_scroll_forward_command)
4446         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4447         (parse_scrolling_args): Remove unnecessary cast.
4448         * tui/tui-data.c (init_win_info, tui_del_window)
4449         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4450         (free_content_elements): Remove unnecessary cast.
4451         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4452         unnecessary cast.
4453         * tui/tui-source.c (tui_set_source_content)
4454         (tui_vertical_source_scroll): Remove unnecessary cast.
4455         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4456         cast.
4457         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4458         * tui/tui-regs.c (tui_display_registers_from)
4459         (tui_display_register): Remove unnecessary cast.
4460         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4461         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4462         (make_visible): Remove unnecessary cast.
4463         * tui/tui-winsource.c (tui_erase_source_content)
4464         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4465         unnecessary cast.
4466         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4467         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4468         * stabsread.c (read_type, read_array_type, read_range_type):
4469         Remove unnecessary cast.
4470         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4471         (parse_symbol, parse_type, upgrade_type, parse_external)
4472         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4473         unnecessary cast.
4474         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4475
4476 2019-06-16  Tom Tromey  <tom@tromey.com>
4477
4478         * tui/tui-data.c (tui_alloc_generic_win_info)
4479         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4480         checks.
4481
4482 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4483             Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * f-typeprint.c (f_print_type): Don't return early for not
4486         associated or not allocated types.
4487         (f_type_print_varspec_suffix): Add print_rank parameter and print
4488         ranks of array types in case they dangling.
4489         (f_type_print_base): Add print_rank parameter.
4490
4491 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * NEWS: Mention new MI commands.
4494         * break-catch-throw.c (enum exception_event_kind): Move to
4495         breakpoint.h.
4496         (print_mention_exception_catchpoint): Output text as a single
4497         message.
4498         (catch_exception_command_1): Rename to...
4499         (catch_exception_event): ...this, make non-static, update header
4500         command, and change some parameter types.
4501         (catch_catch_command): Update for changes to
4502         catch_exception_command_1.
4503         (catch_throw_command): Likewise.
4504         (catch_rethrow_command): Likewise.
4505         * breakpoint.c (enum exception_event_kind): Delete.
4506         * breakpoint.h (enum exception_event_kind): Moved here from
4507         break-catch-throw.c.
4508         (catch_exception_event): Declare.
4509         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4510         (mi_cmd_catch_throw): New function.
4511         (mi_cmd_catch_rethrow): New function.
4512         (mi_cmd_catch_catch): New function.
4513         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4514         'catch-catch' entries.
4515         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4516         (mi_cmd_catch_rethrow): Declare.
4517         (mi_cmd_catch_catch): Declare.
4518
4519 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4520
4521         * annotate.c (annotate_source_line): Change return type to void,
4522         update implementation to match.
4523         * annotate.h (annotate_source_line): Change return type to void,
4524         update header comment.
4525         * stack.c (print_frame_info): Don't change what frame information
4526         is printed based on whether annotations are on or not.
4527
4528 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4531         (annotate_source): Make static.
4532         (annotate_source_line): Moved from source.c and renamed from
4533         identify_source_line.  Update the return type.
4534         * annotate.h (annotate_source): Delete declaration.
4535         (annotate_source_line): Declaration moved from source.h, and
4536         renamed from identify_source_line.  Return type updated.
4537         * source.c (identify_source_line): Moved to annotate.c and renamed
4538         to annotate_source_line.
4539         (info_line_command): Remove check of annotation_level.
4540         * source.h (identify_source_line): Move declaration to annotate.h
4541         and rename to annotate_source_line.
4542         * stack.c: Add 'annotate.h' include.
4543         (print_frame_info): Remove check of annotation_level before
4544         calling annotate_source_line.
4545
4546 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4547
4548         * source-cache.c (source_cache::get_plain_source_lines): Use
4549         open_source_file_with_line_charpos instead of just
4550         open_source_file, remove call to find_source_lines.
4551         (source_cache::get_source_lines): Likewise.
4552         * source.c (find_source_lines): Make static.
4553         (get_filename_and_charpos): Renamed into...
4554         (open_source_file_with_line_charpos): ..this along with changes to
4555         return a scoped_fd, and some other minor clean ups.
4556         (identify_source_line): Use open_source_file_with_line_charpos.
4557         (search_command_helper): Use open_source_file_with_line_charpos
4558         instead of just open_source_file, remove call to
4559         find_source_lines.
4560         * source.h (open_source_file_with_line_charpos): Declare new
4561         function.
4562         (find_source_lines): Delete declaration.
4563
4564 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * source.c (get_filename_and_charpos): Remove fullname
4567         parameter.
4568         (identify_source_line): Update call to get_filename_and_charpos.
4569
4570 2019-06-14  Tom Tromey  <tromey@adacore.com>
4571
4572         PR gdb/24502:
4573         * ui-style.h (skip_ansi_escape): Update comment.
4574         * ui-file.h (class no_terminal_escape_file): New class.
4575         * ui-file.c (no_terminal_escape_file::write)
4576         (no_terminal_escape_file::puts): New methods.
4577         * cli/cli-logging.c (handle_redirections): Use
4578         no_terminal_escape_file.
4579
4580 2019-06-14  Tom Tromey  <tromey@adacore.com>
4581
4582         * NEWS: Move convenience variable news above Python news.
4583
4584 2019-06-14  Tom Tromey  <tom@tromey.com>
4585
4586         * gnulib: Move directory to top-level.
4587         * configure.ac: Don't configure gnulib.
4588         * configure: Rebuild.
4589         * common/common-defs.h: Use new path to gnulib.
4590         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4591         (GNULIB_H): Remove.
4592         (INCGNU): Look in new gnulib location.
4593         (HFILES_NO_SRCDIR): Remove gnulib files.
4594         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4595         (generated_files): Remove GNULIB_H.
4596         ($(LIBGNU), all-lib): Remove targets.
4597         (distclean): Don't mention GNULIB_BUILDDIR.
4598         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4599
4600 2019-06-14  Tom Tromey  <tromey@adacore.com>
4601
4602         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4603         Warn if symbol file does not provide any symbols.
4604
4605 2019-06-14  Tom Tromey  <tromey@adacore.com>
4606
4607         * source.c (find_and_open_source): Respect basenames_may_differ.
4608
4609 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * annotate.c (annotate_breakpoints_invalid): Make use of
4612         scoped_restore_terminal_state.
4613         (annotate_frames_invalid): Likewise.
4614
4615 2019-06-14  Tom Tromey  <tromey@adacore.com>
4616
4617         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4618         allow assignment to an internalvar.
4619
4620 2019-06-14  Tom Tromey  <tromey@adacore.com>
4621
4622         * ada-lex.l: Allow "_" in attribute names.
4623
4624 2019-06-14  Tom Tromey  <tromey@adacore.com>
4625
4626         PR gdb/24653:
4627         * regcache.c (registers_changed): Don't call alloca.
4628         * top.c (execute_command): Don't call alloca.
4629
4630 2019-06-13  Pedro Alves  <palves@redhat.com>
4631
4632         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4633         'expression'.  When parsing an expression, error out if there's
4634         junk after "unlimited".
4635         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4636         (do_set_command): Adjust calls to is_unlimited_literal.
4637
4638 2019-06-13  Pedro Alves  <palves@redhat.com>
4639
4640         * compile/compile.c (make_compile_options_def_group): Add braces
4641         around array_view initializer.
4642         * thread.c (make_thread_apply_all_options_def_group)
4643         (make_thread_apply_all_options_def_group): Likewise.
4644
4645 2019-06-13  Pedro Alves  <palves@redhat.com>
4646
4647         * NEWS (New commands): Mention "maint test-options
4648         require-delimiter", "maint test-options unknown-is-error", "maint
4649         test-options unknown-is-operand" and "maint show
4650         test-options-completion-result".
4651         (New command options, command completion): New section.
4652         (Completion improvements): New section.
4653         Mention that you can abbreviate "unlimited".
4654
4655 2019-06-13  Pedro Alves  <palves@redhat.com>
4656
4657         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4658         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4659         * unittests/cli-utils-selftests.c (test_parse_flags)
4660         (test_parse_flags_qcs): Delete.
4661         (test_cli_utils): Don't call deleted functions.
4662
4663 2019-06-13  Pedro Alves  <palves@redhat.com>
4664
4665         * thread.c: Include "cli/cli-option.h".
4666         (tp_array_compar_ascending): Global.
4667         (tp_array_compar): Delete function.
4668         (tp_array_compar_ascending, tp_array_compar_descending): New
4669         functions.
4670         (ascending_option_def, qcs_flag_option_def)
4671         (thr_qcs_flags_option_defs)
4672         (make_thread_apply_all_options_def_group)
4673         (make_thread_apply_options_def_group): New.
4674         (thread_apply_all_command): Use gdb::option::process_options.
4675         (thread_apply_command_completer)
4676         (thread_apply_all_command_completer): New.
4677         (thread_apply_command): Use gdb::option::process_options.
4678         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4679         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4680         to generate help text of "thread apply".  Adjust "taas"'s help.
4681         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4682         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4683
4684 2019-06-13  Pedro Alves  <palves@redhat.com>
4685
4686         * thread.c (thread_apply_command): Check for invalid TID with
4687         isdigit instead of !isalpha.
4688
4689 2019-06-13  Pedro Alves  <palves@redhat.com>
4690
4691         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4692         (validate_flags_qcs): New.
4693         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4694         (validate_flags_qcs): Declare.
4695         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4696         (make_frame_apply_options_def_group): New.
4697         (frame_apply_command_count): Process options with
4698         gdb::option::process_options.
4699         (frame_apply_completer): New.
4700         (frame_apply_level_completer, frame_apply_all_completer)
4701         (frame_apply_completer): New.
4702         (_initialize_stack): Update help of "frame apply", "frame apply
4703         level", "frame apply all" and "faas" to mention supported options
4704         and install command completers.
4705         * stack.h (frame_apply_all_completer): Declare.
4706         * thread.c: Include "stack.h".
4707         (tfaas_command): Add "--".
4708         (_initialize_thread): Update help "tfaas" to mention supported
4709         options and install command completer.
4710
4711 2019-06-13  Pedro Alves  <palves@redhat.com>
4712
4713         * completer.c (complete_nested_command_line): New.
4714         (gdb_completion_word_break_characters_throw): Add assertion.
4715         * completer.h (complete_nested_command_line): Declare.
4716
4717 2019-06-13  Pedro Alves  <palves@redhat.com>
4718
4719         * stack.c (parse_backtrace_qualifiers): New.
4720         (backtrace_command): Use it.
4721         (backtrace_command_completer): Complete on qualifiers.
4722
4723 2019-06-13  Pedro Alves  <palves@redhat.com>
4724
4725         * frame.c: Include "cli/cli-option.h.
4726         (user_set_backtrace_options): New.
4727         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4728         Delete.
4729         (get_prev_frame): Adjust.
4730         (boolean_option_def, uinteger_option_def)
4731         (set_backtrace_option_defs): New.
4732         (_initialize_frame): Adjust and use
4733         gdb::option::add_setshow_cmds_for_options to install "set
4734         backtrace past-main" and "set backtrace past-entry".
4735         * frame.h: Include "cli/cli-option.h".
4736         (struct frame_print_options): Forward declare.
4737         (print_frame_arguments_all, print_frame_arguments_scalars)
4738         (print_frame_arguments_none): Declare.
4739         (print_entry_values): Delete declaration.
4740         (struct frame_print_options, user_frame_print_options): New.
4741         (struct set_backtrace_options): New.
4742         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4743         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4744         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4745         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4746         (list_args_or_locals): Add frame_print_options parameter.
4747         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4748         * python/py-framefilter.c (enumerate_args): Pass down
4749         USER_FRAME_PRINT_OPTIONS.
4750         * stack.c: Include "cli/cli-option.h".
4751         (print_frame_arguments_all, print_frame_arguments_scalars)
4752         (print_frame_arguments_none): Declare.
4753         (print_raw_frame_arguments, print_entry_values): Delete.
4754         (user_frame_print_options): New.
4755         (boolean_option_def, enum_option_def, frame_print_option_defs):
4756         New.
4757         (struct backtrace_cmd_options): New.
4758         (bt_flag_option_def): New.
4759         (backtrace_command_option_defs): New.
4760         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4761         (print_frame_arg, read_frame_arg, print_frame_args)
4762         (print_frame_info, print_frame): Add frame_print_options parameter
4763         and use it.
4764         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4765         (backtrace_command_1): Add frame_print_options and
4766         backtrace_cmd_options parameters and use them.
4767         (make_backtrace_options_def_group): New.
4768         (backtrace_command): Process command options with
4769         gdb::option::process_options.
4770         (backtrace_command_completer): New.
4771         (_initialize_stack): Extend "backtrace"'s help to mention
4772         supported options.  Install completer for "backtrace".
4773         Install some settings commands with add_setshow_cmds_for_options.
4774
4775 2019-06-13  Pedro Alves  <palves@redhat.com>
4776
4777         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4778         and that "set/show print raw frame-arguments" are now deprecated.
4779
4780         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4781         command.
4782         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4783         * stack.c (_initialize_stack): Install "set/show print
4784         raw-frame-arguments", and deprecate "set/show print raw
4785         frame-arguments".
4786         * valprint.c (_initialize_valprint): Deprecate "set/show print
4787         raw".
4788
4789 2019-06-13  Pedro Alves  <palves@redhat.com>
4790
4791         * compile/compile.c (struct compile_options): New.
4792         (compile_flag_option_def, compile_command_option_defs)
4793         (make_compile_options_def_group): New.
4794         (compile_file_command): Handle options with
4795         gdb::option::process_options.
4796         (compile_file_command_completer): New function.
4797         (compile_code_command): Handle options with
4798         gdb::option::process_options.
4799         (compile_code_command_completer): New function.
4800         (_initialize_compiler): Install completers for "compile code" and
4801         "compile file".  Mention available options in "compile code" and
4802         "compile code"'s help.
4803         * completer.c (advance_to_completion_word): New, factored out from
4804         ...
4805         (advance_to_expression_complete_word_point): ... this.
4806         (advance_to_filename_complete_word_point): New.
4807         * completer.h (advance_to_filename_complete_word_point): New
4808         declaration.
4809
4810 2019-06-13  Pedro Alves  <palves@redhat.com>
4811
4812         * compile/compile.c: Include "cli/cli-option.h".
4813         (compile_print_value): Scope data pointer is now a
4814         value_print_options pointer; adjust.
4815         (compile_print_command): Process options.  Scope data pointer is
4816         now a value_print_options pointer; adjust.
4817         (_initialize_compile): Update "compile print"'s help to include
4818         supported options.  Install a completer for "compile print".
4819         * cp-valprint.c (show_vtblprint, show_objectprint)
4820         (show_static_field_print): Delete.
4821         (_initialize_cp_valprint): Don't install "set print
4822         static-members", "set print vtbl", "set print object" here.
4823         * printcmd.c: Include "cli/cli-option.h" and
4824         "common/gdb_optional.h".
4825         (print_command_parse_format): Rework to fill in a
4826         value_print_options instead of a format_data.
4827         (print_value): Change parameter type from format_data pointer to
4828         value_print_options reference.  Adjust.
4829         (print_command_1): Process options.  Adjust to pass down a
4830         value_print_options.
4831         (print_command_completer): New.
4832         (_initialize_printcmd): Install print_command_completer as
4833         handle_brkchars completer for the "print" command.  Update
4834         "print"'s help to include supported options.
4835         * valprint.c: Include "cli/cli-option.h".
4836         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4837         here from cp-valprint.c.
4838         (boolean_option_def, uinteger_option_def)
4839         (value_print_option_defs, make_value_print_options_def_group):
4840         New.  Use gdb::option::add_setshow_cmds_for_options to install
4841         "set print elements", "set print null-stop", "set print repeats",
4842         "set print pretty", "set print union", "set print array", "set
4843         print address", "set print symbol", "set print array-indexes".
4844         * valprint.h: Include <string> and "cli/cli-option.h".
4845         (make_value_print_options_def_group): Declare.
4846         (print_value): Change parameter type from format_data pointer to
4847         value_print_options reference.
4848         (print_command_completer): Declare.
4849
4850 2019-06-13  Pedro Alves  <palves@redhat.com>
4851
4852         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4853         (COMMON_SFILES): Add maint-test-settings.c.
4854         * cli/cli-decode.c (boolean_enums): New global, factored out from
4855         ...
4856         (add_setshow_boolean_cmd): ... here.
4857         * cli/cli-decode.h (boolean_enums): Declare.
4858         * cli/cli-option.c: New file.
4859         * cli/cli-option.h: New file.
4860         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4861         factored out from ...
4862         (parse_cli_boolean_value(const char *)): ... this.
4863         (is_unlimited_literal): Change parameter type to pointer to
4864         pointer.  Adjust and advance ARG pointer.
4865         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4866         (parse_cli_var_enum): New, factored out from ...
4867         (do_set_command): ... this.  Adjust.
4868         * cli/cli-setshow.h (parse_cli_boolean_value)
4869         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4870         (parse_cli_var_enum): Declare.
4871         * cli/cli-utils.c: Include "cli/cli-option.h".
4872         (get_ulongest): New.
4873         * cli/cli-utils.h (get_ulongest): Declare.
4874         (check_for_argument): New overloads.
4875         * maint-test-options.c: New file.
4876
4877 2019-06-13  Pedro Alves  <palves@redhat.com>
4878
4879         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4880         parse a range if "-" is at the end of the string.
4881
4882 2019-06-13  Pedro Alves  <palves@redhat.com>
4883
4884         * cli/cli-setshow.c (parse_auto_binary_operation)
4885         (parse_cli_boolean_value): Don't allow "o".
4886
4887 2019-06-13  Pedro Alves  <palves@redhat.com>
4888
4889         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4890         * NEWS: Mention maint test-settings KIND.
4891         * maint-test-settings.c: New file.
4892
4893 2019-06-13  Pedro Alves  <palves@redhat.com>
4894
4895         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4896         completer.
4897         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4898         "set" completers.
4899
4900 2019-06-13  Pedro Alves  <palves@redhat.com>
4901
4902         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4903         after item.
4904
4905 2019-06-13  Pedro Alves  <palves@redhat.com>
4906
4907         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4908
4909 2019-06-13  Pedro Alves <palves@redhat.com>
4910
4911         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4912         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4913         call.
4914         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4915         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4916         calls.
4917         (check_for_argument): Skip spaces after argument.
4918
4919 2019-06-13  Pedro Alves  <palves@redhat.com>
4920
4921         * thread.c (thread_apply_command): Adjust TID parsing.
4922         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4923         detected before end of string.
4924         (tid_is_in_list): Error out if LIST is invalid.
4925
4926 2019-06-13  Pedro Alves  <palves@redhat.com>
4927
4928         * completer.c (complete_line_internal_1): Rewind completion word
4929         point.
4930         (completion_tracker::advance_custom_word_point_by): Change
4931         parameter type to int.
4932         * completer.h (completion_tracker::advance_custom_word_point_by):
4933         Likewise.
4934
4935 2019-06-13  Pedro Alves  <palves@redhat.com>
4936
4937         * completer.c (advance_to_completion_word): Handle delimiters.
4938
4939 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4940
4941         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4942
4943 2019-06-11  Tom Tromey  <tom@tromey.com>
4944
4945         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4946         (xmalloc_failed): Move to alloc.c.
4947         * alloc.c: New file.
4948         * Makefile.in (COMMON_SFILES): Add alloc.c.
4949
4950 2019-06-11  Tom Tromey  <tom@tromey.com>
4951
4952         * nat/linux-waitpid.c: Don't include server.h.
4953         (linux_debug): Remove.
4954         (my_waitpid): Update.
4955
4956 2019-06-11  Tom Tromey  <tromey@adacore.com>
4957
4958         * infcall.c (_initialize_infcall): Remove trailing newline from
4959         help.
4960         * user-regs.c (_initialize_user_regs): Remove trailing newline
4961         from help.
4962         * typeprint.c (_initialize_typeprint): Remove trailing newline
4963         from help.
4964         * reverse.c (_initialize_reverse): Remove trailing newlines from
4965         help.
4966         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4967         from help.
4968         * language.c (add_set_language_command): Remove trailing newline
4969         from help.
4970         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4971         help.
4972         * disasm.c (_initialize_disasm): Remove trailing newline from
4973         help.
4974         * top.c (init_main): Remove trailing newline from help.
4975         * interps.c (_initialize_interpreter): Remove trailing newline
4976         from help.
4977         * btrace.c (_initialize_btrace): Remove trailing newlines from
4978         help.
4979         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4980         from help.
4981         * python/python.c (_initialize_python): Remove trailing newline
4982         from help.
4983         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4984         help.
4985         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4986         from help.  Reformat some text.
4987         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4988         from help.
4989         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4990         newline from help.
4991
4992 2019-06-11  Tom Tromey  <tromey@adacore.com>
4993
4994         * darwin-nat.c (darwin_decode_exception_message)
4995         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4996
4997 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4998
4999         * valops.c (value_slice): Check for not allocated or not
5000         associated values.
5001
5002 2019-06-10  Tom de Vries  <tdevries@suse.de>
5003
5004         PR gdb/24618
5005         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5006         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5007         invalid.
5008
5009 2019-06-10  Tom de Vries  <tdevries@suse.de>
5010
5011         PR gdb/24611
5012         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5013         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5014
5015 2019-06-10  Tom de Vries  <tdevries@suse.de>
5016
5017         PR symtab/24545
5018         * symtab.c (struct demangled_name_entry): Add language field.
5019         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5020         static minimal symbol".  Set and use language field.
5021
5022 2019-06-10  Tom Tromey  <tromey@adacore.com>
5023
5024         * ada-lang.c (_initialize_ada_language): Update help text.
5025
5026 2019-06-10  Tom Tromey  <tromey@adacore.com>
5027
5028         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5029         with a newline.
5030         * guile/guile.c (handle_boot_error): Don't end warning with a
5031         newline.
5032         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5033         warning with a newline.
5034         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5035         newline.
5036         (s12z_frame_cache): Likewise.
5037         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5038         a newline.
5039         * solib-svr4.c (disable_probes_interface): Don't end warning with
5040         a newline.
5041         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5042         newline.
5043         * python/python.c (do_finish_initialization): Don't end warning
5044         with a newline.
5045
5046 2019-06-10  Tom Tromey  <tom@tromey.com>
5047
5048         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5049         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5050         gdbpy_enter.
5051
5052 2019-06-10  Tom Tromey  <tromey@adacore.com>
5053
5054         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5055         data.
5056         (elf_new_init): Don't call stabsread_new_init.
5057         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5058         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5059         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5060
5061 2019-06-10  Tom de Vries  <tdevries@suse.de>
5062
5063         PR symtab/16264
5064         PR symtab/24517
5065         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5066
5067 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5068
5069         * source.c (find_and_open_source): Also rewrite relative file
5070         names.
5071
5072 2019-04-26  Amos Bird  <amosbird@gmail.com>
5073
5074         * annotate.c (annotate_thread_exited): Add "thread-exited"
5075         annotation.
5076
5077 2019-06-06  Tom Tromey  <tromey@adacore.com>
5078
5079         * maint.h (class scoped_command_stats): Use
5080         DISABLE_COPY_AND_ASSIGN.
5081         <print_time>: New method.
5082         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5083         print_time.
5084         (scoped_command_stats::print_time): New method.
5085
5086 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5089         instructions of lengths 6 or 8 bytes.
5090
5091 2019-06-04  Pedro Alves  <palves@redhat.com>
5092
5093         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5094
5095         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5096         * breakpoint.c (condition_completer): Likewise.
5097         * cli/cli-dump.c (scan_expression): Likewise.
5098         * common/filestuff.c (mkdir_recursive): Likewise.
5099         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5100         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5101         (gdb_abspath): Likewise.
5102         * compile/compile-cplus-types.c
5103         (compile_cplus_instance::decl_name): Likewise.
5104         * completer.c (complete_explicit_location):
5105         (signal_completer, reg_or_group_completer_1): Likewise.
5106         * cp-support.c (cp_remove_params_if_any): Likewise.
5107         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5108         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5109         * infcmd.c (strip_bg_char): Likewise.
5110         * linespec.c (copy_token_string): Likewise.
5111         * mi/mi-main.c (output_cores): Likewise.
5112         * psymtab.c (psymtab_search_name):
5113         * symfile.c (test_set_ext_lang_command): Likewise.
5114         * target.c (target_fileio_read_stralloc): Likewise.
5115         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5116         * value.c (complete_internalvar): Likewise.
5117
5118 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5119
5120         Add objfile property to gdb.Type.
5121         * NEWS: Mention Python API addition.
5122         * python/py-type.c (typy_get_objfile): New method.
5123
5124 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5125
5126         * NEWS: Mention the new set|show style [title|highlight].
5127         Mention changes to "show style", "help" and "apropos".
5128
5129 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5130
5131         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5132         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5133         instead of print_help_for_command.
5134         (print_doc_of_command): New function.
5135         (help_list): Add 'apropos -v word' suggestion.
5136         (print_help_for_command): Style the command name using title style.
5137         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5138         (_initialize_cli_cmds): Describe -v in apropos_command help.
5139
5140 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5141
5142         * cli/cli-style.h (cli_style_option): Add name in constructor,
5143         add m_name class member, add constructor with intensity,
5144         add name class function.
5145         (cli_style_option::add_setshow_commands): Remove name argument.
5146         (highlight_style, title_style): New styles.
5147         * cli/cli-style.c (do_show): New function that shows a style
5148         characteristic styling the style name with itself.
5149         (set_style_name): New function.
5150         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5151         Update all callers according to the changes in cli/cli-style.h.
5152         * utils.h (fputs_highlighted): New function.
5153         * utils.c (fputs_highlighted): Likewise.
5154
5155 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5156
5157         * NEWS: Mention new pipe command and new convenience variables.
5158
5159 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5160
5161         * cli/cli-cmds.c (pipe_command): New function.
5162         (_initialize_cli_cmds): Call add_com for pipe_command.
5163         Define | as an alias for pipe.
5164         (exit_status_set_internal_vars): New function.
5165         (shell_escape): Call exit_status_set_internal_vars.
5166         cli/cli-decode.c (find_command_name_length): Recognize | as
5167         a single character command.
5168
5169 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5170
5171         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5172         top.c (execute_command_to_ui_file): New function, mostly a copy
5173         of execute_command_to_string.
5174         (execute_command_to_string): Implement by calling
5175         execute_command_to_ui_file.
5176
5177 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5178
5179         * top.h (saved_command_line): Remove declaration.
5180         * top.c (previous_saved_command_line, previous_repeat_arguments):
5181         New variables.
5182         (saved_command_line): Make static, define together with other
5183         'repeat variables'.
5184         (dont_repeat): Clear repeat_arguments.
5185         (repeat_previous, get_saved_command_line, save_command_line):
5186         New functions.
5187         (gdb_init): Initialize saved_command_line
5188         and previous_saved_command_line.
5189         * main.c (captured_main_1): Remove saved_command_line initialization.
5190         * event-top.c (handle_line_of_input): Update to use
5191         the new 'repeat' related functions instead of direct access to
5192         saved_command_line.
5193         * command.h (repeat_previous, get_saved_command_line,
5194         save_command_line): New declarations.
5195         (dont_repeat): Add comment.
5196
5197 2019-05-30  Tom Tromey  <tromey@adacore.com>
5198
5199         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5200         Fix comment.
5201         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5202
5203 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5204
5205         PR cli/24587
5206         * completer.c (complete): Initialize variable word.
5207
5208 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5209
5210         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5211         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5212         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5213         'body' is NULL to the outter 'if', protecting the '!is_define'
5214         situation as well.
5215
5216 2019-05-29  Tom Tromey  <tromey@adacore.com>
5217
5218         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5219         (dwarf_unknown): New function.
5220         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5221         (dwarf_type_encoding_name): Use dwarf_unknown.
5222
5223 2019-05-29  Tom Tromey  <tromey@adacore.com>
5224
5225         PR c++/20020:
5226         * cp-valprint.c (cp_print_value_fields): Call
5227         cp_print_static_field inside "try".
5228
5229 2019-05-29  Tom Tromey  <tromey@adacore.com>
5230
5231         * inflow.c (struct terminal_info): Add default operator=.
5232         * configure: Rebuild.
5233         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5234         -Wdeprecated-copy-dtor, -Wredundant-move.
5235
5236 2019-05-29  Tom Tromey  <tromey@adacore.com>
5237
5238         * NEWS: Add entry.
5239         * infcmd.c (print_return_value_1): Handle finish_print
5240         option.
5241         (show_print_finish): New function.
5242         (_initialize_infcmd): Add "set/show print finish" commands.
5243         * valprint.c (user_print_options): Initialize new member.
5244         * valprint.h (struct value_print_options) <finish_print>: New
5245         member.
5246
5247 2019-05-28  Tom Tromey  <tromey@adacore.com>
5248
5249         * ada-lang.c (ada_remove_Xbn_suffix)
5250         (find_old_style_renaming_symbol)
5251         (parse_old_style_renaming): Remove.
5252         (ada_find_renaming_symbol): Don't call
5253         find_old_style_renaming_symbol.
5254         (ada_is_renaming_symbol): Rename from
5255         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5256         bool.  Now static.
5257         (ada_read_var_value): Update and simplify.
5258         * ada-exp.y (write_var_or_type): Remove old code.
5259
5260 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5261
5262         * event-top.c: Remove include comment.
5263         * inflow.c (class scoped_ignore_sigttou): Move from here...
5264         * inflow.h (class scoped_ignore_sigttou): ...to here.
5265         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5266         * top.c:  Remove include comment.
5267
5268 2019-05-27  Tom Tromey  <tom@tromey.com>
5269
5270         * NEWS: Fix typo.
5271
5272 2019-05-22  Tom Tromey  <tromey@adacore.com>
5273
5274         * target.c (target_follow_exec): Constify parameter.
5275         * target-delegates.c: Rebuild.
5276         * remote.c (remote_target::follow_exec): Constify parameter.
5277         * infrun.c (follow_exec): Constify parameter.
5278         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5279         (target_follow_exec): Likewise.
5280
5281 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5282
5283         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5284         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5285
5286 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5287
5288         * NEWS: Add debugredirect and testsuite sections.
5289
5290 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5291
5292         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5293         target descriptions using exclusively floating point register name
5294         aliases.
5295
5296 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         PR gdb/18644:
5299         * f-lang.c (build_fortran_types): Handle the case where
5300         gdbarch_floatformat_for_type returns a nullptr.
5301
5302 2019-05-21  Tom de Vries  <tdevries@suse.de>
5303
5304         PR cli/24587
5305         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5306
5307 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5308
5309         PR gdb/18644:
5310         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5311         16-byte floats.
5312         * i386-tdep.c (i386_floatformat_for_type): Use
5313         floatformats_ia64_quad for the 16-byte floating point component
5314         within a fortran 32-byte complex number.
5315
5316 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5317
5318         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5319         delete default constructor.
5320         (find_partial_die): Update to return const struct.
5321         (partial_die_parent_scope): Move variable declaration into scope
5322         of its use and change its type to auto.
5323         (guess_partial_die_structure_name): Likewise.
5324         (partial_die_info::fixup): Likewise.
5325
5326 2019-05-17  Tom Tromey  <tromey@adacore.com>
5327
5328         * source.c (find_and_open_source): Remove cast.
5329
5330 2019-05-17  Tom Tromey  <tromey@adacore.com>
5331
5332         * annotate.c (annotate_source): Make "filename" const.
5333         * annotate.h (annotate_source): Use const.
5334
5335 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5336
5337         * disasm.c (set_disassembler_options): Send errors to stderr.
5338
5339 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5340
5341         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5342         (cli_interp_base::set_logging): Check debug_redirect.
5343         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5344         * cli/cli-logging.c (debug_redirect): Add static variable.
5345         (pop_output_files): Add default param.
5346         (handle_redirections): Print debug setting.
5347         (show_logging_command): Likewise.
5348         (_initialize_cli_logging): Add debugredirect command.
5349         * interps.c (current_interp_set_logging): Add debug_redirect
5350         parameter.
5351         * interps.h (set_logging): Add debug_redirect parameter.
5352         (current_interp_set_logging): Likewise.
5353         * mi/mi-common.h: Likewise.
5354         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5355
5356 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5357             Tom Tromey  <tromey@adacore.com>
5358
5359         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5360         directly.
5361         * cli/cli-interp.h (make_logging_output): Remove declaration.
5362         * cli/cli-logging.c (make_logging_output): Remove function.
5363         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5364         directly.
5365         * ui-file.c (tee_file::tee_file): Remove bools.
5366         (tee_file::~tee_file): Remove deletes.
5367         * ui-file.h (tee_file): Remove bools.
5368
5369 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5370
5371         * mi/mi-cmds.h (mi_cmd_complete): New function.
5372         * mi/mi-main.c (mi_cmd_complete): Likewise.
5373         * mi/mi-cmds.c: Define new MI command -complete.
5374         * NEWS: Mention new -complete command.
5375
5376 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5377
5378         * completer.h (complete): New function.
5379         * completer.c (complete): Likewise.
5380         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5381         function defined in completer.h.
5382
5383 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5384
5385         * MAINTAINERS (Write After Approval): Add myself.
5386
5387 2019-05-17  Tom de Vries  <tdevries@suse.de>
5388
5389         PR gdb/24094
5390         * dwarf2read.c (struct cu_partial_die_info): New struct.
5391         (find_partial_die): Return cu_partial_die_info.
5392         (partial_die_parent_scope, guess_partial_die_structure_name)
5393         (partial_die_info::fixup): Handle new return type of find_partial_die.
5394
5395 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5396
5397         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5398         "std::string", simplifying the algorithm.
5399
5400 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5401
5402         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5403         (stap_static_probe_ops::get_probes): Likewise.
5404
5405 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5406
5407         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5408         '-')" and "else if".
5409         (stap_parse_single_operand): Join checks for
5410         "gdbarch_stap_parse_special_token_p" and
5411         "gdbarch_stap_parse_special_token" in the same "if" statement.
5412         Invert check when verifying for operation on register
5413         displacement.
5414
5415 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5416
5417         * stap-probe.c (stap_get_opcode): Update comment.
5418         (stap_get_expected_argument_type): Likewise.
5419         (handle_stap_probe): Likewise.
5420
5421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5422
5423         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5424         return type to 'bool'.  Adjust comment.  Use 'bool' when
5425         appropriate.
5426         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5427         * stap-probe.c (stap_parse_argument_1): Likewise.
5428         (stap_is_operator): Likewise.
5429         (stap_is_generic_prefix): Likewise.
5430         (stap_is_register_prefix): Likewise.
5431         (stap_is_register_indirection_prefix): Likewise.
5432         (stap_is_integer_prefix): Likewise.
5433         (stap_generic_check_suffix): Likewise.
5434         (stap_check_integer_suffix): Likewise.
5435         (stap_check_register_suffix): Likewise.
5436         (stap_check_register_indirection_suffix): Likewise.
5437         (stap_parse_register_operand): Likewise.
5438         (stap_parse_single_operand): Likewise.
5439         (stap_parse_argument_1): Likewise.
5440         (stap_probe::get_argument_count): Likewise.
5441         (stap_is_operator): Likewise.
5442
5443 2019-05-16  Tom Tromey  <tromey@adacore.com>
5444
5445         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5446         keyword to foreach.
5447
5448 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5449
5450         * linux-thread-db.c (try_thread_db_load_1): Change return type
5451         to bool.
5452         (try_thread_db_load): Likewise.
5453         (try_thread_db_load_from_pdir_1): Likewise.
5454         (try_thread_db_load_from_pdir): Likewise.
5455         (try_thread_db_load_from_sdir): Likewise.
5456         (try_thread_db_load_from_dir): Likewise.
5457         (thread_db_load_search): Likewise.
5458         (has_libpthread): Likewise.
5459         (thread_db_load): Likewise.
5460
5461 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5462
5463         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5464         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5465         NULL, and complain/return if that's the case.
5466
5467 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5468
5469         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5470         (advance, posn, abstract_read_memory): New functions.
5471         [struct mem_read_abstraction]: New struct.
5472         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5473
5474 2019-05-14  Tom Tromey  <tromey@adacore.com>
5475
5476         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5477         value is not lval_memory.
5478
5479 2019-05-14  Tom Tromey  <tromey@adacore.com>
5480
5481         * solib.c (info_sharedlibrary_command): Style the file name.
5482
5483 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5484
5485         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5486         (aarch64_vnv_type): Likewise.
5487         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5488         * common/tdesc.c: Likewise.
5489         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5490         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5491         * features/aarch64-fpu.xml: Add ieee half view.
5492         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5493         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5494         * gdbtypes.h (struct builtin_type): Likewise.
5495         (struct objfile_type): Likewise.
5496
5497 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5498
5499         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5500         typo.
5501         * location.h (string_to_event_location): Likewise.
5502
5503 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5504
5505         GDB 8.3 released.
5506
5507 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5508
5509         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5510         New variable declaration.
5511         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5512         New variable.
5513         (print_one_breakpoint): Use ui_out::test_flags and new global
5514         variable to compute use_fixed_output.
5515         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5516         Remove.
5517         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5518         (mi_multi_location_breakpoint_output_fixed): Remove.
5519         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5520         new variable.
5521         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5522         fix_multi_location_breakpoint_output flag if version >= 3.
5523         * ui-out.h (enum ui_out_flag)
5524         <fix_multi_location_breakpoint_output>: New enumerator.
5525
5526 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5527
5528         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5529
5530 2019-05-10  Tom Tromey  <tromey@adacore.com>
5531
5532         * ada-lang.c (catch_ada_completer): New function.
5533         (_initialize_ada_language): Use it.
5534
5535 2019-05-10  Tom Tromey  <tromey@adacore.com>
5536
5537         * thread.c (print_thread_info): Make "requested_threads" const.
5538         * gdbthread.h (print_thread_info): Make "requested_threads"
5539         const.
5540         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5541         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5542
5543 2019-05-08  Tom Tromey  <tom@tromey.com>
5544
5545         * gdbtypes.c (objfile_type_data): Change type.
5546         (objfile_type, _initialize_gdbtypes): Update.
5547
5548 2019-05-08  Tom Tromey  <tom@tromey.com>
5549
5550         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5551         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5552         (_initialize_dwarf2_frame): Update.
5553
5554 2019-05-08  Tom Tromey  <tom@tromey.com>
5555
5556         * objc-lang.c (objc_objfile_data): Change type.
5557         (find_methods): Update.
5558         (_initialize_objc_lang): Remove.
5559
5560 2019-05-08  Tom Tromey  <tom@tromey.com>
5561
5562         * stabsread.c (rs6000_builtin_type_data): Change type.
5563         (rs6000_builtin_type, _initialize_stabsread): Update.
5564
5565 2019-05-08  Tom Tromey  <tom@tromey.com>
5566
5567         * mips-tdep.c (mips_pdr_data): Remove.
5568         (_initialize_mips_tdep): Update.
5569
5570 2019-05-08  Tom Tromey  <tom@tromey.com>
5571
5572         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5573         (hppa_init_objfile_priv_data, read_unwind_info)
5574         (find_unwind_entry, _initialize_hppa_tdep): Update.
5575
5576 2019-05-08  Tom Tromey  <tom@tromey.com>
5577
5578         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5579         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5580         on obstack.
5581         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5582
5583 2019-05-08  Tom Tromey  <tom@tromey.com>
5584
5585         * mdebugread.c (basic_type_data): Change type.
5586         (basic_type, _initialize_mdebugread): Update.
5587
5588 2019-05-08  Tom Tromey  <tom@tromey.com>
5589
5590         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5591
5592 2019-05-08  Tom Tromey  <tom@tromey.com>
5593
5594         * nto-tdep.c (nto_inferior_data_reg): Change type.
5595         (nto_inferior_data): Update.
5596         (nto_inferior_data_cleanup, nto_new_inferior_data)
5597         (_initialize_nto_tdep): Remove.
5598         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5599
5600 2019-05-08  Tom Tromey  <tom@tromey.com>
5601
5602         * ada-lang.c (struct ada_inferior_data): Add initializers.
5603         (ada_inferior_data): Change type.
5604         (ada_inferior_data_cleanup): Remove.
5605         (get_ada_inferior_data, ada_inferior_exit)
5606         (struct ada_pspace_data): Add initializers, destructor.
5607         (ada_pspace_data_handle): Change type.
5608         (get_ada_pspace_data): Update.
5609         (ada_pspace_data_cleanup): Remove.
5610
5611 2019-05-08  Tom Tromey  <tom@tromey.com>
5612
5613         * coffread.c (struct coff_symfile_info): Add initializers.
5614         (coff_objfile_data_key): Move lower.  Change type.
5615         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5616         Update.
5617         (coff_free_info): Remove.
5618
5619 2019-05-08  Tom Tromey  <tom@tromey.com>
5620
5621         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5622         (fbsd_pspace_data_handle): Move lower.  Change type.
5623         (get_fbsd_pspace_data): Update.
5624         (fbsd_pspace_data_cleanup): Remove.
5625         (_initialize_fbsd_tdep): Update.
5626
5627 2019-05-08  Tom Tromey  <tom@tromey.com>
5628
5629         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5630         (get_ada_tasks_pspace_data): Update.
5631         (ada_tasks_pspace_data_cleanup): Remove.
5632         (_initialize_tasks): Update.
5633         (ada_tasks_inferior_data_handle): Change type.
5634         (get_ada_tasks_inferior_data): Update.
5635         (ada_tasks_inferior_data_cleanup): Remove.
5636         (struct ada_tasks_pspace_data): Add initializers.
5637
5638 2019-05-08  Tom Tromey  <tom@tromey.com>
5639
5640         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5641         * symfile-debug.c (debug_sym_get_probes): Change type.
5642         * stap-probe.c (handle_stap_probe):
5643         (stap_static_probe_ops::get_probes): Change type.
5644         * probe.h (class static_probe_ops) <get_probes>: Change type.
5645         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5646         (parse_probes_in_pspace): Update.
5647         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5648         Update.
5649         (any_static_probe_ops::get_probes): Change type.
5650         * elfread.c (elfread_data): New typedef.
5651         (probe_key): Change type.
5652         (elf_get_probes): Likewise.  Update.
5653         (probe_key_free): Remove.
5654         (_initialize_elfread): Update.
5655         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5656         Change type.
5657         (dtrace_process_dof_probe, dtrace_process_dof)
5658         (dtrace_static_probe_ops::get_probe): Change type.
5659
5660 2019-05-08  Tom Tromey  <tom@tromey.com>
5661
5662         * xcoffread.c (struct xcoff_symfile_info): Rename from
5663         coff_symfile_info.  Add initializers.
5664         (xcoff_objfile_data_key): Move lower.  Change type.
5665         (XCOFF_DATA): Rewrite.
5666         (xcoff_free_info): Remove.
5667         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5668         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5669         (xcoff_initial_scan): Update.
5670
5671 2019-05-08  Tom Tromey  <tom@tromey.com>
5672
5673         * solib-svr4.c (struct svr4_info): Add initializers and
5674         destructor.
5675         <probes_table>: Now an htab_up.
5676         (solib_svr4_pspace_data): Change type.
5677         (free_probes_table): Simplify.
5678         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5679         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5680         (probes_table_remove_objfile_probes, register_solib_event_probe)
5681         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5682         (_initialize_svr4_solib): Update.
5683
5684 2019-05-08  Tom Tromey  <tom@tromey.com>
5685
5686         * remote.c (remote_pspace_data): Change type.
5687         (remote_pspace_data_cleanup): Remove.
5688         (get_remote_exec_file, set_pspace_remote_exec_file)
5689         (_initialize_remote): Update.
5690
5691 2019-05-08  Tom Tromey  <tom@tromey.com>
5692
5693         * breakpoint.c (breakpoint_objfile_key): Change type.
5694         (get_breakpoint_objfile_data): Update.
5695         (free_breakpoint_objfile_data): Remove.
5696         (_initialize_breakpoint): Update.
5697
5698 2019-05-08  Tom Tromey  <tom@tromey.com>
5699
5700         * linux-tdep.c (struct linux_info): Add initializers.
5701         (linux_inferior_data): Move.  Change type.
5702         (invalidate_linux_cache_inf): Update.
5703         (linux_inferior_data_cleanup): Remove.
5704         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5705
5706 2019-05-08  Tom Tromey  <tom@tromey.com>
5707
5708         * auxv.c (auxv_inferior_data): Move.  Change type.
5709         (auxv_inferior_data_cleanup): Remove.
5710         (invalidate_auxv_cache_inf): Rewrite.
5711         (get_auxv_inferior_data, _initialize_auxv): Update.
5712
5713 2019-05-08  Tom Tromey  <tom@tromey.com>
5714
5715         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5716         (symfile_debug_objfile_data_key): Change type.
5717         (symfile_debug_installed, debug_qf_has_symbols)
5718         (debug_qf_find_last_source_symtab)
5719         (debug_qf_forget_cached_source_info)
5720         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5721         (debug_qf_print_stats, debug_qf_dump)
5722         (debug_qf_expand_symtabs_for_function)
5723         (debug_qf_expand_all_symtabs)
5724         (debug_qf_expand_symtabs_with_fullname)
5725         (debug_qf_map_matching_symbols)
5726         (debug_qf_expand_symtabs_matching)
5727         (debug_qf_find_pc_sect_compunit_symtab)
5728         (debug_qf_map_symbol_filenames)
5729         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5730         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5731         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5732         (debug_sym_read_linetable, debug_sym_relocate): Update.
5733         (symfile_debug_free_objfile): Remove.
5734         (install_symfile_debug_logging, _initialize_symfile_debug):
5735         Update.
5736
5737 2019-05-08  Tom Tromey  <tom@tromey.com>
5738
5739         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5740         allocate_on_obstack.
5741         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5742         (get_dwarf2_per_objfile): Update.
5743         (set_dwarf2_per_objfile): Remove.
5744         (dwarf2_has_info, dwarf2_get_section_info): Update.
5745         (dwarf2_free_objfile): Remove.
5746         (_initialize_dwarf2_read): Update.
5747
5748 2019-05-08  Tom Tromey  <tom@tromey.com>
5749
5750         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5751         initializers.
5752         <unsupported_script_warning_printed,
5753         script_not_found_warning_printed>: Now bool.
5754         (auto_load_pspace_data): Change type.
5755         (~auto_load_pspace_info): Rename from
5756         auto_load_pspace_data_cleanup.
5757         (get_auto_load_pspace_data, init_loaded_scripts_info)
5758         (clear_section_scripts, maybe_print_unsupported_script_warning)
5759         (maybe_print_script_not_found_warning, _initialize_auto_load):
5760         Update.
5761
5762 2019-05-08  Tom Tromey  <tom@tromey.com>
5763
5764         * objfiles.c (objfile_pspace_info): Add destructor and
5765         initializers.
5766         (objfiles_pspace_data): Change type.
5767         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5768         (get_objfile_pspace_data): Update.
5769         (objfiles_bfd_data): Change type.
5770         (get_objfile_bfd_data): Update.
5771         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5772
5773 2019-05-08  Tom Tromey  <tom@tromey.com>
5774
5775         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5776         Change type.
5777         (get_catch_syscall_inferior_data): Update.
5778         (catch_syscall_inferior_data_cleanup): Remove.
5779         (_initialize_break_catch_syscall): Update.
5780
5781 2019-05-08  Tom Tromey  <tom@tromey.com>
5782
5783         * inflow.c (struct terminal_info): Add destructor and
5784         initializers.
5785         (inflow_inferior_data): Change type.
5786         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5787         (get_inflow_inferior_data, inflow_inferior_exit)
5788         (swap_terminal_info, _initialize_inflow): Update.
5789
5790 2019-05-08  Tom Tromey  <tom@tromey.com>
5791
5792         * target-dcache.c (target_dcache_cleanup): Remove.
5793         (target_dcache_aspace_key): Change type.
5794         (target_dcache_init_p, target_dcache_invalidate)
5795         (target_dcache_get, target_dcache_get_or_init)
5796         (_initialize_target_dcache): Update.
5797         * dcache.h (struct dcache_deleter): New.
5798
5799 2019-05-08  Tom Tromey  <tom@tromey.com>
5800
5801         * symtab.c (struct symbol_cache): Add destructor and
5802         initializers.
5803         (symbol_cache_key): Move.  Change type.
5804         (make_symbol_cache, free_symbol_cache): Remove.
5805         (get_symbol_cache): Update.
5806         (symbol_cache_cleanup): Remove.
5807         (ALL_PSPACES, symbol_cache_flush)
5808         (maintenance_print_symbol_cache)
5809         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5810         Update.
5811
5812 2019-05-08  Tom Tromey  <tom@tromey.com>
5813
5814         * symtab.c (struct main_info): Add destructor and initializers.
5815         (main_progspace_key): Move.  Change type.
5816         (get_main_info): Update.
5817         (main_info_cleanup): Remove.
5818         (_initialize_symtab): Update.
5819
5820 2019-05-08  Tom Tromey  <tom@tromey.com>
5821
5822         * registry.h (DECLARE_REGISTRY): Define the _key class.
5823
5824 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5825
5826         * NEWS: Merge two 'New commands' sections.
5827
5828 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5829
5830         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5831         parameter and use Ada language definition instead.
5832         (ada_val_print_ptr): Remove unused language parameter.
5833         (ada_val_print_num): Remove language parameter and use Ada language
5834         definition instead.
5835         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5836         parameter.
5837         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5838         parameter and use Ada language definition instead.
5839         (ada_val_print_1): Update all ada_val_print_xxx calls.
5840         Remove language parameter.
5841         (ada_val_print): Update ada_val_print_1 call.
5842
5843 2019-05-08  Tom Tromey  <tromey@adacore.com>
5844
5845         * remote.c (remote_hw_watchpoint_limit)
5846         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5847         Now static.
5848
5849 2019-05-08  Tom Tromey  <tromey@adacore.com>
5850
5851         * maint.c (_initialize_maint_cmds): Move initialization code to
5852         remote.c.
5853         (watchdog, show_watchdog): Move to remote.c.
5854         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5855         "watchdog" static.
5856         (_initialize_remote): Move initialization code from maint.c.
5857         * defs.h (watchdog): Don't declare.
5858
5859 2019-05-08  Tom Tromey  <tromey@adacore.com>
5860
5861         * tui/tui-interp.c: Include main.h.
5862         * interps.c: Include main.h.
5863         * main.h (interpreter_p): Declare.
5864         * defs.h (interpreter_p): Don't declare.
5865
5866 2019-05-08  Tom Tromey  <tromey@adacore.com>
5867
5868         * dwarf2loc.c: Include dwarf2read.h.
5869         * defs.h (read_unsigned_leb128): Don't declare.
5870         * dwarf2read.h (read_unsigned_leb128): Declare.
5871
5872 2019-05-08  Tom Tromey  <tromey@adacore.com>
5873
5874         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5875         method.
5876
5877 2019-05-08  Tom Tromey  <tromey@adacore.com>
5878
5879         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5880         when no wrap column is set.
5881
5882 2019-05-08  Tom Tromey  <tromey@adacore.com>
5883
5884         * c-lang.c (c_get_string): Handle non-C-style arrays.
5885
5886 2019-05-08  Tom Tromey  <tromey@adacore.com>
5887
5888         * typeprint.c (print_offset_data::update): Print the bit offset,
5889         not the number of bits remaining.
5890
5891 2019-05-08  Tom Tromey  <tromey@adacore.com>
5892
5893         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5894         padding at end of comment.
5895
5896 2019-05-08  Tom Tromey  <tromey@adacore.com>
5897
5898         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5899         Compare main types.
5900
5901 2019-05-06  Tom Tromey  <tom@tromey.com>
5902
5903         * common/scoped_mmap.c: Include common-defs.h.
5904         * common/scoped_mmap.h: Don't include config.h.
5905
5906 2019-05-04  Tom Tromey  <tom@tromey.com>
5907
5908         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5909         (struct aarch64_call_info): Add initializers.
5910         <si>: Now a std::vector.
5911         (pass_on_stack, aarch64_push_dummy_call): Update.
5912
5913 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5914             Tom Tromey  <tom@tromey.com>
5915
5916         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5917         (ppc_threads): Now a std::vector.  Now static.
5918         (hwdebug_find_thread_points_by_tid)
5919         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5920         Update.
5921
5922 2019-05-04  Tom Tromey  <tom@tromey.com>
5923
5924         * arc-tdep.c (arc_tdesc_init): Return bool.
5925
5926 2019-05-04  Tom Tromey  <tom@tromey.com>
5927
5928         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5929         Use gdb_assert_not_reached.
5930
5931 2019-05-04  Tom Tromey  <tom@tromey.com>
5932
5933         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5934         "false".
5935
5936 2019-05-04  Tom Tromey  <tom@tromey.com>
5937
5938         * arc-tdep.c (arc_tdesc_init): Use bool.
5939
5940 2019-05-04  Tom Tromey  <tom@tromey.com>
5941
5942         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5943
5944 2019-05-04  Tom Tromey  <tom@tromey.com>
5945
5946         * cli/cli-cmds.c (valid_command_p): Return bool.
5947
5948 2019-05-04  Tom Tromey  <tom@tromey.com>
5949
5950         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5951         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5952
5953 2019-05-04  Raul Tambre  <raul@tambre.ee>
5954
5955         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5956         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5957         operator for comparison.
5958
5959 2019-05-04  Tom Tromey  <tom@tromey.com>
5960
5961         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5962         (lookup_partial_symbol, print_partial_symbols)
5963         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5964         (psymbol_compare): Update.
5965         (add_psymbol_to_bcache): Clear the entire psymbol.
5966         (maintenance_check_psymtabs): Update.
5967         * psympriv.h (struct partial_symbol): Don't derive from
5968         general_symbol_info.
5969         <obj_section, unrelocated_address, address,
5970         set_unrelocated_address>: Update.
5971         <ginfo>: New member.
5972         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5973         (debug_names::write_psymbols): Update.
5974
5975 2019-05-04  Tom de Vries  <tdevries@suse.de>
5976
5977         * contrib/cc-with-tweaks.sh: Support -n arg.
5978
5979 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5980
5981         * corelow.c (core_target::detach): Ensure frame cache and
5982         register caches are cleared.
5983         inferior.c (exit_inferior_1): Likewise.
5984
5985 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5986             Tom Tromey  <tom@tromey.com>
5987
5988         * dictionary.c (collate_pending_symbols_by_language): Remove
5989         "struct" from foreach.
5990         * symtab.c (lookup_global_symbol_from_objfile)
5991         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5992         foreach.
5993         * ser-tcp.c (net_open): Remove "struct" from foreach.
5994         * objfiles.c (objfile_relocate, objfile_rebase)
5995         (objfile_has_symbols): Remove "struct" from foreach.
5996         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5997         from foreach.
5998         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5999         foreach.
6000         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6001         "struct" from foreach.
6002         * ada-lang.c (create_excep_cond_exprs)
6003         (ada_exception_catchpoint_cond_string): Remove "struct" from
6004         foreach.
6005
6006 2019-05-03  Tom Tromey  <tromey@adacore.com>
6007
6008         * ada-exp.y (convert_char_literal): Check suffix of each
6009         enumerator.
6010
6011 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6012
6013         PR ada/21406:
6014         * ada-exp.y (yywrap): Don't define.
6015         * ada-lex.l (%option): Add noyywrap
6016         (yywrap): Remove.
6017
6018 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6019
6020         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6021         _WIN32_WINNT to the XP level, unless already defined to a higher
6022         level.
6023
6024         * unittests/parse-connection-spec-selftests.c:
6025         * ser-tcp.c:
6026         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6027         override.
6028
6029         * symfile.c (find_separate_debug_file): Remove colon from the
6030         drive spec of DOS/Windows file names of the target, so that the
6031         file name produced from DEBUGDIR and the target's directory will
6032         be valid on DOS/Windows systems.
6033
6034 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * rust-lang.c (val_print_struct): Handle printing structures
6037         containing strings.
6038
6039 2019-05-02  Tom Tromey  <tromey@adacore.com>
6040
6041         * valarith.c (_initialize_valarith): Remove.
6042
6043 2019-05-01  Tom Tromey  <tromey@adacore.com>
6044
6045         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6046         bitfields.
6047
6048 2019-05-01  Tom Tromey  <tromey@adacore.com>
6049
6050         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6051         for big-endian copies.
6052
6053 2019-04-30  Ali Tamur  <tamur@google.com>
6054         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6055         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6056         (read_3_bytes): New function.
6057
6058 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6059
6060         * windows-nat.c (main_thread_id): Delete.
6061         (handle_output_debug_string): Replace main_thread_id by
6062         current_event.dwThreadId.
6063         (fake_create_process): Likewise.
6064         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6065         Do not set main_thread_id.
6066         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6067         current_event.dwThreadId.
6068         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6069
6070 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6071
6072         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6073         Use current_event.dwThreadId instead of main_thread_id.
6074
6075 2019-04-30  Tom Tromey  <tromey@adacore.com>
6076
6077         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6078         (create_excep_cond_exprs): Iterate over program spaces.
6079         (ada_exception_catchpoint_cond_string): Examine all minimal
6080         symbols for exception types.
6081
6082 2019-04-30  Tom Tromey  <tromey@adacore.com>
6083
6084         PR c++/24470:
6085         * dwarf2read.c (process_structure_scope): Handle case where type
6086         has template parameters but no symbol was created.
6087
6088 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6089             Chris January  <chris.january@arm.com>
6090
6091         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6092         qualifier.
6093         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6094
6095 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * f-typeprint.c (f_print_type): Update rules for printing
6098         whitespace.
6099         (f_type_print_varspec_suffix): Likewise.
6100
6101 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6102             Chris January  <chris.january@arm.com>
6103
6104         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6105         function arguments.
6106
6107 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6108
6109         * f-lang.c (build_fortran_types): Change name of void type to
6110         lower case.
6111         * f-typeprint.c (f_type_print_base): Print the name of the void
6112         type, rather than a fixed string.
6113         * f-valprint.c (f_decorations): Use lower case void string.
6114
6115 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6116             Chris January  <chris.january@arm.com>
6117
6118         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6119         types for Fortran.
6120
6121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6122             Chris January  <chris.january@arm.com>
6123             David Lecomber  <david.lecomber@arm.com>
6124
6125         * f-exp.y (BINOP_INTRINSIC): New token.
6126         (exp): New parser rule handling BINOP_INTRINSIC.
6127         (f77_keywords): Add new builtin procedures.
6128         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6129         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6130         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6131         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6132         (print_unop_subexp_f): New function.
6133         (print_binop_subexp_f): New function.
6134         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6135         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6136         (dump_subexp_body_f): Likewise.
6137         (operator_check_f): Likewise.
6138         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6139         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6140
6141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6142
6143         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6144         UNOP_KIND.
6145         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6146         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6147         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6148         (operator_length_f): New fuction.
6149         (print_subexp_f): New function.
6150         (op_name_f): New function.
6151         (dump_subexp_body_f): New function.
6152         (operator_check_f): New function.
6153         (exp_descriptor_f): Replace standard expression handling functions
6154         with new functions.
6155         * gdb/fortran-operator.def: New file.
6156         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6157         * gdb/std-operator.def: Remove UNOP_KIND.
6158
6159 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6160
6161         * std-operator.def: Remove unbalanced, stray double quote
6162         character.
6163
6164 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6165             Chris January  <chris.january@arm.com>
6166             Daniel Everett  <daniel.everett@arm.com>
6167             Nick Forrington  <nick.forrington@arm.com>
6168             Richard Bunt  <richard.bunt@arm.com>
6169
6170         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6171         of depth when printing anonymous structs or unions.
6172         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6173         Don't print either the top-level value, or the children if the
6174         max-depth is exceeded.
6175         (ppscm_print_children): When printing the key of a map, allow one
6176         extra level of depth.
6177         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6178         print either the top-level value, or the children if the max-depth
6179         is exceeded.
6180         (print_children): When printing the key of a map, allow one extra
6181         level of depth.
6182         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6183         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6184         (user_print_options): Initialise max_depth field.
6185         (val_print_scalar_or_string_type_p): New function.
6186         (val_print): Check to see if the max depth has been reached.
6187         (val_print_check_max_depth): Define new function.
6188         (show_print_max_depth): New function.
6189         (_initialize_valprint): Add 'print max-depth' option.
6190         * valprint.h (struct value_print_options) <max_depth>: New field.
6191         (val_print_check_max_depth): Declare new function.
6192         * NEWS: Document new feature.
6193
6194 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6195
6196         * ada-lang.c (ada_language_defn): Initialise new field.
6197         * c-lang.c (c_is_string_type_p): New function.
6198         (c_language_defn): Initialise new field.
6199         (cplus_language_defn): Initialise new field.
6200         (asm_language_defn): Initialise new field.
6201         (minimal_language_defn): Initialise new field.
6202         * c-lang.h (c_is_string_type_p): Declare new function.
6203         * d-lang.c (d_language_defn): Initialise new field.
6204         * f-lang.c (f_is_string_type_p): New function.
6205         (f_language_defn): Initialise new field.
6206         * go-lang.c (go_is_string_type_p): New function.
6207         (go_language_defn): Initialise new field.
6208         * language.c (default_is_string_type_p): New function.
6209         (unknown_language_defn): Initialise new field.
6210         (auto_language_defn): Initialise new field.
6211         * language.h (struct language_defn) <la_is_string_type_p>: New
6212         member variable.
6213         (default_is_string_type_p): Declare new function.
6214         * m2-lang.c (m2_language_defn): Initialise new field.
6215         * objc-lang.c (objc_language_defn): Initialise new field.
6216         * opencl-lang.c (opencl_language_defn): Initialise new field.
6217         * p-lang.c (pascal_is_string_type_p): New function.
6218         (pascal_language_defn): Initialise new field.
6219         * rust-lang.c (rust_is_string_type_p): New function.
6220         (rust_language_defn): Initialise new field.
6221
6222 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6223
6224         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6225         New field.
6226         * ada-lang.c (ada_language_defn): Initialise new field.
6227         * c-lang.c (c_language_defn): Likewise.
6228         (cplus_language_defn): Likewise.
6229         (asm_language_defn): Likewise.
6230         (minimal_language_defn): Likewise.
6231         * d-lang.c (d_language_defn): Likewise.
6232         * f-lang.c (f_language_defn): Likewise.
6233         * go-lang.c (go_language_defn): Likewise.
6234         * language.c (unknown_language_defn): Likewise.
6235         (auto_language_defn): Likewise.
6236         * m2-lang.c (m2_language_defn): Likewise.
6237         * objc-lang.c (objc_language_defn): Likewise.
6238         * opencl-lang.c (opencl_language_defn): Likewise.
6239         * p-lang.c (pascal_language_defn): Likewise.
6240         * rust-lang.c (rust_language_defn): Likewise.
6241
6242 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * ada-lang.c (ada_is_character_type): Change return type to bool.
6245         (ada_is_string_type): Likewise.
6246         * ada-lang.h (ada_is_character_type): Update declaration
6247         (ada_is_string_type): Likewise.
6248
6249 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6250
6251         Support style in 'frame|thread apply'
6252
6253         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6254         * record.c (record_start, record_stop): Update callers of
6255         execute_command_to_string with false.
6256         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6257         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6258         methods.
6259         (class string_file): New constructor with term_out parameter.
6260         Override methods term_out and can_emit_style_escape.  New member
6261         term_out.
6262         (class stdio_file): Override can_emit_style_escape.
6263         (class tee_file): Override term_out and can_emit_style_escape.
6264         * utils.h (can_emit_style_escape): Remove.
6265         * utils.c (can_emit_style_escape): Likewise.
6266         Update all callers of can_emit_style_escape (SOMESTREAM) to
6267         SOMESTREAM->can_emit_style_escape.
6268         * source-cache.c (source_cache::get_source_lines): Likewise.
6269         * stack.c (frame_apply_command_count): Call execute_command_to_string
6270         passing the term_out characteristic of the current gdb_stdout.
6271         * thread.c (thr_try_catch_cmd): Likewise.
6272         * top.c (execute_command_to_string): pass term_out parameter
6273         to construct the string_file for the command output.
6274         * ui-file.c (term_cli_styling): New function (most code moved
6275         from utils.c can_emit_style_escape).
6276         (string_file::string_file, string_file::can_emit_style_escape,
6277         stdio_file::can_emit_style_escape, tee_file::term_out,
6278         tee_file::can_emit_style_escape): New functions.
6279
6280 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6281
6282         * NEWS: Mention the new set|show may-call-functions.
6283         * infcall.c (may_call_functions_p): New variable.
6284         (show_may_call_functions_p): New function.
6285         (call_function_by_hand_dummy): Throws an error if not
6286         may-call-functions.
6287         (_initialize_infcall): Call add_setshow_boolean_cmd for
6288         may-call-functions.
6289
6290 2019-04-25  Keith Seitz  <keiths@redhat.com>
6291
6292         PR c++/24367
6293         * cp-support.c (inspect_type): Don't attempt substitutions
6294         of symbol with the same name.
6295
6296 2019-04-25  Tom Tromey  <tromey@adacore.com>
6297
6298         PR gdb/24475:
6299         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6300         static.
6301
6302 2019-04-25  Tom Tromey  <tromey@adacore.com>
6303
6304         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6305         rvalue reference.
6306         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6307         (gdb_xml_parser::parse): Use std::move.
6308         * python/python-internal.h (gdbpy_convert_exception): Take a const
6309         reference.
6310         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6311         std::move.
6312         * python/py-utils.c (gdbpy_convert_exception): Take a const
6313         reference.
6314         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6315         Use std::move.
6316         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6317         Use std::move.
6318         * mi/mi-main.c (mi_print_exception): Take a const reference.
6319         * main.c (handle_command_errors): Take a const reference.
6320         * linespec.c (parse_linespec): Use std::move.
6321         * infcall.c (run_inferior_call): Use std::move.
6322         (call_function_by_hand_dummy): Use std::move.
6323         * exec.c (try_open_exec_file): Use std::move.
6324         * exceptions.h (exception_print, exception_fprintf)
6325         (exception_print_same): Update.
6326         * exceptions.c (print_exception, exception_print)
6327         (exception_fprintf, exception_print_same): Change parameters to
6328         const reference.
6329         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6330         * common/new-op.c: Use std::move.
6331         * common/common-exceptions.h (struct gdb_exception): Add move
6332         constructor.
6333         (struct gdb_exception_error, struct gdb_exception_quit, struct
6334         gdb_quit_bad_alloc): Change constructor to move constructor.
6335         (throw_exception): Change parameter to rvalue reference.
6336         * common/common-exceptions.c (throw_exception): Take rvalue
6337         reference.
6338         * cli/cli-interp.c (safe_execute_command): Use std::move.
6339         * breakpoint.c (insert_bp_location, location_to_sals): Use
6340         std::move.
6341
6342 2019-04-25  Tom Tromey  <tromey@adacore.com>
6343
6344         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6345         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6346         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6347         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6348         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6349         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6350         guile/scm-value.c: Use unpack.
6351         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6352         gdbscm_gdb_exception.
6353         (gdbscm_throw_gdb_exception): Likewise.
6354         (struct gdbscm_gdb_exception): New.
6355         (unpack): New function.
6356         (gdbscm_wrap): Use unpack.
6357
6358 2019-04-25  Tom Tromey  <tromey@adacore.com>
6359
6360         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6361         (gdb_rl_callback_handler): Use std::move.
6362         * common/common-exceptions.h (struct gdb_exception): Add move
6363         assignment operator.
6364         (throw_exception_sjlj): Change "exception" to const reference.
6365         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6366         (throw_exception_sjlj): Change "exception" to const reference.
6367
6368 2019-04-25  Tom Tromey  <tromey@adacore.com>
6369
6370         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6371         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6372         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6373         Update.
6374         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6375         Update.
6376         * mi/mi-interp.c (mi_interp::exec): Update.
6377         * linespec.c (parse_linespec): Update.
6378         * infcall.c (run_inferior_call): Update.
6379         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6380         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6381         (gdbscm_lookup_global_symbol): Update.
6382         * guile/scm-param.c (gdbscm_parameter_value): Update.
6383         * guile/scm-frame.c (gdbscm_frame_read_register)
6384         (gdbscm_frame_read_var): Update.
6385         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6386         * exec.c (try_open_exec_file): Update.
6387         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6388         (gdb_rl_callback_handler): Update.
6389         * common/common-exceptions.h (exception_none): Don't declare.
6390         * common/common-exceptions.c (exception_none): Don't define.
6391         (struct catcher) <exception>: Update.
6392         * cli/cli-interp.c (safe_execute_command): Update.
6393         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6394
6395 2019-04-25  Ali Tamur  <tamur@google.com>
6396
6397         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6398         (read_attribute_value): Likewise.
6399         (dwarf2_read_addr_index): Update comment.
6400         (read_str_index): Add DW_FORM_strx.
6401         (dwarf2_string_attr): Likewise.
6402         (dwarf2_const_value_attr): Likewise.
6403         (dump_die_shallow): Likewise.
6404         (dwarf2_fetch_constant_bytes): Likewise.
6405         (skip_form_bytes): Likewise.
6406         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6407
6408 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6409
6410         PR corefiles/11608
6411         PR corefiles/18187
6412         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6413         OFFSET.  Verify if current mapping contains an ELF header.
6414         (linux_find_memory_regions_full): Adjust call to
6415         dump_mapping_p.
6416
6417 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6418             Kang Li <kanglictf@gmail.com>
6419
6420         PR gdb/21600
6421
6422         * dwarf2-frame.c (read_initial_length): Be consistent about using
6423         unsigned representation of length.
6424         (decode_frame_entry_1): Likewise.  Check for wraparound of
6425         end pointer as well as buffer overflow.
6426
6427 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6428
6429         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6430         "vq".
6431
6432 2019-04-24  Tom Tromey  <tromey@adacore.com>
6433
6434         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6435
6436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6437
6438         * s12z-tdep.c (s12z_unwind_pc): Delete.
6439         (s12z_unwind_sp): Delete.
6440         (s12z_gdbarch_init): Don't register deleted functions with
6441         gdbarch.
6442
6443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * rl78-tdep.c (rl78_unwind_sp): Delete.
6446         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6447
6448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6449
6450         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6451         (xstormy16_unwind_pc): Delete.
6452         (xstormy16_dummy_id): Delete.
6453         (xstormy16_gdbarch_init): Don't register deleted functions with
6454         gdbarch.
6455
6456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         * vax-tdep.c (vax_unwind_pc): Delete.
6459         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6460
6461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6462
6463         * v850-tdep.c (v850_unwind_sp): Delete.
6464         (v850_unwind_pc): Delete.
6465         (v850_dummy_id): Delete.
6466         (v850_gdbarch_init): Don't register deleted functions with
6467         gdbarch.
6468
6469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6470
6471         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6472         (tilegx_unwind_pc): Delete.
6473         (tilegx_unwind_dummy_id): Delete.
6474         (tilegx_gdbarch_init): Don't register deleted functions with
6475         gdbarch.
6476
6477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6480         (tic6x_dummy_id): Delete.
6481         (tic6x_gdbarch_init): Don't register deleted functions with
6482         gdbarch.
6483
6484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6485
6486         * sparc-tdep.c (sparc_unwind_pc): Delete.
6487         (sparc32_gdbarch_init): Don't register deleted function with
6488         gdbarch.
6489
6490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6491
6492         * sh-tdep.c (sh_unwind_sp): Delete.
6493         (sh_unwind_pc): Delete.
6494         (sh_dummy_id): Delete.
6495         (sh_gdbarch_init): Don't register deleted functions with
6496         gdbarch.
6497
6498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6499
6500         * score-tdep.c (score_unwind_sp): Delete.
6501         (score_unwind_pc): Delete.
6502         (score_dummy_id): Delete.
6503         (score_gdbarch_init): Don't register deleted functions with
6504         gdbarch.
6505
6506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6507
6508         * rx-tdep.c (rx_unwind_pc): Delete.
6509         (rx_unwind_sp): Delete.
6510         (rx_dummy_id): Delete.
6511         (rx_gdbarch_init): Don't register deleted functions with
6512         gdbarch.  Update comment.
6513
6514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6517         (rs6000_dummy_id): Delete.
6518         (rs6000_gdbarch_init): Don't register deleted functions with
6519         gdbarch.
6520
6521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6522
6523         * or1k-tdep.c (or1k_dummy_id): Delete.
6524         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6525
6526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * nios2-tdep.c (nios2_dummy_id): Delete.
6529         (nios2_unwind_sp): Delete.
6530         (nios2_gdbarch_init): Don't register deleted functions with
6531         gdbarch.
6532
6533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6534
6535         * nds32-tdep.c (nds32_dummy_id): Delete.
6536         (nds32_unwind_pc): Delete.
6537         (nds32_unwind_sp): Delete.
6538         (nds32_gdbarch_init): Don't register deleted functions with
6539         gdbarch.
6540
6541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6542
6543         * msp430-tdep.c (msp430_unwind_pc): Delete.
6544         (msp430_unwind_sp): Delete.
6545         (msp430_dummy_id): Delete.
6546         (msp430_gdbarch_init): Don't register deleted functions with
6547         gdbarch.
6548
6549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * moxie-tdep.c (moxie_unwind_sp): Delete.
6552         (moxie_unwind_pc): Delete.
6553         (moxie_dummy_id): Delete.
6554         (moxie_gdbarch_init): Don't register deleted functions with
6555         gdbarch.
6556
6557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6558
6559         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6560         (mn10300_unwind_pc): Delete.
6561         (mn10300_unwind_sp): Delete.
6562         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6563         mn10300_unwind_sp.
6564         (mn10300_frame_unwind_init): Don't register deleted functions with
6565         gdbarch.
6566
6567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         * mep-tdep.c (mep_unwind_pc): Delete.
6570         (mep_unwind_sp): Delete.
6571         (mep_dummy_id): Delete.
6572         (mep_gdbarch_init): Don't register deleted functions with
6573         gdbarch.
6574
6575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6576
6577         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6578         (m68hc11_unwind_sp): Delete.
6579         (m68hc11_gdbarch_init): Don't register deleted functions with
6580         gdbarch.
6581
6582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         * m32r-tdep.c (m32r_unwind_sp): Delete.
6585         (m32r_unwind_pc): Delete.
6586         (m32r_dummy_id): Delete.
6587         (m32r_gdbarch_init): Don't register deleted functions with
6588         gdbarch.
6589
6590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6591
6592         * m32c-tdep.c (m32c_unwind_pc): Delete.
6593         (m32c_unwind_sp): Delete.
6594         (m32c_dummy_id): Delete.
6595         (m32c_gdbarch_init): Don't register deleted functions with
6596         gdbarch.
6597
6598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6599
6600         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6601         (lm32_unwind_pc): Delete.
6602         (lm32_dummy_id): Delete.
6603         (lm32_gdbarch_init): Don't register deleted functions with
6604         gdbarch.
6605
6606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6607
6608         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6609         (iq2000_unwind_pc): Delete.
6610         (iq2000_dummy_id): Delete.
6611         (iq2000_gdbarch_init): Don't register deleted functions with
6612         gdbarch.
6613
6614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6615
6616         * nds32-tdep.c (nds32_type_align): Delete.
6617         (nds32_push_dummy_call): Use type_align instead.
6618
6619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * arm-tdep.c (arm_type_align): Only handle vector override case.
6622         (arm_push_dummy_call): Use type_align.
6623         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6624
6625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6628         case.
6629         (pass_on_stack): Use type_align.
6630         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6631         function.
6632
6633 2019-04-23  Tom Tromey  <tromey@adacore.com>
6634
6635         * dwarf2read.c (line_header::file_name_at): Remove unused
6636         overload.
6637
6638 2019-04-23  Tom de Vries  <tdevries@suse.de>
6639
6640         PR gdb/24438
6641         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6642         invocation.
6643
6644
6645 2019-03-27  Ali Tamur  <tamur@google.com>
6646
6647         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6648         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6649         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6650         (dwarf_expr_context::get_addr_index): Likewise
6651         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6652         (symbol_needs_eval_context::get_addr_index): Likewise
6653         (disassemble_dwarf_expression): Add DW_OP_addrx
6654         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6655         (read_cutu_die_from_dwo): Update comment
6656         (skip_one_die): Add DW_FORM_addrx
6657         (read_attribute_value): Likewise
6658         (var_decode_location): Add DW_OP_addrx
6659         (dwarf2_const_value_attr): Add DW_FORM_addrx
6660         (dump_die_shallow): Likewise
6661         (dwarf2_fetch_constant_bytes): Likewise
6662         (decode_locdesc): Add DW_OP_addrx
6663         (skip_form_bytes): Add DW_FORM_addrx
6664
6665 2019-04-22  Ali Tamur  <tamur@google.com>
6666
6667         * MAINTAINERS (Write After Approval): Add self.
6668
6669 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6670
6671         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6672         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6673         (open_symbol_file_object): Likewise.
6674         (svr4_default_sos): Add info parameter.
6675         (svr4_read_so_list): Likewise.
6676         (svr4_current_sos_direct): Adjust functions calls to pass down
6677         info.
6678         (svr4_current_sos_1): Add info parameter.
6679         (svr4_current_sos): Call get_svr4_info, pass info down to
6680         svr4_current_sos_1.
6681         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6682         get_svr4_info.
6683         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6684         get_svr4_info.
6685         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6686         to get_svr4_info.
6687         (probes_table_remove_objfile_probes): Likewise.
6688         (register_solib_event_probe): Add info parameter.
6689         (solist_update_incremental): Pass info parameter down to
6690         svr4_read_so_list.
6691         (disable_probes_interface): Add info parameter.
6692         (svr4_handle_solib_event): Pass current_program_space to
6693         get_svr4_info.  Adjust disable_probes_interface cleanup.
6694         (svr4_create_probe_breakpoints): Add info parameter, pass it
6695         down to register_solib_event_probe.
6696         (svr4_create_solib_event_breakpoints): Add info parameter,
6697         pass it down to svr4_create_probe_breakpoints.
6698         (enable_break): Pass info down to
6699         svr4_create_solib_event_breakpoints.
6700         (svr4_solib_create_inferior_hook): Pass current_program_space to
6701         get_svr4_info.
6702         (svr4_clear_solib): Likewise.
6703
6704 2019-04-22  Pedro Alves  <palves@redhat.com>
6705
6706         * solib-svr4.c (svr4_free_objfile_observer): New.
6707         (probe_and_action::objfile): New field.
6708         (probes_table_htab_remove_objfile_probes)
6709         (probes_table_remove_objfile_probes): New functions.
6710         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6711         in the new probe_and_action.  Don't store the probe in 'lookup'.
6712         (svr4_create_probe_breakpoints): Pass objfile to
6713         register_solib_event_probe.
6714         (_initialize_svr4_solib): Register a free_objfile observer.
6715
6716 2019-04-19  Tom Tromey  <tom@tromey.com>
6717
6718         * common/queue.h: Remove.
6719
6720 2019-04-19  Tom Tromey  <tom@tromey.com>
6721
6722         * event-loop.c: Don't include "common/queue.h".
6723
6724 2019-04-19  Tom Tromey  <tom@tromey.com>
6725
6726         * remote.c (remote_target): Use delete.
6727         * remote-notif.h: Include <list>, not "common/queue.h".
6728         (notif_client_p): Remove typedef.
6729         (remote_notif_state): Add constructor, destructor, initializer.
6730         <notif_queue>: Now a std::list.
6731         (remote_notif_state_xfree): Don't declare.
6732         * remote-notif.c (remote_notif_process, handle_notification)
6733         (remote_notif_state_allocate): Update.
6734         (~remote_notif_state): Rename from remote_notif_state_xfree.
6735
6736 2019-04-19  Tom Tromey  <tom@tromey.com>
6737
6738         * symfile.c (reread_symbols): Update.
6739         * objfiles.c (objfile_register_static_link)
6740         (objfile_lookup_static_link): Update
6741         (~objfile) Don't delete static_links.
6742         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6743
6744 2019-04-19  Tom Tromey  <tom@tromey.com>
6745
6746         * type-stack.h (struct type_stack) <insert>: Constify string.
6747         * type-stack.c (type_stack::insert): Constify string.
6748         * gdbtypes.h (lookup_template_type): Update.
6749         (address_space_name_to_int): Update.
6750         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6751         const.
6752         (lookup_template_type): Make name const.
6753         * c-exp.y: Update rules.
6754         (lex_one_token, classify_name, classify_inner_name)
6755         (c_print_token): Update.
6756         * p-exp.y: Update rules.
6757         (yylex): Update.
6758         * f-exp.y: Update rules.
6759         (yylex): Update.
6760         * d-exp.y: Update rules.
6761         (lex_one_token, classify_name, classify_inner_name): Update.
6762         * parse.c (write_dollar_variable, copy_name): Return std::string.
6763         * parser-defs.h (copy_name): Change return type.
6764         * m2-exp.y: Update rules.
6765         (yylex): Update.
6766         * go-exp.y (lex_one_token): Update.
6767         Update rules.
6768         (classify_unsafe_function, classify_packaged_name)
6769         (classify_name, yylex): Update.
6770
6771 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6772
6773         * configure.ac: add --enable-source-highlight switch.
6774         * configure: Regenerate.
6775         * top.c (print_gdb_version): plumb --enable-source-highlight
6776         status to "show configuration".
6777
6778 2019-04-19  Tom Tromey  <tromey@adacore.com>
6779
6780         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6781         Check ADA_TYPE_P.
6782         (empty_record, ada_template_to_fixed_record_type_1)
6783         (template_to_static_fixed_type)
6784         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6785         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6786         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6787         macros.
6788
6789 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6790
6791         PR symtab/24423:
6792         * source.c (print_source_lines_base): Advance "iter" when a
6793         control character is seen.
6794
6795 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * inferior.h (struct infcall_suspend_state_deleter):
6798         Catch exception in destructor to avoid crash.
6799
6800 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6801
6802         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6803         close to the add_com "shell".
6804
6805 2019-04-18  Tom Tromey  <tromey@adacore.com>
6806
6807         * process-stratum-target.h (class process_stratum_target)
6808         <stratum>: Add "final".
6809
6810 2019-04-17  Tom Tromey  <tromey@adacore.com>
6811
6812         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6813         against nullptr before use.
6814
6815 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6816
6817         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6818
6819 2019-04-17  Jim Wilson  <jimw@sifive.com>
6820             Andrew Burgess  <andrew.burgess@embecosm.com>
6821
6822         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6823         code read might fail, assume 4-byte breakpoint in that case.
6824
6825 2019-04-15  Leszek Swirski  <leszeks@google.com>
6826
6827         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6828         rather than a hand-rolled POD check when checking for forced MEMORY
6829         classification.
6830
6831 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6832
6833         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6834         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6835         function.
6836         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6837         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6838         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6839         declaration.
6840
6841 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6842
6843         * aarch64-linux-nat.c
6844         (aarch64_linux_nat_target::thread_architecture): Add override.
6845         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6846         each VQ.
6847
6848 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6849
6850         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6851
6852 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6853
6854         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6855         target types of size 96-bits, add some additional comments, and
6856         check that the builtin type we found was the correct size.
6857
6858 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6859
6860         * utils.c (prompt_for_continue): Don't restore the styling at the
6861         end, as applied_style has the wrong value.  This fixes styling in
6862         long lists of file names that are interrupted by the "Continue?"
6863         prompt.
6864
6865 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6866
6867         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6868         * c-lang.c (c_language_defn): Likewise.
6869         (cplus_language_defn): Likewise.
6870         (asm_language_defn): Likewise.
6871         (minimal_language_defn): Likewise.
6872         * d-lang.c (d_language_defn): Likewise.
6873         * f-lang.c (f_language_defn): Likewise.
6874         * go-lang.c (go_language_defn): Likewise.
6875         * language.c (unknown_language_defn): Likewise.
6876         (auto_language_defn): Likewise.
6877         * language.h (struct language_defn): Remove la_magic field.
6878         (LANG_MAGIC): Delete.
6879         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6880         * objc-lang.c (objc_language_defn): Likewise.
6881         * opencl-lang.c (opencl_language_defn): Likewise.
6882         * p-lang.c (pascal_language_defn): Likewise.
6883         * rust-lang.c (rust_language_defn): Likewise.
6884
6885 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * riscv-tdep.c (riscv_type_align): New function.
6888         (riscv_type_alignment): Delete.
6889         (riscv_arg_location): Use 'type_align'.
6890         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6891
6892 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6893
6894         * gdbtypes.c (type_align): A struct with no non-static fields also
6895         has alignment of 1.
6896
6897 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6898
6899         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6900         component to 0.
6901         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6902         member.
6903         (riscv_struct_info::analyse): New implementation using new
6904         analyse_inner member function.
6905         (riscv_struct_info::field_offset): New member function.
6906         (riscv_struct_info::m_offsets): New member variable.
6907         (riscv_struct_info::analyse_inner): New private member function,
6908         takes the old implementation of riscv_struct_info::analyse but
6909         extended to track field offsets.
6910         (riscv_call_arg_struct): Update the struct folding special cases
6911         to handle cases where empty C++ structs, which are non-zero
6912         length, are found.
6913         (riscv_arg_location): Initialise the length of each location, a
6914         non-zero length now indicates the location is in use.
6915         (riscv_push_dummy_call): Allow for the first location having a
6916         non-zero offset when setting up arguments.
6917         (riscv_return_value): Likewise, but for return values.
6918
6919 2019-04-11  Tom Tromey  <tromey@adacore.com>
6920
6921         * utils.c (internal_vproblem): Make "msg" const.
6922
6923 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6924
6925         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6926         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6927         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6928         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6929
6930 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6931
6932         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6933         function.
6934         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6935         of amd64_collect_native_gregset.
6936         (amd64_linux_nat_target::store_registers): Likewise.
6937
6938 2019-04-10  Tom Tromey  <tom@tromey.com>
6939
6940         * symtab.c (lookup_global_symbol_from_objfile)
6941         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6942         * objfiles.h (class separate_debug_iterator): New.
6943         (class separate_debug_range): New.
6944         (struct objfile) <separate_debug_objfiles>: New method.
6945         (objfile_separate_debug_iterate): Don't declare.
6946         * objfiles.c (separate_debug_iterator::operator++): Rename from
6947         objfile_separate_debug_iterate.
6948         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6949         iterator.
6950         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6951         iterator.
6952
6953 2019-04-10  Tom Tromey  <tom@tromey.com>
6954
6955         * symfile.c (reread_symbols): Remove old comment.
6956         * objfiles.c (free_all_objfiles): Fix a typo.
6957
6958 2019-04-10  Tom Tromey  <tom@tromey.com>
6959
6960         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6961         * minsyms.c (lookup_minimal_symbol): Use foreach.
6962         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6963         (lookup_minimal_symbol_solib_trampoline): Likewise.
6964         * symfile.c (reread_symbols): Use foreach.
6965
6966 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6967             Tom Tromey  <tromey@adacore.com>
6968
6969         PR rust/24414:
6970         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6971         (rust_lex_int_test): Change "value" to be LONGEST.
6972         (rust_lex_tests): Add test for long integer literal.
6973
6974 2019-04-09  Tom Tromey  <tromey@adacore.com>
6975
6976         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6977         to bool.
6978         (extended_remote_target::attach): Update.
6979         (remote_target::remote_notice_new_inferior): Update.
6980         (remote_target::add_current_inferior_and_thread): Update.
6981         * inferior.c (exit_inferior_1): Use "false".
6982         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6983
6984 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6985
6986         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6987         the "start" command.
6988
6989 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6990
6991         * python/py-inferior.c (infpy_thread_from_thread_handle):
6992         Adjust comments to reflect renaming of thread_from_thread_handle
6993         to thread_from_handle.  Adjust keywords.  Fix type error message.
6994         (inferior_object_methods): Add thread_from_handle.  Retain
6995         thread_from_thread_handle, but mark it as deprecated.
6996
6997 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6998
6999         * gdbthread.h (find_thread_by_handle): Revise declaration.
7000         * thread.c (find_thread_by_handle): Likewise.  Adjust
7001         implementation too.
7002         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7003         support for buffer objects as handles.
7004
7005 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7006
7007         * python/py-infthread.c (thpy_thread_handle): New function.
7008         (thread_object_methods): Register thpy_thread_handle.
7009
7010 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7011
7012         * gdbthread.h (thread_to_thread_handle): Declare.
7013         * thread.c (gdbtypes.h): Include.
7014         (thread_to_thread_handle): New function.
7015
7016         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7017         (target_thread_info_to_thread_handle): Declare.
7018         * target.c (target_thread_info_to_thread_handle): New function.
7019         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7020         * target-delegates.c: Regenerate.
7021
7022         * linux-thread-db.c (class thread_db_target): Add method
7023         thread_info_to_thread_handle.
7024         (thread_db_target::thread_info_to_thread_handle): Define.
7025         * remote.c (class remote_target): Add new method
7026         thread_info_to_thread_handle.
7027         (remote_target::thread_info_to_thread_handle): Define.
7028
7029 2019-04-08  Pedro Alves  <palves@redhat.com>
7030
7031         * common/common-exceptions.c (throw_exception): Don't create
7032         named object to throw; throw directly.
7033         (throw_it): Likewise.  Don't initialize gdb_exception::message
7034         here, with new; pass FMT and AP to the ctor instead.
7035         * common/common-exceptions.h: Include <string>.
7036         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7037         const char *, va_list)): New ctor.  Use std::make_shared.
7038         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7039         errors)): Delete.
7040         (gdb_exception_error::gdb_exception_error(enum errors, const char
7041         *, va_list)): New.
7042         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7043         Add assertion.
7044         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7045         errors)): Delete.
7046         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7047         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7048         Add assertion.
7049
7050 2019-04-08  Tom Tromey  <tom@tromey.com>
7051
7052         * valops.c (value_rtti_indirect_type): Replace throw_exception
7053         with throw.
7054         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7055         with throw.
7056         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7057         throw.
7058         * target.c (target_translate_tls_address): Replace throw_exception
7059         with throw.
7060         * stack.c (frame_apply_command_count): Replace throw_exception
7061         with throw.
7062         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7063         throw.
7064         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7065         with throw.
7066         * rs6000-tdep.c (rs6000_frame_cache)
7067         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7068         * remote.c: Replace throw_exception with throw.
7069         * record-full.c (record_full_message, record_full_wait_1)
7070         (record_full_restore): Replace throw_exception with throw.
7071         * record-btrace.c:
7072         (get_thread_current_frame_id, record_btrace_start_replaying)
7073         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7074         (cmd_record_btrace_start): Replace throw_exception with throw.
7075         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7076         throw.
7077         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7078         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7079         * linespec.c:
7080         (find_linespec_symbols): Replace throw_exception with throw.
7081         * infrun.c (displaced_step_prepare, resume): Replace
7082         throw_exception with throw.
7083         * infcmd.c (post_create_inferior): Replace throw_exception with
7084         throw.
7085         * inf-loop.c (inferior_event_handler): Replace throw_exception
7086         with throw.
7087         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7088         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7089         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7090         (get_prev_frame_always, get_frame_pc_if_available)
7091         (get_frame_address_in_block_if_available, get_frame_language):
7092         Replace throw_exception with throw.
7093         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7094         throw_exception with throw.
7095         * eval.c (fetch_subexp_value, evaluate_var_value)
7096         (evaluate_funcall, evaluate_subexp_standard): Replace
7097         throw_exception with throw.
7098         * dwarf2loc.c (call_site_find_chain)
7099         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7100         Replace throw_exception with throw.
7101         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7102         with throw.
7103         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7104         throw.
7105         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7106         * completer.c (complete_line_internal): Replace throw_exception
7107         with throw.
7108         * compile/compile-object-run.c (compile_object_run): Replace
7109         throw_exception with throw.
7110         * cli/cli-script.c (process_next_line): Replace throw_exception
7111         with throw.
7112         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7113         (btrace_enable, btrace_maint_update_pt_packets): Replace
7114         throw_exception with throw.
7115         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7116         throw_exception with throw.
7117         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7118         throw_exception with throw.
7119         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7120         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7121         * aarch64-tdep.c (aarch64_make_prologue_cache)
7122         (aarch64_make_stub_cache): Replace throw_exception with throw.
7123
7124 2019-04-08  Tom Tromey  <tom@tromey.com>
7125
7126         * common/common-exceptions.c (throw_exception): Rename from
7127         throw_exception_cxx.  Remove old copy.  Make argument const.
7128         (throw_it): Create and throw exception objects directly.
7129         * common/common-exceptions.h (throw_exception): Make argument
7130         const.
7131         (struct gdb_exception_error): Add constructor.
7132         (struct gdb_exception_quit): Add constructor.
7133
7134 2019-04-08  Tom Tromey  <tom@tromey.com>
7135
7136         * common/common-exceptions.h (exception_rethrow): Don't declare.
7137         (TRY_SJLJ): Update comment.
7138         (TRY, CATCH, END_CATCH): Remove.
7139         * common/common-exceptions.c (exception_rethrow): Remove.
7140
7141 2019-04-08  Tom Tromey  <tom@tromey.com>
7142
7143         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7144         Remove.
7145         (gdb_exception_error): Rename from
7146         gdb_exception_RETURN_MASK_ERROR.
7147         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7148         (gdb_quit_bad_alloc): Update.
7149         * aarch64-tdep.c: Update.
7150         * ada-lang.c: Update.
7151         * ada-typeprint.c: Update.
7152         * ada-valprint.c: Update.
7153         * amd64-tdep.c: Update.
7154         * arch-utils.c: Update.
7155         * break-catch-throw.c: Update.
7156         * breakpoint.c: Update.
7157         * btrace.c: Update.
7158         * c-varobj.c: Update.
7159         * cli/cli-cmds.c: Update.
7160         * cli/cli-interp.c: Update.
7161         * cli/cli-script.c: Update.
7162         * common/common-exceptions.c: Update.
7163         * common/new-op.c: Update.
7164         * common/selftest.c: Update.
7165         * compile/compile-c-symbols.c: Update.
7166         * compile/compile-cplus-symbols.c: Update.
7167         * compile/compile-object-load.c: Update.
7168         * compile/compile-object-run.c: Update.
7169         * completer.c: Update.
7170         * corelow.c: Update.
7171         * cp-abi.c: Update.
7172         * cp-support.c: Update.
7173         * cp-valprint.c: Update.
7174         * darwin-nat.c: Update.
7175         * disasm-selftests.c: Update.
7176         * dtrace-probe.c: Update.
7177         * dwarf-index-cache.c: Update.
7178         * dwarf-index-write.c: Update.
7179         * dwarf2-frame-tailcall.c: Update.
7180         * dwarf2-frame.c: Update.
7181         * dwarf2loc.c: Update.
7182         * dwarf2read.c: Update.
7183         * eval.c: Update.
7184         * event-loop.c: Update.
7185         * event-top.c: Update.
7186         * exec.c: Update.
7187         * f-valprint.c: Update.
7188         * fbsd-tdep.c: Update.
7189         * frame-unwind.c: Update.
7190         * frame.c: Update.
7191         * gdbtypes.c: Update.
7192         * gnu-v3-abi.c: Update.
7193         * guile/guile-internal.h: Update.
7194         * guile/scm-block.c: Update.
7195         * guile/scm-breakpoint.c: Update.
7196         * guile/scm-cmd.c: Update.
7197         * guile/scm-disasm.c: Update.
7198         * guile/scm-frame.c: Update.
7199         * guile/scm-lazy-string.c: Update.
7200         * guile/scm-math.c: Update.
7201         * guile/scm-param.c: Update.
7202         * guile/scm-ports.c: Update.
7203         * guile/scm-pretty-print.c: Update.
7204         * guile/scm-symbol.c: Update.
7205         * guile/scm-symtab.c: Update.
7206         * guile/scm-type.c: Update.
7207         * guile/scm-value.c: Update.
7208         * i386-linux-tdep.c: Update.
7209         * i386-tdep.c: Update.
7210         * inf-loop.c: Update.
7211         * infcall.c: Update.
7212         * infcmd.c: Update.
7213         * infrun.c: Update.
7214         * jit.c: Update.
7215         * language.c: Update.
7216         * linespec.c: Update.
7217         * linux-fork.c: Update.
7218         * linux-nat.c: Update.
7219         * linux-tdep.c: Update.
7220         * linux-thread-db.c: Update.
7221         * main.c: Update.
7222         * mi/mi-cmd-break.c: Update.
7223         * mi/mi-cmd-stack.c: Update.
7224         * mi/mi-interp.c: Update.
7225         * mi/mi-main.c: Update.
7226         * objc-lang.c: Update.
7227         * p-valprint.c: Update.
7228         * parse.c: Update.
7229         * ppc-linux-tdep.c: Update.
7230         * printcmd.c: Update.
7231         * python/py-arch.c: Update.
7232         * python/py-breakpoint.c: Update.
7233         * python/py-cmd.c: Update.
7234         * python/py-finishbreakpoint.c: Update.
7235         * python/py-frame.c: Update.
7236         * python/py-framefilter.c: Update.
7237         * python/py-gdb-readline.c: Update.
7238         * python/py-inferior.c: Update.
7239         * python/py-infthread.c: Update.
7240         * python/py-lazy-string.c: Update.
7241         * python/py-linetable.c: Update.
7242         * python/py-objfile.c: Update.
7243         * python/py-param.c: Update.
7244         * python/py-prettyprint.c: Update.
7245         * python/py-progspace.c: Update.
7246         * python/py-record-btrace.c: Update.
7247         * python/py-record.c: Update.
7248         * python/py-symbol.c: Update.
7249         * python/py-type.c: Update.
7250         * python/py-unwind.c: Update.
7251         * python/py-utils.c: Update.
7252         * python/py-value.c: Update.
7253         * python/python.c: Update.
7254         * record-btrace.c: Update.
7255         * record-full.c: Update.
7256         * remote-fileio.c: Update.
7257         * remote.c: Update.
7258         * riscv-tdep.c: Update.
7259         * rs6000-aix-tdep.c: Update.
7260         * rs6000-tdep.c: Update.
7261         * rust-exp.y: Update.
7262         * rust-lang.c: Update.
7263         * s390-tdep.c: Update.
7264         * selftest-arch.c: Update.
7265         * solib-dsbt.c: Update.
7266         * solib-frv.c: Update.
7267         * solib-spu.c: Update.
7268         * solib-svr4.c: Update.
7269         * solib.c: Update.
7270         * sparc64-linux-tdep.c: Update.
7271         * stack.c: Update.
7272         * symfile-mem.c: Update.
7273         * symmisc.c: Update.
7274         * target.c: Update.
7275         * thread.c: Update.
7276         * top.c: Update.
7277         * tracefile-tfile.c: Update.
7278         * tui/tui.c: Update.
7279         * typeprint.c: Update.
7280         * unittests/cli-utils-selftests.c: Update.
7281         * unittests/parse-connection-spec-selftests.c: Update.
7282         * valops.c: Update.
7283         * valprint.c: Update.
7284         * value.c: Update.
7285         * varobj.c: Update.
7286         * windows-nat.c: Update.
7287         * x86-linux-nat.c: Update.
7288         * xml-support.c: Update.
7289
7290 2019-04-08  Tom Tromey  <tom@tromey.com>
7291
7292         * xml-support.c: Use C++ exception handling.
7293         * x86-linux-nat.c: Use C++ exception handling.
7294         * windows-nat.c: Use C++ exception handling.
7295         * varobj.c: Use C++ exception handling.
7296         * value.c: Use C++ exception handling.
7297         * valprint.c: Use C++ exception handling.
7298         * valops.c: Use C++ exception handling.
7299         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7300         handling.
7301         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7302         * typeprint.c: Use C++ exception handling.
7303         * tui/tui.c: Use C++ exception handling.
7304         * tracefile-tfile.c: Use C++ exception handling.
7305         * top.c: Use C++ exception handling.
7306         * thread.c: Use C++ exception handling.
7307         * target.c: Use C++ exception handling.
7308         * symmisc.c: Use C++ exception handling.
7309         * symfile-mem.c: Use C++ exception handling.
7310         * stack.c: Use C++ exception handling.
7311         * sparc64-linux-tdep.c: Use C++ exception handling.
7312         * solib.c: Use C++ exception handling.
7313         * solib-svr4.c: Use C++ exception handling.
7314         * solib-spu.c: Use C++ exception handling.
7315         * solib-frv.c: Use C++ exception handling.
7316         * solib-dsbt.c: Use C++ exception handling.
7317         * selftest-arch.c: Use C++ exception handling.
7318         * s390-tdep.c: Use C++ exception handling.
7319         * rust-lang.c: Use C++ exception handling.
7320         * rust-exp.y: Use C++ exception handling.
7321         * rs6000-tdep.c: Use C++ exception handling.
7322         * rs6000-aix-tdep.c: Use C++ exception handling.
7323         * riscv-tdep.c: Use C++ exception handling.
7324         * remote.c: Use C++ exception handling.
7325         * remote-fileio.c: Use C++ exception handling.
7326         * record-full.c: Use C++ exception handling.
7327         * record-btrace.c: Use C++ exception handling.
7328         * python/python.c: Use C++ exception handling.
7329         * python/py-value.c: Use C++ exception handling.
7330         * python/py-utils.c: Use C++ exception handling.
7331         * python/py-unwind.c: Use C++ exception handling.
7332         * python/py-type.c: Use C++ exception handling.
7333         * python/py-symbol.c: Use C++ exception handling.
7334         * python/py-record.c: Use C++ exception handling.
7335         * python/py-record-btrace.c: Use C++ exception handling.
7336         * python/py-progspace.c: Use C++ exception handling.
7337         * python/py-prettyprint.c: Use C++ exception handling.
7338         * python/py-param.c: Use C++ exception handling.
7339         * python/py-objfile.c: Use C++ exception handling.
7340         * python/py-linetable.c: Use C++ exception handling.
7341         * python/py-lazy-string.c: Use C++ exception handling.
7342         * python/py-infthread.c: Use C++ exception handling.
7343         * python/py-inferior.c: Use C++ exception handling.
7344         * python/py-gdb-readline.c: Use C++ exception handling.
7345         * python/py-framefilter.c: Use C++ exception handling.
7346         * python/py-frame.c: Use C++ exception handling.
7347         * python/py-finishbreakpoint.c: Use C++ exception handling.
7348         * python/py-cmd.c: Use C++ exception handling.
7349         * python/py-breakpoint.c: Use C++ exception handling.
7350         * python/py-arch.c: Use C++ exception handling.
7351         * printcmd.c: Use C++ exception handling.
7352         * ppc-linux-tdep.c: Use C++ exception handling.
7353         * parse.c: Use C++ exception handling.
7354         * p-valprint.c: Use C++ exception handling.
7355         * objc-lang.c: Use C++ exception handling.
7356         * mi/mi-main.c: Use C++ exception handling.
7357         * mi/mi-interp.c: Use C++ exception handling.
7358         * mi/mi-cmd-stack.c: Use C++ exception handling.
7359         * mi/mi-cmd-break.c: Use C++ exception handling.
7360         * main.c: Use C++ exception handling.
7361         * linux-thread-db.c: Use C++ exception handling.
7362         * linux-tdep.c: Use C++ exception handling.
7363         * linux-nat.c: Use C++ exception handling.
7364         * linux-fork.c: Use C++ exception handling.
7365         * linespec.c: Use C++ exception handling.
7366         * language.c: Use C++ exception handling.
7367         * jit.c: Use C++ exception handling.
7368         * infrun.c: Use C++ exception handling.
7369         * infcmd.c: Use C++ exception handling.
7370         * infcall.c: Use C++ exception handling.
7371         * inf-loop.c: Use C++ exception handling.
7372         * i386-tdep.c: Use C++ exception handling.
7373         * i386-linux-tdep.c: Use C++ exception handling.
7374         * guile/scm-value.c: Use C++ exception handling.
7375         * guile/scm-type.c: Use C++ exception handling.
7376         * guile/scm-symtab.c: Use C++ exception handling.
7377         * guile/scm-symbol.c: Use C++ exception handling.
7378         * guile/scm-pretty-print.c: Use C++ exception handling.
7379         * guile/scm-ports.c: Use C++ exception handling.
7380         * guile/scm-param.c: Use C++ exception handling.
7381         * guile/scm-math.c: Use C++ exception handling.
7382         * guile/scm-lazy-string.c: Use C++ exception handling.
7383         * guile/scm-frame.c: Use C++ exception handling.
7384         * guile/scm-disasm.c: Use C++ exception handling.
7385         * guile/scm-cmd.c: Use C++ exception handling.
7386         * guile/scm-breakpoint.c: Use C++ exception handling.
7387         * guile/scm-block.c: Use C++ exception handling.
7388         * guile/guile-internal.h: Use C++ exception handling.
7389         * gnu-v3-abi.c: Use C++ exception handling.
7390         * gdbtypes.c: Use C++ exception handling.
7391         * frame.c: Use C++ exception handling.
7392         * frame-unwind.c: Use C++ exception handling.
7393         * fbsd-tdep.c: Use C++ exception handling.
7394         * f-valprint.c: Use C++ exception handling.
7395         * exec.c: Use C++ exception handling.
7396         * event-top.c: Use C++ exception handling.
7397         * event-loop.c: Use C++ exception handling.
7398         * eval.c: Use C++ exception handling.
7399         * dwarf2read.c: Use C++ exception handling.
7400         * dwarf2loc.c: Use C++ exception handling.
7401         * dwarf2-frame.c: Use C++ exception handling.
7402         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7403         * dwarf-index-write.c: Use C++ exception handling.
7404         * dwarf-index-cache.c: Use C++ exception handling.
7405         * dtrace-probe.c: Use C++ exception handling.
7406         * disasm-selftests.c: Use C++ exception handling.
7407         * darwin-nat.c: Use C++ exception handling.
7408         * cp-valprint.c: Use C++ exception handling.
7409         * cp-support.c: Use C++ exception handling.
7410         * cp-abi.c: Use C++ exception handling.
7411         * corelow.c: Use C++ exception handling.
7412         * completer.c: Use C++ exception handling.
7413         * compile/compile-object-run.c: Use C++ exception handling.
7414         * compile/compile-object-load.c: Use C++ exception handling.
7415         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7416         * compile/compile-c-symbols.c: Use C++ exception handling.
7417         * common/selftest.c: Use C++ exception handling.
7418         * common/new-op.c: Use C++ exception handling.
7419         * cli/cli-script.c: Use C++ exception handling.
7420         * cli/cli-interp.c: Use C++ exception handling.
7421         * cli/cli-cmds.c: Use C++ exception handling.
7422         * c-varobj.c: Use C++ exception handling.
7423         * btrace.c: Use C++ exception handling.
7424         * breakpoint.c: Use C++ exception handling.
7425         * break-catch-throw.c: Use C++ exception handling.
7426         * arch-utils.c: Use C++ exception handling.
7427         * amd64-tdep.c: Use C++ exception handling.
7428         * ada-valprint.c: Use C++ exception handling.
7429         * ada-typeprint.c: Use C++ exception handling.
7430         * ada-lang.c: Use C++ exception handling.
7431         * aarch64-tdep.c: Use C++ exception handling.
7432
7433 2019-04-08  Tom Tromey  <tom@tromey.com>
7434
7435         * xml-support.c (gdb_xml_parser::parse): Update.
7436         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7437         * value.c (show_convenience): Update.
7438         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7439         (test_parse_flags_qcs): Update.
7440         * thread.c (thr_try_catch_cmd): Update.
7441         * target.c (target_translate_tls_address): Update.
7442         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7443         (info_frame_command_core, frame_apply_command_count): Update.
7444         * rust-exp.y (rust_lex_exception_test): Update.
7445         * riscv-tdep.c (riscv_print_one_register_info): Update.
7446         * remote.c (remote_target::enable_btrace): Update.
7447         * record-btrace.c (record_btrace_enable_warn): Update.
7448         * python/py-utils.c (gdbpy_convert_exception): Update.
7449         * printcmd.c (do_one_display, print_variable_and_value): Update.
7450         * mi/mi-main.c (mi_print_exception): Update.
7451         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7452         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7453         * linux-nat.c (linux_nat_target::attach): Update.
7454         * linux-fork.c (class scoped_switch_fork_info): Update.
7455         * infrun.c (displaced_step_prepare): Update.
7456         * infcall.c (call_function_by_hand_dummy): Update.
7457         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7458         * gnu-v3-abi.c (print_one_vtable): Update.
7459         * frame.c (get_prev_frame_always): Update.
7460         * f-valprint.c (info_common_command_for_block): Update.
7461         * exec.c (try_open_exec_file): Update.
7462         * exceptions.c (print_exception, exception_print)
7463         (exception_fprintf, exception_print_same): Update.
7464         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7465         * dwarf-index-cache.c (index_cache::store)
7466         (index_cache::lookup_gdb_index): Update.
7467         * darwin-nat.c (maybe_cache_shell): Update.
7468         * cp-valprint.c (cp_print_value_fields): Update.
7469         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7470         (gcc_cplus_symbol_address): Update.
7471         * compile/compile-c-symbols.c (gcc_convert_symbol)
7472         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7473         * common/selftest.c: Update.
7474         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7475         a std::string.
7476         (exception_try_scope_entry, exception_try_scope_exit): Don't
7477         declare.
7478         (struct exception_try_scope): Remove.
7479         (TRY): Don't use exception_try_scope.
7480         (struct gdb_exception): Add constructor, operator=.
7481         <what>: New method.
7482         (struct gdb_exception_RETURN_MASK_ALL)
7483         (struct gdb_exception_RETURN_MASK_ERROR)
7484         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7485         (struct gdb_quit_bad_alloc): Update.
7486         * common/common-exceptions.c (exception_none): Change
7487         initializer.
7488         (struct catcher) <state, exception>: Initialize inline.
7489         <prev>: Remove member.
7490         (current_catcher): Remove.
7491         (catchers): New global.
7492         (exceptions_state_mc_init): Simplify.
7493         (catcher_pop): Remove.
7494         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7495         (try_scope_depth, exception_try_scope_entry)
7496         (exception_try_scope_exit): Remove.
7497         (throw_exception_sjlj): Update.
7498         (exception_messages, exception_messages_size): Remove.
7499         (throw_it): Simplify.
7500         (gdb_exception_sliced_copy): Remove.
7501         (throw_exception_cxx): Update.
7502         * cli/cli-script.c (script_from_file): Update.
7503         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7504         Update.
7505         * ada-valprint.c (ada_val_print): Update.
7506         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7507         (create_excep_cond_exprs): Update.
7508
7509 2019-04-08  Tom Tromey  <tom@tromey.com>
7510
7511         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7512         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7513         (TRY, CATCH, END_CATCH): Remove some definitions.
7514         * common/common-exceptions.c: Don't use GDB_XCPT.
7515         (catcher_list_size): Remove.
7516         (throw_exception, throw_it): Simplify.
7517
7518 2019-04-05  Tom Tromey  <tom@tromey.com>
7519
7520         Revert the header-sorting patch.
7521         * ft32-tdep.c: Revert.
7522         * frv-tdep.c: Revert.
7523         * frv-linux-tdep.c: Revert.
7524         * frame.c: Revert.
7525         * frame-unwind.c: Revert.
7526         * frame-base.c: Revert.
7527         * fork-child.c: Revert.
7528         * findvar.c: Revert.
7529         * findcmd.c: Revert.
7530         * filesystem.c: Revert.
7531         * filename-seen-cache.h: Revert.
7532         * filename-seen-cache.c: Revert.
7533         * fbsd-tdep.c: Revert.
7534         * fbsd-nat.h: Revert.
7535         * fbsd-nat.c: Revert.
7536         * f-valprint.c: Revert.
7537         * f-typeprint.c: Revert.
7538         * f-lang.c: Revert.
7539         * extension.h: Revert.
7540         * extension.c: Revert.
7541         * extension-priv.h: Revert.
7542         * expprint.c: Revert.
7543         * exec.h: Revert.
7544         * exec.c: Revert.
7545         * exceptions.c: Revert.
7546         * event-top.c: Revert.
7547         * event-loop.c: Revert.
7548         * eval.c: Revert.
7549         * elfread.c: Revert.
7550         * dwarf2read.h: Revert.
7551         * dwarf2read.c: Revert.
7552         * dwarf2loc.c: Revert.
7553         * dwarf2expr.h: Revert.
7554         * dwarf2expr.c: Revert.
7555         * dwarf2-frame.c: Revert.
7556         * dwarf2-frame-tailcall.c: Revert.
7557         * dwarf-index-write.h: Revert.
7558         * dwarf-index-write.c: Revert.
7559         * dwarf-index-common.c: Revert.
7560         * dwarf-index-cache.h: Revert.
7561         * dwarf-index-cache.c: Revert.
7562         * dummy-frame.c: Revert.
7563         * dtrace-probe.c: Revert.
7564         * disasm.h: Revert.
7565         * disasm.c: Revert.
7566         * disasm-selftests.c: Revert.
7567         * dictionary.c: Revert.
7568         * dicos-tdep.c: Revert.
7569         * demangle.c: Revert.
7570         * dcache.h: Revert.
7571         * dcache.c: Revert.
7572         * darwin-nat.h: Revert.
7573         * darwin-nat.c: Revert.
7574         * darwin-nat-info.c: Revert.
7575         * d-valprint.c: Revert.
7576         * d-namespace.c: Revert.
7577         * d-lang.c: Revert.
7578         * ctf.c: Revert.
7579         * csky-tdep.c: Revert.
7580         * csky-linux-tdep.c: Revert.
7581         * cris-tdep.c: Revert.
7582         * cris-linux-tdep.c: Revert.
7583         * cp-valprint.c: Revert.
7584         * cp-support.c: Revert.
7585         * cp-namespace.c: Revert.
7586         * cp-abi.c: Revert.
7587         * corelow.c: Revert.
7588         * corefile.c: Revert.
7589         * continuations.c: Revert.
7590         * completer.h: Revert.
7591         * completer.c: Revert.
7592         * complaints.c: Revert.
7593         * coffread.c: Revert.
7594         * coff-pe-read.c: Revert.
7595         * cli-out.h: Revert.
7596         * cli-out.c: Revert.
7597         * charset.c: Revert.
7598         * c-varobj.c: Revert.
7599         * c-valprint.c: Revert.
7600         * c-typeprint.c: Revert.
7601         * c-lang.c: Revert.
7602         * buildsym.c: Revert.
7603         * buildsym-legacy.c: Revert.
7604         * build-id.h: Revert.
7605         * build-id.c: Revert.
7606         * btrace.c: Revert.
7607         * bsd-uthread.c: Revert.
7608         * breakpoint.h: Revert.
7609         * breakpoint.c: Revert.
7610         * break-catch-throw.c: Revert.
7611         * break-catch-syscall.c: Revert.
7612         * break-catch-sig.c: Revert.
7613         * blockframe.c: Revert.
7614         * block.c: Revert.
7615         * bfin-tdep.c: Revert.
7616         * bfin-linux-tdep.c: Revert.
7617         * bfd-target.c: Revert.
7618         * bcache.c: Revert.
7619         * ax-general.c: Revert.
7620         * ax-gdb.h: Revert.
7621         * ax-gdb.c: Revert.
7622         * avr-tdep.c: Revert.
7623         * auxv.c: Revert.
7624         * auto-load.c: Revert.
7625         * arm-wince-tdep.c: Revert.
7626         * arm-tdep.c: Revert.
7627         * arm-symbian-tdep.c: Revert.
7628         * arm-pikeos-tdep.c: Revert.
7629         * arm-obsd-tdep.c: Revert.
7630         * arm-nbsd-tdep.c: Revert.
7631         * arm-nbsd-nat.c: Revert.
7632         * arm-linux-tdep.c: Revert.
7633         * arm-linux-nat.c: Revert.
7634         * arm-fbsd-tdep.c: Revert.
7635         * arm-fbsd-nat.c: Revert.
7636         * arm-bsd-tdep.c: Revert.
7637         * arch-utils.c: Revert.
7638         * arc-tdep.c: Revert.
7639         * arc-newlib-tdep.c: Revert.
7640         * annotate.h: Revert.
7641         * annotate.c: Revert.
7642         * amd64-windows-tdep.c: Revert.
7643         * amd64-windows-nat.c: Revert.
7644         * amd64-tdep.c: Revert.
7645         * amd64-sol2-tdep.c: Revert.
7646         * amd64-obsd-tdep.c: Revert.
7647         * amd64-obsd-nat.c: Revert.
7648         * amd64-nbsd-tdep.c: Revert.
7649         * amd64-nbsd-nat.c: Revert.
7650         * amd64-nat.c: Revert.
7651         * amd64-linux-tdep.c: Revert.
7652         * amd64-linux-nat.c: Revert.
7653         * amd64-fbsd-tdep.c: Revert.
7654         * amd64-fbsd-nat.c: Revert.
7655         * amd64-dicos-tdep.c: Revert.
7656         * amd64-darwin-tdep.c: Revert.
7657         * amd64-bsd-nat.c: Revert.
7658         * alpha-tdep.c: Revert.
7659         * alpha-obsd-tdep.c: Revert.
7660         * alpha-nbsd-tdep.c: Revert.
7661         * alpha-mdebug-tdep.c: Revert.
7662         * alpha-linux-tdep.c: Revert.
7663         * alpha-linux-nat.c: Revert.
7664         * alpha-bsd-tdep.c: Revert.
7665         * alpha-bsd-nat.c: Revert.
7666         * aix-thread.c: Revert.
7667         * agent.c: Revert.
7668         * addrmap.c: Revert.
7669         * ada-varobj.c: Revert.
7670         * ada-valprint.c: Revert.
7671         * ada-typeprint.c: Revert.
7672         * ada-tasks.c: Revert.
7673         * ada-lang.c: Revert.
7674         * aarch64-tdep.c: Revert.
7675         * aarch64-ravenscar-thread.c: Revert.
7676         * aarch64-newlib-tdep.c: Revert.
7677         * aarch64-linux-tdep.c: Revert.
7678         * aarch64-linux-nat.c: Revert.
7679         * aarch64-fbsd-tdep.c: Revert.
7680         * aarch64-fbsd-nat.c: Revert.
7681         * aarch32-linux-nat.c: Revert.
7682
7683 2019-04-05  Tom Tromey  <tom@tromey.com>
7684
7685         * ft32-tdep.c: Sort headers.
7686         * frv-tdep.c: Sort headers.
7687         * frv-linux-tdep.c: Sort headers.
7688         * frame.c: Sort headers.
7689         * frame-unwind.c: Sort headers.
7690         * frame-base.c: Sort headers.
7691         * fork-child.c: Sort headers.
7692         * findvar.c: Sort headers.
7693         * findcmd.c: Sort headers.
7694         * filesystem.c: Sort headers.
7695         * filename-seen-cache.h: Sort headers.
7696         * filename-seen-cache.c: Sort headers.
7697         * fbsd-tdep.c: Sort headers.
7698         * fbsd-nat.h: Sort headers.
7699         * fbsd-nat.c: Sort headers.
7700         * f-valprint.c: Sort headers.
7701         * f-typeprint.c: Sort headers.
7702         * f-lang.c: Sort headers.
7703         * extension.h: Sort headers.
7704         * extension.c: Sort headers.
7705         * extension-priv.h: Sort headers.
7706         * expprint.c: Sort headers.
7707         * exec.h: Sort headers.
7708         * exec.c: Sort headers.
7709         * exceptions.c: Sort headers.
7710         * event-top.c: Sort headers.
7711         * event-loop.c: Sort headers.
7712         * eval.c: Sort headers.
7713         * elfread.c: Sort headers.
7714         * dwarf2read.h: Sort headers.
7715         * dwarf2read.c: Sort headers.
7716         * dwarf2loc.c: Sort headers.
7717         * dwarf2expr.h: Sort headers.
7718         * dwarf2expr.c: Sort headers.
7719         * dwarf2-frame.c: Sort headers.
7720         * dwarf2-frame-tailcall.c: Sort headers.
7721         * dwarf-index-write.h: Sort headers.
7722         * dwarf-index-write.c: Sort headers.
7723         * dwarf-index-common.c: Sort headers.
7724         * dwarf-index-cache.h: Sort headers.
7725         * dwarf-index-cache.c: Sort headers.
7726         * dummy-frame.c: Sort headers.
7727         * dtrace-probe.c: Sort headers.
7728         * disasm.h: Sort headers.
7729         * disasm.c: Sort headers.
7730         * disasm-selftests.c: Sort headers.
7731         * dictionary.c: Sort headers.
7732         * dicos-tdep.c: Sort headers.
7733         * demangle.c: Sort headers.
7734         * dcache.h: Sort headers.
7735         * dcache.c: Sort headers.
7736         * darwin-nat.h: Sort headers.
7737         * darwin-nat.c: Sort headers.
7738         * darwin-nat-info.c: Sort headers.
7739         * d-valprint.c: Sort headers.
7740         * d-namespace.c: Sort headers.
7741         * d-lang.c: Sort headers.
7742         * ctf.c: Sort headers.
7743         * csky-tdep.c: Sort headers.
7744         * csky-linux-tdep.c: Sort headers.
7745         * cris-tdep.c: Sort headers.
7746         * cris-linux-tdep.c: Sort headers.
7747         * cp-valprint.c: Sort headers.
7748         * cp-support.c: Sort headers.
7749         * cp-namespace.c: Sort headers.
7750         * cp-abi.c: Sort headers.
7751         * corelow.c: Sort headers.
7752         * corefile.c: Sort headers.
7753         * continuations.c: Sort headers.
7754         * completer.h: Sort headers.
7755         * completer.c: Sort headers.
7756         * complaints.c: Sort headers.
7757         * coffread.c: Sort headers.
7758         * coff-pe-read.c: Sort headers.
7759         * cli-out.h: Sort headers.
7760         * cli-out.c: Sort headers.
7761         * charset.c: Sort headers.
7762         * c-varobj.c: Sort headers.
7763         * c-valprint.c: Sort headers.
7764         * c-typeprint.c: Sort headers.
7765         * c-lang.c: Sort headers.
7766         * buildsym.c: Sort headers.
7767         * buildsym-legacy.c: Sort headers.
7768         * build-id.h: Sort headers.
7769         * build-id.c: Sort headers.
7770         * btrace.c: Sort headers.
7771         * bsd-uthread.c: Sort headers.
7772         * breakpoint.h: Sort headers.
7773         * breakpoint.c: Sort headers.
7774         * break-catch-throw.c: Sort headers.
7775         * break-catch-syscall.c: Sort headers.
7776         * break-catch-sig.c: Sort headers.
7777         * blockframe.c: Sort headers.
7778         * block.c: Sort headers.
7779         * bfin-tdep.c: Sort headers.
7780         * bfin-linux-tdep.c: Sort headers.
7781         * bfd-target.c: Sort headers.
7782         * bcache.c: Sort headers.
7783         * ax-general.c: Sort headers.
7784         * ax-gdb.h: Sort headers.
7785         * ax-gdb.c: Sort headers.
7786         * avr-tdep.c: Sort headers.
7787         * auxv.c: Sort headers.
7788         * auto-load.c: Sort headers.
7789         * arm-wince-tdep.c: Sort headers.
7790         * arm-tdep.c: Sort headers.
7791         * arm-symbian-tdep.c: Sort headers.
7792         * arm-pikeos-tdep.c: Sort headers.
7793         * arm-obsd-tdep.c: Sort headers.
7794         * arm-nbsd-tdep.c: Sort headers.
7795         * arm-nbsd-nat.c: Sort headers.
7796         * arm-linux-tdep.c: Sort headers.
7797         * arm-linux-nat.c: Sort headers.
7798         * arm-fbsd-tdep.c: Sort headers.
7799         * arm-fbsd-nat.c: Sort headers.
7800         * arm-bsd-tdep.c: Sort headers.
7801         * arch-utils.c: Sort headers.
7802         * arc-tdep.c: Sort headers.
7803         * arc-newlib-tdep.c: Sort headers.
7804         * annotate.h: Sort headers.
7805         * annotate.c: Sort headers.
7806         * amd64-windows-tdep.c: Sort headers.
7807         * amd64-windows-nat.c: Sort headers.
7808         * amd64-tdep.c: Sort headers.
7809         * amd64-sol2-tdep.c: Sort headers.
7810         * amd64-obsd-tdep.c: Sort headers.
7811         * amd64-obsd-nat.c: Sort headers.
7812         * amd64-nbsd-tdep.c: Sort headers.
7813         * amd64-nbsd-nat.c: Sort headers.
7814         * amd64-nat.c: Sort headers.
7815         * amd64-linux-tdep.c: Sort headers.
7816         * amd64-linux-nat.c: Sort headers.
7817         * amd64-fbsd-tdep.c: Sort headers.
7818         * amd64-fbsd-nat.c: Sort headers.
7819         * amd64-dicos-tdep.c: Sort headers.
7820         * amd64-darwin-tdep.c: Sort headers.
7821         * amd64-bsd-nat.c: Sort headers.
7822         * alpha-tdep.c: Sort headers.
7823         * alpha-obsd-tdep.c: Sort headers.
7824         * alpha-nbsd-tdep.c: Sort headers.
7825         * alpha-mdebug-tdep.c: Sort headers.
7826         * alpha-linux-tdep.c: Sort headers.
7827         * alpha-linux-nat.c: Sort headers.
7828         * alpha-bsd-tdep.c: Sort headers.
7829         * alpha-bsd-nat.c: Sort headers.
7830         * aix-thread.c: Sort headers.
7831         * agent.c: Sort headers.
7832         * addrmap.c: Sort headers.
7833         * ada-varobj.c: Sort headers.
7834         * ada-valprint.c: Sort headers.
7835         * ada-typeprint.c: Sort headers.
7836         * ada-tasks.c: Sort headers.
7837         * ada-lang.c: Sort headers.
7838         * aarch64-tdep.c: Sort headers.
7839         * aarch64-ravenscar-thread.c: Sort headers.
7840         * aarch64-newlib-tdep.c: Sort headers.
7841         * aarch64-linux-tdep.c: Sort headers.
7842         * aarch64-linux-nat.c: Sort headers.
7843         * aarch64-fbsd-tdep.c: Sort headers.
7844         * aarch64-fbsd-nat.c: Sort headers.
7845         * aarch32-linux-nat.c: Sort headers.
7846
7847 2019-04-04  Tom Tromey  <tom@tromey.com>
7848
7849         * varobj.c (varobj_create): Update.
7850         * rust-exp.y (struct rust_parser) <update_innermost_block,
7851         lookup_symbol>: New methods.
7852         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7853         Rename.
7854         (rust_parser::rust_lookup_type)
7855         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7856         * printcmd.c (display_command, do_one_display): Update.
7857         * parser-defs.h (struct parser_state) <parser_state>: Add
7858         "tracker" parameter.
7859         (block_tracker): New member.
7860         (class innermost_block_tracker) <innermost_block_tracker>: Add
7861         "types" parameter.
7862         <reset>: Remove method.
7863         (innermost_block): Don't declare.
7864         (null_post_parser): Update.
7865         * parse.c (innermost_block): Remove global.
7866         (write_dollar_variable): Update.
7867         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7868         Remove "tracker_types" parameter.
7869         (parse_expression): Add "tracker" parameter.
7870         (parse_expression_for_completion): Update.
7871         (null_post_parser): Add "tracker" parameter.
7872         * p-exp.y: Update rules.
7873         * m2-exp.y: Update rules.
7874         * language.h (struct language_defn) <la_post_parser>: Add
7875         "tracker" parameter.
7876         * go-exp.y: Update rules.
7877         * f-exp.y: Update rules.
7878         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7879         parameter.
7880         * d-exp.y: Update rules.
7881         * c-exp.y: Update rules.
7882         * breakpoint.c (set_breakpoint_condition): Create an
7883         innermost_block_tracker.
7884         (watch_command_1): Likewise.
7885         * ada-lang.c (resolve): Add "tracker" parameter.
7886         (resolve_subexp): Likewise.
7887         * ada-exp.y (write_var_from_sym): Update.
7888
7889 2019-04-04  Tom Tromey  <tom@tromey.com>
7890
7891         * type-stack.h: New file.
7892         * type-stack.c: New file.
7893         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7894         type-stack.h.
7895         (insert_into_type_stack, insert_type, push_type, push_type_int)
7896         (insert_type_address_space, pop_type, pop_type_int)
7897         (pop_typelist, pop_type_stack, append_type_stack)
7898         (push_type_stack, get_type_stack, push_typelist)
7899         (follow_type_instance_flags, follow_types): Don't declare.
7900         * parse.c (type_stack): Remove global.
7901         (parse_exp_in_context): Update.
7902         (insert_into_type_stack, insert_type, push_type, push_type_int)
7903         (insert_type_address_space, pop_type, pop_type_int)
7904         (pop_typelist, pop_type_stack, append_type_stack)
7905         (push_type_stack, get_type_stack, push_typelist)
7906         (follow_type_instance_flags, follow_types): Remove (moved to
7907         type-stack.c).
7908         * f-exp.y (type_stack): New global.
7909         Update rules.
7910         (push_kind_type, f_parse): Update.
7911         * d-exp.y (type_stack): New global.
7912         Update rules.
7913         (d_parse): Update.
7914         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7915         Update rules.
7916         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7917         (HFILES_NO_SRCDIR): Add type-stack.h.
7918
7919 2019-04-04  Tom Tromey  <tom@tromey.com>
7920
7921         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7922         (rust_parser::convert_ast_to_expression, rust_parse)
7923         (rust_lex_test_completion, rust_lex_tests): Update.
7924         * parser-defs.h (struct expr_completion_state): New.
7925         (struct parser_state) <parser_state>: Add completion parameter.
7926         <mark_struct_expression, mark_completion_tag>: New methods.
7927         <parse_completion, m_completion_state>: New members.
7928         (prefixify_expression, null_post_parser): Update.
7929         (mark_struct_expression, mark_completion_tag): Don't declare.
7930         * parse.c (parse_completion, expout_last_struct)
7931         (expout_tag_completion_type, expout_completion_name): Remove
7932         globals.
7933         (parser_state::mark_struct_expression)
7934         (parser_state::mark_completion_tag): Now methods.
7935         (prefixify_expression): Add last_struct parameter.
7936         (prefixify_subexp): Likewise.
7937         (parse_exp_1): Update.
7938         (parse_exp_in_context): Add cstate parameter.  Update.
7939         (parse_expression_for_completion): Create an
7940         expr_completion_state.
7941         (null_post_parser): Add "completion" parameter.
7942         * p-exp.y: Update rules.
7943         (yylex): Update.
7944         * language.h (struct language_defn) <la_post_parser>: Add
7945         "completing" parameter.
7946         * go-exp.y: Update rules.
7947         (lex_one_token): Update.
7948         * expression.h (parse_completion): Don't declare.
7949         * d-exp.y: Update rules.
7950         (lex_one_token): Update rules.
7951         * c-exp.y: Update rules.
7952         (lex_one_token): Update.
7953         * ada-lang.c (resolve): Add "parse_completion" parameter.
7954         (resolve_subexp): Likewise.
7955         (ada_resolve_function): Likewise.
7956
7957 2019-04-04  Tom Tromey  <tom@tromey.com>
7958
7959         * parser-defs.h (struct parser_state) <start_arglist,
7960         end_arglist>: New methods.
7961         <arglist_len, m_funcall_chain>: New members.
7962         (arglist_len, start_arglist, end_arglist): Don't declare.
7963         * parse.c (arglist_len, funcall_chain): Remove global.
7964         (start_arglist, end_arglist): Remove functions.
7965         (parse_exp_in_context): Update.
7966         * p-exp.y: Update rules.
7967         * m2-exp.y: Update rules.
7968         * go-exp.y: Update rules.
7969         * f-exp.y: Update rules.
7970         * d-exp.y: Update rules.
7971         * c-exp.y: Update rules.
7972
7973 2019-04-04  Tom Tromey  <tom@tromey.com>
7974
7975         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7976         lex_operator, push_back>: New methods.
7977         Update all rules.
7978         (rust_parser::lex_hex, lex_escape): Rename and update.
7979         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7980         (rust_parser::lex_operator): Rename and update.
7981         (rust_parser::lex_number, rustyylex, rustyyerror)
7982         (rust_lex_test_init, rust_lex_test_sequence)
7983         (rust_lex_test_push_back, rust_lex_tests): Update.
7984         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7985         parameter.
7986         <lexptr, prev_lexptr>: New members.
7987         (lexptr, prev_lexptr): Don't declare.
7988         * parse.c (lexptr, prev_lexptr): Remove globals.
7989         (parse_exp_in_context): Update.
7990         * p-exp.y (yylex, yyerror): Update.
7991         * m2-exp.y (parse_number, yylex, yyerror): Update.
7992         * go-exp.y (lex_one_token, yyerror): Update.
7993         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7994         * d-exp.y (lex_one_token, yyerror): Update.
7995         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7996         (lex_one_token, yyerror): Update.
7997         * ada-lex.l (YY_INPUT): Update.
7998         (rewind_to_char): Update.
7999         * ada-exp.y (yyerror): Update.
8000
8001 2019-04-04  Tom Tromey  <tom@tromey.com>
8002
8003         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8004         * parser-defs.h (struct parser_state) <parser_state>: Add new
8005         parameter.
8006         <comma_terminates>: New member.
8007         (comma_terminates): Don't declare global.
8008         * parse.c (comma_terminates): Remove global.
8009         (parse_exp_in_context): Update.
8010         * p-exp.y (yylex): Update.
8011         * m2-exp.y (yylex): Update.
8012         * go-exp.y (lex_one_token): Update.
8013         * f-exp.y (yylex): Update.
8014         * d-exp.y (lex_one_token): Update.
8015         * c-exp.y (lex_one_token): Update.
8016         * ada-lex.l: Update.
8017
8018 2019-04-04  Tom Tromey  <tom@tromey.com>
8019
8020         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8021         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8022         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8023         * parser-defs.h (paren_depth): Don't declare.
8024         * parse.c (paren_depth): Remove global.
8025         (parse_exp_in_context): Update.
8026         * p-exp.y (paren_depth): New global.
8027         (pascal_parse): Initialize it.
8028         * m2-exp.y (paren_depth): New global.
8029         (m2_parse): Initialize it.
8030         * go-exp.y (paren_depth): New global.
8031         (go_parse): Initialize it.
8032         * f-exp.y (paren_depth): New global.
8033         (f_parse): Initialize it.
8034         * d-exp.y (paren_depth): New global.
8035         (d_parse): Initialize it.
8036         * c-exp.y (paren_depth): New global.
8037         (c_parse): Initialize it.
8038         * ada-lex.l (paren_depth): New global.
8039         (lexer_init): Initialize it.
8040
8041 2019-04-04  Tom Tromey  <tom@tromey.com>
8042
8043         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8044         (rust_parser::convert_ast_to_type)
8045         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8046         * parser-defs.h (struct parser_state) <parser_state>: Add
8047         parameters.  Initialize new members.
8048         <expression_context_block, expression_context_pc>: New members.
8049         * parse.c (expression_context_block, expression_context_pc):
8050         Remove globals.
8051         (parse_exp_in_context): Update.
8052         * p-exp.y: Update all rules.
8053         (yylex): Update.
8054         * m2-exp.y: Update all rules.
8055         (yylex): Update.
8056         * go-exp.y (yylex): Update.
8057         * f-exp.y (yylex): Update.
8058         * d-exp.y: Update all rules.
8059         (yylex): Update.
8060         * c-exp.y: Update all rules.
8061         (lex_one_token, classify_name, yylex, c_parse): Update.
8062         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8063
8064 2019-04-04  Tom Tromey  <tom@tromey.com>
8065
8066         * gdbarch.h, gdbarch.c: Rebuild.
8067         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8068         * stap-probe.h:
8069         (struct stap_parse_info): Replace "parser_state" with
8070         "expr_builder".
8071         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8072         (parser_state): New class.
8073         * parse.c (expr_builder): Rename.
8074         (expr_builder::release): Rename.
8075         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8076         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8077         (write_exp_elt_longcst, write_exp_elt_floatcst)
8078         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8079         (write_exp_string_vector, write_exp_bitstring)
8080         (write_exp_msymbol, mark_struct_expression)
8081         (write_dollar_variable)
8082         (insert_type_address_space, increase_expout_size): Replace
8083         "parser_state" with "expr_builder".
8084         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8085         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8086         "parser_state" with "expr_builder".
8087
8088 2019-04-04  Tom Tromey  <tom@tromey.com>
8089
8090         * rust-exp.y: Replace "parse_language" with method call.
8091         * p-exp.y:
8092         (yylex): Replace "parse_language" with method call.
8093         * m2-exp.y:
8094         (yylex): Replace "parse_language" with method call.
8095         * go-exp.y (classify_name): Replace "parse_language" with method
8096         call.
8097         * f-exp.y (yylex): Replace "parse_language" with method call.
8098         * d-exp.y (lex_one_token): Replace "parse_language" with method
8099         call.
8100         * c-exp.y:
8101         (lex_one_token, classify_name, yylex): Replace "parse_language"
8102         with method call.
8103         * ada-exp.y (find_primitive_type, type_char)
8104         (type_system_address): Replace "parse_language" with method call.
8105
8106 2019-04-04  Tom Tromey  <tom@tromey.com>
8107
8108         * rust-exp.y: Replace "parse_gdbarch" with method call.
8109         * parse.c (write_dollar_variable, insert_type_address_space):
8110         Replace "parse_gdbarch" with method call.
8111         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8112         call.
8113         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8114         call.
8115         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8116         "parse_gdbarch" with method call.
8117         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8118         with method call.
8119         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8120         "parse_gdbarch" with method call.
8121         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8122         "parse_gdbarch" with method call.
8123         * c-exp.y (parse_type, parse_number, classify_name): Replace
8124         "parse_gdbarch" with method call.
8125         * ada-lex.l: Replace "parse_gdbarch" with method call.
8126         * ada-exp.y (parse_type, find_primitive_type, type_char)
8127         (type_system_address): Replace "parse_gdbarch" with method call.
8128
8129 2019-04-04  Tom Tromey  <tom@tromey.com>
8130
8131         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8132         * stap-probe.c (stap_parse_argument): Update.
8133         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8134         initial_size parameter.
8135         * rust-exp.y (rust_lex_tests): Update.
8136         * parse.c (parser_state): Update.
8137         (parse_exp_in_context): Update.
8138         * parser-defs.h (struct parser_state) <parser_state>: Remove
8139         "initial_size" parameter.
8140
8141 2019-04-04  Tom Tromey  <tom@tromey.com>
8142
8143         * parser-defs.h (increase_expout_size): Don't declare.
8144         * parse.c (increase_expout_size): Now static.
8145
8146 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8147
8148         * gnu-nat.c (gnu_nat_target::wait): Fix
8149         target_waitstatus_to_string call.
8150
8151 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * eval.c (evaluate_subexp_standard): Handle internal functions
8154         during Fortran function call handling.
8155
8156 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8157
8158         * NEWS: Mention new internal functions.
8159         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8160         (read_base_type): Use dwarf2_init_complex_target_type.
8161         * value.c (creal_internal_fn): New function.
8162         (cimag_internal_fn): New function.
8163         (_initialize_values): Register new internal functions.
8164
8165 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8166
8167         * infrun.c (stop_all_threads): If debug_infrun, always
8168         trace the wait status after wait_one, using
8169         target_waitstatus_to_string and target_pid_to_str.
8170         (handle_inferior_event): Replace various trace of
8171         wait status kind by a single trace.
8172         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8173         wait status kind image by target_waitstatus_to_string.
8174         * target/waitstatus.c (target_waitstatus_to_string): Fix
8175         obsolete comment.
8176
8177 2019-04-01  Tom Tromey  <tromey@adacore.com>
8178
8179         PR symtab/23331:
8180         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8181
8182 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8183             Pedro Alves  <palves@redhat.com>
8184
8185         * top.c (quit_force): Call 'finalize_values'.
8186         * value.c (finalize_values): New function.
8187         * value.h (finalize_values): Declare.
8188
8189 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8190
8191         * NEWS: Announce $_gdb_major and $_gdb_minor.
8192
8193         * top.c (init_gdb_version_vars): New function.
8194         (gdb_init): Call init_gdb_version_vars.
8195
8196 2019-03-29  Tom Tromey  <tromey@adacore.com>
8197
8198         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8199         help text.  Remove dead code.
8200
8201 2019-03-29  Keith Seitz  <keiths@redhat.com>
8202
8203         From Siddhesh Poyarekar:
8204         * f-lang.h (f77_get_upperbound): Return LONGEST.
8205         (f77_get_lowerbound): Likewise.
8206         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8207         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8208         print them.
8209         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8210         plongest to format print it.
8211         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8212         (f77_get_upperbound): Likewise.
8213         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8214         LOWER_BOUND to LONGEST.
8215         (f77_create_arrayprint_offset_tbl): Likewise.
8216
8217 2019-03-29  Keith Seitz  <keiths@redhat.com>
8218
8219         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8220         %s/pulongest for TYPE_LENGTH instead of %d in format
8221         strings.
8222         * ada-typerint.c (ada_print_type): Likewise.
8223         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8224         * compile/compile-c-support.c (generate_register_struct): Likewise.
8225         * gdbtypes.c (recursive_dump_type): Likewise.
8226         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8227         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8228         instead of %d in format strings.
8229         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8230         to std::min to ULONGEST.
8231         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8232         instead of %d in format strings.
8233         * tracepoint.c (info_scope_command): Likewise.
8234         * typeprint.c (print_offset_data::update)
8235         (print_offset_data::finish): Likewise.
8236         * xtensa-tdep.c (xtensa_store_return_value)
8237         (xtensa_push_dummy_call): Likewise.
8238
8239 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8240
8241         * windows-nat.c (display_selector): Fixed format specifications
8242         for 64-bit Cygwin.
8243
8244 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8245
8246         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8247
8248 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8249
8250         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8251         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8252         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8253         (nios2_linux_init_abi): Install it.
8254
8255 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8256
8257         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8258
8259 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8260
8261         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8262
8263 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8264             Tom Tromey  <tromey@adacore.com>
8265
8266         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8267
8268 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8269
8270         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8271         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8272         method to compute the bounds of range types. Also print "[evaluated]"
8273         if the bounds' values come from a dynamic evaluation.
8274
8275 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8276
8277         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8278         whitespace when pretty printing is on.
8279
8280 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8281
8282         * ppc-linux-nat.c: Add include.
8283
8284 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8285
8286         * NEWS: Mention AArch64 Pointer Authentication.
8287
8288 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8289
8290         * arm-linux-nat.c: Add include.
8291
8292 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8293
8294         * source-cache.c (source_cache::get_source_lines): Re-read
8295         fullname after calling open_source_file.
8296
8297 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8298
8299         * NEWS: Mention TLS support for FreeBSD.
8300
8301 2019-03-25  Tom Tromey  <tromey@adacore.com>
8302
8303         * minsyms.c (BUNCH_SIZE): Update comment.
8304         (~minimal_symbol_reader): Remove old comment.
8305         (compact_minimal_symbols): Update comment.
8306         (minimal_symbol_reader::install): Remove old comment.  Update
8307         other comments.
8308
8309 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8310
8311         * s390-linux-nat.c: Add include.
8312
8313 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8314
8315         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8316         Call linux_get_hwcap.
8317         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8318         Likewise.
8319         (aarch64_linux_get_hwcap): Remove function.
8320         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8321         declaration.
8322         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8323         linux_get_hwcap.
8324         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8325         * linux-tdep.c (linux_get_hwcap): Add function.
8326         (linux_get_hwcap2): Likewise.
8327         * linux-tdep.h (linux_get_hwcap): Add declaration.
8328         (linux_get_hwcap2): Likewise.
8329         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8330         (ppc_linux_get_hwcap2): Likewise.
8331         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8332         linux_get_hwcap.
8333         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8334         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8335         (ppc_linux_nat_target::read_description): Likewise.
8336         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8337         * s390-linux-nat.c: Likewise.
8338         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8339
8340 2019-03-24  Tom Tromey  <tom@tromey.com>
8341
8342         * ada-lang.c (standard_lookup): Simplify initialization.
8343         (ada_lookup_symbol_nonlocal): Simplify return.
8344         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8345         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8346         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8347         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8348         initialization.
8349         * solib.c (solib_global_lookup): Simplify.
8350         * symtab.c (null_block_symbol): Remove.
8351         (symbol_cache_lookup): Simplify returns.
8352         (lookup_language_this): Simplify returns.
8353         (lookup_symbol_aux): Simplify return.
8354         (lookup_local_symbol): Simplify returns.
8355         (lookup_global_symbol_from_objfile): Simplify return.
8356         (lookup_symbol_in_objfile_symtabs)
8357         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8358         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8359         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8360         * cp-namespace.c (cp_lookup_bare_symbol)
8361         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8362         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8363         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8364         (cp_lookup_symbol_via_imports): Simplify initialization.
8365         (find_symbol_in_baseclass): Likewise.
8366         * symtab.h (null_block_symbol): Remove.
8367         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8368         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8369         (d_lookup_symbol_module): Likewise.
8370         (find_symbol_in_baseclass): Simplify initialization.
8371
8372 2019-03-24  Tom Tromey  <tom@tromey.com>
8373
8374         * expression.h: Don't include symtab.h.
8375         (struct block): Forward declare.
8376
8377 2019-03-24  Tom Tromey  <tom@tromey.com>
8378
8379         * c-exp.y (typebase): Remove casts.
8380         * gdbtypes.c (lookup_unsigned_typename, )
8381         (lookup_signed_typename): Remove cast.
8382         * eval.c (parse_to_comma_and_eval): Remove cast.
8383         * parse.c (write_dollar_variable): Remove cast.
8384         * block.h (struct block) <superblock>: Now const.
8385         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8386         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8387         (map_block): Make "block" const.
8388         * symfile.h (struct quick_symbol_functions)
8389         <map_matching_symbols>: Constify block argument to "callback".
8390         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8391         const.
8392         (find_pc_sect_compunit_symtab): Make "b" const.
8393         (find_symbol_at_address): Likewise.
8394         (search_symbols): Likewise.
8395         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8396         (dw2_debug_names_lookup_symbol): Likewise.
8397         (dw2_map_matching_symbols): Update.
8398         * p-valprint.c (pascal_val_print): Remove "block".
8399         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8400         (aux_add_nonlocal_symbols): Make "block" const.
8401         (resolve_subexp): Remove cast.
8402         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8403         const.
8404         (iterate_over_file_blocks): Likewise.
8405         * f-exp.y (%union) <bval>: Remove.
8406         * coffread.c (patch_opaque_types): Make "b" const.
8407         * spu-tdep.c (spu_catch_start): Make "block" const.
8408         * c-valprint.c (print_unpacked_pointer): Remove "block".
8409         * symmisc.c (dump_symtab_1): Make "b" const.
8410         (block_depth): Make "block" const.
8411         * d-exp.y (%union) <bval>: Remove.
8412         * cp-support.h (cp_lookup_rtti_type): Update.
8413         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8414         * psymtab.c (psym_lookup_symbol): Make "block" const.
8415         (maintenance_check_psymtabs): Make "b" const.
8416         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8417         (enumerate_locals, enumerate_args): Update.
8418         * python/py-symtab.c (stpy_global_block): Make "block" const.
8419         (stpy_static_block): Likewise.
8420         * inline-frame.c (block_starting_point_at): Make "new_block"
8421         const.
8422         * block.c (find_block_in_blockvector): Make return type const.
8423         (blockvector_for_pc_sect): Make "b" const.
8424         (find_block_in_blockvector): Make "b" const.
8425
8426 2019-03-23  Tom Tromey  <tom@tromey.com>
8427
8428         * varobj.c (varobj_create): Update.
8429         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8430         * printcmd.c (display_command, do_one_display): Don't reset
8431         innermost_block.
8432         * parser-defs.h (enum innermost_block_tracker_type): Move to
8433         expression.h.
8434         (innermost_block): Update comment.
8435         * parse.c (parse_exp_1): Add tracker_types parameter.
8436         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8437         tracker_types parameter.  Reset innermost_block.
8438         (parse_exp_in_context): Remove.
8439         (parse_expression_for_completion): Update.
8440         * objfiles.c (~objfile): Don't reset expression_context_block or
8441         innermost_block.
8442         * expression.h (enum innermost_block_tracker_type): Move from
8443         parser-defs.h.
8444         (parse_exp_1): Add tracker_types parameter.
8445         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8446         reset innermost_block.
8447
8448 2019-03-23  Tom Tromey  <tom@tromey.com>
8449
8450         * objfiles.h: Include bcache.h.
8451
8452 2019-03-23  Tom Tromey  <tom@tromey.com>
8453
8454         * linespec.c (get_current_search_block): Use
8455         scoped_restore_current_language.
8456         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8457
8458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8459             Jiong Wang  <jiong.wang@arm.com>
8460
8461         * aarch64-linux-tdep.c
8462         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8463         section.
8464         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8465
8466 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8467             Jiong Wang  <jiong.wang@arm.com>
8468
8469         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8470         instructions.
8471         (aarch64_analyze_prologue_test): Add PACIASP test.
8472         (aarch64_prologue_prev_register): Unmask PC value.
8473
8474 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8475             Jiong Wang  <jiong.wang@arm.com>
8476
8477         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8478         (aarch64_dwarf2_prev_register): Unmask PC value.
8479         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8480         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8481         DW_CFA_AARCH64_negate_ra_state.
8482         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8483
8484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8485             Jiong Wang  <jiong.wang@arm.com>
8486
8487         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8488         registers.
8489         (aarch64_pseudo_register_name): Likewise.
8490         (aarch64_pseudo_register_type): Likewise.
8491         (aarch64_pseudo_register_reggroup_p): Likewise.
8492         (aarch64_gdbarch_init): Add pauth registers.
8493         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8494         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8495         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8496         (struct gdbarch_tdep): Add regnum for ra_state.
8497
8498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8499             Jiong Wang  <jiong.wang@arm.com>
8500
8501         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8502
8503 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8504             Jiong Wang  <jiong.wang@arm.com>
8505
8506         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8507         function.
8508         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8509         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8510         (aarch64_gdbarch_init): Add puth registers.
8511         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8512         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8513         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8514
8515 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8516             Jiong Wang  <jiong.wang@arm.com>
8517
8518         * aarch64-linux-nat.c
8519         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8520         * aarch64-linux-tdep.c
8521         (aarch64_linux_core_read_description): Likewise.
8522         (aarch64_linux_get_hwcap): New function.
8523         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8524         (aarch64_linux_get_hwcap): New declaration.
8525
8526 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8527             Jiong Wang  <jiong.wang@arm.com>
8528
8529         * aarch64-linux-nat.c
8530         (aarch64_linux_nat_target::read_description): Add pauth param.
8531         * aarch64-linux-tdep.c
8532         (aarch64_linux_core_read_description): Likewise.
8533         * aarch64-tdep.c (struct target_desc): Add in pauth.
8534         (aarch64_read_description): Add pauth param.
8535         (aarch64_gdbarch_init): Likewise.
8536         * aarch64-tdep.h (aarch64_read_description): Likewise.
8537         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8538         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8539         * features/Makefile: Add new files.
8540         * features/aarch64-pauth.c: New file.
8541         * features/aarch64-pauth.xml: New file.
8542
8543 2019-03-20  Tom Tromey  <tromey@adacore.com>
8544
8545         * infrun.c (handle_inferior_event): Rename from
8546         handle_inferior_event_1.  Create a scoped_value_mark.
8547         (handle_inferior_event): Remove.
8548
8549 2019-03-19  Tom Tromey  <tromey@adacore.com>
8550
8551         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8552         * infrun.h (print_stop_event): Add "displays" parameter.
8553         * infrun.c (print_stop_event): Add "displays" parameter.
8554
8555 2019-03-19  Pedro Alves  <palves@redhat.com>
8556
8557         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8558         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8559         to -1.  Fix TABs vs spaces.
8560         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8561         * tui/tui-out.h (tui_ui_out) Add intro comments.
8562         <m_line, m_start_of_line>: In-class initialize, and add describing
8563         comment.
8564
8565 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8566
8567         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8568         variable names.
8569         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8570
8571 2019-03-18  Pedro Alves  <palves@redhat.com>
8572             Eli Zaretskii <eliz@gnu.org>
8573
8574         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8575         m_line and m_start_of_line.
8576
8577 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8578
8579         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8580         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8581         it returns a newline.  This fixes a regression in TU mode, whereby
8582         the next line is output on the same screen line as the user input.
8583
8584 2019-03-18  Tom Tromey  <tromey@adacore.com>
8585
8586         * minsyms.c (minimal_symbol_reader::install): Remove call to
8587         obstack_blank.
8588
8589 2019-03-18  Pedro Alves  <palves@redhat.com>
8590
8591         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8592         New globals.
8593         (apply_style): New, factored out from ...
8594         (apply_ansi_escape): ... this.  Handle reverse video mode.
8595         (tui_set_reverse_mode): New function.
8596         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8597         * tui/tui-winsource.c (tui_show_source_line): Use
8598         tui_set_reverse_mode instead of setting A_STANDOUT.
8599         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8600         New setter methods.
8601
8602 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8603
8604         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8605         Handle tabs.
8606
8607 2019-03-18  Tom Tromey  <tromey@adacore.com>
8608
8609         * ada-lang.c (empty_array): Add "high" parameter.
8610         (ada_evaluate_subexp): Update.
8611
8612 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8613
8614         * unittests/string_view-selftests.c: Define
8615         _initialize_string_view_selftests unconditionally.
8616
8617 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8618
8619         PR gdb/24350
8620         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8621
8622 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8623
8624         PR gdb/24351
8625         * windows-nat.c (display_selector): Fix format specifiers.
8626
8627 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8628
8629         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8630         tui_refill_source_window instead of tui_refresh_win, to update the
8631         current execution line.  This fixes redisplay of the current line
8632         when stepping through the code with "next" or "step".
8633
8634 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8635
8636         * source-cache.c (source_cache::get_source_lines): Call
8637         find_source_lines to initialize s->nlines.  This fixes vertical
8638         scrolling of TUI source window when the DOWN arrow is pressed.
8639
8640 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8641
8642         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8643         linux-thread-db.c (_initialize_thread_db): Likewise.
8644
8645 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8646
8647         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8648         wclrtoeol in tui_show_source_line".  This reverts changes made in
8649         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8650
8651 2019-03-15  Tom Tromey  <tom@tromey.com>
8652
8653         * symtab.h (struct minimal_symbol): Derive from
8654         general_symbol_info.
8655         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8656         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8657         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8658         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8659         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8660         (MSYMBOL_SEARCH_NAME): Update.
8661         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8662         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8663         * minsyms.c (minimal_symbol_reader::record_full): Update.
8664
8665 2019-03-15  Tom Tromey  <tom@tromey.com>
8666
8667         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8668
8669 2019-03-15  Tom Tromey  <tom@tromey.com>
8670
8671         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8672         unique_xmalloc_ptr.
8673         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8674         Update.
8675         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8676         (build_minimal_symbol_hash_tables)
8677         (minimal_symbol_reader::install): Update.
8678
8679 2019-03-15  Tom Tromey  <tom@tromey.com>
8680
8681         * symtab.c (create_demangled_names_hash): Update.
8682         (symbol_set_names): Update.
8683         * objfiles.h (struct objfile_per_bfd_storage)
8684         <demangled_names_hash>: Now an htab_up.
8685         * objfiles.c (objfile_per_bfd_storage): Simplify.
8686
8687 2019-03-15  Tom Tromey  <tom@tromey.com>
8688
8689         * objfiles.h (struct objfile_per_bfd_storage): Declare
8690         destructor.
8691         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8692         New.
8693         (get_objfile_bfd_data): Use new.  Don't initialize
8694         language_of_main.
8695         (free_objfile_per_bfd_storage): Remove.
8696         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8697
8698 2019-03-15  Tom Tromey  <tom@tromey.com>
8699
8700         * symfile.c (reread_symbols): Update.
8701         * objfiles.c (objfile::objfile): Update.
8702         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8704         comment.
8705         (minimal_symbol_reader::install): Update.
8706         (terminate_minimal_symbol_table): Remove.
8707         * jit.c (jit_object_close_impl): Update.
8708
8709 2019-03-15  Tom Tromey  <tom@tromey.com>
8710
8711         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8712         initializations.
8713
8714 2019-03-15  Tom Tromey  <tom@tromey.com>
8715
8716         * objfiles.h (struct objfile_per_bfd_storage)
8717         <demangled_hash_languages>: Now a bitset.
8718         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8719         (lookup_minimal_symbol): Update.
8720
8721 2019-03-15  Tom Tromey  <tom@tromey.com>
8722
8723         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8724         Don't return the symbol.
8725         * coffread.c (record_minimal_symbol): Use record_full.
8726
8727 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8728
8729         The MS-Windows port of ncurses fails to switch to a color pair if
8730         one or both of the colors are the implicit default colors.  This
8731         change records the default colors when TUI is initialized, and
8732         then specifies them explicitly when a color pair uses the default
8733         colors.  This allows color styling in TUI mode on MS-Windows.
8734
8735         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8736         ncurses_norm_attr.
8737         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8738         colors in ncurses_norm_attr.
8739         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8740         "none", replace it with the default color recorded in
8741         ncurses_norm_attr.
8742
8743 2019-03-14  Tom Tromey  <tromey@adacore.com>
8744
8745         * source-cache.h (class source_cache) <get_source_lines>: Return
8746         std::string.
8747         * source-cache.c (source_cache::extract_lines): Handle case where
8748         first_pos==npos.  Return std::string.
8749         (source_cache::get_source_lines): Update.
8750
8751 2019-03-14  Tom Tromey  <tromey@adacore.com>
8752
8753         * NEWS: Add item for "style sources" commands.
8754         * source-cache.c (source_cache::get_source_lines): Check
8755         source_styling.
8756         * cli/cli-style.c (source_styling): New global.
8757         (_initialize_cli_style): Add "style sources" commands.
8758         (show_style_sources): New function.
8759         * cli/cli-style.h (source_styling): Declare.
8760
8761 2019-03-14  Pedro Alves  <palves@redhat.com>
8762             Tom Tromey  <tromey@adacore.com>
8763
8764         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8765         * tui/tui-winsource.c (tui_refill_source_window): New function,
8766         from...
8767         (tui_horizontal_source_scroll): ... here.  Move some logic.
8768         * cli/cli-style.c (set_style_enabled): Notify new observable.
8769         * tui/tui-hooks.c (tui_redisplay_source): New function.
8770         (tui_attach_detach_observers): Attach or detach
8771         tui_redisplay_source.
8772         * observable.h (source_styling_changed): New observable.
8773         * observable.c: Define source_styling_changed observable.
8774
8775 2019-03-13  Tom Tromey  <tromey@adacore.com>
8776
8777         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8778         (i386_gnu_nat_target::store_registers): Update.
8779         * target-debug.h (target_debug_print_std_string): New macro.
8780         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8781         * windows-tdep.c (display_one_tib): Update.
8782         * tui/tui-stack.c (tui_make_status_line): Update.
8783         * top.c (print_inferior_quit_action): Update.
8784         * thread.c (thr_try_catch_cmd): Update.
8785         (add_thread_with_info): Update.
8786         (thread_target_id_str): Update.
8787         (thr_try_catch_cmd): Update.
8788         (thread_command): Update.
8789         (thread_find_command): Update.
8790         * record-btrace.c (record_btrace_target::info_record)
8791         (record_btrace_resume_thread, record_btrace_target::resume)
8792         (record_btrace_cancel_resume, record_btrace_step_thread)
8793         (record_btrace_target::wait, record_btrace_target::wait)
8794         (record_btrace_target::wait, record_btrace_target::stop): Update.
8795         * progspace.c (print_program_space): Update.
8796         * process-stratum-target.c
8797         (process_stratum_target::thread_address_space): Update.
8798         * linux-fork.c (linux_fork_mourn_inferior)
8799         (detach_checkpoint_command, info_checkpoints_command)
8800         (linux_fork_context): Update.
8801         (linux_fork_detach): Update.
8802         (class scoped_switch_fork_info): Update.
8803         (delete_checkpoint_command): Update.
8804         * infrun.c (follow_fork_inferior): Update.
8805         (follow_fork_inferior): Update.
8806         (proceed_after_vfork_done): Update.
8807         (handle_vfork_child_exec_or_exit): Update.
8808         (follow_exec): Update.
8809         (displaced_step_prepare_throw): Update.
8810         (displaced_step_restore): Update.
8811         (start_step_over): Update.
8812         (resume_1): Update.
8813         (clear_proceed_status_thread): Update.
8814         (proceed): Update.
8815         (print_target_wait_results): Update.
8816         (do_target_wait): Update.
8817         (context_switch): Update.
8818         (stop_all_threads): Update.
8819         (restart_threads): Update.
8820         (finish_step_over): Update.
8821         (handle_signal_stop): Update.
8822         (switch_back_to_stepped_thread): Update.
8823         (keep_going_pass_signal): Update.
8824         (print_exited_reason): Update.
8825         (normal_stop): Update.
8826         * inferior.c (inferior_pid_to_str): Change return type.
8827         (print_selected_inferior): Update.
8828         (add_inferior): Update.
8829         (detach_inferior): Update.
8830         * dummy-frame.c (fprint_dummy_frames): Update.
8831         * dcache.c (dcache_info_1): Update.
8832         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8833         (btrace_fetch, btrace_clear): Update.
8834         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8835         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8836         type.
8837         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8838         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8839         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8840         * gdbarch.c, gdbarch.h: Rebuild.
8841         * gdbarch.sh (core_pid_to_str): Change return type.
8842         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8843         return type.
8844         (windows_nat_target::pid_to_str): Change return type.
8845         (windows_delete_thread): Update.
8846         (windows_nat_target::attach): Update.
8847         (windows_nat_target::files_info): Update.
8848         * target-delegates.c: Rebuild.
8849         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8850         return type.
8851         (sol_thread_target::pid_to_str): Change return type.
8852         * remote.c (class remote_target) <pid_to_str>: Change return
8853         type.
8854         (remote_target::pid_to_str): Change return type.
8855         (extended_remote_target::attach, remote_target::remote_stop_ns)
8856         (remote_target::remote_notif_remove_queued_reply)
8857         (remote_target::push_stop_reply, remote_target::disable_btrace):
8858         Update.
8859         (extended_remote_target::attach): Update.
8860         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8861         type.
8862         (gdbsim_target::pid_to_str): Change return type.
8863         * ravenscar-thread.c (struct ravenscar_thread_target)
8864         <pid_to_str>: Change return type.
8865         (ravenscar_thread_target::pid_to_str): Change return type.
8866         * procfs.c (class procfs_target) <pid_to_str>: Change return
8867         type.
8868         (procfs_target::pid_to_str): Change return type.
8869         (procfs_target::attach): Update.
8870         (procfs_target::detach): Update.
8871         (procfs_target::fetch_registers): Update.
8872         (procfs_target::store_registers): Update.
8873         (procfs_target::wait): Update.
8874         (procfs_target::files_info): Update.
8875         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8876         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8877         return type.
8878         (nto_procfs_target::pid_to_str): Change return type.
8879         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8880         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8881         return type.
8882         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8883         (exit_lwp): Update.
8884         (attach_proc_task_lwp_callback, get_detach_signal)
8885         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8886         (linux_nat_target::resume, wait_lwp, stop_callback)
8887         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8888         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8889         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8890         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8891         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8892         type.
8893         (inf_ptrace_target::attach): Update.
8894         (inf_ptrace_target::files_info): Update.
8895         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8896         type.
8897         (go32_nat_target::pid_to_str): Change return type.
8898         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8899         (gnu_nat_target::wait): Update.
8900         (gnu_nat_target::wait): Update.
8901         (gnu_nat_target::resume): Update.
8902         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8903         (fbsd_nat_target::wait): Update.
8904         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8905         type.
8906         (darwin_nat_target::attach): Update.
8907         * corelow.c (class core_target) <pid_to_str>: Change return type.
8908         (core_target::pid_to_str): Change return type.
8909         * target.c (normal_pid_to_str): Change return type.
8910         (default_pid_to_str): Likewise.
8911         (target_pid_to_str): Change return type.
8912         (target_translate_tls_address): Update.
8913         (target_announce_detach): Update.
8914         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8915         return type.
8916         (bsd_uthread_target::pid_to_str): Change return type.
8917         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8918         type.
8919         (bsd_kvm_target::pid_to_str): Change return type.
8920         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8921         return type.
8922         (aix_thread_target::pid_to_str): Change return type.
8923         * target.h (struct target_ops) <pid_to_str>: Change return type.
8924         (target_pid_to_str, normal_pid_to_str): Likewise.
8925         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8926         type.
8927         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8928         type.
8929         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8930         return type.
8931         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8932         type.
8933         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8934         type.
8935         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8936         return type.
8937
8938 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8939
8940         * NEWS: Mention that the new default MI version is 3.  Mention
8941         changes to the output of commands and events that deal with
8942         multi-location breakpoints.
8943         * breakpoint.c: Include "mi/mi-out.h".
8944         (print_one_breakpoint): Change output syntax if using MI version
8945         >= 3.
8946         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8947         New.
8948         (mi_multi_location_breakpoint_output_fixed): New.
8949         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8950         (mi_cmd_fix_multi_location_breakpoint_output): New.
8951         (mi_multi_location_breakpoint_output_fixed): New.
8952         * mi/mi-cmds.c (mi_cmds): Register command
8953         -fix-multi-location-breakpoint-output.
8954         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8955         interpreter "mi".
8956
8957 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8958
8959         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8960         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8961         instantiate mi_ui_out based on interpreter name.
8962         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8963         * mi/mi-main.c (mi_load_progress): Likewise.
8964
8965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8966
8967         * NEWS: Combine separate "New targets" sections for 8.3.
8968
8969 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8970
8971         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8972         (ppcfbsd_init_abi): Install gdbarch
8973         "fetch_tls_load_module_address" and "get_thread_local_address"
8974         methods.
8975
8976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8977
8978         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8979         (riscv_fbsd_init_abi): Install gdbarch
8980         "fetch_tls_load_module_address" and "get_thread_local_address"
8981         methods.
8982
8983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8984
8985         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8986         (i386fbsd_init_abi): Install gdbarch
8987         "fetch_tls_load_module_address" and "get_thread_local_address"
8988         methods.
8989
8990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8991
8992         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8993         (amd64fbsd_init_abi): Install gdbarch
8994         "fetch_tls_load_module_address" and "get_thread_local_address"
8995         methods.
8996
8997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8998
8999         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9000         (struct fbsd_pspace_data): New type.
9001         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9002         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9003         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9004         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9005         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9006
9007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9008
9009         * gdbtypes.c (lookup_struct_elt): New function.
9010         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9011         * gdbtypes.h (struct struct_elt): New type.
9012         (lookup_struct_elt): New prototype.
9013
9014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9015
9016         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9017         remove disabled code block.
9018
9019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9020
9021         * gdbarch.sh (get_thread_local_address): New method.
9022         * gdbarch.h, gdbarch.c: Regenerate.
9023         * target.c (target_translate_tls_address): Use
9024         gdbarch_get_thread_local_address if present instead of
9025         target::get_thread_local_address.
9026
9027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9028
9029         * target.h (target::get_thread_local_address): Update comment.
9030
9031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9032
9033         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9034         objfile->separate_debug_objfile_backlink if not NULL.
9035
9036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9037
9038         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9039         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9040         (amd64bsd_store_inferior_registers): Likewise.
9041         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9042         Enable segment base registers.
9043         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9044         PT_GETFSBASE and PT_GETGSBASE.
9045         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9046         PT_SETGSBASE.
9047         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9048         segment base registers.
9049         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9050
9051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9052
9053         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9054         Update calls to i386_target_description to add 'segments'
9055         parameter.
9056         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9057         add segment base registers.
9058         * arch/i386.c (i386_create_target_description): Add 'segments'
9059         parameter to enable segment base registers.
9060         * arch/i386.h (i386_create_target_description): Likewise.
9061         * features/i386/32bit-segments.xml: New file.
9062         * features/i386/32bit-segments.c: Generate.
9063         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9064         call to i386_target_description to add 'segments' parameter.
9065         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9066         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9067         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9068         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9069         if feature is present.
9070         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9071         Add 'segments' parameter to call to i386_target_description.
9072         (i386_target_description): Add 'segments' parameter to enable
9073         segment base registers.
9074         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9075         to call to i386_target_description.
9076         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9077         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9078         Define I386_NUM_REGS.
9079         (i386_target_description): Add 'segments' parameter to enable
9080         segment base registers.
9081
9082 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9083
9084         PR/24325
9085         * source-cache.c: #undef open and close, to avoid unresolved
9086         externals during linking.
9087
9088 2019-03-12  Tom Tromey  <tromey@adacore.com>
9089
9090         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9091         const.  Add initializers.
9092         (_initialize_remote): Don't initialize ptid globals.
9093
9094 2019-03-12  Pedro Alves  <palves@redhat.com>
9095
9096         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9097
9098 2019-03-12  Pedro Alves  <palves@redhat.com>
9099
9100         * cp-name-parser.y (main): Remove unused 'len' variable.
9101
9102 2019-03-12  Tom Tromey  <tromey@adacore.com>
9103
9104         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9105         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9106
9107 2019-03-12  Tom Tromey  <tromey@adacore.com>
9108
9109         * linux-nat.c (iterate_over_lwps): Update.
9110         (stop_callback): Remove parameter.
9111         (stop_wait_callback, detach_callback, resume_set_callback)
9112         (select_singlestep_lwp_callback, set_ignore_sigint)
9113         (status_callback, resumed_callback, resume_clear_callback)
9114         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9115         data parameter.
9116         (linux_nat_target::detach, linux_nat_target::resume)
9117         (linux_stop_and_wait_all_lwps, select_event_lwp)
9118         (linux_nat_filter_event, linux_nat_wait_1)
9119         (linux_nat_target::kill, linux_nat_target::stop)
9120         (linux_nat_target::stop): Update.
9121         (linux_nat_resume_callback): Change type.
9122         (resume_stopped_resumed_lwps, count_events_callback)
9123         (select_event_lwp_callback): Likewise.
9124         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9125         * arm-linux-nat.c (struct update_registers_data): Remove.
9126         (update_registers_callback): Change type.
9127         (arm_linux_insert_hw_breakpoint1): Update.
9128         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9129         parameter.
9130         (x86_linux_dr_set_addr): Update.
9131         (x86_linux_dr_set_control): Update.
9132         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9133         (iterate_over_lwps): Use gdb::function_view.
9134         * nat/aarch64-linux-hw-point.c (struct
9135         aarch64_dr_update_callback_param): Remove.
9136         (debug_reg_change_callback): Change type.
9137         (aarch64_notify_debug_reg_change): Update.
9138         * s390-linux-nat.c (s390_refresh_per_info): Update.
9139
9140 2019-03-11  Tom Tromey  <tromey@adacore.com>
9141
9142         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9143         redundant assignment to "this_cu".
9144
9145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9146
9147         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9148
9149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9150
9151         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9152         from...
9153         (rank_one_type): ... this.
9154
9155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9156
9157         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9158         from...
9159         (rank_one_type): ... this.
9160
9161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9162
9163         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9164         from...
9165         (rank_one_type): ... this.
9166
9167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9168
9169         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9170         from...
9171         (rank_one_type): ... this.
9172
9173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9174
9175         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9176         from...
9177         (rank_one_type): ... this.
9178
9179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9180
9181         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9182         from...
9183         (rank_one_type): ... this.
9184
9185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9186
9187         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9188         from...
9189         (rank_one_type): ... this.
9190
9191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9192
9193         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9194         from...
9195         (rank_one_type): ... this.
9196
9197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9198
9199         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9200         from...
9201         (rank_one_type): ... this.
9202
9203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9204
9205         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9206         from...
9207         (rank_one_type): ... this.
9208
9209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9210
9211         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9212         from...
9213         (rank_one_type): ... this.
9214
9215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9216
9217         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9218         from...
9219         (rank_one_type): ... this.
9220
9221 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9222
9223         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9224         inferior-events' shows the example events.
9225
9226 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9227
9228         Support styling on native MS-Windows console
9229
9230         PR/24315
9231         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9232         on MS-Windows if $TERM is not defined.
9233
9234         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9235
9236         * posix-hdep.c (gdb_console_fputs):
9237         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9238         functions.
9239         * ui-file.h (gdb_console_fputs): Add prototype.
9240
9241         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9242         back to fputs only if the former returns zero.
9243
9244 2019-03-07  Tom Tromey  <tom@tromey.com>
9245
9246         * symmisc.c (print_symbol_bcache_statistics): Update.
9247         (print_objfile_statistics): Update.
9248         * symfile.c (allocate_symtab): Update.
9249         * stabsread.c: Don't include bcache.h.
9250         * psymtab.h (struct psymbol_bcache): Don't declare.
9251         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9252         (psymbol_bcache_init, psymbol_bcache_free)
9253         (psymbol_bcache_get_bcache): Don't declare.
9254         * psymtab.c (struct psymbol_bcache): Remove.
9255         (psymtab_storage::psymtab_storage): Update.
9256         (psymtab_storage::~psymtab_storage): Update.
9257         (psymbol_bcache_init, psymbol_bcache_free)
9258         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9259         (add_psymbol_to_bcache): Update.
9260         (allocate_psymtab): Update.
9261         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9262         macro_cache>: No longer pointers.
9263         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9264         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9265         * macrotab.c (macro_bcache): Update.
9266         * macroexp.c: Don't include bcache.h.
9267         * gdbtypes.c (check_types_worklist): Update.
9268         (types_deeply_equal): Remove TRY/CATCH.  Update.
9269         * elfread.c (elf_symtab_read): Update.
9270         * dwarf2read.c: Don't include bcache.h.
9271         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9272         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9273         (print_bcache_statistics, bcache_memory_used): Don't declare.
9274         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9275         methods.  Rename all data members.
9276         * bcache.c (struct bcache): Move to bcache.h.
9277         (bcache::expand_hash_table): Rename from expand_hash_table.
9278         (bcache): Remove.
9279         (bcache::insert): Rename from bcache_full.
9280         (bcache::compare): Rename from bcache_compare.
9281         (bcache_xmalloc): Remove.
9282         (bcache::~bcache): Rename from bcache_xfree.
9283         (bcache::print_statistics): Rename from print_bcache_statistics.
9284         (bcache::memory_used): Rename from bcache_memory_used.
9285
9286 2019-03-07  Pedro Alves  <palves@redhat.com>
9287
9288         * infrun.c (normal_stop): Also check for
9289         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9290
9291 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9292
9293         * f-lang.c (value_from_host_double): Moved to...
9294         * value.c (value_from_host_double): ...here.
9295         * value.h (value_from_host_double): Declare.
9296         * guile/scm-math.c (vlscm_convert_typed_number): Use
9297         value_from_host_double.
9298         (vlscm_convert_number): Likewise.
9299         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9300         * python/py-value.c (convert_value_from_python): Likewise.
9301
9302 2019-03-06  Tom Tromey  <tom@tromey.com>
9303
9304         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9305
9306 2019-03-06  Tom Tromey  <tom@tromey.com>
9307
9308         * utils.h (free_current_contents): Don't declare.
9309         * utils.c (free_current_contents): Remove.
9310
9311 2019-03-06  Tom Tromey  <tom@tromey.com>
9312
9313         * top.c (quit_force): Update.
9314         * main.c (captured_command_loop): Update.
9315         * common/new-op.c (operator new): Update.
9316         * common/common-exceptions.c (struct catcher)
9317         <save_cleanup_chain>: Remove member.
9318         (exceptions_state_mc_init): Update.
9319         (exception_try_scope_entry): Return nullptr.
9320         (exception_try_scope_exit, exception_rethrow)
9321         (throw_exception_sjlj, throw_exception_cxx): Update.
9322         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9323         (all_cleanups, do_cleanups, discard_cleanups)
9324         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9325         (restore_cleanups, restore_final_cleanups): Don't declare.
9326         (do_final_cleanups): Remove parameter.
9327         * common/cleanups.c (cleanup_chain, make_cleanup)
9328         (make_cleanup_dtor, all_cleanups, do_cleanups)
9329         (discard_my_cleanups, discard_cleanups)
9330         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9331         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9332         (null_cleanup): Remove.
9333         (do_final_cleanups): Remove parameter.
9334
9335 2019-03-06  Tom Tromey  <tom@tromey.com>
9336
9337         * remote.c (remote_target::remote_parse_stop_reply): Use
9338         unique_xmalloc_ptr.
9339
9340 2019-03-06  Tom Tromey  <tom@tromey.com>
9341
9342         * stabsread.c (struct stabs_field_info): Rename from field_info.
9343         <list, fnlist>: Add initializers.
9344         <obstack>: New member.
9345         (read_member_functions, read_struct_fields, read_baseclasses):
9346         Allocate on obstack.  Don't use cleanups.
9347         (read_one_struct_field, read_member_functions, read_struct_fields)
9348         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9349         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9350         (read_struct_type): Update.
9351
9352 2019-03-06  Tom Tromey  <tom@tromey.com>
9353
9354         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9355         * common/filestuff.h (make_cleanup_close): Don't declare.
9356         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9357         Remove.
9358
9359 2019-03-06  Tom Tromey  <tom@tromey.com>
9360
9361         * solib-aix.c: Use make_scope_exit.
9362
9363 2019-03-06  Tom Tromey  <tom@tromey.com>
9364
9365         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9366         Use make_scope_exit.
9367
9368 2019-03-06  Tom Tromey  <tom@tromey.com>
9369
9370         * solib-svr4.c (disable_probes_interface): Remove parameter.
9371         (svr4_handle_solib_event): Use make_scope_exit.
9372
9373 2019-03-06  Tom Tromey  <tom@tromey.com>
9374
9375         * remote.c (struct stop_reply_deleter): Remove.
9376         (stop_reply_up): Update.
9377         (struct stop_reply): Derive from notif_event.  Don't typedef.
9378         <regcache>: Now a std::vector.
9379         (stop_reply_xfree): Remove.
9380         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9381         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9382         (remote_target::discard_pending_stop_replies): Use delete.
9383         (remote_target::remote_parse_stop_reply): Update.
9384         (remote_target::process_stop_reply): Update.
9385         * remote-notif.h (struct notif_event): Add virtual destructor.
9386         Remove "dtr" member.
9387         (struct notif_client) <alloc_event>: Return a unique_ptr.
9388         (notif_event_xfree): Don't declare.
9389         (notif_event_up): New typedef.
9390         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9391         (notif_event_xfree, do_notif_event_xfree): Remove.
9392         (remote_notif_state_xfree): Update.
9393
9394 2019-03-06  Tom Tromey  <tom@tromey.com>
9395
9396         * infrun.c (displaced_step_clear_cleanup): Now a
9397         forward_scope_exit type.
9398         (displaced_step_prepare_throw): Update.
9399         (displaced_step_fixup): Update.
9400
9401 2019-03-06  Tom Tromey  <tom@tromey.com>
9402
9403         * inferior.h (class inferior): Update comment.
9404         * gdbthread.h (class thread_info): Update comment.
9405
9406 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9407             Tom Tromey  <tom@tromey.com>
9408
9409         * stabsread.h (struct stab_section_list): Remove.
9410         (coffstab_build_psymtabs): Update.
9411         * dbxread.c (symbuf_sections): Now a std::vector.
9412         (sect_idx): New global.
9413         (fill_symbuf): Update.
9414         (coffstab_build_psymtabs): Change type of stabsects parameter.
9415         Update.
9416         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9417         std::vector.
9418         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9419         (coff_locate_sections): Update.
9420         (coff_symfile_read): Remove cleanups.  Update.
9421         (init_stringtab): Add storage parameter.
9422         (free_stringtab, free_stringtab_cleanup): Remove.
9423         (init_lineno): Add storage parameter.
9424         (free_linetab, free_linetab_cleanup): Remove.
9425
9426 2019-03-06  Pedro Alves  <palves@redhat.com>
9427
9428         * linux-fork.c (fork_info::clobber_regs): Delete.
9429         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9430         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9431         comment.  Adjust.
9432         (scoped_switch_fork_info::scoped_switch_fork_info)
9433         (checkpoint_command, linux_fork_context): Adjust
9434         fork_save_infrun_state calls.
9435
9436 2019-03-06  Pedro Alves  <palves@redhat.com>
9437
9438         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9439         (inf_has_multiple_threads): Return 'bool' and rewrite using
9440         inferior_info::threads().
9441
9442 2019-03-06  Pedro Alves  <palves@redhat.com>
9443
9444         * linux-fork.c: Include <list>.
9445         (fork_list): Now a std::list instance.
9446         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9447         (forks_exist_p, find_last_fork): Adjust.
9448         (new_fork): Delete.
9449         (one_fork_p): New.
9450         (add_fork): Adjust.
9451         (free_fork): Delete, folded into fork_info::~fork_info().
9452         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9453         Adjust.
9454         (init_fork_list): Delete.
9455         (linux_fork_killall, linux_fork_mourn_inferior)
9456         (linux_fork_detach, info_checkpoints_command): Adjust.
9457         (_initialize_linux_fork): No longer call init_fork_list.
9458
9459 2019-03-06  Pedro Alves  <palves@redhat.com>
9460
9461         * linux-fork.c (new_fork): New, split out of ...
9462         (add_fork): ... this.  Return void.  Move "first fork" special
9463         case from here, to ...
9464         (checkpoint_command): ... here.
9465         * linux-linux.h (add_fork): Return void.
9466
9467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9468
9469         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9470
9471 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9472             Chris January  <chris.january@arm.com>
9473             David Lecomber  <david.lecomber@arm.com>
9474
9475         * f-exp.y: New token, UNOP_INTRINSIC.
9476         (exp): New pattern using UNOP_INTRINSIC token.
9477         (f77_keywords): Add 'abs' keyword.
9478         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9479         (value_from_host_double): New function.
9480         (evaluate_subexp_f): Support UNOP_ABS.
9481
9482 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9483
9484         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9485         types.
9486
9487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9488
9489         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9490         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9491         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9492
9493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9494
9495         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9496
9497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9498             Chris January  <chris.january@arm.com>
9499
9500         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9501         * f-exp.y: Define 'KIND' token.
9502         (exp): New pattern for KIND expressions.
9503         (ptype): Handle types with a kind extension.
9504         (direct_abs_decl): Extend to spot kind extensions.
9505         (f77_keywords): Add 'kind' to the list.
9506         (push_kind_type): New function.
9507         (convert_to_kind_type): New function.
9508         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9509         * parse.c (operator_length_standard): Likewise.
9510         * parser-defs.h (enum type_pieces): Add tp_kind.
9511         * std-operator.def: Add UNOP_KIND.
9512
9513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * f-exp.y (f_parse): Set yydebug.
9516
9517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9518
9519         * f-lang.c (evaluate_subexp_f): New function.
9520         (exp_descriptor_f): New global.
9521         (f_language_defn): Use exp_descriptor_f instead of
9522         exp_descriptor_standard.
9523
9524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9525
9526         * f-exp.y (struct token): Add comments.
9527         (dot_ops): Remove uppercase versions and the end marker.
9528         (f77_keywords): Likewise.
9529         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9530         entries in the dot_ops array are case insensitive, and use
9531         strncasecmp to compare strings.  Also some whitespace cleanup in
9532         this area.  Similar for the f77_keywords array, except entries in
9533         this list might be case sensitive.
9534
9535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9536
9537         * f-exp.y (struct f77_boolean_val): Add comments.
9538         (boolean_values): Remove uppercase versions, and end marker.
9539         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9540         and use strncasecmp to achieve case insensitivity.  Additionally,
9541         perform whitespace cleanup around this code.
9542
9543 2019-03-06  Tom Tromey  <tromey@adacore.com>
9544
9545         * remote-sim.c (gdbsim_target_open): Use result of
9546         gdb_argv::release.
9547
9548 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9549         Dirk Schubert  <dirk.schubert@arm.com>
9550         Chris January  <chris.january@arm.com>
9551
9552         * eval.c (evaluate_subexp_standard): Call Fortran argument
9553         wrapping logic.
9554         * f-lang.c (struct value): A value which can be passed into a
9555         Fortran function call.
9556         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9557         where appropriate.
9558         (struct type): Value ready for a Fortran function call.
9559         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9560         is needed.
9561         * f-lang.h (fortran_argument_convert): Declaration.
9562         (fortran_preserve_arg_pointer): Declaration.
9563         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9564
9565 2019-03-05  Tom Tromey  <tromey@adacore.com>
9566
9567         * python/py-prettyprint.c (print_string_repr): Remove #if.
9568         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9569
9570 2019-03-05  Tom Tromey  <tromey@adacore.com>
9571
9572         * target.c (the_dummy_target): Move later.  Change type to
9573         "dummy_target".
9574         (initialize_targets): Don't initialize the_dummy_target.
9575
9576 2019-03-05  Tom Tromey  <tromey@adacore.com>
9577
9578         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9579         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9580
9581 2019-03-05  Tom Tromey  <tromey@adacore.com>
9582
9583         * windows-nat.c (windows_nat_target::attach)
9584         (windows_nat_target::detach): Don't call gdb_flush.
9585         * valprint.c (generic_val_print, val_print, val_print_string):
9586         Don't call gdb_flush.
9587         * utils.c (defaulted_query): Don't call gdb_flush.
9588         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9589         * target.c (target_announce_detach): Don't call gdb_flush.
9590         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9591         * remote.c (extended_remote_target::attach): Don't call
9592         gdb_flush.
9593         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9594         * printcmd.c (do_examine): Don't call gdb_flush.
9595         (info_display_command): Don't call gdb_flush.
9596         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9597         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9598         * memattr.c (info_mem_command): Don't call gdb_flush.
9599         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9600         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9601         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9602         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9603         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9604         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9605         (gnu_nat_target::detach): Don't call gdb_flush.
9606         * f-valprint.c (f_val_print): Don't call gdb_flush.
9607         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9608         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9609         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9610         gdb_flush.
9611         * c-valprint.c (c_val_print): Don't call gdb_flush.
9612         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9613
9614 2019-03-05  Tom Tromey  <tromey@adacore.com>
9615
9616         * varobj.c (update_dynamic_varobj_children): Update.
9617         (install_default_visualizer): Use reset, not release.
9618         * value.c (set_internalvar): Update.
9619         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9620         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9621         ATTRIBUTE_UNUSED_RESULT.
9622
9623 2019-03-05  Tom Tromey  <tromey@adacore.com>
9624
9625         * remote.c (class scoped_remote_fd) <release>: Add
9626         ATTRIBUTE_UNUSED_RESULT.
9627
9628 2019-03-05  Tom Tromey  <tromey@adacore.com>
9629
9630         * macroexp.c (struct macro_buffer) <release>: Add
9631         ATTRIBUTE_UNUSED_RESULT.
9632
9633 2019-03-05  Tom Tromey  <tromey@adacore.com>
9634
9635         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9636         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9637         ATTRIBUTE_UNUSED_RESULT.
9638
9639 2019-03-05  Tom Tromey  <tromey@adacore.com>
9640
9641         * common/scoped_fd.h (class scoped_fd) <release>: Add
9642         ATTRIBUTE_UNUSED_RESULT.
9643
9644 2019-03-05  Tom Tromey  <tromey@adacore.com>
9645
9646         * parser-defs.h (struct parser_state) <release>: Add
9647         ATTRIBUTE_UNUSED_RESULT.
9648
9649 2019-03-05  Tom Tromey  <tromey@adacore.com>
9650
9651         * utils.h (class gdb_argv) <release>: Add
9652         ATTRIBUTE_UNUSED_RESULT.
9653         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9654
9655 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9656
9657         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9658         for-loop range, to avoid compiler warnings.
9659
9660         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9661         avoid compiler warnings about unused variables.
9662
9663         * NEWS: Mention end of support for native debugging on MS-Windows
9664         before XP.
9665
9666         PR gdb/24292
9667         * common/netstuff.c:
9668         * gdbserver/gdbreplay.c
9669         * gdbserver/remote-utils.c:
9670         * ser-tcp.c:
9671         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9672         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9673         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9674         'getaddrinfo' and 'freeaddrinfo' were not available before
9675         Windows XP, and mingw.org's MinGW headers by default define
9676         _WIN32_WINNT to 0x500.
9677
9678 2019-03-01  Gary Benson <gbenson@redhat.com>
9679
9680         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9681
9682 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9683             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9684
9685         PR gdb/8527
9686         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9687         set_sigint_trap, clear_sigint_trap.
9688
9689 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9690
9691         * target.c (target_detach): Clear the regcache and the
9692         frame cache.
9693
9694 2019-02-27  Pedro Alves  <palves@redhat.com>
9695
9696         * utils.c (set_screen_size): When we cap the height/width sizes,
9697         tweak the corresponding command variable to show "unlimited":
9698
9699 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9700             Pedro Alves  <palves@redhat.com>
9701
9702         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9703         before calling rl_set_screen_size.
9704
9705 2019-02-27  Tom Tromey  <tromey@adacore.com>
9706
9707         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9708         define.
9709         * python/py-value.c: Remove Python 2.4 workaround.
9710         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9711         workaround.
9712         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9713         Python 2.4 workaround.
9714         * python/python-internal.h: Remove Python 2.4 comment.
9715         (Py_ssize_t): Don't define.
9716         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9717         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9718         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9719         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9720         * python/python.c (do_start_initialization): Remove Python 2.4
9721         workaround.
9722         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9723         (print_children): Remove Python 2.4 workaround.
9724         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9725         workaround.
9726         (CHARBUFFERPROC_NAME): Remove.
9727         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9728         Python 2.4 workaround.
9729
9730 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9731
9732         * NEWS: Note minimum Python version.
9733
9734 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9735
9736         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9737         code from these functions.  Remove corresponding ifdefs.  Use
9738         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9739         Remove gotos and target of gotos.
9740         (infpy_search_memory): Likewise.
9741
9742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9743
9744         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9745         (hppa_gdbarch_init): Don't register deleted functions with
9746         gdbarch.
9747
9748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9749
9750         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9751         (h8300_unwind_sp): Delete.
9752         (h8300_dummy_id): Delete.
9753         (h8300_gdbarch_init): Don't register deleted functions with
9754         gdbarch.
9755
9756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9757
9758         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9759         (ft32_unwind_pc): Delete.
9760         (ft32_unwind_sp): Delete.
9761         (ft32_gdbarch_init): Don't register deleted functions with
9762         gdbarch.
9763
9764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9765
9766         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9767         (frv_unwind_pc): Delete.
9768         (frv_unwind_sp): Delete.
9769         (frv_gdbarch_init): Don't register deleted functions with
9770         gdbarch.
9771
9772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9773
9774         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9775         (riscv_unwind_pc): Delete.
9776         (riscv_unwind_sp): Delete.
9777         (riscv_gdbarch_init): Don't register deleted functions with
9778         gdbarch.
9779
9780 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9781
9782         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9783         (csky_unwind_pc): Delete.
9784         (csky_unwind_sp): Delete.
9785         (csky_gdbarch_init): Don't register deleted functions with
9786         gdbarch.
9787
9788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9789
9790         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9791         (cris_unwind_pc): Delete.
9792         (cris_unwind_sp): Delete.
9793         (cris_gdbarch_init): Don't register deleted functions with
9794         gdbarch.
9795
9796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9797
9798         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9799         (bfin_unwind_pc): Delete.
9800         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9801
9802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9803
9804         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9805         (arm_unwind_pc): Delete.
9806         (arm_unwind_sp): Delete.
9807         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9808
9809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9810
9811         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9812         (arc_unwind_pc): Delete.
9813         (arc_unwind_sp): Delete.
9814         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9815
9816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9817
9818         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9819         (alpha_unwind_pc): Delete.
9820         (alpha_gdbarch_init): Don't register deleted functions with
9821         gdbarch.
9822
9823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9824
9825         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9826         (aarch64_unwind_pc): Delete.
9827         (aarch64_unwind_sp): Delete.
9828         (aarch64_gdbarch_init): Don't register deleted functions with
9829         gdbarch.
9830
9831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9832
9833         * gdbtypes.c (type_align): Don't consider static members when
9834         computing structure alignment.
9835
9836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9837
9838         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9839         return 0 for other types.
9840         * arch-utils.c (default_type_align): Always return 0.
9841         * gdbarch.h: Regenerate.
9842         * gdbarch.sh (type_align): Extend comment.
9843         * gdbtypes.c (type_align): Add additional comments, always call
9844         gdbarch_type_align before applying the default rules.
9845         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9846         generic code will then apply a suitable default.
9847         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9848         types, return 0 for other types.
9849
9850 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9851
9852         * NEWS: Create a new section for the next release branch.
9853         Rename the section of the current branch, now that it has
9854         been cut.
9855
9856 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9857
9858         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9859         * version.in: Bump version to 8.3.50.DATE-git.
9860
9861 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9862
9863         * aix-thread.c (ptid_cmp): Remove unused variable.
9864         (get_signaled_thread): Likewise.
9865         (store_regs_user_thread): Likewise.
9866         (store_regs_kernel_thread): Likewise.
9867         (fetch_regs_kernel_thread): Remove shadowed variable.
9868
9869 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9870
9871         * features/riscv/32bit-cpu.xml: Add register numbers.
9872         * features/riscv/32bit-fpu.c: Regenerate.
9873         * features/riscv/32bit-fpu.xml: Add register numbers.
9874         * features/riscv/64bit-cpu.xml: Add register numbers.
9875         * features/riscv/64bit-fpu.c: Regenerate.
9876         * features/riscv/64bit-fpu.xml: Add register numbers.
9877
9878 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9879
9880         * NEWS: Mention two argument form of gdb.Value constructor.
9881         * python/py-value.c (convert_buffer_and_type_to_value): New
9882         function.
9883         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9884         Add support for handling an optional second argument.  Call
9885         convert_buffer_and_type_to_value as appropriate.
9886         * python/python-internal.h (Py_buffer_deleter): New struct.
9887         (Py_buffer_up): New typedef.
9888
9889 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9890
9891         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9892         instead of releasing ownership.
9893
9894 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9895
9896         * dwarf2read.c (open_and_init_dwp_file): Call
9897         elf_numsections instead of bfd_count_sections to initialize
9898         dwp_file->num_sections.
9899
9900 2019-02-25  Tom Tromey  <tromey@adacore.com>
9901
9902         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9903
9904 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9905
9906         * gcore.in: Add '--readnever' option when invoking GDB.
9907
9908 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9909
9910         * MAINTAINERS: Update my email address.
9911
9912 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9913
9914         * build-id.c (build_id_to_debug_bfd_1): New function.
9915         (build_id_to_debug_bfd): Look for separate debug file in
9916         sysroot.
9917
9918 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9919
9920         * gdbarch.sh: Update the copyright year range that is placed into
9921         generated files.
9922
9923 2019-02-22  Keith Seitz  <keiths@redhat.com>
9924
9925         PR symtab/23853
9926         * linespec.c (create_sals_line_offset): Search for the default
9927         symtab's filename instead of its fullname.
9928
9929 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9930
9931         * NEWS: Update style defaults.
9932
9933 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9934
9935         * main.c (captured_main_1): Disable styling in batch mode.
9936
9937 2019-02-20  Tom Tromey  <tom@tromey.com>
9938
9939         * symtab.c (symtab_symbol_info): Fix typos.
9940
9941 2019-02-20  Tom Tromey  <tromey@adacore.com>
9942
9943         * findcmd.c (_initialize_mem_search): Use upper case for
9944         metasyntactic variables.
9945
9946 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9947
9948         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9949         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9950
9951 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9952
9953         * top.h (source_file_name): Change to std::string.
9954         * top.c (source_file_name): Likewise.
9955         (command_line_input): Adjust.
9956         * cli/cli-script.c (script_from_file): Adjust.
9957
9958 2019-02-19  Tom Tromey  <tromey@adacore.com>
9959
9960         * ravenscar-thread.c
9961         (ravenscar_thread_target::update_thread_list): Don't call
9962         ada_build_task_list.
9963         * ada-lang.h (ada_build_task_list): Don't declare.
9964         * ada-tasks.c (struct ada_tasks_inferior_data)
9965         <task_list_valid_p>: Now bool.
9966         (read_known_tasks, ada_task_list_changed)
9967         (ada_tasks_invalidate_inferior_data): Update.
9968         (read_known_tasks_array): Return bool.
9969         (read_known_tasks_list): Likewise.
9970         (read_known_tasks): Return void.
9971         (ada_build_task_list): Now static.
9972
9973 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9974
9975         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9976         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9977
9978 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9979
9980         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9981         variant for ada_tasks_pspace_data_handle and
9982         ada_tasks_inferior_data_handle.
9983         (ada_tasks_pspace_data_cleanup): New function.
9984         (ada_tasks_inferior_data_cleanup): New function.
9985
9986 2019-02-17  Tom Tromey  <tom@tromey.com>
9987
9988         * macrotab.h (macro_source_fullname): Return a std::string.
9989         * macrotab.c (macro_include, check_for_redefinition)
9990         (macro_undef, macro_lookup_definition, foreach_macro)
9991         (foreach_macro_in_scope): Update.
9992         (macro_source_fullname): Return a std::string.
9993         * macrocmd.c (show_pp_source_pos): Update.
9994
9995 2019-02-17  Tom Tromey  <tom@tromey.com>
9996
9997         * macrocmd.c (show_pp_source_pos): Style the file names.
9998
9999 2019-02-17  Tom Tromey  <tom@tromey.com>
10000
10001         PR tui/24197:
10002         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10003
10004 2019-02-17  Tom Tromey  <tom@tromey.com>
10005
10006         * ada-lang.c (user_select_syms): Use filtered printing.
10007         * utils.c (wrap_style): New global.
10008         (desired_style): Remove.
10009         (emit_style_escape): Add stream parameter.
10010         (set_output_style, reset_terminal_style, prompt_for_continue):
10011         Update.
10012         (flush_wrap_buffer): Only flush gdb_stdout.
10013         (wrap_here): Set wrap_style.
10014         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10015         treat escape sequences as a character.  Change when wrap buffer is
10016         flushed.
10017         (fputs_styled): Do not set the output style when the default is
10018         requested.
10019         * ui-style.h (struct ui_file_style) <is_default>: New method.
10020         * source.c (print_source_lines_base): Emit escape sequences in one
10021         piece.
10022
10023 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10024
10025         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10026         integers and enumeration types.
10027
10028 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10029
10030         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10031         instead of lookup_symbol_in_language
10032         (do_exact_match): New function.
10033         (ada_get_symbol_name_matcher): Return do_exact_match when
10034         doing a verbatim match.
10035
10036 2019-02-15  Tom Tromey  <tromey@adacore.com>
10037
10038         * ravenscar-thread.c (ravenscar_thread_target::resume)
10039         (ravenscar_thread_target::wait): Special case wildcard requests.
10040
10041 2019-02-15  Tom Tromey  <tromey@adacore.com>
10042
10043         * ravenscar-thread.c (base_ptid): Remove.
10044         (struct ravenscar_thread_target) <close>: New method.
10045         <m_base_ptid>: New member.
10046         <update_inferior_ptid, active_task, task_is_currently_active,
10047         runtime_initialized>: Declare methods.
10048         <ravenscar_thread_target>: Add constructor.
10049         (ravenscar_thread_target::task_is_currently_active)
10050         (ravenscar_thread_target::update_inferior_ptid)
10051         (ravenscar_runtime_initialized): Rename.  Now methods.
10052         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10053         (ravenscar_thread_target::update_thread_list): Update.
10054         (ravenscar_thread_target::active_task): Now method.
10055         (ravenscar_thread_target::store_registers)
10056         (ravenscar_thread_target::prepare_to_store)
10057         (ravenscar_thread_target::prepare_to_store)
10058         (ravenscar_thread_target::mourn_inferior): Update.
10059         (ravenscar_inferior_created): Use "new" to create target.
10060         (ravenscar_thread_target::get_ada_task_ptid): Update.
10061         (_initialize_ravenscar): Don't initialize base_ptid.
10062         (ravenscar_ops): Remove global.
10063
10064 2019-02-15  Tom Tromey  <tromey@adacore.com>
10065
10066         * target.h (push_target): Declare new overload.
10067         * target.c (push_target): New overload, taking an rvalue reference.
10068         * remote.c (remote_target::open_1): Use push_target overload.
10069         * corelow.c (core_target_open): Use push_target overload.
10070
10071 2019-02-15  Tom Tromey  <tromey@adacore.com>
10072
10073         * ravenscar-thread.c (is_ravenscar_task)
10074         (ravenscar_task_is_currently_active): Return bool.
10075         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10076         (_initialize_ravenscar): Remove "(void)".
10077         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10078         Return bool.
10079
10080 2019-02-15  Tom Tromey  <tromey@adacore.com>
10081
10082         * ravenscar-thread.c (ravenscar_runtime_initializer)
10083         (has_ravenscar_runtime, get_running_thread_id)
10084         (ravenscar_thread_target::resume): Fix indentation.
10085
10086 2019-02-15  Tom Tromey  <tromey@adacore.com>
10087
10088         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10089         from ravenscar_arch_ops.
10090         (sparc_ravenscar_ops::fetch_registers)
10091         (sparc_ravenscar_ops::store_registers): Now methods.
10092         (sparc_ravenscar_prepare_to_store): Remove.
10093         (sparc_ravenscar_ops): Redefine.
10094         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10095         methods and destructor.  Remove members.
10096         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10097         (ravenscar_thread_target::store_registers)
10098         (ravenscar_thread_target::prepare_to_store): Update.
10099         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10100         Remove.
10101         (struct ppc_ravenscar_powerpc_ops): Derive from
10102         ravenscar_arch_ops.
10103         (ppc_ravenscar_powerpc_ops::fetch_registers)
10104         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10105         (ppc_ravenscar_powerpc_ops): Redefine.
10106         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10107         (ppc_ravenscar_e500_ops::fetch_registers)
10108         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10109         (ppc_ravenscar_e500_ops): Redefine.
10110         * aarch64-ravenscar-thread.c
10111         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10112         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10113         (aarch64_ravenscar_fetch_registers)
10114         (aarch64_ravenscar_store_registers): Now methods.
10115         (aarch64_ravenscar_ops): Redefine.
10116
10117 2019-02-15  Tom Tromey  <tromey@adacore.com>
10118
10119         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10120         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10121         (ravenscar_thread_target::stopped_by_watchpoint)
10122         (ravenscar_thread_target::stopped_data_address)
10123         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10124
10125 2019-02-15  Tom Tromey  <tromey@adacore.com>
10126
10127         * ravenscar-thread.c: Fix some typos.
10128
10129 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10130             Tom Tromey  <tromey@adacore.com>
10131
10132         * ada-lang.c (ada_exception_sal): Change addr_string to a
10133         std::string.
10134         (create_ada_exception_catchpoint): Update.
10135
10136 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10137             Tom Tromey  <tromey@adacore.com>
10138
10139         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10140         (bp_location_ops): Remove.
10141         (base_breakpoint_allocate_location): Update.
10142         (free_bp_location): Update.
10143         * ada-lang.c (class ada_catchpoint_location)
10144         <ada_catchpoint_location>: Remove ops parameter.
10145         (ada_catchpoint_location_dtor): Remove.
10146         (ada_catchpoint_location_ops): Remove.
10147         (allocate_location_exception): Update.
10148         * breakpoint.h (struct bp_location_ops): Remove.
10149         (class bp_location) <bp_location>: Remove bp_location_ops
10150         parameter.
10151         <~bp_location>: Add destructor.
10152         <ops>: Remove.
10153
10154 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10155             Pedro Alves  <palves@redhat.com>
10156
10157         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10158         'PATH_MAX'.
10159
10160 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10161             Samuel Thibault  <samuel.thibault@gnu.org>
10162             Thomas Schwinge  <thomas@codesourcery.com>
10163
10164         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10165         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10166
10167 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10168
10169         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10170         (check_empty): Use "const char *".
10171
10172         * gnu-nat.c (gnu_nat_target::detach): Instead of
10173         'detach_inferior (pid)' call
10174         'detach_inferior (find_inferior_pid (pid))'.
10175
10176         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10177         'nat/fork-inferior.o'.
10178         * gnu-nat.c: #include "nat/fork-inferior.h".
10179
10180         * gnu-nat.c (gnu_nat_target::detach): Instead of
10181         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10182         * gnu-nat.h: #include "inf-child.h".
10183         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10184         'i386_gnu_nat_target::fetch_registers'.
10185         (gnu_store_registers): Rename/move to
10186         'i386_gnu_nat_target::store_registers'.
10187
10188         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10189         * gnu-nat.h (mach_thread_info): New function.
10190         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10191
10192         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10193
10194 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10195
10196         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10197
10198 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10199
10200         * windows-nat.c (windows_add_thread): Add new parameter
10201         "main_thread_p" with default value set to false.  Update
10202         function documentation as well as all callers.
10203         (windows_delete_thread): Likewise.
10204         (fake_create_process): Update call to windows_add_thread.
10205         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10206         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10207         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10208         call to windows_delete_thread.
10209
10210 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10211
10212         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10213
10214 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10215
10216         * symfile.c (find_separate_debug_file): Use canonical path of
10217         sysroot with child_path instead of gdb_sysroot if it is valid.
10218
10219 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10220
10221         * symfile.c (find_separate_debug_file): Use child_path to
10222         determine if an object file is under a sysroot.
10223
10224 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10225
10226         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10227         unittests/child-path-selftests.c.
10228         * common/pathstuff.c (child_path): New function.
10229         * common/pathstuff.h (child_path): New prototype.
10230         * unittests/child-path-selftests.c: New file.
10231
10232 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10233
10234         * symfile.c (find_separate_debug_file): Look for separate debug
10235         files in debug directories under the sysroot.
10236
10237 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10238
10239         * symtab.h (struct minimal_symbol data_p): New const method.
10240         (struct minimal_symbol text_p): Likewise.
10241         * symtab.c (output_source_filename): Use file name style
10242         to print file name.
10243         (print_symbol_info): Likewise.
10244         (print_msymbol_info): Use address style to print addresses.
10245         Use function name style to print executable text symbols.
10246         (expand_symtab_containing_pc): Use data_p.
10247         (find_pc_sect_compunit_symtab): Likewise.
10248
10249 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10250
10251         * breakpoint.c (describe_other_breakpoints): Use address style
10252         to print addresses.
10253         (say_where): Likewise.
10254
10255 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10256
10257         * ada-typeprint.c (print_func_type): Print function name
10258         style to print function name.
10259         * c-typeprint.c (c_print_type_1): Likewise.
10260
10261 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10262
10263         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10264         for execve.
10265
10266 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10267
10268         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10269         type_stack.
10270
10271 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10272
10273         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10274         TYPE_CODE_REF types.
10275
10276 2019-02-08  Jim Wilson  <jimw@sifive.com>
10277
10278         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10279         (riscv_linux_fregset): New.
10280         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10281
10282 2019-02-07  Tom Tromey  <tom@tromey.com>
10283
10284         * thread.c (thread_cancel_execution_command): Update.
10285         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10286         methods.
10287         (struct thread_fsm_ops): Remove.
10288         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10289         (thread_fsm_should_stop, thread_fsm_return_value)
10290         (thread_fsm_set_finished, thread_fsm_finished_p)
10291         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10292         Don't declare.
10293         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10294         * infrun.c (clear_proceed_status_thread)
10295         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10296         (print_stop_event): Update.
10297         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10298         Add constructor.
10299         (step_command_fsm_ops): Remove.
10300         (new_step_command_fsm): Remove.
10301         (step_1): Update.
10302         (step_command_fsm::should_stop): Rename from
10303         step_command_fsm_should_stop.
10304         (step_command_fsm::clean_up): Rename from
10305         step_command_fsm_clean_up.
10306         (step_command_fsm::do_async_reply_reason): Rename from
10307         step_command_fsm_async_reply_reason.
10308         (struct until_next_fsm): Inherit from thread_fsm.  Add
10309         constructor.
10310         (until_next_fsm_ops): Remove.
10311         (new_until_next_fsm): Remove.
10312         (until_next_fsm::should_stop): Rename from
10313         until_next_fsm_should_stop.
10314         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10315         (until_next_fsm::do_async_reply_reason): Rename from
10316         until_next_fsm_async_reply_reason.
10317         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10318         constructor.  Change type of breakpoint.
10319         (finish_command_fsm_ops): Remove.
10320         (new_finish_command_fsm): Remove.
10321         (finish_command_fsm::should_stop): Rename from
10322         finish_command_fsm_should_stop.
10323         (finish_command_fsm::clean_up): Rename from
10324         finish_command_fsm_clean_up.
10325         (finish_command_fsm::return_value): Rename from
10326         finish_command_fsm_return_value.
10327         (finish_command_fsm::do_async_reply_reason): Rename from
10328         finish_command_fsm_async_reply_reason.
10329         (finish_command): Update.
10330         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10331         Add constructor.
10332         (call_thread_fsm_ops): Remove.
10333         (call_thread_fsm::call_thread_fsm): Rename from
10334         new_call_thread_fsm.
10335         (call_thread_fsm::should_stop): Rename from
10336         call_thread_fsm_should_stop.
10337         (call_thread_fsm::should_notify_stop): Rename from
10338         call_thread_fsm_should_notify_stop.
10339         (run_inferior_call, call_function_by_hand_dummy): Update.
10340         * cli/cli-interp.c (should_print_stop_to_console): Update.
10341         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10342         Add constructor.  Change type of location_breakpoint,
10343         caller_breakpoint.
10344         (until_break_fsm_ops): Remove.
10345         (new_until_break_fsm): Remove.
10346         (until_break_fsm::should_stop): Rename from
10347         until_break_fsm_should_stop.
10348         (until_break_fsm::clean_up): Rename from
10349         until_break_fsm_clean_up.
10350         (until_break_fsm::do_async_reply_reason): Rename from
10351         until_break_fsm_async_reply_reason.
10352         (until_break_command): Update.
10353         * thread-fsm.c: Remove.
10354         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10355
10356 2019-02-07  Tom Tromey  <tom@tromey.com>
10357
10358         * yy-remap.h: Add include guard.
10359         * xtensa-tdep.h: Add include guard.
10360         * xcoffread.h: Rename include guard.
10361         * varobj-iter.h: Add include guard.
10362         * tui/tui.h: Rename include guard.
10363         * tui/tui-winsource.h: Rename include guard.
10364         * tui/tui-wingeneral.h: Rename include guard.
10365         * tui/tui-windata.h: Rename include guard.
10366         * tui/tui-win.h: Rename include guard.
10367         * tui/tui-stack.h: Rename include guard.
10368         * tui/tui-source.h: Rename include guard.
10369         * tui/tui-regs.h: Rename include guard.
10370         * tui/tui-out.h: Rename include guard.
10371         * tui/tui-layout.h: Rename include guard.
10372         * tui/tui-io.h: Rename include guard.
10373         * tui/tui-hooks.h: Rename include guard.
10374         * tui/tui-file.h: Rename include guard.
10375         * tui/tui-disasm.h: Rename include guard.
10376         * tui/tui-data.h: Rename include guard.
10377         * tui/tui-command.h: Rename include guard.
10378         * tic6x-tdep.h: Add include guard.
10379         * target/waitstatus.h: Rename include guard.
10380         * target/wait.h: Rename include guard.
10381         * target/target.h: Rename include guard.
10382         * target/resume.h: Rename include guard.
10383         * target-float.h: Rename include guard.
10384         * stabsread.h: Add include guard.
10385         * rs6000-tdep.h: Add include guard.
10386         * riscv-fbsd-tdep.h: Add include guard.
10387         * regformats/regdef.h: Rename include guard.
10388         * record.h: Rename include guard.
10389         * python/python.h: Rename include guard.
10390         * python/python-internal.h: Rename include guard.
10391         * python/py-stopevent.h: Rename include guard.
10392         * python/py-ref.h: Rename include guard.
10393         * python/py-record.h: Rename include guard.
10394         * python/py-record-full.h: Rename include guard.
10395         * python/py-record-btrace.h: Rename include guard.
10396         * python/py-instruction.h: Rename include guard.
10397         * python/py-events.h: Rename include guard.
10398         * python/py-event.h: Rename include guard.
10399         * procfs.h: Add include guard.
10400         * proc-utils.h: Add include guard.
10401         * p-lang.h: Add include guard.
10402         * or1k-tdep.h: Rename include guard.
10403         * observable.h: Rename include guard.
10404         * nto-tdep.h: Rename include guard.
10405         * nat/x86-linux.h: Rename include guard.
10406         * nat/x86-linux-dregs.h: Rename include guard.
10407         * nat/x86-gcc-cpuid.h: Add include guard.
10408         * nat/x86-dregs.h: Rename include guard.
10409         * nat/x86-cpuid.h: Rename include guard.
10410         * nat/ppc-linux.h: Rename include guard.
10411         * nat/mips-linux-watch.h: Rename include guard.
10412         * nat/linux-waitpid.h: Rename include guard.
10413         * nat/linux-ptrace.h: Rename include guard.
10414         * nat/linux-procfs.h: Rename include guard.
10415         * nat/linux-osdata.h: Rename include guard.
10416         * nat/linux-nat.h: Rename include guard.
10417         * nat/linux-namespaces.h: Rename include guard.
10418         * nat/linux-btrace.h: Rename include guard.
10419         * nat/glibc_thread_db.h: Rename include guard.
10420         * nat/gdb_thread_db.h: Rename include guard.
10421         * nat/gdb_ptrace.h: Rename include guard.
10422         * nat/fork-inferior.h: Rename include guard.
10423         * nat/amd64-linux-siginfo.h: Rename include guard.
10424         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10425         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10426         * nat/aarch64-linux.h: Rename include guard.
10427         * nat/aarch64-linux-hw-point.h: Rename include guard.
10428         * mn10300-tdep.h: Add include guard.
10429         * mips-linux-tdep.h: Add include guard.
10430         * mi/mi-parse.h: Rename include guard.
10431         * mi/mi-out.h: Rename include guard.
10432         * mi/mi-main.h: Rename include guard.
10433         * mi/mi-interp.h: Rename include guard.
10434         * mi/mi-getopt.h: Rename include guard.
10435         * mi/mi-console.h: Rename include guard.
10436         * mi/mi-common.h: Rename include guard.
10437         * mi/mi-cmds.h: Rename include guard.
10438         * mi/mi-cmd-break.h: Rename include guard.
10439         * m2-lang.h: Add include guard.
10440         * location.h: Rename include guard.
10441         * linux-record.h: Rename include guard.
10442         * linux-nat.h: Add include guard.
10443         * linux-fork.h: Add include guard.
10444         * i386-darwin-tdep.h: Rename include guard.
10445         * hppa-linux-offsets.h: Add include guard.
10446         * guile/guile.h: Rename include guard.
10447         * guile/guile-internal.h: Rename include guard.
10448         * gnu-nat.h: Rename include guard.
10449         * gdb-stabs.h: Rename include guard.
10450         * frv-tdep.h: Add include guard.
10451         * f-lang.h: Add include guard.
10452         * event-loop.h: Add include guard.
10453         * darwin-nat.h: Rename include guard.
10454         * cp-abi.h: Rename include guard.
10455         * config/sparc/nm-sol2.h: Rename include guard.
10456         * config/nm-nto.h: Rename include guard.
10457         * config/nm-linux.h: Add include guard.
10458         * config/i386/nm-i386gnu.h: Rename include guard.
10459         * config/djgpp/nl_types.h: Rename include guard.
10460         * config/djgpp/langinfo.h: Rename include guard.
10461         * compile/gcc-cp-plugin.h: Add include guard.
10462         * compile/gcc-c-plugin.h: Add include guard.
10463         * compile/compile.h: Rename include guard.
10464         * compile/compile-object-run.h: Rename include guard.
10465         * compile/compile-object-load.h: Rename include guard.
10466         * compile/compile-internal.h: Rename include guard.
10467         * compile/compile-cplus.h: Rename include guard.
10468         * compile/compile-c.h: Rename include guard.
10469         * common/xml-utils.h: Rename include guard.
10470         * common/x86-xstate.h: Rename include guard.
10471         * common/version.h: Rename include guard.
10472         * common/vec.h: Rename include guard.
10473         * common/tdesc.h: Rename include guard.
10474         * common/selftest.h: Rename include guard.
10475         * common/scoped_restore.h: Rename include guard.
10476         * common/scoped_mmap.h: Rename include guard.
10477         * common/scoped_fd.h: Rename include guard.
10478         * common/safe-iterator.h: Rename include guard.
10479         * common/run-time-clock.h: Rename include guard.
10480         * common/refcounted-object.h: Rename include guard.
10481         * common/queue.h: Rename include guard.
10482         * common/ptid.h: Rename include guard.
10483         * common/print-utils.h: Rename include guard.
10484         * common/preprocessor.h: Rename include guard.
10485         * common/pathstuff.h: Rename include guard.
10486         * common/observable.h: Rename include guard.
10487         * common/netstuff.h: Rename include guard.
10488         * common/job-control.h: Rename include guard.
10489         * common/host-defs.h: Rename include guard.
10490         * common/gdb_wait.h: Rename include guard.
10491         * common/gdb_vecs.h: Rename include guard.
10492         * common/gdb_unlinker.h: Rename include guard.
10493         * common/gdb_unique_ptr.h: Rename include guard.
10494         * common/gdb_tilde_expand.h: Rename include guard.
10495         * common/gdb_sys_time.h: Rename include guard.
10496         * common/gdb_string_view.h: Rename include guard.
10497         * common/gdb_splay_tree.h: Rename include guard.
10498         * common/gdb_setjmp.h: Rename include guard.
10499         * common/gdb_ref_ptr.h: Rename include guard.
10500         * common/gdb_optional.h: Rename include guard.
10501         * common/gdb_locale.h: Rename include guard.
10502         * common/gdb_assert.h: Rename include guard.
10503         * common/filtered-iterator.h: Rename include guard.
10504         * common/filestuff.h: Rename include guard.
10505         * common/fileio.h: Rename include guard.
10506         * common/environ.h: Rename include guard.
10507         * common/common-utils.h: Rename include guard.
10508         * common/common-types.h: Rename include guard.
10509         * common/common-regcache.h: Rename include guard.
10510         * common/common-inferior.h: Rename include guard.
10511         * common/common-gdbthread.h: Rename include guard.
10512         * common/common-exceptions.h: Rename include guard.
10513         * common/common-defs.h: Rename include guard.
10514         * common/common-debug.h: Rename include guard.
10515         * common/cleanups.h: Rename include guard.
10516         * common/buffer.h: Rename include guard.
10517         * common/btrace-common.h: Rename include guard.
10518         * common/break-common.h: Rename include guard.
10519         * cli/cli-utils.h: Rename include guard.
10520         * cli/cli-style.h: Rename include guard.
10521         * cli/cli-setshow.h: Rename include guard.
10522         * cli/cli-script.h: Rename include guard.
10523         * cli/cli-interp.h: Rename include guard.
10524         * cli/cli-decode.h: Rename include guard.
10525         * cli/cli-cmds.h: Rename include guard.
10526         * charset-list.h: Add include guard.
10527         * buildsym-legacy.h: Rename include guard.
10528         * bfin-tdep.h: Add include guard.
10529         * ax.h: Rename include guard.
10530         * arm-linux-tdep.h: Add include guard.
10531         * arm-fbsd-tdep.h: Add include guard.
10532         * arch/xtensa.h: Rename include guard.
10533         * arch/tic6x.h: Add include guard.
10534         * arch/i386.h: Add include guard.
10535         * arch/arm.h: Rename include guard.
10536         * arch/arm-linux.h: Rename include guard.
10537         * arch/arm-get-next-pcs.h: Rename include guard.
10538         * arch/amd64.h: Add include guard.
10539         * arch/aarch64-insn.h: Rename include guard.
10540         * arch-utils.h: Rename include guard.
10541         * annotate.h: Add include guard.
10542         * amd64-darwin-tdep.h: Rename include guard.
10543         * aarch64-linux-tdep.h: Add include guard.
10544         * aarch64-fbsd-tdep.h: Add include guard.
10545         * aarch32-linux-nat.h: Add include guard.
10546
10547 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10548
10549         * macrotab.c (macro_define_internal): New function that
10550         factorizes macro_define_object_internal and macro_define_function
10551         code.
10552         (macro_define_object_internal): Use macro_define_internal.
10553         (macro_define_function): Likewise.
10554
10555 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10556
10557         * macrocmd.c (extract_identifier): Return
10558         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10559         callers.
10560
10561 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10562
10563         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10564
10565 2019-02-05  Tom Tromey  <tom@tromey.com>
10566
10567         * target.c (target_stack::unpush): Move assertion earlier.
10568
10569 2019-01-30  Tom Tromey  <tom@tromey.com>
10570
10571         PR python/23615:
10572         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10573         (gdbpy_parse_and_eval): Likewise.
10574         * python/python-internal.h (gdbpy_allow_threads): New class.
10575
10576 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10577
10578         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10579         (aarch64_fbsd_fpregmap): Move earlier.
10580         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10581         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10582         instead of individual calls to trad_frame_set_reg_addr.
10583         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10584         earlier.
10585         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10586         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10587         instead of individual calls to trad_frame_set_reg_addr.
10588
10589 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10590
10591         * CONTRIBUTE: Replace contribution list with wiki link.
10592
10593 2019-01-25  Tom Tromey  <tom@tromey.com>
10594
10595         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10596
10597 2019-01-25  Tom Tromey  <tom@tromey.com>
10598
10599         * xtensa-linux-nat.c: Fix common/ includes.
10600         * xml-support.h: Fix common/ includes.
10601         * xml-support.c: Fix common/ includes.
10602         * x86-linux-nat.c: Fix common/ includes.
10603         * windows-nat.c: Fix common/ includes.
10604         * varobj.h: Fix common/ includes.
10605         * varobj.c: Fix common/ includes.
10606         * value.c: Fix common/ includes.
10607         * valops.c: Fix common/ includes.
10608         * utils.c: Fix common/ includes.
10609         * unittests/xml-utils-selftests.c: Fix common/ includes.
10610         * unittests/utils-selftests.c: Fix common/ includes.
10611         * unittests/unpack-selftests.c: Fix common/ includes.
10612         * unittests/tracepoint-selftests.c: Fix common/ includes.
10613         * unittests/style-selftests.c: Fix common/ includes.
10614         * unittests/string_view-selftests.c: Fix common/ includes.
10615         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10616         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10617         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10618         * unittests/rsp-low-selftests.c: Fix common/ includes.
10619         * unittests/parse-connection-spec-selftests.c: Fix common/
10620         includes.
10621         * unittests/optional-selftests.c: Fix common/ includes.
10622         * unittests/offset-type-selftests.c: Fix common/ includes.
10623         * unittests/observable-selftests.c: Fix common/ includes.
10624         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10625         * unittests/memrange-selftests.c: Fix common/ includes.
10626         * unittests/memory-map-selftests.c: Fix common/ includes.
10627         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10628         * unittests/function-view-selftests.c: Fix common/ includes.
10629         * unittests/environ-selftests.c: Fix common/ includes.
10630         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10631         * unittests/common-utils-selftests.c: Fix common/ includes.
10632         * unittests/cli-utils-selftests.c: Fix common/ includes.
10633         * unittests/array-view-selftests.c: Fix common/ includes.
10634         * ui-file.c: Fix common/ includes.
10635         * tui/tui-io.c: Fix common/ includes.
10636         * tracepoint.h: Fix common/ includes.
10637         * tracepoint.c: Fix common/ includes.
10638         * tracefile-tfile.c: Fix common/ includes.
10639         * top.h: Fix common/ includes.
10640         * top.c: Fix common/ includes.
10641         * thread.c: Fix common/ includes.
10642         * target/waitstatus.h: Fix common/ includes.
10643         * target/waitstatus.c: Fix common/ includes.
10644         * target.h: Fix common/ includes.
10645         * target.c: Fix common/ includes.
10646         * target-memory.c: Fix common/ includes.
10647         * target-descriptions.c: Fix common/ includes.
10648         * symtab.h: Fix common/ includes.
10649         * symfile.c: Fix common/ includes.
10650         * stap-probe.c: Fix common/ includes.
10651         * spu-linux-nat.c: Fix common/ includes.
10652         * sparc-nat.c: Fix common/ includes.
10653         * source.c: Fix common/ includes.
10654         * solib.c: Fix common/ includes.
10655         * solib-target.c: Fix common/ includes.
10656         * ser-unix.c: Fix common/ includes.
10657         * ser-tcp.c: Fix common/ includes.
10658         * ser-pipe.c: Fix common/ includes.
10659         * ser-base.c: Fix common/ includes.
10660         * selftest-arch.c: Fix common/ includes.
10661         * s12z-tdep.c: Fix common/ includes.
10662         * rust-exp.y: Fix common/ includes.
10663         * rs6000-aix-tdep.c: Fix common/ includes.
10664         * riscv-tdep.c: Fix common/ includes.
10665         * remote.c: Fix common/ includes.
10666         * remote-notif.h: Fix common/ includes.
10667         * remote-fileio.h: Fix common/ includes.
10668         * remote-fileio.c: Fix common/ includes.
10669         * regcache.h: Fix common/ includes.
10670         * regcache.c: Fix common/ includes.
10671         * record-btrace.c: Fix common/ includes.
10672         * python/python.c: Fix common/ includes.
10673         * python/py-type.c: Fix common/ includes.
10674         * python/py-inferior.c: Fix common/ includes.
10675         * progspace.h: Fix common/ includes.
10676         * producer.c: Fix common/ includes.
10677         * procfs.c: Fix common/ includes.
10678         * proc-api.c: Fix common/ includes.
10679         * printcmd.c: Fix common/ includes.
10680         * ppc-linux-nat.c: Fix common/ includes.
10681         * parser-defs.h: Fix common/ includes.
10682         * osdata.c: Fix common/ includes.
10683         * obsd-nat.c: Fix common/ includes.
10684         * nat/x86-linux.c: Fix common/ includes.
10685         * nat/x86-linux-dregs.c: Fix common/ includes.
10686         * nat/x86-dregs.h: Fix common/ includes.
10687         * nat/x86-dregs.c: Fix common/ includes.
10688         * nat/ppc-linux.c: Fix common/ includes.
10689         * nat/mips-linux-watch.h: Fix common/ includes.
10690         * nat/mips-linux-watch.c: Fix common/ includes.
10691         * nat/linux-waitpid.c: Fix common/ includes.
10692         * nat/linux-ptrace.h: Fix common/ includes.
10693         * nat/linux-ptrace.c: Fix common/ includes.
10694         * nat/linux-procfs.c: Fix common/ includes.
10695         * nat/linux-personality.c: Fix common/ includes.
10696         * nat/linux-osdata.c: Fix common/ includes.
10697         * nat/linux-namespaces.c: Fix common/ includes.
10698         * nat/linux-btrace.h: Fix common/ includes.
10699         * nat/linux-btrace.c: Fix common/ includes.
10700         * nat/fork-inferior.c: Fix common/ includes.
10701         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10702         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10703         * nat/aarch64-linux.c: Fix common/ includes.
10704         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10705         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10706         * namespace.h: Fix common/ includes.
10707         * mips-linux-tdep.c: Fix common/ includes.
10708         * minsyms.c: Fix common/ includes.
10709         * mi/mi-parse.h: Fix common/ includes.
10710         * mi/mi-main.c: Fix common/ includes.
10711         * mi/mi-cmd-env.c: Fix common/ includes.
10712         * memrange.h: Fix common/ includes.
10713         * memattr.c: Fix common/ includes.
10714         * maint.h: Fix common/ includes.
10715         * maint.c: Fix common/ includes.
10716         * main.c: Fix common/ includes.
10717         * machoread.c: Fix common/ includes.
10718         * location.c: Fix common/ includes.
10719         * linux-thread-db.c: Fix common/ includes.
10720         * linux-nat.c: Fix common/ includes.
10721         * linux-fork.c: Fix common/ includes.
10722         * inline-frame.c: Fix common/ includes.
10723         * infrun.c: Fix common/ includes.
10724         * inflow.c: Fix common/ includes.
10725         * inferior.h: Fix common/ includes.
10726         * inferior.c: Fix common/ includes.
10727         * infcmd.c: Fix common/ includes.
10728         * inf-ptrace.c: Fix common/ includes.
10729         * inf-child.c: Fix common/ includes.
10730         * ia64-linux-nat.c: Fix common/ includes.
10731         * i387-tdep.c: Fix common/ includes.
10732         * i386-tdep.c: Fix common/ includes.
10733         * i386-linux-tdep.c: Fix common/ includes.
10734         * i386-linux-nat.c: Fix common/ includes.
10735         * i386-go32-tdep.c: Fix common/ includes.
10736         * i386-fbsd-tdep.c: Fix common/ includes.
10737         * i386-fbsd-nat.c: Fix common/ includes.
10738         * guile/scm-type.c: Fix common/ includes.
10739         * guile/guile.c: Fix common/ includes.
10740         * go32-nat.c: Fix common/ includes.
10741         * gnu-nat.c: Fix common/ includes.
10742         * gdbthread.h: Fix common/ includes.
10743         * gdbarch-selftests.c: Fix common/ includes.
10744         * gdb_usleep.c: Fix common/ includes.
10745         * gdb_select.h: Fix common/ includes.
10746         * gdb_bfd.c: Fix common/ includes.
10747         * gcore.c: Fix common/ includes.
10748         * fork-child.c: Fix common/ includes.
10749         * findvar.c: Fix common/ includes.
10750         * fbsd-nat.c: Fix common/ includes.
10751         * event-top.c: Fix common/ includes.
10752         * event-loop.c: Fix common/ includes.
10753         * dwarf2read.c: Fix common/ includes.
10754         * dwarf2loc.c: Fix common/ includes.
10755         * dwarf2-frame.c: Fix common/ includes.
10756         * dwarf-index-cache.c: Fix common/ includes.
10757         * dtrace-probe.c: Fix common/ includes.
10758         * disasm-selftests.c: Fix common/ includes.
10759         * defs.h: Fix common/ includes.
10760         * csky-tdep.c: Fix common/ includes.
10761         * cp-valprint.c: Fix common/ includes.
10762         * cp-support.h: Fix common/ includes.
10763         * cp-support.c: Fix common/ includes.
10764         * corelow.c: Fix common/ includes.
10765         * completer.h: Fix common/ includes.
10766         * completer.c: Fix common/ includes.
10767         * compile/compile.c: Fix common/ includes.
10768         * compile/compile-loc2c.c: Fix common/ includes.
10769         * compile/compile-cplus-types.c: Fix common/ includes.
10770         * compile/compile-cplus-symbols.c: Fix common/ includes.
10771         * command.h: Fix common/ includes.
10772         * cli/cli-dump.c: Fix common/ includes.
10773         * cli/cli-cmds.c: Fix common/ includes.
10774         * charset.c: Fix common/ includes.
10775         * build-id.c: Fix common/ includes.
10776         * btrace.h: Fix common/ includes.
10777         * btrace.c: Fix common/ includes.
10778         * breakpoint.h: Fix common/ includes.
10779         * breakpoint.c: Fix common/ includes.
10780         * ax.h:
10781         (enum agent_op): Fix common/ includes.
10782         * ax-general.c (struct aop_map): Fix common/ includes.
10783         * ax-gdb.c: Fix common/ includes.
10784         * auxv.c: Fix common/ includes.
10785         * auto-load.c: Fix common/ includes.
10786         * arm-tdep.c: Fix common/ includes.
10787         * arch/riscv.c: Fix common/ includes.
10788         * arch/ppc-linux-common.c: Fix common/ includes.
10789         * arch/i386.c: Fix common/ includes.
10790         * arch/arm.c: Fix common/ includes.
10791         * arch/arm-linux.c: Fix common/ includes.
10792         * arch/arm-get-next-pcs.c: Fix common/ includes.
10793         * arch/amd64.c: Fix common/ includes.
10794         * arch/aarch64.c: Fix common/ includes.
10795         * arch/aarch64-insn.c: Fix common/ includes.
10796         * arch-utils.c: Fix common/ includes.
10797         * amd64-windows-tdep.c: Fix common/ includes.
10798         * amd64-tdep.c: Fix common/ includes.
10799         * amd64-sol2-tdep.c: Fix common/ includes.
10800         * amd64-obsd-tdep.c: Fix common/ includes.
10801         * amd64-nbsd-tdep.c: Fix common/ includes.
10802         * amd64-linux-tdep.c: Fix common/ includes.
10803         * amd64-linux-nat.c: Fix common/ includes.
10804         * amd64-fbsd-tdep.c: Fix common/ includes.
10805         * amd64-fbsd-nat.c: Fix common/ includes.
10806         * amd64-dicos-tdep.c: Fix common/ includes.
10807         * amd64-darwin-tdep.c: Fix common/ includes.
10808         * agent.c: Fix common/ includes.
10809         * ada-lang.h: Fix common/ includes.
10810         * ada-lang.c: Fix common/ includes.
10811         * aarch64-tdep.c: Fix common/ includes.
10812
10813 2019-01-25  Tom Tromey  <tom@tromey.com>
10814
10815         * common/create-version.sh: Use common/version.h.
10816
10817 2019-01-24  Pedro Alves  <palves@redhat.com>
10818
10819         * infrun.c (signal_stop, signal_print, signal_program)
10820         (signal_catch, signal_pass): Now arrays instead of pointers.
10821         (update_signals_program_target, do_target_resume)
10822         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10823         * linux-nat.c (linux_nat_target::pass_signals)
10824         (linux_nat_target::create_inferior, linux_nat_target::attach):
10825         Adjust.
10826         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10827         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10828         * procfs.c (procfs_target::pass_signals): Adjust.
10829         * record-full.c (record_full_target::resume): Adjust.
10830         * remote.c (remote_target::pass_signals)
10831         (remote_target::program_signals): Adjust.
10832         * target-debug.h (target_debug_print_signals): Now takes a
10833         gdb::array_view as parameter.  Adjust.
10834         * target.h (target_ops) <pass_signals, program_signals>: Replace
10835         pointer and length parameters with gdb::array_view.
10836         (target_pass_signals, target_program_signals): Likewise.
10837         * target-delegates.c: Regenerate.
10838
10839 2019-01-24  Pedro Alves  <palves@redhat.com>
10840
10841         * common/forward-scope-exit.h
10842         (forward_scope_exit::forward_scope_exit): Pass arguments to
10843         m_bind_function directly, instead of creating a std::bind and
10844         copying that.
10845
10846 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10847
10848         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10849         for static members.
10850         (pass_in_v_vfp_candidate): Likewise.
10851
10852 2019-01-23  Tom Tromey  <tom@tromey.com>
10853             Pedro Alves  <palves@redhat.com>
10854
10855         * regcache.c (class regcache_invalidator): Remove.
10856         (regcache::raw_write): Use make_scope_exit.
10857
10858 2019-01-23  Tom Tromey  <tom@tromey.com>
10859
10860         * ui-out.h (class ui_out_emit_type): Update comment.
10861
10862 2019-01-23  Tom Tromey  <tom@tromey.com>
10863
10864         * infrun.c (fetch_inferior_event): Update comment.
10865
10866 2019-01-23  Tom Tromey  <tom@tromey.com>
10867             Pedro Alves  <palves@redhat.com>
10868
10869         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10870         parameter.
10871         (fetch_inferior_event): Use SCOPE_EXIT.
10872
10873
10874 2019-01-23  Tom Tromey  <tom@tromey.com>
10875             Pedro Alves  <palves@redhat.com>
10876
10877         * infrun.c (disable_thread_events): Delete.
10878         (stop_all_threads): Use SCOPE_EXIT.
10879
10880 2019-01-23  Tom Tromey  <tom@tromey.com>
10881             Pedro Alves  <palves@redhat.com>
10882
10883         * symfile.c: Include forward-scope-exit.h.
10884         (clear_symtab_users_cleanup): Replace forward declaration with
10885         a FORWARD_SCOPE_EXIT.
10886         (syms_from_objfile_1): Use the forward_scope_exit and
10887         gdb::optional instead of cleanup_function.
10888         (reread_symbols): Use the forward_scope_exit instead of
10889         cleanup_function.
10890         (clear_symtab_users_cleanup): Remove function.
10891
10892 2019-01-23  Tom Tromey  <tom@tromey.com>
10893             Pedro Alves  <palves@redhat.com>
10894
10895         * linux-nat.c: Include scope-exit.h.
10896         (cleanup_target_stop): Remove.
10897         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10898         SCOPE_EXIT.
10899
10900 2019-01-23  Tom Tromey  <tom@tromey.com>
10901             Pedro Alves  <palves@redhat.com>
10902
10903         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10904         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10905
10906 2019-01-23  Tom Tromey  <tom@tromey.com>
10907             Andrew Burgess  <andrew.burgess@embecosm.com>
10908             Pedro Alves  <palves@redhat.com>
10909
10910         * infrun.c (fetch_inferior_event): Use scope_exit.
10911         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10912         * top.c (execute_command): Use scope_exit.
10913         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10914         * utils.c (do_bpstat_clear_actions_cleanup)
10915         (make_bpstat_clear_actions_cleanup): Remove.
10916
10917 2019-01-23  Tom Tromey  <tom@tromey.com>
10918             Pedro Alves  <palves@redhat.com>
10919
10920         * infrun.c: Include "common/scope-exit.h"
10921         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10922         (wait_for_inferior): Use SCOPE_EXIT.
10923         (fetch_inferior_event): Use scope_exit.
10924
10925 2019-01-23  Tom Tromey  <tom@tromey.com>
10926             Pedro Alves  <palves@redhat.com>
10927
10928         * breakpoint.c (create_breakpoint): Remove cleanup.
10929
10930 2019-01-23  Tom Tromey  <tom@tromey.com>
10931             Andrew Burgess  <andrew.burgess@embecosm.com>
10932             Pedro Alves  <palves@redhat.com>
10933
10934 2019-01-23  Pedro Alves  <palves@redhat.com>
10935
10936         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10937
10938 2019-01-23  Pedro Alves  <palves@redhat.com>
10939             Andrew Burgess  <andrew.burgess@embecosm.com>
10940
10941         * gdbthread.h: Include "common/forward-scope-exit.h".
10942         (scoped_finish_thread_state): Redefine custom class in terms of
10943         forward_scope_exit.
10944
10945 2019-01-23  Pedro Alves  <palves@redhat.com>
10946             Andrew Burgess  <andrew.burgess@embecosm.com>
10947
10948         * common/forward-scope-exit.h: New file.
10949
10950 2019-01-23  Pedro Alves  <palves@redhat.com>
10951             Andrew Burgess  <andrew.burgess@embecosm.com>
10952             Tom Tromey  <tom@tromey.com>
10953
10954         * common/scope-exit.h: New file.
10955
10956 2019-01-23  Pedro Alves  <palves@redhat.com>
10957
10958         * common/preprocessor.h (ESC): Rename to ...
10959         (ESC_PARENS): ... this.
10960         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10961         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10962
10963 2019-01-23  Tom Tromey  <tom@tromey.com>
10964
10965         * language.h (class scoped_switch_to_sym_language_if_auto):
10966         Initialize m_lang in both cases.
10967
10968 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10969
10970         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10971         with XCNEW.
10972
10973 2019-01-22  Tom Tromey  <tom@tromey.com>
10974
10975         * corelow.c: Do not include sys/file.h.
10976
10977 2019-01-22  Tom Tromey  <tom@tromey.com>
10978
10979         * tui/tui-wingeneral.h: Include gdb_curses.h.
10980
10981 2019-01-22  Tom Tromey  <tom@tromey.com>
10982
10983         * source-cache.h (class source_cache) <get_source_lines,
10984         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10985
10986 2019-01-22  Tom Tromey  <tom@tromey.com>
10987
10988         * remote-fileio.h (struct remote_target): Declare.
10989
10990 2019-01-22  Tom Tromey  <tom@tromey.com>
10991
10992         * python/py-arch.c: Do not include py-ref.h.
10993         * python/py-bpevent.c: Do not include py-ref.h.
10994         * python/py-cmd.c: Do not include py-ref.h.
10995         * python/py-continueevent.c: Do not include py-ref.h.
10996         * python/py-event.h: Do not include py-ref.h.
10997         * python/py-evtregistry.c: Do not include py-ref.h.
10998         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10999         * python/py-frame.c: Do not include py-ref.h.
11000         * python/py-framefilter.c: Do not include py-ref.h.
11001         * python/py-function.c: Do not include py-ref.h.
11002         * python/py-infevents.c: Do not include py-ref.h.
11003         * python/py-linetable.c: Do not include py-ref.h.
11004         * python/py-objfile.c: Do not include py-ref.h.
11005         * python/py-param.c: Do not include py-ref.h.
11006         * python/py-prettyprint.c: Do not include py-ref.h.
11007         * python/py-progspace.c: Do not include py-ref.h.
11008         * python/py-symbol.c: Do not include py-ref.h.
11009         * python/py-symtab.c: Do not include py-ref.h.
11010         * python/py-type.c: Do not include py-ref.h.
11011         * python/py-unwind.c: Do not include py-ref.h.
11012         * python/py-utils.c: Do not include py-ref.h.
11013         * python/py-value.c: Do not include py-ref.h.
11014         * python/py-varobj.c: Do not include py-ref.h.
11015         * python/py-xmethods.c: Do not include py-ref.h.
11016         * python/python.c: Do not include py-ref.h.
11017         * varobj.c: Do not include py-ref.h.
11018
11019 2019-01-22  Tom Tromey  <tom@tromey.com>
11020
11021         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11022         keyword for bcache.
11023
11024 2019-01-22  Tom Tromey  <tom@tromey.com>
11025
11026         * compile/compile-cplus-types.c: Remove a comment by #include.
11027
11028 2019-01-22  Tom Tromey  <tom@tromey.com>
11029
11030         * compile/gcc-c-plugin.h: Include compile-internal.h.
11031
11032 2019-01-22  Tom Tromey  <tom@tromey.com>
11033
11034         * stabsread.c (EXTERN): Do not define.
11035         (symnum, next_symbol_text_func, processing_gcc_compilation)
11036         (within_function, global_sym_chain, global_stabs)
11037         (previous_stab_code, this_object_header_files)
11038         (n_this_object_header_files)
11039         (n_allocated_this_object_header_files): Define.
11040         * stabsread.h (EXTERN): Never define.  Use "extern".
11041
11042 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11043
11044         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11045         history_value.
11046
11047 2019-01-21  Tom Tromey  <tom@tromey.com>
11048
11049         * ui-out.c: Fix includes.
11050         * tui/tui-source.c: Fix includes.
11051         * target.c: Fix includes.
11052         * remote.c: Fix includes.
11053         * regcache.c: Fix includes.
11054         * python/py-block.c: Fix includes.
11055         * printcmd.c: Fix includes.
11056         * or1k-tdep.c: Fix includes.
11057         * mi/mi-main.c: Fix includes.
11058         * m32r-tdep.c: Fix includes.
11059         * csky-tdep.c: Fix includes.
11060         * compile/compile-cplus-types.c: Fix includes.
11061         * cli/cli-interp.c: Fix includes.
11062
11063 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11064
11065         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11066         for padding.
11067
11068 2019-01-16  Tom Tromey  <tom@tromey.com>
11069
11070         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11071         earlier.
11072         (struct objfile) <msymbols_range>: Move from top level.
11073         <msymbols>: New method.
11074         (class objfile_msymbols): Remove.
11075         * symtab.c (default_collect_symbol_completion_matches_break_on):
11076         Update.
11077         * symmisc.c (dump_msymbols): Update.
11078         * stabsread.c (scan_file_globals): Update.
11079         * objc-lang.c (info_selectors_command, info_classes_command)
11080         (find_methods): Update.
11081         * minsyms.c (find_solib_trampoline_target): Update.
11082         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11083         * coffread.c (coff_symfile_read): Update.
11084         * ada-lang.c (ada_lookup_simple_minsym)
11085         (ada_collect_symbol_completion_matches): Update.
11086
11087 2019-01-16  Tom Tromey  <tom@tromey.com>
11088
11089         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11090         type.  Remove no-argument constructor.
11091         <iterator::operator++>: Simplify.
11092         <begin>: Update.
11093         <end>: Use minimal_symbol_count.
11094
11095 2019-01-16  Tom Tromey  <tom@tromey.com>
11096
11097         * objfiles.h (struct objfile) <psymtabs>: New method.
11098         (class objfile_psymtabs): Remove.
11099         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11100         typedef.
11101         <range>: New method.
11102         (require_partial_symbols): Change return type.
11103         * psymtab.c (require_partial_symbols)
11104         (psym_expand_symtabs_matching): Update.
11105         * mdebugread.c (parse_partial_symbols): Update.
11106         * dbxread.c (dbx_end_psymtab): Update.
11107
11108 2019-01-15  Tom Tromey  <tom@tromey.com>
11109
11110         * symtab.c (lookup_objfile_from_block)
11111         (lookup_symbol_in_objfile_symtabs)
11112         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11113         (find_line_symtab, info_sources_command)
11114         (default_collect_symbol_completion_matches_break_on)
11115         (make_source_files_completion_list): Update.
11116         * symmisc.c (print_objfile_statistics, dump_objfile)
11117         (maintenance_print_symbols, maintenance_info_symtabs)
11118         (maintenance_check_symtabs, maintenance_info_line_tables):
11119         Update.
11120         * source.c (select_source_symtab)
11121         (forget_cached_source_info_for_objfile): Update.
11122         * objfiles.h (class objfile_compunits): Remove.
11123         (struct objfile) <compunits_range>: New typedef.
11124         (compunits): New method.
11125         * objfiles.c (objfile_relocate1): Update.
11126         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11127         * maint.c (count_symtabs_and_blocks): Update.
11128         * linespec.c (iterate_over_all_matching_symtabs): Update.
11129         * cp-support.c (add_symbol_overload_list_qualified): Update.
11130         * coffread.c (coff_symtab_read): Update.
11131         * ada-lang.c (add_nonlocal_symbols)
11132         (ada_collect_symbol_completion_matches)
11133         (ada_add_global_exceptions): Update.
11134
11135 2019-01-15  Tom Tromey  <tom@tromey.com>
11136
11137         * progspace.h (program_space) <objfiles_safe_range>: New
11138         typedef.
11139         <objfiles_safe>: New method.
11140         * objfiles.h (class all_objfiles_safe): Remove.
11141         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11142         * jit.c (jit_inferior_exit_hook): Update.
11143
11144 2019-01-17  Tom Tromey  <tom@tromey.com>
11145
11146         * progspace.h (program_space) <objfiles_range>: New typedef.
11147         <objfiles>: New method.
11148         <objfiles_head>: Rename from objfiles.
11149         (object_files): Update.
11150         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11151         * guile/scm-pretty-print.c
11152         (ppscm_find_pretty_printer_from_objfiles): Update.
11153         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11154         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11155         Update.
11156         * python/py-progspace.c (pspy_get_objfiles): Update.
11157         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11158         Update.
11159         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11160         (objfpy_lookup_objfile_by_build_id): Update.
11161         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11162         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11163         Update.
11164         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11165         (expand_symtab_containing_pc, lookup_objfile_from_block)
11166         (lookup_static_symbol, basic_lookup_transparent_type)
11167         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11168         (find_line_symtab, info_sources_command)
11169         (default_collect_symbol_completion_matches_break_on)
11170         (make_source_files_completion_list, find_main_name): Update.
11171         * symmisc.c (print_symbol_bcache_statistics)
11172         (print_objfile_statistics, maintenance_print_symbols)
11173         (maintenance_print_msymbols, maintenance_print_objfiles)
11174         (maintenance_info_symtabs, maintenance_check_symtabs)
11175         (maintenance_expand_symtabs, maintenance_info_line_tables):
11176         Update.
11177         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11178         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11179         (map_overlay_command, unmap_overlay_command)
11180         (simple_overlay_update, expand_symtabs_matching)
11181         (map_symbol_filenames): Update.
11182         * symfile-debug.c (set_debug_symfile): Update.
11183         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11184         Update.
11185         * source.c (select_source_symtab, forget_cached_source_info):
11186         Update.
11187         * solib.c (solib_read_symbols): Update.
11188         * solib-spu.c (append_ocl_sos): Update.
11189         * psymtab.c (maintenance_print_psymbols)
11190         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11191         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11192         * printcmd.c (info_symbol_command): Update.
11193         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11194         Update.
11195         * objfiles.h (class all_objfiles): Remove.
11196         * objfiles.c (have_partial_symbols, have_full_symbols)
11197         (have_minimal_symbols, qsort_cmp, update_section_map)
11198         (shared_objfile_contains_address_p)
11199         (default_iterate_over_objfiles_in_search_order): Update.
11200         * objc-lang.c (info_selectors_command, info_classes_command)
11201         (find_methods): Update.
11202         * minsyms.c (find_solib_trampoline_target): Update.
11203         * maint.c (maintenance_info_sections)
11204         (maintenance_translate_address, count_symtabs_and_blocks):
11205         Update.
11206         * main.c (captured_main_1): Update.
11207         * linux-thread-db.c (try_thread_db_load_from_pdir)
11208         (has_libpthread): Update.
11209         * linespec.c (iterate_over_all_matching_symtabs)
11210         (search_minsyms_for_name): Update.
11211         * jit.c (jit_find_objf_with_entry_addr): Update.
11212         * hppa-tdep.c (find_unwind_entry)
11213         (hppa_lookup_stub_minimal_symbol): Update.
11214         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11215         Update.
11216         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11217         (elf_gnu_ifunc_resolve_by_got): Update.
11218         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11219         * dwarf-index-write.c (save_gdb_index_command): Update.
11220         * cp-support.c (add_symbol_overload_list_qualified): Update.
11221         * breakpoint.c (create_overlay_event_breakpoint)
11222         (create_longjmp_master_breakpoint)
11223         (create_std_terminate_master_breakpoint)
11224         (create_exception_master_breakpoint): Update.
11225         * blockframe.c (find_pc_partial_function): Update.
11226         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11227         (ada_collect_symbol_completion_matches)
11228         (ada_add_global_exceptions): Update.
11229
11230 2019-01-17  Tom Tromey  <tom@tromey.com>
11231
11232         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11233         declare VEC.
11234         (solib_target_parse_libraries): Change return type.
11235         (library_list_start_segment, library_list_start_section)
11236         (library_list_end_library, library_list_start_library); Update.
11237         (solib_target_free_library_list): Remove.
11238         (solib_target_parse_libraries): Remove cleanup.  Change return
11239         type.
11240         (solib_target_current_sos): Update.
11241
11242 2019-01-17  Tom Tromey  <tromey@bapiya>
11243
11244         * valprint.c: Replace "the the" with "the".
11245         * symtab.c: Replace "the the" with "the".
11246         * solib.c: Replace "the the" with "the".
11247         * solib-dsbt.c: Replace "the the" with "the".
11248         * linespec.c: Replace "the the" with "the".
11249         * dwarf2loc.h: Replace "the the" with "the".
11250         * amd64-windows-tdep.c: Replace "the the" with "the".
11251         * aarch64-tdep.c: Replace "the the" with "the".
11252
11253 2019-01-16  Keith Seitz  <keiths@redhat.com>
11254
11255         PR gdb/23773
11256         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11257         <builder>: Rename to ..
11258         <m_builder>: ... this and make private.
11259         (dwarf2_cu::get_builder): New method.  Change all users of
11260         `builder' to use this method.
11261         (dwarf2_start_symtab): Move to ...
11262         (dwarf2_cu::start_symtab): ... here.  Update all callers
11263         (setup_type_unit_groups): Move to ...
11264         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11265         callers.
11266         (dwarf2_cu::reset_builder): New method.
11267         (process_full_compunit, process_full_type_unit): Use
11268         dwarf2_cu::reset_builder.
11269         (follow_die_offset): Record the ancestor CU if it is different
11270         from the followed DIE's CU.
11271         (follow_die_sig_1): Likewise.
11272
11273 2019-01-15  Tom Tromey  <tom@tromey.com>
11274
11275         * remote.c (class remote_state) <buf>: Now a char_vector.
11276         <buf_size>: Remove.
11277         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11278         parameter.
11279         (remote_target::getpkt_or_notif_sane_1)
11280         (remote_target::getpkt_sane)
11281         (remote_target::getpkt_or_notif_sane): Likewise.
11282         (class remote_target) <putpkt>: New overload.
11283         (remote_target::read_frame): Change type of "buf_p".  Remove
11284         sizeof_p parameter.
11285         (packet_ok): New overload.
11286         (packet_check_result): New overload.
11287         Update all uses.
11288
11289 2019-01-14  Tom Tromey  <tom@tromey.com>
11290
11291         * remote-notif.c (handle_notification, remote_notif_ack)
11292         (remote_notif_parse): Make "buf" const.
11293         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11294         const.
11295         (remote_notif_parse, remote_notif_ack, handle_notification):
11296         Likewise.
11297         * remote.c (remote_notif_stop_parse): Make "buf" const.
11298         (remote_target::remote_parse_stop_reply): Make "buf" const.
11299         (remote_notif_stop_ack): Make "buf" const.
11300
11301 2019-01-14  Tom Tromey  <tom@tromey.com>
11302
11303         * remote.c (remote_console_output): Make parameter const.
11304
11305 2019-01-14  Tom Tromey  <tom@tromey.com>
11306
11307         * target-debug.h (target_debug_print_signals): Constify.
11308         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11309         * procfs.c (procfs_target::pass_signals): Update.
11310         * linux-nat.c (linux_nat_target::pass_signals): Update.
11311         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11312         * target-delegates.c: Rebuild.
11313         * remote.c (remote_target::program_signals): Update.
11314         (remote_target::pass_signals): Update.
11315         * target.c (target_pass_signals): Constify argument.
11316         (target_program_signals): Likewise.
11317         * target.h (struct target_ops) <pass_signals, program_signals>:
11318         Constify argument.
11319         (target_pass_signals, target_program_signals): Constify argument.
11320
11321 2019-01-14  Tom Tromey  <tom@tromey.com>
11322
11323         PR tui/28819:
11324         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11325
11326 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11327
11328         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11329         field.
11330         * rs6000-tdep.c: Include reggroups.h.
11331         (IS_V_ALIAS_PSEUDOREG): Define.
11332         (rs6000_register_name): Return names for the "vX" aliases.
11333         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11334         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11335         aliases.  Call default_register_reggroup_p for all other
11336         pseudo-registers.
11337         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11338         New functions.
11339         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11340         Handle "vX" aliases.
11341         (v_alias_pseudo_register_collect): New function.
11342         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11343         (rs6000_gdbarch_init): Initialize "vX" aliases as
11344         pseudo-registers.  Restore registration of
11345         rs6000_pseudo_register_reggroup_p with
11346         set_tdesc_pseudo_register_reggroup_p.
11347
11348 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11349
11350         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11351         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11352         set_gdbarch_num_pseudo_regs.
11353
11354 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11355
11356         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11357         Remove arg prefixname, add do_set and do_show.
11358         Add member functions set_list and show_list.
11359         * cli/cli-style.c (class cli_style_option): Update accordingly.
11360         (style_set_list): Move to file scope.
11361         (style_show_list): Likewise.
11362         (set_style): Call help_list.
11363         (show_style): Call cmd_show_list.
11364         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11365         Update to use the new macro.
11366
11367 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11368
11369         * ada-lang.c (_initialize_ada_language): Expand the help text
11370         for the "catch exception" command.
11371
11372 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11373
11374         * symtab.c (matching_obj_sections): Initialize obj,
11375         declare it closer to its usage.
11376
11377 2019-01-10  Tom Tromey  <tom@tromey.com>
11378
11379         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11380         (basic_inf_threads_range): Remove.
11381         (inf_threads_range, inf_non_exited_threads_range)
11382         (safe_inf_threads_range): Use next_adapter.
11383
11384 2019-01-10  Keith Seitz  <keiths@redhat.com>
11385
11386         PR gdb/23712
11387         PR symtab/23010
11388         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11389         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11390
11391 2019-01-10  Keith Seitz  <keiths@redhat.com>
11392
11393         PR gdb/23712
11394         PR symtab/23010
11395         * dictionary.c (pending_to_vector): Remove.
11396         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11397         Remove _1 suffix, replacing functions of the same name.  Update
11398         all callers.
11399         (dict_create_hashed, dict_create_hashed_expandable)
11400         (dict_create_linear, dict_create_linear_expandable, dict_free)
11401         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11402         Make functions static.
11403
11404 2019-01-10  Keith Seitz  <keiths@redhat.com>
11405
11406         PR gdb/23712
11407         PR symtab/23010
11408         * dictionary.h (struct dictionary): Replace declaration with
11409         multidictionary.
11410         (dict_create_hashed, dict_create_hashed_expandable)
11411         (dict_create_linear, dict_create_linear_expandable)
11412         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11413         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11414         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11415         taking multidictionary argument.
11416         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11417         * block.h (struct block) <dict>: Change to multidictionary
11418         and rename `multidict'.
11419         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11420         symmisc.c: Update all dictionary references to multidictionary.
11421
11422 2019-01-10  Keith Seitz  <keiths@redhat.com>
11423
11424         PR gdb/23712
11425         PR symtab/23010
11426         * dictionary.c: Include unordered_map.
11427         (pending_to_vector): New function.
11428         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11429         Rewrite the non-"_1" functions to take vector instead
11430         of linked list.
11431         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11432         "new" _1 versions of the same name.
11433         (multidictionary): Define.
11434         (std::hash<enum language): New definition.
11435         (collate_pending_symbols_by_language, mdict_create_hashed)
11436         (mdict_create_hashed_expandable, mdict_create_linear)
11437         (mdict_create_linear_expandable, mdict_free)
11438         (find_language_dictionary, create_new_language_dictionary)
11439         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11440         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11441         (mdict_size, mdict_empty): New functions.
11442         * dictionary.h (mdict_iterator): Define.
11443
11444 2019-01-10  Pedro Alves  <palves@redhat.com>
11445
11446         * breakpoint.c (read_uploaded_action)
11447         (create_tracepoint_from_upload): Adjust to use
11448         gdb::unique_xmalloc_ptr.
11449         * ctf.c (ctf_write_uploaded_tp):
11450         (SET_ARRAY_FIELD): Use emplace_back.
11451         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11452         * tracefile-tfile.c (tfile_write_uploaded_tp):
11453         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11454         gdb::unique_xmalloc_ptr.
11455         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11456         at_string, cond_string, cmd_strings>: Replace char pointers
11457         with gdb::unique_xmalloc_ptr.
11458
11459 2019-01-10  Pedro Alves  <palves@redhat.com>
11460
11461         * solib-target.c (library_list_start_library): Don't xstrdup name.
11462
11463 2019-01-10  Pedro Alves  <palves@redhat.com>
11464
11465         * mdebugread.c (parse_partial_symbols): Use
11466         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11467
11468 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11469
11470         * linux-fork.c (scoped_switch_fork_info)
11471         <~scoped_switch_fork_info>: Fix incorrect variable name.
11472
11473 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11474
11475         * linux-fork.c (scoped_switch_fork_info)
11476         <scoped_switch_fork_info>: Make explicit.
11477         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11478
11479 2019-01-10  Tom Tromey  <tom@tromey.com>
11480
11481         * objfiles.h (objfile::reset_psymtabs): Update.
11482         * objfiles.c (objfile::objfile): Update.
11483         * psymtab.h (psymtab_storage::obstack): Update.
11484         (psymtab_storage::m_obstack): Use gdb::optional.
11485         (class psymtab_storage): Update comment.  Remove objfile
11486         parameter.
11487         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11488
11489 2019-01-10  Tom Tromey  <tom@tromey.com>
11490
11491         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11492         <free_psymtabs>: Now private.
11493         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11494         (allocate_psymtab): Use new method.
11495
11496 2019-01-10  Tom Tromey  <tom@tromey.com>
11497
11498         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11499         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11500         * mdebugread.c (parse_partial_symbols): Use
11501         allocate_dependencies.
11502         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11503         allocate_dependencies.
11504         (process_psymtab_comp_unit_reader)
11505         (build_type_psymtab_dependencies): Likewise.
11506         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11507
11508 2019-01-10  Tom Tromey  <tom@tromey.com>
11509
11510         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11511         PSYMBOL_SET_LANGUAGE.
11512         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11513
11514 2019-01-10  Tom Tromey  <tom@tromey.com>
11515
11516         * psymtab.h (psymtab_storage::obstack): New method.
11517         <m_obstack>: Rename from obstack; now private.
11518         * psymtab.c (psymtab_storage): Update.
11519         * dwarf2read.c (create_addrmap_from_index)
11520         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11521         Update.
11522
11523 2019-01-10  Tom Tromey  <tom@tromey.com>
11524
11525         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11526         * objfiles.h (objfile::reset_psymtabs): New method.
11527
11528 2019-01-10  Tom Tromey  <tom@tromey.com>
11529
11530         * symmisc.c (print_symbol_bcache_statistics): Update.
11531         (print_objfile_statistics): Update.
11532         * symfile.c (reread_symbols): Update.
11533         * psymtab.h (class psymtab_storage): New.
11534         * psymtab.c (psymtab_storage): New constructor.
11535         (~psymtab_storage): New destructor.
11536         (require_partial_symbols): Update.
11537         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11538         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11539         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11540         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11541         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11542         (start_psymtab_common, end_psymtab_common)
11543         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11544         (allocate_psymtab): Update.
11545         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11546         Update.
11547         (dump_psymtab_addrmap, maintenance_print_psymbols)
11548         (maintenance_check_psymtabs): Update.
11549         (class objfile_psymtabs): Move to objfiles.h.
11550         * psympriv.h (discard_psymtab): Now inline.
11551         (psymtab_discarder::psymtab_discarder): Update.
11552         (psymtab_discarder::~psymtab_discarder): Update.
11553         (ALL_OBJFILE_PSYMTABS): Rewrite.
11554         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11555         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11556         Remove fields.
11557         <partial_symtabs>: New field.
11558         (class objfile_psymtabs): Move from psymtab.h.  Update.
11559         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11560         psymbol_cache.
11561         (objfile::~objfile): Don't destroy psymbol_cache.
11562         * mdebugread.c (parse_partial_symbols): Update.
11563         * dwarf2read.c (create_addrmap_from_index)
11564         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11565         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11566         (add_partial_subprogram, dwarf2_ranges_read): Update.
11567         * dwarf-index-write.c (write_address_map)
11568         (write_one_signatured_type, recursively_write_psymbols)
11569         (class debug_names, class debug_names, write_psymtabs_to_index):
11570         Update.
11571
11572 2019-01-10  Tom Tromey  <tom@tromey.com>
11573
11574         * symtab.h (SYMBOL_SET_NAMES): Update.
11575         (symbol_set_names): Update.
11576         (MSYMBOL_SET_NAMES): Update.
11577         * symtab.c (symbol_set_names): Change argument to be an
11578         objfile_per_bfd_storage.
11579         * psymtab.c (add_psymbol_to_bcache): Update.
11580         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11581
11582 2019-01-10  Tom Tromey  <tom@tromey.com>
11583
11584         * symtab.c (create_demangled_names_hash): Change argument to be an
11585         objfile_per_bfd_storage.
11586         (symbol_set_names): Update.
11587
11588 2019-01-10  Tom Tromey  <tom@tromey.com>
11589
11590         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11591         init_psymbol_list.
11592         * psymtab.c (init_psymbol_list): Do nothing if already called.
11593         * psympriv.h (init_psymbol_list): Add comment.
11594         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11595         init_psymbol_list.
11596         * dbxread.c (dbx_symfile_read): Unconditionally call
11597         init_psymbol_list.
11598
11599 2019-01-10  Tom Tromey  <tom@tromey.com>
11600
11601         * xcoffread.c (scan_xcoff_symtab): Update.
11602         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11603         "where".
11604         * mdebugread.c (parse_partial_symbols)
11605         (handle_psymbol_enumerators): Update.
11606         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11607         * dbxread.c (read_dbx_symtab): Update.
11608         * psympriv.h (psymbol_placement): New enum.
11609         (add_psymbol_to_list): Update.
11610
11611 2019-01-10  Tom Tromey  <tom@tromey.com>
11612
11613         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11614         static_psymbols parameters.
11615         (scan_xcoff_symtab): Update.
11616         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11617         static_psymbols parameters.
11618         * psympriv.h (start_psymtab_common): Update.
11619         * mdebugread.c (parse_partial_symbols): Update.
11620         * dwarf2read.c (create_partial_symtab): Update.
11621         * dbxread.c (read_dbx_symtab): Update.
11622         (start_psymtab): Remove global_psymbols and static_psymbols
11623         parameters.
11624
11625 2019-01-10  Tom Tromey  <tom@tromey.com>
11626
11627         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11628         * psymtab.c (allocate_psymtab): Add comment.
11629         * psympriv.h (allocate_psymtab): Add comment.
11630         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11631         initializations.
11632         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11633
11634 2019-01-10  Tom Tromey  <tom@tromey.com>
11635
11636         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11637         Don't declare.
11638         * mipsread.c: Include mdebugread.h.
11639         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11640         Declare.
11641         * elfread.c: Include mdebugread.h.
11642
11643 2019-01-09  Tom Tromey  <tom@tromey.com>
11644
11645         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11646         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11647         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11648         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11649         (psym_lookup_symbol, psym_find_last_source_symtab)
11650         (psym_forget_cached_source_info, psym_print_stats)
11651         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11652         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11653         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11654         (psym_find_compunit_symtab_by_address)
11655         (maintenance_print_psymbols, maintenance_info_psymtabs)
11656         (maintenance_check_psymtabs): Use ranged for.
11657         * psymtab.h (class objfile_psymtabs): New.
11658         (require_partial_symbols): Return objfile_psymtabs.
11659         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11660
11661 2019-01-09  Tom Tromey  <tom@tromey.com>
11662
11663         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11664         (find_pc_mapped_section, list_overlays_command)
11665         (map_overlay_command, unmap_overlay_command)
11666         (simple_overlay_update): Use all_objfiles.
11667         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11668         * printcmd.c (info_symbol_command): Use all_objfiles.
11669         * objfiles.h (ALL_OBJSECTIONS): Remove.
11670         * maint.c (maintenance_translate_address): Use all_objfiles.
11671         * gcore.c (gcore_create_callback): Use all_objfiles.
11672         (objfile_find_memory_regions): Likewise.
11673
11674 2019-01-09  Tom Tromey  <tom@tromey.com>
11675
11676         * symtab.c (find_line_symtab, info_sources_command)
11677         (make_source_files_completion_list): Use objfile_compunits.
11678         * source.c (select_source_symtab): Use objfile_compunits.
11679         * objfiles.h (struct objfile): Update comment.
11680         (ALL_OBJFILES): Remove.
11681         (ALL_FILETABS): Remove.
11682         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11683         objfile_compunits.
11684
11685 2019-01-09  Tom Tromey  <tom@tromey.com>
11686
11687         * symmisc.c (print_objfile_statistics, dump_objfile)
11688         (maintenance_print_symbols): Use compunit_filetabs.
11689         * source.c (forget_cached_source_info_for_objfile): Use
11690         compunit_filetabs.
11691         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11692         (ALL_FILETABS): Use compunit_filetabs.
11693         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11694         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11695
11696 2019-01-09  Tom Tromey  <tom@tromey.com>
11697
11698         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11699         (compunit_filetabs): New.
11700         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11701         compunit_filetabs.
11702         (info_sources_command, make_source_files_completion_list): Remove
11703         declaration.
11704         * symmisc.c (print_objfile_statistics, dump_objfile)
11705         (maintenance_print_symbols): Remove declaration.
11706         (maintenance_info_symtabs): Use compunit_filetabs.
11707         (maintenance_info_line_tables): Likewise.
11708         * source.c (select_source_symtab): Change local variable name.
11709         (forget_cached_source_info_for_objfile): Remove declaration.
11710         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11711         * objfiles.c (objfile_relocate1): Remove declaration.
11712         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11713         declaration.
11714         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11715         * coffread.c (coff_symtab_read): Remove declaration.
11716         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11717         compunit_filetabs.
11718
11719 2019-01-09  Tom Tromey  <tom@tromey.com>
11720
11721         * symtab.c (lookup_objfile_from_block)
11722         (find_pc_sect_compunit_symtab, search_symbols)
11723         (default_collect_symbol_completion_matches_break_on): Use
11724         objfile_compunits.
11725         * objfiles.h (ALL_COMPUNITS): Remove.
11726         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11727         * cp-support.c (add_symbol_overload_list_qualified): Use
11728         objfile_compunits.
11729         * ada-lang.c (ada_collect_symbol_completion_matches)
11730         (ada_add_global_exceptions): Use objfile_compunits.
11731
11732 2019-01-09  Tom Tromey  <tom@tromey.com>
11733
11734         * source.c (select_source_symtab)
11735         (forget_cached_source_info_for_objfile): Remove declaration.
11736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11737         declaration.
11738         * maint.c (count_symtabs_and_blocks): Remove declaration.
11739         * cp-support.c (add_symbol_overload_list_qualified): Remove
11740         declaration.
11741         * coffread.c (coff_symtab_read): Remove declaration.
11742         * symtab.c (lookup_symbol_in_objfile_symtabs)
11743         (basic_lookup_transparent_type_1): Use objfile_compunits.
11744         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11745         (info_sources_command, search_symbols)
11746         (default_collect_symbol_completion_matches_break_on)
11747         (make_source_files_completion_list): Remove declaration.
11748         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11749         (ada_collect_symbol_completion_matches)
11750         (ada_add_global_exceptions): Remove declaration.
11751         * linespec.c (iterate_over_all_matching_symtabs): Use
11752         objfile_compunits.
11753         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11754         (class objfile_compunits): New.
11755         (ALL_COMPUNITS): Use objfile_compunits.
11756         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11757         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11758         objfile_compunits.
11759         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11760
11761 2019-01-09  Tom Tromey  <tom@tromey.com>
11762
11763         * symtab.c (search_symbols)
11764         (default_collect_symbol_completion_matches_break_on): Use
11765         objfile_msymbols.
11766         * ada-lang.c (ada_lookup_simple_minsym)
11767         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11768         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11769         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11770         objfile_msymbols.
11771         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11772         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11773         * objc-lang.c (find_methods): Use objfile_msymbols.
11774         (info_selectors_command, info_classes_command): Likewise.
11775         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11776         * objfiles.h (class objfile_msymbols): New.
11777         (ALL_OBJFILE_MSYMBOLS): Remove.
11778         (ALL_MSYMBOLS): Remove.
11779
11780 2019-01-09  Tom Tromey  <tom@tromey.com>
11781
11782         * common/next-iterator.h (next_adapter): Add Iterator template
11783         parameter.
11784         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11785         (class all_objfiles_safe): New.
11786         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11787         * objfiles.c (put_objfile_before): Update comment.
11788         (add_separate_debug_objfile): Likewise.
11789         (free_all_objfiles): Use all_objfiles_safe.
11790         (objfile_purge_solibs): Likewise.
11791
11792 2019-01-09  Tom Tromey  <tom@tromey.com>
11793
11794         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11795         (expand_symtab_containing_pc, lookup_static_symbol)
11796         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11797         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11798         all_objfiles.
11799         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11800         * breakpoint.c (create_overlay_event_breakpoint)
11801         (create_longjmp_master_breakpoint)
11802         (create_std_terminate_master_breakpoint)
11803         (create_exception_master_breakpoint): Use all_objfiles.
11804         * linux-thread-db.c (try_thread_db_load_from_pdir)
11805         (has_libpthread): Use all_objfiles.
11806         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11807         * linespec.c (iterate_over_all_matching_symtabs)
11808         (search_minsyms_for_name): Use all_objfiles.
11809         * maint.c (maintenance_info_sections): Use all_objfiles.
11810         * main.c (captured_main_1): Use all_objfiles.
11811         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11812         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11813         * guile/scm-pretty-print.c
11814         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11815         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11816         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11817         (maintenance_print_msymbols): Use all_objfiles.
11818         * source.c (select_source_symtab): Use all_objfiles.
11819         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11820         * symfile.c (remove_symbol_file_command)
11821         (expand_symtabs_matching, map_symbol_filenames): Use
11822         all_objfiles.
11823         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11824         all_objfiles.
11825         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11826         * objc-lang.c (find_methods): Use all_objfiles.
11827         * objfiles.c (have_partial_symbols, have_full_symbols)
11828         (have_minimal_symbols, qsort_cmp)
11829         (default_iterate_over_objfiles_in_search_order): Use
11830         all_objfiles.
11831         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11832         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11833         (maintenance_check_psymtabs): Use all_objfiles.
11834         (ALL_PSYMTABS): Remove.
11835         * compile/compile-object-run.c (do_module_cleanup): Use
11836         all_objfiles.
11837         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11838         * cp-support.c (add_symbol_overload_list_qualified): Use
11839         all_objfiles.
11840         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11841         Use all_objfiles.
11842         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11843         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11844         all_objfiles.
11845         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11846         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11847         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11848         Uses all_objfiles.
11849         * solib.c (solib_read_symbols): Use all_objfiles
11850
11851 2019-01-09  Tom Tromey  <tom@tromey.com>
11852
11853         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11854         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11855         all_objfiles.
11856         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11857         * symmisc.c (print_symbol_bcache_statistics)
11858         (print_objfile_statistics, maintenance_print_objfiles)
11859         (maintenance_info_symtabs, maintenance_check_symtabs)
11860         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11861         all_objfiles.
11862         * source.c (forget_cached_source_info): Use all_objfiles.
11863         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11864         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11865         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11866         * objfiles.c (update_section_map): Use all_objfiles.
11867         (shared_objfile_contains_address_p): Likewise.
11868         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11869         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11870
11871 2019-01-09  Tom Tromey  <tom@tromey.com>
11872
11873         * common/next-iterator.h: New file.
11874         * objfiles.h (class all_objfiles): New.
11875         (struct objfile_iterator): New.
11876
11877 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11878
11879         * NEWS: Move the description of the changed "frame", "select-frame",
11880          and "info frame" commands to the Changed commands section.
11881
11882 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11883
11884         * gdbtypes.c (check_stub_method_group): Remove handling of old
11885         mangling schemes.
11886         * linespec.c (find_methods): Likewise.
11887         * stabsread.c (read_member_functions): Likewise.
11888         * valops.c (search_struct_method): Likewise.
11889         (value_struct_elt_for_reference): Likewise.
11890         * NEWS: Mention this change.
11891
11892 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11893
11894         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11895         print_source_lines.
11896         * source.c (print_source_lines_base): Update line number check.
11897         (print_source_lines): New function.
11898         (source_lines_range::source_lines_range): New function.
11899         * source.h (class source_lines_range): New class.
11900         (print_source_lines): New declaration.
11901
11902 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11903
11904         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11905
11906 2019-01-08  Tom Tromey  <tom@tromey.com>
11907             Simon Marchi  <simon.marchi@ericsson.com>
11908
11909         PR gdb/24060
11910         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11911         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11912         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11913         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11914         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11915         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11916
11917 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11918
11919         * source.c (select_source_symtab): Move header comment to
11920         declaration in source.h.
11921         (forget_cached_source_info_for_objfile): Likewise.
11922         (forget_cached_source_info): Likewise.
11923         (identify_source_line): Likewise.
11924         * source.h (identify_source_line): Move declaration from symtab.h
11925         and add comment from source.c
11926         (print_source_lines): Likewise.
11927         (forget_cached_source_info_for_objfile): Likewise.
11928         (forget_cached_source_info): Likewise.
11929         (select_source_symtab): Likewise.
11930         (enum print_source_lines_flag): Move definition from symtab.h.
11931         * symtab.h (identify_source_line): Move declaration to source.h.
11932         (print_source_lines): Likewise.
11933         (forget_cached_source_info_for_objfile): Likewise.
11934         (forget_cached_source_info): Likewise.
11935         (select_source_symtab): Likewise.
11936         (enum print_source_lines_flag): Move definition to source.h.
11937         * tui/tui-hooks.c: Add 'source.h' include.
11938
11939 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11940
11941         * source.c (print_source_lines_base): Handle requests to print
11942         reverse line number sequences, and guard against empty lines
11943         string.
11944
11945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11946
11947         * source.c (print_source_lines_base): Fix skip of '\r' if next
11948         character is '\n'.
11949
11950 2019-01-06  Tom Tromey  <tom@tromey.com>
11951
11952         * c-exp.y (struct c_parse_state) <macro_original_text,
11953         expansion_obstack>: New member.
11954         (macro_original_text, expansion_obstack): Remove globals.
11955         (scan_macro_expansion, scanning_macro_expansion)
11956         (finished_macro_expansion): Update.
11957         (scan_macro_cleanup): Remove.
11958         (yylex, c_parse): Update.
11959
11960 2019-01-06  Tom Tromey  <tom@tromey.com>
11961
11962         * c-exp.y (struct c_parse_state) <strings>: New member.
11963         (operator_stoken): Update.
11964
11965 2019-01-06  Tom Tromey  <tom@tromey.com>
11966
11967         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11968         (union type_stack_elt) <typelist_val>: Now a pointer to
11969         std::vector.
11970         (type_stack_cleanup): Don't declare.
11971         (push_typelist): Update.
11972         * parse.c (pop_typelist): Return a std::vector.
11973         (push_typelist): Take a std::vector.
11974         (follow_types): Update.  Do not free args.
11975         (type_stack_cleanup): Remove.
11976         * c-exp.y (struct c_parse_state): New.
11977         (cpstate): New global.
11978         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11979         (nonempty_typelist): Update.
11980         (func_mod): Create a new vector.
11981         (c_parse): Create a c_parse_state.
11982         (check_parameter_typelist): Do not delete params.
11983         (function_method): Update.  Do not delete type_list.
11984
11985 2019-01-06  Tom Tromey  <tom@tromey.com>
11986
11987         PR gdb/28155:
11988         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11989         check_typedef.
11990         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11991         (print_return_value): Likewise.
11992
11993 2019-01-05  Tom Tromey  <tom@tromey.com>
11994
11995         * contrib/cleanup_check.py: Remove.
11996         * contrib/gcc-with-excheck: Remove.
11997         * contrib/exsummary.py: Remove.
11998         * contrib/excheck.py: Remove.
11999
12000 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12001
12002         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12003         NULL. Initialize tpprev to NULL instead of assigning it
12004         to NULL on the next statement.
12005         * windows-nat.c (windows_delete_thread): Remove check for
12006         main_thread_id before printing thread exit notifications.
12007         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12008         Remove thread ID check against main_thread_id.
12009         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12010         windows_delete_thread.
12011         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12012
12013 2019-01-04  Tom Tromey  <tom@tromey.com>
12014
12015         * compile/compile.c (_initialize_compile): Use upper case for
12016         metasyntactic variables.
12017         * symmisc.c (_initialize_symmisc): Use upper case for
12018         metasyntactic variables.
12019         * psymtab.c (_initialize_psymtab): Use upper case for
12020         metasyntactic variables.
12021         * demangle.c (demangle_command): Use upper case for metasyntactic
12022         variables.
12023         (_initialize_demangler): Likewise.
12024         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12025         variables.
12026
12027 2019-01-03  Tom Tromey  <tom@tromey.com>
12028
12029         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12030
12031 2019-01-03  Tom Tromey  <tom@tromey.com>
12032
12033         * python/py-symtab.c (salpy_str): Update.
12034         (struct salpy_sal_object) <symtab>: Now a PyObject.
12035         (salpy_dealloc): Update.
12036         (del_objfile_sal): Use gdbpy_ref.
12037
12038 2019-01-03  Tom Tromey  <tom@tromey.com>
12039
12040         * python/py-type.c (convert_field): Use new_reference.  Return
12041         gdbpy_ref.
12042         (make_fielditem): Return gdbpy_ref.
12043         (typy_fields): Update.
12044         (typy_getitem): Update.
12045         (field_name): Return gdbpy_ref.  Use new_reference.
12046         (typy_iterator_iternext): Update.
12047
12048 2019-01-03  Tom Tromey  <tom@tromey.com>
12049
12050         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12051
12052 2019-01-03  Tom Tromey  <tom@tromey.com>
12053
12054         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12055         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12056         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12057         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12058         (pspy_set_type_printers): Likewise.
12059         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12060         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12061         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12062         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12063         (objfpy_set_type_printers): Likewise.
12064
12065 2019-01-03  Tom Tromey  <tom@tromey.com>
12066
12067         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12068         (gdbpy_print_stack): Use gdbpy_err_fetch.
12069         * python/python-internal.h (class gdbpy_err_fetch): New class.
12070         (class gdbpy_enter) <m_error_type, m_error_value,
12071         m_error_traceback>: Remove.
12072         <m_error>: New member.
12073         (gdbpy_exception_to_string): Don't declare.
12074         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12075         * python/py-value.c (convert_value_from_python): Use
12076         gdbpy_err_fetch.
12077         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12078         gdbpy_exception_to_string.
12079         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12080         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12081         gdbpy_err_fetch.
12082
12083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12084
12085         * linux-nat.c (delete_lwp_cleanup): Delete.
12086         (struct lwp_deleter): New struct.
12087         (lwp_info_up): New typedef.
12088         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12089         lwp_info_up.
12090
12091 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12092
12093         * linux-fork.c (class scoped_switch_fork_info): New class.
12094         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12095
12096 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12097
12098         * valops.c (find_overload_match): Remove use of null_cleanup, and
12099         calls to do_cleanups.
12100
12101 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12102
12103         * compile/compile-cplus-types.c
12104         (compile_cplus_instance::decl_name): Handle changes to
12105         cp_func_name.
12106         * cp-support.c (cp_func_name): Update header comment, update
12107         return type.
12108         * cp-support.h (cp_func_name): Update return type in declaration.
12109         * valops.c (find_overload_match): Move temp_func local to top
12110         level of function and change its type.  Use temp_func to hold and
12111         delete temporary string obtained from cp_func_name.
12112
12113 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12114
12115         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12116         gdb::char_vector, remove cleanup, and update uses of `msg`.
12117
12118 2019-01-03  Jim Wilson  <jimw@sifive.com>
12119
12120         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12121
12122 2019-01-02  Tom Tromey  <tom@tromey.com>
12123
12124         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12125         (tdesc_parse_xml): Remove cleanups.
12126         * target-descriptions.h (make_cleanup_free_target_description):
12127         Don't declare.
12128         (target_desc_deleter): New struct.
12129         (target_desc_up): New typedef.
12130         * target-descriptions.c (target_desc_deleter::operator()): Rename
12131         from free_target_description.
12132         (make_cleanup_free_target_description): Remove.
12133
12134 2019-01-02  Tom Tromey  <tom@tromey.com>
12135
12136         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12137         constructor, destructor.
12138         (linespec_parser): Remove typedef.
12139         (~linespec_parser): Rename from linespec_parser_delete.
12140         (linespec_lex_to_end, linespec_complete_label)
12141         (linespec_complete): Update.
12142         (decode_line_full): Remove cleanups.
12143         (decode_line_1): Update.
12144
12145 2019-01-02  Tom Tromey  <tom@tromey.com>
12146
12147         * python/python-internal.h (inferior_to_inferior_object): Change
12148         return type.
12149         * python/py-exitedevent.c (create_exited_event_object): Update.
12150         * python/py-inferior.c (inferior_to_inferior_object): Return
12151         gdbpy_ref.
12152         (python_new_inferior, python_inferior_deleted)
12153         (thread_to_thread_object, delete_thread_object)
12154         (build_inferior_list, gdbpy_selected_inferior): Update.
12155         * python/py-infthread.c (create_thread_object): Update.  Also fail
12156         if inferior_to_inferior_object fails.
12157
12158 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12159
12160         * inferior.h (class inferior) <displaced_step_state>: New field.
12161         * infrun.h (struct displaced_step_state): Move here from
12162         infrun.c.  Initialize fields, add constructor.
12163         <inf>: Remove field.
12164         <reset>: New method.
12165         * infrun.c (struct displaced_step_inferior_state): Move to
12166         infrun.h.
12167         (displaced_step_inferior_states): Remove.
12168         (get_displaced_stepping_state): Adust.
12169         (displaced_step_in_progress_any_inferior): Adjust.
12170         (displaced_step_in_progress_thread): Adjust.
12171         (displaced_step_in_progress): Adjust.
12172         (add_displaced_stepping_state): Remove.
12173         (get_displaced_step_closure_by_addr): Adjust.
12174         (remove_displaced_stepping_state): Remove.
12175         (infrun_inferior_exit): Call displaced_step_state.reset.
12176         (use_displaced_stepping): Don't check for NULL.
12177         (displaced_step_prepare_throw): Call
12178         get_displaced_stepping_state.
12179         (displaced_step_fixup): Don't check for NULL.
12180         (prepare_for_detach): Don't check for NULL.
12181
12182 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12183
12184         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12185          in case of call that did not complete.
12186
12187 2019-01-02  Andrey Utkin  <autkin@undo.io>
12188
12189         * symfile.c (find_separate_debug_file): Fix search of debug files for
12190         remote debuggee.
12191
12192 2019-01-02  Tom Tromey  <tom@tromey.com>
12193
12194         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12195         indentation.
12196         * python/py-frame.c (frapy_older): Remove cast.
12197         (frapy_newer): Likewise.
12198         * python/py-breakpoint.c (local_setattro): Remove cast.
12199         * python/py-arch.c (archpy_name): Remove local variable.
12200         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12201
12202 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12203
12204         * unittests/basic_string_view/element_access/char/empty.cc:
12205         Fix year range in copyright header.
12206
12207 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12208
12209         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12210         Delete.
12211         <operator==>: Update with for removed field.
12212         <hash>: Likewise.
12213         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12214         <isa_features>: ...this.
12215         <abi_features>: New field.
12216         (riscv_isa_flen): Update comment.
12217         (riscv_abi_xlen): New declaration.
12218         (riscv_abi_flen): New declaration.
12219         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12220         isa_features.
12221         (riscv_abi_xlen): New function.
12222         (riscv_isa_flen): Update to get answer from isa_features.
12223         (riscv_abi_flen): New function.
12224         (riscv_has_fp_abi): Update to get answer from abi_features.
12225         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12226         xlen and flen.
12227         (riscv_call_info) <xlen, flen>: Update comment.
12228         (riscv_call_arg_struct): Remove invalid assertions
12229         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12230         is removed.
12231         (riscv_gdbarch_init): Gather isa features and abi features
12232         separately, ensure both match on the gdbarch when reusing an old
12233         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12234         a target with 64-bit float hardware.
12235
12236 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12237
12238         * source.c (search_command_helper): Stop reverse search
12239         when line 1 has been searched.
12240
12241 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12242
12243         * record-full.c (record_full_base_target::close): Rewrite
12244         record_full_core_buf_list free logic.
12245
12246 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12247
12248         * break-catch-syscall.c (print_one_catch_syscall): xfree
12249         the last text.
12250
12251 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12252
12253         * top.c (print_gdb_version): Update Copyright year in version
12254         message.
12255
12256 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12257
12258         Update copyright year range in all GDB files.
12259
12260 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12261
12262         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12263
12264 For older changes see ChangeLog-2018.
12265 \f
12266 Local Variables:
12267 mode: change-log
12268 left-margin: 8
12269 fill-column: 74
12270 version-control: never
12271 coding: utf-8
12272 End:
12273