gdb/ChangeLog

   1 2020-03-13  Tom Tromey  <tom@tromey.com>
   2
   3         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
   4         * mips-tdep.c (mips_print_register): Use
   5         value_print_scalar_formatted.
   6
   7 2020-03-13  Tom Tromey  <tom@tromey.com>
   8
   9         * valprint.h (value_print_scalar_formatted): Declare.
  10         * valprint.c (value_print_scalar_formatted): New function.
  11
  12 2020-03-13  Tom Tromey  <tom@tromey.com>
  13
  14         * valprint.h (generic_value_print): Declare.
  15         * valprint.c (generic_value_print): New function.
  16
  17 2020-03-13  Tom Tromey  <tom@tromey.com>
  18
  19         * valprint.c (do_val_print): Call la_value_print_inner, if
  20         available.
  21         * rust-lang.c (rust_language_defn): Update.
  22         * p-lang.c (pascal_language_defn): Update.
  23         * opencl-lang.c (opencl_language_defn): Update.
  24         * objc-lang.c (objc_language_defn): Update.
  25         * m2-lang.c (m2_language_defn): Update.
  26         * language.h (struct language_defn) <la_value_print_inner>: New
  27         member.
  28         * language.c (unknown_language_defn, auto_language_defn): Update.
  29         * go-lang.c (go_language_defn): Update.
  30         * f-lang.c (f_language_defn): Update.
  31         * d-lang.c (d_language_defn): Update.
  32         * c-lang.c (c_language_defn, cplus_language_defn)
  33         (asm_language_defn, minimal_language_defn): Update.
  34         * ada-lang.c (ada_language_defn): Update.
  35
  36 2020-03-13  Tom Tromey  <tom@tromey.com>
  37
  38         * c-valprint.c (c_value_print): Use common_val_print.
  39
  40 2020-03-13  Tom Tromey  <tom@tromey.com>
  41
  42         * cp-valprint.c (cp_print_static_field): Use common_val_print.
  43
  44 2020-03-13  Tom Tromey  <tom@tromey.com>
  45
  46         * f-valprint.c (f77_print_array_1, f_val_print): Use
  47         common_val_print.
  48
  49 2020-03-13  Tom Tromey  <tom@tromey.com>
  50
  51         * riscv-tdep.c (riscv_print_one_register_info): Use
  52         common_val_print.
  53
  54 2020-03-13  Tom Tromey  <tom@tromey.com>
  55
  56         * mi/mi-main.c (output_register): Use common_val_print.
  57
  58 2020-03-13  Tom Tromey  <tom@tromey.com>
  59
  60         * infcmd.c (default_print_one_register_info): Use
  61         common_val_print.
  62
  63 2020-03-13  Tom Tromey  <tom@tromey.com>
  64
  65         * valprint.h (common_val_print_checked): Declare.
  66         * valprint.c (common_val_print_checked): New function.
  67         * stack.c (print_frame_arg): Use common_val_print_checked.
  68
  69 2020-03-13  Tom Tromey  <tom@tromey.com>
  70
  71         * valprint.c (do_val_print): New function, from val_print.
  72         (val_print): Use do_val_print.
  73         (common_val_print): Use do_val_print.
  74
  75 2020-03-13  Tom Tromey  <tom@tromey.com>
  76
  77         * valprint.c (value_print): Use scoped_value_mark.
  78
  79 2020-03-13  Tom de Vries  <tdevries@suse.de>
  80
  81         PR symtab/25646
  82         * psymtab.c (partial_symtab::partial_symtab): Don't set
  83         globals_offset and statics_offset.  Push element onto
  84         current_global_psymbols and current_static_psymbols stacks.
  85         (concat): New function.
  86         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
  87         element from current_global_psymbols and current_static_psymbols
  88         stacks.  Concat popped elements to global_psymbols and
  89         static_symbols.
  90         (add_psymbol_to_list): Use current_global_psymbols and
  91         current_static_psymbols stacks.
  92         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
  93         current_static_psymbols fields.
  94
  95 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
  96
  97         * corelow.c (sniff_core_bfd): Remove.
  98         (class core_target) <m_core_vec>: Remove.
  99         (core_target::core_target): Update.
 100         (core_file_fns): Remove.
 101         (deprecated_add_core_fns): Remove.
 102         (default_core_sniffer): Remove.
 103         (sniff_core_bfd): Remove.
 104         (default_check_format): Remove.
 105         (gdb_check_format): Remove.
 106         (core_target_open): Update.
 107         (core_target::get_core_register_section): Update.
 108         (get_core_registers_cb): Update.
 109         (core_target::fetch_registers): Update.
 110         * gdbcore.h (struct core_fns): Remove.
 111         (deprecated_add_core_fns): Remove.
 112         (default_core_sniffer): Remove.
 113         (default_check_format): Remove.
 114
 115 2020-03-12  Tom Tromey  <tom@tromey.com>
 116
 117         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
 118         CORE_ADDR.
 119         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
 120
 121 2020-03-12  Tom Tromey  <tom@tromey.com>
 122
 123         * remote.c (remote_target::download_tracepoint)
 124         (remote_target::enable_tracepoint)
 125         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
 126         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
 127         sprintf_vma.
 128
 129 2020-03-12  Tom Tromey  <tom@tromey.com>
 130
 131         * symfile-mem.c: Update CORE_ADDR size assert.
 132
 133 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 134
 135         * selftest.m4: Move to gdbsupport/.
 136         * acinclude.m4: Update path to selftest.m4.
 137
 138 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 139
 140         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
 141         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
 142         gdbarch-selfselftests.c and selftest-arch.c.
 143         (SUBDIR_UNITTESTS_OBS): Rename to...
 144         (SELFTESTS_OBS): ... this.
 145         (COMMON_SFILES): Remove disasm-selftests.c and
 146         gdbarch-selftests.c.
 147         * configure.ac: Don't add selftest-arch.{c,o} to
 148         CONFIG_{SRCS,OBS}.
 149         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
 150         preprocessor conditions.
 151
 152 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 153
 154         * configure.ac: Don't source bfd/development.sh.
 155         * selftest.m4: Modify comment.
 156         * configure: Re-generate.
 157
 158 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 159
 160         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
 161         not "true" or "false".
 162         * configure: Re-generate.
 163
 164 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
 165
 166         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
 167         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
 168         renamed to arm_nbsd_supply_gregset.
 169         (fetch_register): Update to call arm_nbsd_supply_gregset.
 170         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
 171         (arm_netbsd_nat_target::fetch_registers): Update.
 172         (fetch_elfcore_registers): Removed.
 173         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
 174         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
 175         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
 176         not require NetBSD system headers.
 177         (arm_nbsd_regset): New struct.
 178         (arm_nbsd_iterate_over_regset_sections): New function.
 179         (arm_netbsd_init_abi_common): Updated to call
 180         set_gdbarch_iterate_over_regset_sections.
 181         * arm-nbsd-tdep.h: New file.
 182
 183 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
 184
 185         * symtab.c (find_pc_sect_line): Add check which prevents infinite
 186         recursion.
 187
 188 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
 189
 190         * configure: Re-generate.
 191
 192 2020-03-11  Tom Tromey  <tromey@adacore.com>
 193
 194         * ada-typeprint.c (print_choices): Fix comment.
 195
 196 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 197
 198         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
 199         previous item in the list, when the list has no items.
 200
 201 2020-03-11  Tom de Vries  <tdevries@suse.de>
 202
 203         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
 204         PROP_LOCLIST handling code.
 205
 206 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * buildsym-legacy.c (record_line): Pass extra parameter to
 209         record_line.
 210         * buildsym.c (buildsym_compunit::record_line): Take an extra
 211         parameter, reduce duplication in the line table, and record the
 212         is_stmt flag in the line table.
 213         * buildsym.h (buildsym_compunit::record_line): Add extra
 214         parameter.
 215         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
 216         non-statement lines.
 217         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
 218         this to the symtab builder.
 219         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
 220         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
 221         through to dwarf_record_line_1.
 222         * infrun.c (process_event_stop_test): When stepping, don't stop at
 223         a non-statement instruction, and only refresh the step info when
 224         we land in the middle of a line's range.  Also add an extra
 225         comment.
 226         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
 227         field.
 228         * record-btrace.c (btrace_find_line_range): Only record lines
 229         marked as is-statement.
 230         * stack.c (frame_show_address): Show the frame address if we are
 231         in a non-statement sal.
 232         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
 233         (maintenance_print_one_line_table): Print a header for the is_stmt
 234         column, and include is_stmt information in the output.
 235         * symtab.c (find_pc_sect_line): Find lines marked as statements in
 236         preference to non-statements.
 237         (find_pcs_for_symtab_line): Prefer is-statement entries.
 238         (find_line_common): Likewise.
 239         * symtab.h (struct linetable_entry): Add is_stmt field.
 240         (struct symtab_and_line): Likewise.
 241         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
 242         arranging the line table.
 243
 244 2020-03-07  Tom de Vries  <tdevries@suse.de>
 245
 246         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
 247         DIE.
 248
 249 2020-03-07  Tom Tromey  <tom@tromey.com>
 250
 251         * valops.c (value_literal_complex): Remove obsolete comment.
 252         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
 253         comment.
 254
 255 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
 256
 257         * infrun.h: Forward-declare thread_info.
 258         (set_step_info): Add thread_info parameter, add doc.
 259         * infrun.c (set_step_info): Add thread_info parameter, move doc
 260         to header.
 261         * infrun.c (process_event_stop_test): Pass thread to
 262         set_step_info call.
 263         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
 264         set_step_info.
 265         (prepare_one_step): Add thread_info parameter, pass it to
 266         set_step_frame and prepare_one_step (recursive) call.
 267         (step_1): Pass thread to prepare_one_step call.
 268         (step_command_fsm::should_stop): Pass thread to
 269         prepare_one_step.
 270         (until_next_fsm): Pass thread to set_step_frame call.
 271         (finish_command): Pass thread to set_step_info call.
 272
 273 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
 274
 275         * windows-tdep.c (windows_solib_create_inferior_hook):
 276         Check if inferior is running.
 277
 278 2020-03-06  Tom de Vries  <tdevries@suse.de>
 279
 280         * NEWS: Fix "the the".
 281         * ctfread.c: Same.
 282
 283 2020-03-06  Tom de Vries  <tdevries@suse.de>
 284
 285         * psymtab.c (psymtab_to_symtab): Don't print "done.".
 286
 287 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 288
 289         * .dir-locals.el: Add a comment referencing the other copies of
 290         this file.
 291
 292 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
 293
 294         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
 295         psargs.
 296
 297 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 298
 299         * .gitattributes: New file.
 300
 301 2020-03-04  Tom Tromey  <tom@tromey.com>
 302
 303         * symmisc.c (print_symbol_bcache_statistics)
 304         (print_objfile_statistics): Update.
 305         * symfile.c (allocate_symtab): Use intern.
 306         * psymtab.c (partial_symtab::partial_symtab): Use intern.
 307         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 308         macro_cache>: Remove.
 309         <string_cache>: New member.
 310         (struct objfile) <intern>: New methods.
 311         * elfread.c (elf_symtab_read): Use intern.
 312         * dwarf2/read.c (fixup_go_packaging): Intern package name.
 313         (dwarf2_compute_name, dwarf2_physname)
 314         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
 315         names.
 316         (guess_partial_die_structure_name): Update.
 317         (partial_die_info::fixup): Intern name.
 318         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
 319         name.
 320         (dwarf2_name): Intern name.  Update.
 321         * buildsym.c (buildsym_compunit::get_macro_table): Use
 322         string_cache.
 323
 324 2020-03-04  Tom Tromey  <tom@tromey.com>
 325
 326         * jit.c (bfd_open_from_target_memory): Make "target" const.
 327         * corefile.c (gnutarget): Now const.
 328         * gdbcore.h (gnutarget): Now const.
 329
 330 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
 331
 332         * NEWS: Mention support for WOW64 processes.
 333         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
 334         (amd64_windows_segment_register_p): Remove static.
 335         (_initialize_amd64_windows_nat): Update.
 336         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
 337         * i386-windows-nat.c (context_offset): Update.
 338         (i386_mappings): Rename and remove static.
 339         (i386_windows_segment_register_p): Remove static.
 340         (_initialize_i386_windows_nat): Update.
 341         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
 342         (STATUS_WX86_SINGLE_STEP): New macro.
 343         (EnumProcessModulesEx): New macro.
 344         (Wow64SuspendThread): New macro.
 345         (Wow64GetThreadContext): New macro.
 346         (Wow64SetThreadContext): New macro.
 347         (Wow64GetThreadSelectorEntry): New macro.
 348         (windows_set_context_register_offsets): Add static.
 349         (windows_set_segment_register_p): Likewise.
 350         (windows_add_thread): Adapt for WOW64 processes.
 351         (windows_fetch_one_register): Likewise.
 352         (windows_nat_target::fetch_registers): Likewise.
 353         (windows_store_one_register): Likewise.
 354         (display_selector): Likewise.
 355         (display_selectors): Likewise.
 356         (handle_exception): Likewise.
 357         (windows_continue): Likewise.
 358         (windows_nat_target::resume): Likewise.
 359         (windows_add_all_dlls): Likewise.
 360         (do_initial_windows_stuff): Likewise.
 361         (windows_nat_target::attach): Likewise.
 362         (windows_get_exec_module_filename): Likewise.
 363         (windows_nat_target::create_inferior): Likewise.
 364         (windows_xfer_siginfo): Likewise.
 365         (_initialize_loadable): Initialize Wow64SuspendThread,
 366         Wow64GetThreadContext, Wow64SetThreadContext,
 367         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
 368         * windows-nat.h (windows_set_context_register_offsets):
 369         Remove declaration.
 370         (windows_set_segment_register_p): Likewise.
 371         (i386_windows_segment_register_p): Add declaration.
 372         (amd64_windows_segment_register_p): Likewise.
 373
 374 2020-03-04  Luis Machado  <luis.machado@linaro.org>
 375
 376         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
 377         in "info registers" for AArch64/ARM.
 378
 379         The change caused "info registers" to not print GPR's.
 380
 381         gdb/ChangeLog:
 382
 383         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 384
 385         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 386         when reg->group is empty and reggroup is not.
 387
 388 2020-03-03  Tom Tromey  <tromey@adacore.com>
 389
 390         * dwarf2/frame.c (struct dwarf2_frame_cache)
 391         <checked_tailcall_bottom, entry_cfa_sp_offset,
 392         entry_cfa_sp_offset_p>: Remove members.
 393         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
 394         (dwarf2_frame_prev_register): Don't call
 395         dwarf2_tailcall_sniffer_first.
 396         (dwarf2_append_unwinders): Don't append tailcall unwinder.
 397         * frame-unwind.c (add_unwinder): New fuction.
 398         (frame_unwind_init): Use it.  Add tailcall unwinder.
 399
 400 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 401             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 402
 403         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
 404         value should be printed as true.
 405
 406 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
 407
 408         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
 409         (windows_init_abi): Set and use windows_so_ops.
 410
 411 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 412
 413         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
 414         when verifying if dealing with a convenience variable.
 415
 416 2020-03-03  Luis Machado  <luis.machado@linaro.org>
 417
 418         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
 419
 420 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 421
 422         * infrun.c (gdbarch_supports_displaced_stepping): New.
 423         (use_displaced_stepping): Break up conditions in smaller pieces.
 424         Use gdbarch_supports_displaced_stepping.
 425         (displaced_step_prepare_throw): Use
 426         gdbarch_supports_displaced_stepping.
 427
 428 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * NEWS: Mention new behaviour of the history filename.
 431         * top.c (write_history_p): Add comment.
 432         (show_write_history_p): Add header comment, give a different
 433         message when history writing is on, but the history filename is
 434         empty.
 435         (history_filename): Add comment.
 436         (history_filename_empty): New function.
 437         (show_history_filename): Add header comment, give a different
 438         message when the filename is empty.
 439         (init_history): Compare history_filename against nullptr, and only
 440         read history if the filename is not empty.
 441         (set_history_filename): Add header comment, and only make
 442         non-empty filenames absolute.
 443         (init_main): Make the filename argument to 'set history filename'
 444         optional.
 445
 446 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
 447
 448         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
 449         (arm_supply_vfpregset): ...this, and update to use VFP registers.
 450         (fetch_fp_register): Update.
 451         (fetch_fp_regs): Update.
 452         (store_fp_register): Update.
 453         (store_fp_regs): Update.
 454         (arm_netbsd_nat_target::read_description): New function.
 455         (fetch_elfcore_registers): Update.
 456
 457 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
 460         general_thread if the stop reply is missing a thread-id.
 461         (remote_target::process_stop_reply): Use the first non-exited
 462         thread if the target didn't pass a thread-id.
 463         * infrun.c (do_target_wait): Move call to
 464         switch_to_inferior_no_thread to ....
 465         (do_target_wait_1): ... here.
 466
 467 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
 468
 469         * debuginfod-support.c: Include defs.h first.
 470
 471 2020-02-28  Tom de Vries  <tdevries@suse.de>
 472
 473         * symfile.c (set_initial_language): Use default language for lookup.
 474
 475 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
 476
 477         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
 478         reader variable, pass `this` to read_cutu_die_from_dwo.
 479
 480 2020-02-27  Aaron Merey  <amerey@redhat.com>
 481
 482         * source.c (open_source_file): Check for nullptr when computing
 483         srcpath.
 484
 485 2020-02-27  Tom Tromey  <tromey@adacore.com>
 486
 487         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
 488         member.
 489         (dwarf2_add_field): Don't update nfields.
 490         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
 491
 492 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
 495         abs.
 496
 497 2020-02-26  Tom Tromey  <tom@tromey.com>
 498
 499         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
 500         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
 501         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
 502         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
 503         per_cu_data.
 504
 505 2020-02-26  Tom Tromey  <tom@tromey.com>
 506
 507         * dwarf2/index-write.c (psym_index_map): Change type.
 508         (add_address_entry_worker, write_one_signatured_type)
 509         (recursively_count_psymbols, recursively_write_psymbols)
 510         (class debug_names, psyms_seen_size, write_gdbindex)
 511         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
 512
 513 2020-02-26  Aaron Merey  <amerey@redhat.com>
 514
 515         * Makefile.in: Handle optional debuginfod support.
 516         * NEWS: Update.
 517         * README: Add --with-debuginfod summary.
 518         * config.in: Regenerate.
 519         * configure: Regenerate.
 520         * configure.ac: Handle optional debuginfod support.
 521         * debuginfod-support.c: debuginfod helper functions.
 522         * debuginfod-support.h: Ditto.
 523         * doc/gdb.texinfo: Add --with-debuginfod to configure options
 524         summary.
 525         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
 526         when a dwz file cannot be found.
 527         * elfread.c (elf_symfile_read): Query debuginfod servers when a
 528         debuginfo file cannot be found.
 529         * source.c (open_source_file): Query debuginfod servers when a
 530         source file cannot be found.
 531         * top.c (print_gdb_configuration): Include
 532         --{with,without}-debuginfod in the output.
 533
 534 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
 535
 536         * thread.c (thr_try_catch_cmd): Print thread name.
 537
 538 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
 539
 540         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
 541         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 542         dwarf2_fetch_die_type_sect_off): Move to...
 543         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
 544         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 545         dwarf2_fetch_die_type_sect_off): ... here.
 546         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
 547         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 548         dwarf2_fetch_die_type_sect_off): Move doc to header file.
 549
 550 2020-02-26  Tom de Vries  <tdevries@suse.de>
 551
 552         PR gdb/25603
 553         * symfile.c (set_initial_language): Exit-early if
 554         language_mode == language_mode_manual.
 555
 556 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 557
 558         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
 559         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
 560         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
 561
 562 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 563
 564         * gdbtypes.c (create_array_type_with_stride): Handle negative
 565         array strides.
 566         * valarith.c (value_subscripted_rvalue): Likewise.
 567
 568 2020-02-25  Luis Machado  <luis.machado@linaro.org>
 569
 570         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
 571
 572 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 573
 574         * loc.h (dwarf2_get_die_type): Move to...
 575         * read.h (dwarf2_get_die_type): ... here.
 576         * read.c (dwarf2_get_die_type): Move doc to header.
 577
 578 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
 579
 580         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
 581         'gnulib/Makefile.in' to the list.
 582
 583 2020-02-24  Tom Tromey  <tom@tromey.com>
 584
 585         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
 586         Remove.
 587         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
 588         XOBNEWVEC.
 589
 590 2020-02-24  Tom Tromey  <tom@tromey.com>
 591
 592         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
 593         New method.
 594         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
 595         (dw2_do_instantiate_symtab, dw2_get_file_names)
 596         (build_type_psymtab_dependencies, load_full_type_unit): Update.
 597
 598 2020-02-24  Tom Tromey  <tom@tromey.com>
 599
 600         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
 601         make_scoped_restore.
 602         (dwarf2_psymtab::read_symtab): Don't clear
 603         reading_partial_symbols.
 604
 605 2020-02-24  Tom de Vries  <tdevries@suse.de>
 606
 607         PR gdb/25592
 608         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
 609
 610 2020-02-24  Tom de Vries  <tdevries@suse.de>
 611
 612         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
 613         commands layout next/prev/regs.
 614
 615 2020-02-22  Tom Tromey  <tom@tromey.com>
 616
 617         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
 618         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
 619
 620 2020-02-22  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
 623
 624 2020-02-22  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-win.c (_initialize_tui_win): Add usage text.
 627         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
 628         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
 629         * tui/tui.c (_initialize_tui): Add usage text.
 630
 631 2020-02-22  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-win.c (tui_set_focus_command)
 634         (tui_set_win_height_command): Use error_no_arg.
 635         (_initialize_tui_win): Update help text.
 636         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
 637
 638 2020-02-22  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
 641         * tui/tui-disasm.h (struct tui_disasm_window)
 642         <display_start_addr>: Declare.
 643         * tui/tui-source.h (struct tui_source_window)
 644         <display_start_addr>: Declare.
 645         * tui/tui-winsource.h (struct tui_source_window_base)
 646         <show_source_line, display_start_addr>: New methods.
 647         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
 648         Rename and move to protected section.
 649         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 650         (tui_source_window_base::do_erase_source_content): Update.
 651         (tui_source_window_base::show_source_line): Now a method.
 652         (tui_source_window_base::show_source_content)
 653         (tui_source_window_base::tui_source_window_base)
 654         (tui_source_window_base::rerender)
 655         (tui_source_window_base::refill)
 656         (tui_source_window_base::do_scroll_horizontal)
 657         (tui_source_window_base::set_is_exec_point_at)
 658         (tui_source_window_base::update_breakpoint_info)
 659         (tui_source_window_base::update_exec_info): Update.
 660         * tui/tui-source.c (tui_source_window::set_contents)
 661         (tui_source_window::showing_source_p)
 662         (tui_source_window::do_scroll_vertical)
 663         (tui_source_window::location_matches_p)
 664         (tui_source_window::line_is_displayed): Update.
 665         (tui_source_window::display_start_addr): New method.
 666         * tui/tui-disasm.c (tui_disasm_window::set_contents)
 667         (tui_disasm_window::do_scroll_vertical)
 668         (tui_disasm_window::location_matches_p): Update.
 669         (tui_disasm_window::display_start_addr): New method.
 670
 671 2020-02-22  Tom Tromey  <tom@tromey.com>
 672
 673         * NEWS: Add entry for gdb.register_window_type.
 674         * tui/tui-layout.h (window_factory): New typedef.
 675         (tui_register_window): Declare.
 676         * tui/tui-layout.c (saved_tui_windows): New global.
 677         (tui_apply_current_layout): Use it.
 678         (tui_register_window): New function.
 679         * python/python.c (do_start_initialization): Call
 680         gdbpy_initialize_tui.
 681         (python_GdbMethods): Add "register_window_type" function.
 682         * python/python-internal.h (gdbpy_register_tui_window)
 683         (gdbpy_initialize_tui): Declare.
 684         * python/py-tui.c: New file.
 685         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
 686
 687 2020-02-22  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
 690
 691 2020-02-22  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
 694         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
 695         * tui/tui-data.c (tui_set_win_with_focus): Remove.
 696         (tui_set_win_focus_to): Move from tui-win.c.
 697
 698 2020-02-22  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-layout.c (make_standard_window, get_locator_window): New
 701         functions.
 702         (known_window_types): New global.
 703         (tui_get_window_by_name): Reimplement.
 704         (initialize_known_windows): New function.
 705         (validate_window_name): Rewrite.
 706         (_initialize_tui_layout): Call initialize_known_windows.
 707
 708 2020-02-22  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
 711         Remove constants.
 712         * tui/tui-winsource.h (struct tui_source_window_base)
 713         <tui_source_window_base>: Remove parameter.
 714         * tui/tui-winsource.c
 715         (tui_source_window_base::tui_source_window_base): Remove
 716         parameter.
 717         (tui_source_window_base::refill): Update.
 718         * tui/tui-stack.h (struct tui_locator_window)
 719         <tui_locator_window>: Update.
 720         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
 721         Default the constructor.
 722         * tui/tui-regs.h (struct tui_data_item_window)
 723         <tui_data_item_window>: Default the constructor.
 724         (struct tui_data_window) <tui_data_window>: Likewise.
 725         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
 726         Default the constructor.
 727         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
 728         Default the constructor.
 729         <type>: Remove.
 730         (struct tui_win_info) <tui_win_info>: Default the constructor.
 731         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
 732         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 733         Default the constructor.
 734
 735 2020-02-22  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
 738         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
 739         * tui/tui-win.c (tui_resize_all): Don't call
 740         tui_delete_invisible_windows.
 741         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
 742         done.
 743         (tui_set_layout): Update.
 744         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
 745         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
 746         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
 747
 748 2020-02-22  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
 751         correctly.
 752
 753 2020-02-22  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
 756
 757 2020-02-22  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-winsource.h (struct tui_source_window_iterator)
 760         <inner_iterator>: New etytypedef.
 761         <tui_source_window_iterator>: Take "end" parameter.
 762         <tui_source_window_iterator>: Take iterator.
 763         <operator*, advance>: Update.
 764         <m_iter>: Change type.
 765         <m_end>: New field.
 766         (struct tui_source_windows) <begin, end>: Update.
 767         * tui/tui-layout.c (tui_windows): New global.
 768         (tui_apply_current_layout): Clear tui_windows.
 769         (tui_layout_window::apply): Update tui_windows.
 770         * tui/tui-data.h (tui_windows): Declare.
 771         (all_tui_windows): Now inline function.
 772         (class tui_window_iterator, struct all_tui_windows): Remove.
 773
 774 2020-02-22  Tom Tromey  <tom@tromey.com>
 775
 776         PR tui/17850:
 777         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
 778         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
 779         "height" argument.
 780         (class tui_layout_window) <get_sizes>: Likewise.
 781         (class tui_layout_split) <tui_layout_split>: Add "vertical"
 782         argument.
 783         <get_sizes>: Add "height" argument.
 784         <m_vertical>: New field.
 785         * tui/tui-layout.c (tui_layout_split::clone): Update.
 786         (tui_layout_split::get_sizes): Add "height" argument.
 787         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
 788         (tui_new_layout_command): Parse "-horizontal".
 789         (_initialize_tui_layout): Update help string.
 790         (tui_layout_split::specification): Add "-horizontal" when needed.
 791         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
 792         argument.
 793         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
 794         New methods.
 795
 796 2020-02-22  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-layout.h (enum tui_adjust_result): New.
 799         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
 800         (class tui_layout_window) <adjust_size>: Return
 801         tui_adjust_result.  Rewrite.
 802         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
 803         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
 804
 805 2020-02-22  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
 808         parameter and return types.
 809         (class tui_layout_base) <specification>: Add "depth".
 810         (class tui_layout_window) <specification>: Add "depth".
 811         (class tui_layout_split) <specification>: Add "depth".
 812         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
 813         and return types.
 814         (tui_new_layout_command): Parse sub-layouts.
 815         (_initialize_tui_layout): Update help string.
 816         (tui_layout_window::specification): Add "depth".
 817         (add_layout_command): Update.
 818
 819 2020-02-22  Tom Tromey  <tom@tromey.com>
 820
 821         * NEWS: Add "tui new-layout" item.
 822         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
 823         Add new-layout command to help text.
 824         (validate_window_name): New function.
 825         (tui_new_layout_command): New function.
 826         (_initialize_tui_layout): Register "new-layout".
 827         (tui_layout_window::specification): New method.
 828         (tui_layout_window::specification): New method.
 829         * tui/tui-layout.h (class tui_layout_base) <specification>: New
 830         method.
 831         (class tui_layout_window) <specification>: New method.
 832         (class tui_layout_split) <specification>: New method.
 833
 834 2020-02-22  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
 837         * tui/tui-win.c (window_name_completer): Update comment.
 838         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
 839         Declare method.
 840         (class tui_layout_window) <replace_window>: Likewise.
 841         (class tui_layout_split) <replace_window>: Likewise.
 842         (tui_set_layout): Don't declare.
 843         (tui_set_initial_layout): Declare function.
 844         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
 845         (asm_regs_layout): New globals.
 846         (tui_current_layout, show_layout): Remove.
 847         (tui_set_layout, tui_add_win_to_layout): Rewrite.
 848         (find_layout, tui_apply_layout): New function.
 849         (layout_completer): Remove.
 850         (tui_next_layout): Reimplement.
 851         (tui_next_layout_command): New function.
 852         (tui_set_initial_layout, tui_prev_layout_command): New functions.
 853         (tui_regs_layout): Reimplement.
 854         (tui_regs_layout_command): New function.
 855         (extract_display_start_addr): Rewrite.
 856         (next_layout, prev_layout): Remove.
 857         (tui_layout_window::replace_window): New method.
 858         (tui_layout_split::replace_window): New method.
 859         (destroy_layout): New function.
 860         (layout_list): New global.
 861         (add_layout_command): New function.
 862         (initialize_layouts): Update.
 863         (tui_layout_command): New function.
 864         (_initialize_tui_layout): Install "layout" commands.
 865         * tui/tui-data.h (enum tui_layout_type): Remove.
 866         (tui_current_layout): Don't declare.
 867
 868 2020-02-22  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-regs.c (tui_reg_layout): Remove.
 871         (tui_reg_command): Use tui_regs_layout.
 872         * tui/tui-layout.h (tui_reg_command): Declare.
 873         * tui/tui-layout.c (tui_reg_command): New function.
 874
 875 2020-02-22  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui.c (tui_rl_delete_other_windows): Call
 878         tui_remove_some_windows.
 879         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
 880         Declare method.
 881         (class tui_layout_window) <remove_windows>: New method.
 882         (class tui_layout_split) <remove_windows>: Declare.
 883         (tui_remove_some_windows): Declare.
 884         * tui/tui-layout.c (tui_remove_some_windows): New function.
 885         (tui_layout_split::remove_windows): New method.
 886
 887 2020-02-22  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
 890         * tui/tui-layout.h (tui_next_layout): Declare.
 891         * tui/tui-layout.c (tui_next_layout): New function.
 892
 893 2020-02-22  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
 896         correct coordinates.
 897
 898 2020-02-22  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
 901         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
 902         DATA_WIN case.
 903
 904 2020-02-22  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
 907         TUI_DISASM_WIN, not tui_win_list.
 908
 909 2020-02-22  Tom Tromey  <tom@tromey.com>
 910
 911         * valprint.c (generic_val_print_enum_1)
 912         (val_print_type_code_flags): Style member names.
 913         * rust-lang.c (val_print_struct, rust_print_enum)
 914         (rust_print_struct_def, rust_internal_print_type): Style member
 915         names.
 916         * p-valprint.c (pascal_object_print_value_fields): Style member
 917         names.  Only call fprintf_symbol_filtered for static members.
 918         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
 919         * f-valprint.c (f_val_print): Style member names.
 920         * f-typeprint.c (f_type_print_base): Style member names.
 921         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
 922         call fprintf_symbol_filtered for static members.
 923         (cp_print_class_member): Style member names.
 924         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
 925         member names.
 926         * ada-valprint.c (ada_print_scalar): Style enum names.
 927         (ada_val_print_enum): Likewise.
 928         * ada-typeprint.c (print_enum_type): Style enum names.
 929
 930 2020-02-21  Tom Tromey  <tom@tromey.com>
 931
 932         * psympriv.h (struct partial_symtab): Update comment.
 933
 934 2020-02-21  Tom Tromey  <tromey@adacore.com>
 935
 936         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
 937         type is CORE_ADDR.
 938
 939 2020-02-21  Tom de Vries  <tdevries@suse.de>
 940
 941         PR gdb/25534
 942         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
 943         if dependencies[i]->user != NULL.
 944
 945 2020-02-21  Ali Tamur  <tamur@google.com>
 946
 947         * dwarf2/read.c (dwarf2_name): Add null check.
 948
 949 2020-02-20  Tom Tromey  <tom@tromey.com>
 950
 951         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
 952         ">=", in binary search.
 953         (dwarf2_find_containing_comp_unit): New overload.
 954         (run_test): New self-test.
 955         (_initialize_dwarf2_read): Register new test.
 956
 957 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
 958
 959         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
 960         * riscv-tdep.h: Likewise.
 961         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
 962         rv32-only CSR.
 963         * features/riscv/64bit-csr.xml: Regenerated.
 964
 965 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
 966             Tom Tromey  <tom@tromey.com>
 967
 968         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
 969         of 'fputc_unfiltered'.
 970         (putchar_unfiltered): Call 'fputc_unfiltered'.
 971         (fputc_unfiltered): Call 'fputs_unfiltered'.
 972
 973 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * config.in: Regenerate.
 976         * configure: Regenerate.
 977         * configure.ac: Add --with-python-libdir option.
 978         * main.c: Use WITH_PYTHON_LIBDIR.
 979
 980 2020-02-19  Tom Tromey  <tom@tromey.com>
 981
 982         * symtab.c (general_symbol_info::compute_and_set_names): Use
 983         obstack_strndup.  Simplify call to symbol_set_demangled_name.
 984
 985 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
 986
 987         * dwarf2/read.c (allocate_signatured_type_table,
 988         allocate_dwo_unit_table, allocate_type_unit_groups_table,
 989         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
 990         Remove objfile parameter, update all callers.
 991
 992 2020-02-19  Doug Evans  <dje@google.com>
 993
 994         PR rust/25535
 995         * rust-lang.c (rust_print_enum): Apply embedded_offset to
 996         rust_enum_variant calculation.
 997
 998 2020-02-19  Tom Tromey  <tromey@adacore.com>
 999
1000         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
1001
1002 2020-02-19  Tom Tromey  <tromey@adacore.com>
1003
1004         * ada-lang.c (cache_symbol): Use obstack_strdup.
1005
1006 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * configure: Regenerate.
1009
1010 2020-02-19  Tom Tromey  <tromey@adacore.com>
1011
1012         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
1013         NULL check.
1014
1015 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
1016
1017         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
1018
1019 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1020
1021         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
1022         if GDBSERVER is not defined.
1023         (riscv_tdesc_cache): Likewise, also store const target_desc.
1024         (STATIC_IN_GDB): Define.
1025         (riscv_create_target_description): Update declaration with
1026         STATIC_IN_GDB.
1027         (riscv_lookup_target_description): New function, only define if
1028         GDBSERVER is not defined.
1029         * arch/riscv.h (riscv_create_target_description): Declare only
1030         when GDBSERVER is defined.
1031         (riscv_lookup_target_description): New declaration when GDBSERVER
1032         is not defined.
1033         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
1034         (riscv_linux_read_features): ...this, and return
1035         riscv_gdbarch_features instead of target_desc.
1036         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
1037         (riscv_linux_read_description): Rename to...
1038         (riscv_linux_read_features): ...this.
1039         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1040         Update to use riscv_gdbarch_features and
1041         riscv_lookup_target_description.
1042         * riscv-tdep.c (riscv_find_default_target_description): Use
1043         riscv_lookup_target_description instead of
1044         riscv_create_target_description.
1045
1046 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1047
1048         * valprint.c (generic_val_print_enum_1): When printing a flag
1049         enum with value 0 and there is no enumerator with value 0, print
1050         just "0" instead of "(unknown: 0x0)".
1051
1052 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1053
1054         * valprint.c (generic_val_print_enum_1): Print unknown part of
1055         flag enum in hex.
1056
1057 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1058
1059         * dwarf2/read.c (update_enumeration_type_from_children): Allow
1060         flag enums to contain duplicate enumerators.
1061         * valprint.c (generic_val_print_enum_1): Update comment.
1062
1063 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1064
1065         * dwarf2/read.c: Include "count-one-bits.h".
1066         (update_enumeration_type_from_children): If an enumerator has
1067         multiple bits set, don't treat the enumeration as a "flag enum".
1068         * valprint.c (generic_val_print_enum_1): Assert that enumerators
1069         of flag enums have 0 or 1 bit set.
1070
1071 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1072
1073         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
1074         conversion.
1075         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1076         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1077         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1078         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1079         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1080
1081 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1082
1083         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
1084
1085 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1086
1087         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
1088         displaced_step_closure_up.
1089         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1090         (struct displaced_step_closure_up):
1091         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1092         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1093         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
1094         Likewise.
1095         * gdbarch.sh (displaced_step_copy_insn): Likewise.
1096         * gdbarch.c, gdbarch.h: Re-generate.
1097         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
1098         displaced_step_closure_up.
1099         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1100         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1101         * infrun.h (displaced_step_closure_up): New type alias.
1102         (struct displaced_step_inferior_state) <step_closure>: Change
1103         type to displaced_step_closure_up.
1104         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
1105         displaced_step_closure_up.
1106         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1107
1108 2020-02-14  Tom Tromey  <tom@tromey.com>
1109
1110         * minidebug.c (gnu_debug_key): New global.
1111         (find_separate_debug_file_in_section): Use it.
1112
1113 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1114
1115         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
1116         std::unique_ptr.
1117         * gdbarch.c: Re-generate.
1118         * gdbarch.h: Re-generate.
1119         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
1120         change.
1121         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
1122         type to std::unique_ptr.
1123         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1124         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1125         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1126         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1127         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
1128         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1129         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1130         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1131         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1132
1133 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1134
1135         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
1136         std::unique_ptr.
1137         (displaced_step_clear): Rename to...
1138         (displaced_step_reset): ... this.  Just call displaced->reset ().
1139         (displaced_step_clear_cleanup): Rename to...
1140         (displaced_step_reset_cleanup): ... this.
1141         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
1142         (displaced_step_fixup): Likewise.
1143         (resume_1): Likewise.
1144         (handle_inferior_event): Restore child's memory before calling
1145         displaced_step_fixup on the parent.
1146         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
1147         to std::unique_ptr.
1148         <step_closure>: Change type to std::unique_ptr.
1149
1150 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1151
1152         * arm-tdep.c: Include count-one-bits.h.
1153         (cleanup_block_store_pc): Use count_one_bits.
1154         (cleanup_block_load_pc): Use count_one_bits.
1155         (arm_copy_block_xfer): Use count_one_bits.
1156         (thumb2_copy_block_xfer): Use count_one_bits.
1157         (thumb_copy_pop_pc_16bit): Use count_one_bits.
1158         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
1159         (thumb_get_next_pcs_raw): Use count_one_bits.
1160         (arm_get_next_pcs_raw): Use count_one_bits_l.
1161         * arch/arm.c (bitcount): Remove.
1162         * arch/arm.h (bitcount): Remove.
1163
1164 2020-02-14  Tom Tromey  <tromey@adacore.com>
1165
1166         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
1167         Update.
1168         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
1169         * dwarf2/loc.c (call_site_find_chain_1): Return
1170         unique_xmalloc_ptr.
1171         (call_site_find_chain): Likewise.
1172
1173 2020-02-14  Richard Biener  <rguenther@suse.de>
1174
1175         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
1176         on expression with division operators.
1177
1178 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1179
1180         * MAINTAINERS (Write After Approval): Adding myself.
1181
1182 2020-02-12  Tom Tromey  <tom@tromey.com>
1183
1184         * event-loop.c (event_data, gdb_event, event_handler_func):
1185         Remove.
1186
1187 2020-02-12  Tom Tromey  <tom@tromey.com>
1188
1189         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
1190         (dwarf2_frame_objfile_data): Add comment.
1191         (find_comp_unit, set_comp_unit): New functions.
1192         (dwarf2_frame_find_fde): Use find_comp_unit.
1193         (dwarf2_build_frame_info): Use set_comp_unit.
1194
1195 2020-02-12  Tom Tromey  <tom@tromey.com>
1196
1197         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
1198         (comp_unit): Don't initialize objfile.
1199         (execute_cfa_program): Add text_offset parameter.
1200         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
1201         (dwarf2_frame_cache): Update.
1202         (dwarf2_build_frame_info): Don't set "objfile" member.
1203
1204 2020-02-12  Tom Tromey  <tom@tromey.com>
1205
1206         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
1207         (decode_frame_entry): Likewise.
1208         (dwarf2_build_frame_info): Update.
1209
1210 2020-02-12  Tom Tromey  <tom@tromey.com>
1211
1212         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
1213         (decode_frame_entry_1): Use the comp_unit obstack.
1214
1215 2020-02-12  Tom Tromey  <tom@tromey.com>
1216
1217         * dwarf2/frame.c (struct comp_unit): Add initializers and
1218         constructor.
1219         (dwarf2_frame_objfile_data): Store a comp_unit.
1220         (dwarf2_frame_find_fde): Update.
1221         (dwarf2_build_frame_info): Use "new".
1222
1223 2020-02-12  Tom Tromey  <tom@tromey.com>
1224
1225         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
1226         (dwarf2_fde_table): Typedef for std::vector.
1227         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
1228         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
1229         (decode_frame_entry): Update.
1230         (dwarf2_build_frame_info): Use "new".
1231
1232 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1233
1234         * arm-tdep.c (arm_gdbarch_init): Update.
1235         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
1236         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
1237         have_neon, is_m>: Change to bool.
1238
1239 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1240
1241         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
1242
1243 2020-02-12  Tom Tromey  <tom@tromey.com>
1244
1245         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
1246
1247 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
1248
1249         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
1250         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
1251
1252 2020-02-11  Tom Tromey  <tom@tromey.com>
1253
1254         * psymtab.h: Update comment.
1255
1256 2020-02-11  Tom Tromey  <tom@tromey.com>
1257
1258         * gdb_obstack.h (struct auto_obstack): Use
1259         DISABLE_COPY_AND_ASSIGN.
1260
1261 2020-02-11  Tom Tromey  <tom@tromey.com>
1262
1263         * dwarf2/frame.h (struct objfile): Don't forward declare.
1264
1265 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1266
1267         * cris-tdep.c (cris_supply_gregset): Change signature to match
1268         what struct regset expects.
1269         (cris_regset): New struct.
1270         (fetch_core_registers): Remove.
1271         (cris_iterate_over_regset_sections): New function.
1272         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
1273         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
1274
1275 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1276
1277         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
1278         registers.
1279
1280 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1281
1282         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
1283
1284 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1285
1286         * configure: Re-generate.
1287
1288 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1289
1290         * configure: Re-generate.
1291
1292 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1293
1294         * acinclude: Update warning.m4 path.
1295         * warning.m4: Move to gdbsupport.
1296
1297 2020-02-11  Tom Tromey  <tromey@adacore.com>
1298
1299         * remote.c (remote_console_output): Update.
1300         * printcmd.c (printf_command): Update.
1301         * event-loop.c (gdb_wait_for_event): Update.
1302         * linux-nat.c (sigchld_handler): Update.
1303         * remote-sim.c (gdb_os_write_stdout): Update.
1304         (gdb_os_flush_stdout): Update.
1305         (gdb_os_flush_stderr): Update.
1306         (gdb_os_write_stderr): Update.
1307         * exceptions.c (print_exception): Update.
1308         * remote-fileio.c (remote_fileio_func_read): Update.
1309         (remote_fileio_func_write): Update.
1310         * tui/tui.c (tui_enable): Update.
1311         * tui/tui-interp.c (tui_interp::init): Update.
1312         * utils.c (init_page_info): Update.
1313         (putchar_unfiltered, fputc_unfiltered): Update.
1314         (gdb_flush): Update.
1315         (emit_style_escape): Update.
1316         (flush_wrap_buffer, fputs_maybe_filtered): Update.
1317         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
1318         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
1319         (stderr_file::write): Update.
1320         (stderr_file::puts): Update.
1321         * ui-file.h (ui_file_isatty, ui_file_write)
1322         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
1323         (ui_file_puts): Don't declare.
1324
1325 2020-02-10  Tom de Vries  <tdevries@suse.de>
1326
1327         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
1328         sentinel to char *.
1329
1330 2020-02-09  Tom de Vries  <tdevries@suse.de>
1331
1332         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
1333         filename if it matches "<artificial>".
1334
1335 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1336
1337         * windows-tdep.c (struct enum_value_name): New struct.
1338         (create_enum): New function.
1339         (windows_get_siginfo_type): Create and use enum types.
1340
1341 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1342
1343         * NEWS: Mention $_siginfo support for Windows.
1344         * windows-nat.c (handle_exception): Set siginfo_er.
1345         (windows_nat_target::mourn_inferior): Reset siginfo_er.
1346         (windows_xfer_siginfo): New function.
1347         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
1348         * windows-tdep.c (struct windows_gdbarch_data): New struct.
1349         (init_windows_gdbarch_data): New function.
1350         (get_windows_gdbarch_data): New function.
1351         (windows_get_siginfo_type): New function.
1352         (windows_init_abi): Register windows_get_siginfo_type.
1353         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
1354
1355 2020-02-08  Tom Tromey  <tom@tromey.com>
1356
1357         * dwarf2/read.c (class cutu_reader) <cutu_reader,
1358         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
1359         <keep>: Declare method.
1360         <m_keep>: Remove member.
1361         <~cutu_reader>: Remove.
1362         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1363         (cutu_reader::cutu_reader): Update.
1364         (cutu_reader::keep): Rename from ~cutu_reader.
1365         (process_psymtab_comp_unit, build_type_psymtabs_1)
1366         (process_skeletonless_type_unit, load_partial_comp_unit)
1367         (load_full_comp_unit, dwarf2_read_addr_index)
1368         (read_signatured_type): Update.
1369
1370 2020-02-08  Tom Tromey  <tom@tromey.com>
1371
1372         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
1373         "want_partial_unit" parameter.
1374         (process_psymtab_comp_unit): Change want_partial_unit to bool.
1375         Inline check for DW_TAG_partial_unit.
1376         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
1377
1378 2020-02-08  Tom Tromey  <tom@tromey.com>
1379
1380         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
1381         read.c.
1382         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
1383         read.c.
1384
1385 2020-02-08  Tom Tromey  <tom@tromey.com>
1386
1387         * dwarf2/read.c (read_address): Move to comp-unit.c.
1388         (dwarf2_rnglists_process, dwarf2_ranges_process)
1389         (read_attribute_value, dwarf_decode_lines_1)
1390         (var_decode_location, decode_locdesc): Update.
1391         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
1392         read.c.  Remove "cu" parameter.
1393         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
1394         method.
1395
1396 2020-02-08  Tom Tromey  <tom@tromey.com>
1397
1398         * dwarf2/read.c (read_attribute_value, read_indirect_string)
1399         (read_indirect_line_string): Update.
1400         * dwarf2/comp-unit.c (read_offset): Remove.
1401         (read_comp_unit_head): Update.
1402         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
1403         method.
1404         (read_offset): Don't declare.
1405
1406 2020-02-08  Tom Tromey  <tom@tromey.com>
1407
1408         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
1409         * dwarf2/read.c (struct comp_unit_head): Move to
1410         dwarf2/comp-unit.h.
1411         (enum class rcuh_kind): Move to comp-unit.h.
1412         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
1413         (read_comp_unit_head, error_check_comp_unit_head)
1414         (read_and_check_comp_unit_head): Move to comp-unit.c.
1415         (read_offset, dwarf_unit_type_name): Likewise.
1416         (create_debug_type_hash_table, read_cutu_die_from_dwo)
1417         (cutu_reader::cutu_reader, read_call_site_scope)
1418         (find_partial_die, follow_die_offset): Update.
1419         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
1420
1421 2020-02-08  Tom Tromey  <tom@tromey.com>
1422
1423         * dwarf2/read.c (read_offset_1): Move to leb.c.
1424         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
1425         (dwarf_decode_macro_bytes): Update.
1426         * dwarf2/leb.c (read_offset): Rename; move from read.c.
1427         * dwarf2/leb.h (read_offset): Declare.
1428
1429 2020-02-08  Tom Tromey  <tom@tromey.com>
1430
1431         * dwarf2/read.c (dwarf2_section_size): Remove.
1432         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
1433         Update.
1434         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
1435
1436 2020-02-08  Tom Tromey  <tom@tromey.com>
1437
1438         * dwarf2/read.c (read_initial_length): Move to leb.c.
1439         * dwarf2/leb.h (read_initial_length): Declare.
1440         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
1441         handle_nonstd parameter.
1442         * dwarf2/frame.c (read_initial_length): Remove.
1443         (decode_frame_entry_1): Update.
1444
1445 2020-02-08  Tom Tromey  <tom@tromey.com>
1446
1447         * dwarf2/loc.c (dwarf2_find_location_expression)
1448         (dwarf_evaluate_loc_desc::get_tls_address)
1449         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
1450         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
1451         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
1452         (dwarf2_compile_property_to_c)
1453         (dwarf2_loc_desc_get_symbol_read_needs)
1454         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
1455         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
1456         (loclist_describe_location, loclist_tracepoint_var_ref)
1457         (loclist_generate_c_location): Update.
1458         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1459         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
1460         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
1461         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
1462         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
1463         (dwarf2_per_cu_data::addr_size)
1464         (dwarf2_per_cu_data::ref_addr_size)
1465         (dwarf2_per_cu_data::text_offset)
1466         (dwarf2_per_cu_data::addr_type): Now methods.
1467         (per_cu_header_read_in): Make per_cu "const".
1468         (dwarf2_version): Remove.
1469         (dwarf2_per_cu_data::int_type): Now a method.
1470         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
1471         (set_die_type, read_array_type, read_subrange_index_type)
1472         (read_tag_string_type, read_subrange_type): Update.
1473         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
1474         offset_size, ref_addr_size, text_offset, addr_type, version,
1475         objfile, int_type, addr_sized_int_type>: Declare methods.
1476
1477 2020-02-08  Tom Tromey  <tom@tromey.com>
1478
1479         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
1480         Move earlier.
1481
1482 2020-02-08  Tom Tromey  <tom@tromey.com>
1483
1484         * dwarf2/read.h (dwarf_line_debug): Declare.
1485         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
1486         * dwarf2/read.c: Move line_header code to new files.
1487         (dwarf_line_debug): No longer static.
1488         * dwarf2/line-header.c: New file.
1489         * dwarf2/line-header.h: New file.
1490
1491 2020-02-08  Tom Tromey  <tom@tromey.com>
1492
1493         * dwarf2/read.c (struct line_header) <file_full_name,
1494         file_file_name>: Return unique_xmalloc_ptr.
1495         (line_header::file_file_name): Update.
1496         (line_header::file_full_name): Update.
1497         (dw2_get_file_names_reader): Update.
1498         (macro_start_file): Update.
1499
1500 2020-02-08  Tom Tromey  <tom@tromey.com>
1501
1502         * dwarf2/read.c (struct line_header) <file_full_name,
1503         file_file_name>: Declare methods.
1504         (dw2_get_file_names_reader): Update.
1505         (file_file_name): Now a method.
1506         (file_full_name): Likewise.
1507         (macro_start_file): Update.
1508
1509 2020-02-08  Tom Tromey  <tom@tromey.com>
1510
1511         * dwarf2/read.c (dwarf_always_disassemble)
1512         (show_dwarf_always_disassemble): Move to loc.c.
1513         (_initialize_dwarf2_read): Move "always-disassemble" registration
1514         to loc.c.
1515         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
1516         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
1517         static.
1518         (show_dwarf_always_disassemble): Move from read.c.
1519         (_initialize_dwarf2loc): Move always-disassemble from read.c.
1520
1521 2020-02-08  Tom Tromey  <tom@tromey.com>
1522
1523         * dwarf2/read.c (~dwarf2_per_objfile): Update.
1524         (create_quick_file_names_table): Return htab_up.
1525         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
1526         Update.
1527         * dwarf2/read.h (struct dwarf2_per_objfile)
1528         <quick_file_names_table>: Now htab_up.
1529
1530 2020-02-08  Tom Tromey  <tom@tromey.com>
1531
1532         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
1533
1534 2020-02-08  Tom Tromey  <tom@tromey.com>
1535
1536         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
1537         Rewrite.
1538         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
1539         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
1540         (abbrev_table::abbrev_table): No longer inline.
1541         (ABBREV_HASH_SIZE): Remove.
1542         (abbrev_table::m_abbrevs): Now an htab_up.
1543
1544 2020-02-08  Tom Tromey  <tom@tromey.com>
1545
1546         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
1547         (cutu_reader): Update.
1548         (build_type_psymtabs_1): Update.
1549         * dwarf2/abbrev.c (abbrev_table::read): Rename.
1550         (abbrev_table::alloc_abbrev): Update.
1551         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
1552         (abbrev_table::read): New static method, renamed from
1553         abbrev_table_read_table.
1554         (abbrev_table::alloc_abbrev)
1555         (abbrev_table::add_abbrev): Now private.
1556         (abbrev_table::abbrev_table): Now private.
1557         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
1558
1559 2020-02-08  Tom Tromey  <tom@tromey.com>
1560
1561         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
1562         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
1563         htab_up.
1564
1565 2020-02-08  Tom Tromey  <tom@tromey.com>
1566
1567         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
1568         htab_up.
1569         (lookup_dwo_unit_in_dwp): Update.
1570         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
1571         on obstack.
1572
1573 2020-02-08  Tom Tromey  <tom@tromey.com>
1574
1575         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
1576         obstack.
1577
1578 2020-02-08  Tom Tromey  <tom@tromey.com>
1579
1580         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
1581         line_header_hash.
1582         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
1583         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
1584         Change type to htab_up.
1585
1586 2020-02-08  Tom Tromey  <tom@tromey.com>
1587
1588         * dwarf2/read.c (allocate_type_unit_groups_table): Return
1589         htab_up.  Don't allocate on obstack.
1590         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
1591         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
1592         Change type to htab_up.
1593
1594 2020-02-08  Tom Tromey  <tom@tromey.com>
1595
1596         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
1597         Change type to htab_up.
1598         * dwarf2/read.c (create_signatured_type_table_from_index)
1599         (create_signatured_type_table_from_debug_names)
1600         (create_all_type_units, add_type_unit)
1601         (lookup_dwo_signatured_type, lookup_signatured_type)
1602         (process_skeletonless_type_unit): Update.
1603         (create_debug_type_hash_table, create_debug_types_hash_table):
1604         Change type of types_htab.
1605         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
1606         htab_up.  Don't allocate on obstack.
1607         (create_cus_hash_table): Change type of cus_htab parameter.
1608         (struct dwo_file) <cus, tus>: Now htab_up.
1609         (lookup_dwo_signatured_type, lookup_dwo_cutu)
1610         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
1611         (queue_and_load_all_dwo_tus): Update.
1612         * dwarf2/index-write.c (write_gdbindex): Update.
1613         (write_debug_names): Update.
1614
1615 2020-02-08  Tom Tromey  <tom@tromey.com>
1616
1617         * dwarf2/read.h (struct dwarf2_queue_item): Move from
1618         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
1619         destructor.
1620         (struct dwarf2_per_objfile) <queue>: New member.
1621         * dwarf2/read.c (struct dwarf2_queue_item): Move to
1622         dwarf2/read.h.
1623         (dwarf2_queue, dwarf2_queue_tail): Remove.
1624         (class dwarf2_queue_guard): Add parameter to constructor.  Use
1625         DISABLE_COPY_AND_ASSIGN.
1626         <m_per_objfile>: New member.
1627         <~dwarf2_queue_guard>: Rewrite.
1628         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
1629         Update.
1630         (~dwarf2_queue_item): New.
1631
1632 2020-02-08  Tom Tromey  <tom@tromey.com>
1633
1634         * dwarf2/read.c (struct die_info) <has_children>: New member.
1635         (dw2_get_file_names_reader): Remove has_children.
1636         (dw2_get_file_names): Update.
1637         (read_cutu_die_from_dwo): Remove has_children.
1638         (cutu_reader::init_tu_and_read_dwo_dies)
1639         (cutu_reader::cutu_reader): Update.
1640         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
1641         Remove has_children.
1642         (build_type_psymtabs_1, process_skeletonless_type_unit)
1643         (load_partial_comp_unit, load_full_comp_unit): Update.
1644         (create_dwo_cu_reader): Remove has_children.
1645         (create_cus_hash_table, read_die_and_children): Update.
1646         (read_full_die_1,read_full_die): Remove has_children.
1647         (read_signatured_type): Update.
1648         (class cutu_reader) <has_children>: Remove.
1649
1650 2020-02-08  Tom Tromey  <tom@tromey.com>
1651
1652         * dwarf2/expr.c: Rename from dwarf2expr.c.
1653         * dwarf2/expr.h: Rename from dwarf2expr.h.
1654         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
1655         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
1656         * dwarf2/frame.c: Rename from dwarf2-frame.c.
1657         * dwarf2/frame.h: Rename from dwarf2-frame.h.
1658         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
1659         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
1660         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
1661         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
1662         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
1663         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
1664         * dwarf2/loc.c: Rename from dwarf2loc.c.
1665         * dwarf2/loc.h: Rename from dwarf2loc.h.
1666         * dwarf2/read.c: Rename from dwarf2read.c.
1667         * dwarf2/read.h: Rename from dwarf2read.h.
1668         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
1669         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
1670         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
1671         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
1672         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
1673         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
1674         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
1675         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
1676         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
1677         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
1678         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
1679         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
1680         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
1681         Update.
1682         * Makefile.in (COMMON_SFILES): Update.
1683         (HFILES_NO_SRCDIR): Update.
1684
1685 2020-02-08  Tom Tromey  <tom@tromey.com>
1686
1687         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
1688         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
1689
1690 2020-02-08  Tom Tromey  <tom@tromey.com>
1691
1692         * dwarf2read.h (struct die_info): Don't declare.
1693
1694 2020-02-08  Tom Tromey  <tom@tromey.com>
1695
1696         * dwarf2read.h (die_info_ptr): Remove typedef.
1697
1698 2020-02-08  Tom Tromey  <tom@tromey.com>
1699
1700         * dwarf2read.c (read_call_site_scope)
1701         (handle_data_member_location, dwarf2_add_member_fn)
1702         (mark_common_block_symbol_computed, read_common_block)
1703         (attr_to_dynamic_prop, partial_die_info::read)
1704         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
1705         (dwarf2_symbol_mark_computed, set_die_type): Update.
1706         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
1707         method.
1708         (attr_form_is_block): Don't declare.
1709         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
1710
1711 2020-02-08  Tom Tromey  <tom@tromey.com>
1712
1713         * dwarf2read.c (dwarf2_find_base_address, )
1714         (read_call_site_scope, rust_containing_type)
1715         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
1716         (handle_data_member_location, dwarf2_add_member_fn)
1717         (get_alignment, read_structure_type, process_structure_scope)
1718         (mark_common_block_symbol_computed, read_common_block)
1719         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
1720         (partial_die_info::read, read_attribute_value, new_symbol)
1721         (lookup_die_type, dwarf2_get_ref_die_offset)
1722         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
1723         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
1724         (dwarf2_symbol_mark_computed): Update.
1725         * dwarf2/attribute.h (struct attribute) <value_as_address,
1726         form_is_section_offset, form_is_constant, form_is_ref>: Declare
1727         methods.
1728         (value_as_address, attr_form_is_section_offset)
1729         (attr_form_is_constant, attr_form_is_ref): Don't declare.
1730         * dwarf2/attribute.c (attribute::value_as_address)
1731         (attribute::form_is_section_offset, attribute::form_is_constant)
1732         (attribute::form_is_ref): Now methods.
1733
1734 2020-02-08  Tom Tromey  <tom@tromey.com>
1735
1736         * dwarf2read.c (struct attribute, DW_STRING)
1737         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
1738         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
1739         (attr_form_is_block, attr_form_is_section_offset)
1740         (attr_form_is_constant, attr_form_is_ref): Move.
1741         * dwarf2/attribute.h: New file.
1742         * dwarf2/attribute.c: New file, from dwarf2read.c.
1743         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
1744
1745 2020-02-08  Tom Tromey  <tom@tromey.com>
1746
1747         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
1748         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
1749         Move.
1750         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
1751         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
1752         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
1753         abbrev.c.
1754         * dwarf2/abbrev.h: New file.
1755         * dwarf2/abbrev.c: New file, from dwarf2read.c.
1756         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
1757
1758 2020-02-08  Tom Tromey  <tom@tromey.com>
1759
1760         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
1761         (dwarf2_section_size, dwarf2_get_section_info)
1762         (create_signatured_type_table_from_debug_names)
1763         (create_addrmap_from_aranges, read_debug_names_from_section)
1764         (get_gdb_index_contents_from_section, read_comp_unit_head)
1765         (error_check_comp_unit_head, read_abbrev_offset)
1766         (create_debug_type_hash_table, init_cu_die_reader)
1767         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
1768         (read_comp_units_from_section, create_cus_hash_table)
1769         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1770         (create_dwp_v2_section, dwarf2_rnglists_process)
1771         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
1772         (abbrev_table_read_table, read_indirect_string_at_offset_from)
1773         (read_indirect_string_from_dwz, read_addr_index_1)
1774         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
1775         (dwarf_decode_macro_bytes, dwarf_decode_macros)
1776         (fill_in_loclist_baton): Update.
1777         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
1778         get_containing_section, get_bfd_owner, get_bfd_section,
1779         get_file_name, get_id, get_flags, empty, read>: Declare methods.
1780         (dwarf2_read_section, get_section_name, get_section_file_name)
1781         (get_containing_section, get_section_bfd_owner)
1782         (get_section_bfd_section, get_section_name, get_section_file_name)
1783         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
1784         declare.
1785         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
1786         (dwarf2_section_info::get_bfd_owner)
1787         (dwarf2_section_info::get_bfd_section)
1788         (dwarf2_section_info::get_name)
1789         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
1790         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
1791         (dwarf2_section_info::read): Now methods.
1792         * dwarf-index-write.c (class debug_names): Update.
1793
1794 2020-02-08  Tom Tromey  <tom@tromey.com>
1795
1796         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
1797         Move to dwarf2/section.h.
1798         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
1799         (get_section_bfd_section, get_section_name)
1800         (get_section_file_name, get_section_id, get_section_flags)
1801         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
1802         dwarf2/section.c.
1803         * dwarf2/section.h: New file.
1804         * dwarf2/section.c: New file, from dwarf2read.c.
1805         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
1806
1807 2020-02-08  Tom Tromey  <tom@tromey.com>
1808
1809         * dwarf2read.h (read_unsigned_leb128): Don't declare.
1810         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
1811         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
1812         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
1813         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
1814         * dwarf2/leb.h: New file, from dwarf2read.c.
1815         * dwarf2/leb.c: New file, from dwarf2read.c.
1816         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
1817         Remove.
1818         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
1819         (COMMON_SFILES): Add dwarf2/leb.c.
1820
1821 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
1822
1823         GDB 9.1 released.
1824
1825 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1826
1827         PR gdb/25190:
1828         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
1829         * gdb/remote.c (remote_console_output): Update.
1830         * gdb/ui-file.c (fputs_unfiltered): Rename to...
1831         (ui_file_puts): ...this.
1832         * gdb/ui-file.h (ui_file_puts): Add declaration.
1833         * gdb/utils.c (emit_style_escape): Update.
1834         (flush_wrap_buffer): Update.
1835         (fputs_maybe_filtered): Update.
1836         (fputs_unfiltered): Add function.
1837
1838 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1839
1840         * gdb/event-loop.c (gdb_wait_for_event): Update.
1841         * gdb/printcmd.c (printf_command): Update.
1842         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
1843         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
1844         (gdb_os_flush_stderr): Update.
1845         * gdb/remote.c (remote_console_output): Update.
1846         * gdb/ui-file.c (gdb_flush): Rename to...
1847         (ui_file_flush): ...this.
1848         (stderr_file::write): Update.
1849         (stderr_file::puts): Update.
1850         * gdb/ui-file.h (gdb_flush): Rename to...
1851         (ui_file_flush): ...this.
1852         * gdb/utils.c (gdb_flush): Add function.
1853         * gdb/utils.h (gdb_flush): Add declaration.
1854
1855 2020-02-07  Tom Tromey  <tromey@adacore.com>
1856
1857         PR breakpoints/24915:
1858         * source.c (find_and_open_source): Do not check basenames_may_differ.
1859
1860 2020-02-07  Tom Tromey  <tom@tromey.com>
1861
1862         * README: Update gdbserver documentation.
1863         * gdbserver: Move to top level.
1864         * configure.tgt (build_gdbserver): Remove.
1865         * configure.ac: Remove --enable-gdbserver.
1866         * configure: Rebuild.
1867         * Makefile.in (distclean): Don't mention gdbserver.
1868
1869 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1870
1871         * source-cache.c (source_cache::ensure): Surround
1872         get_plain_source_lines with a try/catch.
1873         (source_cache::get_line_charpos): Get rid of try/catch
1874         and only check for the return value of "ensure".
1875         * tui/tui-source.c (tui_source_window::set_contents):
1876         Simplify "nlines" calculation.
1877
1878 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1879
1880         * MAINTAINERS (Write After Approval): Add myself.
1881
1882 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1883
1884         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
1885         function call.
1886
1887 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1888
1889         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
1890
1891 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
1892
1893         * nat/riscv-linux-tdesc.h: New file.
1894         * nat/riscv-linux-tdesc.c: New file, taking code from...
1895         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1896         ... here.
1897         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
1898         NATDEPFILES.
1899
1900 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
1903         we don't set the fake simulator ptid to the null_ptid.
1904
1905 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
1906
1907         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
1908         * gdbthread.h (class thread_info) <resumed>: Likewise.
1909         * infrun.c (resume_1): Likewise.
1910         (proceed): Likewise.
1911         (infrun_thread_stop_requested): Likewise.
1912         (stop_all_threads): Likewise.
1913         (handle_inferior_event): Likewise.
1914         (restart_threads): Likewise.
1915         (finish_step_over): Likewise.
1916         (keep_going_stepped_thread): Likewise.
1917         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
1918         (linux_handle_extended_wait): Likewise.
1919         * record-btrace.c (get_thread_current_frame_id): Likewise.
1920         * record-full.c (record_full_wait_1): Likewise.
1921         * remote.c (remote_target::process_initial_stop_replies): Likewise.
1922         * target.c (target_resume): Likewise.
1923         * thread.c (set_running_thread): Likewise.
1924
1925 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1926
1927         * f-valprint.c (f77_print_array_1): Changed datatype of index
1928         variable to LONGEST from int to enable it to contain bound
1929         values correctly.
1930
1931 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
1932
1933         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
1934         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
1935         offsets according to FLEN determined.
1936         (riscv_linux_nat_target::read_description): Determine FLEN
1937         dynamically.
1938         (riscv_linux_nat_target::fetch_registers): Size regset buffer
1939         according to FLEN determined.
1940         (riscv_linux_nat_target::store_registers): Likewise.
1941
1942 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1943
1944         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1945         when reg->group is empty and reggroup is not.
1946
1947 2020-01-31  Tom Tromey  <tromey@adacore.com>
1948
1949         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
1950         Call beneath target's mourn_inferior after unpushing.
1951
1952 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1953
1954         PR tui/9765
1955         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
1956         have enough lines to fill the screen, still return the lowest
1957         address we found.
1958
1959 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
1962         '-', '<', and '>' commands.
1963
1964 2020-01-29  Pedro Alves  <palves@redhat.com>
1965             Sergio Durigan Junior  <sergiodj@redhat.com>
1966
1967         * infcmd.c (construct_inferior_arguments): Assert that
1968         'argc' is greater than 0.
1969
1970 2020-01-29  Luis Machado  <luis.machado@linaro.org>
1971
1972         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
1973         (BRK_INSN_MASK): Define to 0xd4200000.
1974         (aarch64_program_breakpoint_here_p): New function.
1975         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
1976         * arch-utils.c (default_program_breakpoint_here_p): Moved from
1977         breakpoint.c.
1978         * arch-utils.h (default_program_breakpoint_here_p): Moved from
1979         breakpoint.h
1980         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
1981         call gdbarch_program_breakpoint_here_p.
1982         (program_breakpoint_here): Moved to arch-utils.c, renamed to
1983         default_program_breakpoint_here_p, changed return type to bool and
1984         simplified.
1985         * breakpoint.h (program_breakpoint_here): Moved prototype to
1986         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
1987         return type to bool.
1988         * gdbarch.c: Regenerate.
1989         * gdbarch.h: Regenerate.
1990         * gdbarch.sh (program_breakpoint_here_p): New method.
1991         * infrun.c (handle_signal_stop): Call
1992         gdbarch_program_breakpoint_here_p.
1993
1994 2020-01-26  Tom Tromey  <tom@tromey.com>
1995
1996         * ctfread.c (struct ctf_fp_info): Reindent.
1997         (_initialize_ctfread): Remove.
1998
1999 2020-01-26  Tom Tromey  <tom@tromey.com>
2000
2001         * psymtab.c (partial_map_expand_apply)
2002         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2003         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2004         (psym_print_stats, psym_expand_symtabs_for_function)
2005         (psym_map_symbol_filenames, psym_map_matching_symbols)
2006         (psym_expand_symtabs_matching)
2007         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2008         (maintenance_check_psymtabs): Use new methods.
2009         * psympriv.h (struct partial_symtab) <readin_p,
2010         get_compunit_symtab>: New methods.
2011         <readin, compunit_symtab>: Remove members.
2012         (struct standard_psymtab): New.
2013         (struct legacy_psymtab): Derive from standard_psymtab.
2014         * dwarf2read.h (struct dwarf2_psymtab): Derive from
2015         standard_psymtab.
2016         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
2017
2018 2020-01-26  Tom Tromey  <tom@tromey.com>
2019
2020         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
2021         read_dependencies.  Add assert.
2022         * psymtab.c (partial_symtab::read_dependencies): New method.
2023         * psympriv.h (struct partial_symtab) <read_dependencies>: New
2024         method.
2025         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
2026         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
2027         read_dependencies.
2028         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
2029         Add assert.
2030
2031 2020-01-26  Tom Tromey  <tom@tromey.com>
2032
2033         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
2034         Call expand_psymtab.
2035         (xcoff_read_symtab): Call expand_psymtab.
2036         (xcoff_start_psymtab, xcoff_end_psymtab): Set
2037         legacy_expand_psymtab.
2038         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
2039         method.
2040         (struct legacy_psymtab) <expand_psymtab>: Implement.
2041         <legacy_expand_psymtab>: New member.
2042         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
2043         (parse_partial_symbols): Set legacy_expand_psymtab.
2044         (psymtab_to_symtab_1): Change argument order.  Call
2045         expand_psymtab.
2046         (new_psymtab): Set legacy_expand_psymtab.
2047         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
2048         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
2049         expand_psymtab.
2050         (dwarf2_psymtab::expand_psymtab): Rename from
2051         psymtab_to_symtab_1.  Call expand_psymtab.
2052         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
2053         (dbx_end_psymtab): Likewise.
2054         (dbx_psymtab_to_symtab_1): Change argument order. Call
2055         expand_psymtab.
2056         (dbx_read_symtab): Call expand_psymtab.
2057         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
2058         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
2059         (ctf_psymtab::read_symtab): Call expand_psymtab.
2060
2061 2020-01-26  Tom Tromey  <tom@tromey.com>
2062
2063         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
2064         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
2065         messages.
2066         * mdebugread.c (mdebug_read_symtab): Remove prints.
2067         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
2068         assert.
2069         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
2070
2071 2020-01-26  Tom Tromey  <tom@tromey.com>
2072
2073         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
2074         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
2075         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
2076         legacy_symtab.
2077         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
2078         * psymtab.c (psymtab_to_symtab): Call method.
2079         (dump_psymtab): Update.
2080         * psympriv.h (struct partial_symtab): Add virtual destructor.
2081         <read_symtab>: New method.
2082         (struct legacy_symtab): New.
2083         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
2084         (struct pst_map) <pst>: Now a legacy_psymtab.
2085         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
2086         (new_psymtab): Use legacy_psymtab.
2087         * dwarf2read.h (struct dwarf2_psymtab): New.
2088         (struct dwarf2_per_cu_data) <psymtab>: Use it.
2089         * dwarf2read.c (dwarf2_create_include_psymtab)
2090         (dwarf2_build_include_psymtabs, create_type_unit_group)
2091         (create_partial_symtab, process_psymtab_comp_unit_reader)
2092         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
2093         (set_partial_user): Use dwarf2_psymtab.
2094         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
2095         (psymtab_to_symtab_1, process_full_comp_unit)
2096         (process_full_type_unit, dwarf2_ranges_read)
2097         (dwarf2_get_pc_bounds, psymtab_include_file_name)
2098         (dwarf_decode_lines): Use dwarf2_psymtab.
2099         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
2100         (add_address_entry_worker, write_one_signatured_type)
2101         (recursively_count_psymbols, recursively_write_psymbols)
2102         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
2103         (write_debug_names): Likewise.
2104         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
2105         <pst>: Now a legacy_psymtab.
2106         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
2107         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
2108         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
2109         * ctfread.c (struct ctf_psymtab): New.
2110         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
2111         ctf_psymtab.
2112         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
2113         (create_partial_symtab): Return a ctf_psymtab.
2114         (scan_partial_symbols): Update.
2115
2116 2020-01-26  Tom Tromey  <tom@tromey.com>
2117
2118         * xcoffread.c (xcoff_start_psymtab): Use new.
2119         * psymtab.c (partial_symtab::partial_symtab): New constructor,
2120         renamed from start_psymtab_common.
2121         * psympriv.h (struct partial_symtab): Add new constructor.
2122         (start_psymtab_common): Don't declare.
2123         * mdebugread.c (parse_partial_symbols): Use new.
2124         * dwarf2read.c (create_partial_symtab): Use new.
2125         * dbxread.c (start_psymtab): Use new.
2126         * ctfread.c (create_partial_symtab): Use new.
2127
2128 2020-01-26  Tom Tromey  <tom@tromey.com>
2129
2130         * xcoffread.c (xcoff_end_psymtab): Use new.
2131         * psymtab.c (start_psymtab_common): Use new.
2132         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
2133         Update.
2134         * psympriv.h (struct partial_symtab): Add parameters to
2135         constructor.  Don't inline.
2136         (allocate_psymtab): Don't declare.
2137         * mdebugread.c (new_psymtab): Use new.
2138         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
2139         * dbxread.c (dbx_end_psymtab): Use new.
2140
2141 2020-01-26  Tom Tromey  <tom@tromey.com>
2142
2143         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
2144         allocate_psymtab.  Update documentation.
2145         * psymtab.c (psymtab_storage::install_psymtab): Rename from
2146         allocate_psymtab.  Do not use new.
2147         (allocate_psymtab): Use new.  Update.
2148
2149 2020-01-26  Tom Tromey  <tom@tromey.com>
2150
2151         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2152         * psymtab.c (psym_print_stats): Update.
2153         * psympriv.h (struct partial_symtab) <readin,
2154         psymtabs_addrmap_supported, anonymous>: Now bool.
2155         * mdebugread.c (psymtab_to_symtab_1): Update.
2156         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
2157         (build_type_psymtabs_reader, psymtab_to_symtab_1)
2158         (process_full_comp_unit, process_full_type_unit): Update.
2159         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2160         * ctfread.c (psymtab_to_symtab): Update.
2161
2162 2020-01-26  Tom Tromey  <tom@tromey.com>
2163
2164         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
2165         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
2166         * psymtab.c (psymtab_storage): Delete psymtabs.
2167         (psymtab_storage::allocate_psymtab): Use new.
2168         (psymtab_storage::discard_psymtab): Use delete.
2169         * psympriv.h (struct partial_symtab): Add constructor and
2170         initializers.
2171
2172 2020-01-26  Tom Tromey  <tom@tromey.com>
2173
2174         * machoread.c: Do not include psympriv.h.
2175
2176 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2177
2178         * NEWS: Mention the new option and the set/show commands.
2179
2180 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2181
2182         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
2183         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
2184         (validate_exec_file): New variables, enums, functions.
2185         (exec_file_locate_attach, print_section_info): Style the filenames.
2186         (_initialize_exec): Install show_exec_file_mismatch_command and
2187          set_exec_file_mismatch_command.
2188         * gdbcore.h (validate_exec_file): Declare.
2189         * infcmd.c (attach_command): Call validate_exec_file.
2190         * remote.c ( remote_target::remote_add_inferior): Likewise.
2191
2192 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * frame.c (find_frame_sal): Move call to get_next_frame into more
2195         inner scope.
2196         * inline-frame.c (inilne_state) <inline_state>: Update argument
2197         types.
2198         (inilne_state) <skipped_symbol>: Rename to...
2199         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
2200         (skip_inline_frames): Build vector of skipped symbols and use this
2201         to reate the inline_state.
2202         (inline_skipped_symbol): Add a comment and some assertions, fetch
2203         skipped symbol from the list.
2204
2205 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2206
2207         * buildsym.c (lte_is_less_than): Delete.
2208         (buildsym_compunit::end_symtab_with_blockvector): Create local
2209         lambda function to sort line table entries, and use
2210         std::stable_sort instead of std::sort.
2211         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
2212         markers when looking for a previous line.
2213
2214 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * dwarf2read.c (lnp_state_machine::record_line): Include
2217         end_sequence parameter in debug print out.  Record the line if we
2218         are at an end_sequence marker even if it's not the start of a
2219         statement.
2220         * symmisc.c (maintenance_print_one_line_table): Print end of
2221         sequence markers with 'END' not '0'.
2222
2223 2020-01-24  Pedro Alves  <palves@redhat.com>
2224
2225         PR gdb/25410
2226         * thread.c (scoped_restore_current_thread::restore): Use
2227         switch_to_inferior_no_thread.
2228         * exec.c: Include "progspace-and-thread.h".
2229         (add_target_sections, remove_target_sections):
2230         scoped_restore_current_pspace_and_thread instead of
2231         scoped_restore_current_thread.
2232         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
2233         and aspace to the inferior before calling clone_program_space.
2234         Remove stale comment.
2235
2236 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2237
2238         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
2239         (arm_netbsd_nat_target::fetch_registers): ...this.
2240         (arm_nbsd_nat_target::store_registers): Rename to...
2241         (arm_netbsd_nat_target::store_registers): ...this.
2242
2243 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2244
2245         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2246         register_t.
2247
2248 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2249
2250         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
2251         Update comment.
2252         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
2253         Likewise.
2254         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
2255         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
2256         the correct replacement (iterate_over_regset_sections).
2257         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
2258         Update comment.
2259
2260 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
2261
2262         PR gdb/23718
2263         * gdb/python/python.c (execute_gdb_command): Call
2264         async_enable_stdin in catch block.
2265
2266 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
2269         SWITCH_THRU_ALL_UIS.
2270
2271 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         PR tui/9765
2274         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
2275         comment, add extra parameter, and update to store previous symbol
2276         when appropriate.
2277         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
2278         add extra parameter.
2279         * tui/tui-disasm.c (tui_disassemble): Update header comment,
2280         remove unneeded parameter, add try/catch around gdb_print_insn,
2281         rewrite to add items to asm_lines vector.
2282         (tui_find_backward_disassembly_start_address): New function.
2283         (tui_find_disassembly_address): Updated throughout.
2284         (tui_disasm_window::set_contents): Update for changes to
2285         tui_disassemble.
2286         (tui_disasm_window::do_scroll_vertical): No need to adjust the
2287         number of lines to scroll.
2288
2289 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
2290
2291         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
2292         (SECT_OFF_DATA): Likewise.
2293         (SECT_OFF_RODATA): Likewise.
2294         (SECT_OFF_TEXT): Likewise.
2295         (SECT_OFF_BSS): Likewise.
2296         (struct objfile) <text_section_offset, data_section_offset>: New
2297         methods.
2298         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
2299         objfile::text_section_offset.
2300         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
2301         * coffread.c (coff_symtab_read): Likewise.
2302         (enter_linenos): Likewise.
2303         (process_coff_symbol): Likewise.
2304         * ctfread.c (get_objfile_text_range): Likewise.
2305         * dtrace-probe.c (dtrace_probe::get_relocated_address):
2306         Use objfile::data_section_offset.
2307         * dwarf2-frame.c (execute_cfa_program): Use
2308         objfile::text_section_offset.
2309         (dwarf2_frame_find_fde): Likewise.
2310         * dwarf2read.c (create_addrmap_from_index): Likewise.
2311         (create_addrmap_from_aranges): Likewise.
2312         (dw2_find_pc_sect_compunit_symtab): Likewise.
2313         (process_psymtab_comp_unit_reader): Likewise.
2314         (add_partial_symbol): Likewise.
2315         (add_partial_subprogram): Likewise.
2316         (process_full_comp_unit): Likewise.
2317         (read_file_scope): Likewise.
2318         (read_func_scope): Likewise.
2319         (read_lexical_block_scope): Likewise.
2320         (read_call_site_scope): Likewise.
2321         (dwarf2_rnglists_process): Likewise.
2322         (dwarf2_ranges_process): Likewise.
2323         (dwarf2_ranges_read): Likewise.
2324         (dwarf_decode_lines_1): Likewise.
2325         (new_symbol): Likewise.
2326         (dwarf2_fetch_die_loc_sect_off): Likewise.
2327         (dwarf2_per_cu_text_offset): Likewise.
2328         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
2329         * hppa-tdep.c (read_unwind_info): Likewise.
2330         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
2331         * psympriv.h (struct partial_symtab): Likewise.
2332         * psymtab.c (find_pc_sect_psymtab): Likewise.
2333         * solib-svr4.c (enable_break): Likewise.
2334         * stap-probe.c (relocate_address): Use
2335         objfile::data_section_offset.
2336         * xcoffread.c (enter_line_range): Use
2337         objfile::text_section_offset.
2338         (read_xcoff_symtab): Likewise.
2339
2340 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2341
2342         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
2343         declaration to narrower scopes.
2344
2345 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2346
2347         * darwin-nat.h (struct darwin_exception_msg, enum
2348         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
2349         Move up.
2350         (class darwin_nat_target) <wait_1, check_new_threads,
2351         decode_exception_message, decode_message, stop_inferior,
2352         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
2353         * darwin-nat.c (darwin_check_new_threads): Rename to...
2354         (darwin_nat_target::check_new_threads): ... this.
2355         (darwin_suspend_inferior_it): Remove.
2356         (darwin_decode_exception_message): Rename to...
2357         (darwin_nat_target::decode_exception_message): ... this.
2358         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
2359         (darwin_decode_message): Rename to...
2360         (darwin_nat_target::decode_message): ... this.
2361         (cancel_breakpoint): Rename to...
2362         (darwin_nat_target::cancel_breakpoint): ... this.
2363         (darwin_wait): Rename to...
2364         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
2365         instead of iterate_over_inferiors.
2366         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
2367         (darwin_stop_inferior): Rename to...
2368         (darwin_nat_target::stop_inferior): ... this.
2369         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
2370         (darwin_init_thread_list): Rename to...
2371         (darwin_nat_target::init_thread_list): ... this.
2372         (darwin_ptrace_him): Rename to...
2373         (darwin_nat_target::ptrace_him): ... this.
2374         (darwin_nat_target::create_inferior): Pass lambda function to
2375         fork_inferior.
2376         (darwin_nat_target::detach): Call stop_inferior instead of
2377         darwin_stop_inferior.
2378         * fork-inferior.h (fork_inferior): Change init_trace_fun
2379         parameter to gdb::function_view.
2380         * fork-inferior.c (fork_inferior): Likewise.
2381
2382 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
2383
2384         * i386-cygwin-tdep.c (core_process_module_section): Update.
2385         * windows-nat.c (struct lm_info_windows): Add text_offset.
2386         (windows_xfer_shared_libraries): Update.
2387         * windows-tdep.c (windows_xfer_shared_library):
2388         Add text_offset_cached argument.
2389         * windows-tdep.h (windows_xfer_shared_library): Update.
2390
2391 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2392
2393         * gdbarch.sh: Add declaration for _initialize_gdbarch.
2394
2395 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2396
2397         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
2398         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
2399         replace with range-based for.
2400         (gdbsim_interrupt_inferior): Remove.
2401         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
2402         with a range-based for.  Inline code from
2403         gdbsim_interrupt_inferior.
2404
2405 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2406
2407         * infrun.c (proceed): Fix indentation.
2408
2409 2020-01-21  Tom Tromey  <tromey@adacore.com>
2410
2411         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
2412         * python/python.c (python_extension_ops): Update.
2413         (gdbpy_colorize): New function.
2414         * python/lib/gdb/__init__.py (colorize): New function.
2415         * extension.h (ext_lang_colorize): Declare.
2416         * extension.c (ext_lang_colorize): New function.
2417         * extension-priv.h (struct extension_language_ops) <colorize>: New
2418         member.
2419         * cli/cli-style.c (_initialize_cli_style): Update help text.
2420
2421 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2422
2423         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
2424         <cond>: Change type to bool.
2425         (aarch64_displaced_step_b_cond): Update cond to use bool type.
2426         (aarch64_displaced_step_cb): Likewise.
2427         (aarch64_displaced_step_tb): Likewise.
2428
2429 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2430
2431         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
2432         output.
2433
2434 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2435
2436         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
2437         <pc_adjust>: Adjust the documentation.
2438         (aarch64_displaced_step_fixup): Check if PC really moved before
2439         adjusting it.
2440
2441 2020-01-19  Tom Tromey  <tom@tromey.com>
2442
2443         * disasm.c (~gdb_disassembler): New destructor.
2444         (gdb_buffered_insn_length): Call disassemble_free_target.
2445         * disasm.h (class gdb_disassembler): Declare destructor.  Use
2446         DISABLE_COPY_AND_ASSIGN.
2447
2448 2020-01-19  Tom Tromey  <tom@tromey.com>
2449
2450         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
2451         (die_reader_func_ftype): Remove.
2452         (cutu_reader): New class.
2453         (dw2_get_file_names_reader): Remove "data" parameter.
2454         (dw2_get_file_names): Use cutu_reader.
2455         (create_debug_type_hash_table): Update.
2456         (read_cutu_die_from_dwo): Update comment.
2457         (lookup_dwo_unit): Add dwo_name parameter.
2458         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
2459         die_reader_func_ftype and data parameters.
2460         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
2461         Remove die_reader_func_ftype and data parameters.
2462         (~cutu_reader): New; from init_cutu_and_read_dies.
2463         (cutu_reader::cutu_reader): Rename from
2464         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
2465         and data parameters.
2466         (init_cutu_and_read_dies_simple): Remove.
2467         (struct process_psymtab_comp_unit_data): Remove.
2468         (process_psymtab_comp_unit_reader): Remove data parameter; add
2469         want_partial_unit and pretend_language parameters.
2470         (process_psymtab_comp_unit): Use cutu_reader.
2471         (build_type_psymtabs_reader): Remove data parameter.
2472         (build_type_psymtabs_1): Use cutu_reader.
2473         (process_skeletonless_type_unit): Likewise.
2474         (load_partial_comp_unit_reader): Remove.
2475         (load_partial_comp_unit): Use cutu_reader.
2476         (load_full_comp_unit_reader): Remove.
2477         (load_full_comp_unit): Use cutu_reader.
2478         (struct create_dwo_cu_data): Remove.
2479         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
2480         dwo_unit parameters.
2481         (create_cus_hash_table): Use cutu_reader.
2482         (struct dwarf2_read_addr_index_data): Remove.
2483         (dwarf2_read_addr_index_reader): Remove.
2484         (dwarf2_read_addr_index): Use cutu_reader.
2485         (read_signatured_type_reader): Remove.
2486         (read_signatured_type): Use cutu_reader.
2487
2488 2020-01-19  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
2491         * tui/tui-wingeneral.h (class tui_suppress_output): New.
2492         (tui_wrefresh): Declare.
2493         * tui/tui-wingeneral.c (suppress_output): New global.
2494         (tui_suppress_output, ~tui_suppress_output): New constructor and
2495         destructor.
2496         (tui_wrefresh): New function.
2497         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
2498         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
2499         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
2500         method.
2501         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
2502         tui_wrefresh.
2503         (tui_data_window::no_refresh): New method.
2504         (tui_data_item_window::refresh_window): Call tui_wrefresh.
2505         (tui_reg_command): Use tui_suppress_output
2506         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
2507         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
2508         method.
2509         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
2510
2511 2020-01-19  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-winsource.c (tui_update_source_windows_with_line):
2514         Handle case where symtab is null.
2515
2516 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
2517
2518         * linux-fork.c (one_fork_p): Simplify.
2519
2520 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2521
2522         * top.c (struct qt_args): Remove.
2523         (kill_or_detach): Change return type to void, replace `void *`
2524         parameter with a proper one.
2525         (print_inferior_quit_action):  Likewise.
2526         (quit_confirm): Use range-based for loop to iterate over inferiors.
2527         (quit_force): Likewise.
2528
2529 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2530
2531         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
2532         `void *` parameter with proper parameters.
2533         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
2534         (print_one_inferior): Change return type to void, replace `void *`
2535         parameter with proper parameters.
2536         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
2537         inferiors.
2538         (get_other_inferior): Remove.
2539         (mi_cmd_remove_inferior): Use range-based loop to iterate over
2540         inferiors.
2541
2542 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2543
2544         * mi/mi-interp.c (report_initial_inferior): Remove.
2545         (mi_interp::init): Use range-based for to iterate over inferiors.
2546
2547 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2548
2549         * python/py-inferior.c (build_inferior_list): Remove.
2550         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
2551
2552 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
2553
2554         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
2555         (btrace_stitch_trace): Likewise.
2556         * charset.c (intermediate_encoding): Likewise (vaild).
2557         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
2558         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
2559         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
2560
2561 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
2562
2563         * windows-tdep.c (windows_get_tlb_type):
2564         Add rtl_user_process_parameters type.
2565
2566 2020-01-16  Pedro Alves  <palves@redhat.com>
2567             Norbert Lange  <nolange79@gmail.com>
2568
2569         PR build/24805
2570         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
2571         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
2572         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
2573         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
2574         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
2575         (ps_plog): Redeclare exported functions with default visibility.
2576
2577 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
2578
2579         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
2580         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
2581
2582 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
2583
2584         * infcmd.c (post_create_inferior): Use get_thread_regcache
2585         instead of get_current_regcache.
2586
2587 2020-01-14  Tom Tromey  <tom@tromey.com>
2588
2589         PR symtab/12535:
2590         * python/python.c (gdbpy_decode_line): Treat empty string the same
2591         as no argument.
2592
2593 2020-01-14  Tom Tromey  <tom@tromey.com>
2594
2595         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
2596
2597 2020-01-14  Tom Tromey  <tom@tromey.com>
2598
2599         * nat/linux-btrace.c: Don't include <config.h>.
2600         * nat/linux-ptrace.c: Don't include <config.h>.
2601         * nat/x86-linux-dregs.c: Don't include <config.h>.
2602
2603 2020-01-14  Tom Tromey  <tom@tromey.com>
2604
2605         * configure: Rebuild.
2606         * configure.ac: Move many checks to ../gdbsupport/common.m4.
2607
2608 2020-01-14  Tom Tromey  <tom@tromey.com>
2609
2610         * nat/x86-linux-dregs.c: Include configh.h.
2611         * nat/linux-ptrace.c: Include configh.h.
2612         * nat/linux-btrace.c: Include configh.h.
2613         * defs.h: Include config.h, bfd.h.
2614         * configure.ac: Don't source common.host.
2615         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
2616         * configure: Rebuild.
2617         * acinclude.m4: Update path.
2618         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
2619         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
2620         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
2621         (CLIBS): Add LIBSUPPORT.
2622         (CDEPS): Likewise.
2623         (COMMON_SFILES): Remove gdbsupport files.
2624         (HFILES_NO_SRCDIR): Likewise.
2625         (stamp-version): Update path to create-version.sh.
2626         (ALLDEPFILES): Remove gdbsupport files.
2627
2628 2020-01-14  Tom Tromey  <tom@tromey.com>
2629
2630         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
2631         USE_WIN32API when needed.
2632         * configure.ac (USE_WIN32API): Don't define.
2633         (WIN32LIBS): Use WIN32APILIBS.
2634         * configure: Rebuild.
2635
2636 2020-01-14  Tom Tromey  <tom@tromey.com>
2637
2638         * configure: Rebuild.
2639         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
2640
2641 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2642
2643         * skip.c (skip_function_command): Make skip w/o arguments use the
2644         name of the inlined function if pc is inside any inlined function.
2645
2646 2020-01-14  Luis Machado  <luis.machado@linaro.org>
2647
2648         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
2649         * infrun.c (resume_1): Likewise.
2650         (handle_inferior_event): Remove stale comment.
2651         * linux-nat.c (linux_nat_target::resume): Update comments.
2652         (save_stop_reason): Likewise.
2653         (linux_nat_filter_event): Likewise.
2654         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
2655
2656 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * elfread.c (record_minimal_symbol): Set section index to 0 for
2659         non-allocatable sections.
2660
2661
2662 2020-01-13  Ali Tamur <tamur@google.com>
2663
2664         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
2665         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
2666         to gdb::optional.  Update comments.
2667         (dwo_file): Update comments.
2668         (read_attribute): Update API to take an additional out parameter,
2669         need_reprocess.  This is used to mark attributes that need other
2670         attributes (e.g. str_offsets_base) for correct computation which may not
2671         have been read yet.
2672         (read_attribute_reprocess): New function declaration.
2673         (read_addr_index): Likewise.
2674         (read_dwo_str_index): Likewise.
2675         (read_stub_str_index): Likewise.
2676         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
2677         (lookup_addr_base): New function definition.
2678         (lookup_ranges_base): Likewise.
2679         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
2680         lookup_ranges_base.
2681         (init_cutu_and_read_dies): Update comments.
2682         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
2683         unit.  This is used to inherit parent's str_offsets_base and addr_base.
2684         Update comments.
2685         (init_cutu_and_read_dies_simple): Reflect API changes.
2686         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
2687         (create_cus_hash_table): Change API to take parent compile unit.
2688         Reflect API changes.
2689         (open_and_init_dwo_file): Reflect API changes.
2690         (dwarf2_get_pc_bounds): Update comments.
2691         (dwarf2_record_block_ranges): Likewise.
2692         (read_full_die_1): Change implementation to reprocess attributes that
2693         need str_offsets_base and addr_base.
2694         (partial_die_info::read): Likewise.
2695         (read_attribute_reprocess): New function definition.
2696         (read_attribute_value): Change API to take an additional out parameter,
2697         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
2698         when a non-dwo compile unit has index based attributes.
2699         (read_attribute): Reflect API changes.
2700         (read_addr_index_1): Reflect API changes.  Update comments.
2701         (dwarf2_read_addr_index_data): Reflect API changes.
2702         (dwarf2_read_addr_index): Likewise.
2703         (read_str_index): Change API and implementation.  This becomes a helper
2704         to be used by the new string index related methods.  Update error
2705         message and comments.
2706         (read_dwo_str_index): New function definition.
2707         (read_stub_str_index): Likewise.
2708         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
2709         * symfile.h (dwarf2_debug_sections): Likewise.
2710         * xcoffread.c (dwarf2_debug_sections): Likewise.
2711
2712 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2713
2714         * gdbcore.h (struct core_fns) <core_read_registers>: Change
2715         core_reg_sect type to gdb_byte *.
2716         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
2717         * cris-tdep.c (fetch_core_registers): Likewise.
2718         * corelow.c (core_target::get_core_register_section): Change
2719         type of `contents` to gdb::byte_vector.
2720
2721 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2722
2723         * tui/tui-wingeneral.c (box_win): Position the title in the center
2724         of the border.
2725
2726 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2727
2728         * corelow.c (core_target::get_core_register_section): Use
2729           std::vector instead of alloca.
2730
2731 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2732
2733         * warning.m4: Add -Wmissing-declarations to build_warnings.
2734         * configure: Re-generate.
2735
2736 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2737
2738         * python/python.c (init__gdb_module): Add declaration.
2739
2740 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2741
2742         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
2743         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
2744         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
2745         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
2746         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
2747         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
2748         * ada-exp.y (_initialize_ada_exp): Add declaration.
2749         * ada-lang.c (_initialize_ada_language): Add declaration.
2750         * ada-tasks.c (_initialize_tasks): Add declaration.
2751         * agent.c (_initialize_agent): Add declaration.
2752         * aix-thread.c (_initialize_aix_thread): Add declaration.
2753         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
2754         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
2755         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
2756         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
2757         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
2758         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
2759         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
2760         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
2761         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
2762         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
2763         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
2764         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
2765         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
2766         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
2767         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
2768         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
2769         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
2770         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
2771         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
2772         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
2773         * annotate.c (_initialize_annotate): Add declaration.
2774         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
2775         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
2776         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
2777         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
2778         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
2779         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
2780         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
2781         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
2782         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
2783         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
2784         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
2785         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
2786         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
2787         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
2788         * auto-load.c (_initialize_auto_load): Add declaration.
2789         * auxv.c (_initialize_auxv): Add declaration.
2790         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
2791         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
2792         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
2793         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
2794         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
2795         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
2796         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
2797         * breakpoint.c (_initialize_breakpoint): Add declaration.
2798         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
2799         * btrace.c (_initialize_btrace): Add declaration.
2800         * charset.c (_initialize_charset): Add declaration.
2801         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
2802         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
2803         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
2804         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
2805         * cli/cli-script.c (_initialize_cli_script): Add declaration.
2806         * cli/cli-style.c (_initialize_cli_style): Add declaration.
2807         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
2808         * coffread.c (_initialize_coffread): Add declaration.
2809         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
2810         * compile/compile.c (_initialize_compile): Add declaration.
2811         * complaints.c (_initialize_complaints): Add declaration.
2812         * completer.c (_initialize_completer): Add declaration.
2813         * copying.c (_initialize_copying): Add declaration.
2814         * corefile.c (_initialize_core): Add declaration.
2815         * corelow.c (_initialize_corelow): Add declaration.
2816         * cp-abi.c (_initialize_cp_abi): Add declaration.
2817         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
2818         * cp-support.c (_initialize_cp_support): Add declaration.
2819         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
2820         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
2821         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
2822         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
2823         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
2824         * ctfread.c (_initialize_ctfread): Add declaration.
2825         * d-lang.c (_initialize_d_language): Add declaration.
2826         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
2827         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
2828         * dbxread.c (_initialize_dbxread): Add declaration.
2829         * dcache.c (_initialize_dcache): Add declaration.
2830         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
2831         * disasm.c (_initialize_disasm): Add declaration.
2832         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
2833         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
2834         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
2835         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
2836         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
2837         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
2838         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
2839         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
2840         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
2841         * elfread.c (_initialize_elfread): Add declaration.
2842         * exec.c (_initialize_exec): Add declaration.
2843         * extension.c (_initialize_extension): Add declaration.
2844         * f-lang.c (_initialize_f_language): Add declaration.
2845         * f-valprint.c (_initialize_f_valprint): Add declaration.
2846         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
2847         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
2848         * filesystem.c (_initialize_filesystem): Add declaration.
2849         * findcmd.c (_initialize_mem_search): Add declaration.
2850         * findvar.c (_initialize_findvar): Add declaration.
2851         * fork-child.c (_initialize_fork_child): Add declaration.
2852         * frame-base.c (_initialize_frame_base): Add declaration.
2853         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
2854         * frame.c (_initialize_frame): Add declaration.
2855         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
2856         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
2857         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
2858         * gcore.c (_initialize_gcore): Add declaration.
2859         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
2860         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
2861         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
2862         * gdbarch.c (_initialize_gdbarch): Add declaration.
2863         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
2864         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
2865         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
2866         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
2867         * go-lang.c (_initialize_go_language): Add declaration.
2868         * go32-nat.c (_initialize_go32_nat): Add declaration.
2869         * guile/guile.c (_initialize_guile): Add declaration.
2870         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
2871         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
2872         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
2873         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
2874         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
2875         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
2876         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
2877         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
2878         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
2879         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
2880         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
2881         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
2882         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
2883         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
2884         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
2885         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
2886         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
2887         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
2888         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
2889         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
2890         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
2891         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
2892         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
2893         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
2894         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
2895         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
2896         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
2897         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
2898         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
2899         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
2900         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
2901         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
2902         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
2903         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
2904         * infcall.c (_initialize_infcall): Add declaration.
2905         * infcmd.c (_initialize_infcmd): Add declaration.
2906         * inflow.c (_initialize_inflow): Add declaration.
2907         * infrun.c (_initialize_infrun): Add declaration.
2908         * interps.c (_initialize_interpreter): Add declaration.
2909         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
2910         * jit.c (_initialize_jit): Add declaration.
2911         * language.c (_initialize_language): Add declaration.
2912         * linux-fork.c (_initialize_linux_fork): Add declaration.
2913         * linux-nat.c (_initialize_linux_nat): Add declaration.
2914         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
2915         * linux-thread-db.c (_initialize_thread_db): Add declaration.
2916         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
2917         * m2-lang.c (_initialize_m2_language): Add declaration.
2918         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
2919         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
2920         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
2921         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
2922         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
2923         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
2924         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
2925         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
2926         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
2927         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
2928         * machoread.c (_initialize_machoread): Add declaration.
2929         * macrocmd.c (_initialize_macrocmd): Add declaration.
2930         * macroscope.c (_initialize_macroscope): Add declaration.
2931         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
2932         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
2933         * maint.c (_initialize_maint_cmds): Add declaration.
2934         * mdebugread.c (_initialize_mdebugread): Add declaration.
2935         * memattr.c (_initialize_mem): Add declaration.
2936         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
2937         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
2938         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
2939         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
2940         * mi/mi-main.c (_initialize_mi_main): Add declaration.
2941         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
2942         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
2943         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
2944         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
2945         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
2946         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
2947         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
2948         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
2949         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
2950         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
2951         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
2952         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
2953         * mipsread.c (_initialize_mipsread): Add declaration.
2954         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
2955         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
2956         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
2957         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
2958         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
2959         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
2960         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
2961         * nto-procfs.c (_initialize_procfs): Add declaration.
2962         * objc-lang.c (_initialize_objc_language): Add declaration.
2963         * observable.c (_initialize_observer): Add declaration.
2964         * opencl-lang.c (_initialize_opencl_language): Add declaration.
2965         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
2966         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
2967         * osabi.c (_initialize_gdb_osabi): Add declaration.
2968         * osdata.c (_initialize_osdata): Add declaration.
2969         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
2970         * parse.c (_initialize_parse): Add declaration.
2971         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
2972         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
2973         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
2974         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
2975         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
2976         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
2977         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
2978         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
2979         * printcmd.c (_initialize_printcmd): Add declaration.
2980         * probe.c (_initialize_probe): Add declaration.
2981         * proc-api.c (_initialize_proc_api): Add declaration.
2982         * proc-events.c (_initialize_proc_events): Add declaration.
2983         * proc-service.c (_initialize_proc_service): Add declaration.
2984         * procfs.c (_initialize_procfs): Add declaration.
2985         * producer.c (_initialize_producer): Add declaration.
2986         * psymtab.c (_initialize_psymtab): Add declaration.
2987         * python/python.c (_initialize_python): Add declaration.
2988         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
2989         * record-btrace.c (_initialize_record_btrace): Add declaration.
2990         * record-full.c (_initialize_record_full): Add declaration.
2991         * record.c (_initialize_record): Add declaration.
2992         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
2993         * regcache.c (_initialize_regcache): Add declaration.
2994         * reggroups.c (_initialize_reggroup): Add declaration.
2995         * remote-notif.c (_initialize_notif): Add declaration.
2996         * remote-sim.c (_initialize_remote_sim): Add declaration.
2997         * remote.c (_initialize_remote): Add declaration.
2998         * reverse.c (_initialize_reverse): Add declaration.
2999         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
3000         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
3001         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
3002         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
3003         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
3004         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
3005         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
3006         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
3007         Add declaration.
3008         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
3009         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
3010         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
3011         * rust-exp.y (_initialize_rust_exp): Add declaration.
3012         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
3013         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
3014         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
3015         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
3016         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
3017         * score-tdep.c (_initialize_score_tdep): Add declaration.
3018         * ser-go32.c (_initialize_ser_dos): Add declaration.
3019         * ser-mingw.c (_initialize_ser_windows): Add declaration.
3020         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
3021         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
3022         * ser-uds.c (_initialize_ser_socket): Add declaration.
3023         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
3024         * serial.c (_initialize_serial): Add declaration.
3025         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
3026         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
3027         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
3028         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
3029         * skip.c (_initialize_step_skip): Add declaration.
3030         * sol-thread.c (_initialize_sol_thread): Add declaration.
3031         * solib-aix.c (_initialize_solib_aix): Add declaration.
3032         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
3033         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
3034         * solib-frv.c (_initialize_frv_solib): Add declaration.
3035         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
3036         * solib-target.c (_initialize_solib_target): Add declaration.
3037         * solib.c (_initialize_solib): Add declaration.
3038         * source-cache.c (_initialize_source_cache): Add declaration.
3039         * source.c (_initialize_source): Add declaration.
3040         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
3041         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
3042         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
3043         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
3044         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
3045         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
3046         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
3047         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
3048         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
3049         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
3050         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
3051         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
3052         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
3053         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
3054         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
3055         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
3056         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
3057         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
3058         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
3059         * stabsread.c (_initialize_stabsread): Add declaration.
3060         * stack.c (_initialize_stack): Add declaration.
3061         * stap-probe.c (_initialize_stap_probe): Add declaration.
3062         * std-regs.c (_initialize_frame_reg): Add declaration.
3063         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
3064         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
3065         * symfile.c (_initialize_symfile): Add declaration.
3066         * symmisc.c (_initialize_symmisc): Add declaration.
3067         * symtab.c (_initialize_symtab): Add declaration.
3068         * target.c (_initialize_target): Add declaration.
3069         * target-connection.c (_initialize_target_connection): Add
3070         declaration.
3071         * target-dcache.c (_initialize_target_dcache): Add declaration.
3072         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
3073         * thread.c (_initialize_thread): Add declaration.
3074         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
3075         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
3076         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
3077         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
3078         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
3079         * tracectf.c (_initialize_ctf): Add declaration.
3080         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
3081         * tracefile.c (_initialize_tracefile): Add declaration.
3082         * tracepoint.c (_initialize_tracepoint): Add declaration.
3083         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
3084         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
3085         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
3086         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
3087         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
3088         * tui/tui-win.c (_initialize_tui_win): Add declaration.
3089         * tui/tui.c (_initialize_tui): Add declaration.
3090         * typeprint.c (_initialize_typeprint): Add declaration.
3091         * ui-style.c (_initialize_ui_style): Add declaration.
3092         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
3093         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
3094         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
3095         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
3096         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
3097         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
3098         * unittests/filtered_iterator-selftests.c
3099         (_initialize_filtered_iterator_selftests): Add declaration.
3100         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
3101         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
3102         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
3103         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
3104         * unittests/main-thread-selftests.c
3105         (_initialize_main_thread_selftests): Add declaration.
3106         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
3107         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
3108         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
3109         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
3110         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
3111         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
3112         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
3113         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
3114         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
3115         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
3116         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
3117         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
3118         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
3119         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
3120         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
3121         declaration.
3122         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
3123         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
3124         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
3125         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
3126         * user-regs.c (_initialize_user_regs): Add declaration.
3127         * utils.c (_initialize_utils): Add declaration.
3128         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
3129         * valops.c (_initialize_valops): Add declaration.
3130         * valprint.c (_initialize_valprint): Add declaration.
3131         * value.c (_initialize_values): Add declaration.
3132         * varobj.c (_initialize_varobj): Add declaration.
3133         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
3134         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
3135         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
3136         * windows-nat.c (_initialize_windows_nat): Add declaration.
3137         (_initialize_check_for_gdb_ini): Add declaration.
3138         (_initialize_loadable): Add declaration.
3139         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
3140         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
3141         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
3142         * xcoffread.c (_initialize_xcoffread): Add declaration.
3143         * xml-support.c (_initialize_xml_support): Add declaration.
3144         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
3145         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
3146         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
3147         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
3148
3149 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3150
3151         * regformats/regdat.sh: Generate declaration for init function.
3152
3153 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3154
3155         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
3156         up.
3157         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
3158         close_one_inferior>: New methods.
3159         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
3160         pass down target to find_inferior_pid.
3161         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
3162         Pass down target to find_inferior_ptid.
3163         (gdbsim_target::create_inferior): Pass down target to
3164         add_thread_silent.
3165         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
3166         target down to find_inferior_ptid and switch_to_thread.
3167         (gdbsim_target::close): Update to call close_one_inferior.
3168         (struct resume_data): Remove.
3169         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
3170         directly, rather than through a void pointer.
3171         (gdbsim_target::resume): Update to call resume_one_inferior.
3172
3173 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
3174
3175         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
3176
3177 2020-01-12  Pedro Alves  <palves@redhat.com>
3178
3179         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
3180         directly for the current inferior instead of
3181         discard_all_inferiors.
3182         (discard_all_inferiors): Delete.
3183
3184 2020-01-11  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-wingeneral.c (box_win): Check cli_styling.
3187         * tui/tui-winsource.c (tui_source_window_base::refill): Use
3188         deprecated_safe_get_selected_frame.
3189
3190 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3191
3192         * inferior.c (print_inferior): Switch inferior before printing it.
3193
3194 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
3195             Pedro Alves  <palves@redhat.com>
3196
3197         * progspace-and-thread.c (switch_to_program_space_and_thread):
3198         Assert there's an inferior for PSPACE.  Use
3199         switch_to_inferior_no_thread to switch the inferior too.
3200         * progspace.c (program_space::~program_space): Call
3201         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
3202         (program_space::free_all_objfiles): Don't call clear_symtab_users
3203         here.
3204         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
3205
3206 2020-01-10  Pedro Alves  <palves@redhat.com>
3207
3208         * NEWS: Mention multi-target debugging, "info connections", and
3209         "add-inferior -no-connection".
3210
3211 2020-01-10  Pedro Alves  <palves@redhat.com>
3212
3213         * infrun.c: Include "target-connection.h".
3214         (check_multi_target_resumption): New.
3215         (proceed): Call it.
3216         * target-connection.c (make_target_connection_string): Make
3217         extern.
3218         * target-connection.h (make_target_connection_string): Declare.
3219
3220 2020-01-10  Pedro Alves  <palves@redhat.com>
3221
3222         * Makefile.in (COMMON_SFILES): Add target-connection.c.
3223         * inferior.c (uiout_field_connection): New function.
3224         (print_inferior): Add new "connection-id" column.
3225         (add_inferior_command): Show connection number/string of added
3226         inferior.
3227         * process-stratum-target.h
3228         (process_stratum_target::connection_string): New virtual method.
3229         (process_stratum_target::connection_number): New field.
3230         * remote.c (remote_target::connection_string): New override.
3231         * target-connection.c: New file.
3232         * target-connection.h: New file.
3233         * target.c (decref_target): Remove process_stratum targets from
3234         the connection list.
3235         (target_stack::push): Add process_stratum targets to the
3236         connection list.
3237
3238 2020-01-10  Pedro Alves  <palves@redhat.com>
3239
3240         Revert:
3241         2016-04-12  Pedro Alves  <palves@redhat.com>
3242         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
3243         Remove references to name.
3244         * serial.h (struct serial) <name>: Delete.
3245
3246 2020-01-10  Pedro Alves  <palves@redhat.com>
3247
3248         * gdbarch-selftests.c (register_to_value_test): Remove "target
3249         already pushed" check.
3250
3251 2020-01-10  Pedro Alves  <palves@redhat.com>
3252             John Baldwin  <jhb@FreeBSD.org>
3253
3254         * aarch64-linux-nat.c
3255         (aarch64_linux_nat_target::thread_architecture): Adjust.
3256         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
3257         (task_command_1): Likewise.
3258         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
3259         (aix_thread_target::wait, aix_thread_target::fetch_registers)
3260         (aix_thread_target::store_registers)
3261         (aix_thread_target::thread_alive): Adjust.
3262         * amd64-fbsd-tdep.c: Include "inferior.h".
3263         (amd64fbsd_get_thread_local_address): Pass down target.
3264         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
3265         thread's gdbarch instead of target_gdbarch.
3266         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
3267         get_last_target_status.
3268         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
3269         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
3270         inferiors.
3271         (update_inserted_breakpoint_locations): Skip if inferiors with no
3272         execution.
3273         (update_global_location_list): When handling moribund locations,
3274         find representative inferior for location's pspace, and use thread
3275         count of its process_stratum target.
3276         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
3277         * bsd-uthread.c (bsd_uthread_target::wait): Use
3278         as_process_stratum_target and adjust thread_change_ptid and
3279         add_thread calls.
3280         (bsd_uthread_target::update_thread_list): Use
3281         as_process_stratum_target and adjust find_thread_ptid,
3282         thread_change_ptid and add_thread calls.
3283         * btrace.c (maint_btrace_packet_history_cmd): Adjust
3284         find_thread_ptid call.
3285         * corelow.c (add_to_thread_list): Adjust add_thread call.
3286         (core_target_open): Adjust add_thread_silent and thread_count
3287         calls.
3288         (core_target::pid_to_str): Adjust find_inferior_ptid call.
3289         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
3290         * event-top.c (async_disconnect): Pop targets from all inferiors.
3291         * exec.c (add_target_sections): Push exec target on all inferiors
3292         sharing the program space.
3293         (remove_target_sections): Remove the exec target from all
3294         inferiors sharing the program space.
3295         (exec_on_vfork): New.
3296         * exec.h (exec_on_vfork): Declare.
3297         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
3298         Pass it down.
3299         (fbsd_nat_target::update_thread_list): Adjust.
3300         (fbsd_nat_target::resume): Adjust.
3301         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
3302         down.
3303         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
3304         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
3305         get_thread_arch_regcache call.
3306         * fork-child.c (gdb_startup_inferior): Pass target down to
3307         startup_inferior and set_executing.
3308         * gdbthread.h (struct process_stratum_target): Forward declare.
3309         (add_thread, add_thread_silent, add_thread_with_info)
3310         (in_thread_list): Add process_stratum_target parameter.
3311         (find_thread_ptid(inferior*, ptid_t)): New overload.
3312         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
3313         parameter.
3314         (all_threads()): Delete overload.
3315         (all_threads, all_non_exited_threads): Add process_stratum_target
3316         parameter.
3317         (all_threads_safe): Use brace initialization.
3318         (thread_count): Add process_stratum_target parameter.
3319         (set_resumed, set_running, set_stop_requested, set_executing)
3320         (threads_are_executing, finish_thread_state): Add
3321         process_stratum_target parameter.
3322         (switch_to_thread): Use is_current_thread.
3323         * i386-fbsd-tdep.c: Include "inferior.h".
3324         (i386fbsd_get_thread_local_address): Pass down target.
3325         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
3326         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
3327         have_inferiors check.
3328         * inf-ptrace.c (inf_ptrace_target::create_inferior)
3329         (inf_ptrace_target::attach): Adjust.
3330         * infcall.c (run_inferior_call): Adjust.
3331         * infcmd.c (run_command_1): Pass target to
3332         scoped_finish_thread_state.
3333         (proceed_thread_callback): Skip inferiors with no execution.
3334         (continue_command): Rename 'all_threads' local to avoid hiding
3335         'all_threads' function.  Adjust get_last_target_status call.
3336         (prepare_one_step): Adjust set_running call.
3337         (signal_command): Use user_visible_resume_target.  Compare thread
3338         pointers instead of inferior_ptid.
3339         (info_program_command): Adjust to pass down target.
3340         (attach_command): Mark target's 'thread_executing' flag.
3341         (stop_current_target_threads_ns): New, factored out from ...
3342         (interrupt_target_1): ... this.  Switch inferior before making
3343         target calls.
3344         * inferior-iter.h
3345         (struct all_inferiors_iterator, struct all_inferiors_range)
3346         (struct all_inferiors_safe_range)
3347         (struct all_non_exited_inferiors_range): Filter on
3348         process_stratum_target too.  Remove explicit.
3349         * inferior.c (inferior::inferior): Push dummy target on target
3350         stack.
3351         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
3352         Add process_stratum_target parameter, and pass it down.
3353         (have_live_inferiors): Adjust.
3354         (switch_to_inferior_and_push_target): New.
3355         (add_inferior_command, clone_inferior_command): Handle
3356         "-no-connection" parameter.  Use
3357         switch_to_inferior_and_push_target.
3358         (_initialize_inferior): Mention "-no-connection" option in
3359         the help of "add-inferior" and "clone-inferior" commands.
3360         * inferior.h: Include "process-stratum-target.h".
3361         (interrupt_target_1): Use bool.
3362         (struct inferior) <push_target, unpush_target, target_is_pushed,
3363         find_target_beneath, top_target, process_target, target_at,
3364         m_stack>: New.
3365         (discard_all_inferiors): Delete.
3366         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
3367         (all_inferiors, all_non_exited_inferiors): Add
3368         process_stratum_target parameter.
3369         * infrun.c: Include "gdb_select.h" and <unordered_map>.
3370         (target_last_proc_target): New global.
3371         (follow_fork_inferior): Push target on new inferior.  Pass target
3372         to add_thread_silent.  Call exec_on_vfork.  Handle target's
3373         reference count.
3374         (follow_fork): Adjust get_last_target_status call.  Also consider
3375         target.
3376         (follow_exec): Push target on new inferior.
3377         (struct execution_control_state) <target>: New field.
3378         (user_visible_resume_target): New.
3379         (do_target_resume): Call target_async.
3380         (resume_1): Set target's threads_executing flag.  Consider resume
3381         target.
3382         (commit_resume_all_targets): New.
3383         (proceed): Also consider resume target.  Skip threads of inferiors
3384         with no execution.  Commit resumtion in all targets.
3385         (start_remote): Pass current inferior to wait_for_inferior.
3386         (infrun_thread_stop_requested): Consider target as well.  Pass
3387         thread_info pointer to clear_inline_frame_state instead of ptid.
3388         (infrun_thread_thread_exit): Consider target as well.
3389         (random_pending_event_thread): New inferior parameter.  Use it.
3390         (do_target_wait): Rename to ...
3391         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
3392         down.
3393         (threads_are_resumed_pending_p, do_target_wait): New.
3394         (prepare_for_detach): Adjust calls.
3395         (wait_for_inferior): New inferior parameter.  Handle it.  Use
3396         do_target_wait_1 instead of do_target_wait.
3397         (fetch_inferior_event): Adjust.  Switch to representative
3398         inferior.  Pass target down.
3399         (set_last_target_status): Add process_stratum_target parameter.
3400         Save target in global.
3401         (get_last_target_status): Add process_stratum_target parameter and
3402         handle it.
3403         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
3404         (context_switch): Check inferior_ptid == null_ptid before calling
3405         inferior_thread().
3406         (get_inferior_stop_soon): Pass down target.
3407         (wait_one): Rename to ...
3408         (poll_one_curr_target): ... this.
3409         (struct wait_one_event): New.
3410         (wait_one): New.
3411         (stop_all_threads): Adjust.
3412         (handle_no_resumed, handle_inferior_event): Adjust to consider the
3413         event's target.
3414         (switch_back_to_stepped_thread): Also consider target.
3415         (print_stop_event): Update.
3416         (normal_stop): Update.  Also consider the resume target.
3417         * infrun.h (wait_for_inferior): Remove declaration.
3418         (user_visible_resume_target): New declaration.
3419         (get_last_target_status, set_last_target_status): New
3420         process_stratum_target parameter.
3421         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3422         process_stratum_target parameter, and use it.
3423         (clear_inline_frame_state (thread_info*)): New.
3424         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3425         process_stratum_target parameter.
3426         (clear_inline_frame_state (thread_info*)): Declare.
3427         * linux-fork.c (delete_checkpoint_command): Pass target down to
3428         find_thread_ptid.
3429         (checkpoint_command): Adjust.
3430         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
3431         instead of just tweaking inferior_ptid.
3432         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
3433         (exit_lwp): Pass target down to find_thread_ptid.
3434         (attach_proc_task_lwp_callback): Pass target down to
3435         add_thread/set_running/set_executing.
3436         (linux_nat_target::attach): Pass target down to
3437         thread_change_ptid.
3438         (get_detach_signal): Pass target down to find_thread_ptid.
3439         Consider last target status's target.
3440         (linux_resume_one_lwp_throw, resume_lwp)
3441         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
3442         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
3443         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
3444         (linux_nat_target::async_wait_fd): New.
3445         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
3446         target down.
3447         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
3448         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
3449         * linux-thread-db.c (struct thread_db_info::process_target): New
3450         field.
3451         (add_thread_db_info): Save target.
3452         (get_thread_db_info): New process_stratum_target parameter.  Also
3453         match target.
3454         (delete_thread_db_info): New process_stratum_target parameter.
3455         Also match target.
3456         (thread_from_lwp): Adjust to pass down target.
3457         (thread_db_notice_clone): Pass down target.
3458         (check_thread_db_callback): Pass down target.
3459         (try_thread_db_load_1): Always push the thread_db target.
3460         (try_thread_db_load, record_thread): Pass target down.
3461         (thread_db_target::detach): Pass target down.  Always unpush the
3462         thread_db target.
3463         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
3464         target down.  Always unpush the thread_db target.
3465         (find_new_threads_callback, thread_db_find_new_threads_2)
3466         (thread_db_target::update_thread_list): Pass target down.
3467         (thread_db_target::pid_to_str): Pass current inferior down.
3468         (thread_db_target::get_thread_local_address): Pass target down.
3469         (thread_db_target::resume, maintenance_check_libthread_db): Pass
3470         target down.
3471         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
3472         * procfs.c (procfs_target::procfs_init_inferior): Declare.
3473         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
3474         (procfs_init_inferior): Rename to ...
3475         (procfs_target::procfs_init_inferior): ... this and adjust.
3476         (procfs_target::create_inferior, procfs_notice_thread)
3477         (procfs_do_thread_registers): Adjust.
3478         * ppc-fbsd-tdep.c: Include "inferior.h".
3479         (ppcfbsd_get_thread_local_address): Pass down target.
3480         * proc-service.c (ps_xfer_memory): Switch current inferior and
3481         program space as well.
3482         (get_ps_regcache): Pass target down.
3483         * process-stratum-target.c
3484         (process_stratum_target::thread_address_space)
3485         (process_stratum_target::thread_architecture): Pass target down.
3486         * process-stratum-target.h
3487         (process_stratum_target::threads_executing): New field.
3488         (as_process_stratum_target): New.
3489         * ravenscar-thread.c
3490         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
3491         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
3492         down.
3493         * record-btrace.c (record_btrace_target::info_record): Adjust.
3494         (record_btrace_target::record_method)
3495         (record_btrace_target::record_is_replaying)
3496         (record_btrace_target::fetch_registers)
3497         (get_thread_current_frame_id, record_btrace_target::resume)
3498         (record_btrace_target::wait, record_btrace_target::stop): Pass
3499         target down.
3500         * record-full.c (record_full_wait_1): Switch to event thread.
3501         Pass target down.
3502         * regcache.c (regcache::regcache)
3503         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
3504         process_stratum_target parameter and handle it.
3505         (current_thread_target): New global.
3506         (get_thread_regcache): Add process_stratum_target parameter and
3507         handle it.  Switch inferior before calling target method.
3508         (get_thread_regcache): Pass target down.
3509         (get_thread_regcache_for_ptid): Pass target down.
3510         (registers_changed_ptid): Add process_stratum_target parameter and
3511         handle it.
3512         (registers_changed_thread, registers_changed): Pass target down.
3513         (test_get_thread_arch_aspace_regcache): New.
3514         (current_regcache_test): Define a couple local test_target_ops
3515         instances and use them for testing.
3516         (readwrite_regcache): Pass process_stratum_target parameter.
3517         (cooked_read_test, cooked_write_test): Pass mock_target down.
3518         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
3519         (get_thread_arch_aspace_regcache): Add process_stratum_target
3520         parameter.
3521         (regcache::target): New method.
3522         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
3523         (regcache::registers_changed_ptid): Add process_stratum_target
3524         parameter.
3525         (regcache::m_target): New field.
3526         (registers_changed_ptid): Add process_stratum_target parameter.
3527         * remote.c (remote_state::supports_vCont_probed): New field.
3528         (remote_target::async_wait_fd): New method.
3529         (remote_unpush_and_throw): Add remote_target parameter.
3530         (get_current_remote_target): Adjust.
3531         (remote_target::remote_add_inferior): Push target.
3532         (remote_target::remote_add_thread)
3533         (remote_target::remote_notice_new_inferior)
3534         (get_remote_thread_info): Pass target down.
3535         (remote_target::update_thread_list): Skip threads of inferiors
3536         bound to other targets.  (remote_target::close): Don't discard
3537         inferiors.  (remote_target::add_current_inferior_and_thread)
3538         (remote_target::process_initial_stop_replies)
3539         (remote_target::start_remote)
3540         (remote_target::remote_serial_quit_handler): Pass down target.
3541         (remote_target::remote_unpush_target): New remote_target
3542         parameter.  Unpush the target from all inferiors.
3543         (remote_target::remote_unpush_and_throw): New remote_target
3544         parameter.  Pass it down.
3545         (remote_target::open_1): Check whether the current inferior has
3546         execution instead of checking whether any inferior is live.  Pass
3547         target down.
3548         (remote_target::remote_detach_1): Pass down target.  Use
3549         remote_unpush_target.
3550         (extended_remote_target::attach): Pass down target.
3551         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
3552         (remote_target::append_resumption): Pass down target.
3553         (remote_target::append_pending_thread_resumptions)
3554         (remote_target::remote_resume_with_hc, remote_target::resume)
3555         (remote_target::commit_resume): Pass down target.
3556         (remote_target::remote_stop_ns): Check supports_vCont_probed.
3557         (remote_target::interrupt_query)
3558         (remote_target::remove_new_fork_children)
3559         (remote_target::check_pending_events_prevent_wildcard_vcont)
3560         (remote_target::remote_parse_stop_reply)
3561         (remote_target::process_stop_reply): Pass down target.
3562         (first_remote_resumed_thread): New remote_target parameter.  Pass
3563         it down.
3564         (remote_target::wait_as): Pass down target.
3565         (unpush_and_perror): New remote_target parameter.  Pass it down.
3566         (remote_target::readchar, remote_target::remote_serial_write)
3567         (remote_target::getpkt_or_notif_sane_1)
3568         (remote_target::kill_new_fork_children, remote_target::kill): Pass
3569         down target.
3570         (remote_target::mourn_inferior): Pass down target.  Use
3571         remote_unpush_target.
3572         (remote_target::core_of_thread)
3573         (remote_target::remote_btrace_maybe_reopen): Pass down target.
3574         (remote_target::pid_to_exec_file)
3575         (remote_target::thread_handle_to_thread_info): Pass down target.
3576         (remote_target::async_wait_fd): New.
3577         * riscv-fbsd-tdep.c: Include "inferior.h".
3578         (riscv_fbsd_get_thread_local_address): Pass down target.
3579         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
3580         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
3581         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
3582         Adjust.
3583         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
3584         * solib-svr4.c (enable_break): Pass down target.
3585         * spu-multiarch.c (parse_spufs_run): Pass down target.
3586         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
3587         * target-delegates.c: Regenerate.
3588         * target.c (g_target_stack): Delete.
3589         (current_top_target): Return the current inferior's top target.
3590         (target_has_execution_1): Refer to the passed-in inferior's top
3591         target.
3592         (target_supports_terminal_ours): Check whether the initial
3593         inferior was already created.
3594         (decref_target): New.
3595         (target_stack::push): Incref/decref the target.
3596         (push_target, push_target, unpush_target): Adjust.
3597         (target_stack::unpush): Defref target.
3598         (target_is_pushed): Return bool.  Adjust to refer to the current
3599         inferior's target stack.
3600         (dispose_inferior): Delete, and inline parts ...
3601         (target_preopen): ... here.  Only dispose of the current inferior.
3602         (target_detach): Hold strong target reference while detaching.
3603         Pass target down.
3604         (target_thread_name): Add assertion.
3605         (target_resume): Pass down target.
3606         (target_ops::beneath, find_target_at): Adjust to refer to the
3607         current inferior's target stack.
3608         (get_dummy_target): New.
3609         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
3610         has a thread running.
3611         (initialize_targets): Rename to ...
3612         (_initialize_target): ... this.
3613         * target.h: Include "gdbsupport/refcounted-object.h".
3614         (struct target_ops): Inherit refcounted_object.
3615         (target_ops::shortname, target_ops::longname): Make const.
3616         (target_ops::async_wait_fd): New method.
3617         (decref_target): Declare.
3618         (struct target_ops_ref_policy): New.
3619         (target_ops_ref): New typedef.
3620         (get_dummy_target): Declare function.
3621         (target_is_pushed): Return bool.
3622         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
3623         (all_matching_threads_iterator::all_matching_threads_iterator):
3624         Handle filter target.
3625         * thread-iter.h (struct all_matching_threads_iterator, struct
3626         all_matching_threads_range, class all_non_exited_threads_range):
3627         Filter by target too.  Remove explicit.
3628         * thread.c (threads_executing): Delete.
3629         (inferior_thread): Pass down current inferior.
3630         (clear_thread_inferior_resources): Pass down thread pointer
3631         instead of ptid_t.
3632         (add_thread_silent, add_thread_with_info, add_thread): Add
3633         process_stratum_target parameter.  Use it for thread and inferior
3634         searches.
3635         (is_current_thread): New.
3636         (thread_info::deletable): Use it.
3637         (find_thread_ptid, thread_count, in_thread_list)
3638         (thread_change_ptid, set_resumed, set_running): New
3639         process_stratum_target parameter.  Pass it down.
3640         (set_executing): New process_stratum_target parameter.  Pass it
3641         down.  Adjust reference to 'threads_executing'.
3642         (threads_are_executing): New process_stratum_target parameter.
3643         Adjust reference to 'threads_executing'.
3644         (set_stop_requested, finish_thread_state): New
3645         process_stratum_target parameter.  Pass it down.
3646         (switch_to_thread): Also match inferior.
3647         (switch_to_thread): New process_stratum_target parameter.  Pass it
3648         down.
3649         (update_threads_executing): Reimplement.
3650         * top.c (quit_force): Pop targets from all inferior.
3651         (gdb_init): Don't call initialize_targets.
3652         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
3653         Declare.
3654         (windows_add_thread, windows_delete_thread): Adjust.
3655         (get_windows_debug_event): Rename to ...
3656         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
3657         * tracefile-tfile.c (tfile_target_open): Pass down target.
3658         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
3659         Forward declare.
3660         (switch_to_thread): Add process_stratum_target parameter.
3661         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
3662         parameter.  Use it.
3663         (mi_on_resume): Pass target down.
3664         * nat/fork-inferior.c (startup_inferior): Add
3665         process_stratum_target parameter.  Pass it down.
3666         * nat/fork-inferior.h (startup_inferior): Add
3667         process_stratum_target parameter.
3668         * python/py-threadevent.c (py_get_event_thread): Pass target down.
3669
3670 2020-01-10  Pedro Alves  <palves@redhat.com>
3671
3672         * remote.c (remote_target::start_remote): Don't set inferior_ptid
3673         directly.  Instead find the first thread in the thread list and
3674         use switch_to_thread.
3675
3676 2020-01-10  Pedro Alves  <palves@redhat.com>
3677
3678         * remote.c (remote_target::remote_add_inferior): Don't bind a
3679         process to the current inferior if the current inferior is already
3680         bound to a process.
3681
3682 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3683             Pedro Alves  <palves@redhat.com>
3684
3685         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
3686         If no process is specified, return null_ptid instead of
3687         inferior_ptid.
3688         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
3689         TARGET_WAITKIND_SIGNALLED with no pid.
3690
3691 2020-01-10  Pedro Alves  <palves@redhat.com>
3692
3693         * remote.c (first_remote_resumed_thread): New.
3694         (remote_target::wait_as): Use it as default event_ptid instead of
3695         inferior_ptid.
3696
3697 2020-01-10  Pedro Alves  <palves@redhat.com>
3698
3699         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
3700
3701 2020-01-10  Pedro Alves  <palves@redhat.com>
3702
3703         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
3704         not -1.
3705
3706 2020-01-10  Pedro Alves  <palves@redhat.com>
3707
3708         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
3709         ptid to get_last_target_status.
3710         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
3711         ptid to get_last_target_status.
3712         * infcmd.c (continue_command): Don't pass a target_waitstatus to
3713         get_last_target_status.
3714         (info_program_command): Don't pass a target_waitstatus to
3715         get_last_target_status.
3716         * infrun.c (init_wait_for_inferior): Use
3717         nullify_last_target_wait_ptid.
3718         (get_last_target_status): Handle nullptr arguments.
3719         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
3720         (print_stop_event): Don't pass a ptid to get_last_target_status.
3721         (normal_stop): Don't pass a ptid to get_last_target_status.
3722         * infrun.h (get_last_target_status, set_last_target_status): Move
3723         comments here and update.
3724         (nullify_last_target_wait_ptid): Declare.
3725         * linux-fork.c (fork_load_infrun_state): Remove local extern
3726         declaration of nullify_last_target_wait_ptid.
3727         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
3728         to get_last_target_status.
3729
3730 2020-01-10  Pedro Alves  <palves@redhat.com>
3731
3732         * gdbthread.h (scoped_restore_current_thread)
3733         <dont_restore, restore, m_dont_restore>: Declare.
3734         * thread.c (thread_alive): Add assertion.  Return bool.
3735         (switch_to_thread_if_alive): New.
3736         (prune_threads): Switch inferior/thread.
3737         (print_thread_info_1): Switch thread before calling target methods.
3738         (scoped_restore_current_thread::restore): New, factored out from
3739         ...
3740         (scoped_restore_current_thread::~scoped_restore_current_thread):
3741         ... this.
3742         (scoped_restore_current_thread::scoped_restore_current_thread):
3743         Add assertion.
3744         (thread_apply_all_command, thread_select): Use
3745         switch_to_thread_if_alive.
3746         * infrun.c (proceed, restart_threads, handle_signal_stop)
3747         (switch_back_to_stepped_thread): Switch current thread before
3748         calling target methods.
3749
3750 2020-01-10  Pedro Alves <palves@redhat.com>
3751
3752         * inferior.c (switch_to_inferior_no_thread): New function,
3753         factored out from ...
3754         (inferior_command): ... here.
3755         * inferior.h (switch_to_inferior_no_thread): Declare.
3756         * mi/mi-main.c (run_one_inferior): Use
3757         switch_to_inferior_no_thread.
3758
3759 2020-01-10  Pedro Alves  <palves@redhat.com>
3760
3761         * infcmd.c (kill_command): Remove dead code.
3762
3763 2020-01-10  Pedro Alves  <palves@redhat.com>
3764
3765         * remote.c (remote_target::mourn_inferior): No longer check
3766         whether the target is running.
3767
3768 2020-01-10  Pedro Alves  <palves@redhat.com>
3769
3770         * corelow.c (core_target::has_execution): Change parameter type to
3771         inferior pointer.
3772         * inferior.c (number_of_live_inferiors): Use
3773         inferior::has_execution instead of target_has_execution_1.
3774         * inferior.h (inferior::has_execution): New.
3775         * linux-thread-db.c (thread_db_target::update_thread_list): Use
3776         inferior::has_execution instead of target_has_execution_1.
3777         * process-stratum-target.c
3778         (process_stratum_target::has_execution): Change parameter type to
3779         inferior pointer.  Check the inferior's PID instead of
3780         inferior_ptid.
3781         * process-stratum-target.h
3782         (process_stratum_target::has_execution): Change parameter type to
3783         inferior pointer.
3784         * record-full.c (record_full_core_target::has_execution): Change
3785         parameter type to inferior pointer.
3786         * target.c (target_has_execution_1): Change parameter type to
3787         inferior pointer.
3788         (target_has_execution_current): Adjust.
3789         * target.h (target_ops::has_execution): Change parameter type to
3790         inferior pointer.
3791         (target_has_execution_1): Change parameter type to inferior
3792         pointer.  Change return type to bool.
3793         * tracefile.h (tracefile_target::has_execution): Change parameter
3794         type to inferior pointer.
3795
3796 2020-01-10  Pedro Alves  <palves@redhat.com>
3797
3798         * exceptions.c (print_flush): Remove current_top_target() check.
3799
3800 2020-01-10  Pedro Alves  <palves@redhat.com>
3801
3802         * remote.c (show_remote_exec_file): Show the current inferior's
3803         exec-file instead of the command variable's value.
3804
3805 2020-01-10  Pedro Alves  <palves@redhat.com>
3806
3807         * record-full.c (record_full_resume_ptid): New global.
3808         (record_full_target::resume): Set it.
3809         (record_full_wait_1): Use record_full_resume_ptid instead of
3810         inferior_ptid.
3811
3812 2020-01-10  Pedro Alves  <palves@redhat.com>
3813
3814         * gdbthread.h (scoped_restore_current_thread)
3815         <dont_restore, restore, m_dont_restore>: Declare.
3816         * thread.c (thread_alive): Add assertion.  Return bool.
3817         (switch_to_thread_if_alive): New.
3818         (prune_threads): Switch inferior/thread.
3819         (print_thread_info_1): Switch thread before calling target methods.
3820         (scoped_restore_current_thread::restore): New, factored out from
3821         ...
3822         (scoped_restore_current_thread::~scoped_restore_current_thread):
3823         ... this.
3824         (scoped_restore_current_thread::scoped_restore_current_thread):
3825         Add assertion.
3826         (thread_apply_all_command, thread_select): Use
3827         switch_to_thread_if_alive.
3828
3829 2020-01-10  George Barrett  <bob@bob131.so>
3830
3831         * stap-probe.c (stap_modify_semaphore): Don't check for null
3832         semaphores.
3833         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
3834         for null semaphores.
3835
3836 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
3839         all source windows, and maintain horizontal scroll status while
3840         doing so.
3841
3842 2020-01-09  Tom Tromey  <tom@tromey.com>
3843
3844         PR tui/18932:
3845         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
3846         update_source_window, not print_source_lines.
3847
3848 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * tui/tui.c (tui_enable): Register tui hooks after calling
3851         tui_display_main.
3852
3853 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3854
3855         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
3856
3857 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
3858
3859         * thread.c (print_thread_info_1): Fix indentation.
3860
3861 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3862
3863         * symtab.c (general_symbol_info::compute_and_set_names): Move the
3864         unique_xmalloc_ptr outside the if to always free the demangled name.
3865
3866 2020-01-08  Tom Tromey  <tromey@adacore.com>
3867
3868         * xcoffread.c (enter_line_range, read_xcoff_symtab)
3869         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
3870         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
3871         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
3872         Remove.
3873         (section_offsets): New typedef.
3874         * symtab.c (fixup_section, get_msymbol_address): Update.
3875         * symmisc.c (dump_msymbols): Update.
3876         * symfile.h (relative_addr_info_to_section_offsets)
3877         (symfile_map_offsets_to_segments): Update.
3878         * symfile.c (build_section_addr_info_from_objfile)
3879         (init_objfile_sect_indices): Update.
3880         (struct place_section_arg): Change type of "offsets".
3881         (place_section): Update.
3882         (relative_addr_info_to_section_offsets): Change type of
3883         "section_offsets".  Remove "num_sections" parameter.
3884         (default_symfile_offsets, syms_from_objfile_1)
3885         (set_objfile_default_section_offset): Update.
3886         (reread_symbols): No need to preserve section offsets by hand.
3887         (symfile_map_offsets_to_segments): Change type of "offsets".
3888         * stap-probe.c (relocate_address): Update.
3889         * stabsread.h (process_one_symbol): Update.
3890         * solib-target.c (struct lm_info_target) <offsets>: Change type.
3891         (solib_target_relocate_section_addresses): Update.
3892         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
3893         Update.
3894         * solib-frv.c (frv_relocate_main_executable): Update.
3895         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
3896         * solib-aix.c (solib_aix_get_section_offsets): Change return
3897         type.
3898         (solib_aix_solib_create_inferior_hook): Update.
3899         * remote.c (remote_target::get_offsets): Update.
3900         * psymtab.c (find_pc_sect_psymtab): Update.
3901         * psympriv.h (struct partial_symbol) <address, text_low,
3902         text_high>: Update.
3903         * objfiles.h (obj_section_offset): Update.
3904         (struct objfile) <section_offsets>: Change type.
3905         <num_sections>: Remove.
3906         (objfile_relocate): Update.
3907         * objfiles.c (entry_point_address_query): Update
3908         (relocate_one_symbol): Change type of "section_offsets".
3909         (objfile_relocate1, objfile_relocate1): Change type of
3910         "new_offsets".
3911         (objfile_rebase1): Update.
3912         * mipsread.c (mipscoff_symfile_read): Update.
3913         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
3914         parameter.
3915         * mdebugread.c (parse_symbol): Change type of "section_offsets".
3916         (parse_external, psymtab_to_symtab_1): Update.
3917         * machoread.c (macho_symfile_offsets): Update.
3918         * ia64-tdep.c (ia64_find_unwind_table): Update.
3919         * hppa-tdep.c (read_unwind_info): Update.
3920         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
3921         * dwarf2read.c (create_addrmap_from_index)
3922         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3923         (process_psymtab_comp_unit_reader, add_partial_symbol)
3924         (add_partial_subprogram, process_full_comp_unit)
3925         (read_file_scope, read_func_scope, read_lexical_block_scope)
3926         (read_call_site_scope, dwarf2_rnglists_process)
3927         (dwarf2_ranges_process, dwarf2_ranges_read)
3928         (dwarf_decode_lines_1, var_decode_location, new_symbol)
3929         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
3930         Update.
3931         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
3932         Update.
3933         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
3934         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
3935         (process_one_symbol): Change type of "section_offsets".
3936         * ctfread.c (get_objfile_text_range): Update.
3937         * coffread.c (coff_symtab_read, enter_linenos)
3938         (process_coff_symbol): Update.
3939         * coff-pe-read.c (add_pe_forwarded_sym): Update.
3940         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
3941
3942 2020-01-08  Tom Tromey  <tromey@adacore.com>
3943
3944         * dwarf2read.c (parse_macro_definition): Use std::string.
3945         (parse_macro_definition): Likewise.
3946
3947 2020-01-08  Tom Tromey  <tromey@adacore.com>
3948
3949         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
3950         (ATTR_ALLOC_CHUNK): Remove.
3951
3952 2020-01-08  Tom Tromey  <tromey@adacore.com>
3953
3954         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
3955
3956 2020-01-08  Tom Tromey  <tromey@adacore.com>
3957
3958         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
3959         (dwarf2_compute_name, open_dwo_file): Likewise.
3960         (process_enumeration_scope): Use std::vector.
3961         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
3962         (partial_die_info::fixup, dwarf2_start_subfile)
3963         (guess_full_die_structure_name, dwarf2_name): Likewise.
3964         (determine_prefix): Update.
3965         (guess_full_die_structure_name): Make return type const.
3966         (partial_die_full_name): Return unique_xmalloc_ptr.
3967         (DW_FIELD_ALLOC_CHUNK): Remove.
3968
3969 2020-01-07  Tom Tromey  <tromey@adacore.com>
3970
3971         PR build/24937:
3972         * stap-probe.c (class stap_static_probe_ops): Add constructor.
3973
3974 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3975
3976         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
3977
3978 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * stack.c (print_frame_info): Move disassemble_next_line code
3981         inside source_print block.
3982
3983 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3984
3985         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
3986         gdb/signals.h, as we are now using native signal symbols.
3987
3988 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3989
3990         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
3991         overflow by an early check of content vs threshold.
3992         * tui/tui-source.c (tui_source_window::line_is_displayed):
3993         Likewise.
3994
3995 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3996
3997         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
3998
3999 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
4000
4001         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
4002         export table if no section contains it's RVA.
4003
4004 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4005
4006         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
4007
4008 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
4009
4010         * source.c (print_source_lines_base): Set last_line_listed.
4011
4012 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
4013
4014         * tui/tui-disasm.c: Remove trailing spaces.
4015
4016 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4017             Pedro Alves  <palves@redhat.com>
4018
4019         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
4020         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
4021         (windows_gdb_signal_to_target): New function, uses the above
4022         enumeration to convert GDB internal signal codes to equivalent
4023         Windows codes.
4024         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
4025         * windows-nat.c: Include "gdb_wait.h".
4026         (get_windows_debug_event): Extract the fatal exception from the
4027         exit status and convert to the equivalent Posix signal number.
4028         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
4029         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
4030         * gdbsupport/gdb_wait.c: New file, implements
4031         windows_status_to_termsig.
4032         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
4033         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
4034
4035 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4036
4037         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
4038         show_layout.
4039
4040 2020-01-05  Luis Machado  <luis.machado@linaro.org>
4041
4042         * aarch64-linux-nat.c
4043         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
4044         and bfd_mach_aarch64.
4045
4046 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4047
4048         * ui-file.c (stdio_file::can_emit_style_escape)
4049         (tee_file::can_emit_style_escape): Ensure style is used also on
4050         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
4051         to gdb_stdout.
4052         * main.c (set_gdb_data_directory): Use file style to output the
4053         warning that the given pathname is not a directory.
4054         * top.c (show_history_filename, gdb_safe_append_history)
4055         (show_gdb_datadir): Use file style.
4056
4057 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4058
4059         * solib-target.c (struct lm_info_target):
4060         Change offsets to be a unique_xmalloc_ptr.
4061         (solib_target_relocate_section_addresses): Update.
4062
4063 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4064
4065         * windows-nat.c (windows_clear_solib): Free so_list linked list.
4066
4067 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4068
4069         * MAINTAINERS (Write After Approval): Add myself.
4070
4071 2020-01-02  Luis Machado  <luis.machado@linaro.org>
4072
4073         * proc-service.c (get_ps_regcache): Remove reference to obsolete
4074         Cell BE architecture.
4075         * target.h (struct target_ops) <thread_architecture>: Likewise.
4076
4077 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4078
4079         * Makefile.in: Use INSTALL_PROGRAM_ENV.
4080
4081 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4082
4083         * MAINTAINERS (Write After Approval): Add myself.
4084
4085 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4086
4087         * gdbarch.sh: Update copyright year range of generated files.
4088
4089 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4090
4091         Update copyright year range in all GDB files.
4092
4093 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4094
4095         * copyright.py: Convert to Python 3.
4096
4097 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4098
4099         * copyright.py: Adapt after move of gnulib directory from gdb
4100         directory to toplevel directory.
4101
4102 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4103
4104         * copyright.py (main): Exit if run from the wrong directory.
4105
4106 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4107
4108         * top.c (print_gdb_version): Change copyright year to 2020.
4109
4110 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4111
4112         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
4113
4114 For older changes see ChangeLog-2019.
4115 \f
4116 Local Variables:
4117 mode: change-log
4118 left-margin: 8
4119 fill-column: 74
4120 version-control: never
4121 coding: utf-8
4122 End: