gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.c: Remove separator comments.
   4         * tui/tui-layout.c: Remove separator comments.
   5         * tui/tui-win.c: Remove separator comments.
   6         * tui/tui-wingeneral.c: Remove separator comments.
   7
   8 2019-09-20  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui.h (strcat_to_buf): Don't declare.
  11         * tui/tui.c (strcat_to_buf): Remove.
  12
  13 2019-09-20  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
  16         from "fullname".
  17         * tui/tui-source.c (tui_source_window::set_contents)
  18         (tui_source_window::location_matches_p)
  19         (tui_source_window::maybe_update): Update.
  20
  21 2019-09-20  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
  24         Update.
  25         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
  26         prefix.
  27         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  28         (tui_data_window::line_from_reg_element_no)
  29         (tui_data_window::first_reg_element_no_inline)
  30         (tui_data_window::show_registers)
  31         (tui_data_window::show_register_group)
  32         (tui_data_window::display_registers_from)
  33         (tui_data_window::display_registers_from_line)
  34         (tui_data_window::first_data_item_displayed)
  35         (tui_data_window::delete_data_content_windows)
  36         (tui_data_window::erase_data_content)
  37         (tui_data_window::do_scroll_vertical)
  38         (tui_data_window::refresh_window)
  39         (tui_data_window::check_register_values): Update.
  40
  41 2019-09-20  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
  44         (struct tui_locator_window) <full_name, proc_name>: Now
  45         std::string.
  46         * tui/tui-stack.c (tui_locator_window::make_status_line)
  47         (tui_locator_window::set_locator_fullname)
  48         (tui_locator_window::set_locator_info): Update.
  49         * tui/tui-source.c (tui_source_window::set_contents)
  50         (tui_source_window::showing_source_p): Update.
  51
  52 2019-09-20  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  55         Don't call tui_locator_win_info_ptr.
  56
  57 2019-09-20  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-win.c (tui_resize_all): Don't call refresh.
  60
  61 2019-09-20  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
  64         height for locator.
  65         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
  66         * tui/tui-layout.c (show_source_disasm_command, show_data)
  67         (show_source_or_disasm_and_command): Use 1 as height for locator.
  68
  69 2019-09-20  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui.c (tui_enable): Update.
  72         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
  73         Update.
  74         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
  75         Update.
  76         * tui/tui-data.c (win_resized): Now bool.
  77         (tui_win_resized): Return bool.
  78         (tui_set_win_resized_to): Accept a bool.
  79
  80 2019-09-20  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
  83         Change type of "refresh_values_only".
  84         * tui/tui-regs.c (tui_data_window::show_register_group): Change
  85         type of "refresh_values_only".
  86
  87 2019-09-20  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
  90         std::string.
  91         (tui_disassemble): Add "pos" parameter.
  92         (tui_disasm_window::set_contents): Simplify.
  93
  94 2019-09-20  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-winsource.h (struct tui_source_window_base)
  97         <show_source_content>: Now private.
  98         * tui/tui-winsource.c
  99         (tui_source_window_base::show_source_content): Don't handle empty
 100         content case.
 101
 102 2019-09-20  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-layout.c (show_source_disasm_command)
 105         (show_source_or_disasm_and_command): Don't call
 106         show_source_content.
 107
 108 2019-09-20  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 111         Declare.
 112         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 113         from tui_make_status_line.
 114         (tui_locator_window::rerender): Update.
 115
 116 2019-09-20  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 119         (tui_locator_window::rerender): Update.
 120
 121 2019-09-20  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.h (struct tui_source_window_base)
 124         <~tui_source_window_base>: Don't declare.
 125         <fullname>: Remove.
 126         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 127         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 128         member.
 129         * tui/tui-source.c (tui_source_window::set_contents): Update.
 130         (tui_source_window::location_matches_p)
 131         (tui_source_window::maybe_update): Update.
 132
 133 2019-09-20  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-winsource.h (~tui_source_element): Remove.
 136         (tui_source_element): Update.
 137         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 138         * tui/tui-winsource.c (tui_show_source_line): Update.
 139         * tui/tui-source.c (tui_source_window::set_contents): Update.
 140         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 141
 142 2019-09-20  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 145         declare.
 146         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 147         tui_clear_source_windows_detail.
 148         * tui/tui-winsource.h (struct tui_source_window_base)
 149         <clear_detail>: Don't declare.
 150         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 151         Remove.
 152         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 153
 154 2019-09-20  Tom Tromey  <tromey@adacore.com>
 155
 156         PR ada/24919:
 157         * block.c (contained_in): Fix final return value.
 158
 159 2019-09-20  Alan Modra  <amodra@gmail.com>
 160
 161         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 162         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 163         (read_indirect_string_from_dwz): Use bfd accessor.
 164         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 165         * machoread.c (macho_symfile_read_all_oso): Likewise.
 166         * solib.c (solib_bfd_open): Likewise.
 167
 168 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 169
 170         * eval.c: Move declaration of overload_resolution to...
 171         * value.h: ...here.
 172
 173 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 176         * arm-linux-tdep.c: Likewise.
 177         * arm-nbsd-nat.c: Likewise.
 178         * arm-tdep.h: Declare arm_apcs_32.
 179         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 180
 181 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 182
 183         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 184         * dwarf2read.h: Declare dwarf_always_disassemble.
 185
 186 2019-09-19  Tom de Vries  <tdevries@suse.de>
 187
 188         PR gdb/25009
 189         * source-cache.c (source_cache::ensure): Catch exception thrown during
 190         construction of the highlighter.
 191
 192 2019-09-18  Alan Modra  <amodra@gmail.com>
 193
 194         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 195         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 196         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 197         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 198         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 199         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 200         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 201         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 202         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 203         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 204         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 205         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 206         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 207         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 208         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 209         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 210         * mi/mi-interp.c: Update throughout for bfd section macro and
 211         function changes.
 212         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 213         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 214
 215 2019-09-18  Tom Tromey  <tom@tromey.com>
 216
 217         * NEWS: Add entry.
 218         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 219         call rl_initialize.
 220         (tui_enable): Do not call rl_initialize.
 221
 222 2019-09-18  Christian Groessler  <chris@groessler.org>
 223
 224         * alpha-linux-nat.c: Include gdbarch.h.
 225
 226 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 227
 228         * ui-file.c: Include cli/cli-style.h.
 229         (term_cli_styling): Remove cli_styling declaration.
 230
 231 2019-09-18  Alan Modra  <amodra@gmail.com>
 232
 233         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 234         to bfd_asymbol_section.
 235
 236 2019-09-18  Alan Modra  <amodra@gmail.com>
 237
 238         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 239         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 240         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 241
 242 2019-09-18  Alan Modra  <amodra@gmail.com>
 243
 244         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 245         * spu-linux-nat.c (spu_bfd_open): Likewise.
 246
 247 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 248
 249         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 250         to bool to match definition in dwarf2read.c.
 251
 252 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 253
 254         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 255         (print_signatures): Likewise.
 256         (trust_pad_over_xvs): Likewise.
 257         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 258         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 259         * arm-linux-nat.c (arm_apcs_32): Likewise.
 260         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 261         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 262         * arm-tdep.c (arm_debug): Likewise.
 263         (arm_apcs_32): Likewise.
 264         * auto-load.c (debug_auto_load): Likewise.
 265         (auto_load_gdb_scripts): Likewise.
 266         (global_auto_load): Likewise.
 267         (auto_load_local_gdbinit): Likewise.
 268         (auto_load_local_gdbinit_loaded): Likewise.
 269         * auto-load.h (global_auto_load): Likewise.
 270         (auto_load_local_gdbinit): Likewise.
 271         (auto_load_local_gdbinit_loaded): Likewise.
 272         * breakpoint.c (disconnected_dprintf): Likewise.
 273         (breakpoint_proceeded): Likewise.
 274         (automatic_hardware_breakpoints): Likewise.
 275         (always_inserted_mode): Likewise.
 276         (target_exact_watchpoints): Likewise.
 277         (_initialize_breakpoint): Update.
 278         * breakpoint.h (target_exact_watchpoints): Change to bool.
 279         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 280         * cli/cli-cmds.c (trace_commands): Likewise.
 281         * cli/cli-cmds.h (trace_commands): Likewise.
 282         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 283         to bool*.
 284         * cli/cli-logging.c (logging_overwrite): Change to bool.
 285         (logging_redirect): Likewise.
 286         (debug_redirect): Likewise.
 287         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 288         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 289         to bool.
 290         <boolean_option_def>: Update.
 291         (struct flag_option_def): Change default type of Context to bool
 292         from int.
 293         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 294         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 295         (get_setshow_command_value_string): Likewise.
 296         * cli/cli-style.c (cli_styling): Change to bool.
 297         (source_styling): Likewise.
 298         * cli/cli-style.h (source_styling): Likewise.
 299         (cli_styling): Likewise.
 300         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 301         to bool.
 302         * command.h (var_types): Update comment.
 303         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 304         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 305         bool.
 306         (debug_compile_cplus_scopes): Likewise.
 307         * compile/compile-internal.h (compile_debug): Likewise.
 308         * compile/compile.c (compile_debug): Likewise.
 309         (struct compile_options) <raw>: Likewise.
 310         * cp-support.c (catch_demangler_crashes): Likewise.
 311         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 312         (usr_cmd_cris_dwarf2_cfi): Likewise.
 313         * csky-tdep.c (csky_debug): Likewise.
 314         * darwin-nat.c (enable_mach_exceptions): Likewise.
 315         * dcache.c (dcache_enabled_p): Likewise.
 316         * defs.h (info_verbose): Likewise.
 317         * demangle.c (demangle): Likewise.
 318         (asm_demangle): Likewise.
 319         * dwarf-index-cache.c (debug_index_cache): Likewise.
 320         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 321         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 322         * dwarf2read.c (check_physname): Likewise.
 323         (use_deprecated_index_sections): Likewise.
 324         (dwarf_always_disassemble): Likewise.
 325         * eval.c (overload_resolution): Likewise.
 326         * event-top.c (set_editing_cmd_var): Likewise.
 327         (exec_done_display_p): Likewise.
 328         * event-top.h (set_editing_cmd_var): Likewise.
 329         (exec_done_display_p): Likewise.
 330         * exec.c (write_files): Likewise.
 331         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 332         (debug_fbsd_nat): Likewise.
 333         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 334         Likewise.
 335         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 336         <backtrace_past_entry> Likewise.
 337         * gdb-demangle.h (demangle): Likewise.
 338         (asm_demangle): Likewise.
 339         * gdb_bfd.c (bfd_sharing): Likewise.
 340         * gdbcore.h (write_files): Likewise.
 341         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 342         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 343         * gdbthread.h (print_thread_events): Likewise.
 344         * gdbtypes.c (opaque_type_resolution): Likewise.
 345         (strict_type_checking): Likewise.
 346         * gnu-nat.c (gnu_debug_flag): Likewise.
 347         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 348         * guile/scm-param.c (pascm_variable): Add boolval.
 349         (add_setshow_generic): Update.
 350         (pascm_param_value): Update.
 351         (pascm_set_param_value_x): Update.
 352         * hppa-tdep.c (hppa_debug): Change to bool..
 353         * infcall.c (may_call_functions_p): Likewise.
 354         (coerce_float_to_double_p): Likewise.
 355         (unwind_on_signal_p): Likewise.
 356         (unwind_on_terminating_exception_p): Likewise.
 357         * infcmd.c (startup_with_shell): Likewise.
 358         * inferior.c (print_inferior_events): Likewise.
 359         * inferior.h (startup_with_shell): Likewise.
 360         (print_inferior_events): Likewise.
 361         * infrun.c (step_stop_if_no_debug): Likewise.
 362         (detach_fork): Likewise.
 363         (debug_displaced): Likewise.
 364         (disable_randomization): Likewise.
 365         (non_stop): Likewise.
 366         (non_stop_1): Likewise.
 367         (observer_mode): Likewise.
 368         (observer_mode_1): Likewise.
 369         (set_observer_mode): Update.
 370         (sched_multi): Change to bool.
 371         * infrun.h (debug_displaced): Likewise.
 372         (sched_multi): Likewise.
 373         (step_stop_if_no_debug): Likewise.
 374         (non_stop): Likewise.
 375         (disable_randomization): Likewise.
 376         * linux-tdep.c (use_coredump_filter): Likewise.
 377         (dump_excluded_mappings): Likewise.
 378         * linux-thread-db.c (auto_load_thread_db): Likewise.
 379         (check_thread_db_on_load): Likewise.
 380         * main.c (captured_main_1): Update.
 381         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 382         xx2_opt, boolean_opt>: Change to bool.
 383         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 384         * maint.c (maintenance_profile_p): Likewise.
 385         (per_command_time): Likewise.
 386         (per_command_space): Likewise.
 387         (per_command_symtab): Likewise.
 388         * memattr.c (inaccessible_by_default): Likewise.
 389         * mi/mi-main.c (mi_async): Likewise.
 390         (mi_async_1): Likewise.
 391         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 392         * nat/fork-inferior.h (startup_with_shell): Likewise.
 393         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 394         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 395         * nios2-tdep.c (nios2_debug): Likewise.
 396         * or1k-tdep.c (or1k_debug): Likewise.
 397         * parse.c (parser_debug): Likewise.
 398         * parser-defs.h (parser_debug): Likewise.
 399         * printcmd.c (print_symbol_filename): Likewise.
 400         * proc-api.c (procfs_trace): Likewise.
 401         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 402         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 403         (set_parameter_value): Update.
 404         (add_setshow_generic): Update.
 405         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 406         to bool*.
 407         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 408         int*.
 409         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 410         * record-btrace.c (record_btrace_target::store_registers): Update.
 411         * record-full.c (record_full_memory_query): Change to bool.
 412         (record_full_stop_at_limit): Likewise.
 413         * record-full.h (record_full_memory_query): Likewise.
 414         * remote-notif.c (notif_debug): Likewise.
 415         * remote-notif.h (notif_debug): Likewise.
 416         * remote.c (use_range_stepping): Likewise.
 417         (interrupt_on_connect): Likewise.
 418         (remote_break): Likewise.
 419         * ser-tcp.c (tcp_auto_retry): Likewise.
 420         * ser-unix.c (serial_hwflow): Likewise.
 421         * skip.c (debug_skip): Likewise.
 422         * solib-aix.c (solib_aix_debug): Likewise.
 423         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 424         (spu_auto_flush_cache_p): Likewise.
 425         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 426         Likewise.
 427         (struct info_print_options) <quiet>: Likewise.
 428         * symfile-debug.c (debug_symfile): Likewise.
 429         * symfile.c (auto_solib_add): Likewise.
 430         (separate_debug_file_debug): Likewise.
 431         * symfile.h (auto_solib_add): Likewise.
 432         (separate_debug_file_debug): Likewise.
 433         * symtab.c (basenames_may_differ): Likewise.
 434         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 435         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 436         (struct info_types_options) <quiet>: Likewise.
 437         * symtab.h (demangle): Likewise.
 438         (basenames_may_differ): Likewise.
 439         * target-dcache.c (stack_cache_enabled_1): Likewise.
 440         (code_cache_enabled_1): Likewise.
 441         * target.c (trust_readonly): Likewise.
 442         (may_write_registers): Likewise.
 443         (may_write_memory): Likewise.
 444         (may_insert_breakpoints): Likewise.
 445         (may_insert_tracepoints): Likewise.
 446         (may_insert_fast_tracepoints): Likewise.
 447         (may_stop): Likewise.
 448         (auto_connect_native_target): Likewise.
 449         (target_stop_and_wait): Update.
 450         (target_async_permitted): Change to bool.
 451         (target_async_permitted_1): Likewise.
 452         (may_write_registers_1): Likewise.
 453         (may_write_memory_1): Likewise.
 454         (may_insert_breakpoints_1): Likewise.
 455         (may_insert_tracepoints_1): Likewise.
 456         (may_insert_fast_tracepoints_1): Likewise.
 457         (may_stop_1): Likewise.
 458         * target.h (target_async_permitted): Likewise.
 459         (may_write_registers): Likewise.
 460         (may_write_memory): Likewise.
 461         (may_insert_breakpoints): Likewise.
 462         (may_insert_tracepoints): Likewise.
 463         (may_insert_fast_tracepoints): Likewise.
 464         (may_stop): Likewise.
 465         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 466         (make_thread_apply_all_options_def_group): Change argument from int*
 467         to bool*.
 468         (thread_apply_all_command): Update.
 469         (print_thread_events): Change to bool.
 470         * top.c (confirm): Likewise.
 471         (command_editing_p): Likewise.
 472         (history_expansion_p): Likewise.
 473         (write_history_p): Likewise.
 474         (info_verbose): Likewise.
 475         * top.h (confirm): Likewise.
 476         (history_expansion_p): Likewise.
 477         * tracepoint.c (disconnected_tracing): Likewise.
 478         (circular_trace_buffer): Likewise.
 479         * typeprint.c (print_methods): Likewise.
 480         (print_typedefs): Likewise.
 481         * utils.c (debug_timestamp): Likewise.
 482         (sevenbit_strings): Likewise.
 483         (pagination_enabled): Likewise.
 484         * utils.h (sevenbit_strings): Likewise.
 485         (pagination_enabled): Likewise.
 486         * valops.c (overload_resolution): Likewise.
 487         * valprint.h (struct value_print_options) <prettyformat_arrays,
 488         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 489         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 490         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 491         Likewise.
 492         * windows-nat.c (new_console): Likewise.
 493         (cygwin_exceptions): Likewise.
 494         (new_group): Likewise.
 495         (debug_exec): Likewise.
 496         (debug_events): Likewise.
 497         (debug_memory): Likewise.
 498         (debug_exceptions): Likewise.
 499         (useshell): Likewise.
 500         * windows-tdep.c (maint_display_all_tib): Likewise.
 501         * xml-support.c (debug_xml): Likewise.
 502
 503 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 504
 505         * source.c (prepare_path_for_appending): New function.
 506         (openp): Make use of new function.
 507         (find_and_open_source): Search for the compilation directory and
 508         source file as a relative path beneath the directory search path.
 509
 510 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 511
 512         * source-cache.c (source_cache::get_line_charpos): Catch
 513         exceptions and return false, this matches the behaviour documented
 514         in the header file.
 515
 516 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 517
 518         * ada-tasks.c (info_task): Remove quoting of the task's name.
 519
 520 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 521
 522         * symfile.c (auto_solib_add): Replace comment with a reference
 523         to the header file.
 524
 525 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 526
 527         * NEWS: Mention that gdb can now be compiled with Python 3
 528         on Windows.
 529
 530 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * maint.c (maint_print_section_data::maint_print_section_data):
 533         Force use of 'float log10 (float)' by casting the argument to
 534         float.
 535
 536 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 537
 538         * maint.c: Add 'cmath' include.
 539         (struct maint_print_section_data): New structure.
 540         (print_section_index): New function.
 541         (print_bfd_section_info): Add header comment, small whitespace
 542         cleanup, and update to call new print_section_index function.
 543         (print_objfile_section_info): Likewise.
 544         (maint_obj_section_from_bfd_section): New function.
 545         (print_bfd_section_info_maybe_relocated): New function.
 546         (maintenance_info_sections): Add header comment, always use
 547         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 548
 549 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 552         inner scope, add check that the objfile has psymtabs before
 553         checking psymtabs_addrmap.
 554         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 555
 556 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 557
 558         * NEWS: Announce that Ada task names are now shown at more places,
 559         and between quotes (except in info task output).
 560         * gdb/ada-tasks.c (task_to_str): New function.
 561         (display_current_task_id): Call task_to_str.
 562         (task_command_1): Likewise.
 563         (print_ada_task_info): In non-mi mode, Properly align headers and data
 564         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 565
 566 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 567
 568         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 569         prstatus.pr_lwp.pr_info instead of making it up.
 570
 571 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 572
 573         * auto-load.c (auto_load_expand_dir_vars): Update.
 574         * defs.h (gdb_datadir): Change to std::string.
 575         (python_libdir): Likewise.
 576         (relocate_gdb_directory): Change return type to std::string.
 577         * guile/guile.c (gdbscm_data_directory): Update.
 578         (initialize_scheme_side): Update.
 579         * jit.c (jit_reader_dir): Change to std::string.
 580         (jit_reader_load_command): Update.
 581         * main.c (gdb_datadir): Change to std::string.
 582         (python_libdir): Likewise.
 583         (set_gdb_data_directory): Update.
 584         (relocate_path): Change to return std::string.
 585         (relocate_gdb_directory): Change to return std::string.
 586         (relocate_gdbinit_path_maybe_in_datadir): Update.
 587         (captured_main_1): Update.
 588         * python/python.c (do_start_initialization): Update.
 589         * top.c (show_gdb_datadir): Update.
 590         * xml-syscall.c (xml_init_syscalls_info): Update.
 591         (init_syscalls_info): Update.
 592
 593 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 594
 595         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 596         out of get_init_files.
 597         (get_init_files): Update.
 598
 599 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 600
 601         * main.c (get_init_files): Change to use std::string.
 602         (captured_main_1): Update.
 603         (print_gdb_help): Update.
 604
 605 2019-09-11  Ali Tamur  <tamur@google.com>
 606
 607         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 608         implementation.
 609
 610 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 611
 612         * dbxread.c (read_dbx_symtab): Update.
 613         * dwarf2read.c (load_partial_dies): Update.
 614         * mdebugread.c (parse_partial_symbols): Update.
 615         (handle_psymbol_enumerators): Update.
 616         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 617         * psymtab.c (add_psymbol_to_bcache): Likewise.
 618         (add_psymbol_to_list): Likewise.
 619         * symtab.c (symbol_set_names): Likewise.
 620         * symtab.h (symbol_set_names): Likewise.
 621         * xcoffread.c (scan_xcoff_symtab): Update.
 622
 623 2019-09-11  Tom Tromey  <tom@tromey.com>
 624
 625         * symfile-mem.c (symbol_file_add_from_memory): Use
 626         bfd_set_filename.
 627         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 628         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 629
 630 2019-09-10  Tom Tromey  <tromey@adacore.com>
 631
 632         * dwarf-index-write.c (write_psymbols): Extend error message.
 633         (debug_names::insert): Add Ada code.
 634         (debug_names::write_psymbols): Remove Ada check.
 635         (debug_names) <m_string_obstack>: New member.
 636         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 637         (gdb_index_symbol_name_matcher::matches): Remove.
 638         (mapped_index_base::find_name_components_bounds): Add "lang"
 639         parameter.
 640         (mapped_index_base::build_name_components): Also split names
 641         according to Ada syntax.
 642         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 643         type of "match_callback".
 644         (check_match, check_find_bounds_finds)
 645         (dw2_expand_symtabs_matching): Update.
 646         (dw2_debug_names_iterator): Add new constructor.
 647         (dw2_debug_names_map_matching_symbols): New function.
 648         (dw2_debug_names_expand_symtabs_matching): Update.
 649         (dwarf2_debug_names_functions): Use
 650         dw2_debug_names_map_matching_symbols.
 651
 652 2019-09-10  Tom Tromey  <tromey@adacore.com>
 653
 654         * dwarf2read.c (dw2_get_file_names_reader): Add the
 655         CU's file name to the results.
 656
 657 2019-09-10  Tom Tromey  <tromey@adacore.com>
 658
 659         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 660         map_matching_symbols.  Update.
 661         * dwarf2read.c (dw2_map_matching_symbols): Update.
 662         * psymtab.c (match_partial_symbol): Change type; update.
 663         (psym_map_matching_symbols): Likewise.
 664         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 665         type; update.
 666         * symfile.h (struct quick_symbol_functions)
 667         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 668         Remove "match".
 669
 670 2019-09-10  Tom Tromey  <tromey@adacore.com>
 671
 672         * psymtab.c (map_block): Remove.
 673         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 674         * symtab.c (iterate_over_symbols_terminated): New function.
 675         * symtab.c (iterate_over_symbols_terminated): Declare.
 676
 677 2019-09-10  Tom Tromey  <tromey@adacore.com>
 678
 679         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 680         * language.h (struct language_defn) <la_iterate_over_symbols>:
 681         Return bool.
 682         * symtab.c (iterate_over_symbols): Return bool.
 683         * symtab.h (iterate_over_symbols): Return bool.
 684
 685 2019-09-10  Tom Tromey  <tromey@adacore.com>
 686
 687         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 688         (add_nonlocal_symbols): Update.
 689         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 690         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 691         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 692         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 693         Change type of "callback".  Remove "data".
 694
 695
 696 2019-09-09  Ali Tamur  <tamur@google.com>
 697
 698         * dwarf2read.c (comp_unit_head): Update comment.
 699         (dwarf2_dwo_name): New function declaration.
 700         (dwarf_unit_type_name): New function declaration.
 701         (read_comp_unit_head): Add support for new compilation units,
 702         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 703         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 704         (currently named as "signature") in their header. Also clarify error
 705         messages.
 706         (lookup_dwo_id): New function. Returns the dwo id of the given
 707         compile unit.
 708         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 709         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 710         functions.
 711         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 712         (dwarf2_dwo_name): Get the dwo name if present.
 713         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 714         purposes.
 715
 716 2019-09-09  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 719
 720 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 721
 722         * python/python.c (do_start_initialization): Make progname_copy static,
 723         to avoid a leak report.
 724
 725 2019-09-08  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 728
 729 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 730
 731         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 732         Change type to gdb::optional<block_enum>.
 733         (dw2_symtab_iter_init): Change block_index parameter type
 734         to gdb::optional<block_enum>.
 735         (dw2_lookup_symbol): Change block_index parameter
 736         type to block_enum.c
 737         (dw2_debug_names_lookup_symbol): Likewise.
 738         * psymtab.c (psym_lookup_symbol): Likewise.
 739         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 740         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 741         Likewise.
 742
 743 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 744
 745         * defs.h (relocate_gdb_directory): Change int to bool in
 746         signature and rename flag to relocatable.
 747         * main.c (relocate_path): Likewise.
 748         (relocate_gdb_directory): Likewise.
 749
 750 2019-09-06  Alan Modra  <amodra@gmail.com>
 751
 752         * coffread.c (coff_symfile_read): Constify filename variable.
 753         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 754         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 755         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 756         * solib.c (reload_shared_libraries_1): Likewise.
 757         * symfile.c (reread_symbols): Likewise.
 758         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 759         * solib-darwin.c (darwin_bfd_open): Likewise.
 760         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 761
 762 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 765         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 766
 767 2019-09-03  Tom Tromey  <tromey@adacore.com>
 768
 769         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 770         types.
 771         (has_negatives): Unbias a range type bound.
 772         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 773         * gdbtypes.c (operator==): Handle new field.
 774         (create_range_type): Add "bias" parameter.
 775         (create_static_range_type, resolve_dynamic_range): Update.
 776         * gdbtypes.h (struct range_bounds) <bias>: New member.
 777         (create_range_type): Add bias parameter.
 778         * printcmd.c (print_scalar_formatted): Unbias range types.
 779         * value.c (unpack_long): Unbias range types.
 780         (pack_long): Bias range types.
 781
 782 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 783
 784         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 785         probe arguments.
 786
 787 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 788
 789         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 790         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 791         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 792         (compile_probe_arg): Likewise.
 793         * probe.h (get_argument_count): Likewise.
 794         * solib-svr4.c (solib_event_probe_action): Likewise.
 795         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 796
 797 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 798
 799         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 800         code to here...
 801         (svr4_create_solib_event_breakpoints): ...from here.
 802
 803 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 804
 805         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 806         suffix from warning message.
 807
 808 2019-08-30  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-winsource.h (struct tui_source_window_base)
 811         <refresh_all>: Don't declare.
 812         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 813         Remove.
 814         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 815         tui_show_locator_content.
 816         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 817         declare.
 818         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 819         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 820         declare.
 821
 822 2019-08-30  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 825
 826 2019-08-30  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 829         Remove unnecessary forward declarations.
 830
 831 2019-08-30  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 834         rerender.
 835         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 836         tui_show_locator_content.
 837
 838 2019-08-30  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 841         (tui_locator_window::rerender): Rewrite using body of previous
 842         tui_show_locator_content.
 843
 844 2019-08-30  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 847         set_locator_fullname>: New methods.
 848         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 849         Rename from tui_set_locator_fullname.
 850         (tui_locator_window::set_locator_info): Rename from
 851         tui_set_locator_info.  Return bool.
 852         (tui_update_locator_fullname, tui_show_frame_info): Update.
 853
 854 2019-08-30  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 857
 858 2019-08-30  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 861         call touchwin.
 862
 863 2019-08-30  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-wingeneral.c (box_win): Assume win_info and
 866         win_info->handle cannot be NULL.
 867
 868 2019-08-30  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 871         refresh_window>: Declare.
 872         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 873         resize.
 874         (tui_data_item_window::rerender): Rename from
 875         tui_display_register.
 876         (tui_data_item_window::refresh_window): New method.
 877         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 878         no-op.
 879
 880 2019-08-30  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 883         regs_column_count, current_group>: Move later.  Now private.
 884         <get_current_group>: New method.
 885         * tui/tui-regs.c (tui_reg_command): Update.
 886         * tui/tui-layout.c (tui_set_layout): Update.
 887
 888 2019-08-30  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 891         (tui_data_window::rerender): Don't call
 892         check_and_display_highlight_if_needed.
 893         (tui_data_window::refresh_all): Remove call to
 894         erase_data_content.
 895
 896 2019-08-30  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 899         (tui_data_window::display_registers_from)
 900         (tui_data_window::display_reg_element_at_line)
 901         (tui_data_window::display_registers_from_line): Remove checks of
 902         "empty".
 903
 904 2019-08-30  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 907         Don't declare.
 908         * tui/tui-regs.c (tui_data_window::show_registers): Call
 909         rerender.
 910         (tui_data_window::rerender): Rename from display_all_data.
 911         (tui_data_window::rerender): Remove old implementation.
 912
 913 2019-08-30  Tom Tromey  <tom@tromey.com>
 914
 915         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 916         text.
 917         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 918
 919 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 920             Sergio Durigan Junior  <sergiodj@redhat.com>
 921
 922         PR win32/24284
 923         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 924
 925 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 928         when searching for types.
 929
 930 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * f-lang.c (f_language_defn): Use f_print_typedef.
 933         * f-lang.h (f_print_typedef): Declare.
 934         * f-typeprint.c (f_print_typedef): Define.
 935
 936 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 937
 938         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 939
 940 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 941
 942         * cli/cli-utils.c (info_print_options_defs): Delete.
 943         (make_info_print_options_def_group): Delete.
 944         (extract_info_print_options): Delete.
 945         (info_print_command_completer): Delete.
 946         (info_print_args_help): Add extra parameter, and optionally
 947         include text about -n flag.
 948         * cli/cli-utils.h (struct info_print_options): Delete.
 949         (extract_info_print_options): Delete declaration.
 950         (info_print_command_completer): Delete declaration.
 951         (info_print_args_help): Add extra parameter, extend header
 952         comment.
 953         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 954         search_symbols.
 955         * stack.c (struct info_print_options): New type.
 956         (info_print_options_defs): New file scoped variable.
 957         (make_info_print_options_def_group): New static function.
 958         (info_print_command_completer): New static function.
 959         (info_locals_command): Update to use new local functions.
 960         (info_args_command): Likewise.
 961         (_initialize_stack): Add extra parameter to calls to
 962         info_print_args_help.
 963         * symtab.c (search_symbols): Add extra parameter, use this to
 964         possibly excluse non-debug symbols.
 965         (symtab_symbol_info): Add extra parameter, which is passed on to
 966         search_symbols.
 967         (struct info_print_options): New type.
 968         (info_print_options_defs): New file scoped variable.
 969         (make_info_print_options_def_group): New static function.
 970         (info_print_command_completer): New static function.
 971         (info_variables_command): Update to use local functions, and pass
 972         extra parameter through to symtab_symbol_info.
 973         (info_functions_command): Likewise.
 974         (info_types_command): Pass additional argument through to
 975         symtab_symbol_info.
 976         (rbreak_command): Pass extra argument to search_symbols.
 977         (_initialize_symtab): Add extra arguments for calls to
 978         info_print_args_help, and update help text for 'info variables',
 979         'whereis', and 'info functions' commands.
 980         * symtab.h (search_symbols): Add extra argument to declaration.
 981         * NEWS: Mention new flags.
 982
 983 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 984
 985         * symtab.c (lookup_static_symbol): Call the new function (and move
 986         it down to be next to lookup_global_symbol).
 987         (struct global_sym_lookup_data): Add block_enum member and rename to...
 988         (struct global_or_static_sym_lookup_data): ...this.
 989         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 990         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 991         (lookup_symbol_global_or_static_iterator_cb): ...this.
 992         (lookup_global_or_static_symbol): New function.
 993         (lookup_global_symbol): Call new function.
 994
 995 2019-08-26  Tom de Vries  <tdevries@suse.de>
 996
 997         PR c++/24852
 998         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 999         when pc_probe.prob == NULL.
1000
1001 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1002
1003         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1004         variable symbol_linkage to symbol_linkage_.
1005
1006 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1007
1008         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1009         represent whether the symbol is static, dynamic, or we don't
1010         know.
1011
1012 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1013
1014         * gdb/rx-tdep.c (rx_register_names): New.
1015         (rx_register_name): Delete.
1016         (rx_psw_type): Delete.
1017         (rx_fpsw_type): Delete.
1018         (rx_register_type): Delete.
1019         (rx_gdbarch_init): Convert target-descriptions.
1020         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1021         * gdb/features/Makefile: Add rx.xml.
1022         * gdb/features/rx.xml: New.
1023         * gdb/features/rx.c: Generated.
1024         * gdb/NEWS: Mention target description support.
1025
1026 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1027
1028         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1029         *slot_ptr.
1030
1031 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1032
1033         * configure.ac: Don't check for 'dlfcn.h' (moved to
1034         gdbsupport/common.m4).
1035         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1036         'gdbsupport/'.
1037         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1038         * compile/compile-c-support.c: Include
1039         'gdbsupport/gdb-dlfcn.h'.
1040         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1041         * gdb-dlfcn.c: Move to...
1042         * gdbsupport/gdb-dlfcn.c: ... here.
1043         * gdb-dlfcn.h: Move to...
1044         * gdbsupport/gdb-dlfcn.h: ... here.
1045
1046 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1047
1048         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1049         the offset field signed.
1050
1051 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * python/lib/gdb/__init__.py (_execute_file): New function.
1054         * python/python.c (python_run_simple_file): Call gdb._execute_file
1055         on Windows.
1056
1057 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1060         all uses as this was never set to anything but a zero value.
1061
1062 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1063
1064         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1065
1066 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1067
1068         * tui/tui-data.h (tui_gen_win_info): Add an =default
1069         move constructor, required by some GCC versions.
1070
1071 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1072
1073         * go32-nat.c (go32_sysinfo): Add hygon_p.
1074
1075 2019-08-20  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1078         line_from_reg_element_no, first_reg_element_no_inline,
1079         display_all_data, delete_data_content_windows,
1080         erase_data_content>: Now private.
1081
1082 2019-08-20  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1085         (tui_unhighlight_win, tui_highlight_win)
1086         (tui_win_info::make_window): Update.
1087         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1088
1089 2019-08-20  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1092         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1093         (MAX_PID_WIDTH): Move to tui-stack.c.
1094         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1095         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1096         (MAX_PID_WIDTH): Move from tui-data.h.
1097
1098 2019-08-20  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1101         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1102         (box_win): Update.
1103         (tui_gen_win_info::make_window): Rename from tui_make_window.
1104         (tui_win_info::make_window): New method.
1105         (tui_gen_win_info::make_visible): Update.
1106         * tui/tui-source.c (tui_source_window::set_contents): Update.
1107         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1108         (tui_data_window::display_registers_from): Update.
1109         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1110         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1111         Declare.
1112         <can_box>: Remove.
1113         <title>: Remove.
1114         (struct tui_win_info) <make_window>: Declare.
1115         <can_box>: Now virtual.
1116         <title>: New member.
1117         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1118         * tui/tui-command.c (tui_cmd_window::resize): Update.
1119
1120 2019-08-20  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1123         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1124         (tui_data_window::check_register_values): Update.
1125
1126 2019-08-20  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-regs.h (struct tui_data_window): Use
1129         DISABLE_COPY_AND_ASSIGN.
1130         <regs_content>: Change type, removing unique_ptr.
1131         <tui_data_window>: Add move constructor.
1132         * tui/tui-regs.c (tui_data_window::show_registers)
1133         (tui_data_window::show_register_group)
1134         (tui_data_window::display_registers_from)
1135         (tui_data_window::display_registers_from)
1136         (tui_data_window::first_data_item_displayed)
1137         (tui_data_window::delete_data_content_windows)
1138         (tui_data_window::rerender, tui_data_window::refresh_window)
1139         (tui_data_window::check_register_values): Update.
1140
1141 2019-08-20  Tom Tromey  <tom@tromey.com>
1142
1143         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1144         show_register_group>: Declare.
1145         (tui_show_register_group): Don't declare.
1146         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1147         tui_show_registers.
1148         (tui_data_window::show_register_group): Rename from
1149         tui_show_register_group.
1150         (tui_data_window::check_register_values, tui_reg_command):
1151         Update.
1152         * tui/tui-layout.c (tui_set_layout): Update.
1153
1154 2019-08-20  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1157         Declare.
1158         (tui_check_register_values): Don't declare.
1159         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1160         from tui_check_register_values.
1161         * tui/tui-hooks.c (tui_register_changed): Update.
1162
1163 2019-08-20  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-regs.c (tui_reg_layout): Move later.
1166         (tui_show_registers): Don't enable TUI mode or change layout.
1167
1168 2019-08-20  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-regs.h (struct tui_data_item_window)
1171         <~tui_data_item_window>: Remove.
1172         <content>: Now a unique_xmalloc_ptr.
1173         * tui/tui-regs.c (tui_register_format): Return a
1174         unique_xmalloc_ptr.
1175         (tui_get_register): Update.
1176         (~tui_data_item_window): Remove.
1177         (tui_data_window::display_registers_from, tui_display_register):
1178         Update.
1179         * tui/tui-io.h (tui_expand_tabs): Update.
1180         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1181         Remove "col" parameter.
1182
1183 2019-08-20  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1186         field.
1187         * tui/tui-regs.c (~tui_data_item_window): Update.
1188
1189 2019-08-20  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1192         earlier.
1193
1194 2019-08-20  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1197
1198 2019-08-20  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-source.h (struct tui_source_window): Update.
1201         * tui/tui-regs.c (tui_show_registers): Update.
1202         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1203         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1204         (NO_REGS_STRING): Remove defines.
1205
1206 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1207
1208         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1209         unnecessary thread walk if remote doesn't support the packet.
1210
1211 2019-08-19  Tom Tromey  <tromey@adacore.com>
1212
1213         * python/py-value.c (value_has_field): Fix indentation.
1214
1215 2019-08-19  Tom Tromey  <tromey@adacore.com>
1216
1217         * printcmd.c (do_one_display, info_display_command): Update.
1218         * block.h (contained_in): Return bool.  Add allow_nested
1219         parameter.
1220         * block.c (contained_in): Return bool.  Add allow_nested
1221         parameter.
1222
1223 2019-08-19  Tom Tromey  <tom@tromey.com>
1224
1225         * configure: Rebuild.
1226         * configure.ac: Disallow the combination of -static-libstdc++ and
1227         source highlight.
1228         * source-cache.c (get_language_name): Handle rust.
1229         (source_cache::get_source_lines): Ignore highlighting exceptions.
1230
1231 2019-08-16  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1234         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1235         (struct tui_source_window_base) <make_visible, refresh_window,
1236         resize>: Remove methods.
1237         <execution_info>: Remove field.
1238         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1239         (tui_show_source_line, tui_source_window_base)
1240         (~tui_source_window_base): Update.
1241         (tui_source_window_base::resize)
1242         (tui_source_window_base::make_visible)
1243         (tui_source_window_base::refresh_window): Remove.
1244         (tui_source_window_base::update_exec_info): Update.
1245         * tui/tui-source.c (tui_source_window::set_contents): Update.
1246         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1247
1248 2019-08-16  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1251         deprecated_query_hook.
1252
1253 2019-08-16  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1256         (tui_update_source_windows_with_line): Update.
1257         * tui/tui-source.h (struct tui_source_window)
1258         <show_symtab_source>: Declare.
1259         (tui_show_symtab_source): Don't declare.
1260         * tui/tui-source.c (tui_show_symtab_source): Rename from
1261         tui_show_symtab_source.
1262
1263 2019-08-16  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-winsource.h (struct tui_source_window_base)
1266         <set_contents>: Declare.
1267         * tui/tui-winsource.c
1268         (tui_source_window_base::update_source_window_as_is): Update.
1269         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1270         Declare.
1271         (tui_set_source_content): Don't declare.
1272         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1273         tui_set_source_content.
1274         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1275         Declare.
1276         (tui_set_disassem_content): Don't declare.
1277         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1278         tui_set_disassem_content.
1279
1280 2019-08-16  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-winsource.h (struct tui_source_window_base)
1283         <update_breakpoint_info>: Declare.
1284         (tui_update_breakpoint_info): Don't declare.
1285         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1286         (tui_update_all_breakpoint_info): Update.
1287         (tui_source_window_base::update_breakpoint_info): Rename from
1288         tui_update_breakpoint_info.
1289         (tui_source_window_base::update_exec_info): Update.
1290
1291 2019-08-16  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-winsource.h (struct tui_source_window_base)
1294         <update_source_window>: Declare.
1295         (tui_update_source_window): Don't declare.
1296         * tui/tui-winsource.c
1297         (tui_source_window_base::update_source_window): Rename from
1298         tui_update_source_window.
1299         (tui_source_window_base::rerender): Update.
1300         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1301         * tui/tui-disasm.c (tui_show_disassem)
1302         (tui_show_disassem_and_update_source)
1303         (tui_disasm_window::maybe_update): Update.
1304
1305 2019-08-16  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-winsource.h (struct tui_source_window_base)
1308         <update_source_window_as_is>: Declare.
1309         (tui_update_source_window_as_is): Don't declare.
1310         * tui/tui-winsource.c (tui_update_source_window): Update
1311         (tui_source_window_base::update_source_window_as_is): Rename from
1312         tui_update_source_window_as_is.
1313         (tui_source_window_base::refill): Update.
1314         * tui/tui-source.c (tui_show_symtab_source): Update.
1315         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1316         Update.
1317
1318 2019-08-16  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-winsource.h (tui_update_source_window)
1321         (tui_update_source_window_as_is): Remove "noerror" parameter.
1322         * tui/tui-winsource.c (tui_update_source_window)
1323         (tui_update_source_window_as_is): Remove "noerror" parameter.
1324         (tui_update_source_windows_with_addr)
1325         (tui_update_source_windows_with_line)
1326         (tui_source_window_base::rerender)
1327         (tui_source_window_base::refill): Update.
1328         * tui/tui-source.h (tui_set_source_content)
1329         (tui_show_symtab_source): Remove "noerror" parameter.
1330         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1331         parameter.
1332         (tui_show_symtab_source): Likewise.
1333         (tui_source_window::maybe_update): Update.
1334         * tui/tui-disasm.c (tui_show_disassem)
1335         (tui_show_disassem_and_update_source)
1336         (tui_disasm_window::do_scroll_vertical)
1337         (tui_disasm_window::maybe_update): Update.
1338
1339 2019-08-16  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui.c (tui_is_window_visible): Update.
1342         * tui/tui-wingeneral.c (tui_make_window)
1343         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1344         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1345         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1346         (tui_set_win_height_command, parse_scrolling_args): Update.
1347         * tui/tui-source.c (tui_source_window::style_changed): Update.
1348         * tui/tui-regs.c (tui_show_registers)
1349         (tui_data_window::first_data_item_displayed)
1350         (tui_data_window::delete_data_content_windows)
1351         (tui_check_register_values, tui_reg_command): Update.
1352         * tui/tui-disasm.c (tui_show_disassem): Update.
1353         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1354         method.
1355         <is_visible>: Remove field.
1356         * tui/tui-data.c (tui_next_win, tui_prev_win)
1357         (tui_delete_invisible_windows): Update.
1358
1359 2019-08-16  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-winsource.h (struct tui_source_window_base)
1362         <m_has_locator>: Remove.
1363         * tui/tui-layout.c (show_source_disasm_command, show_data)
1364         (show_source_or_disasm_and_command): Update.
1365
1366 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1367
1368         * NEWS (Other MI changes): New subsection.
1369         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1370         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1371         * arch-utils.c (default_get_pc_address_flags): New function.
1372         * arch-utils.h (default_get_pc_address_flags): New declaration.
1373         * gdbarch.sh: Add get_pc_address_flags.
1374         * gdbarch.c: Regenerate.
1375         * gdbarch.h: Likewise.
1376         * stack.c (print_pc): New function.
1377         (print_frame_info) (print_frame): Call print_pc.
1378
1379 2019-08-16  Tom de Vries  <tdevries@suse.de>
1380
1381         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1382         print_objfile_section_info.
1383
1384 2019-08-15  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1387         calling update_cmdwin_start_line.
1388         * tui/tui-winsource.h (struct tui_source_window_base)
1389         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1390         <rerender>: Declare.
1391         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1392         Call rerender.
1393         (tui_source_window_base::set_new_height): Remove.
1394         (tui_source_window_base::rerender): Rename from
1395         do_make_visible_with_new_height.
1396         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1397         resize method.
1398         (tui_win_info::make_invisible_and_set_new_height)
1399         (tui_win_info::make_visible_with_new_height): Remove.
1400         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1401         Declare.
1402         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1403         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1404         do_make_visible_with_new_height>: Don't declare.
1405         <rerender>: Declare.
1406         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1407         set_new_height.
1408         (tui_data_window::do_make_visible_with_new_height): Remove.
1409         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1410         call tui_show_locator_content.
1411         (tui_gen_win_info::resize): Call rerender.
1412         (show_source_or_disasm_and_command): Don't call
1413         tui_show_locator_content.
1414         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1415         method.
1416         (struct tui_win_info) <rerender>: Declare.
1417         <set_new_height, make_invisible_and_set_new_height,
1418         make_visible_with_new_height>: Don't declare.
1419         * tui/tui-data.c (tui_win_list::rerender): New method.
1420         * tui/tui-command.h (struct tui_cmd_window)
1421         <do_make_visible_with_new_height>: Don't declare.
1422         * tui/tui-command.c
1423         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1424
1425 2019-08-15  Tom Tromey  <tromey@adacore.com>
1426
1427         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1428         * ada-lang.c (ada_enum_name): Likewise.
1429
1430 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1431
1432         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1433         leading underscore.
1434         (GdbOutputErrorFile): Likewise.
1435         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1436         accordingly.
1437         (execute_unwinders): Rename to have a leading underscore.
1438         (auto_load_packages): Likewise.
1439         (global scope): Adjust call to auto_load_packages accordingly.
1440         (GdbSetPythonDirectory): Likewise.
1441         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1442         instead of execute_unwinders.
1443
1444 2019-08-15  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1447         (show_data): Don't change window visibility.
1448         (tui_gen_win_info::resize): Remove special case for command
1449         window.  Use wresize, when available.
1450         (show_source_or_disasm_and_command): Don't change window
1451         visibility.
1452         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1453         <make_visible>: New method.
1454         * tui/tui-command.c (tui_cmd_window::resize): New method.
1455
1456 2019-08-15  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1459         (struct tui_source_windows): New.
1460         * tui/tui-winsource.c (tui_display_main): Update.
1461         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1462         (new_height_ok, parse_scrolling_args): Update.
1463         * tui/tui-layout.c (show_layout, show_data): Update.
1464         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1465         (tui_add_to_source_windows): Don't declare.
1466         * tui/tui-data.c (source_windows, tui_source_windows)
1467         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1468
1469 2019-08-15  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1472         Rename from reset.
1473         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1474         * tui/tui-layout.c (show_source_disasm_command, show_data):
1475         Update.
1476         (tui_gen_win_info::resize): Rename.
1477         (show_source_or_disasm_and_command): Update.
1478         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1479         reset.
1480
1481 2019-08-15  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1484         * tui/tui-interp.c (tui_interp::init): Don't call
1485         tui_initialize_static_data.
1486         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1487
1488 2019-08-15  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1491         examine tui_win_list.
1492
1493 2019-08-15  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1496         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1497         tui_clear_source_content.
1498         (tui_clear_source_content): Remove.
1499         (tui_source_window_base::do_erase_source_content): Hoist call to
1500         content.clear().
1501         * tui/tui-stack.c (tui_show_frame_info): Don't call
1502         tui_clear_source_content.
1503
1504 2019-08-15  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-winsource.h (struct tui_source_window_base)
1507         <do_erase_source_content>: New method.
1508         <erase_source_content>: New method.
1509         (tui_erase_source_content): Don't declare.
1510         * tui/tui-winsource.c (tui_clear_source_content): Update.
1511         (tui_source_window_base::do_erase_source_content): Rename from
1512         tui_erase_source_content.
1513         (tui_source_window_base::show_source_content): Update.
1514         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1515         * tui/tui-source.h (struct tui_source_window)
1516         <erase_source_content>: New method.
1517         * tui/tui-disasm.h (struct tui_disasm_window)
1518         <erase_source_content>: New method.
1519
1520 2019-08-15  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1523         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1524         constructor.
1525         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1526         * tui/tui-source.c (tui_set_source_content): Update.
1527         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1528
1529 2019-08-15  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1532         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1533         tui-source.c.
1534         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1535         Declare.
1536         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1537         method.
1538         (tui_source_window::maybe_update): Update.
1539
1540 2019-08-15  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1543         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1544         tui-disasm.c.
1545         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1546         Declare.
1547         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1548         method.
1549         (tui_disasm_window::maybe_update): Update.
1550
1551 2019-08-15  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-winsource.h (struct tui_source_window_base)
1554         <maybe_update>: Declare.
1555         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1556         method.
1557         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1558         Declare.
1559         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1560         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1561         Declare.
1562         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1563
1564 2019-08-15  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1567
1568 2019-08-15  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-wingeneral.c: Include tui-stack.h.
1571         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1572         (struct tui_locator_window): Move from tui-data.h.
1573         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1574         (tui_initialize_static_data): Move from tui-data.c.
1575         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1576         (struct tui_locator_window): Move to tui-stack.c.
1577         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1578         (tui_initialize_static_data): Move to tui-stack.c.
1579
1580 2019-08-15  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-layout.c (show_source_disasm_command)
1583         (show_source_or_disasm_and_command): Use make_visible method, not
1584         tui_make_window.
1585         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1586         Remove.
1587
1588 2019-08-15  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-wingeneral.h (tui_make_window): Update.
1591         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1592         parameter.
1593         (tui_gen_win_info::make_visible): Update.
1594         * tui/tui-regs.c (tui_data_window::display_registers_from):
1595         Update.
1596         * tui/tui-layout.c (show_source_disasm_command)
1597         (show_source_or_disasm_and_command): Update.
1598         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1599         (enum tui_box): Remove.
1600         (struct tui_win_info) <can_box>: New method.
1601         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1602         method.
1603
1604 2019-08-15  Tom de Vries  <tdevries@suse.de>
1605
1606         * linux-nat-trad.c: Include gdbarch.h.
1607
1608 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1609
1610         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1611         register sizes.
1612
1613 2019-08-14  Tom Tromey  <tromey@adacore.com>
1614
1615         * darwin-nat.c: Include gdbarch.h.
1616         * darwin-nat-info.c: Include gdbarch.h.
1617
1618 2019-08-13  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1621         Remove.
1622         * tui/tui-data.c (tui_initialize_static_data): Update.
1623
1624 2019-08-13  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-winsource.h (struct tui_exec_info_window)
1627         <~tui_exec_info_window, maybe_allocate_content, get_content,
1628         m_content>: Remove.
1629         (struct tui_source_window_base) <set_exec_info_content,
1630         show_exec_info_content>: Don't declare.
1631         * tui/tui-winsource.c
1632         (tui_exec_info_window::maybe_allocate_content): Remove.
1633         (tui_source_window_base::update_exec_info): Rename from
1634         set_exec_info_content.
1635         (tui_source_window_base::show_exec_info_content)
1636         (tui_source_window_base::update_exec_info): Remove.
1637
1638 2019-08-13  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1641         declare.
1642         * tui/tui-winsource.c (tui_update_source_window_as_is)
1643         (tui_update_source_windows_with_addr, tui_erase_source_content):
1644         Update.
1645         (tui_clear_exec_info_content): Remove.
1646
1647 2019-08-13  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1650         declare.
1651         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1652         call tui_erase_exec_info_content.
1653         (tui_clear_exec_info_content): Rename from
1654         tui_erase_exec_info_content.
1655         (tui_clear_exec_info_content): Delete.
1656
1657 2019-08-13  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-winsource.h (struct tui_source_window_base)
1660         <show_exec_info_content>: Declare.
1661         (tui_show_exec_info_content): Don't declare.
1662         * tui/tui-winsource.c
1663         (tui_source_window_base::show_exec_info_content): Rename from
1664         tui_show_exec_info_content.
1665         (tui_source_window_base::update_exec_info): Update.
1666
1667 2019-08-13  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1670         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1671         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1672         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1673         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1674         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1675         ... here.
1676
1677 2019-08-13  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-winsource.h (struct tui_source_window_base)
1680         <update_exec_info>: Declare.
1681         (tui_update_exec_info): Don't declare.
1682         * tui/tui-winsource.c (tui_update_source_window_as_is)
1683         (tui_source_window_base::refresh_all)
1684         (tui_update_all_breakpoint_info): Update.
1685         (tui_source_window_base::update_exec_info): Rename from
1686         tui_update_exec_info.
1687         * tui/tui-stack.c (tui_show_frame_info): Update.
1688
1689 2019-08-13  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.h (struct tui_source_window_base)
1692         <set_exec_info_content>: Declare.
1693         (tui_set_exec_info_content): Don't declare.
1694         * tui/tui-winsource.c
1695         (tui_source_window_base::set_exec_info_content): Rename from
1696         tui_set_exec_info_content.
1697         (tui_update_exec_info): Update.
1698
1699 2019-08-13  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-winsource.h (struct tui_source_window_base)
1702         <show_source_content>: Declare.
1703         (tui_show_source_content): Don't declare.
1704         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1705         (tui_source_window_base::show_source_content): Rename from
1706         tui_show_source_content.
1707         (tui_source_window_base::refresh_all): Update.
1708         * tui/tui-layout.c (show_source_disasm_command)
1709         (show_source_or_disasm_and_command): Update.
1710
1711 2019-08-13  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-winsource.c (tui_erase_source_content)
1714         (tui_show_source_content, tui_source_window_base::refresh_all):
1715         Update.
1716         * tui/tui-wingeneral.h
1717         (tui_check_and_display_highlight_if_needed): Don't declare.
1718         * tui/tui-wingeneral.c
1719         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1720         check_and_display_highlight_if_needed.
1721         * tui/tui-win.c (tui_rehighlight_all)
1722         (tui_win_info::make_visible_with_new_height): Update.
1723         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1724         (tui_data_window::erase_data_content)
1725         (tui_data_window::display_all_data): Update.
1726         * tui/tui-data.h (struct tui_win_info)
1727         <check_and_display_highlight_if_needed>: Declare.
1728
1729 2019-08-13  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-win.c (tui_resize_all): Call
1732         tui_delete_invisible_windows.
1733         * tui/tui-layout.c (show_layout): Call
1734         tui_delete_invisible_windows.
1735         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1736         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1737
1738 2019-08-13  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1741         tui_add_win_to_layout.
1742
1743 2019-08-13  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1746         * tui/tui-layout.c (tui_default_win_height): Now static.
1747
1748 2019-08-13  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1751         single switch.
1752         (show_source_disasm_command, show_source_or_disasm_and_command):
1753         Don't check current layout.
1754
1755 2019-08-13  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-wingeneral.c (make_all_visible): Remove.
1758         (tui_make_all_invisible): Simplify.
1759         * tui/tui-layout.c (tui_make_all_invisible): Move from
1760         tui-wingeneral.c; simplify.
1761         (show_layout): Hoist call to tui_make_all_invisible.
1762         (show_data): Don't call tui_make_all_invisible.
1763
1764 2019-08-13  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1767         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1768
1769 2019-08-13  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1772         tui-data.c.
1773         (show_source_disasm_command, show_data)
1774         (show_source_or_disasm_and_command): Don't use
1775         tui_set_current_layout_to.
1776         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1777         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1778         tui-layout.c.
1779         (tui_set_current_layout_to): Remove.
1780
1781 2019-08-13  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-layout.c (tui_set_layout): Update.
1784         * tui/tui-data.h (struct tui_layout_def): Remove.
1785         (tui_layout_def): Don't declare.
1786         * tui/tui-data.c (layout_def): Remove.
1787         (tui_layout_def): Remove.
1788
1789 2019-08-13  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-winsource.h (struct tui_source_window_base)
1792         <clear_detail>: No longer "override".
1793         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1794         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1795         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1796         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1797         Remove.
1798         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1799
1800 2019-08-13  Tom Tromey  <tromey@adacore.com>
1801
1802         * tracepoint.c: Don't include readline.h or history.h.
1803
1804 2019-08-12  Tom Tromey  <tom@tromey.com>
1805
1806         * configure: Rebuild.
1807         * configure.ac: Check for readline 7.
1808         * NEWS: Mention readline 7 requirement.
1809         * README: Update.
1810
1811 2019-08-12  Tom Tromey  <tom@tromey.com>
1812
1813         * mingw-hdep.c (gdb_select): Remove readline hack.
1814
1815 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1816
1817         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1818         when the function fails.
1819
1820 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1821
1822         * s390-tdep.c (s390_type_align): New function.
1823         (s390_gdbarch_init): Set it as type_align gdbarch method.
1824
1825 2019-08-09  Tom de Vries  <tdevries@suse.de>
1826
1827         PR gdb/24591
1828         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1829         pc_low with relocation offset.
1830
1831 2019-08-07  Tom Tromey  <tromey@adacore.com>
1832
1833         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1834         (print_frame_args): Update.
1835         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1836         Update.
1837         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1838         * frame.h (struct frame_arg): Add initializers.
1839         <error>: Now a unique_xmalloc_ptr.
1840
1841 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1842
1843         * NEWS: Expand the Pointer Authentication entry.
1844         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1845         (aarch64_frame_unmask_lr): ... to this.
1846         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1847         Call aarch64_frame_unmask_lr.
1848         * frame.c (struct frame_info): Add "masked" variable.
1849         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1850         (fprint_frame): Check for masked pc.
1851         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1852         declarations.
1853         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1854         * stack.c (print_frame): Check for masked pc.
1855
1856 2019-08-06  Tom Tromey  <tom@tromey.com>
1857
1858         * stabsread.c (patch_block_stabs, read_one_struct_field)
1859         (read_enum_type): Use obstack_strndup.
1860         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1861         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1862         * dwarf2read.c (guess_full_die_structure_name)
1863         (anonymous_struct_prefix): Use obstack_strndup.
1864         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1865         * c-exp.y (yylex): Use obstack_strndup.
1866         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1867         (write_var_or_type): Use obstack_strndup.
1868
1869 2019-08-06  Tom Tromey  <tom@tromey.com>
1870
1871         * symfile.c (reread_symbols): Use obstack_strdup.
1872         * stabsread.c (read_type): Use obstack_strdup.
1873         * gdb_obstack.h (obstack_strdup): New overload.
1874         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1875         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1876         (dwarf2_canonicalize_name): Use obstack_strdup.
1877         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1878         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1879         Use obstack_strdup.
1880
1881 2019-08-06  Tom Tromey  <tom@tromey.com>
1882
1883         * gdb_obstack.h (obstack_strdup): Define.
1884         * gdb_obstack.c (obstack_strdup): Don't define.
1885
1886 2019-08-06  Tom Tromey  <tom@tromey.com>
1887
1888         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1889         obstack_strdup.
1890         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1891         obstack_strdup.
1892         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1893         * stabsread.c (common_block_start): Use obstack_strdup.
1894         * objfiles.c (set_objfile_main_name, objfile): Use
1895         obstack_strdup.
1896         * namespace.c (add_using_directive): Use obstack_strdup.
1897         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1898         * jit.c (finalize_symtab): Use obstack_strdup.
1899         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1900         (guess_partial_die_structure_name, partial_die_info::fixup)
1901         (dwarf2_name): Use obstack_strdup.
1902         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1903         obstack_strdup.
1904         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1905         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1906         obstack_strdup.
1907         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1908
1909 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1910
1911         * unittests/help-doc-selftests.c: New file.
1912         * Makefile.in: Add the new file.
1913
1914 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1915
1916         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1917         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1918         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1919         the trailing '.' is not output, and the first character is uppercased.
1920         (print_help_for_command): Update call to print_doc_line.
1921         (print_doc_of_command): Likewise.
1922         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1923         * cli/cli-option.c (append_indented_doc): Do not append newline.
1924         (build_help_option): Append newline after first appended_indented_doc
1925         only if a second call is done.
1926         (build_help): Append 2 new lines before each option, except the first
1927         one.
1928         * compile/compile.c (_initialize_compile): Add new lines after
1929         %OPTIONS%, when not at the end of the help.
1930         Change help doc or code
1931         producing the help doc to respect the invariants.
1932         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1933         Also removed the new line after 'Options:', as all other commands
1934         do not put an empty line between 'Options:' and the first option.
1935         * printcmd.c (_initialize_printcmd): Likewise.
1936         * stack.c (_initialize_stack): Likewise.
1937         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1938         incorrectly telling COMMAND is optional.
1939         * ada-lang.c (_initialize_ada_language): Change help doc or code
1940         producing the help doc to respect the invariants.
1941         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1942         * breakpoint.c (_initialize_breakpoint): Likewise.
1943         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1944         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1945         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1946         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1947         _initialize_cli_style): Likewise.
1948         * corelow.c (core_target_info): Likewise.
1949         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1950         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1951         * filesystem.c (_initialize_filesystem): Likewise.
1952         * frame.c (_initialize_frame): Likewise.
1953         * gnu-nat.c (add_task_commands): Likewise.
1954         * infcall.c (_initialize_infcall): Likewise.
1955         * infcmd.c (_initialize_infcmd): Likewise.
1956         * interps.c (_initialize_interpreter): Likewise.
1957         * language.c (_initialize_language): Likewise.
1958         * linux-fork.c (_initialize_linux_fork): Likewise.
1959         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1960         * maint.c (_initialize_maint_cmds): Likewise.
1961         * memattr.c (_initialize_mem): Likewise.
1962         * printcmd.c (_initialize_printcmd): Likewise.
1963         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1964         _RegEx): Likewise.
1965         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1966         * record-btrace.c (_initialize_record_btrace): Likewise.
1967         * record-full.c (_initialize_record_full): Likewise.
1968         * record.c (_initialize_record): Likewise.
1969         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1970         * regcache.c (_initialize_regcache): Likewise.
1971         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1972         _initialize_remote): Likewise.
1973         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1974         * serial.c (_initialize_serial): Likewise.
1975         * skip.c (_initialize_step_skip): Likewise.
1976         * source.c (_initialize_source): Likewise.
1977         * stack.c (_initialize_stack): Likewise.
1978         * symfile.c (_initialize_symfile): Likewise.
1979         * symtab.c (_initialize_symtab): Likewise.
1980         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1981         * top.c (init_main): Likewise.
1982         * tracefile-tfile.c (tfile_target_info): Likewise.
1983         * tracepoint.c (_initialize_tracepoint): Likewise.
1984         * tui/tui-win.c (_initialize_tui_win): Likewise.
1985         * utils.c (add_internal_problem_command): Likewise.
1986         * valprint.c (value_print_option_defs): Likewise.
1987
1988 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1989
1990         PR build/24886
1991         * configure.ac: Drop enable-libmcheck support.
1992         * configure, config.in: Rebuild.
1993         * libmcheck.m4: Remove.
1994         * acinclude.m4: Don't include it.
1995         * Makefile.in: Don't distribute it.
1996         * top.c (print_gdb_configuration): Don't mention it.
1997
1998 2019-08-06  Tom Tromey  <tom@tromey.com>
1999
2000         * utils.c (set_output_style): Sometimes pass stream to
2001         emit_style_escape.
2002         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2003         * record-btrace.c (btrace_insn_history): Update.
2004         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2005         method.
2006         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2007         Update initializers.
2008         <m_uiout>: New field.
2009         <m_di>: Move lower.
2010         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2011         Remove "uiout" parameter.
2012         (dump_insns): Update.
2013         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2014         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2015
2016 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2017
2018         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2019         (error_in_psymtab_expansion): Likewise.
2020         (lookup_symbol_via_quick_fns): Likewise.
2021         (basic_lookup_transparent_type_quick): Likewise.
2022         (basic_lookup_transparent_type_1): Likewise.
2023
2024 2019-08-06  Tom Tromey  <tromey@adacore.com>
2025
2026         * source.c (last_source_error): Now bool.
2027         (print_source_lines_base): Make "noprint" bool.  Only open
2028         source file when last_source_visited changes.
2029
2030 2019-08-06  Tom Tromey  <tromey@adacore.com>
2031
2032         * annotate.c (annotate_source_line): Use g_source_cache.
2033         * source-cache.c (source_cache::get_plain_source_lines): Change
2034         parameters.  Populate m_offset_cache.
2035         (source_cache::ensure): New method.
2036         (source_cache::get_line_charpos): New method.
2037         (extract_lines): Move lower.  Change parameters.
2038         (source_cache::get_source_lines): Move lower.
2039         * source-cache.h (class source_cache): Update comment.
2040         <get_line_charpos>: New method.
2041         <get_source_lines>: Update comment.
2042         <clear>: Clear m_offset_cache.
2043         <get_plain_source_lines>: Change parameters.
2044         <ensure>: New method
2045         <m_offset_cache>: New member.
2046         * source.c (forget_cached_source_info_for_objfile): Update.
2047         (info_source_command): Use g_source_cache.
2048         (find_source_lines, open_source_file_with_line_charpos): Remove.
2049         (print_source_lines_base, search_command_helper): Use g_source_cache.
2050         * source.h (open_source_file_with_line_charpos): Don't declare.
2051         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2052         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2053         Use g_source_cache.
2054
2055 2019-08-06  Tom Tromey  <tromey@adacore.com>
2056
2057         * source-cache.c (source_cache::get_plain_source_lines):
2058         Remove "first_line" and "last_line" parameters.
2059         (source_cache::get_source_lines): Cache plain text.
2060         * source-cache.h (class source_cache)
2061         <get_plain_source_lines>: Update.
2062
2063 2019-08-06  Tom Tromey  <tromey@adacore.com>
2064
2065         * source-cache.c (extract_lines): No longer a method.
2066         Changed type of parameter.  Include final newline.
2067         (selftests::extract_lines_test): New function.
2068         (_initialize_source_cache): Likewise.
2069         * source-cache.h (class source_cache)
2070         <extract_lines>: Don't declare.
2071
2072 2019-08-06  Tom Tromey  <tromey@adacore.com>
2073
2074         * breakpoint.c (init_breakpoint_sal): Update.
2075         (breakpoint): Update.
2076         * breakpoint.h (struct breakpoint) <filter>: Now a
2077         unique_xmalloc_ptr.
2078
2079 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2080
2081         * NEWS: Mention dictionary access on blocks.
2082         * python/py-block.c (blpy_getitem): New function.
2083         (block_object_as_mapping): New struct.
2084         (block_object_type): Use new struct for tp_as_mapping field.
2085
2086 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2087
2088         * objfiles.h (objfile): Add a comment describing partial symbols.
2089
2090 2019-08-05  Tom Tromey  <tromey@adacore.com>
2091
2092         * compile/compile.c (_initialize_compile): Use _(), not N_().
2093         * thread.c (_initialize_thread): Use _(), not N_().
2094         * stack.c (_initialize_stack): Use _(), not N_().
2095         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2096
2097 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2098
2099         * dwarf2read.c (struct dw2_symtab_iterator):
2100         <want_specific_block>: Remove.
2101         <block_index>: Change type to gdb::optional.
2102         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2103         change type of BLOCK_INDEX parameter to gdb::optional.
2104         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2105         (dw2_lookup_symbol): Don't pass argument for
2106         WANT_SPECIFIC_BLOCK.
2107         (dw2_expand_symtabs_for_function): Don't pass argument for
2108         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2109         (class dw2_debug_names_iterator)
2110         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2111         parameter, change BLOCK_INDEX type to gdb::optional.
2112         <m_want_specific_block>: Remove.
2113         <m_block_index>: Change type to gdb::optional.
2114         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2115         gdb::optional.  Re-write in function of gdb::optional.
2116         (dw2_debug_names_lookup_symbol): Don't pass argument for
2117         WANT_SPECIFIC_BLOCK.
2118         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2119         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2120         BLOCK_INDEX.
2121
2122 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2123
2124         * NEWS: Mention changes to "info sources" command.
2125
2126 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2127
2128         * symtab.c (filename_partial_match_opts): New struct type.
2129         (struct output_source_filename_data): New members
2130         regexp, c_regexp, partial_match.
2131         (output_source_filename): Use new members to decide to print file.
2132         (info_sources_option_defs): New variable.
2133         (make_info_sources_options_def_group, print_info_sources_header,
2134         info_sources_command_completer):
2135         New functions.
2136         (info_sources_command): Read new optional arguments.
2137         (_initialize_symtab): Update info sources help.
2138
2139 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2140
2141         * ada-lang.c (exception_support_info_v0): Renamed from...
2142         (default_exception_support_info): ... this.  Create new
2143         definition for v1.
2144         (ada_has_this_exception_support): Look up catch_handlers_sym.
2145         (ada_exception_support_info_sniffer): Try v0 after default.
2146
2147 2019-08-01  Tom Tromey  <tromey@adacore.com>
2148
2149         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2150         gdbarch.h.
2151
2152 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2153
2154         * s12z-tdep.c: Fix include path for s12z-opc.h.
2155
2156 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2157
2158         * NEWS: Require GNU make 3.82.
2159
2160 2019-07-16  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2163         declare.
2164
2165 2019-07-30  Tom Tromey  <tromey@adacore.com>
2166
2167         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2168
2169 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2170
2171         * printcmd.c (print_address_symbolic): Print negative offsets.
2172         (build_address_symbolic): Force signed arithmetic when computing
2173         offset.
2174
2175 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2176
2177         PR/24474: Add a function to lookup static variables.
2178         * NEWS: Mention this new function.
2179         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2180         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2181         * python/python.c (python_GdbMethods): Add new function.
2182
2183 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2184
2185         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2186         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2187         (objfpy_lookup_static_symbol): New function.
2188         (objfile_object_methods): Add new functions.
2189
2190 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2191
2192         * NEWS: Mention 'set|show print frame-info'.  Mention new
2193         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2194         backtrace argument.  Mention that python frame filtering code
2195         is now consistent with what 'backtrace' command prints.
2196
2197 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2198
2199         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2200         comments.
2201         (print_frame_info_auto, print_frame_info_source_line,
2202         print_frame_info_location, print_frame_info_source_and_location,
2203         print_frame_info_location_and_address, print_frame_info_short_location):
2204         New declarations.
2205         (struct frame_print_options): New member print_frame_info.
2206         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2207         * stack.h (get_user_print_what_frame_info): New declaration.
2208         (frame_show_address): New declaration.
2209         * stack.c (print_frame_arguments_choices): New value 'presence'.
2210         (print_frame_info_auto, print_frame_info_source_line,
2211         print_frame_info_location, print_frame_info_source_and_location,
2212         print_frame_info_location_and_address, print_frame_info_short_location,
2213         print_frame_info_choices, print_frame_info_print_what): New definitions.
2214         (print_frame_args): Only print dots for args if print frame-arguments
2215         is 'presence'.
2216         (frame_print_option_defs): New element for "frame-info".
2217         (get_user_print_what_frame_info): New function.
2218         (frame_show_address): Make non static.  Move comment to stack.h.
2219         (print_frame_info_to_print_what): New function.
2220         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2221         to decide what to print.
2222         (backtrace_command_1): Handle the new print_frame_arguments_presence
2223         value.
2224         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2225         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2226         (py_print_frame): In non-mi mode, use LOCATION as default for
2227         print_what, similarly to frame information printed directly by
2228         backtrace command. Handle frame-info user option in non MI mode.
2229
2230 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2231
2232         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2233         Add case for debugging 32-bit target on 64-bit host.  Revise
2234         comment.
2235
2236 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2237
2238         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2239         instead of find_function_entry_range_from_pc.
2240
2241 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2242
2243         * stack.c (find_frame_funname): Remove code which preferred
2244         minsym over symtab sym in "certain pathological cases".
2245
2246         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2247         parameter.  Change type of "do_demangle" to bool.
2248         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2249         Pass suitable "prefer_sym_over_minsym" flag to
2250         build_address_symbolic().  Don't output "+" for negative offsets.
2251         * printcmd.c (print_address_symbolic): Update invocation of
2252         build_address_symbolic to include a "prefer_sym_over_minsym"
2253         flag.
2254         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2255         Restrict cases in which use of minimal symbol is preferred to that
2256         of a found symbol.  Update comments.
2257
2258         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2259         for entry pc when entry pc is out of range for that FDE.
2260
2261 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2262
2263         PR gdb/24839:
2264         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2265         type.
2266
2267 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2268
2269         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2270         this function's Python signature.
2271
2272
2273 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2274
2275         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2276         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2277         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2278         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2279         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2280
2281
2282 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2283
2284         * h8300-tdep.c (h8300_register_name_common): New.
2285         h8300_register_name): Use h8300_register_name_common.
2286         (h8300s_register_name): Likewise.
2287         (h8300sx_register_name): Likewise.
2288         (h8300h_register_nam): New.
2289         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2290
2291
2292 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2293
2294         * arm-tdep.c (arm_skip_cmse_entry): New function.
2295         (arm_is_sgstubs_section): New function.
2296         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2297
2298 2019-07-22  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2301         Don't self-assign.
2302
2303 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2306         type_print.
2307
2308 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2311         so that GDB doesn't match any msymbols when searching in the
2312         TYPES_DOMAIN.
2313         (print_symbol_info): Print using typedef_print or type_print based
2314         on the type of the symbol.  Add updated FIXME comment moved from...
2315         (_initialize_symtab): ... move and update FIXME comment to above.
2316
2317 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * NEWS: Mention adding -q option to "info types".
2320         * symtab.c (struct info_types_options): New struct.
2321         (info_types_options_defs): New variable.
2322         (make_info_types_options_def_group): New function.
2323         (info_types_command): Use gdb::option framework to parse options.
2324         (info_types_command_completer): New function.
2325         (_initialize_symtab): Extend the help text on "info types" and
2326         register command completer.
2327
2328 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2329
2330         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2331         (lookup_symbol_in_objfile): Change int to block_enum and add a
2332         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2333
2334 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2335
2336         * MAINTAINERS (Write After Approval): Add self.
2337
2338 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2341         instruction to the dummy code region.
2342
2343 2019-07-19  Tom Tromey  <tromey@adacore.com>
2344
2345         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2346         (ARGSUSED, PARAMS, __func__): Remove rules.
2347
2348 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2349
2350         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2351         * features/arm/arm-with-iwmmxt.c: Remove.
2352         * features/arm/arm-with-iwmmxt.xml: Remove.
2353         * features/arm/arm-with-m-fpa-layout.c: Remove.
2354         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2355         * features/arm/arm-with-m-vfp-d16.c: Remove.
2356         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2357         * features/arm/arm-with-m.c: Remove.
2358         * features/arm/arm-with-m.xml: Remove.
2359         * features/arm/arm-with-neon.c: Remove.
2360         * features/arm/arm-with-neon.xml: Remove.
2361         * features/arm/arm-with-vfpv2.c: Remove.
2362         * features/arm/arm-with-vfpv2.xml: Remove.
2363         * features/arm/arm-with-vfpv3.c: Remove.
2364         * features/arm/arm-with-vfpv3.xml: Remove.
2365
2366 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2367
2368         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2369
2370 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2371
2372         * arch/aarch32.c (aarch32_create_target_description): Create
2373         target descriptions using features.
2374         * arch/arm.c (arm_create_target_description)
2375         (arm_create_mprofile_target_description): Likewise.
2376         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2377
2378 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2379
2380         * Makefile.in: Add new files.
2381         * aarch32-tdep.c: New file.
2382         * aarch32-tdep.h: New file.
2383         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2384         Call aarch32_read_description.
2385         * arch/aarch32.c: New file.
2386         * arch/aarch32.h: New file.
2387         * arch/arm.c (arm_create_target_description)
2388         (arm_create_mprofile_target_description): New function.
2389         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2390         (arm_create_target_description)
2391         (arm_create_mprofile_target_description): New declaration.
2392         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2393         read_description functions.
2394         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2395         Likewise.
2396         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2397         * arm-tdep.c (tdesc_arm_list): New variable.
2398         (arm_register_g_packet_guesses): Call create description functions.
2399         (arm_read_description) (arm_read_mprofile_description): New
2400         function.
2401         * arm-tdep.h (arm_read_description)
2402         (arm_read_mprofile_description): Add declaration.
2403         * configure.tgt: Add new files.
2404
2405 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2406
2407         * top.c (new_ui_command): Open specified terminal just once.
2408
2409 2019-07-18  Tom Tromey  <tromey@adacore.com>
2410
2411         * symtab.c (main_name): Constify return type.
2412         * symfile.c (set_initial_language): Update.
2413         * symtab.h (main_name): Constify return type.
2414
2415 2019-07-17  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-winsource.c (tui_update_source_window)
2418         (tui_update_source_window_as_is)
2419         (tui_update_source_windows_with_line): Remove return.
2420         * tui/tui-disasm.c (tui_show_disassem)
2421         (tui_show_disassem_and_update_source): Remove return.
2422         * tui/tui.c (tui_reset): Remove return.
2423         * tui/tui-wingeneral.c
2424         (tui_check_and_display_highlight_if_needed): Remove return.
2425
2426 2019-07-17  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2429
2430 2019-07-17  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-winsource.h (struct tui_exec_info_window)
2433         (struct tui_source_window_base): Move from tui-data.h.
2434         * tui/tui-winsource.c: Move many method definitions from
2435         elsewhere.  Remove "structuring" comments.
2436         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2437         (tui_source_window_base::refresh_window): Move to
2438         tui-winsource.c.
2439         * tui/tui-win.c (tui_source_window_base::refresh_all)
2440         (tui_source_window_base::update_tab_width)
2441         (tui_source_window_base::set_new_height)
2442         (tui_source_window_base::do_make_visible_with_new_height): Move to
2443         tui-winsource.c.
2444         * tui/tui-source.h: Update.
2445         * tui/tui-source.c (tui_source_window_base::reset): Move to
2446         tui-winsource.c.
2447         * tui/tui-disasm.h: Update.
2448         * tui/tui-data.h (struct tui_exec_info_window): Move to
2449         tui-winsource.h.
2450         (struct tui_source_window_base): Likewise.
2451         * tui/tui-data.c (tui_source_window_base::clear_detail)
2452         (tui_source_window_base, ~tui_source_window_base): Move to
2453         tui-winsource.c.
2454
2455 2019-07-17  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-win.c (tui_resize_all)
2458         (tui_source_window_base::update_tab_width)
2459         (tui_adjust_win_heights): Update.
2460         (tui_win_info::make_invisible_and_set_new_height): Rename from
2461         make_invisible_and_set_new_height.
2462         * tui/tui-data.h (struct tui_win_info)
2463         <make_invisible_and_set_new_height>: New method.
2464
2465 2019-07-17  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui.c: Update.
2468         * tui/tui-source.h (struct tui_source_window): Move from
2469         tui-data.h.
2470         * tui/tui-layout.c: Update.
2471         * tui/tui-disasm.c: Update.
2472         * tui/tui-data.h (struct tui_source_window): Move to
2473         tui-source.h.
2474
2475 2019-07-17  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2478         tui-data.h.
2479         * tui/tui-data.h (struct tui_disasm_window): Move to
2480         tui-disasm.h.
2481
2482 2019-07-17  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-regs.h (struct tui_data_item_window): Move from
2485         tui-data.h.
2486         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2487         * tui/tui-data.h (struct tui_data_item_window): Move to
2488         tui-regs.h.
2489         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2490
2491 2019-07-17  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui.c: Update.
2494         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2495         (tui_cmd_window::max_height): Move to tui-command.c.
2496         * tui/tui-layout.c: Update.
2497         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2498         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2499         tui-command.c.
2500         * tui/tui-command.h (struct tui_cmd_window): Move from
2501         tui-data.h.
2502         * tui/tui-command.c: Remove "structuring" comments.
2503         (tui_cmd_window::clear_detail)
2504         (tui_cmd_window::do_make_visible_with_new_height)
2505         (tui_cmd_window::max_height): Move from elsewhere.
2506
2507 2019-07-17  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2510         Now static.
2511         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2512         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2513
2514 2019-07-17  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui.c: Update.
2517         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2518         tui-regs.c.
2519         * tui/tui-windata.h: Remove file.
2520         * tui/tui-windata.c: Remove file.
2521         * tui/tui-win.c (tui_data_window::set_new_height)
2522         (tui_data_window::do_make_visible_with_new_height): Move to
2523         tui-regs.c.
2524         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2525         * tui/tui-regs.c: Remove "structuring" comments.
2526         (tui_data_window::first_data_item_displayed)
2527         (tui_data_window::delete_data_content_windows)
2528         (tui_data_window::erase_data_content)
2529         (tui_data_window::display_all_data)
2530         (tui_data_window::refresh_all)
2531         (tui_data_window::do_scroll_vertical)
2532         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2533         (tui_data_window::do_make_visible_with_new_height)
2534         (tui_data_window::refresh_window): Move from elsewhere.
2535         (_initialize_tui_regs): Move to end of file.
2536         * tui/tui-layout.c: Update.
2537         * tui/tui-hooks.c: Update.
2538         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2539         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2540         tui-regs.c.
2541         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2542
2543 2019-07-17  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2546         seen.
2547
2548 2019-07-17  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-win.c (tui_source_window_base::set_new_height)
2551         (tui_source_window_base::do_make_visible_with_new_height): Use
2552         m_has_locator field directly.
2553         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2554         method.
2555         (struct tui_source_window_base) <has_locator>: Likewise.
2556
2557 2019-07-17  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2560         Don't declare.
2561         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2562         Remove.
2563         * tui/tui-win.c (tui_source_window_base::set_new_height)
2564         (tui_source_window_base::set_new_height)
2565         (make_invisible_and_set_new_height)
2566         (tui_source_window_base::do_make_visible_with_new_height)
2567         (tui_source_window_base::do_make_visible_with_new_height):
2568         Update.
2569         * tui/tui-layout.c (show_source_disasm_command, show_data)
2570         (show_source_or_disasm_and_command): Update.
2571         * tui/tui-layout.c (show_layout): Update.
2572
2573 2019-07-17  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-layout.c (make_data_window): Remove.
2576         (show_data): Unify creation and re-initialization cases.
2577
2578 2019-07-17  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-layout.c (make_source_window, make_disasm_window):
2581         Remove.
2582         (show_data): Unify creation and re-initialization cases.
2583
2584 2019-07-17  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-layout.c (make_command_window): Remove.
2587         (show_source_disasm_command, show_source_or_disasm_and_command):
2588         Unify creation and re-initialization cases.
2589
2590 2019-07-17  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2593         creation and re-initialization cases.
2594
2595 2019-07-17  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-regs.c (tui_get_register): Return void.
2598
2599 2019-07-17  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2602         Simplify.
2603
2604 2019-07-17  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2607         resetting.
2608
2609 2019-07-17  Tom Tromey  <tom@tromey.com>
2610
2611         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2612         * tui/tui-regs.c (tui_reg_layout): New function.
2613         (tui_show_registers, tui_reg_command): Use it.
2614         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2615         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2616         parameters.
2617         (tui_layout_command): Remove.
2618
2619 2019-07-17  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-layout.h (tui/tui-layout): Return void.
2622         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2623
2624 2019-07-17  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-layout.c (show_source_disasm_command, show_data):
2627         Update.
2628         (reset_locator): Remove.
2629         (show_source_or_disasm_and_command): Update.
2630
2631 2019-07-17  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-source.c (tui_source_window_base::reset): Remove
2634         win_type parameter.
2635         * tui/tui-layout.c (make_command_window, make_source_window)
2636         (make_disasm_window, make_data_window)
2637         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2638         (reset_locator, show_source_or_disasm_and_command): Update.
2639         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2640         win_type parameter.
2641         (struct tui_source_window_base) <reset>: Likewise.
2642
2643 2019-07-17  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-layout.c (show_source_disasm_command): Use
2646         reset_locator.
2647         (reset_locator): New function.
2648         (init_and_make_win): Remove.
2649         (show_source_or_disasm_and_command): Use reset_locator.
2650
2651 2019-07-17  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2654         condition.
2655         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2656         Remove condition.
2657         * tui/tui-source.c (tui_source_window_base::reset): New method.
2658         * tui/tui-layout.c (make_command_window): Don't call
2659         init_and_make_win.
2660         (make_source_window, make_disasm_window): Don't call
2661         make_source_or_disasm_window.
2662         (make_data_window): Don't call init_and_make_win.  Change calling
2663         convention.
2664         (show_source_disasm_command, show_data): Simplify.
2665         (make_source_or_disasm_window): Remove.
2666         (show_source_or_disasm_and_command): Simplify.
2667         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2668         (struct tui_source_window_base) <reset>: Likewise.
2669         <execution_info>: Remove initializer.
2670         * tui/tui-data.c (tui_source_window_base): Initialize
2671         execution_info.
2672
2673 2019-07-17  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2676         variable.
2677
2678 2019-07-17  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui.c (tui_rl_other_window): Update.
2681         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2682         superclass method first.  Always iterate over regs_content.
2683         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2684         method.
2685         * tui/tui-win.c (tui_set_focus_command): Update.
2686
2687 2019-07-17  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-win.c (tui_set_focus_command): Rename from
2690         tui_set_focus.  Call tui_enable.
2691         (tui_set_focus_command): Remove.
2692
2693 2019-07-17  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2696         refresh_window.
2697         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2698         touchwin.
2699         (tui_data_window::refresh_window): Call refresh_window on data
2700         items.  Always call superclass refresh_window.
2701         (tui_win_info::refresh): Remove.
2702         (tui_source_window_base::refresh_window): Update.
2703         (tui_refresh_all): Update.
2704         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2705         refresh_window.
2706         (show_source_or_disasm_and_command): Likewise.
2707         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2708         (struct tui_source_window_base) <refresh>: Likewise.
2709
2710 2019-07-17  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-winsource.c (tui_clear_source_content)
2713         (tui_show_source_content): Update.
2714         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2715         whether content is empty.
2716         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2717         Remove.
2718
2719 2019-07-17  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2722         window's contents.
2723         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2724         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2725
2726 2019-07-17  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2729         (struct tui_data_item_window): Update.
2730
2731 2019-07-17  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2734         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2735         defines.
2736
2737 2019-07-17  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-winsource.h (tui_erase_source_content)
2740         (tui_clear_source_content): Remove "display_prompt" parameter.
2741         * tui/tui-winsource.c (tui_update_source_window_as_is)
2742         (tui_update_source_windows_with_addr): Update.
2743         (tui_clear_source_content): Remove "display_prompt" parameter.
2744         (tui_erase_source_content): Likewise.  Simplify.
2745         (tui_show_source_content): Update.
2746         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2747         * tui/tui-stack.c (tui_show_frame_info): Update.
2748         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2749         Remove defines.
2750
2751 2019-07-17  Tom Tromey  <tom@tromey.com>
2752
2753         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2754         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2755         parameter.
2756         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2757         parameter.
2758
2759 2019-07-17  Tom Tromey  <tom@tromey.com>
2760
2761         * tui/tui-winsource.c (tui_clear_source_content)
2762         (tui_show_source_content, tui_show_exec_info_content)
2763         (tui_clear_exec_info_content): Update.
2764         * tui/tui-stack.c (tui_show_locator_content): Update.
2765         (tui_show_frame_info): Update.
2766         * tui/tui-source.h (tui_source_window): Don't declare.
2767         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2768         from tui_source_is_displayed.
2769         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2770         Remove field.
2771         (struct tui_source_window_base) <content_in_use>: New field.  Now
2772         bool.
2773         (struct tui_source_window) <showing_source_p>: New method.
2774         (TUI_SRC_WIN): Change cast.
2775         * tui/tui-data.c (tui_initialize_static_data): Update.
2776
2777 2019-07-17  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2780         location_matches_p.
2781         * tui/tui-source.c (tui_source_window::location_matches_p): New
2782         method.
2783         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2784         method.
2785         * tui/tui-data.h (struct tui_source_window_base)
2786         <location_matches_p>: New method.
2787         (struct tui_source_window, struct tui_disasm_window)
2788         <location_matches_p>: Likewise.
2789
2790 2019-07-17  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-win.c (tui_set_win_height_command): Rename from
2793         tui_set_win_height.
2794         (tui_set_win_height_command): Remove.
2795
2796 2019-07-17  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-source.c (tui_source_window): New constructor.  Add
2799         observer.
2800         (~tui_source_window): New destructor.
2801         (tui_source_window::style_changed): New method.
2802         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2803         (tui_attach_detach_observers): Update.
2804         * tui/tui-data.h (struct tui_source_window): Make constructor not
2805         inline.  Add destructor.
2806         (struct tui_source_window) <style_changed>: New method.
2807         <m_observable>: New member.
2808
2809 2019-07-17  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2812         * tui/tui-win.c (tui_resize_all): Fix typo.
2813
2814 2019-07-17  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2817         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2818         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2819         * tui/tui-win.c (window_name_completer): Use foreach.
2820         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2821         (update_tab_width): Likewise.
2822         * tui/tui-layout.c (show_layout): Update.
2823         * tui/tui-data.h (class tui_window_iterator): New.
2824         (struct all_tui_windows): New.
2825         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2826
2827 2019-07-17  Tom Tromey  <tom@tromey.com>
2828
2829         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2830         parameter.  Don't reference globals.
2831         (tui_reg_command): Update.
2832
2833 2019-07-17  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-regs.c (tui_show_registers): Simplify.
2836
2837 2019-07-17  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-regs.c (tui_show_registers): Update.
2840         (tui_show_register_group): Add win_info parameter.
2841
2842 2019-07-17  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2845         Rename from tui_display_reg_element_at_line.
2846         (tui_data_window::display_registers_from_line): Update.
2847         * tui/tui-data.h (struct tui_data_window)
2848         <display_reg_element_at_line>: New method.
2849
2850 2019-07-17  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-regs.h (tui_display_registers_from)
2853         (tui_display_registers_from_line): Don't declare.
2854         * tui/tui-windata.c (tui_data_window::display_all_data)
2855         (tui_data_window::refresh_all)
2856         (tui_data_window::do_scroll_vertical): Update.
2857         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2858         from tui_display_registers_from.
2859         (tui_display_reg_element_at_line): Update.
2860         (tui_data_window::display_registers_from_line): Rename from
2861         tui_display_registers_from_line.
2862         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2863         display_registers_from_line>: New methods.
2864
2865 2019-07-17  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2868         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2869         from tui_erase_data_content.
2870         (tui_data_window::display_all_data)
2871         (tui_data_window::refresh_all)
2872         (tui_data_window::do_scroll_vertical): Update.
2873         * tui/tui-regs.c (tui_show_registers): Update.
2874         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2875         New method.
2876
2877 2019-07-17  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2880         declare.
2881         * tui/tui-windata.c
2882         (tui_data_window::delete_data_content_windows): Rename from
2883         tui_delete_data_content_windows.
2884         (tui_data_window::display_all_data)
2885         (tui_data_window::do_scroll_vertical): Update.
2886         * tui/tui-data.h (struct tui_data_window)
2887         <delete_data_content_windows>: New method.
2888
2889 2019-07-17  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2892         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2893
2894 2019-07-17  Tom Tromey  <tom@tromey.com>
2895
2896         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2897         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2898         from tui_display_all_data.
2899         * tui/tui-win.c
2900         (tui_data_window::do_make_visible_with_new_height): Update.
2901         * tui/tui-regs.c (tui_show_registers): Update.
2902         * tui/tui-layout.c (tui_set_layout): Update.
2903         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2904         method.
2905
2906 2019-07-17  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2909         * tui/tui-windata.c (tui_display_data_from): Remove.
2910         (tui_data_window::refresh_all): Update.
2911
2912 2019-07-17  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2915         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2916         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2917         tui_display_registers_from_line.
2918         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2919         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2920         "force_display" parameter.
2921
2922 2019-07-17  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2925         declare.
2926         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2927         Rename from tui_first_reg_element_no_inline.
2928         (tui_display_reg_element_at_line)
2929         (tui_display_registers_from_line): Update.
2930         * tui/tui-data.h (struct tui_data_window)
2931         <first_reg_element_no_inline>: New method.
2932
2933 2019-07-17  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-windata.c (tui_display_data_from)
2936         (tui_data_window::do_scroll_vertical): Update.
2937         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2938         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2939         Rename from tui_line_from_reg_element_no.
2940         (tui_display_registers_from_line): Update.
2941         * tui/tui-data.h (struct tui_data_window)
2942         <line_from_reg_element_no>: New method.
2943
2944 2019-07-17  Tom Tromey  <tom@tromey.com>
2945
2946         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2947         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2948         tui_last_regs_line_no.
2949         (tui_display_reg_element_at_line)
2950         (tui_display_registers_from_line): Update.
2951         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2952         method.
2953
2954 2019-07-17  Tom Tromey  <tom@tromey.com>
2955
2956         PR tui/24722:
2957         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2958         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2959         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2960         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2961         (tui_update_breakpoint_info): Likewise.
2962         * tui/tui-hooks.c (tui_event_create_breakpoint)
2963         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2964         Update.
2965
2966 2019-07-17  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2969
2970 2019-07-17  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-winsource.c (tui_update_source_window_as_is)
2973         (tui_update_source_windows_with_addr): Update.
2974         * tui/tui-source.h (tui_set_source_content)
2975         (tui_show_symtab_source): Add "win_info" parameter.
2976         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2977         parameter.
2978         (tui_show_symtab_source): Likewise.
2979
2980 2019-07-17  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-wingeneral.c
2983         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2984
2985 2019-07-17  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2988         (struct tui_cmd_window) <can_scroll>: New method.
2989         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2990         method.
2991
2992 2019-07-17  Tom Tromey  <tromey@adacore.com>
2993
2994         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2995         do_field_signed>: Rename.  Change type of "value".
2996         * ui-out.c (ui_out::field_signed): Rename from field_int.
2997         Change type of "value".
2998         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2999         type of "value".
3000         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3001         do_field_int.  Change type of "value".
3002         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3003         do_field_int.  Change type of "value".
3004         * tracepoint.c (trace_status_mi, tfind_1)
3005         (print_one_static_tracepoint_marker): Update.
3006         * thread.c (print_thread_info_1, print_selected_thread_frame):
3007         Update.
3008         * stack.c (print_frame, print_frame_info): Update.
3009         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3010         Update.
3011         * source.c (print_source_lines_base): Update.
3012         * skip.c (info_skip_command): Update.
3013         * record-btrace.c (btrace_ui_out_decode_error)
3014         (btrace_call_history_src_line): Update.
3015         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3016         Update.
3017         * progspace.c (print_program_space): Update.
3018         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3019         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3020         do_field_int.  Change type of "value".
3021         * mi/mi-out.c (mi_ui_out::do_table_begin)
3022         (mi_ui_out::do_table_header): Update.
3023         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3024         type of "value".
3025         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3026         (mi_cmd_data_list_changed_registers, output_register)
3027         (mi_cmd_data_read_memory, mi_load_progress)
3028         (mi_cmd_trace_frame_collected): Update.
3029         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3030         Update.
3031         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3032         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3033         (mi_cmd_var_list_children, varobj_update_one): Update.
3034         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3035         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3036         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3037         * inferior.c (print_inferior): Update.
3038         * gdb_bfd.c (print_one_bfd): Update.
3039         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3040         Update.
3041         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3042         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3043         do_field_int.  Change type of "value".
3044         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3045         do_field_int.  Change type of "value".
3046         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3047         (print_one_breakpoint_location, print_it_catch_fork)
3048         (print_one_catch_fork, print_it_catch_vfork)
3049         (print_one_catch_vfork, print_it_catch_solib)
3050         (print_it_catch_exec, print_it_ranged_breakpoint)
3051         (print_mention_watchpoint, print_mention_masked_watchpoint)
3052         (bkpt_print_it, update_static_tracepoint): Update.
3053         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3054         * break-catch-syscall.c (print_it_catch_syscall): Update.
3055         * ada-tasks.c (print_ada_task_info): Update.
3056         * ada-lang.c (print_it_exception, print_mention_exception):
3057         Update.
3058
3059 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         PR breakpoints/24541
3062         * gdbarch.c: Regenerate.
3063         * gdbarch.h: Regenerate.
3064         * gdbarch.sh: Adjust return type and parameter types for
3065         'stap_adjust_register'.
3066         (i386_stap_adjust_register): Adjust signature and return new
3067         register name.
3068         * stap-probe.c (stap_parse_register_operand): Adjust use of
3069         'gdbarch_stap_adjust_register'.
3070
3071 2019-07-17  Tom Tromey  <tromey@adacore.com>
3072
3073         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3074         declare VEC.
3075         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3076         std::vector.
3077         (struct s390_process_info): Add initializers.
3078         (s390_add_process): Use new.
3079         (s390_linux_nat_target::low_forget_process): Use delete.
3080         (s390_linux_nat_target::low_new_fork)
3081         (s390_linux_nat_target::stopped_by_watchpoint)
3082         (s390_linux_nat_target::low_prepare_to_resume)
3083         (s390_linux_nat_target::insert_watchpoint)
3084         (s390_linux_nat_target::insert_hw_breakpoint)
3085         (s390_linux_nat_target::remove_watchpoint)
3086         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3087
3088 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3089
3090         * aarch64-fbsd-nat.c: Include regcache.h.
3091         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3092         argument.
3093         (aarch64_fbsd_nat_target::fetch_registers)
3094         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3095         variable.
3096         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3097
3098 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3099
3100         * fbsd-nat.c: Include gdbarch.h.
3101
3102 2019-07-15  Tom Tromey  <tromey@adacore.com>
3103
3104         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3105
3106 2019-07-15  Tom Tromey  <tromey@adacore.com>
3107
3108         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3109         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3110         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3111         * cli-out.c (cli_ui_out::do_field_int): New method.
3112         * ui-out.c (ui_out::field_unsigned): New method.
3113         * symfile.c (generic_load): Use field_unsigned.
3114         (print_transfer_performance): Likewise.
3115         * record-btrace.c (ui_out_field_uint): Remove.
3116         (btrace_call_history_insn_range, btrace_call_history): Use
3117         field_unsigned.
3118         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3119         field_unsigned.
3120         * ui-out.h (class ui_out) <field_unsigned>: New method.
3121         <do_field_unsigned>: Likewise.
3122
3123 2019-07-15  Tom Tromey  <tromey@adacore.com>
3124
3125         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3126         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3127         * target.c (flash_erase_command): Use field_string.
3128         * infrun.c (print_signal_received_reason): Use field_string.
3129         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3130         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3131         field_string.
3132         * ada-tasks.c (print_ada_task_info): Use field_string.
3133
3134 2019-07-15  Tom Tromey  <tromey@adacore.com>
3135
3136         * target.c (flash_erase_command): Use field_core_addr.
3137         * symfile.c (generic_load): Use field_core_addr.
3138         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3139         Use field_core_addr.
3140         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3141         field_core_addr.
3142
3143 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3146         value if its desired type is smaller than a CORE_ADDR and signed.
3147
3148 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3149
3150         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3151         of changes to field names, and use new is_reference field to
3152         decide if a property is a reference or not.
3153         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3154         field.
3155         (struct dwarf2_property_baton): Update header comment, rename
3156         'referenced_type' to 'property_type' and update comments.
3157         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3158         default property type, store in property baton, update to take
3159         accound of renamed field.
3160         (read_func_scope): Update call to attr_to_dynamic_prop.
3161         (read_array_type): Likewise.
3162         (dwarf2_per_cu_addr_sized_int_type): New function.
3163         (read_subrange_index_type): Move type finding code to
3164         dwarf2_per_cu_addr_sized_int_type.
3165         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3166         (dwarf2_per_cu_addr_type): New function.
3167         (set_die_type): Update calls to attr_to_dynamic_prop.
3168
3169 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         * dwarf2read.c (read_subrange_index_type): New function.
3172         (read_subrange_type): Move code into new function and call it.
3173         * gdbtypes.c (create_range_type): Add some asserts.
3174
3175 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3178         update return statements.
3179         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3180         declaration, and update comment to match.
3181         * gdbtypes.c (resolve_dynamic_array): Update call to
3182         dwarf2_evaluate_property to match new return type.
3183
3184 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * valarith.c (value_subscripted_rvalue): Change lowerbound
3187         parameter type from int to LONGEST.
3188         * value.h (value_subscripted_rvalue): Likewise in declaration.
3189
3190 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * cli/cli-utils.c (info_print_command_completer): New function.
3193         * cli/cli-utils.h: Add 'completer.h' include, and forward
3194         declaration for 'struct cmd_list_element'.
3195         (info_print_command_completer): Declare.
3196         * stack.c (_initialize_stack): Add completer for 'info locals' and
3197         'info args'.
3198         * symtab.c (_initialize_symtab): Add completer for 'info
3199         variables' and 'info functions'.
3200         * NEWS: Mention completion for additional info commands.
3201
3202 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3203
3204         * cli/cli-utils.c (extract_info_print_args): Delete.
3205         (extract_arg_maybe_quoted): Delete.
3206         (info_print_options_defs): New variable.
3207         (make_info_print_options_def_group): New function.
3208         (extract_info_print_options): Define new function.
3209         * cli/cli-utils.h (extract_info_print_args): Delete.
3210         (struct info_print_options): New structure.
3211         (extract_info_print_options): Declare new function.
3212         * stack.c (info_locals_command): Update to use new
3213         extract_info_print_options, also add a header comment.
3214         (info_args_command): Likewise.
3215         * symtab.c (info_variables_command): Likewise.
3216         (info_functions_command): Likewise.
3217
3218 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3221         to extract string arguments.
3222         * common/common-utils.c (extract_string_maybe_quoted): New function.
3223         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3224
3225 2019-07-11  Tom Tromey  <tromey@adacore.com>
3226
3227         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3228         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3229         * top.h (gdbinit): Don't declare.
3230         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3231         into...
3232         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3233         * top.c (gdb_init): Don't call init_cli_cmds.
3234         (gdbinit): Remove.
3235         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3236
3237 2019-07-11  Tom Tromey  <tromey@adacore.com>
3238
3239         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3240         after it has been moved.
3241
3242 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3243
3244         * valops.c (value_must_coerce_to_target): Change return type to
3245         bool.
3246         * value.h (value_must_coerce_to_target): Likewise.
3247
3248 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3249
3250         * breakpoint.c (is_hardware_watchpoint): Remove
3251         forward-declaration.
3252         (is_masked_watchpoint): Change return type to bool.
3253         (is_tracepoint): Likewise.
3254         (is_breakpoint): Likewise.
3255         (is_hardware_watchpoint): Likewise.
3256         (is_watchpoint): Likewise.
3257         (is_no_memory_software_watchpoint): Likewise.
3258         (is_catchpoint): Likewise.
3259         (breakpoint_1): Make FILTER parameter's return type bool.
3260         is_masked_watchpoint): Change return type to bool.
3261         (save_breakpoints): Make FILTER parameter's return type bool.
3262         * breakpoint.h (is_breakpoint): Change return type to bool.
3263         (is_watchpoint): Likewise.
3264         (is_catchpoint): Likewise.
3265         (is_tracepoint): Likewise.
3266
3267 2019-07-10  Tom Tromey  <tom@tromey.com>
3268
3269         * defs.h: Don't include gdbarch.h.
3270         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3271         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3272         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3273         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3274         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3275         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3276         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3277         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3278         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3279         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3280         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3281         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3282         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3283         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3284         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3285         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3286         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3287         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3288         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3289         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3290         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3291         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3292         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3293         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3294         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3295         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3296         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3297
3298 2019-07-10  Tom Tromey  <tromey@adacore.com>
3299
3300         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3301         * breakpoint.c (init_ada_exception_breakpoint): Register as
3302         bp_catchpoint.
3303         (print_one_breakpoint_location, print_one_breakpoint): Use
3304         is_ada_exception_catchpoint.
3305         * ada-lang.c (class ada_catchpoint_location): Pass
3306         bp_loc_software_breakpoint to bp_location constructor.
3307         (is_ada_exception_catchpoint): New function.
3308
3309 2019-07-10  Tom Tromey  <tromey@adacore.com>
3310
3311         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3312         VEC.
3313         (struct arm_exidx_entry): New method operator<.
3314         (struct arm_exidx_data) <section_maps>: Change type.
3315         (arm_exidx_data_free): Remove.
3316         (arm_exidx_data_key): Change type.  Move lower.
3317         (arm_exidx_new_objfile): Update.
3318         (arm_compare_exidx_entries): Remove.
3319         (arm_find_exidx_entry, _initialize_arm_tdep)
3320
3321 2019-07-10  Tom Tromey  <tromey@adacore.com>
3322
3323         * solib-spu.c (ocl_program_data_key): Change type.
3324         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3325         Update.
3326
3327 2019-07-10  Tom Tromey  <tromey@adacore.com>
3328
3329         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3330         (struct solib_aix_inferior_data) <library_list>: Change type.
3331         (solib_aix_inferior_data_handle): Change type.
3332         (get_solib_aix_inferior_data): Update.
3333         (solib_aix_free_library_list): Remove.
3334         (library_list_start_library): Update.
3335         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3336         return type.
3337         (solib_aix_get_library_list)
3338         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3339         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3340
3341 2019-07-10  Tom Tromey  <tromey@adacore.com>
3342
3343         * solib-dsbt.c (struct dsbt_info): Add initializers.
3344         (solib_dsbt_pspace_data): Change type.
3345         (dsbt_pspace_data_cleanup): Remove.
3346         (get_dsbt_info, _initialize_dsbt_solib): Update.
3347
3348 2019-07-10  Tom Tromey  <tromey@adacore.com>
3349
3350         * spu-tdep.c (spu_overlay_data): Change type.
3351         (spu_get_overlay_table, spu_overlay_new_objfile)
3352         (_initialize_spu_tdep): Update.
3353
3354 2019-07-10  Tom Tromey  <tromey@adacore.com>
3355
3356         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3357         destructor.
3358         (dbx_objfile_data_key): Change type and declare later.
3359         (DBX_SYMFILE_INFO): Rewrite.
3360         * dbxread.c (dbx_objfile_data_key): Change type.
3361         (dbx_symfile_init): Update.
3362         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3363         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3364         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3365
3366 2019-07-10  Tom Tromey  <tromey@adacore.com>
3367
3368         * jit.c (jit_program_space_key): Change type.  Move lower.
3369         (get_jit_program_space_data): Update.
3370         (jit_program_space_data_cleanup): Remove.
3371         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3372         Update.
3373         (struct jit_program_space_data): Add initializers.
3374
3375 2019-07-10  Tom Tromey  <tromey@adacore.com>
3376
3377         * solib-darwin.c (struct darwin_info): Add initializers.
3378         (solib_darwin_pspace_data): Change type.
3379         (darwin_pspace_data_cleanup): Remove.
3380         (get_darwin_info, _initialize_darwin_solib): Update.
3381
3382 2019-07-10  Tom Tromey  <tromey@adacore.com>
3383
3384         * remote-sim.c (struct sim_inferior_data): Add initializers,
3385         constructor, and destructor.
3386         (sim_inferior_data_key): Change type.  Move lower.
3387         (check_for_duplicate_sim_descriptor): Update.
3388         (get_sim_inferior_data): Use new.  Update.
3389         (~sim_inferior_data_cleanup): Rename from
3390         sim_inferior_data_cleanup.  Simplify.
3391         (gdbsim_close_inferior, simulator_command)
3392         (sim_command_completer, _initialize_remote_sim): Update.
3393         (next_pid, INITIAL_PID): Move earlier.
3394
3395 2019-07-10  Tom Tromey  <tromey@adacore.com>
3396
3397         * python/python-internal.h (create_thread_object): Return
3398         gdbpy_ref.
3399         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3400         * python/py-inferior.c (struct threadlist_entry): Add
3401         constructor.
3402         <thread_obj>: Now a gdbpy_ref.
3403         (thread_to_thread_object): Update.
3404         (add_thread_object): Use new.
3405         (delete_thread_object): Use delete.
3406         (infpy_threads): Update.
3407         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3408         GIL.
3409
3410 2019-07-10  Tom Tromey  <tromey@adacore.com>
3411
3412         * valops.c (value_cast): Specialize error message for Ada.
3413
3414 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3415
3416         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3417
3418 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3419
3420         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3421         bpstat_should_step): Return bool, adjust comments.
3422         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3423         bpstat_should_step): Likewise.
3424
3425 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3426
3427         * features/Makefile: Use feature target descriptions for Arm.
3428         * features/arm/arm-core.c: Generate new file.
3429         * features/arm/arm-fpa.c: Likewise.
3430         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3431         * features/arm/arm-m-profile.c: Likewise.
3432         * features/arm/arm-vfpv2.c: Likewise.
3433         * features/arm/arm-vfpv3.c: Likewise.
3434         * features/arm/xscale-iwmmxt.c: Likewise.
3435         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3436
3437 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3438
3439         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3440         ptrace earlier.
3441
3442 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3443
3444         * features/aarch64-pauth.c: Regenerate.
3445
3446 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3447
3448         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3449         bool.
3450         (bpstat_what): Use false instead of 0.
3451
3452 2019-07-09  Pedro Alves  <palves@redhat.com>
3453
3454         * break-catch-throw.c (is_exception_catchpoint): New.
3455         * breakpoint.c (print_one_breakpoint_location): New parameter
3456         'raw_loc'.  Handle it.  Use
3457         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3458         looking at the breakpoint's type.
3459         (print_one_breakpoint): If handling "maint info breakpoints", also
3460         print locations of exception catchpoints.
3461         * breakpoint.h (is_exception_catchpoint): Declare.
3462
3463 2019-07-09  Pedro Alves  <palves@redhat.com>
3464
3465         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3466         "addr" field.
3467         (allocate_location_exception_catchpoint): New.
3468         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3469         (initialize_throw_catchpoint_ops): Install
3470         allocate_location_exception_catchpoint as allocate_location
3471         method.
3472         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3473         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3474         bp_loc_other.
3475         (breakpoint_address_is_meaningful): Delete.
3476         (bl_address_is_meaningful): New.
3477         (breakpoint_locations_match): Adjust comment.
3478         (bp_location_from_bp_type): New, factored out of...
3479         (bp_location::bp_location(breakpoint *)): ... this.
3480         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3481         factored out of...
3482         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3483         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3484         breakpoint_address_is_meaningful.
3485         (bp_locations_compare): Adjust comment.
3486         (update_global_location_list): Use bl_address_is_meaningful
3487         instead of breakpoint_address_is_meaningful.
3488         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3489         explicit.
3490         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3491         * python/py-breakpoint.c (bppy_get_location): No longer check
3492         whether location is null.
3493
3494 2019-07-09  Pedro Alves  <palves@redhat.com>
3495
3496         PR c++/15468
3497         * breakpoint.c (print_one_breakpoint_location): Remove
3498         single-location assert.
3499
3500 2019-07-09  Tom Tromey  <tom@tromey.com>
3501
3502         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3503         * configure: Rebuild.
3504         * configure.ac: Change common to gdbsupport.
3505         * gdbsupport: Rename from common.
3506         * acinclude.m4: Change common to gdbsupport.
3507         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3508         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3509         gdbsupport.
3510         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3511         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3512         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3513         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3514         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3515         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3516         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3517         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3518         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3519         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3520         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3521         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3522         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3523         coff-pe-read.c, command.h, compile/compile-c-support.c,
3524         compile/compile-c.h, compile/compile-cplus-symbols.c,
3525         compile/compile-cplus-types.c, compile/compile-cplus.h,
3526         compile/compile-loc2c.c, compile/compile.c, completer.c,
3527         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3528         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3529         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3530         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3531         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3532         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3533         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3534         features/aarch64-core.c, features/aarch64-fpu.c,
3535         features/aarch64-pauth.c, features/aarch64-sve.c,
3536         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3537         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3538         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3539         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3540         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3541         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3542         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3543         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3544         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3545         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3546         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3547         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3548         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3549         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3550         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3551         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3552         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3553         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3554         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3555         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3556         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3557         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3558         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3559         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3560         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3561         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3562         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3563         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3564         minsyms.c, mips-linux-tdep.c, namespace.h,
3565         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3566         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3567         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3568         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3569         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3570         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3571         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3572         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3573         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3574         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3575         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3576         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3577         procfs.c, producer.c, progspace.h, psymtab.h,
3578         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3579         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3580         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3581         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3582         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3583         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3584         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3585         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3586         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3587         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3588         target-memory.c, target.c, target.h, target/waitstatus.c,
3589         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3590         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3591         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3592         unittests/array-view-selftests.c,
3593         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3594         unittests/common-utils-selftests.c,
3595         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3596         unittests/format_pieces-selftests.c,
3597         unittests/function-view-selftests.c,
3598         unittests/lookup_name_info-selftests.c,
3599         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3600         unittests/mkdir-recursive-selftests.c,
3601         unittests/observable-selftests.c,
3602         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3603         unittests/parse-connection-spec-selftests.c,
3604         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3605         unittests/scoped_fd-selftests.c,
3606         unittests/scoped_mmap-selftests.c,
3607         unittests/scoped_restore-selftests.c,
3608         unittests/string_view-selftests.c, unittests/style-selftests.c,
3609         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3610         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3611         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3612         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3613         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3614         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3615
3616 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3617
3618         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3619         bool value.
3620         (decode_digits_ordinary): Set explicit_line field in sal.
3621         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3622         symtab_and_line that was set on an explicit line number in
3623         assembler code.  Do always update the recorded symtab and line if
3624         we do skip the prologue.
3625
3626 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3627
3628         * breakpoint.c (set_breakpoint_location_function): Remove
3629         explicit_loc parameter.
3630         (momentary_breakpoint_from_master): Update call to
3631         set_breakpoint_location_function.
3632         (add_location_to_breakpoint): Likewise.
3633
3634 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3637         required features based on default bfd type when no specific bfd
3638         is present.
3639
3640 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3641
3642         * NEWS: Mention that GDB printf and eval commands can now print
3643         C-style and Ada-style convenience var strings without
3644         calling the inferior.
3645         * printcmd.c (printf_c_string): Locally print GDB internal var
3646         instead of transiting via the inferior.
3647         (printf_wide_c_string): Likewise.
3648
3649 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3650
3651         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3652
3653 2019-07-04  Tom Tromey  <tom@tromey.com>
3654
3655         PR tui/24724:
3656         * tui/tui-winsource.c (tui_clear_source_content): Update.
3657         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3658         (tui_update_breakpoint_info): Update.
3659         (tui_set_exec_info_content): Update.
3660         * tui/tui-source.c (tui_set_source_content_nil): Update.
3661         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3662         has_break.
3663         * tui/tui-data.h (enum tui_bp_flag): New.
3664         (tui_bp_flags): New enum flags type.
3665         (struct tui_source_element) <break_mode>: Change type.  Rename
3666         from has_break.
3667         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3668         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3669         constants.
3670         * tui/tui-winsource.h: Fix comment.
3671
3672 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3675         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3676         (store_fpregs_to_thread)
3677         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3678         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3679         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3680         (IWMMXT_REGS_SIZE): Add define.
3681         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3682         (fetch_vfp_regs, store_vfp_regs)
3683         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3684         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3685
3686 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3687
3688         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3689         defines.
3690         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3691         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3692         (ARM_INT_REGISTER_SIZE): ...to this.
3693         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3694         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3695         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3696         (arm_linux_collect_gregset, supply_nwfpe_register)
3697         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3698         defines.
3699         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3700         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3701         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3702         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3703         (arm_return_in_memory, arm_store_return_value)
3704         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3705         (arm_record_ld_st_multiple): Likewise.
3706         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3707         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3708
3709 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3710
3711         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3712         AARCH64_DISPLACED_MODIFIED_INSNS.
3713         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3714         (aarch64_displaced_step_copy_insn): Likewise.
3715         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3716         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3717         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3718         ARM_DISPLACED_MODIFIED_INSNS.
3719         * arm-tdep.c (arm_gdbarch_init): Likewise.
3720         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3721         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3722         (struct arm_displaced_step_closure): Use
3723         ARM_DISPLACED_MODIFIED_INSNS.
3724
3725 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * features/Makefile: Remove unused xml files.
3728         * features/aarch64.xml: Remove.
3729         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3730         * features/i386/amd64-avx-avx512.xml: Remove.
3731         * features/i386/amd64-avx-linux.xml: Remove.
3732         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3733         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3734         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3735         * features/i386/amd64-avx-mpx.xml: Remove.
3736         * features/i386/amd64-avx.xml: Remove.
3737         * features/i386/amd64-linux.xml: Remove.
3738         * features/i386/amd64-mpx-linux.xml: Remove.
3739         * features/i386/amd64-mpx.xml: Remove.
3740         * features/i386/amd64.xml: Remove.
3741         * features/i386/i386-avx-avx512-linux.xml: Remove.
3742         * features/i386/i386-avx-avx512.xml: Remove.
3743         * features/i386/i386-avx-linux.xml: Remove.
3744         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3745         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3746         * features/i386/i386-avx-mpx-linux.xml: Remove.
3747         * features/i386/i386-avx-mpx.xml: Remove.
3748         * features/i386/i386-avx.xml: Remove.
3749         * features/i386/i386-linux.xml: Remove.
3750         * features/i386/i386-mmx-linux.xml: Remove.
3751         * features/i386/i386-mmx.xml: Remove.
3752         * features/i386/i386-mpx-linux.xml: Remove.
3753         * features/i386/i386-mpx.xml: Remove.
3754         * features/i386/i386.xml: Remove.
3755         * features/i386/x32-avx-avx512-linux.xml: Remove.
3756         * features/i386/x32-avx-linux.xml: Remove.
3757         * features/i386/x32-linux.xml: Remove.
3758
3759 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3760
3761         * regformats/aarch64.dat: Remove.
3762         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3763         * regformats/i386/amd64-avx-linux.dat: Remove.
3764         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3765         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3766         * regformats/i386/amd64-linux.dat: Remove.
3767         * regformats/i386/amd64-mpx-linux.dat: Remove.
3768         * regformats/i386/amd64.dat: Remove.
3769         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3770         * regformats/i386/i386-avx-linux.dat: Remove.
3771         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3772         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3773         * regformats/i386/i386-linux.dat: Remove.
3774         * regformats/i386/i386-mmx-linux.dat: Remove.
3775         * regformats/i386/i386-mpx-linux.dat: Remove.
3776         * regformats/i386/i386.dat: Remove.
3777         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3778         * regformats/i386/x32-avx-linux.dat: Remove.
3779         * regformats/i386/x32-linux.dat: Remove.
3780
3781 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3782
3783         * aarch64-tdep.c: Remove xml self tests.
3784         * amd64-linux-tdep.c: Likewise.
3785         * amd64-tdep.c: Likewise.
3786         * i386-linux-tdep.c: Likewise.
3787         * i386-tdep.c: Likewise.
3788
3789 2019-07-03  Pedro Alves  <palves@redhat.com>
3790
3791         PR cli/24732
3792         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3793         (pipe_cmd_option_defs): New.
3794         (make_pipe_cmd_options_def_group): New.
3795         (pipe_command): Use gdb::option::process_options.
3796         (pipe_command_completer): New function.
3797         (_initialize_cli_cmds): Install completer for "pipe" command.
3798
3799 2019-07-03  Pedro Alves  <palves@redhat.com>
3800
3801         * cli/cli-option.c (union option_value) <string>: New field.
3802         (struct option_def_and_value): Add ctor, move ctor, dtor and
3803         use DISABLE_COPY_AND_ASSIGN.
3804         (option_def_and_value::clear_value): New.
3805         (parse_option, save_option_value_in_ctx, get_val_type_str)
3806         (add_setshow_cmds_for_options): Handle var_string.
3807         * cli-option.h (union option_def::var_address) <string>: New
3808         field.
3809         (struct string_option_def): New.
3810         * maint-test-options.c (struct test_options_opts): Add default
3811         ctor and use DISABLE_COPY_AND_ASSIGN.
3812         <string_opt>: New field.
3813         (test_options_opts::~test_options_opts): New.
3814         (test_options_opts::dump): Also dump "-string".
3815         (test_options_option_defs): Install "string.
3816
3817 2019-07-03  Pedro Alves  <palves@redhat.com>
3818
3819         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3820         option_value with a null enumeration.
3821         (complete_options): Save the option values in the context.
3822         (save_option_value_in_ctx): New, factored out from ...
3823         (process_options): ... here.
3824         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3825         of the function.
3826         * maint-test-options.c (test_options_opts::dump): New, factored
3827         out from ...
3828         (maintenance_test_options_command_mode): ... here.
3829         (maintenance_test_options_command_completion_result): Delete.
3830         (maintenance_test_options_command_completion_text): Update
3831         comment.
3832         (maintenance_show_test_options_completion_result): Change
3833         prototype.  Just print
3834         maintenance_test_options_command_completion_text.
3835         (save_completion_result): New.
3836         (maintenance_test_options_completer_mode): Pass options context to
3837         complete_options, and then save a dump.
3838         (_initialize_maint_test_options): Use add_cmd to install "maint
3839         show test-options-completion-result".
3840
3841 2019-07-03  Pedro Alves  <palves@redhat.com>
3842
3843         * NEWS (New commands): Mention "with" and "maint with".
3844         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3845         (with_command, with_command_completer): New.
3846         (pipe_command): Adjust to new repeat_previous
3847         interface.
3848         (_initialize_cli_cmds): Install the "with" command and its "w"
3849         alias.
3850         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3851         declarations.
3852         * cli/cli-setshow.c (parse_cli_var_uinteger)
3853         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3854         argument strings for all var_types.
3855         (get_setshow_command_value_string): New, factored out from ...
3856         (do_show_command): ... this.
3857         * cli/cli-setshow.h: Include <string>.
3858         (get_setshow_command_value_string): Declare.
3859         * command.h (repeat_previous): Now returns const char *.  Adjust
3860         comment.
3861         * maint.c: Include "cli/cli-cmds.h".
3862         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3863         (_initialize_maint_cmds): Register the "maintenance with" command.
3864         * top.c (repeat_previous): Move bits from pipe_command here:
3865         Return the saved command line, if any; error out if there's no
3866         command to relaunch.
3867
3868 2019-07-03  Pedro Alves  <palves@redhat.com>
3869
3870         * NEWS (New commands): Mention "maint set/show test-settings"
3871         instead of "maint test-settings".
3872         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3873         (maintenance_test_settings_set_list): Rename to ...
3874         (maintenance_set_test_settings_list): ... this.
3875         (maintenance_test_settings_show_list): Rename to  ...
3876         (maintenance_show_test_settings_list): ... this.
3877         (maintenance_test_settings_cmd): Delete.
3878         (maintenance_test_settings_set_cmd): ...
3879         (maintenance_set_test_settings_cmd): ... this.
3880         (maintenance_test_settings_show_cmd): ...
3881         (maintenance_show_test_settings_cmd): ... this.
3882         (maintenance_test_settings_show_value_cmd):
3883         (maintenance_show_test_settings_value_cmd): ... this.
3884         (_initialize_maint_test_settings): No longer install the "maint
3885         test-settings" prefix command.  Rename "maint test-settings set"
3886         to "maint set test-settings", and "maint test-settings show" to
3887         "maint show test-settings".  Adjust all subcommands.
3888
3889 2019-07-03  Pedro Alves  <palves@redhat.com>
3890
3891         * maint-test-settings.c: Fix file's intro comment.  Replace all
3892         references to "test-options" with references to "test-settings",
3893         in comments.
3894
3895 2019-07-03  Pedro Alves  <palves@redhat.com>
3896
3897         * maint-test-settings.c (maintenance_test_settings_xxx)
3898         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3899         New.
3900         (maintenance_test_settings_enums): Use them.
3901         (maintenance_test_settings_enum): Default to
3902         maintenance_test_settings_xxx.
3903         (_initialize_maint_test_settings): Initialize
3904         MAINTENANCE_TEST_SETTINGS_FILENAME.
3905
3906 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3907
3908         * breakpoint.h (remove_breakpoints_inf): Change return type to
3909         void, move function documentation here.
3910         * breakpoint.c (remove_breakpoints_inf): Change return type to
3911         void, move function documentation to header.
3912
3913 2019-07-02  Pedro Alves  <palves@redhat.com>
3914
3915         * NEWS (Completion improvements): Mention "info threads".
3916         * thread.c (struct info_threads_opts, info_threads_option_defs)
3917         (make_info_threads_options_def_group): New.
3918         (info_threads_command): Use gdb::option::process_options.
3919         (info_threads_command_completer): New.
3920         (_initialize_thread): Use gdb::option::build_help to build the
3921         help text for "info threads".
3922
3923 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3924
3925         * defs.h (generic_load): Move from here...
3926         * symfile.h (generic_load): ... to here.  Rename name parameter
3927         to args.
3928         * symfile.c (generic_load): Add comment.
3929
3930 2019-07-01  Tom Tromey  <tromey@adacore.com>
3931
3932         * dwarf2read.c
3933         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3934         declaration of without_params.  Fix formatting.
3935
3936 2019-07-01  Tom Tromey  <tromey@adacore.com>
3937
3938         * ada-exp.y (find_primitive_type): Update.
3939         * ada-lang.h (ada_lookup_symbol): Update.
3940         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3941         parameter.
3942         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3943
3944 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3945
3946         PR breakpoints/24541
3947         * gdbarch.c: Regenerate.
3948         * gdbarch.h: Regenerate.
3949         * gdbarch.sh: Add 'stap_adjust_register'.
3950         * i386-tdep.c: Include '<unordered_set>'.
3951         (i386_stap_adjust_register): New function.
3952         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3953         * stap-probe.c (stap_parse_register_operand): Call
3954         'gdbarch_stap_adjust_register'.
3955
3956 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3957
3958         PR python/24742
3959         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3960         * python/python.c (do_start_initialization): Use 'xmalloc'
3961         instead of 'PyMem_Malloc'.
3962
3963 2019-06-28  Tom Tromey  <tromey@adacore.com>
3964
3965         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3966         for Ada.
3967
3968 2019-06-27  Tom Tromey  <tromey@adacore.com>
3969
3970         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3971         objfile_key.
3972         (arm_find_mapping_symbol, arm_record_special_symbol)
3973         (_initialize_arm_tdep): Update.
3974         (arm_objfile_data_free): Remove.
3975
3976 2019-06-27  Tom Tromey  <tromey@adacore.com>
3977
3978         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3979         to cp_print_static_field.
3980
3981 2019-06-26  Tom Tromey  <tromey@adacore.com>
3982
3983         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3984         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3985         declare.
3986
3987 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3988
3989         * features/aarch64-core.c (create_feature_aarch64_core):
3990         Regenerate.
3991         * features/aarch64-core.xml: Add cpsr flags.
3992
3993 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3994
3995         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3996         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3997
3998 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3999
4000         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4001         field.
4002         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4003         use.
4004         (arm_record_special_symbol): Don't insert new symbol in sorted
4005         position, push it at the end.
4006
4007 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4008
4009         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4010         (arm_mapping_symbol_s): Remove.
4011         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4012         (arm_mapping_symbol_vec): New typedef.
4013         (struct arm_per_objfile): Add constructor.
4014         <section_maps>: Change type to
4015         std::unique_ptr<arm_mapping_symbol_vec[]>.
4016         (arm_compare_mapping_symbols): Remove.
4017         (arm_find_mapping_symbol): Adjust to section_maps type change.
4018         (arm_objfile_data_free): Call delete on arm_per_objfile.
4019         (arm_record_special_symbol): Adjust to section_maps type change.
4020         Allocate arm_per_objfile with new.
4021
4022 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4023
4024         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4025         with the command prefix.
4026
4027 2019-06-25  Tom Tromey  <tom@tromey.com>
4028
4029         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4030         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4031
4032 2019-06-25  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4035         type.
4036         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4037         protected.
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-winsource.c
4042         (tui_source_window_base::set_is_exec_point_at): Add check against
4043         LOA_ADDRESS.
4044
4045 2019-06-25  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-source.c (tui_set_source_content): Don't check before
4048         xfree.
4049         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4050
4051 2019-06-25  Tom Tromey  <tom@tromey.com>
4052
4053         * tui/tui-winsource.h (tui_update_source_window_as_is)
4054         (tui_alloc_source_buffer, tui_line_is_displayed)
4055         (tui_addr_is_displayed): Change type of win_info.
4056         * tui/tui-winsource.c (tui_update_source_window_as_is)
4057         (tui_clear_source_content, tui_show_source_line)
4058         (tui_show_source_content, tui_source_window_base::refill)
4059         (tui_source_window_base::set_is_exec_point_at)
4060         (tui_source_window_base::set_is_exec_point_at)
4061         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4062         (tui_alloc_source_buffer, tui_line_is_displayed)
4063         (tui_addr_is_displayed): Change type of win_info.  Update.
4064         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4065         (tui_source_window_base::do_make_visible_with_new_height):
4066         Update.
4067         * tui/tui-source.c (tui_set_source_content)
4068         (tui_set_source_content_nil)
4069         (tui_source_window::do_scroll_vertical): Update.
4070         * tui/tui-layout.c (show_layout): Update.
4071         * tui/tui-disasm.c (tui_set_disassem_content)
4072         (tui_disasm_window::do_scroll_vertical): Update.
4073         * tui/tui-data.h (tui_win_content): Remove.
4074         (struct tui_gen_win_info) <content, content_size>: Remove.
4075         (struct tui_source_element): Add initializers and destructor.
4076         (union tui_which_element, struct tui_win_element): Remove.
4077         (struct tui_source_window_base) <content>: New field.
4078         (struct tui_data_window): Remove destructor.
4079         (tui_alloc_content, tui_free_win_content)
4080         (tui_free_all_source_wins_content): Don't declare.
4081         * tui/tui-data.c (tui_initialize_static_data): Update.
4082         (init_content_element, tui_alloc_content): Remove.
4083         (~tui_gen_win_info): Update.
4084         (~tui_data_window, tui_free_all_source_wins_content)
4085         (tui_free_win_content, free_content, free_content_elements):
4086         Remove.
4087
4088 2019-06-25  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-winsource.h (tui_clear_source_content)
4091         (tui_erase_source_content, tui_show_source_content): Change type
4092         of win_info.
4093         * tui/tui-winsource.c (tui_clear_source_content)
4094         (tui_erase_source_content, tui_show_source_content): Change type
4095         of win_info.
4096         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4097         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4098         win_info.
4099         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4100         win_info.
4101         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4102
4103 2019-06-25  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-winsource.c (tui_clear_source_content)
4106         (tui_source_window_base::set_is_exec_point_at): Update.
4107         * tui/tui-source.c (tui_set_source_content_nil): Update.
4108         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4109         a bool.
4110         * tui/tui-data.c (init_content_element): Update.
4111
4112 2019-06-25  Tom Tromey  <tom@tromey.com>
4113
4114         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4115         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4116         * tui/tui-layout.c (init_and_make_win): Update.
4117         * tui/tui.h (enum tui_win_type): Update.
4118         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4119         tui_win_is_auxillary.
4120         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4121         tui_win_is_auxillary.
4122
4123 2019-06-25  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4126         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4127         (tui_delete_data_content_windows, tui_display_all_data)
4128         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4129         Update.
4130         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4131         * tui/tui-regs.c (tui_last_regs_line_no)
4132         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4133         (tui_show_registers): Update.
4134         (tui_show_register_group): Return void.  Update.
4135         (tui_display_registers_from, tui_display_reg_element_at_line)
4136         (tui_display_registers_from_line, tui_check_register_values):
4137         Update.
4138         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4139         member.
4140         (struct tui_data_window) <regs_content>: Now a std::vector.
4141         <regs_content_count>: Remove.
4142         (tui_add_content_elements, tui_free_data_content): Don't declare.
4143         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4144         (init_content_element): Remove DATA_WIN case.  Add assert.
4145         (tui_add_content_elements): Remove.
4146         (tui_data_window): Update.
4147         (tui_free_data_content): Remove.
4148         (free_content_elements): Remove DATA_WIN case.
4149
4150 2019-06-25  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-data.c (tui_data_item_window): Update.
4153         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4154         * tui/tui-windata.c (tui_display_all_data)
4155         (tui_display_data_from_line): Update.
4156         (tui_check_data_values): Remove.
4157         * tui/tui-regs.c (tui_show_register_group)
4158         (tui_display_reg_element_at_line): Update.
4159         * tui/tui-hooks.c (tui_register_changed)
4160         (tui_refresh_frame_and_register_information): Call
4161         tui_check_register_values.
4162         * tui/tui-data.h (struct tui_data_window) <data_content,
4163         data_content_count, data_type>: Remove.
4164         (enum tui_data_type): Remove.
4165
4166         * tui/tui-data.c (tui_data_window::clear_detail)
4167         (~tui_data_window): Update.
4168
4169 2019-06-25  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4172         declare.
4173         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4174         Rename from tui_first_data_item_displayed.  Update.
4175         (tui_data_window::refresh_all)
4176         (tui_data_window::do_scroll_vertical): Update.
4177         * tui/tui-data.h (struct tui_data_window)
4178         <first_data_item_displayed>: Declare new method.
4179
4180 2019-06-25  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4183         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4184         contents...
4185         (tui_initialize_static_data): ...here.
4186
4187 2019-06-25  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4190         (tui_display_registers_from, tui_check_register_values): Update.
4191         (tui_display_register): Remove win_info parameter; update.
4192         (tui_get_register): Change type of parameters.
4193         * tui/tui-data.h (struct tui_data_element): Remove.
4194         (union tui_which_element) <data>: Remove.
4195         <data_window>: Change type.
4196         (struct tui_data_item_window): New.
4197         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4198         case.  Add assert.
4199         (~tui_data_item_window): New destructor.
4200         (free_content_elements): Remove DATA_ITEM_WIN case.
4201
4202 2019-06-25  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4205         Remove.
4206
4207 2019-06-25  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-data.h (struct tui_command_element): Remove.
4210         (union tui_which_element) <command>: Remove.
4211         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4212         assert.
4213         (free_content_elements): Remove CMD_WIN case.
4214
4215 2019-06-25  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-layout.c (tui_set_layout): Update.
4218         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4219         * tui/tui-data.c (layout_def): Update.
4220
4221 2019-06-25  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4225         (tui_source_window_base::set_new_height): Update.
4226         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4227         Update.
4228         (tui_set_locator_fullname, tui_set_locator_info)
4229         (tui_show_frame_info): Update.
4230         * tui/tui-source.c (tui_set_source_content)
4231         (tui_source_is_displayed): Update.
4232         * tui/tui-layout.c (show_source_disasm_command, show_data)
4233         (show_source_or_disasm_and_command): Update.
4234         * tui/tui-disasm.c (tui_set_disassem_content)
4235         (tui_get_begin_asm_address): Update.
4236         * tui/tui-data.h (struct tui_locator_element): Remove.
4237         (union tui_which_element) <locator>: Remove.
4238         (struct tui_locator_window): New.
4239         (tui_locator_win_info_ptr): Change return type.
4240         * tui/tui-data.c (_locator): Change type.
4241         (tui_locator_win_info_ptr): Change return type.
4242         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4243         (tui_alloc_content): Add assert.
4244
4245 2019-06-25  Tom Tromey  <tom@tromey.com>
4246
4247         * tui/tui-winsource.c
4248         (tui_exec_info_window::maybe_allocate_content): New method.
4249         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4250         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4251         (make_source_or_disasm_window): Add cast.
4252         * tui/tui-data.h (union tui_which_element) <simple_string>:
4253         Remove.
4254         (struct tui_source_info): New.
4255         (struct tui_source_window_base) <execution_info>: Change type.
4256         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4257         case, and add assert.
4258         (tui_alloc_content): Add assert.
4259
4260 2019-06-25  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4263         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4264         * tui/tui-data.c (tui_alloc_win_info): Remove.
4265
4266 2019-06-25  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4269         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4270         can_highlight.
4271
4272 2019-06-25  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4275         make_visible_with_new_height method.
4276         (tui_win_info::make_visible_with_new_height): New method.
4277         (tui_source_window_base::do_make_visible_with_new_height)
4278         (tui_data_window::do_make_visible_with_new_height)
4279         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4280         (make_visible_with_new_height): Remove.
4281         (tui_resize_all, tui_adjust_win_heights): Use
4282         make_visible_with_new_height method.
4283         * tui/tui-data.h (struct tui_win_info)
4284         <do_make_visible_with_new_height, make_visible_with_new_height>:
4285         New methods.
4286         (struct tui_source_window_base, struct tui_data_window)
4287         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4288         methods.
4289
4290 2019-06-25  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4293         method.
4294         (update_tab_width): Call update_tab_width method.
4295         * tui/tui-data.h (struct tui_win_info)
4296         (struct tui_source_window_base) <update_tab_width>: New methods.
4297
4298 2019-06-25  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4301         parameter.
4302         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4303         parameter.
4304         (tui_gen_win_info::make_visible): Update.
4305         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4306         parameter.
4307         * tui/tui-data.h (enum tui_box): New enum.
4308         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4309
4310 2019-06-25  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4313         init_and_make_win for EXEC_INFO_WIN.
4314         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4315         longer inline.
4316         (struct tui_win_info) <~tui_win_info>: Inline.
4317         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4318         Don't declare.
4319         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4320         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4321         Remove.
4322         (tui_initialize_static_data): Update.
4323         (~tui_gen_win_info): Handle more cleanup here.
4324         (~tui_source_window_base): Delete "execution_info".
4325         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4326
4327 2019-06-25  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-layout.c (make_command_window): Don't set
4330         can_highlight.
4331         (show_source_disasm_command): Call the reset method.
4332         (show_data): Don't set can_highlight.  Call the reset method.
4333         (tui_gen_win_info::reset): Rename from init_gen_win_info
4334         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4335         (show_source_or_disasm_and_command): Call the reset method.
4336         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4337         (struct tui_cmd_window): Set can_highlight.
4338
4339 2019-06-25  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4342         from make_visible.
4343         (tui_make_visible, tui_make_invisible): Rewrite.
4344         (tui_win_info::make_visible): Remove.
4345         (tui_source_window_base::make_visible): Update.
4346         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4347         method.  Moved from...
4348         (struct tui_win_info) <make_visible>: ...here.
4349
4350 2019-06-25  Tom Tromey  <tom@tromey.com>
4351
4352         * tui/tui-winsource.c
4353         (tui_source_window_base::do_scroll_horizontal): Remove direction
4354         parameter.
4355         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4356         direction parameter.
4357         * tui/tui-win.c (tui_win_info::forward_scroll)
4358         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4359         (tui_win_info::right_scroll): Update.
4360         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4361         direction parameter.
4362         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4363         direction parameter.
4364         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4365         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4366         Remove direction parameter.
4367         (struct tui_source_window_base, struct tui_source_window)
4368         (struct tui_disasm_window, struct tui_data_window)
4369         (struct tui_cmd_window): Update.
4370
4371 2019-06-25  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui-winsource.h (tui_set_exec_info_content)
4374         (tui_show_exec_info_content, tui_erase_exec_info_content)
4375         (tui_clear_exec_info_content, tui_update_exec_info): Change
4376         argument to tui_source_window_base.
4377         * tui/tui-winsource.c (tui_set_exec_info_content)
4378         (tui_show_exec_info_content, tui_erase_exec_info_content)
4379         (tui_clear_exec_info_content, tui_update_exec_info): Change
4380         argument to tui_source_window_base.
4381
4382 2019-06-25  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4385         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4386
4387 2019-06-25  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4390         check.
4391
4392 2019-06-25  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4395         type to void.
4396         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4397         type to void.
4398         * tui/tui-source.c (tui_set_source_content): Update.
4399         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4400
4401 2019-06-25  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui-win.c (window_name_completer, tui_set_focus)
4404         (tui_all_windows_info): Use name method.
4405         * tui/tui-data.h (struct tui_gen_win_info)
4406         (struct tui_source_window, struct tui_disasm_window)
4407         (struct tui_data_window, struct tui_cmd_window) <name>: New
4408         method.
4409         (tui_win_name): Don't declare.
4410         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4411         (tui_win_name): Remove.
4412
4413 2019-06-25  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui-winsource.h (tui_update_source_window)
4416         (tui_update_source_window_as_is): Change parameter type.
4417         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4418         to be a tui_source_window_base.
4419         (tui_update_source_window_as_is): Likewise.
4420         * tui/tui-win.c (make_visible_with_new_height): Update.
4421
4422 2019-06-25  Tom Tromey  <tom@tromey.com>
4423
4424         * tui/tui-winsource.c (tui_erase_source_content)
4425         (tui_show_source_content, tui_show_exec_info_content)
4426         (tui_erase_exec_info_content): Use refresh_window method.
4427         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4428         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4429         from tui_refresh_win.
4430         (tui_data_window::refresh_window): New method.
4431         (tui_win_info::refresh, tui_source_window_base::refresh)
4432         (tui_refresh_all): Use refresh_window method.
4433         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4434         method.
4435         * tui/tui-regs.c (tui_display_register): Call refresh_window
4436         method.
4437         * tui/tui-layout.c (show_source_disasm_command)
4438         (show_source_or_disasm_and_command): Call refresh_window method.
4439         * tui/tui-data.h (struct tui_gen_win_info)
4440         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4441         New method.
4442
4443 2019-06-25  Tom Tromey  <tom@tromey.com>
4444
4445         * tui/tui.c (tui_rl_other_window, tui_enable)
4446         (tui_is_window_visible, tui_get_command_dimension): Update.
4447         * tui/tui-winsource.c (tui_update_source_window_as_is)
4448         (tui_clear_source_content, tui_erase_source_content)
4449         (tui_show_source_line, tui_source_window_base::refill)
4450         (tui_source_window_base::do_scroll_horizontal)
4451         (tui_source_window_base::set_is_exec_point_at)
4452         (tui_update_breakpoint_info, tui_set_exec_info_content)
4453         (tui_alloc_source_buffer, tui_line_is_displayed)
4454         (tui_addr_is_displayed): Update.
4455         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4456         (tui_check_and_display_highlight_if_needed)
4457         (tui_win_info::make_visible, tui_win_info::refresh)
4458         (tui_refresh_all): Update.
4459         * tui/tui-windata.c (tui_first_data_item_displayed)
4460         (tui_delete_data_content_windows, tui_erase_data_content)
4461         (tui_display_all_data, tui_data_window::refresh_all)
4462         (tui_check_data_values): Update.
4463         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4464         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4465         (tui_win_info::backward_scroll, tui_refresh_all_win)
4466         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4467         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4468         (tui_source_window_base::set_new_height)
4469         (tui_data_window::set_new_height)
4470         (make_invisible_and_set_new_height)
4471         (make_visible_with_new_height, new_height_ok)
4472         (parse_scrolling_args): Update.
4473         * tui/tui-stack.c (tui_show_frame_info): Update.
4474         * tui/tui-source.c (tui_set_source_content)
4475         (tui_set_source_content_nil, tui_source_is_displayed)
4476         (tui_source_window::do_scroll_vertical): Update.
4477         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4478         (tui_display_registers_from, tui_display_reg_element_at_line)
4479         (tui_check_register_values, tui_reg_command): Update.
4480         * tui/tui-layout.c (tui_default_win_height)
4481         (show_source_disasm_command, show_data, init_and_make_win)
4482         (show_source_or_disasm_and_command): Update.
4483         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4484         (tui_redisplay_readline, tui_mld_flush)
4485         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4486         (tui_getc): Update.
4487         * tui/tui-disasm.c (tui_set_disassem_content)
4488         (tui_disasm_window::do_scroll_vertical): Update.
4489         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4490         Now virtual.
4491         (struct tui_win_info): Derive from tui_gen_win_info.
4492         <~tui_win_info>: Mark as override.
4493         <generic>: Remove member.
4494         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4495         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4496         (~tui_data_window, ~tui_win_info)
4497         (tui_free_all_source_wins_content): Update.
4498         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4499
4500 2019-06-25  Tom Tromey  <tom@tromey.com>
4501
4502         * tui/tui-layout.c (init_and_make_win): Use new.
4503         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4504         destructor, initializers.
4505         (tui_alloc_generic_win_info): Don't declare.
4506         * tui/tui-data.c (_locator): Add argument to constructor.
4507         (source_win, disasm_win): New globals.
4508         (exec_info): Remove.
4509         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4510         Update.
4511         (tui_alloc_generic_win_info): Remove.
4512         (init_content_element): Use new.
4513         (tui_win_info::tui_win_info): Update.
4514         (free_content_elements) <case DATA_WIN>: Use delete.
4515
4516 2019-06-25  Tom Tromey  <tom@tromey.com>
4517
4518         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4519         * tui/tui-windata.c (tui_first_data_item_displayed)
4520         (tui_delete_data_content_windows): Update.
4521         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4522         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4523         (tui_display_registers_from, tui_check_register_values): Update.
4524         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4525         pointer.
4526         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4527         window.
4528         (tui_free_data_content): Update.
4529         (free_content_elements) <case DATA_WIN>: Free the window.
4530
4531 2019-06-25  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4534         Update.
4535         * tui/tui-layout.c (make_command_window)
4536         (show_source_disasm_command, show_data, init_and_make_win)
4537         (show_source_or_disasm_and_command): Update.
4538         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4539         method.
4540         <can_highight, is_highlighted>: Now bool.
4541         (tui_set_win_highlight): Don't declare.
4542         * tui/tui-data.c (tui_set_win_highlight): Remove.
4543
4544 2019-06-25  Tom Tromey  <tom@tromey.com>
4545
4546         * tui/tui-wingeneral.c (make_visible): Remove check of window
4547         type.
4548
4549 2019-06-25  Tom Tromey  <tom@tromey.com>
4550
4551         * tui/tui-win.c (tui_win_info::max_height)
4552         (tui_cmd_window::max_height): New methods.
4553         (new_height_ok): Call max_height.
4554         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4555         <max_height>: New method.
4556
4557 2019-06-25  Tom Tromey  <tom@tromey.com>
4558
4559         * tui/tui-win.c (tui_source_window_base::set_new_height)
4560         (tui_data_window::set_new_height): New methods.
4561         (make_invisible_and_set_new_height): Call set_new_height method.
4562         * tui/tui-data.h (struct tui_win_info)
4563         (struct tui_source_window_base, struct tui_data_window)
4564         <set_new_height>: New method.
4565
4566 2019-06-25  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4569         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4570         tui_refresh_data_win.
4571         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4572         method.
4573         (tui_refresh_all_win): Call the refresh_all method.
4574         (tui_set_focus): Likewise.
4575         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4576         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4577         Likewise.
4578
4579 2019-06-25  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-winsource.h (tui_refill_source_window)
4582         (tui_set_is_exec_point_at): Don't declare.
4583         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4584         (tui_source_window_base::refill): Rename from
4585         tui_refill_source_window.
4586         (tui_source_window_base::do_scroll_horizontal): Update.
4587         (tui_source_window_base::set_is_exec_point_at): Rename from
4588         tui_set_is_exec_point_at.
4589         (tui_update_all_breakpoint_info): Update.
4590         * tui/tui-stack.c (tui_show_frame_info): Update.
4591         * tui/tui-layout.c (show_data): Add cast.
4592         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4593         * tui/tui-data.h (struct tui_source_window_base) <refill,
4594         set_is_exec_point_at>: New methods.
4595         (tui_source_windows, tui_add_to_source_windows): Update types.
4596         (tui_add_to_source_windows): Remove redundant declaration.
4597         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4598         (tui_source_windows): Change return type.
4599         (tui_clear_source_windows_detail): Update.
4600         (tui_add_to_source_windows): Change type of parameter.
4601         (tui_free_all_source_wins_content): Update.
4602
4603 2019-06-25  Tom Tromey  <tom@tromey.com>
4604
4605         * tui/tui-wingeneral.c (tui_win_info::refresh)
4606         (tui_source_window_base::refresh): New methods.
4607         (tui_refresh_all): Call the refresh method.
4608         * tui/tui-data.h (struct tui_win_info)
4609         (struct tui_source_window_base) <refresh>: New method.
4610
4611 2019-06-25  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui.h (tui_is_window_visible): Return bool.
4614         * tui/tui.c (tui_is_window_visible): Return bool.
4615         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4616         (tui_make_visible, tui_make_invisible)
4617         (tui_win_info::make_visible)
4618         (tui_source_window_base::make_visible, make_all_visible)
4619         (tui_make_all_visible, tui_make_all_invisible): Update.
4620         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4621         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4622         bool.
4623         (struct tui_win_info, struct tui_source_window_base)
4624         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4625         * tui/tui-data.c (tui_init_generic_part): Update.
4626
4627 2019-06-25  Tom Tromey  <tom@tromey.com>
4628
4629         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4630         (tui_source_window_base::make_visible): New methods.
4631         (make_all_visible): Make method call.
4632         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4633         (struct tui_source_window_base, struct tui_cmd_window): Override
4634         make_visible.
4635         (tui_win_is_source_type): Don't declare.
4636         * tui/tui-data.c (tui_win_is_source_type): Remove.
4637
4638 2019-06-25  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4641         NULL check.
4642
4643 2019-06-25  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4646         Inline constructor.  Add initializers for members.
4647         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4648         constructors; now inline in class.
4649
4650 2019-06-25  Tom Tromey  <tom@tromey.com>
4651
4652         * tui/tui-regs.c (tui_show_registers): Update.
4653         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4654         bool.
4655         * tui/tui-data.c (tui_data_window::clear_detail)
4656         (tui_data_window): Update.
4657
4658 2019-06-25  Tom Tromey  <tom@tromey.com>
4659
4660         * tui/tui-windata.c (tui_display_all_data)
4661         (tui_display_data_from_line, tui_display_data_from)
4662         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4663         Update.
4664         * tui/tui-regs.c (tui_last_regs_line_no)
4665         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4666         (tui_show_registers, tui_show_register_group)
4667         (tui_display_registers_from, tui_display_reg_element_at_line)
4668         (tui_display_registers_from_line, tui_check_register_values)
4669         (tui_reg_next, tui_reg_prev): Update.
4670         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4671         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4672         tui_data_window.
4673         (struct tui_win_info) <detail>: Remove.  Add new fields from
4674         tui_data_info.
4675         (TUI_DATA_WIN): Add cast.
4676         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4677         (~tui_data_window): Simplify.
4678
4679 2019-06-25  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-layout.c (show_source_disasm_command)
4682         (show_source_or_disasm_and_command): Update.
4683         * tui/tui-io.c (update_cmdwin_start_line)
4684         (tui_redisplay_readline): Update.
4685         * tui/tui-data.h (struct tui_command_info): Remove.
4686         (struct tui_win_info) <detail>: Remove command_info member.
4687         (struct tui_data_window) <start_line>: New member, from
4688         tui_command_info.
4689         (TUI_CMD_WIN): Add casts.
4690
4691 2019-06-25  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui-winsource.c (tui_update_source_window)
4694         (tui_refill_source_window)
4695         (tui_source_window_base::do_scroll_horizontal)
4696         (tui_update_breakpoint_info, tui_set_exec_info_content)
4697         (tui_show_exec_info_content, tui_erase_exec_info_content)
4698         (tui_clear_exec_info_content): Update.
4699         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4700         Update.
4701         * tui/tui-win.c (make_invisible_and_set_new_height)
4702         (make_visible_with_new_height): Update.
4703         * tui/tui-source.c (tui_set_source_content)
4704         (tui_show_symtab_source): Update.
4705         * tui/tui-layout.c (extract_display_start_addr)
4706         (show_source_disasm_command, show_data)
4707         (make_source_or_disasm_window)
4708         (show_source_or_disasm_and_command): Update.
4709         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4710         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4711         "gdbarch".
4712         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4713         to tui_source_window_base.
4714         (struct tui_win_info) <detail>: Remove source_info member.
4715         (struct tui_source_window_base) <has_locator>: Inline.
4716         Move contents from tui_source_info; rename has_locator member to
4717         m_has_locator.
4718         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4719         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4720         header file.
4721         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4722         Simplify.
4723         (tui_free_all_source_wins_content): Cast to
4724         tui_source_window_base.
4725
4726 2019-06-25  Tom Tromey  <tom@tromey.com>
4727
4728         * tui/tui-win.c (make_invisible_and_set_new_height)
4729         (make_visible_with_new_height): Call has_locator method.
4730         * tui/tui-layout.c (show_source_disasm_command, show_data)
4731         (show_source_or_disasm_and_command): Update for bool change.
4732         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4733         (tui_win_info) <has_locator>: New method.
4734         (struct tui_source_window_base) <has_locator>: New method.
4735         (tui_win_has_locator): Don't declare.
4736         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4737         from tui_win_has_locator.
4738         (tui_source_window_base): Use false, not FALSE.
4739
4740 2019-06-25  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4743         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4744         clear_detail method directly.
4745         (tui_clear_win_detail): Remove.
4746
4747 2019-06-25  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4750         "this", not TUI_DISASM_WIN.
4751
4752 2019-06-25  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4755         declare.
4756         * tui/tui-winsource.c
4757         (tui_source_window_base::do_scroll_horizontal): Rename from
4758         tui_horizontal_source_scroll.
4759         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4760         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4761         from tui_vertical_data_scroll.
4762         * tui/tui-win.h (tui_scroll): Don't declare.
4763         * tui/tui-win.c (tui_win_info::forward_scroll)
4764         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4765         (tui_win_info::right_scroll): Rename and update.
4766         (tui_scroll_forward_command, tui_scroll_backward_command)
4767         (tui_scroll_left_command, tui_scroll_right_command): Update.
4768         (tui_scroll): Remove.
4769         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4770         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4771         from tui_vertical_source_scroll.
4772         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4773         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4774         from tui_vertical_disassem_scroll.
4775         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4776         do_scroll_horizontal>: New methods.
4777         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4778         Likewise.
4779         (struct tui_source_window_base): Add do_scroll_horizontal.
4780         (struct tui_source_window, struct tui_disasm_window): Add
4781         do_scroll_vertical.
4782         (struct tui_data_window, struct tui_cmd_window): Add
4783         do_scroll_horizontal and do_scroll_vertical.
4784         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4785
4786 2019-06-25  Tom Tromey  <tom@tromey.com>
4787
4788         * tui/tui-data.h (struct tui_source_window_base): New struct.
4789         (struct tui_source_window): Derive from tui_source_window_base.
4790         (struct tui_disasm_window): New struct.
4791         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4792         from tui_source_window::clear_detail.
4793         (tui_source_window_base): Rename from tui_source_window.
4794         (~tui_source_window_base): Rename from ~tui_source_window.
4795         (tui_alloc_win_info): Create a tui_disasm_window.
4796
4797 2019-06-25  Tom Tromey  <tom@tromey.com>
4798
4799         * tui/tui-data.h (struct tui_source_window)
4800         (struct tui_data_window): Declare destructors.
4801         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4802         destructors.
4803         (tui_win_info): Simplify.
4804
4805 2019-06-25  Tom Tromey  <tom@tromey.com>
4806
4807         * tui/tui-winsource.c (tui_display_main)
4808         (tui_update_source_windows_with_addr)
4809         (tui_update_all_breakpoint_info): Update.
4810         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4811         (new_height_ok, parse_scrolling_args): Update.
4812         * tui/tui-stack.c (tui_show_frame_info): Update.
4813         * tui/tui-data.h (struct tui_list): Remove.
4814         (tui_source_windows): Return a reference to a std::vector.
4815         * tui/tui-data.c (source_windows): Now a std::vector.
4816         (tui_source_windows): Change return type.
4817         (tui_clear_source_windows): Rewrite.
4818         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4819         (tui_free_all_source_wins_content): Rewrite.
4820
4821 2019-06-25  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4824         (struct tui_data_window, struct tui_cmd_window): Declare
4825         clear_detail method.
4826         * tui/tui-data.c (tui_source_window::clear_detail)
4827         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4828         methods.
4829         (tui_clear_win_detail): Simplify.
4830
4831 2019-06-25  Tom Tromey  <tom@tromey.com>
4832
4833         * tui/tui-layout.c (make_source_window, make_disasm_window)
4834         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4835         Return the new window.
4836         (show_source_disasm_command, show_data)
4837         (show_source_or_disasm_and_command): Update.
4838
4839 2019-06-25  Tom Tromey  <tom@tromey.com>
4840
4841         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4842         parameter.  Return the new window.
4843         (show_source_disasm_command): Update and remove NULL check.
4844         (show_source_or_disasm_and_command): Update.
4845
4846 2019-06-25  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4849
4850 2019-06-25  Tom Tromey  <tom@tromey.com>
4851
4852         * tui/tui-data.h (struct tui_win_info): Make constructor
4853         protected.  Make destructor virtual.  Add initializers.
4854         (tui_source_window, tui_data_window, tui_cmd_window): New
4855         classes.
4856         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4857         constructor.  Add "type" parameter.
4858         (tui_source_window, tui_data_window, tui_cmd_window): New
4859         constructors.
4860         (tui_alloc_win_info): Instantiate the appropriate subclass.
4861
4862 2019-06-25  Tom Tromey  <tom@tromey.com>
4863
4864         * tui/tui-win.c (tui_resize_all): Use delete.
4865         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4866         destructor.
4867         (tui_free_window): Don't declare.
4868         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4869         Update.
4870
4871 2019-06-25  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-data.h (struct tui_win_info): Add constructor.
4874         * tui/tui-data.c (tui_alloc_win_info): Use new.
4875         (tui_free_window): Use delete.
4876
4877 2019-06-22  Tom Tromey  <tom@tromey.com>
4878
4879         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4880         declare.
4881         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4882
4883 2019-06-22  Tom Tromey  <tom@tromey.com>
4884
4885         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4886         declare.
4887         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4888
4889 2019-06-22  Tom de Vries  <tdevries@suse.de>
4890
4891         * dwarf2read.c (create_addrmap_from_aranges)
4892         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4893         instead of '%zu'.
4894
4895 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4896
4897         * dwarf2read.h (dwarf2_section_info_def): Remove.
4898         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4899         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4900         std::vector<dwarf2_section_info>.
4901         (struct dwo_file) <~dwo_file>: Remove.
4902         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4903         types field.
4904         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4905         (dwarf2_read_debug_names): Likewise.
4906         (create_debug_types_hash_table): Change parameter type to
4907         array_view, adjust code accordingly.
4908         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4909         (partial_die_info::fixup): Likewise.
4910         (determine_prefix): Likewise.
4911         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4912
4913 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4914
4915         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4916         gdb_bfd_ref_ptr.
4917         <~dwo_file>: Remove call to gdb_bfd_unref.
4918         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4919         gdb_bfd_ref_ptr::get.
4920
4921 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4922
4923         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4924         type to htab_up.
4925         * dwarf2read.c (struct dwo_file): Initialize fields.
4926         <~dwo_file>: New.
4927         (free_dwo_file): Remove, move content to ~dwo_file.
4928         (struct dwo_file_deleter): Remove.
4929         (dwo_file_up>: Remove custom deleter.
4930         (free_dwo_files): Remove.
4931         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4932         dwo_files.
4933         (process_skeletonless_type_units): Call unique_ptr::get.
4934         (allocate_dwo_file_hash_table): Add deleter to created hash
4935         table.  Change return type to htab_up.
4936         (lookup_dwo_file_slot): Don't memset dwo_file, call
4937         unique_ptr::get.
4938         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4939         (create_dwo_unit_in_dwp_v2): Likewise.
4940         (open_and_init_dwo_file): Likewise.
4941         (free_dwo_file_from_slot): Remove.
4942
4943 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4944
4945         * dwarf2read.h (struct dwarf2_section_info) <readin,
4946         is_virtual>: Change type to bool.
4947         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4948         true instead of 1.
4949
4950 2019-06-19  Tom Tromey  <tom@tromey.com>
4951
4952         * tui/tui-data.h (tui_init_content_element): Don't declare.
4953
4954 2019-06-19  Tom Tromey  <tom@tromey.com>
4955
4956         * tui/tui-data.h (tui_init_win_info): Don't declare.
4957
4958 2019-06-19  Tom de Vries  <tdevries@suse.de>
4959
4960         * dwarf2read.h (abstract_to_concrete): Change type to
4961         std::unordered_map<sect_offset, std::vector<sect_offset>,
4962         gdb::hash_enum<sect_offset>>.
4963
4964 2019-06-19  Tom Tromey  <tromey@adacore.com>
4965
4966         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4967         EVAL_AVOID_SIDE_EFFECTS specially.
4968
4969 2019-06-19  Tom Tromey  <tromey@adacore.com>
4970
4971         * source-cache.c (highlighter): New global.
4972         (source_cache::get_source_lines): Create a highlighter on demand.
4973
4974 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * defs.h (deprecated_interactive_hook): Delete declaration.
4977         * interps.c (clear_interpreter_hooks): Remove use of
4978         deprecated_interactive_hook.
4979         * top.c (deprecated_interactive_hook): Delete definition.
4980         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4981
4982 2019-06-18  Tom de Vries  <tdevries@suse.de>
4983
4984         PR gdb/24515
4985         * dwarf2read.h (abstract_to_concrete): Change type from
4986         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4987         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4988         * dwarf2read.c (read_variable): Update.
4989         (dwarf2_fetch_die_loc_sect_off): Update.
4990
4991 2019-06-17  Tom de Vries  <tdevries@suse.de>
4992
4993         PR gdb/24617
4994         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4995         accessing parent[parent_len - 1].
4996
4997 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4998
4999         PR gdb/24364
5000         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5001         call dtrace_process_dof with NULL dof.
5002
5003 2019-06-16  Tom de Vries  <tdevries@suse.de>
5004
5005         PR gdb/24445
5006         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5007
5008 2019-06-16  Tom Tromey  <tom@tromey.com>
5009
5010         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5011         (make_all_visible): Use address of member.
5012
5013 2019-06-16  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5016         (tui_free_window, free_content, free_content_elements): Remove
5017         unnecessary cast.
5018         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5019         cast.
5020         * tui/tui-regs.c (tui_show_register_group)
5021         (tui_display_registers_from, tui_display_reg_element_at_line):
5022         Remove unnecessary cast.
5023
5024 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * linux-nat.c (normal_mask): Delete.
5027         (_initialize_linux_nat): Don't initialise normal_mask.
5028
5029 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5030
5031         PR gdb/24445
5032         * dwarf-index-write.h (write_psymtabs_to_index): Add
5033         dwz_basename parameter.
5034         * dwarf-index-write.c (write_gdbindex): Move file writing to
5035         write_gdbindex_1.  Change return type void.
5036         (assert_file_size): Move up, remove filename parameter.
5037         (write_gdbindex_1): New function.
5038         (write_debug_names): Change return type to void, call
5039         assert_file_size.
5040         (struct index_wip_file): New struct.
5041         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5042         file logic to index_wip_file.  Write index for dwz file if
5043         needed.
5044         (save_gdb_index_command): Pass basename of dwz file, if present.
5045         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5046         build-id of dwz file, if present.
5047         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5048         (dwarf2_get_dwz_file): Likewise.
5049         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5050         (dwarf2_get_dwz_file): Likewise.
5051
5052 2019-06-16  Tom Tromey  <tom@tromey.com>
5053
5054         * coffread.c (process_coff_symbol): Use xstrdup.
5055         * value.c (create_internalvar): Use xstrdup.
5056
5057 2019-06-16  Tom Tromey  <tom@tromey.com>
5058
5059         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5060         * breakpoint.c (stopin_command, stopat_command)
5061         (until_break_command, decode_location_default): Remove unnecessary
5062         cast.
5063         * utils.c (subset_compare): Remove unnecessary cast.
5064         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5065         cast.
5066         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5067         cast.
5068         * infcmd.c (path_command): Remove unnecessary cast.
5069         * coffread.c (decode_type): Remove unnecessary cast.
5070         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5071         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5072         * tui/tui-stack.c (tui_show_locator_content)
5073         (tui_show_frame_info): Remove unnecessary cast.
5074         * tui/tui-win.c (tui_scroll_forward_command)
5075         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5076         (parse_scrolling_args): Remove unnecessary cast.
5077         * tui/tui-data.c (init_win_info, tui_del_window)
5078         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5079         (free_content_elements): Remove unnecessary cast.
5080         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5081         unnecessary cast.
5082         * tui/tui-source.c (tui_set_source_content)
5083         (tui_vertical_source_scroll): Remove unnecessary cast.
5084         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5085         cast.
5086         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5087         * tui/tui-regs.c (tui_display_registers_from)
5088         (tui_display_register): Remove unnecessary cast.
5089         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5090         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5091         (make_visible): Remove unnecessary cast.
5092         * tui/tui-winsource.c (tui_erase_source_content)
5093         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5094         unnecessary cast.
5095         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5096         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5097         * stabsread.c (read_type, read_array_type, read_range_type):
5098         Remove unnecessary cast.
5099         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5100         (parse_symbol, parse_type, upgrade_type, parse_external)
5101         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5102         unnecessary cast.
5103         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5104
5105 2019-06-16  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-data.c (tui_alloc_generic_win_info)
5108         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5109         checks.
5110
5111 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5112             Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * f-typeprint.c (f_print_type): Don't return early for not
5115         associated or not allocated types.
5116         (f_type_print_varspec_suffix): Add print_rank parameter and print
5117         ranks of array types in case they dangling.
5118         (f_type_print_base): Add print_rank parameter.
5119
5120 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * NEWS: Mention new MI commands.
5123         * break-catch-throw.c (enum exception_event_kind): Move to
5124         breakpoint.h.
5125         (print_mention_exception_catchpoint): Output text as a single
5126         message.
5127         (catch_exception_command_1): Rename to...
5128         (catch_exception_event): ...this, make non-static, update header
5129         command, and change some parameter types.
5130         (catch_catch_command): Update for changes to
5131         catch_exception_command_1.
5132         (catch_throw_command): Likewise.
5133         (catch_rethrow_command): Likewise.
5134         * breakpoint.c (enum exception_event_kind): Delete.
5135         * breakpoint.h (enum exception_event_kind): Moved here from
5136         break-catch-throw.c.
5137         (catch_exception_event): Declare.
5138         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5139         (mi_cmd_catch_throw): New function.
5140         (mi_cmd_catch_rethrow): New function.
5141         (mi_cmd_catch_catch): New function.
5142         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5143         'catch-catch' entries.
5144         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5145         (mi_cmd_catch_rethrow): Declare.
5146         (mi_cmd_catch_catch): Declare.
5147
5148 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * annotate.c (annotate_source_line): Change return type to void,
5151         update implementation to match.
5152         * annotate.h (annotate_source_line): Change return type to void,
5153         update header comment.
5154         * stack.c (print_frame_info): Don't change what frame information
5155         is printed based on whether annotations are on or not.
5156
5157 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5160         (annotate_source): Make static.
5161         (annotate_source_line): Moved from source.c and renamed from
5162         identify_source_line.  Update the return type.
5163         * annotate.h (annotate_source): Delete declaration.
5164         (annotate_source_line): Declaration moved from source.h, and
5165         renamed from identify_source_line.  Return type updated.
5166         * source.c (identify_source_line): Moved to annotate.c and renamed
5167         to annotate_source_line.
5168         (info_line_command): Remove check of annotation_level.
5169         * source.h (identify_source_line): Move declaration to annotate.h
5170         and rename to annotate_source_line.
5171         * stack.c: Add 'annotate.h' include.
5172         (print_frame_info): Remove check of annotation_level before
5173         calling annotate_source_line.
5174
5175 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5176
5177         * source-cache.c (source_cache::get_plain_source_lines): Use
5178         open_source_file_with_line_charpos instead of just
5179         open_source_file, remove call to find_source_lines.
5180         (source_cache::get_source_lines): Likewise.
5181         * source.c (find_source_lines): Make static.
5182         (get_filename_and_charpos): Renamed into...
5183         (open_source_file_with_line_charpos): ..this along with changes to
5184         return a scoped_fd, and some other minor clean ups.
5185         (identify_source_line): Use open_source_file_with_line_charpos.
5186         (search_command_helper): Use open_source_file_with_line_charpos
5187         instead of just open_source_file, remove call to
5188         find_source_lines.
5189         * source.h (open_source_file_with_line_charpos): Declare new
5190         function.
5191         (find_source_lines): Delete declaration.
5192
5193 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * source.c (get_filename_and_charpos): Remove fullname
5196         parameter.
5197         (identify_source_line): Update call to get_filename_and_charpos.
5198
5199 2019-06-14  Tom Tromey  <tromey@adacore.com>
5200
5201         PR gdb/24502:
5202         * ui-style.h (skip_ansi_escape): Update comment.
5203         * ui-file.h (class no_terminal_escape_file): New class.
5204         * ui-file.c (no_terminal_escape_file::write)
5205         (no_terminal_escape_file::puts): New methods.
5206         * cli/cli-logging.c (handle_redirections): Use
5207         no_terminal_escape_file.
5208
5209 2019-06-14  Tom Tromey  <tromey@adacore.com>
5210
5211         * NEWS: Move convenience variable news above Python news.
5212
5213 2019-06-14  Tom Tromey  <tom@tromey.com>
5214
5215         * gnulib: Move directory to top-level.
5216         * configure.ac: Don't configure gnulib.
5217         * configure: Rebuild.
5218         * common/common-defs.h: Use new path to gnulib.
5219         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5220         (GNULIB_H): Remove.
5221         (INCGNU): Look in new gnulib location.
5222         (HFILES_NO_SRCDIR): Remove gnulib files.
5223         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5224         (generated_files): Remove GNULIB_H.
5225         ($(LIBGNU), all-lib): Remove targets.
5226         (distclean): Don't mention GNULIB_BUILDDIR.
5227         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5228
5229 2019-06-14  Tom Tromey  <tromey@adacore.com>
5230
5231         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5232         Warn if symbol file does not provide any symbols.
5233
5234 2019-06-14  Tom Tromey  <tromey@adacore.com>
5235
5236         * source.c (find_and_open_source): Respect basenames_may_differ.
5237
5238 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5239
5240         * annotate.c (annotate_breakpoints_invalid): Make use of
5241         scoped_restore_terminal_state.
5242         (annotate_frames_invalid): Likewise.
5243
5244 2019-06-14  Tom Tromey  <tromey@adacore.com>
5245
5246         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5247         allow assignment to an internalvar.
5248
5249 2019-06-14  Tom Tromey  <tromey@adacore.com>
5250
5251         * ada-lex.l: Allow "_" in attribute names.
5252
5253 2019-06-14  Tom Tromey  <tromey@adacore.com>
5254
5255         PR gdb/24653:
5256         * regcache.c (registers_changed): Don't call alloca.
5257         * top.c (execute_command): Don't call alloca.
5258
5259 2019-06-13  Pedro Alves  <palves@redhat.com>
5260
5261         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5262         'expression'.  When parsing an expression, error out if there's
5263         junk after "unlimited".
5264         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5265         (do_set_command): Adjust calls to is_unlimited_literal.
5266
5267 2019-06-13  Pedro Alves  <palves@redhat.com>
5268
5269         * compile/compile.c (make_compile_options_def_group): Add braces
5270         around array_view initializer.
5271         * thread.c (make_thread_apply_all_options_def_group)
5272         (make_thread_apply_all_options_def_group): Likewise.
5273
5274 2019-06-13  Pedro Alves  <palves@redhat.com>
5275
5276         * NEWS (New commands): Mention "maint test-options
5277         require-delimiter", "maint test-options unknown-is-error", "maint
5278         test-options unknown-is-operand" and "maint show
5279         test-options-completion-result".
5280         (New command options, command completion): New section.
5281         (Completion improvements): New section.
5282         Mention that you can abbreviate "unlimited".
5283
5284 2019-06-13  Pedro Alves  <palves@redhat.com>
5285
5286         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5287         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5288         * unittests/cli-utils-selftests.c (test_parse_flags)
5289         (test_parse_flags_qcs): Delete.
5290         (test_cli_utils): Don't call deleted functions.
5291
5292 2019-06-13  Pedro Alves  <palves@redhat.com>
5293
5294         * thread.c: Include "cli/cli-option.h".
5295         (tp_array_compar_ascending): Global.
5296         (tp_array_compar): Delete function.
5297         (tp_array_compar_ascending, tp_array_compar_descending): New
5298         functions.
5299         (ascending_option_def, qcs_flag_option_def)
5300         (thr_qcs_flags_option_defs)
5301         (make_thread_apply_all_options_def_group)
5302         (make_thread_apply_options_def_group): New.
5303         (thread_apply_all_command): Use gdb::option::process_options.
5304         (thread_apply_command_completer)
5305         (thread_apply_all_command_completer): New.
5306         (thread_apply_command): Use gdb::option::process_options.
5307         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5308         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5309         to generate help text of "thread apply".  Adjust "taas"'s help.
5310         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5311         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5312
5313 2019-06-13  Pedro Alves  <palves@redhat.com>
5314
5315         * thread.c (thread_apply_command): Check for invalid TID with
5316         isdigit instead of !isalpha.
5317
5318 2019-06-13  Pedro Alves  <palves@redhat.com>
5319
5320         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5321         (validate_flags_qcs): New.
5322         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5323         (validate_flags_qcs): Declare.
5324         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5325         (make_frame_apply_options_def_group): New.
5326         (frame_apply_command_count): Process options with
5327         gdb::option::process_options.
5328         (frame_apply_completer): New.
5329         (frame_apply_level_completer, frame_apply_all_completer)
5330         (frame_apply_completer): New.
5331         (_initialize_stack): Update help of "frame apply", "frame apply
5332         level", "frame apply all" and "faas" to mention supported options
5333         and install command completers.
5334         * stack.h (frame_apply_all_completer): Declare.
5335         * thread.c: Include "stack.h".
5336         (tfaas_command): Add "--".
5337         (_initialize_thread): Update help "tfaas" to mention supported
5338         options and install command completer.
5339
5340 2019-06-13  Pedro Alves  <palves@redhat.com>
5341
5342         * completer.c (complete_nested_command_line): New.
5343         (gdb_completion_word_break_characters_throw): Add assertion.
5344         * completer.h (complete_nested_command_line): Declare.
5345
5346 2019-06-13  Pedro Alves  <palves@redhat.com>
5347
5348         * stack.c (parse_backtrace_qualifiers): New.
5349         (backtrace_command): Use it.
5350         (backtrace_command_completer): Complete on qualifiers.
5351
5352 2019-06-13  Pedro Alves  <palves@redhat.com>
5353
5354         * frame.c: Include "cli/cli-option.h.
5355         (user_set_backtrace_options): New.
5356         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5357         Delete.
5358         (get_prev_frame): Adjust.
5359         (boolean_option_def, uinteger_option_def)
5360         (set_backtrace_option_defs): New.
5361         (_initialize_frame): Adjust and use
5362         gdb::option::add_setshow_cmds_for_options to install "set
5363         backtrace past-main" and "set backtrace past-entry".
5364         * frame.h: Include "cli/cli-option.h".
5365         (struct frame_print_options): Forward declare.
5366         (print_frame_arguments_all, print_frame_arguments_scalars)
5367         (print_frame_arguments_none): Declare.
5368         (print_entry_values): Delete declaration.
5369         (struct frame_print_options, user_frame_print_options): New.
5370         (struct set_backtrace_options): New.
5371         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5372         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5373         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5374         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5375         (list_args_or_locals): Add frame_print_options parameter.
5376         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5377         * python/py-framefilter.c (enumerate_args): Pass down
5378         USER_FRAME_PRINT_OPTIONS.
5379         * stack.c: Include "cli/cli-option.h".
5380         (print_frame_arguments_all, print_frame_arguments_scalars)
5381         (print_frame_arguments_none): Declare.
5382         (print_raw_frame_arguments, print_entry_values): Delete.
5383         (user_frame_print_options): New.
5384         (boolean_option_def, enum_option_def, frame_print_option_defs):
5385         New.
5386         (struct backtrace_cmd_options): New.
5387         (bt_flag_option_def): New.
5388         (backtrace_command_option_defs): New.
5389         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5390         (print_frame_arg, read_frame_arg, print_frame_args)
5391         (print_frame_info, print_frame): Add frame_print_options parameter
5392         and use it.
5393         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5394         (backtrace_command_1): Add frame_print_options and
5395         backtrace_cmd_options parameters and use them.
5396         (make_backtrace_options_def_group): New.
5397         (backtrace_command): Process command options with
5398         gdb::option::process_options.
5399         (backtrace_command_completer): New.
5400         (_initialize_stack): Extend "backtrace"'s help to mention
5401         supported options.  Install completer for "backtrace".
5402         Install some settings commands with add_setshow_cmds_for_options.
5403
5404 2019-06-13  Pedro Alves  <palves@redhat.com>
5405
5406         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5407         and that "set/show print raw frame-arguments" are now deprecated.
5408
5409         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5410         command.
5411         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5412         * stack.c (_initialize_stack): Install "set/show print
5413         raw-frame-arguments", and deprecate "set/show print raw
5414         frame-arguments".
5415         * valprint.c (_initialize_valprint): Deprecate "set/show print
5416         raw".
5417
5418 2019-06-13  Pedro Alves  <palves@redhat.com>
5419
5420         * compile/compile.c (struct compile_options): New.
5421         (compile_flag_option_def, compile_command_option_defs)
5422         (make_compile_options_def_group): New.
5423         (compile_file_command): Handle options with
5424         gdb::option::process_options.
5425         (compile_file_command_completer): New function.
5426         (compile_code_command): Handle options with
5427         gdb::option::process_options.
5428         (compile_code_command_completer): New function.
5429         (_initialize_compiler): Install completers for "compile code" and
5430         "compile file".  Mention available options in "compile code" and
5431         "compile code"'s help.
5432         * completer.c (advance_to_completion_word): New, factored out from
5433         ...
5434         (advance_to_expression_complete_word_point): ... this.
5435         (advance_to_filename_complete_word_point): New.
5436         * completer.h (advance_to_filename_complete_word_point): New
5437         declaration.
5438
5439 2019-06-13  Pedro Alves  <palves@redhat.com>
5440
5441         * compile/compile.c: Include "cli/cli-option.h".
5442         (compile_print_value): Scope data pointer is now a
5443         value_print_options pointer; adjust.
5444         (compile_print_command): Process options.  Scope data pointer is
5445         now a value_print_options pointer; adjust.
5446         (_initialize_compile): Update "compile print"'s help to include
5447         supported options.  Install a completer for "compile print".
5448         * cp-valprint.c (show_vtblprint, show_objectprint)
5449         (show_static_field_print): Delete.
5450         (_initialize_cp_valprint): Don't install "set print
5451         static-members", "set print vtbl", "set print object" here.
5452         * printcmd.c: Include "cli/cli-option.h" and
5453         "common/gdb_optional.h".
5454         (print_command_parse_format): Rework to fill in a
5455         value_print_options instead of a format_data.
5456         (print_value): Change parameter type from format_data pointer to
5457         value_print_options reference.  Adjust.
5458         (print_command_1): Process options.  Adjust to pass down a
5459         value_print_options.
5460         (print_command_completer): New.
5461         (_initialize_printcmd): Install print_command_completer as
5462         handle_brkchars completer for the "print" command.  Update
5463         "print"'s help to include supported options.
5464         * valprint.c: Include "cli/cli-option.h".
5465         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5466         here from cp-valprint.c.
5467         (boolean_option_def, uinteger_option_def)
5468         (value_print_option_defs, make_value_print_options_def_group):
5469         New.  Use gdb::option::add_setshow_cmds_for_options to install
5470         "set print elements", "set print null-stop", "set print repeats",
5471         "set print pretty", "set print union", "set print array", "set
5472         print address", "set print symbol", "set print array-indexes".
5473         * valprint.h: Include <string> and "cli/cli-option.h".
5474         (make_value_print_options_def_group): Declare.
5475         (print_value): Change parameter type from format_data pointer to
5476         value_print_options reference.
5477         (print_command_completer): Declare.
5478
5479 2019-06-13  Pedro Alves  <palves@redhat.com>
5480
5481         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5482         (COMMON_SFILES): Add maint-test-settings.c.
5483         * cli/cli-decode.c (boolean_enums): New global, factored out from
5484         ...
5485         (add_setshow_boolean_cmd): ... here.
5486         * cli/cli-decode.h (boolean_enums): Declare.
5487         * cli/cli-option.c: New file.
5488         * cli/cli-option.h: New file.
5489         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5490         factored out from ...
5491         (parse_cli_boolean_value(const char *)): ... this.
5492         (is_unlimited_literal): Change parameter type to pointer to
5493         pointer.  Adjust and advance ARG pointer.
5494         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5495         (parse_cli_var_enum): New, factored out from ...
5496         (do_set_command): ... this.  Adjust.
5497         * cli/cli-setshow.h (parse_cli_boolean_value)
5498         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5499         (parse_cli_var_enum): Declare.
5500         * cli/cli-utils.c: Include "cli/cli-option.h".
5501         (get_ulongest): New.
5502         * cli/cli-utils.h (get_ulongest): Declare.
5503         (check_for_argument): New overloads.
5504         * maint-test-options.c: New file.
5505
5506 2019-06-13  Pedro Alves  <palves@redhat.com>
5507
5508         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5509         parse a range if "-" is at the end of the string.
5510
5511 2019-06-13  Pedro Alves  <palves@redhat.com>
5512
5513         * cli/cli-setshow.c (parse_auto_binary_operation)
5514         (parse_cli_boolean_value): Don't allow "o".
5515
5516 2019-06-13  Pedro Alves  <palves@redhat.com>
5517
5518         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5519         * NEWS: Mention maint test-settings KIND.
5520         * maint-test-settings.c: New file.
5521
5522 2019-06-13  Pedro Alves  <palves@redhat.com>
5523
5524         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5525         completer.
5526         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5527         "set" completers.
5528
5529 2019-06-13  Pedro Alves  <palves@redhat.com>
5530
5531         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5532         after item.
5533
5534 2019-06-13  Pedro Alves  <palves@redhat.com>
5535
5536         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5537
5538 2019-06-13  Pedro Alves <palves@redhat.com>
5539
5540         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5541         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5542         call.
5543         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5544         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5545         calls.
5546         (check_for_argument): Skip spaces after argument.
5547
5548 2019-06-13  Pedro Alves  <palves@redhat.com>
5549
5550         * thread.c (thread_apply_command): Adjust TID parsing.
5551         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5552         detected before end of string.
5553         (tid_is_in_list): Error out if LIST is invalid.
5554
5555 2019-06-13  Pedro Alves  <palves@redhat.com>
5556
5557         * completer.c (complete_line_internal_1): Rewind completion word
5558         point.
5559         (completion_tracker::advance_custom_word_point_by): Change
5560         parameter type to int.
5561         * completer.h (completion_tracker::advance_custom_word_point_by):
5562         Likewise.
5563
5564 2019-06-13  Pedro Alves  <palves@redhat.com>
5565
5566         * completer.c (advance_to_completion_word): Handle delimiters.
5567
5568 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5569
5570         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5571
5572 2019-06-11  Tom Tromey  <tom@tromey.com>
5573
5574         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5575         (xmalloc_failed): Move to alloc.c.
5576         * alloc.c: New file.
5577         * Makefile.in (COMMON_SFILES): Add alloc.c.
5578
5579 2019-06-11  Tom Tromey  <tom@tromey.com>
5580
5581         * nat/linux-waitpid.c: Don't include server.h.
5582         (linux_debug): Remove.
5583         (my_waitpid): Update.
5584
5585 2019-06-11  Tom Tromey  <tromey@adacore.com>
5586
5587         * infcall.c (_initialize_infcall): Remove trailing newline from
5588         help.
5589         * user-regs.c (_initialize_user_regs): Remove trailing newline
5590         from help.
5591         * typeprint.c (_initialize_typeprint): Remove trailing newline
5592         from help.
5593         * reverse.c (_initialize_reverse): Remove trailing newlines from
5594         help.
5595         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5596         from help.
5597         * language.c (add_set_language_command): Remove trailing newline
5598         from help.
5599         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5600         help.
5601         * disasm.c (_initialize_disasm): Remove trailing newline from
5602         help.
5603         * top.c (init_main): Remove trailing newline from help.
5604         * interps.c (_initialize_interpreter): Remove trailing newline
5605         from help.
5606         * btrace.c (_initialize_btrace): Remove trailing newlines from
5607         help.
5608         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5609         from help.
5610         * python/python.c (_initialize_python): Remove trailing newline
5611         from help.
5612         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5613         help.
5614         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5615         from help.  Reformat some text.
5616         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5617         from help.
5618         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5619         newline from help.
5620
5621 2019-06-11  Tom Tromey  <tromey@adacore.com>
5622
5623         * darwin-nat.c (darwin_decode_exception_message)
5624         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5625
5626 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5627
5628         * valops.c (value_slice): Check for not allocated or not
5629         associated values.
5630
5631 2019-06-10  Tom de Vries  <tdevries@suse.de>
5632
5633         PR gdb/24618
5634         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5635         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5636         invalid.
5637
5638 2019-06-10  Tom de Vries  <tdevries@suse.de>
5639
5640         PR gdb/24611
5641         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5642         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5643
5644 2019-06-10  Tom de Vries  <tdevries@suse.de>
5645
5646         PR symtab/24545
5647         * symtab.c (struct demangled_name_entry): Add language field.
5648         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5649         static minimal symbol".  Set and use language field.
5650
5651 2019-06-10  Tom Tromey  <tromey@adacore.com>
5652
5653         * ada-lang.c (_initialize_ada_language): Update help text.
5654
5655 2019-06-10  Tom Tromey  <tromey@adacore.com>
5656
5657         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5658         with a newline.
5659         * guile/guile.c (handle_boot_error): Don't end warning with a
5660         newline.
5661         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5662         warning with a newline.
5663         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5664         newline.
5665         (s12z_frame_cache): Likewise.
5666         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5667         a newline.
5668         * solib-svr4.c (disable_probes_interface): Don't end warning with
5669         a newline.
5670         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5671         newline.
5672         * python/python.c (do_finish_initialization): Don't end warning
5673         with a newline.
5674
5675 2019-06-10  Tom Tromey  <tom@tromey.com>
5676
5677         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5678         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5679         gdbpy_enter.
5680
5681 2019-06-10  Tom Tromey  <tromey@adacore.com>
5682
5683         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5684         data.
5685         (elf_new_init): Don't call stabsread_new_init.
5686         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5687         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5688         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5689
5690 2019-06-10  Tom de Vries  <tdevries@suse.de>
5691
5692         PR symtab/16264
5693         PR symtab/24517
5694         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5695
5696 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5697
5698         * source.c (find_and_open_source): Also rewrite relative file
5699         names.
5700
5701 2019-04-26  Amos Bird  <amosbird@gmail.com>
5702
5703         * annotate.c (annotate_thread_exited): Add "thread-exited"
5704         annotation.
5705
5706 2019-06-06  Tom Tromey  <tromey@adacore.com>
5707
5708         * maint.h (class scoped_command_stats): Use
5709         DISABLE_COPY_AND_ASSIGN.
5710         <print_time>: New method.
5711         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5712         print_time.
5713         (scoped_command_stats::print_time): New method.
5714
5715 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5718         instructions of lengths 6 or 8 bytes.
5719
5720 2019-06-04  Pedro Alves  <palves@redhat.com>
5721
5722         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5723
5724         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5725         * breakpoint.c (condition_completer): Likewise.
5726         * cli/cli-dump.c (scan_expression): Likewise.
5727         * common/filestuff.c (mkdir_recursive): Likewise.
5728         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5729         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5730         (gdb_abspath): Likewise.
5731         * compile/compile-cplus-types.c
5732         (compile_cplus_instance::decl_name): Likewise.
5733         * completer.c (complete_explicit_location):
5734         (signal_completer, reg_or_group_completer_1): Likewise.
5735         * cp-support.c (cp_remove_params_if_any): Likewise.
5736         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5737         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5738         * infcmd.c (strip_bg_char): Likewise.
5739         * linespec.c (copy_token_string): Likewise.
5740         * mi/mi-main.c (output_cores): Likewise.
5741         * psymtab.c (psymtab_search_name):
5742         * symfile.c (test_set_ext_lang_command): Likewise.
5743         * target.c (target_fileio_read_stralloc): Likewise.
5744         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5745         * value.c (complete_internalvar): Likewise.
5746
5747 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5748
5749         Add objfile property to gdb.Type.
5750         * NEWS: Mention Python API addition.
5751         * python/py-type.c (typy_get_objfile): New method.
5752
5753 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5754
5755         * NEWS: Mention the new set|show style [title|highlight].
5756         Mention changes to "show style", "help" and "apropos".
5757
5758 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5759
5760         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5761         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5762         instead of print_help_for_command.
5763         (print_doc_of_command): New function.
5764         (help_list): Add 'apropos -v word' suggestion.
5765         (print_help_for_command): Style the command name using title style.
5766         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5767         (_initialize_cli_cmds): Describe -v in apropos_command help.
5768
5769 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5770
5771         * cli/cli-style.h (cli_style_option): Add name in constructor,
5772         add m_name class member, add constructor with intensity,
5773         add name class function.
5774         (cli_style_option::add_setshow_commands): Remove name argument.
5775         (highlight_style, title_style): New styles.
5776         * cli/cli-style.c (do_show): New function that shows a style
5777         characteristic styling the style name with itself.
5778         (set_style_name): New function.
5779         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5780         Update all callers according to the changes in cli/cli-style.h.
5781         * utils.h (fputs_highlighted): New function.
5782         * utils.c (fputs_highlighted): Likewise.
5783
5784 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5785
5786         * NEWS: Mention new pipe command and new convenience variables.
5787
5788 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5789
5790         * cli/cli-cmds.c (pipe_command): New function.
5791         (_initialize_cli_cmds): Call add_com for pipe_command.
5792         Define | as an alias for pipe.
5793         (exit_status_set_internal_vars): New function.
5794         (shell_escape): Call exit_status_set_internal_vars.
5795         cli/cli-decode.c (find_command_name_length): Recognize | as
5796         a single character command.
5797
5798 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5799
5800         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5801         top.c (execute_command_to_ui_file): New function, mostly a copy
5802         of execute_command_to_string.
5803         (execute_command_to_string): Implement by calling
5804         execute_command_to_ui_file.
5805
5806 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5807
5808         * top.h (saved_command_line): Remove declaration.
5809         * top.c (previous_saved_command_line, previous_repeat_arguments):
5810         New variables.
5811         (saved_command_line): Make static, define together with other
5812         'repeat variables'.
5813         (dont_repeat): Clear repeat_arguments.
5814         (repeat_previous, get_saved_command_line, save_command_line):
5815         New functions.
5816         (gdb_init): Initialize saved_command_line
5817         and previous_saved_command_line.
5818         * main.c (captured_main_1): Remove saved_command_line initialization.
5819         * event-top.c (handle_line_of_input): Update to use
5820         the new 'repeat' related functions instead of direct access to
5821         saved_command_line.
5822         * command.h (repeat_previous, get_saved_command_line,
5823         save_command_line): New declarations.
5824         (dont_repeat): Add comment.
5825
5826 2019-05-30  Tom Tromey  <tromey@adacore.com>
5827
5828         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5829         Fix comment.
5830         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5831
5832 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5833
5834         PR cli/24587
5835         * completer.c (complete): Initialize variable word.
5836
5837 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5838
5839         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5840         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5841         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5842         'body' is NULL to the outter 'if', protecting the '!is_define'
5843         situation as well.
5844
5845 2019-05-29  Tom Tromey  <tromey@adacore.com>
5846
5847         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5848         (dwarf_unknown): New function.
5849         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5850         (dwarf_type_encoding_name): Use dwarf_unknown.
5851
5852 2019-05-29  Tom Tromey  <tromey@adacore.com>
5853
5854         PR c++/20020:
5855         * cp-valprint.c (cp_print_value_fields): Call
5856         cp_print_static_field inside "try".
5857
5858 2019-05-29  Tom Tromey  <tromey@adacore.com>
5859
5860         * inflow.c (struct terminal_info): Add default operator=.
5861         * configure: Rebuild.
5862         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5863         -Wdeprecated-copy-dtor, -Wredundant-move.
5864
5865 2019-05-29  Tom Tromey  <tromey@adacore.com>
5866
5867         * NEWS: Add entry.
5868         * infcmd.c (print_return_value_1): Handle finish_print
5869         option.
5870         (show_print_finish): New function.
5871         (_initialize_infcmd): Add "set/show print finish" commands.
5872         * valprint.c (user_print_options): Initialize new member.
5873         * valprint.h (struct value_print_options) <finish_print>: New
5874         member.
5875
5876 2019-05-28  Tom Tromey  <tromey@adacore.com>
5877
5878         * ada-lang.c (ada_remove_Xbn_suffix)
5879         (find_old_style_renaming_symbol)
5880         (parse_old_style_renaming): Remove.
5881         (ada_find_renaming_symbol): Don't call
5882         find_old_style_renaming_symbol.
5883         (ada_is_renaming_symbol): Rename from
5884         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5885         bool.  Now static.
5886         (ada_read_var_value): Update and simplify.
5887         * ada-exp.y (write_var_or_type): Remove old code.
5888
5889 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5890
5891         * event-top.c: Remove include comment.
5892         * inflow.c (class scoped_ignore_sigttou): Move from here...
5893         * inflow.h (class scoped_ignore_sigttou): ...to here.
5894         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5895         * top.c:  Remove include comment.
5896
5897 2019-05-27  Tom Tromey  <tom@tromey.com>
5898
5899         * NEWS: Fix typo.
5900
5901 2019-05-22  Tom Tromey  <tromey@adacore.com>
5902
5903         * target.c (target_follow_exec): Constify parameter.
5904         * target-delegates.c: Rebuild.
5905         * remote.c (remote_target::follow_exec): Constify parameter.
5906         * infrun.c (follow_exec): Constify parameter.
5907         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5908         (target_follow_exec): Likewise.
5909
5910 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5911
5912         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5913         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5914
5915 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5916
5917         * NEWS: Add debugredirect and testsuite sections.
5918
5919 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5920
5921         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5922         target descriptions using exclusively floating point register name
5923         aliases.
5924
5925 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         PR gdb/18644:
5928         * f-lang.c (build_fortran_types): Handle the case where
5929         gdbarch_floatformat_for_type returns a nullptr.
5930
5931 2019-05-21  Tom de Vries  <tdevries@suse.de>
5932
5933         PR cli/24587
5934         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5935
5936 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5937
5938         PR gdb/18644:
5939         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5940         16-byte floats.
5941         * i386-tdep.c (i386_floatformat_for_type): Use
5942         floatformats_ia64_quad for the 16-byte floating point component
5943         within a fortran 32-byte complex number.
5944
5945 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5948         delete default constructor.
5949         (find_partial_die): Update to return const struct.
5950         (partial_die_parent_scope): Move variable declaration into scope
5951         of its use and change its type to auto.
5952         (guess_partial_die_structure_name): Likewise.
5953         (partial_die_info::fixup): Likewise.
5954
5955 2019-05-17  Tom Tromey  <tromey@adacore.com>
5956
5957         * source.c (find_and_open_source): Remove cast.
5958
5959 2019-05-17  Tom Tromey  <tromey@adacore.com>
5960
5961         * annotate.c (annotate_source): Make "filename" const.
5962         * annotate.h (annotate_source): Use const.
5963
5964 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5965
5966         * disasm.c (set_disassembler_options): Send errors to stderr.
5967
5968 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5969
5970         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5971         (cli_interp_base::set_logging): Check debug_redirect.
5972         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5973         * cli/cli-logging.c (debug_redirect): Add static variable.
5974         (pop_output_files): Add default param.
5975         (handle_redirections): Print debug setting.
5976         (show_logging_command): Likewise.
5977         (_initialize_cli_logging): Add debugredirect command.
5978         * interps.c (current_interp_set_logging): Add debug_redirect
5979         parameter.
5980         * interps.h (set_logging): Add debug_redirect parameter.
5981         (current_interp_set_logging): Likewise.
5982         * mi/mi-common.h: Likewise.
5983         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5984
5985 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5986             Tom Tromey  <tromey@adacore.com>
5987
5988         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5989         directly.
5990         * cli/cli-interp.h (make_logging_output): Remove declaration.
5991         * cli/cli-logging.c (make_logging_output): Remove function.
5992         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5993         directly.
5994         * ui-file.c (tee_file::tee_file): Remove bools.
5995         (tee_file::~tee_file): Remove deletes.
5996         * ui-file.h (tee_file): Remove bools.
5997
5998 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5999
6000         * mi/mi-cmds.h (mi_cmd_complete): New function.
6001         * mi/mi-main.c (mi_cmd_complete): Likewise.
6002         * mi/mi-cmds.c: Define new MI command -complete.
6003         * NEWS: Mention new -complete command.
6004
6005 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6006
6007         * completer.h (complete): New function.
6008         * completer.c (complete): Likewise.
6009         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6010         function defined in completer.h.
6011
6012 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6013
6014         * MAINTAINERS (Write After Approval): Add myself.
6015
6016 2019-05-17  Tom de Vries  <tdevries@suse.de>
6017
6018         PR gdb/24094
6019         * dwarf2read.c (struct cu_partial_die_info): New struct.
6020         (find_partial_die): Return cu_partial_die_info.
6021         (partial_die_parent_scope, guess_partial_die_structure_name)
6022         (partial_die_info::fixup): Handle new return type of find_partial_die.
6023
6024 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6025
6026         PR breakpoints/24541
6027         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6028         "std::string", simplifying the algorithm.
6029
6030 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6031
6032         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6033         (stap_static_probe_ops::get_probes): Likewise.
6034
6035 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6036
6037         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6038         '-')" and "else if".
6039         (stap_parse_single_operand): Join checks for
6040         "gdbarch_stap_parse_special_token_p" and
6041         "gdbarch_stap_parse_special_token" in the same "if" statement.
6042         Invert check when verifying for operation on register
6043         displacement.
6044
6045 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6046
6047         * stap-probe.c (stap_get_opcode): Update comment.
6048         (stap_get_expected_argument_type): Likewise.
6049         (handle_stap_probe): Likewise.
6050
6051 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6052
6053         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6054         return type to 'bool'.  Adjust comment.  Use 'bool' when
6055         appropriate.
6056         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6057         * stap-probe.c (stap_parse_argument_1): Likewise.
6058         (stap_is_operator): Likewise.
6059         (stap_is_generic_prefix): Likewise.
6060         (stap_is_register_prefix): Likewise.
6061         (stap_is_register_indirection_prefix): Likewise.
6062         (stap_is_integer_prefix): Likewise.
6063         (stap_generic_check_suffix): Likewise.
6064         (stap_check_integer_suffix): Likewise.
6065         (stap_check_register_suffix): Likewise.
6066         (stap_check_register_indirection_suffix): Likewise.
6067         (stap_parse_register_operand): Likewise.
6068         (stap_parse_single_operand): Likewise.
6069         (stap_parse_argument_1): Likewise.
6070         (stap_probe::get_argument_count): Likewise.
6071         (stap_is_operator): Likewise.
6072
6073 2019-05-16  Tom Tromey  <tromey@adacore.com>
6074
6075         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6076         keyword to foreach.
6077
6078 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6079
6080         * linux-thread-db.c (try_thread_db_load_1): Change return type
6081         to bool.
6082         (try_thread_db_load): Likewise.
6083         (try_thread_db_load_from_pdir_1): Likewise.
6084         (try_thread_db_load_from_pdir): Likewise.
6085         (try_thread_db_load_from_sdir): Likewise.
6086         (try_thread_db_load_from_dir): Likewise.
6087         (thread_db_load_search): Likewise.
6088         (has_libpthread): Likewise.
6089         (thread_db_load): Likewise.
6090
6091 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6092
6093         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6094         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6095         NULL, and complain/return if that's the case.
6096
6097 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6098
6099         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6100         (advance, posn, abstract_read_memory): New functions.
6101         [struct mem_read_abstraction]: New struct.
6102         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6103
6104 2019-05-14  Tom Tromey  <tromey@adacore.com>
6105
6106         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6107         value is not lval_memory.
6108
6109 2019-05-14  Tom Tromey  <tromey@adacore.com>
6110
6111         * solib.c (info_sharedlibrary_command): Style the file name.
6112
6113 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6114
6115         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6116         (aarch64_vnv_type): Likewise.
6117         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6118         * common/tdesc.c: Likewise.
6119         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6120         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6121         * features/aarch64-fpu.xml: Add ieee half view.
6122         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6123         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6124         * gdbtypes.h (struct builtin_type): Likewise.
6125         (struct objfile_type): Likewise.
6126
6127 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6128
6129         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6130         typo.
6131         * location.h (string_to_event_location): Likewise.
6132
6133 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6134
6135         GDB 8.3 released.
6136
6137 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6138
6139         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6140         New variable declaration.
6141         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6142         New variable.
6143         (print_one_breakpoint): Use ui_out::test_flags and new global
6144         variable to compute use_fixed_output.
6145         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6146         Remove.
6147         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6148         (mi_multi_location_breakpoint_output_fixed): Remove.
6149         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6150         new variable.
6151         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6152         fix_multi_location_breakpoint_output flag if version >= 3.
6153         * ui-out.h (enum ui_out_flag)
6154         <fix_multi_location_breakpoint_output>: New enumerator.
6155
6156 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6157
6158         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6159
6160 2019-05-10  Tom Tromey  <tromey@adacore.com>
6161
6162         * ada-lang.c (catch_ada_completer): New function.
6163         (_initialize_ada_language): Use it.
6164
6165 2019-05-10  Tom Tromey  <tromey@adacore.com>
6166
6167         * thread.c (print_thread_info): Make "requested_threads" const.
6168         * gdbthread.h (print_thread_info): Make "requested_threads"
6169         const.
6170         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6171         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6172
6173 2019-05-08  Tom Tromey  <tom@tromey.com>
6174
6175         * gdbtypes.c (objfile_type_data): Change type.
6176         (objfile_type, _initialize_gdbtypes): Update.
6177
6178 2019-05-08  Tom Tromey  <tom@tromey.com>
6179
6180         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6181         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6182         (_initialize_dwarf2_frame): Update.
6183
6184 2019-05-08  Tom Tromey  <tom@tromey.com>
6185
6186         * objc-lang.c (objc_objfile_data): Change type.
6187         (find_methods): Update.
6188         (_initialize_objc_lang): Remove.
6189
6190 2019-05-08  Tom Tromey  <tom@tromey.com>
6191
6192         * stabsread.c (rs6000_builtin_type_data): Change type.
6193         (rs6000_builtin_type, _initialize_stabsread): Update.
6194
6195 2019-05-08  Tom Tromey  <tom@tromey.com>
6196
6197         * mips-tdep.c (mips_pdr_data): Remove.
6198         (_initialize_mips_tdep): Update.
6199
6200 2019-05-08  Tom Tromey  <tom@tromey.com>
6201
6202         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6203         (hppa_init_objfile_priv_data, read_unwind_info)
6204         (find_unwind_entry, _initialize_hppa_tdep): Update.
6205
6206 2019-05-08  Tom Tromey  <tom@tromey.com>
6207
6208         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6209         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6210         on obstack.
6211         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6212
6213 2019-05-08  Tom Tromey  <tom@tromey.com>
6214
6215         * mdebugread.c (basic_type_data): Change type.
6216         (basic_type, _initialize_mdebugread): Update.
6217
6218 2019-05-08  Tom Tromey  <tom@tromey.com>
6219
6220         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6221
6222 2019-05-08  Tom Tromey  <tom@tromey.com>
6223
6224         * nto-tdep.c (nto_inferior_data_reg): Change type.
6225         (nto_inferior_data): Update.
6226         (nto_inferior_data_cleanup, nto_new_inferior_data)
6227         (_initialize_nto_tdep): Remove.
6228         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6229
6230 2019-05-08  Tom Tromey  <tom@tromey.com>
6231
6232         * ada-lang.c (struct ada_inferior_data): Add initializers.
6233         (ada_inferior_data): Change type.
6234         (ada_inferior_data_cleanup): Remove.
6235         (get_ada_inferior_data, ada_inferior_exit)
6236         (struct ada_pspace_data): Add initializers, destructor.
6237         (ada_pspace_data_handle): Change type.
6238         (get_ada_pspace_data): Update.
6239         (ada_pspace_data_cleanup): Remove.
6240
6241 2019-05-08  Tom Tromey  <tom@tromey.com>
6242
6243         * coffread.c (struct coff_symfile_info): Add initializers.
6244         (coff_objfile_data_key): Move lower.  Change type.
6245         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6246         Update.
6247         (coff_free_info): Remove.
6248
6249 2019-05-08  Tom Tromey  <tom@tromey.com>
6250
6251         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6252         (fbsd_pspace_data_handle): Move lower.  Change type.
6253         (get_fbsd_pspace_data): Update.
6254         (fbsd_pspace_data_cleanup): Remove.
6255         (_initialize_fbsd_tdep): Update.
6256
6257 2019-05-08  Tom Tromey  <tom@tromey.com>
6258
6259         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6260         (get_ada_tasks_pspace_data): Update.
6261         (ada_tasks_pspace_data_cleanup): Remove.
6262         (_initialize_tasks): Update.
6263         (ada_tasks_inferior_data_handle): Change type.
6264         (get_ada_tasks_inferior_data): Update.
6265         (ada_tasks_inferior_data_cleanup): Remove.
6266         (struct ada_tasks_pspace_data): Add initializers.
6267
6268 2019-05-08  Tom Tromey  <tom@tromey.com>
6269
6270         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6271         * symfile-debug.c (debug_sym_get_probes): Change type.
6272         * stap-probe.c (handle_stap_probe):
6273         (stap_static_probe_ops::get_probes): Change type.
6274         * probe.h (class static_probe_ops) <get_probes>: Change type.
6275         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6276         (parse_probes_in_pspace): Update.
6277         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6278         Update.
6279         (any_static_probe_ops::get_probes): Change type.
6280         * elfread.c (elfread_data): New typedef.
6281         (probe_key): Change type.
6282         (elf_get_probes): Likewise.  Update.
6283         (probe_key_free): Remove.
6284         (_initialize_elfread): Update.
6285         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6286         Change type.
6287         (dtrace_process_dof_probe, dtrace_process_dof)
6288         (dtrace_static_probe_ops::get_probe): Change type.
6289
6290 2019-05-08  Tom Tromey  <tom@tromey.com>
6291
6292         * xcoffread.c (struct xcoff_symfile_info): Rename from
6293         coff_symfile_info.  Add initializers.
6294         (xcoff_objfile_data_key): Move lower.  Change type.
6295         (XCOFF_DATA): Rewrite.
6296         (xcoff_free_info): Remove.
6297         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6298         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6299         (xcoff_initial_scan): Update.
6300
6301 2019-05-08  Tom Tromey  <tom@tromey.com>
6302
6303         * solib-svr4.c (struct svr4_info): Add initializers and
6304         destructor.
6305         <probes_table>: Now an htab_up.
6306         (solib_svr4_pspace_data): Change type.
6307         (free_probes_table): Simplify.
6308         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6309         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6310         (probes_table_remove_objfile_probes, register_solib_event_probe)
6311         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6312         (_initialize_svr4_solib): Update.
6313
6314 2019-05-08  Tom Tromey  <tom@tromey.com>
6315
6316         * remote.c (remote_pspace_data): Change type.
6317         (remote_pspace_data_cleanup): Remove.
6318         (get_remote_exec_file, set_pspace_remote_exec_file)
6319         (_initialize_remote): Update.
6320
6321 2019-05-08  Tom Tromey  <tom@tromey.com>
6322
6323         * breakpoint.c (breakpoint_objfile_key): Change type.
6324         (get_breakpoint_objfile_data): Update.
6325         (free_breakpoint_objfile_data): Remove.
6326         (_initialize_breakpoint): Update.
6327
6328 2019-05-08  Tom Tromey  <tom@tromey.com>
6329
6330         * linux-tdep.c (struct linux_info): Add initializers.
6331         (linux_inferior_data): Move.  Change type.
6332         (invalidate_linux_cache_inf): Update.
6333         (linux_inferior_data_cleanup): Remove.
6334         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6335
6336 2019-05-08  Tom Tromey  <tom@tromey.com>
6337
6338         * auxv.c (auxv_inferior_data): Move.  Change type.
6339         (auxv_inferior_data_cleanup): Remove.
6340         (invalidate_auxv_cache_inf): Rewrite.
6341         (get_auxv_inferior_data, _initialize_auxv): Update.
6342
6343 2019-05-08  Tom Tromey  <tom@tromey.com>
6344
6345         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6346         (symfile_debug_objfile_data_key): Change type.
6347         (symfile_debug_installed, debug_qf_has_symbols)
6348         (debug_qf_find_last_source_symtab)
6349         (debug_qf_forget_cached_source_info)
6350         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6351         (debug_qf_print_stats, debug_qf_dump)
6352         (debug_qf_expand_symtabs_for_function)
6353         (debug_qf_expand_all_symtabs)
6354         (debug_qf_expand_symtabs_with_fullname)
6355         (debug_qf_map_matching_symbols)
6356         (debug_qf_expand_symtabs_matching)
6357         (debug_qf_find_pc_sect_compunit_symtab)
6358         (debug_qf_map_symbol_filenames)
6359         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6360         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6361         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6362         (debug_sym_read_linetable, debug_sym_relocate): Update.
6363         (symfile_debug_free_objfile): Remove.
6364         (install_symfile_debug_logging, _initialize_symfile_debug):
6365         Update.
6366
6367 2019-05-08  Tom Tromey  <tom@tromey.com>
6368
6369         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6370         allocate_on_obstack.
6371         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6372         (get_dwarf2_per_objfile): Update.
6373         (set_dwarf2_per_objfile): Remove.
6374         (dwarf2_has_info, dwarf2_get_section_info): Update.
6375         (dwarf2_free_objfile): Remove.
6376         (_initialize_dwarf2_read): Update.
6377
6378 2019-05-08  Tom Tromey  <tom@tromey.com>
6379
6380         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6381         initializers.
6382         <unsupported_script_warning_printed,
6383         script_not_found_warning_printed>: Now bool.
6384         (auto_load_pspace_data): Change type.
6385         (~auto_load_pspace_info): Rename from
6386         auto_load_pspace_data_cleanup.
6387         (get_auto_load_pspace_data, init_loaded_scripts_info)
6388         (clear_section_scripts, maybe_print_unsupported_script_warning)
6389         (maybe_print_script_not_found_warning, _initialize_auto_load):
6390         Update.
6391
6392 2019-05-08  Tom Tromey  <tom@tromey.com>
6393
6394         * objfiles.c (objfile_pspace_info): Add destructor and
6395         initializers.
6396         (objfiles_pspace_data): Change type.
6397         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6398         (get_objfile_pspace_data): Update.
6399         (objfiles_bfd_data): Change type.
6400         (get_objfile_bfd_data): Update.
6401         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6402
6403 2019-05-08  Tom Tromey  <tom@tromey.com>
6404
6405         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6406         Change type.
6407         (get_catch_syscall_inferior_data): Update.
6408         (catch_syscall_inferior_data_cleanup): Remove.
6409         (_initialize_break_catch_syscall): Update.
6410
6411 2019-05-08  Tom Tromey  <tom@tromey.com>
6412
6413         * inflow.c (struct terminal_info): Add destructor and
6414         initializers.
6415         (inflow_inferior_data): Change type.
6416         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6417         (get_inflow_inferior_data, inflow_inferior_exit)
6418         (swap_terminal_info, _initialize_inflow): Update.
6419
6420 2019-05-08  Tom Tromey  <tom@tromey.com>
6421
6422         * target-dcache.c (target_dcache_cleanup): Remove.
6423         (target_dcache_aspace_key): Change type.
6424         (target_dcache_init_p, target_dcache_invalidate)
6425         (target_dcache_get, target_dcache_get_or_init)
6426         (_initialize_target_dcache): Update.
6427         * dcache.h (struct dcache_deleter): New.
6428
6429 2019-05-08  Tom Tromey  <tom@tromey.com>
6430
6431         * symtab.c (struct symbol_cache): Add destructor and
6432         initializers.
6433         (symbol_cache_key): Move.  Change type.
6434         (make_symbol_cache, free_symbol_cache): Remove.
6435         (get_symbol_cache): Update.
6436         (symbol_cache_cleanup): Remove.
6437         (ALL_PSPACES, symbol_cache_flush)
6438         (maintenance_print_symbol_cache)
6439         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6440         Update.
6441
6442 2019-05-08  Tom Tromey  <tom@tromey.com>
6443
6444         * symtab.c (struct main_info): Add destructor and initializers.
6445         (main_progspace_key): Move.  Change type.
6446         (get_main_info): Update.
6447         (main_info_cleanup): Remove.
6448         (_initialize_symtab): Update.
6449
6450 2019-05-08  Tom Tromey  <tom@tromey.com>
6451
6452         * registry.h (DECLARE_REGISTRY): Define the _key class.
6453
6454 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * NEWS: Merge two 'New commands' sections.
6457
6458 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6459
6460         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6461         parameter and use Ada language definition instead.
6462         (ada_val_print_ptr): Remove unused language parameter.
6463         (ada_val_print_num): Remove language parameter and use Ada language
6464         definition instead.
6465         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6466         parameter.
6467         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6468         parameter and use Ada language definition instead.
6469         (ada_val_print_1): Update all ada_val_print_xxx calls.
6470         Remove language parameter.
6471         (ada_val_print): Update ada_val_print_1 call.
6472
6473 2019-05-08  Tom Tromey  <tromey@adacore.com>
6474
6475         * remote.c (remote_hw_watchpoint_limit)
6476         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6477         Now static.
6478
6479 2019-05-08  Tom Tromey  <tromey@adacore.com>
6480
6481         * maint.c (_initialize_maint_cmds): Move initialization code to
6482         remote.c.
6483         (watchdog, show_watchdog): Move to remote.c.
6484         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6485         "watchdog" static.
6486         (_initialize_remote): Move initialization code from maint.c.
6487         * defs.h (watchdog): Don't declare.
6488
6489 2019-05-08  Tom Tromey  <tromey@adacore.com>
6490
6491         * tui/tui-interp.c: Include main.h.
6492         * interps.c: Include main.h.
6493         * main.h (interpreter_p): Declare.
6494         * defs.h (interpreter_p): Don't declare.
6495
6496 2019-05-08  Tom Tromey  <tromey@adacore.com>
6497
6498         * dwarf2loc.c: Include dwarf2read.h.
6499         * defs.h (read_unsigned_leb128): Don't declare.
6500         * dwarf2read.h (read_unsigned_leb128): Declare.
6501
6502 2019-05-08  Tom Tromey  <tromey@adacore.com>
6503
6504         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6505         method.
6506
6507 2019-05-08  Tom Tromey  <tromey@adacore.com>
6508
6509         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6510         when no wrap column is set.
6511
6512 2019-05-08  Tom Tromey  <tromey@adacore.com>
6513
6514         * c-lang.c (c_get_string): Handle non-C-style arrays.
6515
6516 2019-05-08  Tom Tromey  <tromey@adacore.com>
6517
6518         * typeprint.c (print_offset_data::update): Print the bit offset,
6519         not the number of bits remaining.
6520
6521 2019-05-08  Tom Tromey  <tromey@adacore.com>
6522
6523         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6524         padding at end of comment.
6525
6526 2019-05-08  Tom Tromey  <tromey@adacore.com>
6527
6528         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6529         Compare main types.
6530
6531 2019-05-06  Tom Tromey  <tom@tromey.com>
6532
6533         * common/scoped_mmap.c: Include common-defs.h.
6534         * common/scoped_mmap.h: Don't include config.h.
6535
6536 2019-05-04  Tom Tromey  <tom@tromey.com>
6537
6538         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6539         (struct aarch64_call_info): Add initializers.
6540         <si>: Now a std::vector.
6541         (pass_on_stack, aarch64_push_dummy_call): Update.
6542
6543 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6544             Tom Tromey  <tom@tromey.com>
6545
6546         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6547         (ppc_threads): Now a std::vector.  Now static.
6548         (hwdebug_find_thread_points_by_tid)
6549         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6550         Update.
6551
6552 2019-05-04  Tom Tromey  <tom@tromey.com>
6553
6554         * arc-tdep.c (arc_tdesc_init): Return bool.
6555
6556 2019-05-04  Tom Tromey  <tom@tromey.com>
6557
6558         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6559         Use gdb_assert_not_reached.
6560
6561 2019-05-04  Tom Tromey  <tom@tromey.com>
6562
6563         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6564         "false".
6565
6566 2019-05-04  Tom Tromey  <tom@tromey.com>
6567
6568         * arc-tdep.c (arc_tdesc_init): Use bool.
6569
6570 2019-05-04  Tom Tromey  <tom@tromey.com>
6571
6572         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6573
6574 2019-05-04  Tom Tromey  <tom@tromey.com>
6575
6576         * cli/cli-cmds.c (valid_command_p): Return bool.
6577
6578 2019-05-04  Tom Tromey  <tom@tromey.com>
6579
6580         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6581         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6582
6583 2019-05-04  Raul Tambre  <raul@tambre.ee>
6584
6585         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6586         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6587         operator for comparison.
6588
6589 2019-05-04  Tom Tromey  <tom@tromey.com>
6590
6591         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6592         (lookup_partial_symbol, print_partial_symbols)
6593         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6594         (psymbol_compare): Update.
6595         (add_psymbol_to_bcache): Clear the entire psymbol.
6596         (maintenance_check_psymtabs): Update.
6597         * psympriv.h (struct partial_symbol): Don't derive from
6598         general_symbol_info.
6599         <obj_section, unrelocated_address, address,
6600         set_unrelocated_address>: Update.
6601         <ginfo>: New member.
6602         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6603         (debug_names::write_psymbols): Update.
6604
6605 2019-05-04  Tom de Vries  <tdevries@suse.de>
6606
6607         * contrib/cc-with-tweaks.sh: Support -n arg.
6608
6609 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6610
6611         * corelow.c (core_target::detach): Ensure frame cache and
6612         register caches are cleared.
6613         inferior.c (exit_inferior_1): Likewise.
6614
6615 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6616             Tom Tromey  <tom@tromey.com>
6617
6618         * dictionary.c (collate_pending_symbols_by_language): Remove
6619         "struct" from foreach.
6620         * symtab.c (lookup_global_symbol_from_objfile)
6621         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6622         foreach.
6623         * ser-tcp.c (net_open): Remove "struct" from foreach.
6624         * objfiles.c (objfile_relocate, objfile_rebase)
6625         (objfile_has_symbols): Remove "struct" from foreach.
6626         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6627         from foreach.
6628         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6629         foreach.
6630         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6631         "struct" from foreach.
6632         * ada-lang.c (create_excep_cond_exprs)
6633         (ada_exception_catchpoint_cond_string): Remove "struct" from
6634         foreach.
6635
6636 2019-05-03  Tom Tromey  <tromey@adacore.com>
6637
6638         * ada-exp.y (convert_char_literal): Check suffix of each
6639         enumerator.
6640
6641 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6642
6643         PR ada/21406:
6644         * ada-exp.y (yywrap): Don't define.
6645         * ada-lex.l (%option): Add noyywrap
6646         (yywrap): Remove.
6647
6648 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6649
6650         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6651         _WIN32_WINNT to the XP level, unless already defined to a higher
6652         level.
6653
6654         * unittests/parse-connection-spec-selftests.c:
6655         * ser-tcp.c:
6656         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6657         override.
6658
6659         * symfile.c (find_separate_debug_file): Remove colon from the
6660         drive spec of DOS/Windows file names of the target, so that the
6661         file name produced from DEBUGDIR and the target's directory will
6662         be valid on DOS/Windows systems.
6663
6664 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * rust-lang.c (val_print_struct): Handle printing structures
6667         containing strings.
6668
6669 2019-05-02  Tom Tromey  <tromey@adacore.com>
6670
6671         * valarith.c (_initialize_valarith): Remove.
6672
6673 2019-05-01  Tom Tromey  <tromey@adacore.com>
6674
6675         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6676         bitfields.
6677
6678 2019-05-01  Tom Tromey  <tromey@adacore.com>
6679
6680         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6681         for big-endian copies.
6682
6683 2019-04-30  Ali Tamur  <tamur@google.com>
6684         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6685         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6686         (read_3_bytes): New function.
6687
6688 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6689
6690         * windows-nat.c (main_thread_id): Delete.
6691         (handle_output_debug_string): Replace main_thread_id by
6692         current_event.dwThreadId.
6693         (fake_create_process): Likewise.
6694         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6695         Do not set main_thread_id.
6696         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6697         current_event.dwThreadId.
6698         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6699
6700 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6701
6702         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6703         Use current_event.dwThreadId instead of main_thread_id.
6704
6705 2019-04-30  Tom Tromey  <tromey@adacore.com>
6706
6707         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6708         (create_excep_cond_exprs): Iterate over program spaces.
6709         (ada_exception_catchpoint_cond_string): Examine all minimal
6710         symbols for exception types.
6711
6712 2019-04-30  Tom Tromey  <tromey@adacore.com>
6713
6714         PR c++/24470:
6715         * dwarf2read.c (process_structure_scope): Handle case where type
6716         has template parameters but no symbol was created.
6717
6718 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6719             Chris January  <chris.january@arm.com>
6720
6721         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6722         qualifier.
6723         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6724
6725 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * f-typeprint.c (f_print_type): Update rules for printing
6728         whitespace.
6729         (f_type_print_varspec_suffix): Likewise.
6730
6731 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6732             Chris January  <chris.january@arm.com>
6733
6734         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6735         function arguments.
6736
6737 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6738
6739         * f-lang.c (build_fortran_types): Change name of void type to
6740         lower case.
6741         * f-typeprint.c (f_type_print_base): Print the name of the void
6742         type, rather than a fixed string.
6743         * f-valprint.c (f_decorations): Use lower case void string.
6744
6745 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6746             Chris January  <chris.january@arm.com>
6747
6748         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6749         types for Fortran.
6750
6751 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6752             Chris January  <chris.january@arm.com>
6753             David Lecomber  <david.lecomber@arm.com>
6754
6755         * f-exp.y (BINOP_INTRINSIC): New token.
6756         (exp): New parser rule handling BINOP_INTRINSIC.
6757         (f77_keywords): Add new builtin procedures.
6758         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6759         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6760         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6761         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6762         (print_unop_subexp_f): New function.
6763         (print_binop_subexp_f): New function.
6764         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6765         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6766         (dump_subexp_body_f): Likewise.
6767         (operator_check_f): Likewise.
6768         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6769         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6770
6771 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6772
6773         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6774         UNOP_KIND.
6775         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6776         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6777         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6778         (operator_length_f): New fuction.
6779         (print_subexp_f): New function.
6780         (op_name_f): New function.
6781         (dump_subexp_body_f): New function.
6782         (operator_check_f): New function.
6783         (exp_descriptor_f): Replace standard expression handling functions
6784         with new functions.
6785         * gdb/fortran-operator.def: New file.
6786         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6787         * gdb/std-operator.def: Remove UNOP_KIND.
6788
6789 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6790
6791         * std-operator.def: Remove unbalanced, stray double quote
6792         character.
6793
6794 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6795             Chris January  <chris.january@arm.com>
6796             Daniel Everett  <daniel.everett@arm.com>
6797             Nick Forrington  <nick.forrington@arm.com>
6798             Richard Bunt  <richard.bunt@arm.com>
6799
6800         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6801         of depth when printing anonymous structs or unions.
6802         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6803         Don't print either the top-level value, or the children if the
6804         max-depth is exceeded.
6805         (ppscm_print_children): When printing the key of a map, allow one
6806         extra level of depth.
6807         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6808         print either the top-level value, or the children if the max-depth
6809         is exceeded.
6810         (print_children): When printing the key of a map, allow one extra
6811         level of depth.
6812         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6813         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6814         (user_print_options): Initialise max_depth field.
6815         (val_print_scalar_or_string_type_p): New function.
6816         (val_print): Check to see if the max depth has been reached.
6817         (val_print_check_max_depth): Define new function.
6818         (show_print_max_depth): New function.
6819         (_initialize_valprint): Add 'print max-depth' option.
6820         * valprint.h (struct value_print_options) <max_depth>: New field.
6821         (val_print_check_max_depth): Declare new function.
6822         * NEWS: Document new feature.
6823
6824 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6825
6826         * ada-lang.c (ada_language_defn): Initialise new field.
6827         * c-lang.c (c_is_string_type_p): New function.
6828         (c_language_defn): Initialise new field.
6829         (cplus_language_defn): Initialise new field.
6830         (asm_language_defn): Initialise new field.
6831         (minimal_language_defn): Initialise new field.
6832         * c-lang.h (c_is_string_type_p): Declare new function.
6833         * d-lang.c (d_language_defn): Initialise new field.
6834         * f-lang.c (f_is_string_type_p): New function.
6835         (f_language_defn): Initialise new field.
6836         * go-lang.c (go_is_string_type_p): New function.
6837         (go_language_defn): Initialise new field.
6838         * language.c (default_is_string_type_p): New function.
6839         (unknown_language_defn): Initialise new field.
6840         (auto_language_defn): Initialise new field.
6841         * language.h (struct language_defn) <la_is_string_type_p>: New
6842         member variable.
6843         (default_is_string_type_p): Declare new function.
6844         * m2-lang.c (m2_language_defn): Initialise new field.
6845         * objc-lang.c (objc_language_defn): Initialise new field.
6846         * opencl-lang.c (opencl_language_defn): Initialise new field.
6847         * p-lang.c (pascal_is_string_type_p): New function.
6848         (pascal_language_defn): Initialise new field.
6849         * rust-lang.c (rust_is_string_type_p): New function.
6850         (rust_language_defn): Initialise new field.
6851
6852 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6853
6854         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6855         New field.
6856         * ada-lang.c (ada_language_defn): Initialise new field.
6857         * c-lang.c (c_language_defn): Likewise.
6858         (cplus_language_defn): Likewise.
6859         (asm_language_defn): Likewise.
6860         (minimal_language_defn): Likewise.
6861         * d-lang.c (d_language_defn): Likewise.
6862         * f-lang.c (f_language_defn): Likewise.
6863         * go-lang.c (go_language_defn): Likewise.
6864         * language.c (unknown_language_defn): Likewise.
6865         (auto_language_defn): Likewise.
6866         * m2-lang.c (m2_language_defn): Likewise.
6867         * objc-lang.c (objc_language_defn): Likewise.
6868         * opencl-lang.c (opencl_language_defn): Likewise.
6869         * p-lang.c (pascal_language_defn): Likewise.
6870         * rust-lang.c (rust_language_defn): Likewise.
6871
6872 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6873
6874         * ada-lang.c (ada_is_character_type): Change return type to bool.
6875         (ada_is_string_type): Likewise.
6876         * ada-lang.h (ada_is_character_type): Update declaration
6877         (ada_is_string_type): Likewise.
6878
6879 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6880
6881         Support style in 'frame|thread apply'
6882
6883         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6884         * record.c (record_start, record_stop): Update callers of
6885         execute_command_to_string with false.
6886         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6887         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6888         methods.
6889         (class string_file): New constructor with term_out parameter.
6890         Override methods term_out and can_emit_style_escape.  New member
6891         term_out.
6892         (class stdio_file): Override can_emit_style_escape.
6893         (class tee_file): Override term_out and can_emit_style_escape.
6894         * utils.h (can_emit_style_escape): Remove.
6895         * utils.c (can_emit_style_escape): Likewise.
6896         Update all callers of can_emit_style_escape (SOMESTREAM) to
6897         SOMESTREAM->can_emit_style_escape.
6898         * source-cache.c (source_cache::get_source_lines): Likewise.
6899         * stack.c (frame_apply_command_count): Call execute_command_to_string
6900         passing the term_out characteristic of the current gdb_stdout.
6901         * thread.c (thr_try_catch_cmd): Likewise.
6902         * top.c (execute_command_to_string): pass term_out parameter
6903         to construct the string_file for the command output.
6904         * ui-file.c (term_cli_styling): New function (most code moved
6905         from utils.c can_emit_style_escape).
6906         (string_file::string_file, string_file::can_emit_style_escape,
6907         stdio_file::can_emit_style_escape, tee_file::term_out,
6908         tee_file::can_emit_style_escape): New functions.
6909
6910 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6911
6912         * NEWS: Mention the new set|show may-call-functions.
6913         * infcall.c (may_call_functions_p): New variable.
6914         (show_may_call_functions_p): New function.
6915         (call_function_by_hand_dummy): Throws an error if not
6916         may-call-functions.
6917         (_initialize_infcall): Call add_setshow_boolean_cmd for
6918         may-call-functions.
6919
6920 2019-04-25  Keith Seitz  <keiths@redhat.com>
6921
6922         PR c++/24367
6923         * cp-support.c (inspect_type): Don't attempt substitutions
6924         of symbol with the same name.
6925
6926 2019-04-25  Tom Tromey  <tromey@adacore.com>
6927
6928         PR gdb/24475:
6929         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6930         static.
6931
6932 2019-04-25  Tom Tromey  <tromey@adacore.com>
6933
6934         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6935         rvalue reference.
6936         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6937         (gdb_xml_parser::parse): Use std::move.
6938         * python/python-internal.h (gdbpy_convert_exception): Take a const
6939         reference.
6940         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6941         std::move.
6942         * python/py-utils.c (gdbpy_convert_exception): Take a const
6943         reference.
6944         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6945         Use std::move.
6946         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6947         Use std::move.
6948         * mi/mi-main.c (mi_print_exception): Take a const reference.
6949         * main.c (handle_command_errors): Take a const reference.
6950         * linespec.c (parse_linespec): Use std::move.
6951         * infcall.c (run_inferior_call): Use std::move.
6952         (call_function_by_hand_dummy): Use std::move.
6953         * exec.c (try_open_exec_file): Use std::move.
6954         * exceptions.h (exception_print, exception_fprintf)
6955         (exception_print_same): Update.
6956         * exceptions.c (print_exception, exception_print)
6957         (exception_fprintf, exception_print_same): Change parameters to
6958         const reference.
6959         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6960         * common/new-op.c: Use std::move.
6961         * common/common-exceptions.h (struct gdb_exception): Add move
6962         constructor.
6963         (struct gdb_exception_error, struct gdb_exception_quit, struct
6964         gdb_quit_bad_alloc): Change constructor to move constructor.
6965         (throw_exception): Change parameter to rvalue reference.
6966         * common/common-exceptions.c (throw_exception): Take rvalue
6967         reference.
6968         * cli/cli-interp.c (safe_execute_command): Use std::move.
6969         * breakpoint.c (insert_bp_location, location_to_sals): Use
6970         std::move.
6971
6972 2019-04-25  Tom Tromey  <tromey@adacore.com>
6973
6974         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6975         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6976         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6977         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6978         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6979         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6980         guile/scm-value.c: Use unpack.
6981         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6982         gdbscm_gdb_exception.
6983         (gdbscm_throw_gdb_exception): Likewise.
6984         (struct gdbscm_gdb_exception): New.
6985         (unpack): New function.
6986         (gdbscm_wrap): Use unpack.
6987
6988 2019-04-25  Tom Tromey  <tromey@adacore.com>
6989
6990         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6991         (gdb_rl_callback_handler): Use std::move.
6992         * common/common-exceptions.h (struct gdb_exception): Add move
6993         assignment operator.
6994         (throw_exception_sjlj): Change "exception" to const reference.
6995         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6996         (throw_exception_sjlj): Change "exception" to const reference.
6997
6998 2019-04-25  Tom Tromey  <tromey@adacore.com>
6999
7000         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7001         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7002         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7003         Update.
7004         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7005         Update.
7006         * mi/mi-interp.c (mi_interp::exec): Update.
7007         * linespec.c (parse_linespec): Update.
7008         * infcall.c (run_inferior_call): Update.
7009         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7010         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7011         (gdbscm_lookup_global_symbol): Update.
7012         * guile/scm-param.c (gdbscm_parameter_value): Update.
7013         * guile/scm-frame.c (gdbscm_frame_read_register)
7014         (gdbscm_frame_read_var): Update.
7015         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7016         * exec.c (try_open_exec_file): Update.
7017         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7018         (gdb_rl_callback_handler): Update.
7019         * common/common-exceptions.h (exception_none): Don't declare.
7020         * common/common-exceptions.c (exception_none): Don't define.
7021         (struct catcher) <exception>: Update.
7022         * cli/cli-interp.c (safe_execute_command): Update.
7023         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7024
7025 2019-04-25  Ali Tamur  <tamur@google.com>
7026
7027         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7028         (read_attribute_value): Likewise.
7029         (dwarf2_read_addr_index): Update comment.
7030         (read_str_index): Add DW_FORM_strx.
7031         (dwarf2_string_attr): Likewise.
7032         (dwarf2_const_value_attr): Likewise.
7033         (dump_die_shallow): Likewise.
7034         (dwarf2_fetch_constant_bytes): Likewise.
7035         (skip_form_bytes): Likewise.
7036         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7037
7038 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7039
7040         PR corefiles/11608
7041         PR corefiles/18187
7042         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7043         OFFSET.  Verify if current mapping contains an ELF header.
7044         (linux_find_memory_regions_full): Adjust call to
7045         dump_mapping_p.
7046
7047 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7048             Kang Li <kanglictf@gmail.com>
7049
7050         PR gdb/21600
7051
7052         * dwarf2-frame.c (read_initial_length): Be consistent about using
7053         unsigned representation of length.
7054         (decode_frame_entry_1): Likewise.  Check for wraparound of
7055         end pointer as well as buffer overflow.
7056
7057 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7058
7059         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7060         "vq".
7061
7062 2019-04-24  Tom Tromey  <tromey@adacore.com>
7063
7064         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7065
7066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * s12z-tdep.c (s12z_unwind_pc): Delete.
7069         (s12z_unwind_sp): Delete.
7070         (s12z_gdbarch_init): Don't register deleted functions with
7071         gdbarch.
7072
7073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7074
7075         * rl78-tdep.c (rl78_unwind_sp): Delete.
7076         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7077
7078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7079
7080         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7081         (xstormy16_unwind_pc): Delete.
7082         (xstormy16_dummy_id): Delete.
7083         (xstormy16_gdbarch_init): Don't register deleted functions with
7084         gdbarch.
7085
7086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7087
7088         * vax-tdep.c (vax_unwind_pc): Delete.
7089         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7090
7091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * v850-tdep.c (v850_unwind_sp): Delete.
7094         (v850_unwind_pc): Delete.
7095         (v850_dummy_id): Delete.
7096         (v850_gdbarch_init): Don't register deleted functions with
7097         gdbarch.
7098
7099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7100
7101         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7102         (tilegx_unwind_pc): Delete.
7103         (tilegx_unwind_dummy_id): Delete.
7104         (tilegx_gdbarch_init): Don't register deleted functions with
7105         gdbarch.
7106
7107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7108
7109         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7110         (tic6x_dummy_id): Delete.
7111         (tic6x_gdbarch_init): Don't register deleted functions with
7112         gdbarch.
7113
7114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7115
7116         * sparc-tdep.c (sparc_unwind_pc): Delete.
7117         (sparc32_gdbarch_init): Don't register deleted function with
7118         gdbarch.
7119
7120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7121
7122         * sh-tdep.c (sh_unwind_sp): Delete.
7123         (sh_unwind_pc): Delete.
7124         (sh_dummy_id): Delete.
7125         (sh_gdbarch_init): Don't register deleted functions with
7126         gdbarch.
7127
7128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7129
7130         * score-tdep.c (score_unwind_sp): Delete.
7131         (score_unwind_pc): Delete.
7132         (score_dummy_id): Delete.
7133         (score_gdbarch_init): Don't register deleted functions with
7134         gdbarch.
7135
7136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7137
7138         * rx-tdep.c (rx_unwind_pc): Delete.
7139         (rx_unwind_sp): Delete.
7140         (rx_dummy_id): Delete.
7141         (rx_gdbarch_init): Don't register deleted functions with
7142         gdbarch.  Update comment.
7143
7144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7145
7146         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7147         (rs6000_dummy_id): Delete.
7148         (rs6000_gdbarch_init): Don't register deleted functions with
7149         gdbarch.
7150
7151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * or1k-tdep.c (or1k_dummy_id): Delete.
7154         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7155
7156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7157
7158         * nios2-tdep.c (nios2_dummy_id): Delete.
7159         (nios2_unwind_sp): Delete.
7160         (nios2_gdbarch_init): Don't register deleted functions with
7161         gdbarch.
7162
7163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7164
7165         * nds32-tdep.c (nds32_dummy_id): Delete.
7166         (nds32_unwind_pc): Delete.
7167         (nds32_unwind_sp): Delete.
7168         (nds32_gdbarch_init): Don't register deleted functions with
7169         gdbarch.
7170
7171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7172
7173         * msp430-tdep.c (msp430_unwind_pc): Delete.
7174         (msp430_unwind_sp): Delete.
7175         (msp430_dummy_id): Delete.
7176         (msp430_gdbarch_init): Don't register deleted functions with
7177         gdbarch.
7178
7179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7180
7181         * moxie-tdep.c (moxie_unwind_sp): Delete.
7182         (moxie_unwind_pc): Delete.
7183         (moxie_dummy_id): Delete.
7184         (moxie_gdbarch_init): Don't register deleted functions with
7185         gdbarch.
7186
7187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7188
7189         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7190         (mn10300_unwind_pc): Delete.
7191         (mn10300_unwind_sp): Delete.
7192         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7193         mn10300_unwind_sp.
7194         (mn10300_frame_unwind_init): Don't register deleted functions with
7195         gdbarch.
7196
7197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7198
7199         * mep-tdep.c (mep_unwind_pc): Delete.
7200         (mep_unwind_sp): Delete.
7201         (mep_dummy_id): Delete.
7202         (mep_gdbarch_init): Don't register deleted functions with
7203         gdbarch.
7204
7205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7206
7207         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7208         (m68hc11_unwind_sp): Delete.
7209         (m68hc11_gdbarch_init): Don't register deleted functions with
7210         gdbarch.
7211
7212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7213
7214         * m32r-tdep.c (m32r_unwind_sp): Delete.
7215         (m32r_unwind_pc): Delete.
7216         (m32r_dummy_id): Delete.
7217         (m32r_gdbarch_init): Don't register deleted functions with
7218         gdbarch.
7219
7220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * m32c-tdep.c (m32c_unwind_pc): Delete.
7223         (m32c_unwind_sp): Delete.
7224         (m32c_dummy_id): Delete.
7225         (m32c_gdbarch_init): Don't register deleted functions with
7226         gdbarch.
7227
7228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7231         (lm32_unwind_pc): Delete.
7232         (lm32_dummy_id): Delete.
7233         (lm32_gdbarch_init): Don't register deleted functions with
7234         gdbarch.
7235
7236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7237
7238         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7239         (iq2000_unwind_pc): Delete.
7240         (iq2000_dummy_id): Delete.
7241         (iq2000_gdbarch_init): Don't register deleted functions with
7242         gdbarch.
7243
7244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7245
7246         * nds32-tdep.c (nds32_type_align): Delete.
7247         (nds32_push_dummy_call): Use type_align instead.
7248
7249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7250
7251         * arm-tdep.c (arm_type_align): Only handle vector override case.
7252         (arm_push_dummy_call): Use type_align.
7253         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7254
7255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7256
7257         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7258         case.
7259         (pass_on_stack): Use type_align.
7260         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7261         function.
7262
7263 2019-04-23  Tom Tromey  <tromey@adacore.com>
7264
7265         * dwarf2read.c (line_header::file_name_at): Remove unused
7266         overload.
7267
7268 2019-04-23  Tom de Vries  <tdevries@suse.de>
7269
7270         PR gdb/24438
7271         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7272         invocation.
7273
7274
7275 2019-03-27  Ali Tamur  <tamur@google.com>
7276
7277         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7278         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7279         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7280         (dwarf_expr_context::get_addr_index): Likewise
7281         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7282         (symbol_needs_eval_context::get_addr_index): Likewise
7283         (disassemble_dwarf_expression): Add DW_OP_addrx
7284         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7285         (read_cutu_die_from_dwo): Update comment
7286         (skip_one_die): Add DW_FORM_addrx
7287         (read_attribute_value): Likewise
7288         (var_decode_location): Add DW_OP_addrx
7289         (dwarf2_const_value_attr): Add DW_FORM_addrx
7290         (dump_die_shallow): Likewise
7291         (dwarf2_fetch_constant_bytes): Likewise
7292         (decode_locdesc): Add DW_OP_addrx
7293         (skip_form_bytes): Add DW_FORM_addrx
7294
7295 2019-04-22  Ali Tamur  <tamur@google.com>
7296
7297         * MAINTAINERS (Write After Approval): Add self.
7298
7299 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7300
7301         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7302         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7303         (open_symbol_file_object): Likewise.
7304         (svr4_default_sos): Add info parameter.
7305         (svr4_read_so_list): Likewise.
7306         (svr4_current_sos_direct): Adjust functions calls to pass down
7307         info.
7308         (svr4_current_sos_1): Add info parameter.
7309         (svr4_current_sos): Call get_svr4_info, pass info down to
7310         svr4_current_sos_1.
7311         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7312         get_svr4_info.
7313         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7314         get_svr4_info.
7315         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7316         to get_svr4_info.
7317         (probes_table_remove_objfile_probes): Likewise.
7318         (register_solib_event_probe): Add info parameter.
7319         (solist_update_incremental): Pass info parameter down to
7320         svr4_read_so_list.
7321         (disable_probes_interface): Add info parameter.
7322         (svr4_handle_solib_event): Pass current_program_space to
7323         get_svr4_info.  Adjust disable_probes_interface cleanup.
7324         (svr4_create_probe_breakpoints): Add info parameter, pass it
7325         down to register_solib_event_probe.
7326         (svr4_create_solib_event_breakpoints): Add info parameter,
7327         pass it down to svr4_create_probe_breakpoints.
7328         (enable_break): Pass info down to
7329         svr4_create_solib_event_breakpoints.
7330         (svr4_solib_create_inferior_hook): Pass current_program_space to
7331         get_svr4_info.
7332         (svr4_clear_solib): Likewise.
7333
7334 2019-04-22  Pedro Alves  <palves@redhat.com>
7335
7336         * solib-svr4.c (svr4_free_objfile_observer): New.
7337         (probe_and_action::objfile): New field.
7338         (probes_table_htab_remove_objfile_probes)
7339         (probes_table_remove_objfile_probes): New functions.
7340         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7341         in the new probe_and_action.  Don't store the probe in 'lookup'.
7342         (svr4_create_probe_breakpoints): Pass objfile to
7343         register_solib_event_probe.
7344         (_initialize_svr4_solib): Register a free_objfile observer.
7345
7346 2019-04-19  Tom Tromey  <tom@tromey.com>
7347
7348         * common/queue.h: Remove.
7349
7350 2019-04-19  Tom Tromey  <tom@tromey.com>
7351
7352         * event-loop.c: Don't include "common/queue.h".
7353
7354 2019-04-19  Tom Tromey  <tom@tromey.com>
7355
7356         * remote.c (remote_target): Use delete.
7357         * remote-notif.h: Include <list>, not "common/queue.h".
7358         (notif_client_p): Remove typedef.
7359         (remote_notif_state): Add constructor, destructor, initializer.
7360         <notif_queue>: Now a std::list.
7361         (remote_notif_state_xfree): Don't declare.
7362         * remote-notif.c (remote_notif_process, handle_notification)
7363         (remote_notif_state_allocate): Update.
7364         (~remote_notif_state): Rename from remote_notif_state_xfree.
7365
7366 2019-04-19  Tom Tromey  <tom@tromey.com>
7367
7368         * symfile.c (reread_symbols): Update.
7369         * objfiles.c (objfile_register_static_link)
7370         (objfile_lookup_static_link): Update
7371         (~objfile) Don't delete static_links.
7372         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7373
7374 2019-04-19  Tom Tromey  <tom@tromey.com>
7375
7376         * type-stack.h (struct type_stack) <insert>: Constify string.
7377         * type-stack.c (type_stack::insert): Constify string.
7378         * gdbtypes.h (lookup_template_type): Update.
7379         (address_space_name_to_int): Update.
7380         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7381         const.
7382         (lookup_template_type): Make name const.
7383         * c-exp.y: Update rules.
7384         (lex_one_token, classify_name, classify_inner_name)
7385         (c_print_token): Update.
7386         * p-exp.y: Update rules.
7387         (yylex): Update.
7388         * f-exp.y: Update rules.
7389         (yylex): Update.
7390         * d-exp.y: Update rules.
7391         (lex_one_token, classify_name, classify_inner_name): Update.
7392         * parse.c (write_dollar_variable, copy_name): Return std::string.
7393         * parser-defs.h (copy_name): Change return type.
7394         * m2-exp.y: Update rules.
7395         (yylex): Update.
7396         * go-exp.y (lex_one_token): Update.
7397         Update rules.
7398         (classify_unsafe_function, classify_packaged_name)
7399         (classify_name, yylex): Update.
7400
7401 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7402
7403         * configure.ac: add --enable-source-highlight switch.
7404         * configure: Regenerate.
7405         * top.c (print_gdb_version): plumb --enable-source-highlight
7406         status to "show configuration".
7407
7408 2019-04-19  Tom Tromey  <tromey@adacore.com>
7409
7410         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7411         Check ADA_TYPE_P.
7412         (empty_record, ada_template_to_fixed_record_type_1)
7413         (template_to_static_fixed_type)
7414         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7415         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7416         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7417         macros.
7418
7419 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7420
7421         PR symtab/24423:
7422         * source.c (print_source_lines_base): Advance "iter" when a
7423         control character is seen.
7424
7425 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7426
7427         * inferior.h (struct infcall_suspend_state_deleter):
7428         Catch exception in destructor to avoid crash.
7429
7430 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7431
7432         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7433         close to the add_com "shell".
7434
7435 2019-04-18  Tom Tromey  <tromey@adacore.com>
7436
7437         * process-stratum-target.h (class process_stratum_target)
7438         <stratum>: Add "final".
7439
7440 2019-04-17  Tom Tromey  <tromey@adacore.com>
7441
7442         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7443         against nullptr before use.
7444
7445 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7446
7447         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7448
7449 2019-04-17  Jim Wilson  <jimw@sifive.com>
7450             Andrew Burgess  <andrew.burgess@embecosm.com>
7451
7452         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7453         code read might fail, assume 4-byte breakpoint in that case.
7454
7455 2019-04-15  Leszek Swirski  <leszeks@google.com>
7456
7457         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7458         rather than a hand-rolled POD check when checking for forced MEMORY
7459         classification.
7460
7461 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7462
7463         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7464         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7465         function.
7466         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7467         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7468         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7469         declaration.
7470
7471 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7472
7473         * aarch64-linux-nat.c
7474         (aarch64_linux_nat_target::thread_architecture): Add override.
7475         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7476         each VQ.
7477
7478 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7479
7480         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7481
7482 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7483
7484         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7485         target types of size 96-bits, add some additional comments, and
7486         check that the builtin type we found was the correct size.
7487
7488 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7489
7490         * utils.c (prompt_for_continue): Don't restore the styling at the
7491         end, as applied_style has the wrong value.  This fixes styling in
7492         long lists of file names that are interrupted by the "Continue?"
7493         prompt.
7494
7495 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7498         * c-lang.c (c_language_defn): Likewise.
7499         (cplus_language_defn): Likewise.
7500         (asm_language_defn): Likewise.
7501         (minimal_language_defn): Likewise.
7502         * d-lang.c (d_language_defn): Likewise.
7503         * f-lang.c (f_language_defn): Likewise.
7504         * go-lang.c (go_language_defn): Likewise.
7505         * language.c (unknown_language_defn): Likewise.
7506         (auto_language_defn): Likewise.
7507         * language.h (struct language_defn): Remove la_magic field.
7508         (LANG_MAGIC): Delete.
7509         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7510         * objc-lang.c (objc_language_defn): Likewise.
7511         * opencl-lang.c (opencl_language_defn): Likewise.
7512         * p-lang.c (pascal_language_defn): Likewise.
7513         * rust-lang.c (rust_language_defn): Likewise.
7514
7515 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7516
7517         * riscv-tdep.c (riscv_type_align): New function.
7518         (riscv_type_alignment): Delete.
7519         (riscv_arg_location): Use 'type_align'.
7520         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7521
7522 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * gdbtypes.c (type_align): A struct with no non-static fields also
7525         has alignment of 1.
7526
7527 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7528
7529         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7530         component to 0.
7531         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7532         member.
7533         (riscv_struct_info::analyse): New implementation using new
7534         analyse_inner member function.
7535         (riscv_struct_info::field_offset): New member function.
7536         (riscv_struct_info::m_offsets): New member variable.
7537         (riscv_struct_info::analyse_inner): New private member function,
7538         takes the old implementation of riscv_struct_info::analyse but
7539         extended to track field offsets.
7540         (riscv_call_arg_struct): Update the struct folding special cases
7541         to handle cases where empty C++ structs, which are non-zero
7542         length, are found.
7543         (riscv_arg_location): Initialise the length of each location, a
7544         non-zero length now indicates the location is in use.
7545         (riscv_push_dummy_call): Allow for the first location having a
7546         non-zero offset when setting up arguments.
7547         (riscv_return_value): Likewise, but for return values.
7548
7549 2019-04-11  Tom Tromey  <tromey@adacore.com>
7550
7551         * utils.c (internal_vproblem): Make "msg" const.
7552
7553 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7554
7555         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7556         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7557         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7558         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7559
7560 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7561
7562         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7563         function.
7564         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7565         of amd64_collect_native_gregset.
7566         (amd64_linux_nat_target::store_registers): Likewise.
7567
7568 2019-04-10  Tom Tromey  <tom@tromey.com>
7569
7570         * symtab.c (lookup_global_symbol_from_objfile)
7571         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7572         * objfiles.h (class separate_debug_iterator): New.
7573         (class separate_debug_range): New.
7574         (struct objfile) <separate_debug_objfiles>: New method.
7575         (objfile_separate_debug_iterate): Don't declare.
7576         * objfiles.c (separate_debug_iterator::operator++): Rename from
7577         objfile_separate_debug_iterate.
7578         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7579         iterator.
7580         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7581         iterator.
7582
7583 2019-04-10  Tom Tromey  <tom@tromey.com>
7584
7585         * symfile.c (reread_symbols): Remove old comment.
7586         * objfiles.c (free_all_objfiles): Fix a typo.
7587
7588 2019-04-10  Tom Tromey  <tom@tromey.com>
7589
7590         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7591         * minsyms.c (lookup_minimal_symbol): Use foreach.
7592         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7593         (lookup_minimal_symbol_solib_trampoline): Likewise.
7594         * symfile.c (reread_symbols): Use foreach.
7595
7596 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7597             Tom Tromey  <tromey@adacore.com>
7598
7599         PR rust/24414:
7600         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7601         (rust_lex_int_test): Change "value" to be LONGEST.
7602         (rust_lex_tests): Add test for long integer literal.
7603
7604 2019-04-09  Tom Tromey  <tromey@adacore.com>
7605
7606         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7607         to bool.
7608         (extended_remote_target::attach): Update.
7609         (remote_target::remote_notice_new_inferior): Update.
7610         (remote_target::add_current_inferior_and_thread): Update.
7611         * inferior.c (exit_inferior_1): Use "false".
7612         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7613
7614 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7615
7616         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7617         the "start" command.
7618
7619 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7620
7621         * python/py-inferior.c (infpy_thread_from_thread_handle):
7622         Adjust comments to reflect renaming of thread_from_thread_handle
7623         to thread_from_handle.  Adjust keywords.  Fix type error message.
7624         (inferior_object_methods): Add thread_from_handle.  Retain
7625         thread_from_thread_handle, but mark it as deprecated.
7626
7627 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7628
7629         * gdbthread.h (find_thread_by_handle): Revise declaration.
7630         * thread.c (find_thread_by_handle): Likewise.  Adjust
7631         implementation too.
7632         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7633         support for buffer objects as handles.
7634
7635 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7636
7637         * python/py-infthread.c (thpy_thread_handle): New function.
7638         (thread_object_methods): Register thpy_thread_handle.
7639
7640 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7641
7642         * gdbthread.h (thread_to_thread_handle): Declare.
7643         * thread.c (gdbtypes.h): Include.
7644         (thread_to_thread_handle): New function.
7645
7646         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7647         (target_thread_info_to_thread_handle): Declare.
7648         * target.c (target_thread_info_to_thread_handle): New function.
7649         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7650         * target-delegates.c: Regenerate.
7651
7652         * linux-thread-db.c (class thread_db_target): Add method
7653         thread_info_to_thread_handle.
7654         (thread_db_target::thread_info_to_thread_handle): Define.
7655         * remote.c (class remote_target): Add new method
7656         thread_info_to_thread_handle.
7657         (remote_target::thread_info_to_thread_handle): Define.
7658
7659 2019-04-08  Pedro Alves  <palves@redhat.com>
7660
7661         * common/common-exceptions.c (throw_exception): Don't create
7662         named object to throw; throw directly.
7663         (throw_it): Likewise.  Don't initialize gdb_exception::message
7664         here, with new; pass FMT and AP to the ctor instead.
7665         * common/common-exceptions.h: Include <string>.
7666         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7667         const char *, va_list)): New ctor.  Use std::make_shared.
7668         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7669         errors)): Delete.
7670         (gdb_exception_error::gdb_exception_error(enum errors, const char
7671         *, va_list)): New.
7672         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7673         Add assertion.
7674         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7675         errors)): Delete.
7676         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7677         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7678         Add assertion.
7679
7680 2019-04-08  Tom Tromey  <tom@tromey.com>
7681
7682         * valops.c (value_rtti_indirect_type): Replace throw_exception
7683         with throw.
7684         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7685         with throw.
7686         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7687         throw.
7688         * target.c (target_translate_tls_address): Replace throw_exception
7689         with throw.
7690         * stack.c (frame_apply_command_count): Replace throw_exception
7691         with throw.
7692         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7693         throw.
7694         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7695         with throw.
7696         * rs6000-tdep.c (rs6000_frame_cache)
7697         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7698         * remote.c: Replace throw_exception with throw.
7699         * record-full.c (record_full_message, record_full_wait_1)
7700         (record_full_restore): Replace throw_exception with throw.
7701         * record-btrace.c:
7702         (get_thread_current_frame_id, record_btrace_start_replaying)
7703         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7704         (cmd_record_btrace_start): Replace throw_exception with throw.
7705         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7706         throw.
7707         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7708         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7709         * linespec.c:
7710         (find_linespec_symbols): Replace throw_exception with throw.
7711         * infrun.c (displaced_step_prepare, resume): Replace
7712         throw_exception with throw.
7713         * infcmd.c (post_create_inferior): Replace throw_exception with
7714         throw.
7715         * inf-loop.c (inferior_event_handler): Replace throw_exception
7716         with throw.
7717         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7718         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7719         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7720         (get_prev_frame_always, get_frame_pc_if_available)
7721         (get_frame_address_in_block_if_available, get_frame_language):
7722         Replace throw_exception with throw.
7723         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7724         throw_exception with throw.
7725         * eval.c (fetch_subexp_value, evaluate_var_value)
7726         (evaluate_funcall, evaluate_subexp_standard): Replace
7727         throw_exception with throw.
7728         * dwarf2loc.c (call_site_find_chain)
7729         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7730         Replace throw_exception with throw.
7731         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7732         with throw.
7733         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7734         throw.
7735         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7736         * completer.c (complete_line_internal): Replace throw_exception
7737         with throw.
7738         * compile/compile-object-run.c (compile_object_run): Replace
7739         throw_exception with throw.
7740         * cli/cli-script.c (process_next_line): Replace throw_exception
7741         with throw.
7742         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7743         (btrace_enable, btrace_maint_update_pt_packets): Replace
7744         throw_exception with throw.
7745         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7746         throw_exception with throw.
7747         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7748         throw_exception with throw.
7749         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7750         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7751         * aarch64-tdep.c (aarch64_make_prologue_cache)
7752         (aarch64_make_stub_cache): Replace throw_exception with throw.
7753
7754 2019-04-08  Tom Tromey  <tom@tromey.com>
7755
7756         * common/common-exceptions.c (throw_exception): Rename from
7757         throw_exception_cxx.  Remove old copy.  Make argument const.
7758         (throw_it): Create and throw exception objects directly.
7759         * common/common-exceptions.h (throw_exception): Make argument
7760         const.
7761         (struct gdb_exception_error): Add constructor.
7762         (struct gdb_exception_quit): Add constructor.
7763
7764 2019-04-08  Tom Tromey  <tom@tromey.com>
7765
7766         * common/common-exceptions.h (exception_rethrow): Don't declare.
7767         (TRY_SJLJ): Update comment.
7768         (TRY, CATCH, END_CATCH): Remove.
7769         * common/common-exceptions.c (exception_rethrow): Remove.
7770
7771 2019-04-08  Tom Tromey  <tom@tromey.com>
7772
7773         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7774         Remove.
7775         (gdb_exception_error): Rename from
7776         gdb_exception_RETURN_MASK_ERROR.
7777         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7778         (gdb_quit_bad_alloc): Update.
7779         * aarch64-tdep.c: Update.
7780         * ada-lang.c: Update.
7781         * ada-typeprint.c: Update.
7782         * ada-valprint.c: Update.
7783         * amd64-tdep.c: Update.
7784         * arch-utils.c: Update.
7785         * break-catch-throw.c: Update.
7786         * breakpoint.c: Update.
7787         * btrace.c: Update.
7788         * c-varobj.c: Update.
7789         * cli/cli-cmds.c: Update.
7790         * cli/cli-interp.c: Update.
7791         * cli/cli-script.c: Update.
7792         * common/common-exceptions.c: Update.
7793         * common/new-op.c: Update.
7794         * common/selftest.c: Update.
7795         * compile/compile-c-symbols.c: Update.
7796         * compile/compile-cplus-symbols.c: Update.
7797         * compile/compile-object-load.c: Update.
7798         * compile/compile-object-run.c: Update.
7799         * completer.c: Update.
7800         * corelow.c: Update.
7801         * cp-abi.c: Update.
7802         * cp-support.c: Update.
7803         * cp-valprint.c: Update.
7804         * darwin-nat.c: Update.
7805         * disasm-selftests.c: Update.
7806         * dtrace-probe.c: Update.
7807         * dwarf-index-cache.c: Update.
7808         * dwarf-index-write.c: Update.
7809         * dwarf2-frame-tailcall.c: Update.
7810         * dwarf2-frame.c: Update.
7811         * dwarf2loc.c: Update.
7812         * dwarf2read.c: Update.
7813         * eval.c: Update.
7814         * event-loop.c: Update.
7815         * event-top.c: Update.
7816         * exec.c: Update.
7817         * f-valprint.c: Update.
7818         * fbsd-tdep.c: Update.
7819         * frame-unwind.c: Update.
7820         * frame.c: Update.
7821         * gdbtypes.c: Update.
7822         * gnu-v3-abi.c: Update.
7823         * guile/guile-internal.h: Update.
7824         * guile/scm-block.c: Update.
7825         * guile/scm-breakpoint.c: Update.
7826         * guile/scm-cmd.c: Update.
7827         * guile/scm-disasm.c: Update.
7828         * guile/scm-frame.c: Update.
7829         * guile/scm-lazy-string.c: Update.
7830         * guile/scm-math.c: Update.
7831         * guile/scm-param.c: Update.
7832         * guile/scm-ports.c: Update.
7833         * guile/scm-pretty-print.c: Update.
7834         * guile/scm-symbol.c: Update.
7835         * guile/scm-symtab.c: Update.
7836         * guile/scm-type.c: Update.
7837         * guile/scm-value.c: Update.
7838         * i386-linux-tdep.c: Update.
7839         * i386-tdep.c: Update.
7840         * inf-loop.c: Update.
7841         * infcall.c: Update.
7842         * infcmd.c: Update.
7843         * infrun.c: Update.
7844         * jit.c: Update.
7845         * language.c: Update.
7846         * linespec.c: Update.
7847         * linux-fork.c: Update.
7848         * linux-nat.c: Update.
7849         * linux-tdep.c: Update.
7850         * linux-thread-db.c: Update.
7851         * main.c: Update.
7852         * mi/mi-cmd-break.c: Update.
7853         * mi/mi-cmd-stack.c: Update.
7854         * mi/mi-interp.c: Update.
7855         * mi/mi-main.c: Update.
7856         * objc-lang.c: Update.
7857         * p-valprint.c: Update.
7858         * parse.c: Update.
7859         * ppc-linux-tdep.c: Update.
7860         * printcmd.c: Update.
7861         * python/py-arch.c: Update.
7862         * python/py-breakpoint.c: Update.
7863         * python/py-cmd.c: Update.
7864         * python/py-finishbreakpoint.c: Update.
7865         * python/py-frame.c: Update.
7866         * python/py-framefilter.c: Update.
7867         * python/py-gdb-readline.c: Update.
7868         * python/py-inferior.c: Update.
7869         * python/py-infthread.c: Update.
7870         * python/py-lazy-string.c: Update.
7871         * python/py-linetable.c: Update.
7872         * python/py-objfile.c: Update.
7873         * python/py-param.c: Update.
7874         * python/py-prettyprint.c: Update.
7875         * python/py-progspace.c: Update.
7876         * python/py-record-btrace.c: Update.
7877         * python/py-record.c: Update.
7878         * python/py-symbol.c: Update.
7879         * python/py-type.c: Update.
7880         * python/py-unwind.c: Update.
7881         * python/py-utils.c: Update.
7882         * python/py-value.c: Update.
7883         * python/python.c: Update.
7884         * record-btrace.c: Update.
7885         * record-full.c: Update.
7886         * remote-fileio.c: Update.
7887         * remote.c: Update.
7888         * riscv-tdep.c: Update.
7889         * rs6000-aix-tdep.c: Update.
7890         * rs6000-tdep.c: Update.
7891         * rust-exp.y: Update.
7892         * rust-lang.c: Update.
7893         * s390-tdep.c: Update.
7894         * selftest-arch.c: Update.
7895         * solib-dsbt.c: Update.
7896         * solib-frv.c: Update.
7897         * solib-spu.c: Update.
7898         * solib-svr4.c: Update.
7899         * solib.c: Update.
7900         * sparc64-linux-tdep.c: Update.
7901         * stack.c: Update.
7902         * symfile-mem.c: Update.
7903         * symmisc.c: Update.
7904         * target.c: Update.
7905         * thread.c: Update.
7906         * top.c: Update.
7907         * tracefile-tfile.c: Update.
7908         * tui/tui.c: Update.
7909         * typeprint.c: Update.
7910         * unittests/cli-utils-selftests.c: Update.
7911         * unittests/parse-connection-spec-selftests.c: Update.
7912         * valops.c: Update.
7913         * valprint.c: Update.
7914         * value.c: Update.
7915         * varobj.c: Update.
7916         * windows-nat.c: Update.
7917         * x86-linux-nat.c: Update.
7918         * xml-support.c: Update.
7919
7920 2019-04-08  Tom Tromey  <tom@tromey.com>
7921
7922         * xml-support.c: Use C++ exception handling.
7923         * x86-linux-nat.c: Use C++ exception handling.
7924         * windows-nat.c: Use C++ exception handling.
7925         * varobj.c: Use C++ exception handling.
7926         * value.c: Use C++ exception handling.
7927         * valprint.c: Use C++ exception handling.
7928         * valops.c: Use C++ exception handling.
7929         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7930         handling.
7931         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7932         * typeprint.c: Use C++ exception handling.
7933         * tui/tui.c: Use C++ exception handling.
7934         * tracefile-tfile.c: Use C++ exception handling.
7935         * top.c: Use C++ exception handling.
7936         * thread.c: Use C++ exception handling.
7937         * target.c: Use C++ exception handling.
7938         * symmisc.c: Use C++ exception handling.
7939         * symfile-mem.c: Use C++ exception handling.
7940         * stack.c: Use C++ exception handling.
7941         * sparc64-linux-tdep.c: Use C++ exception handling.
7942         * solib.c: Use C++ exception handling.
7943         * solib-svr4.c: Use C++ exception handling.
7944         * solib-spu.c: Use C++ exception handling.
7945         * solib-frv.c: Use C++ exception handling.
7946         * solib-dsbt.c: Use C++ exception handling.
7947         * selftest-arch.c: Use C++ exception handling.
7948         * s390-tdep.c: Use C++ exception handling.
7949         * rust-lang.c: Use C++ exception handling.
7950         * rust-exp.y: Use C++ exception handling.
7951         * rs6000-tdep.c: Use C++ exception handling.
7952         * rs6000-aix-tdep.c: Use C++ exception handling.
7953         * riscv-tdep.c: Use C++ exception handling.
7954         * remote.c: Use C++ exception handling.
7955         * remote-fileio.c: Use C++ exception handling.
7956         * record-full.c: Use C++ exception handling.
7957         * record-btrace.c: Use C++ exception handling.
7958         * python/python.c: Use C++ exception handling.
7959         * python/py-value.c: Use C++ exception handling.
7960         * python/py-utils.c: Use C++ exception handling.
7961         * python/py-unwind.c: Use C++ exception handling.
7962         * python/py-type.c: Use C++ exception handling.
7963         * python/py-symbol.c: Use C++ exception handling.
7964         * python/py-record.c: Use C++ exception handling.
7965         * python/py-record-btrace.c: Use C++ exception handling.
7966         * python/py-progspace.c: Use C++ exception handling.
7967         * python/py-prettyprint.c: Use C++ exception handling.
7968         * python/py-param.c: Use C++ exception handling.
7969         * python/py-objfile.c: Use C++ exception handling.
7970         * python/py-linetable.c: Use C++ exception handling.
7971         * python/py-lazy-string.c: Use C++ exception handling.
7972         * python/py-infthread.c: Use C++ exception handling.
7973         * python/py-inferior.c: Use C++ exception handling.
7974         * python/py-gdb-readline.c: Use C++ exception handling.
7975         * python/py-framefilter.c: Use C++ exception handling.
7976         * python/py-frame.c: Use C++ exception handling.
7977         * python/py-finishbreakpoint.c: Use C++ exception handling.
7978         * python/py-cmd.c: Use C++ exception handling.
7979         * python/py-breakpoint.c: Use C++ exception handling.
7980         * python/py-arch.c: Use C++ exception handling.
7981         * printcmd.c: Use C++ exception handling.
7982         * ppc-linux-tdep.c: Use C++ exception handling.
7983         * parse.c: Use C++ exception handling.
7984         * p-valprint.c: Use C++ exception handling.
7985         * objc-lang.c: Use C++ exception handling.
7986         * mi/mi-main.c: Use C++ exception handling.
7987         * mi/mi-interp.c: Use C++ exception handling.
7988         * mi/mi-cmd-stack.c: Use C++ exception handling.
7989         * mi/mi-cmd-break.c: Use C++ exception handling.
7990         * main.c: Use C++ exception handling.
7991         * linux-thread-db.c: Use C++ exception handling.
7992         * linux-tdep.c: Use C++ exception handling.
7993         * linux-nat.c: Use C++ exception handling.
7994         * linux-fork.c: Use C++ exception handling.
7995         * linespec.c: Use C++ exception handling.
7996         * language.c: Use C++ exception handling.
7997         * jit.c: Use C++ exception handling.
7998         * infrun.c: Use C++ exception handling.
7999         * infcmd.c: Use C++ exception handling.
8000         * infcall.c: Use C++ exception handling.
8001         * inf-loop.c: Use C++ exception handling.
8002         * i386-tdep.c: Use C++ exception handling.
8003         * i386-linux-tdep.c: Use C++ exception handling.
8004         * guile/scm-value.c: Use C++ exception handling.
8005         * guile/scm-type.c: Use C++ exception handling.
8006         * guile/scm-symtab.c: Use C++ exception handling.
8007         * guile/scm-symbol.c: Use C++ exception handling.
8008         * guile/scm-pretty-print.c: Use C++ exception handling.
8009         * guile/scm-ports.c: Use C++ exception handling.
8010         * guile/scm-param.c: Use C++ exception handling.
8011         * guile/scm-math.c: Use C++ exception handling.
8012         * guile/scm-lazy-string.c: Use C++ exception handling.
8013         * guile/scm-frame.c: Use C++ exception handling.
8014         * guile/scm-disasm.c: Use C++ exception handling.
8015         * guile/scm-cmd.c: Use C++ exception handling.
8016         * guile/scm-breakpoint.c: Use C++ exception handling.
8017         * guile/scm-block.c: Use C++ exception handling.
8018         * guile/guile-internal.h: Use C++ exception handling.
8019         * gnu-v3-abi.c: Use C++ exception handling.
8020         * gdbtypes.c: Use C++ exception handling.
8021         * frame.c: Use C++ exception handling.
8022         * frame-unwind.c: Use C++ exception handling.
8023         * fbsd-tdep.c: Use C++ exception handling.
8024         * f-valprint.c: Use C++ exception handling.
8025         * exec.c: Use C++ exception handling.
8026         * event-top.c: Use C++ exception handling.
8027         * event-loop.c: Use C++ exception handling.
8028         * eval.c: Use C++ exception handling.
8029         * dwarf2read.c: Use C++ exception handling.
8030         * dwarf2loc.c: Use C++ exception handling.
8031         * dwarf2-frame.c: Use C++ exception handling.
8032         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8033         * dwarf-index-write.c: Use C++ exception handling.
8034         * dwarf-index-cache.c: Use C++ exception handling.
8035         * dtrace-probe.c: Use C++ exception handling.
8036         * disasm-selftests.c: Use C++ exception handling.
8037         * darwin-nat.c: Use C++ exception handling.
8038         * cp-valprint.c: Use C++ exception handling.
8039         * cp-support.c: Use C++ exception handling.
8040         * cp-abi.c: Use C++ exception handling.
8041         * corelow.c: Use C++ exception handling.
8042         * completer.c: Use C++ exception handling.
8043         * compile/compile-object-run.c: Use C++ exception handling.
8044         * compile/compile-object-load.c: Use C++ exception handling.
8045         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8046         * compile/compile-c-symbols.c: Use C++ exception handling.
8047         * common/selftest.c: Use C++ exception handling.
8048         * common/new-op.c: Use C++ exception handling.
8049         * cli/cli-script.c: Use C++ exception handling.
8050         * cli/cli-interp.c: Use C++ exception handling.
8051         * cli/cli-cmds.c: Use C++ exception handling.
8052         * c-varobj.c: Use C++ exception handling.
8053         * btrace.c: Use C++ exception handling.
8054         * breakpoint.c: Use C++ exception handling.
8055         * break-catch-throw.c: Use C++ exception handling.
8056         * arch-utils.c: Use C++ exception handling.
8057         * amd64-tdep.c: Use C++ exception handling.
8058         * ada-valprint.c: Use C++ exception handling.
8059         * ada-typeprint.c: Use C++ exception handling.
8060         * ada-lang.c: Use C++ exception handling.
8061         * aarch64-tdep.c: Use C++ exception handling.
8062
8063 2019-04-08  Tom Tromey  <tom@tromey.com>
8064
8065         * xml-support.c (gdb_xml_parser::parse): Update.
8066         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8067         * value.c (show_convenience): Update.
8068         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8069         (test_parse_flags_qcs): Update.
8070         * thread.c (thr_try_catch_cmd): Update.
8071         * target.c (target_translate_tls_address): Update.
8072         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8073         (info_frame_command_core, frame_apply_command_count): Update.
8074         * rust-exp.y (rust_lex_exception_test): Update.
8075         * riscv-tdep.c (riscv_print_one_register_info): Update.
8076         * remote.c (remote_target::enable_btrace): Update.
8077         * record-btrace.c (record_btrace_enable_warn): Update.
8078         * python/py-utils.c (gdbpy_convert_exception): Update.
8079         * printcmd.c (do_one_display, print_variable_and_value): Update.
8080         * mi/mi-main.c (mi_print_exception): Update.
8081         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8082         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8083         * linux-nat.c (linux_nat_target::attach): Update.
8084         * linux-fork.c (class scoped_switch_fork_info): Update.
8085         * infrun.c (displaced_step_prepare): Update.
8086         * infcall.c (call_function_by_hand_dummy): Update.
8087         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8088         * gnu-v3-abi.c (print_one_vtable): Update.
8089         * frame.c (get_prev_frame_always): Update.
8090         * f-valprint.c (info_common_command_for_block): Update.
8091         * exec.c (try_open_exec_file): Update.
8092         * exceptions.c (print_exception, exception_print)
8093         (exception_fprintf, exception_print_same): Update.
8094         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8095         * dwarf-index-cache.c (index_cache::store)
8096         (index_cache::lookup_gdb_index): Update.
8097         * darwin-nat.c (maybe_cache_shell): Update.
8098         * cp-valprint.c (cp_print_value_fields): Update.
8099         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8100         (gcc_cplus_symbol_address): Update.
8101         * compile/compile-c-symbols.c (gcc_convert_symbol)
8102         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8103         * common/selftest.c: Update.
8104         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8105         a std::string.
8106         (exception_try_scope_entry, exception_try_scope_exit): Don't
8107         declare.
8108         (struct exception_try_scope): Remove.
8109         (TRY): Don't use exception_try_scope.
8110         (struct gdb_exception): Add constructor, operator=.
8111         <what>: New method.
8112         (struct gdb_exception_RETURN_MASK_ALL)
8113         (struct gdb_exception_RETURN_MASK_ERROR)
8114         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8115         (struct gdb_quit_bad_alloc): Update.
8116         * common/common-exceptions.c (exception_none): Change
8117         initializer.
8118         (struct catcher) <state, exception>: Initialize inline.
8119         <prev>: Remove member.
8120         (current_catcher): Remove.
8121         (catchers): New global.
8122         (exceptions_state_mc_init): Simplify.
8123         (catcher_pop): Remove.
8124         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8125         (try_scope_depth, exception_try_scope_entry)
8126         (exception_try_scope_exit): Remove.
8127         (throw_exception_sjlj): Update.
8128         (exception_messages, exception_messages_size): Remove.
8129         (throw_it): Simplify.
8130         (gdb_exception_sliced_copy): Remove.
8131         (throw_exception_cxx): Update.
8132         * cli/cli-script.c (script_from_file): Update.
8133         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8134         Update.
8135         * ada-valprint.c (ada_val_print): Update.
8136         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8137         (create_excep_cond_exprs): Update.
8138
8139 2019-04-08  Tom Tromey  <tom@tromey.com>
8140
8141         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8142         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8143         (TRY, CATCH, END_CATCH): Remove some definitions.
8144         * common/common-exceptions.c: Don't use GDB_XCPT.
8145         (catcher_list_size): Remove.
8146         (throw_exception, throw_it): Simplify.
8147
8148 2019-04-05  Tom Tromey  <tom@tromey.com>
8149
8150         Revert the header-sorting patch.
8151         * ft32-tdep.c: Revert.
8152         * frv-tdep.c: Revert.
8153         * frv-linux-tdep.c: Revert.
8154         * frame.c: Revert.
8155         * frame-unwind.c: Revert.
8156         * frame-base.c: Revert.
8157         * fork-child.c: Revert.
8158         * findvar.c: Revert.
8159         * findcmd.c: Revert.
8160         * filesystem.c: Revert.
8161         * filename-seen-cache.h: Revert.
8162         * filename-seen-cache.c: Revert.
8163         * fbsd-tdep.c: Revert.
8164         * fbsd-nat.h: Revert.
8165         * fbsd-nat.c: Revert.
8166         * f-valprint.c: Revert.
8167         * f-typeprint.c: Revert.
8168         * f-lang.c: Revert.
8169         * extension.h: Revert.
8170         * extension.c: Revert.
8171         * extension-priv.h: Revert.
8172         * expprint.c: Revert.
8173         * exec.h: Revert.
8174         * exec.c: Revert.
8175         * exceptions.c: Revert.
8176         * event-top.c: Revert.
8177         * event-loop.c: Revert.
8178         * eval.c: Revert.
8179         * elfread.c: Revert.
8180         * dwarf2read.h: Revert.
8181         * dwarf2read.c: Revert.
8182         * dwarf2loc.c: Revert.
8183         * dwarf2expr.h: Revert.
8184         * dwarf2expr.c: Revert.
8185         * dwarf2-frame.c: Revert.
8186         * dwarf2-frame-tailcall.c: Revert.
8187         * dwarf-index-write.h: Revert.
8188         * dwarf-index-write.c: Revert.
8189         * dwarf-index-common.c: Revert.
8190         * dwarf-index-cache.h: Revert.
8191         * dwarf-index-cache.c: Revert.
8192         * dummy-frame.c: Revert.
8193         * dtrace-probe.c: Revert.
8194         * disasm.h: Revert.
8195         * disasm.c: Revert.
8196         * disasm-selftests.c: Revert.
8197         * dictionary.c: Revert.
8198         * dicos-tdep.c: Revert.
8199         * demangle.c: Revert.
8200         * dcache.h: Revert.
8201         * dcache.c: Revert.
8202         * darwin-nat.h: Revert.
8203         * darwin-nat.c: Revert.
8204         * darwin-nat-info.c: Revert.
8205         * d-valprint.c: Revert.
8206         * d-namespace.c: Revert.
8207         * d-lang.c: Revert.
8208         * ctf.c: Revert.
8209         * csky-tdep.c: Revert.
8210         * csky-linux-tdep.c: Revert.
8211         * cris-tdep.c: Revert.
8212         * cris-linux-tdep.c: Revert.
8213         * cp-valprint.c: Revert.
8214         * cp-support.c: Revert.
8215         * cp-namespace.c: Revert.
8216         * cp-abi.c: Revert.
8217         * corelow.c: Revert.
8218         * corefile.c: Revert.
8219         * continuations.c: Revert.
8220         * completer.h: Revert.
8221         * completer.c: Revert.
8222         * complaints.c: Revert.
8223         * coffread.c: Revert.
8224         * coff-pe-read.c: Revert.
8225         * cli-out.h: Revert.
8226         * cli-out.c: Revert.
8227         * charset.c: Revert.
8228         * c-varobj.c: Revert.
8229         * c-valprint.c: Revert.
8230         * c-typeprint.c: Revert.
8231         * c-lang.c: Revert.
8232         * buildsym.c: Revert.
8233         * buildsym-legacy.c: Revert.
8234         * build-id.h: Revert.
8235         * build-id.c: Revert.
8236         * btrace.c: Revert.
8237         * bsd-uthread.c: Revert.
8238         * breakpoint.h: Revert.
8239         * breakpoint.c: Revert.
8240         * break-catch-throw.c: Revert.
8241         * break-catch-syscall.c: Revert.
8242         * break-catch-sig.c: Revert.
8243         * blockframe.c: Revert.
8244         * block.c: Revert.
8245         * bfin-tdep.c: Revert.
8246         * bfin-linux-tdep.c: Revert.
8247         * bfd-target.c: Revert.
8248         * bcache.c: Revert.
8249         * ax-general.c: Revert.
8250         * ax-gdb.h: Revert.
8251         * ax-gdb.c: Revert.
8252         * avr-tdep.c: Revert.
8253         * auxv.c: Revert.
8254         * auto-load.c: Revert.
8255         * arm-wince-tdep.c: Revert.
8256         * arm-tdep.c: Revert.
8257         * arm-symbian-tdep.c: Revert.
8258         * arm-pikeos-tdep.c: Revert.
8259         * arm-obsd-tdep.c: Revert.
8260         * arm-nbsd-tdep.c: Revert.
8261         * arm-nbsd-nat.c: Revert.
8262         * arm-linux-tdep.c: Revert.
8263         * arm-linux-nat.c: Revert.
8264         * arm-fbsd-tdep.c: Revert.
8265         * arm-fbsd-nat.c: Revert.
8266         * arm-bsd-tdep.c: Revert.
8267         * arch-utils.c: Revert.
8268         * arc-tdep.c: Revert.
8269         * arc-newlib-tdep.c: Revert.
8270         * annotate.h: Revert.
8271         * annotate.c: Revert.
8272         * amd64-windows-tdep.c: Revert.
8273         * amd64-windows-nat.c: Revert.
8274         * amd64-tdep.c: Revert.
8275         * amd64-sol2-tdep.c: Revert.
8276         * amd64-obsd-tdep.c: Revert.
8277         * amd64-obsd-nat.c: Revert.
8278         * amd64-nbsd-tdep.c: Revert.
8279         * amd64-nbsd-nat.c: Revert.
8280         * amd64-nat.c: Revert.
8281         * amd64-linux-tdep.c: Revert.
8282         * amd64-linux-nat.c: Revert.
8283         * amd64-fbsd-tdep.c: Revert.
8284         * amd64-fbsd-nat.c: Revert.
8285         * amd64-dicos-tdep.c: Revert.
8286         * amd64-darwin-tdep.c: Revert.
8287         * amd64-bsd-nat.c: Revert.
8288         * alpha-tdep.c: Revert.
8289         * alpha-obsd-tdep.c: Revert.
8290         * alpha-nbsd-tdep.c: Revert.
8291         * alpha-mdebug-tdep.c: Revert.
8292         * alpha-linux-tdep.c: Revert.
8293         * alpha-linux-nat.c: Revert.
8294         * alpha-bsd-tdep.c: Revert.
8295         * alpha-bsd-nat.c: Revert.
8296         * aix-thread.c: Revert.
8297         * agent.c: Revert.
8298         * addrmap.c: Revert.
8299         * ada-varobj.c: Revert.
8300         * ada-valprint.c: Revert.
8301         * ada-typeprint.c: Revert.
8302         * ada-tasks.c: Revert.
8303         * ada-lang.c: Revert.
8304         * aarch64-tdep.c: Revert.
8305         * aarch64-ravenscar-thread.c: Revert.
8306         * aarch64-newlib-tdep.c: Revert.
8307         * aarch64-linux-tdep.c: Revert.
8308         * aarch64-linux-nat.c: Revert.
8309         * aarch64-fbsd-tdep.c: Revert.
8310         * aarch64-fbsd-nat.c: Revert.
8311         * aarch32-linux-nat.c: Revert.
8312
8313 2019-04-05  Tom Tromey  <tom@tromey.com>
8314
8315         * ft32-tdep.c: Sort headers.
8316         * frv-tdep.c: Sort headers.
8317         * frv-linux-tdep.c: Sort headers.
8318         * frame.c: Sort headers.
8319         * frame-unwind.c: Sort headers.
8320         * frame-base.c: Sort headers.
8321         * fork-child.c: Sort headers.
8322         * findvar.c: Sort headers.
8323         * findcmd.c: Sort headers.
8324         * filesystem.c: Sort headers.
8325         * filename-seen-cache.h: Sort headers.
8326         * filename-seen-cache.c: Sort headers.
8327         * fbsd-tdep.c: Sort headers.
8328         * fbsd-nat.h: Sort headers.
8329         * fbsd-nat.c: Sort headers.
8330         * f-valprint.c: Sort headers.
8331         * f-typeprint.c: Sort headers.
8332         * f-lang.c: Sort headers.
8333         * extension.h: Sort headers.
8334         * extension.c: Sort headers.
8335         * extension-priv.h: Sort headers.
8336         * expprint.c: Sort headers.
8337         * exec.h: Sort headers.
8338         * exec.c: Sort headers.
8339         * exceptions.c: Sort headers.
8340         * event-top.c: Sort headers.
8341         * event-loop.c: Sort headers.
8342         * eval.c: Sort headers.
8343         * elfread.c: Sort headers.
8344         * dwarf2read.h: Sort headers.
8345         * dwarf2read.c: Sort headers.
8346         * dwarf2loc.c: Sort headers.
8347         * dwarf2expr.h: Sort headers.
8348         * dwarf2expr.c: Sort headers.
8349         * dwarf2-frame.c: Sort headers.
8350         * dwarf2-frame-tailcall.c: Sort headers.
8351         * dwarf-index-write.h: Sort headers.
8352         * dwarf-index-write.c: Sort headers.
8353         * dwarf-index-common.c: Sort headers.
8354         * dwarf-index-cache.h: Sort headers.
8355         * dwarf-index-cache.c: Sort headers.
8356         * dummy-frame.c: Sort headers.
8357         * dtrace-probe.c: Sort headers.
8358         * disasm.h: Sort headers.
8359         * disasm.c: Sort headers.
8360         * disasm-selftests.c: Sort headers.
8361         * dictionary.c: Sort headers.
8362         * dicos-tdep.c: Sort headers.
8363         * demangle.c: Sort headers.
8364         * dcache.h: Sort headers.
8365         * dcache.c: Sort headers.
8366         * darwin-nat.h: Sort headers.
8367         * darwin-nat.c: Sort headers.
8368         * darwin-nat-info.c: Sort headers.
8369         * d-valprint.c: Sort headers.
8370         * d-namespace.c: Sort headers.
8371         * d-lang.c: Sort headers.
8372         * ctf.c: Sort headers.
8373         * csky-tdep.c: Sort headers.
8374         * csky-linux-tdep.c: Sort headers.
8375         * cris-tdep.c: Sort headers.
8376         * cris-linux-tdep.c: Sort headers.
8377         * cp-valprint.c: Sort headers.
8378         * cp-support.c: Sort headers.
8379         * cp-namespace.c: Sort headers.
8380         * cp-abi.c: Sort headers.
8381         * corelow.c: Sort headers.
8382         * corefile.c: Sort headers.
8383         * continuations.c: Sort headers.
8384         * completer.h: Sort headers.
8385         * completer.c: Sort headers.
8386         * complaints.c: Sort headers.
8387         * coffread.c: Sort headers.
8388         * coff-pe-read.c: Sort headers.
8389         * cli-out.h: Sort headers.
8390         * cli-out.c: Sort headers.
8391         * charset.c: Sort headers.
8392         * c-varobj.c: Sort headers.
8393         * c-valprint.c: Sort headers.
8394         * c-typeprint.c: Sort headers.
8395         * c-lang.c: Sort headers.
8396         * buildsym.c: Sort headers.
8397         * buildsym-legacy.c: Sort headers.
8398         * build-id.h: Sort headers.
8399         * build-id.c: Sort headers.
8400         * btrace.c: Sort headers.
8401         * bsd-uthread.c: Sort headers.
8402         * breakpoint.h: Sort headers.
8403         * breakpoint.c: Sort headers.
8404         * break-catch-throw.c: Sort headers.
8405         * break-catch-syscall.c: Sort headers.
8406         * break-catch-sig.c: Sort headers.
8407         * blockframe.c: Sort headers.
8408         * block.c: Sort headers.
8409         * bfin-tdep.c: Sort headers.
8410         * bfin-linux-tdep.c: Sort headers.
8411         * bfd-target.c: Sort headers.
8412         * bcache.c: Sort headers.
8413         * ax-general.c: Sort headers.
8414         * ax-gdb.h: Sort headers.
8415         * ax-gdb.c: Sort headers.
8416         * avr-tdep.c: Sort headers.
8417         * auxv.c: Sort headers.
8418         * auto-load.c: Sort headers.
8419         * arm-wince-tdep.c: Sort headers.
8420         * arm-tdep.c: Sort headers.
8421         * arm-symbian-tdep.c: Sort headers.
8422         * arm-pikeos-tdep.c: Sort headers.
8423         * arm-obsd-tdep.c: Sort headers.
8424         * arm-nbsd-tdep.c: Sort headers.
8425         * arm-nbsd-nat.c: Sort headers.
8426         * arm-linux-tdep.c: Sort headers.
8427         * arm-linux-nat.c: Sort headers.
8428         * arm-fbsd-tdep.c: Sort headers.
8429         * arm-fbsd-nat.c: Sort headers.
8430         * arm-bsd-tdep.c: Sort headers.
8431         * arch-utils.c: Sort headers.
8432         * arc-tdep.c: Sort headers.
8433         * arc-newlib-tdep.c: Sort headers.
8434         * annotate.h: Sort headers.
8435         * annotate.c: Sort headers.
8436         * amd64-windows-tdep.c: Sort headers.
8437         * amd64-windows-nat.c: Sort headers.
8438         * amd64-tdep.c: Sort headers.
8439         * amd64-sol2-tdep.c: Sort headers.
8440         * amd64-obsd-tdep.c: Sort headers.
8441         * amd64-obsd-nat.c: Sort headers.
8442         * amd64-nbsd-tdep.c: Sort headers.
8443         * amd64-nbsd-nat.c: Sort headers.
8444         * amd64-nat.c: Sort headers.
8445         * amd64-linux-tdep.c: Sort headers.
8446         * amd64-linux-nat.c: Sort headers.
8447         * amd64-fbsd-tdep.c: Sort headers.
8448         * amd64-fbsd-nat.c: Sort headers.
8449         * amd64-dicos-tdep.c: Sort headers.
8450         * amd64-darwin-tdep.c: Sort headers.
8451         * amd64-bsd-nat.c: Sort headers.
8452         * alpha-tdep.c: Sort headers.
8453         * alpha-obsd-tdep.c: Sort headers.
8454         * alpha-nbsd-tdep.c: Sort headers.
8455         * alpha-mdebug-tdep.c: Sort headers.
8456         * alpha-linux-tdep.c: Sort headers.
8457         * alpha-linux-nat.c: Sort headers.
8458         * alpha-bsd-tdep.c: Sort headers.
8459         * alpha-bsd-nat.c: Sort headers.
8460         * aix-thread.c: Sort headers.
8461         * agent.c: Sort headers.
8462         * addrmap.c: Sort headers.
8463         * ada-varobj.c: Sort headers.
8464         * ada-valprint.c: Sort headers.
8465         * ada-typeprint.c: Sort headers.
8466         * ada-tasks.c: Sort headers.
8467         * ada-lang.c: Sort headers.
8468         * aarch64-tdep.c: Sort headers.
8469         * aarch64-ravenscar-thread.c: Sort headers.
8470         * aarch64-newlib-tdep.c: Sort headers.
8471         * aarch64-linux-tdep.c: Sort headers.
8472         * aarch64-linux-nat.c: Sort headers.
8473         * aarch64-fbsd-tdep.c: Sort headers.
8474         * aarch64-fbsd-nat.c: Sort headers.
8475         * aarch32-linux-nat.c: Sort headers.
8476
8477 2019-04-04  Tom Tromey  <tom@tromey.com>
8478
8479         * varobj.c (varobj_create): Update.
8480         * rust-exp.y (struct rust_parser) <update_innermost_block,
8481         lookup_symbol>: New methods.
8482         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8483         Rename.
8484         (rust_parser::rust_lookup_type)
8485         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8486         * printcmd.c (display_command, do_one_display): Update.
8487         * parser-defs.h (struct parser_state) <parser_state>: Add
8488         "tracker" parameter.
8489         (block_tracker): New member.
8490         (class innermost_block_tracker) <innermost_block_tracker>: Add
8491         "types" parameter.
8492         <reset>: Remove method.
8493         (innermost_block): Don't declare.
8494         (null_post_parser): Update.
8495         * parse.c (innermost_block): Remove global.
8496         (write_dollar_variable): Update.
8497         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8498         Remove "tracker_types" parameter.
8499         (parse_expression): Add "tracker" parameter.
8500         (parse_expression_for_completion): Update.
8501         (null_post_parser): Add "tracker" parameter.
8502         * p-exp.y: Update rules.
8503         * m2-exp.y: Update rules.
8504         * language.h (struct language_defn) <la_post_parser>: Add
8505         "tracker" parameter.
8506         * go-exp.y: Update rules.
8507         * f-exp.y: Update rules.
8508         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8509         parameter.
8510         * d-exp.y: Update rules.
8511         * c-exp.y: Update rules.
8512         * breakpoint.c (set_breakpoint_condition): Create an
8513         innermost_block_tracker.
8514         (watch_command_1): Likewise.
8515         * ada-lang.c (resolve): Add "tracker" parameter.
8516         (resolve_subexp): Likewise.
8517         * ada-exp.y (write_var_from_sym): Update.
8518
8519 2019-04-04  Tom Tromey  <tom@tromey.com>
8520
8521         * type-stack.h: New file.
8522         * type-stack.c: New file.
8523         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8524         type-stack.h.
8525         (insert_into_type_stack, insert_type, push_type, push_type_int)
8526         (insert_type_address_space, pop_type, pop_type_int)
8527         (pop_typelist, pop_type_stack, append_type_stack)
8528         (push_type_stack, get_type_stack, push_typelist)
8529         (follow_type_instance_flags, follow_types): Don't declare.
8530         * parse.c (type_stack): Remove global.
8531         (parse_exp_in_context): Update.
8532         (insert_into_type_stack, insert_type, push_type, push_type_int)
8533         (insert_type_address_space, pop_type, pop_type_int)
8534         (pop_typelist, pop_type_stack, append_type_stack)
8535         (push_type_stack, get_type_stack, push_typelist)
8536         (follow_type_instance_flags, follow_types): Remove (moved to
8537         type-stack.c).
8538         * f-exp.y (type_stack): New global.
8539         Update rules.
8540         (push_kind_type, f_parse): Update.
8541         * d-exp.y (type_stack): New global.
8542         Update rules.
8543         (d_parse): Update.
8544         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8545         Update rules.
8546         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8547         (HFILES_NO_SRCDIR): Add type-stack.h.
8548
8549 2019-04-04  Tom Tromey  <tom@tromey.com>
8550
8551         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8552         (rust_parser::convert_ast_to_expression, rust_parse)
8553         (rust_lex_test_completion, rust_lex_tests): Update.
8554         * parser-defs.h (struct expr_completion_state): New.
8555         (struct parser_state) <parser_state>: Add completion parameter.
8556         <mark_struct_expression, mark_completion_tag>: New methods.
8557         <parse_completion, m_completion_state>: New members.
8558         (prefixify_expression, null_post_parser): Update.
8559         (mark_struct_expression, mark_completion_tag): Don't declare.
8560         * parse.c (parse_completion, expout_last_struct)
8561         (expout_tag_completion_type, expout_completion_name): Remove
8562         globals.
8563         (parser_state::mark_struct_expression)
8564         (parser_state::mark_completion_tag): Now methods.
8565         (prefixify_expression): Add last_struct parameter.
8566         (prefixify_subexp): Likewise.
8567         (parse_exp_1): Update.
8568         (parse_exp_in_context): Add cstate parameter.  Update.
8569         (parse_expression_for_completion): Create an
8570         expr_completion_state.
8571         (null_post_parser): Add "completion" parameter.
8572         * p-exp.y: Update rules.
8573         (yylex): Update.
8574         * language.h (struct language_defn) <la_post_parser>: Add
8575         "completing" parameter.
8576         * go-exp.y: Update rules.
8577         (lex_one_token): Update.
8578         * expression.h (parse_completion): Don't declare.
8579         * d-exp.y: Update rules.
8580         (lex_one_token): Update rules.
8581         * c-exp.y: Update rules.
8582         (lex_one_token): Update.
8583         * ada-lang.c (resolve): Add "parse_completion" parameter.
8584         (resolve_subexp): Likewise.
8585         (ada_resolve_function): Likewise.
8586
8587 2019-04-04  Tom Tromey  <tom@tromey.com>
8588
8589         * parser-defs.h (struct parser_state) <start_arglist,
8590         end_arglist>: New methods.
8591         <arglist_len, m_funcall_chain>: New members.
8592         (arglist_len, start_arglist, end_arglist): Don't declare.
8593         * parse.c (arglist_len, funcall_chain): Remove global.
8594         (start_arglist, end_arglist): Remove functions.
8595         (parse_exp_in_context): Update.
8596         * p-exp.y: Update rules.
8597         * m2-exp.y: Update rules.
8598         * go-exp.y: Update rules.
8599         * f-exp.y: Update rules.
8600         * d-exp.y: Update rules.
8601         * c-exp.y: Update rules.
8602
8603 2019-04-04  Tom Tromey  <tom@tromey.com>
8604
8605         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8606         lex_operator, push_back>: New methods.
8607         Update all rules.
8608         (rust_parser::lex_hex, lex_escape): Rename and update.
8609         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8610         (rust_parser::lex_operator): Rename and update.
8611         (rust_parser::lex_number, rustyylex, rustyyerror)
8612         (rust_lex_test_init, rust_lex_test_sequence)
8613         (rust_lex_test_push_back, rust_lex_tests): Update.
8614         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8615         parameter.
8616         <lexptr, prev_lexptr>: New members.
8617         (lexptr, prev_lexptr): Don't declare.
8618         * parse.c (lexptr, prev_lexptr): Remove globals.
8619         (parse_exp_in_context): Update.
8620         * p-exp.y (yylex, yyerror): Update.
8621         * m2-exp.y (parse_number, yylex, yyerror): Update.
8622         * go-exp.y (lex_one_token, yyerror): Update.
8623         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8624         * d-exp.y (lex_one_token, yyerror): Update.
8625         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8626         (lex_one_token, yyerror): Update.
8627         * ada-lex.l (YY_INPUT): Update.
8628         (rewind_to_char): Update.
8629         * ada-exp.y (yyerror): Update.
8630
8631 2019-04-04  Tom Tromey  <tom@tromey.com>
8632
8633         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8634         * parser-defs.h (struct parser_state) <parser_state>: Add new
8635         parameter.
8636         <comma_terminates>: New member.
8637         (comma_terminates): Don't declare global.
8638         * parse.c (comma_terminates): Remove global.
8639         (parse_exp_in_context): Update.
8640         * p-exp.y (yylex): Update.
8641         * m2-exp.y (yylex): Update.
8642         * go-exp.y (lex_one_token): Update.
8643         * f-exp.y (yylex): Update.
8644         * d-exp.y (lex_one_token): Update.
8645         * c-exp.y (lex_one_token): Update.
8646         * ada-lex.l: Update.
8647
8648 2019-04-04  Tom Tromey  <tom@tromey.com>
8649
8650         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8651         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8652         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8653         * parser-defs.h (paren_depth): Don't declare.
8654         * parse.c (paren_depth): Remove global.
8655         (parse_exp_in_context): Update.
8656         * p-exp.y (paren_depth): New global.
8657         (pascal_parse): Initialize it.
8658         * m2-exp.y (paren_depth): New global.
8659         (m2_parse): Initialize it.
8660         * go-exp.y (paren_depth): New global.
8661         (go_parse): Initialize it.
8662         * f-exp.y (paren_depth): New global.
8663         (f_parse): Initialize it.
8664         * d-exp.y (paren_depth): New global.
8665         (d_parse): Initialize it.
8666         * c-exp.y (paren_depth): New global.
8667         (c_parse): Initialize it.
8668         * ada-lex.l (paren_depth): New global.
8669         (lexer_init): Initialize it.
8670
8671 2019-04-04  Tom Tromey  <tom@tromey.com>
8672
8673         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8674         (rust_parser::convert_ast_to_type)
8675         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8676         * parser-defs.h (struct parser_state) <parser_state>: Add
8677         parameters.  Initialize new members.
8678         <expression_context_block, expression_context_pc>: New members.
8679         * parse.c (expression_context_block, expression_context_pc):
8680         Remove globals.
8681         (parse_exp_in_context): Update.
8682         * p-exp.y: Update all rules.
8683         (yylex): Update.
8684         * m2-exp.y: Update all rules.
8685         (yylex): Update.
8686         * go-exp.y (yylex): Update.
8687         * f-exp.y (yylex): Update.
8688         * d-exp.y: Update all rules.
8689         (yylex): Update.
8690         * c-exp.y: Update all rules.
8691         (lex_one_token, classify_name, yylex, c_parse): Update.
8692         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8693
8694 2019-04-04  Tom Tromey  <tom@tromey.com>
8695
8696         * gdbarch.h, gdbarch.c: Rebuild.
8697         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8698         * stap-probe.h:
8699         (struct stap_parse_info): Replace "parser_state" with
8700         "expr_builder".
8701         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8702         (parser_state): New class.
8703         * parse.c (expr_builder): Rename.
8704         (expr_builder::release): Rename.
8705         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8706         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8707         (write_exp_elt_longcst, write_exp_elt_floatcst)
8708         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8709         (write_exp_string_vector, write_exp_bitstring)
8710         (write_exp_msymbol, mark_struct_expression)
8711         (write_dollar_variable)
8712         (insert_type_address_space, increase_expout_size): Replace
8713         "parser_state" with "expr_builder".
8714         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8715         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8716         "parser_state" with "expr_builder".
8717
8718 2019-04-04  Tom Tromey  <tom@tromey.com>
8719
8720         * rust-exp.y: Replace "parse_language" with method call.
8721         * p-exp.y:
8722         (yylex): Replace "parse_language" with method call.
8723         * m2-exp.y:
8724         (yylex): Replace "parse_language" with method call.
8725         * go-exp.y (classify_name): Replace "parse_language" with method
8726         call.
8727         * f-exp.y (yylex): Replace "parse_language" with method call.
8728         * d-exp.y (lex_one_token): Replace "parse_language" with method
8729         call.
8730         * c-exp.y:
8731         (lex_one_token, classify_name, yylex): Replace "parse_language"
8732         with method call.
8733         * ada-exp.y (find_primitive_type, type_char)
8734         (type_system_address): Replace "parse_language" with method call.
8735
8736 2019-04-04  Tom Tromey  <tom@tromey.com>
8737
8738         * rust-exp.y: Replace "parse_gdbarch" with method call.
8739         * parse.c (write_dollar_variable, insert_type_address_space):
8740         Replace "parse_gdbarch" with method call.
8741         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8742         call.
8743         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8744         call.
8745         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8746         "parse_gdbarch" with method call.
8747         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8748         with method call.
8749         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8750         "parse_gdbarch" with method call.
8751         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8752         "parse_gdbarch" with method call.
8753         * c-exp.y (parse_type, parse_number, classify_name): Replace
8754         "parse_gdbarch" with method call.
8755         * ada-lex.l: Replace "parse_gdbarch" with method call.
8756         * ada-exp.y (parse_type, find_primitive_type, type_char)
8757         (type_system_address): Replace "parse_gdbarch" with method call.
8758
8759 2019-04-04  Tom Tromey  <tom@tromey.com>
8760
8761         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8762         * stap-probe.c (stap_parse_argument): Update.
8763         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8764         initial_size parameter.
8765         * rust-exp.y (rust_lex_tests): Update.
8766         * parse.c (parser_state): Update.
8767         (parse_exp_in_context): Update.
8768         * parser-defs.h (struct parser_state) <parser_state>: Remove
8769         "initial_size" parameter.
8770
8771 2019-04-04  Tom Tromey  <tom@tromey.com>
8772
8773         * parser-defs.h (increase_expout_size): Don't declare.
8774         * parse.c (increase_expout_size): Now static.
8775
8776 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8777
8778         * gnu-nat.c (gnu_nat_target::wait): Fix
8779         target_waitstatus_to_string call.
8780
8781 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8782
8783         * eval.c (evaluate_subexp_standard): Handle internal functions
8784         during Fortran function call handling.
8785
8786 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * NEWS: Mention new internal functions.
8789         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8790         (read_base_type): Use dwarf2_init_complex_target_type.
8791         * value.c (creal_internal_fn): New function.
8792         (cimag_internal_fn): New function.
8793         (_initialize_values): Register new internal functions.
8794
8795 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8796
8797         * infrun.c (stop_all_threads): If debug_infrun, always
8798         trace the wait status after wait_one, using
8799         target_waitstatus_to_string and target_pid_to_str.
8800         (handle_inferior_event): Replace various trace of
8801         wait status kind by a single trace.
8802         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8803         wait status kind image by target_waitstatus_to_string.
8804         * target/waitstatus.c (target_waitstatus_to_string): Fix
8805         obsolete comment.
8806
8807 2019-04-01  Tom Tromey  <tromey@adacore.com>
8808
8809         PR symtab/23331:
8810         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8811
8812 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8813             Pedro Alves  <palves@redhat.com>
8814
8815         * top.c (quit_force): Call 'finalize_values'.
8816         * value.c (finalize_values): New function.
8817         * value.h (finalize_values): Declare.
8818
8819 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8820
8821         * NEWS: Announce $_gdb_major and $_gdb_minor.
8822
8823         * top.c (init_gdb_version_vars): New function.
8824         (gdb_init): Call init_gdb_version_vars.
8825
8826 2019-03-29  Tom Tromey  <tromey@adacore.com>
8827
8828         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8829         help text.  Remove dead code.
8830
8831 2019-03-29  Keith Seitz  <keiths@redhat.com>
8832
8833         From Siddhesh Poyarekar:
8834         * f-lang.h (f77_get_upperbound): Return LONGEST.
8835         (f77_get_lowerbound): Likewise.
8836         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8837         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8838         print them.
8839         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8840         plongest to format print it.
8841         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8842         (f77_get_upperbound): Likewise.
8843         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8844         LOWER_BOUND to LONGEST.
8845         (f77_create_arrayprint_offset_tbl): Likewise.
8846
8847 2019-03-29  Keith Seitz  <keiths@redhat.com>
8848
8849         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8850         %s/pulongest for TYPE_LENGTH instead of %d in format
8851         strings.
8852         * ada-typerint.c (ada_print_type): Likewise.
8853         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8854         * compile/compile-c-support.c (generate_register_struct): Likewise.
8855         * gdbtypes.c (recursive_dump_type): Likewise.
8856         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8857         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8858         instead of %d in format strings.
8859         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8860         to std::min to ULONGEST.
8861         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8862         instead of %d in format strings.
8863         * tracepoint.c (info_scope_command): Likewise.
8864         * typeprint.c (print_offset_data::update)
8865         (print_offset_data::finish): Likewise.
8866         * xtensa-tdep.c (xtensa_store_return_value)
8867         (xtensa_push_dummy_call): Likewise.
8868
8869 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8870
8871         * windows-nat.c (display_selector): Fixed format specifications
8872         for 64-bit Cygwin.
8873
8874 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8875
8876         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8877
8878 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8879
8880         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8881         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8882         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8883         (nios2_linux_init_abi): Install it.
8884
8885 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8886
8887         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8888
8889 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8890
8891         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8892
8893 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8894             Tom Tromey  <tromey@adacore.com>
8895
8896         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8897
8898 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8899
8900         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8901         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8902         method to compute the bounds of range types. Also print "[evaluated]"
8903         if the bounds' values come from a dynamic evaluation.
8904
8905 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8906
8907         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8908         whitespace when pretty printing is on.
8909
8910 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8911
8912         * ppc-linux-nat.c: Add include.
8913
8914 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8915
8916         * NEWS: Mention AArch64 Pointer Authentication.
8917
8918 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8919
8920         * arm-linux-nat.c: Add include.
8921
8922 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8923
8924         * source-cache.c (source_cache::get_source_lines): Re-read
8925         fullname after calling open_source_file.
8926
8927 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8928
8929         * NEWS: Mention TLS support for FreeBSD.
8930
8931 2019-03-25  Tom Tromey  <tromey@adacore.com>
8932
8933         * minsyms.c (BUNCH_SIZE): Update comment.
8934         (~minimal_symbol_reader): Remove old comment.
8935         (compact_minimal_symbols): Update comment.
8936         (minimal_symbol_reader::install): Remove old comment.  Update
8937         other comments.
8938
8939 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8940
8941         * s390-linux-nat.c: Add include.
8942
8943 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8944
8945         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8946         Call linux_get_hwcap.
8947         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8948         Likewise.
8949         (aarch64_linux_get_hwcap): Remove function.
8950         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8951         declaration.
8952         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8953         linux_get_hwcap.
8954         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8955         * linux-tdep.c (linux_get_hwcap): Add function.
8956         (linux_get_hwcap2): Likewise.
8957         * linux-tdep.h (linux_get_hwcap): Add declaration.
8958         (linux_get_hwcap2): Likewise.
8959         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8960         (ppc_linux_get_hwcap2): Likewise.
8961         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8962         linux_get_hwcap.
8963         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8964         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8965         (ppc_linux_nat_target::read_description): Likewise.
8966         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8967         * s390-linux-nat.c: Likewise.
8968         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8969
8970 2019-03-24  Tom Tromey  <tom@tromey.com>
8971
8972         * ada-lang.c (standard_lookup): Simplify initialization.
8973         (ada_lookup_symbol_nonlocal): Simplify return.
8974         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8975         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8976         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8977         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8978         initialization.
8979         * solib.c (solib_global_lookup): Simplify.
8980         * symtab.c (null_block_symbol): Remove.
8981         (symbol_cache_lookup): Simplify returns.
8982         (lookup_language_this): Simplify returns.
8983         (lookup_symbol_aux): Simplify return.
8984         (lookup_local_symbol): Simplify returns.
8985         (lookup_global_symbol_from_objfile): Simplify return.
8986         (lookup_symbol_in_objfile_symtabs)
8987         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8988         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8989         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8990         * cp-namespace.c (cp_lookup_bare_symbol)
8991         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8992         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8993         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8994         (cp_lookup_symbol_via_imports): Simplify initialization.
8995         (find_symbol_in_baseclass): Likewise.
8996         * symtab.h (null_block_symbol): Remove.
8997         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8998         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8999         (d_lookup_symbol_module): Likewise.
9000         (find_symbol_in_baseclass): Simplify initialization.
9001
9002 2019-03-24  Tom Tromey  <tom@tromey.com>
9003
9004         * expression.h: Don't include symtab.h.
9005         (struct block): Forward declare.
9006
9007 2019-03-24  Tom Tromey  <tom@tromey.com>
9008
9009         * c-exp.y (typebase): Remove casts.
9010         * gdbtypes.c (lookup_unsigned_typename, )
9011         (lookup_signed_typename): Remove cast.
9012         * eval.c (parse_to_comma_and_eval): Remove cast.
9013         * parse.c (write_dollar_variable): Remove cast.
9014         * block.h (struct block) <superblock>: Now const.
9015         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9016         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9017         (map_block): Make "block" const.
9018         * symfile.h (struct quick_symbol_functions)
9019         <map_matching_symbols>: Constify block argument to "callback".
9020         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9021         const.
9022         (find_pc_sect_compunit_symtab): Make "b" const.
9023         (find_symbol_at_address): Likewise.
9024         (search_symbols): Likewise.
9025         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9026         (dw2_debug_names_lookup_symbol): Likewise.
9027         (dw2_map_matching_symbols): Update.
9028         * p-valprint.c (pascal_val_print): Remove "block".
9029         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9030         (aux_add_nonlocal_symbols): Make "block" const.
9031         (resolve_subexp): Remove cast.
9032         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9033         const.
9034         (iterate_over_file_blocks): Likewise.
9035         * f-exp.y (%union) <bval>: Remove.
9036         * coffread.c (patch_opaque_types): Make "b" const.
9037         * spu-tdep.c (spu_catch_start): Make "block" const.
9038         * c-valprint.c (print_unpacked_pointer): Remove "block".
9039         * symmisc.c (dump_symtab_1): Make "b" const.
9040         (block_depth): Make "block" const.
9041         * d-exp.y (%union) <bval>: Remove.
9042         * cp-support.h (cp_lookup_rtti_type): Update.
9043         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9044         * psymtab.c (psym_lookup_symbol): Make "block" const.
9045         (maintenance_check_psymtabs): Make "b" const.
9046         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9047         (enumerate_locals, enumerate_args): Update.
9048         * python/py-symtab.c (stpy_global_block): Make "block" const.
9049         (stpy_static_block): Likewise.
9050         * inline-frame.c (block_starting_point_at): Make "new_block"
9051         const.
9052         * block.c (find_block_in_blockvector): Make return type const.
9053         (blockvector_for_pc_sect): Make "b" const.
9054         (find_block_in_blockvector): Make "b" const.
9055
9056 2019-03-23  Tom Tromey  <tom@tromey.com>
9057
9058         * varobj.c (varobj_create): Update.
9059         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9060         * printcmd.c (display_command, do_one_display): Don't reset
9061         innermost_block.
9062         * parser-defs.h (enum innermost_block_tracker_type): Move to
9063         expression.h.
9064         (innermost_block): Update comment.
9065         * parse.c (parse_exp_1): Add tracker_types parameter.
9066         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9067         tracker_types parameter.  Reset innermost_block.
9068         (parse_exp_in_context): Remove.
9069         (parse_expression_for_completion): Update.
9070         * objfiles.c (~objfile): Don't reset expression_context_block or
9071         innermost_block.
9072         * expression.h (enum innermost_block_tracker_type): Move from
9073         parser-defs.h.
9074         (parse_exp_1): Add tracker_types parameter.
9075         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9076         reset innermost_block.
9077
9078 2019-03-23  Tom Tromey  <tom@tromey.com>
9079
9080         * objfiles.h: Include bcache.h.
9081
9082 2019-03-23  Tom Tromey  <tom@tromey.com>
9083
9084         * linespec.c (get_current_search_block): Use
9085         scoped_restore_current_language.
9086         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9087
9088 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9089             Jiong Wang  <jiong.wang@arm.com>
9090
9091         * aarch64-linux-tdep.c
9092         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9093         section.
9094         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9095
9096 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9097             Jiong Wang  <jiong.wang@arm.com>
9098
9099         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9100         instructions.
9101         (aarch64_analyze_prologue_test): Add PACIASP test.
9102         (aarch64_prologue_prev_register): Unmask PC value.
9103
9104 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9105             Jiong Wang  <jiong.wang@arm.com>
9106
9107         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9108         (aarch64_dwarf2_prev_register): Unmask PC value.
9109         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9110         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9111         DW_CFA_AARCH64_negate_ra_state.
9112         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9113
9114 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9115             Jiong Wang  <jiong.wang@arm.com>
9116
9117         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9118         registers.
9119         (aarch64_pseudo_register_name): Likewise.
9120         (aarch64_pseudo_register_type): Likewise.
9121         (aarch64_pseudo_register_reggroup_p): Likewise.
9122         (aarch64_gdbarch_init): Add pauth registers.
9123         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9124         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9125         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9126         (struct gdbarch_tdep): Add regnum for ra_state.
9127
9128 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9129             Jiong Wang  <jiong.wang@arm.com>
9130
9131         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9132
9133 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9134             Jiong Wang  <jiong.wang@arm.com>
9135
9136         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9137         function.
9138         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9139         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9140         (aarch64_gdbarch_init): Add puth registers.
9141         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9142         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9143         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9144
9145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9146             Jiong Wang  <jiong.wang@arm.com>
9147
9148         * aarch64-linux-nat.c
9149         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9150         * aarch64-linux-tdep.c
9151         (aarch64_linux_core_read_description): Likewise.
9152         (aarch64_linux_get_hwcap): New function.
9153         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9154         (aarch64_linux_get_hwcap): New declaration.
9155
9156 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9157             Jiong Wang  <jiong.wang@arm.com>
9158
9159         * aarch64-linux-nat.c
9160         (aarch64_linux_nat_target::read_description): Add pauth param.
9161         * aarch64-linux-tdep.c
9162         (aarch64_linux_core_read_description): Likewise.
9163         * aarch64-tdep.c (struct target_desc): Add in pauth.
9164         (aarch64_read_description): Add pauth param.
9165         (aarch64_gdbarch_init): Likewise.
9166         * aarch64-tdep.h (aarch64_read_description): Likewise.
9167         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9168         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9169         * features/Makefile: Add new files.
9170         * features/aarch64-pauth.c: New file.
9171         * features/aarch64-pauth.xml: New file.
9172
9173 2019-03-20  Tom Tromey  <tromey@adacore.com>
9174
9175         * infrun.c (handle_inferior_event): Rename from
9176         handle_inferior_event_1.  Create a scoped_value_mark.
9177         (handle_inferior_event): Remove.
9178
9179 2019-03-19  Tom Tromey  <tromey@adacore.com>
9180
9181         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9182         * infrun.h (print_stop_event): Add "displays" parameter.
9183         * infrun.c (print_stop_event): Add "displays" parameter.
9184
9185 2019-03-19  Pedro Alves  <palves@redhat.com>
9186
9187         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9188         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9189         to -1.  Fix TABs vs spaces.
9190         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9191         * tui/tui-out.h (tui_ui_out) Add intro comments.
9192         <m_line, m_start_of_line>: In-class initialize, and add describing
9193         comment.
9194
9195 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9196
9197         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9198         variable names.
9199         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9200
9201 2019-03-18  Pedro Alves  <palves@redhat.com>
9202             Eli Zaretskii <eliz@gnu.org>
9203
9204         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9205         m_line and m_start_of_line.
9206
9207 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9208
9209         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9210         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9211         it returns a newline.  This fixes a regression in TU mode, whereby
9212         the next line is output on the same screen line as the user input.
9213
9214 2019-03-18  Tom Tromey  <tromey@adacore.com>
9215
9216         * minsyms.c (minimal_symbol_reader::install): Remove call to
9217         obstack_blank.
9218
9219 2019-03-18  Pedro Alves  <palves@redhat.com>
9220
9221         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9222         New globals.
9223         (apply_style): New, factored out from ...
9224         (apply_ansi_escape): ... this.  Handle reverse video mode.
9225         (tui_set_reverse_mode): New function.
9226         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9227         * tui/tui-winsource.c (tui_show_source_line): Use
9228         tui_set_reverse_mode instead of setting A_STANDOUT.
9229         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9230         New setter methods.
9231
9232 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9233
9234         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9235         Handle tabs.
9236
9237 2019-03-18  Tom Tromey  <tromey@adacore.com>
9238
9239         * ada-lang.c (empty_array): Add "high" parameter.
9240         (ada_evaluate_subexp): Update.
9241
9242 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9243
9244         * unittests/string_view-selftests.c: Define
9245         _initialize_string_view_selftests unconditionally.
9246
9247 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9248
9249         PR gdb/24350
9250         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9251
9252 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9253
9254         PR gdb/24351
9255         * windows-nat.c (display_selector): Fix format specifiers.
9256
9257 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9258
9259         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9260         tui_refill_source_window instead of tui_refresh_win, to update the
9261         current execution line.  This fixes redisplay of the current line
9262         when stepping through the code with "next" or "step".
9263
9264 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9265
9266         * source-cache.c (source_cache::get_source_lines): Call
9267         find_source_lines to initialize s->nlines.  This fixes vertical
9268         scrolling of TUI source window when the DOWN arrow is pressed.
9269
9270 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9271
9272         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9273         linux-thread-db.c (_initialize_thread_db): Likewise.
9274
9275 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9276
9277         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9278         wclrtoeol in tui_show_source_line".  This reverts changes made in
9279         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9280
9281 2019-03-15  Tom Tromey  <tom@tromey.com>
9282
9283         * symtab.h (struct minimal_symbol): Derive from
9284         general_symbol_info.
9285         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9286         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9287         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9288         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9289         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9290         (MSYMBOL_SEARCH_NAME): Update.
9291         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9292         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9293         * minsyms.c (minimal_symbol_reader::record_full): Update.
9294
9295 2019-03-15  Tom Tromey  <tom@tromey.com>
9296
9297         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9298
9299 2019-03-15  Tom Tromey  <tom@tromey.com>
9300
9301         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9302         unique_xmalloc_ptr.
9303         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9304         Update.
9305         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9306         (build_minimal_symbol_hash_tables)
9307         (minimal_symbol_reader::install): Update.
9308
9309 2019-03-15  Tom Tromey  <tom@tromey.com>
9310
9311         * symtab.c (create_demangled_names_hash): Update.
9312         (symbol_set_names): Update.
9313         * objfiles.h (struct objfile_per_bfd_storage)
9314         <demangled_names_hash>: Now an htab_up.
9315         * objfiles.c (objfile_per_bfd_storage): Simplify.
9316
9317 2019-03-15  Tom Tromey  <tom@tromey.com>
9318
9319         * objfiles.h (struct objfile_per_bfd_storage): Declare
9320         destructor.
9321         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9322         New.
9323         (get_objfile_bfd_data): Use new.  Don't initialize
9324         language_of_main.
9325         (free_objfile_per_bfd_storage): Remove.
9326         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9327
9328 2019-03-15  Tom Tromey  <tom@tromey.com>
9329
9330         * symfile.c (reread_symbols): Update.
9331         * objfiles.c (objfile::objfile): Update.
9332         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9333         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9334         comment.
9335         (minimal_symbol_reader::install): Update.
9336         (terminate_minimal_symbol_table): Remove.
9337         * jit.c (jit_object_close_impl): Update.
9338
9339 2019-03-15  Tom Tromey  <tom@tromey.com>
9340
9341         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9342         initializations.
9343
9344 2019-03-15  Tom Tromey  <tom@tromey.com>
9345
9346         * objfiles.h (struct objfile_per_bfd_storage)
9347         <demangled_hash_languages>: Now a bitset.
9348         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9349         (lookup_minimal_symbol): Update.
9350
9351 2019-03-15  Tom Tromey  <tom@tromey.com>
9352
9353         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9354         Don't return the symbol.
9355         * coffread.c (record_minimal_symbol): Use record_full.
9356
9357 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9358
9359         The MS-Windows port of ncurses fails to switch to a color pair if
9360         one or both of the colors are the implicit default colors.  This
9361         change records the default colors when TUI is initialized, and
9362         then specifies them explicitly when a color pair uses the default
9363         colors.  This allows color styling in TUI mode on MS-Windows.
9364
9365         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9366         ncurses_norm_attr.
9367         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9368         colors in ncurses_norm_attr.
9369         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9370         "none", replace it with the default color recorded in
9371         ncurses_norm_attr.
9372
9373 2019-03-14  Tom Tromey  <tromey@adacore.com>
9374
9375         * source-cache.h (class source_cache) <get_source_lines>: Return
9376         std::string.
9377         * source-cache.c (source_cache::extract_lines): Handle case where
9378         first_pos==npos.  Return std::string.
9379         (source_cache::get_source_lines): Update.
9380
9381 2019-03-14  Tom Tromey  <tromey@adacore.com>
9382
9383         * NEWS: Add item for "style sources" commands.
9384         * source-cache.c (source_cache::get_source_lines): Check
9385         source_styling.
9386         * cli/cli-style.c (source_styling): New global.
9387         (_initialize_cli_style): Add "style sources" commands.
9388         (show_style_sources): New function.
9389         * cli/cli-style.h (source_styling): Declare.
9390
9391 2019-03-14  Pedro Alves  <palves@redhat.com>
9392             Tom Tromey  <tromey@adacore.com>
9393
9394         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9395         * tui/tui-winsource.c (tui_refill_source_window): New function,
9396         from...
9397         (tui_horizontal_source_scroll): ... here.  Move some logic.
9398         * cli/cli-style.c (set_style_enabled): Notify new observable.
9399         * tui/tui-hooks.c (tui_redisplay_source): New function.
9400         (tui_attach_detach_observers): Attach or detach
9401         tui_redisplay_source.
9402         * observable.h (source_styling_changed): New observable.
9403         * observable.c: Define source_styling_changed observable.
9404
9405 2019-03-13  Tom Tromey  <tromey@adacore.com>
9406
9407         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9408         (i386_gnu_nat_target::store_registers): Update.
9409         * target-debug.h (target_debug_print_std_string): New macro.
9410         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9411         * windows-tdep.c (display_one_tib): Update.
9412         * tui/tui-stack.c (tui_make_status_line): Update.
9413         * top.c (print_inferior_quit_action): Update.
9414         * thread.c (thr_try_catch_cmd): Update.
9415         (add_thread_with_info): Update.
9416         (thread_target_id_str): Update.
9417         (thr_try_catch_cmd): Update.
9418         (thread_command): Update.
9419         (thread_find_command): Update.
9420         * record-btrace.c (record_btrace_target::info_record)
9421         (record_btrace_resume_thread, record_btrace_target::resume)
9422         (record_btrace_cancel_resume, record_btrace_step_thread)
9423         (record_btrace_target::wait, record_btrace_target::wait)
9424         (record_btrace_target::wait, record_btrace_target::stop): Update.
9425         * progspace.c (print_program_space): Update.
9426         * process-stratum-target.c
9427         (process_stratum_target::thread_address_space): Update.
9428         * linux-fork.c (linux_fork_mourn_inferior)
9429         (detach_checkpoint_command, info_checkpoints_command)
9430         (linux_fork_context): Update.
9431         (linux_fork_detach): Update.
9432         (class scoped_switch_fork_info): Update.
9433         (delete_checkpoint_command): Update.
9434         * infrun.c (follow_fork_inferior): Update.
9435         (follow_fork_inferior): Update.
9436         (proceed_after_vfork_done): Update.
9437         (handle_vfork_child_exec_or_exit): Update.
9438         (follow_exec): Update.
9439         (displaced_step_prepare_throw): Update.
9440         (displaced_step_restore): Update.
9441         (start_step_over): Update.
9442         (resume_1): Update.
9443         (clear_proceed_status_thread): Update.
9444         (proceed): Update.
9445         (print_target_wait_results): Update.
9446         (do_target_wait): Update.
9447         (context_switch): Update.
9448         (stop_all_threads): Update.
9449         (restart_threads): Update.
9450         (finish_step_over): Update.
9451         (handle_signal_stop): Update.
9452         (switch_back_to_stepped_thread): Update.
9453         (keep_going_pass_signal): Update.
9454         (print_exited_reason): Update.
9455         (normal_stop): Update.
9456         * inferior.c (inferior_pid_to_str): Change return type.
9457         (print_selected_inferior): Update.
9458         (add_inferior): Update.
9459         (detach_inferior): Update.
9460         * dummy-frame.c (fprint_dummy_frames): Update.
9461         * dcache.c (dcache_info_1): Update.
9462         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9463         (btrace_fetch, btrace_clear): Update.
9464         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9465         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9466         type.
9467         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9468         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9469         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9470         * gdbarch.c, gdbarch.h: Rebuild.
9471         * gdbarch.sh (core_pid_to_str): Change return type.
9472         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9473         return type.
9474         (windows_nat_target::pid_to_str): Change return type.
9475         (windows_delete_thread): Update.
9476         (windows_nat_target::attach): Update.
9477         (windows_nat_target::files_info): Update.
9478         * target-delegates.c: Rebuild.
9479         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9480         return type.
9481         (sol_thread_target::pid_to_str): Change return type.
9482         * remote.c (class remote_target) <pid_to_str>: Change return
9483         type.
9484         (remote_target::pid_to_str): Change return type.
9485         (extended_remote_target::attach, remote_target::remote_stop_ns)
9486         (remote_target::remote_notif_remove_queued_reply)
9487         (remote_target::push_stop_reply, remote_target::disable_btrace):
9488         Update.
9489         (extended_remote_target::attach): Update.
9490         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9491         type.
9492         (gdbsim_target::pid_to_str): Change return type.
9493         * ravenscar-thread.c (struct ravenscar_thread_target)
9494         <pid_to_str>: Change return type.
9495         (ravenscar_thread_target::pid_to_str): Change return type.
9496         * procfs.c (class procfs_target) <pid_to_str>: Change return
9497         type.
9498         (procfs_target::pid_to_str): Change return type.
9499         (procfs_target::attach): Update.
9500         (procfs_target::detach): Update.
9501         (procfs_target::fetch_registers): Update.
9502         (procfs_target::store_registers): Update.
9503         (procfs_target::wait): Update.
9504         (procfs_target::files_info): Update.
9505         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9506         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9507         return type.
9508         (nto_procfs_target::pid_to_str): Change return type.
9509         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9510         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9511         return type.
9512         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9513         (exit_lwp): Update.
9514         (attach_proc_task_lwp_callback, get_detach_signal)
9515         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9516         (linux_nat_target::resume, wait_lwp, stop_callback)
9517         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9518         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9519         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9520         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9521         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9522         type.
9523         (inf_ptrace_target::attach): Update.
9524         (inf_ptrace_target::files_info): Update.
9525         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9526         type.
9527         (go32_nat_target::pid_to_str): Change return type.
9528         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9529         (gnu_nat_target::wait): Update.
9530         (gnu_nat_target::wait): Update.
9531         (gnu_nat_target::resume): Update.
9532         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9533         (fbsd_nat_target::wait): Update.
9534         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9535         type.
9536         (darwin_nat_target::attach): Update.
9537         * corelow.c (class core_target) <pid_to_str>: Change return type.
9538         (core_target::pid_to_str): Change return type.
9539         * target.c (normal_pid_to_str): Change return type.
9540         (default_pid_to_str): Likewise.
9541         (target_pid_to_str): Change return type.
9542         (target_translate_tls_address): Update.
9543         (target_announce_detach): Update.
9544         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9545         return type.
9546         (bsd_uthread_target::pid_to_str): Change return type.
9547         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9548         type.
9549         (bsd_kvm_target::pid_to_str): Change return type.
9550         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9551         return type.
9552         (aix_thread_target::pid_to_str): Change return type.
9553         * target.h (struct target_ops) <pid_to_str>: Change return type.
9554         (target_pid_to_str, normal_pid_to_str): Likewise.
9555         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9556         type.
9557         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9558         type.
9559         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9560         return type.
9561         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9562         type.
9563         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9564         type.
9565         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9566         return type.
9567
9568 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9569
9570         * NEWS: Mention that the new default MI version is 3.  Mention
9571         changes to the output of commands and events that deal with
9572         multi-location breakpoints.
9573         * breakpoint.c: Include "mi/mi-out.h".
9574         (print_one_breakpoint): Change output syntax if using MI version
9575         >= 3.
9576         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9577         New.
9578         (mi_multi_location_breakpoint_output_fixed): New.
9579         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9580         (mi_cmd_fix_multi_location_breakpoint_output): New.
9581         (mi_multi_location_breakpoint_output_fixed): New.
9582         * mi/mi-cmds.c (mi_cmds): Register command
9583         -fix-multi-location-breakpoint-output.
9584         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9585         interpreter "mi".
9586
9587 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9588
9589         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9590         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9591         instantiate mi_ui_out based on interpreter name.
9592         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9593         * mi/mi-main.c (mi_load_progress): Likewise.
9594
9595 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9596
9597         * NEWS: Combine separate "New targets" sections for 8.3.
9598
9599 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9600
9601         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9602         (ppcfbsd_init_abi): Install gdbarch
9603         "fetch_tls_load_module_address" and "get_thread_local_address"
9604         methods.
9605
9606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9607
9608         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9609         (riscv_fbsd_init_abi): Install gdbarch
9610         "fetch_tls_load_module_address" and "get_thread_local_address"
9611         methods.
9612
9613 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9614
9615         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9616         (i386fbsd_init_abi): Install gdbarch
9617         "fetch_tls_load_module_address" and "get_thread_local_address"
9618         methods.
9619
9620 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9621
9622         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9623         (amd64fbsd_init_abi): Install gdbarch
9624         "fetch_tls_load_module_address" and "get_thread_local_address"
9625         methods.
9626
9627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9628
9629         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9630         (struct fbsd_pspace_data): New type.
9631         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9632         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9633         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9634         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9635         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9636
9637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9638
9639         * gdbtypes.c (lookup_struct_elt): New function.
9640         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9641         * gdbtypes.h (struct struct_elt): New type.
9642         (lookup_struct_elt): New prototype.
9643
9644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9645
9646         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9647         remove disabled code block.
9648
9649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9650
9651         * gdbarch.sh (get_thread_local_address): New method.
9652         * gdbarch.h, gdbarch.c: Regenerate.
9653         * target.c (target_translate_tls_address): Use
9654         gdbarch_get_thread_local_address if present instead of
9655         target::get_thread_local_address.
9656
9657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9658
9659         * target.h (target::get_thread_local_address): Update comment.
9660
9661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9662
9663         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9664         objfile->separate_debug_objfile_backlink if not NULL.
9665
9666 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9667
9668         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9669         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9670         (amd64bsd_store_inferior_registers): Likewise.
9671         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9672         Enable segment base registers.
9673         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9674         PT_GETFSBASE and PT_GETGSBASE.
9675         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9676         PT_SETGSBASE.
9677         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9678         segment base registers.
9679         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9680
9681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9682
9683         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9684         Update calls to i386_target_description to add 'segments'
9685         parameter.
9686         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9687         add segment base registers.
9688         * arch/i386.c (i386_create_target_description): Add 'segments'
9689         parameter to enable segment base registers.
9690         * arch/i386.h (i386_create_target_description): Likewise.
9691         * features/i386/32bit-segments.xml: New file.
9692         * features/i386/32bit-segments.c: Generate.
9693         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9694         call to i386_target_description to add 'segments' parameter.
9695         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9696         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9697         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9698         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9699         if feature is present.
9700         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9701         Add 'segments' parameter to call to i386_target_description.
9702         (i386_target_description): Add 'segments' parameter to enable
9703         segment base registers.
9704         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9705         to call to i386_target_description.
9706         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9707         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9708         Define I386_NUM_REGS.
9709         (i386_target_description): Add 'segments' parameter to enable
9710         segment base registers.
9711
9712 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9713
9714         PR/24325
9715         * source-cache.c: #undef open and close, to avoid unresolved
9716         externals during linking.
9717
9718 2019-03-12  Tom Tromey  <tromey@adacore.com>
9719
9720         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9721         const.  Add initializers.
9722         (_initialize_remote): Don't initialize ptid globals.
9723
9724 2019-03-12  Pedro Alves  <palves@redhat.com>
9725
9726         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9727
9728 2019-03-12  Pedro Alves  <palves@redhat.com>
9729
9730         * cp-name-parser.y (main): Remove unused 'len' variable.
9731
9732 2019-03-12  Tom Tromey  <tromey@adacore.com>
9733
9734         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9735         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9736
9737 2019-03-12  Tom Tromey  <tromey@adacore.com>
9738
9739         * linux-nat.c (iterate_over_lwps): Update.
9740         (stop_callback): Remove parameter.
9741         (stop_wait_callback, detach_callback, resume_set_callback)
9742         (select_singlestep_lwp_callback, set_ignore_sigint)
9743         (status_callback, resumed_callback, resume_clear_callback)
9744         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9745         data parameter.
9746         (linux_nat_target::detach, linux_nat_target::resume)
9747         (linux_stop_and_wait_all_lwps, select_event_lwp)
9748         (linux_nat_filter_event, linux_nat_wait_1)
9749         (linux_nat_target::kill, linux_nat_target::stop)
9750         (linux_nat_target::stop): Update.
9751         (linux_nat_resume_callback): Change type.
9752         (resume_stopped_resumed_lwps, count_events_callback)
9753         (select_event_lwp_callback): Likewise.
9754         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9755         * arm-linux-nat.c (struct update_registers_data): Remove.
9756         (update_registers_callback): Change type.
9757         (arm_linux_insert_hw_breakpoint1): Update.
9758         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9759         parameter.
9760         (x86_linux_dr_set_addr): Update.
9761         (x86_linux_dr_set_control): Update.
9762         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9763         (iterate_over_lwps): Use gdb::function_view.
9764         * nat/aarch64-linux-hw-point.c (struct
9765         aarch64_dr_update_callback_param): Remove.
9766         (debug_reg_change_callback): Change type.
9767         (aarch64_notify_debug_reg_change): Update.
9768         * s390-linux-nat.c (s390_refresh_per_info): Update.
9769
9770 2019-03-11  Tom Tromey  <tromey@adacore.com>
9771
9772         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9773         redundant assignment to "this_cu".
9774
9775 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9776
9777         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9778
9779 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9780
9781         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9782         from...
9783         (rank_one_type): ... this.
9784
9785 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9786
9787         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9788         from...
9789         (rank_one_type): ... this.
9790
9791 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9792
9793         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9794         from...
9795         (rank_one_type): ... this.
9796
9797 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9798
9799         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9800         from...
9801         (rank_one_type): ... this.
9802
9803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9804
9805         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9806         from...
9807         (rank_one_type): ... this.
9808
9809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9810
9811         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9812         from...
9813         (rank_one_type): ... this.
9814
9815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9816
9817         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9818         from...
9819         (rank_one_type): ... this.
9820
9821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9822
9823         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9824         from...
9825         (rank_one_type): ... this.
9826
9827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9828
9829         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9830         from...
9831         (rank_one_type): ... this.
9832
9833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9834
9835         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9836         from...
9837         (rank_one_type): ... this.
9838
9839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9840
9841         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9842         from...
9843         (rank_one_type): ... this.
9844
9845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9846
9847         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9848         from...
9849         (rank_one_type): ... this.
9850
9851 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9852
9853         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9854         inferior-events' shows the example events.
9855
9856 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9857
9858         Support styling on native MS-Windows console
9859
9860         PR/24315
9861         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9862         on MS-Windows if $TERM is not defined.
9863
9864         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9865
9866         * posix-hdep.c (gdb_console_fputs):
9867         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9868         functions.
9869         * ui-file.h (gdb_console_fputs): Add prototype.
9870
9871         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9872         back to fputs only if the former returns zero.
9873
9874 2019-03-07  Tom Tromey  <tom@tromey.com>
9875
9876         * symmisc.c (print_symbol_bcache_statistics): Update.
9877         (print_objfile_statistics): Update.
9878         * symfile.c (allocate_symtab): Update.
9879         * stabsread.c: Don't include bcache.h.
9880         * psymtab.h (struct psymbol_bcache): Don't declare.
9881         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9882         (psymbol_bcache_init, psymbol_bcache_free)
9883         (psymbol_bcache_get_bcache): Don't declare.
9884         * psymtab.c (struct psymbol_bcache): Remove.
9885         (psymtab_storage::psymtab_storage): Update.
9886         (psymtab_storage::~psymtab_storage): Update.
9887         (psymbol_bcache_init, psymbol_bcache_free)
9888         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9889         (add_psymbol_to_bcache): Update.
9890         (allocate_psymtab): Update.
9891         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9892         macro_cache>: No longer pointers.
9893         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9894         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9895         * macrotab.c (macro_bcache): Update.
9896         * macroexp.c: Don't include bcache.h.
9897         * gdbtypes.c (check_types_worklist): Update.
9898         (types_deeply_equal): Remove TRY/CATCH.  Update.
9899         * elfread.c (elf_symtab_read): Update.
9900         * dwarf2read.c: Don't include bcache.h.
9901         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9902         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9903         (print_bcache_statistics, bcache_memory_used): Don't declare.
9904         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9905         methods.  Rename all data members.
9906         * bcache.c (struct bcache): Move to bcache.h.
9907         (bcache::expand_hash_table): Rename from expand_hash_table.
9908         (bcache): Remove.
9909         (bcache::insert): Rename from bcache_full.
9910         (bcache::compare): Rename from bcache_compare.
9911         (bcache_xmalloc): Remove.
9912         (bcache::~bcache): Rename from bcache_xfree.
9913         (bcache::print_statistics): Rename from print_bcache_statistics.
9914         (bcache::memory_used): Rename from bcache_memory_used.
9915
9916 2019-03-07  Pedro Alves  <palves@redhat.com>
9917
9918         * infrun.c (normal_stop): Also check for
9919         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9920
9921 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9922
9923         * f-lang.c (value_from_host_double): Moved to...
9924         * value.c (value_from_host_double): ...here.
9925         * value.h (value_from_host_double): Declare.
9926         * guile/scm-math.c (vlscm_convert_typed_number): Use
9927         value_from_host_double.
9928         (vlscm_convert_number): Likewise.
9929         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9930         * python/py-value.c (convert_value_from_python): Likewise.
9931
9932 2019-03-06  Tom Tromey  <tom@tromey.com>
9933
9934         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9935
9936 2019-03-06  Tom Tromey  <tom@tromey.com>
9937
9938         * utils.h (free_current_contents): Don't declare.
9939         * utils.c (free_current_contents): Remove.
9940
9941 2019-03-06  Tom Tromey  <tom@tromey.com>
9942
9943         * top.c (quit_force): Update.
9944         * main.c (captured_command_loop): Update.
9945         * common/new-op.c (operator new): Update.
9946         * common/common-exceptions.c (struct catcher)
9947         <save_cleanup_chain>: Remove member.
9948         (exceptions_state_mc_init): Update.
9949         (exception_try_scope_entry): Return nullptr.
9950         (exception_try_scope_exit, exception_rethrow)
9951         (throw_exception_sjlj, throw_exception_cxx): Update.
9952         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9953         (all_cleanups, do_cleanups, discard_cleanups)
9954         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9955         (restore_cleanups, restore_final_cleanups): Don't declare.
9956         (do_final_cleanups): Remove parameter.
9957         * common/cleanups.c (cleanup_chain, make_cleanup)
9958         (make_cleanup_dtor, all_cleanups, do_cleanups)
9959         (discard_my_cleanups, discard_cleanups)
9960         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9961         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9962         (null_cleanup): Remove.
9963         (do_final_cleanups): Remove parameter.
9964
9965 2019-03-06  Tom Tromey  <tom@tromey.com>
9966
9967         * remote.c (remote_target::remote_parse_stop_reply): Use
9968         unique_xmalloc_ptr.
9969
9970 2019-03-06  Tom Tromey  <tom@tromey.com>
9971
9972         * stabsread.c (struct stabs_field_info): Rename from field_info.
9973         <list, fnlist>: Add initializers.
9974         <obstack>: New member.
9975         (read_member_functions, read_struct_fields, read_baseclasses):
9976         Allocate on obstack.  Don't use cleanups.
9977         (read_one_struct_field, read_member_functions, read_struct_fields)
9978         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9979         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9980         (read_struct_type): Update.
9981
9982 2019-03-06  Tom Tromey  <tom@tromey.com>
9983
9984         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9985         * common/filestuff.h (make_cleanup_close): Don't declare.
9986         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9987         Remove.
9988
9989 2019-03-06  Tom Tromey  <tom@tromey.com>
9990
9991         * solib-aix.c: Use make_scope_exit.
9992
9993 2019-03-06  Tom Tromey  <tom@tromey.com>
9994
9995         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9996         Use make_scope_exit.
9997
9998 2019-03-06  Tom Tromey  <tom@tromey.com>
9999
10000         * solib-svr4.c (disable_probes_interface): Remove parameter.
10001         (svr4_handle_solib_event): Use make_scope_exit.
10002
10003 2019-03-06  Tom Tromey  <tom@tromey.com>
10004
10005         * remote.c (struct stop_reply_deleter): Remove.
10006         (stop_reply_up): Update.
10007         (struct stop_reply): Derive from notif_event.  Don't typedef.
10008         <regcache>: Now a std::vector.
10009         (stop_reply_xfree): Remove.
10010         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10011         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10012         (remote_target::discard_pending_stop_replies): Use delete.
10013         (remote_target::remote_parse_stop_reply): Update.
10014         (remote_target::process_stop_reply): Update.
10015         * remote-notif.h (struct notif_event): Add virtual destructor.
10016         Remove "dtr" member.
10017         (struct notif_client) <alloc_event>: Return a unique_ptr.
10018         (notif_event_xfree): Don't declare.
10019         (notif_event_up): New typedef.
10020         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10021         (notif_event_xfree, do_notif_event_xfree): Remove.
10022         (remote_notif_state_xfree): Update.
10023
10024 2019-03-06  Tom Tromey  <tom@tromey.com>
10025
10026         * infrun.c (displaced_step_clear_cleanup): Now a
10027         forward_scope_exit type.
10028         (displaced_step_prepare_throw): Update.
10029         (displaced_step_fixup): Update.
10030
10031 2019-03-06  Tom Tromey  <tom@tromey.com>
10032
10033         * inferior.h (class inferior): Update comment.
10034         * gdbthread.h (class thread_info): Update comment.
10035
10036 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10037             Tom Tromey  <tom@tromey.com>
10038
10039         * stabsread.h (struct stab_section_list): Remove.
10040         (coffstab_build_psymtabs): Update.
10041         * dbxread.c (symbuf_sections): Now a std::vector.
10042         (sect_idx): New global.
10043         (fill_symbuf): Update.
10044         (coffstab_build_psymtabs): Change type of stabsects parameter.
10045         Update.
10046         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10047         std::vector.
10048         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10049         (coff_locate_sections): Update.
10050         (coff_symfile_read): Remove cleanups.  Update.
10051         (init_stringtab): Add storage parameter.
10052         (free_stringtab, free_stringtab_cleanup): Remove.
10053         (init_lineno): Add storage parameter.
10054         (free_linetab, free_linetab_cleanup): Remove.
10055
10056 2019-03-06  Pedro Alves  <palves@redhat.com>
10057
10058         * linux-fork.c (fork_info::clobber_regs): Delete.
10059         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10060         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10061         comment.  Adjust.
10062         (scoped_switch_fork_info::scoped_switch_fork_info)
10063         (checkpoint_command, linux_fork_context): Adjust
10064         fork_save_infrun_state calls.
10065
10066 2019-03-06  Pedro Alves  <palves@redhat.com>
10067
10068         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10069         (inf_has_multiple_threads): Return 'bool' and rewrite using
10070         inferior_info::threads().
10071
10072 2019-03-06  Pedro Alves  <palves@redhat.com>
10073
10074         * linux-fork.c: Include <list>.
10075         (fork_list): Now a std::list instance.
10076         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10077         (forks_exist_p, find_last_fork): Adjust.
10078         (new_fork): Delete.
10079         (one_fork_p): New.
10080         (add_fork): Adjust.
10081         (free_fork): Delete, folded into fork_info::~fork_info().
10082         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10083         Adjust.
10084         (init_fork_list): Delete.
10085         (linux_fork_killall, linux_fork_mourn_inferior)
10086         (linux_fork_detach, info_checkpoints_command): Adjust.
10087         (_initialize_linux_fork): No longer call init_fork_list.
10088
10089 2019-03-06  Pedro Alves  <palves@redhat.com>
10090
10091         * linux-fork.c (new_fork): New, split out of ...
10092         (add_fork): ... this.  Return void.  Move "first fork" special
10093         case from here, to ...
10094         (checkpoint_command): ... here.
10095         * linux-linux.h (add_fork): Return void.
10096
10097 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10098
10099         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10100
10101 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10102             Chris January  <chris.january@arm.com>
10103             David Lecomber  <david.lecomber@arm.com>
10104
10105         * f-exp.y: New token, UNOP_INTRINSIC.
10106         (exp): New pattern using UNOP_INTRINSIC token.
10107         (f77_keywords): Add 'abs' keyword.
10108         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10109         (value_from_host_double): New function.
10110         (evaluate_subexp_f): Support UNOP_ABS.
10111
10112 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10113
10114         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10115         types.
10116
10117 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10118
10119         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10120         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10121         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10122
10123 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10124
10125         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10126
10127 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10128             Chris January  <chris.january@arm.com>
10129
10130         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10131         * f-exp.y: Define 'KIND' token.
10132         (exp): New pattern for KIND expressions.
10133         (ptype): Handle types with a kind extension.
10134         (direct_abs_decl): Extend to spot kind extensions.
10135         (f77_keywords): Add 'kind' to the list.
10136         (push_kind_type): New function.
10137         (convert_to_kind_type): New function.
10138         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10139         * parse.c (operator_length_standard): Likewise.
10140         * parser-defs.h (enum type_pieces): Add tp_kind.
10141         * std-operator.def: Add UNOP_KIND.
10142
10143 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10144
10145         * f-exp.y (f_parse): Set yydebug.
10146
10147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10148
10149         * f-lang.c (evaluate_subexp_f): New function.
10150         (exp_descriptor_f): New global.
10151         (f_language_defn): Use exp_descriptor_f instead of
10152         exp_descriptor_standard.
10153
10154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10155
10156         * f-exp.y (struct token): Add comments.
10157         (dot_ops): Remove uppercase versions and the end marker.
10158         (f77_keywords): Likewise.
10159         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10160         entries in the dot_ops array are case insensitive, and use
10161         strncasecmp to compare strings.  Also some whitespace cleanup in
10162         this area.  Similar for the f77_keywords array, except entries in
10163         this list might be case sensitive.
10164
10165 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10166
10167         * f-exp.y (struct f77_boolean_val): Add comments.
10168         (boolean_values): Remove uppercase versions, and end marker.
10169         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10170         and use strncasecmp to achieve case insensitivity.  Additionally,
10171         perform whitespace cleanup around this code.
10172
10173 2019-03-06  Tom Tromey  <tromey@adacore.com>
10174
10175         * remote-sim.c (gdbsim_target_open): Use result of
10176         gdb_argv::release.
10177
10178 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10179         Dirk Schubert  <dirk.schubert@arm.com>
10180         Chris January  <chris.january@arm.com>
10181
10182         * eval.c (evaluate_subexp_standard): Call Fortran argument
10183         wrapping logic.
10184         * f-lang.c (struct value): A value which can be passed into a
10185         Fortran function call.
10186         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10187         where appropriate.
10188         (struct type): Value ready for a Fortran function call.
10189         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10190         is needed.
10191         * f-lang.h (fortran_argument_convert): Declaration.
10192         (fortran_preserve_arg_pointer): Declaration.
10193         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10194
10195 2019-03-05  Tom Tromey  <tromey@adacore.com>
10196
10197         * python/py-prettyprint.c (print_string_repr): Remove #if.
10198         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10199
10200 2019-03-05  Tom Tromey  <tromey@adacore.com>
10201
10202         * target.c (the_dummy_target): Move later.  Change type to
10203         "dummy_target".
10204         (initialize_targets): Don't initialize the_dummy_target.
10205
10206 2019-03-05  Tom Tromey  <tromey@adacore.com>
10207
10208         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10209         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10210
10211 2019-03-05  Tom Tromey  <tromey@adacore.com>
10212
10213         * windows-nat.c (windows_nat_target::attach)
10214         (windows_nat_target::detach): Don't call gdb_flush.
10215         * valprint.c (generic_val_print, val_print, val_print_string):
10216         Don't call gdb_flush.
10217         * utils.c (defaulted_query): Don't call gdb_flush.
10218         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10219         * target.c (target_announce_detach): Don't call gdb_flush.
10220         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10221         * remote.c (extended_remote_target::attach): Don't call
10222         gdb_flush.
10223         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10224         * printcmd.c (do_examine): Don't call gdb_flush.
10225         (info_display_command): Don't call gdb_flush.
10226         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10227         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10228         * memattr.c (info_mem_command): Don't call gdb_flush.
10229         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10230         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10231         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10232         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10233         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10234         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10235         (gnu_nat_target::detach): Don't call gdb_flush.
10236         * f-valprint.c (f_val_print): Don't call gdb_flush.
10237         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10238         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10239         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10240         gdb_flush.
10241         * c-valprint.c (c_val_print): Don't call gdb_flush.
10242         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10243
10244 2019-03-05  Tom Tromey  <tromey@adacore.com>
10245
10246         * varobj.c (update_dynamic_varobj_children): Update.
10247         (install_default_visualizer): Use reset, not release.
10248         * value.c (set_internalvar): Update.
10249         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10250         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10251         ATTRIBUTE_UNUSED_RESULT.
10252
10253 2019-03-05  Tom Tromey  <tromey@adacore.com>
10254
10255         * remote.c (class scoped_remote_fd) <release>: Add
10256         ATTRIBUTE_UNUSED_RESULT.
10257
10258 2019-03-05  Tom Tromey  <tromey@adacore.com>
10259
10260         * macroexp.c (struct macro_buffer) <release>: Add
10261         ATTRIBUTE_UNUSED_RESULT.
10262
10263 2019-03-05  Tom Tromey  <tromey@adacore.com>
10264
10265         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10266         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10267         ATTRIBUTE_UNUSED_RESULT.
10268
10269 2019-03-05  Tom Tromey  <tromey@adacore.com>
10270
10271         * common/scoped_fd.h (class scoped_fd) <release>: Add
10272         ATTRIBUTE_UNUSED_RESULT.
10273
10274 2019-03-05  Tom Tromey  <tromey@adacore.com>
10275
10276         * parser-defs.h (struct parser_state) <release>: Add
10277         ATTRIBUTE_UNUSED_RESULT.
10278
10279 2019-03-05  Tom Tromey  <tromey@adacore.com>
10280
10281         * utils.h (class gdb_argv) <release>: Add
10282         ATTRIBUTE_UNUSED_RESULT.
10283         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10284
10285 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10286
10287         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10288         for-loop range, to avoid compiler warnings.
10289
10290         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10291         avoid compiler warnings about unused variables.
10292
10293         * NEWS: Mention end of support for native debugging on MS-Windows
10294         before XP.
10295
10296         PR gdb/24292
10297         * common/netstuff.c:
10298         * gdbserver/gdbreplay.c
10299         * gdbserver/remote-utils.c:
10300         * ser-tcp.c:
10301         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10302         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10303         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10304         'getaddrinfo' and 'freeaddrinfo' were not available before
10305         Windows XP, and mingw.org's MinGW headers by default define
10306         _WIN32_WINNT to 0x500.
10307
10308 2019-03-01  Gary Benson <gbenson@redhat.com>
10309
10310         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10311
10312 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10313             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10314
10315         PR gdb/8527
10316         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10317         set_sigint_trap, clear_sigint_trap.
10318
10319 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10320
10321         * target.c (target_detach): Clear the regcache and the
10322         frame cache.
10323
10324 2019-02-27  Pedro Alves  <palves@redhat.com>
10325
10326         * utils.c (set_screen_size): When we cap the height/width sizes,
10327         tweak the corresponding command variable to show "unlimited":
10328
10329 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10330             Pedro Alves  <palves@redhat.com>
10331
10332         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10333         before calling rl_set_screen_size.
10334
10335 2019-02-27  Tom Tromey  <tromey@adacore.com>
10336
10337         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10338         define.
10339         * python/py-value.c: Remove Python 2.4 workaround.
10340         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10341         workaround.
10342         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10343         Python 2.4 workaround.
10344         * python/python-internal.h: Remove Python 2.4 comment.
10345         (Py_ssize_t): Don't define.
10346         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10347         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10348         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10349         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10350         * python/python.c (do_start_initialization): Remove Python 2.4
10351         workaround.
10352         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10353         (print_children): Remove Python 2.4 workaround.
10354         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10355         workaround.
10356         (CHARBUFFERPROC_NAME): Remove.
10357         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10358         Python 2.4 workaround.
10359
10360 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10361
10362         * NEWS: Note minimum Python version.
10363
10364 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10365
10366         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10367         code from these functions.  Remove corresponding ifdefs.  Use
10368         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10369         Remove gotos and target of gotos.
10370         (infpy_search_memory): Likewise.
10371
10372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10373
10374         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10375         (hppa_gdbarch_init): Don't register deleted functions with
10376         gdbarch.
10377
10378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10381         (h8300_unwind_sp): Delete.
10382         (h8300_dummy_id): Delete.
10383         (h8300_gdbarch_init): Don't register deleted functions with
10384         gdbarch.
10385
10386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10387
10388         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10389         (ft32_unwind_pc): Delete.
10390         (ft32_unwind_sp): Delete.
10391         (ft32_gdbarch_init): Don't register deleted functions with
10392         gdbarch.
10393
10394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10395
10396         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10397         (frv_unwind_pc): Delete.
10398         (frv_unwind_sp): Delete.
10399         (frv_gdbarch_init): Don't register deleted functions with
10400         gdbarch.
10401
10402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10403
10404         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10405         (riscv_unwind_pc): Delete.
10406         (riscv_unwind_sp): Delete.
10407         (riscv_gdbarch_init): Don't register deleted functions with
10408         gdbarch.
10409
10410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10411
10412         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10413         (csky_unwind_pc): Delete.
10414         (csky_unwind_sp): Delete.
10415         (csky_gdbarch_init): Don't register deleted functions with
10416         gdbarch.
10417
10418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10419
10420         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10421         (cris_unwind_pc): Delete.
10422         (cris_unwind_sp): Delete.
10423         (cris_gdbarch_init): Don't register deleted functions with
10424         gdbarch.
10425
10426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10427
10428         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10429         (bfin_unwind_pc): Delete.
10430         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10431
10432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10433
10434         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10435         (arm_unwind_pc): Delete.
10436         (arm_unwind_sp): Delete.
10437         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10438
10439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10440
10441         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10442         (arc_unwind_pc): Delete.
10443         (arc_unwind_sp): Delete.
10444         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10445
10446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10447
10448         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10449         (alpha_unwind_pc): Delete.
10450         (alpha_gdbarch_init): Don't register deleted functions with
10451         gdbarch.
10452
10453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10454
10455         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10456         (aarch64_unwind_pc): Delete.
10457         (aarch64_unwind_sp): Delete.
10458         (aarch64_gdbarch_init): Don't register deleted functions with
10459         gdbarch.
10460
10461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10462
10463         * gdbtypes.c (type_align): Don't consider static members when
10464         computing structure alignment.
10465
10466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10467
10468         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10469         return 0 for other types.
10470         * arch-utils.c (default_type_align): Always return 0.
10471         * gdbarch.h: Regenerate.
10472         * gdbarch.sh (type_align): Extend comment.
10473         * gdbtypes.c (type_align): Add additional comments, always call
10474         gdbarch_type_align before applying the default rules.
10475         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10476         generic code will then apply a suitable default.
10477         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10478         types, return 0 for other types.
10479
10480 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10481
10482         * NEWS: Create a new section for the next release branch.
10483         Rename the section of the current branch, now that it has
10484         been cut.
10485
10486 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10487
10488         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10489         * version.in: Bump version to 8.3.50.DATE-git.
10490
10491 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10492
10493         * aix-thread.c (ptid_cmp): Remove unused variable.
10494         (get_signaled_thread): Likewise.
10495         (store_regs_user_thread): Likewise.
10496         (store_regs_kernel_thread): Likewise.
10497         (fetch_regs_kernel_thread): Remove shadowed variable.
10498
10499 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10500
10501         * features/riscv/32bit-cpu.xml: Add register numbers.
10502         * features/riscv/32bit-fpu.c: Regenerate.
10503         * features/riscv/32bit-fpu.xml: Add register numbers.
10504         * features/riscv/64bit-cpu.xml: Add register numbers.
10505         * features/riscv/64bit-fpu.c: Regenerate.
10506         * features/riscv/64bit-fpu.xml: Add register numbers.
10507
10508 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10509
10510         * NEWS: Mention two argument form of gdb.Value constructor.
10511         * python/py-value.c (convert_buffer_and_type_to_value): New
10512         function.
10513         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10514         Add support for handling an optional second argument.  Call
10515         convert_buffer_and_type_to_value as appropriate.
10516         * python/python-internal.h (Py_buffer_deleter): New struct.
10517         (Py_buffer_up): New typedef.
10518
10519 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10520
10521         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10522         instead of releasing ownership.
10523
10524 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10525
10526         * dwarf2read.c (open_and_init_dwp_file): Call
10527         elf_numsections instead of bfd_count_sections to initialize
10528         dwp_file->num_sections.
10529
10530 2019-02-25  Tom Tromey  <tromey@adacore.com>
10531
10532         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10533
10534 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10535
10536         * gcore.in: Add '--readnever' option when invoking GDB.
10537
10538 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10539
10540         * MAINTAINERS: Update my email address.
10541
10542 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10543
10544         * build-id.c (build_id_to_debug_bfd_1): New function.
10545         (build_id_to_debug_bfd): Look for separate debug file in
10546         sysroot.
10547
10548 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10549
10550         * gdbarch.sh: Update the copyright year range that is placed into
10551         generated files.
10552
10553 2019-02-22  Keith Seitz  <keiths@redhat.com>
10554
10555         PR symtab/23853
10556         * linespec.c (create_sals_line_offset): Search for the default
10557         symtab's filename instead of its fullname.
10558
10559 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10560
10561         * NEWS: Update style defaults.
10562
10563 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10564
10565         * main.c (captured_main_1): Disable styling in batch mode.
10566
10567 2019-02-20  Tom Tromey  <tom@tromey.com>
10568
10569         * symtab.c (symtab_symbol_info): Fix typos.
10570
10571 2019-02-20  Tom Tromey  <tromey@adacore.com>
10572
10573         * findcmd.c (_initialize_mem_search): Use upper case for
10574         metasyntactic variables.
10575
10576 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10577
10578         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10579         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10580
10581 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10582
10583         * top.h (source_file_name): Change to std::string.
10584         * top.c (source_file_name): Likewise.
10585         (command_line_input): Adjust.
10586         * cli/cli-script.c (script_from_file): Adjust.
10587
10588 2019-02-19  Tom Tromey  <tromey@adacore.com>
10589
10590         * ravenscar-thread.c
10591         (ravenscar_thread_target::update_thread_list): Don't call
10592         ada_build_task_list.
10593         * ada-lang.h (ada_build_task_list): Don't declare.
10594         * ada-tasks.c (struct ada_tasks_inferior_data)
10595         <task_list_valid_p>: Now bool.
10596         (read_known_tasks, ada_task_list_changed)
10597         (ada_tasks_invalidate_inferior_data): Update.
10598         (read_known_tasks_array): Return bool.
10599         (read_known_tasks_list): Likewise.
10600         (read_known_tasks): Return void.
10601         (ada_build_task_list): Now static.
10602
10603 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10604
10605         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10606         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10607
10608 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10609
10610         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10611         variant for ada_tasks_pspace_data_handle and
10612         ada_tasks_inferior_data_handle.
10613         (ada_tasks_pspace_data_cleanup): New function.
10614         (ada_tasks_inferior_data_cleanup): New function.
10615
10616 2019-02-17  Tom Tromey  <tom@tromey.com>
10617
10618         * macrotab.h (macro_source_fullname): Return a std::string.
10619         * macrotab.c (macro_include, check_for_redefinition)
10620         (macro_undef, macro_lookup_definition, foreach_macro)
10621         (foreach_macro_in_scope): Update.
10622         (macro_source_fullname): Return a std::string.
10623         * macrocmd.c (show_pp_source_pos): Update.
10624
10625 2019-02-17  Tom Tromey  <tom@tromey.com>
10626
10627         * macrocmd.c (show_pp_source_pos): Style the file names.
10628
10629 2019-02-17  Tom Tromey  <tom@tromey.com>
10630
10631         PR tui/24197:
10632         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10633
10634 2019-02-17  Tom Tromey  <tom@tromey.com>
10635
10636         * ada-lang.c (user_select_syms): Use filtered printing.
10637         * utils.c (wrap_style): New global.
10638         (desired_style): Remove.
10639         (emit_style_escape): Add stream parameter.
10640         (set_output_style, reset_terminal_style, prompt_for_continue):
10641         Update.
10642         (flush_wrap_buffer): Only flush gdb_stdout.
10643         (wrap_here): Set wrap_style.
10644         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10645         treat escape sequences as a character.  Change when wrap buffer is
10646         flushed.
10647         (fputs_styled): Do not set the output style when the default is
10648         requested.
10649         * ui-style.h (struct ui_file_style) <is_default>: New method.
10650         * source.c (print_source_lines_base): Emit escape sequences in one
10651         piece.
10652
10653 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10654
10655         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10656         integers and enumeration types.
10657
10658 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10659
10660         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10661         instead of lookup_symbol_in_language
10662         (do_exact_match): New function.
10663         (ada_get_symbol_name_matcher): Return do_exact_match when
10664         doing a verbatim match.
10665
10666 2019-02-15  Tom Tromey  <tromey@adacore.com>
10667
10668         * ravenscar-thread.c (ravenscar_thread_target::resume)
10669         (ravenscar_thread_target::wait): Special case wildcard requests.
10670
10671 2019-02-15  Tom Tromey  <tromey@adacore.com>
10672
10673         * ravenscar-thread.c (base_ptid): Remove.
10674         (struct ravenscar_thread_target) <close>: New method.
10675         <m_base_ptid>: New member.
10676         <update_inferior_ptid, active_task, task_is_currently_active,
10677         runtime_initialized>: Declare methods.
10678         <ravenscar_thread_target>: Add constructor.
10679         (ravenscar_thread_target::task_is_currently_active)
10680         (ravenscar_thread_target::update_inferior_ptid)
10681         (ravenscar_runtime_initialized): Rename.  Now methods.
10682         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10683         (ravenscar_thread_target::update_thread_list): Update.
10684         (ravenscar_thread_target::active_task): Now method.
10685         (ravenscar_thread_target::store_registers)
10686         (ravenscar_thread_target::prepare_to_store)
10687         (ravenscar_thread_target::prepare_to_store)
10688         (ravenscar_thread_target::mourn_inferior): Update.
10689         (ravenscar_inferior_created): Use "new" to create target.
10690         (ravenscar_thread_target::get_ada_task_ptid): Update.
10691         (_initialize_ravenscar): Don't initialize base_ptid.
10692         (ravenscar_ops): Remove global.
10693
10694 2019-02-15  Tom Tromey  <tromey@adacore.com>
10695
10696         * target.h (push_target): Declare new overload.
10697         * target.c (push_target): New overload, taking an rvalue reference.
10698         * remote.c (remote_target::open_1): Use push_target overload.
10699         * corelow.c (core_target_open): Use push_target overload.
10700
10701 2019-02-15  Tom Tromey  <tromey@adacore.com>
10702
10703         * ravenscar-thread.c (is_ravenscar_task)
10704         (ravenscar_task_is_currently_active): Return bool.
10705         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10706         (_initialize_ravenscar): Remove "(void)".
10707         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10708         Return bool.
10709
10710 2019-02-15  Tom Tromey  <tromey@adacore.com>
10711
10712         * ravenscar-thread.c (ravenscar_runtime_initializer)
10713         (has_ravenscar_runtime, get_running_thread_id)
10714         (ravenscar_thread_target::resume): Fix indentation.
10715
10716 2019-02-15  Tom Tromey  <tromey@adacore.com>
10717
10718         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10719         from ravenscar_arch_ops.
10720         (sparc_ravenscar_ops::fetch_registers)
10721         (sparc_ravenscar_ops::store_registers): Now methods.
10722         (sparc_ravenscar_prepare_to_store): Remove.
10723         (sparc_ravenscar_ops): Redefine.
10724         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10725         methods and destructor.  Remove members.
10726         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10727         (ravenscar_thread_target::store_registers)
10728         (ravenscar_thread_target::prepare_to_store): Update.
10729         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10730         Remove.
10731         (struct ppc_ravenscar_powerpc_ops): Derive from
10732         ravenscar_arch_ops.
10733         (ppc_ravenscar_powerpc_ops::fetch_registers)
10734         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10735         (ppc_ravenscar_powerpc_ops): Redefine.
10736         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10737         (ppc_ravenscar_e500_ops::fetch_registers)
10738         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10739         (ppc_ravenscar_e500_ops): Redefine.
10740         * aarch64-ravenscar-thread.c
10741         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10742         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10743         (aarch64_ravenscar_fetch_registers)
10744         (aarch64_ravenscar_store_registers): Now methods.
10745         (aarch64_ravenscar_ops): Redefine.
10746
10747 2019-02-15  Tom Tromey  <tromey@adacore.com>
10748
10749         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10750         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10751         (ravenscar_thread_target::stopped_by_watchpoint)
10752         (ravenscar_thread_target::stopped_data_address)
10753         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10754
10755 2019-02-15  Tom Tromey  <tromey@adacore.com>
10756
10757         * ravenscar-thread.c: Fix some typos.
10758
10759 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10760             Tom Tromey  <tromey@adacore.com>
10761
10762         * ada-lang.c (ada_exception_sal): Change addr_string to a
10763         std::string.
10764         (create_ada_exception_catchpoint): Update.
10765
10766 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10767             Tom Tromey  <tromey@adacore.com>
10768
10769         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10770         (bp_location_ops): Remove.
10771         (base_breakpoint_allocate_location): Update.
10772         (free_bp_location): Update.
10773         * ada-lang.c (class ada_catchpoint_location)
10774         <ada_catchpoint_location>: Remove ops parameter.
10775         (ada_catchpoint_location_dtor): Remove.
10776         (ada_catchpoint_location_ops): Remove.
10777         (allocate_location_exception): Update.
10778         * breakpoint.h (struct bp_location_ops): Remove.
10779         (class bp_location) <bp_location>: Remove bp_location_ops
10780         parameter.
10781         <~bp_location>: Add destructor.
10782         <ops>: Remove.
10783
10784 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10785             Pedro Alves  <palves@redhat.com>
10786
10787         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10788         'PATH_MAX'.
10789
10790 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10791             Samuel Thibault  <samuel.thibault@gnu.org>
10792             Thomas Schwinge  <thomas@codesourcery.com>
10793
10794         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10795         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10796
10797 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10798
10799         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10800         (check_empty): Use "const char *".
10801
10802         * gnu-nat.c (gnu_nat_target::detach): Instead of
10803         'detach_inferior (pid)' call
10804         'detach_inferior (find_inferior_pid (pid))'.
10805
10806         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10807         'nat/fork-inferior.o'.
10808         * gnu-nat.c: #include "nat/fork-inferior.h".
10809
10810         * gnu-nat.c (gnu_nat_target::detach): Instead of
10811         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10812         * gnu-nat.h: #include "inf-child.h".
10813         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10814         'i386_gnu_nat_target::fetch_registers'.
10815         (gnu_store_registers): Rename/move to
10816         'i386_gnu_nat_target::store_registers'.
10817
10818         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10819         * gnu-nat.h (mach_thread_info): New function.
10820         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10821
10822         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10823
10824 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10825
10826         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10827
10828 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10829
10830         * windows-nat.c (windows_add_thread): Add new parameter
10831         "main_thread_p" with default value set to false.  Update
10832         function documentation as well as all callers.
10833         (windows_delete_thread): Likewise.
10834         (fake_create_process): Update call to windows_add_thread.
10835         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10836         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10837         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10838         call to windows_delete_thread.
10839
10840 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10841
10842         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10843
10844 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10845
10846         * symfile.c (find_separate_debug_file): Use canonical path of
10847         sysroot with child_path instead of gdb_sysroot if it is valid.
10848
10849 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10850
10851         * symfile.c (find_separate_debug_file): Use child_path to
10852         determine if an object file is under a sysroot.
10853
10854 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10855
10856         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10857         unittests/child-path-selftests.c.
10858         * common/pathstuff.c (child_path): New function.
10859         * common/pathstuff.h (child_path): New prototype.
10860         * unittests/child-path-selftests.c: New file.
10861
10862 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10863
10864         * symfile.c (find_separate_debug_file): Look for separate debug
10865         files in debug directories under the sysroot.
10866
10867 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10868
10869         * symtab.h (struct minimal_symbol data_p): New const method.
10870         (struct minimal_symbol text_p): Likewise.
10871         * symtab.c (output_source_filename): Use file name style
10872         to print file name.
10873         (print_symbol_info): Likewise.
10874         (print_msymbol_info): Use address style to print addresses.
10875         Use function name style to print executable text symbols.
10876         (expand_symtab_containing_pc): Use data_p.
10877         (find_pc_sect_compunit_symtab): Likewise.
10878
10879 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10880
10881         * breakpoint.c (describe_other_breakpoints): Use address style
10882         to print addresses.
10883         (say_where): Likewise.
10884
10885 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10886
10887         * ada-typeprint.c (print_func_type): Print function name
10888         style to print function name.
10889         * c-typeprint.c (c_print_type_1): Likewise.
10890
10891 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10892
10893         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10894         for execve.
10895
10896 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10897
10898         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10899         type_stack.
10900
10901 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10902
10903         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10904         TYPE_CODE_REF types.
10905
10906 2019-02-08  Jim Wilson  <jimw@sifive.com>
10907
10908         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10909         (riscv_linux_fregset): New.
10910         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10911
10912 2019-02-07  Tom Tromey  <tom@tromey.com>
10913
10914         * thread.c (thread_cancel_execution_command): Update.
10915         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10916         methods.
10917         (struct thread_fsm_ops): Remove.
10918         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10919         (thread_fsm_should_stop, thread_fsm_return_value)
10920         (thread_fsm_set_finished, thread_fsm_finished_p)
10921         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10922         Don't declare.
10923         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10924         * infrun.c (clear_proceed_status_thread)
10925         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10926         (print_stop_event): Update.
10927         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10928         Add constructor.
10929         (step_command_fsm_ops): Remove.
10930         (new_step_command_fsm): Remove.
10931         (step_1): Update.
10932         (step_command_fsm::should_stop): Rename from
10933         step_command_fsm_should_stop.
10934         (step_command_fsm::clean_up): Rename from
10935         step_command_fsm_clean_up.
10936         (step_command_fsm::do_async_reply_reason): Rename from
10937         step_command_fsm_async_reply_reason.
10938         (struct until_next_fsm): Inherit from thread_fsm.  Add
10939         constructor.
10940         (until_next_fsm_ops): Remove.
10941         (new_until_next_fsm): Remove.
10942         (until_next_fsm::should_stop): Rename from
10943         until_next_fsm_should_stop.
10944         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10945         (until_next_fsm::do_async_reply_reason): Rename from
10946         until_next_fsm_async_reply_reason.
10947         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10948         constructor.  Change type of breakpoint.
10949         (finish_command_fsm_ops): Remove.
10950         (new_finish_command_fsm): Remove.
10951         (finish_command_fsm::should_stop): Rename from
10952         finish_command_fsm_should_stop.
10953         (finish_command_fsm::clean_up): Rename from
10954         finish_command_fsm_clean_up.
10955         (finish_command_fsm::return_value): Rename from
10956         finish_command_fsm_return_value.
10957         (finish_command_fsm::do_async_reply_reason): Rename from
10958         finish_command_fsm_async_reply_reason.
10959         (finish_command): Update.
10960         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10961         Add constructor.
10962         (call_thread_fsm_ops): Remove.
10963         (call_thread_fsm::call_thread_fsm): Rename from
10964         new_call_thread_fsm.
10965         (call_thread_fsm::should_stop): Rename from
10966         call_thread_fsm_should_stop.
10967         (call_thread_fsm::should_notify_stop): Rename from
10968         call_thread_fsm_should_notify_stop.
10969         (run_inferior_call, call_function_by_hand_dummy): Update.
10970         * cli/cli-interp.c (should_print_stop_to_console): Update.
10971         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10972         Add constructor.  Change type of location_breakpoint,
10973         caller_breakpoint.
10974         (until_break_fsm_ops): Remove.
10975         (new_until_break_fsm): Remove.
10976         (until_break_fsm::should_stop): Rename from
10977         until_break_fsm_should_stop.
10978         (until_break_fsm::clean_up): Rename from
10979         until_break_fsm_clean_up.
10980         (until_break_fsm::do_async_reply_reason): Rename from
10981         until_break_fsm_async_reply_reason.
10982         (until_break_command): Update.
10983         * thread-fsm.c: Remove.
10984         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10985
10986 2019-02-07  Tom Tromey  <tom@tromey.com>
10987
10988         * yy-remap.h: Add include guard.
10989         * xtensa-tdep.h: Add include guard.
10990         * xcoffread.h: Rename include guard.
10991         * varobj-iter.h: Add include guard.
10992         * tui/tui.h: Rename include guard.
10993         * tui/tui-winsource.h: Rename include guard.
10994         * tui/tui-wingeneral.h: Rename include guard.
10995         * tui/tui-windata.h: Rename include guard.
10996         * tui/tui-win.h: Rename include guard.
10997         * tui/tui-stack.h: Rename include guard.
10998         * tui/tui-source.h: Rename include guard.
10999         * tui/tui-regs.h: Rename include guard.
11000         * tui/tui-out.h: Rename include guard.
11001         * tui/tui-layout.h: Rename include guard.
11002         * tui/tui-io.h: Rename include guard.
11003         * tui/tui-hooks.h: Rename include guard.
11004         * tui/tui-file.h: Rename include guard.
11005         * tui/tui-disasm.h: Rename include guard.
11006         * tui/tui-data.h: Rename include guard.
11007         * tui/tui-command.h: Rename include guard.
11008         * tic6x-tdep.h: Add include guard.
11009         * target/waitstatus.h: Rename include guard.
11010         * target/wait.h: Rename include guard.
11011         * target/target.h: Rename include guard.
11012         * target/resume.h: Rename include guard.
11013         * target-float.h: Rename include guard.
11014         * stabsread.h: Add include guard.
11015         * rs6000-tdep.h: Add include guard.
11016         * riscv-fbsd-tdep.h: Add include guard.
11017         * regformats/regdef.h: Rename include guard.
11018         * record.h: Rename include guard.
11019         * python/python.h: Rename include guard.
11020         * python/python-internal.h: Rename include guard.
11021         * python/py-stopevent.h: Rename include guard.
11022         * python/py-ref.h: Rename include guard.
11023         * python/py-record.h: Rename include guard.
11024         * python/py-record-full.h: Rename include guard.
11025         * python/py-record-btrace.h: Rename include guard.
11026         * python/py-instruction.h: Rename include guard.
11027         * python/py-events.h: Rename include guard.
11028         * python/py-event.h: Rename include guard.
11029         * procfs.h: Add include guard.
11030         * proc-utils.h: Add include guard.
11031         * p-lang.h: Add include guard.
11032         * or1k-tdep.h: Rename include guard.
11033         * observable.h: Rename include guard.
11034         * nto-tdep.h: Rename include guard.
11035         * nat/x86-linux.h: Rename include guard.
11036         * nat/x86-linux-dregs.h: Rename include guard.
11037         * nat/x86-gcc-cpuid.h: Add include guard.
11038         * nat/x86-dregs.h: Rename include guard.
11039         * nat/x86-cpuid.h: Rename include guard.
11040         * nat/ppc-linux.h: Rename include guard.
11041         * nat/mips-linux-watch.h: Rename include guard.
11042         * nat/linux-waitpid.h: Rename include guard.
11043         * nat/linux-ptrace.h: Rename include guard.
11044         * nat/linux-procfs.h: Rename include guard.
11045         * nat/linux-osdata.h: Rename include guard.
11046         * nat/linux-nat.h: Rename include guard.
11047         * nat/linux-namespaces.h: Rename include guard.
11048         * nat/linux-btrace.h: Rename include guard.
11049         * nat/glibc_thread_db.h: Rename include guard.
11050         * nat/gdb_thread_db.h: Rename include guard.
11051         * nat/gdb_ptrace.h: Rename include guard.
11052         * nat/fork-inferior.h: Rename include guard.
11053         * nat/amd64-linux-siginfo.h: Rename include guard.
11054         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11055         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11056         * nat/aarch64-linux.h: Rename include guard.
11057         * nat/aarch64-linux-hw-point.h: Rename include guard.
11058         * mn10300-tdep.h: Add include guard.
11059         * mips-linux-tdep.h: Add include guard.
11060         * mi/mi-parse.h: Rename include guard.
11061         * mi/mi-out.h: Rename include guard.
11062         * mi/mi-main.h: Rename include guard.
11063         * mi/mi-interp.h: Rename include guard.
11064         * mi/mi-getopt.h: Rename include guard.
11065         * mi/mi-console.h: Rename include guard.
11066         * mi/mi-common.h: Rename include guard.
11067         * mi/mi-cmds.h: Rename include guard.
11068         * mi/mi-cmd-break.h: Rename include guard.
11069         * m2-lang.h: Add include guard.
11070         * location.h: Rename include guard.
11071         * linux-record.h: Rename include guard.
11072         * linux-nat.h: Add include guard.
11073         * linux-fork.h: Add include guard.
11074         * i386-darwin-tdep.h: Rename include guard.
11075         * hppa-linux-offsets.h: Add include guard.
11076         * guile/guile.h: Rename include guard.
11077         * guile/guile-internal.h: Rename include guard.
11078         * gnu-nat.h: Rename include guard.
11079         * gdb-stabs.h: Rename include guard.
11080         * frv-tdep.h: Add include guard.
11081         * f-lang.h: Add include guard.
11082         * event-loop.h: Add include guard.
11083         * darwin-nat.h: Rename include guard.
11084         * cp-abi.h: Rename include guard.
11085         * config/sparc/nm-sol2.h: Rename include guard.
11086         * config/nm-nto.h: Rename include guard.
11087         * config/nm-linux.h: Add include guard.
11088         * config/i386/nm-i386gnu.h: Rename include guard.
11089         * config/djgpp/nl_types.h: Rename include guard.
11090         * config/djgpp/langinfo.h: Rename include guard.
11091         * compile/gcc-cp-plugin.h: Add include guard.
11092         * compile/gcc-c-plugin.h: Add include guard.
11093         * compile/compile.h: Rename include guard.
11094         * compile/compile-object-run.h: Rename include guard.
11095         * compile/compile-object-load.h: Rename include guard.
11096         * compile/compile-internal.h: Rename include guard.
11097         * compile/compile-cplus.h: Rename include guard.
11098         * compile/compile-c.h: Rename include guard.
11099         * common/xml-utils.h: Rename include guard.
11100         * common/x86-xstate.h: Rename include guard.
11101         * common/version.h: Rename include guard.
11102         * common/vec.h: Rename include guard.
11103         * common/tdesc.h: Rename include guard.
11104         * common/selftest.h: Rename include guard.
11105         * common/scoped_restore.h: Rename include guard.
11106         * common/scoped_mmap.h: Rename include guard.
11107         * common/scoped_fd.h: Rename include guard.
11108         * common/safe-iterator.h: Rename include guard.
11109         * common/run-time-clock.h: Rename include guard.
11110         * common/refcounted-object.h: Rename include guard.
11111         * common/queue.h: Rename include guard.
11112         * common/ptid.h: Rename include guard.
11113         * common/print-utils.h: Rename include guard.
11114         * common/preprocessor.h: Rename include guard.
11115         * common/pathstuff.h: Rename include guard.
11116         * common/observable.h: Rename include guard.
11117         * common/netstuff.h: Rename include guard.
11118         * common/job-control.h: Rename include guard.
11119         * common/host-defs.h: Rename include guard.
11120         * common/gdb_wait.h: Rename include guard.
11121         * common/gdb_vecs.h: Rename include guard.
11122         * common/gdb_unlinker.h: Rename include guard.
11123         * common/gdb_unique_ptr.h: Rename include guard.
11124         * common/gdb_tilde_expand.h: Rename include guard.
11125         * common/gdb_sys_time.h: Rename include guard.
11126         * common/gdb_string_view.h: Rename include guard.
11127         * common/gdb_splay_tree.h: Rename include guard.
11128         * common/gdb_setjmp.h: Rename include guard.
11129         * common/gdb_ref_ptr.h: Rename include guard.
11130         * common/gdb_optional.h: Rename include guard.
11131         * common/gdb_locale.h: Rename include guard.
11132         * common/gdb_assert.h: Rename include guard.
11133         * common/filtered-iterator.h: Rename include guard.
11134         * common/filestuff.h: Rename include guard.
11135         * common/fileio.h: Rename include guard.
11136         * common/environ.h: Rename include guard.
11137         * common/common-utils.h: Rename include guard.
11138         * common/common-types.h: Rename include guard.
11139         * common/common-regcache.h: Rename include guard.
11140         * common/common-inferior.h: Rename include guard.
11141         * common/common-gdbthread.h: Rename include guard.
11142         * common/common-exceptions.h: Rename include guard.
11143         * common/common-defs.h: Rename include guard.
11144         * common/common-debug.h: Rename include guard.
11145         * common/cleanups.h: Rename include guard.
11146         * common/buffer.h: Rename include guard.
11147         * common/btrace-common.h: Rename include guard.
11148         * common/break-common.h: Rename include guard.
11149         * cli/cli-utils.h: Rename include guard.
11150         * cli/cli-style.h: Rename include guard.
11151         * cli/cli-setshow.h: Rename include guard.
11152         * cli/cli-script.h: Rename include guard.
11153         * cli/cli-interp.h: Rename include guard.
11154         * cli/cli-decode.h: Rename include guard.
11155         * cli/cli-cmds.h: Rename include guard.
11156         * charset-list.h: Add include guard.
11157         * buildsym-legacy.h: Rename include guard.
11158         * bfin-tdep.h: Add include guard.
11159         * ax.h: Rename include guard.
11160         * arm-linux-tdep.h: Add include guard.
11161         * arm-fbsd-tdep.h: Add include guard.
11162         * arch/xtensa.h: Rename include guard.
11163         * arch/tic6x.h: Add include guard.
11164         * arch/i386.h: Add include guard.
11165         * arch/arm.h: Rename include guard.
11166         * arch/arm-linux.h: Rename include guard.
11167         * arch/arm-get-next-pcs.h: Rename include guard.
11168         * arch/amd64.h: Add include guard.
11169         * arch/aarch64-insn.h: Rename include guard.
11170         * arch-utils.h: Rename include guard.
11171         * annotate.h: Add include guard.
11172         * amd64-darwin-tdep.h: Rename include guard.
11173         * aarch64-linux-tdep.h: Add include guard.
11174         * aarch64-fbsd-tdep.h: Add include guard.
11175         * aarch32-linux-nat.h: Add include guard.
11176
11177 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11178
11179         * macrotab.c (macro_define_internal): New function that
11180         factorizes macro_define_object_internal and macro_define_function
11181         code.
11182         (macro_define_object_internal): Use macro_define_internal.
11183         (macro_define_function): Likewise.
11184
11185 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11186
11187         * macrocmd.c (extract_identifier): Return
11188         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11189         callers.
11190
11191 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11192
11193         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11194
11195 2019-02-05  Tom Tromey  <tom@tromey.com>
11196
11197         * target.c (target_stack::unpush): Move assertion earlier.
11198
11199 2019-01-30  Tom Tromey  <tom@tromey.com>
11200
11201         PR python/23615:
11202         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11203         (gdbpy_parse_and_eval): Likewise.
11204         * python/python-internal.h (gdbpy_allow_threads): New class.
11205
11206 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11207
11208         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11209         (aarch64_fbsd_fpregmap): Move earlier.
11210         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11211         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11212         instead of individual calls to trad_frame_set_reg_addr.
11213         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11214         earlier.
11215         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11216         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11217         instead of individual calls to trad_frame_set_reg_addr.
11218
11219 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11220
11221         * CONTRIBUTE: Replace contribution list with wiki link.
11222
11223 2019-01-25  Tom Tromey  <tom@tromey.com>
11224
11225         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11226
11227 2019-01-25  Tom Tromey  <tom@tromey.com>
11228
11229         * xtensa-linux-nat.c: Fix common/ includes.
11230         * xml-support.h: Fix common/ includes.
11231         * xml-support.c: Fix common/ includes.
11232         * x86-linux-nat.c: Fix common/ includes.
11233         * windows-nat.c: Fix common/ includes.
11234         * varobj.h: Fix common/ includes.
11235         * varobj.c: Fix common/ includes.
11236         * value.c: Fix common/ includes.
11237         * valops.c: Fix common/ includes.
11238         * utils.c: Fix common/ includes.
11239         * unittests/xml-utils-selftests.c: Fix common/ includes.
11240         * unittests/utils-selftests.c: Fix common/ includes.
11241         * unittests/unpack-selftests.c: Fix common/ includes.
11242         * unittests/tracepoint-selftests.c: Fix common/ includes.
11243         * unittests/style-selftests.c: Fix common/ includes.
11244         * unittests/string_view-selftests.c: Fix common/ includes.
11245         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11246         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11247         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11248         * unittests/rsp-low-selftests.c: Fix common/ includes.
11249         * unittests/parse-connection-spec-selftests.c: Fix common/
11250         includes.
11251         * unittests/optional-selftests.c: Fix common/ includes.
11252         * unittests/offset-type-selftests.c: Fix common/ includes.
11253         * unittests/observable-selftests.c: Fix common/ includes.
11254         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11255         * unittests/memrange-selftests.c: Fix common/ includes.
11256         * unittests/memory-map-selftests.c: Fix common/ includes.
11257         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11258         * unittests/function-view-selftests.c: Fix common/ includes.
11259         * unittests/environ-selftests.c: Fix common/ includes.
11260         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11261         * unittests/common-utils-selftests.c: Fix common/ includes.
11262         * unittests/cli-utils-selftests.c: Fix common/ includes.
11263         * unittests/array-view-selftests.c: Fix common/ includes.
11264         * ui-file.c: Fix common/ includes.
11265         * tui/tui-io.c: Fix common/ includes.
11266         * tracepoint.h: Fix common/ includes.
11267         * tracepoint.c: Fix common/ includes.
11268         * tracefile-tfile.c: Fix common/ includes.
11269         * top.h: Fix common/ includes.
11270         * top.c: Fix common/ includes.
11271         * thread.c: Fix common/ includes.
11272         * target/waitstatus.h: Fix common/ includes.
11273         * target/waitstatus.c: Fix common/ includes.
11274         * target.h: Fix common/ includes.
11275         * target.c: Fix common/ includes.
11276         * target-memory.c: Fix common/ includes.
11277         * target-descriptions.c: Fix common/ includes.
11278         * symtab.h: Fix common/ includes.
11279         * symfile.c: Fix common/ includes.
11280         * stap-probe.c: Fix common/ includes.
11281         * spu-linux-nat.c: Fix common/ includes.
11282         * sparc-nat.c: Fix common/ includes.
11283         * source.c: Fix common/ includes.
11284         * solib.c: Fix common/ includes.
11285         * solib-target.c: Fix common/ includes.
11286         * ser-unix.c: Fix common/ includes.
11287         * ser-tcp.c: Fix common/ includes.
11288         * ser-pipe.c: Fix common/ includes.
11289         * ser-base.c: Fix common/ includes.
11290         * selftest-arch.c: Fix common/ includes.
11291         * s12z-tdep.c: Fix common/ includes.
11292         * rust-exp.y: Fix common/ includes.
11293         * rs6000-aix-tdep.c: Fix common/ includes.
11294         * riscv-tdep.c: Fix common/ includes.
11295         * remote.c: Fix common/ includes.
11296         * remote-notif.h: Fix common/ includes.
11297         * remote-fileio.h: Fix common/ includes.
11298         * remote-fileio.c: Fix common/ includes.
11299         * regcache.h: Fix common/ includes.
11300         * regcache.c: Fix common/ includes.
11301         * record-btrace.c: Fix common/ includes.
11302         * python/python.c: Fix common/ includes.
11303         * python/py-type.c: Fix common/ includes.
11304         * python/py-inferior.c: Fix common/ includes.
11305         * progspace.h: Fix common/ includes.
11306         * producer.c: Fix common/ includes.
11307         * procfs.c: Fix common/ includes.
11308         * proc-api.c: Fix common/ includes.
11309         * printcmd.c: Fix common/ includes.
11310         * ppc-linux-nat.c: Fix common/ includes.
11311         * parser-defs.h: Fix common/ includes.
11312         * osdata.c: Fix common/ includes.
11313         * obsd-nat.c: Fix common/ includes.
11314         * nat/x86-linux.c: Fix common/ includes.
11315         * nat/x86-linux-dregs.c: Fix common/ includes.
11316         * nat/x86-dregs.h: Fix common/ includes.
11317         * nat/x86-dregs.c: Fix common/ includes.
11318         * nat/ppc-linux.c: Fix common/ includes.
11319         * nat/mips-linux-watch.h: Fix common/ includes.
11320         * nat/mips-linux-watch.c: Fix common/ includes.
11321         * nat/linux-waitpid.c: Fix common/ includes.
11322         * nat/linux-ptrace.h: Fix common/ includes.
11323         * nat/linux-ptrace.c: Fix common/ includes.
11324         * nat/linux-procfs.c: Fix common/ includes.
11325         * nat/linux-personality.c: Fix common/ includes.
11326         * nat/linux-osdata.c: Fix common/ includes.
11327         * nat/linux-namespaces.c: Fix common/ includes.
11328         * nat/linux-btrace.h: Fix common/ includes.
11329         * nat/linux-btrace.c: Fix common/ includes.
11330         * nat/fork-inferior.c: Fix common/ includes.
11331         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11332         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11333         * nat/aarch64-linux.c: Fix common/ includes.
11334         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11335         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11336         * namespace.h: Fix common/ includes.
11337         * mips-linux-tdep.c: Fix common/ includes.
11338         * minsyms.c: Fix common/ includes.
11339         * mi/mi-parse.h: Fix common/ includes.
11340         * mi/mi-main.c: Fix common/ includes.
11341         * mi/mi-cmd-env.c: Fix common/ includes.
11342         * memrange.h: Fix common/ includes.
11343         * memattr.c: Fix common/ includes.
11344         * maint.h: Fix common/ includes.
11345         * maint.c: Fix common/ includes.
11346         * main.c: Fix common/ includes.
11347         * machoread.c: Fix common/ includes.
11348         * location.c: Fix common/ includes.
11349         * linux-thread-db.c: Fix common/ includes.
11350         * linux-nat.c: Fix common/ includes.
11351         * linux-fork.c: Fix common/ includes.
11352         * inline-frame.c: Fix common/ includes.
11353         * infrun.c: Fix common/ includes.
11354         * inflow.c: Fix common/ includes.
11355         * inferior.h: Fix common/ includes.
11356         * inferior.c: Fix common/ includes.
11357         * infcmd.c: Fix common/ includes.
11358         * inf-ptrace.c: Fix common/ includes.
11359         * inf-child.c: Fix common/ includes.
11360         * ia64-linux-nat.c: Fix common/ includes.
11361         * i387-tdep.c: Fix common/ includes.
11362         * i386-tdep.c: Fix common/ includes.
11363         * i386-linux-tdep.c: Fix common/ includes.
11364         * i386-linux-nat.c: Fix common/ includes.
11365         * i386-go32-tdep.c: Fix common/ includes.
11366         * i386-fbsd-tdep.c: Fix common/ includes.
11367         * i386-fbsd-nat.c: Fix common/ includes.
11368         * guile/scm-type.c: Fix common/ includes.
11369         * guile/guile.c: Fix common/ includes.
11370         * go32-nat.c: Fix common/ includes.
11371         * gnu-nat.c: Fix common/ includes.
11372         * gdbthread.h: Fix common/ includes.
11373         * gdbarch-selftests.c: Fix common/ includes.
11374         * gdb_usleep.c: Fix common/ includes.
11375         * gdb_select.h: Fix common/ includes.
11376         * gdb_bfd.c: Fix common/ includes.
11377         * gcore.c: Fix common/ includes.
11378         * fork-child.c: Fix common/ includes.
11379         * findvar.c: Fix common/ includes.
11380         * fbsd-nat.c: Fix common/ includes.
11381         * event-top.c: Fix common/ includes.
11382         * event-loop.c: Fix common/ includes.
11383         * dwarf2read.c: Fix common/ includes.
11384         * dwarf2loc.c: Fix common/ includes.
11385         * dwarf2-frame.c: Fix common/ includes.
11386         * dwarf-index-cache.c: Fix common/ includes.
11387         * dtrace-probe.c: Fix common/ includes.
11388         * disasm-selftests.c: Fix common/ includes.
11389         * defs.h: Fix common/ includes.
11390         * csky-tdep.c: Fix common/ includes.
11391         * cp-valprint.c: Fix common/ includes.
11392         * cp-support.h: Fix common/ includes.
11393         * cp-support.c: Fix common/ includes.
11394         * corelow.c: Fix common/ includes.
11395         * completer.h: Fix common/ includes.
11396         * completer.c: Fix common/ includes.
11397         * compile/compile.c: Fix common/ includes.
11398         * compile/compile-loc2c.c: Fix common/ includes.
11399         * compile/compile-cplus-types.c: Fix common/ includes.
11400         * compile/compile-cplus-symbols.c: Fix common/ includes.
11401         * command.h: Fix common/ includes.
11402         * cli/cli-dump.c: Fix common/ includes.
11403         * cli/cli-cmds.c: Fix common/ includes.
11404         * charset.c: Fix common/ includes.
11405         * build-id.c: Fix common/ includes.
11406         * btrace.h: Fix common/ includes.
11407         * btrace.c: Fix common/ includes.
11408         * breakpoint.h: Fix common/ includes.
11409         * breakpoint.c: Fix common/ includes.
11410         * ax.h:
11411         (enum agent_op): Fix common/ includes.
11412         * ax-general.c (struct aop_map): Fix common/ includes.
11413         * ax-gdb.c: Fix common/ includes.
11414         * auxv.c: Fix common/ includes.
11415         * auto-load.c: Fix common/ includes.
11416         * arm-tdep.c: Fix common/ includes.
11417         * arch/riscv.c: Fix common/ includes.
11418         * arch/ppc-linux-common.c: Fix common/ includes.
11419         * arch/i386.c: Fix common/ includes.
11420         * arch/arm.c: Fix common/ includes.
11421         * arch/arm-linux.c: Fix common/ includes.
11422         * arch/arm-get-next-pcs.c: Fix common/ includes.
11423         * arch/amd64.c: Fix common/ includes.
11424         * arch/aarch64.c: Fix common/ includes.
11425         * arch/aarch64-insn.c: Fix common/ includes.
11426         * arch-utils.c: Fix common/ includes.
11427         * amd64-windows-tdep.c: Fix common/ includes.
11428         * amd64-tdep.c: Fix common/ includes.
11429         * amd64-sol2-tdep.c: Fix common/ includes.
11430         * amd64-obsd-tdep.c: Fix common/ includes.
11431         * amd64-nbsd-tdep.c: Fix common/ includes.
11432         * amd64-linux-tdep.c: Fix common/ includes.
11433         * amd64-linux-nat.c: Fix common/ includes.
11434         * amd64-fbsd-tdep.c: Fix common/ includes.
11435         * amd64-fbsd-nat.c: Fix common/ includes.
11436         * amd64-dicos-tdep.c: Fix common/ includes.
11437         * amd64-darwin-tdep.c: Fix common/ includes.
11438         * agent.c: Fix common/ includes.
11439         * ada-lang.h: Fix common/ includes.
11440         * ada-lang.c: Fix common/ includes.
11441         * aarch64-tdep.c: Fix common/ includes.
11442
11443 2019-01-25  Tom Tromey  <tom@tromey.com>
11444
11445         * common/create-version.sh: Use common/version.h.
11446
11447 2019-01-24  Pedro Alves  <palves@redhat.com>
11448
11449         * infrun.c (signal_stop, signal_print, signal_program)
11450         (signal_catch, signal_pass): Now arrays instead of pointers.
11451         (update_signals_program_target, do_target_resume)
11452         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11453         * linux-nat.c (linux_nat_target::pass_signals)
11454         (linux_nat_target::create_inferior, linux_nat_target::attach):
11455         Adjust.
11456         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11457         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11458         * procfs.c (procfs_target::pass_signals): Adjust.
11459         * record-full.c (record_full_target::resume): Adjust.
11460         * remote.c (remote_target::pass_signals)
11461         (remote_target::program_signals): Adjust.
11462         * target-debug.h (target_debug_print_signals): Now takes a
11463         gdb::array_view as parameter.  Adjust.
11464         * target.h (target_ops) <pass_signals, program_signals>: Replace
11465         pointer and length parameters with gdb::array_view.
11466         (target_pass_signals, target_program_signals): Likewise.
11467         * target-delegates.c: Regenerate.
11468
11469 2019-01-24  Pedro Alves  <palves@redhat.com>
11470
11471         * common/forward-scope-exit.h
11472         (forward_scope_exit::forward_scope_exit): Pass arguments to
11473         m_bind_function directly, instead of creating a std::bind and
11474         copying that.
11475
11476 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11477
11478         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11479         for static members.
11480         (pass_in_v_vfp_candidate): Likewise.
11481
11482 2019-01-23  Tom Tromey  <tom@tromey.com>
11483             Pedro Alves  <palves@redhat.com>
11484
11485         * regcache.c (class regcache_invalidator): Remove.
11486         (regcache::raw_write): Use make_scope_exit.
11487
11488 2019-01-23  Tom Tromey  <tom@tromey.com>
11489
11490         * ui-out.h (class ui_out_emit_type): Update comment.
11491
11492 2019-01-23  Tom Tromey  <tom@tromey.com>
11493
11494         * infrun.c (fetch_inferior_event): Update comment.
11495
11496 2019-01-23  Tom Tromey  <tom@tromey.com>
11497             Pedro Alves  <palves@redhat.com>
11498
11499         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11500         parameter.
11501         (fetch_inferior_event): Use SCOPE_EXIT.
11502
11503
11504 2019-01-23  Tom Tromey  <tom@tromey.com>
11505             Pedro Alves  <palves@redhat.com>
11506
11507         * infrun.c (disable_thread_events): Delete.
11508         (stop_all_threads): Use SCOPE_EXIT.
11509
11510 2019-01-23  Tom Tromey  <tom@tromey.com>
11511             Pedro Alves  <palves@redhat.com>
11512
11513         * symfile.c: Include forward-scope-exit.h.
11514         (clear_symtab_users_cleanup): Replace forward declaration with
11515         a FORWARD_SCOPE_EXIT.
11516         (syms_from_objfile_1): Use the forward_scope_exit and
11517         gdb::optional instead of cleanup_function.
11518         (reread_symbols): Use the forward_scope_exit instead of
11519         cleanup_function.
11520         (clear_symtab_users_cleanup): Remove function.
11521
11522 2019-01-23  Tom Tromey  <tom@tromey.com>
11523             Pedro Alves  <palves@redhat.com>
11524
11525         * linux-nat.c: Include scope-exit.h.
11526         (cleanup_target_stop): Remove.
11527         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11528         SCOPE_EXIT.
11529
11530 2019-01-23  Tom Tromey  <tom@tromey.com>
11531             Pedro Alves  <palves@redhat.com>
11532
11533         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11534         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11535
11536 2019-01-23  Tom Tromey  <tom@tromey.com>
11537             Andrew Burgess  <andrew.burgess@embecosm.com>
11538             Pedro Alves  <palves@redhat.com>
11539
11540         * infrun.c (fetch_inferior_event): Use scope_exit.
11541         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11542         * top.c (execute_command): Use scope_exit.
11543         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11544         * utils.c (do_bpstat_clear_actions_cleanup)
11545         (make_bpstat_clear_actions_cleanup): Remove.
11546
11547 2019-01-23  Tom Tromey  <tom@tromey.com>
11548             Pedro Alves  <palves@redhat.com>
11549
11550         * infrun.c: Include "common/scope-exit.h"
11551         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11552         (wait_for_inferior): Use SCOPE_EXIT.
11553         (fetch_inferior_event): Use scope_exit.
11554
11555 2019-01-23  Tom Tromey  <tom@tromey.com>
11556             Pedro Alves  <palves@redhat.com>
11557
11558         * breakpoint.c (create_breakpoint): Remove cleanup.
11559
11560 2019-01-23  Tom Tromey  <tom@tromey.com>
11561             Andrew Burgess  <andrew.burgess@embecosm.com>
11562             Pedro Alves  <palves@redhat.com>
11563
11564 2019-01-23  Pedro Alves  <palves@redhat.com>
11565
11566         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11567
11568 2019-01-23  Pedro Alves  <palves@redhat.com>
11569             Andrew Burgess  <andrew.burgess@embecosm.com>
11570
11571         * gdbthread.h: Include "common/forward-scope-exit.h".
11572         (scoped_finish_thread_state): Redefine custom class in terms of
11573         forward_scope_exit.
11574
11575 2019-01-23  Pedro Alves  <palves@redhat.com>
11576             Andrew Burgess  <andrew.burgess@embecosm.com>
11577
11578         * common/forward-scope-exit.h: New file.
11579
11580 2019-01-23  Pedro Alves  <palves@redhat.com>
11581             Andrew Burgess  <andrew.burgess@embecosm.com>
11582             Tom Tromey  <tom@tromey.com>
11583
11584         * common/scope-exit.h: New file.
11585
11586 2019-01-23  Pedro Alves  <palves@redhat.com>
11587
11588         * common/preprocessor.h (ESC): Rename to ...
11589         (ESC_PARENS): ... this.
11590         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11591         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11592
11593 2019-01-23  Tom Tromey  <tom@tromey.com>
11594
11595         * language.h (class scoped_switch_to_sym_language_if_auto):
11596         Initialize m_lang in both cases.
11597
11598 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11599
11600         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11601         with XCNEW.
11602
11603 2019-01-22  Tom Tromey  <tom@tromey.com>
11604
11605         * corelow.c: Do not include sys/file.h.
11606
11607 2019-01-22  Tom Tromey  <tom@tromey.com>
11608
11609         * tui/tui-wingeneral.h: Include gdb_curses.h.
11610
11611 2019-01-22  Tom Tromey  <tom@tromey.com>
11612
11613         * source-cache.h (class source_cache) <get_source_lines,
11614         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11615
11616 2019-01-22  Tom Tromey  <tom@tromey.com>
11617
11618         * remote-fileio.h (struct remote_target): Declare.
11619
11620 2019-01-22  Tom Tromey  <tom@tromey.com>
11621
11622         * python/py-arch.c: Do not include py-ref.h.
11623         * python/py-bpevent.c: Do not include py-ref.h.
11624         * python/py-cmd.c: Do not include py-ref.h.
11625         * python/py-continueevent.c: Do not include py-ref.h.
11626         * python/py-event.h: Do not include py-ref.h.
11627         * python/py-evtregistry.c: Do not include py-ref.h.
11628         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11629         * python/py-frame.c: Do not include py-ref.h.
11630         * python/py-framefilter.c: Do not include py-ref.h.
11631         * python/py-function.c: Do not include py-ref.h.
11632         * python/py-infevents.c: Do not include py-ref.h.
11633         * python/py-linetable.c: Do not include py-ref.h.
11634         * python/py-objfile.c: Do not include py-ref.h.
11635         * python/py-param.c: Do not include py-ref.h.
11636         * python/py-prettyprint.c: Do not include py-ref.h.
11637         * python/py-progspace.c: Do not include py-ref.h.
11638         * python/py-symbol.c: Do not include py-ref.h.
11639         * python/py-symtab.c: Do not include py-ref.h.
11640         * python/py-type.c: Do not include py-ref.h.
11641         * python/py-unwind.c: Do not include py-ref.h.
11642         * python/py-utils.c: Do not include py-ref.h.
11643         * python/py-value.c: Do not include py-ref.h.
11644         * python/py-varobj.c: Do not include py-ref.h.
11645         * python/py-xmethods.c: Do not include py-ref.h.
11646         * python/python.c: Do not include py-ref.h.
11647         * varobj.c: Do not include py-ref.h.
11648
11649 2019-01-22  Tom Tromey  <tom@tromey.com>
11650
11651         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11652         keyword for bcache.
11653
11654 2019-01-22  Tom Tromey  <tom@tromey.com>
11655
11656         * compile/compile-cplus-types.c: Remove a comment by #include.
11657
11658 2019-01-22  Tom Tromey  <tom@tromey.com>
11659
11660         * compile/gcc-c-plugin.h: Include compile-internal.h.
11661
11662 2019-01-22  Tom Tromey  <tom@tromey.com>
11663
11664         * stabsread.c (EXTERN): Do not define.
11665         (symnum, next_symbol_text_func, processing_gcc_compilation)
11666         (within_function, global_sym_chain, global_stabs)
11667         (previous_stab_code, this_object_header_files)
11668         (n_this_object_header_files)
11669         (n_allocated_this_object_header_files): Define.
11670         * stabsread.h (EXTERN): Never define.  Use "extern".
11671
11672 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11673
11674         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11675         history_value.
11676
11677 2019-01-21  Tom Tromey  <tom@tromey.com>
11678
11679         * ui-out.c: Fix includes.
11680         * tui/tui-source.c: Fix includes.
11681         * target.c: Fix includes.
11682         * remote.c: Fix includes.
11683         * regcache.c: Fix includes.
11684         * python/py-block.c: Fix includes.
11685         * printcmd.c: Fix includes.
11686         * or1k-tdep.c: Fix includes.
11687         * mi/mi-main.c: Fix includes.
11688         * m32r-tdep.c: Fix includes.
11689         * csky-tdep.c: Fix includes.
11690         * compile/compile-cplus-types.c: Fix includes.
11691         * cli/cli-interp.c: Fix includes.
11692
11693 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11694
11695         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11696         for padding.
11697
11698 2019-01-16  Tom Tromey  <tom@tromey.com>
11699
11700         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11701         earlier.
11702         (struct objfile) <msymbols_range>: Move from top level.
11703         <msymbols>: New method.
11704         (class objfile_msymbols): Remove.
11705         * symtab.c (default_collect_symbol_completion_matches_break_on):
11706         Update.
11707         * symmisc.c (dump_msymbols): Update.
11708         * stabsread.c (scan_file_globals): Update.
11709         * objc-lang.c (info_selectors_command, info_classes_command)
11710         (find_methods): Update.
11711         * minsyms.c (find_solib_trampoline_target): Update.
11712         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11713         * coffread.c (coff_symfile_read): Update.
11714         * ada-lang.c (ada_lookup_simple_minsym)
11715         (ada_collect_symbol_completion_matches): Update.
11716
11717 2019-01-16  Tom Tromey  <tom@tromey.com>
11718
11719         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11720         type.  Remove no-argument constructor.
11721         <iterator::operator++>: Simplify.
11722         <begin>: Update.
11723         <end>: Use minimal_symbol_count.
11724
11725 2019-01-16  Tom Tromey  <tom@tromey.com>
11726
11727         * objfiles.h (struct objfile) <psymtabs>: New method.
11728         (class objfile_psymtabs): Remove.
11729         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11730         typedef.
11731         <range>: New method.
11732         (require_partial_symbols): Change return type.
11733         * psymtab.c (require_partial_symbols)
11734         (psym_expand_symtabs_matching): Update.
11735         * mdebugread.c (parse_partial_symbols): Update.
11736         * dbxread.c (dbx_end_psymtab): Update.
11737
11738 2019-01-15  Tom Tromey  <tom@tromey.com>
11739
11740         * symtab.c (lookup_objfile_from_block)
11741         (lookup_symbol_in_objfile_symtabs)
11742         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11743         (find_line_symtab, info_sources_command)
11744         (default_collect_symbol_completion_matches_break_on)
11745         (make_source_files_completion_list): Update.
11746         * symmisc.c (print_objfile_statistics, dump_objfile)
11747         (maintenance_print_symbols, maintenance_info_symtabs)
11748         (maintenance_check_symtabs, maintenance_info_line_tables):
11749         Update.
11750         * source.c (select_source_symtab)
11751         (forget_cached_source_info_for_objfile): Update.
11752         * objfiles.h (class objfile_compunits): Remove.
11753         (struct objfile) <compunits_range>: New typedef.
11754         (compunits): New method.
11755         * objfiles.c (objfile_relocate1): Update.
11756         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11757         * maint.c (count_symtabs_and_blocks): Update.
11758         * linespec.c (iterate_over_all_matching_symtabs): Update.
11759         * cp-support.c (add_symbol_overload_list_qualified): Update.
11760         * coffread.c (coff_symtab_read): Update.
11761         * ada-lang.c (add_nonlocal_symbols)
11762         (ada_collect_symbol_completion_matches)
11763         (ada_add_global_exceptions): Update.
11764
11765 2019-01-15  Tom Tromey  <tom@tromey.com>
11766
11767         * progspace.h (program_space) <objfiles_safe_range>: New
11768         typedef.
11769         <objfiles_safe>: New method.
11770         * objfiles.h (class all_objfiles_safe): Remove.
11771         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11772         * jit.c (jit_inferior_exit_hook): Update.
11773
11774 2019-01-17  Tom Tromey  <tom@tromey.com>
11775
11776         * progspace.h (program_space) <objfiles_range>: New typedef.
11777         <objfiles>: New method.
11778         <objfiles_head>: Rename from objfiles.
11779         (object_files): Update.
11780         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11781         * guile/scm-pretty-print.c
11782         (ppscm_find_pretty_printer_from_objfiles): Update.
11783         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11784         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11785         Update.
11786         * python/py-progspace.c (pspy_get_objfiles): Update.
11787         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11788         Update.
11789         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11790         (objfpy_lookup_objfile_by_build_id): Update.
11791         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11792         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11793         Update.
11794         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11795         (expand_symtab_containing_pc, lookup_objfile_from_block)
11796         (lookup_static_symbol, basic_lookup_transparent_type)
11797         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11798         (find_line_symtab, info_sources_command)
11799         (default_collect_symbol_completion_matches_break_on)
11800         (make_source_files_completion_list, find_main_name): Update.
11801         * symmisc.c (print_symbol_bcache_statistics)
11802         (print_objfile_statistics, maintenance_print_symbols)
11803         (maintenance_print_msymbols, maintenance_print_objfiles)
11804         (maintenance_info_symtabs, maintenance_check_symtabs)
11805         (maintenance_expand_symtabs, maintenance_info_line_tables):
11806         Update.
11807         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11808         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11809         (map_overlay_command, unmap_overlay_command)
11810         (simple_overlay_update, expand_symtabs_matching)
11811         (map_symbol_filenames): Update.
11812         * symfile-debug.c (set_debug_symfile): Update.
11813         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11814         Update.
11815         * source.c (select_source_symtab, forget_cached_source_info):
11816         Update.
11817         * solib.c (solib_read_symbols): Update.
11818         * solib-spu.c (append_ocl_sos): Update.
11819         * psymtab.c (maintenance_print_psymbols)
11820         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11821         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11822         * printcmd.c (info_symbol_command): Update.
11823         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11824         Update.
11825         * objfiles.h (class all_objfiles): Remove.
11826         * objfiles.c (have_partial_symbols, have_full_symbols)
11827         (have_minimal_symbols, qsort_cmp, update_section_map)
11828         (shared_objfile_contains_address_p)
11829         (default_iterate_over_objfiles_in_search_order): Update.
11830         * objc-lang.c (info_selectors_command, info_classes_command)
11831         (find_methods): Update.
11832         * minsyms.c (find_solib_trampoline_target): Update.
11833         * maint.c (maintenance_info_sections)
11834         (maintenance_translate_address, count_symtabs_and_blocks):
11835         Update.
11836         * main.c (captured_main_1): Update.
11837         * linux-thread-db.c (try_thread_db_load_from_pdir)
11838         (has_libpthread): Update.
11839         * linespec.c (iterate_over_all_matching_symtabs)
11840         (search_minsyms_for_name): Update.
11841         * jit.c (jit_find_objf_with_entry_addr): Update.
11842         * hppa-tdep.c (find_unwind_entry)
11843         (hppa_lookup_stub_minimal_symbol): Update.
11844         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11845         Update.
11846         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11847         (elf_gnu_ifunc_resolve_by_got): Update.
11848         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11849         * dwarf-index-write.c (save_gdb_index_command): Update.
11850         * cp-support.c (add_symbol_overload_list_qualified): Update.
11851         * breakpoint.c (create_overlay_event_breakpoint)
11852         (create_longjmp_master_breakpoint)
11853         (create_std_terminate_master_breakpoint)
11854         (create_exception_master_breakpoint): Update.
11855         * blockframe.c (find_pc_partial_function): Update.
11856         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11857         (ada_collect_symbol_completion_matches)
11858         (ada_add_global_exceptions): Update.
11859
11860 2019-01-17  Tom Tromey  <tom@tromey.com>
11861
11862         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11863         declare VEC.
11864         (solib_target_parse_libraries): Change return type.
11865         (library_list_start_segment, library_list_start_section)
11866         (library_list_end_library, library_list_start_library); Update.
11867         (solib_target_free_library_list): Remove.
11868         (solib_target_parse_libraries): Remove cleanup.  Change return
11869         type.
11870         (solib_target_current_sos): Update.
11871
11872 2019-01-17  Tom Tromey  <tromey@bapiya>
11873
11874         * valprint.c: Replace "the the" with "the".
11875         * symtab.c: Replace "the the" with "the".
11876         * solib.c: Replace "the the" with "the".
11877         * solib-dsbt.c: Replace "the the" with "the".
11878         * linespec.c: Replace "the the" with "the".
11879         * dwarf2loc.h: Replace "the the" with "the".
11880         * amd64-windows-tdep.c: Replace "the the" with "the".
11881         * aarch64-tdep.c: Replace "the the" with "the".
11882
11883 2019-01-16  Keith Seitz  <keiths@redhat.com>
11884
11885         PR gdb/23773
11886         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11887         <builder>: Rename to ..
11888         <m_builder>: ... this and make private.
11889         (dwarf2_cu::get_builder): New method.  Change all users of
11890         `builder' to use this method.
11891         (dwarf2_start_symtab): Move to ...
11892         (dwarf2_cu::start_symtab): ... here.  Update all callers
11893         (setup_type_unit_groups): Move to ...
11894         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11895         callers.
11896         (dwarf2_cu::reset_builder): New method.
11897         (process_full_compunit, process_full_type_unit): Use
11898         dwarf2_cu::reset_builder.
11899         (follow_die_offset): Record the ancestor CU if it is different
11900         from the followed DIE's CU.
11901         (follow_die_sig_1): Likewise.
11902
11903 2019-01-15  Tom Tromey  <tom@tromey.com>
11904
11905         * remote.c (class remote_state) <buf>: Now a char_vector.
11906         <buf_size>: Remove.
11907         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11908         parameter.
11909         (remote_target::getpkt_or_notif_sane_1)
11910         (remote_target::getpkt_sane)
11911         (remote_target::getpkt_or_notif_sane): Likewise.
11912         (class remote_target) <putpkt>: New overload.
11913         (remote_target::read_frame): Change type of "buf_p".  Remove
11914         sizeof_p parameter.
11915         (packet_ok): New overload.
11916         (packet_check_result): New overload.
11917         Update all uses.
11918
11919 2019-01-14  Tom Tromey  <tom@tromey.com>
11920
11921         * remote-notif.c (handle_notification, remote_notif_ack)
11922         (remote_notif_parse): Make "buf" const.
11923         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11924         const.
11925         (remote_notif_parse, remote_notif_ack, handle_notification):
11926         Likewise.
11927         * remote.c (remote_notif_stop_parse): Make "buf" const.
11928         (remote_target::remote_parse_stop_reply): Make "buf" const.
11929         (remote_notif_stop_ack): Make "buf" const.
11930
11931 2019-01-14  Tom Tromey  <tom@tromey.com>
11932
11933         * remote.c (remote_console_output): Make parameter const.
11934
11935 2019-01-14  Tom Tromey  <tom@tromey.com>
11936
11937         * target-debug.h (target_debug_print_signals): Constify.
11938         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11939         * procfs.c (procfs_target::pass_signals): Update.
11940         * linux-nat.c (linux_nat_target::pass_signals): Update.
11941         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11942         * target-delegates.c: Rebuild.
11943         * remote.c (remote_target::program_signals): Update.
11944         (remote_target::pass_signals): Update.
11945         * target.c (target_pass_signals): Constify argument.
11946         (target_program_signals): Likewise.
11947         * target.h (struct target_ops) <pass_signals, program_signals>:
11948         Constify argument.
11949         (target_pass_signals, target_program_signals): Constify argument.
11950
11951 2019-01-14  Tom Tromey  <tom@tromey.com>
11952
11953         PR tui/28819:
11954         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11955
11956 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11957
11958         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11959         field.
11960         * rs6000-tdep.c: Include reggroups.h.
11961         (IS_V_ALIAS_PSEUDOREG): Define.
11962         (rs6000_register_name): Return names for the "vX" aliases.
11963         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11964         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11965         aliases.  Call default_register_reggroup_p for all other
11966         pseudo-registers.
11967         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11968         New functions.
11969         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11970         Handle "vX" aliases.
11971         (v_alias_pseudo_register_collect): New function.
11972         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11973         (rs6000_gdbarch_init): Initialize "vX" aliases as
11974         pseudo-registers.  Restore registration of
11975         rs6000_pseudo_register_reggroup_p with
11976         set_tdesc_pseudo_register_reggroup_p.
11977
11978 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11979
11980         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11981         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11982         set_gdbarch_num_pseudo_regs.
11983
11984 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11985
11986         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11987         Remove arg prefixname, add do_set and do_show.
11988         Add member functions set_list and show_list.
11989         * cli/cli-style.c (class cli_style_option): Update accordingly.
11990         (style_set_list): Move to file scope.
11991         (style_show_list): Likewise.
11992         (set_style): Call help_list.
11993         (show_style): Call cmd_show_list.
11994         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11995         Update to use the new macro.
11996
11997 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11998
11999         * ada-lang.c (_initialize_ada_language): Expand the help text
12000         for the "catch exception" command.
12001
12002 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12003
12004         * symtab.c (matching_obj_sections): Initialize obj,
12005         declare it closer to its usage.
12006
12007 2019-01-10  Tom Tromey  <tom@tromey.com>
12008
12009         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12010         (basic_inf_threads_range): Remove.
12011         (inf_threads_range, inf_non_exited_threads_range)
12012         (safe_inf_threads_range): Use next_adapter.
12013
12014 2019-01-10  Keith Seitz  <keiths@redhat.com>
12015
12016         PR gdb/23712
12017         PR symtab/23010
12018         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12019         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12020
12021 2019-01-10  Keith Seitz  <keiths@redhat.com>
12022
12023         PR gdb/23712
12024         PR symtab/23010
12025         * dictionary.c (pending_to_vector): Remove.
12026         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12027         Remove _1 suffix, replacing functions of the same name.  Update
12028         all callers.
12029         (dict_create_hashed, dict_create_hashed_expandable)
12030         (dict_create_linear, dict_create_linear_expandable, dict_free)
12031         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12032         Make functions static.
12033
12034 2019-01-10  Keith Seitz  <keiths@redhat.com>
12035
12036         PR gdb/23712
12037         PR symtab/23010
12038         * dictionary.h (struct dictionary): Replace declaration with
12039         multidictionary.
12040         (dict_create_hashed, dict_create_hashed_expandable)
12041         (dict_create_linear, dict_create_linear_expandable)
12042         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12043         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12044         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12045         taking multidictionary argument.
12046         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12047         * block.h (struct block) <dict>: Change to multidictionary
12048         and rename `multidict'.
12049         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12050         symmisc.c: Update all dictionary references to multidictionary.
12051
12052 2019-01-10  Keith Seitz  <keiths@redhat.com>
12053
12054         PR gdb/23712
12055         PR symtab/23010
12056         * dictionary.c: Include unordered_map.
12057         (pending_to_vector): New function.
12058         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12059         Rewrite the non-"_1" functions to take vector instead
12060         of linked list.
12061         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12062         "new" _1 versions of the same name.
12063         (multidictionary): Define.
12064         (std::hash<enum language): New definition.
12065         (collate_pending_symbols_by_language, mdict_create_hashed)
12066         (mdict_create_hashed_expandable, mdict_create_linear)
12067         (mdict_create_linear_expandable, mdict_free)
12068         (find_language_dictionary, create_new_language_dictionary)
12069         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12070         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12071         (mdict_size, mdict_empty): New functions.
12072         * dictionary.h (mdict_iterator): Define.
12073
12074 2019-01-10  Pedro Alves  <palves@redhat.com>
12075
12076         * breakpoint.c (read_uploaded_action)
12077         (create_tracepoint_from_upload): Adjust to use
12078         gdb::unique_xmalloc_ptr.
12079         * ctf.c (ctf_write_uploaded_tp):
12080         (SET_ARRAY_FIELD): Use emplace_back.
12081         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12082         * tracefile-tfile.c (tfile_write_uploaded_tp):
12083         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12084         gdb::unique_xmalloc_ptr.
12085         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12086         at_string, cond_string, cmd_strings>: Replace char pointers
12087         with gdb::unique_xmalloc_ptr.
12088
12089 2019-01-10  Pedro Alves  <palves@redhat.com>
12090
12091         * solib-target.c (library_list_start_library): Don't xstrdup name.
12092
12093 2019-01-10  Pedro Alves  <palves@redhat.com>
12094
12095         * mdebugread.c (parse_partial_symbols): Use
12096         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12097
12098 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12099
12100         * linux-fork.c (scoped_switch_fork_info)
12101         <~scoped_switch_fork_info>: Fix incorrect variable name.
12102
12103 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12104
12105         * linux-fork.c (scoped_switch_fork_info)
12106         <scoped_switch_fork_info>: Make explicit.
12107         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12108
12109 2019-01-10  Tom Tromey  <tom@tromey.com>
12110
12111         * objfiles.h (objfile::reset_psymtabs): Update.
12112         * objfiles.c (objfile::objfile): Update.
12113         * psymtab.h (psymtab_storage::obstack): Update.
12114         (psymtab_storage::m_obstack): Use gdb::optional.
12115         (class psymtab_storage): Update comment.  Remove objfile
12116         parameter.
12117         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12118
12119 2019-01-10  Tom Tromey  <tom@tromey.com>
12120
12121         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12122         <free_psymtabs>: Now private.
12123         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12124         (allocate_psymtab): Use new method.
12125
12126 2019-01-10  Tom Tromey  <tom@tromey.com>
12127
12128         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12129         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12130         * mdebugread.c (parse_partial_symbols): Use
12131         allocate_dependencies.
12132         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12133         allocate_dependencies.
12134         (process_psymtab_comp_unit_reader)
12135         (build_type_psymtab_dependencies): Likewise.
12136         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12137
12138 2019-01-10  Tom Tromey  <tom@tromey.com>
12139
12140         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12141         PSYMBOL_SET_LANGUAGE.
12142         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12143
12144 2019-01-10  Tom Tromey  <tom@tromey.com>
12145
12146         * psymtab.h (psymtab_storage::obstack): New method.
12147         <m_obstack>: Rename from obstack; now private.
12148         * psymtab.c (psymtab_storage): Update.
12149         * dwarf2read.c (create_addrmap_from_index)
12150         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12151         Update.
12152
12153 2019-01-10  Tom Tromey  <tom@tromey.com>
12154
12155         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12156         * objfiles.h (objfile::reset_psymtabs): New method.
12157
12158 2019-01-10  Tom Tromey  <tom@tromey.com>
12159
12160         * symmisc.c (print_symbol_bcache_statistics): Update.
12161         (print_objfile_statistics): Update.
12162         * symfile.c (reread_symbols): Update.
12163         * psymtab.h (class psymtab_storage): New.
12164         * psymtab.c (psymtab_storage): New constructor.
12165         (~psymtab_storage): New destructor.
12166         (require_partial_symbols): Update.
12167         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12168         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12169         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12170         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12171         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12172         (start_psymtab_common, end_psymtab_common)
12173         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12174         (allocate_psymtab): Update.
12175         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12176         Update.
12177         (dump_psymtab_addrmap, maintenance_print_psymbols)
12178         (maintenance_check_psymtabs): Update.
12179         (class objfile_psymtabs): Move to objfiles.h.
12180         * psympriv.h (discard_psymtab): Now inline.
12181         (psymtab_discarder::psymtab_discarder): Update.
12182         (psymtab_discarder::~psymtab_discarder): Update.
12183         (ALL_OBJFILE_PSYMTABS): Rewrite.
12184         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12185         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12186         Remove fields.
12187         <partial_symtabs>: New field.
12188         (class objfile_psymtabs): Move from psymtab.h.  Update.
12189         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12190         psymbol_cache.
12191         (objfile::~objfile): Don't destroy psymbol_cache.
12192         * mdebugread.c (parse_partial_symbols): Update.
12193         * dwarf2read.c (create_addrmap_from_index)
12194         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12195         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12196         (add_partial_subprogram, dwarf2_ranges_read): Update.
12197         * dwarf-index-write.c (write_address_map)
12198         (write_one_signatured_type, recursively_write_psymbols)
12199         (class debug_names, class debug_names, write_psymtabs_to_index):
12200         Update.
12201
12202 2019-01-10  Tom Tromey  <tom@tromey.com>
12203
12204         * symtab.h (SYMBOL_SET_NAMES): Update.
12205         (symbol_set_names): Update.
12206         (MSYMBOL_SET_NAMES): Update.
12207         * symtab.c (symbol_set_names): Change argument to be an
12208         objfile_per_bfd_storage.
12209         * psymtab.c (add_psymbol_to_bcache): Update.
12210         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12211
12212 2019-01-10  Tom Tromey  <tom@tromey.com>
12213
12214         * symtab.c (create_demangled_names_hash): Change argument to be an
12215         objfile_per_bfd_storage.
12216         (symbol_set_names): Update.
12217
12218 2019-01-10  Tom Tromey  <tom@tromey.com>
12219
12220         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12221         init_psymbol_list.
12222         * psymtab.c (init_psymbol_list): Do nothing if already called.
12223         * psympriv.h (init_psymbol_list): Add comment.
12224         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12225         init_psymbol_list.
12226         * dbxread.c (dbx_symfile_read): Unconditionally call
12227         init_psymbol_list.
12228
12229 2019-01-10  Tom Tromey  <tom@tromey.com>
12230
12231         * xcoffread.c (scan_xcoff_symtab): Update.
12232         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12233         "where".
12234         * mdebugread.c (parse_partial_symbols)
12235         (handle_psymbol_enumerators): Update.
12236         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12237         * dbxread.c (read_dbx_symtab): Update.
12238         * psympriv.h (psymbol_placement): New enum.
12239         (add_psymbol_to_list): Update.
12240
12241 2019-01-10  Tom Tromey  <tom@tromey.com>
12242
12243         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12244         static_psymbols parameters.
12245         (scan_xcoff_symtab): Update.
12246         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12247         static_psymbols parameters.
12248         * psympriv.h (start_psymtab_common): Update.
12249         * mdebugread.c (parse_partial_symbols): Update.
12250         * dwarf2read.c (create_partial_symtab): Update.
12251         * dbxread.c (read_dbx_symtab): Update.
12252         (start_psymtab): Remove global_psymbols and static_psymbols
12253         parameters.
12254
12255 2019-01-10  Tom Tromey  <tom@tromey.com>
12256
12257         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12258         * psymtab.c (allocate_psymtab): Add comment.
12259         * psympriv.h (allocate_psymtab): Add comment.
12260         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12261         initializations.
12262         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12263
12264 2019-01-10  Tom Tromey  <tom@tromey.com>
12265
12266         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12267         Don't declare.
12268         * mipsread.c: Include mdebugread.h.
12269         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12270         Declare.
12271         * elfread.c: Include mdebugread.h.
12272
12273 2019-01-09  Tom Tromey  <tom@tromey.com>
12274
12275         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12276         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12277         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12278         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12279         (psym_lookup_symbol, psym_find_last_source_symtab)
12280         (psym_forget_cached_source_info, psym_print_stats)
12281         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12282         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12283         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12284         (psym_find_compunit_symtab_by_address)
12285         (maintenance_print_psymbols, maintenance_info_psymtabs)
12286         (maintenance_check_psymtabs): Use ranged for.
12287         * psymtab.h (class objfile_psymtabs): New.
12288         (require_partial_symbols): Return objfile_psymtabs.
12289         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12290
12291 2019-01-09  Tom Tromey  <tom@tromey.com>
12292
12293         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12294         (find_pc_mapped_section, list_overlays_command)
12295         (map_overlay_command, unmap_overlay_command)
12296         (simple_overlay_update): Use all_objfiles.
12297         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12298         * printcmd.c (info_symbol_command): Use all_objfiles.
12299         * objfiles.h (ALL_OBJSECTIONS): Remove.
12300         * maint.c (maintenance_translate_address): Use all_objfiles.
12301         * gcore.c (gcore_create_callback): Use all_objfiles.
12302         (objfile_find_memory_regions): Likewise.
12303
12304 2019-01-09  Tom Tromey  <tom@tromey.com>
12305
12306         * symtab.c (find_line_symtab, info_sources_command)
12307         (make_source_files_completion_list): Use objfile_compunits.
12308         * source.c (select_source_symtab): Use objfile_compunits.
12309         * objfiles.h (struct objfile): Update comment.
12310         (ALL_OBJFILES): Remove.
12311         (ALL_FILETABS): Remove.
12312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12313         objfile_compunits.
12314
12315 2019-01-09  Tom Tromey  <tom@tromey.com>
12316
12317         * symmisc.c (print_objfile_statistics, dump_objfile)
12318         (maintenance_print_symbols): Use compunit_filetabs.
12319         * source.c (forget_cached_source_info_for_objfile): Use
12320         compunit_filetabs.
12321         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12322         (ALL_FILETABS): Use compunit_filetabs.
12323         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12324         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12325
12326 2019-01-09  Tom Tromey  <tom@tromey.com>
12327
12328         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12329         (compunit_filetabs): New.
12330         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12331         compunit_filetabs.
12332         (info_sources_command, make_source_files_completion_list): Remove
12333         declaration.
12334         * symmisc.c (print_objfile_statistics, dump_objfile)
12335         (maintenance_print_symbols): Remove declaration.
12336         (maintenance_info_symtabs): Use compunit_filetabs.
12337         (maintenance_info_line_tables): Likewise.
12338         * source.c (select_source_symtab): Change local variable name.
12339         (forget_cached_source_info_for_objfile): Remove declaration.
12340         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12341         * objfiles.c (objfile_relocate1): Remove declaration.
12342         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12343         declaration.
12344         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12345         * coffread.c (coff_symtab_read): Remove declaration.
12346         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12347         compunit_filetabs.
12348
12349 2019-01-09  Tom Tromey  <tom@tromey.com>
12350
12351         * symtab.c (lookup_objfile_from_block)
12352         (find_pc_sect_compunit_symtab, search_symbols)
12353         (default_collect_symbol_completion_matches_break_on): Use
12354         objfile_compunits.
12355         * objfiles.h (ALL_COMPUNITS): Remove.
12356         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12357         * cp-support.c (add_symbol_overload_list_qualified): Use
12358         objfile_compunits.
12359         * ada-lang.c (ada_collect_symbol_completion_matches)
12360         (ada_add_global_exceptions): Use objfile_compunits.
12361
12362 2019-01-09  Tom Tromey  <tom@tromey.com>
12363
12364         * source.c (select_source_symtab)
12365         (forget_cached_source_info_for_objfile): Remove declaration.
12366         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12367         declaration.
12368         * maint.c (count_symtabs_and_blocks): Remove declaration.
12369         * cp-support.c (add_symbol_overload_list_qualified): Remove
12370         declaration.
12371         * coffread.c (coff_symtab_read): Remove declaration.
12372         * symtab.c (lookup_symbol_in_objfile_symtabs)
12373         (basic_lookup_transparent_type_1): Use objfile_compunits.
12374         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12375         (info_sources_command, search_symbols)
12376         (default_collect_symbol_completion_matches_break_on)
12377         (make_source_files_completion_list): Remove declaration.
12378         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12379         (ada_collect_symbol_completion_matches)
12380         (ada_add_global_exceptions): Remove declaration.
12381         * linespec.c (iterate_over_all_matching_symtabs): Use
12382         objfile_compunits.
12383         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12384         (class objfile_compunits): New.
12385         (ALL_COMPUNITS): Use objfile_compunits.
12386         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12387         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12388         objfile_compunits.
12389         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12390
12391 2019-01-09  Tom Tromey  <tom@tromey.com>
12392
12393         * symtab.c (search_symbols)
12394         (default_collect_symbol_completion_matches_break_on): Use
12395         objfile_msymbols.
12396         * ada-lang.c (ada_lookup_simple_minsym)
12397         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12398         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12399         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12400         objfile_msymbols.
12401         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12402         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12403         * objc-lang.c (find_methods): Use objfile_msymbols.
12404         (info_selectors_command, info_classes_command): Likewise.
12405         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12406         * objfiles.h (class objfile_msymbols): New.
12407         (ALL_OBJFILE_MSYMBOLS): Remove.
12408         (ALL_MSYMBOLS): Remove.
12409
12410 2019-01-09  Tom Tromey  <tom@tromey.com>
12411
12412         * common/next-iterator.h (next_adapter): Add Iterator template
12413         parameter.
12414         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12415         (class all_objfiles_safe): New.
12416         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12417         * objfiles.c (put_objfile_before): Update comment.
12418         (add_separate_debug_objfile): Likewise.
12419         (free_all_objfiles): Use all_objfiles_safe.
12420         (objfile_purge_solibs): Likewise.
12421
12422 2019-01-09  Tom Tromey  <tom@tromey.com>
12423
12424         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12425         (expand_symtab_containing_pc, lookup_static_symbol)
12426         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12427         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12428         all_objfiles.
12429         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12430         * breakpoint.c (create_overlay_event_breakpoint)
12431         (create_longjmp_master_breakpoint)
12432         (create_std_terminate_master_breakpoint)
12433         (create_exception_master_breakpoint): Use all_objfiles.
12434         * linux-thread-db.c (try_thread_db_load_from_pdir)
12435         (has_libpthread): Use all_objfiles.
12436         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12437         * linespec.c (iterate_over_all_matching_symtabs)
12438         (search_minsyms_for_name): Use all_objfiles.
12439         * maint.c (maintenance_info_sections): Use all_objfiles.
12440         * main.c (captured_main_1): Use all_objfiles.
12441         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12442         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12443         * guile/scm-pretty-print.c
12444         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12445         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12446         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12447         (maintenance_print_msymbols): Use all_objfiles.
12448         * source.c (select_source_symtab): Use all_objfiles.
12449         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12450         * symfile.c (remove_symbol_file_command)
12451         (expand_symtabs_matching, map_symbol_filenames): Use
12452         all_objfiles.
12453         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12454         all_objfiles.
12455         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12456         * objc-lang.c (find_methods): Use all_objfiles.
12457         * objfiles.c (have_partial_symbols, have_full_symbols)
12458         (have_minimal_symbols, qsort_cmp)
12459         (default_iterate_over_objfiles_in_search_order): Use
12460         all_objfiles.
12461         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12462         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12463         (maintenance_check_psymtabs): Use all_objfiles.
12464         (ALL_PSYMTABS): Remove.
12465         * compile/compile-object-run.c (do_module_cleanup): Use
12466         all_objfiles.
12467         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12468         * cp-support.c (add_symbol_overload_list_qualified): Use
12469         all_objfiles.
12470         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12471         Use all_objfiles.
12472         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12473         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12474         all_objfiles.
12475         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12476         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12477         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12478         Uses all_objfiles.
12479         * solib.c (solib_read_symbols): Use all_objfiles
12480
12481 2019-01-09  Tom Tromey  <tom@tromey.com>
12482
12483         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12484         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12485         all_objfiles.
12486         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12487         * symmisc.c (print_symbol_bcache_statistics)
12488         (print_objfile_statistics, maintenance_print_objfiles)
12489         (maintenance_info_symtabs, maintenance_check_symtabs)
12490         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12491         all_objfiles.
12492         * source.c (forget_cached_source_info): Use all_objfiles.
12493         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12494         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12495         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12496         * objfiles.c (update_section_map): Use all_objfiles.
12497         (shared_objfile_contains_address_p): Likewise.
12498         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12499         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12500
12501 2019-01-09  Tom Tromey  <tom@tromey.com>
12502
12503         * common/next-iterator.h: New file.
12504         * objfiles.h (class all_objfiles): New.
12505         (struct objfile_iterator): New.
12506
12507 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12508
12509         * NEWS: Move the description of the changed "frame", "select-frame",
12510          and "info frame" commands to the Changed commands section.
12511
12512 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12513
12514         * gdbtypes.c (check_stub_method_group): Remove handling of old
12515         mangling schemes.
12516         * linespec.c (find_methods): Likewise.
12517         * stabsread.c (read_member_functions): Likewise.
12518         * valops.c (search_struct_method): Likewise.
12519         (value_struct_elt_for_reference): Likewise.
12520         * NEWS: Mention this change.
12521
12522 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12523
12524         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12525         print_source_lines.
12526         * source.c (print_source_lines_base): Update line number check.
12527         (print_source_lines): New function.
12528         (source_lines_range::source_lines_range): New function.
12529         * source.h (class source_lines_range): New class.
12530         (print_source_lines): New declaration.
12531
12532 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12533
12534         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12535
12536 2019-01-08  Tom Tromey  <tom@tromey.com>
12537             Simon Marchi  <simon.marchi@ericsson.com>
12538
12539         PR gdb/24060
12540         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12541         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12542         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12543         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12544         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12545         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12546
12547 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12548
12549         * source.c (select_source_symtab): Move header comment to
12550         declaration in source.h.
12551         (forget_cached_source_info_for_objfile): Likewise.
12552         (forget_cached_source_info): Likewise.
12553         (identify_source_line): Likewise.
12554         * source.h (identify_source_line): Move declaration from symtab.h
12555         and add comment from source.c
12556         (print_source_lines): Likewise.
12557         (forget_cached_source_info_for_objfile): Likewise.
12558         (forget_cached_source_info): Likewise.
12559         (select_source_symtab): Likewise.
12560         (enum print_source_lines_flag): Move definition from symtab.h.
12561         * symtab.h (identify_source_line): Move declaration to source.h.
12562         (print_source_lines): Likewise.
12563         (forget_cached_source_info_for_objfile): Likewise.
12564         (forget_cached_source_info): Likewise.
12565         (select_source_symtab): Likewise.
12566         (enum print_source_lines_flag): Move definition to source.h.
12567         * tui/tui-hooks.c: Add 'source.h' include.
12568
12569 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12570
12571         * source.c (print_source_lines_base): Handle requests to print
12572         reverse line number sequences, and guard against empty lines
12573         string.
12574
12575 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12576
12577         * source.c (print_source_lines_base): Fix skip of '\r' if next
12578         character is '\n'.
12579
12580 2019-01-06  Tom Tromey  <tom@tromey.com>
12581
12582         * c-exp.y (struct c_parse_state) <macro_original_text,
12583         expansion_obstack>: New member.
12584         (macro_original_text, expansion_obstack): Remove globals.
12585         (scan_macro_expansion, scanning_macro_expansion)
12586         (finished_macro_expansion): Update.
12587         (scan_macro_cleanup): Remove.
12588         (yylex, c_parse): Update.
12589
12590 2019-01-06  Tom Tromey  <tom@tromey.com>
12591
12592         * c-exp.y (struct c_parse_state) <strings>: New member.
12593         (operator_stoken): Update.
12594
12595 2019-01-06  Tom Tromey  <tom@tromey.com>
12596
12597         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12598         (union type_stack_elt) <typelist_val>: Now a pointer to
12599         std::vector.
12600         (type_stack_cleanup): Don't declare.
12601         (push_typelist): Update.
12602         * parse.c (pop_typelist): Return a std::vector.
12603         (push_typelist): Take a std::vector.
12604         (follow_types): Update.  Do not free args.
12605         (type_stack_cleanup): Remove.
12606         * c-exp.y (struct c_parse_state): New.
12607         (cpstate): New global.
12608         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12609         (nonempty_typelist): Update.
12610         (func_mod): Create a new vector.
12611         (c_parse): Create a c_parse_state.
12612         (check_parameter_typelist): Do not delete params.
12613         (function_method): Update.  Do not delete type_list.
12614
12615 2019-01-06  Tom Tromey  <tom@tromey.com>
12616
12617         PR gdb/28155:
12618         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12619         check_typedef.
12620         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12621         (print_return_value): Likewise.
12622
12623 2019-01-05  Tom Tromey  <tom@tromey.com>
12624
12625         * contrib/cleanup_check.py: Remove.
12626         * contrib/gcc-with-excheck: Remove.
12627         * contrib/exsummary.py: Remove.
12628         * contrib/excheck.py: Remove.
12629
12630 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12631
12632         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12633         NULL. Initialize tpprev to NULL instead of assigning it
12634         to NULL on the next statement.
12635         * windows-nat.c (windows_delete_thread): Remove check for
12636         main_thread_id before printing thread exit notifications.
12637         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12638         Remove thread ID check against main_thread_id.
12639         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12640         windows_delete_thread.
12641         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12642
12643 2019-01-04  Tom Tromey  <tom@tromey.com>
12644
12645         * compile/compile.c (_initialize_compile): Use upper case for
12646         metasyntactic variables.
12647         * symmisc.c (_initialize_symmisc): Use upper case for
12648         metasyntactic variables.
12649         * psymtab.c (_initialize_psymtab): Use upper case for
12650         metasyntactic variables.
12651         * demangle.c (demangle_command): Use upper case for metasyntactic
12652         variables.
12653         (_initialize_demangler): Likewise.
12654         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12655         variables.
12656
12657 2019-01-03  Tom Tromey  <tom@tromey.com>
12658
12659         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12660
12661 2019-01-03  Tom Tromey  <tom@tromey.com>
12662
12663         * python/py-symtab.c (salpy_str): Update.
12664         (struct salpy_sal_object) <symtab>: Now a PyObject.
12665         (salpy_dealloc): Update.
12666         (del_objfile_sal): Use gdbpy_ref.
12667
12668 2019-01-03  Tom Tromey  <tom@tromey.com>
12669
12670         * python/py-type.c (convert_field): Use new_reference.  Return
12671         gdbpy_ref.
12672         (make_fielditem): Return gdbpy_ref.
12673         (typy_fields): Update.
12674         (typy_getitem): Update.
12675         (field_name): Return gdbpy_ref.  Use new_reference.
12676         (typy_iterator_iternext): Update.
12677
12678 2019-01-03  Tom Tromey  <tom@tromey.com>
12679
12680         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12681
12682 2019-01-03  Tom Tromey  <tom@tromey.com>
12683
12684         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12685         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12686         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12687         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12688         (pspy_set_type_printers): Likewise.
12689         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12690         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12691         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12692         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12693         (objfpy_set_type_printers): Likewise.
12694
12695 2019-01-03  Tom Tromey  <tom@tromey.com>
12696
12697         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12698         (gdbpy_print_stack): Use gdbpy_err_fetch.
12699         * python/python-internal.h (class gdbpy_err_fetch): New class.
12700         (class gdbpy_enter) <m_error_type, m_error_value,
12701         m_error_traceback>: Remove.
12702         <m_error>: New member.
12703         (gdbpy_exception_to_string): Don't declare.
12704         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12705         * python/py-value.c (convert_value_from_python): Use
12706         gdbpy_err_fetch.
12707         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12708         gdbpy_exception_to_string.
12709         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12710         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12711         gdbpy_err_fetch.
12712
12713 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12714
12715         * linux-nat.c (delete_lwp_cleanup): Delete.
12716         (struct lwp_deleter): New struct.
12717         (lwp_info_up): New typedef.
12718         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12719         lwp_info_up.
12720
12721 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12722
12723         * linux-fork.c (class scoped_switch_fork_info): New class.
12724         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12725
12726 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12727
12728         * valops.c (find_overload_match): Remove use of null_cleanup, and
12729         calls to do_cleanups.
12730
12731 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12732
12733         * compile/compile-cplus-types.c
12734         (compile_cplus_instance::decl_name): Handle changes to
12735         cp_func_name.
12736         * cp-support.c (cp_func_name): Update header comment, update
12737         return type.
12738         * cp-support.h (cp_func_name): Update return type in declaration.
12739         * valops.c (find_overload_match): Move temp_func local to top
12740         level of function and change its type.  Use temp_func to hold and
12741         delete temporary string obtained from cp_func_name.
12742
12743 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12744
12745         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12746         gdb::char_vector, remove cleanup, and update uses of `msg`.
12747
12748 2019-01-03  Jim Wilson  <jimw@sifive.com>
12749
12750         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12751
12752 2019-01-02  Tom Tromey  <tom@tromey.com>
12753
12754         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12755         (tdesc_parse_xml): Remove cleanups.
12756         * target-descriptions.h (make_cleanup_free_target_description):
12757         Don't declare.
12758         (target_desc_deleter): New struct.
12759         (target_desc_up): New typedef.
12760         * target-descriptions.c (target_desc_deleter::operator()): Rename
12761         from free_target_description.
12762         (make_cleanup_free_target_description): Remove.
12763
12764 2019-01-02  Tom Tromey  <tom@tromey.com>
12765
12766         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12767         constructor, destructor.
12768         (linespec_parser): Remove typedef.
12769         (~linespec_parser): Rename from linespec_parser_delete.
12770         (linespec_lex_to_end, linespec_complete_label)
12771         (linespec_complete): Update.
12772         (decode_line_full): Remove cleanups.
12773         (decode_line_1): Update.
12774
12775 2019-01-02  Tom Tromey  <tom@tromey.com>
12776
12777         * python/python-internal.h (inferior_to_inferior_object): Change
12778         return type.
12779         * python/py-exitedevent.c (create_exited_event_object): Update.
12780         * python/py-inferior.c (inferior_to_inferior_object): Return
12781         gdbpy_ref.
12782         (python_new_inferior, python_inferior_deleted)
12783         (thread_to_thread_object, delete_thread_object)
12784         (build_inferior_list, gdbpy_selected_inferior): Update.
12785         * python/py-infthread.c (create_thread_object): Update.  Also fail
12786         if inferior_to_inferior_object fails.
12787
12788 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12789
12790         * inferior.h (class inferior) <displaced_step_state>: New field.
12791         * infrun.h (struct displaced_step_state): Move here from
12792         infrun.c.  Initialize fields, add constructor.
12793         <inf>: Remove field.
12794         <reset>: New method.
12795         * infrun.c (struct displaced_step_inferior_state): Move to
12796         infrun.h.
12797         (displaced_step_inferior_states): Remove.
12798         (get_displaced_stepping_state): Adust.
12799         (displaced_step_in_progress_any_inferior): Adjust.
12800         (displaced_step_in_progress_thread): Adjust.
12801         (displaced_step_in_progress): Adjust.
12802         (add_displaced_stepping_state): Remove.
12803         (get_displaced_step_closure_by_addr): Adjust.
12804         (remove_displaced_stepping_state): Remove.
12805         (infrun_inferior_exit): Call displaced_step_state.reset.
12806         (use_displaced_stepping): Don't check for NULL.
12807         (displaced_step_prepare_throw): Call
12808         get_displaced_stepping_state.
12809         (displaced_step_fixup): Don't check for NULL.
12810         (prepare_for_detach): Don't check for NULL.
12811
12812 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12813
12814         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12815          in case of call that did not complete.
12816
12817 2019-01-02  Andrey Utkin  <autkin@undo.io>
12818
12819         * symfile.c (find_separate_debug_file): Fix search of debug files for
12820         remote debuggee.
12821
12822 2019-01-02  Tom Tromey  <tom@tromey.com>
12823
12824         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12825         indentation.
12826         * python/py-frame.c (frapy_older): Remove cast.
12827         (frapy_newer): Likewise.
12828         * python/py-breakpoint.c (local_setattro): Remove cast.
12829         * python/py-arch.c (archpy_name): Remove local variable.
12830         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12831
12832 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12833
12834         * unittests/basic_string_view/element_access/char/empty.cc:
12835         Fix year range in copyright header.
12836
12837 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12838
12839         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12840         Delete.
12841         <operator==>: Update with for removed field.
12842         <hash>: Likewise.
12843         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12844         <isa_features>: ...this.
12845         <abi_features>: New field.
12846         (riscv_isa_flen): Update comment.
12847         (riscv_abi_xlen): New declaration.
12848         (riscv_abi_flen): New declaration.
12849         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12850         isa_features.
12851         (riscv_abi_xlen): New function.
12852         (riscv_isa_flen): Update to get answer from isa_features.
12853         (riscv_abi_flen): New function.
12854         (riscv_has_fp_abi): Update to get answer from abi_features.
12855         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12856         xlen and flen.
12857         (riscv_call_info) <xlen, flen>: Update comment.
12858         (riscv_call_arg_struct): Remove invalid assertions
12859         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12860         is removed.
12861         (riscv_gdbarch_init): Gather isa features and abi features
12862         separately, ensure both match on the gdbarch when reusing an old
12863         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12864         a target with 64-bit float hardware.
12865
12866 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12867
12868         * source.c (search_command_helper): Stop reverse search
12869         when line 1 has been searched.
12870
12871 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12872
12873         * record-full.c (record_full_base_target::close): Rewrite
12874         record_full_core_buf_list free logic.
12875
12876 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12877
12878         * break-catch-syscall.c (print_one_catch_syscall): xfree
12879         the last text.
12880
12881 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12882
12883         * top.c (print_gdb_version): Update Copyright year in version
12884         message.
12885
12886 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12887
12888         Update copyright year range in all GDB files.
12889
12890 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12891
12892         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12893
12894 For older changes see ChangeLog-2018.
12895 \f
12896 Local Variables:
12897 mode: change-log
12898 left-margin: 8
12899 fill-column: 74
12900 version-control: never
12901 coding: utf-8
12902 End:
12903