gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
   4
   5 2019-08-30  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
   8         call touchwin.
   9
  10 2019-08-30  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-wingeneral.c (box_win): Assume win_info and
  13         win_info->handle cannot be NULL.
  14
  15 2019-08-30  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  18         refresh_window>: Declare.
  19         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  20         resize.
  21         (tui_data_item_window::rerender): Rename from
  22         tui_display_register.
  23         (tui_data_item_window::refresh_window): New method.
  24         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  25         no-op.
  26
  27 2019-08-30  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  30         regs_column_count, current_group>: Move later.  Now private.
  31         <get_current_group>: New method.
  32         * tui/tui-regs.c (tui_reg_command): Update.
  33         * tui/tui-layout.c (tui_set_layout): Update.
  34
  35 2019-08-30  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  38         (tui_data_window::rerender): Don't call
  39         check_and_display_highlight_if_needed.
  40         (tui_data_window::refresh_all): Remove call to
  41         erase_data_content.
  42
  43 2019-08-30  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  46         (tui_data_window::display_registers_from)
  47         (tui_data_window::display_reg_element_at_line)
  48         (tui_data_window::display_registers_from_line): Remove checks of
  49         "empty".
  50
  51 2019-08-30  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  54         Don't declare.
  55         * tui/tui-regs.c (tui_data_window::show_registers): Call
  56         rerender.
  57         (tui_data_window::rerender): Rename from display_all_data.
  58         (tui_data_window::rerender): Remove old implementation.
  59
  60 2019-08-30  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  63         text.
  64         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  65
  66 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  67             Sergio Durigan Junior  <sergiodj@redhat.com>
  68
  69         PR win32/24284
  70         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  71
  72 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  75         when searching for types.
  76
  77 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  78
  79         * f-lang.c (f_language_defn): Use f_print_typedef.
  80         * f-lang.h (f_print_typedef): Declare.
  81         * f-typeprint.c (f_print_typedef): Define.
  82
  83 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  84
  85         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  86
  87 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * cli/cli-utils.c (info_print_options_defs): Delete.
  90         (make_info_print_options_def_group): Delete.
  91         (extract_info_print_options): Delete.
  92         (info_print_command_completer): Delete.
  93         (info_print_args_help): Add extra parameter, and optionally
  94         include text about -n flag.
  95         * cli/cli-utils.h (struct info_print_options): Delete.
  96         (extract_info_print_options): Delete declaration.
  97         (info_print_command_completer): Delete declaration.
  98         (info_print_args_help): Add extra parameter, extend header
  99         comment.
 100         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 101         search_symbols.
 102         * stack.c (struct info_print_options): New type.
 103         (info_print_options_defs): New file scoped variable.
 104         (make_info_print_options_def_group): New static function.
 105         (info_print_command_completer): New static function.
 106         (info_locals_command): Update to use new local functions.
 107         (info_args_command): Likewise.
 108         (_initialize_stack): Add extra parameter to calls to
 109         info_print_args_help.
 110         * symtab.c (search_symbols): Add extra parameter, use this to
 111         possibly excluse non-debug symbols.
 112         (symtab_symbol_info): Add extra parameter, which is passed on to
 113         search_symbols.
 114         (struct info_print_options): New type.
 115         (info_print_options_defs): New file scoped variable.
 116         (make_info_print_options_def_group): New static function.
 117         (info_print_command_completer): New static function.
 118         (info_variables_command): Update to use local functions, and pass
 119         extra parameter through to symtab_symbol_info.
 120         (info_functions_command): Likewise.
 121         (info_types_command): Pass additional argument through to
 122         symtab_symbol_info.
 123         (rbreak_command): Pass extra argument to search_symbols.
 124         (_initialize_symtab): Add extra arguments for calls to
 125         info_print_args_help, and update help text for 'info variables',
 126         'whereis', and 'info functions' commands.
 127         * symtab.h (search_symbols): Add extra argument to declaration.
 128         * NEWS: Mention new flags.
 129
 130 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 131
 132         * symtab.c (lookup_static_symbol): Call the new function (and move
 133         it down to be next to lookup_global_symbol).
 134         (struct global_sym_lookup_data): Add block_enum member and rename to...
 135         (struct global_or_static_sym_lookup_data): ...this.
 136         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 137         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 138         (lookup_symbol_global_or_static_iterator_cb): ...this.
 139         (lookup_global_or_static_symbol): New function.
 140         (lookup_global_symbol): Call new function.
 141
 142 2019-08-26  Tom de Vries  <tdevries@suse.de>
 143
 144         PR c++/24852
 145         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 146         when pc_probe.prob == NULL.
 147
 148 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 149
 150         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 151         variable symbol_linkage to symbol_linkage_.
 152
 153 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 154
 155         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 156         represent whether the symbol is static, dynamic, or we don't
 157         know.
 158
 159 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 160
 161         * gdb/rx-tdep.c (rx_register_names): New.
 162         (rx_register_name): Delete.
 163         (rx_psw_type): Delete.
 164         (rx_fpsw_type): Delete.
 165         (rx_register_type): Delete.
 166         (rx_gdbarch_init): Convert target-descriptions.
 167         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 168         * gdb/features/Makefile: Add rx.xml.
 169         * gdb/features/rx.xml: New.
 170         * gdb/features/rx.c: Generated.
 171         * gdb/NEWS: Mention target description support.
 172
 173 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 176         *slot_ptr.
 177
 178 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 179
 180         * configure.ac: Don't check for 'dlfcn.h' (moved to
 181         gdbsupport/common.m4).
 182         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 183         'gdbsupport/'.
 184         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 185         * compile/compile-c-support.c: Include
 186         'gdbsupport/gdb-dlfcn.h'.
 187         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 188         * gdb-dlfcn.c: Move to...
 189         * gdbsupport/gdb-dlfcn.c: ... here.
 190         * gdb-dlfcn.h: Move to...
 191         * gdbsupport/gdb-dlfcn.h: ... here.
 192
 193 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 194
 195         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 196         the offset field signed.
 197
 198 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 199
 200         * python/lib/gdb/__init__.py (_execute_file): New function.
 201         * python/python.c (python_run_simple_file): Call gdb._execute_file
 202         on Windows.
 203
 204 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 205
 206         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 207         all uses as this was never set to anything but a zero value.
 208
 209 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 210
 211         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 212
 213 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 214
 215         * tui/tui-data.h (tui_gen_win_info): Add an =default
 216         move constructor, required by some GCC versions.
 217
 218 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 219
 220         * go32-nat.c (go32_sysinfo): Add hygon_p.
 221
 222 2019-08-20  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 225         line_from_reg_element_no, first_reg_element_no_inline,
 226         display_all_data, delete_data_content_windows,
 227         erase_data_content>: Now private.
 228
 229 2019-08-20  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 232         (tui_unhighlight_win, tui_highlight_win)
 233         (tui_win_info::make_window): Update.
 234         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 235
 236 2019-08-20  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 239         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 240         (MAX_PID_WIDTH): Move to tui-stack.c.
 241         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 242         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 243         (MAX_PID_WIDTH): Move from tui-data.h.
 244
 245 2019-08-20  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 248         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 249         (box_win): Update.
 250         (tui_gen_win_info::make_window): Rename from tui_make_window.
 251         (tui_win_info::make_window): New method.
 252         (tui_gen_win_info::make_visible): Update.
 253         * tui/tui-source.c (tui_source_window::set_contents): Update.
 254         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 255         (tui_data_window::display_registers_from): Update.
 256         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 257         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 258         Declare.
 259         <can_box>: Remove.
 260         <title>: Remove.
 261         (struct tui_win_info) <make_window>: Declare.
 262         <can_box>: Now virtual.
 263         <title>: New member.
 264         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 265         * tui/tui-command.c (tui_cmd_window::resize): Update.
 266
 267 2019-08-20  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 270         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 271         (tui_data_window::check_register_values): Update.
 272
 273 2019-08-20  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-regs.h (struct tui_data_window): Use
 276         DISABLE_COPY_AND_ASSIGN.
 277         <regs_content>: Change type, removing unique_ptr.
 278         <tui_data_window>: Add move constructor.
 279         * tui/tui-regs.c (tui_data_window::show_registers)
 280         (tui_data_window::show_register_group)
 281         (tui_data_window::display_registers_from)
 282         (tui_data_window::display_registers_from)
 283         (tui_data_window::first_data_item_displayed)
 284         (tui_data_window::delete_data_content_windows)
 285         (tui_data_window::rerender, tui_data_window::refresh_window)
 286         (tui_data_window::check_register_values): Update.
 287
 288 2019-08-20  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 291         show_register_group>: Declare.
 292         (tui_show_register_group): Don't declare.
 293         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 294         tui_show_registers.
 295         (tui_data_window::show_register_group): Rename from
 296         tui_show_register_group.
 297         (tui_data_window::check_register_values, tui_reg_command):
 298         Update.
 299         * tui/tui-layout.c (tui_set_layout): Update.
 300
 301 2019-08-20  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 304         Declare.
 305         (tui_check_register_values): Don't declare.
 306         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 307         from tui_check_register_values.
 308         * tui/tui-hooks.c (tui_register_changed): Update.
 309
 310 2019-08-20  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-regs.c (tui_reg_layout): Move later.
 313         (tui_show_registers): Don't enable TUI mode or change layout.
 314
 315 2019-08-20  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-regs.h (struct tui_data_item_window)
 318         <~tui_data_item_window>: Remove.
 319         <content>: Now a unique_xmalloc_ptr.
 320         * tui/tui-regs.c (tui_register_format): Return a
 321         unique_xmalloc_ptr.
 322         (tui_get_register): Update.
 323         (~tui_data_item_window): Remove.
 324         (tui_data_window::display_registers_from, tui_display_register):
 325         Update.
 326         * tui/tui-io.h (tui_expand_tabs): Update.
 327         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 328         Remove "col" parameter.
 329
 330 2019-08-20  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 333         field.
 334         * tui/tui-regs.c (~tui_data_item_window): Update.
 335
 336 2019-08-20  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 339         earlier.
 340
 341 2019-08-20  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 344
 345 2019-08-20  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-source.h (struct tui_source_window): Update.
 348         * tui/tui-regs.c (tui_show_registers): Update.
 349         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 350         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 351         (NO_REGS_STRING): Remove defines.
 352
 353 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 354
 355         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 356         unnecessary thread walk if remote doesn't support the packet.
 357
 358 2019-08-19  Tom Tromey  <tromey@adacore.com>
 359
 360         * python/py-value.c (value_has_field): Fix indentation.
 361
 362 2019-08-19  Tom Tromey  <tromey@adacore.com>
 363
 364         * printcmd.c (do_one_display, info_display_command): Update.
 365         * block.h (contained_in): Return bool.  Add allow_nested
 366         parameter.
 367         * block.c (contained_in): Return bool.  Add allow_nested
 368         parameter.
 369
 370 2019-08-19  Tom Tromey  <tom@tromey.com>
 371
 372         * configure: Rebuild.
 373         * configure.ac: Disallow the combination of -static-libstdc++ and
 374         source highlight.
 375         * source-cache.c (get_language_name): Handle rust.
 376         (source_cache::get_source_lines): Ignore highlighting exceptions.
 377
 378 2019-08-16  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 381         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 382         (struct tui_source_window_base) <make_visible, refresh_window,
 383         resize>: Remove methods.
 384         <execution_info>: Remove field.
 385         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 386         (tui_show_source_line, tui_source_window_base)
 387         (~tui_source_window_base): Update.
 388         (tui_source_window_base::resize)
 389         (tui_source_window_base::make_visible)
 390         (tui_source_window_base::refresh_window): Remove.
 391         (tui_source_window_base::update_exec_info): Update.
 392         * tui/tui-source.c (tui_source_window::set_contents): Update.
 393         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 394
 395 2019-08-16  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 398         deprecated_query_hook.
 399
 400 2019-08-16  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 403         (tui_update_source_windows_with_line): Update.
 404         * tui/tui-source.h (struct tui_source_window)
 405         <show_symtab_source>: Declare.
 406         (tui_show_symtab_source): Don't declare.
 407         * tui/tui-source.c (tui_show_symtab_source): Rename from
 408         tui_show_symtab_source.
 409
 410 2019-08-16  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-winsource.h (struct tui_source_window_base)
 413         <set_contents>: Declare.
 414         * tui/tui-winsource.c
 415         (tui_source_window_base::update_source_window_as_is): Update.
 416         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 417         Declare.
 418         (tui_set_source_content): Don't declare.
 419         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 420         tui_set_source_content.
 421         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 422         Declare.
 423         (tui_set_disassem_content): Don't declare.
 424         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 425         tui_set_disassem_content.
 426
 427 2019-08-16  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-winsource.h (struct tui_source_window_base)
 430         <update_breakpoint_info>: Declare.
 431         (tui_update_breakpoint_info): Don't declare.
 432         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 433         (tui_update_all_breakpoint_info): Update.
 434         (tui_source_window_base::update_breakpoint_info): Rename from
 435         tui_update_breakpoint_info.
 436         (tui_source_window_base::update_exec_info): Update.
 437
 438 2019-08-16  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.h (struct tui_source_window_base)
 441         <update_source_window>: Declare.
 442         (tui_update_source_window): Don't declare.
 443         * tui/tui-winsource.c
 444         (tui_source_window_base::update_source_window): Rename from
 445         tui_update_source_window.
 446         (tui_source_window_base::rerender): Update.
 447         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 448         * tui/tui-disasm.c (tui_show_disassem)
 449         (tui_show_disassem_and_update_source)
 450         (tui_disasm_window::maybe_update): Update.
 451
 452 2019-08-16  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-winsource.h (struct tui_source_window_base)
 455         <update_source_window_as_is>: Declare.
 456         (tui_update_source_window_as_is): Don't declare.
 457         * tui/tui-winsource.c (tui_update_source_window): Update
 458         (tui_source_window_base::update_source_window_as_is): Rename from
 459         tui_update_source_window_as_is.
 460         (tui_source_window_base::refill): Update.
 461         * tui/tui-source.c (tui_show_symtab_source): Update.
 462         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 463         Update.
 464
 465 2019-08-16  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-winsource.h (tui_update_source_window)
 468         (tui_update_source_window_as_is): Remove "noerror" parameter.
 469         * tui/tui-winsource.c (tui_update_source_window)
 470         (tui_update_source_window_as_is): Remove "noerror" parameter.
 471         (tui_update_source_windows_with_addr)
 472         (tui_update_source_windows_with_line)
 473         (tui_source_window_base::rerender)
 474         (tui_source_window_base::refill): Update.
 475         * tui/tui-source.h (tui_set_source_content)
 476         (tui_show_symtab_source): Remove "noerror" parameter.
 477         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 478         parameter.
 479         (tui_show_symtab_source): Likewise.
 480         (tui_source_window::maybe_update): Update.
 481         * tui/tui-disasm.c (tui_show_disassem)
 482         (tui_show_disassem_and_update_source)
 483         (tui_disasm_window::do_scroll_vertical)
 484         (tui_disasm_window::maybe_update): Update.
 485
 486 2019-08-16  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui.c (tui_is_window_visible): Update.
 489         * tui/tui-wingeneral.c (tui_make_window)
 490         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 491         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 492         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 493         (tui_set_win_height_command, parse_scrolling_args): Update.
 494         * tui/tui-source.c (tui_source_window::style_changed): Update.
 495         * tui/tui-regs.c (tui_show_registers)
 496         (tui_data_window::first_data_item_displayed)
 497         (tui_data_window::delete_data_content_windows)
 498         (tui_check_register_values, tui_reg_command): Update.
 499         * tui/tui-disasm.c (tui_show_disassem): Update.
 500         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 501         method.
 502         <is_visible>: Remove field.
 503         * tui/tui-data.c (tui_next_win, tui_prev_win)
 504         (tui_delete_invisible_windows): Update.
 505
 506 2019-08-16  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-winsource.h (struct tui_source_window_base)
 509         <m_has_locator>: Remove.
 510         * tui/tui-layout.c (show_source_disasm_command, show_data)
 511         (show_source_or_disasm_and_command): Update.
 512
 513 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 514
 515         * NEWS (Other MI changes): New subsection.
 516         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 517         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 518         * arch-utils.c (default_get_pc_address_flags): New function.
 519         * arch-utils.h (default_get_pc_address_flags): New declaration.
 520         * gdbarch.sh: Add get_pc_address_flags.
 521         * gdbarch.c: Regenerate.
 522         * gdbarch.h: Likewise.
 523         * stack.c (print_pc): New function.
 524         (print_frame_info) (print_frame): Call print_pc.
 525
 526 2019-08-16  Tom de Vries  <tdevries@suse.de>
 527
 528         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 529         print_objfile_section_info.
 530
 531 2019-08-15  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 534         calling update_cmdwin_start_line.
 535         * tui/tui-winsource.h (struct tui_source_window_base)
 536         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 537         <rerender>: Declare.
 538         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 539         Call rerender.
 540         (tui_source_window_base::set_new_height): Remove.
 541         (tui_source_window_base::rerender): Rename from
 542         do_make_visible_with_new_height.
 543         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 544         resize method.
 545         (tui_win_info::make_invisible_and_set_new_height)
 546         (tui_win_info::make_visible_with_new_height): Remove.
 547         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 548         Declare.
 549         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 550         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 551         do_make_visible_with_new_height>: Don't declare.
 552         <rerender>: Declare.
 553         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 554         set_new_height.
 555         (tui_data_window::do_make_visible_with_new_height): Remove.
 556         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 557         call tui_show_locator_content.
 558         (tui_gen_win_info::resize): Call rerender.
 559         (show_source_or_disasm_and_command): Don't call
 560         tui_show_locator_content.
 561         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 562         method.
 563         (struct tui_win_info) <rerender>: Declare.
 564         <set_new_height, make_invisible_and_set_new_height,
 565         make_visible_with_new_height>: Don't declare.
 566         * tui/tui-data.c (tui_win_list::rerender): New method.
 567         * tui/tui-command.h (struct tui_cmd_window)
 568         <do_make_visible_with_new_height>: Don't declare.
 569         * tui/tui-command.c
 570         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 571
 572 2019-08-15  Tom Tromey  <tromey@adacore.com>
 573
 574         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 575         * ada-lang.c (ada_enum_name): Likewise.
 576
 577 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 578
 579         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 580         leading underscore.
 581         (GdbOutputErrorFile): Likewise.
 582         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 583         accordingly.
 584         (execute_unwinders): Rename to have a leading underscore.
 585         (auto_load_packages): Likewise.
 586         (global scope): Adjust call to auto_load_packages accordingly.
 587         (GdbSetPythonDirectory): Likewise.
 588         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 589         instead of execute_unwinders.
 590
 591 2019-08-15  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 594         (show_data): Don't change window visibility.
 595         (tui_gen_win_info::resize): Remove special case for command
 596         window.  Use wresize, when available.
 597         (show_source_or_disasm_and_command): Don't change window
 598         visibility.
 599         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 600         <make_visible>: New method.
 601         * tui/tui-command.c (tui_cmd_window::resize): New method.
 602
 603 2019-08-15  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 606         (struct tui_source_windows): New.
 607         * tui/tui-winsource.c (tui_display_main): Update.
 608         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 609         (new_height_ok, parse_scrolling_args): Update.
 610         * tui/tui-layout.c (show_layout, show_data): Update.
 611         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 612         (tui_add_to_source_windows): Don't declare.
 613         * tui/tui-data.c (source_windows, tui_source_windows)
 614         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 615
 616 2019-08-15  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 619         Rename from reset.
 620         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 621         * tui/tui-layout.c (show_source_disasm_command, show_data):
 622         Update.
 623         (tui_gen_win_info::resize): Rename.
 624         (show_source_or_disasm_and_command): Update.
 625         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 626         reset.
 627
 628 2019-08-15  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 631         * tui/tui-interp.c (tui_interp::init): Don't call
 632         tui_initialize_static_data.
 633         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 634
 635 2019-08-15  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 638         examine tui_win_list.
 639
 640 2019-08-15  Tom Tromey  <tom@tromey.com>
 641
 642         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 643         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 644         tui_clear_source_content.
 645         (tui_clear_source_content): Remove.
 646         (tui_source_window_base::do_erase_source_content): Hoist call to
 647         content.clear().
 648         * tui/tui-stack.c (tui_show_frame_info): Don't call
 649         tui_clear_source_content.
 650
 651 2019-08-15  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-winsource.h (struct tui_source_window_base)
 654         <do_erase_source_content>: New method.
 655         <erase_source_content>: New method.
 656         (tui_erase_source_content): Don't declare.
 657         * tui/tui-winsource.c (tui_clear_source_content): Update.
 658         (tui_source_window_base::do_erase_source_content): Rename from
 659         tui_erase_source_content.
 660         (tui_source_window_base::show_source_content): Update.
 661         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 662         * tui/tui-source.h (struct tui_source_window)
 663         <erase_source_content>: New method.
 664         * tui/tui-disasm.h (struct tui_disasm_window)
 665         <erase_source_content>: New method.
 666
 667 2019-08-15  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 670         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 671         constructor.
 672         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 673         * tui/tui-source.c (tui_set_source_content): Update.
 674         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 675
 676 2019-08-15  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 679         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 680         tui-source.c.
 681         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 682         Declare.
 683         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 684         method.
 685         (tui_source_window::maybe_update): Update.
 686
 687 2019-08-15  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 690         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 691         tui-disasm.c.
 692         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 693         Declare.
 694         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 695         method.
 696         (tui_disasm_window::maybe_update): Update.
 697
 698 2019-08-15  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-winsource.h (struct tui_source_window_base)
 701         <maybe_update>: Declare.
 702         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 703         method.
 704         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 705         Declare.
 706         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 707         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 708         Declare.
 709         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 710
 711 2019-08-15  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 714
 715 2019-08-15  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-wingeneral.c: Include tui-stack.h.
 718         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 719         (struct tui_locator_window): Move from tui-data.h.
 720         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 721         (tui_initialize_static_data): Move from tui-data.c.
 722         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 723         (struct tui_locator_window): Move to tui-stack.c.
 724         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 725         (tui_initialize_static_data): Move to tui-stack.c.
 726
 727 2019-08-15  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-layout.c (show_source_disasm_command)
 730         (show_source_or_disasm_and_command): Use make_visible method, not
 731         tui_make_window.
 732         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 733         Remove.
 734
 735 2019-08-15  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-wingeneral.h (tui_make_window): Update.
 738         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 739         parameter.
 740         (tui_gen_win_info::make_visible): Update.
 741         * tui/tui-regs.c (tui_data_window::display_registers_from):
 742         Update.
 743         * tui/tui-layout.c (show_source_disasm_command)
 744         (show_source_or_disasm_and_command): Update.
 745         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 746         (enum tui_box): Remove.
 747         (struct tui_win_info) <can_box>: New method.
 748         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 749         method.
 750
 751 2019-08-15  Tom de Vries  <tdevries@suse.de>
 752
 753         * linux-nat-trad.c: Include gdbarch.h.
 754
 755 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 756
 757         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 758         register sizes.
 759
 760 2019-08-14  Tom Tromey  <tromey@adacore.com>
 761
 762         * darwin-nat.c: Include gdbarch.h.
 763         * darwin-nat-info.c: Include gdbarch.h.
 764
 765 2019-08-13  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 768         Remove.
 769         * tui/tui-data.c (tui_initialize_static_data): Update.
 770
 771 2019-08-13  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-winsource.h (struct tui_exec_info_window)
 774         <~tui_exec_info_window, maybe_allocate_content, get_content,
 775         m_content>: Remove.
 776         (struct tui_source_window_base) <set_exec_info_content,
 777         show_exec_info_content>: Don't declare.
 778         * tui/tui-winsource.c
 779         (tui_exec_info_window::maybe_allocate_content): Remove.
 780         (tui_source_window_base::update_exec_info): Rename from
 781         set_exec_info_content.
 782         (tui_source_window_base::show_exec_info_content)
 783         (tui_source_window_base::update_exec_info): Remove.
 784
 785 2019-08-13  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 788         declare.
 789         * tui/tui-winsource.c (tui_update_source_window_as_is)
 790         (tui_update_source_windows_with_addr, tui_erase_source_content):
 791         Update.
 792         (tui_clear_exec_info_content): Remove.
 793
 794 2019-08-13  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 797         declare.
 798         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 799         call tui_erase_exec_info_content.
 800         (tui_clear_exec_info_content): Rename from
 801         tui_erase_exec_info_content.
 802         (tui_clear_exec_info_content): Delete.
 803
 804 2019-08-13  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-winsource.h (struct tui_source_window_base)
 807         <show_exec_info_content>: Declare.
 808         (tui_show_exec_info_content): Don't declare.
 809         * tui/tui-winsource.c
 810         (tui_source_window_base::show_exec_info_content): Rename from
 811         tui_show_exec_info_content.
 812         (tui_source_window_base::update_exec_info): Update.
 813
 814 2019-08-13  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 817         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 818         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 819         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 820         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 821         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 822         ... here.
 823
 824 2019-08-13  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-winsource.h (struct tui_source_window_base)
 827         <update_exec_info>: Declare.
 828         (tui_update_exec_info): Don't declare.
 829         * tui/tui-winsource.c (tui_update_source_window_as_is)
 830         (tui_source_window_base::refresh_all)
 831         (tui_update_all_breakpoint_info): Update.
 832         (tui_source_window_base::update_exec_info): Rename from
 833         tui_update_exec_info.
 834         * tui/tui-stack.c (tui_show_frame_info): Update.
 835
 836 2019-08-13  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-winsource.h (struct tui_source_window_base)
 839         <set_exec_info_content>: Declare.
 840         (tui_set_exec_info_content): Don't declare.
 841         * tui/tui-winsource.c
 842         (tui_source_window_base::set_exec_info_content): Rename from
 843         tui_set_exec_info_content.
 844         (tui_update_exec_info): Update.
 845
 846 2019-08-13  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-winsource.h (struct tui_source_window_base)
 849         <show_source_content>: Declare.
 850         (tui_show_source_content): Don't declare.
 851         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 852         (tui_source_window_base::show_source_content): Rename from
 853         tui_show_source_content.
 854         (tui_source_window_base::refresh_all): Update.
 855         * tui/tui-layout.c (show_source_disasm_command)
 856         (show_source_or_disasm_and_command): Update.
 857
 858 2019-08-13  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-winsource.c (tui_erase_source_content)
 861         (tui_show_source_content, tui_source_window_base::refresh_all):
 862         Update.
 863         * tui/tui-wingeneral.h
 864         (tui_check_and_display_highlight_if_needed): Don't declare.
 865         * tui/tui-wingeneral.c
 866         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 867         check_and_display_highlight_if_needed.
 868         * tui/tui-win.c (tui_rehighlight_all)
 869         (tui_win_info::make_visible_with_new_height): Update.
 870         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 871         (tui_data_window::erase_data_content)
 872         (tui_data_window::display_all_data): Update.
 873         * tui/tui-data.h (struct tui_win_info)
 874         <check_and_display_highlight_if_needed>: Declare.
 875
 876 2019-08-13  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-win.c (tui_resize_all): Call
 879         tui_delete_invisible_windows.
 880         * tui/tui-layout.c (show_layout): Call
 881         tui_delete_invisible_windows.
 882         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 883         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 884
 885 2019-08-13  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 888         tui_add_win_to_layout.
 889
 890 2019-08-13  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 893         * tui/tui-layout.c (tui_default_win_height): Now static.
 894
 895 2019-08-13  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 898         single switch.
 899         (show_source_disasm_command, show_source_or_disasm_and_command):
 900         Don't check current layout.
 901
 902 2019-08-13  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-wingeneral.c (make_all_visible): Remove.
 905         (tui_make_all_invisible): Simplify.
 906         * tui/tui-layout.c (tui_make_all_invisible): Move from
 907         tui-wingeneral.c; simplify.
 908         (show_layout): Hoist call to tui_make_all_invisible.
 909         (show_data): Don't call tui_make_all_invisible.
 910
 911 2019-08-13  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 914         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 915
 916 2019-08-13  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 919         tui-data.c.
 920         (show_source_disasm_command, show_data)
 921         (show_source_or_disasm_and_command): Don't use
 922         tui_set_current_layout_to.
 923         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 924         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 925         tui-layout.c.
 926         (tui_set_current_layout_to): Remove.
 927
 928 2019-08-13  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-layout.c (tui_set_layout): Update.
 931         * tui/tui-data.h (struct tui_layout_def): Remove.
 932         (tui_layout_def): Don't declare.
 933         * tui/tui-data.c (layout_def): Remove.
 934         (tui_layout_def): Remove.
 935
 936 2019-08-13  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-winsource.h (struct tui_source_window_base)
 939         <clear_detail>: No longer "override".
 940         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 941         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 942         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 943         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 944         Remove.
 945         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 946
 947 2019-08-13  Tom Tromey  <tromey@adacore.com>
 948
 949         * tracepoint.c: Don't include readline.h or history.h.
 950
 951 2019-08-12  Tom Tromey  <tom@tromey.com>
 952
 953         * configure: Rebuild.
 954         * configure.ac: Check for readline 7.
 955         * NEWS: Mention readline 7 requirement.
 956         * README: Update.
 957
 958 2019-08-12  Tom Tromey  <tom@tromey.com>
 959
 960         * mingw-hdep.c (gdb_select): Remove readline hack.
 961
 962 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 963
 964         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 965         when the function fails.
 966
 967 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 968
 969         * s390-tdep.c (s390_type_align): New function.
 970         (s390_gdbarch_init): Set it as type_align gdbarch method.
 971
 972 2019-08-09  Tom de Vries  <tdevries@suse.de>
 973
 974         PR gdb/24591
 975         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 976         pc_low with relocation offset.
 977
 978 2019-08-07  Tom Tromey  <tromey@adacore.com>
 979
 980         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 981         (print_frame_args): Update.
 982         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 983         Update.
 984         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 985         * frame.h (struct frame_arg): Add initializers.
 986         <error>: Now a unique_xmalloc_ptr.
 987
 988 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 989
 990         * NEWS: Expand the Pointer Authentication entry.
 991         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 992         (aarch64_frame_unmask_lr): ... to this.
 993         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 994         Call aarch64_frame_unmask_lr.
 995         * frame.c (struct frame_info): Add "masked" variable.
 996         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 997         (fprint_frame): Check for masked pc.
 998         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 999         declarations.
1000         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1001         * stack.c (print_frame): Check for masked pc.
1002
1003 2019-08-06  Tom Tromey  <tom@tromey.com>
1004
1005         * stabsread.c (patch_block_stabs, read_one_struct_field)
1006         (read_enum_type): Use obstack_strndup.
1007         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1008         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1009         * dwarf2read.c (guess_full_die_structure_name)
1010         (anonymous_struct_prefix): Use obstack_strndup.
1011         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1012         * c-exp.y (yylex): Use obstack_strndup.
1013         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1014         (write_var_or_type): Use obstack_strndup.
1015
1016 2019-08-06  Tom Tromey  <tom@tromey.com>
1017
1018         * symfile.c (reread_symbols): Use obstack_strdup.
1019         * stabsread.c (read_type): Use obstack_strdup.
1020         * gdb_obstack.h (obstack_strdup): New overload.
1021         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1022         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1023         (dwarf2_canonicalize_name): Use obstack_strdup.
1024         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1025         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1026         Use obstack_strdup.
1027
1028 2019-08-06  Tom Tromey  <tom@tromey.com>
1029
1030         * gdb_obstack.h (obstack_strdup): Define.
1031         * gdb_obstack.c (obstack_strdup): Don't define.
1032
1033 2019-08-06  Tom Tromey  <tom@tromey.com>
1034
1035         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1036         obstack_strdup.
1037         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1038         obstack_strdup.
1039         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1040         * stabsread.c (common_block_start): Use obstack_strdup.
1041         * objfiles.c (set_objfile_main_name, objfile): Use
1042         obstack_strdup.
1043         * namespace.c (add_using_directive): Use obstack_strdup.
1044         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1045         * jit.c (finalize_symtab): Use obstack_strdup.
1046         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1047         (guess_partial_die_structure_name, partial_die_info::fixup)
1048         (dwarf2_name): Use obstack_strdup.
1049         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1050         obstack_strdup.
1051         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1052         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1053         obstack_strdup.
1054         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1055
1056 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1057
1058         * unittests/help-doc-selftests.c: New file.
1059         * Makefile.in: Add the new file.
1060
1061 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1062
1063         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1064         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1065         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1066         the trailing '.' is not output, and the first character is uppercased.
1067         (print_help_for_command): Update call to print_doc_line.
1068         (print_doc_of_command): Likewise.
1069         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1070         * cli/cli-option.c (append_indented_doc): Do not append newline.
1071         (build_help_option): Append newline after first appended_indented_doc
1072         only if a second call is done.
1073         (build_help): Append 2 new lines before each option, except the first
1074         one.
1075         * compile/compile.c (_initialize_compile): Add new lines after
1076         %OPTIONS%, when not at the end of the help.
1077         Change help doc or code
1078         producing the help doc to respect the invariants.
1079         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1080         Also removed the new line after 'Options:', as all other commands
1081         do not put an empty line between 'Options:' and the first option.
1082         * printcmd.c (_initialize_printcmd): Likewise.
1083         * stack.c (_initialize_stack): Likewise.
1084         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1085         incorrectly telling COMMAND is optional.
1086         * ada-lang.c (_initialize_ada_language): Change help doc or code
1087         producing the help doc to respect the invariants.
1088         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1089         * breakpoint.c (_initialize_breakpoint): Likewise.
1090         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1091         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1092         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1093         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1094         _initialize_cli_style): Likewise.
1095         * corelow.c (core_target_info): Likewise.
1096         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1097         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1098         * filesystem.c (_initialize_filesystem): Likewise.
1099         * frame.c (_initialize_frame): Likewise.
1100         * gnu-nat.c (add_task_commands): Likewise.
1101         * infcall.c (_initialize_infcall): Likewise.
1102         * infcmd.c (_initialize_infcmd): Likewise.
1103         * interps.c (_initialize_interpreter): Likewise.
1104         * language.c (_initialize_language): Likewise.
1105         * linux-fork.c (_initialize_linux_fork): Likewise.
1106         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1107         * maint.c (_initialize_maint_cmds): Likewise.
1108         * memattr.c (_initialize_mem): Likewise.
1109         * printcmd.c (_initialize_printcmd): Likewise.
1110         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1111         _RegEx): Likewise.
1112         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1113         * record-btrace.c (_initialize_record_btrace): Likewise.
1114         * record-full.c (_initialize_record_full): Likewise.
1115         * record.c (_initialize_record): Likewise.
1116         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1117         * regcache.c (_initialize_regcache): Likewise.
1118         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1119         _initialize_remote): Likewise.
1120         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1121         * serial.c (_initialize_serial): Likewise.
1122         * skip.c (_initialize_step_skip): Likewise.
1123         * source.c (_initialize_source): Likewise.
1124         * stack.c (_initialize_stack): Likewise.
1125         * symfile.c (_initialize_symfile): Likewise.
1126         * symtab.c (_initialize_symtab): Likewise.
1127         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1128         * top.c (init_main): Likewise.
1129         * tracefile-tfile.c (tfile_target_info): Likewise.
1130         * tracepoint.c (_initialize_tracepoint): Likewise.
1131         * tui/tui-win.c (_initialize_tui_win): Likewise.
1132         * utils.c (add_internal_problem_command): Likewise.
1133         * valprint.c (value_print_option_defs): Likewise.
1134
1135 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1136
1137         PR build/24886
1138         * configure.ac: Drop enable-libmcheck support.
1139         * configure, config.in: Rebuild.
1140         * libmcheck.m4: Remove.
1141         * acinclude.m4: Don't include it.
1142         * Makefile.in: Don't distribute it.
1143         * top.c (print_gdb_configuration): Don't mention it.
1144
1145 2019-08-06  Tom Tromey  <tom@tromey.com>
1146
1147         * utils.c (set_output_style): Sometimes pass stream to
1148         emit_style_escape.
1149         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1150         * record-btrace.c (btrace_insn_history): Update.
1151         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1152         method.
1153         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1154         Update initializers.
1155         <m_uiout>: New field.
1156         <m_di>: Move lower.
1157         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1158         Remove "uiout" parameter.
1159         (dump_insns): Update.
1160         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1161         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1162
1163 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1164
1165         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1166         (error_in_psymtab_expansion): Likewise.
1167         (lookup_symbol_via_quick_fns): Likewise.
1168         (basic_lookup_transparent_type_quick): Likewise.
1169         (basic_lookup_transparent_type_1): Likewise.
1170
1171 2019-08-06  Tom Tromey  <tromey@adacore.com>
1172
1173         * source.c (last_source_error): Now bool.
1174         (print_source_lines_base): Make "noprint" bool.  Only open
1175         source file when last_source_visited changes.
1176
1177 2019-08-06  Tom Tromey  <tromey@adacore.com>
1178
1179         * annotate.c (annotate_source_line): Use g_source_cache.
1180         * source-cache.c (source_cache::get_plain_source_lines): Change
1181         parameters.  Populate m_offset_cache.
1182         (source_cache::ensure): New method.
1183         (source_cache::get_line_charpos): New method.
1184         (extract_lines): Move lower.  Change parameters.
1185         (source_cache::get_source_lines): Move lower.
1186         * source-cache.h (class source_cache): Update comment.
1187         <get_line_charpos>: New method.
1188         <get_source_lines>: Update comment.
1189         <clear>: Clear m_offset_cache.
1190         <get_plain_source_lines>: Change parameters.
1191         <ensure>: New method
1192         <m_offset_cache>: New member.
1193         * source.c (forget_cached_source_info_for_objfile): Update.
1194         (info_source_command): Use g_source_cache.
1195         (find_source_lines, open_source_file_with_line_charpos): Remove.
1196         (print_source_lines_base, search_command_helper): Use g_source_cache.
1197         * source.h (open_source_file_with_line_charpos): Don't declare.
1198         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1199         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1200         Use g_source_cache.
1201
1202 2019-08-06  Tom Tromey  <tromey@adacore.com>
1203
1204         * source-cache.c (source_cache::get_plain_source_lines):
1205         Remove "first_line" and "last_line" parameters.
1206         (source_cache::get_source_lines): Cache plain text.
1207         * source-cache.h (class source_cache)
1208         <get_plain_source_lines>: Update.
1209
1210 2019-08-06  Tom Tromey  <tromey@adacore.com>
1211
1212         * source-cache.c (extract_lines): No longer a method.
1213         Changed type of parameter.  Include final newline.
1214         (selftests::extract_lines_test): New function.
1215         (_initialize_source_cache): Likewise.
1216         * source-cache.h (class source_cache)
1217         <extract_lines>: Don't declare.
1218
1219 2019-08-06  Tom Tromey  <tromey@adacore.com>
1220
1221         * breakpoint.c (init_breakpoint_sal): Update.
1222         (breakpoint): Update.
1223         * breakpoint.h (struct breakpoint) <filter>: Now a
1224         unique_xmalloc_ptr.
1225
1226 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1227
1228         * NEWS: Mention dictionary access on blocks.
1229         * python/py-block.c (blpy_getitem): New function.
1230         (block_object_as_mapping): New struct.
1231         (block_object_type): Use new struct for tp_as_mapping field.
1232
1233 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1234
1235         * objfiles.h (objfile): Add a comment describing partial symbols.
1236
1237 2019-08-05  Tom Tromey  <tromey@adacore.com>
1238
1239         * compile/compile.c (_initialize_compile): Use _(), not N_().
1240         * thread.c (_initialize_thread): Use _(), not N_().
1241         * stack.c (_initialize_stack): Use _(), not N_().
1242         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1243
1244 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1245
1246         * dwarf2read.c (struct dw2_symtab_iterator):
1247         <want_specific_block>: Remove.
1248         <block_index>: Change type to gdb::optional.
1249         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1250         change type of BLOCK_INDEX parameter to gdb::optional.
1251         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1252         (dw2_lookup_symbol): Don't pass argument for
1253         WANT_SPECIFIC_BLOCK.
1254         (dw2_expand_symtabs_for_function): Don't pass argument for
1255         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1256         (class dw2_debug_names_iterator)
1257         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1258         parameter, change BLOCK_INDEX type to gdb::optional.
1259         <m_want_specific_block>: Remove.
1260         <m_block_index>: Change type to gdb::optional.
1261         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1262         gdb::optional.  Re-write in function of gdb::optional.
1263         (dw2_debug_names_lookup_symbol): Don't pass argument for
1264         WANT_SPECIFIC_BLOCK.
1265         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1266         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1267         BLOCK_INDEX.
1268
1269 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1270
1271         * NEWS: Mention changes to "info sources" command.
1272
1273 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1274
1275         * symtab.c (filename_partial_match_opts): New struct type.
1276         (struct output_source_filename_data): New members
1277         regexp, c_regexp, partial_match.
1278         (output_source_filename): Use new members to decide to print file.
1279         (info_sources_option_defs): New variable.
1280         (make_info_sources_options_def_group, print_info_sources_header,
1281         info_sources_command_completer):
1282         New functions.
1283         (info_sources_command): Read new optional arguments.
1284         (_initialize_symtab): Update info sources help.
1285
1286 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1287
1288         * ada-lang.c (exception_support_info_v0): Renamed from...
1289         (default_exception_support_info): ... this.  Create new
1290         definition for v1.
1291         (ada_has_this_exception_support): Look up catch_handlers_sym.
1292         (ada_exception_support_info_sniffer): Try v0 after default.
1293
1294 2019-08-01  Tom Tromey  <tromey@adacore.com>
1295
1296         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1297         gdbarch.h.
1298
1299 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1300
1301         * s12z-tdep.c: Fix include path for s12z-opc.h.
1302
1303 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1304
1305         * NEWS: Require GNU make 3.82.
1306
1307 2019-07-16  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1310         declare.
1311
1312 2019-07-30  Tom Tromey  <tromey@adacore.com>
1313
1314         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1315
1316 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1317
1318         * printcmd.c (print_address_symbolic): Print negative offsets.
1319         (build_address_symbolic): Force signed arithmetic when computing
1320         offset.
1321
1322 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1323
1324         PR/24474: Add a function to lookup static variables.
1325         * NEWS: Mention this new function.
1326         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1327         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1328         * python/python.c (python_GdbMethods): Add new function.
1329
1330 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1331
1332         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1333         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1334         (objfpy_lookup_static_symbol): New function.
1335         (objfile_object_methods): Add new functions.
1336
1337 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1338
1339         * NEWS: Mention 'set|show print frame-info'.  Mention new
1340         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1341         backtrace argument.  Mention that python frame filtering code
1342         is now consistent with what 'backtrace' command prints.
1343
1344 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1345
1346         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1347         comments.
1348         (print_frame_info_auto, print_frame_info_source_line,
1349         print_frame_info_location, print_frame_info_source_and_location,
1350         print_frame_info_location_and_address, print_frame_info_short_location):
1351         New declarations.
1352         (struct frame_print_options): New member print_frame_info.
1353         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1354         * stack.h (get_user_print_what_frame_info): New declaration.
1355         (frame_show_address): New declaration.
1356         * stack.c (print_frame_arguments_choices): New value 'presence'.
1357         (print_frame_info_auto, print_frame_info_source_line,
1358         print_frame_info_location, print_frame_info_source_and_location,
1359         print_frame_info_location_and_address, print_frame_info_short_location,
1360         print_frame_info_choices, print_frame_info_print_what): New definitions.
1361         (print_frame_args): Only print dots for args if print frame-arguments
1362         is 'presence'.
1363         (frame_print_option_defs): New element for "frame-info".
1364         (get_user_print_what_frame_info): New function.
1365         (frame_show_address): Make non static.  Move comment to stack.h.
1366         (print_frame_info_to_print_what): New function.
1367         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1368         to decide what to print.
1369         (backtrace_command_1): Handle the new print_frame_arguments_presence
1370         value.
1371         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1372         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1373         (py_print_frame): In non-mi mode, use LOCATION as default for
1374         print_what, similarly to frame information printed directly by
1375         backtrace command. Handle frame-info user option in non MI mode.
1376
1377 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1378
1379         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1380         Add case for debugging 32-bit target on 64-bit host.  Revise
1381         comment.
1382
1383 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1384
1385         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1386         instead of find_function_entry_range_from_pc.
1387
1388 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1389
1390         * stack.c (find_frame_funname): Remove code which preferred
1391         minsym over symtab sym in "certain pathological cases".
1392
1393         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1394         parameter.  Change type of "do_demangle" to bool.
1395         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1396         Pass suitable "prefer_sym_over_minsym" flag to
1397         build_address_symbolic().  Don't output "+" for negative offsets.
1398         * printcmd.c (print_address_symbolic): Update invocation of
1399         build_address_symbolic to include a "prefer_sym_over_minsym"
1400         flag.
1401         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1402         Restrict cases in which use of minimal symbol is preferred to that
1403         of a found symbol.  Update comments.
1404
1405         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1406         for entry pc when entry pc is out of range for that FDE.
1407
1408 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1409
1410         PR gdb/24839:
1411         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1412         type.
1413
1414 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1415
1416         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1417         this function's Python signature.
1418
1419
1420 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1421
1422         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1423         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1424         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1425         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1426         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1427
1428
1429 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1430
1431         * h8300-tdep.c (h8300_register_name_common): New.
1432         h8300_register_name): Use h8300_register_name_common.
1433         (h8300s_register_name): Likewise.
1434         (h8300sx_register_name): Likewise.
1435         (h8300h_register_nam): New.
1436         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1437
1438
1439 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1440
1441         * arm-tdep.c (arm_skip_cmse_entry): New function.
1442         (arm_is_sgstubs_section): New function.
1443         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1444
1445 2019-07-22  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1448         Don't self-assign.
1449
1450 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1453         type_print.
1454
1455 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1458         so that GDB doesn't match any msymbols when searching in the
1459         TYPES_DOMAIN.
1460         (print_symbol_info): Print using typedef_print or type_print based
1461         on the type of the symbol.  Add updated FIXME comment moved from...
1462         (_initialize_symtab): ... move and update FIXME comment to above.
1463
1464 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1465
1466         * NEWS: Mention adding -q option to "info types".
1467         * symtab.c (struct info_types_options): New struct.
1468         (info_types_options_defs): New variable.
1469         (make_info_types_options_def_group): New function.
1470         (info_types_command): Use gdb::option framework to parse options.
1471         (info_types_command_completer): New function.
1472         (_initialize_symtab): Extend the help text on "info types" and
1473         register command completer.
1474
1475 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1476
1477         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1478         (lookup_symbol_in_objfile): Change int to block_enum and add a
1479         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1480
1481 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1482
1483         * MAINTAINERS (Write After Approval): Add self.
1484
1485 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1486
1487         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1488         instruction to the dummy code region.
1489
1490 2019-07-19  Tom Tromey  <tromey@adacore.com>
1491
1492         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1493         (ARGSUSED, PARAMS, __func__): Remove rules.
1494
1495 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1496
1497         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1498         * features/arm/arm-with-iwmmxt.c: Remove.
1499         * features/arm/arm-with-iwmmxt.xml: Remove.
1500         * features/arm/arm-with-m-fpa-layout.c: Remove.
1501         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1502         * features/arm/arm-with-m-vfp-d16.c: Remove.
1503         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1504         * features/arm/arm-with-m.c: Remove.
1505         * features/arm/arm-with-m.xml: Remove.
1506         * features/arm/arm-with-neon.c: Remove.
1507         * features/arm/arm-with-neon.xml: Remove.
1508         * features/arm/arm-with-vfpv2.c: Remove.
1509         * features/arm/arm-with-vfpv2.xml: Remove.
1510         * features/arm/arm-with-vfpv3.c: Remove.
1511         * features/arm/arm-with-vfpv3.xml: Remove.
1512
1513 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1514
1515         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1516
1517 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1518
1519         * arch/aarch32.c (aarch32_create_target_description): Create
1520         target descriptions using features.
1521         * arch/arm.c (arm_create_target_description)
1522         (arm_create_mprofile_target_description): Likewise.
1523         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1524
1525 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1526
1527         * Makefile.in: Add new files.
1528         * aarch32-tdep.c: New file.
1529         * aarch32-tdep.h: New file.
1530         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1531         Call aarch32_read_description.
1532         * arch/aarch32.c: New file.
1533         * arch/aarch32.h: New file.
1534         * arch/arm.c (arm_create_target_description)
1535         (arm_create_mprofile_target_description): New function.
1536         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1537         (arm_create_target_description)
1538         (arm_create_mprofile_target_description): New declaration.
1539         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1540         read_description functions.
1541         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1542         Likewise.
1543         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1544         * arm-tdep.c (tdesc_arm_list): New variable.
1545         (arm_register_g_packet_guesses): Call create description functions.
1546         (arm_read_description) (arm_read_mprofile_description): New
1547         function.
1548         * arm-tdep.h (arm_read_description)
1549         (arm_read_mprofile_description): Add declaration.
1550         * configure.tgt: Add new files.
1551
1552 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1553
1554         * top.c (new_ui_command): Open specified terminal just once.
1555
1556 2019-07-18  Tom Tromey  <tromey@adacore.com>
1557
1558         * symtab.c (main_name): Constify return type.
1559         * symfile.c (set_initial_language): Update.
1560         * symtab.h (main_name): Constify return type.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-winsource.c (tui_update_source_window)
1565         (tui_update_source_window_as_is)
1566         (tui_update_source_windows_with_line): Remove return.
1567         * tui/tui-disasm.c (tui_show_disassem)
1568         (tui_show_disassem_and_update_source): Remove return.
1569         * tui/tui.c (tui_reset): Remove return.
1570         * tui/tui-wingeneral.c
1571         (tui_check_and_display_highlight_if_needed): Remove return.
1572
1573 2019-07-17  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1576
1577 2019-07-17  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-winsource.h (struct tui_exec_info_window)
1580         (struct tui_source_window_base): Move from tui-data.h.
1581         * tui/tui-winsource.c: Move many method definitions from
1582         elsewhere.  Remove "structuring" comments.
1583         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1584         (tui_source_window_base::refresh_window): Move to
1585         tui-winsource.c.
1586         * tui/tui-win.c (tui_source_window_base::refresh_all)
1587         (tui_source_window_base::update_tab_width)
1588         (tui_source_window_base::set_new_height)
1589         (tui_source_window_base::do_make_visible_with_new_height): Move to
1590         tui-winsource.c.
1591         * tui/tui-source.h: Update.
1592         * tui/tui-source.c (tui_source_window_base::reset): Move to
1593         tui-winsource.c.
1594         * tui/tui-disasm.h: Update.
1595         * tui/tui-data.h (struct tui_exec_info_window): Move to
1596         tui-winsource.h.
1597         (struct tui_source_window_base): Likewise.
1598         * tui/tui-data.c (tui_source_window_base::clear_detail)
1599         (tui_source_window_base, ~tui_source_window_base): Move to
1600         tui-winsource.c.
1601
1602 2019-07-17  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-win.c (tui_resize_all)
1605         (tui_source_window_base::update_tab_width)
1606         (tui_adjust_win_heights): Update.
1607         (tui_win_info::make_invisible_and_set_new_height): Rename from
1608         make_invisible_and_set_new_height.
1609         * tui/tui-data.h (struct tui_win_info)
1610         <make_invisible_and_set_new_height>: New method.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui.c: Update.
1615         * tui/tui-source.h (struct tui_source_window): Move from
1616         tui-data.h.
1617         * tui/tui-layout.c: Update.
1618         * tui/tui-disasm.c: Update.
1619         * tui/tui-data.h (struct tui_source_window): Move to
1620         tui-source.h.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1625         tui-data.h.
1626         * tui/tui-data.h (struct tui_disasm_window): Move to
1627         tui-disasm.h.
1628
1629 2019-07-17  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-regs.h (struct tui_data_item_window): Move from
1632         tui-data.h.
1633         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1634         * tui/tui-data.h (struct tui_data_item_window): Move to
1635         tui-regs.h.
1636         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1637
1638 2019-07-17  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui.c: Update.
1641         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1642         (tui_cmd_window::max_height): Move to tui-command.c.
1643         * tui/tui-layout.c: Update.
1644         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1645         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1646         tui-command.c.
1647         * tui/tui-command.h (struct tui_cmd_window): Move from
1648         tui-data.h.
1649         * tui/tui-command.c: Remove "structuring" comments.
1650         (tui_cmd_window::clear_detail)
1651         (tui_cmd_window::do_make_visible_with_new_height)
1652         (tui_cmd_window::max_height): Move from elsewhere.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1657         Now static.
1658         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1659         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui.c: Update.
1664         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1665         tui-regs.c.
1666         * tui/tui-windata.h: Remove file.
1667         * tui/tui-windata.c: Remove file.
1668         * tui/tui-win.c (tui_data_window::set_new_height)
1669         (tui_data_window::do_make_visible_with_new_height): Move to
1670         tui-regs.c.
1671         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1672         * tui/tui-regs.c: Remove "structuring" comments.
1673         (tui_data_window::first_data_item_displayed)
1674         (tui_data_window::delete_data_content_windows)
1675         (tui_data_window::erase_data_content)
1676         (tui_data_window::display_all_data)
1677         (tui_data_window::refresh_all)
1678         (tui_data_window::do_scroll_vertical)
1679         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1680         (tui_data_window::do_make_visible_with_new_height)
1681         (tui_data_window::refresh_window): Move from elsewhere.
1682         (_initialize_tui_regs): Move to end of file.
1683         * tui/tui-layout.c: Update.
1684         * tui/tui-hooks.c: Update.
1685         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1686         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1687         tui-regs.c.
1688         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1689
1690 2019-07-17  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1693         seen.
1694
1695 2019-07-17  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-win.c (tui_source_window_base::set_new_height)
1698         (tui_source_window_base::do_make_visible_with_new_height): Use
1699         m_has_locator field directly.
1700         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1701         method.
1702         (struct tui_source_window_base) <has_locator>: Likewise.
1703
1704 2019-07-17  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1707         Don't declare.
1708         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1709         Remove.
1710         * tui/tui-win.c (tui_source_window_base::set_new_height)
1711         (tui_source_window_base::set_new_height)
1712         (make_invisible_and_set_new_height)
1713         (tui_source_window_base::do_make_visible_with_new_height)
1714         (tui_source_window_base::do_make_visible_with_new_height):
1715         Update.
1716         * tui/tui-layout.c (show_source_disasm_command, show_data)
1717         (show_source_or_disasm_and_command): Update.
1718         * tui/tui-layout.c (show_layout): Update.
1719
1720 2019-07-17  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-layout.c (make_data_window): Remove.
1723         (show_data): Unify creation and re-initialization cases.
1724
1725 2019-07-17  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-layout.c (make_source_window, make_disasm_window):
1728         Remove.
1729         (show_data): Unify creation and re-initialization cases.
1730
1731 2019-07-17  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-layout.c (make_command_window): Remove.
1734         (show_source_disasm_command, show_source_or_disasm_and_command):
1735         Unify creation and re-initialization cases.
1736
1737 2019-07-17  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1740         creation and re-initialization cases.
1741
1742 2019-07-17  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-regs.c (tui_get_register): Return void.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1749         Simplify.
1750
1751 2019-07-17  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1754         resetting.
1755
1756 2019-07-17  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1759         * tui/tui-regs.c (tui_reg_layout): New function.
1760         (tui_show_registers, tui_reg_command): Use it.
1761         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1762         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1763         parameters.
1764         (tui_layout_command): Remove.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-layout.h (tui/tui-layout): Return void.
1769         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1770
1771 2019-07-17  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-layout.c (show_source_disasm_command, show_data):
1774         Update.
1775         (reset_locator): Remove.
1776         (show_source_or_disasm_and_command): Update.
1777
1778 2019-07-17  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-source.c (tui_source_window_base::reset): Remove
1781         win_type parameter.
1782         * tui/tui-layout.c (make_command_window, make_source_window)
1783         (make_disasm_window, make_data_window)
1784         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1785         (reset_locator, show_source_or_disasm_and_command): Update.
1786         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1787         win_type parameter.
1788         (struct tui_source_window_base) <reset>: Likewise.
1789
1790 2019-07-17  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-layout.c (show_source_disasm_command): Use
1793         reset_locator.
1794         (reset_locator): New function.
1795         (init_and_make_win): Remove.
1796         (show_source_or_disasm_and_command): Use reset_locator.
1797
1798 2019-07-17  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1801         condition.
1802         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1803         Remove condition.
1804         * tui/tui-source.c (tui_source_window_base::reset): New method.
1805         * tui/tui-layout.c (make_command_window): Don't call
1806         init_and_make_win.
1807         (make_source_window, make_disasm_window): Don't call
1808         make_source_or_disasm_window.
1809         (make_data_window): Don't call init_and_make_win.  Change calling
1810         convention.
1811         (show_source_disasm_command, show_data): Simplify.
1812         (make_source_or_disasm_window): Remove.
1813         (show_source_or_disasm_and_command): Simplify.
1814         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1815         (struct tui_source_window_base) <reset>: Likewise.
1816         <execution_info>: Remove initializer.
1817         * tui/tui-data.c (tui_source_window_base): Initialize
1818         execution_info.
1819
1820 2019-07-17  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1823         variable.
1824
1825 2019-07-17  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui.c (tui_rl_other_window): Update.
1828         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1829         superclass method first.  Always iterate over regs_content.
1830         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1831         method.
1832         * tui/tui-win.c (tui_set_focus_command): Update.
1833
1834 2019-07-17  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-win.c (tui_set_focus_command): Rename from
1837         tui_set_focus.  Call tui_enable.
1838         (tui_set_focus_command): Remove.
1839
1840 2019-07-17  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1843         refresh_window.
1844         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1845         touchwin.
1846         (tui_data_window::refresh_window): Call refresh_window on data
1847         items.  Always call superclass refresh_window.
1848         (tui_win_info::refresh): Remove.
1849         (tui_source_window_base::refresh_window): Update.
1850         (tui_refresh_all): Update.
1851         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1852         refresh_window.
1853         (show_source_or_disasm_and_command): Likewise.
1854         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1855         (struct tui_source_window_base) <refresh>: Likewise.
1856
1857 2019-07-17  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-winsource.c (tui_clear_source_content)
1860         (tui_show_source_content): Update.
1861         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1862         whether content is empty.
1863         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1864         Remove.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1869         window's contents.
1870         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1871         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1872
1873 2019-07-17  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1876         (struct tui_data_item_window): Update.
1877
1878 2019-07-17  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1881         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1882         defines.
1883
1884 2019-07-17  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-winsource.h (tui_erase_source_content)
1887         (tui_clear_source_content): Remove "display_prompt" parameter.
1888         * tui/tui-winsource.c (tui_update_source_window_as_is)
1889         (tui_update_source_windows_with_addr): Update.
1890         (tui_clear_source_content): Remove "display_prompt" parameter.
1891         (tui_erase_source_content): Likewise.  Simplify.
1892         (tui_show_source_content): Update.
1893         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1894         * tui/tui-stack.c (tui_show_frame_info): Update.
1895         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1896         Remove defines.
1897
1898 2019-07-17  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1901         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1902         parameter.
1903         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1904         parameter.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-winsource.c (tui_clear_source_content)
1909         (tui_show_source_content, tui_show_exec_info_content)
1910         (tui_clear_exec_info_content): Update.
1911         * tui/tui-stack.c (tui_show_locator_content): Update.
1912         (tui_show_frame_info): Update.
1913         * tui/tui-source.h (tui_source_window): Don't declare.
1914         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1915         from tui_source_is_displayed.
1916         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1917         Remove field.
1918         (struct tui_source_window_base) <content_in_use>: New field.  Now
1919         bool.
1920         (struct tui_source_window) <showing_source_p>: New method.
1921         (TUI_SRC_WIN): Change cast.
1922         * tui/tui-data.c (tui_initialize_static_data): Update.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1927         location_matches_p.
1928         * tui/tui-source.c (tui_source_window::location_matches_p): New
1929         method.
1930         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1931         method.
1932         * tui/tui-data.h (struct tui_source_window_base)
1933         <location_matches_p>: New method.
1934         (struct tui_source_window, struct tui_disasm_window)
1935         <location_matches_p>: Likewise.
1936
1937 2019-07-17  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-win.c (tui_set_win_height_command): Rename from
1940         tui_set_win_height.
1941         (tui_set_win_height_command): Remove.
1942
1943 2019-07-17  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-source.c (tui_source_window): New constructor.  Add
1946         observer.
1947         (~tui_source_window): New destructor.
1948         (tui_source_window::style_changed): New method.
1949         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1950         (tui_attach_detach_observers): Update.
1951         * tui/tui-data.h (struct tui_source_window): Make constructor not
1952         inline.  Add destructor.
1953         (struct tui_source_window) <style_changed>: New method.
1954         <m_observable>: New member.
1955
1956 2019-07-17  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1959         * tui/tui-win.c (tui_resize_all): Fix typo.
1960
1961 2019-07-17  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1964         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1965         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1966         * tui/tui-win.c (window_name_completer): Use foreach.
1967         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1968         (update_tab_width): Likewise.
1969         * tui/tui-layout.c (show_layout): Update.
1970         * tui/tui-data.h (class tui_window_iterator): New.
1971         (struct all_tui_windows): New.
1972         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1973
1974 2019-07-17  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1977         parameter.  Don't reference globals.
1978         (tui_reg_command): Update.
1979
1980 2019-07-17  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-regs.c (tui_show_registers): Simplify.
1983
1984 2019-07-17  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-regs.c (tui_show_registers): Update.
1987         (tui_show_register_group): Add win_info parameter.
1988
1989 2019-07-17  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1992         Rename from tui_display_reg_element_at_line.
1993         (tui_data_window::display_registers_from_line): Update.
1994         * tui/tui-data.h (struct tui_data_window)
1995         <display_reg_element_at_line>: New method.
1996
1997 2019-07-17  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-regs.h (tui_display_registers_from)
2000         (tui_display_registers_from_line): Don't declare.
2001         * tui/tui-windata.c (tui_data_window::display_all_data)
2002         (tui_data_window::refresh_all)
2003         (tui_data_window::do_scroll_vertical): Update.
2004         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2005         from tui_display_registers_from.
2006         (tui_display_reg_element_at_line): Update.
2007         (tui_data_window::display_registers_from_line): Rename from
2008         tui_display_registers_from_line.
2009         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2010         display_registers_from_line>: New methods.
2011
2012 2019-07-17  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2015         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2016         from tui_erase_data_content.
2017         (tui_data_window::display_all_data)
2018         (tui_data_window::refresh_all)
2019         (tui_data_window::do_scroll_vertical): Update.
2020         * tui/tui-regs.c (tui_show_registers): Update.
2021         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2022         New method.
2023
2024 2019-07-17  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2027         declare.
2028         * tui/tui-windata.c
2029         (tui_data_window::delete_data_content_windows): Rename from
2030         tui_delete_data_content_windows.
2031         (tui_data_window::display_all_data)
2032         (tui_data_window::do_scroll_vertical): Update.
2033         * tui/tui-data.h (struct tui_data_window)
2034         <delete_data_content_windows>: New method.
2035
2036 2019-07-17  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2039         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2040
2041 2019-07-17  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2044         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2045         from tui_display_all_data.
2046         * tui/tui-win.c
2047         (tui_data_window::do_make_visible_with_new_height): Update.
2048         * tui/tui-regs.c (tui_show_registers): Update.
2049         * tui/tui-layout.c (tui_set_layout): Update.
2050         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2051         method.
2052
2053 2019-07-17  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2056         * tui/tui-windata.c (tui_display_data_from): Remove.
2057         (tui_data_window::refresh_all): Update.
2058
2059 2019-07-17  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2062         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2063         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2064         tui_display_registers_from_line.
2065         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2066         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2067         "force_display" parameter.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2072         declare.
2073         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2074         Rename from tui_first_reg_element_no_inline.
2075         (tui_display_reg_element_at_line)
2076         (tui_display_registers_from_line): Update.
2077         * tui/tui-data.h (struct tui_data_window)
2078         <first_reg_element_no_inline>: New method.
2079
2080 2019-07-17  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-windata.c (tui_display_data_from)
2083         (tui_data_window::do_scroll_vertical): Update.
2084         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2085         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2086         Rename from tui_line_from_reg_element_no.
2087         (tui_display_registers_from_line): Update.
2088         * tui/tui-data.h (struct tui_data_window)
2089         <line_from_reg_element_no>: New method.
2090
2091 2019-07-17  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2094         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2095         tui_last_regs_line_no.
2096         (tui_display_reg_element_at_line)
2097         (tui_display_registers_from_line): Update.
2098         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2099         method.
2100
2101 2019-07-17  Tom Tromey  <tom@tromey.com>
2102
2103         PR tui/24722:
2104         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2105         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2106         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2107         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2108         (tui_update_breakpoint_info): Likewise.
2109         * tui/tui-hooks.c (tui_event_create_breakpoint)
2110         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2111         Update.
2112
2113 2019-07-17  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2116
2117 2019-07-17  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-winsource.c (tui_update_source_window_as_is)
2120         (tui_update_source_windows_with_addr): Update.
2121         * tui/tui-source.h (tui_set_source_content)
2122         (tui_show_symtab_source): Add "win_info" parameter.
2123         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2124         parameter.
2125         (tui_show_symtab_source): Likewise.
2126
2127 2019-07-17  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-wingeneral.c
2130         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2131
2132 2019-07-17  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2135         (struct tui_cmd_window) <can_scroll>: New method.
2136         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2137         method.
2138
2139 2019-07-17  Tom Tromey  <tromey@adacore.com>
2140
2141         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2142         do_field_signed>: Rename.  Change type of "value".
2143         * ui-out.c (ui_out::field_signed): Rename from field_int.
2144         Change type of "value".
2145         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2146         type of "value".
2147         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2148         do_field_int.  Change type of "value".
2149         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2150         do_field_int.  Change type of "value".
2151         * tracepoint.c (trace_status_mi, tfind_1)
2152         (print_one_static_tracepoint_marker): Update.
2153         * thread.c (print_thread_info_1, print_selected_thread_frame):
2154         Update.
2155         * stack.c (print_frame, print_frame_info): Update.
2156         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2157         Update.
2158         * source.c (print_source_lines_base): Update.
2159         * skip.c (info_skip_command): Update.
2160         * record-btrace.c (btrace_ui_out_decode_error)
2161         (btrace_call_history_src_line): Update.
2162         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2163         Update.
2164         * progspace.c (print_program_space): Update.
2165         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2166         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2167         do_field_int.  Change type of "value".
2168         * mi/mi-out.c (mi_ui_out::do_table_begin)
2169         (mi_ui_out::do_table_header): Update.
2170         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2171         type of "value".
2172         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2173         (mi_cmd_data_list_changed_registers, output_register)
2174         (mi_cmd_data_read_memory, mi_load_progress)
2175         (mi_cmd_trace_frame_collected): Update.
2176         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2177         Update.
2178         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2179         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2180         (mi_cmd_var_list_children, varobj_update_one): Update.
2181         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2182         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2183         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2184         * inferior.c (print_inferior): Update.
2185         * gdb_bfd.c (print_one_bfd): Update.
2186         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2187         Update.
2188         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2189         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2190         do_field_int.  Change type of "value".
2191         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2192         do_field_int.  Change type of "value".
2193         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2194         (print_one_breakpoint_location, print_it_catch_fork)
2195         (print_one_catch_fork, print_it_catch_vfork)
2196         (print_one_catch_vfork, print_it_catch_solib)
2197         (print_it_catch_exec, print_it_ranged_breakpoint)
2198         (print_mention_watchpoint, print_mention_masked_watchpoint)
2199         (bkpt_print_it, update_static_tracepoint): Update.
2200         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2201         * break-catch-syscall.c (print_it_catch_syscall): Update.
2202         * ada-tasks.c (print_ada_task_info): Update.
2203         * ada-lang.c (print_it_exception, print_mention_exception):
2204         Update.
2205
2206 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         PR breakpoints/24541
2209         * gdbarch.c: Regenerate.
2210         * gdbarch.h: Regenerate.
2211         * gdbarch.sh: Adjust return type and parameter types for
2212         'stap_adjust_register'.
2213         (i386_stap_adjust_register): Adjust signature and return new
2214         register name.
2215         * stap-probe.c (stap_parse_register_operand): Adjust use of
2216         'gdbarch_stap_adjust_register'.
2217
2218 2019-07-17  Tom Tromey  <tromey@adacore.com>
2219
2220         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2221         declare VEC.
2222         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2223         std::vector.
2224         (struct s390_process_info): Add initializers.
2225         (s390_add_process): Use new.
2226         (s390_linux_nat_target::low_forget_process): Use delete.
2227         (s390_linux_nat_target::low_new_fork)
2228         (s390_linux_nat_target::stopped_by_watchpoint)
2229         (s390_linux_nat_target::low_prepare_to_resume)
2230         (s390_linux_nat_target::insert_watchpoint)
2231         (s390_linux_nat_target::insert_hw_breakpoint)
2232         (s390_linux_nat_target::remove_watchpoint)
2233         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2234
2235 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2236
2237         * aarch64-fbsd-nat.c: Include regcache.h.
2238         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2239         argument.
2240         (aarch64_fbsd_nat_target::fetch_registers)
2241         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2242         variable.
2243         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2244
2245 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2246
2247         * fbsd-nat.c: Include gdbarch.h.
2248
2249 2019-07-15  Tom Tromey  <tromey@adacore.com>
2250
2251         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2252
2253 2019-07-15  Tom Tromey  <tromey@adacore.com>
2254
2255         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2256         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2257         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2258         * cli-out.c (cli_ui_out::do_field_int): New method.
2259         * ui-out.c (ui_out::field_unsigned): New method.
2260         * symfile.c (generic_load): Use field_unsigned.
2261         (print_transfer_performance): Likewise.
2262         * record-btrace.c (ui_out_field_uint): Remove.
2263         (btrace_call_history_insn_range, btrace_call_history): Use
2264         field_unsigned.
2265         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2266         field_unsigned.
2267         * ui-out.h (class ui_out) <field_unsigned>: New method.
2268         <do_field_unsigned>: Likewise.
2269
2270 2019-07-15  Tom Tromey  <tromey@adacore.com>
2271
2272         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2273         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2274         * target.c (flash_erase_command): Use field_string.
2275         * infrun.c (print_signal_received_reason): Use field_string.
2276         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2277         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2278         field_string.
2279         * ada-tasks.c (print_ada_task_info): Use field_string.
2280
2281 2019-07-15  Tom Tromey  <tromey@adacore.com>
2282
2283         * target.c (flash_erase_command): Use field_core_addr.
2284         * symfile.c (generic_load): Use field_core_addr.
2285         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2286         Use field_core_addr.
2287         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2288         field_core_addr.
2289
2290 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2293         value if its desired type is smaller than a CORE_ADDR and signed.
2294
2295 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2296
2297         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2298         of changes to field names, and use new is_reference field to
2299         decide if a property is a reference or not.
2300         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2301         field.
2302         (struct dwarf2_property_baton): Update header comment, rename
2303         'referenced_type' to 'property_type' and update comments.
2304         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2305         default property type, store in property baton, update to take
2306         accound of renamed field.
2307         (read_func_scope): Update call to attr_to_dynamic_prop.
2308         (read_array_type): Likewise.
2309         (dwarf2_per_cu_addr_sized_int_type): New function.
2310         (read_subrange_index_type): Move type finding code to
2311         dwarf2_per_cu_addr_sized_int_type.
2312         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2313         (dwarf2_per_cu_addr_type): New function.
2314         (set_die_type): Update calls to attr_to_dynamic_prop.
2315
2316 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * dwarf2read.c (read_subrange_index_type): New function.
2319         (read_subrange_type): Move code into new function and call it.
2320         * gdbtypes.c (create_range_type): Add some asserts.
2321
2322 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2323
2324         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2325         update return statements.
2326         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2327         declaration, and update comment to match.
2328         * gdbtypes.c (resolve_dynamic_array): Update call to
2329         dwarf2_evaluate_property to match new return type.
2330
2331 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * valarith.c (value_subscripted_rvalue): Change lowerbound
2334         parameter type from int to LONGEST.
2335         * value.h (value_subscripted_rvalue): Likewise in declaration.
2336
2337 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * cli/cli-utils.c (info_print_command_completer): New function.
2340         * cli/cli-utils.h: Add 'completer.h' include, and forward
2341         declaration for 'struct cmd_list_element'.
2342         (info_print_command_completer): Declare.
2343         * stack.c (_initialize_stack): Add completer for 'info locals' and
2344         'info args'.
2345         * symtab.c (_initialize_symtab): Add completer for 'info
2346         variables' and 'info functions'.
2347         * NEWS: Mention completion for additional info commands.
2348
2349 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2350
2351         * cli/cli-utils.c (extract_info_print_args): Delete.
2352         (extract_arg_maybe_quoted): Delete.
2353         (info_print_options_defs): New variable.
2354         (make_info_print_options_def_group): New function.
2355         (extract_info_print_options): Define new function.
2356         * cli/cli-utils.h (extract_info_print_args): Delete.
2357         (struct info_print_options): New structure.
2358         (extract_info_print_options): Declare new function.
2359         * stack.c (info_locals_command): Update to use new
2360         extract_info_print_options, also add a header comment.
2361         (info_args_command): Likewise.
2362         * symtab.c (info_variables_command): Likewise.
2363         (info_functions_command): Likewise.
2364
2365 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2366
2367         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2368         to extract string arguments.
2369         * common/common-utils.c (extract_string_maybe_quoted): New function.
2370         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2371
2372 2019-07-11  Tom Tromey  <tromey@adacore.com>
2373
2374         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2375         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2376         * top.h (gdbinit): Don't declare.
2377         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2378         into...
2379         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2380         * top.c (gdb_init): Don't call init_cli_cmds.
2381         (gdbinit): Remove.
2382         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2383
2384 2019-07-11  Tom Tromey  <tromey@adacore.com>
2385
2386         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2387         after it has been moved.
2388
2389 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2390
2391         * valops.c (value_must_coerce_to_target): Change return type to
2392         bool.
2393         * value.h (value_must_coerce_to_target): Likewise.
2394
2395 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2396
2397         * breakpoint.c (is_hardware_watchpoint): Remove
2398         forward-declaration.
2399         (is_masked_watchpoint): Change return type to bool.
2400         (is_tracepoint): Likewise.
2401         (is_breakpoint): Likewise.
2402         (is_hardware_watchpoint): Likewise.
2403         (is_watchpoint): Likewise.
2404         (is_no_memory_software_watchpoint): Likewise.
2405         (is_catchpoint): Likewise.
2406         (breakpoint_1): Make FILTER parameter's return type bool.
2407         is_masked_watchpoint): Change return type to bool.
2408         (save_breakpoints): Make FILTER parameter's return type bool.
2409         * breakpoint.h (is_breakpoint): Change return type to bool.
2410         (is_watchpoint): Likewise.
2411         (is_catchpoint): Likewise.
2412         (is_tracepoint): Likewise.
2413
2414 2019-07-10  Tom Tromey  <tom@tromey.com>
2415
2416         * defs.h: Don't include gdbarch.h.
2417         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2418         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2419         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2420         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2421         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2422         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2423         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2424         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2425         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2426         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2427         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2428         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2429         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2430         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2431         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2432         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2433         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2434         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2435         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2436         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2437         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2438         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2439         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2440         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2441         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2442         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2443         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2444
2445 2019-07-10  Tom Tromey  <tromey@adacore.com>
2446
2447         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2448         * breakpoint.c (init_ada_exception_breakpoint): Register as
2449         bp_catchpoint.
2450         (print_one_breakpoint_location, print_one_breakpoint): Use
2451         is_ada_exception_catchpoint.
2452         * ada-lang.c (class ada_catchpoint_location): Pass
2453         bp_loc_software_breakpoint to bp_location constructor.
2454         (is_ada_exception_catchpoint): New function.
2455
2456 2019-07-10  Tom Tromey  <tromey@adacore.com>
2457
2458         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2459         VEC.
2460         (struct arm_exidx_entry): New method operator<.
2461         (struct arm_exidx_data) <section_maps>: Change type.
2462         (arm_exidx_data_free): Remove.
2463         (arm_exidx_data_key): Change type.  Move lower.
2464         (arm_exidx_new_objfile): Update.
2465         (arm_compare_exidx_entries): Remove.
2466         (arm_find_exidx_entry, _initialize_arm_tdep)
2467
2468 2019-07-10  Tom Tromey  <tromey@adacore.com>
2469
2470         * solib-spu.c (ocl_program_data_key): Change type.
2471         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2472         Update.
2473
2474 2019-07-10  Tom Tromey  <tromey@adacore.com>
2475
2476         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2477         (struct solib_aix_inferior_data) <library_list>: Change type.
2478         (solib_aix_inferior_data_handle): Change type.
2479         (get_solib_aix_inferior_data): Update.
2480         (solib_aix_free_library_list): Remove.
2481         (library_list_start_library): Update.
2482         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2483         return type.
2484         (solib_aix_get_library_list)
2485         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2486         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2487
2488 2019-07-10  Tom Tromey  <tromey@adacore.com>
2489
2490         * solib-dsbt.c (struct dsbt_info): Add initializers.
2491         (solib_dsbt_pspace_data): Change type.
2492         (dsbt_pspace_data_cleanup): Remove.
2493         (get_dsbt_info, _initialize_dsbt_solib): Update.
2494
2495 2019-07-10  Tom Tromey  <tromey@adacore.com>
2496
2497         * spu-tdep.c (spu_overlay_data): Change type.
2498         (spu_get_overlay_table, spu_overlay_new_objfile)
2499         (_initialize_spu_tdep): Update.
2500
2501 2019-07-10  Tom Tromey  <tromey@adacore.com>
2502
2503         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2504         destructor.
2505         (dbx_objfile_data_key): Change type and declare later.
2506         (DBX_SYMFILE_INFO): Rewrite.
2507         * dbxread.c (dbx_objfile_data_key): Change type.
2508         (dbx_symfile_init): Update.
2509         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2510         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2511         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2512
2513 2019-07-10  Tom Tromey  <tromey@adacore.com>
2514
2515         * jit.c (jit_program_space_key): Change type.  Move lower.
2516         (get_jit_program_space_data): Update.
2517         (jit_program_space_data_cleanup): Remove.
2518         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2519         Update.
2520         (struct jit_program_space_data): Add initializers.
2521
2522 2019-07-10  Tom Tromey  <tromey@adacore.com>
2523
2524         * solib-darwin.c (struct darwin_info): Add initializers.
2525         (solib_darwin_pspace_data): Change type.
2526         (darwin_pspace_data_cleanup): Remove.
2527         (get_darwin_info, _initialize_darwin_solib): Update.
2528
2529 2019-07-10  Tom Tromey  <tromey@adacore.com>
2530
2531         * remote-sim.c (struct sim_inferior_data): Add initializers,
2532         constructor, and destructor.
2533         (sim_inferior_data_key): Change type.  Move lower.
2534         (check_for_duplicate_sim_descriptor): Update.
2535         (get_sim_inferior_data): Use new.  Update.
2536         (~sim_inferior_data_cleanup): Rename from
2537         sim_inferior_data_cleanup.  Simplify.
2538         (gdbsim_close_inferior, simulator_command)
2539         (sim_command_completer, _initialize_remote_sim): Update.
2540         (next_pid, INITIAL_PID): Move earlier.
2541
2542 2019-07-10  Tom Tromey  <tromey@adacore.com>
2543
2544         * python/python-internal.h (create_thread_object): Return
2545         gdbpy_ref.
2546         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2547         * python/py-inferior.c (struct threadlist_entry): Add
2548         constructor.
2549         <thread_obj>: Now a gdbpy_ref.
2550         (thread_to_thread_object): Update.
2551         (add_thread_object): Use new.
2552         (delete_thread_object): Use delete.
2553         (infpy_threads): Update.
2554         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2555         GIL.
2556
2557 2019-07-10  Tom Tromey  <tromey@adacore.com>
2558
2559         * valops.c (value_cast): Specialize error message for Ada.
2560
2561 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2562
2563         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2564
2565 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2566
2567         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2568         bpstat_should_step): Return bool, adjust comments.
2569         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2570         bpstat_should_step): Likewise.
2571
2572 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * features/Makefile: Use feature target descriptions for Arm.
2575         * features/arm/arm-core.c: Generate new file.
2576         * features/arm/arm-fpa.c: Likewise.
2577         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2578         * features/arm/arm-m-profile.c: Likewise.
2579         * features/arm/arm-vfpv2.c: Likewise.
2580         * features/arm/arm-vfpv3.c: Likewise.
2581         * features/arm/xscale-iwmmxt.c: Likewise.
2582         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2583
2584 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2587         ptrace earlier.
2588
2589 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2590
2591         * features/aarch64-pauth.c: Regenerate.
2592
2593 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2594
2595         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2596         bool.
2597         (bpstat_what): Use false instead of 0.
2598
2599 2019-07-09  Pedro Alves  <palves@redhat.com>
2600
2601         * break-catch-throw.c (is_exception_catchpoint): New.
2602         * breakpoint.c (print_one_breakpoint_location): New parameter
2603         'raw_loc'.  Handle it.  Use
2604         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2605         looking at the breakpoint's type.
2606         (print_one_breakpoint): If handling "maint info breakpoints", also
2607         print locations of exception catchpoints.
2608         * breakpoint.h (is_exception_catchpoint): Declare.
2609
2610 2019-07-09  Pedro Alves  <palves@redhat.com>
2611
2612         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2613         "addr" field.
2614         (allocate_location_exception_catchpoint): New.
2615         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2616         (initialize_throw_catchpoint_ops): Install
2617         allocate_location_exception_catchpoint as allocate_location
2618         method.
2619         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2620         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2621         bp_loc_other.
2622         (breakpoint_address_is_meaningful): Delete.
2623         (bl_address_is_meaningful): New.
2624         (breakpoint_locations_match): Adjust comment.
2625         (bp_location_from_bp_type): New, factored out of...
2626         (bp_location::bp_location(breakpoint *)): ... this.
2627         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2628         factored out of...
2629         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2630         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2631         breakpoint_address_is_meaningful.
2632         (bp_locations_compare): Adjust comment.
2633         (update_global_location_list): Use bl_address_is_meaningful
2634         instead of breakpoint_address_is_meaningful.
2635         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2636         explicit.
2637         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2638         * python/py-breakpoint.c (bppy_get_location): No longer check
2639         whether location is null.
2640
2641 2019-07-09  Pedro Alves  <palves@redhat.com>
2642
2643         PR c++/15468
2644         * breakpoint.c (print_one_breakpoint_location): Remove
2645         single-location assert.
2646
2647 2019-07-09  Tom Tromey  <tom@tromey.com>
2648
2649         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2650         * configure: Rebuild.
2651         * configure.ac: Change common to gdbsupport.
2652         * gdbsupport: Rename from common.
2653         * acinclude.m4: Change common to gdbsupport.
2654         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2655         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2656         gdbsupport.
2657         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2658         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2659         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2660         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2661         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2662         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2663         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2664         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2665         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2666         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2667         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2668         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2669         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2670         coff-pe-read.c, command.h, compile/compile-c-support.c,
2671         compile/compile-c.h, compile/compile-cplus-symbols.c,
2672         compile/compile-cplus-types.c, compile/compile-cplus.h,
2673         compile/compile-loc2c.c, compile/compile.c, completer.c,
2674         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2675         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2676         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2677         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2678         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2679         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2680         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2681         features/aarch64-core.c, features/aarch64-fpu.c,
2682         features/aarch64-pauth.c, features/aarch64-sve.c,
2683         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2684         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2685         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2686         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2687         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2688         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2689         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2690         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2691         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2692         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2693         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2694         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2695         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2696         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2697         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2698         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2699         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2700         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2701         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2702         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2703         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2704         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2705         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2706         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2707         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2708         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2709         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2710         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2711         minsyms.c, mips-linux-tdep.c, namespace.h,
2712         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2713         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2714         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2715         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2716         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2717         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2718         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2719         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2720         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2721         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2722         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2723         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2724         procfs.c, producer.c, progspace.h, psymtab.h,
2725         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2726         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2727         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2728         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2729         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2730         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2731         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2732         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2733         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2734         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2735         target-memory.c, target.c, target.h, target/waitstatus.c,
2736         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2737         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2738         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2739         unittests/array-view-selftests.c,
2740         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2741         unittests/common-utils-selftests.c,
2742         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2743         unittests/format_pieces-selftests.c,
2744         unittests/function-view-selftests.c,
2745         unittests/lookup_name_info-selftests.c,
2746         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2747         unittests/mkdir-recursive-selftests.c,
2748         unittests/observable-selftests.c,
2749         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2750         unittests/parse-connection-spec-selftests.c,
2751         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2752         unittests/scoped_fd-selftests.c,
2753         unittests/scoped_mmap-selftests.c,
2754         unittests/scoped_restore-selftests.c,
2755         unittests/string_view-selftests.c, unittests/style-selftests.c,
2756         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2757         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2758         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2759         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2760         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2761         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2762
2763 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2764
2765         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2766         bool value.
2767         (decode_digits_ordinary): Set explicit_line field in sal.
2768         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2769         symtab_and_line that was set on an explicit line number in
2770         assembler code.  Do always update the recorded symtab and line if
2771         we do skip the prologue.
2772
2773 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * breakpoint.c (set_breakpoint_location_function): Remove
2776         explicit_loc parameter.
2777         (momentary_breakpoint_from_master): Update call to
2778         set_breakpoint_location_function.
2779         (add_location_to_breakpoint): Likewise.
2780
2781 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2784         required features based on default bfd type when no specific bfd
2785         is present.
2786
2787 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2788
2789         * NEWS: Mention that GDB printf and eval commands can now print
2790         C-style and Ada-style convenience var strings without
2791         calling the inferior.
2792         * printcmd.c (printf_c_string): Locally print GDB internal var
2793         instead of transiting via the inferior.
2794         (printf_wide_c_string): Likewise.
2795
2796 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2797
2798         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2799
2800 2019-07-04  Tom Tromey  <tom@tromey.com>
2801
2802         PR tui/24724:
2803         * tui/tui-winsource.c (tui_clear_source_content): Update.
2804         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2805         (tui_update_breakpoint_info): Update.
2806         (tui_set_exec_info_content): Update.
2807         * tui/tui-source.c (tui_set_source_content_nil): Update.
2808         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2809         has_break.
2810         * tui/tui-data.h (enum tui_bp_flag): New.
2811         (tui_bp_flags): New enum flags type.
2812         (struct tui_source_element) <break_mode>: Change type.  Rename
2813         from has_break.
2814         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2815         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2816         constants.
2817         * tui/tui-winsource.h: Fix comment.
2818
2819 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2820
2821         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2822         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2823         (store_fpregs_to_thread)
2824         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2825         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2826         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2827         (IWMMXT_REGS_SIZE): Add define.
2828         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2829         (fetch_vfp_regs, store_vfp_regs)
2830         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2831         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2832
2833 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2834
2835         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2836         defines.
2837         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2838         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2839         (ARM_INT_REGISTER_SIZE): ...to this.
2840         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2841         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2842         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2843         (arm_linux_collect_gregset, supply_nwfpe_register)
2844         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2845         defines.
2846         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2847         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2848         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2849         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2850         (arm_return_in_memory, arm_store_return_value)
2851         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2852         (arm_record_ld_st_multiple): Likewise.
2853         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2854         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2855
2856 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2857
2858         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2859         AARCH64_DISPLACED_MODIFIED_INSNS.
2860         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2861         (aarch64_displaced_step_copy_insn): Likewise.
2862         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2863         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2864         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2865         ARM_DISPLACED_MODIFIED_INSNS.
2866         * arm-tdep.c (arm_gdbarch_init): Likewise.
2867         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2868         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2869         (struct arm_displaced_step_closure): Use
2870         ARM_DISPLACED_MODIFIED_INSNS.
2871
2872 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2873
2874         * features/Makefile: Remove unused xml files.
2875         * features/aarch64.xml: Remove.
2876         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2877         * features/i386/amd64-avx-avx512.xml: Remove.
2878         * features/i386/amd64-avx-linux.xml: Remove.
2879         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2880         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2881         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2882         * features/i386/amd64-avx-mpx.xml: Remove.
2883         * features/i386/amd64-avx.xml: Remove.
2884         * features/i386/amd64-linux.xml: Remove.
2885         * features/i386/amd64-mpx-linux.xml: Remove.
2886         * features/i386/amd64-mpx.xml: Remove.
2887         * features/i386/amd64.xml: Remove.
2888         * features/i386/i386-avx-avx512-linux.xml: Remove.
2889         * features/i386/i386-avx-avx512.xml: Remove.
2890         * features/i386/i386-avx-linux.xml: Remove.
2891         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2892         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2893         * features/i386/i386-avx-mpx-linux.xml: Remove.
2894         * features/i386/i386-avx-mpx.xml: Remove.
2895         * features/i386/i386-avx.xml: Remove.
2896         * features/i386/i386-linux.xml: Remove.
2897         * features/i386/i386-mmx-linux.xml: Remove.
2898         * features/i386/i386-mmx.xml: Remove.
2899         * features/i386/i386-mpx-linux.xml: Remove.
2900         * features/i386/i386-mpx.xml: Remove.
2901         * features/i386/i386.xml: Remove.
2902         * features/i386/x32-avx-avx512-linux.xml: Remove.
2903         * features/i386/x32-avx-linux.xml: Remove.
2904         * features/i386/x32-linux.xml: Remove.
2905
2906 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2907
2908         * regformats/aarch64.dat: Remove.
2909         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2910         * regformats/i386/amd64-avx-linux.dat: Remove.
2911         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2912         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2913         * regformats/i386/amd64-linux.dat: Remove.
2914         * regformats/i386/amd64-mpx-linux.dat: Remove.
2915         * regformats/i386/amd64.dat: Remove.
2916         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2917         * regformats/i386/i386-avx-linux.dat: Remove.
2918         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2919         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2920         * regformats/i386/i386-linux.dat: Remove.
2921         * regformats/i386/i386-mmx-linux.dat: Remove.
2922         * regformats/i386/i386-mpx-linux.dat: Remove.
2923         * regformats/i386/i386.dat: Remove.
2924         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2925         * regformats/i386/x32-avx-linux.dat: Remove.
2926         * regformats/i386/x32-linux.dat: Remove.
2927
2928 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2929
2930         * aarch64-tdep.c: Remove xml self tests.
2931         * amd64-linux-tdep.c: Likewise.
2932         * amd64-tdep.c: Likewise.
2933         * i386-linux-tdep.c: Likewise.
2934         * i386-tdep.c: Likewise.
2935
2936 2019-07-03  Pedro Alves  <palves@redhat.com>
2937
2938         PR cli/24732
2939         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2940         (pipe_cmd_option_defs): New.
2941         (make_pipe_cmd_options_def_group): New.
2942         (pipe_command): Use gdb::option::process_options.
2943         (pipe_command_completer): New function.
2944         (_initialize_cli_cmds): Install completer for "pipe" command.
2945
2946 2019-07-03  Pedro Alves  <palves@redhat.com>
2947
2948         * cli/cli-option.c (union option_value) <string>: New field.
2949         (struct option_def_and_value): Add ctor, move ctor, dtor and
2950         use DISABLE_COPY_AND_ASSIGN.
2951         (option_def_and_value::clear_value): New.
2952         (parse_option, save_option_value_in_ctx, get_val_type_str)
2953         (add_setshow_cmds_for_options): Handle var_string.
2954         * cli-option.h (union option_def::var_address) <string>: New
2955         field.
2956         (struct string_option_def): New.
2957         * maint-test-options.c (struct test_options_opts): Add default
2958         ctor and use DISABLE_COPY_AND_ASSIGN.
2959         <string_opt>: New field.
2960         (test_options_opts::~test_options_opts): New.
2961         (test_options_opts::dump): Also dump "-string".
2962         (test_options_option_defs): Install "string.
2963
2964 2019-07-03  Pedro Alves  <palves@redhat.com>
2965
2966         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2967         option_value with a null enumeration.
2968         (complete_options): Save the option values in the context.
2969         (save_option_value_in_ctx): New, factored out from ...
2970         (process_options): ... here.
2971         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2972         of the function.
2973         * maint-test-options.c (test_options_opts::dump): New, factored
2974         out from ...
2975         (maintenance_test_options_command_mode): ... here.
2976         (maintenance_test_options_command_completion_result): Delete.
2977         (maintenance_test_options_command_completion_text): Update
2978         comment.
2979         (maintenance_show_test_options_completion_result): Change
2980         prototype.  Just print
2981         maintenance_test_options_command_completion_text.
2982         (save_completion_result): New.
2983         (maintenance_test_options_completer_mode): Pass options context to
2984         complete_options, and then save a dump.
2985         (_initialize_maint_test_options): Use add_cmd to install "maint
2986         show test-options-completion-result".
2987
2988 2019-07-03  Pedro Alves  <palves@redhat.com>
2989
2990         * NEWS (New commands): Mention "with" and "maint with".
2991         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2992         (with_command, with_command_completer): New.
2993         (pipe_command): Adjust to new repeat_previous
2994         interface.
2995         (_initialize_cli_cmds): Install the "with" command and its "w"
2996         alias.
2997         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2998         declarations.
2999         * cli/cli-setshow.c (parse_cli_var_uinteger)
3000         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3001         argument strings for all var_types.
3002         (get_setshow_command_value_string): New, factored out from ...
3003         (do_show_command): ... this.
3004         * cli/cli-setshow.h: Include <string>.
3005         (get_setshow_command_value_string): Declare.
3006         * command.h (repeat_previous): Now returns const char *.  Adjust
3007         comment.
3008         * maint.c: Include "cli/cli-cmds.h".
3009         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3010         (_initialize_maint_cmds): Register the "maintenance with" command.
3011         * top.c (repeat_previous): Move bits from pipe_command here:
3012         Return the saved command line, if any; error out if there's no
3013         command to relaunch.
3014
3015 2019-07-03  Pedro Alves  <palves@redhat.com>
3016
3017         * NEWS (New commands): Mention "maint set/show test-settings"
3018         instead of "maint test-settings".
3019         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3020         (maintenance_test_settings_set_list): Rename to ...
3021         (maintenance_set_test_settings_list): ... this.
3022         (maintenance_test_settings_show_list): Rename to  ...
3023         (maintenance_show_test_settings_list): ... this.
3024         (maintenance_test_settings_cmd): Delete.
3025         (maintenance_test_settings_set_cmd): ...
3026         (maintenance_set_test_settings_cmd): ... this.
3027         (maintenance_test_settings_show_cmd): ...
3028         (maintenance_show_test_settings_cmd): ... this.
3029         (maintenance_test_settings_show_value_cmd):
3030         (maintenance_show_test_settings_value_cmd): ... this.
3031         (_initialize_maint_test_settings): No longer install the "maint
3032         test-settings" prefix command.  Rename "maint test-settings set"
3033         to "maint set test-settings", and "maint test-settings show" to
3034         "maint show test-settings".  Adjust all subcommands.
3035
3036 2019-07-03  Pedro Alves  <palves@redhat.com>
3037
3038         * maint-test-settings.c: Fix file's intro comment.  Replace all
3039         references to "test-options" with references to "test-settings",
3040         in comments.
3041
3042 2019-07-03  Pedro Alves  <palves@redhat.com>
3043
3044         * maint-test-settings.c (maintenance_test_settings_xxx)
3045         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3046         New.
3047         (maintenance_test_settings_enums): Use them.
3048         (maintenance_test_settings_enum): Default to
3049         maintenance_test_settings_xxx.
3050         (_initialize_maint_test_settings): Initialize
3051         MAINTENANCE_TEST_SETTINGS_FILENAME.
3052
3053 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3054
3055         * breakpoint.h (remove_breakpoints_inf): Change return type to
3056         void, move function documentation here.
3057         * breakpoint.c (remove_breakpoints_inf): Change return type to
3058         void, move function documentation to header.
3059
3060 2019-07-02  Pedro Alves  <palves@redhat.com>
3061
3062         * NEWS (Completion improvements): Mention "info threads".
3063         * thread.c (struct info_threads_opts, info_threads_option_defs)
3064         (make_info_threads_options_def_group): New.
3065         (info_threads_command): Use gdb::option::process_options.
3066         (info_threads_command_completer): New.
3067         (_initialize_thread): Use gdb::option::build_help to build the
3068         help text for "info threads".
3069
3070 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3071
3072         * defs.h (generic_load): Move from here...
3073         * symfile.h (generic_load): ... to here.  Rename name parameter
3074         to args.
3075         * symfile.c (generic_load): Add comment.
3076
3077 2019-07-01  Tom Tromey  <tromey@adacore.com>
3078
3079         * dwarf2read.c
3080         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3081         declaration of without_params.  Fix formatting.
3082
3083 2019-07-01  Tom Tromey  <tromey@adacore.com>
3084
3085         * ada-exp.y (find_primitive_type): Update.
3086         * ada-lang.h (ada_lookup_symbol): Update.
3087         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3088         parameter.
3089         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3090
3091 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3092
3093         PR breakpoints/24541
3094         * gdbarch.c: Regenerate.
3095         * gdbarch.h: Regenerate.
3096         * gdbarch.sh: Add 'stap_adjust_register'.
3097         * i386-tdep.c: Include '<unordered_set>'.
3098         (i386_stap_adjust_register): New function.
3099         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3100         * stap-probe.c (stap_parse_register_operand): Call
3101         'gdbarch_stap_adjust_register'.
3102
3103 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3104
3105         PR python/24742
3106         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3107         * python/python.c (do_start_initialization): Use 'xmalloc'
3108         instead of 'PyMem_Malloc'.
3109
3110 2019-06-28  Tom Tromey  <tromey@adacore.com>
3111
3112         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3113         for Ada.
3114
3115 2019-06-27  Tom Tromey  <tromey@adacore.com>
3116
3117         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3118         objfile_key.
3119         (arm_find_mapping_symbol, arm_record_special_symbol)
3120         (_initialize_arm_tdep): Update.
3121         (arm_objfile_data_free): Remove.
3122
3123 2019-06-27  Tom Tromey  <tromey@adacore.com>
3124
3125         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3126         to cp_print_static_field.
3127
3128 2019-06-26  Tom Tromey  <tromey@adacore.com>
3129
3130         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3131         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3132         declare.
3133
3134 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3135
3136         * features/aarch64-core.c (create_feature_aarch64_core):
3137         Regenerate.
3138         * features/aarch64-core.xml: Add cpsr flags.
3139
3140 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3141
3142         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3143         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3144
3145 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3146
3147         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3148         field.
3149         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3150         use.
3151         (arm_record_special_symbol): Don't insert new symbol in sorted
3152         position, push it at the end.
3153
3154 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3155
3156         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3157         (arm_mapping_symbol_s): Remove.
3158         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3159         (arm_mapping_symbol_vec): New typedef.
3160         (struct arm_per_objfile): Add constructor.
3161         <section_maps>: Change type to
3162         std::unique_ptr<arm_mapping_symbol_vec[]>.
3163         (arm_compare_mapping_symbols): Remove.
3164         (arm_find_mapping_symbol): Adjust to section_maps type change.
3165         (arm_objfile_data_free): Call delete on arm_per_objfile.
3166         (arm_record_special_symbol): Adjust to section_maps type change.
3167         Allocate arm_per_objfile with new.
3168
3169 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3170
3171         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3172         with the command prefix.
3173
3174 2019-06-25  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3177         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3178
3179 2019-06-25  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3182         type.
3183         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3184         protected.
3185
3186 2019-06-25  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-winsource.c
3189         (tui_source_window_base::set_is_exec_point_at): Add check against
3190         LOA_ADDRESS.
3191
3192 2019-06-25  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-source.c (tui_set_source_content): Don't check before
3195         xfree.
3196         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3197
3198 2019-06-25  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-winsource.h (tui_update_source_window_as_is)
3201         (tui_alloc_source_buffer, tui_line_is_displayed)
3202         (tui_addr_is_displayed): Change type of win_info.
3203         * tui/tui-winsource.c (tui_update_source_window_as_is)
3204         (tui_clear_source_content, tui_show_source_line)
3205         (tui_show_source_content, tui_source_window_base::refill)
3206         (tui_source_window_base::set_is_exec_point_at)
3207         (tui_source_window_base::set_is_exec_point_at)
3208         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3209         (tui_alloc_source_buffer, tui_line_is_displayed)
3210         (tui_addr_is_displayed): Change type of win_info.  Update.
3211         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3212         (tui_source_window_base::do_make_visible_with_new_height):
3213         Update.
3214         * tui/tui-source.c (tui_set_source_content)
3215         (tui_set_source_content_nil)
3216         (tui_source_window::do_scroll_vertical): Update.
3217         * tui/tui-layout.c (show_layout): Update.
3218         * tui/tui-disasm.c (tui_set_disassem_content)
3219         (tui_disasm_window::do_scroll_vertical): Update.
3220         * tui/tui-data.h (tui_win_content): Remove.
3221         (struct tui_gen_win_info) <content, content_size>: Remove.
3222         (struct tui_source_element): Add initializers and destructor.
3223         (union tui_which_element, struct tui_win_element): Remove.
3224         (struct tui_source_window_base) <content>: New field.
3225         (struct tui_data_window): Remove destructor.
3226         (tui_alloc_content, tui_free_win_content)
3227         (tui_free_all_source_wins_content): Don't declare.
3228         * tui/tui-data.c (tui_initialize_static_data): Update.
3229         (init_content_element, tui_alloc_content): Remove.
3230         (~tui_gen_win_info): Update.
3231         (~tui_data_window, tui_free_all_source_wins_content)
3232         (tui_free_win_content, free_content, free_content_elements):
3233         Remove.
3234
3235 2019-06-25  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-winsource.h (tui_clear_source_content)
3238         (tui_erase_source_content, tui_show_source_content): Change type
3239         of win_info.
3240         * tui/tui-winsource.c (tui_clear_source_content)
3241         (tui_erase_source_content, tui_show_source_content): Change type
3242         of win_info.
3243         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3244         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3245         win_info.
3246         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3247         win_info.
3248         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3249
3250 2019-06-25  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-winsource.c (tui_clear_source_content)
3253         (tui_source_window_base::set_is_exec_point_at): Update.
3254         * tui/tui-source.c (tui_set_source_content_nil): Update.
3255         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3256         a bool.
3257         * tui/tui-data.c (init_content_element): Update.
3258
3259 2019-06-25  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3262         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3263         * tui/tui-layout.c (init_and_make_win): Update.
3264         * tui/tui.h (enum tui_win_type): Update.
3265         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3266         tui_win_is_auxillary.
3267         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3268         tui_win_is_auxillary.
3269
3270 2019-06-25  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3273         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3274         (tui_delete_data_content_windows, tui_display_all_data)
3275         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3276         Update.
3277         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3278         * tui/tui-regs.c (tui_last_regs_line_no)
3279         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3280         (tui_show_registers): Update.
3281         (tui_show_register_group): Return void.  Update.
3282         (tui_display_registers_from, tui_display_reg_element_at_line)
3283         (tui_display_registers_from_line, tui_check_register_values):
3284         Update.
3285         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3286         member.
3287         (struct tui_data_window) <regs_content>: Now a std::vector.
3288         <regs_content_count>: Remove.
3289         (tui_add_content_elements, tui_free_data_content): Don't declare.
3290         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3291         (init_content_element): Remove DATA_WIN case.  Add assert.
3292         (tui_add_content_elements): Remove.
3293         (tui_data_window): Update.
3294         (tui_free_data_content): Remove.
3295         (free_content_elements): Remove DATA_WIN case.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-data.c (tui_data_item_window): Update.
3300         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3301         * tui/tui-windata.c (tui_display_all_data)
3302         (tui_display_data_from_line): Update.
3303         (tui_check_data_values): Remove.
3304         * tui/tui-regs.c (tui_show_register_group)
3305         (tui_display_reg_element_at_line): Update.
3306         * tui/tui-hooks.c (tui_register_changed)
3307         (tui_refresh_frame_and_register_information): Call
3308         tui_check_register_values.
3309         * tui/tui-data.h (struct tui_data_window) <data_content,
3310         data_content_count, data_type>: Remove.
3311         (enum tui_data_type): Remove.
3312
3313         * tui/tui-data.c (tui_data_window::clear_detail)
3314         (~tui_data_window): Update.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3319         declare.
3320         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3321         Rename from tui_first_data_item_displayed.  Update.
3322         (tui_data_window::refresh_all)
3323         (tui_data_window::do_scroll_vertical): Update.
3324         * tui/tui-data.h (struct tui_data_window)
3325         <first_data_item_displayed>: Declare new method.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3330         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3331         contents...
3332         (tui_initialize_static_data): ...here.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3337         (tui_display_registers_from, tui_check_register_values): Update.
3338         (tui_display_register): Remove win_info parameter; update.
3339         (tui_get_register): Change type of parameters.
3340         * tui/tui-data.h (struct tui_data_element): Remove.
3341         (union tui_which_element) <data>: Remove.
3342         <data_window>: Change type.
3343         (struct tui_data_item_window): New.
3344         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3345         case.  Add assert.
3346         (~tui_data_item_window): New destructor.
3347         (free_content_elements): Remove DATA_ITEM_WIN case.
3348
3349 2019-06-25  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3352         Remove.
3353
3354 2019-06-25  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-data.h (struct tui_command_element): Remove.
3357         (union tui_which_element) <command>: Remove.
3358         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3359         assert.
3360         (free_content_elements): Remove CMD_WIN case.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-layout.c (tui_set_layout): Update.
3365         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3366         * tui/tui-data.c (layout_def): Update.
3367
3368 2019-06-25  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3371         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3372         (tui_source_window_base::set_new_height): Update.
3373         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3374         Update.
3375         (tui_set_locator_fullname, tui_set_locator_info)
3376         (tui_show_frame_info): Update.
3377         * tui/tui-source.c (tui_set_source_content)
3378         (tui_source_is_displayed): Update.
3379         * tui/tui-layout.c (show_source_disasm_command, show_data)
3380         (show_source_or_disasm_and_command): Update.
3381         * tui/tui-disasm.c (tui_set_disassem_content)
3382         (tui_get_begin_asm_address): Update.
3383         * tui/tui-data.h (struct tui_locator_element): Remove.
3384         (union tui_which_element) <locator>: Remove.
3385         (struct tui_locator_window): New.
3386         (tui_locator_win_info_ptr): Change return type.
3387         * tui/tui-data.c (_locator): Change type.
3388         (tui_locator_win_info_ptr): Change return type.
3389         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3390         (tui_alloc_content): Add assert.
3391
3392 2019-06-25  Tom Tromey  <tom@tromey.com>
3393
3394         * tui/tui-winsource.c
3395         (tui_exec_info_window::maybe_allocate_content): New method.
3396         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3397         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3398         (make_source_or_disasm_window): Add cast.
3399         * tui/tui-data.h (union tui_which_element) <simple_string>:
3400         Remove.
3401         (struct tui_source_info): New.
3402         (struct tui_source_window_base) <execution_info>: Change type.
3403         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3404         case, and add assert.
3405         (tui_alloc_content): Add assert.
3406
3407 2019-06-25  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3410         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3411         * tui/tui-data.c (tui_alloc_win_info): Remove.
3412
3413 2019-06-25  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3416         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3417         can_highlight.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3422         make_visible_with_new_height method.
3423         (tui_win_info::make_visible_with_new_height): New method.
3424         (tui_source_window_base::do_make_visible_with_new_height)
3425         (tui_data_window::do_make_visible_with_new_height)
3426         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3427         (make_visible_with_new_height): Remove.
3428         (tui_resize_all, tui_adjust_win_heights): Use
3429         make_visible_with_new_height method.
3430         * tui/tui-data.h (struct tui_win_info)
3431         <do_make_visible_with_new_height, make_visible_with_new_height>:
3432         New methods.
3433         (struct tui_source_window_base, struct tui_data_window)
3434         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3435         methods.
3436
3437 2019-06-25  Tom Tromey  <tom@tromey.com>
3438
3439         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3440         method.
3441         (update_tab_width): Call update_tab_width method.
3442         * tui/tui-data.h (struct tui_win_info)
3443         (struct tui_source_window_base) <update_tab_width>: New methods.
3444
3445 2019-06-25  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3448         parameter.
3449         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3450         parameter.
3451         (tui_gen_win_info::make_visible): Update.
3452         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3453         parameter.
3454         * tui/tui-data.h (enum tui_box): New enum.
3455         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3456
3457 2019-06-25  Tom Tromey  <tom@tromey.com>
3458
3459         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3460         init_and_make_win for EXEC_INFO_WIN.
3461         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3462         longer inline.
3463         (struct tui_win_info) <~tui_win_info>: Inline.
3464         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3465         Don't declare.
3466         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3467         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3468         Remove.
3469         (tui_initialize_static_data): Update.
3470         (~tui_gen_win_info): Handle more cleanup here.
3471         (~tui_source_window_base): Delete "execution_info".
3472         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-layout.c (make_command_window): Don't set
3477         can_highlight.
3478         (show_source_disasm_command): Call the reset method.
3479         (show_data): Don't set can_highlight.  Call the reset method.
3480         (tui_gen_win_info::reset): Rename from init_gen_win_info
3481         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3482         (show_source_or_disasm_and_command): Call the reset method.
3483         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3484         (struct tui_cmd_window): Set can_highlight.
3485
3486 2019-06-25  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3489         from make_visible.
3490         (tui_make_visible, tui_make_invisible): Rewrite.
3491         (tui_win_info::make_visible): Remove.
3492         (tui_source_window_base::make_visible): Update.
3493         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3494         method.  Moved from...
3495         (struct tui_win_info) <make_visible>: ...here.
3496
3497 2019-06-25  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-winsource.c
3500         (tui_source_window_base::do_scroll_horizontal): Remove direction
3501         parameter.
3502         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3503         direction parameter.
3504         * tui/tui-win.c (tui_win_info::forward_scroll)
3505         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3506         (tui_win_info::right_scroll): Update.
3507         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3508         direction parameter.
3509         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3510         direction parameter.
3511         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3512         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3513         Remove direction parameter.
3514         (struct tui_source_window_base, struct tui_source_window)
3515         (struct tui_disasm_window, struct tui_data_window)
3516         (struct tui_cmd_window): Update.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-winsource.h (tui_set_exec_info_content)
3521         (tui_show_exec_info_content, tui_erase_exec_info_content)
3522         (tui_clear_exec_info_content, tui_update_exec_info): Change
3523         argument to tui_source_window_base.
3524         * tui/tui-winsource.c (tui_set_exec_info_content)
3525         (tui_show_exec_info_content, tui_erase_exec_info_content)
3526         (tui_clear_exec_info_content, tui_update_exec_info): Change
3527         argument to tui_source_window_base.
3528
3529 2019-06-25  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3532         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3533
3534 2019-06-25  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3537         check.
3538
3539 2019-06-25  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3542         type to void.
3543         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3544         type to void.
3545         * tui/tui-source.c (tui_set_source_content): Update.
3546         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3547
3548 2019-06-25  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-win.c (window_name_completer, tui_set_focus)
3551         (tui_all_windows_info): Use name method.
3552         * tui/tui-data.h (struct tui_gen_win_info)
3553         (struct tui_source_window, struct tui_disasm_window)
3554         (struct tui_data_window, struct tui_cmd_window) <name>: New
3555         method.
3556         (tui_win_name): Don't declare.
3557         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3558         (tui_win_name): Remove.
3559
3560 2019-06-25  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-winsource.h (tui_update_source_window)
3563         (tui_update_source_window_as_is): Change parameter type.
3564         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3565         to be a tui_source_window_base.
3566         (tui_update_source_window_as_is): Likewise.
3567         * tui/tui-win.c (make_visible_with_new_height): Update.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-winsource.c (tui_erase_source_content)
3572         (tui_show_source_content, tui_show_exec_info_content)
3573         (tui_erase_exec_info_content): Use refresh_window method.
3574         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3575         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3576         from tui_refresh_win.
3577         (tui_data_window::refresh_window): New method.
3578         (tui_win_info::refresh, tui_source_window_base::refresh)
3579         (tui_refresh_all): Use refresh_window method.
3580         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3581         method.
3582         * tui/tui-regs.c (tui_display_register): Call refresh_window
3583         method.
3584         * tui/tui-layout.c (show_source_disasm_command)
3585         (show_source_or_disasm_and_command): Call refresh_window method.
3586         * tui/tui-data.h (struct tui_gen_win_info)
3587         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3588         New method.
3589
3590 2019-06-25  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui.c (tui_rl_other_window, tui_enable)
3593         (tui_is_window_visible, tui_get_command_dimension): Update.
3594         * tui/tui-winsource.c (tui_update_source_window_as_is)
3595         (tui_clear_source_content, tui_erase_source_content)
3596         (tui_show_source_line, tui_source_window_base::refill)
3597         (tui_source_window_base::do_scroll_horizontal)
3598         (tui_source_window_base::set_is_exec_point_at)
3599         (tui_update_breakpoint_info, tui_set_exec_info_content)
3600         (tui_alloc_source_buffer, tui_line_is_displayed)
3601         (tui_addr_is_displayed): Update.
3602         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3603         (tui_check_and_display_highlight_if_needed)
3604         (tui_win_info::make_visible, tui_win_info::refresh)
3605         (tui_refresh_all): Update.
3606         * tui/tui-windata.c (tui_first_data_item_displayed)
3607         (tui_delete_data_content_windows, tui_erase_data_content)
3608         (tui_display_all_data, tui_data_window::refresh_all)
3609         (tui_check_data_values): Update.
3610         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3611         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3612         (tui_win_info::backward_scroll, tui_refresh_all_win)
3613         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3614         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3615         (tui_source_window_base::set_new_height)
3616         (tui_data_window::set_new_height)
3617         (make_invisible_and_set_new_height)
3618         (make_visible_with_new_height, new_height_ok)
3619         (parse_scrolling_args): Update.
3620         * tui/tui-stack.c (tui_show_frame_info): Update.
3621         * tui/tui-source.c (tui_set_source_content)
3622         (tui_set_source_content_nil, tui_source_is_displayed)
3623         (tui_source_window::do_scroll_vertical): Update.
3624         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3625         (tui_display_registers_from, tui_display_reg_element_at_line)
3626         (tui_check_register_values, tui_reg_command): Update.
3627         * tui/tui-layout.c (tui_default_win_height)
3628         (show_source_disasm_command, show_data, init_and_make_win)
3629         (show_source_or_disasm_and_command): Update.
3630         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3631         (tui_redisplay_readline, tui_mld_flush)
3632         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3633         (tui_getc): Update.
3634         * tui/tui-disasm.c (tui_set_disassem_content)
3635         (tui_disasm_window::do_scroll_vertical): Update.
3636         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3637         Now virtual.
3638         (struct tui_win_info): Derive from tui_gen_win_info.
3639         <~tui_win_info>: Mark as override.
3640         <generic>: Remove member.
3641         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3642         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3643         (~tui_data_window, ~tui_win_info)
3644         (tui_free_all_source_wins_content): Update.
3645         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3646
3647 2019-06-25  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui-layout.c (init_and_make_win): Use new.
3650         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3651         destructor, initializers.
3652         (tui_alloc_generic_win_info): Don't declare.
3653         * tui/tui-data.c (_locator): Add argument to constructor.
3654         (source_win, disasm_win): New globals.
3655         (exec_info): Remove.
3656         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3657         Update.
3658         (tui_alloc_generic_win_info): Remove.
3659         (init_content_element): Use new.
3660         (tui_win_info::tui_win_info): Update.
3661         (free_content_elements) <case DATA_WIN>: Use delete.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3666         * tui/tui-windata.c (tui_first_data_item_displayed)
3667         (tui_delete_data_content_windows): Update.
3668         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3669         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3670         (tui_display_registers_from, tui_check_register_values): Update.
3671         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3672         pointer.
3673         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3674         window.
3675         (tui_free_data_content): Update.
3676         (free_content_elements) <case DATA_WIN>: Free the window.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3681         Update.
3682         * tui/tui-layout.c (make_command_window)
3683         (show_source_disasm_command, show_data, init_and_make_win)
3684         (show_source_or_disasm_and_command): Update.
3685         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3686         method.
3687         <can_highight, is_highlighted>: Now bool.
3688         (tui_set_win_highlight): Don't declare.
3689         * tui/tui-data.c (tui_set_win_highlight): Remove.
3690
3691 2019-06-25  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-wingeneral.c (make_visible): Remove check of window
3694         type.
3695
3696 2019-06-25  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-win.c (tui_win_info::max_height)
3699         (tui_cmd_window::max_height): New methods.
3700         (new_height_ok): Call max_height.
3701         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3702         <max_height>: New method.
3703
3704 2019-06-25  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-win.c (tui_source_window_base::set_new_height)
3707         (tui_data_window::set_new_height): New methods.
3708         (make_invisible_and_set_new_height): Call set_new_height method.
3709         * tui/tui-data.h (struct tui_win_info)
3710         (struct tui_source_window_base, struct tui_data_window)
3711         <set_new_height>: New method.
3712
3713 2019-06-25  Tom Tromey  <tom@tromey.com>
3714
3715         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3716         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3717         tui_refresh_data_win.
3718         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3719         method.
3720         (tui_refresh_all_win): Call the refresh_all method.
3721         (tui_set_focus): Likewise.
3722         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3723         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3724         Likewise.
3725
3726 2019-06-25  Tom Tromey  <tom@tromey.com>
3727
3728         * tui/tui-winsource.h (tui_refill_source_window)
3729         (tui_set_is_exec_point_at): Don't declare.
3730         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3731         (tui_source_window_base::refill): Rename from
3732         tui_refill_source_window.
3733         (tui_source_window_base::do_scroll_horizontal): Update.
3734         (tui_source_window_base::set_is_exec_point_at): Rename from
3735         tui_set_is_exec_point_at.
3736         (tui_update_all_breakpoint_info): Update.
3737         * tui/tui-stack.c (tui_show_frame_info): Update.
3738         * tui/tui-layout.c (show_data): Add cast.
3739         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3740         * tui/tui-data.h (struct tui_source_window_base) <refill,
3741         set_is_exec_point_at>: New methods.
3742         (tui_source_windows, tui_add_to_source_windows): Update types.
3743         (tui_add_to_source_windows): Remove redundant declaration.
3744         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3745         (tui_source_windows): Change return type.
3746         (tui_clear_source_windows_detail): Update.
3747         (tui_add_to_source_windows): Change type of parameter.
3748         (tui_free_all_source_wins_content): Update.
3749
3750 2019-06-25  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-wingeneral.c (tui_win_info::refresh)
3753         (tui_source_window_base::refresh): New methods.
3754         (tui_refresh_all): Call the refresh method.
3755         * tui/tui-data.h (struct tui_win_info)
3756         (struct tui_source_window_base) <refresh>: New method.
3757
3758 2019-06-25  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui.h (tui_is_window_visible): Return bool.
3761         * tui/tui.c (tui_is_window_visible): Return bool.
3762         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3763         (tui_make_visible, tui_make_invisible)
3764         (tui_win_info::make_visible)
3765         (tui_source_window_base::make_visible, make_all_visible)
3766         (tui_make_all_visible, tui_make_all_invisible): Update.
3767         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3768         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3769         bool.
3770         (struct tui_win_info, struct tui_source_window_base)
3771         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3772         * tui/tui-data.c (tui_init_generic_part): Update.
3773
3774 2019-06-25  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3777         (tui_source_window_base::make_visible): New methods.
3778         (make_all_visible): Make method call.
3779         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3780         (struct tui_source_window_base, struct tui_cmd_window): Override
3781         make_visible.
3782         (tui_win_is_source_type): Don't declare.
3783         * tui/tui-data.c (tui_win_is_source_type): Remove.
3784
3785 2019-06-25  Tom Tromey  <tom@tromey.com>
3786
3787         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3788         NULL check.
3789
3790 2019-06-25  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3793         Inline constructor.  Add initializers for members.
3794         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3795         constructors; now inline in class.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-regs.c (tui_show_registers): Update.
3800         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3801         bool.
3802         * tui/tui-data.c (tui_data_window::clear_detail)
3803         (tui_data_window): Update.
3804
3805 2019-06-25  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui-windata.c (tui_display_all_data)
3808         (tui_display_data_from_line, tui_display_data_from)
3809         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3810         Update.
3811         * tui/tui-regs.c (tui_last_regs_line_no)
3812         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3813         (tui_show_registers, tui_show_register_group)
3814         (tui_display_registers_from, tui_display_reg_element_at_line)
3815         (tui_display_registers_from_line, tui_check_register_values)
3816         (tui_reg_next, tui_reg_prev): Update.
3817         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3818         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3819         tui_data_window.
3820         (struct tui_win_info) <detail>: Remove.  Add new fields from
3821         tui_data_info.
3822         (TUI_DATA_WIN): Add cast.
3823         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3824         (~tui_data_window): Simplify.
3825
3826 2019-06-25  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-layout.c (show_source_disasm_command)
3829         (show_source_or_disasm_and_command): Update.
3830         * tui/tui-io.c (update_cmdwin_start_line)
3831         (tui_redisplay_readline): Update.
3832         * tui/tui-data.h (struct tui_command_info): Remove.
3833         (struct tui_win_info) <detail>: Remove command_info member.
3834         (struct tui_data_window) <start_line>: New member, from
3835         tui_command_info.
3836         (TUI_CMD_WIN): Add casts.
3837
3838 2019-06-25  Tom Tromey  <tom@tromey.com>
3839
3840         * tui/tui-winsource.c (tui_update_source_window)
3841         (tui_refill_source_window)
3842         (tui_source_window_base::do_scroll_horizontal)
3843         (tui_update_breakpoint_info, tui_set_exec_info_content)
3844         (tui_show_exec_info_content, tui_erase_exec_info_content)
3845         (tui_clear_exec_info_content): Update.
3846         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3847         Update.
3848         * tui/tui-win.c (make_invisible_and_set_new_height)
3849         (make_visible_with_new_height): Update.
3850         * tui/tui-source.c (tui_set_source_content)
3851         (tui_show_symtab_source): Update.
3852         * tui/tui-layout.c (extract_display_start_addr)
3853         (show_source_disasm_command, show_data)
3854         (make_source_or_disasm_window)
3855         (show_source_or_disasm_and_command): Update.
3856         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3857         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3858         "gdbarch".
3859         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3860         to tui_source_window_base.
3861         (struct tui_win_info) <detail>: Remove source_info member.
3862         (struct tui_source_window_base) <has_locator>: Inline.
3863         Move contents from tui_source_info; rename has_locator member to
3864         m_has_locator.
3865         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3866         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3867         header file.
3868         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3869         Simplify.
3870         (tui_free_all_source_wins_content): Cast to
3871         tui_source_window_base.
3872
3873 2019-06-25  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-win.c (make_invisible_and_set_new_height)
3876         (make_visible_with_new_height): Call has_locator method.
3877         * tui/tui-layout.c (show_source_disasm_command, show_data)
3878         (show_source_or_disasm_and_command): Update for bool change.
3879         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3880         (tui_win_info) <has_locator>: New method.
3881         (struct tui_source_window_base) <has_locator>: New method.
3882         (tui_win_has_locator): Don't declare.
3883         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3884         from tui_win_has_locator.
3885         (tui_source_window_base): Use false, not FALSE.
3886
3887 2019-06-25  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3890         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3891         clear_detail method directly.
3892         (tui_clear_win_detail): Remove.
3893
3894 2019-06-25  Tom Tromey  <tom@tromey.com>
3895
3896         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3897         "this", not TUI_DISASM_WIN.
3898
3899 2019-06-25  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3902         declare.
3903         * tui/tui-winsource.c
3904         (tui_source_window_base::do_scroll_horizontal): Rename from
3905         tui_horizontal_source_scroll.
3906         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3907         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3908         from tui_vertical_data_scroll.
3909         * tui/tui-win.h (tui_scroll): Don't declare.
3910         * tui/tui-win.c (tui_win_info::forward_scroll)
3911         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3912         (tui_win_info::right_scroll): Rename and update.
3913         (tui_scroll_forward_command, tui_scroll_backward_command)
3914         (tui_scroll_left_command, tui_scroll_right_command): Update.
3915         (tui_scroll): Remove.
3916         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3917         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3918         from tui_vertical_source_scroll.
3919         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3920         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3921         from tui_vertical_disassem_scroll.
3922         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3923         do_scroll_horizontal>: New methods.
3924         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3925         Likewise.
3926         (struct tui_source_window_base): Add do_scroll_horizontal.
3927         (struct tui_source_window, struct tui_disasm_window): Add
3928         do_scroll_vertical.
3929         (struct tui_data_window, struct tui_cmd_window): Add
3930         do_scroll_horizontal and do_scroll_vertical.
3931         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3932
3933 2019-06-25  Tom Tromey  <tom@tromey.com>
3934
3935         * tui/tui-data.h (struct tui_source_window_base): New struct.
3936         (struct tui_source_window): Derive from tui_source_window_base.
3937         (struct tui_disasm_window): New struct.
3938         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3939         from tui_source_window::clear_detail.
3940         (tui_source_window_base): Rename from tui_source_window.
3941         (~tui_source_window_base): Rename from ~tui_source_window.
3942         (tui_alloc_win_info): Create a tui_disasm_window.
3943
3944 2019-06-25  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-data.h (struct tui_source_window)
3947         (struct tui_data_window): Declare destructors.
3948         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3949         destructors.
3950         (tui_win_info): Simplify.
3951
3952 2019-06-25  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-winsource.c (tui_display_main)
3955         (tui_update_source_windows_with_addr)
3956         (tui_update_all_breakpoint_info): Update.
3957         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3958         (new_height_ok, parse_scrolling_args): Update.
3959         * tui/tui-stack.c (tui_show_frame_info): Update.
3960         * tui/tui-data.h (struct tui_list): Remove.
3961         (tui_source_windows): Return a reference to a std::vector.
3962         * tui/tui-data.c (source_windows): Now a std::vector.
3963         (tui_source_windows): Change return type.
3964         (tui_clear_source_windows): Rewrite.
3965         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3966         (tui_free_all_source_wins_content): Rewrite.
3967
3968 2019-06-25  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3971         (struct tui_data_window, struct tui_cmd_window): Declare
3972         clear_detail method.
3973         * tui/tui-data.c (tui_source_window::clear_detail)
3974         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3975         methods.
3976         (tui_clear_win_detail): Simplify.
3977
3978 2019-06-25  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-layout.c (make_source_window, make_disasm_window)
3981         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3982         Return the new window.
3983         (show_source_disasm_command, show_data)
3984         (show_source_or_disasm_and_command): Update.
3985
3986 2019-06-25  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3989         parameter.  Return the new window.
3990         (show_source_disasm_command): Update and remove NULL check.
3991         (show_source_or_disasm_and_command): Update.
3992
3993 2019-06-25  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3996
3997 2019-06-25  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-data.h (struct tui_win_info): Make constructor
4000         protected.  Make destructor virtual.  Add initializers.
4001         (tui_source_window, tui_data_window, tui_cmd_window): New
4002         classes.
4003         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4004         constructor.  Add "type" parameter.
4005         (tui_source_window, tui_data_window, tui_cmd_window): New
4006         constructors.
4007         (tui_alloc_win_info): Instantiate the appropriate subclass.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-win.c (tui_resize_all): Use delete.
4012         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4013         destructor.
4014         (tui_free_window): Don't declare.
4015         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4016         Update.
4017
4018 2019-06-25  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-data.h (struct tui_win_info): Add constructor.
4021         * tui/tui-data.c (tui_alloc_win_info): Use new.
4022         (tui_free_window): Use delete.
4023
4024 2019-06-22  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4027         declare.
4028         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4029
4030 2019-06-22  Tom Tromey  <tom@tromey.com>
4031
4032         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4033         declare.
4034         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4035
4036 2019-06-22  Tom de Vries  <tdevries@suse.de>
4037
4038         * dwarf2read.c (create_addrmap_from_aranges)
4039         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4040         instead of '%zu'.
4041
4042 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4043
4044         * dwarf2read.h (dwarf2_section_info_def): Remove.
4045         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4046         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4047         std::vector<dwarf2_section_info>.
4048         (struct dwo_file) <~dwo_file>: Remove.
4049         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4050         types field.
4051         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4052         (dwarf2_read_debug_names): Likewise.
4053         (create_debug_types_hash_table): Change parameter type to
4054         array_view, adjust code accordingly.
4055         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4056         (partial_die_info::fixup): Likewise.
4057         (determine_prefix): Likewise.
4058         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4059
4060 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4061
4062         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4063         gdb_bfd_ref_ptr.
4064         <~dwo_file>: Remove call to gdb_bfd_unref.
4065         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4066         gdb_bfd_ref_ptr::get.
4067
4068 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4069
4070         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4071         type to htab_up.
4072         * dwarf2read.c (struct dwo_file): Initialize fields.
4073         <~dwo_file>: New.
4074         (free_dwo_file): Remove, move content to ~dwo_file.
4075         (struct dwo_file_deleter): Remove.
4076         (dwo_file_up>: Remove custom deleter.
4077         (free_dwo_files): Remove.
4078         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4079         dwo_files.
4080         (process_skeletonless_type_units): Call unique_ptr::get.
4081         (allocate_dwo_file_hash_table): Add deleter to created hash
4082         table.  Change return type to htab_up.
4083         (lookup_dwo_file_slot): Don't memset dwo_file, call
4084         unique_ptr::get.
4085         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4086         (create_dwo_unit_in_dwp_v2): Likewise.
4087         (open_and_init_dwo_file): Likewise.
4088         (free_dwo_file_from_slot): Remove.
4089
4090 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4091
4092         * dwarf2read.h (struct dwarf2_section_info) <readin,
4093         is_virtual>: Change type to bool.
4094         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4095         true instead of 1.
4096
4097 2019-06-19  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-data.h (tui_init_content_element): Don't declare.
4100
4101 2019-06-19  Tom Tromey  <tom@tromey.com>
4102
4103         * tui/tui-data.h (tui_init_win_info): Don't declare.
4104
4105 2019-06-19  Tom de Vries  <tdevries@suse.de>
4106
4107         * dwarf2read.h (abstract_to_concrete): Change type to
4108         std::unordered_map<sect_offset, std::vector<sect_offset>,
4109         gdb::hash_enum<sect_offset>>.
4110
4111 2019-06-19  Tom Tromey  <tromey@adacore.com>
4112
4113         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4114         EVAL_AVOID_SIDE_EFFECTS specially.
4115
4116 2019-06-19  Tom Tromey  <tromey@adacore.com>
4117
4118         * source-cache.c (highlighter): New global.
4119         (source_cache::get_source_lines): Create a highlighter on demand.
4120
4121 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * defs.h (deprecated_interactive_hook): Delete declaration.
4124         * interps.c (clear_interpreter_hooks): Remove use of
4125         deprecated_interactive_hook.
4126         * top.c (deprecated_interactive_hook): Delete definition.
4127         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4128
4129 2019-06-18  Tom de Vries  <tdevries@suse.de>
4130
4131         PR gdb/24515
4132         * dwarf2read.h (abstract_to_concrete): Change type from
4133         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4134         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4135         * dwarf2read.c (read_variable): Update.
4136         (dwarf2_fetch_die_loc_sect_off): Update.
4137
4138 2019-06-17  Tom de Vries  <tdevries@suse.de>
4139
4140         PR gdb/24617
4141         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4142         accessing parent[parent_len - 1].
4143
4144 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4145
4146         PR gdb/24364
4147         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4148         call dtrace_process_dof with NULL dof.
4149
4150 2019-06-16  Tom de Vries  <tdevries@suse.de>
4151
4152         PR gdb/24445
4153         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4154
4155 2019-06-16  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4158         (make_all_visible): Use address of member.
4159
4160 2019-06-16  Tom Tromey  <tom@tromey.com>
4161
4162         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4163         (tui_free_window, free_content, free_content_elements): Remove
4164         unnecessary cast.
4165         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4166         cast.
4167         * tui/tui-regs.c (tui_show_register_group)
4168         (tui_display_registers_from, tui_display_reg_element_at_line):
4169         Remove unnecessary cast.
4170
4171 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4172
4173         * linux-nat.c (normal_mask): Delete.
4174         (_initialize_linux_nat): Don't initialise normal_mask.
4175
4176 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4177
4178         PR gdb/24445
4179         * dwarf-index-write.h (write_psymtabs_to_index): Add
4180         dwz_basename parameter.
4181         * dwarf-index-write.c (write_gdbindex): Move file writing to
4182         write_gdbindex_1.  Change return type void.
4183         (assert_file_size): Move up, remove filename parameter.
4184         (write_gdbindex_1): New function.
4185         (write_debug_names): Change return type to void, call
4186         assert_file_size.
4187         (struct index_wip_file): New struct.
4188         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4189         file logic to index_wip_file.  Write index for dwz file if
4190         needed.
4191         (save_gdb_index_command): Pass basename of dwz file, if present.
4192         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4193         build-id of dwz file, if present.
4194         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4195         (dwarf2_get_dwz_file): Likewise.
4196         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4197         (dwarf2_get_dwz_file): Likewise.
4198
4199 2019-06-16  Tom Tromey  <tom@tromey.com>
4200
4201         * coffread.c (process_coff_symbol): Use xstrdup.
4202         * value.c (create_internalvar): Use xstrdup.
4203
4204 2019-06-16  Tom Tromey  <tom@tromey.com>
4205
4206         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4207         * breakpoint.c (stopin_command, stopat_command)
4208         (until_break_command, decode_location_default): Remove unnecessary
4209         cast.
4210         * utils.c (subset_compare): Remove unnecessary cast.
4211         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4212         cast.
4213         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4214         cast.
4215         * infcmd.c (path_command): Remove unnecessary cast.
4216         * coffread.c (decode_type): Remove unnecessary cast.
4217         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4218         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4219         * tui/tui-stack.c (tui_show_locator_content)
4220         (tui_show_frame_info): Remove unnecessary cast.
4221         * tui/tui-win.c (tui_scroll_forward_command)
4222         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4223         (parse_scrolling_args): Remove unnecessary cast.
4224         * tui/tui-data.c (init_win_info, tui_del_window)
4225         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4226         (free_content_elements): Remove unnecessary cast.
4227         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4228         unnecessary cast.
4229         * tui/tui-source.c (tui_set_source_content)
4230         (tui_vertical_source_scroll): Remove unnecessary cast.
4231         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4232         cast.
4233         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4234         * tui/tui-regs.c (tui_display_registers_from)
4235         (tui_display_register): Remove unnecessary cast.
4236         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4237         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4238         (make_visible): Remove unnecessary cast.
4239         * tui/tui-winsource.c (tui_erase_source_content)
4240         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4241         unnecessary cast.
4242         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4243         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4244         * stabsread.c (read_type, read_array_type, read_range_type):
4245         Remove unnecessary cast.
4246         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4247         (parse_symbol, parse_type, upgrade_type, parse_external)
4248         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4249         unnecessary cast.
4250         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4251
4252 2019-06-16  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-data.c (tui_alloc_generic_win_info)
4255         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4256         checks.
4257
4258 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4259             Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * f-typeprint.c (f_print_type): Don't return early for not
4262         associated or not allocated types.
4263         (f_type_print_varspec_suffix): Add print_rank parameter and print
4264         ranks of array types in case they dangling.
4265         (f_type_print_base): Add print_rank parameter.
4266
4267 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * NEWS: Mention new MI commands.
4270         * break-catch-throw.c (enum exception_event_kind): Move to
4271         breakpoint.h.
4272         (print_mention_exception_catchpoint): Output text as a single
4273         message.
4274         (catch_exception_command_1): Rename to...
4275         (catch_exception_event): ...this, make non-static, update header
4276         command, and change some parameter types.
4277         (catch_catch_command): Update for changes to
4278         catch_exception_command_1.
4279         (catch_throw_command): Likewise.
4280         (catch_rethrow_command): Likewise.
4281         * breakpoint.c (enum exception_event_kind): Delete.
4282         * breakpoint.h (enum exception_event_kind): Moved here from
4283         break-catch-throw.c.
4284         (catch_exception_event): Declare.
4285         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4286         (mi_cmd_catch_throw): New function.
4287         (mi_cmd_catch_rethrow): New function.
4288         (mi_cmd_catch_catch): New function.
4289         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4290         'catch-catch' entries.
4291         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4292         (mi_cmd_catch_rethrow): Declare.
4293         (mi_cmd_catch_catch): Declare.
4294
4295 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         * annotate.c (annotate_source_line): Change return type to void,
4298         update implementation to match.
4299         * annotate.h (annotate_source_line): Change return type to void,
4300         update header comment.
4301         * stack.c (print_frame_info): Don't change what frame information
4302         is printed based on whether annotations are on or not.
4303
4304 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4305
4306         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4307         (annotate_source): Make static.
4308         (annotate_source_line): Moved from source.c and renamed from
4309         identify_source_line.  Update the return type.
4310         * annotate.h (annotate_source): Delete declaration.
4311         (annotate_source_line): Declaration moved from source.h, and
4312         renamed from identify_source_line.  Return type updated.
4313         * source.c (identify_source_line): Moved to annotate.c and renamed
4314         to annotate_source_line.
4315         (info_line_command): Remove check of annotation_level.
4316         * source.h (identify_source_line): Move declaration to annotate.h
4317         and rename to annotate_source_line.
4318         * stack.c: Add 'annotate.h' include.
4319         (print_frame_info): Remove check of annotation_level before
4320         calling annotate_source_line.
4321
4322 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * source-cache.c (source_cache::get_plain_source_lines): Use
4325         open_source_file_with_line_charpos instead of just
4326         open_source_file, remove call to find_source_lines.
4327         (source_cache::get_source_lines): Likewise.
4328         * source.c (find_source_lines): Make static.
4329         (get_filename_and_charpos): Renamed into...
4330         (open_source_file_with_line_charpos): ..this along with changes to
4331         return a scoped_fd, and some other minor clean ups.
4332         (identify_source_line): Use open_source_file_with_line_charpos.
4333         (search_command_helper): Use open_source_file_with_line_charpos
4334         instead of just open_source_file, remove call to
4335         find_source_lines.
4336         * source.h (open_source_file_with_line_charpos): Declare new
4337         function.
4338         (find_source_lines): Delete declaration.
4339
4340 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * source.c (get_filename_and_charpos): Remove fullname
4343         parameter.
4344         (identify_source_line): Update call to get_filename_and_charpos.
4345
4346 2019-06-14  Tom Tromey  <tromey@adacore.com>
4347
4348         PR gdb/24502:
4349         * ui-style.h (skip_ansi_escape): Update comment.
4350         * ui-file.h (class no_terminal_escape_file): New class.
4351         * ui-file.c (no_terminal_escape_file::write)
4352         (no_terminal_escape_file::puts): New methods.
4353         * cli/cli-logging.c (handle_redirections): Use
4354         no_terminal_escape_file.
4355
4356 2019-06-14  Tom Tromey  <tromey@adacore.com>
4357
4358         * NEWS: Move convenience variable news above Python news.
4359
4360 2019-06-14  Tom Tromey  <tom@tromey.com>
4361
4362         * gnulib: Move directory to top-level.
4363         * configure.ac: Don't configure gnulib.
4364         * configure: Rebuild.
4365         * common/common-defs.h: Use new path to gnulib.
4366         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4367         (GNULIB_H): Remove.
4368         (INCGNU): Look in new gnulib location.
4369         (HFILES_NO_SRCDIR): Remove gnulib files.
4370         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4371         (generated_files): Remove GNULIB_H.
4372         ($(LIBGNU), all-lib): Remove targets.
4373         (distclean): Don't mention GNULIB_BUILDDIR.
4374         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4375
4376 2019-06-14  Tom Tromey  <tromey@adacore.com>
4377
4378         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4379         Warn if symbol file does not provide any symbols.
4380
4381 2019-06-14  Tom Tromey  <tromey@adacore.com>
4382
4383         * source.c (find_and_open_source): Respect basenames_may_differ.
4384
4385 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4386
4387         * annotate.c (annotate_breakpoints_invalid): Make use of
4388         scoped_restore_terminal_state.
4389         (annotate_frames_invalid): Likewise.
4390
4391 2019-06-14  Tom Tromey  <tromey@adacore.com>
4392
4393         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4394         allow assignment to an internalvar.
4395
4396 2019-06-14  Tom Tromey  <tromey@adacore.com>
4397
4398         * ada-lex.l: Allow "_" in attribute names.
4399
4400 2019-06-14  Tom Tromey  <tromey@adacore.com>
4401
4402         PR gdb/24653:
4403         * regcache.c (registers_changed): Don't call alloca.
4404         * top.c (execute_command): Don't call alloca.
4405
4406 2019-06-13  Pedro Alves  <palves@redhat.com>
4407
4408         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4409         'expression'.  When parsing an expression, error out if there's
4410         junk after "unlimited".
4411         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4412         (do_set_command): Adjust calls to is_unlimited_literal.
4413
4414 2019-06-13  Pedro Alves  <palves@redhat.com>
4415
4416         * compile/compile.c (make_compile_options_def_group): Add braces
4417         around array_view initializer.
4418         * thread.c (make_thread_apply_all_options_def_group)
4419         (make_thread_apply_all_options_def_group): Likewise.
4420
4421 2019-06-13  Pedro Alves  <palves@redhat.com>
4422
4423         * NEWS (New commands): Mention "maint test-options
4424         require-delimiter", "maint test-options unknown-is-error", "maint
4425         test-options unknown-is-operand" and "maint show
4426         test-options-completion-result".
4427         (New command options, command completion): New section.
4428         (Completion improvements): New section.
4429         Mention that you can abbreviate "unlimited".
4430
4431 2019-06-13  Pedro Alves  <palves@redhat.com>
4432
4433         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4434         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4435         * unittests/cli-utils-selftests.c (test_parse_flags)
4436         (test_parse_flags_qcs): Delete.
4437         (test_cli_utils): Don't call deleted functions.
4438
4439 2019-06-13  Pedro Alves  <palves@redhat.com>
4440
4441         * thread.c: Include "cli/cli-option.h".
4442         (tp_array_compar_ascending): Global.
4443         (tp_array_compar): Delete function.
4444         (tp_array_compar_ascending, tp_array_compar_descending): New
4445         functions.
4446         (ascending_option_def, qcs_flag_option_def)
4447         (thr_qcs_flags_option_defs)
4448         (make_thread_apply_all_options_def_group)
4449         (make_thread_apply_options_def_group): New.
4450         (thread_apply_all_command): Use gdb::option::process_options.
4451         (thread_apply_command_completer)
4452         (thread_apply_all_command_completer): New.
4453         (thread_apply_command): Use gdb::option::process_options.
4454         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4455         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4456         to generate help text of "thread apply".  Adjust "taas"'s help.
4457         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4458         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4459
4460 2019-06-13  Pedro Alves  <palves@redhat.com>
4461
4462         * thread.c (thread_apply_command): Check for invalid TID with
4463         isdigit instead of !isalpha.
4464
4465 2019-06-13  Pedro Alves  <palves@redhat.com>
4466
4467         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4468         (validate_flags_qcs): New.
4469         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4470         (validate_flags_qcs): Declare.
4471         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4472         (make_frame_apply_options_def_group): New.
4473         (frame_apply_command_count): Process options with
4474         gdb::option::process_options.
4475         (frame_apply_completer): New.
4476         (frame_apply_level_completer, frame_apply_all_completer)
4477         (frame_apply_completer): New.
4478         (_initialize_stack): Update help of "frame apply", "frame apply
4479         level", "frame apply all" and "faas" to mention supported options
4480         and install command completers.
4481         * stack.h (frame_apply_all_completer): Declare.
4482         * thread.c: Include "stack.h".
4483         (tfaas_command): Add "--".
4484         (_initialize_thread): Update help "tfaas" to mention supported
4485         options and install command completer.
4486
4487 2019-06-13  Pedro Alves  <palves@redhat.com>
4488
4489         * completer.c (complete_nested_command_line): New.
4490         (gdb_completion_word_break_characters_throw): Add assertion.
4491         * completer.h (complete_nested_command_line): Declare.
4492
4493 2019-06-13  Pedro Alves  <palves@redhat.com>
4494
4495         * stack.c (parse_backtrace_qualifiers): New.
4496         (backtrace_command): Use it.
4497         (backtrace_command_completer): Complete on qualifiers.
4498
4499 2019-06-13  Pedro Alves  <palves@redhat.com>
4500
4501         * frame.c: Include "cli/cli-option.h.
4502         (user_set_backtrace_options): New.
4503         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4504         Delete.
4505         (get_prev_frame): Adjust.
4506         (boolean_option_def, uinteger_option_def)
4507         (set_backtrace_option_defs): New.
4508         (_initialize_frame): Adjust and use
4509         gdb::option::add_setshow_cmds_for_options to install "set
4510         backtrace past-main" and "set backtrace past-entry".
4511         * frame.h: Include "cli/cli-option.h".
4512         (struct frame_print_options): Forward declare.
4513         (print_frame_arguments_all, print_frame_arguments_scalars)
4514         (print_frame_arguments_none): Declare.
4515         (print_entry_values): Delete declaration.
4516         (struct frame_print_options, user_frame_print_options): New.
4517         (struct set_backtrace_options): New.
4518         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4519         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4520         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4521         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4522         (list_args_or_locals): Add frame_print_options parameter.
4523         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4524         * python/py-framefilter.c (enumerate_args): Pass down
4525         USER_FRAME_PRINT_OPTIONS.
4526         * stack.c: Include "cli/cli-option.h".
4527         (print_frame_arguments_all, print_frame_arguments_scalars)
4528         (print_frame_arguments_none): Declare.
4529         (print_raw_frame_arguments, print_entry_values): Delete.
4530         (user_frame_print_options): New.
4531         (boolean_option_def, enum_option_def, frame_print_option_defs):
4532         New.
4533         (struct backtrace_cmd_options): New.
4534         (bt_flag_option_def): New.
4535         (backtrace_command_option_defs): New.
4536         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4537         (print_frame_arg, read_frame_arg, print_frame_args)
4538         (print_frame_info, print_frame): Add frame_print_options parameter
4539         and use it.
4540         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4541         (backtrace_command_1): Add frame_print_options and
4542         backtrace_cmd_options parameters and use them.
4543         (make_backtrace_options_def_group): New.
4544         (backtrace_command): Process command options with
4545         gdb::option::process_options.
4546         (backtrace_command_completer): New.
4547         (_initialize_stack): Extend "backtrace"'s help to mention
4548         supported options.  Install completer for "backtrace".
4549         Install some settings commands with add_setshow_cmds_for_options.
4550
4551 2019-06-13  Pedro Alves  <palves@redhat.com>
4552
4553         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4554         and that "set/show print raw frame-arguments" are now deprecated.
4555
4556         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4557         command.
4558         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4559         * stack.c (_initialize_stack): Install "set/show print
4560         raw-frame-arguments", and deprecate "set/show print raw
4561         frame-arguments".
4562         * valprint.c (_initialize_valprint): Deprecate "set/show print
4563         raw".
4564
4565 2019-06-13  Pedro Alves  <palves@redhat.com>
4566
4567         * compile/compile.c (struct compile_options): New.
4568         (compile_flag_option_def, compile_command_option_defs)
4569         (make_compile_options_def_group): New.
4570         (compile_file_command): Handle options with
4571         gdb::option::process_options.
4572         (compile_file_command_completer): New function.
4573         (compile_code_command): Handle options with
4574         gdb::option::process_options.
4575         (compile_code_command_completer): New function.
4576         (_initialize_compiler): Install completers for "compile code" and
4577         "compile file".  Mention available options in "compile code" and
4578         "compile code"'s help.
4579         * completer.c (advance_to_completion_word): New, factored out from
4580         ...
4581         (advance_to_expression_complete_word_point): ... this.
4582         (advance_to_filename_complete_word_point): New.
4583         * completer.h (advance_to_filename_complete_word_point): New
4584         declaration.
4585
4586 2019-06-13  Pedro Alves  <palves@redhat.com>
4587
4588         * compile/compile.c: Include "cli/cli-option.h".
4589         (compile_print_value): Scope data pointer is now a
4590         value_print_options pointer; adjust.
4591         (compile_print_command): Process options.  Scope data pointer is
4592         now a value_print_options pointer; adjust.
4593         (_initialize_compile): Update "compile print"'s help to include
4594         supported options.  Install a completer for "compile print".
4595         * cp-valprint.c (show_vtblprint, show_objectprint)
4596         (show_static_field_print): Delete.
4597         (_initialize_cp_valprint): Don't install "set print
4598         static-members", "set print vtbl", "set print object" here.
4599         * printcmd.c: Include "cli/cli-option.h" and
4600         "common/gdb_optional.h".
4601         (print_command_parse_format): Rework to fill in a
4602         value_print_options instead of a format_data.
4603         (print_value): Change parameter type from format_data pointer to
4604         value_print_options reference.  Adjust.
4605         (print_command_1): Process options.  Adjust to pass down a
4606         value_print_options.
4607         (print_command_completer): New.
4608         (_initialize_printcmd): Install print_command_completer as
4609         handle_brkchars completer for the "print" command.  Update
4610         "print"'s help to include supported options.
4611         * valprint.c: Include "cli/cli-option.h".
4612         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4613         here from cp-valprint.c.
4614         (boolean_option_def, uinteger_option_def)
4615         (value_print_option_defs, make_value_print_options_def_group):
4616         New.  Use gdb::option::add_setshow_cmds_for_options to install
4617         "set print elements", "set print null-stop", "set print repeats",
4618         "set print pretty", "set print union", "set print array", "set
4619         print address", "set print symbol", "set print array-indexes".
4620         * valprint.h: Include <string> and "cli/cli-option.h".
4621         (make_value_print_options_def_group): Declare.
4622         (print_value): Change parameter type from format_data pointer to
4623         value_print_options reference.
4624         (print_command_completer): Declare.
4625
4626 2019-06-13  Pedro Alves  <palves@redhat.com>
4627
4628         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4629         (COMMON_SFILES): Add maint-test-settings.c.
4630         * cli/cli-decode.c (boolean_enums): New global, factored out from
4631         ...
4632         (add_setshow_boolean_cmd): ... here.
4633         * cli/cli-decode.h (boolean_enums): Declare.
4634         * cli/cli-option.c: New file.
4635         * cli/cli-option.h: New file.
4636         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4637         factored out from ...
4638         (parse_cli_boolean_value(const char *)): ... this.
4639         (is_unlimited_literal): Change parameter type to pointer to
4640         pointer.  Adjust and advance ARG pointer.
4641         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4642         (parse_cli_var_enum): New, factored out from ...
4643         (do_set_command): ... this.  Adjust.
4644         * cli/cli-setshow.h (parse_cli_boolean_value)
4645         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4646         (parse_cli_var_enum): Declare.
4647         * cli/cli-utils.c: Include "cli/cli-option.h".
4648         (get_ulongest): New.
4649         * cli/cli-utils.h (get_ulongest): Declare.
4650         (check_for_argument): New overloads.
4651         * maint-test-options.c: New file.
4652
4653 2019-06-13  Pedro Alves  <palves@redhat.com>
4654
4655         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4656         parse a range if "-" is at the end of the string.
4657
4658 2019-06-13  Pedro Alves  <palves@redhat.com>
4659
4660         * cli/cli-setshow.c (parse_auto_binary_operation)
4661         (parse_cli_boolean_value): Don't allow "o".
4662
4663 2019-06-13  Pedro Alves  <palves@redhat.com>
4664
4665         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4666         * NEWS: Mention maint test-settings KIND.
4667         * maint-test-settings.c: New file.
4668
4669 2019-06-13  Pedro Alves  <palves@redhat.com>
4670
4671         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4672         completer.
4673         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4674         "set" completers.
4675
4676 2019-06-13  Pedro Alves  <palves@redhat.com>
4677
4678         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4679         after item.
4680
4681 2019-06-13  Pedro Alves  <palves@redhat.com>
4682
4683         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4684
4685 2019-06-13  Pedro Alves <palves@redhat.com>
4686
4687         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4688         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4689         call.
4690         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4691         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4692         calls.
4693         (check_for_argument): Skip spaces after argument.
4694
4695 2019-06-13  Pedro Alves  <palves@redhat.com>
4696
4697         * thread.c (thread_apply_command): Adjust TID parsing.
4698         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4699         detected before end of string.
4700         (tid_is_in_list): Error out if LIST is invalid.
4701
4702 2019-06-13  Pedro Alves  <palves@redhat.com>
4703
4704         * completer.c (complete_line_internal_1): Rewind completion word
4705         point.
4706         (completion_tracker::advance_custom_word_point_by): Change
4707         parameter type to int.
4708         * completer.h (completion_tracker::advance_custom_word_point_by):
4709         Likewise.
4710
4711 2019-06-13  Pedro Alves  <palves@redhat.com>
4712
4713         * completer.c (advance_to_completion_word): Handle delimiters.
4714
4715 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4716
4717         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4718
4719 2019-06-11  Tom Tromey  <tom@tromey.com>
4720
4721         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4722         (xmalloc_failed): Move to alloc.c.
4723         * alloc.c: New file.
4724         * Makefile.in (COMMON_SFILES): Add alloc.c.
4725
4726 2019-06-11  Tom Tromey  <tom@tromey.com>
4727
4728         * nat/linux-waitpid.c: Don't include server.h.
4729         (linux_debug): Remove.
4730         (my_waitpid): Update.
4731
4732 2019-06-11  Tom Tromey  <tromey@adacore.com>
4733
4734         * infcall.c (_initialize_infcall): Remove trailing newline from
4735         help.
4736         * user-regs.c (_initialize_user_regs): Remove trailing newline
4737         from help.
4738         * typeprint.c (_initialize_typeprint): Remove trailing newline
4739         from help.
4740         * reverse.c (_initialize_reverse): Remove trailing newlines from
4741         help.
4742         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4743         from help.
4744         * language.c (add_set_language_command): Remove trailing newline
4745         from help.
4746         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4747         help.
4748         * disasm.c (_initialize_disasm): Remove trailing newline from
4749         help.
4750         * top.c (init_main): Remove trailing newline from help.
4751         * interps.c (_initialize_interpreter): Remove trailing newline
4752         from help.
4753         * btrace.c (_initialize_btrace): Remove trailing newlines from
4754         help.
4755         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4756         from help.
4757         * python/python.c (_initialize_python): Remove trailing newline
4758         from help.
4759         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4760         help.
4761         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4762         from help.  Reformat some text.
4763         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4764         from help.
4765         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4766         newline from help.
4767
4768 2019-06-11  Tom Tromey  <tromey@adacore.com>
4769
4770         * darwin-nat.c (darwin_decode_exception_message)
4771         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4772
4773 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * valops.c (value_slice): Check for not allocated or not
4776         associated values.
4777
4778 2019-06-10  Tom de Vries  <tdevries@suse.de>
4779
4780         PR gdb/24618
4781         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4782         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4783         invalid.
4784
4785 2019-06-10  Tom de Vries  <tdevries@suse.de>
4786
4787         PR gdb/24611
4788         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4789         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4790
4791 2019-06-10  Tom de Vries  <tdevries@suse.de>
4792
4793         PR symtab/24545
4794         * symtab.c (struct demangled_name_entry): Add language field.
4795         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4796         static minimal symbol".  Set and use language field.
4797
4798 2019-06-10  Tom Tromey  <tromey@adacore.com>
4799
4800         * ada-lang.c (_initialize_ada_language): Update help text.
4801
4802 2019-06-10  Tom Tromey  <tromey@adacore.com>
4803
4804         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4805         with a newline.
4806         * guile/guile.c (handle_boot_error): Don't end warning with a
4807         newline.
4808         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4809         warning with a newline.
4810         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4811         newline.
4812         (s12z_frame_cache): Likewise.
4813         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4814         a newline.
4815         * solib-svr4.c (disable_probes_interface): Don't end warning with
4816         a newline.
4817         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4818         newline.
4819         * python/python.c (do_finish_initialization): Don't end warning
4820         with a newline.
4821
4822 2019-06-10  Tom Tromey  <tom@tromey.com>
4823
4824         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4825         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4826         gdbpy_enter.
4827
4828 2019-06-10  Tom Tromey  <tromey@adacore.com>
4829
4830         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4831         data.
4832         (elf_new_init): Don't call stabsread_new_init.
4833         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4834         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4835         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4836
4837 2019-06-10  Tom de Vries  <tdevries@suse.de>
4838
4839         PR symtab/16264
4840         PR symtab/24517
4841         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4842
4843 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4844
4845         * source.c (find_and_open_source): Also rewrite relative file
4846         names.
4847
4848 2019-04-26  Amos Bird  <amosbird@gmail.com>
4849
4850         * annotate.c (annotate_thread_exited): Add "thread-exited"
4851         annotation.
4852
4853 2019-06-06  Tom Tromey  <tromey@adacore.com>
4854
4855         * maint.h (class scoped_command_stats): Use
4856         DISABLE_COPY_AND_ASSIGN.
4857         <print_time>: New method.
4858         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4859         print_time.
4860         (scoped_command_stats::print_time): New method.
4861
4862 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4865         instructions of lengths 6 or 8 bytes.
4866
4867 2019-06-04  Pedro Alves  <palves@redhat.com>
4868
4869         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4870
4871         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4872         * breakpoint.c (condition_completer): Likewise.
4873         * cli/cli-dump.c (scan_expression): Likewise.
4874         * common/filestuff.c (mkdir_recursive): Likewise.
4875         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4876         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4877         (gdb_abspath): Likewise.
4878         * compile/compile-cplus-types.c
4879         (compile_cplus_instance::decl_name): Likewise.
4880         * completer.c (complete_explicit_location):
4881         (signal_completer, reg_or_group_completer_1): Likewise.
4882         * cp-support.c (cp_remove_params_if_any): Likewise.
4883         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4884         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4885         * infcmd.c (strip_bg_char): Likewise.
4886         * linespec.c (copy_token_string): Likewise.
4887         * mi/mi-main.c (output_cores): Likewise.
4888         * psymtab.c (psymtab_search_name):
4889         * symfile.c (test_set_ext_lang_command): Likewise.
4890         * target.c (target_fileio_read_stralloc): Likewise.
4891         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4892         * value.c (complete_internalvar): Likewise.
4893
4894 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4895
4896         Add objfile property to gdb.Type.
4897         * NEWS: Mention Python API addition.
4898         * python/py-type.c (typy_get_objfile): New method.
4899
4900 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4901
4902         * NEWS: Mention the new set|show style [title|highlight].
4903         Mention changes to "show style", "help" and "apropos".
4904
4905 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4906
4907         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4908         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4909         instead of print_help_for_command.
4910         (print_doc_of_command): New function.
4911         (help_list): Add 'apropos -v word' suggestion.
4912         (print_help_for_command): Style the command name using title style.
4913         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4914         (_initialize_cli_cmds): Describe -v in apropos_command help.
4915
4916 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4917
4918         * cli/cli-style.h (cli_style_option): Add name in constructor,
4919         add m_name class member, add constructor with intensity,
4920         add name class function.
4921         (cli_style_option::add_setshow_commands): Remove name argument.
4922         (highlight_style, title_style): New styles.
4923         * cli/cli-style.c (do_show): New function that shows a style
4924         characteristic styling the style name with itself.
4925         (set_style_name): New function.
4926         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4927         Update all callers according to the changes in cli/cli-style.h.
4928         * utils.h (fputs_highlighted): New function.
4929         * utils.c (fputs_highlighted): Likewise.
4930
4931 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4932
4933         * NEWS: Mention new pipe command and new convenience variables.
4934
4935 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4936
4937         * cli/cli-cmds.c (pipe_command): New function.
4938         (_initialize_cli_cmds): Call add_com for pipe_command.
4939         Define | as an alias for pipe.
4940         (exit_status_set_internal_vars): New function.
4941         (shell_escape): Call exit_status_set_internal_vars.
4942         cli/cli-decode.c (find_command_name_length): Recognize | as
4943         a single character command.
4944
4945 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4946
4947         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4948         top.c (execute_command_to_ui_file): New function, mostly a copy
4949         of execute_command_to_string.
4950         (execute_command_to_string): Implement by calling
4951         execute_command_to_ui_file.
4952
4953 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4954
4955         * top.h (saved_command_line): Remove declaration.
4956         * top.c (previous_saved_command_line, previous_repeat_arguments):
4957         New variables.
4958         (saved_command_line): Make static, define together with other
4959         'repeat variables'.
4960         (dont_repeat): Clear repeat_arguments.
4961         (repeat_previous, get_saved_command_line, save_command_line):
4962         New functions.
4963         (gdb_init): Initialize saved_command_line
4964         and previous_saved_command_line.
4965         * main.c (captured_main_1): Remove saved_command_line initialization.
4966         * event-top.c (handle_line_of_input): Update to use
4967         the new 'repeat' related functions instead of direct access to
4968         saved_command_line.
4969         * command.h (repeat_previous, get_saved_command_line,
4970         save_command_line): New declarations.
4971         (dont_repeat): Add comment.
4972
4973 2019-05-30  Tom Tromey  <tromey@adacore.com>
4974
4975         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4976         Fix comment.
4977         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4978
4979 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4980
4981         PR cli/24587
4982         * completer.c (complete): Initialize variable word.
4983
4984 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4985
4986         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4987         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4988         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4989         'body' is NULL to the outter 'if', protecting the '!is_define'
4990         situation as well.
4991
4992 2019-05-29  Tom Tromey  <tromey@adacore.com>
4993
4994         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4995         (dwarf_unknown): New function.
4996         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4997         (dwarf_type_encoding_name): Use dwarf_unknown.
4998
4999 2019-05-29  Tom Tromey  <tromey@adacore.com>
5000
5001         PR c++/20020:
5002         * cp-valprint.c (cp_print_value_fields): Call
5003         cp_print_static_field inside "try".
5004
5005 2019-05-29  Tom Tromey  <tromey@adacore.com>
5006
5007         * inflow.c (struct terminal_info): Add default operator=.
5008         * configure: Rebuild.
5009         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5010         -Wdeprecated-copy-dtor, -Wredundant-move.
5011
5012 2019-05-29  Tom Tromey  <tromey@adacore.com>
5013
5014         * NEWS: Add entry.
5015         * infcmd.c (print_return_value_1): Handle finish_print
5016         option.
5017         (show_print_finish): New function.
5018         (_initialize_infcmd): Add "set/show print finish" commands.
5019         * valprint.c (user_print_options): Initialize new member.
5020         * valprint.h (struct value_print_options) <finish_print>: New
5021         member.
5022
5023 2019-05-28  Tom Tromey  <tromey@adacore.com>
5024
5025         * ada-lang.c (ada_remove_Xbn_suffix)
5026         (find_old_style_renaming_symbol)
5027         (parse_old_style_renaming): Remove.
5028         (ada_find_renaming_symbol): Don't call
5029         find_old_style_renaming_symbol.
5030         (ada_is_renaming_symbol): Rename from
5031         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5032         bool.  Now static.
5033         (ada_read_var_value): Update and simplify.
5034         * ada-exp.y (write_var_or_type): Remove old code.
5035
5036 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5037
5038         * event-top.c: Remove include comment.
5039         * inflow.c (class scoped_ignore_sigttou): Move from here...
5040         * inflow.h (class scoped_ignore_sigttou): ...to here.
5041         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5042         * top.c:  Remove include comment.
5043
5044 2019-05-27  Tom Tromey  <tom@tromey.com>
5045
5046         * NEWS: Fix typo.
5047
5048 2019-05-22  Tom Tromey  <tromey@adacore.com>
5049
5050         * target.c (target_follow_exec): Constify parameter.
5051         * target-delegates.c: Rebuild.
5052         * remote.c (remote_target::follow_exec): Constify parameter.
5053         * infrun.c (follow_exec): Constify parameter.
5054         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5055         (target_follow_exec): Likewise.
5056
5057 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5058
5059         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5060         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5061
5062 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5063
5064         * NEWS: Add debugredirect and testsuite sections.
5065
5066 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5067
5068         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5069         target descriptions using exclusively floating point register name
5070         aliases.
5071
5072 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         PR gdb/18644:
5075         * f-lang.c (build_fortran_types): Handle the case where
5076         gdbarch_floatformat_for_type returns a nullptr.
5077
5078 2019-05-21  Tom de Vries  <tdevries@suse.de>
5079
5080         PR cli/24587
5081         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5082
5083 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5084
5085         PR gdb/18644:
5086         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5087         16-byte floats.
5088         * i386-tdep.c (i386_floatformat_for_type): Use
5089         floatformats_ia64_quad for the 16-byte floating point component
5090         within a fortran 32-byte complex number.
5091
5092 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5095         delete default constructor.
5096         (find_partial_die): Update to return const struct.
5097         (partial_die_parent_scope): Move variable declaration into scope
5098         of its use and change its type to auto.
5099         (guess_partial_die_structure_name): Likewise.
5100         (partial_die_info::fixup): Likewise.
5101
5102 2019-05-17  Tom Tromey  <tromey@adacore.com>
5103
5104         * source.c (find_and_open_source): Remove cast.
5105
5106 2019-05-17  Tom Tromey  <tromey@adacore.com>
5107
5108         * annotate.c (annotate_source): Make "filename" const.
5109         * annotate.h (annotate_source): Use const.
5110
5111 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5112
5113         * disasm.c (set_disassembler_options): Send errors to stderr.
5114
5115 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5116
5117         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5118         (cli_interp_base::set_logging): Check debug_redirect.
5119         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5120         * cli/cli-logging.c (debug_redirect): Add static variable.
5121         (pop_output_files): Add default param.
5122         (handle_redirections): Print debug setting.
5123         (show_logging_command): Likewise.
5124         (_initialize_cli_logging): Add debugredirect command.
5125         * interps.c (current_interp_set_logging): Add debug_redirect
5126         parameter.
5127         * interps.h (set_logging): Add debug_redirect parameter.
5128         (current_interp_set_logging): Likewise.
5129         * mi/mi-common.h: Likewise.
5130         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5131
5132 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5133             Tom Tromey  <tromey@adacore.com>
5134
5135         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5136         directly.
5137         * cli/cli-interp.h (make_logging_output): Remove declaration.
5138         * cli/cli-logging.c (make_logging_output): Remove function.
5139         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5140         directly.
5141         * ui-file.c (tee_file::tee_file): Remove bools.
5142         (tee_file::~tee_file): Remove deletes.
5143         * ui-file.h (tee_file): Remove bools.
5144
5145 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5146
5147         * mi/mi-cmds.h (mi_cmd_complete): New function.
5148         * mi/mi-main.c (mi_cmd_complete): Likewise.
5149         * mi/mi-cmds.c: Define new MI command -complete.
5150         * NEWS: Mention new -complete command.
5151
5152 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5153
5154         * completer.h (complete): New function.
5155         * completer.c (complete): Likewise.
5156         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5157         function defined in completer.h.
5158
5159 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5160
5161         * MAINTAINERS (Write After Approval): Add myself.
5162
5163 2019-05-17  Tom de Vries  <tdevries@suse.de>
5164
5165         PR gdb/24094
5166         * dwarf2read.c (struct cu_partial_die_info): New struct.
5167         (find_partial_die): Return cu_partial_die_info.
5168         (partial_die_parent_scope, guess_partial_die_structure_name)
5169         (partial_die_info::fixup): Handle new return type of find_partial_die.
5170
5171 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5172
5173         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5174         "std::string", simplifying the algorithm.
5175
5176 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5177
5178         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5179         (stap_static_probe_ops::get_probes): Likewise.
5180
5181 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5182
5183         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5184         '-')" and "else if".
5185         (stap_parse_single_operand): Join checks for
5186         "gdbarch_stap_parse_special_token_p" and
5187         "gdbarch_stap_parse_special_token" in the same "if" statement.
5188         Invert check when verifying for operation on register
5189         displacement.
5190
5191 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5192
5193         * stap-probe.c (stap_get_opcode): Update comment.
5194         (stap_get_expected_argument_type): Likewise.
5195         (handle_stap_probe): Likewise.
5196
5197 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5198
5199         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5200         return type to 'bool'.  Adjust comment.  Use 'bool' when
5201         appropriate.
5202         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5203         * stap-probe.c (stap_parse_argument_1): Likewise.
5204         (stap_is_operator): Likewise.
5205         (stap_is_generic_prefix): Likewise.
5206         (stap_is_register_prefix): Likewise.
5207         (stap_is_register_indirection_prefix): Likewise.
5208         (stap_is_integer_prefix): Likewise.
5209         (stap_generic_check_suffix): Likewise.
5210         (stap_check_integer_suffix): Likewise.
5211         (stap_check_register_suffix): Likewise.
5212         (stap_check_register_indirection_suffix): Likewise.
5213         (stap_parse_register_operand): Likewise.
5214         (stap_parse_single_operand): Likewise.
5215         (stap_parse_argument_1): Likewise.
5216         (stap_probe::get_argument_count): Likewise.
5217         (stap_is_operator): Likewise.
5218
5219 2019-05-16  Tom Tromey  <tromey@adacore.com>
5220
5221         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5222         keyword to foreach.
5223
5224 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5225
5226         * linux-thread-db.c (try_thread_db_load_1): Change return type
5227         to bool.
5228         (try_thread_db_load): Likewise.
5229         (try_thread_db_load_from_pdir_1): Likewise.
5230         (try_thread_db_load_from_pdir): Likewise.
5231         (try_thread_db_load_from_sdir): Likewise.
5232         (try_thread_db_load_from_dir): Likewise.
5233         (thread_db_load_search): Likewise.
5234         (has_libpthread): Likewise.
5235         (thread_db_load): Likewise.
5236
5237 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5238
5239         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5240         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5241         NULL, and complain/return if that's the case.
5242
5243 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5244
5245         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5246         (advance, posn, abstract_read_memory): New functions.
5247         [struct mem_read_abstraction]: New struct.
5248         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5249
5250 2019-05-14  Tom Tromey  <tromey@adacore.com>
5251
5252         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5253         value is not lval_memory.
5254
5255 2019-05-14  Tom Tromey  <tromey@adacore.com>
5256
5257         * solib.c (info_sharedlibrary_command): Style the file name.
5258
5259 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5260
5261         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5262         (aarch64_vnv_type): Likewise.
5263         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5264         * common/tdesc.c: Likewise.
5265         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5266         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5267         * features/aarch64-fpu.xml: Add ieee half view.
5268         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5269         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5270         * gdbtypes.h (struct builtin_type): Likewise.
5271         (struct objfile_type): Likewise.
5272
5273 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5274
5275         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5276         typo.
5277         * location.h (string_to_event_location): Likewise.
5278
5279 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5280
5281         GDB 8.3 released.
5282
5283 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5284
5285         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5286         New variable declaration.
5287         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5288         New variable.
5289         (print_one_breakpoint): Use ui_out::test_flags and new global
5290         variable to compute use_fixed_output.
5291         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5292         Remove.
5293         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5294         (mi_multi_location_breakpoint_output_fixed): Remove.
5295         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5296         new variable.
5297         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5298         fix_multi_location_breakpoint_output flag if version >= 3.
5299         * ui-out.h (enum ui_out_flag)
5300         <fix_multi_location_breakpoint_output>: New enumerator.
5301
5302 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5303
5304         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5305
5306 2019-05-10  Tom Tromey  <tromey@adacore.com>
5307
5308         * ada-lang.c (catch_ada_completer): New function.
5309         (_initialize_ada_language): Use it.
5310
5311 2019-05-10  Tom Tromey  <tromey@adacore.com>
5312
5313         * thread.c (print_thread_info): Make "requested_threads" const.
5314         * gdbthread.h (print_thread_info): Make "requested_threads"
5315         const.
5316         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5317         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5318
5319 2019-05-08  Tom Tromey  <tom@tromey.com>
5320
5321         * gdbtypes.c (objfile_type_data): Change type.
5322         (objfile_type, _initialize_gdbtypes): Update.
5323
5324 2019-05-08  Tom Tromey  <tom@tromey.com>
5325
5326         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5327         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5328         (_initialize_dwarf2_frame): Update.
5329
5330 2019-05-08  Tom Tromey  <tom@tromey.com>
5331
5332         * objc-lang.c (objc_objfile_data): Change type.
5333         (find_methods): Update.
5334         (_initialize_objc_lang): Remove.
5335
5336 2019-05-08  Tom Tromey  <tom@tromey.com>
5337
5338         * stabsread.c (rs6000_builtin_type_data): Change type.
5339         (rs6000_builtin_type, _initialize_stabsread): Update.
5340
5341 2019-05-08  Tom Tromey  <tom@tromey.com>
5342
5343         * mips-tdep.c (mips_pdr_data): Remove.
5344         (_initialize_mips_tdep): Update.
5345
5346 2019-05-08  Tom Tromey  <tom@tromey.com>
5347
5348         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5349         (hppa_init_objfile_priv_data, read_unwind_info)
5350         (find_unwind_entry, _initialize_hppa_tdep): Update.
5351
5352 2019-05-08  Tom Tromey  <tom@tromey.com>
5353
5354         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5355         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5356         on obstack.
5357         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5358
5359 2019-05-08  Tom Tromey  <tom@tromey.com>
5360
5361         * mdebugread.c (basic_type_data): Change type.
5362         (basic_type, _initialize_mdebugread): Update.
5363
5364 2019-05-08  Tom Tromey  <tom@tromey.com>
5365
5366         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5367
5368 2019-05-08  Tom Tromey  <tom@tromey.com>
5369
5370         * nto-tdep.c (nto_inferior_data_reg): Change type.
5371         (nto_inferior_data): Update.
5372         (nto_inferior_data_cleanup, nto_new_inferior_data)
5373         (_initialize_nto_tdep): Remove.
5374         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5375
5376 2019-05-08  Tom Tromey  <tom@tromey.com>
5377
5378         * ada-lang.c (struct ada_inferior_data): Add initializers.
5379         (ada_inferior_data): Change type.
5380         (ada_inferior_data_cleanup): Remove.
5381         (get_ada_inferior_data, ada_inferior_exit)
5382         (struct ada_pspace_data): Add initializers, destructor.
5383         (ada_pspace_data_handle): Change type.
5384         (get_ada_pspace_data): Update.
5385         (ada_pspace_data_cleanup): Remove.
5386
5387 2019-05-08  Tom Tromey  <tom@tromey.com>
5388
5389         * coffread.c (struct coff_symfile_info): Add initializers.
5390         (coff_objfile_data_key): Move lower.  Change type.
5391         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5392         Update.
5393         (coff_free_info): Remove.
5394
5395 2019-05-08  Tom Tromey  <tom@tromey.com>
5396
5397         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5398         (fbsd_pspace_data_handle): Move lower.  Change type.
5399         (get_fbsd_pspace_data): Update.
5400         (fbsd_pspace_data_cleanup): Remove.
5401         (_initialize_fbsd_tdep): Update.
5402
5403 2019-05-08  Tom Tromey  <tom@tromey.com>
5404
5405         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5406         (get_ada_tasks_pspace_data): Update.
5407         (ada_tasks_pspace_data_cleanup): Remove.
5408         (_initialize_tasks): Update.
5409         (ada_tasks_inferior_data_handle): Change type.
5410         (get_ada_tasks_inferior_data): Update.
5411         (ada_tasks_inferior_data_cleanup): Remove.
5412         (struct ada_tasks_pspace_data): Add initializers.
5413
5414 2019-05-08  Tom Tromey  <tom@tromey.com>
5415
5416         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5417         * symfile-debug.c (debug_sym_get_probes): Change type.
5418         * stap-probe.c (handle_stap_probe):
5419         (stap_static_probe_ops::get_probes): Change type.
5420         * probe.h (class static_probe_ops) <get_probes>: Change type.
5421         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5422         (parse_probes_in_pspace): Update.
5423         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5424         Update.
5425         (any_static_probe_ops::get_probes): Change type.
5426         * elfread.c (elfread_data): New typedef.
5427         (probe_key): Change type.
5428         (elf_get_probes): Likewise.  Update.
5429         (probe_key_free): Remove.
5430         (_initialize_elfread): Update.
5431         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5432         Change type.
5433         (dtrace_process_dof_probe, dtrace_process_dof)
5434         (dtrace_static_probe_ops::get_probe): Change type.
5435
5436 2019-05-08  Tom Tromey  <tom@tromey.com>
5437
5438         * xcoffread.c (struct xcoff_symfile_info): Rename from
5439         coff_symfile_info.  Add initializers.
5440         (xcoff_objfile_data_key): Move lower.  Change type.
5441         (XCOFF_DATA): Rewrite.
5442         (xcoff_free_info): Remove.
5443         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5444         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5445         (xcoff_initial_scan): Update.
5446
5447 2019-05-08  Tom Tromey  <tom@tromey.com>
5448
5449         * solib-svr4.c (struct svr4_info): Add initializers and
5450         destructor.
5451         <probes_table>: Now an htab_up.
5452         (solib_svr4_pspace_data): Change type.
5453         (free_probes_table): Simplify.
5454         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5455         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5456         (probes_table_remove_objfile_probes, register_solib_event_probe)
5457         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5458         (_initialize_svr4_solib): Update.
5459
5460 2019-05-08  Tom Tromey  <tom@tromey.com>
5461
5462         * remote.c (remote_pspace_data): Change type.
5463         (remote_pspace_data_cleanup): Remove.
5464         (get_remote_exec_file, set_pspace_remote_exec_file)
5465         (_initialize_remote): Update.
5466
5467 2019-05-08  Tom Tromey  <tom@tromey.com>
5468
5469         * breakpoint.c (breakpoint_objfile_key): Change type.
5470         (get_breakpoint_objfile_data): Update.
5471         (free_breakpoint_objfile_data): Remove.
5472         (_initialize_breakpoint): Update.
5473
5474 2019-05-08  Tom Tromey  <tom@tromey.com>
5475
5476         * linux-tdep.c (struct linux_info): Add initializers.
5477         (linux_inferior_data): Move.  Change type.
5478         (invalidate_linux_cache_inf): Update.
5479         (linux_inferior_data_cleanup): Remove.
5480         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5481
5482 2019-05-08  Tom Tromey  <tom@tromey.com>
5483
5484         * auxv.c (auxv_inferior_data): Move.  Change type.
5485         (auxv_inferior_data_cleanup): Remove.
5486         (invalidate_auxv_cache_inf): Rewrite.
5487         (get_auxv_inferior_data, _initialize_auxv): Update.
5488
5489 2019-05-08  Tom Tromey  <tom@tromey.com>
5490
5491         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5492         (symfile_debug_objfile_data_key): Change type.
5493         (symfile_debug_installed, debug_qf_has_symbols)
5494         (debug_qf_find_last_source_symtab)
5495         (debug_qf_forget_cached_source_info)
5496         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5497         (debug_qf_print_stats, debug_qf_dump)
5498         (debug_qf_expand_symtabs_for_function)
5499         (debug_qf_expand_all_symtabs)
5500         (debug_qf_expand_symtabs_with_fullname)
5501         (debug_qf_map_matching_symbols)
5502         (debug_qf_expand_symtabs_matching)
5503         (debug_qf_find_pc_sect_compunit_symtab)
5504         (debug_qf_map_symbol_filenames)
5505         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5506         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5507         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5508         (debug_sym_read_linetable, debug_sym_relocate): Update.
5509         (symfile_debug_free_objfile): Remove.
5510         (install_symfile_debug_logging, _initialize_symfile_debug):
5511         Update.
5512
5513 2019-05-08  Tom Tromey  <tom@tromey.com>
5514
5515         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5516         allocate_on_obstack.
5517         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5518         (get_dwarf2_per_objfile): Update.
5519         (set_dwarf2_per_objfile): Remove.
5520         (dwarf2_has_info, dwarf2_get_section_info): Update.
5521         (dwarf2_free_objfile): Remove.
5522         (_initialize_dwarf2_read): Update.
5523
5524 2019-05-08  Tom Tromey  <tom@tromey.com>
5525
5526         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5527         initializers.
5528         <unsupported_script_warning_printed,
5529         script_not_found_warning_printed>: Now bool.
5530         (auto_load_pspace_data): Change type.
5531         (~auto_load_pspace_info): Rename from
5532         auto_load_pspace_data_cleanup.
5533         (get_auto_load_pspace_data, init_loaded_scripts_info)
5534         (clear_section_scripts, maybe_print_unsupported_script_warning)
5535         (maybe_print_script_not_found_warning, _initialize_auto_load):
5536         Update.
5537
5538 2019-05-08  Tom Tromey  <tom@tromey.com>
5539
5540         * objfiles.c (objfile_pspace_info): Add destructor and
5541         initializers.
5542         (objfiles_pspace_data): Change type.
5543         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5544         (get_objfile_pspace_data): Update.
5545         (objfiles_bfd_data): Change type.
5546         (get_objfile_bfd_data): Update.
5547         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5548
5549 2019-05-08  Tom Tromey  <tom@tromey.com>
5550
5551         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5552         Change type.
5553         (get_catch_syscall_inferior_data): Update.
5554         (catch_syscall_inferior_data_cleanup): Remove.
5555         (_initialize_break_catch_syscall): Update.
5556
5557 2019-05-08  Tom Tromey  <tom@tromey.com>
5558
5559         * inflow.c (struct terminal_info): Add destructor and
5560         initializers.
5561         (inflow_inferior_data): Change type.
5562         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5563         (get_inflow_inferior_data, inflow_inferior_exit)
5564         (swap_terminal_info, _initialize_inflow): Update.
5565
5566 2019-05-08  Tom Tromey  <tom@tromey.com>
5567
5568         * target-dcache.c (target_dcache_cleanup): Remove.
5569         (target_dcache_aspace_key): Change type.
5570         (target_dcache_init_p, target_dcache_invalidate)
5571         (target_dcache_get, target_dcache_get_or_init)
5572         (_initialize_target_dcache): Update.
5573         * dcache.h (struct dcache_deleter): New.
5574
5575 2019-05-08  Tom Tromey  <tom@tromey.com>
5576
5577         * symtab.c (struct symbol_cache): Add destructor and
5578         initializers.
5579         (symbol_cache_key): Move.  Change type.
5580         (make_symbol_cache, free_symbol_cache): Remove.
5581         (get_symbol_cache): Update.
5582         (symbol_cache_cleanup): Remove.
5583         (ALL_PSPACES, symbol_cache_flush)
5584         (maintenance_print_symbol_cache)
5585         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5586         Update.
5587
5588 2019-05-08  Tom Tromey  <tom@tromey.com>
5589
5590         * symtab.c (struct main_info): Add destructor and initializers.
5591         (main_progspace_key): Move.  Change type.
5592         (get_main_info): Update.
5593         (main_info_cleanup): Remove.
5594         (_initialize_symtab): Update.
5595
5596 2019-05-08  Tom Tromey  <tom@tromey.com>
5597
5598         * registry.h (DECLARE_REGISTRY): Define the _key class.
5599
5600 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5601
5602         * NEWS: Merge two 'New commands' sections.
5603
5604 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5605
5606         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5607         parameter and use Ada language definition instead.
5608         (ada_val_print_ptr): Remove unused language parameter.
5609         (ada_val_print_num): Remove language parameter and use Ada language
5610         definition instead.
5611         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5612         parameter.
5613         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5614         parameter and use Ada language definition instead.
5615         (ada_val_print_1): Update all ada_val_print_xxx calls.
5616         Remove language parameter.
5617         (ada_val_print): Update ada_val_print_1 call.
5618
5619 2019-05-08  Tom Tromey  <tromey@adacore.com>
5620
5621         * remote.c (remote_hw_watchpoint_limit)
5622         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5623         Now static.
5624
5625 2019-05-08  Tom Tromey  <tromey@adacore.com>
5626
5627         * maint.c (_initialize_maint_cmds): Move initialization code to
5628         remote.c.
5629         (watchdog, show_watchdog): Move to remote.c.
5630         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5631         "watchdog" static.
5632         (_initialize_remote): Move initialization code from maint.c.
5633         * defs.h (watchdog): Don't declare.
5634
5635 2019-05-08  Tom Tromey  <tromey@adacore.com>
5636
5637         * tui/tui-interp.c: Include main.h.
5638         * interps.c: Include main.h.
5639         * main.h (interpreter_p): Declare.
5640         * defs.h (interpreter_p): Don't declare.
5641
5642 2019-05-08  Tom Tromey  <tromey@adacore.com>
5643
5644         * dwarf2loc.c: Include dwarf2read.h.
5645         * defs.h (read_unsigned_leb128): Don't declare.
5646         * dwarf2read.h (read_unsigned_leb128): Declare.
5647
5648 2019-05-08  Tom Tromey  <tromey@adacore.com>
5649
5650         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5651         method.
5652
5653 2019-05-08  Tom Tromey  <tromey@adacore.com>
5654
5655         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5656         when no wrap column is set.
5657
5658 2019-05-08  Tom Tromey  <tromey@adacore.com>
5659
5660         * c-lang.c (c_get_string): Handle non-C-style arrays.
5661
5662 2019-05-08  Tom Tromey  <tromey@adacore.com>
5663
5664         * typeprint.c (print_offset_data::update): Print the bit offset,
5665         not the number of bits remaining.
5666
5667 2019-05-08  Tom Tromey  <tromey@adacore.com>
5668
5669         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5670         padding at end of comment.
5671
5672 2019-05-08  Tom Tromey  <tromey@adacore.com>
5673
5674         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5675         Compare main types.
5676
5677 2019-05-06  Tom Tromey  <tom@tromey.com>
5678
5679         * common/scoped_mmap.c: Include common-defs.h.
5680         * common/scoped_mmap.h: Don't include config.h.
5681
5682 2019-05-04  Tom Tromey  <tom@tromey.com>
5683
5684         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5685         (struct aarch64_call_info): Add initializers.
5686         <si>: Now a std::vector.
5687         (pass_on_stack, aarch64_push_dummy_call): Update.
5688
5689 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5690             Tom Tromey  <tom@tromey.com>
5691
5692         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5693         (ppc_threads): Now a std::vector.  Now static.
5694         (hwdebug_find_thread_points_by_tid)
5695         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5696         Update.
5697
5698 2019-05-04  Tom Tromey  <tom@tromey.com>
5699
5700         * arc-tdep.c (arc_tdesc_init): Return bool.
5701
5702 2019-05-04  Tom Tromey  <tom@tromey.com>
5703
5704         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5705         Use gdb_assert_not_reached.
5706
5707 2019-05-04  Tom Tromey  <tom@tromey.com>
5708
5709         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5710         "false".
5711
5712 2019-05-04  Tom Tromey  <tom@tromey.com>
5713
5714         * arc-tdep.c (arc_tdesc_init): Use bool.
5715
5716 2019-05-04  Tom Tromey  <tom@tromey.com>
5717
5718         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5719
5720 2019-05-04  Tom Tromey  <tom@tromey.com>
5721
5722         * cli/cli-cmds.c (valid_command_p): Return bool.
5723
5724 2019-05-04  Tom Tromey  <tom@tromey.com>
5725
5726         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5727         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5728
5729 2019-05-04  Raul Tambre  <raul@tambre.ee>
5730
5731         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5732         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5733         operator for comparison.
5734
5735 2019-05-04  Tom Tromey  <tom@tromey.com>
5736
5737         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5738         (lookup_partial_symbol, print_partial_symbols)
5739         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5740         (psymbol_compare): Update.
5741         (add_psymbol_to_bcache): Clear the entire psymbol.
5742         (maintenance_check_psymtabs): Update.
5743         * psympriv.h (struct partial_symbol): Don't derive from
5744         general_symbol_info.
5745         <obj_section, unrelocated_address, address,
5746         set_unrelocated_address>: Update.
5747         <ginfo>: New member.
5748         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5749         (debug_names::write_psymbols): Update.
5750
5751 2019-05-04  Tom de Vries  <tdevries@suse.de>
5752
5753         * contrib/cc-with-tweaks.sh: Support -n arg.
5754
5755 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5756
5757         * corelow.c (core_target::detach): Ensure frame cache and
5758         register caches are cleared.
5759         inferior.c (exit_inferior_1): Likewise.
5760
5761 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5762             Tom Tromey  <tom@tromey.com>
5763
5764         * dictionary.c (collate_pending_symbols_by_language): Remove
5765         "struct" from foreach.
5766         * symtab.c (lookup_global_symbol_from_objfile)
5767         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5768         foreach.
5769         * ser-tcp.c (net_open): Remove "struct" from foreach.
5770         * objfiles.c (objfile_relocate, objfile_rebase)
5771         (objfile_has_symbols): Remove "struct" from foreach.
5772         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5773         from foreach.
5774         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5775         foreach.
5776         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5777         "struct" from foreach.
5778         * ada-lang.c (create_excep_cond_exprs)
5779         (ada_exception_catchpoint_cond_string): Remove "struct" from
5780         foreach.
5781
5782 2019-05-03  Tom Tromey  <tromey@adacore.com>
5783
5784         * ada-exp.y (convert_char_literal): Check suffix of each
5785         enumerator.
5786
5787 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5788
5789         PR ada/21406:
5790         * ada-exp.y (yywrap): Don't define.
5791         * ada-lex.l (%option): Add noyywrap
5792         (yywrap): Remove.
5793
5794 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5795
5796         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5797         _WIN32_WINNT to the XP level, unless already defined to a higher
5798         level.
5799
5800         * unittests/parse-connection-spec-selftests.c:
5801         * ser-tcp.c:
5802         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5803         override.
5804
5805         * symfile.c (find_separate_debug_file): Remove colon from the
5806         drive spec of DOS/Windows file names of the target, so that the
5807         file name produced from DEBUGDIR and the target's directory will
5808         be valid on DOS/Windows systems.
5809
5810 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5811
5812         * rust-lang.c (val_print_struct): Handle printing structures
5813         containing strings.
5814
5815 2019-05-02  Tom Tromey  <tromey@adacore.com>
5816
5817         * valarith.c (_initialize_valarith): Remove.
5818
5819 2019-05-01  Tom Tromey  <tromey@adacore.com>
5820
5821         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5822         bitfields.
5823
5824 2019-05-01  Tom Tromey  <tromey@adacore.com>
5825
5826         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5827         for big-endian copies.
5828
5829 2019-04-30  Ali Tamur  <tamur@google.com>
5830         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5831         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5832         (read_3_bytes): New function.
5833
5834 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5835
5836         * windows-nat.c (main_thread_id): Delete.
5837         (handle_output_debug_string): Replace main_thread_id by
5838         current_event.dwThreadId.
5839         (fake_create_process): Likewise.
5840         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5841         Do not set main_thread_id.
5842         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5843         current_event.dwThreadId.
5844         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5845
5846 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5847
5848         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5849         Use current_event.dwThreadId instead of main_thread_id.
5850
5851 2019-04-30  Tom Tromey  <tromey@adacore.com>
5852
5853         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5854         (create_excep_cond_exprs): Iterate over program spaces.
5855         (ada_exception_catchpoint_cond_string): Examine all minimal
5856         symbols for exception types.
5857
5858 2019-04-30  Tom Tromey  <tromey@adacore.com>
5859
5860         PR c++/24470:
5861         * dwarf2read.c (process_structure_scope): Handle case where type
5862         has template parameters but no symbol was created.
5863
5864 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5865             Chris January  <chris.january@arm.com>
5866
5867         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5868         qualifier.
5869         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5870
5871 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5872
5873         * f-typeprint.c (f_print_type): Update rules for printing
5874         whitespace.
5875         (f_type_print_varspec_suffix): Likewise.
5876
5877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5878             Chris January  <chris.january@arm.com>
5879
5880         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5881         function arguments.
5882
5883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * f-lang.c (build_fortran_types): Change name of void type to
5886         lower case.
5887         * f-typeprint.c (f_type_print_base): Print the name of the void
5888         type, rather than a fixed string.
5889         * f-valprint.c (f_decorations): Use lower case void string.
5890
5891 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5892             Chris January  <chris.january@arm.com>
5893
5894         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5895         types for Fortran.
5896
5897 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5898             Chris January  <chris.january@arm.com>
5899             David Lecomber  <david.lecomber@arm.com>
5900
5901         * f-exp.y (BINOP_INTRINSIC): New token.
5902         (exp): New parser rule handling BINOP_INTRINSIC.
5903         (f77_keywords): Add new builtin procedures.
5904         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5905         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5906         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5907         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5908         (print_unop_subexp_f): New function.
5909         (print_binop_subexp_f): New function.
5910         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5911         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5912         (dump_subexp_body_f): Likewise.
5913         (operator_check_f): Likewise.
5914         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5915         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5916
5917 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5918
5919         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5920         UNOP_KIND.
5921         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5922         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5923         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5924         (operator_length_f): New fuction.
5925         (print_subexp_f): New function.
5926         (op_name_f): New function.
5927         (dump_subexp_body_f): New function.
5928         (operator_check_f): New function.
5929         (exp_descriptor_f): Replace standard expression handling functions
5930         with new functions.
5931         * gdb/fortran-operator.def: New file.
5932         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5933         * gdb/std-operator.def: Remove UNOP_KIND.
5934
5935 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5936
5937         * std-operator.def: Remove unbalanced, stray double quote
5938         character.
5939
5940 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5941             Chris January  <chris.january@arm.com>
5942             Daniel Everett  <daniel.everett@arm.com>
5943             Nick Forrington  <nick.forrington@arm.com>
5944             Richard Bunt  <richard.bunt@arm.com>
5945
5946         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5947         of depth when printing anonymous structs or unions.
5948         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5949         Don't print either the top-level value, or the children if the
5950         max-depth is exceeded.
5951         (ppscm_print_children): When printing the key of a map, allow one
5952         extra level of depth.
5953         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5954         print either the top-level value, or the children if the max-depth
5955         is exceeded.
5956         (print_children): When printing the key of a map, allow one extra
5957         level of depth.
5958         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5959         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5960         (user_print_options): Initialise max_depth field.
5961         (val_print_scalar_or_string_type_p): New function.
5962         (val_print): Check to see if the max depth has been reached.
5963         (val_print_check_max_depth): Define new function.
5964         (show_print_max_depth): New function.
5965         (_initialize_valprint): Add 'print max-depth' option.
5966         * valprint.h (struct value_print_options) <max_depth>: New field.
5967         (val_print_check_max_depth): Declare new function.
5968         * NEWS: Document new feature.
5969
5970 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5971
5972         * ada-lang.c (ada_language_defn): Initialise new field.
5973         * c-lang.c (c_is_string_type_p): New function.
5974         (c_language_defn): Initialise new field.
5975         (cplus_language_defn): Initialise new field.
5976         (asm_language_defn): Initialise new field.
5977         (minimal_language_defn): Initialise new field.
5978         * c-lang.h (c_is_string_type_p): Declare new function.
5979         * d-lang.c (d_language_defn): Initialise new field.
5980         * f-lang.c (f_is_string_type_p): New function.
5981         (f_language_defn): Initialise new field.
5982         * go-lang.c (go_is_string_type_p): New function.
5983         (go_language_defn): Initialise new field.
5984         * language.c (default_is_string_type_p): New function.
5985         (unknown_language_defn): Initialise new field.
5986         (auto_language_defn): Initialise new field.
5987         * language.h (struct language_defn) <la_is_string_type_p>: New
5988         member variable.
5989         (default_is_string_type_p): Declare new function.
5990         * m2-lang.c (m2_language_defn): Initialise new field.
5991         * objc-lang.c (objc_language_defn): Initialise new field.
5992         * opencl-lang.c (opencl_language_defn): Initialise new field.
5993         * p-lang.c (pascal_is_string_type_p): New function.
5994         (pascal_language_defn): Initialise new field.
5995         * rust-lang.c (rust_is_string_type_p): New function.
5996         (rust_language_defn): Initialise new field.
5997
5998 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5999
6000         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6001         New field.
6002         * ada-lang.c (ada_language_defn): Initialise new field.
6003         * c-lang.c (c_language_defn): Likewise.
6004         (cplus_language_defn): Likewise.
6005         (asm_language_defn): Likewise.
6006         (minimal_language_defn): Likewise.
6007         * d-lang.c (d_language_defn): Likewise.
6008         * f-lang.c (f_language_defn): Likewise.
6009         * go-lang.c (go_language_defn): Likewise.
6010         * language.c (unknown_language_defn): Likewise.
6011         (auto_language_defn): Likewise.
6012         * m2-lang.c (m2_language_defn): Likewise.
6013         * objc-lang.c (objc_language_defn): Likewise.
6014         * opencl-lang.c (opencl_language_defn): Likewise.
6015         * p-lang.c (pascal_language_defn): Likewise.
6016         * rust-lang.c (rust_language_defn): Likewise.
6017
6018 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6019
6020         * ada-lang.c (ada_is_character_type): Change return type to bool.
6021         (ada_is_string_type): Likewise.
6022         * ada-lang.h (ada_is_character_type): Update declaration
6023         (ada_is_string_type): Likewise.
6024
6025 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6026
6027         Support style in 'frame|thread apply'
6028
6029         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6030         * record.c (record_start, record_stop): Update callers of
6031         execute_command_to_string with false.
6032         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6033         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6034         methods.
6035         (class string_file): New constructor with term_out parameter.
6036         Override methods term_out and can_emit_style_escape.  New member
6037         term_out.
6038         (class stdio_file): Override can_emit_style_escape.
6039         (class tee_file): Override term_out and can_emit_style_escape.
6040         * utils.h (can_emit_style_escape): Remove.
6041         * utils.c (can_emit_style_escape): Likewise.
6042         Update all callers of can_emit_style_escape (SOMESTREAM) to
6043         SOMESTREAM->can_emit_style_escape.
6044         * source-cache.c (source_cache::get_source_lines): Likewise.
6045         * stack.c (frame_apply_command_count): Call execute_command_to_string
6046         passing the term_out characteristic of the current gdb_stdout.
6047         * thread.c (thr_try_catch_cmd): Likewise.
6048         * top.c (execute_command_to_string): pass term_out parameter
6049         to construct the string_file for the command output.
6050         * ui-file.c (term_cli_styling): New function (most code moved
6051         from utils.c can_emit_style_escape).
6052         (string_file::string_file, string_file::can_emit_style_escape,
6053         stdio_file::can_emit_style_escape, tee_file::term_out,
6054         tee_file::can_emit_style_escape): New functions.
6055
6056 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6057
6058         * NEWS: Mention the new set|show may-call-functions.
6059         * infcall.c (may_call_functions_p): New variable.
6060         (show_may_call_functions_p): New function.
6061         (call_function_by_hand_dummy): Throws an error if not
6062         may-call-functions.
6063         (_initialize_infcall): Call add_setshow_boolean_cmd for
6064         may-call-functions.
6065
6066 2019-04-25  Keith Seitz  <keiths@redhat.com>
6067
6068         PR c++/24367
6069         * cp-support.c (inspect_type): Don't attempt substitutions
6070         of symbol with the same name.
6071
6072 2019-04-25  Tom Tromey  <tromey@adacore.com>
6073
6074         PR gdb/24475:
6075         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6076         static.
6077
6078 2019-04-25  Tom Tromey  <tromey@adacore.com>
6079
6080         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6081         rvalue reference.
6082         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6083         (gdb_xml_parser::parse): Use std::move.
6084         * python/python-internal.h (gdbpy_convert_exception): Take a const
6085         reference.
6086         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6087         std::move.
6088         * python/py-utils.c (gdbpy_convert_exception): Take a const
6089         reference.
6090         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6091         Use std::move.
6092         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6093         Use std::move.
6094         * mi/mi-main.c (mi_print_exception): Take a const reference.
6095         * main.c (handle_command_errors): Take a const reference.
6096         * linespec.c (parse_linespec): Use std::move.
6097         * infcall.c (run_inferior_call): Use std::move.
6098         (call_function_by_hand_dummy): Use std::move.
6099         * exec.c (try_open_exec_file): Use std::move.
6100         * exceptions.h (exception_print, exception_fprintf)
6101         (exception_print_same): Update.
6102         * exceptions.c (print_exception, exception_print)
6103         (exception_fprintf, exception_print_same): Change parameters to
6104         const reference.
6105         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6106         * common/new-op.c: Use std::move.
6107         * common/common-exceptions.h (struct gdb_exception): Add move
6108         constructor.
6109         (struct gdb_exception_error, struct gdb_exception_quit, struct
6110         gdb_quit_bad_alloc): Change constructor to move constructor.
6111         (throw_exception): Change parameter to rvalue reference.
6112         * common/common-exceptions.c (throw_exception): Take rvalue
6113         reference.
6114         * cli/cli-interp.c (safe_execute_command): Use std::move.
6115         * breakpoint.c (insert_bp_location, location_to_sals): Use
6116         std::move.
6117
6118 2019-04-25  Tom Tromey  <tromey@adacore.com>
6119
6120         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6121         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6122         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6123         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6124         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6125         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6126         guile/scm-value.c: Use unpack.
6127         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6128         gdbscm_gdb_exception.
6129         (gdbscm_throw_gdb_exception): Likewise.
6130         (struct gdbscm_gdb_exception): New.
6131         (unpack): New function.
6132         (gdbscm_wrap): Use unpack.
6133
6134 2019-04-25  Tom Tromey  <tromey@adacore.com>
6135
6136         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6137         (gdb_rl_callback_handler): Use std::move.
6138         * common/common-exceptions.h (struct gdb_exception): Add move
6139         assignment operator.
6140         (throw_exception_sjlj): Change "exception" to const reference.
6141         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6142         (throw_exception_sjlj): Change "exception" to const reference.
6143
6144 2019-04-25  Tom Tromey  <tromey@adacore.com>
6145
6146         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6147         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6148         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6149         Update.
6150         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6151         Update.
6152         * mi/mi-interp.c (mi_interp::exec): Update.
6153         * linespec.c (parse_linespec): Update.
6154         * infcall.c (run_inferior_call): Update.
6155         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6156         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6157         (gdbscm_lookup_global_symbol): Update.
6158         * guile/scm-param.c (gdbscm_parameter_value): Update.
6159         * guile/scm-frame.c (gdbscm_frame_read_register)
6160         (gdbscm_frame_read_var): Update.
6161         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6162         * exec.c (try_open_exec_file): Update.
6163         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6164         (gdb_rl_callback_handler): Update.
6165         * common/common-exceptions.h (exception_none): Don't declare.
6166         * common/common-exceptions.c (exception_none): Don't define.
6167         (struct catcher) <exception>: Update.
6168         * cli/cli-interp.c (safe_execute_command): Update.
6169         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6170
6171 2019-04-25  Ali Tamur  <tamur@google.com>
6172
6173         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6174         (read_attribute_value): Likewise.
6175         (dwarf2_read_addr_index): Update comment.
6176         (read_str_index): Add DW_FORM_strx.
6177         (dwarf2_string_attr): Likewise.
6178         (dwarf2_const_value_attr): Likewise.
6179         (dump_die_shallow): Likewise.
6180         (dwarf2_fetch_constant_bytes): Likewise.
6181         (skip_form_bytes): Likewise.
6182         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6183
6184 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6185
6186         PR corefiles/11608
6187         PR corefiles/18187
6188         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6189         OFFSET.  Verify if current mapping contains an ELF header.
6190         (linux_find_memory_regions_full): Adjust call to
6191         dump_mapping_p.
6192
6193 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6194             Kang Li <kanglictf@gmail.com>
6195
6196         PR gdb/21600
6197
6198         * dwarf2-frame.c (read_initial_length): Be consistent about using
6199         unsigned representation of length.
6200         (decode_frame_entry_1): Likewise.  Check for wraparound of
6201         end pointer as well as buffer overflow.
6202
6203 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6204
6205         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6206         "vq".
6207
6208 2019-04-24  Tom Tromey  <tromey@adacore.com>
6209
6210         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6211
6212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * s12z-tdep.c (s12z_unwind_pc): Delete.
6215         (s12z_unwind_sp): Delete.
6216         (s12z_gdbarch_init): Don't register deleted functions with
6217         gdbarch.
6218
6219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * rl78-tdep.c (rl78_unwind_sp): Delete.
6222         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6223
6224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6227         (xstormy16_unwind_pc): Delete.
6228         (xstormy16_dummy_id): Delete.
6229         (xstormy16_gdbarch_init): Don't register deleted functions with
6230         gdbarch.
6231
6232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * vax-tdep.c (vax_unwind_pc): Delete.
6235         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6236
6237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6238
6239         * v850-tdep.c (v850_unwind_sp): Delete.
6240         (v850_unwind_pc): Delete.
6241         (v850_dummy_id): Delete.
6242         (v850_gdbarch_init): Don't register deleted functions with
6243         gdbarch.
6244
6245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6246
6247         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6248         (tilegx_unwind_pc): Delete.
6249         (tilegx_unwind_dummy_id): Delete.
6250         (tilegx_gdbarch_init): Don't register deleted functions with
6251         gdbarch.
6252
6253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6256         (tic6x_dummy_id): Delete.
6257         (tic6x_gdbarch_init): Don't register deleted functions with
6258         gdbarch.
6259
6260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * sparc-tdep.c (sparc_unwind_pc): Delete.
6263         (sparc32_gdbarch_init): Don't register deleted function with
6264         gdbarch.
6265
6266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * sh-tdep.c (sh_unwind_sp): Delete.
6269         (sh_unwind_pc): Delete.
6270         (sh_dummy_id): Delete.
6271         (sh_gdbarch_init): Don't register deleted functions with
6272         gdbarch.
6273
6274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * score-tdep.c (score_unwind_sp): Delete.
6277         (score_unwind_pc): Delete.
6278         (score_dummy_id): Delete.
6279         (score_gdbarch_init): Don't register deleted functions with
6280         gdbarch.
6281
6282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * rx-tdep.c (rx_unwind_pc): Delete.
6285         (rx_unwind_sp): Delete.
6286         (rx_dummy_id): Delete.
6287         (rx_gdbarch_init): Don't register deleted functions with
6288         gdbarch.  Update comment.
6289
6290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6293         (rs6000_dummy_id): Delete.
6294         (rs6000_gdbarch_init): Don't register deleted functions with
6295         gdbarch.
6296
6297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * or1k-tdep.c (or1k_dummy_id): Delete.
6300         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6301
6302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * nios2-tdep.c (nios2_dummy_id): Delete.
6305         (nios2_unwind_sp): Delete.
6306         (nios2_gdbarch_init): Don't register deleted functions with
6307         gdbarch.
6308
6309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * nds32-tdep.c (nds32_dummy_id): Delete.
6312         (nds32_unwind_pc): Delete.
6313         (nds32_unwind_sp): Delete.
6314         (nds32_gdbarch_init): Don't register deleted functions with
6315         gdbarch.
6316
6317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * msp430-tdep.c (msp430_unwind_pc): Delete.
6320         (msp430_unwind_sp): Delete.
6321         (msp430_dummy_id): Delete.
6322         (msp430_gdbarch_init): Don't register deleted functions with
6323         gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * moxie-tdep.c (moxie_unwind_sp): Delete.
6328         (moxie_unwind_pc): Delete.
6329         (moxie_dummy_id): Delete.
6330         (moxie_gdbarch_init): Don't register deleted functions with
6331         gdbarch.
6332
6333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6336         (mn10300_unwind_pc): Delete.
6337         (mn10300_unwind_sp): Delete.
6338         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6339         mn10300_unwind_sp.
6340         (mn10300_frame_unwind_init): Don't register deleted functions with
6341         gdbarch.
6342
6343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6344
6345         * mep-tdep.c (mep_unwind_pc): Delete.
6346         (mep_unwind_sp): Delete.
6347         (mep_dummy_id): Delete.
6348         (mep_gdbarch_init): Don't register deleted functions with
6349         gdbarch.
6350
6351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6352
6353         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6354         (m68hc11_unwind_sp): Delete.
6355         (m68hc11_gdbarch_init): Don't register deleted functions with
6356         gdbarch.
6357
6358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * m32r-tdep.c (m32r_unwind_sp): Delete.
6361         (m32r_unwind_pc): Delete.
6362         (m32r_dummy_id): Delete.
6363         (m32r_gdbarch_init): Don't register deleted functions with
6364         gdbarch.
6365
6366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * m32c-tdep.c (m32c_unwind_pc): Delete.
6369         (m32c_unwind_sp): Delete.
6370         (m32c_dummy_id): Delete.
6371         (m32c_gdbarch_init): Don't register deleted functions with
6372         gdbarch.
6373
6374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6377         (lm32_unwind_pc): Delete.
6378         (lm32_dummy_id): Delete.
6379         (lm32_gdbarch_init): Don't register deleted functions with
6380         gdbarch.
6381
6382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6383
6384         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6385         (iq2000_unwind_pc): Delete.
6386         (iq2000_dummy_id): Delete.
6387         (iq2000_gdbarch_init): Don't register deleted functions with
6388         gdbarch.
6389
6390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6391
6392         * nds32-tdep.c (nds32_type_align): Delete.
6393         (nds32_push_dummy_call): Use type_align instead.
6394
6395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * arm-tdep.c (arm_type_align): Only handle vector override case.
6398         (arm_push_dummy_call): Use type_align.
6399         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6400
6401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6404         case.
6405         (pass_on_stack): Use type_align.
6406         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6407         function.
6408
6409 2019-04-23  Tom Tromey  <tromey@adacore.com>
6410
6411         * dwarf2read.c (line_header::file_name_at): Remove unused
6412         overload.
6413
6414 2019-04-23  Tom de Vries  <tdevries@suse.de>
6415
6416         PR gdb/24438
6417         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6418         invocation.
6419
6420
6421 2019-03-27  Ali Tamur  <tamur@google.com>
6422
6423         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6424         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6425         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6426         (dwarf_expr_context::get_addr_index): Likewise
6427         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6428         (symbol_needs_eval_context::get_addr_index): Likewise
6429         (disassemble_dwarf_expression): Add DW_OP_addrx
6430         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6431         (read_cutu_die_from_dwo): Update comment
6432         (skip_one_die): Add DW_FORM_addrx
6433         (read_attribute_value): Likewise
6434         (var_decode_location): Add DW_OP_addrx
6435         (dwarf2_const_value_attr): Add DW_FORM_addrx
6436         (dump_die_shallow): Likewise
6437         (dwarf2_fetch_constant_bytes): Likewise
6438         (decode_locdesc): Add DW_OP_addrx
6439         (skip_form_bytes): Add DW_FORM_addrx
6440
6441 2019-04-22  Ali Tamur  <tamur@google.com>
6442
6443         * MAINTAINERS (Write After Approval): Add self.
6444
6445 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6446
6447         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6448         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6449         (open_symbol_file_object): Likewise.
6450         (svr4_default_sos): Add info parameter.
6451         (svr4_read_so_list): Likewise.
6452         (svr4_current_sos_direct): Adjust functions calls to pass down
6453         info.
6454         (svr4_current_sos_1): Add info parameter.
6455         (svr4_current_sos): Call get_svr4_info, pass info down to
6456         svr4_current_sos_1.
6457         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6458         get_svr4_info.
6459         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6460         get_svr4_info.
6461         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6462         to get_svr4_info.
6463         (probes_table_remove_objfile_probes): Likewise.
6464         (register_solib_event_probe): Add info parameter.
6465         (solist_update_incremental): Pass info parameter down to
6466         svr4_read_so_list.
6467         (disable_probes_interface): Add info parameter.
6468         (svr4_handle_solib_event): Pass current_program_space to
6469         get_svr4_info.  Adjust disable_probes_interface cleanup.
6470         (svr4_create_probe_breakpoints): Add info parameter, pass it
6471         down to register_solib_event_probe.
6472         (svr4_create_solib_event_breakpoints): Add info parameter,
6473         pass it down to svr4_create_probe_breakpoints.
6474         (enable_break): Pass info down to
6475         svr4_create_solib_event_breakpoints.
6476         (svr4_solib_create_inferior_hook): Pass current_program_space to
6477         get_svr4_info.
6478         (svr4_clear_solib): Likewise.
6479
6480 2019-04-22  Pedro Alves  <palves@redhat.com>
6481
6482         * solib-svr4.c (svr4_free_objfile_observer): New.
6483         (probe_and_action::objfile): New field.
6484         (probes_table_htab_remove_objfile_probes)
6485         (probes_table_remove_objfile_probes): New functions.
6486         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6487         in the new probe_and_action.  Don't store the probe in 'lookup'.
6488         (svr4_create_probe_breakpoints): Pass objfile to
6489         register_solib_event_probe.
6490         (_initialize_svr4_solib): Register a free_objfile observer.
6491
6492 2019-04-19  Tom Tromey  <tom@tromey.com>
6493
6494         * common/queue.h: Remove.
6495
6496 2019-04-19  Tom Tromey  <tom@tromey.com>
6497
6498         * event-loop.c: Don't include "common/queue.h".
6499
6500 2019-04-19  Tom Tromey  <tom@tromey.com>
6501
6502         * remote.c (remote_target): Use delete.
6503         * remote-notif.h: Include <list>, not "common/queue.h".
6504         (notif_client_p): Remove typedef.
6505         (remote_notif_state): Add constructor, destructor, initializer.
6506         <notif_queue>: Now a std::list.
6507         (remote_notif_state_xfree): Don't declare.
6508         * remote-notif.c (remote_notif_process, handle_notification)
6509         (remote_notif_state_allocate): Update.
6510         (~remote_notif_state): Rename from remote_notif_state_xfree.
6511
6512 2019-04-19  Tom Tromey  <tom@tromey.com>
6513
6514         * symfile.c (reread_symbols): Update.
6515         * objfiles.c (objfile_register_static_link)
6516         (objfile_lookup_static_link): Update
6517         (~objfile) Don't delete static_links.
6518         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6519
6520 2019-04-19  Tom Tromey  <tom@tromey.com>
6521
6522         * type-stack.h (struct type_stack) <insert>: Constify string.
6523         * type-stack.c (type_stack::insert): Constify string.
6524         * gdbtypes.h (lookup_template_type): Update.
6525         (address_space_name_to_int): Update.
6526         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6527         const.
6528         (lookup_template_type): Make name const.
6529         * c-exp.y: Update rules.
6530         (lex_one_token, classify_name, classify_inner_name)
6531         (c_print_token): Update.
6532         * p-exp.y: Update rules.
6533         (yylex): Update.
6534         * f-exp.y: Update rules.
6535         (yylex): Update.
6536         * d-exp.y: Update rules.
6537         (lex_one_token, classify_name, classify_inner_name): Update.
6538         * parse.c (write_dollar_variable, copy_name): Return std::string.
6539         * parser-defs.h (copy_name): Change return type.
6540         * m2-exp.y: Update rules.
6541         (yylex): Update.
6542         * go-exp.y (lex_one_token): Update.
6543         Update rules.
6544         (classify_unsafe_function, classify_packaged_name)
6545         (classify_name, yylex): Update.
6546
6547 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6548
6549         * configure.ac: add --enable-source-highlight switch.
6550         * configure: Regenerate.
6551         * top.c (print_gdb_version): plumb --enable-source-highlight
6552         status to "show configuration".
6553
6554 2019-04-19  Tom Tromey  <tromey@adacore.com>
6555
6556         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6557         Check ADA_TYPE_P.
6558         (empty_record, ada_template_to_fixed_record_type_1)
6559         (template_to_static_fixed_type)
6560         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6561         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6562         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6563         macros.
6564
6565 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6566
6567         PR symtab/24423:
6568         * source.c (print_source_lines_base): Advance "iter" when a
6569         control character is seen.
6570
6571 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6572
6573         * inferior.h (struct infcall_suspend_state_deleter):
6574         Catch exception in destructor to avoid crash.
6575
6576 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6577
6578         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6579         close to the add_com "shell".
6580
6581 2019-04-18  Tom Tromey  <tromey@adacore.com>
6582
6583         * process-stratum-target.h (class process_stratum_target)
6584         <stratum>: Add "final".
6585
6586 2019-04-17  Tom Tromey  <tromey@adacore.com>
6587
6588         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6589         against nullptr before use.
6590
6591 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6592
6593         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6594
6595 2019-04-17  Jim Wilson  <jimw@sifive.com>
6596             Andrew Burgess  <andrew.burgess@embecosm.com>
6597
6598         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6599         code read might fail, assume 4-byte breakpoint in that case.
6600
6601 2019-04-15  Leszek Swirski  <leszeks@google.com>
6602
6603         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6604         rather than a hand-rolled POD check when checking for forced MEMORY
6605         classification.
6606
6607 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6608
6609         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6610         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6611         function.
6612         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6613         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6614         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6615         declaration.
6616
6617 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6618
6619         * aarch64-linux-nat.c
6620         (aarch64_linux_nat_target::thread_architecture): Add override.
6621         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6622         each VQ.
6623
6624 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6625
6626         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6627
6628 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6629
6630         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6631         target types of size 96-bits, add some additional comments, and
6632         check that the builtin type we found was the correct size.
6633
6634 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6635
6636         * utils.c (prompt_for_continue): Don't restore the styling at the
6637         end, as applied_style has the wrong value.  This fixes styling in
6638         long lists of file names that are interrupted by the "Continue?"
6639         prompt.
6640
6641 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6642
6643         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6644         * c-lang.c (c_language_defn): Likewise.
6645         (cplus_language_defn): Likewise.
6646         (asm_language_defn): Likewise.
6647         (minimal_language_defn): Likewise.
6648         * d-lang.c (d_language_defn): Likewise.
6649         * f-lang.c (f_language_defn): Likewise.
6650         * go-lang.c (go_language_defn): Likewise.
6651         * language.c (unknown_language_defn): Likewise.
6652         (auto_language_defn): Likewise.
6653         * language.h (struct language_defn): Remove la_magic field.
6654         (LANG_MAGIC): Delete.
6655         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6656         * objc-lang.c (objc_language_defn): Likewise.
6657         * opencl-lang.c (opencl_language_defn): Likewise.
6658         * p-lang.c (pascal_language_defn): Likewise.
6659         * rust-lang.c (rust_language_defn): Likewise.
6660
6661 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6662
6663         * riscv-tdep.c (riscv_type_align): New function.
6664         (riscv_type_alignment): Delete.
6665         (riscv_arg_location): Use 'type_align'.
6666         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6667
6668 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6669
6670         * gdbtypes.c (type_align): A struct with no non-static fields also
6671         has alignment of 1.
6672
6673 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6674
6675         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6676         component to 0.
6677         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6678         member.
6679         (riscv_struct_info::analyse): New implementation using new
6680         analyse_inner member function.
6681         (riscv_struct_info::field_offset): New member function.
6682         (riscv_struct_info::m_offsets): New member variable.
6683         (riscv_struct_info::analyse_inner): New private member function,
6684         takes the old implementation of riscv_struct_info::analyse but
6685         extended to track field offsets.
6686         (riscv_call_arg_struct): Update the struct folding special cases
6687         to handle cases where empty C++ structs, which are non-zero
6688         length, are found.
6689         (riscv_arg_location): Initialise the length of each location, a
6690         non-zero length now indicates the location is in use.
6691         (riscv_push_dummy_call): Allow for the first location having a
6692         non-zero offset when setting up arguments.
6693         (riscv_return_value): Likewise, but for return values.
6694
6695 2019-04-11  Tom Tromey  <tromey@adacore.com>
6696
6697         * utils.c (internal_vproblem): Make "msg" const.
6698
6699 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6700
6701         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6702         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6703         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6704         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6705
6706 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6707
6708         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6709         function.
6710         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6711         of amd64_collect_native_gregset.
6712         (amd64_linux_nat_target::store_registers): Likewise.
6713
6714 2019-04-10  Tom Tromey  <tom@tromey.com>
6715
6716         * symtab.c (lookup_global_symbol_from_objfile)
6717         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6718         * objfiles.h (class separate_debug_iterator): New.
6719         (class separate_debug_range): New.
6720         (struct objfile) <separate_debug_objfiles>: New method.
6721         (objfile_separate_debug_iterate): Don't declare.
6722         * objfiles.c (separate_debug_iterator::operator++): Rename from
6723         objfile_separate_debug_iterate.
6724         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6725         iterator.
6726         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6727         iterator.
6728
6729 2019-04-10  Tom Tromey  <tom@tromey.com>
6730
6731         * symfile.c (reread_symbols): Remove old comment.
6732         * objfiles.c (free_all_objfiles): Fix a typo.
6733
6734 2019-04-10  Tom Tromey  <tom@tromey.com>
6735
6736         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6737         * minsyms.c (lookup_minimal_symbol): Use foreach.
6738         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6739         (lookup_minimal_symbol_solib_trampoline): Likewise.
6740         * symfile.c (reread_symbols): Use foreach.
6741
6742 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6743             Tom Tromey  <tromey@adacore.com>
6744
6745         PR rust/24414:
6746         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6747         (rust_lex_int_test): Change "value" to be LONGEST.
6748         (rust_lex_tests): Add test for long integer literal.
6749
6750 2019-04-09  Tom Tromey  <tromey@adacore.com>
6751
6752         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6753         to bool.
6754         (extended_remote_target::attach): Update.
6755         (remote_target::remote_notice_new_inferior): Update.
6756         (remote_target::add_current_inferior_and_thread): Update.
6757         * inferior.c (exit_inferior_1): Use "false".
6758         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6759
6760 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6761
6762         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6763         the "start" command.
6764
6765 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6766
6767         * python/py-inferior.c (infpy_thread_from_thread_handle):
6768         Adjust comments to reflect renaming of thread_from_thread_handle
6769         to thread_from_handle.  Adjust keywords.  Fix type error message.
6770         (inferior_object_methods): Add thread_from_handle.  Retain
6771         thread_from_thread_handle, but mark it as deprecated.
6772
6773 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6774
6775         * gdbthread.h (find_thread_by_handle): Revise declaration.
6776         * thread.c (find_thread_by_handle): Likewise.  Adjust
6777         implementation too.
6778         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6779         support for buffer objects as handles.
6780
6781 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6782
6783         * python/py-infthread.c (thpy_thread_handle): New function.
6784         (thread_object_methods): Register thpy_thread_handle.
6785
6786 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6787
6788         * gdbthread.h (thread_to_thread_handle): Declare.
6789         * thread.c (gdbtypes.h): Include.
6790         (thread_to_thread_handle): New function.
6791
6792         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6793         (target_thread_info_to_thread_handle): Declare.
6794         * target.c (target_thread_info_to_thread_handle): New function.
6795         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6796         * target-delegates.c: Regenerate.
6797
6798         * linux-thread-db.c (class thread_db_target): Add method
6799         thread_info_to_thread_handle.
6800         (thread_db_target::thread_info_to_thread_handle): Define.
6801         * remote.c (class remote_target): Add new method
6802         thread_info_to_thread_handle.
6803         (remote_target::thread_info_to_thread_handle): Define.
6804
6805 2019-04-08  Pedro Alves  <palves@redhat.com>
6806
6807         * common/common-exceptions.c (throw_exception): Don't create
6808         named object to throw; throw directly.
6809         (throw_it): Likewise.  Don't initialize gdb_exception::message
6810         here, with new; pass FMT and AP to the ctor instead.
6811         * common/common-exceptions.h: Include <string>.
6812         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6813         const char *, va_list)): New ctor.  Use std::make_shared.
6814         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6815         errors)): Delete.
6816         (gdb_exception_error::gdb_exception_error(enum errors, const char
6817         *, va_list)): New.
6818         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6819         Add assertion.
6820         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6821         errors)): Delete.
6822         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6823         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6824         Add assertion.
6825
6826 2019-04-08  Tom Tromey  <tom@tromey.com>
6827
6828         * valops.c (value_rtti_indirect_type): Replace throw_exception
6829         with throw.
6830         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6831         with throw.
6832         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6833         throw.
6834         * target.c (target_translate_tls_address): Replace throw_exception
6835         with throw.
6836         * stack.c (frame_apply_command_count): Replace throw_exception
6837         with throw.
6838         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6839         throw.
6840         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6841         with throw.
6842         * rs6000-tdep.c (rs6000_frame_cache)
6843         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6844         * remote.c: Replace throw_exception with throw.
6845         * record-full.c (record_full_message, record_full_wait_1)
6846         (record_full_restore): Replace throw_exception with throw.
6847         * record-btrace.c:
6848         (get_thread_current_frame_id, record_btrace_start_replaying)
6849         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6850         (cmd_record_btrace_start): Replace throw_exception with throw.
6851         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6852         throw.
6853         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6854         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6855         * linespec.c:
6856         (find_linespec_symbols): Replace throw_exception with throw.
6857         * infrun.c (displaced_step_prepare, resume): Replace
6858         throw_exception with throw.
6859         * infcmd.c (post_create_inferior): Replace throw_exception with
6860         throw.
6861         * inf-loop.c (inferior_event_handler): Replace throw_exception
6862         with throw.
6863         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6864         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6865         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6866         (get_prev_frame_always, get_frame_pc_if_available)
6867         (get_frame_address_in_block_if_available, get_frame_language):
6868         Replace throw_exception with throw.
6869         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6870         throw_exception with throw.
6871         * eval.c (fetch_subexp_value, evaluate_var_value)
6872         (evaluate_funcall, evaluate_subexp_standard): Replace
6873         throw_exception with throw.
6874         * dwarf2loc.c (call_site_find_chain)
6875         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6876         Replace throw_exception with throw.
6877         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6878         with throw.
6879         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6880         throw.
6881         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6882         * completer.c (complete_line_internal): Replace throw_exception
6883         with throw.
6884         * compile/compile-object-run.c (compile_object_run): Replace
6885         throw_exception with throw.
6886         * cli/cli-script.c (process_next_line): Replace throw_exception
6887         with throw.
6888         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6889         (btrace_enable, btrace_maint_update_pt_packets): Replace
6890         throw_exception with throw.
6891         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6892         throw_exception with throw.
6893         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6894         throw_exception with throw.
6895         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6896         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6897         * aarch64-tdep.c (aarch64_make_prologue_cache)
6898         (aarch64_make_stub_cache): Replace throw_exception with throw.
6899
6900 2019-04-08  Tom Tromey  <tom@tromey.com>
6901
6902         * common/common-exceptions.c (throw_exception): Rename from
6903         throw_exception_cxx.  Remove old copy.  Make argument const.
6904         (throw_it): Create and throw exception objects directly.
6905         * common/common-exceptions.h (throw_exception): Make argument
6906         const.
6907         (struct gdb_exception_error): Add constructor.
6908         (struct gdb_exception_quit): Add constructor.
6909
6910 2019-04-08  Tom Tromey  <tom@tromey.com>
6911
6912         * common/common-exceptions.h (exception_rethrow): Don't declare.
6913         (TRY_SJLJ): Update comment.
6914         (TRY, CATCH, END_CATCH): Remove.
6915         * common/common-exceptions.c (exception_rethrow): Remove.
6916
6917 2019-04-08  Tom Tromey  <tom@tromey.com>
6918
6919         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6920         Remove.
6921         (gdb_exception_error): Rename from
6922         gdb_exception_RETURN_MASK_ERROR.
6923         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6924         (gdb_quit_bad_alloc): Update.
6925         * aarch64-tdep.c: Update.
6926         * ada-lang.c: Update.
6927         * ada-typeprint.c: Update.
6928         * ada-valprint.c: Update.
6929         * amd64-tdep.c: Update.
6930         * arch-utils.c: Update.
6931         * break-catch-throw.c: Update.
6932         * breakpoint.c: Update.
6933         * btrace.c: Update.
6934         * c-varobj.c: Update.
6935         * cli/cli-cmds.c: Update.
6936         * cli/cli-interp.c: Update.
6937         * cli/cli-script.c: Update.
6938         * common/common-exceptions.c: Update.
6939         * common/new-op.c: Update.
6940         * common/selftest.c: Update.
6941         * compile/compile-c-symbols.c: Update.
6942         * compile/compile-cplus-symbols.c: Update.
6943         * compile/compile-object-load.c: Update.
6944         * compile/compile-object-run.c: Update.
6945         * completer.c: Update.
6946         * corelow.c: Update.
6947         * cp-abi.c: Update.
6948         * cp-support.c: Update.
6949         * cp-valprint.c: Update.
6950         * darwin-nat.c: Update.
6951         * disasm-selftests.c: Update.
6952         * dtrace-probe.c: Update.
6953         * dwarf-index-cache.c: Update.
6954         * dwarf-index-write.c: Update.
6955         * dwarf2-frame-tailcall.c: Update.
6956         * dwarf2-frame.c: Update.
6957         * dwarf2loc.c: Update.
6958         * dwarf2read.c: Update.
6959         * eval.c: Update.
6960         * event-loop.c: Update.
6961         * event-top.c: Update.
6962         * exec.c: Update.
6963         * f-valprint.c: Update.
6964         * fbsd-tdep.c: Update.
6965         * frame-unwind.c: Update.
6966         * frame.c: Update.
6967         * gdbtypes.c: Update.
6968         * gnu-v3-abi.c: Update.
6969         * guile/guile-internal.h: Update.
6970         * guile/scm-block.c: Update.
6971         * guile/scm-breakpoint.c: Update.
6972         * guile/scm-cmd.c: Update.
6973         * guile/scm-disasm.c: Update.
6974         * guile/scm-frame.c: Update.
6975         * guile/scm-lazy-string.c: Update.
6976         * guile/scm-math.c: Update.
6977         * guile/scm-param.c: Update.
6978         * guile/scm-ports.c: Update.
6979         * guile/scm-pretty-print.c: Update.
6980         * guile/scm-symbol.c: Update.
6981         * guile/scm-symtab.c: Update.
6982         * guile/scm-type.c: Update.
6983         * guile/scm-value.c: Update.
6984         * i386-linux-tdep.c: Update.
6985         * i386-tdep.c: Update.
6986         * inf-loop.c: Update.
6987         * infcall.c: Update.
6988         * infcmd.c: Update.
6989         * infrun.c: Update.
6990         * jit.c: Update.
6991         * language.c: Update.
6992         * linespec.c: Update.
6993         * linux-fork.c: Update.
6994         * linux-nat.c: Update.
6995         * linux-tdep.c: Update.
6996         * linux-thread-db.c: Update.
6997         * main.c: Update.
6998         * mi/mi-cmd-break.c: Update.
6999         * mi/mi-cmd-stack.c: Update.
7000         * mi/mi-interp.c: Update.
7001         * mi/mi-main.c: Update.
7002         * objc-lang.c: Update.
7003         * p-valprint.c: Update.
7004         * parse.c: Update.
7005         * ppc-linux-tdep.c: Update.
7006         * printcmd.c: Update.
7007         * python/py-arch.c: Update.
7008         * python/py-breakpoint.c: Update.
7009         * python/py-cmd.c: Update.
7010         * python/py-finishbreakpoint.c: Update.
7011         * python/py-frame.c: Update.
7012         * python/py-framefilter.c: Update.
7013         * python/py-gdb-readline.c: Update.
7014         * python/py-inferior.c: Update.
7015         * python/py-infthread.c: Update.
7016         * python/py-lazy-string.c: Update.
7017         * python/py-linetable.c: Update.
7018         * python/py-objfile.c: Update.
7019         * python/py-param.c: Update.
7020         * python/py-prettyprint.c: Update.
7021         * python/py-progspace.c: Update.
7022         * python/py-record-btrace.c: Update.
7023         * python/py-record.c: Update.
7024         * python/py-symbol.c: Update.
7025         * python/py-type.c: Update.
7026         * python/py-unwind.c: Update.
7027         * python/py-utils.c: Update.
7028         * python/py-value.c: Update.
7029         * python/python.c: Update.
7030         * record-btrace.c: Update.
7031         * record-full.c: Update.
7032         * remote-fileio.c: Update.
7033         * remote.c: Update.
7034         * riscv-tdep.c: Update.
7035         * rs6000-aix-tdep.c: Update.
7036         * rs6000-tdep.c: Update.
7037         * rust-exp.y: Update.
7038         * rust-lang.c: Update.
7039         * s390-tdep.c: Update.
7040         * selftest-arch.c: Update.
7041         * solib-dsbt.c: Update.
7042         * solib-frv.c: Update.
7043         * solib-spu.c: Update.
7044         * solib-svr4.c: Update.
7045         * solib.c: Update.
7046         * sparc64-linux-tdep.c: Update.
7047         * stack.c: Update.
7048         * symfile-mem.c: Update.
7049         * symmisc.c: Update.
7050         * target.c: Update.
7051         * thread.c: Update.
7052         * top.c: Update.
7053         * tracefile-tfile.c: Update.
7054         * tui/tui.c: Update.
7055         * typeprint.c: Update.
7056         * unittests/cli-utils-selftests.c: Update.
7057         * unittests/parse-connection-spec-selftests.c: Update.
7058         * valops.c: Update.
7059         * valprint.c: Update.
7060         * value.c: Update.
7061         * varobj.c: Update.
7062         * windows-nat.c: Update.
7063         * x86-linux-nat.c: Update.
7064         * xml-support.c: Update.
7065
7066 2019-04-08  Tom Tromey  <tom@tromey.com>
7067
7068         * xml-support.c: Use C++ exception handling.
7069         * x86-linux-nat.c: Use C++ exception handling.
7070         * windows-nat.c: Use C++ exception handling.
7071         * varobj.c: Use C++ exception handling.
7072         * value.c: Use C++ exception handling.
7073         * valprint.c: Use C++ exception handling.
7074         * valops.c: Use C++ exception handling.
7075         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7076         handling.
7077         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7078         * typeprint.c: Use C++ exception handling.
7079         * tui/tui.c: Use C++ exception handling.
7080         * tracefile-tfile.c: Use C++ exception handling.
7081         * top.c: Use C++ exception handling.
7082         * thread.c: Use C++ exception handling.
7083         * target.c: Use C++ exception handling.
7084         * symmisc.c: Use C++ exception handling.
7085         * symfile-mem.c: Use C++ exception handling.
7086         * stack.c: Use C++ exception handling.
7087         * sparc64-linux-tdep.c: Use C++ exception handling.
7088         * solib.c: Use C++ exception handling.
7089         * solib-svr4.c: Use C++ exception handling.
7090         * solib-spu.c: Use C++ exception handling.
7091         * solib-frv.c: Use C++ exception handling.
7092         * solib-dsbt.c: Use C++ exception handling.
7093         * selftest-arch.c: Use C++ exception handling.
7094         * s390-tdep.c: Use C++ exception handling.
7095         * rust-lang.c: Use C++ exception handling.
7096         * rust-exp.y: Use C++ exception handling.
7097         * rs6000-tdep.c: Use C++ exception handling.
7098         * rs6000-aix-tdep.c: Use C++ exception handling.
7099         * riscv-tdep.c: Use C++ exception handling.
7100         * remote.c: Use C++ exception handling.
7101         * remote-fileio.c: Use C++ exception handling.
7102         * record-full.c: Use C++ exception handling.
7103         * record-btrace.c: Use C++ exception handling.
7104         * python/python.c: Use C++ exception handling.
7105         * python/py-value.c: Use C++ exception handling.
7106         * python/py-utils.c: Use C++ exception handling.
7107         * python/py-unwind.c: Use C++ exception handling.
7108         * python/py-type.c: Use C++ exception handling.
7109         * python/py-symbol.c: Use C++ exception handling.
7110         * python/py-record.c: Use C++ exception handling.
7111         * python/py-record-btrace.c: Use C++ exception handling.
7112         * python/py-progspace.c: Use C++ exception handling.
7113         * python/py-prettyprint.c: Use C++ exception handling.
7114         * python/py-param.c: Use C++ exception handling.
7115         * python/py-objfile.c: Use C++ exception handling.
7116         * python/py-linetable.c: Use C++ exception handling.
7117         * python/py-lazy-string.c: Use C++ exception handling.
7118         * python/py-infthread.c: Use C++ exception handling.
7119         * python/py-inferior.c: Use C++ exception handling.
7120         * python/py-gdb-readline.c: Use C++ exception handling.
7121         * python/py-framefilter.c: Use C++ exception handling.
7122         * python/py-frame.c: Use C++ exception handling.
7123         * python/py-finishbreakpoint.c: Use C++ exception handling.
7124         * python/py-cmd.c: Use C++ exception handling.
7125         * python/py-breakpoint.c: Use C++ exception handling.
7126         * python/py-arch.c: Use C++ exception handling.
7127         * printcmd.c: Use C++ exception handling.
7128         * ppc-linux-tdep.c: Use C++ exception handling.
7129         * parse.c: Use C++ exception handling.
7130         * p-valprint.c: Use C++ exception handling.
7131         * objc-lang.c: Use C++ exception handling.
7132         * mi/mi-main.c: Use C++ exception handling.
7133         * mi/mi-interp.c: Use C++ exception handling.
7134         * mi/mi-cmd-stack.c: Use C++ exception handling.
7135         * mi/mi-cmd-break.c: Use C++ exception handling.
7136         * main.c: Use C++ exception handling.
7137         * linux-thread-db.c: Use C++ exception handling.
7138         * linux-tdep.c: Use C++ exception handling.
7139         * linux-nat.c: Use C++ exception handling.
7140         * linux-fork.c: Use C++ exception handling.
7141         * linespec.c: Use C++ exception handling.
7142         * language.c: Use C++ exception handling.
7143         * jit.c: Use C++ exception handling.
7144         * infrun.c: Use C++ exception handling.
7145         * infcmd.c: Use C++ exception handling.
7146         * infcall.c: Use C++ exception handling.
7147         * inf-loop.c: Use C++ exception handling.
7148         * i386-tdep.c: Use C++ exception handling.
7149         * i386-linux-tdep.c: Use C++ exception handling.
7150         * guile/scm-value.c: Use C++ exception handling.
7151         * guile/scm-type.c: Use C++ exception handling.
7152         * guile/scm-symtab.c: Use C++ exception handling.
7153         * guile/scm-symbol.c: Use C++ exception handling.
7154         * guile/scm-pretty-print.c: Use C++ exception handling.
7155         * guile/scm-ports.c: Use C++ exception handling.
7156         * guile/scm-param.c: Use C++ exception handling.
7157         * guile/scm-math.c: Use C++ exception handling.
7158         * guile/scm-lazy-string.c: Use C++ exception handling.
7159         * guile/scm-frame.c: Use C++ exception handling.
7160         * guile/scm-disasm.c: Use C++ exception handling.
7161         * guile/scm-cmd.c: Use C++ exception handling.
7162         * guile/scm-breakpoint.c: Use C++ exception handling.
7163         * guile/scm-block.c: Use C++ exception handling.
7164         * guile/guile-internal.h: Use C++ exception handling.
7165         * gnu-v3-abi.c: Use C++ exception handling.
7166         * gdbtypes.c: Use C++ exception handling.
7167         * frame.c: Use C++ exception handling.
7168         * frame-unwind.c: Use C++ exception handling.
7169         * fbsd-tdep.c: Use C++ exception handling.
7170         * f-valprint.c: Use C++ exception handling.
7171         * exec.c: Use C++ exception handling.
7172         * event-top.c: Use C++ exception handling.
7173         * event-loop.c: Use C++ exception handling.
7174         * eval.c: Use C++ exception handling.
7175         * dwarf2read.c: Use C++ exception handling.
7176         * dwarf2loc.c: Use C++ exception handling.
7177         * dwarf2-frame.c: Use C++ exception handling.
7178         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7179         * dwarf-index-write.c: Use C++ exception handling.
7180         * dwarf-index-cache.c: Use C++ exception handling.
7181         * dtrace-probe.c: Use C++ exception handling.
7182         * disasm-selftests.c: Use C++ exception handling.
7183         * darwin-nat.c: Use C++ exception handling.
7184         * cp-valprint.c: Use C++ exception handling.
7185         * cp-support.c: Use C++ exception handling.
7186         * cp-abi.c: Use C++ exception handling.
7187         * corelow.c: Use C++ exception handling.
7188         * completer.c: Use C++ exception handling.
7189         * compile/compile-object-run.c: Use C++ exception handling.
7190         * compile/compile-object-load.c: Use C++ exception handling.
7191         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7192         * compile/compile-c-symbols.c: Use C++ exception handling.
7193         * common/selftest.c: Use C++ exception handling.
7194         * common/new-op.c: Use C++ exception handling.
7195         * cli/cli-script.c: Use C++ exception handling.
7196         * cli/cli-interp.c: Use C++ exception handling.
7197         * cli/cli-cmds.c: Use C++ exception handling.
7198         * c-varobj.c: Use C++ exception handling.
7199         * btrace.c: Use C++ exception handling.
7200         * breakpoint.c: Use C++ exception handling.
7201         * break-catch-throw.c: Use C++ exception handling.
7202         * arch-utils.c: Use C++ exception handling.
7203         * amd64-tdep.c: Use C++ exception handling.
7204         * ada-valprint.c: Use C++ exception handling.
7205         * ada-typeprint.c: Use C++ exception handling.
7206         * ada-lang.c: Use C++ exception handling.
7207         * aarch64-tdep.c: Use C++ exception handling.
7208
7209 2019-04-08  Tom Tromey  <tom@tromey.com>
7210
7211         * xml-support.c (gdb_xml_parser::parse): Update.
7212         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7213         * value.c (show_convenience): Update.
7214         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7215         (test_parse_flags_qcs): Update.
7216         * thread.c (thr_try_catch_cmd): Update.
7217         * target.c (target_translate_tls_address): Update.
7218         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7219         (info_frame_command_core, frame_apply_command_count): Update.
7220         * rust-exp.y (rust_lex_exception_test): Update.
7221         * riscv-tdep.c (riscv_print_one_register_info): Update.
7222         * remote.c (remote_target::enable_btrace): Update.
7223         * record-btrace.c (record_btrace_enable_warn): Update.
7224         * python/py-utils.c (gdbpy_convert_exception): Update.
7225         * printcmd.c (do_one_display, print_variable_and_value): Update.
7226         * mi/mi-main.c (mi_print_exception): Update.
7227         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7228         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7229         * linux-nat.c (linux_nat_target::attach): Update.
7230         * linux-fork.c (class scoped_switch_fork_info): Update.
7231         * infrun.c (displaced_step_prepare): Update.
7232         * infcall.c (call_function_by_hand_dummy): Update.
7233         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7234         * gnu-v3-abi.c (print_one_vtable): Update.
7235         * frame.c (get_prev_frame_always): Update.
7236         * f-valprint.c (info_common_command_for_block): Update.
7237         * exec.c (try_open_exec_file): Update.
7238         * exceptions.c (print_exception, exception_print)
7239         (exception_fprintf, exception_print_same): Update.
7240         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7241         * dwarf-index-cache.c (index_cache::store)
7242         (index_cache::lookup_gdb_index): Update.
7243         * darwin-nat.c (maybe_cache_shell): Update.
7244         * cp-valprint.c (cp_print_value_fields): Update.
7245         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7246         (gcc_cplus_symbol_address): Update.
7247         * compile/compile-c-symbols.c (gcc_convert_symbol)
7248         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7249         * common/selftest.c: Update.
7250         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7251         a std::string.
7252         (exception_try_scope_entry, exception_try_scope_exit): Don't
7253         declare.
7254         (struct exception_try_scope): Remove.
7255         (TRY): Don't use exception_try_scope.
7256         (struct gdb_exception): Add constructor, operator=.
7257         <what>: New method.
7258         (struct gdb_exception_RETURN_MASK_ALL)
7259         (struct gdb_exception_RETURN_MASK_ERROR)
7260         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7261         (struct gdb_quit_bad_alloc): Update.
7262         * common/common-exceptions.c (exception_none): Change
7263         initializer.
7264         (struct catcher) <state, exception>: Initialize inline.
7265         <prev>: Remove member.
7266         (current_catcher): Remove.
7267         (catchers): New global.
7268         (exceptions_state_mc_init): Simplify.
7269         (catcher_pop): Remove.
7270         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7271         (try_scope_depth, exception_try_scope_entry)
7272         (exception_try_scope_exit): Remove.
7273         (throw_exception_sjlj): Update.
7274         (exception_messages, exception_messages_size): Remove.
7275         (throw_it): Simplify.
7276         (gdb_exception_sliced_copy): Remove.
7277         (throw_exception_cxx): Update.
7278         * cli/cli-script.c (script_from_file): Update.
7279         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7280         Update.
7281         * ada-valprint.c (ada_val_print): Update.
7282         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7283         (create_excep_cond_exprs): Update.
7284
7285 2019-04-08  Tom Tromey  <tom@tromey.com>
7286
7287         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7288         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7289         (TRY, CATCH, END_CATCH): Remove some definitions.
7290         * common/common-exceptions.c: Don't use GDB_XCPT.
7291         (catcher_list_size): Remove.
7292         (throw_exception, throw_it): Simplify.
7293
7294 2019-04-05  Tom Tromey  <tom@tromey.com>
7295
7296         Revert the header-sorting patch.
7297         * ft32-tdep.c: Revert.
7298         * frv-tdep.c: Revert.
7299         * frv-linux-tdep.c: Revert.
7300         * frame.c: Revert.
7301         * frame-unwind.c: Revert.
7302         * frame-base.c: Revert.
7303         * fork-child.c: Revert.
7304         * findvar.c: Revert.
7305         * findcmd.c: Revert.
7306         * filesystem.c: Revert.
7307         * filename-seen-cache.h: Revert.
7308         * filename-seen-cache.c: Revert.
7309         * fbsd-tdep.c: Revert.
7310         * fbsd-nat.h: Revert.
7311         * fbsd-nat.c: Revert.
7312         * f-valprint.c: Revert.
7313         * f-typeprint.c: Revert.
7314         * f-lang.c: Revert.
7315         * extension.h: Revert.
7316         * extension.c: Revert.
7317         * extension-priv.h: Revert.
7318         * expprint.c: Revert.
7319         * exec.h: Revert.
7320         * exec.c: Revert.
7321         * exceptions.c: Revert.
7322         * event-top.c: Revert.
7323         * event-loop.c: Revert.
7324         * eval.c: Revert.
7325         * elfread.c: Revert.
7326         * dwarf2read.h: Revert.
7327         * dwarf2read.c: Revert.
7328         * dwarf2loc.c: Revert.
7329         * dwarf2expr.h: Revert.
7330         * dwarf2expr.c: Revert.
7331         * dwarf2-frame.c: Revert.
7332         * dwarf2-frame-tailcall.c: Revert.
7333         * dwarf-index-write.h: Revert.
7334         * dwarf-index-write.c: Revert.
7335         * dwarf-index-common.c: Revert.
7336         * dwarf-index-cache.h: Revert.
7337         * dwarf-index-cache.c: Revert.
7338         * dummy-frame.c: Revert.
7339         * dtrace-probe.c: Revert.
7340         * disasm.h: Revert.
7341         * disasm.c: Revert.
7342         * disasm-selftests.c: Revert.
7343         * dictionary.c: Revert.
7344         * dicos-tdep.c: Revert.
7345         * demangle.c: Revert.
7346         * dcache.h: Revert.
7347         * dcache.c: Revert.
7348         * darwin-nat.h: Revert.
7349         * darwin-nat.c: Revert.
7350         * darwin-nat-info.c: Revert.
7351         * d-valprint.c: Revert.
7352         * d-namespace.c: Revert.
7353         * d-lang.c: Revert.
7354         * ctf.c: Revert.
7355         * csky-tdep.c: Revert.
7356         * csky-linux-tdep.c: Revert.
7357         * cris-tdep.c: Revert.
7358         * cris-linux-tdep.c: Revert.
7359         * cp-valprint.c: Revert.
7360         * cp-support.c: Revert.
7361         * cp-namespace.c: Revert.
7362         * cp-abi.c: Revert.
7363         * corelow.c: Revert.
7364         * corefile.c: Revert.
7365         * continuations.c: Revert.
7366         * completer.h: Revert.
7367         * completer.c: Revert.
7368         * complaints.c: Revert.
7369         * coffread.c: Revert.
7370         * coff-pe-read.c: Revert.
7371         * cli-out.h: Revert.
7372         * cli-out.c: Revert.
7373         * charset.c: Revert.
7374         * c-varobj.c: Revert.
7375         * c-valprint.c: Revert.
7376         * c-typeprint.c: Revert.
7377         * c-lang.c: Revert.
7378         * buildsym.c: Revert.
7379         * buildsym-legacy.c: Revert.
7380         * build-id.h: Revert.
7381         * build-id.c: Revert.
7382         * btrace.c: Revert.
7383         * bsd-uthread.c: Revert.
7384         * breakpoint.h: Revert.
7385         * breakpoint.c: Revert.
7386         * break-catch-throw.c: Revert.
7387         * break-catch-syscall.c: Revert.
7388         * break-catch-sig.c: Revert.
7389         * blockframe.c: Revert.
7390         * block.c: Revert.
7391         * bfin-tdep.c: Revert.
7392         * bfin-linux-tdep.c: Revert.
7393         * bfd-target.c: Revert.
7394         * bcache.c: Revert.
7395         * ax-general.c: Revert.
7396         * ax-gdb.h: Revert.
7397         * ax-gdb.c: Revert.
7398         * avr-tdep.c: Revert.
7399         * auxv.c: Revert.
7400         * auto-load.c: Revert.
7401         * arm-wince-tdep.c: Revert.
7402         * arm-tdep.c: Revert.
7403         * arm-symbian-tdep.c: Revert.
7404         * arm-pikeos-tdep.c: Revert.
7405         * arm-obsd-tdep.c: Revert.
7406         * arm-nbsd-tdep.c: Revert.
7407         * arm-nbsd-nat.c: Revert.
7408         * arm-linux-tdep.c: Revert.
7409         * arm-linux-nat.c: Revert.
7410         * arm-fbsd-tdep.c: Revert.
7411         * arm-fbsd-nat.c: Revert.
7412         * arm-bsd-tdep.c: Revert.
7413         * arch-utils.c: Revert.
7414         * arc-tdep.c: Revert.
7415         * arc-newlib-tdep.c: Revert.
7416         * annotate.h: Revert.
7417         * annotate.c: Revert.
7418         * amd64-windows-tdep.c: Revert.
7419         * amd64-windows-nat.c: Revert.
7420         * amd64-tdep.c: Revert.
7421         * amd64-sol2-tdep.c: Revert.
7422         * amd64-obsd-tdep.c: Revert.
7423         * amd64-obsd-nat.c: Revert.
7424         * amd64-nbsd-tdep.c: Revert.
7425         * amd64-nbsd-nat.c: Revert.
7426         * amd64-nat.c: Revert.
7427         * amd64-linux-tdep.c: Revert.
7428         * amd64-linux-nat.c: Revert.
7429         * amd64-fbsd-tdep.c: Revert.
7430         * amd64-fbsd-nat.c: Revert.
7431         * amd64-dicos-tdep.c: Revert.
7432         * amd64-darwin-tdep.c: Revert.
7433         * amd64-bsd-nat.c: Revert.
7434         * alpha-tdep.c: Revert.
7435         * alpha-obsd-tdep.c: Revert.
7436         * alpha-nbsd-tdep.c: Revert.
7437         * alpha-mdebug-tdep.c: Revert.
7438         * alpha-linux-tdep.c: Revert.
7439         * alpha-linux-nat.c: Revert.
7440         * alpha-bsd-tdep.c: Revert.
7441         * alpha-bsd-nat.c: Revert.
7442         * aix-thread.c: Revert.
7443         * agent.c: Revert.
7444         * addrmap.c: Revert.
7445         * ada-varobj.c: Revert.
7446         * ada-valprint.c: Revert.
7447         * ada-typeprint.c: Revert.
7448         * ada-tasks.c: Revert.
7449         * ada-lang.c: Revert.
7450         * aarch64-tdep.c: Revert.
7451         * aarch64-ravenscar-thread.c: Revert.
7452         * aarch64-newlib-tdep.c: Revert.
7453         * aarch64-linux-tdep.c: Revert.
7454         * aarch64-linux-nat.c: Revert.
7455         * aarch64-fbsd-tdep.c: Revert.
7456         * aarch64-fbsd-nat.c: Revert.
7457         * aarch32-linux-nat.c: Revert.
7458
7459 2019-04-05  Tom Tromey  <tom@tromey.com>
7460
7461         * ft32-tdep.c: Sort headers.
7462         * frv-tdep.c: Sort headers.
7463         * frv-linux-tdep.c: Sort headers.
7464         * frame.c: Sort headers.
7465         * frame-unwind.c: Sort headers.
7466         * frame-base.c: Sort headers.
7467         * fork-child.c: Sort headers.
7468         * findvar.c: Sort headers.
7469         * findcmd.c: Sort headers.
7470         * filesystem.c: Sort headers.
7471         * filename-seen-cache.h: Sort headers.
7472         * filename-seen-cache.c: Sort headers.
7473         * fbsd-tdep.c: Sort headers.
7474         * fbsd-nat.h: Sort headers.
7475         * fbsd-nat.c: Sort headers.
7476         * f-valprint.c: Sort headers.
7477         * f-typeprint.c: Sort headers.
7478         * f-lang.c: Sort headers.
7479         * extension.h: Sort headers.
7480         * extension.c: Sort headers.
7481         * extension-priv.h: Sort headers.
7482         * expprint.c: Sort headers.
7483         * exec.h: Sort headers.
7484         * exec.c: Sort headers.
7485         * exceptions.c: Sort headers.
7486         * event-top.c: Sort headers.
7487         * event-loop.c: Sort headers.
7488         * eval.c: Sort headers.
7489         * elfread.c: Sort headers.
7490         * dwarf2read.h: Sort headers.
7491         * dwarf2read.c: Sort headers.
7492         * dwarf2loc.c: Sort headers.
7493         * dwarf2expr.h: Sort headers.
7494         * dwarf2expr.c: Sort headers.
7495         * dwarf2-frame.c: Sort headers.
7496         * dwarf2-frame-tailcall.c: Sort headers.
7497         * dwarf-index-write.h: Sort headers.
7498         * dwarf-index-write.c: Sort headers.
7499         * dwarf-index-common.c: Sort headers.
7500         * dwarf-index-cache.h: Sort headers.
7501         * dwarf-index-cache.c: Sort headers.
7502         * dummy-frame.c: Sort headers.
7503         * dtrace-probe.c: Sort headers.
7504         * disasm.h: Sort headers.
7505         * disasm.c: Sort headers.
7506         * disasm-selftests.c: Sort headers.
7507         * dictionary.c: Sort headers.
7508         * dicos-tdep.c: Sort headers.
7509         * demangle.c: Sort headers.
7510         * dcache.h: Sort headers.
7511         * dcache.c: Sort headers.
7512         * darwin-nat.h: Sort headers.
7513         * darwin-nat.c: Sort headers.
7514         * darwin-nat-info.c: Sort headers.
7515         * d-valprint.c: Sort headers.
7516         * d-namespace.c: Sort headers.
7517         * d-lang.c: Sort headers.
7518         * ctf.c: Sort headers.
7519         * csky-tdep.c: Sort headers.
7520         * csky-linux-tdep.c: Sort headers.
7521         * cris-tdep.c: Sort headers.
7522         * cris-linux-tdep.c: Sort headers.
7523         * cp-valprint.c: Sort headers.
7524         * cp-support.c: Sort headers.
7525         * cp-namespace.c: Sort headers.
7526         * cp-abi.c: Sort headers.
7527         * corelow.c: Sort headers.
7528         * corefile.c: Sort headers.
7529         * continuations.c: Sort headers.
7530         * completer.h: Sort headers.
7531         * completer.c: Sort headers.
7532         * complaints.c: Sort headers.
7533         * coffread.c: Sort headers.
7534         * coff-pe-read.c: Sort headers.
7535         * cli-out.h: Sort headers.
7536         * cli-out.c: Sort headers.
7537         * charset.c: Sort headers.
7538         * c-varobj.c: Sort headers.
7539         * c-valprint.c: Sort headers.
7540         * c-typeprint.c: Sort headers.
7541         * c-lang.c: Sort headers.
7542         * buildsym.c: Sort headers.
7543         * buildsym-legacy.c: Sort headers.
7544         * build-id.h: Sort headers.
7545         * build-id.c: Sort headers.
7546         * btrace.c: Sort headers.
7547         * bsd-uthread.c: Sort headers.
7548         * breakpoint.h: Sort headers.
7549         * breakpoint.c: Sort headers.
7550         * break-catch-throw.c: Sort headers.
7551         * break-catch-syscall.c: Sort headers.
7552         * break-catch-sig.c: Sort headers.
7553         * blockframe.c: Sort headers.
7554         * block.c: Sort headers.
7555         * bfin-tdep.c: Sort headers.
7556         * bfin-linux-tdep.c: Sort headers.
7557         * bfd-target.c: Sort headers.
7558         * bcache.c: Sort headers.
7559         * ax-general.c: Sort headers.
7560         * ax-gdb.h: Sort headers.
7561         * ax-gdb.c: Sort headers.
7562         * avr-tdep.c: Sort headers.
7563         * auxv.c: Sort headers.
7564         * auto-load.c: Sort headers.
7565         * arm-wince-tdep.c: Sort headers.
7566         * arm-tdep.c: Sort headers.
7567         * arm-symbian-tdep.c: Sort headers.
7568         * arm-pikeos-tdep.c: Sort headers.
7569         * arm-obsd-tdep.c: Sort headers.
7570         * arm-nbsd-tdep.c: Sort headers.
7571         * arm-nbsd-nat.c: Sort headers.
7572         * arm-linux-tdep.c: Sort headers.
7573         * arm-linux-nat.c: Sort headers.
7574         * arm-fbsd-tdep.c: Sort headers.
7575         * arm-fbsd-nat.c: Sort headers.
7576         * arm-bsd-tdep.c: Sort headers.
7577         * arch-utils.c: Sort headers.
7578         * arc-tdep.c: Sort headers.
7579         * arc-newlib-tdep.c: Sort headers.
7580         * annotate.h: Sort headers.
7581         * annotate.c: Sort headers.
7582         * amd64-windows-tdep.c: Sort headers.
7583         * amd64-windows-nat.c: Sort headers.
7584         * amd64-tdep.c: Sort headers.
7585         * amd64-sol2-tdep.c: Sort headers.
7586         * amd64-obsd-tdep.c: Sort headers.
7587         * amd64-obsd-nat.c: Sort headers.
7588         * amd64-nbsd-tdep.c: Sort headers.
7589         * amd64-nbsd-nat.c: Sort headers.
7590         * amd64-nat.c: Sort headers.
7591         * amd64-linux-tdep.c: Sort headers.
7592         * amd64-linux-nat.c: Sort headers.
7593         * amd64-fbsd-tdep.c: Sort headers.
7594         * amd64-fbsd-nat.c: Sort headers.
7595         * amd64-dicos-tdep.c: Sort headers.
7596         * amd64-darwin-tdep.c: Sort headers.
7597         * amd64-bsd-nat.c: Sort headers.
7598         * alpha-tdep.c: Sort headers.
7599         * alpha-obsd-tdep.c: Sort headers.
7600         * alpha-nbsd-tdep.c: Sort headers.
7601         * alpha-mdebug-tdep.c: Sort headers.
7602         * alpha-linux-tdep.c: Sort headers.
7603         * alpha-linux-nat.c: Sort headers.
7604         * alpha-bsd-tdep.c: Sort headers.
7605         * alpha-bsd-nat.c: Sort headers.
7606         * aix-thread.c: Sort headers.
7607         * agent.c: Sort headers.
7608         * addrmap.c: Sort headers.
7609         * ada-varobj.c: Sort headers.
7610         * ada-valprint.c: Sort headers.
7611         * ada-typeprint.c: Sort headers.
7612         * ada-tasks.c: Sort headers.
7613         * ada-lang.c: Sort headers.
7614         * aarch64-tdep.c: Sort headers.
7615         * aarch64-ravenscar-thread.c: Sort headers.
7616         * aarch64-newlib-tdep.c: Sort headers.
7617         * aarch64-linux-tdep.c: Sort headers.
7618         * aarch64-linux-nat.c: Sort headers.
7619         * aarch64-fbsd-tdep.c: Sort headers.
7620         * aarch64-fbsd-nat.c: Sort headers.
7621         * aarch32-linux-nat.c: Sort headers.
7622
7623 2019-04-04  Tom Tromey  <tom@tromey.com>
7624
7625         * varobj.c (varobj_create): Update.
7626         * rust-exp.y (struct rust_parser) <update_innermost_block,
7627         lookup_symbol>: New methods.
7628         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7629         Rename.
7630         (rust_parser::rust_lookup_type)
7631         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7632         * printcmd.c (display_command, do_one_display): Update.
7633         * parser-defs.h (struct parser_state) <parser_state>: Add
7634         "tracker" parameter.
7635         (block_tracker): New member.
7636         (class innermost_block_tracker) <innermost_block_tracker>: Add
7637         "types" parameter.
7638         <reset>: Remove method.
7639         (innermost_block): Don't declare.
7640         (null_post_parser): Update.
7641         * parse.c (innermost_block): Remove global.
7642         (write_dollar_variable): Update.
7643         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7644         Remove "tracker_types" parameter.
7645         (parse_expression): Add "tracker" parameter.
7646         (parse_expression_for_completion): Update.
7647         (null_post_parser): Add "tracker" parameter.
7648         * p-exp.y: Update rules.
7649         * m2-exp.y: Update rules.
7650         * language.h (struct language_defn) <la_post_parser>: Add
7651         "tracker" parameter.
7652         * go-exp.y: Update rules.
7653         * f-exp.y: Update rules.
7654         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7655         parameter.
7656         * d-exp.y: Update rules.
7657         * c-exp.y: Update rules.
7658         * breakpoint.c (set_breakpoint_condition): Create an
7659         innermost_block_tracker.
7660         (watch_command_1): Likewise.
7661         * ada-lang.c (resolve): Add "tracker" parameter.
7662         (resolve_subexp): Likewise.
7663         * ada-exp.y (write_var_from_sym): Update.
7664
7665 2019-04-04  Tom Tromey  <tom@tromey.com>
7666
7667         * type-stack.h: New file.
7668         * type-stack.c: New file.
7669         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7670         type-stack.h.
7671         (insert_into_type_stack, insert_type, push_type, push_type_int)
7672         (insert_type_address_space, pop_type, pop_type_int)
7673         (pop_typelist, pop_type_stack, append_type_stack)
7674         (push_type_stack, get_type_stack, push_typelist)
7675         (follow_type_instance_flags, follow_types): Don't declare.
7676         * parse.c (type_stack): Remove global.
7677         (parse_exp_in_context): Update.
7678         (insert_into_type_stack, insert_type, push_type, push_type_int)
7679         (insert_type_address_space, pop_type, pop_type_int)
7680         (pop_typelist, pop_type_stack, append_type_stack)
7681         (push_type_stack, get_type_stack, push_typelist)
7682         (follow_type_instance_flags, follow_types): Remove (moved to
7683         type-stack.c).
7684         * f-exp.y (type_stack): New global.
7685         Update rules.
7686         (push_kind_type, f_parse): Update.
7687         * d-exp.y (type_stack): New global.
7688         Update rules.
7689         (d_parse): Update.
7690         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7691         Update rules.
7692         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7693         (HFILES_NO_SRCDIR): Add type-stack.h.
7694
7695 2019-04-04  Tom Tromey  <tom@tromey.com>
7696
7697         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7698         (rust_parser::convert_ast_to_expression, rust_parse)
7699         (rust_lex_test_completion, rust_lex_tests): Update.
7700         * parser-defs.h (struct expr_completion_state): New.
7701         (struct parser_state) <parser_state>: Add completion parameter.
7702         <mark_struct_expression, mark_completion_tag>: New methods.
7703         <parse_completion, m_completion_state>: New members.
7704         (prefixify_expression, null_post_parser): Update.
7705         (mark_struct_expression, mark_completion_tag): Don't declare.
7706         * parse.c (parse_completion, expout_last_struct)
7707         (expout_tag_completion_type, expout_completion_name): Remove
7708         globals.
7709         (parser_state::mark_struct_expression)
7710         (parser_state::mark_completion_tag): Now methods.
7711         (prefixify_expression): Add last_struct parameter.
7712         (prefixify_subexp): Likewise.
7713         (parse_exp_1): Update.
7714         (parse_exp_in_context): Add cstate parameter.  Update.
7715         (parse_expression_for_completion): Create an
7716         expr_completion_state.
7717         (null_post_parser): Add "completion" parameter.
7718         * p-exp.y: Update rules.
7719         (yylex): Update.
7720         * language.h (struct language_defn) <la_post_parser>: Add
7721         "completing" parameter.
7722         * go-exp.y: Update rules.
7723         (lex_one_token): Update.
7724         * expression.h (parse_completion): Don't declare.
7725         * d-exp.y: Update rules.
7726         (lex_one_token): Update rules.
7727         * c-exp.y: Update rules.
7728         (lex_one_token): Update.
7729         * ada-lang.c (resolve): Add "parse_completion" parameter.
7730         (resolve_subexp): Likewise.
7731         (ada_resolve_function): Likewise.
7732
7733 2019-04-04  Tom Tromey  <tom@tromey.com>
7734
7735         * parser-defs.h (struct parser_state) <start_arglist,
7736         end_arglist>: New methods.
7737         <arglist_len, m_funcall_chain>: New members.
7738         (arglist_len, start_arglist, end_arglist): Don't declare.
7739         * parse.c (arglist_len, funcall_chain): Remove global.
7740         (start_arglist, end_arglist): Remove functions.
7741         (parse_exp_in_context): Update.
7742         * p-exp.y: Update rules.
7743         * m2-exp.y: Update rules.
7744         * go-exp.y: Update rules.
7745         * f-exp.y: Update rules.
7746         * d-exp.y: Update rules.
7747         * c-exp.y: Update rules.
7748
7749 2019-04-04  Tom Tromey  <tom@tromey.com>
7750
7751         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7752         lex_operator, push_back>: New methods.
7753         Update all rules.
7754         (rust_parser::lex_hex, lex_escape): Rename and update.
7755         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7756         (rust_parser::lex_operator): Rename and update.
7757         (rust_parser::lex_number, rustyylex, rustyyerror)
7758         (rust_lex_test_init, rust_lex_test_sequence)
7759         (rust_lex_test_push_back, rust_lex_tests): Update.
7760         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7761         parameter.
7762         <lexptr, prev_lexptr>: New members.
7763         (lexptr, prev_lexptr): Don't declare.
7764         * parse.c (lexptr, prev_lexptr): Remove globals.
7765         (parse_exp_in_context): Update.
7766         * p-exp.y (yylex, yyerror): Update.
7767         * m2-exp.y (parse_number, yylex, yyerror): Update.
7768         * go-exp.y (lex_one_token, yyerror): Update.
7769         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7770         * d-exp.y (lex_one_token, yyerror): Update.
7771         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7772         (lex_one_token, yyerror): Update.
7773         * ada-lex.l (YY_INPUT): Update.
7774         (rewind_to_char): Update.
7775         * ada-exp.y (yyerror): Update.
7776
7777 2019-04-04  Tom Tromey  <tom@tromey.com>
7778
7779         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7780         * parser-defs.h (struct parser_state) <parser_state>: Add new
7781         parameter.
7782         <comma_terminates>: New member.
7783         (comma_terminates): Don't declare global.
7784         * parse.c (comma_terminates): Remove global.
7785         (parse_exp_in_context): Update.
7786         * p-exp.y (yylex): Update.
7787         * m2-exp.y (yylex): Update.
7788         * go-exp.y (lex_one_token): Update.
7789         * f-exp.y (yylex): Update.
7790         * d-exp.y (lex_one_token): Update.
7791         * c-exp.y (lex_one_token): Update.
7792         * ada-lex.l: Update.
7793
7794 2019-04-04  Tom Tromey  <tom@tromey.com>
7795
7796         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7797         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7798         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7799         * parser-defs.h (paren_depth): Don't declare.
7800         * parse.c (paren_depth): Remove global.
7801         (parse_exp_in_context): Update.
7802         * p-exp.y (paren_depth): New global.
7803         (pascal_parse): Initialize it.
7804         * m2-exp.y (paren_depth): New global.
7805         (m2_parse): Initialize it.
7806         * go-exp.y (paren_depth): New global.
7807         (go_parse): Initialize it.
7808         * f-exp.y (paren_depth): New global.
7809         (f_parse): Initialize it.
7810         * d-exp.y (paren_depth): New global.
7811         (d_parse): Initialize it.
7812         * c-exp.y (paren_depth): New global.
7813         (c_parse): Initialize it.
7814         * ada-lex.l (paren_depth): New global.
7815         (lexer_init): Initialize it.
7816
7817 2019-04-04  Tom Tromey  <tom@tromey.com>
7818
7819         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7820         (rust_parser::convert_ast_to_type)
7821         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7822         * parser-defs.h (struct parser_state) <parser_state>: Add
7823         parameters.  Initialize new members.
7824         <expression_context_block, expression_context_pc>: New members.
7825         * parse.c (expression_context_block, expression_context_pc):
7826         Remove globals.
7827         (parse_exp_in_context): Update.
7828         * p-exp.y: Update all rules.
7829         (yylex): Update.
7830         * m2-exp.y: Update all rules.
7831         (yylex): Update.
7832         * go-exp.y (yylex): Update.
7833         * f-exp.y (yylex): Update.
7834         * d-exp.y: Update all rules.
7835         (yylex): Update.
7836         * c-exp.y: Update all rules.
7837         (lex_one_token, classify_name, yylex, c_parse): Update.
7838         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7839
7840 2019-04-04  Tom Tromey  <tom@tromey.com>
7841
7842         * gdbarch.h, gdbarch.c: Rebuild.
7843         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7844         * stap-probe.h:
7845         (struct stap_parse_info): Replace "parser_state" with
7846         "expr_builder".
7847         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7848         (parser_state): New class.
7849         * parse.c (expr_builder): Rename.
7850         (expr_builder::release): Rename.
7851         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7852         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7853         (write_exp_elt_longcst, write_exp_elt_floatcst)
7854         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7855         (write_exp_string_vector, write_exp_bitstring)
7856         (write_exp_msymbol, mark_struct_expression)
7857         (write_dollar_variable)
7858         (insert_type_address_space, increase_expout_size): Replace
7859         "parser_state" with "expr_builder".
7860         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7861         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7862         "parser_state" with "expr_builder".
7863
7864 2019-04-04  Tom Tromey  <tom@tromey.com>
7865
7866         * rust-exp.y: Replace "parse_language" with method call.
7867         * p-exp.y:
7868         (yylex): Replace "parse_language" with method call.
7869         * m2-exp.y:
7870         (yylex): Replace "parse_language" with method call.
7871         * go-exp.y (classify_name): Replace "parse_language" with method
7872         call.
7873         * f-exp.y (yylex): Replace "parse_language" with method call.
7874         * d-exp.y (lex_one_token): Replace "parse_language" with method
7875         call.
7876         * c-exp.y:
7877         (lex_one_token, classify_name, yylex): Replace "parse_language"
7878         with method call.
7879         * ada-exp.y (find_primitive_type, type_char)
7880         (type_system_address): Replace "parse_language" with method call.
7881
7882 2019-04-04  Tom Tromey  <tom@tromey.com>
7883
7884         * rust-exp.y: Replace "parse_gdbarch" with method call.
7885         * parse.c (write_dollar_variable, insert_type_address_space):
7886         Replace "parse_gdbarch" with method call.
7887         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7888         call.
7889         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7890         call.
7891         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7892         "parse_gdbarch" with method call.
7893         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7894         with method call.
7895         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7896         "parse_gdbarch" with method call.
7897         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7898         "parse_gdbarch" with method call.
7899         * c-exp.y (parse_type, parse_number, classify_name): Replace
7900         "parse_gdbarch" with method call.
7901         * ada-lex.l: Replace "parse_gdbarch" with method call.
7902         * ada-exp.y (parse_type, find_primitive_type, type_char)
7903         (type_system_address): Replace "parse_gdbarch" with method call.
7904
7905 2019-04-04  Tom Tromey  <tom@tromey.com>
7906
7907         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7908         * stap-probe.c (stap_parse_argument): Update.
7909         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7910         initial_size parameter.
7911         * rust-exp.y (rust_lex_tests): Update.
7912         * parse.c (parser_state): Update.
7913         (parse_exp_in_context): Update.
7914         * parser-defs.h (struct parser_state) <parser_state>: Remove
7915         "initial_size" parameter.
7916
7917 2019-04-04  Tom Tromey  <tom@tromey.com>
7918
7919         * parser-defs.h (increase_expout_size): Don't declare.
7920         * parse.c (increase_expout_size): Now static.
7921
7922 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7923
7924         * gnu-nat.c (gnu_nat_target::wait): Fix
7925         target_waitstatus_to_string call.
7926
7927 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7928
7929         * eval.c (evaluate_subexp_standard): Handle internal functions
7930         during Fortran function call handling.
7931
7932 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7933
7934         * NEWS: Mention new internal functions.
7935         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7936         (read_base_type): Use dwarf2_init_complex_target_type.
7937         * value.c (creal_internal_fn): New function.
7938         (cimag_internal_fn): New function.
7939         (_initialize_values): Register new internal functions.
7940
7941 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7942
7943         * infrun.c (stop_all_threads): If debug_infrun, always
7944         trace the wait status after wait_one, using
7945         target_waitstatus_to_string and target_pid_to_str.
7946         (handle_inferior_event): Replace various trace of
7947         wait status kind by a single trace.
7948         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7949         wait status kind image by target_waitstatus_to_string.
7950         * target/waitstatus.c (target_waitstatus_to_string): Fix
7951         obsolete comment.
7952
7953 2019-04-01  Tom Tromey  <tromey@adacore.com>
7954
7955         PR symtab/23331:
7956         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7957
7958 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7959             Pedro Alves  <palves@redhat.com>
7960
7961         * top.c (quit_force): Call 'finalize_values'.
7962         * value.c (finalize_values): New function.
7963         * value.h (finalize_values): Declare.
7964
7965 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7966
7967         * NEWS: Announce $_gdb_major and $_gdb_minor.
7968
7969         * top.c (init_gdb_version_vars): New function.
7970         (gdb_init): Call init_gdb_version_vars.
7971
7972 2019-03-29  Tom Tromey  <tromey@adacore.com>
7973
7974         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7975         help text.  Remove dead code.
7976
7977 2019-03-29  Keith Seitz  <keiths@redhat.com>
7978
7979         From Siddhesh Poyarekar:
7980         * f-lang.h (f77_get_upperbound): Return LONGEST.
7981         (f77_get_lowerbound): Likewise.
7982         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7983         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7984         print them.
7985         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7986         plongest to format print it.
7987         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7988         (f77_get_upperbound): Likewise.
7989         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7990         LOWER_BOUND to LONGEST.
7991         (f77_create_arrayprint_offset_tbl): Likewise.
7992
7993 2019-03-29  Keith Seitz  <keiths@redhat.com>
7994
7995         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7996         %s/pulongest for TYPE_LENGTH instead of %d in format
7997         strings.
7998         * ada-typerint.c (ada_print_type): Likewise.
7999         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8000         * compile/compile-c-support.c (generate_register_struct): Likewise.
8001         * gdbtypes.c (recursive_dump_type): Likewise.
8002         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8003         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8004         instead of %d in format strings.
8005         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8006         to std::min to ULONGEST.
8007         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8008         instead of %d in format strings.
8009         * tracepoint.c (info_scope_command): Likewise.
8010         * typeprint.c (print_offset_data::update)
8011         (print_offset_data::finish): Likewise.
8012         * xtensa-tdep.c (xtensa_store_return_value)
8013         (xtensa_push_dummy_call): Likewise.
8014
8015 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8016
8017         * windows-nat.c (display_selector): Fixed format specifications
8018         for 64-bit Cygwin.
8019
8020 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8021
8022         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8023
8024 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8025
8026         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8027         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8028         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8029         (nios2_linux_init_abi): Install it.
8030
8031 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8032
8033         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8034
8035 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8036
8037         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8038
8039 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8040             Tom Tromey  <tromey@adacore.com>
8041
8042         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8043
8044 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8045
8046         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8047         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8048         method to compute the bounds of range types. Also print "[evaluated]"
8049         if the bounds' values come from a dynamic evaluation.
8050
8051 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8052
8053         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8054         whitespace when pretty printing is on.
8055
8056 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8057
8058         * ppc-linux-nat.c: Add include.
8059
8060 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8061
8062         * NEWS: Mention AArch64 Pointer Authentication.
8063
8064 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8065
8066         * arm-linux-nat.c: Add include.
8067
8068 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8069
8070         * source-cache.c (source_cache::get_source_lines): Re-read
8071         fullname after calling open_source_file.
8072
8073 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8074
8075         * NEWS: Mention TLS support for FreeBSD.
8076
8077 2019-03-25  Tom Tromey  <tromey@adacore.com>
8078
8079         * minsyms.c (BUNCH_SIZE): Update comment.
8080         (~minimal_symbol_reader): Remove old comment.
8081         (compact_minimal_symbols): Update comment.
8082         (minimal_symbol_reader::install): Remove old comment.  Update
8083         other comments.
8084
8085 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8086
8087         * s390-linux-nat.c: Add include.
8088
8089 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8090
8091         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8092         Call linux_get_hwcap.
8093         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8094         Likewise.
8095         (aarch64_linux_get_hwcap): Remove function.
8096         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8097         declaration.
8098         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8099         linux_get_hwcap.
8100         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8101         * linux-tdep.c (linux_get_hwcap): Add function.
8102         (linux_get_hwcap2): Likewise.
8103         * linux-tdep.h (linux_get_hwcap): Add declaration.
8104         (linux_get_hwcap2): Likewise.
8105         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8106         (ppc_linux_get_hwcap2): Likewise.
8107         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8108         linux_get_hwcap.
8109         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8110         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8111         (ppc_linux_nat_target::read_description): Likewise.
8112         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8113         * s390-linux-nat.c: Likewise.
8114         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8115
8116 2019-03-24  Tom Tromey  <tom@tromey.com>
8117
8118         * ada-lang.c (standard_lookup): Simplify initialization.
8119         (ada_lookup_symbol_nonlocal): Simplify return.
8120         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8121         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8122         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8123         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8124         initialization.
8125         * solib.c (solib_global_lookup): Simplify.
8126         * symtab.c (null_block_symbol): Remove.
8127         (symbol_cache_lookup): Simplify returns.
8128         (lookup_language_this): Simplify returns.
8129         (lookup_symbol_aux): Simplify return.
8130         (lookup_local_symbol): Simplify returns.
8131         (lookup_global_symbol_from_objfile): Simplify return.
8132         (lookup_symbol_in_objfile_symtabs)
8133         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8134         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8135         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8136         * cp-namespace.c (cp_lookup_bare_symbol)
8137         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8138         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8139         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8140         (cp_lookup_symbol_via_imports): Simplify initialization.
8141         (find_symbol_in_baseclass): Likewise.
8142         * symtab.h (null_block_symbol): Remove.
8143         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8144         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8145         (d_lookup_symbol_module): Likewise.
8146         (find_symbol_in_baseclass): Simplify initialization.
8147
8148 2019-03-24  Tom Tromey  <tom@tromey.com>
8149
8150         * expression.h: Don't include symtab.h.
8151         (struct block): Forward declare.
8152
8153 2019-03-24  Tom Tromey  <tom@tromey.com>
8154
8155         * c-exp.y (typebase): Remove casts.
8156         * gdbtypes.c (lookup_unsigned_typename, )
8157         (lookup_signed_typename): Remove cast.
8158         * eval.c (parse_to_comma_and_eval): Remove cast.
8159         * parse.c (write_dollar_variable): Remove cast.
8160         * block.h (struct block) <superblock>: Now const.
8161         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8162         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8163         (map_block): Make "block" const.
8164         * symfile.h (struct quick_symbol_functions)
8165         <map_matching_symbols>: Constify block argument to "callback".
8166         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8167         const.
8168         (find_pc_sect_compunit_symtab): Make "b" const.
8169         (find_symbol_at_address): Likewise.
8170         (search_symbols): Likewise.
8171         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8172         (dw2_debug_names_lookup_symbol): Likewise.
8173         (dw2_map_matching_symbols): Update.
8174         * p-valprint.c (pascal_val_print): Remove "block".
8175         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8176         (aux_add_nonlocal_symbols): Make "block" const.
8177         (resolve_subexp): Remove cast.
8178         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8179         const.
8180         (iterate_over_file_blocks): Likewise.
8181         * f-exp.y (%union) <bval>: Remove.
8182         * coffread.c (patch_opaque_types): Make "b" const.
8183         * spu-tdep.c (spu_catch_start): Make "block" const.
8184         * c-valprint.c (print_unpacked_pointer): Remove "block".
8185         * symmisc.c (dump_symtab_1): Make "b" const.
8186         (block_depth): Make "block" const.
8187         * d-exp.y (%union) <bval>: Remove.
8188         * cp-support.h (cp_lookup_rtti_type): Update.
8189         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8190         * psymtab.c (psym_lookup_symbol): Make "block" const.
8191         (maintenance_check_psymtabs): Make "b" const.
8192         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8193         (enumerate_locals, enumerate_args): Update.
8194         * python/py-symtab.c (stpy_global_block): Make "block" const.
8195         (stpy_static_block): Likewise.
8196         * inline-frame.c (block_starting_point_at): Make "new_block"
8197         const.
8198         * block.c (find_block_in_blockvector): Make return type const.
8199         (blockvector_for_pc_sect): Make "b" const.
8200         (find_block_in_blockvector): Make "b" const.
8201
8202 2019-03-23  Tom Tromey  <tom@tromey.com>
8203
8204         * varobj.c (varobj_create): Update.
8205         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8206         * printcmd.c (display_command, do_one_display): Don't reset
8207         innermost_block.
8208         * parser-defs.h (enum innermost_block_tracker_type): Move to
8209         expression.h.
8210         (innermost_block): Update comment.
8211         * parse.c (parse_exp_1): Add tracker_types parameter.
8212         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8213         tracker_types parameter.  Reset innermost_block.
8214         (parse_exp_in_context): Remove.
8215         (parse_expression_for_completion): Update.
8216         * objfiles.c (~objfile): Don't reset expression_context_block or
8217         innermost_block.
8218         * expression.h (enum innermost_block_tracker_type): Move from
8219         parser-defs.h.
8220         (parse_exp_1): Add tracker_types parameter.
8221         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8222         reset innermost_block.
8223
8224 2019-03-23  Tom Tromey  <tom@tromey.com>
8225
8226         * objfiles.h: Include bcache.h.
8227
8228 2019-03-23  Tom Tromey  <tom@tromey.com>
8229
8230         * linespec.c (get_current_search_block): Use
8231         scoped_restore_current_language.
8232         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8233
8234 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8235             Jiong Wang  <jiong.wang@arm.com>
8236
8237         * aarch64-linux-tdep.c
8238         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8239         section.
8240         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8241
8242 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8243             Jiong Wang  <jiong.wang@arm.com>
8244
8245         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8246         instructions.
8247         (aarch64_analyze_prologue_test): Add PACIASP test.
8248         (aarch64_prologue_prev_register): Unmask PC value.
8249
8250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8251             Jiong Wang  <jiong.wang@arm.com>
8252
8253         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8254         (aarch64_dwarf2_prev_register): Unmask PC value.
8255         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8256         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8257         DW_CFA_AARCH64_negate_ra_state.
8258         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8259
8260 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8261             Jiong Wang  <jiong.wang@arm.com>
8262
8263         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8264         registers.
8265         (aarch64_pseudo_register_name): Likewise.
8266         (aarch64_pseudo_register_type): Likewise.
8267         (aarch64_pseudo_register_reggroup_p): Likewise.
8268         (aarch64_gdbarch_init): Add pauth registers.
8269         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8270         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8271         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8272         (struct gdbarch_tdep): Add regnum for ra_state.
8273
8274 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8275             Jiong Wang  <jiong.wang@arm.com>
8276
8277         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8278
8279 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8280             Jiong Wang  <jiong.wang@arm.com>
8281
8282         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8283         function.
8284         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8285         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8286         (aarch64_gdbarch_init): Add puth registers.
8287         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8288         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8289         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8290
8291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8292             Jiong Wang  <jiong.wang@arm.com>
8293
8294         * aarch64-linux-nat.c
8295         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8296         * aarch64-linux-tdep.c
8297         (aarch64_linux_core_read_description): Likewise.
8298         (aarch64_linux_get_hwcap): New function.
8299         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8300         (aarch64_linux_get_hwcap): New declaration.
8301
8302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8303             Jiong Wang  <jiong.wang@arm.com>
8304
8305         * aarch64-linux-nat.c
8306         (aarch64_linux_nat_target::read_description): Add pauth param.
8307         * aarch64-linux-tdep.c
8308         (aarch64_linux_core_read_description): Likewise.
8309         * aarch64-tdep.c (struct target_desc): Add in pauth.
8310         (aarch64_read_description): Add pauth param.
8311         (aarch64_gdbarch_init): Likewise.
8312         * aarch64-tdep.h (aarch64_read_description): Likewise.
8313         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8314         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8315         * features/Makefile: Add new files.
8316         * features/aarch64-pauth.c: New file.
8317         * features/aarch64-pauth.xml: New file.
8318
8319 2019-03-20  Tom Tromey  <tromey@adacore.com>
8320
8321         * infrun.c (handle_inferior_event): Rename from
8322         handle_inferior_event_1.  Create a scoped_value_mark.
8323         (handle_inferior_event): Remove.
8324
8325 2019-03-19  Tom Tromey  <tromey@adacore.com>
8326
8327         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8328         * infrun.h (print_stop_event): Add "displays" parameter.
8329         * infrun.c (print_stop_event): Add "displays" parameter.
8330
8331 2019-03-19  Pedro Alves  <palves@redhat.com>
8332
8333         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8334         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8335         to -1.  Fix TABs vs spaces.
8336         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8337         * tui/tui-out.h (tui_ui_out) Add intro comments.
8338         <m_line, m_start_of_line>: In-class initialize, and add describing
8339         comment.
8340
8341 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8342
8343         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8344         variable names.
8345         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8346
8347 2019-03-18  Pedro Alves  <palves@redhat.com>
8348             Eli Zaretskii <eliz@gnu.org>
8349
8350         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8351         m_line and m_start_of_line.
8352
8353 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8354
8355         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8356         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8357         it returns a newline.  This fixes a regression in TU mode, whereby
8358         the next line is output on the same screen line as the user input.
8359
8360 2019-03-18  Tom Tromey  <tromey@adacore.com>
8361
8362         * minsyms.c (minimal_symbol_reader::install): Remove call to
8363         obstack_blank.
8364
8365 2019-03-18  Pedro Alves  <palves@redhat.com>
8366
8367         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8368         New globals.
8369         (apply_style): New, factored out from ...
8370         (apply_ansi_escape): ... this.  Handle reverse video mode.
8371         (tui_set_reverse_mode): New function.
8372         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8373         * tui/tui-winsource.c (tui_show_source_line): Use
8374         tui_set_reverse_mode instead of setting A_STANDOUT.
8375         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8376         New setter methods.
8377
8378 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8379
8380         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8381         Handle tabs.
8382
8383 2019-03-18  Tom Tromey  <tromey@adacore.com>
8384
8385         * ada-lang.c (empty_array): Add "high" parameter.
8386         (ada_evaluate_subexp): Update.
8387
8388 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8389
8390         * unittests/string_view-selftests.c: Define
8391         _initialize_string_view_selftests unconditionally.
8392
8393 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8394
8395         PR gdb/24350
8396         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8397
8398 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8399
8400         PR gdb/24351
8401         * windows-nat.c (display_selector): Fix format specifiers.
8402
8403 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8404
8405         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8406         tui_refill_source_window instead of tui_refresh_win, to update the
8407         current execution line.  This fixes redisplay of the current line
8408         when stepping through the code with "next" or "step".
8409
8410 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8411
8412         * source-cache.c (source_cache::get_source_lines): Call
8413         find_source_lines to initialize s->nlines.  This fixes vertical
8414         scrolling of TUI source window when the DOWN arrow is pressed.
8415
8416 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8417
8418         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8419         linux-thread-db.c (_initialize_thread_db): Likewise.
8420
8421 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8422
8423         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8424         wclrtoeol in tui_show_source_line".  This reverts changes made in
8425         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8426
8427 2019-03-15  Tom Tromey  <tom@tromey.com>
8428
8429         * symtab.h (struct minimal_symbol): Derive from
8430         general_symbol_info.
8431         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8432         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8433         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8434         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8435         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8436         (MSYMBOL_SEARCH_NAME): Update.
8437         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8438         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8439         * minsyms.c (minimal_symbol_reader::record_full): Update.
8440
8441 2019-03-15  Tom Tromey  <tom@tromey.com>
8442
8443         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8444
8445 2019-03-15  Tom Tromey  <tom@tromey.com>
8446
8447         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8448         unique_xmalloc_ptr.
8449         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8450         Update.
8451         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8452         (build_minimal_symbol_hash_tables)
8453         (minimal_symbol_reader::install): Update.
8454
8455 2019-03-15  Tom Tromey  <tom@tromey.com>
8456
8457         * symtab.c (create_demangled_names_hash): Update.
8458         (symbol_set_names): Update.
8459         * objfiles.h (struct objfile_per_bfd_storage)
8460         <demangled_names_hash>: Now an htab_up.
8461         * objfiles.c (objfile_per_bfd_storage): Simplify.
8462
8463 2019-03-15  Tom Tromey  <tom@tromey.com>
8464
8465         * objfiles.h (struct objfile_per_bfd_storage): Declare
8466         destructor.
8467         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8468         New.
8469         (get_objfile_bfd_data): Use new.  Don't initialize
8470         language_of_main.
8471         (free_objfile_per_bfd_storage): Remove.
8472         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8473
8474 2019-03-15  Tom Tromey  <tom@tromey.com>
8475
8476         * symfile.c (reread_symbols): Update.
8477         * objfiles.c (objfile::objfile): Update.
8478         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8479         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8480         comment.
8481         (minimal_symbol_reader::install): Update.
8482         (terminate_minimal_symbol_table): Remove.
8483         * jit.c (jit_object_close_impl): Update.
8484
8485 2019-03-15  Tom Tromey  <tom@tromey.com>
8486
8487         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8488         initializations.
8489
8490 2019-03-15  Tom Tromey  <tom@tromey.com>
8491
8492         * objfiles.h (struct objfile_per_bfd_storage)
8493         <demangled_hash_languages>: Now a bitset.
8494         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8495         (lookup_minimal_symbol): Update.
8496
8497 2019-03-15  Tom Tromey  <tom@tromey.com>
8498
8499         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8500         Don't return the symbol.
8501         * coffread.c (record_minimal_symbol): Use record_full.
8502
8503 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8504
8505         The MS-Windows port of ncurses fails to switch to a color pair if
8506         one or both of the colors are the implicit default colors.  This
8507         change records the default colors when TUI is initialized, and
8508         then specifies them explicitly when a color pair uses the default
8509         colors.  This allows color styling in TUI mode on MS-Windows.
8510
8511         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8512         ncurses_norm_attr.
8513         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8514         colors in ncurses_norm_attr.
8515         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8516         "none", replace it with the default color recorded in
8517         ncurses_norm_attr.
8518
8519 2019-03-14  Tom Tromey  <tromey@adacore.com>
8520
8521         * source-cache.h (class source_cache) <get_source_lines>: Return
8522         std::string.
8523         * source-cache.c (source_cache::extract_lines): Handle case where
8524         first_pos==npos.  Return std::string.
8525         (source_cache::get_source_lines): Update.
8526
8527 2019-03-14  Tom Tromey  <tromey@adacore.com>
8528
8529         * NEWS: Add item for "style sources" commands.
8530         * source-cache.c (source_cache::get_source_lines): Check
8531         source_styling.
8532         * cli/cli-style.c (source_styling): New global.
8533         (_initialize_cli_style): Add "style sources" commands.
8534         (show_style_sources): New function.
8535         * cli/cli-style.h (source_styling): Declare.
8536
8537 2019-03-14  Pedro Alves  <palves@redhat.com>
8538             Tom Tromey  <tromey@adacore.com>
8539
8540         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8541         * tui/tui-winsource.c (tui_refill_source_window): New function,
8542         from...
8543         (tui_horizontal_source_scroll): ... here.  Move some logic.
8544         * cli/cli-style.c (set_style_enabled): Notify new observable.
8545         * tui/tui-hooks.c (tui_redisplay_source): New function.
8546         (tui_attach_detach_observers): Attach or detach
8547         tui_redisplay_source.
8548         * observable.h (source_styling_changed): New observable.
8549         * observable.c: Define source_styling_changed observable.
8550
8551 2019-03-13  Tom Tromey  <tromey@adacore.com>
8552
8553         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8554         (i386_gnu_nat_target::store_registers): Update.
8555         * target-debug.h (target_debug_print_std_string): New macro.
8556         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8557         * windows-tdep.c (display_one_tib): Update.
8558         * tui/tui-stack.c (tui_make_status_line): Update.
8559         * top.c (print_inferior_quit_action): Update.
8560         * thread.c (thr_try_catch_cmd): Update.
8561         (add_thread_with_info): Update.
8562         (thread_target_id_str): Update.
8563         (thr_try_catch_cmd): Update.
8564         (thread_command): Update.
8565         (thread_find_command): Update.
8566         * record-btrace.c (record_btrace_target::info_record)
8567         (record_btrace_resume_thread, record_btrace_target::resume)
8568         (record_btrace_cancel_resume, record_btrace_step_thread)
8569         (record_btrace_target::wait, record_btrace_target::wait)
8570         (record_btrace_target::wait, record_btrace_target::stop): Update.
8571         * progspace.c (print_program_space): Update.
8572         * process-stratum-target.c
8573         (process_stratum_target::thread_address_space): Update.
8574         * linux-fork.c (linux_fork_mourn_inferior)
8575         (detach_checkpoint_command, info_checkpoints_command)
8576         (linux_fork_context): Update.
8577         (linux_fork_detach): Update.
8578         (class scoped_switch_fork_info): Update.
8579         (delete_checkpoint_command): Update.
8580         * infrun.c (follow_fork_inferior): Update.
8581         (follow_fork_inferior): Update.
8582         (proceed_after_vfork_done): Update.
8583         (handle_vfork_child_exec_or_exit): Update.
8584         (follow_exec): Update.
8585         (displaced_step_prepare_throw): Update.
8586         (displaced_step_restore): Update.
8587         (start_step_over): Update.
8588         (resume_1): Update.
8589         (clear_proceed_status_thread): Update.
8590         (proceed): Update.
8591         (print_target_wait_results): Update.
8592         (do_target_wait): Update.
8593         (context_switch): Update.
8594         (stop_all_threads): Update.
8595         (restart_threads): Update.
8596         (finish_step_over): Update.
8597         (handle_signal_stop): Update.
8598         (switch_back_to_stepped_thread): Update.
8599         (keep_going_pass_signal): Update.
8600         (print_exited_reason): Update.
8601         (normal_stop): Update.
8602         * inferior.c (inferior_pid_to_str): Change return type.
8603         (print_selected_inferior): Update.
8604         (add_inferior): Update.
8605         (detach_inferior): Update.
8606         * dummy-frame.c (fprint_dummy_frames): Update.
8607         * dcache.c (dcache_info_1): Update.
8608         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8609         (btrace_fetch, btrace_clear): Update.
8610         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8611         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8612         type.
8613         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8614         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8615         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8616         * gdbarch.c, gdbarch.h: Rebuild.
8617         * gdbarch.sh (core_pid_to_str): Change return type.
8618         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8619         return type.
8620         (windows_nat_target::pid_to_str): Change return type.
8621         (windows_delete_thread): Update.
8622         (windows_nat_target::attach): Update.
8623         (windows_nat_target::files_info): Update.
8624         * target-delegates.c: Rebuild.
8625         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8626         return type.
8627         (sol_thread_target::pid_to_str): Change return type.
8628         * remote.c (class remote_target) <pid_to_str>: Change return
8629         type.
8630         (remote_target::pid_to_str): Change return type.
8631         (extended_remote_target::attach, remote_target::remote_stop_ns)
8632         (remote_target::remote_notif_remove_queued_reply)
8633         (remote_target::push_stop_reply, remote_target::disable_btrace):
8634         Update.
8635         (extended_remote_target::attach): Update.
8636         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8637         type.
8638         (gdbsim_target::pid_to_str): Change return type.
8639         * ravenscar-thread.c (struct ravenscar_thread_target)
8640         <pid_to_str>: Change return type.
8641         (ravenscar_thread_target::pid_to_str): Change return type.
8642         * procfs.c (class procfs_target) <pid_to_str>: Change return
8643         type.
8644         (procfs_target::pid_to_str): Change return type.
8645         (procfs_target::attach): Update.
8646         (procfs_target::detach): Update.
8647         (procfs_target::fetch_registers): Update.
8648         (procfs_target::store_registers): Update.
8649         (procfs_target::wait): Update.
8650         (procfs_target::files_info): Update.
8651         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8652         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8653         return type.
8654         (nto_procfs_target::pid_to_str): Change return type.
8655         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8656         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8657         return type.
8658         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8659         (exit_lwp): Update.
8660         (attach_proc_task_lwp_callback, get_detach_signal)
8661         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8662         (linux_nat_target::resume, wait_lwp, stop_callback)
8663         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8664         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8665         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8666         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8667         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8668         type.
8669         (inf_ptrace_target::attach): Update.
8670         (inf_ptrace_target::files_info): Update.
8671         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8672         type.
8673         (go32_nat_target::pid_to_str): Change return type.
8674         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8675         (gnu_nat_target::wait): Update.
8676         (gnu_nat_target::wait): Update.
8677         (gnu_nat_target::resume): Update.
8678         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8679         (fbsd_nat_target::wait): Update.
8680         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8681         type.
8682         (darwin_nat_target::attach): Update.
8683         * corelow.c (class core_target) <pid_to_str>: Change return type.
8684         (core_target::pid_to_str): Change return type.
8685         * target.c (normal_pid_to_str): Change return type.
8686         (default_pid_to_str): Likewise.
8687         (target_pid_to_str): Change return type.
8688         (target_translate_tls_address): Update.
8689         (target_announce_detach): Update.
8690         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8691         return type.
8692         (bsd_uthread_target::pid_to_str): Change return type.
8693         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8694         type.
8695         (bsd_kvm_target::pid_to_str): Change return type.
8696         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8697         return type.
8698         (aix_thread_target::pid_to_str): Change return type.
8699         * target.h (struct target_ops) <pid_to_str>: Change return type.
8700         (target_pid_to_str, normal_pid_to_str): Likewise.
8701         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8702         type.
8703         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8704         type.
8705         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8706         return type.
8707         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8708         type.
8709         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8710         type.
8711         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8712         return type.
8713
8714 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8715
8716         * NEWS: Mention that the new default MI version is 3.  Mention
8717         changes to the output of commands and events that deal with
8718         multi-location breakpoints.
8719         * breakpoint.c: Include "mi/mi-out.h".
8720         (print_one_breakpoint): Change output syntax if using MI version
8721         >= 3.
8722         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8723         New.
8724         (mi_multi_location_breakpoint_output_fixed): New.
8725         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8726         (mi_cmd_fix_multi_location_breakpoint_output): New.
8727         (mi_multi_location_breakpoint_output_fixed): New.
8728         * mi/mi-cmds.c (mi_cmds): Register command
8729         -fix-multi-location-breakpoint-output.
8730         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8731         interpreter "mi".
8732
8733 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8734
8735         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8736         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8737         instantiate mi_ui_out based on interpreter name.
8738         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8739         * mi/mi-main.c (mi_load_progress): Likewise.
8740
8741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8742
8743         * NEWS: Combine separate "New targets" sections for 8.3.
8744
8745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8746
8747         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8748         (ppcfbsd_init_abi): Install gdbarch
8749         "fetch_tls_load_module_address" and "get_thread_local_address"
8750         methods.
8751
8752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8753
8754         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8755         (riscv_fbsd_init_abi): Install gdbarch
8756         "fetch_tls_load_module_address" and "get_thread_local_address"
8757         methods.
8758
8759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8760
8761         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8762         (i386fbsd_init_abi): Install gdbarch
8763         "fetch_tls_load_module_address" and "get_thread_local_address"
8764         methods.
8765
8766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8767
8768         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8769         (amd64fbsd_init_abi): Install gdbarch
8770         "fetch_tls_load_module_address" and "get_thread_local_address"
8771         methods.
8772
8773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8774
8775         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8776         (struct fbsd_pspace_data): New type.
8777         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8778         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8779         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8780         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8781         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8782
8783 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8784
8785         * gdbtypes.c (lookup_struct_elt): New function.
8786         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8787         * gdbtypes.h (struct struct_elt): New type.
8788         (lookup_struct_elt): New prototype.
8789
8790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8791
8792         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8793         remove disabled code block.
8794
8795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8796
8797         * gdbarch.sh (get_thread_local_address): New method.
8798         * gdbarch.h, gdbarch.c: Regenerate.
8799         * target.c (target_translate_tls_address): Use
8800         gdbarch_get_thread_local_address if present instead of
8801         target::get_thread_local_address.
8802
8803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8804
8805         * target.h (target::get_thread_local_address): Update comment.
8806
8807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8808
8809         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8810         objfile->separate_debug_objfile_backlink if not NULL.
8811
8812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8813
8814         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8815         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8816         (amd64bsd_store_inferior_registers): Likewise.
8817         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8818         Enable segment base registers.
8819         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8820         PT_GETFSBASE and PT_GETGSBASE.
8821         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8822         PT_SETGSBASE.
8823         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8824         segment base registers.
8825         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8826
8827 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8828
8829         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8830         Update calls to i386_target_description to add 'segments'
8831         parameter.
8832         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8833         add segment base registers.
8834         * arch/i386.c (i386_create_target_description): Add 'segments'
8835         parameter to enable segment base registers.
8836         * arch/i386.h (i386_create_target_description): Likewise.
8837         * features/i386/32bit-segments.xml: New file.
8838         * features/i386/32bit-segments.c: Generate.
8839         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8840         call to i386_target_description to add 'segments' parameter.
8841         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8842         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8843         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8844         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8845         if feature is present.
8846         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8847         Add 'segments' parameter to call to i386_target_description.
8848         (i386_target_description): Add 'segments' parameter to enable
8849         segment base registers.
8850         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8851         to call to i386_target_description.
8852         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8853         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8854         Define I386_NUM_REGS.
8855         (i386_target_description): Add 'segments' parameter to enable
8856         segment base registers.
8857
8858 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8859
8860         PR/24325
8861         * source-cache.c: #undef open and close, to avoid unresolved
8862         externals during linking.
8863
8864 2019-03-12  Tom Tromey  <tromey@adacore.com>
8865
8866         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8867         const.  Add initializers.
8868         (_initialize_remote): Don't initialize ptid globals.
8869
8870 2019-03-12  Pedro Alves  <palves@redhat.com>
8871
8872         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8873
8874 2019-03-12  Pedro Alves  <palves@redhat.com>
8875
8876         * cp-name-parser.y (main): Remove unused 'len' variable.
8877
8878 2019-03-12  Tom Tromey  <tromey@adacore.com>
8879
8880         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8881         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8882
8883 2019-03-12  Tom Tromey  <tromey@adacore.com>
8884
8885         * linux-nat.c (iterate_over_lwps): Update.
8886         (stop_callback): Remove parameter.
8887         (stop_wait_callback, detach_callback, resume_set_callback)
8888         (select_singlestep_lwp_callback, set_ignore_sigint)
8889         (status_callback, resumed_callback, resume_clear_callback)
8890         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8891         data parameter.
8892         (linux_nat_target::detach, linux_nat_target::resume)
8893         (linux_stop_and_wait_all_lwps, select_event_lwp)
8894         (linux_nat_filter_event, linux_nat_wait_1)
8895         (linux_nat_target::kill, linux_nat_target::stop)
8896         (linux_nat_target::stop): Update.
8897         (linux_nat_resume_callback): Change type.
8898         (resume_stopped_resumed_lwps, count_events_callback)
8899         (select_event_lwp_callback): Likewise.
8900         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8901         * arm-linux-nat.c (struct update_registers_data): Remove.
8902         (update_registers_callback): Change type.
8903         (arm_linux_insert_hw_breakpoint1): Update.
8904         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8905         parameter.
8906         (x86_linux_dr_set_addr): Update.
8907         (x86_linux_dr_set_control): Update.
8908         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8909         (iterate_over_lwps): Use gdb::function_view.
8910         * nat/aarch64-linux-hw-point.c (struct
8911         aarch64_dr_update_callback_param): Remove.
8912         (debug_reg_change_callback): Change type.
8913         (aarch64_notify_debug_reg_change): Update.
8914         * s390-linux-nat.c (s390_refresh_per_info): Update.
8915
8916 2019-03-11  Tom Tromey  <tromey@adacore.com>
8917
8918         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8919         redundant assignment to "this_cu".
8920
8921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8922
8923         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8924
8925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8926
8927         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8928         from...
8929         (rank_one_type): ... this.
8930
8931 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8932
8933         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8934         from...
8935         (rank_one_type): ... this.
8936
8937 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8938
8939         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8940         from...
8941         (rank_one_type): ... this.
8942
8943 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8944
8945         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8946         from...
8947         (rank_one_type): ... this.
8948
8949 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8950
8951         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8952         from...
8953         (rank_one_type): ... this.
8954
8955 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8956
8957         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8958         from...
8959         (rank_one_type): ... this.
8960
8961 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8962
8963         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8964         from...
8965         (rank_one_type): ... this.
8966
8967 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8968
8969         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8970         from...
8971         (rank_one_type): ... this.
8972
8973 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8974
8975         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8976         from...
8977         (rank_one_type): ... this.
8978
8979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8980
8981         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8982         from...
8983         (rank_one_type): ... this.
8984
8985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8986
8987         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8988         from...
8989         (rank_one_type): ... this.
8990
8991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8992
8993         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8994         from...
8995         (rank_one_type): ... this.
8996
8997 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8998
8999         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9000         inferior-events' shows the example events.
9001
9002 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9003
9004         Support styling on native MS-Windows console
9005
9006         PR/24315
9007         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9008         on MS-Windows if $TERM is not defined.
9009
9010         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9011
9012         * posix-hdep.c (gdb_console_fputs):
9013         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9014         functions.
9015         * ui-file.h (gdb_console_fputs): Add prototype.
9016
9017         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9018         back to fputs only if the former returns zero.
9019
9020 2019-03-07  Tom Tromey  <tom@tromey.com>
9021
9022         * symmisc.c (print_symbol_bcache_statistics): Update.
9023         (print_objfile_statistics): Update.
9024         * symfile.c (allocate_symtab): Update.
9025         * stabsread.c: Don't include bcache.h.
9026         * psymtab.h (struct psymbol_bcache): Don't declare.
9027         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9028         (psymbol_bcache_init, psymbol_bcache_free)
9029         (psymbol_bcache_get_bcache): Don't declare.
9030         * psymtab.c (struct psymbol_bcache): Remove.
9031         (psymtab_storage::psymtab_storage): Update.
9032         (psymtab_storage::~psymtab_storage): Update.
9033         (psymbol_bcache_init, psymbol_bcache_free)
9034         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9035         (add_psymbol_to_bcache): Update.
9036         (allocate_psymtab): Update.
9037         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9038         macro_cache>: No longer pointers.
9039         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9040         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9041         * macrotab.c (macro_bcache): Update.
9042         * macroexp.c: Don't include bcache.h.
9043         * gdbtypes.c (check_types_worklist): Update.
9044         (types_deeply_equal): Remove TRY/CATCH.  Update.
9045         * elfread.c (elf_symtab_read): Update.
9046         * dwarf2read.c: Don't include bcache.h.
9047         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9048         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9049         (print_bcache_statistics, bcache_memory_used): Don't declare.
9050         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9051         methods.  Rename all data members.
9052         * bcache.c (struct bcache): Move to bcache.h.
9053         (bcache::expand_hash_table): Rename from expand_hash_table.
9054         (bcache): Remove.
9055         (bcache::insert): Rename from bcache_full.
9056         (bcache::compare): Rename from bcache_compare.
9057         (bcache_xmalloc): Remove.
9058         (bcache::~bcache): Rename from bcache_xfree.
9059         (bcache::print_statistics): Rename from print_bcache_statistics.
9060         (bcache::memory_used): Rename from bcache_memory_used.
9061
9062 2019-03-07  Pedro Alves  <palves@redhat.com>
9063
9064         * infrun.c (normal_stop): Also check for
9065         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9066
9067 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * f-lang.c (value_from_host_double): Moved to...
9070         * value.c (value_from_host_double): ...here.
9071         * value.h (value_from_host_double): Declare.
9072         * guile/scm-math.c (vlscm_convert_typed_number): Use
9073         value_from_host_double.
9074         (vlscm_convert_number): Likewise.
9075         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9076         * python/py-value.c (convert_value_from_python): Likewise.
9077
9078 2019-03-06  Tom Tromey  <tom@tromey.com>
9079
9080         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9081
9082 2019-03-06  Tom Tromey  <tom@tromey.com>
9083
9084         * utils.h (free_current_contents): Don't declare.
9085         * utils.c (free_current_contents): Remove.
9086
9087 2019-03-06  Tom Tromey  <tom@tromey.com>
9088
9089         * top.c (quit_force): Update.
9090         * main.c (captured_command_loop): Update.
9091         * common/new-op.c (operator new): Update.
9092         * common/common-exceptions.c (struct catcher)
9093         <save_cleanup_chain>: Remove member.
9094         (exceptions_state_mc_init): Update.
9095         (exception_try_scope_entry): Return nullptr.
9096         (exception_try_scope_exit, exception_rethrow)
9097         (throw_exception_sjlj, throw_exception_cxx): Update.
9098         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9099         (all_cleanups, do_cleanups, discard_cleanups)
9100         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9101         (restore_cleanups, restore_final_cleanups): Don't declare.
9102         (do_final_cleanups): Remove parameter.
9103         * common/cleanups.c (cleanup_chain, make_cleanup)
9104         (make_cleanup_dtor, all_cleanups, do_cleanups)
9105         (discard_my_cleanups, discard_cleanups)
9106         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9107         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9108         (null_cleanup): Remove.
9109         (do_final_cleanups): Remove parameter.
9110
9111 2019-03-06  Tom Tromey  <tom@tromey.com>
9112
9113         * remote.c (remote_target::remote_parse_stop_reply): Use
9114         unique_xmalloc_ptr.
9115
9116 2019-03-06  Tom Tromey  <tom@tromey.com>
9117
9118         * stabsread.c (struct stabs_field_info): Rename from field_info.
9119         <list, fnlist>: Add initializers.
9120         <obstack>: New member.
9121         (read_member_functions, read_struct_fields, read_baseclasses):
9122         Allocate on obstack.  Don't use cleanups.
9123         (read_one_struct_field, read_member_functions, read_struct_fields)
9124         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9125         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9126         (read_struct_type): Update.
9127
9128 2019-03-06  Tom Tromey  <tom@tromey.com>
9129
9130         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9131         * common/filestuff.h (make_cleanup_close): Don't declare.
9132         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9133         Remove.
9134
9135 2019-03-06  Tom Tromey  <tom@tromey.com>
9136
9137         * solib-aix.c: Use make_scope_exit.
9138
9139 2019-03-06  Tom Tromey  <tom@tromey.com>
9140
9141         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9142         Use make_scope_exit.
9143
9144 2019-03-06  Tom Tromey  <tom@tromey.com>
9145
9146         * solib-svr4.c (disable_probes_interface): Remove parameter.
9147         (svr4_handle_solib_event): Use make_scope_exit.
9148
9149 2019-03-06  Tom Tromey  <tom@tromey.com>
9150
9151         * remote.c (struct stop_reply_deleter): Remove.
9152         (stop_reply_up): Update.
9153         (struct stop_reply): Derive from notif_event.  Don't typedef.
9154         <regcache>: Now a std::vector.
9155         (stop_reply_xfree): Remove.
9156         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9157         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9158         (remote_target::discard_pending_stop_replies): Use delete.
9159         (remote_target::remote_parse_stop_reply): Update.
9160         (remote_target::process_stop_reply): Update.
9161         * remote-notif.h (struct notif_event): Add virtual destructor.
9162         Remove "dtr" member.
9163         (struct notif_client) <alloc_event>: Return a unique_ptr.
9164         (notif_event_xfree): Don't declare.
9165         (notif_event_up): New typedef.
9166         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9167         (notif_event_xfree, do_notif_event_xfree): Remove.
9168         (remote_notif_state_xfree): Update.
9169
9170 2019-03-06  Tom Tromey  <tom@tromey.com>
9171
9172         * infrun.c (displaced_step_clear_cleanup): Now a
9173         forward_scope_exit type.
9174         (displaced_step_prepare_throw): Update.
9175         (displaced_step_fixup): Update.
9176
9177 2019-03-06  Tom Tromey  <tom@tromey.com>
9178
9179         * inferior.h (class inferior): Update comment.
9180         * gdbthread.h (class thread_info): Update comment.
9181
9182 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9183             Tom Tromey  <tom@tromey.com>
9184
9185         * stabsread.h (struct stab_section_list): Remove.
9186         (coffstab_build_psymtabs): Update.
9187         * dbxread.c (symbuf_sections): Now a std::vector.
9188         (sect_idx): New global.
9189         (fill_symbuf): Update.
9190         (coffstab_build_psymtabs): Change type of stabsects parameter.
9191         Update.
9192         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9193         std::vector.
9194         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9195         (coff_locate_sections): Update.
9196         (coff_symfile_read): Remove cleanups.  Update.
9197         (init_stringtab): Add storage parameter.
9198         (free_stringtab, free_stringtab_cleanup): Remove.
9199         (init_lineno): Add storage parameter.
9200         (free_linetab, free_linetab_cleanup): Remove.
9201
9202 2019-03-06  Pedro Alves  <palves@redhat.com>
9203
9204         * linux-fork.c (fork_info::clobber_regs): Delete.
9205         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9206         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9207         comment.  Adjust.
9208         (scoped_switch_fork_info::scoped_switch_fork_info)
9209         (checkpoint_command, linux_fork_context): Adjust
9210         fork_save_infrun_state calls.
9211
9212 2019-03-06  Pedro Alves  <palves@redhat.com>
9213
9214         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9215         (inf_has_multiple_threads): Return 'bool' and rewrite using
9216         inferior_info::threads().
9217
9218 2019-03-06  Pedro Alves  <palves@redhat.com>
9219
9220         * linux-fork.c: Include <list>.
9221         (fork_list): Now a std::list instance.
9222         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9223         (forks_exist_p, find_last_fork): Adjust.
9224         (new_fork): Delete.
9225         (one_fork_p): New.
9226         (add_fork): Adjust.
9227         (free_fork): Delete, folded into fork_info::~fork_info().
9228         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9229         Adjust.
9230         (init_fork_list): Delete.
9231         (linux_fork_killall, linux_fork_mourn_inferior)
9232         (linux_fork_detach, info_checkpoints_command): Adjust.
9233         (_initialize_linux_fork): No longer call init_fork_list.
9234
9235 2019-03-06  Pedro Alves  <palves@redhat.com>
9236
9237         * linux-fork.c (new_fork): New, split out of ...
9238         (add_fork): ... this.  Return void.  Move "first fork" special
9239         case from here, to ...
9240         (checkpoint_command): ... here.
9241         * linux-linux.h (add_fork): Return void.
9242
9243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9246
9247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9248             Chris January  <chris.january@arm.com>
9249             David Lecomber  <david.lecomber@arm.com>
9250
9251         * f-exp.y: New token, UNOP_INTRINSIC.
9252         (exp): New pattern using UNOP_INTRINSIC token.
9253         (f77_keywords): Add 'abs' keyword.
9254         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9255         (value_from_host_double): New function.
9256         (evaluate_subexp_f): Support UNOP_ABS.
9257
9258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9259
9260         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9261         types.
9262
9263 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9266         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9267         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9268
9269 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9272
9273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9274             Chris January  <chris.january@arm.com>
9275
9276         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9277         * f-exp.y: Define 'KIND' token.
9278         (exp): New pattern for KIND expressions.
9279         (ptype): Handle types with a kind extension.
9280         (direct_abs_decl): Extend to spot kind extensions.
9281         (f77_keywords): Add 'kind' to the list.
9282         (push_kind_type): New function.
9283         (convert_to_kind_type): New function.
9284         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9285         * parse.c (operator_length_standard): Likewise.
9286         * parser-defs.h (enum type_pieces): Add tp_kind.
9287         * std-operator.def: Add UNOP_KIND.
9288
9289 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * f-exp.y (f_parse): Set yydebug.
9292
9293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9294
9295         * f-lang.c (evaluate_subexp_f): New function.
9296         (exp_descriptor_f): New global.
9297         (f_language_defn): Use exp_descriptor_f instead of
9298         exp_descriptor_standard.
9299
9300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9301
9302         * f-exp.y (struct token): Add comments.
9303         (dot_ops): Remove uppercase versions and the end marker.
9304         (f77_keywords): Likewise.
9305         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9306         entries in the dot_ops array are case insensitive, and use
9307         strncasecmp to compare strings.  Also some whitespace cleanup in
9308         this area.  Similar for the f77_keywords array, except entries in
9309         this list might be case sensitive.
9310
9311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9312
9313         * f-exp.y (struct f77_boolean_val): Add comments.
9314         (boolean_values): Remove uppercase versions, and end marker.
9315         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9316         and use strncasecmp to achieve case insensitivity.  Additionally,
9317         perform whitespace cleanup around this code.
9318
9319 2019-03-06  Tom Tromey  <tromey@adacore.com>
9320
9321         * remote-sim.c (gdbsim_target_open): Use result of
9322         gdb_argv::release.
9323
9324 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9325         Dirk Schubert  <dirk.schubert@arm.com>
9326         Chris January  <chris.january@arm.com>
9327
9328         * eval.c (evaluate_subexp_standard): Call Fortran argument
9329         wrapping logic.
9330         * f-lang.c (struct value): A value which can be passed into a
9331         Fortran function call.
9332         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9333         where appropriate.
9334         (struct type): Value ready for a Fortran function call.
9335         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9336         is needed.
9337         * f-lang.h (fortran_argument_convert): Declaration.
9338         (fortran_preserve_arg_pointer): Declaration.
9339         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9340
9341 2019-03-05  Tom Tromey  <tromey@adacore.com>
9342
9343         * python/py-prettyprint.c (print_string_repr): Remove #if.
9344         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9345
9346 2019-03-05  Tom Tromey  <tromey@adacore.com>
9347
9348         * target.c (the_dummy_target): Move later.  Change type to
9349         "dummy_target".
9350         (initialize_targets): Don't initialize the_dummy_target.
9351
9352 2019-03-05  Tom Tromey  <tromey@adacore.com>
9353
9354         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9355         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9356
9357 2019-03-05  Tom Tromey  <tromey@adacore.com>
9358
9359         * windows-nat.c (windows_nat_target::attach)
9360         (windows_nat_target::detach): Don't call gdb_flush.
9361         * valprint.c (generic_val_print, val_print, val_print_string):
9362         Don't call gdb_flush.
9363         * utils.c (defaulted_query): Don't call gdb_flush.
9364         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9365         * target.c (target_announce_detach): Don't call gdb_flush.
9366         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9367         * remote.c (extended_remote_target::attach): Don't call
9368         gdb_flush.
9369         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9370         * printcmd.c (do_examine): Don't call gdb_flush.
9371         (info_display_command): Don't call gdb_flush.
9372         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9373         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9374         * memattr.c (info_mem_command): Don't call gdb_flush.
9375         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9376         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9377         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9378         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9379         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9380         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9381         (gnu_nat_target::detach): Don't call gdb_flush.
9382         * f-valprint.c (f_val_print): Don't call gdb_flush.
9383         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9384         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9385         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9386         gdb_flush.
9387         * c-valprint.c (c_val_print): Don't call gdb_flush.
9388         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9389
9390 2019-03-05  Tom Tromey  <tromey@adacore.com>
9391
9392         * varobj.c (update_dynamic_varobj_children): Update.
9393         (install_default_visualizer): Use reset, not release.
9394         * value.c (set_internalvar): Update.
9395         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9396         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9397         ATTRIBUTE_UNUSED_RESULT.
9398
9399 2019-03-05  Tom Tromey  <tromey@adacore.com>
9400
9401         * remote.c (class scoped_remote_fd) <release>: Add
9402         ATTRIBUTE_UNUSED_RESULT.
9403
9404 2019-03-05  Tom Tromey  <tromey@adacore.com>
9405
9406         * macroexp.c (struct macro_buffer) <release>: Add
9407         ATTRIBUTE_UNUSED_RESULT.
9408
9409 2019-03-05  Tom Tromey  <tromey@adacore.com>
9410
9411         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9412         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9413         ATTRIBUTE_UNUSED_RESULT.
9414
9415 2019-03-05  Tom Tromey  <tromey@adacore.com>
9416
9417         * common/scoped_fd.h (class scoped_fd) <release>: Add
9418         ATTRIBUTE_UNUSED_RESULT.
9419
9420 2019-03-05  Tom Tromey  <tromey@adacore.com>
9421
9422         * parser-defs.h (struct parser_state) <release>: Add
9423         ATTRIBUTE_UNUSED_RESULT.
9424
9425 2019-03-05  Tom Tromey  <tromey@adacore.com>
9426
9427         * utils.h (class gdb_argv) <release>: Add
9428         ATTRIBUTE_UNUSED_RESULT.
9429         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9430
9431 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9432
9433         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9434         for-loop range, to avoid compiler warnings.
9435
9436         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9437         avoid compiler warnings about unused variables.
9438
9439         * NEWS: Mention end of support for native debugging on MS-Windows
9440         before XP.
9441
9442         PR gdb/24292
9443         * common/netstuff.c:
9444         * gdbserver/gdbreplay.c
9445         * gdbserver/remote-utils.c:
9446         * ser-tcp.c:
9447         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9448         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9449         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9450         'getaddrinfo' and 'freeaddrinfo' were not available before
9451         Windows XP, and mingw.org's MinGW headers by default define
9452         _WIN32_WINNT to 0x500.
9453
9454 2019-03-01  Gary Benson <gbenson@redhat.com>
9455
9456         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9457
9458 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9459             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9460
9461         PR gdb/8527
9462         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9463         set_sigint_trap, clear_sigint_trap.
9464
9465 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9466
9467         * target.c (target_detach): Clear the regcache and the
9468         frame cache.
9469
9470 2019-02-27  Pedro Alves  <palves@redhat.com>
9471
9472         * utils.c (set_screen_size): When we cap the height/width sizes,
9473         tweak the corresponding command variable to show "unlimited":
9474
9475 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9476             Pedro Alves  <palves@redhat.com>
9477
9478         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9479         before calling rl_set_screen_size.
9480
9481 2019-02-27  Tom Tromey  <tromey@adacore.com>
9482
9483         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9484         define.
9485         * python/py-value.c: Remove Python 2.4 workaround.
9486         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9487         workaround.
9488         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9489         Python 2.4 workaround.
9490         * python/python-internal.h: Remove Python 2.4 comment.
9491         (Py_ssize_t): Don't define.
9492         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9493         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9494         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9495         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9496         * python/python.c (do_start_initialization): Remove Python 2.4
9497         workaround.
9498         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9499         (print_children): Remove Python 2.4 workaround.
9500         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9501         workaround.
9502         (CHARBUFFERPROC_NAME): Remove.
9503         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9504         Python 2.4 workaround.
9505
9506 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9507
9508         * NEWS: Note minimum Python version.
9509
9510 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9511
9512         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9513         code from these functions.  Remove corresponding ifdefs.  Use
9514         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9515         Remove gotos and target of gotos.
9516         (infpy_search_memory): Likewise.
9517
9518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9519
9520         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9521         (hppa_gdbarch_init): Don't register deleted functions with
9522         gdbarch.
9523
9524 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9525
9526         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9527         (h8300_unwind_sp): Delete.
9528         (h8300_dummy_id): Delete.
9529         (h8300_gdbarch_init): Don't register deleted functions with
9530         gdbarch.
9531
9532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9533
9534         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9535         (ft32_unwind_pc): Delete.
9536         (ft32_unwind_sp): Delete.
9537         (ft32_gdbarch_init): Don't register deleted functions with
9538         gdbarch.
9539
9540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9541
9542         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9543         (frv_unwind_pc): Delete.
9544         (frv_unwind_sp): Delete.
9545         (frv_gdbarch_init): Don't register deleted functions with
9546         gdbarch.
9547
9548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9549
9550         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9551         (riscv_unwind_pc): Delete.
9552         (riscv_unwind_sp): Delete.
9553         (riscv_gdbarch_init): Don't register deleted functions with
9554         gdbarch.
9555
9556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9557
9558         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9559         (csky_unwind_pc): Delete.
9560         (csky_unwind_sp): Delete.
9561         (csky_gdbarch_init): Don't register deleted functions with
9562         gdbarch.
9563
9564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9565
9566         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9567         (cris_unwind_pc): Delete.
9568         (cris_unwind_sp): Delete.
9569         (cris_gdbarch_init): Don't register deleted functions with
9570         gdbarch.
9571
9572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9573
9574         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9575         (bfin_unwind_pc): Delete.
9576         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9577
9578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9579
9580         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9581         (arm_unwind_pc): Delete.
9582         (arm_unwind_sp): Delete.
9583         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9584
9585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9586
9587         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9588         (arc_unwind_pc): Delete.
9589         (arc_unwind_sp): Delete.
9590         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9591
9592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9593
9594         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9595         (alpha_unwind_pc): Delete.
9596         (alpha_gdbarch_init): Don't register deleted functions with
9597         gdbarch.
9598
9599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9600
9601         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9602         (aarch64_unwind_pc): Delete.
9603         (aarch64_unwind_sp): Delete.
9604         (aarch64_gdbarch_init): Don't register deleted functions with
9605         gdbarch.
9606
9607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9608
9609         * gdbtypes.c (type_align): Don't consider static members when
9610         computing structure alignment.
9611
9612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9613
9614         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9615         return 0 for other types.
9616         * arch-utils.c (default_type_align): Always return 0.
9617         * gdbarch.h: Regenerate.
9618         * gdbarch.sh (type_align): Extend comment.
9619         * gdbtypes.c (type_align): Add additional comments, always call
9620         gdbarch_type_align before applying the default rules.
9621         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9622         generic code will then apply a suitable default.
9623         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9624         types, return 0 for other types.
9625
9626 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9627
9628         * NEWS: Create a new section for the next release branch.
9629         Rename the section of the current branch, now that it has
9630         been cut.
9631
9632 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9633
9634         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9635         * version.in: Bump version to 8.3.50.DATE-git.
9636
9637 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9638
9639         * aix-thread.c (ptid_cmp): Remove unused variable.
9640         (get_signaled_thread): Likewise.
9641         (store_regs_user_thread): Likewise.
9642         (store_regs_kernel_thread): Likewise.
9643         (fetch_regs_kernel_thread): Remove shadowed variable.
9644
9645 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9646
9647         * features/riscv/32bit-cpu.xml: Add register numbers.
9648         * features/riscv/32bit-fpu.c: Regenerate.
9649         * features/riscv/32bit-fpu.xml: Add register numbers.
9650         * features/riscv/64bit-cpu.xml: Add register numbers.
9651         * features/riscv/64bit-fpu.c: Regenerate.
9652         * features/riscv/64bit-fpu.xml: Add register numbers.
9653
9654 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9655
9656         * NEWS: Mention two argument form of gdb.Value constructor.
9657         * python/py-value.c (convert_buffer_and_type_to_value): New
9658         function.
9659         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9660         Add support for handling an optional second argument.  Call
9661         convert_buffer_and_type_to_value as appropriate.
9662         * python/python-internal.h (Py_buffer_deleter): New struct.
9663         (Py_buffer_up): New typedef.
9664
9665 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9666
9667         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9668         instead of releasing ownership.
9669
9670 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9671
9672         * dwarf2read.c (open_and_init_dwp_file): Call
9673         elf_numsections instead of bfd_count_sections to initialize
9674         dwp_file->num_sections.
9675
9676 2019-02-25  Tom Tromey  <tromey@adacore.com>
9677
9678         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9679
9680 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9681
9682         * gcore.in: Add '--readnever' option when invoking GDB.
9683
9684 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9685
9686         * MAINTAINERS: Update my email address.
9687
9688 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9689
9690         * build-id.c (build_id_to_debug_bfd_1): New function.
9691         (build_id_to_debug_bfd): Look for separate debug file in
9692         sysroot.
9693
9694 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9695
9696         * gdbarch.sh: Update the copyright year range that is placed into
9697         generated files.
9698
9699 2019-02-22  Keith Seitz  <keiths@redhat.com>
9700
9701         PR symtab/23853
9702         * linespec.c (create_sals_line_offset): Search for the default
9703         symtab's filename instead of its fullname.
9704
9705 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9706
9707         * NEWS: Update style defaults.
9708
9709 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9710
9711         * main.c (captured_main_1): Disable styling in batch mode.
9712
9713 2019-02-20  Tom Tromey  <tom@tromey.com>
9714
9715         * symtab.c (symtab_symbol_info): Fix typos.
9716
9717 2019-02-20  Tom Tromey  <tromey@adacore.com>
9718
9719         * findcmd.c (_initialize_mem_search): Use upper case for
9720         metasyntactic variables.
9721
9722 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9723
9724         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9725         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9726
9727 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9728
9729         * top.h (source_file_name): Change to std::string.
9730         * top.c (source_file_name): Likewise.
9731         (command_line_input): Adjust.
9732         * cli/cli-script.c (script_from_file): Adjust.
9733
9734 2019-02-19  Tom Tromey  <tromey@adacore.com>
9735
9736         * ravenscar-thread.c
9737         (ravenscar_thread_target::update_thread_list): Don't call
9738         ada_build_task_list.
9739         * ada-lang.h (ada_build_task_list): Don't declare.
9740         * ada-tasks.c (struct ada_tasks_inferior_data)
9741         <task_list_valid_p>: Now bool.
9742         (read_known_tasks, ada_task_list_changed)
9743         (ada_tasks_invalidate_inferior_data): Update.
9744         (read_known_tasks_array): Return bool.
9745         (read_known_tasks_list): Likewise.
9746         (read_known_tasks): Return void.
9747         (ada_build_task_list): Now static.
9748
9749 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9750
9751         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9752         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9753
9754 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9755
9756         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9757         variant for ada_tasks_pspace_data_handle and
9758         ada_tasks_inferior_data_handle.
9759         (ada_tasks_pspace_data_cleanup): New function.
9760         (ada_tasks_inferior_data_cleanup): New function.
9761
9762 2019-02-17  Tom Tromey  <tom@tromey.com>
9763
9764         * macrotab.h (macro_source_fullname): Return a std::string.
9765         * macrotab.c (macro_include, check_for_redefinition)
9766         (macro_undef, macro_lookup_definition, foreach_macro)
9767         (foreach_macro_in_scope): Update.
9768         (macro_source_fullname): Return a std::string.
9769         * macrocmd.c (show_pp_source_pos): Update.
9770
9771 2019-02-17  Tom Tromey  <tom@tromey.com>
9772
9773         * macrocmd.c (show_pp_source_pos): Style the file names.
9774
9775 2019-02-17  Tom Tromey  <tom@tromey.com>
9776
9777         PR tui/24197:
9778         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9779
9780 2019-02-17  Tom Tromey  <tom@tromey.com>
9781
9782         * ada-lang.c (user_select_syms): Use filtered printing.
9783         * utils.c (wrap_style): New global.
9784         (desired_style): Remove.
9785         (emit_style_escape): Add stream parameter.
9786         (set_output_style, reset_terminal_style, prompt_for_continue):
9787         Update.
9788         (flush_wrap_buffer): Only flush gdb_stdout.
9789         (wrap_here): Set wrap_style.
9790         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9791         treat escape sequences as a character.  Change when wrap buffer is
9792         flushed.
9793         (fputs_styled): Do not set the output style when the default is
9794         requested.
9795         * ui-style.h (struct ui_file_style) <is_default>: New method.
9796         * source.c (print_source_lines_base): Emit escape sequences in one
9797         piece.
9798
9799 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9800
9801         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9802         integers and enumeration types.
9803
9804 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9805
9806         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9807         instead of lookup_symbol_in_language
9808         (do_exact_match): New function.
9809         (ada_get_symbol_name_matcher): Return do_exact_match when
9810         doing a verbatim match.
9811
9812 2019-02-15  Tom Tromey  <tromey@adacore.com>
9813
9814         * ravenscar-thread.c (ravenscar_thread_target::resume)
9815         (ravenscar_thread_target::wait): Special case wildcard requests.
9816
9817 2019-02-15  Tom Tromey  <tromey@adacore.com>
9818
9819         * ravenscar-thread.c (base_ptid): Remove.
9820         (struct ravenscar_thread_target) <close>: New method.
9821         <m_base_ptid>: New member.
9822         <update_inferior_ptid, active_task, task_is_currently_active,
9823         runtime_initialized>: Declare methods.
9824         <ravenscar_thread_target>: Add constructor.
9825         (ravenscar_thread_target::task_is_currently_active)
9826         (ravenscar_thread_target::update_inferior_ptid)
9827         (ravenscar_runtime_initialized): Rename.  Now methods.
9828         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9829         (ravenscar_thread_target::update_thread_list): Update.
9830         (ravenscar_thread_target::active_task): Now method.
9831         (ravenscar_thread_target::store_registers)
9832         (ravenscar_thread_target::prepare_to_store)
9833         (ravenscar_thread_target::prepare_to_store)
9834         (ravenscar_thread_target::mourn_inferior): Update.
9835         (ravenscar_inferior_created): Use "new" to create target.
9836         (ravenscar_thread_target::get_ada_task_ptid): Update.
9837         (_initialize_ravenscar): Don't initialize base_ptid.
9838         (ravenscar_ops): Remove global.
9839
9840 2019-02-15  Tom Tromey  <tromey@adacore.com>
9841
9842         * target.h (push_target): Declare new overload.
9843         * target.c (push_target): New overload, taking an rvalue reference.
9844         * remote.c (remote_target::open_1): Use push_target overload.
9845         * corelow.c (core_target_open): Use push_target overload.
9846
9847 2019-02-15  Tom Tromey  <tromey@adacore.com>
9848
9849         * ravenscar-thread.c (is_ravenscar_task)
9850         (ravenscar_task_is_currently_active): Return bool.
9851         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9852         (_initialize_ravenscar): Remove "(void)".
9853         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9854         Return bool.
9855
9856 2019-02-15  Tom Tromey  <tromey@adacore.com>
9857
9858         * ravenscar-thread.c (ravenscar_runtime_initializer)
9859         (has_ravenscar_runtime, get_running_thread_id)
9860         (ravenscar_thread_target::resume): Fix indentation.
9861
9862 2019-02-15  Tom Tromey  <tromey@adacore.com>
9863
9864         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9865         from ravenscar_arch_ops.
9866         (sparc_ravenscar_ops::fetch_registers)
9867         (sparc_ravenscar_ops::store_registers): Now methods.
9868         (sparc_ravenscar_prepare_to_store): Remove.
9869         (sparc_ravenscar_ops): Redefine.
9870         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9871         methods and destructor.  Remove members.
9872         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9873         (ravenscar_thread_target::store_registers)
9874         (ravenscar_thread_target::prepare_to_store): Update.
9875         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9876         Remove.
9877         (struct ppc_ravenscar_powerpc_ops): Derive from
9878         ravenscar_arch_ops.
9879         (ppc_ravenscar_powerpc_ops::fetch_registers)
9880         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9881         (ppc_ravenscar_powerpc_ops): Redefine.
9882         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9883         (ppc_ravenscar_e500_ops::fetch_registers)
9884         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9885         (ppc_ravenscar_e500_ops): Redefine.
9886         * aarch64-ravenscar-thread.c
9887         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9888         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9889         (aarch64_ravenscar_fetch_registers)
9890         (aarch64_ravenscar_store_registers): Now methods.
9891         (aarch64_ravenscar_ops): Redefine.
9892
9893 2019-02-15  Tom Tromey  <tromey@adacore.com>
9894
9895         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9896         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9897         (ravenscar_thread_target::stopped_by_watchpoint)
9898         (ravenscar_thread_target::stopped_data_address)
9899         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9900
9901 2019-02-15  Tom Tromey  <tromey@adacore.com>
9902
9903         * ravenscar-thread.c: Fix some typos.
9904
9905 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9906             Tom Tromey  <tromey@adacore.com>
9907
9908         * ada-lang.c (ada_exception_sal): Change addr_string to a
9909         std::string.
9910         (create_ada_exception_catchpoint): Update.
9911
9912 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9913             Tom Tromey  <tromey@adacore.com>
9914
9915         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9916         (bp_location_ops): Remove.
9917         (base_breakpoint_allocate_location): Update.
9918         (free_bp_location): Update.
9919         * ada-lang.c (class ada_catchpoint_location)
9920         <ada_catchpoint_location>: Remove ops parameter.
9921         (ada_catchpoint_location_dtor): Remove.
9922         (ada_catchpoint_location_ops): Remove.
9923         (allocate_location_exception): Update.
9924         * breakpoint.h (struct bp_location_ops): Remove.
9925         (class bp_location) <bp_location>: Remove bp_location_ops
9926         parameter.
9927         <~bp_location>: Add destructor.
9928         <ops>: Remove.
9929
9930 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9931             Pedro Alves  <palves@redhat.com>
9932
9933         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9934         'PATH_MAX'.
9935
9936 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9937             Samuel Thibault  <samuel.thibault@gnu.org>
9938             Thomas Schwinge  <thomas@codesourcery.com>
9939
9940         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9941         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9942
9943 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9944
9945         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9946         (check_empty): Use "const char *".
9947
9948         * gnu-nat.c (gnu_nat_target::detach): Instead of
9949         'detach_inferior (pid)' call
9950         'detach_inferior (find_inferior_pid (pid))'.
9951
9952         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9953         'nat/fork-inferior.o'.
9954         * gnu-nat.c: #include "nat/fork-inferior.h".
9955
9956         * gnu-nat.c (gnu_nat_target::detach): Instead of
9957         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9958         * gnu-nat.h: #include "inf-child.h".
9959         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9960         'i386_gnu_nat_target::fetch_registers'.
9961         (gnu_store_registers): Rename/move to
9962         'i386_gnu_nat_target::store_registers'.
9963
9964         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9965         * gnu-nat.h (mach_thread_info): New function.
9966         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9967
9968         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9969
9970 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9971
9972         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9973
9974 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9975
9976         * windows-nat.c (windows_add_thread): Add new parameter
9977         "main_thread_p" with default value set to false.  Update
9978         function documentation as well as all callers.
9979         (windows_delete_thread): Likewise.
9980         (fake_create_process): Update call to windows_add_thread.
9981         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9982         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9983         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9984         call to windows_delete_thread.
9985
9986 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9987
9988         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9989
9990 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9991
9992         * symfile.c (find_separate_debug_file): Use canonical path of
9993         sysroot with child_path instead of gdb_sysroot if it is valid.
9994
9995 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9996
9997         * symfile.c (find_separate_debug_file): Use child_path to
9998         determine if an object file is under a sysroot.
9999
10000 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10001
10002         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10003         unittests/child-path-selftests.c.
10004         * common/pathstuff.c (child_path): New function.
10005         * common/pathstuff.h (child_path): New prototype.
10006         * unittests/child-path-selftests.c: New file.
10007
10008 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10009
10010         * symfile.c (find_separate_debug_file): Look for separate debug
10011         files in debug directories under the sysroot.
10012
10013 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10014
10015         * symtab.h (struct minimal_symbol data_p): New const method.
10016         (struct minimal_symbol text_p): Likewise.
10017         * symtab.c (output_source_filename): Use file name style
10018         to print file name.
10019         (print_symbol_info): Likewise.
10020         (print_msymbol_info): Use address style to print addresses.
10021         Use function name style to print executable text symbols.
10022         (expand_symtab_containing_pc): Use data_p.
10023         (find_pc_sect_compunit_symtab): Likewise.
10024
10025 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10026
10027         * breakpoint.c (describe_other_breakpoints): Use address style
10028         to print addresses.
10029         (say_where): Likewise.
10030
10031 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10032
10033         * ada-typeprint.c (print_func_type): Print function name
10034         style to print function name.
10035         * c-typeprint.c (c_print_type_1): Likewise.
10036
10037 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10038
10039         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10040         for execve.
10041
10042 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10043
10044         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10045         type_stack.
10046
10047 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10048
10049         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10050         TYPE_CODE_REF types.
10051
10052 2019-02-08  Jim Wilson  <jimw@sifive.com>
10053
10054         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10055         (riscv_linux_fregset): New.
10056         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10057
10058 2019-02-07  Tom Tromey  <tom@tromey.com>
10059
10060         * thread.c (thread_cancel_execution_command): Update.
10061         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10062         methods.
10063         (struct thread_fsm_ops): Remove.
10064         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10065         (thread_fsm_should_stop, thread_fsm_return_value)
10066         (thread_fsm_set_finished, thread_fsm_finished_p)
10067         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10068         Don't declare.
10069         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10070         * infrun.c (clear_proceed_status_thread)
10071         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10072         (print_stop_event): Update.
10073         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10074         Add constructor.
10075         (step_command_fsm_ops): Remove.
10076         (new_step_command_fsm): Remove.
10077         (step_1): Update.
10078         (step_command_fsm::should_stop): Rename from
10079         step_command_fsm_should_stop.
10080         (step_command_fsm::clean_up): Rename from
10081         step_command_fsm_clean_up.
10082         (step_command_fsm::do_async_reply_reason): Rename from
10083         step_command_fsm_async_reply_reason.
10084         (struct until_next_fsm): Inherit from thread_fsm.  Add
10085         constructor.
10086         (until_next_fsm_ops): Remove.
10087         (new_until_next_fsm): Remove.
10088         (until_next_fsm::should_stop): Rename from
10089         until_next_fsm_should_stop.
10090         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10091         (until_next_fsm::do_async_reply_reason): Rename from
10092         until_next_fsm_async_reply_reason.
10093         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10094         constructor.  Change type of breakpoint.
10095         (finish_command_fsm_ops): Remove.
10096         (new_finish_command_fsm): Remove.
10097         (finish_command_fsm::should_stop): Rename from
10098         finish_command_fsm_should_stop.
10099         (finish_command_fsm::clean_up): Rename from
10100         finish_command_fsm_clean_up.
10101         (finish_command_fsm::return_value): Rename from
10102         finish_command_fsm_return_value.
10103         (finish_command_fsm::do_async_reply_reason): Rename from
10104         finish_command_fsm_async_reply_reason.
10105         (finish_command): Update.
10106         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10107         Add constructor.
10108         (call_thread_fsm_ops): Remove.
10109         (call_thread_fsm::call_thread_fsm): Rename from
10110         new_call_thread_fsm.
10111         (call_thread_fsm::should_stop): Rename from
10112         call_thread_fsm_should_stop.
10113         (call_thread_fsm::should_notify_stop): Rename from
10114         call_thread_fsm_should_notify_stop.
10115         (run_inferior_call, call_function_by_hand_dummy): Update.
10116         * cli/cli-interp.c (should_print_stop_to_console): Update.
10117         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10118         Add constructor.  Change type of location_breakpoint,
10119         caller_breakpoint.
10120         (until_break_fsm_ops): Remove.
10121         (new_until_break_fsm): Remove.
10122         (until_break_fsm::should_stop): Rename from
10123         until_break_fsm_should_stop.
10124         (until_break_fsm::clean_up): Rename from
10125         until_break_fsm_clean_up.
10126         (until_break_fsm::do_async_reply_reason): Rename from
10127         until_break_fsm_async_reply_reason.
10128         (until_break_command): Update.
10129         * thread-fsm.c: Remove.
10130         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10131
10132 2019-02-07  Tom Tromey  <tom@tromey.com>
10133
10134         * yy-remap.h: Add include guard.
10135         * xtensa-tdep.h: Add include guard.
10136         * xcoffread.h: Rename include guard.
10137         * varobj-iter.h: Add include guard.
10138         * tui/tui.h: Rename include guard.
10139         * tui/tui-winsource.h: Rename include guard.
10140         * tui/tui-wingeneral.h: Rename include guard.
10141         * tui/tui-windata.h: Rename include guard.
10142         * tui/tui-win.h: Rename include guard.
10143         * tui/tui-stack.h: Rename include guard.
10144         * tui/tui-source.h: Rename include guard.
10145         * tui/tui-regs.h: Rename include guard.
10146         * tui/tui-out.h: Rename include guard.
10147         * tui/tui-layout.h: Rename include guard.
10148         * tui/tui-io.h: Rename include guard.
10149         * tui/tui-hooks.h: Rename include guard.
10150         * tui/tui-file.h: Rename include guard.
10151         * tui/tui-disasm.h: Rename include guard.
10152         * tui/tui-data.h: Rename include guard.
10153         * tui/tui-command.h: Rename include guard.
10154         * tic6x-tdep.h: Add include guard.
10155         * target/waitstatus.h: Rename include guard.
10156         * target/wait.h: Rename include guard.
10157         * target/target.h: Rename include guard.
10158         * target/resume.h: Rename include guard.
10159         * target-float.h: Rename include guard.
10160         * stabsread.h: Add include guard.
10161         * rs6000-tdep.h: Add include guard.
10162         * riscv-fbsd-tdep.h: Add include guard.
10163         * regformats/regdef.h: Rename include guard.
10164         * record.h: Rename include guard.
10165         * python/python.h: Rename include guard.
10166         * python/python-internal.h: Rename include guard.
10167         * python/py-stopevent.h: Rename include guard.
10168         * python/py-ref.h: Rename include guard.
10169         * python/py-record.h: Rename include guard.
10170         * python/py-record-full.h: Rename include guard.
10171         * python/py-record-btrace.h: Rename include guard.
10172         * python/py-instruction.h: Rename include guard.
10173         * python/py-events.h: Rename include guard.
10174         * python/py-event.h: Rename include guard.
10175         * procfs.h: Add include guard.
10176         * proc-utils.h: Add include guard.
10177         * p-lang.h: Add include guard.
10178         * or1k-tdep.h: Rename include guard.
10179         * observable.h: Rename include guard.
10180         * nto-tdep.h: Rename include guard.
10181         * nat/x86-linux.h: Rename include guard.
10182         * nat/x86-linux-dregs.h: Rename include guard.
10183         * nat/x86-gcc-cpuid.h: Add include guard.
10184         * nat/x86-dregs.h: Rename include guard.
10185         * nat/x86-cpuid.h: Rename include guard.
10186         * nat/ppc-linux.h: Rename include guard.
10187         * nat/mips-linux-watch.h: Rename include guard.
10188         * nat/linux-waitpid.h: Rename include guard.
10189         * nat/linux-ptrace.h: Rename include guard.
10190         * nat/linux-procfs.h: Rename include guard.
10191         * nat/linux-osdata.h: Rename include guard.
10192         * nat/linux-nat.h: Rename include guard.
10193         * nat/linux-namespaces.h: Rename include guard.
10194         * nat/linux-btrace.h: Rename include guard.
10195         * nat/glibc_thread_db.h: Rename include guard.
10196         * nat/gdb_thread_db.h: Rename include guard.
10197         * nat/gdb_ptrace.h: Rename include guard.
10198         * nat/fork-inferior.h: Rename include guard.
10199         * nat/amd64-linux-siginfo.h: Rename include guard.
10200         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10201         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10202         * nat/aarch64-linux.h: Rename include guard.
10203         * nat/aarch64-linux-hw-point.h: Rename include guard.
10204         * mn10300-tdep.h: Add include guard.
10205         * mips-linux-tdep.h: Add include guard.
10206         * mi/mi-parse.h: Rename include guard.
10207         * mi/mi-out.h: Rename include guard.
10208         * mi/mi-main.h: Rename include guard.
10209         * mi/mi-interp.h: Rename include guard.
10210         * mi/mi-getopt.h: Rename include guard.
10211         * mi/mi-console.h: Rename include guard.
10212         * mi/mi-common.h: Rename include guard.
10213         * mi/mi-cmds.h: Rename include guard.
10214         * mi/mi-cmd-break.h: Rename include guard.
10215         * m2-lang.h: Add include guard.
10216         * location.h: Rename include guard.
10217         * linux-record.h: Rename include guard.
10218         * linux-nat.h: Add include guard.
10219         * linux-fork.h: Add include guard.
10220         * i386-darwin-tdep.h: Rename include guard.
10221         * hppa-linux-offsets.h: Add include guard.
10222         * guile/guile.h: Rename include guard.
10223         * guile/guile-internal.h: Rename include guard.
10224         * gnu-nat.h: Rename include guard.
10225         * gdb-stabs.h: Rename include guard.
10226         * frv-tdep.h: Add include guard.
10227         * f-lang.h: Add include guard.
10228         * event-loop.h: Add include guard.
10229         * darwin-nat.h: Rename include guard.
10230         * cp-abi.h: Rename include guard.
10231         * config/sparc/nm-sol2.h: Rename include guard.
10232         * config/nm-nto.h: Rename include guard.
10233         * config/nm-linux.h: Add include guard.
10234         * config/i386/nm-i386gnu.h: Rename include guard.
10235         * config/djgpp/nl_types.h: Rename include guard.
10236         * config/djgpp/langinfo.h: Rename include guard.
10237         * compile/gcc-cp-plugin.h: Add include guard.
10238         * compile/gcc-c-plugin.h: Add include guard.
10239         * compile/compile.h: Rename include guard.
10240         * compile/compile-object-run.h: Rename include guard.
10241         * compile/compile-object-load.h: Rename include guard.
10242         * compile/compile-internal.h: Rename include guard.
10243         * compile/compile-cplus.h: Rename include guard.
10244         * compile/compile-c.h: Rename include guard.
10245         * common/xml-utils.h: Rename include guard.
10246         * common/x86-xstate.h: Rename include guard.
10247         * common/version.h: Rename include guard.
10248         * common/vec.h: Rename include guard.
10249         * common/tdesc.h: Rename include guard.
10250         * common/selftest.h: Rename include guard.
10251         * common/scoped_restore.h: Rename include guard.
10252         * common/scoped_mmap.h: Rename include guard.
10253         * common/scoped_fd.h: Rename include guard.
10254         * common/safe-iterator.h: Rename include guard.
10255         * common/run-time-clock.h: Rename include guard.
10256         * common/refcounted-object.h: Rename include guard.
10257         * common/queue.h: Rename include guard.
10258         * common/ptid.h: Rename include guard.
10259         * common/print-utils.h: Rename include guard.
10260         * common/preprocessor.h: Rename include guard.
10261         * common/pathstuff.h: Rename include guard.
10262         * common/observable.h: Rename include guard.
10263         * common/netstuff.h: Rename include guard.
10264         * common/job-control.h: Rename include guard.
10265         * common/host-defs.h: Rename include guard.
10266         * common/gdb_wait.h: Rename include guard.
10267         * common/gdb_vecs.h: Rename include guard.
10268         * common/gdb_unlinker.h: Rename include guard.
10269         * common/gdb_unique_ptr.h: Rename include guard.
10270         * common/gdb_tilde_expand.h: Rename include guard.
10271         * common/gdb_sys_time.h: Rename include guard.
10272         * common/gdb_string_view.h: Rename include guard.
10273         * common/gdb_splay_tree.h: Rename include guard.
10274         * common/gdb_setjmp.h: Rename include guard.
10275         * common/gdb_ref_ptr.h: Rename include guard.
10276         * common/gdb_optional.h: Rename include guard.
10277         * common/gdb_locale.h: Rename include guard.
10278         * common/gdb_assert.h: Rename include guard.
10279         * common/filtered-iterator.h: Rename include guard.
10280         * common/filestuff.h: Rename include guard.
10281         * common/fileio.h: Rename include guard.
10282         * common/environ.h: Rename include guard.
10283         * common/common-utils.h: Rename include guard.
10284         * common/common-types.h: Rename include guard.
10285         * common/common-regcache.h: Rename include guard.
10286         * common/common-inferior.h: Rename include guard.
10287         * common/common-gdbthread.h: Rename include guard.
10288         * common/common-exceptions.h: Rename include guard.
10289         * common/common-defs.h: Rename include guard.
10290         * common/common-debug.h: Rename include guard.
10291         * common/cleanups.h: Rename include guard.
10292         * common/buffer.h: Rename include guard.
10293         * common/btrace-common.h: Rename include guard.
10294         * common/break-common.h: Rename include guard.
10295         * cli/cli-utils.h: Rename include guard.
10296         * cli/cli-style.h: Rename include guard.
10297         * cli/cli-setshow.h: Rename include guard.
10298         * cli/cli-script.h: Rename include guard.
10299         * cli/cli-interp.h: Rename include guard.
10300         * cli/cli-decode.h: Rename include guard.
10301         * cli/cli-cmds.h: Rename include guard.
10302         * charset-list.h: Add include guard.
10303         * buildsym-legacy.h: Rename include guard.
10304         * bfin-tdep.h: Add include guard.
10305         * ax.h: Rename include guard.
10306         * arm-linux-tdep.h: Add include guard.
10307         * arm-fbsd-tdep.h: Add include guard.
10308         * arch/xtensa.h: Rename include guard.
10309         * arch/tic6x.h: Add include guard.
10310         * arch/i386.h: Add include guard.
10311         * arch/arm.h: Rename include guard.
10312         * arch/arm-linux.h: Rename include guard.
10313         * arch/arm-get-next-pcs.h: Rename include guard.
10314         * arch/amd64.h: Add include guard.
10315         * arch/aarch64-insn.h: Rename include guard.
10316         * arch-utils.h: Rename include guard.
10317         * annotate.h: Add include guard.
10318         * amd64-darwin-tdep.h: Rename include guard.
10319         * aarch64-linux-tdep.h: Add include guard.
10320         * aarch64-fbsd-tdep.h: Add include guard.
10321         * aarch32-linux-nat.h: Add include guard.
10322
10323 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10324
10325         * macrotab.c (macro_define_internal): New function that
10326         factorizes macro_define_object_internal and macro_define_function
10327         code.
10328         (macro_define_object_internal): Use macro_define_internal.
10329         (macro_define_function): Likewise.
10330
10331 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10332
10333         * macrocmd.c (extract_identifier): Return
10334         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10335         callers.
10336
10337 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10338
10339         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10340
10341 2019-02-05  Tom Tromey  <tom@tromey.com>
10342
10343         * target.c (target_stack::unpush): Move assertion earlier.
10344
10345 2019-01-30  Tom Tromey  <tom@tromey.com>
10346
10347         PR python/23615:
10348         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10349         (gdbpy_parse_and_eval): Likewise.
10350         * python/python-internal.h (gdbpy_allow_threads): New class.
10351
10352 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10353
10354         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10355         (aarch64_fbsd_fpregmap): Move earlier.
10356         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10357         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10358         instead of individual calls to trad_frame_set_reg_addr.
10359         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10360         earlier.
10361         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10362         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10363         instead of individual calls to trad_frame_set_reg_addr.
10364
10365 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10366
10367         * CONTRIBUTE: Replace contribution list with wiki link.
10368
10369 2019-01-25  Tom Tromey  <tom@tromey.com>
10370
10371         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10372
10373 2019-01-25  Tom Tromey  <tom@tromey.com>
10374
10375         * xtensa-linux-nat.c: Fix common/ includes.
10376         * xml-support.h: Fix common/ includes.
10377         * xml-support.c: Fix common/ includes.
10378         * x86-linux-nat.c: Fix common/ includes.
10379         * windows-nat.c: Fix common/ includes.
10380         * varobj.h: Fix common/ includes.
10381         * varobj.c: Fix common/ includes.
10382         * value.c: Fix common/ includes.
10383         * valops.c: Fix common/ includes.
10384         * utils.c: Fix common/ includes.
10385         * unittests/xml-utils-selftests.c: Fix common/ includes.
10386         * unittests/utils-selftests.c: Fix common/ includes.
10387         * unittests/unpack-selftests.c: Fix common/ includes.
10388         * unittests/tracepoint-selftests.c: Fix common/ includes.
10389         * unittests/style-selftests.c: Fix common/ includes.
10390         * unittests/string_view-selftests.c: Fix common/ includes.
10391         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10392         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10393         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10394         * unittests/rsp-low-selftests.c: Fix common/ includes.
10395         * unittests/parse-connection-spec-selftests.c: Fix common/
10396         includes.
10397         * unittests/optional-selftests.c: Fix common/ includes.
10398         * unittests/offset-type-selftests.c: Fix common/ includes.
10399         * unittests/observable-selftests.c: Fix common/ includes.
10400         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10401         * unittests/memrange-selftests.c: Fix common/ includes.
10402         * unittests/memory-map-selftests.c: Fix common/ includes.
10403         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10404         * unittests/function-view-selftests.c: Fix common/ includes.
10405         * unittests/environ-selftests.c: Fix common/ includes.
10406         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10407         * unittests/common-utils-selftests.c: Fix common/ includes.
10408         * unittests/cli-utils-selftests.c: Fix common/ includes.
10409         * unittests/array-view-selftests.c: Fix common/ includes.
10410         * ui-file.c: Fix common/ includes.
10411         * tui/tui-io.c: Fix common/ includes.
10412         * tracepoint.h: Fix common/ includes.
10413         * tracepoint.c: Fix common/ includes.
10414         * tracefile-tfile.c: Fix common/ includes.
10415         * top.h: Fix common/ includes.
10416         * top.c: Fix common/ includes.
10417         * thread.c: Fix common/ includes.
10418         * target/waitstatus.h: Fix common/ includes.
10419         * target/waitstatus.c: Fix common/ includes.
10420         * target.h: Fix common/ includes.
10421         * target.c: Fix common/ includes.
10422         * target-memory.c: Fix common/ includes.
10423         * target-descriptions.c: Fix common/ includes.
10424         * symtab.h: Fix common/ includes.
10425         * symfile.c: Fix common/ includes.
10426         * stap-probe.c: Fix common/ includes.
10427         * spu-linux-nat.c: Fix common/ includes.
10428         * sparc-nat.c: Fix common/ includes.
10429         * source.c: Fix common/ includes.
10430         * solib.c: Fix common/ includes.
10431         * solib-target.c: Fix common/ includes.
10432         * ser-unix.c: Fix common/ includes.
10433         * ser-tcp.c: Fix common/ includes.
10434         * ser-pipe.c: Fix common/ includes.
10435         * ser-base.c: Fix common/ includes.
10436         * selftest-arch.c: Fix common/ includes.
10437         * s12z-tdep.c: Fix common/ includes.
10438         * rust-exp.y: Fix common/ includes.
10439         * rs6000-aix-tdep.c: Fix common/ includes.
10440         * riscv-tdep.c: Fix common/ includes.
10441         * remote.c: Fix common/ includes.
10442         * remote-notif.h: Fix common/ includes.
10443         * remote-fileio.h: Fix common/ includes.
10444         * remote-fileio.c: Fix common/ includes.
10445         * regcache.h: Fix common/ includes.
10446         * regcache.c: Fix common/ includes.
10447         * record-btrace.c: Fix common/ includes.
10448         * python/python.c: Fix common/ includes.
10449         * python/py-type.c: Fix common/ includes.
10450         * python/py-inferior.c: Fix common/ includes.
10451         * progspace.h: Fix common/ includes.
10452         * producer.c: Fix common/ includes.
10453         * procfs.c: Fix common/ includes.
10454         * proc-api.c: Fix common/ includes.
10455         * printcmd.c: Fix common/ includes.
10456         * ppc-linux-nat.c: Fix common/ includes.
10457         * parser-defs.h: Fix common/ includes.
10458         * osdata.c: Fix common/ includes.
10459         * obsd-nat.c: Fix common/ includes.
10460         * nat/x86-linux.c: Fix common/ includes.
10461         * nat/x86-linux-dregs.c: Fix common/ includes.
10462         * nat/x86-dregs.h: Fix common/ includes.
10463         * nat/x86-dregs.c: Fix common/ includes.
10464         * nat/ppc-linux.c: Fix common/ includes.
10465         * nat/mips-linux-watch.h: Fix common/ includes.
10466         * nat/mips-linux-watch.c: Fix common/ includes.
10467         * nat/linux-waitpid.c: Fix common/ includes.
10468         * nat/linux-ptrace.h: Fix common/ includes.
10469         * nat/linux-ptrace.c: Fix common/ includes.
10470         * nat/linux-procfs.c: Fix common/ includes.
10471         * nat/linux-personality.c: Fix common/ includes.
10472         * nat/linux-osdata.c: Fix common/ includes.
10473         * nat/linux-namespaces.c: Fix common/ includes.
10474         * nat/linux-btrace.h: Fix common/ includes.
10475         * nat/linux-btrace.c: Fix common/ includes.
10476         * nat/fork-inferior.c: Fix common/ includes.
10477         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10478         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10479         * nat/aarch64-linux.c: Fix common/ includes.
10480         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10481         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10482         * namespace.h: Fix common/ includes.
10483         * mips-linux-tdep.c: Fix common/ includes.
10484         * minsyms.c: Fix common/ includes.
10485         * mi/mi-parse.h: Fix common/ includes.
10486         * mi/mi-main.c: Fix common/ includes.
10487         * mi/mi-cmd-env.c: Fix common/ includes.
10488         * memrange.h: Fix common/ includes.
10489         * memattr.c: Fix common/ includes.
10490         * maint.h: Fix common/ includes.
10491         * maint.c: Fix common/ includes.
10492         * main.c: Fix common/ includes.
10493         * machoread.c: Fix common/ includes.
10494         * location.c: Fix common/ includes.
10495         * linux-thread-db.c: Fix common/ includes.
10496         * linux-nat.c: Fix common/ includes.
10497         * linux-fork.c: Fix common/ includes.
10498         * inline-frame.c: Fix common/ includes.
10499         * infrun.c: Fix common/ includes.
10500         * inflow.c: Fix common/ includes.
10501         * inferior.h: Fix common/ includes.
10502         * inferior.c: Fix common/ includes.
10503         * infcmd.c: Fix common/ includes.
10504         * inf-ptrace.c: Fix common/ includes.
10505         * inf-child.c: Fix common/ includes.
10506         * ia64-linux-nat.c: Fix common/ includes.
10507         * i387-tdep.c: Fix common/ includes.
10508         * i386-tdep.c: Fix common/ includes.
10509         * i386-linux-tdep.c: Fix common/ includes.
10510         * i386-linux-nat.c: Fix common/ includes.
10511         * i386-go32-tdep.c: Fix common/ includes.
10512         * i386-fbsd-tdep.c: Fix common/ includes.
10513         * i386-fbsd-nat.c: Fix common/ includes.
10514         * guile/scm-type.c: Fix common/ includes.
10515         * guile/guile.c: Fix common/ includes.
10516         * go32-nat.c: Fix common/ includes.
10517         * gnu-nat.c: Fix common/ includes.
10518         * gdbthread.h: Fix common/ includes.
10519         * gdbarch-selftests.c: Fix common/ includes.
10520         * gdb_usleep.c: Fix common/ includes.
10521         * gdb_select.h: Fix common/ includes.
10522         * gdb_bfd.c: Fix common/ includes.
10523         * gcore.c: Fix common/ includes.
10524         * fork-child.c: Fix common/ includes.
10525         * findvar.c: Fix common/ includes.
10526         * fbsd-nat.c: Fix common/ includes.
10527         * event-top.c: Fix common/ includes.
10528         * event-loop.c: Fix common/ includes.
10529         * dwarf2read.c: Fix common/ includes.
10530         * dwarf2loc.c: Fix common/ includes.
10531         * dwarf2-frame.c: Fix common/ includes.
10532         * dwarf-index-cache.c: Fix common/ includes.
10533         * dtrace-probe.c: Fix common/ includes.
10534         * disasm-selftests.c: Fix common/ includes.
10535         * defs.h: Fix common/ includes.
10536         * csky-tdep.c: Fix common/ includes.
10537         * cp-valprint.c: Fix common/ includes.
10538         * cp-support.h: Fix common/ includes.
10539         * cp-support.c: Fix common/ includes.
10540         * corelow.c: Fix common/ includes.
10541         * completer.h: Fix common/ includes.
10542         * completer.c: Fix common/ includes.
10543         * compile/compile.c: Fix common/ includes.
10544         * compile/compile-loc2c.c: Fix common/ includes.
10545         * compile/compile-cplus-types.c: Fix common/ includes.
10546         * compile/compile-cplus-symbols.c: Fix common/ includes.
10547         * command.h: Fix common/ includes.
10548         * cli/cli-dump.c: Fix common/ includes.
10549         * cli/cli-cmds.c: Fix common/ includes.
10550         * charset.c: Fix common/ includes.
10551         * build-id.c: Fix common/ includes.
10552         * btrace.h: Fix common/ includes.
10553         * btrace.c: Fix common/ includes.
10554         * breakpoint.h: Fix common/ includes.
10555         * breakpoint.c: Fix common/ includes.
10556         * ax.h:
10557         (enum agent_op): Fix common/ includes.
10558         * ax-general.c (struct aop_map): Fix common/ includes.
10559         * ax-gdb.c: Fix common/ includes.
10560         * auxv.c: Fix common/ includes.
10561         * auto-load.c: Fix common/ includes.
10562         * arm-tdep.c: Fix common/ includes.
10563         * arch/riscv.c: Fix common/ includes.
10564         * arch/ppc-linux-common.c: Fix common/ includes.
10565         * arch/i386.c: Fix common/ includes.
10566         * arch/arm.c: Fix common/ includes.
10567         * arch/arm-linux.c: Fix common/ includes.
10568         * arch/arm-get-next-pcs.c: Fix common/ includes.
10569         * arch/amd64.c: Fix common/ includes.
10570         * arch/aarch64.c: Fix common/ includes.
10571         * arch/aarch64-insn.c: Fix common/ includes.
10572         * arch-utils.c: Fix common/ includes.
10573         * amd64-windows-tdep.c: Fix common/ includes.
10574         * amd64-tdep.c: Fix common/ includes.
10575         * amd64-sol2-tdep.c: Fix common/ includes.
10576         * amd64-obsd-tdep.c: Fix common/ includes.
10577         * amd64-nbsd-tdep.c: Fix common/ includes.
10578         * amd64-linux-tdep.c: Fix common/ includes.
10579         * amd64-linux-nat.c: Fix common/ includes.
10580         * amd64-fbsd-tdep.c: Fix common/ includes.
10581         * amd64-fbsd-nat.c: Fix common/ includes.
10582         * amd64-dicos-tdep.c: Fix common/ includes.
10583         * amd64-darwin-tdep.c: Fix common/ includes.
10584         * agent.c: Fix common/ includes.
10585         * ada-lang.h: Fix common/ includes.
10586         * ada-lang.c: Fix common/ includes.
10587         * aarch64-tdep.c: Fix common/ includes.
10588
10589 2019-01-25  Tom Tromey  <tom@tromey.com>
10590
10591         * common/create-version.sh: Use common/version.h.
10592
10593 2019-01-24  Pedro Alves  <palves@redhat.com>
10594
10595         * infrun.c (signal_stop, signal_print, signal_program)
10596         (signal_catch, signal_pass): Now arrays instead of pointers.
10597         (update_signals_program_target, do_target_resume)
10598         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10599         * linux-nat.c (linux_nat_target::pass_signals)
10600         (linux_nat_target::create_inferior, linux_nat_target::attach):
10601         Adjust.
10602         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10603         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10604         * procfs.c (procfs_target::pass_signals): Adjust.
10605         * record-full.c (record_full_target::resume): Adjust.
10606         * remote.c (remote_target::pass_signals)
10607         (remote_target::program_signals): Adjust.
10608         * target-debug.h (target_debug_print_signals): Now takes a
10609         gdb::array_view as parameter.  Adjust.
10610         * target.h (target_ops) <pass_signals, program_signals>: Replace
10611         pointer and length parameters with gdb::array_view.
10612         (target_pass_signals, target_program_signals): Likewise.
10613         * target-delegates.c: Regenerate.
10614
10615 2019-01-24  Pedro Alves  <palves@redhat.com>
10616
10617         * common/forward-scope-exit.h
10618         (forward_scope_exit::forward_scope_exit): Pass arguments to
10619         m_bind_function directly, instead of creating a std::bind and
10620         copying that.
10621
10622 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10623
10624         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10625         for static members.
10626         (pass_in_v_vfp_candidate): Likewise.
10627
10628 2019-01-23  Tom Tromey  <tom@tromey.com>
10629             Pedro Alves  <palves@redhat.com>
10630
10631         * regcache.c (class regcache_invalidator): Remove.
10632         (regcache::raw_write): Use make_scope_exit.
10633
10634 2019-01-23  Tom Tromey  <tom@tromey.com>
10635
10636         * ui-out.h (class ui_out_emit_type): Update comment.
10637
10638 2019-01-23  Tom Tromey  <tom@tromey.com>
10639
10640         * infrun.c (fetch_inferior_event): Update comment.
10641
10642 2019-01-23  Tom Tromey  <tom@tromey.com>
10643             Pedro Alves  <palves@redhat.com>
10644
10645         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10646         parameter.
10647         (fetch_inferior_event): Use SCOPE_EXIT.
10648
10649
10650 2019-01-23  Tom Tromey  <tom@tromey.com>
10651             Pedro Alves  <palves@redhat.com>
10652
10653         * infrun.c (disable_thread_events): Delete.
10654         (stop_all_threads): Use SCOPE_EXIT.
10655
10656 2019-01-23  Tom Tromey  <tom@tromey.com>
10657             Pedro Alves  <palves@redhat.com>
10658
10659         * symfile.c: Include forward-scope-exit.h.
10660         (clear_symtab_users_cleanup): Replace forward declaration with
10661         a FORWARD_SCOPE_EXIT.
10662         (syms_from_objfile_1): Use the forward_scope_exit and
10663         gdb::optional instead of cleanup_function.
10664         (reread_symbols): Use the forward_scope_exit instead of
10665         cleanup_function.
10666         (clear_symtab_users_cleanup): Remove function.
10667
10668 2019-01-23  Tom Tromey  <tom@tromey.com>
10669             Pedro Alves  <palves@redhat.com>
10670
10671         * linux-nat.c: Include scope-exit.h.
10672         (cleanup_target_stop): Remove.
10673         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10674         SCOPE_EXIT.
10675
10676 2019-01-23  Tom Tromey  <tom@tromey.com>
10677             Pedro Alves  <palves@redhat.com>
10678
10679         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10680         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10681
10682 2019-01-23  Tom Tromey  <tom@tromey.com>
10683             Andrew Burgess  <andrew.burgess@embecosm.com>
10684             Pedro Alves  <palves@redhat.com>
10685
10686         * infrun.c (fetch_inferior_event): Use scope_exit.
10687         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10688         * top.c (execute_command): Use scope_exit.
10689         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10690         * utils.c (do_bpstat_clear_actions_cleanup)
10691         (make_bpstat_clear_actions_cleanup): Remove.
10692
10693 2019-01-23  Tom Tromey  <tom@tromey.com>
10694             Pedro Alves  <palves@redhat.com>
10695
10696         * infrun.c: Include "common/scope-exit.h"
10697         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10698         (wait_for_inferior): Use SCOPE_EXIT.
10699         (fetch_inferior_event): Use scope_exit.
10700
10701 2019-01-23  Tom Tromey  <tom@tromey.com>
10702             Pedro Alves  <palves@redhat.com>
10703
10704         * breakpoint.c (create_breakpoint): Remove cleanup.
10705
10706 2019-01-23  Tom Tromey  <tom@tromey.com>
10707             Andrew Burgess  <andrew.burgess@embecosm.com>
10708             Pedro Alves  <palves@redhat.com>
10709
10710 2019-01-23  Pedro Alves  <palves@redhat.com>
10711
10712         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10713
10714 2019-01-23  Pedro Alves  <palves@redhat.com>
10715             Andrew Burgess  <andrew.burgess@embecosm.com>
10716
10717         * gdbthread.h: Include "common/forward-scope-exit.h".
10718         (scoped_finish_thread_state): Redefine custom class in terms of
10719         forward_scope_exit.
10720
10721 2019-01-23  Pedro Alves  <palves@redhat.com>
10722             Andrew Burgess  <andrew.burgess@embecosm.com>
10723
10724         * common/forward-scope-exit.h: New file.
10725
10726 2019-01-23  Pedro Alves  <palves@redhat.com>
10727             Andrew Burgess  <andrew.burgess@embecosm.com>
10728             Tom Tromey  <tom@tromey.com>
10729
10730         * common/scope-exit.h: New file.
10731
10732 2019-01-23  Pedro Alves  <palves@redhat.com>
10733
10734         * common/preprocessor.h (ESC): Rename to ...
10735         (ESC_PARENS): ... this.
10736         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10737         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10738
10739 2019-01-23  Tom Tromey  <tom@tromey.com>
10740
10741         * language.h (class scoped_switch_to_sym_language_if_auto):
10742         Initialize m_lang in both cases.
10743
10744 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10745
10746         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10747         with XCNEW.
10748
10749 2019-01-22  Tom Tromey  <tom@tromey.com>
10750
10751         * corelow.c: Do not include sys/file.h.
10752
10753 2019-01-22  Tom Tromey  <tom@tromey.com>
10754
10755         * tui/tui-wingeneral.h: Include gdb_curses.h.
10756
10757 2019-01-22  Tom Tromey  <tom@tromey.com>
10758
10759         * source-cache.h (class source_cache) <get_source_lines,
10760         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10761
10762 2019-01-22  Tom Tromey  <tom@tromey.com>
10763
10764         * remote-fileio.h (struct remote_target): Declare.
10765
10766 2019-01-22  Tom Tromey  <tom@tromey.com>
10767
10768         * python/py-arch.c: Do not include py-ref.h.
10769         * python/py-bpevent.c: Do not include py-ref.h.
10770         * python/py-cmd.c: Do not include py-ref.h.
10771         * python/py-continueevent.c: Do not include py-ref.h.
10772         * python/py-event.h: Do not include py-ref.h.
10773         * python/py-evtregistry.c: Do not include py-ref.h.
10774         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10775         * python/py-frame.c: Do not include py-ref.h.
10776         * python/py-framefilter.c: Do not include py-ref.h.
10777         * python/py-function.c: Do not include py-ref.h.
10778         * python/py-infevents.c: Do not include py-ref.h.
10779         * python/py-linetable.c: Do not include py-ref.h.
10780         * python/py-objfile.c: Do not include py-ref.h.
10781         * python/py-param.c: Do not include py-ref.h.
10782         * python/py-prettyprint.c: Do not include py-ref.h.
10783         * python/py-progspace.c: Do not include py-ref.h.
10784         * python/py-symbol.c: Do not include py-ref.h.
10785         * python/py-symtab.c: Do not include py-ref.h.
10786         * python/py-type.c: Do not include py-ref.h.
10787         * python/py-unwind.c: Do not include py-ref.h.
10788         * python/py-utils.c: Do not include py-ref.h.
10789         * python/py-value.c: Do not include py-ref.h.
10790         * python/py-varobj.c: Do not include py-ref.h.
10791         * python/py-xmethods.c: Do not include py-ref.h.
10792         * python/python.c: Do not include py-ref.h.
10793         * varobj.c: Do not include py-ref.h.
10794
10795 2019-01-22  Tom Tromey  <tom@tromey.com>
10796
10797         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10798         keyword for bcache.
10799
10800 2019-01-22  Tom Tromey  <tom@tromey.com>
10801
10802         * compile/compile-cplus-types.c: Remove a comment by #include.
10803
10804 2019-01-22  Tom Tromey  <tom@tromey.com>
10805
10806         * compile/gcc-c-plugin.h: Include compile-internal.h.
10807
10808 2019-01-22  Tom Tromey  <tom@tromey.com>
10809
10810         * stabsread.c (EXTERN): Do not define.
10811         (symnum, next_symbol_text_func, processing_gcc_compilation)
10812         (within_function, global_sym_chain, global_stabs)
10813         (previous_stab_code, this_object_header_files)
10814         (n_this_object_header_files)
10815         (n_allocated_this_object_header_files): Define.
10816         * stabsread.h (EXTERN): Never define.  Use "extern".
10817
10818 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10819
10820         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10821         history_value.
10822
10823 2019-01-21  Tom Tromey  <tom@tromey.com>
10824
10825         * ui-out.c: Fix includes.
10826         * tui/tui-source.c: Fix includes.
10827         * target.c: Fix includes.
10828         * remote.c: Fix includes.
10829         * regcache.c: Fix includes.
10830         * python/py-block.c: Fix includes.
10831         * printcmd.c: Fix includes.
10832         * or1k-tdep.c: Fix includes.
10833         * mi/mi-main.c: Fix includes.
10834         * m32r-tdep.c: Fix includes.
10835         * csky-tdep.c: Fix includes.
10836         * compile/compile-cplus-types.c: Fix includes.
10837         * cli/cli-interp.c: Fix includes.
10838
10839 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10840
10841         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10842         for padding.
10843
10844 2019-01-16  Tom Tromey  <tom@tromey.com>
10845
10846         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10847         earlier.
10848         (struct objfile) <msymbols_range>: Move from top level.
10849         <msymbols>: New method.
10850         (class objfile_msymbols): Remove.
10851         * symtab.c (default_collect_symbol_completion_matches_break_on):
10852         Update.
10853         * symmisc.c (dump_msymbols): Update.
10854         * stabsread.c (scan_file_globals): Update.
10855         * objc-lang.c (info_selectors_command, info_classes_command)
10856         (find_methods): Update.
10857         * minsyms.c (find_solib_trampoline_target): Update.
10858         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10859         * coffread.c (coff_symfile_read): Update.
10860         * ada-lang.c (ada_lookup_simple_minsym)
10861         (ada_collect_symbol_completion_matches): Update.
10862
10863 2019-01-16  Tom Tromey  <tom@tromey.com>
10864
10865         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10866         type.  Remove no-argument constructor.
10867         <iterator::operator++>: Simplify.
10868         <begin>: Update.
10869         <end>: Use minimal_symbol_count.
10870
10871 2019-01-16  Tom Tromey  <tom@tromey.com>
10872
10873         * objfiles.h (struct objfile) <psymtabs>: New method.
10874         (class objfile_psymtabs): Remove.
10875         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10876         typedef.
10877         <range>: New method.
10878         (require_partial_symbols): Change return type.
10879         * psymtab.c (require_partial_symbols)
10880         (psym_expand_symtabs_matching): Update.
10881         * mdebugread.c (parse_partial_symbols): Update.
10882         * dbxread.c (dbx_end_psymtab): Update.
10883
10884 2019-01-15  Tom Tromey  <tom@tromey.com>
10885
10886         * symtab.c (lookup_objfile_from_block)
10887         (lookup_symbol_in_objfile_symtabs)
10888         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10889         (find_line_symtab, info_sources_command)
10890         (default_collect_symbol_completion_matches_break_on)
10891         (make_source_files_completion_list): Update.
10892         * symmisc.c (print_objfile_statistics, dump_objfile)
10893         (maintenance_print_symbols, maintenance_info_symtabs)
10894         (maintenance_check_symtabs, maintenance_info_line_tables):
10895         Update.
10896         * source.c (select_source_symtab)
10897         (forget_cached_source_info_for_objfile): Update.
10898         * objfiles.h (class objfile_compunits): Remove.
10899         (struct objfile) <compunits_range>: New typedef.
10900         (compunits): New method.
10901         * objfiles.c (objfile_relocate1): Update.
10902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10903         * maint.c (count_symtabs_and_blocks): Update.
10904         * linespec.c (iterate_over_all_matching_symtabs): Update.
10905         * cp-support.c (add_symbol_overload_list_qualified): Update.
10906         * coffread.c (coff_symtab_read): Update.
10907         * ada-lang.c (add_nonlocal_symbols)
10908         (ada_collect_symbol_completion_matches)
10909         (ada_add_global_exceptions): Update.
10910
10911 2019-01-15  Tom Tromey  <tom@tromey.com>
10912
10913         * progspace.h (program_space) <objfiles_safe_range>: New
10914         typedef.
10915         <objfiles_safe>: New method.
10916         * objfiles.h (class all_objfiles_safe): Remove.
10917         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10918         * jit.c (jit_inferior_exit_hook): Update.
10919
10920 2019-01-17  Tom Tromey  <tom@tromey.com>
10921
10922         * progspace.h (program_space) <objfiles_range>: New typedef.
10923         <objfiles>: New method.
10924         <objfiles_head>: Rename from objfiles.
10925         (object_files): Update.
10926         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10927         * guile/scm-pretty-print.c
10928         (ppscm_find_pretty_printer_from_objfiles): Update.
10929         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10930         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10931         Update.
10932         * python/py-progspace.c (pspy_get_objfiles): Update.
10933         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10934         Update.
10935         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10936         (objfpy_lookup_objfile_by_build_id): Update.
10937         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10938         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10939         Update.
10940         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10941         (expand_symtab_containing_pc, lookup_objfile_from_block)
10942         (lookup_static_symbol, basic_lookup_transparent_type)
10943         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10944         (find_line_symtab, info_sources_command)
10945         (default_collect_symbol_completion_matches_break_on)
10946         (make_source_files_completion_list, find_main_name): Update.
10947         * symmisc.c (print_symbol_bcache_statistics)
10948         (print_objfile_statistics, maintenance_print_symbols)
10949         (maintenance_print_msymbols, maintenance_print_objfiles)
10950         (maintenance_info_symtabs, maintenance_check_symtabs)
10951         (maintenance_expand_symtabs, maintenance_info_line_tables):
10952         Update.
10953         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10954         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10955         (map_overlay_command, unmap_overlay_command)
10956         (simple_overlay_update, expand_symtabs_matching)
10957         (map_symbol_filenames): Update.
10958         * symfile-debug.c (set_debug_symfile): Update.
10959         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10960         Update.
10961         * source.c (select_source_symtab, forget_cached_source_info):
10962         Update.
10963         * solib.c (solib_read_symbols): Update.
10964         * solib-spu.c (append_ocl_sos): Update.
10965         * psymtab.c (maintenance_print_psymbols)
10966         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10967         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10968         * printcmd.c (info_symbol_command): Update.
10969         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10970         Update.
10971         * objfiles.h (class all_objfiles): Remove.
10972         * objfiles.c (have_partial_symbols, have_full_symbols)
10973         (have_minimal_symbols, qsort_cmp, update_section_map)
10974         (shared_objfile_contains_address_p)
10975         (default_iterate_over_objfiles_in_search_order): Update.
10976         * objc-lang.c (info_selectors_command, info_classes_command)
10977         (find_methods): Update.
10978         * minsyms.c (find_solib_trampoline_target): Update.
10979         * maint.c (maintenance_info_sections)
10980         (maintenance_translate_address, count_symtabs_and_blocks):
10981         Update.
10982         * main.c (captured_main_1): Update.
10983         * linux-thread-db.c (try_thread_db_load_from_pdir)
10984         (has_libpthread): Update.
10985         * linespec.c (iterate_over_all_matching_symtabs)
10986         (search_minsyms_for_name): Update.
10987         * jit.c (jit_find_objf_with_entry_addr): Update.
10988         * hppa-tdep.c (find_unwind_entry)
10989         (hppa_lookup_stub_minimal_symbol): Update.
10990         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10991         Update.
10992         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10993         (elf_gnu_ifunc_resolve_by_got): Update.
10994         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10995         * dwarf-index-write.c (save_gdb_index_command): Update.
10996         * cp-support.c (add_symbol_overload_list_qualified): Update.
10997         * breakpoint.c (create_overlay_event_breakpoint)
10998         (create_longjmp_master_breakpoint)
10999         (create_std_terminate_master_breakpoint)
11000         (create_exception_master_breakpoint): Update.
11001         * blockframe.c (find_pc_partial_function): Update.
11002         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11003         (ada_collect_symbol_completion_matches)
11004         (ada_add_global_exceptions): Update.
11005
11006 2019-01-17  Tom Tromey  <tom@tromey.com>
11007
11008         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11009         declare VEC.
11010         (solib_target_parse_libraries): Change return type.
11011         (library_list_start_segment, library_list_start_section)
11012         (library_list_end_library, library_list_start_library); Update.
11013         (solib_target_free_library_list): Remove.
11014         (solib_target_parse_libraries): Remove cleanup.  Change return
11015         type.
11016         (solib_target_current_sos): Update.
11017
11018 2019-01-17  Tom Tromey  <tromey@bapiya>
11019
11020         * valprint.c: Replace "the the" with "the".
11021         * symtab.c: Replace "the the" with "the".
11022         * solib.c: Replace "the the" with "the".
11023         * solib-dsbt.c: Replace "the the" with "the".
11024         * linespec.c: Replace "the the" with "the".
11025         * dwarf2loc.h: Replace "the the" with "the".
11026         * amd64-windows-tdep.c: Replace "the the" with "the".
11027         * aarch64-tdep.c: Replace "the the" with "the".
11028
11029 2019-01-16  Keith Seitz  <keiths@redhat.com>
11030
11031         PR gdb/23773
11032         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11033         <builder>: Rename to ..
11034         <m_builder>: ... this and make private.
11035         (dwarf2_cu::get_builder): New method.  Change all users of
11036         `builder' to use this method.
11037         (dwarf2_start_symtab): Move to ...
11038         (dwarf2_cu::start_symtab): ... here.  Update all callers
11039         (setup_type_unit_groups): Move to ...
11040         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11041         callers.
11042         (dwarf2_cu::reset_builder): New method.
11043         (process_full_compunit, process_full_type_unit): Use
11044         dwarf2_cu::reset_builder.
11045         (follow_die_offset): Record the ancestor CU if it is different
11046         from the followed DIE's CU.
11047         (follow_die_sig_1): Likewise.
11048
11049 2019-01-15  Tom Tromey  <tom@tromey.com>
11050
11051         * remote.c (class remote_state) <buf>: Now a char_vector.
11052         <buf_size>: Remove.
11053         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11054         parameter.
11055         (remote_target::getpkt_or_notif_sane_1)
11056         (remote_target::getpkt_sane)
11057         (remote_target::getpkt_or_notif_sane): Likewise.
11058         (class remote_target) <putpkt>: New overload.
11059         (remote_target::read_frame): Change type of "buf_p".  Remove
11060         sizeof_p parameter.
11061         (packet_ok): New overload.
11062         (packet_check_result): New overload.
11063         Update all uses.
11064
11065 2019-01-14  Tom Tromey  <tom@tromey.com>
11066
11067         * remote-notif.c (handle_notification, remote_notif_ack)
11068         (remote_notif_parse): Make "buf" const.
11069         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11070         const.
11071         (remote_notif_parse, remote_notif_ack, handle_notification):
11072         Likewise.
11073         * remote.c (remote_notif_stop_parse): Make "buf" const.
11074         (remote_target::remote_parse_stop_reply): Make "buf" const.
11075         (remote_notif_stop_ack): Make "buf" const.
11076
11077 2019-01-14  Tom Tromey  <tom@tromey.com>
11078
11079         * remote.c (remote_console_output): Make parameter const.
11080
11081 2019-01-14  Tom Tromey  <tom@tromey.com>
11082
11083         * target-debug.h (target_debug_print_signals): Constify.
11084         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11085         * procfs.c (procfs_target::pass_signals): Update.
11086         * linux-nat.c (linux_nat_target::pass_signals): Update.
11087         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11088         * target-delegates.c: Rebuild.
11089         * remote.c (remote_target::program_signals): Update.
11090         (remote_target::pass_signals): Update.
11091         * target.c (target_pass_signals): Constify argument.
11092         (target_program_signals): Likewise.
11093         * target.h (struct target_ops) <pass_signals, program_signals>:
11094         Constify argument.
11095         (target_pass_signals, target_program_signals): Constify argument.
11096
11097 2019-01-14  Tom Tromey  <tom@tromey.com>
11098
11099         PR tui/28819:
11100         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11101
11102 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11103
11104         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11105         field.
11106         * rs6000-tdep.c: Include reggroups.h.
11107         (IS_V_ALIAS_PSEUDOREG): Define.
11108         (rs6000_register_name): Return names for the "vX" aliases.
11109         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11110         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11111         aliases.  Call default_register_reggroup_p for all other
11112         pseudo-registers.
11113         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11114         New functions.
11115         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11116         Handle "vX" aliases.
11117         (v_alias_pseudo_register_collect): New function.
11118         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11119         (rs6000_gdbarch_init): Initialize "vX" aliases as
11120         pseudo-registers.  Restore registration of
11121         rs6000_pseudo_register_reggroup_p with
11122         set_tdesc_pseudo_register_reggroup_p.
11123
11124 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11125
11126         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11127         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11128         set_gdbarch_num_pseudo_regs.
11129
11130 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11131
11132         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11133         Remove arg prefixname, add do_set and do_show.
11134         Add member functions set_list and show_list.
11135         * cli/cli-style.c (class cli_style_option): Update accordingly.
11136         (style_set_list): Move to file scope.
11137         (style_show_list): Likewise.
11138         (set_style): Call help_list.
11139         (show_style): Call cmd_show_list.
11140         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11141         Update to use the new macro.
11142
11143 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11144
11145         * ada-lang.c (_initialize_ada_language): Expand the help text
11146         for the "catch exception" command.
11147
11148 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11149
11150         * symtab.c (matching_obj_sections): Initialize obj,
11151         declare it closer to its usage.
11152
11153 2019-01-10  Tom Tromey  <tom@tromey.com>
11154
11155         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11156         (basic_inf_threads_range): Remove.
11157         (inf_threads_range, inf_non_exited_threads_range)
11158         (safe_inf_threads_range): Use next_adapter.
11159
11160 2019-01-10  Keith Seitz  <keiths@redhat.com>
11161
11162         PR gdb/23712
11163         PR symtab/23010
11164         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11165         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11166
11167 2019-01-10  Keith Seitz  <keiths@redhat.com>
11168
11169         PR gdb/23712
11170         PR symtab/23010
11171         * dictionary.c (pending_to_vector): Remove.
11172         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11173         Remove _1 suffix, replacing functions of the same name.  Update
11174         all callers.
11175         (dict_create_hashed, dict_create_hashed_expandable)
11176         (dict_create_linear, dict_create_linear_expandable, dict_free)
11177         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11178         Make functions static.
11179
11180 2019-01-10  Keith Seitz  <keiths@redhat.com>
11181
11182         PR gdb/23712
11183         PR symtab/23010
11184         * dictionary.h (struct dictionary): Replace declaration with
11185         multidictionary.
11186         (dict_create_hashed, dict_create_hashed_expandable)
11187         (dict_create_linear, dict_create_linear_expandable)
11188         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11189         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11190         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11191         taking multidictionary argument.
11192         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11193         * block.h (struct block) <dict>: Change to multidictionary
11194         and rename `multidict'.
11195         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11196         symmisc.c: Update all dictionary references to multidictionary.
11197
11198 2019-01-10  Keith Seitz  <keiths@redhat.com>
11199
11200         PR gdb/23712
11201         PR symtab/23010
11202         * dictionary.c: Include unordered_map.
11203         (pending_to_vector): New function.
11204         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11205         Rewrite the non-"_1" functions to take vector instead
11206         of linked list.
11207         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11208         "new" _1 versions of the same name.
11209         (multidictionary): Define.
11210         (std::hash<enum language): New definition.
11211         (collate_pending_symbols_by_language, mdict_create_hashed)
11212         (mdict_create_hashed_expandable, mdict_create_linear)
11213         (mdict_create_linear_expandable, mdict_free)
11214         (find_language_dictionary, create_new_language_dictionary)
11215         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11216         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11217         (mdict_size, mdict_empty): New functions.
11218         * dictionary.h (mdict_iterator): Define.
11219
11220 2019-01-10  Pedro Alves  <palves@redhat.com>
11221
11222         * breakpoint.c (read_uploaded_action)
11223         (create_tracepoint_from_upload): Adjust to use
11224         gdb::unique_xmalloc_ptr.
11225         * ctf.c (ctf_write_uploaded_tp):
11226         (SET_ARRAY_FIELD): Use emplace_back.
11227         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11228         * tracefile-tfile.c (tfile_write_uploaded_tp):
11229         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11230         gdb::unique_xmalloc_ptr.
11231         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11232         at_string, cond_string, cmd_strings>: Replace char pointers
11233         with gdb::unique_xmalloc_ptr.
11234
11235 2019-01-10  Pedro Alves  <palves@redhat.com>
11236
11237         * solib-target.c (library_list_start_library): Don't xstrdup name.
11238
11239 2019-01-10  Pedro Alves  <palves@redhat.com>
11240
11241         * mdebugread.c (parse_partial_symbols): Use
11242         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11243
11244 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11245
11246         * linux-fork.c (scoped_switch_fork_info)
11247         <~scoped_switch_fork_info>: Fix incorrect variable name.
11248
11249 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11250
11251         * linux-fork.c (scoped_switch_fork_info)
11252         <scoped_switch_fork_info>: Make explicit.
11253         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11254
11255 2019-01-10  Tom Tromey  <tom@tromey.com>
11256
11257         * objfiles.h (objfile::reset_psymtabs): Update.
11258         * objfiles.c (objfile::objfile): Update.
11259         * psymtab.h (psymtab_storage::obstack): Update.
11260         (psymtab_storage::m_obstack): Use gdb::optional.
11261         (class psymtab_storage): Update comment.  Remove objfile
11262         parameter.
11263         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11264
11265 2019-01-10  Tom Tromey  <tom@tromey.com>
11266
11267         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11268         <free_psymtabs>: Now private.
11269         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11270         (allocate_psymtab): Use new method.
11271
11272 2019-01-10  Tom Tromey  <tom@tromey.com>
11273
11274         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11275         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11276         * mdebugread.c (parse_partial_symbols): Use
11277         allocate_dependencies.
11278         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11279         allocate_dependencies.
11280         (process_psymtab_comp_unit_reader)
11281         (build_type_psymtab_dependencies): Likewise.
11282         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11283
11284 2019-01-10  Tom Tromey  <tom@tromey.com>
11285
11286         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11287         PSYMBOL_SET_LANGUAGE.
11288         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11289
11290 2019-01-10  Tom Tromey  <tom@tromey.com>
11291
11292         * psymtab.h (psymtab_storage::obstack): New method.
11293         <m_obstack>: Rename from obstack; now private.
11294         * psymtab.c (psymtab_storage): Update.
11295         * dwarf2read.c (create_addrmap_from_index)
11296         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11297         Update.
11298
11299 2019-01-10  Tom Tromey  <tom@tromey.com>
11300
11301         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11302         * objfiles.h (objfile::reset_psymtabs): New method.
11303
11304 2019-01-10  Tom Tromey  <tom@tromey.com>
11305
11306         * symmisc.c (print_symbol_bcache_statistics): Update.
11307         (print_objfile_statistics): Update.
11308         * symfile.c (reread_symbols): Update.
11309         * psymtab.h (class psymtab_storage): New.
11310         * psymtab.c (psymtab_storage): New constructor.
11311         (~psymtab_storage): New destructor.
11312         (require_partial_symbols): Update.
11313         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11314         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11315         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11316         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11317         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11318         (start_psymtab_common, end_psymtab_common)
11319         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11320         (allocate_psymtab): Update.
11321         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11322         Update.
11323         (dump_psymtab_addrmap, maintenance_print_psymbols)
11324         (maintenance_check_psymtabs): Update.
11325         (class objfile_psymtabs): Move to objfiles.h.
11326         * psympriv.h (discard_psymtab): Now inline.
11327         (psymtab_discarder::psymtab_discarder): Update.
11328         (psymtab_discarder::~psymtab_discarder): Update.
11329         (ALL_OBJFILE_PSYMTABS): Rewrite.
11330         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11331         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11332         Remove fields.
11333         <partial_symtabs>: New field.
11334         (class objfile_psymtabs): Move from psymtab.h.  Update.
11335         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11336         psymbol_cache.
11337         (objfile::~objfile): Don't destroy psymbol_cache.
11338         * mdebugread.c (parse_partial_symbols): Update.
11339         * dwarf2read.c (create_addrmap_from_index)
11340         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11341         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11342         (add_partial_subprogram, dwarf2_ranges_read): Update.
11343         * dwarf-index-write.c (write_address_map)
11344         (write_one_signatured_type, recursively_write_psymbols)
11345         (class debug_names, class debug_names, write_psymtabs_to_index):
11346         Update.
11347
11348 2019-01-10  Tom Tromey  <tom@tromey.com>
11349
11350         * symtab.h (SYMBOL_SET_NAMES): Update.
11351         (symbol_set_names): Update.
11352         (MSYMBOL_SET_NAMES): Update.
11353         * symtab.c (symbol_set_names): Change argument to be an
11354         objfile_per_bfd_storage.
11355         * psymtab.c (add_psymbol_to_bcache): Update.
11356         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11357
11358 2019-01-10  Tom Tromey  <tom@tromey.com>
11359
11360         * symtab.c (create_demangled_names_hash): Change argument to be an
11361         objfile_per_bfd_storage.
11362         (symbol_set_names): Update.
11363
11364 2019-01-10  Tom Tromey  <tom@tromey.com>
11365
11366         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11367         init_psymbol_list.
11368         * psymtab.c (init_psymbol_list): Do nothing if already called.
11369         * psympriv.h (init_psymbol_list): Add comment.
11370         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11371         init_psymbol_list.
11372         * dbxread.c (dbx_symfile_read): Unconditionally call
11373         init_psymbol_list.
11374
11375 2019-01-10  Tom Tromey  <tom@tromey.com>
11376
11377         * xcoffread.c (scan_xcoff_symtab): Update.
11378         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11379         "where".
11380         * mdebugread.c (parse_partial_symbols)
11381         (handle_psymbol_enumerators): Update.
11382         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11383         * dbxread.c (read_dbx_symtab): Update.
11384         * psympriv.h (psymbol_placement): New enum.
11385         (add_psymbol_to_list): Update.
11386
11387 2019-01-10  Tom Tromey  <tom@tromey.com>
11388
11389         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11390         static_psymbols parameters.
11391         (scan_xcoff_symtab): Update.
11392         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11393         static_psymbols parameters.
11394         * psympriv.h (start_psymtab_common): Update.
11395         * mdebugread.c (parse_partial_symbols): Update.
11396         * dwarf2read.c (create_partial_symtab): Update.
11397         * dbxread.c (read_dbx_symtab): Update.
11398         (start_psymtab): Remove global_psymbols and static_psymbols
11399         parameters.
11400
11401 2019-01-10  Tom Tromey  <tom@tromey.com>
11402
11403         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11404         * psymtab.c (allocate_psymtab): Add comment.
11405         * psympriv.h (allocate_psymtab): Add comment.
11406         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11407         initializations.
11408         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11409
11410 2019-01-10  Tom Tromey  <tom@tromey.com>
11411
11412         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11413         Don't declare.
11414         * mipsread.c: Include mdebugread.h.
11415         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11416         Declare.
11417         * elfread.c: Include mdebugread.h.
11418
11419 2019-01-09  Tom Tromey  <tom@tromey.com>
11420
11421         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11422         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11423         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11424         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11425         (psym_lookup_symbol, psym_find_last_source_symtab)
11426         (psym_forget_cached_source_info, psym_print_stats)
11427         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11428         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11429         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11430         (psym_find_compunit_symtab_by_address)
11431         (maintenance_print_psymbols, maintenance_info_psymtabs)
11432         (maintenance_check_psymtabs): Use ranged for.
11433         * psymtab.h (class objfile_psymtabs): New.
11434         (require_partial_symbols): Return objfile_psymtabs.
11435         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11436
11437 2019-01-09  Tom Tromey  <tom@tromey.com>
11438
11439         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11440         (find_pc_mapped_section, list_overlays_command)
11441         (map_overlay_command, unmap_overlay_command)
11442         (simple_overlay_update): Use all_objfiles.
11443         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11444         * printcmd.c (info_symbol_command): Use all_objfiles.
11445         * objfiles.h (ALL_OBJSECTIONS): Remove.
11446         * maint.c (maintenance_translate_address): Use all_objfiles.
11447         * gcore.c (gcore_create_callback): Use all_objfiles.
11448         (objfile_find_memory_regions): Likewise.
11449
11450 2019-01-09  Tom Tromey  <tom@tromey.com>
11451
11452         * symtab.c (find_line_symtab, info_sources_command)
11453         (make_source_files_completion_list): Use objfile_compunits.
11454         * source.c (select_source_symtab): Use objfile_compunits.
11455         * objfiles.h (struct objfile): Update comment.
11456         (ALL_OBJFILES): Remove.
11457         (ALL_FILETABS): Remove.
11458         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11459         objfile_compunits.
11460
11461 2019-01-09  Tom Tromey  <tom@tromey.com>
11462
11463         * symmisc.c (print_objfile_statistics, dump_objfile)
11464         (maintenance_print_symbols): Use compunit_filetabs.
11465         * source.c (forget_cached_source_info_for_objfile): Use
11466         compunit_filetabs.
11467         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11468         (ALL_FILETABS): Use compunit_filetabs.
11469         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11470         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11471
11472 2019-01-09  Tom Tromey  <tom@tromey.com>
11473
11474         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11475         (compunit_filetabs): New.
11476         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11477         compunit_filetabs.
11478         (info_sources_command, make_source_files_completion_list): Remove
11479         declaration.
11480         * symmisc.c (print_objfile_statistics, dump_objfile)
11481         (maintenance_print_symbols): Remove declaration.
11482         (maintenance_info_symtabs): Use compunit_filetabs.
11483         (maintenance_info_line_tables): Likewise.
11484         * source.c (select_source_symtab): Change local variable name.
11485         (forget_cached_source_info_for_objfile): Remove declaration.
11486         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11487         * objfiles.c (objfile_relocate1): Remove declaration.
11488         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11489         declaration.
11490         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11491         * coffread.c (coff_symtab_read): Remove declaration.
11492         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11493         compunit_filetabs.
11494
11495 2019-01-09  Tom Tromey  <tom@tromey.com>
11496
11497         * symtab.c (lookup_objfile_from_block)
11498         (find_pc_sect_compunit_symtab, search_symbols)
11499         (default_collect_symbol_completion_matches_break_on): Use
11500         objfile_compunits.
11501         * objfiles.h (ALL_COMPUNITS): Remove.
11502         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11503         * cp-support.c (add_symbol_overload_list_qualified): Use
11504         objfile_compunits.
11505         * ada-lang.c (ada_collect_symbol_completion_matches)
11506         (ada_add_global_exceptions): Use objfile_compunits.
11507
11508 2019-01-09  Tom Tromey  <tom@tromey.com>
11509
11510         * source.c (select_source_symtab)
11511         (forget_cached_source_info_for_objfile): Remove declaration.
11512         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11513         declaration.
11514         * maint.c (count_symtabs_and_blocks): Remove declaration.
11515         * cp-support.c (add_symbol_overload_list_qualified): Remove
11516         declaration.
11517         * coffread.c (coff_symtab_read): Remove declaration.
11518         * symtab.c (lookup_symbol_in_objfile_symtabs)
11519         (basic_lookup_transparent_type_1): Use objfile_compunits.
11520         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11521         (info_sources_command, search_symbols)
11522         (default_collect_symbol_completion_matches_break_on)
11523         (make_source_files_completion_list): Remove declaration.
11524         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11525         (ada_collect_symbol_completion_matches)
11526         (ada_add_global_exceptions): Remove declaration.
11527         * linespec.c (iterate_over_all_matching_symtabs): Use
11528         objfile_compunits.
11529         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11530         (class objfile_compunits): New.
11531         (ALL_COMPUNITS): Use objfile_compunits.
11532         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11533         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11534         objfile_compunits.
11535         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11536
11537 2019-01-09  Tom Tromey  <tom@tromey.com>
11538
11539         * symtab.c (search_symbols)
11540         (default_collect_symbol_completion_matches_break_on): Use
11541         objfile_msymbols.
11542         * ada-lang.c (ada_lookup_simple_minsym)
11543         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11544         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11545         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11546         objfile_msymbols.
11547         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11548         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11549         * objc-lang.c (find_methods): Use objfile_msymbols.
11550         (info_selectors_command, info_classes_command): Likewise.
11551         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11552         * objfiles.h (class objfile_msymbols): New.
11553         (ALL_OBJFILE_MSYMBOLS): Remove.
11554         (ALL_MSYMBOLS): Remove.
11555
11556 2019-01-09  Tom Tromey  <tom@tromey.com>
11557
11558         * common/next-iterator.h (next_adapter): Add Iterator template
11559         parameter.
11560         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11561         (class all_objfiles_safe): New.
11562         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11563         * objfiles.c (put_objfile_before): Update comment.
11564         (add_separate_debug_objfile): Likewise.
11565         (free_all_objfiles): Use all_objfiles_safe.
11566         (objfile_purge_solibs): Likewise.
11567
11568 2019-01-09  Tom Tromey  <tom@tromey.com>
11569
11570         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11571         (expand_symtab_containing_pc, lookup_static_symbol)
11572         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11573         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11574         all_objfiles.
11575         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11576         * breakpoint.c (create_overlay_event_breakpoint)
11577         (create_longjmp_master_breakpoint)
11578         (create_std_terminate_master_breakpoint)
11579         (create_exception_master_breakpoint): Use all_objfiles.
11580         * linux-thread-db.c (try_thread_db_load_from_pdir)
11581         (has_libpthread): Use all_objfiles.
11582         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11583         * linespec.c (iterate_over_all_matching_symtabs)
11584         (search_minsyms_for_name): Use all_objfiles.
11585         * maint.c (maintenance_info_sections): Use all_objfiles.
11586         * main.c (captured_main_1): Use all_objfiles.
11587         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11588         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11589         * guile/scm-pretty-print.c
11590         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11591         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11592         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11593         (maintenance_print_msymbols): Use all_objfiles.
11594         * source.c (select_source_symtab): Use all_objfiles.
11595         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11596         * symfile.c (remove_symbol_file_command)
11597         (expand_symtabs_matching, map_symbol_filenames): Use
11598         all_objfiles.
11599         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11600         all_objfiles.
11601         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11602         * objc-lang.c (find_methods): Use all_objfiles.
11603         * objfiles.c (have_partial_symbols, have_full_symbols)
11604         (have_minimal_symbols, qsort_cmp)
11605         (default_iterate_over_objfiles_in_search_order): Use
11606         all_objfiles.
11607         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11608         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11609         (maintenance_check_psymtabs): Use all_objfiles.
11610         (ALL_PSYMTABS): Remove.
11611         * compile/compile-object-run.c (do_module_cleanup): Use
11612         all_objfiles.
11613         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11614         * cp-support.c (add_symbol_overload_list_qualified): Use
11615         all_objfiles.
11616         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11617         Use all_objfiles.
11618         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11619         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11620         all_objfiles.
11621         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11622         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11623         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11624         Uses all_objfiles.
11625         * solib.c (solib_read_symbols): Use all_objfiles
11626
11627 2019-01-09  Tom Tromey  <tom@tromey.com>
11628
11629         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11630         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11631         all_objfiles.
11632         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11633         * symmisc.c (print_symbol_bcache_statistics)
11634         (print_objfile_statistics, maintenance_print_objfiles)
11635         (maintenance_info_symtabs, maintenance_check_symtabs)
11636         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11637         all_objfiles.
11638         * source.c (forget_cached_source_info): Use all_objfiles.
11639         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11640         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11641         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11642         * objfiles.c (update_section_map): Use all_objfiles.
11643         (shared_objfile_contains_address_p): Likewise.
11644         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11645         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11646
11647 2019-01-09  Tom Tromey  <tom@tromey.com>
11648
11649         * common/next-iterator.h: New file.
11650         * objfiles.h (class all_objfiles): New.
11651         (struct objfile_iterator): New.
11652
11653 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11654
11655         * NEWS: Move the description of the changed "frame", "select-frame",
11656          and "info frame" commands to the Changed commands section.
11657
11658 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11659
11660         * gdbtypes.c (check_stub_method_group): Remove handling of old
11661         mangling schemes.
11662         * linespec.c (find_methods): Likewise.
11663         * stabsread.c (read_member_functions): Likewise.
11664         * valops.c (search_struct_method): Likewise.
11665         (value_struct_elt_for_reference): Likewise.
11666         * NEWS: Mention this change.
11667
11668 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11669
11670         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11671         print_source_lines.
11672         * source.c (print_source_lines_base): Update line number check.
11673         (print_source_lines): New function.
11674         (source_lines_range::source_lines_range): New function.
11675         * source.h (class source_lines_range): New class.
11676         (print_source_lines): New declaration.
11677
11678 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11679
11680         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11681
11682 2019-01-08  Tom Tromey  <tom@tromey.com>
11683             Simon Marchi  <simon.marchi@ericsson.com>
11684
11685         PR gdb/24060
11686         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11687         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11688         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11689         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11690         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11691         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11692
11693 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11694
11695         * source.c (select_source_symtab): Move header comment to
11696         declaration in source.h.
11697         (forget_cached_source_info_for_objfile): Likewise.
11698         (forget_cached_source_info): Likewise.
11699         (identify_source_line): Likewise.
11700         * source.h (identify_source_line): Move declaration from symtab.h
11701         and add comment from source.c
11702         (print_source_lines): Likewise.
11703         (forget_cached_source_info_for_objfile): Likewise.
11704         (forget_cached_source_info): Likewise.
11705         (select_source_symtab): Likewise.
11706         (enum print_source_lines_flag): Move definition from symtab.h.
11707         * symtab.h (identify_source_line): Move declaration to source.h.
11708         (print_source_lines): Likewise.
11709         (forget_cached_source_info_for_objfile): Likewise.
11710         (forget_cached_source_info): Likewise.
11711         (select_source_symtab): Likewise.
11712         (enum print_source_lines_flag): Move definition to source.h.
11713         * tui/tui-hooks.c: Add 'source.h' include.
11714
11715 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11716
11717         * source.c (print_source_lines_base): Handle requests to print
11718         reverse line number sequences, and guard against empty lines
11719         string.
11720
11721 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11722
11723         * source.c (print_source_lines_base): Fix skip of '\r' if next
11724         character is '\n'.
11725
11726 2019-01-06  Tom Tromey  <tom@tromey.com>
11727
11728         * c-exp.y (struct c_parse_state) <macro_original_text,
11729         expansion_obstack>: New member.
11730         (macro_original_text, expansion_obstack): Remove globals.
11731         (scan_macro_expansion, scanning_macro_expansion)
11732         (finished_macro_expansion): Update.
11733         (scan_macro_cleanup): Remove.
11734         (yylex, c_parse): Update.
11735
11736 2019-01-06  Tom Tromey  <tom@tromey.com>
11737
11738         * c-exp.y (struct c_parse_state) <strings>: New member.
11739         (operator_stoken): Update.
11740
11741 2019-01-06  Tom Tromey  <tom@tromey.com>
11742
11743         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11744         (union type_stack_elt) <typelist_val>: Now a pointer to
11745         std::vector.
11746         (type_stack_cleanup): Don't declare.
11747         (push_typelist): Update.
11748         * parse.c (pop_typelist): Return a std::vector.
11749         (push_typelist): Take a std::vector.
11750         (follow_types): Update.  Do not free args.
11751         (type_stack_cleanup): Remove.
11752         * c-exp.y (struct c_parse_state): New.
11753         (cpstate): New global.
11754         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11755         (nonempty_typelist): Update.
11756         (func_mod): Create a new vector.
11757         (c_parse): Create a c_parse_state.
11758         (check_parameter_typelist): Do not delete params.
11759         (function_method): Update.  Do not delete type_list.
11760
11761 2019-01-06  Tom Tromey  <tom@tromey.com>
11762
11763         PR gdb/28155:
11764         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11765         check_typedef.
11766         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11767         (print_return_value): Likewise.
11768
11769 2019-01-05  Tom Tromey  <tom@tromey.com>
11770
11771         * contrib/cleanup_check.py: Remove.
11772         * contrib/gcc-with-excheck: Remove.
11773         * contrib/exsummary.py: Remove.
11774         * contrib/excheck.py: Remove.
11775
11776 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11777
11778         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11779         NULL. Initialize tpprev to NULL instead of assigning it
11780         to NULL on the next statement.
11781         * windows-nat.c (windows_delete_thread): Remove check for
11782         main_thread_id before printing thread exit notifications.
11783         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11784         Remove thread ID check against main_thread_id.
11785         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11786         windows_delete_thread.
11787         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11788
11789 2019-01-04  Tom Tromey  <tom@tromey.com>
11790
11791         * compile/compile.c (_initialize_compile): Use upper case for
11792         metasyntactic variables.
11793         * symmisc.c (_initialize_symmisc): Use upper case for
11794         metasyntactic variables.
11795         * psymtab.c (_initialize_psymtab): Use upper case for
11796         metasyntactic variables.
11797         * demangle.c (demangle_command): Use upper case for metasyntactic
11798         variables.
11799         (_initialize_demangler): Likewise.
11800         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11801         variables.
11802
11803 2019-01-03  Tom Tromey  <tom@tromey.com>
11804
11805         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11806
11807 2019-01-03  Tom Tromey  <tom@tromey.com>
11808
11809         * python/py-symtab.c (salpy_str): Update.
11810         (struct salpy_sal_object) <symtab>: Now a PyObject.
11811         (salpy_dealloc): Update.
11812         (del_objfile_sal): Use gdbpy_ref.
11813
11814 2019-01-03  Tom Tromey  <tom@tromey.com>
11815
11816         * python/py-type.c (convert_field): Use new_reference.  Return
11817         gdbpy_ref.
11818         (make_fielditem): Return gdbpy_ref.
11819         (typy_fields): Update.
11820         (typy_getitem): Update.
11821         (field_name): Return gdbpy_ref.  Use new_reference.
11822         (typy_iterator_iternext): Update.
11823
11824 2019-01-03  Tom Tromey  <tom@tromey.com>
11825
11826         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11827
11828 2019-01-03  Tom Tromey  <tom@tromey.com>
11829
11830         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11831         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11832         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11833         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11834         (pspy_set_type_printers): Likewise.
11835         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11836         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11837         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11838         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11839         (objfpy_set_type_printers): Likewise.
11840
11841 2019-01-03  Tom Tromey  <tom@tromey.com>
11842
11843         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11844         (gdbpy_print_stack): Use gdbpy_err_fetch.
11845         * python/python-internal.h (class gdbpy_err_fetch): New class.
11846         (class gdbpy_enter) <m_error_type, m_error_value,
11847         m_error_traceback>: Remove.
11848         <m_error>: New member.
11849         (gdbpy_exception_to_string): Don't declare.
11850         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11851         * python/py-value.c (convert_value_from_python): Use
11852         gdbpy_err_fetch.
11853         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11854         gdbpy_exception_to_string.
11855         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11856         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11857         gdbpy_err_fetch.
11858
11859 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11860
11861         * linux-nat.c (delete_lwp_cleanup): Delete.
11862         (struct lwp_deleter): New struct.
11863         (lwp_info_up): New typedef.
11864         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11865         lwp_info_up.
11866
11867 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11868
11869         * linux-fork.c (class scoped_switch_fork_info): New class.
11870         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11871
11872 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11873
11874         * valops.c (find_overload_match): Remove use of null_cleanup, and
11875         calls to do_cleanups.
11876
11877 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11878
11879         * compile/compile-cplus-types.c
11880         (compile_cplus_instance::decl_name): Handle changes to
11881         cp_func_name.
11882         * cp-support.c (cp_func_name): Update header comment, update
11883         return type.
11884         * cp-support.h (cp_func_name): Update return type in declaration.
11885         * valops.c (find_overload_match): Move temp_func local to top
11886         level of function and change its type.  Use temp_func to hold and
11887         delete temporary string obtained from cp_func_name.
11888
11889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11890
11891         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11892         gdb::char_vector, remove cleanup, and update uses of `msg`.
11893
11894 2019-01-03  Jim Wilson  <jimw@sifive.com>
11895
11896         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11897
11898 2019-01-02  Tom Tromey  <tom@tromey.com>
11899
11900         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11901         (tdesc_parse_xml): Remove cleanups.
11902         * target-descriptions.h (make_cleanup_free_target_description):
11903         Don't declare.
11904         (target_desc_deleter): New struct.
11905         (target_desc_up): New typedef.
11906         * target-descriptions.c (target_desc_deleter::operator()): Rename
11907         from free_target_description.
11908         (make_cleanup_free_target_description): Remove.
11909
11910 2019-01-02  Tom Tromey  <tom@tromey.com>
11911
11912         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11913         constructor, destructor.
11914         (linespec_parser): Remove typedef.
11915         (~linespec_parser): Rename from linespec_parser_delete.
11916         (linespec_lex_to_end, linespec_complete_label)
11917         (linespec_complete): Update.
11918         (decode_line_full): Remove cleanups.
11919         (decode_line_1): Update.
11920
11921 2019-01-02  Tom Tromey  <tom@tromey.com>
11922
11923         * python/python-internal.h (inferior_to_inferior_object): Change
11924         return type.
11925         * python/py-exitedevent.c (create_exited_event_object): Update.
11926         * python/py-inferior.c (inferior_to_inferior_object): Return
11927         gdbpy_ref.
11928         (python_new_inferior, python_inferior_deleted)
11929         (thread_to_thread_object, delete_thread_object)
11930         (build_inferior_list, gdbpy_selected_inferior): Update.
11931         * python/py-infthread.c (create_thread_object): Update.  Also fail
11932         if inferior_to_inferior_object fails.
11933
11934 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11935
11936         * inferior.h (class inferior) <displaced_step_state>: New field.
11937         * infrun.h (struct displaced_step_state): Move here from
11938         infrun.c.  Initialize fields, add constructor.
11939         <inf>: Remove field.
11940         <reset>: New method.
11941         * infrun.c (struct displaced_step_inferior_state): Move to
11942         infrun.h.
11943         (displaced_step_inferior_states): Remove.
11944         (get_displaced_stepping_state): Adust.
11945         (displaced_step_in_progress_any_inferior): Adjust.
11946         (displaced_step_in_progress_thread): Adjust.
11947         (displaced_step_in_progress): Adjust.
11948         (add_displaced_stepping_state): Remove.
11949         (get_displaced_step_closure_by_addr): Adjust.
11950         (remove_displaced_stepping_state): Remove.
11951         (infrun_inferior_exit): Call displaced_step_state.reset.
11952         (use_displaced_stepping): Don't check for NULL.
11953         (displaced_step_prepare_throw): Call
11954         get_displaced_stepping_state.
11955         (displaced_step_fixup): Don't check for NULL.
11956         (prepare_for_detach): Don't check for NULL.
11957
11958 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11959
11960         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11961          in case of call that did not complete.
11962
11963 2019-01-02  Andrey Utkin  <autkin@undo.io>
11964
11965         * symfile.c (find_separate_debug_file): Fix search of debug files for
11966         remote debuggee.
11967
11968 2019-01-02  Tom Tromey  <tom@tromey.com>
11969
11970         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11971         indentation.
11972         * python/py-frame.c (frapy_older): Remove cast.
11973         (frapy_newer): Likewise.
11974         * python/py-breakpoint.c (local_setattro): Remove cast.
11975         * python/py-arch.c (archpy_name): Remove local variable.
11976         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11977
11978 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11979
11980         * unittests/basic_string_view/element_access/char/empty.cc:
11981         Fix year range in copyright header.
11982
11983 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11984
11985         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11986         Delete.
11987         <operator==>: Update with for removed field.
11988         <hash>: Likewise.
11989         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11990         <isa_features>: ...this.
11991         <abi_features>: New field.
11992         (riscv_isa_flen): Update comment.
11993         (riscv_abi_xlen): New declaration.
11994         (riscv_abi_flen): New declaration.
11995         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11996         isa_features.
11997         (riscv_abi_xlen): New function.
11998         (riscv_isa_flen): Update to get answer from isa_features.
11999         (riscv_abi_flen): New function.
12000         (riscv_has_fp_abi): Update to get answer from abi_features.
12001         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12002         xlen and flen.
12003         (riscv_call_info) <xlen, flen>: Update comment.
12004         (riscv_call_arg_struct): Remove invalid assertions
12005         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12006         is removed.
12007         (riscv_gdbarch_init): Gather isa features and abi features
12008         separately, ensure both match on the gdbarch when reusing an old
12009         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12010         a target with 64-bit float hardware.
12011
12012 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12013
12014         * source.c (search_command_helper): Stop reverse search
12015         when line 1 has been searched.
12016
12017 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12018
12019         * record-full.c (record_full_base_target::close): Rewrite
12020         record_full_core_buf_list free logic.
12021
12022 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12023
12024         * break-catch-syscall.c (print_one_catch_syscall): xfree
12025         the last text.
12026
12027 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12028
12029         * top.c (print_gdb_version): Update Copyright year in version
12030         message.
12031
12032 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12033
12034         Update copyright year range in all GDB files.
12035
12036 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12037
12038         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12039
12040 For older changes see ChangeLog-2018.
12041 \f
12042 Local Variables:
12043 mode: change-log
12044 left-margin: 8
12045 fill-column: 74
12046 version-control: never
12047 coding: utf-8
12048 End:
12049