gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <regs_content,
   4         regs_column_count, current_group>: Move later.  Now private.
   5         <get_current_group>: New method.
   6         * tui/tui-regs.c (tui_reg_command): Update.
   7         * tui/tui-layout.c (tui_set_layout): Update.
   8
   9 2019-08-30  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  12         (tui_data_window::rerender): Don't call
  13         check_and_display_highlight_if_needed.
  14         (tui_data_window::refresh_all): Remove call to
  15         erase_data_content.
  16
  17 2019-08-30  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  20         (tui_data_window::display_registers_from)
  21         (tui_data_window::display_reg_element_at_line)
  22         (tui_data_window::display_registers_from_line): Remove checks of
  23         "empty".
  24
  25 2019-08-30  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  28         Don't declare.
  29         * tui/tui-regs.c (tui_data_window::show_registers): Call
  30         rerender.
  31         (tui_data_window::rerender): Rename from display_all_data.
  32         (tui_data_window::rerender): Remove old implementation.
  33
  34 2019-08-30  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  37         text.
  38         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  39
  40 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  41             Sergio Durigan Junior  <sergiodj@redhat.com>
  42
  43         PR win32/24284
  44         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  45
  46 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  47
  48         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  49         when searching for types.
  50
  51 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  52
  53         * f-lang.c (f_language_defn): Use f_print_typedef.
  54         * f-lang.h (f_print_typedef): Declare.
  55         * f-typeprint.c (f_print_typedef): Define.
  56
  57 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  58
  59         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  60
  61 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  62
  63         * cli/cli-utils.c (info_print_options_defs): Delete.
  64         (make_info_print_options_def_group): Delete.
  65         (extract_info_print_options): Delete.
  66         (info_print_command_completer): Delete.
  67         (info_print_args_help): Add extra parameter, and optionally
  68         include text about -n flag.
  69         * cli/cli-utils.h (struct info_print_options): Delete.
  70         (extract_info_print_options): Delete declaration.
  71         (info_print_command_completer): Delete declaration.
  72         (info_print_args_help): Add extra parameter, extend header
  73         comment.
  74         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  75         search_symbols.
  76         * stack.c (struct info_print_options): New type.
  77         (info_print_options_defs): New file scoped variable.
  78         (make_info_print_options_def_group): New static function.
  79         (info_print_command_completer): New static function.
  80         (info_locals_command): Update to use new local functions.
  81         (info_args_command): Likewise.
  82         (_initialize_stack): Add extra parameter to calls to
  83         info_print_args_help.
  84         * symtab.c (search_symbols): Add extra parameter, use this to
  85         possibly excluse non-debug symbols.
  86         (symtab_symbol_info): Add extra parameter, which is passed on to
  87         search_symbols.
  88         (struct info_print_options): New type.
  89         (info_print_options_defs): New file scoped variable.
  90         (make_info_print_options_def_group): New static function.
  91         (info_print_command_completer): New static function.
  92         (info_variables_command): Update to use local functions, and pass
  93         extra parameter through to symtab_symbol_info.
  94         (info_functions_command): Likewise.
  95         (info_types_command): Pass additional argument through to
  96         symtab_symbol_info.
  97         (rbreak_command): Pass extra argument to search_symbols.
  98         (_initialize_symtab): Add extra arguments for calls to
  99         info_print_args_help, and update help text for 'info variables',
 100         'whereis', and 'info functions' commands.
 101         * symtab.h (search_symbols): Add extra argument to declaration.
 102         * NEWS: Mention new flags.
 103
 104 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 105
 106         * symtab.c (lookup_static_symbol): Call the new function (and move
 107         it down to be next to lookup_global_symbol).
 108         (struct global_sym_lookup_data): Add block_enum member and rename to...
 109         (struct global_or_static_sym_lookup_data): ...this.
 110         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 111         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 112         (lookup_symbol_global_or_static_iterator_cb): ...this.
 113         (lookup_global_or_static_symbol): New function.
 114         (lookup_global_symbol): Call new function.
 115
 116 2019-08-26  Tom de Vries  <tdevries@suse.de>
 117
 118         PR c++/24852
 119         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 120         when pc_probe.prob == NULL.
 121
 122 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 123
 124         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 125         variable symbol_linkage to symbol_linkage_.
 126
 127 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 128
 129         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 130         represent whether the symbol is static, dynamic, or we don't
 131         know.
 132
 133 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 134
 135         * gdb/rx-tdep.c (rx_register_names): New.
 136         (rx_register_name): Delete.
 137         (rx_psw_type): Delete.
 138         (rx_fpsw_type): Delete.
 139         (rx_register_type): Delete.
 140         (rx_gdbarch_init): Convert target-descriptions.
 141         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 142         * gdb/features/Makefile: Add rx.xml.
 143         * gdb/features/rx.xml: New.
 144         * gdb/features/rx.c: Generated.
 145         * gdb/NEWS: Mention target description support.
 146
 147 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 148
 149         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 150         *slot_ptr.
 151
 152 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 153
 154         * configure.ac: Don't check for 'dlfcn.h' (moved to
 155         gdbsupport/common.m4).
 156         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 157         'gdbsupport/'.
 158         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 159         * compile/compile-c-support.c: Include
 160         'gdbsupport/gdb-dlfcn.h'.
 161         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 162         * gdb-dlfcn.c: Move to...
 163         * gdbsupport/gdb-dlfcn.c: ... here.
 164         * gdb-dlfcn.h: Move to...
 165         * gdbsupport/gdb-dlfcn.h: ... here.
 166
 167 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 168
 169         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 170         the offset field signed.
 171
 172 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 173
 174         * python/lib/gdb/__init__.py (_execute_file): New function.
 175         * python/python.c (python_run_simple_file): Call gdb._execute_file
 176         on Windows.
 177
 178 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 179
 180         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 181         all uses as this was never set to anything but a zero value.
 182
 183 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 184
 185         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 186
 187 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 188
 189         * tui/tui-data.h (tui_gen_win_info): Add an =default
 190         move constructor, required by some GCC versions.
 191
 192 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 193
 194         * go32-nat.c (go32_sysinfo): Add hygon_p.
 195
 196 2019-08-20  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 199         line_from_reg_element_no, first_reg_element_no_inline,
 200         display_all_data, delete_data_content_windows,
 201         erase_data_content>: Now private.
 202
 203 2019-08-20  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 206         (tui_unhighlight_win, tui_highlight_win)
 207         (tui_win_info::make_window): Update.
 208         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 209
 210 2019-08-20  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 213         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 214         (MAX_PID_WIDTH): Move to tui-stack.c.
 215         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 216         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 217         (MAX_PID_WIDTH): Move from tui-data.h.
 218
 219 2019-08-20  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 222         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 223         (box_win): Update.
 224         (tui_gen_win_info::make_window): Rename from tui_make_window.
 225         (tui_win_info::make_window): New method.
 226         (tui_gen_win_info::make_visible): Update.
 227         * tui/tui-source.c (tui_source_window::set_contents): Update.
 228         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 229         (tui_data_window::display_registers_from): Update.
 230         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 231         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 232         Declare.
 233         <can_box>: Remove.
 234         <title>: Remove.
 235         (struct tui_win_info) <make_window>: Declare.
 236         <can_box>: Now virtual.
 237         <title>: New member.
 238         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 239         * tui/tui-command.c (tui_cmd_window::resize): Update.
 240
 241 2019-08-20  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 244         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 245         (tui_data_window::check_register_values): Update.
 246
 247 2019-08-20  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-regs.h (struct tui_data_window): Use
 250         DISABLE_COPY_AND_ASSIGN.
 251         <regs_content>: Change type, removing unique_ptr.
 252         <tui_data_window>: Add move constructor.
 253         * tui/tui-regs.c (tui_data_window::show_registers)
 254         (tui_data_window::show_register_group)
 255         (tui_data_window::display_registers_from)
 256         (tui_data_window::display_registers_from)
 257         (tui_data_window::first_data_item_displayed)
 258         (tui_data_window::delete_data_content_windows)
 259         (tui_data_window::rerender, tui_data_window::refresh_window)
 260         (tui_data_window::check_register_values): Update.
 261
 262 2019-08-20  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 265         show_register_group>: Declare.
 266         (tui_show_register_group): Don't declare.
 267         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 268         tui_show_registers.
 269         (tui_data_window::show_register_group): Rename from
 270         tui_show_register_group.
 271         (tui_data_window::check_register_values, tui_reg_command):
 272         Update.
 273         * tui/tui-layout.c (tui_set_layout): Update.
 274
 275 2019-08-20  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 278         Declare.
 279         (tui_check_register_values): Don't declare.
 280         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 281         from tui_check_register_values.
 282         * tui/tui-hooks.c (tui_register_changed): Update.
 283
 284 2019-08-20  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-regs.c (tui_reg_layout): Move later.
 287         (tui_show_registers): Don't enable TUI mode or change layout.
 288
 289 2019-08-20  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-regs.h (struct tui_data_item_window)
 292         <~tui_data_item_window>: Remove.
 293         <content>: Now a unique_xmalloc_ptr.
 294         * tui/tui-regs.c (tui_register_format): Return a
 295         unique_xmalloc_ptr.
 296         (tui_get_register): Update.
 297         (~tui_data_item_window): Remove.
 298         (tui_data_window::display_registers_from, tui_display_register):
 299         Update.
 300         * tui/tui-io.h (tui_expand_tabs): Update.
 301         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 302         Remove "col" parameter.
 303
 304 2019-08-20  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 307         field.
 308         * tui/tui-regs.c (~tui_data_item_window): Update.
 309
 310 2019-08-20  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 313         earlier.
 314
 315 2019-08-20  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 318
 319 2019-08-20  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-source.h (struct tui_source_window): Update.
 322         * tui/tui-regs.c (tui_show_registers): Update.
 323         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 324         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 325         (NO_REGS_STRING): Remove defines.
 326
 327 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 328
 329         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 330         unnecessary thread walk if remote doesn't support the packet.
 331
 332 2019-08-19  Tom Tromey  <tromey@adacore.com>
 333
 334         * python/py-value.c (value_has_field): Fix indentation.
 335
 336 2019-08-19  Tom Tromey  <tromey@adacore.com>
 337
 338         * printcmd.c (do_one_display, info_display_command): Update.
 339         * block.h (contained_in): Return bool.  Add allow_nested
 340         parameter.
 341         * block.c (contained_in): Return bool.  Add allow_nested
 342         parameter.
 343
 344 2019-08-19  Tom Tromey  <tom@tromey.com>
 345
 346         * configure: Rebuild.
 347         * configure.ac: Disallow the combination of -static-libstdc++ and
 348         source highlight.
 349         * source-cache.c (get_language_name): Handle rust.
 350         (source_cache::get_source_lines): Ignore highlighting exceptions.
 351
 352 2019-08-16  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 355         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 356         (struct tui_source_window_base) <make_visible, refresh_window,
 357         resize>: Remove methods.
 358         <execution_info>: Remove field.
 359         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 360         (tui_show_source_line, tui_source_window_base)
 361         (~tui_source_window_base): Update.
 362         (tui_source_window_base::resize)
 363         (tui_source_window_base::make_visible)
 364         (tui_source_window_base::refresh_window): Remove.
 365         (tui_source_window_base::update_exec_info): Update.
 366         * tui/tui-source.c (tui_source_window::set_contents): Update.
 367         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 368
 369 2019-08-16  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 372         deprecated_query_hook.
 373
 374 2019-08-16  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 377         (tui_update_source_windows_with_line): Update.
 378         * tui/tui-source.h (struct tui_source_window)
 379         <show_symtab_source>: Declare.
 380         (tui_show_symtab_source): Don't declare.
 381         * tui/tui-source.c (tui_show_symtab_source): Rename from
 382         tui_show_symtab_source.
 383
 384 2019-08-16  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-winsource.h (struct tui_source_window_base)
 387         <set_contents>: Declare.
 388         * tui/tui-winsource.c
 389         (tui_source_window_base::update_source_window_as_is): Update.
 390         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 391         Declare.
 392         (tui_set_source_content): Don't declare.
 393         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 394         tui_set_source_content.
 395         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 396         Declare.
 397         (tui_set_disassem_content): Don't declare.
 398         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 399         tui_set_disassem_content.
 400
 401 2019-08-16  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-winsource.h (struct tui_source_window_base)
 404         <update_breakpoint_info>: Declare.
 405         (tui_update_breakpoint_info): Don't declare.
 406         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 407         (tui_update_all_breakpoint_info): Update.
 408         (tui_source_window_base::update_breakpoint_info): Rename from
 409         tui_update_breakpoint_info.
 410         (tui_source_window_base::update_exec_info): Update.
 411
 412 2019-08-16  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-winsource.h (struct tui_source_window_base)
 415         <update_source_window>: Declare.
 416         (tui_update_source_window): Don't declare.
 417         * tui/tui-winsource.c
 418         (tui_source_window_base::update_source_window): Rename from
 419         tui_update_source_window.
 420         (tui_source_window_base::rerender): Update.
 421         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 422         * tui/tui-disasm.c (tui_show_disassem)
 423         (tui_show_disassem_and_update_source)
 424         (tui_disasm_window::maybe_update): Update.
 425
 426 2019-08-16  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-winsource.h (struct tui_source_window_base)
 429         <update_source_window_as_is>: Declare.
 430         (tui_update_source_window_as_is): Don't declare.
 431         * tui/tui-winsource.c (tui_update_source_window): Update
 432         (tui_source_window_base::update_source_window_as_is): Rename from
 433         tui_update_source_window_as_is.
 434         (tui_source_window_base::refill): Update.
 435         * tui/tui-source.c (tui_show_symtab_source): Update.
 436         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 437         Update.
 438
 439 2019-08-16  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-winsource.h (tui_update_source_window)
 442         (tui_update_source_window_as_is): Remove "noerror" parameter.
 443         * tui/tui-winsource.c (tui_update_source_window)
 444         (tui_update_source_window_as_is): Remove "noerror" parameter.
 445         (tui_update_source_windows_with_addr)
 446         (tui_update_source_windows_with_line)
 447         (tui_source_window_base::rerender)
 448         (tui_source_window_base::refill): Update.
 449         * tui/tui-source.h (tui_set_source_content)
 450         (tui_show_symtab_source): Remove "noerror" parameter.
 451         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 452         parameter.
 453         (tui_show_symtab_source): Likewise.
 454         (tui_source_window::maybe_update): Update.
 455         * tui/tui-disasm.c (tui_show_disassem)
 456         (tui_show_disassem_and_update_source)
 457         (tui_disasm_window::do_scroll_vertical)
 458         (tui_disasm_window::maybe_update): Update.
 459
 460 2019-08-16  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui.c (tui_is_window_visible): Update.
 463         * tui/tui-wingeneral.c (tui_make_window)
 464         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 465         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 466         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 467         (tui_set_win_height_command, parse_scrolling_args): Update.
 468         * tui/tui-source.c (tui_source_window::style_changed): Update.
 469         * tui/tui-regs.c (tui_show_registers)
 470         (tui_data_window::first_data_item_displayed)
 471         (tui_data_window::delete_data_content_windows)
 472         (tui_check_register_values, tui_reg_command): Update.
 473         * tui/tui-disasm.c (tui_show_disassem): Update.
 474         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 475         method.
 476         <is_visible>: Remove field.
 477         * tui/tui-data.c (tui_next_win, tui_prev_win)
 478         (tui_delete_invisible_windows): Update.
 479
 480 2019-08-16  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-winsource.h (struct tui_source_window_base)
 483         <m_has_locator>: Remove.
 484         * tui/tui-layout.c (show_source_disasm_command, show_data)
 485         (show_source_or_disasm_and_command): Update.
 486
 487 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 488
 489         * NEWS (Other MI changes): New subsection.
 490         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 491         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 492         * arch-utils.c (default_get_pc_address_flags): New function.
 493         * arch-utils.h (default_get_pc_address_flags): New declaration.
 494         * gdbarch.sh: Add get_pc_address_flags.
 495         * gdbarch.c: Regenerate.
 496         * gdbarch.h: Likewise.
 497         * stack.c (print_pc): New function.
 498         (print_frame_info) (print_frame): Call print_pc.
 499
 500 2019-08-16  Tom de Vries  <tdevries@suse.de>
 501
 502         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 503         print_objfile_section_info.
 504
 505 2019-08-15  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 508         calling update_cmdwin_start_line.
 509         * tui/tui-winsource.h (struct tui_source_window_base)
 510         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 511         <rerender>: Declare.
 512         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 513         Call rerender.
 514         (tui_source_window_base::set_new_height): Remove.
 515         (tui_source_window_base::rerender): Rename from
 516         do_make_visible_with_new_height.
 517         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 518         resize method.
 519         (tui_win_info::make_invisible_and_set_new_height)
 520         (tui_win_info::make_visible_with_new_height): Remove.
 521         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 522         Declare.
 523         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 524         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 525         do_make_visible_with_new_height>: Don't declare.
 526         <rerender>: Declare.
 527         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 528         set_new_height.
 529         (tui_data_window::do_make_visible_with_new_height): Remove.
 530         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 531         call tui_show_locator_content.
 532         (tui_gen_win_info::resize): Call rerender.
 533         (show_source_or_disasm_and_command): Don't call
 534         tui_show_locator_content.
 535         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 536         method.
 537         (struct tui_win_info) <rerender>: Declare.
 538         <set_new_height, make_invisible_and_set_new_height,
 539         make_visible_with_new_height>: Don't declare.
 540         * tui/tui-data.c (tui_win_list::rerender): New method.
 541         * tui/tui-command.h (struct tui_cmd_window)
 542         <do_make_visible_with_new_height>: Don't declare.
 543         * tui/tui-command.c
 544         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 545
 546 2019-08-15  Tom Tromey  <tromey@adacore.com>
 547
 548         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 549         * ada-lang.c (ada_enum_name): Likewise.
 550
 551 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 552
 553         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 554         leading underscore.
 555         (GdbOutputErrorFile): Likewise.
 556         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 557         accordingly.
 558         (execute_unwinders): Rename to have a leading underscore.
 559         (auto_load_packages): Likewise.
 560         (global scope): Adjust call to auto_load_packages accordingly.
 561         (GdbSetPythonDirectory): Likewise.
 562         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 563         instead of execute_unwinders.
 564
 565 2019-08-15  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 568         (show_data): Don't change window visibility.
 569         (tui_gen_win_info::resize): Remove special case for command
 570         window.  Use wresize, when available.
 571         (show_source_or_disasm_and_command): Don't change window
 572         visibility.
 573         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 574         <make_visible>: New method.
 575         * tui/tui-command.c (tui_cmd_window::resize): New method.
 576
 577 2019-08-15  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 580         (struct tui_source_windows): New.
 581         * tui/tui-winsource.c (tui_display_main): Update.
 582         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 583         (new_height_ok, parse_scrolling_args): Update.
 584         * tui/tui-layout.c (show_layout, show_data): Update.
 585         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 586         (tui_add_to_source_windows): Don't declare.
 587         * tui/tui-data.c (source_windows, tui_source_windows)
 588         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 589
 590 2019-08-15  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 593         Rename from reset.
 594         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 595         * tui/tui-layout.c (show_source_disasm_command, show_data):
 596         Update.
 597         (tui_gen_win_info::resize): Rename.
 598         (show_source_or_disasm_and_command): Update.
 599         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 600         reset.
 601
 602 2019-08-15  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 605         * tui/tui-interp.c (tui_interp::init): Don't call
 606         tui_initialize_static_data.
 607         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 608
 609 2019-08-15  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 612         examine tui_win_list.
 613
 614 2019-08-15  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 617         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 618         tui_clear_source_content.
 619         (tui_clear_source_content): Remove.
 620         (tui_source_window_base::do_erase_source_content): Hoist call to
 621         content.clear().
 622         * tui/tui-stack.c (tui_show_frame_info): Don't call
 623         tui_clear_source_content.
 624
 625 2019-08-15  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-winsource.h (struct tui_source_window_base)
 628         <do_erase_source_content>: New method.
 629         <erase_source_content>: New method.
 630         (tui_erase_source_content): Don't declare.
 631         * tui/tui-winsource.c (tui_clear_source_content): Update.
 632         (tui_source_window_base::do_erase_source_content): Rename from
 633         tui_erase_source_content.
 634         (tui_source_window_base::show_source_content): Update.
 635         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 636         * tui/tui-source.h (struct tui_source_window)
 637         <erase_source_content>: New method.
 638         * tui/tui-disasm.h (struct tui_disasm_window)
 639         <erase_source_content>: New method.
 640
 641 2019-08-15  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 644         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 645         constructor.
 646         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 647         * tui/tui-source.c (tui_set_source_content): Update.
 648         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 649
 650 2019-08-15  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 653         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 654         tui-source.c.
 655         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 656         Declare.
 657         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 658         method.
 659         (tui_source_window::maybe_update): Update.
 660
 661 2019-08-15  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 664         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 665         tui-disasm.c.
 666         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 667         Declare.
 668         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 669         method.
 670         (tui_disasm_window::maybe_update): Update.
 671
 672 2019-08-15  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-winsource.h (struct tui_source_window_base)
 675         <maybe_update>: Declare.
 676         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 677         method.
 678         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 679         Declare.
 680         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 681         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 682         Declare.
 683         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 684
 685 2019-08-15  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 688
 689 2019-08-15  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-wingeneral.c: Include tui-stack.h.
 692         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 693         (struct tui_locator_window): Move from tui-data.h.
 694         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 695         (tui_initialize_static_data): Move from tui-data.c.
 696         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 697         (struct tui_locator_window): Move to tui-stack.c.
 698         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 699         (tui_initialize_static_data): Move to tui-stack.c.
 700
 701 2019-08-15  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-layout.c (show_source_disasm_command)
 704         (show_source_or_disasm_and_command): Use make_visible method, not
 705         tui_make_window.
 706         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 707         Remove.
 708
 709 2019-08-15  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-wingeneral.h (tui_make_window): Update.
 712         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 713         parameter.
 714         (tui_gen_win_info::make_visible): Update.
 715         * tui/tui-regs.c (tui_data_window::display_registers_from):
 716         Update.
 717         * tui/tui-layout.c (show_source_disasm_command)
 718         (show_source_or_disasm_and_command): Update.
 719         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 720         (enum tui_box): Remove.
 721         (struct tui_win_info) <can_box>: New method.
 722         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 723         method.
 724
 725 2019-08-15  Tom de Vries  <tdevries@suse.de>
 726
 727         * linux-nat-trad.c: Include gdbarch.h.
 728
 729 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 730
 731         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 732         register sizes.
 733
 734 2019-08-14  Tom Tromey  <tromey@adacore.com>
 735
 736         * darwin-nat.c: Include gdbarch.h.
 737         * darwin-nat-info.c: Include gdbarch.h.
 738
 739 2019-08-13  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 742         Remove.
 743         * tui/tui-data.c (tui_initialize_static_data): Update.
 744
 745 2019-08-13  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-winsource.h (struct tui_exec_info_window)
 748         <~tui_exec_info_window, maybe_allocate_content, get_content,
 749         m_content>: Remove.
 750         (struct tui_source_window_base) <set_exec_info_content,
 751         show_exec_info_content>: Don't declare.
 752         * tui/tui-winsource.c
 753         (tui_exec_info_window::maybe_allocate_content): Remove.
 754         (tui_source_window_base::update_exec_info): Rename from
 755         set_exec_info_content.
 756         (tui_source_window_base::show_exec_info_content)
 757         (tui_source_window_base::update_exec_info): Remove.
 758
 759 2019-08-13  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 762         declare.
 763         * tui/tui-winsource.c (tui_update_source_window_as_is)
 764         (tui_update_source_windows_with_addr, tui_erase_source_content):
 765         Update.
 766         (tui_clear_exec_info_content): Remove.
 767
 768 2019-08-13  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 771         declare.
 772         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 773         call tui_erase_exec_info_content.
 774         (tui_clear_exec_info_content): Rename from
 775         tui_erase_exec_info_content.
 776         (tui_clear_exec_info_content): Delete.
 777
 778 2019-08-13  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-winsource.h (struct tui_source_window_base)
 781         <show_exec_info_content>: Declare.
 782         (tui_show_exec_info_content): Don't declare.
 783         * tui/tui-winsource.c
 784         (tui_source_window_base::show_exec_info_content): Rename from
 785         tui_show_exec_info_content.
 786         (tui_source_window_base::update_exec_info): Update.
 787
 788 2019-08-13  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 791         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 792         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 793         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 794         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 795         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 796         ... here.
 797
 798 2019-08-13  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-winsource.h (struct tui_source_window_base)
 801         <update_exec_info>: Declare.
 802         (tui_update_exec_info): Don't declare.
 803         * tui/tui-winsource.c (tui_update_source_window_as_is)
 804         (tui_source_window_base::refresh_all)
 805         (tui_update_all_breakpoint_info): Update.
 806         (tui_source_window_base::update_exec_info): Rename from
 807         tui_update_exec_info.
 808         * tui/tui-stack.c (tui_show_frame_info): Update.
 809
 810 2019-08-13  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-winsource.h (struct tui_source_window_base)
 813         <set_exec_info_content>: Declare.
 814         (tui_set_exec_info_content): Don't declare.
 815         * tui/tui-winsource.c
 816         (tui_source_window_base::set_exec_info_content): Rename from
 817         tui_set_exec_info_content.
 818         (tui_update_exec_info): Update.
 819
 820 2019-08-13  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-winsource.h (struct tui_source_window_base)
 823         <show_source_content>: Declare.
 824         (tui_show_source_content): Don't declare.
 825         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 826         (tui_source_window_base::show_source_content): Rename from
 827         tui_show_source_content.
 828         (tui_source_window_base::refresh_all): Update.
 829         * tui/tui-layout.c (show_source_disasm_command)
 830         (show_source_or_disasm_and_command): Update.
 831
 832 2019-08-13  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-winsource.c (tui_erase_source_content)
 835         (tui_show_source_content, tui_source_window_base::refresh_all):
 836         Update.
 837         * tui/tui-wingeneral.h
 838         (tui_check_and_display_highlight_if_needed): Don't declare.
 839         * tui/tui-wingeneral.c
 840         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 841         check_and_display_highlight_if_needed.
 842         * tui/tui-win.c (tui_rehighlight_all)
 843         (tui_win_info::make_visible_with_new_height): Update.
 844         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 845         (tui_data_window::erase_data_content)
 846         (tui_data_window::display_all_data): Update.
 847         * tui/tui-data.h (struct tui_win_info)
 848         <check_and_display_highlight_if_needed>: Declare.
 849
 850 2019-08-13  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-win.c (tui_resize_all): Call
 853         tui_delete_invisible_windows.
 854         * tui/tui-layout.c (show_layout): Call
 855         tui_delete_invisible_windows.
 856         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 857         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 858
 859 2019-08-13  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 862         tui_add_win_to_layout.
 863
 864 2019-08-13  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 867         * tui/tui-layout.c (tui_default_win_height): Now static.
 868
 869 2019-08-13  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 872         single switch.
 873         (show_source_disasm_command, show_source_or_disasm_and_command):
 874         Don't check current layout.
 875
 876 2019-08-13  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-wingeneral.c (make_all_visible): Remove.
 879         (tui_make_all_invisible): Simplify.
 880         * tui/tui-layout.c (tui_make_all_invisible): Move from
 881         tui-wingeneral.c; simplify.
 882         (show_layout): Hoist call to tui_make_all_invisible.
 883         (show_data): Don't call tui_make_all_invisible.
 884
 885 2019-08-13  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 888         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 889
 890 2019-08-13  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 893         tui-data.c.
 894         (show_source_disasm_command, show_data)
 895         (show_source_or_disasm_and_command): Don't use
 896         tui_set_current_layout_to.
 897         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 898         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 899         tui-layout.c.
 900         (tui_set_current_layout_to): Remove.
 901
 902 2019-08-13  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-layout.c (tui_set_layout): Update.
 905         * tui/tui-data.h (struct tui_layout_def): Remove.
 906         (tui_layout_def): Don't declare.
 907         * tui/tui-data.c (layout_def): Remove.
 908         (tui_layout_def): Remove.
 909
 910 2019-08-13  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-winsource.h (struct tui_source_window_base)
 913         <clear_detail>: No longer "override".
 914         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 915         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 916         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 917         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 918         Remove.
 919         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 920
 921 2019-08-13  Tom Tromey  <tromey@adacore.com>
 922
 923         * tracepoint.c: Don't include readline.h or history.h.
 924
 925 2019-08-12  Tom Tromey  <tom@tromey.com>
 926
 927         * configure: Rebuild.
 928         * configure.ac: Check for readline 7.
 929         * NEWS: Mention readline 7 requirement.
 930         * README: Update.
 931
 932 2019-08-12  Tom Tromey  <tom@tromey.com>
 933
 934         * mingw-hdep.c (gdb_select): Remove readline hack.
 935
 936 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 937
 938         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 939         when the function fails.
 940
 941 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 942
 943         * s390-tdep.c (s390_type_align): New function.
 944         (s390_gdbarch_init): Set it as type_align gdbarch method.
 945
 946 2019-08-09  Tom de Vries  <tdevries@suse.de>
 947
 948         PR gdb/24591
 949         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 950         pc_low with relocation offset.
 951
 952 2019-08-07  Tom Tromey  <tromey@adacore.com>
 953
 954         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 955         (print_frame_args): Update.
 956         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 957         Update.
 958         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 959         * frame.h (struct frame_arg): Add initializers.
 960         <error>: Now a unique_xmalloc_ptr.
 961
 962 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 963
 964         * NEWS: Expand the Pointer Authentication entry.
 965         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 966         (aarch64_frame_unmask_lr): ... to this.
 967         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 968         Call aarch64_frame_unmask_lr.
 969         * frame.c (struct frame_info): Add "masked" variable.
 970         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 971         (fprint_frame): Check for masked pc.
 972         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 973         declarations.
 974         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 975         * stack.c (print_frame): Check for masked pc.
 976
 977 2019-08-06  Tom Tromey  <tom@tromey.com>
 978
 979         * stabsread.c (patch_block_stabs, read_one_struct_field)
 980         (read_enum_type): Use obstack_strndup.
 981         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 982         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 983         * dwarf2read.c (guess_full_die_structure_name)
 984         (anonymous_struct_prefix): Use obstack_strndup.
 985         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 986         * c-exp.y (yylex): Use obstack_strndup.
 987         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 988         (write_var_or_type): Use obstack_strndup.
 989
 990 2019-08-06  Tom Tromey  <tom@tromey.com>
 991
 992         * symfile.c (reread_symbols): Use obstack_strdup.
 993         * stabsread.c (read_type): Use obstack_strdup.
 994         * gdb_obstack.h (obstack_strdup): New overload.
 995         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 996         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 997         (dwarf2_canonicalize_name): Use obstack_strdup.
 998         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 999         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1000         Use obstack_strdup.
1001
1002 2019-08-06  Tom Tromey  <tom@tromey.com>
1003
1004         * gdb_obstack.h (obstack_strdup): Define.
1005         * gdb_obstack.c (obstack_strdup): Don't define.
1006
1007 2019-08-06  Tom Tromey  <tom@tromey.com>
1008
1009         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1010         obstack_strdup.
1011         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1012         obstack_strdup.
1013         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1014         * stabsread.c (common_block_start): Use obstack_strdup.
1015         * objfiles.c (set_objfile_main_name, objfile): Use
1016         obstack_strdup.
1017         * namespace.c (add_using_directive): Use obstack_strdup.
1018         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1019         * jit.c (finalize_symtab): Use obstack_strdup.
1020         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1021         (guess_partial_die_structure_name, partial_die_info::fixup)
1022         (dwarf2_name): Use obstack_strdup.
1023         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1024         obstack_strdup.
1025         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1026         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1027         obstack_strdup.
1028         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1029
1030 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1031
1032         * unittests/help-doc-selftests.c: New file.
1033         * Makefile.in: Add the new file.
1034
1035 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1036
1037         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1038         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1039         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1040         the trailing '.' is not output, and the first character is uppercased.
1041         (print_help_for_command): Update call to print_doc_line.
1042         (print_doc_of_command): Likewise.
1043         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1044         * cli/cli-option.c (append_indented_doc): Do not append newline.
1045         (build_help_option): Append newline after first appended_indented_doc
1046         only if a second call is done.
1047         (build_help): Append 2 new lines before each option, except the first
1048         one.
1049         * compile/compile.c (_initialize_compile): Add new lines after
1050         %OPTIONS%, when not at the end of the help.
1051         Change help doc or code
1052         producing the help doc to respect the invariants.
1053         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1054         Also removed the new line after 'Options:', as all other commands
1055         do not put an empty line between 'Options:' and the first option.
1056         * printcmd.c (_initialize_printcmd): Likewise.
1057         * stack.c (_initialize_stack): Likewise.
1058         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1059         incorrectly telling COMMAND is optional.
1060         * ada-lang.c (_initialize_ada_language): Change help doc or code
1061         producing the help doc to respect the invariants.
1062         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1063         * breakpoint.c (_initialize_breakpoint): Likewise.
1064         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1065         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1066         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1067         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1068         _initialize_cli_style): Likewise.
1069         * corelow.c (core_target_info): Likewise.
1070         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1071         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1072         * filesystem.c (_initialize_filesystem): Likewise.
1073         * frame.c (_initialize_frame): Likewise.
1074         * gnu-nat.c (add_task_commands): Likewise.
1075         * infcall.c (_initialize_infcall): Likewise.
1076         * infcmd.c (_initialize_infcmd): Likewise.
1077         * interps.c (_initialize_interpreter): Likewise.
1078         * language.c (_initialize_language): Likewise.
1079         * linux-fork.c (_initialize_linux_fork): Likewise.
1080         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1081         * maint.c (_initialize_maint_cmds): Likewise.
1082         * memattr.c (_initialize_mem): Likewise.
1083         * printcmd.c (_initialize_printcmd): Likewise.
1084         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1085         _RegEx): Likewise.
1086         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1087         * record-btrace.c (_initialize_record_btrace): Likewise.
1088         * record-full.c (_initialize_record_full): Likewise.
1089         * record.c (_initialize_record): Likewise.
1090         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1091         * regcache.c (_initialize_regcache): Likewise.
1092         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1093         _initialize_remote): Likewise.
1094         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1095         * serial.c (_initialize_serial): Likewise.
1096         * skip.c (_initialize_step_skip): Likewise.
1097         * source.c (_initialize_source): Likewise.
1098         * stack.c (_initialize_stack): Likewise.
1099         * symfile.c (_initialize_symfile): Likewise.
1100         * symtab.c (_initialize_symtab): Likewise.
1101         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1102         * top.c (init_main): Likewise.
1103         * tracefile-tfile.c (tfile_target_info): Likewise.
1104         * tracepoint.c (_initialize_tracepoint): Likewise.
1105         * tui/tui-win.c (_initialize_tui_win): Likewise.
1106         * utils.c (add_internal_problem_command): Likewise.
1107         * valprint.c (value_print_option_defs): Likewise.
1108
1109 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1110
1111         PR build/24886
1112         * configure.ac: Drop enable-libmcheck support.
1113         * configure, config.in: Rebuild.
1114         * libmcheck.m4: Remove.
1115         * acinclude.m4: Don't include it.
1116         * Makefile.in: Don't distribute it.
1117         * top.c (print_gdb_configuration): Don't mention it.
1118
1119 2019-08-06  Tom Tromey  <tom@tromey.com>
1120
1121         * utils.c (set_output_style): Sometimes pass stream to
1122         emit_style_escape.
1123         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1124         * record-btrace.c (btrace_insn_history): Update.
1125         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1126         method.
1127         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1128         Update initializers.
1129         <m_uiout>: New field.
1130         <m_di>: Move lower.
1131         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1132         Remove "uiout" parameter.
1133         (dump_insns): Update.
1134         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1135         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1136
1137 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1138
1139         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1140         (error_in_psymtab_expansion): Likewise.
1141         (lookup_symbol_via_quick_fns): Likewise.
1142         (basic_lookup_transparent_type_quick): Likewise.
1143         (basic_lookup_transparent_type_1): Likewise.
1144
1145 2019-08-06  Tom Tromey  <tromey@adacore.com>
1146
1147         * source.c (last_source_error): Now bool.
1148         (print_source_lines_base): Make "noprint" bool.  Only open
1149         source file when last_source_visited changes.
1150
1151 2019-08-06  Tom Tromey  <tromey@adacore.com>
1152
1153         * annotate.c (annotate_source_line): Use g_source_cache.
1154         * source-cache.c (source_cache::get_plain_source_lines): Change
1155         parameters.  Populate m_offset_cache.
1156         (source_cache::ensure): New method.
1157         (source_cache::get_line_charpos): New method.
1158         (extract_lines): Move lower.  Change parameters.
1159         (source_cache::get_source_lines): Move lower.
1160         * source-cache.h (class source_cache): Update comment.
1161         <get_line_charpos>: New method.
1162         <get_source_lines>: Update comment.
1163         <clear>: Clear m_offset_cache.
1164         <get_plain_source_lines>: Change parameters.
1165         <ensure>: New method
1166         <m_offset_cache>: New member.
1167         * source.c (forget_cached_source_info_for_objfile): Update.
1168         (info_source_command): Use g_source_cache.
1169         (find_source_lines, open_source_file_with_line_charpos): Remove.
1170         (print_source_lines_base, search_command_helper): Use g_source_cache.
1171         * source.h (open_source_file_with_line_charpos): Don't declare.
1172         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1173         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1174         Use g_source_cache.
1175
1176 2019-08-06  Tom Tromey  <tromey@adacore.com>
1177
1178         * source-cache.c (source_cache::get_plain_source_lines):
1179         Remove "first_line" and "last_line" parameters.
1180         (source_cache::get_source_lines): Cache plain text.
1181         * source-cache.h (class source_cache)
1182         <get_plain_source_lines>: Update.
1183
1184 2019-08-06  Tom Tromey  <tromey@adacore.com>
1185
1186         * source-cache.c (extract_lines): No longer a method.
1187         Changed type of parameter.  Include final newline.
1188         (selftests::extract_lines_test): New function.
1189         (_initialize_source_cache): Likewise.
1190         * source-cache.h (class source_cache)
1191         <extract_lines>: Don't declare.
1192
1193 2019-08-06  Tom Tromey  <tromey@adacore.com>
1194
1195         * breakpoint.c (init_breakpoint_sal): Update.
1196         (breakpoint): Update.
1197         * breakpoint.h (struct breakpoint) <filter>: Now a
1198         unique_xmalloc_ptr.
1199
1200 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1201
1202         * NEWS: Mention dictionary access on blocks.
1203         * python/py-block.c (blpy_getitem): New function.
1204         (block_object_as_mapping): New struct.
1205         (block_object_type): Use new struct for tp_as_mapping field.
1206
1207 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1208
1209         * objfiles.h (objfile): Add a comment describing partial symbols.
1210
1211 2019-08-05  Tom Tromey  <tromey@adacore.com>
1212
1213         * compile/compile.c (_initialize_compile): Use _(), not N_().
1214         * thread.c (_initialize_thread): Use _(), not N_().
1215         * stack.c (_initialize_stack): Use _(), not N_().
1216         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1217
1218 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1219
1220         * dwarf2read.c (struct dw2_symtab_iterator):
1221         <want_specific_block>: Remove.
1222         <block_index>: Change type to gdb::optional.
1223         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1224         change type of BLOCK_INDEX parameter to gdb::optional.
1225         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1226         (dw2_lookup_symbol): Don't pass argument for
1227         WANT_SPECIFIC_BLOCK.
1228         (dw2_expand_symtabs_for_function): Don't pass argument for
1229         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1230         (class dw2_debug_names_iterator)
1231         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1232         parameter, change BLOCK_INDEX type to gdb::optional.
1233         <m_want_specific_block>: Remove.
1234         <m_block_index>: Change type to gdb::optional.
1235         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1236         gdb::optional.  Re-write in function of gdb::optional.
1237         (dw2_debug_names_lookup_symbol): Don't pass argument for
1238         WANT_SPECIFIC_BLOCK.
1239         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1240         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1241         BLOCK_INDEX.
1242
1243 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1244
1245         * NEWS: Mention changes to "info sources" command.
1246
1247 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1248
1249         * symtab.c (filename_partial_match_opts): New struct type.
1250         (struct output_source_filename_data): New members
1251         regexp, c_regexp, partial_match.
1252         (output_source_filename): Use new members to decide to print file.
1253         (info_sources_option_defs): New variable.
1254         (make_info_sources_options_def_group, print_info_sources_header,
1255         info_sources_command_completer):
1256         New functions.
1257         (info_sources_command): Read new optional arguments.
1258         (_initialize_symtab): Update info sources help.
1259
1260 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1261
1262         * ada-lang.c (exception_support_info_v0): Renamed from...
1263         (default_exception_support_info): ... this.  Create new
1264         definition for v1.
1265         (ada_has_this_exception_support): Look up catch_handlers_sym.
1266         (ada_exception_support_info_sniffer): Try v0 after default.
1267
1268 2019-08-01  Tom Tromey  <tromey@adacore.com>
1269
1270         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1271         gdbarch.h.
1272
1273 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1274
1275         * s12z-tdep.c: Fix include path for s12z-opc.h.
1276
1277 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1278
1279         * NEWS: Require GNU make 3.82.
1280
1281 2019-07-16  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1284         declare.
1285
1286 2019-07-30  Tom Tromey  <tromey@adacore.com>
1287
1288         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1289
1290 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1291
1292         * printcmd.c (print_address_symbolic): Print negative offsets.
1293         (build_address_symbolic): Force signed arithmetic when computing
1294         offset.
1295
1296 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1297
1298         PR/24474: Add a function to lookup static variables.
1299         * NEWS: Mention this new function.
1300         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1301         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1302         * python/python.c (python_GdbMethods): Add new function.
1303
1304 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1305
1306         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1307         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1308         (objfpy_lookup_static_symbol): New function.
1309         (objfile_object_methods): Add new functions.
1310
1311 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1312
1313         * NEWS: Mention 'set|show print frame-info'.  Mention new
1314         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1315         backtrace argument.  Mention that python frame filtering code
1316         is now consistent with what 'backtrace' command prints.
1317
1318 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1319
1320         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1321         comments.
1322         (print_frame_info_auto, print_frame_info_source_line,
1323         print_frame_info_location, print_frame_info_source_and_location,
1324         print_frame_info_location_and_address, print_frame_info_short_location):
1325         New declarations.
1326         (struct frame_print_options): New member print_frame_info.
1327         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1328         * stack.h (get_user_print_what_frame_info): New declaration.
1329         (frame_show_address): New declaration.
1330         * stack.c (print_frame_arguments_choices): New value 'presence'.
1331         (print_frame_info_auto, print_frame_info_source_line,
1332         print_frame_info_location, print_frame_info_source_and_location,
1333         print_frame_info_location_and_address, print_frame_info_short_location,
1334         print_frame_info_choices, print_frame_info_print_what): New definitions.
1335         (print_frame_args): Only print dots for args if print frame-arguments
1336         is 'presence'.
1337         (frame_print_option_defs): New element for "frame-info".
1338         (get_user_print_what_frame_info): New function.
1339         (frame_show_address): Make non static.  Move comment to stack.h.
1340         (print_frame_info_to_print_what): New function.
1341         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1342         to decide what to print.
1343         (backtrace_command_1): Handle the new print_frame_arguments_presence
1344         value.
1345         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1346         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1347         (py_print_frame): In non-mi mode, use LOCATION as default for
1348         print_what, similarly to frame information printed directly by
1349         backtrace command. Handle frame-info user option in non MI mode.
1350
1351 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1352
1353         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1354         Add case for debugging 32-bit target on 64-bit host.  Revise
1355         comment.
1356
1357 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1358
1359         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1360         instead of find_function_entry_range_from_pc.
1361
1362 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1363
1364         * stack.c (find_frame_funname): Remove code which preferred
1365         minsym over symtab sym in "certain pathological cases".
1366
1367         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1368         parameter.  Change type of "do_demangle" to bool.
1369         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1370         Pass suitable "prefer_sym_over_minsym" flag to
1371         build_address_symbolic().  Don't output "+" for negative offsets.
1372         * printcmd.c (print_address_symbolic): Update invocation of
1373         build_address_symbolic to include a "prefer_sym_over_minsym"
1374         flag.
1375         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1376         Restrict cases in which use of minimal symbol is preferred to that
1377         of a found symbol.  Update comments.
1378
1379         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1380         for entry pc when entry pc is out of range for that FDE.
1381
1382 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1383
1384         PR gdb/24839:
1385         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1386         type.
1387
1388 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1389
1390         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1391         this function's Python signature.
1392
1393
1394 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1395
1396         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1397         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1398         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1399         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1400         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1401
1402
1403 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1404
1405         * h8300-tdep.c (h8300_register_name_common): New.
1406         h8300_register_name): Use h8300_register_name_common.
1407         (h8300s_register_name): Likewise.
1408         (h8300sx_register_name): Likewise.
1409         (h8300h_register_nam): New.
1410         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1411
1412
1413 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1414
1415         * arm-tdep.c (arm_skip_cmse_entry): New function.
1416         (arm_is_sgstubs_section): New function.
1417         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1418
1419 2019-07-22  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1422         Don't self-assign.
1423
1424 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1427         type_print.
1428
1429 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1430
1431         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1432         so that GDB doesn't match any msymbols when searching in the
1433         TYPES_DOMAIN.
1434         (print_symbol_info): Print using typedef_print or type_print based
1435         on the type of the symbol.  Add updated FIXME comment moved from...
1436         (_initialize_symtab): ... move and update FIXME comment to above.
1437
1438 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * NEWS: Mention adding -q option to "info types".
1441         * symtab.c (struct info_types_options): New struct.
1442         (info_types_options_defs): New variable.
1443         (make_info_types_options_def_group): New function.
1444         (info_types_command): Use gdb::option framework to parse options.
1445         (info_types_command_completer): New function.
1446         (_initialize_symtab): Extend the help text on "info types" and
1447         register command completer.
1448
1449 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1450
1451         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1452         (lookup_symbol_in_objfile): Change int to block_enum and add a
1453         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1454
1455 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1456
1457         * MAINTAINERS (Write After Approval): Add self.
1458
1459 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1460
1461         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1462         instruction to the dummy code region.
1463
1464 2019-07-19  Tom Tromey  <tromey@adacore.com>
1465
1466         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1467         (ARGSUSED, PARAMS, __func__): Remove rules.
1468
1469 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1470
1471         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1472         * features/arm/arm-with-iwmmxt.c: Remove.
1473         * features/arm/arm-with-iwmmxt.xml: Remove.
1474         * features/arm/arm-with-m-fpa-layout.c: Remove.
1475         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1476         * features/arm/arm-with-m-vfp-d16.c: Remove.
1477         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1478         * features/arm/arm-with-m.c: Remove.
1479         * features/arm/arm-with-m.xml: Remove.
1480         * features/arm/arm-with-neon.c: Remove.
1481         * features/arm/arm-with-neon.xml: Remove.
1482         * features/arm/arm-with-vfpv2.c: Remove.
1483         * features/arm/arm-with-vfpv2.xml: Remove.
1484         * features/arm/arm-with-vfpv3.c: Remove.
1485         * features/arm/arm-with-vfpv3.xml: Remove.
1486
1487 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1488
1489         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1490
1491 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1492
1493         * arch/aarch32.c (aarch32_create_target_description): Create
1494         target descriptions using features.
1495         * arch/arm.c (arm_create_target_description)
1496         (arm_create_mprofile_target_description): Likewise.
1497         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1498
1499 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1500
1501         * Makefile.in: Add new files.
1502         * aarch32-tdep.c: New file.
1503         * aarch32-tdep.h: New file.
1504         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1505         Call aarch32_read_description.
1506         * arch/aarch32.c: New file.
1507         * arch/aarch32.h: New file.
1508         * arch/arm.c (arm_create_target_description)
1509         (arm_create_mprofile_target_description): New function.
1510         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1511         (arm_create_target_description)
1512         (arm_create_mprofile_target_description): New declaration.
1513         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1514         read_description functions.
1515         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1516         Likewise.
1517         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1518         * arm-tdep.c (tdesc_arm_list): New variable.
1519         (arm_register_g_packet_guesses): Call create description functions.
1520         (arm_read_description) (arm_read_mprofile_description): New
1521         function.
1522         * arm-tdep.h (arm_read_description)
1523         (arm_read_mprofile_description): Add declaration.
1524         * configure.tgt: Add new files.
1525
1526 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1527
1528         * top.c (new_ui_command): Open specified terminal just once.
1529
1530 2019-07-18  Tom Tromey  <tromey@adacore.com>
1531
1532         * symtab.c (main_name): Constify return type.
1533         * symfile.c (set_initial_language): Update.
1534         * symtab.h (main_name): Constify return type.
1535
1536 2019-07-17  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-winsource.c (tui_update_source_window)
1539         (tui_update_source_window_as_is)
1540         (tui_update_source_windows_with_line): Remove return.
1541         * tui/tui-disasm.c (tui_show_disassem)
1542         (tui_show_disassem_and_update_source): Remove return.
1543         * tui/tui.c (tui_reset): Remove return.
1544         * tui/tui-wingeneral.c
1545         (tui_check_and_display_highlight_if_needed): Remove return.
1546
1547 2019-07-17  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1550
1551 2019-07-17  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-winsource.h (struct tui_exec_info_window)
1554         (struct tui_source_window_base): Move from tui-data.h.
1555         * tui/tui-winsource.c: Move many method definitions from
1556         elsewhere.  Remove "structuring" comments.
1557         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1558         (tui_source_window_base::refresh_window): Move to
1559         tui-winsource.c.
1560         * tui/tui-win.c (tui_source_window_base::refresh_all)
1561         (tui_source_window_base::update_tab_width)
1562         (tui_source_window_base::set_new_height)
1563         (tui_source_window_base::do_make_visible_with_new_height): Move to
1564         tui-winsource.c.
1565         * tui/tui-source.h: Update.
1566         * tui/tui-source.c (tui_source_window_base::reset): Move to
1567         tui-winsource.c.
1568         * tui/tui-disasm.h: Update.
1569         * tui/tui-data.h (struct tui_exec_info_window): Move to
1570         tui-winsource.h.
1571         (struct tui_source_window_base): Likewise.
1572         * tui/tui-data.c (tui_source_window_base::clear_detail)
1573         (tui_source_window_base, ~tui_source_window_base): Move to
1574         tui-winsource.c.
1575
1576 2019-07-17  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-win.c (tui_resize_all)
1579         (tui_source_window_base::update_tab_width)
1580         (tui_adjust_win_heights): Update.
1581         (tui_win_info::make_invisible_and_set_new_height): Rename from
1582         make_invisible_and_set_new_height.
1583         * tui/tui-data.h (struct tui_win_info)
1584         <make_invisible_and_set_new_height>: New method.
1585
1586 2019-07-17  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui.c: Update.
1589         * tui/tui-source.h (struct tui_source_window): Move from
1590         tui-data.h.
1591         * tui/tui-layout.c: Update.
1592         * tui/tui-disasm.c: Update.
1593         * tui/tui-data.h (struct tui_source_window): Move to
1594         tui-source.h.
1595
1596 2019-07-17  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1599         tui-data.h.
1600         * tui/tui-data.h (struct tui_disasm_window): Move to
1601         tui-disasm.h.
1602
1603 2019-07-17  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-regs.h (struct tui_data_item_window): Move from
1606         tui-data.h.
1607         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1608         * tui/tui-data.h (struct tui_data_item_window): Move to
1609         tui-regs.h.
1610         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui.c: Update.
1615         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1616         (tui_cmd_window::max_height): Move to tui-command.c.
1617         * tui/tui-layout.c: Update.
1618         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1619         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1620         tui-command.c.
1621         * tui/tui-command.h (struct tui_cmd_window): Move from
1622         tui-data.h.
1623         * tui/tui-command.c: Remove "structuring" comments.
1624         (tui_cmd_window::clear_detail)
1625         (tui_cmd_window::do_make_visible_with_new_height)
1626         (tui_cmd_window::max_height): Move from elsewhere.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1631         Now static.
1632         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1633         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1634
1635 2019-07-17  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui.c: Update.
1638         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1639         tui-regs.c.
1640         * tui/tui-windata.h: Remove file.
1641         * tui/tui-windata.c: Remove file.
1642         * tui/tui-win.c (tui_data_window::set_new_height)
1643         (tui_data_window::do_make_visible_with_new_height): Move to
1644         tui-regs.c.
1645         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1646         * tui/tui-regs.c: Remove "structuring" comments.
1647         (tui_data_window::first_data_item_displayed)
1648         (tui_data_window::delete_data_content_windows)
1649         (tui_data_window::erase_data_content)
1650         (tui_data_window::display_all_data)
1651         (tui_data_window::refresh_all)
1652         (tui_data_window::do_scroll_vertical)
1653         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1654         (tui_data_window::do_make_visible_with_new_height)
1655         (tui_data_window::refresh_window): Move from elsewhere.
1656         (_initialize_tui_regs): Move to end of file.
1657         * tui/tui-layout.c: Update.
1658         * tui/tui-hooks.c: Update.
1659         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1660         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1661         tui-regs.c.
1662         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1663
1664 2019-07-17  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1667         seen.
1668
1669 2019-07-17  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-win.c (tui_source_window_base::set_new_height)
1672         (tui_source_window_base::do_make_visible_with_new_height): Use
1673         m_has_locator field directly.
1674         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1675         method.
1676         (struct tui_source_window_base) <has_locator>: Likewise.
1677
1678 2019-07-17  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1681         Don't declare.
1682         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1683         Remove.
1684         * tui/tui-win.c (tui_source_window_base::set_new_height)
1685         (tui_source_window_base::set_new_height)
1686         (make_invisible_and_set_new_height)
1687         (tui_source_window_base::do_make_visible_with_new_height)
1688         (tui_source_window_base::do_make_visible_with_new_height):
1689         Update.
1690         * tui/tui-layout.c (show_source_disasm_command, show_data)
1691         (show_source_or_disasm_and_command): Update.
1692         * tui/tui-layout.c (show_layout): Update.
1693
1694 2019-07-17  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-layout.c (make_data_window): Remove.
1697         (show_data): Unify creation and re-initialization cases.
1698
1699 2019-07-17  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-layout.c (make_source_window, make_disasm_window):
1702         Remove.
1703         (show_data): Unify creation and re-initialization cases.
1704
1705 2019-07-17  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-layout.c (make_command_window): Remove.
1708         (show_source_disasm_command, show_source_or_disasm_and_command):
1709         Unify creation and re-initialization cases.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1714         creation and re-initialization cases.
1715
1716 2019-07-17  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-regs.c (tui_get_register): Return void.
1719
1720 2019-07-17  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1723         Simplify.
1724
1725 2019-07-17  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1728         resetting.
1729
1730 2019-07-17  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1733         * tui/tui-regs.c (tui_reg_layout): New function.
1734         (tui_show_registers, tui_reg_command): Use it.
1735         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1736         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1737         parameters.
1738         (tui_layout_command): Remove.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-layout.h (tui/tui-layout): Return void.
1743         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1744
1745 2019-07-17  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-layout.c (show_source_disasm_command, show_data):
1748         Update.
1749         (reset_locator): Remove.
1750         (show_source_or_disasm_and_command): Update.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-source.c (tui_source_window_base::reset): Remove
1755         win_type parameter.
1756         * tui/tui-layout.c (make_command_window, make_source_window)
1757         (make_disasm_window, make_data_window)
1758         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1759         (reset_locator, show_source_or_disasm_and_command): Update.
1760         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1761         win_type parameter.
1762         (struct tui_source_window_base) <reset>: Likewise.
1763
1764 2019-07-17  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-layout.c (show_source_disasm_command): Use
1767         reset_locator.
1768         (reset_locator): New function.
1769         (init_and_make_win): Remove.
1770         (show_source_or_disasm_and_command): Use reset_locator.
1771
1772 2019-07-17  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1775         condition.
1776         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1777         Remove condition.
1778         * tui/tui-source.c (tui_source_window_base::reset): New method.
1779         * tui/tui-layout.c (make_command_window): Don't call
1780         init_and_make_win.
1781         (make_source_window, make_disasm_window): Don't call
1782         make_source_or_disasm_window.
1783         (make_data_window): Don't call init_and_make_win.  Change calling
1784         convention.
1785         (show_source_disasm_command, show_data): Simplify.
1786         (make_source_or_disasm_window): Remove.
1787         (show_source_or_disasm_and_command): Simplify.
1788         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1789         (struct tui_source_window_base) <reset>: Likewise.
1790         <execution_info>: Remove initializer.
1791         * tui/tui-data.c (tui_source_window_base): Initialize
1792         execution_info.
1793
1794 2019-07-17  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1797         variable.
1798
1799 2019-07-17  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui.c (tui_rl_other_window): Update.
1802         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1803         superclass method first.  Always iterate over regs_content.
1804         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1805         method.
1806         * tui/tui-win.c (tui_set_focus_command): Update.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-win.c (tui_set_focus_command): Rename from
1811         tui_set_focus.  Call tui_enable.
1812         (tui_set_focus_command): Remove.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1817         refresh_window.
1818         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1819         touchwin.
1820         (tui_data_window::refresh_window): Call refresh_window on data
1821         items.  Always call superclass refresh_window.
1822         (tui_win_info::refresh): Remove.
1823         (tui_source_window_base::refresh_window): Update.
1824         (tui_refresh_all): Update.
1825         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1826         refresh_window.
1827         (show_source_or_disasm_and_command): Likewise.
1828         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1829         (struct tui_source_window_base) <refresh>: Likewise.
1830
1831 2019-07-17  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.c (tui_clear_source_content)
1834         (tui_show_source_content): Update.
1835         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1836         whether content is empty.
1837         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1838         Remove.
1839
1840 2019-07-17  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1843         window's contents.
1844         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1845         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1846
1847 2019-07-17  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1850         (struct tui_data_item_window): Update.
1851
1852 2019-07-17  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1855         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1856         defines.
1857
1858 2019-07-17  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-winsource.h (tui_erase_source_content)
1861         (tui_clear_source_content): Remove "display_prompt" parameter.
1862         * tui/tui-winsource.c (tui_update_source_window_as_is)
1863         (tui_update_source_windows_with_addr): Update.
1864         (tui_clear_source_content): Remove "display_prompt" parameter.
1865         (tui_erase_source_content): Likewise.  Simplify.
1866         (tui_show_source_content): Update.
1867         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1868         * tui/tui-stack.c (tui_show_frame_info): Update.
1869         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1870         Remove defines.
1871
1872 2019-07-17  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1875         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1876         parameter.
1877         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1878         parameter.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.c (tui_clear_source_content)
1883         (tui_show_source_content, tui_show_exec_info_content)
1884         (tui_clear_exec_info_content): Update.
1885         * tui/tui-stack.c (tui_show_locator_content): Update.
1886         (tui_show_frame_info): Update.
1887         * tui/tui-source.h (tui_source_window): Don't declare.
1888         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1889         from tui_source_is_displayed.
1890         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1891         Remove field.
1892         (struct tui_source_window_base) <content_in_use>: New field.  Now
1893         bool.
1894         (struct tui_source_window) <showing_source_p>: New method.
1895         (TUI_SRC_WIN): Change cast.
1896         * tui/tui-data.c (tui_initialize_static_data): Update.
1897
1898 2019-07-17  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1901         location_matches_p.
1902         * tui/tui-source.c (tui_source_window::location_matches_p): New
1903         method.
1904         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1905         method.
1906         * tui/tui-data.h (struct tui_source_window_base)
1907         <location_matches_p>: New method.
1908         (struct tui_source_window, struct tui_disasm_window)
1909         <location_matches_p>: Likewise.
1910
1911 2019-07-17  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-win.c (tui_set_win_height_command): Rename from
1914         tui_set_win_height.
1915         (tui_set_win_height_command): Remove.
1916
1917 2019-07-17  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-source.c (tui_source_window): New constructor.  Add
1920         observer.
1921         (~tui_source_window): New destructor.
1922         (tui_source_window::style_changed): New method.
1923         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1924         (tui_attach_detach_observers): Update.
1925         * tui/tui-data.h (struct tui_source_window): Make constructor not
1926         inline.  Add destructor.
1927         (struct tui_source_window) <style_changed>: New method.
1928         <m_observable>: New member.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1933         * tui/tui-win.c (tui_resize_all): Fix typo.
1934
1935 2019-07-17  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1938         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1939         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1940         * tui/tui-win.c (window_name_completer): Use foreach.
1941         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1942         (update_tab_width): Likewise.
1943         * tui/tui-layout.c (show_layout): Update.
1944         * tui/tui-data.h (class tui_window_iterator): New.
1945         (struct all_tui_windows): New.
1946         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1947
1948 2019-07-17  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1951         parameter.  Don't reference globals.
1952         (tui_reg_command): Update.
1953
1954 2019-07-17  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-regs.c (tui_show_registers): Simplify.
1957
1958 2019-07-17  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-regs.c (tui_show_registers): Update.
1961         (tui_show_register_group): Add win_info parameter.
1962
1963 2019-07-17  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1966         Rename from tui_display_reg_element_at_line.
1967         (tui_data_window::display_registers_from_line): Update.
1968         * tui/tui-data.h (struct tui_data_window)
1969         <display_reg_element_at_line>: New method.
1970
1971 2019-07-17  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-regs.h (tui_display_registers_from)
1974         (tui_display_registers_from_line): Don't declare.
1975         * tui/tui-windata.c (tui_data_window::display_all_data)
1976         (tui_data_window::refresh_all)
1977         (tui_data_window::do_scroll_vertical): Update.
1978         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1979         from tui_display_registers_from.
1980         (tui_display_reg_element_at_line): Update.
1981         (tui_data_window::display_registers_from_line): Rename from
1982         tui_display_registers_from_line.
1983         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1984         display_registers_from_line>: New methods.
1985
1986 2019-07-17  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1989         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1990         from tui_erase_data_content.
1991         (tui_data_window::display_all_data)
1992         (tui_data_window::refresh_all)
1993         (tui_data_window::do_scroll_vertical): Update.
1994         * tui/tui-regs.c (tui_show_registers): Update.
1995         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1996         New method.
1997
1998 2019-07-17  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2001         declare.
2002         * tui/tui-windata.c
2003         (tui_data_window::delete_data_content_windows): Rename from
2004         tui_delete_data_content_windows.
2005         (tui_data_window::display_all_data)
2006         (tui_data_window::do_scroll_vertical): Update.
2007         * tui/tui-data.h (struct tui_data_window)
2008         <delete_data_content_windows>: New method.
2009
2010 2019-07-17  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2013         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2014
2015 2019-07-17  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2018         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2019         from tui_display_all_data.
2020         * tui/tui-win.c
2021         (tui_data_window::do_make_visible_with_new_height): Update.
2022         * tui/tui-regs.c (tui_show_registers): Update.
2023         * tui/tui-layout.c (tui_set_layout): Update.
2024         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2025         method.
2026
2027 2019-07-17  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2030         * tui/tui-windata.c (tui_display_data_from): Remove.
2031         (tui_data_window::refresh_all): Update.
2032
2033 2019-07-17  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2036         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2037         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2038         tui_display_registers_from_line.
2039         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2040         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2041         "force_display" parameter.
2042
2043 2019-07-17  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2046         declare.
2047         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2048         Rename from tui_first_reg_element_no_inline.
2049         (tui_display_reg_element_at_line)
2050         (tui_display_registers_from_line): Update.
2051         * tui/tui-data.h (struct tui_data_window)
2052         <first_reg_element_no_inline>: New method.
2053
2054 2019-07-17  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-windata.c (tui_display_data_from)
2057         (tui_data_window::do_scroll_vertical): Update.
2058         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2059         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2060         Rename from tui_line_from_reg_element_no.
2061         (tui_display_registers_from_line): Update.
2062         * tui/tui-data.h (struct tui_data_window)
2063         <line_from_reg_element_no>: New method.
2064
2065 2019-07-17  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2068         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2069         tui_last_regs_line_no.
2070         (tui_display_reg_element_at_line)
2071         (tui_display_registers_from_line): Update.
2072         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2073         method.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         PR tui/24722:
2078         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2079         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2080         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2081         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2082         (tui_update_breakpoint_info): Likewise.
2083         * tui/tui-hooks.c (tui_event_create_breakpoint)
2084         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2085         Update.
2086
2087 2019-07-17  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2090
2091 2019-07-17  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-winsource.c (tui_update_source_window_as_is)
2094         (tui_update_source_windows_with_addr): Update.
2095         * tui/tui-source.h (tui_set_source_content)
2096         (tui_show_symtab_source): Add "win_info" parameter.
2097         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2098         parameter.
2099         (tui_show_symtab_source): Likewise.
2100
2101 2019-07-17  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-wingeneral.c
2104         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2105
2106 2019-07-17  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2109         (struct tui_cmd_window) <can_scroll>: New method.
2110         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2111         method.
2112
2113 2019-07-17  Tom Tromey  <tromey@adacore.com>
2114
2115         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2116         do_field_signed>: Rename.  Change type of "value".
2117         * ui-out.c (ui_out::field_signed): Rename from field_int.
2118         Change type of "value".
2119         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2120         type of "value".
2121         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2122         do_field_int.  Change type of "value".
2123         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2124         do_field_int.  Change type of "value".
2125         * tracepoint.c (trace_status_mi, tfind_1)
2126         (print_one_static_tracepoint_marker): Update.
2127         * thread.c (print_thread_info_1, print_selected_thread_frame):
2128         Update.
2129         * stack.c (print_frame, print_frame_info): Update.
2130         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2131         Update.
2132         * source.c (print_source_lines_base): Update.
2133         * skip.c (info_skip_command): Update.
2134         * record-btrace.c (btrace_ui_out_decode_error)
2135         (btrace_call_history_src_line): Update.
2136         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2137         Update.
2138         * progspace.c (print_program_space): Update.
2139         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2140         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2141         do_field_int.  Change type of "value".
2142         * mi/mi-out.c (mi_ui_out::do_table_begin)
2143         (mi_ui_out::do_table_header): Update.
2144         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2145         type of "value".
2146         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2147         (mi_cmd_data_list_changed_registers, output_register)
2148         (mi_cmd_data_read_memory, mi_load_progress)
2149         (mi_cmd_trace_frame_collected): Update.
2150         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2151         Update.
2152         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2153         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2154         (mi_cmd_var_list_children, varobj_update_one): Update.
2155         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2156         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2158         * inferior.c (print_inferior): Update.
2159         * gdb_bfd.c (print_one_bfd): Update.
2160         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2161         Update.
2162         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2163         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2164         do_field_int.  Change type of "value".
2165         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2166         do_field_int.  Change type of "value".
2167         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2168         (print_one_breakpoint_location, print_it_catch_fork)
2169         (print_one_catch_fork, print_it_catch_vfork)
2170         (print_one_catch_vfork, print_it_catch_solib)
2171         (print_it_catch_exec, print_it_ranged_breakpoint)
2172         (print_mention_watchpoint, print_mention_masked_watchpoint)
2173         (bkpt_print_it, update_static_tracepoint): Update.
2174         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2175         * break-catch-syscall.c (print_it_catch_syscall): Update.
2176         * ada-tasks.c (print_ada_task_info): Update.
2177         * ada-lang.c (print_it_exception, print_mention_exception):
2178         Update.
2179
2180 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2181
2182         PR breakpoints/24541
2183         * gdbarch.c: Regenerate.
2184         * gdbarch.h: Regenerate.
2185         * gdbarch.sh: Adjust return type and parameter types for
2186         'stap_adjust_register'.
2187         (i386_stap_adjust_register): Adjust signature and return new
2188         register name.
2189         * stap-probe.c (stap_parse_register_operand): Adjust use of
2190         'gdbarch_stap_adjust_register'.
2191
2192 2019-07-17  Tom Tromey  <tromey@adacore.com>
2193
2194         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2195         declare VEC.
2196         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2197         std::vector.
2198         (struct s390_process_info): Add initializers.
2199         (s390_add_process): Use new.
2200         (s390_linux_nat_target::low_forget_process): Use delete.
2201         (s390_linux_nat_target::low_new_fork)
2202         (s390_linux_nat_target::stopped_by_watchpoint)
2203         (s390_linux_nat_target::low_prepare_to_resume)
2204         (s390_linux_nat_target::insert_watchpoint)
2205         (s390_linux_nat_target::insert_hw_breakpoint)
2206         (s390_linux_nat_target::remove_watchpoint)
2207         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2208
2209 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2210
2211         * aarch64-fbsd-nat.c: Include regcache.h.
2212         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2213         argument.
2214         (aarch64_fbsd_nat_target::fetch_registers)
2215         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2216         variable.
2217         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2218
2219 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2220
2221         * fbsd-nat.c: Include gdbarch.h.
2222
2223 2019-07-15  Tom Tromey  <tromey@adacore.com>
2224
2225         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2226
2227 2019-07-15  Tom Tromey  <tromey@adacore.com>
2228
2229         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2230         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2231         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2232         * cli-out.c (cli_ui_out::do_field_int): New method.
2233         * ui-out.c (ui_out::field_unsigned): New method.
2234         * symfile.c (generic_load): Use field_unsigned.
2235         (print_transfer_performance): Likewise.
2236         * record-btrace.c (ui_out_field_uint): Remove.
2237         (btrace_call_history_insn_range, btrace_call_history): Use
2238         field_unsigned.
2239         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2240         field_unsigned.
2241         * ui-out.h (class ui_out) <field_unsigned>: New method.
2242         <do_field_unsigned>: Likewise.
2243
2244 2019-07-15  Tom Tromey  <tromey@adacore.com>
2245
2246         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2247         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2248         * target.c (flash_erase_command): Use field_string.
2249         * infrun.c (print_signal_received_reason): Use field_string.
2250         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2251         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2252         field_string.
2253         * ada-tasks.c (print_ada_task_info): Use field_string.
2254
2255 2019-07-15  Tom Tromey  <tromey@adacore.com>
2256
2257         * target.c (flash_erase_command): Use field_core_addr.
2258         * symfile.c (generic_load): Use field_core_addr.
2259         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2260         Use field_core_addr.
2261         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2262         field_core_addr.
2263
2264 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2267         value if its desired type is smaller than a CORE_ADDR and signed.
2268
2269 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2272         of changes to field names, and use new is_reference field to
2273         decide if a property is a reference or not.
2274         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2275         field.
2276         (struct dwarf2_property_baton): Update header comment, rename
2277         'referenced_type' to 'property_type' and update comments.
2278         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2279         default property type, store in property baton, update to take
2280         accound of renamed field.
2281         (read_func_scope): Update call to attr_to_dynamic_prop.
2282         (read_array_type): Likewise.
2283         (dwarf2_per_cu_addr_sized_int_type): New function.
2284         (read_subrange_index_type): Move type finding code to
2285         dwarf2_per_cu_addr_sized_int_type.
2286         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2287         (dwarf2_per_cu_addr_type): New function.
2288         (set_die_type): Update calls to attr_to_dynamic_prop.
2289
2290 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * dwarf2read.c (read_subrange_index_type): New function.
2293         (read_subrange_type): Move code into new function and call it.
2294         * gdbtypes.c (create_range_type): Add some asserts.
2295
2296 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2297
2298         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2299         update return statements.
2300         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2301         declaration, and update comment to match.
2302         * gdbtypes.c (resolve_dynamic_array): Update call to
2303         dwarf2_evaluate_property to match new return type.
2304
2305 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * valarith.c (value_subscripted_rvalue): Change lowerbound
2308         parameter type from int to LONGEST.
2309         * value.h (value_subscripted_rvalue): Likewise in declaration.
2310
2311 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2312
2313         * cli/cli-utils.c (info_print_command_completer): New function.
2314         * cli/cli-utils.h: Add 'completer.h' include, and forward
2315         declaration for 'struct cmd_list_element'.
2316         (info_print_command_completer): Declare.
2317         * stack.c (_initialize_stack): Add completer for 'info locals' and
2318         'info args'.
2319         * symtab.c (_initialize_symtab): Add completer for 'info
2320         variables' and 'info functions'.
2321         * NEWS: Mention completion for additional info commands.
2322
2323 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * cli/cli-utils.c (extract_info_print_args): Delete.
2326         (extract_arg_maybe_quoted): Delete.
2327         (info_print_options_defs): New variable.
2328         (make_info_print_options_def_group): New function.
2329         (extract_info_print_options): Define new function.
2330         * cli/cli-utils.h (extract_info_print_args): Delete.
2331         (struct info_print_options): New structure.
2332         (extract_info_print_options): Declare new function.
2333         * stack.c (info_locals_command): Update to use new
2334         extract_info_print_options, also add a header comment.
2335         (info_args_command): Likewise.
2336         * symtab.c (info_variables_command): Likewise.
2337         (info_functions_command): Likewise.
2338
2339 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2342         to extract string arguments.
2343         * common/common-utils.c (extract_string_maybe_quoted): New function.
2344         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2345
2346 2019-07-11  Tom Tromey  <tromey@adacore.com>
2347
2348         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2349         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2350         * top.h (gdbinit): Don't declare.
2351         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2352         into...
2353         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2354         * top.c (gdb_init): Don't call init_cli_cmds.
2355         (gdbinit): Remove.
2356         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2357
2358 2019-07-11  Tom Tromey  <tromey@adacore.com>
2359
2360         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2361         after it has been moved.
2362
2363 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2364
2365         * valops.c (value_must_coerce_to_target): Change return type to
2366         bool.
2367         * value.h (value_must_coerce_to_target): Likewise.
2368
2369 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2370
2371         * breakpoint.c (is_hardware_watchpoint): Remove
2372         forward-declaration.
2373         (is_masked_watchpoint): Change return type to bool.
2374         (is_tracepoint): Likewise.
2375         (is_breakpoint): Likewise.
2376         (is_hardware_watchpoint): Likewise.
2377         (is_watchpoint): Likewise.
2378         (is_no_memory_software_watchpoint): Likewise.
2379         (is_catchpoint): Likewise.
2380         (breakpoint_1): Make FILTER parameter's return type bool.
2381         is_masked_watchpoint): Change return type to bool.
2382         (save_breakpoints): Make FILTER parameter's return type bool.
2383         * breakpoint.h (is_breakpoint): Change return type to bool.
2384         (is_watchpoint): Likewise.
2385         (is_catchpoint): Likewise.
2386         (is_tracepoint): Likewise.
2387
2388 2019-07-10  Tom Tromey  <tom@tromey.com>
2389
2390         * defs.h: Don't include gdbarch.h.
2391         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2392         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2393         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2394         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2395         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2396         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2397         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2398         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2399         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2400         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2401         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2402         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2403         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2404         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2405         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2406         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2407         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2408         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2409         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2410         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2411         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2412         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2413         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2414         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2415         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2416         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2417         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2418
2419 2019-07-10  Tom Tromey  <tromey@adacore.com>
2420
2421         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2422         * breakpoint.c (init_ada_exception_breakpoint): Register as
2423         bp_catchpoint.
2424         (print_one_breakpoint_location, print_one_breakpoint): Use
2425         is_ada_exception_catchpoint.
2426         * ada-lang.c (class ada_catchpoint_location): Pass
2427         bp_loc_software_breakpoint to bp_location constructor.
2428         (is_ada_exception_catchpoint): New function.
2429
2430 2019-07-10  Tom Tromey  <tromey@adacore.com>
2431
2432         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2433         VEC.
2434         (struct arm_exidx_entry): New method operator<.
2435         (struct arm_exidx_data) <section_maps>: Change type.
2436         (arm_exidx_data_free): Remove.
2437         (arm_exidx_data_key): Change type.  Move lower.
2438         (arm_exidx_new_objfile): Update.
2439         (arm_compare_exidx_entries): Remove.
2440         (arm_find_exidx_entry, _initialize_arm_tdep)
2441
2442 2019-07-10  Tom Tromey  <tromey@adacore.com>
2443
2444         * solib-spu.c (ocl_program_data_key): Change type.
2445         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2446         Update.
2447
2448 2019-07-10  Tom Tromey  <tromey@adacore.com>
2449
2450         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2451         (struct solib_aix_inferior_data) <library_list>: Change type.
2452         (solib_aix_inferior_data_handle): Change type.
2453         (get_solib_aix_inferior_data): Update.
2454         (solib_aix_free_library_list): Remove.
2455         (library_list_start_library): Update.
2456         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2457         return type.
2458         (solib_aix_get_library_list)
2459         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2460         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2461
2462 2019-07-10  Tom Tromey  <tromey@adacore.com>
2463
2464         * solib-dsbt.c (struct dsbt_info): Add initializers.
2465         (solib_dsbt_pspace_data): Change type.
2466         (dsbt_pspace_data_cleanup): Remove.
2467         (get_dsbt_info, _initialize_dsbt_solib): Update.
2468
2469 2019-07-10  Tom Tromey  <tromey@adacore.com>
2470
2471         * spu-tdep.c (spu_overlay_data): Change type.
2472         (spu_get_overlay_table, spu_overlay_new_objfile)
2473         (_initialize_spu_tdep): Update.
2474
2475 2019-07-10  Tom Tromey  <tromey@adacore.com>
2476
2477         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2478         destructor.
2479         (dbx_objfile_data_key): Change type and declare later.
2480         (DBX_SYMFILE_INFO): Rewrite.
2481         * dbxread.c (dbx_objfile_data_key): Change type.
2482         (dbx_symfile_init): Update.
2483         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2484         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2485         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2486
2487 2019-07-10  Tom Tromey  <tromey@adacore.com>
2488
2489         * jit.c (jit_program_space_key): Change type.  Move lower.
2490         (get_jit_program_space_data): Update.
2491         (jit_program_space_data_cleanup): Remove.
2492         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2493         Update.
2494         (struct jit_program_space_data): Add initializers.
2495
2496 2019-07-10  Tom Tromey  <tromey@adacore.com>
2497
2498         * solib-darwin.c (struct darwin_info): Add initializers.
2499         (solib_darwin_pspace_data): Change type.
2500         (darwin_pspace_data_cleanup): Remove.
2501         (get_darwin_info, _initialize_darwin_solib): Update.
2502
2503 2019-07-10  Tom Tromey  <tromey@adacore.com>
2504
2505         * remote-sim.c (struct sim_inferior_data): Add initializers,
2506         constructor, and destructor.
2507         (sim_inferior_data_key): Change type.  Move lower.
2508         (check_for_duplicate_sim_descriptor): Update.
2509         (get_sim_inferior_data): Use new.  Update.
2510         (~sim_inferior_data_cleanup): Rename from
2511         sim_inferior_data_cleanup.  Simplify.
2512         (gdbsim_close_inferior, simulator_command)
2513         (sim_command_completer, _initialize_remote_sim): Update.
2514         (next_pid, INITIAL_PID): Move earlier.
2515
2516 2019-07-10  Tom Tromey  <tromey@adacore.com>
2517
2518         * python/python-internal.h (create_thread_object): Return
2519         gdbpy_ref.
2520         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2521         * python/py-inferior.c (struct threadlist_entry): Add
2522         constructor.
2523         <thread_obj>: Now a gdbpy_ref.
2524         (thread_to_thread_object): Update.
2525         (add_thread_object): Use new.
2526         (delete_thread_object): Use delete.
2527         (infpy_threads): Update.
2528         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2529         GIL.
2530
2531 2019-07-10  Tom Tromey  <tromey@adacore.com>
2532
2533         * valops.c (value_cast): Specialize error message for Ada.
2534
2535 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2536
2537         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2538
2539 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2540
2541         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2542         bpstat_should_step): Return bool, adjust comments.
2543         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2544         bpstat_should_step): Likewise.
2545
2546 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2547
2548         * features/Makefile: Use feature target descriptions for Arm.
2549         * features/arm/arm-core.c: Generate new file.
2550         * features/arm/arm-fpa.c: Likewise.
2551         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2552         * features/arm/arm-m-profile.c: Likewise.
2553         * features/arm/arm-vfpv2.c: Likewise.
2554         * features/arm/arm-vfpv3.c: Likewise.
2555         * features/arm/xscale-iwmmxt.c: Likewise.
2556         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2557
2558 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2559
2560         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2561         ptrace earlier.
2562
2563 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2564
2565         * features/aarch64-pauth.c: Regenerate.
2566
2567 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2568
2569         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2570         bool.
2571         (bpstat_what): Use false instead of 0.
2572
2573 2019-07-09  Pedro Alves  <palves@redhat.com>
2574
2575         * break-catch-throw.c (is_exception_catchpoint): New.
2576         * breakpoint.c (print_one_breakpoint_location): New parameter
2577         'raw_loc'.  Handle it.  Use
2578         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2579         looking at the breakpoint's type.
2580         (print_one_breakpoint): If handling "maint info breakpoints", also
2581         print locations of exception catchpoints.
2582         * breakpoint.h (is_exception_catchpoint): Declare.
2583
2584 2019-07-09  Pedro Alves  <palves@redhat.com>
2585
2586         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2587         "addr" field.
2588         (allocate_location_exception_catchpoint): New.
2589         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2590         (initialize_throw_catchpoint_ops): Install
2591         allocate_location_exception_catchpoint as allocate_location
2592         method.
2593         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2594         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2595         bp_loc_other.
2596         (breakpoint_address_is_meaningful): Delete.
2597         (bl_address_is_meaningful): New.
2598         (breakpoint_locations_match): Adjust comment.
2599         (bp_location_from_bp_type): New, factored out of...
2600         (bp_location::bp_location(breakpoint *)): ... this.
2601         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2602         factored out of...
2603         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2604         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2605         breakpoint_address_is_meaningful.
2606         (bp_locations_compare): Adjust comment.
2607         (update_global_location_list): Use bl_address_is_meaningful
2608         instead of breakpoint_address_is_meaningful.
2609         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2610         explicit.
2611         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2612         * python/py-breakpoint.c (bppy_get_location): No longer check
2613         whether location is null.
2614
2615 2019-07-09  Pedro Alves  <palves@redhat.com>
2616
2617         PR c++/15468
2618         * breakpoint.c (print_one_breakpoint_location): Remove
2619         single-location assert.
2620
2621 2019-07-09  Tom Tromey  <tom@tromey.com>
2622
2623         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2624         * configure: Rebuild.
2625         * configure.ac: Change common to gdbsupport.
2626         * gdbsupport: Rename from common.
2627         * acinclude.m4: Change common to gdbsupport.
2628         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2629         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2630         gdbsupport.
2631         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2632         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2633         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2634         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2635         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2636         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2637         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2638         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2639         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2640         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2641         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2642         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2643         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2644         coff-pe-read.c, command.h, compile/compile-c-support.c,
2645         compile/compile-c.h, compile/compile-cplus-symbols.c,
2646         compile/compile-cplus-types.c, compile/compile-cplus.h,
2647         compile/compile-loc2c.c, compile/compile.c, completer.c,
2648         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2649         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2650         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2651         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2652         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2653         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2654         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2655         features/aarch64-core.c, features/aarch64-fpu.c,
2656         features/aarch64-pauth.c, features/aarch64-sve.c,
2657         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2658         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2659         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2660         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2661         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2662         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2663         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2664         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2665         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2666         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2667         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2668         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2669         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2670         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2671         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2672         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2673         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2674         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2675         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2676         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2677         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2678         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2679         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2680         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2681         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2682         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2683         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2684         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2685         minsyms.c, mips-linux-tdep.c, namespace.h,
2686         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2687         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2688         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2689         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2690         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2691         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2692         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2693         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2694         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2695         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2696         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2697         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2698         procfs.c, producer.c, progspace.h, psymtab.h,
2699         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2700         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2701         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2702         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2703         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2704         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2705         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2706         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2707         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2708         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2709         target-memory.c, target.c, target.h, target/waitstatus.c,
2710         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2711         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2712         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2713         unittests/array-view-selftests.c,
2714         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2715         unittests/common-utils-selftests.c,
2716         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2717         unittests/format_pieces-selftests.c,
2718         unittests/function-view-selftests.c,
2719         unittests/lookup_name_info-selftests.c,
2720         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2721         unittests/mkdir-recursive-selftests.c,
2722         unittests/observable-selftests.c,
2723         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2724         unittests/parse-connection-spec-selftests.c,
2725         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2726         unittests/scoped_fd-selftests.c,
2727         unittests/scoped_mmap-selftests.c,
2728         unittests/scoped_restore-selftests.c,
2729         unittests/string_view-selftests.c, unittests/style-selftests.c,
2730         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2731         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2732         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2733         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2734         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2735         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2736
2737 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2738
2739         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2740         bool value.
2741         (decode_digits_ordinary): Set explicit_line field in sal.
2742         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2743         symtab_and_line that was set on an explicit line number in
2744         assembler code.  Do always update the recorded symtab and line if
2745         we do skip the prologue.
2746
2747 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * breakpoint.c (set_breakpoint_location_function): Remove
2750         explicit_loc parameter.
2751         (momentary_breakpoint_from_master): Update call to
2752         set_breakpoint_location_function.
2753         (add_location_to_breakpoint): Likewise.
2754
2755 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2756
2757         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2758         required features based on default bfd type when no specific bfd
2759         is present.
2760
2761 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2762
2763         * NEWS: Mention that GDB printf and eval commands can now print
2764         C-style and Ada-style convenience var strings without
2765         calling the inferior.
2766         * printcmd.c (printf_c_string): Locally print GDB internal var
2767         instead of transiting via the inferior.
2768         (printf_wide_c_string): Likewise.
2769
2770 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2771
2772         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2773
2774 2019-07-04  Tom Tromey  <tom@tromey.com>
2775
2776         PR tui/24724:
2777         * tui/tui-winsource.c (tui_clear_source_content): Update.
2778         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2779         (tui_update_breakpoint_info): Update.
2780         (tui_set_exec_info_content): Update.
2781         * tui/tui-source.c (tui_set_source_content_nil): Update.
2782         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2783         has_break.
2784         * tui/tui-data.h (enum tui_bp_flag): New.
2785         (tui_bp_flags): New enum flags type.
2786         (struct tui_source_element) <break_mode>: Change type.  Rename
2787         from has_break.
2788         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2789         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2790         constants.
2791         * tui/tui-winsource.h: Fix comment.
2792
2793 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2794
2795         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2796         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2797         (store_fpregs_to_thread)
2798         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2799         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2800         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2801         (IWMMXT_REGS_SIZE): Add define.
2802         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2803         (fetch_vfp_regs, store_vfp_regs)
2804         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2805         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2806
2807 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2808
2809         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2810         defines.
2811         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2812         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2813         (ARM_INT_REGISTER_SIZE): ...to this.
2814         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2815         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2816         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2817         (arm_linux_collect_gregset, supply_nwfpe_register)
2818         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2819         defines.
2820         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2821         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2822         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2823         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2824         (arm_return_in_memory, arm_store_return_value)
2825         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2826         (arm_record_ld_st_multiple): Likewise.
2827         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2828         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2829
2830 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2831
2832         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2833         AARCH64_DISPLACED_MODIFIED_INSNS.
2834         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2835         (aarch64_displaced_step_copy_insn): Likewise.
2836         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2837         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2838         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2839         ARM_DISPLACED_MODIFIED_INSNS.
2840         * arm-tdep.c (arm_gdbarch_init): Likewise.
2841         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2842         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2843         (struct arm_displaced_step_closure): Use
2844         ARM_DISPLACED_MODIFIED_INSNS.
2845
2846 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2847
2848         * features/Makefile: Remove unused xml files.
2849         * features/aarch64.xml: Remove.
2850         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2851         * features/i386/amd64-avx-avx512.xml: Remove.
2852         * features/i386/amd64-avx-linux.xml: Remove.
2853         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2854         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2855         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2856         * features/i386/amd64-avx-mpx.xml: Remove.
2857         * features/i386/amd64-avx.xml: Remove.
2858         * features/i386/amd64-linux.xml: Remove.
2859         * features/i386/amd64-mpx-linux.xml: Remove.
2860         * features/i386/amd64-mpx.xml: Remove.
2861         * features/i386/amd64.xml: Remove.
2862         * features/i386/i386-avx-avx512-linux.xml: Remove.
2863         * features/i386/i386-avx-avx512.xml: Remove.
2864         * features/i386/i386-avx-linux.xml: Remove.
2865         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2866         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2867         * features/i386/i386-avx-mpx-linux.xml: Remove.
2868         * features/i386/i386-avx-mpx.xml: Remove.
2869         * features/i386/i386-avx.xml: Remove.
2870         * features/i386/i386-linux.xml: Remove.
2871         * features/i386/i386-mmx-linux.xml: Remove.
2872         * features/i386/i386-mmx.xml: Remove.
2873         * features/i386/i386-mpx-linux.xml: Remove.
2874         * features/i386/i386-mpx.xml: Remove.
2875         * features/i386/i386.xml: Remove.
2876         * features/i386/x32-avx-avx512-linux.xml: Remove.
2877         * features/i386/x32-avx-linux.xml: Remove.
2878         * features/i386/x32-linux.xml: Remove.
2879
2880 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2881
2882         * regformats/aarch64.dat: Remove.
2883         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2884         * regformats/i386/amd64-avx-linux.dat: Remove.
2885         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2886         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2887         * regformats/i386/amd64-linux.dat: Remove.
2888         * regformats/i386/amd64-mpx-linux.dat: Remove.
2889         * regformats/i386/amd64.dat: Remove.
2890         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2891         * regformats/i386/i386-avx-linux.dat: Remove.
2892         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2893         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2894         * regformats/i386/i386-linux.dat: Remove.
2895         * regformats/i386/i386-mmx-linux.dat: Remove.
2896         * regformats/i386/i386-mpx-linux.dat: Remove.
2897         * regformats/i386/i386.dat: Remove.
2898         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2899         * regformats/i386/x32-avx-linux.dat: Remove.
2900         * regformats/i386/x32-linux.dat: Remove.
2901
2902 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2903
2904         * aarch64-tdep.c: Remove xml self tests.
2905         * amd64-linux-tdep.c: Likewise.
2906         * amd64-tdep.c: Likewise.
2907         * i386-linux-tdep.c: Likewise.
2908         * i386-tdep.c: Likewise.
2909
2910 2019-07-03  Pedro Alves  <palves@redhat.com>
2911
2912         PR cli/24732
2913         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2914         (pipe_cmd_option_defs): New.
2915         (make_pipe_cmd_options_def_group): New.
2916         (pipe_command): Use gdb::option::process_options.
2917         (pipe_command_completer): New function.
2918         (_initialize_cli_cmds): Install completer for "pipe" command.
2919
2920 2019-07-03  Pedro Alves  <palves@redhat.com>
2921
2922         * cli/cli-option.c (union option_value) <string>: New field.
2923         (struct option_def_and_value): Add ctor, move ctor, dtor and
2924         use DISABLE_COPY_AND_ASSIGN.
2925         (option_def_and_value::clear_value): New.
2926         (parse_option, save_option_value_in_ctx, get_val_type_str)
2927         (add_setshow_cmds_for_options): Handle var_string.
2928         * cli-option.h (union option_def::var_address) <string>: New
2929         field.
2930         (struct string_option_def): New.
2931         * maint-test-options.c (struct test_options_opts): Add default
2932         ctor and use DISABLE_COPY_AND_ASSIGN.
2933         <string_opt>: New field.
2934         (test_options_opts::~test_options_opts): New.
2935         (test_options_opts::dump): Also dump "-string".
2936         (test_options_option_defs): Install "string.
2937
2938 2019-07-03  Pedro Alves  <palves@redhat.com>
2939
2940         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2941         option_value with a null enumeration.
2942         (complete_options): Save the option values in the context.
2943         (save_option_value_in_ctx): New, factored out from ...
2944         (process_options): ... here.
2945         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2946         of the function.
2947         * maint-test-options.c (test_options_opts::dump): New, factored
2948         out from ...
2949         (maintenance_test_options_command_mode): ... here.
2950         (maintenance_test_options_command_completion_result): Delete.
2951         (maintenance_test_options_command_completion_text): Update
2952         comment.
2953         (maintenance_show_test_options_completion_result): Change
2954         prototype.  Just print
2955         maintenance_test_options_command_completion_text.
2956         (save_completion_result): New.
2957         (maintenance_test_options_completer_mode): Pass options context to
2958         complete_options, and then save a dump.
2959         (_initialize_maint_test_options): Use add_cmd to install "maint
2960         show test-options-completion-result".
2961
2962 2019-07-03  Pedro Alves  <palves@redhat.com>
2963
2964         * NEWS (New commands): Mention "with" and "maint with".
2965         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2966         (with_command, with_command_completer): New.
2967         (pipe_command): Adjust to new repeat_previous
2968         interface.
2969         (_initialize_cli_cmds): Install the "with" command and its "w"
2970         alias.
2971         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2972         declarations.
2973         * cli/cli-setshow.c (parse_cli_var_uinteger)
2974         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2975         argument strings for all var_types.
2976         (get_setshow_command_value_string): New, factored out from ...
2977         (do_show_command): ... this.
2978         * cli/cli-setshow.h: Include <string>.
2979         (get_setshow_command_value_string): Declare.
2980         * command.h (repeat_previous): Now returns const char *.  Adjust
2981         comment.
2982         * maint.c: Include "cli/cli-cmds.h".
2983         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2984         (_initialize_maint_cmds): Register the "maintenance with" command.
2985         * top.c (repeat_previous): Move bits from pipe_command here:
2986         Return the saved command line, if any; error out if there's no
2987         command to relaunch.
2988
2989 2019-07-03  Pedro Alves  <palves@redhat.com>
2990
2991         * NEWS (New commands): Mention "maint set/show test-settings"
2992         instead of "maint test-settings".
2993         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2994         (maintenance_test_settings_set_list): Rename to ...
2995         (maintenance_set_test_settings_list): ... this.
2996         (maintenance_test_settings_show_list): Rename to  ...
2997         (maintenance_show_test_settings_list): ... this.
2998         (maintenance_test_settings_cmd): Delete.
2999         (maintenance_test_settings_set_cmd): ...
3000         (maintenance_set_test_settings_cmd): ... this.
3001         (maintenance_test_settings_show_cmd): ...
3002         (maintenance_show_test_settings_cmd): ... this.
3003         (maintenance_test_settings_show_value_cmd):
3004         (maintenance_show_test_settings_value_cmd): ... this.
3005         (_initialize_maint_test_settings): No longer install the "maint
3006         test-settings" prefix command.  Rename "maint test-settings set"
3007         to "maint set test-settings", and "maint test-settings show" to
3008         "maint show test-settings".  Adjust all subcommands.
3009
3010 2019-07-03  Pedro Alves  <palves@redhat.com>
3011
3012         * maint-test-settings.c: Fix file's intro comment.  Replace all
3013         references to "test-options" with references to "test-settings",
3014         in comments.
3015
3016 2019-07-03  Pedro Alves  <palves@redhat.com>
3017
3018         * maint-test-settings.c (maintenance_test_settings_xxx)
3019         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3020         New.
3021         (maintenance_test_settings_enums): Use them.
3022         (maintenance_test_settings_enum): Default to
3023         maintenance_test_settings_xxx.
3024         (_initialize_maint_test_settings): Initialize
3025         MAINTENANCE_TEST_SETTINGS_FILENAME.
3026
3027 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3028
3029         * breakpoint.h (remove_breakpoints_inf): Change return type to
3030         void, move function documentation here.
3031         * breakpoint.c (remove_breakpoints_inf): Change return type to
3032         void, move function documentation to header.
3033
3034 2019-07-02  Pedro Alves  <palves@redhat.com>
3035
3036         * NEWS (Completion improvements): Mention "info threads".
3037         * thread.c (struct info_threads_opts, info_threads_option_defs)
3038         (make_info_threads_options_def_group): New.
3039         (info_threads_command): Use gdb::option::process_options.
3040         (info_threads_command_completer): New.
3041         (_initialize_thread): Use gdb::option::build_help to build the
3042         help text for "info threads".
3043
3044 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3045
3046         * defs.h (generic_load): Move from here...
3047         * symfile.h (generic_load): ... to here.  Rename name parameter
3048         to args.
3049         * symfile.c (generic_load): Add comment.
3050
3051 2019-07-01  Tom Tromey  <tromey@adacore.com>
3052
3053         * dwarf2read.c
3054         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3055         declaration of without_params.  Fix formatting.
3056
3057 2019-07-01  Tom Tromey  <tromey@adacore.com>
3058
3059         * ada-exp.y (find_primitive_type): Update.
3060         * ada-lang.h (ada_lookup_symbol): Update.
3061         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3062         parameter.
3063         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3064
3065 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3066
3067         PR breakpoints/24541
3068         * gdbarch.c: Regenerate.
3069         * gdbarch.h: Regenerate.
3070         * gdbarch.sh: Add 'stap_adjust_register'.
3071         * i386-tdep.c: Include '<unordered_set>'.
3072         (i386_stap_adjust_register): New function.
3073         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3074         * stap-probe.c (stap_parse_register_operand): Call
3075         'gdbarch_stap_adjust_register'.
3076
3077 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3078
3079         PR python/24742
3080         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3081         * python/python.c (do_start_initialization): Use 'xmalloc'
3082         instead of 'PyMem_Malloc'.
3083
3084 2019-06-28  Tom Tromey  <tromey@adacore.com>
3085
3086         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3087         for Ada.
3088
3089 2019-06-27  Tom Tromey  <tromey@adacore.com>
3090
3091         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3092         objfile_key.
3093         (arm_find_mapping_symbol, arm_record_special_symbol)
3094         (_initialize_arm_tdep): Update.
3095         (arm_objfile_data_free): Remove.
3096
3097 2019-06-27  Tom Tromey  <tromey@adacore.com>
3098
3099         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3100         to cp_print_static_field.
3101
3102 2019-06-26  Tom Tromey  <tromey@adacore.com>
3103
3104         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3105         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3106         declare.
3107
3108 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3109
3110         * features/aarch64-core.c (create_feature_aarch64_core):
3111         Regenerate.
3112         * features/aarch64-core.xml: Add cpsr flags.
3113
3114 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3115
3116         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3117         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3118
3119 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3120
3121         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3122         field.
3123         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3124         use.
3125         (arm_record_special_symbol): Don't insert new symbol in sorted
3126         position, push it at the end.
3127
3128 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3129
3130         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3131         (arm_mapping_symbol_s): Remove.
3132         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3133         (arm_mapping_symbol_vec): New typedef.
3134         (struct arm_per_objfile): Add constructor.
3135         <section_maps>: Change type to
3136         std::unique_ptr<arm_mapping_symbol_vec[]>.
3137         (arm_compare_mapping_symbols): Remove.
3138         (arm_find_mapping_symbol): Adjust to section_maps type change.
3139         (arm_objfile_data_free): Call delete on arm_per_objfile.
3140         (arm_record_special_symbol): Adjust to section_maps type change.
3141         Allocate arm_per_objfile with new.
3142
3143 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3144
3145         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3146         with the command prefix.
3147
3148 2019-06-25  Tom Tromey  <tom@tromey.com>
3149
3150         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3151         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3152
3153 2019-06-25  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3156         type.
3157         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3158         protected.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-winsource.c
3163         (tui_source_window_base::set_is_exec_point_at): Add check against
3164         LOA_ADDRESS.
3165
3166 2019-06-25  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-source.c (tui_set_source_content): Don't check before
3169         xfree.
3170         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3171
3172 2019-06-25  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-winsource.h (tui_update_source_window_as_is)
3175         (tui_alloc_source_buffer, tui_line_is_displayed)
3176         (tui_addr_is_displayed): Change type of win_info.
3177         * tui/tui-winsource.c (tui_update_source_window_as_is)
3178         (tui_clear_source_content, tui_show_source_line)
3179         (tui_show_source_content, tui_source_window_base::refill)
3180         (tui_source_window_base::set_is_exec_point_at)
3181         (tui_source_window_base::set_is_exec_point_at)
3182         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3183         (tui_alloc_source_buffer, tui_line_is_displayed)
3184         (tui_addr_is_displayed): Change type of win_info.  Update.
3185         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3186         (tui_source_window_base::do_make_visible_with_new_height):
3187         Update.
3188         * tui/tui-source.c (tui_set_source_content)
3189         (tui_set_source_content_nil)
3190         (tui_source_window::do_scroll_vertical): Update.
3191         * tui/tui-layout.c (show_layout): Update.
3192         * tui/tui-disasm.c (tui_set_disassem_content)
3193         (tui_disasm_window::do_scroll_vertical): Update.
3194         * tui/tui-data.h (tui_win_content): Remove.
3195         (struct tui_gen_win_info) <content, content_size>: Remove.
3196         (struct tui_source_element): Add initializers and destructor.
3197         (union tui_which_element, struct tui_win_element): Remove.
3198         (struct tui_source_window_base) <content>: New field.
3199         (struct tui_data_window): Remove destructor.
3200         (tui_alloc_content, tui_free_win_content)
3201         (tui_free_all_source_wins_content): Don't declare.
3202         * tui/tui-data.c (tui_initialize_static_data): Update.
3203         (init_content_element, tui_alloc_content): Remove.
3204         (~tui_gen_win_info): Update.
3205         (~tui_data_window, tui_free_all_source_wins_content)
3206         (tui_free_win_content, free_content, free_content_elements):
3207         Remove.
3208
3209 2019-06-25  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-winsource.h (tui_clear_source_content)
3212         (tui_erase_source_content, tui_show_source_content): Change type
3213         of win_info.
3214         * tui/tui-winsource.c (tui_clear_source_content)
3215         (tui_erase_source_content, tui_show_source_content): Change type
3216         of win_info.
3217         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3218         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3219         win_info.
3220         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3221         win_info.
3222         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3223
3224 2019-06-25  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-winsource.c (tui_clear_source_content)
3227         (tui_source_window_base::set_is_exec_point_at): Update.
3228         * tui/tui-source.c (tui_set_source_content_nil): Update.
3229         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3230         a bool.
3231         * tui/tui-data.c (init_content_element): Update.
3232
3233 2019-06-25  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3236         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3237         * tui/tui-layout.c (init_and_make_win): Update.
3238         * tui/tui.h (enum tui_win_type): Update.
3239         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3240         tui_win_is_auxillary.
3241         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3242         tui_win_is_auxillary.
3243
3244 2019-06-25  Tom Tromey  <tom@tromey.com>
3245
3246         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3247         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3248         (tui_delete_data_content_windows, tui_display_all_data)
3249         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3250         Update.
3251         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3252         * tui/tui-regs.c (tui_last_regs_line_no)
3253         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3254         (tui_show_registers): Update.
3255         (tui_show_register_group): Return void.  Update.
3256         (tui_display_registers_from, tui_display_reg_element_at_line)
3257         (tui_display_registers_from_line, tui_check_register_values):
3258         Update.
3259         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3260         member.
3261         (struct tui_data_window) <regs_content>: Now a std::vector.
3262         <regs_content_count>: Remove.
3263         (tui_add_content_elements, tui_free_data_content): Don't declare.
3264         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3265         (init_content_element): Remove DATA_WIN case.  Add assert.
3266         (tui_add_content_elements): Remove.
3267         (tui_data_window): Update.
3268         (tui_free_data_content): Remove.
3269         (free_content_elements): Remove DATA_WIN case.
3270
3271 2019-06-25  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-data.c (tui_data_item_window): Update.
3274         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3275         * tui/tui-windata.c (tui_display_all_data)
3276         (tui_display_data_from_line): Update.
3277         (tui_check_data_values): Remove.
3278         * tui/tui-regs.c (tui_show_register_group)
3279         (tui_display_reg_element_at_line): Update.
3280         * tui/tui-hooks.c (tui_register_changed)
3281         (tui_refresh_frame_and_register_information): Call
3282         tui_check_register_values.
3283         * tui/tui-data.h (struct tui_data_window) <data_content,
3284         data_content_count, data_type>: Remove.
3285         (enum tui_data_type): Remove.
3286
3287         * tui/tui-data.c (tui_data_window::clear_detail)
3288         (~tui_data_window): Update.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3293         declare.
3294         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3295         Rename from tui_first_data_item_displayed.  Update.
3296         (tui_data_window::refresh_all)
3297         (tui_data_window::do_scroll_vertical): Update.
3298         * tui/tui-data.h (struct tui_data_window)
3299         <first_data_item_displayed>: Declare new method.
3300
3301 2019-06-25  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3304         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3305         contents...
3306         (tui_initialize_static_data): ...here.
3307
3308 2019-06-25  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3311         (tui_display_registers_from, tui_check_register_values): Update.
3312         (tui_display_register): Remove win_info parameter; update.
3313         (tui_get_register): Change type of parameters.
3314         * tui/tui-data.h (struct tui_data_element): Remove.
3315         (union tui_which_element) <data>: Remove.
3316         <data_window>: Change type.
3317         (struct tui_data_item_window): New.
3318         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3319         case.  Add assert.
3320         (~tui_data_item_window): New destructor.
3321         (free_content_elements): Remove DATA_ITEM_WIN case.
3322
3323 2019-06-25  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3326         Remove.
3327
3328 2019-06-25  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-data.h (struct tui_command_element): Remove.
3331         (union tui_which_element) <command>: Remove.
3332         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3333         assert.
3334         (free_content_elements): Remove CMD_WIN case.
3335
3336 2019-06-25  Tom Tromey  <tom@tromey.com>
3337
3338         * tui/tui-layout.c (tui_set_layout): Update.
3339         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3340         * tui/tui-data.c (layout_def): Update.
3341
3342 2019-06-25  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3345         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3346         (tui_source_window_base::set_new_height): Update.
3347         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3348         Update.
3349         (tui_set_locator_fullname, tui_set_locator_info)
3350         (tui_show_frame_info): Update.
3351         * tui/tui-source.c (tui_set_source_content)
3352         (tui_source_is_displayed): Update.
3353         * tui/tui-layout.c (show_source_disasm_command, show_data)
3354         (show_source_or_disasm_and_command): Update.
3355         * tui/tui-disasm.c (tui_set_disassem_content)
3356         (tui_get_begin_asm_address): Update.
3357         * tui/tui-data.h (struct tui_locator_element): Remove.
3358         (union tui_which_element) <locator>: Remove.
3359         (struct tui_locator_window): New.
3360         (tui_locator_win_info_ptr): Change return type.
3361         * tui/tui-data.c (_locator): Change type.
3362         (tui_locator_win_info_ptr): Change return type.
3363         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3364         (tui_alloc_content): Add assert.
3365
3366 2019-06-25  Tom Tromey  <tom@tromey.com>
3367
3368         * tui/tui-winsource.c
3369         (tui_exec_info_window::maybe_allocate_content): New method.
3370         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3371         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3372         (make_source_or_disasm_window): Add cast.
3373         * tui/tui-data.h (union tui_which_element) <simple_string>:
3374         Remove.
3375         (struct tui_source_info): New.
3376         (struct tui_source_window_base) <execution_info>: Change type.
3377         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3378         case, and add assert.
3379         (tui_alloc_content): Add assert.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3384         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3385         * tui/tui-data.c (tui_alloc_win_info): Remove.
3386
3387 2019-06-25  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3390         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3391         can_highlight.
3392
3393 2019-06-25  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3396         make_visible_with_new_height method.
3397         (tui_win_info::make_visible_with_new_height): New method.
3398         (tui_source_window_base::do_make_visible_with_new_height)
3399         (tui_data_window::do_make_visible_with_new_height)
3400         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3401         (make_visible_with_new_height): Remove.
3402         (tui_resize_all, tui_adjust_win_heights): Use
3403         make_visible_with_new_height method.
3404         * tui/tui-data.h (struct tui_win_info)
3405         <do_make_visible_with_new_height, make_visible_with_new_height>:
3406         New methods.
3407         (struct tui_source_window_base, struct tui_data_window)
3408         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3409         methods.
3410
3411 2019-06-25  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3414         method.
3415         (update_tab_width): Call update_tab_width method.
3416         * tui/tui-data.h (struct tui_win_info)
3417         (struct tui_source_window_base) <update_tab_width>: New methods.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3422         parameter.
3423         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3424         parameter.
3425         (tui_gen_win_info::make_visible): Update.
3426         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3427         parameter.
3428         * tui/tui-data.h (enum tui_box): New enum.
3429         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3430
3431 2019-06-25  Tom Tromey  <tom@tromey.com>
3432
3433         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3434         init_and_make_win for EXEC_INFO_WIN.
3435         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3436         longer inline.
3437         (struct tui_win_info) <~tui_win_info>: Inline.
3438         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3439         Don't declare.
3440         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3441         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3442         Remove.
3443         (tui_initialize_static_data): Update.
3444         (~tui_gen_win_info): Handle more cleanup here.
3445         (~tui_source_window_base): Delete "execution_info".
3446         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3447
3448 2019-06-25  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-layout.c (make_command_window): Don't set
3451         can_highlight.
3452         (show_source_disasm_command): Call the reset method.
3453         (show_data): Don't set can_highlight.  Call the reset method.
3454         (tui_gen_win_info::reset): Rename from init_gen_win_info
3455         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3456         (show_source_or_disasm_and_command): Call the reset method.
3457         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3458         (struct tui_cmd_window): Set can_highlight.
3459
3460 2019-06-25  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3463         from make_visible.
3464         (tui_make_visible, tui_make_invisible): Rewrite.
3465         (tui_win_info::make_visible): Remove.
3466         (tui_source_window_base::make_visible): Update.
3467         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3468         method.  Moved from...
3469         (struct tui_win_info) <make_visible>: ...here.
3470
3471 2019-06-25  Tom Tromey  <tom@tromey.com>
3472
3473         * tui/tui-winsource.c
3474         (tui_source_window_base::do_scroll_horizontal): Remove direction
3475         parameter.
3476         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3477         direction parameter.
3478         * tui/tui-win.c (tui_win_info::forward_scroll)
3479         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3480         (tui_win_info::right_scroll): Update.
3481         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3482         direction parameter.
3483         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3484         direction parameter.
3485         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3486         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3487         Remove direction parameter.
3488         (struct tui_source_window_base, struct tui_source_window)
3489         (struct tui_disasm_window, struct tui_data_window)
3490         (struct tui_cmd_window): Update.
3491
3492 2019-06-25  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-winsource.h (tui_set_exec_info_content)
3495         (tui_show_exec_info_content, tui_erase_exec_info_content)
3496         (tui_clear_exec_info_content, tui_update_exec_info): Change
3497         argument to tui_source_window_base.
3498         * tui/tui-winsource.c (tui_set_exec_info_content)
3499         (tui_show_exec_info_content, tui_erase_exec_info_content)
3500         (tui_clear_exec_info_content, tui_update_exec_info): Change
3501         argument to tui_source_window_base.
3502
3503 2019-06-25  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3506         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3507
3508 2019-06-25  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3511         check.
3512
3513 2019-06-25  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3516         type to void.
3517         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3518         type to void.
3519         * tui/tui-source.c (tui_set_source_content): Update.
3520         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3521
3522 2019-06-25  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-win.c (window_name_completer, tui_set_focus)
3525         (tui_all_windows_info): Use name method.
3526         * tui/tui-data.h (struct tui_gen_win_info)
3527         (struct tui_source_window, struct tui_disasm_window)
3528         (struct tui_data_window, struct tui_cmd_window) <name>: New
3529         method.
3530         (tui_win_name): Don't declare.
3531         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3532         (tui_win_name): Remove.
3533
3534 2019-06-25  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-winsource.h (tui_update_source_window)
3537         (tui_update_source_window_as_is): Change parameter type.
3538         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3539         to be a tui_source_window_base.
3540         (tui_update_source_window_as_is): Likewise.
3541         * tui/tui-win.c (make_visible_with_new_height): Update.
3542
3543 2019-06-25  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-winsource.c (tui_erase_source_content)
3546         (tui_show_source_content, tui_show_exec_info_content)
3547         (tui_erase_exec_info_content): Use refresh_window method.
3548         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3549         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3550         from tui_refresh_win.
3551         (tui_data_window::refresh_window): New method.
3552         (tui_win_info::refresh, tui_source_window_base::refresh)
3553         (tui_refresh_all): Use refresh_window method.
3554         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3555         method.
3556         * tui/tui-regs.c (tui_display_register): Call refresh_window
3557         method.
3558         * tui/tui-layout.c (show_source_disasm_command)
3559         (show_source_or_disasm_and_command): Call refresh_window method.
3560         * tui/tui-data.h (struct tui_gen_win_info)
3561         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3562         New method.
3563
3564 2019-06-25  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui.c (tui_rl_other_window, tui_enable)
3567         (tui_is_window_visible, tui_get_command_dimension): Update.
3568         * tui/tui-winsource.c (tui_update_source_window_as_is)
3569         (tui_clear_source_content, tui_erase_source_content)
3570         (tui_show_source_line, tui_source_window_base::refill)
3571         (tui_source_window_base::do_scroll_horizontal)
3572         (tui_source_window_base::set_is_exec_point_at)
3573         (tui_update_breakpoint_info, tui_set_exec_info_content)
3574         (tui_alloc_source_buffer, tui_line_is_displayed)
3575         (tui_addr_is_displayed): Update.
3576         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3577         (tui_check_and_display_highlight_if_needed)
3578         (tui_win_info::make_visible, tui_win_info::refresh)
3579         (tui_refresh_all): Update.
3580         * tui/tui-windata.c (tui_first_data_item_displayed)
3581         (tui_delete_data_content_windows, tui_erase_data_content)
3582         (tui_display_all_data, tui_data_window::refresh_all)
3583         (tui_check_data_values): Update.
3584         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3585         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3586         (tui_win_info::backward_scroll, tui_refresh_all_win)
3587         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3588         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3589         (tui_source_window_base::set_new_height)
3590         (tui_data_window::set_new_height)
3591         (make_invisible_and_set_new_height)
3592         (make_visible_with_new_height, new_height_ok)
3593         (parse_scrolling_args): Update.
3594         * tui/tui-stack.c (tui_show_frame_info): Update.
3595         * tui/tui-source.c (tui_set_source_content)
3596         (tui_set_source_content_nil, tui_source_is_displayed)
3597         (tui_source_window::do_scroll_vertical): Update.
3598         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3599         (tui_display_registers_from, tui_display_reg_element_at_line)
3600         (tui_check_register_values, tui_reg_command): Update.
3601         * tui/tui-layout.c (tui_default_win_height)
3602         (show_source_disasm_command, show_data, init_and_make_win)
3603         (show_source_or_disasm_and_command): Update.
3604         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3605         (tui_redisplay_readline, tui_mld_flush)
3606         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3607         (tui_getc): Update.
3608         * tui/tui-disasm.c (tui_set_disassem_content)
3609         (tui_disasm_window::do_scroll_vertical): Update.
3610         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3611         Now virtual.
3612         (struct tui_win_info): Derive from tui_gen_win_info.
3613         <~tui_win_info>: Mark as override.
3614         <generic>: Remove member.
3615         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3616         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3617         (~tui_data_window, ~tui_win_info)
3618         (tui_free_all_source_wins_content): Update.
3619         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-layout.c (init_and_make_win): Use new.
3624         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3625         destructor, initializers.
3626         (tui_alloc_generic_win_info): Don't declare.
3627         * tui/tui-data.c (_locator): Add argument to constructor.
3628         (source_win, disasm_win): New globals.
3629         (exec_info): Remove.
3630         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3631         Update.
3632         (tui_alloc_generic_win_info): Remove.
3633         (init_content_element): Use new.
3634         (tui_win_info::tui_win_info): Update.
3635         (free_content_elements) <case DATA_WIN>: Use delete.
3636
3637 2019-06-25  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3640         * tui/tui-windata.c (tui_first_data_item_displayed)
3641         (tui_delete_data_content_windows): Update.
3642         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3643         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3644         (tui_display_registers_from, tui_check_register_values): Update.
3645         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3646         pointer.
3647         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3648         window.
3649         (tui_free_data_content): Update.
3650         (free_content_elements) <case DATA_WIN>: Free the window.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3655         Update.
3656         * tui/tui-layout.c (make_command_window)
3657         (show_source_disasm_command, show_data, init_and_make_win)
3658         (show_source_or_disasm_and_command): Update.
3659         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3660         method.
3661         <can_highight, is_highlighted>: Now bool.
3662         (tui_set_win_highlight): Don't declare.
3663         * tui/tui-data.c (tui_set_win_highlight): Remove.
3664
3665 2019-06-25  Tom Tromey  <tom@tromey.com>
3666
3667         * tui/tui-wingeneral.c (make_visible): Remove check of window
3668         type.
3669
3670 2019-06-25  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-win.c (tui_win_info::max_height)
3673         (tui_cmd_window::max_height): New methods.
3674         (new_height_ok): Call max_height.
3675         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3676         <max_height>: New method.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-win.c (tui_source_window_base::set_new_height)
3681         (tui_data_window::set_new_height): New methods.
3682         (make_invisible_and_set_new_height): Call set_new_height method.
3683         * tui/tui-data.h (struct tui_win_info)
3684         (struct tui_source_window_base, struct tui_data_window)
3685         <set_new_height>: New method.
3686
3687 2019-06-25  Tom Tromey  <tom@tromey.com>
3688
3689         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3690         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3691         tui_refresh_data_win.
3692         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3693         method.
3694         (tui_refresh_all_win): Call the refresh_all method.
3695         (tui_set_focus): Likewise.
3696         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3697         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3698         Likewise.
3699
3700 2019-06-25  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui-winsource.h (tui_refill_source_window)
3703         (tui_set_is_exec_point_at): Don't declare.
3704         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3705         (tui_source_window_base::refill): Rename from
3706         tui_refill_source_window.
3707         (tui_source_window_base::do_scroll_horizontal): Update.
3708         (tui_source_window_base::set_is_exec_point_at): Rename from
3709         tui_set_is_exec_point_at.
3710         (tui_update_all_breakpoint_info): Update.
3711         * tui/tui-stack.c (tui_show_frame_info): Update.
3712         * tui/tui-layout.c (show_data): Add cast.
3713         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3714         * tui/tui-data.h (struct tui_source_window_base) <refill,
3715         set_is_exec_point_at>: New methods.
3716         (tui_source_windows, tui_add_to_source_windows): Update types.
3717         (tui_add_to_source_windows): Remove redundant declaration.
3718         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3719         (tui_source_windows): Change return type.
3720         (tui_clear_source_windows_detail): Update.
3721         (tui_add_to_source_windows): Change type of parameter.
3722         (tui_free_all_source_wins_content): Update.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-wingeneral.c (tui_win_info::refresh)
3727         (tui_source_window_base::refresh): New methods.
3728         (tui_refresh_all): Call the refresh method.
3729         * tui/tui-data.h (struct tui_win_info)
3730         (struct tui_source_window_base) <refresh>: New method.
3731
3732 2019-06-25  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui.h (tui_is_window_visible): Return bool.
3735         * tui/tui.c (tui_is_window_visible): Return bool.
3736         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3737         (tui_make_visible, tui_make_invisible)
3738         (tui_win_info::make_visible)
3739         (tui_source_window_base::make_visible, make_all_visible)
3740         (tui_make_all_visible, tui_make_all_invisible): Update.
3741         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3742         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3743         bool.
3744         (struct tui_win_info, struct tui_source_window_base)
3745         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3746         * tui/tui-data.c (tui_init_generic_part): Update.
3747
3748 2019-06-25  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3751         (tui_source_window_base::make_visible): New methods.
3752         (make_all_visible): Make method call.
3753         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3754         (struct tui_source_window_base, struct tui_cmd_window): Override
3755         make_visible.
3756         (tui_win_is_source_type): Don't declare.
3757         * tui/tui-data.c (tui_win_is_source_type): Remove.
3758
3759 2019-06-25  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3762         NULL check.
3763
3764 2019-06-25  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3767         Inline constructor.  Add initializers for members.
3768         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3769         constructors; now inline in class.
3770
3771 2019-06-25  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui-regs.c (tui_show_registers): Update.
3774         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3775         bool.
3776         * tui/tui-data.c (tui_data_window::clear_detail)
3777         (tui_data_window): Update.
3778
3779 2019-06-25  Tom Tromey  <tom@tromey.com>
3780
3781         * tui/tui-windata.c (tui_display_all_data)
3782         (tui_display_data_from_line, tui_display_data_from)
3783         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3784         Update.
3785         * tui/tui-regs.c (tui_last_regs_line_no)
3786         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3787         (tui_show_registers, tui_show_register_group)
3788         (tui_display_registers_from, tui_display_reg_element_at_line)
3789         (tui_display_registers_from_line, tui_check_register_values)
3790         (tui_reg_next, tui_reg_prev): Update.
3791         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3792         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3793         tui_data_window.
3794         (struct tui_win_info) <detail>: Remove.  Add new fields from
3795         tui_data_info.
3796         (TUI_DATA_WIN): Add cast.
3797         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3798         (~tui_data_window): Simplify.
3799
3800 2019-06-25  Tom Tromey  <tom@tromey.com>
3801
3802         * tui/tui-layout.c (show_source_disasm_command)
3803         (show_source_or_disasm_and_command): Update.
3804         * tui/tui-io.c (update_cmdwin_start_line)
3805         (tui_redisplay_readline): Update.
3806         * tui/tui-data.h (struct tui_command_info): Remove.
3807         (struct tui_win_info) <detail>: Remove command_info member.
3808         (struct tui_data_window) <start_line>: New member, from
3809         tui_command_info.
3810         (TUI_CMD_WIN): Add casts.
3811
3812 2019-06-25  Tom Tromey  <tom@tromey.com>
3813
3814         * tui/tui-winsource.c (tui_update_source_window)
3815         (tui_refill_source_window)
3816         (tui_source_window_base::do_scroll_horizontal)
3817         (tui_update_breakpoint_info, tui_set_exec_info_content)
3818         (tui_show_exec_info_content, tui_erase_exec_info_content)
3819         (tui_clear_exec_info_content): Update.
3820         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3821         Update.
3822         * tui/tui-win.c (make_invisible_and_set_new_height)
3823         (make_visible_with_new_height): Update.
3824         * tui/tui-source.c (tui_set_source_content)
3825         (tui_show_symtab_source): Update.
3826         * tui/tui-layout.c (extract_display_start_addr)
3827         (show_source_disasm_command, show_data)
3828         (make_source_or_disasm_window)
3829         (show_source_or_disasm_and_command): Update.
3830         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3831         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3832         "gdbarch".
3833         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3834         to tui_source_window_base.
3835         (struct tui_win_info) <detail>: Remove source_info member.
3836         (struct tui_source_window_base) <has_locator>: Inline.
3837         Move contents from tui_source_info; rename has_locator member to
3838         m_has_locator.
3839         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3840         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3841         header file.
3842         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3843         Simplify.
3844         (tui_free_all_source_wins_content): Cast to
3845         tui_source_window_base.
3846
3847 2019-06-25  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-win.c (make_invisible_and_set_new_height)
3850         (make_visible_with_new_height): Call has_locator method.
3851         * tui/tui-layout.c (show_source_disasm_command, show_data)
3852         (show_source_or_disasm_and_command): Update for bool change.
3853         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3854         (tui_win_info) <has_locator>: New method.
3855         (struct tui_source_window_base) <has_locator>: New method.
3856         (tui_win_has_locator): Don't declare.
3857         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3858         from tui_win_has_locator.
3859         (tui_source_window_base): Use false, not FALSE.
3860
3861 2019-06-25  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3864         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3865         clear_detail method directly.
3866         (tui_clear_win_detail): Remove.
3867
3868 2019-06-25  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3871         "this", not TUI_DISASM_WIN.
3872
3873 2019-06-25  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3876         declare.
3877         * tui/tui-winsource.c
3878         (tui_source_window_base::do_scroll_horizontal): Rename from
3879         tui_horizontal_source_scroll.
3880         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3881         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3882         from tui_vertical_data_scroll.
3883         * tui/tui-win.h (tui_scroll): Don't declare.
3884         * tui/tui-win.c (tui_win_info::forward_scroll)
3885         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3886         (tui_win_info::right_scroll): Rename and update.
3887         (tui_scroll_forward_command, tui_scroll_backward_command)
3888         (tui_scroll_left_command, tui_scroll_right_command): Update.
3889         (tui_scroll): Remove.
3890         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3891         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3892         from tui_vertical_source_scroll.
3893         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3894         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3895         from tui_vertical_disassem_scroll.
3896         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3897         do_scroll_horizontal>: New methods.
3898         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3899         Likewise.
3900         (struct tui_source_window_base): Add do_scroll_horizontal.
3901         (struct tui_source_window, struct tui_disasm_window): Add
3902         do_scroll_vertical.
3903         (struct tui_data_window, struct tui_cmd_window): Add
3904         do_scroll_horizontal and do_scroll_vertical.
3905         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3906
3907 2019-06-25  Tom Tromey  <tom@tromey.com>
3908
3909         * tui/tui-data.h (struct tui_source_window_base): New struct.
3910         (struct tui_source_window): Derive from tui_source_window_base.
3911         (struct tui_disasm_window): New struct.
3912         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3913         from tui_source_window::clear_detail.
3914         (tui_source_window_base): Rename from tui_source_window.
3915         (~tui_source_window_base): Rename from ~tui_source_window.
3916         (tui_alloc_win_info): Create a tui_disasm_window.
3917
3918 2019-06-25  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-data.h (struct tui_source_window)
3921         (struct tui_data_window): Declare destructors.
3922         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3923         destructors.
3924         (tui_win_info): Simplify.
3925
3926 2019-06-25  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-winsource.c (tui_display_main)
3929         (tui_update_source_windows_with_addr)
3930         (tui_update_all_breakpoint_info): Update.
3931         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3932         (new_height_ok, parse_scrolling_args): Update.
3933         * tui/tui-stack.c (tui_show_frame_info): Update.
3934         * tui/tui-data.h (struct tui_list): Remove.
3935         (tui_source_windows): Return a reference to a std::vector.
3936         * tui/tui-data.c (source_windows): Now a std::vector.
3937         (tui_source_windows): Change return type.
3938         (tui_clear_source_windows): Rewrite.
3939         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3940         (tui_free_all_source_wins_content): Rewrite.
3941
3942 2019-06-25  Tom Tromey  <tom@tromey.com>
3943
3944         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3945         (struct tui_data_window, struct tui_cmd_window): Declare
3946         clear_detail method.
3947         * tui/tui-data.c (tui_source_window::clear_detail)
3948         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3949         methods.
3950         (tui_clear_win_detail): Simplify.
3951
3952 2019-06-25  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-layout.c (make_source_window, make_disasm_window)
3955         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3956         Return the new window.
3957         (show_source_disasm_command, show_data)
3958         (show_source_or_disasm_and_command): Update.
3959
3960 2019-06-25  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3963         parameter.  Return the new window.
3964         (show_source_disasm_command): Update and remove NULL check.
3965         (show_source_or_disasm_and_command): Update.
3966
3967 2019-06-25  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3970
3971 2019-06-25  Tom Tromey  <tom@tromey.com>
3972
3973         * tui/tui-data.h (struct tui_win_info): Make constructor
3974         protected.  Make destructor virtual.  Add initializers.
3975         (tui_source_window, tui_data_window, tui_cmd_window): New
3976         classes.
3977         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3978         constructor.  Add "type" parameter.
3979         (tui_source_window, tui_data_window, tui_cmd_window): New
3980         constructors.
3981         (tui_alloc_win_info): Instantiate the appropriate subclass.
3982
3983 2019-06-25  Tom Tromey  <tom@tromey.com>
3984
3985         * tui/tui-win.c (tui_resize_all): Use delete.
3986         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3987         destructor.
3988         (tui_free_window): Don't declare.
3989         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3990         Update.
3991
3992 2019-06-25  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-data.h (struct tui_win_info): Add constructor.
3995         * tui/tui-data.c (tui_alloc_win_info): Use new.
3996         (tui_free_window): Use delete.
3997
3998 2019-06-22  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4001         declare.
4002         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4003
4004 2019-06-22  Tom Tromey  <tom@tromey.com>
4005
4006         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4007         declare.
4008         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4009
4010 2019-06-22  Tom de Vries  <tdevries@suse.de>
4011
4012         * dwarf2read.c (create_addrmap_from_aranges)
4013         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4014         instead of '%zu'.
4015
4016 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4017
4018         * dwarf2read.h (dwarf2_section_info_def): Remove.
4019         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4020         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4021         std::vector<dwarf2_section_info>.
4022         (struct dwo_file) <~dwo_file>: Remove.
4023         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4024         types field.
4025         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4026         (dwarf2_read_debug_names): Likewise.
4027         (create_debug_types_hash_table): Change parameter type to
4028         array_view, adjust code accordingly.
4029         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4030         (partial_die_info::fixup): Likewise.
4031         (determine_prefix): Likewise.
4032         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4033
4034 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4035
4036         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4037         gdb_bfd_ref_ptr.
4038         <~dwo_file>: Remove call to gdb_bfd_unref.
4039         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4040         gdb_bfd_ref_ptr::get.
4041
4042 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4043
4044         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4045         type to htab_up.
4046         * dwarf2read.c (struct dwo_file): Initialize fields.
4047         <~dwo_file>: New.
4048         (free_dwo_file): Remove, move content to ~dwo_file.
4049         (struct dwo_file_deleter): Remove.
4050         (dwo_file_up>: Remove custom deleter.
4051         (free_dwo_files): Remove.
4052         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4053         dwo_files.
4054         (process_skeletonless_type_units): Call unique_ptr::get.
4055         (allocate_dwo_file_hash_table): Add deleter to created hash
4056         table.  Change return type to htab_up.
4057         (lookup_dwo_file_slot): Don't memset dwo_file, call
4058         unique_ptr::get.
4059         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4060         (create_dwo_unit_in_dwp_v2): Likewise.
4061         (open_and_init_dwo_file): Likewise.
4062         (free_dwo_file_from_slot): Remove.
4063
4064 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4065
4066         * dwarf2read.h (struct dwarf2_section_info) <readin,
4067         is_virtual>: Change type to bool.
4068         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4069         true instead of 1.
4070
4071 2019-06-19  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-data.h (tui_init_content_element): Don't declare.
4074
4075 2019-06-19  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-data.h (tui_init_win_info): Don't declare.
4078
4079 2019-06-19  Tom de Vries  <tdevries@suse.de>
4080
4081         * dwarf2read.h (abstract_to_concrete): Change type to
4082         std::unordered_map<sect_offset, std::vector<sect_offset>,
4083         gdb::hash_enum<sect_offset>>.
4084
4085 2019-06-19  Tom Tromey  <tromey@adacore.com>
4086
4087         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4088         EVAL_AVOID_SIDE_EFFECTS specially.
4089
4090 2019-06-19  Tom Tromey  <tromey@adacore.com>
4091
4092         * source-cache.c (highlighter): New global.
4093         (source_cache::get_source_lines): Create a highlighter on demand.
4094
4095 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * defs.h (deprecated_interactive_hook): Delete declaration.
4098         * interps.c (clear_interpreter_hooks): Remove use of
4099         deprecated_interactive_hook.
4100         * top.c (deprecated_interactive_hook): Delete definition.
4101         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4102
4103 2019-06-18  Tom de Vries  <tdevries@suse.de>
4104
4105         PR gdb/24515
4106         * dwarf2read.h (abstract_to_concrete): Change type from
4107         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4108         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4109         * dwarf2read.c (read_variable): Update.
4110         (dwarf2_fetch_die_loc_sect_off): Update.
4111
4112 2019-06-17  Tom de Vries  <tdevries@suse.de>
4113
4114         PR gdb/24617
4115         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4116         accessing parent[parent_len - 1].
4117
4118 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4119
4120         PR gdb/24364
4121         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4122         call dtrace_process_dof with NULL dof.
4123
4124 2019-06-16  Tom de Vries  <tdevries@suse.de>
4125
4126         PR gdb/24445
4127         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4128
4129 2019-06-16  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4132         (make_all_visible): Use address of member.
4133
4134 2019-06-16  Tom Tromey  <tom@tromey.com>
4135
4136         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4137         (tui_free_window, free_content, free_content_elements): Remove
4138         unnecessary cast.
4139         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4140         cast.
4141         * tui/tui-regs.c (tui_show_register_group)
4142         (tui_display_registers_from, tui_display_reg_element_at_line):
4143         Remove unnecessary cast.
4144
4145 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4146
4147         * linux-nat.c (normal_mask): Delete.
4148         (_initialize_linux_nat): Don't initialise normal_mask.
4149
4150 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4151
4152         PR gdb/24445
4153         * dwarf-index-write.h (write_psymtabs_to_index): Add
4154         dwz_basename parameter.
4155         * dwarf-index-write.c (write_gdbindex): Move file writing to
4156         write_gdbindex_1.  Change return type void.
4157         (assert_file_size): Move up, remove filename parameter.
4158         (write_gdbindex_1): New function.
4159         (write_debug_names): Change return type to void, call
4160         assert_file_size.
4161         (struct index_wip_file): New struct.
4162         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4163         file logic to index_wip_file.  Write index for dwz file if
4164         needed.
4165         (save_gdb_index_command): Pass basename of dwz file, if present.
4166         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4167         build-id of dwz file, if present.
4168         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4169         (dwarf2_get_dwz_file): Likewise.
4170         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4171         (dwarf2_get_dwz_file): Likewise.
4172
4173 2019-06-16  Tom Tromey  <tom@tromey.com>
4174
4175         * coffread.c (process_coff_symbol): Use xstrdup.
4176         * value.c (create_internalvar): Use xstrdup.
4177
4178 2019-06-16  Tom Tromey  <tom@tromey.com>
4179
4180         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4181         * breakpoint.c (stopin_command, stopat_command)
4182         (until_break_command, decode_location_default): Remove unnecessary
4183         cast.
4184         * utils.c (subset_compare): Remove unnecessary cast.
4185         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4186         cast.
4187         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4188         cast.
4189         * infcmd.c (path_command): Remove unnecessary cast.
4190         * coffread.c (decode_type): Remove unnecessary cast.
4191         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4192         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4193         * tui/tui-stack.c (tui_show_locator_content)
4194         (tui_show_frame_info): Remove unnecessary cast.
4195         * tui/tui-win.c (tui_scroll_forward_command)
4196         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4197         (parse_scrolling_args): Remove unnecessary cast.
4198         * tui/tui-data.c (init_win_info, tui_del_window)
4199         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4200         (free_content_elements): Remove unnecessary cast.
4201         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4202         unnecessary cast.
4203         * tui/tui-source.c (tui_set_source_content)
4204         (tui_vertical_source_scroll): Remove unnecessary cast.
4205         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4206         cast.
4207         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4208         * tui/tui-regs.c (tui_display_registers_from)
4209         (tui_display_register): Remove unnecessary cast.
4210         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4211         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4212         (make_visible): Remove unnecessary cast.
4213         * tui/tui-winsource.c (tui_erase_source_content)
4214         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4215         unnecessary cast.
4216         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4217         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4218         * stabsread.c (read_type, read_array_type, read_range_type):
4219         Remove unnecessary cast.
4220         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4221         (parse_symbol, parse_type, upgrade_type, parse_external)
4222         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4223         unnecessary cast.
4224         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4225
4226 2019-06-16  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-data.c (tui_alloc_generic_win_info)
4229         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4230         checks.
4231
4232 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4233             Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * f-typeprint.c (f_print_type): Don't return early for not
4236         associated or not allocated types.
4237         (f_type_print_varspec_suffix): Add print_rank parameter and print
4238         ranks of array types in case they dangling.
4239         (f_type_print_base): Add print_rank parameter.
4240
4241 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * NEWS: Mention new MI commands.
4244         * break-catch-throw.c (enum exception_event_kind): Move to
4245         breakpoint.h.
4246         (print_mention_exception_catchpoint): Output text as a single
4247         message.
4248         (catch_exception_command_1): Rename to...
4249         (catch_exception_event): ...this, make non-static, update header
4250         command, and change some parameter types.
4251         (catch_catch_command): Update for changes to
4252         catch_exception_command_1.
4253         (catch_throw_command): Likewise.
4254         (catch_rethrow_command): Likewise.
4255         * breakpoint.c (enum exception_event_kind): Delete.
4256         * breakpoint.h (enum exception_event_kind): Moved here from
4257         break-catch-throw.c.
4258         (catch_exception_event): Declare.
4259         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4260         (mi_cmd_catch_throw): New function.
4261         (mi_cmd_catch_rethrow): New function.
4262         (mi_cmd_catch_catch): New function.
4263         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4264         'catch-catch' entries.
4265         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4266         (mi_cmd_catch_rethrow): Declare.
4267         (mi_cmd_catch_catch): Declare.
4268
4269 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         * annotate.c (annotate_source_line): Change return type to void,
4272         update implementation to match.
4273         * annotate.h (annotate_source_line): Change return type to void,
4274         update header comment.
4275         * stack.c (print_frame_info): Don't change what frame information
4276         is printed based on whether annotations are on or not.
4277
4278 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4281         (annotate_source): Make static.
4282         (annotate_source_line): Moved from source.c and renamed from
4283         identify_source_line.  Update the return type.
4284         * annotate.h (annotate_source): Delete declaration.
4285         (annotate_source_line): Declaration moved from source.h, and
4286         renamed from identify_source_line.  Return type updated.
4287         * source.c (identify_source_line): Moved to annotate.c and renamed
4288         to annotate_source_line.
4289         (info_line_command): Remove check of annotation_level.
4290         * source.h (identify_source_line): Move declaration to annotate.h
4291         and rename to annotate_source_line.
4292         * stack.c: Add 'annotate.h' include.
4293         (print_frame_info): Remove check of annotation_level before
4294         calling annotate_source_line.
4295
4296 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4297
4298         * source-cache.c (source_cache::get_plain_source_lines): Use
4299         open_source_file_with_line_charpos instead of just
4300         open_source_file, remove call to find_source_lines.
4301         (source_cache::get_source_lines): Likewise.
4302         * source.c (find_source_lines): Make static.
4303         (get_filename_and_charpos): Renamed into...
4304         (open_source_file_with_line_charpos): ..this along with changes to
4305         return a scoped_fd, and some other minor clean ups.
4306         (identify_source_line): Use open_source_file_with_line_charpos.
4307         (search_command_helper): Use open_source_file_with_line_charpos
4308         instead of just open_source_file, remove call to
4309         find_source_lines.
4310         * source.h (open_source_file_with_line_charpos): Declare new
4311         function.
4312         (find_source_lines): Delete declaration.
4313
4314 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * source.c (get_filename_and_charpos): Remove fullname
4317         parameter.
4318         (identify_source_line): Update call to get_filename_and_charpos.
4319
4320 2019-06-14  Tom Tromey  <tromey@adacore.com>
4321
4322         PR gdb/24502:
4323         * ui-style.h (skip_ansi_escape): Update comment.
4324         * ui-file.h (class no_terminal_escape_file): New class.
4325         * ui-file.c (no_terminal_escape_file::write)
4326         (no_terminal_escape_file::puts): New methods.
4327         * cli/cli-logging.c (handle_redirections): Use
4328         no_terminal_escape_file.
4329
4330 2019-06-14  Tom Tromey  <tromey@adacore.com>
4331
4332         * NEWS: Move convenience variable news above Python news.
4333
4334 2019-06-14  Tom Tromey  <tom@tromey.com>
4335
4336         * gnulib: Move directory to top-level.
4337         * configure.ac: Don't configure gnulib.
4338         * configure: Rebuild.
4339         * common/common-defs.h: Use new path to gnulib.
4340         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4341         (GNULIB_H): Remove.
4342         (INCGNU): Look in new gnulib location.
4343         (HFILES_NO_SRCDIR): Remove gnulib files.
4344         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4345         (generated_files): Remove GNULIB_H.
4346         ($(LIBGNU), all-lib): Remove targets.
4347         (distclean): Don't mention GNULIB_BUILDDIR.
4348         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4349
4350 2019-06-14  Tom Tromey  <tromey@adacore.com>
4351
4352         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4353         Warn if symbol file does not provide any symbols.
4354
4355 2019-06-14  Tom Tromey  <tromey@adacore.com>
4356
4357         * source.c (find_and_open_source): Respect basenames_may_differ.
4358
4359 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * annotate.c (annotate_breakpoints_invalid): Make use of
4362         scoped_restore_terminal_state.
4363         (annotate_frames_invalid): Likewise.
4364
4365 2019-06-14  Tom Tromey  <tromey@adacore.com>
4366
4367         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4368         allow assignment to an internalvar.
4369
4370 2019-06-14  Tom Tromey  <tromey@adacore.com>
4371
4372         * ada-lex.l: Allow "_" in attribute names.
4373
4374 2019-06-14  Tom Tromey  <tromey@adacore.com>
4375
4376         PR gdb/24653:
4377         * regcache.c (registers_changed): Don't call alloca.
4378         * top.c (execute_command): Don't call alloca.
4379
4380 2019-06-13  Pedro Alves  <palves@redhat.com>
4381
4382         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4383         'expression'.  When parsing an expression, error out if there's
4384         junk after "unlimited".
4385         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4386         (do_set_command): Adjust calls to is_unlimited_literal.
4387
4388 2019-06-13  Pedro Alves  <palves@redhat.com>
4389
4390         * compile/compile.c (make_compile_options_def_group): Add braces
4391         around array_view initializer.
4392         * thread.c (make_thread_apply_all_options_def_group)
4393         (make_thread_apply_all_options_def_group): Likewise.
4394
4395 2019-06-13  Pedro Alves  <palves@redhat.com>
4396
4397         * NEWS (New commands): Mention "maint test-options
4398         require-delimiter", "maint test-options unknown-is-error", "maint
4399         test-options unknown-is-operand" and "maint show
4400         test-options-completion-result".
4401         (New command options, command completion): New section.
4402         (Completion improvements): New section.
4403         Mention that you can abbreviate "unlimited".
4404
4405 2019-06-13  Pedro Alves  <palves@redhat.com>
4406
4407         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4408         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4409         * unittests/cli-utils-selftests.c (test_parse_flags)
4410         (test_parse_flags_qcs): Delete.
4411         (test_cli_utils): Don't call deleted functions.
4412
4413 2019-06-13  Pedro Alves  <palves@redhat.com>
4414
4415         * thread.c: Include "cli/cli-option.h".
4416         (tp_array_compar_ascending): Global.
4417         (tp_array_compar): Delete function.
4418         (tp_array_compar_ascending, tp_array_compar_descending): New
4419         functions.
4420         (ascending_option_def, qcs_flag_option_def)
4421         (thr_qcs_flags_option_defs)
4422         (make_thread_apply_all_options_def_group)
4423         (make_thread_apply_options_def_group): New.
4424         (thread_apply_all_command): Use gdb::option::process_options.
4425         (thread_apply_command_completer)
4426         (thread_apply_all_command_completer): New.
4427         (thread_apply_command): Use gdb::option::process_options.
4428         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4429         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4430         to generate help text of "thread apply".  Adjust "taas"'s help.
4431         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4432         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4433
4434 2019-06-13  Pedro Alves  <palves@redhat.com>
4435
4436         * thread.c (thread_apply_command): Check for invalid TID with
4437         isdigit instead of !isalpha.
4438
4439 2019-06-13  Pedro Alves  <palves@redhat.com>
4440
4441         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4442         (validate_flags_qcs): New.
4443         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4444         (validate_flags_qcs): Declare.
4445         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4446         (make_frame_apply_options_def_group): New.
4447         (frame_apply_command_count): Process options with
4448         gdb::option::process_options.
4449         (frame_apply_completer): New.
4450         (frame_apply_level_completer, frame_apply_all_completer)
4451         (frame_apply_completer): New.
4452         (_initialize_stack): Update help of "frame apply", "frame apply
4453         level", "frame apply all" and "faas" to mention supported options
4454         and install command completers.
4455         * stack.h (frame_apply_all_completer): Declare.
4456         * thread.c: Include "stack.h".
4457         (tfaas_command): Add "--".
4458         (_initialize_thread): Update help "tfaas" to mention supported
4459         options and install command completer.
4460
4461 2019-06-13  Pedro Alves  <palves@redhat.com>
4462
4463         * completer.c (complete_nested_command_line): New.
4464         (gdb_completion_word_break_characters_throw): Add assertion.
4465         * completer.h (complete_nested_command_line): Declare.
4466
4467 2019-06-13  Pedro Alves  <palves@redhat.com>
4468
4469         * stack.c (parse_backtrace_qualifiers): New.
4470         (backtrace_command): Use it.
4471         (backtrace_command_completer): Complete on qualifiers.
4472
4473 2019-06-13  Pedro Alves  <palves@redhat.com>
4474
4475         * frame.c: Include "cli/cli-option.h.
4476         (user_set_backtrace_options): New.
4477         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4478         Delete.
4479         (get_prev_frame): Adjust.
4480         (boolean_option_def, uinteger_option_def)
4481         (set_backtrace_option_defs): New.
4482         (_initialize_frame): Adjust and use
4483         gdb::option::add_setshow_cmds_for_options to install "set
4484         backtrace past-main" and "set backtrace past-entry".
4485         * frame.h: Include "cli/cli-option.h".
4486         (struct frame_print_options): Forward declare.
4487         (print_frame_arguments_all, print_frame_arguments_scalars)
4488         (print_frame_arguments_none): Declare.
4489         (print_entry_values): Delete declaration.
4490         (struct frame_print_options, user_frame_print_options): New.
4491         (struct set_backtrace_options): New.
4492         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4493         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4494         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4495         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4496         (list_args_or_locals): Add frame_print_options parameter.
4497         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4498         * python/py-framefilter.c (enumerate_args): Pass down
4499         USER_FRAME_PRINT_OPTIONS.
4500         * stack.c: Include "cli/cli-option.h".
4501         (print_frame_arguments_all, print_frame_arguments_scalars)
4502         (print_frame_arguments_none): Declare.
4503         (print_raw_frame_arguments, print_entry_values): Delete.
4504         (user_frame_print_options): New.
4505         (boolean_option_def, enum_option_def, frame_print_option_defs):
4506         New.
4507         (struct backtrace_cmd_options): New.
4508         (bt_flag_option_def): New.
4509         (backtrace_command_option_defs): New.
4510         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4511         (print_frame_arg, read_frame_arg, print_frame_args)
4512         (print_frame_info, print_frame): Add frame_print_options parameter
4513         and use it.
4514         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4515         (backtrace_command_1): Add frame_print_options and
4516         backtrace_cmd_options parameters and use them.
4517         (make_backtrace_options_def_group): New.
4518         (backtrace_command): Process command options with
4519         gdb::option::process_options.
4520         (backtrace_command_completer): New.
4521         (_initialize_stack): Extend "backtrace"'s help to mention
4522         supported options.  Install completer for "backtrace".
4523         Install some settings commands with add_setshow_cmds_for_options.
4524
4525 2019-06-13  Pedro Alves  <palves@redhat.com>
4526
4527         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4528         and that "set/show print raw frame-arguments" are now deprecated.
4529
4530         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4531         command.
4532         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4533         * stack.c (_initialize_stack): Install "set/show print
4534         raw-frame-arguments", and deprecate "set/show print raw
4535         frame-arguments".
4536         * valprint.c (_initialize_valprint): Deprecate "set/show print
4537         raw".
4538
4539 2019-06-13  Pedro Alves  <palves@redhat.com>
4540
4541         * compile/compile.c (struct compile_options): New.
4542         (compile_flag_option_def, compile_command_option_defs)
4543         (make_compile_options_def_group): New.
4544         (compile_file_command): Handle options with
4545         gdb::option::process_options.
4546         (compile_file_command_completer): New function.
4547         (compile_code_command): Handle options with
4548         gdb::option::process_options.
4549         (compile_code_command_completer): New function.
4550         (_initialize_compiler): Install completers for "compile code" and
4551         "compile file".  Mention available options in "compile code" and
4552         "compile code"'s help.
4553         * completer.c (advance_to_completion_word): New, factored out from
4554         ...
4555         (advance_to_expression_complete_word_point): ... this.
4556         (advance_to_filename_complete_word_point): New.
4557         * completer.h (advance_to_filename_complete_word_point): New
4558         declaration.
4559
4560 2019-06-13  Pedro Alves  <palves@redhat.com>
4561
4562         * compile/compile.c: Include "cli/cli-option.h".
4563         (compile_print_value): Scope data pointer is now a
4564         value_print_options pointer; adjust.
4565         (compile_print_command): Process options.  Scope data pointer is
4566         now a value_print_options pointer; adjust.
4567         (_initialize_compile): Update "compile print"'s help to include
4568         supported options.  Install a completer for "compile print".
4569         * cp-valprint.c (show_vtblprint, show_objectprint)
4570         (show_static_field_print): Delete.
4571         (_initialize_cp_valprint): Don't install "set print
4572         static-members", "set print vtbl", "set print object" here.
4573         * printcmd.c: Include "cli/cli-option.h" and
4574         "common/gdb_optional.h".
4575         (print_command_parse_format): Rework to fill in a
4576         value_print_options instead of a format_data.
4577         (print_value): Change parameter type from format_data pointer to
4578         value_print_options reference.  Adjust.
4579         (print_command_1): Process options.  Adjust to pass down a
4580         value_print_options.
4581         (print_command_completer): New.
4582         (_initialize_printcmd): Install print_command_completer as
4583         handle_brkchars completer for the "print" command.  Update
4584         "print"'s help to include supported options.
4585         * valprint.c: Include "cli/cli-option.h".
4586         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4587         here from cp-valprint.c.
4588         (boolean_option_def, uinteger_option_def)
4589         (value_print_option_defs, make_value_print_options_def_group):
4590         New.  Use gdb::option::add_setshow_cmds_for_options to install
4591         "set print elements", "set print null-stop", "set print repeats",
4592         "set print pretty", "set print union", "set print array", "set
4593         print address", "set print symbol", "set print array-indexes".
4594         * valprint.h: Include <string> and "cli/cli-option.h".
4595         (make_value_print_options_def_group): Declare.
4596         (print_value): Change parameter type from format_data pointer to
4597         value_print_options reference.
4598         (print_command_completer): Declare.
4599
4600 2019-06-13  Pedro Alves  <palves@redhat.com>
4601
4602         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4603         (COMMON_SFILES): Add maint-test-settings.c.
4604         * cli/cli-decode.c (boolean_enums): New global, factored out from
4605         ...
4606         (add_setshow_boolean_cmd): ... here.
4607         * cli/cli-decode.h (boolean_enums): Declare.
4608         * cli/cli-option.c: New file.
4609         * cli/cli-option.h: New file.
4610         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4611         factored out from ...
4612         (parse_cli_boolean_value(const char *)): ... this.
4613         (is_unlimited_literal): Change parameter type to pointer to
4614         pointer.  Adjust and advance ARG pointer.
4615         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4616         (parse_cli_var_enum): New, factored out from ...
4617         (do_set_command): ... this.  Adjust.
4618         * cli/cli-setshow.h (parse_cli_boolean_value)
4619         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4620         (parse_cli_var_enum): Declare.
4621         * cli/cli-utils.c: Include "cli/cli-option.h".
4622         (get_ulongest): New.
4623         * cli/cli-utils.h (get_ulongest): Declare.
4624         (check_for_argument): New overloads.
4625         * maint-test-options.c: New file.
4626
4627 2019-06-13  Pedro Alves  <palves@redhat.com>
4628
4629         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4630         parse a range if "-" is at the end of the string.
4631
4632 2019-06-13  Pedro Alves  <palves@redhat.com>
4633
4634         * cli/cli-setshow.c (parse_auto_binary_operation)
4635         (parse_cli_boolean_value): Don't allow "o".
4636
4637 2019-06-13  Pedro Alves  <palves@redhat.com>
4638
4639         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4640         * NEWS: Mention maint test-settings KIND.
4641         * maint-test-settings.c: New file.
4642
4643 2019-06-13  Pedro Alves  <palves@redhat.com>
4644
4645         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4646         completer.
4647         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4648         "set" completers.
4649
4650 2019-06-13  Pedro Alves  <palves@redhat.com>
4651
4652         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4653         after item.
4654
4655 2019-06-13  Pedro Alves  <palves@redhat.com>
4656
4657         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4658
4659 2019-06-13  Pedro Alves <palves@redhat.com>
4660
4661         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4662         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4663         call.
4664         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4665         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4666         calls.
4667         (check_for_argument): Skip spaces after argument.
4668
4669 2019-06-13  Pedro Alves  <palves@redhat.com>
4670
4671         * thread.c (thread_apply_command): Adjust TID parsing.
4672         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4673         detected before end of string.
4674         (tid_is_in_list): Error out if LIST is invalid.
4675
4676 2019-06-13  Pedro Alves  <palves@redhat.com>
4677
4678         * completer.c (complete_line_internal_1): Rewind completion word
4679         point.
4680         (completion_tracker::advance_custom_word_point_by): Change
4681         parameter type to int.
4682         * completer.h (completion_tracker::advance_custom_word_point_by):
4683         Likewise.
4684
4685 2019-06-13  Pedro Alves  <palves@redhat.com>
4686
4687         * completer.c (advance_to_completion_word): Handle delimiters.
4688
4689 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4690
4691         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4692
4693 2019-06-11  Tom Tromey  <tom@tromey.com>
4694
4695         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4696         (xmalloc_failed): Move to alloc.c.
4697         * alloc.c: New file.
4698         * Makefile.in (COMMON_SFILES): Add alloc.c.
4699
4700 2019-06-11  Tom Tromey  <tom@tromey.com>
4701
4702         * nat/linux-waitpid.c: Don't include server.h.
4703         (linux_debug): Remove.
4704         (my_waitpid): Update.
4705
4706 2019-06-11  Tom Tromey  <tromey@adacore.com>
4707
4708         * infcall.c (_initialize_infcall): Remove trailing newline from
4709         help.
4710         * user-regs.c (_initialize_user_regs): Remove trailing newline
4711         from help.
4712         * typeprint.c (_initialize_typeprint): Remove trailing newline
4713         from help.
4714         * reverse.c (_initialize_reverse): Remove trailing newlines from
4715         help.
4716         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4717         from help.
4718         * language.c (add_set_language_command): Remove trailing newline
4719         from help.
4720         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4721         help.
4722         * disasm.c (_initialize_disasm): Remove trailing newline from
4723         help.
4724         * top.c (init_main): Remove trailing newline from help.
4725         * interps.c (_initialize_interpreter): Remove trailing newline
4726         from help.
4727         * btrace.c (_initialize_btrace): Remove trailing newlines from
4728         help.
4729         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4730         from help.
4731         * python/python.c (_initialize_python): Remove trailing newline
4732         from help.
4733         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4734         help.
4735         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4736         from help.  Reformat some text.
4737         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4738         from help.
4739         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4740         newline from help.
4741
4742 2019-06-11  Tom Tromey  <tromey@adacore.com>
4743
4744         * darwin-nat.c (darwin_decode_exception_message)
4745         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4746
4747 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * valops.c (value_slice): Check for not allocated or not
4750         associated values.
4751
4752 2019-06-10  Tom de Vries  <tdevries@suse.de>
4753
4754         PR gdb/24618
4755         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4756         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4757         invalid.
4758
4759 2019-06-10  Tom de Vries  <tdevries@suse.de>
4760
4761         PR gdb/24611
4762         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4763         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4764
4765 2019-06-10  Tom de Vries  <tdevries@suse.de>
4766
4767         PR symtab/24545
4768         * symtab.c (struct demangled_name_entry): Add language field.
4769         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4770         static minimal symbol".  Set and use language field.
4771
4772 2019-06-10  Tom Tromey  <tromey@adacore.com>
4773
4774         * ada-lang.c (_initialize_ada_language): Update help text.
4775
4776 2019-06-10  Tom Tromey  <tromey@adacore.com>
4777
4778         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4779         with a newline.
4780         * guile/guile.c (handle_boot_error): Don't end warning with a
4781         newline.
4782         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4783         warning with a newline.
4784         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4785         newline.
4786         (s12z_frame_cache): Likewise.
4787         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4788         a newline.
4789         * solib-svr4.c (disable_probes_interface): Don't end warning with
4790         a newline.
4791         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4792         newline.
4793         * python/python.c (do_finish_initialization): Don't end warning
4794         with a newline.
4795
4796 2019-06-10  Tom Tromey  <tom@tromey.com>
4797
4798         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4799         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4800         gdbpy_enter.
4801
4802 2019-06-10  Tom Tromey  <tromey@adacore.com>
4803
4804         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4805         data.
4806         (elf_new_init): Don't call stabsread_new_init.
4807         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4808         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4809         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4810
4811 2019-06-10  Tom de Vries  <tdevries@suse.de>
4812
4813         PR symtab/16264
4814         PR symtab/24517
4815         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4816
4817 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4818
4819         * source.c (find_and_open_source): Also rewrite relative file
4820         names.
4821
4822 2019-04-26  Amos Bird  <amosbird@gmail.com>
4823
4824         * annotate.c (annotate_thread_exited): Add "thread-exited"
4825         annotation.
4826
4827 2019-06-06  Tom Tromey  <tromey@adacore.com>
4828
4829         * maint.h (class scoped_command_stats): Use
4830         DISABLE_COPY_AND_ASSIGN.
4831         <print_time>: New method.
4832         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4833         print_time.
4834         (scoped_command_stats::print_time): New method.
4835
4836 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4839         instructions of lengths 6 or 8 bytes.
4840
4841 2019-06-04  Pedro Alves  <palves@redhat.com>
4842
4843         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4844
4845         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4846         * breakpoint.c (condition_completer): Likewise.
4847         * cli/cli-dump.c (scan_expression): Likewise.
4848         * common/filestuff.c (mkdir_recursive): Likewise.
4849         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4850         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4851         (gdb_abspath): Likewise.
4852         * compile/compile-cplus-types.c
4853         (compile_cplus_instance::decl_name): Likewise.
4854         * completer.c (complete_explicit_location):
4855         (signal_completer, reg_or_group_completer_1): Likewise.
4856         * cp-support.c (cp_remove_params_if_any): Likewise.
4857         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4858         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4859         * infcmd.c (strip_bg_char): Likewise.
4860         * linespec.c (copy_token_string): Likewise.
4861         * mi/mi-main.c (output_cores): Likewise.
4862         * psymtab.c (psymtab_search_name):
4863         * symfile.c (test_set_ext_lang_command): Likewise.
4864         * target.c (target_fileio_read_stralloc): Likewise.
4865         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4866         * value.c (complete_internalvar): Likewise.
4867
4868 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4869
4870         Add objfile property to gdb.Type.
4871         * NEWS: Mention Python API addition.
4872         * python/py-type.c (typy_get_objfile): New method.
4873
4874 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4875
4876         * NEWS: Mention the new set|show style [title|highlight].
4877         Mention changes to "show style", "help" and "apropos".
4878
4879 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4880
4881         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4882         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4883         instead of print_help_for_command.
4884         (print_doc_of_command): New function.
4885         (help_list): Add 'apropos -v word' suggestion.
4886         (print_help_for_command): Style the command name using title style.
4887         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4888         (_initialize_cli_cmds): Describe -v in apropos_command help.
4889
4890 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4891
4892         * cli/cli-style.h (cli_style_option): Add name in constructor,
4893         add m_name class member, add constructor with intensity,
4894         add name class function.
4895         (cli_style_option::add_setshow_commands): Remove name argument.
4896         (highlight_style, title_style): New styles.
4897         * cli/cli-style.c (do_show): New function that shows a style
4898         characteristic styling the style name with itself.
4899         (set_style_name): New function.
4900         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4901         Update all callers according to the changes in cli/cli-style.h.
4902         * utils.h (fputs_highlighted): New function.
4903         * utils.c (fputs_highlighted): Likewise.
4904
4905 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4906
4907         * NEWS: Mention new pipe command and new convenience variables.
4908
4909 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4910
4911         * cli/cli-cmds.c (pipe_command): New function.
4912         (_initialize_cli_cmds): Call add_com for pipe_command.
4913         Define | as an alias for pipe.
4914         (exit_status_set_internal_vars): New function.
4915         (shell_escape): Call exit_status_set_internal_vars.
4916         cli/cli-decode.c (find_command_name_length): Recognize | as
4917         a single character command.
4918
4919 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4920
4921         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4922         top.c (execute_command_to_ui_file): New function, mostly a copy
4923         of execute_command_to_string.
4924         (execute_command_to_string): Implement by calling
4925         execute_command_to_ui_file.
4926
4927 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4928
4929         * top.h (saved_command_line): Remove declaration.
4930         * top.c (previous_saved_command_line, previous_repeat_arguments):
4931         New variables.
4932         (saved_command_line): Make static, define together with other
4933         'repeat variables'.
4934         (dont_repeat): Clear repeat_arguments.
4935         (repeat_previous, get_saved_command_line, save_command_line):
4936         New functions.
4937         (gdb_init): Initialize saved_command_line
4938         and previous_saved_command_line.
4939         * main.c (captured_main_1): Remove saved_command_line initialization.
4940         * event-top.c (handle_line_of_input): Update to use
4941         the new 'repeat' related functions instead of direct access to
4942         saved_command_line.
4943         * command.h (repeat_previous, get_saved_command_line,
4944         save_command_line): New declarations.
4945         (dont_repeat): Add comment.
4946
4947 2019-05-30  Tom Tromey  <tromey@adacore.com>
4948
4949         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4950         Fix comment.
4951         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4952
4953 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4954
4955         PR cli/24587
4956         * completer.c (complete): Initialize variable word.
4957
4958 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4959
4960         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4961         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4962         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4963         'body' is NULL to the outter 'if', protecting the '!is_define'
4964         situation as well.
4965
4966 2019-05-29  Tom Tromey  <tromey@adacore.com>
4967
4968         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4969         (dwarf_unknown): New function.
4970         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4971         (dwarf_type_encoding_name): Use dwarf_unknown.
4972
4973 2019-05-29  Tom Tromey  <tromey@adacore.com>
4974
4975         PR c++/20020:
4976         * cp-valprint.c (cp_print_value_fields): Call
4977         cp_print_static_field inside "try".
4978
4979 2019-05-29  Tom Tromey  <tromey@adacore.com>
4980
4981         * inflow.c (struct terminal_info): Add default operator=.
4982         * configure: Rebuild.
4983         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4984         -Wdeprecated-copy-dtor, -Wredundant-move.
4985
4986 2019-05-29  Tom Tromey  <tromey@adacore.com>
4987
4988         * NEWS: Add entry.
4989         * infcmd.c (print_return_value_1): Handle finish_print
4990         option.
4991         (show_print_finish): New function.
4992         (_initialize_infcmd): Add "set/show print finish" commands.
4993         * valprint.c (user_print_options): Initialize new member.
4994         * valprint.h (struct value_print_options) <finish_print>: New
4995         member.
4996
4997 2019-05-28  Tom Tromey  <tromey@adacore.com>
4998
4999         * ada-lang.c (ada_remove_Xbn_suffix)
5000         (find_old_style_renaming_symbol)
5001         (parse_old_style_renaming): Remove.
5002         (ada_find_renaming_symbol): Don't call
5003         find_old_style_renaming_symbol.
5004         (ada_is_renaming_symbol): Rename from
5005         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5006         bool.  Now static.
5007         (ada_read_var_value): Update and simplify.
5008         * ada-exp.y (write_var_or_type): Remove old code.
5009
5010 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5011
5012         * event-top.c: Remove include comment.
5013         * inflow.c (class scoped_ignore_sigttou): Move from here...
5014         * inflow.h (class scoped_ignore_sigttou): ...to here.
5015         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5016         * top.c:  Remove include comment.
5017
5018 2019-05-27  Tom Tromey  <tom@tromey.com>
5019
5020         * NEWS: Fix typo.
5021
5022 2019-05-22  Tom Tromey  <tromey@adacore.com>
5023
5024         * target.c (target_follow_exec): Constify parameter.
5025         * target-delegates.c: Rebuild.
5026         * remote.c (remote_target::follow_exec): Constify parameter.
5027         * infrun.c (follow_exec): Constify parameter.
5028         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5029         (target_follow_exec): Likewise.
5030
5031 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5032
5033         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5034         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5035
5036 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5037
5038         * NEWS: Add debugredirect and testsuite sections.
5039
5040 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5041
5042         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5043         target descriptions using exclusively floating point register name
5044         aliases.
5045
5046 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5047
5048         PR gdb/18644:
5049         * f-lang.c (build_fortran_types): Handle the case where
5050         gdbarch_floatformat_for_type returns a nullptr.
5051
5052 2019-05-21  Tom de Vries  <tdevries@suse.de>
5053
5054         PR cli/24587
5055         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5056
5057 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         PR gdb/18644:
5060         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5061         16-byte floats.
5062         * i386-tdep.c (i386_floatformat_for_type): Use
5063         floatformats_ia64_quad for the 16-byte floating point component
5064         within a fortran 32-byte complex number.
5065
5066 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5067
5068         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5069         delete default constructor.
5070         (find_partial_die): Update to return const struct.
5071         (partial_die_parent_scope): Move variable declaration into scope
5072         of its use and change its type to auto.
5073         (guess_partial_die_structure_name): Likewise.
5074         (partial_die_info::fixup): Likewise.
5075
5076 2019-05-17  Tom Tromey  <tromey@adacore.com>
5077
5078         * source.c (find_and_open_source): Remove cast.
5079
5080 2019-05-17  Tom Tromey  <tromey@adacore.com>
5081
5082         * annotate.c (annotate_source): Make "filename" const.
5083         * annotate.h (annotate_source): Use const.
5084
5085 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5086
5087         * disasm.c (set_disassembler_options): Send errors to stderr.
5088
5089 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5090
5091         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5092         (cli_interp_base::set_logging): Check debug_redirect.
5093         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5094         * cli/cli-logging.c (debug_redirect): Add static variable.
5095         (pop_output_files): Add default param.
5096         (handle_redirections): Print debug setting.
5097         (show_logging_command): Likewise.
5098         (_initialize_cli_logging): Add debugredirect command.
5099         * interps.c (current_interp_set_logging): Add debug_redirect
5100         parameter.
5101         * interps.h (set_logging): Add debug_redirect parameter.
5102         (current_interp_set_logging): Likewise.
5103         * mi/mi-common.h: Likewise.
5104         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5105
5106 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5107             Tom Tromey  <tromey@adacore.com>
5108
5109         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5110         directly.
5111         * cli/cli-interp.h (make_logging_output): Remove declaration.
5112         * cli/cli-logging.c (make_logging_output): Remove function.
5113         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5114         directly.
5115         * ui-file.c (tee_file::tee_file): Remove bools.
5116         (tee_file::~tee_file): Remove deletes.
5117         * ui-file.h (tee_file): Remove bools.
5118
5119 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5120
5121         * mi/mi-cmds.h (mi_cmd_complete): New function.
5122         * mi/mi-main.c (mi_cmd_complete): Likewise.
5123         * mi/mi-cmds.c: Define new MI command -complete.
5124         * NEWS: Mention new -complete command.
5125
5126 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5127
5128         * completer.h (complete): New function.
5129         * completer.c (complete): Likewise.
5130         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5131         function defined in completer.h.
5132
5133 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5134
5135         * MAINTAINERS (Write After Approval): Add myself.
5136
5137 2019-05-17  Tom de Vries  <tdevries@suse.de>
5138
5139         PR gdb/24094
5140         * dwarf2read.c (struct cu_partial_die_info): New struct.
5141         (find_partial_die): Return cu_partial_die_info.
5142         (partial_die_parent_scope, guess_partial_die_structure_name)
5143         (partial_die_info::fixup): Handle new return type of find_partial_die.
5144
5145 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5146
5147         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5148         "std::string", simplifying the algorithm.
5149
5150 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5151
5152         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5153         (stap_static_probe_ops::get_probes): Likewise.
5154
5155 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5156
5157         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5158         '-')" and "else if".
5159         (stap_parse_single_operand): Join checks for
5160         "gdbarch_stap_parse_special_token_p" and
5161         "gdbarch_stap_parse_special_token" in the same "if" statement.
5162         Invert check when verifying for operation on register
5163         displacement.
5164
5165 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5166
5167         * stap-probe.c (stap_get_opcode): Update comment.
5168         (stap_get_expected_argument_type): Likewise.
5169         (handle_stap_probe): Likewise.
5170
5171 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5172
5173         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5174         return type to 'bool'.  Adjust comment.  Use 'bool' when
5175         appropriate.
5176         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5177         * stap-probe.c (stap_parse_argument_1): Likewise.
5178         (stap_is_operator): Likewise.
5179         (stap_is_generic_prefix): Likewise.
5180         (stap_is_register_prefix): Likewise.
5181         (stap_is_register_indirection_prefix): Likewise.
5182         (stap_is_integer_prefix): Likewise.
5183         (stap_generic_check_suffix): Likewise.
5184         (stap_check_integer_suffix): Likewise.
5185         (stap_check_register_suffix): Likewise.
5186         (stap_check_register_indirection_suffix): Likewise.
5187         (stap_parse_register_operand): Likewise.
5188         (stap_parse_single_operand): Likewise.
5189         (stap_parse_argument_1): Likewise.
5190         (stap_probe::get_argument_count): Likewise.
5191         (stap_is_operator): Likewise.
5192
5193 2019-05-16  Tom Tromey  <tromey@adacore.com>
5194
5195         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5196         keyword to foreach.
5197
5198 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5199
5200         * linux-thread-db.c (try_thread_db_load_1): Change return type
5201         to bool.
5202         (try_thread_db_load): Likewise.
5203         (try_thread_db_load_from_pdir_1): Likewise.
5204         (try_thread_db_load_from_pdir): Likewise.
5205         (try_thread_db_load_from_sdir): Likewise.
5206         (try_thread_db_load_from_dir): Likewise.
5207         (thread_db_load_search): Likewise.
5208         (has_libpthread): Likewise.
5209         (thread_db_load): Likewise.
5210
5211 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5212
5213         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5214         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5215         NULL, and complain/return if that's the case.
5216
5217 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5218
5219         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5220         (advance, posn, abstract_read_memory): New functions.
5221         [struct mem_read_abstraction]: New struct.
5222         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5223
5224 2019-05-14  Tom Tromey  <tromey@adacore.com>
5225
5226         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5227         value is not lval_memory.
5228
5229 2019-05-14  Tom Tromey  <tromey@adacore.com>
5230
5231         * solib.c (info_sharedlibrary_command): Style the file name.
5232
5233 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5234
5235         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5236         (aarch64_vnv_type): Likewise.
5237         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5238         * common/tdesc.c: Likewise.
5239         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5240         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5241         * features/aarch64-fpu.xml: Add ieee half view.
5242         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5243         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5244         * gdbtypes.h (struct builtin_type): Likewise.
5245         (struct objfile_type): Likewise.
5246
5247 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5248
5249         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5250         typo.
5251         * location.h (string_to_event_location): Likewise.
5252
5253 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5254
5255         GDB 8.3 released.
5256
5257 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5258
5259         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5260         New variable declaration.
5261         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5262         New variable.
5263         (print_one_breakpoint): Use ui_out::test_flags and new global
5264         variable to compute use_fixed_output.
5265         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5266         Remove.
5267         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5268         (mi_multi_location_breakpoint_output_fixed): Remove.
5269         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5270         new variable.
5271         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5272         fix_multi_location_breakpoint_output flag if version >= 3.
5273         * ui-out.h (enum ui_out_flag)
5274         <fix_multi_location_breakpoint_output>: New enumerator.
5275
5276 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5277
5278         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5279
5280 2019-05-10  Tom Tromey  <tromey@adacore.com>
5281
5282         * ada-lang.c (catch_ada_completer): New function.
5283         (_initialize_ada_language): Use it.
5284
5285 2019-05-10  Tom Tromey  <tromey@adacore.com>
5286
5287         * thread.c (print_thread_info): Make "requested_threads" const.
5288         * gdbthread.h (print_thread_info): Make "requested_threads"
5289         const.
5290         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5291         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5292
5293 2019-05-08  Tom Tromey  <tom@tromey.com>
5294
5295         * gdbtypes.c (objfile_type_data): Change type.
5296         (objfile_type, _initialize_gdbtypes): Update.
5297
5298 2019-05-08  Tom Tromey  <tom@tromey.com>
5299
5300         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5301         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5302         (_initialize_dwarf2_frame): Update.
5303
5304 2019-05-08  Tom Tromey  <tom@tromey.com>
5305
5306         * objc-lang.c (objc_objfile_data): Change type.
5307         (find_methods): Update.
5308         (_initialize_objc_lang): Remove.
5309
5310 2019-05-08  Tom Tromey  <tom@tromey.com>
5311
5312         * stabsread.c (rs6000_builtin_type_data): Change type.
5313         (rs6000_builtin_type, _initialize_stabsread): Update.
5314
5315 2019-05-08  Tom Tromey  <tom@tromey.com>
5316
5317         * mips-tdep.c (mips_pdr_data): Remove.
5318         (_initialize_mips_tdep): Update.
5319
5320 2019-05-08  Tom Tromey  <tom@tromey.com>
5321
5322         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5323         (hppa_init_objfile_priv_data, read_unwind_info)
5324         (find_unwind_entry, _initialize_hppa_tdep): Update.
5325
5326 2019-05-08  Tom Tromey  <tom@tromey.com>
5327
5328         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5329         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5330         on obstack.
5331         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5332
5333 2019-05-08  Tom Tromey  <tom@tromey.com>
5334
5335         * mdebugread.c (basic_type_data): Change type.
5336         (basic_type, _initialize_mdebugread): Update.
5337
5338 2019-05-08  Tom Tromey  <tom@tromey.com>
5339
5340         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5341
5342 2019-05-08  Tom Tromey  <tom@tromey.com>
5343
5344         * nto-tdep.c (nto_inferior_data_reg): Change type.
5345         (nto_inferior_data): Update.
5346         (nto_inferior_data_cleanup, nto_new_inferior_data)
5347         (_initialize_nto_tdep): Remove.
5348         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5349
5350 2019-05-08  Tom Tromey  <tom@tromey.com>
5351
5352         * ada-lang.c (struct ada_inferior_data): Add initializers.
5353         (ada_inferior_data): Change type.
5354         (ada_inferior_data_cleanup): Remove.
5355         (get_ada_inferior_data, ada_inferior_exit)
5356         (struct ada_pspace_data): Add initializers, destructor.
5357         (ada_pspace_data_handle): Change type.
5358         (get_ada_pspace_data): Update.
5359         (ada_pspace_data_cleanup): Remove.
5360
5361 2019-05-08  Tom Tromey  <tom@tromey.com>
5362
5363         * coffread.c (struct coff_symfile_info): Add initializers.
5364         (coff_objfile_data_key): Move lower.  Change type.
5365         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5366         Update.
5367         (coff_free_info): Remove.
5368
5369 2019-05-08  Tom Tromey  <tom@tromey.com>
5370
5371         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5372         (fbsd_pspace_data_handle): Move lower.  Change type.
5373         (get_fbsd_pspace_data): Update.
5374         (fbsd_pspace_data_cleanup): Remove.
5375         (_initialize_fbsd_tdep): Update.
5376
5377 2019-05-08  Tom Tromey  <tom@tromey.com>
5378
5379         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5380         (get_ada_tasks_pspace_data): Update.
5381         (ada_tasks_pspace_data_cleanup): Remove.
5382         (_initialize_tasks): Update.
5383         (ada_tasks_inferior_data_handle): Change type.
5384         (get_ada_tasks_inferior_data): Update.
5385         (ada_tasks_inferior_data_cleanup): Remove.
5386         (struct ada_tasks_pspace_data): Add initializers.
5387
5388 2019-05-08  Tom Tromey  <tom@tromey.com>
5389
5390         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5391         * symfile-debug.c (debug_sym_get_probes): Change type.
5392         * stap-probe.c (handle_stap_probe):
5393         (stap_static_probe_ops::get_probes): Change type.
5394         * probe.h (class static_probe_ops) <get_probes>: Change type.
5395         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5396         (parse_probes_in_pspace): Update.
5397         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5398         Update.
5399         (any_static_probe_ops::get_probes): Change type.
5400         * elfread.c (elfread_data): New typedef.
5401         (probe_key): Change type.
5402         (elf_get_probes): Likewise.  Update.
5403         (probe_key_free): Remove.
5404         (_initialize_elfread): Update.
5405         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5406         Change type.
5407         (dtrace_process_dof_probe, dtrace_process_dof)
5408         (dtrace_static_probe_ops::get_probe): Change type.
5409
5410 2019-05-08  Tom Tromey  <tom@tromey.com>
5411
5412         * xcoffread.c (struct xcoff_symfile_info): Rename from
5413         coff_symfile_info.  Add initializers.
5414         (xcoff_objfile_data_key): Move lower.  Change type.
5415         (XCOFF_DATA): Rewrite.
5416         (xcoff_free_info): Remove.
5417         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5418         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5419         (xcoff_initial_scan): Update.
5420
5421 2019-05-08  Tom Tromey  <tom@tromey.com>
5422
5423         * solib-svr4.c (struct svr4_info): Add initializers and
5424         destructor.
5425         <probes_table>: Now an htab_up.
5426         (solib_svr4_pspace_data): Change type.
5427         (free_probes_table): Simplify.
5428         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5429         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5430         (probes_table_remove_objfile_probes, register_solib_event_probe)
5431         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5432         (_initialize_svr4_solib): Update.
5433
5434 2019-05-08  Tom Tromey  <tom@tromey.com>
5435
5436         * remote.c (remote_pspace_data): Change type.
5437         (remote_pspace_data_cleanup): Remove.
5438         (get_remote_exec_file, set_pspace_remote_exec_file)
5439         (_initialize_remote): Update.
5440
5441 2019-05-08  Tom Tromey  <tom@tromey.com>
5442
5443         * breakpoint.c (breakpoint_objfile_key): Change type.
5444         (get_breakpoint_objfile_data): Update.
5445         (free_breakpoint_objfile_data): Remove.
5446         (_initialize_breakpoint): Update.
5447
5448 2019-05-08  Tom Tromey  <tom@tromey.com>
5449
5450         * linux-tdep.c (struct linux_info): Add initializers.
5451         (linux_inferior_data): Move.  Change type.
5452         (invalidate_linux_cache_inf): Update.
5453         (linux_inferior_data_cleanup): Remove.
5454         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5455
5456 2019-05-08  Tom Tromey  <tom@tromey.com>
5457
5458         * auxv.c (auxv_inferior_data): Move.  Change type.
5459         (auxv_inferior_data_cleanup): Remove.
5460         (invalidate_auxv_cache_inf): Rewrite.
5461         (get_auxv_inferior_data, _initialize_auxv): Update.
5462
5463 2019-05-08  Tom Tromey  <tom@tromey.com>
5464
5465         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5466         (symfile_debug_objfile_data_key): Change type.
5467         (symfile_debug_installed, debug_qf_has_symbols)
5468         (debug_qf_find_last_source_symtab)
5469         (debug_qf_forget_cached_source_info)
5470         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5471         (debug_qf_print_stats, debug_qf_dump)
5472         (debug_qf_expand_symtabs_for_function)
5473         (debug_qf_expand_all_symtabs)
5474         (debug_qf_expand_symtabs_with_fullname)
5475         (debug_qf_map_matching_symbols)
5476         (debug_qf_expand_symtabs_matching)
5477         (debug_qf_find_pc_sect_compunit_symtab)
5478         (debug_qf_map_symbol_filenames)
5479         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5480         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5481         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5482         (debug_sym_read_linetable, debug_sym_relocate): Update.
5483         (symfile_debug_free_objfile): Remove.
5484         (install_symfile_debug_logging, _initialize_symfile_debug):
5485         Update.
5486
5487 2019-05-08  Tom Tromey  <tom@tromey.com>
5488
5489         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5490         allocate_on_obstack.
5491         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5492         (get_dwarf2_per_objfile): Update.
5493         (set_dwarf2_per_objfile): Remove.
5494         (dwarf2_has_info, dwarf2_get_section_info): Update.
5495         (dwarf2_free_objfile): Remove.
5496         (_initialize_dwarf2_read): Update.
5497
5498 2019-05-08  Tom Tromey  <tom@tromey.com>
5499
5500         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5501         initializers.
5502         <unsupported_script_warning_printed,
5503         script_not_found_warning_printed>: Now bool.
5504         (auto_load_pspace_data): Change type.
5505         (~auto_load_pspace_info): Rename from
5506         auto_load_pspace_data_cleanup.
5507         (get_auto_load_pspace_data, init_loaded_scripts_info)
5508         (clear_section_scripts, maybe_print_unsupported_script_warning)
5509         (maybe_print_script_not_found_warning, _initialize_auto_load):
5510         Update.
5511
5512 2019-05-08  Tom Tromey  <tom@tromey.com>
5513
5514         * objfiles.c (objfile_pspace_info): Add destructor and
5515         initializers.
5516         (objfiles_pspace_data): Change type.
5517         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5518         (get_objfile_pspace_data): Update.
5519         (objfiles_bfd_data): Change type.
5520         (get_objfile_bfd_data): Update.
5521         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5522
5523 2019-05-08  Tom Tromey  <tom@tromey.com>
5524
5525         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5526         Change type.
5527         (get_catch_syscall_inferior_data): Update.
5528         (catch_syscall_inferior_data_cleanup): Remove.
5529         (_initialize_break_catch_syscall): Update.
5530
5531 2019-05-08  Tom Tromey  <tom@tromey.com>
5532
5533         * inflow.c (struct terminal_info): Add destructor and
5534         initializers.
5535         (inflow_inferior_data): Change type.
5536         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5537         (get_inflow_inferior_data, inflow_inferior_exit)
5538         (swap_terminal_info, _initialize_inflow): Update.
5539
5540 2019-05-08  Tom Tromey  <tom@tromey.com>
5541
5542         * target-dcache.c (target_dcache_cleanup): Remove.
5543         (target_dcache_aspace_key): Change type.
5544         (target_dcache_init_p, target_dcache_invalidate)
5545         (target_dcache_get, target_dcache_get_or_init)
5546         (_initialize_target_dcache): Update.
5547         * dcache.h (struct dcache_deleter): New.
5548
5549 2019-05-08  Tom Tromey  <tom@tromey.com>
5550
5551         * symtab.c (struct symbol_cache): Add destructor and
5552         initializers.
5553         (symbol_cache_key): Move.  Change type.
5554         (make_symbol_cache, free_symbol_cache): Remove.
5555         (get_symbol_cache): Update.
5556         (symbol_cache_cleanup): Remove.
5557         (ALL_PSPACES, symbol_cache_flush)
5558         (maintenance_print_symbol_cache)
5559         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5560         Update.
5561
5562 2019-05-08  Tom Tromey  <tom@tromey.com>
5563
5564         * symtab.c (struct main_info): Add destructor and initializers.
5565         (main_progspace_key): Move.  Change type.
5566         (get_main_info): Update.
5567         (main_info_cleanup): Remove.
5568         (_initialize_symtab): Update.
5569
5570 2019-05-08  Tom Tromey  <tom@tromey.com>
5571
5572         * registry.h (DECLARE_REGISTRY): Define the _key class.
5573
5574 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5575
5576         * NEWS: Merge two 'New commands' sections.
5577
5578 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5579
5580         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5581         parameter and use Ada language definition instead.
5582         (ada_val_print_ptr): Remove unused language parameter.
5583         (ada_val_print_num): Remove language parameter and use Ada language
5584         definition instead.
5585         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5586         parameter.
5587         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5588         parameter and use Ada language definition instead.
5589         (ada_val_print_1): Update all ada_val_print_xxx calls.
5590         Remove language parameter.
5591         (ada_val_print): Update ada_val_print_1 call.
5592
5593 2019-05-08  Tom Tromey  <tromey@adacore.com>
5594
5595         * remote.c (remote_hw_watchpoint_limit)
5596         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5597         Now static.
5598
5599 2019-05-08  Tom Tromey  <tromey@adacore.com>
5600
5601         * maint.c (_initialize_maint_cmds): Move initialization code to
5602         remote.c.
5603         (watchdog, show_watchdog): Move to remote.c.
5604         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5605         "watchdog" static.
5606         (_initialize_remote): Move initialization code from maint.c.
5607         * defs.h (watchdog): Don't declare.
5608
5609 2019-05-08  Tom Tromey  <tromey@adacore.com>
5610
5611         * tui/tui-interp.c: Include main.h.
5612         * interps.c: Include main.h.
5613         * main.h (interpreter_p): Declare.
5614         * defs.h (interpreter_p): Don't declare.
5615
5616 2019-05-08  Tom Tromey  <tromey@adacore.com>
5617
5618         * dwarf2loc.c: Include dwarf2read.h.
5619         * defs.h (read_unsigned_leb128): Don't declare.
5620         * dwarf2read.h (read_unsigned_leb128): Declare.
5621
5622 2019-05-08  Tom Tromey  <tromey@adacore.com>
5623
5624         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5625         method.
5626
5627 2019-05-08  Tom Tromey  <tromey@adacore.com>
5628
5629         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5630         when no wrap column is set.
5631
5632 2019-05-08  Tom Tromey  <tromey@adacore.com>
5633
5634         * c-lang.c (c_get_string): Handle non-C-style arrays.
5635
5636 2019-05-08  Tom Tromey  <tromey@adacore.com>
5637
5638         * typeprint.c (print_offset_data::update): Print the bit offset,
5639         not the number of bits remaining.
5640
5641 2019-05-08  Tom Tromey  <tromey@adacore.com>
5642
5643         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5644         padding at end of comment.
5645
5646 2019-05-08  Tom Tromey  <tromey@adacore.com>
5647
5648         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5649         Compare main types.
5650
5651 2019-05-06  Tom Tromey  <tom@tromey.com>
5652
5653         * common/scoped_mmap.c: Include common-defs.h.
5654         * common/scoped_mmap.h: Don't include config.h.
5655
5656 2019-05-04  Tom Tromey  <tom@tromey.com>
5657
5658         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5659         (struct aarch64_call_info): Add initializers.
5660         <si>: Now a std::vector.
5661         (pass_on_stack, aarch64_push_dummy_call): Update.
5662
5663 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5664             Tom Tromey  <tom@tromey.com>
5665
5666         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5667         (ppc_threads): Now a std::vector.  Now static.
5668         (hwdebug_find_thread_points_by_tid)
5669         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5670         Update.
5671
5672 2019-05-04  Tom Tromey  <tom@tromey.com>
5673
5674         * arc-tdep.c (arc_tdesc_init): Return bool.
5675
5676 2019-05-04  Tom Tromey  <tom@tromey.com>
5677
5678         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5679         Use gdb_assert_not_reached.
5680
5681 2019-05-04  Tom Tromey  <tom@tromey.com>
5682
5683         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5684         "false".
5685
5686 2019-05-04  Tom Tromey  <tom@tromey.com>
5687
5688         * arc-tdep.c (arc_tdesc_init): Use bool.
5689
5690 2019-05-04  Tom Tromey  <tom@tromey.com>
5691
5692         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5693
5694 2019-05-04  Tom Tromey  <tom@tromey.com>
5695
5696         * cli/cli-cmds.c (valid_command_p): Return bool.
5697
5698 2019-05-04  Tom Tromey  <tom@tromey.com>
5699
5700         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5701         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5702
5703 2019-05-04  Raul Tambre  <raul@tambre.ee>
5704
5705         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5706         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5707         operator for comparison.
5708
5709 2019-05-04  Tom Tromey  <tom@tromey.com>
5710
5711         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5712         (lookup_partial_symbol, print_partial_symbols)
5713         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5714         (psymbol_compare): Update.
5715         (add_psymbol_to_bcache): Clear the entire psymbol.
5716         (maintenance_check_psymtabs): Update.
5717         * psympriv.h (struct partial_symbol): Don't derive from
5718         general_symbol_info.
5719         <obj_section, unrelocated_address, address,
5720         set_unrelocated_address>: Update.
5721         <ginfo>: New member.
5722         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5723         (debug_names::write_psymbols): Update.
5724
5725 2019-05-04  Tom de Vries  <tdevries@suse.de>
5726
5727         * contrib/cc-with-tweaks.sh: Support -n arg.
5728
5729 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5730
5731         * corelow.c (core_target::detach): Ensure frame cache and
5732         register caches are cleared.
5733         inferior.c (exit_inferior_1): Likewise.
5734
5735 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5736             Tom Tromey  <tom@tromey.com>
5737
5738         * dictionary.c (collate_pending_symbols_by_language): Remove
5739         "struct" from foreach.
5740         * symtab.c (lookup_global_symbol_from_objfile)
5741         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5742         foreach.
5743         * ser-tcp.c (net_open): Remove "struct" from foreach.
5744         * objfiles.c (objfile_relocate, objfile_rebase)
5745         (objfile_has_symbols): Remove "struct" from foreach.
5746         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5747         from foreach.
5748         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5749         foreach.
5750         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5751         "struct" from foreach.
5752         * ada-lang.c (create_excep_cond_exprs)
5753         (ada_exception_catchpoint_cond_string): Remove "struct" from
5754         foreach.
5755
5756 2019-05-03  Tom Tromey  <tromey@adacore.com>
5757
5758         * ada-exp.y (convert_char_literal): Check suffix of each
5759         enumerator.
5760
5761 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5762
5763         PR ada/21406:
5764         * ada-exp.y (yywrap): Don't define.
5765         * ada-lex.l (%option): Add noyywrap
5766         (yywrap): Remove.
5767
5768 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5769
5770         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5771         _WIN32_WINNT to the XP level, unless already defined to a higher
5772         level.
5773
5774         * unittests/parse-connection-spec-selftests.c:
5775         * ser-tcp.c:
5776         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5777         override.
5778
5779         * symfile.c (find_separate_debug_file): Remove colon from the
5780         drive spec of DOS/Windows file names of the target, so that the
5781         file name produced from DEBUGDIR and the target's directory will
5782         be valid on DOS/Windows systems.
5783
5784 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5785
5786         * rust-lang.c (val_print_struct): Handle printing structures
5787         containing strings.
5788
5789 2019-05-02  Tom Tromey  <tromey@adacore.com>
5790
5791         * valarith.c (_initialize_valarith): Remove.
5792
5793 2019-05-01  Tom Tromey  <tromey@adacore.com>
5794
5795         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5796         bitfields.
5797
5798 2019-05-01  Tom Tromey  <tromey@adacore.com>
5799
5800         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5801         for big-endian copies.
5802
5803 2019-04-30  Ali Tamur  <tamur@google.com>
5804         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5805         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5806         (read_3_bytes): New function.
5807
5808 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5809
5810         * windows-nat.c (main_thread_id): Delete.
5811         (handle_output_debug_string): Replace main_thread_id by
5812         current_event.dwThreadId.
5813         (fake_create_process): Likewise.
5814         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5815         Do not set main_thread_id.
5816         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5817         current_event.dwThreadId.
5818         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5819
5820 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5821
5822         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5823         Use current_event.dwThreadId instead of main_thread_id.
5824
5825 2019-04-30  Tom Tromey  <tromey@adacore.com>
5826
5827         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5828         (create_excep_cond_exprs): Iterate over program spaces.
5829         (ada_exception_catchpoint_cond_string): Examine all minimal
5830         symbols for exception types.
5831
5832 2019-04-30  Tom Tromey  <tromey@adacore.com>
5833
5834         PR c++/24470:
5835         * dwarf2read.c (process_structure_scope): Handle case where type
5836         has template parameters but no symbol was created.
5837
5838 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5839             Chris January  <chris.january@arm.com>
5840
5841         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5842         qualifier.
5843         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5844
5845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5846
5847         * f-typeprint.c (f_print_type): Update rules for printing
5848         whitespace.
5849         (f_type_print_varspec_suffix): Likewise.
5850
5851 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5852             Chris January  <chris.january@arm.com>
5853
5854         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5855         function arguments.
5856
5857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         * f-lang.c (build_fortran_types): Change name of void type to
5860         lower case.
5861         * f-typeprint.c (f_type_print_base): Print the name of the void
5862         type, rather than a fixed string.
5863         * f-valprint.c (f_decorations): Use lower case void string.
5864
5865 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5866             Chris January  <chris.january@arm.com>
5867
5868         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5869         types for Fortran.
5870
5871 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5872             Chris January  <chris.january@arm.com>
5873             David Lecomber  <david.lecomber@arm.com>
5874
5875         * f-exp.y (BINOP_INTRINSIC): New token.
5876         (exp): New parser rule handling BINOP_INTRINSIC.
5877         (f77_keywords): Add new builtin procedures.
5878         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5879         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5880         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5881         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5882         (print_unop_subexp_f): New function.
5883         (print_binop_subexp_f): New function.
5884         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5885         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5886         (dump_subexp_body_f): Likewise.
5887         (operator_check_f): Likewise.
5888         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5889         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5890
5891 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5894         UNOP_KIND.
5895         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5896         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5897         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5898         (operator_length_f): New fuction.
5899         (print_subexp_f): New function.
5900         (op_name_f): New function.
5901         (dump_subexp_body_f): New function.
5902         (operator_check_f): New function.
5903         (exp_descriptor_f): Replace standard expression handling functions
5904         with new functions.
5905         * gdb/fortran-operator.def: New file.
5906         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5907         * gdb/std-operator.def: Remove UNOP_KIND.
5908
5909 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * std-operator.def: Remove unbalanced, stray double quote
5912         character.
5913
5914 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5915             Chris January  <chris.january@arm.com>
5916             Daniel Everett  <daniel.everett@arm.com>
5917             Nick Forrington  <nick.forrington@arm.com>
5918             Richard Bunt  <richard.bunt@arm.com>
5919
5920         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5921         of depth when printing anonymous structs or unions.
5922         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5923         Don't print either the top-level value, or the children if the
5924         max-depth is exceeded.
5925         (ppscm_print_children): When printing the key of a map, allow one
5926         extra level of depth.
5927         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5928         print either the top-level value, or the children if the max-depth
5929         is exceeded.
5930         (print_children): When printing the key of a map, allow one extra
5931         level of depth.
5932         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5933         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5934         (user_print_options): Initialise max_depth field.
5935         (val_print_scalar_or_string_type_p): New function.
5936         (val_print): Check to see if the max depth has been reached.
5937         (val_print_check_max_depth): Define new function.
5938         (show_print_max_depth): New function.
5939         (_initialize_valprint): Add 'print max-depth' option.
5940         * valprint.h (struct value_print_options) <max_depth>: New field.
5941         (val_print_check_max_depth): Declare new function.
5942         * NEWS: Document new feature.
5943
5944 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5945
5946         * ada-lang.c (ada_language_defn): Initialise new field.
5947         * c-lang.c (c_is_string_type_p): New function.
5948         (c_language_defn): Initialise new field.
5949         (cplus_language_defn): Initialise new field.
5950         (asm_language_defn): Initialise new field.
5951         (minimal_language_defn): Initialise new field.
5952         * c-lang.h (c_is_string_type_p): Declare new function.
5953         * d-lang.c (d_language_defn): Initialise new field.
5954         * f-lang.c (f_is_string_type_p): New function.
5955         (f_language_defn): Initialise new field.
5956         * go-lang.c (go_is_string_type_p): New function.
5957         (go_language_defn): Initialise new field.
5958         * language.c (default_is_string_type_p): New function.
5959         (unknown_language_defn): Initialise new field.
5960         (auto_language_defn): Initialise new field.
5961         * language.h (struct language_defn) <la_is_string_type_p>: New
5962         member variable.
5963         (default_is_string_type_p): Declare new function.
5964         * m2-lang.c (m2_language_defn): Initialise new field.
5965         * objc-lang.c (objc_language_defn): Initialise new field.
5966         * opencl-lang.c (opencl_language_defn): Initialise new field.
5967         * p-lang.c (pascal_is_string_type_p): New function.
5968         (pascal_language_defn): Initialise new field.
5969         * rust-lang.c (rust_is_string_type_p): New function.
5970         (rust_language_defn): Initialise new field.
5971
5972 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5973
5974         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5975         New field.
5976         * ada-lang.c (ada_language_defn): Initialise new field.
5977         * c-lang.c (c_language_defn): Likewise.
5978         (cplus_language_defn): Likewise.
5979         (asm_language_defn): Likewise.
5980         (minimal_language_defn): Likewise.
5981         * d-lang.c (d_language_defn): Likewise.
5982         * f-lang.c (f_language_defn): Likewise.
5983         * go-lang.c (go_language_defn): Likewise.
5984         * language.c (unknown_language_defn): Likewise.
5985         (auto_language_defn): Likewise.
5986         * m2-lang.c (m2_language_defn): Likewise.
5987         * objc-lang.c (objc_language_defn): Likewise.
5988         * opencl-lang.c (opencl_language_defn): Likewise.
5989         * p-lang.c (pascal_language_defn): Likewise.
5990         * rust-lang.c (rust_language_defn): Likewise.
5991
5992 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5993
5994         * ada-lang.c (ada_is_character_type): Change return type to bool.
5995         (ada_is_string_type): Likewise.
5996         * ada-lang.h (ada_is_character_type): Update declaration
5997         (ada_is_string_type): Likewise.
5998
5999 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6000
6001         Support style in 'frame|thread apply'
6002
6003         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6004         * record.c (record_start, record_stop): Update callers of
6005         execute_command_to_string with false.
6006         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6007         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6008         methods.
6009         (class string_file): New constructor with term_out parameter.
6010         Override methods term_out and can_emit_style_escape.  New member
6011         term_out.
6012         (class stdio_file): Override can_emit_style_escape.
6013         (class tee_file): Override term_out and can_emit_style_escape.
6014         * utils.h (can_emit_style_escape): Remove.
6015         * utils.c (can_emit_style_escape): Likewise.
6016         Update all callers of can_emit_style_escape (SOMESTREAM) to
6017         SOMESTREAM->can_emit_style_escape.
6018         * source-cache.c (source_cache::get_source_lines): Likewise.
6019         * stack.c (frame_apply_command_count): Call execute_command_to_string
6020         passing the term_out characteristic of the current gdb_stdout.
6021         * thread.c (thr_try_catch_cmd): Likewise.
6022         * top.c (execute_command_to_string): pass term_out parameter
6023         to construct the string_file for the command output.
6024         * ui-file.c (term_cli_styling): New function (most code moved
6025         from utils.c can_emit_style_escape).
6026         (string_file::string_file, string_file::can_emit_style_escape,
6027         stdio_file::can_emit_style_escape, tee_file::term_out,
6028         tee_file::can_emit_style_escape): New functions.
6029
6030 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6031
6032         * NEWS: Mention the new set|show may-call-functions.
6033         * infcall.c (may_call_functions_p): New variable.
6034         (show_may_call_functions_p): New function.
6035         (call_function_by_hand_dummy): Throws an error if not
6036         may-call-functions.
6037         (_initialize_infcall): Call add_setshow_boolean_cmd for
6038         may-call-functions.
6039
6040 2019-04-25  Keith Seitz  <keiths@redhat.com>
6041
6042         PR c++/24367
6043         * cp-support.c (inspect_type): Don't attempt substitutions
6044         of symbol with the same name.
6045
6046 2019-04-25  Tom Tromey  <tromey@adacore.com>
6047
6048         PR gdb/24475:
6049         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6050         static.
6051
6052 2019-04-25  Tom Tromey  <tromey@adacore.com>
6053
6054         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6055         rvalue reference.
6056         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6057         (gdb_xml_parser::parse): Use std::move.
6058         * python/python-internal.h (gdbpy_convert_exception): Take a const
6059         reference.
6060         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6061         std::move.
6062         * python/py-utils.c (gdbpy_convert_exception): Take a const
6063         reference.
6064         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6065         Use std::move.
6066         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6067         Use std::move.
6068         * mi/mi-main.c (mi_print_exception): Take a const reference.
6069         * main.c (handle_command_errors): Take a const reference.
6070         * linespec.c (parse_linespec): Use std::move.
6071         * infcall.c (run_inferior_call): Use std::move.
6072         (call_function_by_hand_dummy): Use std::move.
6073         * exec.c (try_open_exec_file): Use std::move.
6074         * exceptions.h (exception_print, exception_fprintf)
6075         (exception_print_same): Update.
6076         * exceptions.c (print_exception, exception_print)
6077         (exception_fprintf, exception_print_same): Change parameters to
6078         const reference.
6079         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6080         * common/new-op.c: Use std::move.
6081         * common/common-exceptions.h (struct gdb_exception): Add move
6082         constructor.
6083         (struct gdb_exception_error, struct gdb_exception_quit, struct
6084         gdb_quit_bad_alloc): Change constructor to move constructor.
6085         (throw_exception): Change parameter to rvalue reference.
6086         * common/common-exceptions.c (throw_exception): Take rvalue
6087         reference.
6088         * cli/cli-interp.c (safe_execute_command): Use std::move.
6089         * breakpoint.c (insert_bp_location, location_to_sals): Use
6090         std::move.
6091
6092 2019-04-25  Tom Tromey  <tromey@adacore.com>
6093
6094         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6095         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6096         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6097         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6098         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6099         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6100         guile/scm-value.c: Use unpack.
6101         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6102         gdbscm_gdb_exception.
6103         (gdbscm_throw_gdb_exception): Likewise.
6104         (struct gdbscm_gdb_exception): New.
6105         (unpack): New function.
6106         (gdbscm_wrap): Use unpack.
6107
6108 2019-04-25  Tom Tromey  <tromey@adacore.com>
6109
6110         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6111         (gdb_rl_callback_handler): Use std::move.
6112         * common/common-exceptions.h (struct gdb_exception): Add move
6113         assignment operator.
6114         (throw_exception_sjlj): Change "exception" to const reference.
6115         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6116         (throw_exception_sjlj): Change "exception" to const reference.
6117
6118 2019-04-25  Tom Tromey  <tromey@adacore.com>
6119
6120         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6121         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6122         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6123         Update.
6124         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6125         Update.
6126         * mi/mi-interp.c (mi_interp::exec): Update.
6127         * linespec.c (parse_linespec): Update.
6128         * infcall.c (run_inferior_call): Update.
6129         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6130         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6131         (gdbscm_lookup_global_symbol): Update.
6132         * guile/scm-param.c (gdbscm_parameter_value): Update.
6133         * guile/scm-frame.c (gdbscm_frame_read_register)
6134         (gdbscm_frame_read_var): Update.
6135         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6136         * exec.c (try_open_exec_file): Update.
6137         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6138         (gdb_rl_callback_handler): Update.
6139         * common/common-exceptions.h (exception_none): Don't declare.
6140         * common/common-exceptions.c (exception_none): Don't define.
6141         (struct catcher) <exception>: Update.
6142         * cli/cli-interp.c (safe_execute_command): Update.
6143         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6144
6145 2019-04-25  Ali Tamur  <tamur@google.com>
6146
6147         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6148         (read_attribute_value): Likewise.
6149         (dwarf2_read_addr_index): Update comment.
6150         (read_str_index): Add DW_FORM_strx.
6151         (dwarf2_string_attr): Likewise.
6152         (dwarf2_const_value_attr): Likewise.
6153         (dump_die_shallow): Likewise.
6154         (dwarf2_fetch_constant_bytes): Likewise.
6155         (skip_form_bytes): Likewise.
6156         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6157
6158 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6159
6160         PR corefiles/11608
6161         PR corefiles/18187
6162         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6163         OFFSET.  Verify if current mapping contains an ELF header.
6164         (linux_find_memory_regions_full): Adjust call to
6165         dump_mapping_p.
6166
6167 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6168             Kang Li <kanglictf@gmail.com>
6169
6170         PR gdb/21600
6171
6172         * dwarf2-frame.c (read_initial_length): Be consistent about using
6173         unsigned representation of length.
6174         (decode_frame_entry_1): Likewise.  Check for wraparound of
6175         end pointer as well as buffer overflow.
6176
6177 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6178
6179         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6180         "vq".
6181
6182 2019-04-24  Tom Tromey  <tromey@adacore.com>
6183
6184         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6185
6186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * s12z-tdep.c (s12z_unwind_pc): Delete.
6189         (s12z_unwind_sp): Delete.
6190         (s12z_gdbarch_init): Don't register deleted functions with
6191         gdbarch.
6192
6193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6194
6195         * rl78-tdep.c (rl78_unwind_sp): Delete.
6196         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6197
6198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6199
6200         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6201         (xstormy16_unwind_pc): Delete.
6202         (xstormy16_dummy_id): Delete.
6203         (xstormy16_gdbarch_init): Don't register deleted functions with
6204         gdbarch.
6205
6206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * vax-tdep.c (vax_unwind_pc): Delete.
6209         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6210
6211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * v850-tdep.c (v850_unwind_sp): Delete.
6214         (v850_unwind_pc): Delete.
6215         (v850_dummy_id): Delete.
6216         (v850_gdbarch_init): Don't register deleted functions with
6217         gdbarch.
6218
6219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6222         (tilegx_unwind_pc): Delete.
6223         (tilegx_unwind_dummy_id): Delete.
6224         (tilegx_gdbarch_init): Don't register deleted functions with
6225         gdbarch.
6226
6227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6230         (tic6x_dummy_id): Delete.
6231         (tic6x_gdbarch_init): Don't register deleted functions with
6232         gdbarch.
6233
6234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * sparc-tdep.c (sparc_unwind_pc): Delete.
6237         (sparc32_gdbarch_init): Don't register deleted function with
6238         gdbarch.
6239
6240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6241
6242         * sh-tdep.c (sh_unwind_sp): Delete.
6243         (sh_unwind_pc): Delete.
6244         (sh_dummy_id): Delete.
6245         (sh_gdbarch_init): Don't register deleted functions with
6246         gdbarch.
6247
6248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * score-tdep.c (score_unwind_sp): Delete.
6251         (score_unwind_pc): Delete.
6252         (score_dummy_id): Delete.
6253         (score_gdbarch_init): Don't register deleted functions with
6254         gdbarch.
6255
6256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * rx-tdep.c (rx_unwind_pc): Delete.
6259         (rx_unwind_sp): Delete.
6260         (rx_dummy_id): Delete.
6261         (rx_gdbarch_init): Don't register deleted functions with
6262         gdbarch.  Update comment.
6263
6264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6267         (rs6000_dummy_id): Delete.
6268         (rs6000_gdbarch_init): Don't register deleted functions with
6269         gdbarch.
6270
6271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6272
6273         * or1k-tdep.c (or1k_dummy_id): Delete.
6274         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6275
6276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * nios2-tdep.c (nios2_dummy_id): Delete.
6279         (nios2_unwind_sp): Delete.
6280         (nios2_gdbarch_init): Don't register deleted functions with
6281         gdbarch.
6282
6283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6284
6285         * nds32-tdep.c (nds32_dummy_id): Delete.
6286         (nds32_unwind_pc): Delete.
6287         (nds32_unwind_sp): Delete.
6288         (nds32_gdbarch_init): Don't register deleted functions with
6289         gdbarch.
6290
6291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6292
6293         * msp430-tdep.c (msp430_unwind_pc): Delete.
6294         (msp430_unwind_sp): Delete.
6295         (msp430_dummy_id): Delete.
6296         (msp430_gdbarch_init): Don't register deleted functions with
6297         gdbarch.
6298
6299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * moxie-tdep.c (moxie_unwind_sp): Delete.
6302         (moxie_unwind_pc): Delete.
6303         (moxie_dummy_id): Delete.
6304         (moxie_gdbarch_init): Don't register deleted functions with
6305         gdbarch.
6306
6307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6310         (mn10300_unwind_pc): Delete.
6311         (mn10300_unwind_sp): Delete.
6312         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6313         mn10300_unwind_sp.
6314         (mn10300_frame_unwind_init): Don't register deleted functions with
6315         gdbarch.
6316
6317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * mep-tdep.c (mep_unwind_pc): Delete.
6320         (mep_unwind_sp): Delete.
6321         (mep_dummy_id): Delete.
6322         (mep_gdbarch_init): Don't register deleted functions with
6323         gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6328         (m68hc11_unwind_sp): Delete.
6329         (m68hc11_gdbarch_init): Don't register deleted functions with
6330         gdbarch.
6331
6332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * m32r-tdep.c (m32r_unwind_sp): Delete.
6335         (m32r_unwind_pc): Delete.
6336         (m32r_dummy_id): Delete.
6337         (m32r_gdbarch_init): Don't register deleted functions with
6338         gdbarch.
6339
6340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * m32c-tdep.c (m32c_unwind_pc): Delete.
6343         (m32c_unwind_sp): Delete.
6344         (m32c_dummy_id): Delete.
6345         (m32c_gdbarch_init): Don't register deleted functions with
6346         gdbarch.
6347
6348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6351         (lm32_unwind_pc): Delete.
6352         (lm32_dummy_id): Delete.
6353         (lm32_gdbarch_init): Don't register deleted functions with
6354         gdbarch.
6355
6356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6359         (iq2000_unwind_pc): Delete.
6360         (iq2000_dummy_id): Delete.
6361         (iq2000_gdbarch_init): Don't register deleted functions with
6362         gdbarch.
6363
6364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6365
6366         * nds32-tdep.c (nds32_type_align): Delete.
6367         (nds32_push_dummy_call): Use type_align instead.
6368
6369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6370
6371         * arm-tdep.c (arm_type_align): Only handle vector override case.
6372         (arm_push_dummy_call): Use type_align.
6373         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6374
6375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6378         case.
6379         (pass_on_stack): Use type_align.
6380         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6381         function.
6382
6383 2019-04-23  Tom Tromey  <tromey@adacore.com>
6384
6385         * dwarf2read.c (line_header::file_name_at): Remove unused
6386         overload.
6387
6388 2019-04-23  Tom de Vries  <tdevries@suse.de>
6389
6390         PR gdb/24438
6391         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6392         invocation.
6393
6394
6395 2019-03-27  Ali Tamur  <tamur@google.com>
6396
6397         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6398         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6399         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6400         (dwarf_expr_context::get_addr_index): Likewise
6401         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6402         (symbol_needs_eval_context::get_addr_index): Likewise
6403         (disassemble_dwarf_expression): Add DW_OP_addrx
6404         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6405         (read_cutu_die_from_dwo): Update comment
6406         (skip_one_die): Add DW_FORM_addrx
6407         (read_attribute_value): Likewise
6408         (var_decode_location): Add DW_OP_addrx
6409         (dwarf2_const_value_attr): Add DW_FORM_addrx
6410         (dump_die_shallow): Likewise
6411         (dwarf2_fetch_constant_bytes): Likewise
6412         (decode_locdesc): Add DW_OP_addrx
6413         (skip_form_bytes): Add DW_FORM_addrx
6414
6415 2019-04-22  Ali Tamur  <tamur@google.com>
6416
6417         * MAINTAINERS (Write After Approval): Add self.
6418
6419 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6420
6421         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6422         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6423         (open_symbol_file_object): Likewise.
6424         (svr4_default_sos): Add info parameter.
6425         (svr4_read_so_list): Likewise.
6426         (svr4_current_sos_direct): Adjust functions calls to pass down
6427         info.
6428         (svr4_current_sos_1): Add info parameter.
6429         (svr4_current_sos): Call get_svr4_info, pass info down to
6430         svr4_current_sos_1.
6431         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6432         get_svr4_info.
6433         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6434         get_svr4_info.
6435         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6436         to get_svr4_info.
6437         (probes_table_remove_objfile_probes): Likewise.
6438         (register_solib_event_probe): Add info parameter.
6439         (solist_update_incremental): Pass info parameter down to
6440         svr4_read_so_list.
6441         (disable_probes_interface): Add info parameter.
6442         (svr4_handle_solib_event): Pass current_program_space to
6443         get_svr4_info.  Adjust disable_probes_interface cleanup.
6444         (svr4_create_probe_breakpoints): Add info parameter, pass it
6445         down to register_solib_event_probe.
6446         (svr4_create_solib_event_breakpoints): Add info parameter,
6447         pass it down to svr4_create_probe_breakpoints.
6448         (enable_break): Pass info down to
6449         svr4_create_solib_event_breakpoints.
6450         (svr4_solib_create_inferior_hook): Pass current_program_space to
6451         get_svr4_info.
6452         (svr4_clear_solib): Likewise.
6453
6454 2019-04-22  Pedro Alves  <palves@redhat.com>
6455
6456         * solib-svr4.c (svr4_free_objfile_observer): New.
6457         (probe_and_action::objfile): New field.
6458         (probes_table_htab_remove_objfile_probes)
6459         (probes_table_remove_objfile_probes): New functions.
6460         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6461         in the new probe_and_action.  Don't store the probe in 'lookup'.
6462         (svr4_create_probe_breakpoints): Pass objfile to
6463         register_solib_event_probe.
6464         (_initialize_svr4_solib): Register a free_objfile observer.
6465
6466 2019-04-19  Tom Tromey  <tom@tromey.com>
6467
6468         * common/queue.h: Remove.
6469
6470 2019-04-19  Tom Tromey  <tom@tromey.com>
6471
6472         * event-loop.c: Don't include "common/queue.h".
6473
6474 2019-04-19  Tom Tromey  <tom@tromey.com>
6475
6476         * remote.c (remote_target): Use delete.
6477         * remote-notif.h: Include <list>, not "common/queue.h".
6478         (notif_client_p): Remove typedef.
6479         (remote_notif_state): Add constructor, destructor, initializer.
6480         <notif_queue>: Now a std::list.
6481         (remote_notif_state_xfree): Don't declare.
6482         * remote-notif.c (remote_notif_process, handle_notification)
6483         (remote_notif_state_allocate): Update.
6484         (~remote_notif_state): Rename from remote_notif_state_xfree.
6485
6486 2019-04-19  Tom Tromey  <tom@tromey.com>
6487
6488         * symfile.c (reread_symbols): Update.
6489         * objfiles.c (objfile_register_static_link)
6490         (objfile_lookup_static_link): Update
6491         (~objfile) Don't delete static_links.
6492         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6493
6494 2019-04-19  Tom Tromey  <tom@tromey.com>
6495
6496         * type-stack.h (struct type_stack) <insert>: Constify string.
6497         * type-stack.c (type_stack::insert): Constify string.
6498         * gdbtypes.h (lookup_template_type): Update.
6499         (address_space_name_to_int): Update.
6500         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6501         const.
6502         (lookup_template_type): Make name const.
6503         * c-exp.y: Update rules.
6504         (lex_one_token, classify_name, classify_inner_name)
6505         (c_print_token): Update.
6506         * p-exp.y: Update rules.
6507         (yylex): Update.
6508         * f-exp.y: Update rules.
6509         (yylex): Update.
6510         * d-exp.y: Update rules.
6511         (lex_one_token, classify_name, classify_inner_name): Update.
6512         * parse.c (write_dollar_variable, copy_name): Return std::string.
6513         * parser-defs.h (copy_name): Change return type.
6514         * m2-exp.y: Update rules.
6515         (yylex): Update.
6516         * go-exp.y (lex_one_token): Update.
6517         Update rules.
6518         (classify_unsafe_function, classify_packaged_name)
6519         (classify_name, yylex): Update.
6520
6521 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6522
6523         * configure.ac: add --enable-source-highlight switch.
6524         * configure: Regenerate.
6525         * top.c (print_gdb_version): plumb --enable-source-highlight
6526         status to "show configuration".
6527
6528 2019-04-19  Tom Tromey  <tromey@adacore.com>
6529
6530         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6531         Check ADA_TYPE_P.
6532         (empty_record, ada_template_to_fixed_record_type_1)
6533         (template_to_static_fixed_type)
6534         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6535         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6536         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6537         macros.
6538
6539 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6540
6541         PR symtab/24423:
6542         * source.c (print_source_lines_base): Advance "iter" when a
6543         control character is seen.
6544
6545 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6546
6547         * inferior.h (struct infcall_suspend_state_deleter):
6548         Catch exception in destructor to avoid crash.
6549
6550 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6551
6552         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6553         close to the add_com "shell".
6554
6555 2019-04-18  Tom Tromey  <tromey@adacore.com>
6556
6557         * process-stratum-target.h (class process_stratum_target)
6558         <stratum>: Add "final".
6559
6560 2019-04-17  Tom Tromey  <tromey@adacore.com>
6561
6562         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6563         against nullptr before use.
6564
6565 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6566
6567         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6568
6569 2019-04-17  Jim Wilson  <jimw@sifive.com>
6570             Andrew Burgess  <andrew.burgess@embecosm.com>
6571
6572         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6573         code read might fail, assume 4-byte breakpoint in that case.
6574
6575 2019-04-15  Leszek Swirski  <leszeks@google.com>
6576
6577         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6578         rather than a hand-rolled POD check when checking for forced MEMORY
6579         classification.
6580
6581 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6582
6583         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6584         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6585         function.
6586         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6587         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6588         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6589         declaration.
6590
6591 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6592
6593         * aarch64-linux-nat.c
6594         (aarch64_linux_nat_target::thread_architecture): Add override.
6595         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6596         each VQ.
6597
6598 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6599
6600         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6601
6602 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6603
6604         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6605         target types of size 96-bits, add some additional comments, and
6606         check that the builtin type we found was the correct size.
6607
6608 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6609
6610         * utils.c (prompt_for_continue): Don't restore the styling at the
6611         end, as applied_style has the wrong value.  This fixes styling in
6612         long lists of file names that are interrupted by the "Continue?"
6613         prompt.
6614
6615 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6616
6617         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6618         * c-lang.c (c_language_defn): Likewise.
6619         (cplus_language_defn): Likewise.
6620         (asm_language_defn): Likewise.
6621         (minimal_language_defn): Likewise.
6622         * d-lang.c (d_language_defn): Likewise.
6623         * f-lang.c (f_language_defn): Likewise.
6624         * go-lang.c (go_language_defn): Likewise.
6625         * language.c (unknown_language_defn): Likewise.
6626         (auto_language_defn): Likewise.
6627         * language.h (struct language_defn): Remove la_magic field.
6628         (LANG_MAGIC): Delete.
6629         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6630         * objc-lang.c (objc_language_defn): Likewise.
6631         * opencl-lang.c (opencl_language_defn): Likewise.
6632         * p-lang.c (pascal_language_defn): Likewise.
6633         * rust-lang.c (rust_language_defn): Likewise.
6634
6635 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6636
6637         * riscv-tdep.c (riscv_type_align): New function.
6638         (riscv_type_alignment): Delete.
6639         (riscv_arg_location): Use 'type_align'.
6640         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6641
6642 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6643
6644         * gdbtypes.c (type_align): A struct with no non-static fields also
6645         has alignment of 1.
6646
6647 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6650         component to 0.
6651         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6652         member.
6653         (riscv_struct_info::analyse): New implementation using new
6654         analyse_inner member function.
6655         (riscv_struct_info::field_offset): New member function.
6656         (riscv_struct_info::m_offsets): New member variable.
6657         (riscv_struct_info::analyse_inner): New private member function,
6658         takes the old implementation of riscv_struct_info::analyse but
6659         extended to track field offsets.
6660         (riscv_call_arg_struct): Update the struct folding special cases
6661         to handle cases where empty C++ structs, which are non-zero
6662         length, are found.
6663         (riscv_arg_location): Initialise the length of each location, a
6664         non-zero length now indicates the location is in use.
6665         (riscv_push_dummy_call): Allow for the first location having a
6666         non-zero offset when setting up arguments.
6667         (riscv_return_value): Likewise, but for return values.
6668
6669 2019-04-11  Tom Tromey  <tromey@adacore.com>
6670
6671         * utils.c (internal_vproblem): Make "msg" const.
6672
6673 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6674
6675         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6676         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6677         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6678         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6679
6680 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6681
6682         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6683         function.
6684         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6685         of amd64_collect_native_gregset.
6686         (amd64_linux_nat_target::store_registers): Likewise.
6687
6688 2019-04-10  Tom Tromey  <tom@tromey.com>
6689
6690         * symtab.c (lookup_global_symbol_from_objfile)
6691         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6692         * objfiles.h (class separate_debug_iterator): New.
6693         (class separate_debug_range): New.
6694         (struct objfile) <separate_debug_objfiles>: New method.
6695         (objfile_separate_debug_iterate): Don't declare.
6696         * objfiles.c (separate_debug_iterator::operator++): Rename from
6697         objfile_separate_debug_iterate.
6698         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6699         iterator.
6700         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6701         iterator.
6702
6703 2019-04-10  Tom Tromey  <tom@tromey.com>
6704
6705         * symfile.c (reread_symbols): Remove old comment.
6706         * objfiles.c (free_all_objfiles): Fix a typo.
6707
6708 2019-04-10  Tom Tromey  <tom@tromey.com>
6709
6710         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6711         * minsyms.c (lookup_minimal_symbol): Use foreach.
6712         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6713         (lookup_minimal_symbol_solib_trampoline): Likewise.
6714         * symfile.c (reread_symbols): Use foreach.
6715
6716 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6717             Tom Tromey  <tromey@adacore.com>
6718
6719         PR rust/24414:
6720         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6721         (rust_lex_int_test): Change "value" to be LONGEST.
6722         (rust_lex_tests): Add test for long integer literal.
6723
6724 2019-04-09  Tom Tromey  <tromey@adacore.com>
6725
6726         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6727         to bool.
6728         (extended_remote_target::attach): Update.
6729         (remote_target::remote_notice_new_inferior): Update.
6730         (remote_target::add_current_inferior_and_thread): Update.
6731         * inferior.c (exit_inferior_1): Use "false".
6732         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6733
6734 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6735
6736         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6737         the "start" command.
6738
6739 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6740
6741         * python/py-inferior.c (infpy_thread_from_thread_handle):
6742         Adjust comments to reflect renaming of thread_from_thread_handle
6743         to thread_from_handle.  Adjust keywords.  Fix type error message.
6744         (inferior_object_methods): Add thread_from_handle.  Retain
6745         thread_from_thread_handle, but mark it as deprecated.
6746
6747 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6748
6749         * gdbthread.h (find_thread_by_handle): Revise declaration.
6750         * thread.c (find_thread_by_handle): Likewise.  Adjust
6751         implementation too.
6752         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6753         support for buffer objects as handles.
6754
6755 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6756
6757         * python/py-infthread.c (thpy_thread_handle): New function.
6758         (thread_object_methods): Register thpy_thread_handle.
6759
6760 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6761
6762         * gdbthread.h (thread_to_thread_handle): Declare.
6763         * thread.c (gdbtypes.h): Include.
6764         (thread_to_thread_handle): New function.
6765
6766         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6767         (target_thread_info_to_thread_handle): Declare.
6768         * target.c (target_thread_info_to_thread_handle): New function.
6769         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6770         * target-delegates.c: Regenerate.
6771
6772         * linux-thread-db.c (class thread_db_target): Add method
6773         thread_info_to_thread_handle.
6774         (thread_db_target::thread_info_to_thread_handle): Define.
6775         * remote.c (class remote_target): Add new method
6776         thread_info_to_thread_handle.
6777         (remote_target::thread_info_to_thread_handle): Define.
6778
6779 2019-04-08  Pedro Alves  <palves@redhat.com>
6780
6781         * common/common-exceptions.c (throw_exception): Don't create
6782         named object to throw; throw directly.
6783         (throw_it): Likewise.  Don't initialize gdb_exception::message
6784         here, with new; pass FMT and AP to the ctor instead.
6785         * common/common-exceptions.h: Include <string>.
6786         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6787         const char *, va_list)): New ctor.  Use std::make_shared.
6788         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6789         errors)): Delete.
6790         (gdb_exception_error::gdb_exception_error(enum errors, const char
6791         *, va_list)): New.
6792         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6793         Add assertion.
6794         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6795         errors)): Delete.
6796         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6797         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6798         Add assertion.
6799
6800 2019-04-08  Tom Tromey  <tom@tromey.com>
6801
6802         * valops.c (value_rtti_indirect_type): Replace throw_exception
6803         with throw.
6804         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6805         with throw.
6806         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6807         throw.
6808         * target.c (target_translate_tls_address): Replace throw_exception
6809         with throw.
6810         * stack.c (frame_apply_command_count): Replace throw_exception
6811         with throw.
6812         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6813         throw.
6814         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6815         with throw.
6816         * rs6000-tdep.c (rs6000_frame_cache)
6817         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6818         * remote.c: Replace throw_exception with throw.
6819         * record-full.c (record_full_message, record_full_wait_1)
6820         (record_full_restore): Replace throw_exception with throw.
6821         * record-btrace.c:
6822         (get_thread_current_frame_id, record_btrace_start_replaying)
6823         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6824         (cmd_record_btrace_start): Replace throw_exception with throw.
6825         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6826         throw.
6827         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6828         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6829         * linespec.c:
6830         (find_linespec_symbols): Replace throw_exception with throw.
6831         * infrun.c (displaced_step_prepare, resume): Replace
6832         throw_exception with throw.
6833         * infcmd.c (post_create_inferior): Replace throw_exception with
6834         throw.
6835         * inf-loop.c (inferior_event_handler): Replace throw_exception
6836         with throw.
6837         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6838         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6839         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6840         (get_prev_frame_always, get_frame_pc_if_available)
6841         (get_frame_address_in_block_if_available, get_frame_language):
6842         Replace throw_exception with throw.
6843         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6844         throw_exception with throw.
6845         * eval.c (fetch_subexp_value, evaluate_var_value)
6846         (evaluate_funcall, evaluate_subexp_standard): Replace
6847         throw_exception with throw.
6848         * dwarf2loc.c (call_site_find_chain)
6849         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6850         Replace throw_exception with throw.
6851         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6852         with throw.
6853         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6854         throw.
6855         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6856         * completer.c (complete_line_internal): Replace throw_exception
6857         with throw.
6858         * compile/compile-object-run.c (compile_object_run): Replace
6859         throw_exception with throw.
6860         * cli/cli-script.c (process_next_line): Replace throw_exception
6861         with throw.
6862         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6863         (btrace_enable, btrace_maint_update_pt_packets): Replace
6864         throw_exception with throw.
6865         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6866         throw_exception with throw.
6867         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6868         throw_exception with throw.
6869         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6870         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6871         * aarch64-tdep.c (aarch64_make_prologue_cache)
6872         (aarch64_make_stub_cache): Replace throw_exception with throw.
6873
6874 2019-04-08  Tom Tromey  <tom@tromey.com>
6875
6876         * common/common-exceptions.c (throw_exception): Rename from
6877         throw_exception_cxx.  Remove old copy.  Make argument const.
6878         (throw_it): Create and throw exception objects directly.
6879         * common/common-exceptions.h (throw_exception): Make argument
6880         const.
6881         (struct gdb_exception_error): Add constructor.
6882         (struct gdb_exception_quit): Add constructor.
6883
6884 2019-04-08  Tom Tromey  <tom@tromey.com>
6885
6886         * common/common-exceptions.h (exception_rethrow): Don't declare.
6887         (TRY_SJLJ): Update comment.
6888         (TRY, CATCH, END_CATCH): Remove.
6889         * common/common-exceptions.c (exception_rethrow): Remove.
6890
6891 2019-04-08  Tom Tromey  <tom@tromey.com>
6892
6893         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6894         Remove.
6895         (gdb_exception_error): Rename from
6896         gdb_exception_RETURN_MASK_ERROR.
6897         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6898         (gdb_quit_bad_alloc): Update.
6899         * aarch64-tdep.c: Update.
6900         * ada-lang.c: Update.
6901         * ada-typeprint.c: Update.
6902         * ada-valprint.c: Update.
6903         * amd64-tdep.c: Update.
6904         * arch-utils.c: Update.
6905         * break-catch-throw.c: Update.
6906         * breakpoint.c: Update.
6907         * btrace.c: Update.
6908         * c-varobj.c: Update.
6909         * cli/cli-cmds.c: Update.
6910         * cli/cli-interp.c: Update.
6911         * cli/cli-script.c: Update.
6912         * common/common-exceptions.c: Update.
6913         * common/new-op.c: Update.
6914         * common/selftest.c: Update.
6915         * compile/compile-c-symbols.c: Update.
6916         * compile/compile-cplus-symbols.c: Update.
6917         * compile/compile-object-load.c: Update.
6918         * compile/compile-object-run.c: Update.
6919         * completer.c: Update.
6920         * corelow.c: Update.
6921         * cp-abi.c: Update.
6922         * cp-support.c: Update.
6923         * cp-valprint.c: Update.
6924         * darwin-nat.c: Update.
6925         * disasm-selftests.c: Update.
6926         * dtrace-probe.c: Update.
6927         * dwarf-index-cache.c: Update.
6928         * dwarf-index-write.c: Update.
6929         * dwarf2-frame-tailcall.c: Update.
6930         * dwarf2-frame.c: Update.
6931         * dwarf2loc.c: Update.
6932         * dwarf2read.c: Update.
6933         * eval.c: Update.
6934         * event-loop.c: Update.
6935         * event-top.c: Update.
6936         * exec.c: Update.
6937         * f-valprint.c: Update.
6938         * fbsd-tdep.c: Update.
6939         * frame-unwind.c: Update.
6940         * frame.c: Update.
6941         * gdbtypes.c: Update.
6942         * gnu-v3-abi.c: Update.
6943         * guile/guile-internal.h: Update.
6944         * guile/scm-block.c: Update.
6945         * guile/scm-breakpoint.c: Update.
6946         * guile/scm-cmd.c: Update.
6947         * guile/scm-disasm.c: Update.
6948         * guile/scm-frame.c: Update.
6949         * guile/scm-lazy-string.c: Update.
6950         * guile/scm-math.c: Update.
6951         * guile/scm-param.c: Update.
6952         * guile/scm-ports.c: Update.
6953         * guile/scm-pretty-print.c: Update.
6954         * guile/scm-symbol.c: Update.
6955         * guile/scm-symtab.c: Update.
6956         * guile/scm-type.c: Update.
6957         * guile/scm-value.c: Update.
6958         * i386-linux-tdep.c: Update.
6959         * i386-tdep.c: Update.
6960         * inf-loop.c: Update.
6961         * infcall.c: Update.
6962         * infcmd.c: Update.
6963         * infrun.c: Update.
6964         * jit.c: Update.
6965         * language.c: Update.
6966         * linespec.c: Update.
6967         * linux-fork.c: Update.
6968         * linux-nat.c: Update.
6969         * linux-tdep.c: Update.
6970         * linux-thread-db.c: Update.
6971         * main.c: Update.
6972         * mi/mi-cmd-break.c: Update.
6973         * mi/mi-cmd-stack.c: Update.
6974         * mi/mi-interp.c: Update.
6975         * mi/mi-main.c: Update.
6976         * objc-lang.c: Update.
6977         * p-valprint.c: Update.
6978         * parse.c: Update.
6979         * ppc-linux-tdep.c: Update.
6980         * printcmd.c: Update.
6981         * python/py-arch.c: Update.
6982         * python/py-breakpoint.c: Update.
6983         * python/py-cmd.c: Update.
6984         * python/py-finishbreakpoint.c: Update.
6985         * python/py-frame.c: Update.
6986         * python/py-framefilter.c: Update.
6987         * python/py-gdb-readline.c: Update.
6988         * python/py-inferior.c: Update.
6989         * python/py-infthread.c: Update.
6990         * python/py-lazy-string.c: Update.
6991         * python/py-linetable.c: Update.
6992         * python/py-objfile.c: Update.
6993         * python/py-param.c: Update.
6994         * python/py-prettyprint.c: Update.
6995         * python/py-progspace.c: Update.
6996         * python/py-record-btrace.c: Update.
6997         * python/py-record.c: Update.
6998         * python/py-symbol.c: Update.
6999         * python/py-type.c: Update.
7000         * python/py-unwind.c: Update.
7001         * python/py-utils.c: Update.
7002         * python/py-value.c: Update.
7003         * python/python.c: Update.
7004         * record-btrace.c: Update.
7005         * record-full.c: Update.
7006         * remote-fileio.c: Update.
7007         * remote.c: Update.
7008         * riscv-tdep.c: Update.
7009         * rs6000-aix-tdep.c: Update.
7010         * rs6000-tdep.c: Update.
7011         * rust-exp.y: Update.
7012         * rust-lang.c: Update.
7013         * s390-tdep.c: Update.
7014         * selftest-arch.c: Update.
7015         * solib-dsbt.c: Update.
7016         * solib-frv.c: Update.
7017         * solib-spu.c: Update.
7018         * solib-svr4.c: Update.
7019         * solib.c: Update.
7020         * sparc64-linux-tdep.c: Update.
7021         * stack.c: Update.
7022         * symfile-mem.c: Update.
7023         * symmisc.c: Update.
7024         * target.c: Update.
7025         * thread.c: Update.
7026         * top.c: Update.
7027         * tracefile-tfile.c: Update.
7028         * tui/tui.c: Update.
7029         * typeprint.c: Update.
7030         * unittests/cli-utils-selftests.c: Update.
7031         * unittests/parse-connection-spec-selftests.c: Update.
7032         * valops.c: Update.
7033         * valprint.c: Update.
7034         * value.c: Update.
7035         * varobj.c: Update.
7036         * windows-nat.c: Update.
7037         * x86-linux-nat.c: Update.
7038         * xml-support.c: Update.
7039
7040 2019-04-08  Tom Tromey  <tom@tromey.com>
7041
7042         * xml-support.c: Use C++ exception handling.
7043         * x86-linux-nat.c: Use C++ exception handling.
7044         * windows-nat.c: Use C++ exception handling.
7045         * varobj.c: Use C++ exception handling.
7046         * value.c: Use C++ exception handling.
7047         * valprint.c: Use C++ exception handling.
7048         * valops.c: Use C++ exception handling.
7049         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7050         handling.
7051         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7052         * typeprint.c: Use C++ exception handling.
7053         * tui/tui.c: Use C++ exception handling.
7054         * tracefile-tfile.c: Use C++ exception handling.
7055         * top.c: Use C++ exception handling.
7056         * thread.c: Use C++ exception handling.
7057         * target.c: Use C++ exception handling.
7058         * symmisc.c: Use C++ exception handling.
7059         * symfile-mem.c: Use C++ exception handling.
7060         * stack.c: Use C++ exception handling.
7061         * sparc64-linux-tdep.c: Use C++ exception handling.
7062         * solib.c: Use C++ exception handling.
7063         * solib-svr4.c: Use C++ exception handling.
7064         * solib-spu.c: Use C++ exception handling.
7065         * solib-frv.c: Use C++ exception handling.
7066         * solib-dsbt.c: Use C++ exception handling.
7067         * selftest-arch.c: Use C++ exception handling.
7068         * s390-tdep.c: Use C++ exception handling.
7069         * rust-lang.c: Use C++ exception handling.
7070         * rust-exp.y: Use C++ exception handling.
7071         * rs6000-tdep.c: Use C++ exception handling.
7072         * rs6000-aix-tdep.c: Use C++ exception handling.
7073         * riscv-tdep.c: Use C++ exception handling.
7074         * remote.c: Use C++ exception handling.
7075         * remote-fileio.c: Use C++ exception handling.
7076         * record-full.c: Use C++ exception handling.
7077         * record-btrace.c: Use C++ exception handling.
7078         * python/python.c: Use C++ exception handling.
7079         * python/py-value.c: Use C++ exception handling.
7080         * python/py-utils.c: Use C++ exception handling.
7081         * python/py-unwind.c: Use C++ exception handling.
7082         * python/py-type.c: Use C++ exception handling.
7083         * python/py-symbol.c: Use C++ exception handling.
7084         * python/py-record.c: Use C++ exception handling.
7085         * python/py-record-btrace.c: Use C++ exception handling.
7086         * python/py-progspace.c: Use C++ exception handling.
7087         * python/py-prettyprint.c: Use C++ exception handling.
7088         * python/py-param.c: Use C++ exception handling.
7089         * python/py-objfile.c: Use C++ exception handling.
7090         * python/py-linetable.c: Use C++ exception handling.
7091         * python/py-lazy-string.c: Use C++ exception handling.
7092         * python/py-infthread.c: Use C++ exception handling.
7093         * python/py-inferior.c: Use C++ exception handling.
7094         * python/py-gdb-readline.c: Use C++ exception handling.
7095         * python/py-framefilter.c: Use C++ exception handling.
7096         * python/py-frame.c: Use C++ exception handling.
7097         * python/py-finishbreakpoint.c: Use C++ exception handling.
7098         * python/py-cmd.c: Use C++ exception handling.
7099         * python/py-breakpoint.c: Use C++ exception handling.
7100         * python/py-arch.c: Use C++ exception handling.
7101         * printcmd.c: Use C++ exception handling.
7102         * ppc-linux-tdep.c: Use C++ exception handling.
7103         * parse.c: Use C++ exception handling.
7104         * p-valprint.c: Use C++ exception handling.
7105         * objc-lang.c: Use C++ exception handling.
7106         * mi/mi-main.c: Use C++ exception handling.
7107         * mi/mi-interp.c: Use C++ exception handling.
7108         * mi/mi-cmd-stack.c: Use C++ exception handling.
7109         * mi/mi-cmd-break.c: Use C++ exception handling.
7110         * main.c: Use C++ exception handling.
7111         * linux-thread-db.c: Use C++ exception handling.
7112         * linux-tdep.c: Use C++ exception handling.
7113         * linux-nat.c: Use C++ exception handling.
7114         * linux-fork.c: Use C++ exception handling.
7115         * linespec.c: Use C++ exception handling.
7116         * language.c: Use C++ exception handling.
7117         * jit.c: Use C++ exception handling.
7118         * infrun.c: Use C++ exception handling.
7119         * infcmd.c: Use C++ exception handling.
7120         * infcall.c: Use C++ exception handling.
7121         * inf-loop.c: Use C++ exception handling.
7122         * i386-tdep.c: Use C++ exception handling.
7123         * i386-linux-tdep.c: Use C++ exception handling.
7124         * guile/scm-value.c: Use C++ exception handling.
7125         * guile/scm-type.c: Use C++ exception handling.
7126         * guile/scm-symtab.c: Use C++ exception handling.
7127         * guile/scm-symbol.c: Use C++ exception handling.
7128         * guile/scm-pretty-print.c: Use C++ exception handling.
7129         * guile/scm-ports.c: Use C++ exception handling.
7130         * guile/scm-param.c: Use C++ exception handling.
7131         * guile/scm-math.c: Use C++ exception handling.
7132         * guile/scm-lazy-string.c: Use C++ exception handling.
7133         * guile/scm-frame.c: Use C++ exception handling.
7134         * guile/scm-disasm.c: Use C++ exception handling.
7135         * guile/scm-cmd.c: Use C++ exception handling.
7136         * guile/scm-breakpoint.c: Use C++ exception handling.
7137         * guile/scm-block.c: Use C++ exception handling.
7138         * guile/guile-internal.h: Use C++ exception handling.
7139         * gnu-v3-abi.c: Use C++ exception handling.
7140         * gdbtypes.c: Use C++ exception handling.
7141         * frame.c: Use C++ exception handling.
7142         * frame-unwind.c: Use C++ exception handling.
7143         * fbsd-tdep.c: Use C++ exception handling.
7144         * f-valprint.c: Use C++ exception handling.
7145         * exec.c: Use C++ exception handling.
7146         * event-top.c: Use C++ exception handling.
7147         * event-loop.c: Use C++ exception handling.
7148         * eval.c: Use C++ exception handling.
7149         * dwarf2read.c: Use C++ exception handling.
7150         * dwarf2loc.c: Use C++ exception handling.
7151         * dwarf2-frame.c: Use C++ exception handling.
7152         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7153         * dwarf-index-write.c: Use C++ exception handling.
7154         * dwarf-index-cache.c: Use C++ exception handling.
7155         * dtrace-probe.c: Use C++ exception handling.
7156         * disasm-selftests.c: Use C++ exception handling.
7157         * darwin-nat.c: Use C++ exception handling.
7158         * cp-valprint.c: Use C++ exception handling.
7159         * cp-support.c: Use C++ exception handling.
7160         * cp-abi.c: Use C++ exception handling.
7161         * corelow.c: Use C++ exception handling.
7162         * completer.c: Use C++ exception handling.
7163         * compile/compile-object-run.c: Use C++ exception handling.
7164         * compile/compile-object-load.c: Use C++ exception handling.
7165         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7166         * compile/compile-c-symbols.c: Use C++ exception handling.
7167         * common/selftest.c: Use C++ exception handling.
7168         * common/new-op.c: Use C++ exception handling.
7169         * cli/cli-script.c: Use C++ exception handling.
7170         * cli/cli-interp.c: Use C++ exception handling.
7171         * cli/cli-cmds.c: Use C++ exception handling.
7172         * c-varobj.c: Use C++ exception handling.
7173         * btrace.c: Use C++ exception handling.
7174         * breakpoint.c: Use C++ exception handling.
7175         * break-catch-throw.c: Use C++ exception handling.
7176         * arch-utils.c: Use C++ exception handling.
7177         * amd64-tdep.c: Use C++ exception handling.
7178         * ada-valprint.c: Use C++ exception handling.
7179         * ada-typeprint.c: Use C++ exception handling.
7180         * ada-lang.c: Use C++ exception handling.
7181         * aarch64-tdep.c: Use C++ exception handling.
7182
7183 2019-04-08  Tom Tromey  <tom@tromey.com>
7184
7185         * xml-support.c (gdb_xml_parser::parse): Update.
7186         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7187         * value.c (show_convenience): Update.
7188         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7189         (test_parse_flags_qcs): Update.
7190         * thread.c (thr_try_catch_cmd): Update.
7191         * target.c (target_translate_tls_address): Update.
7192         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7193         (info_frame_command_core, frame_apply_command_count): Update.
7194         * rust-exp.y (rust_lex_exception_test): Update.
7195         * riscv-tdep.c (riscv_print_one_register_info): Update.
7196         * remote.c (remote_target::enable_btrace): Update.
7197         * record-btrace.c (record_btrace_enable_warn): Update.
7198         * python/py-utils.c (gdbpy_convert_exception): Update.
7199         * printcmd.c (do_one_display, print_variable_and_value): Update.
7200         * mi/mi-main.c (mi_print_exception): Update.
7201         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7202         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7203         * linux-nat.c (linux_nat_target::attach): Update.
7204         * linux-fork.c (class scoped_switch_fork_info): Update.
7205         * infrun.c (displaced_step_prepare): Update.
7206         * infcall.c (call_function_by_hand_dummy): Update.
7207         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7208         * gnu-v3-abi.c (print_one_vtable): Update.
7209         * frame.c (get_prev_frame_always): Update.
7210         * f-valprint.c (info_common_command_for_block): Update.
7211         * exec.c (try_open_exec_file): Update.
7212         * exceptions.c (print_exception, exception_print)
7213         (exception_fprintf, exception_print_same): Update.
7214         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7215         * dwarf-index-cache.c (index_cache::store)
7216         (index_cache::lookup_gdb_index): Update.
7217         * darwin-nat.c (maybe_cache_shell): Update.
7218         * cp-valprint.c (cp_print_value_fields): Update.
7219         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7220         (gcc_cplus_symbol_address): Update.
7221         * compile/compile-c-symbols.c (gcc_convert_symbol)
7222         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7223         * common/selftest.c: Update.
7224         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7225         a std::string.
7226         (exception_try_scope_entry, exception_try_scope_exit): Don't
7227         declare.
7228         (struct exception_try_scope): Remove.
7229         (TRY): Don't use exception_try_scope.
7230         (struct gdb_exception): Add constructor, operator=.
7231         <what>: New method.
7232         (struct gdb_exception_RETURN_MASK_ALL)
7233         (struct gdb_exception_RETURN_MASK_ERROR)
7234         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7235         (struct gdb_quit_bad_alloc): Update.
7236         * common/common-exceptions.c (exception_none): Change
7237         initializer.
7238         (struct catcher) <state, exception>: Initialize inline.
7239         <prev>: Remove member.
7240         (current_catcher): Remove.
7241         (catchers): New global.
7242         (exceptions_state_mc_init): Simplify.
7243         (catcher_pop): Remove.
7244         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7245         (try_scope_depth, exception_try_scope_entry)
7246         (exception_try_scope_exit): Remove.
7247         (throw_exception_sjlj): Update.
7248         (exception_messages, exception_messages_size): Remove.
7249         (throw_it): Simplify.
7250         (gdb_exception_sliced_copy): Remove.
7251         (throw_exception_cxx): Update.
7252         * cli/cli-script.c (script_from_file): Update.
7253         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7254         Update.
7255         * ada-valprint.c (ada_val_print): Update.
7256         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7257         (create_excep_cond_exprs): Update.
7258
7259 2019-04-08  Tom Tromey  <tom@tromey.com>
7260
7261         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7262         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7263         (TRY, CATCH, END_CATCH): Remove some definitions.
7264         * common/common-exceptions.c: Don't use GDB_XCPT.
7265         (catcher_list_size): Remove.
7266         (throw_exception, throw_it): Simplify.
7267
7268 2019-04-05  Tom Tromey  <tom@tromey.com>
7269
7270         Revert the header-sorting patch.
7271         * ft32-tdep.c: Revert.
7272         * frv-tdep.c: Revert.
7273         * frv-linux-tdep.c: Revert.
7274         * frame.c: Revert.
7275         * frame-unwind.c: Revert.
7276         * frame-base.c: Revert.
7277         * fork-child.c: Revert.
7278         * findvar.c: Revert.
7279         * findcmd.c: Revert.
7280         * filesystem.c: Revert.
7281         * filename-seen-cache.h: Revert.
7282         * filename-seen-cache.c: Revert.
7283         * fbsd-tdep.c: Revert.
7284         * fbsd-nat.h: Revert.
7285         * fbsd-nat.c: Revert.
7286         * f-valprint.c: Revert.
7287         * f-typeprint.c: Revert.
7288         * f-lang.c: Revert.
7289         * extension.h: Revert.
7290         * extension.c: Revert.
7291         * extension-priv.h: Revert.
7292         * expprint.c: Revert.
7293         * exec.h: Revert.
7294         * exec.c: Revert.
7295         * exceptions.c: Revert.
7296         * event-top.c: Revert.
7297         * event-loop.c: Revert.
7298         * eval.c: Revert.
7299         * elfread.c: Revert.
7300         * dwarf2read.h: Revert.
7301         * dwarf2read.c: Revert.
7302         * dwarf2loc.c: Revert.
7303         * dwarf2expr.h: Revert.
7304         * dwarf2expr.c: Revert.
7305         * dwarf2-frame.c: Revert.
7306         * dwarf2-frame-tailcall.c: Revert.
7307         * dwarf-index-write.h: Revert.
7308         * dwarf-index-write.c: Revert.
7309         * dwarf-index-common.c: Revert.
7310         * dwarf-index-cache.h: Revert.
7311         * dwarf-index-cache.c: Revert.
7312         * dummy-frame.c: Revert.
7313         * dtrace-probe.c: Revert.
7314         * disasm.h: Revert.
7315         * disasm.c: Revert.
7316         * disasm-selftests.c: Revert.
7317         * dictionary.c: Revert.
7318         * dicos-tdep.c: Revert.
7319         * demangle.c: Revert.
7320         * dcache.h: Revert.
7321         * dcache.c: Revert.
7322         * darwin-nat.h: Revert.
7323         * darwin-nat.c: Revert.
7324         * darwin-nat-info.c: Revert.
7325         * d-valprint.c: Revert.
7326         * d-namespace.c: Revert.
7327         * d-lang.c: Revert.
7328         * ctf.c: Revert.
7329         * csky-tdep.c: Revert.
7330         * csky-linux-tdep.c: Revert.
7331         * cris-tdep.c: Revert.
7332         * cris-linux-tdep.c: Revert.
7333         * cp-valprint.c: Revert.
7334         * cp-support.c: Revert.
7335         * cp-namespace.c: Revert.
7336         * cp-abi.c: Revert.
7337         * corelow.c: Revert.
7338         * corefile.c: Revert.
7339         * continuations.c: Revert.
7340         * completer.h: Revert.
7341         * completer.c: Revert.
7342         * complaints.c: Revert.
7343         * coffread.c: Revert.
7344         * coff-pe-read.c: Revert.
7345         * cli-out.h: Revert.
7346         * cli-out.c: Revert.
7347         * charset.c: Revert.
7348         * c-varobj.c: Revert.
7349         * c-valprint.c: Revert.
7350         * c-typeprint.c: Revert.
7351         * c-lang.c: Revert.
7352         * buildsym.c: Revert.
7353         * buildsym-legacy.c: Revert.
7354         * build-id.h: Revert.
7355         * build-id.c: Revert.
7356         * btrace.c: Revert.
7357         * bsd-uthread.c: Revert.
7358         * breakpoint.h: Revert.
7359         * breakpoint.c: Revert.
7360         * break-catch-throw.c: Revert.
7361         * break-catch-syscall.c: Revert.
7362         * break-catch-sig.c: Revert.
7363         * blockframe.c: Revert.
7364         * block.c: Revert.
7365         * bfin-tdep.c: Revert.
7366         * bfin-linux-tdep.c: Revert.
7367         * bfd-target.c: Revert.
7368         * bcache.c: Revert.
7369         * ax-general.c: Revert.
7370         * ax-gdb.h: Revert.
7371         * ax-gdb.c: Revert.
7372         * avr-tdep.c: Revert.
7373         * auxv.c: Revert.
7374         * auto-load.c: Revert.
7375         * arm-wince-tdep.c: Revert.
7376         * arm-tdep.c: Revert.
7377         * arm-symbian-tdep.c: Revert.
7378         * arm-pikeos-tdep.c: Revert.
7379         * arm-obsd-tdep.c: Revert.
7380         * arm-nbsd-tdep.c: Revert.
7381         * arm-nbsd-nat.c: Revert.
7382         * arm-linux-tdep.c: Revert.
7383         * arm-linux-nat.c: Revert.
7384         * arm-fbsd-tdep.c: Revert.
7385         * arm-fbsd-nat.c: Revert.
7386         * arm-bsd-tdep.c: Revert.
7387         * arch-utils.c: Revert.
7388         * arc-tdep.c: Revert.
7389         * arc-newlib-tdep.c: Revert.
7390         * annotate.h: Revert.
7391         * annotate.c: Revert.
7392         * amd64-windows-tdep.c: Revert.
7393         * amd64-windows-nat.c: Revert.
7394         * amd64-tdep.c: Revert.
7395         * amd64-sol2-tdep.c: Revert.
7396         * amd64-obsd-tdep.c: Revert.
7397         * amd64-obsd-nat.c: Revert.
7398         * amd64-nbsd-tdep.c: Revert.
7399         * amd64-nbsd-nat.c: Revert.
7400         * amd64-nat.c: Revert.
7401         * amd64-linux-tdep.c: Revert.
7402         * amd64-linux-nat.c: Revert.
7403         * amd64-fbsd-tdep.c: Revert.
7404         * amd64-fbsd-nat.c: Revert.
7405         * amd64-dicos-tdep.c: Revert.
7406         * amd64-darwin-tdep.c: Revert.
7407         * amd64-bsd-nat.c: Revert.
7408         * alpha-tdep.c: Revert.
7409         * alpha-obsd-tdep.c: Revert.
7410         * alpha-nbsd-tdep.c: Revert.
7411         * alpha-mdebug-tdep.c: Revert.
7412         * alpha-linux-tdep.c: Revert.
7413         * alpha-linux-nat.c: Revert.
7414         * alpha-bsd-tdep.c: Revert.
7415         * alpha-bsd-nat.c: Revert.
7416         * aix-thread.c: Revert.
7417         * agent.c: Revert.
7418         * addrmap.c: Revert.
7419         * ada-varobj.c: Revert.
7420         * ada-valprint.c: Revert.
7421         * ada-typeprint.c: Revert.
7422         * ada-tasks.c: Revert.
7423         * ada-lang.c: Revert.
7424         * aarch64-tdep.c: Revert.
7425         * aarch64-ravenscar-thread.c: Revert.
7426         * aarch64-newlib-tdep.c: Revert.
7427         * aarch64-linux-tdep.c: Revert.
7428         * aarch64-linux-nat.c: Revert.
7429         * aarch64-fbsd-tdep.c: Revert.
7430         * aarch64-fbsd-nat.c: Revert.
7431         * aarch32-linux-nat.c: Revert.
7432
7433 2019-04-05  Tom Tromey  <tom@tromey.com>
7434
7435         * ft32-tdep.c: Sort headers.
7436         * frv-tdep.c: Sort headers.
7437         * frv-linux-tdep.c: Sort headers.
7438         * frame.c: Sort headers.
7439         * frame-unwind.c: Sort headers.
7440         * frame-base.c: Sort headers.
7441         * fork-child.c: Sort headers.
7442         * findvar.c: Sort headers.
7443         * findcmd.c: Sort headers.
7444         * filesystem.c: Sort headers.
7445         * filename-seen-cache.h: Sort headers.
7446         * filename-seen-cache.c: Sort headers.
7447         * fbsd-tdep.c: Sort headers.
7448         * fbsd-nat.h: Sort headers.
7449         * fbsd-nat.c: Sort headers.
7450         * f-valprint.c: Sort headers.
7451         * f-typeprint.c: Sort headers.
7452         * f-lang.c: Sort headers.
7453         * extension.h: Sort headers.
7454         * extension.c: Sort headers.
7455         * extension-priv.h: Sort headers.
7456         * expprint.c: Sort headers.
7457         * exec.h: Sort headers.
7458         * exec.c: Sort headers.
7459         * exceptions.c: Sort headers.
7460         * event-top.c: Sort headers.
7461         * event-loop.c: Sort headers.
7462         * eval.c: Sort headers.
7463         * elfread.c: Sort headers.
7464         * dwarf2read.h: Sort headers.
7465         * dwarf2read.c: Sort headers.
7466         * dwarf2loc.c: Sort headers.
7467         * dwarf2expr.h: Sort headers.
7468         * dwarf2expr.c: Sort headers.
7469         * dwarf2-frame.c: Sort headers.
7470         * dwarf2-frame-tailcall.c: Sort headers.
7471         * dwarf-index-write.h: Sort headers.
7472         * dwarf-index-write.c: Sort headers.
7473         * dwarf-index-common.c: Sort headers.
7474         * dwarf-index-cache.h: Sort headers.
7475         * dwarf-index-cache.c: Sort headers.
7476         * dummy-frame.c: Sort headers.
7477         * dtrace-probe.c: Sort headers.
7478         * disasm.h: Sort headers.
7479         * disasm.c: Sort headers.
7480         * disasm-selftests.c: Sort headers.
7481         * dictionary.c: Sort headers.
7482         * dicos-tdep.c: Sort headers.
7483         * demangle.c: Sort headers.
7484         * dcache.h: Sort headers.
7485         * dcache.c: Sort headers.
7486         * darwin-nat.h: Sort headers.
7487         * darwin-nat.c: Sort headers.
7488         * darwin-nat-info.c: Sort headers.
7489         * d-valprint.c: Sort headers.
7490         * d-namespace.c: Sort headers.
7491         * d-lang.c: Sort headers.
7492         * ctf.c: Sort headers.
7493         * csky-tdep.c: Sort headers.
7494         * csky-linux-tdep.c: Sort headers.
7495         * cris-tdep.c: Sort headers.
7496         * cris-linux-tdep.c: Sort headers.
7497         * cp-valprint.c: Sort headers.
7498         * cp-support.c: Sort headers.
7499         * cp-namespace.c: Sort headers.
7500         * cp-abi.c: Sort headers.
7501         * corelow.c: Sort headers.
7502         * corefile.c: Sort headers.
7503         * continuations.c: Sort headers.
7504         * completer.h: Sort headers.
7505         * completer.c: Sort headers.
7506         * complaints.c: Sort headers.
7507         * coffread.c: Sort headers.
7508         * coff-pe-read.c: Sort headers.
7509         * cli-out.h: Sort headers.
7510         * cli-out.c: Sort headers.
7511         * charset.c: Sort headers.
7512         * c-varobj.c: Sort headers.
7513         * c-valprint.c: Sort headers.
7514         * c-typeprint.c: Sort headers.
7515         * c-lang.c: Sort headers.
7516         * buildsym.c: Sort headers.
7517         * buildsym-legacy.c: Sort headers.
7518         * build-id.h: Sort headers.
7519         * build-id.c: Sort headers.
7520         * btrace.c: Sort headers.
7521         * bsd-uthread.c: Sort headers.
7522         * breakpoint.h: Sort headers.
7523         * breakpoint.c: Sort headers.
7524         * break-catch-throw.c: Sort headers.
7525         * break-catch-syscall.c: Sort headers.
7526         * break-catch-sig.c: Sort headers.
7527         * blockframe.c: Sort headers.
7528         * block.c: Sort headers.
7529         * bfin-tdep.c: Sort headers.
7530         * bfin-linux-tdep.c: Sort headers.
7531         * bfd-target.c: Sort headers.
7532         * bcache.c: Sort headers.
7533         * ax-general.c: Sort headers.
7534         * ax-gdb.h: Sort headers.
7535         * ax-gdb.c: Sort headers.
7536         * avr-tdep.c: Sort headers.
7537         * auxv.c: Sort headers.
7538         * auto-load.c: Sort headers.
7539         * arm-wince-tdep.c: Sort headers.
7540         * arm-tdep.c: Sort headers.
7541         * arm-symbian-tdep.c: Sort headers.
7542         * arm-pikeos-tdep.c: Sort headers.
7543         * arm-obsd-tdep.c: Sort headers.
7544         * arm-nbsd-tdep.c: Sort headers.
7545         * arm-nbsd-nat.c: Sort headers.
7546         * arm-linux-tdep.c: Sort headers.
7547         * arm-linux-nat.c: Sort headers.
7548         * arm-fbsd-tdep.c: Sort headers.
7549         * arm-fbsd-nat.c: Sort headers.
7550         * arm-bsd-tdep.c: Sort headers.
7551         * arch-utils.c: Sort headers.
7552         * arc-tdep.c: Sort headers.
7553         * arc-newlib-tdep.c: Sort headers.
7554         * annotate.h: Sort headers.
7555         * annotate.c: Sort headers.
7556         * amd64-windows-tdep.c: Sort headers.
7557         * amd64-windows-nat.c: Sort headers.
7558         * amd64-tdep.c: Sort headers.
7559         * amd64-sol2-tdep.c: Sort headers.
7560         * amd64-obsd-tdep.c: Sort headers.
7561         * amd64-obsd-nat.c: Sort headers.
7562         * amd64-nbsd-tdep.c: Sort headers.
7563         * amd64-nbsd-nat.c: Sort headers.
7564         * amd64-nat.c: Sort headers.
7565         * amd64-linux-tdep.c: Sort headers.
7566         * amd64-linux-nat.c: Sort headers.
7567         * amd64-fbsd-tdep.c: Sort headers.
7568         * amd64-fbsd-nat.c: Sort headers.
7569         * amd64-dicos-tdep.c: Sort headers.
7570         * amd64-darwin-tdep.c: Sort headers.
7571         * amd64-bsd-nat.c: Sort headers.
7572         * alpha-tdep.c: Sort headers.
7573         * alpha-obsd-tdep.c: Sort headers.
7574         * alpha-nbsd-tdep.c: Sort headers.
7575         * alpha-mdebug-tdep.c: Sort headers.
7576         * alpha-linux-tdep.c: Sort headers.
7577         * alpha-linux-nat.c: Sort headers.
7578         * alpha-bsd-tdep.c: Sort headers.
7579         * alpha-bsd-nat.c: Sort headers.
7580         * aix-thread.c: Sort headers.
7581         * agent.c: Sort headers.
7582         * addrmap.c: Sort headers.
7583         * ada-varobj.c: Sort headers.
7584         * ada-valprint.c: Sort headers.
7585         * ada-typeprint.c: Sort headers.
7586         * ada-tasks.c: Sort headers.
7587         * ada-lang.c: Sort headers.
7588         * aarch64-tdep.c: Sort headers.
7589         * aarch64-ravenscar-thread.c: Sort headers.
7590         * aarch64-newlib-tdep.c: Sort headers.
7591         * aarch64-linux-tdep.c: Sort headers.
7592         * aarch64-linux-nat.c: Sort headers.
7593         * aarch64-fbsd-tdep.c: Sort headers.
7594         * aarch64-fbsd-nat.c: Sort headers.
7595         * aarch32-linux-nat.c: Sort headers.
7596
7597 2019-04-04  Tom Tromey  <tom@tromey.com>
7598
7599         * varobj.c (varobj_create): Update.
7600         * rust-exp.y (struct rust_parser) <update_innermost_block,
7601         lookup_symbol>: New methods.
7602         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7603         Rename.
7604         (rust_parser::rust_lookup_type)
7605         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7606         * printcmd.c (display_command, do_one_display): Update.
7607         * parser-defs.h (struct parser_state) <parser_state>: Add
7608         "tracker" parameter.
7609         (block_tracker): New member.
7610         (class innermost_block_tracker) <innermost_block_tracker>: Add
7611         "types" parameter.
7612         <reset>: Remove method.
7613         (innermost_block): Don't declare.
7614         (null_post_parser): Update.
7615         * parse.c (innermost_block): Remove global.
7616         (write_dollar_variable): Update.
7617         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7618         Remove "tracker_types" parameter.
7619         (parse_expression): Add "tracker" parameter.
7620         (parse_expression_for_completion): Update.
7621         (null_post_parser): Add "tracker" parameter.
7622         * p-exp.y: Update rules.
7623         * m2-exp.y: Update rules.
7624         * language.h (struct language_defn) <la_post_parser>: Add
7625         "tracker" parameter.
7626         * go-exp.y: Update rules.
7627         * f-exp.y: Update rules.
7628         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7629         parameter.
7630         * d-exp.y: Update rules.
7631         * c-exp.y: Update rules.
7632         * breakpoint.c (set_breakpoint_condition): Create an
7633         innermost_block_tracker.
7634         (watch_command_1): Likewise.
7635         * ada-lang.c (resolve): Add "tracker" parameter.
7636         (resolve_subexp): Likewise.
7637         * ada-exp.y (write_var_from_sym): Update.
7638
7639 2019-04-04  Tom Tromey  <tom@tromey.com>
7640
7641         * type-stack.h: New file.
7642         * type-stack.c: New file.
7643         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7644         type-stack.h.
7645         (insert_into_type_stack, insert_type, push_type, push_type_int)
7646         (insert_type_address_space, pop_type, pop_type_int)
7647         (pop_typelist, pop_type_stack, append_type_stack)
7648         (push_type_stack, get_type_stack, push_typelist)
7649         (follow_type_instance_flags, follow_types): Don't declare.
7650         * parse.c (type_stack): Remove global.
7651         (parse_exp_in_context): Update.
7652         (insert_into_type_stack, insert_type, push_type, push_type_int)
7653         (insert_type_address_space, pop_type, pop_type_int)
7654         (pop_typelist, pop_type_stack, append_type_stack)
7655         (push_type_stack, get_type_stack, push_typelist)
7656         (follow_type_instance_flags, follow_types): Remove (moved to
7657         type-stack.c).
7658         * f-exp.y (type_stack): New global.
7659         Update rules.
7660         (push_kind_type, f_parse): Update.
7661         * d-exp.y (type_stack): New global.
7662         Update rules.
7663         (d_parse): Update.
7664         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7665         Update rules.
7666         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7667         (HFILES_NO_SRCDIR): Add type-stack.h.
7668
7669 2019-04-04  Tom Tromey  <tom@tromey.com>
7670
7671         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7672         (rust_parser::convert_ast_to_expression, rust_parse)
7673         (rust_lex_test_completion, rust_lex_tests): Update.
7674         * parser-defs.h (struct expr_completion_state): New.
7675         (struct parser_state) <parser_state>: Add completion parameter.
7676         <mark_struct_expression, mark_completion_tag>: New methods.
7677         <parse_completion, m_completion_state>: New members.
7678         (prefixify_expression, null_post_parser): Update.
7679         (mark_struct_expression, mark_completion_tag): Don't declare.
7680         * parse.c (parse_completion, expout_last_struct)
7681         (expout_tag_completion_type, expout_completion_name): Remove
7682         globals.
7683         (parser_state::mark_struct_expression)
7684         (parser_state::mark_completion_tag): Now methods.
7685         (prefixify_expression): Add last_struct parameter.
7686         (prefixify_subexp): Likewise.
7687         (parse_exp_1): Update.
7688         (parse_exp_in_context): Add cstate parameter.  Update.
7689         (parse_expression_for_completion): Create an
7690         expr_completion_state.
7691         (null_post_parser): Add "completion" parameter.
7692         * p-exp.y: Update rules.
7693         (yylex): Update.
7694         * language.h (struct language_defn) <la_post_parser>: Add
7695         "completing" parameter.
7696         * go-exp.y: Update rules.
7697         (lex_one_token): Update.
7698         * expression.h (parse_completion): Don't declare.
7699         * d-exp.y: Update rules.
7700         (lex_one_token): Update rules.
7701         * c-exp.y: Update rules.
7702         (lex_one_token): Update.
7703         * ada-lang.c (resolve): Add "parse_completion" parameter.
7704         (resolve_subexp): Likewise.
7705         (ada_resolve_function): Likewise.
7706
7707 2019-04-04  Tom Tromey  <tom@tromey.com>
7708
7709         * parser-defs.h (struct parser_state) <start_arglist,
7710         end_arglist>: New methods.
7711         <arglist_len, m_funcall_chain>: New members.
7712         (arglist_len, start_arglist, end_arglist): Don't declare.
7713         * parse.c (arglist_len, funcall_chain): Remove global.
7714         (start_arglist, end_arglist): Remove functions.
7715         (parse_exp_in_context): Update.
7716         * p-exp.y: Update rules.
7717         * m2-exp.y: Update rules.
7718         * go-exp.y: Update rules.
7719         * f-exp.y: Update rules.
7720         * d-exp.y: Update rules.
7721         * c-exp.y: Update rules.
7722
7723 2019-04-04  Tom Tromey  <tom@tromey.com>
7724
7725         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7726         lex_operator, push_back>: New methods.
7727         Update all rules.
7728         (rust_parser::lex_hex, lex_escape): Rename and update.
7729         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7730         (rust_parser::lex_operator): Rename and update.
7731         (rust_parser::lex_number, rustyylex, rustyyerror)
7732         (rust_lex_test_init, rust_lex_test_sequence)
7733         (rust_lex_test_push_back, rust_lex_tests): Update.
7734         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7735         parameter.
7736         <lexptr, prev_lexptr>: New members.
7737         (lexptr, prev_lexptr): Don't declare.
7738         * parse.c (lexptr, prev_lexptr): Remove globals.
7739         (parse_exp_in_context): Update.
7740         * p-exp.y (yylex, yyerror): Update.
7741         * m2-exp.y (parse_number, yylex, yyerror): Update.
7742         * go-exp.y (lex_one_token, yyerror): Update.
7743         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7744         * d-exp.y (lex_one_token, yyerror): Update.
7745         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7746         (lex_one_token, yyerror): Update.
7747         * ada-lex.l (YY_INPUT): Update.
7748         (rewind_to_char): Update.
7749         * ada-exp.y (yyerror): Update.
7750
7751 2019-04-04  Tom Tromey  <tom@tromey.com>
7752
7753         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7754         * parser-defs.h (struct parser_state) <parser_state>: Add new
7755         parameter.
7756         <comma_terminates>: New member.
7757         (comma_terminates): Don't declare global.
7758         * parse.c (comma_terminates): Remove global.
7759         (parse_exp_in_context): Update.
7760         * p-exp.y (yylex): Update.
7761         * m2-exp.y (yylex): Update.
7762         * go-exp.y (lex_one_token): Update.
7763         * f-exp.y (yylex): Update.
7764         * d-exp.y (lex_one_token): Update.
7765         * c-exp.y (lex_one_token): Update.
7766         * ada-lex.l: Update.
7767
7768 2019-04-04  Tom Tromey  <tom@tromey.com>
7769
7770         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7771         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7772         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7773         * parser-defs.h (paren_depth): Don't declare.
7774         * parse.c (paren_depth): Remove global.
7775         (parse_exp_in_context): Update.
7776         * p-exp.y (paren_depth): New global.
7777         (pascal_parse): Initialize it.
7778         * m2-exp.y (paren_depth): New global.
7779         (m2_parse): Initialize it.
7780         * go-exp.y (paren_depth): New global.
7781         (go_parse): Initialize it.
7782         * f-exp.y (paren_depth): New global.
7783         (f_parse): Initialize it.
7784         * d-exp.y (paren_depth): New global.
7785         (d_parse): Initialize it.
7786         * c-exp.y (paren_depth): New global.
7787         (c_parse): Initialize it.
7788         * ada-lex.l (paren_depth): New global.
7789         (lexer_init): Initialize it.
7790
7791 2019-04-04  Tom Tromey  <tom@tromey.com>
7792
7793         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7794         (rust_parser::convert_ast_to_type)
7795         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7796         * parser-defs.h (struct parser_state) <parser_state>: Add
7797         parameters.  Initialize new members.
7798         <expression_context_block, expression_context_pc>: New members.
7799         * parse.c (expression_context_block, expression_context_pc):
7800         Remove globals.
7801         (parse_exp_in_context): Update.
7802         * p-exp.y: Update all rules.
7803         (yylex): Update.
7804         * m2-exp.y: Update all rules.
7805         (yylex): Update.
7806         * go-exp.y (yylex): Update.
7807         * f-exp.y (yylex): Update.
7808         * d-exp.y: Update all rules.
7809         (yylex): Update.
7810         * c-exp.y: Update all rules.
7811         (lex_one_token, classify_name, yylex, c_parse): Update.
7812         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7813
7814 2019-04-04  Tom Tromey  <tom@tromey.com>
7815
7816         * gdbarch.h, gdbarch.c: Rebuild.
7817         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7818         * stap-probe.h:
7819         (struct stap_parse_info): Replace "parser_state" with
7820         "expr_builder".
7821         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7822         (parser_state): New class.
7823         * parse.c (expr_builder): Rename.
7824         (expr_builder::release): Rename.
7825         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7826         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7827         (write_exp_elt_longcst, write_exp_elt_floatcst)
7828         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7829         (write_exp_string_vector, write_exp_bitstring)
7830         (write_exp_msymbol, mark_struct_expression)
7831         (write_dollar_variable)
7832         (insert_type_address_space, increase_expout_size): Replace
7833         "parser_state" with "expr_builder".
7834         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7835         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7836         "parser_state" with "expr_builder".
7837
7838 2019-04-04  Tom Tromey  <tom@tromey.com>
7839
7840         * rust-exp.y: Replace "parse_language" with method call.
7841         * p-exp.y:
7842         (yylex): Replace "parse_language" with method call.
7843         * m2-exp.y:
7844         (yylex): Replace "parse_language" with method call.
7845         * go-exp.y (classify_name): Replace "parse_language" with method
7846         call.
7847         * f-exp.y (yylex): Replace "parse_language" with method call.
7848         * d-exp.y (lex_one_token): Replace "parse_language" with method
7849         call.
7850         * c-exp.y:
7851         (lex_one_token, classify_name, yylex): Replace "parse_language"
7852         with method call.
7853         * ada-exp.y (find_primitive_type, type_char)
7854         (type_system_address): Replace "parse_language" with method call.
7855
7856 2019-04-04  Tom Tromey  <tom@tromey.com>
7857
7858         * rust-exp.y: Replace "parse_gdbarch" with method call.
7859         * parse.c (write_dollar_variable, insert_type_address_space):
7860         Replace "parse_gdbarch" with method call.
7861         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7862         call.
7863         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7864         call.
7865         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7866         "parse_gdbarch" with method call.
7867         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7868         with method call.
7869         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7870         "parse_gdbarch" with method call.
7871         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7872         "parse_gdbarch" with method call.
7873         * c-exp.y (parse_type, parse_number, classify_name): Replace
7874         "parse_gdbarch" with method call.
7875         * ada-lex.l: Replace "parse_gdbarch" with method call.
7876         * ada-exp.y (parse_type, find_primitive_type, type_char)
7877         (type_system_address): Replace "parse_gdbarch" with method call.
7878
7879 2019-04-04  Tom Tromey  <tom@tromey.com>
7880
7881         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7882         * stap-probe.c (stap_parse_argument): Update.
7883         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7884         initial_size parameter.
7885         * rust-exp.y (rust_lex_tests): Update.
7886         * parse.c (parser_state): Update.
7887         (parse_exp_in_context): Update.
7888         * parser-defs.h (struct parser_state) <parser_state>: Remove
7889         "initial_size" parameter.
7890
7891 2019-04-04  Tom Tromey  <tom@tromey.com>
7892
7893         * parser-defs.h (increase_expout_size): Don't declare.
7894         * parse.c (increase_expout_size): Now static.
7895
7896 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7897
7898         * gnu-nat.c (gnu_nat_target::wait): Fix
7899         target_waitstatus_to_string call.
7900
7901 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7902
7903         * eval.c (evaluate_subexp_standard): Handle internal functions
7904         during Fortran function call handling.
7905
7906 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7907
7908         * NEWS: Mention new internal functions.
7909         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7910         (read_base_type): Use dwarf2_init_complex_target_type.
7911         * value.c (creal_internal_fn): New function.
7912         (cimag_internal_fn): New function.
7913         (_initialize_values): Register new internal functions.
7914
7915 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7916
7917         * infrun.c (stop_all_threads): If debug_infrun, always
7918         trace the wait status after wait_one, using
7919         target_waitstatus_to_string and target_pid_to_str.
7920         (handle_inferior_event): Replace various trace of
7921         wait status kind by a single trace.
7922         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7923         wait status kind image by target_waitstatus_to_string.
7924         * target/waitstatus.c (target_waitstatus_to_string): Fix
7925         obsolete comment.
7926
7927 2019-04-01  Tom Tromey  <tromey@adacore.com>
7928
7929         PR symtab/23331:
7930         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7931
7932 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7933             Pedro Alves  <palves@redhat.com>
7934
7935         * top.c (quit_force): Call 'finalize_values'.
7936         * value.c (finalize_values): New function.
7937         * value.h (finalize_values): Declare.
7938
7939 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7940
7941         * NEWS: Announce $_gdb_major and $_gdb_minor.
7942
7943         * top.c (init_gdb_version_vars): New function.
7944         (gdb_init): Call init_gdb_version_vars.
7945
7946 2019-03-29  Tom Tromey  <tromey@adacore.com>
7947
7948         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7949         help text.  Remove dead code.
7950
7951 2019-03-29  Keith Seitz  <keiths@redhat.com>
7952
7953         From Siddhesh Poyarekar:
7954         * f-lang.h (f77_get_upperbound): Return LONGEST.
7955         (f77_get_lowerbound): Likewise.
7956         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7957         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7958         print them.
7959         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7960         plongest to format print it.
7961         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7962         (f77_get_upperbound): Likewise.
7963         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7964         LOWER_BOUND to LONGEST.
7965         (f77_create_arrayprint_offset_tbl): Likewise.
7966
7967 2019-03-29  Keith Seitz  <keiths@redhat.com>
7968
7969         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7970         %s/pulongest for TYPE_LENGTH instead of %d in format
7971         strings.
7972         * ada-typerint.c (ada_print_type): Likewise.
7973         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7974         * compile/compile-c-support.c (generate_register_struct): Likewise.
7975         * gdbtypes.c (recursive_dump_type): Likewise.
7976         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7977         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7978         instead of %d in format strings.
7979         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7980         to std::min to ULONGEST.
7981         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7982         instead of %d in format strings.
7983         * tracepoint.c (info_scope_command): Likewise.
7984         * typeprint.c (print_offset_data::update)
7985         (print_offset_data::finish): Likewise.
7986         * xtensa-tdep.c (xtensa_store_return_value)
7987         (xtensa_push_dummy_call): Likewise.
7988
7989 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7990
7991         * windows-nat.c (display_selector): Fixed format specifications
7992         for 64-bit Cygwin.
7993
7994 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7995
7996         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7997
7998 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7999
8000         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8001         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8002         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8003         (nios2_linux_init_abi): Install it.
8004
8005 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8006
8007         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8008
8009 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8010
8011         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8012
8013 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8014             Tom Tromey  <tromey@adacore.com>
8015
8016         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8017
8018 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8019
8020         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8021         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8022         method to compute the bounds of range types. Also print "[evaluated]"
8023         if the bounds' values come from a dynamic evaluation.
8024
8025 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8026
8027         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8028         whitespace when pretty printing is on.
8029
8030 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8031
8032         * ppc-linux-nat.c: Add include.
8033
8034 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8035
8036         * NEWS: Mention AArch64 Pointer Authentication.
8037
8038 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8039
8040         * arm-linux-nat.c: Add include.
8041
8042 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8043
8044         * source-cache.c (source_cache::get_source_lines): Re-read
8045         fullname after calling open_source_file.
8046
8047 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8048
8049         * NEWS: Mention TLS support for FreeBSD.
8050
8051 2019-03-25  Tom Tromey  <tromey@adacore.com>
8052
8053         * minsyms.c (BUNCH_SIZE): Update comment.
8054         (~minimal_symbol_reader): Remove old comment.
8055         (compact_minimal_symbols): Update comment.
8056         (minimal_symbol_reader::install): Remove old comment.  Update
8057         other comments.
8058
8059 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8060
8061         * s390-linux-nat.c: Add include.
8062
8063 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8064
8065         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8066         Call linux_get_hwcap.
8067         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8068         Likewise.
8069         (aarch64_linux_get_hwcap): Remove function.
8070         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8071         declaration.
8072         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8073         linux_get_hwcap.
8074         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8075         * linux-tdep.c (linux_get_hwcap): Add function.
8076         (linux_get_hwcap2): Likewise.
8077         * linux-tdep.h (linux_get_hwcap): Add declaration.
8078         (linux_get_hwcap2): Likewise.
8079         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8080         (ppc_linux_get_hwcap2): Likewise.
8081         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8082         linux_get_hwcap.
8083         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8084         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8085         (ppc_linux_nat_target::read_description): Likewise.
8086         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8087         * s390-linux-nat.c: Likewise.
8088         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8089
8090 2019-03-24  Tom Tromey  <tom@tromey.com>
8091
8092         * ada-lang.c (standard_lookup): Simplify initialization.
8093         (ada_lookup_symbol_nonlocal): Simplify return.
8094         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8095         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8096         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8097         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8098         initialization.
8099         * solib.c (solib_global_lookup): Simplify.
8100         * symtab.c (null_block_symbol): Remove.
8101         (symbol_cache_lookup): Simplify returns.
8102         (lookup_language_this): Simplify returns.
8103         (lookup_symbol_aux): Simplify return.
8104         (lookup_local_symbol): Simplify returns.
8105         (lookup_global_symbol_from_objfile): Simplify return.
8106         (lookup_symbol_in_objfile_symtabs)
8107         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8108         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8109         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8110         * cp-namespace.c (cp_lookup_bare_symbol)
8111         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8112         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8113         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8114         (cp_lookup_symbol_via_imports): Simplify initialization.
8115         (find_symbol_in_baseclass): Likewise.
8116         * symtab.h (null_block_symbol): Remove.
8117         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8118         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8119         (d_lookup_symbol_module): Likewise.
8120         (find_symbol_in_baseclass): Simplify initialization.
8121
8122 2019-03-24  Tom Tromey  <tom@tromey.com>
8123
8124         * expression.h: Don't include symtab.h.
8125         (struct block): Forward declare.
8126
8127 2019-03-24  Tom Tromey  <tom@tromey.com>
8128
8129         * c-exp.y (typebase): Remove casts.
8130         * gdbtypes.c (lookup_unsigned_typename, )
8131         (lookup_signed_typename): Remove cast.
8132         * eval.c (parse_to_comma_and_eval): Remove cast.
8133         * parse.c (write_dollar_variable): Remove cast.
8134         * block.h (struct block) <superblock>: Now const.
8135         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8136         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8137         (map_block): Make "block" const.
8138         * symfile.h (struct quick_symbol_functions)
8139         <map_matching_symbols>: Constify block argument to "callback".
8140         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8141         const.
8142         (find_pc_sect_compunit_symtab): Make "b" const.
8143         (find_symbol_at_address): Likewise.
8144         (search_symbols): Likewise.
8145         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8146         (dw2_debug_names_lookup_symbol): Likewise.
8147         (dw2_map_matching_symbols): Update.
8148         * p-valprint.c (pascal_val_print): Remove "block".
8149         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8150         (aux_add_nonlocal_symbols): Make "block" const.
8151         (resolve_subexp): Remove cast.
8152         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8153         const.
8154         (iterate_over_file_blocks): Likewise.
8155         * f-exp.y (%union) <bval>: Remove.
8156         * coffread.c (patch_opaque_types): Make "b" const.
8157         * spu-tdep.c (spu_catch_start): Make "block" const.
8158         * c-valprint.c (print_unpacked_pointer): Remove "block".
8159         * symmisc.c (dump_symtab_1): Make "b" const.
8160         (block_depth): Make "block" const.
8161         * d-exp.y (%union) <bval>: Remove.
8162         * cp-support.h (cp_lookup_rtti_type): Update.
8163         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8164         * psymtab.c (psym_lookup_symbol): Make "block" const.
8165         (maintenance_check_psymtabs): Make "b" const.
8166         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8167         (enumerate_locals, enumerate_args): Update.
8168         * python/py-symtab.c (stpy_global_block): Make "block" const.
8169         (stpy_static_block): Likewise.
8170         * inline-frame.c (block_starting_point_at): Make "new_block"
8171         const.
8172         * block.c (find_block_in_blockvector): Make return type const.
8173         (blockvector_for_pc_sect): Make "b" const.
8174         (find_block_in_blockvector): Make "b" const.
8175
8176 2019-03-23  Tom Tromey  <tom@tromey.com>
8177
8178         * varobj.c (varobj_create): Update.
8179         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8180         * printcmd.c (display_command, do_one_display): Don't reset
8181         innermost_block.
8182         * parser-defs.h (enum innermost_block_tracker_type): Move to
8183         expression.h.
8184         (innermost_block): Update comment.
8185         * parse.c (parse_exp_1): Add tracker_types parameter.
8186         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8187         tracker_types parameter.  Reset innermost_block.
8188         (parse_exp_in_context): Remove.
8189         (parse_expression_for_completion): Update.
8190         * objfiles.c (~objfile): Don't reset expression_context_block or
8191         innermost_block.
8192         * expression.h (enum innermost_block_tracker_type): Move from
8193         parser-defs.h.
8194         (parse_exp_1): Add tracker_types parameter.
8195         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8196         reset innermost_block.
8197
8198 2019-03-23  Tom Tromey  <tom@tromey.com>
8199
8200         * objfiles.h: Include bcache.h.
8201
8202 2019-03-23  Tom Tromey  <tom@tromey.com>
8203
8204         * linespec.c (get_current_search_block): Use
8205         scoped_restore_current_language.
8206         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8207
8208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8209             Jiong Wang  <jiong.wang@arm.com>
8210
8211         * aarch64-linux-tdep.c
8212         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8213         section.
8214         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8215
8216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8217             Jiong Wang  <jiong.wang@arm.com>
8218
8219         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8220         instructions.
8221         (aarch64_analyze_prologue_test): Add PACIASP test.
8222         (aarch64_prologue_prev_register): Unmask PC value.
8223
8224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8225             Jiong Wang  <jiong.wang@arm.com>
8226
8227         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8228         (aarch64_dwarf2_prev_register): Unmask PC value.
8229         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8230         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8231         DW_CFA_AARCH64_negate_ra_state.
8232         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8233
8234 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8235             Jiong Wang  <jiong.wang@arm.com>
8236
8237         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8238         registers.
8239         (aarch64_pseudo_register_name): Likewise.
8240         (aarch64_pseudo_register_type): Likewise.
8241         (aarch64_pseudo_register_reggroup_p): Likewise.
8242         (aarch64_gdbarch_init): Add pauth registers.
8243         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8244         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8245         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8246         (struct gdbarch_tdep): Add regnum for ra_state.
8247
8248 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8249             Jiong Wang  <jiong.wang@arm.com>
8250
8251         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8252
8253 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8254             Jiong Wang  <jiong.wang@arm.com>
8255
8256         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8257         function.
8258         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8259         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8260         (aarch64_gdbarch_init): Add puth registers.
8261         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8262         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8263         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8264
8265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8266             Jiong Wang  <jiong.wang@arm.com>
8267
8268         * aarch64-linux-nat.c
8269         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8270         * aarch64-linux-tdep.c
8271         (aarch64_linux_core_read_description): Likewise.
8272         (aarch64_linux_get_hwcap): New function.
8273         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8274         (aarch64_linux_get_hwcap): New declaration.
8275
8276 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8277             Jiong Wang  <jiong.wang@arm.com>
8278
8279         * aarch64-linux-nat.c
8280         (aarch64_linux_nat_target::read_description): Add pauth param.
8281         * aarch64-linux-tdep.c
8282         (aarch64_linux_core_read_description): Likewise.
8283         * aarch64-tdep.c (struct target_desc): Add in pauth.
8284         (aarch64_read_description): Add pauth param.
8285         (aarch64_gdbarch_init): Likewise.
8286         * aarch64-tdep.h (aarch64_read_description): Likewise.
8287         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8288         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8289         * features/Makefile: Add new files.
8290         * features/aarch64-pauth.c: New file.
8291         * features/aarch64-pauth.xml: New file.
8292
8293 2019-03-20  Tom Tromey  <tromey@adacore.com>
8294
8295         * infrun.c (handle_inferior_event): Rename from
8296         handle_inferior_event_1.  Create a scoped_value_mark.
8297         (handle_inferior_event): Remove.
8298
8299 2019-03-19  Tom Tromey  <tromey@adacore.com>
8300
8301         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8302         * infrun.h (print_stop_event): Add "displays" parameter.
8303         * infrun.c (print_stop_event): Add "displays" parameter.
8304
8305 2019-03-19  Pedro Alves  <palves@redhat.com>
8306
8307         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8308         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8309         to -1.  Fix TABs vs spaces.
8310         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8311         * tui/tui-out.h (tui_ui_out) Add intro comments.
8312         <m_line, m_start_of_line>: In-class initialize, and add describing
8313         comment.
8314
8315 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8316
8317         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8318         variable names.
8319         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8320
8321 2019-03-18  Pedro Alves  <palves@redhat.com>
8322             Eli Zaretskii <eliz@gnu.org>
8323
8324         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8325         m_line and m_start_of_line.
8326
8327 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8328
8329         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8330         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8331         it returns a newline.  This fixes a regression in TU mode, whereby
8332         the next line is output on the same screen line as the user input.
8333
8334 2019-03-18  Tom Tromey  <tromey@adacore.com>
8335
8336         * minsyms.c (minimal_symbol_reader::install): Remove call to
8337         obstack_blank.
8338
8339 2019-03-18  Pedro Alves  <palves@redhat.com>
8340
8341         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8342         New globals.
8343         (apply_style): New, factored out from ...
8344         (apply_ansi_escape): ... this.  Handle reverse video mode.
8345         (tui_set_reverse_mode): New function.
8346         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8347         * tui/tui-winsource.c (tui_show_source_line): Use
8348         tui_set_reverse_mode instead of setting A_STANDOUT.
8349         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8350         New setter methods.
8351
8352 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8353
8354         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8355         Handle tabs.
8356
8357 2019-03-18  Tom Tromey  <tromey@adacore.com>
8358
8359         * ada-lang.c (empty_array): Add "high" parameter.
8360         (ada_evaluate_subexp): Update.
8361
8362 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8363
8364         * unittests/string_view-selftests.c: Define
8365         _initialize_string_view_selftests unconditionally.
8366
8367 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8368
8369         PR gdb/24350
8370         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8371
8372 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8373
8374         PR gdb/24351
8375         * windows-nat.c (display_selector): Fix format specifiers.
8376
8377 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8378
8379         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8380         tui_refill_source_window instead of tui_refresh_win, to update the
8381         current execution line.  This fixes redisplay of the current line
8382         when stepping through the code with "next" or "step".
8383
8384 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8385
8386         * source-cache.c (source_cache::get_source_lines): Call
8387         find_source_lines to initialize s->nlines.  This fixes vertical
8388         scrolling of TUI source window when the DOWN arrow is pressed.
8389
8390 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8391
8392         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8393         linux-thread-db.c (_initialize_thread_db): Likewise.
8394
8395 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8396
8397         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8398         wclrtoeol in tui_show_source_line".  This reverts changes made in
8399         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8400
8401 2019-03-15  Tom Tromey  <tom@tromey.com>
8402
8403         * symtab.h (struct minimal_symbol): Derive from
8404         general_symbol_info.
8405         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8406         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8407         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8408         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8409         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8410         (MSYMBOL_SEARCH_NAME): Update.
8411         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8412         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8413         * minsyms.c (minimal_symbol_reader::record_full): Update.
8414
8415 2019-03-15  Tom Tromey  <tom@tromey.com>
8416
8417         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8418
8419 2019-03-15  Tom Tromey  <tom@tromey.com>
8420
8421         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8422         unique_xmalloc_ptr.
8423         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8424         Update.
8425         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8426         (build_minimal_symbol_hash_tables)
8427         (minimal_symbol_reader::install): Update.
8428
8429 2019-03-15  Tom Tromey  <tom@tromey.com>
8430
8431         * symtab.c (create_demangled_names_hash): Update.
8432         (symbol_set_names): Update.
8433         * objfiles.h (struct objfile_per_bfd_storage)
8434         <demangled_names_hash>: Now an htab_up.
8435         * objfiles.c (objfile_per_bfd_storage): Simplify.
8436
8437 2019-03-15  Tom Tromey  <tom@tromey.com>
8438
8439         * objfiles.h (struct objfile_per_bfd_storage): Declare
8440         destructor.
8441         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8442         New.
8443         (get_objfile_bfd_data): Use new.  Don't initialize
8444         language_of_main.
8445         (free_objfile_per_bfd_storage): Remove.
8446         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8447
8448 2019-03-15  Tom Tromey  <tom@tromey.com>
8449
8450         * symfile.c (reread_symbols): Update.
8451         * objfiles.c (objfile::objfile): Update.
8452         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8453         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8454         comment.
8455         (minimal_symbol_reader::install): Update.
8456         (terminate_minimal_symbol_table): Remove.
8457         * jit.c (jit_object_close_impl): Update.
8458
8459 2019-03-15  Tom Tromey  <tom@tromey.com>
8460
8461         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8462         initializations.
8463
8464 2019-03-15  Tom Tromey  <tom@tromey.com>
8465
8466         * objfiles.h (struct objfile_per_bfd_storage)
8467         <demangled_hash_languages>: Now a bitset.
8468         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8469         (lookup_minimal_symbol): Update.
8470
8471 2019-03-15  Tom Tromey  <tom@tromey.com>
8472
8473         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8474         Don't return the symbol.
8475         * coffread.c (record_minimal_symbol): Use record_full.
8476
8477 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8478
8479         The MS-Windows port of ncurses fails to switch to a color pair if
8480         one or both of the colors are the implicit default colors.  This
8481         change records the default colors when TUI is initialized, and
8482         then specifies them explicitly when a color pair uses the default
8483         colors.  This allows color styling in TUI mode on MS-Windows.
8484
8485         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8486         ncurses_norm_attr.
8487         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8488         colors in ncurses_norm_attr.
8489         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8490         "none", replace it with the default color recorded in
8491         ncurses_norm_attr.
8492
8493 2019-03-14  Tom Tromey  <tromey@adacore.com>
8494
8495         * source-cache.h (class source_cache) <get_source_lines>: Return
8496         std::string.
8497         * source-cache.c (source_cache::extract_lines): Handle case where
8498         first_pos==npos.  Return std::string.
8499         (source_cache::get_source_lines): Update.
8500
8501 2019-03-14  Tom Tromey  <tromey@adacore.com>
8502
8503         * NEWS: Add item for "style sources" commands.
8504         * source-cache.c (source_cache::get_source_lines): Check
8505         source_styling.
8506         * cli/cli-style.c (source_styling): New global.
8507         (_initialize_cli_style): Add "style sources" commands.
8508         (show_style_sources): New function.
8509         * cli/cli-style.h (source_styling): Declare.
8510
8511 2019-03-14  Pedro Alves  <palves@redhat.com>
8512             Tom Tromey  <tromey@adacore.com>
8513
8514         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8515         * tui/tui-winsource.c (tui_refill_source_window): New function,
8516         from...
8517         (tui_horizontal_source_scroll): ... here.  Move some logic.
8518         * cli/cli-style.c (set_style_enabled): Notify new observable.
8519         * tui/tui-hooks.c (tui_redisplay_source): New function.
8520         (tui_attach_detach_observers): Attach or detach
8521         tui_redisplay_source.
8522         * observable.h (source_styling_changed): New observable.
8523         * observable.c: Define source_styling_changed observable.
8524
8525 2019-03-13  Tom Tromey  <tromey@adacore.com>
8526
8527         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8528         (i386_gnu_nat_target::store_registers): Update.
8529         * target-debug.h (target_debug_print_std_string): New macro.
8530         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8531         * windows-tdep.c (display_one_tib): Update.
8532         * tui/tui-stack.c (tui_make_status_line): Update.
8533         * top.c (print_inferior_quit_action): Update.
8534         * thread.c (thr_try_catch_cmd): Update.
8535         (add_thread_with_info): Update.
8536         (thread_target_id_str): Update.
8537         (thr_try_catch_cmd): Update.
8538         (thread_command): Update.
8539         (thread_find_command): Update.
8540         * record-btrace.c (record_btrace_target::info_record)
8541         (record_btrace_resume_thread, record_btrace_target::resume)
8542         (record_btrace_cancel_resume, record_btrace_step_thread)
8543         (record_btrace_target::wait, record_btrace_target::wait)
8544         (record_btrace_target::wait, record_btrace_target::stop): Update.
8545         * progspace.c (print_program_space): Update.
8546         * process-stratum-target.c
8547         (process_stratum_target::thread_address_space): Update.
8548         * linux-fork.c (linux_fork_mourn_inferior)
8549         (detach_checkpoint_command, info_checkpoints_command)
8550         (linux_fork_context): Update.
8551         (linux_fork_detach): Update.
8552         (class scoped_switch_fork_info): Update.
8553         (delete_checkpoint_command): Update.
8554         * infrun.c (follow_fork_inferior): Update.
8555         (follow_fork_inferior): Update.
8556         (proceed_after_vfork_done): Update.
8557         (handle_vfork_child_exec_or_exit): Update.
8558         (follow_exec): Update.
8559         (displaced_step_prepare_throw): Update.
8560         (displaced_step_restore): Update.
8561         (start_step_over): Update.
8562         (resume_1): Update.
8563         (clear_proceed_status_thread): Update.
8564         (proceed): Update.
8565         (print_target_wait_results): Update.
8566         (do_target_wait): Update.
8567         (context_switch): Update.
8568         (stop_all_threads): Update.
8569         (restart_threads): Update.
8570         (finish_step_over): Update.
8571         (handle_signal_stop): Update.
8572         (switch_back_to_stepped_thread): Update.
8573         (keep_going_pass_signal): Update.
8574         (print_exited_reason): Update.
8575         (normal_stop): Update.
8576         * inferior.c (inferior_pid_to_str): Change return type.
8577         (print_selected_inferior): Update.
8578         (add_inferior): Update.
8579         (detach_inferior): Update.
8580         * dummy-frame.c (fprint_dummy_frames): Update.
8581         * dcache.c (dcache_info_1): Update.
8582         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8583         (btrace_fetch, btrace_clear): Update.
8584         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8585         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8586         type.
8587         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8588         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8589         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8590         * gdbarch.c, gdbarch.h: Rebuild.
8591         * gdbarch.sh (core_pid_to_str): Change return type.
8592         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8593         return type.
8594         (windows_nat_target::pid_to_str): Change return type.
8595         (windows_delete_thread): Update.
8596         (windows_nat_target::attach): Update.
8597         (windows_nat_target::files_info): Update.
8598         * target-delegates.c: Rebuild.
8599         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8600         return type.
8601         (sol_thread_target::pid_to_str): Change return type.
8602         * remote.c (class remote_target) <pid_to_str>: Change return
8603         type.
8604         (remote_target::pid_to_str): Change return type.
8605         (extended_remote_target::attach, remote_target::remote_stop_ns)
8606         (remote_target::remote_notif_remove_queued_reply)
8607         (remote_target::push_stop_reply, remote_target::disable_btrace):
8608         Update.
8609         (extended_remote_target::attach): Update.
8610         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8611         type.
8612         (gdbsim_target::pid_to_str): Change return type.
8613         * ravenscar-thread.c (struct ravenscar_thread_target)
8614         <pid_to_str>: Change return type.
8615         (ravenscar_thread_target::pid_to_str): Change return type.
8616         * procfs.c (class procfs_target) <pid_to_str>: Change return
8617         type.
8618         (procfs_target::pid_to_str): Change return type.
8619         (procfs_target::attach): Update.
8620         (procfs_target::detach): Update.
8621         (procfs_target::fetch_registers): Update.
8622         (procfs_target::store_registers): Update.
8623         (procfs_target::wait): Update.
8624         (procfs_target::files_info): Update.
8625         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8626         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8627         return type.
8628         (nto_procfs_target::pid_to_str): Change return type.
8629         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8630         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8631         return type.
8632         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8633         (exit_lwp): Update.
8634         (attach_proc_task_lwp_callback, get_detach_signal)
8635         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8636         (linux_nat_target::resume, wait_lwp, stop_callback)
8637         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8638         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8639         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8640         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8641         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8642         type.
8643         (inf_ptrace_target::attach): Update.
8644         (inf_ptrace_target::files_info): Update.
8645         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8646         type.
8647         (go32_nat_target::pid_to_str): Change return type.
8648         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8649         (gnu_nat_target::wait): Update.
8650         (gnu_nat_target::wait): Update.
8651         (gnu_nat_target::resume): Update.
8652         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8653         (fbsd_nat_target::wait): Update.
8654         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8655         type.
8656         (darwin_nat_target::attach): Update.
8657         * corelow.c (class core_target) <pid_to_str>: Change return type.
8658         (core_target::pid_to_str): Change return type.
8659         * target.c (normal_pid_to_str): Change return type.
8660         (default_pid_to_str): Likewise.
8661         (target_pid_to_str): Change return type.
8662         (target_translate_tls_address): Update.
8663         (target_announce_detach): Update.
8664         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8665         return type.
8666         (bsd_uthread_target::pid_to_str): Change return type.
8667         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8668         type.
8669         (bsd_kvm_target::pid_to_str): Change return type.
8670         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8671         return type.
8672         (aix_thread_target::pid_to_str): Change return type.
8673         * target.h (struct target_ops) <pid_to_str>: Change return type.
8674         (target_pid_to_str, normal_pid_to_str): Likewise.
8675         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8676         type.
8677         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8678         type.
8679         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8680         return type.
8681         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8682         type.
8683         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8684         type.
8685         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8686         return type.
8687
8688 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8689
8690         * NEWS: Mention that the new default MI version is 3.  Mention
8691         changes to the output of commands and events that deal with
8692         multi-location breakpoints.
8693         * breakpoint.c: Include "mi/mi-out.h".
8694         (print_one_breakpoint): Change output syntax if using MI version
8695         >= 3.
8696         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8697         New.
8698         (mi_multi_location_breakpoint_output_fixed): New.
8699         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8700         (mi_cmd_fix_multi_location_breakpoint_output): New.
8701         (mi_multi_location_breakpoint_output_fixed): New.
8702         * mi/mi-cmds.c (mi_cmds): Register command
8703         -fix-multi-location-breakpoint-output.
8704         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8705         interpreter "mi".
8706
8707 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8708
8709         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8710         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8711         instantiate mi_ui_out based on interpreter name.
8712         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8713         * mi/mi-main.c (mi_load_progress): Likewise.
8714
8715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8716
8717         * NEWS: Combine separate "New targets" sections for 8.3.
8718
8719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8720
8721         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8722         (ppcfbsd_init_abi): Install gdbarch
8723         "fetch_tls_load_module_address" and "get_thread_local_address"
8724         methods.
8725
8726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8727
8728         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8729         (riscv_fbsd_init_abi): Install gdbarch
8730         "fetch_tls_load_module_address" and "get_thread_local_address"
8731         methods.
8732
8733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8734
8735         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8736         (i386fbsd_init_abi): Install gdbarch
8737         "fetch_tls_load_module_address" and "get_thread_local_address"
8738         methods.
8739
8740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8741
8742         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8743         (amd64fbsd_init_abi): Install gdbarch
8744         "fetch_tls_load_module_address" and "get_thread_local_address"
8745         methods.
8746
8747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8748
8749         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8750         (struct fbsd_pspace_data): New type.
8751         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8752         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8753         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8754         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8755         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8756
8757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8758
8759         * gdbtypes.c (lookup_struct_elt): New function.
8760         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8761         * gdbtypes.h (struct struct_elt): New type.
8762         (lookup_struct_elt): New prototype.
8763
8764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8765
8766         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8767         remove disabled code block.
8768
8769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8770
8771         * gdbarch.sh (get_thread_local_address): New method.
8772         * gdbarch.h, gdbarch.c: Regenerate.
8773         * target.c (target_translate_tls_address): Use
8774         gdbarch_get_thread_local_address if present instead of
8775         target::get_thread_local_address.
8776
8777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8778
8779         * target.h (target::get_thread_local_address): Update comment.
8780
8781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8782
8783         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8784         objfile->separate_debug_objfile_backlink if not NULL.
8785
8786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8787
8788         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8789         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8790         (amd64bsd_store_inferior_registers): Likewise.
8791         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8792         Enable segment base registers.
8793         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8794         PT_GETFSBASE and PT_GETGSBASE.
8795         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8796         PT_SETGSBASE.
8797         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8798         segment base registers.
8799         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8800
8801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8802
8803         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8804         Update calls to i386_target_description to add 'segments'
8805         parameter.
8806         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8807         add segment base registers.
8808         * arch/i386.c (i386_create_target_description): Add 'segments'
8809         parameter to enable segment base registers.
8810         * arch/i386.h (i386_create_target_description): Likewise.
8811         * features/i386/32bit-segments.xml: New file.
8812         * features/i386/32bit-segments.c: Generate.
8813         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8814         call to i386_target_description to add 'segments' parameter.
8815         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8816         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8817         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8818         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8819         if feature is present.
8820         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8821         Add 'segments' parameter to call to i386_target_description.
8822         (i386_target_description): Add 'segments' parameter to enable
8823         segment base registers.
8824         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8825         to call to i386_target_description.
8826         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8827         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8828         Define I386_NUM_REGS.
8829         (i386_target_description): Add 'segments' parameter to enable
8830         segment base registers.
8831
8832 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8833
8834         PR/24325
8835         * source-cache.c: #undef open and close, to avoid unresolved
8836         externals during linking.
8837
8838 2019-03-12  Tom Tromey  <tromey@adacore.com>
8839
8840         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8841         const.  Add initializers.
8842         (_initialize_remote): Don't initialize ptid globals.
8843
8844 2019-03-12  Pedro Alves  <palves@redhat.com>
8845
8846         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8847
8848 2019-03-12  Pedro Alves  <palves@redhat.com>
8849
8850         * cp-name-parser.y (main): Remove unused 'len' variable.
8851
8852 2019-03-12  Tom Tromey  <tromey@adacore.com>
8853
8854         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8855         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8856
8857 2019-03-12  Tom Tromey  <tromey@adacore.com>
8858
8859         * linux-nat.c (iterate_over_lwps): Update.
8860         (stop_callback): Remove parameter.
8861         (stop_wait_callback, detach_callback, resume_set_callback)
8862         (select_singlestep_lwp_callback, set_ignore_sigint)
8863         (status_callback, resumed_callback, resume_clear_callback)
8864         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8865         data parameter.
8866         (linux_nat_target::detach, linux_nat_target::resume)
8867         (linux_stop_and_wait_all_lwps, select_event_lwp)
8868         (linux_nat_filter_event, linux_nat_wait_1)
8869         (linux_nat_target::kill, linux_nat_target::stop)
8870         (linux_nat_target::stop): Update.
8871         (linux_nat_resume_callback): Change type.
8872         (resume_stopped_resumed_lwps, count_events_callback)
8873         (select_event_lwp_callback): Likewise.
8874         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8875         * arm-linux-nat.c (struct update_registers_data): Remove.
8876         (update_registers_callback): Change type.
8877         (arm_linux_insert_hw_breakpoint1): Update.
8878         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8879         parameter.
8880         (x86_linux_dr_set_addr): Update.
8881         (x86_linux_dr_set_control): Update.
8882         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8883         (iterate_over_lwps): Use gdb::function_view.
8884         * nat/aarch64-linux-hw-point.c (struct
8885         aarch64_dr_update_callback_param): Remove.
8886         (debug_reg_change_callback): Change type.
8887         (aarch64_notify_debug_reg_change): Update.
8888         * s390-linux-nat.c (s390_refresh_per_info): Update.
8889
8890 2019-03-11  Tom Tromey  <tromey@adacore.com>
8891
8892         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8893         redundant assignment to "this_cu".
8894
8895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8896
8897         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8898
8899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8900
8901         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8902         from...
8903         (rank_one_type): ... this.
8904
8905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8906
8907         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8908         from...
8909         (rank_one_type): ... this.
8910
8911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8912
8913         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8914         from...
8915         (rank_one_type): ... this.
8916
8917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8918
8919         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8920         from...
8921         (rank_one_type): ... this.
8922
8923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8924
8925         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8926         from...
8927         (rank_one_type): ... this.
8928
8929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8930
8931         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8932         from...
8933         (rank_one_type): ... this.
8934
8935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8936
8937         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8938         from...
8939         (rank_one_type): ... this.
8940
8941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8942
8943         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8944         from...
8945         (rank_one_type): ... this.
8946
8947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8948
8949         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8950         from...
8951         (rank_one_type): ... this.
8952
8953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8954
8955         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8956         from...
8957         (rank_one_type): ... this.
8958
8959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8960
8961         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8962         from...
8963         (rank_one_type): ... this.
8964
8965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8966
8967         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8968         from...
8969         (rank_one_type): ... this.
8970
8971 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8972
8973         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8974         inferior-events' shows the example events.
8975
8976 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8977
8978         Support styling on native MS-Windows console
8979
8980         PR/24315
8981         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8982         on MS-Windows if $TERM is not defined.
8983
8984         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8985
8986         * posix-hdep.c (gdb_console_fputs):
8987         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8988         functions.
8989         * ui-file.h (gdb_console_fputs): Add prototype.
8990
8991         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8992         back to fputs only if the former returns zero.
8993
8994 2019-03-07  Tom Tromey  <tom@tromey.com>
8995
8996         * symmisc.c (print_symbol_bcache_statistics): Update.
8997         (print_objfile_statistics): Update.
8998         * symfile.c (allocate_symtab): Update.
8999         * stabsread.c: Don't include bcache.h.
9000         * psymtab.h (struct psymbol_bcache): Don't declare.
9001         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9002         (psymbol_bcache_init, psymbol_bcache_free)
9003         (psymbol_bcache_get_bcache): Don't declare.
9004         * psymtab.c (struct psymbol_bcache): Remove.
9005         (psymtab_storage::psymtab_storage): Update.
9006         (psymtab_storage::~psymtab_storage): Update.
9007         (psymbol_bcache_init, psymbol_bcache_free)
9008         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9009         (add_psymbol_to_bcache): Update.
9010         (allocate_psymtab): Update.
9011         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9012         macro_cache>: No longer pointers.
9013         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9014         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9015         * macrotab.c (macro_bcache): Update.
9016         * macroexp.c: Don't include bcache.h.
9017         * gdbtypes.c (check_types_worklist): Update.
9018         (types_deeply_equal): Remove TRY/CATCH.  Update.
9019         * elfread.c (elf_symtab_read): Update.
9020         * dwarf2read.c: Don't include bcache.h.
9021         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9022         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9023         (print_bcache_statistics, bcache_memory_used): Don't declare.
9024         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9025         methods.  Rename all data members.
9026         * bcache.c (struct bcache): Move to bcache.h.
9027         (bcache::expand_hash_table): Rename from expand_hash_table.
9028         (bcache): Remove.
9029         (bcache::insert): Rename from bcache_full.
9030         (bcache::compare): Rename from bcache_compare.
9031         (bcache_xmalloc): Remove.
9032         (bcache::~bcache): Rename from bcache_xfree.
9033         (bcache::print_statistics): Rename from print_bcache_statistics.
9034         (bcache::memory_used): Rename from bcache_memory_used.
9035
9036 2019-03-07  Pedro Alves  <palves@redhat.com>
9037
9038         * infrun.c (normal_stop): Also check for
9039         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9040
9041 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9042
9043         * f-lang.c (value_from_host_double): Moved to...
9044         * value.c (value_from_host_double): ...here.
9045         * value.h (value_from_host_double): Declare.
9046         * guile/scm-math.c (vlscm_convert_typed_number): Use
9047         value_from_host_double.
9048         (vlscm_convert_number): Likewise.
9049         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9050         * python/py-value.c (convert_value_from_python): Likewise.
9051
9052 2019-03-06  Tom Tromey  <tom@tromey.com>
9053
9054         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9055
9056 2019-03-06  Tom Tromey  <tom@tromey.com>
9057
9058         * utils.h (free_current_contents): Don't declare.
9059         * utils.c (free_current_contents): Remove.
9060
9061 2019-03-06  Tom Tromey  <tom@tromey.com>
9062
9063         * top.c (quit_force): Update.
9064         * main.c (captured_command_loop): Update.
9065         * common/new-op.c (operator new): Update.
9066         * common/common-exceptions.c (struct catcher)
9067         <save_cleanup_chain>: Remove member.
9068         (exceptions_state_mc_init): Update.
9069         (exception_try_scope_entry): Return nullptr.
9070         (exception_try_scope_exit, exception_rethrow)
9071         (throw_exception_sjlj, throw_exception_cxx): Update.
9072         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9073         (all_cleanups, do_cleanups, discard_cleanups)
9074         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9075         (restore_cleanups, restore_final_cleanups): Don't declare.
9076         (do_final_cleanups): Remove parameter.
9077         * common/cleanups.c (cleanup_chain, make_cleanup)
9078         (make_cleanup_dtor, all_cleanups, do_cleanups)
9079         (discard_my_cleanups, discard_cleanups)
9080         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9081         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9082         (null_cleanup): Remove.
9083         (do_final_cleanups): Remove parameter.
9084
9085 2019-03-06  Tom Tromey  <tom@tromey.com>
9086
9087         * remote.c (remote_target::remote_parse_stop_reply): Use
9088         unique_xmalloc_ptr.
9089
9090 2019-03-06  Tom Tromey  <tom@tromey.com>
9091
9092         * stabsread.c (struct stabs_field_info): Rename from field_info.
9093         <list, fnlist>: Add initializers.
9094         <obstack>: New member.
9095         (read_member_functions, read_struct_fields, read_baseclasses):
9096         Allocate on obstack.  Don't use cleanups.
9097         (read_one_struct_field, read_member_functions, read_struct_fields)
9098         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9099         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9100         (read_struct_type): Update.
9101
9102 2019-03-06  Tom Tromey  <tom@tromey.com>
9103
9104         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9105         * common/filestuff.h (make_cleanup_close): Don't declare.
9106         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9107         Remove.
9108
9109 2019-03-06  Tom Tromey  <tom@tromey.com>
9110
9111         * solib-aix.c: Use make_scope_exit.
9112
9113 2019-03-06  Tom Tromey  <tom@tromey.com>
9114
9115         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9116         Use make_scope_exit.
9117
9118 2019-03-06  Tom Tromey  <tom@tromey.com>
9119
9120         * solib-svr4.c (disable_probes_interface): Remove parameter.
9121         (svr4_handle_solib_event): Use make_scope_exit.
9122
9123 2019-03-06  Tom Tromey  <tom@tromey.com>
9124
9125         * remote.c (struct stop_reply_deleter): Remove.
9126         (stop_reply_up): Update.
9127         (struct stop_reply): Derive from notif_event.  Don't typedef.
9128         <regcache>: Now a std::vector.
9129         (stop_reply_xfree): Remove.
9130         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9131         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9132         (remote_target::discard_pending_stop_replies): Use delete.
9133         (remote_target::remote_parse_stop_reply): Update.
9134         (remote_target::process_stop_reply): Update.
9135         * remote-notif.h (struct notif_event): Add virtual destructor.
9136         Remove "dtr" member.
9137         (struct notif_client) <alloc_event>: Return a unique_ptr.
9138         (notif_event_xfree): Don't declare.
9139         (notif_event_up): New typedef.
9140         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9141         (notif_event_xfree, do_notif_event_xfree): Remove.
9142         (remote_notif_state_xfree): Update.
9143
9144 2019-03-06  Tom Tromey  <tom@tromey.com>
9145
9146         * infrun.c (displaced_step_clear_cleanup): Now a
9147         forward_scope_exit type.
9148         (displaced_step_prepare_throw): Update.
9149         (displaced_step_fixup): Update.
9150
9151 2019-03-06  Tom Tromey  <tom@tromey.com>
9152
9153         * inferior.h (class inferior): Update comment.
9154         * gdbthread.h (class thread_info): Update comment.
9155
9156 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9157             Tom Tromey  <tom@tromey.com>
9158
9159         * stabsread.h (struct stab_section_list): Remove.
9160         (coffstab_build_psymtabs): Update.
9161         * dbxread.c (symbuf_sections): Now a std::vector.
9162         (sect_idx): New global.
9163         (fill_symbuf): Update.
9164         (coffstab_build_psymtabs): Change type of stabsects parameter.
9165         Update.
9166         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9167         std::vector.
9168         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9169         (coff_locate_sections): Update.
9170         (coff_symfile_read): Remove cleanups.  Update.
9171         (init_stringtab): Add storage parameter.
9172         (free_stringtab, free_stringtab_cleanup): Remove.
9173         (init_lineno): Add storage parameter.
9174         (free_linetab, free_linetab_cleanup): Remove.
9175
9176 2019-03-06  Pedro Alves  <palves@redhat.com>
9177
9178         * linux-fork.c (fork_info::clobber_regs): Delete.
9179         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9180         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9181         comment.  Adjust.
9182         (scoped_switch_fork_info::scoped_switch_fork_info)
9183         (checkpoint_command, linux_fork_context): Adjust
9184         fork_save_infrun_state calls.
9185
9186 2019-03-06  Pedro Alves  <palves@redhat.com>
9187
9188         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9189         (inf_has_multiple_threads): Return 'bool' and rewrite using
9190         inferior_info::threads().
9191
9192 2019-03-06  Pedro Alves  <palves@redhat.com>
9193
9194         * linux-fork.c: Include <list>.
9195         (fork_list): Now a std::list instance.
9196         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9197         (forks_exist_p, find_last_fork): Adjust.
9198         (new_fork): Delete.
9199         (one_fork_p): New.
9200         (add_fork): Adjust.
9201         (free_fork): Delete, folded into fork_info::~fork_info().
9202         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9203         Adjust.
9204         (init_fork_list): Delete.
9205         (linux_fork_killall, linux_fork_mourn_inferior)
9206         (linux_fork_detach, info_checkpoints_command): Adjust.
9207         (_initialize_linux_fork): No longer call init_fork_list.
9208
9209 2019-03-06  Pedro Alves  <palves@redhat.com>
9210
9211         * linux-fork.c (new_fork): New, split out of ...
9212         (add_fork): ... this.  Return void.  Move "first fork" special
9213         case from here, to ...
9214         (checkpoint_command): ... here.
9215         * linux-linux.h (add_fork): Return void.
9216
9217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9218
9219         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9220
9221 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9222             Chris January  <chris.january@arm.com>
9223             David Lecomber  <david.lecomber@arm.com>
9224
9225         * f-exp.y: New token, UNOP_INTRINSIC.
9226         (exp): New pattern using UNOP_INTRINSIC token.
9227         (f77_keywords): Add 'abs' keyword.
9228         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9229         (value_from_host_double): New function.
9230         (evaluate_subexp_f): Support UNOP_ABS.
9231
9232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9233
9234         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9235         types.
9236
9237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9238
9239         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9240         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9241         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9242
9243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9246
9247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9248             Chris January  <chris.january@arm.com>
9249
9250         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9251         * f-exp.y: Define 'KIND' token.
9252         (exp): New pattern for KIND expressions.
9253         (ptype): Handle types with a kind extension.
9254         (direct_abs_decl): Extend to spot kind extensions.
9255         (f77_keywords): Add 'kind' to the list.
9256         (push_kind_type): New function.
9257         (convert_to_kind_type): New function.
9258         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9259         * parse.c (operator_length_standard): Likewise.
9260         * parser-defs.h (enum type_pieces): Add tp_kind.
9261         * std-operator.def: Add UNOP_KIND.
9262
9263 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * f-exp.y (f_parse): Set yydebug.
9266
9267 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9268
9269         * f-lang.c (evaluate_subexp_f): New function.
9270         (exp_descriptor_f): New global.
9271         (f_language_defn): Use exp_descriptor_f instead of
9272         exp_descriptor_standard.
9273
9274 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * f-exp.y (struct token): Add comments.
9277         (dot_ops): Remove uppercase versions and the end marker.
9278         (f77_keywords): Likewise.
9279         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9280         entries in the dot_ops array are case insensitive, and use
9281         strncasecmp to compare strings.  Also some whitespace cleanup in
9282         this area.  Similar for the f77_keywords array, except entries in
9283         this list might be case sensitive.
9284
9285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * f-exp.y (struct f77_boolean_val): Add comments.
9288         (boolean_values): Remove uppercase versions, and end marker.
9289         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9290         and use strncasecmp to achieve case insensitivity.  Additionally,
9291         perform whitespace cleanup around this code.
9292
9293 2019-03-06  Tom Tromey  <tromey@adacore.com>
9294
9295         * remote-sim.c (gdbsim_target_open): Use result of
9296         gdb_argv::release.
9297
9298 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9299         Dirk Schubert  <dirk.schubert@arm.com>
9300         Chris January  <chris.january@arm.com>
9301
9302         * eval.c (evaluate_subexp_standard): Call Fortran argument
9303         wrapping logic.
9304         * f-lang.c (struct value): A value which can be passed into a
9305         Fortran function call.
9306         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9307         where appropriate.
9308         (struct type): Value ready for a Fortran function call.
9309         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9310         is needed.
9311         * f-lang.h (fortran_argument_convert): Declaration.
9312         (fortran_preserve_arg_pointer): Declaration.
9313         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9314
9315 2019-03-05  Tom Tromey  <tromey@adacore.com>
9316
9317         * python/py-prettyprint.c (print_string_repr): Remove #if.
9318         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9319
9320 2019-03-05  Tom Tromey  <tromey@adacore.com>
9321
9322         * target.c (the_dummy_target): Move later.  Change type to
9323         "dummy_target".
9324         (initialize_targets): Don't initialize the_dummy_target.
9325
9326 2019-03-05  Tom Tromey  <tromey@adacore.com>
9327
9328         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9329         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9330
9331 2019-03-05  Tom Tromey  <tromey@adacore.com>
9332
9333         * windows-nat.c (windows_nat_target::attach)
9334         (windows_nat_target::detach): Don't call gdb_flush.
9335         * valprint.c (generic_val_print, val_print, val_print_string):
9336         Don't call gdb_flush.
9337         * utils.c (defaulted_query): Don't call gdb_flush.
9338         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9339         * target.c (target_announce_detach): Don't call gdb_flush.
9340         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9341         * remote.c (extended_remote_target::attach): Don't call
9342         gdb_flush.
9343         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9344         * printcmd.c (do_examine): Don't call gdb_flush.
9345         (info_display_command): Don't call gdb_flush.
9346         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9347         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9348         * memattr.c (info_mem_command): Don't call gdb_flush.
9349         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9350         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9351         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9352         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9353         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9354         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9355         (gnu_nat_target::detach): Don't call gdb_flush.
9356         * f-valprint.c (f_val_print): Don't call gdb_flush.
9357         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9358         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9359         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9360         gdb_flush.
9361         * c-valprint.c (c_val_print): Don't call gdb_flush.
9362         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9363
9364 2019-03-05  Tom Tromey  <tromey@adacore.com>
9365
9366         * varobj.c (update_dynamic_varobj_children): Update.
9367         (install_default_visualizer): Use reset, not release.
9368         * value.c (set_internalvar): Update.
9369         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9370         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9371         ATTRIBUTE_UNUSED_RESULT.
9372
9373 2019-03-05  Tom Tromey  <tromey@adacore.com>
9374
9375         * remote.c (class scoped_remote_fd) <release>: Add
9376         ATTRIBUTE_UNUSED_RESULT.
9377
9378 2019-03-05  Tom Tromey  <tromey@adacore.com>
9379
9380         * macroexp.c (struct macro_buffer) <release>: Add
9381         ATTRIBUTE_UNUSED_RESULT.
9382
9383 2019-03-05  Tom Tromey  <tromey@adacore.com>
9384
9385         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9386         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9387         ATTRIBUTE_UNUSED_RESULT.
9388
9389 2019-03-05  Tom Tromey  <tromey@adacore.com>
9390
9391         * common/scoped_fd.h (class scoped_fd) <release>: Add
9392         ATTRIBUTE_UNUSED_RESULT.
9393
9394 2019-03-05  Tom Tromey  <tromey@adacore.com>
9395
9396         * parser-defs.h (struct parser_state) <release>: Add
9397         ATTRIBUTE_UNUSED_RESULT.
9398
9399 2019-03-05  Tom Tromey  <tromey@adacore.com>
9400
9401         * utils.h (class gdb_argv) <release>: Add
9402         ATTRIBUTE_UNUSED_RESULT.
9403         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9404
9405 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9406
9407         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9408         for-loop range, to avoid compiler warnings.
9409
9410         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9411         avoid compiler warnings about unused variables.
9412
9413         * NEWS: Mention end of support for native debugging on MS-Windows
9414         before XP.
9415
9416         PR gdb/24292
9417         * common/netstuff.c:
9418         * gdbserver/gdbreplay.c
9419         * gdbserver/remote-utils.c:
9420         * ser-tcp.c:
9421         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9422         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9423         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9424         'getaddrinfo' and 'freeaddrinfo' were not available before
9425         Windows XP, and mingw.org's MinGW headers by default define
9426         _WIN32_WINNT to 0x500.
9427
9428 2019-03-01  Gary Benson <gbenson@redhat.com>
9429
9430         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9431
9432 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9433             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9434
9435         PR gdb/8527
9436         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9437         set_sigint_trap, clear_sigint_trap.
9438
9439 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9440
9441         * target.c (target_detach): Clear the regcache and the
9442         frame cache.
9443
9444 2019-02-27  Pedro Alves  <palves@redhat.com>
9445
9446         * utils.c (set_screen_size): When we cap the height/width sizes,
9447         tweak the corresponding command variable to show "unlimited":
9448
9449 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9450             Pedro Alves  <palves@redhat.com>
9451
9452         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9453         before calling rl_set_screen_size.
9454
9455 2019-02-27  Tom Tromey  <tromey@adacore.com>
9456
9457         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9458         define.
9459         * python/py-value.c: Remove Python 2.4 workaround.
9460         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9461         workaround.
9462         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9463         Python 2.4 workaround.
9464         * python/python-internal.h: Remove Python 2.4 comment.
9465         (Py_ssize_t): Don't define.
9466         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9467         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9468         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9469         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9470         * python/python.c (do_start_initialization): Remove Python 2.4
9471         workaround.
9472         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9473         (print_children): Remove Python 2.4 workaround.
9474         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9475         workaround.
9476         (CHARBUFFERPROC_NAME): Remove.
9477         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9478         Python 2.4 workaround.
9479
9480 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9481
9482         * NEWS: Note minimum Python version.
9483
9484 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9485
9486         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9487         code from these functions.  Remove corresponding ifdefs.  Use
9488         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9489         Remove gotos and target of gotos.
9490         (infpy_search_memory): Likewise.
9491
9492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9493
9494         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9495         (hppa_gdbarch_init): Don't register deleted functions with
9496         gdbarch.
9497
9498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9499
9500         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9501         (h8300_unwind_sp): Delete.
9502         (h8300_dummy_id): Delete.
9503         (h8300_gdbarch_init): Don't register deleted functions with
9504         gdbarch.
9505
9506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9507
9508         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9509         (ft32_unwind_pc): Delete.
9510         (ft32_unwind_sp): Delete.
9511         (ft32_gdbarch_init): Don't register deleted functions with
9512         gdbarch.
9513
9514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9517         (frv_unwind_pc): Delete.
9518         (frv_unwind_sp): Delete.
9519         (frv_gdbarch_init): Don't register deleted functions with
9520         gdbarch.
9521
9522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9523
9524         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9525         (riscv_unwind_pc): Delete.
9526         (riscv_unwind_sp): Delete.
9527         (riscv_gdbarch_init): Don't register deleted functions with
9528         gdbarch.
9529
9530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9531
9532         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9533         (csky_unwind_pc): Delete.
9534         (csky_unwind_sp): Delete.
9535         (csky_gdbarch_init): Don't register deleted functions with
9536         gdbarch.
9537
9538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9539
9540         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9541         (cris_unwind_pc): Delete.
9542         (cris_unwind_sp): Delete.
9543         (cris_gdbarch_init): Don't register deleted functions with
9544         gdbarch.
9545
9546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9547
9548         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9549         (bfin_unwind_pc): Delete.
9550         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9551
9552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9553
9554         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9555         (arm_unwind_pc): Delete.
9556         (arm_unwind_sp): Delete.
9557         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9558
9559 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9560
9561         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9562         (arc_unwind_pc): Delete.
9563         (arc_unwind_sp): Delete.
9564         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9565
9566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9567
9568         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9569         (alpha_unwind_pc): Delete.
9570         (alpha_gdbarch_init): Don't register deleted functions with
9571         gdbarch.
9572
9573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9574
9575         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9576         (aarch64_unwind_pc): Delete.
9577         (aarch64_unwind_sp): Delete.
9578         (aarch64_gdbarch_init): Don't register deleted functions with
9579         gdbarch.
9580
9581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9582
9583         * gdbtypes.c (type_align): Don't consider static members when
9584         computing structure alignment.
9585
9586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9587
9588         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9589         return 0 for other types.
9590         * arch-utils.c (default_type_align): Always return 0.
9591         * gdbarch.h: Regenerate.
9592         * gdbarch.sh (type_align): Extend comment.
9593         * gdbtypes.c (type_align): Add additional comments, always call
9594         gdbarch_type_align before applying the default rules.
9595         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9596         generic code will then apply a suitable default.
9597         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9598         types, return 0 for other types.
9599
9600 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9601
9602         * NEWS: Create a new section for the next release branch.
9603         Rename the section of the current branch, now that it has
9604         been cut.
9605
9606 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9607
9608         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9609         * version.in: Bump version to 8.3.50.DATE-git.
9610
9611 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9612
9613         * aix-thread.c (ptid_cmp): Remove unused variable.
9614         (get_signaled_thread): Likewise.
9615         (store_regs_user_thread): Likewise.
9616         (store_regs_kernel_thread): Likewise.
9617         (fetch_regs_kernel_thread): Remove shadowed variable.
9618
9619 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9620
9621         * features/riscv/32bit-cpu.xml: Add register numbers.
9622         * features/riscv/32bit-fpu.c: Regenerate.
9623         * features/riscv/32bit-fpu.xml: Add register numbers.
9624         * features/riscv/64bit-cpu.xml: Add register numbers.
9625         * features/riscv/64bit-fpu.c: Regenerate.
9626         * features/riscv/64bit-fpu.xml: Add register numbers.
9627
9628 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9629
9630         * NEWS: Mention two argument form of gdb.Value constructor.
9631         * python/py-value.c (convert_buffer_and_type_to_value): New
9632         function.
9633         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9634         Add support for handling an optional second argument.  Call
9635         convert_buffer_and_type_to_value as appropriate.
9636         * python/python-internal.h (Py_buffer_deleter): New struct.
9637         (Py_buffer_up): New typedef.
9638
9639 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9640
9641         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9642         instead of releasing ownership.
9643
9644 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9645
9646         * dwarf2read.c (open_and_init_dwp_file): Call
9647         elf_numsections instead of bfd_count_sections to initialize
9648         dwp_file->num_sections.
9649
9650 2019-02-25  Tom Tromey  <tromey@adacore.com>
9651
9652         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9653
9654 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9655
9656         * gcore.in: Add '--readnever' option when invoking GDB.
9657
9658 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9659
9660         * MAINTAINERS: Update my email address.
9661
9662 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9663
9664         * build-id.c (build_id_to_debug_bfd_1): New function.
9665         (build_id_to_debug_bfd): Look for separate debug file in
9666         sysroot.
9667
9668 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9669
9670         * gdbarch.sh: Update the copyright year range that is placed into
9671         generated files.
9672
9673 2019-02-22  Keith Seitz  <keiths@redhat.com>
9674
9675         PR symtab/23853
9676         * linespec.c (create_sals_line_offset): Search for the default
9677         symtab's filename instead of its fullname.
9678
9679 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9680
9681         * NEWS: Update style defaults.
9682
9683 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9684
9685         * main.c (captured_main_1): Disable styling in batch mode.
9686
9687 2019-02-20  Tom Tromey  <tom@tromey.com>
9688
9689         * symtab.c (symtab_symbol_info): Fix typos.
9690
9691 2019-02-20  Tom Tromey  <tromey@adacore.com>
9692
9693         * findcmd.c (_initialize_mem_search): Use upper case for
9694         metasyntactic variables.
9695
9696 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9697
9698         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9699         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9700
9701 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9702
9703         * top.h (source_file_name): Change to std::string.
9704         * top.c (source_file_name): Likewise.
9705         (command_line_input): Adjust.
9706         * cli/cli-script.c (script_from_file): Adjust.
9707
9708 2019-02-19  Tom Tromey  <tromey@adacore.com>
9709
9710         * ravenscar-thread.c
9711         (ravenscar_thread_target::update_thread_list): Don't call
9712         ada_build_task_list.
9713         * ada-lang.h (ada_build_task_list): Don't declare.
9714         * ada-tasks.c (struct ada_tasks_inferior_data)
9715         <task_list_valid_p>: Now bool.
9716         (read_known_tasks, ada_task_list_changed)
9717         (ada_tasks_invalidate_inferior_data): Update.
9718         (read_known_tasks_array): Return bool.
9719         (read_known_tasks_list): Likewise.
9720         (read_known_tasks): Return void.
9721         (ada_build_task_list): Now static.
9722
9723 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9724
9725         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9726         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9727
9728 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9729
9730         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9731         variant for ada_tasks_pspace_data_handle and
9732         ada_tasks_inferior_data_handle.
9733         (ada_tasks_pspace_data_cleanup): New function.
9734         (ada_tasks_inferior_data_cleanup): New function.
9735
9736 2019-02-17  Tom Tromey  <tom@tromey.com>
9737
9738         * macrotab.h (macro_source_fullname): Return a std::string.
9739         * macrotab.c (macro_include, check_for_redefinition)
9740         (macro_undef, macro_lookup_definition, foreach_macro)
9741         (foreach_macro_in_scope): Update.
9742         (macro_source_fullname): Return a std::string.
9743         * macrocmd.c (show_pp_source_pos): Update.
9744
9745 2019-02-17  Tom Tromey  <tom@tromey.com>
9746
9747         * macrocmd.c (show_pp_source_pos): Style the file names.
9748
9749 2019-02-17  Tom Tromey  <tom@tromey.com>
9750
9751         PR tui/24197:
9752         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9753
9754 2019-02-17  Tom Tromey  <tom@tromey.com>
9755
9756         * ada-lang.c (user_select_syms): Use filtered printing.
9757         * utils.c (wrap_style): New global.
9758         (desired_style): Remove.
9759         (emit_style_escape): Add stream parameter.
9760         (set_output_style, reset_terminal_style, prompt_for_continue):
9761         Update.
9762         (flush_wrap_buffer): Only flush gdb_stdout.
9763         (wrap_here): Set wrap_style.
9764         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9765         treat escape sequences as a character.  Change when wrap buffer is
9766         flushed.
9767         (fputs_styled): Do not set the output style when the default is
9768         requested.
9769         * ui-style.h (struct ui_file_style) <is_default>: New method.
9770         * source.c (print_source_lines_base): Emit escape sequences in one
9771         piece.
9772
9773 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9774
9775         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9776         integers and enumeration types.
9777
9778 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9779
9780         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9781         instead of lookup_symbol_in_language
9782         (do_exact_match): New function.
9783         (ada_get_symbol_name_matcher): Return do_exact_match when
9784         doing a verbatim match.
9785
9786 2019-02-15  Tom Tromey  <tromey@adacore.com>
9787
9788         * ravenscar-thread.c (ravenscar_thread_target::resume)
9789         (ravenscar_thread_target::wait): Special case wildcard requests.
9790
9791 2019-02-15  Tom Tromey  <tromey@adacore.com>
9792
9793         * ravenscar-thread.c (base_ptid): Remove.
9794         (struct ravenscar_thread_target) <close>: New method.
9795         <m_base_ptid>: New member.
9796         <update_inferior_ptid, active_task, task_is_currently_active,
9797         runtime_initialized>: Declare methods.
9798         <ravenscar_thread_target>: Add constructor.
9799         (ravenscar_thread_target::task_is_currently_active)
9800         (ravenscar_thread_target::update_inferior_ptid)
9801         (ravenscar_runtime_initialized): Rename.  Now methods.
9802         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9803         (ravenscar_thread_target::update_thread_list): Update.
9804         (ravenscar_thread_target::active_task): Now method.
9805         (ravenscar_thread_target::store_registers)
9806         (ravenscar_thread_target::prepare_to_store)
9807         (ravenscar_thread_target::prepare_to_store)
9808         (ravenscar_thread_target::mourn_inferior): Update.
9809         (ravenscar_inferior_created): Use "new" to create target.
9810         (ravenscar_thread_target::get_ada_task_ptid): Update.
9811         (_initialize_ravenscar): Don't initialize base_ptid.
9812         (ravenscar_ops): Remove global.
9813
9814 2019-02-15  Tom Tromey  <tromey@adacore.com>
9815
9816         * target.h (push_target): Declare new overload.
9817         * target.c (push_target): New overload, taking an rvalue reference.
9818         * remote.c (remote_target::open_1): Use push_target overload.
9819         * corelow.c (core_target_open): Use push_target overload.
9820
9821 2019-02-15  Tom Tromey  <tromey@adacore.com>
9822
9823         * ravenscar-thread.c (is_ravenscar_task)
9824         (ravenscar_task_is_currently_active): Return bool.
9825         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9826         (_initialize_ravenscar): Remove "(void)".
9827         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9828         Return bool.
9829
9830 2019-02-15  Tom Tromey  <tromey@adacore.com>
9831
9832         * ravenscar-thread.c (ravenscar_runtime_initializer)
9833         (has_ravenscar_runtime, get_running_thread_id)
9834         (ravenscar_thread_target::resume): Fix indentation.
9835
9836 2019-02-15  Tom Tromey  <tromey@adacore.com>
9837
9838         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9839         from ravenscar_arch_ops.
9840         (sparc_ravenscar_ops::fetch_registers)
9841         (sparc_ravenscar_ops::store_registers): Now methods.
9842         (sparc_ravenscar_prepare_to_store): Remove.
9843         (sparc_ravenscar_ops): Redefine.
9844         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9845         methods and destructor.  Remove members.
9846         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9847         (ravenscar_thread_target::store_registers)
9848         (ravenscar_thread_target::prepare_to_store): Update.
9849         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9850         Remove.
9851         (struct ppc_ravenscar_powerpc_ops): Derive from
9852         ravenscar_arch_ops.
9853         (ppc_ravenscar_powerpc_ops::fetch_registers)
9854         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9855         (ppc_ravenscar_powerpc_ops): Redefine.
9856         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9857         (ppc_ravenscar_e500_ops::fetch_registers)
9858         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9859         (ppc_ravenscar_e500_ops): Redefine.
9860         * aarch64-ravenscar-thread.c
9861         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9862         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9863         (aarch64_ravenscar_fetch_registers)
9864         (aarch64_ravenscar_store_registers): Now methods.
9865         (aarch64_ravenscar_ops): Redefine.
9866
9867 2019-02-15  Tom Tromey  <tromey@adacore.com>
9868
9869         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9870         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9871         (ravenscar_thread_target::stopped_by_watchpoint)
9872         (ravenscar_thread_target::stopped_data_address)
9873         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9874
9875 2019-02-15  Tom Tromey  <tromey@adacore.com>
9876
9877         * ravenscar-thread.c: Fix some typos.
9878
9879 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9880             Tom Tromey  <tromey@adacore.com>
9881
9882         * ada-lang.c (ada_exception_sal): Change addr_string to a
9883         std::string.
9884         (create_ada_exception_catchpoint): Update.
9885
9886 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9887             Tom Tromey  <tromey@adacore.com>
9888
9889         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9890         (bp_location_ops): Remove.
9891         (base_breakpoint_allocate_location): Update.
9892         (free_bp_location): Update.
9893         * ada-lang.c (class ada_catchpoint_location)
9894         <ada_catchpoint_location>: Remove ops parameter.
9895         (ada_catchpoint_location_dtor): Remove.
9896         (ada_catchpoint_location_ops): Remove.
9897         (allocate_location_exception): Update.
9898         * breakpoint.h (struct bp_location_ops): Remove.
9899         (class bp_location) <bp_location>: Remove bp_location_ops
9900         parameter.
9901         <~bp_location>: Add destructor.
9902         <ops>: Remove.
9903
9904 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9905             Pedro Alves  <palves@redhat.com>
9906
9907         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9908         'PATH_MAX'.
9909
9910 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9911             Samuel Thibault  <samuel.thibault@gnu.org>
9912             Thomas Schwinge  <thomas@codesourcery.com>
9913
9914         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9915         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9916
9917 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9918
9919         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9920         (check_empty): Use "const char *".
9921
9922         * gnu-nat.c (gnu_nat_target::detach): Instead of
9923         'detach_inferior (pid)' call
9924         'detach_inferior (find_inferior_pid (pid))'.
9925
9926         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9927         'nat/fork-inferior.o'.
9928         * gnu-nat.c: #include "nat/fork-inferior.h".
9929
9930         * gnu-nat.c (gnu_nat_target::detach): Instead of
9931         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9932         * gnu-nat.h: #include "inf-child.h".
9933         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9934         'i386_gnu_nat_target::fetch_registers'.
9935         (gnu_store_registers): Rename/move to
9936         'i386_gnu_nat_target::store_registers'.
9937
9938         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9939         * gnu-nat.h (mach_thread_info): New function.
9940         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9941
9942         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9943
9944 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9945
9946         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9947
9948 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9949
9950         * windows-nat.c (windows_add_thread): Add new parameter
9951         "main_thread_p" with default value set to false.  Update
9952         function documentation as well as all callers.
9953         (windows_delete_thread): Likewise.
9954         (fake_create_process): Update call to windows_add_thread.
9955         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9956         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9957         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9958         call to windows_delete_thread.
9959
9960 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9961
9962         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9963
9964 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9965
9966         * symfile.c (find_separate_debug_file): Use canonical path of
9967         sysroot with child_path instead of gdb_sysroot if it is valid.
9968
9969 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9970
9971         * symfile.c (find_separate_debug_file): Use child_path to
9972         determine if an object file is under a sysroot.
9973
9974 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9975
9976         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9977         unittests/child-path-selftests.c.
9978         * common/pathstuff.c (child_path): New function.
9979         * common/pathstuff.h (child_path): New prototype.
9980         * unittests/child-path-selftests.c: New file.
9981
9982 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9983
9984         * symfile.c (find_separate_debug_file): Look for separate debug
9985         files in debug directories under the sysroot.
9986
9987 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9988
9989         * symtab.h (struct minimal_symbol data_p): New const method.
9990         (struct minimal_symbol text_p): Likewise.
9991         * symtab.c (output_source_filename): Use file name style
9992         to print file name.
9993         (print_symbol_info): Likewise.
9994         (print_msymbol_info): Use address style to print addresses.
9995         Use function name style to print executable text symbols.
9996         (expand_symtab_containing_pc): Use data_p.
9997         (find_pc_sect_compunit_symtab): Likewise.
9998
9999 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10000
10001         * breakpoint.c (describe_other_breakpoints): Use address style
10002         to print addresses.
10003         (say_where): Likewise.
10004
10005 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10006
10007         * ada-typeprint.c (print_func_type): Print function name
10008         style to print function name.
10009         * c-typeprint.c (c_print_type_1): Likewise.
10010
10011 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10012
10013         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10014         for execve.
10015
10016 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10017
10018         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10019         type_stack.
10020
10021 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10022
10023         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10024         TYPE_CODE_REF types.
10025
10026 2019-02-08  Jim Wilson  <jimw@sifive.com>
10027
10028         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10029         (riscv_linux_fregset): New.
10030         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10031
10032 2019-02-07  Tom Tromey  <tom@tromey.com>
10033
10034         * thread.c (thread_cancel_execution_command): Update.
10035         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10036         methods.
10037         (struct thread_fsm_ops): Remove.
10038         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10039         (thread_fsm_should_stop, thread_fsm_return_value)
10040         (thread_fsm_set_finished, thread_fsm_finished_p)
10041         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10042         Don't declare.
10043         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10044         * infrun.c (clear_proceed_status_thread)
10045         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10046         (print_stop_event): Update.
10047         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10048         Add constructor.
10049         (step_command_fsm_ops): Remove.
10050         (new_step_command_fsm): Remove.
10051         (step_1): Update.
10052         (step_command_fsm::should_stop): Rename from
10053         step_command_fsm_should_stop.
10054         (step_command_fsm::clean_up): Rename from
10055         step_command_fsm_clean_up.
10056         (step_command_fsm::do_async_reply_reason): Rename from
10057         step_command_fsm_async_reply_reason.
10058         (struct until_next_fsm): Inherit from thread_fsm.  Add
10059         constructor.
10060         (until_next_fsm_ops): Remove.
10061         (new_until_next_fsm): Remove.
10062         (until_next_fsm::should_stop): Rename from
10063         until_next_fsm_should_stop.
10064         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10065         (until_next_fsm::do_async_reply_reason): Rename from
10066         until_next_fsm_async_reply_reason.
10067         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10068         constructor.  Change type of breakpoint.
10069         (finish_command_fsm_ops): Remove.
10070         (new_finish_command_fsm): Remove.
10071         (finish_command_fsm::should_stop): Rename from
10072         finish_command_fsm_should_stop.
10073         (finish_command_fsm::clean_up): Rename from
10074         finish_command_fsm_clean_up.
10075         (finish_command_fsm::return_value): Rename from
10076         finish_command_fsm_return_value.
10077         (finish_command_fsm::do_async_reply_reason): Rename from
10078         finish_command_fsm_async_reply_reason.
10079         (finish_command): Update.
10080         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10081         Add constructor.
10082         (call_thread_fsm_ops): Remove.
10083         (call_thread_fsm::call_thread_fsm): Rename from
10084         new_call_thread_fsm.
10085         (call_thread_fsm::should_stop): Rename from
10086         call_thread_fsm_should_stop.
10087         (call_thread_fsm::should_notify_stop): Rename from
10088         call_thread_fsm_should_notify_stop.
10089         (run_inferior_call, call_function_by_hand_dummy): Update.
10090         * cli/cli-interp.c (should_print_stop_to_console): Update.
10091         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10092         Add constructor.  Change type of location_breakpoint,
10093         caller_breakpoint.
10094         (until_break_fsm_ops): Remove.
10095         (new_until_break_fsm): Remove.
10096         (until_break_fsm::should_stop): Rename from
10097         until_break_fsm_should_stop.
10098         (until_break_fsm::clean_up): Rename from
10099         until_break_fsm_clean_up.
10100         (until_break_fsm::do_async_reply_reason): Rename from
10101         until_break_fsm_async_reply_reason.
10102         (until_break_command): Update.
10103         * thread-fsm.c: Remove.
10104         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10105
10106 2019-02-07  Tom Tromey  <tom@tromey.com>
10107
10108         * yy-remap.h: Add include guard.
10109         * xtensa-tdep.h: Add include guard.
10110         * xcoffread.h: Rename include guard.
10111         * varobj-iter.h: Add include guard.
10112         * tui/tui.h: Rename include guard.
10113         * tui/tui-winsource.h: Rename include guard.
10114         * tui/tui-wingeneral.h: Rename include guard.
10115         * tui/tui-windata.h: Rename include guard.
10116         * tui/tui-win.h: Rename include guard.
10117         * tui/tui-stack.h: Rename include guard.
10118         * tui/tui-source.h: Rename include guard.
10119         * tui/tui-regs.h: Rename include guard.
10120         * tui/tui-out.h: Rename include guard.
10121         * tui/tui-layout.h: Rename include guard.
10122         * tui/tui-io.h: Rename include guard.
10123         * tui/tui-hooks.h: Rename include guard.
10124         * tui/tui-file.h: Rename include guard.
10125         * tui/tui-disasm.h: Rename include guard.
10126         * tui/tui-data.h: Rename include guard.
10127         * tui/tui-command.h: Rename include guard.
10128         * tic6x-tdep.h: Add include guard.
10129         * target/waitstatus.h: Rename include guard.
10130         * target/wait.h: Rename include guard.
10131         * target/target.h: Rename include guard.
10132         * target/resume.h: Rename include guard.
10133         * target-float.h: Rename include guard.
10134         * stabsread.h: Add include guard.
10135         * rs6000-tdep.h: Add include guard.
10136         * riscv-fbsd-tdep.h: Add include guard.
10137         * regformats/regdef.h: Rename include guard.
10138         * record.h: Rename include guard.
10139         * python/python.h: Rename include guard.
10140         * python/python-internal.h: Rename include guard.
10141         * python/py-stopevent.h: Rename include guard.
10142         * python/py-ref.h: Rename include guard.
10143         * python/py-record.h: Rename include guard.
10144         * python/py-record-full.h: Rename include guard.
10145         * python/py-record-btrace.h: Rename include guard.
10146         * python/py-instruction.h: Rename include guard.
10147         * python/py-events.h: Rename include guard.
10148         * python/py-event.h: Rename include guard.
10149         * procfs.h: Add include guard.
10150         * proc-utils.h: Add include guard.
10151         * p-lang.h: Add include guard.
10152         * or1k-tdep.h: Rename include guard.
10153         * observable.h: Rename include guard.
10154         * nto-tdep.h: Rename include guard.
10155         * nat/x86-linux.h: Rename include guard.
10156         * nat/x86-linux-dregs.h: Rename include guard.
10157         * nat/x86-gcc-cpuid.h: Add include guard.
10158         * nat/x86-dregs.h: Rename include guard.
10159         * nat/x86-cpuid.h: Rename include guard.
10160         * nat/ppc-linux.h: Rename include guard.
10161         * nat/mips-linux-watch.h: Rename include guard.
10162         * nat/linux-waitpid.h: Rename include guard.
10163         * nat/linux-ptrace.h: Rename include guard.
10164         * nat/linux-procfs.h: Rename include guard.
10165         * nat/linux-osdata.h: Rename include guard.
10166         * nat/linux-nat.h: Rename include guard.
10167         * nat/linux-namespaces.h: Rename include guard.
10168         * nat/linux-btrace.h: Rename include guard.
10169         * nat/glibc_thread_db.h: Rename include guard.
10170         * nat/gdb_thread_db.h: Rename include guard.
10171         * nat/gdb_ptrace.h: Rename include guard.
10172         * nat/fork-inferior.h: Rename include guard.
10173         * nat/amd64-linux-siginfo.h: Rename include guard.
10174         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10175         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10176         * nat/aarch64-linux.h: Rename include guard.
10177         * nat/aarch64-linux-hw-point.h: Rename include guard.
10178         * mn10300-tdep.h: Add include guard.
10179         * mips-linux-tdep.h: Add include guard.
10180         * mi/mi-parse.h: Rename include guard.
10181         * mi/mi-out.h: Rename include guard.
10182         * mi/mi-main.h: Rename include guard.
10183         * mi/mi-interp.h: Rename include guard.
10184         * mi/mi-getopt.h: Rename include guard.
10185         * mi/mi-console.h: Rename include guard.
10186         * mi/mi-common.h: Rename include guard.
10187         * mi/mi-cmds.h: Rename include guard.
10188         * mi/mi-cmd-break.h: Rename include guard.
10189         * m2-lang.h: Add include guard.
10190         * location.h: Rename include guard.
10191         * linux-record.h: Rename include guard.
10192         * linux-nat.h: Add include guard.
10193         * linux-fork.h: Add include guard.
10194         * i386-darwin-tdep.h: Rename include guard.
10195         * hppa-linux-offsets.h: Add include guard.
10196         * guile/guile.h: Rename include guard.
10197         * guile/guile-internal.h: Rename include guard.
10198         * gnu-nat.h: Rename include guard.
10199         * gdb-stabs.h: Rename include guard.
10200         * frv-tdep.h: Add include guard.
10201         * f-lang.h: Add include guard.
10202         * event-loop.h: Add include guard.
10203         * darwin-nat.h: Rename include guard.
10204         * cp-abi.h: Rename include guard.
10205         * config/sparc/nm-sol2.h: Rename include guard.
10206         * config/nm-nto.h: Rename include guard.
10207         * config/nm-linux.h: Add include guard.
10208         * config/i386/nm-i386gnu.h: Rename include guard.
10209         * config/djgpp/nl_types.h: Rename include guard.
10210         * config/djgpp/langinfo.h: Rename include guard.
10211         * compile/gcc-cp-plugin.h: Add include guard.
10212         * compile/gcc-c-plugin.h: Add include guard.
10213         * compile/compile.h: Rename include guard.
10214         * compile/compile-object-run.h: Rename include guard.
10215         * compile/compile-object-load.h: Rename include guard.
10216         * compile/compile-internal.h: Rename include guard.
10217         * compile/compile-cplus.h: Rename include guard.
10218         * compile/compile-c.h: Rename include guard.
10219         * common/xml-utils.h: Rename include guard.
10220         * common/x86-xstate.h: Rename include guard.
10221         * common/version.h: Rename include guard.
10222         * common/vec.h: Rename include guard.
10223         * common/tdesc.h: Rename include guard.
10224         * common/selftest.h: Rename include guard.
10225         * common/scoped_restore.h: Rename include guard.
10226         * common/scoped_mmap.h: Rename include guard.
10227         * common/scoped_fd.h: Rename include guard.
10228         * common/safe-iterator.h: Rename include guard.
10229         * common/run-time-clock.h: Rename include guard.
10230         * common/refcounted-object.h: Rename include guard.
10231         * common/queue.h: Rename include guard.
10232         * common/ptid.h: Rename include guard.
10233         * common/print-utils.h: Rename include guard.
10234         * common/preprocessor.h: Rename include guard.
10235         * common/pathstuff.h: Rename include guard.
10236         * common/observable.h: Rename include guard.
10237         * common/netstuff.h: Rename include guard.
10238         * common/job-control.h: Rename include guard.
10239         * common/host-defs.h: Rename include guard.
10240         * common/gdb_wait.h: Rename include guard.
10241         * common/gdb_vecs.h: Rename include guard.
10242         * common/gdb_unlinker.h: Rename include guard.
10243         * common/gdb_unique_ptr.h: Rename include guard.
10244         * common/gdb_tilde_expand.h: Rename include guard.
10245         * common/gdb_sys_time.h: Rename include guard.
10246         * common/gdb_string_view.h: Rename include guard.
10247         * common/gdb_splay_tree.h: Rename include guard.
10248         * common/gdb_setjmp.h: Rename include guard.
10249         * common/gdb_ref_ptr.h: Rename include guard.
10250         * common/gdb_optional.h: Rename include guard.
10251         * common/gdb_locale.h: Rename include guard.
10252         * common/gdb_assert.h: Rename include guard.
10253         * common/filtered-iterator.h: Rename include guard.
10254         * common/filestuff.h: Rename include guard.
10255         * common/fileio.h: Rename include guard.
10256         * common/environ.h: Rename include guard.
10257         * common/common-utils.h: Rename include guard.
10258         * common/common-types.h: Rename include guard.
10259         * common/common-regcache.h: Rename include guard.
10260         * common/common-inferior.h: Rename include guard.
10261         * common/common-gdbthread.h: Rename include guard.
10262         * common/common-exceptions.h: Rename include guard.
10263         * common/common-defs.h: Rename include guard.
10264         * common/common-debug.h: Rename include guard.
10265         * common/cleanups.h: Rename include guard.
10266         * common/buffer.h: Rename include guard.
10267         * common/btrace-common.h: Rename include guard.
10268         * common/break-common.h: Rename include guard.
10269         * cli/cli-utils.h: Rename include guard.
10270         * cli/cli-style.h: Rename include guard.
10271         * cli/cli-setshow.h: Rename include guard.
10272         * cli/cli-script.h: Rename include guard.
10273         * cli/cli-interp.h: Rename include guard.
10274         * cli/cli-decode.h: Rename include guard.
10275         * cli/cli-cmds.h: Rename include guard.
10276         * charset-list.h: Add include guard.
10277         * buildsym-legacy.h: Rename include guard.
10278         * bfin-tdep.h: Add include guard.
10279         * ax.h: Rename include guard.
10280         * arm-linux-tdep.h: Add include guard.
10281         * arm-fbsd-tdep.h: Add include guard.
10282         * arch/xtensa.h: Rename include guard.
10283         * arch/tic6x.h: Add include guard.
10284         * arch/i386.h: Add include guard.
10285         * arch/arm.h: Rename include guard.
10286         * arch/arm-linux.h: Rename include guard.
10287         * arch/arm-get-next-pcs.h: Rename include guard.
10288         * arch/amd64.h: Add include guard.
10289         * arch/aarch64-insn.h: Rename include guard.
10290         * arch-utils.h: Rename include guard.
10291         * annotate.h: Add include guard.
10292         * amd64-darwin-tdep.h: Rename include guard.
10293         * aarch64-linux-tdep.h: Add include guard.
10294         * aarch64-fbsd-tdep.h: Add include guard.
10295         * aarch32-linux-nat.h: Add include guard.
10296
10297 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10298
10299         * macrotab.c (macro_define_internal): New function that
10300         factorizes macro_define_object_internal and macro_define_function
10301         code.
10302         (macro_define_object_internal): Use macro_define_internal.
10303         (macro_define_function): Likewise.
10304
10305 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10306
10307         * macrocmd.c (extract_identifier): Return
10308         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10309         callers.
10310
10311 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10312
10313         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10314
10315 2019-02-05  Tom Tromey  <tom@tromey.com>
10316
10317         * target.c (target_stack::unpush): Move assertion earlier.
10318
10319 2019-01-30  Tom Tromey  <tom@tromey.com>
10320
10321         PR python/23615:
10322         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10323         (gdbpy_parse_and_eval): Likewise.
10324         * python/python-internal.h (gdbpy_allow_threads): New class.
10325
10326 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10327
10328         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10329         (aarch64_fbsd_fpregmap): Move earlier.
10330         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10331         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10332         instead of individual calls to trad_frame_set_reg_addr.
10333         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10334         earlier.
10335         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10336         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10337         instead of individual calls to trad_frame_set_reg_addr.
10338
10339 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10340
10341         * CONTRIBUTE: Replace contribution list with wiki link.
10342
10343 2019-01-25  Tom Tromey  <tom@tromey.com>
10344
10345         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10346
10347 2019-01-25  Tom Tromey  <tom@tromey.com>
10348
10349         * xtensa-linux-nat.c: Fix common/ includes.
10350         * xml-support.h: Fix common/ includes.
10351         * xml-support.c: Fix common/ includes.
10352         * x86-linux-nat.c: Fix common/ includes.
10353         * windows-nat.c: Fix common/ includes.
10354         * varobj.h: Fix common/ includes.
10355         * varobj.c: Fix common/ includes.
10356         * value.c: Fix common/ includes.
10357         * valops.c: Fix common/ includes.
10358         * utils.c: Fix common/ includes.
10359         * unittests/xml-utils-selftests.c: Fix common/ includes.
10360         * unittests/utils-selftests.c: Fix common/ includes.
10361         * unittests/unpack-selftests.c: Fix common/ includes.
10362         * unittests/tracepoint-selftests.c: Fix common/ includes.
10363         * unittests/style-selftests.c: Fix common/ includes.
10364         * unittests/string_view-selftests.c: Fix common/ includes.
10365         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10366         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10367         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10368         * unittests/rsp-low-selftests.c: Fix common/ includes.
10369         * unittests/parse-connection-spec-selftests.c: Fix common/
10370         includes.
10371         * unittests/optional-selftests.c: Fix common/ includes.
10372         * unittests/offset-type-selftests.c: Fix common/ includes.
10373         * unittests/observable-selftests.c: Fix common/ includes.
10374         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10375         * unittests/memrange-selftests.c: Fix common/ includes.
10376         * unittests/memory-map-selftests.c: Fix common/ includes.
10377         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10378         * unittests/function-view-selftests.c: Fix common/ includes.
10379         * unittests/environ-selftests.c: Fix common/ includes.
10380         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10381         * unittests/common-utils-selftests.c: Fix common/ includes.
10382         * unittests/cli-utils-selftests.c: Fix common/ includes.
10383         * unittests/array-view-selftests.c: Fix common/ includes.
10384         * ui-file.c: Fix common/ includes.
10385         * tui/tui-io.c: Fix common/ includes.
10386         * tracepoint.h: Fix common/ includes.
10387         * tracepoint.c: Fix common/ includes.
10388         * tracefile-tfile.c: Fix common/ includes.
10389         * top.h: Fix common/ includes.
10390         * top.c: Fix common/ includes.
10391         * thread.c: Fix common/ includes.
10392         * target/waitstatus.h: Fix common/ includes.
10393         * target/waitstatus.c: Fix common/ includes.
10394         * target.h: Fix common/ includes.
10395         * target.c: Fix common/ includes.
10396         * target-memory.c: Fix common/ includes.
10397         * target-descriptions.c: Fix common/ includes.
10398         * symtab.h: Fix common/ includes.
10399         * symfile.c: Fix common/ includes.
10400         * stap-probe.c: Fix common/ includes.
10401         * spu-linux-nat.c: Fix common/ includes.
10402         * sparc-nat.c: Fix common/ includes.
10403         * source.c: Fix common/ includes.
10404         * solib.c: Fix common/ includes.
10405         * solib-target.c: Fix common/ includes.
10406         * ser-unix.c: Fix common/ includes.
10407         * ser-tcp.c: Fix common/ includes.
10408         * ser-pipe.c: Fix common/ includes.
10409         * ser-base.c: Fix common/ includes.
10410         * selftest-arch.c: Fix common/ includes.
10411         * s12z-tdep.c: Fix common/ includes.
10412         * rust-exp.y: Fix common/ includes.
10413         * rs6000-aix-tdep.c: Fix common/ includes.
10414         * riscv-tdep.c: Fix common/ includes.
10415         * remote.c: Fix common/ includes.
10416         * remote-notif.h: Fix common/ includes.
10417         * remote-fileio.h: Fix common/ includes.
10418         * remote-fileio.c: Fix common/ includes.
10419         * regcache.h: Fix common/ includes.
10420         * regcache.c: Fix common/ includes.
10421         * record-btrace.c: Fix common/ includes.
10422         * python/python.c: Fix common/ includes.
10423         * python/py-type.c: Fix common/ includes.
10424         * python/py-inferior.c: Fix common/ includes.
10425         * progspace.h: Fix common/ includes.
10426         * producer.c: Fix common/ includes.
10427         * procfs.c: Fix common/ includes.
10428         * proc-api.c: Fix common/ includes.
10429         * printcmd.c: Fix common/ includes.
10430         * ppc-linux-nat.c: Fix common/ includes.
10431         * parser-defs.h: Fix common/ includes.
10432         * osdata.c: Fix common/ includes.
10433         * obsd-nat.c: Fix common/ includes.
10434         * nat/x86-linux.c: Fix common/ includes.
10435         * nat/x86-linux-dregs.c: Fix common/ includes.
10436         * nat/x86-dregs.h: Fix common/ includes.
10437         * nat/x86-dregs.c: Fix common/ includes.
10438         * nat/ppc-linux.c: Fix common/ includes.
10439         * nat/mips-linux-watch.h: Fix common/ includes.
10440         * nat/mips-linux-watch.c: Fix common/ includes.
10441         * nat/linux-waitpid.c: Fix common/ includes.
10442         * nat/linux-ptrace.h: Fix common/ includes.
10443         * nat/linux-ptrace.c: Fix common/ includes.
10444         * nat/linux-procfs.c: Fix common/ includes.
10445         * nat/linux-personality.c: Fix common/ includes.
10446         * nat/linux-osdata.c: Fix common/ includes.
10447         * nat/linux-namespaces.c: Fix common/ includes.
10448         * nat/linux-btrace.h: Fix common/ includes.
10449         * nat/linux-btrace.c: Fix common/ includes.
10450         * nat/fork-inferior.c: Fix common/ includes.
10451         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10452         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10453         * nat/aarch64-linux.c: Fix common/ includes.
10454         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10455         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10456         * namespace.h: Fix common/ includes.
10457         * mips-linux-tdep.c: Fix common/ includes.
10458         * minsyms.c: Fix common/ includes.
10459         * mi/mi-parse.h: Fix common/ includes.
10460         * mi/mi-main.c: Fix common/ includes.
10461         * mi/mi-cmd-env.c: Fix common/ includes.
10462         * memrange.h: Fix common/ includes.
10463         * memattr.c: Fix common/ includes.
10464         * maint.h: Fix common/ includes.
10465         * maint.c: Fix common/ includes.
10466         * main.c: Fix common/ includes.
10467         * machoread.c: Fix common/ includes.
10468         * location.c: Fix common/ includes.
10469         * linux-thread-db.c: Fix common/ includes.
10470         * linux-nat.c: Fix common/ includes.
10471         * linux-fork.c: Fix common/ includes.
10472         * inline-frame.c: Fix common/ includes.
10473         * infrun.c: Fix common/ includes.
10474         * inflow.c: Fix common/ includes.
10475         * inferior.h: Fix common/ includes.
10476         * inferior.c: Fix common/ includes.
10477         * infcmd.c: Fix common/ includes.
10478         * inf-ptrace.c: Fix common/ includes.
10479         * inf-child.c: Fix common/ includes.
10480         * ia64-linux-nat.c: Fix common/ includes.
10481         * i387-tdep.c: Fix common/ includes.
10482         * i386-tdep.c: Fix common/ includes.
10483         * i386-linux-tdep.c: Fix common/ includes.
10484         * i386-linux-nat.c: Fix common/ includes.
10485         * i386-go32-tdep.c: Fix common/ includes.
10486         * i386-fbsd-tdep.c: Fix common/ includes.
10487         * i386-fbsd-nat.c: Fix common/ includes.
10488         * guile/scm-type.c: Fix common/ includes.
10489         * guile/guile.c: Fix common/ includes.
10490         * go32-nat.c: Fix common/ includes.
10491         * gnu-nat.c: Fix common/ includes.
10492         * gdbthread.h: Fix common/ includes.
10493         * gdbarch-selftests.c: Fix common/ includes.
10494         * gdb_usleep.c: Fix common/ includes.
10495         * gdb_select.h: Fix common/ includes.
10496         * gdb_bfd.c: Fix common/ includes.
10497         * gcore.c: Fix common/ includes.
10498         * fork-child.c: Fix common/ includes.
10499         * findvar.c: Fix common/ includes.
10500         * fbsd-nat.c: Fix common/ includes.
10501         * event-top.c: Fix common/ includes.
10502         * event-loop.c: Fix common/ includes.
10503         * dwarf2read.c: Fix common/ includes.
10504         * dwarf2loc.c: Fix common/ includes.
10505         * dwarf2-frame.c: Fix common/ includes.
10506         * dwarf-index-cache.c: Fix common/ includes.
10507         * dtrace-probe.c: Fix common/ includes.
10508         * disasm-selftests.c: Fix common/ includes.
10509         * defs.h: Fix common/ includes.
10510         * csky-tdep.c: Fix common/ includes.
10511         * cp-valprint.c: Fix common/ includes.
10512         * cp-support.h: Fix common/ includes.
10513         * cp-support.c: Fix common/ includes.
10514         * corelow.c: Fix common/ includes.
10515         * completer.h: Fix common/ includes.
10516         * completer.c: Fix common/ includes.
10517         * compile/compile.c: Fix common/ includes.
10518         * compile/compile-loc2c.c: Fix common/ includes.
10519         * compile/compile-cplus-types.c: Fix common/ includes.
10520         * compile/compile-cplus-symbols.c: Fix common/ includes.
10521         * command.h: Fix common/ includes.
10522         * cli/cli-dump.c: Fix common/ includes.
10523         * cli/cli-cmds.c: Fix common/ includes.
10524         * charset.c: Fix common/ includes.
10525         * build-id.c: Fix common/ includes.
10526         * btrace.h: Fix common/ includes.
10527         * btrace.c: Fix common/ includes.
10528         * breakpoint.h: Fix common/ includes.
10529         * breakpoint.c: Fix common/ includes.
10530         * ax.h:
10531         (enum agent_op): Fix common/ includes.
10532         * ax-general.c (struct aop_map): Fix common/ includes.
10533         * ax-gdb.c: Fix common/ includes.
10534         * auxv.c: Fix common/ includes.
10535         * auto-load.c: Fix common/ includes.
10536         * arm-tdep.c: Fix common/ includes.
10537         * arch/riscv.c: Fix common/ includes.
10538         * arch/ppc-linux-common.c: Fix common/ includes.
10539         * arch/i386.c: Fix common/ includes.
10540         * arch/arm.c: Fix common/ includes.
10541         * arch/arm-linux.c: Fix common/ includes.
10542         * arch/arm-get-next-pcs.c: Fix common/ includes.
10543         * arch/amd64.c: Fix common/ includes.
10544         * arch/aarch64.c: Fix common/ includes.
10545         * arch/aarch64-insn.c: Fix common/ includes.
10546         * arch-utils.c: Fix common/ includes.
10547         * amd64-windows-tdep.c: Fix common/ includes.
10548         * amd64-tdep.c: Fix common/ includes.
10549         * amd64-sol2-tdep.c: Fix common/ includes.
10550         * amd64-obsd-tdep.c: Fix common/ includes.
10551         * amd64-nbsd-tdep.c: Fix common/ includes.
10552         * amd64-linux-tdep.c: Fix common/ includes.
10553         * amd64-linux-nat.c: Fix common/ includes.
10554         * amd64-fbsd-tdep.c: Fix common/ includes.
10555         * amd64-fbsd-nat.c: Fix common/ includes.
10556         * amd64-dicos-tdep.c: Fix common/ includes.
10557         * amd64-darwin-tdep.c: Fix common/ includes.
10558         * agent.c: Fix common/ includes.
10559         * ada-lang.h: Fix common/ includes.
10560         * ada-lang.c: Fix common/ includes.
10561         * aarch64-tdep.c: Fix common/ includes.
10562
10563 2019-01-25  Tom Tromey  <tom@tromey.com>
10564
10565         * common/create-version.sh: Use common/version.h.
10566
10567 2019-01-24  Pedro Alves  <palves@redhat.com>
10568
10569         * infrun.c (signal_stop, signal_print, signal_program)
10570         (signal_catch, signal_pass): Now arrays instead of pointers.
10571         (update_signals_program_target, do_target_resume)
10572         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10573         * linux-nat.c (linux_nat_target::pass_signals)
10574         (linux_nat_target::create_inferior, linux_nat_target::attach):
10575         Adjust.
10576         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10577         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10578         * procfs.c (procfs_target::pass_signals): Adjust.
10579         * record-full.c (record_full_target::resume): Adjust.
10580         * remote.c (remote_target::pass_signals)
10581         (remote_target::program_signals): Adjust.
10582         * target-debug.h (target_debug_print_signals): Now takes a
10583         gdb::array_view as parameter.  Adjust.
10584         * target.h (target_ops) <pass_signals, program_signals>: Replace
10585         pointer and length parameters with gdb::array_view.
10586         (target_pass_signals, target_program_signals): Likewise.
10587         * target-delegates.c: Regenerate.
10588
10589 2019-01-24  Pedro Alves  <palves@redhat.com>
10590
10591         * common/forward-scope-exit.h
10592         (forward_scope_exit::forward_scope_exit): Pass arguments to
10593         m_bind_function directly, instead of creating a std::bind and
10594         copying that.
10595
10596 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10597
10598         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10599         for static members.
10600         (pass_in_v_vfp_candidate): Likewise.
10601
10602 2019-01-23  Tom Tromey  <tom@tromey.com>
10603             Pedro Alves  <palves@redhat.com>
10604
10605         * regcache.c (class regcache_invalidator): Remove.
10606         (regcache::raw_write): Use make_scope_exit.
10607
10608 2019-01-23  Tom Tromey  <tom@tromey.com>
10609
10610         * ui-out.h (class ui_out_emit_type): Update comment.
10611
10612 2019-01-23  Tom Tromey  <tom@tromey.com>
10613
10614         * infrun.c (fetch_inferior_event): Update comment.
10615
10616 2019-01-23  Tom Tromey  <tom@tromey.com>
10617             Pedro Alves  <palves@redhat.com>
10618
10619         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10620         parameter.
10621         (fetch_inferior_event): Use SCOPE_EXIT.
10622
10623
10624 2019-01-23  Tom Tromey  <tom@tromey.com>
10625             Pedro Alves  <palves@redhat.com>
10626
10627         * infrun.c (disable_thread_events): Delete.
10628         (stop_all_threads): Use SCOPE_EXIT.
10629
10630 2019-01-23  Tom Tromey  <tom@tromey.com>
10631             Pedro Alves  <palves@redhat.com>
10632
10633         * symfile.c: Include forward-scope-exit.h.
10634         (clear_symtab_users_cleanup): Replace forward declaration with
10635         a FORWARD_SCOPE_EXIT.
10636         (syms_from_objfile_1): Use the forward_scope_exit and
10637         gdb::optional instead of cleanup_function.
10638         (reread_symbols): Use the forward_scope_exit instead of
10639         cleanup_function.
10640         (clear_symtab_users_cleanup): Remove function.
10641
10642 2019-01-23  Tom Tromey  <tom@tromey.com>
10643             Pedro Alves  <palves@redhat.com>
10644
10645         * linux-nat.c: Include scope-exit.h.
10646         (cleanup_target_stop): Remove.
10647         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10648         SCOPE_EXIT.
10649
10650 2019-01-23  Tom Tromey  <tom@tromey.com>
10651             Pedro Alves  <palves@redhat.com>
10652
10653         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10654         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10655
10656 2019-01-23  Tom Tromey  <tom@tromey.com>
10657             Andrew Burgess  <andrew.burgess@embecosm.com>
10658             Pedro Alves  <palves@redhat.com>
10659
10660         * infrun.c (fetch_inferior_event): Use scope_exit.
10661         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10662         * top.c (execute_command): Use scope_exit.
10663         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10664         * utils.c (do_bpstat_clear_actions_cleanup)
10665         (make_bpstat_clear_actions_cleanup): Remove.
10666
10667 2019-01-23  Tom Tromey  <tom@tromey.com>
10668             Pedro Alves  <palves@redhat.com>
10669
10670         * infrun.c: Include "common/scope-exit.h"
10671         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10672         (wait_for_inferior): Use SCOPE_EXIT.
10673         (fetch_inferior_event): Use scope_exit.
10674
10675 2019-01-23  Tom Tromey  <tom@tromey.com>
10676             Pedro Alves  <palves@redhat.com>
10677
10678         * breakpoint.c (create_breakpoint): Remove cleanup.
10679
10680 2019-01-23  Tom Tromey  <tom@tromey.com>
10681             Andrew Burgess  <andrew.burgess@embecosm.com>
10682             Pedro Alves  <palves@redhat.com>
10683
10684 2019-01-23  Pedro Alves  <palves@redhat.com>
10685
10686         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10687
10688 2019-01-23  Pedro Alves  <palves@redhat.com>
10689             Andrew Burgess  <andrew.burgess@embecosm.com>
10690
10691         * gdbthread.h: Include "common/forward-scope-exit.h".
10692         (scoped_finish_thread_state): Redefine custom class in terms of
10693         forward_scope_exit.
10694
10695 2019-01-23  Pedro Alves  <palves@redhat.com>
10696             Andrew Burgess  <andrew.burgess@embecosm.com>
10697
10698         * common/forward-scope-exit.h: New file.
10699
10700 2019-01-23  Pedro Alves  <palves@redhat.com>
10701             Andrew Burgess  <andrew.burgess@embecosm.com>
10702             Tom Tromey  <tom@tromey.com>
10703
10704         * common/scope-exit.h: New file.
10705
10706 2019-01-23  Pedro Alves  <palves@redhat.com>
10707
10708         * common/preprocessor.h (ESC): Rename to ...
10709         (ESC_PARENS): ... this.
10710         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10711         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10712
10713 2019-01-23  Tom Tromey  <tom@tromey.com>
10714
10715         * language.h (class scoped_switch_to_sym_language_if_auto):
10716         Initialize m_lang in both cases.
10717
10718 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10719
10720         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10721         with XCNEW.
10722
10723 2019-01-22  Tom Tromey  <tom@tromey.com>
10724
10725         * corelow.c: Do not include sys/file.h.
10726
10727 2019-01-22  Tom Tromey  <tom@tromey.com>
10728
10729         * tui/tui-wingeneral.h: Include gdb_curses.h.
10730
10731 2019-01-22  Tom Tromey  <tom@tromey.com>
10732
10733         * source-cache.h (class source_cache) <get_source_lines,
10734         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10735
10736 2019-01-22  Tom Tromey  <tom@tromey.com>
10737
10738         * remote-fileio.h (struct remote_target): Declare.
10739
10740 2019-01-22  Tom Tromey  <tom@tromey.com>
10741
10742         * python/py-arch.c: Do not include py-ref.h.
10743         * python/py-bpevent.c: Do not include py-ref.h.
10744         * python/py-cmd.c: Do not include py-ref.h.
10745         * python/py-continueevent.c: Do not include py-ref.h.
10746         * python/py-event.h: Do not include py-ref.h.
10747         * python/py-evtregistry.c: Do not include py-ref.h.
10748         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10749         * python/py-frame.c: Do not include py-ref.h.
10750         * python/py-framefilter.c: Do not include py-ref.h.
10751         * python/py-function.c: Do not include py-ref.h.
10752         * python/py-infevents.c: Do not include py-ref.h.
10753         * python/py-linetable.c: Do not include py-ref.h.
10754         * python/py-objfile.c: Do not include py-ref.h.
10755         * python/py-param.c: Do not include py-ref.h.
10756         * python/py-prettyprint.c: Do not include py-ref.h.
10757         * python/py-progspace.c: Do not include py-ref.h.
10758         * python/py-symbol.c: Do not include py-ref.h.
10759         * python/py-symtab.c: Do not include py-ref.h.
10760         * python/py-type.c: Do not include py-ref.h.
10761         * python/py-unwind.c: Do not include py-ref.h.
10762         * python/py-utils.c: Do not include py-ref.h.
10763         * python/py-value.c: Do not include py-ref.h.
10764         * python/py-varobj.c: Do not include py-ref.h.
10765         * python/py-xmethods.c: Do not include py-ref.h.
10766         * python/python.c: Do not include py-ref.h.
10767         * varobj.c: Do not include py-ref.h.
10768
10769 2019-01-22  Tom Tromey  <tom@tromey.com>
10770
10771         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10772         keyword for bcache.
10773
10774 2019-01-22  Tom Tromey  <tom@tromey.com>
10775
10776         * compile/compile-cplus-types.c: Remove a comment by #include.
10777
10778 2019-01-22  Tom Tromey  <tom@tromey.com>
10779
10780         * compile/gcc-c-plugin.h: Include compile-internal.h.
10781
10782 2019-01-22  Tom Tromey  <tom@tromey.com>
10783
10784         * stabsread.c (EXTERN): Do not define.
10785         (symnum, next_symbol_text_func, processing_gcc_compilation)
10786         (within_function, global_sym_chain, global_stabs)
10787         (previous_stab_code, this_object_header_files)
10788         (n_this_object_header_files)
10789         (n_allocated_this_object_header_files): Define.
10790         * stabsread.h (EXTERN): Never define.  Use "extern".
10791
10792 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10793
10794         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10795         history_value.
10796
10797 2019-01-21  Tom Tromey  <tom@tromey.com>
10798
10799         * ui-out.c: Fix includes.
10800         * tui/tui-source.c: Fix includes.
10801         * target.c: Fix includes.
10802         * remote.c: Fix includes.
10803         * regcache.c: Fix includes.
10804         * python/py-block.c: Fix includes.
10805         * printcmd.c: Fix includes.
10806         * or1k-tdep.c: Fix includes.
10807         * mi/mi-main.c: Fix includes.
10808         * m32r-tdep.c: Fix includes.
10809         * csky-tdep.c: Fix includes.
10810         * compile/compile-cplus-types.c: Fix includes.
10811         * cli/cli-interp.c: Fix includes.
10812
10813 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10814
10815         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10816         for padding.
10817
10818 2019-01-16  Tom Tromey  <tom@tromey.com>
10819
10820         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10821         earlier.
10822         (struct objfile) <msymbols_range>: Move from top level.
10823         <msymbols>: New method.
10824         (class objfile_msymbols): Remove.
10825         * symtab.c (default_collect_symbol_completion_matches_break_on):
10826         Update.
10827         * symmisc.c (dump_msymbols): Update.
10828         * stabsread.c (scan_file_globals): Update.
10829         * objc-lang.c (info_selectors_command, info_classes_command)
10830         (find_methods): Update.
10831         * minsyms.c (find_solib_trampoline_target): Update.
10832         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10833         * coffread.c (coff_symfile_read): Update.
10834         * ada-lang.c (ada_lookup_simple_minsym)
10835         (ada_collect_symbol_completion_matches): Update.
10836
10837 2019-01-16  Tom Tromey  <tom@tromey.com>
10838
10839         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10840         type.  Remove no-argument constructor.
10841         <iterator::operator++>: Simplify.
10842         <begin>: Update.
10843         <end>: Use minimal_symbol_count.
10844
10845 2019-01-16  Tom Tromey  <tom@tromey.com>
10846
10847         * objfiles.h (struct objfile) <psymtabs>: New method.
10848         (class objfile_psymtabs): Remove.
10849         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10850         typedef.
10851         <range>: New method.
10852         (require_partial_symbols): Change return type.
10853         * psymtab.c (require_partial_symbols)
10854         (psym_expand_symtabs_matching): Update.
10855         * mdebugread.c (parse_partial_symbols): Update.
10856         * dbxread.c (dbx_end_psymtab): Update.
10857
10858 2019-01-15  Tom Tromey  <tom@tromey.com>
10859
10860         * symtab.c (lookup_objfile_from_block)
10861         (lookup_symbol_in_objfile_symtabs)
10862         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10863         (find_line_symtab, info_sources_command)
10864         (default_collect_symbol_completion_matches_break_on)
10865         (make_source_files_completion_list): Update.
10866         * symmisc.c (print_objfile_statistics, dump_objfile)
10867         (maintenance_print_symbols, maintenance_info_symtabs)
10868         (maintenance_check_symtabs, maintenance_info_line_tables):
10869         Update.
10870         * source.c (select_source_symtab)
10871         (forget_cached_source_info_for_objfile): Update.
10872         * objfiles.h (class objfile_compunits): Remove.
10873         (struct objfile) <compunits_range>: New typedef.
10874         (compunits): New method.
10875         * objfiles.c (objfile_relocate1): Update.
10876         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10877         * maint.c (count_symtabs_and_blocks): Update.
10878         * linespec.c (iterate_over_all_matching_symtabs): Update.
10879         * cp-support.c (add_symbol_overload_list_qualified): Update.
10880         * coffread.c (coff_symtab_read): Update.
10881         * ada-lang.c (add_nonlocal_symbols)
10882         (ada_collect_symbol_completion_matches)
10883         (ada_add_global_exceptions): Update.
10884
10885 2019-01-15  Tom Tromey  <tom@tromey.com>
10886
10887         * progspace.h (program_space) <objfiles_safe_range>: New
10888         typedef.
10889         <objfiles_safe>: New method.
10890         * objfiles.h (class all_objfiles_safe): Remove.
10891         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10892         * jit.c (jit_inferior_exit_hook): Update.
10893
10894 2019-01-17  Tom Tromey  <tom@tromey.com>
10895
10896         * progspace.h (program_space) <objfiles_range>: New typedef.
10897         <objfiles>: New method.
10898         <objfiles_head>: Rename from objfiles.
10899         (object_files): Update.
10900         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10901         * guile/scm-pretty-print.c
10902         (ppscm_find_pretty_printer_from_objfiles): Update.
10903         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10904         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10905         Update.
10906         * python/py-progspace.c (pspy_get_objfiles): Update.
10907         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10908         Update.
10909         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10910         (objfpy_lookup_objfile_by_build_id): Update.
10911         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10912         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10913         Update.
10914         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10915         (expand_symtab_containing_pc, lookup_objfile_from_block)
10916         (lookup_static_symbol, basic_lookup_transparent_type)
10917         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10918         (find_line_symtab, info_sources_command)
10919         (default_collect_symbol_completion_matches_break_on)
10920         (make_source_files_completion_list, find_main_name): Update.
10921         * symmisc.c (print_symbol_bcache_statistics)
10922         (print_objfile_statistics, maintenance_print_symbols)
10923         (maintenance_print_msymbols, maintenance_print_objfiles)
10924         (maintenance_info_symtabs, maintenance_check_symtabs)
10925         (maintenance_expand_symtabs, maintenance_info_line_tables):
10926         Update.
10927         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10928         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10929         (map_overlay_command, unmap_overlay_command)
10930         (simple_overlay_update, expand_symtabs_matching)
10931         (map_symbol_filenames): Update.
10932         * symfile-debug.c (set_debug_symfile): Update.
10933         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10934         Update.
10935         * source.c (select_source_symtab, forget_cached_source_info):
10936         Update.
10937         * solib.c (solib_read_symbols): Update.
10938         * solib-spu.c (append_ocl_sos): Update.
10939         * psymtab.c (maintenance_print_psymbols)
10940         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10941         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10942         * printcmd.c (info_symbol_command): Update.
10943         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10944         Update.
10945         * objfiles.h (class all_objfiles): Remove.
10946         * objfiles.c (have_partial_symbols, have_full_symbols)
10947         (have_minimal_symbols, qsort_cmp, update_section_map)
10948         (shared_objfile_contains_address_p)
10949         (default_iterate_over_objfiles_in_search_order): Update.
10950         * objc-lang.c (info_selectors_command, info_classes_command)
10951         (find_methods): Update.
10952         * minsyms.c (find_solib_trampoline_target): Update.
10953         * maint.c (maintenance_info_sections)
10954         (maintenance_translate_address, count_symtabs_and_blocks):
10955         Update.
10956         * main.c (captured_main_1): Update.
10957         * linux-thread-db.c (try_thread_db_load_from_pdir)
10958         (has_libpthread): Update.
10959         * linespec.c (iterate_over_all_matching_symtabs)
10960         (search_minsyms_for_name): Update.
10961         * jit.c (jit_find_objf_with_entry_addr): Update.
10962         * hppa-tdep.c (find_unwind_entry)
10963         (hppa_lookup_stub_minimal_symbol): Update.
10964         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10965         Update.
10966         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10967         (elf_gnu_ifunc_resolve_by_got): Update.
10968         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10969         * dwarf-index-write.c (save_gdb_index_command): Update.
10970         * cp-support.c (add_symbol_overload_list_qualified): Update.
10971         * breakpoint.c (create_overlay_event_breakpoint)
10972         (create_longjmp_master_breakpoint)
10973         (create_std_terminate_master_breakpoint)
10974         (create_exception_master_breakpoint): Update.
10975         * blockframe.c (find_pc_partial_function): Update.
10976         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10977         (ada_collect_symbol_completion_matches)
10978         (ada_add_global_exceptions): Update.
10979
10980 2019-01-17  Tom Tromey  <tom@tromey.com>
10981
10982         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10983         declare VEC.
10984         (solib_target_parse_libraries): Change return type.
10985         (library_list_start_segment, library_list_start_section)
10986         (library_list_end_library, library_list_start_library); Update.
10987         (solib_target_free_library_list): Remove.
10988         (solib_target_parse_libraries): Remove cleanup.  Change return
10989         type.
10990         (solib_target_current_sos): Update.
10991
10992 2019-01-17  Tom Tromey  <tromey@bapiya>
10993
10994         * valprint.c: Replace "the the" with "the".
10995         * symtab.c: Replace "the the" with "the".
10996         * solib.c: Replace "the the" with "the".
10997         * solib-dsbt.c: Replace "the the" with "the".
10998         * linespec.c: Replace "the the" with "the".
10999         * dwarf2loc.h: Replace "the the" with "the".
11000         * amd64-windows-tdep.c: Replace "the the" with "the".
11001         * aarch64-tdep.c: Replace "the the" with "the".
11002
11003 2019-01-16  Keith Seitz  <keiths@redhat.com>
11004
11005         PR gdb/23773
11006         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11007         <builder>: Rename to ..
11008         <m_builder>: ... this and make private.
11009         (dwarf2_cu::get_builder): New method.  Change all users of
11010         `builder' to use this method.
11011         (dwarf2_start_symtab): Move to ...
11012         (dwarf2_cu::start_symtab): ... here.  Update all callers
11013         (setup_type_unit_groups): Move to ...
11014         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11015         callers.
11016         (dwarf2_cu::reset_builder): New method.
11017         (process_full_compunit, process_full_type_unit): Use
11018         dwarf2_cu::reset_builder.
11019         (follow_die_offset): Record the ancestor CU if it is different
11020         from the followed DIE's CU.
11021         (follow_die_sig_1): Likewise.
11022
11023 2019-01-15  Tom Tromey  <tom@tromey.com>
11024
11025         * remote.c (class remote_state) <buf>: Now a char_vector.
11026         <buf_size>: Remove.
11027         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11028         parameter.
11029         (remote_target::getpkt_or_notif_sane_1)
11030         (remote_target::getpkt_sane)
11031         (remote_target::getpkt_or_notif_sane): Likewise.
11032         (class remote_target) <putpkt>: New overload.
11033         (remote_target::read_frame): Change type of "buf_p".  Remove
11034         sizeof_p parameter.
11035         (packet_ok): New overload.
11036         (packet_check_result): New overload.
11037         Update all uses.
11038
11039 2019-01-14  Tom Tromey  <tom@tromey.com>
11040
11041         * remote-notif.c (handle_notification, remote_notif_ack)
11042         (remote_notif_parse): Make "buf" const.
11043         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11044         const.
11045         (remote_notif_parse, remote_notif_ack, handle_notification):
11046         Likewise.
11047         * remote.c (remote_notif_stop_parse): Make "buf" const.
11048         (remote_target::remote_parse_stop_reply): Make "buf" const.
11049         (remote_notif_stop_ack): Make "buf" const.
11050
11051 2019-01-14  Tom Tromey  <tom@tromey.com>
11052
11053         * remote.c (remote_console_output): Make parameter const.
11054
11055 2019-01-14  Tom Tromey  <tom@tromey.com>
11056
11057         * target-debug.h (target_debug_print_signals): Constify.
11058         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11059         * procfs.c (procfs_target::pass_signals): Update.
11060         * linux-nat.c (linux_nat_target::pass_signals): Update.
11061         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11062         * target-delegates.c: Rebuild.
11063         * remote.c (remote_target::program_signals): Update.
11064         (remote_target::pass_signals): Update.
11065         * target.c (target_pass_signals): Constify argument.
11066         (target_program_signals): Likewise.
11067         * target.h (struct target_ops) <pass_signals, program_signals>:
11068         Constify argument.
11069         (target_pass_signals, target_program_signals): Constify argument.
11070
11071 2019-01-14  Tom Tromey  <tom@tromey.com>
11072
11073         PR tui/28819:
11074         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11075
11076 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11077
11078         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11079         field.
11080         * rs6000-tdep.c: Include reggroups.h.
11081         (IS_V_ALIAS_PSEUDOREG): Define.
11082         (rs6000_register_name): Return names for the "vX" aliases.
11083         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11084         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11085         aliases.  Call default_register_reggroup_p for all other
11086         pseudo-registers.
11087         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11088         New functions.
11089         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11090         Handle "vX" aliases.
11091         (v_alias_pseudo_register_collect): New function.
11092         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11093         (rs6000_gdbarch_init): Initialize "vX" aliases as
11094         pseudo-registers.  Restore registration of
11095         rs6000_pseudo_register_reggroup_p with
11096         set_tdesc_pseudo_register_reggroup_p.
11097
11098 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11099
11100         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11101         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11102         set_gdbarch_num_pseudo_regs.
11103
11104 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11105
11106         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11107         Remove arg prefixname, add do_set and do_show.
11108         Add member functions set_list and show_list.
11109         * cli/cli-style.c (class cli_style_option): Update accordingly.
11110         (style_set_list): Move to file scope.
11111         (style_show_list): Likewise.
11112         (set_style): Call help_list.
11113         (show_style): Call cmd_show_list.
11114         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11115         Update to use the new macro.
11116
11117 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11118
11119         * ada-lang.c (_initialize_ada_language): Expand the help text
11120         for the "catch exception" command.
11121
11122 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11123
11124         * symtab.c (matching_obj_sections): Initialize obj,
11125         declare it closer to its usage.
11126
11127 2019-01-10  Tom Tromey  <tom@tromey.com>
11128
11129         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11130         (basic_inf_threads_range): Remove.
11131         (inf_threads_range, inf_non_exited_threads_range)
11132         (safe_inf_threads_range): Use next_adapter.
11133
11134 2019-01-10  Keith Seitz  <keiths@redhat.com>
11135
11136         PR gdb/23712
11137         PR symtab/23010
11138         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11139         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11140
11141 2019-01-10  Keith Seitz  <keiths@redhat.com>
11142
11143         PR gdb/23712
11144         PR symtab/23010
11145         * dictionary.c (pending_to_vector): Remove.
11146         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11147         Remove _1 suffix, replacing functions of the same name.  Update
11148         all callers.
11149         (dict_create_hashed, dict_create_hashed_expandable)
11150         (dict_create_linear, dict_create_linear_expandable, dict_free)
11151         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11152         Make functions static.
11153
11154 2019-01-10  Keith Seitz  <keiths@redhat.com>
11155
11156         PR gdb/23712
11157         PR symtab/23010
11158         * dictionary.h (struct dictionary): Replace declaration with
11159         multidictionary.
11160         (dict_create_hashed, dict_create_hashed_expandable)
11161         (dict_create_linear, dict_create_linear_expandable)
11162         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11163         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11164         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11165         taking multidictionary argument.
11166         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11167         * block.h (struct block) <dict>: Change to multidictionary
11168         and rename `multidict'.
11169         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11170         symmisc.c: Update all dictionary references to multidictionary.
11171
11172 2019-01-10  Keith Seitz  <keiths@redhat.com>
11173
11174         PR gdb/23712
11175         PR symtab/23010
11176         * dictionary.c: Include unordered_map.
11177         (pending_to_vector): New function.
11178         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11179         Rewrite the non-"_1" functions to take vector instead
11180         of linked list.
11181         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11182         "new" _1 versions of the same name.
11183         (multidictionary): Define.
11184         (std::hash<enum language): New definition.
11185         (collate_pending_symbols_by_language, mdict_create_hashed)
11186         (mdict_create_hashed_expandable, mdict_create_linear)
11187         (mdict_create_linear_expandable, mdict_free)
11188         (find_language_dictionary, create_new_language_dictionary)
11189         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11190         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11191         (mdict_size, mdict_empty): New functions.
11192         * dictionary.h (mdict_iterator): Define.
11193
11194 2019-01-10  Pedro Alves  <palves@redhat.com>
11195
11196         * breakpoint.c (read_uploaded_action)
11197         (create_tracepoint_from_upload): Adjust to use
11198         gdb::unique_xmalloc_ptr.
11199         * ctf.c (ctf_write_uploaded_tp):
11200         (SET_ARRAY_FIELD): Use emplace_back.
11201         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11202         * tracefile-tfile.c (tfile_write_uploaded_tp):
11203         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11204         gdb::unique_xmalloc_ptr.
11205         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11206         at_string, cond_string, cmd_strings>: Replace char pointers
11207         with gdb::unique_xmalloc_ptr.
11208
11209 2019-01-10  Pedro Alves  <palves@redhat.com>
11210
11211         * solib-target.c (library_list_start_library): Don't xstrdup name.
11212
11213 2019-01-10  Pedro Alves  <palves@redhat.com>
11214
11215         * mdebugread.c (parse_partial_symbols): Use
11216         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11217
11218 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11219
11220         * linux-fork.c (scoped_switch_fork_info)
11221         <~scoped_switch_fork_info>: Fix incorrect variable name.
11222
11223 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11224
11225         * linux-fork.c (scoped_switch_fork_info)
11226         <scoped_switch_fork_info>: Make explicit.
11227         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11228
11229 2019-01-10  Tom Tromey  <tom@tromey.com>
11230
11231         * objfiles.h (objfile::reset_psymtabs): Update.
11232         * objfiles.c (objfile::objfile): Update.
11233         * psymtab.h (psymtab_storage::obstack): Update.
11234         (psymtab_storage::m_obstack): Use gdb::optional.
11235         (class psymtab_storage): Update comment.  Remove objfile
11236         parameter.
11237         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11238
11239 2019-01-10  Tom Tromey  <tom@tromey.com>
11240
11241         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11242         <free_psymtabs>: Now private.
11243         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11244         (allocate_psymtab): Use new method.
11245
11246 2019-01-10  Tom Tromey  <tom@tromey.com>
11247
11248         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11249         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11250         * mdebugread.c (parse_partial_symbols): Use
11251         allocate_dependencies.
11252         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11253         allocate_dependencies.
11254         (process_psymtab_comp_unit_reader)
11255         (build_type_psymtab_dependencies): Likewise.
11256         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11257
11258 2019-01-10  Tom Tromey  <tom@tromey.com>
11259
11260         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11261         PSYMBOL_SET_LANGUAGE.
11262         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11263
11264 2019-01-10  Tom Tromey  <tom@tromey.com>
11265
11266         * psymtab.h (psymtab_storage::obstack): New method.
11267         <m_obstack>: Rename from obstack; now private.
11268         * psymtab.c (psymtab_storage): Update.
11269         * dwarf2read.c (create_addrmap_from_index)
11270         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11271         Update.
11272
11273 2019-01-10  Tom Tromey  <tom@tromey.com>
11274
11275         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11276         * objfiles.h (objfile::reset_psymtabs): New method.
11277
11278 2019-01-10  Tom Tromey  <tom@tromey.com>
11279
11280         * symmisc.c (print_symbol_bcache_statistics): Update.
11281         (print_objfile_statistics): Update.
11282         * symfile.c (reread_symbols): Update.
11283         * psymtab.h (class psymtab_storage): New.
11284         * psymtab.c (psymtab_storage): New constructor.
11285         (~psymtab_storage): New destructor.
11286         (require_partial_symbols): Update.
11287         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11288         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11289         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11290         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11291         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11292         (start_psymtab_common, end_psymtab_common)
11293         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11294         (allocate_psymtab): Update.
11295         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11296         Update.
11297         (dump_psymtab_addrmap, maintenance_print_psymbols)
11298         (maintenance_check_psymtabs): Update.
11299         (class objfile_psymtabs): Move to objfiles.h.
11300         * psympriv.h (discard_psymtab): Now inline.
11301         (psymtab_discarder::psymtab_discarder): Update.
11302         (psymtab_discarder::~psymtab_discarder): Update.
11303         (ALL_OBJFILE_PSYMTABS): Rewrite.
11304         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11305         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11306         Remove fields.
11307         <partial_symtabs>: New field.
11308         (class objfile_psymtabs): Move from psymtab.h.  Update.
11309         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11310         psymbol_cache.
11311         (objfile::~objfile): Don't destroy psymbol_cache.
11312         * mdebugread.c (parse_partial_symbols): Update.
11313         * dwarf2read.c (create_addrmap_from_index)
11314         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11315         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11316         (add_partial_subprogram, dwarf2_ranges_read): Update.
11317         * dwarf-index-write.c (write_address_map)
11318         (write_one_signatured_type, recursively_write_psymbols)
11319         (class debug_names, class debug_names, write_psymtabs_to_index):
11320         Update.
11321
11322 2019-01-10  Tom Tromey  <tom@tromey.com>
11323
11324         * symtab.h (SYMBOL_SET_NAMES): Update.
11325         (symbol_set_names): Update.
11326         (MSYMBOL_SET_NAMES): Update.
11327         * symtab.c (symbol_set_names): Change argument to be an
11328         objfile_per_bfd_storage.
11329         * psymtab.c (add_psymbol_to_bcache): Update.
11330         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11331
11332 2019-01-10  Tom Tromey  <tom@tromey.com>
11333
11334         * symtab.c (create_demangled_names_hash): Change argument to be an
11335         objfile_per_bfd_storage.
11336         (symbol_set_names): Update.
11337
11338 2019-01-10  Tom Tromey  <tom@tromey.com>
11339
11340         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11341         init_psymbol_list.
11342         * psymtab.c (init_psymbol_list): Do nothing if already called.
11343         * psympriv.h (init_psymbol_list): Add comment.
11344         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11345         init_psymbol_list.
11346         * dbxread.c (dbx_symfile_read): Unconditionally call
11347         init_psymbol_list.
11348
11349 2019-01-10  Tom Tromey  <tom@tromey.com>
11350
11351         * xcoffread.c (scan_xcoff_symtab): Update.
11352         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11353         "where".
11354         * mdebugread.c (parse_partial_symbols)
11355         (handle_psymbol_enumerators): Update.
11356         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11357         * dbxread.c (read_dbx_symtab): Update.
11358         * psympriv.h (psymbol_placement): New enum.
11359         (add_psymbol_to_list): Update.
11360
11361 2019-01-10  Tom Tromey  <tom@tromey.com>
11362
11363         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11364         static_psymbols parameters.
11365         (scan_xcoff_symtab): Update.
11366         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11367         static_psymbols parameters.
11368         * psympriv.h (start_psymtab_common): Update.
11369         * mdebugread.c (parse_partial_symbols): Update.
11370         * dwarf2read.c (create_partial_symtab): Update.
11371         * dbxread.c (read_dbx_symtab): Update.
11372         (start_psymtab): Remove global_psymbols and static_psymbols
11373         parameters.
11374
11375 2019-01-10  Tom Tromey  <tom@tromey.com>
11376
11377         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11378         * psymtab.c (allocate_psymtab): Add comment.
11379         * psympriv.h (allocate_psymtab): Add comment.
11380         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11381         initializations.
11382         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11383
11384 2019-01-10  Tom Tromey  <tom@tromey.com>
11385
11386         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11387         Don't declare.
11388         * mipsread.c: Include mdebugread.h.
11389         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11390         Declare.
11391         * elfread.c: Include mdebugread.h.
11392
11393 2019-01-09  Tom Tromey  <tom@tromey.com>
11394
11395         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11396         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11397         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11398         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11399         (psym_lookup_symbol, psym_find_last_source_symtab)
11400         (psym_forget_cached_source_info, psym_print_stats)
11401         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11402         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11403         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11404         (psym_find_compunit_symtab_by_address)
11405         (maintenance_print_psymbols, maintenance_info_psymtabs)
11406         (maintenance_check_psymtabs): Use ranged for.
11407         * psymtab.h (class objfile_psymtabs): New.
11408         (require_partial_symbols): Return objfile_psymtabs.
11409         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11410
11411 2019-01-09  Tom Tromey  <tom@tromey.com>
11412
11413         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11414         (find_pc_mapped_section, list_overlays_command)
11415         (map_overlay_command, unmap_overlay_command)
11416         (simple_overlay_update): Use all_objfiles.
11417         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11418         * printcmd.c (info_symbol_command): Use all_objfiles.
11419         * objfiles.h (ALL_OBJSECTIONS): Remove.
11420         * maint.c (maintenance_translate_address): Use all_objfiles.
11421         * gcore.c (gcore_create_callback): Use all_objfiles.
11422         (objfile_find_memory_regions): Likewise.
11423
11424 2019-01-09  Tom Tromey  <tom@tromey.com>
11425
11426         * symtab.c (find_line_symtab, info_sources_command)
11427         (make_source_files_completion_list): Use objfile_compunits.
11428         * source.c (select_source_symtab): Use objfile_compunits.
11429         * objfiles.h (struct objfile): Update comment.
11430         (ALL_OBJFILES): Remove.
11431         (ALL_FILETABS): Remove.
11432         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11433         objfile_compunits.
11434
11435 2019-01-09  Tom Tromey  <tom@tromey.com>
11436
11437         * symmisc.c (print_objfile_statistics, dump_objfile)
11438         (maintenance_print_symbols): Use compunit_filetabs.
11439         * source.c (forget_cached_source_info_for_objfile): Use
11440         compunit_filetabs.
11441         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11442         (ALL_FILETABS): Use compunit_filetabs.
11443         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11444         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11445
11446 2019-01-09  Tom Tromey  <tom@tromey.com>
11447
11448         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11449         (compunit_filetabs): New.
11450         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11451         compunit_filetabs.
11452         (info_sources_command, make_source_files_completion_list): Remove
11453         declaration.
11454         * symmisc.c (print_objfile_statistics, dump_objfile)
11455         (maintenance_print_symbols): Remove declaration.
11456         (maintenance_info_symtabs): Use compunit_filetabs.
11457         (maintenance_info_line_tables): Likewise.
11458         * source.c (select_source_symtab): Change local variable name.
11459         (forget_cached_source_info_for_objfile): Remove declaration.
11460         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11461         * objfiles.c (objfile_relocate1): Remove declaration.
11462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11463         declaration.
11464         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11465         * coffread.c (coff_symtab_read): Remove declaration.
11466         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11467         compunit_filetabs.
11468
11469 2019-01-09  Tom Tromey  <tom@tromey.com>
11470
11471         * symtab.c (lookup_objfile_from_block)
11472         (find_pc_sect_compunit_symtab, search_symbols)
11473         (default_collect_symbol_completion_matches_break_on): Use
11474         objfile_compunits.
11475         * objfiles.h (ALL_COMPUNITS): Remove.
11476         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11477         * cp-support.c (add_symbol_overload_list_qualified): Use
11478         objfile_compunits.
11479         * ada-lang.c (ada_collect_symbol_completion_matches)
11480         (ada_add_global_exceptions): Use objfile_compunits.
11481
11482 2019-01-09  Tom Tromey  <tom@tromey.com>
11483
11484         * source.c (select_source_symtab)
11485         (forget_cached_source_info_for_objfile): Remove declaration.
11486         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11487         declaration.
11488         * maint.c (count_symtabs_and_blocks): Remove declaration.
11489         * cp-support.c (add_symbol_overload_list_qualified): Remove
11490         declaration.
11491         * coffread.c (coff_symtab_read): Remove declaration.
11492         * symtab.c (lookup_symbol_in_objfile_symtabs)
11493         (basic_lookup_transparent_type_1): Use objfile_compunits.
11494         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11495         (info_sources_command, search_symbols)
11496         (default_collect_symbol_completion_matches_break_on)
11497         (make_source_files_completion_list): Remove declaration.
11498         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11499         (ada_collect_symbol_completion_matches)
11500         (ada_add_global_exceptions): Remove declaration.
11501         * linespec.c (iterate_over_all_matching_symtabs): Use
11502         objfile_compunits.
11503         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11504         (class objfile_compunits): New.
11505         (ALL_COMPUNITS): Use objfile_compunits.
11506         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11507         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11508         objfile_compunits.
11509         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11510
11511 2019-01-09  Tom Tromey  <tom@tromey.com>
11512
11513         * symtab.c (search_symbols)
11514         (default_collect_symbol_completion_matches_break_on): Use
11515         objfile_msymbols.
11516         * ada-lang.c (ada_lookup_simple_minsym)
11517         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11518         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11519         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11520         objfile_msymbols.
11521         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11522         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11523         * objc-lang.c (find_methods): Use objfile_msymbols.
11524         (info_selectors_command, info_classes_command): Likewise.
11525         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11526         * objfiles.h (class objfile_msymbols): New.
11527         (ALL_OBJFILE_MSYMBOLS): Remove.
11528         (ALL_MSYMBOLS): Remove.
11529
11530 2019-01-09  Tom Tromey  <tom@tromey.com>
11531
11532         * common/next-iterator.h (next_adapter): Add Iterator template
11533         parameter.
11534         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11535         (class all_objfiles_safe): New.
11536         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11537         * objfiles.c (put_objfile_before): Update comment.
11538         (add_separate_debug_objfile): Likewise.
11539         (free_all_objfiles): Use all_objfiles_safe.
11540         (objfile_purge_solibs): Likewise.
11541
11542 2019-01-09  Tom Tromey  <tom@tromey.com>
11543
11544         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11545         (expand_symtab_containing_pc, lookup_static_symbol)
11546         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11547         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11548         all_objfiles.
11549         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11550         * breakpoint.c (create_overlay_event_breakpoint)
11551         (create_longjmp_master_breakpoint)
11552         (create_std_terminate_master_breakpoint)
11553         (create_exception_master_breakpoint): Use all_objfiles.
11554         * linux-thread-db.c (try_thread_db_load_from_pdir)
11555         (has_libpthread): Use all_objfiles.
11556         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11557         * linespec.c (iterate_over_all_matching_symtabs)
11558         (search_minsyms_for_name): Use all_objfiles.
11559         * maint.c (maintenance_info_sections): Use all_objfiles.
11560         * main.c (captured_main_1): Use all_objfiles.
11561         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11562         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11563         * guile/scm-pretty-print.c
11564         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11565         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11566         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11567         (maintenance_print_msymbols): Use all_objfiles.
11568         * source.c (select_source_symtab): Use all_objfiles.
11569         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11570         * symfile.c (remove_symbol_file_command)
11571         (expand_symtabs_matching, map_symbol_filenames): Use
11572         all_objfiles.
11573         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11574         all_objfiles.
11575         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11576         * objc-lang.c (find_methods): Use all_objfiles.
11577         * objfiles.c (have_partial_symbols, have_full_symbols)
11578         (have_minimal_symbols, qsort_cmp)
11579         (default_iterate_over_objfiles_in_search_order): Use
11580         all_objfiles.
11581         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11582         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11583         (maintenance_check_psymtabs): Use all_objfiles.
11584         (ALL_PSYMTABS): Remove.
11585         * compile/compile-object-run.c (do_module_cleanup): Use
11586         all_objfiles.
11587         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11588         * cp-support.c (add_symbol_overload_list_qualified): Use
11589         all_objfiles.
11590         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11591         Use all_objfiles.
11592         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11593         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11594         all_objfiles.
11595         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11596         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11597         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11598         Uses all_objfiles.
11599         * solib.c (solib_read_symbols): Use all_objfiles
11600
11601 2019-01-09  Tom Tromey  <tom@tromey.com>
11602
11603         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11604         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11605         all_objfiles.
11606         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11607         * symmisc.c (print_symbol_bcache_statistics)
11608         (print_objfile_statistics, maintenance_print_objfiles)
11609         (maintenance_info_symtabs, maintenance_check_symtabs)
11610         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11611         all_objfiles.
11612         * source.c (forget_cached_source_info): Use all_objfiles.
11613         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11614         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11615         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11616         * objfiles.c (update_section_map): Use all_objfiles.
11617         (shared_objfile_contains_address_p): Likewise.
11618         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11619         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11620
11621 2019-01-09  Tom Tromey  <tom@tromey.com>
11622
11623         * common/next-iterator.h: New file.
11624         * objfiles.h (class all_objfiles): New.
11625         (struct objfile_iterator): New.
11626
11627 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11628
11629         * NEWS: Move the description of the changed "frame", "select-frame",
11630          and "info frame" commands to the Changed commands section.
11631
11632 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11633
11634         * gdbtypes.c (check_stub_method_group): Remove handling of old
11635         mangling schemes.
11636         * linespec.c (find_methods): Likewise.
11637         * stabsread.c (read_member_functions): Likewise.
11638         * valops.c (search_struct_method): Likewise.
11639         (value_struct_elt_for_reference): Likewise.
11640         * NEWS: Mention this change.
11641
11642 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11643
11644         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11645         print_source_lines.
11646         * source.c (print_source_lines_base): Update line number check.
11647         (print_source_lines): New function.
11648         (source_lines_range::source_lines_range): New function.
11649         * source.h (class source_lines_range): New class.
11650         (print_source_lines): New declaration.
11651
11652 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11653
11654         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11655
11656 2019-01-08  Tom Tromey  <tom@tromey.com>
11657             Simon Marchi  <simon.marchi@ericsson.com>
11658
11659         PR gdb/24060
11660         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11661         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11662         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11663         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11664         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11665         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11666
11667 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11668
11669         * source.c (select_source_symtab): Move header comment to
11670         declaration in source.h.
11671         (forget_cached_source_info_for_objfile): Likewise.
11672         (forget_cached_source_info): Likewise.
11673         (identify_source_line): Likewise.
11674         * source.h (identify_source_line): Move declaration from symtab.h
11675         and add comment from source.c
11676         (print_source_lines): Likewise.
11677         (forget_cached_source_info_for_objfile): Likewise.
11678         (forget_cached_source_info): Likewise.
11679         (select_source_symtab): Likewise.
11680         (enum print_source_lines_flag): Move definition from symtab.h.
11681         * symtab.h (identify_source_line): Move declaration to source.h.
11682         (print_source_lines): Likewise.
11683         (forget_cached_source_info_for_objfile): Likewise.
11684         (forget_cached_source_info): Likewise.
11685         (select_source_symtab): Likewise.
11686         (enum print_source_lines_flag): Move definition to source.h.
11687         * tui/tui-hooks.c: Add 'source.h' include.
11688
11689 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11690
11691         * source.c (print_source_lines_base): Handle requests to print
11692         reverse line number sequences, and guard against empty lines
11693         string.
11694
11695 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11696
11697         * source.c (print_source_lines_base): Fix skip of '\r' if next
11698         character is '\n'.
11699
11700 2019-01-06  Tom Tromey  <tom@tromey.com>
11701
11702         * c-exp.y (struct c_parse_state) <macro_original_text,
11703         expansion_obstack>: New member.
11704         (macro_original_text, expansion_obstack): Remove globals.
11705         (scan_macro_expansion, scanning_macro_expansion)
11706         (finished_macro_expansion): Update.
11707         (scan_macro_cleanup): Remove.
11708         (yylex, c_parse): Update.
11709
11710 2019-01-06  Tom Tromey  <tom@tromey.com>
11711
11712         * c-exp.y (struct c_parse_state) <strings>: New member.
11713         (operator_stoken): Update.
11714
11715 2019-01-06  Tom Tromey  <tom@tromey.com>
11716
11717         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11718         (union type_stack_elt) <typelist_val>: Now a pointer to
11719         std::vector.
11720         (type_stack_cleanup): Don't declare.
11721         (push_typelist): Update.
11722         * parse.c (pop_typelist): Return a std::vector.
11723         (push_typelist): Take a std::vector.
11724         (follow_types): Update.  Do not free args.
11725         (type_stack_cleanup): Remove.
11726         * c-exp.y (struct c_parse_state): New.
11727         (cpstate): New global.
11728         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11729         (nonempty_typelist): Update.
11730         (func_mod): Create a new vector.
11731         (c_parse): Create a c_parse_state.
11732         (check_parameter_typelist): Do not delete params.
11733         (function_method): Update.  Do not delete type_list.
11734
11735 2019-01-06  Tom Tromey  <tom@tromey.com>
11736
11737         PR gdb/28155:
11738         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11739         check_typedef.
11740         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11741         (print_return_value): Likewise.
11742
11743 2019-01-05  Tom Tromey  <tom@tromey.com>
11744
11745         * contrib/cleanup_check.py: Remove.
11746         * contrib/gcc-with-excheck: Remove.
11747         * contrib/exsummary.py: Remove.
11748         * contrib/excheck.py: Remove.
11749
11750 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11751
11752         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11753         NULL. Initialize tpprev to NULL instead of assigning it
11754         to NULL on the next statement.
11755         * windows-nat.c (windows_delete_thread): Remove check for
11756         main_thread_id before printing thread exit notifications.
11757         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11758         Remove thread ID check against main_thread_id.
11759         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11760         windows_delete_thread.
11761         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11762
11763 2019-01-04  Tom Tromey  <tom@tromey.com>
11764
11765         * compile/compile.c (_initialize_compile): Use upper case for
11766         metasyntactic variables.
11767         * symmisc.c (_initialize_symmisc): Use upper case for
11768         metasyntactic variables.
11769         * psymtab.c (_initialize_psymtab): Use upper case for
11770         metasyntactic variables.
11771         * demangle.c (demangle_command): Use upper case for metasyntactic
11772         variables.
11773         (_initialize_demangler): Likewise.
11774         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11775         variables.
11776
11777 2019-01-03  Tom Tromey  <tom@tromey.com>
11778
11779         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11780
11781 2019-01-03  Tom Tromey  <tom@tromey.com>
11782
11783         * python/py-symtab.c (salpy_str): Update.
11784         (struct salpy_sal_object) <symtab>: Now a PyObject.
11785         (salpy_dealloc): Update.
11786         (del_objfile_sal): Use gdbpy_ref.
11787
11788 2019-01-03  Tom Tromey  <tom@tromey.com>
11789
11790         * python/py-type.c (convert_field): Use new_reference.  Return
11791         gdbpy_ref.
11792         (make_fielditem): Return gdbpy_ref.
11793         (typy_fields): Update.
11794         (typy_getitem): Update.
11795         (field_name): Return gdbpy_ref.  Use new_reference.
11796         (typy_iterator_iternext): Update.
11797
11798 2019-01-03  Tom Tromey  <tom@tromey.com>
11799
11800         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11801
11802 2019-01-03  Tom Tromey  <tom@tromey.com>
11803
11804         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11805         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11806         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11807         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11808         (pspy_set_type_printers): Likewise.
11809         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11810         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11811         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11812         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11813         (objfpy_set_type_printers): Likewise.
11814
11815 2019-01-03  Tom Tromey  <tom@tromey.com>
11816
11817         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11818         (gdbpy_print_stack): Use gdbpy_err_fetch.
11819         * python/python-internal.h (class gdbpy_err_fetch): New class.
11820         (class gdbpy_enter) <m_error_type, m_error_value,
11821         m_error_traceback>: Remove.
11822         <m_error>: New member.
11823         (gdbpy_exception_to_string): Don't declare.
11824         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11825         * python/py-value.c (convert_value_from_python): Use
11826         gdbpy_err_fetch.
11827         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11828         gdbpy_exception_to_string.
11829         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11830         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11831         gdbpy_err_fetch.
11832
11833 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11834
11835         * linux-nat.c (delete_lwp_cleanup): Delete.
11836         (struct lwp_deleter): New struct.
11837         (lwp_info_up): New typedef.
11838         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11839         lwp_info_up.
11840
11841 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * linux-fork.c (class scoped_switch_fork_info): New class.
11844         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11845
11846 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11847
11848         * valops.c (find_overload_match): Remove use of null_cleanup, and
11849         calls to do_cleanups.
11850
11851 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11852
11853         * compile/compile-cplus-types.c
11854         (compile_cplus_instance::decl_name): Handle changes to
11855         cp_func_name.
11856         * cp-support.c (cp_func_name): Update header comment, update
11857         return type.
11858         * cp-support.h (cp_func_name): Update return type in declaration.
11859         * valops.c (find_overload_match): Move temp_func local to top
11860         level of function and change its type.  Use temp_func to hold and
11861         delete temporary string obtained from cp_func_name.
11862
11863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11864
11865         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11866         gdb::char_vector, remove cleanup, and update uses of `msg`.
11867
11868 2019-01-03  Jim Wilson  <jimw@sifive.com>
11869
11870         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11871
11872 2019-01-02  Tom Tromey  <tom@tromey.com>
11873
11874         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11875         (tdesc_parse_xml): Remove cleanups.
11876         * target-descriptions.h (make_cleanup_free_target_description):
11877         Don't declare.
11878         (target_desc_deleter): New struct.
11879         (target_desc_up): New typedef.
11880         * target-descriptions.c (target_desc_deleter::operator()): Rename
11881         from free_target_description.
11882         (make_cleanup_free_target_description): Remove.
11883
11884 2019-01-02  Tom Tromey  <tom@tromey.com>
11885
11886         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11887         constructor, destructor.
11888         (linespec_parser): Remove typedef.
11889         (~linespec_parser): Rename from linespec_parser_delete.
11890         (linespec_lex_to_end, linespec_complete_label)
11891         (linespec_complete): Update.
11892         (decode_line_full): Remove cleanups.
11893         (decode_line_1): Update.
11894
11895 2019-01-02  Tom Tromey  <tom@tromey.com>
11896
11897         * python/python-internal.h (inferior_to_inferior_object): Change
11898         return type.
11899         * python/py-exitedevent.c (create_exited_event_object): Update.
11900         * python/py-inferior.c (inferior_to_inferior_object): Return
11901         gdbpy_ref.
11902         (python_new_inferior, python_inferior_deleted)
11903         (thread_to_thread_object, delete_thread_object)
11904         (build_inferior_list, gdbpy_selected_inferior): Update.
11905         * python/py-infthread.c (create_thread_object): Update.  Also fail
11906         if inferior_to_inferior_object fails.
11907
11908 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11909
11910         * inferior.h (class inferior) <displaced_step_state>: New field.
11911         * infrun.h (struct displaced_step_state): Move here from
11912         infrun.c.  Initialize fields, add constructor.
11913         <inf>: Remove field.
11914         <reset>: New method.
11915         * infrun.c (struct displaced_step_inferior_state): Move to
11916         infrun.h.
11917         (displaced_step_inferior_states): Remove.
11918         (get_displaced_stepping_state): Adust.
11919         (displaced_step_in_progress_any_inferior): Adjust.
11920         (displaced_step_in_progress_thread): Adjust.
11921         (displaced_step_in_progress): Adjust.
11922         (add_displaced_stepping_state): Remove.
11923         (get_displaced_step_closure_by_addr): Adjust.
11924         (remove_displaced_stepping_state): Remove.
11925         (infrun_inferior_exit): Call displaced_step_state.reset.
11926         (use_displaced_stepping): Don't check for NULL.
11927         (displaced_step_prepare_throw): Call
11928         get_displaced_stepping_state.
11929         (displaced_step_fixup): Don't check for NULL.
11930         (prepare_for_detach): Don't check for NULL.
11931
11932 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11933
11934         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11935          in case of call that did not complete.
11936
11937 2019-01-02  Andrey Utkin  <autkin@undo.io>
11938
11939         * symfile.c (find_separate_debug_file): Fix search of debug files for
11940         remote debuggee.
11941
11942 2019-01-02  Tom Tromey  <tom@tromey.com>
11943
11944         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11945         indentation.
11946         * python/py-frame.c (frapy_older): Remove cast.
11947         (frapy_newer): Likewise.
11948         * python/py-breakpoint.c (local_setattro): Remove cast.
11949         * python/py-arch.c (archpy_name): Remove local variable.
11950         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11951
11952 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11953
11954         * unittests/basic_string_view/element_access/char/empty.cc:
11955         Fix year range in copyright header.
11956
11957 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11958
11959         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11960         Delete.
11961         <operator==>: Update with for removed field.
11962         <hash>: Likewise.
11963         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11964         <isa_features>: ...this.
11965         <abi_features>: New field.
11966         (riscv_isa_flen): Update comment.
11967         (riscv_abi_xlen): New declaration.
11968         (riscv_abi_flen): New declaration.
11969         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11970         isa_features.
11971         (riscv_abi_xlen): New function.
11972         (riscv_isa_flen): Update to get answer from isa_features.
11973         (riscv_abi_flen): New function.
11974         (riscv_has_fp_abi): Update to get answer from abi_features.
11975         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11976         xlen and flen.
11977         (riscv_call_info) <xlen, flen>: Update comment.
11978         (riscv_call_arg_struct): Remove invalid assertions
11979         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11980         is removed.
11981         (riscv_gdbarch_init): Gather isa features and abi features
11982         separately, ensure both match on the gdbarch when reusing an old
11983         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11984         a target with 64-bit float hardware.
11985
11986 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11987
11988         * source.c (search_command_helper): Stop reverse search
11989         when line 1 has been searched.
11990
11991 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11992
11993         * record-full.c (record_full_base_target::close): Rewrite
11994         record_full_core_buf_list free logic.
11995
11996 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11997
11998         * break-catch-syscall.c (print_one_catch_syscall): xfree
11999         the last text.
12000
12001 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12002
12003         * top.c (print_gdb_version): Update Copyright year in version
12004         message.
12005
12006 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12007
12008         Update copyright year range in all GDB files.
12009
12010 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12011
12012         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12013
12014 For older changes see ChangeLog-2018.
12015 \f
12016 Local Variables:
12017 mode: change-log
12018 left-margin: 8
12019 fill-column: 74
12020 version-control: never
12021 coding: utf-8
12022 End:
12023